1 2004-10-18 Raja R Harinath <rharinath@novell.com>
3 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
6 2004-10-17 John Luke <john.luke@gmail.com>
8 * class.cs (Operator.GetSignatureForError): use CSharpName
10 * parameter.cs (Parameter.GetSignatureForError): Returns
11 correct name even if was not defined.
13 2004-10-13 Raja R Harinath <rharinath@novell.com>
16 * class.cs (TypeContainer.EmitContext): New property.
17 (DefineNestedTypes): Create an emitcontext for each part.
18 (MethodCore.DoDefineParameters): Use container's emitcontext.
19 Pass type array to InternalParameters.
20 (MemberBase.DoDefine): Use container's emitcontext.
21 (FieldMember.Define): Likewise.
22 (Event.Define): Likewise.
23 (SetMethod.GetParameterInfo): Change argument to EmitContext.
24 Pass type array to InternalParameters.
25 (SetIndexerMethod.GetParameterInfo): Likewise.
26 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
27 * delegate.cs (Define): Pass emitcontext to
28 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
29 array to InternalParameters.
30 * expression.cs (ParameterReference.DoResolveBase): Pass
31 emitcontext to GetParameterInfo.
32 (ComposedCast.DoResolveAsTypeStep): Remove check on
34 * parameter.cs (Parameter.Resolve): Change argument to
35 EmitContext. Use ResolveAsTypeTerminal.
36 (Parameter.GetSignature): Change argument to EmitContext.
37 (Parameters.ComputeSignature): Likewise.
38 (Parameters.ComputeParameterTypes): Likewise.
39 (Parameters.GetParameterInfo): Likewise.
40 (Parameters.ComputeAndDefineParameterTypes): Likewise.
41 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
42 * support.cs (InternalParameters..ctor): Remove variant that takes
44 * typemanager.cs (system_intptr_expr): New.
45 (InitExpressionTypes): Initialize it.
47 2004-10-12 Chris Toshok <toshok@ximian.com>
49 * cs-parser.jay: fix location for try_statement and catch_clause.
51 2004-10-18 Martin Baulig <martin@ximian.com>
53 * class.cs (FieldMember.Define): Don't access the TypeExpr's
54 `Type' directly, but call ResolveType() on it.
55 (MemberBase.DoDefine): Likewise.
57 * expression.cs (New.DoResolve): Don't access the TypeExpr's
58 `Type' directly, but call ResolveType() on it.
59 (ComposedCast.DoResolveAsTypeStep): Likewise.
61 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
62 `Type' directly, but call ResolveType() on it.
64 2004-10-07 Raja R Harinath <rharinath@novell.com>
66 More DeclSpace.ResolveType avoidance.
67 * decl.cs (MemberCore.InUnsafe): New property.
68 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
69 with newly created EmitContext.
70 (FieldMember.Define): Likewise.
71 * delegate.cs (Delegate.Define): Likewise.
72 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
73 only if normal name-lookup fails.
74 (TypeExpr.DoResolve): Enable error-checking.
75 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
76 (SizeOf.DoResolve): Likewise.
77 (ComposedCast.DoResolveAsTypeStep): Likewise.
78 (StackAlloc.DoResolve): Likewise.
79 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
80 (Block.Unsafe): New property.
81 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
82 (Unsafe): Set 'unsafe' flag of contained block.
83 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
84 (Fixed.Resolve): Likewise.
85 (Catch.Resolve): Likewise.
86 (Using.ResolveLocalVariableDecls): Likewise.
87 (Foreach.Resolve): Likewise.
89 2004-10-05 John Luke <john.luke@gmail.com>
91 * cs-parser.jay: add location to error CS0175
93 2004-10-04 Miguel de Icaza <miguel@ximian.com>
95 * ecore.cs (Expression.Constantity): Add support for turning null
98 * const.cs (Const.Define): Allow constants to be reference types
99 as long as the value is Null.
101 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
103 * namespace.cs (NamespaceEntry.Using): No matter which warning
104 level is set, check if this namespace name has already been added.
106 2004-10-03 Ben Maurer <bmaurer@ximian.com>
108 * expression.cs: reftype [!=]= null should always use br[true,false].
111 2004-10-03 Marek Safar <marek.safar@seznam.cz>
114 * attribute.cs: Enum conversion moved to
115 GetAttributeArgumentExpression to be applied to the all
118 2004-10-01 Raja R Harinath <rharinath@novell.com>
120 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
121 * class.c (TypeContainer.DefineType): Flag error if
122 base types aren't accessible due to access permissions.
123 * decl.cs (DeclSpace.ResolveType): Move logic to
124 Expression.ResolveAsTypeTerminal.
125 (DeclSpace.ResolveTypeExpr): Thin layer over
126 Expression.ResolveAsTypeTerminal.
127 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
128 Refactor code into NestedAccess. Use it.
129 (DeclSpace.NestedAccess): New.
130 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
131 argument to silence errors. Check access permissions.
132 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
133 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
134 (Cast.DoResolve): Likewise.
135 (New.DoResolve): Likewise.
136 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
137 (TypeOf.DoResolve): Likewise.
139 * expression.cs (Invocation.BetterConversion): Return the Type of
140 the better conversion. Implement section 14.4.2.3 more faithfully.
141 (Invocation.BetterFunction): Make boolean. Make correspondence to
142 section 14.4.2.2 explicit.
143 (Invocation.OverloadResolve): Update.
144 (Invocation): Remove is_base field.
145 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
146 (Invocation.Emit): Likewise.
148 2004-09-24 Marek Safar <marek.safar@seznam.cz>
150 * cs-parser.jay: Reverted 642 warning fix.
152 2004-09-23 Marek Safar <marek.safar@seznam.cz>
155 * decl.cs (FindMemberWithSameName): Indexer can have more than
158 2004-09-23 Marek Safar <marek.safar@seznam.cz>
160 * expression.cs (LocalVariableReference.DoResolveLValue):
161 Do not report warning 219 for out values.
162 (EmptyExpression.Null): New member to avoid extra allocations.
164 2004-09-23 Marek Safar <marek.safar@seznam.cz>
166 * cs-parser.jay: Fix wrong warning 642 report.
168 * cs-tokenizer.cs (CheckNextToken): New helper;
169 Inspect next character if is same as expected.
171 2004-09-23 Martin Baulig <martin@ximian.com>
173 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
174 (Convert.ImplicitReferenceConversionExists): Likewise.
176 2004-10-13 Martin Baulig <martin@ximian.com>
178 * generic.cs (TypeManager.InflatedConstraints): New nested class.
179 (TypeParameter.DefineType): If we're a method type parameter and
180 that method is overriding something, "inflate" its constraints.
182 2004-10-12 Martin Baulig <martin@ximian.com>
184 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
185 and have type arguments, create and resolve a ConstructedType.
187 2004-10-12 Martin Baulig <martin@ximian.com>
189 * decl.cs (MemberCache.FindMemberToOverride): Use
190 TypeManager.IsEqual() to compare the parameters and Type.Equals()
191 to compare the invocationType.
193 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
194 When comparing two type parameters, only do the signature-only
195 comparision for method type parameters.
197 2004-10-11 Martin Baulig <martin@ximian.com>
199 * report.cs: Don't make --fatal abort on warnings, we have
200 -warnaserror for that.
202 2004-10-11 Martin Baulig <martin@ximian.com>
205 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
206 (TypeManager.IsEqual): Call ourself recursively instead of using
209 2004-10-11 Martin Baulig <martin@ximian.com>
211 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
212 on our own type parameters, not on the ones we inherit from a containing
215 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
218 * generic.cs (TypeParameter.Define): We may only be called once.
220 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
221 instead of TypeManager.IsEqual().
223 2004-09-28 Martin Baulig <martin@ximian.com>
226 (GenericConstraints.EffectiveBaseClass): New public property.
227 (TypeParameter.GenericConstraints): New public property.
228 (ConstructedType.CheckConstraints): Improved.
230 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
231 (Convert.TypeParameterConversion): New private method; use this in
232 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
233 for all conversions related to type parameters.
235 2004-09-24 Martin Baulig <martin@ximian.com>
237 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
238 type parameter conversions for type parameters which are known to
241 2004-09-24 Martin Baulig <martin@ximian.com>
243 * generic.cs (GenericConstraints): Added `IsReferenceType' and
244 `IsValueType' properties.
246 * support.cs (ReflectionConstraints): Use
247 Type.GetGenericParameterConstraints() instead of the old hack.
249 2004-09-24 Martin Baulig <martin@ximian.com>
251 * generic.cs (GenericConstraints): Moved here and made it an
254 * support.cs (GenericConstraints): Moved to generic.cs.
256 2004-09-24 Martin Baulig <martin@ximian.com>
259 (ReflectionConstraints): Un-nested this class and made it public.
262 (TypeManager.GetTypeParameterConstraints): New public method.
263 (TypeManager.HasConstructorConstraint): Use the attributes.
265 2004-09-24 Martin Baulig <martin@ximian.com>
267 * support.cs (GenericConstraints): Replaced `HasConstructor',
268 `IsReferenceType' and `IsValueType' with `Attributes'.
269 (ReflectionParameters.ReflectionConstraints): Removed the Create()
270 method and made the .ctor public.
272 * generic.cs (Constraints.Attributes): New public property.
273 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
274 `IsReferenceType' -> `HasReferenceTypeConstraint' and
275 `IsValueType' -> `HasValueTypeConstraint'.
277 2004-09-23 Martin Baulig <martin@ximian.com>
279 * generic.cs (Constraints): Reflect latest runtime changes.
281 2004-09-23 Martin Baulig <martin@ximian.com>
283 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
284 (Convert.ImplicitReferenceConversionExists): Likewise.
286 2004-09-23 Marek Safar <marek.safar@seznam.cz>
288 * class.cs (Operator.Define): Add error 448 and 559 report.
290 2004-09-22 Marek Safar <marek.safar@seznam.cz>
292 * class.cs (MemberBase.IsTypePermitted): New protected
293 method for checking error CS0610.
295 2004-09-22 Marek Safar <marek.safar@seznam.cz>
297 * class.cs (TypeContainer.HasExplicitLayout): New property
298 Returns whether container has StructLayout attribute set Explicit.
299 (FieldMember): New abstract class for consts and fields.
300 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
301 (Field): Reuse FieldMember.
303 * const.cs (Const): Reuse FieldMember.
305 * rootcontext.cs: EmitConstants call moved to class.
307 2004-09-22 Martin Baulig <martin@ximian.com>
309 Marek and me just fixed one of our oldest bugs: #28562 :-)
311 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
313 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
314 we're an EnumConstant, just return that.
315 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
316 an EnumConstant. In this case, we need to use GetValueAsEnumType()
317 to get the value which'll actually be written into the attribute.
318 However, we have to use GetValue() to access the attribute's value
321 2004-09-22 Marek Safar <marek.safar@seznam.cz>
323 * constant.cs (Constant.IsNegative): New abstract property
326 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
327 (StackAlloc.DoResolve): Reused IsNegative.
329 2004-09-22 Martin Baulig <martin@ximian.com>
331 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
332 public method; like LookupTypeContainer, but also works for
335 * report.cs (Report.SymbolRelatedToPreviousError): Use
336 TypeManager.LookupGenericTypeContainer().
338 2004-09-22 Martin Baulig <martin@ximian.com>
340 Thanks to Peter Sestoft for this bug report.
342 * expression.cs (Conditional): If both the `trueExpr' and the
343 `falseExpr' is a NullLiteral, return a NullLiteral.
345 2004-09-22 Martin Baulig <martin@ximian.com>
347 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
348 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
349 for the "get_Current" call.
351 2004-09-21 Martin Baulig <martin@ximian.com>
353 * convert.cs (Convert.ImplicitReferenceConversion): When
354 converting to an interface type, first check whether we're
355 converting from a reference type.
357 2004-09-14 Martin Baulig <martin@ximian.com>
359 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
361 2004-09-14 Marek Safar <marek.safar@seznam.cz>
364 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
365 called and is obsolete then this member suppress message
366 when call is inside next [Obsolete] method or type.
368 * expression.cs: Use TestObsoleteMethodUsage member.
370 2004-09-14 Martin Baulig <martin@ximian.com>
372 * genericparser.cs: Removed.
374 2004-09-13 Marek Safar <marek.safar@seznam.cz>
376 * class.cs (MethodCore.CheckBase): Fix bug #65757.
378 2004-09-12 Marek Safar <marek.safar@seznam.cz>
380 * attribute.cs (Attribute.Resolve): Add error 653 report.
382 * class.cs (Class.ApplyAttributeBuilder): Add error 641
384 (Method.ApplyAttributeBuilder): Add error 685 report.
385 (Operator.Define): Add error 564 report.
387 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
389 * expression.cs (Invocation.DoResolve): Add error
392 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
395 2004-09-11 Marek Safar <marek.safar@seznam.cz>
397 * class.cs (ConstructorInitializer.Resolve):
398 Wrong error number (515->516).
400 2004-09-11 Marek Safar <marek.safar@seznam.cz>
402 * class.cs (Indexer.Define): Add error 631 report.
404 2004-09-11 Marek Safar <marek.safar@seznam.cz>
406 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
408 2004-09-11 Marek Safar <marek.safar@seznam.cz>
410 * expression.cs (Probe.DoResolve): Add error CS0241 report.
412 2004-09-10 Marek Safar <marek.safar@seznam.cz>
414 * cs-parser.jay: Added error CS0241 report.
416 2004-09-10 Raja R Harinath <rharinath@novell.com>
418 * cs-parser.jay (fixed_statement): Introduce a scope for the
419 declaration in the 'fixed' statement.
421 2004-09-09 Marek Safar <marek.safar@seznam.cz>
423 * cs-parser.jay: Added CS0230 error report.
425 2004-09-09 Marek Safar <marek.safar@seznam.cz>
427 * cs-parser.jay: Added errors CS0231 and CS0257 report.
429 2004-09-09 Marek Safar <marek.safar@seznam.cz>
431 * expression.cs (Argument.Resolve): Added error CS0192 and
434 2004-09-09 Marek Safar <marek.safar@seznam.cz>
436 C# 2.0 #pragma warning feature
438 * cs-tokenizer.cs (PreProcessPragma): New method;
439 Handles #pragma directive.
441 * report.cs (WarningRegions): New class; Support
442 class for #pragma warning directive. It tests whether
443 warning is enabled for a given line.
445 2004-09-08 Miguel de Icaza <miguel@ximian.com>
447 * const.cs: Add more descriptive error report, tahnks to
450 2004-09-08 Marek Safar <marek.safar@seznam.cz>
452 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
454 2004-09-07 Miguel de Icaza <miguel@ximian.com>
456 * expression.cs: Apply patch from Ben: Remove dead code from
457 ArrayCreation, and remove the TurnintoConstant call in const.cs,
458 as that code just threw an exception anwyays.
460 * const.cs: Remove the call to the turnintoconstant, for details
463 * literal.cs: The type of the null-literal is the null type; So
464 we use a placeholder type (literal.cs:System.Null, defined here)
467 * expression.cs (Conditional.DoResolve): Remove some old code that
468 is no longer needed, conversions have been fixed.
470 (ArrayCreationExpression.DoResolve): Return false if we fail to
471 resolve the inner expression.
473 2004-09-07 Raja R Harinath <rharinath@novell.com>
476 * cs-parser.jay (delegate_declaration): Record a delegate
477 declaration as a type declaration.
478 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
480 2004-09-06 Miguel de Icaza <miguel@ximian.com>
482 * parameter.cs: Do not crash if the type can not be resolved.
484 * expression.cs: Report errors with unsafe pointers, fixes #64896
486 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
488 * expression.cs: Pointer arith always needs to do a conv.i
489 if the operand is a long. fix 65320
491 2004-09-04 Marek Safar <marek.safar@seznam.cz>
493 Fixed cs0619-37.cs, cs0619-38.cs
495 * enum.cs (GetObsoleteAttribute): Removed.
497 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
498 on Enum member is double staged. The first is tested member
501 2004-09-04 Marek Safar <marek.safar@seznam.cz>
503 Fixed #56986, #63631, #65231
505 * class.cs: (TypeContainer.AddToMemberContainer): New method,
506 adds member to name container.
507 (TypeContainer.AddToTypeContainer): New method, adds type to
509 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
510 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
511 AddOperator): Simplified by reusing AddToMemberContainer.
512 (TypeContainer.UserDefinedStaticConstructor): Changed to property
514 (Method.CheckForDuplications): Fixed implementation to test all
516 (MemberBase): Detection whether member is explicit interface
517 implementation is now in constructor.
518 (MemberBase.UpdateMemberName): Handles IndexerName.
519 (Accessor): Changed to keep also location information.
520 (AbstractPropertyEventMethod): Is derived from MemberCore.
521 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
522 will be emited or not.
523 (PropertyBase.AreAccessorsDuplicateImplementation):
524 Tests whether accessors are not in collision with some method.
525 (Operator): Is derived from MethodCore to simplify common
528 * decl.cs (Flags.TestMethodDuplication): Test for duplication
530 (DeclSpace.AddToContainer): Adds the member to defined_names
531 table. It tests for duplications and enclosing name conflicts.
533 * enum.cs (EnumMember): Clean up to reuse the base structures
535 2004-09-03 Martin Baulig <martin@ximian.com>
537 Merged latest changes into gmcs. Please keep this comment in
538 here, it makes it easier for me to see what changed in MCS since
539 the last time I merged.
541 2004-09-03 Martin Baulig <martin@ximian.com>
543 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
544 into TypeContainer, to make partial classes work again.
546 2004-09-03 Martin Baulig <martin@ximian.com>
548 * rootcontext.cs (RootContext.V2): Removed.
550 2004-03-23 Martin Baulig <martin@ximian.com>
552 * expression.cs (Invocation.OverloadResolve): Added `bool
553 may_fail' argument and use it instead of the Location.IsNull() hack.
555 2004-09-09 Martin Baulig <martin@ximian.com>
557 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
559 2004-09-09 Martin Baulig <martin@ximian.com>
561 * generic.cs (TypeParameter.DefineType): Added support for
562 explicit interface methods.
564 2004-09-09 Martin Baulig <martin@ximian.com>
566 * README.Changes: New document. Started to list important changes
567 between MCS and GMCS here.
569 2004-09-08 Martin Baulig <martin@ximian.com>
572 (TypeContainer.CheckRecursiveDefinition): New protected method.
573 (TypeContainer.DefineType): Move the CS0146 check into
574 CheckRecursiveDefinition().
576 2004-09-06 Martin Baulig <martin@ximian.com>
578 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
579 types for the constructor constraint.
581 2004-09-03 Martin Baulig <martin@ximian.com>
583 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
584 into TypeContainer, to make partial classes work again.
586 2004-09-03 Martin Baulig <martin@ximian.com>
588 * rootcontext.cs (RootContext.V2): Removed.
590 2004-03-23 Martin Baulig <martin@ximian.com>
592 * expression.cs (Invocation.OverloadResolve): Added `bool
593 may_fail' argument and use it instead of the Location.IsNull() hack.
595 2004-09-03 Martin Baulig <martin@ximian.com>
597 Merged latest changes into gmcs. Please keep this comment in
598 here, it makes it easier for me to see what changed in MCS since
599 the last time I merged.
601 2004-09-03 Raja R Harinath <rharinath@novell.com>
604 * expression.cs (BetterConversion): Don't allow either conversion
605 to be null. Remove redundant implicit conversion test when 'q ==
606 null' -- when this function is invoked, we already know that the
607 implicit conversion exists.
608 (BetterFunction): Assume that 'best' is non-null. Remove
609 redundant reimplementation of IsApplicable when 'best' is null.
610 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
612 (IsAncestralType): Extract from OverloadResolve.
613 (OverloadResolve): Make robust to the MethodGroupExpr being
614 unsorted. Implement all the logic of Section 14.5.5.1, and
615 support overloading of methods from multiple applicable types.
616 Clean up logic somewhat. Don't pass null methods to BetterFunction.
618 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
619 (RealError, Warning): Append type of report to related symbol.
621 2004-09-03 Marek Safar <marek.safar@seznam.cz>
623 * enum.cs: Fixed CLS-Compliance checks for enum members.
624 Error tests cs3008-8.cs, cs3014-8.cs
626 2004-09-02 Marek Safar <marek.safar@seznam.cz>
628 Fixed bug #62342, #63102
629 * class.cs: ImplementIndexer uses member.IsExplicitImpl
630 like ImplementMethod.
632 2004-09-02 Marek Safar <marek.safar@seznam.cz>
634 * attribute.cs (Attribute.GetAttributeArgumentExpression):
637 2004-09-02 Martin Baulig <martin@ximian.com>
639 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
640 TypeManager.GetArgumentTypes() rather than calling GetParameters()
643 2004-09-01 Marek Safar <marek.safar@seznam.cz>
645 C# 2.0 Static classes implemented
647 * class.cs (TypeContainer): instance_constructors,
648 initialized_fields, initialized_static_fields,
649 default_constructor, base_inteface_types are protected to be
650 accessible from StaticClass.
651 (TypeContainer.DefineDefaultConstructor): New virtual method
652 for custom default constructor generating
653 (StaticClass): New class to handle "Static classes" feature.
655 * cs-parser.jay: Handle static keyword on class like instance
658 * driver.cs: Added "/langversion" command line switch with two
659 options (iso-1, default).
661 2004-08-31 Marek Safar <marek.safar@seznam.cz>
663 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
665 2004-08-31 Miguel de Icaza <miguel@ximian.com>
667 * delegate.cs: Style.
669 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
671 * delegate.cs: Add seperate instance expr field for miguel.
673 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
675 * PointerArithmetic (Resolve): make sure we are not doing
676 pointer arith on void*. Also, make sure we are resolved
677 by not setting eclass until resolve.
679 All callers: Make sure that PointerArithmetic gets resolved.
681 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
683 * ArrayCreation (LookupType): If the type does not resolve
684 to an array, give an error.
686 2004-08-27 Marek Safar <marek.safar@seznam.cz>
688 * statement.cs (Try.Resolve): Fixed bug #64222
690 2004-08-27 Martin Baulig <martin@ximian.com>
693 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
696 2004-08-26 Marek Safar <marek.safar@seznam.cz>
698 * ecore.cs (Constantify): Get underlying type via
699 System.Enum.GetUnderlyingType to avoid StackOverflow on the
700 Windows in special cases.
702 2004-08-26 Marek Safar <marek.safar@seznam.cz>
704 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
705 for obtaining also private methods.
706 (GetRemoveMethod): Used GetRemoveMethod (true)
707 for obtaining also private methods.
709 2004-09-02 Martin Baulig <martin@ximian.com>
711 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
712 TypeManager.GetArgumentTypes() rather than calling GetParameters()
715 2004-08-27 Martin Baulig <martin@ximian.com>
718 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
721 2004-08-25 Martin Baulig <martin@ximian.com>
723 * support.cs (ReflectionParameters..ctor): If this is a generic
724 method, retrieve and store its type parameters.
725 (InternalParameters..ctor): Added `TypeParameter[]' argument.
726 (ReflectionParameters.GenericConstraints): The argument specifies
727 the type parameter, not the method parameter.
728 (InternalParameters.GenericConstraints): Likewise.
730 * generic.cs (TypeParameter.DefineType): Correctly handle
731 constraints wrt. generic methods in interfaces and their
734 2004-08-24 Martin Baulig <martin@ximian.com>
736 * generic.cs (TypeParameter.IsSubclassOf): New public method.
737 (Constraints.IsSubclassOf): New internal method.
739 * typemanager.cs (TypeManager.FindMembers): Added special support
740 for GenericTypeParameterBuilder's.
741 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
744 2004-08-24 Martin Baulig <martin@ximian.com>
747 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
748 this for accessibility checks.
749 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
750 IsNestedFamilyAccessible.
751 (TypeManager.IsSubclassOf): New method, do what the name actually
754 2004-08-24 Martin Baulig <martin@ximian.com>
756 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
757 as a SimpleName, include the generic arity.
759 2004-08-24 Martin Baulig <martin@ximian.com>
761 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
762 MethodAttributes.HideBySig for operators.
764 2004-08-23 Martin Baulig <martin@ximian.com>
766 Back to the old error reporting system :-)
768 * report.cs (Message): Removed.
769 (Report.MessageData, ErrorData, WarningData): Removed.
770 (Report.Error, Warning): Back to the old system.
772 2004-08-23 Martin Baulig <martin@ximian.com>
774 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
776 * class.cs (TypeContainer.ParentContainer): New public virtual
777 method; replaces the explicit interface implementation.
778 (ClassPart.ParentContainer): Override.
780 2004-08-23 Martin Baulig <martin@ximian.com>
782 * statement.cs (Switch): Added support for constant switches; see
783 #59428 or test-285.cs.
785 2004-08-22 Marek Safar <marek.safar@seznam.cz>
788 * statement.cs (GetEnumeratorFilter): Removed useless
789 logic because C# specs is strict. GetEnumerator must be
792 2004-08-22 Martin Baulig <martin@ximian.com>
794 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
795 a switch and may break, reset the barrier. Fixes #59867.
797 2004-08-22 Marek Safar <marek.safar@seznam.cz>
799 CLS-Compliance speed up (~5% for corlib)
801 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
802 New method. Tests container for CLS-Compliant names
804 * class.cs (TypeContainer.VerifyClsName): New method.
805 Checks whether container name is CLS Compliant.
806 (Constructor): Implements IMethodData.
808 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
809 low-case table for CLS Compliance test.
810 (MemberCache.VerifyClsParameterConflict): New method.
811 Checks method parameters for CS3006 error.
813 * enum.cs (EnumMember): Is derived from MemberCore.
814 (Enum.VerifyClsName): Optimized for better performance.
816 2004-08-06 Marek Safar <marek.safar@seznam.cz>
818 * report.cs: Renamed Error_T to Error and changed all
821 2004-08-06 Marek Safar <marek.safar@seznam.cz>
823 * class.cs (TypeContainer.IndexerArrayList): New inner class
824 container for indexers.
825 (TypeContainer.DefaultIndexerName): New constant for default
826 indexer name. Replaced all "Item" with this constant.
827 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
829 * typemanager.cs (TypeManager.default_member_ctor): Cache here
830 DefaultMemberAttribute constructor.
832 2004-08-05 Martin Baulig <martin@ximian.com>
834 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
837 2004-08-05 Marek Safar <marek.safar@seznam.cz>
839 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
840 multi platforms problem.
842 * compiler.csproj: Included shared files.
844 2004-08-04 Marek Safar <marek.safar@seznam.cz>
846 Fix bug 60333, 55971 in the more general way
847 * attribute.cs (Attribute.GetAttributeArgumentExpression):
848 Added arg_type argument for constant conversion.
849 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
851 2004-08-04 Marek Safar <marek.safar@seznam.cz>
854 * class.cs (TypeContainer ): New inner classes MethodArrayList,
855 OperatorArrayList, MethodCoreArrayList for typecontainer
856 containers. Changed class member types to these new types.
857 (MethodArrayList.DefineMembers): Added test for CS0659.
859 2004-08-04 Miguel de Icaza <miguel@ximian.com>
861 * cfold.cs: Synchronize the folding with the code in expression.cs
862 Binary.DoNumericPromotions for uint operands.
864 * attribute.cs: Revert patch from Raja, it introduced a regression
865 while building Blam-1.2.1 (hard to isolate a test case).
867 2004-08-04 Marek Safar <marek.safar@seznam.cz>
871 (TypeContainer.Define): Renamed to DefineContainerMembers because of
873 (MethodCore.parent_method): New member. The method we're overriding
874 if this is an override method.
875 (MethodCore.CheckBase): Moved from Method class and made common.
876 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
878 (MethodCore.CheckForDuplications): New abstract method. For custom
879 member duplication search in a container
880 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
881 method and its return type.
882 (Event.conflict_symbol): New member. Symbol with same name in the
886 (MemberCache.FindMemberWithSameName): New method. The method
887 is looking for conflict with inherited symbols.
889 2004-08-04 Martin Baulig <martin@ximian.com>
891 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
893 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
895 2004-08-03 Marek Safar <marek.safar@seznam.cz>
897 * report.cs (Message): New enum for better error, warning reference in
899 (MessageData): New inner abstract class. It generally handles printing of
900 error and warning messages.
901 Removed unused Error, Warning, Message methods.
903 2004-08-03 Marek Safar <marek.safar@seznam.cz>
905 Fix for cs0592-8.cs test
907 (Attributable.ValidAttributeTargets): Made public.
908 (Attribute.ExplicitTarget): New member for explicit target value.
909 (Attribute.CheckTargets): Now we translate explicit attribute
910 target to Target here.
912 2004-08-03 Ben Maurer <bmaurer@ximian.com>
914 * ecore.cs (MethodGroupExpr): new IsBase property.
916 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
918 * delegate.cs (DelegateCreation): store a MethodGroupExpr
919 rather than an instance expr.
921 (DelegateCreation.Emit): Use the method group rather than
922 the instance expression. Also, if you have base.Foo as the
923 method for a delegate, make sure to emit ldftn, not ldftnvirt.
925 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
927 (NewDelegate.DoResolve): Only check for the existance of Invoke
928 if the method is going to be needed. Use MethodGroupExpr.
930 (NewDelegate.Emit): Remove, DelegateCreation implements this.
932 * expression.cs: For pointer arith., make sure to use
933 the size of the type, not the size of the pointer to
936 2004-08-03 Marek Safar <marek.safar@seznam.cz>
939 * class.cs (Class): Added error CS0502 test.
941 2004-08-03 John Luke <jluke@cfl.rr.com>
942 Raja R Harinath <rharinath@novell.com>
945 * attribute.cs (Attribute.complained_before): New flag.
946 (Attribute.ResolveType, Attribute.Resolve),
947 (Attribute.DefinePInvokeMethod): Set it.
948 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
950 2004-08-03 Martin Baulig <martin@ximian.com>
952 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
953 use a user-defined operator; we still need to do numeric
954 promotions in case one argument is a builtin type and the other
955 one has an implicit conversion to that type. Fixes #62322.
957 2004-08-18 Martin Baulig <martin@ximian.com>
959 * class.cs (Method.Define): Use the correct method name when
960 creating the MethodBuilder for a generic method.
962 2004-08-17 Martin Baulig <martin@ximian.com>
964 * generic.cs (Constraints): Support type parameter constraints.
966 2004-08-16 Martin Baulig <martin@ximian.com>
968 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
969 (Token.GENERIC_DIMENSION): New token; this is returned if we
970 encounter an unbound generic type in a typeof() expression.
972 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
973 this token is only generated while parsing a typeof() expression.
974 (typeof_expression): Removed the old unbound_type hack.
976 * generic.cs (TypeArguments.IsUnbound): New public property.
978 * decl.cs (MemberName): Added support for unbound types.
980 2004-08-14 Martin Baulig <martin@ximian.com>
983 (TypeManager.IsEqualGenericInstance): New static method.
984 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
985 just used to check accessibility, so follow the rules of 26.1.6.
987 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
988 ConstructedType instead of a TypeExpression if we have type arguments.
990 * cs-parser.jay (typeof_expression): Support unbound generic types.
992 * ecore.cs (UnboundTypeExpression): New public class.
994 2004-08-12 Martin Baulig <martin@ximian.com>
996 * typemanager.cs (TypeManager.IsNestedChildOf): Use
997 TypeManager.IsEqual() rather than `=='.
999 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
1000 generic instances as well.
1002 2004-08-12 Martin Baulig <martin@ximian.com>
1004 * expression.cs (Invocation.InferType): We can only infer method
1005 type parameters. Fixes #62647.
1007 2004-08-11 Martin Baulig <martin@ximian.com>
1009 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
1010 before resolving the base classes.
1012 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1014 * Makefile: install .mdb file too.
1016 2004-08-05 Martin Baulig <martin@ximian.com>
1018 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
1019 initializer, the current type is just the TypeBuilder, not the
1020 instantiated generic type.
1021 (FieldExpr.IsFieldInitializer): New public property.
1023 2004-08-04 Martin Baulig <martin@ximian.com>
1025 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1027 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1029 2004-08-03 Martin Baulig <martin@ximian.com>
1031 * class.cs (MethodData.Define): If we're an explicit
1032 implementation, remove the generic arity from the type name.
1034 2004-08-03 Martin Baulig <martin@ximian.com>
1036 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1037 use a user-defined operator; we still need to do numeric
1038 promotions in case one argument is a builtin type and the other
1039 one has an implicit conversion to that type. Fixes #62322.
1041 2004-08-02 Martin Baulig <martin@ximian.com>
1043 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
1045 (TypeContainer.GetClassBases): Return the unexpanded list of
1046 interfaces; we expand them later.
1047 (TypeContainer.DefineType): After creating the TypeBuilder, call
1048 TypeManager.ExpandInterfaces() to get an expanded and resolved
1051 * ecore.cs (TypeExpr.GetInterfaces): Removed
1053 * generics.cs (Constraints.InterfaceConstraints): Remove.
1054 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
1055 register the interface constraints.
1058 (TypeManager.AddUserType): Removed the `ifaces' argument.
1059 (TypeManager.AddTypeParameter): Likewise.
1060 (TypeManager.AddUserInterface): Removed, was unused.
1061 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
1062 `TypeExpr[]' array for the interfaces.
1063 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
1064 has been defined, returns a list of the resolved interfaces types.
1065 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
1066 (TypeManager.GetExplicitInterfaces): Likewise.
1068 2004-08-02 Martin Baulig <martin@ximian.com>
1070 * expression.cs (Invocation.EmitCall): If we're invoking a method
1071 on a type parameter, use the new `Constrained' prefix opcode.
1073 2004-08-02 Martin Baulig <martin@ximian.com>
1075 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1076 (LocalInfo.IsThis): New public property.
1077 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1079 2004-08-01 Martin Baulig <martin@ximian.com>
1081 * class.cs (TypeContainer.GetClassBases): Don't set the default
1082 here since we may get called from GetPartialBases().
1083 (TypeContainer.DefineType): If GetClassBases() didn't return a
1084 parent, use the default one.
1086 2004-07-30 Martin Baulig <martin@ximian.com>
1088 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1090 * class.cs (SourceMethod): New public class, derive from the
1091 symbol writer's ISourceMethod.
1092 (Method): Use the new symbol writer API.
1094 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1095 as argument and use the new symbol writer.
1098 (SourceFile): Implement the symbol writer's ISourceFile.
1099 (Location.SymbolDocument): Removed.
1100 (Location.SourceFile): New public property.
1102 * symbolwriter.cs: Use the new symbol writer API.
1104 2004-07-30 Raja R Harinath <rharinath@novell.com>
1106 * Makefile (install-local): Remove. Functionality moved to
1109 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1111 * Makefile: Install mcs.exe.config file together with mcs.exe.
1112 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1113 correct runtime version.
1115 2004-07-25 Martin Baulig <martin@ximian.com>
1118 (TypeContainer.RegisterOrder): Removed, this was unused.
1119 (TypeContainer, interface_order): Removed.
1120 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1121 TypeContainer as argument since we can also be called with a
1122 `PartialContainer' for a partial class/struct/interface.
1123 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
1124 of checking whether we're an `Interface' - we could be a
1126 (PartialContainer.Register): Override; call
1127 AddClass()/AddStruct()/AddInterface() on our parent.
1129 * cs-parser.jay (interface_member_declaration): Add things to the
1130 `current_container', not the `current_class'.
1132 * rootcontext.cs (RegisterOrder): The overloaded version which
1133 takes an `Interface' was unused, removed.
1135 * typemanager.cs (TypeManager.LookupInterface): Return a
1136 `TypeContainer', not an `Interface'.
1137 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
1138 contain a `PartialContainer' for an interface, so check it's
1139 `Kind' to figure out what it is.
1141 2004-07-25 Martin Baulig <martin@ximian.com>
1143 * class.cs (Class.DefaultTypeAttributes): New public constant.
1144 (Struct.DefaultTypeAttributes): Likewise.
1145 (Interface.DefaultTypeAttributes): Likewise.
1146 (PartialContainer.TypeAttr): Override this and add the
1147 DefaultTypeAttributes.
1149 2004-07-25 Martin Baulig <martin@ximian.com>
1151 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
1152 we can just use the `Parent' field instead.
1154 2004-07-25 Martin Baulig <martin@ximian.com>
1156 * class.cs (TypeContainer.Emit): Renamed to EmitType().
1158 2004-07-25 Martin Baulig <martin@ximian.com>
1160 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
1161 our parts before defining any methods.
1162 (TypeContainer.VerifyImplements): Make this virtual.
1163 (ClassPart.VerifyImplements): Override and call VerifyImplements()
1164 on our PartialContainer.
1166 2004-07-25 Martin Baulig <martin@ximian.com>
1168 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
1170 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
1171 argument, we can just use the `Parent' field instead.
1174 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
1175 (MemberBase.DoDefine): Likewise.
1177 2004-07-24 Martin Baulig <martin@ximian.com>
1179 * decl.cs (MemberCore.Parent): New public field.
1180 (DeclSpace.Parent): Moved to MemberCore.
1182 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
1183 (MemberBase.ctor): Added TypeContainer argument, pass it to our
1185 (FieldBase, Field, Operator): Likewise.
1186 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
1187 (EventField, Event): Likewise.
1189 2004-07-23 Martin Baulig <martin@ximian.com>
1191 * class.cs (PartialContainer): New public class.
1192 (ClassPart): New public class.
1193 (TypeContainer): Added support for partial classes.
1194 (TypeContainer.GetClassBases): Splitted some of the functionality
1195 out into GetNormalBases() and GetPartialBases().
1197 * cs-tokenizer.cs (Token.PARTIAL): New token.
1198 (Tokenizer.consume_identifier): Added some hacks to recognize
1199 `partial', but only if it's immediately followed by `class',
1200 `struct' or `interface'.
1202 * cs-parser.jay: Added support for partial clases.
1204 2004-07-23 Martin Baulig <martin@ximian.com>
1206 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
1207 a `DeclSpace' and also made it readonly.
1208 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
1209 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
1210 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
1212 * cs-parser.jay: Pass the `current_class', not the
1213 `current_container' (at the moment, this is still the same thing)
1214 to a new Method, Property, Event, Indexer or Constructor.
1216 2004-07-23 Martin Baulig <martin@ximian.com>
1218 * cs-parser.jay (CSharpParser): Added a new `current_class' field
1219 and removed the `current_interface' one.
1220 (struct_declaration, class_declaration, interface_declaration):
1221 Set `current_class' to the newly created class/struct/interface;
1222 set their `Bases' and call Register() before parsing their body.
1224 2004-07-23 Martin Baulig <martin@ximian.com>
1226 * class.cs (Kind): New public enum.
1227 (TypeContainer): Made this class abstract.
1228 (TypeContainer.Kind): New public readonly field.
1229 (TypeContainer.CheckDef): New public method; moved here from
1231 (TypeContainer.Register): New public abstract method.
1232 (TypeContainer.GetPendingImplementations): New public abstract
1234 (TypeContainer.GetClassBases): Removed the `is_class' and
1235 `is_iface' parameters.
1236 (TypeContainer.DefineNestedTypes): Formerly known as
1238 (ClassOrStruct): Made this class abstract.
1240 * tree.cs (RootTypes): New public type.
1242 2004-07-20 Martin Baulig <martin@ximian.com>
1244 * tree.cs (Tree.RecordNamespace): Removed.
1245 (Tree.Namespaces): Removed.
1247 * rootcontext.cs (RootContext.IsNamespace): Removed.
1249 * cs-parser.jay (namespace_declaration): Just create a new
1250 NamespaceEntry here.
1252 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
1254 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
1255 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
1256 entry to make sure it runs in the correct runtime version.
1258 2004-07-18 Martin Baulig <martin@ximian.com>
1260 * generic.cs (ConstructedType.CheckConstraints): Improved
1261 constraints checking.
1263 2004-07-18 Martin Baulig <martin@ximian.com>
1265 * expression.cs (Invocation.BetterMethod): Call
1266 TypeManager.TypeToCoreType() on all types and removed my previous
1267 hack; we're already doig the right thing here.
1269 2004-07-17 Martin Baulig <martin@ximian.com>
1271 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
1273 2004-07-16 Martin Baulig <martin@ximian.com>
1275 * iterators.cs: Added generics support.
1277 2004-07-16 Martin Baulig <martin@ximian.com>
1279 * iterators.cs: Rewrote this. We're now using one single Proxy
1280 class for both the IEnumerable and the IEnumerator interface and
1281 `Iterator' derives from Class so we can use the high-level API.
1283 * class.cs (TypeContainer.AddIterator): New method.
1284 (TypeContainer.DoDefineType): New protected virtual method, which
1285 is called from DefineType().
1286 (TypeContainer.DoDefineMembers): Call DefineType() and
1287 DefineMembers() on all our iterators.
1288 (TypeContainer.Emit): Call Emit() on all our iterators.
1289 (TypeContainer.CloseType): Call CloseType() on all our iterators.
1291 * codegen.cs (EmitContext.CurrentIterator): New public field.
1293 2004-07-15 Martin Baulig <martin@ximian.com>
1296 (TypeManager.not_supported_exception_type): New type.
1298 2004-07-14 Martin Baulig <martin@ximian.com>
1301 (TypeManager.generic_ienumerable_type): New type.
1302 (TypeManager.generic_ienumerator_type): New type.
1305 (RootContext.interfaces_first_stage): Added
1306 "System.Collections.Generic.IEnumerator`1" and
1307 "System.Collections.Generic.IEnumerable`1".
1309 2004-07-14 Martin Baulig <martin@ximian.com>
1311 * iterators.cs: Use real error numbers.
1313 2004-07-14 Martin Baulig <martin@ximian.com>
1315 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
1316 requires this to be a System.Collection.IEnumerable and not a
1317 class implementing that interface.
1318 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
1320 2004-07-13 Marek Safar <marek.safar@seznam.cz>
1322 * class.cs: Fixed previous fix, it broke some error tests.
1324 2004-07-12 Martin Baulig <martin@ximian.com>
1326 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
1329 2004-07-14 Martin Baulig <martin@ximian.com>
1331 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
1332 an exclamation mark (!) for the generic arity to reflect the
1333 latest spec changes; ie. use "System.Collections.Generic.IList`1".
1335 2004-07-13 Martin Baulig <martin@ximian.com>
1337 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
1338 specifiers being part of a type argument.
1340 2004-07-13 Martin Baulig <martin@ximian.com>
1342 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
1343 name for generic types.
1345 2004-07-13 Martin Baulig <martin@ximian.com>
1347 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
1350 2004-07-09 Miguel de Icaza <miguel@ximian.com>
1352 * assign.cs (LocalTemporary): Add new argument: is_address,If
1353 `is_address' is true, then the value that we store is the address
1354 to the real value, and not the value itself.
1356 * ecore.cs (PropertyExpr): use the new local temporary
1357 stuff to allow us to handle X.Y += z (where X is a struct)
1359 2004-07-08 Martin Baulig <martin@ximian.com>
1361 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
1362 not always return, just like we're doing in Using.Resolve().
1364 2004-07-07 Miguel de Icaza <miguel@ximian.com>
1366 * cs-parser.jay (fixed_statement): flag this as Pinned.
1368 2004-07-06 Miguel de Icaza <miguel@ximian.com>
1370 * typemanager.cs (TypeManager): Removed MakePinned method, this
1371 mechanism is replaced with the .NET 2.x compatible mechanism of
1372 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
1374 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
1375 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
1376 `IsFixed' property which has a different meaning.
1378 2004-07-02 Raja R Harinath <rharinath@novell.com>
1380 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
1381 visible from inside a nested class, not just the names of the
1382 immediately enclosing class.
1385 2004-06-24 Raja R Harinath <rharinath@novell.com>
1387 * expression.cs (BetterConversion): Remove buggy special-case
1388 handling of "implicit constant expression conversions". At this
1389 point, we already know that the conversion is possible -- we're
1390 only checking to see which is better.
1392 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1394 * cs-parser.jay: Added error CS0210 test.
1396 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1398 * cs-parser.jay: Added error CS0134 test.
1400 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1403 * cs-parser.jay: Added error CS0145 test.
1405 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1407 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
1409 2004-06-23 Ben Maurer <bmaurer@ximian.com>
1411 * expression.cs (StackAlloc.Resolve): The argument may not
1412 be a constant; deal with this case.
1414 2004-06-23 Marek Safar <marek.safar@seznam.cz>
1416 * attribute.cs (IndexerName_GetIndexerName): Renamed to
1417 GetIndexerAttributeValue.
1418 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
1420 * class.cs (Indexer.Define): Added error tests for CS0415,
1423 2004-06-23 Miguel de Icaza <miguel@ximian.com>
1425 * attribute.cs (Attribute.Resolve): Keep field code in sync with
1428 2004-06-23 Martin Baulig <martin@ximian.com>
1430 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
1431 neither return nor throw, reset the barrier as well. Fixes #60457.
1433 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
1435 * class.cs : EventAttributes is now set to None by default.
1436 This fixes bug #60459.
1438 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1441 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
1442 Don't throw exception but return null (it's sufficient now).
1444 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1446 * typemanager.cs (GetArgumentTypes): Faster implementation.
1448 2004-06-18 Martin Baulig <martin@ximian.com>
1450 * attribute.cs (Attribute.Resolve): Check whether we're an
1451 EmptyCast which a Constant child. Fixes #60333.
1453 2004-06-17 Ben Maurer <bmaurer@ximian.com>
1455 * statement.cs (EmitCollectionForeach): Account for the fact that
1456 not all valuetypes are in areas which we can take the address of.
1457 For these variables, we store to a temporary variable. Also, make
1458 sure that we dont emit a `callvirt' on a valuetype method.
1460 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1462 * expression.cs (StackAlloc.DoReSolve): Added test for
1463 negative parameter (CS0247).
1465 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1468 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
1470 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1473 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
1476 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1478 Fix bug #58254 & cs1555.cs, cs1556.cs
1479 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
1481 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1483 * cs-parser.jay: Added error CS1669 test for indexers.
1485 2004-06-18 Martin Baulig <martin@ximian.com>
1487 * generics.cs (GenericMethod.ctor): Don't take an Attributes
1488 argument. Fixes #60441.
1490 2004-06-16 Ben Maurer <bmaurer@ximian.com>
1491 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
1492 The name needs to have the actual name of the method in order
1493 for other tests (such as the one in OverloadResolve for Invoke
1494 on a delegate) to work. As well, it does not really help
1495 error reporting because the method group had multiple methods.
1496 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
1497 Make profiling work.
1499 2004-06-13 Martin Baulig <martin@ximian.com>
1501 * cs-parser.jay: Don't allow generic attributes.
1503 2004-06-13 Martin Baulig <martin@ximian.com>
1505 * class.cs (MemberBase.DoDefineBase): New protected method.
1506 (MemberBase.DoDefine): Compute the `flags' in the new
1507 DoDefineBase() which must be called first.
1508 (Method.Define): Call DoDefineBase() first so we have the flags
1509 when defining the generic method.
1511 * cs-parser.jay (interface_method_declaration): Support generic methods.
1513 2004-06-13 Martin Baulig <martin@ximian.com>
1515 * decl.cs (TypeName): Removed.
1516 (MemberName): Removed TypeName and MemberNow; now we just have
1519 * cs-parser.jay: Don't distinguish between type arguments and type
1520 parameters in the grammar and simplified the rules a bit. The
1521 reduce/reduce conflicts are now gone (except the one we inherited
1524 2004-06-11 Martin Baulig <martin@ximian.com>
1526 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
1527 call this twice: for params and varargs methods.
1529 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1532 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
1534 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1536 * attribute.cs (Attribute.GetValidTargets): Made public.
1539 (AbstractPropertyEventMethod): New class for better code sharing.
1540 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
1542 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
1544 2004-06-09 Martin Baulig <martin@ximian.com>
1546 * cs-parser.jay: Removed a reduce/reduce conflict.
1548 2004-06-03 Martin Baulig <martin@ximian.com>
1550 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
1551 GetSimpleName() and return a SimpleName.
1553 * ecore.cs (SimpleName.Arguments): New public field.
1554 (SimpleName): Added overloaded ctor which takes an additional
1555 TypeArguments argument.
1556 (SimpleName.SimpleNameResolve): Added support for generic methods.
1557 (MethodGroupExpr.ResolveGeneric): New public method. The code was
1558 formerly in MemberAccess.DoResolve(), but we also need it in
1559 SimpleNameResolve().
1561 * expression.cs (MemberAccess.DoResolve): Use the new
1562 MethodGroupExpr.ResolveGeneric().
1564 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1566 * decl.cs: If possible, use lookuptypedirect here. We can only do
1567 this if there is no `.' after the namespace. Avoids using
1568 LookupType, which does lots of slow processing.
1569 (FindNestedType) New method, does what it says :-).
1570 * namespace.cs: use LookupTypeDirect.
1571 * rootcontext.cs: use membercache, if possible.
1572 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
1574 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1577 According to the spec,
1579 In a member access of the form E.I, if E is a single identifier,
1580 and if the meaning of E as a simple-name (§7.5.2) is a constant,
1581 field, property, localvariable, or parameter with the same type as
1582 the meaning of E as a type-name (§3.8), then both possible
1583 meanings of E are permitted.
1585 We did not check that E as a simple-name had the same type as E as
1588 This trivial check gives us 5-7% on bootstrap time.
1590 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1592 * expression.cs (Invocation.OverloadResolve): Avoid the
1593 use of hashtables and boxing here by allocating on demand.
1595 2004-05-30 Martin Baulig <martin@ximian.com>
1597 * rootcontext.cs (RootContext.LookupType): Don't cache things if
1598 we're doing a silent lookup. Don't try to lookup nested types in
1599 TypeManager.object_type (thanks to Ben Maurer).
1601 2004-05-30 Martin Baulig <martin@ximian.com>
1603 Committing a patch from Ben Maurer.
1605 * rootcontext.cs (RootContext.LookupType): Cache negative results.
1607 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1609 * convert.cs: add a trivial cache for overload operator resolution.
1611 2004-05-31 Marek Safar <marek.safar@seznam.cz>
1614 (AttributeTester.GetObsoleteAttribute): Returns instance of
1615 ObsoleteAttribute when type is obsolete.
1618 (TypeContainer.VerifyObsoleteAttribute): Override.
1619 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
1620 (MethodCode.VerifyObsoleteAttribute): Override.
1621 (MemberBase.VerifyObsoleteAttribute): Override.
1624 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
1625 and report proper error.
1628 (Delegate.VerifyObsoleteAttribute): Override.
1631 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
1632 and report proper error.
1633 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
1636 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
1640 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
1641 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
1642 Added test for ObsoleteAttribute.
1645 (Catch): Derived from Statement.
1647 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1649 * decl.cs: If possible, use lookuptypedirect here. We can only do
1650 this if there is no `.' after the namespace. Avoids using
1651 LookupType, which does lots of slow processing.
1652 (FindNestedType) New method, does what it says :-).
1653 * namespace.cs: use LookupTypeDirect.
1654 * rootcontext.cs: use membercache, if possible.
1655 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
1657 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1660 According to the spec,
1662 In a member access of the form E.I, if E is a single identifier,
1663 and if the meaning of E as a simple-name (§7.5.2) is a constant,
1664 field, property, localvariable, or parameter with the same type as
1665 the meaning of E as a type-name (§3.8), then both possible
1666 meanings of E are permitted.
1668 We did not check that E as a simple-name had the same type as E as
1671 This trivial check gives us 5-7% on bootstrap time.
1673 2004-05-30 Marek Safar <marek.safar@seznam.cz>
1675 Fixed bug #59071 & cs0160.cs
1676 * statement.cs (Try.Resolve): Check here whether order of catch
1677 clauses matches their dependencies.
1679 2004-05-30 Marek Safar <marek.safar@seznam.cz>
1682 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
1685 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1687 * expression.cs (Invocation.OverloadResolve): Avoid the
1688 use of hashtables and boxing here by allocating on demand.
1690 2004-05-30 Martin Baulig <martin@ximian.com>
1692 * rootcontext.cs (RootContext.LookupType): Don't cache things if
1693 we're doing a silent lookup. Don't try to lookup nested types in
1694 TypeManager.object_type (thanks to Ben Maurer).
1696 2004-05-30 Martin Baulig <martin@ximian.com>
1698 Committing a patch from Ben Maurer.
1700 * rootcontext.cs (RootContext.LookupType): Cache negative results.
1702 2004-05-29 Martin Baulig <martin@ximian.com>
1704 * class.cs (IMethodData.ShouldIgnore): New method.
1706 * typemanager.cs (TypeManager.MethodFlags): Don't take a
1707 `Location' argument, we don't need it anywhere. Use
1708 `IMethodData.ShouldIgnore ()' instead of
1709 `MethodData.GetMethodFlags ()'.
1710 (TypeManager.AddMethod): Removed.
1711 (TypeManager.AddMethod2): Renamed to AddMethod.
1713 2004-05-29 Martin Baulig <martin@ximian.com>
1715 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
1717 * convert.cs (Convert.ImplicitReferenceConversion): If we're
1718 converting from a class type S to an interface type and we already
1719 have an object on the stack, don't box it again. Fixes #52578.
1721 2004-05-29 Martin Baulig <martin@ximian.com>
1723 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
1724 Added support for `params' parameters. Fixes #59267.
1726 2004-05-29 Martin Baulig <martin@ximian.com>
1728 * literal.cs (NullPointer): Provide a private .ctor which sets
1729 `type' to TypeManager.object_type. Fixes #59048.
1731 2004-05-29 Martin Baulig <martin@ximian.com>
1733 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
1734 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
1736 * ecore.cs (EventExpr.instance_expr): Make the field private.
1738 2004-05-26 Marek Safar <marek.safar@seznam.cz>
1740 Fixed bug #50080 & cs0214-2.cs
1741 * expression.cs (Cast.DoResolve): Check unsafe context here.
1743 * statement.cs (Resolve.DoResolve): Likewise.
1745 2004-05-26 Martin Baulig <martin@ximian.com>
1747 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
1749 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
1750 (RootContext.LookupType): Pass down the `silent' flag.
1752 2004-05-25 Martin Baulig <martin@ximian.com>
1755 (MethodGroupExpr.IdenticalTypeName): New public property.
1756 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
1757 expression actually refers to a type.
1759 2004-05-25 Martin Baulig <martin@ximian.com>
1761 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
1762 for #56176 and made it actually work.
1764 2004-05-25 Martin Baulig <martin@ximian.com>
1766 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
1767 (FieldExpr, PropertyExpr): Override and implement
1768 CacheTemporaries. Fixes #52279.
1770 2004-05-25 Miguel de Icaza <miguel@ximian.com>
1772 * location.cs: In the new compiler listing a file twice is a
1773 warning, not an error.
1775 2004-05-24 Martin Baulig <martin@ximian.com>
1777 * enum.cs (Enum.DefineType): For the `BaseType' to be a
1778 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
1780 2004-05-24 Martin Baulig <martin@ximian.com>
1782 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
1783 walking the `using' list. Fixes #53921.
1785 2004-05-24 Martin Baulig <martin@ximian.com>
1787 * const.cs (Const.LookupConstantValue): Added support for
1788 EmptyCast's; fixes #55251.
1790 2004-05-24 Martin Baulig <martin@ximian.com>
1792 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
1793 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
1794 which does the CS0135 check. The reason is that we first need to
1795 check whether the variable actually exists.
1797 2004-05-24 Martin Baulig <martin@ximian.com>
1799 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
1800 than RootContext.LookupType() to find the explicit interface
1803 2004-05-24 Raja R Harinath <rharinath@novell.com>
1805 * Makefile: Simplify. Use executable.make.
1806 * mcs.exe.sources: New file. List of sources of mcs.exe.
1808 2004-05-24 Anders Carlsson <andersca@gnome.org>
1812 Use the invariant culture when doing String.Compare for CLS case
1815 2004-05-23 Martin Baulig <martin@ximian.com>
1817 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
1818 don't have any dots. Fixes #52622, added cs0246-8.cs.
1820 * namespace.cs (NamespaceEntry.Lookup): Likewise.
1822 2004-05-23 Marek Safar <marek.safar@seznam.cz>
1824 * class.cs (MemberBase.Define): Reuse MemberType member for
1825 resolved type. Other methods can use it too.
1827 2004-05-23 Martin Baulig <martin@ximian.com>
1829 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
1830 the variable also exists in the current block (otherwise, we need
1831 to report a CS0103). Fixes #58670.
1833 2004-05-23 Martin Baulig <martin@ximian.com>
1835 * flowanalysis.cs (Reachability.Reachable): Compute this
1836 on-the-fly rather than storing it as a field.
1838 2004-05-23 Martin Baulig <martin@ximian.com>
1840 * flowanalysis.cs (Reachability.And): Manually compute the
1841 resulting `barrier' from the reachability.
1843 2004-05-23 Marek Safar <marek.safar@seznam.cz>
1846 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
1847 instance of ObsoleteAttribute when symbol is obsolete.
1850 (IMethodData): Extended interface for ObsoleteAttribute support.
1852 2004-05-22 Marek Safar <marek.safar@seznam.cz>
1854 * attribute.cs: Fix bug #55970
1856 2004-05-22 Marek Safar <marek.safar@seznam.cz>
1860 (GetObsoleteAttribute): New method. Creates the instance of
1862 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
1863 ObsoleteAttribute when member is obsolete.
1864 (AttributeTester.Report_ObsoleteMessage): Common method for
1865 Obsolete error/warning reporting.
1868 (TypeContainer.base_classs_type): New member for storing parent type.
1871 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
1872 for this MemberCore.
1874 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1876 * attribute.cs, const.cs: Fix bug #58590
1878 2004-05-21 Martin Baulig <martin@ximian.com>
1880 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
1881 out parameters if the end of the method is unreachable. Fixes
1884 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1886 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
1887 Hari was right, why extra method.
1889 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1891 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
1893 2004-05-20 Martin Baulig <martin@ximian.com>
1895 * delegate.cs: Convert this file to Unix mode - like the original
1898 2004-05-20 Martin Baulig <martin@ximian.com>
1900 * attribute.cs: Convert this file to Unix mode - like the original
1903 2004-05-19 Marek Safar <marek.safar@seznam.cz>
1905 Fix bug #58688 (MCS does not report error when the same attribute
1908 * attribute.cs (Attribute.Emit): Distinction between null and default.
1910 2004-05-19 Raja R Harinath <rharinath@novell.com>
1912 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
1913 of a top-level attribute without an attribute target.
1914 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
1916 (Attribute.Conditional_GetConditionName),
1917 (Attribute.Obsolete_GetObsoleteMessage): Update.
1918 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
1919 part of ScanForIndexerName.
1920 (Attribute.CanIgnoreInvalidAttribute): New function.
1921 (Attribute.ScanForIndexerName): Move to ...
1922 (Attributes.ScanForIndexerName): ... here.
1923 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
1924 (Attributes.Search): New internal variant that can choose not to
1925 complain if types aren't resolved. The original signature now
1927 (Attributes.GetClsCompliantAttribute): Use internal variant, with
1928 complaints suppressed.
1929 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
1930 only if it not useful.
1931 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
1932 top-level for attributes that are shared between the assembly
1933 and a top-level class.
1934 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
1935 * class.cs: Update to reflect changes.
1936 (DefineIndexers): Fuse loops.
1937 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
1938 a couple more variants of attribute names.
1940 2004-05-18 Marek Safar <marek.safar@seznam.cz>
1942 Fix bug #52585 (Implemented explicit attribute declaration)
1945 (Attributable.ValidAttributeTargets): New abstract method. It gets
1946 list of valid attribute targets for explicit target declaration.
1947 (Attribute.Target): It holds target itself.
1948 (AttributeSection): Removed.
1949 (Attribute.CheckTargets): New method. It checks whether attribute
1950 target is valid for the current element.
1953 (EventProperty): New class. For events that are declared like
1954 property (with add and remove accessors).
1955 (EventField): New class. For events that are declared like field.
1958 * cs-parser.jay: Implemented explicit attribute target declaration.
1960 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
1961 Override ValidAttributeTargets.
1964 (ReturnParameter): Class for applying custom attributes on
1966 (ParameterAtribute): New class. Class for applying custom
1967 attributes on the parameter type.
1969 2004-05-17 Miguel de Icaza <miguel@ximian.com>
1971 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
1974 (Method): Allow UNSAFE here.
1976 * modifiers.cs: Support unsafe reporting.
1978 2004-05-17 Marek Safar <marek.safar@seznam.cz>
1980 * decl.cs: Fix bug #58478.
1982 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1984 * statement.cs: When checking for unreachable code on an EmptyStatement,
1985 set the location. Fixes bug #58488.
1987 2004-05-13 Miguel de Icaza <miguel@ximian.com>
1989 * driver.cs: Add -pkg handling.
1991 From Gonzalo: UseShelLExecute=false
1993 2004-05-12 Marek Safar <marek.safar@seznam.cz>
1996 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
1998 (Attribute.IsClsCompliaceRequired): Moved to base for better
2000 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2001 when attribute is AttributeUsageAttribute.
2002 (Attribute.GetValidTargets): Simplified.
2003 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2004 attribute for this type.
2005 (Attribute.ApplyAttributes): Method renamed to Emit and make
2007 (GlobalAttributeSection): New class for special handling of global
2008 attributes (assembly, module).
2009 (AttributeSection.Emit): New method.
2011 * class.cs: Implemented Attributable abstract methods.
2012 (MethodCore.LabelParameters): Moved to Parameter class.
2013 (Accessor): Is back simple class.
2014 (PropertyMethod): Implemented Attributable abstract class.
2015 (DelegateMethod): Implemented Attributable abstract class.
2016 (Event): New constructor for disctintion between normal Event
2017 and Event with accessors.
2019 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
2021 * codegen.cs, const.cs, decl.cs, delegate.cs:
2022 (CommonAssemblyModulClass): Implemented Attributable abstract class
2025 * enum.cs: Implement IAttributeSupport interface.
2026 (EnumMember): New class for emum members. Implemented Attributable
2030 (ParameterBase): Is abstract.
2031 (ReturnParameter): New class for easier [return:] attribute handling.
2033 * typemanager.cs: Removed builder_to_attr.
2035 2004-05-11 Raja R Harinath <rharinath@novell.com>
2038 * attribute.cs (Attribute.GetPositionalValue): New function.
2039 * class.cs (TypeContainer.VerifyMembers): New function.
2040 (TypeContainer.Emit): Use it.
2041 (ClassOrStruct): New base class for Class and Struct.
2042 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
2043 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
2045 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
2046 then each non-static field should have a FieldOffset attribute.
2047 Otherwise, none of the fields should have a FieldOffset attribute.
2048 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
2049 and FieldOffset attributes.
2050 * typemanager.cs (TypeManager.struct_layout_attribute_type)
2051 (TypeManager.field_offset_attribute_type): New core types.
2052 (TypeManager.InitCoreTypes): Initialize them.
2054 2004-05-11 Michal Moskal <malekith@pld-linux.org>
2056 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
2057 Return correct type.
2060 2004-05-09 Miguel de Icaza <miguel@ximian.com>
2062 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
2063 be implicitly converted to ulong.
2065 * expression.cs: The logic for allowing operator &, | and ^ worked
2066 was wrong, it worked before because we did not report an error in
2067 an else branch. Fixes 57895.
2069 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
2070 allow volatile fields to be reference types.
2072 2004-05-07 Miguel de Icaza <miguel@ximian.com>
2074 * driver.cs: Add support for /debug-
2076 2004-05-07 Raja R Harinath <rharinath@novell.com>
2078 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
2079 Add a 'complain' parameter to silence errors.
2080 (Attribute.Resolve): Update to changes. Put in sanity check to catch
2081 silently overlooked type-resolutions.
2082 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
2084 (Attributes.Search): New function.
2085 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
2086 (Attributes.GetAttributeFullName): Remove hack.
2087 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
2088 Update to reflect changes.
2089 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
2090 Use Attributes.Search instead of nested loops.
2092 2004-05-07 Marek Safar <marek.safar@seznam.cz>
2095 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
2096 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
2097 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
2099 * report.cs: (Report.Warning): Renamed to Warning_T because of
2100 parameter collision.
2102 2004-05-05 Raja R Harinath <rharinath@novell.com>
2104 * expression.cs (MemberAccess.ResolveMemberAccess):
2105 Exit with non-zero status after Report.Error.
2106 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
2108 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
2110 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2112 * support.cs: Don't hang when the file is empty.
2114 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2116 * support.cs: In SeekableStreamReader, compute the preamble size of the
2117 underlying stream. Position changes should take into account that initial
2120 2004-05-03 Todd Berman <tberman@sevenl.net>
2122 * driver.cs: remove unused GetSysVersion function.
2124 2004-05-03 Todd Berman <tberman@sevenl.net>
2126 * driver.cs: Remove the hack from saturday, as well as the hack
2127 from jackson (LoadAssemblyFromGac), also adds the CWD to the
2128 link_paths to get that bit proper.
2130 2004-05-01 Todd Berman <tberman@sevenl.net>
2132 * driver.cs: Try a LoadFrom before a Load, this checks the current
2133 path. This is currently a bug in mono that is be fixed, however, this
2134 provides a workaround for now. This will be removed when the bug
2137 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
2139 * CryptoConvert.cs: Updated to latest version. Fix issue with
2140 incomplete key pairs (#57941).
2142 2004-05-01 Todd Berman <tberman@sevenl.net>
2144 * driver.cs: Remove '.' from path_chars, now System.* loads properly
2147 2004-04-30 Jackson Harper <jackson@ximian.com>
2149 * codegen.cs: Open keys readonly.
2151 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2153 * typemanager.cs: don't report cyclic struct layout when a struct
2154 contains 2 or more fields of the same type. Failed for Pango.AttrShape
2155 which has 2 Pango.Rectangle fields.
2157 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
2159 * expression.cs: Handle IntPtr comparisons with IL code
2160 rather than a method call.
2162 2004-04-29 Martin Baulig <martin@ximian.com>
2164 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
2165 the list of PropertyInfo's in class hierarchy and find the
2166 accessor. Fixes #56013.
2168 2004-04-29 Martin Baulig <martin@ximian.com>
2170 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
2172 2004-04-29 Martin Baulig <martin@ximian.com>
2174 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2176 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
2178 2004-04-29 Martin Baulig <martin@ximian.com>
2180 * class.cs (ConstructorInitializer.Resolve): Check whether the
2181 parent .ctor is accessible. Fixes #52146.
2183 2004-04-29 Martin Baulig <martin@ximian.com>
2185 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2187 * statement.cs (Using.EmitLocalVariableDecls): Use
2188 TypeManager.idisposable_type, not typeof (IDisposable).
2189 (Foreach.EmitCollectionForeach): Added support for valuetypes.
2191 2004-04-29 Martin Baulig <martin@ximian.com>
2193 * class.cs (Event.Define): Don't emit the field and don't set
2194 RTSpecialName and SpecialName for events on interfaces. Fixes
2197 2004-04-29 Raja R Harinath <rharinath@novell.com>
2199 Refactor Attribute.ApplyAttributes.
2200 * attribute.cs (Attributable): New base class for objects that can
2201 have Attributes applied on them.
2202 (Attribute): Make AttributeUsage fields public.
2203 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
2204 (Attribute.IsInternalCall): New property.
2205 (Attribute.UsageAttr): Convert to a public read-only property.
2206 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
2207 (Attribute.ResolveType, Attribute.Resolve)
2208 (Attribute.ScanForIndexerName): Update to reflect changes.
2209 (Attribute.CheckAttributeTarget): Re-format.
2210 (Attribute.ApplyAttributes): Refactor, to various
2211 Attributable.ApplyAttributeBuilder methods.
2212 * decl.cs (MemberCore): Make Attributable.
2213 * class.cs (Accessor): Make Attributable.
2214 (MethodData.ApplyAttributes): Use proper attribute types, not
2216 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
2217 (TypeContainer.ApplyAttributeBuilder)
2218 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
2219 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
2220 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
2221 (Operator.ApplyAttributeBuilder): New factored-out methods.
2222 * const.cs (Const.ApplyAttributeBuilder): Likewise.
2223 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
2224 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
2225 * parameter.cs (ParameterBase): New Attributable base class
2226 that can also represent Return types.
2227 (Parameter): Update to the changes.
2229 2004-04-29 Jackson Harper <jackson@ximian.com>
2231 * driver.cs: Prefer the corlib system version when looking for
2232 assemblies in the GAC. This is still a hack, but its a better hack
2235 2004-04-29 Marek Safar <marek.safar@seznam.cz>
2237 * decl.cs, enum.cs: Improved error 3005 reporting.
2239 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
2240 (related_symbols): New private member for list of symbols
2241 related to reported error/warning.
2243 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
2245 2004-04-29 Martin Baulig <martin@ximian.com>
2247 * ecore.cs (Expression.Constantify): If we're an enum and
2248 TypeManager.TypeToCoreType() doesn't give us another type, use
2249 t.UnderlyingSystemType. Fixes #56178.
2251 2004-04-29 Martin Baulig <martin@ximian.com>
2253 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
2254 interfaces and for each interface, only add members directly
2255 declared in that interface. Fixes #53255.
2257 2004-04-28 Martin Baulig <martin@ximian.com>
2259 * expression.cs (ConditionalLogicalOperator): Use a temporary
2260 variable for `left' to avoid that we evaluate it more than once;
2263 2004-04-28 Martin Baulig <martin@ximian.com>
2265 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
2268 2004-04-28 Martin Baulig <martin@ximian.com>
2270 * statement.cs (LocalInfo.Resolve): Check whether the type is not
2273 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
2274 whether the type is not void (CS1547).
2276 2004-04-28 Martin Baulig <martin@ximian.com>
2278 * expression.cs (Unary.DoResolveLValue): Override this and report
2279 CS0131 for anything but Operator.Indirection.
2281 2004-04-28 Martin Baulig <martin@ximian.com>
2283 Committing a patch from Ben Maurer; see bug #50820.
2285 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2288 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2291 2004-04-28 Martin Baulig <martin@ximian.com>
2293 Committing a patch from Ben Maurer; see bug #50820.
2295 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2298 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2301 2004-04-28 Martin Baulig <martin@ximian.com>
2303 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
2304 (Block.AddLabel): Call DoLookupLabel() to only search in the
2307 2004-04-28 Martin Baulig <martin@ximian.com>
2309 * cfold.cs (ConstantFold.BinaryFold): Added special support for
2310 comparing StringConstants and NullLiterals in Equality and Inequality.
2312 2004-04-28 Jackson Harper <jackson@ximian.com>
2314 * driver.cs: Attempt to load referenced assemblies from the
2315 GAC. This is the quick and dirty version of this method that
2316 doesnt take into account versions and just takes the first
2317 canidate found. Will be good enough for now as we will not have more
2318 then one version installed into the GAC until I update this method.
2320 2004-04-28 Martin Baulig <martin@ximian.com>
2322 * typemanager.cs (TypeManager.CheckStructCycles): New public
2323 static method to check for cycles in the struct layout.
2325 * rootcontext.cs (RootContext.PopulateTypes): Call
2326 TypeManager.CheckStructCycles() for each TypeContainer.
2327 [Note: We only need to visit each type once.]
2329 2004-04-28 Martin Baulig <martin@ximian.com>
2331 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
2333 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
2334 success and added `out object value'. Use a `bool resolved' field
2335 to check whether we've already been called rather than
2336 `ConstantValue != null' since this breaks for NullLiterals.
2338 2004-04-28 Raja R Harinath <rharinath@novell.com>
2340 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
2341 setting of this flag, since the 'set' method may be non-public.
2343 2004-04-28 Raja R Harinath <rharinath@novell.com>
2345 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
2346 check on current_vector.Block.
2348 2004-04-27 Martin Baulig <martin@ximian.com>
2350 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
2351 a field initializer. Fixes #56459.
2353 2004-04-27 Martin Baulig <martin@ximian.com>
2355 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
2356 we're not attempting to use an indexer. Fixes #52154.
2358 2004-04-27 Martin Baulig <martin@ximian.com>
2360 * statement.cs (Return): Don't create a return label if we don't
2361 need it; reverts my change from January 20th. Thanks to Ben
2364 2004-04-27 Martin Baulig <martin@ximian.com>
2366 According to the spec, `goto' can only leave a nested scope, but
2369 * statement.cs (Block.LookupLabel): Only lookup in the current
2370 block, don't recurse into parent or child blocks.
2371 (Block.AddLabel): Check in parent and child blocks, report
2372 CS0140/CS0158 if we find a duplicate.
2373 (Block): Removed this indexer for label lookups.
2374 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
2375 this already does the error reporting for us.
2378 (FlowBranching.UsageVector.Block): New public variable; may be null.
2379 (FlowBranching.CreateSibling): Added `Block' argument.
2380 (FlowBranching.LookupLabel): New public virtual method. Lookup a
2381 label for the target of a `goto' and check whether we're not
2382 leaving a `finally'.
2384 2004-04-27 Martin Baulig <martin@ximian.com>
2386 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2387 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
2390 2004-04-27 Martin Baulig <martin@ximian.com>
2392 * statement.cs (Block.AddLabel): Also check for implicit blocks
2393 and added a CS0158 check.
2395 2004-04-27 Martin Baulig <martin@ximian.com>
2397 * flowanalysis.cs (FlowBranchingLoop): New class.
2398 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
2399 UsageVector's instead of an ArrayList.
2400 (FlowBranching.Label): Likewise.
2401 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
2402 (FlowBranching.AddBreakVector): New method.
2404 2004-04-27 Miguel de Icaza <miguel@ximian.com>
2406 * attribute.cs: Small regression fix: only convert the type if we
2407 the type is different, fixes System.Drawing build.
2409 2004-04-27 Martin Baulig <martin@ximian.com>
2411 * attribute.cs (Attribute.Resolve): If we have a constant value
2412 for a named field or property, implicity convert it to the correct
2415 2004-04-27 Raja R Harinath <rharinath@novell.com>
2417 * statement.cs (Block.Block): Implicit blocks share
2418 'child_variable_names' fields with parent blocks.
2419 (Block.AddChildVariableNames): Remove.
2420 (Block.AddVariable): Mark variable as "used by a child block" in
2421 every surrounding block.
2422 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
2423 been used in a child block, complain about violation of "Invariant
2424 meaning in blocks" rule.
2425 * cs-parser.jay (declare_local_variables): Don't use
2426 AddChildVariableNames.
2427 (foreach_statement): Don't create an implicit block: 'foreach'
2430 2004-04-23 Miguel de Icaza <miguel@ximian.com>
2432 * convert.cs (ImplicitNumericConversion): 0 is also positive when
2433 converting from 0L to ulong. Fixes 57522.
2435 2004-04-22 Marek Safar <marek.safar@seznam.cz>
2437 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
2438 derived class hides via 'new' keyword field from base class (test-242.cs).
2439 TODO: Handle this in the more general way.
2441 * class.cs (CheckBase): Ditto.
2443 2004-04-22 Marek Safar <marek.safar@seznam.cz>
2445 * decl.cs (caching_flags): New member for storing cached values
2447 (MemberCore.Flags): New enum where bit flags for caching_flags
2449 (MemberCore.cls_compliance): Moved to caching_flags.
2450 (DeclSpace.Created): Moved to caching_flags.
2452 * class.cs: Use caching_flags instead of DeclSpace.Created
2454 2004-04-21 Miguel de Icaza <miguel@ximian.com>
2456 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
2457 if we are only a derived class, not a nested class.
2459 * typemanager.cs: Same as above, but do this at the MemberLookup
2460 level (used by field and methods, properties are handled in
2461 PropertyExpr). Allow for the qualified access if we are a nested
2464 2004-04-21 Marek Safar <marek.safar@seznam.cz>
2466 * class.cs: Refactoring.
2467 (IMethodData): New inteface; Holds links to parent members
2468 to avoid member duplication (reduced memory allocation).
2469 (Method): Implemented IMethodData interface.
2470 (PropertyBase): New inner classes for get/set methods.
2471 (PropertyBase.PropertyMethod): Implemented IMethodData interface
2472 (Event): New inner classes for add/remove methods.
2473 (Event.DelegateMethod): Implemented IMethodData interface.
2475 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
2476 EmitContext (related to class.cs refactoring).
2478 2004-04-21 Raja R Harinath <rharinath@novell.com>
2480 * delegate.cs (Delegate.VerifyApplicability): If the number of
2481 arguments are the same as the number of parameters, first try to
2482 verify applicability ignoring any 'params' modifier on the last
2486 2004-04-08 Martin Baulig <martin@ximian.com>
2488 Merged latest changes into gmcs. Please keep this comment in
2489 here, it makes it easier for me to see what changed in MCS since
2490 the last time I merged.
2492 2004-04-16 Raja R Harinath <rharinath@novell.com>
2494 * class.cs (TypeContainer.AddIndexer): Use
2495 'ExplicitInterfaceName' to determine if interface name was
2496 explicitly specified. 'InterfaceType' is not initialized at this time.
2497 (TypeContainer.DefineIndexers): Remove use of temporary list. The
2498 Indexers array is already in the required order. Initialize
2499 'IndexerName' only if there are normal indexers.
2500 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
2501 (TypeContainer.Emit): Emit DefaultMember attribute only if
2502 IndexerName is initialized.
2505 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
2507 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
2510 2004-04-15 Raja R Harinath <rharinath@novell.com>
2512 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
2516 * attribute.cs (Attribute.Resolve): Check for duplicate named
2520 2004-04-15 Miguel de Icaza <miguel@ximian.com>
2522 * iterators.cs (MarkYield): track whether we are in an exception,
2523 and generate code accordingly. Use a temporary value to store the
2524 result for our state.
2526 I had ignored a bit the interaction of try/catch with iterators
2527 since their behavior was not entirely obvious, but now it is
2528 possible to verify that our behavior is the same as MS .NET 2.0
2532 2004-04-14 Miguel de Icaza <miguel@ximian.com>
2534 * iterators.cs: Avoid creating temporaries if there is no work to
2537 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
2538 Enumerations, use TypeManager.EnumToUnderlying and call
2541 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
2544 (This.Emit): Use EmitContext.EmitThis to emit our
2547 (This.EmitAssign): Ditto.
2549 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
2550 codepaths, we will move all the functionality into
2553 (FieldExpr.EmitAssign): Ditto.
2555 This fixes several hidden bugs that I uncovered while doing a code
2556 review of this today.
2558 * codegen.cs (EmitThis): reworked so the semantics are more clear
2559 and also support value types "this" instances.
2561 * iterators.cs: Changed so that for iterators in value types, we
2562 do not pass the value type as a parameter.
2564 Initialization of the enumerator helpers is now done in the caller
2565 instead of passing the parameters to the constructors and having
2566 the constructor set the fields.
2568 The fields have now `assembly' visibility instead of private.
2570 2004-04-11 Miguel de Icaza <miguel@ximian.com>
2572 * expression.cs (Argument.Resolve): Check if fields passed as ref
2573 or out are contained in a MarshalByRefObject.
2575 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
2576 another compiler type.
2578 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
2580 * class.cs (Indexer.Define): use the new name checking method.
2581 Also, return false on an error.
2582 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
2583 (is_identifier_[start/part]_character): make static.
2585 2004-04-10 Miguel de Icaza <miguel@ximian.com>
2587 * expression.cs (Binary.ResolveOperator): Do no append strings
2588 twice: since we can be invoked more than once (array evaluation)
2589 on the same concatenation, take care of this here. Based on a fix
2590 from Ben (bug #56454)
2592 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
2594 * codegen.cs: Fix another case where CS1548 must be reported (when
2595 delay-sign isn't specified and no private is available #56564). Fix
2596 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
2597 error when MCS is used on the MS runtime and we need to delay-sign
2598 (which seems unsupported by AssemblyBuilder - see #56621).
2600 2004-04-08 Marek Safar <marek.safar@seznam.cz>
2602 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
2603 (TypeManager.ComputeNamespaces): Faster implementation for
2606 * compiler.csproj: Updated AssemblyName to mcs.
2608 2004-05-11 Jackson Harper <jackson@ximian.com>
2610 * Makefile: Preserve MONO_PATH
2612 2004-05-11 Jackson Harper <jackson@ximian.com>
2614 * Makefile: Use mono and mcs to build gmcs
2616 2004-05-03 Miguel de Icaza <miguel@ximian.com>
2618 * codegen.cs: Add patch from Robert Shade
2619 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
2622 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
2624 * CryptoConvert.cs: Updated to latest version. Fix issue with
2625 incomplete key pairs (#57941).
2627 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
2629 * codegen.cs: Fix another case where CS1548 must be reported (when
2630 delay-sign isn't specified and no private is available #56564). Fix
2631 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
2632 error when MCS is used on the MS runtime and we need to delay-sign
2633 (which seems unsupported by AssemblyBuilder - see #56621).
2635 2004-04-29 Jackson Harper <jackson@ximian.com>
2637 * Makefile: Set MONO_PATH to use the bootstrap corlib
2638 * driver.cs: Check the GAC for referenced assemblies.
2640 2004-04-29 Martin Baulig <martin@ximian.com>
2642 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
2644 2004-04-07 Martin Baulig <martin@ximian.com>
2646 * expression.cs (Binary.ResolveOperator): Added special case for
2647 Equality/Inequality between a type parameter and a null literal.
2649 2004-04-07 Martin Baulig <martin@ximian.com>
2651 * convert.cs: Check null literal -> type parameter conversions.
2653 2004-04-07 Martin Baulig <martin@ximian.com>
2655 * generic.cs (ConstructedType.CheckConstraints): Enforce the
2656 `class' and `struct' constraints.
2658 2004-04-07 Martin Baulig <martin@ximian.com>
2660 * generic.cs (SpecialConstraint): New public enum.
2661 (Constraints.Resolve): Added support for the `class' and `struct'
2664 * cs-parser.jay (type_parameter_constraint): Added support for the
2665 `class' and `struct' constraints.
2667 2004-04-07 Martin Baulig <martin@ximian.com>
2669 * support.cs (GenericConstraints): Replaced `Types' by
2670 `ClassConstraint' and `InterfaceConstraints'; added
2671 `HasClassConstraint'.
2673 2004-04-07 Martin Baulig <martin@ximian.com>
2676 (Constraints.InterfaceConstraints): New public property.
2677 (Constraints.Types): Make this property public
2678 (TypeParameter): Implement IMemberContainer.
2679 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
2680 instead of a TypeBuilder/MethodBuilder; pass the interface
2681 constraints to TypeManager.AddTypeParameter().
2682 (TypeParameter.DefineType): Just take an EmitContext and no
2683 TypeBuilder/MethodBuilder. Use the new public API.
2685 * typemanager.cs (TypeManager.AddTypeParameter): Added
2686 `TypeExpr[]' argument; add the interfaces to the
2687 `builder_to_ifaces' hash.
2688 (TypeManager.LookupMemberContainer): For
2689 GenericTypeParameterBuilders, get the TypeParameter from the
2690 `builder_to_type_param'.
2691 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
2692 the TypeParameter and call FindMembers on it.
2694 2004-04-07 Martin Baulig <martin@ximian.com>
2697 (MethodCore.GenericMethod): Moved this field here from Method.
2698 (MethodCore.IsDuplicateImplementation): Take the number of type
2699 parameters into account if we're a generic method.
2701 * expression.cs (Invocation.InferTypeArguments): Don't return true
2702 if `arguments' is null; we still need to check whether we actually
2703 don't need to infer anything in this case.
2704 (MemberAccess): Merged the functionality from GenericMemberAccess
2707 * generic.cs (GenericMemberAccess): Removed.
2709 2004-04-05 Martin Baulig <martin@ximian.com>
2711 * decl.cs (MemberCore): For generic classes, interfaces and
2712 structs, `Name' now includes the number of type parameters
2714 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
2715 encode the number of type arguments in the type name.
2717 * expression.cs (Expression.MemberLookup): Removed the
2718 `num_type_args' argument; we now encode the number of type
2719 arguments in the type name.
2721 * ecore.cs (SimpleName): Encode the number of type arguments in
2722 the type name itself.
2724 * generic.cs (ConstructedType): Likewise.
2726 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
2727 `MemberName'; we now include the number of type parameters in the
2730 * typemanager.cs (TypeManager.CheckGeneric): Removed.
2731 (TypeManager.MemberLookup): Removed the
2732 `num_type_args' argument; we now encode the number of type
2733 arguments in the type name.
2735 2004-04-03 Martin Baulig <martin@ximian.com>
2737 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
2738 (MemberCore.MemberName): Moved here from MemberBase.
2739 (DeclSpace.SetParameterInfo): Just take the constraints as an
2740 ArrayList; we already have the type parameters in our
2741 `MemberName'; also do the CS0080 reporting here.
2743 * cs-parser.jay (struct_declaration): Use `member_name' instead of
2744 `IDENTIFIER opt_type_parameter_list'; when constructing our
2745 `MemberName', it'll already include our type parameters.
2746 (class_declaration, interface_declaration): Likewise.
2747 (delegate_declaration): Likewise.
2748 (MakeName): Take a MemberName and return a MemberName.
2749 The following two changes are required to avoid shift/reduce conflicts:
2750 (member_name): Don't include a TypeName anymore; ie. this is now
2751 just 'IDENTIFIER opt_type_parameter_list'.
2752 (property_declaration, event_declaration): Use a
2753 `namespace_or_type_name' instead of a `member_name'.
2755 2004-04-03 Martin Baulig <martin@ximian.com>
2757 * decl.cs (MemberName): Renamed to `TypeName' and created a new
2759 (TypeName): Formerly known as MemberName.
2761 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
2762 instead of a `MemberName'.
2764 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
2765 (member_name): New rule; create a MemberName.
2767 2004-04-02 Martin Baulig <martin@ximian.com>
2769 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
2770 (CS0305 and CS0308).
2772 2004-04-02 Martin Baulig <martin@ximian.com>
2774 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
2775 support for nested types.
2777 2004-04-02 Martin Baulig <martin@ximian.com>
2779 * ecore.cs (IAlias): New public interface.
2780 (TypeExpr, TypeExpression): Implement IAlias.
2781 (TypeAliasExpression): New public class.
2783 * namespace.cs (Namespace): Implement IAlias.
2784 (Namespace.Lookup): Return an IAlias instead on an object.
2785 (Namespace.DefineName): Take an IAlias instead of an object.
2786 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
2788 (NamespaceEntry.UsingAlias): Take a Membername instead of an
2790 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
2792 (NamespaceEntry.Lookup): Likewise.
2794 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
2797 * decl.cs (DeclSpace): Implement IAlias.
2798 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
2800 * generic.cs (ConstructedType): Improved error checking.
2802 2004-04-02 Martin Baulig <martin@ximian.com>
2804 * convert.cs: Added type parameter conversions.
2807 (UnboxCast.Emit): Emit an `unbox.any' for type params.
2808 (ClassCast.Emit): If the source type is a type parameter, box it.
2809 If the target type is a type parameter, emit an `unbox.any'
2810 instead of a `classcast'.1
2812 2004-04-01 Martin Baulig <martin@ximian.com>
2814 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
2816 2004-04-01 Martin Baulig <martin@ximian.com>
2818 * generic.cs (ConstructedType.CheckConstraints): Use
2819 Convert.ImplicitStandardConversionExists(); user-defined implicit
2820 conversions are not allowed according to the spec.
2822 2004-03-30 Martin Baulig <martin@ximian.com>
2824 * expression.cs (New): Added support for type parameters.
2827 (TypeManager.activator_type): New public static field.
2828 (TypeManager.activator_create_instance): Likewise.
2830 2004-03-30 Martin Baulig <martin@ximian.com>
2832 * typemanager.cs (TypeManager.HasConstructorConstraint): New
2835 2004-03-30 Martin Baulig <martin@ximian.com>
2837 * generic.cs (ConstructedType.CheckConstraints): Actually follow
2838 the spec here: the argument type must be convertible to the
2841 2004-03-30 Martin Baulig <martin@ximian.com>
2844 (TypeParameter.Define, TypeParameter.DefineMethod): Call
2845 TypeManager.AddTypeParameter().
2846 (ConstructedType.CheckConstraints): Re-enable this and actually
2847 check whether we have a constructor constraint.
2850 (TypeManager.builder_to_type_param): New static field.
2851 (TypeManager.AddTypeParameter): New static method.
2852 (TypeManager.LookupTypeParameter): New public method.
2854 2004-03-30 Martin Baulig <martin@ximian.com>
2856 * generic.cs (TypeParameter.DefineType): Return a boolean and use
2857 the new API to actually define the constructor constraint.
2860 (TypeManager.new_constraint_attr_type): New static field.
2861 (TypeManager.InitCoreTypes): Initialize it.
2863 2004-03-30 Martin Baulig <martin@ximian.com>
2865 * generic.cs (Constraints): Completed error checking, use correct
2868 2004-03-29 Martin Baulig <martin@ximian.com>
2870 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
2872 * expression.cs (Invocation.InferTypeArguments): Added overloaded
2873 public version which takes a `ParameterData pd' instead of an
2876 2004-03-29 Martin Baulig <martin@ximian.com>
2878 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
2881 2004-03-29 Martin Baulig <martin@ximian.com>
2883 * expression.cs (Argument.ResolveMethodGroup): If we're a
2884 ConstructedType, call GetMemberAccess() on it.
2886 2004-03-29 Martin Baulig <martin@ximian.com>
2888 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
2889 (MethodCore.CheckGenericOverride): When overriding a generic
2890 method, check whether the constraints match.
2892 * support.cs (GenericConstraints): New public interface.
2893 (ParameterData.GenericConstraints): New public method.
2895 * parameter.cs (Parameter.Resolve): Check whether we're a generic
2896 method parameter and compute our constraints if appropriate.
2897 (Parameter.GenericConstraints): New public property.
2899 * generic.cs (Constraints): Implement GenericConstraints.
2901 2004-03-29 Martin Baulig <martin@ximian.com>
2903 * decl.cs (MemberCache.FindMemberToOverride): Use
2904 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
2906 2004-03-29 Martin Baulig <martin@ximian.com>
2908 * generic.cs (GenericMethod.Define): Resolve our type parameters.
2910 2004-03-29 Martin Baulig <martin@ximian.com>
2912 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
2913 not allowed on non-generic declarations").
2915 2004-03-29 Martin Baulig <martin@ximian.com>
2917 * expression.cs (Invocation.InferTypeArguments): Added overloaded
2918 public version of this method.
2920 * class.cs (MethodCore.IsDuplicateImplementation): Use
2921 Invocation.InferTypeArguments() to check this.
2923 2004-03-29 Martin Baulig <martin@ximian.com>
2925 * convert.cs: Use TypeManager.IsDelegateType() instead of
2926 comparing types correctly.
2928 2004-03-29 Martin Baulig <martin@ximian.com>
2930 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
2931 types directly to make it work for generic instances.
2933 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
2935 2004-03-29 Martin Baulig <martin@ximian.com>
2937 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
2940 2004-03-24 Martin Baulig <martin@ximian.com>
2942 * decl.cs (DeclSpace.FindType): Also use
2943 TypeManager.CheckGeneric() for types from the using clauses.
2945 2004-03-23 Martin Baulig <martin@ximian.com>
2947 * expression.cs (Invocation.OverloadResolve): Added `bool
2948 may_fail' argument and use it instead of the Location.IsNull() hack.
2950 2004-03-23 Martin Baulig <martin@ximian.com>
2952 * expression.cs (Invocation.InferType): Use correct type inference
2955 2004-03-23 Martin Baulig <martin@ximian.com>
2957 * ecore.cs (MethodGroupExpr.Name): Use
2958 TypeManager.CSharpSignature() instead of just the name.
2960 * expression.cs (Invocation.OverloadResolve): Provide better error
2962 (Invocation.DoResolve): OverloadResolve() never returns null
2963 without reporting an error, so removed the error -6 reporting here.
2965 2004-03-23 Martin Baulig <martin@ximian.com>
2967 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
2970 * cs-parser.jay (delegate_declaration): Support generic delegates.
2972 * delegate.cs: Support generic delegates.
2974 2004-03-22 Martin Baulig <martin@ximian.com>
2976 * expression.cs (Invocation.InferParamsTypeArguments): New static
2977 method; does type inference for params arguments.
2979 2004-03-21 Martin Baulig <martin@ximian.com>
2981 * typemanager.cs (TypeManager.IsGenericMethod): New public static
2982 method; checks whether a method is a generic method.
2984 * expression.cs (Invocation.InferTypeArguments): New static method;
2985 infer type arguments for generic method invocation.
2987 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
2988 property; we set this to true if we're resolving a generic method
2989 invocation and the user specified type arguments, ie. we're not
2990 doing type inference.
2992 2004-03-20 Martin Baulig <martin@ximian.com>
2994 * class.cs (MethodData.DeclaringType): New public property.
2995 (MethodData.Define): Set DeclaringType here.
2996 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
2997 instead of OperatorMethodBuilder.DeclaringType.
2999 2004-03-20 Martin Baulig <martin@ximian.com>
3001 * cs-tokenizer.cs (xtoken): Return a special
3002 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
3004 * cs-parser.jay (default_value_expression): Switch to the new
3007 2004-03-19 Martin Baulig <martin@ximian.com>
3009 * decl.cs (MemberName): New class. We use this to "construct"
3010 namespace_or_type_name's.
3012 * generics.cs (TypeArguments.GetDeclarations): New public method;
3013 returns the type arguments as a string[] and reports a CS0081 if
3014 one of them is not an identifier.
3016 * class.cs (MemberBase): The .ctor now takes the name as a
3017 MemberName instead of a string.
3018 (MemberBase.ExplicitInterfaceName): Changed type from string to
3020 (MemberBase.DoDefine): If we're an explicit implementation, the
3021 InterfaceType may be a generic instance.
3023 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
3024 (namespace_name): Call MemberName.GetName () to transform the
3025 MemberName into a string and ensure we don't have any type
3027 (type_name): Call MemberName.GetTypeExpression() to transfrom the
3028 MemberName into an expression.
3029 (method_header): Use namespace_or_type_name instead of member_name.
3031 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3033 * rootcontext.cs: Add new types to the boot resolution.
3035 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3036 MulticastDelegate is not allowed.
3038 * typemanager.cs: Add new types to lookup: System.TypedReference
3041 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3042 check for TypedReference or ArgIterator, they are not allowed.
3044 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3045 makes us properly catch 1510 in some conditions (see bug 56016 for
3048 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3050 * CryptoConvert.cs: update from corlib version
3053 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3055 * class.cs (Indexer.Define): Check indexername declaration
3057 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3059 * attribute.cs (IsClsCompliant): Fixed problem with handling
3060 all three states (compliant, not-compliant, undetected).
3062 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3064 * attribute.cs (Attribute): Location is now public.
3065 (Resolve): Store resolved arguments (pos_values) in attribute class.
3066 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3067 (GetClsCompliantAttributeValue): New method that gets
3068 CLSCompliantAttribute value.
3069 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3070 if exists else null.
3071 (AttributeTester): New class for CLS-Compliant verification routines.
3073 * class.cs (Emit): Add CLS-Compliant verification.
3074 (Method.GetSignatureForError): Implemented.
3075 (Constructor.GetSignatureForError): Implemented
3076 (Constructor.HasCompliantArgs): Returns if constructor has
3077 CLS-Compliant arguments.
3078 (Constructor.Emit): Override.
3079 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3080 is needed to test only parameters.
3081 (FieldBase.GetSignatureForError): Implemented.
3082 (TypeContainer): New member for storing base interfaces.
3083 (TypeContainer.FindMembers): Search in base interfaces too.
3085 * codegen.cs (GetClsComplianceAttribute): New method that gets
3086 assembly or module CLSCompliantAttribute value.
3087 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3089 (ModuleClass.Emit): Add error 3012 test.
3091 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3093 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3094 state for all decl types.
3095 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3096 if CLS-Compliant tests are required.
3097 (IsClsCompliaceRequired): New method. Analyze whether code
3098 must be CLS-Compliant.
3099 (IsExposedFromAssembly): New method. Returns true when MemberCore
3100 is exposed from assembly.
3101 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3102 value or gets cached value.
3103 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3104 is explicitly marked with CLSCompliantAttribute.
3105 (IsIdentifierClsCompliant): New abstract method. This method is
3106 used to testing error 3005.
3107 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3108 for identifier and parameters CLS-Compliant testing.
3109 (VerifyClsCompliance): New method. The main virtual method for
3110 CLS-Compliant verifications.
3111 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3112 null. I don't know why is null (too many public members !).
3113 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3114 and get value of first CLSCompliantAttribute that found.
3116 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3117 (VerifyClsCompliance): Override and add extra tests.
3119 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3120 clscheck- disable CLS-Compliant verification event if assembly is has
3121 CLSCompliantAttribute(true).
3123 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3124 ApllyAttribute is now called in emit section as in the other cases.
3125 Possible future Emit integration.
3126 (IsIdentifierClsCompliant): New override.
3127 (VerifyClsCompliance): New override.
3128 (GetEnumeratorName): Returns full enum name.
3130 * parameter.cs (GetSignatureForError): Implemented.
3132 * report.cs (WarningData): New struct for Warning message information.
3133 (LocationOfPreviousError): New method.
3134 (Warning): New method. Reports warning based on the warning table.
3135 (Error_T): New method. Reports error based on the error table.
3137 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3138 verifications are done here.
3140 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3142 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3143 CLSCompliantAttribute.
3144 (all_imported_types): New member holds all imported types from other
3146 (LoadAllImportedTypes): New method fills static table with exported types
3147 from all referenced assemblies.
3148 (Modules): New property returns all assembly modules.
3150 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3152 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3153 throwing a parser error.
3155 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3156 which removes the hardcoded get_/set_ prefixes for properties, as
3157 IL allows for the properties to be named something else.
3161 * expression.cs: Do not override operand before we know if it is
3164 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3166 * typemanager.cs: support for pinned variables.
3168 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3170 * decl.cs, typemanager.cs: Avoid using an arraylist
3171 as a buffer if there is only one result set.
3173 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3175 * expression.cs: Make sure you cant call a static method
3176 with an instance expression, bug #56174.
3178 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3180 * class.cs (IsDuplicateImplementation): Improve error reporting to
3181 flag 663 (method only differs in parameter modifier).
3183 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3184 in preprocessor directives.
3186 * location.cs (LookupFile): Allow for the empty path.
3188 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3189 better approach for some of that patch, but its failing with the
3190 CharSet enumeration. For now try/catch will do.
3192 * typemanager.cs: Do not crash if a struct does not have fields.
3195 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3197 * expression.cs: cs0213, cant fix a fixed expression.
3200 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3202 * cs-parser.jay: detect invalid embeded statements gracefully.
3205 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3207 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3210 the invocation type may not be a subclass of the tye of the item/
3211 The type of the item must be a subclass of the invocation item.
3216 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3218 * attribute.cs: Added methods to get a string and a bool from an
3219 attribute. Required to information from AssemblyKeyFileAttribute,
3220 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3221 * codegen.cs: Modified AssemblyName creation to include support for
3222 strongnames. Catch additional exceptions to report them as CS1548.
3223 * compiler.csproj: Updated include CryptoConvert.cs.
3224 * compiler.csproj.user: Removed file - user specific configuration.
3225 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
3226 Mono.Security assembly. The original class is maintained and tested in
3227 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
3228 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
3229 like CSC 8.0 (C# v2) supports.
3230 * Makefile: Added CryptoConvert.cs to mcs sources.
3231 * rootcontext.cs: Added new options for strongnames.
3233 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
3235 * driver.cs: For --expect-error, report error code `2'
3236 if the program compiled with no errors, error code `1' if
3237 it compiled with an error other than the one expected.
3239 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
3241 * compiler.csproj: Updated for Visual Studio .NET 2003.
3242 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
3243 * compiler.sln: Updated for Visual Studio .NET 2003.
3245 2004-03-24 Ravi Pratap M <ravi@ximian.com>
3247 * expression.cs: Fix bug #47234. We basically need to apply the
3248 rule that we prefer the conversion of null to a reference type
3249 when faced with a conversion to 'object' (csc behaviour).
3251 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3253 * statement.cs: Shorter form for foreach, eliminates
3254 a local variable. r=Martin.
3256 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3258 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
3259 checks if we can use brtrue/brfalse to test for 0.
3260 * expression.cs: use the above in the test for using brtrue/brfalse.
3263 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3265 * expression.cs: Rewrite string concat stuff. Benefits:
3267 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
3268 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
3269 rather than a concat chain.
3271 * typemanager.cs: Add lookups for more concat overloads.
3273 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3275 * expression.cs: Emit shorter il code for array init.
3292 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
3294 * statement.cs: Before, two switch blocks would be merged if the
3295 total size of the blocks (end_item - begin_item + 1) was less than
3296 two times the combined sizes of the blocks.
3298 Now, it will only merge if after the merge at least half of the
3303 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
3305 * class.cs : csc build fix for GetMethods(). See bug #52503.
3307 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
3309 * expression.cs: Make sure fp comparisons work with NaN.
3310 This fixes bug #54303. Mig approved this patch a long
3311 time ago, but we were not able to test b/c the runtime
3314 2004-03-19 Miguel de Icaza <miguel@ximian.com>
3316 * ecore.cs (TypExpr.GetHashCode): implement this overload.
3318 2004-03-19 Martin Baulig <martin@ximian.com>
3320 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
3321 two overloads may unify for some type parameter substitutions and
3322 report a CS0408 if appropriate.
3324 2004-03-19 Martin Baulig <martin@ximian.com>
3326 * class.cs (MemberCore.IsDuplicateImplementation): Report the
3327 error here and not in our caller.
3329 2004-03-19 Martin Baulig <martin@ximian.com>
3331 * interface.cs: Completely killed this file.
3332 (Interface): We're now a TypeContainer and live in class.cs.
3334 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
3335 argument; we're now also called for interfaces.
3336 (TypeContainer.DefineMembers): Allow this method being called
3338 (TypeContainer.GetMethods): New public method; formerly known as
3339 Interface.GetMethod(). This is used by PendingImplementation.
3340 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
3341 it's now private and non-static.
3342 (Interface): Moved this here; it's now implemented similar to
3344 (Method, Property, Event, Indexer): Added `bool is_interface'
3345 argument to their .ctor's.
3346 (MemberBase.IsInterface): New public field.
3348 * cs-parser.jay: Create normal Method, Property, Event, Indexer
3349 instances instead of InterfaceMethod, InterfaceProperty, etc.
3350 (opt_interface_base): Removed; we now use `opt_class_base' instead.
3351 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
3353 2004-03-19 Martin Baulig <martin@ximian.com>
3355 * class.cs (MethodCore.IsDuplicateImplementation): New private
3356 method which does the CS0111 checking.
3357 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
3358 Use IsDuplicateImplementation().
3360 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
3362 * decl.cs (FindMemberToOverride): New method to find the correct
3363 method or property to override in the base class.
3365 - Make Method/Property use the above method to find the
3366 version in the base class.
3367 - Remove the InheritableMemberSignatureCompare as it is now
3370 This patch makes large code bases much faster to compile, as it is
3371 O(n) rather than O(n^2) to do this validation.
3373 Also, it fixes bug 52458 which is that nested classes are not
3374 taken into account when finding the base class member.
3376 Reviewed/Approved by Martin.
3378 2004-03-17 Martin Baulig <martin@ximian.com>
3380 * expression.cs (MemberAccess.DoResolve): Take the parent's number
3381 of type arguments into account; use the `real_num_type_args'
3382 approach like in DoResolveAsTypeStep().
3384 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
3387 2004-03-17 Marek Safar <marek.safar@seznam.cz>
3389 * interface.cs: In all interface classes removed redundant
3390 member initialization.
3392 2004-03-16 Martin Baulig <martin@ximian.com>
3394 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
3396 2004-03-15 Miguel de Icaza <miguel@ximian.com>
3398 * decl.cs (DefineTypeAndParents): New helper method to define a
3399 type's containers before the type itself is defined; This is a
3400 bug exposed by the recent changes to Windows.Forms when an
3401 implemented interface was defined inside a class that had not been
3404 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
3406 (Check): Loop correctly to report errors modifiers
3407 (UNSAFE was not in the loop, since it was the same as TOP).
3409 * interface.cs: Every interface member now takes a ModFlags,
3410 instead of a "is_new" bool, which we set on the base MemberCore.
3412 Every place where we called "UnsafeOk" in the interface, now we
3413 call the proper member (InterfaceMethod.UnsafeOK) instead to get
3414 the unsafe settings from the member declaration instead of the
3415 container interface.
3417 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
3419 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
3420 `set_indexer_name' to the pending bits (one per type).
3422 We fixed a bug today that was picking the wrong method to
3423 override, since for properties the existing InterfaceMethod code
3424 basically ignored the method name. Now we make sure that the
3425 method name is one of the valid indexer names.
3427 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
3429 * support.cs (SeekableStreamReader): Keep track of stream byte
3430 positions and don't mix them with character offsets to the buffer.
3432 Patch from Gustavo Giráldez
3434 2004-03-15 Marek Safar <marek.safar@seznam.cz>
3436 * interface.cs (InterfaceSetGetBase): Removed double member
3437 initialization, base class does it as well.
3439 2004-03-13 Martin Baulig <martin@ximian.com>
3441 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
3442 when compiling corlib.
3444 2004-03-13 Miguel de Icaza <miguel@ximian.com>
3446 * convert.cs (ExplicitConversion): We were reporting an error on
3447 certain conversions (object_type source to a value type, when the
3448 expression was `null') before we had a chance to pass it through
3449 the user defined conversions.
3451 * driver.cs: Replace / and \ in resource specifications to dots.
3454 * class.cs: Add check for duplicate operators. Fixes 52477
3456 2004-03-11 Miguel de Icaza <miguel@ximian.com>
3458 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
3459 that are in the middle of the statements, not only at the end.
3462 * class.cs (TypeContainer.AddField): No longer set the
3463 `HaveStaticConstructor' flag, now we call it
3464 `UserDefineStaticConstructor' to diferentiate the slightly
3465 semantic difference.
3467 The situation is that we were not adding BeforeFieldInit (from
3468 Modifiers.TypeAttr) to classes that could have it.
3469 BeforeFieldInit should be set to classes that have no static
3474 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
3476 And most importantly Zoltan's comment:
3478 http://bugzilla.ximian.com/show_bug.cgi?id=44229
3480 "I think beforefieldinit means 'it's ok to initialize the type sometime
3481 before its static fields are used', i.e. initialization does not need
3482 to be triggered by the first access to the type. Setting this flag
3483 helps the JIT to compile better code, since it can run the static
3484 constructor at JIT time, and does not need to generate code to call it
3485 (possibly lots of times) at runtime. Unfortunately, mcs does not set
3486 this flag for lots of classes like String.
3488 csc sets this flag if the type does not have an explicit static
3489 constructor. The reasoning seems to be that if there are only static
3490 initalizers for a type, and no static constructor, then the programmer
3491 does not care when this initialization happens, so beforefieldinit
3494 This bug prevents the AOT compiler from being usable, since it
3495 generates so many calls to mono_runtime_class_init that the AOT code
3496 is much slower than the JITted code. The JITted code is faster,
3497 because it does not generate these calls if the vtable is type is
3498 already initialized, which is true in the majority of cases. But the
3499 AOT compiler can't do this."
3501 2004-03-10 Miguel de Icaza <miguel@ximian.com>
3503 * class.cs (MethodData.Emit): Refactor the code so symbolic
3504 information is generated for destructors; For some reasons we
3505 were taking a code path that did not generate symbolic information
3508 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
3510 * class.cs: Create a Constructor.CheckBase method that
3511 takes care of all validation type code. The method
3512 contains some code that was moved from Define.
3514 It also includes new code that checks for duplicate ctors.
3515 This fixes bug #55148.
3517 2004-03-09 Joshua Tauberer <tauberer@for.net>
3519 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
3520 a { ... }-style array creation invokes EmitStaticInitializers
3521 which is not good for reference-type arrays. String, decimal
3522 and now null constants (NullCast) are not counted toward
3523 static initializers.
3525 2004-03-05 Martin Baulig <martin@ximian.com>
3527 * location.cs (SourceFile.HasLineDirective): New public field;
3528 specifies whether the file contains or is referenced by a "#line"
3530 (Location.DefineSymbolDocuments): Ignore source files which
3531 either contain or are referenced by a "#line" directive.
3533 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
3535 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
3536 direct access to our parent, so check the method inline there.
3538 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
3540 * expression.cs (Invocation.EmitCall): Miguel's last commit
3541 caused a regression. If you had:
3546 In Foo the implict this would be null.
3548 2004-02-27 Miguel de Icaza <miguel@ximian.com>
3550 * expression.cs (Invocation.EmitCall): If the method is not
3551 virtual, do not emit a CallVirt to it, use Call.
3553 * typemanager.cs (GetFullNameSignature): Improve the method to
3554 cope with ".ctor" and replace it with the type name.
3556 * class.cs (ConstructorInitializer.Resolve): Now the method takes
3557 as an argument the ConstructorBuilder where it is being defined,
3558 to catch the recursive constructor invocations.
3560 2004-03-16 Martin Baulig <martin@ximian.com>
3562 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
3563 ConstructedType, call ResolveType() on it to get the type rather
3564 than just using `expr.Type'.
3566 2004-03-16 Martin Baulig <martin@ximian.com>
3568 * generics.cs (ConstructedType.GetMemberAccess): Take the
3569 EmitContext instead on the TypeExpr and use
3570 ec.TypeContainer.CurrentType/ec.ContainerType.
3572 2004-03-16 Martin Baulig <martin@ximian.com>
3574 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
3575 parameters before aliases.
3577 2004-03-16 Martin Baulig <martin@ximian.com>
3579 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
3580 New oublic function; checks whether two generic instances may become
3581 equal under some instantiations (26.3.1).
3583 * class.cs (TypeContainer.Define): Call
3584 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
3587 2004-03-16 Martin Baulig <martin@ximian.com>
3589 * class.cs (TypeContainer.GetClassBases): Moved
3590 Error_TypeParameterAsBase() here and also check whether the base
3591 class is not an attribute.
3593 2004-03-16 Martin Baulig <martin@ximian.com>
3595 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
3597 2004-03-16 Martin Baulig <martin@ximian.com>
3599 * class.cs (Error_TypeParameterAsBase): Use correct error number
3602 2004-03-16 Martin Baulig <martin@ximian.com>
3604 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
3607 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
3610 2004-03-15 Martin Baulig <martin@ximian.com>
3612 * typemanager.cs (TypeManager.GetFullName): New public method.
3613 (TypeManager.MemberLookup): Added `int_num_type_arguments'
3614 argument; only return members with the correct number of type
3616 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
3617 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
3618 whether the number of type arguments matches.
3620 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
3621 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
3623 * expression.cs (MemberAccess): Added public `NumTypeArguments'
3624 field; it's set by the protected .ctor when we're actually a
3625 GenericMemberAccess.
3626 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
3627 arguments and pass it to MemberLookupFinal ().
3629 * ecore.cs (Expression.MemberLookup): Added `int
3630 num_type_arguments' argument; only return members with the correct
3631 number of type arguments.
3632 (Expression.MemberLookupFailed): Check whether the MemberLookup
3633 failed because we did not have the correct number of type
3634 arguments; report CS0305 in this case.
3636 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
3637 `e.ResolveAsTypeTerminal()' already did so.
3639 2004-03-15 Martin Baulig <martin@ximian.com>
3641 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
3642 we're a ConstructedType; in this case, the caller must report an
3643 error (for instance CS0131).
3645 * generic.cs (TypeArguments): Added Location argument to the .ctor.
3646 (TypeArguments.Resolve): Actually report errors here.
3648 2004-03-15 Miguel de Icaza <miguel@ximian.com>
3650 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
3651 `set_indexer_name' to the pending bits (one per type).
3653 We fixed a bug today that was picking the wrong method to
3654 override, since for properties the existing InterfaceMethod code
3655 basically ignored the method name. Now we make sure that the
3656 method name is one of the valid indexer names.
3658 2004-03-15 Martin Baulig <martin@ximian.com>
3660 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
3661 for generic instances.
3663 2004-03-13 Martin Baulig <martin@ximian.com>
3665 * class.cs (TypeContainer.DefineType): Call
3666 TypeManager.AddUserType() immediately after creating the
3667 TypeBuilder; pass all type parameters when creating the
3670 * decl.cs (DeclSpace.FindNestedType): New public method.
3671 (DeclSpace.FindType): Added `int num_type_args' argument; only
3672 return types with the correct number of type parameters.
3673 (DeclSpace.CountTypeParams): New public property.
3675 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
3676 the number of type parameters; defaults to zero.
3678 * generic.cs (TypeArguments.Count): New public property.
3679 (ConstructedType.DoResolveAsTypeStep): First call
3680 ds.FindNestedType() to find out whether we're nested in the
3681 current generic type; in this case, we inherit all type parameters
3682 from the current class.
3684 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
3685 num_type_args' argument.
3686 (RootContext.LookupType): Added overloaded version which takes the
3687 number of type arguments; only return types with the correct
3688 number of type arguments.
3690 * typemanager.cs (TypeManager.CheckGeneric): New public function;
3691 checks whether `Type t' has `int num_type_args'.
3693 2004-03-13 Martin Baulig <martin@ximian.com>
3695 * generic.cs (GenericMethod.DefineType): New method; calls
3696 DefineType() on all the type parameters.
3698 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
3699 (MethodData.Define): If we're a generic method, call
3700 GenericMethod.DefineType() to define the type parameters.
3702 2004-03-10 Martin Baulig <martin@ximian.com>
3704 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
3705 instead of IsAssignableFrom.
3707 2004-03-10 Martin Baulig <martin@ximian.com>
3709 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
3711 * support.cs (ParameterData.HasArrayParameter): New property.
3712 (ReflectionParameters.ctor): Take a MethodBase instead of a
3713 ParameterInfo[]. If we have any type parameters, get the generic
3714 method definition and ask it whether we have variable arguments.
3716 2004-02-26 Miguel de Icaza <miguel@ximian.com>
3718 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
3719 routines to check if a type is an enumerable/enumerator allow
3720 classes that implement the IEnumerable or IEnumerator interfaces.
3722 * class.cs (Property, Operator): Implement IIteratorContainer, and
3723 implement SetYields.
3725 (Property.Define): Do the block swapping for get_methods in the
3726 context of iterators. We need to check if Properties also
3727 include indexers or not.
3729 (Operator): Assign the Block before invoking the
3730 OperatorMethod.Define, so we can trigger the Iterator code
3733 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
3734 Property and Operator classes are not created when we parse the
3735 declarator but until we have the block completed, so we use a
3736 singleton SimpleIteratorContainer.Simple to flag whether the
3737 SetYields has been invoked.
3739 We propagate this setting then to the Property or the Operator to
3740 allow the `yield' to function.
3742 2004-02-25 Marek Safar <marek.safar@seznam.cz>
3744 * codegen.cs: Implemented attribute support for modules.
3745 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
3746 Assembly/Module functionality.
3748 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
3749 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
3750 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
3752 2004-02-16 Marek Safar <marek.safar@seznam.cz>
3754 * interface.cs (FindMembers): The operation is performed on all base
3755 interfaces and not only on the first. It is required for future CLS Compliance patch.
3757 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
3759 * statement.cs, codegen.cs:
3760 This patch deals with patterns such as:
3762 public class List : IEnumerable {
3764 public MyEnumerator GetEnumerator () {
3765 return new MyEnumerator(this);
3768 IEnumerator IEnumerable.GetEnumerator () {
3772 public struct MyEnumerator : IEnumerator {
3777 Before, there were a few things we did wrong:
3778 1) we would emit callvirt on a struct, which is illegal
3779 2) we emited ldarg when we needed to emit ldarga
3780 3) we would mistakenly call the interface methods on an enumerator
3781 type that derived from IEnumerator and was in another assembly. For example:
3783 public class MyEnumerator : IEnumerator
3785 Would have the interface methods called, even if there were public impls of the
3786 method. In a struct, this lead to invalid IL code.
3788 2004-02-11 Marek Safar <marek.safar@seznam.cz>
3790 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
3793 * delegate.cs (Define): Fixed crash when delegate type is undefined.
3795 2004-02-11 Miguel de Icaza <miguel@ximian.com>
3797 * cs-parser.jay: Fix small regression: we were not testing V2
3798 compiler features correctly.
3800 * interface.cs: If the emit context is null, then create one
3802 2004-02-09 Marek Safar <marek.safar@seznam.cz>
3804 * decl.cs (GetSignatureForError): New virtual method to get full name
3807 * attribute.cs (IAttributeSupport): New interface for attribute setting.
3808 Now it is possible to rewrite ApplyAttributes method to be less if/else.
3810 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
3811 Duplicated members and code in these classes has been removed.
3812 Better encapsulation in these classes.
3814 2004-02-07 Miguel de Icaza <miguel@ximian.com>
3816 * assign.cs (Assign.DoResolve): When dealing with compound
3817 assignments, there is a new rule in ECMA C# 2.4 (might have been
3818 there before, but it is documented here) that states that in:
3822 If b is of type int, and the `op' is a shift-operator, then the
3823 above is evaluated as:
3827 * expression.cs (Binary.ResolveOperator): Instead of testing for
3828 int/uint/long/ulong, try to implicitly convert to any of those
3829 types and use that in pointer arithmetic.
3831 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
3832 method to print information for from the type, not from the
3833 null-method we were given.
3835 2004-02-01 Duncan Mak <duncan@ximian.com>
3837 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
3838 parsing for cmd, fixes bug #53694.
3840 2004-02-04 Marek Safar <marek.safar@seznam.cz>
3842 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
3843 in the member name duplication tests. Property and operator name duplication
3844 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
3846 2004-02-03 Marek Safar <marek.safar@seznam.cz>
3848 * interface.cs (PopulateMethod): Fixed crash when interface method
3849 returns not existing type (error test cs0246-3.cs).
3851 2004-02-02 Ravi Pratap M <ravi@ximian.com>
3853 * cs-parser.jay (interface_accessors): Re-write actions to also
3854 store attributes attached to get and set methods. Fix spelling
3857 (inteface_property_declaration): Modify accordingly.
3859 (InterfaceAccessorInfo): New helper class to store information to pass
3860 around between rules that use interface_accessors.
3862 * interface.cs (Emit): Apply attributes on the get and set
3863 accessors of properties and indexers too.
3865 * attribute.cs (ApplyAttributes): Modify accordingly to use the
3866 right MethodBuilder when applying attributes to the get and set accessors.
3868 2004-01-31 Miguel de Icaza <miguel@ximian.com>
3870 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
3872 2004-01-26 Miguel de Icaza <miguel@ximian.com>
3874 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
3876 2004-01-25 Miguel de Icaza <miguel@ximian.com>
3878 * cs-parser.jay: Remove YIELD token, instead use the new grammar
3879 changes that treat `yield' specially when present before `break'
3882 * cs-tokenizer.cs: yield is no longer a keyword.
3884 2004-01-23 Marek Safar <marek.safar@seznam.cz>
3886 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
3887 setting for default constructors.
3888 For default constructors are almost every time set wrong Modifier. The
3889 generated IL code has been alright. But inside mcs this values was
3890 wrong and this was reason why several of my CLS Compliance tests
3893 2004-02-27 Martin Baulig <martin@ximian.com>
3895 * generics.cs (ConstructedType.ResolveType): Make the nested type
3896 stuff actually work.
3898 2004-02-25 Martin Baulig <martin@ximian.com>
3900 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
3901 property; returns the type parameters just from the current type,
3902 ie. with the ones from outer classes.
3903 (DeclSpace.LookupGeneric): First search in the current class, then
3905 (DeclSpace.initialize_type_params): When hiding a type parameter
3906 from an outer class, put it into the `type_param_list' anyways.
3908 * expression.cs (MemberAccess.expr): Made this field protected.
3910 * class.cs (TypeContainer.Define): The `CurrentType' just contains
3911 the type parameters from the current class.
3913 * generic.cs (ConstructedType.ResolveType): Support nested generic
3914 types by taking the type parameters which we inherit from outer
3915 classes into account.
3916 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
3917 support for nested generic types.
3919 2004-02-23 Martin Baulig <martin@ximian.com>
3921 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
3922 field and check whether we're nested inside a generic type.
3923 (DeclSpace.ResolveType): If we're resolving to a generic type
3924 definition, create a ConstructedType and return its resolved type.
3925 (DeclSpace.initialize_type_params): New private method;
3926 initializes the `type_param_list' field from the type parameters
3927 from this and all enclosing classes.
3928 (DeclSpace.TypeParameters): Call initialize_type_params() unless
3929 we're already initialized.
3931 2004-02-23 Martin Baulig <martin@ximian.com>
3933 * class.cs (Method.Define): Create the generic method before
3935 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
3936 the TypeContainer one); we use this for generic methods.
3938 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
3939 parent's TypeBuilder.
3941 2004-02-18 Martin Baulig <martin@ximian.com>
3943 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
3944 to check for equality.
3946 2004-02-05 Martin Baulig <martin@ximian.com>
3948 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
3949 `ec.TypeContainer.CurrentType', use it instead of
3950 `ec.ContainerType' to check whether we're in the type's ctor.
3952 2004-01-29 Martin Baulig <martin@ximian.com>
3954 * expression.cs (Invocation.DoResolve): If we're a
3955 `ConstructedType', then we're actually a generic method, so
3956 rewrite the expr as a GenericMemberAccess.
3958 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
3959 here; manually parse it into a string.
3961 2004-01-28 Martin Baulig <martin@ximian.com>
3963 * typemanager.cs (TypeManager.IsEqual): New static method.
3964 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
3965 check for equality instead of using `=='.
3967 2004-01-26 Martin Baulig <martin@ximian.com>
3969 * decl.cs (DeclSpace.CurrentType): New public field.
3971 * expression.cs (This.ResolveBase): If we have an
3972 `ec.TypeContainer.CurrentType', use it instead of
3975 * class.cs (TypeContainer.DefineType): If we're a generic type,
3976 create the `CurrentType' (unresolved).
3977 (TypeContainer.GenericType): New private field.
3978 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
3979 it and store it in `GenericType' before creating the MemberCache.
3980 (TypeContainer.GetMembers): If we have a `GenericType', call
3981 TypeManager.FindMembers() on it.
3983 * interface.cs (Interface.GenericType): New private field.
3984 (Interface.DefineType): If we're a generic type, create the
3985 `CurrentType' (unresolved).
3986 (Interface.DefineMembers): If we have a `CurrentType', resolve it
3987 and store it in `GenericType' before creating the MemberCache.
3988 (Interface.GetMembers): If we have a `GenericType', call
3989 TypeManager.FindMembers() on it.
3991 2004-01-22 Martin Baulig <martin@ximian.com>
3993 * cs-parser.jay (namespace_or_type_name): Return an Expression,
3994 not a QualifiedIdentifier. This is what `type_name_expression'
3995 was previously doing.
3996 (type_name_expression): Removed; the code is now in
3997 `namespace_or_type_name'.
3998 (qualified_identifier): Removed, use `namespace_or_type_name'
4000 (QualifiedIdentifier): Removed this class.
4002 2004-01-22 Martin Baulig <martin@ximian.com>
4004 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4005 not a string as alias name.
4007 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4009 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4010 #52730 bug, and instead compute correctly the need to use a
4011 temporary variable when requesting an address based on the
4012 static/instace modified of the field and the constructor.
4014 2004-01-21 Martin Baulig <martin@ximian.com>
4016 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4017 class and namespace before looking up aliases. Fixes #52517.
4019 2004-01-21 Martin Baulig <martin@ximian.com>
4021 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4022 assinged in a 'try'; fixes exception4.cs.
4024 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4025 * class.cs : Implemented parameter-less constructor for TypeContainer
4027 * decl.cs: Attributes are now stored here. New property OptAttributes
4029 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4031 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4033 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4035 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4036 (CSharpSignature): New method for indexer and property signature.
4038 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4040 * pending.cs (IsVirtualFilter): Faster implementation.
4042 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4044 * typemanager.cs: Avoid inclusion of same assembly more than once.
4046 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4048 * cs-parser.jay: Fixed problem where the last assembly attribute
4049 has been applied also to following declaration (class, struct, etc.)
4051 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4053 * class.cs: Added error CS0538, CS0539 reporting.
4054 Fixed crash on Microsoft runtime when field type is void.
4056 * cs-parser.jay: Added error CS0537 reporting.
4058 * pending.cs: Added error CS0535 reporting.
4059 Improved error report for errors CS0536, CS0534.
4061 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4063 Merge a few bits from the Anonymous Method MCS tree.
4065 * statement.cs (ToplevelBlock): New class for toplevel methods,
4066 will hold anonymous methods, lifted variables.
4068 * cs-parser.jay: Create toplevel blocks for delegates and for
4069 regular blocks of code.
4071 2004-01-20 Martin Baulig <martin@ximian.com>
4073 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4074 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4075 and `NeedExplicitReturn'; added `IsLastStatement'.
4076 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4077 have a `ReturnLabel' or we're not unreachable.
4079 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4080 child's reachability; don't just override ours with it. Fixes
4081 #58058 (lluis's example).
4082 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4083 InFinally(), InLoop(), InSwitch() and
4084 BreakCrossesTryCatchBoundary() methods.
4086 * statement.cs (Return): Do all error checking in Resolve().
4087 Unless we are the last statement in a top-level block, always
4088 create a return label and jump to it.
4089 (Break, Continue): Do all error checking in Resolve(); also make
4090 sure we aren't leaving a `finally'.
4091 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4092 statement in a top-level block.
4093 (Block.Flags): Added `IsDestructor'.
4094 (Block.IsDestructor): New public property.
4096 2004-01-20 Martin Baulig <martin@ximian.com>
4098 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4100 2004-01-20 Martin Baulig <martin@ximian.com>
4102 * statement.cs (Statement.ResolveUnreachable): New public method.
4103 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4104 (Block.Resolve): Resolve unreachable statements.
4106 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4108 * expression.cs: We need to fix the case where we do
4109 not have a temp variable here.
4111 * assign.cs: Only expression compound assignments need
4112 temporary variables.
4114 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4116 * flowanalysis.cs: Reduce memory allocation in a few ways:
4117 - A block with no variables should not allocate a bit
4119 - A method with no out parameters does not need any tracking
4120 for assignment of the parameters, so we need not allocate
4123 public readonly Type[] VariableTypes;
4124 public readonly string[] VariableNames;
4125 Are redundant. The data is already stored in the variable
4126 map, so we need not allocate another array for it.
4127 - We need to add alot of checks for if (params | locals) == null
4128 due to the first two changes.
4130 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4132 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4133 implement IMemoryLocation, we store a copy on a local variable and
4134 take the address of it. Patch from Benjamin Jemlich
4136 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4137 to use a special "type_name_expression" rule which reduces the
4138 number of "QualifiedIdentifier" classes created, and instead
4139 directly creates MemberAccess expressions.
4141 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4143 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4144 that fixes #52853. Null literal assignment to ValueType
4146 * class.cs (MethodData.Emit): Instead of checking the name of the
4147 method to determine if its a destructor, create a new derived
4148 class from Method called Destructor, and test for that.
4150 * cs-parser.jay: Create a Destructor object instead of a Method.
4152 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4156 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4158 * expression.cs (Binary.ResolveOperator): Perform an implicit
4159 conversion from MethodGroups to their delegate types on the
4162 * delegate.cs: Introduce a new class DelegateCreation that is the
4163 base class for `NewDelegate' and `ImplicitDelegateCreation',
4164 factor some code in here.
4166 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4167 conversion from MethodGroups to compatible delegate types.
4169 * ecore.cs (Expression.Resolve): Do not flag error 654
4170 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4171 we allow conversions from MethodGroups to delegate types now.
4173 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4174 assignments in v2 either.
4176 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4178 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4179 static read-only fields in ctors.
4181 Applied patch from Benjamin Jemlich
4183 * expression.cs (UnaryMutator): Avoid leaking local variables.
4185 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4187 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4188 here to return true, as they can be used like this:
4192 Fixed 49836 and all the other dups
4194 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4196 * driver.cs: Implement /win32res and /win32icon.
4198 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4200 * cs-parser.jay: Add a rule to improve error handling for the
4201 common mistake of placing modifiers after the type.
4203 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4205 * cs-parser.jay (interface_event_declaration): Catch
4206 initialization of events on interfaces, and report cs0068
4208 * cs-parser.jay (interface_event_declaration): Catch
4209 initialization of events.
4211 * ecore.cs: Better report missing constructors.
4213 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4214 the error reporting done in the wrong place. Fix.
4216 * expression.cs (Binary.ResolveOperator): Catch the
4217 operator + (E x, E y) error earlier, and later allow for implicit
4218 conversions in operator +/- (E e, U x) from U to the underlying
4221 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4222 52596, if the container class is abstract, the default constructor
4223 is protected otherwise its public (before, we were always public).
4225 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4228 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4229 Jemlich that fixes bug #52597, MCS was generating invalid code for
4230 idisposable structs. Thanks to Ben for following up with this
4233 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4235 * driver.cs: Allow assemblies without code to be generated, fixes
4238 2004-01-07 Nick Drochak <ndrochak@gol.com>
4240 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4242 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4244 * cs-parser.jay: Add rules to improve error reporting if fields or
4245 methods are declared at the namespace level (error 116)
4247 * Add rules to catch event add/remove
4249 2004-01-04 David Sheldon <dave-mono@earth.li>
4251 * expression.cs: Added matching ")" to error message for
4254 2004-01-03 Todd Berman <tberman@gentoo.org>
4256 * ecore.cs, attribute.cs:
4257 Applying fix from #52429.
4259 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4261 * ecore.cs, expression.cs, statement.cs:
4262 Total rewrite of how we handle branching. We
4263 now handle complex boolean expressions with fewer
4264 jumps. As well if (x == 0) no longer emits a ceq.
4266 if (x is Foo) is much faster now, because we generate
4269 Overall, we get a pretty big improvement on our benchmark
4270 tests. The code we generate is smaller and more readable.
4272 I did a full two-stage bootstrap. The patch was reviewed
4273 by Martin and Miguel.
4275 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4277 * cs-parser.jay: Make primary_expression not take a QI.
4278 we dont need this because the member_access rule covers
4279 us here. So we replace the rule with just IDENTIFIER.
4281 This has two good effects. First, we remove a s/r conflict.
4282 Second, we allocate many fewer QualifiedIdentifier objects.
4284 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4286 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4287 set the correct information via SRE. This prevents
4288 hanging on the MS runtime. Fixes #29374.
4290 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4292 * convert.cs: correctly handle conversions to value types
4293 from Enum and ValueType as unboxing conversions.
4295 Fixes bug #52569. Patch by Benjamin Jemlich.
4297 2004-01-02 Ravi Pratap <ravi@ximian.com>
4299 * expression.cs (BetterConversion): Prefer int -> uint
4300 over int -> ulong (csc's behaviour). This fixed bug #52046.
4302 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4304 * decl.cs (MemberCache.FindMembers): now returns a
4307 * typemanager.cs: In general, go with with ^^.
4308 (CopyNewMethods): take an IList.
4309 (RealMemberLookup): Only allocate an arraylist
4310 if we copy from two sets of methods.
4312 This change basically does two things:
4313 1) Fewer array lists allocated due to CopyNewMethods.
4314 2) the explicit cast in MemberList costed ALOT.
4316 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
4318 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
4319 a hashtable to avoid needless string allocations when an identifier is
4320 used more than once (the common case).
4322 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4324 * pending.cs: MS's TypeBuilder.GetInterfaces ()
4325 is broken, it will not return anything. So, we
4326 have to use the information we have in mcs to
4329 * typemanager.cs: Add a cache for GetInterfaces,
4330 since this will now be used more often (due to ^^)
4332 (GetExplicitInterfaces) New method that gets the
4333 declared, not effective, interfaces on a type
4334 builder (eg, if you have interface IFoo, interface
4335 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
4338 This patch makes MCS able to bootstrap itself on
4341 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4343 * expression.cs: Remove the Nop's that Miguel put
4346 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4348 * report.cs, codegen.cs: Give the real stack trace to
4349 the error when an exception is thrown.
4351 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4353 * decl.cs: only allocate hashtables for ifaces if
4356 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4358 * expression.cs: fix the error from cs0121-2.cs
4359 (a parent interface has two child interfaces that
4360 have a function with the same name and 0 params
4361 and the function is called through the parent).
4363 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
4365 * class.cs, rootcontext.cs, typmanager.cs: do not
4368 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
4370 * codegen.cs: remove stack for the ec flow branching.
4371 It is already a linked list, so no need.
4373 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
4375 * Makefile: Allow custom profiler here.
4377 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4379 * typemanager.cs (LookupType):
4380 - Use a static char [], because split takes
4381 a param array for args, so it was allocating
4383 - Do not store true in a hashtable, it boxes.
4385 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4387 * flowanalysis.cs: bytify common enums.
4389 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4391 * modifiers.cs: Add a new set of flags for the
4392 flags allowed on explicit interface impls.
4393 * cs-parser.jay: catch the use of modifiers in
4394 interfaces correctly.
4395 * class.cs: catch private void IFoo.Blah ().
4397 All related to bug #50572.
4399 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4401 * decl.cs: Rewrite the consistant accessability checking.
4402 Accessability is not linear, it must be implemented in
4403 a tableish way. Fixes #49704.
4405 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4407 * expression.cs: Handle negation in a checked context.
4408 We must use subtraction from zero. Fixes #38674.
4410 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4412 * class.cs: Ignore static void main in DLLs.
4413 * rootcontext.cs: Handle the target type here,
4414 since we are have to access it from class.cs
4415 * driver.cs: account for the above.
4417 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4419 * report.cs: Give line numbers and files if available.
4421 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
4423 * driver.cs: Implement /addmodule.
4425 * typemanager.cs: Change 'modules' field so it now contains Modules not
4428 2003-12-20 Martin Baulig <martin@ximian.com>
4430 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
4431 (FieldBase.IsAssigned): Removed this field.
4432 (FieldBase.SetAssigned): New public method.
4433 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
4435 2003-12-20 Martin Baulig <martin@ximian.com>
4437 * expression.cs (LocalVariableReference.DoResolve): Don't set
4438 `vi.Used' if we're called from DoResolveLValue().
4440 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
4441 returns the usage vector it just merged into the current one -
4442 pass this one to UsageWarning().
4443 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
4444 of the `EmitContext', don't call this recursively on our children.
4446 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
4448 * driver.cs: Implement /target:module.
4450 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
4452 * support.cs (CharArrayHashtable): New helper class.
4454 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
4455 char arrays, not strings, so we can avoid creating a string in
4456 consume_identifier if the identifier is a keyword.
4458 2003-12-16 Martin Baulig <martin@ximian.com>
4460 * statement.cs (LocalInfo.Assigned): Removed this property.
4461 (LocalInfo.Flags): Removed `Assigned'.
4462 (LocalInfo.IsAssigned): New public method; takes the EmitContext
4463 and uses flow analysis.
4464 (Block.UsageWarning): Made this method private.
4465 (Block.Resolve): Call UsageWarning() if appropriate.
4467 * expression.cs (LocalVariableReference.DoResolve): Always set
4468 LocalInfo.Used here.
4470 2003-12-13 Martin Baulig <martin@ximian.com>
4472 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
4473 any value here; we're now using flow analysis to figure out
4474 whether a statement/block returns a value.
4476 2003-12-13 Martin Baulig <martin@ximian.com>
4478 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
4480 (FlowBranching.MergeFinally): Don't call
4481 `branching.CheckOutParameters()' here, this is called in
4483 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
4484 when adding the `finally' vector.
4486 2003-12-13 Martin Baulig <martin@ximian.com>
4489 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
4490 actually work and also fix #48962.
4492 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
4494 * decl.cs: Do not check System.Object for nested types,
4495 since we know it does not have any. Big bang for buck:
4500 corlib: 17.99 seconds
4504 corlib: 17.39 seconds
4506 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
4508 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
4509 time we are returning 0 members, so we save alot here.
4511 2003-12-11 Martin Baulig <martin@ximian.com>
4513 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
4514 `MergeChild()', also just take the `FlowBranching' as argument;
4515 call Merge() on it and return the result.
4516 (FlowBranching.Merge): We don't need to do anything if we just
4519 2003-12-11 Martin Baulig <martin@ximian.com>
4521 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
4522 them in an `ArrayList' to reduce memory usage. Thanks to Ben
4523 Maurer for this idea.
4525 2003-12-11 Martin Baulig <martin@ximian.com>
4527 * flowanalysis.cs (MergeResult): This class is now gone; we now
4528 use the `UsageVector' for this. The reason for this is that if a
4529 branching just has one sibling, we don't need to "merge" them at
4530 all - that's the next step to do.
4531 (FlowBranching.Merge): We now return a `UsageVector' instead of a
4534 2003-12-11 Martin Baulig <martin@ximian.com>
4536 Reworked flow analyis and made it more precise and bug-free. The
4537 most important change is that we're now using a special `Reachability'
4538 class instead of having "magic" meanings of `FlowReturns'. I'll
4539 do some more cleanups and optimizations and also add some more
4540 documentation this week.
4542 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
4543 largely reworked this class.
4544 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
4545 the new `Reachability' class instead of having "magic" values here.
4546 (FlowBranching): We're now using an instance of `Reachability'
4547 instead of having separate `Returns', `Breaks' etc. fields.
4549 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
4550 based on flow analysis; ignore the return value of block.Emit ().
4552 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
4554 * driver.cs typemanager.cs: Find the mono extensions to corlib even
4555 if they are private.
4557 2003-12-09 Martin Baulig <martin@ximian.com>
4559 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
4560 call them directly on the UsageVector.
4562 2003-12-09 Martin Baulig <martin@ximian.com>
4564 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
4565 Changed return type from `FlowReturns' to `Reachability'.
4567 2003-12-09 Martin Baulig <martin@ximian.com>
4569 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
4570 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
4571 `Reachable' fields with a single `Reachability' one.
4573 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4575 * class.cs (FindMembers): Remove foreach's.
4588 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4593 This patch does a few things:
4594 1. EmptyStatement is now a singleton, so it is never reallocated.
4595 2. All blah is EmptyStatement constructs have been changed to
4596 blah == EmptyStatement.Value, which is much faster and valid
4597 now that EmptyStatement is a singleton.
4598 3. When resolving a block, rather than allocating a new array for
4599 the non-empty statements, empty statements are replaced with
4600 EmptyStatement.Value
4601 4. Some recursive functions have been made non-recursive.
4602 Mainly the performance impact is from (3), however (1) and (2) are needed for
4603 this to work. (4) does not make a big difference in normal situations, however
4604 it makes the profile look saner.
4609 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4610 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4611 Total memory allocated: 56397 KB
4614 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
4615 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
4616 Total memory allocated: 55666 KB
4618 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4620 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
4621 than the hashtable in a hashtable version
4623 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
4624 we always end up concating a string. This results in a huge perf
4625 loss, because many strings have to be tracked by the GC. In this
4626 patch, we first use a hashtable that works with two keys, so that
4627 the strings do not need to be concat'ed.
4638 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4640 * Makefile: Add a new target `do-time' that does a quick and simple
4641 profile, leaving easy to parse output.
4643 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
4645 * codegen.cs (Init): Create the dynamic assembly with
4646 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
4648 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
4650 * support.cs: Make the PtrHashtable use only one
4651 instance of its comparer.
4653 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
4655 * typemanager.cs: Fix lookup of GetNamespaces.
4657 2003-11-29 Miguel de Icaza <miguel@ximian.com>
4659 * expression.cs: Removed redundant line.
4661 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
4662 ArrayLists, use for loops with bounds.
4664 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
4667 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
4668 arraylists, use for loop with bounds.
4670 The above three changes give us a 0.071 second performance
4671 improvement out of 3.294 seconds down to 3.223. On my machine
4672 the above changes reduced the memory usage by 1,387 KB during
4675 * cs-parser.jay (QualifiedIdentifier): New class used to represent
4676 QualifiedIdentifiers. Before we created a new string through
4677 concatenation, and mostly later on, the result would be
4678 manipulated by DecomposeQI through string manipulation.
4680 This reduced the compiler memory usage for bootstrapping from
4681 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
4682 compile times in 0.05 seconds.
4684 2003-11-28 Dick Porter <dick@ximian.com>
4686 * support.cs: Do string compares with the Invariant culture.
4694 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
4695 the comparison is done with the Invariant culture.
4697 2003-11-27 Miguel de Icaza <miguel@ximian.com>
4699 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
4700 GetEnumerator method.
4702 (ProbeCollectionType): Iterate starting at the most specific type
4703 upwards looking for a GetEnumerator
4705 * expression.cs: Shift count can be up to 31 for int/uint and 63
4708 2003-11-26 Miguel de Icaza <miguel@ximian.com>
4710 * statement.cs (Block.LookupLabel): Also look for the label on the
4711 children blocks. Use a hash table to keep track of visited
4714 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
4715 we actually did transform the other operand, otherwise fall back
4716 to the common codepath that casts to long.
4718 * cs-tokenizer.cs: Use the same code pattern as the int case.
4719 Maybe I should do the parsing myself, and avoid depending on the
4720 Parse routines to get this done.
4722 2003-11-25 Miguel de Icaza <miguel@ximian.com>
4724 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
4725 which fixes bug 51347. This time test it.
4727 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
4728 attributes for example can not tell the difference between these.
4729 The difference was only a syntax feature of the language.
4731 * attribute.cs: Apply attributes to delegates.
4733 * delegate.cs: Call the apply attributes method.
4735 2003-11-24 Miguel de Icaza <miguel@ximian.com>
4737 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
4738 comparing 0 vs Byte.MinValue, not the value
4740 (ImplicitConversionRequired): When reporting a conversion error,
4741 use error 31 to print out the constant error instead of the
4744 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
4745 which fixes bug 51347.
4747 2003-11-22 Miguel de Icaza <miguel@ximian.com>
4749 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
4750 which fixes the -warnaserror command line option.
4752 2003-11-21 Miguel de Icaza <miguel@ximian.com>
4754 * cfold.cs (DoNumericPromotions): During constant folding of
4755 additions on UIntConstant, special case intconstants with
4756 IntConstants like we do on the expression binary operator.
4758 2003-11-12 Miguel de Icaza <miguel@ximian.com>
4760 * convert.cs (ImplicitReferenceConversion): We were missing a case
4761 (System.Enum are not value types or class types, so we need to
4762 classify them separatedly).
4764 * driver.cs: We do not support error 2007.
4766 2003-11-12 Jackson Harper <jackson@ximian.com>
4768 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
4769 system directory. Also use the full file name so users can
4770 libraries names mscorlib-o-tron.dll in a non system dir.
4772 2004-01-04 David Sheldon <dave-mono@earth.li>
4774 * expression.cs: Added matching ")" to error message for CS0077.
4776 2003-12-19 Martin Baulig <martin@ximian.com>
4778 * typemanager.cs (TypeManager.IsEqualGenericType): New public
4779 static method; see documentation in the method.
4780 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
4782 * convert.cs (Convert.ImplicitReferenceConversion,
4783 Convert.ImplicitReferenceConversionExists): Add support for
4784 generic type declarations; see gen-36.cs.
4786 2003-12-19 Martin Baulig <martin@ximian.com>
4788 * pending.cs (Pending.InterfaceMethod): Use
4789 `Type.IsAssignableFrom()' instead of `=='.
4791 2003-12-18 Martin Baulig <martin@ximian.com>
4793 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
4796 * convert.cs (Convert.ImplicitStandardConversionExists): Use
4797 `expr_type.Equals (target_type)' instead of `=='.
4799 2003-12-08 Martin Baulig <martin@ximian.com>
4801 * generics.cs (Constraints.Types): Removed.
4802 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
4804 (Constraints.ResolveTypes): New public method; resolves the
4805 TypeExpr's to Type's.
4806 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
4807 longer takes the constraints.
4808 (TypeParameter.DefineMethod): Likewise.
4809 (TypeParameter.DefineType): New public method. Calls
4810 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
4813 2003-12-08 Martin Baulig <martin@ximian.com>
4815 * convert.cs (Convert.ImplicitConversionStandard): Use
4816 `expr_type.Equals (target_type)' instead of `=='.
4818 2003-12-08 Martin Baulig <martin@ximian.com>
4820 * typemanager.cs (TypeManager.GetReferenceType): Call
4821 `Type.MakeByRefType ()'.
4823 2003-12-08 Martin Baulig <martin@ximian.com>
4825 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
4826 just has some special meaning in some situations. For instance,
4827 it is allowed to use `where' as the name of a variable etc.
4829 2003-12-04 Martin Baulig <martin@ximian.com>
4831 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
4832 `Type.MakeArrayType()' for array types.
4834 2003-11-18 Miguel de Icaza <miguel@ximian.com>
4836 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
4839 (SizeOf.DoResolve): assign the `type_queried' field. This gets
4842 2003-11-16 Martin Baulig <martin@ximian.com>
4844 * codegen.cs (EmitContext.IsGeneric): Removed.
4846 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
4847 ResolveGeneric() on the DeclSpace.
4849 2003-11-16 Martin Baulig <martin@ximian.com>
4851 * generic.cs (TypeArguments.Resolve):
4852 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
4853 `ResolveType()' on it to get the Type.
4855 2003-11-15 Martin Baulig <martin@ximian.com>
4857 * generic.cs (ConstructedType.GetInterfaces): Override this.
4859 2003-11-14 Martin Baulig <martin@ximian.com>
4861 * interface.cs (Interface.DefineType): Define all type parameters
4862 before adding the interfaces we inherit.
4864 2003-11-11 Martin Baulig <martin@ximian.com>
4866 * generic.cs (ConstructedType.ResolveType): Always call
4867 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
4869 2003-11-10 Martin Baulig <martin@ximian.com>
4871 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
4872 (TypeManager.InitCoreTypes): Initialize them here, but instead of
4873 calling `ResolveType()' on them, directly assign their `Type'.
4875 2003-11-08 Martin Baulig <martin@ximian.com>
4877 * generic.cs (ConstructedType): Override `IsClass' etc.
4879 2003-11-08 Martin Baulig <martin@ximian.com>
4881 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
4882 return value and the `out parent' parameter.
4883 (TypeContainer.DefineType): Moved the CS0644 check into
4884 GetClassBases(). Don't pass the interface types to the
4885 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
4886 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
4888 * ecore.cs (TypeExpr.IsAttribute): New property.
4889 (TypeExpr.GetInterfaces): New method.
4891 * interface.cs (Interface.GetInterfaceTypeByName): Return a
4892 TypeExpr instead of a Type.
4893 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
4894 (Interface.DefineType): Don't pass the interface types to the
4895 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
4896 them later and then call `TypeBulider.AddInterfaceImplementation()'.
4898 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
4899 instead of a `Type[]'.
4900 (TypeManager.RegisterBuilder): Likewise.
4901 (TypeManager.AddUserInterface): Likewise.
4902 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
4903 `Type[]' and also return a `TypeExpr[]'.
4904 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
4906 2003-11-08 Martin Baulig <martin@ximian.com>
4908 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
4911 2003-11-08 Martin Baulig <martin@ximian.com>
4913 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
4914 TypeManager.ResolveExpressionTypes().
4916 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
4917 instead of an Expression.
4918 (TypeExpr): This is now an abstract base class for `TypeExpression'.
4919 (TypeExpression): New public class; formerly known as `TypeExpr'.
4921 * expression.cs (ComposedCast): Derive from TypeExpr.
4923 * typemanager.cs (TypeManager.system_*_expr): These are now
4924 TypExpr's instead of Expression's.
4925 (TypeManager.ResolveExpressionTypes): New public static function;
4926 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
4929 2003-11-06 Miguel de Icaza <miguel@ximian.com>
4931 * expression.cs (New.DoResolve): Do not dereference value that
4932 might be a null return.
4934 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
4935 sure that the constant value has the right type. Fixes an
4936 unreported bug, similar to 50425.
4938 * const.cs (Const.LookupConstantValue): Call
4939 ImplicitStandardConversionExists before doing a conversion to
4940 avoid havng the TypeManager.ChangeType do conversions.
4942 Reduced the number of casts used
4944 (Const.ChangeType): New routine to enable reuse of the constant
4945 type changing code from statement.
4947 * typemanager.cs (ChangeType): Move common initialization to
4948 static global variables.
4952 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
4953 every value type to go through, even if it was void. Fix that.
4955 * cs-tokenizer.cs: Use is_identifier_start_character on the start
4956 character of the define, and the is_identifier_part_character for
4957 the rest of the string.
4959 2003-11-05 Miguel de Icaza <miguel@ximian.com>
4961 * expression.cs (UnaryMutator.EmitCode): When I updated
4962 LocalVariableReference.DoResolve, I overdid it, and dropped an
4963 optimization done on local variable references.
4965 2003-11-04 Miguel de Icaza <miguel@ximian.com>
4967 * ecore.cs: Convert the return from Ldlen into an int.
4969 2003-10-20 Miguel de Icaza <miguel@ximian.com>
4971 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
4972 the accessibility, this is a special case for toplevel non-public
4973 classes (internal for instance).
4975 2003-10-20 Nick Drochak <ndrochak@gol.com>
4977 * ecore.cs: Fix typo and build. Needed another right paren.
4979 2003-10-19 Miguel de Icaza <miguel@ximian.com>
4981 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
4982 `internal' case regular and protected, but not allowing protected
4983 to be evaluated later. Bug 49840
4985 2003-10-15 Miguel de Icaza <miguel@ximian.com>
4987 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
4988 to kb.Nlast, and not the kb.nFirst to isolate the switch
4991 Extract the underlying type, so enumerations of long/ulong are
4992 treated like long/ulong.
4994 2003-10-14 Miguel de Icaza <miguel@ximian.com>
4996 * expression.cs (New): Overload the meaning of RequestedType to
4997 track the possible creation of the NewDelegate type, since
4998 DoResolve is invoked more than once for new constructors on field
5001 See bugs: #48800 and #37014
5003 * cs-parser.jay (declare_local_constants): Take an arraylist
5004 instead of a single constant.
5006 (local_constant_declaration): It should take a
5007 constant_declarators, not a constant_declarator. Fixes 49487
5009 * convert.cs: Fix error report.
5011 2003-10-13 Jackson Harper <jackson@ximian.com>
5013 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5016 2003-11-03 Martin Baulig <martin@ximian.com>
5018 * expression.cs (ArrayAccess.GetStoreOpcode): Added
5019 `out bool has_type_arg'; if set, we need to pass the type to
5021 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
5022 Stelem_Any/Ldelem_Any for generic parameters.
5024 2003-11-02 Martin Baulig <martin@ximian.com>
5026 * expression.cs (Invocation.EmitCall): Use
5027 `TypeManager.IsValueType()' to check whether it's a value type.
5028 Don't set `struct_call' when calling a method on a type parameter.
5030 2003-11-02 Martin Baulig <martin@ximian.com>
5032 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
5033 and removed the TypeBuilder argument.
5035 * typemanager.cs (TypeManager.IsValueType): Return
5036 `t.IsGenericParameter || t.IsValueType'.
5038 2003-10-25 Martin Baulig <martin@ximian.com>
5040 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
5041 call ConstructedType.Resolve() on it.
5043 * generic.cs (ConstructedType.Resolve): Set `type' on success.
5045 2003-10-25 Martin Baulig <martin@ximian.com>
5047 * class.cs (TypeContainer.GetClassBases): Changed
5048 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
5049 CS8214 reporting here.
5050 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
5051 instead of a `Type' for our parent. In case of a recursive
5052 declaration (see tests/gen-23.cs for an example), our parent is a
5053 ConstructedType and it doesn't have its type set. So, first
5054 create our own TypeBuilder, then call constructed.Resolve() to get
5055 the parent's type and finally TypeBuilder.SetParent() it.
5057 * ecore.cs (TypeExpr.Name): New public virtual property.
5060 (ConstructedType): We're now a TypeExpr and not just an Expression.
5061 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
5062 arguments here; this is done later.
5063 (ConstructedType.Resolve): New public method to resolve the type
5064 arguments and bind them.
5066 2003-10-21 Martin Baulig <martin@ximian.com>
5068 * convert.cs: Use `TypeManager.IsValueType' instead of
5069 'type.IsValueType' everywhere.
5071 * typemanager.cs (TypeManager.IsValueType): Return true for type
5072 parameters. The reason for this is that we need to box a type
5073 parameter when converting it to a reference type.
5075 * cs-parser.jay: Added support for default value expressions.
5077 * generics.cs (DefaultValueExpression): New public class.
5079 2003-10-17 Martin Baulig <martin@ximian.com>
5081 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
5082 TypeContainer so we can also use this for Interfaces.
5083 (TypeParameter.Resolve): Likewise.
5085 * interface.cs (Interface.DefineType): Added support for generic
5088 * cs-parser.jay: Added support for generic structs and interfaces.
5090 2003-10-17 Martin Baulig <martin@ximian.com>
5092 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
5093 call generic methods :-)
5095 2003-10-16 Martin Baulig <martin@ximian.com>
5097 * cs-parser.jay (namespace_or_type_name): Only create a
5098 GenericMemberAccess if we actually have type arguments.
5100 2003-10-13 Martin Baulig <martin@ximian.com>
5102 * class.cs (Method.Define): If we're a generic method, call
5103 TypeBuilder.DefineGenericMethod () before resolving
5105 (MethodData): Added .ctor which takes an additional MethodBuilder
5106 argument; this is used for generic methods.
5107 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
5108 we already have a MethodBuilder.
5110 2003-10-10 Martin Baulig <martin@ximian.com>
5112 * class.cs (Method): Added .ctor which takes a `GenericMethod'
5113 instead of a `DeclSpace'. This is used for generic methods.
5115 * cs-parser.jay (method_header): Added support for generic
5116 methods; create a `GenericMethod' instance and pass it to the
5117 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
5118 parameters and locals.
5120 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
5121 since we already have the location. Check whether we're a generic
5122 type declaration or a generic method and create the correct type
5125 * generic.cs (TypeParameter.DefineMethod): New public method.
5126 (GenericMethod): New public class; derives from DeclSpace and is
5127 used for generic methods.
5129 2003-10-09 Martin Baulig <martin@ximian.com>
5131 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5133 (MethodCore.DoDefineParameters): Removed the TypeContainer
5134 argument; use the DeclSpace which was passed to the .ctor instead.
5135 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5136 TypeContainer; we only need a DeclSpace here.
5138 2003-10-09 Martin Baulig <martin@ximian.com>
5140 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5142 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5143 EmitContext's .ctor.
5145 2003-10-09 Martin Baulig <martin@ximian.com>
5147 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5148 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5149 AsAccessible(), moved them as well.
5151 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5153 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5155 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5156 generation for >=, as spotted by Paolo, bug 48679.
5157 Patch from David Waite.
5159 * cs-tokenizer.cs: Add handling for #pragma.
5161 * cs-parser.jay: Allow for both yield and yield return in the
5162 syntax. The anti-cobolization of C# fight will go on!
5164 * class.cs (TypeBuilder.DefineType): Catch error condition here
5165 (Parent.DefineType erroring out and returning null).
5167 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5168 coping with enumerations variables, we were mistakenly processing
5169 them as a regular value type instead of built-in types. Fixes the
5172 * typemanager.cs (IsBuiltinOrEnum): New method.
5174 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5176 * cs-parser.jay: Upgrade: yield now needs the return clause.
5178 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5180 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5182 2003-09-29 Martin Baulig <martin@ximian.com>
5184 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
5185 inflated generic methods.
5187 * generics.cs (ConstructedType): Distinguish between open and
5188 closed constructed types; correctly resolve the arguments.
5190 2003-09-22 Martin Baulig <martin@ximian.com>
5192 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
5193 all type arguments meet their constraints.
5195 2003-09-19 Martin Baulig <martin@ximian.com>
5197 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5198 `MemberCache parent' argument. Normally, an interface doesn't
5199 have a parent type except System.Object, but we use this in gmcs
5200 for generic type parameters.
5202 2003-09-18 Martin Baulig <martin@ximian.com>
5204 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5205 on `type.IsInterface'; don't check whether the type has a parent
5206 to determine whether it's an interface.
5208 2003-09-17 Martin Baulig <martin@ximian.com>
5210 * generic.cs (ConstructedType.ToString): Always use `name' as the
5213 2003-09-15 Martin Baulig <martin@ximian.com>
5215 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
5217 * generic.cs (Constraints.Resolve): New public method; this is
5218 called to resolve the constraint types and to check whether all
5219 the constraints are correct.
5220 (Constraints.Types): New public property.
5221 (TypeParameter.Resolve): New public method; resolves all the
5224 * class.cs (TypeContainer.DefineType): Call
5225 TypeParameter.Resolve() before actually defining the type.
5227 2003-09-15 Martin Baulig <martin@ximian.com>
5229 * class.cs (TypeContainer.DefineType): Added an error flag to
5230 avoid reporting duplicate CS0146's ("class definition is
5233 * driver.cs (Driver.MainDriver): Abort if
5234 RootContext.ResolveTree() reported any errors.
5236 2003-09-07 Martin Baulig <martin@ximian.com>
5238 * report.cs (Error, Warning): Added overloaded versions which take
5239 a `params object[] args' and call String.Format().
5241 2003-09-07 Martin Baulig <martin@ximian.com>
5243 * decl.cs (DeclSpace..ctor): Don't call
5244 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5245 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5246 (DeclSpace.RecordDecl): New method.
5248 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5250 2003-09-02 Ravi Pratap <ravi@ximian.com>
5252 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5253 value attributes to be applied to ParameterBuilders.
5255 * class.cs (MethodCore.LabelParameters): Make static and more
5256 generic so that it can be used from other places - like interface
5257 methods, for instance.
5259 * interface.cs (Interface.Emit): Call LabelParameters before
5260 emitting attributes on the InterfaceMethod.
5262 2003-09-07 Martin Baulig <martin@ximian.com>
5264 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
5265 if the number of type parameters doesn't match.
5267 2003-09-04 Martin Baulig <martin@ximian.com>
5269 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
5270 for arrays of generic type params (ie. `!0[]').
5272 2003-09-04 Martin Baulig <martin@ximian.com>
5274 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
5277 2003-09-04 Martin Baulig <martin@ximian.com>
5279 * decl.cs (DeclSpace.LookupGeneric): New method.
5280 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
5283 * generic.cs (TypeParameterExpr): Take a TypeParameter as
5284 argument, not just a string.
5285 (TypeParameter.Define): New public method; this is called to
5286 actually define the generic parameter; after this, you can use the
5287 new `Type' property to get the type.
5289 2003-09-04 Martin Baulig <martin@ximian.com>
5291 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
5292 is now an ArrayList; initialize the result of the `TypeParameters'
5294 (DeclSpace.GetGenericData): Removed.
5295 (DeclSpace.LookupGeneric): Temporarily removed; we need to
5296 implement this in a different way.
5297 (DeclSpace.GetTypeParameters): Removed; there's now a
5298 `TypeParameters' property.
5299 (DeclSpace.TypeParameters): New public property.
5301 * generic.cs (Constraints): Make this class public.
5302 (TypeParameter): New public class.
5304 2003-09-04 Martin Baulig <martin@ximian.com>
5306 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
5309 * class.cs (TypeContainer.DefineType): Call
5310 TypeBuilder.DefineGenericParameter () on all generic parameters if
5311 this is a generic type.
5313 2003-08-28 Martin Baulig <martin@ximian.com>
5315 * sample-stack.il: Compile this with ilasm: "ilasm /dll
5318 * sample-hello.cs: Compile this with gmcs: "gmcs
5319 /r:sample-stack.dll sample-hello.cs".
5321 2003-08-28 Martin Baulig <martin@ximian.com>
5323 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
5324 the parameters to the generic type.
5326 2003-08-28 Martin Baulig <martin@ximian.com>
5328 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
5330 2003-08-28 Martin Baulig <martin@ximian.com>
5332 * cs-parser.jay (opt_type_argument_list): Use
5333 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
5334 (primary_expression): Replace `qualified_identifier' with `type_name'.
5335 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
5337 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
5338 parser to check whether it is syntactically a type parameter list;
5339 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
5342 2003-08-26 Martin Baulig <martin@ximian.com>
5344 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5345 resolving aliases; fixes #47927.
5347 2003-08-26 Martin Baulig <martin@ximian.com>
5349 * statement.cs (Using.DoResolve): This is internally emitting a
5350 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5351 do not always return. Fixes #47681.
5353 2003-08-26 Martin Baulig <martin@ximian.com>
5355 * decl.cs (MemberCore): Moved WarningNotHiding(),
5356 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5358 (AdditionResult): Make this nested in DeclSpace.
5359 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5360 argument; call NamespaceEntry.Define() unless we're nested in a
5363 * namespace.cs (Namespace.DefineName): New public function. This
5364 is called from DeclSpace's .ctor to add
5365 (Namespace.Lookup): Include DeclSpaces in the lookup.
5367 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5369 * const.cs (Const): Derive from MemberBase, not MemberCore.
5371 2003-08-25 Martin Baulig <martin@ximian.com>
5373 * convert.cs (Convert.ExplicitReferenceConversion): When
5374 converting from an interface type to a class, unbox if the target
5375 type is a struct type. Fixes #47822.
5377 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5379 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5382 2003-08-22 Martin Baulig <martin@ximian.com>
5384 * class.cs (TypeManager.DefineType): When defining a nested type,
5385 call DefineType() on our parent; fixes #47801.
5387 2003-08-22 Martin Baulig <martin@ximian.com>
5389 * class.cs (MethodData.Define): While checking if a method is an
5390 interface implementation, improve the test a bit more to fix #47654.
5392 2003-08-22 Martin Baulig <martin@ximian.com>
5394 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5395 correctly; fixes #47722.
5397 2003-08-22 Martin Baulig <martin@ximian.com>
5399 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5400 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5402 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5404 2003-08-22 Martin Baulig <martin@ximian.com>
5406 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5407 can only be assigned in static constructors. Fixes #47161.
5409 2003-08-22 Martin Baulig <martin@ximian.com>
5411 Rewrote and improved the flow analysis code.
5413 * flowbranching.cs (FlowBranching): Make this class abstract.
5414 (FlowBranching.CreateBranching): New static function to create a
5416 (FlowBranchingBlock, FlowBranchingException): New classes.
5417 (FlowBranching.UsageVector.Type): New public readonly field.
5418 (FlowBranching.UsageVector.Breaks): Removed the setter.
5419 (FlowBranching.UsageVector.Returns): Removed the setter.
5420 (FlowBranching.UsageVector): Added Break(), Return(),
5421 NeverReachable() and Throw() methods to modify the reachability.
5422 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5423 done by FlowBranching.Merge().
5424 (FlowBranching.UsageVector.MergeChild): New method; merges the
5425 merge result into the current vector.
5426 (FlowBranching.Merge): New abstract method to merge a branching.
5428 2003-08-12 Martin Baulig <martin@ximian.com>
5430 * expression.cs (Indirection.CacheTemporaries): Create the
5431 LocalTemporary with the pointer type, not its element type.
5433 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5435 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5436 token was a keyword or not.
5438 Add `error' options where an IDENTIFIER was expected; Provide
5439 CheckToken and CheckIdentifierToken convenience error reporting
5442 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
5444 * decl.cs: Rename `NamespaceEntry Namespace' public field into
5445 NameSpaceEntry NameSpaceEntry.
5447 (LookupInterfaceOrClass): Avoid creating a full qualified name
5448 from namespace and name: avoid doing lookups when we know the
5449 namespace is non-existant. Use new Tree.LookupByNamespace which
5450 looks up DeclSpaces based on their namespace, name pair.
5452 * driver.cs: Provide a new `parser verbose' to display the
5453 exception thrown during parsing. This is turned off by default
5454 now, so the output of a failure from mcs is more graceful.
5456 * namespace.cs: Track all the namespaces defined in a hashtable
5459 (IsNamespace): New method
5461 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5463 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5464 we know that we need to concatenate (full typename can never be
5469 * statement.cs: Use a bitfield; Do not initialize to null things
5470 which are done by the constructor by default.
5472 * cs-parser.jay: bug fix, parameter was 4, not 3.
5474 * expression.cs: Just use the property;
5476 * statement.cs: No need for GetVariableInfo method.
5478 2003-08-08 Martin Baulig <martin@ximian.com>
5480 * flowanalysis.cs (FlowReturns): This is now nested in the
5481 `FlowBranching' class.
5482 (MyBitVector): Moved this here from statement.cs.
5483 (FlowBranching.SiblingType): New enum type.
5484 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5486 2003-08-07 Martin Baulig <martin@ximian.com>
5488 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5489 `FlowBranching' class and called `BranchingType'.
5491 2003-08-07 Martin Baulig <martin@ximian.com>
5493 * flowanalysis.cs: Moved all the control flow analysis code into
5496 2003-08-07 Martin Baulig <martin@ximian.com>
5498 * assign.cs (Assign.DoResolve): `target' must either be an
5499 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
5502 2003-08-07 Miguel de Icaza <miguel@ximian.com>
5504 * expression.cs (BinaryMethod): This kind of expression is created by the
5505 Binary class if it determines that the operator has to be handled
5508 (BinaryDelegate): This kind of expression is created if we are
5509 dealing with a + or - operator on delegates.
5511 (Binary): remove method, argumetns, and DelegateOperator: when
5512 dealing with methods,
5514 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
5516 * statement.cs (Block): use bitfields for the three extra booleans
5517 we had in use. Remove unused topblock parameter.
5519 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
5521 * assign.cs: Drop extra unneeded tests.
5523 2003-08-06 Miguel de Icaza <miguel@ximian.com>
5525 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
5527 * statement.cs (Foreach): Use VariableStorage instead of
5530 * codegen.cs (VariableStorage): New class used by clients that
5531 require a variable stored: locals or fields for variables that
5532 need to live across yield.
5534 Maybe provide a convenience api for EmitThis+EmitLoad?
5536 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
5539 2003-08-05 Miguel de Icaza <miguel@ximian.com>
5541 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
5542 RemapParameterLValue): New methods that are used to turn a
5543 precomputed FieldInfo into an expression like this:
5547 The idea is to use this instead of making LocalVariableReference
5548 have more than one meaning.
5550 * cs-parser.jay: Add error production to BASE.
5552 * ecore.cs: Deal with TypeManager.GetField returning null, which
5553 is now a valid return value.
5555 (FieldExprNoAddress): New expression for Fields whose address can
5558 * expression.cs (LocalVariableReference): During the resolve
5559 phases, create new expressions if we are in a remapping context.
5560 Remove code that dealt with remapping here.
5562 (ParameterReference): same.
5564 (ProxyInstance): New expression, like the `This' expression, but
5565 it is born fully resolved. We know what we are doing, so remove
5566 the errors that are targeted to user-provided uses of `this'.
5568 * statement.cs (Foreach): our variable is now stored as an
5569 Expression; During resolution, follow the protocol, dont just
5570 assume it will return this.
5572 2003-08-06 Martin Baulig <martin@ximian.com>
5574 * support.cs (SeekableStreamReader.cs): New public class.
5576 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
5577 SeekableStreamReader instead of the normal StreamReader.
5579 2003-08-04 Martin Baulig <martin@ximian.com>
5581 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
5582 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
5583 deambiguate casts and delegate invocations.
5584 (parenthesized_expression): Use the new tokens to ensure this is
5585 not a cast of method invocation.
5587 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
5588 when reading a `)' and Deambiguate_CloseParens () was previously
5591 * expression.cs (ParenthesizedExpression): New class. This is
5592 just used for the CS0075 test.
5593 (Binary.DoResolve): Check for CS0075.
5595 2003-07-29 Ravi Pratap <ravi@ximian.com>
5597 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
5598 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
5599 reference comparison.
5601 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
5602 examine the ReturnType for equality - this is necessary in the
5603 cases of implicit and explicit operators whose signature also
5604 includes the return type.
5606 2003-07-26 Miguel de Icaza <miguel@ximian.com>
5608 * namespace.cs: Cache the result of the namespace computation,
5609 instead of computing it every time.
5611 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5613 * decl.cs: Use a global arraylist that we reuse over invocations
5614 to avoid excesive memory consumption. Reduces memory usage on an
5615 mcs compile by one meg (45 average).
5617 * typemanager.cs (LookupTypeReflection): In .NET pointers are
5618 private, work around that.
5620 2003-07-23 Miguel de Icaza <miguel@ximian.com>
5622 * literal.cs (IntLiteral): Define Zero and One static literals.
5624 * cs-parser.jay (integer_literal): use static literals to reduce
5625 memory usage for the most used literals (0, 1 and -1). 211kb
5626 reduced in memory usage.
5628 Replace all calls to `new ArrayList' with `new
5629 ArrayList(4)' which is a good average number for most allocations,
5630 and also requires only 16 bytes of memory for its buffer by
5633 This reduced MCS memory usage in seven megabytes for the RSS after
5636 2003-07-28 Ravi Pratap <ravi@ximian.com>
5638 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
5639 handle params methods the correct way by forming only one
5640 applicable set with params and normal methods in them. Earlier we
5641 were looking at params methods only if we found no normal methods
5642 which was not the correct thing to do.
5644 (Invocation.BetterFunction): Take separate arguments indicating
5645 when candidate and the best method are params methods in their
5648 This fixes bugs #43367 and #46199.
5650 * attribute.cs: Documentation updates.
5652 (CheckAttribute): Rename to CheckAttributeTarget.
5653 (GetValidPlaces): Rename to GetValidTargets.
5655 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
5656 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
5660 2003-07-28 Miguel de Icaza <miguel@ximian.com>
5662 * codegen.cs: Compute IsGeneric correctly.
5664 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
5667 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
5668 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
5669 regressions, and I was chasing more bugs than I required.
5671 * interface.cs: Use expressions for base type names (like classes
5672 and structs have been doing for a while now), and resolve that.
5673 This patch should probably go into head as well.
5675 This makes it one less user of FindType.
5677 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5679 This compiler can not self host currently. Need to fix that.
5681 * Makefile: compile to `gmcs.exe'
5683 * driver.cs: Turn on v2 by default on gmcs.
5685 * generic.cs (ConstructedType): Does no longer take a container
5686 type argument; That will be taken care of later.
5688 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
5689 Use SimpleName to resolve for now, so we can continue the work on
5690 the parser, until we get Type.GetType that understands generics.
5692 (ConstructedType.ToString): Implement
5694 (TypeArguments.Resolve): Resolve the child expressions as types.
5696 * cs-parser.jay: Rename interface_constraints to
5697 type_parameter_constraints
5699 (namespace_or_type_name): Only use constructed types for the basic
5700 construction, we will deal with identifier<...> later.
5702 (type/type_name): No longer call DecomposeQI, as
5703 namespace_or_type_name is always decoded now.
5705 2003-07-22 Ravi Pratap <ravi@ximian.com>
5707 * expression.cs (Invocation.OverloadResolve): Follow the spec more
5708 closely: we eliminate methods in base types when we have an
5709 applicable method in a top-level type.
5711 Please see section 14.5.5.1 for an exact description of what goes
5714 This fixes bug #45127 and a host of other related to corlib compilation.
5716 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
5717 array is the method corresponding to the top-level type (this is
5718 because of the changes made to icall.c) so we change this
5721 (MethodGroupExpr.Name): This too.
5723 * typemanager.cs (GetElementType): New method which does the right
5724 thing when compiling corlib.
5726 * everywhere: Make use of the above in the relevant places.
5728 2003-07-22 Martin Baulig <martin@ximian.com>
5730 * cs-parser.jay (invocation_expression): Moved
5731 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
5732 `cast_expression', but create a InvocationOrCast which later
5733 resolves to either an Invocation or a Cast.
5735 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
5736 method; call this before EmitStatement() to make sure that this
5737 expression can be used as a statement.
5739 * expression.cs (InvocationOrCast): New class; resolves to either
5740 an Invocation or a Cast.
5742 * statement.cs (StatementExpression): Call ResolveStatement() on
5743 the ExpressionStatement before emitting it.
5745 2003-07-21 Martin Baulig <martin@ximian.com>
5747 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
5748 `ref' and `out' attributes match; fixes #46220.
5749 (MemberAccess.ResolveMemberAccess): You can't reference a type
5750 through an expression; fixes #33180.
5751 (Indexers.GetIndexersForType): Don't return the indexers from
5752 interfaces the class implements; fixes #46502.
5754 2003-07-21 Martin Baulig <martin@ximian.com>
5756 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
5757 CS0661 checks; fixes bug #30442.
5759 2003-07-21 Martin Baulig <martin@ximian.com>
5761 * decl.cs (AdditionResult): Added `Error'.
5763 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
5765 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
5766 cs0031.cs actually work.
5768 2003-07-20 Miguel de Icaza <miguel@ximian.com>
5770 * cs-parser.jay (namespace_name): do not use
5771 namespace_or_type_name, use qualified_identifier, because
5772 namespace_or_type_name will soon return a composed expression
5773 instead of a string.
5775 (namespace_or_type_name): Instead of returning a string, now this
5776 production returns an expression.
5778 * codegen.cs (EmitContext): Setup IsGeneric property based on
5779 whether our DeclSpace is generic, our the method is generic.
5781 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
5782 the method is generic.
5784 * cs-parser.jay (type_arguments, opt_type_argument_list,
5785 type_parameters, type_parameter_list, opt_type_parameter_list,
5786 type_parameter,, opt_type_parameter_constraints_clauses,
5787 type_parameter_constraints_clauses,
5788 type_parameter_constraint_clause, type_parameter_constraint,
5789 interface_constraints): Add new production
5791 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
5792 DeclSpace is generic or not.
5794 (DeclSpace.SetParameterInfo): New routine, used to set the
5795 parameter info for a type.
5797 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
5798 returns a GenericTypeExpr
5800 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
5801 generic, lookup the generic argument.
5803 * attribute.cs: Do not allow TypeParameterExpressions in
5806 * class.cs: Do not allow the Main method to be defined in a
5809 * expression.cs (SizeOf): Do not allow generic types to be used as
5810 arguments to sizeof.
5812 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
5813 it: whether a type is generic or not. Only works for types we are
5814 currently building for now.
5816 2003-07-20 Martin Baulig <martin@ximian.com>
5818 * namespace.cs: Fixed that bug which caused a crash when compiling
5821 2003-07-20 Miguel de Icaza <miguel@ximian.com>
5823 * typemanager.cs (LookupTypeReflection): Never expose types which
5824 are NotPublic, NestedPrivate, NestedAssembly, or
5825 NestedFamANDAssem. We used to return these, and later do a check
5826 that would report a meaningful error, but the problem is that we
5827 would not get the real match, if there was a name override.
5829 2003-07-18 Miguel de Icaza <miguel@ximian.com>
5831 * namespace.cs (Namespace, Name): Do not compute the namespace
5832 name dynamically, compute it in the constructor. This reduced
5833 memory usage by 1697 KB.
5835 * driver.cs: Use --pause to pause at the end.
5837 2003-07-17 Peter Williams <peter@newton.cx>
5839 * Makefile: Change the name of the test target so that it doesn't
5840 conflict with the recursive test target.
5842 2003-07-17 Miguel de Icaza <miguel@ximian.com>
5844 * expression.cs (LocalVariableReference.Emit, EmitAssign,
5845 AddressOf): Do not use EmitThis, that was wrong, use the actual
5848 2003-07-15 Miguel de Icaza <miguel@ximian.com>
5850 * class.cs (MethodData.Define): While checking if a method is an
5851 interface implementation, improve the test: If we are not public
5852 (use new test here: use the computed MethodAttributes directly,
5853 instead of the parsed modifier flags) check if the `implementing'
5854 method comes from an interface or not.
5856 * pending.cs (VerifyPendingMethods): Slightly better error
5859 * makefile: add test target that does the mcs bootstrap.
5861 2003-07-16 Ravi Pratap <ravi@ximian.com>
5863 * interface.cs (Define): Do nothing here since there are no
5864 members to populate etc. Move the attribute emission out of here
5865 since this was just totally the wrong place to put it. Attribute
5866 application happens during the 'Emit' phase, not in the 'Define'
5869 (Emit): Add this method and move the attribute emission here
5871 * rootcontext.cs (EmitCode): Call the Emit method on interface
5874 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5876 * expression.cs (OverloadResolve): Report error only if Location
5877 is not 'Null' which means that there was a probe going on.
5879 2003-07-14 Martin Baulig <martin@ximian.com>
5881 * expression.cs (ConditionalLogicalOperator): New public class to
5882 implement user defined conditional logical operators.
5883 This is section 14.11.2 in the spec and bug #40505.
5885 2003-07-14 Martin Baulig <martin@ximian.com>
5887 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
5889 2003-07-14 Martin Baulig <martin@ximian.com>
5891 * codegen.cs (EmitContext.InFixedInitializer): New public field.
5893 * ecore.cs (IVariable.VerifyFixed): New interface method.
5895 * expression.cs (Unary.ResolveOperator): When resolving the `&'
5896 operator, check whether the variable is actually fixed. Fixes bug
5897 #36055. Set a variable definitely assigned when taking its
5898 address as required by the spec.
5900 * statement.cs (LocalInfo.IsFixed): New field.
5901 (LocalInfo.MakePinned): Set `IsFixed' to true.
5903 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5905 * attribute.cs (Attribute.Resolve): While doing a Member lookup
5906 for .ctors, ensure that we only ask for members declared in the
5907 attribute type (BindingFlags.DeclaredOnly).
5911 * expression.cs (Error_WrongNumArguments): Report error 1501
5912 correctly the way CSC does.
5914 2003-07-13 Martin Baulig <martin@ximian.com>
5916 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
5917 lookup on the fully qualified name, to make things like "X.X" work
5918 where "X.X" is a fully qualified type name, but we also have a
5919 namespace "X" in the using list. Fixes #41975.
5921 2003-07-13 Martin Baulig <martin@ximian.com>
5923 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
5924 function. If we're a CompoundAssign, we need to create an embedded
5925 CompoundAssign, not an embedded Assign.
5926 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
5929 2003-07-13 Martin Baulig <martin@ximian.com>
5931 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
5932 work to fix bug #46088.
5934 2003-07-13 Ravi Pratap <ravi@ximian.com>
5936 * class.cs (Operator.Emit): Do not emit attributes here - it is
5937 taken care of by the Method class that we delegate too. This takes
5940 2003-07-10 Martin Baulig <martin@ximian.com>
5942 * expression.cs (TypeOfVoid): New class.
5943 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
5945 2003-07-10 Martin Baulig <martin@ximian.com>
5947 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
5950 2003-07-10 Martin Baulig <martin@ximian.com>
5952 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
5953 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
5955 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
5957 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
5959 2003-07-10 Martin Baulig <martin@ximian.com>
5961 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
5962 of decimal. Fixes #42850.
5964 NOTE: I also fixed the created byte blob, but this doesn't work on
5965 the MS runtime and csc never produces any byte blobs for decimal
5968 2003-07-10 Martin Baulig <martin@ximian.com>
5970 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
5971 structs; fixes #32068.
5972 (Block.AddChildVariableNames): Fixed #44302.
5974 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5976 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
5978 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5980 * attribute.cs: And this test is onger needed.
5982 2003-07-08 Martin Baulig <martin@ximian.com>
5984 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
5985 inaccessible types. Fixes #36313.
5987 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
5989 * namespace.cs (NamespaceEntry): Create implicit entries for all
5990 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
5991 implicit entries for N1.N2 and N1.
5993 2003-07-08 Martin Baulig <martin@ximian.com>
5995 Rewrote the handling of namespaces to fix a lot of the issues
5996 wrt. `using' aliases etc.
5998 * namespace.cs (Namespace): Splitted this class into a
5999 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6001 * typemanager.cs (TypeManager.IsNamespace): Removed.
6002 (TypeManager.ComputeNamespaces): Only compute namespaces from
6003 loaded assemblies here, not the namespaces from the assembly we're
6004 currently compiling.
6006 2003-07-08 Martin Baulig <martin@ximian.com>
6008 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6010 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6012 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6015 I thought about the memory savings here, but LookupTypeReflection
6016 is used under already very constrained scenarios. Compiling
6017 corlib or mcs only exposes one hit, so it would not really reduce
6018 any memory consumption.
6020 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6022 * typemanager.cs: fixes bug #45889 by only adding public types from
6023 other assemblies to the list of known types.
6025 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6027 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6028 on the type we resolved.
6030 2003-07-05 Martin Baulig <martin@ximian.com>
6032 * pending.cs (PendingImplementation.ParentImplements): Don't
6033 create the proxy if the parent is abstract.
6035 * class.cs (TypeContainer.DefineIndexers): Process explicit
6036 interface implementations first. Fixes #37714.
6038 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6040 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6041 defined recursively; but since we modify the input parameters
6042 (left is set to `this' temporarily), we reset this value if the
6043 left_is_explicit is false, which gives the original semantics to
6046 * literal.cs (NullPointer): new class used to represent a null
6047 literal in a pointer context.
6049 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6050 type is a pointer, use a NullPointer object instead of a
6051 NullLiteral. Closes 43687
6053 (ExplicitConversion): Convert pointer values using
6054 the conv opcode to the proper type.
6056 * ecore.cs (New): change ValueTypeVariable property into a method,
6057 that returns whether the valuetype is suitable for being used.
6059 * expression.cs (Binary.DoNumericPromotions): Only return if we
6060 the int constant was a valid uint, and we can return both left and
6061 right as uints. If not, we continue processing, to trigger the
6062 type conversion. This fixes 39018.
6064 * statement.cs (Block.EmitMeta): During constant resolution, set
6065 the CurrentBlock property on the emitcontext, so that we resolve
6066 constants propertly.
6068 2003-07-02 Martin Baulig <martin@ximian.com>
6070 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6071 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6073 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6074 than emitting it here.
6076 * statement.cs: Fixed some more flow analysis bugs.
6078 2003-07-02 Martin Baulig <martin@ximian.com>
6080 * class.cs (MethodData.Define): When implementing interface
6081 methods, set Final unless we're Virtual.
6083 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6084 check work for interface methods.
6086 2003-07-01 Martin Baulig <martin@ximian.com>
6088 * ecore.cs (EmitContext.This): Replaced this property with a
6089 GetThis() method which takes a Location argument. This ensures
6090 that we get the correct error location for a CS0188.
6092 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6094 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6095 ImplicitStandardConversion.
6097 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6099 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6101 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6104 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6106 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6109 (MethodData.Define): Turn off initlocals for unsafe methods.
6111 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6113 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6114 complete; Fixes #37521.
6116 * delegate.cs: Use Modifiers.TypeAttr to compute the
6117 TypeAttributes, instead of rolling our own. This makes the flags
6118 correct for the delegates.
6120 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6122 * class.cs (Constructor.Define): Set the private flag for static
6123 constructors as well.
6125 * cs-parser.jay (statement_expression): Set the return value to
6126 null, to avoid a crash when we catch an error.
6128 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6130 * cs-parser.jay: Applied patch from Jackson that adds support for
6131 extern and unsafe modifiers to destructor declarations.
6133 * expression.cs: Report error 21 if the user is trying to index a
6136 * driver.cs: Add an error message, suggested by the bug report.
6138 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6139 if we do not have a ": this ()" constructor initializer. Fixes 45149
6141 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6143 * namespace.cs: Add some information to reduce FAQs.
6145 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6147 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6148 underlying enumeration types. Fixes #43915.
6150 * expression.cs: Treat ushort/short as legal values to be used in
6153 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6155 * delegate.cs: transfer custom attributes for paramenters from
6156 the delegate declaration to Invoke and BeginInvoke.
6158 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6160 * attribute.cs: handle custom marshalers and emit marshal info
6163 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6165 * makefile.gnu: Added anonymous.cs to the compiler sources.
6167 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6169 * iterators.cs: Change the name of the proxy class to include two
6172 * cs-parser.jay: Update grammar to include anonymous methods.
6174 * anonymous.cs: new file.
6176 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6178 * class.cs (Field.Define): Add missing test for pointers and
6181 2003-05-27 Ravi Pratap <ravi@ximian.com>
6183 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6184 we use the stobj opcode.
6186 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6187 since it wasn't the correct fix.
6189 It still is puzzling that we are required to use stobj for IntPtr
6190 which seems to be a ValueType.
6192 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6194 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6195 during regular simple name resolution. Now, the trick is that
6196 instead of returning for processing the simplename, we do a
6197 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6198 contextual lookup type). If a match is found, return that, if
6199 not, return for further composition.
6201 This fixes long-standing 30485.
6203 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6204 using the address to initialize an object, do an Stobj instead of
6205 using the regular Stelem.
6207 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6208 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6209 Because if we are a BaseIndexerAccess that value will be true.
6212 * statement.cs (GotoCase.Resolve): Return after reporting an
6213 error, do not attempt to continue.
6215 * expression.cs (PointerArithmetic.Emit): If our operand is a
6216 long, convert our constants to match the operand before
6217 multiplying. Convert to I type before adding. Fixes 43670.
6219 2003-05-14 Ravi Pratap <ravi@ximian.com>
6221 * enum.cs (ImplicitConversionExists) : Rename to
6222 ImplicitEnumConversionExists to remove ambiguity.
6224 * ecore.cs (NullCast): New type of cast expression class which
6225 basically is very similar to EmptyCast with the difference being
6226 it still is a constant since it is used only to cast a null to
6230 * convert.cs (ImplicitReferenceConversion): When casting a null
6231 literal, we return a NullCast.
6233 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6234 should be around anymore.
6236 The renaming (reported was slightly wrong). Corrections:
6238 ConvertImplicitStandard -> ImplicitConversionStandard
6239 ConvertExplicitStandard -> ExplicitConversionStandard
6241 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6242 before passing them in !
6244 * convert.cs (ImplicitConversionStandard): When comparing for
6245 equal expr and target types, ensure that expr is not a
6248 In general, we must not be checking (expr_type ==
6249 target_type) in the top level conversion methods
6250 (ImplicitConversion, ExplicitConversion etc). This checking is
6251 done in the methods that they delegate to.
6253 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6255 * convert.cs: Move Error_CannotConvertType,
6256 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6257 ImplicitNumericConversion, ImplicitConversionExists,
6258 ImplicitUserConversionExists, StandardConversionExists,
6259 FindMostEncompassedType, FindMostSpecificSource,
6260 FindMostSpecificTarget, ImplicitUserConversion,
6261 ExplicitUserConversion, GetConversionOperators,
6262 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6263 TryImplicitIntConversion, Error_CannotConvertImplicit,
6264 ConvertImplicitRequired, ConvertNumericExplicit,
6265 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6266 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6269 Perform the following renames:
6271 StandardConversionExists -> ImplicitStandardConversionExists
6272 ConvertImplicit -> ImplicitConversion
6273 ConvertImplicitStandard -> ImplicitStandardConversion
6274 TryImplicitIntConversion -> ImplicitIntConversion
6275 ConvertImplicitRequired -> ImplicitConversionRequired
6276 ConvertNumericExplicit -> ExplicitNumericConversion
6277 ConvertReferenceExplicit -> ExplicitReferenceConversion
6278 ConvertExplicit -> ExplicitConversion
6279 ConvertExplicitStandard -> ExplicitStandardConversion
6281 2003-05-19 Martin Baulig <martin@ximian.com>
6283 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6284 (TypeInfo): Added support for structs having structs as fields.
6286 * ecore.cs (FieldExpr): Implement IVariable.
6287 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6288 VariableInfo for the field.
6290 2003-05-18 Martin Baulig <martin@ximian.com>
6292 * expression.cs (This.DoResolve): Report a CS0027 if we're
6293 emitting a field initializer.
6295 2003-05-18 Martin Baulig <martin@ximian.com>
6297 * expression.cs (This.ResolveBase): New public function.
6298 (This.DoResolve): Check for CS0188.
6300 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6303 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6304 `instance_expression' to null if we don't have any non-static
6307 2003-05-18 Martin Baulig <martin@ximian.com>
6309 Reworked the way how local variables and parameters are handled by
6310 the flow analysis code.
6312 * statement.cs (TypeInfo, VariableMap): New public classes.
6313 (VariableInfo): New public class. This is now responsible for
6314 checking whether a variable has been assigned. It is used for
6315 parameters and local variables.
6316 (Block.EmitMeta): Take the InternalParameters as argument; compute
6317 the layout of the flow vectors here.
6318 (Block.LocalMap, Block.ParameterMap): New public properties.
6319 (FlowBranching): The .ctor doesn't get the InternalParameters
6320 anymore since Block.EmitMeta() now computes the layout of the flow
6322 (MyStructInfo): This class is now known as `StructInfo' and nested
6323 in `TypeInfo'; we don't access this directly anymore.
6325 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6326 property and removed IsAssigned(), IsFieldAssigned(),
6327 SetAssigned() and SetFieldAssigned(); we now call them on the
6328 VariableInfo so we don't need to duplicate this code everywhere.
6330 * expression.cs (ParameterReference): Added `Block block' argument
6332 (LocalVariableReference, ParameterReference, This): The new
6333 VariableInfo class is now responsible for all the definite
6336 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6337 IsParameterAssigned, SetParameterAssigned): Removed.
6339 2003-05-18 Martin Baulig <martin@ximian.com>
6341 * typemanager.cs (InitCoreTypes): Try calling
6342 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6343 the 3-args-version. Corlib now also needs our `void_type'.
6344 (GetMethod): Added overloaded version which takes an optional
6345 `bool report_errors' to allow lookups of optional methods.
6347 2003-05-12 Martin Baulig <martin@ximian.com>
6349 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6350 only used for locals and not for parameters.
6352 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6354 * support.cs (InternalParameters.ParameterType): Return the
6355 ExternalType of the parameter.
6357 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6360 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6362 * class.cs (MethodData.Define): Do not set the `newslot' on
6363 interface members, if they are also flagged as "override".
6365 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6366 better code for ++i and i++. This only works for static fields
6367 and local variables.
6369 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6370 want to pull the DeclSpace out of the builder_to_declspace instead
6371 of the TypeBuilder (like in TypeContainer.FindMembers).
6373 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6374 instead of LookupTypeContainer. Fixes the crash on .NET for
6375 looking up interface members.
6377 * const.cs: Create our own emit context during the Definition
6378 stage, so that constants are evaluated in the proper context, when
6379 a recursive definition happens.
6381 2003-05-11 Martin Baulig <martin@ximian.com>
6383 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6384 new block for a switch section.
6385 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6386 the adding/lookup in the switch block. Fixes #39828.
6388 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6390 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6391 functionality: I needed to convert the data after I had performed
6392 the add/sub operation into the operands type size.
6394 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6395 pass the type for the box operation, otherwise the resulting
6396 object would have been of type object.
6398 (BoxedCast): Add constructor to specify the type to box as.
6400 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6402 * iterators.cs: I was reusing the `count' variable inadvertently,
6403 take steps to not allow this to happen.
6405 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6407 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6408 by creating an array at the point where the params starts and
6409 putting all those arguments there, then adjusting the size of the
6412 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6414 * expression.cs (New.AddressOf): Implement interface
6415 IMemoryLocation. This is used when the `new' operator is used in
6416 the context of an invocation to a method on a value type.
6418 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6421 * namespace.cs: Also check the using aliases here.
6423 * driver.cs: Move the test for using validity after the types have
6424 been entered, so we do a single pass that also includes the using
6427 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6428 in the regular case. CreateSiblingForFinally is doing extra
6431 * attribute.cs (GetAttributeArgumentExpression): Store the result
6432 on an out value, and use the return value to indicate failure
6433 instead of using null (which is a valid return for Constant.GetValue).
6435 * statement.cs: Perform the analysis flow for the increment
6436 portion after the statement, because this will be the real flow of
6437 execution. Fixes #42385
6439 * codegen.cs (EmitContext.EmitArgument,
6440 EmitContext.EmitStoreArgument): New helper functions when the
6441 RemapToProxy flag is set.
6443 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6446 Add support for remapping parameters.
6448 * iterators.cs: Propagate parameter values; Store parameter
6449 values in the proxy classes.
6451 2003-05-04 Miguel de Icaza <miguel@ximian.com>
6453 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
6454 need a proxy reference; I do not know what I was thinking
6456 * cs-parser.jay (constructor_initializer): catch another error,
6457 and display nice message.
6459 (field_declaration): catch void field declaration
6460 to flag a better error.
6462 * class.cs (MemberBase.CheckBase): Report an error instead of a
6463 warning if a new protected member is declared in a struct.
6464 (Field.Define): catch the error of readonly/volatile.
6466 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
6468 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6469 volatile variable is taken
6471 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6473 * statement.cs (Fixed.Resolve): Report an error if we are not in
6476 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6478 * typemanager.cs: reuse the code that handles type clashes for
6479 delegates and enumerations.
6481 * class.cs (Report28): Always report.
6483 * expression.cs (EncodeAsAttribute): Allow nulls here.
6485 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6487 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6488 the functionality for testing whether an expression is valid for
6489 an attribute here. Also handle the case of arrays of elements
6492 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6493 encoding a linear array into an array of objects that are suitable
6494 to be passed to an CustomAttributeBuilder.
6496 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6498 * ecore.cs: (FieldExpr): Handle field remapping here.
6500 * iteratators.cs: Pass the instance variable (if the method is an
6501 instance method) to the constructors, so we can access the field
6502 variables on the class.
6504 TODO: Test this with structs. I think the THIS variable on
6505 structs might have to be a pointer, and not a refenrece
6507 2003-04-27 Miguel de Icaza <miguel@ximian.com>
6509 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
6510 local variables to fields in a proxy class.
6512 * iterators.cs (PopulateProxy): Rename our internal fields to
6514 Create a <THIS> field if we are an instance method, so we can
6515 reference our parent container variables.
6516 (MapVariable): Called back from the EmitContext code to enter a
6517 new variable to field mapping into the proxy class (we just create
6521 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
6522 for using the remapped locals to fields.
6524 I placed the code here, because that gives the same semantics to
6525 local variables, and only changes the Emit code.
6527 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
6528 statements inside iterators.
6529 (VariableInfo): Add a FieldBuilder for the cases when we are
6530 remapping local variables to fields in a proxy class
6532 * ecore.cs (SimpleNameResolve): Avoid testing two times for
6533 current_block != null.
6535 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
6536 not cope with strings, as it has been moved to the
6537 TableSwitchEmit. Fixed bug in switch generation.
6539 * expression.cs (New.DoResolve): Provide more context for the user
6540 when reporting an error.
6542 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
6545 * expression.cs (MemberAccess.DoResolve): When we get a type back,
6546 check the permissions for it. Note than in a type-resolution
6547 context the check was already present in DeclSpace.ResolveType,
6548 but was missing from the MemberAccess.
6550 (ArrayCreation.CheckIndices): warn if the user has
6551 more nested levels of expressions, but there are no more
6552 dimensions specified. Avoids crash on bug 41906.
6554 2003-04-26 Miguel de Icaza <miguel@ximian.com>
6556 * statement.cs (Block): replace Implicit bool, for a generic
6558 New flag: `Unchecked'. This is used during the EmitMeta phase
6559 (which is out-of-line with the regular Resolve/Emit process for a
6560 statement, as this is done ahead of time, but still gets a chance
6561 to call constant resolve).
6563 (Block.Flags): new enum for adding a new flag.
6565 (Block.EmitMeta): track the state of unchecked.
6567 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
6568 to enable constant resolution to work there as well.
6570 2003-04-22 Miguel de Icaza <miguel@ximian.com>
6572 * typemanager.cs (ienumerable_type): Also look up
6573 System.Collections.IEnumerable.
6575 2003-04-21 Miguel de Icaza <miguel@ximian.com>
6577 TODO: Test more than one conditional per method.
6579 * class.cs (Indexer.Define): Report the location where the user is
6580 referencing the unsupported feature.
6582 (MethodData): Overload the use of `conditionals' to
6583 minimize the creation of needless ArrayLists. This saves roughly
6584 212kb on my machine.
6586 (Method): Implement the new IIteratorContainer interface.
6587 (Method.SetYields): Implement the method by setting the ModFlags
6588 to contain METHOD_YIELDS.
6590 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
6591 which just got set to null.
6593 * iterators.cs: New file.
6595 (Yield, YieldBreak): New statements.
6597 * statement.cs (Return.Resolve): Flag an error if we are used in
6600 * codegen.cs (InIterator): New flag set if the code is being
6601 compiled in an iterator method.
6603 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
6604 internal modifier, and we just use it to avoid adding extra
6605 fields, as this is seldom used.
6607 * cs-parser.jay: Add yield_statement (yield and yield break).
6609 * driver.cs: New flag -v2 to turn on version 2 features.
6611 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
6612 hashtable when v2 is enabled.
6614 2003-04-20 Miguel de Icaza <miguel@ximian.com>
6616 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
6617 there is already a namespace defined with this name.
6619 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
6620 people upgraded their corlibs.
6622 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
6623 always use fully qualified types, no need to use the compiler
6626 (TypeManager.IsNamespace): Use binarysearch.
6628 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
6629 AddDelegate): I did not quite use the new IsValid API properly: I
6630 have to pass the short-name and the fullname. I was passing only
6631 the basename instead of the fullname sometimes.
6633 (TypeContainer.DefineType): call NamespaceClash.
6635 * interface.cs (Interface.DefineType): use NamespaceClash before
6638 * delegate.cs (Delegate.DefineType): use NamespaceClash before
6641 * enum.cs: (Enum.DefineType): use NamespaceClash before
6644 * typemanager.cs (: 3-line patch that gives us some tasty 11%
6645 speed increase. First, use the negative_hits cache when we get a
6646 negative. Second, add the type with its full original name
6647 instead of the new . and + encoded name (reflection uses + to
6648 separate type from a nested type). Use LookupTypeReflection
6649 directly which bypasses the type->name hashtable (that we already
6650 know does not contain the type.
6652 * decl.cs (DeclSpace.ResolveTypeExpr): track the
6653 location/container type.
6655 * driver.cs: When passing utf8, use directly the UTF8Encoding.
6657 2003-04-19 Miguel de Icaza <miguel@ximian.com>
6659 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
6661 * delegate.cs (NewDelegate.Resolve): Test whether an instance
6662 method is being referenced in the method group from a static
6663 context, and report error 120 if so.
6665 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
6668 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
6669 is created, we create the A namespace).
6671 * cs-parser.jay: A namespace also introduces a DeclarationFound.
6674 2003-04-18 Miguel de Icaza <miguel@ximian.com>
6676 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
6677 invocation to ModuleBuilder.GetType with the same values will
6678 return a new type instance, so we need to cache its return
6681 * expression.cs (Binary.ResolveOperator): Only allow the compare
6682 operators on enums if they are of the same type.
6684 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
6685 types of ValueType on their own case. Before we were giving them
6686 the same treatment as objects.
6688 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
6689 fullname. Short name is used to compare against container name.
6690 Fullname is used to check against defined namespace names.
6692 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
6693 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
6695 (Method.CheckBase): Call parent.
6696 (MemberBase.CheckBase): Check for protected members on sealed
6698 (PropertyBase.CheckBase): Call parent.
6699 (Field.Define): Call parent.
6701 * report.cs: Negative error codes are now mapped to 8000 - code,
6702 so that the display is render more nicely.
6704 * typemanager.cs: Do not use try/catch, instead report a regular
6707 (GetPointerType, GetReferenceType): These methods provide
6708 mechanisms to obtain the T* and T& from a T. We had the code
6709 previously scattered around the code base, and it also used
6710 TypeManager.LookupType that would go through plenty of caches.
6711 This one goes directly to the type source.
6713 In some places we did the Type.GetType followed by
6714 ModuleBuilder.GetType, but not in others, so this unifies the
6717 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
6718 statements now that we have namespace information.
6720 * typemanager.cs (IsNamespace): New method, returns whether the
6721 string presented is a namespace or not.
6723 (ComputeNamespaces): New public entry point, computes the list of
6724 available namespaces, using the GetNamespaces API call in Mono, or
6725 the slower version in MS.NET.
6727 Now before we start the semantic analysis phase, we have a
6728 complete list of namespaces including everything that the user has
6731 Deleted old code to cache namespaces in .nsc files.
6733 2003-04-17 Miguel de Icaza <miguel@ximian.com>
6735 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
6736 class/struct location definition Location for the implicit
6737 constructor location.
6739 (Operator.Define): Use the location of the operator for the
6740 implicit Method definition.
6742 (Constructor.Emit): use the constructor location for the implicit
6743 base initializer constructor.
6745 * ecore.cs: Remove ITypeExpression. This interface is now gone,
6746 and the Expression class now contains two new methods:
6748 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
6749 isolate type lookup from the rest of the resolution process.
6751 Since we use Expressions to hold type definitions due to the way
6752 we parse the input we have historically overloaded Resolve to
6753 perform the Type lookups if a special flag is passed. Now this is
6754 eliminated and two methods take their place.
6756 The differences in the two methods between xStep and xTerminal is
6757 that xStep is involved in our current lookup system that uses
6758 SimpleNames to compose a name, while xTerminal is used just to
6759 catch the case where the simplename lookup failed.
6761 2003-04-16 Miguel de Icaza <miguel@ximian.com>
6763 * expression.cs (ResolveMemberAccess): Remove redundant code.
6764 TypeExpr expressions are always born fully resolved.
6766 * interface.cs (PopulateMethod): Do not lookup the types twice.
6767 We were doing it once during SemanticAnalysis and once during
6770 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
6771 in local variable type definitions, were being returned as a
6772 SimpleName (we decomposed everything into a string), that is
6773 because primary_expression was being used instead of a type in the
6774 grammar (reduce/reduce conflicts).
6776 The part that was wrong is that we converted the expression into a
6777 string (an oversimplification in one hand, compounded with primary
6778 expressions doing string concatenation).
6784 Would return "A.B.C[]" as a SimpleName. This stopped things like
6785 using clauses from working on this particular context. And a type
6786 was being matched directly against "A.B.C[]".
6788 We now use the correct approach, and allow for ComposedCast to be
6789 part of the unary expression. So the "A.B.C []" become a composed
6790 cast of "A.B.C" (as a nested group of MemberAccess with a
6791 SimpleName at the end) plus the rank composition "[]".
6795 2003-04-10 Miguel de Icaza <miguel@ximian.com>
6797 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
6798 for the access level checking.
6800 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
6801 `TypeContainer container', because I kept getting confused when I
6802 was debugging this code.
6804 * expression.cs (Indexers): Instead of tracking getters/setters,
6805 we now track them in parallel. We create one arraylist less, but
6806 most importantly it is possible now for the LValue code to find a
6807 matching get for a set.
6809 (IndexerAccess.DoResolveLValue): Update the code.
6810 GetIndexersForType has been modified already to extract all the
6811 indexers from a type. The code assumed it did not.
6813 Also make the code set the correct return type for the indexer.
6814 This was fixed a long time ago for properties, but was missing for
6815 indexers. It used to be void_type.
6817 (Binary.Emit): Test first for doubles instead of
6818 floats, as they are more common.
6820 (Binary.EmitBranchable): Use the .un version of the branch opcodes
6821 when dealing with floats and the <=, >= operators. This fixes bug
6824 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
6825 to load the array value by emitting a load on the foreach variable
6826 type. This was incorrect.
6828 We now emit the code to load an element using the the array
6829 variable type, and then we emit the conversion operator.
6833 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
6835 * attribute.cs: Avoid allocation of ArrayLists in the common case.
6837 2003-04-09 Miguel de Icaza <miguel@ximian.com>
6839 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
6840 test for protection before we test for signatures.
6842 (MethodSignature.ToString): implement.
6844 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
6845 to the case where we reduced into a LongConstant.
6847 * decl.cs (CheckAccessLevel): If the type is an array, we can not
6848 depend on whether the information is acurrate, because the
6849 Microsoft runtime will always claim that the array type is public,
6850 regardless of the real state.
6852 If the type is a pointer, another problem happens: the type is
6853 reported as non-public in Microsoft.
6855 In both cases we have to call CheckAccessLevel recursively with
6856 the underlying type as the argument to be tested.
6858 2003-04-08 Miguel de Icaza <miguel@ximian.com>
6860 * assign.cs (Assign.Emit): If we are dealing with a compound
6861 assignment expression, we should use the code path that stores the
6862 intermediate result in a temporary value. This fixes #40903.
6864 *expression.cs (Indirection.ToString): Provide ToString method for
6867 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
6869 * class.cs: Null out fields holding references to Block objects so
6870 they can be garbage collected.
6872 * expression.cs (OverloadResolve): Remove unused local.
6874 2003-04-07 Martin Baulig <martin@ximian.com>
6876 * codegen.cs (EmitContext.CurrentFile): New public field.
6877 (EmitContext.Mark): Use the CurrentFile to check whether the
6878 location is in the correct file.
6879 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
6881 2003-04-07 Martin Baulig <martin@ximian.com>
6883 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
6885 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
6886 location. [FIXME: The location argument which gets passed to this
6887 method is sometimes wrong!]
6889 2003-04-07 Nick Drochak <ndrochak@gol.com>
6891 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
6893 2003-04-07 Miguel de Icaza <miguel@ximian.com>
6895 * expression.cs (Indirection.EmitAssign): We were using the
6896 temporary, but returning immediately instead of continuing the
6899 2003-04-06 Martin Baulig <martin@ximian.com>
6901 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
6902 if it's a nested child, but also deriving from the outer class.
6905 * typemanager.cs (IsNestedChildOf): Make this work if it's a
6906 nested child, but also deriving from the outer class. See
6908 (FilterWithClosure): We may access private members of the outer
6909 class if we're a nested child and deriving from the outer class.
6910 (RealMemberLookup): Only set `closure_private_ok' if the
6911 `original_bf' contained BindingFlags.NonPublic.
6913 2003-04-05 Martin Baulig <martin@ximian.com>
6915 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
6916 probe if its a type parameter, and if so, flag an error.
6918 * decl.cs: Move here the SetParameterInfo code from class.cs.
6919 Handle IsGeneric here.
6921 Handle a variety of errors in the parameter info definition.
6923 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
6924 type parameters here.
6926 * cs-parser.jay (class_declaration): report errors for parameters
6929 2003-01-21 Miguel de Icaza <miguel@ximian.com>
6931 * generic.cs: New file, contains support code for generics.
6933 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
6934 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
6936 Update parser for the above removals.
6938 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
6939 now taken care of in the parser.
6941 2003-04-02 Miguel de Icaza <miguel@ximian.com>
6943 * class.cs (Event.Define): Do not allow abstract events to have
6946 2003-04-01 Miguel de Icaza <miguel@ximian.com>
6948 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
6949 block in event declarations.
6951 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
6952 value type, get its address.
6954 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
6955 leaving a class on the stack instead of a boolean value (int
6956 0/1). Change the code so we compare against null, and then the
6957 result against zero.
6959 * class.cs (TypeContainer.GetClassBases): We were checking for the
6960 parent class being sealed too late.
6962 * expression.cs (Binary.Emit): For <= and >= when dealing with
6963 floating point values, use cgt.un and clt.un instead of cgt and
6966 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
6968 * statement.cs: Apply the same optimization as MS: skip the
6969 GetEnumerator returning an IEnumerator, and use the one returning a
6970 CharEnumerator instead. This allows us to avoid the try-finally block
6973 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
6975 * cs-parser.jay: Attributes cannot be applied to
6976 namespaces. Fixes #40473
6978 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6981 (Add*): check if the name is valid using the full name for constants,
6982 fields, properties and events.
6984 2003-03-28 Miguel de Icaza <miguel@ximian.com>
6986 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
6987 char constants to be part of the enumeration.
6989 * expression.cs (Conditional.DoResolve): Add support for operator
6990 true. Implements the missing functionality from 14.12
6992 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
6993 operator true/false as required by the spec.
6995 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
6996 implicit conversion to boolean.
6998 * statement.cs (Statement.ResolveBoolean): A boolean expression is
6999 also one where the type implements `operator true'.
7001 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7002 get an expression that will invoke operator true based on an
7005 (GetConversionOperators): Removed the hack that called op_True
7008 (Expression.ResolveBoolean): Move this from Statement.
7010 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7012 * ecore.cs (FieldExpr): do not allow initialization of initonly
7013 fields on derived classes
7015 2003-03-13 Martin Baulig <martin@ximian.com>
7017 * statement.cs (Block.Emit): Call ig.BeginScope() and
7018 ig.EndScope() when compiling with debugging info; call
7019 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7021 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7023 * expression.cs (Indexers): Do not construct immediately, allow
7024 for new members to be appended as we go. Fixes 38143
7026 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7028 * expression.cs: save/restore context when resolving an unchecked
7031 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7033 * cfold.cs: Catch division by zero in modulus operator during
7036 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7038 * interface.cs (Interface.DefineMembers): Avoid defining members
7041 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7043 * driver.cs: handle the +/- options for -noconfig
7045 * statement.cs (Unckeched.Resolve): Also track the state of
7046 unchecked in the Resolve phase.
7048 2003-02-27 Martin Baulig <martin@ximian.com>
7050 * ecore.cs (Expression.MemberLookup): Don't create a
7051 MethodGroupExpr for something which is not a method. Fixes #38291.
7053 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7055 * class.cs (MemberBase.CheckParameters): Also check that the type
7056 is unmanaged if it is a pointer.
7058 * expression.cs (SizeOf.Resolve): Add location information.
7060 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7061 a managed type is declared.
7063 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7064 parameter modifiers as well. Fixes bug 38606
7066 * class.cs: Very sad. Am backing out the speed up changes
7067 introduced by the ArrayList -> Array in the TypeContainer, as they
7068 were not actually that much faster, and introduced a bug (no error
7069 reports on duplicated methods).
7071 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7072 source first, this will guarantee that we have a valid expression
7073 before calling in lower levels functions that will require a
7074 resolved object. Then use this original_source in the
7075 target.ResolveLValue instead of the original source that was
7078 Another change. Use target.Resolve instead of LValueResolve.
7079 Although we are resolving for LValues, we will let the Assign code
7080 take care of that (it will be called again from Resolve). This
7081 basically allows code like this:
7083 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7084 class Y { void A (X x) { x [0] += o; }
7086 The problem was that the indexer was trying to resolve for
7087 set_Item (idx, object o) and never finding one. The real set_Item
7088 was set_Item (idx, X). By delaying the process we get the right
7093 2003-02-23 Martin Baulig <martin@ximian.com>
7095 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7096 while calling DoEmit ().
7098 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7099 source files; if you use the #line directive inside a method, the
7100 compiler stops emitting line numbers for the debugger until it
7101 reaches the end of the method or another #line directive which
7102 restores the original file.
7104 2003-02-23 Martin Baulig <martin@ximian.com>
7106 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7108 2003-02-23 Martin Baulig <martin@ximian.com>
7110 * statement.cs (Block.AddChildVariableNames): We need to call this
7111 recursively, not just for our immediate children.
7113 2003-02-23 Martin Baulig <martin@ximian.com>
7115 * class.cs (Event.Define): Always make the field private, like csc does.
7117 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7118 actually work, fixes bug #37521.
7120 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7122 * delegate.cs: When creating the various temporary "Parameters"
7123 classes, make sure that we call the ComputeAndDefineParameterTypes
7124 on those new parameters (just like we do with the formal ones), to
7125 allow them to be resolved in the context of the DeclSpace.
7127 This fixes the bug that Dick observed in Bugzilla #38530.
7129 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7131 * expression.cs (ResolveMemberAccess): When resolving a constant,
7132 do not attempt to pull a constant if the value was not able to
7133 generate a valid constant.
7135 * const.cs (LookupConstantValue): Do not report more errors than required.
7137 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7139 * expression.cs: fixes bug #38328.
7141 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7143 * class.cs: Changed all the various members that can be part of a
7144 class from being an ArrayList to be an Array of the right type.
7145 During the DefineType type_list, interface_list, delegate_list and
7146 enum_list are turned into types, interfaces, delegates and enums
7149 And during the member population, indexer_list, event_list,
7150 constant_list, field_list, instance_constructor_list, method_list,
7151 operator_list and property_list are turned into their real arrays.
7153 Although we could probably perform this operation earlier, for
7154 good error reporting we need to keep the lists and remove the
7155 lists for longer than required.
7157 This optimization was triggered by Paolo profiling the compiler
7158 speed on the output of `gen-sample-program.pl' perl script.
7160 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7161 not crash in methods like MemberLookupFailed that use this field.
7163 This problem arises when the compiler fails to resolve a type
7164 during interface type definition for example.
7166 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7168 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7169 inherit from System.Object, so we have to stop at null, not only
7170 when reaching System.Object.
7172 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7174 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7175 DeclaredOnly because the parent indexer might have had a different
7176 name, but did not loop until the top of the hierarchy was reached.
7178 The problem this one fixes is 35492: when a class implemented an
7179 indexer from an interface, we were getting the interface method
7180 (which was abstract) and we were flagging an error (can not invoke
7183 This also keeps bug 33089 functioning, and test-148 functioning.
7185 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7186 out if a method is special is to see if it is declared in a
7187 property or event, or whether it is one of the predefined operator
7188 names. This should fix correctly #36804.
7190 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7192 The goal here is to remove the dependency on EmptyCast.Peel ().
7193 Killing it completely.
7195 The problem is that currently in a number of places where
7196 constants are expected, we have to "probe" for an EmptyCast, and
7197 Peel, which is not the correct thing to do, as this will be
7198 repetitive and will likely lead to errors.
7200 The idea is to remove any EmptyCasts that are used in casts that
7201 can be reduced to constants, so we only have to cope with
7204 This bug hunt was triggered by Bug 37363 and the desire to remove
7205 the duplicate pattern where we were "peeling" emptycasts to check
7206 whether they were constants. Now constants will always be
7209 * ecore.cs: Use an enumconstant here instead of wrapping with
7212 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7213 throwing me off. By handling this we can get rid of a few hacks.
7215 * statement.cs (Switch): Removed Peel() code.
7217 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7219 * class.cs: Location information for error 508
7221 * expression.cs (New.DoResolve): Add a guard against double
7222 resolution of an expression.
7224 The New DoResolve might be called twice when initializing field
7225 expressions (see EmitFieldInitializers, the call to
7226 GetInitializerExpression will perform a resolve on the expression,
7227 and later the assign will trigger another resolution
7229 This leads to bugs (#37014)
7231 * delegate.cs: The signature for EndInvoke should contain any ref
7232 or out parameters as well. We were not doing this in the past.
7234 * class.cs (Field.Define): Do not overwrite the type definition
7235 inside the `volatile' group. Turns out that volatile enumerations
7236 were changing the type here to perform a validity test, which
7239 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7241 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7242 and structs, we do not want to load the instance variable
7244 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7245 enum_type has to be handled like an object reference (implicit
7246 conversions exists from this to object), but the regular IsClass
7247 and IsValueType tests will never return true for this one.
7249 Also we use TypeManager.IsValueType instead of type.IsValueType,
7250 just for consistency with the rest of the code (this is only
7251 needed if we ever use the construct exposed by test-180.cs inside
7252 corlib, which we dont today).
7254 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7256 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7259 2003-02-09 Martin Baulig <martin@ximian.com>
7261 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7262 (Namespace.DefineNamespaces): New static public method; this is
7263 called when we're compiling with debugging to add all namespaces
7266 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7267 pass it to the Namespace's .ctor.
7269 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7270 and MethodBase arguments; pass the namespace ID to the symwriter;
7271 pass the MethodBase instead of the token to the symwriter.
7272 (SymbolWriter.DefineNamespace): New method to add a namespace to
7275 2003-02-09 Martin Baulig <martin@ximian.com>
7277 * symbolwriter.cs: New file. This is a wrapper around
7278 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7279 methods here in near future.
7281 2003-02-09 Martin Baulig <martin@ximian.com>
7283 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7284 ILGenerator.MarkSequencePoint() which are actually used by the
7287 2003-02-09 Martin Baulig <martin@ximian.com>
7289 * location.cs (SourceFile): New public sealed class. This
7290 contains the name and an index which is used in the location's token.
7291 (Location): Reserve an appropriate number of bits in the token for
7292 the source file instead of walking over that list, this gives us a
7293 really huge performance improvement when compiling with debugging.
7295 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7296 `SourceFile' argument instead of a string.
7297 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7298 but don't parse/tokenize here, we need to generate the list of all
7299 source files before we do that.
7300 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7303 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7304 instead of a string.
7306 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7309 2003-02-09 Martin Baulig <martin@ximian.com>
7311 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7312 filename on `#line default'.
7314 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7316 * statement.cs: don't clear the pinned var when the fixed statement
7317 returns from the method (fixes bug#37752).
7319 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7321 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7324 2003-02-07 Martin Baulig <martin@ximian.com>
7326 * driver.cs: Removed the `--debug-args' command line argument.
7328 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7329 automatically by the AsssemblyBuilder.
7330 (CodeGen.InitializeSymbolWriter): We don't need to call any
7331 initialization function on the symbol writer anymore. This method
7332 doesn't take any arguments.
7334 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7336 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7337 from referenced assemblies as well.
7339 2003-02-02 Martin Baulig <martin@ximian.com>
7341 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7343 2003-02-02 Martin Baulig <martin@ximian.com>
7345 * class.cs (Constructor.Emit): Open the symbol writer before
7346 emitting the constructor initializer.
7347 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7348 single-stepping through constructor initializers.
7350 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7352 * class.cs: Handle error 549: do not allow virtual methods in
7355 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7357 * decl.cs: Check access levels when resolving types
7359 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7361 * statement.cs: Add parameters and locals set in catch blocks that might
7362 return to set vector
7364 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7366 * class.cs (Operator): Set the SpecialName flags for operators.
7368 * expression.cs (Invocation.DoResolve): Only block calls to
7369 accessors and operators on SpecialName methods.
7371 (Cast.TryReduce): Handle conversions from char constants.
7374 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7376 * statement.cs: small memory and time optimization in FlowBranching.
7378 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7380 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7381 problem that the last fix but in the other sid (Set).
7383 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7384 access when there is no indexer in the hierarchy.
7386 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7388 * class.cs: Combine some if statements.
7390 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7392 * driver.cs: fixed bug #37187.
7394 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7396 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7397 any indexer, it's needed to build a list with all the indexers in the
7398 hierarchy (AllGetters), else we have problems. Fixes #35653.
7400 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7402 * class.cs (MethodData.Define): It is wrong for an interface
7403 implementation to be static in both cases: explicit and implicit.
7404 We were only handling this in one case.
7406 Improve the if situation there to not have negations.
7408 * class.cs (Field.Define): Turns out that we do not need to check
7409 the unsafe bit on field definition, only on usage. Remove the test.
7411 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7413 * driver.cs: use assembly.Location instead of Codebase (the latest
7414 patch made mcs fail when using MS assemblies).
7416 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7418 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7419 get the path to *corlib.dll.
7421 2003-01-21 Nick Drochak <ndrochak@gol.com>
7425 * typemanager.cs: Remove compiler warnings
7427 2003-01-20 Duncan Mak <duncan@ximian.com>
7429 * AssemblyInfo.cs: Bump the version number to 0.19.
7431 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7433 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7435 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7437 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7439 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7441 * cs-parser.jay: Small fix: we were not comparing the constructor
7442 name correctly. Thanks to Zoltan for the initial pointer.
7444 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7446 * cs-tokenizer.cs: Set file name when specified with #line
7448 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7450 * cs-parser.jay: Only perform the constructor checks here if we
7451 are named like the class; This will help provider a better
7452 error. The constructor path is taken when a type definition is
7453 not found, but most likely the user forgot to add the type, so
7454 report that rather than the constructor error.
7456 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7458 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7461 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7463 * cs-parser.jay: Add cleanup call.
7465 2003-01-13 Duncan Mak <duncan@ximian.com>
7467 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7468 consistent with other methods.
7470 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7472 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7474 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
7476 * attribute.cs: only set GuidAttr to true when we have a
7479 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7483 * typemanager.cs: fixes to allow mcs compile corlib with the new
7484 Type.IsSubclassOf fix.
7486 2003-01-08 Miguel de Icaza <miguel@ximian.com>
7488 * expression.cs (LocalVariableReference.DoResolve): Classify a
7489 constant as a value, not as a variable. Also, set the type for
7492 * cs-parser.jay (fixed_statement): take a type instead of a
7493 pointer_type, so we can produce a better error message later.
7495 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7498 (For.DoEmit): Make inifinite loops have a
7499 non-conditional branch back.
7501 (Fixed.DoEmit): First populate the pinned variables, then emit the
7502 statement, then clear the variables. Before I was emitting the
7503 code once for each fixed piece.
7506 2003-01-08 Martin Baulig <martin@ximian.com>
7508 * statement.cs (FlowBranching.MergeChild): A break in a
7509 SWITCH_SECTION does not leave a loop. Fixes #36155.
7511 2003-01-08 Martin Baulig <martin@ximian.com>
7513 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7514 lives in the same number space than `param_map'. Fixes #36154.
7516 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7518 * cs-parser.jay (constructor_declaration): Set the
7519 Constructor.ModFlags before probing for it. This makes the
7520 compiler report 514, 515 and 132 (the code was there, but got
7523 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7524 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7525 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7527 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
7529 * enum.cs: create the enum static fields using the enum type.
7531 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
7533 * class.cs: don't try to create the ParamBuilder for the return
7534 type if it's not needed (and handle it breaking for the ms runtime
7537 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
7539 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
7541 2002-12-29 Miguel de Icaza <miguel@ximian.com>
7543 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
7544 the command. This showed up while compiling the JANET source
7545 code, which used \r as its only newline separator.
7547 2002-12-28 Miguel de Icaza <miguel@ximian.com>
7549 * class.cs (Method.Define): If we are an operator (because it
7550 reuses our code), then set the SpecialName and HideBySig. #36128
7552 2002-12-22 Miguel de Icaza <miguel@ximian.com>
7554 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
7555 exception, report error 120 `object reference required'.
7557 * driver.cs: Add --pause option, used during to measure the size
7558 of the process as it goes with --timestamp.
7560 * expression.cs (Invocation.DoResolve): Do not allow methods with
7561 SpecialName to be invoked.
7563 2002-12-21 Miguel de Icaza <miguel@ximian.com>
7565 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
7566 number before adding it.
7568 2002-12-21 Ravi Pratap <ravi@ximian.com>
7570 * ecore.cs (StandardImplicitConversion): When in an unsafe
7571 context, we allow conversion between void * to any other pointer
7572 type. This fixes bug #35973.
7574 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
7576 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
7577 is not thrown when extensionless outputs are used
7579 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7581 * rootcontext.cs: fixed compilation of corlib.
7583 2002-12-19 Miguel de Icaza <miguel@ximian.com>
7585 * attribute.cs (Attributes.Contains): Add new method.
7587 * class.cs (MethodCore.LabelParameters): if the parameter is an
7588 `out' parameter, check that no attribute `[In]' has been passed.
7590 * enum.cs: Handle the `value__' name in an enumeration.
7592 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
7594 * decl.cs: Added special case to allow overrides on "protected
7597 2002-12-18 Ravi Pratap <ravi@ximian.com>
7599 * attribute.cs (Attributes.AddAttributeSection): Rename to this
7600 since it makes much more sense.
7602 (Attributes.ctor): Don't require a Location parameter.
7604 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
7606 * attribute.cs (ApplyAttributes): Remove extra Location parameters
7607 since we already have that information per attribute.
7609 * everywhere : make appropriate changes.
7611 * class.cs (LabelParameters): Write the code which actually
7612 applies attributes to the return type. We can't do this on the MS
7613 .NET runtime so we flag a warning in the case an exception is
7616 2002-12-18 Miguel de Icaza <miguel@ximian.com>
7618 * const.cs: Handle implicit null conversions here too.
7620 2002-12-17 Ravi Pratap <ravi@ximian.com>
7622 * class.cs (MethodCore.LabelParameters): Remove the extra
7623 Type [] parameter since it is completely unnecessary. Instead
7624 pass in the method's attributes so that we can extract
7625 the "return" attribute.
7627 2002-12-17 Miguel de Icaza <miguel@ximian.com>
7629 * cs-parser.jay (parse): Use Report.Error to flag errors instead
7630 of ignoring it and letting the compile continue.
7632 * typemanager.cs (ChangeType): use an extra argument to return an
7633 error condition instead of throwing an exception.
7635 2002-12-15 Miguel de Icaza <miguel@ximian.com>
7637 * expression.cs (Unary.TryReduce): mimic the code for the regular
7638 code path. Perform an implicit cast in the cases where we can
7639 implicitly convert to one of the integral types, and then reduce
7640 based on that constant. This fixes bug #35483.
7642 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7644 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
7646 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7648 * namespace.cs: fixed bug #35489.
7650 2002-12-12 Miguel de Icaza <miguel@ximian.com>
7652 * class.cs: Remove some dead code.
7654 * cs-parser.jay: Estimate the number of methods needed
7655 (RootContext.MethodCount);
7657 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
7658 numbers instead of StringBuilders.
7660 * support.cs (PtrHashtable): Add constructor with initial size;
7661 We can now reduce reallocations of the method table.
7663 2002-12-10 Ravi Pratap <ravi@ximian.com>
7665 * attribute.cs (ApplyAttributes): Keep track of the emitted
7666 attributes on a per-target basis. This fixes bug #35413.
7668 2002-12-10 Miguel de Icaza <miguel@ximian.com>
7670 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
7671 default to the Windows 1252 encoding.
7673 (UnixParseOption): Support version, thanks to Alp for the missing
7676 * AssemblyInfo.cs: Add nice assembly information.
7678 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
7681 * cs-parser.jay: Allow a trailing comma before the close bracked
7682 in the attribute_section production.
7684 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
7685 address of the instance was being taken, I will take this out,
7686 because we take the address of the object immediately here.
7688 2002-12-09 Ravi Pratap <ravi@ximian.com>
7690 * typemanager.cs (AreMultipleAllowed): Take care of the most
7691 obvious case where attribute type is not in the current assembly -
7694 2002-12-08 Miguel de Icaza <miguel@ximian.com>
7696 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
7697 definitions, instead of doing that afterwards.
7699 Also we use a nice little hack, depending on the constructor, we
7700 know if we are a "composed" name or a simple name. Hence, we
7701 avoid the IndexOf test, and we avoid
7703 * codegen.cs: Add code to assist in a bug reporter to track down
7704 the source of a compiler crash.
7706 2002-12-07 Ravi Pratap <ravi@ximian.com>
7708 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
7709 types have been emitted for a given element and flag an error
7710 if something which does not have AllowMultiple set is used more
7713 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
7714 attribute types and their corresponding AllowMultiple properties
7716 (AreMultipleAllowed): Check the property for a given type.
7718 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
7719 property in the case we have a TypeContainer.
7721 (Attributes.AddAttribute): Detect duplicates and just skip on
7722 adding them. This trivial fix catches a pretty gross error in our
7723 attribute emission - global attributes were being emitted twice!
7725 Bugzilla bug #33187 is now fixed.
7727 2002-12-06 Miguel de Icaza <miguel@ximian.com>
7729 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
7732 * expression.cs (Binary.ResolveOperator): I can only use the
7733 Concat (string, string, string) and Concat (string, string,
7734 string, string) if the child is actually a concatenation of
7737 2002-12-04 Miguel de Icaza <miguel@ximian.com>
7739 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
7740 context where we need a 2-character lookahead.
7742 * pending.cs (PendingImplementation): Rework so we can keep track
7743 of interface types all the time, and flag those which were
7744 implemented by parents as optional.
7746 2002-12-03 Miguel de Icaza <miguel@ximian.com>
7748 * expression.cs (Binary.ResolveOperator): Use
7749 String.Concat(string,string,string) or
7750 String.Concat(string,string,string,string) when possible.
7752 * typemanager: More helper methods.
7755 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
7757 * pending.cs: remove the bogus return from GetMissingInterfaces()
7758 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
7760 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7762 * namespace.cs: avoid duplicated 'using xxx' being added to
7763 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
7764 when we get more than one 'using' statement for the same namespace.
7765 Report a CS0105 warning for it.
7767 2002-11-30 Miguel de Icaza <miguel@ximian.com>
7769 * cs-tokenizer.cs (consume_identifier): use read directly, instead
7770 of calling getChar/putback, uses internal knowledge of it.
7772 (xtoken): Reorder tokenizer so most common patterns are checked
7773 first. This reduces the compilation time in another 5% (from 8.11s
7774 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
7776 The parsing time is 22% of the compilation in mcs, and from that
7777 64% is spent on the tokenization process.
7779 I tried using a binary search for keywords, but this is slower
7780 than the hashtable. Another option would be to do a couple of
7783 * Not use a StringBuilder, instead use an array of chars,
7784 with a set value. Notice that this way we could catch
7785 the 645 error without having to do it *afterwards*.
7787 * We could write a hand-parser to avoid the hashtable
7788 compares altogether.
7790 The identifier consumption process takes 37% of the tokenization
7791 time. Another 15% is spent on is_number. 56% of the time spent
7792 on is_number is spent on Int64.Parse:
7794 * We could probably choose based on the string length to
7795 use Int32.Parse or Int64.Parse and avoid all the 64-bit
7798 Another 3% is spend on wrapping `xtoken' in the `token' function.
7800 Handle 0xa0 as whitespace (#34752)
7802 2002-11-26 Miguel de Icaza <miguel@ximian.com>
7804 * typemanager.cs (IsCLRType): New routine to tell whether a type
7805 is one of the builtin types.
7807 Maybe it needs to use TypeCodes to be faster. Maybe we could use
7808 typecode in more places instead of doing pointer comparissions.
7809 We could leverage some knowledge about the way the typecodes are
7812 New code to cache namespaces in assemblies, it is currently not
7813 invoked, to be used soon.
7815 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
7817 * expression.cs (Binary.ResolveOperator): specially handle
7818 strings, and do not perform user-defined operator overloading for
7821 2002-11-24 Miguel de Icaza <miguel@ximian.com>
7823 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
7824 internalcall as it is a pretty simple operation; Avoid whenever
7825 possible to call Char.IsLetter.
7827 (consume_identifier): Cut by half the number of
7828 hashtable calls by merging the is_keyword and GetKeyword behavior.
7830 Do not short-circuit, because if we do, we
7831 report errors (ie, #if false && true would produce an invalid
7835 2002-11-24 Martin Baulig <martin@ximian.com>
7837 * expression.cs (Cast.TryReduce): If we're in checked syntax,
7838 check constant ranges and report a CS0221. Fixes #33186.
7840 2002-11-24 Martin Baulig <martin@ximian.com>
7842 * cs-parser.jay: Make this work for uninitialized variable
7843 declarations in the `for' initializer. Fixes #32416.
7845 2002-11-24 Martin Baulig <martin@ximian.com>
7847 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
7848 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
7850 2002-11-24 Martin Baulig <martin@ximian.com>
7852 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
7853 argument; if true, we also check for user-defined conversions.
7854 This is only needed if both arguments are of a user-defined type.
7855 Fixes #30443, added test-175.cs.
7856 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
7858 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
7860 2002-11-24 Martin Baulig <martin@ximian.com>
7862 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
7863 function to get the store opcode.
7864 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
7865 only emit the Ldelema if the store opcode is Stobj. You must run
7866 both test-34 and test-167 to test this. Fixes #34529.
7868 2002-11-23 Martin Baulig <martin@ximian.com>
7870 * ecore.cs (Expression.MemberLookup): Added additional
7871 `qualifier_type' argument which is used when we're being called
7872 from MemberAccess.DoResolve() and null if we're called from a
7874 (Expression.MemberLookupFailed): New method to report errors; this
7875 does the CS1540 check and reports the correct error message.
7877 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
7878 argument for the CS1540 check and redone the way how we're dealing
7879 with private members. See the comment in the source code for details.
7880 (FilterWithClosure): Reverted this back to revision 1.197; renamed
7881 `closure_start_type' to `closure_qualifier_type' and check whether
7882 it's not null. It was not this filter being broken, it was just
7883 being called with the wrong arguments.
7885 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
7886 and pass it the correct `qualifier_type'; this also does the error
7889 2002-11-22 Miguel de Icaza <miguel@ximian.com>
7891 * expression.cs (Invocation.EmitParams): If the we are dealing
7892 with a non-built-in value type, load its address as well.
7894 (ArrayCreation): Use a a pretty constant instead
7895 of the hardcoded value 2. Use 6 instead of 2 for the number of
7896 static initializers.
7898 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
7899 because they are not really value types, just glorified integers.
7901 * driver.cs: Do not append .exe, the CSC compiler does not do it.
7903 * ecore.cs: Remove redundant code for enumerations, make them use
7904 the same code path as everything else, fixes the casting issue
7905 with enumerations in Windows.Forms.
7907 * attribute.cs: Do only cast to string if it is a string, the
7908 validation happens later.
7910 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
7911 people upgrade their corlibs.
7913 * ecore.cs: Oops, enumerations were not following the entire code path
7915 2002-11-21 Miguel de Icaza <miguel@ximian.com>
7917 * typemanager.cs (FilterWithClosure): Commented out the test for
7918 1540 in typemanager.cs, as it has problems when accessing
7919 protected methods from a parent class (see test-174.cs).
7921 * attribute.cs (Attribute.ValidateGuid): new method.
7922 (Attribute.Resolve): Use above.
7924 2002-11-19 Miguel de Icaza <miguel@ximian.com>
7926 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
7928 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
7929 handling for enumerations, as we only needed the TypeContainer
7930 functionality to begin with (this is required for the fix below to
7931 work for enums that reference constants in a container class for
7934 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
7936 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
7937 a valid TypeBuilder to perform lookups on.o
7939 * class.cs (InheritableMemberSignatureCompare): Use true in the
7940 call to GetGetMethod and GetSetMethod, because we are comparing
7941 the signature, and we need to get the methods *even* if they are
7944 (PropertyBase.CheckBase): ditto.
7946 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
7947 GotoCase.Resolve): Use Peel on EmpytCasts.
7949 * ecore.cs (EmptyCast): drop child, add Peel method.
7951 2002-11-17 Martin Baulig <martin@ximian.com>
7953 * ecore.cs (EmptyCast.Child): New public property.
7955 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
7956 label resolved to an EmptyCast. Fixes #34162.
7957 (GotoCase.Resolve): Likewise.
7958 (Block.EmitMeta): Likewise.
7960 2002-11-17 Martin Baulig <martin@ximian.com>
7962 * expression.cs (Invocation.BetterConversion): Prefer int over
7963 uint; short over ushort; long over ulong for integer literals.
7964 Use ImplicitConversionExists instead of StandardConversionExists
7965 since we also need to check for user-defined implicit conversions.
7966 Fixes #34165. Added test-173.cs.
7968 2002-11-16 Martin Baulig <martin@ximian.com>
7970 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
7971 with the `true' and `false' literals. Fixes #33151.
7973 2002-11-16 Martin Baulig <martin@ximian.com>
7975 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
7976 October 22nd; don't do the cs1540 check for static members.
7978 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
7979 now using our own filter here and doing the cs1540 check again.
7981 2002-11-16 Martin Baulig <martin@ximian.com>
7983 * support.cs (InternalParameters): Don't crash if we don't have
7984 any fixed parameters. Fixes #33532.
7986 2002-11-16 Martin Baulig <martin@ximian.com>
7988 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
7989 when looking up static methods to make this work on Windows.
7992 2002-11-16 Martin Baulig <martin@ximian.com>
7994 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
7995 a setter rather than using PropertyInfo.CanWrite.
7997 2002-11-15 Nick Drochak <ndrochak@gol.com>
7999 * class.cs: Allow acces to block member by subclasses. Fixes build
8002 2002-11-14 Martin Baulig <martin@ximian.com>
8004 * class.cs (Constructor.Emit): Added the extern/block check.
8007 2002-11-14 Martin Baulig <martin@ximian.com>
8009 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8010 iteration while looking for indexers, this is needed because the
8011 indexer may have a different name in our base classes. Fixed the
8012 error reporting (no indexers at all, not get accessor, no
8013 overloaded match). Fixes bug #33089.
8014 (IndexerAccess.DoResolveLValue): Likewise.
8016 2002-11-14 Martin Baulig <martin@ximian.com>
8018 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8019 indexers. Fixes the first part of bug #33089.
8020 (MethodSignature.InheritableMemberSignatureCompare): Added support
8023 2002-11-13 Ravi Pratap <ravi@ximian.com>
8025 * attribute.cs (Attribute.Resolve): Catch the
8026 NullReferenceException and report it since it isn't supposed to
8029 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8031 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8032 LogicalOr and LogicalAnd that can benefit from recursively
8033 handling EmitBranchable. The code now should be nice for Paolo.
8035 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8037 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8038 the Type lookups, as we perform quite a number of lookups on
8039 non-Types. This can be removed once we can deterministically tell
8040 whether we have a type or a namespace in advance.
8042 But this might require special hacks from our corlib.
8046 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8047 and double which avoids a conversion from an integer to a double.
8049 * expression.cs: tiny optimization, avoid calling IsConstant,
8050 because it effectively performs the lookup twice.
8052 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8054 But a bogus return here to keep the semantics of the old code
8055 until the Mono runtime is fixed.
8057 * pending.cs (GetMissingInterfaces): New method used to remove all
8058 the interfaces that are already implemented by our parent
8059 classes from the list of pending methods.
8061 * interface.cs: Add checks for calls after ResolveTypeExpr.
8063 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8065 * class.cs (Class.Emit): Report warning 67: event not used if the
8066 warning level is beyond 3.
8068 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8069 being a NullLiteral.
8071 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8074 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8075 path that might fail if a type can not be resolved.
8077 * expression.cs (Binary.Emit): Emit unsigned versions of the
8080 * driver.cs: use error 5.
8082 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8084 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8086 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8088 * cs-parser.jay (switch_section): A beautiful patch from Martin
8089 Baulig that fixed 33094.
8091 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8093 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8094 Check whether the base is abstract and report an error if so.
8096 * expression.cs (IndexerAccess.DoResolveLValue,
8097 IndexerAccess.DoResolve): ditto.
8099 (Invocation.DoResolve): ditto.
8101 (Invocation.FullMethodDesc): Improve the report string.
8103 * statement.cs (Block): Eliminate IsVariableDefined as it is
8104 basically just a wrapper for GetVariableInfo.
8106 * ecore.cs (SimpleName): Use new
8108 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8109 type, as we return the actual parameter ref/unref state on a
8112 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8114 * support.cs: Return proper flags REF/OUT fixing the previous
8117 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8118 not used to mean `ref' but `ref or out' in ParameterReference
8120 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8121 full type signature instead of calling TypeManger.CSharpName
8124 * support.cs (InternalParameters.ParameterDesc): Do not compare
8125 directly to the modflags, because REF/OUT will actually be bitsets
8128 * delegate.cs (VerifyMethod): Check also the modifiers.
8130 * cs-tokenizer.cs: Fix bug where floating point values with an
8131 exponent where a sign was missing was ignored.
8133 * driver.cs: Allow multiple assemblies to be specified in a single
8136 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8138 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8139 because identifiers after a parenthesis would end up in this kind
8140 of production, and we needed to desamiguate it for having casts
8143 (UserDefinedType *) xxx
8145 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8147 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8148 we should set on the Bindingflags.NonPublic, but not turn on
8149 private_ok. private_ok controls whether a Private member is
8150 returned (this is chekced on the filter routine), while the
8151 BindingFlags.NonPublic just controls whether private/protected
8152 will be allowed. This fixes the problem part of the problem of
8153 private properties being allowed to be used in derived classes.
8155 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8156 so we can call the children DoResolveLValue method (this will
8157 properly signal errors on lvalue assignments to base properties)
8159 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8160 getter are null, and we have a property info, we know that this
8161 happened because the lookup failed, so we report an error 122 for
8162 protection level violation.
8164 We also silently return if setter and getter are null in the
8165 resolve functions, this condition only happens if we have flagged
8166 the error before. This is the other half of the problem.
8168 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8169 not have accessibility information, that is why we were returning
8170 true in the filter function in typemanager.cs.
8172 To properly report 122 (property is inaccessible because of its
8173 protection level) correctly, we report this error in ResolveAccess
8174 by failing if both the setter and the getter are lacking (ie, the
8177 DoResolve and DoLResolve have been modified to check for both
8178 setter/getter being null and returning silently, the reason being
8179 that I did not want to put the knowledge about this error in upper
8182 int old = Report.Errors;
8183 x = new PropertyExpr (...);
8184 if (old != Report.Errors)
8189 So the property expr is returned, but it is invalid, so the error
8190 will be flagged during the resolve process.
8192 * class.cs: Remove InheritablePropertySignatureCompare from the
8193 class, as we no longer depend on the property signature to compute
8194 whether it is possible to implement a method or not.
8196 The reason is that calling PropertyInfo.GetGetMethod will return
8197 null (in .NET, in Mono it works, and we should change this), in
8198 cases where the Get Method does not exist in that particular
8203 class X { public virtual int A { get { return 1; } } }
8205 class Z : Y { public override int A { get { return 2; } } }
8207 Would fail in Z because the parent (Y) would not have the property
8208 defined. So we avoid this completely now (because the alternative
8209 fix was ugly and slow), and we now depend exclusively on the
8212 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8213 reference method, instead of using the property.
8215 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8216 routines are gone now.
8218 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8219 names, they were incorrectly named.
8221 * cs-tokenizer.cs: Return are more gentle token on failure.
8223 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8224 had an out-of-sync index variable, which caused it to remove from
8225 the list of pending methods the wrong method sometimes.
8227 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8229 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8230 CanWrite, because those refer to this particular instance of the
8231 property, and do not take into account the fact that we can
8232 override single members of a property.
8234 Constructor requires an EmitContext. The resolution process does
8235 not happen here, but we need to compute the accessors before,
8236 because the resolution does not always happen for properties.
8238 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8239 subclass, before we did not update this flag, but we did update
8242 (GetAccessors): Drop this routine, as it did not work in the
8243 presence of partially overwritten set/get methods.
8245 Notice that this broke the cs1540 detection, but that will require
8248 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8252 * driver.cs: issue a warning instead of an error if we don't support
8253 debugging for the platform. Also ignore a couple of errors that may
8254 arise when trying to write the symbols. Undo my previous patch.
8256 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8258 * driver.cs: ignore /debug switch except for Unix platforms.
8260 2002-10-23 Nick Drochak <ndrochak@gol.com>
8262 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8264 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8266 * driver.cs: Do not make mcs-debug conditional, so we do not break
8269 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8270 review this patch. But basically after all the children variables
8271 have been merged, the value of "Breaks" was not being set to
8272 new_breaks for Switch blocks. I think that it should be set after
8273 it has executed. Currently I set this to the value of new_breaks,
8274 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8275 conservative, but I do not understand this code very well.
8277 I did not break anything in the build, so that is good ;-)
8279 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8281 2002-10-20 Mark Crichton <crichton@gimp.org>
8283 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8285 2002-10-20 Nick Drochak <ndrochak@gol.com>
8287 * cfold.cs: Fixed compile blocker.
8289 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8291 * driver.cs: I was chekcing the key, not the file.
8293 2002-10-19 Ravi Pratap <ravi@ximian.com>
8295 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8296 message that we were generating - we just need to silently return
8299 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8301 * class.cs (Event.Define): Change my previous commit, as this
8302 breaks the debugger. This is a temporary hack, as it seems like
8303 the compiler is generating events incorrectly to begin with.
8305 * expression.cs (Binary.ResolveOperator): Added support for
8306 "U operator - (E x, E y)"
8308 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8311 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8312 init-only variables, but this path did not take into account that
8313 there might be also instance readonly variables. Correct this
8316 This fixes bug 32253
8318 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8321 * driver.cs: Change the extension for modules to `netmodule'
8323 * cs-parser.jay: Improved slightly the location tracking for
8324 the debugger symbols.
8326 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8327 modifiers that were specified instead of the hardcoded value
8328 (FamAndAssem). This was basically ignoring the static modifier,
8329 and others. Fixes 32429.
8331 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8332 fixed a bug in the process (32476)
8334 * expression.cs (ArrayAccess.EmitAssign): Patch from
8335 hwang_rob@yahoo.ca that fixes bug 31834.3
8337 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8339 * driver.cs: Make the module extension .netmodule.
8341 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8343 * driver.cs: Report an error if the resource file is not found
8344 instead of crashing.
8346 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8347 false, like Emit does.
8349 2002-10-16 Nick Drochak <ndrochak@gol.com>
8351 * typemanager.cs: Remove unused private member. Also reported mcs
8352 bug to report this as a warning like csc.
8354 2002-10-15 Martin Baulig <martin@gnome.org>
8356 * statement.cs (Statement.Emit): Made this a virtual method; emits
8357 the line number info and calls DoEmit().
8358 (Statement.DoEmit): New protected abstract method, formerly knows
8359 as Statement.Emit().
8361 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8363 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8365 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8366 have fixed a remaining problem: not every AddXXXX was adding a
8367 fully qualified name.
8369 Now everyone registers a fully qualified name in the DeclSpace as
8370 being defined instead of the partial name.
8372 Downsides: we are slower than we need to be due to the excess
8373 copies and the names being registered this way.
8375 The reason for this is that we currently depend (on the corlib
8376 bootstrap for instance) that types are fully qualified, because
8377 we dump all the types in the namespace, and we should really have
8378 types inserted into the proper namespace, so we can only store the
8379 basenames in the defined_names array.
8381 2002-10-10 Martin Baulig <martin@gnome.org>
8383 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8384 from bug #31834, see the bug report for a testcase which is
8387 2002-10-10 Martin Baulig <martin@gnome.org>
8389 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8390 flow analysis code for this.
8392 * statement.cs (Do, While, For): Tell the flow analysis code about
8394 (FlowBranching.UsageVector): Added support for infinite loops.
8395 (Block.Resolve): Moved the dead code elimination here and use flow
8398 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8400 * class.cs (Field.Define): Catch cycles on struct type
8403 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8404 fields if the fields are static. We only need to check instance
8407 * expression.cs (As.DoResolve): Test for reference type.
8409 * statement.cs (Using.ResolveExpression): Use
8410 ConvertImplicitRequired, not ConvertImplicit which reports an
8412 (Using.ResolveLocalVariableDecls): ditto.
8414 * expression.cs (Binary.ResolveOperator): Report errors in a few
8415 places where we had to.
8417 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8419 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8421 * expression.cs: Use StoreFromPtr instead of extracting the type
8422 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8424 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8425 an enumeration value to a System.Enum, but System.Enum is not a
8426 value type, but an class type, so we need to box.
8428 (Expression.ConvertExplicit): One codepath could return
8429 errors but not flag them. Fix this. Fixes #31853
8431 * parameter.cs (Resolve): Do not allow void as a parameter type.
8433 2002-10-06 Martin Baulig <martin@gnome.org>
8435 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8436 if it's a class type and not a struct. Fixes #31815.
8438 2002-10-06 Martin Baulig <martin@gnome.org>
8440 * statement.cs: Reworked the flow analysis code a bit to make it
8441 usable for dead code elimination.
8443 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8445 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8447 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8449 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8450 to fix the test 165, will investigate deeper.
8452 2002-10-04 Martin Baulig <martin@gnome.org>
8454 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8455 finally blocks actually work.
8456 (Try.Resolve): We don't need to create a sibling for `finally' if
8457 there is no finally block.
8459 2002-10-04 Martin Baulig <martin@gnome.org>
8461 * class.cs (Constructor.Define): The default accessibility for a
8462 non-default constructor is private, not public.
8464 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8466 * class.cs (Constructor): Make AllowedModifiers public, add
8469 * cs-parser.jay: Perform the modifiers test here, as the
8470 constructor for the Constructor class usually receives a zero
8471 because of the way we create it (first we create, later we
8472 customize, and we were never checking the modifiers).
8474 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8475 is a version of LookupTypeReflection that includes the type-name
8476 cache. This can be used as a fast path for functions that know
8477 the fully qualified name and are only calling into *.GetType() to
8478 obtain a composed type.
8480 This is also used by TypeManager.LookupType during its type
8483 (LookupType): We now also track the real type name, as sometimes
8484 we can get a quey for the real type name from things like
8485 ComposedCast. This fixes bug 31422.
8487 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
8488 complete type fullname, it does not have to go through the type
8489 resolution system to obtain the composed version of the type (for
8490 obtaining arrays or pointers).
8492 (Conditional.Emit): Use the EmitBoolExpression to
8493 generate nicer code, as requested by Paolo.
8495 (ArrayCreation.CheckIndices): Use the patch from
8496 hwang_rob@yahoo.ca to validate the array initializers.
8498 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8500 * class.cs (ConstructorInitializer.Emit): simplify code by using
8501 Invocation.EmitCall, and at the same time, fix the bugs in calling
8502 parent constructors that took variable arguments.
8504 * ecore.cs (Expression.ConvertNumericExplicit,
8505 Expression.ImplicitNumericConversion): Remove the code that
8506 manually wrapped decimal (InternalTypeConstructor call is now gone
8509 * expression.cs (Cast.TryReduce): Also handle decimal types when
8510 trying to perform a constant fold on the type.
8512 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8514 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8515 that only turned off an error report, and did nothing else.
8517 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8519 * driver.cs: Handle and ignore /fullpaths
8521 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8523 * expression.cs (Binary.ResolveOperator): Catch the case where
8524 DoNumericPromotions returns true,
8526 (Binary.DoNumericPromotions): Simplify the code, and the tests.
8528 2002-09-27 Miguel de Icaza <miguel@ximian.com>
8530 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
8533 2002-09-26 Miguel de Icaza <miguel@ximian.com>
8535 * ecore.cs (ConvertNumericExplicit): It is not enough that the
8536 conversion exists, but it is also required that the conversion be
8537 performed. This manifested in "(Type64Enum) 2".
8539 * class.cs (TypeManager.AddMethod): The fix is not to change
8540 AddEnum, because that one was using a fully qualified name (every
8541 DeclSpace derivative does), but to change the AddMethod routine
8542 that was using an un-namespaced name. This now correctly reports
8543 the duplicated name.
8545 Revert patch until I can properly fix it. The issue
8546 is that we have a shared Type space across all namespaces
8547 currently, which is wrong.
8549 Options include making the Namespace a DeclSpace, and merge
8550 current_namespace/current_container in the parser.
8552 2002-09-25 Miguel de Icaza <miguel@ximian.com>
8554 * cs-parser.jay: Improve error reporting when we get a different
8555 kind of expression in local_variable_type and
8556 local_variable_pointer_type.
8558 Propagate this to avoid missleading errors being reported.
8560 * ecore.cs (ImplicitReferenceConversion): treat
8561 TypeManager.value_type as a target just like object_type. As
8566 Is valid, and needs to result in the int 1 being boxed before it
8567 is assigned to the value type v.
8569 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
8570 to validate the enumeration name.
8572 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
8573 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
8574 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
8576 * ecore.cs (TryImplicitIntConversion): When doing an
8577 implicit-enumeration-conversion, check if the type is 64-bits and
8578 perform a conversion before passing to EnumConstant.
8580 2002-09-23 Miguel de Icaza <miguel@ximian.com>
8582 * decl.cs (Error_AmbiguousTypeReference); New routine used to
8583 report ambiguous type references. Unlike the MS version, we
8584 report what the ambiguity is. Innovation at work ;-)
8586 (DeclSpace.FindType): Require a location argument to
8587 display when we display an ambiguous error.
8589 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
8591 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
8593 * expression.cs (EmitDynamicInitializers): Apply patch from
8594 hwang_rob@yahoo.ca that fixes the order in which we emit our
8597 2002-09-21 Martin Baulig <martin@gnome.org>
8599 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
8600 delegate takes no arguments.
8602 2002-09-20 Miguel de Icaza <miguel@ximian.com>
8604 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
8607 * expression.cs: Extract the underlying type.
8609 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
8611 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
8613 2002-09-19 Miguel de Icaza <miguel@ximian.com>
8615 * class.cs (TypeContainer.DefineType): We can not use the nice
8616 PackingSize with the size set to 1 DefineType method, because it
8617 will not allow us to define the interfaces that the struct
8620 This completes the fixing of bug 27287
8622 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
8623 means also structs. This fixes part of the problem.
8624 (Expresion.ImplicitReferenceConversionExists): ditto.
8626 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
8627 error if there were no errors reported during the type lookup
8628 process, to avoid duplicates or redundant errors. Without this
8629 you would get an ambiguous errors plus a type not found. We have
8630 beaten the user enough with the first error.
8632 (DeclSparce.FindType): Emit a warning if we have an ambiguous
8635 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
8636 during the resolution process, stop the lookup, this avoids
8637 repeated error reports (same error twice).
8639 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
8641 * typemanager.cs (LookupType): Redo the type lookup code to match
8642 the needs of System.Reflection.
8644 The issue is that System.Reflection requires references to nested
8645 types to begin with a "+" sign instead of a dot. So toplevel
8646 types look like: "NameSpace.TopLevelClass", and nested ones look
8647 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
8650 2002-09-19 Martin Baulig <martin@gnome.org>
8652 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
8653 says that a method always returns or always throws an exception,
8654 don't report the CS0161.
8656 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
8657 set `Returns = new_returns'.
8659 2002-09-19 Martin Baulig <martin@gnome.org>
8661 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
8662 to an enum constant, check for a CS0176.
8664 2002-09-18 Miguel de Icaza <miguel@ximian.com>
8666 * class.cs (TypeContainer.CheckPairedOperators): Now we check
8667 for operators that must be in pairs and report errors.
8669 * ecore.cs (SimpleName.DoResolveType): During the initial type
8670 resolution process, when we define types recursively, we must
8671 check first for types in our current scope before we perform
8672 lookups in the enclosing scopes.
8674 * expression.cs (MakeByteBlob): Handle Decimal blobs.
8676 (Invocation.VerifyArgumentsCompat): Call
8677 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
8678 I thought we were supposed to always call this, but there are a
8679 few places in the code where we dont do it.
8681 2002-09-17 Miguel de Icaza <miguel@ximian.com>
8683 * driver.cs: Add support in -linkres and -resource to specify the
8684 name of the identifier.
8686 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8688 * ecore.cs (StandardConversionExists): Sync with the conversion
8689 code: allow anything-* to void* conversions.
8691 (FindMostSpecificSource): Use an Expression argument
8692 instead of a Type, because we might be handed over a Literal which
8693 gets a few more implicit conversions that plain types do not. So
8694 this information was being lost.
8696 Also, we drop the temporary type-holder expression when not
8699 2002-09-17 Martin Baulig <martin@gnome.org>
8701 * class.cs (PropertyBase.CheckBase): Don't check the base class if
8702 this is an explicit interface implementation.
8704 2002-09-17 Martin Baulig <martin@gnome.org>
8706 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
8707 different `IndexerName' attributes.
8709 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
8710 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
8711 virtual CommonResolve().
8713 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8715 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
8716 and convert that to the UnderlyingType.
8718 * statement.cs (Foreach.Resolve): Indexers are just like variables
8719 or PropertyAccesses.
8721 * cs-tokenizer.cs (consume_string): Track line numbers and columns
8722 inside quoted strings, we were not doing this before.
8724 2002-09-16 Martin Baulig <martin@gnome.org>
8726 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
8727 resolve it. This is needed for the definite assignment check of the
8728 instance expression, fixes bug #29846.
8729 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
8731 2002-09-16 Nick Drochak <ndrochak@gol.com>
8733 * parameter.cs: Fix compile error. Cannot reference static member
8734 from an instance object. Is this an mcs bug?
8736 2002-09-14 Martin Baulig <martin@gnome.org>
8738 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
8739 multiple times. Fixes bug #30295, added test-166.cs.
8741 2002-09-14 Martin Baulig <martin@gnome.org>
8743 * statement.cs (Block.Emit): Don't emit unreachable code.
8744 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
8746 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
8748 2002-09-14 Martin Baulig <martin@gnome.org>
8750 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
8753 2002-09-14 Martin Baulig <martin@gnome.org>
8755 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
8756 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
8757 be false on the ms runtime.
8759 2002-09-13 Martin Baulig <martin@gnome.org>
8761 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
8762 the CS0038 error message.
8764 2002-09-12 Miguel de Icaza <miguel@ximian.com>
8766 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
8767 constant inside, return it.
8769 2002-09-12 Martin Baulig <martin@gnome.org>
8771 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
8772 implicit conversion can be done between enum types.
8774 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
8775 check whether an implicit conversion to the current enum's UnderlyingType
8776 exists and report an error if not.
8778 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
8779 without debugging support.
8781 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
8782 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
8784 2002-09-12 Martin Baulig <martin@gnome.org>
8786 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
8788 * ecore.cs (IMemberExpr.DeclaringType): New property.
8789 (SimpleName.SimpleNameResolve): Check whether we're accessing a
8790 nonstatic member of an outer type (CS0038).
8792 2002-09-11 Miguel de Icaza <miguel@ximian.com>
8794 * driver.cs: Activate the using-error detector at warning level
8795 4 (at least for MS-compatible APIs).
8797 * namespace.cs (VerifyUsing): Small buglett fix.
8799 * pending.cs (PendingImplementation): pass the container pointer.
8801 * interface.cs (GetMethods): Allow for recursive definition. Long
8802 term, I would like to move every type to support recursive
8803 definitions, not the current ordering mechanism that we have right
8806 The situation is this: Attributes are handled before interfaces,
8807 so we can apply attributes to interfaces. But some attributes
8808 implement interfaces, we will now handle the simple cases
8809 (recursive definitions will just get an error).
8811 * parameter.cs: Only invalidate types at the end if we fail to
8814 2002-09-09 Martin Baulig <martin@gnome.org>
8816 * ecore.cs (PropertyExpr.Emit): Also check for
8817 TypeManager.system_int_array_get_length so this'll also work when
8818 compiling corlib. Fixes #30003.
8820 2002-09-09 Martin Baulig <martin@gnome.org>
8822 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
8823 and throw an exception if we can't get the type's size. Fixed #30040,
8826 2002-09-09 Martin Baulig <martin@gnome.org>
8828 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
8830 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
8831 context. Fixes bug #30027.
8833 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
8834 virtual functions. Fixes bug #30043, added test-164.cs.
8836 2002-09-08 Ravi Pratap <ravi@ximian.com>
8838 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
8840 2002-09-08 Nick Drochak <ndrochak@gol.com>
8842 * driver.cs: Use an object to get the windows codepage since it's not a
8845 2002-09-08 Miguel de Icaza <miguel@ximian.com>
8847 * statement.cs (For.Emit): for infinite loops (test == null)
8848 return whether there is a break inside, not always "true".
8850 * namespace.cs (UsingEntry): New struct to hold the name of the
8851 using definition, the location where it is defined, and whether it
8852 has been used in a successful type lookup.
8854 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
8859 2002-09-06 Ravi Pratap <ravi@ximian.com>
8861 * attribute.cs : Fix incorrect code which relied on catching
8862 a NullReferenceException to detect a null being passed in
8863 where an object was expected.
8865 2002-09-06 Miguel de Icaza <miguel@ximian.com>
8867 * statement.cs (Try): flag the catch variable as assigned
8869 * expression.cs (Cast): Simplified by using ResolveType instead of
8872 * statement.cs (Catch): Fix bug by using ResolveType.
8874 2002-09-06 Ravi Pratap <ravi@ximian.com>
8876 * expression.cs (BetterConversion): Special case for when we have
8877 a NullLiteral as the argument and we have to choose between string
8878 and object types - we choose string the way csc does.
8880 * attribute.cs (Attribute.Resolve): Catch the
8881 NullReferenceException and report error #182 since the Mono
8882 runtime no more has the bug and having this exception raised means
8883 we tried to select a constructor which takes an object and is
8886 2002-09-05 Ravi Pratap <ravi@ximian.com>
8888 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
8889 message (1502, 1503) when we can't locate a method after overload
8890 resolution. This is much more informative and closes the bug
8893 * interface.cs (PopulateMethod): Return if there are no argument
8894 types. Fixes a NullReferenceException bug.
8896 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
8897 expressions too. Previously we were checking only in one place for
8898 positional arguments leaving out named arguments.
8900 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
8901 type to the enum type is not allowed. Remove code corresponding to
8904 (ConvertNumericExplicit): Allow explicit conversions from
8905 the underlying type to enum type. This precisely follows the spec
8906 and closes a bug filed by Gonzalo.
8908 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8911 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
8913 2002-09-03 Miguel de Icaza <miguel@ximian.com>
8915 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
8916 it was important that we stored the right value after the
8917 reduction in `converted'.
8919 2002-09-04 Martin Baulig <martin@gnome.org>
8921 * location.cs (Location.SymbolDocument): Use full pathnames for the
8924 2002-08-30 Miguel de Icaza <miguel@ximian.com>
8926 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
8927 of the expression resolve mechanism, because that will catch the
8928 SimpleName error failures.
8930 (Conditional): If we can not resolve the
8931 expression, return, do not crash.
8933 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8936 (location): display token name instead of its number.
8938 2002-08-28 Martin Baulig <martin@gnome.org>
8940 * expression.cs (Binary.ResolveOperator): Don't silently return
8941 but return an error if an operator cannot be applied between two
8944 2002-08-28 Martin Baulig <martin@gnome.org>
8946 * class.cs (Constructor.Define): Set the permission attributes
8947 correctly instead of making all constructors public.
8949 2002-08-28 Martin Baulig <martin@gnome.org>
8951 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
8952 for private members before reporting a CS0103; if we find anything,
8955 2002-08-28 Martin Baulig <martin@gnome.org>
8957 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
8958 to check whether `closure_start_type == closure_invocation_type',
8959 we also need to check whether `m.DeclaringType == closure_invocation_type'
8960 before bypassing the permission checks. We might be accessing
8961 protected/private members from the base class.
8962 (TypeManager.RealMemberLookup): Only set private_ok if private
8963 members were requested via BindingFlags.NonPublic.
8965 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
8967 * expression.cs (MemberAccess.ResolveMemberAccess): Set
8968 MethodGroupExpr.IsExplicitImpl if appropriate.
8969 (Invocation.DoResolve): Don't report the CS0120 for explicit
8970 interface implementations.
8972 2002-08-27 Martin Baulig <martin@gnome.org>
8974 * expression.cs (Invocation.DoResolve): If this is a static
8975 method and we don't have an InstanceExpression, we must report
8978 2002-08-25 Martin Baulig <martin@gnome.org>
8980 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
8981 `==' between a valuetype and an object.
8983 2002-08-25 Miguel de Icaza <miguel@ximian.com>
8985 * ecore.cs (TypeExpr): Provide a ToString method.
8987 2002-08-24 Martin Baulig <martin@gnome.org>
8989 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
8990 now called proggie.dbg and it's a binary file.
8992 2002-08-23 Martin Baulig <martin@gnome.org>
8994 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
8996 2002-08-23 Martin Baulig <martin@gnome.org>
8998 * struct.cs (MyStructInfo.ctor): Make this work with empty
8999 structs; it's not allowed to use foreach() on null.
9001 2002-08-23 Martin Baulig <martin@gnome.org>
9003 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9004 writer the full pathname of the generated assembly.
9006 2002-08-23 Martin Baulig <martin@gnome.org>
9008 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9009 A `finally' block never returns or breaks; improved handling of
9012 2002-08-23 Martin Baulig <martin@gnome.org>
9014 * statement.cs (Throw.Resolve): Allow `throw null'.
9016 2002-08-23 Martin Baulig <martin@gnome.org>
9018 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9019 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9020 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9021 MemberLookup would return a wrong event if this is an explicit
9022 interface implementation and the class has an event with the same
9025 2002-08-23 Martin Baulig <martin@gnome.org>
9027 * statement.cs (Block.AddChildVariableNames): New public method.
9028 (Block.AddChildVariableName): Likewise.
9029 (Block.IsVariableNameUsedInChildBlock): Likewise.
9030 (Block.AddVariable): Check whether a variable name has already
9031 been used in a child block.
9033 * cs-parser.jay (declare_local_variables): Mark all variable names
9034 from the current block as being used in a child block in the
9037 2002-08-23 Martin Baulig <martin@gnome.org>
9039 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9040 find the symbol writer.
9042 * driver.cs: csc also allows the arguments to /define being
9043 separated by commas, not only by semicolons.
9045 2002-08-23 Martin Baulig <martin@gnome.org>
9047 * interface.cs (Interface.GetMembers): Added static check for events.
9049 2002-08-15 Martin Baulig <martin@gnome.org>
9051 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9052 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9054 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9055 why the MethodData.EmitDestructor() change was necessary.
9057 2002-08-20 Martin Baulig <martin@gnome.org>
9059 * class.cs (TypeContainer.FindMembers): Added static check for events.
9061 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9063 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9064 use Type.GetEvents(), not Type.FindMembers().
9066 2002-08-20 Martin Baulig <martin@gnome.org>
9068 * decl.cs (MemberCache): Added a special method cache which will
9069 be used for method-only searched. This ensures that a method
9070 search will return a MethodInfo with the correct ReflectedType for
9073 2002-08-20 Martin Baulig <martin@gnome.org>
9075 * decl.cs (DeclSpace.FindMembers): Made this public.
9077 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9079 * delegate.cs: fixed build on windows.
9080 [FIXME: Filed as bug #29150: MCS must report these errors.]
9082 2002-08-19 Ravi Pratap <ravi@ximian.com>
9084 * ecore.cs (StandardConversionExists): Return a false
9085 if we are trying to convert the void type to anything else
9086 since that is not allowed.
9088 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9089 we flag error 70 in the event an event is trying to be accessed
9090 directly from outside the declaring type.
9092 2002-08-20 Martin Baulig <martin@gnome.org>
9094 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9095 MemberCache from typemanager.cs to decl.cs.
9097 2002-08-19 Martin Baulig <martin@gnome.org>
9099 * class.cs (TypeContainer): Implement IMemberContainer.
9100 (TypeContainer.DefineMembers): Create the MemberCache.
9101 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9102 return public members if BindingFlags.Public was given, check
9103 whether members are static.
9105 2002-08-16 Martin Baulig <martin@gnome.org>
9107 * decl.cs (DeclSpace.Define): Splitted this in Define and
9108 DefineMembers. DefineMembers is called first and initializes the
9111 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9112 DefineMembers() on all our DeclSpaces.
9114 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9115 but call DefineMembers() on all nested interfaces. We call their
9116 Define() in our new Define() function.
9118 * interface.cs (Interface): Implement IMemberContainer.
9119 (Interface.Define): Moved all code except the attribute stuf to
9121 (Interface.DefineMembers): Initialize the member cache.
9123 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9124 need this anymore since we can use MemberCache.FindMembers directly.
9126 2002-08-19 Martin Baulig <martin@gnome.org>
9128 * typemanager.cs (MemberCache): When creating the cache for an
9129 interface type, add all inherited members.
9130 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9131 to `out bool used_cache' and documented it.
9132 (TypeManager.MemberLookup): If we already used the cache in the first
9133 iteration, we don't need to do the interfaces check.
9135 2002-08-19 Martin Baulig <martin@gnome.org>
9137 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9138 here from IMemberFinder and don't implement this interface anymore.
9139 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9141 * typemanager.cs (IMemberFinder): This interface is now only used by
9142 classes which actually support the member cache.
9143 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9144 since we only put DeclSpaces into this Hashtable.
9145 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9146 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9148 2002-08-16 Martin Baulig <martin@gnome.org>
9150 * typemanager.cs (ICachingMemberFinder): Removed.
9151 (IMemberFinder.MemberCache): New property.
9152 (TypeManager.FindMembers): Merged this with RealFindMembers().
9153 This function will never be called from TypeManager.MemberLookup()
9154 so we can't use the cache here, just the IMemberFinder.
9155 (TypeManager.MemberLookup_FindMembers): Check whether the
9156 IMemberFinder has a MemberCache and call the cache's FindMembers
9158 (MemberCache): Rewrote larger parts of this yet another time and
9159 cleaned it up a bit.
9161 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9163 * driver.cs (LoadArgs): Support quoting.
9165 (Usage): Show the CSC-like command line arguments.
9167 Improved a few error messages.
9169 2002-08-15 Martin Baulig <martin@gnome.org>
9171 * typemanager.cs (IMemberContainer.Type): New property.
9172 (IMemberContainer.IsInterface): New property.
9174 The following changes are conditional to BROKEN_RUNTIME, which is
9175 defined at the top of the file.
9177 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9178 class'es members, but add all members from TypeHandle.ObjectType
9179 if we're an interface.
9180 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9181 is the current type.
9182 (MemberCache.CacheEntry.Container): Removed this field.
9183 (TypeHandle.GetMembers): Include inherited members.
9185 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9187 * typemanager.cs: fixed compilation and added a comment on a field that
9190 2002-08-15 Martin Baulig <martin@gnome.org>
9192 * class.cs (ConstructorInitializer.Resolve): In the
9193 Expression.MemberLookup call, use the queried_type as
9196 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9197 declared' attribute, it's always true.
9198 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9199 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9200 temporary wrapper for FindMembers which tells MemberLookup whether
9201 members from the base classes are included in the return value.
9202 This will go away soon.
9203 (TypeManager.MemberLookup): Use this temporary hack here; once the
9204 new MemberCache is completed, we don't need to do the DeclaredOnly
9205 looping here anymore since the MemberCache will take care of this.
9206 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9207 (MemberCache): When creating the MemberCache for a class, get
9208 members from the current class and all its base classes.
9209 (MemberCache.CacheEntry.Container): New field. This is a
9210 temporary hack until the Mono runtime is fixed to distinguish
9211 between ReflectedType and DeclaringType. It allows us to use MCS
9212 with both the MS runtime and the unfixed Mono runtime without
9213 problems and without accecting performance.
9214 (MemberCache.SearchMembers): The DeclaredOnly looping from
9215 TypeManager.MemberLookup is now done here.
9217 2002-08-14 Martin Baulig <martin@gnome.org>
9219 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9220 Type.GetFields on dynamic types but get the fields from the
9221 corresponding TypeContainer.
9222 (MyStructInfo.GetStructInfo): Added check for enum types.
9224 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9225 (MemberList.SyncRoot): Implemented.
9226 (TypeManager.FilterWithClosure): No need to check permissions if
9227 closure_start_type == closure_invocation_type, don't crash if
9228 closure_invocation_type is null.
9230 2002-08-13 Martin Baulig <martin@gnome.org>
9232 Rewrote TypeContainer.FindMembers to use a member cache. This
9233 gives us a speed increase of about 35% for the self-hosting MCS
9234 build and of about 15-20% for the class libs (both on GNU/Linux).
9236 * report.cs (Timer): New class to get enhanced profiling. This
9237 whole class is "TIMER" conditional since it remarkably slows down
9240 * class.cs (MemberList): New class. This is an IList wrapper
9241 which we're now using instead of passing MemberInfo[]'s around to
9242 avoid copying this array unnecessarily.
9243 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9244 (ICachingMemberFinder, IMemberContainer): New interface.
9245 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9246 has already been checked, otherwise use it for the name comparision.
9247 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9248 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9249 if possible. Returns a MemberList, not a MemberInfo [].
9250 (TypeHandle): New class, implements IMemberContainer. We create
9251 one instance of this class per type, it contains a MemberCache
9252 which is used to do the member lookups.
9253 (MemberCache): New class. Each instance of this class contains
9254 all members of a type and a name-based hash table.
9255 (MemberCache.FindMembers): This is our new member lookup
9256 function. First, it looks up all members of the requested name in
9257 the hash table. Then, it walks this list and sorts out all
9258 applicable members and returns them.
9260 2002-08-13 Martin Baulig <martin@gnome.org>
9262 In addition to a nice code cleanup, this gives us a performance
9263 increase of about 1.4% on GNU/Linux - not much, but it's already
9264 half a second for the self-hosting MCS compilation.
9266 * typemanager.cs (IMemberFinder): New interface. It is used by
9267 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9268 Enum, Delegate or Interface.
9269 (TypeManager.finder_to_member_finder): New PtrHashtable.
9270 (TypeManager.finder_to_container): Removed.
9271 (TypeManager.finder_to_delegate): Removed.
9272 (TypeManager.finder_to_interface): Removed.
9273 (TypeManager.finder_to_enum): Removed.
9275 * interface.cs (Interface): Implement IMemberFinder.
9277 * delegate.cs (Delegate): Implement IMemberFinder.
9279 * enum.cs (Enum): Implement IMemberFinder.
9281 * class.cs (TypeContainer): Implement IMemberFinder.
9283 2002-08-12 Martin Baulig <martin@gnome.org>
9285 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9287 2002-08-12 Martin Baulig <martin@gnome.org>
9289 * ecore.cs (ITypeExpression): New interface for expressions which
9291 (TypeExpression): Renamed to TypeLookupExpression.
9292 (Expression.DoResolve): If we're doing a types-only lookup, the
9293 expression must implement the ITypeExpression interface and we
9294 call DoResolveType() on it.
9295 (SimpleName): Implement the new ITypeExpression interface.
9296 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9297 hack, the situation that we're only looking up types can't happen
9298 anymore when this method is called. Moved the type lookup code to
9299 DoResolveType() and call it.
9300 (SimpleName.DoResolveType): This ITypeExpression interface method
9301 is now doing the types-only lookup.
9302 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9303 (ResolveFlags): Added MaskExprClass.
9305 * expression.cs (MemberAccess): Implement the ITypeExpression
9307 (MemberAccess.DoResolve): Added support for a types-only lookup
9308 when we're called via ITypeExpression.DoResolveType().
9309 (ComposedCast): Implement the ITypeExpression interface.
9311 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9312 Expression.Resolve() with ResolveFlags.Type instead.
9314 2002-08-12 Martin Baulig <martin@gnome.org>
9316 * interface.cs (Interface.Define): Apply attributes.
9318 * attribute.cs (Attribute.ApplyAttributes): Added support for
9319 interface attributes.
9321 2002-08-11 Martin Baulig <martin@gnome.org>
9323 * statement.cs (Block.Emit): Only check the "this" variable if we
9324 do not always throw an exception.
9326 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9327 whether the property has a set accessor.
9329 2002-08-11 Martin Baulig <martin@gnome.org>
9331 Added control flow analysis support for structs.
9333 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9334 with control flow analysis turned off.
9335 (IVariable): New interface.
9336 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9337 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9338 (FieldExpr.DoResolve): Resolve the instance expression with flow
9339 analysis turned off and do the definite assignment check after the
9340 resolving when we know what the expression will resolve to.
9342 * expression.cs (LocalVariableReference, ParameterReference):
9343 Implement the new IVariable interface, only call the flow analysis
9344 code if ec.DoFlowAnalysis is true.
9345 (This): Added constructor which takes a Block argument. Implement
9346 the new IVariable interface.
9347 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9348 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9349 This does the definite assignment checks for struct members.
9351 * class.cs (Constructor.Emit): If this is a non-static `struct'
9352 constructor which doesn't have any initializer, call
9353 Block.AddThisVariable() to tell the flow analysis code that all
9354 struct elements must be initialized before control returns from
9357 * statement.cs (MyStructInfo): New public class.
9358 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9359 argument to this indexer. If non-zero, check an individual struct
9360 member, not the whole struct.
9361 (FlowBranching.CheckOutParameters): Check struct members.
9362 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9363 overloaded versions of these methods which take an additional
9364 `int field_idx' argument to check struct members.
9365 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9366 overloaded versions of these methods which take an additional
9367 `string field_name' argument to check struct member.s
9368 (VariableInfo): Implement the IVariable interface.
9369 (VariableInfo.StructInfo): New public property. Returns the
9370 MyStructInfo instance of the variable if it's a struct or null.
9371 (Block.AddThisVariable): New public method. This is called from
9372 Constructor.Emit() for non-static `struct' constructor which do
9373 not have any initializer. It creates a special variable for the
9374 "this" instance variable which will be checked by the flow
9375 analysis code to ensure that all of the struct's fields are
9376 initialized before control returns from the constructor.
9377 (UsageVector): Added support for struct members. If a
9378 variable/parameter is a struct with N members, we reserve a slot
9379 in the usage vector for each member. A struct is considered fully
9380 initialized if either the struct itself (slot 0) or all its
9381 members are initialized.
9383 2002-08-08 Martin Baulig <martin@gnome.org>
9385 * driver.cs (Driver.MainDriver): Only report an error CS5001
9386 if there were no compilation errors.
9388 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9389 `UnsafeContext' property to determine whether the parent is in
9390 unsafe context rather than checking the parent's ModFlags:
9391 classes nested in an unsafe class are unsafe as well.
9393 2002-08-08 Martin Baulig <martin@gnome.org>
9395 * statement.cs (UsageVector.MergeChildren): Distinguish between
9396 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9397 we return. Added test17() and test18() to test-154.cs.
9399 2002-08-08 Martin Baulig <martin@gnome.org>
9401 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9402 Family access, make sure the invoking type isn't a subclass of the
9403 queried type (that'd be a CS1540).
9405 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9406 this method which takes an additional `Type invocation_type'.
9408 * expression.cs (BaseAccess.DoResolve): Use the base type as
9409 invocation and query type.
9410 (MemberAccess.DoResolve): If the lookup failed and we're about to
9411 report a CS0122, try a lookup with the ec.ContainerType - if this
9412 succeeds, we must report a CS1540.
9414 2002-08-08 Martin Baulig <martin@gnome.org>
9416 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9417 (MethodGroupExpr): Implement the IMemberExpr interface.
9419 * expression (MemberAccess.ResolveMemberAccess): No need to have
9420 any special code for MethodGroupExprs anymore, they're now
9423 2002-08-08 Martin Baulig <martin@gnome.org>
9425 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9426 Family, FamANDAssem and FamORAssem permissions.
9427 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9429 2002-08-08 Martin Baulig <martin@gnome.org>
9431 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9432 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9435 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9437 * driver.cs: implemented /resource option to embed managed resources.
9439 2002-08-07 Martin Baulig <martin@gnome.org>
9441 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9442 (FieldBase.HasFieldInitializer): New public property.
9443 (FieldBase.GetInitializerExpression): New public method. Resolves and
9444 returns the field initializer and makes sure it is only resolved once.
9445 (TypeContainer.EmitFieldInitializers): Call
9446 FieldBase.GetInitializerExpression to get the initializer, this ensures
9447 that it isn't resolved multiple times.
9449 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9450 the resolving process (SimpleName/MemberLookup) that we're currently
9451 emitting a field initializer (which must not access any instance members,
9452 this is an error CS0236).
9454 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9455 argument, if the `IsFieldInitializer' flag is set, we must report and
9456 error CS0236 and not an error CS0120.
9458 2002-08-07 Martin Baulig <martin@gnome.org>
9460 * ecore.cs (IMemberExpr): New public interface.
9461 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9462 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9463 if the expression is an IMemberExpr.
9465 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9466 to be null, implicitly default to `this' if we're non-static in
9467 this case. Simplified the code a lot by using the new IMemberExpr
9468 interface. Also fixed bug #28176 here.
9470 2002-08-06 Martin Baulig <martin@gnome.org>
9472 * cs-parser.jay (SimpleLookup): Removed. We need to create
9473 ParameterReferences during semantic analysis so that we can do a
9474 type-only search when resolving Cast, TypeOf and SizeOf.
9475 (block): Pass the `current_local_parameters' to the Block's
9478 * class.cs (ConstructorInitializer): Added `Parameters parameters'
9479 argument to the constructor.
9480 (ConstructorInitializer.Resolve): Create a temporary implicit
9481 block with the parameters.
9483 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
9484 references here if we aren't doing a type-only search.
9486 * statement.cs (Block): Added constructor which takes a
9487 `Parameters parameters' argument.
9488 (Block.Parameters): New public property.
9490 * support.cs (InternalParameters.Parameters): Renamed `parameters'
9491 to `Parameters' and made it public readonly.
9493 2002-08-06 Martin Baulig <martin@gnome.org>
9495 * ecore.cs (Expression.Warning): Made this public as well.
9497 * report.cs (Report.Debug): Print the contents of collections.
9499 2002-08-06 Martin Baulig <martin@gnome.org>
9501 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9502 used to tell Resolve() which kinds of expressions it may return.
9503 (Expression.Resolve): Added overloaded version of this method which
9504 takes a `ResolveFlags flags' argument. This can be used to tell
9505 Resolve() which kinds of expressions it may return. Reports a
9507 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9508 ResolveFlags.SimpleName.
9509 (Expression.Error118): Added overloaded version of this method which
9510 takes a `ResolveFlags flags' argument. It uses the flags to determine
9511 which kinds of expressions are allowed.
9513 * expression.cs (Argument.ResolveMethodGroup): New public method.
9514 Resolves an argument, but allows a MethodGroup to be returned.
9515 This is used when invoking a delegate.
9517 * TODO: Updated a bit.
9519 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9521 Fixed compilation with csc.
9523 * ecore.cs: Expression.Error made public. Is this correct? Should
9524 Warning be made public too?
9526 * expression.cs: use ea.Location instead of ea.loc.
9527 [FIXME: Filed as bug #28607: MCS must report these errors.]
9529 2002-08-06 Martin Baulig <martin@gnome.org>
9531 * ecore.cs (Expression.loc): Moved the location here instead of
9532 duplicating it in all derived classes.
9533 (Expression.Location): New public property.
9534 (Expression.Error, Expression.Warning): Made them non-static and
9535 removed the location argument.
9536 (Expression.Warning): Added overloaded version which takes an
9537 `int level' argument.
9538 (Expression.Error118): Make this non-static and removed the
9539 expression and location arguments.
9540 (TypeExpr): Added location argument to the constructor.
9542 * expression.cs (StaticCallExpr): Added location argument to
9544 (Indirection, PointerArithmetic): Likewise.
9545 (CheckedExpr, UnCheckedExpr): Likewise.
9546 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
9547 (StringPtr): Likewise.
9550 2002-08-05 Martin Baulig <martin@gnome.org>
9552 * expression.cs (BaseAccess.DoResolve): Actually report errors.
9554 * assign.cs (Assign.DoResolve): Check whether the source
9555 expression is a value or variable.
9557 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
9558 while resolving the corresponding blocks.
9560 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
9561 an error, don't silently return null.
9563 * statement.cs (Block.AddVariable): Do the error reporting here
9564 and distinguish between CS0128 and CS0136.
9565 (Block.DoResolve): Report all unused labels (warning CS0164).
9566 (LabeledStatement): Pass the location to the constructor.
9567 (LabeledStatement.HasBeenReferenced): New property.
9568 (LabeledStatement.Resolve): Set it to true here.
9570 * statement.cs (Return.Emit): Return success even after reporting
9571 a type mismatch error (CS0126 or CS0127), this is what csc does and
9572 it avoids confusing the users with any consecutive errors.
9574 2002-08-05 Martin Baulig <martin@gnome.org>
9576 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
9578 * const.cs (Const.LookupConstantValue): Catch circular definitions.
9580 * expression.cs (MemberAccess.DoResolve): Silently return if an
9581 error has already been reported.
9583 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
9584 error has already been reported.
9586 2002-08-05 Martin Baulig <martin@gnome.org>
9588 * statement.cs (UsageVector): Only initialize the `parameters'
9589 vector if we actually have any "out" parameters.
9591 2002-08-05 Martin Baulig <martin@gnome.org>
9593 * expression.cs (Binary.ResolveOperator): When combining delegates,
9594 they must have the same type.
9596 2002-08-05 Martin Baulig <martin@gnome.org>
9598 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
9599 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
9600 work with the ms runtime and we also don't need it: if we're a
9601 PropertyBuilder and not in the `indexer_arguments' hash, then we
9602 are a property and not an indexer.
9604 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
9605 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
9606 since the latter one doesn't work with the ms runtime.
9608 2002-08-03 Martin Baulig <martin@gnome.org>
9610 Fixed bugs #27998 and #22735.
9612 * class.cs (Method.IsOperator): New public field.
9613 (Method.CheckBase): Report CS0111 if there's already a method
9614 with the same parameters in the current class. Report CS0508 when
9615 attempting to change the return type of an inherited method.
9616 (MethodData.Emit): Report CS0179 if a method doesn't have a body
9617 and it's not marked abstract or extern.
9618 (PropertyBase): New abstract base class for Property and Indexer.
9619 (PropertyBase.CheckBase): Moved here from Property and made it work
9621 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
9622 the same so we can reuse it there.
9623 (Property, Indexer): Derive from PropertyBase.
9624 (MethodSignature.inheritable_property_signature_filter): New delegate
9625 to find properties and indexers.
9627 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
9628 argument and improved error reporting.
9630 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
9631 EmptyReadOnlyParameters and made it a property.
9633 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
9634 version of this method which takes a `PropertyInfo indexer'.
9635 (TypeManager.RegisterIndexer): New method.
9637 * class.cs: Added myself as author of this file :-)
9639 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9641 * class.cs: fixed compilation on windoze.
9643 2002-08-03 Martin Baulig <martin@gnome.org>
9645 * interface.cs (Interface.GetInterfaceBases): Check whether all
9646 base interfaces are at least as accessible than the current one.
9648 * class.cs (TypeContainer.GetClassBases): Check whether base types
9649 are at least as accessible than the current type.
9650 (TypeContainer.AsAccessible): Implemented and made non-static.
9651 (MemberBase.CheckParameters): Report errors if the accessibility
9654 * delegate.cs (Delegate.Delegate): The default visibility is
9655 internal for top-level types and private for nested types.
9656 (Delegate.Define): Report errors if the accessibility checks fail.
9658 * enum.cs (Enum.Enum): The default visibility is internal for
9659 top-level types and private for nested types.
9660 (Enum.DefineType): Compute the correct visibility.
9662 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
9663 function which takes a `bool is_toplevel' instead of a TypeContainer.
9665 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
9668 2002-08-02 Martin Baulig <martin@gnome.org>
9670 * expression.cs (LocalVariableReferenc): Added constructor which
9671 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
9672 (LocalVariableReference.IsReadOnly): New property.
9673 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
9674 variable is readonly, use our own readonly flag to do this; you can
9675 use the new constructor to get a writable reference to a read-only
9678 * cs-parser.jay (foreach_statement, using_statement): Get a writable
9679 reference to the local variable.
9681 2002-08-01 Miguel de Icaza <miguel@ximian.com>
9683 * rootcontext.cs (ResolveCore): Also include System.Exception
9685 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
9686 we reach an EmptyStatement.
9688 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
9691 * expression.cs (Binary.ResolveOperator): Check error result in
9694 use brtrue/brfalse directly and avoid compares to null.
9696 2002-08-02 Martin Baulig <martin@gnome.org>
9698 * class.cs (TypeContainer.Define): Define all nested interfaces here.
9699 Fixes bug #28407, added test-155.cs.
9701 2002-08-01 Martin Baulig <martin@gnome.org>
9703 * class.cs (Event.EmitDefaultMethod): Make this work with static
9704 events. Fixes #28311, added verify-3.cs.
9706 2002-08-01 Martin Baulig <martin@gnome.org>
9708 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
9709 `is_disposable' fields.
9710 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
9711 `hm.is_disposable' if we're using the collection pattern.
9712 (Foreach.EmitCollectionForeach): Use the correct type for the
9713 enumerator's local variable, only emit the try/finally block if
9714 necessary (fixes #27713).
9716 2002-08-01 Martin Baulig <martin@gnome.org>
9718 * ecore.cs (Expression.report118): Renamed to Error118 and made
9721 * statement.cs (Throw.Resolve): Check whether the expression is of
9722 the correct type (CS0118) and whether the type derives from
9723 System.Exception (CS0155).
9724 (Catch.Resolve): New method. Do the type lookup here and check
9725 whether it derives from System.Exception (CS0155).
9726 (Catch.CatchType, Catch.IsGeneral): New public properties.
9728 * typemanager.cs (TypeManager.exception_type): Added.
9730 2002-07-31 Miguel de Icaza <miguel@ximian.com>
9732 * driver.cs: Updated About function.
9734 2002-07-31 Martin Baulig <martin@gnome.org>
9736 Implemented Control Flow Analysis.
9738 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
9739 (EmitContext.CurrentBranching): Added.
9740 (EmitContext.StartFlowBranching): Added.
9741 (EmitContext.EndFlowBranching): Added.
9742 (EmitContext.KillFlowBranching): Added.
9743 (EmitContext.IsVariableAssigned): Added.
9744 (EmitContext.SetVariableAssigned): Added.
9745 (EmitContext.IsParameterAssigned): Added.
9746 (EmitContext.SetParameterAssigned): Added.
9747 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
9748 Added control flow analysis stuff here.
9750 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
9751 resolve the expression as lvalue.
9752 (LocalVariableReference.DoResolve): Check whether the variable has
9753 already been assigned.
9754 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
9755 the parameter as assigned here.
9756 (ParameterReference.DoResolve): Check whether the parameter has already
9758 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
9759 expression as lvalue.
9761 * statement.cs (FlowBranching): New class for the flow analysis code.
9762 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
9763 (LabeledStatement.IsDefined): New public property.
9764 (LabeledStatement.AddUsageVector): New public method to tell flow
9765 analyis that the label may be reached via a forward jump.
9766 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
9768 (VariableInfo.Number): New public field. This is used by flow analysis
9769 to number all locals of a block.
9770 (Block.CountVariables): New public property. This is the number of
9771 local variables in this block (including the locals from all parent
9773 (Block.EmitMeta): Number all the variables.
9775 * statement.cs: Added flow analysis support to all classes.
9777 2002-07-31 Martin Baulig <martin@gnome.org>
9779 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
9780 To get debugging messages, compile mcs with /define:MCS_DEBUG and
9781 then use this argument.
9783 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
9785 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
9786 use this to specify /define options.
9788 2002-07-29 Martin Baulig <martin@gnome.org>
9790 * statement.cs (Fixed): Moved all code that does variable lookups
9791 and resolvings from Emit to Resolve.
9793 * statement.cs (For): Moved all code that does variable lookups
9794 and resolvings from Emit to Resolve.
9796 * statement.cs (Using): Moved all code that does variable lookups
9797 and resolvings from Emit to Resolve.
9799 2002-07-29 Martin Baulig <martin@gnome.org>
9801 * attribute.cs (Attribute.Resolve): Explicitly catch a
9802 System.NullReferenceException when creating the
9803 CustromAttributeBuilder and report a different warning message.
9805 2002-07-29 Martin Baulig <martin@gnome.org>
9807 * support.cs (ParameterData.ParameterName): Added method to
9808 get the name of a parameter.
9810 * typemanager.cs (TypeManager.IsValueType): New public method.
9812 2002-07-29 Martin Baulig <martin@gnome.org>
9814 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
9815 is a flag which specifies that it's either ref or out.
9816 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
9817 the out parameter to `out Parameter.Modifier mod', also set the
9818 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
9820 * support.cs (InternalParameters.ParameterModifier): Distinguish
9821 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9822 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9824 * expression.cs (Argument.GetParameterModifier): Distinguish
9825 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9826 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9828 2002-07-29 Martin Baulig <martin@gnome.org>
9830 * expression.cs (ParameterReference.ParameterReference): Added
9831 `Location loc' argument to the constructor.
9833 * cs-parser.jay: Pass location to ParameterReference.
9835 2002-07-28 Miguel de Icaza <miguel@ximian.com>
9837 * statement.cs (Try): Initialize the location.
9839 * cs-parser.jay: pass location to Try.
9841 * expression.cs (Unary.Reduce): Change the prototype to return
9842 whether a constant fold could be performed or not. The result is
9843 returned in an out parameters. In the case of Indirection and
9844 AddressOf, we want to perform the full tests.
9846 2002-07-26 Miguel de Icaza <miguel@ximian.com>
9848 * statement.cs (Statement.Emit): Flag dead code.
9850 2002-07-27 Andrew Birkett <andy@nobugs.org>
9852 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
9854 2002-07-27 Martin Baulig <martin@gnome.org>
9856 * class.cs (MethodData.Define): Put back call to
9857 TypeManager.AddMethod(), accidentally commented this out.
9859 * report.cs (Debug): New public method to print debugging information,
9860 this is `[Conditional ("DEBUG")]'.
9862 2002-07-26 Martin Baulig <martin@gnome.org>
9864 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
9865 (switch_statement): Push the current_block to the switch_stack and
9866 pop it again when we're done with the switch.
9867 (switch_section): The new block is a child of the current_block.
9868 Fixes bug #24007, added test-152.cs.
9870 2002-07-27 Martin Baulig <martin@gnome.org>
9872 * expression.cs (Invocation.EmitArguments): When calling a varargs
9873 function with only its fixed arguments, we need to pass an empty
9876 2002-07-27 Martin Baulig <martin@gnome.org>
9878 Mono 0.13 has been released.
9880 2002-07-25 Miguel de Icaza <miguel@ximian.com>
9882 * driver.cs: Rename --resource to --linkres, because that is what
9883 we do currently, we dont support --resource yet.
9885 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
9887 2002-07-25 Martin Baulig <martin@gnome.org>
9889 * class.cs (MethodData): New public class. This is a `method builder'
9890 class for a method or one accessor of a Property/Indexer/Event.
9891 (MethodData.GetMethodFlags): Moved here from MemberBase.
9892 (MethodData.ApplyAttributes): Likewise.
9893 (MethodData.ApplyObsoleteAttribute): Likewise.
9894 (MethodData.ApplyConditionalAttribute): Likewise.
9895 (MethodData.ApplyDllImportAttribute): Likewise.
9896 (MethodData.CheckAbstractAndExternal): Likewise.
9897 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
9898 (MethodData.Emit): Formerly known as Method.Emit().
9899 (MemberBase): Moved everything which was specific to a single
9900 accessor/method to MethodData.
9901 (Method): Create a new MethodData and call Define() and Emit() on it.
9902 (Property, Indexer, Event): Create a new MethodData objects for each
9903 accessor and call Define() and Emit() on them.
9905 2002-07-25 Martin Baulig <martin@gnome.org>
9907 Made MethodCore derive from MemberBase to reuse the code from there.
9908 MemberBase now also checks for attributes.
9910 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
9911 (MemberBase.GetMethodFlags): Moved here from class Method and marked
9913 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
9914 `CallingConventions cc' and `Attributes opt_attrs' arguments.
9915 (MemberBase.ApplyAttributes): New virtual method; applies the
9916 attributes to a method or accessor.
9917 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
9918 (MemberBase.ApplyConditionalAttribute): Likewise.
9919 (MemberBase.ApplyDllImportAttribute): Likewise.
9920 (MemberBase.CheckAbstractAndExternal): Likewise.
9921 (MethodCore.ParameterTypes): This is now a property instead of a
9922 method, it's initialized from DoDefineParameters().
9923 (MethodCore.ParameterInfo): Removed the set accessor.
9924 (MethodCore.DoDefineParameters): New protected virtual method to
9925 initialize ParameterTypes and ParameterInfo.
9926 (Method.GetReturnType): We can now simply return the MemberType.
9927 (Method.GetMethodFlags): Override the MemberBase version and add
9928 the conditional flags.
9929 (Method.CheckBase): Moved some code from Define() here, call
9930 DoDefineParameters() here.
9931 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
9932 here to avoid some larger code duplication.
9933 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
9934 ensure that abstract and external accessors don't declare a body.
9936 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
9937 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
9938 lookup in the attribute's parent classes, so we need to abort as soon
9939 as we found the first match.
9940 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
9941 the attribute has no arguments.
9943 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
9946 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9948 * cs-parser.jay: reverted previous patch.
9950 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9952 * cs-parser.jay: fixed bug #22119.
9954 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9956 * attribute.cs: fixed compilation. The error was:
9957 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
9958 be assigned to before control leaves the current method."
9959 [FIXME: Filed as bug #28186: MCS must report this error.]
9961 2002-07-25 Martin Baulig <martin@gnome.org>
9963 * attribute.cs (Attribute.Conditional_GetConditionName): New static
9964 method to pull the condition name ouf of a Conditional attribute.
9965 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
9966 the obsolete message and error flag out of an Obsolete attribute.
9968 * class.cs (Method.GetMethodFlags): New public method to get the
9969 TypeManager.MethodFlags for this method.
9970 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
9972 (Method.Define): Get and apply the Obsolete and Conditional attributes;
9973 if we're overriding a virtual function, set the new private variable
9974 `parent_method'; call the new TypeManager.AddMethod().
9976 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
9977 the MethodBuilder and the Method in a PtrHashtable.
9978 (TypeManager.builder_to_method): Added for this purpose.
9979 (TypeManager.MethodFlags): Added IsObsoleteError.
9980 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
9981 Obsolete and Conditional arguments in MethodBuilders. If we discover
9982 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
9983 the message from the attribute.
9985 2002-07-24 Martin Baulig <martin@gnome.org>
9987 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
9988 preprocessor directives, ensure that the argument to #define/#undef is
9989 exactly one identifier and that it's actually an identifier.
9991 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
9994 2002-07-24 Martin Baulig <martin@gnome.org>
9996 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
9997 initialize it to TypeManager.object_type in the constructor.
9998 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
9999 of the `hm.get_current' method if we're using the collection pattern.
10000 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10001 for the explicit conversion to make it work when we're using the collection
10002 pattern and the `Current' property has a different return type than `object'.
10005 2002-07-24 Martin Baulig <martin@gnome.org>
10007 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10008 does not match, but don't report any errors. This method is called in
10009 order for all methods in a MethodGroupExpr until a matching method is
10010 found, so we don't want to bail out if the first method doesn't match.
10011 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10012 matches, report the 123. Fixes #28070.
10014 2002-07-24 Martin Baulig <martin@gnome.org>
10016 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10017 TypeManager.TypeToCoreType() to the top of the method so the
10018 following equality checks will work. Fixes #28107.
10020 2002-07-24 Martin Baulig <martin@gnome.org>
10022 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10023 operand is of type uint, and the other operand is of type sbyte,
10024 short or int, the operands are converted to type long." -
10025 Actually do what this comment already told us. Fixes bug #28106,
10028 2002-07-24 Martin Baulig <martin@gnome.org>
10030 * class.cs (MethodBase): New abstract class. This is now a base
10031 class for Property, Indexer and Event to avoid some code duplication
10032 in their Define() and DefineMethods() methods.
10033 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10034 generic methods for Define() and DefineMethods().
10035 (FieldBase): Derive from MemberBase, not MemberCore.
10036 (Property): Derive from MemberBase, not MemberCore.
10037 (Property.DefineMethod): Moved all the code from this method to the
10038 new MethodBase.DefineAccessor(), just call it with appropriate
10040 (Property.Define): Call the new Property.DoDefine(), this does some
10041 sanity checks and we don't need to duplicate the code everywhere.
10042 (Event): Derive from MemberBase, not MemberCore.
10043 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10044 accessors, this will also make them work with interface events.
10045 (Indexer): Derive from MemberBase, not MemberCore.
10046 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10047 (Indexer.Define): Use the new MethodBase functions.
10049 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10050 argument to the constructor.
10051 (Interface.FindMembers): Added support for interface events.
10052 (Interface.PopluateEvent): Implemented.
10054 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10056 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10058 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10059 but this is required to check for a method name being the same as
10060 the containing class.
10064 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10066 * interface.cs: initialize variable.
10068 2002-07-23 Martin Baulig <martin@gnome.org>
10070 Implemented the IndexerName attribute in interfaces.
10072 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10073 name if this is an explicit interface implementation.
10074 (Indexer.InterfaceIndexerName): New public variable. If we're
10075 implementing an interface indexer, this is the IndexerName in that
10076 interface. Otherwise, it's the IndexerName.
10077 (Indexer.DefineMethod): If we're implementing interface indexer,
10078 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10079 and Pending.ImplementIndexer methods.
10080 (Indexer.Define): Also define the PropertyBuilder if we're
10081 implementing an interface indexer and this is neither an explicit
10082 interface implementation nor do the IndexerName match the one in
10085 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10086 If a method is defined here, then we always need to create a proxy
10087 for it. This is used when implementing interface indexers.
10088 (Pending.IsInterfaceIndexer): New public method.
10089 (Pending.ImplementIndexer): New public method.
10090 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10091 This is used when implementing interface indexers to define a proxy
10093 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10094 define a proxy if necessary.
10096 * interface.cs (Interface.IndexerName): New public variable.
10097 (Interface.PopulateIndexer): Set the IndexerName.
10098 (Interface.DefineIndexers): New private method. Populate all the
10099 indexers and make sure their IndexerNames match.
10101 * typemanager.cs (IndexerPropertyName): Added support for interface
10104 2002-07-22 Martin Baulig <martin@gnome.org>
10106 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10107 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10108 ret if HasReturnLabel.
10109 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10112 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10113 and set the ec.LoopBeginTryCatchLevel.
10114 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10115 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10116 the current ec.TryCatchLevel, the branch goes out of an exception
10117 block. In this case, we need to use Leave and not Br.
10119 2002-07-22 Martin Baulig <martin@gnome.org>
10121 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10122 block unless the block does not always return or it is contained in
10123 another try { ... } catch { ... } block. Fixes bug #26506.
10124 Added verify-1.cs to the test suite.
10126 2002-07-22 Martin Baulig <martin@gnome.org>
10128 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10129 then we do not always return. Fixes bug #24985.
10131 2002-07-22 Martin Baulig <martin@gnome.org>
10133 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10134 lookup on a per-class level; ie. walk up the class hierarchy until we
10135 found at least one applicable method, then choose the best among them.
10136 Fixes bug #24463 and test-29.cs.
10138 2002-07-22 Martin Baulig <martin@gnome.org>
10140 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10141 return types of the methods. The return type is not part of the
10142 signature and we must not check it to make the `new' modifier work.
10143 Fixes bug #27999, also added test-147.cs.
10144 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10146 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10147 on the method's return type.
10149 2002-07-21 Martin Baulig <martin@gnome.org>
10151 * assign.cs: Make this work if the rightmost source is a constant and
10152 we need to do an implicit type conversion. Also adding a few more tests
10153 to test-38.cs which should have caught this.
10155 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10156 target in the makefile for this. The makefile.gnu is primarily intended
10157 for end-users who don't want to debug the compiler.
10159 2002-07-21 Martin Baulig <martin@gnome.org>
10161 * assign.cs: Improved the Assign class so it can now handle embedded
10162 assignments (X = Y = Z = something). As a side-effect this'll now also
10163 consume less local variables. test-38.cs now passes with MCS, added
10164 a few new test cases to that test.
10166 2002-07-20 Martin Baulig <martin@gnome.org>
10168 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10169 instructions. Fixes bug #27977, also added test-146.cs.
10171 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10173 * cs-tokenizer.cs: fixed getHex ().
10175 2002-07-19 Martin Baulig <martin@gnome.org>
10177 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10178 not Type.GetType() to lookup the array type. This is needed when
10179 we're constructing an array of a user-defined type.
10180 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10181 single-dimensional arrays, but also for single-dimensial arrays of
10184 2002-07-19 Martin Baulig <martin@gnome.org>
10186 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10187 this function is called, it's not allowed to share LocalBuilders
10188 among ILGenerators.
10190 2002-07-19 Martin Baulig <martin@gnome.org>
10192 * expression.cs (Argument.Resolve): Report an error 118 when trying
10193 to pass a type as argument.
10195 2002-07-18 Martin Baulig <martin@gnome.org>
10197 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10198 Conv_R_Un for the signed `long' type.
10200 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10202 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10203 `expr' for the temporary result, as that will fail if we do
10204 multiple resolves on the same expression.
10206 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10208 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10209 ec.TypeContainer for looking up aliases.
10211 * class.cs (TypeContainer): Remove LookupAlias from here.
10213 * decl.cs (DeclSpace); Move here.
10215 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10217 * class.cs (FindMembers): Only call filter if the constructor
10218 bulider is not null.
10220 Also handle delegates in `NestedTypes' now. Now we will perform
10221 type lookups using the standard resolution process. This also
10224 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10225 This uses Expressions (the limited kind that can be parsed by the
10226 tree) instead of strings.
10228 * expression.cs (ComposedCast.ToString): Implement, used to flag
10229 errors since now we have to render expressions.
10231 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10234 * ecore.cs (SimpleName.ToString): ditto.
10236 * cs-parser.jay: Instead of using strings to assemble types, use
10237 Expressions to assemble the type (using SimpleName, ComposedCast,
10238 MemberAccess). This should fix the type lookups in declarations,
10239 because we were using a different code path for this.
10241 * statement.cs (Block.Resolve): Continue processing statements
10242 even when there is an error.
10244 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10246 * class.cs (Event.Define): Also remove the `remove' method from
10247 the list of pending items.
10249 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10250 generate more compact code.
10252 2002-07-17 Martin Baulig <martin@gnome.org>
10254 * const.cs (Const.LookupConstantValue): Add support for constant
10255 `unchecked' and `checked' expressions.
10256 Also adding test case test-140.cs for this.
10258 2002-07-17 Martin Baulig <martin@gnome.org>
10260 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10261 check whether mi.ReturnType implements the IEnumerator interface; the
10262 `==' and the IsAssignableFrom() will fail in this situation.
10264 2002-07-16 Ravi Pratap <ravi@ximian.com>
10266 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10269 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10271 * expression.cs: fixed bug #27811.
10273 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10275 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10276 Molaro: when we are a ref, the value already contains a pointer
10277 value, do not take the address of it.
10279 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10280 * removed mb-parser.jay and mb-tokenizer.cs
10282 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10284 * expression.cs: check against the building corlib void type.
10286 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10288 * ecore.cs: fix for valuetype static readonly fields: when
10289 initializing them, we need their address, not the address of a copy.
10291 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10293 * typemanager.cs: register also enum_type in corlib.
10295 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10297 * class.cs: allow calling this (but not base) initializers in structs.
10299 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10301 * ecore.cs: make sure we compare against the building base types
10304 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10306 * typemanager.cs: fix TypeToCoreType() to handle void and object
10307 (corlib gets no more typerefs after this change).
10309 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10311 * expression.cs (ArrayCreation.EmitArrayArguments): use
10312 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10314 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10315 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10316 array indexes, the runtime actually forbids them.
10318 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10319 for array arguments here.
10321 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10322 instead of the default for ValueTypes.
10324 (New.DoEmit): Use IsValueType instead of
10325 IsSubclassOf (value_type)
10326 (New.DoResolve): ditto.
10327 (Invocation.EmitCall): ditto.
10329 * assign.cs (Assign): ditto.
10331 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10332 Statements *are* currently doing part of their resolution during
10335 Expressions do always resolve during resolve, but statements are
10336 only required to propagate resolution to their children.
10338 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10340 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10342 (LoadAssembly): Do not add the dll if it is already specified
10344 (MainDriver): Add the System directory to the link path at the end,
10345 after all the other -L arguments.
10347 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10348 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10349 ldelem.u1) and using the opposite for sbytes.
10351 This fixes Digger, and we can finally run it.
10353 * driver.cs (UnixParseOption): Move the option parsing here.
10354 (CSCParseOption): Implement CSC-like parsing of options.
10356 We now support both modes of operation, the old Unix way, and the
10357 new CSC-like way. This should help those who wanted to make cross
10358 platform makefiles.
10360 The only thing broken is that /r:, /reference: and /lib: are not
10361 implemented, because I want to make those have the same semantics
10362 as the CSC compiler has, and kill once and for all the confussion
10363 around this. Will be doing this tomorrow.
10365 * statement.cs (Unsafe.Resolve): The state is checked during
10366 resolve, not emit, so we have to set the flags for IsUnsfe here.
10368 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10370 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10371 not catch the Error_ObjectRefRequired in SimpleName (as it is
10372 possible to have a class/instance variable name that later gets
10373 deambiguated), we have to check this here.
10375 2002-07-10 Ravi Pratap <ravi@ximian.com>
10377 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10378 make static and put into Expression.
10380 (Event.Define): Register the private field of the event with the
10381 TypeManager so that GetFieldFromEvent can get at it.
10383 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10384 keep track of the private field associated with an event which
10387 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10390 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10392 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10394 * expression.cs (Binary.EmitBranchable): this routine emits the
10395 Binary expression in a branchable context. This basically means:
10396 we need to branch somewhere, not just get the value on the stack.
10398 This works together with Statement.EmitBoolExpression.
10400 * statement.cs (Statement.EmitBoolExpression): Use
10403 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10405 * statement.cs (For): Reduce the number of jumps in loops.
10407 (For): Implement loop inversion for the For statement.
10409 (Break): We can be breaking out of a Try/Catch controlled section
10410 (foreach might have an implicit try/catch clause), so we need to
10411 use Leave instead of Br.
10413 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10414 now). If the instace expression supports IMemoryLocation, we use
10415 the AddressOf method from the IMemoryLocation to extract the
10416 address instead of emitting the instance.
10418 This showed up with `This', as we were emitting the instance
10419 always (Emit) instead of the Address of This. Particularly
10420 interesting when This is a value type, as we dont want the Emit
10421 effect (which was to load the object).
10423 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10425 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10427 * statement.cs (Checked): Set the CheckedState during the resolve
10428 process too, as the ConvCast operations track the checked state on
10429 the resolve process, and not emit.
10431 * cs-parser.jay (namespace_member_declaration): Flag that we have
10432 found a declaration when we do. This is used to flag error 1529
10434 * driver.cs: Report ok when we display the help only.
10436 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10438 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10440 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10442 * cs-tokenizer.cs (define): We also have to track locally the
10443 defines. AllDefines is just used for the Conditional Attribute,
10444 but we also need the local defines for the current source code.
10446 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10448 * statement.cs (While, For, Do): These loops can exit through a
10449 Break statement, use this information to tell whether the
10450 statement is the last piece of code.
10452 (Break): Flag that we break.
10454 * codegen.cs (EmitContexts): New `Breaks' state variable.
10456 2002-07-03 Martin Baulig <martin@gnome.org>
10458 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10459 modifiers in method declarations in structs. Otherwise, you won't
10460 be able to override things like Object.Equals().
10462 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10464 * class.cs (Method, Property, Indexer): Do not allow the public
10465 modifier to be used in explicit interface implementations.
10467 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10468 override modifiers in method declarations in structs
10470 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10472 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10473 integer or real overflow, report an error
10475 2002-07-02 Martin Baulig <martin@gnome.org>
10477 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
10478 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
10479 to tell the runtime about our newly created System.Object and
10480 System.ValueType types.
10482 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10484 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
10485 struct instead of Ldarg/Starg.
10487 2002-07-02 Martin Baulig <martin@gnome.org>
10489 * expression.cs (Indirection.Indirection): Call
10490 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
10492 2002-07-02 Martin Baulig <martin@gnome.org>
10494 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10495 ValueType, call TypeManager.TypeToCoreType() on it.
10496 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10497 the OpCodes.Newarr argument.
10499 2002-07-02 Martin Baulig <martin@gnome.org>
10501 * expression.cs (Invocation.EmitCall): When compiling corlib,
10502 replace all calls to the system's System.Array type to calls to
10503 the newly created one.
10505 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10506 System.Array methods.
10507 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10508 from the system's System.Array type which must be replaced.
10510 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10512 * typemanager.cs: load unverifiable_code_ctor so we can build
10513 corlib using the correct type. Avoid using GetTypeCode() with
10515 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10516 TypeManager.object_type to allow building corlib.
10518 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10520 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10522 2002-07-01 Martin Baulig <martin@gnome.org>
10524 * class.cs: Make the last change actually work, we need to check
10525 whether `ifaces != null' to avoid a crash.
10527 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10529 * class.cs: when we build structs without fields that implement
10530 interfaces, we need to add the interfaces separately, since there is
10531 no API to both set the size and add the interfaces at type creation
10534 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10536 * expression.cs: the dimension arguments to the array constructors
10537 need to be converted if they are a long.
10539 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
10541 * class.cs: don't emit ldarg.0 if there is no parent constructor
10542 (fixes showstopper for corlib).
10544 2002-06-29 Martin Baulig <martin@gnome.org>
10546 MCS now compiles corlib on GNU/Linux :-)
10548 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
10549 ie. check for MethodImplOptions.InternalCall.
10551 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
10552 and TypeManager.attribute_type are null, so we must explicitly check
10553 whether parent is not null to find out whether it's an attribute type.
10554 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
10555 and SetBuilder, not only if the property is neither abstract nor external.
10556 This is necessary to set the MethodImplOptions on the accessor methods.
10557 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
10558 SetBuilder, see Property.Emit().
10560 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
10561 populate "System.Object", "System.ValueType" and "System.Attribute" since
10562 they've already been populated from BootCorlib_PopulateCoreTypes().
10564 2002-06-29 Martin Baulig <martin@gnome.org>
10566 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
10567 is the NullLiteral, we also need to make sure that target_type is not
10570 2002-06-29 Martin Baulig <martin@gnome.org>
10572 * rootcontext.cs (RootContext.ResolveCore): We must initialize
10573 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
10574 before calling BootstrapCorlib_ResolveDelegate ().
10576 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10578 * statement.cs: fixed build-breaker. All tests passed ok.
10580 2002-06-27 Martin Baulig <martin@gnome.org>
10582 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
10583 for System.Decimal when compiling corlib.
10585 2002-06-27 Martin Baulig <martin@gnome.org>
10587 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
10588 switch blocks which contain nothing but a default clause.
10590 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
10592 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
10594 2002-06-27 Martin Baulig <martin@gnome.org>
10596 * ecore.cs (PropertyExpr.PropertyExpr): Call
10597 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
10599 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
10600 is already a TypeBuilder.
10602 2002-06-27 Martin Baulig <martin@gnome.org>
10604 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
10605 `target_type == TypeManager.array_type', not IsAssignableFrom() in
10606 the "from an array-type to System.Array" case. This makes it work
10607 when compiling corlib.
10609 2002-06-27 Martin Baulig <martin@gnome.org>
10611 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
10612 non-static PropertyExpr, set its InstanceExpression. This makes
10613 the `ICollection.Count' property work in System/Array.cs.
10615 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
10617 * driver.cs: Made error handling more consistent. Errors now
10618 tracked by Report class, so many methods which used to return int
10619 now return void. Main() now prints success/failure and
10620 errors/warnings message.
10622 Renamed '--probe' compiler argument to '--expect-error'. Removed
10623 the magic number return values (123 and 124). Now, if the
10624 expected error occurs, the compiler exits with success (exit value
10625 0). If the compilation completes without seeing that particular
10626 error, the compiler exits with failure (exit value 1). The
10627 makefile in mcs/errors has been changed to handle the new behaviour.
10629 * report.cs: Made 'expected error' number a property and renamed
10630 it from 'Probe' to 'ExpectedError'.
10632 * genericparser.cs: Removed error handling support, since it is
10633 now all done by Report class.
10635 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
10636 class, so parse() no longer returns an int.
10638 * namespace.cs: Use Report.Error instead of GenericParser.error
10640 2002-06-22 Miguel de Icaza <miguel@ximian.com>
10642 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
10643 TypeContainer.AddOperator): At the front of the list put the
10644 explicit implementations, so they get resolved/defined first.
10646 2002-06-21 Miguel de Icaza <miguel@ximian.com>
10648 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
10649 interface type is implemented by this TypeContainer. Used during
10650 explicit interface implementation.
10652 (Property.Define, Indexer.Define, Method.Define): Validate that
10653 the given interface in the explicit implementation is one of the
10654 base classes for the containing type.
10656 Also if we are explicitly implementing an interface, but there is
10657 no match in the pending implementation table, report an error.
10659 (Property.Define): Only define the property if we are
10660 not explicitly implementing a property from an interface. Use the
10661 correct name also for those properties (the same CSC uses,
10662 although that is really not needed).
10664 (Property.Emit): Do not emit attributes for explicitly implemented
10665 properties, as there is no TypeBuilder.
10667 (Indexer.Emit): ditto.
10669 Hiding then means that we do not really *implement* a pending
10670 implementation, which makes code fail.
10672 2002-06-22 Martin Baulig <martin@gnome.org>
10674 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
10675 the return value of Object.GetType(). [FIXME: we need to do this whenever
10676 we get a type back from the reflection library].
10678 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
10680 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
10682 2002-06-20 Miguel de Icaza <miguel@ximian.com>
10684 * attribute.cs: Return null if we can not look up the type.
10686 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
10687 the interface types found.
10689 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
10690 interface types found.
10692 * typemanager.cs (GetInterfaces): Make this routine returns alll
10693 the interfaces and work around the lame differences between
10694 System.Type and System.Reflection.Emit.TypeBuilder in the results
10695 result for GetInterfaces.
10697 (ExpandInterfaces): Given an array of interface types, expand and
10698 eliminate repeated ocurrences of an interface. This expands in
10699 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
10702 2002-06-21 Martin Baulig <martin@gnome.org>
10704 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
10707 2002-06-21 Martin Baulig <martin@gnome.org>
10709 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
10710 and called with one of the core types, return the corresponding typebuilder for
10713 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
10716 2002-06-21 Martin Baulig <martin@gnome.org>
10718 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
10719 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
10720 (Expression.ConvertReferenceExplicit): Likewise.
10722 * expression.cs (ElementAccess.DoResolve): Likewise.
10723 (ElementAccess.DoResolveLValue): Likewise.
10725 2002-06-10 Martin Baulig <martin@gnome.org>
10727 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
10728 add the "value" parameter to the parameter list.
10730 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
10733 2002-06-19 Miguel de Icaza <miguel@ximian.com>
10735 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
10736 the argument to an int, uint, long or ulong, per the spec. Also
10737 catch negative constants in array creation.
10739 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
10741 * class.cs: do not allow the same interface to appear twice in
10742 the definition list.
10744 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
10746 * ecore.cs: don't use ldlen with System.Array.
10748 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
10750 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
10752 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
10754 * modifiers.cs: produce correct field attributes for protected
10755 internal. Easy fix so miguel can work on ther harder stuff:-)
10757 2002-06-18 Miguel de Icaza <miguel@ximian.com>
10759 * pending.cs: New file. Move the code from class.cs here.
10760 Support clearning the pending flag for all methods (when not doing
10761 explicit interface implementation).
10763 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
10765 * rootcontext.cs: added a couple more types needed to bootstrap.
10767 2002-06-17 Miguel de Icaza <miguel@ximian.com>
10769 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
10770 constructor in the type, instead of any constructor in the type
10771 hierarchy. Thanks to Paolo for finding this bug (it showed up as
10772 a bug in the Mono runtime when applying the params attribute).
10774 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10775 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
10777 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
10779 * expression.cs (Unary.ResolveOperator): Use TypeManager
10780 to resolve the type.
10782 2002-06-13 Ravi Pratap <ravi@ximian.com>
10784 * cs-parser.jay (enum_member_declaration): Pass in the attributes
10787 * enum.cs (AddEnumMember): Add support to store the attributes associated
10788 with each member too.
10790 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
10791 field builders too - this takes care of the enum member case.
10793 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
10795 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
10796 address-of operator on both value types and pointers.
10798 2002-06-10 Martin Baulig <martin@gnome.org>
10800 * interface.cs (Interface.PopulateIndexer): Add the indexer's
10801 PropertyBuilder to the `property_builders' list.
10803 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
10804 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
10805 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
10806 find any indexers which are inherited from an interface.
10808 2002-06-09 Martin Baulig <martin@gnome.org>
10810 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
10811 the same type as the constant if necessary. There's also a test-130.cs
10814 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
10816 * typemanager.cs (TypeManager.ChangeType): Previously known as
10817 Enum.ChangeEnumType().
10819 2002-06-09 Martin Baulig <martin@gnome.org>
10821 * expression.cs (Cast.TryReduce): Added support for consts.
10823 2002-06-08 Ravi Pratap <ravi@ximian.com>
10825 * class.cs (Accessor): Hold attributes information so we can pass
10828 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
10829 Modify to pass in attributes attached to the methods.
10831 (add_accessor_declaration, remove_accessor_declaration): Ditto.
10833 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
10834 to handle the Accessor kind :-)
10836 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
10838 2002-06-08 Martin Baulig <martin@gnome.org>
10840 * expression.cs (Unary.TryReduceNegative): Added support for
10843 2002-06-08 Martin Baulig <martin@gnome.org>
10845 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
10846 name can't be found in the `defined_names' - the caller will do a
10847 MemberLookup in this case and thus find methods in System.Enum
10848 such as Enum.IsDefined().
10850 2002-06-08 Martin Baulig <martin@gnome.org>
10852 * enum.cs (Enum.ChangeEnumType): This is a custom version of
10853 Convert.ChangeType() which works with TypeBuilder created types.
10854 (Enum.LookupEnumValue, Enum.Define): Use it here.
10856 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
10857 `TypeBuilder.BaseType != null' check.
10858 (TypeContainer.FindMembers): Only lookup parent members if we
10859 actually have a parent.
10860 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
10861 (ConstructorInitializer.Resolve): Likewise.
10863 * interface.cs (Interface.FindMembers): Added
10864 `TypeBuilder.BaseType != null' check.
10866 * rootcontext.cs (RootContext.ResolveCore): Added
10867 "System.Runtime.CompilerServices.IndexerNameAttribute" to
10868 classes_second_stage.
10870 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
10871 debug_type and trace_type when compiling with --nostdlib.
10873 2002-06-07 Martin Baulig <martin@gnome.org>
10875 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
10876 (AddField): Set it to true when adding a non-static field.
10877 (DefineType): Use `have_nonstatic_fields' to find out whether we
10878 have non-static fields, not `Fields != null'.
10880 2002-06-02 Miguel de Icaza <miguel@ximian.com>
10882 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
10883 dereferencing a null on the static-field code path)
10885 2002-05-30 Martin Baulig <martin@gnome.org>
10887 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
10888 to take command line arguments. Use reflection to call the new
10889 custom `Initialize' function on the symbol writer and pass it the
10890 command line arguments.
10892 * driver.cs (--debug-args): New command line argument to pass command
10893 line arguments to the symbol writer.
10895 2002-05-28 Miguel de Icaza <miguel@ximian.com>
10897 * assign.cs (DoResolve): Forgot to do the implicit conversion to
10898 the target type for indexers and properties. Thanks to Joe for
10901 2002-05-27 Miguel de Icaza <miguel@ximian.com>
10903 * typemanager.cs (MethodFlags): returns the method flags
10904 (Obsolete/ShouldIgnore) that control warning emission and whether
10905 the invocation should be made, or ignored.
10907 * expression.cs (Invocation.Emit): Remove previous hack, we should
10908 not do this on matching a base type, we should do this based on an attribute
10910 Only emit calls to System.Diagnostics.Debug and
10911 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
10912 on the command line.
10914 * rootcontext.cs: Global settings for tracing and debugging.
10916 * cs-tokenizer.cs (define): New utility function to track
10917 defines. Set the global settings for TRACE and DEBUG if found.
10919 2002-05-25 Ravi Pratap <ravi@ximian.com>
10921 * interface.cs (Populate*): Pass in the TypeContainer as well as
10922 the DeclSpace as parameters so that we can create EmitContexts and
10923 then use that to apply attributes etc.
10925 (PopulateMethod, PopulateEvent, PopulateProperty)
10926 (PopulateIndexer): Apply attributes everywhere.
10928 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
10931 (ApplyAttributes): Update accordingly.
10933 We now apply interface attributes for all members too.
10935 2002-05-26 Miguel de Icaza <miguel@ximian.com>
10937 * class.cs (Indexer.Define); Correctly check if we are explicit
10938 implementation (instead of checking the Name for a ".", we
10939 directly look up if the InterfaceType was specified).
10941 Delay the creation of the PropertyBuilder.
10943 Only create the PropertyBuilder if we are not an explicit
10944 interface implementation. This means that explicit interface
10945 implementation members do not participate in regular function
10946 lookups, and hence fixes another major ambiguity problem in
10947 overload resolution (that was the visible effect).
10949 (DefineMethod): Return whether we are doing an interface
10952 * typemanager.cs: Temporary hack until we get attributes in
10953 interfaces (Ravi is working on that) and we get IndexerName
10954 support in interfaces.
10956 * interface.cs: Register the indexers as properties.
10958 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
10959 warning, I have verified that this is a bug in the .NET runtime
10960 (JavaScript suffers of the same problem).
10962 * typemanager.cs (MemberLookup): When looking up members for
10963 interfaces, the parent of an interface is the implicit
10964 System.Object (so we succeed in searches of Object methods in an
10965 interface method invocation. Example: IEnumerable x; x.ToString
10968 2002-05-25 Miguel de Icaza <miguel@ximian.com>
10970 * class.cs (Event): Events should also register if they do
10971 implement the methods that an interface requires.
10973 * typemanager.cs (MemberLookup); use the new GetInterfaces
10976 (GetInterfaces): The code used to lookup interfaces for a type is
10977 used in more than one place, factor it here.
10979 * driver.cs: Track the errors at the bottom of the file, we kept
10982 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
10983 instance if the method we are calling is static!
10985 2002-05-24 Miguel de Icaza <miguel@ximian.com>
10987 * attribute.cs (ApplyAttributes): Make this function filter out
10988 the IndexerName attribute (as that attribute in reality is never
10989 applied) and return the string constant for the IndexerName
10992 * class.cs (TypeContainer.Emit): Validate that all the indexers
10993 have the same IndexerName attribute, and if so, set the
10994 DefaultName attribute on the class.
10996 * typemanager.cs: The return value might contain other stuff (not
10997 only methods). For instance, consider a method with an "Item"
10998 property and an Item method.
11000 * class.cs: If there is a problem with the parameter types,
11003 2002-05-24 Ravi Pratap <ravi@ximian.com>
11005 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11006 looks at user defined conversion after making a call to
11007 StandardConversionExists - we need this for overload resolution.
11009 * expression.cs : Update accordingly the various method calls.
11011 This fixes 2 bugs filed against implicit user defined conversions
11013 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11015 * statement.cs: Track the result of the assignment.
11017 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11019 * expression.cs (MemberAccess): Improved error reporting for
11020 inaccessible members.
11022 2002-05-22 Martin Baulig <martin@gnome.org>
11024 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11025 itself with debugging support.
11027 2002-05-22 Martin Baulig <martin@gnome.org>
11029 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11030 Removed, this isn't needed anymore.
11032 2002-05-20 Martin Baulig <martin@gnome.org>
11034 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11035 be underlying type for an enum.
11037 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11039 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11040 that splits out the loading of just the core types.
11042 * rootcontext.cs (ResolveCore): Split the struct resolution in
11043 two, so we can load the enumeration underlying types before any
11046 * expression.cs (Is): Bandaid until we fix properly Switch (see
11047 bug #24985 for details).
11049 * typemanager.cs (ImplementsInterface): The hashtable will contain
11050 a null if there are no interfaces implemented.
11052 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11054 * cs-parser.jay (indexer_declarator): It is fine to have array
11057 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11059 * typemanager.cs: (RegisterBuilder): New function used to register
11060 TypeBuilders that implement interfaces. Since
11061 TypeBuilder.GetInterfaces (as usual) does not work with lame
11063 (AddUserType): register interfaces.
11065 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11066 dealing with TypeBuilder. Also, arrays are showing up as
11067 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11068 methods can not be invoked on them!
11070 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11071 (ImplicitReferenceConversionExists): Split out from
11072 StandardConversionExists.
11074 * expression.cs (As): We were only implementing one of the three
11075 cases for the as operator. We now implement them all.
11076 (Is): Implement the various other cases for Is as well.
11078 * typemanager.cs (CACHE): New define used to control if we want or
11079 not the FindMembers cache. Seems to have a negative impact on
11080 performance currently
11082 (MemberLookup): Nested types have full acess to
11083 enclosing type members
11085 Remove code that coped with instance/static returns for events, we
11086 now catch this in RealFindMembers.
11088 (RealFindMembers): only perform static lookup if the instance
11089 lookup did not return a type or an event.
11091 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11093 * assign.cs (CompoundAssign): We pass more semantic information
11094 now to Compound Assignments than we did before: now we have all
11095 the information at hand, and now we resolve the target *before* we
11096 do the expression expansion, which allows the "CacheValue" method
11097 to have the effect we intended (before, a [x] += 1 would generate
11098 two differen ArrayAccess expressions from the ElementAccess,
11099 during the resolution process).
11101 (CompoundAssign.DoResolve): Resolve target and original_source here.
11103 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11105 * expression.cs (ArrayAccess): dropped debugging information.
11107 * typemanager.cs: Small bug fix: I was always returning i_members,
11108 instead of one of i_members or s_members (depending on which had
11111 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11112 method is invoked before any code generation takes place, and it
11113 is a mechanism to inform that the expression will be invoked more
11114 than once, and that the method should use temporary values to
11115 avoid having side effects
11117 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11119 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11122 * expression.cs (Indirection, ArrayAccess): Add support for
11123 CacheTemporaries in these two bad boys.
11125 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11126 ldobj or ldind_ref.
11127 (StoreFromPtr): Handle stobj as well.
11129 * expression.cs (UnaryMutator): Share more code.
11131 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11132 down: I was not tracking the Filter function as well, which
11133 was affecting the results of the cache.
11135 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11137 * attribute.cs: Remove the hack to handle the CharSet property on
11140 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11142 * attribute.cs (DoResolve): More uglyness, we now only try to
11143 resolve the attribute partially, to extract the CharSet
11144 information (only if we are a StructLayout attribute). Otherwise
11146 (GetExtraTypeInfo): Add some code to conditionally kill in the
11147 future this. I am more and more convinced that the .NET
11148 framework has special code to handle the attribute setting on
11151 * expression.cs (IsParamsMethodApplicable): Revert my previous
11152 foreach change here, it was wrong.
11154 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11156 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11157 (pp_expr): do not abort on unknown input, just return.
11158 (eval): abort if there are pending chars.
11160 * attribute.cs (Attribute.Resolve): Positional parameters are
11161 optional. Deal with that case.
11163 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11164 the Ansi/Unicode/Auto information for the type.
11166 (TypeContainer.DefineType): instantiate the EmitContext here, as
11167 we will be using it during the type definition (to resolve
11168 attributes) and during the emit phase.
11170 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11171 to pull type information out of the attributes
11173 (Attribute.Resolve): track the constructor builder, and allow for
11174 multiple invocations (structs and classes will use this).
11176 * ecore.cs (MemberLookupFinal): new version with all the
11177 parameters customizable.
11179 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11180 constructors. Return if the result value is null (as the error
11181 would have been flagged already by MemberLookupFinal)
11183 Do not allow instances of abstract classes or interfaces to be
11186 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11187 We have to compare the assembly property here when dealing with
11188 FamANDAssem and Assembly access modifiers, because we might be
11189 creating an assembly from *modules* (that means that we are not
11190 getting TypeBuilders for types defined in other modules that are
11191 part of this assembly).
11193 (Method.Emit): If the method is marked abstract and has a body,
11196 (TypeContainer.DefineMembers): If both the defined member and the
11197 parent name match are methods, then do not emit any warnings: let
11198 the Method.Define routine take care of flagging warnings. But if
11199 there is a mismatch (method overrides something else, or method is
11200 overriwritten by something, then emit warning).
11202 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11203 set to null, this means `do not check for the return type on the
11206 (Method.Define): set the return type for the method signature to
11207 null, so that we get methods with the same name and parameters and
11208 different return types. This is used to flag warning 114 (you are
11209 hiding a method, and you probably want to use the new/override
11212 * typemanager.cs (MemberLookup): Implemented proper access
11213 control, closing a long standing set of bug reports. The problem
11214 was that the Framework only has two bits: Public and NonPublic,
11215 and NonPublic includes private and protected methods, but we need
11216 to enforce the FamANDAssem, FamOrAssem and Family.
11218 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11220 * statement.cs (GotoCase): Return true: Ammounts to giving up
11221 knowledge on whether we return or not, and letting the other case
11222 be responsible for it.
11224 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11226 * driver.cs: Do not load directories for each file processed, only
11227 do it if there is a pattern.
11229 * ecore.cs: Report readonly assigns here as well, as we might have
11230 been resolved only by MemberAccess.
11232 (SimpleName.SimpleNameResolve): Also be useful for LValue
11233 resolution. We need this to propagate assign to local readonly variables
11235 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11236 do not want to reuse potential criteria memory.
11238 * class.cs (MyEventBuilder): Set reflected_type;
11240 * ecore.cs (Constantify): Added support for constifying bools.
11242 (RootContext.LookupType): Added a cache for values looked up in
11243 the declaration space.
11245 * typemanager.cs (FindMembers): Now is a front-end to
11246 RealFindMembers, and provides a two-level hashtable-based cache to
11249 15% performance improvement: from 22.5 to 19.2 seconds.
11251 * expression.cs (IsParamsMethodApplicable): use foreach.
11252 (Invocation.DoResolve): ditto.
11253 (New.DoResolve): ditto.
11254 (ArrayCreation.DoResolve): ditto.
11256 * ecore.cs (FindMostEncompassingType): use foreach.
11258 * delegate.cs (NewDelegate.DoResolve): Use foreach
11260 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11261 (RemoveMethods): use foreach.
11263 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11264 nested foreach statements instead of for, and also break out of
11265 the inner loop once a match is found.
11267 (Invocation.OverloadResolve): Use foreach, simplify the code.
11269 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11271 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11272 we actually unwrap the expression to allow for extra information
11275 * expression.cs: Use Shr_Un on unsigned operations.
11277 2002-05-08 Ravi Pratap <ravi@ximian.com>
11279 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11280 applicable operators was not being considered correctly. This closes
11281 the bug Miguel reported.
11283 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11285 * attribute.cs: check that the type derives from System.Attribute
11286 and report the correct error in that case (moved the duplicate code to
11287 its own method, too).
11289 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11291 * attribute.cs: lookup attribute type name as the spec says: first the
11292 bare attribute name and then name + "Attribute" (nant compiles with
11293 mcs after this fix).
11295 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11297 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11298 Because of the way we parse things, we should try to see if a
11299 UIntConstant can fit in an integer.
11301 2002-05-07 Ravi Pratap <ravi@ximian.com>
11303 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11304 when we are in an explicit context.
11306 (ConvertReferenceExplicit): When converting from Iface type S to Class
11307 T make sure the rules are implemented as an OR.
11309 * parameter.cs (ParameterType): Make it a property for now although the
11310 purpose really isn't anything immediate.
11312 * expression.cs (Is*Applicable): Do better checking on the parameter type
11313 of a ref/out parameter. The ones from the system assemblies are already
11314 marked with the correct type so we don't need to do any correction.
11316 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11317 the object type is standard too so include that.
11319 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11321 * ecore.cs (StandardConversionExists): Augment with missing code:
11322 deal with IntConstant, LongConstants and Enumerations.
11324 * assign.cs: Report the error, instead of failing silently
11326 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11327 typecontainer that they are declared, because the
11328 typecontainer/namespace will have the list of using clauses that
11329 need to be applied.
11331 Assembly Attributes were escaping the normal registration
11334 (EmitCode): Apply attributes within an EmitContext that represents
11335 the container they were declared on.
11337 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11339 2002-05-06 Ravi Pratap <ravi@ximian.com>
11341 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11342 Revamp completely - make much cleaner as we now operate only
11345 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11346 to implement the logic detailed in the spec more correctly.
11348 (UserDefinedConversion): Update accordingly.
11350 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11352 * statement.cs: Return flow analysis information up.
11354 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11357 (token): Do not consume an extra character before calling
11360 2002-05-06 Piers Haken <piersh@friskit.com>
11362 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11364 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11366 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11367 EmitContext during the instance constructor initializer
11368 resolution, to stop access to instance variables.
11370 This is mandated by the spec, last paragraph of the `constructor
11371 initializers' section.
11373 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11375 * cs-parser.jay, class.cs (Accessor): new class used to represent
11376 an accessor (get or set). In the past we used `null' to represent
11377 a missing accessor. But this is ambiguous because there was no
11378 way to tell in abstract indexers/properties if one of them was
11381 Now there is a way of addressing that.
11383 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11384 instead of FindMembers.
11386 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11387 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11389 * attribute.cs: Treat indexers and properties as the same in terms
11390 of applying attributes
11392 * ecore.cs (FindMostEncompassedType): Use statically initialized
11393 EmptyExpressions()s like we do elsewhere to avoid creating useless
11394 objects (and we take this out of the tight loop).
11396 (GetConversionOperators): Move the code to extract the actual
11397 operators to a separate routine to clean things up.
11399 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11401 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11402 events are always registered FieldBuilders.
11404 * class.cs (FieldBase): New class shared by Fields
11406 * delegate.cs: If we are a toplevel delegate, use our full name.
11407 If we are a nested delegate, then only use our tail name.
11409 2002-05-02 Ravi Pratap <ravi@ximian.com>
11411 * expression.cs (IsApplicable): Ensure that we add the "&" to
11412 ref/out types before comparing it with the type of the argument.
11414 (IsParamsMethodApplicable): Ditto.
11416 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11419 * delegate.cs : Handle the case when we have more than one applicable
11420 method. Flag an error only when we finish checking all.
11422 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11424 * expression.cs: Add support for boolean static initializers.
11426 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11428 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11430 * parameter.cs (ComputeParameterTypes,
11431 ComputeAndDefineParameterTypes): Better error handling: now we
11432 clear the `types' cache if we fail during any of the type lookups.
11433 We also return the status code correctly to our caller
11435 * delegate.cs: If we fail to define a delegate, abort the extra
11438 * expression.cs (Binary.ResolveOperator): for
11439 operator==(object,object) and operator !=(object, object) we also
11440 have to verify that there is an implicit conversion from one to
11443 (ArrayAccess.DoResolve): Array Access can operate on
11446 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11448 * assign.cs (CompoundAssign): A new class used as a "flag" that
11449 the assignment actually is happening as part of a compound
11450 assignment operator.
11452 During compound assignment, a few new rules exist to enable things
11459 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11460 to the type of x) if y is implicitly convertible to the type of x,
11461 and the operator is a builtin operator and the return type of the
11462 operator is explicitly convertible to the type of x.
11464 * rootcontext.cs: Reset warning level to 2. 4 catches various
11465 "interesting" features in mcs, we must clean this up at some
11466 point, but currently am trying to kill other bugs ;-)
11468 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11469 in container classes as well.
11471 * expression.cs (Binary.ResolveOperator): Handle string case
11472 before anything else (as operator overloading does emit an error
11473 before doing anything else).
11475 This code could go away when we move to a table driven model, but
11476 i could not come up with a good plan last night.
11478 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
11480 * typemanager.cs (CSharpName): reimplementation using regex.
11481 * class.cs: added null check for fields in Emit
11482 * rootcontext.cs: set warninglevel to 4
11484 2002-04-29 Miguel de Icaza <miguel@ximian.com>
11486 * typemanager.cs (CSharpName): reimplemented with Lupus
11489 2002-04-28 Miguel de Icaza <miguel@ximian.com>
11491 * statement.cs (If): correclty implement Resolve, because we were
11492 not catching sem errors in there. The same process is needed
11494 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11497 (Statement.Warning_DeadCodeFound): Factorize code.
11498 (While): Report dead code here too.
11500 (Statement): Added Resolve virtual method to allow
11501 for resolution split from the emit code.
11503 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11505 * statement.cs (EmitBoolExpression): No longer try to resolve the
11507 (MakeBoolean): New utility function that resolve, implicitly
11508 converts to boolean and tags the expression.
11511 (If, Do): Implement dead code elimination.
11512 (While): Implement loop inversion
11514 (Do, While, For, If): Resolve the expression prior to calling our
11517 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11520 - added method Report28 (warning: program has more than one entry point)
11521 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11522 - modified method Method.Define, the part at the end of the method
11524 * rootcontext.cs: added static public Location EntryPointLocation;
11526 * ../errors/cs0028.cs : Add test case for the above warning.
11529 - modified method CSharpName to allow arrays of primitive type to
11530 be printed nicely (e.g. instead of System.Int32[][] it now prints
11532 - added method CSharpSignature: returns the signature of a method
11533 in string format to be used in reporting errors, warnings, etc.
11535 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
11538 2002-04-26 Ravi Pratap <ravi@ximian.com>
11540 * delegate.cs (Define): Fix extremely silly bug where I was
11541 setting the type of the 'object' parameter of the BeginInvoke
11542 method to System.IAsyncResult instead of System.Object ;-)
11544 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11546 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
11549 (Constructor.Emit): return if we fail to initialize the
11550 constructor. Another door closed!
11552 * expression.cs (New.DoResolve): Improve error message (from -6 to
11553 1501). Use DeclaredOnly lookup to find the exact constructor.
11555 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
11556 loop. This is useful.
11558 * cs-parser.jay: Adjust the default parameters so that destructors
11559 have the proper signature.
11561 2002-04-26 Martin Baulig <martin@gnome.org>
11563 * driver.cs (LoadAssembly): If `assembly' contains any characters
11564 which are only valid in path names and not in assembly names
11565 (currently slash, backslash and point), use Assembly.LoadFrom ()
11566 instead of Assembly.Load () on the `assembly' (before iteration
11567 over the link_paths).
11569 2002-04-26 Martin Baulig <martin@gnome.org>
11571 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
11573 2002-04-25 Miguel de Icaza <miguel@ximian.com>
11575 * class.cs (Property): use the new typemanager.MemberLookup
11577 (TypeContainer.MemberLookup): Implement using the
11578 TypeManager.MemberLookup now.
11580 * typemanager.cs: Make MemberLookup a function of the TypeManager,
11581 and return MemberInfos, so that these can be used without an
11582 EmitContext (what we had before).
11584 2002-04-24 Miguel de Icaza <miguel@ximian.com>
11586 * expression.cs: Fix the case where the argument to params if the
11587 type of the params. I omitted handling this before. Fixed
11589 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11591 * driver.cs: Call BootCorlib_PopulateCoreType
11593 * class.cs (Property.CheckBase): Check for properties only, not
11596 * interface.cs: Temporary hack: try/catch around the
11597 CustomAttributeBuilder, because I am getting an exception that I
11600 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
11601 types whose definitions are required to be there (attributes are
11602 defined before standard types).
11604 Compute definitions as we boot the various types, as they are used
11605 immediately (value_type class will need object_type, but if we do
11606 not initialize object_type, we will pass a null, which will let
11607 the runtime pick the System.Object from the existing corlib, which
11608 is not what we want).
11610 2002-04-22 Patrik Torstensson <totte@labs2.com>
11612 * cs-tokenizer.cs: fixed a number of trim() issues.
11614 2002-04-22 Ravi Pratap <ravi@ximian.com>
11616 * expression.cs (Argument.Type): Ensure that we return the correct
11617 type when we have out or ref parameters [in which case we
11620 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11622 * class.cs (Property, Indexer): Allow extern modifier in there.
11624 * typemanager.cs (InitBaseTypes): Initializes object_type and
11625 value_type, since those will be used early on during the bootstrap
11626 process to compile corlib.
11628 (InitCoreTypes): Move code from here to InitBaseTypes.
11630 2002-04-21 Miguel de Icaza <miguel@ximian.com>
11632 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
11633 single-dimension arrays as using the ldlen opcode.
11635 Daniel Lewis discovered this optimization.
11637 * typemanager.cs: Add signature for System.Array::get_Length
11639 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11641 * statement.cs: report the error when the foreach does not apply to an
11642 array nor a collection.
11644 2002-04-19 Miguel de Icaza <miguel@ximian.com>
11646 * expression.cs: Add implicit conversions to the operator ~.
11648 * constant.cs (DecimalConstant.Emit): Emit decimal value.
11650 * typemanager.cs: Locate the decimal constructor.
11652 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11654 * attribute.cs: use the new property of TypeOf.
11655 * expression.cs: added 'get' property around typearg.
11657 These changes fix a build breaker reported by NickD. Is this the
11658 correct way to fix? If not, please, revert my changes and make it
11661 2002-04-17 Miguel de Icaza <miguel@ximian.com>
11663 * attribute.cs: Add support for typeof in attribute invocations.
11664 I am not sure that this is right though.
11666 2002-04-14 Duncan Mak <duncan@ximian.com>
11668 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
11669 Binary.Operator.Division case.
11671 2002-04-13 Ravi Pratap <ravi@ximian.com>
11673 * class.cs (DefineType): Ensure that we do a proper check on
11674 attribute types and also register it with the TypeManager.
11676 (TypeContainer.Targets): The default for attribute types is
11677 AttributeTargets.All.
11679 * attribute.cs (ApplyAttributes): Registering the attribute type
11680 is done elsewhere, not when we discover we have a Usage attribute.
11682 2002-04-12 Ravi Pratap <ravi@ximian.com>
11684 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
11685 and get rid of is_delegate parameter.
11687 * everywhere : update.
11689 2002-04-12 Ravi Pratap <ravi@ximian.com>
11691 * cs-parser.jay (compilation_unit): Revamp completely to use
11692 some new ideas that I got from Rhys' grammar to solve the problems
11693 with assembly level attributes.
11695 (outer_declaration): New grammar production.
11697 (attribute_sections): Add.
11699 (opt_attributes): Base on attribute_sections
11701 (namespace_declaration): Allow opt_attributes to tackle the case
11702 when we have assembly level attributes - we are clever in this
11705 * attribute.cs (ApplyAttributes): Do not worry about assembly
11706 attributes in the non-global context.
11708 * rootcontext.cs (AddGlobalAttributes): Go back to using this
11709 instead of SetGlobalAttributes.
11711 * class.cs, rootcontext.cs : Ensure we define and generate
11712 attribute types before anything else.
11714 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
11715 and flag the new error -20 for the case when the attribute type
11716 does not have valid targets specified. csc does not catch this.
11718 * ../errors/errors.txt : update for error # -20
11720 2002-04-11 Ravi Pratap <ravi@ximian.com>
11722 * support.cs (InternalParameters.ParameterModifier): Do some null
11723 checking and return sane values.
11725 * class.cs (Method.Define): If we are a PInvoke method, ensure
11726 that we are static and extern. Report error # 601
11728 * ../errors/cs0601.cs : Add test case for the above error.
11730 2002-04-07 Ravi Pratap <ravi@ximian.com>
11732 * rootcontext.cs (attribute_types): We need to keep type of
11733 all attribute types separately and emit code for them first.
11735 (RegisterAttribute) : Implement.
11737 * class.cs (DefineType): Check if the current Type is a custom
11738 attribute type and register it accordingly.
11740 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
11741 adding the first attribute twice and rename to
11743 (SetGlobalAttributes): this.
11745 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
11748 * attribute.cs (ApplyAttributes): Take an additional argument telling us
11749 if we are processing global arguments. Hmm, I am unsure of this.
11751 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11753 * expression.cs: added static array of strings to avoid calling
11754 Enum.ToString () for Operator in Binary. Significant recover of
11757 2002-04-10 Miguel de Icaza <miguel@ximian.com>
11759 * class.cs (FindMembers): Allow the Builders of the various
11760 members to be null. If they are skip them. This only happens
11761 during the PInvoke declaration.
11763 2002-04-09 Miguel de Icaza <miguel@ximian.com>
11765 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
11766 failure, so we do not keep going afterwards.
11768 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
11769 wanted to pass `false' as the `is_delegate' argument. If this is
11770 the case, why not use delegate_type == null to mean `is_delegate =
11771 false' and anything else as is_delegate = true.
11773 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
11775 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
11776 code for the section, not the beginning of the tests.
11778 2002-04-08 Miguel de Icaza <miguel@ximian.com>
11780 * cfold.cs: Handle operator + (Enum x, Underlying x)
11782 * expression.cs (Binary): same. Warn about errors where we have
11783 Enum/Enum in operator + as well.
11785 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
11788 - added support for switch(bool)
11789 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
11790 - add TableSwitchEmit() to handle table-based switch statements
11792 2002-04-05 Ravi Pratap <ravi@ximian.com>
11794 * expression.cs (Invocation.OverloadResolve): Factor out code which
11795 does parameter compatibility checking with arguments so that we can
11796 re-use the code even from Delegate.VerifyApplicability
11798 (VerifyArgumentsCompat): Move above code here.
11800 * delegate.cs (VerifyApplicability): Get rid of duplicate code
11801 and instead make a call to the above method.
11803 2002-03-31 Ravi Pratap <ravi@ximian.com>
11805 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
11806 We use it to keep track of classes which are attribute types.
11808 2002-04-02 Miguel de Icaza <miguel@ximian.com>
11810 * delegate.cs (Delegate.Define): Correctly define the types in the
11811 presence of fixed and array parameters.
11813 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
11816 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
11817 include NonPublic after the first iteration.
11819 * class.cs (Indexer.CheckBase): Only check if both parents are
11822 * cs-parser.jay (accessor_body): If empty, set to null.
11824 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
11825 same code path here to resolve constants names that we did have in
11826 MemberAccess.DoResolve. There is too much code duplicated here.
11828 2002-04-01 Miguel de Icaza <miguel@ximian.com>
11830 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
11832 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
11835 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
11836 tokens, numbers and strings.
11838 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
11841 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
11842 asyncronous parameters and the regular parameters.
11844 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
11845 specify the target directory.
11847 * expression.cs: (This.DoResolve): Simplify
11848 (As.Emit): Optimize, do not generate IsInst if the expression is
11849 always of the given type.
11851 (Is.DoResolve): Bug fix, we were reporting both always/never for
11854 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
11855 creating too many unnecessary arrays.
11857 2002-03-31 Miguel de Icaza <miguel@ximian.com>
11859 * class.cs (EmitFieldInitializer): Use Assign expression to assign
11860 fields instead of rolling our own initializer. Takes care of all
11861 implicit conversions, and drops unnecessary static checks/argument.
11863 2002-03-31 Dick Porter <dick@ximian.com>
11865 * driver.cs: use the GetDirectories() return values properly, and
11866 use "/" as path separator.
11868 2002-03-30 Miguel de Icaza <miguel@ximian.com>
11870 * expression.cs (Unary): Optimize - - expr into expr.
11871 (Binary): Optimize a + (-b) into a -b.
11873 * codegen.cs (CodeGen): Made all methods static.
11875 2002-03-29 Miguel de Icaza <miguel@ximian.com>
11879 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
11880 TypeBuilder property.
11882 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
11885 * tree.cs: Removed the various RecordXXXX, and replaced with a
11886 single RecordDecl. Removed all the accessor methods, and just
11887 left a single access point Type
11889 * enum.cs: Rename DefineEnum to DefineType.
11891 * decl.cs: New abstract method `DefineType' used to unify the
11892 Defines for Enumerations, Interfaces, TypeContainers and
11895 (FindType): Moved LookupInterfaceOrClass here. Moved the
11896 LookupBaseClasses method that used to live in class.cs and
11897 interface.cs here, and renamed to FindType.
11899 * delegate.cs: Implement DefineType. Take advantage of the
11900 refactored pattern for locating the parent builder without taking
11901 the parent_builder argument (which we know does not work if we are
11902 nested, and triggering a toplevel definition).
11904 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11906 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
11907 accessibility of a member has changed during override and report
11910 * class.cs (Method.Define, Property.Define): Only complain on
11911 overrides if the method is private, any other accessibility is
11912 fine (and since we just checked the permission is the same, we are
11915 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
11916 and elif are processed always. The other pre-processing
11917 directives are only processed if we are "taking" the path
11919 2002-03-29 Martin Baulig <martin@gnome.org>
11921 * class.cs (Method.Emit): Only emit symbolic debugging info if the
11922 current location is not Null.
11924 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
11925 a separate method so we can profile it.
11927 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
11928 `span.Seconds' are just seconds, but no minutes or hours.
11929 (MainDriver): Profile the CodeGen.SaveSymbols calls.
11931 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11933 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
11934 Remove the gratuitous set of Final:
11936 // If an interface implementation, then we can set Final.
11937 if (((flags & MethodAttributes.Abstract) == 0) &&
11938 implementing.DeclaringType.IsInterface)
11939 flags |= MethodAttributes.Final;
11941 I do not know what I was smoking when I used that.
11944 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
11945 step into fixing the name resolution issues for delegates and
11946 unifying the toplevel name resolution.
11948 2002-03-28 Martin Baulig <martin@gnome.org>
11950 * class.cs (Method.Emit): If we have a symbol writer, call its
11951 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
11952 tell it about the current method.
11954 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
11955 writer that we're going to emit the first byte of IL code for a new
11956 statement (a new source line).
11957 (EmitContext.EmitTopBlock): If we have a symbol writer, call
11958 EmitContext.Mark() before emitting any code.
11960 * location.cs (SymbolDocument): Return null when we're Null.
11962 * statement.cs (Statement): Moved the `Location loc' variable here.
11963 (Statement.EmitBoolExpression): If we have a symbol writer, call
11964 ec.Mark() before emitting any code to tell it that we're at the
11965 beginning of a new statement.
11966 (StatementExpression): Added `Location' argument to the constructor.
11967 (Block): Added public readonly variable `StartLocation' and public
11968 variable `EndLocation'. The latter is to be set using SetEndLocation().
11969 (Block): Added constructor which takes a start and end location.
11970 (Block.SetEndLocation): New method. This sets the end location.
11971 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
11972 local variables we create.
11973 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
11974 each statement and do also mark the begin and end of the block.
11976 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
11977 tell it the current lexer.Location, use Location.Null for the end of the
11979 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
11980 current block, set its end location using SetEndLocation().
11981 (statement_expression): StatementExpression constructor now takes the
11982 lexer.Location as additional argument.
11983 (for_statement, declare_local_variables): Likewise.
11984 (declare_local_variables): When creating a new implicit block, use the
11985 new Block constructor and pass it the lexer.Location.
11987 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11989 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
11990 members also on the parent interfaces recursively.
11992 2002-03-27 Miguel de Icaza <miguel@ximian.com>
11994 * report.cs: Use new formats, since Gonzalo finished the missing
11997 * expression.cs (Binary.ResolveOperator): added missing operator|
11998 operator& and operator^ for bool/bool.
12000 * cs-parser.jay: CheckDef now takes a Location argument that is
12001 used to report errors more precisly (instead of reporting the end
12002 of a definition, we try to track something which is a lot closer
12003 to the source of the problem).
12005 * cs-tokenizer.cs: Track global token use, so we can properly flag
12006 the use of #define/#undef after the first token has been seen.
12008 Also, rename the reportXXXX to Error_DescriptiveName
12010 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12011 TypeContainer, so that Enum and Interface can use this too.
12013 * class.cs (TypeContainer.LookupInterfaceOrClass,
12014 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12015 `builder' argument. Typically this was used to pass the parent
12016 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12019 The problem is that a nested class could trigger the definition of
12020 a toplevel class, and the builder would be obviously wrong in that
12023 So we drop this argument, and we compute dynamically the
12024 TypeBuilder/ModuleBuilder (the correct information was available
12025 to us anyways from DeclSpace.Parent)
12027 * interface.cs (Interface.DefineInterface): Drop builder
12028 parameter cleanup like class.cs
12030 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12033 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12036 (Try.Emit): Propagate the returns value from the statement.
12038 (Return.Emit): Even if we are leavning
12040 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12042 * modifiers.cs: Fix the computation of MethodAttributes flags.
12044 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12046 * driver.cs: allow compilation of files that start with '/'.
12047 Add a default case when checking the argument of --target.
12049 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12051 * interface.cs: Implement the same search algorithm for types in
12052 the interface code.
12054 * delegate.cs: Do not allow multiple definition.
12056 * Recovered ChangeLog that got accidentally amputated
12058 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12060 * rootcontext.cs: Load manually enum to allow core classes to
12061 contain enumerations.
12063 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12064 Update to new static methods in TypeManager.
12066 * typemanager.cs (GetMethod, GetConstructor): Use our
12067 implementation of FindMembers to find the members, since during
12068 corlib compilation, the types are TypeBuilders and GetMethod and
12069 GetConstructor do not work.
12071 Make all methods in TypeManager static.
12073 (InitCodeHelpers): Split the functionality from
12074 the InitCodeTypes function.
12076 * driver.cs: Call InitCodeHelpers after we have populated the
12079 * cs-parser.jay (delegate_declaration): we did not used to compute
12080 the delegate name correctly for void delegates.
12082 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12084 * rootcontext.cs (RootContext): Init the interface_resolve_order
12085 and type_container_resolve_order always.
12087 (ResolveCore, BootstrapCorlib_ResolveClass,
12088 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12089 compiler when compiling with --nostdlib
12091 * class.cs (TypeContainer.DefineType): Check that our parent is
12092 not null. This test is most important when we are bootstraping
12095 * codegen.cs: Split out the symbol writing code.
12097 2002-03-25 Martin Baulig <martin@gnome.org>
12099 * driver.cs (-g): Made -g an alias for --debug.
12101 2002-03-24 Martin Baulig <martin@gnome.org>
12103 * codegen.cs (SymbolWriter): New public variable. Returns the
12104 current symbol writer.
12105 (CodeGen): Added `bool want_debugging_support' argument to the
12106 constructor. If true, tell the ModuleBuild that we want debugging
12107 support and ask it for the ISymbolWriter.
12108 (Save): If we have a symbol writer, call it's Close() method after
12109 saving the assembly.
12111 * driver.c (--debug): New command line argument to create a
12112 debugger information file.
12114 * location.cs (SymbolDocument): New public property. Returns an
12115 ISymbolDocumentWriter object for the current source file or null
12116 if we don't have a symbol writer.
12118 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12120 * driver.cs (LoadAssembly): Correctly return when all the paths
12121 have been tried and not before.
12123 * statement.cs (Switch.Emit): return the actual coverage for this
12124 statement (returns/not-returns)
12126 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12127 switch of the statement if we are the last switch section. That
12128 kills two problems: try/catch problems (we used to emit an empty
12129 nop at the end) and switch statements where all branches would
12132 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12134 * driver.cs: Add default assemblies (the equivalent to the
12135 Microsoft CSC.RSP file)
12137 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12138 also update tokens_seen and set it to false.
12140 * driver.cs: Implement --recurse for Mike.
12142 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12143 correctly splitting out the paths.
12145 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12147 * interface.cs (Interface.PopulateProperty): Instead of using
12148 `parent' as the declaration space for the set parameters, use
12151 * support.cs (InternalParameters): InternalParameters constructor
12152 takes a DeclSpace instead of a TypeContainer.
12154 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12155 types are being initialized, load the address of it before calling
12158 (New): Provide a mechanism to disable the generation of local
12159 value type temporaries when the caller will be providing us with
12160 an address to store it.
12162 (ArrayCreation.EmitDynamicInitializers): Use it.
12164 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12166 * expression.cs (Invocation.EmitArguments): Only probe for array
12167 property if there is more than one argument. Sorry about that.
12169 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12170 empty param arrays.
12172 * class.cs (Method.LabelParameters): Fix incorrect code path that
12173 prevented the `ParamArrayAttribute' from being applied to the
12176 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12178 * support.cs (ReflectionParameters): Correctly compute whether the
12179 last argument is a params array. Fixes the problem with
12182 * typemanager.cs: Make the assemblies array always be non-null
12183 (empty, but non-null)
12185 * tree.cs (RecordDecl): New function that abstracts the recording
12186 of names. This reports error 101, and provides a pointer to the
12187 previous declaration. Fixes a crash in the compiler.
12189 * cs-parser.jay (constructor_declaration): Update to new grammar,
12190 and provide a constructor_body that can be empty.
12192 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12194 * driver.cs: Add support for --resources.
12196 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12197 Make all types for the various array helper methods be integer.
12199 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12200 CheckState to ConvCast.
12202 (ConvCast): Now it takes a `checked' state argument, to avoid
12203 depending on the emit context for the conversion, and just using
12204 the resolve time setting.
12206 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12207 instead of Invocation.EmitArguments. We do not emit the original
12208 arguments, instead we emit those which have been converted to
12209 unsigned int expressions.
12211 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12213 * codegen.cs: ditto.
12215 * expression.cs (LocalVariableReference): Drop the use of the
12216 Store function that depended on the variable index.
12218 * statement.cs (VariableInfo): Drop the `Idx' property from this
12219 class, as this is not taking into account the indexes for
12220 temporaries tat we generate during the execution, getting the
12223 * class.cs: First emit class initializers, then call the parent
12226 * expression.cs (Binary): Fix opcode emision.
12227 (UnaryMutator.EmitCode): Support checked code generation
12229 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12230 matches for events for both the Static and Instance scans,
12231 pointing to the same element. Fix that.
12233 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12235 * rootcontext.cs (ResolveTree): Always set the
12236 interface_resolve_order, because nested interfaces will be calling
12239 * class.cs (GetInterfaceOrClass): Track the same resolution
12240 process used by TypeManager.LookupType. This fixes the nested
12241 type lookups in class declarations (separate path from
12244 (TypeContainer.DefineType): Also define nested interfaces.
12245 (TypeContainer.RegisterOrder): New public function used to
12246 register the order in which child interfaces need to be closed.
12248 Nested interfaces need to be closed after their parents have been
12251 * interface.cs (InterfaceAttr): Put all the logic for computing
12252 the interface attribute here.
12254 (DefineInterface): Register our interface order with the
12255 RootContext or with the TypeContainer depending on the case.
12257 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12259 * cs-parser.jay: rework foreach statement to work with the new
12260 changes to the policy on SimpleNames.
12262 * report.cs: support Stacktrace on warnings as well.
12264 * makefile: drop --unsafe and /unsafe from the compile.
12266 2002-03-13 Ravi Pratap <ravi@ximian.com>
12268 * ecore.cs (StandardConversionExists): Modify to take an Expression
12269 as the first parameter. Ensure we do null -> reference type conversion
12272 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12273 temporary Expression objects.
12275 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12277 * interface.cs: workaround bug in method overloading resolution
12278 (there is already a bugzilla bug for it).
12280 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12282 We could also solve this problem by having a separate path for
12283 performing type lookups, instead of DoResolve, we could have a
12284 ResolveType entry point, and only participating pieces of the
12285 production (simplename, deref, array) would implement this.
12287 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12288 signal SimpleName to only resolve type names and not attempt to
12289 resolve anything else.
12291 * expression.cs (Cast): Set the flag.
12293 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12295 * class.cs: Only report 108 if there is no `new' modifier.
12297 * cs-parser.jay: rework foreach statement to work with the new
12298 changes to the policy on SimpleNames.
12300 * report.cs: support Stacktrace on warnings as well.
12302 * makefile: drop --unsafe and /unsafe from the compile.
12304 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12306 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12307 lookups here, instead of doing that at parse time. This means
12308 that our grammar will not introduce `LocalVariableReferences' as
12309 expressions at this point. That solves the problem of code like
12313 static void Main ()
12317 This is only half the fix. The full fix requires parameters to
12318 also be handled in this way.
12320 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12321 makes the use more obvious of the DeclSpace. The
12322 ec.TypeContainer.TypeBuilder is now only used to pull the
12323 TypeBuilder for it.
12325 My theory is that I can get rid of the TypeBuilder completely from
12326 the EmitContext, and have typecasts where it is used (from
12327 DeclSpace to where it matters).
12329 The only pending problem is that the code that implements Aliases
12330 is on TypeContainer, and probably should go in DeclSpace.
12332 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12333 lookups here, instead of doing that at parse time. This means
12334 that our grammar will not introduce `LocalVariableReferences' as
12335 expressions at this point. That solves the problem of code like
12339 static void Main ()
12343 This is only half the fix. The full fix requires parameters to
12344 also be handled in this way.
12346 * class.cs (Property.DefineMethod): When implementing an interface
12347 method, set newslot, when implementing an abstract method, do not
12348 set the flag (before we tried never setting it, or always setting
12349 it, which is the difference).
12350 (Indexer.DefineMethod): same.
12351 (Method.DefineMethod): same.
12353 * ecore.cs: Only set the status used flag if we get back a Field.
12355 * attribute.cs: Temporary hack, so Paolo can keep working.
12357 2002-03-08 Ravi Pratap <ravi@ximian.com>
12359 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12360 the unmanaged type in the case we have a MarshalAs attribute.
12362 (Resolve): Handle the case when we are parsing the special MarshalAs
12363 attribute [we need to store the unmanaged type to use later]
12365 * typemanager.cs (marshal_as_attr_type): Built in type for the
12366 MarshalAs Attribute.
12368 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12369 on parameters and accordingly set the marshalling info.
12371 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12373 * class.cs: Optimizing slightly by removing redundant code after
12374 we switched to the `NoTypes' return value.
12375 (Property.DefineMethod): use NoTypes here too.
12377 This fixes the bug I introduced in my last batch of changes.
12379 2002-03-05 Ravi Pratap <ravi@ximian.com>
12381 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12383 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12384 Enums since those are types too.
12386 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12388 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12389 thanks to a call during the lookup process.
12391 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12393 * statement.cs (Foreach): Lots of work to accomodate a particular
12394 kind of foreach statement that I had not kept in mind. It is
12395 possible to have foreachs on classes that provide a GetEnumerator
12396 method that return objects that implement the "pattern" for using
12397 a foreach, there is no need to support GetEnumerator
12400 This is needed to compile nant.
12402 * decl.cs: Only report 114 if the member is not `Finalize' and if
12403 the warning level is at least 2.
12405 * class.cs: Moved the compare function from Method to
12408 (MethodSignature.InheritableMemberSignatureCompare): Add new
12409 filter function that is used to extract inheritable methods from a
12412 (Method.Define): Use the new `inheritable_method_signature_filter'
12415 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12418 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12420 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12422 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12424 * expression.cs: Pass location information to
12425 ConvertImplicitStandard.
12427 * class.cs: Added debugging code to track return values from
12430 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12432 * expression.cs (Is.DoResolve): If either side of the `is' is an
12433 interface, do not flag the warning.
12435 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12438 * report.cs: Allow for --fatal to be used with --probe.
12440 * typemanager.cs (NoTypes): Move the definition for the empty Type
12443 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12445 (TypeContainer.DefineProxy): New function used to proxy to parent
12446 implementations when implementing interfaces.
12447 (TypeContainer.ParentImplements): used to lookup if our parent
12448 implements a public function that is required by an interface.
12449 (TypeContainer.VerifyPendingMethods): Hook this up.
12451 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12452 `modules' and `assemblies' arraylists into arrays. We only grow
12453 these are the very early start up of the program, so this improves
12454 the speedof LookupType (nicely measured).
12456 * expression.cs (MakeByteBlob): Replaced unsafe code with
12457 BitConverter, as suggested by Paolo.
12459 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12460 folding of string concatenation, but if either side is a string,
12461 and the other is not, then return null, and let the runtime use
12462 the concatenation on the string plus the object (using
12463 `Object.ToString').
12465 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12467 Constant Folding has been implemented now.
12469 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12470 the error instead on types that are not supported in one's
12473 * constant.cs (Constant and all children): New set of functions to
12474 perform implict and explicit conversions.
12476 * ecore.cs (EnumConstant): Implement the new functions to perform
12477 conversion by proxying to the child expression.
12479 * codegen.cs: (ConstantCheckState): Constant evaluation has its
12480 own separate setting that can not be turned off from the command
12481 line using --unchecked or --checked and is only controlled using
12482 the checked/unchecked statements and expressions. This setting is
12483 used by the constant folder to flag errors.
12485 * expression.cs (CheckedExpr, UncheckedExpr): Set the
12486 ConstantCheckState as well.
12488 During Resolve, they also have to flag the state, because the
12489 constant folder runs completely in the Resolve phase.
12491 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12494 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12496 * cfold.cs: New file, this file contains the constant folder.
12498 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12499 argument to track whether we are using the resulting address to
12500 load or store a value and provide better error messages.
12502 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12503 new AddressOf arguments.
12505 * statement.cs (Foreach.EmitCollectionForeach): Update
12507 * expression.cs (Argument.Emit): Call AddressOf with proper
12508 arguments to track usage.
12510 (New.DoEmit): Call AddressOf with new arguments.
12512 (Unary.Emit): Adjust AddressOf call.
12514 2002-03-01 Ravi Pratap <ravi@ximian.com>
12516 * cs-parser.jay (member_access): Change the case for pre-defined types
12517 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12520 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12523 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12524 essentially like methods and apply attributes like MethodImplOptions to them too.
12526 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
12529 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
12530 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
12533 * Update code everywhere accordingly.
12535 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
12537 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
12539 2002-02-28 Ravi Pratap <ravi@ximian.com>
12541 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
12542 try performing lookups against those instead of jumping straight into using
12543 the 'using' clauses.
12545 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
12547 (LookupType): Perform lookups in implicit parents too.
12549 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
12550 sequence as RootContext.LookupType.
12552 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
12553 the various cases of namespace lookups into this method.
12555 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12557 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
12558 in positional arguments)
12560 * class.cs (Operator): Update the AllowedModifiers to contain
12563 * cs-parser.jay: Update operator declaration to allow for the
12564 operator body to be empty.
12566 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
12569 2002-02-27 Miguel de Icaza <miguel@ximian.com>
12571 * class.cs (Method.Emit): Label parameters.
12573 * driver.cs: Return 1 or 0 as the program exit code.
12575 2002-02-26 Miguel de Icaza <miguel@ximian.com>
12577 * expression.cs: Special case the `null' object when trying to
12578 auto-compute the type, as anything can be explicitly converted to
12581 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
12582 spotting this Paolo.
12584 (Expression.ImplicitNumericConversion): Perform comparissions of
12585 the type using the underlying type in the case of an enumeration
12586 rather than using the enumeration type for the compare.
12588 Cope with the underlying == type case, which is not possible to
12591 (Expression.ConvertNumericExplicit): Perform comparissions of
12592 the type using the underlying type in the case of an enumeration
12593 rather than using the enumeration type for the compare.
12595 * driver.cs: If the user does not supply an extension, assume .exe
12597 * cs-parser.jay (if_statement): Rewrote so that we can track the
12598 location for the if statement.
12600 * expression.cs (Binary.ConstantFold): Only concat strings when
12601 the operation is "+", not everything ;-)
12603 * statement.cs (Statement.EmitBoolExpression): Take a location
12605 (If, While, Do): Track location.
12607 * expression.cs (Binary.ResolveOperator): In the object + string
12608 case, I was missing a call to ConvertImplicit
12610 2002-02-25 Ravi Pratap <ravi@ximian.com>
12612 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
12613 Location arguments. Ensure we use RootContext.LookupType to do our work
12614 and not try to do a direct Type.GetType and ModuleBuilder.GetType
12616 * interface.cs (PopulateMethod): Handle the type of the parameter being
12619 * expression.cs (Invocation.BetterFunction): Handle the case when we
12620 have a params method with no fixed arguments and a call is made with no
12623 2002-02-25 Miguel de Icaza <miguel@ximian.com>
12625 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
12626 the verbatim-string-literal
12628 * support.cs (InternalParameters.ParameterModifier): handle null
12630 (InternalParameters.ParameterType): ditto.
12632 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
12633 duplicating the name of the variable parameter.
12634 (GetParameterByName): Fix bug where we were not looking up array
12635 paramters if they were the only present (thanks Paolo!).
12636 (GetParameterInfo): We only have an empty set of types if both
12637 fixed and array are set to null.
12638 (GetParameterInfo-idx): Handle FixedParameter == null
12640 * cs-parser.jay: Handle the case where there is no catch
12641 statements (missing null test).
12643 2002-02-22 Miguel de Icaza <miguel@ximian.com>
12645 * driver.cs (MainDriver): Be conservative on our command line
12648 Catch DirectoryNotFoundException when calling GetFiles.
12650 (SplitPathAndPattern): Used to split the input specification into
12651 a path and a pattern that we can feed to Directory.GetFiles.
12653 2002-02-21 Miguel de Icaza <miguel@ximian.com>
12655 * statement.cs (Fixed): Implement the last case of the Fixed
12656 statement (string handling).
12658 * expression.cs (StringPtr): New class used to return a char * to
12659 a string; Used by the Fixed statement.
12661 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
12663 * expression.cs (Binary.ResolveOperator): Remove redundant
12664 MemberLookup pn parent type.
12665 Optimize union call, we do not need a union if the types are the same.
12666 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
12669 Specialize the use of MemberLookup everywhere, instead of using
12670 the default settings.
12672 (StackAlloc): Implement stackalloc keyword.
12674 * cs-parser.jay: Add rule to parse stackalloc.
12676 * driver.cs: Handle /h, /help, /?
12678 * expression.cs (MakeByteBlob): Removed the hacks we had in place
12679 before we supported unsafe code.
12681 * makefile: add --unsafe to the self compilation of mcs.
12683 2002-02-20 Miguel de Icaza <miguel@ximian.com>
12685 * expression.cs (PointerArithmetic): New class that is used to
12686 perform pointer arithmetic.
12687 (Binary.Resolve): Handle pointer arithmetic
12688 Handle pointer comparission.
12689 (ArrayPtr): Utility expression class that is used to take the
12690 address of an array.
12692 (ElementAccess): Implement array access for pointers
12694 * statement.cs (Fixed): Implement fixed statement for arrays, we
12695 are missing one more case before we are done.
12697 * expression.cs (Indirection): Implement EmitAssign and set the
12698 ExprClass to Variable. This allows pointer dereferences to be
12699 treated as variables, and to have values assigned to them.
12701 * ecore.cs (Expression.StoreFromPtr): New utility function to
12702 store values dereferencing.
12704 2002-02-20 Ravi Pratap <ravi@ximian.com>
12706 * expression.cs (Binary.ResolveOperator): Ensure that we are
12707 not trying to operate on a void type - this fixes the reported
12710 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
12711 the parent implementation is sealed.
12713 * ../errors/cs0239.cs : Add.
12715 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
12717 * typemanager.cs (unverifiable_code_type): Corresponds to
12718 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
12719 which have unsafe code in them.
12721 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
12724 2002-02-19 Miguel de Icaza <miguel@ximian.com>
12726 * cs-tokenizer.cs: Add support for @"litreal strings"
12728 Make tokenizer accept pre-processor directives
12729 on any column (remove the old C-like limitation).
12731 * rootcontext.cs (EmitCode): Emit any global attributes.
12732 (AddGlobalAttributes): Used to keep track of assembly attributes.
12734 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
12736 * cs-parser.jay: Add support for global attributes.
12738 2002-02-17 Miguel de Icaza <miguel@ximian.com>
12740 * expression.cs (Indirection): New helper class. Unary will
12741 create Indirection classes to be able to implement the
12742 IMemoryLocation interface on it.
12744 2002-02-16 Miguel de Icaza <miguel@ximian.com>
12746 * cs-parser.jay (fixed_statement): reference the right statement.
12748 * statement.cs (Fixed.Emit): Finish implementing the fixed
12749 statement for the &x case.
12751 2002-02-14 Miguel de Icaza <miguel@ximian.com>
12753 * class.cs (Property.Define, Method.Define): Remove newslot when
12756 * modifiers.cs: My use of NewSlot when `Abstract' was set was
12757 wrong. NewSlot should only be used if the `new' keyword is present.
12759 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
12760 locating our system dir. Sorry about this.
12762 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12764 * driver.cs (GetSystemDir): Compute correctly the location of our
12765 system assemblies. I was using the compiler directory instead of
12766 the library directory.
12768 2002-02-13 Ravi Pratap <ravi@ximian.com>
12770 * expression.cs (BetterFunction): Put back in what Miguel commented out
12771 since it is the correct fix. The problem is elsewhere ;-)
12773 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
12774 parameters of the parms method are themselves compatible or not !
12776 (StandardConversionExists): Fix very dangerous bug where we were forgetting
12777 to check that a class implements an interface before saying that an implicit
12778 conversion was allowed. Use ImplementsInterface to do the checking.
12780 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12782 * class.cs (Method.Define): Track whether we are an explicit
12783 implementation or not. And only call DefineMethodOverride if we
12784 are an explicit implementation.
12786 (Property.DefineMethod): Ditto.
12788 2002-02-11 Ravi Pratap <ravi@ximian.com>
12790 * expression.cs (BetterFunction): Catch hideous bug which was
12791 preventing us from detecting ambiguous calls due to implicit casts i.e
12794 2002-01-29 Miguel de Icaza <miguel@ximian.com>
12796 * support.cs (Pair): Remove un-needed method. I figured why I was
12797 getting the error in cs-parser.jay, the variable in a foreach loop
12798 is readonly, and the compiler does not really treat this as a variable.
12800 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
12801 instead of EQUALS in grammar.
12803 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
12805 * expression.cs (Unary.DoResolve): Check whether the argument is
12808 2002-01-28 Miguel de Icaza <miguel@ximian.com>
12810 * support.cs: Api for Pair to set a value. Despite the fact that
12811 the variables are public the MS C# compiler refuses to compile
12812 code that accesses the field if the variable is part of a foreach
12815 * statement.cs (Fixed): Begin implementation of the fixed
12818 (Block.AddVariable): Return the VariableInfo on success and null
12819 on failure instead of true/false.
12821 * cs-parser.jay (foreach): Catch errors on variables already
12822 defined (we were ignoring this value before) and properly unwind
12823 the block hierarchy
12825 (fixed_statement): grammar for the fixed statement.
12827 2002-01-25 Miguel de Icaza <miguel@ximian.com>
12829 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
12830 pointer types to be incretemented.
12832 (SizeOf): Implement.
12834 * cs-parser.jay (pointer_member_access): Implement
12835 expr->IDENTIFIER production.
12837 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
12838 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
12841 (Unary): Implement indirection.
12843 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
12844 use in non-unsafe context).
12846 (SimpleName.DoResolve): Check for pointers in field access on safe
12849 (Expression.LoadFromPtr): Factor the load-indirect code in this
12850 function. This was duplicated in UnboxCast and ParameterReference
12852 2002-01-24 Miguel de Icaza <miguel@ximian.com>
12854 * expression.cs (ComposedCast): report an error if a pointer cast
12855 is used in a safe region.
12857 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
12858 pointer type casts in unsafe context.
12860 * codegen.cs (EmitContext): Set up IsUnsafe.
12862 * cs-parser.jay (non_expression_type): Add productions for pointer
12865 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
12866 code. We should not use force into static mode if the method is
12867 not virtual. Fixes bug in MIS
12869 * statement.cs (Do.Emit, While.Emit, For.Emit,
12870 Statement.EmitBoolExpression): Add support to Do and While to
12871 propagate infinite loop as `I do return' semantics.
12873 Improve the For case to also test for boolean constants.
12875 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
12876 to the list of attributes we can add.
12878 Remove `EmitContext' argument.
12880 * class.cs (Method.Define): Apply parameter attributes.
12881 (Constructor.Define): Apply parameter attributes.
12882 (MethodCore.LabelParameters): Move here the core of labeling
12885 * support.cs (ReflectionParameters.ParameterModifier,
12886 InternalParameters.ParameterModifier): Use IsByRef on the type and
12887 only return the OUT bit for these parameters instead of in/out/ref
12890 This is because I miss-understood things. The ParameterInfo.IsIn
12891 and IsOut represent whether the parameter has the [In] and [Out]
12894 2002-01-22 Miguel de Icaza <miguel@ximian.com>
12896 * ecore.cs (FieldExpr.Emit): Release temporaries.
12898 * assign.cs (LocalTemporary.Release): new function.
12900 * codegen.cs (EmitContext.GetTemporaryStorage,
12901 EmitContext.FreeTemporaryStorage): Rework the way we deal with
12902 temporary storage. Now we can "put back" localbuilders when we
12905 2002-01-21 Miguel de Icaza <miguel@ximian.com>
12907 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
12908 need to make a copy of the variable to generate verifiable code.
12910 2002-01-19 Miguel de Icaza <miguel@ximian.com>
12912 * driver.cs: Compute dynamically the system directory.
12914 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
12915 Slower, but more generally useful. Used by the abstract
12916 registering implementation.
12918 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
12919 the rules for the special rule on Type/instances. First check if
12920 we have the same name, and if so, try that special static path
12921 rather than the instance path.
12923 2002-01-18 Miguel de Icaza <miguel@ximian.com>
12925 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
12928 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
12929 Enum, ValueType, Delegate or Array for non-corlib compiles.
12931 * cs-tokenizer.cs: Catch long identifiers (645)
12933 * typemanager.cs (IndexerPropetyName): Ravi never tested this
12936 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
12937 fix, we were returning too early, so we were not registering
12938 pending methods from abstract classes.
12940 Do not register pending methods if the class is abstract.
12942 * expression.cs (Conditional.DoResolve): Report circular implicit
12943 conversions when we neecd to compute it for conditional
12946 (Is.DoResolve): If the expression is always of the provided type,
12947 flag warning 183. If the expression can not ever be of the
12948 provided type flag warning 184.
12950 * class.cs: Catch 169 as well.
12952 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
12955 2002-01-18 Nick Drochak <ndrochak@gol.com>
12957 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
12959 2002-01-17 Miguel de Icaza <miguel@ximian.com>
12961 * interface.cs: (PopulateMethod): Check for pointers being defined
12962 only if the unsafe context is active.
12963 (PopulateProperty): ditto.
12964 (PopulateIndexer): ditto.
12966 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
12967 specified. If pointers are present, make sure that they are
12968 present in an unsafe context.
12969 (Constructor, Constructor.Define): ditto.
12970 (Field, Field.Define): ditto.
12971 (Property, Property.Define): ditto.
12972 (Event, Event.Define): ditto.
12974 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
12975 hashtable if there are classes or structs defined.
12977 * expression.cs (LocalVariableReference.DoResolve): Simplify this
12978 code, as the constant resolution moved.
12980 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
12981 the metadata, so we can flag error 133.
12983 * decl.cs (MemberCore.UnsafeOK): New function to test that a
12984 pointer is being declared in an unsafe context.
12986 2002-01-16 Miguel de Icaza <miguel@ximian.com>
12988 * modifiers.cs (Modifiers.Check): Require a Location argument.
12989 Report error 227 for Unsafe use.
12991 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
12993 * statement.cs (For.Emit): If the test is null, then report that
12994 we do `return', as we wont reach anything afterwards.
12996 (Switch.SwitchGoverningType): Track the expression that matched
12999 * driver.cs: Allow negative numbers as an error code to flag.
13001 * cs-parser.jay: Handle 1551.
13003 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13005 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13007 * cs-parser.jay: Report 1518 (type declaration can only contain
13008 class, struct, interface, enum or delegate)
13010 (switch_label): Report 1523 (keywords `case' or `default' must
13013 (opt_switch_sections): Report 1522 (empty switch)
13015 * driver.cs: Report 1515 (response file specified multiple times)
13016 Report 1516 (Source file specified multiple times).
13018 * expression.cs (Argument.Resolve): Signal 1510
13020 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13021 access not allowed in static code)
13023 2002-01-11 Ravi Pratap <ravi@ximian.com>
13025 * typemanager.cs (IsPointerType): Utility method which we are going
13028 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13029 the object type, so we take care of that.
13031 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13033 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13034 added to non-params parameters :-)
13036 * typemanager.cs (CSharpName): Include 'void' type too.
13038 (void_ptr_type): Include in the set of core types.
13040 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13043 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13046 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13047 completely forgotten about it.
13049 2002-01-10 Ravi Pratap <ravi@ximian.com>
13051 * cs-parser.jay (pointer_type): Add. This begins our implementation
13052 of parsing rules for unsafe code.
13054 (unsafe_statement): Implement.
13056 (embedded_statement): Modify to include the above.
13058 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13060 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13061 if the current context is an unsafe one.
13063 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13064 are handled differently, we need separate rules for them.
13066 (local_variable_declaration): Update to use local_variable_pointer_type
13067 to allow variable declarations of unmanaged pointer types.
13069 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13070 in unsafe contexts.
13072 * ../errors/cs0214.cs : Add.
13074 2002-01-16 Nick Drochak <ndrochak@gol.com>
13076 * makefile: remove 'response' file when cleaning.
13078 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13080 * cs-parser.jay: Report 1524.
13082 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13084 * typemanager.cs (RegisterMethod): drop checking if we have
13085 registered this from here
13087 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13089 * class.cs (Method.EmitDestructor): Implement calling our base
13092 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13093 value of InFinally.
13095 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13096 this routine and will wrap the call in a try/catch block. Deal
13099 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13101 * ecore.cs (Expression.MemberLookup): instead of taking a
13102 parameter `same_type' that was used to tell whether we could
13103 access private members we compute our containing type from the
13106 (FieldExpr): Added partial support for volatile fields. This does
13107 not work for volatile fields exposed from assemblies, as I can not
13108 figure out how to extract the modreq from it.
13110 Updated all the source files to use this.
13112 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13113 because it is referenced by MemberLookup very often.
13115 2002-01-09 Ravi Pratap <ravi@ximian.com>
13117 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13118 TypeBuilder.GetCustomAttributes to retrieve what we need.
13120 Get rid of redundant default_member_attr_type as this is the same as
13121 default_member_type which already exists.
13123 * interface.cs, attribute.cs : Update accordingly.
13125 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13127 * typemanager.cs: Enable IndexerPropertyName again. It does not
13128 work for TYpeBuilders though. Ravi, can you please fix this?
13130 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13132 * expression.cs (Argument.Emit): Handle the case of ref objects
13133 being passed to ref functions;
13135 (ParameterReference.EmitLoad): Loads the content of the pointer
13136 without dereferencing.
13138 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13140 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13142 2002-01-08 Ravi Pratap <ravi@ximian.com>
13144 * class.cs (Indexer.DefineMethod): Incorporate the interface
13145 type in the name of the method if we are doing explicit interface
13148 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13150 (BetterConversion): Fix extremely trivial bug where we were referring to
13151 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13154 * ../errors/bug16.cs : Add although we have fixed it.
13156 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13158 * expression.cs (BaseIndexer): Begin implementation.
13160 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13162 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13163 production directly to remove a shift/reduce, and implement
13164 explicit interface implementation.
13166 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13167 after a floating point suffix.
13169 * expression.cs (DoNumericPromotions): Improved the conversion for
13170 uint/uint. If we have a constant, we avoid doing a typecast to a
13173 * class.cs (Indexer): Implement explicit interface implementation
13176 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13178 * class.cs: make the default instance constructor public and hidebysig.
13180 2001-01-03 Ravi Pratap <ravi@ximian.com>
13182 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13183 so we can call it from elsewhere.
13185 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13186 we emit it internally if the class has a defined indexer; otherwise the user
13187 emits it by decorating the class definition with the DefaultMemberAttribute.
13189 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13190 attribute is not used on a type which defines an indexer.
13192 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13193 character when we skip whitespace.
13195 * ../errors/cs0646.cs : Add.
13197 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13199 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13202 * makefile: Add practical target `mcs3.exe' which builds the third
13203 generation compiler.
13205 * expression.cs (New): Fix structures constructor calling.
13207 * class.cs (Property, Method, Indexer): Emit Final flag on the
13208 method if we are an interface implementation and we are not
13211 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13212 whether this property is referencing a `base' method.
13214 * expression.cs (Invocation.EmitCall): take an extra argument:
13215 is_base, this is used to determine whether the `call' or
13216 `callvirt' opcode should be used.
13219 * delegate.cs: update EmitCall.
13221 * class.cs (Method.Define): Set NewSlot for the cases where we are
13222 not implementing an interface method.
13224 (Property.Define): ditto.
13226 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13228 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13229 'r'. Allows mcs to parse itself fully.
13231 2002-01-02 Ravi Pratap <ravi@ximian.com>
13233 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13234 of the number of initializers that require the InitializeArray method.
13236 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13237 update the above field where necessary.
13239 (MakeByteBlob): Update accordingly.
13241 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13244 (EmitDynamicInitializers): Update in accordance with the new optimization.
13246 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13247 same OpCode applies.
13249 * cs-parser.jay : Fix some glaring errors I introduced.
13251 2002-01-01 Ravi Pratap <ravi@ximian.com>
13253 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13254 so that we can check for name clashes there too.
13256 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13257 for interface indexers.
13259 * interfaces.cs (Define): Emit the default member attribute.
13261 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13262 variable was being referred to while setting the value ;-)
13264 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13266 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13267 byte-by-byte information when we know the data is zero.
13269 Make the block always a multiple of 4, because
13270 DefineInitializedData has a bug.
13272 * assign.cs: Fix, we should assign from the temporary, not from
13275 * expression.cs (MakeByteBlob): Fix my incorrect code.
13277 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13279 * typemanager.cs (EnumToUnderlying): This function is used to get
13280 the underlying type from an enumeration, because it does not
13283 * constant.cs: Use the I4_S form for values between -128 and 127.
13285 * statement.cs (Block.LookupLabel): Looks up a label.
13286 (Block): Drop support for labeled blocks.
13288 (LabeledStatement): New kind of statement that represents a label
13291 (Goto): Finally implement this bad boy.
13293 * cs-parser.jay: Update to reflect new mechanism to implement
13296 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13298 * codegen.cs (EmitContext.This): a codegen property that keeps the
13299 a single instance of this instead of creating many different this
13302 * delegate.cs (Delegate.DoResolve): Update to use the property;
13304 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13306 * expression.cs (BaseAccess.DoResolve): Ditto.
13308 2001-12-29 Ravi Pratap <ravi@ximian.com>
13310 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13311 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13313 (InitCoreTypes): Update accordingly.
13315 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13316 so we can quickly store the state.
13318 (ApplyAttributes): Set the correct implementation flags
13319 for InternalCall methods.
13321 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13323 * expression.cs (EmitCall): if a method is not virtual, then do
13324 not use callvirt on it.
13326 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13327 user defined stuff) requires the use of stobj, which takes an
13328 address on the stack instead of an array and an index. So emit
13329 the Ldelema operation for it.
13331 (EmitStoreOpcode): Use stobj for valuetypes.
13333 (UnaryMutator.EmitCode): Use the right 1 value depending on
13334 whether we are dealing with int64/uint64, float or doubles.
13336 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13337 constructors that I implemented last night.
13339 (Constructor.IsDefault): Fix to work properly for static
13342 * cs-parser.jay (CheckDef): report method signature errors.
13343 Update error number 103 to be 132.
13345 * decl.cs: New AdditionResult enumeration value: MethodExists.
13346 Although we do this check for methods later on in the semantic
13347 analysis, catching repeated default constructors is so easy that
13348 we catch these here.
13350 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13353 (ParameterReference.EmitAssign, Emit): handle
13356 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13357 (ArrayAccess.EmitStoreOpcode): ditto.
13359 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13361 * expression.cs (MakeByteBlob): Complete all the missing types
13362 (uint, short, ushort, byte, sbyte)
13364 * class.cs: Only init instance field initializers on instance
13367 Rename `constructors' to instance_constructors.
13369 (TypeContainer.AddConstructor): Only add constructors to the list
13370 if it is not static.
13372 Make sure that we handle default_static_constructor independently
13373 everywhere where we handle instance_constructors
13375 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13377 * class.cs: Do not lookup or create a base initializer for a
13378 static constructor.
13380 (ConstructorInitializer.Resolve): use the proper type to lookup
13383 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13385 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13388 * decl.cs: CloseType is now an virtual method, the default
13389 implementation just closes this type.
13391 2001-12-28 Ravi Pratap <ravi@ximian.com>
13393 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13394 to PreserveSig by default. Also emit HideBySig on such methods.
13396 Basically, set the defaults to standard values.
13398 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13399 argument, if candidate is better, it can't be worse than the best !
13401 (Invocation): Re-write bits to differentiate between methods being
13402 applicable in their expanded form and their normal form - for params
13405 Get rid of use_standard everywhere as only standard conversions are allowed
13406 in overload resolution.
13408 More spec conformance.
13410 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13412 * driver.cs: Add --timestamp, to see where the compiler spends
13415 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13416 `this' in static code.
13418 (SimpleName.DoResolve): Implement in terms of a helper function
13419 that allows static-references to be passed upstream to
13422 (Expression.ResolveWithSimpleName): Resolve specially simple
13423 names when called by MemberAccess to implement the special
13426 (Expression.ImplicitReferenceConversion): Handle conversions from
13427 Null to reference types before others, as Null's type is
13430 * expression.cs (Invocation.EmitCall): Handle the special case of
13431 calling methods declared on a reference type from a ValueType
13432 (Base classes System.Object and System.Enum)
13434 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13435 the left hand side is a TypeExpr, not on every enumeration.
13437 (Binary.Resolve): If types are reference types, then do a cast to
13438 object on operators != and == of both arguments.
13440 * typemanager.cs (FindMembers): Extract instance and static
13441 members if requested.
13443 * interface.cs (PopulateProperty): Use void_type instead of null
13444 as the return type for the setter method.
13446 (PopulateIndexer): ditto.
13448 2001-12-27 Ravi Pratap <ravi@ximian.com>
13450 * support.cs (ReflectionParameters): Fix minor bug where we
13451 were examining the wrong parameter for the ParamArray attribute.
13453 Cope with requests for the type of the parameter at position
13454 greater than the params parameter's. We now return the element
13455 type of the params array as that makes more sense.
13457 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13458 accordingly as we no longer have to extract the element type
13461 (Invocation.OverloadResolve): Update.
13463 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13465 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13466 against IEnumerator, test whether the return value is a descendant
13467 of the IEnumerator interface.
13469 * class.cs (Indexer.Define): Use an auxiliary method to implement
13470 the other bits of the method definition. Begin support for
13471 explicit interface implementation.
13473 (Property.DefineMethod): Use TypeManager.void_type instead of null
13474 for an empty return value.
13476 2001-12-26 Miguel de Icaza <miguel@ximian.com>
13478 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
13479 dealing with a FieldExpr which is composed of a FieldBuilder, in
13480 the code path we did extract the constant, but we should have
13481 obtained the underlying value to be able to cast it (otherwise we
13482 end up in an infinite loop, this is what Ravi was running into).
13484 (ArrayCreation.UpdateIndices): Arrays might be empty.
13486 (MemberAccess.ResolveMemberAccess): Add support for section
13487 14.5.4.1 that deals with the special case of E.I when E is a type
13488 and something else, that I can be a reference to a static member.
13490 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
13491 handle a particular array type to create byte blobs, it is just
13492 something we dont generate byteblobs for.
13494 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13497 * location.cs (Push): remove the key from the hashtable that we
13498 are about to add. This happens for empty files.
13500 * driver.cs: Dispose files after we have parsed them.
13502 (tokenize): new function that only runs the tokenizer on its
13503 input, for speed testing.
13505 2001-12-26 Ravi Pratap <ravi@ximian.com>
13507 * class.cs (Event.Define): Define the private field only if there
13508 are no accessors defined.
13510 * expression.cs (ResolveMemberAccess): If there is no associated
13511 field with the event, that means we have an event defined with its
13512 own accessors and we should flag error cs0070 since transforming
13513 ourselves into a field is not valid in that case.
13515 * ecore.cs (SimpleName.DoResolve): Same as above.
13517 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13518 and charset to sane values.
13520 2001-12-25 Ravi Pratap <ravi@ximian.com>
13522 * assign.cs (DoResolve): Perform check on events only if they
13523 are being accessed outside the declaring type.
13525 * cs-parser.jay (event_declarations): Update rules to correctly
13526 set the type of the implicit parameter etc.
13528 (add_accessor, remove_accessor): Set current local parameters.
13530 * expression.cs (Binary): For delegate addition and subtraction,
13531 cast the return value from the method into the appropriate delegate
13534 2001-12-24 Ravi Pratap <ravi@ximian.com>
13536 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
13537 of these as the workaround is unnecessary.
13539 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
13540 delegate data - none of that is needed at all.
13542 Re-write bits to extract the instance expression and the delegate method
13545 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
13548 * attribute.cs (ApplyAttributes): New method to take care of common tasks
13549 of attaching attributes instead of duplicating code everywhere.
13551 * everywhere : Update code to do attribute emission using the above method.
13553 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13555 * expression.cs (IsParamsMethodApplicable): if there are not
13556 parameters, return immediately.
13558 * ecore.cs: The 0 literal can be implicity converted to an enum
13561 (SimpleName.DoResolve): First lookup the type, then lookup the
13564 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
13565 want to get its address. If the InstanceExpression is not
13566 addressable, store the result in a temporary variable, then get
13569 * codegen.cs: Only display 219 errors on warning level or above.
13571 * expression.cs (ArrayAccess): Make it implement the
13572 IMemoryLocation interface.
13574 (Binary.DoResolve): handle the operator == (object a, object b)
13575 and operator != (object a, object b) without incurring into a
13576 BoxedCast (because 5 != o should never be performed).
13578 Handle binary enumerator operators.
13580 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
13581 value type, otherwise use Ldelem_ref.
13583 Use precomputed names;
13585 (AddressOf): Implement address of
13587 * cs-parser.jay (labeled_statement): Fix recursive block
13588 addition by reworking the production.
13590 * expression.cs (New.DoEmit): New has a special case:
13592 If we are dealing with a ValueType, we have a few
13593 situations to deal with:
13595 * The target of New is a ValueType variable, that is
13596 easy, we just pass this as the variable reference
13598 * The target of New is being passed as an argument,
13599 to a boxing operation or a function that takes a
13602 In this case, we need to create a temporary variable
13603 that is the argument of New.
13606 2001-12-23 Ravi Pratap <ravi@ximian.com>
13608 * rootcontext.cs (LookupType): Check that current_type is not null before
13609 going about looking at nested types.
13611 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
13612 not implement the IAssignMethod interface any more.
13614 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
13615 where we tranform them into FieldExprs if they are being resolved from within
13616 the declaring type.
13618 * ecore.cs (SimpleName.DoResolve): Do the same here.
13620 * assign.cs (DoResolve, Emit): Clean up code considerably.
13622 * ../errors/bug10.cs : Add.
13624 * ../errors/cs0070.cs : Add.
13626 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
13628 * assign.cs : Get rid of EventIsLocal everywhere.
13630 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13632 * ecore.cs (ConvertIntLiteral): finished the implementation.
13634 * statement.cs (SwitchLabel): Convert the value we are using as a
13635 key before looking up the table.
13637 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13639 * codegen.cs (EmitTopBlock): Require a Location argument now.
13641 * cs-parser.jay (constructor_declarator): We need to setup
13642 current_local_parameters before we parse the
13643 opt_constructor_initializer, to allow the variables to be bound
13644 to the constructor arguments.
13646 * rootcontext.cs (LookupType): First lookup nested classes in our
13647 class and our parents before we go looking outside our class.
13649 * expression.cs (ConstantFold): Extract/debox the values at the
13652 * rootcontext.cs (EmitCode): Resolve the constants first before we
13653 resolve the types. This is not really needed, but it helps debugging.
13655 * statement.cs: report location.
13657 * cs-parser.jay: pass location to throw statement.
13659 * driver.cs: Small bug fix.
13661 * report.cs: Updated format to be 4-zero filled digits.
13663 2001-12-22 Ravi Pratap <ravi@ximian.com>
13665 * expression.cs (CheckIndices): Fix minor bug where the wrong
13666 variable was being referred to ;-)
13668 (DoEmit): Do not call EmitStaticInitializers when the
13669 underlying type is System.Object.
13671 2001-12-21 Ravi Pratap <ravi@ximian.com>
13673 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
13674 and do the usual workaround for SRE.
13676 * class.cs (MyEventBuilder.EventType): New member to get at the type
13677 of the event, quickly.
13679 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
13681 * assign.cs (Assign.DoResolve): Handle the case when the target
13682 is an EventExpr and perform the necessary checks.
13684 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
13687 (SimpleName.MemberStaticCheck): Include check for EventExpr.
13689 (EventExpr): Set the type in the constructor itself since we
13690 are meant to be born fully resolved.
13692 (EventExpr.Define): Revert code I wrote earlier.
13694 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
13695 instance expression is null. The instance expression is a This in that case
13696 or a null, depending on whether it is a static method or not.
13698 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
13699 refers to more than one method.
13701 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
13702 and accordingly flag errors.
13704 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13706 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
13708 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13710 * location.cs (ToString): Provide useful rutine.
13712 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13714 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
13715 objects, return the actual integral boxed.
13717 * statement.cs (SwitchLabel): define an ILLabel for each
13720 (Switch.CheckSwitch): If the value is a Literal, extract
13721 the underlying literal.
13723 Also in the unused hashtable we had, add the SwitchLabel so we can
13724 quickly look this value up.
13726 * constant.cs: Implement a bunch of new constants. Rewrite
13727 Literal based on this. Made changes everywhere to adapt to this.
13729 * expression.cs (Expression.MakeByteBlob): Optimize routine by
13730 dereferencing array only once, and also copes with enumrations.
13732 bytes are two bytes wide, not one.
13734 (Cast): Perform constant conversions.
13736 * ecore.cs (TryImplicitIntConversion): Return literals instead of
13737 wrappers to the literals here.
13739 * expression.cs (DoNumericPromotions): long literals can converted
13740 to ulong implicity (this is taken care of elsewhere, but I was
13741 missing this spot).
13743 * ecore.cs (Expression.Literalize): Make the return type Literal,
13744 to improve type checking.
13746 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
13748 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13750 * literal.cs: Revert code from ravi that checked the bounds. The
13751 bounds are sane by the definition of the type itself.
13753 * typemanager.cs: Fix implementation of ImplementsInterface. We
13754 need to actually look up in our parent hierarchy for interfaces
13757 * const.cs: Use the underlying type for enumerations
13759 * delegate.cs: Compute the basename for the delegate creation,
13760 that should fix the delegate test case, and restore the correct
13761 Type Lookup semantics in rootcontext
13763 * rootcontext.cs: Revert Ravi's last patch. The correct way of
13764 referencing a nested type with the Reflection API is using the "+"
13767 * cs-parser.jay: Do not require EOF token at the end.
13769 2001-12-20 Ravi Pratap <ravi@ximian.com>
13771 * rootcontext.cs (LookupType): Concatenate type names with
13772 a '.' instead of a '+' The test suite passes again.
13774 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
13775 field of the enumeration.
13777 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
13778 the case when the member is an EventExpr.
13780 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
13781 static has an associated instance expression.
13783 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
13785 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
13787 * class.cs (Event.Define): Register event and perform appropriate checks
13790 We define the Add and Remove methods even if the use provides none because
13791 in that case, we provide default implementations ourselves.
13793 Define a private field of the type of the event. This is done by the CSC compiler
13794 and we should be doing it too ;-)
13796 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
13797 More methods we use in code we generate.
13799 (multicast_delegate_type, delegate_type): Two separate types since the distinction
13802 (InitCoreTypes): Update accordingly for the above.
13804 * class.cs (Event.Emit): Generate code for default accessors that we provide
13806 (EmitDefaultMethod): Do the job in the above.
13808 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
13811 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13813 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
13814 builders even if we were missing one.
13816 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
13817 pass the Basename as our class name instead of the Name. The
13818 basename will be correctly composed for us.
13820 * parameter.cs (Paramters): Now takes a Location argument.
13822 * decl.cs (DeclSpace.LookupType): Removed convenience function and
13823 make all the code call directly LookupType in RootContext and take
13824 this chance to pass the Location information everywhere.
13826 * Everywhere: pass Location information.
13828 2001-12-19 Miguel de Icaza <miguel@ximian.com>
13830 * class.cs (Constructor.Define): Updated way of detecting the
13831 length of the parameters.
13833 (TypeContainer.DefineType): Use basename as the type name for
13836 (TypeContainer.Define): Do not recursively define types here, as
13837 definition is taken care in order by the RootContext.
13839 * tree.cs: Keep track of namespaces in a per-file basis.
13841 * parameter.cs (Parameter.ComputeSignature): Update to use
13844 (Parameters.GetSignature): ditto.
13846 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
13847 instead of a TypeContainer.
13849 (Interface.SemanticAnalysis): Use `this' instead of our parent to
13850 resolve names. Because we need to be resolve in our context, not
13853 * driver.cs: Implement response files.
13855 * class.cs (TypeContainer.DefineType): If we are defined, do not
13856 redefine ourselves.
13858 (Event.Emit): Emit the code for add/remove handlers.
13859 (Event.Define): Save the MethodBuilders for add/remove.
13861 * typemanager.cs: Use pair here too.
13863 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
13864 DictionaryEntry requires the first argument to be non-null.
13866 (enum_declaration): Compute full name for registering the
13869 (delegate_declaration): Instead of using
13870 formal_parameter_list, use opt_formal_parameter_list as the list
13873 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
13874 (EventParsing): New property that controls whether `add' and
13875 `remove' are returned as tokens or identifiers (for events);
13877 2001-12-19 Ravi Pratap <ravi@ximian.com>
13879 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
13880 use MyEventBuilder only and let it wrap the real builder for us.
13882 (MyEventBuilder): Revamp constructor etc.
13884 Implement all operations that we perform on EventBuilder in precisely the same
13887 (FindMembers): Update to use the EventBuilder member.
13889 (Event.Emit): Update accordingly.
13891 2001-12-18 Ravi Pratap <ravi@ximian.com>
13893 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
13894 by calling the appropriate methods.
13896 (GetCustomAttributes): Make stubs as they cannot possibly do anything
13899 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
13901 2001-12-17 Ravi Pratap <ravi@ximian.com>
13903 * delegate.cs (Delegate.Populate): Check that the return type
13904 and various parameters types are indeed accessible.
13906 * class.cs (Constructor.Define): Same here.
13908 (Field.Define): Ditto.
13910 (Event.Define): Ditto.
13912 (Operator.Define): Check that the underlying Method defined itself
13913 correctly - so it's MethodBuilder should not be null.
13915 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
13916 expression happens to be null.
13918 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
13919 members but as of now we don't seem to be able to do anything really useful with it.
13921 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
13922 not the EventBuilder.
13924 2001-12-18 Miguel de Icaza <miguel@ximian.com>
13926 * cs-tokenizer.cs: Add support for defines.
13927 Add support for #if, #elif, #else, #endif
13929 (eval_var): evaluates a variable.
13930 (eval): stubbed for evaluating functions.
13932 * cs-parser.jay: Pass the defines information
13934 * driver.cs: Add --define command line option.
13936 * decl.cs: Move MemberCore here.
13938 Make it the base class for DeclSpace. This allows us to catch and
13939 report 108 and 109 for everything now.
13941 * class.cs (TypeContainer.Define): Extract all the members
13942 before populating and emit the warning 108 (new keyword required
13943 to override) instead of having each member implement this.
13945 (MemberCore.Define): New abstract method, we will be using this in
13946 the warning reporting engine in Populate.
13948 (Operator.Define): Adjust to new MemberCore protocol.
13950 * const.cs (Const): This does not derive from Expression, it is a
13951 temporary object we use to create fields, it is a MemberCore.
13953 * class.cs (Method.Define): Allow the entry point to be in a
13956 * driver.cs: Rewrite the argument handler to clean it up a bit.
13958 * rootcontext.cs: Made it just an auxiliary namespace feature by
13959 making everything static.
13961 * driver.cs: Adapt code to use RootContext type name instead of
13964 * delegate.cs: Remove RootContext argument.
13966 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
13969 * class.cs (Event.Define): The lookup can fail.
13971 * cs-tokenizer.cs: Begin implementation of pre-procesor.
13973 * expression.cs: Resolve the this instance before invoking the code.
13975 2001-12-17 Miguel de Icaza <miguel@ximian.com>
13977 * cs-parser.jay: Add a production in element_access that allows
13978 the thing to become a "type" reference. This way we can parse
13979 things like "(string [])" as a type.
13981 Note that this still does not handle the more complex rules of
13985 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
13987 * ecore.cs: (CopyNewMethods): new utility function used to
13988 assemble the list of methods from running FindMembers.
13990 (MemberLookup): Rework FindMembers so that
13992 2001-12-16 Miguel de Icaza <miguel@ximian.com>
13994 * class.cs (TypeContainer): Remove Delegates who fail to be
13997 * delegate.cs (Populate): Verify that we dont get null return
13998 values. TODO: Check for AsAccessible.
14000 * cs-parser.jay: Use basename to emit error 574 (destructor should
14001 have the same name as container class), not the full name.
14003 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14004 possible representation.
14006 Also implements integer type suffixes U and L.
14008 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14010 * expression.cs (ArrayCreation.DoResolve): We need to do the
14011 argument resolution *always*.
14013 * decl.cs: Make this hold the namespace. Hold the root context as
14015 (LookupType): Move here.
14017 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14019 * location.cs (Row, Name): Fixed the code, it was always returning
14020 references to the first file.
14022 * interface.cs: Register properties defined through interfaces.
14024 * driver.cs: Add support for globbing on the command line
14026 * class.cs (Field): Make it derive from MemberCore as well.
14029 2001-12-15 Ravi Pratap <ravi@ximian.com>
14031 * class.cs (Event::Define): Check that the type of the event is a delegate
14032 type else flag error #66.
14034 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14037 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14038 values of EntryPoint, CharSet etc etc.
14040 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14042 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14043 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14044 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14045 which needs this to do its work.
14047 * ../errors/cs0066.cs : Add.
14049 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14051 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14054 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14055 clears out the parameters field.
14056 (MemberSignatureCompare): Cleanup
14058 (MemberCore): New base class used to share code between MethodCore
14061 (RegisterRequiredImplementations) BindingFlags.Public requires
14062 either BindingFlags.Instace or Static. Use instance here.
14064 (Property): Refactored code to cope better with the full spec.
14066 * parameter.cs (GetParameterInfo): Return an empty array instead
14069 * class.cs (Property): Abstract or extern properties have no bodies.
14071 * parameter.cs (GetParameterInfo): return a zero-sized array.
14073 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14074 method modifier validation to the typecontainer so we can reuse
14075 this on properties.
14077 (MethodCore.ParameterTypes): return an empty sized array of types.
14079 (Property.Define): Test property modifier validity.
14081 Add tests for sealed/override too.
14083 (Method.Emit): abstract or extern methods have no bodies.
14085 2001-12-14 Ravi Pratap <ravi@ximian.com>
14087 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14090 (Method::Define, ::Emit): Modify accordingly.
14092 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14094 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14096 * makefile: Pass in /unsafe.
14098 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14100 * class.cs (MakeKey): Kill routine.
14102 * class.cs (TypeContainer.Define): Correctly define explicit
14103 method implementations (they require the full interface name plus
14106 * typemanager.cs: Deply the PtrHashtable here and stop using the
14107 lame keys. Things work so much better.
14109 This of course broke everyone who depended on `RegisterMethod' to
14110 do the `test for existance' test. This has to be done elsewhere.
14112 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14113 the object stupid Equals method (because, that like fails all over
14114 the place). We still do not use it.
14116 * class.cs (TypeContainer.SetRequiredInterface,
14117 TypeContainer.RequireMethods): Killed these two routines and moved
14118 all the functionality to RegisterRequiredImplementations.
14120 (TypeContainer.RegisterRequiredImplementations): This routine now
14121 registers all the implementations required in an array for the
14122 interfaces and abstract methods. We use an array of structures
14123 which can be computed ahead of time to reduce memory usage and we
14124 also assume that lookups are cheap as most classes will not
14125 implement too many interfaces.
14127 We also avoid creating too many MethodSignatures.
14129 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14130 clear the "pending" bit if we find that there are problems with
14133 (TypeContainer.VerifyPendingMethods): Update to report errors of
14134 methods that look like implementations but are not.
14136 (TypeContainer.Define): Add support for explicit interface method
14139 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14141 * typemanager.cs: Keep track of the parameters here instead of
14142 being a feature of the TypeContainer.
14144 * class.cs: Drop the registration of parameters here, as
14145 InterfaceMethods are also interface declarations.
14147 * delegate.cs: Register methods with the TypeManager not only with
14148 the TypeContainer. This code was buggy.
14150 * interface.cs: Full registation here.
14152 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14154 * expression.cs: Remove reducer for binary expressions, it can not
14157 * const.cs: Put here the code that used to go into constant.cs
14159 * constant.cs: Put here the code for constants, this is a new base
14160 class for Literals.
14162 * literal.cs: Make Literal derive from Constant.
14164 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14166 * statement.cs (Return.Emit): Report error 157 if the user
14167 attempts to return from a finally block.
14169 (Return.Emit): Instead of emitting a return, jump to the end of
14172 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14173 LocalBuilder to store the result of the function. ReturnLabel is
14174 the target where we jump.
14177 2001-12-09 Radek Doulik <rodo@ximian.com>
14179 * cs-parser.jay: remember alias in current namespace
14181 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14184 * class.cs (LookupAlias): lookup alias in my_namespace
14186 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14188 (LookupAlias): lookup alias in this and if needed in parent
14191 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14195 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14196 making things static. I need this to avoid passing the
14197 TypeContainer when calling ParameterType.
14199 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14200 that did string manipulation to compute the type and then call
14201 GetType. Use Parameter.ParameterType instead.
14203 * cs-tokenizer.cs: Consume the suffix for floating values.
14205 * expression.cs (ParameterReference): figure out whether this is a
14206 reference parameter or not. Kill an extra variable by computing
14207 the arg_idx during emission.
14209 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14210 function that returns whether a parameter is an out/ref value or not.
14212 (Parameter.ParameterType): The type of the parameter (base,
14213 without ref/out applied).
14215 (Parameter.Resolve): Perform resolution here.
14216 (Parameter.ExternalType): The full type (with ref/out applied).
14218 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14219 support for expressions on the using statement.
14221 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14223 * statement.cs (Using.EmitLocalVariableDecls): Split the
14224 localvariable handling of the using statement.
14226 (Block.EmitMeta): Keep track of variable count across blocks. We
14227 were reusing slots on separate branches of blocks.
14229 (Try.Emit): Emit the general code block, we were not emitting it.
14231 Check the type of the declaration to be an IDisposable or
14232 something that can be implicity converted to it.
14234 Emit conversions if required.
14236 * ecore.cs (EmptyExpression): New utility class.
14237 (Expression.ImplicitConversionExists): New utility function.
14239 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14241 * statement.cs (Using): Implement.
14243 * expression.cs (LocalVariableReference): Support read only variables.
14245 * statement.cs: Remove the explicit emit for the Leave opcode.
14246 (VariableInfo): Add a readonly field.
14248 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14250 * ecore.cs (ConvCast): new class used to encapsulate the various
14251 explicit integer conversions that works in both checked and
14252 unchecked contexts.
14254 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14255 properly generate the overflow opcodes.
14257 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14259 * statement.cs: The correct type for the EmptyExpression is the
14260 element_type, not the variable type. Ravi pointed this out.
14262 2001-12-04 Ravi Pratap <ravi@ximian.com>
14264 * class.cs (Method::Define): Handle PInvoke methods specially
14265 by using DefinePInvokeMethod instead of the usual one.
14267 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14268 above to do the task of extracting information and defining the method.
14270 2001-12-04 Ravi Pratap <ravi@ximian.com>
14272 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14273 of the condition for string type.
14275 (Emit): Move that here.
14277 (ArrayCreation::CheckIndices): Keep string literals in their expression
14280 (EmitDynamicInitializers): Handle strings appropriately.
14282 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14284 * codegen.cs (EmitContext): Replace multiple variables with a
14285 single pointer to the current Switch statement.
14287 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14290 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14294 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14297 (Foreach.Emit): Foreach on arrays was not setting
14298 up the loop variables (for break/continue).
14300 (GotoCase): Semi-implented.
14302 2001-12-03 Ravi Pratap <ravi@ximian.com>
14304 * attribute.cs (CheckAttribute): Handle system attributes by using
14305 Attribute.GetAttributes to examine information we need.
14307 (GetValidPlaces): Same here.
14309 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14311 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14313 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14315 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14317 (Method::Emit): Handle the case when we are a PInvoke method.
14319 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14321 * expression.cs: Use ResolveWithSimpleName on compound names.
14323 2001-12-02 Ravi Pratap <ravi@ximian.com>
14325 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14326 before trying to reduce it.
14328 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14330 * constant.cs (LookupConstantValue): Implement.
14332 (EmitConstant): Use the above in emitting the constant.
14334 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14335 that are user-defined by doing a LookupConstantValue on them.
14337 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14340 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14342 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14344 (BaseAccess.DoResolve): Implement.
14346 (MemberAccess.DoResolve): Split this routine into a
14347 ResolveMemberAccess routine that can be used independently
14349 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14351 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14352 As that share bits of the implementation. Is returns a boolean,
14353 while As returns the Type that is being probed.
14355 2001-12-01 Ravi Pratap <ravi@ximian.com>
14357 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14358 instead of a Literal - much easier.
14360 (EnumInTransit): Remove - utterly useless :-)
14362 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14364 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14366 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14367 chain when we have no associated expression.
14369 2001-11-30 Ravi Pratap <ravi@ximian.com>
14371 * constant.cs (Define): Use Location while reporting the errror.
14373 Also emit a warning when 'new' is used and there is no inherited
14376 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14379 (LookupEnumValue): Implement to lookup an enum member's value and define it
14382 (Populate): Re-write accordingly to use the above routine.
14384 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14386 * expression.cs (This): Fix prototype for DoResolveLValue to
14387 override the base class DoResolveLValue.
14389 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14392 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14393 (we need to load the address of the field here). This fixes
14396 (FieldExpr.DoResolveLValue): Call the DoResolve
14397 function to initialize the Instance expression.
14399 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14400 correctly the GetEnumerator operation on a value type.
14402 * cs-parser.jay: Add more simple parsing error catches.
14404 * statement.cs (Switch): Add support for string switches.
14405 Handle null specially.
14407 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14409 2001-11-28 Ravi Pratap <ravi@ximian.com>
14411 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14413 (declare_local_constant): New helper function.
14415 * statement.cs (AddConstant): Keep a separate record of constants
14417 (IsConstant): Implement to determine if a variable is a constant.
14419 (GetConstantExpression): Implement.
14421 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14423 * statement.cs (IsVariableDefined): Re-write.
14425 2001-11-27 Ravi Pratap <ravi@ximian.com>
14427 * class.cs (TypeContainer::FindMembers): Look for constants
14428 in the case when we are looking for MemberTypes.Field
14430 * expression.cs (MemberAccess::DoResolve): Check that in the
14431 case we are a FieldExpr and a Literal, we are not being accessed
14432 by an instance reference.
14434 * cs-parser.jay (local_constant_declaration): Implement.
14436 (declaration_statement): Implement for constant declarations.
14438 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14440 * statement.cs (Switch): Catch double defaults.
14442 (Switch): More work on the switch() statement
14443 implementation. It works for integral values now, need to finish
14447 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14449 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14450 integer literals into other integer literals. To be used by
14453 2001-11-24 Ravi Pratap <ravi@ximian.com>
14455 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14458 (EmitDynamicInitializers): Cope with the above since we extract data
14459 directly from ArrayData now.
14461 (ExpectInitializers): Keep track of whether initializers are mandatory
14464 (Bounds): Make it a hashtable to prevent the same dimension being
14465 recorded for every element in that dimension.
14467 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14470 Also fix bug which was causing the indices to be emitted in the reverse
14473 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14475 * expression.cs (ArrayCreation): Implement the bits that Ravi left
14476 unfinished. They do not work, because the underlying code is
14479 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14481 * cs-parser.jay: Remove bogus fixme.
14483 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
14484 on Switch statement.
14486 2001-11-23 Ravi Pratap <ravi@ximian.com>
14488 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
14491 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
14492 parameter. Apparently, any expression is allowed.
14494 (ValidateInitializers): Update accordingly.
14496 (CheckIndices): Fix some tricky bugs thanks to recursion.
14498 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14499 I was being completely brain-dead.
14501 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14502 and re-write acordingly.
14504 (DelegateInvocation): Re-write accordingly.
14506 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14508 (MakeByteBlob): Handle types more correctly.
14510 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14511 initialization from expressions but it is incomplete because I am a complete
14514 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14516 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14517 on If. Basically, we have to return `true' (ie, we do return to
14518 our caller) only if both branches of the if return.
14520 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14521 short-circuit operators, handle them as short circuit operators.
14523 (Cast.DoResolve): Resolve type.
14524 (Cast.Cast): Take an expression as the target type.
14526 * cs-parser.jay (cast_expression): Remove old hack that only
14527 allowed a limited set of types to be handled. Now we take a
14528 unary_expression and we resolve to a type during semantic
14531 Use the grammar productions from Rhys to handle casts (this is
14532 not complete like Rhys syntax yet, we fail to handle that corner
14533 case that C# has regarding (-x), but we will get there.
14535 2001-11-22 Ravi Pratap <ravi@ximian.com>
14537 * class.cs (EmitFieldInitializer): Take care of the case when we have a
14538 field which is an array type.
14540 * cs-parser.jay (declare_local_variables): Support array initialization too.
14542 * typemanager.cs (MakeKey): Implement.
14544 (everywhere): Use the above appropriately.
14546 * cs-parser.jay (for_statement): Update for array initialization while
14547 declaring variables.
14549 * ecore.cs : The error message was correct, it's the variable's names that
14550 were misleading ;-) Make the code more readable.
14552 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
14553 the correct type etc.
14555 (ConvertExplicit): Handle Enum types by examining the underlying type.
14557 2001-11-21 Ravi Pratap <ravi@ximian.com>
14559 * parameter.cs (GetCallingConvention): Always return
14560 CallingConventions.Standard for now.
14562 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14564 * expression.cs (Binary.ResolveOperator): Update the values of `l'
14565 and `r' after calling DoNumericPromotions.
14567 * ecore.cs: Fix error message (the types were in the wrong order).
14569 * statement.cs (Foreach.ProbeCollectionType): Need to pass
14570 BindingFlags.Instance as well
14572 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
14573 implicit int literal conversion in an empty cast so that we
14574 propagate the right type upstream.
14576 (UnboxCast): new class used to unbox value types.
14577 (Expression.ConvertExplicit): Add explicit type conversions done
14580 (Expression.ImplicitNumericConversion): Oops, forgot to test for
14581 the target type before applying the implicit LongLiterals to ULong
14584 2001-11-21 Miguel de Icaza <miguel@ximian.com>
14586 * cs-parser.jay (for_statement): Reworked the way For works: now
14587 we declare manually any variables that are introduced in
14588 for_initializer to solve the problem of having out-of-band code
14589 emition (that is what got for broken).
14591 (declaration_statement): Perform the actual variable declaration
14592 that used to be done in local_variable_declaration here.
14594 (local_variable_declaration): Do not declare anything, just pass
14595 the information on a DictionaryEntry
14597 2001-11-20 Ravi Pratap <ravi@ximian.com>
14599 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
14600 re-write of the logic to now make it recursive.
14602 (UpdateIndices): Re-write accordingly.
14604 Store element data in a separate ArrayData list in the above methods.
14606 (MakeByteBlob): Implement to dump the array data into a byte array.
14608 2001-11-19 Ravi Pratap <ravi@ximian.com>
14610 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
14613 * constant.cs (Define): Implement.
14615 (EmitConstant): Re-write fully.
14617 Pass in location info.
14619 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
14622 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
14623 DictionaryEntry since we need location info too.
14625 (constant_declaration): Update accordingly.
14627 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
14628 code into another method : UpdateIndices.
14630 2001-11-18 Ravi Pratap <ravi@ximian.com>
14632 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
14633 some type checking etc.
14635 2001-11-17 Ravi Pratap <ravi@ximian.com>
14637 * expression.cs (ArrayCreation::ValidateInitializers): Implement
14638 bits to provide dimension info if the user skips doing that.
14640 Update second constructor to store the rank correctly.
14642 2001-11-16 Ravi Pratap <ravi@ximian.com>
14644 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
14645 and try to implement.
14647 * ../errors/cs0150.cs : Add.
14649 * ../errors/cs0178.cs : Add.
14651 2001-11-16 Miguel de Icaza <miguel@ximian.com>
14653 * statement.cs: Implement foreach on multi-dimensional arrays.
14655 * parameter.cs (Parameters.GetParameterByName): Also lookup the
14656 name of the params argument.
14658 * expression.cs: Use EmitStoreOpcode to get the right opcode while
14659 initializing the array.
14661 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
14662 we can use this elsewhere.
14664 * statement.cs: Finish implementation of foreach for single
14667 * cs-parser.jay: Use an out-of-band stack to pass information
14668 around, I wonder why I need this.
14670 foreach_block: Make the new foreach_block the current_block.
14672 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
14673 function used to return a static Parameters structure. Used for
14674 empty parameters, as those are created very frequently.
14676 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
14678 2001-11-15 Ravi Pratap <ravi@ximian.com>
14680 * interface.cs : Default modifier is private, not public. The
14681 make verify test passes again.
14683 2001-11-15 Ravi Pratap <ravi@ximian.com>
14685 * support.cs (ReflectionParameters): Fix logic to determine
14686 whether the last parameter is a params one. Test 9 passes again.
14688 * delegate.cs (Populate): Register the builders we define with
14689 RegisterParameterForBuilder. Test 19 passes again.
14691 * cs-parser.jay (property_declaration): Reference $6 instead
14692 of $$ to get at the location.
14694 (indexer_declaration): Similar stuff.
14696 (attribute): Ditto.
14698 * class.cs (Property): Register parameters for the Get and Set methods
14699 if they exist. Test 23 passes again.
14701 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
14702 call to EmitArguments as we are sure there aren't any params arguments.
14703 Test 32 passes again.
14705 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
14706 IndexOutOfRangeException.
14708 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
14709 Test 33 now passes again.
14711 2001-11-15 Miguel de Icaza <miguel@ximian.com>
14713 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
14714 broke a bunch of things. Will have to come up with a better way
14715 of tracking locations.
14717 * statement.cs: Implemented foreach for single dimension arrays.
14719 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14721 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
14722 an error. This removes the lookup from the critical path.
14724 * cs-parser.jay: Removed use of temporary_loc, which is completely
14727 2001-11-14 Miguel de Icaza <miguel@ximian.com>
14729 * support.cs (ReflectionParameters.ParameterModifier): Report
14730 whether the argument is a PARAMS argument or not.
14732 * class.cs: Set the attribute `ParamArrayAttribute' on the
14733 parameter argument.
14735 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
14736 and cons_param_array_attribute (ConstructorInfo for
14737 ParamArrayAttribute).,
14739 * codegen.cs: Emit the return using the `Return' statement, that
14740 way we can report the error correctly for missing return values.
14742 * class.cs (Method.Emit): Clean up.
14744 * expression.cs (Argument.Resolve): Take another argument: the
14745 location where this argument is used. Notice that this is not
14746 part of the "Argument" class as to reduce the size of the
14747 structure (we know the approximate location anyways).
14749 Test if the argument is a variable-reference, if not, then
14750 complain with a 206.
14752 (Argument.Emit): Emit addresses of variables.
14754 (Argument.FullDesc): Simplify.
14756 (Invocation.DoResolve): Update for Argument.Resolve.
14758 (ElementAccess.DoResolve): ditto.
14760 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
14761 method should be virtual, as this method is always virtual.
14763 (NewDelegate.DoResolve): Update for Argument.Resolve.
14765 * class.cs (ConstructorInitializer.DoResolve): ditto.
14767 * attribute.cs (Attribute.Resolve): ditto.
14769 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14771 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
14773 * expression.cs (ParameterReference): Drop IStackStorage and implement
14774 IAssignMethod instead.
14776 (LocalVariableReference): ditto.
14778 * ecore.cs (FieldExpr): Drop IStackStorage and implement
14779 IAssignMethod instead.
14781 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14783 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
14784 enumerations that are used in heavily used structures derive from
14785 byte in a laughable and pathetic attempt to reduce memory usage.
14786 This is the kind of pre-optimzations that you should not do at
14787 home without adult supervision.
14789 * expression.cs (UnaryMutator): New class, used to handle ++ and
14790 -- separatedly from the other unary operators. Cleans up the
14791 code, and kills the ExpressionStatement dependency in Unary.
14793 (Unary): Removed `method' and `Arguments' from this class, making
14794 it smaller, and moving it all to SimpleCall, so I can reuse this
14795 code in other locations and avoid creating a lot of transient data
14796 strucutres when not required.
14798 * cs-parser.jay: Adjust for new changes.
14800 2001-11-11 Miguel de Icaza <miguel@ximian.com>
14802 * enum.cs (Enum.Populate): If there is a failure during
14805 * cs-parser.jay (opt_enum_base): we used to catch type errors
14806 here, but this is really incorrect. The type error should be
14807 catched during semantic analysis.
14809 2001-12-11 Ravi Pratap <ravi@ximian.com>
14811 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
14812 current_local_parameters as expected since I, in my stupidity, had forgotten
14815 * attribute.cs (GetValidPlaces): Fix stupid bug.
14817 * class.cs (Method::Emit): Perform check on applicability of attributes.
14819 (Constructor::Emit): Ditto.
14821 (Field::Emit): Ditto.
14823 (Field.Location): Store location information.
14825 (Property, Event, Indexer, Operator): Ditto.
14827 * cs-parser.jay (field_declaration): Pass in location for each field.
14829 * ../errors/cs0592.cs : Add.
14831 2001-11-12 Ravi Pratap <ravi@ximian.com>
14833 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
14835 (InitCoreTypes): Update accordingly.
14837 (RegisterAttrType, LookupAttr): Implement.
14839 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
14840 info about the same.
14842 (Resolve): Update to populate the above as necessary.
14844 (Error592): Helper.
14846 (GetValidPlaces): Helper to the above.
14848 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
14850 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
14852 2001-11-12 Ravi Pratap <ravi@ximian.com>
14854 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
14856 * ../errors/cs0617.cs : Add.
14858 2001-11-11 Ravi Pratap <ravi@ximian.com>
14860 * enum.cs (Emit): Rename to Populate to be more consistent with what
14861 we expect it to do and when exactly it is called.
14863 * class.cs, rootcontext.cs : Update accordingly.
14865 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
14866 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
14868 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
14870 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
14871 of a fieldinfo using the above, when dealing with a FieldBuilder.
14873 2001-11-10 Ravi Pratap <ravi@ximian.com>
14875 * ../errors/cs0031.cs : Add.
14877 * ../errors/cs1008.cs : Add.
14879 * ../errrors/cs0543.cs : Add.
14881 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
14884 (FindMembers): Implement.
14886 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
14887 enums and delegates too.
14889 (enum_types): Rename to builder_to_enum.
14891 (delegate_types): Rename to builder_to_delegate.
14893 * delegate.cs (FindMembers): Implement.
14895 2001-11-09 Ravi Pratap <ravi@ximian.com>
14897 * typemanager.cs (IsEnumType): Implement.
14899 * enum.cs (Emit): Re-write parts to account for the underlying type
14900 better and perform checking etc.
14902 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
14903 of the underlying type.
14905 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
14908 * enum.cs (error31): Helper to report error #31.
14910 * cs-parser.jay (enum_declaration): Store location of each member too.
14912 * enum.cs (member_to_location): New hashtable.
14914 (AddEnumMember): Update location hashtable.
14916 (Emit): Use the location of each member while reporting errors.
14918 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14920 * cs-parser.jay: A for_initializer if is a
14921 local_variable_declaration really ammount to have an implicit
14922 block with the variable declaration and no initializer for for.
14924 * statement.cs (For.Emit): Cope with null initializers.
14926 This fixes the infinite loop on for initializers.
14928 2001-11-08 Miguel de Icaza <miguel@ximian.com>
14930 * enum.cs: More cleanup.
14932 * ecore.cs: Remove dead code.
14934 * class.cs (Property.Emit): More simplification.
14935 (Event.Emit): ditto.
14937 Reworked to have less levels of indentation.
14939 2001-11-08 Ravi Pratap <ravi@ximian.com>
14941 * class.cs (Property): Emit attributes.
14951 * enum.cs (Emit): Ditto.
14953 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
14956 * class.cs (Field, Event, etc.): Move attribute generation into the
14957 Emit method everywhere.
14959 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
14960 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
14961 as we had no way of defining nested enums !
14963 * rootcontext.cs : Adjust code accordingly.
14965 * typemanager.cs (AddEnumType): To keep track of enum types separately.
14967 2001-11-07 Ravi Pratap <ravi@ximian.com>
14969 * expression.cs (EvalConstantExpression): Move into ecore.cs
14971 * enum.cs (Enum): Rename some members and make them public and readonly
14972 according to our convention.
14974 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
14977 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
14979 (Enum::Emit): Write a simple version for now which doesn't try to compute
14980 expressions. I shall modify this to be more robust in just a while.
14982 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
14984 (TypeContainer::CloseType): Create the Enum types too.
14986 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
14988 * expression.cs (EvalConstantExpression): Get rid of completely.
14990 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
14991 user-defined values and other cases.
14993 (IsValidEnumLiteral): Helper function.
14995 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
14996 out there in the case we had a literal FieldExpr.
14998 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15000 (Literalize): Revamp a bit to take two arguments.
15002 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15004 2001-11-06 Ravi Pratap <ravi@ximian.com>
15006 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15008 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15010 (Resolve): Use the above to ensure we have proper initializers.
15012 2001-11-05 Ravi Pratap <ravi@ximian.com>
15014 * expression.cs (Expression::EvalConstantExpression): New method to
15015 evaluate constant expressions.
15017 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15019 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15021 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15024 (Binary.ResolveOperator): Handle operator != (object a, object b)
15025 and operator == (object a, object b);
15027 (Binary.DoNumericPromotions): Indicate whether the numeric
15028 promotion was possible.
15030 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15033 Made the ArrayAccess implement interface IAssignMethod instead of
15034 IStackStore as the order in which arguments are passed reflects
15037 * assign.cs: Instead of using expr.ExprClass to select the way of
15038 assinging, probe for the IStackStore/IAssignMethod interfaces.
15040 * typemanager.cs: Load InitializeArray definition.
15042 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15043 static data that can be used to initialize arrays.
15045 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15047 * expression.cs: Handle operator== and operator!= for booleans.
15049 (Conditioal.Reduce): Implement reducer for the ?: operator.
15051 (Conditional.Resolve): Implement dead code elimination.
15053 (Binary.Resolve): Catch string literals and return a new
15054 concatenated string.
15056 (Unary.Reduce): Implement reduction of unary expressions.
15058 * ecore.cs: Split out the expression core handling here.
15060 (Expression.Reduce): New method used to perform constant folding
15061 and CSE. This is needed to support constant-expressions.
15063 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15064 targets, and optimize for !x.
15066 2001-11-04 Ravi Pratap <ravi@ximian.com>
15068 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15069 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15070 set custom atttributes.
15072 * literal.cs (Literal::GetValue): New abstract method to return the actual
15073 value of the literal, cast as an object.
15075 (*Literal): Implement GetValue method.
15077 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15078 expressions to the arraylist but objects of type Argument.
15080 * class.cs (TypeContainer::Emit): Emit our attributes too.
15082 (Method::Emit, Constructor::Emit): Ditto.
15084 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15085 to be ignoring earlier.
15087 2001-11-03 Ravi Pratap <ravi@ximian.com>
15089 * attribute.cs (AttributeSection::Define): Implement to do the business
15090 of constructing a CustomAttributeBuilder.
15092 (Attribute): New trivial class. Increases readability of code.
15094 * cs-parser.jay : Update accordingly.
15096 (positional_argument_list, named_argument_list, named_argument): New rules
15098 (attribute_arguments): Use the above so that we are more correct.
15100 2001-11-02 Ravi Pratap <ravi@ximian.com>
15102 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15103 to perform all checks for a method with a params parameter.
15105 (Invocation::OverloadResolve): Update to use the above method and therefore
15106 cope correctly with params method invocations.
15108 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15111 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15112 constructors in our parent too because we can't afford to miss out on
15115 * attribute.cs (AttributeSection): New name for the class Attribute
15117 Other trivial changes to improve readability.
15119 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15120 use the new class names.
15122 2001-11-01 Ravi Pratap <ravi@ximian.com>
15124 * class.cs (Method::Define): Complete definition for params types too
15126 (Indexer::Define): Ditto.
15128 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15129 Cope everywhere with a request for info about the array parameter.
15131 2001-11-01 Ravi Pratap <ravi@ximian.com>
15133 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15135 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15136 local_variable_type to extract the string corresponding to the type.
15138 (local_variable_type): Fixup the action to use the new helper method.
15140 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15143 * expression.cs : Clean out code which uses the above.
15145 2001-10-31 Ravi Pratap <ravi@ximian.com>
15147 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15148 and bale out if necessary by returning a false.
15150 (RegisterProperty): Ditto.
15152 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15153 and print out appropriate error messages.
15155 * interface.cs (everywhere): Ditto.
15157 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15158 location to constructor.
15160 * class.cs (Property, Event, Indexer): Update accordingly.
15162 * ../errors/cs111.cs : Added.
15164 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15165 of a method, as laid down by the spec.
15167 (Invocation::OverloadResolve): Use the above method.
15169 2001-10-31 Ravi Pratap <ravi@ximian.com>
15171 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15172 now take a TypeContainer and a Parameters object.
15174 (ParameterData): Modify return type of ParameterModifier method to be
15175 Parameter.Modifier and not a string.
15177 (ReflectionParameters, InternalParameters): Update accordingly.
15179 * expression.cs (Argument::GetParameterModifier): Same here.
15181 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15182 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15183 symbol in it at all so maybe this is only for now.
15185 2001-10-30 Ravi Pratap <ravi@ximian.com>
15187 * support.cs (InternalParameters): Constructor now takes an extra argument
15188 which is the actual Parameters class.
15190 (ParameterDesc): Update to provide info on ref/out modifiers.
15192 * class.cs (everywhere): Update call to InternalParameters to pass in
15193 the second argument too.
15195 * support.cs (ParameterData): Add ParameterModifier, which is a method
15196 to return the modifier info [ref/out etc]
15198 (InternalParameters, ReflectionParameters): Implement the above.
15200 * expression.cs (Argument::ParameterModifier): Similar function to return
15201 info about the argument's modifiers.
15203 (Invocation::OverloadResolve): Update to take into account matching modifiers
15206 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15207 a new SetFormalParameters object which we pass to InternalParameters.
15209 2001-10-30 Ravi Pratap <ravi@ximian.com>
15211 * expression.cs (NewArray): Merge into the ArrayCreation class.
15213 2001-10-29 Ravi Pratap <ravi@ximian.com>
15215 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15216 NewUserdefinedArray into one as there wasn't much of a use in having
15219 * expression.cs (Argument): Change field's name to ArgType from Type.
15221 (Type): New readonly property which returns the proper type, taking into
15222 account ref/out modifiers.
15224 (everywhere): Adjust code accordingly for the above.
15226 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15227 whether we are emitting for a ref or out parameter.
15229 * expression.cs (Argument::Emit): Use the above field to set the state.
15231 (LocalVariableReference::Emit): Update to honour the flag and emit the
15234 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15236 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15238 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15240 (ReflectionParameters, InternalParameters): Implement the above method.
15242 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15245 (Invocation::FullMethodDesc): Ditto.
15247 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15249 * cs-parser.jay: Add extra production for the second form of array
15252 * expression.cs (ArrayCreation): Update to reflect the above
15255 * Small changes to prepare for Array initialization.
15257 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15259 * typemanager.cs (ImplementsInterface): interface might be null;
15260 Deal with this problem;
15262 Also, we do store negative hits on the cache (null values), so use
15263 this instead of calling t.GetInterfaces on the type everytime.
15265 2001-10-28 Ravi Pratap <ravi@ximian.com>
15267 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15269 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15270 split functionality out into different classes.
15272 (New::FormArrayType): Move into NewBuiltinArray.
15274 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15277 (NewBuiltinArray): New class to handle creation of built-in arrays.
15279 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15280 account creation of one-dimensional arrays.
15282 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15284 (NewUserdefinedArray::DoResolve): Implement.
15286 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15288 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15289 we maintain inside the TypeManager. This is necessary to perform lookups on the
15292 (LookupType): Update to perform GetType on the module builders too.
15294 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15296 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15298 2001-10-23 Ravi Pratap <ravi@ximian.com>
15300 * expression.cs (New::DoResolve): Implement guts of array creation.
15302 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15304 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15306 * expression.cs: Fix bug I introduced lsat night that broke
15309 (Expression.Resolve): Report a 246 error (can not resolve name)
15310 if we find a SimpleName in the stream.
15312 (Expression.ResolveLValue): Ditto.
15314 (Expression.ResolveWithSimpleName): This function is a variant of
15315 ResolveName, this one allows SimpleNames to be returned without a
15316 warning. The only consumer of SimpleNames is MemberAccess
15318 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15320 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15321 might arrive here. I have my doubts that this is correct.
15323 * statement.cs (Lock): Implement lock statement.
15325 * cs-parser.jay: Small fixes to support `lock' and `using'
15327 * cs-tokenizer.cs: Remove extra space
15329 * driver.cs: New flag --checked, allows to turn on integer math
15332 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15333 Threading.Monitor.Exit
15335 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15337 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15338 Expression Class to be IndexerAccess.
15340 Notice that Indexer::DoResolve sets the eclass to Value.
15342 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15344 * class.cs (TypeContainer::Emit): Emit code for indexers.
15346 * assign.cs (IAssignMethod): New interface implemented by Indexers
15347 and Properties for handling assignment.
15349 (Assign::Emit): Simplify and reuse code.
15351 * expression.cs (IndexerAccess, PropertyExpr): Implement
15352 IAssignMethod, clean up old code.
15354 2001-10-22 Ravi Pratap <ravi@ximian.com>
15356 * typemanager.cs (ImplementsInterface): New method to determine if a type
15357 implements a given interface. Provides a nice cache too.
15359 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15362 (ConvertReferenceExplicit): Ditto.
15364 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15365 various methods, with correct names etc.
15367 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15368 Operator.UnaryNegation.
15370 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15371 we have a unary plus or minus operator.
15373 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15376 * everywhere : update accordingly.
15378 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15381 * class.cs (Method::Define): For the case where we are implementing a method
15382 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15383 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15385 2001-10-21 Ravi Pratap <ravi@ximian.com>
15387 * interface.cs (FindMembers): Implement to work around S.R.E
15390 * typemanager.cs (IsInterfaceType): Implement.
15392 (FindMembers): Update to handle interface types too.
15394 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15395 use IsAssignableFrom as that is not correct - it doesn't work.
15397 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15398 and accordingly override EmitStatement.
15400 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15401 using the correct logic :-)
15403 2001-10-19 Ravi Pratap <ravi@ximian.com>
15405 * ../errors/cs-11.cs : Add to demonstrate error -11
15407 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15409 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15410 then pass this as a hint to ResolveLValue.
15412 * expression.cs (FieldExpr): Add Location information
15414 (FieldExpr::LValueResolve): Report assignment to readonly
15417 (Expression::ExprClassFromMemberInfo): Pass location information.
15419 (Expression::ResolveLValue): Add new method that resolves an
15422 (Expression::DoResolveLValue): Default invocation calls
15425 (Indexers): New class used to keep track of indexers in a given
15428 (IStackStore): Renamed from LValue, as it did not really describe
15429 what this did. Also ResolveLValue is gone from this interface and
15430 now is part of Expression.
15432 (ElementAccess): Depending on the element access type
15434 * typemanager.cs: Add `indexer_name_type' as a Core type
15435 (System.Runtime.CompilerServices.IndexerNameAttribute)
15437 * statement.cs (Goto): Take a location.
15439 2001-10-18 Ravi Pratap <ravi@ximian.com>
15441 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15442 if two delegates are compatible.
15444 (NewDelegate::DoResolve): Update to take care of the case when
15445 we instantiate a delegate from another delegate.
15447 * typemanager.cs (FindMembers): Don't even try to look up members
15448 of Delegate types for now.
15450 2001-10-18 Ravi Pratap <ravi@ximian.com>
15452 * delegate.cs (NewDelegate): New class to take care of delegate
15455 * expression.cs (New): Split the delegate related code out into
15456 the NewDelegate class.
15458 * delegate.cs (DelegateInvocation): New class to handle delegate
15461 * expression.cs (Invocation): Split out delegate related code into
15462 the DelegateInvocation class.
15464 2001-10-17 Ravi Pratap <ravi@ximian.com>
15466 * expression.cs (New::DoResolve): Implement delegate creation fully
15467 and according to the spec.
15469 (New::DoEmit): Update to handle delegates differently.
15471 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15472 because of which we were printing out arguments in reverse order !
15474 * delegate.cs (VerifyMethod): Implement to check if the given method
15475 matches the delegate.
15477 (FullDelegateDesc): Implement.
15479 (VerifyApplicability): Implement.
15481 * expression.cs (Invocation::DoResolve): Update to accordingly handle
15482 delegate invocations too.
15484 (Invocation::Emit): Ditto.
15486 * ../errors/cs1593.cs : Added.
15488 * ../errors/cs1594.cs : Added.
15490 * delegate.cs (InstanceExpression, TargetMethod): New properties.
15492 2001-10-16 Ravi Pratap <ravi@ximian.com>
15494 * typemanager.cs (intptr_type): Core type for System.IntPtr
15496 (InitCoreTypes): Update for the same.
15498 (iasyncresult_type, asynccallback_type): Ditto.
15500 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15503 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15506 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15507 the builders for the 4 members of a delegate type :-)
15509 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15512 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15514 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15516 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15518 * statement.cs (Break::Emit): Implement.
15519 (Continue::Emit): Implement.
15521 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15522 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15523 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15524 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15527 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
15528 properties that track the label for the current loop (begin of the
15529 loop and end of the loop).
15531 2001-10-15 Ravi Pratap <ravi@ximian.com>
15533 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
15534 use of emitting anything at all.
15536 * class.cs, rootcontext.cs : Get rid of calls to the same.
15538 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
15540 (Populate): Define the constructor correctly and set the implementation
15543 * typemanager.cs (delegate_types): New hashtable to hold delegates that
15546 (AddDelegateType): Implement.
15548 (IsDelegateType): Implement helper method.
15550 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
15552 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
15553 and accordingly handle it.
15555 * delegate.cs (Populate): Take TypeContainer argument.
15556 Implement bits to define the Invoke method. However, I still haven't figured out
15557 how to take care of the native int bit :-(
15559 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
15560 Qualify the name of the delegate, not its return type !
15562 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
15565 (StandardConversionExists): Checking for array types turns out to be recursive.
15567 (ConvertReferenceExplicit): Implement array conversion.
15569 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
15571 2001-10-12 Ravi Pratap <ravi@ximian.com>
15573 * cs-parser.jay (delegate_declaration): Store the fully qualified
15574 name as it is a type declaration.
15576 * delegate.cs (ReturnType, Name): Rename members to these. Make them
15579 (DefineDelegate): Renamed from Define. Does the same thing essentially,
15580 as TypeContainer::DefineType.
15582 (Populate): Method in which all the definition of the various methods (Invoke)
15585 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
15588 (CloseDelegate): Finally creates the delegate.
15590 * class.cs (TypeContainer::DefineType): Update to define delegates.
15591 (Populate, Emit and CloseType): Do the same thing here too.
15593 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
15594 delegates in all these operations.
15596 2001-10-14 Miguel de Icaza <miguel@ximian.com>
15598 * expression.cs: LocalTemporary: a new expression used to
15599 reference a temporary that has been created.
15601 * assign.cs: Handle PropertyAccess back here, so that we can
15602 provide the proper semantic access to properties.
15604 * expression.cs (Expression::ConvertReferenceExplicit): Implement
15605 a few more explicit conversions.
15607 * modifiers.cs: `NEW' modifier maps to HideBySig.
15609 * expression.cs (PropertyExpr): Make this into an
15610 ExpressionStatement, and support the EmitStatement code path.
15612 Perform get/set error checking, clean up the interface.
15614 * assign.cs: recognize PropertyExprs as targets, and if so, turn
15615 them into toplevel access objects.
15617 2001-10-12 Miguel de Icaza <miguel@ximian.com>
15619 * expression.cs: PropertyExpr::PropertyExpr: use work around the
15622 * typemanager.cs: Keep track here of our PropertyBuilders again to
15623 work around lameness in SRE.
15625 2001-10-11 Miguel de Icaza <miguel@ximian.com>
15627 * expression.cs (LValue::LValueResolve): New method in the
15628 interface, used to perform a second resolution pass for LValues.
15630 (This::DoResolve): Catch the use of this in static methods.
15632 (This::LValueResolve): Implement.
15634 (This::Store): Remove warning, assigning to `this' in structures
15637 (Invocation::Emit): Deal with invocation of
15638 methods on value types. We need to pass the address to structure
15639 methods rather than the object itself. (The equivalent code to
15640 emit "this" for structures leaves the entire structure on the
15641 stack instead of a pointer to it).
15643 (ParameterReference::DoResolve): Compute the real index for the
15644 argument based on whether the method takes or not a `this' pointer
15645 (ie, the method is static).
15647 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
15648 value types returned from functions when we need to invoke a
15649 method on the sturcture.
15652 2001-10-11 Ravi Pratap <ravi@ximian.com>
15654 * class.cs (TypeContainer::DefineType): Method to actually do the business of
15655 defining the type in the Modulebuilder or Typebuilder. This is to take
15656 care of nested types which need to be defined on the TypeBuilder using
15657 DefineNestedMethod.
15659 (TypeContainer::GetClassBases): Implement. Essentially the code from the
15660 methods in RootContext, only ported to be part of TypeContainer.
15662 (TypeContainer::GetInterfaceOrClass): Ditto.
15664 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
15666 * interface.cs (Interface::DefineInterface): New method. Does exactly
15667 what RootContext.CreateInterface did earlier, only it takes care of nested types
15670 (Interface::GetInterfaces): Move from RootContext here and port.
15672 (Interface::GetInterfaceByName): Same here.
15674 * rootcontext.cs (ResolveTree): Re-write.
15676 (PopulateTypes): Re-write.
15678 * class.cs (TypeContainer::Populate): Populate nested types too.
15679 (TypeContainer::Emit): Emit nested members too.
15681 * typemanager.cs (AddUserType): Do not make use of the FullName property,
15682 instead just use the name argument passed in as it is already fully
15685 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
15686 to TypeContainer mapping to see if a type is user-defined.
15688 * class.cs (TypeContainer::CloseType): Implement.
15690 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
15691 the default constructor.
15693 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
15696 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
15698 * interface.cs (CloseType): Create the type here.
15700 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
15703 Remove all the methods which are now in TypeContainer.
15705 2001-10-10 Ravi Pratap <ravi@ximian.com>
15707 * delegate.cs (Define): Re-write bits to define the delegate
15710 2001-10-10 Miguel de Icaza <miguel@ximian.com>
15712 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
15714 * expression.cs (ImplicitReferenceConversion): handle null as well
15715 as a source to convert to any reference type.
15717 * statement.cs (Return): Perform any implicit conversions to
15718 expected return type.
15720 Validate use of return statement.
15722 * codegen.cs (EmitContext): Pass the expected return type here.
15724 * class.cs (Method, Constructor, Property): Pass expected return
15725 type to EmitContext.
15727 2001-10-09 Miguel de Icaza <miguel@ximian.com>
15729 * expression.cs: Make DoResolve take an EmitContext instead of a
15732 Replaced `l' and `location' for `loc', for consistency.
15734 (Error, Warning): Remove unneeded Tc argument.
15736 * assign.cs, literal.cs, constant.cs: Update to new calling
15739 * codegen.cs: EmitContext now contains a flag indicating whether
15740 code is being generated in a static method or not.
15742 * cs-parser.jay: DecomposeQI, new function that replaces the old
15743 QualifiedIdentifier. Now we always decompose the assembled
15744 strings from qualified_identifier productions into a group of
15747 2001-10-08 Miguel de Icaza <miguel@ximian.com>
15749 * rootcontext.cs: Deal with field-less struct types correctly now
15750 by passing the size option to Define Type.
15752 * class.cs: Removed hack that created one static field.
15754 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15756 * statement.cs: Moved most of the code generation here.
15758 2001-10-09 Ravi Pratap <ravi@ximian.com>
15760 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
15763 (ElementAccess): Remove useless bits for now - keep checks as the spec
15766 2001-10-08 Ravi Pratap <ravi@ximian.com>
15768 * expression.cs (ElementAccess::DoResolve): Remove my crap code
15769 and start performing checks according to the spec.
15771 2001-10-07 Ravi Pratap <ravi@ximian.com>
15773 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
15774 rank_specifiers instead.
15776 (rank_specifiers): Change the order in which the rank specifiers are stored
15778 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
15780 * expression.cs (ElementAccess): Implement the LValue interface too.
15782 2001-10-06 Ravi Pratap <ravi@ximian.com>
15784 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
15785 except that user defined conversions are not included.
15787 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
15788 perform the conversion of the return type, if necessary.
15790 (New::DoResolve): Check whether we are creating an array or an object
15791 and accordingly do the needful.
15793 (New::Emit): Same here.
15795 (New::DoResolve): Implement guts of array creation.
15797 (New::FormLookupType): Helper function.
15799 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15801 * codegen.cs: Removed most of the code generation here, and move the
15802 corresponding code generation bits to the statement classes.
15804 Added support for try/catch/finalize and throw.
15806 * cs-parser.jay: Added support for try/catch/finalize.
15808 * class.cs: Catch static methods having the flags override,
15809 virtual or abstract.
15811 * expression.cs (UserCast): This user cast was not really doing
15812 what it was supposed to do. Which is to be born in fully resolved
15813 state. Parts of the resolution were being performed at Emit time!
15817 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15819 * expression.cs: Implicity convert the result from UserCast.
15821 2001-10-05 Ravi Pratap <ravi@ximian.com>
15823 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
15824 prevented it from working correctly.
15826 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
15827 merely ConvertImplicit.
15829 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15831 * typemanager.cs: Make the LookupTypeContainer function static,
15832 and not per-instance.
15834 * class.cs: Make static FindMembers (the one that takes a Type
15837 * codegen.cs: Add EmitForeach here.
15839 * cs-parser.jay: Make foreach a toplevel object instead of the
15840 inline expansion, as we need to perform semantic analysis on it.
15842 2001-10-05 Ravi Pratap <ravi@ximian.com>
15844 * expression.cs (Expression::ImplicitUserConversion): Rename to
15845 UserDefinedConversion.
15847 (Expression::UserDefinedConversion): Take an extra argument specifying
15848 whether we look for explicit user conversions too.
15850 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
15852 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
15854 (ExplicitUserConversion): Make it a call to UserDefinedConversion
15855 with the appropriate arguments.
15857 * cs-parser.jay (cast_expression): Record location too.
15859 * expression.cs (Cast): Record location info.
15861 (Expression::ConvertExplicit): Take location argument.
15863 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
15864 to determine if we are doing explicit conversions.
15866 (UserCast::Emit): Update accordingly.
15868 (Expression::ConvertExplicit): Report an error if everything fails.
15870 * ../errors/cs0030.cs : Add.
15872 2001-10-04 Miguel de Icaza <miguel@ximian.com>
15874 * modifiers.cs: If the ABSTRACT keyword is present, also set the
15875 virtual and newslot bits.
15877 * class.cs (TypeContainer::RegisterRequiredImplementations):
15878 Record methods we need.
15880 (TypeContainer::MakeKey): Helper function to make keys for
15881 MethodBases, since the Methodbase key is useless.
15883 (TypeContainer::Populate): Call RegisterRequiredImplementations
15884 before defining the methods.
15886 Create a mapping for method_builders_to_methods ahead of time
15887 instead of inside a tight loop.
15889 (::RequireMethods): Accept an object as the data to set into the
15890 hashtable so we can report interface vs abstract method mismatch.
15892 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15894 * report.cs: Make all of it static.
15896 * rootcontext.cs: Drop object_type and value_type computations, as
15897 we have those in the TypeManager anyways.
15899 Drop report instance variable too, now it is a global.
15901 * driver.cs: Use try/catch on command line handling.
15903 Add --probe option to debug the error reporting system with a test
15906 * report.cs: Add support for exiting program when a probe
15907 condition is reached.
15909 2001-10-03 Ravi Pratap <ravi@ximian.com>
15911 * expression.cs (Binary::DoNumericPromotions): Fix the case when
15912 we do a forcible conversion regardless of type, to check if
15913 ForceConversion returns a null.
15915 (Binary::error19): Use location to report error.
15917 (Unary::error23): Use location here too.
15919 * ../errors/cs0019.cs : Check in.
15921 * ../errors/cs0023.cs : Check in.
15923 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
15924 case of a non-null MethodInfo object with a length of 0 !
15926 (Binary::ResolveOperator): Flag error if overload resolution fails to find
15927 an applicable member - according to the spec :-)
15928 Also fix logic to find members in base types.
15930 (Unary::ResolveOperator): Same here.
15932 (Unary::report23): Change name to error23 and make first argument a TypeContainer
15933 as I was getting thoroughly confused between this and error19 :-)
15935 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
15936 (::FindMostEncompassedType): Implement.
15937 (::FindMostEncompassingType): Implement.
15938 (::StandardConversionExists): Implement.
15940 (UserImplicitCast): Re-vamp. We now need info about most specific
15941 source and target types so that we can do the necessary conversions.
15943 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
15944 mathematical union with no duplicates.
15946 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15948 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
15949 in order from base classes to child classes, so that we can in
15950 child classes look up in our parent for method names and
15951 attributes (required for handling abstract, virtual, new, override
15952 constructs: we need to instrospect our base class, and if we dont
15953 populate the classes in order, the introspection might be
15954 incorrect. For example, a method could query its parent before
15955 the parent has any methods and would determine that the parent has
15956 no abstract methods (while it could have had them)).
15958 (RootContext::CreateType): Record the order in which we define the
15961 2001-10-02 Miguel de Icaza <miguel@ximian.com>
15963 * class.cs (TypeContainer::Populate): Also method definitions can
15964 fail now, keep track of this.
15966 (TypeContainer::FindMembers): Implement support for
15967 DeclaredOnly/noDeclaredOnly flag.
15969 (Constructor::Emit) Return the ConstructorBuilder.
15971 (Method::Emit) Return the MethodBuilder.
15972 Check for abstract or virtual methods to be public.
15974 * rootcontext.cs (RootContext::CreateType): Register all the
15975 abstract methods required for the class to be complete and the
15976 interface methods that must be implemented.
15978 * cs-parser.jay: Report error 501 (method requires body if it is
15979 not marked abstract or extern).
15981 * expression.cs (TypeOf::Emit): Implement.
15983 * typemanager.cs: runtime_handle_type, new global type.
15985 * class.cs (Property::Emit): Generate code for properties.
15987 2001-10-02 Ravi Pratap <ravi@ximian.com>
15989 * expression.cs (Unary::ResolveOperator): Find operators on base type
15990 too - we now conform exactly to the spec.
15992 (Binary::ResolveOperator): Same here.
15994 * class.cs (Operator::Define): Fix minor quirk in the tests.
15996 * ../errors/cs0215.cs : Added.
15998 * ../errors/cs0556.cs : Added.
16000 * ../errors/cs0555.cs : Added.
16002 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16004 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16005 single integer which is really efficient
16007 2001-10-01 Ravi Pratap <ravi@ximian.com>
16009 * expression.cs (Expression::ImplicitUserConversion): Use location
16010 even in the case when we are examining True operators.
16012 * class.cs (Operator::Define): Perform extensive checks to conform
16013 with the rules for operator overloading in the spec.
16015 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16016 some of the other conversions mentioned in the spec.
16018 * typemanager.cs (array_type): New static member for the System.Array built-in
16021 (cloneable_interface): For System.ICloneable interface.
16023 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16024 we start resolving the tree and populating types.
16026 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16028 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16030 * expression.cs (Expression::ExprClassFromMemberInfo,
16031 Expression::Literalize): Create literal expressions from
16032 FieldInfos which are literals.
16034 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16035 type casts, because they were wrong. The test suite in tests
16038 (ImplicitNumericConversion): ushort to ulong requires a widening
16041 Int32 constant to long requires widening cast as well.
16043 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16044 for integers because the type on the stack is not i4.
16046 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16048 * expression.cs (report118): require location argument.
16050 * parameter.cs: Do not dereference potential null value.
16052 * class.cs: Catch methods that lack the `new' keyword when
16053 overriding a name. Report warnings when `new' is used without
16054 anything being there to override.
16056 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16058 * class.cs: Only add constructor to hashtable if it is non-null
16059 (as now constructors can fail on define).
16061 (TypeManager, Class, Struct): Take location arguments.
16063 Catch field instance initialization in structs as errors.
16065 accepting_filter: a new filter for FindMembers that is static so
16066 that we dont create an instance per invocation.
16068 (Constructor::Define): Catch errors where a struct constructor is
16071 * cs-parser.jay: Pass location information for various new
16074 * delegate.cs (Delegate): take a location argument.
16076 * driver.cs: Do not call EmitCode if there were problesm in the
16077 Definition of the types, as many Builders wont be there.
16079 * decl.cs (Decl::Decl): Require a location argument.
16081 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16082 into integers, and find the most appropiate integer for it.
16084 * literal.cs: Implement ULongLiteral.
16086 * rootcontext.cs: Provide better information about the location of
16087 failure when CreateType fails.
16089 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16091 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16094 * expression.cs (Binary::CheckShiftArguments): Add missing type
16096 (Binary::ResolveOperator): Add type to the logical and and logical
16097 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16100 (Binary::DoNumericPromotions): In the case where either argument
16101 is ulong (and most signed types combined with ulong cause an
16102 error) perform implicit integer constant conversions as well.
16104 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16106 * expression.cs (UserImplicitCast): Method should always be
16108 (Invocation::BetterConversion): Simplified test for IntLiteral.
16110 (Expression::ImplicitNumericConversion): Split this routine out.
16111 Put the code that performs implicit constant integer conversions
16114 (Expression::Resolve): Become a wrapper around DoResolve so we can
16115 check eclass and type being set after resolve.
16117 (Invocation::Badness): Remove this dead function
16119 (Binary::ResolveOperator): Do not compute the expensive argumnets
16120 unless we have a union for it.
16122 (Probe::Emit): Is needs to do an isinst and then
16123 compare against null.
16125 (::CanConvert): Added Location argument. If the Location argument
16126 is null (Location.Null), then we do not report errors. This is
16127 used by the `probe' mechanism of the Explicit conversion. We do
16128 not want to generate an error for something that the user
16129 explicitly requested to be casted. But the pipeline for an
16130 explicit cast first tests for potential implicit casts.
16132 So for now, if the Location is null, it means `Probe only' to
16133 avoid adding another argument. Might have to revise this
16136 (ClassCast): New class used to type cast objects into arbitrary
16137 classes (used in Explicit Reference Conversions).
16139 Implement `as' as well.
16141 Reverted all the patches from Ravi below: they were broken:
16143 * The use of `level' as a mechanism to stop recursive
16144 invocations is wrong. That was there just to catch the
16145 bug with a strack trace but not as a way of addressing
16148 To fix the problem we have to *understand* what is going
16149 on and the interactions and come up with a plan, not
16150 just get things going.
16152 * The use of the type conversion cache that I proposed
16153 last night had an open topic: How does this work across
16154 protection domains. A user defined conversion might not
16155 be public in the location where we are applying the
16156 conversion, a different conversion might be selected
16157 (ie, private A->B (better) but public B->A (worse),
16158 inside A, A->B applies, but outside it, B->A will
16161 * On top of that (ie, even if the above is solved),
16162 conversions in a cache need to be abstract. Ie, `To
16163 convert from an Int to a Short use an OpcodeCast', not
16164 `To convert from an Int to a Short use the OpcodeCast on
16165 the variable 5' (which is what this patch was doing).
16167 2001-09-28 Ravi Pratap <ravi@ximian.com>
16169 * expression.cs (Invocation::ConversionExists): Re-write to use
16170 the conversion cache
16172 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16173 cache all conversions done, not just user-defined ones.
16175 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16176 to determine if a conversion exists instead of acutually trying to
16177 perform the conversion. It's faster too.
16179 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16180 and only then attempt the implicit conversion.
16182 2001-09-28 Ravi Pratap <ravi@ximian.com>
16184 * expression.cs (ConvertImplicit): Use a cache for conversions
16185 already found. Check level of recursion and bail out if necessary.
16187 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16189 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16190 Export standard methods that we expect for string operations.
16192 * statement.cs (Block::UsageWarning): Track usage of variables and
16193 report the errors for not used variables.
16195 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16198 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16200 * codegen.cs: remove unnneded code
16202 * expression.cs: Removed BuiltinTypeAccess class
16204 Fix the order in which implicit conversions are
16207 The previous fixed dropped support for boxed conversions (adding a
16208 test to the test suite now)
16210 (UserImplicitCast::CanConvert): Remove test for source being null,
16211 that code is broken. We should not feed a null to begin with, if
16212 we do, then we should track the bug where the problem originates
16213 and not try to cover it up here.
16215 Return a resolved expression of type UserImplicitCast on success
16216 rather than true/false. Ravi: this is what I was talking about,
16217 the pattern is to use a static method as a "constructor" for
16220 Also, do not create arguments until the very last minute,
16221 otherwise we always create the arguments even for lookups that
16222 will never be performed.
16224 (UserImplicitCast::Resolve): Eliminate, objects of type
16225 UserImplicitCast are born in a fully resolved state.
16227 * typemanager.cs (InitCoreTypes): Init also value_type
16228 (System.ValueType).
16230 * expression.cs (Cast::Resolve): First resolve the child expression.
16232 (LValue): Add new method AddressOf to be used by
16235 Change the argument of Store to take an EmitContext instead of an
16236 ILGenerator, because things like FieldExpr need to be able to call
16237 their children expression to generate the instance code.
16239 (Expression::Error, Expression::Warning): Sugar functions for
16242 (Expression::MemberLookup): Accept a TypeContainer instead of a
16243 Report as the first argument.
16245 (Expression::ResolvePrimary): Killed. I still want to improve
16246 this as currently the code is just not right.
16248 (Expression::ResolveMemberAccess): Simplify, but it is still
16251 (Unary::Resolve): Catch errors in AddressOf operators.
16253 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16254 index to a byte for the short-version, or the compiler will choose
16255 the wrong Emit call, which generates the wrong data.
16257 (ParameterReference::Emit, ::Store): same.
16259 (FieldExpr::AddressOf): Implement.
16261 * typemanager.cs: TypeManager: made public variable instead of
16264 * driver.cs: document --fatal.
16266 * report.cs (ErrorMessage, WarningMessage): new names for the old
16267 Error and Warning classes.
16269 * cs-parser.jay (member_access): Turn built-in access to types
16270 into a normal simplename
16272 2001-09-27 Ravi Pratap <ravi@ximian.com>
16274 * expression.cs (Invocation::BetterConversion): Fix to cope
16275 with q being null, since this was introducing a bug.
16277 * expression.cs (ConvertImplicit): Do built-in conversions first.
16279 2001-09-27 Ravi Pratap <ravi@ximian.com>
16281 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16283 2001-09-27 Ravi Pratap <ravi@ximian.com>
16285 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16286 I had introduced long ago (what's new ?).
16288 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16289 the work of all the checking.
16290 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16291 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16293 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16294 that is the right way.
16296 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16297 overloading resolution. Use everywhere instead of cutting and pasting code.
16299 (Binary::ResolveOperator): Use MakeUnionSet.
16301 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16302 we have to convert to bool types. Not complete yet.
16304 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16306 * typemanager.cs (TypeManager::CSharpName): support ushort.
16308 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16309 to provide an expression that performsn an implicit constant int
16310 conversion (section 6.1.6).
16311 (Expression::ConvertImplicitRequired): Reworked to include
16312 implicit constant expression conversions.
16314 (Expression::ConvertNumericExplicit): Finished.
16316 (Invocation::Emit): If InstanceExpression is null, then it means
16317 that we perform a call on this.
16319 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16321 * expression.cs (Unary::Emit): Remove some dead code.
16322 (Probe): Implement Resolve and Emit for `is'.
16323 (Expression::ConvertImplicitRequired): Attempt to do constant
16324 expression conversions here. Maybe should be moved to
16325 ConvertImplicit, but I am not sure.
16326 (Expression::ImplicitLongConstantConversionPossible,
16327 Expression::ImplicitIntConstantConversionPossible): New functions
16328 that tell whether is it possible to apply an implicit constant
16329 expression conversion.
16331 (ConvertNumericExplicit): Started work on explicit numeric
16334 * cs-parser.jay: Update operator constants.
16336 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16337 (Parameters::GetSignature): Hook up VerifyArgs here.
16338 (Parameters::VerifyArgs): Verifies that no two arguments have the
16341 * class.cs (Operator): Update the operator names to reflect the
16342 ones that the spec expects (as we are just stringizing the
16345 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16346 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16347 previous usage did only work for our methods.
16348 (Expression::ConvertImplicit): Handle decimal implicit numeric
16349 conversions as well.
16350 (Expression::InternalTypeConstructor): Used to invoke constructors
16351 on internal types for default promotions.
16353 (Unary::Emit): Implement special handling for the pre/post
16354 increment/decrement for overloaded operators, as they need to have
16355 the same semantics as the other operators.
16357 (Binary::ResolveOperator): ditto.
16358 (Invocation::ConversionExists): ditto.
16359 (UserImplicitCast::Resolve): ditto.
16361 2001-09-26 Ravi Pratap <ravi@ximian.com>
16363 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16364 operator, return after emitting body. Regression tests pass again !
16366 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16367 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16368 (Invocation::OverloadResolve): Ditto.
16369 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16371 * everywhere : update calls to the above methods accordingly.
16373 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16375 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16377 * expression.cs (ExpressionStatement): New base class used for
16378 expressions that can appear in statements, so that we can provide
16379 an alternate path to generate expression that do not leave a value
16382 (Expression::Emit, and all the derivatives): We no longer return
16383 whether a value is left on the stack or not. Every expression
16384 after being emitted leaves a single value on the stack.
16386 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16387 facilties of ExpressionStatement if possible.
16389 * cs-parser.jay: Update statement_expression.
16391 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16393 * driver.cs: Change the wording of message
16395 2001-09-25 Ravi Pratap <ravi@ximian.com>
16397 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16398 the type of the expression to the return type of the method if
16399 we have an overloaded operator match ! The regression tests pass again !
16400 (Unary::ResolveOperator): Ditto.
16402 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16403 to find "op_Implicit", not "implicit" ;-)
16404 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16405 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16407 * everywhere : Correct calls to the above accordingly.
16409 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16410 (ConvertImplicit): Do user-defined conversion if it exists.
16412 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16414 * assign.cs: track location.
16415 (Resolve): Use implicit conversions on assignment.
16417 * literal.cs: Oops. Not good, Emit of short access values should
16418 pass (Bytes) or the wrong argument will be selected.
16420 * expression.cs (Unary::Emit): Emit code for -expr.
16422 (Unary::ResolveOperator): Handle `Substract' for non-constants
16423 (substract from zero from the non-constants).
16424 Deal with Doubles as well.
16426 (Expression::ConvertImplicitRequired): New routine that reports an
16427 error if no implicit conversion exists.
16429 (Invocation::OverloadResolve): Store the converted implicit
16430 expressions if we make them
16432 2001-09-24 Ravi Pratap <ravi@ximian.com>
16434 * class.cs (ConstructorInitializer): Take a Location argument.
16435 (ConstructorBaseInitializer): Same here.
16436 (ConstructorThisInitializer): Same here.
16438 * cs-parser.jay : Update all calls accordingly.
16440 * expression.cs (Unary, Binary, New): Take location argument.
16441 Update accordingly everywhere.
16443 * cs-parser.jay : Update all calls to the above to take a location
16446 * class.cs : Ditto.
16448 2001-09-24 Ravi Pratap <ravi@ximian.com>
16450 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16451 (Invocation::BetterConversion): Same here
16452 (Invocation::ConversionExists): Ditto.
16454 (Invocation::ConversionExists): Implement.
16456 2001-09-22 Ravi Pratap <ravi@ximian.com>
16458 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16459 Also take an additional TypeContainer argument.
16461 * All over : Pass in TypeContainer as argument to OverloadResolve.
16463 * typemanager.cs (CSharpName): Update to check for the string type and return
16466 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16469 2001-09-21 Ravi Pratap <ravi@ximian.com>
16471 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16472 (Invocation::BetterFunction): Implement.
16473 (Invocation::BetterConversion): Implement.
16474 (Invocation::ConversionExists): Skeleton, no implementation yet.
16476 Okay, things work fine !
16478 2001-09-21 Miguel de Icaza <miguel@ximian.com>
16480 * typemanager.cs: declare and load enum_type, delegate_type and
16483 * expression.cs (Expression::Emit): Now emit returns a value that
16484 tells whether a value is left on the stack or not. This strategy
16485 might be reveted tomorrow with a mechanism that would address
16486 multiple assignments.
16487 (Expression::report118): Utility routine to report mismatches on
16490 (Unary::Report23): Report impossible type/operator combination
16493 (Unary::IsIncrementableNumber): Whether the type can be
16494 incremented or decremented with add.
16495 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16497 (Unary::ResolveOperator): Implement ++, !, ~,
16499 (Invocation::Emit): Deal with new Emit convetion.
16501 * All Expression derivatives: Updated their Emit method to return
16502 whether they leave values on the stack or not.
16504 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16505 stack for expressions that are statements.
16507 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16509 * expression.cs (LValue): New interface. Must be implemented by
16511 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16514 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16515 interface for generating code, simplifies the code.
16517 2001-09-20 Ravi Pratap <ravi@ximian.com>
16519 * expression.cs (everywhere): Comment out return statements in ::Resolve
16520 methods to avoid the warnings.
16522 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16524 * driver.cs (parse): Report error 2001 if we can not open the
16527 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
16530 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
16533 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
16534 otherwise nested blocks end up with the same index.
16536 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
16538 * expression.cs: Instead of having FIXMEs in the Resolve
16539 functions, throw exceptions so it is obvious that we are facing a
16542 * cs-parser.jay (invocation_expression): Pass Location information.
16544 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
16545 Use a basename for those routines because .NET does not like paths
16548 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
16551 2001-09-19 Miguel de Icaza <miguel@ximian.com>
16553 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
16554 are loading the correct data types (throws an exception if not).
16555 (TypeManager::InitCoreTypes): Use CoreLookupType
16557 * expression.cs (Unary::ResolveOperator): return the child
16558 expression for expressions which are just +expr.
16559 (Unary::ResolveOperator): Return negative literals for -LITERAL
16560 expressions (otherwise they are Unary {Literal}).
16561 (Invocation::Badness): Take into account `Implicit constant
16562 expression conversions'.
16564 * literal.cs (LongLiteral): Implement long literal class.
16565 (IntLiteral): export the `Value' of the intliteral.
16567 2001-09-19 Ravi Pratap <ravi@ximian.com>
16569 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
16571 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
16572 instead of 'Operator'
16574 * expression.cs (Binary::ResolveOperator): Update accordingly.
16575 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
16578 * cs-parser.jay (unary_expression): Update to use the new names.
16580 * gen-treedump.cs (GetUnary): Same here.
16582 * expression.cs (Unary::Resolve): Implement.
16583 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
16584 operators are found instead of making noise ;-)
16585 (Unary::ResolveOperator): New method to do precisely the same thing which
16586 Binary::ResolveOperator does for Binary expressions.
16587 (Unary.method, .Arguments): Add.
16588 (Unary::OperName): Implement.
16589 (Unary::ForceConversion): Copy and Paste !
16591 * class.cs (Operator::Define): Fix a small bug for the case when we have
16594 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
16595 for the inbuilt operators. Only overloading works for now ;-)
16597 2001-09-18 Miguel de Icaza <miguel@ximian.com>
16599 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
16600 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
16602 * expression.cs (This::Emit): Implement.
16603 (This::Resolve): Implement.
16604 (TypeOf:Resolve): Implement.
16605 (Expression::ResolveSimpleName): Add an implicit this to instance
16607 (MemberAccess::Resolve): Deal with Parameters and Fields.
16608 Bind instance variable to Field expressions.
16609 (FieldExpr::Instance): New field used to track the expression that
16610 represents the object instance.
16611 (FieldExpr::Resolve): Track potential errors from MemberLookup not
16613 (FieldExpr::Emit): Implement.
16615 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
16616 the last instruction contains a return opcode to avoid generating
16617 the last `ret' instruction (this generates correct code, and it is
16618 nice to pass the peverify output).
16620 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
16621 initializer for static and instance variables.
16622 (Constructor::Emit): Allow initializer to be null in the case of
16623 static constructors. Only emit initializer for instance
16626 (TypeContainer::FindMembers): Return a null array if there are no
16629 Also fix the code for the MemberTypes.Method branch, as it was not
16630 scanning that for operators (or tried to access null variables before).
16632 * assign.cs (Assign::Emit): Handle instance and static fields.
16636 * driver.cs: Stop compilation if there are parse errors.
16638 * cs-parser.jay (constructor_declaration): Provide default base
16639 initializer for non-static constructors.
16640 (constructor_declarator): Do not provide a default base
16641 initializers if none was specified.
16642 Catch the fact that constructors should not have parameters.
16644 * class.cs: Do not emit parent class initializers for static
16645 constructors, that should be flagged as an error.
16647 2001-09-18 Ravi Pratap <ravi@ximian.com>
16649 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
16650 Move back code into TypeContainer::Populate.
16652 2001-09-18 Ravi Pratap <ravi@ximian.com>
16654 * class.cs (TypeContainer::AddConstructor): Fix the check to
16655 compare against Name, not Basename.
16656 (Operator::OpType): Change Plus and Minus to Add and Subtract.
16658 * cs-parser.jay : Update accordingly.
16660 * class.cs (TypeContainer::FindMembers): For the case where we are searching
16661 for methods, don't forget to look into the operators too.
16662 (RegisterMethodBuilder): Helper method to take care of this for
16663 methods, constructors and operators.
16664 (Operator::Define): Completely revamp.
16665 (Operator.OperatorMethod, MethodName): New fields.
16666 (TypeContainer::Populate): Move the registering of builders into
16667 RegisterMethodBuilder.
16668 (Operator::Emit): Re-write.
16670 * expression.cs (Binary::Emit): Comment out code path to emit method
16671 invocation stuff for the case when we have a user defined operator. I am
16672 just not able to get it right !
16674 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16676 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
16679 (Expression::MemberLookup): Provide a version that allows to
16680 specify the MemberTypes and BindingFlags.
16682 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
16683 so it was not fetching variable information from outer blocks.
16685 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
16686 Beforefieldinit as it was buggy.
16688 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
16689 that Ravi put here.
16691 * class.cs (Constructor::Emit): Only emit if block is not null.
16692 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
16693 deal with this by semantically definining it as if the user had
16696 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
16697 constructors as we now "emit" them at a higher level.
16699 (TypeContainer::DefineDefaultConstructor): Used to define the
16700 default constructors if none was provided.
16702 (ConstructorInitializer): Add methods Resolve and Emit.
16704 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
16706 2001-09-17 Ravi Pratap <ravi@ximian.com>
16708 * class.cs (TypeContainer::EmitDefaultConstructor): Register
16709 the default constructor builder with our hashtable for methodbuilders
16712 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
16713 and argument_count is 0 in which case we have a match.
16714 (Binary::ResolveOperator): More null checking and miscellaneous coding
16717 2001-09-17 Ravi Pratap <ravi@ximian.com>
16719 * rootcontext.cs (IsNameSpace): Compare against null.
16721 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
16723 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
16724 and Unary::Operator.
16726 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
16729 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
16730 we have overloaded operators.
16731 (Binary::ResolveOperator): Implement the part which does the operator overload
16734 * class.cs (Operator::Emit): Implement.
16735 (TypeContainer::Emit): Emit the operators we have too.
16737 * expression.cs (Binary::Emit): Update to emit the appropriate code for
16738 the case when we have a user-defined operator.
16740 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16742 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
16744 2001-09-16 Ravi Pratap <ravi@ximian.com>
16746 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
16747 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
16748 (Constructor::Emit): Implement.
16749 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
16750 if we have no work to do.
16751 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
16754 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
16755 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
16757 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
16760 2001-09-15 Ravi Pratap <ravi@ximian.com>
16762 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
16764 (Tree::RecordNamespace): Method to do what the name says ;-)
16765 (Tree::Namespaces): Property to get at the namespaces hashtable.
16767 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
16770 * rootcontext.cs (IsNamespace): Fixed it :-)
16772 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16774 * class.cs (TypeContainer::FindMembers): Add support for
16776 (MethodCore): New class that encapsulates both the shared aspects
16777 of a Constructor and a Method.
16778 (Method, Constructor): Factored pieces into MethodCore.
16780 * driver.cs: Added --fatal which makes errors throw exceptions.
16781 Load System assembly as well as part of the standard library.
16783 * report.cs: Allow throwing exceptions on errors for debugging.
16785 * modifiers.cs: Do not use `parent', instead use the real type
16786 container to evaluate permission settings.
16788 * class.cs: Put Ravi's patch back in. He is right, and we will
16789 have to cope with the
16791 2001-09-14 Ravi Pratap <ravi@ximian.com>
16793 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
16794 FamORAssem, not FamANDAssem.
16796 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16798 * driver.cs: Added --parse option that only parses its input files
16801 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
16802 incorrect. IsTopLevel is not used to tell whether an object is
16803 root_types or not (that can be achieved by testing this ==
16804 root_types). But to see if this is a top-level *class* (not
16805 necessarly our "toplevel" container).
16807 2001-09-14 Ravi Pratap <ravi@ximian.com>
16809 * enum.cs (Enum::Define): Modify to call the Lookup method on the
16810 parent instead of a direct call to GetType.
16812 2001-09-14 Ravi Pratap <ravi@ximian.com>
16814 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
16815 Modifiers.TypeAttr. This should just be a call to that method.
16817 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
16818 object so that we can determine if we are top-level or not.
16820 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
16823 * enum.cs (Enum::Define): Ditto.
16825 * modifiers.cs (FieldAttr): Re-write.
16827 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
16828 (TypeContainer::HaveStaticConstructor): New property to provide access
16829 to precisely that info.
16831 * modifiers.cs (MethodAttr): Re-write.
16832 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
16834 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
16835 of top-level types as claimed.
16837 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16839 * expression.cs (MemberLookup): Fruitless attempt to lookup
16840 constructors. Maybe I need to emit default constructors? That
16841 might be it (currently .NET emits this for me automatically).
16842 (Invocation::OverloadResolve): Cope with Arguments == null.
16843 (Invocation::EmitArguments): new function, shared by the new
16844 constructor and us.
16845 (Invocation::Emit): Handle static and instance methods. Emit
16846 proper call instruction for virtual or non-virtual invocations.
16847 (New::Emit): Implement.
16848 (New::Resolve): Implement.
16849 (MemberAccess:Resolve): Implement.
16850 (MethodGroupExpr::InstanceExpression): used conforming to the spec
16851 to track instances.
16852 (FieldExpr::Resolve): Set type.
16854 * support.cs: Handle empty arguments.
16856 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
16857 SimpleLookup): Auxiliary routines to help parse a qualifier
16860 Update qualifier_identifier rule.
16862 * codegen.cs: Removed debugging messages.
16864 * class.cs: Make this a global thing, this acts just as a "key" to
16865 objects that we might have around.
16867 (Populate): Only initialize method_builders_to_methods once.
16869 * expression.cs (PropertyExpr): Initialize type from the
16872 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
16873 Resolve pattern. Attempt to implicitly convert value to boolean.
16876 * expression.cs: Set the type for the int32/int32 argument case.
16877 (Binary::ResolveOperator): Set the return type to boolean for
16878 comparission operators
16880 * typemanager.cs: Remove debugging print code.
16882 (Invocation::Resolve): resolve type.
16884 * class.cs: Allocate a MemberInfo of the correct size, as the code
16885 elsewhere depends on the test to reflect the correct contents.
16887 (Method::) Keep track of parameters, due to System.Reflection holes
16889 (TypeContainer::Populate): Keep track of MethodBuilders to Method
16892 (TypeContainer::FindMembers): Use ArrayList and then copy an array
16893 of the exact size and return that.
16895 (Class::LookupMethodByBuilder): New function that maps
16896 MethodBuilders to its methods. Required to locate the information
16897 on methods because System.Reflection bit us again.
16899 * support.cs: New file, contains an interface ParameterData and
16900 two implementations: ReflectionParameters and InternalParameters
16901 used to access Parameter information. We will need to grow this
16904 * expression.cs (Invocation::GetParameterData): implement a cache
16905 and a wrapper around the ParameterData creation for methods.
16906 (Invocation::OverloadResolve): Use new code.
16908 2001-09-13 Ravi Pratap <ravi@ximian.com>
16910 * class.cs (TypeContainer::EmitField): Remove and move into
16911 (Field::Define): here and modify accordingly.
16912 (Field.FieldBuilder): New member.
16913 (TypeContainer::Populate): Update accordingly.
16914 (TypeContainer::FindMembers): Implement.
16916 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16918 * statement.cs: (VariableInfo::VariableType): New field to be
16919 initialized with the full type once it is resolved.
16921 2001-09-12 Miguel de Icaza <miguel@ximian.com>
16923 * parameter.cs (GetParameterInfo): Use a type cache to compute
16924 things only once, and to reuse this information
16926 * expression.cs (LocalVariableReference::Emit): Implement.
16927 (OpcodeCast::Emit): fix.
16929 (ParameterReference::Resolve): Implement.
16930 (ParameterReference::Emit): Implement.
16932 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
16933 that are expressions need to stay as Expressions.
16935 * typemanager.cs (CSharpName): Returns the C# name of a type if
16938 * expression.cs (Expression::ConvertImplicit): New function that
16939 implements implicit type conversions.
16941 (Expression::ImplicitReferenceConversion): Implements implicit
16942 reference conversions.
16944 (EmptyCast): New type for transparent casts.
16946 (OpcodeCast): New type for casts of types that are performed with
16947 a sequence of bytecodes.
16949 (BoxedCast): New type used for casting value types into reference
16950 types. Emits a box opcode.
16952 (Binary::DoNumericPromotions): Implements numeric promotions of
16953 and computation of the Binary::Type.
16955 (Binary::EmitBranchable): Optimization.
16957 (Binary::Emit): Implement code emission for expressions.
16959 * typemanager.cs (TypeManager): Added two new core types: sbyte
16962 2001-09-12 Ravi Pratap <ravi@ximian.com>
16964 * class.cs (TypeContainer::FindMembers): Method which does exactly
16965 what Type.FindMembers does, only we don't have to use reflection. No
16966 implementation yet.
16968 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
16969 typecontainer objects as we need to get at them.
16970 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
16972 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
16973 typecontainer object.
16975 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
16976 of just a Report object.
16978 2001-09-11 Ravi Pratap <ravi@ximian.com>
16980 * class.cs (Event::Define): Go back to using the prefixes "add_" and
16982 (TypeContainer::Populate): Now define the delegates of the type too.
16983 (TypeContainer.Delegates): Property to access the list of delegates defined
16986 * delegates.cs (Delegate::Define): Implement partially.
16988 * modifiers.cs (TypeAttr): Handle more flags.
16990 2001-09-11 Ravi Pratap <ravi@ximian.com>
16992 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
16994 (Operator::Define): Re-write logic to get types by using the LookupType method
16995 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
16996 (Indexer::Define): Ditto.
16997 (Event::Define): Ditto.
16998 (Property::Define): Ditto.
17000 2001-09-10 Ravi Pratap <ravi@ximian.com>
17002 * class.cs (TypeContainer::Populate): Now define operators too.
17003 (TypeContainer.Operators): New property to access the list of operators
17005 (Operator.OperatorMethodBuilder): New member to hold the method builder
17006 for the operator we are defining.
17007 (Operator::Define): Implement.
17009 2001-09-10 Ravi Pratap <ravi@ximian.com>
17011 * class.cs (Event::Define): Make the prefixes of the accessor methods
17012 addOn_ and removeOn_
17014 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17015 of the location being passed in too. Ideally, this should go later since all
17016 error reporting should be done through the Report object.
17018 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17019 (Populate): Iterate thru the indexers we have and define them too.
17020 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17021 for the get and set accessors.
17022 (Indexer::Define): Implement.
17024 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17026 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17027 my previous implementation, did not work.
17029 * typemanager.cs: Add a couple of missing types (the longs).
17031 * literal.cs: Use TypeManager.bool_type instead of getting it.
17033 * expression.cs (EventExpr): New kind of expressions.
17034 (Expressio::ExprClassFromMemberInfo): finish
17036 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17038 * assign.cs: Emit stores to static fields differently.
17040 2001-09-08 Ravi Pratap <ravi@ximian.com>
17042 * Merge in changes and adjust code to tackle conflicts. Backed out my
17043 code in Assign::Resolve ;-)
17045 2001-09-08 Ravi Pratap <ravi@ximian.com>
17047 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17048 instead Report.Error and also pass in the location.
17049 (CSharpParser::Lexer): New readonly property to return the reference
17050 to the Tokenizer object.
17051 (declare_local_variables): Use Report.Error with location instead of plain
17055 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17056 (Operator.CheckBinaryOperator): Ditto.
17058 * cs-parser.jay (operator_declarator): Update accordingly.
17060 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17061 (CheckBinaryOperator): Same here.
17063 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17064 on the name without any prefixes of namespace names etc. This is because we
17065 already might have something already fully qualified like
17066 'System.Console.WriteLine'
17068 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17070 2001-09-07 Ravi Pratap <ravi@ximian.com>
17072 * cs-tokenizer.cs (location): Return a string which also contains
17075 * expression.cs (ElementAccess): New class for expressions of the
17076 type 'element access.'
17077 (BaseAccess): New class for expressions of the type 'base access.'
17078 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17081 * cs-parser.jay (element_access): Implement action.
17082 (base_access): Implement actions.
17083 (checked_expression, unchecked_expression): Implement.
17085 * cs-parser.jay (local_variable_type): Correct and implement.
17086 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17088 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17090 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17091 name and the specifiers.
17093 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17095 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17096 making them all public ;-)
17098 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17101 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17103 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17105 (FieldExpr, PropertyExprs): New resolved expressions.
17106 (SimpleName::MemberStaticCheck): Perform static checks for access
17107 to non-static fields on static methods. Maybe this should be
17108 generalized for MemberAccesses.
17109 (SimpleName::ResolveSimpleName): More work on simple name
17112 * cs-parser.jay (primary_expression/qualified_identifier): track
17113 the parameter index.
17115 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17116 (EmitContext::EmitBoolExpression): Chain to expression generation
17117 instead of temporary hack.
17118 (::EmitStatementExpression): Put generic expression code generation.
17120 * assign.cs (Assign::Emit): Implement variable assignments to
17121 local variables, parameters and fields.
17123 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17125 * statement.cs (Block::GetVariableInfo): New method, returns the
17126 VariableInfo for a variable name in a block.
17127 (Block::GetVariableType): Implement in terms of GetVariableInfo
17129 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17130 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17132 2001-09-06 Ravi Pratap <ravi@ximian.com>
17134 * cs-parser.jay (operator_declaration): Continue on my quest : update
17135 to take attributes argument.
17136 (event_declaration): Ditto.
17137 (enum_declaration): Ditto.
17138 (indexer_declaration): Ditto.
17140 * class.cs (Operator::Operator): Update constructor accordingly.
17141 (Event::Event): Ditto.
17143 * delegate.cs (Delegate::Delegate): Same here.
17145 * enum.cs (Enum::Enum): Same here.
17147 2001-09-05 Ravi Pratap <ravi@ximian.com>
17149 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17151 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17153 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17154 being passed around as an arraylist.
17155 (Attributes::AddAttribute): Method to add attribute sections.
17157 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17158 (struct_declaration): Update accordingly.
17159 (constant_declaration): Update.
17160 (field_declaration): Update.
17161 (method_header): Update.
17162 (fixed_parameter): Update.
17163 (parameter_array): Ditto.
17164 (property_declaration): Ditto.
17165 (destructor_declaration): Ditto.
17167 * class.cs (Struct::Struct): Update constructors accordingly.
17168 (Class::Class): Ditto.
17169 (Field::Field): Ditto.
17170 (Method::Method): Ditto.
17171 (Property::Property): Ditto.
17172 (TypeContainer::OptAttribute): update property's return type.
17174 * interface.cs (Interface.opt_attributes): New member.
17175 (Interface::Interface): Update to take the extra Attributes argument.
17177 * parameter.cs (Parameter::Parameter): Ditto.
17179 * constant.cs (Constant::Constant): Ditto.
17181 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17182 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17183 the attributes as a parameter.
17184 (InterfaceProperty): Update constructor call.
17185 (InterfaceEvent): Ditto.
17186 (InterfaceMethod): Ditto.
17187 (InterfaceIndexer): Ditto.
17189 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17190 pass the attributes too.
17191 (interface_event_declaration): Ditto.
17192 (interface_property_declaration): Ditto.
17193 (interface_method_declaration): Ditto.
17194 (interface_declaration): Ditto.
17196 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17198 * class.cs (Method::Define): Track the "static Main" definition to
17199 create an entry point.
17201 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17202 EntryPoint if we find it.
17204 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17205 (EmitContext::ig): Make this variable public.
17207 * driver.cs: Make the default output file be the first file name
17208 with the .exe extension.
17210 Detect empty compilations
17212 Handle various kinds of output targets. Handle --target and
17213 rename -t to --dumper.
17215 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17216 methods inherited from Expression return now an Expression. This
17217 will is used during the tree rewriting as we resolve them during
17220 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17221 the spec. Missing entirely is the information about
17222 accessability of elements of it.
17224 (Expression::ExprClassFromMemberInfo): New constructor for
17225 Expressions that creates a fully initialized Expression based on
17226 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17229 (Invocation::Resolve): Begin implementing resolution of invocations.
17231 * literal.cs (StringLiteral): Implement Emit.
17233 2001-09-05 Ravi Pratap <ravi@ximian.com>
17235 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17238 2001-09-04 Ravi Pratap <ravi@ximian.com>
17240 * cs-parser.jay (attribute_arguments): Implement actions.
17241 (attribute): Fix bug in production. Implement action.
17242 (attribute_list): Implement.
17243 (attribute_target): Implement.
17244 (attribute_target_specifier, opt_target_specifier): Implement
17245 (CheckAttributeTarget): New method to check if the attribute target
17247 (attribute_section): Implement.
17248 (opt_attributes): Implement.
17250 * attribute.cs : New file to handle attributes.
17251 (Attribute): Class to hold attribute info.
17253 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17254 (attribute_section): Modify production to use 2 different rules to
17255 achieve the same thing. 1 s/r conflict down !
17256 Clean out commented, useless, non-reducing dimension_separator rules.
17258 * class.cs (TypeContainer.attributes): New member to hold list
17259 of attributes for a type.
17260 (Struct::Struct): Modify to take one more argument, the attribute list.
17261 (Class::Class): Ditto.
17262 (Field::Field): Ditto.
17263 (Method::Method): Ditto.
17264 (Property::Property): Ditto.
17266 * cs-parser.jay (struct_declaration): Update constructor call to
17267 pass in the attributes too.
17268 (class_declaration): Ditto.
17269 (constant_declaration): Ditto.
17270 (field_declaration): Ditto.
17271 (method_header): Ditto.
17272 (fixed_parameter): Ditto.
17273 (parameter_array): Ditto.
17274 (property_declaration): Ditto.
17276 * constant.cs (Constant::Constant): Update constructor similarly.
17277 Use System.Collections.
17279 * parameter.cs (Parameter::Parameter): Update as above.
17281 2001-09-02 Ravi Pratap <ravi@ximian.com>
17283 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17284 (TypeContainer.delegates): New member to hold list of delegates.
17286 * cs-parser.jay (delegate_declaration): Implement the action correctly
17287 this time as I seem to be on crack ;-)
17289 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17291 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17292 tell whether an identifier represents a namespace.
17294 * expression.cs (NamespaceExpr): A namespace expression, used only
17295 temporarly during expression resolution.
17296 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17297 utility functions to resolve names on expressions.
17299 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17301 * codegen.cs: Add hook for StatementExpressions.
17303 * class.cs: Fix inverted test for static flag in methods.
17305 2001-09-02 Ravi Pratap <ravi@ximian.com>
17307 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17308 to make it coincide with MS' number.
17309 (Operator::CheckBinaryOperator): Ditto.
17311 * ../errors/errors.txt : Remove error numbers added earlier.
17313 * ../errors/cs1019.cs : Test case for error # 1019
17315 * ../errros/cs1020.cs : Test case for error # 1020
17317 * cs-parser.jay : Clean out commented cruft.
17318 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17319 used anywhere - non-reducing rule.
17320 (namespace_declarations): Non-reducing rule - comment out.
17322 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17323 with TypeContainer::AddEnum.
17325 * delegate.cs : New file for delegate handling classes.
17326 (Delegate): Class for declaring delegates.
17328 * makefile : Update.
17330 * cs-parser.jay (delegate_declaration): Implement.
17332 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17334 * class.cs (Event::Define): Implement.
17335 (Event.EventBuilder): New member.
17337 * class.cs (TypeContainer::Populate): Update to define all enums and events
17339 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17340 readonly fields for all these cases ?
17342 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17344 * class.cs (Property): Revamp to use the convention of making fields readonly.
17345 Accordingly modify code elsewhere.
17347 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17348 the Define method of the Property class.
17350 * class.cs : Clean up applied patch and update references to variables etc. Fix
17352 (TypeContainer::Populate): Update to define all the properties we have. Also
17353 define all enumerations.
17355 * enum.cs (Define): Implement.
17357 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17359 * cs-parser.jay (overloadable_operator): The semantic value is an
17360 enum of the Operator class.
17361 (operator_declarator): Implement actions.
17362 (operator_declaration): Implement.
17364 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17365 validity of definitions.
17366 (Operator::CheckBinaryOperator): Static method to check for binary operators
17367 (TypeContainer::AddOperator): New method to add an operator to a type.
17369 * cs-parser.jay (indexer_declaration): Added line to actually call the
17370 AddIndexer method so it gets added ;-)
17372 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17373 already taken care of by the MS compiler ?
17375 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17377 * class.cs (Operator): New class for operator declarations.
17378 (Operator::OpType): Enum for the various operators.
17380 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17382 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17383 ostensibly handle this in semantic analysis.
17385 * cs-parser.jay (general_catch_clause): Comment out
17386 (specific_catch_clauses, specific_catch_clause): Ditto.
17387 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17388 (catch_args, opt_catch_args): New productions.
17389 (catch_clause): Rewrite to use the new productions above
17390 (catch_clauses): Modify accordingly.
17391 (opt_catch_clauses): New production to use in try_statement
17392 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17393 and re-write the code in the actions to extract the specific and
17394 general catch clauses by being a little smart ;-)
17396 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17397 Hooray, try and catch statements parse fine !
17399 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17401 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17402 string from the hashtable of variables.
17404 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17405 I end up making that mistake ;-)
17406 (catch_clauses): Fixed gross error which made Key and Value of the
17407 DictionaryEntry the same : $1 !!
17409 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17411 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17413 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17414 when the add and remove accessors are specified.
17416 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17418 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17419 information about indexer_declarator.
17420 (indexer_declarator): Implement actions.
17421 (parsing_indexer): New local boolean used to keep track of whether
17422 we are parsing indexers or properties. This is necessary because
17423 implicit_parameters come into picture even for the get accessor in the
17424 case of an indexer.
17425 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17427 * class.cs (Indexer): New class for indexer declarations.
17428 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17429 (TypeContainer::indexers): New member to hold list of indexers for the
17432 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17434 * cs-parser.jay (add_accessor_declaration): Implement action.
17435 (remove_accessor_declaration): Implement action.
17436 (event_accessors_declaration): Implement
17437 (variable_declarators): swap statements for first rule - trivial.
17439 * class.cs (Event): New class to hold information about event
17441 (TypeContainer::AddEvent): New method to add an event to a type
17442 (TypeContainer::events): New member to hold list of events.
17444 * cs-parser.jay (event_declaration): Implement actions.
17446 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17448 * cs-parser.jay (dim_separators): Implement. Make it a string
17449 concatenating all the commas together, just as they appear.
17450 (opt_dim_separators): Modify accordingly
17451 (rank_specifiers): Update accordingly. Basically do the same
17452 thing - instead, collect the brackets here.
17453 (opt_rank_sepcifiers): Modify accordingly.
17454 (array_type): Modify to actually return the complete type string
17455 instead of ignoring the rank_specifiers.
17456 (expression_list): Implement to collect the expressions
17457 (variable_initializer): Implement. We make it a list of expressions
17458 essentially so that we can handle the array_initializer case neatly too.
17459 (variable_initializer_list): Implement.
17460 (array_initializer): Make it a list of variable_initializers
17461 (opt_array_initializer): Modify accordingly.
17463 * expression.cs (New::NType): Add enumeration to help us
17464 keep track of whether we have an object/delegate creation
17465 or an array creation.
17466 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17467 members to hold data about array creation.
17468 (New:New): Modify to update NewType
17469 (New:New): New Overloaded contructor for the array creation
17472 * cs-parser.jay (array_creation_expression): Implement to call
17473 the overloaded New constructor.
17475 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
17477 * class.cs (TypeContainer::Constructors): Return member
17478 constructors instead of returning null.
17480 2001-08-26 Miguel de Icaza <miguel@ximian.com>
17482 * typemanager.cs (InitCoreTypes): Initialize the various core
17483 types after we have populated the type manager with the user
17484 defined types (this distinction will be important later while
17485 compiling corlib.dll)
17487 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
17488 on Expression Classification. Now all expressions have a method
17489 `Resolve' and a method `Emit'.
17491 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
17492 generation from working. Also add some temporary debugging
17495 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17497 * codegen.cs: Lots of code generation pieces. This is only the
17498 beginning, will continue tomorrow with more touches of polish. We
17499 handle the fundamentals of if, while, do, for, return. Others are
17500 trickier and I need to start working on invocations soon.
17502 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17505 * codegen.cs (EmitContext): New struct, used during code
17506 emission to keep a context. Most of the code generation will be
17509 * cs-parser.jay: Add embedded blocks to the list of statements of
17510 this block. So code generation proceeds in a top down fashion.
17512 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17514 * statement.cs: Add support for multiple child blocks.
17516 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17518 * codegen.cs (EmitCode): New function, will emit the code for a
17519 Block of code given a TypeContainer and its ILGenerator.
17521 * statement.cs (Block): Standard public readonly optimization.
17522 (Block::Block constructors): Link children.
17523 (Block::Child): Child Linker.
17524 (Block::EmitVariables): Emits IL variable declarations.
17526 * class.cs: Drop support for MethodGroups here, delay until
17528 (Method::): Applied the same simplification that I did before, and
17529 move from Properties to public readonly fields.
17530 (Method::ParameterTypes): Returns the parameter types for the
17531 function, and implements a cache that will be useful later when I
17532 do error checking and the semantic analysis on the methods is
17534 (Constructor::GetCallingConvention): Renamed from CallingConvetion
17535 and made a method, optional argument tells whether this is a class
17536 or a structure to apply the `has-this' bit.
17537 (Method::GetCallingConvention): Implement, returns the calling
17539 (Method::Define): Defines the type, a second pass is performed
17540 later to populate the methods.
17542 (Constructor::ParameterTypes): implement a cache similar to the
17543 one on Method::ParameterTypes, useful later when we do semantic
17546 (TypeContainer::EmitMethod): New method. Emits methods.
17548 * expression.cs: Removed MethodGroup class from here.
17550 * parameter.cs (Parameters::GetCallingConvention): new method.
17552 2001-08-21 Miguel de Icaza <miguel@ximian.com>
17554 * class.cs (TypeContainer::Populate): Drop RootContext from the
17557 (Constructor::CallingConvention): Returns the calling convention.
17558 (Constructor::ParameterTypes): Returns the constructor parameter
17561 (TypeContainer::AddConstructor): Keep track of default constructor
17562 and the default static constructor.
17564 (Constructor::) Another class that starts using `public readonly'
17565 instead of properties.
17567 (Constructor::IsDefault): Whether this is a default constructor.
17569 (Field::) use readonly public fields instead of properties also.
17571 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
17572 track of static constructors; If none is used, turn on
17573 BeforeFieldInit in the TypeAttributes.
17575 * cs-parser.jay (opt_argument_list): now the return can be null
17576 for the cases where there are no arguments.
17578 (constructor_declarator): If there is no implicit `base' or
17579 `this', then invoke the default parent constructor.
17581 * modifiers.cs (MethodAttr): New static function maps a set of
17582 modifiers flags into a MethodAttributes enum
17583 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
17584 MethodAttr, TypeAttr to represent the various mappings where the
17585 modifiers are used.
17586 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
17588 2001-08-19 Miguel de Icaza <miguel@ximian.com>
17590 * parameter.cs (GetParameterInfo): Fix bug where there would be no
17593 * interface.cs (PopulateIndexer): Implemented the code generator
17594 for interface indexers.
17596 2001-08-17 Miguel de Icaza <miguel@ximian.com>
17598 * interface.cs (InterfaceMemberBase): Now we track the new status
17601 (PopulateProperty): Implement property population. Woohoo! Got
17602 Methods and Properties going today.
17604 Removed all the properties for interfaces, and replaced them with
17605 `public readonly' fields.
17607 2001-08-16 Miguel de Icaza <miguel@ximian.com>
17609 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
17610 initialize their hashtables/arraylists only when they are needed
17611 instead of doing this always.
17613 * parameter.cs: Handle refs and out parameters.
17615 * cs-parser.jay: Use an ArrayList to construct the arguments
17616 instead of the ParameterCollection, and then cast that to a
17619 * parameter.cs: Drop the use of ParameterCollection and use
17620 instead arrays of Parameters.
17622 (GetParameterInfo): Use the Type, not the Name when resolving
17625 2001-08-13 Miguel de Icaza <miguel@ximian.com>
17627 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
17628 and instead use public readonly fields.
17630 * class.cs: Put back walking code for type containers.
17632 2001-08-11 Miguel de Icaza <miguel@ximian.com>
17634 * class.cs (MakeConstant): Code to define constants.
17636 * rootcontext.cs (LookupType): New function. Used to locate types
17639 2001-08-08 Miguel de Icaza <miguel@ximian.com>
17641 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
17642 this System.Reflection code is. Kudos to Microsoft
17644 * typemanager.cs: Implement a type cache and avoid loading all
17645 types at boot time. Wrap in LookupType the internals. This made
17646 the compiler so much faster. Wow. I rule!
17648 * driver.cs: Make sure we always load mscorlib first (for
17649 debugging purposes, nothing really important).
17651 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
17652 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
17654 * rootcontext.cs: Lookup types on their namespace; Lookup types
17655 on namespaces that have been imported using the `using' keyword.
17657 * class.cs (TypeContainer::TypeAttr): Virtualize.
17658 (Class::TypeAttr): Return attributes suitable for this bad boy.
17659 (Struct::TypeAttr): ditto.
17660 Handle nested classes.
17661 (TypeContainer::) Remove all the type visiting code, it is now
17662 replaced with the rootcontext.cs code
17664 * rootcontext.cs (GetClassBases): Added support for structs.
17666 2001-08-06 Miguel de Icaza <miguel@ximian.com>
17668 * interface.cs, statement.cs, class.cs, parameter.cs,
17669 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
17670 Drop use of TypeRefs, and use strings instead.
17672 2001-08-04 Miguel de Icaza <miguel@ximian.com>
17676 * class.cs (Struct::Struct): set the SEALED flags after
17677 checking the modifiers.
17678 (TypeContainer::TypeAttr): new property, returns the
17679 TypeAttributes for a class.
17681 * cs-parser.jay (type_list): Oops, list production was creating a
17682 new list of base types.
17684 * rootcontext.cs (StdLib): New property.
17685 (GetInterfaceTypeByName): returns an interface by type name, and
17686 encapsulates error handling here.
17687 (GetInterfaces): simplified.
17688 (ResolveTree): Encapsulated all the tree resolution here.
17689 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
17692 * driver.cs: Add support for --nostdlib, to avoid loading the
17693 default assemblies.
17694 (Main): Do not put tree resolution here.
17696 * rootcontext.cs: Beginning of the class resolution.
17698 2001-08-03 Miguel de Icaza <miguel@ximian.com>
17700 * rootcontext.cs: Provide better error reporting.
17702 * cs-parser.jay (interface_base): set our $$ to be interfaces.
17704 * rootcontext.cs (CreateInterface): Handle the case where there
17705 are no parent interfaces.
17707 (CloseTypes): Routine to flush types at the end.
17708 (CreateInterface): Track types.
17709 (GetInterfaces): Returns an array of Types from the list of
17710 defined interfaces.
17712 * typemanager.c (AddUserType): Mechanism to track user types (puts
17713 the type on the global type hash, and allows us to close it at the
17716 2001-08-02 Miguel de Icaza <miguel@ximian.com>
17718 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
17719 RecordInterface instead.
17721 * cs-parser.jay: Updated to reflect changes above.
17723 * decl.cs (Definition): Keep track of the TypeBuilder type that
17724 represents this type here. Not sure we will use it in the long
17725 run, but wont hurt for now.
17727 * driver.cs: Smaller changes to accomodate the new code.
17729 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
17732 * rootcontext.cs (CreateInterface): New method, used to create
17733 the System.TypeBuilder type for interfaces.
17734 (ResolveInterfaces): new entry point to resolve the interface
17736 (CodeGen): Property, used to keep track of the code generator.
17738 2001-07-26 Miguel de Icaza <miguel@ximian.com>
17740 * cs-parser.jay: Add a second production for delegate_declaration
17743 (enum_body): Put an opt_comma here instead of putting it on
17744 enum_body or enum_member_declarations so we can handle trailing
17745 commas on enumeration members. Gets rid of a shift/reduce.
17747 (type_list): Need a COMMA in the middle.
17749 (indexer_declaration): Tell tokenizer to recognize get/set
17751 * Remove old targets.
17753 * Re-add the parser target.
17755 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17757 * cs-parser.jay: Add precendence rules for a number of operators
17758 ot reduce the number of shift/reduce conflicts in the grammar.
17760 2001-07-17 Miguel de Icaza <miguel@ximian.com>
17762 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
17765 Get rid of old crufty code.
17767 * rootcontext.cs: Use this to keep track of the parsed
17768 representation and the defined types available to the program.
17770 * gen-treedump.cs: adjust for new convention.
17772 * type.cs: Split out the type manager, and the assembly builder
17775 * typemanager.cs: the type manager will live here now.
17777 * cil-codegen.cs: And the code generator here.
17779 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
17781 * makefile: Fixed up for easy making.
17783 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17785 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
17788 (unary_expression): Expand pre_increment_expression and
17789 post_decrement_expression to reduce a shift/reduce.
17791 2001-07-11 Simon Cozens
17793 * cs-tokenizer.cs: Hex numbers should begin with a 0.
17795 Improve allow_keyword_as_indent name.
17797 2001-06-19 Miguel de Icaza <miguel@ximian.com>
17799 * Adjustments for Beta2.
17801 2001-06-13 Miguel de Icaza <miguel@ximian.com>
17803 * decl.cs: Added `Define' abstract method.
17804 (InTransit): new property, used to catch recursive definitions.
17806 * interface.cs: Implement `Define'.
17808 * modifiers.cs: Map Modifiers.constants to
17809 System.Reflection.TypeAttribute flags.
17811 * class.cs: Keep track of types and user-defined types.
17812 (BuilderInit): New method for creating an assembly
17813 (ResolveType): New function to launch the resolution process, only
17814 used by interfaces for now.
17816 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
17817 that are inserted into the name space.
17819 2001-06-08 Miguel de Icaza <miguel@ximian.com>
17821 * ARGH. I have screwed up my tree so many times due to the use of
17822 rsync rather than using CVS. Going to fix this at once.
17824 * driver.cs: Objetify driver. Load assemblies, use assemblies to
17827 2001-06-07 Miguel de Icaza <miguel@ximian.com>
17829 * Experiment successful: Use System.Type rather that our own
17832 2001-05-25 Miguel de Icaza <miguel@ximian.com>
17834 * cs-parser.jay: Removed nsAliases from here.
17836 Use new namespaces, handle `using XXX;'
17838 * namespace.cs: Reimplemented namespace handling, use a recursive
17839 definition of the class. Now we can keep track of using clauses
17840 and catch invalid using clauses.
17842 2001-05-24 Miguel de Icaza <miguel@ximian.com>
17844 * gen-treedump.cs: Adapted for all the renaming.
17846 * expression.cs (Expression): this class now has a Type property
17847 which returns an expression Type.
17849 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
17850 `Type', as this has a different meaning now in the base
17852 2001-05-22 Miguel de Icaza <miguel@ximian.com>
17854 * interface.cs, class.cs: Removed from all the sources the
17855 references to signature computation, as we can not do method
17856 signature computation during the parsing time, as we are not
17857 trying to solve at that point distinguishing:
17861 void a (NS.Blah x) {}
17864 Which depending on the context might be valid or not, as we do not
17865 know if Blah is the same thing as NS.Blah at that point.
17867 * Redid everything so the code uses TypeRefs now instead of
17868 Types. TypeRefs are just temporary type placeholders, that need
17869 to be resolved. They initially have a pointer to a string and the
17870 current scope in which they are used. This is used later by the
17871 compiler to resolve the reference to an actual Type.
17873 * DeclSpace is no longer a CIR.Type, and neither are
17874 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
17875 are all DeclSpaces, but no Types.
17877 * type.cs (TypeRefManager): This implements the TypeRef manager,
17878 which keeps track of all the types that need to be resolved after
17879 the parsing has finished.
17881 2001-05-13 Miguel de Icaza <miguel@ximian.com>
17883 * ARGH. We are going to have to store `foreach' as a class rather
17884 than resolving it, as we need to verify error 1579 after name
17885 resolution. *OR* we could keep a flag that says `This request to
17886 IEnumerator comes from a foreach statement' which we can then use
17887 to generate the error.
17889 2001-05-10 Miguel de Icaza <miguel@ximian.com>
17891 * class.cs (TypeContainer.AddMethod): we now add methods to the
17892 MethodGroup instead of the method hashtable.
17894 * expression.cs: Add MethodGroup abstraction, which gets us one
17895 step closer to the specification in the way we handle method
17898 * cs-parser.jay (primary_expression): qualified_identifier now
17899 tried to match up an identifier to a local variable reference or
17900 to a parameter reference.
17902 current_local_parameters is now a parser global variable that
17903 points to the current parameters for the block, used during name
17906 (property_declaration): Now creates an implicit `value' argument to
17909 2001-05-09 Miguel de Icaza <miguel@ximian.com>
17911 * parameter.cs: Do not use `param' arguments as part of the
17912 signature, per the spec.
17914 2001-05-08 Miguel de Icaza <miguel@ximian.com>
17916 * decl.cs: Base class for classes, structs and interfaces. This
17917 is the "Declaration Space"
17919 * cs-parser.jay: Use CheckDef for checking declaration errors
17920 instead of having one on each function.
17922 * class.cs: Factor out some code for handling error handling in
17923 accordance to the "Declarations" section in the "Basic Concepts"
17924 chapter in the ECMA C# spec.
17926 * interface.cs: Make all interface member classes derive from
17927 InterfaceMemberBase.
17929 2001-05-07 Miguel de Icaza <miguel@ximian.com>
17931 * Many things: all interfaces are parsed and generated in
17932 gen-treedump. Support for member variables, constructors,
17933 destructors, properties, constants is there.
17935 Beginning of the IL backend, but very little done, just there for
17938 2001-04-29 Miguel de Icaza <miguel@ximian.com>
17940 * cs-parser.jay: Fix labeled statement.
17942 * cs-tokenizer.cs (escape): Escape " and ' always.
17943 ref_line, ref_name: keep track of the line/filename as instructed
17944 by #line by the compiler.
17947 2001-04-27 Miguel de Icaza <miguel@ximian.com>
17949 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
17950 to match the values in System.CodeDOM.
17952 Divid renamed to Divide.
17954 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
17956 (Statements.set): remove.
17958 * System.CodeDOM/CodeCatchClause.cs: always have a valid
17961 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
17962 falseStatements always have valid values.
17964 * cs-parser.jay: Use System.CodeDOM now.