1 2007-06-15 Marek Safar <marek.safar@gmail.com>
3 * cs-parser.jay: Correctly split generic arguments and generic
4 parameters. Correctly implemented typeof of generic unbound types.
6 2007-06-14 Marek Safar <marek.safar@gmail.com>
8 * cs-parser.jay: Assembly and module attributes must precede all other
9 elements except using clauses and extern alias declarations.
11 2007-06-08 Marek Safar <marek.safar@gmail.com>
13 * cs-parser.jay: Uses newly defined GroupBy class.
15 * linq.cs (GroupBy): Implemented.
16 (AQueryClause.BuildQueryClause): Refactored to allow customize query
19 2007-06-08 Marek Safar <marek.safar@gmail.com>
21 * generics.cs (InferTypeArguments): Uses AnonymousMethodExpression
24 2007-06-06 Marek Safar <marek.safar@gmail.com>
26 * generics.cs (TypeArguments): New contructor fow known number of
29 2007-06-04 Raja R Harinath <rharinath@novell.com>
31 * linq.cs (Select.DoResolve): Pass the created parameters to the
34 2007-05-29 Raja R Harinath <rharinath@novell.com>
36 * cs-parser.jay: Update to changes in ToplevelBlock.
37 (top_current_block): Remove.
39 2007-05-27 Raja R Harinath <harinath@gmail.com>
41 * cs-parser.jay: Update to new ExplicitBlock invariant.
43 * cs-parser.jay: Update to changes introduced in Block and
46 2007-05-25 Raja R Harinath <rharinath@novell.com>
48 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
49 modifying current_block directly.
51 2007-05-22 Scott Peterson <lunchtimemama@gmail.com>
53 * cs-parser.jay: Implemented automatic properties (C# 3.0)
55 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
57 * cs-parser.jay: Improved grammar for object and collection
60 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
62 This code is contributed under the MIT X11 license
64 * cs-parser.jay: Added support for C# 3.0 language features:
65 Variable type inference (the "var" keyword)
69 Collection initialization
71 2007-05-06 Marek Safar <marek.safar@gmail.com>
74 * cs-parser.jay: Add special handling for coalescing operator.
76 2007-05-02 Raja R Harinath <rharinath@novell.com>
78 Fix regression in cs0631-3.cs
79 * cs-parser.jay (operator_declarator): Add opt_attributes to error
80 fallback. Make error fallback catch more cases.
82 2007-05-01 Miguel de Icaza <miguel@novell.com>
84 * cs-parser.jay: Allow parameters in operator declarations to have
87 2007-04-27 Miguel de Icaza <miguel@novell.com>
89 * generic.cs (TypeManager.LambdaInfer): now this routine will
90 make only one inference from the list of lambda expression that
91 have not participated in inferring a type.
93 (TypeManager.InferTypeArguments): The logic that drives the type
94 inference in lambda expressions is now driven here.
96 2007-04-23 Miguel de Icaza <miguel@novell.com>
98 * generic.cs: Large update to LambdaInfer, this is merely an
99 update to start the lambda type inference. It is by no means
100 complete. It is currently merely able to build a sample program
101 (with no iteration for the type parameters).
103 2007-04-12 Duncan Mak <duncan@a-chinaman.com>
105 * cs-parser.jay (interface_method_declaration_body): Fixed typo.
107 2007-04-08 Marek Safar <marek.safar@gmail.com>
109 * cs-parser.jay, linq.cs: First select implementation (hacky).
111 * generic.cs (InferTypeArguments): Simplified.
113 2007-03-31 Marek Safar <marek.safar@gmail.com>
115 * generic.cs (InferTypeArguments): Restored validation check.
116 (InferTypeArguments): Move all logic to Compatible method for re-usability.
118 2007-03-25 Marek Safar <marek.safar@gmail.com>
120 * generic.cs (InferTypeArguments): Infer arguments before they are used
121 for compatibility check.
123 2007-03-15 Marek Safar <marek.safar@gmail.com>
125 * generic.cs (InflatedConstraints): Fixed the check order.
126 (TypeArguments.Resolve): Small optimization for generic parameters.
127 (InferTypeArguments): Add infering support for anonymous methods.
129 2007-03-15 Martin Baulig <martin@ximian.com>
134 (TypeParameter.HasConstructorConstraint): Removed.
135 (ConstraintChecker.HasDefaultConstructor): Removed the
136 `TypeBuilder' argument here; correctly check for the ctor
137 constraint on type parameters.
139 2007-03-15 Martin Baulig <martin@ximian.com>
144 (TypeParameter): Create a `MemberCache' here as well. Note that
145 we need to create this on-demand when it's actually used.
147 2007-03-10 Marek Safar <marek.safar@gmail.com>
149 * generic.cs (TypeArguments.Resolve): Avoid redundant checks.
151 2007-03-09 Raja R Harinath <rharinath@novell.com>
153 * cs-parser.jay (WHERE): Move before QUERY_FIRST_TOKEN. 'where'
154 is a valid keyword outside a linq expression too.
156 2007-03-03 Marek Safar <marek.safar@gmail.com>
158 * cs-parser.jay: Implemented basic linq grammar.
160 * linq.cs: New file for hosting query specific classes.
162 2007-02-26 Marek Safar <marek.safar@gmail.com>
164 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
166 2007-02-20 Marek Safar <marek.safar@gmail.com>
169 * cs-parser.jay: Anonymous container starts at constructor declaration
170 and not at block beginning because it has to be usable in constructor
173 2007-02-18 Marek Safar <marek.safar@gmail.com>
175 A fix for bug #80493 by Atsushi Enomoto
176 * cs-parser.jay: Ignore invalid attribute target.
178 2007-02-15 Miguel de Icaza <miguel@novell.com>
180 * Remove the call to SetExpression for lambda expressions, we do
181 not actually need it.
183 Remove expression tracking code as its not needed.
185 2007-02-11 Miguel de Icaza <miguel@novell.com>
187 * cs-parser.jay (lambda_expression_body): when the body is an
188 expression add a statement of the form:
190 contextual-return expression.
192 Where `contextual-return' is similar to `return', the difference
193 being that if the delegate that the lambda will be converted to
194 has a void return type, it will check that the result is a
195 ExpressionStatement and the result is a plain ret (no return
196 values on the stack). If the return type of the delegate is of a
197 given type, this turns into a return with a value and does the
198 regular checking to check that the computed value can be
199 implicitly converted to the delegate return.
201 2007-01-30 Miguel de Icaza <miguel@novell.com>
203 * cs-parser.jay (anonymous_method_expression): move the
204 before/after productions to the start_anonymous and end_anonymous
205 methods so the code can be reused for lambda functions.
207 (lambda_expression_body): wrap expressions implicitly into a
210 (block): factor out the setup/teardown of parsing a block so we
211 can reuse that in lambda_expression_body
213 (lambda_expression): use new anonymous method helper methods.
215 2007-01-29 Miguel de Icaza <miguel@novell.com>
217 * cs-parser.jay: oob_stack make it static (am guessing that is why
218 we no longer initialize it anymore) and reuse it across
221 2007-01-28 Miguel de Icaza <miguel@novell.com>
223 * cs-parser.jay (open_parens): Introduce new non-terminal that
224 abstracts OPEN_PARENS and OPEN_PARENS_LAMBDA as the later can now
225 be returned in places where types are followed by identifiers
226 (this is expected in declaration, fixed, using, foreach and catch
229 Use open_parens in those places, keep OPEN_PARENS in the
232 cs-parser.jay: New grammar bits for parsing lambda expressions.
234 2007-01-28 Raja R Harinath <rharinath@novell.com>
236 Fix #80534, gtest-309.cs
237 * generic.cs (UnifyType): Rename from InferType. Make unification
238 of generic insts simpler and don't insist on inferring all generic
239 parameters in a single generic inst unification.
241 (InferGenericInstance): Remove.
242 Analysis and initial patch by David Mitchell <dmitchell@logos.com>.
244 2007-01-20 Marek Safar <marek.safar@gmail.com>
246 * cs-parser.jay: Better parameter error handling.
248 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
249 Raja R Harinath <rharinath@novell.com>
251 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
252 Note the order in which accessors are declared in the source.
254 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
256 * generic.cs (TypeParameter.FindMembers): Use the generic
257 constraints, not the constraints to check for methods (first fix
260 2006-12-30 Marek Safar <marek.safar@gmail.com>
262 * cs-parser.jay: Better syntax errors handling.
264 2006-11-21 Marek Safar <marek.safar@gmail.com>
266 * cs-parser.jay: Tiny change to work with mcs tokenizer.
268 * cs-tokenizer.cs: Remove after unification with mcs.
270 2006-10-28 Marek Safar <marek.safar@gmail.com>
273 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
276 2006-10-26 Marek Safar <marek.safar@gmail.com>
279 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
281 2006-10-25 Brian Crowell <brian@fluggo.com>
284 * generic.cs (CheckConstraints): Allow generic parameters with
285 inheritance constraints to satisfy reference type constraints.
287 2006-10-09 Martin Baulig <martin@ximian.com>
290 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
292 2006-09-25 Martin Baulig <martin@ximian.com>
294 * class.cs: Remove after unification with mcs source.
296 2006-09-24 Raja R Harinath <harinath@gmail.com>
298 * convert.cs: Remove after unification with mcs source.
300 2006-09-24 Marek Safar <marek.safar@seznam.cz>
302 * class.cs (MemberBase.VerifyClsCompliance): When method has type
303 parameters verify them as well.
305 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
306 the type parameter constraints.
307 (Generics.VerifyClsCompliance): Ditto.
309 2006-09-24 Marek Safar <marek.safar@seznam.cz>
311 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
312 for anonymous block with out argument.
314 2006-09-24 Marek Safar <marek.safar@seznam.cz>
316 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
317 not used private events only.
319 2006-09-23 Marek Safar <marek.safar@seznam.cz>
321 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
323 * cs-parser.jay: Parse correctly cast of default (T).
325 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
326 Store original type via EmptyConstantCast.
328 2006-09-22 Martin Baulig <martin@ximian.com>
330 * delegate.cs: Removed; this file is now shared with mcs.
332 * attribute.cs: Removed; this file is now shared with mcs.
334 2006-09-22 Martin Baulig <martin@ximian.com>
336 * ecore.cs: Removed; this file is now shared with mcs.
338 2006-09-21 Marek Safar <marek.safar@seznam.cz>
340 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
342 * ecore.cs (NullCast): Derives from NullConstant.
344 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
347 2006-09-21 Martin Baulig <martin@ximian.com>
349 * decl.cs: Removed; this file is now shared with mcs.
351 2006-09-21 Raja R Harinath <rharinath@novell.com>
353 * rootcontext.cs: Remove after unification with mcs source.
355 * report.cs: Remove after unification with mcs source.
356 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
358 (InitGenerics, CleanUpGenerics): Remove.
360 * support.cs: Remove after unification with mcs source.
362 2006-09-20 Raja R Harinath <rharinath@novell.com>
364 * codegen.cs: Remove after unification with mcs source.
366 2006-09-19 Martin Baulig <martin@ximian.com>
368 * expression.cs: Removed; this file is now shared with mcs.
370 2006-09-19 Martin Baulig <martin@ximian.com>
373 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
374 (TypeManager.DropGenericTypeArguments): Likewise.
375 (TypeManager.DropGenericMethodArguments): Likewise.
376 (TypeManager.GetTypeArguments): Likewise.
377 (TypeManager.HasGenericArguments): Likewise.
379 2006-09-19 Martin Baulig <martin@ximian.com>
381 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
383 2006-09-19 Martin Baulig <martin@ximian.com>
385 * typemanager.cs: Removed; this file is now shared with mcs.
387 2006-09-16 Raja R Harinath <rharinath@novell.com>
389 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
390 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
392 2006-09-16 Marek Safar <marek.safar@seznam.cz>
395 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
396 only if parent type is class.
397 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
400 2006-09-15 Marek Safar <marek.safar@seznam.cz>
403 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
405 * typemanager.cs(CSharpName): Converts NullType to null.
407 2006-09-15 Martin Baulig <martin@ximian.com>
409 * pending.cs: Removed; this file is now shared with mcs.
411 2006-09-15 Martin Baulig <martin@ximian.com>
413 * statement.cs: Removed; this file is now shared with mcs.
415 2006-09-15 Martin Baulig <martin@ximian.com>
417 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
419 * driver.cs: Removed the `--broken-cycles' argument.
421 2006-09-15 Martin Baulig <martin@ximian.com>
423 * namespace.cs: Removed; this file is now shared with mcs.
425 2006-09-15 Martin Baulig <martin@ximian.com>
427 * decl.cs (MemberName): Minor code cleanups.
429 2006-09-15 Martin Baulig <martin@ximian.com>
431 * parameter.cs: Removed; this file is now shared with mcs.
433 2006-09-15 Martin Baulig <martin@ximian.com>
435 * enum.cs: Removed; this file is now shared with mcs.
437 2006-09-15 Martin Baulig <martin@ximian.com>
439 * Makefile: Define `GMCS_SOURCE'.
441 * flowanalysis.cs: Removed; this file is now shared with mcs.
443 2006-09-15 Martin Baulig <martin@ximian.com>
445 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
446 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
447 doc.cs - they are now shared with mcs.
449 * gmcs.exe.sources: Include these files from ../mcs/.
451 2006-09-15 Martin Baulig <martin@ximian.com>
453 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
454 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
456 2006-09-14 Marek Safar <marek.safar@seznam.cz>
458 * assign.cs, ecore.cs, expression.cs: Share error message text.
459 * class.cs (FieldMember.Define): Check for variable of static type.
460 * decl.cs (check_type_parameter): Report correct type name.
461 * driver.cs (LoadAssembly): Uses error output for errors.
462 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
463 (TypeArguments.Resolve): Static class cannot be used as an argument.
464 * statement.cs (ResolveMeta): Constants cannot be generic types.
466 2006-09-12 Martin Baulig <martin@ximian.com>
468 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
470 * convert.cs (Convert.Array_To_IList): Moved here and correctly
471 implement it; fixes #79345.
473 2006-09-08 Marek Safar <marek.safar@seznam.cz>
475 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
477 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
479 * generic.cs: Improved error messages.
480 * typemanager.cs (RemoveGenericArity): Made public.
482 2006-09-08 Martin Baulig <martin@ximian.com>
484 * typemanager.cs (TypeManager.interlocked_type): New public field.
485 (TypeManager.int_interlocked_compare-exchange): New public field.
486 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
487 enumerator types here and call InitGenericCoreTypes().
488 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
489 after calling InitEnumUnderlyingTypes().
492 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
493 `classes_second_stage'.
495 2006-09-07 Marek Safar <marek.safar@seznam.cz>
497 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
499 * statement.cs (Block.Variables): Made public.
501 2006-09-07 Martin Baulig <martin@ximian.com>
504 (MainDriver): Revert r62663 from Marek; see #70506 for details.
506 2006-09-01 Martin Baulig <martin@ximian.com>
509 (TypeManager.IsIList): Also handle base classes and interfaces.
511 2006-09-01 Raja R Harinath <rharinath@novell.com>
514 * expression.cs (Invocation.MoreSpecific): Check for reference
517 2006-08-29 Miguel de Icaza <miguel@novell.com>
519 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
521 2006-08-17 Miguel de Icaza <miguel@novell.com>
523 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
524 #52019 and #79064, the use of the \uXXXX sequence in source code
525 to represent unicode characters.
527 2006-08-15 Marek Safar <marek.safar@seznam.cz>
529 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
531 * class.cs, ecore.cs, statement.cs: Merged to one error message.
533 2006-08-14 Raja R Harinath <rharinath@novell.com>
536 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
537 parameter too. This only avoids a parse error -- the semantic
538 error is caught elsewhere.
540 2006-08-13 Miguel de Icaza <miguel@novell.com>
542 * assign.cs: Catch attempts to assign to a method groups in += and
545 2006-08-13 Marek Safar <marek.safar@seznam.cz>
548 * cs-parser.jay: Don't destroy current array type by typeof of array's.
550 2006-08-12 Marek Safar <marek.safar@seznam.cz>
552 * cs-parser.jay: Check whether a constraint clause has already been
553 specified for type parameter.
554 * generic.cs (Constraints): Exposed location.
556 2006-08-12 Marek Safar <marek.safar@seznam.cz>
558 * class.cs (Method.Define): Issue a warning when generic method looks like
560 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
562 * report.cs: New warning number.
564 2006-08-09 Marek Safar <marek.safar@seznam.cz>
566 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
568 * decl.cs (MemberCache.FindMembers): When container is interface we need to
569 search all base interfaces as a member can be ambiguous.
570 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
571 Constructor member type filter.
572 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
573 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
574 reporting for returned memberinfos.
575 * report.cs: Updated.
576 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
577 version to work on all runtimes.
578 (TypeManager.RealMemberLookup): Removed members filtering.
580 2006-08-08 Raja R Harinath <rharinath@novell.com>
582 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
583 (PropertyExpr.EmitAssign): Likewise.
584 * expression.cs (Indirection.EmitAssign): Likewise.
585 (LocalVariableReference.EmitAssign): Likewise.
586 (ParameterReference.EmitAssign): Likewise.
587 (Invocation.EmitArguments): Likewise.
588 (ArrayAccess.EmitAssign): Likewise.
589 (IndexerAccess.EmitAssign): Likewise.
590 (This.EmitAssign): Likewise.
591 (ConditionalLogicalOperator.Emit): Likewise.
594 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
595 instead of ArrayList. If the hashtable has a LocalBuilder, don't
596 leave it in after returning it.
597 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
599 2006-08-06 Marek Safar <marek.safar@seznam.cz>
601 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
604 2006-08-05 Marek Safar <marek.safar@seznam.cz>
606 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
607 with different type names.
608 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
610 2006-08-03 Raja R Harinath <rharinath@novell.com>
612 Fix cs0146-3.cs and cs0146-4.cs.
613 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
614 enclosing types don't depend on the current type.
616 2006-08-02 Raja R Harinath <rharinath@novell.com>
619 * class.cs (TypeContainer.DoDefineMembers): Use
620 FindBaseMemberWithSameName on Parent, since we're interested in
621 whether we hide inherited members or not.
622 (FindBaseMemberWithSameName): Make slightly more robust.
625 * codegen.cs (IResolveContext.GenericDeclContainer): New.
626 (EmitContext): Implement new interface requirement.
627 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
628 * decl.cs (MemberCore): Likewise.
629 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
630 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
631 ec.GenericDeclContainer to check for generic parameters.
632 (SimpleName.DoSimpleNameResolve): Likewise.
633 * generic.cs (TypeParameter.DeclContainer): Remove override.
635 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
636 declspaces for doppelgangers too.
637 (UsingEntry): Implement IResolveContext.
638 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
639 'this' as the resolve context.
640 (LocalAliasEntry): Likewise.
642 Implement parts of #77403
643 * roottypes.cs (RootDeclSpace): New. Used to represent the
644 toplevel declaration space. Each namespace declaration introduces
645 a "partial" root declaretion space.
646 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
647 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
648 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
649 from 'current_namespace.SlaveDeclSpace'.
650 (namespace_declaration): Likewise.
651 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
652 check. It can't happen now.
653 * decl.cs (DeclSpace.LookupType): Likewise.
654 * driver.cs (MainDriver): Sanity check.
656 2006-08-01 Raja R Harinath <rharinath@novell.com>
658 * decl.cs (DeclSpace.FindNestedType): Remove.
659 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
660 LookupTypeContainer to get the container of the nested type.
661 * class.cs (TypeContainer.FindNestedType): Make non-override.
663 2006-07-31 Raja R Harinath <rharinath@novell.com>
665 * decl.cs (DeclSpace.PartialContainer): Move field from ...
666 * class.cs (TypeContainer.PartialContainer): ... here.
667 (TypeContainer.AddBasesForPart): New helper.
668 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
670 * cs-parser.jay (current_class): Convert to DeclSpace.
671 (struct_declaration, interface_declaration, class_declaration):
672 Use AddBasesForPart instead of .Bases directly.
673 * const.cs, iterators.cs: Update to changes.
675 2006-07-28 Raja R Harinath <rharinath@novell.com>
677 * class.cs (TypeContainer.AddMemberType): Rename from
679 (TypeContainer.AddMember): Rename from AddToMemberContainer.
680 (AddTypeContainer): New. Combine AddClassOrStruct and
682 (AddPartial): Update. Add 'is_partial' argument.
683 * roottypes.cs: Update to changes.
684 * cs-parser.jay (push_current_class): New helper for handling
685 current_container and current_class.
686 (struct_declaration, interface_declaration, class_declaration):
689 2006-07-26 Raja R Harinath <rharinath@novell.com>
691 * roottypes.cs: Rename from tree.cs.
693 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
694 * tree.cs (Tree, ITreeDump): Remove types.
695 * rootcontext.cs (tree, Tree): Remove fields.
696 (root, ToplevelTypes): New.
697 * *.cs: Update to rename.
699 * tree.cs (Tree.RecordDecl): Remove.
700 (RootTypes.AddToTypeContainer): Record the toplevel type in its
702 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
704 2006-07-23 Raja R Harinath <harinath@gmail.com>
706 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
707 DoFlowAnalysis and OmitStructFlowAnalysis here.
708 (ec.With): Rename from WithUnsafe and generalize.
709 (ec.WithCheckState): Remove. All users can be handled by 'With'.
710 (ec.WithFlowAnalyis): New.
711 * ecore.cs, expression.cs, statement.cs: Update.
713 2006-07-22 Raja R Harinath <harinath@gmail.com>
715 * statement.cs (Block.ResolveMeta): Simplify slightly.
717 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
718 multiple boolean fields. Convert InUnsafe, constant_check_state,
719 check_state to flags.
720 (CheckState, ConstantCheckState): Update.
721 (InUnsafe): New read-only property.
722 (FlagsHandle): Rename from CheckStateHandle and convert to handle
724 (WithUnsafe): New helper similar to WithCheckState.
725 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
726 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
728 2006-07-21 Raja R Harinath <rharinath@novell.com>
730 Make comparisons use the same IL irrespective of whether they're
731 in a 'checked' or 'unchecked' context: one of the issues in #78899
732 * codegen.cs (EmitContext.CheckState): Make read-only property.
733 (EmitContext.ConstantCheckState): Likewise.
734 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
735 helper that implement a save/restore stack for CheckState
736 values. This is the only way to change check-state.
737 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
738 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
739 (CheckedExpr.EmitBranchable): New forwarding method.
740 (UnCheckedExpr): Likewise.
741 * statement.cs (Block.ResolveMeta): Use WithCheckState.
742 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
743 (Checked.Resolve, checked.DoEmit): Likewise.
745 2006-07-21 Martin Baulig <martin@ximian.com>
747 * generic.cs (TypeManager.InferType): When inferring an array
748 type, also allow IList<T> and ICollection<T>. Fixes #78900.
750 2006-07-21 Martin Baulig <martin@ximian.com>
752 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
753 and allow IList`1 and all its base interfaces.
755 * convert.cs (Convert.ImplicitReferenceConversion): Allow
756 converting from an array-type of T to IList<T>.
758 2006-07-21 Martin Baulig <martin@ximian.com>
760 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
762 2006-07-20 Miguel de Icaza <miguel@novell.com>
764 * anonymous.cs: Cache the resolved anonymous delegate, and return
765 this so that the ResolveTopBlock is only triggered once, not
768 Currently we trigger ResolvetopBlock twice due to a first pass of
769 argument check compatibility, and a second pass that does the
772 2006-07-15 Marek Safar <marek.safar@seznam.cz>
774 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
776 * rootcontext.cs (Reset): Add helper_classes.
778 2006-07-15 Marek Safar <marek.safar@seznam.cz>
781 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
784 2006-07-13 Miguel de Icaza <miguel@novell.com>
786 * statement.cs (Lock): Handle expressions of type
787 TypeManager.null_type specially. Fixes #78770
789 2006-07-08 Marek Safar <marek.safar@seznam.cz>
791 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
794 2006-07-08 Marek Safar <marek.safar@seznam.cz>
796 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
797 for accessors as well.
798 * ecore.cs (EventExpr): Add AccessorTable.
800 2006-07-03 Martin Baulig <martin@ximian.com>
802 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
803 instances of value types.
805 * convert.cs (Convert.ExplicitConversion): Correctly handle
806 object->nullable conversions.
808 2006-07-01 Marek Safar <marek.safar@seznam.cz>
811 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
812 for CS0122 where appropriate.
813 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
815 (Filter): Assembly can be null in the case of top level attributes.
817 2006-06-28 Raja R Harinath <rharinath@novell.com>
820 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
821 no arguments, return 'false': nothing can be inferred.
823 2006-06-25 Marek Safar <marek.safar@seznam.cz>
827 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
828 is done at global level.
830 2006-06-24 Marek Safar <marek.safar@seznam.cz>
832 A fix for #77002, Implemented TypeForwarder support.
834 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
835 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
837 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
838 * typemanager.cs (): Add type_forwarder_attr_type.
840 2006-06-24 Marek Safar <marek.safar@seznam.cz>
842 * report.cs: Add CS0469 warning.
844 2006-06-22 Martin Baulig <martin@ximian.com>
847 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
848 for interfaces; fixes #78686, which is a modification of #78380
849 with interfaces instead of classes.
851 2006-06-21 Martin Baulig <martin@ximian.com>
853 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
854 the `try'-block, so we also report CS0016 etc. there.
856 2006-06-21 Martin Baulig <martin@ximian.com>
858 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
859 handle SetAssigned() and SetMemberIsUsed() for generic types;
862 2006-06-21 Martin Baulig <martin@ximian.com>
865 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
867 2006-06-21 Martin Baulig <martin@ximian.com>
869 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
870 also report CS1686 for parameters.
872 2006-06-21 Martin Baulig <martin@ximian.com>
874 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
875 instead of an error if the value is not implicitly convertible to
876 the switch types; fixes #77964.
878 2006-06-21 Raja R Harinath <rharinath@novell.com>
881 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
882 FieldBuilder is null.
885 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
886 'left' and 'right' before error-checking.
888 2006-06-19 Martin Baulig <martin@ximian.com>
891 (Convert.ImplicitConversionStandard): Cleanup and correctly
892 implement nullable conversions.
893 (Convert.ImplicitStandardConversionExists): Likewise.
894 (Convert.ExplicitConversion): Likewise.
896 2006-06-19 Martin Baulig <martin@ximian.com>
899 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
900 methods; make the ctors protected.
902 2006-06-19 Martin Baulig <martin@ximian.com>
904 Fixed #78380; added gtest-273.cs.
907 (Expression.ResolveAsBaseTerminal): Move the constraint checking
908 into ResolveAsTypeTerminal().
911 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
912 TypeManager.FindMembers() to check for the default ctor.
914 2006-06-18 Marek Safar <marek.safar@seznam.cz>
916 * generic.cs: Fixed NullableInfo accessibility.
918 2006-06-16 Martin Baulig <martin@ximian.com>
921 (Constraints.InflatedConstraints.inflate): Correctly inflate
922 generic types; fixes #78400.
924 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
926 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
928 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
929 (FieldExpr.DoResolve): likewise.
930 (PropertyExpr.InstanceResolve): likewise.
931 (EventExpr.InstanceResolve): likewise.
933 2006-06-15 Martin Baulig <martin@ximian.com>
936 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
937 argument; always allow a `null' label if true.
938 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
939 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
940 we have a `null' label and mark the new `null_target' label;
941 default to the `default' label.
942 (Switch.Resolve): Add support for nullable types. Fixes #78630.
944 2006-06-15 Martin Baulig <martin@ximian.com>
946 * class.cs (Operator.Define): Allow an implicit/explicit operator
947 to convert to/from a nullable value of the enclosing type.
949 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
950 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
953 (Convert.ImplicitStandardConversionExists): Add support for lifted
954 implicit/explicit conversions.
955 (Convert.ImplicitConversionStandard): Likewise.
957 2006-06-13 Martin Baulig <martin@ximian.com>
959 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
960 type arguments and create a ConstructedType if necessary. Fixes #78400.
962 2006-06-04 Marek Safar <marek.safar@seznam.cz>
964 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
965 attribute applicable tests for attribute argument.
967 2006-06-02 Raja R Harinath <rharinath@novell.com>
970 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
971 (Binary.OverloadResolve_PredefinedIntegral): New.
972 (Binary.OverloadResolve_PredefinedFloating): New.
973 (Binary.OverloadResolve_PredefinedString): New.
974 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
975 Follow the standard more closely, and treat numeric promotions in
976 terms of overload resolution.
977 (Binary.CheckShiftArguments): Simplify.
979 2006-06-01 Raja R Harinath <rharinath@novell.com>
981 * flowanalysis.cs (MyBitVector): Simplify representation.
982 (MyBitVector.Clone): Avoid allocating BitArray.
983 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
984 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
985 (*): Update. Change all references to MyBitVector.And and
986 MyBitVector.Or to &= and |=.
988 2006-05-31 Raja R Harinath <rharinath@novell.com>
990 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
991 Use bne.un instead of ceq+brfalse.
994 * typemanager.cs (IsUnmanagedType): Disallow generic types and
997 2006-05-29 Raja R Harinath <rharinath@novell.com>
1000 * cs-parser.jay (formal_parameter_list): Extend the pattern below
1001 to param arguments too.
1003 2006-05-26 Miguel de Icaza <miguel@novell.com>
1005 * cs-parser.jay: Catch another parsing form for arglist being
1006 followed by other arguments. Fixes #78313.
1008 2006-05-25 Raja R Harinath <rharinath@novell.com>
1011 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
1012 also when one of the operands is a null literal.
1013 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
1014 to improve clarity, and generate slightly better code.
1016 2006-05-24 Raja R Harinath <rharinath@novell.com>
1018 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
1019 checking of out parameters to ...
1020 (FlowBranchingToplevel.Merge): ... here.
1021 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
1022 set, propagate the origin upward, and only complain if there was
1024 (FlowBranchingException.AddContinueOrigin): Likewise.
1025 (FlowBranchingException.AddReturnOrigin): Likewise.
1026 (FlowBranchingException.AddGotoOrigin): Likewise.
1028 2006-05-23 Raja R Harinath <rharinath@novell.com>
1030 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
1031 unreachable, skip it.
1032 (FlowBranchingException.Merge): Always propagate jumps, even if
1033 the finally block renders subsequent code unreachable.
1035 2006-05-18 Raja R Harinath <rharinath@novell.com>
1038 * statement.cs (Goto.Resolve): Move responsibility for resolving
1039 'goto' to FlowBranching.AddGotoOrigin.
1040 (Goto.SetResolvedTarget): New. Callback to set the
1041 LabeledStatement that's the target of the goto.
1042 (Goto.DoEmit): Use Leave instead of Br when crossing an
1043 unwind-protect boundary.
1044 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
1045 LookupLabel and adjust to new semantics.
1046 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
1047 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
1048 Goto.SetResolvedTarget to update target.
1049 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
1050 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
1051 AddBreakOrigin & co. Delay propagation until ...
1052 (FlowBranchingException.Merge): ... this.
1054 * statement.cs (Block.Resolve): Always depend on flow-branching to
1055 determine unreachability. Kill workaround that originally emitted
1056 only one statement after an "unreachable" label (see infloop in
1059 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
1060 This is still "wrong", but anything better would probably need a
1061 multi-pass algorithm.
1062 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
1063 usage vector. Force current usage vector to be reachable, to
1064 optimistically signify backward jumps.
1065 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
1067 (FlowBranchingLabeled.Merge): New. If no backward jump was
1068 detected, return the original salted-away usage vector instead,
1069 updated with appropriate changes. Print unreachable warning if
1071 * statement.cs (Block.Resolve): Don't print unreachable warning on
1072 a labeled statement.
1074 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
1076 * driver.cs: Pass filename without path to AssemblyBuilder's
1077 AddResourceFile. Fixes bug #78407.
1079 2006-05-17 Raja R Harinath <rharinath@novell.com>
1081 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
1082 * flowanalysis.cs (FlowBranchingLabeled): ... here.
1083 (FlowBranching.MergeChild): Overwrite
1084 reachability information from Labeled branchings too.
1086 2006-05-16 Raja R Harinath <rharinath@novell.com>
1088 * statement.cs (Goto.Resolve): Merge jump origins here ...
1089 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
1091 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
1092 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
1093 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
1094 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
1096 * statement.cs (Goto.Resolve): ... not here.
1097 (Goto.Emit): Remove CS1632 check.
1099 2006-05-14 Marek Safar <marek.safar@seznam.cz>
1101 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
1104 2006-05-11 Raja R Harinath <rharinath@novell.com>
1106 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
1107 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
1108 (FlowBranchingException.Label): Likewise.
1110 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
1112 (MyBitVector.Or): Use it to avoid losing information (Count).
1113 (FlowBranching.MergeOrigins): Likewise.
1115 * flowanalysis.cs (UsageVector.IsDirty): Remove.
1116 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
1117 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
1118 (UsageVector.ToString): Simplify.
1119 (UsageVector.MergeSiblings): Move here from ...
1120 (FlowBranching.Merge): ... here.
1121 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
1124 2006-05-10 Raja R Harinath <rharinath@novell.com>
1126 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
1127 null bitvector is treated as all-true.
1129 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
1130 (MyBitVector): Rationalize invariants. 'vector != null' implies
1131 that we have our own copy of the bitvector. Otherwise,
1132 'InheritsFrom == null' implies all inherited bits are true.
1134 2006-05-09 Marek Safar <marek.safar@seznam.cz>
1136 * statement.cs (LocalInfo): Add IsConstant.
1137 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
1138 local variable for constants.
1140 2006-05-09 Raja R Harinath <rharinath@novell.com>
1142 * flowanalysis.cs (MyBitVector.Empty): New.
1143 (MyBitVector): Don't allow InheritedFrom to be null.
1144 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
1145 (UsageVector, FlowBranching): Update to changes.
1147 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
1148 recursion. The 'Parent == null' condition isn't sufficient for
1150 (FlowBranching.AddBreakOrigin): Likewise.
1151 (FlowBranching.AddContinueOrigin): Likewise.
1152 (FlowBranching.AddReturnOrigin): Likewise.
1153 (FlowBranching.StealFinallyClauses): Likewise.
1154 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
1155 (FlowBranching.CheckOutParameters): Likewise.
1156 (FlowBranchingToplevel): Terminate all the above recursions here.
1157 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
1158 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
1160 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
1162 (FlowBranchingToplevel): New. Empty for now.
1163 (FlowBranching.MergeTopBlock): Update.
1164 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
1165 branching for the anonymous delegate.
1166 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
1168 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
1169 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
1170 information at the start of the merge. Reorganize.
1172 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1174 * class.cs (MethodData.Define): Method cannot implement interface accessor.
1176 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1178 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
1179 to newly introduced ctor.
1181 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
1182 message to one place.
1183 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
1186 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1188 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
1190 * ecore.cs (Expression.ResolveAsConstant): Updated.
1192 * statement.cs (ResolveMeta): Updated.
1194 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1196 * cs-parser.jay: __arglist cannot be used in initializer.
1198 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1201 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
1204 2006-05-05 Raja R Harinath <rharinath@novell.com>
1206 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
1207 (LabeledStatement): Add 'name' parameter.
1208 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
1209 (Block.AddLabel): Update to changes.
1210 * cs-parser.jay (labeled_statement): Likewise.
1212 * flowanalysis.cs (BranchingType.Labeled): New.
1213 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
1214 (FlowBranchingLabeled): New. Does nothing for now, but will
1215 eventually handle 'goto' flows.
1216 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
1217 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
1218 that's terminated ...
1219 (Block.Resolve): ... here.
1221 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
1222 (UsageVector.MergeFinallyOrigins): Likewise.
1223 (FlowBranching.InTryOrCatch): Likewise.
1224 (FlowBranching.AddFinallyVector): Likewise.
1225 (FlowBranchingException): Update to changes.
1228 * statement.cs (Return.Resolve): Move error checking to ...
1229 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
1230 (FlowBranchingException): Handle return origins like break and
1232 (FlowBranching.UsageVector.CheckOutParameters): Remove.
1234 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1237 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
1240 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1243 * class.cs (MethodData.Define): Do public accessor check only when method
1244 implements an interface.
1246 2006-05-04 Raja R Harinath <rharinath@novell.com>
1248 Remove special handling of 'break'
1249 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
1250 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
1251 (UsageVector.Break): Remove.
1252 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
1254 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
1256 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
1257 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1259 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1262 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1263 be the interface member.
1265 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1268 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1269 for emitting small (int) values.
1271 2006-05-03 Raja R Harinath <rharinath@novell.com>
1274 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1275 control-flow passes through the 'finally' after merging-in all the
1276 control-flows from 'try' and the 'catch' clauses.
1278 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1279 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1280 always true at the only non-recursive entry point.
1281 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1282 FlowBranchingBreakable.
1283 (FlowBranchingLoop): Remove.
1284 * statement.cs (Return.DoResolve): Update to changes.
1287 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1288 (FlowBranching.CreateBranching): Handle it: create a
1289 FlowBranchingContinuable.
1290 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1291 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1292 except that it handles the 'continue' command.
1293 (FlowBranching.UsageVector.MergeOrigins): Rename from
1295 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1296 except that it overrides AddContinueOrigin.
1297 (FlowBranchingException): Override AddContinueOrigin, similar to
1299 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1300 Create a new branching around the embedded statement.
1301 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1302 control flow after the embedded statement.
1303 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1305 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1306 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1307 FlowBranchingBreakable.
1308 (FlowBranchingSwitch): Remove.
1311 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1312 error reporting to ...
1313 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1314 Rename from 'AddBreakVector'. Add new location argument. Return
1315 a bool indicating whether the 'break' crosses an unwind-protect.
1316 (FlowBranchingException.AddBreakOrigin): Add.
1317 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1318 flowbranching after updating with the effects of the 'finally'
1320 (FlowBranchingBreakable): New common base class for
1321 FlowBranchingLoop and FlowBranchingSwitch.
1323 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1325 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1327 2006-05-02 Raja R Harinath <rharinath@novell.com>
1329 * statement.cs (Do.Resolve): If the loop is infinite, set the
1331 (While.Resolve, For.Resolve): Set a barrier after the embedded
1332 statement. There's no direct control flow that goes from the end
1333 of the embedded statement to the end of the loop.
1334 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1335 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1336 above ensure that the reachability is correctly computed.
1338 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1339 (UsageVector.MergeBreakOrigins): If the current path is
1340 unreachable, treat it as if all parameters/locals are initialized.
1341 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1342 infinite loops before merging-in break origins.
1344 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1345 (Reachability.Reachable): Split part into ...
1346 (Reachability.Unreachable): ... this. Simplify.
1347 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1349 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1350 (Reachability.SetThrowsSometimes): Likewise.
1351 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1352 TriState.Always, use corresponding property.
1353 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1354 (Block.Resolve): Likewise. Remove some redundant checks.
1356 2006-05-02 Raja R Harinath <harinath@gmail.com>
1358 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1359 (Reachability.Meet): Don't bother checking AlwaysThrows --
1360 barrier is always set.
1361 (FlowBranchingBlock.Merge): Likewise.
1363 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1365 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1366 defined, so it's references should also compile only for NET_2_0
1367 (as occurs in mcs version)
1369 2006-05-01 Raja R Harinath <harinath@gmail.com>
1371 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1372 checks for unreachable.
1374 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1377 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1379 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1380 whether field is really assigned.
1382 2006-04-30 Raja R Harinath <harinath@gmail.com>
1384 * flowanalysis.cs (Reachability): Make 4-argument constructor
1386 (Reachability.Meet): Rename from 'And'. Remove static variant.
1387 (Reachability.Always): Rename from the highly misleading
1388 'Reachability.Never'.
1389 (FlowBranching.Merge): Update to changes. Mark an impossible
1390 situation with a 'throw'.
1391 (*): Update to changes.
1393 2006-04-29 Raja R Harinath <harinath@gmail.com>
1395 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1397 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1398 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1399 (*): Update to changes.
1400 * statement.cs: Update to changes.
1402 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1405 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1407 2006-04-28 Raja R Harinath <harinath@gmail.com>
1409 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1412 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1413 argument to two arguments: an usage-vector and a bool. Move call
1414 to FlowBranching.Merge () ...
1415 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1417 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1418 handling of loop and switch reachability to ...
1419 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1421 2006-04-27 Raja R Harinath <harinath@gmail.com>
1423 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1424 handling to FlowBranchingLoop.InLoop.
1425 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1427 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1430 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1431 anonymous method is allowed from AnonymousContainer here.
1433 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1435 2006-04-24 Raja R Harinath <rharinath@novell.com>
1438 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1440 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1443 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1444 (DoubleConstant.Reduce): Ditto.
1446 2006-04-23 Raja R Harinath <rharinath@novell.com>
1448 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1449 Remove 'lvalue_right_side' argument. Move parts to ...
1450 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1451 (LocalVariable.DoResolveLValue): ... these.
1453 2006-04-21 Raja R Harinath <rharinath@novell.com>
1456 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1457 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1458 (LocalVariableReference.DoResolveBase): Use it to implement new
1460 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1461 (Argument.Resolve): Simplify. Move CS1510 check ...
1462 * ecore.cs (Expression.ResolveLValue): ... here.
1463 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1464 (PropertyExpr.DoResolveLValue): Likewise.
1465 (FieldExpr.Report_AssignToReadonly): Likewise.
1466 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1467 LValueMemberAccess or LValueMemberOutAccess on instance depending
1469 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1470 DoResolve as appropriate.
1472 2006-04-20 Raja R Harinath <rharinath@novell.com>
1475 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1476 implicit conversions on 'out' and 'ref' arguments.
1478 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1479 improve clarity. Remove dead code.
1482 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1483 (Catch.Resolve): Resolve VarBlock if it exists.
1485 2006-04-19 Miguel de Icaza <miguel@novell.com>
1487 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1488 twice, this was some residual code, the enumerator was emitted
1489 properly in the two branche of if later.
1493 Thanks to Martin for finding the source of the problem
1495 2006-04-19 Raja R Harinath <rharinath@novell.com>
1497 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1498 cast is never an lvalue.
1499 (Cast.DoResolve, Cast.ResolveRest): Combine.
1500 (Argument.Emit): Simplify slightly. Move 'Expr is
1501 IMemoryLocation' check ...
1502 (Argument.Resolve): ... here.
1503 (Argument.Error_LValueRequired): Remove. Inline into only user.
1505 Simplifications. Fix cs0191-2.cs
1506 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1507 CS1649 and CS1651 to ...
1508 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1509 the actual selection of the error code and message to a lookup
1510 table. Add a dummy return value to simplify callsites.
1511 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1512 readonly fields of other instances of the same type. Move CS0197
1514 * expression.cs (Argument.Resolve): ... here. Simplify code.
1515 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1516 resolution of an out or ref argument. The code simplification
1517 above uses this invariant.
1519 2006-04-18 Raja R Harinath <rharinath@novell.com>
1521 Possibly fix #77752. Fix cs1690-[4-7].cs.
1522 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1523 CheckMarshallByRefAccess. Drop parameter.
1524 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1526 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1528 * report.cs (AllWarnings): Add CS1690.
1529 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1531 (LocalVariableReference.DoResolveBase): Update.
1533 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1535 * class.cs (MethodOrOperator): Moved common parts from method class.
1536 detect obsolete attributes.
1537 (Method.Define): Simplified as it reuses code from base.
1538 (Constructor.ValidAttributeTargets): Fixed issue found during
1540 (Destructor.ValidAttributeTargets): Fixed issue found during
1542 (Operator): Finished refactoring set off by #78020. Operator class is now
1543 ordinary method class.
1545 * anonymous.cs: Updated.
1547 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1549 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1551 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1553 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1554 detect obsolete attributes.
1555 (Method.CreateEmitContext): Moved to MethodOrOperator.
1557 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1560 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1561 customized exception to make crash detection easier.
1562 (MethodOrOperator): Started to work on new base class for methods and
1564 (Method): Derives from MethodOrOperator.
1565 (Constructor.Emit): Emits its own attributes.
1566 (AbstractPropertyEventMethod.Emit): Ditto.
1567 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1569 (Operator.Emit): It's temporary more tricky than should be.
1571 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1573 * report.cs (InternalErrorException): Add ctor with inner exception.
1575 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1578 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1581 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1584 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1587 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1589 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1590 attribute is present and Guid not.
1591 (Interface.ApplyAttributeBuilder): Ditto.
1593 * attribute.cs: Add error message.
1595 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1599 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1600 sources (it's composite) so hold them in extra array as they are used in
1601 Emit phase only. It worked in the previous versions by mistake.
1602 (Attribute.Emit): Emit attribute for more owners when exist.
1604 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1605 it has now different behaviour.
1607 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1609 * constant.cs (Constant.IsDefaultInitializer): New method.
1611 * class.cs: Updated.
1613 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1614 re-initialize default values. It saves KBs almost for every assembly.
1615 Thanks Zoltan for the idea.
1616 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1617 (ArrayCreation.DoResolve): Resolve only once.
1618 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1619 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1621 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1623 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1626 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1628 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1629 in an embedded statement too.
1631 2006-04-01 Raja R Harinath <rharinath@novell.com>
1634 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1638 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1641 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1642 arguments before checking whether a type is reflected or not.
1645 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1646 definition doesn't take part in overload resolution.
1647 (Invocation.IsParamsMethodApplicable): Likewise.
1648 (Invocation.OverloadResolve): When replacing a reflected override
1649 method with its base definition, ensure that type arguments are
1652 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1656 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1659 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1661 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1663 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1666 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1667 LocalTemporary change.
1669 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1671 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1672 initializers optimization.
1673 (ClassOrStruct.TypeAttr): Moved from modifiers.
1674 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1675 (FieldBase.ResolveInitializer): Resolves initializer.
1676 (FieldBase.HasDefaultInitializer): New property.
1678 * cs-parser.jay: Removed message.
1680 * expression.cs (CompilerGeneratedThis): New specialization.
1682 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1684 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1686 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1688 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1690 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1691 be now EnumConstants only.
1693 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1695 * attribute.cs, driver.cs: Reset more caches.
1697 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1699 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1701 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1703 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1704 for easier reuse. Updated all overrides.
1705 (IntegralConstant): New base class for all integral constants.
1706 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1707 of the constant range, report custom error.
1708 (UIntConstant.Reduce): Fixed uint conversion.
1710 * ecore.cs, literal.cs: Reduce updates.
1712 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1716 * class.cs (Constructor.Define): Removed extra if for default ctors.
1717 A patch from Atsushi Enomoto.
1719 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1721 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1722 GetAttributableValue.
1724 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1727 * convert.cs (ImplicitConversionRequired): Error message moved to
1730 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1731 automatic implicit conversion of an output value.
1732 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1734 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1736 (TypeOf.GetAttributableValue): Add extra handling for object type.
1738 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1739 special error message.
1741 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1743 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1745 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1746 compatible with MS runtime.
1748 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1750 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1751 attribute arguments here.
1753 * class.cs (Indexer.Define): The check was moved to attribute class.
1755 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1757 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1759 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1761 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1763 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1766 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1768 * doc-bootstrap.cs : fix build.
1770 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1772 * expression.cs (StringConcat.Append): Issue a warning when empty string
1775 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1777 * assign.cs (CompoundAssign.ResolveSource): Removed.
1779 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1782 * class.cs (TypeContainer.FindMethods): Removed.
1783 (TypeContainer.CheckMemberUsage): Made static.
1785 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1787 * constant.cs (CheckRange): Removed unused type argument.
1788 (CheckUnsigned): Removed unused type argument.
1790 * cs-parser.jay: Updated after MemberAccess clean up.
1791 Uses Length for empty string test.
1793 * cs-tokenizer.cs: Uses Length for empty string test.
1794 (IsCastToken): Made static.
1795 (is_hex): Made static.
1796 (real_type_suffix): Made static.
1798 * decl.cs (SetupCache): Made static.
1799 (OnGenerateDocComment): Removed unused ds argument.
1801 * delegate.cs (VerifyDelegate): Removed unused argument.
1803 * doc.cs: Uses Length for empty string test.
1805 * driver.cs: Uses Length for empty string test.
1807 * enum.cs (IsValidEnumType): Made static
1809 * expression.cs (EnumLiftUp): Removed unused argument.
1810 (ResolveMethodGroup): Ditto.
1811 (BetterConversion): Ditto.
1812 (GetVarargsTypes): Ditto.
1813 (UpdateIndices): Ditto.
1814 (ValidateInitializers): Ditto.
1815 (MemberAccess.ctor): Ditto.
1816 (GetIndexersForType): Ditto.
1818 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1820 * iterators.cs: Updated after MemberAccess clean up.
1822 * location.cs: Uses Length for empty string test.
1824 * namespace.cs: Uses Length for empty string test.
1826 * report.cs (CheckWarningCode): Made static.
1828 * statement.cs (LabeledStatement): Removed unused argument.
1830 * typemanager.cs (FilterNone): Removed.
1832 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1834 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1837 * class.cs: Updated.
1839 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1841 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1843 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1847 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1849 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1850 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1851 Add more error reporting; Fixed issue with params.
1853 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1855 * cs-parser.jay: AnonymousMethod requires host container.
1857 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1859 2006-03-18 Raja R Harinath <harinath@gmail.com>
1861 * class.cs: Change 'TypeContainer ds' constructor argument to
1862 'DeclSpace parent'. Some classes were missed below due to
1863 different naming convention.
1865 * class.cs (MemberCore.Parent): Delete. This makes the
1866 ParentContainer changes below enforceable by the compiler.
1868 Treat pointers to enclosing declaration space as 'DeclSpace', not
1870 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
1871 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
1873 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
1875 (Block.AddThisVariable): Likewise.
1876 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
1877 (AbstractPropertyEventMethod.Emit): Likewise.
1878 (AbstractPropertyEventMethod.EmitMethod): Likewise.
1879 (GetMethod.Define, SetMethod.Define): Likewise.
1880 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
1881 (DelegateMethod.EmitMethod): Likewise.
1883 Fix regression test-partial-13.cs.
1884 Rationalize use of PartialContainer. Ensure that the partial
1885 class semantics can be tied to type-correctness, i.e., any
1886 violation will cause a compile error.
1887 * class.cs, const.cs: Access all fields that belong to class
1888 TypeContainer via ParentContainer. Arguments of EmitContexts and
1889 Resolve()-like functions still use 'Parent'.
1891 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
1892 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
1893 (PropertyMethod.CheckModifiers): Remove unused argument.
1894 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
1897 2006-03-28 Raja R Harinath <rharinath@novell.com>
1899 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
1901 2006-03-17 Raja R Harinath <harinath@gmail.com>
1903 Make semantics of PartialContainer simpler.
1904 * decl.cs (DeclSpace.IsPartial): Remove.
1905 * class.cs (TypeContainer.IsPartial): Likewise.
1906 (TypeContainer..ctor): Set PartialContainer to point to self.
1907 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
1908 (TypeContainer.FindNestedType): Likewise.
1909 (MemberCore.ParentContainer): Simplify. Remove deprecation.
1911 2006-03-17 Marek Safar <marek.safar@seznam.cz>
1913 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
1915 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1917 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
1920 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1922 * class.cs (Operator.Define): An error for base conversion was not
1925 2006-03-13 Marek Safar <marek.safar@seznam.cz>
1927 A fix for #77593, #77574.
1929 * class.cs (MethodCore.CheckBase): Another if for operator.
1931 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1935 * expression.cs (VerifyArgumentsCompat): Reverted to double error
1936 reporting, it's more tricky than I thought.
1938 2006-03-09 Marek Safar <marek.safar@seznam.cz>
1940 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
1943 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
1944 (DelegateCreation.ImplicitStandardConversionExists): New method for just
1947 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
1950 2006-03-04 Marek Safar <marek.safar@seznam.cz>
1954 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
1955 (Event.Define): ditto
1956 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
1958 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
1959 Removed redundant code and set NewSlot for Invoke method too.
1961 * parameter.cs (Parameters.ctor): Add custom, type ctor.
1962 (Parameters.MergeGenerated): New method. Use this method when you merge
1963 compiler generated argument with user arguments.
1965 2006-03-03 Marek Safar <marek.safar@seznam.cz>
1967 * attribute.cs (ResolveAsTypeTerminal): Removed.
1969 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
1970 specialization for predefined types; 30% speed up.
1971 Finally placed obsolete check to right place.
1972 (Expression.ResolveType): Removed.
1974 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
1975 Updated after ResolveType was removed.
1977 * expression.cs (Cast.ctor): Check void cast.
1978 (Binary.ResolveAsTypeTerminal): Is never type.
1979 (Conditional.ResolveAsTypeTerminal): Is never type.
1981 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
1983 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1985 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
1987 2006-03-23 Martin Baulig <martin@ximian.com>
1989 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
1990 type check if either of the types is an open generic type.
1992 2006-03-23 Martin Baulig <martin@ximian.com>
1995 (Convert.ExplicitTypeParameterConversion): New method; implement
1996 explicit type parameter conversions.
1998 2006-03-23 Martin Baulig <martin@ximian.com>
2000 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
2001 blindly allow all conversions if we do not have any constraints.
2003 2006-02-27 Marek Safar <marek.safar@seznam.cz>
2005 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
2006 these two separated members to simplify the code.
2007 (Attribute.Resolve): Refactored to use new fields and methods.
2008 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
2009 implemented obsolete attribute checking.
2010 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
2011 implemented obsolete checking again. It look line never ending quest ;-)
2012 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
2014 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
2016 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
2018 *class.cs (Property.Define): Add RegisterProperty call.
2020 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
2021 argument groups (only 2).
2023 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
2024 encoding expression to arguments.
2025 (Expression.ExprClassToResolveFlags): Just turned to property.
2027 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
2028 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
2029 optimized as well as implemented support for zero-length attributes.
2031 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
2032 Add caching of PropertyInfo's.
2034 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2036 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
2037 error multiple times.
2039 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2041 New partial class implementation.
2042 A fix for #77027, #77029, #77403
2044 * attribute.cs (Attributable): Made attributes protected.
2046 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
2047 the replacements of ClassPart and PartialContainer.
2048 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
2049 (TypeContainer.AddInterface): Ditto.
2050 (TypeContainer.AddPartial): The main method for partial classes. It checks
2051 for errors and merges ModFlags and attributes. At the end class is added to
2053 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
2055 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
2056 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
2057 from the rest of partial classes.
2058 (TypeContainer.GetClassBases): Simplified.
2059 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
2061 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
2062 (TypeContainer.HasExplicitLayout): Uses Flags now.
2063 (PartialContainer): Removed.
2064 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
2065 (StaticClass): Was merged with Class.
2066 (Class.GetClassBases): class and static class bases are verified here.
2067 (Class.TypeAttr): Added static attributes when class is static.
2068 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
2069 (MemberBase): In some cases we need to call parent container for partial
2070 class. It should be eliminated but it's not easy now.
2072 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
2074 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
2075 partial classed to accumulate class comments.
2076 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
2078 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
2080 * driver.cs (MainDriver): Tree.GetDecl was removed.
2082 * modifiers.cs (Modifiers): Add partial modifier.
2084 * tree.cs (Tree.decl): Removed.
2085 (RootTypes): Started to use this class more often for root types
2088 2006-03-23 Raja R Harinath <rharinath@novell.com>
2090 * generic.cs (TypeParameter.UpdateConstraints): Update
2091 'constraints' if null.
2093 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2097 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
2098 external interface does not have an attribute.
2100 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2102 Another prerequisites for new partial classs implementation.
2104 * attribute.cs (Attribute.Equal): Implemented.
2105 (Attribute.Emit): Changed as attributes can be applied more than twice.
2106 (Attributes.Emit): Check for duplicate attributes here.
2108 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
2109 as a parameter, clean-up.
2111 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2115 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
2116 contains obsolete attribute check which can in some cases look for base
2117 type of current class which is not initialized yet.
2118 (TypeContainer.BaseType): Replacement of ptype.
2120 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
2122 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2124 First of prerequisites for new partial classs implemention.
2126 * attribute.cs (Attributable): Extended by ResolveContext;
2127 Attributes finally have correct context for resolving in all cases.
2128 (AttachTo): Attribute owner is assigned here.
2130 * codegen.cs (IResolveContext): Introduce new interface to hold
2131 all information needed in resolving phase.
2132 (EmitContext): Implements IResolveContext; more clean-up needed here.
2134 * decl.cs (MemberCore): Implemented IResolveContext.
2136 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
2137 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
2138 parameter.cs, statement.cs, tree.cs, typemanager.cs:
2139 Refactored to use new IResolveContext instead of EmitContext; cleanup
2141 2006-03-22 Raja R Harinath <rharinath@novell.com>
2143 Support ParameterDefaultValueAttribute in gmcs. Also applied to
2144 mcs to keep code differences small.
2145 * attribute.cs (Attribute.GetParameterDefaultValue): New.
2146 * typemanager.cs (parameter_default_value_attribute_type): New.
2147 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
2150 2006-03-22 Martin Baulig <martin@ximian.com>
2153 (Nullable.NullableLiteral): Derive from `NullLiteral'.
2156 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
2157 instead of the normal `NullLiteral'.
2159 2006-03-21 Martin Baulig <martin@ximian.com>
2162 * generic.cs (TypeManager.InferType): If `pt' is a generic
2163 parameter, don't check whether `pt == at'.
2165 2006-03-20 Raja R Harinath <rharinath@novell.com>
2168 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
2169 (TypeParameter.Resolve): Update to change.
2170 (ConstraintChecker.CheckConstraints): Resolve type-argument
2171 constraints before use.
2173 2006-03-16 Martin Baulig <martin@ximian.com>
2176 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
2177 and don't have any instance constructors, also lookup in the base class.
2178 (TypeManager.IsNullableValueType): New public method.
2180 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
2181 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
2182 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
2184 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
2185 instead of just TypeManager.IsNullableType() to determine whether
2186 a lifted operator exists.
2187 (UnaryMutator.DoResolve): Likewise.
2188 (Conditional.DoResolve): Likewise.
2189 (Binary.DoResolve): A lifted operator only exists if both operands
2190 are valuetypes and at least one of them is a nullable type.
2192 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
2194 * iterator.cs : yield break is allowed in try statement which has
2195 catch clauses. Fixed bug #77767.
2197 2006-03-12 Martin Baulig <martin@ximian.com>
2199 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
2200 private IsSignatureEqual() to compare types; see the comment in
2201 that method; fixes #77674.
2203 2006-03-10 Raja R Harinath <rharinath@novell.com>
2205 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
2206 (Expression.ResolveAsTypeTerminal): Likewise.
2207 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
2208 * expression.cs, generic.cs, iterators.cs: Likewise.
2209 * parameter.cs, statement.cs, typemanager.cs: Likewise.
2211 2006-03-09 Martin Baulig <martin@ximian.com>
2213 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
2214 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
2216 2006-03-09 Martin Baulig <martin@ximian.com>
2218 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
2219 `prepared' flag is set.
2221 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
2222 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
2223 issues; see gtest-254.cs.
2225 2006-03-07 Martin Baulig <martin@ximian.com>
2227 * generic.cs (TypeManager.InferType): Allow infering
2228 `IEnumerable<T>' with an array of T; see gtest-251.cs.
2230 2006-03-06 Martin Baulig <martin@ximian.com>
2233 (TypeManager.InferType): Fix gtest-250.cs.
2236 (TypeManager.IsSubclassOf): Also check the base class.
2239 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
2242 2006-03-01 Raja R Harinath <rharinath@novell.com>
2245 * expression.cs (ParameterReference.DoResolveBase): Change return
2247 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
2251 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
2254 * typemanager.cs (GetFullNameSignature): Don't nullref on
2255 protected accessors.
2257 2006-02-16 Martin Baulig <martin@ximian.com>
2260 (TypeManager.GetGenericFieldDefinition): New public method; use it
2261 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2263 2006-02-14 Martin Baulig <martin@ximian.com>
2265 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2267 2006-02-14 Martin Baulig <martin@ximian.com>
2270 (TypeManager.DropGenericMethodArguments): New public method; don't
2271 use GetGenericMethodDefinition() on something which is not a
2274 2006-02-14 Martin Baulig <martin@ximian.com>
2277 (ConstraintChecker.CheckConstraints): If a type parameter has the
2278 `struct' constraint, the type must be a non-nullable valuetype.
2280 2006-02-10 Martin Baulig <martin@ximian.com>
2283 (TypeManager.IsOverride): Make this work for instantiated methods
2284 in a generic class; fixes #77509.
2285 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2286 rather than calling it directly; fixes #77488.
2288 2006-02-08 Martin Baulig <martin@ximian.com>
2290 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2291 reporting into CheckConstraint() so we can use the correctly
2294 2006-02-08 Martin Baulig <martin@ximian.com>
2296 * expression.cs (BaseAccess): Add support for generic methods.
2298 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2299 the new MethodGroupExpr.
2301 2006-02-07 Martin Baulig <martin@ximian.com>
2303 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2304 also reference types; fixes #77483.
2306 2006-02-07 Martin Baulig <martin@ximian.com>
2309 (TypeManager.IsGenericMethod): We now return whether something is
2310 an instantiated generic method (and not a generic method def).
2311 (TypeManager.IsGenericMethodDefinition): New public method.
2314 (TypeManager.CSharpSignature): Only include type arguments for
2315 "real" generic methods, not for any instantiated method.
2316 (TypeManager.GetMethodName): Likewise, but also allow generic
2317 method definitions here.
2319 2006-02-06 Miguel de Icaza <miguel@novell.com>
2321 * codegen.cs (EmitScopeInitFromBlock): check here the
2322 capture_context, there is no need to make two calls to the
2325 * anonymous.cs: Add some debugging messages that might help me
2326 track other instances of this problem in the future (the
2327 regression of test 467).
2329 * cs-parser.jay: track the variable block, as we need to initalize
2330 any captured variables declared in this block for the "catch"
2331 portion of the "Try" statement.
2333 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2334 scope initialization for captured variables.
2336 Also, move the emit for the variables after the block location has
2339 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2341 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2343 2006-02-06 Martin Baulig <martin@ximian.com>
2345 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2346 `TypeManager.value_type' as parent type to
2347 ModuleBuilder.DefineType(). Fixes #77358.
2349 2006-02-02 Miguel de Icaza <miguel@novell.com>
2351 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2352 commit yesterday, the initialization for the roots is necessary.
2353 What is not necessary is the scope activation.
2355 2006-02-02 Raja R Harinath <rharinath@novell.com>
2357 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2358 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2360 (Argument.Resolve): Remove CS0206 checks.
2362 2006-02-01 Miguel de Icaza <miguel@novell.com>
2364 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2365 scopes for all the roots, the scopes will now be emitted when the
2366 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2368 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2369 code. This reduces a lot of existing cruft.
2371 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2372 that the ScopeInfo is generated as we enter the scope, not at the
2373 time of use, which is what we used to do before.
2375 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2376 every time a Block is about to be emitted if we have a
2379 2006-02-01 Raja R Harinath <rharinath@novell.com>
2381 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2382 attribute for mscorlib too.
2384 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2386 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2388 * typemanager.cs (cons_param_array_attribute): Make private.
2389 (Reset): Set it to null.
2390 (InitCoreHelpers): Don't initialize it.
2391 (ConsParamArrayAttribute): New. Initialize it as needed.
2392 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2394 2006-01-31 Miguel de Icaza <miguel@novell.com>
2396 * expression.cs: There might be errors reported during the
2397 selection of applicable methods. If there are errors, do not
2398 continue execution as it will lead the compiler to crash.
2400 2006-01-30 Miguel de Icaza <miguel@novell.com>
2402 * expression.cs: Member access is not allowed on anonymous
2403 methods. Fixes #77402.
2405 2006-01-30 Raja R Harinath <rharinath@novell.com>
2408 * cs-parser.jay (VariableDeclaration): Don't set
2409 current_array_type to null.
2410 (field_declaration, event_declaration, declaration_statement):
2411 Set it to null here.
2413 2006-01-29 Raja R Harinath <harinath@gmail.com>
2416 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2418 2006-01-28 Raja R Harinath <harinath@gmail.com>
2420 * typemanager.cs (GenericParameterPosition): New.
2423 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2425 * doc.cs : To process "include" elements, first we should create
2426 another list than XmlNodeList, because it could result in node
2427 removal, which could result in that the XmlNodeList gives up
2430 2006-01-25 Miguel de Icaza <miguel@novell.com>
2432 * expression.cs: Introduce an error report that we were not
2433 catching before. Gonzalo ran into it.
2435 2006-01-23 Miguel de Icaza <miguel@novell.com>
2437 A fix for bug: #76957
2439 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2440 ComputeMethodHost before creating the method, this is a new
2443 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2444 that this method references (RegisterScope). The actual scope
2445 where the method is hosted is computed with the ComputeMethodHost
2446 before we create the method.
2448 Moved the Deepest routine here.
2450 (AnonymousContainer.ComputeMethodHost): New routine used to
2451 compute the proper ScopeInfo that will host the anonymous method.
2453 (ScopeInfo): Deal with multiple roots. The problem was that we
2454 did not have a unique root where all ScopeInfos could be hanged
2455 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2458 Remove AdjustMethodScope which is now computed at the end. Remove
2459 LinkScope which did a partial link, instead link all ScopeInfos
2460 before code generation from the new "LinkScopes" routine.
2462 Simplify all the Add* routines as they no longer need to maintain
2463 the tree, they just need to record that they are using variables
2466 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2467 routines to produce the forest of ScopeInfo trees.
2469 * class.cs (TypeContainer.AppendMethod): This is just like
2470 AddMethod, but ensures that an interface implementation method
2471 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2472 methods, but at the end.
2474 We use this functionality to ensure that the generated MoveNext
2475 method in the iterator class is resolved/emitted before the
2476 enumerator methods created.
2478 This is required because the MoveNext method computes the right
2479 ScopeInfo for the method. And the other methods will eventually
2480 need to resolve and fetch information computed from the anonymous
2484 2006-01-23 Raja R Harinath <rharinath@novell.com>
2486 Improve implementation of section 14.4.2.2 (Better function member).
2487 * expression.cs (Invocation.MoreSpecific): Compare all type
2488 arguments before deciding if one type is more specific than
2489 another. Handle array types too. Return the more specific type.
2490 (Invocation.BetterFunction): Add more tie-breaking rules from
2491 section 14.4.2.2. Perform "more specific" check after
2492 other tie-breaking rules. Compare all parameter types before
2493 choosing the "more specific" method.
2495 2006-01-21 Raja R Harinath <harinath@gmail.com>
2496 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2499 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2501 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2502 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2504 2006-01-18 Martin Baulig <martin@ximian.com>
2506 * class.cs (TypeContainer.AddToMemberContainer): Use
2507 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2510 2006-01-18 Martin Baulig <martin@ximian.com>
2512 Fix #76417: a generic class may now have methods which may unify
2513 for some type parameter substitutions.
2515 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2516 for methods which may unify anymore.
2518 * expression.cs (Invocation.MoreSpecific): New private static
2519 method; checks whether one method is more specific than another
2520 according to 14.4.2.2 of the spec.
2521 (Invocation.BetterFunction): Implement the tie-breaking rules from
2522 14.4.2.2 of the spec: if two methods unify for some type parameter
2523 substitution, we need to pick the more specific one.
2525 2006-01-18 Raja R Harinath <rharinath@novell.com>
2527 Fix #76656, cs0231-2.cs.
2528 * cs-parser.jay (formal_parameter_list): Make error case catch
2530 (parenthesized_expression_0): Add CS1026 check.
2531 (invocation_expression): Remove unused { $$ = lexer.Location }.
2533 2006-01-17 Raja R Harinath <rharinath@novell.com>
2536 * cs-parser.jay (statement_expression): Don't list out the
2537 individual statement-expressions. Convert syntax error into
2540 2006-01-16 Raja R Harinath <rharinath@novell.com>
2543 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2544 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2545 CheckIntermediateModification.
2546 (FieldExpr.DoResolve): Add new two-argument version that
2547 allows us to resolve the InstanceExpression as an lvalue.
2548 The one-argument variant is now just a wrapper.
2549 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2550 Resolve the lhs as an lvalue if the it has a value type.
2551 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2552 from Assign.DoResolve.
2553 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2554 resolved as an lvalue.
2555 (PropertyExpr.DoResolve): Update.
2556 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2557 has a value type. Move CS1612 check here from
2558 CheckIntermediateModification.
2559 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2560 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2561 'right_side' of a ResolveLValue on an 'out' argument.
2562 (EmptyExpression.LValueMemberAccess): New. Used as the
2563 'right_side' of a propagated ResolveLValue on a value type.
2564 (LocalVariableReference.DoResolveBase): Recognize
2565 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2567 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2568 EmptyExpression.Null.
2570 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2572 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2573 Type.IsGenericParameter(). Fixed bug #77183.
2574 * doc.cs : it is now identical to doc.cs in mcs.
2576 2006-01-16 Martin Baulig <martin@ximian.com>
2578 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2580 2006-01-16 Martin Baulig <martin@ximian.com>
2582 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2583 ctors; fixes #77250.
2585 2006-01-12 Miguel de Icaza <miguel@novell.com>
2587 This fixes the problem where we used ldfld instead of ldflda to
2588 load the "THIS" pointer on captured parameters, when THIS is a
2589 value type. See bug #77205.
2591 * iterators.cs (CapturedThisReference.Emit): Pass false to
2592 EmitThis (we do not need the address).
2594 * codegen.cs (EmitThis): it needs to know whether we need the
2595 address of `this' or not. This is used by value types.
2597 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2598 every other call passes false.
2600 2006-01-12 Raja R Harinath <rharinath@novell.com>
2603 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2605 * expression.cs (Invocation.OverloadResolve): Update.
2606 (Invocation.DoResolve): Avoid double resolution of invocation.
2608 2006-01-11 Raja R Harinath <rharinath@novell.com>
2611 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2612 unary negation of floating point types as 0-expr; negation cannot
2613 overflow in floating point types.
2616 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2617 on operands of 'void' type.
2620 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2621 and ExclusiveOr for boolean constants too.
2623 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2625 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2627 2006-01-12 Miguel de Icaza <miguel@novell.com>
2629 * cs-tokenizer.cs (Position): New class used to save and restore
2630 the position state in the tokenizer. Before this patch the save
2631 and restore was not complete enough so the line and columns would
2632 start to drift and the debugger and stack traces will get the
2635 2006-01-10 Martin Baulig <martin@ximian.com>
2638 (TypeParameter.InflateConstraints): New public method.
2640 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2641 constraints; fixes #77042.
2643 2006-01-10 Martin Baulig <martin@ximian.com>
2645 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2646 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2649 2006-01-09 Raja R Harinath <rharinath@novell.com>
2652 * expression.cs (Invocation.OverloadResolve): Replace reflected
2653 override methods with their base virtual methods, rather than
2655 * typemanager.cs (TypeManager.GetOverride): New.
2657 2005-12-21 Miguel de Icaza <miguel@novell.com>
2659 * driver.cs: Report the case of no source files and no -out:
2662 2005-12-20 Raja R Harinath <rharinath@novell.com>
2665 * expression.cs (ComposedCast.GetSignatureForError): Define.
2667 2006-01-05 Jb Evain <jbevain@gmail.com>
2669 * class.cs (Property.Define, Indexer.Define): do not tag the
2670 properties as SpecialName | RTSpecialName.
2672 2006-01-04 Miguel de Icaza <miguel@novell.com>
2674 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2675 doing a low-level comparission of parameter types. It was lacking
2676 a check for __argslist.
2678 2005-12-30 Miguel de Icaza <miguel@novell.com>
2680 * expression.cs (ParameterReference.DoResolveBase): Allow
2681 reference parameters if they are local to this block.
2683 This allows the ref and out parameters of a delegate to be used in
2684 an anonymous method, for example:
2686 delegate void set (out int x);
2688 set s = delegate (out int x){
2692 This is used by functionality introduced late in the C# language.
2694 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2695 method that take ref and out parameters.
2697 Fixes #77119 which was a late change in the spec.
2699 2005-12-23 Miguel de Icaza <miguel@novell.com>
2701 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2702 parent if its the same scope. Fixes #77060.
2704 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2706 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2708 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2710 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2711 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2712 that doesn't contain the full public key. This is a update of the
2713 friend assemblies in .Net 2.0 release.
2715 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2719 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2720 ListDictionary, to contain the ExternAliasEntry entries (in
2721 addition to the NamespaceEntry.aliases hashtable). This field is
2722 shared between the original entry and its doppelganger (bodyless
2724 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2725 extern_aliases field.
2726 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2727 lookup in extern_aliases.
2729 2005-12-16 Raja R Harinath <rharinath@novell.com>
2732 * class.cs (TypeContainer.Mark_HasEquals): New.
2733 (TypeContainer.Mark_HasGetHashCode): New.
2734 (ClassPart): Override them.
2735 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2737 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2738 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2742 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2743 'parent' argument to the base constructor.
2745 Remove all mention of TypeContainer from decl.cs.
2746 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2747 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2748 (DeclSpace.DeclSpace): Likewise.
2749 (DeclSpace.DefineMembers): Remove unused argument.
2750 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2751 debugging check -- we don't care if the debug code throws an
2752 InvalidCastException instead of an InternalErrorException.
2753 * class.cs (TypeContainer.DefineMembers): Update to changes.
2754 (TypeContainer.DoDefineMembers): Likewise.
2755 (TypeContainer.GetMethods): Likewise.
2756 (PropertyMember.Define): Likewise.
2757 (MemberBase.Parent): New property that forwards to
2758 MemberCore.Parent, but ensures that we get a TypeContainer.
2759 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2760 (RootContext.PopulateTypes): Likewise. Remove special case code
2761 for !RootContext.StdLib: DefineMembers is idempotent.
2763 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2765 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2767 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2769 * doc.cs : The search for referenced namespace was insufficient to
2770 get global one as it used to do. Fixed bug #76965.
2772 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2774 * doc.cs : check name in cref in the last phase that whether it is
2777 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2779 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2782 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2784 * doc.cs : so it turned out that we cannot skip override check for
2785 interface members. Fixed bug #76954.
2787 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2789 * cs-tokenizer.cs : fixed bug #75984:
2790 - #warning and #error should not be handled when the source line
2792 - #line is not checked strictly when the source line is disabled.
2793 - #define and #undef is on the other hand checked strictly at any
2796 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2798 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2801 2005-12-15 Raja R Harinath <rharinath@novell.com>
2803 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2805 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2808 2005-12-14 Martin Baulig <martin@ximian.com>
2810 * typemanager.cs (TypeManager.GetFullName): Make this public;
2811 `Type.Fullname' now never returns null.
2813 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2814 explicit interface implementations; we're now using the same
2815 naming convention than csc does.
2817 2005-12-14 Miguel de Icaza <miguel@novell.com>
2819 * convert.cs (ExplicitConversionCore): Check the return value from
2820 ExplicitConversionCore which can return null on failure. Fixes #76914
2822 2005-12-09 Raja R Harinath <rharinath@novell.com>
2824 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2825 instead of IsGenericInstance.
2826 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2827 code that's now covered by the more general test.
2828 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2830 * generic.cs (DropGenericTypeArguments): New. Captures the common
2831 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2832 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2833 * generic.cs, report.cs, typemanager.cs: Likewise.
2835 2005-12-08 Martin Baulig <martin@ximian.com>
2837 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2839 * typemanager.cs (TypeManager.CSharpSignature): Include type
2840 arguments in the signature of a generic method.
2842 2005-12-07 Martin Baulig <martin@ximian.com>
2844 Add support for custom attributes on type parameters.
2846 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2848 * generic.cs (TypeParameterName): New public class; we use this
2849 instead of a `string' to store the name of a type parameter, so we
2850 can also have `Attributes'.
2851 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2852 array instead of a `string[]' array.
2853 (TypeParameter.ctor): We now also take an `Attributes' argument.
2854 (TypeParameter.EmitAttributes): New public method; emit our
2855 `OptAttributes' here.
2856 (GenericMethod.EmitAttributes): New public method; emit the custom
2857 attributes on all our type parameters.
2859 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2860 our type parameters.
2861 (MethodData.Define): If we're a generic method, call
2862 EmitAttributes() on it.
2864 2005-12-07 Martin Baulig <martin@ximian.com>
2867 (ConstraintChecker): New public abstract class; move the
2868 constraint checking here from `ConstructedType' and also do
2869 constraint checking for generic methods here.
2871 * expression.cs (Invocation.OverloadResolve): Use
2872 ConstraintChecker.CheckConstraints() if we resolved to a generic
2875 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2877 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
2879 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
2881 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
2882 (FieldBase.Initializer): Initializer is now optional.
2883 (EventField.Define): Only event field can have initializer.
2885 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
2887 * const.cs (Const): Reuse initializer.
2889 * cs-parser.jay: Updated after FieldBase changes.
2890 Added current_array_type to simplify array initializers.
2892 * ecore.cs (NullCast.IsDefaultValue): Implemented.
2894 * expression.cs, iterators.cs: Updated.
2896 * namespace.cs (NamespaceEntry): Made UsingFound private.
2898 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2900 * parameterCollection.cs: Obsolete, removed.
2901 * parser.cs: Obsolete, removed.
2903 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2906 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
2908 * enum.cs (Enum.Define): Set obsolete context here.
2910 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2913 - FindDocumentedMember() now expects 1) paramList as null
2914 when "we don't have to check the number of parameters" and
2915 2) Type.EmptyTypes when "there is no arguments".
2916 - Introduced FoundMember struct to hold the exact type which was
2917 used to find the documented member (the above change broke
2918 test-xml-044; it might be better just to use DeclaringType than
2919 what MS does, like this change does, but it depends on usage.)
2921 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2923 * doc.cs : documented member might be from DeclaringType for nested
2924 types. Fixed bug #76782.
2926 2005-12-03 Ben Maurer <bmaurer@ximian.com>
2928 * anonymous.cs: Have the param code handle leaving copies on the
2929 stack etc. Allows anonymous params to take part in the assignment
2930 code (++, +=, etc). Fixes bug #76550
2932 * expression.cs: Handle the prepare_for_load/leave_copy by passing
2933 it down to the anon code.
2935 * iterators.cs: Use dummy var here
2937 * codegen.cs: Handle new vars
2939 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2942 * class.cs (MethodData.Define): Set proper Obsolete context.
2944 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
2946 (FieldExpr.DoResolve): Ditto.
2948 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2951 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
2952 parent is not obsolete.
2954 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
2956 * doc.cs : (FindDocumentedMember) find parameterless members first
2957 and get CS0419 in the early stage. Fixed first case of bug #76727.
2959 2005-11-30 Marek Safar <marek.safar@seznam.cz>
2962 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
2963 no error was reported.
2965 *expression.cs (Binary.DoResolve): left can be null.
2967 2005-12-06 Raja R Harinath <rharinath@novell.com>
2969 * class.cs (MethodCore.CheckGenericOverride): Delete unused
2970 abstract method and all overrides.
2971 * support.cs (ParameterData.GenericConstraints): Delete.
2972 (ReflectionParameters.type_params): Delete.
2973 (ReflectionParameters.ReflectionParameters): Make private.
2974 (ReflectionParameters.GetConstaints): New factory method.
2975 * generic.cs (TypeParameterDefineType): Use it.
2976 (TypeManager.GetTypeParameterConstraints): Likewise.
2978 2005-11-22 Marek Safar <marek.safar@seznam.cz>
2981 * class.cs (MethodData.Emit): Parameters should be labeled first.
2983 2005-11-21 Marek Safar <marek.safar@seznam.cz>
2986 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
2988 2005-11-18 Marek Safar <marek.safar@seznam.cz>
2990 * attribute.cs (AreParametersCompliant): Moved to Parameter.
2992 * class.cs (MethodCore): Parameter clean up.
2993 (IMethodData): Added ParameterInfo.
2994 (MethodData): Parameter clean up.
2995 (Indexer.Define): Parameter clean up.
3007 * typemanager.cs: Parameter clean up.
3009 * delegate.cs (Define): Get rid of duplicated code.
3011 * expression.cs (ParameterReference): Removed useless parameters
3013 (Invocation): Ditto.
3015 * parameter.cs (ParamsParameter): New class, params specialization.
3016 (ArglistParameter): Attemp to separate arglist.
3017 (Parameter): Refactored to be reusable and faster.
3018 (Parameter.Modifier): Made understandable.
3019 (Parameters): Changed to be used as a class for `this' assembly
3020 parameters. Refactored to use new specialized classes.
3022 * support.cs (ParameterData): Added Types property.
3023 (InternalParameters): Deleted.
3025 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3027 * doc.cs : the previous patch does not actually fix the bug.
3028 PropertyInfo override check is now implemented and really fixed it.
3029 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
3031 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3033 * doc.cs : apply "override filter" also to properties.
3036 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3038 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
3039 no need to check overrides. For classes, omit those results from
3040 interfaces since they must exist in the class. Fixed bug #76726.
3042 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3044 * typemanager.cs : (GetFullNameSignature) differentiate indexers
3045 with different parameters. Fixed the second problem in #76685.
3047 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3049 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
3050 get expected 'protected' access in CheckValidFamilyAccess()).
3053 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3055 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
3056 Fixed bug #76705. CS1569 was incorrectly commented out.
3058 2005-11-23 Martin Baulig <martin@ximian.com>
3060 * generic.cs (Constraints.Define): Removed.
3061 (TypeParameter.DefineConstraints): Removed.
3062 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
3063 on the GenericTypeParameterBuilder here.
3065 2005-11-23 Martin Baulig <martin@ximian.com>
3067 * typemanager.cs (TypeManager.GetProperty): Make this public.
3069 * generic.cs (Nullable.NullableInfo.ctor): Use
3070 TypeManager.GetProperty() rather than using reflection directly.
3072 2005-11-17 Martin Baulig <martin@ximian.com>
3074 * expression.cs (Indexers.GetIndexersForType): Added support for
3075 generic parameters; fixes #76587.
3077 2005-11-17 Martin Baulig <martin@ximian.com>
3080 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
3081 inherit the scope from our parent. Fixes #76653.
3083 2005-11-15 Martin Baulig <martin@ximian.com>
3085 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
3086 instead of `ScopeTypeBuilder' to refer to the "current" type.
3087 (AnonymousMethod.CreateScopeType): Correctly create the helper
3088 class if we're inside a generic type definition.
3090 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3092 * doc.cs : use Invocation.IsOverride() to do real override check.
3093 * expression.cs : made Invocation.IsOverride() internal.
3095 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3097 * doc.cs : use TypeManager.FindMembers() instead of (possible)
3098 TypeBuilder.FindMembers() and filter overriden base members out.
3101 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3103 * doc.cs : ref/out parameters are represented as '@' (instead of
3104 '&' in type FullName). Fixed bug #76630 (additionally crefs).
3106 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3108 * doc.cs : when there was no '.' in cref to methods in doc comment,
3109 then parameters were missing in the output. Fixed bug #76691.
3111 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3113 * driver.cs : don't output docs when there is an error.
3116 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3119 Now it should detect indexers. Fixed primary concern in bug #76685.
3120 Fixed CS0419 message to not show the identical member signature in
3123 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3125 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
3126 instead of Type.FindMembers() since it does not handle events.
3129 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
3131 * codegen.cs: Fixed typo (speficied -> specified).
3133 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3136 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
3138 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3140 * attribute.cs: Changed error message.
3142 * cs-tokenizer.cs: One more check.
3144 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3146 * statement.cs (Block.Resolve): Ignore empty statement.
3148 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3150 * report.cs: Made error/warning methods more strict to avoid
3153 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
3154 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
3155 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
3156 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
3158 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3160 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
3161 Use the more explicit AssemblyName.FullName instead of
3162 AssemblyName.Name to report errors.
3164 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3166 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
3169 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3179 * report.cs: Fixed error reporting and typos.
3181 * generic.cs (TypeParameter.GetSignatureForError): New method.
3182 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
3184 * typemanager.cs (GetFullName): Refactored.
3186 2005-11-08 Marek Safar <marek.safar@seznam.cz>
3188 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
3189 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
3191 * class.cs (TypeContainer.IsComImport): New property.
3192 (Constructor.Define): Create proper ctor for ComImport types.
3194 * expression.cs (New.CheckComImport): Fixed.
3196 2005-11-07 Miguel de Icaza <miguel@novell.com>
3198 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
3199 that a parameter has been captured does not mean that we do not
3200 have to do the rest of the processing. This fixes the second part
3201 of #76592. If there was another anonymous method capturing
3202 values in the past, the Scope would never be set for the second
3203 method that captured the same parameter.
3205 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
3206 properly manipulate the stack. Second part of fix for #76592.
3208 * expression.cs (New): Add support for invoking "new" on
3209 interfaces that have been flagged with the ComImport attribute and
3210 the CoClass. Fixes #76637
3212 * statement.cs (Try.DoEmit): When a variable is captured, do not
3213 try to emit the vi.LocalBuilder variable as it has been captured.
3214 Create a temporary variable and store the results on the
3215 FieldBuilder. Fixes #76642
3217 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3219 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
3221 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
3223 * expression.cs (Binary.DoResolve): Added && optimalization.
3225 * typemanager.cs (AddUserType): Removed useless argument.
3227 2005-11-04 Marek Safar <marek.safar@seznam.cz>
3229 * statement.cs (Block.variables): Uses ListDictionary.
3231 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3234 * class.cs (PartialContainer.EmitType): Customized to emit
3235 security attributes.
3236 (ClassPart.ApplyAttributeBuilder): Transform security attribute
3237 for partial classes.
3239 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3242 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
3243 access has to be fixed.
3245 * typemanager.cs (IsUnmanagedType): Wrong common field type.
3247 2005-11-01 Marek Safar <marek.safar@seznam.cz>
3250 * ecore.cs (NullCast.Reduce): Implemented.
3252 * expression.cs (ArrayCreation.CheckIndices): Correcly check
3255 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
3257 (Foreach.Resolve): Catch null properly.
3259 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3261 * cs-tokenizer.cs: Warning text fix.
3263 * driver.cs: AllWarningNumbers exposed on public interface.
3265 * report.cs (): Reviewed warning numbers.
3266 (IsValidWarning): Use binary search.
3268 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3270 * driver.cs: Implemeted resource visibility.
3271 (Resources): New class for code sharing between /res: and
3274 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3276 decl.cs (CurrentTypeParameters): Fixed to be public.
3278 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3280 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3282 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3284 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3286 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3288 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3290 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3292 Add friend assembly access support.
3293 * typemanager.cs: assembly_internals_vis_attrs
3294 cache for friend assembly access.
3295 (TypeManager.IsFriendAssembly): New method for
3296 checking friend assembly access.
3297 (TypeManager.Error_FriendAccessNameNotMatching): New
3299 (TypeManager.CompareKeyTokens): Likewise.
3300 (TypeManager.Filter): Handle friend accessible
3303 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3304 friend accessible types.
3306 * ecore.cs (Expression.IsAccessorAccessible): Handle
3307 friend accessible properties.
3309 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3312 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3315 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3318 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3321 * ecore.cs (NullCast): Child is contant only.
3323 * literal.cs (NullLiteral.Reduce): null can be converted to any
3326 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3328 * driver.cs: Use Encoding.Default as default code page instead
3331 2005-10-27 Raja R Harinath <rharinath@novell.com>
3334 * expression.cs (Invocation.Error_InvalidArguments): Handle
3335 __arglist parameters.
3336 (Invocation.VerifyArgumentsCompat): Likewise.
3337 * support.cs (ReflectionParameters.GetSignatureForError): Print
3338 __arglist parameters.
3339 (InternalParamters.GetSignatureForError): Likewise.
3340 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3342 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3344 * attribute.cs (GetPropertyValue): Made public.
3346 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3348 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3350 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3353 * driver.cs: Reflect method name change.
3355 * statement.cs (Try.Resolve): Warn when try has both general
3358 * typemanager.cs: runtime_compatibility_attr_type new predefined
3361 2005-10-26 Raja R Harinath <harinath@gmail.com>
3364 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3365 treat it as an empty parameter list.
3367 2005-10-26 Raja R Harinath <rharinath@novell.com>
3370 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3371 ResolveAsTypeStep silent.
3372 * statement.cs (Block.AddConstant): Mark block as used.
3373 (Block.ResolveMeta): Avoid piling on error messages
3374 if a constant initializer resolution fails.
3376 2005-10-25 Raja R Harinath <rharinath@novell.com>
3378 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3380 (NamespaceEntry.VerifyAllUsing): New.
3381 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3382 behaviour. Delegates actual resolution of alias to ...
3383 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3384 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3386 * driver.cs (Driver.MainDriver): Update.
3388 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3389 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3391 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3393 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3394 RootNamespace.DefineNamespacesForAll.
3396 2005-10-24 Raja R Harinath <harinath@gmail.com>
3398 * typemanager.cs (assemblies, external_aliases, modules)
3399 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3400 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3401 overhead. Move resposibility ...
3402 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3403 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3405 2005-10-23 Raja R Harinath <harinath@gmail.com>
3407 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3408 cached_namespaces. Improve usage.
3409 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3410 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3411 Move from GlobalRootNamespace and simplify.
3412 (RootNamespace.Global): Make instance variable.
3413 (RootNamespace.RootNamespace): Add "alias name" parameter.
3414 (GlobalRootNamespace): Simplify drastically.
3415 (Namespace.Lookup): Don't use GetNamespace.
3416 * typemanager.cs (GetRootNamespace): Rename from
3417 ComputeNamespaceForAlias.
3418 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3420 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3422 * anonymous.cs (AnonymousContainer): Don't crash when container
3425 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3427 * expression.cs (Binary.DoResolve): Warn when comparing same
3430 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3433 * expression.cs (Binary.DoResolve): It looks like there are no
3434 convetsion rules in enum context.
3436 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3438 Add support for extern alias qualifiers.
3439 * typemanager.cs: Move some LookupTypeReflection code
3440 to namespace.cs, to have cleaner code. Added some methods
3441 to help us keep track of the extern aliased references.
3442 * driver.cs: Add suport for extern alias assemblies on command
3443 line and check for their warnings/errors. Also keep track of the
3444 extern aliased assemblies.
3445 * namespace.cs: Move the global functionality of Namespace
3446 to GlobalRootNamespace/RootNamespace. Now the global namespace
3447 is GlobalRootNamespace.Globa. Also the code moved from
3448 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3449 Finally added LocalAliasEntry (AliasEntry before) and
3450 ExternAliasEntry, to handle alias statements.
3451 * cs-parser.jay: Add support in the grammar for extern alias
3453 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3454 Update callings to Namespace (now in GlobalRootNamespace).
3456 2005-10-25 Martin Baulig <martin@ximian.com>
3458 * convert.cs (ImplicitTypeParameterConversion): Make base
3459 interfaces actually work; fixes #76557.
3461 2005-10-25 Martin Baulig <martin@ximian.com>
3464 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3465 all the type parameters; fixes #76551.
3467 2005-10-25 Martin Baulig <martin@ximian.com>
3472 (GenericMethod.ctor): Added `Expression return_type' and
3473 `Parameters parameters' arguments.
3474 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3475 parameter and return types to check their constraints if they're
3478 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3481 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3482 constraints of a generic type if `ec.ResolvingGenericMethod'.
3484 * class.cs (MethodCore.DoDefineParameters): Set
3485 `ec.ResolvingGenericMethod' if we're a generic method.
3486 (MemberBase.MemberType): Likewise.
3488 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3490 * typemanager.cs (TypeManager): Added
3491 TypeManager.internals_visible_attr_type to cache
3492 S.R.CompilerServices.InternalsVisibleToAttribute.
3494 * codegen.cs (AssemblyClass): Added checks for
3495 InternalsVisibleToAttribute in new method
3496 CheckInternalsVisibleAttribute () and also cache the
3497 AssemblyName in AssemblyClass.Name.
3499 2005-10-24 Martin Baulig <martin@ximian.com>
3502 (TypeManager.ExpandInterfaces): Added overloaded version which
3503 just takes a `Type[]' array.
3506 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3507 just use the interfaces which were explicitly specified and not
3508 the interfaces they inherit. Fixes #76482.
3509 (TypeParameter.FindMembers): Expand the interfaces here.
3511 2005-10-21 Martin Baulig <martin@ximian.com>
3514 (Constraints.Resolve): Also resolve the actual types here.
3515 (Constraints.ResolveTypes): Just check the constraints here.
3516 Fixes #76363; see gtest-218.cs.
3518 2005-10-21 Martin Baulig <martin@ximian.com>
3521 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3522 instead of a `BoxedCast'; fixes gtest-217.cs.
3524 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3526 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3527 1) "new()" is specified as generic parameter constraint and 2) the
3528 type is TypeBuilder and 3) the type is abstract even if it has a
3529 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3531 2005-10-20 Martin Baulig <martin@ximian.com>
3534 (GenericConstraints.TypeParameter): New public property.
3535 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3536 (TypeParameter.DeclSpace): New public property.
3537 (TypeParameter.DefineType): Inflate the constraints if our
3538 `DeclSpace' is an `Iterator'.
3540 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3542 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3543 GenericMethod argument to compare methods' generic type arguments.
3546 2005-10-19 Martin Baulig <martin@ximian.com>
3548 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3549 not ResolveType() when resolving the base type, so we're not
3550 checking the constraints here.
3551 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3554 2005-10-19 Martin Baulig <martin@ximian.com>
3556 * generic.cs (ConstructedType.CheckConstraints): Committing
3557 untested fix for #76441.
3559 2005-10-18 Raja R Harinath <rharinath@novell.com>
3562 * class.cs (TypeContainer.DefineType): Move updating of
3563 topological sort earlier in the code.
3564 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3566 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3569 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3571 * constant.cs (Constant.TryReduce): Moved from Cast class.
3572 (Reduce): Made little bit more OO and fixed missing conversions.
3574 * ecore.cs (Reduce): Implemented.
3575 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3577 * literal.cs (Reduce): Implemented.
3579 * class.cs: Reverted Miguel's wrong commit.
3581 2005-10-14 Miguel de Icaza <miguel@novell.com>
3583 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3585 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3587 * cs-parser.jay, expression.cs : CS0214 was missing error location
3588 for constants. Fixed bug #76404.
3590 2005-10-10 Raja R Harinath <rharinath@novell.com>
3592 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3594 (PropertyExpr.EmitCall): Likewise.
3595 * expression.cs (Invocation.EmitArguments): Handle case where
3597 (Invocation.EmitCall): Avoid allocating temporary variable if
3598 there are no arguments.
3600 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3603 * convert.cs (ExplicitConversionCore): Fixed object->enum
3606 2005-10-07 Raja R Harinath <rharinath@novell.com>
3609 * convert.cs (ImplicitConversionStandard): Move conversion of
3610 void* to arbitrary pointer types ...
3611 (ExplicitConversionStandard): .. here.
3612 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3613 error to always print typenames.
3615 2005-10-07 Raja R Harinath <rharinath@novell.com>
3617 * convert.cs (GetConversionOperator): Rename from
3618 GetConversionOperators. Move operator selection code from ...
3619 (UserDefinedConversion): ... here.
3621 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3623 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3626 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3628 * assign.cs (Assign.DoResolve): Error method changed.
3630 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3632 * const.cs (ResolveValue): Reset in_transit immediately.
3634 * constant.cs: Error method changed.
3636 * convert.cs: Removed useless location parameter.
3637 (ExplicitNumericConversion): Don't do double enum check.
3638 (ExplicitConversionCore): Renamed from ExplicitConversion.
3639 (ExplicitUnsafe): Extracted from ExplicitConversion.
3640 (ExplicitConversion): Uses for error reporting.
3642 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3644 (ResolveBoolean): Uses common error method.
3645 (CastToDecimal): Get rid of ec.
3646 (CastFromDecimal): Optimized.
3647 (ConvCast): Get rid of ec.
3649 * enum.cs (ResolveValue): Reset in_transit immediately.
3650 (Emit): Return after first error.
3652 * expression.cs: Convert changes.
3654 * literal.cs: Error method changed.
3656 * statement.cs: Error method changed.
3658 2005-10-06 Raja R Harinath <rharinath@novell.com>
3660 Fix gtest-131.cs and gtest-211.cs.
3661 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3662 Only emit code for a label if it is used. Unreachable code can
3663 violate ECMA evaluation stack invariants.
3665 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3667 * anonymous.cs: Implemented ExprClassName.
3669 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3672 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3675 * class.cs (StaticClass.DefineContainerMembers): Report protected
3678 * codegen.cs: if(ed) PRODUCTION.
3680 * convert.cs (Error_CannotImplicitConversion): Better error
3683 * cs-parser.jay: More error checks.
3685 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3687 * driver.cs (CSCParseOption): Enabled wrong option check.
3689 * ecore.cs (Expression.ExprClassName): Turned to property.
3690 (MemberExpr.CheckIntermediateModification): For checking boxed
3691 value types modification.
3693 * statement.cs (Fixed.Resolve): Expression type must be
3694 convertible to fixed type.
3695 (CollectionForeach.GetEnumeratorFilter,TryType):
3696 Small refactoring for easier error checking.
3698 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3700 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3703 * class.cs (GeneratedBaseInitializer): New class for customization
3704 compiler generated initializers.
3705 (MemberBase.DoDefine): Check Obsolete attribute here.
3706 (FieldMember.DoDefine): Ditto.
3708 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3711 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3712 (MemberCore.GetObsoleteAttribute): Removed argument.
3713 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3714 (MemberCore.CheckObsoleteType): New helper.
3718 * statement.cs: Updates after MemberCore changes.
3720 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3721 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3723 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3724 obsolete attribute for compiler construct.
3725 (As.DoResolve): Cache result.
3727 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3729 2005-10-01 Miguel de Icaza <miguel@novell.com>
3731 * expression.cs (Probe): instead of having a "Type probe_type"
3732 keep the extra information as a TypeExpr probe_type_expr since the
3733 "As" operator needs to perform some type checks.
3735 * (As.DoResolve): If the type is a type parameter, ensure that it
3736 is constrained by a class.
3738 2005-09-22 Miguel de Icaza <miguel@novell.com>
3740 * statement.cs (Lock): Use the TemporaryVariable class instead of
3741 manually using local variables as those do not work when variables
3744 * ecore.cs: Moved the TemporaryVariable class from being a nested
3745 class inside Foreach to be a public class that can be employed in
3748 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3750 * cs-parser.jay: interface_accessors replaced by
3751 accessor_declarations.
3753 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3756 * statement.cs (GotoCase.Resolve): Convert null constant to
3758 (SwitchLabel.ResolveAndReduce): Ditto.
3759 (SwitchLabel.NullStringCase): Custom null stamp.
3760 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3762 typemanager.cs (CSharpSignature): Don't skip first argument
3765 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3767 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3768 expression.cs, iterators.cs, literal.cs: Store constants and
3771 * class.cs (MemberBase.ShortName): Pass location.
3773 * cs-parser.jay: Some location fixes.
3775 * ecore.cs (Expression.Location): Made virtual.
3777 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3780 * const.cs (Const.ResolveValue): Check for assigning non-null
3781 value to reference type.
3783 2005-09-26 Raja R Harinath <rharinath@novell.com>
3786 * expression.cs (This.VerifyFixed): In a value type T, the type of
3787 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3788 value type R, 'this' is treated as a value parameter.
3790 2005-09-05 Miguel de Icaza <miguel@novell.com>
3792 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3793 if the underlying types are the same, otherwise we need to produce
3794 code that will do the proper cast.
3796 This was exposed by Marek's constant rewrite which produced
3797 invalid code for the call site:
3800 void Method (X v) {}
3804 This fixes test-49.cs
3806 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3808 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3809 Type/Object should be allowed as well. Fixed bug #75968.
3811 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3813 * expression.cs : (Binary.DoResolve): when one is enum constant and
3814 another is constant 0, then return enum one *as enum type*.
3817 2005-10-04 Martin Baulig <martin@ximian.com>
3819 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3820 `SetMemberIsUsed()' work for generics, too.
3822 2005-10-04 Martin Baulig <martin@ximian.com>
3824 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3825 for corlib. Fixes #75691.
3827 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3830 * driver.cs: Fix compilation files with full root path.
3832 2005-09-25 Miguel de Icaza <miguel@novell.com>
3834 * report.cs (SymbolRelatedToPreviousError): Format the output so
3835 it does not use an open parenthesis that is never closed.
3837 * driver.cs: Follow coding guidelines
3839 2005-09-18 Miguel de Icaza <miguel@novell.com>
3841 * driver.cs: Set InEmacs based on the environment variable EMACS.
3843 * location.cs (InEmacs): in this mode, do not report column
3844 location as it confuses Emacs.
3846 2005-10-03 Raja R Harinath <rharinath@novell.com>
3848 * support.cs (SeekableStreamReader.Position): Don't error out when
3849 the requested position is just beyond the end of the current
3852 2005-09-28 Raja R Harinath <rharinath@novell.com>
3854 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3855 try to keep in sync with the byte count of the underlying Stream.
3856 However, this limits us to a window size of 2048 characters: i.e.,
3857 the maximum lookahead of our lexer/parser can be 2048 characters.
3859 2005-09-22 Martin Baulig <martin@ximian.com>
3861 * driver.cs: Removed a debugging FIXME.
3863 2005-09-21 Raja R Harinath <rharinath@novell.com>
3865 * cs-parser.jay (type_arguments): Add CS1644 check.
3866 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3868 2005-09-15 Raja R Harinath <rharinath@novell.com>
3870 * Makefile (PROGRAM): Make profile specific.
3871 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
3872 the current directory.
3875 * expression.cs (Invocation.EmitCall): Remove optimization on
3876 this_call since it doesn't handle 'this' being a value type.
3878 2005-09-05 Geoff Norton <gnorton@customerdna.com>
3880 * driver.cs: Ensure file handles are closed after parsing
3882 2005-09-05 Miguel de Icaza <miguel@novell.com>
3884 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3885 if the underlying types are the same, otherwise we need to produce
3886 code that will do the proper cast.
3888 This was exposed by Marek's constant rewrite which produced
3889 invalid code for the call site:
3892 void Method (X v) {}
3896 This fixes test-49.cs
3898 2005-09-05 Martin Baulig <martin@ximian.com>
3900 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
3901 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
3903 * cs-parser.jay (delegate_declaration): Small fix for #75852.
3905 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3907 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
3908 to be a pointer type due to the spec 25.2, so check if declaring
3909 type is generic type definition. Fixed bug #75772.
3911 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3914 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
3915 both types are not defined by methods.
3916 * expression.cs : (Invocation.IsApplicable): it should work when
3917 the argument type is equal to the parameter type, not only when
3918 ImplicitConversionExists() returns true.
3920 2005-09-02 Raja R Harinath <rharinath@novell.com>
3922 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
3926 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
3927 flow-branching for LocalVariableReferences in case we were invoked
3928 from a MemberAccess.
3929 * expression.cs (LocalVariableReference.VerifyAssigned): New.
3931 (LocalVariableReference.DoResolveBase): ... this.
3932 (MemberAccess.Resolve): Do the check that was disabled during
3935 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3938 (PartialContainer.Create): check abstract/sealed/static strictly
3939 but abstract/sealed can exist only at one side. Fixed bug #75883.
3941 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
3944 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
3945 specified, don't default to UnmanagedType.I4.
3947 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3949 * expression.cs : conditional operator should check possibly
3950 incorrect assign expression. Fixed bug #75946.
3952 2005-08-30 Raja R Harinath <rharinath@novell.com>
3955 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
3956 (ScopeInfo.EmitScopeType): Use it to construct field names from
3957 names of captured locals.
3960 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
3961 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
3962 Pass 'target_type' to BoxedCast. Don't default to 'object'.
3963 (ExplicitConversion): Remove enum cases already handled by
3964 implicit conversion. Move implicit conversion check to the beginning.
3965 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
3966 * expression.cs (ArrayCreation.EmitDynamicInitializers):
3967 Don't treat System.Enum as a struct.
3969 2005-08-30 Jb Evain <jbevain@gmail.com>
3971 * attribute.cs: handles as expression in parameters.
3973 2005-08-30 Raja R Harinath <rharinath@novell.com>
3976 * class.cs (TypeContainer.VerifyClsName): Don't use a
3977 PartialContainer when verifying CLS compliance.
3978 (AbstractPropertyEventMethod): Set Parent here, ...
3979 (PropertyMethod): ... not here.
3981 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
3983 * attribute.cs : escaped attribute name should not be allowed to be
3984 resolved (e.g. @class as classAttribute). Fixed bug #75930.
3986 2005-08-29 Raja R Harinath <rharinath@novell.com>
3989 * convert.cs (ImplicitStandardConversionExists): Allow zero also
3990 when converting a long constant to unsigned long.
3991 * expression.cs (Invocation.OverloadResolve): Add sanity check to
3992 detect where IsApplicable and VerifyArgumentsCompat disagree.
3994 2005-08-29 Raja R Harinath <rharinath@novell.com>
3995 and Carlos Alberto Cortez <carlos@unixmexico.org>
3998 * class.cs (TypeContainer.CanElideInitializer): New helper.
3999 (TypeContainer.EmitFieldInitializers): Use it to determine if we
4000 can safely emitting the initializer of a field.
4002 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4004 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
4005 allowed inside a switch (without loop). Fixed bug #75433.
4007 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4009 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4010 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4012 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4014 * driver.cs : kinda reverting the default encoding changes (not exact
4015 revert since I noticed that "codepage:reset" might not work fine).
4017 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4019 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
4020 Location. Now getter and setter store location correctly.
4021 (errors/cs0111-12.cs now reports the expected location.)
4023 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4025 * driver.cs : Use default encoding on the environment.
4026 Removed (now that) extra parameter for SeekableStreamReader.
4027 * support.cs : (SeekableStreamReader) third .ctor() argument for
4028 StreamReader is not required (always true). preamble size could
4029 be acquired in simpler and safe way.
4031 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
4033 * cs-parser.jay: report CS0642 at warning level 3
4034 and report CS0642 for an if else statement also
4035 fixes bug #74745. Patch by John Luke (and a bit
4037 Removed extra CS0642 warning check for "while",
4039 * statement.cs: In Block.Resolve(), CS0642 check
4040 is reimplemented to check a sequence of an empty
4041 statement and a block.
4043 Both fix bug #66777.
4045 2005-08-24 Marek Safar <marek.safar@seznam.cz>
4047 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
4048 detection until I fix it.
4050 * cs-tokenizer.cs: Changed error message.
4052 * cs-parser.jay: Fixed 2 error locations.
4054 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
4055 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
4058 * enum.cs (GetSignatureForError): Fixed.
4060 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
4064 * typemanager.cs (RegisterProperty): Removed.
4066 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
4068 2005-08-24 Raja R Harinath <rharinath@novell.com>
4071 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
4072 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
4074 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4076 * expression.cs : tiny fix is required for not warning positive ulong.
4079 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4081 * expression.cs : add CS0652 check for constant and integral
4082 expression. Fixed bug #53974.
4084 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4086 * expression.cs : in DoNumericPromotions(), check if there is implicit
4087 conversion overload for string (to check CS0034). Fixed bug #52492.
4089 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4091 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
4093 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4095 * ecore.cs : report location when it is *not* Null.
4097 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4103 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
4104 correctly. Fixed bug #75721.
4106 2005-08-23 Raja R Harinath <rharinath@novell.com>
4108 * support.cs (SeekableStreamReader.Position): Avoid an expensive
4109 loop that performs 'min (pos, char_count)'.
4112 * expression.cs (Unary.ResolveOperator): Don't discard implicit
4113 converted value in Operator.OnesComplement.
4115 2005-08-22 Ben Maurer <bmaurer@ximian.com>
4117 * anonymous.cs: If the anon method is pulled into a helper class,
4118 it needs to be `internal' not `private'. Fixes runtime behavior on
4121 2005-08-17 Marek Safar <marek.safar@seznam.cz>
4124 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
4127 2005-08-16 Marek Safar <marek.safar@seznam.cz>
4129 The big constants rewrite
4130 Fix #75746, #75685 and more
4131 As a side effect saved 1MB for MWF ;-)
4133 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
4134 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
4135 enum based for corlib compilation.
4137 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
4140 * class.cs (FixedField.Define): Use ResolveAsConstant.
4142 * const.cs (IConstant): Interface constants and enums.
4143 (Const.ResolveValue): New method for constant resolvning.
4144 (ExternalConstant): Constants from imported assemblies.
4146 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
4147 conversion; like enums.
4148 (Constant.ToType): Converts this constant to different type.
4149 (Constant.Increment): Adds 1.
4151 * convert.cs (ImplicitConversionRequired): Simplified.
4153 * cs-parser.jay: Create EnumMember directly.
4155 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
4157 * doc.cs (GenerateEnumDocComment): Removed.
4159 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
4160 (ConvertIntLiteral): Removed.
4161 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
4163 * enum.cs (EnumMember): Implement IConstant.
4164 (Enum.IsValidEnumConstant): Removed.
4165 (Enum.GetNextDefaultValue): Removed.
4166 (Enum.FindMembers): Updated.
4167 (Enum.GenerateDocComment): Iterate enum members.
4169 * expression.cs (Cast.TryReduce): Handle enums correctly.
4170 (New.Constantify): Made public.
4171 (MemberAccess.DoResolve): Removed contant specific if(s).
4173 * literal.cs (NullLiteral): Implement new abstract methods.
4175 * statement.cs (GotoCase.Resolve): Use new constant methods.
4176 (SwitchLabel.ResolveAndReduce): Use new constant methods.
4178 * typemanager.cs (LookupEnum): Removed.
4179 (IsEnumType): Fixed to work with corlib.
4180 (RegisterConstant): Removed.
4181 (LookupConstant): Removed.
4182 (GetConstant): Changed to work with IConstant.
4184 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
4186 * location.cs : Fixed overflown (>255) column number.
4188 2005-08-03 Raja R Harinath <rharinath@novell.com>
4190 First cut of the qualified-alias-member feature.
4191 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
4193 * cs-parser.jay (DOUBLE_COLON): New token.
4194 (namespace_or_type_name): Add rule for recognizing
4195 qualified-alias-members.
4196 (primary_expression): Likewise.
4197 (element_access): Allow QualifiedAliasMember as a possible
4198 type-bearing expression.
4199 (local_variable_type, local_variable_pointer_type): Likewise.
4200 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
4201 aliases in the current and enclosing namespace declarations.
4202 (NamespaceEntry.UsingAlias): Add CS0440 warning.
4203 * decl.cs (MemberName.is_double_colon): New.
4204 (MemberName.MemberName): Add new constructor for alias-member.
4205 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
4206 * expression.cs (QualifiedAliasMember): New expression type.
4208 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4210 * location.cs : it borked when no argument was specified.
4212 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4214 * location.cs : tiny ToString() format fix.
4216 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4218 * statement.cs : oops, it was missing.
4220 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4222 A set of fixes for precise line/column location.
4225 "token" field now holds a file/line "delta", a line number offset
4226 from the segment, and a column number. See also:
4227 http://lists.ximian.com/pipermail/mono-devel-list/2004-
4228 December/009508.html
4229 Removed static IsNull. Use instance IsNull property instead.
4231 For some tokens it stores Location. For Identifier it stores
4232 LocatedToken which is a pair of string name and location.
4233 Column numbers are adjusted only at getChar().
4235 Use Location.ToString() for reporting (it now contains column).
4237 Largely modified to use LocatedToken instead of
4238 string (IDENTIFIER), and to acquire Location from some tokens.
4239 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
4240 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
4242 Now MemberName holds Location. DeclSpace.ctor() receives Location
4243 as a parameter. Removed extra parameters to all derived classes.
4244 Replaced Location.IsNull() with instance property.
4245 * assign.cs, expression.cs :
4246 Added .ctor() overload that omits Location.
4248 Added "nameEscaped" flag that indicates the identifier was escaped
4249 in the source file. This fixes bug #57047.
4251 2005-09-02 Martin Baulig <martin@ximian.com>
4253 * class.cs: Make CS3005 a warning, not an error.
4255 2005-08-02 Marek Safar <marek.safar@seznam.cz>
4257 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
4258 New method, looking for lo-case imported cls type.
4260 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4263 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4265 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4267 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4269 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4271 Optimized to save 3.5 MB for SWF compilation.
4273 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4275 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4276 (PartialContainer.Create): Moved logic AddToContainer.
4277 (PartialContainer.MarkForDuplicationCheck): Shares name.
4279 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4282 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4284 (Namespace.GetSignatureForError): New method.
4286 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4287 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4289 2005-08-01 Raja R Harinath <rharinath@novell.com>
4292 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4293 member lookup rather than qualifier_type, since qualifier_type can
4296 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4298 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4301 2005-07-31 Miguel de Icaza <miguel@novell.com>
4303 * statement.cs: Copy the local exception into the exception
4304 captured local. Fixes 75674
4306 2005-07-31 Raja R Harinath <harinath@gmail.com>
4309 * expression.cs (Invocation.OverloadResolve): Don't report error
4310 CS1501 if error CS1502 has been reported.
4311 (New.DoResolve): Delegate CS1501 reporting to
4312 Invocation.OverloadResolve.
4315 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4316 invariant-meaning-in-block property in an enclosing block if
4319 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4321 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4322 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4323 (Switch.CheckSwitch): Just save 50kb for SWF.
4325 2005-07-27 Martin Baulig <martin@ximian.com>
4327 * anonymous.cs (CaptureContext.AddField): Added
4328 `AnonymousContainer am' argument; compute its toplevel scope if
4329 it's not already computed. Fixes #75649.
4331 2005-07-26 Raja R Harinath <rharinath@novell.com>
4334 * class.cs (Constructor.Emit): Reset block to null if the block
4337 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4339 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4341 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4343 * class.cs (MethodData.Define): Check whether accessor implementing
4344 interface is public.
4346 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4348 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4351 * namespace.cs (LookupType): Moved same type check to...
4353 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4356 2005-07-21 Raja R Harinath <rharinath@novell.com>
4358 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4359 already found a typebuilder.
4360 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4361 MemberNames, not strings.
4363 * const.cs (Error_ExpressionMustBeConst):
4364 Rename from Error_EpressionMustBeConst.
4365 * const.cs, class.cs, statement.cd: Update.
4367 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4371 * const.cs (Const.LookupConstantValue): Report missing contant expression
4373 (Error_EpressionMustBeConstant): Only one error method.
4375 * class.cs, statement.c: Updated.
4377 2005-07-20 Raja R Harinath <rharinath@novell.com>
4379 * statement.cs (Block.Flags): Add back HasVarargs.
4380 (Block.flags): Make protected.
4381 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4383 * typemanager.cs (types, typecontainers, user_types): Remove.
4384 (UserTypes, TypeContainers): Likewise.
4385 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4386 (CleanUp, Reset): Update.
4387 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4388 (GetNestedType): Use Type.GetNestedType.
4389 (CoreLookupType): Take two arguments, the namespace and the
4390 basename of the type. Update to use the Namespace.Lookup
4392 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4393 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4394 string concatenation and substring matches.
4395 * class.cs, enum.cs, delegate.cs: Update to changes.
4397 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4399 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4400 Expression and made virtual.
4402 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4403 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4405 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4407 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4410 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4413 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4416 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4417 AssemblyCultureAttribute is not used on executable.
4420 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4422 2005-07-16 Raja R Harinath <rharinath@novell.com>
4425 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4426 New. Reports CS0252/CS0253.
4427 Mostly taken from preliminary patch by Duncak Mak.
4428 (Binary.DoResolveOperator): Store results of operator lookup.
4429 Use them to detect if we need to warn about unintended reference
4432 2005-07-15 Raja R Harinath <rharinath@novell.com>
4435 * namespace.cs (Namespace.Lookup): Add back location parameter.
4436 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4437 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4439 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4440 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4441 (Namespace.LookupType): ... this.
4442 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4444 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4445 purported to handle pointers.
4446 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4449 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4451 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4454 2005-07-15 Raja R Harinath <rharinath@novell.com>
4456 * namespace.cs (Namespace.Lookup): Drop location parameter.
4457 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4458 (NamespaceEntry.Lookup): ... this.
4459 (NamespaceEntry.Error_AmbiguousTypeReference):
4460 Move here from DeclSpace.
4461 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4463 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4464 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4465 Move to NamespaceEntry.
4466 * delegate.cs, expression.cs: Update to changes.
4468 2005-08-31 Martin Baulig <martin@ximian.com>
4470 Committing a patch from Atsushi Enomoto for #75850.
4472 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4473 Prefer a generic enumerator over a non-generic one.
4475 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4477 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4478 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4480 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4482 * driver.cs : reverting default encoding change as well as mcs.
4484 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4486 * driver.cs, support.cs : merged r48826.
4488 > could you integrate your mcs changes to gmcs otherwise
4489 > gmcs cannot compile some files.
4491 2005-08-20 Martin Baulig <martin@ximian.com>
4493 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4494 scope if we don't already have it.
4496 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4497 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4500 2005-07-31 Miguel de Icaza <miguel@novell.com>
4502 * statement.cs: Copy the local exception into the exception
4503 captured local. Fixes 75674
4505 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4507 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4510 2005-08-12 Martin Baulig <martin@ximian.com>
4512 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4513 for nested types here to avoid hitting the cache too early.
4515 2005-08-09 Miguel de Icaza <miguel@novell.com>
4517 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4520 2005-08-03 Martin Baulig <martin@ximian.com>
4522 Make iterators in generic methods work; see gtest-191.cs.
4525 (Constraints.Resolve): Protect against being called twice.
4528 (TypeContainer.GetClassBases): Make this `protected virtual'.
4530 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4531 (Iterator.GetClassBases): Override this and compute the base
4533 (Iterator.DefineNestedTypes): If we're a generic method, all our
4534 method type parameters become class type parameters on the proxy
4538 (ToplevelBlock.Parameters): Make this a property, not a field.
4539 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4541 2005-08-03 Martin Baulig <martin@ximian.com>
4543 * typemanager.cs (TypeManager.IsSubclassOf): Use
4544 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4545 (TypeManager.GetFullName_recursed): Improved.
4547 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4550 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4551 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4552 invocation_type == mi.DeclaringType, since the first one also checks
4553 other condition used by generic instances.
4555 2005-07-27 Martin Baulig <martin@ximian.com>
4557 * anonymous.cs (CaptureContext.AddField): Added
4558 `AnonymousContainer am' argument; compute its toplevel scope if
4559 it's not already computed. Fixes #75649.
4561 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4563 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4564 CheckAttributeType and refactored.
4565 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4566 ResolveAsTypeTerminal error handling.
4567 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4569 (GetSignatureForError): Print errors in same way.
4572 * codegen.cs: Reflect attribute GetSignatureForError change.
4575 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4577 * namespace.cs (UsingEntry): Refactored to make fields private.
4580 statement.cs: Error_UnexpectedKind has extra parameter.
4582 2005-07-14 Raja R Harinath <rharinath@novell.com>
4584 * ecore.cs (IAlias): Remove.
4585 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4586 that implement the interface.
4587 * namespace.cs (Namespace): Likewise.
4588 (Namespace.declspaces): Renamed from 'defined_names'.
4589 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4590 DeclSpace instead of an IAlias.
4591 * tree.cs (Tree.AddDecl): Update.
4593 2005-07-12 Raja R Harinath <rharinath@novell.com>
4595 * statement.cs (Block.Flags); Remove HasVarargs.
4596 (Block.HasVarargs): Move to ToplevelBlock.
4597 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4598 (Block.Variables): Make protected. Initialize variable hashtable
4600 (Block.AddVariable): Update.
4601 (Block.Resolve): Update to changes.
4602 (ToplevelBlock.HasVarargs): New boolean.
4603 (ToplevelBlock.ThisVariable): Move here from Block.
4604 (ToplevelBlock.AddThisVariable): Likewise.
4605 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4606 * expression.cs (This.ResolveBase): Update to changes.
4607 (ArglistAccess.DoResolve): Likewise.
4609 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4612 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4614 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4615 not used and not used & assigned.
4616 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4618 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4621 * expression.cs (Is.DoResolve): null is never provided type.
4623 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4626 * cs-parser.jay: Less strict event error rule to catch more errors.
4628 2005-07-11 Martin Baulig <martin@ximian.com>
4630 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4631 for the constructor constraint: we do not only have to check
4632 whether the class has a public constructor, but also ensure that
4633 it's parameterless. Fixes #75492.
4635 2005-07-11 Martin Baulig <martin@ximian.com>
4637 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4638 between type parameters if they either have the reference type
4639 constraint or the class constraint.
4641 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4643 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4645 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4648 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4649 (ExtractSecurityPermissionSet): Cope with self referencing security
4650 attributes properly.
4652 * driver.cs (SetOutputFile): Made public property OutputFile.
4654 2005-07-07 Raja R Harinath <rharinath@novell.com>
4657 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4658 has_nonstatic_fields. Make into a FieldBase pointer.
4659 (TypeContainer.AddField): Add CS0282 check.
4660 (TypeContainer.EmitType): Update.
4662 2005-07-06 Miguel de Icaza <miguel@novell.com>
4664 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4665 compare if they start with __.
4667 2005-07-06 Raja R Harinath <rharinath@novell.com>
4669 * statement.cs (Switch.SwitchGoverningType): Only look at
4670 UserCasts that don't need implicit standard conversions to one of
4671 the allowed switch types (Fixes test-322.cs).
4672 (LocalInfo.Resolve): Re-enable sanity-test.
4674 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4676 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4678 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4680 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4682 2005-07-06 Raja R Harinath <rharinath@novell.com>
4685 * ecore.cs (SimpleName.GetSignatureForError): Add.
4686 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4687 (MemberAccess.GetSignatureForError): Add.
4689 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4691 The big error and warning messages review.
4721 * typemanager.cs: Updated.
4723 * class.cs: (MethodCore.SetYields): Moved here to share.
4724 (PropertyMethod.Define): Moved iterator setup here.
4726 * iterators.cs: Add orig_method to have full access to parent
4729 2005-07-05 Raja R Harinath <rharinath@novell.com>
4731 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4732 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4733 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4734 variable of struct type.
4735 * expression.cs (Unary.ResolveOperator): Update to change.
4736 (Indirection.VerifyFixed): Likewise.
4737 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4738 (ParameterReference.VerifyFixed): Value parameters are fixed.
4739 (This.VerifyFixed): Treat 'this' as a value parameter.
4740 * statement.cs (LocalInfo.IsFixed): Remove.
4742 2005-07-01 Martin Baulig <martin@ximian.com>
4744 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4745 `ec.EmitThis ()' to get the correct scope.
4747 2005-07-01 Martin Baulig <martin@ximian.com>
4749 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4750 instance is a ParameterReference; fixes #75299.
4752 2005-06-30 Raja R Harinath <rharinath@novell.com>
4755 * expression.cs (Indexers.map): Remove.
4756 (Indexers.Append): Filter out inaccessible setters and getters.
4757 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4760 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4762 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4763 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4764 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4765 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4767 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4770 * class.cs (FieldBase.GetInitializerExpression): One more field
4773 2005-06-28 Miguel de Icaza <miguel@novell.com>
4775 * pending.cs: Do not define a proxy if the base method is virtual,
4776 it will be picked up by the runtime (bug 75270).
4778 2005-07-08 Martin Baulig <martin@ximian.com>
4780 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4781 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4783 2005-07-07 Martin Baulig <martin@ximian.com>
4785 * generic.cs (ConstructedType.CheckConstraint): Use
4786 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4787 called recursively; fixes #75329.
4789 2005-07-06 Martin Baulig <martin@ximian.com>
4791 * generic.cs (TypeManager.InferTypeArguments): Added support for
4792 anonymous methods; fixes #75461.
4794 2005-07-01 Martin Baulig <martin@ximian.com>
4796 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4797 `ec.EmitThis ()' to get the correct scope.
4799 2005-07-01 Martin Baulig <martin@ximian.com>
4801 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4802 instance is `This'; fixes #75299.
4804 2005-06-30 Martin Baulig <martin@ximian.com>
4806 * class.cs (Indexer): Implement IIteratorContainer; added support
4807 for iterators in indexers.
4810 (EmitContext.CurrentIterator): Make this a property, not a field.
4812 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4814 2005-06-28 Miguel de Icaza <miguel@novell.com>
4816 * pending.cs: Do not define a proxy if the base method is virtual,
4817 it will be picked up by the runtime (bug 75270).
4819 2005-06-28 Martin Baulig <martin@ximian.com>
4821 * cs-parser.jay (interface_method_declaration): Avoid a
4822 reduce/reduce conflict by moving some of the code into a separate
4823 `interface_method_declaration_body' rule; fixes #75368.
4825 2005-06-28 Martin Baulig <martin@ximian.com>
4827 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4828 array check after the check for TypeBuilder's.
4830 2005-06-21 Raja R Harinath <rharinath@novell.com>
4832 * convert.cs (FindMostEncompassedType): Add two trivial special
4833 cases (number_of_types == 0 || number_of_types == 1).
4834 (FindMostEncompasingType): Likewise.
4836 2005-06-17 Raja R Harinath <rharinath@novell.com>
4838 Some cleanups preparing for the fix of #75283.
4839 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4841 (EventExpr.InstanceResolve): Likewise.
4842 (EventExpr.DoResolve): Remove redundant checks.
4844 2005-06-08 Miguel de Icaza <miguel@novell.com>
4846 * class.cs: Small fix.
4848 2005-06-08 Raja R Harinath <rharinath@novell.com>
4851 * class.cs (GetPartialBases): Fix return value check of
4854 2005-06-07 Raja R Harinath <rharinath@novell.com>
4856 Ensure that partial classes are registered in their enclosing
4857 namespace. Initial part of fix of #75160.
4858 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4859 Register declspace with namespace here, not in
4860 DeclSpace.RecordDecl.
4861 * cs-parser.jay: Pass namespace to RecordDecl.
4862 * class.cs (PartialContainer.Create): Likewise.
4863 (ClassPart.DefineType): New sanity-check. Throws an exception if
4865 * decl.cs (Declspace.RecordDecl): Remove.
4866 * namespace.cs (NamespaceEntry.DefineName): Remove.
4868 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4870 * rootcontext.cs: Reset TargetExt as well.
4872 2005-06-03 Raja R Harinath <rharinath@novell.com>
4874 * ecore.cs (Expression.Resolve): Emit CS0654 error when
4877 2005-06-02 Raja R Harinath <rharinath@novell.com>
4879 Fix #75080, cs0119.cs.
4880 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
4882 (Expression.Resolve): ... this. Use it. Remove bogus code
4883 allowing ExprClass.Type and ExprClass.Namespace for
4884 ResolveFlags.VariableOrValue.
4885 (Expression.Resolve) [1-argument variant]: Change default resolve
4886 flags based on language version.
4887 (Expression.Error_UnexpectedKind): Use a simple string array
4888 rather than an ArrayList.
4889 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
4891 (TypeOfVoid.DoResolve): Likewise.
4892 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
4893 flags argument -- it always has the same value.
4895 2005-05-31 Raja R Harinath <rharinath@novell.com>
4898 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
4899 Use it in the error message.
4900 * assign.cs, expression.cs, statement.cs: Update.
4902 2005-05-30 Raja R Harinath <rharinath@novell.com>
4905 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
4906 the "almostMatchedMember" case too.
4907 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
4908 that failed the accessibility checks to 'almost_match'.
4910 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
4912 * attribute.cs: Use internal MethodBuilder methods to set
4913 ExactSpelling and SetLastError on PInvoke methods, instead
4914 of passing them via charset. Fixes #75060.
4916 2005-05-27 Raja R Harinath <rharinath@novell.com>
4918 * parameter.cs (Parameter): Remove TODO comment.
4919 (Parameter.DefineParameter): Remove Location parameter.
4920 (Parameters.LabelParameters): Likewise.
4921 * class.cs (Constructor.Emit): Update to change.
4922 (MethodData.Emit): Likewise.
4923 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
4924 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
4926 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
4929 Removed Parameters.Location and added Parameter.Location instead.
4930 Removed Location parameter from Emit() and GetSignature().
4937 Modified all related calls.
4939 2005-06-21 Martin Baulig <martin@ximian.com>
4941 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
4942 left-hand side is not a nullable type; fixes #75328.
4944 2005-06-21 Martin Baulig <martin@ximian.com>
4947 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
4948 (TypeManager.GetFullNameSignature): Likewise.
4950 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
4951 `source.FullName' and `target.FullName' to check whether there are
4952 two conflicting definitions.
4954 2005-06-21 Martin Baulig <martin@ximian.com>
4956 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
4957 a BoxedCast - also for reference types - to be compatible with csc.
4959 2005-06-21 Martin Baulig <martin@ximian.com>
4961 * expression.cs (MemberAccess.DoResolve): Add support for nested
4962 types in a generic instance; fixes #75320.
4964 2005-06-20 Martin Baulig <martin@ximian.com>
4966 * generic.cs (TypeManager.InferType): Also walk the class
4967 hierarchy for generic instances; fixes #75261.
4969 2005-06-17 Martin Baulig <martin@ximian.com>
4971 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
4972 to make things work for corlib.
4974 2005-06-15 Martin Baulig <martin@ximian.com>
4976 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
4977 obsolete `SecurityAction' values.
4979 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4981 * rootcontext.cs: Reset TargetExt as well.
4983 2005-06-09 Martin Baulig <martin@ximian.com>
4985 * delegate.cs (Delegate.VerifyMethod): Added
4986 `MethodGroupExpr old_mg' argument; inherit its
4987 `HasTypeParameters'; fix #75085.
4989 2005-06-09 Martin Baulig <martin@ximian.com>
4991 * expression.cs (Invocation.OverloadResolve): Correctly handle
4992 generic methods for the SetMemberIsUsed(); fix #75064.
4994 2005-06-09 Martin Baulig <martin@ximian.com>
4996 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
4999 2005-06-08 Martin Baulig <martin@ximian.com>
5001 * cs-parser.jay (nullable_type_or_conditional): If we put the
5002 nullable back and our `type' is a `ComposedCast', remove the
5003 nullable from it. Fixes #75156.
5005 * expression.cs (ComposedCast.RemoveNullable): New public method.
5007 2005-06-08 Martin Baulig <martin@ximian.com>
5009 The big Iterators rewrite :-)
5011 * iterators.cs: Rewrite this to use the anonymous methods framework.
5013 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
5014 before the TypeContainers; see 2test-21.cs.
5017 (TypeContainer.DefineType): Don't create a new EmitContext if we
5018 already have one (this only happens if we're an Iterator).
5019 (TypeContainer.Define): Also call Define() on all our iterators.
5020 (Method.CreateEmitContext): Added support for iterators.
5023 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
5024 (AnonymousContainer.CreateMethodHost): Moved here from
5025 AnonymousMethod and made abstract.
5026 (AnonymousContainer.CreateScopeType): New abstract method.
5027 (AnonymousContainer.IsIterator): New public property.
5028 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
5029 get the ScopeTypeBuilder rather than manually defining it here.
5030 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
5033 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
5034 before RootContext.DefineTypes().
5036 * codegen.cs (EmitContext.RemapToProxy): Removed.
5037 (EmitContext.CurrentAnonymousMethod): Changed type from
5038 AnonymousMethod -> AnonymousContainer.
5039 (EmitContext.ResolveTopBlock): Protect from being called twice.
5040 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
5041 (EmitContext.EmitThis): Removed the iterators hacks; use the
5042 anonymous methods framework for that.
5045 (ToplevelBlock.Container): Make this a property, not a field.
5046 (ToplevelBlock.ReParent): New public method; move the
5047 ToplevelBlock into a new container.
5048 (Foreach.TemporaryVariable): Simplify.
5050 2005-06-05 Martin Baulig <martin@ximian.com>
5052 * statement.cs (LocalInfo.CompilerGenerated): New flag.
5053 (Block.AddTemporaryVariable): New public method; creates a new
5054 `LocalInfo' for a temporary variable.
5055 (Block.EmitMeta): Create the LocalBuilders for all the temporary
5057 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
5058 non-iterator variables.
5060 2005-06-05 Martin Baulig <martin@ximian.com>
5062 * statement.cs (Foreach.TemporaryVariable): Create the
5063 LocalBuilder in the Emit phase and not in Resolve since in some
5064 situations, we don't have an ILGenerator during Resolve; see
5065 2test-19.cs for an example.
5067 2005-06-04 Martin Baulig <martin@ximian.com>
5069 The big Foreach rewrite - Part II.
5071 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
5072 with `PropertyInfo ienumerator_getcurrent'.
5074 * codegen.cs (VariableStorage): Removed.
5077 (Foreach): Derive from Statement, not ExceptionStatement.
5078 (Foreach.CollectionForeach): New nested class. Moved all the code
5079 dealing with collection foreach here.
5080 (Foreach.ForeachHelperMethods): Removed.
5081 (Foreach.TemporaryVariable): Implement IMemoryLocation.
5083 2005-05-23 Martin Baulig <martin@ximian.com>
5085 * statement.cs (Try.DoResolve): Don't create a `finally' if we
5086 don't need to. Fix #75014.
5088 2005-05-26 Raja R Harinath <rharinath@novell.com>
5090 Improve user-defined conversion handling.
5091 * convert.cs (GetConversionOperators): Rewrite. Return only the
5092 applicable operators.
5093 (AddConversionOperators): New. Helper for GetConversionOperators.
5094 (FindMostEncompassedType, FindMostEncompassingType): Verify that
5095 there is only one most encompassed/encompassing type.
5096 (FindMostSpecificSource, FindMostSpecificTarget): Remove
5097 "applicable operator" handling.
5098 (UserConversion): Move cache here from GetConversionOperators.
5099 Directly cache the chosen operator, rather than the whole
5101 (ExplicitNumericConversion): Fix buggy implementation of Decimal
5102 case. Allow conversion of decimal to sbyte and byte too.
5103 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5104 New static methods. Used to avoid allocating EmptyExpressions in
5107 2005-05-24 Duncan Mak <duncan@novell.com>
5109 * ecore.cs (CastFromDecimal): New class for casting a decimal to
5110 another class, used in Convert.ExplicitNumericConversion.
5111 (CastToDecimal): New class, similar to above, but casts to
5112 System.Decimal, used in Convert.ImplicitNumericConversion and also
5113 in explicit convesion from double/float to decimal.
5115 * convert.cs (ImplicitNumericConversion): Handle implicit
5116 conversions to System.Decimal.
5117 (ExplicitNumericConversion): handle explicit conversions to
5122 2005-05-20 Miguel de Icaza <miguel@novell.com>
5124 * typemanager.cs: Do not throw an exception in the TypeBuilder
5125 case, we take care of it on the TypeCode.
5127 2005-05-17 Marek Safar <marek.safar@seznam.cz>
5129 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
5132 * cs-parser.jay: Catch more lexical errors.
5134 * report.cs: Add one more Error method.
5137 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
5139 2005-05-20 Martin Baulig <martin@ximian.com>
5141 * class.cs (TypeContainer.CircularDepException): Removed.
5142 (TypeContainer.DefineType): Removed the `InTransit' stuff.
5143 (TypeContainer.CheckRecursiveDefinition): Check for circular class
5144 (CS0146) and interface (CS0529) dependencies here.
5146 2005-05-20 Martin Baulig <martin@ximian.com>
5148 * expression.cs (New.DoResolve): Move the CS0712 check above the
5149 CS0144 check; otherwise it can never be reached.
5151 2005-05-20 Martin Baulig <martin@ximian.com>
5153 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
5155 2005-05-20 Martin Baulig <martin@ximian.com>
5157 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
5159 * typemanager.cs (TypeManager.IsAttributeType): New public method.
5161 2005-05-19 Martin Baulig <martin@ximian.com>
5164 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
5165 to disable error reporting.
5167 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
5168 here since we don't want to report an error; see the new test-336.cs.
5170 2005-05-19 Raja R Harinath <rharinath@novell.com>
5172 * statement.cs (ToplevelBlock.GetParameterReference)
5173 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
5174 Move here from class Block.
5175 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
5176 * expression.cs (ParameterReference.DoResolveBase): Likewise.
5178 2005-05-18 Martin Baulig <martin@ximian.com>
5183 (FlowBranching.Reachability): Add non-static public And() and Or()
5185 (FlowBranchingSwitch): New class; do the `break_origins' thing
5186 like in FlowBranchingLoop.
5187 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
5188 reachability, not just locals and parameters.
5189 (FlowBranching.MergeChild): Remove some of the hacks for loop and
5190 switch; MergeBreakOrigins() now takes care of that.
5192 2005-05-18 Martin Baulig <martin@ximian.com>
5194 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
5195 a loop and may leave it, reset the barrier; fixes #74974.
5197 2005-05-16 Raja R Harinath <rharinath@novell.com>
5199 Fix test-382.cs. Emit values of decimal constants.
5200 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
5202 (TypeContainer.AddField): ... this.
5203 (TypeContainer.EmitFieldInitializers): Allow the list of fields
5204 with initializers to include 'Const's.
5205 (ClassPart.RegisterFieldForInitialization): Forward to
5207 * const.cs (Const.Const): Pass initializer to base class.
5208 (Const.Define): In case of decimal constants, register them for
5209 initialization in a static constructor.
5211 2005-05-14 Martin Baulig <martin@ximian.com>
5213 * statement.cs (Block.Resolve): Correctly handle unreachable code;
5214 do not call ResolveUnreachable() on unreachable statements in
5215 here, see the comment in the source code.
5217 2005-05-13 Raja R Harinath <rharinath@novell.com>
5220 * expression.cs (BinaryResolveOperator): If one of the operands of
5221 an equality comparison is 'null' and the other is a pointer type,
5222 convert the null to a NullPointer.
5223 * convert.cs (ImplicitReferenceConversion): If the expression is a
5224 NullLiteral and the target type is a pointer type, return a
5225 NullPointer instead.
5226 (ImplicitConversionStandard): Likewise.
5228 2005-05-13 Marek Safar <marek.safar@seznam.cz>
5230 * cs-parser.jay: Set readonly context based on special constructs.
5232 * expression.cs (LocalVariableReference.DoResolveBase): Improved
5233 readonly variable error handling.
5235 * rootcontext.cs (EmitCode): Don't verify members when error
5238 * statement.cs (LocalInfo): Add reaodnly context information.
5239 (SetReadOnlyContext, GetReadOnlyContext): New methods.
5241 2005-05-17 Martin Baulig <martin@ximian.com>
5243 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
5246 2005-05-13 Martin Baulig <martin@ximian.com>
5248 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
5249 handle unreachable blocks.
5251 2005-05-13 Martin Baulig <martin@ximian.com>
5254 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
5255 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
5258 2005-05-13 Martin Baulig <martin@ximian.com>
5260 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5261 instance variable, not a local. Fix #74873.
5262 (Block.ResolveUnreachable): Set it to true here.
5264 2005-05-12 Martin Baulig <martin@ximian.com>
5266 * cs-parser.jay (property_declaration): Pass the `current_class',
5267 not the `current_container' to Property's .ctor. Fixes #74912.
5269 2005-05-11 Martin Baulig <martin@ximian.com>
5271 * typemanager.cs (Closure): Copy this from MCS and merge all the
5272 GMCS-specific changes into it.
5274 2005-05-12 Raja R Harinath <harinath@gmail.com>
5277 * typemanager.cs (unmanaged_enclosing_types): New.
5278 (IsUnmanagedType): Avoid infloops by using
5279 'unmanaged_enclosing_types' to talk with recursive invocations.
5281 2005-05-11 Duncan Mak <duncan@novell.com>
5283 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5284 continuing to process for 'arg'.
5285 (handle_preprocessing_directive): Check the argument of the #endif
5286 directive and report error CS1025 if there are any trailing
5289 According to the C# spec, having even whitespace after the #endif
5290 directive is illegal; however, because we call arg.TrimEnd ()
5291 beforehand, we have the same behavior as csc, allowing whitespace
5292 after the directive.
5296 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5300 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5301 (Constructor.GetObsoleteAttribute): Implemented correctly.
5303 2005-05-10 Martin Baulig <martin@ximian.com>
5305 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5306 resolve the type; fixes #74864.
5307 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5308 in DoResolve(); fixes #74862.
5310 2005-05-10 Martin Baulig <martin@ximian.com>
5312 * support.cs (ReflectionParameters.ParameterModifier): Use
5313 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5314 and `ParameterAttributes.In'. Fixes #74884.
5316 2005-05-10 Martin Baulig <martin@ximian.com>
5318 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5319 the cache if we're just looking for `MemberTypes.NestedType' in a
5322 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5323 constraints if we're still resolving the type tree.
5324 (Expression.MemberLookup): If we're resolving the type tree, only
5325 look for `MemberTypes.NestedType' since we're only interested in
5328 * class.cs (TypeContainer.DefineType): Don't resolve the type
5329 parameters here; do this later in ResolveType() after the type
5330 tree has been resolved.
5331 (TypeContainer.ResolveType): New public method; this is called
5332 after the type tree is resolved and before the types are being
5333 populated. We resolve the generic constraints here.
5334 (TypeContainer.DoDefineMember): Check the constraints on our base
5335 class and interfaces.
5337 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5338 set the `ResolvingTypeTree' flag on the EmitContext.
5340 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5342 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5344 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5346 * expression.cs (Argument.GetParameterModifier): Turned to property.
5347 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5349 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5352 2005-05-09 Raja R Harinath <rharinath@novell.com>
5355 * decl.cs (MemberCache.AddMethods): Register override methods,
5356 rather than non-override methods.
5357 * typemanager.cs (RegisterOverride): New.
5358 (IsOverride): Update.
5360 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5362 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5364 2005-05-06 Martin Baulig <martin@ximian.com>
5367 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5368 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5370 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5374 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5375 recursive declaration.
5377 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5379 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5381 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5383 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5385 2005-05-05 Raja R Harinath <rharinath@novell.com>
5388 * decl.cs (DeclSpace.FamilyAccessible):
5389 Use TypeManager.IsNestedFamilyAccessible.
5391 Fix reopened #64812.
5392 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5395 2005-05-04 Raja R Harinath <rharinath@novell.com>
5396 Abin Thomas <projectmonokochi@rediffmail.com>
5397 Anoob V E <projectmonokochi@rediffmail.com>
5398 Harilal P R <projectmonokochi@rediffmail.com>
5401 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5402 allow access to all static members.
5404 2005-05-04 Martin Baulig <martin@ximian.com>
5406 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5408 2005-05-04 Martin Baulig <martin@ximian.com>
5412 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5413 section at the end; make things work if `default' is not the last
5416 2005-05-04 Martin Baulig <martin@ximian.com>
5420 * statement.cs (Switch): Replaced the `got_default' field with a
5421 `default_section' one.
5422 (Switch.CheckSwitch): Set `default_section' here.
5423 (Switch.Resolve): If we're a constant switch and the constant is
5424 not found, use the default section.
5426 2005-05-03 Martin Baulig <martin@ximian.com>
5428 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5430 * statement.cs (Foreach.ArrayForeach): New nested class.
5431 (Foreach.TemporaryVariable): New nested class.
5432 (Foreach.EmitArrayForeach): Removed; this is now in the new
5435 2005-05-03 Raja R Harinath <rharinath@novell.com>
5437 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5439 (VerifyPendingMethods): Revert change below.
5441 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5442 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5443 that used to trigger warning -28. Remove warning -28.
5444 * expression.cs (Invocation.OverloadResolve): Use
5445 TypeManager.IsOverride to distinguish override methods.
5448 * pending.cs (VerifyPendingMethods): If a base type implements the
5449 requested interface, don't bother checking individual methods of
5450 the base type. As a side-effect, this prevents the creation of
5451 unnecessary proxies.
5453 2005-05-02 Martin Baulig <martin@ximian.com>
5457 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5458 Also `And' the locals if the old vector is null.
5459 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5460 null; in this case we basically reset all the variables.
5462 2005-05-02 Martin Baulig <martin@ximian.com>
5466 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5467 Added `FlowBranching branching' argument; always `and' the
5468 variables instead of `or'ing them unless we're an infinite loop.
5470 * statement.cs (While.Resolve): Create a new sibling unless we're
5473 2005-05-02 Martin Baulig <martin@ximian.com>
5477 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5478 arguments; use it instead of creating a new TopLevelBlock.
5479 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5480 our ConstructorInitializer.
5483 (TopLevelBlock.TopLevelBranching): New public property.
5484 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5485 and create our `TopLevelBranching'.
5487 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5488 anonymous method host, use `block.TopLevelBranching' rather than
5489 creating a new branching.
5491 2005-04-20 Miguel de Icaza <miguel@novell.com>
5493 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5494 a ScopeInfo, if any of the current children is a child of the new
5495 entry, move those children there.
5497 2005-04-30 Martin Baulig <martin@ximian.com>
5499 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5500 at the beginning of a SwitchSection. Fix #73335.
5502 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5505 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5507 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5508 (FieldExpr.DoResolve): Obsolete members are ignored for field
5511 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5513 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5514 of arrays detection.
5516 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5518 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5520 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5523 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5525 * cs-parser.jay: Use the prefered version of -unsafe in error
5528 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5530 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5533 2005-04-20 John Luke <john.luke@gmail.com>
5535 * driver.cs: fix typo in error message, --outout to --output
5537 2005-04-30 Martin Baulig <martin@ximian.com>
5539 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5540 handle the .NET 2.x security attributes.
5542 2005-04-30 Martin Baulig <martin@ximian.com>
5545 (TypeManager.ExpandInterfaces): Don't add things twice.
5548 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5550 2005-04-29 Martin Baulig <martin@ximian.com>
5552 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5554 * anonymous.cs: Added support for anonymous generic methods.
5556 2005-04-29 Martin Baulig <martin@ximian.com>
5558 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5561 2005-04-29 Martin Baulig <martin@ximian.com>
5563 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5565 * expression.cs (New.DoResolve): Fix the CS0304 check.
5567 2005-04-29 Martin Baulig <martin@ximian.com>
5569 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5572 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5573 explicit interface implementation, compare the interface types.
5574 (MethodData.Define): Use the new naming scheme from the latest
5576 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5578 * decl.cs (MemberName.GetMemberName): Removed.
5579 (MemberName.MethodName, FullName): New properties.
5581 2005-04-25 Raja R Harinath <rharinath@novell.com>
5583 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5585 2005-04-22 Martin Baulig <martin@ximian.com>
5587 * generic.cs (GenericMethod): Create the EmitContext in the
5588 `Define()'; in `Define(MethodBuilder)', create the type parameters
5589 before calling `Define()'. Fixes #73933.
5591 2005-04-22 Martin Baulig <martin@ximian.com>
5594 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5595 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5597 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5598 ConstructedType, check its constraints.
5600 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5602 * codegen.cs (InRefOutArgumentResolving): New field.
5604 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5605 fields outside contructor.
5607 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5609 2005-04-19 Miguel de Icaza <miguel@novell.com>
5611 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5612 parameter code was not completed ever, so it was not as up-to-date
5613 as local variables. Must finish it.
5615 The bug fix was to compare the Toplevel of the block, not the
5616 current block. Thanks for Ben for pointing this out.
5618 2005-04-19 Raja R Harinath <rharinath@novell.com>
5620 * decl.cs (AddMethods): Use the declaring type of the problem
5621 method to determine if we want to squash a warning.
5623 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5625 * attribute.cs: Removed debug output.
5627 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5629 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5632 2005-04-18 Raja R Harinath <rharinath@novell.com>
5635 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5636 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5637 all null comparisons against reference types.
5639 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5642 * class.cs (TypeContainer.CircularDepException) New nested
5644 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5645 (TypeContainer.DefineType): Removed error, reset InTransit before
5647 (Class.DefineType): Throw exception when is in Transit.
5648 Catch exception and report error.
5649 (Struct.DefineType): Throw exception when is in Transit.
5650 Catch exception and report error.
5651 (Interface.DefineType): Throw exception when is in Transit.
5652 Catch exception and report error.
5654 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5655 handle nested exception handlers.
5657 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5660 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5661 InFinally and InCatch storage.
5663 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5664 (Catch.Resolve): Set and Restore ec.InCatch.
5665 (Try.Resolve): Set and Restore ec.InFinally.
5666 (Try.HasCatch): True when try has catch.
5668 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5670 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5671 for the same event member, so exclude such cases from warning 419.
5674 2005-04-16 Miguel de Icaza <miguel@novell.com>
5676 * expression.cs (Binary.ResolveOperator): Apply patch from John
5677 Luke to fix bug 59864: operators &, | and ^ on enumerations
5678 require that the same enum type on both sides.
5680 * driver.cs: Add warnings to old flag usage, this is to assist
5681 people who produce Makefiles and hope that the Makefiles will be
5684 * class.cs (TypeContainer.EmitType): Moved the definition of the
5685 special $PRIVATE$ field from the resolve phase to the Emit phase.
5686 During resolve we do not know if we are a struct with
5687 HasExplicitLayout, we know this only after the attributes for the
5690 Set the FieldOffset to zero on the dummy field that we create for
5691 the class. Fixes 74590.
5693 2005-04-16 Raja R Harinath <rharinath@novell.com>
5696 * ecore.cs (PropertyExpr.resolved): New.
5697 (DoResolve): Use it to handle a case of double resolution here.
5698 Handle a case of identical-name-and-type-name.
5699 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5700 resolution by storing the results of expression resolution back
5701 into the "probes" array.
5703 2005-04-15 Raja R Harinath <rharinath@novell.com>
5705 Fix cs0208-7.cs and cs0208-8.cs.
5706 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5707 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5708 error reporting to point out the reason a struct is not unmanaged.
5710 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5712 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5713 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5715 2005-04-13 Raja R Harinath <rharinath@novell.com>
5718 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5719 IdenticalNameAndTypeName here.
5720 (EventExpr.InstanceResolve): Likewise.
5722 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5724 C# 2.0 DefaultCharSetAttribute implementation
5726 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5727 which allows us to set GlobalNamespace for every resolve.
5728 (Attribute.ResolveArguments): Cut from Resolve.
5729 (Attribute.GetCharSetValue): Returns CharSet named argument.
5730 (Attribute.DefinePInvokeMethod): Gets default charset from
5732 (GlobalAttribute.ResolveAsTypeStep): Override.
5733 (GlobalAttribute.ResolveArguments): Override.
5735 * class.cs (TypeAttr): Is protected.
5737 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5738 (ModuleClass.DefaultCharSetType): New memeber.
5739 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5741 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5742 charset from module.
5744 * delegate.cs (TypeAttr): Override.
5745 (Delegate.DefineType): Use this TypeAttr.
5747 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5748 at very early stage (before types are defined) to resolve model
5749 module attributes. It will probably not work with corlib but it
5752 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5753 charset from module.
5755 * typemanager.cs (default_charset_type): New type.
5757 2005-04-13 Raja R Harinath <rharinath@novell.com>
5759 * decl.cs (MemberCache.AddMethods): Don't warn if
5760 System.Object.Finalize has buggy MethodAttributes.
5762 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5765 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5767 * doc.cs : detect ambiguous reference to overloaded members.
5768 Fixed bug #71603. MS 1.1 csc does not detect it.
5770 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5772 * doc.cs : delegates must not be referenced with parameters.
5775 2005-04-12 Miguel de Icaza <miguel@novell.com>
5777 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5779 2005-04-10 Miguel de Icaza <miguel@novell.com>
5781 * driver.cs (MainDriver): Stop processing if the CLS stage found
5784 (CompilerCallableEntryPoint.InvokeCompiler): Always
5785 reset after execution; Take a TextWriter argument for the
5788 * report.cs: Use the error stream instead of hardcoding stderr.
5790 2005-04-09 Miguel de Icaza <miguel@novell.com>
5792 * class.cs: Reduce code paths to test, too small of an
5793 optimization to make it worth the extra testing. Always perform
5796 2005-04-08 Raja R Harinath <rharinath@novell.com>
5799 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5800 operators that had errors reported on them.
5802 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5804 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5806 (Attribute.Resolve): Add named argument type checking.
5808 * class.cs (FixedField.Define): Use IsPrimitiveType
5810 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5812 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5813 unsafe parameter types.
5815 * statement.cs (Using.ResolveExpression): Add better error description.
5817 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5819 2005-04-08 Raja R Harinath <rharinath@novell.com>
5822 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5823 AttributeUsageAttribute in the emitcontext of the attribute class,
5824 not in the emitcontext of the attributable entity it was attached to.
5825 * cs-parser.jay: Use 'current_class', not 'current_container',
5826 when creating a GlobalAttribute.
5828 2005-04-08 Alp Toker <alp@atoker.com>
5830 * pending.cs: The fix to #58413 failed to compile methods implementing
5831 interfaces with/without params modifiers and vice versa, even though
5832 params modifiers aren't part of the signature. Make the modifier check
5833 less strict as in csc.
5835 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5836 Anoob V E <projectmonokochi@rediffmail.com>
5837 Harilal P R <projectmonokochi@rediffmail.com>
5840 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5841 modifiers of pending methods.
5842 (PendingImplementation.PendingImplementation): Initialize it.
5843 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5844 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5845 with ParameterData. Add check for modifiers.
5846 * class.cs (MethodData.Define): Update to changes.
5848 2005-04-07 Raja R Harinath <rharinath@novell.com>
5850 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5852 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5854 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5857 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5860 * typemanager.cs: Registered RequiredAttributeAttribute.
5862 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5864 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5865 Warning CS0169 is back at level 3.
5866 (IMethodData.SetMemberIsUsed): New method.
5868 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5869 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
5871 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
5873 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
5875 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
5878 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
5881 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
5882 to avoid the problems with nested types.
5884 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
5885 Anoob V.E <projectmonokochi@rediffmail.com>
5886 Harilal P.R <projectmonokochi@rediffmail.com>
5887 Raja R Harinath <rharinath@novell.com>
5890 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
5892 * typemanager (GetConstructor): Make public.
5894 2005-04-05 John Luke <john.luke@gmail.com>
5895 Raja R Harinath <rharinath@novell.com>
5898 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
5899 struct too. Return false quicker in a few cases.
5900 (VerifyUnManaged): Use it.
5902 2005-04-05 Raja R Harinath <rharinath@novell.com>
5905 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
5906 not 'unreachable_seen'.
5908 2005-04-04 Marek Safar <marek.safar@seznam.cz>
5910 * attribute.cs (Attribute.GetValue): Removed unused.
5912 * codegen.cs (CodeGen.TrimExt): Removed unused.
5914 * cs-parser.jay (output): Removed unused.
5916 * cs-tokenizer.cs (hex_digits): Removed unused.
5918 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
5920 * expression.cs (Indirection.LoadExprValue): Removed unused.
5921 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
5923 * iterators.cs (Iterator.param_types): Removed unused.
5925 * statement.cs (Goto.block): Removed unused.
5926 (ToplevelBlock.did): Removed unused.
5927 (Switch.ResolveConstantSwitch): Removed unused.
5929 2005-04-01 Ben Maurer <bmaurer@ximian.com>
5931 * rootcontext.cs: Allow mcs to bootstrap with the compilation
5934 2005-04-19 Martin Baulig <martin@ximian.com>
5936 Merged r42462 from MCS and made it work for GMCS.
5938 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
5940 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
5942 2005-04-01 Raja R Harinath <rharinath@novell.com>
5944 Fix #74232 and cs0208-3.cs.
5945 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
5946 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
5947 unmanaged type. Don't use FieldBuilders when 't' is a
5948 TypeBuilder. Use ModFlags and MemberType fields.
5949 * class.cs (MemberBase.member_type): Rename from MemberType.
5950 (MemberBase.MemberType): New property. Determines member_type on
5952 (MemberBase.DoDefine): Don't initialize MemberType here.
5953 (FieldMember.Define): Likewise.
5955 2005-04-01 Marek Safar <marek.safar@seznam.cz>
5958 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
5959 Attributes are emitted there.
5961 2005-04-01 Raja R Harinath <rharinath@novell.com>
5963 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
5964 keyword in 'partial enum' too.
5965 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
5967 Report from Kamil Skalski <nazgul@omega.pl>.
5970 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
5971 have partial containers too.
5973 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
5974 in block' checks to Block.CheckInvariantMeaningInBlock.
5975 * statement.cs (Block.GetKnownVariableInfo): Make private.
5976 (Block.IsVariableUsedInChildBlock): Remove.
5977 (Block.IsVariableUsedInBlock): Likewise.
5978 (Block.CheckInvariantMeaningInBlock): New. Show location of
5979 conflicting declaration.
5980 (Block.AddVariable): Make error messages less long-winded and more
5981 specific. Show location of conflicting declaration.
5982 * parameter.cs (Parameters.Location): New readonly property.
5984 2005-03-31 Raja R Harinath <rharinath@novell.com>
5986 Clean up semantics of invoking ResolveMemberAccess.
5987 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
5988 can have an instance, ensure that we pass in a non-TypeExpression
5989 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
5990 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
5991 argument. Update to changes and simplify.
5992 (FieldExpr.Emitinstance): Remove CS0120 check.
5993 (PropertyExpr.EmitInstance): Likewise.
5994 * expression.cs (Argument.Resolve): Likewise.
5995 (Invocation.DoResolve): Update to changes in semantics of
5998 2005-03-31 Marek Safar <marek.safar@seznam.cz>
6001 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
6004 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
6006 2005-03-31 Raja R Harinath <rharinath@novell.com>
6008 Fix difference in behaviour with commandline invocation.
6009 * driver.cs (Driver.Reset): New.
6010 (CompilerCallableEntryPoint): Call it.
6012 * statement.cs (If.Resolve): Avoid spurious "uninitialized
6013 variable" warnings if the boolean expression failed to resolve.
6015 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
6017 * attribute.cs: Fix the union of several permissions when some of them
6018 are unrestricted (so the result isn't an unrestricted permission set).
6021 2005-03-30 Raja R Harinath <rharinath@novell.com>
6023 * ecore.cs (MemberExpr): New class. Convert from interface
6025 (MemberExpr.ResolveMemberAccess): Refactor and move here from
6026 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
6028 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
6029 (MethodGroupExpr.IsExplicitImpl): Remove.
6030 (Expression.GetFieldFromEvent): Remove.
6031 (SimpleName.MemberStaticCheck): Remove.
6032 (SimpleName.DoSimpleNameResolve): Update to changes.
6033 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
6034 (MemberAccess.IdenticalNameAndTypeName): Remove.
6035 (MemberAccess.error176): Move to MemberExpr.
6036 (MemberAccess.DoResolve): Update to changes.
6037 (BaseAccess.DoResolve): Likewise.
6039 2005-03-30 Marek Safar <marek.safar@seznam.cz>
6041 C# 2.0 Conditional attribute class implementation
6043 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
6044 Analyzes class whether it has attribute which has ConditionalAttribute
6045 and its condition is not defined.
6047 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
6048 (Class.IsExcluded): New method. Search for at least one defined
6049 condition in ConditionalAttribute of attribute class.
6051 2005-03-30 Raja R Harinath <rharinath@novell.com>
6053 * ecore.cs (PropertyExpr): Derive from Expression, not
6054 ExpressionStatement.
6055 (PropertyExpr.EmitStatement): Remove.
6057 2005-03-29 Raja R Harinath <rharinath@novell.com>
6060 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
6061 internal field "value__" of an enum be private. The examples for
6062 "value__" that I found on MSDN all used FieldAttributes.Private.
6064 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
6065 Don't mention IL method attribute names.
6067 Fix #47991. Remove a TODO.
6068 * statement.cs (Block.Toplevel): Make into a field.
6069 (Block.Parameters): Move into ToplevelBlock.
6070 (Block.known_variables): Rename from child_variable_names.
6071 (Block.Block): Remove variants that take Parameters. Initialize
6072 'Toplevel' with the immediately surrounding toplevel block.
6073 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
6074 LocalInfo parameter.
6075 (Block.GetKnownVariableInfo): New.
6076 (Block.IsVariableNameUsedInChildBlock): Update.
6077 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
6078 the block, even though it may not be in scope.
6079 (Block.AddVariable): Remove Parameters parameter. Use
6080 Toplevel.Parameters instead.
6081 (Block.AddConstant): Remove Parameters parameter.
6082 (Block.GetParameterReference): Update to use Toplevel.Parameters.
6083 (Block.IsParamaterReference): Likewise.
6084 (Block.IsLocalParameter): Likewise. Simplify a lot.
6085 (ToplevelBlock.Parameters): New. Moved from Block.
6086 (ToplevelBlock.ToplevelBlock): Update to changes. Always
6087 initialize Parameters to a non-null value.
6088 * cs-parser.jay: Update to changes.
6089 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
6090 simple names that mean different things in the same block. Use
6091 Block.IsVariableNameUsedInBlock.
6093 2005-03-28 Raja R Harinath <rharinath@novell.com>
6095 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
6097 2005-03-26 Raja R Harinath <harinath@acm.org>
6100 * assign.cs (Assign.DoResolve): When the RHS of an assignment
6101 fails to resolve, ensure that the LHS is still resolved as an
6104 2005-03-25 Raja R Harinath <harinath@acm.org>
6106 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
6108 (Enum.current_ec): Remove.
6109 (Enum.LookupEnumValue): Remove EmitContext argument.
6110 Just uses the one created during DefineType.
6111 (Enum.FindMembers): Update.
6112 * expression.cs (MemberAccess.DoResolve): Update.
6114 2005-03-22 Marek Safar <marek.safar@seznam.cz>
6116 * assign.cs (Assign.DoResolve): Check for CS1717 when
6117 source and target are same (uses Equals).
6119 * expression.cs (LocalVariableReference, ParameterReference,
6120 This): Implemented Equals, GetHashCode.
6122 * statement.cs (Block.GetParameterReference): Removed useless
6125 2005-03-22 Raja R Harinath <rharinath@novell.com>
6128 * statement.cs (Block.AddVariable): Ensure that we skip implicit
6129 blocks before deciding whether the error is cs0136 or cs0128.
6131 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
6132 (using_alias_directive, using_namespace_directive): Pass
6133 MemberName, not an expression to Namespace.UsingAlias and
6135 (MakeName): Use the MemberName of the namespace.
6136 * namespace.cs (Namespace.MemberName): New.
6137 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
6138 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
6140 * decl.cs (MemberName.Name): Make readonly.
6141 (MemberName.FromDotted): New "constructor".
6142 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
6143 (MemberCore.Name): Compute from MemberName on demand.
6144 (MemberCore.SetMemberName): Provide a way to change the
6146 (MemberCore.AddToContainer): Don't take a fullname parameter.
6147 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
6148 fully qualified name of the container to the member name.
6149 (TypeContainer.AddToTypeContainer): Use a fully qualified name
6150 only if the type is a member of the root container.
6151 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
6152 MemberName.Left rather than searching for an embedded ".".
6153 (PartialContainer.CreatePart): Update to changes in RootContext.
6154 (MemberBase.ShortName): Turn into a property. Use
6155 MemberCore.SetMemberName.
6156 (MemberBase.ExplicitInterfaceName): Remove.
6157 (MemberBase.UpdateMemberName): Remove.
6158 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
6159 (PropertyBase.SetMemberName): New override.
6160 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
6161 (Tree.GetDecl): New.
6162 (Tree.AllDecls): Rename from Decls.
6163 * attribute.cs, enum.cs, report.cs: Update to changes.
6164 * driver.cs (MainDriver): Use MemberName.FromDotted on
6165 RootContext.MainClass.
6167 2005-03-21 Marek Safar <marek.safar@seznam.cz>
6169 * class.cs (FixedField.Define): Check for CS1664 and more sanity
6172 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
6174 2005-03-18 Marek Safar <marek.safar@seznam.cz>
6176 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
6177 property accessor modifiers.
6179 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
6180 fixed buffer attribute (CS1716).
6181 (PropertyMethod.HasCustomAccessModifier): When property accessor
6182 has custom modifier.
6184 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
6186 (PropertyExpr.DoResolveLValue): Add CS0272.
6188 2005-03-17 Miguel de Icaza <miguel@novell.com>
6190 * convert.cs: When converting to a pointer, use the proper Conv.U
6191 or Conv.I depending on the source data type.
6193 * cs-tokenizer.cs: Make the size for large decimal constants,
6196 2005-03-17 Martin Baulig <martin@ximian.com>
6198 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6199 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6201 2005-03-17 Martin Baulig <martin@ximian.com>
6203 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6204 to bool so we can return an error condition.
6205 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6208 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
6210 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
6213 2005-03-16 Raja R Harinath <rharinath@novell.com>
6215 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
6216 Refactor to avoid traversing the list of assemblies, and to avoid
6217 string concatenation.
6218 * typemanager.cs (guid_attr_type): Remove.
6219 (negative_hits, pointers, references): Remove hashes.
6221 (GetConstructedType): New. Uses type_hash to handle constructed
6222 types (arrays, references, pointers).
6223 (GetReferenceType, GetPointerType): Use it.
6224 (GetNestedType): New. Uses type_hash to handle nested types of
6226 (LookupType, LookupTypeDirect): Remove.
6227 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
6228 'types' hash and LookupTypeReflection directly.
6229 (params_string, params_object): Use GetConstructedType.
6230 * namespace.cs (Namespace.cached_types): New. Cache of reflected
6232 (Namespace.Lookup): Use cached_types.
6233 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
6234 provided by old TypeManager.LookupType.
6235 * rootcontext.cs (MakeFQN): Remove.
6236 * decl.cs (DeclSpace.MakeFQN): Likewise.
6237 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
6238 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6239 TypeManager.GetConstructedType.
6240 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
6242 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
6244 * cs-parser.jay: Fix build.
6246 2005-03-15 Marek Safar <marek.safar@seznam.cz>
6248 * class.cs (TypeContainer.CircularDepException) New nested
6249 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
6251 * cs-parser.jay: Reports CS1527 for any namespace element.
6253 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
6256 * expression.cs (ParameterReference.IsAssigned): Changed error to
6258 (Error_WrongNumArguments): Moved CS0245 detection here.
6260 * statement.cs (Return.Resolve): Add CS1622 report.
6262 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6264 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6266 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6268 * attribute.cs expression.cs: Get rid of some allocations.
6270 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6272 * doc.cs : just eliminate the latest change.
6274 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6276 * doc.cs : commented out the latest change. It breaks xml-030.cs
6278 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6280 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6281 fail. So invoke CreateType() in FindDocumentedType().
6283 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6285 * cs-tokenizer.cs : added IsKeyword().
6286 * doc.cs : Detect keyword incorrectly used as identifier.
6287 Allow identifiers prefixed by @.
6289 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6291 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6292 It caused exception in namespace resolving (again!).
6294 * class.cs (Class.ctor): Removed exit.
6295 (PropertyMethod.ctor): ditto.
6297 * codegen.cs (Codegen.Reset): Reset static data.
6298 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6300 * cs-tokenizer.cs (Cleanup): Removed.
6302 * driver.cs (GetSystemDir): Rewrote to one line command.
6303 It caused problem with unloaded dynamic modules.
6304 (UnixParseOption): Removed Exit.
6305 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6306 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6307 Now can be mcs used as library.
6309 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6312 * location.cs (Reset): Reset static data.
6314 * namespace.cs (Reset): Reset static data.
6316 * report.cs (Report.Reset): Reset static data.
6318 * rootcontext.cs (RootContext.Reset): Reset static data.
6320 * tree.cs (RootTypes.ctor): Use Location.Null
6322 * typemanager.cs (TypeManager.Reset): Reset static data.
6323 (CoreLookupType): Removed Exit.
6324 (TypeHandle.Reset): Reset static data.
6326 2005-03-10 Raja R Harinath <rharinath@novell.com>
6329 * typemanager.cs (ComputeNamespaces): Import namespaces from
6330 referenced modules too.
6332 2005-03-09 Raja R Harinath <rharinath@novell.com>
6334 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6337 2005-03-09 Raja R Harinath <rharinath@novell.com>
6339 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6340 enclosing DeclSpace. This ensures that a name-lookup populates
6341 more caches and there are fewer 'TypeExpression's. Carve out
6342 nested type lookup into ...
6343 (LookupNestedTypeInHierarchy): ... this.
6345 2005-04-15 Martin Baulig <martin@ximian.com>
6347 Merged r41590 from MCS and make it work in the generics land.
6349 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6352 * class.cs (PartialContainer.UpdateConstraints): Removed.
6353 (PartialContainer.CheckConstraints): Removed.
6354 (PartialContainer.SetParameterInfo): Store the constraints here.
6355 (PartialContainer.DefineTypeParameters): New public method;
6356 resolve the type parameter's constraints here. Note that the
6357 PartialContainer doesn't have an EmitContext anymore, so we must
6358 do this in the ClassPart.
6360 2005-03-09 Raja R Harinath <rharinath@novell.com>
6362 Clean up a few partial-class semantics.
6363 Fixes test-357.cs and cs1618-2.cs.
6364 * cs-parser.jay (struct_declaration): Use 'current_class' as
6365 parent of newly-created struct. Remove call to Register ().
6366 Use 'pop_current_class' to complete handing the current struct.
6367 (interface_declaration): Likewise.
6368 (class_declaration): Likewise.
6369 (enum_declaration): Use 'current_class' as parent of newly created
6371 (delegate_declaration): Likewise.
6372 (pop_current_class): New function. This is used to handle closing
6373 up the 'current_class' and 'current_container', and pointing them
6374 to the enclosing class/container.
6375 (CSharpParser): Initialize 'current_class' too.
6376 * decl.cs (MemberCore): Add check for invariant: a partial
6377 container is not a parsed entity, and thus does not enclose any
6379 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6380 (DeclSpace.BaseTypeExpr): Use it.
6381 (DeclSpace.LookupType): Add check for invariant.
6382 * class.cs (TypeContainer): Add check for invariant: a nested
6383 class should have the same NamespaceEntry as its enclosing class.
6384 (TypeContainer.EmitFieldInitializers): Make virtual.
6385 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6387 (TypeContainer.Register): Remove.
6388 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6389 null. Use TypeResolveEmitContext for resolving base types and
6390 interfaces. Move initialization of Parts.TypeBuilder here from
6392 (TypeContainer.DefineNestedTypes): ... here.
6393 (PartialContainer): Take a Namespace not a NamespaceEntry.
6394 (PartialContainer.Create): Don't use Register. Call the
6395 appropriate Add... function directly.
6396 (ClassPart): Take both the PartialContainer and the enclosing
6397 class as constructor arguments.
6398 (ClassPart.EmitFieldInitializers): Override.
6399 (ClassPart.PartFindNestedTypes): Remove.
6400 (FieldBase.GetInitializerExpression): Resolve the initializer
6401 expression in the emit context of the enclosing class.
6402 * tree.cs (RootTypes): Remove Register ().
6404 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6406 * cs-parser.jay: Removed CS0134.
6408 * driver.cs: Removed CS1901.
6410 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6411 for predefined types.
6413 2005-03-07 Duncan Mak <duncan@novell.com>
6415 * codegen.cs (Save): Catch UnauthorizedAccessException as
6416 well. Fixes bug #73454.
6418 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6420 * cs-tokenizer.cs (xtoken): Add CS1035.
6422 * class.cs (MethodData.Define): Add CS0683.
6423 (FieldMember.ctor): Add CS0681.
6425 2005-03-07 Raja R Harinath <rharinath@novell.com>
6427 * ecore.cs (SimpleName.DoResolve): Rename from
6428 SimpleName.DoResolveAllowStatic.
6429 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6430 Pass 'intermediate' flag to MemberStaticCheck.
6431 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6432 of "intermediate" lookups via MemberAccess.
6433 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6434 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6436 2005-03-07 Raja R Harinath <rharinath@novell.com>
6439 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6440 slipped in because of variable names that are identical to a
6441 builtin type's BCL equivalent ('string String;', 'int Int32;').
6442 (PropertyExpr.EmitInstance): Likewise.
6444 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6446 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6448 * report.cs (warning_ignore_table): Made public.
6450 2005-03-04 Raja R Harinath <rharinath@novell.com>
6453 * class.cs (MethodData.Emit): Pass 'container' to
6454 container.GetObsoleteAttribute instead of 'container.Parent'.
6456 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6458 * cs-parser.jay: Add 1534 error test.
6460 * iterators.cs (Yield.CheckContext): Add error 1629.
6461 (Iterator.ctor): Save unsafe modifier.
6462 (MoveNextMethod.DoEmit): Restore unsafe context.
6464 * namespace.cs (UsingAlias): Better error message.
6466 2005-03-03 Dan Winship <danw@novell.com>
6468 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6469 the warning message [#73219]
6471 2005-03-03 Raja R Harinath <rharinath@novell.com>
6473 Fix compile with MCS 1.0.0.0.
6474 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6475 w_restore to not depend on string constant folding.
6477 2005-03-03 Raja R Harinath <rharinath@novell.com>
6479 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6480 CS0246 check to users who passed 'silent = false'.
6481 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6483 (SimpleName.SimpleNameResolve): Update.
6484 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6485 (MemberAccess.IdenticalNameAndTypeName): Update.
6486 * doc.cs (FindDocumentedTypeNonArray): Update.
6488 2005-03-03 Raja R Harinath <rharinath@novell.com>
6490 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6491 * parameters.cs (ComputeAndDefineParameters): Remove.
6492 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6493 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6494 Use GetParameterInfo.
6496 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6498 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6500 2005-03-02 Raja R Harinath <rharinath@novell.com>
6502 Unify DeclSpace.LookupType and DeclSpace.FindType.
6503 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6504 is in charge of defining nested types on demand.
6505 (DeclSpace.LookupType): Use it when the current_type is a
6506 TypeBuilder. Use LookupTypeDirect for reflected types.
6507 (DeclSpace.FindType): Remove.
6508 (DeclSpace.LookupInterfaceOrClass): Likewise.
6509 (DeclSpace.DefineTypeAndParents): Likewise.
6510 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6511 DeclSpace.LookupType.
6512 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6513 * typemanager.cs (LookupType): Simplify.
6514 (AddUserType): Remove type from negative_hits.
6515 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6516 * class.cs (TypeContainer.FindMembers): Move handling of nested
6518 (TypeContainer.FindMembers_NestedTypes): ... here.
6519 (TypeContainer.FindNestedType): Implement override.
6520 (ClassPart.FindNestedType): Delegate to PartialContainer.
6521 (ClassPart.PartFindNestedType): Looks up the nested types of the
6524 2005-04-14 Martin Baulig <martin@ximian.com>
6526 * generic.cs (ConstructedType): Moved all the type lookup and
6527 nested class logic into SimpleName.
6528 (ConstructedType.ResolveConstructedType): Our underlying type is
6529 already fully resolved; all the type lookup stuff is in
6532 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6533 constructed types here instead of in ConstructedType.
6535 * decl.cs (MemberName.GetTypeExpression): Always create a
6536 SimpleName, not a ConstructedType.
6537 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6539 2005-03-02 Martin Baulig <martin@ximian.com>
6541 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6542 static constructor in static classes.
6544 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6546 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6547 sizeParamIndex is not specified.
6549 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6552 * report.cs (WarningMessage.IsEnabled): Missing null check.
6554 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6556 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6557 in the fields and not in the properties.
6559 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6561 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6564 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6566 * attribute.cs: Small refactoring (improved robustness).
6567 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6568 (ValidateGuid): Removed.
6569 (Resolve): Removed referenced to above mentioned.
6570 (GetAttributeUsage): Made private and changed to work without
6572 (GetIndexerAttributeValue): Don't crash.
6573 (GetConditionalAttributeValue): Ditto.
6574 (GetClsCompliantAttributeValue): Ditto.
6575 (ExtractSecurityPermissionSet): All attributes exceptions are
6577 (GetPropertyValue): New helper.
6578 (GetMethodImplOptions): New method.
6579 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6580 some missing properties.
6582 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6583 (Method.ApplyAttributeBuilder): Updated.
6585 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6588 2005-02-28 Raja R Harinath <rharinath@novell.com>
6591 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6592 non-simple types (array, pointer, reference).
6594 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6596 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6598 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6600 (Method.CheckBase): Catch wrong destructor here.
6601 (MethodData.Define): Add errors 550, 668.
6603 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6605 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6607 * pending.cs (VerifyPendingMethods): Add error 551.
6609 * typemanager.cs (CSharpName): Next error report helper.
6611 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6613 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6614 attributes. Removed useless attribute double check.
6615 It saves almost 2MBs for corlib.
6617 2005-02-25 Raja R Harinath <rharinath@novell.com>
6620 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6621 called twice in case of error.
6623 2005-02-23 Chris Toshok <toshok@ximian.com>
6625 Fix compiler portions of #72827.
6626 * statement.cs (Block.Emit): call Begin/EndScope on the
6627 EmitContext instead of the ILGenerator.
6629 * codegen.cs (EmitContext.BeginScope): new method, call
6630 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6632 (EmitContext.BeginScope): same, but EndScope and CloseScope
6634 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6635 offset and call the superclass's OpenScope(int) with it.
6636 (SymbolWriter.CloseScope): get the current il
6637 offset and call superclass's CloseScope(int) with it.
6639 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6641 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6642 CS1677 for out and ref as well.
6644 * class.cs (Method.Define): Add error CS1599 detection.
6646 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6648 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6650 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6652 * support.cs.cs (ModifierDesc): New helper method.
6654 2005-02-23 Raja R Harinath <rharinath@novell.com>
6655 Abin Thomas <projectmonokochi@rediffmail.com>
6656 Anoob V E <projectmonokochi@rediffmail.com>
6657 Harilal P R <projectmonokochi@rediffmail.com>
6660 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6661 MemberLookup (used for error reporting) actually returns a result.
6662 Fix error report number (122, not 112).
6664 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6665 Anoob V E <projectmonokochi@rediffmail.com>
6666 Harilal P R <projectmonokochi@rediffmail.com>
6669 * pending.cs (PendingImplementation.GetAbstractMethods):
6670 Find NonPublic members too.
6672 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6674 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6677 * class.cs (MethodCore.CheckMethodAgainstBase):
6678 Add error 239 report.
6680 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6682 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6684 * class.cs (Operator.Define): Add error 217 report.
6686 2005-02-21 Raja R Harinath <rharinath@novell.com>
6689 * expression.cs (Invocation.IsApplicable): Make public.
6690 (Invocation.IsParamsMethodApplicable): Likewise.
6691 * delegate.cs (Delegate.VerifyApplicability): Don't use
6692 Invocation.VerifyArgumentCompat for parameter applicability
6693 testing. Use Invocation.IsApplicable and
6694 Invocation.IsParamsMethodApplicable.
6696 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6698 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6700 * class.cs (Operator.Define): Add error 217 report.
6702 2005-02-21 Raja R Harinath <rharinath@novell.com>
6704 * namespace.cs (UsingEntry.Resolve): Undo change below.
6706 2005-02-21 Raja R Harinath <rharinath@novell.com>
6709 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6710 disable the error message when the extended MemberLookup also
6712 (Expression.MemberLookupFinal): Update.
6713 (SimpleName.DoSimpleNameResolve): Update.
6714 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6715 Don't use MemberLookupFinal.
6716 (New.DoResolve): Update.
6717 (BaseAccess.CommonResolve): Update.
6719 2005-02-21 Raja R Harinath <rharinath@novell.com>
6722 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6723 occured previously, don't resolve again.
6725 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6728 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6729 argument. Call ResolveAttributeUsage for unresolved.
6730 when types doesn't match ctor arguments.
6732 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6733 for nested attribute classes.
6734 (Class.attribute_usage): Removed.
6735 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6736 for attribute class.
6738 * ecore.cs (IsAttribute): Removed.
6740 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6742 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6744 (attribute_types): Removed.
6745 (EmitCode): Global attributes are emited as the latest.
6747 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6749 * class.cs (EmitFieldInitializers): Don't emit field initializer
6750 for default values when optimilization is on.
6752 * constant.cs (Constant.IsDefaultValue): New property.
6754 * driver.cs: Add /optimize handling.
6758 * literal.cs: Implement new IsDefaultValue property.
6760 * rootcontext.cs (Optimize): New field, holds /optimize option.
6762 2005-02-18 Raja R Harinath <rharinath@novell.com>
6764 Fix crasher in re-opened #72347.
6765 * namespace.cs (Namespace.Lookup): Return null if
6766 DeclSpace.DefineType returns null.
6769 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6771 2005-02-18 Raja R Harinath <rharinath@novell.com>
6773 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6774 now returns null if it cannot resolve to an lvalue.
6775 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6776 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6777 returned null. Remove check for SimpleName.
6778 (EventExpr.DoResolveLValue): New.
6779 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6780 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6782 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6784 (Unary.ResolveOperator): Move CS0211 check ...
6785 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6787 (Unary.DoResolveLValue): Simplify.
6788 (AddressOf.DoResolveLValue): New.
6789 (ArrayAccess.DoResolveLValue): New.
6791 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6793 * attribute.cs (Attribute.Resolve): Add arguments casting for
6794 when types doesn't match ctor arguments.
6796 2005-02-16 Raja R Harinath <rharinath@novell.com>
6798 Fix parts of #63202.
6799 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6800 lookup of operator in base type. Ensure that all checks happen
6801 when the operator resolves to an "op_..." method.
6803 2005-02-15 Raja R Harinath <rharinath@novell.com>
6806 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6807 'ignore_cs0104' parameter. Pass it to ...
6808 (NamespaceEntry.Lookup): ... this.
6809 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6810 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6811 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6812 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6813 Update. Request that cs0104 errors be ignored.
6814 (ComposedCast.ResolveAsTypeStep): Update.
6816 2005-02-14 Raja R Harinath <rharinath@novell.com>
6819 * expression.cs (Invocation.BetterFunction): Remove support for
6820 comparing virtual functions and their overrides.
6821 (Invocation.IsOverride): New.
6822 (Invocation.OverloadResolve): Don't consider 'override' functions
6823 during candidate selection. Store them in a lookaside list.
6824 If the selected method is a 'virtual' function, use the list to
6825 find any overrides that are closer to the LHS type.
6827 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6829 * expression.cs (New.DoResolve): Add complex core type reduction.
6830 (New.Constantify): Converts complex core type syntax like 'new int ()'
6833 2005-02-14 Raja R Harinath <rharinath@novell.com>
6835 * decl.cs (EntryType.EntryType): New constructor to create an
6836 updated copy of a cache entry.
6837 (MemberCache.AddMethods): Use it.
6838 (MemberCache.ClearDeclaredOnly): Remove.
6839 (MemberCache.MemberCache): Update.
6841 2005-02-11 Miguel de Icaza <miguel@novell.com>
6843 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6844 variable. This one is represents the actual low-level declaration
6845 of the method, as opposed to the semantic level `IsStatic'.
6847 An anonymous method which is hosted into a static method might be
6848 actually an instance method. IsStatic would reflect the
6849 container, while MethodIsStatic represents the actual code
6852 * expression.cs (ParameterReference): Use the new MethodIsStatic
6853 instead of IsStatic.
6855 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6856 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6857 set on the current EmitContext.
6859 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6860 resolve our casted expression as an LValue. This triggers the
6861 proper LValue processing that is later required by Assign.
6865 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6867 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6869 C# 2.0 Fixed buffer implementation
6871 * anonymous.cs: Update after RegisterHelperClass renaming.
6873 * attribute.cs (AttributeTester.fixed_buffer_cache):
6874 Cache of external fixed buffers.
6875 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
6876 implementation if field is fixed buffer else null.
6879 (TypeContainer.AddField): Accept FieldMember instead of Field.
6880 (FieldBase.IsFieldClsCompliant): Extracted code from
6881 VerifyClsCompliance descendant customization.
6882 (FixedField): New class handles fixed buffer fields.
6883 (FixedFieldExternal): Keeps information about imported fixed
6885 (IFixedField): Make access to internal or external fixed buffer
6888 * cs-parser.jay: Add fixed buffer parsing.
6890 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
6893 * expression.cs (Indirection): Extended implementation to accept
6895 (PointerArithmetic.Emit): Get element from fixed buffer as well.
6896 (ElementAccess.MakePointerAccess): Get type as parameter.
6897 (DoResolve): Add fixed buffer field expression conversion.
6898 (DoResolveLValue): Ditto.
6899 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
6900 (ArrayPtr): Derives from FixedBufferPtr.
6901 (ArrayPtr.Emit): Add extra emit for array elements.
6903 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
6905 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
6906 for compiler generated types.
6907 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
6909 * statement.cs (Fixed): Refactored to be easier add fixed buffer
6910 and consume less memory.
6911 (Fixed.Resolve): Add fixed buffer case.
6913 * typemanager.cs (compiler_generated_attr_ctor,
6914 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
6915 (HasElementType): Add our own implementation to work on every
6918 2005-02-11 Miguel de Icaza <miguel@novell.com>
6920 * anonymous.cs (CaptureContext): Track whether `this' has been
6923 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
6924 only captured `this' if it was implicitly done (instance
6925 methods/variables were used).
6927 * codegen.cs (EmitContext.CaptureThis): New method to flag that
6928 `this' must be captured.
6930 2005-01-30 Miguel de Icaza <miguel@novell.com>
6932 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
6933 is null it means that there has been no need to capture anything,
6934 so we just create a sibling.
6936 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
6938 Just a partial fix. The other half is fairly elusive.
6940 2005-02-10 Raja R Harinath <rharinath@novell.com>
6942 Fix #52586, cs0121-4.cs.
6943 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
6944 and return a hashtable.
6945 (MemberCache.ClearDeclaredOnly): New.
6946 (MemberCache.MemberCache): Update to change. Make a deep copy of
6947 the method_hash of a base type too.
6948 (MemberCache.AddMethods): Adapt to having a deep copy of the base
6949 type methods. Overwrite entries with the same MethodHandle so
6950 that the ReflectedType is correct. The process leaves in base
6951 virtual functions and their overrides as distinct entries.
6952 (CacheEntry): Now a class instead of a struct. It shouldn't alter
6953 matters since it was boxed in a ArrayList before.
6954 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
6956 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
6957 case of a virtual function and its override (choose the overload
6959 (Invocation.OverloadResolve): Avoid 'override' members during
6960 'applicable_type' calculation.
6962 2005-03-28 Raja R Harinath <rharinath@novell.com>
6964 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
6965 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
6966 GetTypeHandle. It is possible for a reflected type to derive from
6967 a TypeBuilder (e.g., int[] derives from the TypeBuilder
6968 System.Array during mscorlib compilation).
6969 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
6970 contain a method_hash, don't create one either. Don't create a
6971 deep copy of the base cache's method_hash.
6972 (MemberCache.SetupCache): Rename back from DeepCopy.
6973 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
6974 already initialized. If we see an override function, add its
6975 underlying base virtual function to the member_hash too.
6977 2005-02-09 Raja R Harinath <rharinath@novell.com>
6979 Combine two near-redundant caches.
6980 * typemanager.cs (method_params): Rename from method_internal_params.
6981 (TypeManager.GetParameterData): New. Replace
6982 Invocation.GetParameterData.
6983 (TypeManager.LookupParametersByBuilder): Remove.
6984 * expression.cs (Invocation.method_parameter_cache): Remove.
6985 (Invocation.GetParameterData): Remove.
6987 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
6990 2005-02-08 Raja R Harinath <rharinath@novell.com>
6993 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
6994 TypeManager.multicast_delegate_type is null, resolve it by looking
6995 up "System.MulticastDelegate".
6996 * rootcontext.cs (RootContext.ResolveCore): Simplify.
6998 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
6999 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
7000 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
7003 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
7004 (LabeledStatement.AddReference): New. Set 'referenced'.
7005 (Goto.Resolve): Use it.
7007 2005-02-05 John Luke <john.luke@gmail.com>
7009 * driver.cs: remove duplicate -doc line in Usage ()
7011 2005-02-04 Raja R Harinath <rharinath@novell.com>
7013 * location.cs (Location.AddFile): Fix CS2002 error report.
7015 2005-02-02 Martin Baulig <martin@ximian.com>
7017 * delegate.cs (Delegate.DefineType): Report an internal error if
7018 TypeManager.multicast_delegate_type is null. See bug #72015 for
7021 2005-02-02 Raja R Harinath <rharinath@novell.com>
7023 Fix a crasher in a variant of #31984.
7024 * const.cs (Constant.CheckBase): New override that defers the
7025 new-or-override check in case the base type hasn't been populated
7027 (Constant.Define): Ensure the new-or-override check is performed.
7029 2005-02-01 Duncan Mak <duncan@ximian.com>
7031 * const.cs (LookupConstantValue): Check that `ce' is not null
7032 before calling GetValue ().
7034 2005-02-01 Raja R Harinath <rharinath@novell.com>
7036 Fix test-334.cs (#69519).
7037 * cs-parser.jay (using_alias_directive): Pass in an expression to
7038 NamespaceEntry.UsingAlias.
7039 (using_namespace_directive): Pass in an expression to
7040 NamespaceEntry.Using.
7041 (namespace_name): Don't flatten to a string.
7042 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
7043 (NamespaceEntry.AliasEntry.Resolve): Lookup using
7045 (NamespaceEntry.UsingEntry): Likewise.
7046 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
7048 (NamespaceEntry.LookupForUsing): Remove.
7049 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
7051 (NamespaceEntry.Lookup): Remove support for dotted names.
7053 2005-02-01 Raja R Harinath <rharinath@novell.com>
7055 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
7057 (NamespaceEntry.ImplicitParent): Compute on demand.
7058 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
7059 parallels the current.
7060 (NamespaceEntry.LookupForUsing): Use it.
7061 (NamespaceEntry.Lookup): If the current namespace-entry is
7062 implicit, don't search aliases and using tables.
7064 2005-02-01 Raja R Harinath <rharinath@novell.com>
7067 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
7069 (TypeContainer.BaseCache): Compute on demand.
7070 (TypeContainer.FindMembers): Define constants and types if they're
7071 not already created.
7072 (FieldMember.Define): Move resetting of ec.InUnsafe before error
7074 * const.cs (Constant.Define): Make idempotent.
7076 2005-01-29 Miguel de Icaza <miguel@novell.com>
7078 * pending.cs: Produce better code (no nops produced by using Ldarg
7081 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7082 i - 1' it should be arg + 1.
7086 2005-01-28 Raja R Harinath <rharinath@novell.com>
7088 * attribute.cs (Attribute.CheckAttributeType): Make private
7090 (Attribute.ResolveType): Make virtual.
7091 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
7092 handling of RootContext.Tree.Types.
7094 2005-01-27 Raja R Harinath <rharinath@novell.com>
7096 Update attribute-handling to use the SimpleName/MemberAccess
7098 * cs-parser.jay (attribute): Pass in an expression to the
7099 constructors of Attribute and GlobalAttribute.
7100 * attribute.cs (Attribute): Take an expression for the name.
7101 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
7102 passed in attribute name expression.
7103 (Attribute.CheckAttributeType): Use it.
7104 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
7105 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
7106 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
7107 argument to prevent error messages if the lookup fails.
7109 2005-01-27 Marek Safar <marek.safar@seznam.cz>
7111 * expression.cs (Indirection): Implemented IVariable interface
7112 to support indirection in AddressOf operator.
7113 (PointerArithmetic.Emit): Add optimalization for case where
7114 result can be precomputed.
7116 2005-01-26 Martin Baulig <martin@ximian.com>
7118 * class.cs (TypeContainer.AttributeTargets): Return the correct
7119 AttributeTargets depending on our `Kind' instead of throwing an
7120 exception; fixes #71632.
7122 2005-01-26 Marek Safar <marek.safar@seznam.cz>
7125 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
7128 2005-03-17 Martin Baulig <martin@ximian.com>
7130 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
7131 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
7133 2005-03-17 Martin Baulig <martin@ximian.com>
7135 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
7136 to bool so we can return an error condition.
7137 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
7140 2005-03-17 Martin Baulig <martin@ximian.com>
7142 * generic.cs (TypeMananager.IsIEnumerable): New public method.
7144 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
7145 converting from an array-type of T to `IEnumerable<T>'.
7147 2005-03-16 Martin Baulig <martin@ximian.com>
7149 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
7150 (Nullable.LiftedUnaryMutator): New public class.
7152 * expression.cs (UnaryMutator.DoResolve): Added support for
7155 2005-03-14 Martin Baulig <martin@ximian.com>
7157 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
7159 2005-03-14 Martin Baulig <martin@ximian.com>
7161 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
7162 the comparision operators `<', `>', `<=' and `>='.
7164 2005-03-13 Martin Baulig <martin@ximian.com>
7167 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
7168 avoid confusion with the `NullLiteral'.
7169 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
7171 2005-03-13 Martin Baulig <martin@ximian.com>
7173 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
7174 comparing arbitrary types with the null literal.
7176 2005-03-13 Martin Baulig <martin@ximian.com>
7178 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
7179 boolean operators '&&', '||', '&' and '|'.
7180 (Nullable.OperatorTrueOrFalse): New public class.
7182 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
7183 instead of a `StaticCallExpr'; added support for nullables.
7185 2005-03-10 Martin Baulig <martin@ximian.com>
7188 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
7189 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
7191 2005-03-07 Martin Baulig <martin@ximian.com>
7193 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
7194 it work if `expr' is not an IMemoryLocation.
7195 (Nullable.Lifted): Implement IMemoryLocation.
7196 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
7199 2005-03-05 Martin Baulig <martin@ximian.com>
7201 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
7202 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
7203 (Nullable): Added support for lifted unary and binary operators.
7205 * expression.cs (Unary.DoResolve): Added support for nullable types.
7206 (Binary.DoResolve): Likewise.
7207 (Conditional.DoResolve): Likewise.
7209 2005-03-02 Martin Baulig <martin@ximian.com>
7211 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
7213 * class.cs (ClassPart.SetParameterInfo): Override this.
7214 (PartialContainer.SetParameterInfo): Override this.
7215 (TypeContainer.CheckConstraints): New protected method.
7216 (PartialContainer.CheckConstraints): Override this and check
7217 whether the same contraints were specified in all parts of a
7218 partial generic type definition.
7219 (PartialContainer.UpdateConstraints): New public method.
7221 * generic.cs (TypeParameter.UpdateConstraints): New public method.
7223 2005-03-02 Martin Baulig <martin@ximian.com>
7225 Committing a patch from Carlos Alberto Cortez to fix #72887.
7227 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
7228 casts from `T []' to `int []'.
7230 2005-03-02 Martin Baulig <martin@ximian.com>
7232 * generic.cs (TypeManager.IsEqual): Make this symmetric.
7234 * expression.cs (Binary.ResolveOperator): When resolving a
7235 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
7236 `=='. Fixes #71866. See gen-127.cs.
7238 2005-03-02 Martin Baulig <martin@ximian.com>
7240 * class.cs (TypeContainer.DoDefineMembers): We also need a default
7241 static constructor in static classes.
7243 2005-03-02 Martin Baulig <martin@ximian.com>
7246 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
7247 (Nullable.LiftedConversion): Added support for user-defined
7250 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
7252 * cs-parser.jay: Use ComposedCast everywhere instead of
7253 NullableType, so we don't need to check for NullableType
7255 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
7256 case where we'll be resolved into a `parenthesized_expression_0'
7260 (Convert.UserDefinedConversion): Added nullable conversions.
7262 2005-02-28 Martin Baulig <martin@ximian.com>
7264 * generic.cs (TypeManager.IsNullableType): New static method.
7265 (Nullable): New abstract class.
7266 (Nullable.NullLiteral): New public class.
7267 (Nullable.LiftedConversion): New public class.
7269 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7270 `builtin_types opt_nullable'.
7273 (Convert.ImplicitConversionStandard): Added nullable conversions.
7274 (Convert.ExplicitConversionStandard): Likewise.
7275 (Convert.ExplicitConversion): Likewise.
7277 2005-02-26 Martin Baulig <martin@ximian.com>
7279 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7280 begin with a "?", for instance "?[]". Don't do a type lookup if
7283 2005-02-25 Martin Baulig <martin@ximian.com>
7285 The first part of Nullable Types :-)
7287 * generic.cs (NullableType): New public class.
7288 (NullCoalescingOperator): New public class.
7289 (TypeArguments.Resolve): Add a CS0306 check.
7291 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7292 (opt_nullable): New rule.
7293 (type): Added `opt_nullable' to `namespace_or_type_name',
7294 `builtin_types' and `pointer_type'.
7295 (array_type): Added `opt_nullable'.
7296 (opt_rank_specifier_or_nullable): New rule; this is the
7297 combination of `opt_rank_specifier' and `opt_nullable'.
7298 (opt_error): New rule; catch errors here.
7299 (nullable_type_or_conditional): New rule; we use this to check for
7300 nullable and still detect the conditional operator.
7301 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7302 instead `opt_rank_specifier'.
7304 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7307 2005-02-24 Martin Baulig <martin@ximian.com>
7309 * README, README.Changes: Removed; they're old and obsolete.
7311 2005-02-22 Martin Baulig <martin@ximian.com>
7313 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7314 returned an error, set `constraints' to null to avoid a crash
7316 (TypeParameter.ResolveType): Likewise.
7318 2005-02-22 Martin Baulig <martin@ximian.com>
7321 (Constraints.ResolveTypes): Protect against being called twice.
7322 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7323 (TypeParameter.ResolveType): New public method; calls
7324 constraints.ResolveTypes().
7325 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7326 into the new ResolveType().
7327 (GenericMethod.Define): Call ResolveType() on all our
7330 2005-02-21 Martin Baulig <martin@ximian.com>
7333 (TypeManager.generic_nullable_type): New static public field.
7334 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7337 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7339 2005-02-15 Martin Baulig <martin@ximian.com>
7341 * generic.cs (ConstructedType.Constraints): Correctly check
7342 constraints if the argument type is a type parameter; fixes
7345 2005-02-02 Martin Baulig <martin@ximian.com>
7347 * delegate.cs (Delegate.DefineType): Report an internal error if
7348 TypeManager.multicast_delegate_type is null. See bug #72015 for
7351 2005-01-29 Miguel de Icaza <miguel@novell.com>
7353 * pending.cs: Produce better code (no nops produced by using Ldarg
7356 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7357 i - 1' it should be arg + 1.
7361 2005-01-26 Martin Baulig <martin@ximian.com>
7363 * cs-parser.jay (indexer_declarator): Don't report an error if we
7364 have type parameters since we can be an explicit interface
7365 implementation; fixes #71449.
7367 2005-01-26 Martin Baulig <martin@ximian.com>
7369 * class.cs (TypeContainer.AttributeTargets): Return the correct
7370 AttributeTargets depending on our `Kind' instead of throwing an
7371 exception; fixes #71632.
7373 2005-01-26 Martin Baulig <martin@ximian.com>
7375 * delegate.cs (Delegate.DefineType): Correctly define our type
7376 parameters. Fixes #71483.
7378 2005-01-25 Raja R Harinath <rharinath@novell.com>
7381 * expression.cs (MemberAccess.DoResolve): Don't complain with
7382 cs0572 when the LHS of a member access has identical name and type
7385 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7388 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7390 Create custom PermissionSet only for PermissionSetAttribute.
7392 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7395 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7396 delegates in static class.
7398 2005-01-24 Martin Baulig <martin@ximian.com>
7400 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7401 merging an implicit block, just use its reachability.
7403 * statement.cs (Block.Resolve): Make the unreachable code check
7404 work wrt. implicit blocks; see test-337 from #63842.
7406 2005-01-21 Alp Toker <alp@atoker.com>
7408 * cs-parser.jay: destructor_declaration's container is PartialContainer
7409 not Class when partial types are used, so use Kind prop instead of
7412 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7414 * cs-parser.jay: Improve error reporting when an interface
7417 2005-01-20 Dick Porter <dick@ximian.com>
7419 * support.cs: SeekableStreamReader fix from Sandor Dobos
7420 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7421 chars are read. Fixes bug 70369.
7423 2005-01-20 Raja R Harinath <rharinath@novell.com>
7425 * cs-parser.jay (catch_clause): Simplify current_block handling
7428 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7430 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7431 code with ImplicitStandardConversion to handle the implicit
7432 conversion of method groups into valid delegate invocations.
7434 The problem is that in parameter handling we were using this code
7435 path. Fixes bug #64698
7437 2005-01-19 Raja R Harinath <rharinath@novell.com>
7439 * cs-parser.jay: Fix several infelicities.
7440 - Avoid assigning to the parser value stack. Code like
7441 '$3 = null' is unclean. Synthesize a value for the code block
7443 - Avoid using oob_stack for storing location information. Use ...
7444 (_mark_): ... this. New (empty) rule. Saves the current location
7446 (foreach_statement): Avoid using oob_stack for current_block
7447 handling. Use technique used in for_statement and
7448 using_statement. Synthesize a value for the code block to store
7449 additional intermediate information.
7451 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7453 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7454 of a different type is only allowed to private fields of a
7455 containing type, not on fields of a base class.
7457 See test-174.cs and error cs0122-9.cs
7459 2005-01-13 Raja R Harinath <rharinath@novell.com>
7461 Fix test-335.cs (bug #58126).
7462 * cs-parser.jay (argument): Split out non-expression parts of the
7463 rule into 'non_simple_argument'.
7464 (invocation_expression): Support parenthesized invocations with
7465 multiple arguments, and with single non-simple arguments.
7467 2005-01-13 Raja R Harinath <rharinath@novell.com>
7469 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7472 2005-01-12 Raja R Harinath <rharinath@novell.com>
7474 Fix cs0038-1.cs, cs1640-6.cs.
7475 * ecore.cs (Expression.Resolve): Remove special-case for
7476 SimpleName in error-handling.
7477 (Expression.almostMatchedMembers): Relax access permission to
7479 (Expression.MemberLookupFailed): Handle duplicates in
7480 almostMatchedMembers list.
7481 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7482 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7483 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7484 overload if the passed in MemberInfo is a MethodBase.
7486 2005-01-25 Martin Baulig <martin@ximian.com>
7489 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7491 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7494 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7495 for non-CAS & merge permission sets properly.
7497 2005-01-11 Raja R Harinath <rharinath@novell.com>
7499 Improve standard-compliance of simple name and member access
7500 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7501 * ecore.cs (FullNamedExpression): New abstract base class
7502 for Namespaces and TypeExpressions.
7503 (ResolveFlags.SimpleName): Remove.
7504 (SimpleName): Remove support for dotted names.
7505 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7506 DeclSpace.FindType and DeclSpace.LookupType.
7507 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7508 (Expression.ExprClassName): Make member function.
7509 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7510 a namespace. Remove creation of dotted "SimpleName"s.
7511 (MemberAccess.DoResolve): Likewise.
7512 * decl.cs (DeclSpace.Cache): Make private.
7513 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7514 (DeclSpace.FindType): Update.
7515 (DeclSpace.LookupType): Move here from RootContext. Return a
7516 FullNamedExpression.
7517 * namespace.cs (Namespace): Derive from FullNamedExpression
7518 so that it can be part of expression resolution.
7519 (Namespace.Lookup): Return an FullNamedExpression.
7520 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7522 * rootcontext.cs (NamespaceLookup): Remove.
7523 (LookupType): Move to DeclSpace.
7524 * attribute.cs (CheckAttributeType): Update.
7525 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7526 (FindDocumentedTypeNonArray): Likewise.
7528 2005-01-11 Raja R Harinath <rharinath@novell.com>
7530 Fix cs0509.cs, cs1632.cs.
7531 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7532 is the same as IsInterface.
7533 (TypeContainer.GetClassBases): Likewise.
7534 * statement.cs (LabeledStatement.ig): New field.
7535 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7537 (LabeledStatement.DoEmit): Check that the label was created with
7538 the same ILGenerator.
7540 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7543 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7544 accessors to its properties.
7546 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7547 from accessors to property.
7549 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7552 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7555 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7557 * attribute.cs: Check for null and empty strings.
7559 I have lost another battle to Paolo.
7561 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7564 * class.cs (PropertyMethod): Set Parent field in ctors.
7565 (SetMethod.InternalParameters): Add unsafe switch hack.
7566 Override MarkForDuplicationCheck where it is appropriate.
7568 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7569 It says whether container allows members with the same name.
7571 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7572 Removed is_method parameter.
7574 2005-01-06 Duncan Mak <duncan@ximian.com>
7576 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7577 because the previous change led to incorrect reporting of CS1032
7578 ("Cannot define/undefine preprocessor symbols after first token in
7579 file"). Instead of using `tokens_seen' as the only flag that
7580 triggers CS1040, introduce `comments_seen'. This new flag is used
7581 to signify having seen comments on the current line, so it is
7582 unset after a newline.
7584 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7586 * doc.cs : When searching for a type, find nested type too.
7587 This fixes bug #71040.
7589 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7592 - Warn missing member comment on those classes which also does not
7593 have doc comments. Fixed bug #71041.
7594 - Don't warn missing doc comment on default constructor.
7597 2005-01-06 Duncan Mak <duncan@ximian.com>
7599 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7600 comments, set `tokens_seen' to true. This allows us to detect
7601 misplaced preprocessor directives (i.e. not at the beginning of
7602 the a line, nor after whitespaces). In that case, report error
7603 CS1040. This fixes bug #56460.
7605 * cs-parser.jay (interface_member_declaration): Add checks for
7606 IsExplicitImpl, and report CS0541 error if an interface member is
7607 defined as an explicit interface declaration.
7609 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7612 * class.cs (PropertyMethod): Set Parent field in ctors.
7613 (SetMethod.InternalParameters): Add unsafe switch hack.
7615 * decl.cs (MemberCore.Parent): Cannot be readonly.
7617 2005-01-06 Raja R Harinath <rharinath@novell.com>
7619 * decl.cs (DeclSpace.ResolveType): Remove.
7620 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7621 Merge in code from ...
7622 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7623 * class.cs, enum.cs: Update to changes.
7625 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7627 * anonymous.cs: Ensure that we init the scope of our parent if it
7628 has not been initialized yet.
7630 2004-12-30 Duncan Mak <duncan@ximian.com>
7632 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7633 if field.FieldBuilder is null. Fixes #70758.
7635 * convert.cs: Fixed some typos and updated some of the comments.
7636 (ImplicitStandardConversionExists):
7637 (TryImplicitIntConversion): If `target_type' is an interface and
7638 the type of `ic' implements this interface, return true or a new
7639 BoxedCast instead of null. This fixes #70468.
7641 2004-12-29 Duncan Mak <duncan@ximian.com>
7643 * expression.cs (Argument.Emit): Check that Expr is
7644 IMemoryLocation before casting to it, and report CS1510 otherwise.
7648 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7650 * statement.cs (Block.ThisVariable): remove the recursion here, to
7651 make the --profile more sane.
7653 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7655 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7656 assembly, by JB Evain.
7658 2004-12-17 Raja R Harinath <rharinath@novell.com>
7660 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7661 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7662 "parent" refers to enclosing type/class. "base" refers to superclass.
7664 2004-12-17 Raja R Harinath <rharinath@novell.com>
7666 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7667 Ensure that we only have GlobalAttributes.
7668 * attribute.cs (Attribute.Emit): Make non-virtual.
7669 (GlobalAttribute.Emit): Remove.
7670 (Attribute.Resolve): Make virtual.
7671 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7672 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7673 the argument. Don't create one.
7674 (Attribute.GetObsoleteAttribute): Likewise.
7675 (Attribute.GetClsCompliantAttributeValue): Likewise.
7676 * class.cs, decl.cs: Update to changes.
7678 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7680 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7682 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7684 * statement.cs (Foreach.Resolve): Add error 186 report.
7686 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7688 * expression.cs (Conditional.DoResolve): Add warning 429.
7690 * statement.cs (If.Resolve): Add warning 665.
7692 2004-12-16 Raja R Harinath <rharinath@novell.com>
7694 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7695 except when in the parser, and in GlobalAttribute.
7696 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7697 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7698 RootContext.Tree.Types.NamespaceEntry once work is done.
7699 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7700 and resets RootContext.Tree.Types.NamespaceEntry.
7702 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7704 * cs-parser.jay: Don't create a block for every variable.
7706 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7708 * location.cs: Provide extra information.
7710 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7711 variables from the captured environment, it is the ldarg_0.
7713 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7715 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7718 * class.cs: Changed warning level for 169 to avoid developer
7719 displeasure from warning flooding. It will be changed back when they
7720 fix most of current BCL warnings.
7722 * RootContext.cs: Pushed default WarningLevel to 3.
7724 * statement.cs: Removed unused variable.
7726 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7728 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7729 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7730 Add error 502 report.
7731 (StaticClass.DefineType): Add error 441 report.
7732 (Class.AllowedModifiersProp): New virtual property as temporary
7733 extension to AllowedModifiers.
7734 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7735 to share implementation with StaticClass and don't call virtual
7738 * driver.cs (MainDriver): Add error 1558 test.
7740 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7741 report. Moved error 36 test here.
7743 * statement.cs (Throw.Resolve): Add error 724 report.
7745 * typemanager.cs: Add out_attribute_type core type.
7747 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7749 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7751 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7753 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7756 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7758 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7759 Add error 3023 report.
7760 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7762 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7765 2004-12-12 John Luke <john.luke@gmail.com>
7767 * driver.cs (AddArgs): take -- into account when
7768 adding arguments, fixes bug 65710
7770 2004-12-12 Martin Baulig <martin@ximian.com>
7772 * expression.cs (Unary.TryReduceNegative): Added support for
7773 SByteConstant and ByteConstant.
7774 (Unary.Reduce): Check error values from TryReduceNegative().
7776 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7778 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7779 and report exception as error 182.
7781 2004-12-10 Raja R Harinath <rharinath@novell.com>
7783 * driver.cs (Main): Fix message when there are warnings.
7785 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7787 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7789 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7791 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7792 Reduced number of warnings.
7794 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7796 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7798 * driver.cs: Removed message.
7800 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7802 2004-12-08 <vargaz@freemail.hu>
7804 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7806 2004-12-08 Martin Baulig <martin@ximian.com>
7808 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7809 instead of a CS3002 for properties and indexer.
7811 2004-12-08 Martin Baulig <martin@ximian.com>
7813 * decl.cs (MemberName.ToString): Make this work again.
7815 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7817 * attribute.cs (Resolve): Add error 591 detection.
7819 * class.cs (FieldMember.Define): Add error 1547 detection.
7820 (Indexer.Define): Add error 620 detection.
7821 (Operator.Define): Add error 590 detection.
7823 * ecore.cs: Missing argument for error 79.
7825 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7828 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7831 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7834 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7836 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7837 Some operator comments were suppressed.
7838 * doc.cs : Implicit/explicit operator name in doc comments are like
7839 "op_Explicit(type)~returnType", so added suffix handling.
7841 2005-01-21 Alp Toker <alp@atoker.com>
7843 * cs-parser.jay: destructor_declaration's container is PartialContainer
7844 not Class when partial types are used, so use Kind prop instead of 'is'.
7846 2004-12-12 Martin Baulig <martin@ximian.com>
7848 * expression.cs (Unary.TryReduceNegative): Added support for
7849 SByteConstant and ByteConstant.
7850 (Unary.Reduce): Check error values from TryReduceNegative().
7852 2004-12-11 Martin Baulig <martin@ximian.com>
7854 * support.cs (ReflectionParameters.ParameterName): If we have a
7855 `gpd', call `ParameterName' on it.
7857 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7859 * pending.cs (PendingImplementation.DefineProxy): Call
7860 DefineParameter() for all of the MethodBuilder's arguments.
7862 2004-12-09 Martin Baulig <martin@ximian.com>
7864 * doc.cs (DocUtil): Make this a static class.
7866 2004-12-09 Martin Baulig <martin@ximian.com>
7868 * expression.cs (Invocation.InferType): Moved the type inference
7869 implementation into TypeManager.
7871 * generics.cs (TypeManager): Moved the type inference
7872 implementation here.
7874 2004-12-09 Martin Baulig <martin@ximian.com>
7876 * typemanager.cs (TypeManager): Make this a partial class.
7879 (TypeManager): Move the generics part of `TypeManager' here.
7881 2004-12-08 Martin Baulig <martin@ximian.com>
7883 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7884 instead of a CS3002 for properties and indexer. Added CS3024
7885 check for generic interfaces.
7887 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
7888 instances are not CLS-compliant.
7890 2004-12-08 Martin Baulig <martin@ximian.com>
7893 (void_pointer_expression): New rule for `void*', `void**' etc.
7894 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
7896 2004-12-08 Martin Baulig <martin@ximian.com>
7898 * expression.cs (Invocation.InferType): Removed the hack for
7899 MethodCore.MayUnify().
7901 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
7904 * class.cs (MethodCore.MayUnify): Use
7905 TypeManager.MayBecomeEqualGenericTypes().
7907 2004-12-08 Martin Baulig <martin@ximian.com>
7909 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
7910 parameter, box it. Fixes #69233.
7912 2004-12-08 Martin Baulig <martin@ximian.com>
7914 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
7915 have the ctor constraint. Fixes #68326.
7917 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7919 * cs-parser.jay : interface comment was not consumed because of
7920 extra opt_semicolon before doc handling.
7922 2004-12-03 Raja R Harinath <rharinath@novell.com>
7924 Fix test-327.cs, test-328.cs, and put in early infrastructure
7925 for eventually fixing #52697.
7926 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
7927 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
7929 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
7930 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
7931 (VerifyUsing, error246): Update.
7932 * rootcontext.cs (RootContext.NamespaceLookup): Just use
7933 'NamespaceEntry.LookupNamespaceOrType'.
7935 2004-12-07 Martin Baulig <martin@ximian.com>
7937 * driver.cs: Call it "BETA SOFTWARE" :-)
7939 2004-12-06 Raja R Harinath <rharinath@novell.com>
7941 Fix crash on cs0657-17.cs.
7942 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7943 Use RootContext.Tree.Types, not 'new RootTypes ()'.
7944 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
7945 the case where the NamespaceEntry gets overwritten.
7947 2004-12-06 Marek Safar <marek.safar@seznam.cz>
7949 Fixed #69195, #56821
7950 * ecore.cs (ResolveBoolean): Tiny refactoring.
7952 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
7953 of right expression resolving when left is false constant and
7954 operator is LogicalAnd OR true constant and operator is LogicalOr.
7956 * statement.cs (ResolveUnreachable): Always reports warning.
7958 2004-12-05 Miguel de Icaza <miguel@ximian.com>
7960 * class.cs: Distinguish between 1721 and 1722 (just a little help
7961 for the programmer).
7963 2004-12-03 Miguel de Icaza <miguel@ximian.com>
7965 * delegate.cs: Only allow this on new versions of the language.
7967 2004-12-02 Duncan Mak <duncan@ximian.com>
7969 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
7971 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
7972 here as a static method. Take an additional bool out parameter
7973 `must_do_cs1540_check' for signaling to InstanceResolve.
7974 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
7975 member field from PropertyExpr class and made it an argument of
7977 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
7978 check for MarshalByRefObject, and report CS0122 instead of CS1540.
7979 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
7980 and `remove_accessor' as well as InstanceResolve: report CS0122
7985 2004-12-07 Martin Baulig <martin@ximian.com>
7987 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
7988 and CS0692 where appropriate.
7990 2004-12-06 Martin Baulig <martin@ximian.com>
7992 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
7993 IsDuplicateImplementation() and improved it.
7995 * expression.cs (Invocation.InferTypeArguments): Added
7996 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
7997 and removed the "ref" modifier from `infered_types'.
7999 * decl.cs (MemberName.ToString): Removed the exception.
8001 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
8003 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
8004 comments are allowed.
8006 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8008 * delegate.cs: Add checks for subtypes in paramaters and return values
8009 in VerifyMethod () to add support for Covariance/Contravariance
8012 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8014 * report.cs: Remove extra closing parenthesis.
8016 * convert.cs (Error_CannotImplicitConversion): If the name of the
8017 types are the same, provide some extra information.
8019 2004-12-02 Marek Safar <marek.safar@seznam.cz>
8022 * attribute.cs (Resolve): Improved implementation of params
8023 attribute arguments.
8025 * support.cs (ParameterData): Add HasParams to be faster.
8027 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
8029 all things are for /doc support:
8031 * doc.cs: new file that supports XML documentation generation.
8032 * mcs.exe.sources: added doc.cs.
8034 Handle /doc command line option.
8035 Report error 2006 instead of 5 for missing file name for /doc.
8036 Generate XML documentation when required, after type resolution.
8038 Added support for picking up documentation (/// and /** ... */),
8039 including a new XmlCommentState enumeration.
8041 Added lines to fill Documentation element for field, constant,
8042 property, indexer, method, constructor, destructor, operator, event
8043 and class, struct, interface, delegate, enum.
8044 Added lines to warn incorrect comment.
8046 Added Documentation field (passed only when /doc was specified).
8048 Added DocComment, DocCommentHeader, GenerateDocComment() and
8049 OnGenerateDocComment() and some supporting private members for
8050 /doc feature to MemberCore.
8052 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
8054 Added overriden DocCommentHeader.
8056 Added overriden DocCommentHeader and GenerateDocComment().
8058 2004-12-01 Miguel de Icaza <miguel@ximian.com>
8060 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
8061 unwrapping the enumeration values, chain to
8062 DoConstantNumericPromotions again, so we can promote things to the
8063 fundamental types (takes care of enums that are bytes, sbytes).
8067 2004-12-01 Raja R Harinath <rharinath@novell.com>
8069 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
8070 Fix long-standing bug in type-lookup. Use FindType instead of
8071 LookupType when ec.ResolvingTypeTree.
8072 (Attribute.ResolveType, Attribute.Resolve)
8073 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
8075 (Attributes.Search): Remove internal version. Update.
8076 (Attributes.SearchMulti): Update.
8077 (Attributes.GetClsCompliantAttribute): Remove.
8078 (Attributes.GetIndexerNameAttribute): Remove.
8079 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
8080 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
8081 * class.cs (Indexer.Define): Likewise.
8083 2004-12-01 Marek Safar <marek.safar@seznam.cz>
8086 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
8087 MarshallByReference members access.
8089 * expression.cs: Use CheckMarshallByRefAccess;
8090 Better error CS0197 message.
8092 * report.cs: Print whole related error message.
8094 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8096 * class (GetClassBases): Better error 60 report.
8097 (EventProperty): Disabled warning 67 detection.
8099 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8102 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
8104 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
8107 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8110 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
8112 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
8114 2004-11-26 Miguel de Icaza <miguel@ximian.com>
8116 * attribute.cs (Attribute.Resolve): Refine error reporting and
8117 report a cs0117 if the identifier does not exist, to distinguish
8118 from 0617 which is a miss-use of the actual identifier.
8120 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
8121 between cs0070 and cs0079.
8123 * class.cs (MemberBase.DoDefine): When reporting a wrong
8124 accessibility level, we use MethodCore to compare instead of
8125 Method (this was a regression in some refactoring effort).
8127 So now we correctly report cs0056 again.
8129 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
8130 testing the target_type (which was known to be object_type) and
8131 not the source type (which is anonymous_method).
8133 Fixed reporting of error cs1660.
8135 * expression.cs (UserCast.Source): Expose the underlying cast.
8137 * statement.cs (Switch.SwitchGoverningType): Sort the list of
8138 allowed types to find a match to int32 first (most common).
8140 In addition, it ignores any ImplicitUserConversions that did an
8141 internal implicit conversion (as the switch statement allows only
8142 one integral conversion to exist).
8144 * class.cs (PartialContainer.Create): rename `name' to
8145 `member_name' for clarity. Then replace the string calls with a
8146 call to MemberName.GetPartialName, as now using
8147 MemberName.ToString is an error (this is due to the side effects
8148 it had, that were fixed in the past).
8150 This will restore the error reporting on a number of partial class
8151 errors that were missusing this (and getting an exception as a
8152 results, which is now just a plain textual warning, because
8153 yyparse debug output would crash otherwise).
8155 2004-11-26 Raja R Harinath <rharinath@novell.com>
8157 * Makefile (PROGRAM_INSTALL_DIR): Remove.
8159 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8161 * rootcontext.cs (LookupType): Make sure to cache lookups that
8162 don't give us a negative result. This saves about 5% of corlib
8165 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8167 * report.cs (AbstractMessage.Print): messages are sent to stderr
8169 * class.cs (TypeContainer.GetClassBases): It is an error to have a
8170 non-interface in the list of interfaces (at this point, either
8171 parent was properly set, or a base class is being listed in the
8172 interfaces section).
8174 This flags error 1722, and resolves the crash from bug 69259.
8176 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8178 * statement.cs (Using.EmitExpressionFinally): make this work right
8179 for valuetypes. Fixes 69926.
8181 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8183 * const.cs (Const.ChangeType): Cope with the "0 literal can be
8184 converted to an enum" here, before we try to change the underlying
8185 type. This code exists, but it is a different code path than the
8186 one used while encoding constants.
8188 (ImplicitReferenceConversionExists): In addition, resynchronized
8189 the code here, so it matches the same code in
8190 ImplicitReferenceConversionExists for the `from any class-type S
8191 to any interface-type T'.
8193 2004-11-25 Marek Safar <marek.safar@seznam.cz>
8195 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
8197 2004-11-24 Miguel de Icaza <miguel@ximian.com>
8199 * cs-parser.jay: Use verbosity accordingly.
8201 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8203 * expression.cs (Unary.ResolveOperator): Do not report warning;
8204 AddressOf reads from variable.
8206 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
8208 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8212 * attribute.cs (Attributable): Removed CheckTargets.
8213 (Attributes.Emit): Explicit attribute targets are tested here.
8215 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
8216 not enabled for interfaces.
8218 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
8219 (GetAssemblyName): Ouch next bug there.
8221 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8223 * expression.cs: Error 275 added.
8225 2004-11-23 Marek Safar <marek.safar@seznam.cz>
8227 Fix bug #69177 (Implemented decimal constant support)
8229 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
8230 (BinaryFold): Add DecimalConstant.
8232 * const.cs (Define): Decimal constant
8234 (ChangeType): Add decimal type handling.
8235 (LookupConstantValue): Don't set value for decimal type but
8236 emit DecimalConstantAttribute. Needed for constant optimization.
8238 * constant.cs (ToDecimal): New method.
8239 (ConvertToDecimal): New method.
8240 (IntConstant): Implemented ConvertToDecimal.
8241 (DecimalConstant.Emit): Emit optimized version for decimals in
8244 * expression.cs (ResolveOperator): Changed order of constant
8245 reduction to work correctly with native types which have
8246 overloaded operators.
8247 (ResolveMemberAccess): Extract constant value from attribute
8250 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
8252 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
8253 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
8254 (ChangeType): Decimal is special.
8255 (TypeToCoreType): Add decimal type.
8257 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8259 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8262 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8264 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8267 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8269 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8271 * pending.cs (PendingImplementation): Grab only interfaces.
8273 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8275 * statement.cs (ForeachHelperMethods): Add location member and
8276 error 202 detection.
8278 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8280 * expression.cs (DoResolveBase): Fixed wrong warning for out
8283 2004-12-04 Martin Baulig <martin@ximian.com>
8285 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8286 to check whether the conversion is ok.
8288 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8289 `Type.EmptyTypes' if we're not a generic TypeContainer.
8291 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8293 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8294 old bug: when converting from the null literal to a pointer,
8295 return an EmptyCast, not the NullLiteral.
8297 This fixes #69921, the recent null_type changes probably made this
8300 2004-12-03 Martin Baulig <martin@ximian.com>
8302 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8303 method as our child, call AnonymousMethod.Compatible() on it.
8305 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8307 * class.cs (FieldBase): Use an unused bit field from the field to
8308 encode the `has_offset' property from the FieldMember. This saves
8309 a couple of Ks on bootstrap compilation.
8311 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8312 method as our child, return the AnonymousMethod resolved
8315 * expression.cs (New.DoResolve): Allow return values from
8316 NewDelegate to also include AnonymousMethods.
8320 2004-11-29 Raja R Harinath <rharinath@novell.com>
8322 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8324 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8325 System.Runtime.InteropServices._Exception, since it's a base
8326 interface of the core type System.Exception in the net_2_0 profile.
8328 2004-11-27 Martin Baulig <martin@ximian.com>
8330 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8332 2004-11-26 Raja R Harinath <rharinath@novell.com>
8334 * Makefile: Convert to use executable.make.
8335 * gmcs.exe.sources: New.
8337 2004-11-25 Martin Baulig <martin@ximian.com>
8339 * expression.cs (Invocation.InferType): Added support for byref types.
8341 2004-11-25 Martin Baulig <martin@ximian.com>
8343 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8344 in TypeManager.TypeToCoreType().
8346 2004-11-25 Martin Baulig <martin@ximian.com>
8348 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8349 "Dispose" method from the `current_type'.
8350 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8351 DoDefineMembers() instead of using the MethodBuilder; this is
8352 required for generic iterators.
8354 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8356 2004-11-24 Martin Baulig <martin@ximian.com>
8358 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8360 2004-11-20 Martin Baulig <martin@ximian.com>
8362 * expression.cs (Invocation.InferType): Correctly infer generic
8363 instances; see gen-103.cs.
8364 (Invocation.InferTypeArguments): If a generic method doesn't have
8365 any unbound type parameters, we don't need to infer anything.
8367 2004-11-19 Raja R Harinath <rharinath@novell.com>
8369 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8371 2004-11-17 Raja R Harinath <rharinath@novell.com>
8373 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8374 (TypeHandle.GetMemberCache): New.
8375 (TypeHandle.TypeHandle): Update.
8376 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8377 (TypeManager.LookupParentInterfacesCache):
8378 Rename from LookupInterfaceCache. Optimize slightly.
8379 (TypeManager.MemberLookup_FindMembers): Update.
8380 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8382 (AddCacheContents): Rename from AddHashtable.
8383 * class.cs (TypeContainer.parent_container): Remove.
8384 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8385 (TypeContainer.DoDefineMembers): Don't initialize it.
8386 Update to name changes.
8388 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8390 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8391 that factors the code to check access modifiers on override.
8393 (PropertyBase): Use the code here.
8395 Patch from Lluis S'anchez, fixes bug #69361.
8397 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8399 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8400 routine that is used to report the use of a captured variable
8401 whose address has been taken.
8403 There are two checks: one when variables are being captured and
8404 the other check is when the address of a variable is taken.
8406 (because an anonymous methods might be resolved before *or* after
8407 the address has been taken) and
8409 * expression.cs (Conditional.DoResolve): Remove the special
8410 casing that Martin added to trueExpr and falseExpr being both
8411 NullLiteral. We get the right behavior now just by introducing
8412 the null_type into the compiler.
8414 * convert.cs (ExplicitConversion): Change the code to use
8415 null_type instead of testing `expr is NullLiteral'.
8416 (ImplicitConversionStandard): use null_type too.
8417 (ImplicitReferenceConversionExists): use null_type too.
8418 (ImplicitReferenceConversion): use null_type too.
8420 * literal.cs: The type of `NullLiteral' is now null_type instead
8422 (Resolve): Set the type here.
8424 * typemanager.cs: Introduce null_type.
8426 2004-11-18 Martin Baulig <martin@ximian.com>
8429 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8431 2004-11-18 Martin Baulig <martin@ximian.com>
8433 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8435 2004-11-18 Martin Baulig <martin@ximian.com>
8437 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8438 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8439 call ResolveConstructedType() on it to resolve it without checking
8441 (Constraints.ResolveTypes): Check them here.
8442 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8443 but don't check constraints.
8444 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8445 check constraints here.
8446 (ConstructedType.ResolveConstructedType): New public method. This
8447 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8448 resolve ourselves without checking constraints.
8450 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8452 2004-11-18 Martin Baulig <martin@ximian.com>
8455 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8457 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8459 2004-11-18 Martin Baulig <martin@ximian.com>
8461 * ecore.cs (TypeExpr.ResolveType): Removed.
8462 (Expression.ResolveAsTypeTerminal): We always return a fully
8463 resolved `TypeExpr', so we can just access its `Type'.
8465 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8467 2004-11-17 Martin Baulig <martin@ximian.com>
8469 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8470 sure we don't return any unresolved TypeExpr's.
8471 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8473 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8475 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8476 unresolved `ConstructedType's.
8478 2004-11-17 Martin Baulig <martin@ximian.com>
8480 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8482 2004-11-17 Martin Baulig <martin@ximian.com>
8485 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8487 * decl.cs (DeclSpace.ResolveType): Removed.
8488 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8490 2004-11-17 Martin Baulig <martin@ximian.com>
8492 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8493 direction, like FindMembers() does. Fixes #69546, testcase is in
8496 2004-11-16 Martin Baulig <martin@ximian.com>
8498 This is based on a patch from Marek Safar, see bug #69082.
8499 Fixes bugs #63705 and #67130.
8501 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8502 method; create a MemberCache for an interface type and cache the
8505 * decl.cs (IMemberContainer.ParentContainer): Removed.
8506 (IMemberContainer.ParentCache): New property.
8507 (MemberCache.SetupCacheForInterface): Removed.
8508 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8509 to create a cache for an interface's "parent".
8511 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8514 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8516 * statement.cs: Avoid adding bools to a hashtable.
8518 2004-11-15 Martin Baulig <martin@ximian.com>
8520 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8522 2004-11-11 Martin Baulig <martin@ximian.com>
8524 * typemanager.cs (TypeManager.GetMethodName): New method.
8526 * class.cs (MethodData.Define): Include the generic arity in the
8527 name of an explicit interface; also add it to the method name.
8529 * pending.cs (PendingImplementation.InterfaceMethod): The method
8530 name now includes the generic arity.
8532 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8534 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8535 calling an unsafe method from a safe location.
8537 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8540 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8542 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8544 * namespace.cs (VerifyUsing): use GetPartialName instead of
8547 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8549 * statement.cs (Return.Resolve): Fix regression in typo: if
8550 `in_exc', we have to request a NeedReturnLabel, this was a typo
8551 introduced in the anonymous method check-in. Fixes #69131.
8553 * Indexers were using the ShortName when defining themselves,
8554 causing a regression in the compiler bootstrap when applying the
8555 patch from 2004-11-02 (first part), now they use their full name
8556 and the bug is gone.
8558 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8560 * driver.cs: Strip the path from the names of embedded resources. Fixes
8563 2004-11-04 Raja R Harinath <rharinath@novell.com>
8565 Fix error message regression: cs0104-2.cs.
8566 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8567 (AliasEntry.Resolve): Update.
8568 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8570 (RootContext.LookupType): Update.
8572 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8574 * cs-parser.jay: Add support for handling accessor modifiers
8575 * class: Add support port accessor modifiers and error checking,
8576 define PropertyMethod.Define as virtual (not abstract anymore)
8577 * ecore.cs: Add checking for proeprties access with access modifiers
8578 * iterators.cs: Modify Accessor constructor call based in the modified
8580 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8582 * expression.cs (StringConcat): Handle being called twice,
8583 as when we have a concat in a field init with more than two
8586 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8588 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8589 special case explicit implementations, we should always produce
8590 the .property or .event declaration.
8592 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8593 since it will not return correct data if people use this
8594 unresolved in the presence of using statements (see test-313).
8596 * class.cs (MethodData.Define): If we are an explicit interface
8597 implementation, set the method name to the full name of the
8598 interface plus the name of the method.
8600 Notice that using the method.MethodName.GetFullName() does not
8601 work, as it will only contain the name as declared on the source
8602 file (it can be a shorthand in the presence of using statements)
8603 and not the fully qualifed type name, for example:
8607 class D : ICloneable {
8608 object ICloneable.Clone () {
8612 Would produce a method called `ICloneable.Clone' instead of
8613 `System.ICloneable.Clone'.
8615 * namespace.cs (Alias.Resolve): Use GetPartialName.
8617 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8619 * cs-parser.jay: Add error 1055 report.
8621 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8623 * assign.cs (Assign.DoResolve): Only do the transform of
8624 assignment into a New if the types are compatible, if not, fall
8625 through and let the implicit code deal with the errors and with
8626 the necessary conversions.
8628 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8630 * cs-parser.jay: Add error 1031 report.
8632 * cs-tokenizer.cs: Add location for error 1038.
8634 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8636 * cs-parser.jay: Add error 1016 report.
8638 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8640 * cs-parser.jay: Add errors 1575,1611 report.
8642 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8644 * cs-parser.jay: Add error 1001 report.
8646 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8649 * attribute.cs (GetMarshal): Add method argument for
8650 caller identification.
8652 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8653 agument for GetMarshal and RuntimeMissingSupport.
8655 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8657 * attribute.cs (ExtractSecurityPermissionSet): Removed
8658 TypeManager.code_access_permission_type.
8660 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8662 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8664 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8665 for obsolete use of a variable here. Fixes regression on errors
8666 cs0619-25 and cs0619-26.
8668 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8670 Fix #62358, implemented security attribute encoding.
8672 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8673 Tests permitted SecurityAction for assembly or other types.
8674 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8675 data from SecurityPermissionAttribute to PermisionSet class.
8677 * class.cs (ApplyAttributeBuilder): Added special handling
8678 for System.Security.Permissions.SecurityAttribute based types.
8680 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8681 special handling for System.Security.Permissions.SecurityAttribute
8684 * enum.cs (ApplyAttributeBuilder): Added special handling
8685 for System.Security.Permissions.SecurityAttribute based types.
8687 * parameter.cs (ApplyAttributeBuilder): Added special handling
8688 for System.Security.Permissions.SecurityAttribute based types.
8690 * rootcontext.cs: Next 2 core types.
8692 * typemanager.cs (TypeManager.security_permission_attr_type):
8693 Built in type for the SecurityPermission Attribute.
8694 (code_access_permission_type): Build in type.
8696 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8698 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8699 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8700 all of this information into
8701 EmitContext.EmitCapturedVariableInstance.
8703 * codegen.cs (EmitCapturedVariableInstance): move here the
8704 funcionality of emitting an ldarg.0 in the presence of a
8705 remapping. This centralizes the instance emit code.
8707 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8708 then emit a load of this: it means that we have reached the
8709 topmost ScopeInfo: the one that contains the pointer to the
8710 instance of the class hosting the anonymous method.
8712 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8713 captures to the topmost CaptureContext.
8715 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8717 * expression.cs (LocalVariableReference): Move the knowledge about
8718 the iterators into codegen's EmitCapturedVariableInstance.
8720 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8722 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8723 all code paths return a value from an anonymous method (it is the
8724 same as the 161 error, but for anonymous methods).
8726 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8728 The introduction of anonymous methods in the compiler changed
8729 various ways of doing things in the compiler. The most
8730 significant one is the hard split between the resolution phase
8731 and the emission phases of the compiler.
8733 For instance, routines that referenced local variables no
8734 longer can safely create temporary variables during the
8735 resolution phase: they must do so from the emission phase,
8736 since the variable might have been "captured", hence access to
8737 it can not be done with the local-variable operations from the runtime.
8741 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8742 is a toplevel block.
8744 (ToplevelBlock): A new kind of Block, these are the blocks that
8745 are created by the parser for all toplevel method bodies. These
8746 include methods, accessors and anonymous methods.
8748 These contain some extra information not found in regular blocks:
8749 A pointer to an optional CaptureContext (for tracking captured
8750 local variables and parameters). A pointer to the parent
8753 (Return.Resolve): Catch missmatches when returning a value from an
8754 anonymous method (error 1662).
8755 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8758 (Break.Resolve): ditto.
8760 (SwitchLabel): instead of defining the labels during the
8761 resolution phase, we now turned the public ILLabel and ILLabelCode
8762 labels into methods called GetILLabelCode() and GetILLabel() that
8763 only define the label during the Emit phase.
8765 (GotoCase): Track the SwitchLabel instead of the computed label
8766 (its contained therein). Emit the code by using
8767 SwitchLabel.GetILLabelCode ().
8769 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8770 whether the Local has been captured or not.
8772 (LocalInfo.IsCaptured): New property, used to tell whether the
8773 local has been captured.
8775 * anonymous.cs: Vastly updated to contain the anonymous method
8778 The main classes here are: CaptureContext which tracks any
8779 captured information for a toplevel block and ScopeInfo used to
8780 track the activation frames for various local variables.
8782 Each toplevel block has an optional capture context associated
8783 with it. When a method contains an anonymous method both the
8784 toplevel method and the anonymous method will create a capture
8785 context. When variables or parameters are captured, they are
8786 recorded on the CaptureContext that owns them, for example:
8790 MyDelegate d = delegate {
8795 Here `a' will be recorded as captured on the toplevel
8796 CapturedContext, the inner captured context will not have anything
8797 (it will only have data if local variables or parameters from it
8798 are captured in a nested anonymous method.
8800 The ScopeInfo is used to track the activation frames for local
8801 variables, for example:
8803 for (int i = 0; i < 10; i++)
8804 for (int j = 0; j < 10; j++){
8805 MyDelegate d = delegate {
8810 At runtime this captures a single captured variable `i', but it
8811 captures 10 different versions of the variable `j'. The variable
8812 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8813 recorded on a child.
8815 The toplevel ScopeInfo will also track information like the `this'
8816 pointer if instance variables were referenced (this is necessary
8817 as the anonymous method lives inside a nested class in the host
8818 type of the method).
8820 (AnonymousMethod): Expanded to track the Toplevel, implement
8821 `AnonymousMethod.Compatible' to tell whether an anonymous method
8822 can be converted to a target delegate type.
8824 The routine now also produces the anonymous method content
8826 (AnonymousDelegate): A helper class that derives from
8827 DelegateCreation, this is used to generate the code necessary to
8828 produce the delegate for the anonymous method that was created.
8830 * assign.cs: API adjustments for new changes in
8831 Convert.ImplicitStandardConversionExists.
8833 * class.cs: Adjustments to cope with the fact that now toplevel
8834 blocks are of type `ToplevelBlock'.
8836 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8837 insteda of standard blocks.
8839 Flag errors if params arguments are passed to anonymous methods.
8841 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8842 `CurrentAnonymousMethod' which points to the current Anonymous
8843 Method. The variable points to the AnonymousMethod class that
8844 holds the code being compiled. It is set in the new EmitContext
8845 created for the anonymous method.
8847 (EmitContext.Phase): Introduce a variable and an enumeration to
8848 assist in enforcing some rules about when and where we are allowed
8849 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8850 only one that enfonces this right now).
8852 (EmitContext.HaveCaptureInfo): new helper method that returns
8853 whether we have a CapturedContext initialized.
8855 (EmitContext.CaptureVariable): New method used to register that a
8856 LocalInfo must be flagged for capturing.
8858 (EmitContext.CapturedParameter): New method used to register that a
8859 parameters must be flagged for capturing.
8861 (EmitContext.CapturedField): New method used to register that a
8862 field must be flagged for capturing.
8864 (EmitContext.HaveCapturedVariables,
8865 EmitContext.HaveCapturedFields): Return whether there are captured
8866 variables or fields.
8868 (EmitContext.EmitMethodHostInstance): This is used to emit the
8869 instance for the anonymous method. The instance might be null
8870 (static methods), this (for anonymous methods that capture nothing
8871 and happen to live side-by-side with the current method body) or a
8872 more complicated expression if the method has a CaptureContext.
8874 (EmitContext.EmitTopBlock): Routine that drives the emission of
8875 code: it will first resolve the top block, then emit any metadata
8876 and then emit the code. The split is done so that we can extract
8877 any anonymous methods and flag any captured variables/parameters.
8879 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
8880 during this phase, the ILGenerator should not be used as labels
8881 and local variables declared here might not be accessible to any
8882 code that is part of an anonymous method.
8884 Exceptions to this include the temporary variables that are
8885 created by some statements internally for holding temporary
8888 (EmitContext.EmitMeta): New routine, in charge of emitting all the
8891 (EmitContext.TemporaryReturn): This method is typically called
8892 from the Emit phase, and its the only place where we allow the
8893 ReturnLabel to be defined other than the EmitMeta. The reason is
8894 that otherwise we would have to duplicate a lot of logic in the
8895 Resolve phases of various methods that today is on the Emit
8898 (EmitContext.NeedReturnLabel): This no longer creates the label,
8899 as the ILGenerator is not valid during the resolve phase.
8901 (EmitContext.EmitThis): Extended the knowledge in this class to
8902 work in anonymous methods in addition to iterators.
8904 (EmitContext.EmitCapturedVariableInstance): This emits whatever
8905 code is necessary on the stack to access the instance to a local
8906 variable (the variable will be accessed as a field).
8908 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
8909 EmitContext.EmitAddressOfParameter): Routines to support
8910 parameters (not completed at this point).
8912 Removals: Removed RemapLocal and RemapLocalLValue. We probably
8913 will also remove the parameters.
8915 * convert.cs (Convert): Define a `ConstantEC' which points to a
8916 null. This is just to prefity some code that uses
8917 ImplicitStandardConversion code and do not have an EmitContext
8920 The idea is to flag explicitly that at that point in time, it is
8921 known that the conversion will not trigger the delegate checking
8922 code in implicit conversions (which requires a valid
8925 Everywhere: pass new EmitContext parameter since
8926 ImplicitStandardConversionExists now requires it to check for
8927 anonymous method conversions.
8929 (Convert.ImplicitStandardConversionExists): If the type of an
8930 expression is the anonymous_method_type, and the type is a
8931 delegate, we invoke the AnonymousMethod.Compatible method to check
8932 whether an implicit conversion is possible.
8934 (Convert.ImplicitConversionStandard): Only do implicit method
8935 group conversions if the language level is not ISO_1.
8937 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
8938 MethodInfo for the Invoke method. used by Delegate and
8941 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
8942 method conversions if the target type is a delegate.
8944 Removed extra debugging nops.
8946 (LocalVariableReference): Turn the `local_info' into a public
8949 Add `prepared' field, the same hack used for FieldExprs to cope
8950 with composed assignments, as Local variables do not necessarily
8951 operate purely on the stack as they used to: they can be captured
8954 Add `temp' for a temporary result, like fields.
8956 Refactor DoResolve and DoResolveLValue into DoResolveBase.
8958 It now copes with Local variables that are captured and emits the
8959 proper instance variable to load it from a field in the captured
8962 (ParameterReference.DoResolveBase): During the resolve phase,
8963 capture parameters if we are in an anonymous method.
8965 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
8966 anonymous method, use the EmitContext helper routines to emit the
8967 parameter reference.
8969 * iterators.cs: Set RemapToProxy to true/false during the
8972 * parameters.cs (GetParameterByName): New helper method.
8974 * typemanager.cs (anonymous_method_type) a new type that
8975 represents an anonyous method. This is always an internal type,
8976 used as a fencepost to test against the anonymous-methodness of an
8979 2004-10-20 Marek Safar <marek.safar@seznam.cz>
8981 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
8983 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
8985 2004-11-10 Martin Baulig <martin@ximian.com>
8987 * expression.cs (Invocation.BetterFunction): If two methods have
8988 equal parameter types, but only one of them is generic, the
8989 non-generic one wins.
8990 (New.DoResolve): Don't set `is_struct' to false if we're a generic
8991 instance; just use `Type.IsValueType' to determine whether
8992 something is a struct or not.
8993 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
8994 so we can be called multiple times.
8996 2004-11-10 Martin Baulig <martin@ximian.com>
8998 * generic.cs (TypeParameter.DefineConstraints): New public method.
8999 (TypeParameter.CheckAccessLevel): Override this and return true.
9000 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
9001 override ResolveType() anymore.
9002 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
9004 2004-11-10 Martin Baulig <martin@ximian.com>
9006 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
9007 call DeclSpace.ResolveNestedType() on it.
9009 2004-11-10 Martin Baulig <martin@ximian.com>
9011 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
9012 non-null, call ParameterModifier() on it.
9014 2004-11-10 Martin Baulig <martin@ximian.com>
9017 (Iterators): Added `current_type' and `this_type' fields.
9018 (Iterators.DefineIterator): Create a new EmitContext and store it
9019 in `ec'; compute `this_type'.
9021 2004-11-10 Martin Baulig <martin@ximian.com>
9024 (TypeManager.IsPrivateAccessible): New public method.
9025 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
9027 2004-11-10 Martin Baulig <martin@ximian.com>
9029 * class.cs (TypeContainer.DefineType): Call
9030 TypeBuilder.DefineGenericParameters() before resolving the type
9032 (MethodData.parent_method): New protected field.
9033 (MethodData..ctor): Added `MethodInfo parent_method' argument.
9034 (MethodData.Define): Compute `parent_method'.
9037 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
9038 (MemberCore.GetClsCompliantAttributeValue): Likewise.
9039 (DeclSpace.ec): New protected field; store the EmitContext here.
9040 (DeclSpace.EmitContext): New public property.
9041 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
9042 (DeclSpace.ResolveNestedType): New public method.
9043 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
9044 (DeclSpace.NestedAccessible): Added `Type tb' argument.
9045 (DeclSpace.FamilyAccessible): Likewise.
9046 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
9047 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
9050 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
9053 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
9054 (Enum.Emit): Don't create a new EmitContext.
9056 2004-10-18 Martin Baulig <martin@ximian.com>
9058 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
9059 `Type' directly, but call ResolveType() on it.
9060 (Catch.Resolve): Likewise.
9061 (Foreach.Resolve): Likewise.
9063 2004-10-18 Martin Baulig <martin@ximian.com>
9065 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
9066 `Type' directly, but call ResolveType() on it.
9067 (Probe.DoResolve): Likewise.
9068 (ArrayCreation.LookupType): Likewise.
9069 (TypeOf.DoResolve): Likewise.
9070 (SizeOf.DoResolve): Likewise.
9072 2004-10-18 Raja R Harinath <rharinath@novell.com>
9074 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
9077 2004-10-17 John Luke <john.luke@gmail.com>
9079 * class.cs (Operator.GetSignatureForError): use CSharpName
9081 * parameter.cs (Parameter.GetSignatureForError): Returns
9082 correct name even if was not defined.
9084 2004-10-13 Raja R Harinath <rharinath@novell.com>
9087 * class.cs (TypeContainer.EmitContext): New property.
9088 (DefineNestedTypes): Create an emitcontext for each part.
9089 (MethodCore.DoDefineParameters): Use container's emitcontext.
9090 Pass type array to InternalParameters.
9091 (MemberBase.DoDefine): Use container's emitcontext.
9092 (FieldMember.Define): Likewise.
9093 (Event.Define): Likewise.
9094 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9095 Pass type array to InternalParameters.
9096 (SetIndexerMethod.GetParameterInfo): Likewise.
9097 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9098 * delegate.cs (Define): Pass emitcontext to
9099 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9100 array to InternalParameters.
9101 * expression.cs (ParameterReference.DoResolveBase): Pass
9102 emitcontext to GetParameterInfo.
9103 (ComposedCast.DoResolveAsTypeStep): Remove check on
9104 ec.ResolvingTypeTree.
9105 * parameter.cs (Parameter.Resolve): Change argument to
9106 EmitContext. Use ResolveAsTypeTerminal.
9107 (Parameter.GetSignature): Change argument to EmitContext.
9108 (Parameters.ComputeSignature): Likewise.
9109 (Parameters.ComputeParameterTypes): Likewise.
9110 (Parameters.GetParameterInfo): Likewise.
9111 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9112 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9113 * support.cs (InternalParameters..ctor): Remove variant that takes
9115 * typemanager.cs (system_intptr_expr): New.
9116 (InitExpressionTypes): Initialize it.
9118 2004-10-12 Chris Toshok <toshok@ximian.com>
9120 * cs-parser.jay: fix location for try_statement and catch_clause.
9122 2004-10-18 Martin Baulig <martin@ximian.com>
9124 * class.cs (FieldMember.Define): Don't access the TypeExpr's
9125 `Type' directly, but call ResolveType() on it.
9126 (MemberBase.DoDefine): Likewise.
9128 * expression.cs (New.DoResolve): Don't access the TypeExpr's
9129 `Type' directly, but call ResolveType() on it.
9130 (ComposedCast.DoResolveAsTypeStep): Likewise.
9132 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
9133 `Type' directly, but call ResolveType() on it.
9135 2004-10-17 John Luke <john.luke@gmail.com>
9137 * class.cs (Operator.GetSignatureForError): use CSharpName
9139 * parameter.cs (Parameter.GetSignatureForError): Returns
9140 correct name even if was not defined.
9142 2004-10-13 Raja R Harinath <rharinath@novell.com>
9145 * class.cs (TypeContainer.EmitContext): New property.
9146 (DefineNestedTypes): Create an emitcontext for each part.
9147 (MethodCore.DoDefineParameters): Use container's emitcontext.
9148 Pass type array to InternalParameters.
9149 (MemberBase.DoDefine): Use container's emitcontext.
9150 (FieldMember.Define): Likewise.
9151 (Event.Define): Likewise.
9152 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9153 Pass type array to InternalParameters.
9154 (SetIndexerMethod.GetParameterInfo): Likewise.
9155 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9156 * delegate.cs (Define): Pass emitcontext to
9157 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9158 array to InternalParameters.
9159 * expression.cs (ParameterReference.DoResolveBase): Pass
9160 emitcontext to GetParameterInfo.
9161 (ComposedCast.DoResolveAsTypeStep): Remove check on
9162 ec.ResolvingTypeTree.
9163 * parameter.cs (Parameter.Resolve): Change argument to
9164 EmitContext. Use ResolveAsTypeTerminal.
9165 (Parameter.GetSignature): Change argument to EmitContext.
9166 (Parameters.ComputeSignature): Likewise.
9167 (Parameters.ComputeParameterTypes): Likewise.
9168 (Parameters.GetParameterInfo): Likewise.
9169 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9170 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9171 * support.cs (InternalParameters..ctor): Remove variant that takes
9173 * typemanager.cs (system_intptr_expr): New.
9174 (InitExpressionTypes): Initialize it.
9176 2004-10-12 Chris Toshok <toshok@ximian.com>
9178 * cs-parser.jay: fix location for try_statement and catch_clause.
9180 2004-10-07 Raja R Harinath <rharinath@novell.com>
9182 More DeclSpace.ResolveType avoidance.
9183 * decl.cs (MemberCore.InUnsafe): New property.
9184 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
9185 with newly created EmitContext.
9186 (FieldMember.Define): Likewise.
9187 * delegate.cs (Delegate.Define): Likewise.
9188 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
9189 only if normal name-lookup fails.
9190 (TypeExpr.DoResolve): Enable error-checking.
9191 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
9192 (SizeOf.DoResolve): Likewise.
9193 (ComposedCast.DoResolveAsTypeStep): Likewise.
9194 (StackAlloc.DoResolve): Likewise.
9195 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
9196 (Block.Unsafe): New property.
9197 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
9198 (Unsafe): Set 'unsafe' flag of contained block.
9199 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
9200 (Fixed.Resolve): Likewise.
9201 (Catch.Resolve): Likewise.
9202 (Using.ResolveLocalVariableDecls): Likewise.
9203 (Foreach.Resolve): Likewise.
9205 2004-10-05 John Luke <john.luke@gmail.com>
9207 * cs-parser.jay: add location to error CS0175
9209 2004-10-04 Miguel de Icaza <miguel@ximian.com>
9211 * ecore.cs (Expression.Constantity): Add support for turning null
9214 * const.cs (Const.Define): Allow constants to be reference types
9215 as long as the value is Null.
9217 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
9219 * namespace.cs (NamespaceEntry.Using): No matter which warning
9220 level is set, check if this namespace name has already been added.
9222 2004-10-03 Ben Maurer <bmaurer@ximian.com>
9224 * expression.cs: reftype [!=]= null should always use br[true,false].
9227 2004-10-03 Marek Safar <marek.safar@seznam.cz>
9230 * attribute.cs: Enum conversion moved to
9231 GetAttributeArgumentExpression to be applied to the all
9234 2004-10-01 Raja R Harinath <rharinath@novell.com>
9236 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
9237 * class.c (TypeContainer.DefineType): Flag error if
9238 base types aren't accessible due to access permissions.
9239 * decl.cs (DeclSpace.ResolveType): Move logic to
9240 Expression.ResolveAsTypeTerminal.
9241 (DeclSpace.ResolveTypeExpr): Thin layer over
9242 Expression.ResolveAsTypeTerminal.
9243 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
9244 Refactor code into NestedAccess. Use it.
9245 (DeclSpace.NestedAccess): New.
9246 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
9247 argument to silence errors. Check access permissions.
9248 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
9249 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
9250 (Cast.DoResolve): Likewise.
9251 (New.DoResolve): Likewise.
9252 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
9253 (TypeOf.DoResolve): Likewise.
9255 * expression.cs (Invocation.BetterConversion): Return the Type of
9256 the better conversion. Implement section 14.4.2.3 more faithfully.
9257 (Invocation.BetterFunction): Make boolean. Make correspondence to
9258 section 14.4.2.2 explicit.
9259 (Invocation.OverloadResolve): Update.
9260 (Invocation): Remove is_base field.
9261 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9262 (Invocation.Emit): Likewise.
9264 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9266 * cs-parser.jay: Reverted 642 warning fix.
9268 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9271 * decl.cs (FindMemberWithSameName): Indexer can have more than
9274 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9276 * expression.cs (LocalVariableReference.DoResolveLValue):
9277 Do not report warning 219 for out values.
9278 (EmptyExpression.Null): New member to avoid extra allocations.
9280 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9282 * cs-parser.jay: Fix wrong warning 642 report.
9284 * cs-tokenizer.cs (CheckNextToken): New helper;
9285 Inspect next character if is same as expected.
9287 2004-09-23 Martin Baulig <martin@ximian.com>
9289 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9290 (Convert.ImplicitReferenceConversionExists): Likewise.
9292 2004-11-09 Raja R Harinath <rharinath@novell.com>
9294 * Makefile (DISTFILES): Comment out a few missing files.
9296 2004-10-29 Raja R Harinath <rharinath@novell.com>
9298 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9299 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9300 (gmcs.exe): Invoke bootstrap-libs.
9301 (clean-local): Clean the net_2_0_bootstrap profile too.
9302 (PROGRAM_INSTALL_DIR): New.
9303 (install-local): Use it.
9305 2004-10-13 Martin Baulig <martin@ximian.com>
9307 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9308 (TypeParameter.DefineType): If we're a method type parameter and
9309 that method is overriding something, "inflate" its constraints.
9311 2004-10-12 Martin Baulig <martin@ximian.com>
9313 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9314 and have type arguments, create and resolve a ConstructedType.
9316 2004-10-12 Martin Baulig <martin@ximian.com>
9318 * decl.cs (MemberCache.FindMemberToOverride): Use
9319 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9320 to compare the invocationType.
9322 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9323 When comparing two type parameters, only do the signature-only
9324 comparision for method type parameters.
9326 2004-10-11 Martin Baulig <martin@ximian.com>
9328 * report.cs: Don't make --fatal abort on warnings, we have
9329 -warnaserror for that.
9331 2004-10-11 Martin Baulig <martin@ximian.com>
9334 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9335 (TypeManager.IsEqual): Call ourself recursively instead of using
9338 2004-10-11 Martin Baulig <martin@ximian.com>
9340 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9341 on our own type parameters, not on the ones we inherit from a containing
9344 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9347 * generic.cs (TypeParameter.Define): We may only be called once.
9349 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9350 instead of TypeManager.IsEqual().
9352 2004-09-28 Martin Baulig <martin@ximian.com>
9355 (GenericConstraints.EffectiveBaseClass): New public property.
9356 (TypeParameter.GenericConstraints): New public property.
9357 (ConstructedType.CheckConstraints): Improved.
9359 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9360 (Convert.TypeParameterConversion): New private method; use this in
9361 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9362 for all conversions related to type parameters.
9364 2004-09-24 Martin Baulig <martin@ximian.com>
9366 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9367 type parameter conversions for type parameters which are known to
9370 2004-09-24 Martin Baulig <martin@ximian.com>
9372 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9373 `IsValueType' properties.
9375 * support.cs (ReflectionConstraints): Use
9376 Type.GetGenericParameterConstraints() instead of the old hack.
9378 2004-09-24 Martin Baulig <martin@ximian.com>
9380 * generic.cs (GenericConstraints): Moved here and made it an
9383 * support.cs (GenericConstraints): Moved to generic.cs.
9385 2004-09-24 Martin Baulig <martin@ximian.com>
9388 (ReflectionConstraints): Un-nested this class and made it public.
9391 (TypeManager.GetTypeParameterConstraints): New public method.
9392 (TypeManager.HasConstructorConstraint): Use the attributes.
9394 2004-09-24 Martin Baulig <martin@ximian.com>
9396 * support.cs (GenericConstraints): Replaced `HasConstructor',
9397 `IsReferenceType' and `IsValueType' with `Attributes'.
9398 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9399 method and made the .ctor public.
9401 * generic.cs (Constraints.Attributes): New public property.
9402 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9403 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9404 `IsValueType' -> `HasValueTypeConstraint'.
9406 2004-09-23 Martin Baulig <martin@ximian.com>
9408 * generic.cs (Constraints): Reflect latest runtime changes.
9410 2004-09-23 Martin Baulig <martin@ximian.com>
9412 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9413 (Convert.ImplicitReferenceConversionExists): Likewise.
9415 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9417 * class.cs (Operator.Define): Add error 448 and 559 report.
9419 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9421 * class.cs (MemberBase.IsTypePermitted): New protected
9422 method for checking error CS0610.
9424 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9426 * class.cs (TypeContainer.HasExplicitLayout): New property
9427 Returns whether container has StructLayout attribute set Explicit.
9428 (FieldMember): New abstract class for consts and fields.
9429 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9430 (Field): Reuse FieldMember.
9432 * const.cs (Const): Reuse FieldMember.
9434 * rootcontext.cs: EmitConstants call moved to class.
9436 2004-09-22 Martin Baulig <martin@ximian.com>
9438 Marek and me just fixed one of our oldest bugs: #28562 :-)
9440 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9442 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9443 we're an EnumConstant, just return that.
9444 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9445 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9446 to get the value which'll actually be written into the attribute.
9447 However, we have to use GetValue() to access the attribute's value
9450 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9452 * constant.cs (Constant.IsNegative): New abstract property
9455 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9456 (StackAlloc.DoResolve): Reused IsNegative.
9458 2004-09-22 Martin Baulig <martin@ximian.com>
9460 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9461 public method; like LookupTypeContainer, but also works for
9464 * report.cs (Report.SymbolRelatedToPreviousError): Use
9465 TypeManager.LookupGenericTypeContainer().
9467 2004-09-22 Martin Baulig <martin@ximian.com>
9469 Thanks to Peter Sestoft for this bug report.
9471 * expression.cs (Conditional): If both the `trueExpr' and the
9472 `falseExpr' is a NullLiteral, return a NullLiteral.
9474 2004-09-22 Martin Baulig <martin@ximian.com>
9476 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9477 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9478 for the "get_Current" call.
9480 2004-09-21 Martin Baulig <martin@ximian.com>
9482 * convert.cs (Convert.ImplicitReferenceConversion): When
9483 converting to an interface type, first check whether we're
9484 converting from a reference type.
9486 2004-09-14 Martin Baulig <martin@ximian.com>
9488 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9490 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9493 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9494 called and is obsolete then this member suppress message
9495 when call is inside next [Obsolete] method or type.
9497 * expression.cs: Use TestObsoleteMethodUsage member.
9499 2004-09-14 Martin Baulig <martin@ximian.com>
9501 * genericparser.cs: Removed.
9503 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9505 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9507 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9509 * attribute.cs (Attribute.Resolve): Add error 653 report.
9511 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9513 (Method.ApplyAttributeBuilder): Add error 685 report.
9514 (Operator.Define): Add error 564 report.
9516 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9518 * expression.cs (Invocation.DoResolve): Add error
9521 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9524 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9526 * class.cs (ConstructorInitializer.Resolve):
9527 Wrong error number (515->516).
9529 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9531 * class.cs (Indexer.Define): Add error 631 report.
9533 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9535 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9537 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9539 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9541 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9543 * cs-parser.jay: Added error CS0241 report.
9545 2004-09-10 Raja R Harinath <rharinath@novell.com>
9547 * cs-parser.jay (fixed_statement): Introduce a scope for the
9548 declaration in the 'fixed' statement.
9550 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9552 * cs-parser.jay: Added CS0230 error report.
9554 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9556 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9558 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9560 * expression.cs (Argument.Resolve): Added error CS0192 and
9563 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9565 C# 2.0 #pragma warning feature
9567 * cs-tokenizer.cs (PreProcessPragma): New method;
9568 Handles #pragma directive.
9570 * report.cs (WarningRegions): New class; Support
9571 class for #pragma warning directive. It tests whether
9572 warning is enabled for a given line.
9574 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9576 * const.cs: Add more descriptive error report, tahnks to
9579 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9581 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9583 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9585 * expression.cs: Apply patch from Ben: Remove dead code from
9586 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9587 as that code just threw an exception anwyays.
9589 * const.cs: Remove the call to the turnintoconstant, for details
9592 * literal.cs: The type of the null-literal is the null type; So
9593 we use a placeholder type (literal.cs:System.Null, defined here)
9596 * expression.cs (Conditional.DoResolve): Remove some old code that
9597 is no longer needed, conversions have been fixed.
9599 (ArrayCreationExpression.DoResolve): Return false if we fail to
9600 resolve the inner expression.
9602 2004-09-07 Raja R Harinath <rharinath@novell.com>
9605 * cs-parser.jay (delegate_declaration): Record a delegate
9606 declaration as a type declaration.
9607 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9609 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9611 * parameter.cs: Do not crash if the type can not be resolved.
9613 * expression.cs: Report errors with unsafe pointers, fixes #64896
9615 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9617 * expression.cs: Pointer arith always needs to do a conv.i
9618 if the operand is a long. fix 65320
9620 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9622 Fixed cs0619-37.cs, cs0619-38.cs
9624 * enum.cs (GetObsoleteAttribute): Removed.
9626 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9627 on Enum member is double staged. The first is tested member
9630 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9632 Fixed #56986, #63631, #65231
9634 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9635 adds member to name container.
9636 (TypeContainer.AddToTypeContainer): New method, adds type to
9638 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9639 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9640 AddOperator): Simplified by reusing AddToMemberContainer.
9641 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9643 (Method.CheckForDuplications): Fixed implementation to test all
9645 (MemberBase): Detection whether member is explicit interface
9646 implementation is now in constructor.
9647 (MemberBase.UpdateMemberName): Handles IndexerName.
9648 (Accessor): Changed to keep also location information.
9649 (AbstractPropertyEventMethod): Is derived from MemberCore.
9650 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9651 will be emited or not.
9652 (PropertyBase.AreAccessorsDuplicateImplementation):
9653 Tests whether accessors are not in collision with some method.
9654 (Operator): Is derived from MethodCore to simplify common
9657 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9659 (DeclSpace.AddToContainer): Adds the member to defined_names
9660 table. It tests for duplications and enclosing name conflicts.
9662 * enum.cs (EnumMember): Clean up to reuse the base structures
9664 2004-09-03 Martin Baulig <martin@ximian.com>
9666 Merged latest changes into gmcs. Please keep this comment in
9667 here, it makes it easier for me to see what changed in MCS since
9668 the last time I merged.
9670 2004-09-03 Martin Baulig <martin@ximian.com>
9672 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9673 into TypeContainer, to make partial classes work again.
9675 2004-09-03 Martin Baulig <martin@ximian.com>
9677 * rootcontext.cs (RootContext.V2): Removed.
9679 2004-03-23 Martin Baulig <martin@ximian.com>
9681 * expression.cs (Invocation.OverloadResolve): Added `bool
9682 may_fail' argument and use it instead of the Location.IsNull() hack.
9684 2004-09-09 Martin Baulig <martin@ximian.com>
9686 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9688 2004-09-09 Martin Baulig <martin@ximian.com>
9690 * generic.cs (TypeParameter.DefineType): Added support for
9691 explicit interface methods.
9693 2004-09-09 Martin Baulig <martin@ximian.com>
9695 * README.Changes: New document. Started to list important changes
9696 between MCS and GMCS here.
9698 2004-09-08 Martin Baulig <martin@ximian.com>
9701 (TypeContainer.CheckRecursiveDefinition): New protected method.
9702 (TypeContainer.DefineType): Move the CS0146 check into
9703 CheckRecursiveDefinition().
9705 2004-09-06 Martin Baulig <martin@ximian.com>
9707 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9708 types for the constructor constraint.
9710 2004-09-03 Martin Baulig <martin@ximian.com>
9712 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9713 into TypeContainer, to make partial classes work again.
9715 2004-09-03 Martin Baulig <martin@ximian.com>
9717 * rootcontext.cs (RootContext.V2): Removed.
9719 2004-03-23 Martin Baulig <martin@ximian.com>
9721 * expression.cs (Invocation.OverloadResolve): Added `bool
9722 may_fail' argument and use it instead of the Location.IsNull() hack.
9724 2004-09-03 Martin Baulig <martin@ximian.com>
9726 Merged latest changes into gmcs. Please keep this comment in
9727 here, it makes it easier for me to see what changed in MCS since
9728 the last time I merged.
9730 2004-09-03 Raja R Harinath <rharinath@novell.com>
9733 * expression.cs (BetterConversion): Don't allow either conversion
9734 to be null. Remove redundant implicit conversion test when 'q ==
9735 null' -- when this function is invoked, we already know that the
9736 implicit conversion exists.
9737 (BetterFunction): Assume that 'best' is non-null. Remove
9738 redundant reimplementation of IsApplicable when 'best' is null.
9739 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9740 number of arguments.
9741 (IsAncestralType): Extract from OverloadResolve.
9742 (OverloadResolve): Make robust to the MethodGroupExpr being
9743 unsorted. Implement all the logic of Section 14.5.5.1, and
9744 support overloading of methods from multiple applicable types.
9745 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9747 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9748 (RealError, Warning): Append type of report to related symbol.
9750 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9752 * enum.cs: Fixed CLS-Compliance checks for enum members.
9753 Error tests cs3008-8.cs, cs3014-8.cs
9755 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9757 Fixed bug #62342, #63102
9758 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9759 like ImplementMethod.
9761 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9763 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9766 2004-09-02 Martin Baulig <martin@ximian.com>
9768 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9769 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9772 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9774 C# 2.0 Static classes implemented
9776 * class.cs (TypeContainer): instance_constructors,
9777 initialized_fields, initialized_static_fields,
9778 default_constructor, base_inteface_types are protected to be
9779 accessible from StaticClass.
9780 (TypeContainer.DefineDefaultConstructor): New virtual method
9781 for custom default constructor generating
9782 (StaticClass): New class to handle "Static classes" feature.
9784 * cs-parser.jay: Handle static keyword on class like instance
9787 * driver.cs: Added "/langversion" command line switch with two
9788 options (iso-1, default).
9790 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9792 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9794 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9796 * delegate.cs: Style.
9798 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9800 * delegate.cs: Add seperate instance expr field for miguel.
9802 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9804 * PointerArithmetic (Resolve): make sure we are not doing
9805 pointer arith on void*. Also, make sure we are resolved
9806 by not setting eclass until resolve.
9808 All callers: Make sure that PointerArithmetic gets resolved.
9810 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9812 * ArrayCreation (LookupType): If the type does not resolve
9813 to an array, give an error.
9815 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9817 * statement.cs (Try.Resolve): Fixed bug #64222
9819 2004-08-27 Martin Baulig <martin@ximian.com>
9822 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9825 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9827 * ecore.cs (Constantify): Get underlying type via
9828 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9829 Windows in special cases.
9831 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9833 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9834 for obtaining also private methods.
9835 (GetRemoveMethod): Used GetRemoveMethod (true)
9836 for obtaining also private methods.
9838 2004-09-02 Martin Baulig <martin@ximian.com>
9840 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9841 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9844 2004-08-27 Martin Baulig <martin@ximian.com>
9847 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9850 2004-08-25 Martin Baulig <martin@ximian.com>
9852 * support.cs (ReflectionParameters..ctor): If this is a generic
9853 method, retrieve and store its type parameters.
9854 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9855 (ReflectionParameters.GenericConstraints): The argument specifies
9856 the type parameter, not the method parameter.
9857 (InternalParameters.GenericConstraints): Likewise.
9859 * generic.cs (TypeParameter.DefineType): Correctly handle
9860 constraints wrt. generic methods in interfaces and their
9863 2004-08-24 Martin Baulig <martin@ximian.com>
9865 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9866 (Constraints.IsSubclassOf): New internal method.
9868 * typemanager.cs (TypeManager.FindMembers): Added special support
9869 for GenericTypeParameterBuilder's.
9870 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
9873 2004-08-24 Martin Baulig <martin@ximian.com>
9876 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
9877 this for accessibility checks.
9878 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
9879 IsNestedFamilyAccessible.
9880 (TypeManager.IsSubclassOf): New method, do what the name actually
9883 2004-08-24 Martin Baulig <martin@ximian.com>
9885 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
9886 as a SimpleName, include the generic arity.
9888 2004-08-24 Martin Baulig <martin@ximian.com>
9890 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
9891 MethodAttributes.HideBySig for operators.
9893 2004-08-23 Martin Baulig <martin@ximian.com>
9895 Back to the old error reporting system :-)
9897 * report.cs (Message): Removed.
9898 (Report.MessageData, ErrorData, WarningData): Removed.
9899 (Report.Error, Warning): Back to the old system.
9901 2004-08-23 Martin Baulig <martin@ximian.com>
9903 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
9905 * class.cs (TypeContainer.ParentContainer): New public virtual
9906 method; replaces the explicit interface implementation.
9907 (ClassPart.ParentContainer): Override.
9909 2004-08-23 Martin Baulig <martin@ximian.com>
9911 * statement.cs (Switch): Added support for constant switches; see
9912 #59428 or test-285.cs.
9914 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9917 * statement.cs (GetEnumeratorFilter): Removed useless
9918 logic because C# specs is strict. GetEnumerator must be
9921 2004-08-22 Martin Baulig <martin@ximian.com>
9923 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9924 a switch and may break, reset the barrier. Fixes #59867.
9926 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9928 CLS-Compliance speed up (~5% for corlib)
9930 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
9931 New method. Tests container for CLS-Compliant names
9933 * class.cs (TypeContainer.VerifyClsName): New method.
9934 Checks whether container name is CLS Compliant.
9935 (Constructor): Implements IMethodData.
9937 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
9938 low-case table for CLS Compliance test.
9939 (MemberCache.VerifyClsParameterConflict): New method.
9940 Checks method parameters for CS3006 error.
9942 * enum.cs (EnumMember): Is derived from MemberCore.
9943 (Enum.VerifyClsName): Optimized for better performance.
9945 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9947 * report.cs: Renamed Error_T to Error and changed all
9950 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9952 * class.cs (TypeContainer.IndexerArrayList): New inner class
9953 container for indexers.
9954 (TypeContainer.DefaultIndexerName): New constant for default
9955 indexer name. Replaced all "Item" with this constant.
9956 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
9958 * typemanager.cs (TypeManager.default_member_ctor): Cache here
9959 DefaultMemberAttribute constructor.
9961 2004-08-05 Martin Baulig <martin@ximian.com>
9963 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9966 2004-08-05 Marek Safar <marek.safar@seznam.cz>
9968 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
9969 multi platforms problem.
9971 * compiler.csproj: Included shared files.
9973 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9975 Fix bug 60333, 55971 in the more general way
9976 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9977 Added arg_type argument for constant conversion.
9978 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
9980 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9983 * class.cs (TypeContainer ): New inner classes MethodArrayList,
9984 OperatorArrayList, MethodCoreArrayList for typecontainer
9985 containers. Changed class member types to these new types.
9986 (MethodArrayList.DefineMembers): Added test for CS0659.
9988 2004-08-04 Miguel de Icaza <miguel@ximian.com>
9990 * cfold.cs: Synchronize the folding with the code in expression.cs
9991 Binary.DoNumericPromotions for uint operands.
9993 * attribute.cs: Revert patch from Raja, it introduced a regression
9994 while building Blam-1.2.1 (hard to isolate a test case).
9996 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10000 (TypeContainer.Define): Renamed to DefineContainerMembers because of
10002 (MethodCore.parent_method): New member. The method we're overriding
10003 if this is an override method.
10004 (MethodCore.CheckBase): Moved from Method class and made common.
10005 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
10007 (MethodCore.CheckForDuplications): New abstract method. For custom
10008 member duplication search in a container
10009 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
10010 method and its return type.
10011 (Event.conflict_symbol): New member. Symbol with same name in the
10015 (MemberCache.FindMemberWithSameName): New method. The method
10016 is looking for conflict with inherited symbols.
10018 2004-08-04 Martin Baulig <martin@ximian.com>
10020 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10022 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10024 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10026 * report.cs (Message): New enum for better error, warning reference in
10028 (MessageData): New inner abstract class. It generally handles printing of
10029 error and warning messages.
10030 Removed unused Error, Warning, Message methods.
10032 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10034 Fix for cs0592-8.cs test
10036 (Attributable.ValidAttributeTargets): Made public.
10037 (Attribute.ExplicitTarget): New member for explicit target value.
10038 (Attribute.CheckTargets): Now we translate explicit attribute
10039 target to Target here.
10041 2004-08-03 Ben Maurer <bmaurer@ximian.com>
10043 * ecore.cs (MethodGroupExpr): new IsBase property.
10045 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
10047 * delegate.cs (DelegateCreation): store a MethodGroupExpr
10048 rather than an instance expr.
10050 (DelegateCreation.Emit): Use the method group rather than
10051 the instance expression. Also, if you have base.Foo as the
10052 method for a delegate, make sure to emit ldftn, not ldftnvirt.
10054 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
10056 (NewDelegate.DoResolve): Only check for the existance of Invoke
10057 if the method is going to be needed. Use MethodGroupExpr.
10059 (NewDelegate.Emit): Remove, DelegateCreation implements this.
10061 * expression.cs: For pointer arith., make sure to use
10062 the size of the type, not the size of the pointer to
10065 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10068 * class.cs (Class): Added error CS0502 test.
10070 2004-08-03 John Luke <jluke@cfl.rr.com>
10071 Raja R Harinath <rharinath@novell.com>
10074 * attribute.cs (Attribute.complained_before): New flag.
10075 (Attribute.ResolveType, Attribute.Resolve),
10076 (Attribute.DefinePInvokeMethod): Set it.
10077 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
10079 2004-08-03 Martin Baulig <martin@ximian.com>
10081 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10082 use a user-defined operator; we still need to do numeric
10083 promotions in case one argument is a builtin type and the other
10084 one has an implicit conversion to that type. Fixes #62322.
10086 2004-08-18 Martin Baulig <martin@ximian.com>
10088 * class.cs (Method.Define): Use the correct method name when
10089 creating the MethodBuilder for a generic method.
10091 2004-08-17 Martin Baulig <martin@ximian.com>
10093 * generic.cs (Constraints): Support type parameter constraints.
10095 2004-08-16 Martin Baulig <martin@ximian.com>
10097 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
10098 (Token.GENERIC_DIMENSION): New token; this is returned if we
10099 encounter an unbound generic type in a typeof() expression.
10101 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
10102 this token is only generated while parsing a typeof() expression.
10103 (typeof_expression): Removed the old unbound_type hack.
10105 * generic.cs (TypeArguments.IsUnbound): New public property.
10107 * decl.cs (MemberName): Added support for unbound types.
10109 2004-08-14 Martin Baulig <martin@ximian.com>
10112 (TypeManager.IsEqualGenericInstance): New static method.
10113 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
10114 just used to check accessibility, so follow the rules of 26.1.6.
10116 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
10117 ConstructedType instead of a TypeExpression if we have type arguments.
10119 * cs-parser.jay (typeof_expression): Support unbound generic types.
10121 * ecore.cs (UnboundTypeExpression): New public class.
10123 2004-08-12 Martin Baulig <martin@ximian.com>
10125 * typemanager.cs (TypeManager.IsNestedChildOf): Use
10126 TypeManager.IsEqual() rather than `=='.
10128 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
10129 generic instances as well.
10131 2004-08-12 Martin Baulig <martin@ximian.com>
10133 * expression.cs (Invocation.InferType): We can only infer method
10134 type parameters. Fixes #62647.
10136 2004-08-11 Martin Baulig <martin@ximian.com>
10138 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
10139 before resolving the base classes.
10141 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10143 * Makefile: install .mdb file too.
10145 2004-08-05 Martin Baulig <martin@ximian.com>
10147 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
10148 initializer, the current type is just the TypeBuilder, not the
10149 instantiated generic type.
10150 (FieldExpr.IsFieldInitializer): New public property.
10152 2004-08-04 Martin Baulig <martin@ximian.com>
10154 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10156 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10158 2004-08-03 Martin Baulig <martin@ximian.com>
10160 * class.cs (MethodData.Define): If we're an explicit
10161 implementation, remove the generic arity from the type name.
10163 2004-08-03 Martin Baulig <martin@ximian.com>
10165 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10166 use a user-defined operator; we still need to do numeric
10167 promotions in case one argument is a builtin type and the other
10168 one has an implicit conversion to that type. Fixes #62322.
10170 2004-08-02 Martin Baulig <martin@ximian.com>
10172 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
10173 `TypeExpr[]' array.
10174 (TypeContainer.GetClassBases): Return the unexpanded list of
10175 interfaces; we expand them later.
10176 (TypeContainer.DefineType): After creating the TypeBuilder, call
10177 TypeManager.ExpandInterfaces() to get an expanded and resolved
10178 list of interfaces.
10180 * ecore.cs (TypeExpr.GetInterfaces): Removed
10182 * generics.cs (Constraints.InterfaceConstraints): Remove.
10183 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
10184 register the interface constraints.
10187 (TypeManager.AddUserType): Removed the `ifaces' argument.
10188 (TypeManager.AddTypeParameter): Likewise.
10189 (TypeManager.AddUserInterface): Removed, was unused.
10190 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
10191 `TypeExpr[]' array for the interfaces.
10192 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
10193 has been defined, returns a list of the resolved interfaces types.
10194 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
10195 (TypeManager.GetExplicitInterfaces): Likewise.
10197 2004-08-02 Martin Baulig <martin@ximian.com>
10199 * expression.cs (Invocation.EmitCall): If we're invoking a method
10200 on a type parameter, use the new `Constrained' prefix opcode.
10202 2004-08-02 Martin Baulig <martin@ximian.com>
10204 * statement.cs (LocalInfo.Flags): Added `IsThis'.
10205 (LocalInfo.IsThis): New public property.
10206 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
10208 2004-08-01 Martin Baulig <martin@ximian.com>
10210 * class.cs (TypeContainer.GetClassBases): Don't set the default
10211 here since we may get called from GetPartialBases().
10212 (TypeContainer.DefineType): If GetClassBases() didn't return a
10213 parent, use the default one.
10215 2004-07-30 Martin Baulig <martin@ximian.com>
10217 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
10219 * class.cs (SourceMethod): New public class, derive from the
10220 symbol writer's ISourceMethod.
10221 (Method): Use the new symbol writer API.
10223 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
10224 as argument and use the new symbol writer.
10227 (SourceFile): Implement the symbol writer's ISourceFile.
10228 (Location.SymbolDocument): Removed.
10229 (Location.SourceFile): New public property.
10231 * symbolwriter.cs: Use the new symbol writer API.
10233 2004-07-30 Raja R Harinath <rharinath@novell.com>
10235 * Makefile (install-local): Remove. Functionality moved to
10238 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
10240 * Makefile: Install mcs.exe.config file together with mcs.exe.
10241 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
10242 correct runtime version.
10244 2004-07-25 Martin Baulig <martin@ximian.com>
10247 (TypeContainer.RegisterOrder): Removed, this was unused.
10248 (TypeContainer, interface_order): Removed.
10249 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
10250 TypeContainer as argument since we can also be called with a
10251 `PartialContainer' for a partial class/struct/interface.
10252 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
10253 of checking whether we're an `Interface' - we could be a
10254 `PartialContainer'.
10255 (PartialContainer.Register): Override; call
10256 AddClass()/AddStruct()/AddInterface() on our parent.
10258 * cs-parser.jay (interface_member_declaration): Add things to the
10259 `current_container', not the `current_class'.
10261 * rootcontext.cs (RegisterOrder): The overloaded version which
10262 takes an `Interface' was unused, removed.
10264 * typemanager.cs (TypeManager.LookupInterface): Return a
10265 `TypeContainer', not an `Interface'.
10266 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10267 contain a `PartialContainer' for an interface, so check it's
10268 `Kind' to figure out what it is.
10270 2004-07-25 Martin Baulig <martin@ximian.com>
10272 * class.cs (Class.DefaultTypeAttributes): New public constant.
10273 (Struct.DefaultTypeAttributes): Likewise.
10274 (Interface.DefaultTypeAttributes): Likewise.
10275 (PartialContainer.TypeAttr): Override this and add the
10276 DefaultTypeAttributes.
10278 2004-07-25 Martin Baulig <martin@ximian.com>
10280 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10281 we can just use the `Parent' field instead.
10283 2004-07-25 Martin Baulig <martin@ximian.com>
10285 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10287 2004-07-25 Martin Baulig <martin@ximian.com>
10289 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10290 our parts before defining any methods.
10291 (TypeContainer.VerifyImplements): Make this virtual.
10292 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10293 on our PartialContainer.
10295 2004-07-25 Martin Baulig <martin@ximian.com>
10297 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10299 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10300 argument, we can just use the `Parent' field instead.
10303 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10304 (MemberBase.DoDefine): Likewise.
10306 2004-07-24 Martin Baulig <martin@ximian.com>
10308 * decl.cs (MemberCore.Parent): New public field.
10309 (DeclSpace.Parent): Moved to MemberCore.
10311 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10312 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10314 (FieldBase, Field, Operator): Likewise.
10315 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10316 (EventField, Event): Likewise.
10318 2004-07-23 Martin Baulig <martin@ximian.com>
10320 * class.cs (PartialContainer): New public class.
10321 (ClassPart): New public class.
10322 (TypeContainer): Added support for partial classes.
10323 (TypeContainer.GetClassBases): Splitted some of the functionality
10324 out into GetNormalBases() and GetPartialBases().
10326 * cs-tokenizer.cs (Token.PARTIAL): New token.
10327 (Tokenizer.consume_identifier): Added some hacks to recognize
10328 `partial', but only if it's immediately followed by `class',
10329 `struct' or `interface'.
10331 * cs-parser.jay: Added support for partial clases.
10333 2004-07-23 Martin Baulig <martin@ximian.com>
10335 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10336 a `DeclSpace' and also made it readonly.
10337 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10338 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10339 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10341 * cs-parser.jay: Pass the `current_class', not the
10342 `current_container' (at the moment, this is still the same thing)
10343 to a new Method, Property, Event, Indexer or Constructor.
10345 2004-07-23 Martin Baulig <martin@ximian.com>
10347 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10348 and removed the `current_interface' one.
10349 (struct_declaration, class_declaration, interface_declaration):
10350 Set `current_class' to the newly created class/struct/interface;
10351 set their `Bases' and call Register() before parsing their body.
10353 2004-07-23 Martin Baulig <martin@ximian.com>
10355 * class.cs (Kind): New public enum.
10356 (TypeContainer): Made this class abstract.
10357 (TypeContainer.Kind): New public readonly field.
10358 (TypeContainer.CheckDef): New public method; moved here from
10360 (TypeContainer.Register): New public abstract method.
10361 (TypeContainer.GetPendingImplementations): New public abstract
10363 (TypeContainer.GetClassBases): Removed the `is_class' and
10364 `is_iface' parameters.
10365 (TypeContainer.DefineNestedTypes): Formerly known as
10367 (ClassOrStruct): Made this class abstract.
10369 * tree.cs (RootTypes): New public type.
10371 2004-07-20 Martin Baulig <martin@ximian.com>
10373 * tree.cs (Tree.RecordNamespace): Removed.
10374 (Tree.Namespaces): Removed.
10376 * rootcontext.cs (RootContext.IsNamespace): Removed.
10378 * cs-parser.jay (namespace_declaration): Just create a new
10379 NamespaceEntry here.
10381 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10383 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10384 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10385 entry to make sure it runs in the correct runtime version.
10387 2004-07-18 Martin Baulig <martin@ximian.com>
10389 * generic.cs (ConstructedType.CheckConstraints): Improved
10390 constraints checking.
10392 2004-07-18 Martin Baulig <martin@ximian.com>
10394 * expression.cs (Invocation.BetterMethod): Call
10395 TypeManager.TypeToCoreType() on all types and removed my previous
10396 hack; we're already doig the right thing here.
10398 2004-07-17 Martin Baulig <martin@ximian.com>
10400 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10402 2004-07-16 Martin Baulig <martin@ximian.com>
10404 * iterators.cs: Added generics support.
10406 2004-07-16 Martin Baulig <martin@ximian.com>
10408 * iterators.cs: Rewrote this. We're now using one single Proxy
10409 class for both the IEnumerable and the IEnumerator interface and
10410 `Iterator' derives from Class so we can use the high-level API.
10412 * class.cs (TypeContainer.AddIterator): New method.
10413 (TypeContainer.DoDefineType): New protected virtual method, which
10414 is called from DefineType().
10415 (TypeContainer.DoDefineMembers): Call DefineType() and
10416 DefineMembers() on all our iterators.
10417 (TypeContainer.Emit): Call Emit() on all our iterators.
10418 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10420 * codegen.cs (EmitContext.CurrentIterator): New public field.
10422 2004-07-15 Martin Baulig <martin@ximian.com>
10425 (TypeManager.not_supported_exception_type): New type.
10427 2004-07-14 Martin Baulig <martin@ximian.com>
10430 (TypeManager.generic_ienumerable_type): New type.
10431 (TypeManager.generic_ienumerator_type): New type.
10434 (RootContext.interfaces_first_stage): Added
10435 "System.Collections.Generic.IEnumerator`1" and
10436 "System.Collections.Generic.IEnumerable`1".
10438 2004-07-14 Martin Baulig <martin@ximian.com>
10440 * iterators.cs: Use real error numbers.
10442 2004-07-14 Martin Baulig <martin@ximian.com>
10444 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10445 requires this to be a System.Collection.IEnumerable and not a
10446 class implementing that interface.
10447 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10449 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10451 * class.cs: Fixed previous fix, it broke some error tests.
10453 2004-07-12 Martin Baulig <martin@ximian.com>
10455 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10458 2004-07-14 Martin Baulig <martin@ximian.com>
10460 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10461 an exclamation mark (!) for the generic arity to reflect the
10462 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10464 2004-07-13 Martin Baulig <martin@ximian.com>
10466 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10467 specifiers being part of a type argument.
10469 2004-07-13 Martin Baulig <martin@ximian.com>
10471 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10472 name for generic types.
10474 2004-07-13 Martin Baulig <martin@ximian.com>
10476 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10479 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10481 * assign.cs (LocalTemporary): Add new argument: is_address,If
10482 `is_address' is true, then the value that we store is the address
10483 to the real value, and not the value itself.
10485 * ecore.cs (PropertyExpr): use the new local temporary
10486 stuff to allow us to handle X.Y += z (where X is a struct)
10488 2004-07-08 Martin Baulig <martin@ximian.com>
10490 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10491 not always return, just like we're doing in Using.Resolve().
10493 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10495 * cs-parser.jay (fixed_statement): flag this as Pinned.
10497 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10499 * typemanager.cs (TypeManager): Removed MakePinned method, this
10500 mechanism is replaced with the .NET 2.x compatible mechanism of
10501 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10503 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10504 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10505 `IsFixed' property which has a different meaning.
10507 2004-07-02 Raja R Harinath <rharinath@novell.com>
10509 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10510 visible from inside a nested class, not just the names of the
10511 immediately enclosing class.
10512 Fix for bug #60730.
10514 2004-06-24 Raja R Harinath <rharinath@novell.com>
10516 * expression.cs (BetterConversion): Remove buggy special-case
10517 handling of "implicit constant expression conversions". At this
10518 point, we already know that the conversion is possible -- we're
10519 only checking to see which is better.
10521 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10523 * cs-parser.jay: Added error CS0210 test.
10525 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10527 * cs-parser.jay: Added error CS0134 test.
10529 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10532 * cs-parser.jay: Added error CS0145 test.
10534 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10536 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10538 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10540 * expression.cs (StackAlloc.Resolve): The argument may not
10541 be a constant; deal with this case.
10543 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10545 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10546 GetIndexerAttributeValue.
10547 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10549 * class.cs (Indexer.Define): Added error tests for CS0415,
10552 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10554 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10557 2004-06-23 Martin Baulig <martin@ximian.com>
10559 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10560 neither return nor throw, reset the barrier as well. Fixes #60457.
10562 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10564 * class.cs : EventAttributes is now set to None by default.
10565 This fixes bug #60459.
10567 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10570 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10571 Don't throw exception but return null (it's sufficient now).
10573 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10575 * typemanager.cs (GetArgumentTypes): Faster implementation.
10577 2004-06-18 Martin Baulig <martin@ximian.com>
10579 * attribute.cs (Attribute.Resolve): Check whether we're an
10580 EmptyCast which a Constant child. Fixes #60333.
10582 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10584 * statement.cs (EmitCollectionForeach): Account for the fact that
10585 not all valuetypes are in areas which we can take the address of.
10586 For these variables, we store to a temporary variable. Also, make
10587 sure that we dont emit a `callvirt' on a valuetype method.
10589 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10591 * expression.cs (StackAlloc.DoReSolve): Added test for
10592 negative parameter (CS0247).
10594 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10597 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10599 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10602 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10605 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10607 Fix bug #58254 & cs1555.cs, cs1556.cs
10608 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10610 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10612 * cs-parser.jay: Added error CS1669 test for indexers.
10614 2004-06-18 Martin Baulig <martin@ximian.com>
10616 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10617 argument. Fixes #60441.
10619 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10620 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10621 The name needs to have the actual name of the method in order
10622 for other tests (such as the one in OverloadResolve for Invoke
10623 on a delegate) to work. As well, it does not really help
10624 error reporting because the method group had multiple methods.
10625 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10626 Make profiling work.
10628 2004-06-13 Martin Baulig <martin@ximian.com>
10630 * cs-parser.jay: Don't allow generic attributes.
10632 2004-06-13 Martin Baulig <martin@ximian.com>
10634 * class.cs (MemberBase.DoDefineBase): New protected method.
10635 (MemberBase.DoDefine): Compute the `flags' in the new
10636 DoDefineBase() which must be called first.
10637 (Method.Define): Call DoDefineBase() first so we have the flags
10638 when defining the generic method.
10640 * cs-parser.jay (interface_method_declaration): Support generic methods.
10642 2004-06-13 Martin Baulig <martin@ximian.com>
10644 * decl.cs (TypeName): Removed.
10645 (MemberName): Removed TypeName and MemberNow; now we just have
10648 * cs-parser.jay: Don't distinguish between type arguments and type
10649 parameters in the grammar and simplified the rules a bit. The
10650 reduce/reduce conflicts are now gone (except the one we inherited
10653 2004-06-11 Martin Baulig <martin@ximian.com>
10655 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10656 call this twice: for params and varargs methods.
10658 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10661 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10663 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10665 * attribute.cs (Attribute.GetValidTargets): Made public.
10668 (AbstractPropertyEventMethod): New class for better code sharing.
10669 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10671 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10673 2004-06-09 Martin Baulig <martin@ximian.com>
10675 * cs-parser.jay: Removed a reduce/reduce conflict.
10677 2004-06-03 Martin Baulig <martin@ximian.com>
10679 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10680 GetSimpleName() and return a SimpleName.
10682 * ecore.cs (SimpleName.Arguments): New public field.
10683 (SimpleName): Added overloaded ctor which takes an additional
10684 TypeArguments argument.
10685 (SimpleName.SimpleNameResolve): Added support for generic methods.
10686 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10687 formerly in MemberAccess.DoResolve(), but we also need it in
10688 SimpleNameResolve().
10690 * expression.cs (MemberAccess.DoResolve): Use the new
10691 MethodGroupExpr.ResolveGeneric().
10693 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10695 * decl.cs: If possible, use lookuptypedirect here. We can only do
10696 this if there is no `.' after the namespace. Avoids using
10697 LookupType, which does lots of slow processing.
10698 (FindNestedType) New method, does what it says :-).
10699 * namespace.cs: use LookupTypeDirect.
10700 * rootcontext.cs: use membercache, if possible.
10701 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10703 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10706 According to the spec,
10708 In a member access of the form E.I, if E is a single identifier,
10709 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10710 field, property, localvariable, or parameter with the same type as
10711 the meaning of E as a type-name (§3.8), then both possible
10712 meanings of E are permitted.
10714 We did not check that E as a simple-name had the same type as E as
10717 This trivial check gives us 5-7% on bootstrap time.
10719 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10721 * expression.cs (Invocation.OverloadResolve): Avoid the
10722 use of hashtables and boxing here by allocating on demand.
10724 2004-05-30 Martin Baulig <martin@ximian.com>
10726 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10727 we're doing a silent lookup. Don't try to lookup nested types in
10728 TypeManager.object_type (thanks to Ben Maurer).
10730 2004-05-30 Martin Baulig <martin@ximian.com>
10732 Committing a patch from Ben Maurer.
10734 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10736 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10738 * convert.cs: add a trivial cache for overload operator resolution.
10740 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10743 (AttributeTester.GetObsoleteAttribute): Returns instance of
10744 ObsoleteAttribute when type is obsolete.
10747 (TypeContainer.VerifyObsoleteAttribute): Override.
10748 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10749 (MethodCode.VerifyObsoleteAttribute): Override.
10750 (MemberBase.VerifyObsoleteAttribute): Override.
10753 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10754 and report proper error.
10757 (Delegate.VerifyObsoleteAttribute): Override.
10760 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10761 and report proper error.
10762 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10765 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10769 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10770 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10771 Added test for ObsoleteAttribute.
10774 (Catch): Derived from Statement.
10776 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10778 * decl.cs: If possible, use lookuptypedirect here. We can only do
10779 this if there is no `.' after the namespace. Avoids using
10780 LookupType, which does lots of slow processing.
10781 (FindNestedType) New method, does what it says :-).
10782 * namespace.cs: use LookupTypeDirect.
10783 * rootcontext.cs: use membercache, if possible.
10784 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10786 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10789 According to the spec,
10791 In a member access of the form E.I, if E is a single identifier,
10792 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10793 field, property, localvariable, or parameter with the same type as
10794 the meaning of E as a type-name (§3.8), then both possible
10795 meanings of E are permitted.
10797 We did not check that E as a simple-name had the same type as E as
10800 This trivial check gives us 5-7% on bootstrap time.
10802 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10804 Fixed bug #59071 & cs0160.cs
10805 * statement.cs (Try.Resolve): Check here whether order of catch
10806 clauses matches their dependencies.
10808 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10811 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10814 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10816 * expression.cs (Invocation.OverloadResolve): Avoid the
10817 use of hashtables and boxing here by allocating on demand.
10819 2004-05-30 Martin Baulig <martin@ximian.com>
10821 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10822 we're doing a silent lookup. Don't try to lookup nested types in
10823 TypeManager.object_type (thanks to Ben Maurer).
10825 2004-05-30 Martin Baulig <martin@ximian.com>
10827 Committing a patch from Ben Maurer.
10829 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10831 2004-05-29 Martin Baulig <martin@ximian.com>
10833 * class.cs (IMethodData.ShouldIgnore): New method.
10835 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10836 `Location' argument, we don't need it anywhere. Use
10837 `IMethodData.ShouldIgnore ()' instead of
10838 `MethodData.GetMethodFlags ()'.
10839 (TypeManager.AddMethod): Removed.
10840 (TypeManager.AddMethod2): Renamed to AddMethod.
10842 2004-05-29 Martin Baulig <martin@ximian.com>
10844 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10846 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10847 converting from a class type S to an interface type and we already
10848 have an object on the stack, don't box it again. Fixes #52578.
10850 2004-05-29 Martin Baulig <martin@ximian.com>
10852 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10853 Added support for `params' parameters. Fixes #59267.
10855 2004-05-29 Martin Baulig <martin@ximian.com>
10857 * literal.cs (NullPointer): Provide a private .ctor which sets
10858 `type' to TypeManager.object_type. Fixes #59048.
10860 2004-05-29 Martin Baulig <martin@ximian.com>
10862 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10863 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10865 * ecore.cs (EventExpr.instance_expr): Make the field private.
10867 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10869 Fixed bug #50080 & cs0214-2.cs
10870 * expression.cs (Cast.DoResolve): Check unsafe context here.
10872 * statement.cs (Resolve.DoResolve): Likewise.
10874 2004-05-26 Martin Baulig <martin@ximian.com>
10876 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
10878 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
10879 (RootContext.LookupType): Pass down the `silent' flag.
10881 2004-05-25 Martin Baulig <martin@ximian.com>
10884 (MethodGroupExpr.IdenticalTypeName): New public property.
10885 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
10886 expression actually refers to a type.
10888 2004-05-25 Martin Baulig <martin@ximian.com>
10890 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
10891 for #56176 and made it actually work.
10893 2004-05-25 Martin Baulig <martin@ximian.com>
10895 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
10896 (FieldExpr, PropertyExpr): Override and implement
10897 CacheTemporaries. Fixes #52279.
10899 2004-05-25 Miguel de Icaza <miguel@ximian.com>
10901 * location.cs: In the new compiler listing a file twice is a
10902 warning, not an error.
10904 2004-05-24 Martin Baulig <martin@ximian.com>
10906 * enum.cs (Enum.DefineType): For the `BaseType' to be a
10907 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
10909 2004-05-24 Martin Baulig <martin@ximian.com>
10911 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
10912 walking the `using' list. Fixes #53921.
10914 2004-05-24 Martin Baulig <martin@ximian.com>
10916 * const.cs (Const.LookupConstantValue): Added support for
10917 EmptyCast's; fixes #55251.
10919 2004-05-24 Martin Baulig <martin@ximian.com>
10921 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
10922 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
10923 which does the CS0135 check. The reason is that we first need to
10924 check whether the variable actually exists.
10926 2004-05-24 Martin Baulig <martin@ximian.com>
10928 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
10929 than RootContext.LookupType() to find the explicit interface
10930 type. Fixes #58584.
10932 2004-05-24 Raja R Harinath <rharinath@novell.com>
10934 * Makefile: Simplify. Use executable.make.
10935 * mcs.exe.sources: New file. List of sources of mcs.exe.
10937 2004-05-24 Anders Carlsson <andersca@gnome.org>
10941 Use the invariant culture when doing String.Compare for CLS case
10944 2004-05-23 Martin Baulig <martin@ximian.com>
10946 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
10947 don't have any dots. Fixes #52622, added cs0246-8.cs.
10949 * namespace.cs (NamespaceEntry.Lookup): Likewise.
10951 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10953 * class.cs (MemberBase.Define): Reuse MemberType member for
10954 resolved type. Other methods can use it too.
10956 2004-05-23 Martin Baulig <martin@ximian.com>
10958 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
10959 the variable also exists in the current block (otherwise, we need
10960 to report a CS0103). Fixes #58670.
10962 2004-05-23 Martin Baulig <martin@ximian.com>
10964 * flowanalysis.cs (Reachability.Reachable): Compute this
10965 on-the-fly rather than storing it as a field.
10967 2004-05-23 Martin Baulig <martin@ximian.com>
10969 * flowanalysis.cs (Reachability.And): Manually compute the
10970 resulting `barrier' from the reachability.
10972 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10975 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
10976 instance of ObsoleteAttribute when symbol is obsolete.
10979 (IMethodData): Extended interface for ObsoleteAttribute support.
10981 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10983 * attribute.cs: Fix bug #55970
10985 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10989 (GetObsoleteAttribute): New method. Creates the instance of
10991 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
10992 ObsoleteAttribute when member is obsolete.
10993 (AttributeTester.Report_ObsoleteMessage): Common method for
10994 Obsolete error/warning reporting.
10997 (TypeContainer.base_classs_type): New member for storing parent type.
11000 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
11001 for this MemberCore.
11003 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11005 * attribute.cs, const.cs: Fix bug #58590
11007 2004-05-21 Martin Baulig <martin@ximian.com>
11009 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
11010 out parameters if the end of the method is unreachable. Fixes
11013 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11015 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
11016 Hari was right, why extra method.
11018 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11020 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
11022 2004-05-20 Martin Baulig <martin@ximian.com>
11024 * delegate.cs: Convert this file to Unix mode - like the original
11027 2004-05-20 Martin Baulig <martin@ximian.com>
11029 * attribute.cs: Convert this file to Unix mode - like the original
11032 2004-05-19 Marek Safar <marek.safar@seznam.cz>
11034 Fix bug #58688 (MCS does not report error when the same attribute
11037 * attribute.cs (Attribute.Emit): Distinction between null and default.
11039 2004-05-19 Raja R Harinath <rharinath@novell.com>
11041 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
11042 of a top-level attribute without an attribute target.
11043 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
11045 (Attribute.Conditional_GetConditionName),
11046 (Attribute.Obsolete_GetObsoleteMessage): Update.
11047 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
11048 part of ScanForIndexerName.
11049 (Attribute.CanIgnoreInvalidAttribute): New function.
11050 (Attribute.ScanForIndexerName): Move to ...
11051 (Attributes.ScanForIndexerName): ... here.
11052 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
11053 (Attributes.Search): New internal variant that can choose not to
11054 complain if types aren't resolved. The original signature now
11056 (Attributes.GetClsCompliantAttribute): Use internal variant, with
11057 complaints suppressed.
11058 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
11059 only if it not useful.
11060 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
11061 top-level for attributes that are shared between the assembly
11062 and a top-level class.
11063 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
11064 * class.cs: Update to reflect changes.
11065 (DefineIndexers): Fuse loops.
11066 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
11067 a couple more variants of attribute names.
11069 2004-05-18 Marek Safar <marek.safar@seznam.cz>
11071 Fix bug #52585 (Implemented explicit attribute declaration)
11074 (Attributable.ValidAttributeTargets): New abstract method. It gets
11075 list of valid attribute targets for explicit target declaration.
11076 (Attribute.Target): It holds target itself.
11077 (AttributeSection): Removed.
11078 (Attribute.CheckTargets): New method. It checks whether attribute
11079 target is valid for the current element.
11082 (EventProperty): New class. For events that are declared like
11083 property (with add and remove accessors).
11084 (EventField): New class. For events that are declared like field.
11087 * cs-parser.jay: Implemented explicit attribute target declaration.
11089 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
11090 Override ValidAttributeTargets.
11093 (ReturnParameter): Class for applying custom attributes on
11095 (ParameterAtribute): New class. Class for applying custom
11096 attributes on the parameter type.
11098 2004-05-17 Miguel de Icaza <miguel@ximian.com>
11100 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
11103 (Method): Allow UNSAFE here.
11105 * modifiers.cs: Support unsafe reporting.
11107 2004-05-17 Marek Safar <marek.safar@seznam.cz>
11109 * decl.cs: Fix bug #58478.
11111 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11113 * statement.cs: When checking for unreachable code on an EmptyStatement,
11114 set the location. Fixes bug #58488.
11116 2004-05-13 Miguel de Icaza <miguel@ximian.com>
11118 * driver.cs: Add -pkg handling.
11120 From Gonzalo: UseShelLExecute=false
11122 2004-05-12 Marek Safar <marek.safar@seznam.cz>
11125 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
11127 (Attribute.IsClsCompliaceRequired): Moved to base for better
11129 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
11130 when attribute is AttributeUsageAttribute.
11131 (Attribute.GetValidTargets): Simplified.
11132 (Attribute.GetAttributeUsage): New method returns AttributeUsage
11133 attribute for this type.
11134 (Attribute.ApplyAttributes): Method renamed to Emit and make
11136 (GlobalAttributeSection): New class for special handling of global
11137 attributes (assembly, module).
11138 (AttributeSection.Emit): New method.
11140 * class.cs: Implemented Attributable abstract methods.
11141 (MethodCore.LabelParameters): Moved to Parameter class.
11142 (Accessor): Is back simple class.
11143 (PropertyMethod): Implemented Attributable abstract class.
11144 (DelegateMethod): Implemented Attributable abstract class.
11145 (Event): New constructor for disctintion between normal Event
11146 and Event with accessors.
11148 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
11150 * codegen.cs, const.cs, decl.cs, delegate.cs:
11151 (CommonAssemblyModulClass): Implemented Attributable abstract class
11154 * enum.cs: Implement IAttributeSupport interface.
11155 (EnumMember): New class for emum members. Implemented Attributable
11159 (ParameterBase): Is abstract.
11160 (ReturnParameter): New class for easier [return:] attribute handling.
11162 * typemanager.cs: Removed builder_to_attr.
11164 2004-05-11 Raja R Harinath <rharinath@novell.com>
11167 * attribute.cs (Attribute.GetPositionalValue): New function.
11168 * class.cs (TypeContainer.VerifyMembers): New function.
11169 (TypeContainer.Emit): Use it.
11170 (ClassOrStruct): New base class for Class and Struct.
11171 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
11172 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
11174 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
11175 then each non-static field should have a FieldOffset attribute.
11176 Otherwise, none of the fields should have a FieldOffset attribute.
11177 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
11178 and FieldOffset attributes.
11179 * typemanager.cs (TypeManager.struct_layout_attribute_type)
11180 (TypeManager.field_offset_attribute_type): New core types.
11181 (TypeManager.InitCoreTypes): Initialize them.
11183 2004-05-11 Michal Moskal <malekith@pld-linux.org>
11185 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
11186 Return correct type.
11189 2004-05-09 Miguel de Icaza <miguel@ximian.com>
11191 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
11192 be implicitly converted to ulong.
11194 * expression.cs: The logic for allowing operator &, | and ^ worked
11195 was wrong, it worked before because we did not report an error in
11196 an else branch. Fixes 57895.
11198 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
11199 allow volatile fields to be reference types.
11201 2004-05-07 Miguel de Icaza <miguel@ximian.com>
11203 * driver.cs: Add support for /debug-
11205 2004-05-07 Raja R Harinath <rharinath@novell.com>
11207 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
11208 Add a 'complain' parameter to silence errors.
11209 (Attribute.Resolve): Update to changes. Put in sanity check to catch
11210 silently overlooked type-resolutions.
11211 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
11212 to reflect changes.
11213 (Attributes.Search): New function.
11214 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
11215 (Attributes.GetAttributeFullName): Remove hack.
11216 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
11217 Update to reflect changes.
11218 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11219 Use Attributes.Search instead of nested loops.
11221 2004-05-07 Marek Safar <marek.safar@seznam.cz>
11224 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
11225 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
11226 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
11228 * report.cs: (Report.Warning): Renamed to Warning_T because of
11229 parameter collision.
11231 2004-05-05 Raja R Harinath <rharinath@novell.com>
11233 * expression.cs (MemberAccess.ResolveMemberAccess):
11234 Exit with non-zero status after Report.Error.
11235 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
11237 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
11239 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11241 * support.cs: Don't hang when the file is empty.
11243 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11245 * support.cs: In SeekableStreamReader, compute the preamble size of the
11246 underlying stream. Position changes should take into account that initial
11249 2004-05-03 Todd Berman <tberman@sevenl.net>
11251 * driver.cs: remove unused GetSysVersion function.
11253 2004-05-03 Todd Berman <tberman@sevenl.net>
11255 * driver.cs: Remove the hack from saturday, as well as the hack
11256 from jackson (LoadAssemblyFromGac), also adds the CWD to the
11257 link_paths to get that bit proper.
11259 2004-05-01 Todd Berman <tberman@sevenl.net>
11261 * driver.cs: Try a LoadFrom before a Load, this checks the current
11262 path. This is currently a bug in mono that is be fixed, however, this
11263 provides a workaround for now. This will be removed when the bug
11266 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11268 * CryptoConvert.cs: Updated to latest version. Fix issue with
11269 incomplete key pairs (#57941).
11271 2004-05-01 Todd Berman <tberman@sevenl.net>
11273 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11276 2004-04-30 Jackson Harper <jackson@ximian.com>
11278 * codegen.cs: Open keys readonly.
11280 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11282 * typemanager.cs: don't report cyclic struct layout when a struct
11283 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11284 which has 2 Pango.Rectangle fields.
11286 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11288 * expression.cs: Handle IntPtr comparisons with IL code
11289 rather than a method call.
11291 2004-04-29 Martin Baulig <martin@ximian.com>
11293 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11294 the list of PropertyInfo's in class hierarchy and find the
11295 accessor. Fixes #56013.
11297 2004-04-29 Martin Baulig <martin@ximian.com>
11299 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11301 2004-04-29 Martin Baulig <martin@ximian.com>
11303 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11305 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11307 2004-04-29 Martin Baulig <martin@ximian.com>
11309 * class.cs (ConstructorInitializer.Resolve): Check whether the
11310 parent .ctor is accessible. Fixes #52146.
11312 2004-04-29 Martin Baulig <martin@ximian.com>
11314 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11316 * statement.cs (Using.EmitLocalVariableDecls): Use
11317 TypeManager.idisposable_type, not typeof (IDisposable).
11318 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11320 2004-04-29 Martin Baulig <martin@ximian.com>
11322 * class.cs (Event.Define): Don't emit the field and don't set
11323 RTSpecialName and SpecialName for events on interfaces. Fixes
11326 2004-04-29 Raja R Harinath <rharinath@novell.com>
11328 Refactor Attribute.ApplyAttributes.
11329 * attribute.cs (Attributable): New base class for objects that can
11330 have Attributes applied on them.
11331 (Attribute): Make AttributeUsage fields public.
11332 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11333 (Attribute.IsInternalCall): New property.
11334 (Attribute.UsageAttr): Convert to a public read-only property.
11335 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11336 (Attribute.ResolveType, Attribute.Resolve)
11337 (Attribute.ScanForIndexerName): Update to reflect changes.
11338 (Attribute.CheckAttributeTarget): Re-format.
11339 (Attribute.ApplyAttributes): Refactor, to various
11340 Attributable.ApplyAttributeBuilder methods.
11341 * decl.cs (MemberCore): Make Attributable.
11342 * class.cs (Accessor): Make Attributable.
11343 (MethodData.ApplyAttributes): Use proper attribute types, not
11345 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11346 (TypeContainer.ApplyAttributeBuilder)
11347 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11348 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11349 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11350 (Operator.ApplyAttributeBuilder): New factored-out methods.
11351 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11352 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11353 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11354 * parameter.cs (ParameterBase): New Attributable base class
11355 that can also represent Return types.
11356 (Parameter): Update to the changes.
11358 2004-04-29 Jackson Harper <jackson@ximian.com>
11360 * driver.cs: Prefer the corlib system version when looking for
11361 assemblies in the GAC. This is still a hack, but its a better hack
11364 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11366 * decl.cs, enum.cs: Improved error 3005 reporting.
11368 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11369 (related_symbols): New private member for list of symbols
11370 related to reported error/warning.
11372 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11374 2004-04-29 Martin Baulig <martin@ximian.com>
11376 * ecore.cs (Expression.Constantify): If we're an enum and
11377 TypeManager.TypeToCoreType() doesn't give us another type, use
11378 t.UnderlyingSystemType. Fixes #56178.
11380 2004-04-29 Martin Baulig <martin@ximian.com>
11382 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11383 interfaces and for each interface, only add members directly
11384 declared in that interface. Fixes #53255.
11386 2004-04-28 Martin Baulig <martin@ximian.com>
11388 * expression.cs (ConditionalLogicalOperator): Use a temporary
11389 variable for `left' to avoid that we evaluate it more than once;
11392 2004-04-28 Martin Baulig <martin@ximian.com>
11394 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11397 2004-04-28 Martin Baulig <martin@ximian.com>
11399 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11402 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11403 whether the type is not void (CS1547).
11405 2004-04-28 Martin Baulig <martin@ximian.com>
11407 * expression.cs (Unary.DoResolveLValue): Override this and report
11408 CS0131 for anything but Operator.Indirection.
11410 2004-04-28 Martin Baulig <martin@ximian.com>
11412 Committing a patch from Ben Maurer; see bug #50820.
11414 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11417 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11420 2004-04-28 Martin Baulig <martin@ximian.com>
11422 Committing a patch from Ben Maurer; see bug #50820.
11424 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11427 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11430 2004-04-28 Martin Baulig <martin@ximian.com>
11432 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11433 (Block.AddLabel): Call DoLookupLabel() to only search in the
11436 2004-04-28 Martin Baulig <martin@ximian.com>
11438 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11439 comparing StringConstants and NullLiterals in Equality and Inequality.
11441 2004-04-28 Jackson Harper <jackson@ximian.com>
11443 * driver.cs: Attempt to load referenced assemblies from the
11444 GAC. This is the quick and dirty version of this method that
11445 doesnt take into account versions and just takes the first
11446 canidate found. Will be good enough for now as we will not have more
11447 then one version installed into the GAC until I update this method.
11449 2004-04-28 Martin Baulig <martin@ximian.com>
11451 * typemanager.cs (TypeManager.CheckStructCycles): New public
11452 static method to check for cycles in the struct layout.
11454 * rootcontext.cs (RootContext.PopulateTypes): Call
11455 TypeManager.CheckStructCycles() for each TypeContainer.
11456 [Note: We only need to visit each type once.]
11458 2004-04-28 Martin Baulig <martin@ximian.com>
11460 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11462 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11463 success and added `out object value'. Use a `bool resolved' field
11464 to check whether we've already been called rather than
11465 `ConstantValue != null' since this breaks for NullLiterals.
11467 2004-04-28 Raja R Harinath <rharinath@novell.com>
11469 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11470 setting of this flag, since the 'set' method may be non-public.
11472 2004-04-28 Raja R Harinath <rharinath@novell.com>
11474 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11475 check on current_vector.Block.
11477 2004-04-27 Martin Baulig <martin@ximian.com>
11479 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11480 a field initializer. Fixes #56459.
11482 2004-04-27 Martin Baulig <martin@ximian.com>
11484 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11485 we're not attempting to use an indexer. Fixes #52154.
11487 2004-04-27 Martin Baulig <martin@ximian.com>
11489 * statement.cs (Return): Don't create a return label if we don't
11490 need it; reverts my change from January 20th. Thanks to Ben
11493 2004-04-27 Martin Baulig <martin@ximian.com>
11495 According to the spec, `goto' can only leave a nested scope, but
11498 * statement.cs (Block.LookupLabel): Only lookup in the current
11499 block, don't recurse into parent or child blocks.
11500 (Block.AddLabel): Check in parent and child blocks, report
11501 CS0140/CS0158 if we find a duplicate.
11502 (Block): Removed this indexer for label lookups.
11503 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11504 this already does the error reporting for us.
11507 (FlowBranching.UsageVector.Block): New public variable; may be null.
11508 (FlowBranching.CreateSibling): Added `Block' argument.
11509 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11510 label for the target of a `goto' and check whether we're not
11511 leaving a `finally'.
11513 2004-04-27 Martin Baulig <martin@ximian.com>
11515 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11516 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11519 2004-04-27 Martin Baulig <martin@ximian.com>
11521 * statement.cs (Block.AddLabel): Also check for implicit blocks
11522 and added a CS0158 check.
11524 2004-04-27 Martin Baulig <martin@ximian.com>
11526 * flowanalysis.cs (FlowBranchingLoop): New class.
11527 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11528 UsageVector's instead of an ArrayList.
11529 (FlowBranching.Label): Likewise.
11530 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11531 (FlowBranching.AddBreakVector): New method.
11533 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11535 * attribute.cs: Small regression fix: only convert the type if we
11536 the type is different, fixes System.Drawing build.
11538 2004-04-27 Martin Baulig <martin@ximian.com>
11540 * attribute.cs (Attribute.Resolve): If we have a constant value
11541 for a named field or property, implicity convert it to the correct
11544 2004-04-27 Raja R Harinath <rharinath@novell.com>
11546 * statement.cs (Block.Block): Implicit blocks share
11547 'child_variable_names' fields with parent blocks.
11548 (Block.AddChildVariableNames): Remove.
11549 (Block.AddVariable): Mark variable as "used by a child block" in
11550 every surrounding block.
11551 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11552 been used in a child block, complain about violation of "Invariant
11553 meaning in blocks" rule.
11554 * cs-parser.jay (declare_local_variables): Don't use
11555 AddChildVariableNames.
11556 (foreach_statement): Don't create an implicit block: 'foreach'
11557 introduces a scope.
11559 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11561 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11562 converting from 0L to ulong. Fixes 57522.
11564 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11566 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11567 derived class hides via 'new' keyword field from base class (test-242.cs).
11568 TODO: Handle this in the more general way.
11570 * class.cs (CheckBase): Ditto.
11572 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11574 * decl.cs (caching_flags): New member for storing cached values
11576 (MemberCore.Flags): New enum where bit flags for caching_flags
11578 (MemberCore.cls_compliance): Moved to caching_flags.
11579 (DeclSpace.Created): Moved to caching_flags.
11581 * class.cs: Use caching_flags instead of DeclSpace.Created
11583 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11585 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11586 if we are only a derived class, not a nested class.
11588 * typemanager.cs: Same as above, but do this at the MemberLookup
11589 level (used by field and methods, properties are handled in
11590 PropertyExpr). Allow for the qualified access if we are a nested
11593 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11595 * class.cs: Refactoring.
11596 (IMethodData): New inteface; Holds links to parent members
11597 to avoid member duplication (reduced memory allocation).
11598 (Method): Implemented IMethodData interface.
11599 (PropertyBase): New inner classes for get/set methods.
11600 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11601 (Event): New inner classes for add/remove methods.
11602 (Event.DelegateMethod): Implemented IMethodData interface.
11604 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11605 EmitContext (related to class.cs refactoring).
11607 2004-04-21 Raja R Harinath <rharinath@novell.com>
11609 * delegate.cs (Delegate.VerifyApplicability): If the number of
11610 arguments are the same as the number of parameters, first try to
11611 verify applicability ignoring any 'params' modifier on the last
11615 2004-04-08 Martin Baulig <martin@ximian.com>
11617 Merged latest changes into gmcs. Please keep this comment in
11618 here, it makes it easier for me to see what changed in MCS since
11619 the last time I merged.
11621 2004-04-16 Raja R Harinath <rharinath@novell.com>
11623 * class.cs (TypeContainer.AddIndexer): Use
11624 'ExplicitInterfaceName' to determine if interface name was
11625 explicitly specified. 'InterfaceType' is not initialized at this time.
11626 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11627 Indexers array is already in the required order. Initialize
11628 'IndexerName' only if there are normal indexers.
11629 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11630 (TypeContainer.Emit): Emit DefaultMember attribute only if
11631 IndexerName is initialized.
11634 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11636 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11639 2004-04-15 Raja R Harinath <rharinath@novell.com>
11641 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11645 * attribute.cs (Attribute.Resolve): Check for duplicate named
11649 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11651 * iterators.cs (MarkYield): track whether we are in an exception,
11652 and generate code accordingly. Use a temporary value to store the
11653 result for our state.
11655 I had ignored a bit the interaction of try/catch with iterators
11656 since their behavior was not entirely obvious, but now it is
11657 possible to verify that our behavior is the same as MS .NET 2.0
11661 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11663 * iterators.cs: Avoid creating temporaries if there is no work to
11666 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11667 Enumerations, use TypeManager.EnumToUnderlying and call
11670 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11673 (This.Emit): Use EmitContext.EmitThis to emit our
11676 (This.EmitAssign): Ditto.
11678 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11679 codepaths, we will move all the functionality into
11682 (FieldExpr.EmitAssign): Ditto.
11684 This fixes several hidden bugs that I uncovered while doing a code
11685 review of this today.
11687 * codegen.cs (EmitThis): reworked so the semantics are more clear
11688 and also support value types "this" instances.
11690 * iterators.cs: Changed so that for iterators in value types, we
11691 do not pass the value type as a parameter.
11693 Initialization of the enumerator helpers is now done in the caller
11694 instead of passing the parameters to the constructors and having
11695 the constructor set the fields.
11697 The fields have now `assembly' visibility instead of private.
11699 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11701 * expression.cs (Argument.Resolve): Check if fields passed as ref
11702 or out are contained in a MarshalByRefObject.
11704 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11705 another compiler type.
11707 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11709 * class.cs (Indexer.Define): use the new name checking method.
11710 Also, return false on an error.
11711 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11712 (is_identifier_[start/part]_character): make static.
11714 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11716 * expression.cs (Binary.ResolveOperator): Do no append strings
11717 twice: since we can be invoked more than once (array evaluation)
11718 on the same concatenation, take care of this here. Based on a fix
11719 from Ben (bug #56454)
11721 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11723 * codegen.cs: Fix another case where CS1548 must be reported (when
11724 delay-sign isn't specified and no private is available #56564). Fix
11725 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11726 error when MCS is used on the MS runtime and we need to delay-sign
11727 (which seems unsupported by AssemblyBuilder - see #56621).
11729 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11731 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11732 (TypeManager.ComputeNamespaces): Faster implementation for
11735 * compiler.csproj: Updated AssemblyName to mcs.
11737 2004-05-11 Jackson Harper <jackson@ximian.com>
11739 * Makefile: Preserve MONO_PATH
11741 2004-05-11 Jackson Harper <jackson@ximian.com>
11743 * Makefile: Use mono and mcs to build gmcs
11745 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11747 * codegen.cs: Add patch from Robert Shade
11748 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11751 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11753 * CryptoConvert.cs: Updated to latest version. Fix issue with
11754 incomplete key pairs (#57941).
11756 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11758 * codegen.cs: Fix another case where CS1548 must be reported (when
11759 delay-sign isn't specified and no private is available #56564). Fix
11760 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11761 error when MCS is used on the MS runtime and we need to delay-sign
11762 (which seems unsupported by AssemblyBuilder - see #56621).
11764 2004-04-29 Jackson Harper <jackson@ximian.com>
11766 * Makefile: Set MONO_PATH to use the bootstrap corlib
11767 * driver.cs: Check the GAC for referenced assemblies.
11769 2004-04-29 Martin Baulig <martin@ximian.com>
11771 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11773 2004-04-07 Martin Baulig <martin@ximian.com>
11775 * expression.cs (Binary.ResolveOperator): Added special case for
11776 Equality/Inequality between a type parameter and a null literal.
11778 2004-04-07 Martin Baulig <martin@ximian.com>
11780 * convert.cs: Check null literal -> type parameter conversions.
11782 2004-04-07 Martin Baulig <martin@ximian.com>
11784 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11785 `class' and `struct' constraints.
11787 2004-04-07 Martin Baulig <martin@ximian.com>
11789 * generic.cs (SpecialConstraint): New public enum.
11790 (Constraints.Resolve): Added support for the `class' and `struct'
11793 * cs-parser.jay (type_parameter_constraint): Added support for the
11794 `class' and `struct' constraints.
11796 2004-04-07 Martin Baulig <martin@ximian.com>
11798 * support.cs (GenericConstraints): Replaced `Types' by
11799 `ClassConstraint' and `InterfaceConstraints'; added
11800 `HasClassConstraint'.
11802 2004-04-07 Martin Baulig <martin@ximian.com>
11805 (Constraints.InterfaceConstraints): New public property.
11806 (Constraints.Types): Make this property public
11807 (TypeParameter): Implement IMemberContainer.
11808 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11809 instead of a TypeBuilder/MethodBuilder; pass the interface
11810 constraints to TypeManager.AddTypeParameter().
11811 (TypeParameter.DefineType): Just take an EmitContext and no
11812 TypeBuilder/MethodBuilder. Use the new public API.
11814 * typemanager.cs (TypeManager.AddTypeParameter): Added
11815 `TypeExpr[]' argument; add the interfaces to the
11816 `builder_to_ifaces' hash.
11817 (TypeManager.LookupMemberContainer): For
11818 GenericTypeParameterBuilders, get the TypeParameter from the
11819 `builder_to_type_param'.
11820 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11821 the TypeParameter and call FindMembers on it.
11823 2004-04-07 Martin Baulig <martin@ximian.com>
11826 (MethodCore.GenericMethod): Moved this field here from Method.
11827 (MethodCore.IsDuplicateImplementation): Take the number of type
11828 parameters into account if we're a generic method.
11830 * expression.cs (Invocation.InferTypeArguments): Don't return true
11831 if `arguments' is null; we still need to check whether we actually
11832 don't need to infer anything in this case.
11833 (MemberAccess): Merged the functionality from GenericMemberAccess
11836 * generic.cs (GenericMemberAccess): Removed.
11838 2004-04-05 Martin Baulig <martin@ximian.com>
11840 * decl.cs (MemberCore): For generic classes, interfaces and
11841 structs, `Name' now includes the number of type parameters
11842 ("Stack!1.Node!1").
11843 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11844 encode the number of type arguments in the type name.
11846 * expression.cs (Expression.MemberLookup): Removed the
11847 `num_type_args' argument; we now encode the number of type
11848 arguments in the type name.
11850 * ecore.cs (SimpleName): Encode the number of type arguments in
11851 the type name itself.
11853 * generic.cs (ConstructedType): Likewise.
11855 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11856 `MemberName'; we now include the number of type parameters in the
11859 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11860 (TypeManager.MemberLookup): Removed the
11861 `num_type_args' argument; we now encode the number of type
11862 arguments in the type name.
11864 2004-04-03 Martin Baulig <martin@ximian.com>
11866 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11867 (MemberCore.MemberName): Moved here from MemberBase.
11868 (DeclSpace.SetParameterInfo): Just take the constraints as an
11869 ArrayList; we already have the type parameters in our
11870 `MemberName'; also do the CS0080 reporting here.
11872 * cs-parser.jay (struct_declaration): Use `member_name' instead of
11873 `IDENTIFIER opt_type_parameter_list'; when constructing our
11874 `MemberName', it'll already include our type parameters.
11875 (class_declaration, interface_declaration): Likewise.
11876 (delegate_declaration): Likewise.
11877 (MakeName): Take a MemberName and return a MemberName.
11878 The following two changes are required to avoid shift/reduce conflicts:
11879 (member_name): Don't include a TypeName anymore; ie. this is now
11880 just 'IDENTIFIER opt_type_parameter_list'.
11881 (property_declaration, event_declaration): Use a
11882 `namespace_or_type_name' instead of a `member_name'.
11884 2004-04-03 Martin Baulig <martin@ximian.com>
11886 * decl.cs (MemberName): Renamed to `TypeName' and created a new
11887 `MemberName' class.
11888 (TypeName): Formerly known as MemberName.
11890 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
11891 instead of a `MemberName'.
11893 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
11894 (member_name): New rule; create a MemberName.
11896 2004-04-02 Martin Baulig <martin@ximian.com>
11898 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
11899 (CS0305 and CS0308).
11901 2004-04-02 Martin Baulig <martin@ximian.com>
11903 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
11904 support for nested types.
11906 2004-04-02 Martin Baulig <martin@ximian.com>
11908 * ecore.cs (IAlias): New public interface.
11909 (TypeExpr, TypeExpression): Implement IAlias.
11910 (TypeAliasExpression): New public class.
11912 * namespace.cs (Namespace): Implement IAlias.
11913 (Namespace.Lookup): Return an IAlias instead on an object.
11914 (Namespace.DefineName): Take an IAlias instead of an object.
11915 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
11917 (NamespaceEntry.UsingAlias): Take a Membername instead of an
11919 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
11921 (NamespaceEntry.Lookup): Likewise.
11923 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
11926 * decl.cs (DeclSpace): Implement IAlias.
11927 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
11929 * generic.cs (ConstructedType): Improved error checking.
11931 2004-04-02 Martin Baulig <martin@ximian.com>
11933 * convert.cs: Added type parameter conversions.
11936 (UnboxCast.Emit): Emit an `unbox.any' for type params.
11937 (ClassCast.Emit): If the source type is a type parameter, box it.
11938 If the target type is a type parameter, emit an `unbox.any'
11939 instead of a `classcast'.1
11941 2004-04-01 Martin Baulig <martin@ximian.com>
11943 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
11945 2004-04-01 Martin Baulig <martin@ximian.com>
11947 * generic.cs (ConstructedType.CheckConstraints): Use
11948 Convert.ImplicitStandardConversionExists(); user-defined implicit
11949 conversions are not allowed according to the spec.
11951 2004-03-30 Martin Baulig <martin@ximian.com>
11953 * expression.cs (New): Added support for type parameters.
11956 (TypeManager.activator_type): New public static field.
11957 (TypeManager.activator_create_instance): Likewise.
11959 2004-03-30 Martin Baulig <martin@ximian.com>
11961 * typemanager.cs (TypeManager.HasConstructorConstraint): New
11964 2004-03-30 Martin Baulig <martin@ximian.com>
11966 * generic.cs (ConstructedType.CheckConstraints): Actually follow
11967 the spec here: the argument type must be convertible to the
11970 2004-03-30 Martin Baulig <martin@ximian.com>
11973 (TypeParameter.Define, TypeParameter.DefineMethod): Call
11974 TypeManager.AddTypeParameter().
11975 (ConstructedType.CheckConstraints): Re-enable this and actually
11976 check whether we have a constructor constraint.
11979 (TypeManager.builder_to_type_param): New static field.
11980 (TypeManager.AddTypeParameter): New static method.
11981 (TypeManager.LookupTypeParameter): New public method.
11983 2004-03-30 Martin Baulig <martin@ximian.com>
11985 * generic.cs (TypeParameter.DefineType): Return a boolean and use
11986 the new API to actually define the constructor constraint.
11989 (TypeManager.new_constraint_attr_type): New static field.
11990 (TypeManager.InitCoreTypes): Initialize it.
11992 2004-03-30 Martin Baulig <martin@ximian.com>
11994 * generic.cs (Constraints): Completed error checking, use correct
11997 2004-03-29 Martin Baulig <martin@ximian.com>
11999 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
12001 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12002 public version which takes a `ParameterData pd' instead of an
12005 2004-03-29 Martin Baulig <martin@ximian.com>
12007 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
12010 2004-03-29 Martin Baulig <martin@ximian.com>
12012 * expression.cs (Argument.ResolveMethodGroup): If we're a
12013 ConstructedType, call GetMemberAccess() on it.
12015 2004-03-29 Martin Baulig <martin@ximian.com>
12017 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
12018 (MethodCore.CheckGenericOverride): When overriding a generic
12019 method, check whether the constraints match.
12021 * support.cs (GenericConstraints): New public interface.
12022 (ParameterData.GenericConstraints): New public method.
12024 * parameter.cs (Parameter.Resolve): Check whether we're a generic
12025 method parameter and compute our constraints if appropriate.
12026 (Parameter.GenericConstraints): New public property.
12028 * generic.cs (Constraints): Implement GenericConstraints.
12030 2004-03-29 Martin Baulig <martin@ximian.com>
12032 * decl.cs (MemberCache.FindMemberToOverride): Use
12033 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
12035 2004-03-29 Martin Baulig <martin@ximian.com>
12037 * generic.cs (GenericMethod.Define): Resolve our type parameters.
12039 2004-03-29 Martin Baulig <martin@ximian.com>
12041 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
12042 not allowed on non-generic declarations").
12044 2004-03-29 Martin Baulig <martin@ximian.com>
12046 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12047 public version of this method.
12049 * class.cs (MethodCore.IsDuplicateImplementation): Use
12050 Invocation.InferTypeArguments() to check this.
12052 2004-03-29 Martin Baulig <martin@ximian.com>
12054 * convert.cs: Use TypeManager.IsDelegateType() instead of
12055 comparing types correctly.
12057 2004-03-29 Martin Baulig <martin@ximian.com>
12059 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
12060 types directly to make it work for generic instances.
12062 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
12064 2004-03-29 Martin Baulig <martin@ximian.com>
12066 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
12067 support for arrays.
12069 2004-03-24 Martin Baulig <martin@ximian.com>
12071 * decl.cs (DeclSpace.FindType): Also use
12072 TypeManager.CheckGeneric() for types from the using clauses.
12074 2004-03-23 Martin Baulig <martin@ximian.com>
12076 * expression.cs (Invocation.OverloadResolve): Added `bool
12077 may_fail' argument and use it instead of the Location.IsNull() hack.
12079 2004-03-23 Martin Baulig <martin@ximian.com>
12081 * expression.cs (Invocation.InferType): Use correct type inference
12084 2004-03-23 Martin Baulig <martin@ximian.com>
12086 * ecore.cs (MethodGroupExpr.Name): Use
12087 TypeManager.CSharpSignature() instead of just the name.
12089 * expression.cs (Invocation.OverloadResolve): Provide better error
12091 (Invocation.DoResolve): OverloadResolve() never returns null
12092 without reporting an error, so removed the error -6 reporting here.
12094 2004-03-23 Martin Baulig <martin@ximian.com>
12096 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
12099 * cs-parser.jay (delegate_declaration): Support generic delegates.
12101 * delegate.cs: Support generic delegates.
12103 2004-03-22 Martin Baulig <martin@ximian.com>
12105 * expression.cs (Invocation.InferParamsTypeArguments): New static
12106 method; does type inference for params arguments.
12108 2004-03-21 Martin Baulig <martin@ximian.com>
12110 * typemanager.cs (TypeManager.IsGenericMethod): New public static
12111 method; checks whether a method is a generic method.
12113 * expression.cs (Invocation.InferTypeArguments): New static method;
12114 infer type arguments for generic method invocation.
12116 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
12117 property; we set this to true if we're resolving a generic method
12118 invocation and the user specified type arguments, ie. we're not
12119 doing type inference.
12121 2004-03-20 Martin Baulig <martin@ximian.com>
12123 * class.cs (MethodData.DeclaringType): New public property.
12124 (MethodData.Define): Set DeclaringType here.
12125 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
12126 instead of OperatorMethodBuilder.DeclaringType.
12128 2004-03-20 Martin Baulig <martin@ximian.com>
12130 * cs-tokenizer.cs (xtoken): Return a special
12131 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
12133 * cs-parser.jay (default_value_expression): Switch to the new
12136 2004-03-19 Martin Baulig <martin@ximian.com>
12138 * decl.cs (MemberName): New class. We use this to "construct"
12139 namespace_or_type_name's.
12141 * generics.cs (TypeArguments.GetDeclarations): New public method;
12142 returns the type arguments as a string[] and reports a CS0081 if
12143 one of them is not an identifier.
12145 * class.cs (MemberBase): The .ctor now takes the name as a
12146 MemberName instead of a string.
12147 (MemberBase.ExplicitInterfaceName): Changed type from string to
12149 (MemberBase.DoDefine): If we're an explicit implementation, the
12150 InterfaceType may be a generic instance.
12152 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
12153 (namespace_name): Call MemberName.GetName () to transform the
12154 MemberName into a string and ensure we don't have any type
12156 (type_name): Call MemberName.GetTypeExpression() to transfrom the
12157 MemberName into an expression.
12158 (method_header): Use namespace_or_type_name instead of member_name.
12160 2004-04-07 Miguel de Icaza <miguel@ximian.com>
12162 * rootcontext.cs: Add new types to the boot resolution.
12164 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
12165 MulticastDelegate is not allowed.
12167 * typemanager.cs: Add new types to lookup: System.TypedReference
12170 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
12171 check for TypedReference or ArgIterator, they are not allowed.
12173 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
12174 makes us properly catch 1510 in some conditions (see bug 56016 for
12177 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
12179 * CryptoConvert.cs: update from corlib version
12182 2004-04-05 Miguel de Icaza <miguel@ximian.com>
12184 * class.cs (Indexer.Define): Check indexername declaration
12186 2004-04-05 Marek Safar <marek.safar@seznam.cz>
12188 * attribute.cs (IsClsCompliant): Fixed problem with handling
12189 all three states (compliant, not-compliant, undetected).
12191 2004-03-30 Marek Safar <marek.safar@seznam.cz>
12193 * attribute.cs (Attribute): Location is now public.
12194 (Resolve): Store resolved arguments (pos_values) in attribute class.
12195 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
12196 (GetClsCompliantAttributeValue): New method that gets
12197 CLSCompliantAttribute value.
12198 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
12199 if exists else null.
12200 (AttributeTester): New class for CLS-Compliant verification routines.
12202 * class.cs (Emit): Add CLS-Compliant verification.
12203 (Method.GetSignatureForError): Implemented.
12204 (Constructor.GetSignatureForError): Implemented
12205 (Constructor.HasCompliantArgs): Returns if constructor has
12206 CLS-Compliant arguments.
12207 (Constructor.Emit): Override.
12208 (Construcor.IsIdentifierClsCompliant): New method; For constructors
12209 is needed to test only parameters.
12210 (FieldBase.GetSignatureForError): Implemented.
12211 (TypeContainer): New member for storing base interfaces.
12212 (TypeContainer.FindMembers): Search in base interfaces too.
12214 * codegen.cs (GetClsComplianceAttribute): New method that gets
12215 assembly or module CLSCompliantAttribute value.
12216 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
12218 (ModuleClass.Emit): Add error 3012 test.
12220 * const.cs (Emit): Override and call base for CLS-Compliant tests.
12222 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
12223 state for all decl types.
12224 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
12225 if CLS-Compliant tests are required.
12226 (IsClsCompliaceRequired): New method. Analyze whether code
12227 must be CLS-Compliant.
12228 (IsExposedFromAssembly): New method. Returns true when MemberCore
12229 is exposed from assembly.
12230 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
12231 value or gets cached value.
12232 (HasClsCompliantAttribute): New method. Returns true if MemberCore
12233 is explicitly marked with CLSCompliantAttribute.
12234 (IsIdentifierClsCompliant): New abstract method. This method is
12235 used to testing error 3005.
12236 (IsIdentifierAndParamClsCompliant): New method. Common helper method
12237 for identifier and parameters CLS-Compliant testing.
12238 (VerifyClsCompliance): New method. The main virtual method for
12239 CLS-Compliant verifications.
12240 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
12241 null. I don't know why is null (too many public members !).
12242 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
12243 and get value of first CLSCompliantAttribute that found.
12245 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
12246 (VerifyClsCompliance): Override and add extra tests.
12248 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
12249 clscheck- disable CLS-Compliant verification event if assembly is has
12250 CLSCompliantAttribute(true).
12252 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
12253 ApllyAttribute is now called in emit section as in the other cases.
12254 Possible future Emit integration.
12255 (IsIdentifierClsCompliant): New override.
12256 (VerifyClsCompliance): New override.
12257 (GetEnumeratorName): Returns full enum name.
12259 * parameter.cs (GetSignatureForError): Implemented.
12261 * report.cs (WarningData): New struct for Warning message information.
12262 (LocationOfPreviousError): New method.
12263 (Warning): New method. Reports warning based on the warning table.
12264 (Error_T): New method. Reports error based on the error table.
12266 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12267 verifications are done here.
12269 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12271 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12272 CLSCompliantAttribute.
12273 (all_imported_types): New member holds all imported types from other
12275 (LoadAllImportedTypes): New method fills static table with exported types
12276 from all referenced assemblies.
12277 (Modules): New property returns all assembly modules.
12279 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12281 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12282 throwing a parser error.
12284 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12285 which removes the hardcoded get_/set_ prefixes for properties, as
12286 IL allows for the properties to be named something else.
12290 * expression.cs: Do not override operand before we know if it is
12291 non-null. Fix 56207
12293 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12295 * typemanager.cs: support for pinned variables.
12297 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12299 * decl.cs, typemanager.cs: Avoid using an arraylist
12300 as a buffer if there is only one result set.
12302 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12304 * expression.cs: Make sure you cant call a static method
12305 with an instance expression, bug #56174.
12307 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12309 * class.cs (IsDuplicateImplementation): Improve error reporting to
12310 flag 663 (method only differs in parameter modifier).
12312 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12313 in preprocessor directives.
12315 * location.cs (LookupFile): Allow for the empty path.
12317 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12318 better approach for some of that patch, but its failing with the
12319 CharSet enumeration. For now try/catch will do.
12321 * typemanager.cs: Do not crash if a struct does not have fields.
12324 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12326 * expression.cs: cs0213, cant fix a fixed expression.
12329 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12331 * cs-parser.jay: detect invalid embeded statements gracefully.
12334 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12336 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12339 the invocation type may not be a subclass of the tye of the item/
12340 The type of the item must be a subclass of the invocation item.
12345 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12347 * attribute.cs: Added methods to get a string and a bool from an
12348 attribute. Required to information from AssemblyKeyFileAttribute,
12349 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12350 * codegen.cs: Modified AssemblyName creation to include support for
12351 strongnames. Catch additional exceptions to report them as CS1548.
12352 * compiler.csproj: Updated include CryptoConvert.cs.
12353 * compiler.csproj.user: Removed file - user specific configuration.
12354 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12355 Mono.Security assembly. The original class is maintained and tested in
12356 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12357 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12358 like CSC 8.0 (C# v2) supports.
12359 * Makefile: Added CryptoConvert.cs to mcs sources.
12360 * rootcontext.cs: Added new options for strongnames.
12362 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12364 * driver.cs: For --expect-error, report error code `2'
12365 if the program compiled with no errors, error code `1' if
12366 it compiled with an error other than the one expected.
12368 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12370 * compiler.csproj: Updated for Visual Studio .NET 2003.
12371 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12372 * compiler.sln: Updated for Visual Studio .NET 2003.
12374 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12376 * expression.cs: Fix bug #47234. We basically need to apply the
12377 rule that we prefer the conversion of null to a reference type
12378 when faced with a conversion to 'object' (csc behaviour).
12380 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12382 * statement.cs: Shorter form for foreach, eliminates
12383 a local variable. r=Martin.
12385 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12387 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12388 checks if we can use brtrue/brfalse to test for 0.
12389 * expression.cs: use the above in the test for using brtrue/brfalse.
12390 cleanup code a bit.
12392 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12394 * expression.cs: Rewrite string concat stuff. Benefits:
12396 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12397 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12398 rather than a concat chain.
12400 * typemanager.cs: Add lookups for more concat overloads.
12402 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12404 * expression.cs: Emit shorter il code for array init.
12421 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12423 * statement.cs: Before, two switch blocks would be merged if the
12424 total size of the blocks (end_item - begin_item + 1) was less than
12425 two times the combined sizes of the blocks.
12427 Now, it will only merge if after the merge at least half of the
12432 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12434 * class.cs : csc build fix for GetMethods(). See bug #52503.
12436 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12438 * expression.cs: Make sure fp comparisons work with NaN.
12439 This fixes bug #54303. Mig approved this patch a long
12440 time ago, but we were not able to test b/c the runtime
12443 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12445 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12447 2004-03-19 Martin Baulig <martin@ximian.com>
12449 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12450 two overloads may unify for some type parameter substitutions and
12451 report a CS0408 if appropriate.
12453 2004-03-19 Martin Baulig <martin@ximian.com>
12455 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12456 error here and not in our caller.
12458 2004-03-19 Martin Baulig <martin@ximian.com>
12460 * interface.cs: Completely killed this file.
12461 (Interface): We're now a TypeContainer and live in class.cs.
12463 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12464 argument; we're now also called for interfaces.
12465 (TypeContainer.DefineMembers): Allow this method being called
12467 (TypeContainer.GetMethods): New public method; formerly known as
12468 Interface.GetMethod(). This is used by PendingImplementation.
12469 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12470 it's now private and non-static.
12471 (Interface): Moved this here; it's now implemented similar to
12473 (Method, Property, Event, Indexer): Added `bool is_interface'
12474 argument to their .ctor's.
12475 (MemberBase.IsInterface): New public field.
12477 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12478 instances instead of InterfaceMethod, InterfaceProperty, etc.
12479 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12480 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12482 2004-03-19 Martin Baulig <martin@ximian.com>
12484 * class.cs (MethodCore.IsDuplicateImplementation): New private
12485 method which does the CS0111 checking.
12486 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12487 Use IsDuplicateImplementation().
12489 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12491 * decl.cs (FindMemberToOverride): New method to find the correct
12492 method or property to override in the base class.
12494 - Make Method/Property use the above method to find the
12495 version in the base class.
12496 - Remove the InheritableMemberSignatureCompare as it is now
12499 This patch makes large code bases much faster to compile, as it is
12500 O(n) rather than O(n^2) to do this validation.
12502 Also, it fixes bug 52458 which is that nested classes are not
12503 taken into account when finding the base class member.
12505 Reviewed/Approved by Martin.
12507 2004-03-17 Martin Baulig <martin@ximian.com>
12509 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12510 of type arguments into account; use the `real_num_type_args'
12511 approach like in DoResolveAsTypeStep().
12513 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12516 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12518 * interface.cs: In all interface classes removed redundant
12519 member initialization.
12521 2004-03-16 Martin Baulig <martin@ximian.com>
12523 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12525 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12527 * decl.cs (DefineTypeAndParents): New helper method to define a
12528 type's containers before the type itself is defined; This is a
12529 bug exposed by the recent changes to Windows.Forms when an
12530 implemented interface was defined inside a class that had not been
12533 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12535 (Check): Loop correctly to report errors modifiers
12536 (UNSAFE was not in the loop, since it was the same as TOP).
12538 * interface.cs: Every interface member now takes a ModFlags,
12539 instead of a "is_new" bool, which we set on the base MemberCore.
12541 Every place where we called "UnsafeOk" in the interface, now we
12542 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12543 the unsafe settings from the member declaration instead of the
12544 container interface.
12546 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12548 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12549 `set_indexer_name' to the pending bits (one per type).
12551 We fixed a bug today that was picking the wrong method to
12552 override, since for properties the existing InterfaceMethod code
12553 basically ignored the method name. Now we make sure that the
12554 method name is one of the valid indexer names.
12556 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12558 * support.cs (SeekableStreamReader): Keep track of stream byte
12559 positions and don't mix them with character offsets to the buffer.
12561 Patch from Gustavo Giráldez
12563 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12565 * interface.cs (InterfaceSetGetBase): Removed double member
12566 initialization, base class does it as well.
12568 2004-03-13 Martin Baulig <martin@ximian.com>
12570 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12571 when compiling corlib.
12573 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12575 * convert.cs (ExplicitConversion): We were reporting an error on
12576 certain conversions (object_type source to a value type, when the
12577 expression was `null') before we had a chance to pass it through
12578 the user defined conversions.
12580 * driver.cs: Replace / and \ in resource specifications to dots.
12583 * class.cs: Add check for duplicate operators. Fixes 52477
12585 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12587 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12588 that are in the middle of the statements, not only at the end.
12591 * class.cs (TypeContainer.AddField): No longer set the
12592 `HaveStaticConstructor' flag, now we call it
12593 `UserDefineStaticConstructor' to diferentiate the slightly
12594 semantic difference.
12596 The situation is that we were not adding BeforeFieldInit (from
12597 Modifiers.TypeAttr) to classes that could have it.
12598 BeforeFieldInit should be set to classes that have no static
12603 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12605 And most importantly Zoltan's comment:
12607 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12609 "I think beforefieldinit means 'it's ok to initialize the type sometime
12610 before its static fields are used', i.e. initialization does not need
12611 to be triggered by the first access to the type. Setting this flag
12612 helps the JIT to compile better code, since it can run the static
12613 constructor at JIT time, and does not need to generate code to call it
12614 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12615 this flag for lots of classes like String.
12617 csc sets this flag if the type does not have an explicit static
12618 constructor. The reasoning seems to be that if there are only static
12619 initalizers for a type, and no static constructor, then the programmer
12620 does not care when this initialization happens, so beforefieldinit
12623 This bug prevents the AOT compiler from being usable, since it
12624 generates so many calls to mono_runtime_class_init that the AOT code
12625 is much slower than the JITted code. The JITted code is faster,
12626 because it does not generate these calls if the vtable is type is
12627 already initialized, which is true in the majority of cases. But the
12628 AOT compiler can't do this."
12630 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12632 * class.cs (MethodData.Emit): Refactor the code so symbolic
12633 information is generated for destructors; For some reasons we
12634 were taking a code path that did not generate symbolic information
12637 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12639 * class.cs: Create a Constructor.CheckBase method that
12640 takes care of all validation type code. The method
12641 contains some code that was moved from Define.
12643 It also includes new code that checks for duplicate ctors.
12644 This fixes bug #55148.
12646 2004-03-09 Joshua Tauberer <tauberer@for.net>
12648 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12649 a { ... }-style array creation invokes EmitStaticInitializers
12650 which is not good for reference-type arrays. String, decimal
12651 and now null constants (NullCast) are not counted toward
12652 static initializers.
12654 2004-03-05 Martin Baulig <martin@ximian.com>
12656 * location.cs (SourceFile.HasLineDirective): New public field;
12657 specifies whether the file contains or is referenced by a "#line"
12659 (Location.DefineSymbolDocuments): Ignore source files which
12660 either contain or are referenced by a "#line" directive.
12662 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12664 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12665 direct access to our parent, so check the method inline there.
12667 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12669 * expression.cs (Invocation.EmitCall): Miguel's last commit
12670 caused a regression. If you had:
12675 In Foo the implict this would be null.
12677 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12679 * expression.cs (Invocation.EmitCall): If the method is not
12680 virtual, do not emit a CallVirt to it, use Call.
12682 * typemanager.cs (GetFullNameSignature): Improve the method to
12683 cope with ".ctor" and replace it with the type name.
12685 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12686 as an argument the ConstructorBuilder where it is being defined,
12687 to catch the recursive constructor invocations.
12689 2004-03-16 Martin Baulig <martin@ximian.com>
12691 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12692 ConstructedType, call ResolveType() on it to get the type rather
12693 than just using `expr.Type'.
12695 2004-03-16 Martin Baulig <martin@ximian.com>
12697 * generics.cs (ConstructedType.GetMemberAccess): Take the
12698 EmitContext instead on the TypeExpr and use
12699 ec.TypeContainer.CurrentType/ec.ContainerType.
12701 2004-03-16 Martin Baulig <martin@ximian.com>
12703 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12704 parameters before aliases.
12706 2004-03-16 Martin Baulig <martin@ximian.com>
12708 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12709 New oublic function; checks whether two generic instances may become
12710 equal under some instantiations (26.3.1).
12712 * class.cs (TypeContainer.Define): Call
12713 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12716 2004-03-16 Martin Baulig <martin@ximian.com>
12718 * class.cs (TypeContainer.GetClassBases): Moved
12719 Error_TypeParameterAsBase() here and also check whether the base
12720 class is not an attribute.
12722 2004-03-16 Martin Baulig <martin@ximian.com>
12724 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12726 2004-03-16 Martin Baulig <martin@ximian.com>
12728 * class.cs (Error_TypeParameterAsBase): Use correct error number
12731 2004-03-16 Martin Baulig <martin@ximian.com>
12733 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12736 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12739 2004-03-15 Martin Baulig <martin@ximian.com>
12741 * typemanager.cs (TypeManager.GetFullName): New public method.
12742 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12743 argument; only return members with the correct number of type
12745 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12746 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12747 whether the number of type arguments matches.
12749 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12750 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12752 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12753 field; it's set by the protected .ctor when we're actually a
12754 GenericMemberAccess.
12755 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12756 arguments and pass it to MemberLookupFinal ().
12758 * ecore.cs (Expression.MemberLookup): Added `int
12759 num_type_arguments' argument; only return members with the correct
12760 number of type arguments.
12761 (Expression.MemberLookupFailed): Check whether the MemberLookup
12762 failed because we did not have the correct number of type
12763 arguments; report CS0305 in this case.
12765 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12766 `e.ResolveAsTypeTerminal()' already did so.
12768 2004-03-15 Martin Baulig <martin@ximian.com>
12770 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12771 we're a ConstructedType; in this case, the caller must report an
12772 error (for instance CS0131).
12774 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12775 (TypeArguments.Resolve): Actually report errors here.
12777 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12779 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12780 `set_indexer_name' to the pending bits (one per type).
12782 We fixed a bug today that was picking the wrong method to
12783 override, since for properties the existing InterfaceMethod code
12784 basically ignored the method name. Now we make sure that the
12785 method name is one of the valid indexer names.
12787 2004-03-15 Martin Baulig <martin@ximian.com>
12789 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12790 for generic instances.
12792 2004-03-13 Martin Baulig <martin@ximian.com>
12794 * class.cs (TypeContainer.DefineType): Call
12795 TypeManager.AddUserType() immediately after creating the
12796 TypeBuilder; pass all type parameters when creating the
12799 * decl.cs (DeclSpace.FindNestedType): New public method.
12800 (DeclSpace.FindType): Added `int num_type_args' argument; only
12801 return types with the correct number of type parameters.
12802 (DeclSpace.CountTypeParams): New public property.
12804 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12805 the number of type parameters; defaults to zero.
12807 * generic.cs (TypeArguments.Count): New public property.
12808 (ConstructedType.DoResolveAsTypeStep): First call
12809 ds.FindNestedType() to find out whether we're nested in the
12810 current generic type; in this case, we inherit all type parameters
12811 from the current class.
12813 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12814 num_type_args' argument.
12815 (RootContext.LookupType): Added overloaded version which takes the
12816 number of type arguments; only return types with the correct
12817 number of type arguments.
12819 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12820 checks whether `Type t' has `int num_type_args'.
12822 2004-03-13 Martin Baulig <martin@ximian.com>
12824 * generic.cs (GenericMethod.DefineType): New method; calls
12825 DefineType() on all the type parameters.
12827 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12828 (MethodData.Define): If we're a generic method, call
12829 GenericMethod.DefineType() to define the type parameters.
12831 2004-03-10 Martin Baulig <martin@ximian.com>
12833 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12834 instead of IsAssignableFrom.
12836 2004-03-10 Martin Baulig <martin@ximian.com>
12838 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12840 * support.cs (ParameterData.HasArrayParameter): New property.
12841 (ReflectionParameters.ctor): Take a MethodBase instead of a
12842 ParameterInfo[]. If we have any type parameters, get the generic
12843 method definition and ask it whether we have variable arguments.
12845 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12847 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12848 routines to check if a type is an enumerable/enumerator allow
12849 classes that implement the IEnumerable or IEnumerator interfaces.
12851 * class.cs (Property, Operator): Implement IIteratorContainer, and
12852 implement SetYields.
12854 (Property.Define): Do the block swapping for get_methods in the
12855 context of iterators. We need to check if Properties also
12856 include indexers or not.
12858 (Operator): Assign the Block before invoking the
12859 OperatorMethod.Define, so we can trigger the Iterator code
12862 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12863 Property and Operator classes are not created when we parse the
12864 declarator but until we have the block completed, so we use a
12865 singleton SimpleIteratorContainer.Simple to flag whether the
12866 SetYields has been invoked.
12868 We propagate this setting then to the Property or the Operator to
12869 allow the `yield' to function.
12871 2004-02-25 Marek Safar <marek.safar@seznam.cz>
12873 * codegen.cs: Implemented attribute support for modules.
12874 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
12875 Assembly/Module functionality.
12877 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
12878 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
12879 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
12881 2004-02-16 Marek Safar <marek.safar@seznam.cz>
12883 * interface.cs (FindMembers): The operation is performed on all base
12884 interfaces and not only on the first. It is required for future CLS Compliance patch.
12886 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
12888 * statement.cs, codegen.cs:
12889 This patch deals with patterns such as:
12891 public class List : IEnumerable {
12893 public MyEnumerator GetEnumerator () {
12894 return new MyEnumerator(this);
12897 IEnumerator IEnumerable.GetEnumerator () {
12901 public struct MyEnumerator : IEnumerator {
12906 Before, there were a few things we did wrong:
12907 1) we would emit callvirt on a struct, which is illegal
12908 2) we emited ldarg when we needed to emit ldarga
12909 3) we would mistakenly call the interface methods on an enumerator
12910 type that derived from IEnumerator and was in another assembly. For example:
12912 public class MyEnumerator : IEnumerator
12914 Would have the interface methods called, even if there were public impls of the
12915 method. In a struct, this lead to invalid IL code.
12917 2004-02-11 Marek Safar <marek.safar@seznam.cz>
12919 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
12922 * delegate.cs (Define): Fixed crash when delegate type is undefined.
12924 2004-02-11 Miguel de Icaza <miguel@ximian.com>
12926 * cs-parser.jay: Fix small regression: we were not testing V2
12927 compiler features correctly.
12929 * interface.cs: If the emit context is null, then create one
12931 2004-02-09 Marek Safar <marek.safar@seznam.cz>
12933 * decl.cs (GetSignatureForError): New virtual method to get full name
12934 for error messages.
12936 * attribute.cs (IAttributeSupport): New interface for attribute setting.
12937 Now it is possible to rewrite ApplyAttributes method to be less if/else.
12939 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
12940 Duplicated members and code in these classes has been removed.
12941 Better encapsulation in these classes.
12943 2004-02-07 Miguel de Icaza <miguel@ximian.com>
12945 * assign.cs (Assign.DoResolve): When dealing with compound
12946 assignments, there is a new rule in ECMA C# 2.4 (might have been
12947 there before, but it is documented here) that states that in:
12951 If b is of type int, and the `op' is a shift-operator, then the
12952 above is evaluated as:
12956 * expression.cs (Binary.ResolveOperator): Instead of testing for
12957 int/uint/long/ulong, try to implicitly convert to any of those
12958 types and use that in pointer arithmetic.
12960 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
12961 method to print information for from the type, not from the
12962 null-method we were given.
12964 2004-02-01 Duncan Mak <duncan@ximian.com>
12966 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
12967 parsing for cmd, fixes bug #53694.
12969 2004-02-04 Marek Safar <marek.safar@seznam.cz>
12971 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
12972 in the member name duplication tests. Property and operator name duplication
12973 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
12975 2004-02-03 Marek Safar <marek.safar@seznam.cz>
12977 * interface.cs (PopulateMethod): Fixed crash when interface method
12978 returns not existing type (error test cs0246-3.cs).
12980 2004-02-02 Ravi Pratap M <ravi@ximian.com>
12982 * cs-parser.jay (interface_accessors): Re-write actions to also
12983 store attributes attached to get and set methods. Fix spelling
12986 (inteface_property_declaration): Modify accordingly.
12988 (InterfaceAccessorInfo): New helper class to store information to pass
12989 around between rules that use interface_accessors.
12991 * interface.cs (Emit): Apply attributes on the get and set
12992 accessors of properties and indexers too.
12994 * attribute.cs (ApplyAttributes): Modify accordingly to use the
12995 right MethodBuilder when applying attributes to the get and set accessors.
12997 2004-01-31 Miguel de Icaza <miguel@ximian.com>
12999 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
13001 2004-01-26 Miguel de Icaza <miguel@ximian.com>
13003 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
13005 2004-01-25 Miguel de Icaza <miguel@ximian.com>
13007 * cs-parser.jay: Remove YIELD token, instead use the new grammar
13008 changes that treat `yield' specially when present before `break'
13009 or `return' tokens.
13011 * cs-tokenizer.cs: yield is no longer a keyword.
13013 2004-01-23 Marek Safar <marek.safar@seznam.cz>
13015 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
13016 setting for default constructors.
13017 For default constructors are almost every time set wrong Modifier. The
13018 generated IL code has been alright. But inside mcs this values was
13019 wrong and this was reason why several of my CLS Compliance tests
13022 2004-02-27 Martin Baulig <martin@ximian.com>
13024 * generics.cs (ConstructedType.ResolveType): Make the nested type
13025 stuff actually work.
13027 2004-02-25 Martin Baulig <martin@ximian.com>
13029 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
13030 property; returns the type parameters just from the current type,
13031 ie. with the ones from outer classes.
13032 (DeclSpace.LookupGeneric): First search in the current class, then
13034 (DeclSpace.initialize_type_params): When hiding a type parameter
13035 from an outer class, put it into the `type_param_list' anyways.
13037 * expression.cs (MemberAccess.expr): Made this field protected.
13039 * class.cs (TypeContainer.Define): The `CurrentType' just contains
13040 the type parameters from the current class.
13042 * generic.cs (ConstructedType.ResolveType): Support nested generic
13043 types by taking the type parameters which we inherit from outer
13044 classes into account.
13045 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
13046 support for nested generic types.
13048 2004-02-23 Martin Baulig <martin@ximian.com>
13050 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
13051 field and check whether we're nested inside a generic type.
13052 (DeclSpace.ResolveType): If we're resolving to a generic type
13053 definition, create a ConstructedType and return its resolved type.
13054 (DeclSpace.initialize_type_params): New private method;
13055 initializes the `type_param_list' field from the type parameters
13056 from this and all enclosing classes.
13057 (DeclSpace.TypeParameters): Call initialize_type_params() unless
13058 we're already initialized.
13060 2004-02-23 Martin Baulig <martin@ximian.com>
13062 * class.cs (Method.Define): Create the generic method before
13063 calling DoDefine().
13064 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
13065 the TypeContainer one); we use this for generic methods.
13067 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
13068 parent's TypeBuilder.
13070 2004-02-18 Martin Baulig <martin@ximian.com>
13072 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
13073 to check for equality.
13075 2004-02-05 Martin Baulig <martin@ximian.com>
13077 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
13078 `ec.TypeContainer.CurrentType', use it instead of
13079 `ec.ContainerType' to check whether we're in the type's ctor.
13081 2004-01-29 Martin Baulig <martin@ximian.com>
13083 * expression.cs (Invocation.DoResolve): If we're a
13084 `ConstructedType', then we're actually a generic method, so
13085 rewrite the expr as a GenericMemberAccess.
13087 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
13088 here; manually parse it into a string.
13090 2004-01-28 Martin Baulig <martin@ximian.com>
13092 * typemanager.cs (TypeManager.IsEqual): New static method.
13093 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
13094 check for equality instead of using `=='.
13096 2004-01-26 Martin Baulig <martin@ximian.com>
13098 * decl.cs (DeclSpace.CurrentType): New public field.
13100 * expression.cs (This.ResolveBase): If we have an
13101 `ec.TypeContainer.CurrentType', use it instead of
13102 `ec.ContainerType'.
13104 * class.cs (TypeContainer.DefineType): If we're a generic type,
13105 create the `CurrentType' (unresolved).
13106 (TypeContainer.GenericType): New private field.
13107 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
13108 it and store it in `GenericType' before creating the MemberCache.
13109 (TypeContainer.GetMembers): If we have a `GenericType', call
13110 TypeManager.FindMembers() on it.
13112 * interface.cs (Interface.GenericType): New private field.
13113 (Interface.DefineType): If we're a generic type, create the
13114 `CurrentType' (unresolved).
13115 (Interface.DefineMembers): If we have a `CurrentType', resolve it
13116 and store it in `GenericType' before creating the MemberCache.
13117 (Interface.GetMembers): If we have a `GenericType', call
13118 TypeManager.FindMembers() on it.
13120 2004-01-22 Martin Baulig <martin@ximian.com>
13122 * cs-parser.jay (namespace_or_type_name): Return an Expression,
13123 not a QualifiedIdentifier. This is what `type_name_expression'
13124 was previously doing.
13125 (type_name_expression): Removed; the code is now in
13126 `namespace_or_type_name'.
13127 (qualified_identifier): Removed, use `namespace_or_type_name'
13129 (QualifiedIdentifier): Removed this class.
13131 2004-01-22 Martin Baulig <martin@ximian.com>
13133 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
13134 not a string as alias name.
13136 2004-01-21 Miguel de Icaza <miguel@ximian.com>
13138 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
13139 #52730 bug, and instead compute correctly the need to use a
13140 temporary variable when requesting an address based on the
13141 static/instace modified of the field and the constructor.
13143 2004-01-21 Martin Baulig <martin@ximian.com>
13145 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
13146 class and namespace before looking up aliases. Fixes #52517.
13148 2004-01-21 Martin Baulig <martin@ximian.com>
13150 * flowanalysis.cs (UsageVector.Merge): Allow variables being
13151 assinged in a 'try'; fixes exception4.cs.
13153 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13154 * class.cs : Implemented parameter-less constructor for TypeContainer
13156 * decl.cs: Attributes are now stored here. New property OptAttributes
13158 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
13160 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
13162 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13164 * typemanager.cs (CSharpSignature): Now reports also inner class name.
13165 (CSharpSignature): New method for indexer and property signature.
13167 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13169 * pending.cs (IsVirtualFilter): Faster implementation.
13171 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13173 * typemanager.cs: Avoid inclusion of same assembly more than once.
13175 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13177 * cs-parser.jay: Fixed problem where the last assembly attribute
13178 has been applied also to following declaration (class, struct, etc.)
13180 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13182 * class.cs: Added error CS0538, CS0539 reporting.
13183 Fixed crash on Microsoft runtime when field type is void.
13185 * cs-parser.jay: Added error CS0537 reporting.
13187 * pending.cs: Added error CS0535 reporting.
13188 Improved error report for errors CS0536, CS0534.
13190 2004-01-20 Miguel de Icaza <miguel@ximian.com>
13192 Merge a few bits from the Anonymous Method MCS tree.
13194 * statement.cs (ToplevelBlock): New class for toplevel methods,
13195 will hold anonymous methods, lifted variables.
13197 * cs-parser.jay: Create toplevel blocks for delegates and for
13198 regular blocks of code.
13200 2004-01-20 Martin Baulig <martin@ximian.com>
13202 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
13203 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
13204 and `NeedExplicitReturn'; added `IsLastStatement'.
13205 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
13206 have a `ReturnLabel' or we're not unreachable.
13208 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
13209 child's reachability; don't just override ours with it. Fixes
13210 #58058 (lluis's example).
13211 (FlowBranching): Added public InTryOrCatch(), InCatch(),
13212 InFinally(), InLoop(), InSwitch() and
13213 BreakCrossesTryCatchBoundary() methods.
13215 * statement.cs (Return): Do all error checking in Resolve().
13216 Unless we are the last statement in a top-level block, always
13217 create a return label and jump to it.
13218 (Break, Continue): Do all error checking in Resolve(); also make
13219 sure we aren't leaving a `finally'.
13220 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
13221 statement in a top-level block.
13222 (Block.Flags): Added `IsDestructor'.
13223 (Block.IsDestructor): New public property.
13225 2004-01-20 Martin Baulig <martin@ximian.com>
13227 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
13229 2004-01-20 Martin Baulig <martin@ximian.com>
13231 * statement.cs (Statement.ResolveUnreachable): New public method.
13232 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
13233 (Block.Resolve): Resolve unreachable statements.
13235 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13237 * expression.cs: We need to fix the case where we do
13238 not have a temp variable here.
13240 * assign.cs: Only expression compound assignments need
13241 temporary variables.
13243 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13245 * flowanalysis.cs: Reduce memory allocation in a few ways:
13246 - A block with no variables should not allocate a bit
13248 - A method with no out parameters does not need any tracking
13249 for assignment of the parameters, so we need not allocate
13252 public readonly Type[] VariableTypes;
13253 public readonly string[] VariableNames;
13254 Are redundant. The data is already stored in the variable
13255 map, so we need not allocate another array for it.
13256 - We need to add alot of checks for if (params | locals) == null
13257 due to the first two changes.
13259 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13261 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13262 implement IMemoryLocation, we store a copy on a local variable and
13263 take the address of it. Patch from Benjamin Jemlich
13265 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13266 to use a special "type_name_expression" rule which reduces the
13267 number of "QualifiedIdentifier" classes created, and instead
13268 directly creates MemberAccess expressions.
13270 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13272 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13273 that fixes #52853. Null literal assignment to ValueType
13275 * class.cs (MethodData.Emit): Instead of checking the name of the
13276 method to determine if its a destructor, create a new derived
13277 class from Method called Destructor, and test for that.
13279 * cs-parser.jay: Create a Destructor object instead of a Method.
13281 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13285 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13287 * expression.cs (Binary.ResolveOperator): Perform an implicit
13288 conversion from MethodGroups to their delegate types on the
13289 Addition operation.
13291 * delegate.cs: Introduce a new class DelegateCreation that is the
13292 base class for `NewDelegate' and `ImplicitDelegateCreation',
13293 factor some code in here.
13295 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13296 conversion from MethodGroups to compatible delegate types.
13298 * ecore.cs (Expression.Resolve): Do not flag error 654
13299 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13300 we allow conversions from MethodGroups to delegate types now.
13302 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13303 assignments in v2 either.
13305 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13307 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13308 static read-only fields in ctors.
13310 Applied patch from Benjamin Jemlich
13312 * expression.cs (UnaryMutator): Avoid leaking local variables.
13314 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13316 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13317 here to return true, as they can be used like this:
13319 (XXX) int.MEMBER ()
13321 Fixed 49836 and all the other dups
13323 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13325 * driver.cs: Implement /win32res and /win32icon.
13327 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13329 * cs-parser.jay: Add a rule to improve error handling for the
13330 common mistake of placing modifiers after the type.
13332 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13334 * cs-parser.jay (interface_event_declaration): Catch
13335 initialization of events on interfaces, and report cs0068
13337 * cs-parser.jay (interface_event_declaration): Catch
13338 initialization of events.
13340 * ecore.cs: Better report missing constructors.
13342 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13343 the error reporting done in the wrong place. Fix.
13345 * expression.cs (Binary.ResolveOperator): Catch the
13346 operator + (E x, E y) error earlier, and later allow for implicit
13347 conversions in operator +/- (E e, U x) from U to the underlying
13350 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13351 52596, if the container class is abstract, the default constructor
13352 is protected otherwise its public (before, we were always public).
13354 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13357 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13358 Jemlich that fixes bug #52597, MCS was generating invalid code for
13359 idisposable structs. Thanks to Ben for following up with this
13362 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13364 * driver.cs: Allow assemblies without code to be generated, fixes
13367 2004-01-07 Nick Drochak <ndrochak@gol.com>
13369 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13371 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13373 * cs-parser.jay: Add rules to improve error reporting if fields or
13374 methods are declared at the namespace level (error 116)
13376 * Add rules to catch event add/remove
13378 2004-01-04 David Sheldon <dave-mono@earth.li>
13380 * expression.cs: Added matching ")" to error message for
13383 2004-01-03 Todd Berman <tberman@gentoo.org>
13385 * ecore.cs, attribute.cs:
13386 Applying fix from #52429.
13388 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13390 * ecore.cs, expression.cs, statement.cs:
13391 Total rewrite of how we handle branching. We
13392 now handle complex boolean expressions with fewer
13393 jumps. As well if (x == 0) no longer emits a ceq.
13395 if (x is Foo) is much faster now, because we generate
13398 Overall, we get a pretty big improvement on our benchmark
13399 tests. The code we generate is smaller and more readable.
13401 I did a full two-stage bootstrap. The patch was reviewed
13402 by Martin and Miguel.
13404 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13406 * cs-parser.jay: Make primary_expression not take a QI.
13407 we dont need this because the member_access rule covers
13408 us here. So we replace the rule with just IDENTIFIER.
13410 This has two good effects. First, we remove a s/r conflict.
13411 Second, we allocate many fewer QualifiedIdentifier objects.
13413 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13415 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13416 set the correct information via SRE. This prevents
13417 hanging on the MS runtime. Fixes #29374.
13419 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13421 * convert.cs: correctly handle conversions to value types
13422 from Enum and ValueType as unboxing conversions.
13424 Fixes bug #52569. Patch by Benjamin Jemlich.
13426 2004-01-02 Ravi Pratap <ravi@ximian.com>
13428 * expression.cs (BetterConversion): Prefer int -> uint
13429 over int -> ulong (csc's behaviour). This fixed bug #52046.
13431 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13433 * decl.cs (MemberCache.FindMembers): now returns a
13436 * typemanager.cs: In general, go with with ^^.
13437 (CopyNewMethods): take an IList.
13438 (RealMemberLookup): Only allocate an arraylist
13439 if we copy from two sets of methods.
13441 This change basically does two things:
13442 1) Fewer array lists allocated due to CopyNewMethods.
13443 2) the explicit cast in MemberList costed ALOT.
13445 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13447 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13448 a hashtable to avoid needless string allocations when an identifier is
13449 used more than once (the common case).
13451 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13453 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13454 is broken, it will not return anything. So, we
13455 have to use the information we have in mcs to
13458 * typemanager.cs: Add a cache for GetInterfaces,
13459 since this will now be used more often (due to ^^)
13461 (GetExplicitInterfaces) New method that gets the
13462 declared, not effective, interfaces on a type
13463 builder (eg, if you have interface IFoo, interface
13464 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13467 This patch makes MCS able to bootstrap itself on
13470 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13472 * expression.cs: Remove the Nop's that Miguel put
13475 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13477 * report.cs, codegen.cs: Give the real stack trace to
13478 the error when an exception is thrown.
13480 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13482 * decl.cs: only allocate hashtables for ifaces if
13485 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13487 * expression.cs: fix the error from cs0121-2.cs
13488 (a parent interface has two child interfaces that
13489 have a function with the same name and 0 params
13490 and the function is called through the parent).
13492 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13494 * class.cs, rootcontext.cs, typmanager.cs: do not
13497 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13499 * codegen.cs: remove stack for the ec flow branching.
13500 It is already a linked list, so no need.
13502 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13504 * Makefile: Allow custom profiler here.
13506 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13508 * typemanager.cs (LookupType):
13509 - Use a static char [], because split takes
13510 a param array for args, so it was allocating
13512 - Do not store true in a hashtable, it boxes.
13514 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13516 * flowanalysis.cs: bytify common enums.
13518 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13520 * modifiers.cs: Add a new set of flags for the
13521 flags allowed on explicit interface impls.
13522 * cs-parser.jay: catch the use of modifiers in
13523 interfaces correctly.
13524 * class.cs: catch private void IFoo.Blah ().
13526 All related to bug #50572.
13528 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13530 * decl.cs: Rewrite the consistant accessability checking.
13531 Accessability is not linear, it must be implemented in
13532 a tableish way. Fixes #49704.
13534 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13536 * expression.cs: Handle negation in a checked context.
13537 We must use subtraction from zero. Fixes #38674.
13539 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13541 * class.cs: Ignore static void main in DLLs.
13542 * rootcontext.cs: Handle the target type here,
13543 since we are have to access it from class.cs
13544 * driver.cs: account for the above.
13546 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13548 * report.cs: Give line numbers and files if available.
13550 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13552 * driver.cs: Implement /addmodule.
13554 * typemanager.cs: Change 'modules' field so it now contains Modules not
13557 2003-12-20 Martin Baulig <martin@ximian.com>
13559 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13560 (FieldBase.IsAssigned): Removed this field.
13561 (FieldBase.SetAssigned): New public method.
13562 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13564 2003-12-20 Martin Baulig <martin@ximian.com>
13566 * expression.cs (LocalVariableReference.DoResolve): Don't set
13567 `vi.Used' if we're called from DoResolveLValue().
13569 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13570 returns the usage vector it just merged into the current one -
13571 pass this one to UsageWarning().
13572 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13573 of the `EmitContext', don't call this recursively on our children.
13575 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13577 * driver.cs: Implement /target:module.
13579 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13581 * support.cs (CharArrayHashtable): New helper class.
13583 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13584 char arrays, not strings, so we can avoid creating a string in
13585 consume_identifier if the identifier is a keyword.
13587 2003-12-16 Martin Baulig <martin@ximian.com>
13589 * statement.cs (LocalInfo.Assigned): Removed this property.
13590 (LocalInfo.Flags): Removed `Assigned'.
13591 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13592 and uses flow analysis.
13593 (Block.UsageWarning): Made this method private.
13594 (Block.Resolve): Call UsageWarning() if appropriate.
13596 * expression.cs (LocalVariableReference.DoResolve): Always set
13597 LocalInfo.Used here.
13599 2003-12-13 Martin Baulig <martin@ximian.com>
13601 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13602 any value here; we're now using flow analysis to figure out
13603 whether a statement/block returns a value.
13605 2003-12-13 Martin Baulig <martin@ximian.com>
13607 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13609 (FlowBranching.MergeFinally): Don't call
13610 `branching.CheckOutParameters()' here, this is called in
13612 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13613 when adding the `finally' vector.
13615 2003-12-13 Martin Baulig <martin@ximian.com>
13618 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13619 actually work and also fix #48962.
13621 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13623 * decl.cs: Do not check System.Object for nested types,
13624 since we know it does not have any. Big bang for buck:
13627 Run 1: 8.35 seconds
13628 Run 2: 8.32 seconds
13629 corlib: 17.99 seconds
13631 Run 1: 8.17 seconds
13632 Run 2: 8.17 seconds
13633 corlib: 17.39 seconds
13635 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13637 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13638 time we are returning 0 members, so we save alot here.
13640 2003-12-11 Martin Baulig <martin@ximian.com>
13642 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13643 `MergeChild()', also just take the `FlowBranching' as argument;
13644 call Merge() on it and return the result.
13645 (FlowBranching.Merge): We don't need to do anything if we just
13648 2003-12-11 Martin Baulig <martin@ximian.com>
13650 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13651 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13652 Maurer for this idea.
13654 2003-12-11 Martin Baulig <martin@ximian.com>
13656 * flowanalysis.cs (MergeResult): This class is now gone; we now
13657 use the `UsageVector' for this. The reason for this is that if a
13658 branching just has one sibling, we don't need to "merge" them at
13659 all - that's the next step to do.
13660 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13663 2003-12-11 Martin Baulig <martin@ximian.com>
13665 Reworked flow analyis and made it more precise and bug-free. The
13666 most important change is that we're now using a special `Reachability'
13667 class instead of having "magic" meanings of `FlowReturns'. I'll
13668 do some more cleanups and optimizations and also add some more
13669 documentation this week.
13671 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13672 largely reworked this class.
13673 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13674 the new `Reachability' class instead of having "magic" values here.
13675 (FlowBranching): We're now using an instance of `Reachability'
13676 instead of having separate `Returns', `Breaks' etc. fields.
13678 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13679 based on flow analysis; ignore the return value of block.Emit ().
13681 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13683 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13684 if they are private.
13686 2003-12-09 Martin Baulig <martin@ximian.com>
13688 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13689 call them directly on the UsageVector.
13691 2003-12-09 Martin Baulig <martin@ximian.com>
13693 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13694 Changed return type from `FlowReturns' to `Reachability'.
13696 2003-12-09 Martin Baulig <martin@ximian.com>
13698 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13699 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13700 `Reachable' fields with a single `Reachability' one.
13702 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13704 * class.cs (FindMembers): Remove foreach's.
13709 Run 1: 8.74 seconds
13710 Run 2: 8.71 seconds
13713 Run 1: 8.64 seconds
13714 Run 2: 8.58 seconds
13717 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13722 This patch does a few things:
13723 1. EmptyStatement is now a singleton, so it is never reallocated.
13724 2. All blah is EmptyStatement constructs have been changed to
13725 blah == EmptyStatement.Value, which is much faster and valid
13726 now that EmptyStatement is a singleton.
13727 3. When resolving a block, rather than allocating a new array for
13728 the non-empty statements, empty statements are replaced with
13729 EmptyStatement.Value
13730 4. Some recursive functions have been made non-recursive.
13731 Mainly the performance impact is from (3), however (1) and (2) are needed for
13732 this to work. (4) does not make a big difference in normal situations, however
13733 it makes the profile look saner.
13738 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13739 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13740 Total memory allocated: 56397 KB
13743 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13744 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13745 Total memory allocated: 55666 KB
13747 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13749 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13750 than the hashtable in a hashtable version
13752 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13753 we always end up concating a string. This results in a huge perf
13754 loss, because many strings have to be tracked by the GC. In this
13755 patch, we first use a hashtable that works with two keys, so that
13756 the strings do not need to be concat'ed.
13760 Run 1: 8.74 seconds
13761 Run 2: 8.71 seconds
13764 Run 1: 8.65 seconds
13765 Run 2: 8.56 seconds
13767 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13769 * Makefile: Add a new target `do-time' that does a quick and simple
13770 profile, leaving easy to parse output.
13772 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13774 * codegen.cs (Init): Create the dynamic assembly with
13775 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13777 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13779 * support.cs: Make the PtrHashtable use only one
13780 instance of its comparer.
13782 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13784 * typemanager.cs: Fix lookup of GetNamespaces.
13786 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13788 * expression.cs: Removed redundant line.
13790 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13791 ArrayLists, use for loops with bounds.
13793 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13796 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13797 arraylists, use for loop with bounds.
13799 The above three changes give us a 0.071 second performance
13800 improvement out of 3.294 seconds down to 3.223. On my machine
13801 the above changes reduced the memory usage by 1,387 KB during
13802 compiler bootstrap.
13804 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13805 QualifiedIdentifiers. Before we created a new string through
13806 concatenation, and mostly later on, the result would be
13807 manipulated by DecomposeQI through string manipulation.
13809 This reduced the compiler memory usage for bootstrapping from
13810 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13811 compile times in 0.05 seconds.
13813 2003-11-28 Dick Porter <dick@ximian.com>
13815 * support.cs: Do string compares with the Invariant culture.
13823 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13824 the comparison is done with the Invariant culture.
13826 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13828 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13829 GetEnumerator method.
13831 (ProbeCollectionType): Iterate starting at the most specific type
13832 upwards looking for a GetEnumerator
13834 * expression.cs: Shift count can be up to 31 for int/uint and 63
13837 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13839 * statement.cs (Block.LookupLabel): Also look for the label on the
13840 children blocks. Use a hash table to keep track of visited
13843 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13844 we actually did transform the other operand, otherwise fall back
13845 to the common codepath that casts to long.
13847 * cs-tokenizer.cs: Use the same code pattern as the int case.
13848 Maybe I should do the parsing myself, and avoid depending on the
13849 Parse routines to get this done.
13851 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13853 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13854 which fixes bug 51347. This time test it.
13856 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13857 attributes for example can not tell the difference between these.
13858 The difference was only a syntax feature of the language.
13860 * attribute.cs: Apply attributes to delegates.
13862 * delegate.cs: Call the apply attributes method.
13864 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13866 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13867 comparing 0 vs Byte.MinValue, not the value
13869 (ImplicitConversionRequired): When reporting a conversion error,
13870 use error 31 to print out the constant error instead of the
13873 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13874 which fixes bug 51347.
13876 2003-11-22 Miguel de Icaza <miguel@ximian.com>
13878 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
13879 which fixes the -warnaserror command line option.
13881 2003-11-21 Miguel de Icaza <miguel@ximian.com>
13883 * cfold.cs (DoNumericPromotions): During constant folding of
13884 additions on UIntConstant, special case intconstants with
13885 IntConstants like we do on the expression binary operator.
13887 2003-11-12 Miguel de Icaza <miguel@ximian.com>
13889 * convert.cs (ImplicitReferenceConversion): We were missing a case
13890 (System.Enum are not value types or class types, so we need to
13891 classify them separatedly).
13893 * driver.cs: We do not support error 2007.
13895 2003-11-12 Jackson Harper <jackson@ximian.com>
13897 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
13898 system directory. Also use the full file name so users can
13899 libraries names mscorlib-o-tron.dll in a non system dir.
13901 2004-01-04 David Sheldon <dave-mono@earth.li>
13903 * expression.cs: Added matching ")" to error message for CS0077.
13905 2003-12-19 Martin Baulig <martin@ximian.com>
13907 * typemanager.cs (TypeManager.IsEqualGenericType): New public
13908 static method; see documentation in the method.
13909 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
13911 * convert.cs (Convert.ImplicitReferenceConversion,
13912 Convert.ImplicitReferenceConversionExists): Add support for
13913 generic type declarations; see gen-36.cs.
13915 2003-12-19 Martin Baulig <martin@ximian.com>
13917 * pending.cs (Pending.InterfaceMethod): Use
13918 `Type.IsAssignableFrom()' instead of `=='.
13920 2003-12-18 Martin Baulig <martin@ximian.com>
13922 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
13925 * convert.cs (Convert.ImplicitStandardConversionExists): Use
13926 `expr_type.Equals (target_type)' instead of `=='.
13928 2003-12-08 Martin Baulig <martin@ximian.com>
13930 * generics.cs (Constraints.Types): Removed.
13931 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
13933 (Constraints.ResolveTypes): New public method; resolves the
13934 TypeExpr's to Type's.
13935 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
13936 longer takes the constraints.
13937 (TypeParameter.DefineMethod): Likewise.
13938 (TypeParameter.DefineType): New public method. Calls
13939 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
13942 2003-12-08 Martin Baulig <martin@ximian.com>
13944 * convert.cs (Convert.ImplicitConversionStandard): Use
13945 `expr_type.Equals (target_type)' instead of `=='.
13947 2003-12-08 Martin Baulig <martin@ximian.com>
13949 * typemanager.cs (TypeManager.GetReferenceType): Call
13950 `Type.MakeByRefType ()'.
13952 2003-12-08 Martin Baulig <martin@ximian.com>
13954 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
13955 just has some special meaning in some situations. For instance,
13956 it is allowed to use `where' as the name of a variable etc.
13958 2003-12-04 Martin Baulig <martin@ximian.com>
13960 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13961 `Type.MakeArrayType()' for array types.
13963 2003-11-18 Miguel de Icaza <miguel@ximian.com>
13965 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
13968 (SizeOf.DoResolve): assign the `type_queried' field. This gets
13971 2003-11-16 Martin Baulig <martin@ximian.com>
13973 * codegen.cs (EmitContext.IsGeneric): Removed.
13975 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
13976 ResolveGeneric() on the DeclSpace.
13978 2003-11-16 Martin Baulig <martin@ximian.com>
13980 * generic.cs (TypeArguments.Resolve):
13981 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
13982 `ResolveType()' on it to get the Type.
13984 2003-11-15 Martin Baulig <martin@ximian.com>
13986 * generic.cs (ConstructedType.GetInterfaces): Override this.
13988 2003-11-14 Martin Baulig <martin@ximian.com>
13990 * interface.cs (Interface.DefineType): Define all type parameters
13991 before adding the interfaces we inherit.
13993 2003-11-11 Martin Baulig <martin@ximian.com>
13995 * generic.cs (ConstructedType.ResolveType): Always call
13996 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
13998 2003-11-10 Martin Baulig <martin@ximian.com>
14000 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
14001 (TypeManager.InitCoreTypes): Initialize them here, but instead of
14002 calling `ResolveType()' on them, directly assign their `Type'.
14004 2003-11-08 Martin Baulig <martin@ximian.com>
14006 * generic.cs (ConstructedType): Override `IsClass' etc.
14008 2003-11-08 Martin Baulig <martin@ximian.com>
14010 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
14011 return value and the `out parent' parameter.
14012 (TypeContainer.DefineType): Moved the CS0644 check into
14013 GetClassBases(). Don't pass the interface types to the
14014 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
14015 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
14017 * ecore.cs (TypeExpr.IsAttribute): New property.
14018 (TypeExpr.GetInterfaces): New method.
14020 * interface.cs (Interface.GetInterfaceTypeByName): Return a
14021 TypeExpr instead of a Type.
14022 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
14023 (Interface.DefineType): Don't pass the interface types to the
14024 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
14025 them later and then call `TypeBulider.AddInterfaceImplementation()'.
14027 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
14028 instead of a `Type[]'.
14029 (TypeManager.RegisterBuilder): Likewise.
14030 (TypeManager.AddUserInterface): Likewise.
14031 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
14032 `Type[]' and also return a `TypeExpr[]'.
14033 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
14035 2003-11-08 Martin Baulig <martin@ximian.com>
14037 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
14040 2003-11-08 Martin Baulig <martin@ximian.com>
14042 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
14043 TypeManager.ResolveExpressionTypes().
14045 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
14046 instead of an Expression.
14047 (TypeExpr): This is now an abstract base class for `TypeExpression'.
14048 (TypeExpression): New public class; formerly known as `TypeExpr'.
14050 * expression.cs (ComposedCast): Derive from TypeExpr.
14052 * typemanager.cs (TypeManager.system_*_expr): These are now
14053 TypExpr's instead of Expression's.
14054 (TypeManager.ResolveExpressionTypes): New public static function;
14055 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
14058 2003-11-06 Miguel de Icaza <miguel@ximian.com>
14060 * expression.cs (New.DoResolve): Do not dereference value that
14061 might be a null return.
14063 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
14064 sure that the constant value has the right type. Fixes an
14065 unreported bug, similar to 50425.
14067 * const.cs (Const.LookupConstantValue): Call
14068 ImplicitStandardConversionExists before doing a conversion to
14069 avoid havng the TypeManager.ChangeType do conversions.
14071 Reduced the number of casts used
14073 (Const.ChangeType): New routine to enable reuse of the constant
14074 type changing code from statement.
14076 * typemanager.cs (ChangeType): Move common initialization to
14077 static global variables.
14081 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
14082 every value type to go through, even if it was void. Fix that.
14084 * cs-tokenizer.cs: Use is_identifier_start_character on the start
14085 character of the define, and the is_identifier_part_character for
14086 the rest of the string.
14088 2003-11-05 Miguel de Icaza <miguel@ximian.com>
14090 * expression.cs (UnaryMutator.EmitCode): When I updated
14091 LocalVariableReference.DoResolve, I overdid it, and dropped an
14092 optimization done on local variable references.
14094 2003-11-04 Miguel de Icaza <miguel@ximian.com>
14096 * ecore.cs: Convert the return from Ldlen into an int.
14098 2003-10-20 Miguel de Icaza <miguel@ximian.com>
14100 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
14101 the accessibility, this is a special case for toplevel non-public
14102 classes (internal for instance).
14104 2003-10-20 Nick Drochak <ndrochak@gol.com>
14106 * ecore.cs: Fix typo and build. Needed another right paren.
14108 2003-10-19 Miguel de Icaza <miguel@ximian.com>
14110 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
14111 `internal' case regular and protected, but not allowing protected
14112 to be evaluated later. Bug 49840
14114 2003-10-15 Miguel de Icaza <miguel@ximian.com>
14116 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
14117 to kb.Nlast, and not the kb.nFirst to isolate the switch
14120 Extract the underlying type, so enumerations of long/ulong are
14121 treated like long/ulong.
14123 2003-10-14 Miguel de Icaza <miguel@ximian.com>
14125 * expression.cs (New): Overload the meaning of RequestedType to
14126 track the possible creation of the NewDelegate type, since
14127 DoResolve is invoked more than once for new constructors on field
14130 See bugs: #48800 and #37014
14132 * cs-parser.jay (declare_local_constants): Take an arraylist
14133 instead of a single constant.
14135 (local_constant_declaration): It should take a
14136 constant_declarators, not a constant_declarator. Fixes 49487
14138 * convert.cs: Fix error report.
14140 2003-10-13 Jackson Harper <jackson@ximian.com>
14142 * typemanager.cs (TypeToCoreType): Add float and double this fixes
14145 2003-11-03 Martin Baulig <martin@ximian.com>
14147 * expression.cs (ArrayAccess.GetStoreOpcode): Added
14148 `out bool has_type_arg'; if set, we need to pass the type to
14150 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
14151 Stelem_Any/Ldelem_Any for generic parameters.
14153 2003-11-02 Martin Baulig <martin@ximian.com>
14155 * expression.cs (Invocation.EmitCall): Use
14156 `TypeManager.IsValueType()' to check whether it's a value type.
14157 Don't set `struct_call' when calling a method on a type parameter.
14159 2003-11-02 Martin Baulig <martin@ximian.com>
14161 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
14162 and removed the TypeBuilder argument.
14164 * typemanager.cs (TypeManager.IsValueType): Return
14165 `t.IsGenericParameter || t.IsValueType'.
14167 2003-10-25 Martin Baulig <martin@ximian.com>
14169 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
14170 call ConstructedType.Resolve() on it.
14172 * generic.cs (ConstructedType.Resolve): Set `type' on success.
14174 2003-10-25 Martin Baulig <martin@ximian.com>
14176 * class.cs (TypeContainer.GetClassBases): Changed
14177 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
14178 CS8214 reporting here.
14179 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
14180 instead of a `Type' for our parent. In case of a recursive
14181 declaration (see tests/gen-23.cs for an example), our parent is a
14182 ConstructedType and it doesn't have its type set. So, first
14183 create our own TypeBuilder, then call constructed.Resolve() to get
14184 the parent's type and finally TypeBuilder.SetParent() it.
14186 * ecore.cs (TypeExpr.Name): New public virtual property.
14189 (ConstructedType): We're now a TypeExpr and not just an Expression.
14190 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
14191 arguments here; this is done later.
14192 (ConstructedType.Resolve): New public method to resolve the type
14193 arguments and bind them.
14195 2003-10-21 Martin Baulig <martin@ximian.com>
14197 * convert.cs: Use `TypeManager.IsValueType' instead of
14198 'type.IsValueType' everywhere.
14200 * typemanager.cs (TypeManager.IsValueType): Return true for type
14201 parameters. The reason for this is that we need to box a type
14202 parameter when converting it to a reference type.
14204 * cs-parser.jay: Added support for default value expressions.
14206 * generics.cs (DefaultValueExpression): New public class.
14208 2003-10-17 Martin Baulig <martin@ximian.com>
14210 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
14211 TypeContainer so we can also use this for Interfaces.
14212 (TypeParameter.Resolve): Likewise.
14214 * interface.cs (Interface.DefineType): Added support for generic
14217 * cs-parser.jay: Added support for generic structs and interfaces.
14219 2003-10-17 Martin Baulig <martin@ximian.com>
14221 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
14222 call generic methods :-)
14224 2003-10-16 Martin Baulig <martin@ximian.com>
14226 * cs-parser.jay (namespace_or_type_name): Only create a
14227 GenericMemberAccess if we actually have type arguments.
14229 2003-10-13 Martin Baulig <martin@ximian.com>
14231 * class.cs (Method.Define): If we're a generic method, call
14232 TypeBuilder.DefineGenericMethod () before resolving
14234 (MethodData): Added .ctor which takes an additional MethodBuilder
14235 argument; this is used for generic methods.
14236 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
14237 we already have a MethodBuilder.
14239 2003-10-10 Martin Baulig <martin@ximian.com>
14241 * class.cs (Method): Added .ctor which takes a `GenericMethod'
14242 instead of a `DeclSpace'. This is used for generic methods.
14244 * cs-parser.jay (method_header): Added support for generic
14245 methods; create a `GenericMethod' instance and pass it to the
14246 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
14247 parameters and locals.
14249 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
14250 since we already have the location. Check whether we're a generic
14251 type declaration or a generic method and create the correct type
14254 * generic.cs (TypeParameter.DefineMethod): New public method.
14255 (GenericMethod): New public class; derives from DeclSpace and is
14256 used for generic methods.
14258 2003-10-09 Martin Baulig <martin@ximian.com>
14260 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14262 (MethodCore.DoDefineParameters): Removed the TypeContainer
14263 argument; use the DeclSpace which was passed to the .ctor instead.
14264 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14265 TypeContainer; we only need a DeclSpace here.
14267 2003-10-09 Martin Baulig <martin@ximian.com>
14269 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14271 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14272 EmitContext's .ctor.
14274 2003-10-09 Martin Baulig <martin@ximian.com>
14276 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14277 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14278 AsAccessible(), moved them as well.
14280 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14282 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14284 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14285 generation for >=, as spotted by Paolo, bug 48679.
14286 Patch from David Waite.
14288 * cs-tokenizer.cs: Add handling for #pragma.
14290 * cs-parser.jay: Allow for both yield and yield return in the
14291 syntax. The anti-cobolization of C# fight will go on!
14293 * class.cs (TypeBuilder.DefineType): Catch error condition here
14294 (Parent.DefineType erroring out and returning null).
14296 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14297 coping with enumerations variables, we were mistakenly processing
14298 them as a regular value type instead of built-in types. Fixes the
14301 * typemanager.cs (IsBuiltinOrEnum): New method.
14303 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14305 * cs-parser.jay: Upgrade: yield now needs the return clause.
14307 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14309 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14311 2003-09-29 Martin Baulig <martin@ximian.com>
14313 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14314 inflated generic methods.
14316 * generics.cs (ConstructedType): Distinguish between open and
14317 closed constructed types; correctly resolve the arguments.
14319 2003-09-22 Martin Baulig <martin@ximian.com>
14321 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14322 all type arguments meet their constraints.
14324 2003-09-19 Martin Baulig <martin@ximian.com>
14326 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14327 `MemberCache parent' argument. Normally, an interface doesn't
14328 have a parent type except System.Object, but we use this in gmcs
14329 for generic type parameters.
14331 2003-09-18 Martin Baulig <martin@ximian.com>
14333 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14334 on `type.IsInterface'; don't check whether the type has a parent
14335 to determine whether it's an interface.
14337 2003-09-17 Martin Baulig <martin@ximian.com>
14339 * generic.cs (ConstructedType.ToString): Always use `name' as the
14342 2003-09-15 Martin Baulig <martin@ximian.com>
14344 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14346 * generic.cs (Constraints.Resolve): New public method; this is
14347 called to resolve the constraint types and to check whether all
14348 the constraints are correct.
14349 (Constraints.Types): New public property.
14350 (TypeParameter.Resolve): New public method; resolves all the
14351 type's constraints.
14353 * class.cs (TypeContainer.DefineType): Call
14354 TypeParameter.Resolve() before actually defining the type.
14356 2003-09-15 Martin Baulig <martin@ximian.com>
14358 * class.cs (TypeContainer.DefineType): Added an error flag to
14359 avoid reporting duplicate CS0146's ("class definition is
14362 * driver.cs (Driver.MainDriver): Abort if
14363 RootContext.ResolveTree() reported any errors.
14365 2003-09-07 Martin Baulig <martin@ximian.com>
14367 * report.cs (Error, Warning): Added overloaded versions which take
14368 a `params object[] args' and call String.Format().
14370 2003-09-07 Martin Baulig <martin@ximian.com>
14372 * decl.cs (DeclSpace..ctor): Don't call
14373 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14374 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14375 (DeclSpace.RecordDecl): New method.
14377 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14379 2003-09-02 Ravi Pratap <ravi@ximian.com>
14381 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14382 value attributes to be applied to ParameterBuilders.
14384 * class.cs (MethodCore.LabelParameters): Make static and more
14385 generic so that it can be used from other places - like interface
14386 methods, for instance.
14388 * interface.cs (Interface.Emit): Call LabelParameters before
14389 emitting attributes on the InterfaceMethod.
14391 2003-09-07 Martin Baulig <martin@ximian.com>
14393 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14394 if the number of type parameters doesn't match.
14396 2003-09-04 Martin Baulig <martin@ximian.com>
14398 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14399 for arrays of generic type params (ie. `!0[]').
14401 2003-09-04 Martin Baulig <martin@ximian.com>
14403 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14406 2003-09-04 Martin Baulig <martin@ximian.com>
14408 * decl.cs (DeclSpace.LookupGeneric): New method.
14409 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14412 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14413 argument, not just a string.
14414 (TypeParameter.Define): New public method; this is called to
14415 actually define the generic parameter; after this, you can use the
14416 new `Type' property to get the type.
14418 2003-09-04 Martin Baulig <martin@ximian.com>
14420 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14421 is now an ArrayList; initialize the result of the `TypeParameters'
14423 (DeclSpace.GetGenericData): Removed.
14424 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14425 implement this in a different way.
14426 (DeclSpace.GetTypeParameters): Removed; there's now a
14427 `TypeParameters' property.
14428 (DeclSpace.TypeParameters): New public property.
14430 * generic.cs (Constraints): Make this class public.
14431 (TypeParameter): New public class.
14433 2003-09-04 Martin Baulig <martin@ximian.com>
14435 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14436 generic parameters.
14438 * class.cs (TypeContainer.DefineType): Call
14439 TypeBuilder.DefineGenericParameter () on all generic parameters if
14440 this is a generic type.
14442 2003-08-28 Martin Baulig <martin@ximian.com>
14444 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14447 * sample-hello.cs: Compile this with gmcs: "gmcs
14448 /r:sample-stack.dll sample-hello.cs".
14450 2003-08-28 Martin Baulig <martin@ximian.com>
14452 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14453 the parameters to the generic type.
14455 2003-08-28 Martin Baulig <martin@ximian.com>
14457 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14459 2003-08-28 Martin Baulig <martin@ximian.com>
14461 * cs-parser.jay (opt_type_argument_list): Use
14462 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14463 (primary_expression): Replace `qualified_identifier' with `type_name'.
14464 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14466 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14467 parser to check whether it is syntactically a type parameter list;
14468 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14471 2003-08-26 Martin Baulig <martin@ximian.com>
14473 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14474 resolving aliases; fixes #47927.
14476 2003-08-26 Martin Baulig <martin@ximian.com>
14478 * statement.cs (Using.DoResolve): This is internally emitting a
14479 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14480 do not always return. Fixes #47681.
14482 2003-08-26 Martin Baulig <martin@ximian.com>
14484 * decl.cs (MemberCore): Moved WarningNotHiding(),
14485 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14487 (AdditionResult): Make this nested in DeclSpace.
14488 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14489 argument; call NamespaceEntry.Define() unless we're nested in a
14492 * namespace.cs (Namespace.DefineName): New public function. This
14493 is called from DeclSpace's .ctor to add
14494 (Namespace.Lookup): Include DeclSpaces in the lookup.
14496 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14498 * const.cs (Const): Derive from MemberBase, not MemberCore.
14500 2003-08-25 Martin Baulig <martin@ximian.com>
14502 * convert.cs (Convert.ExplicitReferenceConversion): When
14503 converting from an interface type to a class, unbox if the target
14504 type is a struct type. Fixes #47822.
14506 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14508 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14511 2003-08-22 Martin Baulig <martin@ximian.com>
14513 * class.cs (TypeManager.DefineType): When defining a nested type,
14514 call DefineType() on our parent; fixes #47801.
14516 2003-08-22 Martin Baulig <martin@ximian.com>
14518 * class.cs (MethodData.Define): While checking if a method is an
14519 interface implementation, improve the test a bit more to fix #47654.
14521 2003-08-22 Martin Baulig <martin@ximian.com>
14523 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14524 correctly; fixes #47722.
14526 2003-08-22 Martin Baulig <martin@ximian.com>
14528 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14529 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14531 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14533 2003-08-22 Martin Baulig <martin@ximian.com>
14535 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14536 can only be assigned in static constructors. Fixes #47161.
14538 2003-08-22 Martin Baulig <martin@ximian.com>
14540 Rewrote and improved the flow analysis code.
14542 * flowbranching.cs (FlowBranching): Make this class abstract.
14543 (FlowBranching.CreateBranching): New static function to create a
14544 new flow branching.
14545 (FlowBranchingBlock, FlowBranchingException): New classes.
14546 (FlowBranching.UsageVector.Type): New public readonly field.
14547 (FlowBranching.UsageVector.Breaks): Removed the setter.
14548 (FlowBranching.UsageVector.Returns): Removed the setter.
14549 (FlowBranching.UsageVector): Added Break(), Return(),
14550 NeverReachable() and Throw() methods to modify the reachability.
14551 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14552 done by FlowBranching.Merge().
14553 (FlowBranching.UsageVector.MergeChild): New method; merges the
14554 merge result into the current vector.
14555 (FlowBranching.Merge): New abstract method to merge a branching.
14557 2003-08-12 Martin Baulig <martin@ximian.com>
14559 * expression.cs (Indirection.CacheTemporaries): Create the
14560 LocalTemporary with the pointer type, not its element type.
14562 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14564 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14565 token was a keyword or not.
14567 Add `error' options where an IDENTIFIER was expected; Provide
14568 CheckToken and CheckIdentifierToken convenience error reporting
14571 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14573 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14574 NameSpaceEntry NameSpaceEntry.
14576 (LookupInterfaceOrClass): Avoid creating a full qualified name
14577 from namespace and name: avoid doing lookups when we know the
14578 namespace is non-existant. Use new Tree.LookupByNamespace which
14579 looks up DeclSpaces based on their namespace, name pair.
14581 * driver.cs: Provide a new `parser verbose' to display the
14582 exception thrown during parsing. This is turned off by default
14583 now, so the output of a failure from mcs is more graceful.
14585 * namespace.cs: Track all the namespaces defined in a hashtable
14588 (IsNamespace): New method
14590 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14592 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14593 we know that we need to concatenate (full typename can never be
14598 * statement.cs: Use a bitfield; Do not initialize to null things
14599 which are done by the constructor by default.
14601 * cs-parser.jay: bug fix, parameter was 4, not 3.
14603 * expression.cs: Just use the property;
14605 * statement.cs: No need for GetVariableInfo method.
14607 2003-08-08 Martin Baulig <martin@ximian.com>
14609 * flowanalysis.cs (FlowReturns): This is now nested in the
14610 `FlowBranching' class.
14611 (MyBitVector): Moved this here from statement.cs.
14612 (FlowBranching.SiblingType): New enum type.
14613 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14615 2003-08-07 Martin Baulig <martin@ximian.com>
14617 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14618 `FlowBranching' class and called `BranchingType'.
14620 2003-08-07 Martin Baulig <martin@ximian.com>
14622 * flowanalysis.cs: Moved all the control flow analysis code into
14625 2003-08-07 Martin Baulig <martin@ximian.com>
14627 * assign.cs (Assign.DoResolve): `target' must either be an
14628 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14631 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14633 * expression.cs (BinaryMethod): This kind of expression is created by the
14634 Binary class if it determines that the operator has to be handled
14637 (BinaryDelegate): This kind of expression is created if we are
14638 dealing with a + or - operator on delegates.
14640 (Binary): remove method, argumetns, and DelegateOperator: when
14641 dealing with methods,
14643 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14645 * statement.cs (Block): use bitfields for the three extra booleans
14646 we had in use. Remove unused topblock parameter.
14648 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14650 * assign.cs: Drop extra unneeded tests.
14652 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14654 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14656 * statement.cs (Foreach): Use VariableStorage instead of
14659 * codegen.cs (VariableStorage): New class used by clients that
14660 require a variable stored: locals or fields for variables that
14661 need to live across yield.
14663 Maybe provide a convenience api for EmitThis+EmitLoad?
14665 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14668 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14670 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14671 RemapParameterLValue): New methods that are used to turn a
14672 precomputed FieldInfo into an expression like this:
14676 The idea is to use this instead of making LocalVariableReference
14677 have more than one meaning.
14679 * cs-parser.jay: Add error production to BASE.
14681 * ecore.cs: Deal with TypeManager.GetField returning null, which
14682 is now a valid return value.
14684 (FieldExprNoAddress): New expression for Fields whose address can
14687 * expression.cs (LocalVariableReference): During the resolve
14688 phases, create new expressions if we are in a remapping context.
14689 Remove code that dealt with remapping here.
14691 (ParameterReference): same.
14693 (ProxyInstance): New expression, like the `This' expression, but
14694 it is born fully resolved. We know what we are doing, so remove
14695 the errors that are targeted to user-provided uses of `this'.
14697 * statement.cs (Foreach): our variable is now stored as an
14698 Expression; During resolution, follow the protocol, dont just
14699 assume it will return this.
14701 2003-08-06 Martin Baulig <martin@ximian.com>
14703 * support.cs (SeekableStreamReader.cs): New public class.
14705 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14706 SeekableStreamReader instead of the normal StreamReader.
14708 2003-08-04 Martin Baulig <martin@ximian.com>
14710 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14711 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14712 deambiguate casts and delegate invocations.
14713 (parenthesized_expression): Use the new tokens to ensure this is
14714 not a cast of method invocation.
14716 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14717 when reading a `)' and Deambiguate_CloseParens () was previously
14720 * expression.cs (ParenthesizedExpression): New class. This is
14721 just used for the CS0075 test.
14722 (Binary.DoResolve): Check for CS0075.
14724 2003-07-29 Ravi Pratap <ravi@ximian.com>
14726 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14727 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14728 reference comparison.
14730 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14731 examine the ReturnType for equality - this is necessary in the
14732 cases of implicit and explicit operators whose signature also
14733 includes the return type.
14735 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14737 * namespace.cs: Cache the result of the namespace computation,
14738 instead of computing it every time.
14740 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14742 * decl.cs: Use a global arraylist that we reuse over invocations
14743 to avoid excesive memory consumption. Reduces memory usage on an
14744 mcs compile by one meg (45 average).
14746 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14747 private, work around that.
14749 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14751 * literal.cs (IntLiteral): Define Zero and One static literals.
14753 * cs-parser.jay (integer_literal): use static literals to reduce
14754 memory usage for the most used literals (0, 1 and -1). 211kb
14755 reduced in memory usage.
14757 Replace all calls to `new ArrayList' with `new
14758 ArrayList(4)' which is a good average number for most allocations,
14759 and also requires only 16 bytes of memory for its buffer by
14762 This reduced MCS memory usage in seven megabytes for the RSS after
14765 2003-07-28 Ravi Pratap <ravi@ximian.com>
14767 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14768 handle params methods the correct way by forming only one
14769 applicable set with params and normal methods in them. Earlier we
14770 were looking at params methods only if we found no normal methods
14771 which was not the correct thing to do.
14773 (Invocation.BetterFunction): Take separate arguments indicating
14774 when candidate and the best method are params methods in their
14777 This fixes bugs #43367 and #46199.
14779 * attribute.cs: Documentation updates.
14781 (CheckAttribute): Rename to CheckAttributeTarget.
14782 (GetValidPlaces): Rename to GetValidTargets.
14784 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14785 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14789 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14791 * codegen.cs: Compute IsGeneric correctly.
14793 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14796 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14797 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14798 regressions, and I was chasing more bugs than I required.
14800 * interface.cs: Use expressions for base type names (like classes
14801 and structs have been doing for a while now), and resolve that.
14802 This patch should probably go into head as well.
14804 This makes it one less user of FindType.
14806 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14808 This compiler can not self host currently. Need to fix that.
14810 * Makefile: compile to `gmcs.exe'
14812 * driver.cs: Turn on v2 by default on gmcs.
14814 * generic.cs (ConstructedType): Does no longer take a container
14815 type argument; That will be taken care of later.
14817 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14818 Use SimpleName to resolve for now, so we can continue the work on
14819 the parser, until we get Type.GetType that understands generics.
14821 (ConstructedType.ToString): Implement
14823 (TypeArguments.Resolve): Resolve the child expressions as types.
14825 * cs-parser.jay: Rename interface_constraints to
14826 type_parameter_constraints
14828 (namespace_or_type_name): Only use constructed types for the basic
14829 construction, we will deal with identifier<...> later.
14831 (type/type_name): No longer call DecomposeQI, as
14832 namespace_or_type_name is always decoded now.
14834 2003-07-22 Ravi Pratap <ravi@ximian.com>
14836 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14837 closely: we eliminate methods in base types when we have an
14838 applicable method in a top-level type.
14840 Please see section 14.5.5.1 for an exact description of what goes
14843 This fixes bug #45127 and a host of other related to corlib compilation.
14845 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14846 array is the method corresponding to the top-level type (this is
14847 because of the changes made to icall.c) so we change this
14850 (MethodGroupExpr.Name): This too.
14852 * typemanager.cs (GetElementType): New method which does the right
14853 thing when compiling corlib.
14855 * everywhere: Make use of the above in the relevant places.
14857 2003-07-22 Martin Baulig <martin@ximian.com>
14859 * cs-parser.jay (invocation_expression): Moved
14860 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14861 `cast_expression', but create a InvocationOrCast which later
14862 resolves to either an Invocation or a Cast.
14864 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14865 method; call this before EmitStatement() to make sure that this
14866 expression can be used as a statement.
14868 * expression.cs (InvocationOrCast): New class; resolves to either
14869 an Invocation or a Cast.
14871 * statement.cs (StatementExpression): Call ResolveStatement() on
14872 the ExpressionStatement before emitting it.
14874 2003-07-21 Martin Baulig <martin@ximian.com>
14876 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
14877 `ref' and `out' attributes match; fixes #46220.
14878 (MemberAccess.ResolveMemberAccess): You can't reference a type
14879 through an expression; fixes #33180.
14880 (Indexers.GetIndexersForType): Don't return the indexers from
14881 interfaces the class implements; fixes #46502.
14883 2003-07-21 Martin Baulig <martin@ximian.com>
14885 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
14886 CS0661 checks; fixes bug #30442.
14888 2003-07-21 Martin Baulig <martin@ximian.com>
14890 * decl.cs (AdditionResult): Added `Error'.
14892 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
14894 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
14895 cs0031.cs actually work.
14897 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14899 * cs-parser.jay (namespace_name): do not use
14900 namespace_or_type_name, use qualified_identifier, because
14901 namespace_or_type_name will soon return a composed expression
14902 instead of a string.
14904 (namespace_or_type_name): Instead of returning a string, now this
14905 production returns an expression.
14907 * codegen.cs (EmitContext): Setup IsGeneric property based on
14908 whether our DeclSpace is generic, our the method is generic.
14910 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
14911 the method is generic.
14913 * cs-parser.jay (type_arguments, opt_type_argument_list,
14914 type_parameters, type_parameter_list, opt_type_parameter_list,
14915 type_parameter,, opt_type_parameter_constraints_clauses,
14916 type_parameter_constraints_clauses,
14917 type_parameter_constraint_clause, type_parameter_constraint,
14918 interface_constraints): Add new production
14920 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
14921 DeclSpace is generic or not.
14923 (DeclSpace.SetParameterInfo): New routine, used to set the
14924 parameter info for a type.
14926 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
14927 returns a GenericTypeExpr
14929 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
14930 generic, lookup the generic argument.
14932 * attribute.cs: Do not allow TypeParameterExpressions in
14935 * class.cs: Do not allow the Main method to be defined in a
14938 * expression.cs (SizeOf): Do not allow generic types to be used as
14939 arguments to sizeof.
14941 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
14942 it: whether a type is generic or not. Only works for types we are
14943 currently building for now.
14945 2003-07-20 Martin Baulig <martin@ximian.com>
14947 * namespace.cs: Fixed that bug which caused a crash when compiling
14948 the debugger's GUI.
14950 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14952 * typemanager.cs (LookupTypeReflection): Never expose types which
14953 are NotPublic, NestedPrivate, NestedAssembly, or
14954 NestedFamANDAssem. We used to return these, and later do a check
14955 that would report a meaningful error, but the problem is that we
14956 would not get the real match, if there was a name override.
14958 2003-07-18 Miguel de Icaza <miguel@ximian.com>
14960 * namespace.cs (Namespace, Name): Do not compute the namespace
14961 name dynamically, compute it in the constructor. This reduced
14962 memory usage by 1697 KB.
14964 * driver.cs: Use --pause to pause at the end.
14966 2003-07-17 Peter Williams <peter@newton.cx>
14968 * Makefile: Change the name of the test target so that it doesn't
14969 conflict with the recursive test target.
14971 2003-07-17 Miguel de Icaza <miguel@ximian.com>
14973 * expression.cs (LocalVariableReference.Emit, EmitAssign,
14974 AddressOf): Do not use EmitThis, that was wrong, use the actual
14977 2003-07-15 Miguel de Icaza <miguel@ximian.com>
14979 * class.cs (MethodData.Define): While checking if a method is an
14980 interface implementation, improve the test: If we are not public
14981 (use new test here: use the computed MethodAttributes directly,
14982 instead of the parsed modifier flags) check if the `implementing'
14983 method comes from an interface or not.
14985 * pending.cs (VerifyPendingMethods): Slightly better error
14988 * makefile: add test target that does the mcs bootstrap.
14990 2003-07-16 Ravi Pratap <ravi@ximian.com>
14992 * interface.cs (Define): Do nothing here since there are no
14993 members to populate etc. Move the attribute emission out of here
14994 since this was just totally the wrong place to put it. Attribute
14995 application happens during the 'Emit' phase, not in the 'Define'
14998 (Emit): Add this method and move the attribute emission here
15000 * rootcontext.cs (EmitCode): Call the Emit method on interface
15003 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15005 * expression.cs (OverloadResolve): Report error only if Location
15006 is not 'Null' which means that there was a probe going on.
15008 2003-07-14 Martin Baulig <martin@ximian.com>
15010 * expression.cs (ConditionalLogicalOperator): New public class to
15011 implement user defined conditional logical operators.
15012 This is section 14.11.2 in the spec and bug #40505.
15014 2003-07-14 Martin Baulig <martin@ximian.com>
15016 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
15018 2003-07-14 Martin Baulig <martin@ximian.com>
15020 * codegen.cs (EmitContext.InFixedInitializer): New public field.
15022 * ecore.cs (IVariable.VerifyFixed): New interface method.
15024 * expression.cs (Unary.ResolveOperator): When resolving the `&'
15025 operator, check whether the variable is actually fixed. Fixes bug
15026 #36055. Set a variable definitely assigned when taking its
15027 address as required by the spec.
15029 * statement.cs (LocalInfo.IsFixed): New field.
15030 (LocalInfo.MakePinned): Set `IsFixed' to true.
15032 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15034 * attribute.cs (Attribute.Resolve): While doing a Member lookup
15035 for .ctors, ensure that we only ask for members declared in the
15036 attribute type (BindingFlags.DeclaredOnly).
15040 * expression.cs (Error_WrongNumArguments): Report error 1501
15041 correctly the way CSC does.
15043 2003-07-13 Martin Baulig <martin@ximian.com>
15045 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
15046 lookup on the fully qualified name, to make things like "X.X" work
15047 where "X.X" is a fully qualified type name, but we also have a
15048 namespace "X" in the using list. Fixes #41975.
15050 2003-07-13 Martin Baulig <martin@ximian.com>
15052 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
15053 function. If we're a CompoundAssign, we need to create an embedded
15054 CompoundAssign, not an embedded Assign.
15055 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
15058 2003-07-13 Martin Baulig <martin@ximian.com>
15060 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
15061 work to fix bug #46088.
15063 2003-07-13 Ravi Pratap <ravi@ximian.com>
15065 * class.cs (Operator.Emit): Do not emit attributes here - it is
15066 taken care of by the Method class that we delegate too. This takes
15067 care of bug #45876.
15069 2003-07-10 Martin Baulig <martin@ximian.com>
15071 * expression.cs (TypeOfVoid): New class.
15072 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
15074 2003-07-10 Martin Baulig <martin@ximian.com>
15076 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
15079 2003-07-10 Martin Baulig <martin@ximian.com>
15081 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
15082 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
15084 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
15086 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
15088 2003-07-10 Martin Baulig <martin@ximian.com>
15090 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
15091 of decimal. Fixes #42850.
15093 NOTE: I also fixed the created byte blob, but this doesn't work on
15094 the MS runtime and csc never produces any byte blobs for decimal
15097 2003-07-10 Martin Baulig <martin@ximian.com>
15099 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
15100 structs; fixes #32068.
15101 (Block.AddChildVariableNames): Fixed #44302.
15103 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15105 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
15107 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15109 * attribute.cs: And this test is onger needed.
15111 2003-07-08 Martin Baulig <martin@ximian.com>
15113 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
15114 inaccessible types. Fixes #36313.
15116 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
15118 * namespace.cs (NamespaceEntry): Create implicit entries for all
15119 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
15120 implicit entries for N1.N2 and N1.
15122 2003-07-08 Martin Baulig <martin@ximian.com>
15124 Rewrote the handling of namespaces to fix a lot of the issues
15125 wrt. `using' aliases etc.
15127 * namespace.cs (Namespace): Splitted this class into a
15128 per-assembly `Namespace' and a per-file `NamespaceEntry'.
15130 * typemanager.cs (TypeManager.IsNamespace): Removed.
15131 (TypeManager.ComputeNamespaces): Only compute namespaces from
15132 loaded assemblies here, not the namespaces from the assembly we're
15133 currently compiling.
15135 2003-07-08 Martin Baulig <martin@ximian.com>
15137 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
15139 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15141 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
15144 I thought about the memory savings here, but LookupTypeReflection
15145 is used under already very constrained scenarios. Compiling
15146 corlib or mcs only exposes one hit, so it would not really reduce
15147 any memory consumption.
15149 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15151 * typemanager.cs: fixes bug #45889 by only adding public types from
15152 other assemblies to the list of known types.
15154 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15156 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
15157 on the type we resolved.
15159 2003-07-05 Martin Baulig <martin@ximian.com>
15161 * pending.cs (PendingImplementation.ParentImplements): Don't
15162 create the proxy if the parent is abstract.
15164 * class.cs (TypeContainer.DefineIndexers): Process explicit
15165 interface implementations first. Fixes #37714.
15167 2003-07-04 Miguel de Icaza <miguel@ximian.com>
15169 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
15170 defined recursively; but since we modify the input parameters
15171 (left is set to `this' temporarily), we reset this value if the
15172 left_is_explicit is false, which gives the original semantics to
15175 * literal.cs (NullPointer): new class used to represent a null
15176 literal in a pointer context.
15178 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
15179 type is a pointer, use a NullPointer object instead of a
15180 NullLiteral. Closes 43687
15182 (ExplicitConversion): Convert pointer values using
15183 the conv opcode to the proper type.
15185 * ecore.cs (New): change ValueTypeVariable property into a method,
15186 that returns whether the valuetype is suitable for being used.
15188 * expression.cs (Binary.DoNumericPromotions): Only return if we
15189 the int constant was a valid uint, and we can return both left and
15190 right as uints. If not, we continue processing, to trigger the
15191 type conversion. This fixes 39018.
15193 * statement.cs (Block.EmitMeta): During constant resolution, set
15194 the CurrentBlock property on the emitcontext, so that we resolve
15195 constants propertly.
15197 2003-07-02 Martin Baulig <martin@ximian.com>
15199 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
15200 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
15202 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
15203 than emitting it here.
15205 * statement.cs: Fixed some more flow analysis bugs.
15207 2003-07-02 Martin Baulig <martin@ximian.com>
15209 * class.cs (MethodData.Define): When implementing interface
15210 methods, set Final unless we're Virtual.
15212 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
15213 check work for interface methods.
15215 2003-07-01 Martin Baulig <martin@ximian.com>
15217 * ecore.cs (EmitContext.This): Replaced this property with a
15218 GetThis() method which takes a Location argument. This ensures
15219 that we get the correct error location for a CS0188.
15221 2003-07-01 Miguel de Icaza <miguel@ximian.com>
15223 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
15224 ImplicitStandardConversion.
15226 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
15228 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
15230 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
15233 2003-06-30 Miguel de Icaza <miguel@ximian.com>
15235 * class.cs (Constructor.Define): Turn off initlocals for unsafe
15238 (MethodData.Define): Turn off initlocals for unsafe methods.
15240 2003-06-29 Miguel de Icaza <miguel@ximian.com>
15242 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
15243 complete; Fixes #37521.
15245 * delegate.cs: Use Modifiers.TypeAttr to compute the
15246 TypeAttributes, instead of rolling our own. This makes the flags
15247 correct for the delegates.
15249 2003-06-28 Miguel de Icaza <miguel@ximian.com>
15251 * class.cs (Constructor.Define): Set the private flag for static
15252 constructors as well.
15254 * cs-parser.jay (statement_expression): Set the return value to
15255 null, to avoid a crash when we catch an error.
15257 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15259 * cs-parser.jay: Applied patch from Jackson that adds support for
15260 extern and unsafe modifiers to destructor declarations.
15262 * expression.cs: Report error 21 if the user is trying to index a
15265 * driver.cs: Add an error message, suggested by the bug report.
15267 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15268 if we do not have a ": this ()" constructor initializer. Fixes 45149
15270 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15272 * namespace.cs: Add some information to reduce FAQs.
15274 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15276 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15277 underlying enumeration types. Fixes #43915.
15279 * expression.cs: Treat ushort/short as legal values to be used in
15280 bitwise operations.
15282 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15284 * delegate.cs: transfer custom attributes for paramenters from
15285 the delegate declaration to Invoke and BeginInvoke.
15287 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15289 * attribute.cs: handle custom marshalers and emit marshal info
15292 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15294 * makefile.gnu: Added anonymous.cs to the compiler sources.
15296 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15298 * iterators.cs: Change the name of the proxy class to include two
15301 * cs-parser.jay: Update grammar to include anonymous methods.
15303 * anonymous.cs: new file.
15305 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15307 * class.cs (Field.Define): Add missing test for pointers and
15310 2003-05-27 Ravi Pratap <ravi@ximian.com>
15312 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15313 we use the stobj opcode.
15315 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15316 since it wasn't the correct fix.
15318 It still is puzzling that we are required to use stobj for IntPtr
15319 which seems to be a ValueType.
15321 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15323 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15324 during regular simple name resolution. Now, the trick is that
15325 instead of returning for processing the simplename, we do a
15326 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15327 contextual lookup type). If a match is found, return that, if
15328 not, return for further composition.
15330 This fixes long-standing 30485.
15332 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15333 using the address to initialize an object, do an Stobj instead of
15334 using the regular Stelem.
15336 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15337 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15338 Because if we are a BaseIndexerAccess that value will be true.
15341 * statement.cs (GotoCase.Resolve): Return after reporting an
15342 error, do not attempt to continue.
15344 * expression.cs (PointerArithmetic.Emit): If our operand is a
15345 long, convert our constants to match the operand before
15346 multiplying. Convert to I type before adding. Fixes 43670.
15348 2003-05-14 Ravi Pratap <ravi@ximian.com>
15350 * enum.cs (ImplicitConversionExists) : Rename to
15351 ImplicitEnumConversionExists to remove ambiguity.
15353 * ecore.cs (NullCast): New type of cast expression class which
15354 basically is very similar to EmptyCast with the difference being
15355 it still is a constant since it is used only to cast a null to
15357 (eg. (string) null)
15359 * convert.cs (ImplicitReferenceConversion): When casting a null
15360 literal, we return a NullCast.
15362 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15363 should be around anymore.
15365 The renaming (reported was slightly wrong). Corrections:
15367 ConvertImplicitStandard -> ImplicitConversionStandard
15368 ConvertExplicitStandard -> ExplicitConversionStandard
15370 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15371 before passing them in !
15373 * convert.cs (ImplicitConversionStandard): When comparing for
15374 equal expr and target types, ensure that expr is not a
15377 In general, we must not be checking (expr_type ==
15378 target_type) in the top level conversion methods
15379 (ImplicitConversion, ExplicitConversion etc). This checking is
15380 done in the methods that they delegate to.
15382 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15384 * convert.cs: Move Error_CannotConvertType,
15385 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15386 ImplicitNumericConversion, ImplicitConversionExists,
15387 ImplicitUserConversionExists, StandardConversionExists,
15388 FindMostEncompassedType, FindMostSpecificSource,
15389 FindMostSpecificTarget, ImplicitUserConversion,
15390 ExplicitUserConversion, GetConversionOperators,
15391 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15392 TryImplicitIntConversion, Error_CannotConvertImplicit,
15393 ConvertImplicitRequired, ConvertNumericExplicit,
15394 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15395 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15398 Perform the following renames:
15400 StandardConversionExists -> ImplicitStandardConversionExists
15401 ConvertImplicit -> ImplicitConversion
15402 ConvertImplicitStandard -> ImplicitStandardConversion
15403 TryImplicitIntConversion -> ImplicitIntConversion
15404 ConvertImplicitRequired -> ImplicitConversionRequired
15405 ConvertNumericExplicit -> ExplicitNumericConversion
15406 ConvertReferenceExplicit -> ExplicitReferenceConversion
15407 ConvertExplicit -> ExplicitConversion
15408 ConvertExplicitStandard -> ExplicitStandardConversion
15410 2003-05-19 Martin Baulig <martin@ximian.com>
15412 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15413 (TypeInfo): Added support for structs having structs as fields.
15415 * ecore.cs (FieldExpr): Implement IVariable.
15416 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15417 VariableInfo for the field.
15419 2003-05-18 Martin Baulig <martin@ximian.com>
15421 * expression.cs (This.DoResolve): Report a CS0027 if we're
15422 emitting a field initializer.
15424 2003-05-18 Martin Baulig <martin@ximian.com>
15426 * expression.cs (This.ResolveBase): New public function.
15427 (This.DoResolve): Check for CS0188.
15429 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15432 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15433 `instance_expression' to null if we don't have any non-static
15436 2003-05-18 Martin Baulig <martin@ximian.com>
15438 Reworked the way how local variables and parameters are handled by
15439 the flow analysis code.
15441 * statement.cs (TypeInfo, VariableMap): New public classes.
15442 (VariableInfo): New public class. This is now responsible for
15443 checking whether a variable has been assigned. It is used for
15444 parameters and local variables.
15445 (Block.EmitMeta): Take the InternalParameters as argument; compute
15446 the layout of the flow vectors here.
15447 (Block.LocalMap, Block.ParameterMap): New public properties.
15448 (FlowBranching): The .ctor doesn't get the InternalParameters
15449 anymore since Block.EmitMeta() now computes the layout of the flow
15451 (MyStructInfo): This class is now known as `StructInfo' and nested
15452 in `TypeInfo'; we don't access this directly anymore.
15454 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15455 property and removed IsAssigned(), IsFieldAssigned(),
15456 SetAssigned() and SetFieldAssigned(); we now call them on the
15457 VariableInfo so we don't need to duplicate this code everywhere.
15459 * expression.cs (ParameterReference): Added `Block block' argument
15461 (LocalVariableReference, ParameterReference, This): The new
15462 VariableInfo class is now responsible for all the definite
15465 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15466 IsParameterAssigned, SetParameterAssigned): Removed.
15468 2003-05-18 Martin Baulig <martin@ximian.com>
15470 * typemanager.cs (InitCoreTypes): Try calling
15471 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15472 the 3-args-version. Corlib now also needs our `void_type'.
15473 (GetMethod): Added overloaded version which takes an optional
15474 `bool report_errors' to allow lookups of optional methods.
15476 2003-05-12 Martin Baulig <martin@ximian.com>
15478 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15479 only used for locals and not for parameters.
15481 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15483 * support.cs (InternalParameters.ParameterType): Return the
15484 ExternalType of the parameter.
15486 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15489 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15491 * class.cs (MethodData.Define): Do not set the `newslot' on
15492 interface members, if they are also flagged as "override".
15494 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15495 better code for ++i and i++. This only works for static fields
15496 and local variables.
15498 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15499 want to pull the DeclSpace out of the builder_to_declspace instead
15500 of the TypeBuilder (like in TypeContainer.FindMembers).
15502 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15503 instead of LookupTypeContainer. Fixes the crash on .NET for
15504 looking up interface members.
15506 * const.cs: Create our own emit context during the Definition
15507 stage, so that constants are evaluated in the proper context, when
15508 a recursive definition happens.
15510 2003-05-11 Martin Baulig <martin@ximian.com>
15512 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15513 new block for a switch section.
15514 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15515 the adding/lookup in the switch block. Fixes #39828.
15517 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15519 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15520 functionality: I needed to convert the data after I had performed
15521 the add/sub operation into the operands type size.
15523 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15524 pass the type for the box operation, otherwise the resulting
15525 object would have been of type object.
15527 (BoxedCast): Add constructor to specify the type to box as.
15529 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15531 * iterators.cs: I was reusing the `count' variable inadvertently,
15532 take steps to not allow this to happen.
15534 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15536 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15537 by creating an array at the point where the params starts and
15538 putting all those arguments there, then adjusting the size of the
15541 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15543 * expression.cs (New.AddressOf): Implement interface
15544 IMemoryLocation. This is used when the `new' operator is used in
15545 the context of an invocation to a method on a value type.
15547 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15550 * namespace.cs: Also check the using aliases here.
15552 * driver.cs: Move the test for using validity after the types have
15553 been entered, so we do a single pass that also includes the using
15556 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15557 in the regular case. CreateSiblingForFinally is doing extra
15560 * attribute.cs (GetAttributeArgumentExpression): Store the result
15561 on an out value, and use the return value to indicate failure
15562 instead of using null (which is a valid return for Constant.GetValue).
15564 * statement.cs: Perform the analysis flow for the increment
15565 portion after the statement, because this will be the real flow of
15566 execution. Fixes #42385
15568 * codegen.cs (EmitContext.EmitArgument,
15569 EmitContext.EmitStoreArgument): New helper functions when the
15570 RemapToProxy flag is set.
15572 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15575 Add support for remapping parameters.
15577 * iterators.cs: Propagate parameter values; Store parameter
15578 values in the proxy classes.
15580 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15582 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15583 need a proxy reference; I do not know what I was thinking
15585 * cs-parser.jay (constructor_initializer): catch another error,
15586 and display nice message.
15588 (field_declaration): catch void field declaration
15589 to flag a better error.
15591 * class.cs (MemberBase.CheckBase): Report an error instead of a
15592 warning if a new protected member is declared in a struct.
15593 (Field.Define): catch the error of readonly/volatile.
15595 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15597 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15598 volatile variable is taken
15600 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15602 * statement.cs (Fixed.Resolve): Report an error if we are not in
15605 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15607 * typemanager.cs: reuse the code that handles type clashes for
15608 delegates and enumerations.
15610 * class.cs (Report28): Always report.
15612 * expression.cs (EncodeAsAttribute): Allow nulls here.
15614 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15616 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15617 the functionality for testing whether an expression is valid for
15618 an attribute here. Also handle the case of arrays of elements
15621 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15622 encoding a linear array into an array of objects that are suitable
15623 to be passed to an CustomAttributeBuilder.
15625 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15627 * ecore.cs: (FieldExpr): Handle field remapping here.
15629 * iteratators.cs: Pass the instance variable (if the method is an
15630 instance method) to the constructors, so we can access the field
15631 variables on the class.
15633 TODO: Test this with structs. I think the THIS variable on
15634 structs might have to be a pointer, and not a refenrece
15636 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15638 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15639 local variables to fields in a proxy class.
15641 * iterators.cs (PopulateProxy): Rename our internal fields to
15643 Create a <THIS> field if we are an instance method, so we can
15644 reference our parent container variables.
15645 (MapVariable): Called back from the EmitContext code to enter a
15646 new variable to field mapping into the proxy class (we just create
15650 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15651 for using the remapped locals to fields.
15653 I placed the code here, because that gives the same semantics to
15654 local variables, and only changes the Emit code.
15656 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15657 statements inside iterators.
15658 (VariableInfo): Add a FieldBuilder for the cases when we are
15659 remapping local variables to fields in a proxy class
15661 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15662 current_block != null.
15664 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15665 not cope with strings, as it has been moved to the
15666 TableSwitchEmit. Fixed bug in switch generation.
15668 * expression.cs (New.DoResolve): Provide more context for the user
15669 when reporting an error.
15671 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15674 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15675 check the permissions for it. Note than in a type-resolution
15676 context the check was already present in DeclSpace.ResolveType,
15677 but was missing from the MemberAccess.
15679 (ArrayCreation.CheckIndices): warn if the user has
15680 more nested levels of expressions, but there are no more
15681 dimensions specified. Avoids crash on bug 41906.
15683 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15685 * statement.cs (Block): replace Implicit bool, for a generic
15687 New flag: `Unchecked'. This is used during the EmitMeta phase
15688 (which is out-of-line with the regular Resolve/Emit process for a
15689 statement, as this is done ahead of time, but still gets a chance
15690 to call constant resolve).
15692 (Block.Flags): new enum for adding a new flag.
15694 (Block.EmitMeta): track the state of unchecked.
15696 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15697 to enable constant resolution to work there as well.
15699 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15701 * typemanager.cs (ienumerable_type): Also look up
15702 System.Collections.IEnumerable.
15704 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15706 TODO: Test more than one conditional per method.
15708 * class.cs (Indexer.Define): Report the location where the user is
15709 referencing the unsupported feature.
15711 (MethodData): Overload the use of `conditionals' to
15712 minimize the creation of needless ArrayLists. This saves roughly
15713 212kb on my machine.
15715 (Method): Implement the new IIteratorContainer interface.
15716 (Method.SetYields): Implement the method by setting the ModFlags
15717 to contain METHOD_YIELDS.
15719 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15720 which just got set to null.
15722 * iterators.cs: New file.
15724 (Yield, YieldBreak): New statements.
15726 * statement.cs (Return.Resolve): Flag an error if we are used in
15727 an iterator method.
15729 * codegen.cs (InIterator): New flag set if the code is being
15730 compiled in an iterator method.
15732 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15733 internal modifier, and we just use it to avoid adding extra
15734 fields, as this is seldom used.
15736 * cs-parser.jay: Add yield_statement (yield and yield break).
15738 * driver.cs: New flag -v2 to turn on version 2 features.
15740 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15741 hashtable when v2 is enabled.
15743 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15745 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15746 there is already a namespace defined with this name.
15748 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15749 people upgraded their corlibs.
15751 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15752 always use fully qualified types, no need to use the compiler
15755 (TypeManager.IsNamespace): Use binarysearch.
15757 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15758 AddDelegate): I did not quite use the new IsValid API properly: I
15759 have to pass the short-name and the fullname. I was passing only
15760 the basename instead of the fullname sometimes.
15762 (TypeContainer.DefineType): call NamespaceClash.
15764 * interface.cs (Interface.DefineType): use NamespaceClash before
15767 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15770 * enum.cs: (Enum.DefineType): use NamespaceClash before
15773 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15774 speed increase. First, use the negative_hits cache when we get a
15775 negative. Second, add the type with its full original name
15776 instead of the new . and + encoded name (reflection uses + to
15777 separate type from a nested type). Use LookupTypeReflection
15778 directly which bypasses the type->name hashtable (that we already
15779 know does not contain the type.
15781 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15782 location/container type.
15784 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15786 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15788 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15790 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15791 method is being referenced in the method group from a static
15792 context, and report error 120 if so.
15794 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15797 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15798 is created, we create the A namespace).
15800 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15803 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15805 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15806 invocation to ModuleBuilder.GetType with the same values will
15807 return a new type instance, so we need to cache its return
15810 * expression.cs (Binary.ResolveOperator): Only allow the compare
15811 operators on enums if they are of the same type.
15813 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15814 types of ValueType on their own case. Before we were giving them
15815 the same treatment as objects.
15817 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15818 fullname. Short name is used to compare against container name.
15819 Fullname is used to check against defined namespace names.
15821 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15822 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15824 (Method.CheckBase): Call parent.
15825 (MemberBase.CheckBase): Check for protected members on sealed
15827 (PropertyBase.CheckBase): Call parent.
15828 (Field.Define): Call parent.
15830 * report.cs: Negative error codes are now mapped to 8000 - code,
15831 so that the display is render more nicely.
15833 * typemanager.cs: Do not use try/catch, instead report a regular
15836 (GetPointerType, GetReferenceType): These methods provide
15837 mechanisms to obtain the T* and T& from a T. We had the code
15838 previously scattered around the code base, and it also used
15839 TypeManager.LookupType that would go through plenty of caches.
15840 This one goes directly to the type source.
15842 In some places we did the Type.GetType followed by
15843 ModuleBuilder.GetType, but not in others, so this unifies the
15844 processing as well.
15846 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15847 statements now that we have namespace information.
15849 * typemanager.cs (IsNamespace): New method, returns whether the
15850 string presented is a namespace or not.
15852 (ComputeNamespaces): New public entry point, computes the list of
15853 available namespaces, using the GetNamespaces API call in Mono, or
15854 the slower version in MS.NET.
15856 Now before we start the semantic analysis phase, we have a
15857 complete list of namespaces including everything that the user has
15860 Deleted old code to cache namespaces in .nsc files.
15862 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15864 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15865 class/struct location definition Location for the implicit
15866 constructor location.
15868 (Operator.Define): Use the location of the operator for the
15869 implicit Method definition.
15871 (Constructor.Emit): use the constructor location for the implicit
15872 base initializer constructor.
15874 * ecore.cs: Remove ITypeExpression. This interface is now gone,
15875 and the Expression class now contains two new methods:
15877 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
15878 isolate type lookup from the rest of the resolution process.
15880 Since we use Expressions to hold type definitions due to the way
15881 we parse the input we have historically overloaded Resolve to
15882 perform the Type lookups if a special flag is passed. Now this is
15883 eliminated and two methods take their place.
15885 The differences in the two methods between xStep and xTerminal is
15886 that xStep is involved in our current lookup system that uses
15887 SimpleNames to compose a name, while xTerminal is used just to
15888 catch the case where the simplename lookup failed.
15890 2003-04-16 Miguel de Icaza <miguel@ximian.com>
15892 * expression.cs (ResolveMemberAccess): Remove redundant code.
15893 TypeExpr expressions are always born fully resolved.
15895 * interface.cs (PopulateMethod): Do not lookup the types twice.
15896 We were doing it once during SemanticAnalysis and once during
15899 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
15900 in local variable type definitions, were being returned as a
15901 SimpleName (we decomposed everything into a string), that is
15902 because primary_expression was being used instead of a type in the
15903 grammar (reduce/reduce conflicts).
15905 The part that was wrong is that we converted the expression into a
15906 string (an oversimplification in one hand, compounded with primary
15907 expressions doing string concatenation).
15913 Would return "A.B.C[]" as a SimpleName. This stopped things like
15914 using clauses from working on this particular context. And a type
15915 was being matched directly against "A.B.C[]".
15917 We now use the correct approach, and allow for ComposedCast to be
15918 part of the unary expression. So the "A.B.C []" become a composed
15919 cast of "A.B.C" (as a nested group of MemberAccess with a
15920 SimpleName at the end) plus the rank composition "[]".
15924 2003-04-10 Miguel de Icaza <miguel@ximian.com>
15926 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
15927 for the access level checking.
15929 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
15930 `TypeContainer container', because I kept getting confused when I
15931 was debugging this code.
15933 * expression.cs (Indexers): Instead of tracking getters/setters,
15934 we now track them in parallel. We create one arraylist less, but
15935 most importantly it is possible now for the LValue code to find a
15936 matching get for a set.
15938 (IndexerAccess.DoResolveLValue): Update the code.
15939 GetIndexersForType has been modified already to extract all the
15940 indexers from a type. The code assumed it did not.
15942 Also make the code set the correct return type for the indexer.
15943 This was fixed a long time ago for properties, but was missing for
15944 indexers. It used to be void_type.
15946 (Binary.Emit): Test first for doubles instead of
15947 floats, as they are more common.
15949 (Binary.EmitBranchable): Use the .un version of the branch opcodes
15950 when dealing with floats and the <=, >= operators. This fixes bug
15953 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
15954 to load the array value by emitting a load on the foreach variable
15955 type. This was incorrect.
15957 We now emit the code to load an element using the the array
15958 variable type, and then we emit the conversion operator.
15962 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
15964 * attribute.cs: Avoid allocation of ArrayLists in the common case.
15966 2003-04-09 Miguel de Icaza <miguel@ximian.com>
15968 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
15969 test for protection before we test for signatures.
15971 (MethodSignature.ToString): implement.
15973 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
15974 to the case where we reduced into a LongConstant.
15976 * decl.cs (CheckAccessLevel): If the type is an array, we can not
15977 depend on whether the information is acurrate, because the
15978 Microsoft runtime will always claim that the array type is public,
15979 regardless of the real state.
15981 If the type is a pointer, another problem happens: the type is
15982 reported as non-public in Microsoft.
15984 In both cases we have to call CheckAccessLevel recursively with
15985 the underlying type as the argument to be tested.
15987 2003-04-08 Miguel de Icaza <miguel@ximian.com>
15989 * assign.cs (Assign.Emit): If we are dealing with a compound
15990 assignment expression, we should use the code path that stores the
15991 intermediate result in a temporary value. This fixes #40903.
15993 *expression.cs (Indirection.ToString): Provide ToString method for
15996 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
15998 * class.cs: Null out fields holding references to Block objects so
15999 they can be garbage collected.
16001 * expression.cs (OverloadResolve): Remove unused local.
16003 2003-04-07 Martin Baulig <martin@ximian.com>
16005 * codegen.cs (EmitContext.CurrentFile): New public field.
16006 (EmitContext.Mark): Use the CurrentFile to check whether the
16007 location is in the correct file.
16008 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
16010 2003-04-07 Martin Baulig <martin@ximian.com>
16012 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
16014 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
16015 location. [FIXME: The location argument which gets passed to this
16016 method is sometimes wrong!]
16018 2003-04-07 Nick Drochak <ndrochak@gol.com>
16020 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
16022 2003-04-07 Miguel de Icaza <miguel@ximian.com>
16024 * expression.cs (Indirection.EmitAssign): We were using the
16025 temporary, but returning immediately instead of continuing the
16028 2003-04-06 Martin Baulig <martin@ximian.com>
16030 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
16031 if it's a nested child, but also deriving from the outer class.
16034 * typemanager.cs (IsNestedChildOf): Make this work if it's a
16035 nested child, but also deriving from the outer class. See
16037 (FilterWithClosure): We may access private members of the outer
16038 class if we're a nested child and deriving from the outer class.
16039 (RealMemberLookup): Only set `closure_private_ok' if the
16040 `original_bf' contained BindingFlags.NonPublic.
16042 2003-04-05 Martin Baulig <martin@ximian.com>
16044 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
16045 probe if its a type parameter, and if so, flag an error.
16047 * decl.cs: Move here the SetParameterInfo code from class.cs.
16048 Handle IsGeneric here.
16050 Handle a variety of errors in the parameter info definition.
16052 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
16053 type parameters here.
16055 * cs-parser.jay (class_declaration): report errors for parameters
16058 2003-01-21 Miguel de Icaza <miguel@ximian.com>
16060 * generic.cs: New file, contains support code for generics.
16062 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
16063 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
16065 Update parser for the above removals.
16067 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
16068 now taken care of in the parser.
16070 2003-04-02 Miguel de Icaza <miguel@ximian.com>
16072 * class.cs (Event.Define): Do not allow abstract events to have
16075 2003-04-01 Miguel de Icaza <miguel@ximian.com>
16077 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
16078 block in event declarations.
16080 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
16081 value type, get its address.
16083 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
16084 leaving a class on the stack instead of a boolean value (int
16085 0/1). Change the code so we compare against null, and then the
16086 result against zero.
16088 * class.cs (TypeContainer.GetClassBases): We were checking for the
16089 parent class being sealed too late.
16091 * expression.cs (Binary.Emit): For <= and >= when dealing with
16092 floating point values, use cgt.un and clt.un instead of cgt and
16095 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
16097 * statement.cs: Apply the same optimization as MS: skip the
16098 GetEnumerator returning an IEnumerator, and use the one returning a
16099 CharEnumerator instead. This allows us to avoid the try-finally block
16102 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
16104 * cs-parser.jay: Attributes cannot be applied to
16105 namespaces. Fixes #40473
16107 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16110 (Add*): check if the name is valid using the full name for constants,
16111 fields, properties and events.
16113 2003-03-28 Miguel de Icaza <miguel@ximian.com>
16115 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
16116 char constants to be part of the enumeration.
16118 * expression.cs (Conditional.DoResolve): Add support for operator
16119 true. Implements the missing functionality from 14.12
16121 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
16122 operator true/false as required by the spec.
16124 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
16125 implicit conversion to boolean.
16127 * statement.cs (Statement.ResolveBoolean): A boolean expression is
16128 also one where the type implements `operator true'.
16130 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
16131 get an expression that will invoke operator true based on an
16134 (GetConversionOperators): Removed the hack that called op_True
16137 (Expression.ResolveBoolean): Move this from Statement.
16139 2003-03-17 Miguel de Icaza <miguel@ximian.com>
16141 * ecore.cs (FieldExpr): do not allow initialization of initonly
16142 fields on derived classes
16144 2003-03-13 Martin Baulig <martin@ximian.com>
16146 * statement.cs (Block.Emit): Call ig.BeginScope() and
16147 ig.EndScope() when compiling with debugging info; call
16148 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
16150 2003-03-08 Miguel de Icaza <miguel@ximian.com>
16152 * expression.cs (Indexers): Do not construct immediately, allow
16153 for new members to be appended as we go. Fixes 38143
16155 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16157 * expression.cs: save/restore context when resolving an unchecked
16160 2003-03-05 Miguel de Icaza <miguel@ximian.com>
16162 * cfold.cs: Catch division by zero in modulus operator during
16165 2003-03-03 Miguel de Icaza <miguel@ximian.com>
16167 * interface.cs (Interface.DefineMembers): Avoid defining members
16170 2003-02-27 Miguel de Icaza <miguel@ximian.com>
16172 * driver.cs: handle the +/- options for -noconfig
16174 * statement.cs (Unckeched.Resolve): Also track the state of
16175 unchecked in the Resolve phase.
16177 2003-02-27 Martin Baulig <martin@ximian.com>
16179 * ecore.cs (Expression.MemberLookup): Don't create a
16180 MethodGroupExpr for something which is not a method. Fixes #38291.
16182 2003-02-25 Miguel de Icaza <miguel@ximian.com>
16184 * class.cs (MemberBase.CheckParameters): Also check that the type
16185 is unmanaged if it is a pointer.
16187 * expression.cs (SizeOf.Resolve): Add location information.
16189 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
16190 a managed type is declared.
16192 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
16193 parameter modifiers as well. Fixes bug 38606
16195 * class.cs: Very sad. Am backing out the speed up changes
16196 introduced by the ArrayList -> Array in the TypeContainer, as they
16197 were not actually that much faster, and introduced a bug (no error
16198 reports on duplicated methods).
16200 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
16201 source first, this will guarantee that we have a valid expression
16202 before calling in lower levels functions that will require a
16203 resolved object. Then use this original_source in the
16204 target.ResolveLValue instead of the original source that was
16207 Another change. Use target.Resolve instead of LValueResolve.
16208 Although we are resolving for LValues, we will let the Assign code
16209 take care of that (it will be called again from Resolve). This
16210 basically allows code like this:
16212 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
16213 class Y { void A (X x) { x [0] += o; }
16215 The problem was that the indexer was trying to resolve for
16216 set_Item (idx, object o) and never finding one. The real set_Item
16217 was set_Item (idx, X). By delaying the process we get the right
16222 2003-02-23 Martin Baulig <martin@ximian.com>
16224 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
16225 while calling DoEmit ().
16227 * codegen.cs (EmitContext.Mark): Don't mark locations in other
16228 source files; if you use the #line directive inside a method, the
16229 compiler stops emitting line numbers for the debugger until it
16230 reaches the end of the method or another #line directive which
16231 restores the original file.
16233 2003-02-23 Martin Baulig <martin@ximian.com>
16235 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
16237 2003-02-23 Martin Baulig <martin@ximian.com>
16239 * statement.cs (Block.AddChildVariableNames): We need to call this
16240 recursively, not just for our immediate children.
16242 2003-02-23 Martin Baulig <martin@ximian.com>
16244 * class.cs (Event.Define): Always make the field private, like csc does.
16246 * typemanager.cs (TypeManager.RealMemberLookup): Make events
16247 actually work, fixes bug #37521.
16249 2003-02-23 Miguel de Icaza <miguel@ximian.com>
16251 * delegate.cs: When creating the various temporary "Parameters"
16252 classes, make sure that we call the ComputeAndDefineParameterTypes
16253 on those new parameters (just like we do with the formal ones), to
16254 allow them to be resolved in the context of the DeclSpace.
16256 This fixes the bug that Dick observed in Bugzilla #38530.
16258 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16260 * expression.cs (ResolveMemberAccess): When resolving a constant,
16261 do not attempt to pull a constant if the value was not able to
16262 generate a valid constant.
16264 * const.cs (LookupConstantValue): Do not report more errors than required.
16266 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16268 * expression.cs: fixes bug #38328.
16270 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16272 * class.cs: Changed all the various members that can be part of a
16273 class from being an ArrayList to be an Array of the right type.
16274 During the DefineType type_list, interface_list, delegate_list and
16275 enum_list are turned into types, interfaces, delegates and enums
16278 And during the member population, indexer_list, event_list,
16279 constant_list, field_list, instance_constructor_list, method_list,
16280 operator_list and property_list are turned into their real arrays.
16282 Although we could probably perform this operation earlier, for
16283 good error reporting we need to keep the lists and remove the
16284 lists for longer than required.
16286 This optimization was triggered by Paolo profiling the compiler
16287 speed on the output of `gen-sample-program.pl' perl script.
16289 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16290 not crash in methods like MemberLookupFailed that use this field.
16292 This problem arises when the compiler fails to resolve a type
16293 during interface type definition for example.
16295 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16297 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16298 inherit from System.Object, so we have to stop at null, not only
16299 when reaching System.Object.
16301 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16303 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16304 DeclaredOnly because the parent indexer might have had a different
16305 name, but did not loop until the top of the hierarchy was reached.
16307 The problem this one fixes is 35492: when a class implemented an
16308 indexer from an interface, we were getting the interface method
16309 (which was abstract) and we were flagging an error (can not invoke
16312 This also keeps bug 33089 functioning, and test-148 functioning.
16314 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16315 out if a method is special is to see if it is declared in a
16316 property or event, or whether it is one of the predefined operator
16317 names. This should fix correctly #36804.
16319 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16321 The goal here is to remove the dependency on EmptyCast.Peel ().
16322 Killing it completely.
16324 The problem is that currently in a number of places where
16325 constants are expected, we have to "probe" for an EmptyCast, and
16326 Peel, which is not the correct thing to do, as this will be
16327 repetitive and will likely lead to errors.
16329 The idea is to remove any EmptyCasts that are used in casts that
16330 can be reduced to constants, so we only have to cope with
16333 This bug hunt was triggered by Bug 37363 and the desire to remove
16334 the duplicate pattern where we were "peeling" emptycasts to check
16335 whether they were constants. Now constants will always be
16338 * ecore.cs: Use an enumconstant here instead of wrapping with
16341 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16342 throwing me off. By handling this we can get rid of a few hacks.
16344 * statement.cs (Switch): Removed Peel() code.
16346 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16348 * class.cs: Location information for error 508
16350 * expression.cs (New.DoResolve): Add a guard against double
16351 resolution of an expression.
16353 The New DoResolve might be called twice when initializing field
16354 expressions (see EmitFieldInitializers, the call to
16355 GetInitializerExpression will perform a resolve on the expression,
16356 and later the assign will trigger another resolution
16358 This leads to bugs (#37014)
16360 * delegate.cs: The signature for EndInvoke should contain any ref
16361 or out parameters as well. We were not doing this in the past.
16363 * class.cs (Field.Define): Do not overwrite the type definition
16364 inside the `volatile' group. Turns out that volatile enumerations
16365 were changing the type here to perform a validity test, which
16368 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16370 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16371 and structs, we do not want to load the instance variable
16373 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16374 enum_type has to be handled like an object reference (implicit
16375 conversions exists from this to object), but the regular IsClass
16376 and IsValueType tests will never return true for this one.
16378 Also we use TypeManager.IsValueType instead of type.IsValueType,
16379 just for consistency with the rest of the code (this is only
16380 needed if we ever use the construct exposed by test-180.cs inside
16381 corlib, which we dont today).
16383 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16385 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16388 2003-02-09 Martin Baulig <martin@ximian.com>
16390 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16391 (Namespace.DefineNamespaces): New static public method; this is
16392 called when we're compiling with debugging to add all namespaces
16393 to the symbol file.
16395 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16396 pass it to the Namespace's .ctor.
16398 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16399 and MethodBase arguments; pass the namespace ID to the symwriter;
16400 pass the MethodBase instead of the token to the symwriter.
16401 (SymbolWriter.DefineNamespace): New method to add a namespace to
16404 2003-02-09 Martin Baulig <martin@ximian.com>
16406 * symbolwriter.cs: New file. This is a wrapper around
16407 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16408 methods here in near future.
16410 2003-02-09 Martin Baulig <martin@ximian.com>
16412 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16413 ILGenerator.MarkSequencePoint() which are actually used by the
16416 2003-02-09 Martin Baulig <martin@ximian.com>
16418 * location.cs (SourceFile): New public sealed class. This
16419 contains the name and an index which is used in the location's token.
16420 (Location): Reserve an appropriate number of bits in the token for
16421 the source file instead of walking over that list, this gives us a
16422 really huge performance improvement when compiling with debugging.
16424 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16425 `SourceFile' argument instead of a string.
16426 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16427 but don't parse/tokenize here, we need to generate the list of all
16428 source files before we do that.
16429 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16432 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16433 instead of a string.
16435 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16438 2003-02-09 Martin Baulig <martin@ximian.com>
16440 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16441 filename on `#line default'.
16443 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16445 * statement.cs: don't clear the pinned var when the fixed statement
16446 returns from the method (fixes bug#37752).
16448 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16450 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16453 2003-02-07 Martin Baulig <martin@ximian.com>
16455 * driver.cs: Removed the `--debug-args' command line argument.
16457 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16458 automatically by the AsssemblyBuilder.
16459 (CodeGen.InitializeSymbolWriter): We don't need to call any
16460 initialization function on the symbol writer anymore. This method
16461 doesn't take any arguments.
16463 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16465 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16466 from referenced assemblies as well.
16468 2003-02-02 Martin Baulig <martin@ximian.com>
16470 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16472 2003-02-02 Martin Baulig <martin@ximian.com>
16474 * class.cs (Constructor.Emit): Open the symbol writer before
16475 emitting the constructor initializer.
16476 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16477 single-stepping through constructor initializers.
16479 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16481 * class.cs: Handle error 549: do not allow virtual methods in
16484 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16486 * decl.cs: Check access levels when resolving types
16488 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16490 * statement.cs: Add parameters and locals set in catch blocks that might
16491 return to set vector
16493 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16495 * class.cs (Operator): Set the SpecialName flags for operators.
16497 * expression.cs (Invocation.DoResolve): Only block calls to
16498 accessors and operators on SpecialName methods.
16500 (Cast.TryReduce): Handle conversions from char constants.
16503 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16505 * statement.cs: small memory and time optimization in FlowBranching.
16507 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16509 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16510 problem that the last fix but in the other sid (Set).
16512 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16513 access when there is no indexer in the hierarchy.
16515 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16517 * class.cs: Combine some if statements.
16519 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16521 * driver.cs: fixed bug #37187.
16523 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16525 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16526 any indexer, it's needed to build a list with all the indexers in the
16527 hierarchy (AllGetters), else we have problems. Fixes #35653.
16529 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16531 * class.cs (MethodData.Define): It is wrong for an interface
16532 implementation to be static in both cases: explicit and implicit.
16533 We were only handling this in one case.
16535 Improve the if situation there to not have negations.
16537 * class.cs (Field.Define): Turns out that we do not need to check
16538 the unsafe bit on field definition, only on usage. Remove the test.
16540 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16542 * driver.cs: use assembly.Location instead of Codebase (the latest
16543 patch made mcs fail when using MS assemblies).
16545 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16547 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16548 get the path to *corlib.dll.
16550 2003-01-21 Nick Drochak <ndrochak@gol.com>
16554 * typemanager.cs: Remove compiler warnings
16556 2003-01-20 Duncan Mak <duncan@ximian.com>
16558 * AssemblyInfo.cs: Bump the version number to 0.19.
16560 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16562 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16564 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16566 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16568 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16570 * cs-parser.jay: Small fix: we were not comparing the constructor
16571 name correctly. Thanks to Zoltan for the initial pointer.
16573 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16575 * cs-tokenizer.cs: Set file name when specified with #line
16577 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16579 * cs-parser.jay: Only perform the constructor checks here if we
16580 are named like the class; This will help provider a better
16581 error. The constructor path is taken when a type definition is
16582 not found, but most likely the user forgot to add the type, so
16583 report that rather than the constructor error.
16585 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16587 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16590 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16592 * cs-parser.jay: Add cleanup call.
16594 2003-01-13 Duncan Mak <duncan@ximian.com>
16596 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16597 consistent with other methods.
16599 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16601 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16603 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16605 * attribute.cs: only set GuidAttr to true when we have a
16608 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16612 * typemanager.cs: fixes to allow mcs compile corlib with the new
16613 Type.IsSubclassOf fix.
16615 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16617 * expression.cs (LocalVariableReference.DoResolve): Classify a
16618 constant as a value, not as a variable. Also, set the type for
16621 * cs-parser.jay (fixed_statement): take a type instead of a
16622 pointer_type, so we can produce a better error message later.
16624 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16627 (For.DoEmit): Make inifinite loops have a
16628 non-conditional branch back.
16630 (Fixed.DoEmit): First populate the pinned variables, then emit the
16631 statement, then clear the variables. Before I was emitting the
16632 code once for each fixed piece.
16635 2003-01-08 Martin Baulig <martin@ximian.com>
16637 * statement.cs (FlowBranching.MergeChild): A break in a
16638 SWITCH_SECTION does not leave a loop. Fixes #36155.
16640 2003-01-08 Martin Baulig <martin@ximian.com>
16642 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16643 lives in the same number space than `param_map'. Fixes #36154.
16645 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16647 * cs-parser.jay (constructor_declaration): Set the
16648 Constructor.ModFlags before probing for it. This makes the
16649 compiler report 514, 515 and 132 (the code was there, but got
16652 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16653 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16654 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16656 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16658 * enum.cs: create the enum static fields using the enum type.
16660 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16662 * class.cs: don't try to create the ParamBuilder for the return
16663 type if it's not needed (and handle it breaking for the ms runtime
16666 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16668 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16670 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16672 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16673 the command. This showed up while compiling the JANET source
16674 code, which used \r as its only newline separator.
16676 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16678 * class.cs (Method.Define): If we are an operator (because it
16679 reuses our code), then set the SpecialName and HideBySig. #36128
16681 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16683 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16684 exception, report error 120 `object reference required'.
16686 * driver.cs: Add --pause option, used during to measure the size
16687 of the process as it goes with --timestamp.
16689 * expression.cs (Invocation.DoResolve): Do not allow methods with
16690 SpecialName to be invoked.
16692 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16694 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16695 number before adding it.
16697 2002-12-21 Ravi Pratap <ravi@ximian.com>
16699 * ecore.cs (StandardImplicitConversion): When in an unsafe
16700 context, we allow conversion between void * to any other pointer
16701 type. This fixes bug #35973.
16703 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16705 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16706 is not thrown when extensionless outputs are used
16708 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16710 * rootcontext.cs: fixed compilation of corlib.
16712 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16714 * attribute.cs (Attributes.Contains): Add new method.
16716 * class.cs (MethodCore.LabelParameters): if the parameter is an
16717 `out' parameter, check that no attribute `[In]' has been passed.
16719 * enum.cs: Handle the `value__' name in an enumeration.
16721 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16723 * decl.cs: Added special case to allow overrides on "protected
16726 2002-12-18 Ravi Pratap <ravi@ximian.com>
16728 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16729 since it makes much more sense.
16731 (Attributes.ctor): Don't require a Location parameter.
16733 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16735 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16736 since we already have that information per attribute.
16738 * everywhere : make appropriate changes.
16740 * class.cs (LabelParameters): Write the code which actually
16741 applies attributes to the return type. We can't do this on the MS
16742 .NET runtime so we flag a warning in the case an exception is
16745 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16747 * const.cs: Handle implicit null conversions here too.
16749 2002-12-17 Ravi Pratap <ravi@ximian.com>
16751 * class.cs (MethodCore.LabelParameters): Remove the extra
16752 Type [] parameter since it is completely unnecessary. Instead
16753 pass in the method's attributes so that we can extract
16754 the "return" attribute.
16756 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16758 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16759 of ignoring it and letting the compile continue.
16761 * typemanager.cs (ChangeType): use an extra argument to return an
16762 error condition instead of throwing an exception.
16764 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16766 * expression.cs (Unary.TryReduce): mimic the code for the regular
16767 code path. Perform an implicit cast in the cases where we can
16768 implicitly convert to one of the integral types, and then reduce
16769 based on that constant. This fixes bug #35483.
16771 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16773 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16775 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16777 * namespace.cs: fixed bug #35489.
16779 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16781 * class.cs: Remove some dead code.
16783 * cs-parser.jay: Estimate the number of methods needed
16784 (RootContext.MethodCount);
16786 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16787 numbers instead of StringBuilders.
16789 * support.cs (PtrHashtable): Add constructor with initial size;
16790 We can now reduce reallocations of the method table.
16792 2002-12-10 Ravi Pratap <ravi@ximian.com>
16794 * attribute.cs (ApplyAttributes): Keep track of the emitted
16795 attributes on a per-target basis. This fixes bug #35413.
16797 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16799 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16800 default to the Windows 1252 encoding.
16802 (UnixParseOption): Support version, thanks to Alp for the missing
16805 * AssemblyInfo.cs: Add nice assembly information.
16807 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16810 * cs-parser.jay: Allow a trailing comma before the close bracked
16811 in the attribute_section production.
16813 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16814 address of the instance was being taken, I will take this out,
16815 because we take the address of the object immediately here.
16817 2002-12-09 Ravi Pratap <ravi@ximian.com>
16819 * typemanager.cs (AreMultipleAllowed): Take care of the most
16820 obvious case where attribute type is not in the current assembly -
16823 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16825 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16826 definitions, instead of doing that afterwards.
16828 Also we use a nice little hack, depending on the constructor, we
16829 know if we are a "composed" name or a simple name. Hence, we
16830 avoid the IndexOf test, and we avoid
16832 * codegen.cs: Add code to assist in a bug reporter to track down
16833 the source of a compiler crash.
16835 2002-12-07 Ravi Pratap <ravi@ximian.com>
16837 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16838 types have been emitted for a given element and flag an error
16839 if something which does not have AllowMultiple set is used more
16842 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16843 attribute types and their corresponding AllowMultiple properties
16845 (AreMultipleAllowed): Check the property for a given type.
16847 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16848 property in the case we have a TypeContainer.
16850 (Attributes.AddAttribute): Detect duplicates and just skip on
16851 adding them. This trivial fix catches a pretty gross error in our
16852 attribute emission - global attributes were being emitted twice!
16854 Bugzilla bug #33187 is now fixed.
16856 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16858 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16859 instead of pp_and).
16861 * expression.cs (Binary.ResolveOperator): I can only use the
16862 Concat (string, string, string) and Concat (string, string,
16863 string, string) if the child is actually a concatenation of
16866 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16868 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16869 context where we need a 2-character lookahead.
16871 * pending.cs (PendingImplementation): Rework so we can keep track
16872 of interface types all the time, and flag those which were
16873 implemented by parents as optional.
16875 2002-12-03 Miguel de Icaza <miguel@ximian.com>
16877 * expression.cs (Binary.ResolveOperator): Use
16878 String.Concat(string,string,string) or
16879 String.Concat(string,string,string,string) when possible.
16881 * typemanager: More helper methods.
16884 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
16886 * pending.cs: remove the bogus return from GetMissingInterfaces()
16887 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
16889 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16891 * namespace.cs: avoid duplicated 'using xxx' being added to
16892 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
16893 when we get more than one 'using' statement for the same namespace.
16894 Report a CS0105 warning for it.
16896 2002-11-30 Miguel de Icaza <miguel@ximian.com>
16898 * cs-tokenizer.cs (consume_identifier): use read directly, instead
16899 of calling getChar/putback, uses internal knowledge of it.
16901 (xtoken): Reorder tokenizer so most common patterns are checked
16902 first. This reduces the compilation time in another 5% (from 8.11s
16903 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
16905 The parsing time is 22% of the compilation in mcs, and from that
16906 64% is spent on the tokenization process.
16908 I tried using a binary search for keywords, but this is slower
16909 than the hashtable. Another option would be to do a couple of
16912 * Not use a StringBuilder, instead use an array of chars,
16913 with a set value. Notice that this way we could catch
16914 the 645 error without having to do it *afterwards*.
16916 * We could write a hand-parser to avoid the hashtable
16917 compares altogether.
16919 The identifier consumption process takes 37% of the tokenization
16920 time. Another 15% is spent on is_number. 56% of the time spent
16921 on is_number is spent on Int64.Parse:
16923 * We could probably choose based on the string length to
16924 use Int32.Parse or Int64.Parse and avoid all the 64-bit
16927 Another 3% is spend on wrapping `xtoken' in the `token' function.
16929 Handle 0xa0 as whitespace (#34752)
16931 2002-11-26 Miguel de Icaza <miguel@ximian.com>
16933 * typemanager.cs (IsCLRType): New routine to tell whether a type
16934 is one of the builtin types.
16936 Maybe it needs to use TypeCodes to be faster. Maybe we could use
16937 typecode in more places instead of doing pointer comparissions.
16938 We could leverage some knowledge about the way the typecodes are
16941 New code to cache namespaces in assemblies, it is currently not
16942 invoked, to be used soon.
16944 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
16946 * expression.cs (Binary.ResolveOperator): specially handle
16947 strings, and do not perform user-defined operator overloading for
16950 2002-11-24 Miguel de Icaza <miguel@ximian.com>
16952 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
16953 internalcall as it is a pretty simple operation; Avoid whenever
16954 possible to call Char.IsLetter.
16956 (consume_identifier): Cut by half the number of
16957 hashtable calls by merging the is_keyword and GetKeyword behavior.
16959 Do not short-circuit, because if we do, we
16960 report errors (ie, #if false && true would produce an invalid
16964 2002-11-24 Martin Baulig <martin@ximian.com>
16966 * expression.cs (Cast.TryReduce): If we're in checked syntax,
16967 check constant ranges and report a CS0221. Fixes #33186.
16969 2002-11-24 Martin Baulig <martin@ximian.com>
16971 * cs-parser.jay: Make this work for uninitialized variable
16972 declarations in the `for' initializer. Fixes #32416.
16974 2002-11-24 Martin Baulig <martin@ximian.com>
16976 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
16977 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
16979 2002-11-24 Martin Baulig <martin@ximian.com>
16981 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
16982 argument; if true, we also check for user-defined conversions.
16983 This is only needed if both arguments are of a user-defined type.
16984 Fixes #30443, added test-175.cs.
16985 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
16987 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
16989 2002-11-24 Martin Baulig <martin@ximian.com>
16991 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
16992 function to get the store opcode.
16993 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
16994 only emit the Ldelema if the store opcode is Stobj. You must run
16995 both test-34 and test-167 to test this. Fixes #34529.
16997 2002-11-23 Martin Baulig <martin@ximian.com>
16999 * ecore.cs (Expression.MemberLookup): Added additional
17000 `qualifier_type' argument which is used when we're being called
17001 from MemberAccess.DoResolve() and null if we're called from a
17003 (Expression.MemberLookupFailed): New method to report errors; this
17004 does the CS1540 check and reports the correct error message.
17006 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
17007 argument for the CS1540 check and redone the way how we're dealing
17008 with private members. See the comment in the source code for details.
17009 (FilterWithClosure): Reverted this back to revision 1.197; renamed
17010 `closure_start_type' to `closure_qualifier_type' and check whether
17011 it's not null. It was not this filter being broken, it was just
17012 being called with the wrong arguments.
17014 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
17015 and pass it the correct `qualifier_type'; this also does the error
17018 2002-11-22 Miguel de Icaza <miguel@ximian.com>
17020 * expression.cs (Invocation.EmitParams): If the we are dealing
17021 with a non-built-in value type, load its address as well.
17023 (ArrayCreation): Use a a pretty constant instead
17024 of the hardcoded value 2. Use 6 instead of 2 for the number of
17025 static initializers.
17027 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
17028 because they are not really value types, just glorified integers.
17030 * driver.cs: Do not append .exe, the CSC compiler does not do it.
17032 * ecore.cs: Remove redundant code for enumerations, make them use
17033 the same code path as everything else, fixes the casting issue
17034 with enumerations in Windows.Forms.
17036 * attribute.cs: Do only cast to string if it is a string, the
17037 validation happens later.
17039 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
17040 people upgrade their corlibs.
17042 * ecore.cs: Oops, enumerations were not following the entire code path
17044 2002-11-21 Miguel de Icaza <miguel@ximian.com>
17046 * typemanager.cs (FilterWithClosure): Commented out the test for
17047 1540 in typemanager.cs, as it has problems when accessing
17048 protected methods from a parent class (see test-174.cs).
17050 * attribute.cs (Attribute.ValidateGuid): new method.
17051 (Attribute.Resolve): Use above.
17053 2002-11-19 Miguel de Icaza <miguel@ximian.com>
17055 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
17057 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
17058 handling for enumerations, as we only needed the TypeContainer
17059 functionality to begin with (this is required for the fix below to
17060 work for enums that reference constants in a container class for
17063 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
17065 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
17066 a valid TypeBuilder to perform lookups on.o
17068 * class.cs (InheritableMemberSignatureCompare): Use true in the
17069 call to GetGetMethod and GetSetMethod, because we are comparing
17070 the signature, and we need to get the methods *even* if they are
17073 (PropertyBase.CheckBase): ditto.
17075 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
17076 GotoCase.Resolve): Use Peel on EmpytCasts.
17078 * ecore.cs (EmptyCast): drop child, add Peel method.
17080 2002-11-17 Martin Baulig <martin@ximian.com>
17082 * ecore.cs (EmptyCast.Child): New public property.
17084 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
17085 label resolved to an EmptyCast. Fixes #34162.
17086 (GotoCase.Resolve): Likewise.
17087 (Block.EmitMeta): Likewise.
17089 2002-11-17 Martin Baulig <martin@ximian.com>
17091 * expression.cs (Invocation.BetterConversion): Prefer int over
17092 uint; short over ushort; long over ulong for integer literals.
17093 Use ImplicitConversionExists instead of StandardConversionExists
17094 since we also need to check for user-defined implicit conversions.
17095 Fixes #34165. Added test-173.cs.
17097 2002-11-16 Martin Baulig <martin@ximian.com>
17099 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
17100 with the `true' and `false' literals. Fixes #33151.
17102 2002-11-16 Martin Baulig <martin@ximian.com>
17104 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
17105 October 22nd; don't do the cs1540 check for static members.
17107 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
17108 now using our own filter here and doing the cs1540 check again.
17110 2002-11-16 Martin Baulig <martin@ximian.com>
17112 * support.cs (InternalParameters): Don't crash if we don't have
17113 any fixed parameters. Fixes #33532.
17115 2002-11-16 Martin Baulig <martin@ximian.com>
17117 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
17118 when looking up static methods to make this work on Windows.
17121 2002-11-16 Martin Baulig <martin@ximian.com>
17123 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
17124 a setter rather than using PropertyInfo.CanWrite.
17126 2002-11-15 Nick Drochak <ndrochak@gol.com>
17128 * class.cs: Allow acces to block member by subclasses. Fixes build
17131 2002-11-14 Martin Baulig <martin@ximian.com>
17133 * class.cs (Constructor.Emit): Added the extern/block check.
17136 2002-11-14 Martin Baulig <martin@ximian.com>
17138 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
17139 iteration while looking for indexers, this is needed because the
17140 indexer may have a different name in our base classes. Fixed the
17141 error reporting (no indexers at all, not get accessor, no
17142 overloaded match). Fixes bug #33089.
17143 (IndexerAccess.DoResolveLValue): Likewise.
17145 2002-11-14 Martin Baulig <martin@ximian.com>
17147 * class.cs (PropertyBase.CheckBase): Make this work for multiple
17148 indexers. Fixes the first part of bug #33089.
17149 (MethodSignature.InheritableMemberSignatureCompare): Added support
17152 2002-11-13 Ravi Pratap <ravi@ximian.com>
17154 * attribute.cs (Attribute.Resolve): Catch the
17155 NullReferenceException and report it since it isn't supposed to
17158 2002-11-12 Miguel de Icaza <miguel@ximian.com>
17160 * expression.cs (Binary.EmitBranchable): Also handle the cases for
17161 LogicalOr and LogicalAnd that can benefit from recursively
17162 handling EmitBranchable. The code now should be nice for Paolo.
17164 2002-11-08 Miguel de Icaza <miguel@ximian.com>
17166 * typemanager.cs (LookupType): Added a negative-hit hashtable for
17167 the Type lookups, as we perform quite a number of lookups on
17168 non-Types. This can be removed once we can deterministically tell
17169 whether we have a type or a namespace in advance.
17171 But this might require special hacks from our corlib.
17175 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
17176 and double which avoids a conversion from an integer to a double.
17178 * expression.cs: tiny optimization, avoid calling IsConstant,
17179 because it effectively performs the lookup twice.
17181 2002-11-06 Miguel de Icaza <miguel@ximian.com>
17183 But a bogus return here to keep the semantics of the old code
17184 until the Mono runtime is fixed.
17186 * pending.cs (GetMissingInterfaces): New method used to remove all
17187 the interfaces that are already implemented by our parent
17188 classes from the list of pending methods.
17190 * interface.cs: Add checks for calls after ResolveTypeExpr.
17192 2002-11-05 Miguel de Icaza <miguel@ximian.com>
17194 * class.cs (Class.Emit): Report warning 67: event not used if the
17195 warning level is beyond 3.
17197 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
17198 being a NullLiteral.
17200 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
17203 * class.cs (TypeContainer.GetClassBases): Cover a missing code
17204 path that might fail if a type can not be resolved.
17206 * expression.cs (Binary.Emit): Emit unsigned versions of the
17209 * driver.cs: use error 5.
17211 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
17213 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
17215 2002-11-01 Miguel de Icaza <miguel@ximian.com>
17217 * cs-parser.jay (switch_section): A beautiful patch from Martin
17218 Baulig that fixed 33094.
17220 2002-10-31 Miguel de Icaza <miguel@ximian.com>
17222 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
17223 Check whether the base is abstract and report an error if so.
17225 * expression.cs (IndexerAccess.DoResolveLValue,
17226 IndexerAccess.DoResolve): ditto.
17228 (Invocation.DoResolve): ditto.
17230 (Invocation.FullMethodDesc): Improve the report string.
17232 * statement.cs (Block): Eliminate IsVariableDefined as it is
17233 basically just a wrapper for GetVariableInfo.
17235 * ecore.cs (SimpleName): Use new
17237 * support.cs (ReflectionParamter.ParameterType): We unwrap the
17238 type, as we return the actual parameter ref/unref state on a
17241 2002-10-30 Miguel de Icaza <miguel@ximian.com>
17243 * support.cs: Return proper flags REF/OUT fixing the previous
17246 * expression.cs: Reverted last patch, that was wrong. Is_ref is
17247 not used to mean `ref' but `ref or out' in ParameterReference
17249 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
17250 full type signature instead of calling TypeManger.CSharpName
17253 * support.cs (InternalParameters.ParameterDesc): Do not compare
17254 directly to the modflags, because REF/OUT will actually be bitsets
17257 * delegate.cs (VerifyMethod): Check also the modifiers.
17259 * cs-tokenizer.cs: Fix bug where floating point values with an
17260 exponent where a sign was missing was ignored.
17262 * driver.cs: Allow multiple assemblies to be specified in a single
17265 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17267 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17268 because identifiers after a parenthesis would end up in this kind
17269 of production, and we needed to desamiguate it for having casts
17272 (UserDefinedType *) xxx
17274 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17276 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17277 we should set on the Bindingflags.NonPublic, but not turn on
17278 private_ok. private_ok controls whether a Private member is
17279 returned (this is chekced on the filter routine), while the
17280 BindingFlags.NonPublic just controls whether private/protected
17281 will be allowed. This fixes the problem part of the problem of
17282 private properties being allowed to be used in derived classes.
17284 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17285 so we can call the children DoResolveLValue method (this will
17286 properly signal errors on lvalue assignments to base properties)
17288 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17289 getter are null, and we have a property info, we know that this
17290 happened because the lookup failed, so we report an error 122 for
17291 protection level violation.
17293 We also silently return if setter and getter are null in the
17294 resolve functions, this condition only happens if we have flagged
17295 the error before. This is the other half of the problem.
17297 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17298 not have accessibility information, that is why we were returning
17299 true in the filter function in typemanager.cs.
17301 To properly report 122 (property is inaccessible because of its
17302 protection level) correctly, we report this error in ResolveAccess
17303 by failing if both the setter and the getter are lacking (ie, the
17306 DoResolve and DoLResolve have been modified to check for both
17307 setter/getter being null and returning silently, the reason being
17308 that I did not want to put the knowledge about this error in upper
17311 int old = Report.Errors;
17312 x = new PropertyExpr (...);
17313 if (old != Report.Errors)
17318 So the property expr is returned, but it is invalid, so the error
17319 will be flagged during the resolve process.
17321 * class.cs: Remove InheritablePropertySignatureCompare from the
17322 class, as we no longer depend on the property signature to compute
17323 whether it is possible to implement a method or not.
17325 The reason is that calling PropertyInfo.GetGetMethod will return
17326 null (in .NET, in Mono it works, and we should change this), in
17327 cases where the Get Method does not exist in that particular
17332 class X { public virtual int A { get { return 1; } } }
17334 class Z : Y { public override int A { get { return 2; } } }
17336 Would fail in Z because the parent (Y) would not have the property
17337 defined. So we avoid this completely now (because the alternative
17338 fix was ugly and slow), and we now depend exclusively on the
17341 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17342 reference method, instead of using the property.
17344 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17345 routines are gone now.
17347 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17348 names, they were incorrectly named.
17350 * cs-tokenizer.cs: Return are more gentle token on failure.
17352 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17353 had an out-of-sync index variable, which caused it to remove from
17354 the list of pending methods the wrong method sometimes.
17356 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17358 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17359 CanWrite, because those refer to this particular instance of the
17360 property, and do not take into account the fact that we can
17361 override single members of a property.
17363 Constructor requires an EmitContext. The resolution process does
17364 not happen here, but we need to compute the accessors before,
17365 because the resolution does not always happen for properties.
17367 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17368 subclass, before we did not update this flag, but we did update
17371 (GetAccessors): Drop this routine, as it did not work in the
17372 presence of partially overwritten set/get methods.
17374 Notice that this broke the cs1540 detection, but that will require
17377 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17381 * driver.cs: issue a warning instead of an error if we don't support
17382 debugging for the platform. Also ignore a couple of errors that may
17383 arise when trying to write the symbols. Undo my previous patch.
17385 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17387 * driver.cs: ignore /debug switch except for Unix platforms.
17389 2002-10-23 Nick Drochak <ndrochak@gol.com>
17391 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17393 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17395 * driver.cs: Do not make mcs-debug conditional, so we do not break
17396 builds that use it.
17398 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17399 review this patch. But basically after all the children variables
17400 have been merged, the value of "Breaks" was not being set to
17401 new_breaks for Switch blocks. I think that it should be set after
17402 it has executed. Currently I set this to the value of new_breaks,
17403 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17404 conservative, but I do not understand this code very well.
17406 I did not break anything in the build, so that is good ;-)
17408 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17410 2002-10-20 Mark Crichton <crichton@gimp.org>
17412 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17414 2002-10-20 Nick Drochak <ndrochak@gol.com>
17416 * cfold.cs: Fixed compile blocker.
17418 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17420 * driver.cs: I was chekcing the key, not the file.
17422 2002-10-19 Ravi Pratap <ravi@ximian.com>
17424 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17425 message that we were generating - we just need to silently return
17428 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17430 * class.cs (Event.Define): Change my previous commit, as this
17431 breaks the debugger. This is a temporary hack, as it seems like
17432 the compiler is generating events incorrectly to begin with.
17434 * expression.cs (Binary.ResolveOperator): Added support for
17435 "U operator - (E x, E y)"
17437 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17440 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17441 init-only variables, but this path did not take into account that
17442 there might be also instance readonly variables. Correct this
17445 This fixes bug 32253
17447 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17450 * driver.cs: Change the extension for modules to `netmodule'
17452 * cs-parser.jay: Improved slightly the location tracking for
17453 the debugger symbols.
17455 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17456 modifiers that were specified instead of the hardcoded value
17457 (FamAndAssem). This was basically ignoring the static modifier,
17458 and others. Fixes 32429.
17460 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17461 fixed a bug in the process (32476)
17463 * expression.cs (ArrayAccess.EmitAssign): Patch from
17464 hwang_rob@yahoo.ca that fixes bug 31834.3
17466 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17468 * driver.cs: Make the module extension .netmodule.
17470 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17472 * driver.cs: Report an error if the resource file is not found
17473 instead of crashing.
17475 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17476 false, like Emit does.
17478 2002-10-16 Nick Drochak <ndrochak@gol.com>
17480 * typemanager.cs: Remove unused private member. Also reported mcs
17481 bug to report this as a warning like csc.
17483 2002-10-15 Martin Baulig <martin@gnome.org>
17485 * statement.cs (Statement.Emit): Made this a virtual method; emits
17486 the line number info and calls DoEmit().
17487 (Statement.DoEmit): New protected abstract method, formerly knows
17488 as Statement.Emit().
17490 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17492 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17494 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17495 have fixed a remaining problem: not every AddXXXX was adding a
17496 fully qualified name.
17498 Now everyone registers a fully qualified name in the DeclSpace as
17499 being defined instead of the partial name.
17501 Downsides: we are slower than we need to be due to the excess
17502 copies and the names being registered this way.
17504 The reason for this is that we currently depend (on the corlib
17505 bootstrap for instance) that types are fully qualified, because
17506 we dump all the types in the namespace, and we should really have
17507 types inserted into the proper namespace, so we can only store the
17508 basenames in the defined_names array.
17510 2002-10-10 Martin Baulig <martin@gnome.org>
17512 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17513 from bug #31834, see the bug report for a testcase which is
17516 2002-10-10 Martin Baulig <martin@gnome.org>
17518 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17519 flow analysis code for this.
17521 * statement.cs (Do, While, For): Tell the flow analysis code about
17523 (FlowBranching.UsageVector): Added support for infinite loops.
17524 (Block.Resolve): Moved the dead code elimination here and use flow
17527 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17529 * class.cs (Field.Define): Catch cycles on struct type
17532 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17533 fields if the fields are static. We only need to check instance
17536 * expression.cs (As.DoResolve): Test for reference type.
17538 * statement.cs (Using.ResolveExpression): Use
17539 ConvertImplicitRequired, not ConvertImplicit which reports an
17541 (Using.ResolveLocalVariableDecls): ditto.
17543 * expression.cs (Binary.ResolveOperator): Report errors in a few
17544 places where we had to.
17546 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17548 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17550 * expression.cs: Use StoreFromPtr instead of extracting the type
17551 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17553 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17554 an enumeration value to a System.Enum, but System.Enum is not a
17555 value type, but an class type, so we need to box.
17557 (Expression.ConvertExplicit): One codepath could return
17558 errors but not flag them. Fix this. Fixes #31853
17560 * parameter.cs (Resolve): Do not allow void as a parameter type.
17562 2002-10-06 Martin Baulig <martin@gnome.org>
17564 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17565 if it's a class type and not a struct. Fixes #31815.
17567 2002-10-06 Martin Baulig <martin@gnome.org>
17569 * statement.cs: Reworked the flow analysis code a bit to make it
17570 usable for dead code elimination.
17572 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17574 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17576 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17578 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17579 to fix the test 165, will investigate deeper.
17581 2002-10-04 Martin Baulig <martin@gnome.org>
17583 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17584 finally blocks actually work.
17585 (Try.Resolve): We don't need to create a sibling for `finally' if
17586 there is no finally block.
17588 2002-10-04 Martin Baulig <martin@gnome.org>
17590 * class.cs (Constructor.Define): The default accessibility for a
17591 non-default constructor is private, not public.
17593 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17595 * class.cs (Constructor): Make AllowedModifiers public, add
17598 * cs-parser.jay: Perform the modifiers test here, as the
17599 constructor for the Constructor class usually receives a zero
17600 because of the way we create it (first we create, later we
17601 customize, and we were never checking the modifiers).
17603 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17604 is a version of LookupTypeReflection that includes the type-name
17605 cache. This can be used as a fast path for functions that know
17606 the fully qualified name and are only calling into *.GetType() to
17607 obtain a composed type.
17609 This is also used by TypeManager.LookupType during its type
17612 (LookupType): We now also track the real type name, as sometimes
17613 we can get a quey for the real type name from things like
17614 ComposedCast. This fixes bug 31422.
17616 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17617 complete type fullname, it does not have to go through the type
17618 resolution system to obtain the composed version of the type (for
17619 obtaining arrays or pointers).
17621 (Conditional.Emit): Use the EmitBoolExpression to
17622 generate nicer code, as requested by Paolo.
17624 (ArrayCreation.CheckIndices): Use the patch from
17625 hwang_rob@yahoo.ca to validate the array initializers.
17627 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17629 * class.cs (ConstructorInitializer.Emit): simplify code by using
17630 Invocation.EmitCall, and at the same time, fix the bugs in calling
17631 parent constructors that took variable arguments.
17633 * ecore.cs (Expression.ConvertNumericExplicit,
17634 Expression.ImplicitNumericConversion): Remove the code that
17635 manually wrapped decimal (InternalTypeConstructor call is now gone
17638 * expression.cs (Cast.TryReduce): Also handle decimal types when
17639 trying to perform a constant fold on the type.
17641 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17643 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17644 that only turned off an error report, and did nothing else.
17646 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17648 * driver.cs: Handle and ignore /fullpaths
17650 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17652 * expression.cs (Binary.ResolveOperator): Catch the case where
17653 DoNumericPromotions returns true,
17655 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17657 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17659 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17662 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17664 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17665 conversion exists, but it is also required that the conversion be
17666 performed. This manifested in "(Type64Enum) 2".
17668 * class.cs (TypeManager.AddMethod): The fix is not to change
17669 AddEnum, because that one was using a fully qualified name (every
17670 DeclSpace derivative does), but to change the AddMethod routine
17671 that was using an un-namespaced name. This now correctly reports
17672 the duplicated name.
17674 Revert patch until I can properly fix it. The issue
17675 is that we have a shared Type space across all namespaces
17676 currently, which is wrong.
17678 Options include making the Namespace a DeclSpace, and merge
17679 current_namespace/current_container in the parser.
17681 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17683 * cs-parser.jay: Improve error reporting when we get a different
17684 kind of expression in local_variable_type and
17685 local_variable_pointer_type.
17687 Propagate this to avoid missleading errors being reported.
17689 * ecore.cs (ImplicitReferenceConversion): treat
17690 TypeManager.value_type as a target just like object_type. As
17695 Is valid, and needs to result in the int 1 being boxed before it
17696 is assigned to the value type v.
17698 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17699 to validate the enumeration name.
17701 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17702 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17703 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17705 * ecore.cs (TryImplicitIntConversion): When doing an
17706 implicit-enumeration-conversion, check if the type is 64-bits and
17707 perform a conversion before passing to EnumConstant.
17709 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17711 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17712 report ambiguous type references. Unlike the MS version, we
17713 report what the ambiguity is. Innovation at work ;-)
17715 (DeclSpace.FindType): Require a location argument to
17716 display when we display an ambiguous error.
17718 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17720 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17722 * expression.cs (EmitDynamicInitializers): Apply patch from
17723 hwang_rob@yahoo.ca that fixes the order in which we emit our
17726 2002-09-21 Martin Baulig <martin@gnome.org>
17728 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17729 delegate takes no arguments.
17731 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17733 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17736 * expression.cs: Extract the underlying type.
17738 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17740 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17742 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17744 * class.cs (TypeContainer.DefineType): We can not use the nice
17745 PackingSize with the size set to 1 DefineType method, because it
17746 will not allow us to define the interfaces that the struct
17749 This completes the fixing of bug 27287
17751 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17752 means also structs. This fixes part of the problem.
17753 (Expresion.ImplicitReferenceConversionExists): ditto.
17755 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17756 error if there were no errors reported during the type lookup
17757 process, to avoid duplicates or redundant errors. Without this
17758 you would get an ambiguous errors plus a type not found. We have
17759 beaten the user enough with the first error.
17761 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17764 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17765 during the resolution process, stop the lookup, this avoids
17766 repeated error reports (same error twice).
17768 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17770 * typemanager.cs (LookupType): Redo the type lookup code to match
17771 the needs of System.Reflection.
17773 The issue is that System.Reflection requires references to nested
17774 types to begin with a "+" sign instead of a dot. So toplevel
17775 types look like: "NameSpace.TopLevelClass", and nested ones look
17776 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17779 2002-09-19 Martin Baulig <martin@gnome.org>
17781 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17782 says that a method always returns or always throws an exception,
17783 don't report the CS0161.
17785 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17786 set `Returns = new_returns'.
17788 2002-09-19 Martin Baulig <martin@gnome.org>
17790 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17791 to an enum constant, check for a CS0176.
17793 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17795 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17796 for operators that must be in pairs and report errors.
17798 * ecore.cs (SimpleName.DoResolveType): During the initial type
17799 resolution process, when we define types recursively, we must
17800 check first for types in our current scope before we perform
17801 lookups in the enclosing scopes.
17803 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17805 (Invocation.VerifyArgumentsCompat): Call
17806 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17807 I thought we were supposed to always call this, but there are a
17808 few places in the code where we dont do it.
17810 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17812 * driver.cs: Add support in -linkres and -resource to specify the
17813 name of the identifier.
17815 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17817 * ecore.cs (StandardConversionExists): Sync with the conversion
17818 code: allow anything-* to void* conversions.
17820 (FindMostSpecificSource): Use an Expression argument
17821 instead of a Type, because we might be handed over a Literal which
17822 gets a few more implicit conversions that plain types do not. So
17823 this information was being lost.
17825 Also, we drop the temporary type-holder expression when not
17828 2002-09-17 Martin Baulig <martin@gnome.org>
17830 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17831 this is an explicit interface implementation.
17833 2002-09-17 Martin Baulig <martin@gnome.org>
17835 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17836 different `IndexerName' attributes.
17838 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17839 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17840 virtual CommonResolve().
17842 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17844 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17845 and convert that to the UnderlyingType.
17847 * statement.cs (Foreach.Resolve): Indexers are just like variables
17848 or PropertyAccesses.
17850 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17851 inside quoted strings, we were not doing this before.
17853 2002-09-16 Martin Baulig <martin@gnome.org>
17855 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17856 resolve it. This is needed for the definite assignment check of the
17857 instance expression, fixes bug #29846.
17858 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17860 2002-09-16 Nick Drochak <ndrochak@gol.com>
17862 * parameter.cs: Fix compile error. Cannot reference static member
17863 from an instance object. Is this an mcs bug?
17865 2002-09-14 Martin Baulig <martin@gnome.org>
17867 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17868 multiple times. Fixes bug #30295, added test-166.cs.
17870 2002-09-14 Martin Baulig <martin@gnome.org>
17872 * statement.cs (Block.Emit): Don't emit unreachable code.
17873 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
17874 `break' statements.
17875 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
17877 2002-09-14 Martin Baulig <martin@gnome.org>
17879 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
17882 2002-09-14 Martin Baulig <martin@gnome.org>
17884 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
17885 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
17886 be false on the ms runtime.
17888 2002-09-13 Martin Baulig <martin@gnome.org>
17890 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
17891 the CS0038 error message.
17893 2002-09-12 Miguel de Icaza <miguel@ximian.com>
17895 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
17896 constant inside, return it.
17898 2002-09-12 Martin Baulig <martin@gnome.org>
17900 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
17901 implicit conversion can be done between enum types.
17903 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
17904 check whether an implicit conversion to the current enum's UnderlyingType
17905 exists and report an error if not.
17907 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
17908 without debugging support.
17910 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
17911 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
17913 2002-09-12 Martin Baulig <martin@gnome.org>
17915 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
17917 * ecore.cs (IMemberExpr.DeclaringType): New property.
17918 (SimpleName.SimpleNameResolve): Check whether we're accessing a
17919 nonstatic member of an outer type (CS0038).
17921 2002-09-11 Miguel de Icaza <miguel@ximian.com>
17923 * driver.cs: Activate the using-error detector at warning level
17924 4 (at least for MS-compatible APIs).
17926 * namespace.cs (VerifyUsing): Small buglett fix.
17928 * pending.cs (PendingImplementation): pass the container pointer.
17930 * interface.cs (GetMethods): Allow for recursive definition. Long
17931 term, I would like to move every type to support recursive
17932 definitions, not the current ordering mechanism that we have right
17935 The situation is this: Attributes are handled before interfaces,
17936 so we can apply attributes to interfaces. But some attributes
17937 implement interfaces, we will now handle the simple cases
17938 (recursive definitions will just get an error).
17940 * parameter.cs: Only invalidate types at the end if we fail to
17943 2002-09-09 Martin Baulig <martin@gnome.org>
17945 * ecore.cs (PropertyExpr.Emit): Also check for
17946 TypeManager.system_int_array_get_length so this'll also work when
17947 compiling corlib. Fixes #30003.
17949 2002-09-09 Martin Baulig <martin@gnome.org>
17951 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
17952 and throw an exception if we can't get the type's size. Fixed #30040,
17955 2002-09-09 Martin Baulig <martin@gnome.org>
17957 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
17959 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
17960 context. Fixes bug #30027.
17962 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
17963 virtual functions. Fixes bug #30043, added test-164.cs.
17965 2002-09-08 Ravi Pratap <ravi@ximian.com>
17967 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
17969 2002-09-08 Nick Drochak <ndrochak@gol.com>
17971 * driver.cs: Use an object to get the windows codepage since it's not a
17974 2002-09-08 Miguel de Icaza <miguel@ximian.com>
17976 * statement.cs (For.Emit): for infinite loops (test == null)
17977 return whether there is a break inside, not always "true".
17979 * namespace.cs (UsingEntry): New struct to hold the name of the
17980 using definition, the location where it is defined, and whether it
17981 has been used in a successful type lookup.
17983 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
17988 2002-09-06 Ravi Pratap <ravi@ximian.com>
17990 * attribute.cs : Fix incorrect code which relied on catching
17991 a NullReferenceException to detect a null being passed in
17992 where an object was expected.
17994 2002-09-06 Miguel de Icaza <miguel@ximian.com>
17996 * statement.cs (Try): flag the catch variable as assigned
17998 * expression.cs (Cast): Simplified by using ResolveType instead of
17999 manually resolving.
18001 * statement.cs (Catch): Fix bug by using ResolveType.
18003 2002-09-06 Ravi Pratap <ravi@ximian.com>
18005 * expression.cs (BetterConversion): Special case for when we have
18006 a NullLiteral as the argument and we have to choose between string
18007 and object types - we choose string the way csc does.
18009 * attribute.cs (Attribute.Resolve): Catch the
18010 NullReferenceException and report error #182 since the Mono
18011 runtime no more has the bug and having this exception raised means
18012 we tried to select a constructor which takes an object and is
18015 2002-09-05 Ravi Pratap <ravi@ximian.com>
18017 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
18018 message (1502, 1503) when we can't locate a method after overload
18019 resolution. This is much more informative and closes the bug
18022 * interface.cs (PopulateMethod): Return if there are no argument
18023 types. Fixes a NullReferenceException bug.
18025 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
18026 expressions too. Previously we were checking only in one place for
18027 positional arguments leaving out named arguments.
18029 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
18030 type to the enum type is not allowed. Remove code corresponding to
18033 (ConvertNumericExplicit): Allow explicit conversions from
18034 the underlying type to enum type. This precisely follows the spec
18035 and closes a bug filed by Gonzalo.
18037 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18040 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
18042 2002-09-03 Miguel de Icaza <miguel@ximian.com>
18044 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
18045 it was important that we stored the right value after the
18046 reduction in `converted'.
18048 2002-09-04 Martin Baulig <martin@gnome.org>
18050 * location.cs (Location.SymbolDocument): Use full pathnames for the
18053 2002-08-30 Miguel de Icaza <miguel@ximian.com>
18055 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
18056 of the expression resolve mechanism, because that will catch the
18057 SimpleName error failures.
18059 (Conditional): If we can not resolve the
18060 expression, return, do not crash.
18062 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18065 (location): display token name instead of its number.
18067 2002-08-28 Martin Baulig <martin@gnome.org>
18069 * expression.cs (Binary.ResolveOperator): Don't silently return
18070 but return an error if an operator cannot be applied between two
18073 2002-08-28 Martin Baulig <martin@gnome.org>
18075 * class.cs (Constructor.Define): Set the permission attributes
18076 correctly instead of making all constructors public.
18078 2002-08-28 Martin Baulig <martin@gnome.org>
18080 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
18081 for private members before reporting a CS0103; if we find anything,
18084 2002-08-28 Martin Baulig <martin@gnome.org>
18086 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
18087 to check whether `closure_start_type == closure_invocation_type',
18088 we also need to check whether `m.DeclaringType == closure_invocation_type'
18089 before bypassing the permission checks. We might be accessing
18090 protected/private members from the base class.
18091 (TypeManager.RealMemberLookup): Only set private_ok if private
18092 members were requested via BindingFlags.NonPublic.
18094 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
18096 * expression.cs (MemberAccess.ResolveMemberAccess): Set
18097 MethodGroupExpr.IsExplicitImpl if appropriate.
18098 (Invocation.DoResolve): Don't report the CS0120 for explicit
18099 interface implementations.
18101 2002-08-27 Martin Baulig <martin@gnome.org>
18103 * expression.cs (Invocation.DoResolve): If this is a static
18104 method and we don't have an InstanceExpression, we must report
18107 2002-08-25 Martin Baulig <martin@gnome.org>
18109 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
18110 `==' between a valuetype and an object.
18112 2002-08-25 Miguel de Icaza <miguel@ximian.com>
18114 * ecore.cs (TypeExpr): Provide a ToString method.
18116 2002-08-24 Martin Baulig <martin@gnome.org>
18118 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
18119 now called proggie.dbg and it's a binary file.
18121 2002-08-23 Martin Baulig <martin@gnome.org>
18123 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
18125 2002-08-23 Martin Baulig <martin@gnome.org>
18127 * struct.cs (MyStructInfo.ctor): Make this work with empty
18128 structs; it's not allowed to use foreach() on null.
18130 2002-08-23 Martin Baulig <martin@gnome.org>
18132 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
18133 writer the full pathname of the generated assembly.
18135 2002-08-23 Martin Baulig <martin@gnome.org>
18137 * statements.cs (FlowBranching.UsageVector.MergeChildren):
18138 A `finally' block never returns or breaks; improved handling of
18141 2002-08-23 Martin Baulig <martin@gnome.org>
18143 * statement.cs (Throw.Resolve): Allow `throw null'.
18145 2002-08-23 Martin Baulig <martin@gnome.org>
18147 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
18148 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
18149 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
18150 MemberLookup would return a wrong event if this is an explicit
18151 interface implementation and the class has an event with the same
18154 2002-08-23 Martin Baulig <martin@gnome.org>
18156 * statement.cs (Block.AddChildVariableNames): New public method.
18157 (Block.AddChildVariableName): Likewise.
18158 (Block.IsVariableNameUsedInChildBlock): Likewise.
18159 (Block.AddVariable): Check whether a variable name has already
18160 been used in a child block.
18162 * cs-parser.jay (declare_local_variables): Mark all variable names
18163 from the current block as being used in a child block in the
18166 2002-08-23 Martin Baulig <martin@gnome.org>
18168 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
18169 find the symbol writer.
18171 * driver.cs: csc also allows the arguments to /define being
18172 separated by commas, not only by semicolons.
18174 2002-08-23 Martin Baulig <martin@gnome.org>
18176 * interface.cs (Interface.GetMembers): Added static check for events.
18178 2002-08-15 Martin Baulig <martin@gnome.org>
18180 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
18181 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
18183 * ecore.cs (Expression.MemberLookup): Added documentation and explained
18184 why the MethodData.EmitDestructor() change was necessary.
18186 2002-08-20 Martin Baulig <martin@gnome.org>
18188 * class.cs (TypeContainer.FindMembers): Added static check for events.
18190 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
18192 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
18193 use Type.GetEvents(), not Type.FindMembers().
18195 2002-08-20 Martin Baulig <martin@gnome.org>
18197 * decl.cs (MemberCache): Added a special method cache which will
18198 be used for method-only searched. This ensures that a method
18199 search will return a MethodInfo with the correct ReflectedType for
18202 2002-08-20 Martin Baulig <martin@gnome.org>
18204 * decl.cs (DeclSpace.FindMembers): Made this public.
18206 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18208 * delegate.cs: fixed build on windows.
18209 [FIXME: Filed as bug #29150: MCS must report these errors.]
18211 2002-08-19 Ravi Pratap <ravi@ximian.com>
18213 * ecore.cs (StandardConversionExists): Return a false
18214 if we are trying to convert the void type to anything else
18215 since that is not allowed.
18217 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
18218 we flag error 70 in the event an event is trying to be accessed
18219 directly from outside the declaring type.
18221 2002-08-20 Martin Baulig <martin@gnome.org>
18223 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
18224 MemberCache from typemanager.cs to decl.cs.
18226 2002-08-19 Martin Baulig <martin@gnome.org>
18228 * class.cs (TypeContainer): Implement IMemberContainer.
18229 (TypeContainer.DefineMembers): Create the MemberCache.
18230 (TypeContainer.FindMembers): Do better BindingFlags checking; only
18231 return public members if BindingFlags.Public was given, check
18232 whether members are static.
18234 2002-08-16 Martin Baulig <martin@gnome.org>
18236 * decl.cs (DeclSpace.Define): Splitted this in Define and
18237 DefineMembers. DefineMembers is called first and initializes the
18240 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
18241 DefineMembers() on all our DeclSpaces.
18243 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
18244 but call DefineMembers() on all nested interfaces. We call their
18245 Define() in our new Define() function.
18247 * interface.cs (Interface): Implement IMemberContainer.
18248 (Interface.Define): Moved all code except the attribute stuf to
18250 (Interface.DefineMembers): Initialize the member cache.
18252 * typemanager.cs (IMemberFinder): Removed this interface, we don't
18253 need this anymore since we can use MemberCache.FindMembers directly.
18255 2002-08-19 Martin Baulig <martin@gnome.org>
18257 * typemanager.cs (MemberCache): When creating the cache for an
18258 interface type, add all inherited members.
18259 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18260 to `out bool used_cache' and documented it.
18261 (TypeManager.MemberLookup): If we already used the cache in the first
18262 iteration, we don't need to do the interfaces check.
18264 2002-08-19 Martin Baulig <martin@gnome.org>
18266 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18267 here from IMemberFinder and don't implement this interface anymore.
18268 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18270 * typemanager.cs (IMemberFinder): This interface is now only used by
18271 classes which actually support the member cache.
18272 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18273 since we only put DeclSpaces into this Hashtable.
18274 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18275 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18277 2002-08-16 Martin Baulig <martin@gnome.org>
18279 * typemanager.cs (ICachingMemberFinder): Removed.
18280 (IMemberFinder.MemberCache): New property.
18281 (TypeManager.FindMembers): Merged this with RealFindMembers().
18282 This function will never be called from TypeManager.MemberLookup()
18283 so we can't use the cache here, just the IMemberFinder.
18284 (TypeManager.MemberLookup_FindMembers): Check whether the
18285 IMemberFinder has a MemberCache and call the cache's FindMembers
18287 (MemberCache): Rewrote larger parts of this yet another time and
18288 cleaned it up a bit.
18290 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18292 * driver.cs (LoadArgs): Support quoting.
18294 (Usage): Show the CSC-like command line arguments.
18296 Improved a few error messages.
18298 2002-08-15 Martin Baulig <martin@gnome.org>
18300 * typemanager.cs (IMemberContainer.Type): New property.
18301 (IMemberContainer.IsInterface): New property.
18303 The following changes are conditional to BROKEN_RUNTIME, which is
18304 defined at the top of the file.
18306 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18307 class'es members, but add all members from TypeHandle.ObjectType
18308 if we're an interface.
18309 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18310 is the current type.
18311 (MemberCache.CacheEntry.Container): Removed this field.
18312 (TypeHandle.GetMembers): Include inherited members.
18314 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18316 * typemanager.cs: fixed compilation and added a comment on a field that
18319 2002-08-15 Martin Baulig <martin@gnome.org>
18321 * class.cs (ConstructorInitializer.Resolve): In the
18322 Expression.MemberLookup call, use the queried_type as
18325 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18326 declared' attribute, it's always true.
18327 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18328 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18329 temporary wrapper for FindMembers which tells MemberLookup whether
18330 members from the base classes are included in the return value.
18331 This will go away soon.
18332 (TypeManager.MemberLookup): Use this temporary hack here; once the
18333 new MemberCache is completed, we don't need to do the DeclaredOnly
18334 looping here anymore since the MemberCache will take care of this.
18335 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18336 (MemberCache): When creating the MemberCache for a class, get
18337 members from the current class and all its base classes.
18338 (MemberCache.CacheEntry.Container): New field. This is a
18339 temporary hack until the Mono runtime is fixed to distinguish
18340 between ReflectedType and DeclaringType. It allows us to use MCS
18341 with both the MS runtime and the unfixed Mono runtime without
18342 problems and without accecting performance.
18343 (MemberCache.SearchMembers): The DeclaredOnly looping from
18344 TypeManager.MemberLookup is now done here.
18346 2002-08-14 Martin Baulig <martin@gnome.org>
18348 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18349 Type.GetFields on dynamic types but get the fields from the
18350 corresponding TypeContainer.
18351 (MyStructInfo.GetStructInfo): Added check for enum types.
18353 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18354 (MemberList.SyncRoot): Implemented.
18355 (TypeManager.FilterWithClosure): No need to check permissions if
18356 closure_start_type == closure_invocation_type, don't crash if
18357 closure_invocation_type is null.
18359 2002-08-13 Martin Baulig <martin@gnome.org>
18361 Rewrote TypeContainer.FindMembers to use a member cache. This
18362 gives us a speed increase of about 35% for the self-hosting MCS
18363 build and of about 15-20% for the class libs (both on GNU/Linux).
18365 * report.cs (Timer): New class to get enhanced profiling. This
18366 whole class is "TIMER" conditional since it remarkably slows down
18369 * class.cs (MemberList): New class. This is an IList wrapper
18370 which we're now using instead of passing MemberInfo[]'s around to
18371 avoid copying this array unnecessarily.
18372 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18373 (ICachingMemberFinder, IMemberContainer): New interface.
18374 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18375 has already been checked, otherwise use it for the name comparision.
18376 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18377 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18378 if possible. Returns a MemberList, not a MemberInfo [].
18379 (TypeHandle): New class, implements IMemberContainer. We create
18380 one instance of this class per type, it contains a MemberCache
18381 which is used to do the member lookups.
18382 (MemberCache): New class. Each instance of this class contains
18383 all members of a type and a name-based hash table.
18384 (MemberCache.FindMembers): This is our new member lookup
18385 function. First, it looks up all members of the requested name in
18386 the hash table. Then, it walks this list and sorts out all
18387 applicable members and returns them.
18389 2002-08-13 Martin Baulig <martin@gnome.org>
18391 In addition to a nice code cleanup, this gives us a performance
18392 increase of about 1.4% on GNU/Linux - not much, but it's already
18393 half a second for the self-hosting MCS compilation.
18395 * typemanager.cs (IMemberFinder): New interface. It is used by
18396 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18397 Enum, Delegate or Interface.
18398 (TypeManager.finder_to_member_finder): New PtrHashtable.
18399 (TypeManager.finder_to_container): Removed.
18400 (TypeManager.finder_to_delegate): Removed.
18401 (TypeManager.finder_to_interface): Removed.
18402 (TypeManager.finder_to_enum): Removed.
18404 * interface.cs (Interface): Implement IMemberFinder.
18406 * delegate.cs (Delegate): Implement IMemberFinder.
18408 * enum.cs (Enum): Implement IMemberFinder.
18410 * class.cs (TypeContainer): Implement IMemberFinder.
18412 2002-08-12 Martin Baulig <martin@gnome.org>
18414 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18416 2002-08-12 Martin Baulig <martin@gnome.org>
18418 * ecore.cs (ITypeExpression): New interface for expressions which
18420 (TypeExpression): Renamed to TypeLookupExpression.
18421 (Expression.DoResolve): If we're doing a types-only lookup, the
18422 expression must implement the ITypeExpression interface and we
18423 call DoResolveType() on it.
18424 (SimpleName): Implement the new ITypeExpression interface.
18425 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18426 hack, the situation that we're only looking up types can't happen
18427 anymore when this method is called. Moved the type lookup code to
18428 DoResolveType() and call it.
18429 (SimpleName.DoResolveType): This ITypeExpression interface method
18430 is now doing the types-only lookup.
18431 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18432 (ResolveFlags): Added MaskExprClass.
18434 * expression.cs (MemberAccess): Implement the ITypeExpression
18436 (MemberAccess.DoResolve): Added support for a types-only lookup
18437 when we're called via ITypeExpression.DoResolveType().
18438 (ComposedCast): Implement the ITypeExpression interface.
18440 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18441 Expression.Resolve() with ResolveFlags.Type instead.
18443 2002-08-12 Martin Baulig <martin@gnome.org>
18445 * interface.cs (Interface.Define): Apply attributes.
18447 * attribute.cs (Attribute.ApplyAttributes): Added support for
18448 interface attributes.
18450 2002-08-11 Martin Baulig <martin@gnome.org>
18452 * statement.cs (Block.Emit): Only check the "this" variable if we
18453 do not always throw an exception.
18455 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18456 whether the property has a set accessor.
18458 2002-08-11 Martin Baulig <martin@gnome.org>
18460 Added control flow analysis support for structs.
18462 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18463 with control flow analysis turned off.
18464 (IVariable): New interface.
18465 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18466 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18467 (FieldExpr.DoResolve): Resolve the instance expression with flow
18468 analysis turned off and do the definite assignment check after the
18469 resolving when we know what the expression will resolve to.
18471 * expression.cs (LocalVariableReference, ParameterReference):
18472 Implement the new IVariable interface, only call the flow analysis
18473 code if ec.DoFlowAnalysis is true.
18474 (This): Added constructor which takes a Block argument. Implement
18475 the new IVariable interface.
18476 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18477 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18478 This does the definite assignment checks for struct members.
18480 * class.cs (Constructor.Emit): If this is a non-static `struct'
18481 constructor which doesn't have any initializer, call
18482 Block.AddThisVariable() to tell the flow analysis code that all
18483 struct elements must be initialized before control returns from
18486 * statement.cs (MyStructInfo): New public class.
18487 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18488 argument to this indexer. If non-zero, check an individual struct
18489 member, not the whole struct.
18490 (FlowBranching.CheckOutParameters): Check struct members.
18491 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18492 overloaded versions of these methods which take an additional
18493 `int field_idx' argument to check struct members.
18494 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18495 overloaded versions of these methods which take an additional
18496 `string field_name' argument to check struct member.s
18497 (VariableInfo): Implement the IVariable interface.
18498 (VariableInfo.StructInfo): New public property. Returns the
18499 MyStructInfo instance of the variable if it's a struct or null.
18500 (Block.AddThisVariable): New public method. This is called from
18501 Constructor.Emit() for non-static `struct' constructor which do
18502 not have any initializer. It creates a special variable for the
18503 "this" instance variable which will be checked by the flow
18504 analysis code to ensure that all of the struct's fields are
18505 initialized before control returns from the constructor.
18506 (UsageVector): Added support for struct members. If a
18507 variable/parameter is a struct with N members, we reserve a slot
18508 in the usage vector for each member. A struct is considered fully
18509 initialized if either the struct itself (slot 0) or all its
18510 members are initialized.
18512 2002-08-08 Martin Baulig <martin@gnome.org>
18514 * driver.cs (Driver.MainDriver): Only report an error CS5001
18515 if there were no compilation errors.
18517 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18518 `UnsafeContext' property to determine whether the parent is in
18519 unsafe context rather than checking the parent's ModFlags:
18520 classes nested in an unsafe class are unsafe as well.
18522 2002-08-08 Martin Baulig <martin@gnome.org>
18524 * statement.cs (UsageVector.MergeChildren): Distinguish between
18525 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18526 we return. Added test17() and test18() to test-154.cs.
18528 2002-08-08 Martin Baulig <martin@gnome.org>
18530 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18531 Family access, make sure the invoking type isn't a subclass of the
18532 queried type (that'd be a CS1540).
18534 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18535 this method which takes an additional `Type invocation_type'.
18537 * expression.cs (BaseAccess.DoResolve): Use the base type as
18538 invocation and query type.
18539 (MemberAccess.DoResolve): If the lookup failed and we're about to
18540 report a CS0122, try a lookup with the ec.ContainerType - if this
18541 succeeds, we must report a CS1540.
18543 2002-08-08 Martin Baulig <martin@gnome.org>
18545 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18546 (MethodGroupExpr): Implement the IMemberExpr interface.
18548 * expression (MemberAccess.ResolveMemberAccess): No need to have
18549 any special code for MethodGroupExprs anymore, they're now
18552 2002-08-08 Martin Baulig <martin@gnome.org>
18554 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18555 Family, FamANDAssem and FamORAssem permissions.
18556 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18558 2002-08-08 Martin Baulig <martin@gnome.org>
18560 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18561 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18564 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18566 * driver.cs: implemented /resource option to embed managed resources.
18568 2002-08-07 Martin Baulig <martin@gnome.org>
18570 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18571 (FieldBase.HasFieldInitializer): New public property.
18572 (FieldBase.GetInitializerExpression): New public method. Resolves and
18573 returns the field initializer and makes sure it is only resolved once.
18574 (TypeContainer.EmitFieldInitializers): Call
18575 FieldBase.GetInitializerExpression to get the initializer, this ensures
18576 that it isn't resolved multiple times.
18578 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18579 the resolving process (SimpleName/MemberLookup) that we're currently
18580 emitting a field initializer (which must not access any instance members,
18581 this is an error CS0236).
18583 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18584 argument, if the `IsFieldInitializer' flag is set, we must report and
18585 error CS0236 and not an error CS0120.
18587 2002-08-07 Martin Baulig <martin@gnome.org>
18589 * ecore.cs (IMemberExpr): New public interface.
18590 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18591 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18592 if the expression is an IMemberExpr.
18594 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18595 to be null, implicitly default to `this' if we're non-static in
18596 this case. Simplified the code a lot by using the new IMemberExpr
18597 interface. Also fixed bug #28176 here.
18599 2002-08-06 Martin Baulig <martin@gnome.org>
18601 * cs-parser.jay (SimpleLookup): Removed. We need to create
18602 ParameterReferences during semantic analysis so that we can do a
18603 type-only search when resolving Cast, TypeOf and SizeOf.
18604 (block): Pass the `current_local_parameters' to the Block's
18607 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18608 argument to the constructor.
18609 (ConstructorInitializer.Resolve): Create a temporary implicit
18610 block with the parameters.
18612 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18613 references here if we aren't doing a type-only search.
18615 * statement.cs (Block): Added constructor which takes a
18616 `Parameters parameters' argument.
18617 (Block.Parameters): New public property.
18619 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18620 to `Parameters' and made it public readonly.
18622 2002-08-06 Martin Baulig <martin@gnome.org>
18624 * ecore.cs (Expression.Warning): Made this public as well.
18626 * report.cs (Report.Debug): Print the contents of collections.
18628 2002-08-06 Martin Baulig <martin@gnome.org>
18630 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18631 used to tell Resolve() which kinds of expressions it may return.
18632 (Expression.Resolve): Added overloaded version of this method which
18633 takes a `ResolveFlags flags' argument. This can be used to tell
18634 Resolve() which kinds of expressions it may return. Reports a
18636 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18637 ResolveFlags.SimpleName.
18638 (Expression.Error118): Added overloaded version of this method which
18639 takes a `ResolveFlags flags' argument. It uses the flags to determine
18640 which kinds of expressions are allowed.
18642 * expression.cs (Argument.ResolveMethodGroup): New public method.
18643 Resolves an argument, but allows a MethodGroup to be returned.
18644 This is used when invoking a delegate.
18646 * TODO: Updated a bit.
18648 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18650 Fixed compilation with csc.
18652 * ecore.cs: Expression.Error made public. Is this correct? Should
18653 Warning be made public too?
18655 * expression.cs: use ea.Location instead of ea.loc.
18656 [FIXME: Filed as bug #28607: MCS must report these errors.]
18658 2002-08-06 Martin Baulig <martin@gnome.org>
18660 * ecore.cs (Expression.loc): Moved the location here instead of
18661 duplicating it in all derived classes.
18662 (Expression.Location): New public property.
18663 (Expression.Error, Expression.Warning): Made them non-static and
18664 removed the location argument.
18665 (Expression.Warning): Added overloaded version which takes an
18666 `int level' argument.
18667 (Expression.Error118): Make this non-static and removed the
18668 expression and location arguments.
18669 (TypeExpr): Added location argument to the constructor.
18671 * expression.cs (StaticCallExpr): Added location argument to
18673 (Indirection, PointerArithmetic): Likewise.
18674 (CheckedExpr, UnCheckedExpr): Likewise.
18675 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18676 (StringPtr): Likewise.
18679 2002-08-05 Martin Baulig <martin@gnome.org>
18681 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18683 * assign.cs (Assign.DoResolve): Check whether the source
18684 expression is a value or variable.
18686 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18687 while resolving the corresponding blocks.
18689 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18690 an error, don't silently return null.
18692 * statement.cs (Block.AddVariable): Do the error reporting here
18693 and distinguish between CS0128 and CS0136.
18694 (Block.DoResolve): Report all unused labels (warning CS0164).
18695 (LabeledStatement): Pass the location to the constructor.
18696 (LabeledStatement.HasBeenReferenced): New property.
18697 (LabeledStatement.Resolve): Set it to true here.
18699 * statement.cs (Return.Emit): Return success even after reporting
18700 a type mismatch error (CS0126 or CS0127), this is what csc does and
18701 it avoids confusing the users with any consecutive errors.
18703 2002-08-05 Martin Baulig <martin@gnome.org>
18705 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18707 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18709 * expression.cs (MemberAccess.DoResolve): Silently return if an
18710 error has already been reported.
18712 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18713 error has already been reported.
18715 2002-08-05 Martin Baulig <martin@gnome.org>
18717 * statement.cs (UsageVector): Only initialize the `parameters'
18718 vector if we actually have any "out" parameters.
18720 2002-08-05 Martin Baulig <martin@gnome.org>
18722 * expression.cs (Binary.ResolveOperator): When combining delegates,
18723 they must have the same type.
18725 2002-08-05 Martin Baulig <martin@gnome.org>
18727 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18728 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18729 work with the ms runtime and we also don't need it: if we're a
18730 PropertyBuilder and not in the `indexer_arguments' hash, then we
18731 are a property and not an indexer.
18733 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18734 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18735 since the latter one doesn't work with the ms runtime.
18737 2002-08-03 Martin Baulig <martin@gnome.org>
18739 Fixed bugs #27998 and #22735.
18741 * class.cs (Method.IsOperator): New public field.
18742 (Method.CheckBase): Report CS0111 if there's already a method
18743 with the same parameters in the current class. Report CS0508 when
18744 attempting to change the return type of an inherited method.
18745 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18746 and it's not marked abstract or extern.
18747 (PropertyBase): New abstract base class for Property and Indexer.
18748 (PropertyBase.CheckBase): Moved here from Property and made it work
18750 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18751 the same so we can reuse it there.
18752 (Property, Indexer): Derive from PropertyBase.
18753 (MethodSignature.inheritable_property_signature_filter): New delegate
18754 to find properties and indexers.
18756 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18757 argument and improved error reporting.
18759 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18760 EmptyReadOnlyParameters and made it a property.
18762 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18763 version of this method which takes a `PropertyInfo indexer'.
18764 (TypeManager.RegisterIndexer): New method.
18766 * class.cs: Added myself as author of this file :-)
18768 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18770 * class.cs: fixed compilation on windoze.
18772 2002-08-03 Martin Baulig <martin@gnome.org>
18774 * interface.cs (Interface.GetInterfaceBases): Check whether all
18775 base interfaces are at least as accessible than the current one.
18777 * class.cs (TypeContainer.GetClassBases): Check whether base types
18778 are at least as accessible than the current type.
18779 (TypeContainer.AsAccessible): Implemented and made non-static.
18780 (MemberBase.CheckParameters): Report errors if the accessibility
18783 * delegate.cs (Delegate.Delegate): The default visibility is
18784 internal for top-level types and private for nested types.
18785 (Delegate.Define): Report errors if the accessibility checks fail.
18787 * enum.cs (Enum.Enum): The default visibility is internal for
18788 top-level types and private for nested types.
18789 (Enum.DefineType): Compute the correct visibility.
18791 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18792 function which takes a `bool is_toplevel' instead of a TypeContainer.
18794 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18797 2002-08-02 Martin Baulig <martin@gnome.org>
18799 * expression.cs (LocalVariableReferenc): Added constructor which
18800 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18801 (LocalVariableReference.IsReadOnly): New property.
18802 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18803 variable is readonly, use our own readonly flag to do this; you can
18804 use the new constructor to get a writable reference to a read-only
18807 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18808 reference to the local variable.
18810 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18812 * rootcontext.cs (ResolveCore): Also include System.Exception
18814 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18815 we reach an EmptyStatement.
18817 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18820 * expression.cs (Binary.ResolveOperator): Check error result in
18823 use brtrue/brfalse directly and avoid compares to null.
18825 2002-08-02 Martin Baulig <martin@gnome.org>
18827 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18828 Fixes bug #28407, added test-155.cs.
18830 2002-08-01 Martin Baulig <martin@gnome.org>
18832 * class.cs (Event.EmitDefaultMethod): Make this work with static
18833 events. Fixes #28311, added verify-3.cs.
18835 2002-08-01 Martin Baulig <martin@gnome.org>
18837 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18838 `is_disposable' fields.
18839 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18840 `hm.is_disposable' if we're using the collection pattern.
18841 (Foreach.EmitCollectionForeach): Use the correct type for the
18842 enumerator's local variable, only emit the try/finally block if
18843 necessary (fixes #27713).
18845 2002-08-01 Martin Baulig <martin@gnome.org>
18847 * ecore.cs (Expression.report118): Renamed to Error118 and made
18850 * statement.cs (Throw.Resolve): Check whether the expression is of
18851 the correct type (CS0118) and whether the type derives from
18852 System.Exception (CS0155).
18853 (Catch.Resolve): New method. Do the type lookup here and check
18854 whether it derives from System.Exception (CS0155).
18855 (Catch.CatchType, Catch.IsGeneral): New public properties.
18857 * typemanager.cs (TypeManager.exception_type): Added.
18859 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18861 * driver.cs: Updated About function.
18863 2002-07-31 Martin Baulig <martin@gnome.org>
18865 Implemented Control Flow Analysis.
18867 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18868 (EmitContext.CurrentBranching): Added.
18869 (EmitContext.StartFlowBranching): Added.
18870 (EmitContext.EndFlowBranching): Added.
18871 (EmitContext.KillFlowBranching): Added.
18872 (EmitContext.IsVariableAssigned): Added.
18873 (EmitContext.SetVariableAssigned): Added.
18874 (EmitContext.IsParameterAssigned): Added.
18875 (EmitContext.SetParameterAssigned): Added.
18876 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
18877 Added control flow analysis stuff here.
18879 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
18880 resolve the expression as lvalue.
18881 (LocalVariableReference.DoResolve): Check whether the variable has
18882 already been assigned.
18883 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
18884 the parameter as assigned here.
18885 (ParameterReference.DoResolve): Check whether the parameter has already
18887 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
18888 expression as lvalue.
18890 * statement.cs (FlowBranching): New class for the flow analysis code.
18891 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
18892 (LabeledStatement.IsDefined): New public property.
18893 (LabeledStatement.AddUsageVector): New public method to tell flow
18894 analyis that the label may be reached via a forward jump.
18895 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
18897 (VariableInfo.Number): New public field. This is used by flow analysis
18898 to number all locals of a block.
18899 (Block.CountVariables): New public property. This is the number of
18900 local variables in this block (including the locals from all parent
18902 (Block.EmitMeta): Number all the variables.
18904 * statement.cs: Added flow analysis support to all classes.
18906 2002-07-31 Martin Baulig <martin@gnome.org>
18908 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
18909 To get debugging messages, compile mcs with /define:MCS_DEBUG and
18910 then use this argument.
18912 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
18914 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
18915 use this to specify /define options.
18917 2002-07-29 Martin Baulig <martin@gnome.org>
18919 * statement.cs (Fixed): Moved all code that does variable lookups
18920 and resolvings from Emit to Resolve.
18922 * statement.cs (For): Moved all code that does variable lookups
18923 and resolvings from Emit to Resolve.
18925 * statement.cs (Using): Moved all code that does variable lookups
18926 and resolvings from Emit to Resolve.
18928 2002-07-29 Martin Baulig <martin@gnome.org>
18930 * attribute.cs (Attribute.Resolve): Explicitly catch a
18931 System.NullReferenceException when creating the
18932 CustromAttributeBuilder and report a different warning message.
18934 2002-07-29 Martin Baulig <martin@gnome.org>
18936 * support.cs (ParameterData.ParameterName): Added method to
18937 get the name of a parameter.
18939 * typemanager.cs (TypeManager.IsValueType): New public method.
18941 2002-07-29 Martin Baulig <martin@gnome.org>
18943 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
18944 is a flag which specifies that it's either ref or out.
18945 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
18946 the out parameter to `out Parameter.Modifier mod', also set the
18947 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
18949 * support.cs (InternalParameters.ParameterModifier): Distinguish
18950 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18951 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18953 * expression.cs (Argument.GetParameterModifier): Distinguish
18954 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18955 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18957 2002-07-29 Martin Baulig <martin@gnome.org>
18959 * expression.cs (ParameterReference.ParameterReference): Added
18960 `Location loc' argument to the constructor.
18962 * cs-parser.jay: Pass location to ParameterReference.
18964 2002-07-28 Miguel de Icaza <miguel@ximian.com>
18966 * statement.cs (Try): Initialize the location.
18968 * cs-parser.jay: pass location to Try.
18970 * expression.cs (Unary.Reduce): Change the prototype to return
18971 whether a constant fold could be performed or not. The result is
18972 returned in an out parameters. In the case of Indirection and
18973 AddressOf, we want to perform the full tests.
18975 2002-07-26 Miguel de Icaza <miguel@ximian.com>
18977 * statement.cs (Statement.Emit): Flag dead code.
18979 2002-07-27 Andrew Birkett <andy@nobugs.org>
18981 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
18983 2002-07-27 Martin Baulig <martin@gnome.org>
18985 * class.cs (MethodData.Define): Put back call to
18986 TypeManager.AddMethod(), accidentally commented this out.
18988 * report.cs (Debug): New public method to print debugging information,
18989 this is `[Conditional ("DEBUG")]'.
18991 2002-07-26 Martin Baulig <martin@gnome.org>
18993 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
18994 (switch_statement): Push the current_block to the switch_stack and
18995 pop it again when we're done with the switch.
18996 (switch_section): The new block is a child of the current_block.
18997 Fixes bug #24007, added test-152.cs.
18999 2002-07-27 Martin Baulig <martin@gnome.org>
19001 * expression.cs (Invocation.EmitArguments): When calling a varargs
19002 function with only its fixed arguments, we need to pass an empty
19005 2002-07-27 Martin Baulig <martin@gnome.org>
19007 Mono 0.13 has been released.
19009 2002-07-25 Miguel de Icaza <miguel@ximian.com>
19011 * driver.cs: Rename --resource to --linkres, because that is what
19012 we do currently, we dont support --resource yet.
19014 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
19016 2002-07-25 Martin Baulig <martin@gnome.org>
19018 * class.cs (MethodData): New public class. This is a `method builder'
19019 class for a method or one accessor of a Property/Indexer/Event.
19020 (MethodData.GetMethodFlags): Moved here from MemberBase.
19021 (MethodData.ApplyAttributes): Likewise.
19022 (MethodData.ApplyObsoleteAttribute): Likewise.
19023 (MethodData.ApplyConditionalAttribute): Likewise.
19024 (MethodData.ApplyDllImportAttribute): Likewise.
19025 (MethodData.CheckAbstractAndExternal): Likewise.
19026 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
19027 (MethodData.Emit): Formerly known as Method.Emit().
19028 (MemberBase): Moved everything which was specific to a single
19029 accessor/method to MethodData.
19030 (Method): Create a new MethodData and call Define() and Emit() on it.
19031 (Property, Indexer, Event): Create a new MethodData objects for each
19032 accessor and call Define() and Emit() on them.
19034 2002-07-25 Martin Baulig <martin@gnome.org>
19036 Made MethodCore derive from MemberBase to reuse the code from there.
19037 MemberBase now also checks for attributes.
19039 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
19040 (MemberBase.GetMethodFlags): Moved here from class Method and marked
19042 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
19043 `CallingConventions cc' and `Attributes opt_attrs' arguments.
19044 (MemberBase.ApplyAttributes): New virtual method; applies the
19045 attributes to a method or accessor.
19046 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
19047 (MemberBase.ApplyConditionalAttribute): Likewise.
19048 (MemberBase.ApplyDllImportAttribute): Likewise.
19049 (MemberBase.CheckAbstractAndExternal): Likewise.
19050 (MethodCore.ParameterTypes): This is now a property instead of a
19051 method, it's initialized from DoDefineParameters().
19052 (MethodCore.ParameterInfo): Removed the set accessor.
19053 (MethodCore.DoDefineParameters): New protected virtual method to
19054 initialize ParameterTypes and ParameterInfo.
19055 (Method.GetReturnType): We can now simply return the MemberType.
19056 (Method.GetMethodFlags): Override the MemberBase version and add
19057 the conditional flags.
19058 (Method.CheckBase): Moved some code from Define() here, call
19059 DoDefineParameters() here.
19060 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
19061 here to avoid some larger code duplication.
19062 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
19063 ensure that abstract and external accessors don't declare a body.
19065 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
19066 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
19067 lookup in the attribute's parent classes, so we need to abort as soon
19068 as we found the first match.
19069 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
19070 the attribute has no arguments.
19072 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
19075 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19077 * cs-parser.jay: reverted previous patch.
19079 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19081 * cs-parser.jay: fixed bug #22119.
19083 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19085 * attribute.cs: fixed compilation. The error was:
19086 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
19087 be assigned to before control leaves the current method."
19088 [FIXME: Filed as bug #28186: MCS must report this error.]
19090 2002-07-25 Martin Baulig <martin@gnome.org>
19092 * attribute.cs (Attribute.Conditional_GetConditionName): New static
19093 method to pull the condition name ouf of a Conditional attribute.
19094 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
19095 the obsolete message and error flag out of an Obsolete attribute.
19097 * class.cs (Method.GetMethodFlags): New public method to get the
19098 TypeManager.MethodFlags for this method.
19099 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
19101 (Method.Define): Get and apply the Obsolete and Conditional attributes;
19102 if we're overriding a virtual function, set the new private variable
19103 `parent_method'; call the new TypeManager.AddMethod().
19105 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19106 the MethodBuilder and the Method in a PtrHashtable.
19107 (TypeManager.builder_to_method): Added for this purpose.
19108 (TypeManager.MethodFlags): Added IsObsoleteError.
19109 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
19110 Obsolete and Conditional arguments in MethodBuilders. If we discover
19111 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
19112 the message from the attribute.
19114 2002-07-24 Martin Baulig <martin@gnome.org>
19116 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
19117 preprocessor directives, ensure that the argument to #define/#undef is
19118 exactly one identifier and that it's actually an identifier.
19120 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
19123 2002-07-24 Martin Baulig <martin@gnome.org>
19125 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
19126 initialize it to TypeManager.object_type in the constructor.
19127 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
19128 of the `hm.get_current' method if we're using the collection pattern.
19129 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
19130 for the explicit conversion to make it work when we're using the collection
19131 pattern and the `Current' property has a different return type than `object'.
19134 2002-07-24 Martin Baulig <martin@gnome.org>
19136 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
19137 does not match, but don't report any errors. This method is called in
19138 order for all methods in a MethodGroupExpr until a matching method is
19139 found, so we don't want to bail out if the first method doesn't match.
19140 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
19141 matches, report the 123. Fixes #28070.
19143 2002-07-24 Martin Baulig <martin@gnome.org>
19145 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
19146 TypeManager.TypeToCoreType() to the top of the method so the
19147 following equality checks will work. Fixes #28107.
19149 2002-07-24 Martin Baulig <martin@gnome.org>
19151 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
19152 operand is of type uint, and the other operand is of type sbyte,
19153 short or int, the operands are converted to type long." -
19154 Actually do what this comment already told us. Fixes bug #28106,
19157 2002-07-24 Martin Baulig <martin@gnome.org>
19159 * class.cs (MethodBase): New abstract class. This is now a base
19160 class for Property, Indexer and Event to avoid some code duplication
19161 in their Define() and DefineMethods() methods.
19162 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
19163 generic methods for Define() and DefineMethods().
19164 (FieldBase): Derive from MemberBase, not MemberCore.
19165 (Property): Derive from MemberBase, not MemberCore.
19166 (Property.DefineMethod): Moved all the code from this method to the
19167 new MethodBase.DefineAccessor(), just call it with appropriate
19169 (Property.Define): Call the new Property.DoDefine(), this does some
19170 sanity checks and we don't need to duplicate the code everywhere.
19171 (Event): Derive from MemberBase, not MemberCore.
19172 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
19173 accessors, this will also make them work with interface events.
19174 (Indexer): Derive from MemberBase, not MemberCore.
19175 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
19176 (Indexer.Define): Use the new MethodBase functions.
19178 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
19179 argument to the constructor.
19180 (Interface.FindMembers): Added support for interface events.
19181 (Interface.PopluateEvent): Implemented.
19183 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
19185 2002-07-22 Miguel de Icaza <miguel@ximian.com>
19187 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
19188 but this is required to check for a method name being the same as
19189 the containing class.
19193 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19195 * interface.cs: initialize variable.
19197 2002-07-23 Martin Baulig <martin@gnome.org>
19199 Implemented the IndexerName attribute in interfaces.
19201 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
19202 name if this is an explicit interface implementation.
19203 (Indexer.InterfaceIndexerName): New public variable. If we're
19204 implementing an interface indexer, this is the IndexerName in that
19205 interface. Otherwise, it's the IndexerName.
19206 (Indexer.DefineMethod): If we're implementing interface indexer,
19207 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
19208 and Pending.ImplementIndexer methods.
19209 (Indexer.Define): Also define the PropertyBuilder if we're
19210 implementing an interface indexer and this is neither an explicit
19211 interface implementation nor do the IndexerName match the one in
19214 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
19215 If a method is defined here, then we always need to create a proxy
19216 for it. This is used when implementing interface indexers.
19217 (Pending.IsInterfaceIndexer): New public method.
19218 (Pending.ImplementIndexer): New public method.
19219 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
19220 This is used when implementing interface indexers to define a proxy
19222 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
19223 define a proxy if necessary.
19225 * interface.cs (Interface.IndexerName): New public variable.
19226 (Interface.PopulateIndexer): Set the IndexerName.
19227 (Interface.DefineIndexers): New private method. Populate all the
19228 indexers and make sure their IndexerNames match.
19230 * typemanager.cs (IndexerPropertyName): Added support for interface
19233 2002-07-22 Martin Baulig <martin@gnome.org>
19235 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
19236 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
19237 ret if HasReturnLabel.
19238 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
19241 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
19242 and set the ec.LoopBeginTryCatchLevel.
19243 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
19244 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
19245 the current ec.TryCatchLevel, the branch goes out of an exception
19246 block. In this case, we need to use Leave and not Br.
19248 2002-07-22 Martin Baulig <martin@gnome.org>
19250 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
19251 block unless the block does not always return or it is contained in
19252 another try { ... } catch { ... } block. Fixes bug #26506.
19253 Added verify-1.cs to the test suite.
19255 2002-07-22 Martin Baulig <martin@gnome.org>
19257 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
19258 then we do not always return. Fixes bug #24985.
19260 2002-07-22 Martin Baulig <martin@gnome.org>
19262 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19263 lookup on a per-class level; ie. walk up the class hierarchy until we
19264 found at least one applicable method, then choose the best among them.
19265 Fixes bug #24463 and test-29.cs.
19267 2002-07-22 Martin Baulig <martin@gnome.org>
19269 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19270 return types of the methods. The return type is not part of the
19271 signature and we must not check it to make the `new' modifier work.
19272 Fixes bug #27999, also added test-147.cs.
19273 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19275 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19276 on the method's return type.
19278 2002-07-21 Martin Baulig <martin@gnome.org>
19280 * assign.cs: Make this work if the rightmost source is a constant and
19281 we need to do an implicit type conversion. Also adding a few more tests
19282 to test-38.cs which should have caught this.
19284 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19285 target in the makefile for this. The makefile.gnu is primarily intended
19286 for end-users who don't want to debug the compiler.
19288 2002-07-21 Martin Baulig <martin@gnome.org>
19290 * assign.cs: Improved the Assign class so it can now handle embedded
19291 assignments (X = Y = Z = something). As a side-effect this'll now also
19292 consume less local variables. test-38.cs now passes with MCS, added
19293 a few new test cases to that test.
19295 2002-07-20 Martin Baulig <martin@gnome.org>
19297 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19298 instructions. Fixes bug #27977, also added test-146.cs.
19300 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19302 * cs-tokenizer.cs: fixed getHex ().
19304 2002-07-19 Martin Baulig <martin@gnome.org>
19306 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19307 not Type.GetType() to lookup the array type. This is needed when
19308 we're constructing an array of a user-defined type.
19309 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19310 single-dimensional arrays, but also for single-dimensial arrays of
19313 2002-07-19 Martin Baulig <martin@gnome.org>
19315 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19316 this function is called, it's not allowed to share LocalBuilders
19317 among ILGenerators.
19319 2002-07-19 Martin Baulig <martin@gnome.org>
19321 * expression.cs (Argument.Resolve): Report an error 118 when trying
19322 to pass a type as argument.
19324 2002-07-18 Martin Baulig <martin@gnome.org>
19326 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19327 Conv_R_Un for the signed `long' type.
19329 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19331 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19332 `expr' for the temporary result, as that will fail if we do
19333 multiple resolves on the same expression.
19335 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19337 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19338 ec.TypeContainer for looking up aliases.
19340 * class.cs (TypeContainer): Remove LookupAlias from here.
19342 * decl.cs (DeclSpace); Move here.
19344 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19346 * class.cs (FindMembers): Only call filter if the constructor
19347 bulider is not null.
19349 Also handle delegates in `NestedTypes' now. Now we will perform
19350 type lookups using the standard resolution process. This also
19353 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19354 This uses Expressions (the limited kind that can be parsed by the
19355 tree) instead of strings.
19357 * expression.cs (ComposedCast.ToString): Implement, used to flag
19358 errors since now we have to render expressions.
19360 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19363 * ecore.cs (SimpleName.ToString): ditto.
19365 * cs-parser.jay: Instead of using strings to assemble types, use
19366 Expressions to assemble the type (using SimpleName, ComposedCast,
19367 MemberAccess). This should fix the type lookups in declarations,
19368 because we were using a different code path for this.
19370 * statement.cs (Block.Resolve): Continue processing statements
19371 even when there is an error.
19373 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19375 * class.cs (Event.Define): Also remove the `remove' method from
19376 the list of pending items.
19378 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19379 generate more compact code.
19381 2002-07-17 Martin Baulig <martin@gnome.org>
19383 * const.cs (Const.LookupConstantValue): Add support for constant
19384 `unchecked' and `checked' expressions.
19385 Also adding test case test-140.cs for this.
19387 2002-07-17 Martin Baulig <martin@gnome.org>
19389 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19390 check whether mi.ReturnType implements the IEnumerator interface; the
19391 `==' and the IsAssignableFrom() will fail in this situation.
19393 2002-07-16 Ravi Pratap <ravi@ximian.com>
19395 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19398 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19400 * expression.cs: fixed bug #27811.
19402 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19404 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19405 Molaro: when we are a ref, the value already contains a pointer
19406 value, do not take the address of it.
19408 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19409 * removed mb-parser.jay and mb-tokenizer.cs
19411 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19413 * expression.cs: check against the building corlib void type.
19415 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19417 * ecore.cs: fix for valuetype static readonly fields: when
19418 initializing them, we need their address, not the address of a copy.
19420 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19422 * typemanager.cs: register also enum_type in corlib.
19424 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19426 * class.cs: allow calling this (but not base) initializers in structs.
19428 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19430 * ecore.cs: make sure we compare against the building base types
19433 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19435 * typemanager.cs: fix TypeToCoreType() to handle void and object
19436 (corlib gets no more typerefs after this change).
19438 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19440 * expression.cs (ArrayCreation.EmitArrayArguments): use
19441 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19443 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19444 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19445 array indexes, the runtime actually forbids them.
19447 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19448 for array arguments here.
19450 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19451 instead of the default for ValueTypes.
19453 (New.DoEmit): Use IsValueType instead of
19454 IsSubclassOf (value_type)
19455 (New.DoResolve): ditto.
19456 (Invocation.EmitCall): ditto.
19458 * assign.cs (Assign): ditto.
19460 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19461 Statements *are* currently doing part of their resolution during
19464 Expressions do always resolve during resolve, but statements are
19465 only required to propagate resolution to their children.
19467 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19469 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19471 (LoadAssembly): Do not add the dll if it is already specified
19473 (MainDriver): Add the System directory to the link path at the end,
19474 after all the other -L arguments.
19476 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19477 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19478 ldelem.u1) and using the opposite for sbytes.
19480 This fixes Digger, and we can finally run it.
19482 * driver.cs (UnixParseOption): Move the option parsing here.
19483 (CSCParseOption): Implement CSC-like parsing of options.
19485 We now support both modes of operation, the old Unix way, and the
19486 new CSC-like way. This should help those who wanted to make cross
19487 platform makefiles.
19489 The only thing broken is that /r:, /reference: and /lib: are not
19490 implemented, because I want to make those have the same semantics
19491 as the CSC compiler has, and kill once and for all the confussion
19492 around this. Will be doing this tomorrow.
19494 * statement.cs (Unsafe.Resolve): The state is checked during
19495 resolve, not emit, so we have to set the flags for IsUnsfe here.
19497 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19499 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19500 not catch the Error_ObjectRefRequired in SimpleName (as it is
19501 possible to have a class/instance variable name that later gets
19502 deambiguated), we have to check this here.
19504 2002-07-10 Ravi Pratap <ravi@ximian.com>
19506 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19507 make static and put into Expression.
19509 (Event.Define): Register the private field of the event with the
19510 TypeManager so that GetFieldFromEvent can get at it.
19512 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19513 keep track of the private field associated with an event which
19516 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19519 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19521 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19523 * expression.cs (Binary.EmitBranchable): this routine emits the
19524 Binary expression in a branchable context. This basically means:
19525 we need to branch somewhere, not just get the value on the stack.
19527 This works together with Statement.EmitBoolExpression.
19529 * statement.cs (Statement.EmitBoolExpression): Use
19532 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19534 * statement.cs (For): Reduce the number of jumps in loops.
19536 (For): Implement loop inversion for the For statement.
19538 (Break): We can be breaking out of a Try/Catch controlled section
19539 (foreach might have an implicit try/catch clause), so we need to
19540 use Leave instead of Br.
19542 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19543 now). If the instace expression supports IMemoryLocation, we use
19544 the AddressOf method from the IMemoryLocation to extract the
19545 address instead of emitting the instance.
19547 This showed up with `This', as we were emitting the instance
19548 always (Emit) instead of the Address of This. Particularly
19549 interesting when This is a value type, as we dont want the Emit
19550 effect (which was to load the object).
19552 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19554 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19556 * statement.cs (Checked): Set the CheckedState during the resolve
19557 process too, as the ConvCast operations track the checked state on
19558 the resolve process, and not emit.
19560 * cs-parser.jay (namespace_member_declaration): Flag that we have
19561 found a declaration when we do. This is used to flag error 1529
19563 * driver.cs: Report ok when we display the help only.
19565 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19567 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19569 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19571 * cs-tokenizer.cs (define): We also have to track locally the
19572 defines. AllDefines is just used for the Conditional Attribute,
19573 but we also need the local defines for the current source code.
19575 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19577 * statement.cs (While, For, Do): These loops can exit through a
19578 Break statement, use this information to tell whether the
19579 statement is the last piece of code.
19581 (Break): Flag that we break.
19583 * codegen.cs (EmitContexts): New `Breaks' state variable.
19585 2002-07-03 Martin Baulig <martin@gnome.org>
19587 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19588 modifiers in method declarations in structs. Otherwise, you won't
19589 be able to override things like Object.Equals().
19591 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19593 * class.cs (Method, Property, Indexer): Do not allow the public
19594 modifier to be used in explicit interface implementations.
19596 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19597 override modifiers in method declarations in structs
19599 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19601 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19602 integer or real overflow, report an error
19604 2002-07-02 Martin Baulig <martin@gnome.org>
19606 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19607 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19608 to tell the runtime about our newly created System.Object and
19609 System.ValueType types.
19611 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19613 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19614 struct instead of Ldarg/Starg.
19616 2002-07-02 Martin Baulig <martin@gnome.org>
19618 * expression.cs (Indirection.Indirection): Call
19619 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19621 2002-07-02 Martin Baulig <martin@gnome.org>
19623 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19624 ValueType, call TypeManager.TypeToCoreType() on it.
19625 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19626 the OpCodes.Newarr argument.
19628 2002-07-02 Martin Baulig <martin@gnome.org>
19630 * expression.cs (Invocation.EmitCall): When compiling corlib,
19631 replace all calls to the system's System.Array type to calls to
19632 the newly created one.
19634 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19635 System.Array methods.
19636 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19637 from the system's System.Array type which must be replaced.
19639 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19641 * typemanager.cs: load unverifiable_code_ctor so we can build
19642 corlib using the correct type. Avoid using GetTypeCode() with
19644 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19645 TypeManager.object_type to allow building corlib.
19647 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19649 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19651 2002-07-01 Martin Baulig <martin@gnome.org>
19653 * class.cs: Make the last change actually work, we need to check
19654 whether `ifaces != null' to avoid a crash.
19656 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19658 * class.cs: when we build structs without fields that implement
19659 interfaces, we need to add the interfaces separately, since there is
19660 no API to both set the size and add the interfaces at type creation
19663 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19665 * expression.cs: the dimension arguments to the array constructors
19666 need to be converted if they are a long.
19668 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19670 * class.cs: don't emit ldarg.0 if there is no parent constructor
19671 (fixes showstopper for corlib).
19673 2002-06-29 Martin Baulig <martin@gnome.org>
19675 MCS now compiles corlib on GNU/Linux :-)
19677 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19678 ie. check for MethodImplOptions.InternalCall.
19680 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19681 and TypeManager.attribute_type are null, so we must explicitly check
19682 whether parent is not null to find out whether it's an attribute type.
19683 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19684 and SetBuilder, not only if the property is neither abstract nor external.
19685 This is necessary to set the MethodImplOptions on the accessor methods.
19686 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19687 SetBuilder, see Property.Emit().
19689 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19690 populate "System.Object", "System.ValueType" and "System.Attribute" since
19691 they've already been populated from BootCorlib_PopulateCoreTypes().
19693 2002-06-29 Martin Baulig <martin@gnome.org>
19695 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19696 is the NullLiteral, we also need to make sure that target_type is not
19699 2002-06-29 Martin Baulig <martin@gnome.org>
19701 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19702 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19703 before calling BootstrapCorlib_ResolveDelegate ().
19705 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19707 * statement.cs: fixed build-breaker. All tests passed ok.
19709 2002-06-27 Martin Baulig <martin@gnome.org>
19711 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19712 for System.Decimal when compiling corlib.
19714 2002-06-27 Martin Baulig <martin@gnome.org>
19716 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19717 switch blocks which contain nothing but a default clause.
19719 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19721 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19723 2002-06-27 Martin Baulig <martin@gnome.org>
19725 * ecore.cs (PropertyExpr.PropertyExpr): Call
19726 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19728 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19729 is already a TypeBuilder.
19731 2002-06-27 Martin Baulig <martin@gnome.org>
19733 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19734 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19735 the "from an array-type to System.Array" case. This makes it work
19736 when compiling corlib.
19738 2002-06-27 Martin Baulig <martin@gnome.org>
19740 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19741 non-static PropertyExpr, set its InstanceExpression. This makes
19742 the `ICollection.Count' property work in System/Array.cs.
19744 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19746 * driver.cs: Made error handling more consistent. Errors now
19747 tracked by Report class, so many methods which used to return int
19748 now return void. Main() now prints success/failure and
19749 errors/warnings message.
19751 Renamed '--probe' compiler argument to '--expect-error'. Removed
19752 the magic number return values (123 and 124). Now, if the
19753 expected error occurs, the compiler exits with success (exit value
19754 0). If the compilation completes without seeing that particular
19755 error, the compiler exits with failure (exit value 1). The
19756 makefile in mcs/errors has been changed to handle the new behaviour.
19758 * report.cs: Made 'expected error' number a property and renamed
19759 it from 'Probe' to 'ExpectedError'.
19761 * genericparser.cs: Removed error handling support, since it is
19762 now all done by Report class.
19764 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19765 class, so parse() no longer returns an int.
19767 * namespace.cs: Use Report.Error instead of GenericParser.error
19769 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19771 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19772 TypeContainer.AddOperator): At the front of the list put the
19773 explicit implementations, so they get resolved/defined first.
19775 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19777 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19778 interface type is implemented by this TypeContainer. Used during
19779 explicit interface implementation.
19781 (Property.Define, Indexer.Define, Method.Define): Validate that
19782 the given interface in the explicit implementation is one of the
19783 base classes for the containing type.
19785 Also if we are explicitly implementing an interface, but there is
19786 no match in the pending implementation table, report an error.
19788 (Property.Define): Only define the property if we are
19789 not explicitly implementing a property from an interface. Use the
19790 correct name also for those properties (the same CSC uses,
19791 although that is really not needed).
19793 (Property.Emit): Do not emit attributes for explicitly implemented
19794 properties, as there is no TypeBuilder.
19796 (Indexer.Emit): ditto.
19798 Hiding then means that we do not really *implement* a pending
19799 implementation, which makes code fail.
19801 2002-06-22 Martin Baulig <martin@gnome.org>
19803 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19804 the return value of Object.GetType(). [FIXME: we need to do this whenever
19805 we get a type back from the reflection library].
19807 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19809 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19811 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19813 * attribute.cs: Return null if we can not look up the type.
19815 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19816 the interface types found.
19818 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19819 interface types found.
19821 * typemanager.cs (GetInterfaces): Make this routine returns alll
19822 the interfaces and work around the lame differences between
19823 System.Type and System.Reflection.Emit.TypeBuilder in the results
19824 result for GetInterfaces.
19826 (ExpandInterfaces): Given an array of interface types, expand and
19827 eliminate repeated ocurrences of an interface. This expands in
19828 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19831 2002-06-21 Martin Baulig <martin@gnome.org>
19833 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19836 2002-06-21 Martin Baulig <martin@gnome.org>
19838 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19839 and called with one of the core types, return the corresponding typebuilder for
19842 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19845 2002-06-21 Martin Baulig <martin@gnome.org>
19847 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19848 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19849 (Expression.ConvertReferenceExplicit): Likewise.
19851 * expression.cs (ElementAccess.DoResolve): Likewise.
19852 (ElementAccess.DoResolveLValue): Likewise.
19854 2002-06-10 Martin Baulig <martin@gnome.org>
19856 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19857 add the "value" parameter to the parameter list.
19859 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19862 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19864 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19865 the argument to an int, uint, long or ulong, per the spec. Also
19866 catch negative constants in array creation.
19868 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
19870 * class.cs: do not allow the same interface to appear twice in
19871 the definition list.
19873 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
19875 * ecore.cs: don't use ldlen with System.Array.
19877 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
19879 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
19881 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
19883 * modifiers.cs: produce correct field attributes for protected
19884 internal. Easy fix so miguel can work on ther harder stuff:-)
19886 2002-06-18 Miguel de Icaza <miguel@ximian.com>
19888 * pending.cs: New file. Move the code from class.cs here.
19889 Support clearning the pending flag for all methods (when not doing
19890 explicit interface implementation).
19892 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
19894 * rootcontext.cs: added a couple more types needed to bootstrap.
19896 2002-06-17 Miguel de Icaza <miguel@ximian.com>
19898 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
19899 constructor in the type, instead of any constructor in the type
19900 hierarchy. Thanks to Paolo for finding this bug (it showed up as
19901 a bug in the Mono runtime when applying the params attribute).
19903 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19904 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
19906 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
19908 * expression.cs (Unary.ResolveOperator): Use TypeManager
19909 to resolve the type.
19911 2002-06-13 Ravi Pratap <ravi@ximian.com>
19913 * cs-parser.jay (enum_member_declaration): Pass in the attributes
19916 * enum.cs (AddEnumMember): Add support to store the attributes associated
19917 with each member too.
19919 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
19920 field builders too - this takes care of the enum member case.
19922 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
19924 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
19925 address-of operator on both value types and pointers.
19927 2002-06-10 Martin Baulig <martin@gnome.org>
19929 * interface.cs (Interface.PopulateIndexer): Add the indexer's
19930 PropertyBuilder to the `property_builders' list.
19932 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
19933 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
19934 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
19935 find any indexers which are inherited from an interface.
19937 2002-06-09 Martin Baulig <martin@gnome.org>
19939 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
19940 the same type as the constant if necessary. There's also a test-130.cs
19943 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
19945 * typemanager.cs (TypeManager.ChangeType): Previously known as
19946 Enum.ChangeEnumType().
19948 2002-06-09 Martin Baulig <martin@gnome.org>
19950 * expression.cs (Cast.TryReduce): Added support for consts.
19952 2002-06-08 Ravi Pratap <ravi@ximian.com>
19954 * class.cs (Accessor): Hold attributes information so we can pass
19957 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
19958 Modify to pass in attributes attached to the methods.
19960 (add_accessor_declaration, remove_accessor_declaration): Ditto.
19962 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
19963 to handle the Accessor kind :-)
19965 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
19967 2002-06-08 Martin Baulig <martin@gnome.org>
19969 * expression.cs (Unary.TryReduceNegative): Added support for
19972 2002-06-08 Martin Baulig <martin@gnome.org>
19974 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
19975 name can't be found in the `defined_names' - the caller will do a
19976 MemberLookup in this case and thus find methods in System.Enum
19977 such as Enum.IsDefined().
19979 2002-06-08 Martin Baulig <martin@gnome.org>
19981 * enum.cs (Enum.ChangeEnumType): This is a custom version of
19982 Convert.ChangeType() which works with TypeBuilder created types.
19983 (Enum.LookupEnumValue, Enum.Define): Use it here.
19985 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
19986 `TypeBuilder.BaseType != null' check.
19987 (TypeContainer.FindMembers): Only lookup parent members if we
19988 actually have a parent.
19989 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
19990 (ConstructorInitializer.Resolve): Likewise.
19992 * interface.cs (Interface.FindMembers): Added
19993 `TypeBuilder.BaseType != null' check.
19995 * rootcontext.cs (RootContext.ResolveCore): Added
19996 "System.Runtime.CompilerServices.IndexerNameAttribute" to
19997 classes_second_stage.
19999 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20000 debug_type and trace_type when compiling with --nostdlib.
20002 2002-06-07 Martin Baulig <martin@gnome.org>
20004 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
20005 (AddField): Set it to true when adding a non-static field.
20006 (DefineType): Use `have_nonstatic_fields' to find out whether we
20007 have non-static fields, not `Fields != null'.
20009 2002-06-02 Miguel de Icaza <miguel@ximian.com>
20011 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
20012 dereferencing a null on the static-field code path)
20014 2002-05-30 Martin Baulig <martin@gnome.org>
20016 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
20017 to take command line arguments. Use reflection to call the new
20018 custom `Initialize' function on the symbol writer and pass it the
20019 command line arguments.
20021 * driver.cs (--debug-args): New command line argument to pass command
20022 line arguments to the symbol writer.
20024 2002-05-28 Miguel de Icaza <miguel@ximian.com>
20026 * assign.cs (DoResolve): Forgot to do the implicit conversion to
20027 the target type for indexers and properties. Thanks to Joe for
20030 2002-05-27 Miguel de Icaza <miguel@ximian.com>
20032 * typemanager.cs (MethodFlags): returns the method flags
20033 (Obsolete/ShouldIgnore) that control warning emission and whether
20034 the invocation should be made, or ignored.
20036 * expression.cs (Invocation.Emit): Remove previous hack, we should
20037 not do this on matching a base type, we should do this based on an attribute
20039 Only emit calls to System.Diagnostics.Debug and
20040 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
20041 on the command line.
20043 * rootcontext.cs: Global settings for tracing and debugging.
20045 * cs-tokenizer.cs (define): New utility function to track
20046 defines. Set the global settings for TRACE and DEBUG if found.
20048 2002-05-25 Ravi Pratap <ravi@ximian.com>
20050 * interface.cs (Populate*): Pass in the TypeContainer as well as
20051 the DeclSpace as parameters so that we can create EmitContexts and
20052 then use that to apply attributes etc.
20054 (PopulateMethod, PopulateEvent, PopulateProperty)
20055 (PopulateIndexer): Apply attributes everywhere.
20057 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
20060 (ApplyAttributes): Update accordingly.
20062 We now apply interface attributes for all members too.
20064 2002-05-26 Miguel de Icaza <miguel@ximian.com>
20066 * class.cs (Indexer.Define); Correctly check if we are explicit
20067 implementation (instead of checking the Name for a ".", we
20068 directly look up if the InterfaceType was specified).
20070 Delay the creation of the PropertyBuilder.
20072 Only create the PropertyBuilder if we are not an explicit
20073 interface implementation. This means that explicit interface
20074 implementation members do not participate in regular function
20075 lookups, and hence fixes another major ambiguity problem in
20076 overload resolution (that was the visible effect).
20078 (DefineMethod): Return whether we are doing an interface
20081 * typemanager.cs: Temporary hack until we get attributes in
20082 interfaces (Ravi is working on that) and we get IndexerName
20083 support in interfaces.
20085 * interface.cs: Register the indexers as properties.
20087 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
20088 warning, I have verified that this is a bug in the .NET runtime
20089 (JavaScript suffers of the same problem).
20091 * typemanager.cs (MemberLookup): When looking up members for
20092 interfaces, the parent of an interface is the implicit
20093 System.Object (so we succeed in searches of Object methods in an
20094 interface method invocation. Example: IEnumerable x; x.ToString
20097 2002-05-25 Miguel de Icaza <miguel@ximian.com>
20099 * class.cs (Event): Events should also register if they do
20100 implement the methods that an interface requires.
20102 * typemanager.cs (MemberLookup); use the new GetInterfaces
20105 (GetInterfaces): The code used to lookup interfaces for a type is
20106 used in more than one place, factor it here.
20108 * driver.cs: Track the errors at the bottom of the file, we kept
20111 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
20112 instance if the method we are calling is static!
20114 2002-05-24 Miguel de Icaza <miguel@ximian.com>
20116 * attribute.cs (ApplyAttributes): Make this function filter out
20117 the IndexerName attribute (as that attribute in reality is never
20118 applied) and return the string constant for the IndexerName
20121 * class.cs (TypeContainer.Emit): Validate that all the indexers
20122 have the same IndexerName attribute, and if so, set the
20123 DefaultName attribute on the class.
20125 * typemanager.cs: The return value might contain other stuff (not
20126 only methods). For instance, consider a method with an "Item"
20127 property and an Item method.
20129 * class.cs: If there is a problem with the parameter types,
20132 2002-05-24 Ravi Pratap <ravi@ximian.com>
20134 * ecore.cs (ImplicitConversionExists): Wrapper function which also
20135 looks at user defined conversion after making a call to
20136 StandardConversionExists - we need this for overload resolution.
20138 * expression.cs : Update accordingly the various method calls.
20140 This fixes 2 bugs filed against implicit user defined conversions
20142 2002-05-22 Miguel de Icaza <miguel@ximian.com>
20144 * statement.cs: Track the result of the assignment.
20146 2002-05-21 Miguel de Icaza <miguel@ximian.com>
20148 * expression.cs (MemberAccess): Improved error reporting for
20149 inaccessible members.
20151 2002-05-22 Martin Baulig <martin@gnome.org>
20153 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
20154 itself with debugging support.
20156 2002-05-22 Martin Baulig <martin@gnome.org>
20158 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
20159 Removed, this isn't needed anymore.
20161 2002-05-20 Martin Baulig <martin@gnome.org>
20163 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
20164 be underlying type for an enum.
20166 2002-05-20 Miguel de Icaza <miguel@ximian.com>
20168 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
20169 that splits out the loading of just the core types.
20171 * rootcontext.cs (ResolveCore): Split the struct resolution in
20172 two, so we can load the enumeration underlying types before any
20175 * expression.cs (Is): Bandaid until we fix properly Switch (see
20176 bug #24985 for details).
20178 * typemanager.cs (ImplementsInterface): The hashtable will contain
20179 a null if there are no interfaces implemented.
20181 2002-05-18 Miguel de Icaza <miguel@ximian.com>
20183 * cs-parser.jay (indexer_declarator): It is fine to have array
20186 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20188 * typemanager.cs: (RegisterBuilder): New function used to register
20189 TypeBuilders that implement interfaces. Since
20190 TypeBuilder.GetInterfaces (as usual) does not work with lame
20192 (AddUserType): register interfaces.
20194 (ImplementsInterface): Use the builder_to_ifaces hash if we are
20195 dealing with TypeBuilder. Also, arrays are showing up as
20196 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
20197 methods can not be invoked on them!
20199 * ecore.cs (ExplicitReferenceConversionExists): Made public.
20200 (ImplicitReferenceConversionExists): Split out from
20201 StandardConversionExists.
20203 * expression.cs (As): We were only implementing one of the three
20204 cases for the as operator. We now implement them all.
20205 (Is): Implement the various other cases for Is as well.
20207 * typemanager.cs (CACHE): New define used to control if we want or
20208 not the FindMembers cache. Seems to have a negative impact on
20209 performance currently
20211 (MemberLookup): Nested types have full acess to
20212 enclosing type members
20214 Remove code that coped with instance/static returns for events, we
20215 now catch this in RealFindMembers.
20217 (RealFindMembers): only perform static lookup if the instance
20218 lookup did not return a type or an event.
20220 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20222 * assign.cs (CompoundAssign): We pass more semantic information
20223 now to Compound Assignments than we did before: now we have all
20224 the information at hand, and now we resolve the target *before* we
20225 do the expression expansion, which allows the "CacheValue" method
20226 to have the effect we intended (before, a [x] += 1 would generate
20227 two differen ArrayAccess expressions from the ElementAccess,
20228 during the resolution process).
20230 (CompoundAssign.DoResolve): Resolve target and original_source here.
20232 2002-05-16 Miguel de Icaza <miguel@ximian.com>
20234 * expression.cs (ArrayAccess): dropped debugging information.
20236 * typemanager.cs: Small bug fix: I was always returning i_members,
20237 instead of one of i_members or s_members (depending on which had
20240 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
20241 method is invoked before any code generation takes place, and it
20242 is a mechanism to inform that the expression will be invoked more
20243 than once, and that the method should use temporary values to
20244 avoid having side effects
20246 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
20248 * ecore.cs (Expression.CacheTemporaries): Provide empty default
20251 * expression.cs (Indirection, ArrayAccess): Add support for
20252 CacheTemporaries in these two bad boys.
20254 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
20255 ldobj or ldind_ref.
20256 (StoreFromPtr): Handle stobj as well.
20258 * expression.cs (UnaryMutator): Share more code.
20260 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20261 down: I was not tracking the Filter function as well, which
20262 was affecting the results of the cache.
20264 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20266 * attribute.cs: Remove the hack to handle the CharSet property on
20269 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20271 * attribute.cs (DoResolve): More uglyness, we now only try to
20272 resolve the attribute partially, to extract the CharSet
20273 information (only if we are a StructLayout attribute). Otherwise
20275 (GetExtraTypeInfo): Add some code to conditionally kill in the
20276 future this. I am more and more convinced that the .NET
20277 framework has special code to handle the attribute setting on
20280 * expression.cs (IsParamsMethodApplicable): Revert my previous
20281 foreach change here, it was wrong.
20283 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20285 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20286 (pp_expr): do not abort on unknown input, just return.
20287 (eval): abort if there are pending chars.
20289 * attribute.cs (Attribute.Resolve): Positional parameters are
20290 optional. Deal with that case.
20292 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20293 the Ansi/Unicode/Auto information for the type.
20295 (TypeContainer.DefineType): instantiate the EmitContext here, as
20296 we will be using it during the type definition (to resolve
20297 attributes) and during the emit phase.
20299 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20300 to pull type information out of the attributes
20302 (Attribute.Resolve): track the constructor builder, and allow for
20303 multiple invocations (structs and classes will use this).
20305 * ecore.cs (MemberLookupFinal): new version with all the
20306 parameters customizable.
20308 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20309 constructors. Return if the result value is null (as the error
20310 would have been flagged already by MemberLookupFinal)
20312 Do not allow instances of abstract classes or interfaces to be
20315 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20316 We have to compare the assembly property here when dealing with
20317 FamANDAssem and Assembly access modifiers, because we might be
20318 creating an assembly from *modules* (that means that we are not
20319 getting TypeBuilders for types defined in other modules that are
20320 part of this assembly).
20322 (Method.Emit): If the method is marked abstract and has a body,
20325 (TypeContainer.DefineMembers): If both the defined member and the
20326 parent name match are methods, then do not emit any warnings: let
20327 the Method.Define routine take care of flagging warnings. But if
20328 there is a mismatch (method overrides something else, or method is
20329 overriwritten by something, then emit warning).
20331 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20332 set to null, this means `do not check for the return type on the
20335 (Method.Define): set the return type for the method signature to
20336 null, so that we get methods with the same name and parameters and
20337 different return types. This is used to flag warning 114 (you are
20338 hiding a method, and you probably want to use the new/override
20341 * typemanager.cs (MemberLookup): Implemented proper access
20342 control, closing a long standing set of bug reports. The problem
20343 was that the Framework only has two bits: Public and NonPublic,
20344 and NonPublic includes private and protected methods, but we need
20345 to enforce the FamANDAssem, FamOrAssem and Family.
20347 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20349 * statement.cs (GotoCase): Return true: Ammounts to giving up
20350 knowledge on whether we return or not, and letting the other case
20351 be responsible for it.
20353 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20355 * driver.cs: Do not load directories for each file processed, only
20356 do it if there is a pattern.
20358 * ecore.cs: Report readonly assigns here as well, as we might have
20359 been resolved only by MemberAccess.
20361 (SimpleName.SimpleNameResolve): Also be useful for LValue
20362 resolution. We need this to propagate assign to local readonly variables
20364 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20365 do not want to reuse potential criteria memory.
20367 * class.cs (MyEventBuilder): Set reflected_type;
20369 * ecore.cs (Constantify): Added support for constifying bools.
20371 (RootContext.LookupType): Added a cache for values looked up in
20372 the declaration space.
20374 * typemanager.cs (FindMembers): Now is a front-end to
20375 RealFindMembers, and provides a two-level hashtable-based cache to
20378 15% performance improvement: from 22.5 to 19.2 seconds.
20380 * expression.cs (IsParamsMethodApplicable): use foreach.
20381 (Invocation.DoResolve): ditto.
20382 (New.DoResolve): ditto.
20383 (ArrayCreation.DoResolve): ditto.
20385 * ecore.cs (FindMostEncompassingType): use foreach.
20387 * delegate.cs (NewDelegate.DoResolve): Use foreach
20389 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20390 (RemoveMethods): use foreach.
20392 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20393 nested foreach statements instead of for, and also break out of
20394 the inner loop once a match is found.
20396 (Invocation.OverloadResolve): Use foreach, simplify the code.
20398 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20400 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20401 we actually unwrap the expression to allow for extra information
20404 * expression.cs: Use Shr_Un on unsigned operations.
20406 2002-05-08 Ravi Pratap <ravi@ximian.com>
20408 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20409 applicable operators was not being considered correctly. This closes
20410 the bug Miguel reported.
20412 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20414 * attribute.cs: check that the type derives from System.Attribute
20415 and report the correct error in that case (moved the duplicate code to
20416 its own method, too).
20418 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20420 * attribute.cs: lookup attribute type name as the spec says: first the
20421 bare attribute name and then name + "Attribute" (nant compiles with
20422 mcs after this fix).
20424 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20426 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20427 Because of the way we parse things, we should try to see if a
20428 UIntConstant can fit in an integer.
20430 2002-05-07 Ravi Pratap <ravi@ximian.com>
20432 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20433 when we are in an explicit context.
20435 (ConvertReferenceExplicit): When converting from Iface type S to Class
20436 T make sure the rules are implemented as an OR.
20438 * parameter.cs (ParameterType): Make it a property for now although the
20439 purpose really isn't anything immediate.
20441 * expression.cs (Is*Applicable): Do better checking on the parameter type
20442 of a ref/out parameter. The ones from the system assemblies are already
20443 marked with the correct type so we don't need to do any correction.
20445 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20446 the object type is standard too so include that.
20448 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20450 * ecore.cs (StandardConversionExists): Augment with missing code:
20451 deal with IntConstant, LongConstants and Enumerations.
20453 * assign.cs: Report the error, instead of failing silently
20455 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20456 typecontainer that they are declared, because the
20457 typecontainer/namespace will have the list of using clauses that
20458 need to be applied.
20460 Assembly Attributes were escaping the normal registration
20463 (EmitCode): Apply attributes within an EmitContext that represents
20464 the container they were declared on.
20466 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20468 2002-05-06 Ravi Pratap <ravi@ximian.com>
20470 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20471 Revamp completely - make much cleaner as we now operate only
20474 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20475 to implement the logic detailed in the spec more correctly.
20477 (UserDefinedConversion): Update accordingly.
20479 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20481 * statement.cs: Return flow analysis information up.
20483 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20486 (token): Do not consume an extra character before calling
20489 2002-05-06 Piers Haken <piersh@friskit.com>
20491 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20493 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20495 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20496 EmitContext during the instance constructor initializer
20497 resolution, to stop access to instance variables.
20499 This is mandated by the spec, last paragraph of the `constructor
20500 initializers' section.
20502 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20504 * cs-parser.jay, class.cs (Accessor): new class used to represent
20505 an accessor (get or set). In the past we used `null' to represent
20506 a missing accessor. But this is ambiguous because there was no
20507 way to tell in abstract indexers/properties if one of them was
20510 Now there is a way of addressing that.
20512 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20513 instead of FindMembers.
20515 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20516 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20518 * attribute.cs: Treat indexers and properties as the same in terms
20519 of applying attributes
20521 * ecore.cs (FindMostEncompassedType): Use statically initialized
20522 EmptyExpressions()s like we do elsewhere to avoid creating useless
20523 objects (and we take this out of the tight loop).
20525 (GetConversionOperators): Move the code to extract the actual
20526 operators to a separate routine to clean things up.
20528 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20530 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20531 events are always registered FieldBuilders.
20533 * class.cs (FieldBase): New class shared by Fields
20535 * delegate.cs: If we are a toplevel delegate, use our full name.
20536 If we are a nested delegate, then only use our tail name.
20538 2002-05-02 Ravi Pratap <ravi@ximian.com>
20540 * expression.cs (IsApplicable): Ensure that we add the "&" to
20541 ref/out types before comparing it with the type of the argument.
20543 (IsParamsMethodApplicable): Ditto.
20545 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20548 * delegate.cs : Handle the case when we have more than one applicable
20549 method. Flag an error only when we finish checking all.
20551 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20553 * expression.cs: Add support for boolean static initializers.
20555 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20557 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20559 * parameter.cs (ComputeParameterTypes,
20560 ComputeAndDefineParameterTypes): Better error handling: now we
20561 clear the `types' cache if we fail during any of the type lookups.
20562 We also return the status code correctly to our caller
20564 * delegate.cs: If we fail to define a delegate, abort the extra
20567 * expression.cs (Binary.ResolveOperator): for
20568 operator==(object,object) and operator !=(object, object) we also
20569 have to verify that there is an implicit conversion from one to
20572 (ArrayAccess.DoResolve): Array Access can operate on
20575 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20577 * assign.cs (CompoundAssign): A new class used as a "flag" that
20578 the assignment actually is happening as part of a compound
20579 assignment operator.
20581 During compound assignment, a few new rules exist to enable things
20588 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20589 to the type of x) if y is implicitly convertible to the type of x,
20590 and the operator is a builtin operator and the return type of the
20591 operator is explicitly convertible to the type of x.
20593 * rootcontext.cs: Reset warning level to 2. 4 catches various
20594 "interesting" features in mcs, we must clean this up at some
20595 point, but currently am trying to kill other bugs ;-)
20597 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20598 in container classes as well.
20600 * expression.cs (Binary.ResolveOperator): Handle string case
20601 before anything else (as operator overloading does emit an error
20602 before doing anything else).
20604 This code could go away when we move to a table driven model, but
20605 i could not come up with a good plan last night.
20607 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20609 * typemanager.cs (CSharpName): reimplementation using regex.
20610 * class.cs: added null check for fields in Emit
20611 * rootcontext.cs: set warninglevel to 4
20613 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20615 * typemanager.cs (CSharpName): reimplemented with Lupus
20618 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20620 * statement.cs (If): correclty implement Resolve, because we were
20621 not catching sem errors in there. The same process is needed
20623 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20626 (Statement.Warning_DeadCodeFound): Factorize code.
20627 (While): Report dead code here too.
20629 (Statement): Added Resolve virtual method to allow
20630 for resolution split from the emit code.
20632 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20634 * statement.cs (EmitBoolExpression): No longer try to resolve the
20636 (MakeBoolean): New utility function that resolve, implicitly
20637 converts to boolean and tags the expression.
20640 (If, Do): Implement dead code elimination.
20641 (While): Implement loop inversion
20643 (Do, While, For, If): Resolve the expression prior to calling our
20646 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20649 - added method Report28 (warning: program has more than one entry point)
20650 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20651 - modified method Method.Define, the part at the end of the method
20653 * rootcontext.cs: added static public Location EntryPointLocation;
20655 * ../errors/cs0028.cs : Add test case for the above warning.
20658 - modified method CSharpName to allow arrays of primitive type to
20659 be printed nicely (e.g. instead of System.Int32[][] it now prints
20661 - added method CSharpSignature: returns the signature of a method
20662 in string format to be used in reporting errors, warnings, etc.
20664 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20667 2002-04-26 Ravi Pratap <ravi@ximian.com>
20669 * delegate.cs (Define): Fix extremely silly bug where I was
20670 setting the type of the 'object' parameter of the BeginInvoke
20671 method to System.IAsyncResult instead of System.Object ;-)
20673 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20675 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20678 (Constructor.Emit): return if we fail to initialize the
20679 constructor. Another door closed!
20681 * expression.cs (New.DoResolve): Improve error message (from -6 to
20682 1501). Use DeclaredOnly lookup to find the exact constructor.
20684 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20685 loop. This is useful.
20687 * cs-parser.jay: Adjust the default parameters so that destructors
20688 have the proper signature.
20690 2002-04-26 Martin Baulig <martin@gnome.org>
20692 * driver.cs (LoadAssembly): If `assembly' contains any characters
20693 which are only valid in path names and not in assembly names
20694 (currently slash, backslash and point), use Assembly.LoadFrom ()
20695 instead of Assembly.Load () on the `assembly' (before iteration
20696 over the link_paths).
20698 2002-04-26 Martin Baulig <martin@gnome.org>
20700 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20702 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20704 * class.cs (Property): use the new typemanager.MemberLookup
20706 (TypeContainer.MemberLookup): Implement using the
20707 TypeManager.MemberLookup now.
20709 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20710 and return MemberInfos, so that these can be used without an
20711 EmitContext (what we had before).
20713 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20715 * expression.cs: Fix the case where the argument to params if the
20716 type of the params. I omitted handling this before. Fixed
20718 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20720 * driver.cs: Call BootCorlib_PopulateCoreType
20722 * class.cs (Property.CheckBase): Check for properties only, not
20725 * interface.cs: Temporary hack: try/catch around the
20726 CustomAttributeBuilder, because I am getting an exception that I
20729 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20730 types whose definitions are required to be there (attributes are
20731 defined before standard types).
20733 Compute definitions as we boot the various types, as they are used
20734 immediately (value_type class will need object_type, but if we do
20735 not initialize object_type, we will pass a null, which will let
20736 the runtime pick the System.Object from the existing corlib, which
20737 is not what we want).
20739 2002-04-22 Patrik Torstensson <totte@labs2.com>
20741 * cs-tokenizer.cs: fixed a number of trim() issues.
20743 2002-04-22 Ravi Pratap <ravi@ximian.com>
20745 * expression.cs (Argument.Type): Ensure that we return the correct
20746 type when we have out or ref parameters [in which case we
20749 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20751 * class.cs (Property, Indexer): Allow extern modifier in there.
20753 * typemanager.cs (InitBaseTypes): Initializes object_type and
20754 value_type, since those will be used early on during the bootstrap
20755 process to compile corlib.
20757 (InitCoreTypes): Move code from here to InitBaseTypes.
20759 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20761 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20762 single-dimension arrays as using the ldlen opcode.
20764 Daniel Lewis discovered this optimization.
20766 * typemanager.cs: Add signature for System.Array::get_Length
20768 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20770 * statement.cs: report the error when the foreach does not apply to an
20771 array nor a collection.
20773 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20775 * expression.cs: Add implicit conversions to the operator ~.
20777 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20779 * typemanager.cs: Locate the decimal constructor.
20781 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20783 * attribute.cs: use the new property of TypeOf.
20784 * expression.cs: added 'get' property around typearg.
20786 These changes fix a build breaker reported by NickD. Is this the
20787 correct way to fix? If not, please, revert my changes and make it
20790 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20792 * attribute.cs: Add support for typeof in attribute invocations.
20793 I am not sure that this is right though.
20795 2002-04-14 Duncan Mak <duncan@ximian.com>
20797 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20798 Binary.Operator.Division case.
20800 2002-04-13 Ravi Pratap <ravi@ximian.com>
20802 * class.cs (DefineType): Ensure that we do a proper check on
20803 attribute types and also register it with the TypeManager.
20805 (TypeContainer.Targets): The default for attribute types is
20806 AttributeTargets.All.
20808 * attribute.cs (ApplyAttributes): Registering the attribute type
20809 is done elsewhere, not when we discover we have a Usage attribute.
20811 2002-04-12 Ravi Pratap <ravi@ximian.com>
20813 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20814 and get rid of is_delegate parameter.
20816 * everywhere : update.
20818 2002-04-12 Ravi Pratap <ravi@ximian.com>
20820 * cs-parser.jay (compilation_unit): Revamp completely to use
20821 some new ideas that I got from Rhys' grammar to solve the problems
20822 with assembly level attributes.
20824 (outer_declaration): New grammar production.
20826 (attribute_sections): Add.
20828 (opt_attributes): Base on attribute_sections
20830 (namespace_declaration): Allow opt_attributes to tackle the case
20831 when we have assembly level attributes - we are clever in this
20834 * attribute.cs (ApplyAttributes): Do not worry about assembly
20835 attributes in the non-global context.
20837 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20838 instead of SetGlobalAttributes.
20840 * class.cs, rootcontext.cs : Ensure we define and generate
20841 attribute types before anything else.
20843 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20844 and flag the new error -20 for the case when the attribute type
20845 does not have valid targets specified. csc does not catch this.
20847 * ../errors/errors.txt : update for error # -20
20849 2002-04-11 Ravi Pratap <ravi@ximian.com>
20851 * support.cs (InternalParameters.ParameterModifier): Do some null
20852 checking and return sane values.
20854 * class.cs (Method.Define): If we are a PInvoke method, ensure
20855 that we are static and extern. Report error # 601
20857 * ../errors/cs0601.cs : Add test case for the above error.
20859 2002-04-07 Ravi Pratap <ravi@ximian.com>
20861 * rootcontext.cs (attribute_types): We need to keep type of
20862 all attribute types separately and emit code for them first.
20864 (RegisterAttribute) : Implement.
20866 * class.cs (DefineType): Check if the current Type is a custom
20867 attribute type and register it accordingly.
20869 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
20870 adding the first attribute twice and rename to
20872 (SetGlobalAttributes): this.
20874 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
20877 * attribute.cs (ApplyAttributes): Take an additional argument telling us
20878 if we are processing global arguments. Hmm, I am unsure of this.
20880 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20882 * expression.cs: added static array of strings to avoid calling
20883 Enum.ToString () for Operator in Binary. Significant recover of
20886 2002-04-10 Miguel de Icaza <miguel@ximian.com>
20888 * class.cs (FindMembers): Allow the Builders of the various
20889 members to be null. If they are skip them. This only happens
20890 during the PInvoke declaration.
20892 2002-04-09 Miguel de Icaza <miguel@ximian.com>
20894 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
20895 failure, so we do not keep going afterwards.
20897 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
20898 wanted to pass `false' as the `is_delegate' argument. If this is
20899 the case, why not use delegate_type == null to mean `is_delegate =
20900 false' and anything else as is_delegate = true.
20902 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
20904 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
20905 code for the section, not the beginning of the tests.
20907 2002-04-08 Miguel de Icaza <miguel@ximian.com>
20909 * cfold.cs: Handle operator + (Enum x, Underlying x)
20911 * expression.cs (Binary): same. Warn about errors where we have
20912 Enum/Enum in operator + as well.
20914 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
20917 - added support for switch(bool)
20918 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
20919 - add TableSwitchEmit() to handle table-based switch statements
20921 2002-04-05 Ravi Pratap <ravi@ximian.com>
20923 * expression.cs (Invocation.OverloadResolve): Factor out code which
20924 does parameter compatibility checking with arguments so that we can
20925 re-use the code even from Delegate.VerifyApplicability
20927 (VerifyArgumentsCompat): Move above code here.
20929 * delegate.cs (VerifyApplicability): Get rid of duplicate code
20930 and instead make a call to the above method.
20932 2002-03-31 Ravi Pratap <ravi@ximian.com>
20934 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
20935 We use it to keep track of classes which are attribute types.
20937 2002-04-02 Miguel de Icaza <miguel@ximian.com>
20939 * delegate.cs (Delegate.Define): Correctly define the types in the
20940 presence of fixed and array parameters.
20942 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
20945 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
20946 include NonPublic after the first iteration.
20948 * class.cs (Indexer.CheckBase): Only check if both parents are
20951 * cs-parser.jay (accessor_body): If empty, set to null.
20953 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
20954 same code path here to resolve constants names that we did have in
20955 MemberAccess.DoResolve. There is too much code duplicated here.
20957 2002-04-01 Miguel de Icaza <miguel@ximian.com>
20959 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
20961 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
20964 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
20965 tokens, numbers and strings.
20967 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
20970 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
20971 asyncronous parameters and the regular parameters.
20973 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
20974 specify the target directory.
20976 * expression.cs: (This.DoResolve): Simplify
20977 (As.Emit): Optimize, do not generate IsInst if the expression is
20978 always of the given type.
20980 (Is.DoResolve): Bug fix, we were reporting both always/never for
20983 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
20984 creating too many unnecessary arrays.
20986 2002-03-31 Miguel de Icaza <miguel@ximian.com>
20988 * class.cs (EmitFieldInitializer): Use Assign expression to assign
20989 fields instead of rolling our own initializer. Takes care of all
20990 implicit conversions, and drops unnecessary static checks/argument.
20992 2002-03-31 Dick Porter <dick@ximian.com>
20994 * driver.cs: use the GetDirectories() return values properly, and
20995 use "/" as path separator.
20997 2002-03-30 Miguel de Icaza <miguel@ximian.com>
20999 * expression.cs (Unary): Optimize - - expr into expr.
21000 (Binary): Optimize a + (-b) into a -b.
21002 * codegen.cs (CodeGen): Made all methods static.
21004 2002-03-29 Miguel de Icaza <miguel@ximian.com>
21008 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
21009 TypeBuilder property.
21011 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
21014 * tree.cs: Removed the various RecordXXXX, and replaced with a
21015 single RecordDecl. Removed all the accessor methods, and just
21016 left a single access point Type
21018 * enum.cs: Rename DefineEnum to DefineType.
21020 * decl.cs: New abstract method `DefineType' used to unify the
21021 Defines for Enumerations, Interfaces, TypeContainers and
21024 (FindType): Moved LookupInterfaceOrClass here. Moved the
21025 LookupBaseClasses method that used to live in class.cs and
21026 interface.cs here, and renamed to FindType.
21028 * delegate.cs: Implement DefineType. Take advantage of the
21029 refactored pattern for locating the parent builder without taking
21030 the parent_builder argument (which we know does not work if we are
21031 nested, and triggering a toplevel definition).
21033 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21035 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21036 accessibility of a member has changed during override and report
21039 * class.cs (Method.Define, Property.Define): Only complain on
21040 overrides if the method is private, any other accessibility is
21041 fine (and since we just checked the permission is the same, we are
21044 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
21045 and elif are processed always. The other pre-processing
21046 directives are only processed if we are "taking" the path
21048 2002-03-29 Martin Baulig <martin@gnome.org>
21050 * class.cs (Method.Emit): Only emit symbolic debugging info if the
21051 current location is not Null.
21053 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
21054 a separate method so we can profile it.
21056 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
21057 `span.Seconds' are just seconds, but no minutes or hours.
21058 (MainDriver): Profile the CodeGen.SaveSymbols calls.
21060 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21062 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
21063 Remove the gratuitous set of Final:
21065 // If an interface implementation, then we can set Final.
21066 if (((flags & MethodAttributes.Abstract) == 0) &&
21067 implementing.DeclaringType.IsInterface)
21068 flags |= MethodAttributes.Final;
21070 I do not know what I was smoking when I used that.
21073 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
21074 step into fixing the name resolution issues for delegates and
21075 unifying the toplevel name resolution.
21077 2002-03-28 Martin Baulig <martin@gnome.org>
21079 * class.cs (Method.Emit): If we have a symbol writer, call its
21080 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
21081 tell it about the current method.
21083 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
21084 writer that we're going to emit the first byte of IL code for a new
21085 statement (a new source line).
21086 (EmitContext.EmitTopBlock): If we have a symbol writer, call
21087 EmitContext.Mark() before emitting any code.
21089 * location.cs (SymbolDocument): Return null when we're Null.
21091 * statement.cs (Statement): Moved the `Location loc' variable here.
21092 (Statement.EmitBoolExpression): If we have a symbol writer, call
21093 ec.Mark() before emitting any code to tell it that we're at the
21094 beginning of a new statement.
21095 (StatementExpression): Added `Location' argument to the constructor.
21096 (Block): Added public readonly variable `StartLocation' and public
21097 variable `EndLocation'. The latter is to be set using SetEndLocation().
21098 (Block): Added constructor which takes a start and end location.
21099 (Block.SetEndLocation): New method. This sets the end location.
21100 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
21101 local variables we create.
21102 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
21103 each statement and do also mark the begin and end of the block.
21105 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21106 tell it the current lexer.Location, use Location.Null for the end of the
21108 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
21109 current block, set its end location using SetEndLocation().
21110 (statement_expression): StatementExpression constructor now takes the
21111 lexer.Location as additional argument.
21112 (for_statement, declare_local_variables): Likewise.
21113 (declare_local_variables): When creating a new implicit block, use the
21114 new Block constructor and pass it the lexer.Location.
21116 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21118 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
21119 members also on the parent interfaces recursively.
21121 2002-03-27 Miguel de Icaza <miguel@ximian.com>
21123 * report.cs: Use new formats, since Gonzalo finished the missing
21126 * expression.cs (Binary.ResolveOperator): added missing operator|
21127 operator& and operator^ for bool/bool.
21129 * cs-parser.jay: CheckDef now takes a Location argument that is
21130 used to report errors more precisly (instead of reporting the end
21131 of a definition, we try to track something which is a lot closer
21132 to the source of the problem).
21134 * cs-tokenizer.cs: Track global token use, so we can properly flag
21135 the use of #define/#undef after the first token has been seen.
21137 Also, rename the reportXXXX to Error_DescriptiveName
21139 * decl.cs (DeclSpace.IsTopLevel): Move property here from
21140 TypeContainer, so that Enum and Interface can use this too.
21142 * class.cs (TypeContainer.LookupInterfaceOrClass,
21143 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
21144 `builder' argument. Typically this was used to pass the parent
21145 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
21148 The problem is that a nested class could trigger the definition of
21149 a toplevel class, and the builder would be obviously wrong in that
21152 So we drop this argument, and we compute dynamically the
21153 TypeBuilder/ModuleBuilder (the correct information was available
21154 to us anyways from DeclSpace.Parent)
21156 * interface.cs (Interface.DefineInterface): Drop builder
21157 parameter cleanup like class.cs
21159 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
21162 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
21165 (Try.Emit): Propagate the returns value from the statement.
21167 (Return.Emit): Even if we are leavning
21169 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
21171 * modifiers.cs: Fix the computation of MethodAttributes flags.
21173 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
21175 * driver.cs: allow compilation of files that start with '/'.
21176 Add a default case when checking the argument of --target.
21178 2002-03-25 Miguel de Icaza <miguel@ximian.com>
21180 * interface.cs: Implement the same search algorithm for types in
21181 the interface code.
21183 * delegate.cs: Do not allow multiple definition.
21185 * Recovered ChangeLog that got accidentally amputated
21187 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
21189 * rootcontext.cs: Load manually enum to allow core classes to
21190 contain enumerations.
21192 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
21193 Update to new static methods in TypeManager.
21195 * typemanager.cs (GetMethod, GetConstructor): Use our
21196 implementation of FindMembers to find the members, since during
21197 corlib compilation, the types are TypeBuilders and GetMethod and
21198 GetConstructor do not work.
21200 Make all methods in TypeManager static.
21202 (InitCodeHelpers): Split the functionality from
21203 the InitCodeTypes function.
21205 * driver.cs: Call InitCodeHelpers after we have populated the
21208 * cs-parser.jay (delegate_declaration): we did not used to compute
21209 the delegate name correctly for void delegates.
21211 2002-03-24 Miguel de Icaza <miguel@ximian.com>
21213 * rootcontext.cs (RootContext): Init the interface_resolve_order
21214 and type_container_resolve_order always.
21216 (ResolveCore, BootstrapCorlib_ResolveClass,
21217 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
21218 compiler when compiling with --nostdlib
21220 * class.cs (TypeContainer.DefineType): Check that our parent is
21221 not null. This test is most important when we are bootstraping
21224 * codegen.cs: Split out the symbol writing code.
21226 2002-03-25 Martin Baulig <martin@gnome.org>
21228 * driver.cs (-g): Made -g an alias for --debug.
21230 2002-03-24 Martin Baulig <martin@gnome.org>
21232 * codegen.cs (SymbolWriter): New public variable. Returns the
21233 current symbol writer.
21234 (CodeGen): Added `bool want_debugging_support' argument to the
21235 constructor. If true, tell the ModuleBuild that we want debugging
21236 support and ask it for the ISymbolWriter.
21237 (Save): If we have a symbol writer, call it's Close() method after
21238 saving the assembly.
21240 * driver.c (--debug): New command line argument to create a
21241 debugger information file.
21243 * location.cs (SymbolDocument): New public property. Returns an
21244 ISymbolDocumentWriter object for the current source file or null
21245 if we don't have a symbol writer.
21247 2002-03-21 Miguel de Icaza <miguel@ximian.com>
21249 * driver.cs (LoadAssembly): Correctly return when all the paths
21250 have been tried and not before.
21252 * statement.cs (Switch.Emit): return the actual coverage for this
21253 statement (returns/not-returns)
21255 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
21256 switch of the statement if we are the last switch section. That
21257 kills two problems: try/catch problems (we used to emit an empty
21258 nop at the end) and switch statements where all branches would
21261 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21263 * driver.cs: Add default assemblies (the equivalent to the
21264 Microsoft CSC.RSP file)
21266 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21267 also update tokens_seen and set it to false.
21269 * driver.cs: Implement --recurse for Mike.
21271 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21272 correctly splitting out the paths.
21274 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21276 * interface.cs (Interface.PopulateProperty): Instead of using
21277 `parent' as the declaration space for the set parameters, use
21280 * support.cs (InternalParameters): InternalParameters constructor
21281 takes a DeclSpace instead of a TypeContainer.
21283 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21284 types are being initialized, load the address of it before calling
21287 (New): Provide a mechanism to disable the generation of local
21288 value type temporaries when the caller will be providing us with
21289 an address to store it.
21291 (ArrayCreation.EmitDynamicInitializers): Use it.
21293 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21295 * expression.cs (Invocation.EmitArguments): Only probe for array
21296 property if there is more than one argument. Sorry about that.
21298 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21299 empty param arrays.
21301 * class.cs (Method.LabelParameters): Fix incorrect code path that
21302 prevented the `ParamArrayAttribute' from being applied to the
21305 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21307 * support.cs (ReflectionParameters): Correctly compute whether the
21308 last argument is a params array. Fixes the problem with
21311 * typemanager.cs: Make the assemblies array always be non-null
21312 (empty, but non-null)
21314 * tree.cs (RecordDecl): New function that abstracts the recording
21315 of names. This reports error 101, and provides a pointer to the
21316 previous declaration. Fixes a crash in the compiler.
21318 * cs-parser.jay (constructor_declaration): Update to new grammar,
21319 and provide a constructor_body that can be empty.
21321 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21323 * driver.cs: Add support for --resources.
21325 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21326 Make all types for the various array helper methods be integer.
21328 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21329 CheckState to ConvCast.
21331 (ConvCast): Now it takes a `checked' state argument, to avoid
21332 depending on the emit context for the conversion, and just using
21333 the resolve time setting.
21335 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21336 instead of Invocation.EmitArguments. We do not emit the original
21337 arguments, instead we emit those which have been converted to
21338 unsigned int expressions.
21340 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21342 * codegen.cs: ditto.
21344 * expression.cs (LocalVariableReference): Drop the use of the
21345 Store function that depended on the variable index.
21347 * statement.cs (VariableInfo): Drop the `Idx' property from this
21348 class, as this is not taking into account the indexes for
21349 temporaries tat we generate during the execution, getting the
21352 * class.cs: First emit class initializers, then call the parent
21355 * expression.cs (Binary): Fix opcode emision.
21356 (UnaryMutator.EmitCode): Support checked code generation
21358 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21359 matches for events for both the Static and Instance scans,
21360 pointing to the same element. Fix that.
21362 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21364 * rootcontext.cs (ResolveTree): Always set the
21365 interface_resolve_order, because nested interfaces will be calling
21368 * class.cs (GetInterfaceOrClass): Track the same resolution
21369 process used by TypeManager.LookupType. This fixes the nested
21370 type lookups in class declarations (separate path from
21373 (TypeContainer.DefineType): Also define nested interfaces.
21374 (TypeContainer.RegisterOrder): New public function used to
21375 register the order in which child interfaces need to be closed.
21377 Nested interfaces need to be closed after their parents have been
21380 * interface.cs (InterfaceAttr): Put all the logic for computing
21381 the interface attribute here.
21383 (DefineInterface): Register our interface order with the
21384 RootContext or with the TypeContainer depending on the case.
21386 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21388 * cs-parser.jay: rework foreach statement to work with the new
21389 changes to the policy on SimpleNames.
21391 * report.cs: support Stacktrace on warnings as well.
21393 * makefile: drop --unsafe and /unsafe from the compile.
21395 2002-03-13 Ravi Pratap <ravi@ximian.com>
21397 * ecore.cs (StandardConversionExists): Modify to take an Expression
21398 as the first parameter. Ensure we do null -> reference type conversion
21401 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21402 temporary Expression objects.
21404 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21406 * interface.cs: workaround bug in method overloading resolution
21407 (there is already a bugzilla bug for it).
21409 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21411 We could also solve this problem by having a separate path for
21412 performing type lookups, instead of DoResolve, we could have a
21413 ResolveType entry point, and only participating pieces of the
21414 production (simplename, deref, array) would implement this.
21416 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21417 signal SimpleName to only resolve type names and not attempt to
21418 resolve anything else.
21420 * expression.cs (Cast): Set the flag.
21422 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21424 * class.cs: Only report 108 if there is no `new' modifier.
21426 * cs-parser.jay: rework foreach statement to work with the new
21427 changes to the policy on SimpleNames.
21429 * report.cs: support Stacktrace on warnings as well.
21431 * makefile: drop --unsafe and /unsafe from the compile.
21433 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21435 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21436 lookups here, instead of doing that at parse time. This means
21437 that our grammar will not introduce `LocalVariableReferences' as
21438 expressions at this point. That solves the problem of code like
21442 static void Main ()
21446 This is only half the fix. The full fix requires parameters to
21447 also be handled in this way.
21449 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21450 makes the use more obvious of the DeclSpace. The
21451 ec.TypeContainer.TypeBuilder is now only used to pull the
21452 TypeBuilder for it.
21454 My theory is that I can get rid of the TypeBuilder completely from
21455 the EmitContext, and have typecasts where it is used (from
21456 DeclSpace to where it matters).
21458 The only pending problem is that the code that implements Aliases
21459 is on TypeContainer, and probably should go in DeclSpace.
21461 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21462 lookups here, instead of doing that at parse time. This means
21463 that our grammar will not introduce `LocalVariableReferences' as
21464 expressions at this point. That solves the problem of code like
21468 static void Main ()
21472 This is only half the fix. The full fix requires parameters to
21473 also be handled in this way.
21475 * class.cs (Property.DefineMethod): When implementing an interface
21476 method, set newslot, when implementing an abstract method, do not
21477 set the flag (before we tried never setting it, or always setting
21478 it, which is the difference).
21479 (Indexer.DefineMethod): same.
21480 (Method.DefineMethod): same.
21482 * ecore.cs: Only set the status used flag if we get back a Field.
21484 * attribute.cs: Temporary hack, so Paolo can keep working.
21486 2002-03-08 Ravi Pratap <ravi@ximian.com>
21488 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21489 the unmanaged type in the case we have a MarshalAs attribute.
21491 (Resolve): Handle the case when we are parsing the special MarshalAs
21492 attribute [we need to store the unmanaged type to use later]
21494 * typemanager.cs (marshal_as_attr_type): Built in type for the
21495 MarshalAs Attribute.
21497 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21498 on parameters and accordingly set the marshalling info.
21500 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21502 * class.cs: Optimizing slightly by removing redundant code after
21503 we switched to the `NoTypes' return value.
21504 (Property.DefineMethod): use NoTypes here too.
21506 This fixes the bug I introduced in my last batch of changes.
21508 2002-03-05 Ravi Pratap <ravi@ximian.com>
21510 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21512 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21513 Enums since those are types too.
21515 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21517 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21518 thanks to a call during the lookup process.
21520 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21522 * statement.cs (Foreach): Lots of work to accomodate a particular
21523 kind of foreach statement that I had not kept in mind. It is
21524 possible to have foreachs on classes that provide a GetEnumerator
21525 method that return objects that implement the "pattern" for using
21526 a foreach, there is no need to support GetEnumerator
21529 This is needed to compile nant.
21531 * decl.cs: Only report 114 if the member is not `Finalize' and if
21532 the warning level is at least 2.
21534 * class.cs: Moved the compare function from Method to
21537 (MethodSignature.InheritableMemberSignatureCompare): Add new
21538 filter function that is used to extract inheritable methods from a
21541 (Method.Define): Use the new `inheritable_method_signature_filter'
21544 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21547 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21549 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21551 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21553 * expression.cs: Pass location information to
21554 ConvertImplicitStandard.
21556 * class.cs: Added debugging code to track return values from
21559 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21561 * expression.cs (Is.DoResolve): If either side of the `is' is an
21562 interface, do not flag the warning.
21564 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21567 * report.cs: Allow for --fatal to be used with --probe.
21569 * typemanager.cs (NoTypes): Move the definition for the empty Type
21572 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21574 (TypeContainer.DefineProxy): New function used to proxy to parent
21575 implementations when implementing interfaces.
21576 (TypeContainer.ParentImplements): used to lookup if our parent
21577 implements a public function that is required by an interface.
21578 (TypeContainer.VerifyPendingMethods): Hook this up.
21580 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21581 `modules' and `assemblies' arraylists into arrays. We only grow
21582 these are the very early start up of the program, so this improves
21583 the speedof LookupType (nicely measured).
21585 * expression.cs (MakeByteBlob): Replaced unsafe code with
21586 BitConverter, as suggested by Paolo.
21588 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21589 folding of string concatenation, but if either side is a string,
21590 and the other is not, then return null, and let the runtime use
21591 the concatenation on the string plus the object (using
21592 `Object.ToString').
21594 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21596 Constant Folding has been implemented now.
21598 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21599 the error instead on types that are not supported in one's
21602 * constant.cs (Constant and all children): New set of functions to
21603 perform implict and explicit conversions.
21605 * ecore.cs (EnumConstant): Implement the new functions to perform
21606 conversion by proxying to the child expression.
21608 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21609 own separate setting that can not be turned off from the command
21610 line using --unchecked or --checked and is only controlled using
21611 the checked/unchecked statements and expressions. This setting is
21612 used by the constant folder to flag errors.
21614 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21615 ConstantCheckState as well.
21617 During Resolve, they also have to flag the state, because the
21618 constant folder runs completely in the Resolve phase.
21620 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21623 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21625 * cfold.cs: New file, this file contains the constant folder.
21627 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21628 argument to track whether we are using the resulting address to
21629 load or store a value and provide better error messages.
21631 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21632 new AddressOf arguments.
21634 * statement.cs (Foreach.EmitCollectionForeach): Update
21636 * expression.cs (Argument.Emit): Call AddressOf with proper
21637 arguments to track usage.
21639 (New.DoEmit): Call AddressOf with new arguments.
21641 (Unary.Emit): Adjust AddressOf call.
21643 2002-03-01 Ravi Pratap <ravi@ximian.com>
21645 * cs-parser.jay (member_access): Change the case for pre-defined types
21646 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21649 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21652 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21653 essentially like methods and apply attributes like MethodImplOptions to them too.
21655 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21658 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21659 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21662 * Update code everywhere accordingly.
21664 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21666 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21668 2002-02-28 Ravi Pratap <ravi@ximian.com>
21670 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21671 try performing lookups against those instead of jumping straight into using
21672 the 'using' clauses.
21674 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21676 (LookupType): Perform lookups in implicit parents too.
21678 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21679 sequence as RootContext.LookupType.
21681 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21682 the various cases of namespace lookups into this method.
21684 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21686 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21687 in positional arguments)
21689 * class.cs (Operator): Update the AllowedModifiers to contain
21692 * cs-parser.jay: Update operator declaration to allow for the
21693 operator body to be empty.
21695 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21698 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21700 * class.cs (Method.Emit): Label parameters.
21702 * driver.cs: Return 1 or 0 as the program exit code.
21704 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21706 * expression.cs: Special case the `null' object when trying to
21707 auto-compute the type, as anything can be explicitly converted to
21710 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21711 spotting this Paolo.
21713 (Expression.ImplicitNumericConversion): Perform comparissions of
21714 the type using the underlying type in the case of an enumeration
21715 rather than using the enumeration type for the compare.
21717 Cope with the underlying == type case, which is not possible to
21720 (Expression.ConvertNumericExplicit): Perform comparissions of
21721 the type using the underlying type in the case of an enumeration
21722 rather than using the enumeration type for the compare.
21724 * driver.cs: If the user does not supply an extension, assume .exe
21726 * cs-parser.jay (if_statement): Rewrote so that we can track the
21727 location for the if statement.
21729 * expression.cs (Binary.ConstantFold): Only concat strings when
21730 the operation is "+", not everything ;-)
21732 * statement.cs (Statement.EmitBoolExpression): Take a location
21734 (If, While, Do): Track location.
21736 * expression.cs (Binary.ResolveOperator): In the object + string
21737 case, I was missing a call to ConvertImplicit
21739 2002-02-25 Ravi Pratap <ravi@ximian.com>
21741 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21742 Location arguments. Ensure we use RootContext.LookupType to do our work
21743 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21745 * interface.cs (PopulateMethod): Handle the type of the parameter being
21748 * expression.cs (Invocation.BetterFunction): Handle the case when we
21749 have a params method with no fixed arguments and a call is made with no
21752 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21754 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21755 the verbatim-string-literal
21757 * support.cs (InternalParameters.ParameterModifier): handle null
21759 (InternalParameters.ParameterType): ditto.
21761 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21762 duplicating the name of the variable parameter.
21763 (GetParameterByName): Fix bug where we were not looking up array
21764 paramters if they were the only present (thanks Paolo!).
21765 (GetParameterInfo): We only have an empty set of types if both
21766 fixed and array are set to null.
21767 (GetParameterInfo-idx): Handle FixedParameter == null
21769 * cs-parser.jay: Handle the case where there is no catch
21770 statements (missing null test).
21772 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21774 * driver.cs (MainDriver): Be conservative on our command line
21777 Catch DirectoryNotFoundException when calling GetFiles.
21779 (SplitPathAndPattern): Used to split the input specification into
21780 a path and a pattern that we can feed to Directory.GetFiles.
21782 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21784 * statement.cs (Fixed): Implement the last case of the Fixed
21785 statement (string handling).
21787 * expression.cs (StringPtr): New class used to return a char * to
21788 a string; Used by the Fixed statement.
21790 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21792 * expression.cs (Binary.ResolveOperator): Remove redundant
21793 MemberLookup pn parent type.
21794 Optimize union call, we do not need a union if the types are the same.
21795 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21798 Specialize the use of MemberLookup everywhere, instead of using
21799 the default settings.
21801 (StackAlloc): Implement stackalloc keyword.
21803 * cs-parser.jay: Add rule to parse stackalloc.
21805 * driver.cs: Handle /h, /help, /?
21807 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21808 before we supported unsafe code.
21810 * makefile: add --unsafe to the self compilation of mcs.
21812 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21814 * expression.cs (PointerArithmetic): New class that is used to
21815 perform pointer arithmetic.
21816 (Binary.Resolve): Handle pointer arithmetic
21817 Handle pointer comparission.
21818 (ArrayPtr): Utility expression class that is used to take the
21819 address of an array.
21821 (ElementAccess): Implement array access for pointers
21823 * statement.cs (Fixed): Implement fixed statement for arrays, we
21824 are missing one more case before we are done.
21826 * expression.cs (Indirection): Implement EmitAssign and set the
21827 ExprClass to Variable. This allows pointer dereferences to be
21828 treated as variables, and to have values assigned to them.
21830 * ecore.cs (Expression.StoreFromPtr): New utility function to
21831 store values dereferencing.
21833 2002-02-20 Ravi Pratap <ravi@ximian.com>
21835 * expression.cs (Binary.ResolveOperator): Ensure that we are
21836 not trying to operate on a void type - this fixes the reported
21839 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21840 the parent implementation is sealed.
21842 * ../errors/cs0239.cs : Add.
21844 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21846 * typemanager.cs (unverifiable_code_type): Corresponds to
21847 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21848 which have unsafe code in them.
21850 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21853 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21855 * cs-tokenizer.cs: Add support for @"litreal strings"
21857 Make tokenizer accept pre-processor directives
21858 on any column (remove the old C-like limitation).
21860 * rootcontext.cs (EmitCode): Emit any global attributes.
21861 (AddGlobalAttributes): Used to keep track of assembly attributes.
21863 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21865 * cs-parser.jay: Add support for global attributes.
21867 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21869 * expression.cs (Indirection): New helper class. Unary will
21870 create Indirection classes to be able to implement the
21871 IMemoryLocation interface on it.
21873 2002-02-16 Miguel de Icaza <miguel@ximian.com>
21875 * cs-parser.jay (fixed_statement): reference the right statement.
21877 * statement.cs (Fixed.Emit): Finish implementing the fixed
21878 statement for the &x case.
21880 2002-02-14 Miguel de Icaza <miguel@ximian.com>
21882 * class.cs (Property.Define, Method.Define): Remove newslot when
21885 * modifiers.cs: My use of NewSlot when `Abstract' was set was
21886 wrong. NewSlot should only be used if the `new' keyword is present.
21888 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
21889 locating our system dir. Sorry about this.
21891 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21893 * driver.cs (GetSystemDir): Compute correctly the location of our
21894 system assemblies. I was using the compiler directory instead of
21895 the library directory.
21897 2002-02-13 Ravi Pratap <ravi@ximian.com>
21899 * expression.cs (BetterFunction): Put back in what Miguel commented out
21900 since it is the correct fix. The problem is elsewhere ;-)
21902 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
21903 parameters of the parms method are themselves compatible or not !
21905 (StandardConversionExists): Fix very dangerous bug where we were forgetting
21906 to check that a class implements an interface before saying that an implicit
21907 conversion was allowed. Use ImplementsInterface to do the checking.
21909 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21911 * class.cs (Method.Define): Track whether we are an explicit
21912 implementation or not. And only call DefineMethodOverride if we
21913 are an explicit implementation.
21915 (Property.DefineMethod): Ditto.
21917 2002-02-11 Ravi Pratap <ravi@ximian.com>
21919 * expression.cs (BetterFunction): Catch hideous bug which was
21920 preventing us from detecting ambiguous calls due to implicit casts i.e
21923 2002-01-29 Miguel de Icaza <miguel@ximian.com>
21925 * support.cs (Pair): Remove un-needed method. I figured why I was
21926 getting the error in cs-parser.jay, the variable in a foreach loop
21927 is readonly, and the compiler does not really treat this as a variable.
21929 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
21930 instead of EQUALS in grammar.
21932 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
21934 * expression.cs (Unary.DoResolve): Check whether the argument is
21937 2002-01-28 Miguel de Icaza <miguel@ximian.com>
21939 * support.cs: Api for Pair to set a value. Despite the fact that
21940 the variables are public the MS C# compiler refuses to compile
21941 code that accesses the field if the variable is part of a foreach
21944 * statement.cs (Fixed): Begin implementation of the fixed
21947 (Block.AddVariable): Return the VariableInfo on success and null
21948 on failure instead of true/false.
21950 * cs-parser.jay (foreach): Catch errors on variables already
21951 defined (we were ignoring this value before) and properly unwind
21952 the block hierarchy
21954 (fixed_statement): grammar for the fixed statement.
21956 2002-01-25 Miguel de Icaza <miguel@ximian.com>
21958 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
21959 pointer types to be incretemented.
21961 (SizeOf): Implement.
21963 * cs-parser.jay (pointer_member_access): Implement
21964 expr->IDENTIFIER production.
21966 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
21967 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
21970 (Unary): Implement indirection.
21972 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
21973 use in non-unsafe context).
21975 (SimpleName.DoResolve): Check for pointers in field access on safe
21978 (Expression.LoadFromPtr): Factor the load-indirect code in this
21979 function. This was duplicated in UnboxCast and ParameterReference
21981 2002-01-24 Miguel de Icaza <miguel@ximian.com>
21983 * expression.cs (ComposedCast): report an error if a pointer cast
21984 is used in a safe region.
21986 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
21987 pointer type casts in unsafe context.
21989 * codegen.cs (EmitContext): Set up IsUnsafe.
21991 * cs-parser.jay (non_expression_type): Add productions for pointer
21994 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
21995 code. We should not use force into static mode if the method is
21996 not virtual. Fixes bug in MIS
21998 * statement.cs (Do.Emit, While.Emit, For.Emit,
21999 Statement.EmitBoolExpression): Add support to Do and While to
22000 propagate infinite loop as `I do return' semantics.
22002 Improve the For case to also test for boolean constants.
22004 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
22005 to the list of attributes we can add.
22007 Remove `EmitContext' argument.
22009 * class.cs (Method.Define): Apply parameter attributes.
22010 (Constructor.Define): Apply parameter attributes.
22011 (MethodCore.LabelParameters): Move here the core of labeling
22014 * support.cs (ReflectionParameters.ParameterModifier,
22015 InternalParameters.ParameterModifier): Use IsByRef on the type and
22016 only return the OUT bit for these parameters instead of in/out/ref
22019 This is because I miss-understood things. The ParameterInfo.IsIn
22020 and IsOut represent whether the parameter has the [In] and [Out]
22023 2002-01-22 Miguel de Icaza <miguel@ximian.com>
22025 * ecore.cs (FieldExpr.Emit): Release temporaries.
22027 * assign.cs (LocalTemporary.Release): new function.
22029 * codegen.cs (EmitContext.GetTemporaryStorage,
22030 EmitContext.FreeTemporaryStorage): Rework the way we deal with
22031 temporary storage. Now we can "put back" localbuilders when we
22034 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22036 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22037 need to make a copy of the variable to generate verifiable code.
22039 2002-01-19 Miguel de Icaza <miguel@ximian.com>
22041 * driver.cs: Compute dynamically the system directory.
22043 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
22044 Slower, but more generally useful. Used by the abstract
22045 registering implementation.
22047 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
22048 the rules for the special rule on Type/instances. First check if
22049 we have the same name, and if so, try that special static path
22050 rather than the instance path.
22052 2002-01-18 Miguel de Icaza <miguel@ximian.com>
22054 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
22057 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
22058 Enum, ValueType, Delegate or Array for non-corlib compiles.
22060 * cs-tokenizer.cs: Catch long identifiers (645)
22062 * typemanager.cs (IndexerPropetyName): Ravi never tested this
22065 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
22066 fix, we were returning too early, so we were not registering
22067 pending methods from abstract classes.
22069 Do not register pending methods if the class is abstract.
22071 * expression.cs (Conditional.DoResolve): Report circular implicit
22072 conversions when we neecd to compute it for conditional
22075 (Is.DoResolve): If the expression is always of the provided type,
22076 flag warning 183. If the expression can not ever be of the
22077 provided type flag warning 184.
22079 * class.cs: Catch 169 as well.
22081 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
22084 2002-01-18 Nick Drochak <ndrochak@gol.com>
22086 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
22088 2002-01-17 Miguel de Icaza <miguel@ximian.com>
22090 * interface.cs: (PopulateMethod): Check for pointers being defined
22091 only if the unsafe context is active.
22092 (PopulateProperty): ditto.
22093 (PopulateIndexer): ditto.
22095 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
22096 specified. If pointers are present, make sure that they are
22097 present in an unsafe context.
22098 (Constructor, Constructor.Define): ditto.
22099 (Field, Field.Define): ditto.
22100 (Property, Property.Define): ditto.
22101 (Event, Event.Define): ditto.
22103 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
22104 hashtable if there are classes or structs defined.
22106 * expression.cs (LocalVariableReference.DoResolve): Simplify this
22107 code, as the constant resolution moved.
22109 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
22110 the metadata, so we can flag error 133.
22112 * decl.cs (MemberCore.UnsafeOK): New function to test that a
22113 pointer is being declared in an unsafe context.
22115 2002-01-16 Miguel de Icaza <miguel@ximian.com>
22117 * modifiers.cs (Modifiers.Check): Require a Location argument.
22118 Report error 227 for Unsafe use.
22120 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
22122 * statement.cs (For.Emit): If the test is null, then report that
22123 we do `return', as we wont reach anything afterwards.
22125 (Switch.SwitchGoverningType): Track the expression that matched
22128 * driver.cs: Allow negative numbers as an error code to flag.
22130 * cs-parser.jay: Handle 1551.
22132 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
22134 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22136 * cs-parser.jay: Report 1518 (type declaration can only contain
22137 class, struct, interface, enum or delegate)
22139 (switch_label): Report 1523 (keywords `case' or `default' must
22142 (opt_switch_sections): Report 1522 (empty switch)
22144 * driver.cs: Report 1515 (response file specified multiple times)
22145 Report 1516 (Source file specified multiple times).
22147 * expression.cs (Argument.Resolve): Signal 1510
22149 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
22150 access not allowed in static code)
22152 2002-01-11 Ravi Pratap <ravi@ximian.com>
22154 * typemanager.cs (IsPointerType): Utility method which we are going
22157 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
22158 the object type, so we take care of that.
22160 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
22162 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
22163 added to non-params parameters :-)
22165 * typemanager.cs (CSharpName): Include 'void' type too.
22167 (void_ptr_type): Include in the set of core types.
22169 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
22172 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
22175 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
22176 completely forgotten about it.
22178 2002-01-10 Ravi Pratap <ravi@ximian.com>
22180 * cs-parser.jay (pointer_type): Add. This begins our implementation
22181 of parsing rules for unsafe code.
22183 (unsafe_statement): Implement.
22185 (embedded_statement): Modify to include the above.
22187 * statement.cs (Unsafe): Implement new class for unsafe blocks.
22189 * codegen.cs (EmitContext.InUnsafe): Add. This determines
22190 if the current context is an unsafe one.
22192 * cs-parser.jay (local_variable_pointer_type): Since local variable types
22193 are handled differently, we need separate rules for them.
22195 (local_variable_declaration): Update to use local_variable_pointer_type
22196 to allow variable declarations of unmanaged pointer types.
22198 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
22199 in unsafe contexts.
22201 * ../errors/cs0214.cs : Add.
22203 2002-01-16 Nick Drochak <ndrochak@gol.com>
22205 * makefile: remove 'response' file when cleaning.
22207 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22209 * cs-parser.jay: Report 1524.
22211 2002-01-14 Miguel de Icaza <miguel@ximian.com>
22213 * typemanager.cs (RegisterMethod): drop checking if we have
22214 registered this from here
22216 2002-01-12 Miguel de Icaza <miguel@ximian.com>
22218 * class.cs (Method.EmitDestructor): Implement calling our base
22221 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
22222 value of InFinally.
22224 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
22225 this routine and will wrap the call in a try/catch block. Deal
22228 2002-01-11 Miguel de Icaza <miguel@ximian.com>
22230 * ecore.cs (Expression.MemberLookup): instead of taking a
22231 parameter `same_type' that was used to tell whether we could
22232 access private members we compute our containing type from the
22235 (FieldExpr): Added partial support for volatile fields. This does
22236 not work for volatile fields exposed from assemblies, as I can not
22237 figure out how to extract the modreq from it.
22239 Updated all the source files to use this.
22241 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
22242 because it is referenced by MemberLookup very often.
22244 2002-01-09 Ravi Pratap <ravi@ximian.com>
22246 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
22247 TypeBuilder.GetCustomAttributes to retrieve what we need.
22249 Get rid of redundant default_member_attr_type as this is the same as
22250 default_member_type which already exists.
22252 * interface.cs, attribute.cs : Update accordingly.
22254 2002-01-08 Miguel de Icaza <miguel@ximian.com>
22256 * typemanager.cs: Enable IndexerPropertyName again. It does not
22257 work for TYpeBuilders though. Ravi, can you please fix this?
22259 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22261 * expression.cs (Argument.Emit): Handle the case of ref objects
22262 being passed to ref functions;
22264 (ParameterReference.EmitLoad): Loads the content of the pointer
22265 without dereferencing.
22267 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22269 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22271 2002-01-08 Ravi Pratap <ravi@ximian.com>
22273 * class.cs (Indexer.DefineMethod): Incorporate the interface
22274 type in the name of the method if we are doing explicit interface
22277 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22279 (BetterConversion): Fix extremely trivial bug where we were referring to
22280 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22283 * ../errors/bug16.cs : Add although we have fixed it.
22285 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22287 * expression.cs (BaseIndexer): Begin implementation.
22289 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22291 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22292 production directly to remove a shift/reduce, and implement
22293 explicit interface implementation.
22295 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22296 after a floating point suffix.
22298 * expression.cs (DoNumericPromotions): Improved the conversion for
22299 uint/uint. If we have a constant, we avoid doing a typecast to a
22302 * class.cs (Indexer): Implement explicit interface implementation
22305 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22307 * class.cs: make the default instance constructor public and hidebysig.
22309 2001-01-03 Ravi Pratap <ravi@ximian.com>
22311 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22312 so we can call it from elsewhere.
22314 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22315 we emit it internally if the class has a defined indexer; otherwise the user
22316 emits it by decorating the class definition with the DefaultMemberAttribute.
22318 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22319 attribute is not used on a type which defines an indexer.
22321 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22322 character when we skip whitespace.
22324 * ../errors/cs0646.cs : Add.
22326 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22328 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22331 * makefile: Add practical target `mcs3.exe' which builds the third
22332 generation compiler.
22334 * expression.cs (New): Fix structures constructor calling.
22336 * class.cs (Property, Method, Indexer): Emit Final flag on the
22337 method if we are an interface implementation and we are not
22340 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22341 whether this property is referencing a `base' method.
22343 * expression.cs (Invocation.EmitCall): take an extra argument:
22344 is_base, this is used to determine whether the `call' or
22345 `callvirt' opcode should be used.
22348 * delegate.cs: update EmitCall.
22350 * class.cs (Method.Define): Set NewSlot for the cases where we are
22351 not implementing an interface method.
22353 (Property.Define): ditto.
22355 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22357 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22358 'r'. Allows mcs to parse itself fully.
22360 2002-01-02 Ravi Pratap <ravi@ximian.com>
22362 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22363 of the number of initializers that require the InitializeArray method.
22365 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22366 update the above field where necessary.
22368 (MakeByteBlob): Update accordingly.
22370 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22373 (EmitDynamicInitializers): Update in accordance with the new optimization.
22375 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22376 same OpCode applies.
22378 * cs-parser.jay : Fix some glaring errors I introduced.
22380 2002-01-01 Ravi Pratap <ravi@ximian.com>
22382 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22383 so that we can check for name clashes there too.
22385 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22386 for interface indexers.
22388 * interfaces.cs (Define): Emit the default member attribute.
22390 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22391 variable was being referred to while setting the value ;-)
22393 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22395 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22396 byte-by-byte information when we know the data is zero.
22398 Make the block always a multiple of 4, because
22399 DefineInitializedData has a bug.
22401 * assign.cs: Fix, we should assign from the temporary, not from
22404 * expression.cs (MakeByteBlob): Fix my incorrect code.
22406 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22408 * typemanager.cs (EnumToUnderlying): This function is used to get
22409 the underlying type from an enumeration, because it does not
22412 * constant.cs: Use the I4_S form for values between -128 and 127.
22414 * statement.cs (Block.LookupLabel): Looks up a label.
22415 (Block): Drop support for labeled blocks.
22417 (LabeledStatement): New kind of statement that represents a label
22420 (Goto): Finally implement this bad boy.
22422 * cs-parser.jay: Update to reflect new mechanism to implement
22425 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22427 * codegen.cs (EmitContext.This): a codegen property that keeps the
22428 a single instance of this instead of creating many different this
22431 * delegate.cs (Delegate.DoResolve): Update to use the property;
22433 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22435 * expression.cs (BaseAccess.DoResolve): Ditto.
22437 2001-12-29 Ravi Pratap <ravi@ximian.com>
22439 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22440 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22442 (InitCoreTypes): Update accordingly.
22444 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22445 so we can quickly store the state.
22447 (ApplyAttributes): Set the correct implementation flags
22448 for InternalCall methods.
22450 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22452 * expression.cs (EmitCall): if a method is not virtual, then do
22453 not use callvirt on it.
22455 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22456 user defined stuff) requires the use of stobj, which takes an
22457 address on the stack instead of an array and an index. So emit
22458 the Ldelema operation for it.
22460 (EmitStoreOpcode): Use stobj for valuetypes.
22462 (UnaryMutator.EmitCode): Use the right 1 value depending on
22463 whether we are dealing with int64/uint64, float or doubles.
22465 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22466 constructors that I implemented last night.
22468 (Constructor.IsDefault): Fix to work properly for static
22471 * cs-parser.jay (CheckDef): report method signature errors.
22472 Update error number 103 to be 132.
22474 * decl.cs: New AdditionResult enumeration value: MethodExists.
22475 Although we do this check for methods later on in the semantic
22476 analysis, catching repeated default constructors is so easy that
22477 we catch these here.
22479 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22482 (ParameterReference.EmitAssign, Emit): handle
22485 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22486 (ArrayAccess.EmitStoreOpcode): ditto.
22488 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22490 * expression.cs (MakeByteBlob): Complete all the missing types
22491 (uint, short, ushort, byte, sbyte)
22493 * class.cs: Only init instance field initializers on instance
22496 Rename `constructors' to instance_constructors.
22498 (TypeContainer.AddConstructor): Only add constructors to the list
22499 if it is not static.
22501 Make sure that we handle default_static_constructor independently
22502 everywhere where we handle instance_constructors
22504 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22506 * class.cs: Do not lookup or create a base initializer for a
22507 static constructor.
22509 (ConstructorInitializer.Resolve): use the proper type to lookup
22512 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22514 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22517 * decl.cs: CloseType is now an virtual method, the default
22518 implementation just closes this type.
22520 2001-12-28 Ravi Pratap <ravi@ximian.com>
22522 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22523 to PreserveSig by default. Also emit HideBySig on such methods.
22525 Basically, set the defaults to standard values.
22527 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22528 argument, if candidate is better, it can't be worse than the best !
22530 (Invocation): Re-write bits to differentiate between methods being
22531 applicable in their expanded form and their normal form - for params
22534 Get rid of use_standard everywhere as only standard conversions are allowed
22535 in overload resolution.
22537 More spec conformance.
22539 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22541 * driver.cs: Add --timestamp, to see where the compiler spends
22544 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22545 `this' in static code.
22547 (SimpleName.DoResolve): Implement in terms of a helper function
22548 that allows static-references to be passed upstream to
22551 (Expression.ResolveWithSimpleName): Resolve specially simple
22552 names when called by MemberAccess to implement the special
22555 (Expression.ImplicitReferenceConversion): Handle conversions from
22556 Null to reference types before others, as Null's type is
22559 * expression.cs (Invocation.EmitCall): Handle the special case of
22560 calling methods declared on a reference type from a ValueType
22561 (Base classes System.Object and System.Enum)
22563 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22564 the left hand side is a TypeExpr, not on every enumeration.
22566 (Binary.Resolve): If types are reference types, then do a cast to
22567 object on operators != and == of both arguments.
22569 * typemanager.cs (FindMembers): Extract instance and static
22570 members if requested.
22572 * interface.cs (PopulateProperty): Use void_type instead of null
22573 as the return type for the setter method.
22575 (PopulateIndexer): ditto.
22577 2001-12-27 Ravi Pratap <ravi@ximian.com>
22579 * support.cs (ReflectionParameters): Fix minor bug where we
22580 were examining the wrong parameter for the ParamArray attribute.
22582 Cope with requests for the type of the parameter at position
22583 greater than the params parameter's. We now return the element
22584 type of the params array as that makes more sense.
22586 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22587 accordingly as we no longer have to extract the element type
22590 (Invocation.OverloadResolve): Update.
22592 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22594 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22595 against IEnumerator, test whether the return value is a descendant
22596 of the IEnumerator interface.
22598 * class.cs (Indexer.Define): Use an auxiliary method to implement
22599 the other bits of the method definition. Begin support for
22600 explicit interface implementation.
22602 (Property.DefineMethod): Use TypeManager.void_type instead of null
22603 for an empty return value.
22605 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22607 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22608 dealing with a FieldExpr which is composed of a FieldBuilder, in
22609 the code path we did extract the constant, but we should have
22610 obtained the underlying value to be able to cast it (otherwise we
22611 end up in an infinite loop, this is what Ravi was running into).
22613 (ArrayCreation.UpdateIndices): Arrays might be empty.
22615 (MemberAccess.ResolveMemberAccess): Add support for section
22616 14.5.4.1 that deals with the special case of E.I when E is a type
22617 and something else, that I can be a reference to a static member.
22619 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22620 handle a particular array type to create byte blobs, it is just
22621 something we dont generate byteblobs for.
22623 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22626 * location.cs (Push): remove the key from the hashtable that we
22627 are about to add. This happens for empty files.
22629 * driver.cs: Dispose files after we have parsed them.
22631 (tokenize): new function that only runs the tokenizer on its
22632 input, for speed testing.
22634 2001-12-26 Ravi Pratap <ravi@ximian.com>
22636 * class.cs (Event.Define): Define the private field only if there
22637 are no accessors defined.
22639 * expression.cs (ResolveMemberAccess): If there is no associated
22640 field with the event, that means we have an event defined with its
22641 own accessors and we should flag error cs0070 since transforming
22642 ourselves into a field is not valid in that case.
22644 * ecore.cs (SimpleName.DoResolve): Same as above.
22646 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22647 and charset to sane values.
22649 2001-12-25 Ravi Pratap <ravi@ximian.com>
22651 * assign.cs (DoResolve): Perform check on events only if they
22652 are being accessed outside the declaring type.
22654 * cs-parser.jay (event_declarations): Update rules to correctly
22655 set the type of the implicit parameter etc.
22657 (add_accessor, remove_accessor): Set current local parameters.
22659 * expression.cs (Binary): For delegate addition and subtraction,
22660 cast the return value from the method into the appropriate delegate
22663 2001-12-24 Ravi Pratap <ravi@ximian.com>
22665 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22666 of these as the workaround is unnecessary.
22668 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22669 delegate data - none of that is needed at all.
22671 Re-write bits to extract the instance expression and the delegate method
22674 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22677 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22678 of attaching attributes instead of duplicating code everywhere.
22680 * everywhere : Update code to do attribute emission using the above method.
22682 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22684 * expression.cs (IsParamsMethodApplicable): if there are not
22685 parameters, return immediately.
22687 * ecore.cs: The 0 literal can be implicity converted to an enum
22690 (SimpleName.DoResolve): First lookup the type, then lookup the
22693 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22694 want to get its address. If the InstanceExpression is not
22695 addressable, store the result in a temporary variable, then get
22698 * codegen.cs: Only display 219 errors on warning level or above.
22700 * expression.cs (ArrayAccess): Make it implement the
22701 IMemoryLocation interface.
22703 (Binary.DoResolve): handle the operator == (object a, object b)
22704 and operator != (object a, object b) without incurring into a
22705 BoxedCast (because 5 != o should never be performed).
22707 Handle binary enumerator operators.
22709 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22710 value type, otherwise use Ldelem_ref.
22712 Use precomputed names;
22714 (AddressOf): Implement address of
22716 * cs-parser.jay (labeled_statement): Fix recursive block
22717 addition by reworking the production.
22719 * expression.cs (New.DoEmit): New has a special case:
22721 If we are dealing with a ValueType, we have a few
22722 situations to deal with:
22724 * The target of New is a ValueType variable, that is
22725 easy, we just pass this as the variable reference
22727 * The target of New is being passed as an argument,
22728 to a boxing operation or a function that takes a
22731 In this case, we need to create a temporary variable
22732 that is the argument of New.
22735 2001-12-23 Ravi Pratap <ravi@ximian.com>
22737 * rootcontext.cs (LookupType): Check that current_type is not null before
22738 going about looking at nested types.
22740 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22741 not implement the IAssignMethod interface any more.
22743 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22744 where we tranform them into FieldExprs if they are being resolved from within
22745 the declaring type.
22747 * ecore.cs (SimpleName.DoResolve): Do the same here.
22749 * assign.cs (DoResolve, Emit): Clean up code considerably.
22751 * ../errors/bug10.cs : Add.
22753 * ../errors/cs0070.cs : Add.
22755 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22757 * assign.cs : Get rid of EventIsLocal everywhere.
22759 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22761 * ecore.cs (ConvertIntLiteral): finished the implementation.
22763 * statement.cs (SwitchLabel): Convert the value we are using as a
22764 key before looking up the table.
22766 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22768 * codegen.cs (EmitTopBlock): Require a Location argument now.
22770 * cs-parser.jay (constructor_declarator): We need to setup
22771 current_local_parameters before we parse the
22772 opt_constructor_initializer, to allow the variables to be bound
22773 to the constructor arguments.
22775 * rootcontext.cs (LookupType): First lookup nested classes in our
22776 class and our parents before we go looking outside our class.
22778 * expression.cs (ConstantFold): Extract/debox the values at the
22781 * rootcontext.cs (EmitCode): Resolve the constants first before we
22782 resolve the types. This is not really needed, but it helps debugging.
22784 * statement.cs: report location.
22786 * cs-parser.jay: pass location to throw statement.
22788 * driver.cs: Small bug fix.
22790 * report.cs: Updated format to be 4-zero filled digits.
22792 2001-12-22 Ravi Pratap <ravi@ximian.com>
22794 * expression.cs (CheckIndices): Fix minor bug where the wrong
22795 variable was being referred to ;-)
22797 (DoEmit): Do not call EmitStaticInitializers when the
22798 underlying type is System.Object.
22800 2001-12-21 Ravi Pratap <ravi@ximian.com>
22802 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22803 and do the usual workaround for SRE.
22805 * class.cs (MyEventBuilder.EventType): New member to get at the type
22806 of the event, quickly.
22808 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22810 * assign.cs (Assign.DoResolve): Handle the case when the target
22811 is an EventExpr and perform the necessary checks.
22813 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22816 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22818 (EventExpr): Set the type in the constructor itself since we
22819 are meant to be born fully resolved.
22821 (EventExpr.Define): Revert code I wrote earlier.
22823 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22824 instance expression is null. The instance expression is a This in that case
22825 or a null, depending on whether it is a static method or not.
22827 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22828 refers to more than one method.
22830 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22831 and accordingly flag errors.
22833 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22835 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22837 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22839 * location.cs (ToString): Provide useful rutine.
22841 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22843 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22844 objects, return the actual integral boxed.
22846 * statement.cs (SwitchLabel): define an ILLabel for each
22849 (Switch.CheckSwitch): If the value is a Literal, extract
22850 the underlying literal.
22852 Also in the unused hashtable we had, add the SwitchLabel so we can
22853 quickly look this value up.
22855 * constant.cs: Implement a bunch of new constants. Rewrite
22856 Literal based on this. Made changes everywhere to adapt to this.
22858 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22859 dereferencing array only once, and also copes with enumrations.
22861 bytes are two bytes wide, not one.
22863 (Cast): Perform constant conversions.
22865 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22866 wrappers to the literals here.
22868 * expression.cs (DoNumericPromotions): long literals can converted
22869 to ulong implicity (this is taken care of elsewhere, but I was
22870 missing this spot).
22872 * ecore.cs (Expression.Literalize): Make the return type Literal,
22873 to improve type checking.
22875 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
22877 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22879 * literal.cs: Revert code from ravi that checked the bounds. The
22880 bounds are sane by the definition of the type itself.
22882 * typemanager.cs: Fix implementation of ImplementsInterface. We
22883 need to actually look up in our parent hierarchy for interfaces
22886 * const.cs: Use the underlying type for enumerations
22888 * delegate.cs: Compute the basename for the delegate creation,
22889 that should fix the delegate test case, and restore the correct
22890 Type Lookup semantics in rootcontext
22892 * rootcontext.cs: Revert Ravi's last patch. The correct way of
22893 referencing a nested type with the Reflection API is using the "+"
22896 * cs-parser.jay: Do not require EOF token at the end.
22898 2001-12-20 Ravi Pratap <ravi@ximian.com>
22900 * rootcontext.cs (LookupType): Concatenate type names with
22901 a '.' instead of a '+' The test suite passes again.
22903 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
22904 field of the enumeration.
22906 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
22907 the case when the member is an EventExpr.
22909 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
22910 static has an associated instance expression.
22912 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
22914 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
22916 * class.cs (Event.Define): Register event and perform appropriate checks
22919 We define the Add and Remove methods even if the use provides none because
22920 in that case, we provide default implementations ourselves.
22922 Define a private field of the type of the event. This is done by the CSC compiler
22923 and we should be doing it too ;-)
22925 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
22926 More methods we use in code we generate.
22928 (multicast_delegate_type, delegate_type): Two separate types since the distinction
22931 (InitCoreTypes): Update accordingly for the above.
22933 * class.cs (Event.Emit): Generate code for default accessors that we provide
22935 (EmitDefaultMethod): Do the job in the above.
22937 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
22940 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22942 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
22943 builders even if we were missing one.
22945 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
22946 pass the Basename as our class name instead of the Name. The
22947 basename will be correctly composed for us.
22949 * parameter.cs (Paramters): Now takes a Location argument.
22951 * decl.cs (DeclSpace.LookupType): Removed convenience function and
22952 make all the code call directly LookupType in RootContext and take
22953 this chance to pass the Location information everywhere.
22955 * Everywhere: pass Location information.
22957 2001-12-19 Miguel de Icaza <miguel@ximian.com>
22959 * class.cs (Constructor.Define): Updated way of detecting the
22960 length of the parameters.
22962 (TypeContainer.DefineType): Use basename as the type name for
22965 (TypeContainer.Define): Do not recursively define types here, as
22966 definition is taken care in order by the RootContext.
22968 * tree.cs: Keep track of namespaces in a per-file basis.
22970 * parameter.cs (Parameter.ComputeSignature): Update to use
22973 (Parameters.GetSignature): ditto.
22975 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
22976 instead of a TypeContainer.
22978 (Interface.SemanticAnalysis): Use `this' instead of our parent to
22979 resolve names. Because we need to be resolve in our context, not
22982 * driver.cs: Implement response files.
22984 * class.cs (TypeContainer.DefineType): If we are defined, do not
22985 redefine ourselves.
22987 (Event.Emit): Emit the code for add/remove handlers.
22988 (Event.Define): Save the MethodBuilders for add/remove.
22990 * typemanager.cs: Use pair here too.
22992 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
22993 DictionaryEntry requires the first argument to be non-null.
22995 (enum_declaration): Compute full name for registering the
22998 (delegate_declaration): Instead of using
22999 formal_parameter_list, use opt_formal_parameter_list as the list
23002 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
23003 (EventParsing): New property that controls whether `add' and
23004 `remove' are returned as tokens or identifiers (for events);
23006 2001-12-19 Ravi Pratap <ravi@ximian.com>
23008 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
23009 use MyEventBuilder only and let it wrap the real builder for us.
23011 (MyEventBuilder): Revamp constructor etc.
23013 Implement all operations that we perform on EventBuilder in precisely the same
23016 (FindMembers): Update to use the EventBuilder member.
23018 (Event.Emit): Update accordingly.
23020 2001-12-18 Ravi Pratap <ravi@ximian.com>
23022 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
23023 by calling the appropriate methods.
23025 (GetCustomAttributes): Make stubs as they cannot possibly do anything
23028 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
23030 2001-12-17 Ravi Pratap <ravi@ximian.com>
23032 * delegate.cs (Delegate.Populate): Check that the return type
23033 and various parameters types are indeed accessible.
23035 * class.cs (Constructor.Define): Same here.
23037 (Field.Define): Ditto.
23039 (Event.Define): Ditto.
23041 (Operator.Define): Check that the underlying Method defined itself
23042 correctly - so it's MethodBuilder should not be null.
23044 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
23045 expression happens to be null.
23047 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
23048 members but as of now we don't seem to be able to do anything really useful with it.
23050 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
23051 not the EventBuilder.
23053 2001-12-18 Miguel de Icaza <miguel@ximian.com>
23055 * cs-tokenizer.cs: Add support for defines.
23056 Add support for #if, #elif, #else, #endif
23058 (eval_var): evaluates a variable.
23059 (eval): stubbed for evaluating functions.
23061 * cs-parser.jay: Pass the defines information
23063 * driver.cs: Add --define command line option.
23065 * decl.cs: Move MemberCore here.
23067 Make it the base class for DeclSpace. This allows us to catch and
23068 report 108 and 109 for everything now.
23070 * class.cs (TypeContainer.Define): Extract all the members
23071 before populating and emit the warning 108 (new keyword required
23072 to override) instead of having each member implement this.
23074 (MemberCore.Define): New abstract method, we will be using this in
23075 the warning reporting engine in Populate.
23077 (Operator.Define): Adjust to new MemberCore protocol.
23079 * const.cs (Const): This does not derive from Expression, it is a
23080 temporary object we use to create fields, it is a MemberCore.
23082 * class.cs (Method.Define): Allow the entry point to be in a
23085 * driver.cs: Rewrite the argument handler to clean it up a bit.
23087 * rootcontext.cs: Made it just an auxiliary namespace feature by
23088 making everything static.
23090 * driver.cs: Adapt code to use RootContext type name instead of
23093 * delegate.cs: Remove RootContext argument.
23095 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
23098 * class.cs (Event.Define): The lookup can fail.
23100 * cs-tokenizer.cs: Begin implementation of pre-procesor.
23102 * expression.cs: Resolve the this instance before invoking the code.
23104 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23106 * cs-parser.jay: Add a production in element_access that allows
23107 the thing to become a "type" reference. This way we can parse
23108 things like "(string [])" as a type.
23110 Note that this still does not handle the more complex rules of
23114 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
23116 * ecore.cs: (CopyNewMethods): new utility function used to
23117 assemble the list of methods from running FindMembers.
23119 (MemberLookup): Rework FindMembers so that
23121 2001-12-16 Miguel de Icaza <miguel@ximian.com>
23123 * class.cs (TypeContainer): Remove Delegates who fail to be
23126 * delegate.cs (Populate): Verify that we dont get null return
23127 values. TODO: Check for AsAccessible.
23129 * cs-parser.jay: Use basename to emit error 574 (destructor should
23130 have the same name as container class), not the full name.
23132 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
23133 possible representation.
23135 Also implements integer type suffixes U and L.
23137 2001-12-15 Miguel de Icaza <miguel@ximian.com>
23139 * expression.cs (ArrayCreation.DoResolve): We need to do the
23140 argument resolution *always*.
23142 * decl.cs: Make this hold the namespace. Hold the root context as
23144 (LookupType): Move here.
23146 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
23148 * location.cs (Row, Name): Fixed the code, it was always returning
23149 references to the first file.
23151 * interface.cs: Register properties defined through interfaces.
23153 * driver.cs: Add support for globbing on the command line
23155 * class.cs (Field): Make it derive from MemberCore as well.
23158 2001-12-15 Ravi Pratap <ravi@ximian.com>
23160 * class.cs (Event::Define): Check that the type of the event is a delegate
23161 type else flag error #66.
23163 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
23166 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
23167 values of EntryPoint, CharSet etc etc.
23169 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
23171 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
23172 be null and we should ignore this. I am not sure if this is really clean. Apparently,
23173 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
23174 which needs this to do its work.
23176 * ../errors/cs0066.cs : Add.
23178 2001-12-14 Miguel de Icaza <miguel@ximian.com>
23180 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
23183 * class.cs: (MethodSignature.MethodSignature): Removed hack that
23184 clears out the parameters field.
23185 (MemberSignatureCompare): Cleanup
23187 (MemberCore): New base class used to share code between MethodCore
23190 (RegisterRequiredImplementations) BindingFlags.Public requires
23191 either BindingFlags.Instace or Static. Use instance here.
23193 (Property): Refactored code to cope better with the full spec.
23195 * parameter.cs (GetParameterInfo): Return an empty array instead
23198 * class.cs (Property): Abstract or extern properties have no bodies.
23200 * parameter.cs (GetParameterInfo): return a zero-sized array.
23202 * class.cs (TypeContainer.MethodModifiersValid): Move all the
23203 method modifier validation to the typecontainer so we can reuse
23204 this on properties.
23206 (MethodCore.ParameterTypes): return an empty sized array of types.
23208 (Property.Define): Test property modifier validity.
23210 Add tests for sealed/override too.
23212 (Method.Emit): abstract or extern methods have no bodies.
23214 2001-12-14 Ravi Pratap <ravi@ximian.com>
23216 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
23219 (Method::Define, ::Emit): Modify accordingly.
23221 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
23223 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
23225 * makefile: Pass in /unsafe.
23227 2001-12-13 Miguel de Icaza <miguel@ximian.com>
23229 * class.cs (MakeKey): Kill routine.
23231 * class.cs (TypeContainer.Define): Correctly define explicit
23232 method implementations (they require the full interface name plus
23235 * typemanager.cs: Deply the PtrHashtable here and stop using the
23236 lame keys. Things work so much better.
23238 This of course broke everyone who depended on `RegisterMethod' to
23239 do the `test for existance' test. This has to be done elsewhere.
23241 * support.cs (PtrHashtable): A hashtable that avoid comparing with
23242 the object stupid Equals method (because, that like fails all over
23243 the place). We still do not use it.
23245 * class.cs (TypeContainer.SetRequiredInterface,
23246 TypeContainer.RequireMethods): Killed these two routines and moved
23247 all the functionality to RegisterRequiredImplementations.
23249 (TypeContainer.RegisterRequiredImplementations): This routine now
23250 registers all the implementations required in an array for the
23251 interfaces and abstract methods. We use an array of structures
23252 which can be computed ahead of time to reduce memory usage and we
23253 also assume that lookups are cheap as most classes will not
23254 implement too many interfaces.
23256 We also avoid creating too many MethodSignatures.
23258 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23259 clear the "pending" bit if we find that there are problems with
23262 (TypeContainer.VerifyPendingMethods): Update to report errors of
23263 methods that look like implementations but are not.
23265 (TypeContainer.Define): Add support for explicit interface method
23268 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23270 * typemanager.cs: Keep track of the parameters here instead of
23271 being a feature of the TypeContainer.
23273 * class.cs: Drop the registration of parameters here, as
23274 InterfaceMethods are also interface declarations.
23276 * delegate.cs: Register methods with the TypeManager not only with
23277 the TypeContainer. This code was buggy.
23279 * interface.cs: Full registation here.
23281 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23283 * expression.cs: Remove reducer for binary expressions, it can not
23286 * const.cs: Put here the code that used to go into constant.cs
23288 * constant.cs: Put here the code for constants, this is a new base
23289 class for Literals.
23291 * literal.cs: Make Literal derive from Constant.
23293 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23295 * statement.cs (Return.Emit): Report error 157 if the user
23296 attempts to return from a finally block.
23298 (Return.Emit): Instead of emitting a return, jump to the end of
23301 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23302 LocalBuilder to store the result of the function. ReturnLabel is
23303 the target where we jump.
23306 2001-12-09 Radek Doulik <rodo@ximian.com>
23308 * cs-parser.jay: remember alias in current namespace
23310 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23313 * class.cs (LookupAlias): lookup alias in my_namespace
23315 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23317 (LookupAlias): lookup alias in this and if needed in parent
23320 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23324 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23325 making things static. I need this to avoid passing the
23326 TypeContainer when calling ParameterType.
23328 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23329 that did string manipulation to compute the type and then call
23330 GetType. Use Parameter.ParameterType instead.
23332 * cs-tokenizer.cs: Consume the suffix for floating values.
23334 * expression.cs (ParameterReference): figure out whether this is a
23335 reference parameter or not. Kill an extra variable by computing
23336 the arg_idx during emission.
23338 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23339 function that returns whether a parameter is an out/ref value or not.
23341 (Parameter.ParameterType): The type of the parameter (base,
23342 without ref/out applied).
23344 (Parameter.Resolve): Perform resolution here.
23345 (Parameter.ExternalType): The full type (with ref/out applied).
23347 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23348 support for expressions on the using statement.
23350 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23352 * statement.cs (Using.EmitLocalVariableDecls): Split the
23353 localvariable handling of the using statement.
23355 (Block.EmitMeta): Keep track of variable count across blocks. We
23356 were reusing slots on separate branches of blocks.
23358 (Try.Emit): Emit the general code block, we were not emitting it.
23360 Check the type of the declaration to be an IDisposable or
23361 something that can be implicity converted to it.
23363 Emit conversions if required.
23365 * ecore.cs (EmptyExpression): New utility class.
23366 (Expression.ImplicitConversionExists): New utility function.
23368 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23370 * statement.cs (Using): Implement.
23372 * expression.cs (LocalVariableReference): Support read only variables.
23374 * statement.cs: Remove the explicit emit for the Leave opcode.
23375 (VariableInfo): Add a readonly field.
23377 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23379 * ecore.cs (ConvCast): new class used to encapsulate the various
23380 explicit integer conversions that works in both checked and
23381 unchecked contexts.
23383 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23384 properly generate the overflow opcodes.
23386 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23388 * statement.cs: The correct type for the EmptyExpression is the
23389 element_type, not the variable type. Ravi pointed this out.
23391 2001-12-04 Ravi Pratap <ravi@ximian.com>
23393 * class.cs (Method::Define): Handle PInvoke methods specially
23394 by using DefinePInvokeMethod instead of the usual one.
23396 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23397 above to do the task of extracting information and defining the method.
23399 2001-12-04 Ravi Pratap <ravi@ximian.com>
23401 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23402 of the condition for string type.
23404 (Emit): Move that here.
23406 (ArrayCreation::CheckIndices): Keep string literals in their expression
23409 (EmitDynamicInitializers): Handle strings appropriately.
23411 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23413 * codegen.cs (EmitContext): Replace multiple variables with a
23414 single pointer to the current Switch statement.
23416 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23419 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23423 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23426 (Foreach.Emit): Foreach on arrays was not setting
23427 up the loop variables (for break/continue).
23429 (GotoCase): Semi-implented.
23431 2001-12-03 Ravi Pratap <ravi@ximian.com>
23433 * attribute.cs (CheckAttribute): Handle system attributes by using
23434 Attribute.GetAttributes to examine information we need.
23436 (GetValidPlaces): Same here.
23438 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23440 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23442 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23444 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23446 (Method::Emit): Handle the case when we are a PInvoke method.
23448 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23450 * expression.cs: Use ResolveWithSimpleName on compound names.
23452 2001-12-02 Ravi Pratap <ravi@ximian.com>
23454 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23455 before trying to reduce it.
23457 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23459 * constant.cs (LookupConstantValue): Implement.
23461 (EmitConstant): Use the above in emitting the constant.
23463 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23464 that are user-defined by doing a LookupConstantValue on them.
23466 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23469 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23471 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23473 (BaseAccess.DoResolve): Implement.
23475 (MemberAccess.DoResolve): Split this routine into a
23476 ResolveMemberAccess routine that can be used independently
23478 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23480 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23481 As that share bits of the implementation. Is returns a boolean,
23482 while As returns the Type that is being probed.
23484 2001-12-01 Ravi Pratap <ravi@ximian.com>
23486 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23487 instead of a Literal - much easier.
23489 (EnumInTransit): Remove - utterly useless :-)
23491 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23493 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23495 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23496 chain when we have no associated expression.
23498 2001-11-30 Ravi Pratap <ravi@ximian.com>
23500 * constant.cs (Define): Use Location while reporting the errror.
23502 Also emit a warning when 'new' is used and there is no inherited
23505 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23508 (LookupEnumValue): Implement to lookup an enum member's value and define it
23511 (Populate): Re-write accordingly to use the above routine.
23513 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23515 * expression.cs (This): Fix prototype for DoResolveLValue to
23516 override the base class DoResolveLValue.
23518 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23521 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23522 (we need to load the address of the field here). This fixes
23525 (FieldExpr.DoResolveLValue): Call the DoResolve
23526 function to initialize the Instance expression.
23528 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23529 correctly the GetEnumerator operation on a value type.
23531 * cs-parser.jay: Add more simple parsing error catches.
23533 * statement.cs (Switch): Add support for string switches.
23534 Handle null specially.
23536 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23538 2001-11-28 Ravi Pratap <ravi@ximian.com>
23540 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23542 (declare_local_constant): New helper function.
23544 * statement.cs (AddConstant): Keep a separate record of constants
23546 (IsConstant): Implement to determine if a variable is a constant.
23548 (GetConstantExpression): Implement.
23550 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23552 * statement.cs (IsVariableDefined): Re-write.
23554 2001-11-27 Ravi Pratap <ravi@ximian.com>
23556 * class.cs (TypeContainer::FindMembers): Look for constants
23557 in the case when we are looking for MemberTypes.Field
23559 * expression.cs (MemberAccess::DoResolve): Check that in the
23560 case we are a FieldExpr and a Literal, we are not being accessed
23561 by an instance reference.
23563 * cs-parser.jay (local_constant_declaration): Implement.
23565 (declaration_statement): Implement for constant declarations.
23567 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23569 * statement.cs (Switch): Catch double defaults.
23571 (Switch): More work on the switch() statement
23572 implementation. It works for integral values now, need to finish
23576 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23578 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23579 integer literals into other integer literals. To be used by
23582 2001-11-24 Ravi Pratap <ravi@ximian.com>
23584 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23587 (EmitDynamicInitializers): Cope with the above since we extract data
23588 directly from ArrayData now.
23590 (ExpectInitializers): Keep track of whether initializers are mandatory
23593 (Bounds): Make it a hashtable to prevent the same dimension being
23594 recorded for every element in that dimension.
23596 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23599 Also fix bug which was causing the indices to be emitted in the reverse
23602 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23604 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23605 unfinished. They do not work, because the underlying code is
23608 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23610 * cs-parser.jay: Remove bogus fixme.
23612 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23613 on Switch statement.
23615 2001-11-23 Ravi Pratap <ravi@ximian.com>
23617 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23620 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23621 parameter. Apparently, any expression is allowed.
23623 (ValidateInitializers): Update accordingly.
23625 (CheckIndices): Fix some tricky bugs thanks to recursion.
23627 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23628 I was being completely brain-dead.
23630 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23631 and re-write acordingly.
23633 (DelegateInvocation): Re-write accordingly.
23635 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23637 (MakeByteBlob): Handle types more correctly.
23639 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23640 initialization from expressions but it is incomplete because I am a complete
23643 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23645 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23646 on If. Basically, we have to return `true' (ie, we do return to
23647 our caller) only if both branches of the if return.
23649 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23650 short-circuit operators, handle them as short circuit operators.
23652 (Cast.DoResolve): Resolve type.
23653 (Cast.Cast): Take an expression as the target type.
23655 * cs-parser.jay (cast_expression): Remove old hack that only
23656 allowed a limited set of types to be handled. Now we take a
23657 unary_expression and we resolve to a type during semantic
23660 Use the grammar productions from Rhys to handle casts (this is
23661 not complete like Rhys syntax yet, we fail to handle that corner
23662 case that C# has regarding (-x), but we will get there.
23664 2001-11-22 Ravi Pratap <ravi@ximian.com>
23666 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23667 field which is an array type.
23669 * cs-parser.jay (declare_local_variables): Support array initialization too.
23671 * typemanager.cs (MakeKey): Implement.
23673 (everywhere): Use the above appropriately.
23675 * cs-parser.jay (for_statement): Update for array initialization while
23676 declaring variables.
23678 * ecore.cs : The error message was correct, it's the variable's names that
23679 were misleading ;-) Make the code more readable.
23681 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23682 the correct type etc.
23684 (ConvertExplicit): Handle Enum types by examining the underlying type.
23686 2001-11-21 Ravi Pratap <ravi@ximian.com>
23688 * parameter.cs (GetCallingConvention): Always return
23689 CallingConventions.Standard for now.
23691 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23693 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23694 and `r' after calling DoNumericPromotions.
23696 * ecore.cs: Fix error message (the types were in the wrong order).
23698 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23699 BindingFlags.Instance as well
23701 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23702 implicit int literal conversion in an empty cast so that we
23703 propagate the right type upstream.
23705 (UnboxCast): new class used to unbox value types.
23706 (Expression.ConvertExplicit): Add explicit type conversions done
23709 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23710 the target type before applying the implicit LongLiterals to ULong
23713 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23715 * cs-parser.jay (for_statement): Reworked the way For works: now
23716 we declare manually any variables that are introduced in
23717 for_initializer to solve the problem of having out-of-band code
23718 emition (that is what got for broken).
23720 (declaration_statement): Perform the actual variable declaration
23721 that used to be done in local_variable_declaration here.
23723 (local_variable_declaration): Do not declare anything, just pass
23724 the information on a DictionaryEntry
23726 2001-11-20 Ravi Pratap <ravi@ximian.com>
23728 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23729 re-write of the logic to now make it recursive.
23731 (UpdateIndices): Re-write accordingly.
23733 Store element data in a separate ArrayData list in the above methods.
23735 (MakeByteBlob): Implement to dump the array data into a byte array.
23737 2001-11-19 Ravi Pratap <ravi@ximian.com>
23739 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23742 * constant.cs (Define): Implement.
23744 (EmitConstant): Re-write fully.
23746 Pass in location info.
23748 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23751 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23752 DictionaryEntry since we need location info too.
23754 (constant_declaration): Update accordingly.
23756 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23757 code into another method : UpdateIndices.
23759 2001-11-18 Ravi Pratap <ravi@ximian.com>
23761 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23762 some type checking etc.
23764 2001-11-17 Ravi Pratap <ravi@ximian.com>
23766 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23767 bits to provide dimension info if the user skips doing that.
23769 Update second constructor to store the rank correctly.
23771 2001-11-16 Ravi Pratap <ravi@ximian.com>
23773 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23774 and try to implement.
23776 * ../errors/cs0150.cs : Add.
23778 * ../errors/cs0178.cs : Add.
23780 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23782 * statement.cs: Implement foreach on multi-dimensional arrays.
23784 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23785 name of the params argument.
23787 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23788 initializing the array.
23790 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23791 we can use this elsewhere.
23793 * statement.cs: Finish implementation of foreach for single
23796 * cs-parser.jay: Use an out-of-band stack to pass information
23797 around, I wonder why I need this.
23799 foreach_block: Make the new foreach_block the current_block.
23801 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23802 function used to return a static Parameters structure. Used for
23803 empty parameters, as those are created very frequently.
23805 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23807 2001-11-15 Ravi Pratap <ravi@ximian.com>
23809 * interface.cs : Default modifier is private, not public. The
23810 make verify test passes again.
23812 2001-11-15 Ravi Pratap <ravi@ximian.com>
23814 * support.cs (ReflectionParameters): Fix logic to determine
23815 whether the last parameter is a params one. Test 9 passes again.
23817 * delegate.cs (Populate): Register the builders we define with
23818 RegisterParameterForBuilder. Test 19 passes again.
23820 * cs-parser.jay (property_declaration): Reference $6 instead
23821 of $$ to get at the location.
23823 (indexer_declaration): Similar stuff.
23825 (attribute): Ditto.
23827 * class.cs (Property): Register parameters for the Get and Set methods
23828 if they exist. Test 23 passes again.
23830 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23831 call to EmitArguments as we are sure there aren't any params arguments.
23832 Test 32 passes again.
23834 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23835 IndexOutOfRangeException.
23837 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23838 Test 33 now passes again.
23840 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23842 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23843 broke a bunch of things. Will have to come up with a better way
23844 of tracking locations.
23846 * statement.cs: Implemented foreach for single dimension arrays.
23848 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23850 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23851 an error. This removes the lookup from the critical path.
23853 * cs-parser.jay: Removed use of temporary_loc, which is completely
23856 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23858 * support.cs (ReflectionParameters.ParameterModifier): Report
23859 whether the argument is a PARAMS argument or not.
23861 * class.cs: Set the attribute `ParamArrayAttribute' on the
23862 parameter argument.
23864 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23865 and cons_param_array_attribute (ConstructorInfo for
23866 ParamArrayAttribute).,
23868 * codegen.cs: Emit the return using the `Return' statement, that
23869 way we can report the error correctly for missing return values.
23871 * class.cs (Method.Emit): Clean up.
23873 * expression.cs (Argument.Resolve): Take another argument: the
23874 location where this argument is used. Notice that this is not
23875 part of the "Argument" class as to reduce the size of the
23876 structure (we know the approximate location anyways).
23878 Test if the argument is a variable-reference, if not, then
23879 complain with a 206.
23881 (Argument.Emit): Emit addresses of variables.
23883 (Argument.FullDesc): Simplify.
23885 (Invocation.DoResolve): Update for Argument.Resolve.
23887 (ElementAccess.DoResolve): ditto.
23889 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
23890 method should be virtual, as this method is always virtual.
23892 (NewDelegate.DoResolve): Update for Argument.Resolve.
23894 * class.cs (ConstructorInitializer.DoResolve): ditto.
23896 * attribute.cs (Attribute.Resolve): ditto.
23898 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23900 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
23902 * expression.cs (ParameterReference): Drop IStackStorage and implement
23903 IAssignMethod instead.
23905 (LocalVariableReference): ditto.
23907 * ecore.cs (FieldExpr): Drop IStackStorage and implement
23908 IAssignMethod instead.
23910 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23912 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
23913 enumerations that are used in heavily used structures derive from
23914 byte in a laughable and pathetic attempt to reduce memory usage.
23915 This is the kind of pre-optimzations that you should not do at
23916 home without adult supervision.
23918 * expression.cs (UnaryMutator): New class, used to handle ++ and
23919 -- separatedly from the other unary operators. Cleans up the
23920 code, and kills the ExpressionStatement dependency in Unary.
23922 (Unary): Removed `method' and `Arguments' from this class, making
23923 it smaller, and moving it all to SimpleCall, so I can reuse this
23924 code in other locations and avoid creating a lot of transient data
23925 strucutres when not required.
23927 * cs-parser.jay: Adjust for new changes.
23929 2001-11-11 Miguel de Icaza <miguel@ximian.com>
23931 * enum.cs (Enum.Populate): If there is a failure during
23934 * cs-parser.jay (opt_enum_base): we used to catch type errors
23935 here, but this is really incorrect. The type error should be
23936 catched during semantic analysis.
23938 2001-12-11 Ravi Pratap <ravi@ximian.com>
23940 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
23941 current_local_parameters as expected since I, in my stupidity, had forgotten
23944 * attribute.cs (GetValidPlaces): Fix stupid bug.
23946 * class.cs (Method::Emit): Perform check on applicability of attributes.
23948 (Constructor::Emit): Ditto.
23950 (Field::Emit): Ditto.
23952 (Field.Location): Store location information.
23954 (Property, Event, Indexer, Operator): Ditto.
23956 * cs-parser.jay (field_declaration): Pass in location for each field.
23958 * ../errors/cs0592.cs : Add.
23960 2001-11-12 Ravi Pratap <ravi@ximian.com>
23962 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
23964 (InitCoreTypes): Update accordingly.
23966 (RegisterAttrType, LookupAttr): Implement.
23968 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
23969 info about the same.
23971 (Resolve): Update to populate the above as necessary.
23973 (Error592): Helper.
23975 (GetValidPlaces): Helper to the above.
23977 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
23979 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
23981 2001-11-12 Ravi Pratap <ravi@ximian.com>
23983 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
23985 * ../errors/cs0617.cs : Add.
23987 2001-11-11 Ravi Pratap <ravi@ximian.com>
23989 * enum.cs (Emit): Rename to Populate to be more consistent with what
23990 we expect it to do and when exactly it is called.
23992 * class.cs, rootcontext.cs : Update accordingly.
23994 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
23995 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
23997 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
23999 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24000 of a fieldinfo using the above, when dealing with a FieldBuilder.
24002 2001-11-10 Ravi Pratap <ravi@ximian.com>
24004 * ../errors/cs0031.cs : Add.
24006 * ../errors/cs1008.cs : Add.
24008 * ../errrors/cs0543.cs : Add.
24010 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
24013 (FindMembers): Implement.
24015 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
24016 enums and delegates too.
24018 (enum_types): Rename to builder_to_enum.
24020 (delegate_types): Rename to builder_to_delegate.
24022 * delegate.cs (FindMembers): Implement.
24024 2001-11-09 Ravi Pratap <ravi@ximian.com>
24026 * typemanager.cs (IsEnumType): Implement.
24028 * enum.cs (Emit): Re-write parts to account for the underlying type
24029 better and perform checking etc.
24031 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
24032 of the underlying type.
24034 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24037 * enum.cs (error31): Helper to report error #31.
24039 * cs-parser.jay (enum_declaration): Store location of each member too.
24041 * enum.cs (member_to_location): New hashtable.
24043 (AddEnumMember): Update location hashtable.
24045 (Emit): Use the location of each member while reporting errors.
24047 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24049 * cs-parser.jay: A for_initializer if is a
24050 local_variable_declaration really ammount to have an implicit
24051 block with the variable declaration and no initializer for for.
24053 * statement.cs (For.Emit): Cope with null initializers.
24055 This fixes the infinite loop on for initializers.
24057 2001-11-08 Miguel de Icaza <miguel@ximian.com>
24059 * enum.cs: More cleanup.
24061 * ecore.cs: Remove dead code.
24063 * class.cs (Property.Emit): More simplification.
24064 (Event.Emit): ditto.
24066 Reworked to have less levels of indentation.
24068 2001-11-08 Ravi Pratap <ravi@ximian.com>
24070 * class.cs (Property): Emit attributes.
24080 * enum.cs (Emit): Ditto.
24082 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
24085 * class.cs (Field, Event, etc.): Move attribute generation into the
24086 Emit method everywhere.
24088 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
24089 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
24090 as we had no way of defining nested enums !
24092 * rootcontext.cs : Adjust code accordingly.
24094 * typemanager.cs (AddEnumType): To keep track of enum types separately.
24096 2001-11-07 Ravi Pratap <ravi@ximian.com>
24098 * expression.cs (EvalConstantExpression): Move into ecore.cs
24100 * enum.cs (Enum): Rename some members and make them public and readonly
24101 according to our convention.
24103 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24106 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
24108 (Enum::Emit): Write a simple version for now which doesn't try to compute
24109 expressions. I shall modify this to be more robust in just a while.
24111 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
24113 (TypeContainer::CloseType): Create the Enum types too.
24115 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
24117 * expression.cs (EvalConstantExpression): Get rid of completely.
24119 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
24120 user-defined values and other cases.
24122 (IsValidEnumLiteral): Helper function.
24124 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
24125 out there in the case we had a literal FieldExpr.
24127 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
24129 (Literalize): Revamp a bit to take two arguments.
24131 (EnumLiteral): New class which derives from Literal to wrap enum literals.
24133 2001-11-06 Ravi Pratap <ravi@ximian.com>
24135 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
24137 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
24139 (Resolve): Use the above to ensure we have proper initializers.
24141 2001-11-05 Ravi Pratap <ravi@ximian.com>
24143 * expression.cs (Expression::EvalConstantExpression): New method to
24144 evaluate constant expressions.
24146 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
24148 2001-11-07 Miguel de Icaza <miguel@ximian.com>
24150 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
24153 (Binary.ResolveOperator): Handle operator != (object a, object b)
24154 and operator == (object a, object b);
24156 (Binary.DoNumericPromotions): Indicate whether the numeric
24157 promotion was possible.
24159 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
24162 Made the ArrayAccess implement interface IAssignMethod instead of
24163 IStackStore as the order in which arguments are passed reflects
24166 * assign.cs: Instead of using expr.ExprClass to select the way of
24167 assinging, probe for the IStackStore/IAssignMethod interfaces.
24169 * typemanager.cs: Load InitializeArray definition.
24171 * rootcontext.cs (RootContext.MakeStaticData): Used to define
24172 static data that can be used to initialize arrays.
24174 2001-11-05 Miguel de Icaza <miguel@ximian.com>
24176 * expression.cs: Handle operator== and operator!= for booleans.
24178 (Conditioal.Reduce): Implement reducer for the ?: operator.
24180 (Conditional.Resolve): Implement dead code elimination.
24182 (Binary.Resolve): Catch string literals and return a new
24183 concatenated string.
24185 (Unary.Reduce): Implement reduction of unary expressions.
24187 * ecore.cs: Split out the expression core handling here.
24189 (Expression.Reduce): New method used to perform constant folding
24190 and CSE. This is needed to support constant-expressions.
24192 * statement.cs (Statement.EmitBoolExpression): Pass true and false
24193 targets, and optimize for !x.
24195 2001-11-04 Ravi Pratap <ravi@ximian.com>
24197 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
24198 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
24199 set custom atttributes.
24201 * literal.cs (Literal::GetValue): New abstract method to return the actual
24202 value of the literal, cast as an object.
24204 (*Literal): Implement GetValue method.
24206 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
24207 expressions to the arraylist but objects of type Argument.
24209 * class.cs (TypeContainer::Emit): Emit our attributes too.
24211 (Method::Emit, Constructor::Emit): Ditto.
24213 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
24214 to be ignoring earlier.
24216 2001-11-03 Ravi Pratap <ravi@ximian.com>
24218 * attribute.cs (AttributeSection::Define): Implement to do the business
24219 of constructing a CustomAttributeBuilder.
24221 (Attribute): New trivial class. Increases readability of code.
24223 * cs-parser.jay : Update accordingly.
24225 (positional_argument_list, named_argument_list, named_argument): New rules
24227 (attribute_arguments): Use the above so that we are more correct.
24229 2001-11-02 Ravi Pratap <ravi@ximian.com>
24231 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
24232 to perform all checks for a method with a params parameter.
24234 (Invocation::OverloadResolve): Update to use the above method and therefore
24235 cope correctly with params method invocations.
24237 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
24240 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
24241 constructors in our parent too because we can't afford to miss out on
24244 * attribute.cs (AttributeSection): New name for the class Attribute
24246 Other trivial changes to improve readability.
24248 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
24249 use the new class names.
24251 2001-11-01 Ravi Pratap <ravi@ximian.com>
24253 * class.cs (Method::Define): Complete definition for params types too
24255 (Indexer::Define): Ditto.
24257 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
24258 Cope everywhere with a request for info about the array parameter.
24260 2001-11-01 Ravi Pratap <ravi@ximian.com>
24262 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24264 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24265 local_variable_type to extract the string corresponding to the type.
24267 (local_variable_type): Fixup the action to use the new helper method.
24269 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24272 * expression.cs : Clean out code which uses the above.
24274 2001-10-31 Ravi Pratap <ravi@ximian.com>
24276 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24277 and bale out if necessary by returning a false.
24279 (RegisterProperty): Ditto.
24281 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24282 and print out appropriate error messages.
24284 * interface.cs (everywhere): Ditto.
24286 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24287 location to constructor.
24289 * class.cs (Property, Event, Indexer): Update accordingly.
24291 * ../errors/cs111.cs : Added.
24293 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24294 of a method, as laid down by the spec.
24296 (Invocation::OverloadResolve): Use the above method.
24298 2001-10-31 Ravi Pratap <ravi@ximian.com>
24300 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24301 now take a TypeContainer and a Parameters object.
24303 (ParameterData): Modify return type of ParameterModifier method to be
24304 Parameter.Modifier and not a string.
24306 (ReflectionParameters, InternalParameters): Update accordingly.
24308 * expression.cs (Argument::GetParameterModifier): Same here.
24310 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24311 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24312 symbol in it at all so maybe this is only for now.
24314 2001-10-30 Ravi Pratap <ravi@ximian.com>
24316 * support.cs (InternalParameters): Constructor now takes an extra argument
24317 which is the actual Parameters class.
24319 (ParameterDesc): Update to provide info on ref/out modifiers.
24321 * class.cs (everywhere): Update call to InternalParameters to pass in
24322 the second argument too.
24324 * support.cs (ParameterData): Add ParameterModifier, which is a method
24325 to return the modifier info [ref/out etc]
24327 (InternalParameters, ReflectionParameters): Implement the above.
24329 * expression.cs (Argument::ParameterModifier): Similar function to return
24330 info about the argument's modifiers.
24332 (Invocation::OverloadResolve): Update to take into account matching modifiers
24335 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24336 a new SetFormalParameters object which we pass to InternalParameters.
24338 2001-10-30 Ravi Pratap <ravi@ximian.com>
24340 * expression.cs (NewArray): Merge into the ArrayCreation class.
24342 2001-10-29 Ravi Pratap <ravi@ximian.com>
24344 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24345 NewUserdefinedArray into one as there wasn't much of a use in having
24348 * expression.cs (Argument): Change field's name to ArgType from Type.
24350 (Type): New readonly property which returns the proper type, taking into
24351 account ref/out modifiers.
24353 (everywhere): Adjust code accordingly for the above.
24355 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24356 whether we are emitting for a ref or out parameter.
24358 * expression.cs (Argument::Emit): Use the above field to set the state.
24360 (LocalVariableReference::Emit): Update to honour the flag and emit the
24363 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24365 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24367 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24369 (ReflectionParameters, InternalParameters): Implement the above method.
24371 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24374 (Invocation::FullMethodDesc): Ditto.
24376 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24378 * cs-parser.jay: Add extra production for the second form of array
24381 * expression.cs (ArrayCreation): Update to reflect the above
24384 * Small changes to prepare for Array initialization.
24386 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24388 * typemanager.cs (ImplementsInterface): interface might be null;
24389 Deal with this problem;
24391 Also, we do store negative hits on the cache (null values), so use
24392 this instead of calling t.GetInterfaces on the type everytime.
24394 2001-10-28 Ravi Pratap <ravi@ximian.com>
24396 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24398 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24399 split functionality out into different classes.
24401 (New::FormArrayType): Move into NewBuiltinArray.
24403 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24406 (NewBuiltinArray): New class to handle creation of built-in arrays.
24408 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24409 account creation of one-dimensional arrays.
24411 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24413 (NewUserdefinedArray::DoResolve): Implement.
24415 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24417 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24418 we maintain inside the TypeManager. This is necessary to perform lookups on the
24421 (LookupType): Update to perform GetType on the module builders too.
24423 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24425 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24427 2001-10-23 Ravi Pratap <ravi@ximian.com>
24429 * expression.cs (New::DoResolve): Implement guts of array creation.
24431 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24433 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24435 * expression.cs: Fix bug I introduced lsat night that broke
24438 (Expression.Resolve): Report a 246 error (can not resolve name)
24439 if we find a SimpleName in the stream.
24441 (Expression.ResolveLValue): Ditto.
24443 (Expression.ResolveWithSimpleName): This function is a variant of
24444 ResolveName, this one allows SimpleNames to be returned without a
24445 warning. The only consumer of SimpleNames is MemberAccess
24447 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24449 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24450 might arrive here. I have my doubts that this is correct.
24452 * statement.cs (Lock): Implement lock statement.
24454 * cs-parser.jay: Small fixes to support `lock' and `using'
24456 * cs-tokenizer.cs: Remove extra space
24458 * driver.cs: New flag --checked, allows to turn on integer math
24461 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24462 Threading.Monitor.Exit
24464 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24466 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24467 Expression Class to be IndexerAccess.
24469 Notice that Indexer::DoResolve sets the eclass to Value.
24471 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24473 * class.cs (TypeContainer::Emit): Emit code for indexers.
24475 * assign.cs (IAssignMethod): New interface implemented by Indexers
24476 and Properties for handling assignment.
24478 (Assign::Emit): Simplify and reuse code.
24480 * expression.cs (IndexerAccess, PropertyExpr): Implement
24481 IAssignMethod, clean up old code.
24483 2001-10-22 Ravi Pratap <ravi@ximian.com>
24485 * typemanager.cs (ImplementsInterface): New method to determine if a type
24486 implements a given interface. Provides a nice cache too.
24488 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24491 (ConvertReferenceExplicit): Ditto.
24493 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24494 various methods, with correct names etc.
24496 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24497 Operator.UnaryNegation.
24499 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24500 we have a unary plus or minus operator.
24502 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24505 * everywhere : update accordingly.
24507 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24510 * class.cs (Method::Define): For the case where we are implementing a method
24511 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24512 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24514 2001-10-21 Ravi Pratap <ravi@ximian.com>
24516 * interface.cs (FindMembers): Implement to work around S.R.E
24519 * typemanager.cs (IsInterfaceType): Implement.
24521 (FindMembers): Update to handle interface types too.
24523 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24524 use IsAssignableFrom as that is not correct - it doesn't work.
24526 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24527 and accordingly override EmitStatement.
24529 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24530 using the correct logic :-)
24532 2001-10-19 Ravi Pratap <ravi@ximian.com>
24534 * ../errors/cs-11.cs : Add to demonstrate error -11
24536 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24538 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24539 then pass this as a hint to ResolveLValue.
24541 * expression.cs (FieldExpr): Add Location information
24543 (FieldExpr::LValueResolve): Report assignment to readonly
24546 (Expression::ExprClassFromMemberInfo): Pass location information.
24548 (Expression::ResolveLValue): Add new method that resolves an
24551 (Expression::DoResolveLValue): Default invocation calls
24554 (Indexers): New class used to keep track of indexers in a given
24557 (IStackStore): Renamed from LValue, as it did not really describe
24558 what this did. Also ResolveLValue is gone from this interface and
24559 now is part of Expression.
24561 (ElementAccess): Depending on the element access type
24563 * typemanager.cs: Add `indexer_name_type' as a Core type
24564 (System.Runtime.CompilerServices.IndexerNameAttribute)
24566 * statement.cs (Goto): Take a location.
24568 2001-10-18 Ravi Pratap <ravi@ximian.com>
24570 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24571 if two delegates are compatible.
24573 (NewDelegate::DoResolve): Update to take care of the case when
24574 we instantiate a delegate from another delegate.
24576 * typemanager.cs (FindMembers): Don't even try to look up members
24577 of Delegate types for now.
24579 2001-10-18 Ravi Pratap <ravi@ximian.com>
24581 * delegate.cs (NewDelegate): New class to take care of delegate
24584 * expression.cs (New): Split the delegate related code out into
24585 the NewDelegate class.
24587 * delegate.cs (DelegateInvocation): New class to handle delegate
24590 * expression.cs (Invocation): Split out delegate related code into
24591 the DelegateInvocation class.
24593 2001-10-17 Ravi Pratap <ravi@ximian.com>
24595 * expression.cs (New::DoResolve): Implement delegate creation fully
24596 and according to the spec.
24598 (New::DoEmit): Update to handle delegates differently.
24600 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24601 because of which we were printing out arguments in reverse order !
24603 * delegate.cs (VerifyMethod): Implement to check if the given method
24604 matches the delegate.
24606 (FullDelegateDesc): Implement.
24608 (VerifyApplicability): Implement.
24610 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24611 delegate invocations too.
24613 (Invocation::Emit): Ditto.
24615 * ../errors/cs1593.cs : Added.
24617 * ../errors/cs1594.cs : Added.
24619 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24621 2001-10-16 Ravi Pratap <ravi@ximian.com>
24623 * typemanager.cs (intptr_type): Core type for System.IntPtr
24625 (InitCoreTypes): Update for the same.
24627 (iasyncresult_type, asynccallback_type): Ditto.
24629 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24632 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24635 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24636 the builders for the 4 members of a delegate type :-)
24638 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24641 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24643 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24645 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24647 * statement.cs (Break::Emit): Implement.
24648 (Continue::Emit): Implement.
24650 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24651 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24652 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24653 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24656 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24657 properties that track the label for the current loop (begin of the
24658 loop and end of the loop).
24660 2001-10-15 Ravi Pratap <ravi@ximian.com>
24662 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24663 use of emitting anything at all.
24665 * class.cs, rootcontext.cs : Get rid of calls to the same.
24667 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24669 (Populate): Define the constructor correctly and set the implementation
24672 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24675 (AddDelegateType): Implement.
24677 (IsDelegateType): Implement helper method.
24679 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24681 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24682 and accordingly handle it.
24684 * delegate.cs (Populate): Take TypeContainer argument.
24685 Implement bits to define the Invoke method. However, I still haven't figured out
24686 how to take care of the native int bit :-(
24688 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24689 Qualify the name of the delegate, not its return type !
24691 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24694 (StandardConversionExists): Checking for array types turns out to be recursive.
24696 (ConvertReferenceExplicit): Implement array conversion.
24698 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24700 2001-10-12 Ravi Pratap <ravi@ximian.com>
24702 * cs-parser.jay (delegate_declaration): Store the fully qualified
24703 name as it is a type declaration.
24705 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24708 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24709 as TypeContainer::DefineType.
24711 (Populate): Method in which all the definition of the various methods (Invoke)
24714 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24717 (CloseDelegate): Finally creates the delegate.
24719 * class.cs (TypeContainer::DefineType): Update to define delegates.
24720 (Populate, Emit and CloseType): Do the same thing here too.
24722 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24723 delegates in all these operations.
24725 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24727 * expression.cs: LocalTemporary: a new expression used to
24728 reference a temporary that has been created.
24730 * assign.cs: Handle PropertyAccess back here, so that we can
24731 provide the proper semantic access to properties.
24733 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24734 a few more explicit conversions.
24736 * modifiers.cs: `NEW' modifier maps to HideBySig.
24738 * expression.cs (PropertyExpr): Make this into an
24739 ExpressionStatement, and support the EmitStatement code path.
24741 Perform get/set error checking, clean up the interface.
24743 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24744 them into toplevel access objects.
24746 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24748 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24751 * typemanager.cs: Keep track here of our PropertyBuilders again to
24752 work around lameness in SRE.
24754 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24756 * expression.cs (LValue::LValueResolve): New method in the
24757 interface, used to perform a second resolution pass for LValues.
24759 (This::DoResolve): Catch the use of this in static methods.
24761 (This::LValueResolve): Implement.
24763 (This::Store): Remove warning, assigning to `this' in structures
24766 (Invocation::Emit): Deal with invocation of
24767 methods on value types. We need to pass the address to structure
24768 methods rather than the object itself. (The equivalent code to
24769 emit "this" for structures leaves the entire structure on the
24770 stack instead of a pointer to it).
24772 (ParameterReference::DoResolve): Compute the real index for the
24773 argument based on whether the method takes or not a `this' pointer
24774 (ie, the method is static).
24776 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24777 value types returned from functions when we need to invoke a
24778 method on the sturcture.
24781 2001-10-11 Ravi Pratap <ravi@ximian.com>
24783 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24784 defining the type in the Modulebuilder or Typebuilder. This is to take
24785 care of nested types which need to be defined on the TypeBuilder using
24786 DefineNestedMethod.
24788 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24789 methods in RootContext, only ported to be part of TypeContainer.
24791 (TypeContainer::GetInterfaceOrClass): Ditto.
24793 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24795 * interface.cs (Interface::DefineInterface): New method. Does exactly
24796 what RootContext.CreateInterface did earlier, only it takes care of nested types
24799 (Interface::GetInterfaces): Move from RootContext here and port.
24801 (Interface::GetInterfaceByName): Same here.
24803 * rootcontext.cs (ResolveTree): Re-write.
24805 (PopulateTypes): Re-write.
24807 * class.cs (TypeContainer::Populate): Populate nested types too.
24808 (TypeContainer::Emit): Emit nested members too.
24810 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24811 instead just use the name argument passed in as it is already fully
24814 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24815 to TypeContainer mapping to see if a type is user-defined.
24817 * class.cs (TypeContainer::CloseType): Implement.
24819 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24820 the default constructor.
24822 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24825 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24827 * interface.cs (CloseType): Create the type here.
24829 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24832 Remove all the methods which are now in TypeContainer.
24834 2001-10-10 Ravi Pratap <ravi@ximian.com>
24836 * delegate.cs (Define): Re-write bits to define the delegate
24839 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24841 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24843 * expression.cs (ImplicitReferenceConversion): handle null as well
24844 as a source to convert to any reference type.
24846 * statement.cs (Return): Perform any implicit conversions to
24847 expected return type.
24849 Validate use of return statement.
24851 * codegen.cs (EmitContext): Pass the expected return type here.
24853 * class.cs (Method, Constructor, Property): Pass expected return
24854 type to EmitContext.
24856 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24858 * expression.cs: Make DoResolve take an EmitContext instead of a
24861 Replaced `l' and `location' for `loc', for consistency.
24863 (Error, Warning): Remove unneeded Tc argument.
24865 * assign.cs, literal.cs, constant.cs: Update to new calling
24868 * codegen.cs: EmitContext now contains a flag indicating whether
24869 code is being generated in a static method or not.
24871 * cs-parser.jay: DecomposeQI, new function that replaces the old
24872 QualifiedIdentifier. Now we always decompose the assembled
24873 strings from qualified_identifier productions into a group of
24876 2001-10-08 Miguel de Icaza <miguel@ximian.com>
24878 * rootcontext.cs: Deal with field-less struct types correctly now
24879 by passing the size option to Define Type.
24881 * class.cs: Removed hack that created one static field.
24883 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24885 * statement.cs: Moved most of the code generation here.
24887 2001-10-09 Ravi Pratap <ravi@ximian.com>
24889 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
24892 (ElementAccess): Remove useless bits for now - keep checks as the spec
24895 2001-10-08 Ravi Pratap <ravi@ximian.com>
24897 * expression.cs (ElementAccess::DoResolve): Remove my crap code
24898 and start performing checks according to the spec.
24900 2001-10-07 Ravi Pratap <ravi@ximian.com>
24902 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
24903 rank_specifiers instead.
24905 (rank_specifiers): Change the order in which the rank specifiers are stored
24907 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
24909 * expression.cs (ElementAccess): Implement the LValue interface too.
24911 2001-10-06 Ravi Pratap <ravi@ximian.com>
24913 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
24914 except that user defined conversions are not included.
24916 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
24917 perform the conversion of the return type, if necessary.
24919 (New::DoResolve): Check whether we are creating an array or an object
24920 and accordingly do the needful.
24922 (New::Emit): Same here.
24924 (New::DoResolve): Implement guts of array creation.
24926 (New::FormLookupType): Helper function.
24928 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24930 * codegen.cs: Removed most of the code generation here, and move the
24931 corresponding code generation bits to the statement classes.
24933 Added support for try/catch/finalize and throw.
24935 * cs-parser.jay: Added support for try/catch/finalize.
24937 * class.cs: Catch static methods having the flags override,
24938 virtual or abstract.
24940 * expression.cs (UserCast): This user cast was not really doing
24941 what it was supposed to do. Which is to be born in fully resolved
24942 state. Parts of the resolution were being performed at Emit time!
24946 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24948 * expression.cs: Implicity convert the result from UserCast.
24950 2001-10-05 Ravi Pratap <ravi@ximian.com>
24952 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
24953 prevented it from working correctly.
24955 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
24956 merely ConvertImplicit.
24958 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24960 * typemanager.cs: Make the LookupTypeContainer function static,
24961 and not per-instance.
24963 * class.cs: Make static FindMembers (the one that takes a Type
24966 * codegen.cs: Add EmitForeach here.
24968 * cs-parser.jay: Make foreach a toplevel object instead of the
24969 inline expansion, as we need to perform semantic analysis on it.
24971 2001-10-05 Ravi Pratap <ravi@ximian.com>
24973 * expression.cs (Expression::ImplicitUserConversion): Rename to
24974 UserDefinedConversion.
24976 (Expression::UserDefinedConversion): Take an extra argument specifying
24977 whether we look for explicit user conversions too.
24979 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
24981 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
24983 (ExplicitUserConversion): Make it a call to UserDefinedConversion
24984 with the appropriate arguments.
24986 * cs-parser.jay (cast_expression): Record location too.
24988 * expression.cs (Cast): Record location info.
24990 (Expression::ConvertExplicit): Take location argument.
24992 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
24993 to determine if we are doing explicit conversions.
24995 (UserCast::Emit): Update accordingly.
24997 (Expression::ConvertExplicit): Report an error if everything fails.
24999 * ../errors/cs0030.cs : Add.
25001 2001-10-04 Miguel de Icaza <miguel@ximian.com>
25003 * modifiers.cs: If the ABSTRACT keyword is present, also set the
25004 virtual and newslot bits.
25006 * class.cs (TypeContainer::RegisterRequiredImplementations):
25007 Record methods we need.
25009 (TypeContainer::MakeKey): Helper function to make keys for
25010 MethodBases, since the Methodbase key is useless.
25012 (TypeContainer::Populate): Call RegisterRequiredImplementations
25013 before defining the methods.
25015 Create a mapping for method_builders_to_methods ahead of time
25016 instead of inside a tight loop.
25018 (::RequireMethods): Accept an object as the data to set into the
25019 hashtable so we can report interface vs abstract method mismatch.
25021 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25023 * report.cs: Make all of it static.
25025 * rootcontext.cs: Drop object_type and value_type computations, as
25026 we have those in the TypeManager anyways.
25028 Drop report instance variable too, now it is a global.
25030 * driver.cs: Use try/catch on command line handling.
25032 Add --probe option to debug the error reporting system with a test
25035 * report.cs: Add support for exiting program when a probe
25036 condition is reached.
25038 2001-10-03 Ravi Pratap <ravi@ximian.com>
25040 * expression.cs (Binary::DoNumericPromotions): Fix the case when
25041 we do a forcible conversion regardless of type, to check if
25042 ForceConversion returns a null.
25044 (Binary::error19): Use location to report error.
25046 (Unary::error23): Use location here too.
25048 * ../errors/cs0019.cs : Check in.
25050 * ../errors/cs0023.cs : Check in.
25052 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
25053 case of a non-null MethodInfo object with a length of 0 !
25055 (Binary::ResolveOperator): Flag error if overload resolution fails to find
25056 an applicable member - according to the spec :-)
25057 Also fix logic to find members in base types.
25059 (Unary::ResolveOperator): Same here.
25061 (Unary::report23): Change name to error23 and make first argument a TypeContainer
25062 as I was getting thoroughly confused between this and error19 :-)
25064 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
25065 (::FindMostEncompassedType): Implement.
25066 (::FindMostEncompassingType): Implement.
25067 (::StandardConversionExists): Implement.
25069 (UserImplicitCast): Re-vamp. We now need info about most specific
25070 source and target types so that we can do the necessary conversions.
25072 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
25073 mathematical union with no duplicates.
25075 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25077 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
25078 in order from base classes to child classes, so that we can in
25079 child classes look up in our parent for method names and
25080 attributes (required for handling abstract, virtual, new, override
25081 constructs: we need to instrospect our base class, and if we dont
25082 populate the classes in order, the introspection might be
25083 incorrect. For example, a method could query its parent before
25084 the parent has any methods and would determine that the parent has
25085 no abstract methods (while it could have had them)).
25087 (RootContext::CreateType): Record the order in which we define the
25090 2001-10-02 Miguel de Icaza <miguel@ximian.com>
25092 * class.cs (TypeContainer::Populate): Also method definitions can
25093 fail now, keep track of this.
25095 (TypeContainer::FindMembers): Implement support for
25096 DeclaredOnly/noDeclaredOnly flag.
25098 (Constructor::Emit) Return the ConstructorBuilder.
25100 (Method::Emit) Return the MethodBuilder.
25101 Check for abstract or virtual methods to be public.
25103 * rootcontext.cs (RootContext::CreateType): Register all the
25104 abstract methods required for the class to be complete and the
25105 interface methods that must be implemented.
25107 * cs-parser.jay: Report error 501 (method requires body if it is
25108 not marked abstract or extern).
25110 * expression.cs (TypeOf::Emit): Implement.
25112 * typemanager.cs: runtime_handle_type, new global type.
25114 * class.cs (Property::Emit): Generate code for properties.
25116 2001-10-02 Ravi Pratap <ravi@ximian.com>
25118 * expression.cs (Unary::ResolveOperator): Find operators on base type
25119 too - we now conform exactly to the spec.
25121 (Binary::ResolveOperator): Same here.
25123 * class.cs (Operator::Define): Fix minor quirk in the tests.
25125 * ../errors/cs0215.cs : Added.
25127 * ../errors/cs0556.cs : Added.
25129 * ../errors/cs0555.cs : Added.
25131 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25133 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
25134 single integer which is really efficient
25136 2001-10-01 Ravi Pratap <ravi@ximian.com>
25138 * expression.cs (Expression::ImplicitUserConversion): Use location
25139 even in the case when we are examining True operators.
25141 * class.cs (Operator::Define): Perform extensive checks to conform
25142 with the rules for operator overloading in the spec.
25144 * expression.cs (Expression::ImplicitReferenceConversion): Implement
25145 some of the other conversions mentioned in the spec.
25147 * typemanager.cs (array_type): New static member for the System.Array built-in
25150 (cloneable_interface): For System.ICloneable interface.
25152 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
25153 we start resolving the tree and populating types.
25155 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
25157 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25159 * expression.cs (Expression::ExprClassFromMemberInfo,
25160 Expression::Literalize): Create literal expressions from
25161 FieldInfos which are literals.
25163 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
25164 type casts, because they were wrong. The test suite in tests
25167 (ImplicitNumericConversion): ushort to ulong requires a widening
25170 Int32 constant to long requires widening cast as well.
25172 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
25173 for integers because the type on the stack is not i4.
25175 2001-09-30 Miguel de Icaza <miguel@ximian.com>
25177 * expression.cs (report118): require location argument.
25179 * parameter.cs: Do not dereference potential null value.
25181 * class.cs: Catch methods that lack the `new' keyword when
25182 overriding a name. Report warnings when `new' is used without
25183 anything being there to override.
25185 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
25187 * class.cs: Only add constructor to hashtable if it is non-null
25188 (as now constructors can fail on define).
25190 (TypeManager, Class, Struct): Take location arguments.
25192 Catch field instance initialization in structs as errors.
25194 accepting_filter: a new filter for FindMembers that is static so
25195 that we dont create an instance per invocation.
25197 (Constructor::Define): Catch errors where a struct constructor is
25200 * cs-parser.jay: Pass location information for various new
25203 * delegate.cs (Delegate): take a location argument.
25205 * driver.cs: Do not call EmitCode if there were problesm in the
25206 Definition of the types, as many Builders wont be there.
25208 * decl.cs (Decl::Decl): Require a location argument.
25210 * cs-tokenizer.cs: Handle properly hex constants that can not fit
25211 into integers, and find the most appropiate integer for it.
25213 * literal.cs: Implement ULongLiteral.
25215 * rootcontext.cs: Provide better information about the location of
25216 failure when CreateType fails.
25218 2001-09-29 Miguel de Icaza <miguel@ximian.com>
25220 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
25223 * expression.cs (Binary::CheckShiftArguments): Add missing type
25225 (Binary::ResolveOperator): Add type to the logical and and logical
25226 or, Bitwise And/Or and Exclusive Or code paths, it was missing
25229 (Binary::DoNumericPromotions): In the case where either argument
25230 is ulong (and most signed types combined with ulong cause an
25231 error) perform implicit integer constant conversions as well.
25233 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25235 * expression.cs (UserImplicitCast): Method should always be
25237 (Invocation::BetterConversion): Simplified test for IntLiteral.
25239 (Expression::ImplicitNumericConversion): Split this routine out.
25240 Put the code that performs implicit constant integer conversions
25243 (Expression::Resolve): Become a wrapper around DoResolve so we can
25244 check eclass and type being set after resolve.
25246 (Invocation::Badness): Remove this dead function
25248 (Binary::ResolveOperator): Do not compute the expensive argumnets
25249 unless we have a union for it.
25251 (Probe::Emit): Is needs to do an isinst and then
25252 compare against null.
25254 (::CanConvert): Added Location argument. If the Location argument
25255 is null (Location.Null), then we do not report errors. This is
25256 used by the `probe' mechanism of the Explicit conversion. We do
25257 not want to generate an error for something that the user
25258 explicitly requested to be casted. But the pipeline for an
25259 explicit cast first tests for potential implicit casts.
25261 So for now, if the Location is null, it means `Probe only' to
25262 avoid adding another argument. Might have to revise this
25265 (ClassCast): New class used to type cast objects into arbitrary
25266 classes (used in Explicit Reference Conversions).
25268 Implement `as' as well.
25270 Reverted all the patches from Ravi below: they were broken:
25272 * The use of `level' as a mechanism to stop recursive
25273 invocations is wrong. That was there just to catch the
25274 bug with a strack trace but not as a way of addressing
25277 To fix the problem we have to *understand* what is going
25278 on and the interactions and come up with a plan, not
25279 just get things going.
25281 * The use of the type conversion cache that I proposed
25282 last night had an open topic: How does this work across
25283 protection domains. A user defined conversion might not
25284 be public in the location where we are applying the
25285 conversion, a different conversion might be selected
25286 (ie, private A->B (better) but public B->A (worse),
25287 inside A, A->B applies, but outside it, B->A will
25290 * On top of that (ie, even if the above is solved),
25291 conversions in a cache need to be abstract. Ie, `To
25292 convert from an Int to a Short use an OpcodeCast', not
25293 `To convert from an Int to a Short use the OpcodeCast on
25294 the variable 5' (which is what this patch was doing).
25296 2001-09-28 Ravi Pratap <ravi@ximian.com>
25298 * expression.cs (Invocation::ConversionExists): Re-write to use
25299 the conversion cache
25301 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25302 cache all conversions done, not just user-defined ones.
25304 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25305 to determine if a conversion exists instead of acutually trying to
25306 perform the conversion. It's faster too.
25308 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25309 and only then attempt the implicit conversion.
25311 2001-09-28 Ravi Pratap <ravi@ximian.com>
25313 * expression.cs (ConvertImplicit): Use a cache for conversions
25314 already found. Check level of recursion and bail out if necessary.
25316 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25318 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25319 Export standard methods that we expect for string operations.
25321 * statement.cs (Block::UsageWarning): Track usage of variables and
25322 report the errors for not used variables.
25324 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25327 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25329 * codegen.cs: remove unnneded code
25331 * expression.cs: Removed BuiltinTypeAccess class
25333 Fix the order in which implicit conversions are
25336 The previous fixed dropped support for boxed conversions (adding a
25337 test to the test suite now)
25339 (UserImplicitCast::CanConvert): Remove test for source being null,
25340 that code is broken. We should not feed a null to begin with, if
25341 we do, then we should track the bug where the problem originates
25342 and not try to cover it up here.
25344 Return a resolved expression of type UserImplicitCast on success
25345 rather than true/false. Ravi: this is what I was talking about,
25346 the pattern is to use a static method as a "constructor" for
25349 Also, do not create arguments until the very last minute,
25350 otherwise we always create the arguments even for lookups that
25351 will never be performed.
25353 (UserImplicitCast::Resolve): Eliminate, objects of type
25354 UserImplicitCast are born in a fully resolved state.
25356 * typemanager.cs (InitCoreTypes): Init also value_type
25357 (System.ValueType).
25359 * expression.cs (Cast::Resolve): First resolve the child expression.
25361 (LValue): Add new method AddressOf to be used by
25364 Change the argument of Store to take an EmitContext instead of an
25365 ILGenerator, because things like FieldExpr need to be able to call
25366 their children expression to generate the instance code.
25368 (Expression::Error, Expression::Warning): Sugar functions for
25371 (Expression::MemberLookup): Accept a TypeContainer instead of a
25372 Report as the first argument.
25374 (Expression::ResolvePrimary): Killed. I still want to improve
25375 this as currently the code is just not right.
25377 (Expression::ResolveMemberAccess): Simplify, but it is still
25380 (Unary::Resolve): Catch errors in AddressOf operators.
25382 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25383 index to a byte for the short-version, or the compiler will choose
25384 the wrong Emit call, which generates the wrong data.
25386 (ParameterReference::Emit, ::Store): same.
25388 (FieldExpr::AddressOf): Implement.
25390 * typemanager.cs: TypeManager: made public variable instead of
25393 * driver.cs: document --fatal.
25395 * report.cs (ErrorMessage, WarningMessage): new names for the old
25396 Error and Warning classes.
25398 * cs-parser.jay (member_access): Turn built-in access to types
25399 into a normal simplename
25401 2001-09-27 Ravi Pratap <ravi@ximian.com>
25403 * expression.cs (Invocation::BetterConversion): Fix to cope
25404 with q being null, since this was introducing a bug.
25406 * expression.cs (ConvertImplicit): Do built-in conversions first.
25408 2001-09-27 Ravi Pratap <ravi@ximian.com>
25410 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25412 2001-09-27 Ravi Pratap <ravi@ximian.com>
25414 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25415 I had introduced long ago (what's new ?).
25417 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25418 the work of all the checking.
25419 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25420 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25422 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25423 that is the right way.
25425 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25426 overloading resolution. Use everywhere instead of cutting and pasting code.
25428 (Binary::ResolveOperator): Use MakeUnionSet.
25430 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25431 we have to convert to bool types. Not complete yet.
25433 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25435 * typemanager.cs (TypeManager::CSharpName): support ushort.
25437 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25438 to provide an expression that performsn an implicit constant int
25439 conversion (section 6.1.6).
25440 (Expression::ConvertImplicitRequired): Reworked to include
25441 implicit constant expression conversions.
25443 (Expression::ConvertNumericExplicit): Finished.
25445 (Invocation::Emit): If InstanceExpression is null, then it means
25446 that we perform a call on this.
25448 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25450 * expression.cs (Unary::Emit): Remove some dead code.
25451 (Probe): Implement Resolve and Emit for `is'.
25452 (Expression::ConvertImplicitRequired): Attempt to do constant
25453 expression conversions here. Maybe should be moved to
25454 ConvertImplicit, but I am not sure.
25455 (Expression::ImplicitLongConstantConversionPossible,
25456 Expression::ImplicitIntConstantConversionPossible): New functions
25457 that tell whether is it possible to apply an implicit constant
25458 expression conversion.
25460 (ConvertNumericExplicit): Started work on explicit numeric
25463 * cs-parser.jay: Update operator constants.
25465 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25466 (Parameters::GetSignature): Hook up VerifyArgs here.
25467 (Parameters::VerifyArgs): Verifies that no two arguments have the
25470 * class.cs (Operator): Update the operator names to reflect the
25471 ones that the spec expects (as we are just stringizing the
25474 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25475 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25476 previous usage did only work for our methods.
25477 (Expression::ConvertImplicit): Handle decimal implicit numeric
25478 conversions as well.
25479 (Expression::InternalTypeConstructor): Used to invoke constructors
25480 on internal types for default promotions.
25482 (Unary::Emit): Implement special handling for the pre/post
25483 increment/decrement for overloaded operators, as they need to have
25484 the same semantics as the other operators.
25486 (Binary::ResolveOperator): ditto.
25487 (Invocation::ConversionExists): ditto.
25488 (UserImplicitCast::Resolve): ditto.
25490 2001-09-26 Ravi Pratap <ravi@ximian.com>
25492 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25493 operator, return after emitting body. Regression tests pass again !
25495 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25496 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25497 (Invocation::OverloadResolve): Ditto.
25498 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25500 * everywhere : update calls to the above methods accordingly.
25502 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25504 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25506 * expression.cs (ExpressionStatement): New base class used for
25507 expressions that can appear in statements, so that we can provide
25508 an alternate path to generate expression that do not leave a value
25511 (Expression::Emit, and all the derivatives): We no longer return
25512 whether a value is left on the stack or not. Every expression
25513 after being emitted leaves a single value on the stack.
25515 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25516 facilties of ExpressionStatement if possible.
25518 * cs-parser.jay: Update statement_expression.
25520 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25522 * driver.cs: Change the wording of message
25524 2001-09-25 Ravi Pratap <ravi@ximian.com>
25526 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25527 the type of the expression to the return type of the method if
25528 we have an overloaded operator match ! The regression tests pass again !
25529 (Unary::ResolveOperator): Ditto.
25531 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25532 to find "op_Implicit", not "implicit" ;-)
25533 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25534 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25536 * everywhere : Correct calls to the above accordingly.
25538 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25539 (ConvertImplicit): Do user-defined conversion if it exists.
25541 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25543 * assign.cs: track location.
25544 (Resolve): Use implicit conversions on assignment.
25546 * literal.cs: Oops. Not good, Emit of short access values should
25547 pass (Bytes) or the wrong argument will be selected.
25549 * expression.cs (Unary::Emit): Emit code for -expr.
25551 (Unary::ResolveOperator): Handle `Substract' for non-constants
25552 (substract from zero from the non-constants).
25553 Deal with Doubles as well.
25555 (Expression::ConvertImplicitRequired): New routine that reports an
25556 error if no implicit conversion exists.
25558 (Invocation::OverloadResolve): Store the converted implicit
25559 expressions if we make them
25561 2001-09-24 Ravi Pratap <ravi@ximian.com>
25563 * class.cs (ConstructorInitializer): Take a Location argument.
25564 (ConstructorBaseInitializer): Same here.
25565 (ConstructorThisInitializer): Same here.
25567 * cs-parser.jay : Update all calls accordingly.
25569 * expression.cs (Unary, Binary, New): Take location argument.
25570 Update accordingly everywhere.
25572 * cs-parser.jay : Update all calls to the above to take a location
25575 * class.cs : Ditto.
25577 2001-09-24 Ravi Pratap <ravi@ximian.com>
25579 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25580 (Invocation::BetterConversion): Same here
25581 (Invocation::ConversionExists): Ditto.
25583 (Invocation::ConversionExists): Implement.
25585 2001-09-22 Ravi Pratap <ravi@ximian.com>
25587 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25588 Also take an additional TypeContainer argument.
25590 * All over : Pass in TypeContainer as argument to OverloadResolve.
25592 * typemanager.cs (CSharpName): Update to check for the string type and return
25595 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25598 2001-09-21 Ravi Pratap <ravi@ximian.com>
25600 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25601 (Invocation::BetterFunction): Implement.
25602 (Invocation::BetterConversion): Implement.
25603 (Invocation::ConversionExists): Skeleton, no implementation yet.
25605 Okay, things work fine !
25607 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25609 * typemanager.cs: declare and load enum_type, delegate_type and
25612 * expression.cs (Expression::Emit): Now emit returns a value that
25613 tells whether a value is left on the stack or not. This strategy
25614 might be reveted tomorrow with a mechanism that would address
25615 multiple assignments.
25616 (Expression::report118): Utility routine to report mismatches on
25619 (Unary::Report23): Report impossible type/operator combination
25622 (Unary::IsIncrementableNumber): Whether the type can be
25623 incremented or decremented with add.
25624 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25626 (Unary::ResolveOperator): Implement ++, !, ~,
25628 (Invocation::Emit): Deal with new Emit convetion.
25630 * All Expression derivatives: Updated their Emit method to return
25631 whether they leave values on the stack or not.
25633 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25634 stack for expressions that are statements.
25636 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25638 * expression.cs (LValue): New interface. Must be implemented by
25640 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25643 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25644 interface for generating code, simplifies the code.
25646 2001-09-20 Ravi Pratap <ravi@ximian.com>
25648 * expression.cs (everywhere): Comment out return statements in ::Resolve
25649 methods to avoid the warnings.
25651 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25653 * driver.cs (parse): Report error 2001 if we can not open the
25656 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25659 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25662 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25663 otherwise nested blocks end up with the same index.
25665 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25667 * expression.cs: Instead of having FIXMEs in the Resolve
25668 functions, throw exceptions so it is obvious that we are facing a
25671 * cs-parser.jay (invocation_expression): Pass Location information.
25673 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25674 Use a basename for those routines because .NET does not like paths
25677 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25680 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25682 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25683 are loading the correct data types (throws an exception if not).
25684 (TypeManager::InitCoreTypes): Use CoreLookupType
25686 * expression.cs (Unary::ResolveOperator): return the child
25687 expression for expressions which are just +expr.
25688 (Unary::ResolveOperator): Return negative literals for -LITERAL
25689 expressions (otherwise they are Unary {Literal}).
25690 (Invocation::Badness): Take into account `Implicit constant
25691 expression conversions'.
25693 * literal.cs (LongLiteral): Implement long literal class.
25694 (IntLiteral): export the `Value' of the intliteral.
25696 2001-09-19 Ravi Pratap <ravi@ximian.com>
25698 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25700 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25701 instead of 'Operator'
25703 * expression.cs (Binary::ResolveOperator): Update accordingly.
25704 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25707 * cs-parser.jay (unary_expression): Update to use the new names.
25709 * gen-treedump.cs (GetUnary): Same here.
25711 * expression.cs (Unary::Resolve): Implement.
25712 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25713 operators are found instead of making noise ;-)
25714 (Unary::ResolveOperator): New method to do precisely the same thing which
25715 Binary::ResolveOperator does for Binary expressions.
25716 (Unary.method, .Arguments): Add.
25717 (Unary::OperName): Implement.
25718 (Unary::ForceConversion): Copy and Paste !
25720 * class.cs (Operator::Define): Fix a small bug for the case when we have
25723 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25724 for the inbuilt operators. Only overloading works for now ;-)
25726 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25728 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25729 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25731 * expression.cs (This::Emit): Implement.
25732 (This::Resolve): Implement.
25733 (TypeOf:Resolve): Implement.
25734 (Expression::ResolveSimpleName): Add an implicit this to instance
25736 (MemberAccess::Resolve): Deal with Parameters and Fields.
25737 Bind instance variable to Field expressions.
25738 (FieldExpr::Instance): New field used to track the expression that
25739 represents the object instance.
25740 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25742 (FieldExpr::Emit): Implement.
25744 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25745 the last instruction contains a return opcode to avoid generating
25746 the last `ret' instruction (this generates correct code, and it is
25747 nice to pass the peverify output).
25749 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25750 initializer for static and instance variables.
25751 (Constructor::Emit): Allow initializer to be null in the case of
25752 static constructors. Only emit initializer for instance
25755 (TypeContainer::FindMembers): Return a null array if there are no
25758 Also fix the code for the MemberTypes.Method branch, as it was not
25759 scanning that for operators (or tried to access null variables before).
25761 * assign.cs (Assign::Emit): Handle instance and static fields.
25765 * driver.cs: Stop compilation if there are parse errors.
25767 * cs-parser.jay (constructor_declaration): Provide default base
25768 initializer for non-static constructors.
25769 (constructor_declarator): Do not provide a default base
25770 initializers if none was specified.
25771 Catch the fact that constructors should not have parameters.
25773 * class.cs: Do not emit parent class initializers for static
25774 constructors, that should be flagged as an error.
25776 2001-09-18 Ravi Pratap <ravi@ximian.com>
25778 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25779 Move back code into TypeContainer::Populate.
25781 2001-09-18 Ravi Pratap <ravi@ximian.com>
25783 * class.cs (TypeContainer::AddConstructor): Fix the check to
25784 compare against Name, not Basename.
25785 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25787 * cs-parser.jay : Update accordingly.
25789 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25790 for methods, don't forget to look into the operators too.
25791 (RegisterMethodBuilder): Helper method to take care of this for
25792 methods, constructors and operators.
25793 (Operator::Define): Completely revamp.
25794 (Operator.OperatorMethod, MethodName): New fields.
25795 (TypeContainer::Populate): Move the registering of builders into
25796 RegisterMethodBuilder.
25797 (Operator::Emit): Re-write.
25799 * expression.cs (Binary::Emit): Comment out code path to emit method
25800 invocation stuff for the case when we have a user defined operator. I am
25801 just not able to get it right !
25803 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25805 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25808 (Expression::MemberLookup): Provide a version that allows to
25809 specify the MemberTypes and BindingFlags.
25811 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25812 so it was not fetching variable information from outer blocks.
25814 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25815 Beforefieldinit as it was buggy.
25817 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25818 that Ravi put here.
25820 * class.cs (Constructor::Emit): Only emit if block is not null.
25821 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25822 deal with this by semantically definining it as if the user had
25825 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25826 constructors as we now "emit" them at a higher level.
25828 (TypeContainer::DefineDefaultConstructor): Used to define the
25829 default constructors if none was provided.
25831 (ConstructorInitializer): Add methods Resolve and Emit.
25833 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25835 2001-09-17 Ravi Pratap <ravi@ximian.com>
25837 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25838 the default constructor builder with our hashtable for methodbuilders
25841 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25842 and argument_count is 0 in which case we have a match.
25843 (Binary::ResolveOperator): More null checking and miscellaneous coding
25846 2001-09-17 Ravi Pratap <ravi@ximian.com>
25848 * rootcontext.cs (IsNameSpace): Compare against null.
25850 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25852 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25853 and Unary::Operator.
25855 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25858 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25859 we have overloaded operators.
25860 (Binary::ResolveOperator): Implement the part which does the operator overload
25863 * class.cs (Operator::Emit): Implement.
25864 (TypeContainer::Emit): Emit the operators we have too.
25866 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25867 the case when we have a user-defined operator.
25869 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25871 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
25873 2001-09-16 Ravi Pratap <ravi@ximian.com>
25875 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
25876 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
25877 (Constructor::Emit): Implement.
25878 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
25879 if we have no work to do.
25880 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
25883 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
25884 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
25886 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
25889 2001-09-15 Ravi Pratap <ravi@ximian.com>
25891 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
25893 (Tree::RecordNamespace): Method to do what the name says ;-)
25894 (Tree::Namespaces): Property to get at the namespaces hashtable.
25896 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
25899 * rootcontext.cs (IsNamespace): Fixed it :-)
25901 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25903 * class.cs (TypeContainer::FindMembers): Add support for
25905 (MethodCore): New class that encapsulates both the shared aspects
25906 of a Constructor and a Method.
25907 (Method, Constructor): Factored pieces into MethodCore.
25909 * driver.cs: Added --fatal which makes errors throw exceptions.
25910 Load System assembly as well as part of the standard library.
25912 * report.cs: Allow throwing exceptions on errors for debugging.
25914 * modifiers.cs: Do not use `parent', instead use the real type
25915 container to evaluate permission settings.
25917 * class.cs: Put Ravi's patch back in. He is right, and we will
25918 have to cope with the
25920 2001-09-14 Ravi Pratap <ravi@ximian.com>
25922 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
25923 FamORAssem, not FamANDAssem.
25925 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25927 * driver.cs: Added --parse option that only parses its input files
25930 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
25931 incorrect. IsTopLevel is not used to tell whether an object is
25932 root_types or not (that can be achieved by testing this ==
25933 root_types). But to see if this is a top-level *class* (not
25934 necessarly our "toplevel" container).
25936 2001-09-14 Ravi Pratap <ravi@ximian.com>
25938 * enum.cs (Enum::Define): Modify to call the Lookup method on the
25939 parent instead of a direct call to GetType.
25941 2001-09-14 Ravi Pratap <ravi@ximian.com>
25943 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
25944 Modifiers.TypeAttr. This should just be a call to that method.
25946 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
25947 object so that we can determine if we are top-level or not.
25949 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
25952 * enum.cs (Enum::Define): Ditto.
25954 * modifiers.cs (FieldAttr): Re-write.
25956 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
25957 (TypeContainer::HaveStaticConstructor): New property to provide access
25958 to precisely that info.
25960 * modifiers.cs (MethodAttr): Re-write.
25961 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
25963 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
25964 of top-level types as claimed.
25966 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25968 * expression.cs (MemberLookup): Fruitless attempt to lookup
25969 constructors. Maybe I need to emit default constructors? That
25970 might be it (currently .NET emits this for me automatically).
25971 (Invocation::OverloadResolve): Cope with Arguments == null.
25972 (Invocation::EmitArguments): new function, shared by the new
25973 constructor and us.
25974 (Invocation::Emit): Handle static and instance methods. Emit
25975 proper call instruction for virtual or non-virtual invocations.
25976 (New::Emit): Implement.
25977 (New::Resolve): Implement.
25978 (MemberAccess:Resolve): Implement.
25979 (MethodGroupExpr::InstanceExpression): used conforming to the spec
25980 to track instances.
25981 (FieldExpr::Resolve): Set type.
25983 * support.cs: Handle empty arguments.
25985 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
25986 SimpleLookup): Auxiliary routines to help parse a qualifier
25989 Update qualifier_identifier rule.
25991 * codegen.cs: Removed debugging messages.
25993 * class.cs: Make this a global thing, this acts just as a "key" to
25994 objects that we might have around.
25996 (Populate): Only initialize method_builders_to_methods once.
25998 * expression.cs (PropertyExpr): Initialize type from the
26001 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
26002 Resolve pattern. Attempt to implicitly convert value to boolean.
26005 * expression.cs: Set the type for the int32/int32 argument case.
26006 (Binary::ResolveOperator): Set the return type to boolean for
26007 comparission operators
26009 * typemanager.cs: Remove debugging print code.
26011 (Invocation::Resolve): resolve type.
26013 * class.cs: Allocate a MemberInfo of the correct size, as the code
26014 elsewhere depends on the test to reflect the correct contents.
26016 (Method::) Keep track of parameters, due to System.Reflection holes
26018 (TypeContainer::Populate): Keep track of MethodBuilders to Method
26021 (TypeContainer::FindMembers): Use ArrayList and then copy an array
26022 of the exact size and return that.
26024 (Class::LookupMethodByBuilder): New function that maps
26025 MethodBuilders to its methods. Required to locate the information
26026 on methods because System.Reflection bit us again.
26028 * support.cs: New file, contains an interface ParameterData and
26029 two implementations: ReflectionParameters and InternalParameters
26030 used to access Parameter information. We will need to grow this
26033 * expression.cs (Invocation::GetParameterData): implement a cache
26034 and a wrapper around the ParameterData creation for methods.
26035 (Invocation::OverloadResolve): Use new code.
26037 2001-09-13 Ravi Pratap <ravi@ximian.com>
26039 * class.cs (TypeContainer::EmitField): Remove and move into
26040 (Field::Define): here and modify accordingly.
26041 (Field.FieldBuilder): New member.
26042 (TypeContainer::Populate): Update accordingly.
26043 (TypeContainer::FindMembers): Implement.
26045 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26047 * statement.cs: (VariableInfo::VariableType): New field to be
26048 initialized with the full type once it is resolved.
26050 2001-09-12 Miguel de Icaza <miguel@ximian.com>
26052 * parameter.cs (GetParameterInfo): Use a type cache to compute
26053 things only once, and to reuse this information
26055 * expression.cs (LocalVariableReference::Emit): Implement.
26056 (OpcodeCast::Emit): fix.
26058 (ParameterReference::Resolve): Implement.
26059 (ParameterReference::Emit): Implement.
26061 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
26062 that are expressions need to stay as Expressions.
26064 * typemanager.cs (CSharpName): Returns the C# name of a type if
26067 * expression.cs (Expression::ConvertImplicit): New function that
26068 implements implicit type conversions.
26070 (Expression::ImplicitReferenceConversion): Implements implicit
26071 reference conversions.
26073 (EmptyCast): New type for transparent casts.
26075 (OpcodeCast): New type for casts of types that are performed with
26076 a sequence of bytecodes.
26078 (BoxedCast): New type used for casting value types into reference
26079 types. Emits a box opcode.
26081 (Binary::DoNumericPromotions): Implements numeric promotions of
26082 and computation of the Binary::Type.
26084 (Binary::EmitBranchable): Optimization.
26086 (Binary::Emit): Implement code emission for expressions.
26088 * typemanager.cs (TypeManager): Added two new core types: sbyte
26091 2001-09-12 Ravi Pratap <ravi@ximian.com>
26093 * class.cs (TypeContainer::FindMembers): Method which does exactly
26094 what Type.FindMembers does, only we don't have to use reflection. No
26095 implementation yet.
26097 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
26098 typecontainer objects as we need to get at them.
26099 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
26101 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
26102 typecontainer object.
26104 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
26105 of just a Report object.
26107 2001-09-11 Ravi Pratap <ravi@ximian.com>
26109 * class.cs (Event::Define): Go back to using the prefixes "add_" and
26111 (TypeContainer::Populate): Now define the delegates of the type too.
26112 (TypeContainer.Delegates): Property to access the list of delegates defined
26115 * delegates.cs (Delegate::Define): Implement partially.
26117 * modifiers.cs (TypeAttr): Handle more flags.
26119 2001-09-11 Ravi Pratap <ravi@ximian.com>
26121 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
26123 (Operator::Define): Re-write logic to get types by using the LookupType method
26124 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
26125 (Indexer::Define): Ditto.
26126 (Event::Define): Ditto.
26127 (Property::Define): Ditto.
26129 2001-09-10 Ravi Pratap <ravi@ximian.com>
26131 * class.cs (TypeContainer::Populate): Now define operators too.
26132 (TypeContainer.Operators): New property to access the list of operators
26134 (Operator.OperatorMethodBuilder): New member to hold the method builder
26135 for the operator we are defining.
26136 (Operator::Define): Implement.
26138 2001-09-10 Ravi Pratap <ravi@ximian.com>
26140 * class.cs (Event::Define): Make the prefixes of the accessor methods
26141 addOn_ and removeOn_
26143 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
26144 of the location being passed in too. Ideally, this should go later since all
26145 error reporting should be done through the Report object.
26147 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
26148 (Populate): Iterate thru the indexers we have and define them too.
26149 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
26150 for the get and set accessors.
26151 (Indexer::Define): Implement.
26153 2001-09-09 Miguel de Icaza <miguel@ximian.com>
26155 * expression.cs (Binary::Resolve): Beginning of it. I scratched
26156 my previous implementation, did not work.
26158 * typemanager.cs: Add a couple of missing types (the longs).
26160 * literal.cs: Use TypeManager.bool_type instead of getting it.
26162 * expression.cs (EventExpr): New kind of expressions.
26163 (Expressio::ExprClassFromMemberInfo): finish
26165 2001-09-08 Miguel de Icaza <miguel@ximian.com>
26167 * assign.cs: Emit stores to static fields differently.
26169 2001-09-08 Ravi Pratap <ravi@ximian.com>
26171 * Merge in changes and adjust code to tackle conflicts. Backed out my
26172 code in Assign::Resolve ;-)
26174 2001-09-08 Ravi Pratap <ravi@ximian.com>
26176 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
26177 instead Report.Error and also pass in the location.
26178 (CSharpParser::Lexer): New readonly property to return the reference
26179 to the Tokenizer object.
26180 (declare_local_variables): Use Report.Error with location instead of plain
26184 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
26185 (Operator.CheckBinaryOperator): Ditto.
26187 * cs-parser.jay (operator_declarator): Update accordingly.
26189 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
26190 (CheckBinaryOperator): Same here.
26192 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
26193 on the name without any prefixes of namespace names etc. This is because we
26194 already might have something already fully qualified like
26195 'System.Console.WriteLine'
26197 * assign.cs (Resolve): Begin implementation. Stuck ;-)
26199 2001-09-07 Ravi Pratap <ravi@ximian.com>
26201 * cs-tokenizer.cs (location): Return a string which also contains
26204 * expression.cs (ElementAccess): New class for expressions of the
26205 type 'element access.'
26206 (BaseAccess): New class for expressions of the type 'base access.'
26207 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
26210 * cs-parser.jay (element_access): Implement action.
26211 (base_access): Implement actions.
26212 (checked_expression, unchecked_expression): Implement.
26214 * cs-parser.jay (local_variable_type): Correct and implement.
26215 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
26217 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
26219 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
26220 name and the specifiers.
26222 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
26224 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
26225 making them all public ;-)
26227 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
26230 2001-09-07 Miguel de Icaza <miguel@ximian.com>
26232 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
26234 (FieldExpr, PropertyExprs): New resolved expressions.
26235 (SimpleName::MemberStaticCheck): Perform static checks for access
26236 to non-static fields on static methods. Maybe this should be
26237 generalized for MemberAccesses.
26238 (SimpleName::ResolveSimpleName): More work on simple name
26241 * cs-parser.jay (primary_expression/qualified_identifier): track
26242 the parameter index.
26244 * codegen.cs (CodeGen::Save): Catch save exception, report error.
26245 (EmitContext::EmitBoolExpression): Chain to expression generation
26246 instead of temporary hack.
26247 (::EmitStatementExpression): Put generic expression code generation.
26249 * assign.cs (Assign::Emit): Implement variable assignments to
26250 local variables, parameters and fields.
26252 2001-09-06 Miguel de Icaza <miguel@ximian.com>
26254 * statement.cs (Block::GetVariableInfo): New method, returns the
26255 VariableInfo for a variable name in a block.
26256 (Block::GetVariableType): Implement in terms of GetVariableInfo
26258 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26259 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26261 2001-09-06 Ravi Pratap <ravi@ximian.com>
26263 * cs-parser.jay (operator_declaration): Continue on my quest : update
26264 to take attributes argument.
26265 (event_declaration): Ditto.
26266 (enum_declaration): Ditto.
26267 (indexer_declaration): Ditto.
26269 * class.cs (Operator::Operator): Update constructor accordingly.
26270 (Event::Event): Ditto.
26272 * delegate.cs (Delegate::Delegate): Same here.
26274 * enum.cs (Enum::Enum): Same here.
26276 2001-09-05 Ravi Pratap <ravi@ximian.com>
26278 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26280 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26282 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26283 being passed around as an arraylist.
26284 (Attributes::AddAttribute): Method to add attribute sections.
26286 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26287 (struct_declaration): Update accordingly.
26288 (constant_declaration): Update.
26289 (field_declaration): Update.
26290 (method_header): Update.
26291 (fixed_parameter): Update.
26292 (parameter_array): Ditto.
26293 (property_declaration): Ditto.
26294 (destructor_declaration): Ditto.
26296 * class.cs (Struct::Struct): Update constructors accordingly.
26297 (Class::Class): Ditto.
26298 (Field::Field): Ditto.
26299 (Method::Method): Ditto.
26300 (Property::Property): Ditto.
26301 (TypeContainer::OptAttribute): update property's return type.
26303 * interface.cs (Interface.opt_attributes): New member.
26304 (Interface::Interface): Update to take the extra Attributes argument.
26306 * parameter.cs (Parameter::Parameter): Ditto.
26308 * constant.cs (Constant::Constant): Ditto.
26310 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26311 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26312 the attributes as a parameter.
26313 (InterfaceProperty): Update constructor call.
26314 (InterfaceEvent): Ditto.
26315 (InterfaceMethod): Ditto.
26316 (InterfaceIndexer): Ditto.
26318 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26319 pass the attributes too.
26320 (interface_event_declaration): Ditto.
26321 (interface_property_declaration): Ditto.
26322 (interface_method_declaration): Ditto.
26323 (interface_declaration): Ditto.
26325 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26327 * class.cs (Method::Define): Track the "static Main" definition to
26328 create an entry point.
26330 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26331 EntryPoint if we find it.
26333 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26334 (EmitContext::ig): Make this variable public.
26336 * driver.cs: Make the default output file be the first file name
26337 with the .exe extension.
26339 Detect empty compilations
26341 Handle various kinds of output targets. Handle --target and
26342 rename -t to --dumper.
26344 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26345 methods inherited from Expression return now an Expression. This
26346 will is used during the tree rewriting as we resolve them during
26349 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26350 the spec. Missing entirely is the information about
26351 accessability of elements of it.
26353 (Expression::ExprClassFromMemberInfo): New constructor for
26354 Expressions that creates a fully initialized Expression based on
26355 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26358 (Invocation::Resolve): Begin implementing resolution of invocations.
26360 * literal.cs (StringLiteral): Implement Emit.
26362 2001-09-05 Ravi Pratap <ravi@ximian.com>
26364 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26367 2001-09-04 Ravi Pratap <ravi@ximian.com>
26369 * cs-parser.jay (attribute_arguments): Implement actions.
26370 (attribute): Fix bug in production. Implement action.
26371 (attribute_list): Implement.
26372 (attribute_target): Implement.
26373 (attribute_target_specifier, opt_target_specifier): Implement
26374 (CheckAttributeTarget): New method to check if the attribute target
26376 (attribute_section): Implement.
26377 (opt_attributes): Implement.
26379 * attribute.cs : New file to handle attributes.
26380 (Attribute): Class to hold attribute info.
26382 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26383 (attribute_section): Modify production to use 2 different rules to
26384 achieve the same thing. 1 s/r conflict down !
26385 Clean out commented, useless, non-reducing dimension_separator rules.
26387 * class.cs (TypeContainer.attributes): New member to hold list
26388 of attributes for a type.
26389 (Struct::Struct): Modify to take one more argument, the attribute list.
26390 (Class::Class): Ditto.
26391 (Field::Field): Ditto.
26392 (Method::Method): Ditto.
26393 (Property::Property): Ditto.
26395 * cs-parser.jay (struct_declaration): Update constructor call to
26396 pass in the attributes too.
26397 (class_declaration): Ditto.
26398 (constant_declaration): Ditto.
26399 (field_declaration): Ditto.
26400 (method_header): Ditto.
26401 (fixed_parameter): Ditto.
26402 (parameter_array): Ditto.
26403 (property_declaration): Ditto.
26405 * constant.cs (Constant::Constant): Update constructor similarly.
26406 Use System.Collections.
26408 * parameter.cs (Parameter::Parameter): Update as above.
26410 2001-09-02 Ravi Pratap <ravi@ximian.com>
26412 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26413 (TypeContainer.delegates): New member to hold list of delegates.
26415 * cs-parser.jay (delegate_declaration): Implement the action correctly
26416 this time as I seem to be on crack ;-)
26418 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26420 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26421 tell whether an identifier represents a namespace.
26423 * expression.cs (NamespaceExpr): A namespace expression, used only
26424 temporarly during expression resolution.
26425 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26426 utility functions to resolve names on expressions.
26428 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26430 * codegen.cs: Add hook for StatementExpressions.
26432 * class.cs: Fix inverted test for static flag in methods.
26434 2001-09-02 Ravi Pratap <ravi@ximian.com>
26436 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26437 to make it coincide with MS' number.
26438 (Operator::CheckBinaryOperator): Ditto.
26440 * ../errors/errors.txt : Remove error numbers added earlier.
26442 * ../errors/cs1019.cs : Test case for error # 1019
26444 * ../errros/cs1020.cs : Test case for error # 1020
26446 * cs-parser.jay : Clean out commented cruft.
26447 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26448 used anywhere - non-reducing rule.
26449 (namespace_declarations): Non-reducing rule - comment out.
26451 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26452 with TypeContainer::AddEnum.
26454 * delegate.cs : New file for delegate handling classes.
26455 (Delegate): Class for declaring delegates.
26457 * makefile : Update.
26459 * cs-parser.jay (delegate_declaration): Implement.
26461 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26463 * class.cs (Event::Define): Implement.
26464 (Event.EventBuilder): New member.
26466 * class.cs (TypeContainer::Populate): Update to define all enums and events
26468 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26469 readonly fields for all these cases ?
26471 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26473 * class.cs (Property): Revamp to use the convention of making fields readonly.
26474 Accordingly modify code elsewhere.
26476 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26477 the Define method of the Property class.
26479 * class.cs : Clean up applied patch and update references to variables etc. Fix
26481 (TypeContainer::Populate): Update to define all the properties we have. Also
26482 define all enumerations.
26484 * enum.cs (Define): Implement.
26486 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26488 * cs-parser.jay (overloadable_operator): The semantic value is an
26489 enum of the Operator class.
26490 (operator_declarator): Implement actions.
26491 (operator_declaration): Implement.
26493 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26494 validity of definitions.
26495 (Operator::CheckBinaryOperator): Static method to check for binary operators
26496 (TypeContainer::AddOperator): New method to add an operator to a type.
26498 * cs-parser.jay (indexer_declaration): Added line to actually call the
26499 AddIndexer method so it gets added ;-)
26501 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26502 already taken care of by the MS compiler ?
26504 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26506 * class.cs (Operator): New class for operator declarations.
26507 (Operator::OpType): Enum for the various operators.
26509 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26511 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26512 ostensibly handle this in semantic analysis.
26514 * cs-parser.jay (general_catch_clause): Comment out
26515 (specific_catch_clauses, specific_catch_clause): Ditto.
26516 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26517 (catch_args, opt_catch_args): New productions.
26518 (catch_clause): Rewrite to use the new productions above
26519 (catch_clauses): Modify accordingly.
26520 (opt_catch_clauses): New production to use in try_statement
26521 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26522 and re-write the code in the actions to extract the specific and
26523 general catch clauses by being a little smart ;-)
26525 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26526 Hooray, try and catch statements parse fine !
26528 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26530 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26531 string from the hashtable of variables.
26533 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26534 I end up making that mistake ;-)
26535 (catch_clauses): Fixed gross error which made Key and Value of the
26536 DictionaryEntry the same : $1 !!
26538 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26540 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26542 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26543 when the add and remove accessors are specified.
26545 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26547 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26548 information about indexer_declarator.
26549 (indexer_declarator): Implement actions.
26550 (parsing_indexer): New local boolean used to keep track of whether
26551 we are parsing indexers or properties. This is necessary because
26552 implicit_parameters come into picture even for the get accessor in the
26553 case of an indexer.
26554 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26556 * class.cs (Indexer): New class for indexer declarations.
26557 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26558 (TypeContainer::indexers): New member to hold list of indexers for the
26561 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26563 * cs-parser.jay (add_accessor_declaration): Implement action.
26564 (remove_accessor_declaration): Implement action.
26565 (event_accessors_declaration): Implement
26566 (variable_declarators): swap statements for first rule - trivial.
26568 * class.cs (Event): New class to hold information about event
26570 (TypeContainer::AddEvent): New method to add an event to a type
26571 (TypeContainer::events): New member to hold list of events.
26573 * cs-parser.jay (event_declaration): Implement actions.
26575 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26577 * cs-parser.jay (dim_separators): Implement. Make it a string
26578 concatenating all the commas together, just as they appear.
26579 (opt_dim_separators): Modify accordingly
26580 (rank_specifiers): Update accordingly. Basically do the same
26581 thing - instead, collect the brackets here.
26582 (opt_rank_sepcifiers): Modify accordingly.
26583 (array_type): Modify to actually return the complete type string
26584 instead of ignoring the rank_specifiers.
26585 (expression_list): Implement to collect the expressions
26586 (variable_initializer): Implement. We make it a list of expressions
26587 essentially so that we can handle the array_initializer case neatly too.
26588 (variable_initializer_list): Implement.
26589 (array_initializer): Make it a list of variable_initializers
26590 (opt_array_initializer): Modify accordingly.
26592 * expression.cs (New::NType): Add enumeration to help us
26593 keep track of whether we have an object/delegate creation
26594 or an array creation.
26595 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26596 members to hold data about array creation.
26597 (New:New): Modify to update NewType
26598 (New:New): New Overloaded contructor for the array creation
26601 * cs-parser.jay (array_creation_expression): Implement to call
26602 the overloaded New constructor.
26604 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26606 * class.cs (TypeContainer::Constructors): Return member
26607 constructors instead of returning null.
26609 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26611 * typemanager.cs (InitCoreTypes): Initialize the various core
26612 types after we have populated the type manager with the user
26613 defined types (this distinction will be important later while
26614 compiling corlib.dll)
26616 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26617 on Expression Classification. Now all expressions have a method
26618 `Resolve' and a method `Emit'.
26620 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26621 generation from working. Also add some temporary debugging
26624 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26626 * codegen.cs: Lots of code generation pieces. This is only the
26627 beginning, will continue tomorrow with more touches of polish. We
26628 handle the fundamentals of if, while, do, for, return. Others are
26629 trickier and I need to start working on invocations soon.
26631 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26634 * codegen.cs (EmitContext): New struct, used during code
26635 emission to keep a context. Most of the code generation will be
26638 * cs-parser.jay: Add embedded blocks to the list of statements of
26639 this block. So code generation proceeds in a top down fashion.
26641 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26643 * statement.cs: Add support for multiple child blocks.
26645 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26647 * codegen.cs (EmitCode): New function, will emit the code for a
26648 Block of code given a TypeContainer and its ILGenerator.
26650 * statement.cs (Block): Standard public readonly optimization.
26651 (Block::Block constructors): Link children.
26652 (Block::Child): Child Linker.
26653 (Block::EmitVariables): Emits IL variable declarations.
26655 * class.cs: Drop support for MethodGroups here, delay until
26657 (Method::): Applied the same simplification that I did before, and
26658 move from Properties to public readonly fields.
26659 (Method::ParameterTypes): Returns the parameter types for the
26660 function, and implements a cache that will be useful later when I
26661 do error checking and the semantic analysis on the methods is
26663 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26664 and made a method, optional argument tells whether this is a class
26665 or a structure to apply the `has-this' bit.
26666 (Method::GetCallingConvention): Implement, returns the calling
26668 (Method::Define): Defines the type, a second pass is performed
26669 later to populate the methods.
26671 (Constructor::ParameterTypes): implement a cache similar to the
26672 one on Method::ParameterTypes, useful later when we do semantic
26675 (TypeContainer::EmitMethod): New method. Emits methods.
26677 * expression.cs: Removed MethodGroup class from here.
26679 * parameter.cs (Parameters::GetCallingConvention): new method.
26681 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26683 * class.cs (TypeContainer::Populate): Drop RootContext from the
26686 (Constructor::CallingConvention): Returns the calling convention.
26687 (Constructor::ParameterTypes): Returns the constructor parameter
26690 (TypeContainer::AddConstructor): Keep track of default constructor
26691 and the default static constructor.
26693 (Constructor::) Another class that starts using `public readonly'
26694 instead of properties.
26696 (Constructor::IsDefault): Whether this is a default constructor.
26698 (Field::) use readonly public fields instead of properties also.
26700 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26701 track of static constructors; If none is used, turn on
26702 BeforeFieldInit in the TypeAttributes.
26704 * cs-parser.jay (opt_argument_list): now the return can be null
26705 for the cases where there are no arguments.
26707 (constructor_declarator): If there is no implicit `base' or
26708 `this', then invoke the default parent constructor.
26710 * modifiers.cs (MethodAttr): New static function maps a set of
26711 modifiers flags into a MethodAttributes enum
26712 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26713 MethodAttr, TypeAttr to represent the various mappings where the
26714 modifiers are used.
26715 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26717 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26719 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26722 * interface.cs (PopulateIndexer): Implemented the code generator
26723 for interface indexers.
26725 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26727 * interface.cs (InterfaceMemberBase): Now we track the new status
26730 (PopulateProperty): Implement property population. Woohoo! Got
26731 Methods and Properties going today.
26733 Removed all the properties for interfaces, and replaced them with
26734 `public readonly' fields.
26736 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26738 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26739 initialize their hashtables/arraylists only when they are needed
26740 instead of doing this always.
26742 * parameter.cs: Handle refs and out parameters.
26744 * cs-parser.jay: Use an ArrayList to construct the arguments
26745 instead of the ParameterCollection, and then cast that to a
26748 * parameter.cs: Drop the use of ParameterCollection and use
26749 instead arrays of Parameters.
26751 (GetParameterInfo): Use the Type, not the Name when resolving
26754 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26756 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26757 and instead use public readonly fields.
26759 * class.cs: Put back walking code for type containers.
26761 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26763 * class.cs (MakeConstant): Code to define constants.
26765 * rootcontext.cs (LookupType): New function. Used to locate types
26768 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26770 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26771 this System.Reflection code is. Kudos to Microsoft
26773 * typemanager.cs: Implement a type cache and avoid loading all
26774 types at boot time. Wrap in LookupType the internals. This made
26775 the compiler so much faster. Wow. I rule!
26777 * driver.cs: Make sure we always load mscorlib first (for
26778 debugging purposes, nothing really important).
26780 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26781 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26783 * rootcontext.cs: Lookup types on their namespace; Lookup types
26784 on namespaces that have been imported using the `using' keyword.
26786 * class.cs (TypeContainer::TypeAttr): Virtualize.
26787 (Class::TypeAttr): Return attributes suitable for this bad boy.
26788 (Struct::TypeAttr): ditto.
26789 Handle nested classes.
26790 (TypeContainer::) Remove all the type visiting code, it is now
26791 replaced with the rootcontext.cs code
26793 * rootcontext.cs (GetClassBases): Added support for structs.
26795 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26797 * interface.cs, statement.cs, class.cs, parameter.cs,
26798 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26799 Drop use of TypeRefs, and use strings instead.
26801 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26805 * class.cs (Struct::Struct): set the SEALED flags after
26806 checking the modifiers.
26807 (TypeContainer::TypeAttr): new property, returns the
26808 TypeAttributes for a class.
26810 * cs-parser.jay (type_list): Oops, list production was creating a
26811 new list of base types.
26813 * rootcontext.cs (StdLib): New property.
26814 (GetInterfaceTypeByName): returns an interface by type name, and
26815 encapsulates error handling here.
26816 (GetInterfaces): simplified.
26817 (ResolveTree): Encapsulated all the tree resolution here.
26818 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26821 * driver.cs: Add support for --nostdlib, to avoid loading the
26822 default assemblies.
26823 (Main): Do not put tree resolution here.
26825 * rootcontext.cs: Beginning of the class resolution.
26827 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26829 * rootcontext.cs: Provide better error reporting.
26831 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26833 * rootcontext.cs (CreateInterface): Handle the case where there
26834 are no parent interfaces.
26836 (CloseTypes): Routine to flush types at the end.
26837 (CreateInterface): Track types.
26838 (GetInterfaces): Returns an array of Types from the list of
26839 defined interfaces.
26841 * typemanager.c (AddUserType): Mechanism to track user types (puts
26842 the type on the global type hash, and allows us to close it at the
26845 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26847 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26848 RecordInterface instead.
26850 * cs-parser.jay: Updated to reflect changes above.
26852 * decl.cs (Definition): Keep track of the TypeBuilder type that
26853 represents this type here. Not sure we will use it in the long
26854 run, but wont hurt for now.
26856 * driver.cs: Smaller changes to accomodate the new code.
26858 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26861 * rootcontext.cs (CreateInterface): New method, used to create
26862 the System.TypeBuilder type for interfaces.
26863 (ResolveInterfaces): new entry point to resolve the interface
26865 (CodeGen): Property, used to keep track of the code generator.
26867 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26869 * cs-parser.jay: Add a second production for delegate_declaration
26872 (enum_body): Put an opt_comma here instead of putting it on
26873 enum_body or enum_member_declarations so we can handle trailing
26874 commas on enumeration members. Gets rid of a shift/reduce.
26876 (type_list): Need a COMMA in the middle.
26878 (indexer_declaration): Tell tokenizer to recognize get/set
26880 * Remove old targets.
26882 * Re-add the parser target.
26884 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26886 * cs-parser.jay: Add precendence rules for a number of operators
26887 ot reduce the number of shift/reduce conflicts in the grammar.
26889 2001-07-17 Miguel de Icaza <miguel@ximian.com>
26891 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
26894 Get rid of old crufty code.
26896 * rootcontext.cs: Use this to keep track of the parsed
26897 representation and the defined types available to the program.
26899 * gen-treedump.cs: adjust for new convention.
26901 * type.cs: Split out the type manager, and the assembly builder
26904 * typemanager.cs: the type manager will live here now.
26906 * cil-codegen.cs: And the code generator here.
26908 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
26910 * makefile: Fixed up for easy making.
26912 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26914 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
26917 (unary_expression): Expand pre_increment_expression and
26918 post_decrement_expression to reduce a shift/reduce.
26920 2001-07-11 Simon Cozens
26922 * cs-tokenizer.cs: Hex numbers should begin with a 0.
26924 Improve allow_keyword_as_indent name.
26926 2001-06-19 Miguel de Icaza <miguel@ximian.com>
26928 * Adjustments for Beta2.
26930 2001-06-13 Miguel de Icaza <miguel@ximian.com>
26932 * decl.cs: Added `Define' abstract method.
26933 (InTransit): new property, used to catch recursive definitions.
26935 * interface.cs: Implement `Define'.
26937 * modifiers.cs: Map Modifiers.constants to
26938 System.Reflection.TypeAttribute flags.
26940 * class.cs: Keep track of types and user-defined types.
26941 (BuilderInit): New method for creating an assembly
26942 (ResolveType): New function to launch the resolution process, only
26943 used by interfaces for now.
26945 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
26946 that are inserted into the name space.
26948 2001-06-08 Miguel de Icaza <miguel@ximian.com>
26950 * ARGH. I have screwed up my tree so many times due to the use of
26951 rsync rather than using CVS. Going to fix this at once.
26953 * driver.cs: Objetify driver. Load assemblies, use assemblies to
26956 2001-06-07 Miguel de Icaza <miguel@ximian.com>
26958 * Experiment successful: Use System.Type rather that our own
26961 2001-05-25 Miguel de Icaza <miguel@ximian.com>
26963 * cs-parser.jay: Removed nsAliases from here.
26965 Use new namespaces, handle `using XXX;'
26967 * namespace.cs: Reimplemented namespace handling, use a recursive
26968 definition of the class. Now we can keep track of using clauses
26969 and catch invalid using clauses.
26971 2001-05-24 Miguel de Icaza <miguel@ximian.com>
26973 * gen-treedump.cs: Adapted for all the renaming.
26975 * expression.cs (Expression): this class now has a Type property
26976 which returns an expression Type.
26978 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
26979 `Type', as this has a different meaning now in the base
26981 2001-05-22 Miguel de Icaza <miguel@ximian.com>
26983 * interface.cs, class.cs: Removed from all the sources the
26984 references to signature computation, as we can not do method
26985 signature computation during the parsing time, as we are not
26986 trying to solve at that point distinguishing:
26990 void a (NS.Blah x) {}
26993 Which depending on the context might be valid or not, as we do not
26994 know if Blah is the same thing as NS.Blah at that point.
26996 * Redid everything so the code uses TypeRefs now instead of
26997 Types. TypeRefs are just temporary type placeholders, that need
26998 to be resolved. They initially have a pointer to a string and the
26999 current scope in which they are used. This is used later by the
27000 compiler to resolve the reference to an actual Type.
27002 * DeclSpace is no longer a CIR.Type, and neither are
27003 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
27004 are all DeclSpaces, but no Types.
27006 * type.cs (TypeRefManager): This implements the TypeRef manager,
27007 which keeps track of all the types that need to be resolved after
27008 the parsing has finished.
27010 2001-05-13 Miguel de Icaza <miguel@ximian.com>
27012 * ARGH. We are going to have to store `foreach' as a class rather
27013 than resolving it, as we need to verify error 1579 after name
27014 resolution. *OR* we could keep a flag that says `This request to
27015 IEnumerator comes from a foreach statement' which we can then use
27016 to generate the error.
27018 2001-05-10 Miguel de Icaza <miguel@ximian.com>
27020 * class.cs (TypeContainer.AddMethod): we now add methods to the
27021 MethodGroup instead of the method hashtable.
27023 * expression.cs: Add MethodGroup abstraction, which gets us one
27024 step closer to the specification in the way we handle method
27027 * cs-parser.jay (primary_expression): qualified_identifier now
27028 tried to match up an identifier to a local variable reference or
27029 to a parameter reference.
27031 current_local_parameters is now a parser global variable that
27032 points to the current parameters for the block, used during name
27035 (property_declaration): Now creates an implicit `value' argument to
27038 2001-05-09 Miguel de Icaza <miguel@ximian.com>
27040 * parameter.cs: Do not use `param' arguments as part of the
27041 signature, per the spec.
27043 2001-05-08 Miguel de Icaza <miguel@ximian.com>
27045 * decl.cs: Base class for classes, structs and interfaces. This
27046 is the "Declaration Space"
27048 * cs-parser.jay: Use CheckDef for checking declaration errors
27049 instead of having one on each function.
27051 * class.cs: Factor out some code for handling error handling in
27052 accordance to the "Declarations" section in the "Basic Concepts"
27053 chapter in the ECMA C# spec.
27055 * interface.cs: Make all interface member classes derive from
27056 InterfaceMemberBase.
27058 2001-05-07 Miguel de Icaza <miguel@ximian.com>
27060 * Many things: all interfaces are parsed and generated in
27061 gen-treedump. Support for member variables, constructors,
27062 destructors, properties, constants is there.
27064 Beginning of the IL backend, but very little done, just there for
27067 2001-04-29 Miguel de Icaza <miguel@ximian.com>
27069 * cs-parser.jay: Fix labeled statement.
27071 * cs-tokenizer.cs (escape): Escape " and ' always.
27072 ref_line, ref_name: keep track of the line/filename as instructed
27073 by #line by the compiler.
27076 2001-04-27 Miguel de Icaza <miguel@ximian.com>
27078 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
27079 to match the values in System.CodeDOM.
27081 Divid renamed to Divide.
27083 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
27085 (Statements.set): remove.
27087 * System.CodeDOM/CodeCatchClause.cs: always have a valid
27090 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
27091 falseStatements always have valid values.
27093 * cs-parser.jay: Use System.CodeDOM now.