1 2007-06-20 Marek Safar <marek.safar@gmail.com>
3 * cs-parser.jay: Reworked var keyword handling. We cannot handle var as
4 static keyword because var becomes keyword only if no type with the var
5 name exists in the scope of variable which uses var declaration.
7 2007-06-18 Marek Safar <marek.safar@gmail.com>
9 * cs-parser.jay: Add implicitly typed local variable checks.
11 2007-06-15 Marek Safar <marek.safar@gmail.com>
13 * cs-parser.jay: Correctly split generic arguments and generic
14 parameters. Correctly implemented typeof of generic unbound types.
16 2007-06-14 Marek Safar <marek.safar@gmail.com>
18 * cs-parser.jay: Assembly and module attributes must precede all other
19 elements except using clauses and extern alias declarations.
21 2007-06-08 Marek Safar <marek.safar@gmail.com>
23 * cs-parser.jay: Uses newly defined GroupBy class.
25 * linq.cs (GroupBy): Implemented.
26 (AQueryClause.BuildQueryClause): Refactored to allow customize query
29 2007-06-08 Marek Safar <marek.safar@gmail.com>
31 * generics.cs (InferTypeArguments): Uses AnonymousMethodExpression
34 2007-06-06 Marek Safar <marek.safar@gmail.com>
36 * generics.cs (TypeArguments): New contructor fow known number of
39 2007-06-04 Raja R Harinath <rharinath@novell.com>
41 * linq.cs (Select.DoResolve): Pass the created parameters to the
44 2007-05-29 Raja R Harinath <rharinath@novell.com>
46 * cs-parser.jay: Update to changes in ToplevelBlock.
47 (top_current_block): Remove.
49 2007-05-27 Raja R Harinath <harinath@gmail.com>
51 * cs-parser.jay: Update to new ExplicitBlock invariant.
53 * cs-parser.jay: Update to changes introduced in Block and
56 2007-05-25 Raja R Harinath <rharinath@novell.com>
58 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
59 modifying current_block directly.
61 2007-05-22 Scott Peterson <lunchtimemama@gmail.com>
63 * cs-parser.jay: Implemented automatic properties (C# 3.0)
65 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
67 * cs-parser.jay: Improved grammar for object and collection
70 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
72 This code is contributed under the MIT X11 license
74 * cs-parser.jay: Added support for C# 3.0 language features:
75 Variable type inference (the "var" keyword)
79 Collection initialization
81 2007-05-06 Marek Safar <marek.safar@gmail.com>
84 * cs-parser.jay: Add special handling for coalescing operator.
86 2007-05-02 Raja R Harinath <rharinath@novell.com>
88 Fix regression in cs0631-3.cs
89 * cs-parser.jay (operator_declarator): Add opt_attributes to error
90 fallback. Make error fallback catch more cases.
92 2007-05-01 Miguel de Icaza <miguel@novell.com>
94 * cs-parser.jay: Allow parameters in operator declarations to have
97 2007-04-27 Miguel de Icaza <miguel@novell.com>
99 * generic.cs (TypeManager.LambdaInfer): now this routine will
100 make only one inference from the list of lambda expression that
101 have not participated in inferring a type.
103 (TypeManager.InferTypeArguments): The logic that drives the type
104 inference in lambda expressions is now driven here.
106 2007-04-23 Miguel de Icaza <miguel@novell.com>
108 * generic.cs: Large update to LambdaInfer, this is merely an
109 update to start the lambda type inference. It is by no means
110 complete. It is currently merely able to build a sample program
111 (with no iteration for the type parameters).
113 2007-04-12 Duncan Mak <duncan@a-chinaman.com>
115 * cs-parser.jay (interface_method_declaration_body): Fixed typo.
117 2007-04-08 Marek Safar <marek.safar@gmail.com>
119 * cs-parser.jay, linq.cs: First select implementation (hacky).
121 * generic.cs (InferTypeArguments): Simplified.
123 2007-03-31 Marek Safar <marek.safar@gmail.com>
125 * generic.cs (InferTypeArguments): Restored validation check.
126 (InferTypeArguments): Move all logic to Compatible method for re-usability.
128 2007-03-25 Marek Safar <marek.safar@gmail.com>
130 * generic.cs (InferTypeArguments): Infer arguments before they are used
131 for compatibility check.
133 2007-03-15 Marek Safar <marek.safar@gmail.com>
135 * generic.cs (InflatedConstraints): Fixed the check order.
136 (TypeArguments.Resolve): Small optimization for generic parameters.
137 (InferTypeArguments): Add infering support for anonymous methods.
139 2007-03-15 Martin Baulig <martin@ximian.com>
144 (TypeParameter.HasConstructorConstraint): Removed.
145 (ConstraintChecker.HasDefaultConstructor): Removed the
146 `TypeBuilder' argument here; correctly check for the ctor
147 constraint on type parameters.
149 2007-03-15 Martin Baulig <martin@ximian.com>
154 (TypeParameter): Create a `MemberCache' here as well. Note that
155 we need to create this on-demand when it's actually used.
157 2007-03-10 Marek Safar <marek.safar@gmail.com>
159 * generic.cs (TypeArguments.Resolve): Avoid redundant checks.
161 2007-03-09 Raja R Harinath <rharinath@novell.com>
163 * cs-parser.jay (WHERE): Move before QUERY_FIRST_TOKEN. 'where'
164 is a valid keyword outside a linq expression too.
166 2007-03-03 Marek Safar <marek.safar@gmail.com>
168 * cs-parser.jay: Implemented basic linq grammar.
170 * linq.cs: New file for hosting query specific classes.
172 2007-02-26 Marek Safar <marek.safar@gmail.com>
174 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
176 2007-02-20 Marek Safar <marek.safar@gmail.com>
179 * cs-parser.jay: Anonymous container starts at constructor declaration
180 and not at block beginning because it has to be usable in constructor
183 2007-02-18 Marek Safar <marek.safar@gmail.com>
185 A fix for bug #80493 by Atsushi Enomoto
186 * cs-parser.jay: Ignore invalid attribute target.
188 2007-02-15 Miguel de Icaza <miguel@novell.com>
190 * Remove the call to SetExpression for lambda expressions, we do
191 not actually need it.
193 Remove expression tracking code as its not needed.
195 2007-02-11 Miguel de Icaza <miguel@novell.com>
197 * cs-parser.jay (lambda_expression_body): when the body is an
198 expression add a statement of the form:
200 contextual-return expression.
202 Where `contextual-return' is similar to `return', the difference
203 being that if the delegate that the lambda will be converted to
204 has a void return type, it will check that the result is a
205 ExpressionStatement and the result is a plain ret (no return
206 values on the stack). If the return type of the delegate is of a
207 given type, this turns into a return with a value and does the
208 regular checking to check that the computed value can be
209 implicitly converted to the delegate return.
211 2007-01-30 Miguel de Icaza <miguel@novell.com>
213 * cs-parser.jay (anonymous_method_expression): move the
214 before/after productions to the start_anonymous and end_anonymous
215 methods so the code can be reused for lambda functions.
217 (lambda_expression_body): wrap expressions implicitly into a
220 (block): factor out the setup/teardown of parsing a block so we
221 can reuse that in lambda_expression_body
223 (lambda_expression): use new anonymous method helper methods.
225 2007-01-29 Miguel de Icaza <miguel@novell.com>
227 * cs-parser.jay: oob_stack make it static (am guessing that is why
228 we no longer initialize it anymore) and reuse it across
231 2007-01-28 Miguel de Icaza <miguel@novell.com>
233 * cs-parser.jay (open_parens): Introduce new non-terminal that
234 abstracts OPEN_PARENS and OPEN_PARENS_LAMBDA as the later can now
235 be returned in places where types are followed by identifiers
236 (this is expected in declaration, fixed, using, foreach and catch
239 Use open_parens in those places, keep OPEN_PARENS in the
242 cs-parser.jay: New grammar bits for parsing lambda expressions.
244 2007-01-28 Raja R Harinath <rharinath@novell.com>
246 Fix #80534, gtest-309.cs
247 * generic.cs (UnifyType): Rename from InferType. Make unification
248 of generic insts simpler and don't insist on inferring all generic
249 parameters in a single generic inst unification.
251 (InferGenericInstance): Remove.
252 Analysis and initial patch by David Mitchell <dmitchell@logos.com>.
254 2007-01-20 Marek Safar <marek.safar@gmail.com>
256 * cs-parser.jay: Better parameter error handling.
258 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
259 Raja R Harinath <rharinath@novell.com>
261 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
262 Note the order in which accessors are declared in the source.
264 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
266 * generic.cs (TypeParameter.FindMembers): Use the generic
267 constraints, not the constraints to check for methods (first fix
270 2006-12-30 Marek Safar <marek.safar@gmail.com>
272 * cs-parser.jay: Better syntax errors handling.
274 2006-11-21 Marek Safar <marek.safar@gmail.com>
276 * cs-parser.jay: Tiny change to work with mcs tokenizer.
278 * cs-tokenizer.cs: Remove after unification with mcs.
280 2006-10-28 Marek Safar <marek.safar@gmail.com>
283 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
286 2006-10-26 Marek Safar <marek.safar@gmail.com>
289 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
291 2006-10-25 Brian Crowell <brian@fluggo.com>
294 * generic.cs (CheckConstraints): Allow generic parameters with
295 inheritance constraints to satisfy reference type constraints.
297 2006-10-09 Martin Baulig <martin@ximian.com>
300 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
302 2006-09-25 Martin Baulig <martin@ximian.com>
304 * class.cs: Remove after unification with mcs source.
306 2006-09-24 Raja R Harinath <harinath@gmail.com>
308 * convert.cs: Remove after unification with mcs source.
310 2006-09-24 Marek Safar <marek.safar@seznam.cz>
312 * class.cs (MemberBase.VerifyClsCompliance): When method has type
313 parameters verify them as well.
315 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
316 the type parameter constraints.
317 (Generics.VerifyClsCompliance): Ditto.
319 2006-09-24 Marek Safar <marek.safar@seznam.cz>
321 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
322 for anonymous block with out argument.
324 2006-09-24 Marek Safar <marek.safar@seznam.cz>
326 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
327 not used private events only.
329 2006-09-23 Marek Safar <marek.safar@seznam.cz>
331 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
333 * cs-parser.jay: Parse correctly cast of default (T).
335 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
336 Store original type via EmptyConstantCast.
338 2006-09-22 Martin Baulig <martin@ximian.com>
340 * delegate.cs: Removed; this file is now shared with mcs.
342 * attribute.cs: Removed; this file is now shared with mcs.
344 2006-09-22 Martin Baulig <martin@ximian.com>
346 * ecore.cs: Removed; this file is now shared with mcs.
348 2006-09-21 Marek Safar <marek.safar@seznam.cz>
350 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
352 * ecore.cs (NullCast): Derives from NullConstant.
354 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
357 2006-09-21 Martin Baulig <martin@ximian.com>
359 * decl.cs: Removed; this file is now shared with mcs.
361 2006-09-21 Raja R Harinath <rharinath@novell.com>
363 * rootcontext.cs: Remove after unification with mcs source.
365 * report.cs: Remove after unification with mcs source.
366 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
368 (InitGenerics, CleanUpGenerics): Remove.
370 * support.cs: Remove after unification with mcs source.
372 2006-09-20 Raja R Harinath <rharinath@novell.com>
374 * codegen.cs: Remove after unification with mcs source.
376 2006-09-19 Martin Baulig <martin@ximian.com>
378 * expression.cs: Removed; this file is now shared with mcs.
380 2006-09-19 Martin Baulig <martin@ximian.com>
383 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
384 (TypeManager.DropGenericTypeArguments): Likewise.
385 (TypeManager.DropGenericMethodArguments): Likewise.
386 (TypeManager.GetTypeArguments): Likewise.
387 (TypeManager.HasGenericArguments): Likewise.
389 2006-09-19 Martin Baulig <martin@ximian.com>
391 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
393 2006-09-19 Martin Baulig <martin@ximian.com>
395 * typemanager.cs: Removed; this file is now shared with mcs.
397 2006-09-16 Raja R Harinath <rharinath@novell.com>
399 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
400 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
402 2006-09-16 Marek Safar <marek.safar@seznam.cz>
405 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
406 only if parent type is class.
407 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
410 2006-09-15 Marek Safar <marek.safar@seznam.cz>
413 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
415 * typemanager.cs(CSharpName): Converts NullType to null.
417 2006-09-15 Martin Baulig <martin@ximian.com>
419 * pending.cs: Removed; this file is now shared with mcs.
421 2006-09-15 Martin Baulig <martin@ximian.com>
423 * statement.cs: Removed; this file is now shared with mcs.
425 2006-09-15 Martin Baulig <martin@ximian.com>
427 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
429 * driver.cs: Removed the `--broken-cycles' argument.
431 2006-09-15 Martin Baulig <martin@ximian.com>
433 * namespace.cs: Removed; this file is now shared with mcs.
435 2006-09-15 Martin Baulig <martin@ximian.com>
437 * decl.cs (MemberName): Minor code cleanups.
439 2006-09-15 Martin Baulig <martin@ximian.com>
441 * parameter.cs: Removed; this file is now shared with mcs.
443 2006-09-15 Martin Baulig <martin@ximian.com>
445 * enum.cs: Removed; this file is now shared with mcs.
447 2006-09-15 Martin Baulig <martin@ximian.com>
449 * Makefile: Define `GMCS_SOURCE'.
451 * flowanalysis.cs: Removed; this file is now shared with mcs.
453 2006-09-15 Martin Baulig <martin@ximian.com>
455 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
456 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
457 doc.cs - they are now shared with mcs.
459 * gmcs.exe.sources: Include these files from ../mcs/.
461 2006-09-15 Martin Baulig <martin@ximian.com>
463 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
464 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
466 2006-09-14 Marek Safar <marek.safar@seznam.cz>
468 * assign.cs, ecore.cs, expression.cs: Share error message text.
469 * class.cs (FieldMember.Define): Check for variable of static type.
470 * decl.cs (check_type_parameter): Report correct type name.
471 * driver.cs (LoadAssembly): Uses error output for errors.
472 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
473 (TypeArguments.Resolve): Static class cannot be used as an argument.
474 * statement.cs (ResolveMeta): Constants cannot be generic types.
476 2006-09-12 Martin Baulig <martin@ximian.com>
478 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
480 * convert.cs (Convert.Array_To_IList): Moved here and correctly
481 implement it; fixes #79345.
483 2006-09-08 Marek Safar <marek.safar@seznam.cz>
485 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
487 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
489 * generic.cs: Improved error messages.
490 * typemanager.cs (RemoveGenericArity): Made public.
492 2006-09-08 Martin Baulig <martin@ximian.com>
494 * typemanager.cs (TypeManager.interlocked_type): New public field.
495 (TypeManager.int_interlocked_compare-exchange): New public field.
496 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
497 enumerator types here and call InitGenericCoreTypes().
498 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
499 after calling InitEnumUnderlyingTypes().
502 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
503 `classes_second_stage'.
505 2006-09-07 Marek Safar <marek.safar@seznam.cz>
507 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
509 * statement.cs (Block.Variables): Made public.
511 2006-09-07 Martin Baulig <martin@ximian.com>
514 (MainDriver): Revert r62663 from Marek; see #70506 for details.
516 2006-09-01 Martin Baulig <martin@ximian.com>
519 (TypeManager.IsIList): Also handle base classes and interfaces.
521 2006-09-01 Raja R Harinath <rharinath@novell.com>
524 * expression.cs (Invocation.MoreSpecific): Check for reference
527 2006-08-29 Miguel de Icaza <miguel@novell.com>
529 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
531 2006-08-17 Miguel de Icaza <miguel@novell.com>
533 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
534 #52019 and #79064, the use of the \uXXXX sequence in source code
535 to represent unicode characters.
537 2006-08-15 Marek Safar <marek.safar@seznam.cz>
539 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
541 * class.cs, ecore.cs, statement.cs: Merged to one error message.
543 2006-08-14 Raja R Harinath <rharinath@novell.com>
546 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
547 parameter too. This only avoids a parse error -- the semantic
548 error is caught elsewhere.
550 2006-08-13 Miguel de Icaza <miguel@novell.com>
552 * assign.cs: Catch attempts to assign to a method groups in += and
555 2006-08-13 Marek Safar <marek.safar@seznam.cz>
558 * cs-parser.jay: Don't destroy current array type by typeof of array's.
560 2006-08-12 Marek Safar <marek.safar@seznam.cz>
562 * cs-parser.jay: Check whether a constraint clause has already been
563 specified for type parameter.
564 * generic.cs (Constraints): Exposed location.
566 2006-08-12 Marek Safar <marek.safar@seznam.cz>
568 * class.cs (Method.Define): Issue a warning when generic method looks like
570 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
572 * report.cs: New warning number.
574 2006-08-09 Marek Safar <marek.safar@seznam.cz>
576 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
578 * decl.cs (MemberCache.FindMembers): When container is interface we need to
579 search all base interfaces as a member can be ambiguous.
580 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
581 Constructor member type filter.
582 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
583 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
584 reporting for returned memberinfos.
585 * report.cs: Updated.
586 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
587 version to work on all runtimes.
588 (TypeManager.RealMemberLookup): Removed members filtering.
590 2006-08-08 Raja R Harinath <rharinath@novell.com>
592 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
593 (PropertyExpr.EmitAssign): Likewise.
594 * expression.cs (Indirection.EmitAssign): Likewise.
595 (LocalVariableReference.EmitAssign): Likewise.
596 (ParameterReference.EmitAssign): Likewise.
597 (Invocation.EmitArguments): Likewise.
598 (ArrayAccess.EmitAssign): Likewise.
599 (IndexerAccess.EmitAssign): Likewise.
600 (This.EmitAssign): Likewise.
601 (ConditionalLogicalOperator.Emit): Likewise.
604 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
605 instead of ArrayList. If the hashtable has a LocalBuilder, don't
606 leave it in after returning it.
607 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
609 2006-08-06 Marek Safar <marek.safar@seznam.cz>
611 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
614 2006-08-05 Marek Safar <marek.safar@seznam.cz>
616 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
617 with different type names.
618 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
620 2006-08-03 Raja R Harinath <rharinath@novell.com>
622 Fix cs0146-3.cs and cs0146-4.cs.
623 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
624 enclosing types don't depend on the current type.
626 2006-08-02 Raja R Harinath <rharinath@novell.com>
629 * class.cs (TypeContainer.DoDefineMembers): Use
630 FindBaseMemberWithSameName on Parent, since we're interested in
631 whether we hide inherited members or not.
632 (FindBaseMemberWithSameName): Make slightly more robust.
635 * codegen.cs (IResolveContext.GenericDeclContainer): New.
636 (EmitContext): Implement new interface requirement.
637 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
638 * decl.cs (MemberCore): Likewise.
639 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
640 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
641 ec.GenericDeclContainer to check for generic parameters.
642 (SimpleName.DoSimpleNameResolve): Likewise.
643 * generic.cs (TypeParameter.DeclContainer): Remove override.
645 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
646 declspaces for doppelgangers too.
647 (UsingEntry): Implement IResolveContext.
648 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
649 'this' as the resolve context.
650 (LocalAliasEntry): Likewise.
652 Implement parts of #77403
653 * roottypes.cs (RootDeclSpace): New. Used to represent the
654 toplevel declaration space. Each namespace declaration introduces
655 a "partial" root declaretion space.
656 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
657 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
658 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
659 from 'current_namespace.SlaveDeclSpace'.
660 (namespace_declaration): Likewise.
661 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
662 check. It can't happen now.
663 * decl.cs (DeclSpace.LookupType): Likewise.
664 * driver.cs (MainDriver): Sanity check.
666 2006-08-01 Raja R Harinath <rharinath@novell.com>
668 * decl.cs (DeclSpace.FindNestedType): Remove.
669 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
670 LookupTypeContainer to get the container of the nested type.
671 * class.cs (TypeContainer.FindNestedType): Make non-override.
673 2006-07-31 Raja R Harinath <rharinath@novell.com>
675 * decl.cs (DeclSpace.PartialContainer): Move field from ...
676 * class.cs (TypeContainer.PartialContainer): ... here.
677 (TypeContainer.AddBasesForPart): New helper.
678 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
680 * cs-parser.jay (current_class): Convert to DeclSpace.
681 (struct_declaration, interface_declaration, class_declaration):
682 Use AddBasesForPart instead of .Bases directly.
683 * const.cs, iterators.cs: Update to changes.
685 2006-07-28 Raja R Harinath <rharinath@novell.com>
687 * class.cs (TypeContainer.AddMemberType): Rename from
689 (TypeContainer.AddMember): Rename from AddToMemberContainer.
690 (AddTypeContainer): New. Combine AddClassOrStruct and
692 (AddPartial): Update. Add 'is_partial' argument.
693 * roottypes.cs: Update to changes.
694 * cs-parser.jay (push_current_class): New helper for handling
695 current_container and current_class.
696 (struct_declaration, interface_declaration, class_declaration):
699 2006-07-26 Raja R Harinath <rharinath@novell.com>
701 * roottypes.cs: Rename from tree.cs.
703 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
704 * tree.cs (Tree, ITreeDump): Remove types.
705 * rootcontext.cs (tree, Tree): Remove fields.
706 (root, ToplevelTypes): New.
707 * *.cs: Update to rename.
709 * tree.cs (Tree.RecordDecl): Remove.
710 (RootTypes.AddToTypeContainer): Record the toplevel type in its
712 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
714 2006-07-23 Raja R Harinath <harinath@gmail.com>
716 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
717 DoFlowAnalysis and OmitStructFlowAnalysis here.
718 (ec.With): Rename from WithUnsafe and generalize.
719 (ec.WithCheckState): Remove. All users can be handled by 'With'.
720 (ec.WithFlowAnalyis): New.
721 * ecore.cs, expression.cs, statement.cs: Update.
723 2006-07-22 Raja R Harinath <harinath@gmail.com>
725 * statement.cs (Block.ResolveMeta): Simplify slightly.
727 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
728 multiple boolean fields. Convert InUnsafe, constant_check_state,
729 check_state to flags.
730 (CheckState, ConstantCheckState): Update.
731 (InUnsafe): New read-only property.
732 (FlagsHandle): Rename from CheckStateHandle and convert to handle
734 (WithUnsafe): New helper similar to WithCheckState.
735 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
736 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
738 2006-07-21 Raja R Harinath <rharinath@novell.com>
740 Make comparisons use the same IL irrespective of whether they're
741 in a 'checked' or 'unchecked' context: one of the issues in #78899
742 * codegen.cs (EmitContext.CheckState): Make read-only property.
743 (EmitContext.ConstantCheckState): Likewise.
744 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
745 helper that implement a save/restore stack for CheckState
746 values. This is the only way to change check-state.
747 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
748 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
749 (CheckedExpr.EmitBranchable): New forwarding method.
750 (UnCheckedExpr): Likewise.
751 * statement.cs (Block.ResolveMeta): Use WithCheckState.
752 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
753 (Checked.Resolve, checked.DoEmit): Likewise.
755 2006-07-21 Martin Baulig <martin@ximian.com>
757 * generic.cs (TypeManager.InferType): When inferring an array
758 type, also allow IList<T> and ICollection<T>. Fixes #78900.
760 2006-07-21 Martin Baulig <martin@ximian.com>
762 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
763 and allow IList`1 and all its base interfaces.
765 * convert.cs (Convert.ImplicitReferenceConversion): Allow
766 converting from an array-type of T to IList<T>.
768 2006-07-21 Martin Baulig <martin@ximian.com>
770 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
772 2006-07-20 Miguel de Icaza <miguel@novell.com>
774 * anonymous.cs: Cache the resolved anonymous delegate, and return
775 this so that the ResolveTopBlock is only triggered once, not
778 Currently we trigger ResolvetopBlock twice due to a first pass of
779 argument check compatibility, and a second pass that does the
782 2006-07-15 Marek Safar <marek.safar@seznam.cz>
784 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
786 * rootcontext.cs (Reset): Add helper_classes.
788 2006-07-15 Marek Safar <marek.safar@seznam.cz>
791 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
794 2006-07-13 Miguel de Icaza <miguel@novell.com>
796 * statement.cs (Lock): Handle expressions of type
797 TypeManager.null_type specially. Fixes #78770
799 2006-07-08 Marek Safar <marek.safar@seznam.cz>
801 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
804 2006-07-08 Marek Safar <marek.safar@seznam.cz>
806 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
807 for accessors as well.
808 * ecore.cs (EventExpr): Add AccessorTable.
810 2006-07-03 Martin Baulig <martin@ximian.com>
812 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
813 instances of value types.
815 * convert.cs (Convert.ExplicitConversion): Correctly handle
816 object->nullable conversions.
818 2006-07-01 Marek Safar <marek.safar@seznam.cz>
821 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
822 for CS0122 where appropriate.
823 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
825 (Filter): Assembly can be null in the case of top level attributes.
827 2006-06-28 Raja R Harinath <rharinath@novell.com>
830 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
831 no arguments, return 'false': nothing can be inferred.
833 2006-06-25 Marek Safar <marek.safar@seznam.cz>
837 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
838 is done at global level.
840 2006-06-24 Marek Safar <marek.safar@seznam.cz>
842 A fix for #77002, Implemented TypeForwarder support.
844 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
845 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
847 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
848 * typemanager.cs (): Add type_forwarder_attr_type.
850 2006-06-24 Marek Safar <marek.safar@seznam.cz>
852 * report.cs: Add CS0469 warning.
854 2006-06-22 Martin Baulig <martin@ximian.com>
857 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
858 for interfaces; fixes #78686, which is a modification of #78380
859 with interfaces instead of classes.
861 2006-06-21 Martin Baulig <martin@ximian.com>
863 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
864 the `try'-block, so we also report CS0016 etc. there.
866 2006-06-21 Martin Baulig <martin@ximian.com>
868 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
869 handle SetAssigned() and SetMemberIsUsed() for generic types;
872 2006-06-21 Martin Baulig <martin@ximian.com>
875 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
877 2006-06-21 Martin Baulig <martin@ximian.com>
879 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
880 also report CS1686 for parameters.
882 2006-06-21 Martin Baulig <martin@ximian.com>
884 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
885 instead of an error if the value is not implicitly convertible to
886 the switch types; fixes #77964.
888 2006-06-21 Raja R Harinath <rharinath@novell.com>
891 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
892 FieldBuilder is null.
895 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
896 'left' and 'right' before error-checking.
898 2006-06-19 Martin Baulig <martin@ximian.com>
901 (Convert.ImplicitConversionStandard): Cleanup and correctly
902 implement nullable conversions.
903 (Convert.ImplicitStandardConversionExists): Likewise.
904 (Convert.ExplicitConversion): Likewise.
906 2006-06-19 Martin Baulig <martin@ximian.com>
909 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
910 methods; make the ctors protected.
912 2006-06-19 Martin Baulig <martin@ximian.com>
914 Fixed #78380; added gtest-273.cs.
917 (Expression.ResolveAsBaseTerminal): Move the constraint checking
918 into ResolveAsTypeTerminal().
921 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
922 TypeManager.FindMembers() to check for the default ctor.
924 2006-06-18 Marek Safar <marek.safar@seznam.cz>
926 * generic.cs: Fixed NullableInfo accessibility.
928 2006-06-16 Martin Baulig <martin@ximian.com>
931 (Constraints.InflatedConstraints.inflate): Correctly inflate
932 generic types; fixes #78400.
934 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
936 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
938 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
939 (FieldExpr.DoResolve): likewise.
940 (PropertyExpr.InstanceResolve): likewise.
941 (EventExpr.InstanceResolve): likewise.
943 2006-06-15 Martin Baulig <martin@ximian.com>
946 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
947 argument; always allow a `null' label if true.
948 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
949 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
950 we have a `null' label and mark the new `null_target' label;
951 default to the `default' label.
952 (Switch.Resolve): Add support for nullable types. Fixes #78630.
954 2006-06-15 Martin Baulig <martin@ximian.com>
956 * class.cs (Operator.Define): Allow an implicit/explicit operator
957 to convert to/from a nullable value of the enclosing type.
959 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
960 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
963 (Convert.ImplicitStandardConversionExists): Add support for lifted
964 implicit/explicit conversions.
965 (Convert.ImplicitConversionStandard): Likewise.
967 2006-06-13 Martin Baulig <martin@ximian.com>
969 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
970 type arguments and create a ConstructedType if necessary. Fixes #78400.
972 2006-06-04 Marek Safar <marek.safar@seznam.cz>
974 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
975 attribute applicable tests for attribute argument.
977 2006-06-02 Raja R Harinath <rharinath@novell.com>
980 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
981 (Binary.OverloadResolve_PredefinedIntegral): New.
982 (Binary.OverloadResolve_PredefinedFloating): New.
983 (Binary.OverloadResolve_PredefinedString): New.
984 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
985 Follow the standard more closely, and treat numeric promotions in
986 terms of overload resolution.
987 (Binary.CheckShiftArguments): Simplify.
989 2006-06-01 Raja R Harinath <rharinath@novell.com>
991 * flowanalysis.cs (MyBitVector): Simplify representation.
992 (MyBitVector.Clone): Avoid allocating BitArray.
993 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
994 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
995 (*): Update. Change all references to MyBitVector.And and
996 MyBitVector.Or to &= and |=.
998 2006-05-31 Raja R Harinath <rharinath@novell.com>
1000 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
1001 Use bne.un instead of ceq+brfalse.
1004 * typemanager.cs (IsUnmanagedType): Disallow generic types and
1007 2006-05-29 Raja R Harinath <rharinath@novell.com>
1010 * cs-parser.jay (formal_parameter_list): Extend the pattern below
1011 to param arguments too.
1013 2006-05-26 Miguel de Icaza <miguel@novell.com>
1015 * cs-parser.jay: Catch another parsing form for arglist being
1016 followed by other arguments. Fixes #78313.
1018 2006-05-25 Raja R Harinath <rharinath@novell.com>
1021 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
1022 also when one of the operands is a null literal.
1023 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
1024 to improve clarity, and generate slightly better code.
1026 2006-05-24 Raja R Harinath <rharinath@novell.com>
1028 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
1029 checking of out parameters to ...
1030 (FlowBranchingToplevel.Merge): ... here.
1031 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
1032 set, propagate the origin upward, and only complain if there was
1034 (FlowBranchingException.AddContinueOrigin): Likewise.
1035 (FlowBranchingException.AddReturnOrigin): Likewise.
1036 (FlowBranchingException.AddGotoOrigin): Likewise.
1038 2006-05-23 Raja R Harinath <rharinath@novell.com>
1040 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
1041 unreachable, skip it.
1042 (FlowBranchingException.Merge): Always propagate jumps, even if
1043 the finally block renders subsequent code unreachable.
1045 2006-05-18 Raja R Harinath <rharinath@novell.com>
1048 * statement.cs (Goto.Resolve): Move responsibility for resolving
1049 'goto' to FlowBranching.AddGotoOrigin.
1050 (Goto.SetResolvedTarget): New. Callback to set the
1051 LabeledStatement that's the target of the goto.
1052 (Goto.DoEmit): Use Leave instead of Br when crossing an
1053 unwind-protect boundary.
1054 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
1055 LookupLabel and adjust to new semantics.
1056 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
1057 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
1058 Goto.SetResolvedTarget to update target.
1059 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
1060 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
1061 AddBreakOrigin & co. Delay propagation until ...
1062 (FlowBranchingException.Merge): ... this.
1064 * statement.cs (Block.Resolve): Always depend on flow-branching to
1065 determine unreachability. Kill workaround that originally emitted
1066 only one statement after an "unreachable" label (see infloop in
1069 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
1070 This is still "wrong", but anything better would probably need a
1071 multi-pass algorithm.
1072 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
1073 usage vector. Force current usage vector to be reachable, to
1074 optimistically signify backward jumps.
1075 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
1077 (FlowBranchingLabeled.Merge): New. If no backward jump was
1078 detected, return the original salted-away usage vector instead,
1079 updated with appropriate changes. Print unreachable warning if
1081 * statement.cs (Block.Resolve): Don't print unreachable warning on
1082 a labeled statement.
1084 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
1086 * driver.cs: Pass filename without path to AssemblyBuilder's
1087 AddResourceFile. Fixes bug #78407.
1089 2006-05-17 Raja R Harinath <rharinath@novell.com>
1091 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
1092 * flowanalysis.cs (FlowBranchingLabeled): ... here.
1093 (FlowBranching.MergeChild): Overwrite
1094 reachability information from Labeled branchings too.
1096 2006-05-16 Raja R Harinath <rharinath@novell.com>
1098 * statement.cs (Goto.Resolve): Merge jump origins here ...
1099 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
1101 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
1102 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
1103 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
1104 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
1106 * statement.cs (Goto.Resolve): ... not here.
1107 (Goto.Emit): Remove CS1632 check.
1109 2006-05-14 Marek Safar <marek.safar@seznam.cz>
1111 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
1114 2006-05-11 Raja R Harinath <rharinath@novell.com>
1116 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
1117 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
1118 (FlowBranchingException.Label): Likewise.
1120 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
1122 (MyBitVector.Or): Use it to avoid losing information (Count).
1123 (FlowBranching.MergeOrigins): Likewise.
1125 * flowanalysis.cs (UsageVector.IsDirty): Remove.
1126 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
1127 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
1128 (UsageVector.ToString): Simplify.
1129 (UsageVector.MergeSiblings): Move here from ...
1130 (FlowBranching.Merge): ... here.
1131 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
1134 2006-05-10 Raja R Harinath <rharinath@novell.com>
1136 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
1137 null bitvector is treated as all-true.
1139 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
1140 (MyBitVector): Rationalize invariants. 'vector != null' implies
1141 that we have our own copy of the bitvector. Otherwise,
1142 'InheritsFrom == null' implies all inherited bits are true.
1144 2006-05-09 Marek Safar <marek.safar@seznam.cz>
1146 * statement.cs (LocalInfo): Add IsConstant.
1147 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
1148 local variable for constants.
1150 2006-05-09 Raja R Harinath <rharinath@novell.com>
1152 * flowanalysis.cs (MyBitVector.Empty): New.
1153 (MyBitVector): Don't allow InheritedFrom to be null.
1154 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
1155 (UsageVector, FlowBranching): Update to changes.
1157 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
1158 recursion. The 'Parent == null' condition isn't sufficient for
1160 (FlowBranching.AddBreakOrigin): Likewise.
1161 (FlowBranching.AddContinueOrigin): Likewise.
1162 (FlowBranching.AddReturnOrigin): Likewise.
1163 (FlowBranching.StealFinallyClauses): Likewise.
1164 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
1165 (FlowBranching.CheckOutParameters): Likewise.
1166 (FlowBranchingToplevel): Terminate all the above recursions here.
1167 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
1168 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
1170 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
1172 (FlowBranchingToplevel): New. Empty for now.
1173 (FlowBranching.MergeTopBlock): Update.
1174 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
1175 branching for the anonymous delegate.
1176 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
1178 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
1179 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
1180 information at the start of the merge. Reorganize.
1182 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1184 * class.cs (MethodData.Define): Method cannot implement interface accessor.
1186 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1188 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
1189 to newly introduced ctor.
1191 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
1192 message to one place.
1193 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
1196 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1198 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
1200 * ecore.cs (Expression.ResolveAsConstant): Updated.
1202 * statement.cs (ResolveMeta): Updated.
1204 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1206 * cs-parser.jay: __arglist cannot be used in initializer.
1208 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1211 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
1214 2006-05-05 Raja R Harinath <rharinath@novell.com>
1216 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
1217 (LabeledStatement): Add 'name' parameter.
1218 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
1219 (Block.AddLabel): Update to changes.
1220 * cs-parser.jay (labeled_statement): Likewise.
1222 * flowanalysis.cs (BranchingType.Labeled): New.
1223 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
1224 (FlowBranchingLabeled): New. Does nothing for now, but will
1225 eventually handle 'goto' flows.
1226 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
1227 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
1228 that's terminated ...
1229 (Block.Resolve): ... here.
1231 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
1232 (UsageVector.MergeFinallyOrigins): Likewise.
1233 (FlowBranching.InTryOrCatch): Likewise.
1234 (FlowBranching.AddFinallyVector): Likewise.
1235 (FlowBranchingException): Update to changes.
1238 * statement.cs (Return.Resolve): Move error checking to ...
1239 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
1240 (FlowBranchingException): Handle return origins like break and
1242 (FlowBranching.UsageVector.CheckOutParameters): Remove.
1244 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1247 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
1250 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1253 * class.cs (MethodData.Define): Do public accessor check only when method
1254 implements an interface.
1256 2006-05-04 Raja R Harinath <rharinath@novell.com>
1258 Remove special handling of 'break'
1259 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
1260 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
1261 (UsageVector.Break): Remove.
1262 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
1264 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
1266 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
1267 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1269 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1272 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1273 be the interface member.
1275 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1278 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1279 for emitting small (int) values.
1281 2006-05-03 Raja R Harinath <rharinath@novell.com>
1284 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1285 control-flow passes through the 'finally' after merging-in all the
1286 control-flows from 'try' and the 'catch' clauses.
1288 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1289 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1290 always true at the only non-recursive entry point.
1291 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1292 FlowBranchingBreakable.
1293 (FlowBranchingLoop): Remove.
1294 * statement.cs (Return.DoResolve): Update to changes.
1297 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1298 (FlowBranching.CreateBranching): Handle it: create a
1299 FlowBranchingContinuable.
1300 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1301 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1302 except that it handles the 'continue' command.
1303 (FlowBranching.UsageVector.MergeOrigins): Rename from
1305 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1306 except that it overrides AddContinueOrigin.
1307 (FlowBranchingException): Override AddContinueOrigin, similar to
1309 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1310 Create a new branching around the embedded statement.
1311 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1312 control flow after the embedded statement.
1313 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1315 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1316 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1317 FlowBranchingBreakable.
1318 (FlowBranchingSwitch): Remove.
1321 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1322 error reporting to ...
1323 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1324 Rename from 'AddBreakVector'. Add new location argument. Return
1325 a bool indicating whether the 'break' crosses an unwind-protect.
1326 (FlowBranchingException.AddBreakOrigin): Add.
1327 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1328 flowbranching after updating with the effects of the 'finally'
1330 (FlowBranchingBreakable): New common base class for
1331 FlowBranchingLoop and FlowBranchingSwitch.
1333 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1335 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1337 2006-05-02 Raja R Harinath <rharinath@novell.com>
1339 * statement.cs (Do.Resolve): If the loop is infinite, set the
1341 (While.Resolve, For.Resolve): Set a barrier after the embedded
1342 statement. There's no direct control flow that goes from the end
1343 of the embedded statement to the end of the loop.
1344 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1345 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1346 above ensure that the reachability is correctly computed.
1348 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1349 (UsageVector.MergeBreakOrigins): If the current path is
1350 unreachable, treat it as if all parameters/locals are initialized.
1351 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1352 infinite loops before merging-in break origins.
1354 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1355 (Reachability.Reachable): Split part into ...
1356 (Reachability.Unreachable): ... this. Simplify.
1357 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1359 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1360 (Reachability.SetThrowsSometimes): Likewise.
1361 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1362 TriState.Always, use corresponding property.
1363 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1364 (Block.Resolve): Likewise. Remove some redundant checks.
1366 2006-05-02 Raja R Harinath <harinath@gmail.com>
1368 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1369 (Reachability.Meet): Don't bother checking AlwaysThrows --
1370 barrier is always set.
1371 (FlowBranchingBlock.Merge): Likewise.
1373 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1375 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1376 defined, so it's references should also compile only for NET_2_0
1377 (as occurs in mcs version)
1379 2006-05-01 Raja R Harinath <harinath@gmail.com>
1381 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1382 checks for unreachable.
1384 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1387 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1389 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1390 whether field is really assigned.
1392 2006-04-30 Raja R Harinath <harinath@gmail.com>
1394 * flowanalysis.cs (Reachability): Make 4-argument constructor
1396 (Reachability.Meet): Rename from 'And'. Remove static variant.
1397 (Reachability.Always): Rename from the highly misleading
1398 'Reachability.Never'.
1399 (FlowBranching.Merge): Update to changes. Mark an impossible
1400 situation with a 'throw'.
1401 (*): Update to changes.
1403 2006-04-29 Raja R Harinath <harinath@gmail.com>
1405 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1407 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1408 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1409 (*): Update to changes.
1410 * statement.cs: Update to changes.
1412 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1415 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1417 2006-04-28 Raja R Harinath <harinath@gmail.com>
1419 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1422 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1423 argument to two arguments: an usage-vector and a bool. Move call
1424 to FlowBranching.Merge () ...
1425 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1427 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1428 handling of loop and switch reachability to ...
1429 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1431 2006-04-27 Raja R Harinath <harinath@gmail.com>
1433 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1434 handling to FlowBranchingLoop.InLoop.
1435 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1437 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1440 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1441 anonymous method is allowed from AnonymousContainer here.
1443 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1445 2006-04-24 Raja R Harinath <rharinath@novell.com>
1448 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1450 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1453 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1454 (DoubleConstant.Reduce): Ditto.
1456 2006-04-23 Raja R Harinath <rharinath@novell.com>
1458 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1459 Remove 'lvalue_right_side' argument. Move parts to ...
1460 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1461 (LocalVariable.DoResolveLValue): ... these.
1463 2006-04-21 Raja R Harinath <rharinath@novell.com>
1466 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1467 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1468 (LocalVariableReference.DoResolveBase): Use it to implement new
1470 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1471 (Argument.Resolve): Simplify. Move CS1510 check ...
1472 * ecore.cs (Expression.ResolveLValue): ... here.
1473 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1474 (PropertyExpr.DoResolveLValue): Likewise.
1475 (FieldExpr.Report_AssignToReadonly): Likewise.
1476 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1477 LValueMemberAccess or LValueMemberOutAccess on instance depending
1479 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1480 DoResolve as appropriate.
1482 2006-04-20 Raja R Harinath <rharinath@novell.com>
1485 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1486 implicit conversions on 'out' and 'ref' arguments.
1488 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1489 improve clarity. Remove dead code.
1492 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1493 (Catch.Resolve): Resolve VarBlock if it exists.
1495 2006-04-19 Miguel de Icaza <miguel@novell.com>
1497 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1498 twice, this was some residual code, the enumerator was emitted
1499 properly in the two branche of if later.
1503 Thanks to Martin for finding the source of the problem
1505 2006-04-19 Raja R Harinath <rharinath@novell.com>
1507 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1508 cast is never an lvalue.
1509 (Cast.DoResolve, Cast.ResolveRest): Combine.
1510 (Argument.Emit): Simplify slightly. Move 'Expr is
1511 IMemoryLocation' check ...
1512 (Argument.Resolve): ... here.
1513 (Argument.Error_LValueRequired): Remove. Inline into only user.
1515 Simplifications. Fix cs0191-2.cs
1516 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1517 CS1649 and CS1651 to ...
1518 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1519 the actual selection of the error code and message to a lookup
1520 table. Add a dummy return value to simplify callsites.
1521 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1522 readonly fields of other instances of the same type. Move CS0197
1524 * expression.cs (Argument.Resolve): ... here. Simplify code.
1525 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1526 resolution of an out or ref argument. The code simplification
1527 above uses this invariant.
1529 2006-04-18 Raja R Harinath <rharinath@novell.com>
1531 Possibly fix #77752. Fix cs1690-[4-7].cs.
1532 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1533 CheckMarshallByRefAccess. Drop parameter.
1534 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1536 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1538 * report.cs (AllWarnings): Add CS1690.
1539 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1541 (LocalVariableReference.DoResolveBase): Update.
1543 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1545 * class.cs (MethodOrOperator): Moved common parts from method class.
1546 detect obsolete attributes.
1547 (Method.Define): Simplified as it reuses code from base.
1548 (Constructor.ValidAttributeTargets): Fixed issue found during
1550 (Destructor.ValidAttributeTargets): Fixed issue found during
1552 (Operator): Finished refactoring set off by #78020. Operator class is now
1553 ordinary method class.
1555 * anonymous.cs: Updated.
1557 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1559 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1561 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1563 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1564 detect obsolete attributes.
1565 (Method.CreateEmitContext): Moved to MethodOrOperator.
1567 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1570 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1571 customized exception to make crash detection easier.
1572 (MethodOrOperator): Started to work on new base class for methods and
1574 (Method): Derives from MethodOrOperator.
1575 (Constructor.Emit): Emits its own attributes.
1576 (AbstractPropertyEventMethod.Emit): Ditto.
1577 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1579 (Operator.Emit): It's temporary more tricky than should be.
1581 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1583 * report.cs (InternalErrorException): Add ctor with inner exception.
1585 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1588 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1591 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1594 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1597 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1599 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1600 attribute is present and Guid not.
1601 (Interface.ApplyAttributeBuilder): Ditto.
1603 * attribute.cs: Add error message.
1605 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1609 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1610 sources (it's composite) so hold them in extra array as they are used in
1611 Emit phase only. It worked in the previous versions by mistake.
1612 (Attribute.Emit): Emit attribute for more owners when exist.
1614 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1615 it has now different behaviour.
1617 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1619 * constant.cs (Constant.IsDefaultInitializer): New method.
1621 * class.cs: Updated.
1623 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1624 re-initialize default values. It saves KBs almost for every assembly.
1625 Thanks Zoltan for the idea.
1626 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1627 (ArrayCreation.DoResolve): Resolve only once.
1628 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1629 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1631 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1633 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1636 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1638 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1639 in an embedded statement too.
1641 2006-04-01 Raja R Harinath <rharinath@novell.com>
1644 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1648 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1651 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1652 arguments before checking whether a type is reflected or not.
1655 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1656 definition doesn't take part in overload resolution.
1657 (Invocation.IsParamsMethodApplicable): Likewise.
1658 (Invocation.OverloadResolve): When replacing a reflected override
1659 method with its base definition, ensure that type arguments are
1662 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1666 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1669 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1671 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1673 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1676 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1677 LocalTemporary change.
1679 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1681 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1682 initializers optimization.
1683 (ClassOrStruct.TypeAttr): Moved from modifiers.
1684 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1685 (FieldBase.ResolveInitializer): Resolves initializer.
1686 (FieldBase.HasDefaultInitializer): New property.
1688 * cs-parser.jay: Removed message.
1690 * expression.cs (CompilerGeneratedThis): New specialization.
1692 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1694 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1696 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1698 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1700 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1701 be now EnumConstants only.
1703 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1705 * attribute.cs, driver.cs: Reset more caches.
1707 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1709 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1711 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1713 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1714 for easier reuse. Updated all overrides.
1715 (IntegralConstant): New base class for all integral constants.
1716 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1717 of the constant range, report custom error.
1718 (UIntConstant.Reduce): Fixed uint conversion.
1720 * ecore.cs, literal.cs: Reduce updates.
1722 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1726 * class.cs (Constructor.Define): Removed extra if for default ctors.
1727 A patch from Atsushi Enomoto.
1729 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1731 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1732 GetAttributableValue.
1734 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1737 * convert.cs (ImplicitConversionRequired): Error message moved to
1740 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1741 automatic implicit conversion of an output value.
1742 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1744 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1746 (TypeOf.GetAttributableValue): Add extra handling for object type.
1748 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1749 special error message.
1751 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1753 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1755 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1756 compatible with MS runtime.
1758 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1760 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1761 attribute arguments here.
1763 * class.cs (Indexer.Define): The check was moved to attribute class.
1765 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1767 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1769 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1771 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1773 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1776 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1778 * doc-bootstrap.cs : fix build.
1780 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1782 * expression.cs (StringConcat.Append): Issue a warning when empty string
1785 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1787 * assign.cs (CompoundAssign.ResolveSource): Removed.
1789 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1792 * class.cs (TypeContainer.FindMethods): Removed.
1793 (TypeContainer.CheckMemberUsage): Made static.
1795 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1797 * constant.cs (CheckRange): Removed unused type argument.
1798 (CheckUnsigned): Removed unused type argument.
1800 * cs-parser.jay: Updated after MemberAccess clean up.
1801 Uses Length for empty string test.
1803 * cs-tokenizer.cs: Uses Length for empty string test.
1804 (IsCastToken): Made static.
1805 (is_hex): Made static.
1806 (real_type_suffix): Made static.
1808 * decl.cs (SetupCache): Made static.
1809 (OnGenerateDocComment): Removed unused ds argument.
1811 * delegate.cs (VerifyDelegate): Removed unused argument.
1813 * doc.cs: Uses Length for empty string test.
1815 * driver.cs: Uses Length for empty string test.
1817 * enum.cs (IsValidEnumType): Made static
1819 * expression.cs (EnumLiftUp): Removed unused argument.
1820 (ResolveMethodGroup): Ditto.
1821 (BetterConversion): Ditto.
1822 (GetVarargsTypes): Ditto.
1823 (UpdateIndices): Ditto.
1824 (ValidateInitializers): Ditto.
1825 (MemberAccess.ctor): Ditto.
1826 (GetIndexersForType): Ditto.
1828 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1830 * iterators.cs: Updated after MemberAccess clean up.
1832 * location.cs: Uses Length for empty string test.
1834 * namespace.cs: Uses Length for empty string test.
1836 * report.cs (CheckWarningCode): Made static.
1838 * statement.cs (LabeledStatement): Removed unused argument.
1840 * typemanager.cs (FilterNone): Removed.
1842 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1844 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1847 * class.cs: Updated.
1849 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1851 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1853 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1857 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1859 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1860 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1861 Add more error reporting; Fixed issue with params.
1863 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1865 * cs-parser.jay: AnonymousMethod requires host container.
1867 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1869 2006-03-18 Raja R Harinath <harinath@gmail.com>
1871 * class.cs: Change 'TypeContainer ds' constructor argument to
1872 'DeclSpace parent'. Some classes were missed below due to
1873 different naming convention.
1875 * class.cs (MemberCore.Parent): Delete. This makes the
1876 ParentContainer changes below enforceable by the compiler.
1878 Treat pointers to enclosing declaration space as 'DeclSpace', not
1880 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
1881 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
1883 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
1885 (Block.AddThisVariable): Likewise.
1886 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
1887 (AbstractPropertyEventMethod.Emit): Likewise.
1888 (AbstractPropertyEventMethod.EmitMethod): Likewise.
1889 (GetMethod.Define, SetMethod.Define): Likewise.
1890 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
1891 (DelegateMethod.EmitMethod): Likewise.
1893 Fix regression test-partial-13.cs.
1894 Rationalize use of PartialContainer. Ensure that the partial
1895 class semantics can be tied to type-correctness, i.e., any
1896 violation will cause a compile error.
1897 * class.cs, const.cs: Access all fields that belong to class
1898 TypeContainer via ParentContainer. Arguments of EmitContexts and
1899 Resolve()-like functions still use 'Parent'.
1901 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
1902 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
1903 (PropertyMethod.CheckModifiers): Remove unused argument.
1904 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
1907 2006-03-28 Raja R Harinath <rharinath@novell.com>
1909 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
1911 2006-03-17 Raja R Harinath <harinath@gmail.com>
1913 Make semantics of PartialContainer simpler.
1914 * decl.cs (DeclSpace.IsPartial): Remove.
1915 * class.cs (TypeContainer.IsPartial): Likewise.
1916 (TypeContainer..ctor): Set PartialContainer to point to self.
1917 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
1918 (TypeContainer.FindNestedType): Likewise.
1919 (MemberCore.ParentContainer): Simplify. Remove deprecation.
1921 2006-03-17 Marek Safar <marek.safar@seznam.cz>
1923 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
1925 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1927 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
1930 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1932 * class.cs (Operator.Define): An error for base conversion was not
1935 2006-03-13 Marek Safar <marek.safar@seznam.cz>
1937 A fix for #77593, #77574.
1939 * class.cs (MethodCore.CheckBase): Another if for operator.
1941 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1945 * expression.cs (VerifyArgumentsCompat): Reverted to double error
1946 reporting, it's more tricky than I thought.
1948 2006-03-09 Marek Safar <marek.safar@seznam.cz>
1950 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
1953 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
1954 (DelegateCreation.ImplicitStandardConversionExists): New method for just
1957 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
1960 2006-03-04 Marek Safar <marek.safar@seznam.cz>
1964 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
1965 (Event.Define): ditto
1966 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
1968 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
1969 Removed redundant code and set NewSlot for Invoke method too.
1971 * parameter.cs (Parameters.ctor): Add custom, type ctor.
1972 (Parameters.MergeGenerated): New method. Use this method when you merge
1973 compiler generated argument with user arguments.
1975 2006-03-03 Marek Safar <marek.safar@seznam.cz>
1977 * attribute.cs (ResolveAsTypeTerminal): Removed.
1979 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
1980 specialization for predefined types; 30% speed up.
1981 Finally placed obsolete check to right place.
1982 (Expression.ResolveType): Removed.
1984 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
1985 Updated after ResolveType was removed.
1987 * expression.cs (Cast.ctor): Check void cast.
1988 (Binary.ResolveAsTypeTerminal): Is never type.
1989 (Conditional.ResolveAsTypeTerminal): Is never type.
1991 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
1993 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1995 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
1997 2006-03-23 Martin Baulig <martin@ximian.com>
1999 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
2000 type check if either of the types is an open generic type.
2002 2006-03-23 Martin Baulig <martin@ximian.com>
2005 (Convert.ExplicitTypeParameterConversion): New method; implement
2006 explicit type parameter conversions.
2008 2006-03-23 Martin Baulig <martin@ximian.com>
2010 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
2011 blindly allow all conversions if we do not have any constraints.
2013 2006-02-27 Marek Safar <marek.safar@seznam.cz>
2015 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
2016 these two separated members to simplify the code.
2017 (Attribute.Resolve): Refactored to use new fields and methods.
2018 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
2019 implemented obsolete attribute checking.
2020 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
2021 implemented obsolete checking again. It look line never ending quest ;-)
2022 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
2024 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
2026 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
2028 *class.cs (Property.Define): Add RegisterProperty call.
2030 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
2031 argument groups (only 2).
2033 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
2034 encoding expression to arguments.
2035 (Expression.ExprClassToResolveFlags): Just turned to property.
2037 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
2038 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
2039 optimized as well as implemented support for zero-length attributes.
2041 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
2042 Add caching of PropertyInfo's.
2044 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2046 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
2047 error multiple times.
2049 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2051 New partial class implementation.
2052 A fix for #77027, #77029, #77403
2054 * attribute.cs (Attributable): Made attributes protected.
2056 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
2057 the replacements of ClassPart and PartialContainer.
2058 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
2059 (TypeContainer.AddInterface): Ditto.
2060 (TypeContainer.AddPartial): The main method for partial classes. It checks
2061 for errors and merges ModFlags and attributes. At the end class is added to
2063 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
2065 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
2066 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
2067 from the rest of partial classes.
2068 (TypeContainer.GetClassBases): Simplified.
2069 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
2071 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
2072 (TypeContainer.HasExplicitLayout): Uses Flags now.
2073 (PartialContainer): Removed.
2074 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
2075 (StaticClass): Was merged with Class.
2076 (Class.GetClassBases): class and static class bases are verified here.
2077 (Class.TypeAttr): Added static attributes when class is static.
2078 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
2079 (MemberBase): In some cases we need to call parent container for partial
2080 class. It should be eliminated but it's not easy now.
2082 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
2084 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
2085 partial classed to accumulate class comments.
2086 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
2088 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
2090 * driver.cs (MainDriver): Tree.GetDecl was removed.
2092 * modifiers.cs (Modifiers): Add partial modifier.
2094 * tree.cs (Tree.decl): Removed.
2095 (RootTypes): Started to use this class more often for root types
2098 2006-03-23 Raja R Harinath <rharinath@novell.com>
2100 * generic.cs (TypeParameter.UpdateConstraints): Update
2101 'constraints' if null.
2103 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2107 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
2108 external interface does not have an attribute.
2110 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2112 Another prerequisites for new partial classs implementation.
2114 * attribute.cs (Attribute.Equal): Implemented.
2115 (Attribute.Emit): Changed as attributes can be applied more than twice.
2116 (Attributes.Emit): Check for duplicate attributes here.
2118 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
2119 as a parameter, clean-up.
2121 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2125 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
2126 contains obsolete attribute check which can in some cases look for base
2127 type of current class which is not initialized yet.
2128 (TypeContainer.BaseType): Replacement of ptype.
2130 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
2132 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2134 First of prerequisites for new partial classs implemention.
2136 * attribute.cs (Attributable): Extended by ResolveContext;
2137 Attributes finally have correct context for resolving in all cases.
2138 (AttachTo): Attribute owner is assigned here.
2140 * codegen.cs (IResolveContext): Introduce new interface to hold
2141 all information needed in resolving phase.
2142 (EmitContext): Implements IResolveContext; more clean-up needed here.
2144 * decl.cs (MemberCore): Implemented IResolveContext.
2146 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
2147 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
2148 parameter.cs, statement.cs, tree.cs, typemanager.cs:
2149 Refactored to use new IResolveContext instead of EmitContext; cleanup
2151 2006-03-22 Raja R Harinath <rharinath@novell.com>
2153 Support ParameterDefaultValueAttribute in gmcs. Also applied to
2154 mcs to keep code differences small.
2155 * attribute.cs (Attribute.GetParameterDefaultValue): New.
2156 * typemanager.cs (parameter_default_value_attribute_type): New.
2157 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
2160 2006-03-22 Martin Baulig <martin@ximian.com>
2163 (Nullable.NullableLiteral): Derive from `NullLiteral'.
2166 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
2167 instead of the normal `NullLiteral'.
2169 2006-03-21 Martin Baulig <martin@ximian.com>
2172 * generic.cs (TypeManager.InferType): If `pt' is a generic
2173 parameter, don't check whether `pt == at'.
2175 2006-03-20 Raja R Harinath <rharinath@novell.com>
2178 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
2179 (TypeParameter.Resolve): Update to change.
2180 (ConstraintChecker.CheckConstraints): Resolve type-argument
2181 constraints before use.
2183 2006-03-16 Martin Baulig <martin@ximian.com>
2186 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
2187 and don't have any instance constructors, also lookup in the base class.
2188 (TypeManager.IsNullableValueType): New public method.
2190 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
2191 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
2192 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
2194 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
2195 instead of just TypeManager.IsNullableType() to determine whether
2196 a lifted operator exists.
2197 (UnaryMutator.DoResolve): Likewise.
2198 (Conditional.DoResolve): Likewise.
2199 (Binary.DoResolve): A lifted operator only exists if both operands
2200 are valuetypes and at least one of them is a nullable type.
2202 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
2204 * iterator.cs : yield break is allowed in try statement which has
2205 catch clauses. Fixed bug #77767.
2207 2006-03-12 Martin Baulig <martin@ximian.com>
2209 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
2210 private IsSignatureEqual() to compare types; see the comment in
2211 that method; fixes #77674.
2213 2006-03-10 Raja R Harinath <rharinath@novell.com>
2215 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
2216 (Expression.ResolveAsTypeTerminal): Likewise.
2217 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
2218 * expression.cs, generic.cs, iterators.cs: Likewise.
2219 * parameter.cs, statement.cs, typemanager.cs: Likewise.
2221 2006-03-09 Martin Baulig <martin@ximian.com>
2223 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
2224 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
2226 2006-03-09 Martin Baulig <martin@ximian.com>
2228 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
2229 `prepared' flag is set.
2231 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
2232 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
2233 issues; see gtest-254.cs.
2235 2006-03-07 Martin Baulig <martin@ximian.com>
2237 * generic.cs (TypeManager.InferType): Allow infering
2238 `IEnumerable<T>' with an array of T; see gtest-251.cs.
2240 2006-03-06 Martin Baulig <martin@ximian.com>
2243 (TypeManager.InferType): Fix gtest-250.cs.
2246 (TypeManager.IsSubclassOf): Also check the base class.
2249 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
2252 2006-03-01 Raja R Harinath <rharinath@novell.com>
2255 * expression.cs (ParameterReference.DoResolveBase): Change return
2257 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
2261 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
2264 * typemanager.cs (GetFullNameSignature): Don't nullref on
2265 protected accessors.
2267 2006-02-16 Martin Baulig <martin@ximian.com>
2270 (TypeManager.GetGenericFieldDefinition): New public method; use it
2271 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2273 2006-02-14 Martin Baulig <martin@ximian.com>
2275 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2277 2006-02-14 Martin Baulig <martin@ximian.com>
2280 (TypeManager.DropGenericMethodArguments): New public method; don't
2281 use GetGenericMethodDefinition() on something which is not a
2284 2006-02-14 Martin Baulig <martin@ximian.com>
2287 (ConstraintChecker.CheckConstraints): If a type parameter has the
2288 `struct' constraint, the type must be a non-nullable valuetype.
2290 2006-02-10 Martin Baulig <martin@ximian.com>
2293 (TypeManager.IsOverride): Make this work for instantiated methods
2294 in a generic class; fixes #77509.
2295 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2296 rather than calling it directly; fixes #77488.
2298 2006-02-08 Martin Baulig <martin@ximian.com>
2300 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2301 reporting into CheckConstraint() so we can use the correctly
2304 2006-02-08 Martin Baulig <martin@ximian.com>
2306 * expression.cs (BaseAccess): Add support for generic methods.
2308 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2309 the new MethodGroupExpr.
2311 2006-02-07 Martin Baulig <martin@ximian.com>
2313 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2314 also reference types; fixes #77483.
2316 2006-02-07 Martin Baulig <martin@ximian.com>
2319 (TypeManager.IsGenericMethod): We now return whether something is
2320 an instantiated generic method (and not a generic method def).
2321 (TypeManager.IsGenericMethodDefinition): New public method.
2324 (TypeManager.CSharpSignature): Only include type arguments for
2325 "real" generic methods, not for any instantiated method.
2326 (TypeManager.GetMethodName): Likewise, but also allow generic
2327 method definitions here.
2329 2006-02-06 Miguel de Icaza <miguel@novell.com>
2331 * codegen.cs (EmitScopeInitFromBlock): check here the
2332 capture_context, there is no need to make two calls to the
2335 * anonymous.cs: Add some debugging messages that might help me
2336 track other instances of this problem in the future (the
2337 regression of test 467).
2339 * cs-parser.jay: track the variable block, as we need to initalize
2340 any captured variables declared in this block for the "catch"
2341 portion of the "Try" statement.
2343 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2344 scope initialization for captured variables.
2346 Also, move the emit for the variables after the block location has
2349 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2351 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2353 2006-02-06 Martin Baulig <martin@ximian.com>
2355 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2356 `TypeManager.value_type' as parent type to
2357 ModuleBuilder.DefineType(). Fixes #77358.
2359 2006-02-02 Miguel de Icaza <miguel@novell.com>
2361 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2362 commit yesterday, the initialization for the roots is necessary.
2363 What is not necessary is the scope activation.
2365 2006-02-02 Raja R Harinath <rharinath@novell.com>
2367 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2368 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2370 (Argument.Resolve): Remove CS0206 checks.
2372 2006-02-01 Miguel de Icaza <miguel@novell.com>
2374 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2375 scopes for all the roots, the scopes will now be emitted when the
2376 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2378 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2379 code. This reduces a lot of existing cruft.
2381 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2382 that the ScopeInfo is generated as we enter the scope, not at the
2383 time of use, which is what we used to do before.
2385 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2386 every time a Block is about to be emitted if we have a
2389 2006-02-01 Raja R Harinath <rharinath@novell.com>
2391 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2392 attribute for mscorlib too.
2394 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2396 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2398 * typemanager.cs (cons_param_array_attribute): Make private.
2399 (Reset): Set it to null.
2400 (InitCoreHelpers): Don't initialize it.
2401 (ConsParamArrayAttribute): New. Initialize it as needed.
2402 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2404 2006-01-31 Miguel de Icaza <miguel@novell.com>
2406 * expression.cs: There might be errors reported during the
2407 selection of applicable methods. If there are errors, do not
2408 continue execution as it will lead the compiler to crash.
2410 2006-01-30 Miguel de Icaza <miguel@novell.com>
2412 * expression.cs: Member access is not allowed on anonymous
2413 methods. Fixes #77402.
2415 2006-01-30 Raja R Harinath <rharinath@novell.com>
2418 * cs-parser.jay (VariableDeclaration): Don't set
2419 current_array_type to null.
2420 (field_declaration, event_declaration, declaration_statement):
2421 Set it to null here.
2423 2006-01-29 Raja R Harinath <harinath@gmail.com>
2426 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2428 2006-01-28 Raja R Harinath <harinath@gmail.com>
2430 * typemanager.cs (GenericParameterPosition): New.
2433 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2435 * doc.cs : To process "include" elements, first we should create
2436 another list than XmlNodeList, because it could result in node
2437 removal, which could result in that the XmlNodeList gives up
2440 2006-01-25 Miguel de Icaza <miguel@novell.com>
2442 * expression.cs: Introduce an error report that we were not
2443 catching before. Gonzalo ran into it.
2445 2006-01-23 Miguel de Icaza <miguel@novell.com>
2447 A fix for bug: #76957
2449 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2450 ComputeMethodHost before creating the method, this is a new
2453 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2454 that this method references (RegisterScope). The actual scope
2455 where the method is hosted is computed with the ComputeMethodHost
2456 before we create the method.
2458 Moved the Deepest routine here.
2460 (AnonymousContainer.ComputeMethodHost): New routine used to
2461 compute the proper ScopeInfo that will host the anonymous method.
2463 (ScopeInfo): Deal with multiple roots. The problem was that we
2464 did not have a unique root where all ScopeInfos could be hanged
2465 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2468 Remove AdjustMethodScope which is now computed at the end. Remove
2469 LinkScope which did a partial link, instead link all ScopeInfos
2470 before code generation from the new "LinkScopes" routine.
2472 Simplify all the Add* routines as they no longer need to maintain
2473 the tree, they just need to record that they are using variables
2476 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2477 routines to produce the forest of ScopeInfo trees.
2479 * class.cs (TypeContainer.AppendMethod): This is just like
2480 AddMethod, but ensures that an interface implementation method
2481 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2482 methods, but at the end.
2484 We use this functionality to ensure that the generated MoveNext
2485 method in the iterator class is resolved/emitted before the
2486 enumerator methods created.
2488 This is required because the MoveNext method computes the right
2489 ScopeInfo for the method. And the other methods will eventually
2490 need to resolve and fetch information computed from the anonymous
2494 2006-01-23 Raja R Harinath <rharinath@novell.com>
2496 Improve implementation of section 14.4.2.2 (Better function member).
2497 * expression.cs (Invocation.MoreSpecific): Compare all type
2498 arguments before deciding if one type is more specific than
2499 another. Handle array types too. Return the more specific type.
2500 (Invocation.BetterFunction): Add more tie-breaking rules from
2501 section 14.4.2.2. Perform "more specific" check after
2502 other tie-breaking rules. Compare all parameter types before
2503 choosing the "more specific" method.
2505 2006-01-21 Raja R Harinath <harinath@gmail.com>
2506 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2509 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2511 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2512 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2514 2006-01-18 Martin Baulig <martin@ximian.com>
2516 * class.cs (TypeContainer.AddToMemberContainer): Use
2517 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2520 2006-01-18 Martin Baulig <martin@ximian.com>
2522 Fix #76417: a generic class may now have methods which may unify
2523 for some type parameter substitutions.
2525 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2526 for methods which may unify anymore.
2528 * expression.cs (Invocation.MoreSpecific): New private static
2529 method; checks whether one method is more specific than another
2530 according to 14.4.2.2 of the spec.
2531 (Invocation.BetterFunction): Implement the tie-breaking rules from
2532 14.4.2.2 of the spec: if two methods unify for some type parameter
2533 substitution, we need to pick the more specific one.
2535 2006-01-18 Raja R Harinath <rharinath@novell.com>
2537 Fix #76656, cs0231-2.cs.
2538 * cs-parser.jay (formal_parameter_list): Make error case catch
2540 (parenthesized_expression_0): Add CS1026 check.
2541 (invocation_expression): Remove unused { $$ = lexer.Location }.
2543 2006-01-17 Raja R Harinath <rharinath@novell.com>
2546 * cs-parser.jay (statement_expression): Don't list out the
2547 individual statement-expressions. Convert syntax error into
2550 2006-01-16 Raja R Harinath <rharinath@novell.com>
2553 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2554 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2555 CheckIntermediateModification.
2556 (FieldExpr.DoResolve): Add new two-argument version that
2557 allows us to resolve the InstanceExpression as an lvalue.
2558 The one-argument variant is now just a wrapper.
2559 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2560 Resolve the lhs as an lvalue if the it has a value type.
2561 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2562 from Assign.DoResolve.
2563 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2564 resolved as an lvalue.
2565 (PropertyExpr.DoResolve): Update.
2566 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2567 has a value type. Move CS1612 check here from
2568 CheckIntermediateModification.
2569 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2570 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2571 'right_side' of a ResolveLValue on an 'out' argument.
2572 (EmptyExpression.LValueMemberAccess): New. Used as the
2573 'right_side' of a propagated ResolveLValue on a value type.
2574 (LocalVariableReference.DoResolveBase): Recognize
2575 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2577 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2578 EmptyExpression.Null.
2580 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2582 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2583 Type.IsGenericParameter(). Fixed bug #77183.
2584 * doc.cs : it is now identical to doc.cs in mcs.
2586 2006-01-16 Martin Baulig <martin@ximian.com>
2588 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2590 2006-01-16 Martin Baulig <martin@ximian.com>
2592 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2593 ctors; fixes #77250.
2595 2006-01-12 Miguel de Icaza <miguel@novell.com>
2597 This fixes the problem where we used ldfld instead of ldflda to
2598 load the "THIS" pointer on captured parameters, when THIS is a
2599 value type. See bug #77205.
2601 * iterators.cs (CapturedThisReference.Emit): Pass false to
2602 EmitThis (we do not need the address).
2604 * codegen.cs (EmitThis): it needs to know whether we need the
2605 address of `this' or not. This is used by value types.
2607 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2608 every other call passes false.
2610 2006-01-12 Raja R Harinath <rharinath@novell.com>
2613 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2615 * expression.cs (Invocation.OverloadResolve): Update.
2616 (Invocation.DoResolve): Avoid double resolution of invocation.
2618 2006-01-11 Raja R Harinath <rharinath@novell.com>
2621 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2622 unary negation of floating point types as 0-expr; negation cannot
2623 overflow in floating point types.
2626 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2627 on operands of 'void' type.
2630 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2631 and ExclusiveOr for boolean constants too.
2633 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2635 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2637 2006-01-12 Miguel de Icaza <miguel@novell.com>
2639 * cs-tokenizer.cs (Position): New class used to save and restore
2640 the position state in the tokenizer. Before this patch the save
2641 and restore was not complete enough so the line and columns would
2642 start to drift and the debugger and stack traces will get the
2645 2006-01-10 Martin Baulig <martin@ximian.com>
2648 (TypeParameter.InflateConstraints): New public method.
2650 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2651 constraints; fixes #77042.
2653 2006-01-10 Martin Baulig <martin@ximian.com>
2655 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2656 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2659 2006-01-09 Raja R Harinath <rharinath@novell.com>
2662 * expression.cs (Invocation.OverloadResolve): Replace reflected
2663 override methods with their base virtual methods, rather than
2665 * typemanager.cs (TypeManager.GetOverride): New.
2667 2005-12-21 Miguel de Icaza <miguel@novell.com>
2669 * driver.cs: Report the case of no source files and no -out:
2672 2005-12-20 Raja R Harinath <rharinath@novell.com>
2675 * expression.cs (ComposedCast.GetSignatureForError): Define.
2677 2006-01-05 Jb Evain <jbevain@gmail.com>
2679 * class.cs (Property.Define, Indexer.Define): do not tag the
2680 properties as SpecialName | RTSpecialName.
2682 2006-01-04 Miguel de Icaza <miguel@novell.com>
2684 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2685 doing a low-level comparission of parameter types. It was lacking
2686 a check for __argslist.
2688 2005-12-30 Miguel de Icaza <miguel@novell.com>
2690 * expression.cs (ParameterReference.DoResolveBase): Allow
2691 reference parameters if they are local to this block.
2693 This allows the ref and out parameters of a delegate to be used in
2694 an anonymous method, for example:
2696 delegate void set (out int x);
2698 set s = delegate (out int x){
2702 This is used by functionality introduced late in the C# language.
2704 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2705 method that take ref and out parameters.
2707 Fixes #77119 which was a late change in the spec.
2709 2005-12-23 Miguel de Icaza <miguel@novell.com>
2711 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2712 parent if its the same scope. Fixes #77060.
2714 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2716 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2718 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2720 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2721 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2722 that doesn't contain the full public key. This is a update of the
2723 friend assemblies in .Net 2.0 release.
2725 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2729 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2730 ListDictionary, to contain the ExternAliasEntry entries (in
2731 addition to the NamespaceEntry.aliases hashtable). This field is
2732 shared between the original entry and its doppelganger (bodyless
2734 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2735 extern_aliases field.
2736 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2737 lookup in extern_aliases.
2739 2005-12-16 Raja R Harinath <rharinath@novell.com>
2742 * class.cs (TypeContainer.Mark_HasEquals): New.
2743 (TypeContainer.Mark_HasGetHashCode): New.
2744 (ClassPart): Override them.
2745 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2747 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2748 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2752 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2753 'parent' argument to the base constructor.
2755 Remove all mention of TypeContainer from decl.cs.
2756 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2757 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2758 (DeclSpace.DeclSpace): Likewise.
2759 (DeclSpace.DefineMembers): Remove unused argument.
2760 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2761 debugging check -- we don't care if the debug code throws an
2762 InvalidCastException instead of an InternalErrorException.
2763 * class.cs (TypeContainer.DefineMembers): Update to changes.
2764 (TypeContainer.DoDefineMembers): Likewise.
2765 (TypeContainer.GetMethods): Likewise.
2766 (PropertyMember.Define): Likewise.
2767 (MemberBase.Parent): New property that forwards to
2768 MemberCore.Parent, but ensures that we get a TypeContainer.
2769 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2770 (RootContext.PopulateTypes): Likewise. Remove special case code
2771 for !RootContext.StdLib: DefineMembers is idempotent.
2773 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2775 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2777 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2779 * doc.cs : The search for referenced namespace was insufficient to
2780 get global one as it used to do. Fixed bug #76965.
2782 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2784 * doc.cs : check name in cref in the last phase that whether it is
2787 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2789 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2792 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2794 * doc.cs : so it turned out that we cannot skip override check for
2795 interface members. Fixed bug #76954.
2797 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2799 * cs-tokenizer.cs : fixed bug #75984:
2800 - #warning and #error should not be handled when the source line
2802 - #line is not checked strictly when the source line is disabled.
2803 - #define and #undef is on the other hand checked strictly at any
2806 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2808 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2811 2005-12-15 Raja R Harinath <rharinath@novell.com>
2813 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2815 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2818 2005-12-14 Martin Baulig <martin@ximian.com>
2820 * typemanager.cs (TypeManager.GetFullName): Make this public;
2821 `Type.Fullname' now never returns null.
2823 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2824 explicit interface implementations; we're now using the same
2825 naming convention than csc does.
2827 2005-12-14 Miguel de Icaza <miguel@novell.com>
2829 * convert.cs (ExplicitConversionCore): Check the return value from
2830 ExplicitConversionCore which can return null on failure. Fixes #76914
2832 2005-12-09 Raja R Harinath <rharinath@novell.com>
2834 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2835 instead of IsGenericInstance.
2836 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2837 code that's now covered by the more general test.
2838 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2840 * generic.cs (DropGenericTypeArguments): New. Captures the common
2841 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2842 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2843 * generic.cs, report.cs, typemanager.cs: Likewise.
2845 2005-12-08 Martin Baulig <martin@ximian.com>
2847 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2849 * typemanager.cs (TypeManager.CSharpSignature): Include type
2850 arguments in the signature of a generic method.
2852 2005-12-07 Martin Baulig <martin@ximian.com>
2854 Add support for custom attributes on type parameters.
2856 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2858 * generic.cs (TypeParameterName): New public class; we use this
2859 instead of a `string' to store the name of a type parameter, so we
2860 can also have `Attributes'.
2861 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2862 array instead of a `string[]' array.
2863 (TypeParameter.ctor): We now also take an `Attributes' argument.
2864 (TypeParameter.EmitAttributes): New public method; emit our
2865 `OptAttributes' here.
2866 (GenericMethod.EmitAttributes): New public method; emit the custom
2867 attributes on all our type parameters.
2869 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2870 our type parameters.
2871 (MethodData.Define): If we're a generic method, call
2872 EmitAttributes() on it.
2874 2005-12-07 Martin Baulig <martin@ximian.com>
2877 (ConstraintChecker): New public abstract class; move the
2878 constraint checking here from `ConstructedType' and also do
2879 constraint checking for generic methods here.
2881 * expression.cs (Invocation.OverloadResolve): Use
2882 ConstraintChecker.CheckConstraints() if we resolved to a generic
2885 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2887 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
2889 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
2891 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
2892 (FieldBase.Initializer): Initializer is now optional.
2893 (EventField.Define): Only event field can have initializer.
2895 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
2897 * const.cs (Const): Reuse initializer.
2899 * cs-parser.jay: Updated after FieldBase changes.
2900 Added current_array_type to simplify array initializers.
2902 * ecore.cs (NullCast.IsDefaultValue): Implemented.
2904 * expression.cs, iterators.cs: Updated.
2906 * namespace.cs (NamespaceEntry): Made UsingFound private.
2908 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2910 * parameterCollection.cs: Obsolete, removed.
2911 * parser.cs: Obsolete, removed.
2913 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2916 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
2918 * enum.cs (Enum.Define): Set obsolete context here.
2920 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2923 - FindDocumentedMember() now expects 1) paramList as null
2924 when "we don't have to check the number of parameters" and
2925 2) Type.EmptyTypes when "there is no arguments".
2926 - Introduced FoundMember struct to hold the exact type which was
2927 used to find the documented member (the above change broke
2928 test-xml-044; it might be better just to use DeclaringType than
2929 what MS does, like this change does, but it depends on usage.)
2931 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2933 * doc.cs : documented member might be from DeclaringType for nested
2934 types. Fixed bug #76782.
2936 2005-12-03 Ben Maurer <bmaurer@ximian.com>
2938 * anonymous.cs: Have the param code handle leaving copies on the
2939 stack etc. Allows anonymous params to take part in the assignment
2940 code (++, +=, etc). Fixes bug #76550
2942 * expression.cs: Handle the prepare_for_load/leave_copy by passing
2943 it down to the anon code.
2945 * iterators.cs: Use dummy var here
2947 * codegen.cs: Handle new vars
2949 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2952 * class.cs (MethodData.Define): Set proper Obsolete context.
2954 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
2956 (FieldExpr.DoResolve): Ditto.
2958 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2961 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
2962 parent is not obsolete.
2964 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
2966 * doc.cs : (FindDocumentedMember) find parameterless members first
2967 and get CS0419 in the early stage. Fixed first case of bug #76727.
2969 2005-11-30 Marek Safar <marek.safar@seznam.cz>
2972 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
2973 no error was reported.
2975 *expression.cs (Binary.DoResolve): left can be null.
2977 2005-12-06 Raja R Harinath <rharinath@novell.com>
2979 * class.cs (MethodCore.CheckGenericOverride): Delete unused
2980 abstract method and all overrides.
2981 * support.cs (ParameterData.GenericConstraints): Delete.
2982 (ReflectionParameters.type_params): Delete.
2983 (ReflectionParameters.ReflectionParameters): Make private.
2984 (ReflectionParameters.GetConstaints): New factory method.
2985 * generic.cs (TypeParameterDefineType): Use it.
2986 (TypeManager.GetTypeParameterConstraints): Likewise.
2988 2005-11-22 Marek Safar <marek.safar@seznam.cz>
2991 * class.cs (MethodData.Emit): Parameters should be labeled first.
2993 2005-11-21 Marek Safar <marek.safar@seznam.cz>
2996 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
2998 2005-11-18 Marek Safar <marek.safar@seznam.cz>
3000 * attribute.cs (AreParametersCompliant): Moved to Parameter.
3002 * class.cs (MethodCore): Parameter clean up.
3003 (IMethodData): Added ParameterInfo.
3004 (MethodData): Parameter clean up.
3005 (Indexer.Define): Parameter clean up.
3017 * typemanager.cs: Parameter clean up.
3019 * delegate.cs (Define): Get rid of duplicated code.
3021 * expression.cs (ParameterReference): Removed useless parameters
3023 (Invocation): Ditto.
3025 * parameter.cs (ParamsParameter): New class, params specialization.
3026 (ArglistParameter): Attemp to separate arglist.
3027 (Parameter): Refactored to be reusable and faster.
3028 (Parameter.Modifier): Made understandable.
3029 (Parameters): Changed to be used as a class for `this' assembly
3030 parameters. Refactored to use new specialized classes.
3032 * support.cs (ParameterData): Added Types property.
3033 (InternalParameters): Deleted.
3035 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3037 * doc.cs : the previous patch does not actually fix the bug.
3038 PropertyInfo override check is now implemented and really fixed it.
3039 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
3041 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3043 * doc.cs : apply "override filter" also to properties.
3046 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3048 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
3049 no need to check overrides. For classes, omit those results from
3050 interfaces since they must exist in the class. Fixed bug #76726.
3052 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3054 * typemanager.cs : (GetFullNameSignature) differentiate indexers
3055 with different parameters. Fixed the second problem in #76685.
3057 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3059 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
3060 get expected 'protected' access in CheckValidFamilyAccess()).
3063 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3065 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
3066 Fixed bug #76705. CS1569 was incorrectly commented out.
3068 2005-11-23 Martin Baulig <martin@ximian.com>
3070 * generic.cs (Constraints.Define): Removed.
3071 (TypeParameter.DefineConstraints): Removed.
3072 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
3073 on the GenericTypeParameterBuilder here.
3075 2005-11-23 Martin Baulig <martin@ximian.com>
3077 * typemanager.cs (TypeManager.GetProperty): Make this public.
3079 * generic.cs (Nullable.NullableInfo.ctor): Use
3080 TypeManager.GetProperty() rather than using reflection directly.
3082 2005-11-17 Martin Baulig <martin@ximian.com>
3084 * expression.cs (Indexers.GetIndexersForType): Added support for
3085 generic parameters; fixes #76587.
3087 2005-11-17 Martin Baulig <martin@ximian.com>
3090 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
3091 inherit the scope from our parent. Fixes #76653.
3093 2005-11-15 Martin Baulig <martin@ximian.com>
3095 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
3096 instead of `ScopeTypeBuilder' to refer to the "current" type.
3097 (AnonymousMethod.CreateScopeType): Correctly create the helper
3098 class if we're inside a generic type definition.
3100 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3102 * doc.cs : use Invocation.IsOverride() to do real override check.
3103 * expression.cs : made Invocation.IsOverride() internal.
3105 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3107 * doc.cs : use TypeManager.FindMembers() instead of (possible)
3108 TypeBuilder.FindMembers() and filter overriden base members out.
3111 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3113 * doc.cs : ref/out parameters are represented as '@' (instead of
3114 '&' in type FullName). Fixed bug #76630 (additionally crefs).
3116 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3118 * doc.cs : when there was no '.' in cref to methods in doc comment,
3119 then parameters were missing in the output. Fixed bug #76691.
3121 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3123 * driver.cs : don't output docs when there is an error.
3126 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3129 Now it should detect indexers. Fixed primary concern in bug #76685.
3130 Fixed CS0419 message to not show the identical member signature in
3133 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3135 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
3136 instead of Type.FindMembers() since it does not handle events.
3139 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
3141 * codegen.cs: Fixed typo (speficied -> specified).
3143 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3146 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
3148 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3150 * attribute.cs: Changed error message.
3152 * cs-tokenizer.cs: One more check.
3154 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3156 * statement.cs (Block.Resolve): Ignore empty statement.
3158 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3160 * report.cs: Made error/warning methods more strict to avoid
3163 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
3164 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
3165 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
3166 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
3168 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3170 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
3171 Use the more explicit AssemblyName.FullName instead of
3172 AssemblyName.Name to report errors.
3174 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3176 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
3179 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3189 * report.cs: Fixed error reporting and typos.
3191 * generic.cs (TypeParameter.GetSignatureForError): New method.
3192 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
3194 * typemanager.cs (GetFullName): Refactored.
3196 2005-11-08 Marek Safar <marek.safar@seznam.cz>
3198 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
3199 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
3201 * class.cs (TypeContainer.IsComImport): New property.
3202 (Constructor.Define): Create proper ctor for ComImport types.
3204 * expression.cs (New.CheckComImport): Fixed.
3206 2005-11-07 Miguel de Icaza <miguel@novell.com>
3208 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
3209 that a parameter has been captured does not mean that we do not
3210 have to do the rest of the processing. This fixes the second part
3211 of #76592. If there was another anonymous method capturing
3212 values in the past, the Scope would never be set for the second
3213 method that captured the same parameter.
3215 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
3216 properly manipulate the stack. Second part of fix for #76592.
3218 * expression.cs (New): Add support for invoking "new" on
3219 interfaces that have been flagged with the ComImport attribute and
3220 the CoClass. Fixes #76637
3222 * statement.cs (Try.DoEmit): When a variable is captured, do not
3223 try to emit the vi.LocalBuilder variable as it has been captured.
3224 Create a temporary variable and store the results on the
3225 FieldBuilder. Fixes #76642
3227 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3229 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
3231 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
3233 * expression.cs (Binary.DoResolve): Added && optimalization.
3235 * typemanager.cs (AddUserType): Removed useless argument.
3237 2005-11-04 Marek Safar <marek.safar@seznam.cz>
3239 * statement.cs (Block.variables): Uses ListDictionary.
3241 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3244 * class.cs (PartialContainer.EmitType): Customized to emit
3245 security attributes.
3246 (ClassPart.ApplyAttributeBuilder): Transform security attribute
3247 for partial classes.
3249 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3252 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
3253 access has to be fixed.
3255 * typemanager.cs (IsUnmanagedType): Wrong common field type.
3257 2005-11-01 Marek Safar <marek.safar@seznam.cz>
3260 * ecore.cs (NullCast.Reduce): Implemented.
3262 * expression.cs (ArrayCreation.CheckIndices): Correcly check
3265 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
3267 (Foreach.Resolve): Catch null properly.
3269 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3271 * cs-tokenizer.cs: Warning text fix.
3273 * driver.cs: AllWarningNumbers exposed on public interface.
3275 * report.cs (): Reviewed warning numbers.
3276 (IsValidWarning): Use binary search.
3278 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3280 * driver.cs: Implemeted resource visibility.
3281 (Resources): New class for code sharing between /res: and
3284 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3286 decl.cs (CurrentTypeParameters): Fixed to be public.
3288 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3290 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3292 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3294 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3296 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3298 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3300 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3302 Add friend assembly access support.
3303 * typemanager.cs: assembly_internals_vis_attrs
3304 cache for friend assembly access.
3305 (TypeManager.IsFriendAssembly): New method for
3306 checking friend assembly access.
3307 (TypeManager.Error_FriendAccessNameNotMatching): New
3309 (TypeManager.CompareKeyTokens): Likewise.
3310 (TypeManager.Filter): Handle friend accessible
3313 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3314 friend accessible types.
3316 * ecore.cs (Expression.IsAccessorAccessible): Handle
3317 friend accessible properties.
3319 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3322 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3325 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3328 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3331 * ecore.cs (NullCast): Child is contant only.
3333 * literal.cs (NullLiteral.Reduce): null can be converted to any
3336 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3338 * driver.cs: Use Encoding.Default as default code page instead
3341 2005-10-27 Raja R Harinath <rharinath@novell.com>
3344 * expression.cs (Invocation.Error_InvalidArguments): Handle
3345 __arglist parameters.
3346 (Invocation.VerifyArgumentsCompat): Likewise.
3347 * support.cs (ReflectionParameters.GetSignatureForError): Print
3348 __arglist parameters.
3349 (InternalParamters.GetSignatureForError): Likewise.
3350 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3352 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3354 * attribute.cs (GetPropertyValue): Made public.
3356 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3358 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3360 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3363 * driver.cs: Reflect method name change.
3365 * statement.cs (Try.Resolve): Warn when try has both general
3368 * typemanager.cs: runtime_compatibility_attr_type new predefined
3371 2005-10-26 Raja R Harinath <harinath@gmail.com>
3374 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3375 treat it as an empty parameter list.
3377 2005-10-26 Raja R Harinath <rharinath@novell.com>
3380 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3381 ResolveAsTypeStep silent.
3382 * statement.cs (Block.AddConstant): Mark block as used.
3383 (Block.ResolveMeta): Avoid piling on error messages
3384 if a constant initializer resolution fails.
3386 2005-10-25 Raja R Harinath <rharinath@novell.com>
3388 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3390 (NamespaceEntry.VerifyAllUsing): New.
3391 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3392 behaviour. Delegates actual resolution of alias to ...
3393 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3394 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3396 * driver.cs (Driver.MainDriver): Update.
3398 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3399 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3401 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3403 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3404 RootNamespace.DefineNamespacesForAll.
3406 2005-10-24 Raja R Harinath <harinath@gmail.com>
3408 * typemanager.cs (assemblies, external_aliases, modules)
3409 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3410 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3411 overhead. Move resposibility ...
3412 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3413 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3415 2005-10-23 Raja R Harinath <harinath@gmail.com>
3417 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3418 cached_namespaces. Improve usage.
3419 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3420 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3421 Move from GlobalRootNamespace and simplify.
3422 (RootNamespace.Global): Make instance variable.
3423 (RootNamespace.RootNamespace): Add "alias name" parameter.
3424 (GlobalRootNamespace): Simplify drastically.
3425 (Namespace.Lookup): Don't use GetNamespace.
3426 * typemanager.cs (GetRootNamespace): Rename from
3427 ComputeNamespaceForAlias.
3428 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3430 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3432 * anonymous.cs (AnonymousContainer): Don't crash when container
3435 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3437 * expression.cs (Binary.DoResolve): Warn when comparing same
3440 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3443 * expression.cs (Binary.DoResolve): It looks like there are no
3444 convetsion rules in enum context.
3446 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3448 Add support for extern alias qualifiers.
3449 * typemanager.cs: Move some LookupTypeReflection code
3450 to namespace.cs, to have cleaner code. Added some methods
3451 to help us keep track of the extern aliased references.
3452 * driver.cs: Add suport for extern alias assemblies on command
3453 line and check for their warnings/errors. Also keep track of the
3454 extern aliased assemblies.
3455 * namespace.cs: Move the global functionality of Namespace
3456 to GlobalRootNamespace/RootNamespace. Now the global namespace
3457 is GlobalRootNamespace.Globa. Also the code moved from
3458 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3459 Finally added LocalAliasEntry (AliasEntry before) and
3460 ExternAliasEntry, to handle alias statements.
3461 * cs-parser.jay: Add support in the grammar for extern alias
3463 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3464 Update callings to Namespace (now in GlobalRootNamespace).
3466 2005-10-25 Martin Baulig <martin@ximian.com>
3468 * convert.cs (ImplicitTypeParameterConversion): Make base
3469 interfaces actually work; fixes #76557.
3471 2005-10-25 Martin Baulig <martin@ximian.com>
3474 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3475 all the type parameters; fixes #76551.
3477 2005-10-25 Martin Baulig <martin@ximian.com>
3482 (GenericMethod.ctor): Added `Expression return_type' and
3483 `Parameters parameters' arguments.
3484 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3485 parameter and return types to check their constraints if they're
3488 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3491 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3492 constraints of a generic type if `ec.ResolvingGenericMethod'.
3494 * class.cs (MethodCore.DoDefineParameters): Set
3495 `ec.ResolvingGenericMethod' if we're a generic method.
3496 (MemberBase.MemberType): Likewise.
3498 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3500 * typemanager.cs (TypeManager): Added
3501 TypeManager.internals_visible_attr_type to cache
3502 S.R.CompilerServices.InternalsVisibleToAttribute.
3504 * codegen.cs (AssemblyClass): Added checks for
3505 InternalsVisibleToAttribute in new method
3506 CheckInternalsVisibleAttribute () and also cache the
3507 AssemblyName in AssemblyClass.Name.
3509 2005-10-24 Martin Baulig <martin@ximian.com>
3512 (TypeManager.ExpandInterfaces): Added overloaded version which
3513 just takes a `Type[]' array.
3516 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3517 just use the interfaces which were explicitly specified and not
3518 the interfaces they inherit. Fixes #76482.
3519 (TypeParameter.FindMembers): Expand the interfaces here.
3521 2005-10-21 Martin Baulig <martin@ximian.com>
3524 (Constraints.Resolve): Also resolve the actual types here.
3525 (Constraints.ResolveTypes): Just check the constraints here.
3526 Fixes #76363; see gtest-218.cs.
3528 2005-10-21 Martin Baulig <martin@ximian.com>
3531 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3532 instead of a `BoxedCast'; fixes gtest-217.cs.
3534 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3536 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3537 1) "new()" is specified as generic parameter constraint and 2) the
3538 type is TypeBuilder and 3) the type is abstract even if it has a
3539 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3541 2005-10-20 Martin Baulig <martin@ximian.com>
3544 (GenericConstraints.TypeParameter): New public property.
3545 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3546 (TypeParameter.DeclSpace): New public property.
3547 (TypeParameter.DefineType): Inflate the constraints if our
3548 `DeclSpace' is an `Iterator'.
3550 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3552 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3553 GenericMethod argument to compare methods' generic type arguments.
3556 2005-10-19 Martin Baulig <martin@ximian.com>
3558 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3559 not ResolveType() when resolving the base type, so we're not
3560 checking the constraints here.
3561 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3564 2005-10-19 Martin Baulig <martin@ximian.com>
3566 * generic.cs (ConstructedType.CheckConstraints): Committing
3567 untested fix for #76441.
3569 2005-10-18 Raja R Harinath <rharinath@novell.com>
3572 * class.cs (TypeContainer.DefineType): Move updating of
3573 topological sort earlier in the code.
3574 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3576 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3579 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3581 * constant.cs (Constant.TryReduce): Moved from Cast class.
3582 (Reduce): Made little bit more OO and fixed missing conversions.
3584 * ecore.cs (Reduce): Implemented.
3585 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3587 * literal.cs (Reduce): Implemented.
3589 * class.cs: Reverted Miguel's wrong commit.
3591 2005-10-14 Miguel de Icaza <miguel@novell.com>
3593 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3595 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3597 * cs-parser.jay, expression.cs : CS0214 was missing error location
3598 for constants. Fixed bug #76404.
3600 2005-10-10 Raja R Harinath <rharinath@novell.com>
3602 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3604 (PropertyExpr.EmitCall): Likewise.
3605 * expression.cs (Invocation.EmitArguments): Handle case where
3607 (Invocation.EmitCall): Avoid allocating temporary variable if
3608 there are no arguments.
3610 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3613 * convert.cs (ExplicitConversionCore): Fixed object->enum
3616 2005-10-07 Raja R Harinath <rharinath@novell.com>
3619 * convert.cs (ImplicitConversionStandard): Move conversion of
3620 void* to arbitrary pointer types ...
3621 (ExplicitConversionStandard): .. here.
3622 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3623 error to always print typenames.
3625 2005-10-07 Raja R Harinath <rharinath@novell.com>
3627 * convert.cs (GetConversionOperator): Rename from
3628 GetConversionOperators. Move operator selection code from ...
3629 (UserDefinedConversion): ... here.
3631 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3633 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3636 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3638 * assign.cs (Assign.DoResolve): Error method changed.
3640 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3642 * const.cs (ResolveValue): Reset in_transit immediately.
3644 * constant.cs: Error method changed.
3646 * convert.cs: Removed useless location parameter.
3647 (ExplicitNumericConversion): Don't do double enum check.
3648 (ExplicitConversionCore): Renamed from ExplicitConversion.
3649 (ExplicitUnsafe): Extracted from ExplicitConversion.
3650 (ExplicitConversion): Uses for error reporting.
3652 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3654 (ResolveBoolean): Uses common error method.
3655 (CastToDecimal): Get rid of ec.
3656 (CastFromDecimal): Optimized.
3657 (ConvCast): Get rid of ec.
3659 * enum.cs (ResolveValue): Reset in_transit immediately.
3660 (Emit): Return after first error.
3662 * expression.cs: Convert changes.
3664 * literal.cs: Error method changed.
3666 * statement.cs: Error method changed.
3668 2005-10-06 Raja R Harinath <rharinath@novell.com>
3670 Fix gtest-131.cs and gtest-211.cs.
3671 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3672 Only emit code for a label if it is used. Unreachable code can
3673 violate ECMA evaluation stack invariants.
3675 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3677 * anonymous.cs: Implemented ExprClassName.
3679 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3682 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3685 * class.cs (StaticClass.DefineContainerMembers): Report protected
3688 * codegen.cs: if(ed) PRODUCTION.
3690 * convert.cs (Error_CannotImplicitConversion): Better error
3693 * cs-parser.jay: More error checks.
3695 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3697 * driver.cs (CSCParseOption): Enabled wrong option check.
3699 * ecore.cs (Expression.ExprClassName): Turned to property.
3700 (MemberExpr.CheckIntermediateModification): For checking boxed
3701 value types modification.
3703 * statement.cs (Fixed.Resolve): Expression type must be
3704 convertible to fixed type.
3705 (CollectionForeach.GetEnumeratorFilter,TryType):
3706 Small refactoring for easier error checking.
3708 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3710 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3713 * class.cs (GeneratedBaseInitializer): New class for customization
3714 compiler generated initializers.
3715 (MemberBase.DoDefine): Check Obsolete attribute here.
3716 (FieldMember.DoDefine): Ditto.
3718 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3721 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3722 (MemberCore.GetObsoleteAttribute): Removed argument.
3723 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3724 (MemberCore.CheckObsoleteType): New helper.
3728 * statement.cs: Updates after MemberCore changes.
3730 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3731 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3733 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3734 obsolete attribute for compiler construct.
3735 (As.DoResolve): Cache result.
3737 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3739 2005-10-01 Miguel de Icaza <miguel@novell.com>
3741 * expression.cs (Probe): instead of having a "Type probe_type"
3742 keep the extra information as a TypeExpr probe_type_expr since the
3743 "As" operator needs to perform some type checks.
3745 * (As.DoResolve): If the type is a type parameter, ensure that it
3746 is constrained by a class.
3748 2005-09-22 Miguel de Icaza <miguel@novell.com>
3750 * statement.cs (Lock): Use the TemporaryVariable class instead of
3751 manually using local variables as those do not work when variables
3754 * ecore.cs: Moved the TemporaryVariable class from being a nested
3755 class inside Foreach to be a public class that can be employed in
3758 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3760 * cs-parser.jay: interface_accessors replaced by
3761 accessor_declarations.
3763 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3766 * statement.cs (GotoCase.Resolve): Convert null constant to
3768 (SwitchLabel.ResolveAndReduce): Ditto.
3769 (SwitchLabel.NullStringCase): Custom null stamp.
3770 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3772 typemanager.cs (CSharpSignature): Don't skip first argument
3775 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3777 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3778 expression.cs, iterators.cs, literal.cs: Store constants and
3781 * class.cs (MemberBase.ShortName): Pass location.
3783 * cs-parser.jay: Some location fixes.
3785 * ecore.cs (Expression.Location): Made virtual.
3787 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3790 * const.cs (Const.ResolveValue): Check for assigning non-null
3791 value to reference type.
3793 2005-09-26 Raja R Harinath <rharinath@novell.com>
3796 * expression.cs (This.VerifyFixed): In a value type T, the type of
3797 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3798 value type R, 'this' is treated as a value parameter.
3800 2005-09-05 Miguel de Icaza <miguel@novell.com>
3802 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3803 if the underlying types are the same, otherwise we need to produce
3804 code that will do the proper cast.
3806 This was exposed by Marek's constant rewrite which produced
3807 invalid code for the call site:
3810 void Method (X v) {}
3814 This fixes test-49.cs
3816 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3818 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3819 Type/Object should be allowed as well. Fixed bug #75968.
3821 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3823 * expression.cs : (Binary.DoResolve): when one is enum constant and
3824 another is constant 0, then return enum one *as enum type*.
3827 2005-10-04 Martin Baulig <martin@ximian.com>
3829 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3830 `SetMemberIsUsed()' work for generics, too.
3832 2005-10-04 Martin Baulig <martin@ximian.com>
3834 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3835 for corlib. Fixes #75691.
3837 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3840 * driver.cs: Fix compilation files with full root path.
3842 2005-09-25 Miguel de Icaza <miguel@novell.com>
3844 * report.cs (SymbolRelatedToPreviousError): Format the output so
3845 it does not use an open parenthesis that is never closed.
3847 * driver.cs: Follow coding guidelines
3849 2005-09-18 Miguel de Icaza <miguel@novell.com>
3851 * driver.cs: Set InEmacs based on the environment variable EMACS.
3853 * location.cs (InEmacs): in this mode, do not report column
3854 location as it confuses Emacs.
3856 2005-10-03 Raja R Harinath <rharinath@novell.com>
3858 * support.cs (SeekableStreamReader.Position): Don't error out when
3859 the requested position is just beyond the end of the current
3862 2005-09-28 Raja R Harinath <rharinath@novell.com>
3864 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3865 try to keep in sync with the byte count of the underlying Stream.
3866 However, this limits us to a window size of 2048 characters: i.e.,
3867 the maximum lookahead of our lexer/parser can be 2048 characters.
3869 2005-09-22 Martin Baulig <martin@ximian.com>
3871 * driver.cs: Removed a debugging FIXME.
3873 2005-09-21 Raja R Harinath <rharinath@novell.com>
3875 * cs-parser.jay (type_arguments): Add CS1644 check.
3876 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3878 2005-09-15 Raja R Harinath <rharinath@novell.com>
3880 * Makefile (PROGRAM): Make profile specific.
3881 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
3882 the current directory.
3885 * expression.cs (Invocation.EmitCall): Remove optimization on
3886 this_call since it doesn't handle 'this' being a value type.
3888 2005-09-05 Geoff Norton <gnorton@customerdna.com>
3890 * driver.cs: Ensure file handles are closed after parsing
3892 2005-09-05 Miguel de Icaza <miguel@novell.com>
3894 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3895 if the underlying types are the same, otherwise we need to produce
3896 code that will do the proper cast.
3898 This was exposed by Marek's constant rewrite which produced
3899 invalid code for the call site:
3902 void Method (X v) {}
3906 This fixes test-49.cs
3908 2005-09-05 Martin Baulig <martin@ximian.com>
3910 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
3911 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
3913 * cs-parser.jay (delegate_declaration): Small fix for #75852.
3915 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3917 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
3918 to be a pointer type due to the spec 25.2, so check if declaring
3919 type is generic type definition. Fixed bug #75772.
3921 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3924 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
3925 both types are not defined by methods.
3926 * expression.cs : (Invocation.IsApplicable): it should work when
3927 the argument type is equal to the parameter type, not only when
3928 ImplicitConversionExists() returns true.
3930 2005-09-02 Raja R Harinath <rharinath@novell.com>
3932 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
3936 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
3937 flow-branching for LocalVariableReferences in case we were invoked
3938 from a MemberAccess.
3939 * expression.cs (LocalVariableReference.VerifyAssigned): New.
3941 (LocalVariableReference.DoResolveBase): ... this.
3942 (MemberAccess.Resolve): Do the check that was disabled during
3945 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3948 (PartialContainer.Create): check abstract/sealed/static strictly
3949 but abstract/sealed can exist only at one side. Fixed bug #75883.
3951 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
3954 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
3955 specified, don't default to UnmanagedType.I4.
3957 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3959 * expression.cs : conditional operator should check possibly
3960 incorrect assign expression. Fixed bug #75946.
3962 2005-08-30 Raja R Harinath <rharinath@novell.com>
3965 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
3966 (ScopeInfo.EmitScopeType): Use it to construct field names from
3967 names of captured locals.
3970 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
3971 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
3972 Pass 'target_type' to BoxedCast. Don't default to 'object'.
3973 (ExplicitConversion): Remove enum cases already handled by
3974 implicit conversion. Move implicit conversion check to the beginning.
3975 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
3976 * expression.cs (ArrayCreation.EmitDynamicInitializers):
3977 Don't treat System.Enum as a struct.
3979 2005-08-30 Jb Evain <jbevain@gmail.com>
3981 * attribute.cs: handles as expression in parameters.
3983 2005-08-30 Raja R Harinath <rharinath@novell.com>
3986 * class.cs (TypeContainer.VerifyClsName): Don't use a
3987 PartialContainer when verifying CLS compliance.
3988 (AbstractPropertyEventMethod): Set Parent here, ...
3989 (PropertyMethod): ... not here.
3991 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
3993 * attribute.cs : escaped attribute name should not be allowed to be
3994 resolved (e.g. @class as classAttribute). Fixed bug #75930.
3996 2005-08-29 Raja R Harinath <rharinath@novell.com>
3999 * convert.cs (ImplicitStandardConversionExists): Allow zero also
4000 when converting a long constant to unsigned long.
4001 * expression.cs (Invocation.OverloadResolve): Add sanity check to
4002 detect where IsApplicable and VerifyArgumentsCompat disagree.
4004 2005-08-29 Raja R Harinath <rharinath@novell.com>
4005 and Carlos Alberto Cortez <carlos@unixmexico.org>
4008 * class.cs (TypeContainer.CanElideInitializer): New helper.
4009 (TypeContainer.EmitFieldInitializers): Use it to determine if we
4010 can safely emitting the initializer of a field.
4012 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4014 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
4015 allowed inside a switch (without loop). Fixed bug #75433.
4017 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4019 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4020 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4022 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4024 * driver.cs : kinda reverting the default encoding changes (not exact
4025 revert since I noticed that "codepage:reset" might not work fine).
4027 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4029 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
4030 Location. Now getter and setter store location correctly.
4031 (errors/cs0111-12.cs now reports the expected location.)
4033 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4035 * driver.cs : Use default encoding on the environment.
4036 Removed (now that) extra parameter for SeekableStreamReader.
4037 * support.cs : (SeekableStreamReader) third .ctor() argument for
4038 StreamReader is not required (always true). preamble size could
4039 be acquired in simpler and safe way.
4041 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
4043 * cs-parser.jay: report CS0642 at warning level 3
4044 and report CS0642 for an if else statement also
4045 fixes bug #74745. Patch by John Luke (and a bit
4047 Removed extra CS0642 warning check for "while",
4049 * statement.cs: In Block.Resolve(), CS0642 check
4050 is reimplemented to check a sequence of an empty
4051 statement and a block.
4053 Both fix bug #66777.
4055 2005-08-24 Marek Safar <marek.safar@seznam.cz>
4057 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
4058 detection until I fix it.
4060 * cs-tokenizer.cs: Changed error message.
4062 * cs-parser.jay: Fixed 2 error locations.
4064 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
4065 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
4068 * enum.cs (GetSignatureForError): Fixed.
4070 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
4074 * typemanager.cs (RegisterProperty): Removed.
4076 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
4078 2005-08-24 Raja R Harinath <rharinath@novell.com>
4081 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
4082 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
4084 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4086 * expression.cs : tiny fix is required for not warning positive ulong.
4089 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4091 * expression.cs : add CS0652 check for constant and integral
4092 expression. Fixed bug #53974.
4094 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4096 * expression.cs : in DoNumericPromotions(), check if there is implicit
4097 conversion overload for string (to check CS0034). Fixed bug #52492.
4099 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4101 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
4103 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4105 * ecore.cs : report location when it is *not* Null.
4107 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4113 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
4114 correctly. Fixed bug #75721.
4116 2005-08-23 Raja R Harinath <rharinath@novell.com>
4118 * support.cs (SeekableStreamReader.Position): Avoid an expensive
4119 loop that performs 'min (pos, char_count)'.
4122 * expression.cs (Unary.ResolveOperator): Don't discard implicit
4123 converted value in Operator.OnesComplement.
4125 2005-08-22 Ben Maurer <bmaurer@ximian.com>
4127 * anonymous.cs: If the anon method is pulled into a helper class,
4128 it needs to be `internal' not `private'. Fixes runtime behavior on
4131 2005-08-17 Marek Safar <marek.safar@seznam.cz>
4134 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
4137 2005-08-16 Marek Safar <marek.safar@seznam.cz>
4139 The big constants rewrite
4140 Fix #75746, #75685 and more
4141 As a side effect saved 1MB for MWF ;-)
4143 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
4144 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
4145 enum based for corlib compilation.
4147 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
4150 * class.cs (FixedField.Define): Use ResolveAsConstant.
4152 * const.cs (IConstant): Interface constants and enums.
4153 (Const.ResolveValue): New method for constant resolvning.
4154 (ExternalConstant): Constants from imported assemblies.
4156 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
4157 conversion; like enums.
4158 (Constant.ToType): Converts this constant to different type.
4159 (Constant.Increment): Adds 1.
4161 * convert.cs (ImplicitConversionRequired): Simplified.
4163 * cs-parser.jay: Create EnumMember directly.
4165 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
4167 * doc.cs (GenerateEnumDocComment): Removed.
4169 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
4170 (ConvertIntLiteral): Removed.
4171 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
4173 * enum.cs (EnumMember): Implement IConstant.
4174 (Enum.IsValidEnumConstant): Removed.
4175 (Enum.GetNextDefaultValue): Removed.
4176 (Enum.FindMembers): Updated.
4177 (Enum.GenerateDocComment): Iterate enum members.
4179 * expression.cs (Cast.TryReduce): Handle enums correctly.
4180 (New.Constantify): Made public.
4181 (MemberAccess.DoResolve): Removed contant specific if(s).
4183 * literal.cs (NullLiteral): Implement new abstract methods.
4185 * statement.cs (GotoCase.Resolve): Use new constant methods.
4186 (SwitchLabel.ResolveAndReduce): Use new constant methods.
4188 * typemanager.cs (LookupEnum): Removed.
4189 (IsEnumType): Fixed to work with corlib.
4190 (RegisterConstant): Removed.
4191 (LookupConstant): Removed.
4192 (GetConstant): Changed to work with IConstant.
4194 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
4196 * location.cs : Fixed overflown (>255) column number.
4198 2005-08-03 Raja R Harinath <rharinath@novell.com>
4200 First cut of the qualified-alias-member feature.
4201 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
4203 * cs-parser.jay (DOUBLE_COLON): New token.
4204 (namespace_or_type_name): Add rule for recognizing
4205 qualified-alias-members.
4206 (primary_expression): Likewise.
4207 (element_access): Allow QualifiedAliasMember as a possible
4208 type-bearing expression.
4209 (local_variable_type, local_variable_pointer_type): Likewise.
4210 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
4211 aliases in the current and enclosing namespace declarations.
4212 (NamespaceEntry.UsingAlias): Add CS0440 warning.
4213 * decl.cs (MemberName.is_double_colon): New.
4214 (MemberName.MemberName): Add new constructor for alias-member.
4215 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
4216 * expression.cs (QualifiedAliasMember): New expression type.
4218 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4220 * location.cs : it borked when no argument was specified.
4222 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4224 * location.cs : tiny ToString() format fix.
4226 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4228 * statement.cs : oops, it was missing.
4230 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4232 A set of fixes for precise line/column location.
4235 "token" field now holds a file/line "delta", a line number offset
4236 from the segment, and a column number. See also:
4237 http://lists.ximian.com/pipermail/mono-devel-list/2004-
4238 December/009508.html
4239 Removed static IsNull. Use instance IsNull property instead.
4241 For some tokens it stores Location. For Identifier it stores
4242 LocatedToken which is a pair of string name and location.
4243 Column numbers are adjusted only at getChar().
4245 Use Location.ToString() for reporting (it now contains column).
4247 Largely modified to use LocatedToken instead of
4248 string (IDENTIFIER), and to acquire Location from some tokens.
4249 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
4250 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
4252 Now MemberName holds Location. DeclSpace.ctor() receives Location
4253 as a parameter. Removed extra parameters to all derived classes.
4254 Replaced Location.IsNull() with instance property.
4255 * assign.cs, expression.cs :
4256 Added .ctor() overload that omits Location.
4258 Added "nameEscaped" flag that indicates the identifier was escaped
4259 in the source file. This fixes bug #57047.
4261 2005-09-02 Martin Baulig <martin@ximian.com>
4263 * class.cs: Make CS3005 a warning, not an error.
4265 2005-08-02 Marek Safar <marek.safar@seznam.cz>
4267 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
4268 New method, looking for lo-case imported cls type.
4270 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4273 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4275 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4277 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4279 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4281 Optimized to save 3.5 MB for SWF compilation.
4283 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4285 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4286 (PartialContainer.Create): Moved logic AddToContainer.
4287 (PartialContainer.MarkForDuplicationCheck): Shares name.
4289 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4292 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4294 (Namespace.GetSignatureForError): New method.
4296 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4297 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4299 2005-08-01 Raja R Harinath <rharinath@novell.com>
4302 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4303 member lookup rather than qualifier_type, since qualifier_type can
4306 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4308 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4311 2005-07-31 Miguel de Icaza <miguel@novell.com>
4313 * statement.cs: Copy the local exception into the exception
4314 captured local. Fixes 75674
4316 2005-07-31 Raja R Harinath <harinath@gmail.com>
4319 * expression.cs (Invocation.OverloadResolve): Don't report error
4320 CS1501 if error CS1502 has been reported.
4321 (New.DoResolve): Delegate CS1501 reporting to
4322 Invocation.OverloadResolve.
4325 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4326 invariant-meaning-in-block property in an enclosing block if
4329 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4331 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4332 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4333 (Switch.CheckSwitch): Just save 50kb for SWF.
4335 2005-07-27 Martin Baulig <martin@ximian.com>
4337 * anonymous.cs (CaptureContext.AddField): Added
4338 `AnonymousContainer am' argument; compute its toplevel scope if
4339 it's not already computed. Fixes #75649.
4341 2005-07-26 Raja R Harinath <rharinath@novell.com>
4344 * class.cs (Constructor.Emit): Reset block to null if the block
4347 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4349 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4351 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4353 * class.cs (MethodData.Define): Check whether accessor implementing
4354 interface is public.
4356 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4358 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4361 * namespace.cs (LookupType): Moved same type check to...
4363 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4366 2005-07-21 Raja R Harinath <rharinath@novell.com>
4368 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4369 already found a typebuilder.
4370 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4371 MemberNames, not strings.
4373 * const.cs (Error_ExpressionMustBeConst):
4374 Rename from Error_EpressionMustBeConst.
4375 * const.cs, class.cs, statement.cd: Update.
4377 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4381 * const.cs (Const.LookupConstantValue): Report missing contant expression
4383 (Error_EpressionMustBeConstant): Only one error method.
4385 * class.cs, statement.c: Updated.
4387 2005-07-20 Raja R Harinath <rharinath@novell.com>
4389 * statement.cs (Block.Flags): Add back HasVarargs.
4390 (Block.flags): Make protected.
4391 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4393 * typemanager.cs (types, typecontainers, user_types): Remove.
4394 (UserTypes, TypeContainers): Likewise.
4395 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4396 (CleanUp, Reset): Update.
4397 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4398 (GetNestedType): Use Type.GetNestedType.
4399 (CoreLookupType): Take two arguments, the namespace and the
4400 basename of the type. Update to use the Namespace.Lookup
4402 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4403 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4404 string concatenation and substring matches.
4405 * class.cs, enum.cs, delegate.cs: Update to changes.
4407 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4409 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4410 Expression and made virtual.
4412 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4413 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4415 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4417 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4420 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4423 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4426 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4427 AssemblyCultureAttribute is not used on executable.
4430 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4432 2005-07-16 Raja R Harinath <rharinath@novell.com>
4435 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4436 New. Reports CS0252/CS0253.
4437 Mostly taken from preliminary patch by Duncak Mak.
4438 (Binary.DoResolveOperator): Store results of operator lookup.
4439 Use them to detect if we need to warn about unintended reference
4442 2005-07-15 Raja R Harinath <rharinath@novell.com>
4445 * namespace.cs (Namespace.Lookup): Add back location parameter.
4446 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4447 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4449 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4450 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4451 (Namespace.LookupType): ... this.
4452 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4454 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4455 purported to handle pointers.
4456 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4459 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4461 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4464 2005-07-15 Raja R Harinath <rharinath@novell.com>
4466 * namespace.cs (Namespace.Lookup): Drop location parameter.
4467 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4468 (NamespaceEntry.Lookup): ... this.
4469 (NamespaceEntry.Error_AmbiguousTypeReference):
4470 Move here from DeclSpace.
4471 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4473 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4474 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4475 Move to NamespaceEntry.
4476 * delegate.cs, expression.cs: Update to changes.
4478 2005-08-31 Martin Baulig <martin@ximian.com>
4480 Committing a patch from Atsushi Enomoto for #75850.
4482 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4483 Prefer a generic enumerator over a non-generic one.
4485 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4487 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4488 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4490 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4492 * driver.cs : reverting default encoding change as well as mcs.
4494 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4496 * driver.cs, support.cs : merged r48826.
4498 > could you integrate your mcs changes to gmcs otherwise
4499 > gmcs cannot compile some files.
4501 2005-08-20 Martin Baulig <martin@ximian.com>
4503 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4504 scope if we don't already have it.
4506 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4507 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4510 2005-07-31 Miguel de Icaza <miguel@novell.com>
4512 * statement.cs: Copy the local exception into the exception
4513 captured local. Fixes 75674
4515 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4517 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4520 2005-08-12 Martin Baulig <martin@ximian.com>
4522 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4523 for nested types here to avoid hitting the cache too early.
4525 2005-08-09 Miguel de Icaza <miguel@novell.com>
4527 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4530 2005-08-03 Martin Baulig <martin@ximian.com>
4532 Make iterators in generic methods work; see gtest-191.cs.
4535 (Constraints.Resolve): Protect against being called twice.
4538 (TypeContainer.GetClassBases): Make this `protected virtual'.
4540 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4541 (Iterator.GetClassBases): Override this and compute the base
4543 (Iterator.DefineNestedTypes): If we're a generic method, all our
4544 method type parameters become class type parameters on the proxy
4548 (ToplevelBlock.Parameters): Make this a property, not a field.
4549 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4551 2005-08-03 Martin Baulig <martin@ximian.com>
4553 * typemanager.cs (TypeManager.IsSubclassOf): Use
4554 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4555 (TypeManager.GetFullName_recursed): Improved.
4557 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4560 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4561 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4562 invocation_type == mi.DeclaringType, since the first one also checks
4563 other condition used by generic instances.
4565 2005-07-27 Martin Baulig <martin@ximian.com>
4567 * anonymous.cs (CaptureContext.AddField): Added
4568 `AnonymousContainer am' argument; compute its toplevel scope if
4569 it's not already computed. Fixes #75649.
4571 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4573 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4574 CheckAttributeType and refactored.
4575 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4576 ResolveAsTypeTerminal error handling.
4577 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4579 (GetSignatureForError): Print errors in same way.
4582 * codegen.cs: Reflect attribute GetSignatureForError change.
4585 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4587 * namespace.cs (UsingEntry): Refactored to make fields private.
4590 statement.cs: Error_UnexpectedKind has extra parameter.
4592 2005-07-14 Raja R Harinath <rharinath@novell.com>
4594 * ecore.cs (IAlias): Remove.
4595 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4596 that implement the interface.
4597 * namespace.cs (Namespace): Likewise.
4598 (Namespace.declspaces): Renamed from 'defined_names'.
4599 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4600 DeclSpace instead of an IAlias.
4601 * tree.cs (Tree.AddDecl): Update.
4603 2005-07-12 Raja R Harinath <rharinath@novell.com>
4605 * statement.cs (Block.Flags); Remove HasVarargs.
4606 (Block.HasVarargs): Move to ToplevelBlock.
4607 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4608 (Block.Variables): Make protected. Initialize variable hashtable
4610 (Block.AddVariable): Update.
4611 (Block.Resolve): Update to changes.
4612 (ToplevelBlock.HasVarargs): New boolean.
4613 (ToplevelBlock.ThisVariable): Move here from Block.
4614 (ToplevelBlock.AddThisVariable): Likewise.
4615 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4616 * expression.cs (This.ResolveBase): Update to changes.
4617 (ArglistAccess.DoResolve): Likewise.
4619 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4622 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4624 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4625 not used and not used & assigned.
4626 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4628 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4631 * expression.cs (Is.DoResolve): null is never provided type.
4633 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4636 * cs-parser.jay: Less strict event error rule to catch more errors.
4638 2005-07-11 Martin Baulig <martin@ximian.com>
4640 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4641 for the constructor constraint: we do not only have to check
4642 whether the class has a public constructor, but also ensure that
4643 it's parameterless. Fixes #75492.
4645 2005-07-11 Martin Baulig <martin@ximian.com>
4647 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4648 between type parameters if they either have the reference type
4649 constraint or the class constraint.
4651 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4653 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4655 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4658 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4659 (ExtractSecurityPermissionSet): Cope with self referencing security
4660 attributes properly.
4662 * driver.cs (SetOutputFile): Made public property OutputFile.
4664 2005-07-07 Raja R Harinath <rharinath@novell.com>
4667 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4668 has_nonstatic_fields. Make into a FieldBase pointer.
4669 (TypeContainer.AddField): Add CS0282 check.
4670 (TypeContainer.EmitType): Update.
4672 2005-07-06 Miguel de Icaza <miguel@novell.com>
4674 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4675 compare if they start with __.
4677 2005-07-06 Raja R Harinath <rharinath@novell.com>
4679 * statement.cs (Switch.SwitchGoverningType): Only look at
4680 UserCasts that don't need implicit standard conversions to one of
4681 the allowed switch types (Fixes test-322.cs).
4682 (LocalInfo.Resolve): Re-enable sanity-test.
4684 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4686 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4688 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4690 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4692 2005-07-06 Raja R Harinath <rharinath@novell.com>
4695 * ecore.cs (SimpleName.GetSignatureForError): Add.
4696 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4697 (MemberAccess.GetSignatureForError): Add.
4699 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4701 The big error and warning messages review.
4731 * typemanager.cs: Updated.
4733 * class.cs: (MethodCore.SetYields): Moved here to share.
4734 (PropertyMethod.Define): Moved iterator setup here.
4736 * iterators.cs: Add orig_method to have full access to parent
4739 2005-07-05 Raja R Harinath <rharinath@novell.com>
4741 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4742 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4743 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4744 variable of struct type.
4745 * expression.cs (Unary.ResolveOperator): Update to change.
4746 (Indirection.VerifyFixed): Likewise.
4747 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4748 (ParameterReference.VerifyFixed): Value parameters are fixed.
4749 (This.VerifyFixed): Treat 'this' as a value parameter.
4750 * statement.cs (LocalInfo.IsFixed): Remove.
4752 2005-07-01 Martin Baulig <martin@ximian.com>
4754 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4755 `ec.EmitThis ()' to get the correct scope.
4757 2005-07-01 Martin Baulig <martin@ximian.com>
4759 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4760 instance is a ParameterReference; fixes #75299.
4762 2005-06-30 Raja R Harinath <rharinath@novell.com>
4765 * expression.cs (Indexers.map): Remove.
4766 (Indexers.Append): Filter out inaccessible setters and getters.
4767 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4770 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4772 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4773 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4774 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4775 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4777 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4780 * class.cs (FieldBase.GetInitializerExpression): One more field
4783 2005-06-28 Miguel de Icaza <miguel@novell.com>
4785 * pending.cs: Do not define a proxy if the base method is virtual,
4786 it will be picked up by the runtime (bug 75270).
4788 2005-07-08 Martin Baulig <martin@ximian.com>
4790 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4791 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4793 2005-07-07 Martin Baulig <martin@ximian.com>
4795 * generic.cs (ConstructedType.CheckConstraint): Use
4796 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4797 called recursively; fixes #75329.
4799 2005-07-06 Martin Baulig <martin@ximian.com>
4801 * generic.cs (TypeManager.InferTypeArguments): Added support for
4802 anonymous methods; fixes #75461.
4804 2005-07-01 Martin Baulig <martin@ximian.com>
4806 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4807 `ec.EmitThis ()' to get the correct scope.
4809 2005-07-01 Martin Baulig <martin@ximian.com>
4811 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4812 instance is `This'; fixes #75299.
4814 2005-06-30 Martin Baulig <martin@ximian.com>
4816 * class.cs (Indexer): Implement IIteratorContainer; added support
4817 for iterators in indexers.
4820 (EmitContext.CurrentIterator): Make this a property, not a field.
4822 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4824 2005-06-28 Miguel de Icaza <miguel@novell.com>
4826 * pending.cs: Do not define a proxy if the base method is virtual,
4827 it will be picked up by the runtime (bug 75270).
4829 2005-06-28 Martin Baulig <martin@ximian.com>
4831 * cs-parser.jay (interface_method_declaration): Avoid a
4832 reduce/reduce conflict by moving some of the code into a separate
4833 `interface_method_declaration_body' rule; fixes #75368.
4835 2005-06-28 Martin Baulig <martin@ximian.com>
4837 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4838 array check after the check for TypeBuilder's.
4840 2005-06-21 Raja R Harinath <rharinath@novell.com>
4842 * convert.cs (FindMostEncompassedType): Add two trivial special
4843 cases (number_of_types == 0 || number_of_types == 1).
4844 (FindMostEncompasingType): Likewise.
4846 2005-06-17 Raja R Harinath <rharinath@novell.com>
4848 Some cleanups preparing for the fix of #75283.
4849 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4851 (EventExpr.InstanceResolve): Likewise.
4852 (EventExpr.DoResolve): Remove redundant checks.
4854 2005-06-08 Miguel de Icaza <miguel@novell.com>
4856 * class.cs: Small fix.
4858 2005-06-08 Raja R Harinath <rharinath@novell.com>
4861 * class.cs (GetPartialBases): Fix return value check of
4864 2005-06-07 Raja R Harinath <rharinath@novell.com>
4866 Ensure that partial classes are registered in their enclosing
4867 namespace. Initial part of fix of #75160.
4868 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4869 Register declspace with namespace here, not in
4870 DeclSpace.RecordDecl.
4871 * cs-parser.jay: Pass namespace to RecordDecl.
4872 * class.cs (PartialContainer.Create): Likewise.
4873 (ClassPart.DefineType): New sanity-check. Throws an exception if
4875 * decl.cs (Declspace.RecordDecl): Remove.
4876 * namespace.cs (NamespaceEntry.DefineName): Remove.
4878 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4880 * rootcontext.cs: Reset TargetExt as well.
4882 2005-06-03 Raja R Harinath <rharinath@novell.com>
4884 * ecore.cs (Expression.Resolve): Emit CS0654 error when
4887 2005-06-02 Raja R Harinath <rharinath@novell.com>
4889 Fix #75080, cs0119.cs.
4890 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
4892 (Expression.Resolve): ... this. Use it. Remove bogus code
4893 allowing ExprClass.Type and ExprClass.Namespace for
4894 ResolveFlags.VariableOrValue.
4895 (Expression.Resolve) [1-argument variant]: Change default resolve
4896 flags based on language version.
4897 (Expression.Error_UnexpectedKind): Use a simple string array
4898 rather than an ArrayList.
4899 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
4901 (TypeOfVoid.DoResolve): Likewise.
4902 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
4903 flags argument -- it always has the same value.
4905 2005-05-31 Raja R Harinath <rharinath@novell.com>
4908 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
4909 Use it in the error message.
4910 * assign.cs, expression.cs, statement.cs: Update.
4912 2005-05-30 Raja R Harinath <rharinath@novell.com>
4915 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
4916 the "almostMatchedMember" case too.
4917 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
4918 that failed the accessibility checks to 'almost_match'.
4920 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
4922 * attribute.cs: Use internal MethodBuilder methods to set
4923 ExactSpelling and SetLastError on PInvoke methods, instead
4924 of passing them via charset. Fixes #75060.
4926 2005-05-27 Raja R Harinath <rharinath@novell.com>
4928 * parameter.cs (Parameter): Remove TODO comment.
4929 (Parameter.DefineParameter): Remove Location parameter.
4930 (Parameters.LabelParameters): Likewise.
4931 * class.cs (Constructor.Emit): Update to change.
4932 (MethodData.Emit): Likewise.
4933 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
4934 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
4936 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
4939 Removed Parameters.Location and added Parameter.Location instead.
4940 Removed Location parameter from Emit() and GetSignature().
4947 Modified all related calls.
4949 2005-06-21 Martin Baulig <martin@ximian.com>
4951 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
4952 left-hand side is not a nullable type; fixes #75328.
4954 2005-06-21 Martin Baulig <martin@ximian.com>
4957 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
4958 (TypeManager.GetFullNameSignature): Likewise.
4960 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
4961 `source.FullName' and `target.FullName' to check whether there are
4962 two conflicting definitions.
4964 2005-06-21 Martin Baulig <martin@ximian.com>
4966 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
4967 a BoxedCast - also for reference types - to be compatible with csc.
4969 2005-06-21 Martin Baulig <martin@ximian.com>
4971 * expression.cs (MemberAccess.DoResolve): Add support for nested
4972 types in a generic instance; fixes #75320.
4974 2005-06-20 Martin Baulig <martin@ximian.com>
4976 * generic.cs (TypeManager.InferType): Also walk the class
4977 hierarchy for generic instances; fixes #75261.
4979 2005-06-17 Martin Baulig <martin@ximian.com>
4981 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
4982 to make things work for corlib.
4984 2005-06-15 Martin Baulig <martin@ximian.com>
4986 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
4987 obsolete `SecurityAction' values.
4989 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4991 * rootcontext.cs: Reset TargetExt as well.
4993 2005-06-09 Martin Baulig <martin@ximian.com>
4995 * delegate.cs (Delegate.VerifyMethod): Added
4996 `MethodGroupExpr old_mg' argument; inherit its
4997 `HasTypeParameters'; fix #75085.
4999 2005-06-09 Martin Baulig <martin@ximian.com>
5001 * expression.cs (Invocation.OverloadResolve): Correctly handle
5002 generic methods for the SetMemberIsUsed(); fix #75064.
5004 2005-06-09 Martin Baulig <martin@ximian.com>
5006 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
5009 2005-06-08 Martin Baulig <martin@ximian.com>
5011 * cs-parser.jay (nullable_type_or_conditional): If we put the
5012 nullable back and our `type' is a `ComposedCast', remove the
5013 nullable from it. Fixes #75156.
5015 * expression.cs (ComposedCast.RemoveNullable): New public method.
5017 2005-06-08 Martin Baulig <martin@ximian.com>
5019 The big Iterators rewrite :-)
5021 * iterators.cs: Rewrite this to use the anonymous methods framework.
5023 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
5024 before the TypeContainers; see 2test-21.cs.
5027 (TypeContainer.DefineType): Don't create a new EmitContext if we
5028 already have one (this only happens if we're an Iterator).
5029 (TypeContainer.Define): Also call Define() on all our iterators.
5030 (Method.CreateEmitContext): Added support for iterators.
5033 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
5034 (AnonymousContainer.CreateMethodHost): Moved here from
5035 AnonymousMethod and made abstract.
5036 (AnonymousContainer.CreateScopeType): New abstract method.
5037 (AnonymousContainer.IsIterator): New public property.
5038 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
5039 get the ScopeTypeBuilder rather than manually defining it here.
5040 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
5043 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
5044 before RootContext.DefineTypes().
5046 * codegen.cs (EmitContext.RemapToProxy): Removed.
5047 (EmitContext.CurrentAnonymousMethod): Changed type from
5048 AnonymousMethod -> AnonymousContainer.
5049 (EmitContext.ResolveTopBlock): Protect from being called twice.
5050 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
5051 (EmitContext.EmitThis): Removed the iterators hacks; use the
5052 anonymous methods framework for that.
5055 (ToplevelBlock.Container): Make this a property, not a field.
5056 (ToplevelBlock.ReParent): New public method; move the
5057 ToplevelBlock into a new container.
5058 (Foreach.TemporaryVariable): Simplify.
5060 2005-06-05 Martin Baulig <martin@ximian.com>
5062 * statement.cs (LocalInfo.CompilerGenerated): New flag.
5063 (Block.AddTemporaryVariable): New public method; creates a new
5064 `LocalInfo' for a temporary variable.
5065 (Block.EmitMeta): Create the LocalBuilders for all the temporary
5067 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
5068 non-iterator variables.
5070 2005-06-05 Martin Baulig <martin@ximian.com>
5072 * statement.cs (Foreach.TemporaryVariable): Create the
5073 LocalBuilder in the Emit phase and not in Resolve since in some
5074 situations, we don't have an ILGenerator during Resolve; see
5075 2test-19.cs for an example.
5077 2005-06-04 Martin Baulig <martin@ximian.com>
5079 The big Foreach rewrite - Part II.
5081 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
5082 with `PropertyInfo ienumerator_getcurrent'.
5084 * codegen.cs (VariableStorage): Removed.
5087 (Foreach): Derive from Statement, not ExceptionStatement.
5088 (Foreach.CollectionForeach): New nested class. Moved all the code
5089 dealing with collection foreach here.
5090 (Foreach.ForeachHelperMethods): Removed.
5091 (Foreach.TemporaryVariable): Implement IMemoryLocation.
5093 2005-05-23 Martin Baulig <martin@ximian.com>
5095 * statement.cs (Try.DoResolve): Don't create a `finally' if we
5096 don't need to. Fix #75014.
5098 2005-05-26 Raja R Harinath <rharinath@novell.com>
5100 Improve user-defined conversion handling.
5101 * convert.cs (GetConversionOperators): Rewrite. Return only the
5102 applicable operators.
5103 (AddConversionOperators): New. Helper for GetConversionOperators.
5104 (FindMostEncompassedType, FindMostEncompassingType): Verify that
5105 there is only one most encompassed/encompassing type.
5106 (FindMostSpecificSource, FindMostSpecificTarget): Remove
5107 "applicable operator" handling.
5108 (UserConversion): Move cache here from GetConversionOperators.
5109 Directly cache the chosen operator, rather than the whole
5111 (ExplicitNumericConversion): Fix buggy implementation of Decimal
5112 case. Allow conversion of decimal to sbyte and byte too.
5113 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5114 New static methods. Used to avoid allocating EmptyExpressions in
5117 2005-05-24 Duncan Mak <duncan@novell.com>
5119 * ecore.cs (CastFromDecimal): New class for casting a decimal to
5120 another class, used in Convert.ExplicitNumericConversion.
5121 (CastToDecimal): New class, similar to above, but casts to
5122 System.Decimal, used in Convert.ImplicitNumericConversion and also
5123 in explicit convesion from double/float to decimal.
5125 * convert.cs (ImplicitNumericConversion): Handle implicit
5126 conversions to System.Decimal.
5127 (ExplicitNumericConversion): handle explicit conversions to
5132 2005-05-20 Miguel de Icaza <miguel@novell.com>
5134 * typemanager.cs: Do not throw an exception in the TypeBuilder
5135 case, we take care of it on the TypeCode.
5137 2005-05-17 Marek Safar <marek.safar@seznam.cz>
5139 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
5142 * cs-parser.jay: Catch more lexical errors.
5144 * report.cs: Add one more Error method.
5147 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
5149 2005-05-20 Martin Baulig <martin@ximian.com>
5151 * class.cs (TypeContainer.CircularDepException): Removed.
5152 (TypeContainer.DefineType): Removed the `InTransit' stuff.
5153 (TypeContainer.CheckRecursiveDefinition): Check for circular class
5154 (CS0146) and interface (CS0529) dependencies here.
5156 2005-05-20 Martin Baulig <martin@ximian.com>
5158 * expression.cs (New.DoResolve): Move the CS0712 check above the
5159 CS0144 check; otherwise it can never be reached.
5161 2005-05-20 Martin Baulig <martin@ximian.com>
5163 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
5165 2005-05-20 Martin Baulig <martin@ximian.com>
5167 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
5169 * typemanager.cs (TypeManager.IsAttributeType): New public method.
5171 2005-05-19 Martin Baulig <martin@ximian.com>
5174 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
5175 to disable error reporting.
5177 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
5178 here since we don't want to report an error; see the new test-336.cs.
5180 2005-05-19 Raja R Harinath <rharinath@novell.com>
5182 * statement.cs (ToplevelBlock.GetParameterReference)
5183 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
5184 Move here from class Block.
5185 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
5186 * expression.cs (ParameterReference.DoResolveBase): Likewise.
5188 2005-05-18 Martin Baulig <martin@ximian.com>
5193 (FlowBranching.Reachability): Add non-static public And() and Or()
5195 (FlowBranchingSwitch): New class; do the `break_origins' thing
5196 like in FlowBranchingLoop.
5197 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
5198 reachability, not just locals and parameters.
5199 (FlowBranching.MergeChild): Remove some of the hacks for loop and
5200 switch; MergeBreakOrigins() now takes care of that.
5202 2005-05-18 Martin Baulig <martin@ximian.com>
5204 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
5205 a loop and may leave it, reset the barrier; fixes #74974.
5207 2005-05-16 Raja R Harinath <rharinath@novell.com>
5209 Fix test-382.cs. Emit values of decimal constants.
5210 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
5212 (TypeContainer.AddField): ... this.
5213 (TypeContainer.EmitFieldInitializers): Allow the list of fields
5214 with initializers to include 'Const's.
5215 (ClassPart.RegisterFieldForInitialization): Forward to
5217 * const.cs (Const.Const): Pass initializer to base class.
5218 (Const.Define): In case of decimal constants, register them for
5219 initialization in a static constructor.
5221 2005-05-14 Martin Baulig <martin@ximian.com>
5223 * statement.cs (Block.Resolve): Correctly handle unreachable code;
5224 do not call ResolveUnreachable() on unreachable statements in
5225 here, see the comment in the source code.
5227 2005-05-13 Raja R Harinath <rharinath@novell.com>
5230 * expression.cs (BinaryResolveOperator): If one of the operands of
5231 an equality comparison is 'null' and the other is a pointer type,
5232 convert the null to a NullPointer.
5233 * convert.cs (ImplicitReferenceConversion): If the expression is a
5234 NullLiteral and the target type is a pointer type, return a
5235 NullPointer instead.
5236 (ImplicitConversionStandard): Likewise.
5238 2005-05-13 Marek Safar <marek.safar@seznam.cz>
5240 * cs-parser.jay: Set readonly context based on special constructs.
5242 * expression.cs (LocalVariableReference.DoResolveBase): Improved
5243 readonly variable error handling.
5245 * rootcontext.cs (EmitCode): Don't verify members when error
5248 * statement.cs (LocalInfo): Add reaodnly context information.
5249 (SetReadOnlyContext, GetReadOnlyContext): New methods.
5251 2005-05-17 Martin Baulig <martin@ximian.com>
5253 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
5256 2005-05-13 Martin Baulig <martin@ximian.com>
5258 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
5259 handle unreachable blocks.
5261 2005-05-13 Martin Baulig <martin@ximian.com>
5264 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
5265 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
5268 2005-05-13 Martin Baulig <martin@ximian.com>
5270 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5271 instance variable, not a local. Fix #74873.
5272 (Block.ResolveUnreachable): Set it to true here.
5274 2005-05-12 Martin Baulig <martin@ximian.com>
5276 * cs-parser.jay (property_declaration): Pass the `current_class',
5277 not the `current_container' to Property's .ctor. Fixes #74912.
5279 2005-05-11 Martin Baulig <martin@ximian.com>
5281 * typemanager.cs (Closure): Copy this from MCS and merge all the
5282 GMCS-specific changes into it.
5284 2005-05-12 Raja R Harinath <harinath@gmail.com>
5287 * typemanager.cs (unmanaged_enclosing_types): New.
5288 (IsUnmanagedType): Avoid infloops by using
5289 'unmanaged_enclosing_types' to talk with recursive invocations.
5291 2005-05-11 Duncan Mak <duncan@novell.com>
5293 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5294 continuing to process for 'arg'.
5295 (handle_preprocessing_directive): Check the argument of the #endif
5296 directive and report error CS1025 if there are any trailing
5299 According to the C# spec, having even whitespace after the #endif
5300 directive is illegal; however, because we call arg.TrimEnd ()
5301 beforehand, we have the same behavior as csc, allowing whitespace
5302 after the directive.
5306 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5310 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5311 (Constructor.GetObsoleteAttribute): Implemented correctly.
5313 2005-05-10 Martin Baulig <martin@ximian.com>
5315 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5316 resolve the type; fixes #74864.
5317 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5318 in DoResolve(); fixes #74862.
5320 2005-05-10 Martin Baulig <martin@ximian.com>
5322 * support.cs (ReflectionParameters.ParameterModifier): Use
5323 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5324 and `ParameterAttributes.In'. Fixes #74884.
5326 2005-05-10 Martin Baulig <martin@ximian.com>
5328 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5329 the cache if we're just looking for `MemberTypes.NestedType' in a
5332 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5333 constraints if we're still resolving the type tree.
5334 (Expression.MemberLookup): If we're resolving the type tree, only
5335 look for `MemberTypes.NestedType' since we're only interested in
5338 * class.cs (TypeContainer.DefineType): Don't resolve the type
5339 parameters here; do this later in ResolveType() after the type
5340 tree has been resolved.
5341 (TypeContainer.ResolveType): New public method; this is called
5342 after the type tree is resolved and before the types are being
5343 populated. We resolve the generic constraints here.
5344 (TypeContainer.DoDefineMember): Check the constraints on our base
5345 class and interfaces.
5347 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5348 set the `ResolvingTypeTree' flag on the EmitContext.
5350 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5352 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5354 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5356 * expression.cs (Argument.GetParameterModifier): Turned to property.
5357 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5359 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5362 2005-05-09 Raja R Harinath <rharinath@novell.com>
5365 * decl.cs (MemberCache.AddMethods): Register override methods,
5366 rather than non-override methods.
5367 * typemanager.cs (RegisterOverride): New.
5368 (IsOverride): Update.
5370 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5372 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5374 2005-05-06 Martin Baulig <martin@ximian.com>
5377 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5378 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5380 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5384 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5385 recursive declaration.
5387 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5389 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5391 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5393 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5395 2005-05-05 Raja R Harinath <rharinath@novell.com>
5398 * decl.cs (DeclSpace.FamilyAccessible):
5399 Use TypeManager.IsNestedFamilyAccessible.
5401 Fix reopened #64812.
5402 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5405 2005-05-04 Raja R Harinath <rharinath@novell.com>
5406 Abin Thomas <projectmonokochi@rediffmail.com>
5407 Anoob V E <projectmonokochi@rediffmail.com>
5408 Harilal P R <projectmonokochi@rediffmail.com>
5411 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5412 allow access to all static members.
5414 2005-05-04 Martin Baulig <martin@ximian.com>
5416 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5418 2005-05-04 Martin Baulig <martin@ximian.com>
5422 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5423 section at the end; make things work if `default' is not the last
5426 2005-05-04 Martin Baulig <martin@ximian.com>
5430 * statement.cs (Switch): Replaced the `got_default' field with a
5431 `default_section' one.
5432 (Switch.CheckSwitch): Set `default_section' here.
5433 (Switch.Resolve): If we're a constant switch and the constant is
5434 not found, use the default section.
5436 2005-05-03 Martin Baulig <martin@ximian.com>
5438 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5440 * statement.cs (Foreach.ArrayForeach): New nested class.
5441 (Foreach.TemporaryVariable): New nested class.
5442 (Foreach.EmitArrayForeach): Removed; this is now in the new
5445 2005-05-03 Raja R Harinath <rharinath@novell.com>
5447 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5449 (VerifyPendingMethods): Revert change below.
5451 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5452 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5453 that used to trigger warning -28. Remove warning -28.
5454 * expression.cs (Invocation.OverloadResolve): Use
5455 TypeManager.IsOverride to distinguish override methods.
5458 * pending.cs (VerifyPendingMethods): If a base type implements the
5459 requested interface, don't bother checking individual methods of
5460 the base type. As a side-effect, this prevents the creation of
5461 unnecessary proxies.
5463 2005-05-02 Martin Baulig <martin@ximian.com>
5467 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5468 Also `And' the locals if the old vector is null.
5469 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5470 null; in this case we basically reset all the variables.
5472 2005-05-02 Martin Baulig <martin@ximian.com>
5476 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5477 Added `FlowBranching branching' argument; always `and' the
5478 variables instead of `or'ing them unless we're an infinite loop.
5480 * statement.cs (While.Resolve): Create a new sibling unless we're
5483 2005-05-02 Martin Baulig <martin@ximian.com>
5487 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5488 arguments; use it instead of creating a new TopLevelBlock.
5489 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5490 our ConstructorInitializer.
5493 (TopLevelBlock.TopLevelBranching): New public property.
5494 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5495 and create our `TopLevelBranching'.
5497 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5498 anonymous method host, use `block.TopLevelBranching' rather than
5499 creating a new branching.
5501 2005-04-20 Miguel de Icaza <miguel@novell.com>
5503 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5504 a ScopeInfo, if any of the current children is a child of the new
5505 entry, move those children there.
5507 2005-04-30 Martin Baulig <martin@ximian.com>
5509 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5510 at the beginning of a SwitchSection. Fix #73335.
5512 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5515 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5517 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5518 (FieldExpr.DoResolve): Obsolete members are ignored for field
5521 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5523 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5524 of arrays detection.
5526 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5528 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5530 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5533 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5535 * cs-parser.jay: Use the prefered version of -unsafe in error
5538 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5540 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5543 2005-04-20 John Luke <john.luke@gmail.com>
5545 * driver.cs: fix typo in error message, --outout to --output
5547 2005-04-30 Martin Baulig <martin@ximian.com>
5549 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5550 handle the .NET 2.x security attributes.
5552 2005-04-30 Martin Baulig <martin@ximian.com>
5555 (TypeManager.ExpandInterfaces): Don't add things twice.
5558 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5560 2005-04-29 Martin Baulig <martin@ximian.com>
5562 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5564 * anonymous.cs: Added support for anonymous generic methods.
5566 2005-04-29 Martin Baulig <martin@ximian.com>
5568 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5571 2005-04-29 Martin Baulig <martin@ximian.com>
5573 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5575 * expression.cs (New.DoResolve): Fix the CS0304 check.
5577 2005-04-29 Martin Baulig <martin@ximian.com>
5579 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5582 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5583 explicit interface implementation, compare the interface types.
5584 (MethodData.Define): Use the new naming scheme from the latest
5586 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5588 * decl.cs (MemberName.GetMemberName): Removed.
5589 (MemberName.MethodName, FullName): New properties.
5591 2005-04-25 Raja R Harinath <rharinath@novell.com>
5593 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5595 2005-04-22 Martin Baulig <martin@ximian.com>
5597 * generic.cs (GenericMethod): Create the EmitContext in the
5598 `Define()'; in `Define(MethodBuilder)', create the type parameters
5599 before calling `Define()'. Fixes #73933.
5601 2005-04-22 Martin Baulig <martin@ximian.com>
5604 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5605 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5607 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5608 ConstructedType, check its constraints.
5610 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5612 * codegen.cs (InRefOutArgumentResolving): New field.
5614 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5615 fields outside contructor.
5617 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5619 2005-04-19 Miguel de Icaza <miguel@novell.com>
5621 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5622 parameter code was not completed ever, so it was not as up-to-date
5623 as local variables. Must finish it.
5625 The bug fix was to compare the Toplevel of the block, not the
5626 current block. Thanks for Ben for pointing this out.
5628 2005-04-19 Raja R Harinath <rharinath@novell.com>
5630 * decl.cs (AddMethods): Use the declaring type of the problem
5631 method to determine if we want to squash a warning.
5633 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5635 * attribute.cs: Removed debug output.
5637 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5639 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5642 2005-04-18 Raja R Harinath <rharinath@novell.com>
5645 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5646 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5647 all null comparisons against reference types.
5649 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5652 * class.cs (TypeContainer.CircularDepException) New nested
5654 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5655 (TypeContainer.DefineType): Removed error, reset InTransit before
5657 (Class.DefineType): Throw exception when is in Transit.
5658 Catch exception and report error.
5659 (Struct.DefineType): Throw exception when is in Transit.
5660 Catch exception and report error.
5661 (Interface.DefineType): Throw exception when is in Transit.
5662 Catch exception and report error.
5664 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5665 handle nested exception handlers.
5667 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5670 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5671 InFinally and InCatch storage.
5673 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5674 (Catch.Resolve): Set and Restore ec.InCatch.
5675 (Try.Resolve): Set and Restore ec.InFinally.
5676 (Try.HasCatch): True when try has catch.
5678 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5680 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5681 for the same event member, so exclude such cases from warning 419.
5684 2005-04-16 Miguel de Icaza <miguel@novell.com>
5686 * expression.cs (Binary.ResolveOperator): Apply patch from John
5687 Luke to fix bug 59864: operators &, | and ^ on enumerations
5688 require that the same enum type on both sides.
5690 * driver.cs: Add warnings to old flag usage, this is to assist
5691 people who produce Makefiles and hope that the Makefiles will be
5694 * class.cs (TypeContainer.EmitType): Moved the definition of the
5695 special $PRIVATE$ field from the resolve phase to the Emit phase.
5696 During resolve we do not know if we are a struct with
5697 HasExplicitLayout, we know this only after the attributes for the
5700 Set the FieldOffset to zero on the dummy field that we create for
5701 the class. Fixes 74590.
5703 2005-04-16 Raja R Harinath <rharinath@novell.com>
5706 * ecore.cs (PropertyExpr.resolved): New.
5707 (DoResolve): Use it to handle a case of double resolution here.
5708 Handle a case of identical-name-and-type-name.
5709 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5710 resolution by storing the results of expression resolution back
5711 into the "probes" array.
5713 2005-04-15 Raja R Harinath <rharinath@novell.com>
5715 Fix cs0208-7.cs and cs0208-8.cs.
5716 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5717 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5718 error reporting to point out the reason a struct is not unmanaged.
5720 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5722 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5723 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5725 2005-04-13 Raja R Harinath <rharinath@novell.com>
5728 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5729 IdenticalNameAndTypeName here.
5730 (EventExpr.InstanceResolve): Likewise.
5732 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5734 C# 2.0 DefaultCharSetAttribute implementation
5736 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5737 which allows us to set GlobalNamespace for every resolve.
5738 (Attribute.ResolveArguments): Cut from Resolve.
5739 (Attribute.GetCharSetValue): Returns CharSet named argument.
5740 (Attribute.DefinePInvokeMethod): Gets default charset from
5742 (GlobalAttribute.ResolveAsTypeStep): Override.
5743 (GlobalAttribute.ResolveArguments): Override.
5745 * class.cs (TypeAttr): Is protected.
5747 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5748 (ModuleClass.DefaultCharSetType): New memeber.
5749 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5751 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5752 charset from module.
5754 * delegate.cs (TypeAttr): Override.
5755 (Delegate.DefineType): Use this TypeAttr.
5757 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5758 at very early stage (before types are defined) to resolve model
5759 module attributes. It will probably not work with corlib but it
5762 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5763 charset from module.
5765 * typemanager.cs (default_charset_type): New type.
5767 2005-04-13 Raja R Harinath <rharinath@novell.com>
5769 * decl.cs (MemberCache.AddMethods): Don't warn if
5770 System.Object.Finalize has buggy MethodAttributes.
5772 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5775 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5777 * doc.cs : detect ambiguous reference to overloaded members.
5778 Fixed bug #71603. MS 1.1 csc does not detect it.
5780 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5782 * doc.cs : delegates must not be referenced with parameters.
5785 2005-04-12 Miguel de Icaza <miguel@novell.com>
5787 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5789 2005-04-10 Miguel de Icaza <miguel@novell.com>
5791 * driver.cs (MainDriver): Stop processing if the CLS stage found
5794 (CompilerCallableEntryPoint.InvokeCompiler): Always
5795 reset after execution; Take a TextWriter argument for the
5798 * report.cs: Use the error stream instead of hardcoding stderr.
5800 2005-04-09 Miguel de Icaza <miguel@novell.com>
5802 * class.cs: Reduce code paths to test, too small of an
5803 optimization to make it worth the extra testing. Always perform
5806 2005-04-08 Raja R Harinath <rharinath@novell.com>
5809 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5810 operators that had errors reported on them.
5812 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5814 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5816 (Attribute.Resolve): Add named argument type checking.
5818 * class.cs (FixedField.Define): Use IsPrimitiveType
5820 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5822 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5823 unsafe parameter types.
5825 * statement.cs (Using.ResolveExpression): Add better error description.
5827 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5829 2005-04-08 Raja R Harinath <rharinath@novell.com>
5832 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5833 AttributeUsageAttribute in the emitcontext of the attribute class,
5834 not in the emitcontext of the attributable entity it was attached to.
5835 * cs-parser.jay: Use 'current_class', not 'current_container',
5836 when creating a GlobalAttribute.
5838 2005-04-08 Alp Toker <alp@atoker.com>
5840 * pending.cs: The fix to #58413 failed to compile methods implementing
5841 interfaces with/without params modifiers and vice versa, even though
5842 params modifiers aren't part of the signature. Make the modifier check
5843 less strict as in csc.
5845 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5846 Anoob V E <projectmonokochi@rediffmail.com>
5847 Harilal P R <projectmonokochi@rediffmail.com>
5850 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5851 modifiers of pending methods.
5852 (PendingImplementation.PendingImplementation): Initialize it.
5853 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5854 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5855 with ParameterData. Add check for modifiers.
5856 * class.cs (MethodData.Define): Update to changes.
5858 2005-04-07 Raja R Harinath <rharinath@novell.com>
5860 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5862 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5864 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5867 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5870 * typemanager.cs: Registered RequiredAttributeAttribute.
5872 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5874 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5875 Warning CS0169 is back at level 3.
5876 (IMethodData.SetMemberIsUsed): New method.
5878 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5879 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
5881 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
5883 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
5885 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
5888 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
5891 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
5892 to avoid the problems with nested types.
5894 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
5895 Anoob V.E <projectmonokochi@rediffmail.com>
5896 Harilal P.R <projectmonokochi@rediffmail.com>
5897 Raja R Harinath <rharinath@novell.com>
5900 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
5902 * typemanager (GetConstructor): Make public.
5904 2005-04-05 John Luke <john.luke@gmail.com>
5905 Raja R Harinath <rharinath@novell.com>
5908 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
5909 struct too. Return false quicker in a few cases.
5910 (VerifyUnManaged): Use it.
5912 2005-04-05 Raja R Harinath <rharinath@novell.com>
5915 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
5916 not 'unreachable_seen'.
5918 2005-04-04 Marek Safar <marek.safar@seznam.cz>
5920 * attribute.cs (Attribute.GetValue): Removed unused.
5922 * codegen.cs (CodeGen.TrimExt): Removed unused.
5924 * cs-parser.jay (output): Removed unused.
5926 * cs-tokenizer.cs (hex_digits): Removed unused.
5928 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
5930 * expression.cs (Indirection.LoadExprValue): Removed unused.
5931 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
5933 * iterators.cs (Iterator.param_types): Removed unused.
5935 * statement.cs (Goto.block): Removed unused.
5936 (ToplevelBlock.did): Removed unused.
5937 (Switch.ResolveConstantSwitch): Removed unused.
5939 2005-04-01 Ben Maurer <bmaurer@ximian.com>
5941 * rootcontext.cs: Allow mcs to bootstrap with the compilation
5944 2005-04-19 Martin Baulig <martin@ximian.com>
5946 Merged r42462 from MCS and made it work for GMCS.
5948 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
5950 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
5952 2005-04-01 Raja R Harinath <rharinath@novell.com>
5954 Fix #74232 and cs0208-3.cs.
5955 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
5956 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
5957 unmanaged type. Don't use FieldBuilders when 't' is a
5958 TypeBuilder. Use ModFlags and MemberType fields.
5959 * class.cs (MemberBase.member_type): Rename from MemberType.
5960 (MemberBase.MemberType): New property. Determines member_type on
5962 (MemberBase.DoDefine): Don't initialize MemberType here.
5963 (FieldMember.Define): Likewise.
5965 2005-04-01 Marek Safar <marek.safar@seznam.cz>
5968 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
5969 Attributes are emitted there.
5971 2005-04-01 Raja R Harinath <rharinath@novell.com>
5973 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
5974 keyword in 'partial enum' too.
5975 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
5977 Report from Kamil Skalski <nazgul@omega.pl>.
5980 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
5981 have partial containers too.
5983 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
5984 in block' checks to Block.CheckInvariantMeaningInBlock.
5985 * statement.cs (Block.GetKnownVariableInfo): Make private.
5986 (Block.IsVariableUsedInChildBlock): Remove.
5987 (Block.IsVariableUsedInBlock): Likewise.
5988 (Block.CheckInvariantMeaningInBlock): New. Show location of
5989 conflicting declaration.
5990 (Block.AddVariable): Make error messages less long-winded and more
5991 specific. Show location of conflicting declaration.
5992 * parameter.cs (Parameters.Location): New readonly property.
5994 2005-03-31 Raja R Harinath <rharinath@novell.com>
5996 Clean up semantics of invoking ResolveMemberAccess.
5997 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
5998 can have an instance, ensure that we pass in a non-TypeExpression
5999 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
6000 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
6001 argument. Update to changes and simplify.
6002 (FieldExpr.Emitinstance): Remove CS0120 check.
6003 (PropertyExpr.EmitInstance): Likewise.
6004 * expression.cs (Argument.Resolve): Likewise.
6005 (Invocation.DoResolve): Update to changes in semantics of
6008 2005-03-31 Marek Safar <marek.safar@seznam.cz>
6011 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
6014 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
6016 2005-03-31 Raja R Harinath <rharinath@novell.com>
6018 Fix difference in behaviour with commandline invocation.
6019 * driver.cs (Driver.Reset): New.
6020 (CompilerCallableEntryPoint): Call it.
6022 * statement.cs (If.Resolve): Avoid spurious "uninitialized
6023 variable" warnings if the boolean expression failed to resolve.
6025 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
6027 * attribute.cs: Fix the union of several permissions when some of them
6028 are unrestricted (so the result isn't an unrestricted permission set).
6031 2005-03-30 Raja R Harinath <rharinath@novell.com>
6033 * ecore.cs (MemberExpr): New class. Convert from interface
6035 (MemberExpr.ResolveMemberAccess): Refactor and move here from
6036 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
6038 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
6039 (MethodGroupExpr.IsExplicitImpl): Remove.
6040 (Expression.GetFieldFromEvent): Remove.
6041 (SimpleName.MemberStaticCheck): Remove.
6042 (SimpleName.DoSimpleNameResolve): Update to changes.
6043 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
6044 (MemberAccess.IdenticalNameAndTypeName): Remove.
6045 (MemberAccess.error176): Move to MemberExpr.
6046 (MemberAccess.DoResolve): Update to changes.
6047 (BaseAccess.DoResolve): Likewise.
6049 2005-03-30 Marek Safar <marek.safar@seznam.cz>
6051 C# 2.0 Conditional attribute class implementation
6053 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
6054 Analyzes class whether it has attribute which has ConditionalAttribute
6055 and its condition is not defined.
6057 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
6058 (Class.IsExcluded): New method. Search for at least one defined
6059 condition in ConditionalAttribute of attribute class.
6061 2005-03-30 Raja R Harinath <rharinath@novell.com>
6063 * ecore.cs (PropertyExpr): Derive from Expression, not
6064 ExpressionStatement.
6065 (PropertyExpr.EmitStatement): Remove.
6067 2005-03-29 Raja R Harinath <rharinath@novell.com>
6070 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
6071 internal field "value__" of an enum be private. The examples for
6072 "value__" that I found on MSDN all used FieldAttributes.Private.
6074 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
6075 Don't mention IL method attribute names.
6077 Fix #47991. Remove a TODO.
6078 * statement.cs (Block.Toplevel): Make into a field.
6079 (Block.Parameters): Move into ToplevelBlock.
6080 (Block.known_variables): Rename from child_variable_names.
6081 (Block.Block): Remove variants that take Parameters. Initialize
6082 'Toplevel' with the immediately surrounding toplevel block.
6083 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
6084 LocalInfo parameter.
6085 (Block.GetKnownVariableInfo): New.
6086 (Block.IsVariableNameUsedInChildBlock): Update.
6087 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
6088 the block, even though it may not be in scope.
6089 (Block.AddVariable): Remove Parameters parameter. Use
6090 Toplevel.Parameters instead.
6091 (Block.AddConstant): Remove Parameters parameter.
6092 (Block.GetParameterReference): Update to use Toplevel.Parameters.
6093 (Block.IsParamaterReference): Likewise.
6094 (Block.IsLocalParameter): Likewise. Simplify a lot.
6095 (ToplevelBlock.Parameters): New. Moved from Block.
6096 (ToplevelBlock.ToplevelBlock): Update to changes. Always
6097 initialize Parameters to a non-null value.
6098 * cs-parser.jay: Update to changes.
6099 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
6100 simple names that mean different things in the same block. Use
6101 Block.IsVariableNameUsedInBlock.
6103 2005-03-28 Raja R Harinath <rharinath@novell.com>
6105 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
6107 2005-03-26 Raja R Harinath <harinath@acm.org>
6110 * assign.cs (Assign.DoResolve): When the RHS of an assignment
6111 fails to resolve, ensure that the LHS is still resolved as an
6114 2005-03-25 Raja R Harinath <harinath@acm.org>
6116 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
6118 (Enum.current_ec): Remove.
6119 (Enum.LookupEnumValue): Remove EmitContext argument.
6120 Just uses the one created during DefineType.
6121 (Enum.FindMembers): Update.
6122 * expression.cs (MemberAccess.DoResolve): Update.
6124 2005-03-22 Marek Safar <marek.safar@seznam.cz>
6126 * assign.cs (Assign.DoResolve): Check for CS1717 when
6127 source and target are same (uses Equals).
6129 * expression.cs (LocalVariableReference, ParameterReference,
6130 This): Implemented Equals, GetHashCode.
6132 * statement.cs (Block.GetParameterReference): Removed useless
6135 2005-03-22 Raja R Harinath <rharinath@novell.com>
6138 * statement.cs (Block.AddVariable): Ensure that we skip implicit
6139 blocks before deciding whether the error is cs0136 or cs0128.
6141 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
6142 (using_alias_directive, using_namespace_directive): Pass
6143 MemberName, not an expression to Namespace.UsingAlias and
6145 (MakeName): Use the MemberName of the namespace.
6146 * namespace.cs (Namespace.MemberName): New.
6147 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
6148 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
6150 * decl.cs (MemberName.Name): Make readonly.
6151 (MemberName.FromDotted): New "constructor".
6152 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
6153 (MemberCore.Name): Compute from MemberName on demand.
6154 (MemberCore.SetMemberName): Provide a way to change the
6156 (MemberCore.AddToContainer): Don't take a fullname parameter.
6157 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
6158 fully qualified name of the container to the member name.
6159 (TypeContainer.AddToTypeContainer): Use a fully qualified name
6160 only if the type is a member of the root container.
6161 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
6162 MemberName.Left rather than searching for an embedded ".".
6163 (PartialContainer.CreatePart): Update to changes in RootContext.
6164 (MemberBase.ShortName): Turn into a property. Use
6165 MemberCore.SetMemberName.
6166 (MemberBase.ExplicitInterfaceName): Remove.
6167 (MemberBase.UpdateMemberName): Remove.
6168 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
6169 (PropertyBase.SetMemberName): New override.
6170 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
6171 (Tree.GetDecl): New.
6172 (Tree.AllDecls): Rename from Decls.
6173 * attribute.cs, enum.cs, report.cs: Update to changes.
6174 * driver.cs (MainDriver): Use MemberName.FromDotted on
6175 RootContext.MainClass.
6177 2005-03-21 Marek Safar <marek.safar@seznam.cz>
6179 * class.cs (FixedField.Define): Check for CS1664 and more sanity
6182 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
6184 2005-03-18 Marek Safar <marek.safar@seznam.cz>
6186 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
6187 property accessor modifiers.
6189 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
6190 fixed buffer attribute (CS1716).
6191 (PropertyMethod.HasCustomAccessModifier): When property accessor
6192 has custom modifier.
6194 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
6196 (PropertyExpr.DoResolveLValue): Add CS0272.
6198 2005-03-17 Miguel de Icaza <miguel@novell.com>
6200 * convert.cs: When converting to a pointer, use the proper Conv.U
6201 or Conv.I depending on the source data type.
6203 * cs-tokenizer.cs: Make the size for large decimal constants,
6206 2005-03-17 Martin Baulig <martin@ximian.com>
6208 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6209 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6211 2005-03-17 Martin Baulig <martin@ximian.com>
6213 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6214 to bool so we can return an error condition.
6215 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6218 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
6220 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
6223 2005-03-16 Raja R Harinath <rharinath@novell.com>
6225 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
6226 Refactor to avoid traversing the list of assemblies, and to avoid
6227 string concatenation.
6228 * typemanager.cs (guid_attr_type): Remove.
6229 (negative_hits, pointers, references): Remove hashes.
6231 (GetConstructedType): New. Uses type_hash to handle constructed
6232 types (arrays, references, pointers).
6233 (GetReferenceType, GetPointerType): Use it.
6234 (GetNestedType): New. Uses type_hash to handle nested types of
6236 (LookupType, LookupTypeDirect): Remove.
6237 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
6238 'types' hash and LookupTypeReflection directly.
6239 (params_string, params_object): Use GetConstructedType.
6240 * namespace.cs (Namespace.cached_types): New. Cache of reflected
6242 (Namespace.Lookup): Use cached_types.
6243 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
6244 provided by old TypeManager.LookupType.
6245 * rootcontext.cs (MakeFQN): Remove.
6246 * decl.cs (DeclSpace.MakeFQN): Likewise.
6247 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
6248 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6249 TypeManager.GetConstructedType.
6250 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
6252 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
6254 * cs-parser.jay: Fix build.
6256 2005-03-15 Marek Safar <marek.safar@seznam.cz>
6258 * class.cs (TypeContainer.CircularDepException) New nested
6259 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
6261 * cs-parser.jay: Reports CS1527 for any namespace element.
6263 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
6266 * expression.cs (ParameterReference.IsAssigned): Changed error to
6268 (Error_WrongNumArguments): Moved CS0245 detection here.
6270 * statement.cs (Return.Resolve): Add CS1622 report.
6272 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6274 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6276 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6278 * attribute.cs expression.cs: Get rid of some allocations.
6280 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6282 * doc.cs : just eliminate the latest change.
6284 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6286 * doc.cs : commented out the latest change. It breaks xml-030.cs
6288 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6290 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6291 fail. So invoke CreateType() in FindDocumentedType().
6293 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6295 * cs-tokenizer.cs : added IsKeyword().
6296 * doc.cs : Detect keyword incorrectly used as identifier.
6297 Allow identifiers prefixed by @.
6299 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6301 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6302 It caused exception in namespace resolving (again!).
6304 * class.cs (Class.ctor): Removed exit.
6305 (PropertyMethod.ctor): ditto.
6307 * codegen.cs (Codegen.Reset): Reset static data.
6308 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6310 * cs-tokenizer.cs (Cleanup): Removed.
6312 * driver.cs (GetSystemDir): Rewrote to one line command.
6313 It caused problem with unloaded dynamic modules.
6314 (UnixParseOption): Removed Exit.
6315 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6316 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6317 Now can be mcs used as library.
6319 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6322 * location.cs (Reset): Reset static data.
6324 * namespace.cs (Reset): Reset static data.
6326 * report.cs (Report.Reset): Reset static data.
6328 * rootcontext.cs (RootContext.Reset): Reset static data.
6330 * tree.cs (RootTypes.ctor): Use Location.Null
6332 * typemanager.cs (TypeManager.Reset): Reset static data.
6333 (CoreLookupType): Removed Exit.
6334 (TypeHandle.Reset): Reset static data.
6336 2005-03-10 Raja R Harinath <rharinath@novell.com>
6339 * typemanager.cs (ComputeNamespaces): Import namespaces from
6340 referenced modules too.
6342 2005-03-09 Raja R Harinath <rharinath@novell.com>
6344 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6347 2005-03-09 Raja R Harinath <rharinath@novell.com>
6349 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6350 enclosing DeclSpace. This ensures that a name-lookup populates
6351 more caches and there are fewer 'TypeExpression's. Carve out
6352 nested type lookup into ...
6353 (LookupNestedTypeInHierarchy): ... this.
6355 2005-04-15 Martin Baulig <martin@ximian.com>
6357 Merged r41590 from MCS and make it work in the generics land.
6359 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6362 * class.cs (PartialContainer.UpdateConstraints): Removed.
6363 (PartialContainer.CheckConstraints): Removed.
6364 (PartialContainer.SetParameterInfo): Store the constraints here.
6365 (PartialContainer.DefineTypeParameters): New public method;
6366 resolve the type parameter's constraints here. Note that the
6367 PartialContainer doesn't have an EmitContext anymore, so we must
6368 do this in the ClassPart.
6370 2005-03-09 Raja R Harinath <rharinath@novell.com>
6372 Clean up a few partial-class semantics.
6373 Fixes test-357.cs and cs1618-2.cs.
6374 * cs-parser.jay (struct_declaration): Use 'current_class' as
6375 parent of newly-created struct. Remove call to Register ().
6376 Use 'pop_current_class' to complete handing the current struct.
6377 (interface_declaration): Likewise.
6378 (class_declaration): Likewise.
6379 (enum_declaration): Use 'current_class' as parent of newly created
6381 (delegate_declaration): Likewise.
6382 (pop_current_class): New function. This is used to handle closing
6383 up the 'current_class' and 'current_container', and pointing them
6384 to the enclosing class/container.
6385 (CSharpParser): Initialize 'current_class' too.
6386 * decl.cs (MemberCore): Add check for invariant: a partial
6387 container is not a parsed entity, and thus does not enclose any
6389 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6390 (DeclSpace.BaseTypeExpr): Use it.
6391 (DeclSpace.LookupType): Add check for invariant.
6392 * class.cs (TypeContainer): Add check for invariant: a nested
6393 class should have the same NamespaceEntry as its enclosing class.
6394 (TypeContainer.EmitFieldInitializers): Make virtual.
6395 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6397 (TypeContainer.Register): Remove.
6398 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6399 null. Use TypeResolveEmitContext for resolving base types and
6400 interfaces. Move initialization of Parts.TypeBuilder here from
6402 (TypeContainer.DefineNestedTypes): ... here.
6403 (PartialContainer): Take a Namespace not a NamespaceEntry.
6404 (PartialContainer.Create): Don't use Register. Call the
6405 appropriate Add... function directly.
6406 (ClassPart): Take both the PartialContainer and the enclosing
6407 class as constructor arguments.
6408 (ClassPart.EmitFieldInitializers): Override.
6409 (ClassPart.PartFindNestedTypes): Remove.
6410 (FieldBase.GetInitializerExpression): Resolve the initializer
6411 expression in the emit context of the enclosing class.
6412 * tree.cs (RootTypes): Remove Register ().
6414 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6416 * cs-parser.jay: Removed CS0134.
6418 * driver.cs: Removed CS1901.
6420 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6421 for predefined types.
6423 2005-03-07 Duncan Mak <duncan@novell.com>
6425 * codegen.cs (Save): Catch UnauthorizedAccessException as
6426 well. Fixes bug #73454.
6428 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6430 * cs-tokenizer.cs (xtoken): Add CS1035.
6432 * class.cs (MethodData.Define): Add CS0683.
6433 (FieldMember.ctor): Add CS0681.
6435 2005-03-07 Raja R Harinath <rharinath@novell.com>
6437 * ecore.cs (SimpleName.DoResolve): Rename from
6438 SimpleName.DoResolveAllowStatic.
6439 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6440 Pass 'intermediate' flag to MemberStaticCheck.
6441 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6442 of "intermediate" lookups via MemberAccess.
6443 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6444 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6446 2005-03-07 Raja R Harinath <rharinath@novell.com>
6449 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6450 slipped in because of variable names that are identical to a
6451 builtin type's BCL equivalent ('string String;', 'int Int32;').
6452 (PropertyExpr.EmitInstance): Likewise.
6454 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6456 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6458 * report.cs (warning_ignore_table): Made public.
6460 2005-03-04 Raja R Harinath <rharinath@novell.com>
6463 * class.cs (MethodData.Emit): Pass 'container' to
6464 container.GetObsoleteAttribute instead of 'container.Parent'.
6466 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6468 * cs-parser.jay: Add 1534 error test.
6470 * iterators.cs (Yield.CheckContext): Add error 1629.
6471 (Iterator.ctor): Save unsafe modifier.
6472 (MoveNextMethod.DoEmit): Restore unsafe context.
6474 * namespace.cs (UsingAlias): Better error message.
6476 2005-03-03 Dan Winship <danw@novell.com>
6478 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6479 the warning message [#73219]
6481 2005-03-03 Raja R Harinath <rharinath@novell.com>
6483 Fix compile with MCS 1.0.0.0.
6484 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6485 w_restore to not depend on string constant folding.
6487 2005-03-03 Raja R Harinath <rharinath@novell.com>
6489 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6490 CS0246 check to users who passed 'silent = false'.
6491 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6493 (SimpleName.SimpleNameResolve): Update.
6494 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6495 (MemberAccess.IdenticalNameAndTypeName): Update.
6496 * doc.cs (FindDocumentedTypeNonArray): Update.
6498 2005-03-03 Raja R Harinath <rharinath@novell.com>
6500 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6501 * parameters.cs (ComputeAndDefineParameters): Remove.
6502 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6503 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6504 Use GetParameterInfo.
6506 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6508 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6510 2005-03-02 Raja R Harinath <rharinath@novell.com>
6512 Unify DeclSpace.LookupType and DeclSpace.FindType.
6513 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6514 is in charge of defining nested types on demand.
6515 (DeclSpace.LookupType): Use it when the current_type is a
6516 TypeBuilder. Use LookupTypeDirect for reflected types.
6517 (DeclSpace.FindType): Remove.
6518 (DeclSpace.LookupInterfaceOrClass): Likewise.
6519 (DeclSpace.DefineTypeAndParents): Likewise.
6520 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6521 DeclSpace.LookupType.
6522 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6523 * typemanager.cs (LookupType): Simplify.
6524 (AddUserType): Remove type from negative_hits.
6525 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6526 * class.cs (TypeContainer.FindMembers): Move handling of nested
6528 (TypeContainer.FindMembers_NestedTypes): ... here.
6529 (TypeContainer.FindNestedType): Implement override.
6530 (ClassPart.FindNestedType): Delegate to PartialContainer.
6531 (ClassPart.PartFindNestedType): Looks up the nested types of the
6534 2005-04-14 Martin Baulig <martin@ximian.com>
6536 * generic.cs (ConstructedType): Moved all the type lookup and
6537 nested class logic into SimpleName.
6538 (ConstructedType.ResolveConstructedType): Our underlying type is
6539 already fully resolved; all the type lookup stuff is in
6542 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6543 constructed types here instead of in ConstructedType.
6545 * decl.cs (MemberName.GetTypeExpression): Always create a
6546 SimpleName, not a ConstructedType.
6547 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6549 2005-03-02 Martin Baulig <martin@ximian.com>
6551 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6552 static constructor in static classes.
6554 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6556 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6557 sizeParamIndex is not specified.
6559 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6562 * report.cs (WarningMessage.IsEnabled): Missing null check.
6564 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6566 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6567 in the fields and not in the properties.
6569 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6571 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6574 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6576 * attribute.cs: Small refactoring (improved robustness).
6577 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6578 (ValidateGuid): Removed.
6579 (Resolve): Removed referenced to above mentioned.
6580 (GetAttributeUsage): Made private and changed to work without
6582 (GetIndexerAttributeValue): Don't crash.
6583 (GetConditionalAttributeValue): Ditto.
6584 (GetClsCompliantAttributeValue): Ditto.
6585 (ExtractSecurityPermissionSet): All attributes exceptions are
6587 (GetPropertyValue): New helper.
6588 (GetMethodImplOptions): New method.
6589 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6590 some missing properties.
6592 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6593 (Method.ApplyAttributeBuilder): Updated.
6595 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6598 2005-02-28 Raja R Harinath <rharinath@novell.com>
6601 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6602 non-simple types (array, pointer, reference).
6604 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6606 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6608 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6610 (Method.CheckBase): Catch wrong destructor here.
6611 (MethodData.Define): Add errors 550, 668.
6613 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6615 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6617 * pending.cs (VerifyPendingMethods): Add error 551.
6619 * typemanager.cs (CSharpName): Next error report helper.
6621 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6623 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6624 attributes. Removed useless attribute double check.
6625 It saves almost 2MBs for corlib.
6627 2005-02-25 Raja R Harinath <rharinath@novell.com>
6630 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6631 called twice in case of error.
6633 2005-02-23 Chris Toshok <toshok@ximian.com>
6635 Fix compiler portions of #72827.
6636 * statement.cs (Block.Emit): call Begin/EndScope on the
6637 EmitContext instead of the ILGenerator.
6639 * codegen.cs (EmitContext.BeginScope): new method, call
6640 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6642 (EmitContext.BeginScope): same, but EndScope and CloseScope
6644 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6645 offset and call the superclass's OpenScope(int) with it.
6646 (SymbolWriter.CloseScope): get the current il
6647 offset and call superclass's CloseScope(int) with it.
6649 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6651 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6652 CS1677 for out and ref as well.
6654 * class.cs (Method.Define): Add error CS1599 detection.
6656 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6658 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6660 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6662 * support.cs.cs (ModifierDesc): New helper method.
6664 2005-02-23 Raja R Harinath <rharinath@novell.com>
6665 Abin Thomas <projectmonokochi@rediffmail.com>
6666 Anoob V E <projectmonokochi@rediffmail.com>
6667 Harilal P R <projectmonokochi@rediffmail.com>
6670 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6671 MemberLookup (used for error reporting) actually returns a result.
6672 Fix error report number (122, not 112).
6674 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6675 Anoob V E <projectmonokochi@rediffmail.com>
6676 Harilal P R <projectmonokochi@rediffmail.com>
6679 * pending.cs (PendingImplementation.GetAbstractMethods):
6680 Find NonPublic members too.
6682 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6684 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6687 * class.cs (MethodCore.CheckMethodAgainstBase):
6688 Add error 239 report.
6690 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6692 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6694 * class.cs (Operator.Define): Add error 217 report.
6696 2005-02-21 Raja R Harinath <rharinath@novell.com>
6699 * expression.cs (Invocation.IsApplicable): Make public.
6700 (Invocation.IsParamsMethodApplicable): Likewise.
6701 * delegate.cs (Delegate.VerifyApplicability): Don't use
6702 Invocation.VerifyArgumentCompat for parameter applicability
6703 testing. Use Invocation.IsApplicable and
6704 Invocation.IsParamsMethodApplicable.
6706 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6708 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6710 * class.cs (Operator.Define): Add error 217 report.
6712 2005-02-21 Raja R Harinath <rharinath@novell.com>
6714 * namespace.cs (UsingEntry.Resolve): Undo change below.
6716 2005-02-21 Raja R Harinath <rharinath@novell.com>
6719 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6720 disable the error message when the extended MemberLookup also
6722 (Expression.MemberLookupFinal): Update.
6723 (SimpleName.DoSimpleNameResolve): Update.
6724 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6725 Don't use MemberLookupFinal.
6726 (New.DoResolve): Update.
6727 (BaseAccess.CommonResolve): Update.
6729 2005-02-21 Raja R Harinath <rharinath@novell.com>
6732 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6733 occured previously, don't resolve again.
6735 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6738 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6739 argument. Call ResolveAttributeUsage for unresolved.
6740 when types doesn't match ctor arguments.
6742 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6743 for nested attribute classes.
6744 (Class.attribute_usage): Removed.
6745 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6746 for attribute class.
6748 * ecore.cs (IsAttribute): Removed.
6750 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6752 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6754 (attribute_types): Removed.
6755 (EmitCode): Global attributes are emited as the latest.
6757 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6759 * class.cs (EmitFieldInitializers): Don't emit field initializer
6760 for default values when optimilization is on.
6762 * constant.cs (Constant.IsDefaultValue): New property.
6764 * driver.cs: Add /optimize handling.
6768 * literal.cs: Implement new IsDefaultValue property.
6770 * rootcontext.cs (Optimize): New field, holds /optimize option.
6772 2005-02-18 Raja R Harinath <rharinath@novell.com>
6774 Fix crasher in re-opened #72347.
6775 * namespace.cs (Namespace.Lookup): Return null if
6776 DeclSpace.DefineType returns null.
6779 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6781 2005-02-18 Raja R Harinath <rharinath@novell.com>
6783 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6784 now returns null if it cannot resolve to an lvalue.
6785 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6786 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6787 returned null. Remove check for SimpleName.
6788 (EventExpr.DoResolveLValue): New.
6789 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6790 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6792 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6794 (Unary.ResolveOperator): Move CS0211 check ...
6795 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6797 (Unary.DoResolveLValue): Simplify.
6798 (AddressOf.DoResolveLValue): New.
6799 (ArrayAccess.DoResolveLValue): New.
6801 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6803 * attribute.cs (Attribute.Resolve): Add arguments casting for
6804 when types doesn't match ctor arguments.
6806 2005-02-16 Raja R Harinath <rharinath@novell.com>
6808 Fix parts of #63202.
6809 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6810 lookup of operator in base type. Ensure that all checks happen
6811 when the operator resolves to an "op_..." method.
6813 2005-02-15 Raja R Harinath <rharinath@novell.com>
6816 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6817 'ignore_cs0104' parameter. Pass it to ...
6818 (NamespaceEntry.Lookup): ... this.
6819 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6820 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6821 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6822 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6823 Update. Request that cs0104 errors be ignored.
6824 (ComposedCast.ResolveAsTypeStep): Update.
6826 2005-02-14 Raja R Harinath <rharinath@novell.com>
6829 * expression.cs (Invocation.BetterFunction): Remove support for
6830 comparing virtual functions and their overrides.
6831 (Invocation.IsOverride): New.
6832 (Invocation.OverloadResolve): Don't consider 'override' functions
6833 during candidate selection. Store them in a lookaside list.
6834 If the selected method is a 'virtual' function, use the list to
6835 find any overrides that are closer to the LHS type.
6837 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6839 * expression.cs (New.DoResolve): Add complex core type reduction.
6840 (New.Constantify): Converts complex core type syntax like 'new int ()'
6843 2005-02-14 Raja R Harinath <rharinath@novell.com>
6845 * decl.cs (EntryType.EntryType): New constructor to create an
6846 updated copy of a cache entry.
6847 (MemberCache.AddMethods): Use it.
6848 (MemberCache.ClearDeclaredOnly): Remove.
6849 (MemberCache.MemberCache): Update.
6851 2005-02-11 Miguel de Icaza <miguel@novell.com>
6853 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6854 variable. This one is represents the actual low-level declaration
6855 of the method, as opposed to the semantic level `IsStatic'.
6857 An anonymous method which is hosted into a static method might be
6858 actually an instance method. IsStatic would reflect the
6859 container, while MethodIsStatic represents the actual code
6862 * expression.cs (ParameterReference): Use the new MethodIsStatic
6863 instead of IsStatic.
6865 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6866 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6867 set on the current EmitContext.
6869 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6870 resolve our casted expression as an LValue. This triggers the
6871 proper LValue processing that is later required by Assign.
6875 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6877 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6879 C# 2.0 Fixed buffer implementation
6881 * anonymous.cs: Update after RegisterHelperClass renaming.
6883 * attribute.cs (AttributeTester.fixed_buffer_cache):
6884 Cache of external fixed buffers.
6885 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
6886 implementation if field is fixed buffer else null.
6889 (TypeContainer.AddField): Accept FieldMember instead of Field.
6890 (FieldBase.IsFieldClsCompliant): Extracted code from
6891 VerifyClsCompliance descendant customization.
6892 (FixedField): New class handles fixed buffer fields.
6893 (FixedFieldExternal): Keeps information about imported fixed
6895 (IFixedField): Make access to internal or external fixed buffer
6898 * cs-parser.jay: Add fixed buffer parsing.
6900 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
6903 * expression.cs (Indirection): Extended implementation to accept
6905 (PointerArithmetic.Emit): Get element from fixed buffer as well.
6906 (ElementAccess.MakePointerAccess): Get type as parameter.
6907 (DoResolve): Add fixed buffer field expression conversion.
6908 (DoResolveLValue): Ditto.
6909 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
6910 (ArrayPtr): Derives from FixedBufferPtr.
6911 (ArrayPtr.Emit): Add extra emit for array elements.
6913 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
6915 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
6916 for compiler generated types.
6917 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
6919 * statement.cs (Fixed): Refactored to be easier add fixed buffer
6920 and consume less memory.
6921 (Fixed.Resolve): Add fixed buffer case.
6923 * typemanager.cs (compiler_generated_attr_ctor,
6924 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
6925 (HasElementType): Add our own implementation to work on every
6928 2005-02-11 Miguel de Icaza <miguel@novell.com>
6930 * anonymous.cs (CaptureContext): Track whether `this' has been
6933 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
6934 only captured `this' if it was implicitly done (instance
6935 methods/variables were used).
6937 * codegen.cs (EmitContext.CaptureThis): New method to flag that
6938 `this' must be captured.
6940 2005-01-30 Miguel de Icaza <miguel@novell.com>
6942 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
6943 is null it means that there has been no need to capture anything,
6944 so we just create a sibling.
6946 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
6948 Just a partial fix. The other half is fairly elusive.
6950 2005-02-10 Raja R Harinath <rharinath@novell.com>
6952 Fix #52586, cs0121-4.cs.
6953 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
6954 and return a hashtable.
6955 (MemberCache.ClearDeclaredOnly): New.
6956 (MemberCache.MemberCache): Update to change. Make a deep copy of
6957 the method_hash of a base type too.
6958 (MemberCache.AddMethods): Adapt to having a deep copy of the base
6959 type methods. Overwrite entries with the same MethodHandle so
6960 that the ReflectedType is correct. The process leaves in base
6961 virtual functions and their overrides as distinct entries.
6962 (CacheEntry): Now a class instead of a struct. It shouldn't alter
6963 matters since it was boxed in a ArrayList before.
6964 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
6966 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
6967 case of a virtual function and its override (choose the overload
6969 (Invocation.OverloadResolve): Avoid 'override' members during
6970 'applicable_type' calculation.
6972 2005-03-28 Raja R Harinath <rharinath@novell.com>
6974 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
6975 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
6976 GetTypeHandle. It is possible for a reflected type to derive from
6977 a TypeBuilder (e.g., int[] derives from the TypeBuilder
6978 System.Array during mscorlib compilation).
6979 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
6980 contain a method_hash, don't create one either. Don't create a
6981 deep copy of the base cache's method_hash.
6982 (MemberCache.SetupCache): Rename back from DeepCopy.
6983 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
6984 already initialized. If we see an override function, add its
6985 underlying base virtual function to the member_hash too.
6987 2005-02-09 Raja R Harinath <rharinath@novell.com>
6989 Combine two near-redundant caches.
6990 * typemanager.cs (method_params): Rename from method_internal_params.
6991 (TypeManager.GetParameterData): New. Replace
6992 Invocation.GetParameterData.
6993 (TypeManager.LookupParametersByBuilder): Remove.
6994 * expression.cs (Invocation.method_parameter_cache): Remove.
6995 (Invocation.GetParameterData): Remove.
6997 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
7000 2005-02-08 Raja R Harinath <rharinath@novell.com>
7003 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
7004 TypeManager.multicast_delegate_type is null, resolve it by looking
7005 up "System.MulticastDelegate".
7006 * rootcontext.cs (RootContext.ResolveCore): Simplify.
7008 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
7009 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
7010 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
7013 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
7014 (LabeledStatement.AddReference): New. Set 'referenced'.
7015 (Goto.Resolve): Use it.
7017 2005-02-05 John Luke <john.luke@gmail.com>
7019 * driver.cs: remove duplicate -doc line in Usage ()
7021 2005-02-04 Raja R Harinath <rharinath@novell.com>
7023 * location.cs (Location.AddFile): Fix CS2002 error report.
7025 2005-02-02 Martin Baulig <martin@ximian.com>
7027 * delegate.cs (Delegate.DefineType): Report an internal error if
7028 TypeManager.multicast_delegate_type is null. See bug #72015 for
7031 2005-02-02 Raja R Harinath <rharinath@novell.com>
7033 Fix a crasher in a variant of #31984.
7034 * const.cs (Constant.CheckBase): New override that defers the
7035 new-or-override check in case the base type hasn't been populated
7037 (Constant.Define): Ensure the new-or-override check is performed.
7039 2005-02-01 Duncan Mak <duncan@ximian.com>
7041 * const.cs (LookupConstantValue): Check that `ce' is not null
7042 before calling GetValue ().
7044 2005-02-01 Raja R Harinath <rharinath@novell.com>
7046 Fix test-334.cs (#69519).
7047 * cs-parser.jay (using_alias_directive): Pass in an expression to
7048 NamespaceEntry.UsingAlias.
7049 (using_namespace_directive): Pass in an expression to
7050 NamespaceEntry.Using.
7051 (namespace_name): Don't flatten to a string.
7052 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
7053 (NamespaceEntry.AliasEntry.Resolve): Lookup using
7055 (NamespaceEntry.UsingEntry): Likewise.
7056 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
7058 (NamespaceEntry.LookupForUsing): Remove.
7059 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
7061 (NamespaceEntry.Lookup): Remove support for dotted names.
7063 2005-02-01 Raja R Harinath <rharinath@novell.com>
7065 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
7067 (NamespaceEntry.ImplicitParent): Compute on demand.
7068 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
7069 parallels the current.
7070 (NamespaceEntry.LookupForUsing): Use it.
7071 (NamespaceEntry.Lookup): If the current namespace-entry is
7072 implicit, don't search aliases and using tables.
7074 2005-02-01 Raja R Harinath <rharinath@novell.com>
7077 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
7079 (TypeContainer.BaseCache): Compute on demand.
7080 (TypeContainer.FindMembers): Define constants and types if they're
7081 not already created.
7082 (FieldMember.Define): Move resetting of ec.InUnsafe before error
7084 * const.cs (Constant.Define): Make idempotent.
7086 2005-01-29 Miguel de Icaza <miguel@novell.com>
7088 * pending.cs: Produce better code (no nops produced by using Ldarg
7091 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7092 i - 1' it should be arg + 1.
7096 2005-01-28 Raja R Harinath <rharinath@novell.com>
7098 * attribute.cs (Attribute.CheckAttributeType): Make private
7100 (Attribute.ResolveType): Make virtual.
7101 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
7102 handling of RootContext.Tree.Types.
7104 2005-01-27 Raja R Harinath <rharinath@novell.com>
7106 Update attribute-handling to use the SimpleName/MemberAccess
7108 * cs-parser.jay (attribute): Pass in an expression to the
7109 constructors of Attribute and GlobalAttribute.
7110 * attribute.cs (Attribute): Take an expression for the name.
7111 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
7112 passed in attribute name expression.
7113 (Attribute.CheckAttributeType): Use it.
7114 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
7115 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
7116 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
7117 argument to prevent error messages if the lookup fails.
7119 2005-01-27 Marek Safar <marek.safar@seznam.cz>
7121 * expression.cs (Indirection): Implemented IVariable interface
7122 to support indirection in AddressOf operator.
7123 (PointerArithmetic.Emit): Add optimalization for case where
7124 result can be precomputed.
7126 2005-01-26 Martin Baulig <martin@ximian.com>
7128 * class.cs (TypeContainer.AttributeTargets): Return the correct
7129 AttributeTargets depending on our `Kind' instead of throwing an
7130 exception; fixes #71632.
7132 2005-01-26 Marek Safar <marek.safar@seznam.cz>
7135 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
7138 2005-03-17 Martin Baulig <martin@ximian.com>
7140 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
7141 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
7143 2005-03-17 Martin Baulig <martin@ximian.com>
7145 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
7146 to bool so we can return an error condition.
7147 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
7150 2005-03-17 Martin Baulig <martin@ximian.com>
7152 * generic.cs (TypeMananager.IsIEnumerable): New public method.
7154 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
7155 converting from an array-type of T to `IEnumerable<T>'.
7157 2005-03-16 Martin Baulig <martin@ximian.com>
7159 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
7160 (Nullable.LiftedUnaryMutator): New public class.
7162 * expression.cs (UnaryMutator.DoResolve): Added support for
7165 2005-03-14 Martin Baulig <martin@ximian.com>
7167 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
7169 2005-03-14 Martin Baulig <martin@ximian.com>
7171 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
7172 the comparision operators `<', `>', `<=' and `>='.
7174 2005-03-13 Martin Baulig <martin@ximian.com>
7177 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
7178 avoid confusion with the `NullLiteral'.
7179 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
7181 2005-03-13 Martin Baulig <martin@ximian.com>
7183 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
7184 comparing arbitrary types with the null literal.
7186 2005-03-13 Martin Baulig <martin@ximian.com>
7188 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
7189 boolean operators '&&', '||', '&' and '|'.
7190 (Nullable.OperatorTrueOrFalse): New public class.
7192 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
7193 instead of a `StaticCallExpr'; added support for nullables.
7195 2005-03-10 Martin Baulig <martin@ximian.com>
7198 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
7199 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
7201 2005-03-07 Martin Baulig <martin@ximian.com>
7203 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
7204 it work if `expr' is not an IMemoryLocation.
7205 (Nullable.Lifted): Implement IMemoryLocation.
7206 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
7209 2005-03-05 Martin Baulig <martin@ximian.com>
7211 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
7212 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
7213 (Nullable): Added support for lifted unary and binary operators.
7215 * expression.cs (Unary.DoResolve): Added support for nullable types.
7216 (Binary.DoResolve): Likewise.
7217 (Conditional.DoResolve): Likewise.
7219 2005-03-02 Martin Baulig <martin@ximian.com>
7221 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
7223 * class.cs (ClassPart.SetParameterInfo): Override this.
7224 (PartialContainer.SetParameterInfo): Override this.
7225 (TypeContainer.CheckConstraints): New protected method.
7226 (PartialContainer.CheckConstraints): Override this and check
7227 whether the same contraints were specified in all parts of a
7228 partial generic type definition.
7229 (PartialContainer.UpdateConstraints): New public method.
7231 * generic.cs (TypeParameter.UpdateConstraints): New public method.
7233 2005-03-02 Martin Baulig <martin@ximian.com>
7235 Committing a patch from Carlos Alberto Cortez to fix #72887.
7237 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
7238 casts from `T []' to `int []'.
7240 2005-03-02 Martin Baulig <martin@ximian.com>
7242 * generic.cs (TypeManager.IsEqual): Make this symmetric.
7244 * expression.cs (Binary.ResolveOperator): When resolving a
7245 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
7246 `=='. Fixes #71866. See gen-127.cs.
7248 2005-03-02 Martin Baulig <martin@ximian.com>
7250 * class.cs (TypeContainer.DoDefineMembers): We also need a default
7251 static constructor in static classes.
7253 2005-03-02 Martin Baulig <martin@ximian.com>
7256 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
7257 (Nullable.LiftedConversion): Added support for user-defined
7260 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
7262 * cs-parser.jay: Use ComposedCast everywhere instead of
7263 NullableType, so we don't need to check for NullableType
7265 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
7266 case where we'll be resolved into a `parenthesized_expression_0'
7270 (Convert.UserDefinedConversion): Added nullable conversions.
7272 2005-02-28 Martin Baulig <martin@ximian.com>
7274 * generic.cs (TypeManager.IsNullableType): New static method.
7275 (Nullable): New abstract class.
7276 (Nullable.NullLiteral): New public class.
7277 (Nullable.LiftedConversion): New public class.
7279 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7280 `builtin_types opt_nullable'.
7283 (Convert.ImplicitConversionStandard): Added nullable conversions.
7284 (Convert.ExplicitConversionStandard): Likewise.
7285 (Convert.ExplicitConversion): Likewise.
7287 2005-02-26 Martin Baulig <martin@ximian.com>
7289 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7290 begin with a "?", for instance "?[]". Don't do a type lookup if
7293 2005-02-25 Martin Baulig <martin@ximian.com>
7295 The first part of Nullable Types :-)
7297 * generic.cs (NullableType): New public class.
7298 (NullCoalescingOperator): New public class.
7299 (TypeArguments.Resolve): Add a CS0306 check.
7301 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7302 (opt_nullable): New rule.
7303 (type): Added `opt_nullable' to `namespace_or_type_name',
7304 `builtin_types' and `pointer_type'.
7305 (array_type): Added `opt_nullable'.
7306 (opt_rank_specifier_or_nullable): New rule; this is the
7307 combination of `opt_rank_specifier' and `opt_nullable'.
7308 (opt_error): New rule; catch errors here.
7309 (nullable_type_or_conditional): New rule; we use this to check for
7310 nullable and still detect the conditional operator.
7311 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7312 instead `opt_rank_specifier'.
7314 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7317 2005-02-24 Martin Baulig <martin@ximian.com>
7319 * README, README.Changes: Removed; they're old and obsolete.
7321 2005-02-22 Martin Baulig <martin@ximian.com>
7323 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7324 returned an error, set `constraints' to null to avoid a crash
7326 (TypeParameter.ResolveType): Likewise.
7328 2005-02-22 Martin Baulig <martin@ximian.com>
7331 (Constraints.ResolveTypes): Protect against being called twice.
7332 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7333 (TypeParameter.ResolveType): New public method; calls
7334 constraints.ResolveTypes().
7335 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7336 into the new ResolveType().
7337 (GenericMethod.Define): Call ResolveType() on all our
7340 2005-02-21 Martin Baulig <martin@ximian.com>
7343 (TypeManager.generic_nullable_type): New static public field.
7344 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7347 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7349 2005-02-15 Martin Baulig <martin@ximian.com>
7351 * generic.cs (ConstructedType.Constraints): Correctly check
7352 constraints if the argument type is a type parameter; fixes
7355 2005-02-02 Martin Baulig <martin@ximian.com>
7357 * delegate.cs (Delegate.DefineType): Report an internal error if
7358 TypeManager.multicast_delegate_type is null. See bug #72015 for
7361 2005-01-29 Miguel de Icaza <miguel@novell.com>
7363 * pending.cs: Produce better code (no nops produced by using Ldarg
7366 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7367 i - 1' it should be arg + 1.
7371 2005-01-26 Martin Baulig <martin@ximian.com>
7373 * cs-parser.jay (indexer_declarator): Don't report an error if we
7374 have type parameters since we can be an explicit interface
7375 implementation; fixes #71449.
7377 2005-01-26 Martin Baulig <martin@ximian.com>
7379 * class.cs (TypeContainer.AttributeTargets): Return the correct
7380 AttributeTargets depending on our `Kind' instead of throwing an
7381 exception; fixes #71632.
7383 2005-01-26 Martin Baulig <martin@ximian.com>
7385 * delegate.cs (Delegate.DefineType): Correctly define our type
7386 parameters. Fixes #71483.
7388 2005-01-25 Raja R Harinath <rharinath@novell.com>
7391 * expression.cs (MemberAccess.DoResolve): Don't complain with
7392 cs0572 when the LHS of a member access has identical name and type
7395 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7398 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7400 Create custom PermissionSet only for PermissionSetAttribute.
7402 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7405 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7406 delegates in static class.
7408 2005-01-24 Martin Baulig <martin@ximian.com>
7410 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7411 merging an implicit block, just use its reachability.
7413 * statement.cs (Block.Resolve): Make the unreachable code check
7414 work wrt. implicit blocks; see test-337 from #63842.
7416 2005-01-21 Alp Toker <alp@atoker.com>
7418 * cs-parser.jay: destructor_declaration's container is PartialContainer
7419 not Class when partial types are used, so use Kind prop instead of
7422 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7424 * cs-parser.jay: Improve error reporting when an interface
7427 2005-01-20 Dick Porter <dick@ximian.com>
7429 * support.cs: SeekableStreamReader fix from Sandor Dobos
7430 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7431 chars are read. Fixes bug 70369.
7433 2005-01-20 Raja R Harinath <rharinath@novell.com>
7435 * cs-parser.jay (catch_clause): Simplify current_block handling
7438 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7440 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7441 code with ImplicitStandardConversion to handle the implicit
7442 conversion of method groups into valid delegate invocations.
7444 The problem is that in parameter handling we were using this code
7445 path. Fixes bug #64698
7447 2005-01-19 Raja R Harinath <rharinath@novell.com>
7449 * cs-parser.jay: Fix several infelicities.
7450 - Avoid assigning to the parser value stack. Code like
7451 '$3 = null' is unclean. Synthesize a value for the code block
7453 - Avoid using oob_stack for storing location information. Use ...
7454 (_mark_): ... this. New (empty) rule. Saves the current location
7456 (foreach_statement): Avoid using oob_stack for current_block
7457 handling. Use technique used in for_statement and
7458 using_statement. Synthesize a value for the code block to store
7459 additional intermediate information.
7461 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7463 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7464 of a different type is only allowed to private fields of a
7465 containing type, not on fields of a base class.
7467 See test-174.cs and error cs0122-9.cs
7469 2005-01-13 Raja R Harinath <rharinath@novell.com>
7471 Fix test-335.cs (bug #58126).
7472 * cs-parser.jay (argument): Split out non-expression parts of the
7473 rule into 'non_simple_argument'.
7474 (invocation_expression): Support parenthesized invocations with
7475 multiple arguments, and with single non-simple arguments.
7477 2005-01-13 Raja R Harinath <rharinath@novell.com>
7479 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7482 2005-01-12 Raja R Harinath <rharinath@novell.com>
7484 Fix cs0038-1.cs, cs1640-6.cs.
7485 * ecore.cs (Expression.Resolve): Remove special-case for
7486 SimpleName in error-handling.
7487 (Expression.almostMatchedMembers): Relax access permission to
7489 (Expression.MemberLookupFailed): Handle duplicates in
7490 almostMatchedMembers list.
7491 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7492 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7493 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7494 overload if the passed in MemberInfo is a MethodBase.
7496 2005-01-25 Martin Baulig <martin@ximian.com>
7499 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7501 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7504 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7505 for non-CAS & merge permission sets properly.
7507 2005-01-11 Raja R Harinath <rharinath@novell.com>
7509 Improve standard-compliance of simple name and member access
7510 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7511 * ecore.cs (FullNamedExpression): New abstract base class
7512 for Namespaces and TypeExpressions.
7513 (ResolveFlags.SimpleName): Remove.
7514 (SimpleName): Remove support for dotted names.
7515 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7516 DeclSpace.FindType and DeclSpace.LookupType.
7517 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7518 (Expression.ExprClassName): Make member function.
7519 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7520 a namespace. Remove creation of dotted "SimpleName"s.
7521 (MemberAccess.DoResolve): Likewise.
7522 * decl.cs (DeclSpace.Cache): Make private.
7523 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7524 (DeclSpace.FindType): Update.
7525 (DeclSpace.LookupType): Move here from RootContext. Return a
7526 FullNamedExpression.
7527 * namespace.cs (Namespace): Derive from FullNamedExpression
7528 so that it can be part of expression resolution.
7529 (Namespace.Lookup): Return an FullNamedExpression.
7530 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7532 * rootcontext.cs (NamespaceLookup): Remove.
7533 (LookupType): Move to DeclSpace.
7534 * attribute.cs (CheckAttributeType): Update.
7535 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7536 (FindDocumentedTypeNonArray): Likewise.
7538 2005-01-11 Raja R Harinath <rharinath@novell.com>
7540 Fix cs0509.cs, cs1632.cs.
7541 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7542 is the same as IsInterface.
7543 (TypeContainer.GetClassBases): Likewise.
7544 * statement.cs (LabeledStatement.ig): New field.
7545 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7547 (LabeledStatement.DoEmit): Check that the label was created with
7548 the same ILGenerator.
7550 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7553 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7554 accessors to its properties.
7556 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7557 from accessors to property.
7559 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7562 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7565 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7567 * attribute.cs: Check for null and empty strings.
7569 I have lost another battle to Paolo.
7571 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7574 * class.cs (PropertyMethod): Set Parent field in ctors.
7575 (SetMethod.InternalParameters): Add unsafe switch hack.
7576 Override MarkForDuplicationCheck where it is appropriate.
7578 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7579 It says whether container allows members with the same name.
7581 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7582 Removed is_method parameter.
7584 2005-01-06 Duncan Mak <duncan@ximian.com>
7586 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7587 because the previous change led to incorrect reporting of CS1032
7588 ("Cannot define/undefine preprocessor symbols after first token in
7589 file"). Instead of using `tokens_seen' as the only flag that
7590 triggers CS1040, introduce `comments_seen'. This new flag is used
7591 to signify having seen comments on the current line, so it is
7592 unset after a newline.
7594 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7596 * doc.cs : When searching for a type, find nested type too.
7597 This fixes bug #71040.
7599 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7602 - Warn missing member comment on those classes which also does not
7603 have doc comments. Fixed bug #71041.
7604 - Don't warn missing doc comment on default constructor.
7607 2005-01-06 Duncan Mak <duncan@ximian.com>
7609 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7610 comments, set `tokens_seen' to true. This allows us to detect
7611 misplaced preprocessor directives (i.e. not at the beginning of
7612 the a line, nor after whitespaces). In that case, report error
7613 CS1040. This fixes bug #56460.
7615 * cs-parser.jay (interface_member_declaration): Add checks for
7616 IsExplicitImpl, and report CS0541 error if an interface member is
7617 defined as an explicit interface declaration.
7619 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7622 * class.cs (PropertyMethod): Set Parent field in ctors.
7623 (SetMethod.InternalParameters): Add unsafe switch hack.
7625 * decl.cs (MemberCore.Parent): Cannot be readonly.
7627 2005-01-06 Raja R Harinath <rharinath@novell.com>
7629 * decl.cs (DeclSpace.ResolveType): Remove.
7630 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7631 Merge in code from ...
7632 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7633 * class.cs, enum.cs: Update to changes.
7635 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7637 * anonymous.cs: Ensure that we init the scope of our parent if it
7638 has not been initialized yet.
7640 2004-12-30 Duncan Mak <duncan@ximian.com>
7642 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7643 if field.FieldBuilder is null. Fixes #70758.
7645 * convert.cs: Fixed some typos and updated some of the comments.
7646 (ImplicitStandardConversionExists):
7647 (TryImplicitIntConversion): If `target_type' is an interface and
7648 the type of `ic' implements this interface, return true or a new
7649 BoxedCast instead of null. This fixes #70468.
7651 2004-12-29 Duncan Mak <duncan@ximian.com>
7653 * expression.cs (Argument.Emit): Check that Expr is
7654 IMemoryLocation before casting to it, and report CS1510 otherwise.
7658 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7660 * statement.cs (Block.ThisVariable): remove the recursion here, to
7661 make the --profile more sane.
7663 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7665 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7666 assembly, by JB Evain.
7668 2004-12-17 Raja R Harinath <rharinath@novell.com>
7670 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7671 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7672 "parent" refers to enclosing type/class. "base" refers to superclass.
7674 2004-12-17 Raja R Harinath <rharinath@novell.com>
7676 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7677 Ensure that we only have GlobalAttributes.
7678 * attribute.cs (Attribute.Emit): Make non-virtual.
7679 (GlobalAttribute.Emit): Remove.
7680 (Attribute.Resolve): Make virtual.
7681 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7682 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7683 the argument. Don't create one.
7684 (Attribute.GetObsoleteAttribute): Likewise.
7685 (Attribute.GetClsCompliantAttributeValue): Likewise.
7686 * class.cs, decl.cs: Update to changes.
7688 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7690 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7692 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7694 * statement.cs (Foreach.Resolve): Add error 186 report.
7696 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7698 * expression.cs (Conditional.DoResolve): Add warning 429.
7700 * statement.cs (If.Resolve): Add warning 665.
7702 2004-12-16 Raja R Harinath <rharinath@novell.com>
7704 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7705 except when in the parser, and in GlobalAttribute.
7706 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7707 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7708 RootContext.Tree.Types.NamespaceEntry once work is done.
7709 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7710 and resets RootContext.Tree.Types.NamespaceEntry.
7712 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7714 * cs-parser.jay: Don't create a block for every variable.
7716 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7718 * location.cs: Provide extra information.
7720 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7721 variables from the captured environment, it is the ldarg_0.
7723 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7725 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7728 * class.cs: Changed warning level for 169 to avoid developer
7729 displeasure from warning flooding. It will be changed back when they
7730 fix most of current BCL warnings.
7732 * RootContext.cs: Pushed default WarningLevel to 3.
7734 * statement.cs: Removed unused variable.
7736 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7738 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7739 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7740 Add error 502 report.
7741 (StaticClass.DefineType): Add error 441 report.
7742 (Class.AllowedModifiersProp): New virtual property as temporary
7743 extension to AllowedModifiers.
7744 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7745 to share implementation with StaticClass and don't call virtual
7748 * driver.cs (MainDriver): Add error 1558 test.
7750 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7751 report. Moved error 36 test here.
7753 * statement.cs (Throw.Resolve): Add error 724 report.
7755 * typemanager.cs: Add out_attribute_type core type.
7757 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7759 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7761 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7763 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7766 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7768 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7769 Add error 3023 report.
7770 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7772 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7775 2004-12-12 John Luke <john.luke@gmail.com>
7777 * driver.cs (AddArgs): take -- into account when
7778 adding arguments, fixes bug 65710
7780 2004-12-12 Martin Baulig <martin@ximian.com>
7782 * expression.cs (Unary.TryReduceNegative): Added support for
7783 SByteConstant and ByteConstant.
7784 (Unary.Reduce): Check error values from TryReduceNegative().
7786 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7788 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7789 and report exception as error 182.
7791 2004-12-10 Raja R Harinath <rharinath@novell.com>
7793 * driver.cs (Main): Fix message when there are warnings.
7795 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7797 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7799 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7801 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7802 Reduced number of warnings.
7804 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7806 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7808 * driver.cs: Removed message.
7810 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7812 2004-12-08 <vargaz@freemail.hu>
7814 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7816 2004-12-08 Martin Baulig <martin@ximian.com>
7818 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7819 instead of a CS3002 for properties and indexer.
7821 2004-12-08 Martin Baulig <martin@ximian.com>
7823 * decl.cs (MemberName.ToString): Make this work again.
7825 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7827 * attribute.cs (Resolve): Add error 591 detection.
7829 * class.cs (FieldMember.Define): Add error 1547 detection.
7830 (Indexer.Define): Add error 620 detection.
7831 (Operator.Define): Add error 590 detection.
7833 * ecore.cs: Missing argument for error 79.
7835 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7838 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7841 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7844 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7846 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7847 Some operator comments were suppressed.
7848 * doc.cs : Implicit/explicit operator name in doc comments are like
7849 "op_Explicit(type)~returnType", so added suffix handling.
7851 2005-01-21 Alp Toker <alp@atoker.com>
7853 * cs-parser.jay: destructor_declaration's container is PartialContainer
7854 not Class when partial types are used, so use Kind prop instead of 'is'.
7856 2004-12-12 Martin Baulig <martin@ximian.com>
7858 * expression.cs (Unary.TryReduceNegative): Added support for
7859 SByteConstant and ByteConstant.
7860 (Unary.Reduce): Check error values from TryReduceNegative().
7862 2004-12-11 Martin Baulig <martin@ximian.com>
7864 * support.cs (ReflectionParameters.ParameterName): If we have a
7865 `gpd', call `ParameterName' on it.
7867 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7869 * pending.cs (PendingImplementation.DefineProxy): Call
7870 DefineParameter() for all of the MethodBuilder's arguments.
7872 2004-12-09 Martin Baulig <martin@ximian.com>
7874 * doc.cs (DocUtil): Make this a static class.
7876 2004-12-09 Martin Baulig <martin@ximian.com>
7878 * expression.cs (Invocation.InferType): Moved the type inference
7879 implementation into TypeManager.
7881 * generics.cs (TypeManager): Moved the type inference
7882 implementation here.
7884 2004-12-09 Martin Baulig <martin@ximian.com>
7886 * typemanager.cs (TypeManager): Make this a partial class.
7889 (TypeManager): Move the generics part of `TypeManager' here.
7891 2004-12-08 Martin Baulig <martin@ximian.com>
7893 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7894 instead of a CS3002 for properties and indexer. Added CS3024
7895 check for generic interfaces.
7897 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
7898 instances are not CLS-compliant.
7900 2004-12-08 Martin Baulig <martin@ximian.com>
7903 (void_pointer_expression): New rule for `void*', `void**' etc.
7904 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
7906 2004-12-08 Martin Baulig <martin@ximian.com>
7908 * expression.cs (Invocation.InferType): Removed the hack for
7909 MethodCore.MayUnify().
7911 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
7914 * class.cs (MethodCore.MayUnify): Use
7915 TypeManager.MayBecomeEqualGenericTypes().
7917 2004-12-08 Martin Baulig <martin@ximian.com>
7919 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
7920 parameter, box it. Fixes #69233.
7922 2004-12-08 Martin Baulig <martin@ximian.com>
7924 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
7925 have the ctor constraint. Fixes #68326.
7927 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7929 * cs-parser.jay : interface comment was not consumed because of
7930 extra opt_semicolon before doc handling.
7932 2004-12-03 Raja R Harinath <rharinath@novell.com>
7934 Fix test-327.cs, test-328.cs, and put in early infrastructure
7935 for eventually fixing #52697.
7936 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
7937 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
7939 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
7940 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
7941 (VerifyUsing, error246): Update.
7942 * rootcontext.cs (RootContext.NamespaceLookup): Just use
7943 'NamespaceEntry.LookupNamespaceOrType'.
7945 2004-12-07 Martin Baulig <martin@ximian.com>
7947 * driver.cs: Call it "BETA SOFTWARE" :-)
7949 2004-12-06 Raja R Harinath <rharinath@novell.com>
7951 Fix crash on cs0657-17.cs.
7952 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7953 Use RootContext.Tree.Types, not 'new RootTypes ()'.
7954 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
7955 the case where the NamespaceEntry gets overwritten.
7957 2004-12-06 Marek Safar <marek.safar@seznam.cz>
7959 Fixed #69195, #56821
7960 * ecore.cs (ResolveBoolean): Tiny refactoring.
7962 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
7963 of right expression resolving when left is false constant and
7964 operator is LogicalAnd OR true constant and operator is LogicalOr.
7966 * statement.cs (ResolveUnreachable): Always reports warning.
7968 2004-12-05 Miguel de Icaza <miguel@ximian.com>
7970 * class.cs: Distinguish between 1721 and 1722 (just a little help
7971 for the programmer).
7973 2004-12-03 Miguel de Icaza <miguel@ximian.com>
7975 * delegate.cs: Only allow this on new versions of the language.
7977 2004-12-02 Duncan Mak <duncan@ximian.com>
7979 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
7981 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
7982 here as a static method. Take an additional bool out parameter
7983 `must_do_cs1540_check' for signaling to InstanceResolve.
7984 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
7985 member field from PropertyExpr class and made it an argument of
7987 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
7988 check for MarshalByRefObject, and report CS0122 instead of CS1540.
7989 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
7990 and `remove_accessor' as well as InstanceResolve: report CS0122
7995 2004-12-07 Martin Baulig <martin@ximian.com>
7997 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
7998 and CS0692 where appropriate.
8000 2004-12-06 Martin Baulig <martin@ximian.com>
8002 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
8003 IsDuplicateImplementation() and improved it.
8005 * expression.cs (Invocation.InferTypeArguments): Added
8006 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
8007 and removed the "ref" modifier from `infered_types'.
8009 * decl.cs (MemberName.ToString): Removed the exception.
8011 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
8013 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
8014 comments are allowed.
8016 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8018 * delegate.cs: Add checks for subtypes in paramaters and return values
8019 in VerifyMethod () to add support for Covariance/Contravariance
8022 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8024 * report.cs: Remove extra closing parenthesis.
8026 * convert.cs (Error_CannotImplicitConversion): If the name of the
8027 types are the same, provide some extra information.
8029 2004-12-02 Marek Safar <marek.safar@seznam.cz>
8032 * attribute.cs (Resolve): Improved implementation of params
8033 attribute arguments.
8035 * support.cs (ParameterData): Add HasParams to be faster.
8037 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
8039 all things are for /doc support:
8041 * doc.cs: new file that supports XML documentation generation.
8042 * mcs.exe.sources: added doc.cs.
8044 Handle /doc command line option.
8045 Report error 2006 instead of 5 for missing file name for /doc.
8046 Generate XML documentation when required, after type resolution.
8048 Added support for picking up documentation (/// and /** ... */),
8049 including a new XmlCommentState enumeration.
8051 Added lines to fill Documentation element for field, constant,
8052 property, indexer, method, constructor, destructor, operator, event
8053 and class, struct, interface, delegate, enum.
8054 Added lines to warn incorrect comment.
8056 Added Documentation field (passed only when /doc was specified).
8058 Added DocComment, DocCommentHeader, GenerateDocComment() and
8059 OnGenerateDocComment() and some supporting private members for
8060 /doc feature to MemberCore.
8062 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
8064 Added overriden DocCommentHeader.
8066 Added overriden DocCommentHeader and GenerateDocComment().
8068 2004-12-01 Miguel de Icaza <miguel@ximian.com>
8070 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
8071 unwrapping the enumeration values, chain to
8072 DoConstantNumericPromotions again, so we can promote things to the
8073 fundamental types (takes care of enums that are bytes, sbytes).
8077 2004-12-01 Raja R Harinath <rharinath@novell.com>
8079 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
8080 Fix long-standing bug in type-lookup. Use FindType instead of
8081 LookupType when ec.ResolvingTypeTree.
8082 (Attribute.ResolveType, Attribute.Resolve)
8083 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
8085 (Attributes.Search): Remove internal version. Update.
8086 (Attributes.SearchMulti): Update.
8087 (Attributes.GetClsCompliantAttribute): Remove.
8088 (Attributes.GetIndexerNameAttribute): Remove.
8089 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
8090 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
8091 * class.cs (Indexer.Define): Likewise.
8093 2004-12-01 Marek Safar <marek.safar@seznam.cz>
8096 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
8097 MarshallByReference members access.
8099 * expression.cs: Use CheckMarshallByRefAccess;
8100 Better error CS0197 message.
8102 * report.cs: Print whole related error message.
8104 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8106 * class (GetClassBases): Better error 60 report.
8107 (EventProperty): Disabled warning 67 detection.
8109 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8112 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
8114 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
8117 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8120 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
8122 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
8124 2004-11-26 Miguel de Icaza <miguel@ximian.com>
8126 * attribute.cs (Attribute.Resolve): Refine error reporting and
8127 report a cs0117 if the identifier does not exist, to distinguish
8128 from 0617 which is a miss-use of the actual identifier.
8130 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
8131 between cs0070 and cs0079.
8133 * class.cs (MemberBase.DoDefine): When reporting a wrong
8134 accessibility level, we use MethodCore to compare instead of
8135 Method (this was a regression in some refactoring effort).
8137 So now we correctly report cs0056 again.
8139 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
8140 testing the target_type (which was known to be object_type) and
8141 not the source type (which is anonymous_method).
8143 Fixed reporting of error cs1660.
8145 * expression.cs (UserCast.Source): Expose the underlying cast.
8147 * statement.cs (Switch.SwitchGoverningType): Sort the list of
8148 allowed types to find a match to int32 first (most common).
8150 In addition, it ignores any ImplicitUserConversions that did an
8151 internal implicit conversion (as the switch statement allows only
8152 one integral conversion to exist).
8154 * class.cs (PartialContainer.Create): rename `name' to
8155 `member_name' for clarity. Then replace the string calls with a
8156 call to MemberName.GetPartialName, as now using
8157 MemberName.ToString is an error (this is due to the side effects
8158 it had, that were fixed in the past).
8160 This will restore the error reporting on a number of partial class
8161 errors that were missusing this (and getting an exception as a
8162 results, which is now just a plain textual warning, because
8163 yyparse debug output would crash otherwise).
8165 2004-11-26 Raja R Harinath <rharinath@novell.com>
8167 * Makefile (PROGRAM_INSTALL_DIR): Remove.
8169 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8171 * rootcontext.cs (LookupType): Make sure to cache lookups that
8172 don't give us a negative result. This saves about 5% of corlib
8175 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8177 * report.cs (AbstractMessage.Print): messages are sent to stderr
8179 * class.cs (TypeContainer.GetClassBases): It is an error to have a
8180 non-interface in the list of interfaces (at this point, either
8181 parent was properly set, or a base class is being listed in the
8182 interfaces section).
8184 This flags error 1722, and resolves the crash from bug 69259.
8186 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8188 * statement.cs (Using.EmitExpressionFinally): make this work right
8189 for valuetypes. Fixes 69926.
8191 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8193 * const.cs (Const.ChangeType): Cope with the "0 literal can be
8194 converted to an enum" here, before we try to change the underlying
8195 type. This code exists, but it is a different code path than the
8196 one used while encoding constants.
8198 (ImplicitReferenceConversionExists): In addition, resynchronized
8199 the code here, so it matches the same code in
8200 ImplicitReferenceConversionExists for the `from any class-type S
8201 to any interface-type T'.
8203 2004-11-25 Marek Safar <marek.safar@seznam.cz>
8205 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
8207 2004-11-24 Miguel de Icaza <miguel@ximian.com>
8209 * cs-parser.jay: Use verbosity accordingly.
8211 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8213 * expression.cs (Unary.ResolveOperator): Do not report warning;
8214 AddressOf reads from variable.
8216 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
8218 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8222 * attribute.cs (Attributable): Removed CheckTargets.
8223 (Attributes.Emit): Explicit attribute targets are tested here.
8225 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
8226 not enabled for interfaces.
8228 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
8229 (GetAssemblyName): Ouch next bug there.
8231 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8233 * expression.cs: Error 275 added.
8235 2004-11-23 Marek Safar <marek.safar@seznam.cz>
8237 Fix bug #69177 (Implemented decimal constant support)
8239 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
8240 (BinaryFold): Add DecimalConstant.
8242 * const.cs (Define): Decimal constant
8244 (ChangeType): Add decimal type handling.
8245 (LookupConstantValue): Don't set value for decimal type but
8246 emit DecimalConstantAttribute. Needed for constant optimization.
8248 * constant.cs (ToDecimal): New method.
8249 (ConvertToDecimal): New method.
8250 (IntConstant): Implemented ConvertToDecimal.
8251 (DecimalConstant.Emit): Emit optimized version for decimals in
8254 * expression.cs (ResolveOperator): Changed order of constant
8255 reduction to work correctly with native types which have
8256 overloaded operators.
8257 (ResolveMemberAccess): Extract constant value from attribute
8260 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
8262 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
8263 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
8264 (ChangeType): Decimal is special.
8265 (TypeToCoreType): Add decimal type.
8267 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8269 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8272 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8274 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8277 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8279 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8281 * pending.cs (PendingImplementation): Grab only interfaces.
8283 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8285 * statement.cs (ForeachHelperMethods): Add location member and
8286 error 202 detection.
8288 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8290 * expression.cs (DoResolveBase): Fixed wrong warning for out
8293 2004-12-04 Martin Baulig <martin@ximian.com>
8295 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8296 to check whether the conversion is ok.
8298 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8299 `Type.EmptyTypes' if we're not a generic TypeContainer.
8301 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8303 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8304 old bug: when converting from the null literal to a pointer,
8305 return an EmptyCast, not the NullLiteral.
8307 This fixes #69921, the recent null_type changes probably made this
8310 2004-12-03 Martin Baulig <martin@ximian.com>
8312 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8313 method as our child, call AnonymousMethod.Compatible() on it.
8315 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8317 * class.cs (FieldBase): Use an unused bit field from the field to
8318 encode the `has_offset' property from the FieldMember. This saves
8319 a couple of Ks on bootstrap compilation.
8321 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8322 method as our child, return the AnonymousMethod resolved
8325 * expression.cs (New.DoResolve): Allow return values from
8326 NewDelegate to also include AnonymousMethods.
8330 2004-11-29 Raja R Harinath <rharinath@novell.com>
8332 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8334 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8335 System.Runtime.InteropServices._Exception, since it's a base
8336 interface of the core type System.Exception in the net_2_0 profile.
8338 2004-11-27 Martin Baulig <martin@ximian.com>
8340 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8342 2004-11-26 Raja R Harinath <rharinath@novell.com>
8344 * Makefile: Convert to use executable.make.
8345 * gmcs.exe.sources: New.
8347 2004-11-25 Martin Baulig <martin@ximian.com>
8349 * expression.cs (Invocation.InferType): Added support for byref types.
8351 2004-11-25 Martin Baulig <martin@ximian.com>
8353 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8354 in TypeManager.TypeToCoreType().
8356 2004-11-25 Martin Baulig <martin@ximian.com>
8358 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8359 "Dispose" method from the `current_type'.
8360 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8361 DoDefineMembers() instead of using the MethodBuilder; this is
8362 required for generic iterators.
8364 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8366 2004-11-24 Martin Baulig <martin@ximian.com>
8368 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8370 2004-11-20 Martin Baulig <martin@ximian.com>
8372 * expression.cs (Invocation.InferType): Correctly infer generic
8373 instances; see gen-103.cs.
8374 (Invocation.InferTypeArguments): If a generic method doesn't have
8375 any unbound type parameters, we don't need to infer anything.
8377 2004-11-19 Raja R Harinath <rharinath@novell.com>
8379 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8381 2004-11-17 Raja R Harinath <rharinath@novell.com>
8383 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8384 (TypeHandle.GetMemberCache): New.
8385 (TypeHandle.TypeHandle): Update.
8386 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8387 (TypeManager.LookupParentInterfacesCache):
8388 Rename from LookupInterfaceCache. Optimize slightly.
8389 (TypeManager.MemberLookup_FindMembers): Update.
8390 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8392 (AddCacheContents): Rename from AddHashtable.
8393 * class.cs (TypeContainer.parent_container): Remove.
8394 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8395 (TypeContainer.DoDefineMembers): Don't initialize it.
8396 Update to name changes.
8398 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8400 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8401 that factors the code to check access modifiers on override.
8403 (PropertyBase): Use the code here.
8405 Patch from Lluis S'anchez, fixes bug #69361.
8407 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8409 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8410 routine that is used to report the use of a captured variable
8411 whose address has been taken.
8413 There are two checks: one when variables are being captured and
8414 the other check is when the address of a variable is taken.
8416 (because an anonymous methods might be resolved before *or* after
8417 the address has been taken) and
8419 * expression.cs (Conditional.DoResolve): Remove the special
8420 casing that Martin added to trueExpr and falseExpr being both
8421 NullLiteral. We get the right behavior now just by introducing
8422 the null_type into the compiler.
8424 * convert.cs (ExplicitConversion): Change the code to use
8425 null_type instead of testing `expr is NullLiteral'.
8426 (ImplicitConversionStandard): use null_type too.
8427 (ImplicitReferenceConversionExists): use null_type too.
8428 (ImplicitReferenceConversion): use null_type too.
8430 * literal.cs: The type of `NullLiteral' is now null_type instead
8432 (Resolve): Set the type here.
8434 * typemanager.cs: Introduce null_type.
8436 2004-11-18 Martin Baulig <martin@ximian.com>
8439 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8441 2004-11-18 Martin Baulig <martin@ximian.com>
8443 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8445 2004-11-18 Martin Baulig <martin@ximian.com>
8447 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8448 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8449 call ResolveConstructedType() on it to resolve it without checking
8451 (Constraints.ResolveTypes): Check them here.
8452 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8453 but don't check constraints.
8454 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8455 check constraints here.
8456 (ConstructedType.ResolveConstructedType): New public method. This
8457 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8458 resolve ourselves without checking constraints.
8460 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8462 2004-11-18 Martin Baulig <martin@ximian.com>
8465 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8467 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8469 2004-11-18 Martin Baulig <martin@ximian.com>
8471 * ecore.cs (TypeExpr.ResolveType): Removed.
8472 (Expression.ResolveAsTypeTerminal): We always return a fully
8473 resolved `TypeExpr', so we can just access its `Type'.
8475 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8477 2004-11-17 Martin Baulig <martin@ximian.com>
8479 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8480 sure we don't return any unresolved TypeExpr's.
8481 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8483 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8485 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8486 unresolved `ConstructedType's.
8488 2004-11-17 Martin Baulig <martin@ximian.com>
8490 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8492 2004-11-17 Martin Baulig <martin@ximian.com>
8495 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8497 * decl.cs (DeclSpace.ResolveType): Removed.
8498 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8500 2004-11-17 Martin Baulig <martin@ximian.com>
8502 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8503 direction, like FindMembers() does. Fixes #69546, testcase is in
8506 2004-11-16 Martin Baulig <martin@ximian.com>
8508 This is based on a patch from Marek Safar, see bug #69082.
8509 Fixes bugs #63705 and #67130.
8511 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8512 method; create a MemberCache for an interface type and cache the
8515 * decl.cs (IMemberContainer.ParentContainer): Removed.
8516 (IMemberContainer.ParentCache): New property.
8517 (MemberCache.SetupCacheForInterface): Removed.
8518 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8519 to create a cache for an interface's "parent".
8521 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8524 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8526 * statement.cs: Avoid adding bools to a hashtable.
8528 2004-11-15 Martin Baulig <martin@ximian.com>
8530 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8532 2004-11-11 Martin Baulig <martin@ximian.com>
8534 * typemanager.cs (TypeManager.GetMethodName): New method.
8536 * class.cs (MethodData.Define): Include the generic arity in the
8537 name of an explicit interface; also add it to the method name.
8539 * pending.cs (PendingImplementation.InterfaceMethod): The method
8540 name now includes the generic arity.
8542 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8544 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8545 calling an unsafe method from a safe location.
8547 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8550 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8552 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8554 * namespace.cs (VerifyUsing): use GetPartialName instead of
8557 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8559 * statement.cs (Return.Resolve): Fix regression in typo: if
8560 `in_exc', we have to request a NeedReturnLabel, this was a typo
8561 introduced in the anonymous method check-in. Fixes #69131.
8563 * Indexers were using the ShortName when defining themselves,
8564 causing a regression in the compiler bootstrap when applying the
8565 patch from 2004-11-02 (first part), now they use their full name
8566 and the bug is gone.
8568 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8570 * driver.cs: Strip the path from the names of embedded resources. Fixes
8573 2004-11-04 Raja R Harinath <rharinath@novell.com>
8575 Fix error message regression: cs0104-2.cs.
8576 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8577 (AliasEntry.Resolve): Update.
8578 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8580 (RootContext.LookupType): Update.
8582 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8584 * cs-parser.jay: Add support for handling accessor modifiers
8585 * class: Add support port accessor modifiers and error checking,
8586 define PropertyMethod.Define as virtual (not abstract anymore)
8587 * ecore.cs: Add checking for proeprties access with access modifiers
8588 * iterators.cs: Modify Accessor constructor call based in the modified
8590 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8592 * expression.cs (StringConcat): Handle being called twice,
8593 as when we have a concat in a field init with more than two
8596 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8598 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8599 special case explicit implementations, we should always produce
8600 the .property or .event declaration.
8602 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8603 since it will not return correct data if people use this
8604 unresolved in the presence of using statements (see test-313).
8606 * class.cs (MethodData.Define): If we are an explicit interface
8607 implementation, set the method name to the full name of the
8608 interface plus the name of the method.
8610 Notice that using the method.MethodName.GetFullName() does not
8611 work, as it will only contain the name as declared on the source
8612 file (it can be a shorthand in the presence of using statements)
8613 and not the fully qualifed type name, for example:
8617 class D : ICloneable {
8618 object ICloneable.Clone () {
8622 Would produce a method called `ICloneable.Clone' instead of
8623 `System.ICloneable.Clone'.
8625 * namespace.cs (Alias.Resolve): Use GetPartialName.
8627 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8629 * cs-parser.jay: Add error 1055 report.
8631 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8633 * assign.cs (Assign.DoResolve): Only do the transform of
8634 assignment into a New if the types are compatible, if not, fall
8635 through and let the implicit code deal with the errors and with
8636 the necessary conversions.
8638 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8640 * cs-parser.jay: Add error 1031 report.
8642 * cs-tokenizer.cs: Add location for error 1038.
8644 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8646 * cs-parser.jay: Add error 1016 report.
8648 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8650 * cs-parser.jay: Add errors 1575,1611 report.
8652 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8654 * cs-parser.jay: Add error 1001 report.
8656 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8659 * attribute.cs (GetMarshal): Add method argument for
8660 caller identification.
8662 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8663 agument for GetMarshal and RuntimeMissingSupport.
8665 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8667 * attribute.cs (ExtractSecurityPermissionSet): Removed
8668 TypeManager.code_access_permission_type.
8670 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8672 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8674 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8675 for obsolete use of a variable here. Fixes regression on errors
8676 cs0619-25 and cs0619-26.
8678 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8680 Fix #62358, implemented security attribute encoding.
8682 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8683 Tests permitted SecurityAction for assembly or other types.
8684 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8685 data from SecurityPermissionAttribute to PermisionSet class.
8687 * class.cs (ApplyAttributeBuilder): Added special handling
8688 for System.Security.Permissions.SecurityAttribute based types.
8690 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8691 special handling for System.Security.Permissions.SecurityAttribute
8694 * enum.cs (ApplyAttributeBuilder): Added special handling
8695 for System.Security.Permissions.SecurityAttribute based types.
8697 * parameter.cs (ApplyAttributeBuilder): Added special handling
8698 for System.Security.Permissions.SecurityAttribute based types.
8700 * rootcontext.cs: Next 2 core types.
8702 * typemanager.cs (TypeManager.security_permission_attr_type):
8703 Built in type for the SecurityPermission Attribute.
8704 (code_access_permission_type): Build in type.
8706 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8708 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8709 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8710 all of this information into
8711 EmitContext.EmitCapturedVariableInstance.
8713 * codegen.cs (EmitCapturedVariableInstance): move here the
8714 funcionality of emitting an ldarg.0 in the presence of a
8715 remapping. This centralizes the instance emit code.
8717 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8718 then emit a load of this: it means that we have reached the
8719 topmost ScopeInfo: the one that contains the pointer to the
8720 instance of the class hosting the anonymous method.
8722 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8723 captures to the topmost CaptureContext.
8725 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8727 * expression.cs (LocalVariableReference): Move the knowledge about
8728 the iterators into codegen's EmitCapturedVariableInstance.
8730 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8732 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8733 all code paths return a value from an anonymous method (it is the
8734 same as the 161 error, but for anonymous methods).
8736 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8738 The introduction of anonymous methods in the compiler changed
8739 various ways of doing things in the compiler. The most
8740 significant one is the hard split between the resolution phase
8741 and the emission phases of the compiler.
8743 For instance, routines that referenced local variables no
8744 longer can safely create temporary variables during the
8745 resolution phase: they must do so from the emission phase,
8746 since the variable might have been "captured", hence access to
8747 it can not be done with the local-variable operations from the runtime.
8751 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8752 is a toplevel block.
8754 (ToplevelBlock): A new kind of Block, these are the blocks that
8755 are created by the parser for all toplevel method bodies. These
8756 include methods, accessors and anonymous methods.
8758 These contain some extra information not found in regular blocks:
8759 A pointer to an optional CaptureContext (for tracking captured
8760 local variables and parameters). A pointer to the parent
8763 (Return.Resolve): Catch missmatches when returning a value from an
8764 anonymous method (error 1662).
8765 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8768 (Break.Resolve): ditto.
8770 (SwitchLabel): instead of defining the labels during the
8771 resolution phase, we now turned the public ILLabel and ILLabelCode
8772 labels into methods called GetILLabelCode() and GetILLabel() that
8773 only define the label during the Emit phase.
8775 (GotoCase): Track the SwitchLabel instead of the computed label
8776 (its contained therein). Emit the code by using
8777 SwitchLabel.GetILLabelCode ().
8779 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8780 whether the Local has been captured or not.
8782 (LocalInfo.IsCaptured): New property, used to tell whether the
8783 local has been captured.
8785 * anonymous.cs: Vastly updated to contain the anonymous method
8788 The main classes here are: CaptureContext which tracks any
8789 captured information for a toplevel block and ScopeInfo used to
8790 track the activation frames for various local variables.
8792 Each toplevel block has an optional capture context associated
8793 with it. When a method contains an anonymous method both the
8794 toplevel method and the anonymous method will create a capture
8795 context. When variables or parameters are captured, they are
8796 recorded on the CaptureContext that owns them, for example:
8800 MyDelegate d = delegate {
8805 Here `a' will be recorded as captured on the toplevel
8806 CapturedContext, the inner captured context will not have anything
8807 (it will only have data if local variables or parameters from it
8808 are captured in a nested anonymous method.
8810 The ScopeInfo is used to track the activation frames for local
8811 variables, for example:
8813 for (int i = 0; i < 10; i++)
8814 for (int j = 0; j < 10; j++){
8815 MyDelegate d = delegate {
8820 At runtime this captures a single captured variable `i', but it
8821 captures 10 different versions of the variable `j'. The variable
8822 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8823 recorded on a child.
8825 The toplevel ScopeInfo will also track information like the `this'
8826 pointer if instance variables were referenced (this is necessary
8827 as the anonymous method lives inside a nested class in the host
8828 type of the method).
8830 (AnonymousMethod): Expanded to track the Toplevel, implement
8831 `AnonymousMethod.Compatible' to tell whether an anonymous method
8832 can be converted to a target delegate type.
8834 The routine now also produces the anonymous method content
8836 (AnonymousDelegate): A helper class that derives from
8837 DelegateCreation, this is used to generate the code necessary to
8838 produce the delegate for the anonymous method that was created.
8840 * assign.cs: API adjustments for new changes in
8841 Convert.ImplicitStandardConversionExists.
8843 * class.cs: Adjustments to cope with the fact that now toplevel
8844 blocks are of type `ToplevelBlock'.
8846 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8847 insteda of standard blocks.
8849 Flag errors if params arguments are passed to anonymous methods.
8851 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8852 `CurrentAnonymousMethod' which points to the current Anonymous
8853 Method. The variable points to the AnonymousMethod class that
8854 holds the code being compiled. It is set in the new EmitContext
8855 created for the anonymous method.
8857 (EmitContext.Phase): Introduce a variable and an enumeration to
8858 assist in enforcing some rules about when and where we are allowed
8859 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8860 only one that enfonces this right now).
8862 (EmitContext.HaveCaptureInfo): new helper method that returns
8863 whether we have a CapturedContext initialized.
8865 (EmitContext.CaptureVariable): New method used to register that a
8866 LocalInfo must be flagged for capturing.
8868 (EmitContext.CapturedParameter): New method used to register that a
8869 parameters must be flagged for capturing.
8871 (EmitContext.CapturedField): New method used to register that a
8872 field must be flagged for capturing.
8874 (EmitContext.HaveCapturedVariables,
8875 EmitContext.HaveCapturedFields): Return whether there are captured
8876 variables or fields.
8878 (EmitContext.EmitMethodHostInstance): This is used to emit the
8879 instance for the anonymous method. The instance might be null
8880 (static methods), this (for anonymous methods that capture nothing
8881 and happen to live side-by-side with the current method body) or a
8882 more complicated expression if the method has a CaptureContext.
8884 (EmitContext.EmitTopBlock): Routine that drives the emission of
8885 code: it will first resolve the top block, then emit any metadata
8886 and then emit the code. The split is done so that we can extract
8887 any anonymous methods and flag any captured variables/parameters.
8889 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
8890 during this phase, the ILGenerator should not be used as labels
8891 and local variables declared here might not be accessible to any
8892 code that is part of an anonymous method.
8894 Exceptions to this include the temporary variables that are
8895 created by some statements internally for holding temporary
8898 (EmitContext.EmitMeta): New routine, in charge of emitting all the
8901 (EmitContext.TemporaryReturn): This method is typically called
8902 from the Emit phase, and its the only place where we allow the
8903 ReturnLabel to be defined other than the EmitMeta. The reason is
8904 that otherwise we would have to duplicate a lot of logic in the
8905 Resolve phases of various methods that today is on the Emit
8908 (EmitContext.NeedReturnLabel): This no longer creates the label,
8909 as the ILGenerator is not valid during the resolve phase.
8911 (EmitContext.EmitThis): Extended the knowledge in this class to
8912 work in anonymous methods in addition to iterators.
8914 (EmitContext.EmitCapturedVariableInstance): This emits whatever
8915 code is necessary on the stack to access the instance to a local
8916 variable (the variable will be accessed as a field).
8918 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
8919 EmitContext.EmitAddressOfParameter): Routines to support
8920 parameters (not completed at this point).
8922 Removals: Removed RemapLocal and RemapLocalLValue. We probably
8923 will also remove the parameters.
8925 * convert.cs (Convert): Define a `ConstantEC' which points to a
8926 null. This is just to prefity some code that uses
8927 ImplicitStandardConversion code and do not have an EmitContext
8930 The idea is to flag explicitly that at that point in time, it is
8931 known that the conversion will not trigger the delegate checking
8932 code in implicit conversions (which requires a valid
8935 Everywhere: pass new EmitContext parameter since
8936 ImplicitStandardConversionExists now requires it to check for
8937 anonymous method conversions.
8939 (Convert.ImplicitStandardConversionExists): If the type of an
8940 expression is the anonymous_method_type, and the type is a
8941 delegate, we invoke the AnonymousMethod.Compatible method to check
8942 whether an implicit conversion is possible.
8944 (Convert.ImplicitConversionStandard): Only do implicit method
8945 group conversions if the language level is not ISO_1.
8947 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
8948 MethodInfo for the Invoke method. used by Delegate and
8951 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
8952 method conversions if the target type is a delegate.
8954 Removed extra debugging nops.
8956 (LocalVariableReference): Turn the `local_info' into a public
8959 Add `prepared' field, the same hack used for FieldExprs to cope
8960 with composed assignments, as Local variables do not necessarily
8961 operate purely on the stack as they used to: they can be captured
8964 Add `temp' for a temporary result, like fields.
8966 Refactor DoResolve and DoResolveLValue into DoResolveBase.
8968 It now copes with Local variables that are captured and emits the
8969 proper instance variable to load it from a field in the captured
8972 (ParameterReference.DoResolveBase): During the resolve phase,
8973 capture parameters if we are in an anonymous method.
8975 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
8976 anonymous method, use the EmitContext helper routines to emit the
8977 parameter reference.
8979 * iterators.cs: Set RemapToProxy to true/false during the
8982 * parameters.cs (GetParameterByName): New helper method.
8984 * typemanager.cs (anonymous_method_type) a new type that
8985 represents an anonyous method. This is always an internal type,
8986 used as a fencepost to test against the anonymous-methodness of an
8989 2004-10-20 Marek Safar <marek.safar@seznam.cz>
8991 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
8993 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
8995 2004-11-10 Martin Baulig <martin@ximian.com>
8997 * expression.cs (Invocation.BetterFunction): If two methods have
8998 equal parameter types, but only one of them is generic, the
8999 non-generic one wins.
9000 (New.DoResolve): Don't set `is_struct' to false if we're a generic
9001 instance; just use `Type.IsValueType' to determine whether
9002 something is a struct or not.
9003 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
9004 so we can be called multiple times.
9006 2004-11-10 Martin Baulig <martin@ximian.com>
9008 * generic.cs (TypeParameter.DefineConstraints): New public method.
9009 (TypeParameter.CheckAccessLevel): Override this and return true.
9010 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
9011 override ResolveType() anymore.
9012 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
9014 2004-11-10 Martin Baulig <martin@ximian.com>
9016 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
9017 call DeclSpace.ResolveNestedType() on it.
9019 2004-11-10 Martin Baulig <martin@ximian.com>
9021 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
9022 non-null, call ParameterModifier() on it.
9024 2004-11-10 Martin Baulig <martin@ximian.com>
9027 (Iterators): Added `current_type' and `this_type' fields.
9028 (Iterators.DefineIterator): Create a new EmitContext and store it
9029 in `ec'; compute `this_type'.
9031 2004-11-10 Martin Baulig <martin@ximian.com>
9034 (TypeManager.IsPrivateAccessible): New public method.
9035 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
9037 2004-11-10 Martin Baulig <martin@ximian.com>
9039 * class.cs (TypeContainer.DefineType): Call
9040 TypeBuilder.DefineGenericParameters() before resolving the type
9042 (MethodData.parent_method): New protected field.
9043 (MethodData..ctor): Added `MethodInfo parent_method' argument.
9044 (MethodData.Define): Compute `parent_method'.
9047 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
9048 (MemberCore.GetClsCompliantAttributeValue): Likewise.
9049 (DeclSpace.ec): New protected field; store the EmitContext here.
9050 (DeclSpace.EmitContext): New public property.
9051 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
9052 (DeclSpace.ResolveNestedType): New public method.
9053 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
9054 (DeclSpace.NestedAccessible): Added `Type tb' argument.
9055 (DeclSpace.FamilyAccessible): Likewise.
9056 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
9057 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
9060 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
9063 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
9064 (Enum.Emit): Don't create a new EmitContext.
9066 2004-10-18 Martin Baulig <martin@ximian.com>
9068 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
9069 `Type' directly, but call ResolveType() on it.
9070 (Catch.Resolve): Likewise.
9071 (Foreach.Resolve): Likewise.
9073 2004-10-18 Martin Baulig <martin@ximian.com>
9075 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
9076 `Type' directly, but call ResolveType() on it.
9077 (Probe.DoResolve): Likewise.
9078 (ArrayCreation.LookupType): Likewise.
9079 (TypeOf.DoResolve): Likewise.
9080 (SizeOf.DoResolve): Likewise.
9082 2004-10-18 Raja R Harinath <rharinath@novell.com>
9084 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
9087 2004-10-17 John Luke <john.luke@gmail.com>
9089 * class.cs (Operator.GetSignatureForError): use CSharpName
9091 * parameter.cs (Parameter.GetSignatureForError): Returns
9092 correct name even if was not defined.
9094 2004-10-13 Raja R Harinath <rharinath@novell.com>
9097 * class.cs (TypeContainer.EmitContext): New property.
9098 (DefineNestedTypes): Create an emitcontext for each part.
9099 (MethodCore.DoDefineParameters): Use container's emitcontext.
9100 Pass type array to InternalParameters.
9101 (MemberBase.DoDefine): Use container's emitcontext.
9102 (FieldMember.Define): Likewise.
9103 (Event.Define): Likewise.
9104 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9105 Pass type array to InternalParameters.
9106 (SetIndexerMethod.GetParameterInfo): Likewise.
9107 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9108 * delegate.cs (Define): Pass emitcontext to
9109 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9110 array to InternalParameters.
9111 * expression.cs (ParameterReference.DoResolveBase): Pass
9112 emitcontext to GetParameterInfo.
9113 (ComposedCast.DoResolveAsTypeStep): Remove check on
9114 ec.ResolvingTypeTree.
9115 * parameter.cs (Parameter.Resolve): Change argument to
9116 EmitContext. Use ResolveAsTypeTerminal.
9117 (Parameter.GetSignature): Change argument to EmitContext.
9118 (Parameters.ComputeSignature): Likewise.
9119 (Parameters.ComputeParameterTypes): Likewise.
9120 (Parameters.GetParameterInfo): Likewise.
9121 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9122 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9123 * support.cs (InternalParameters..ctor): Remove variant that takes
9125 * typemanager.cs (system_intptr_expr): New.
9126 (InitExpressionTypes): Initialize it.
9128 2004-10-12 Chris Toshok <toshok@ximian.com>
9130 * cs-parser.jay: fix location for try_statement and catch_clause.
9132 2004-10-18 Martin Baulig <martin@ximian.com>
9134 * class.cs (FieldMember.Define): Don't access the TypeExpr's
9135 `Type' directly, but call ResolveType() on it.
9136 (MemberBase.DoDefine): Likewise.
9138 * expression.cs (New.DoResolve): Don't access the TypeExpr's
9139 `Type' directly, but call ResolveType() on it.
9140 (ComposedCast.DoResolveAsTypeStep): Likewise.
9142 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
9143 `Type' directly, but call ResolveType() on it.
9145 2004-10-17 John Luke <john.luke@gmail.com>
9147 * class.cs (Operator.GetSignatureForError): use CSharpName
9149 * parameter.cs (Parameter.GetSignatureForError): Returns
9150 correct name even if was not defined.
9152 2004-10-13 Raja R Harinath <rharinath@novell.com>
9155 * class.cs (TypeContainer.EmitContext): New property.
9156 (DefineNestedTypes): Create an emitcontext for each part.
9157 (MethodCore.DoDefineParameters): Use container's emitcontext.
9158 Pass type array to InternalParameters.
9159 (MemberBase.DoDefine): Use container's emitcontext.
9160 (FieldMember.Define): Likewise.
9161 (Event.Define): Likewise.
9162 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9163 Pass type array to InternalParameters.
9164 (SetIndexerMethod.GetParameterInfo): Likewise.
9165 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9166 * delegate.cs (Define): Pass emitcontext to
9167 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9168 array to InternalParameters.
9169 * expression.cs (ParameterReference.DoResolveBase): Pass
9170 emitcontext to GetParameterInfo.
9171 (ComposedCast.DoResolveAsTypeStep): Remove check on
9172 ec.ResolvingTypeTree.
9173 * parameter.cs (Parameter.Resolve): Change argument to
9174 EmitContext. Use ResolveAsTypeTerminal.
9175 (Parameter.GetSignature): Change argument to EmitContext.
9176 (Parameters.ComputeSignature): Likewise.
9177 (Parameters.ComputeParameterTypes): Likewise.
9178 (Parameters.GetParameterInfo): Likewise.
9179 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9180 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9181 * support.cs (InternalParameters..ctor): Remove variant that takes
9183 * typemanager.cs (system_intptr_expr): New.
9184 (InitExpressionTypes): Initialize it.
9186 2004-10-12 Chris Toshok <toshok@ximian.com>
9188 * cs-parser.jay: fix location for try_statement and catch_clause.
9190 2004-10-07 Raja R Harinath <rharinath@novell.com>
9192 More DeclSpace.ResolveType avoidance.
9193 * decl.cs (MemberCore.InUnsafe): New property.
9194 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
9195 with newly created EmitContext.
9196 (FieldMember.Define): Likewise.
9197 * delegate.cs (Delegate.Define): Likewise.
9198 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
9199 only if normal name-lookup fails.
9200 (TypeExpr.DoResolve): Enable error-checking.
9201 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
9202 (SizeOf.DoResolve): Likewise.
9203 (ComposedCast.DoResolveAsTypeStep): Likewise.
9204 (StackAlloc.DoResolve): Likewise.
9205 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
9206 (Block.Unsafe): New property.
9207 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
9208 (Unsafe): Set 'unsafe' flag of contained block.
9209 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
9210 (Fixed.Resolve): Likewise.
9211 (Catch.Resolve): Likewise.
9212 (Using.ResolveLocalVariableDecls): Likewise.
9213 (Foreach.Resolve): Likewise.
9215 2004-10-05 John Luke <john.luke@gmail.com>
9217 * cs-parser.jay: add location to error CS0175
9219 2004-10-04 Miguel de Icaza <miguel@ximian.com>
9221 * ecore.cs (Expression.Constantity): Add support for turning null
9224 * const.cs (Const.Define): Allow constants to be reference types
9225 as long as the value is Null.
9227 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
9229 * namespace.cs (NamespaceEntry.Using): No matter which warning
9230 level is set, check if this namespace name has already been added.
9232 2004-10-03 Ben Maurer <bmaurer@ximian.com>
9234 * expression.cs: reftype [!=]= null should always use br[true,false].
9237 2004-10-03 Marek Safar <marek.safar@seznam.cz>
9240 * attribute.cs: Enum conversion moved to
9241 GetAttributeArgumentExpression to be applied to the all
9244 2004-10-01 Raja R Harinath <rharinath@novell.com>
9246 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
9247 * class.c (TypeContainer.DefineType): Flag error if
9248 base types aren't accessible due to access permissions.
9249 * decl.cs (DeclSpace.ResolveType): Move logic to
9250 Expression.ResolveAsTypeTerminal.
9251 (DeclSpace.ResolveTypeExpr): Thin layer over
9252 Expression.ResolveAsTypeTerminal.
9253 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
9254 Refactor code into NestedAccess. Use it.
9255 (DeclSpace.NestedAccess): New.
9256 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
9257 argument to silence errors. Check access permissions.
9258 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
9259 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
9260 (Cast.DoResolve): Likewise.
9261 (New.DoResolve): Likewise.
9262 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
9263 (TypeOf.DoResolve): Likewise.
9265 * expression.cs (Invocation.BetterConversion): Return the Type of
9266 the better conversion. Implement section 14.4.2.3 more faithfully.
9267 (Invocation.BetterFunction): Make boolean. Make correspondence to
9268 section 14.4.2.2 explicit.
9269 (Invocation.OverloadResolve): Update.
9270 (Invocation): Remove is_base field.
9271 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9272 (Invocation.Emit): Likewise.
9274 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9276 * cs-parser.jay: Reverted 642 warning fix.
9278 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9281 * decl.cs (FindMemberWithSameName): Indexer can have more than
9284 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9286 * expression.cs (LocalVariableReference.DoResolveLValue):
9287 Do not report warning 219 for out values.
9288 (EmptyExpression.Null): New member to avoid extra allocations.
9290 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9292 * cs-parser.jay: Fix wrong warning 642 report.
9294 * cs-tokenizer.cs (CheckNextToken): New helper;
9295 Inspect next character if is same as expected.
9297 2004-09-23 Martin Baulig <martin@ximian.com>
9299 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9300 (Convert.ImplicitReferenceConversionExists): Likewise.
9302 2004-11-09 Raja R Harinath <rharinath@novell.com>
9304 * Makefile (DISTFILES): Comment out a few missing files.
9306 2004-10-29 Raja R Harinath <rharinath@novell.com>
9308 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9309 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9310 (gmcs.exe): Invoke bootstrap-libs.
9311 (clean-local): Clean the net_2_0_bootstrap profile too.
9312 (PROGRAM_INSTALL_DIR): New.
9313 (install-local): Use it.
9315 2004-10-13 Martin Baulig <martin@ximian.com>
9317 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9318 (TypeParameter.DefineType): If we're a method type parameter and
9319 that method is overriding something, "inflate" its constraints.
9321 2004-10-12 Martin Baulig <martin@ximian.com>
9323 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9324 and have type arguments, create and resolve a ConstructedType.
9326 2004-10-12 Martin Baulig <martin@ximian.com>
9328 * decl.cs (MemberCache.FindMemberToOverride): Use
9329 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9330 to compare the invocationType.
9332 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9333 When comparing two type parameters, only do the signature-only
9334 comparision for method type parameters.
9336 2004-10-11 Martin Baulig <martin@ximian.com>
9338 * report.cs: Don't make --fatal abort on warnings, we have
9339 -warnaserror for that.
9341 2004-10-11 Martin Baulig <martin@ximian.com>
9344 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9345 (TypeManager.IsEqual): Call ourself recursively instead of using
9348 2004-10-11 Martin Baulig <martin@ximian.com>
9350 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9351 on our own type parameters, not on the ones we inherit from a containing
9354 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9357 * generic.cs (TypeParameter.Define): We may only be called once.
9359 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9360 instead of TypeManager.IsEqual().
9362 2004-09-28 Martin Baulig <martin@ximian.com>
9365 (GenericConstraints.EffectiveBaseClass): New public property.
9366 (TypeParameter.GenericConstraints): New public property.
9367 (ConstructedType.CheckConstraints): Improved.
9369 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9370 (Convert.TypeParameterConversion): New private method; use this in
9371 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9372 for all conversions related to type parameters.
9374 2004-09-24 Martin Baulig <martin@ximian.com>
9376 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9377 type parameter conversions for type parameters which are known to
9380 2004-09-24 Martin Baulig <martin@ximian.com>
9382 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9383 `IsValueType' properties.
9385 * support.cs (ReflectionConstraints): Use
9386 Type.GetGenericParameterConstraints() instead of the old hack.
9388 2004-09-24 Martin Baulig <martin@ximian.com>
9390 * generic.cs (GenericConstraints): Moved here and made it an
9393 * support.cs (GenericConstraints): Moved to generic.cs.
9395 2004-09-24 Martin Baulig <martin@ximian.com>
9398 (ReflectionConstraints): Un-nested this class and made it public.
9401 (TypeManager.GetTypeParameterConstraints): New public method.
9402 (TypeManager.HasConstructorConstraint): Use the attributes.
9404 2004-09-24 Martin Baulig <martin@ximian.com>
9406 * support.cs (GenericConstraints): Replaced `HasConstructor',
9407 `IsReferenceType' and `IsValueType' with `Attributes'.
9408 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9409 method and made the .ctor public.
9411 * generic.cs (Constraints.Attributes): New public property.
9412 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9413 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9414 `IsValueType' -> `HasValueTypeConstraint'.
9416 2004-09-23 Martin Baulig <martin@ximian.com>
9418 * generic.cs (Constraints): Reflect latest runtime changes.
9420 2004-09-23 Martin Baulig <martin@ximian.com>
9422 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9423 (Convert.ImplicitReferenceConversionExists): Likewise.
9425 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9427 * class.cs (Operator.Define): Add error 448 and 559 report.
9429 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9431 * class.cs (MemberBase.IsTypePermitted): New protected
9432 method for checking error CS0610.
9434 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9436 * class.cs (TypeContainer.HasExplicitLayout): New property
9437 Returns whether container has StructLayout attribute set Explicit.
9438 (FieldMember): New abstract class for consts and fields.
9439 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9440 (Field): Reuse FieldMember.
9442 * const.cs (Const): Reuse FieldMember.
9444 * rootcontext.cs: EmitConstants call moved to class.
9446 2004-09-22 Martin Baulig <martin@ximian.com>
9448 Marek and me just fixed one of our oldest bugs: #28562 :-)
9450 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9452 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9453 we're an EnumConstant, just return that.
9454 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9455 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9456 to get the value which'll actually be written into the attribute.
9457 However, we have to use GetValue() to access the attribute's value
9460 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9462 * constant.cs (Constant.IsNegative): New abstract property
9465 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9466 (StackAlloc.DoResolve): Reused IsNegative.
9468 2004-09-22 Martin Baulig <martin@ximian.com>
9470 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9471 public method; like LookupTypeContainer, but also works for
9474 * report.cs (Report.SymbolRelatedToPreviousError): Use
9475 TypeManager.LookupGenericTypeContainer().
9477 2004-09-22 Martin Baulig <martin@ximian.com>
9479 Thanks to Peter Sestoft for this bug report.
9481 * expression.cs (Conditional): If both the `trueExpr' and the
9482 `falseExpr' is a NullLiteral, return a NullLiteral.
9484 2004-09-22 Martin Baulig <martin@ximian.com>
9486 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9487 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9488 for the "get_Current" call.
9490 2004-09-21 Martin Baulig <martin@ximian.com>
9492 * convert.cs (Convert.ImplicitReferenceConversion): When
9493 converting to an interface type, first check whether we're
9494 converting from a reference type.
9496 2004-09-14 Martin Baulig <martin@ximian.com>
9498 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9500 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9503 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9504 called and is obsolete then this member suppress message
9505 when call is inside next [Obsolete] method or type.
9507 * expression.cs: Use TestObsoleteMethodUsage member.
9509 2004-09-14 Martin Baulig <martin@ximian.com>
9511 * genericparser.cs: Removed.
9513 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9515 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9517 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9519 * attribute.cs (Attribute.Resolve): Add error 653 report.
9521 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9523 (Method.ApplyAttributeBuilder): Add error 685 report.
9524 (Operator.Define): Add error 564 report.
9526 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9528 * expression.cs (Invocation.DoResolve): Add error
9531 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9534 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9536 * class.cs (ConstructorInitializer.Resolve):
9537 Wrong error number (515->516).
9539 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9541 * class.cs (Indexer.Define): Add error 631 report.
9543 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9545 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9547 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9549 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9551 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9553 * cs-parser.jay: Added error CS0241 report.
9555 2004-09-10 Raja R Harinath <rharinath@novell.com>
9557 * cs-parser.jay (fixed_statement): Introduce a scope for the
9558 declaration in the 'fixed' statement.
9560 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9562 * cs-parser.jay: Added CS0230 error report.
9564 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9566 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9568 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9570 * expression.cs (Argument.Resolve): Added error CS0192 and
9573 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9575 C# 2.0 #pragma warning feature
9577 * cs-tokenizer.cs (PreProcessPragma): New method;
9578 Handles #pragma directive.
9580 * report.cs (WarningRegions): New class; Support
9581 class for #pragma warning directive. It tests whether
9582 warning is enabled for a given line.
9584 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9586 * const.cs: Add more descriptive error report, tahnks to
9589 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9591 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9593 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9595 * expression.cs: Apply patch from Ben: Remove dead code from
9596 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9597 as that code just threw an exception anwyays.
9599 * const.cs: Remove the call to the turnintoconstant, for details
9602 * literal.cs: The type of the null-literal is the null type; So
9603 we use a placeholder type (literal.cs:System.Null, defined here)
9606 * expression.cs (Conditional.DoResolve): Remove some old code that
9607 is no longer needed, conversions have been fixed.
9609 (ArrayCreationExpression.DoResolve): Return false if we fail to
9610 resolve the inner expression.
9612 2004-09-07 Raja R Harinath <rharinath@novell.com>
9615 * cs-parser.jay (delegate_declaration): Record a delegate
9616 declaration as a type declaration.
9617 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9619 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9621 * parameter.cs: Do not crash if the type can not be resolved.
9623 * expression.cs: Report errors with unsafe pointers, fixes #64896
9625 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9627 * expression.cs: Pointer arith always needs to do a conv.i
9628 if the operand is a long. fix 65320
9630 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9632 Fixed cs0619-37.cs, cs0619-38.cs
9634 * enum.cs (GetObsoleteAttribute): Removed.
9636 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9637 on Enum member is double staged. The first is tested member
9640 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9642 Fixed #56986, #63631, #65231
9644 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9645 adds member to name container.
9646 (TypeContainer.AddToTypeContainer): New method, adds type to
9648 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9649 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9650 AddOperator): Simplified by reusing AddToMemberContainer.
9651 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9653 (Method.CheckForDuplications): Fixed implementation to test all
9655 (MemberBase): Detection whether member is explicit interface
9656 implementation is now in constructor.
9657 (MemberBase.UpdateMemberName): Handles IndexerName.
9658 (Accessor): Changed to keep also location information.
9659 (AbstractPropertyEventMethod): Is derived from MemberCore.
9660 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9661 will be emited or not.
9662 (PropertyBase.AreAccessorsDuplicateImplementation):
9663 Tests whether accessors are not in collision with some method.
9664 (Operator): Is derived from MethodCore to simplify common
9667 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9669 (DeclSpace.AddToContainer): Adds the member to defined_names
9670 table. It tests for duplications and enclosing name conflicts.
9672 * enum.cs (EnumMember): Clean up to reuse the base structures
9674 2004-09-03 Martin Baulig <martin@ximian.com>
9676 Merged latest changes into gmcs. Please keep this comment in
9677 here, it makes it easier for me to see what changed in MCS since
9678 the last time I merged.
9680 2004-09-03 Martin Baulig <martin@ximian.com>
9682 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9683 into TypeContainer, to make partial classes work again.
9685 2004-09-03 Martin Baulig <martin@ximian.com>
9687 * rootcontext.cs (RootContext.V2): Removed.
9689 2004-03-23 Martin Baulig <martin@ximian.com>
9691 * expression.cs (Invocation.OverloadResolve): Added `bool
9692 may_fail' argument and use it instead of the Location.IsNull() hack.
9694 2004-09-09 Martin Baulig <martin@ximian.com>
9696 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9698 2004-09-09 Martin Baulig <martin@ximian.com>
9700 * generic.cs (TypeParameter.DefineType): Added support for
9701 explicit interface methods.
9703 2004-09-09 Martin Baulig <martin@ximian.com>
9705 * README.Changes: New document. Started to list important changes
9706 between MCS and GMCS here.
9708 2004-09-08 Martin Baulig <martin@ximian.com>
9711 (TypeContainer.CheckRecursiveDefinition): New protected method.
9712 (TypeContainer.DefineType): Move the CS0146 check into
9713 CheckRecursiveDefinition().
9715 2004-09-06 Martin Baulig <martin@ximian.com>
9717 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9718 types for the constructor constraint.
9720 2004-09-03 Martin Baulig <martin@ximian.com>
9722 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9723 into TypeContainer, to make partial classes work again.
9725 2004-09-03 Martin Baulig <martin@ximian.com>
9727 * rootcontext.cs (RootContext.V2): Removed.
9729 2004-03-23 Martin Baulig <martin@ximian.com>
9731 * expression.cs (Invocation.OverloadResolve): Added `bool
9732 may_fail' argument and use it instead of the Location.IsNull() hack.
9734 2004-09-03 Martin Baulig <martin@ximian.com>
9736 Merged latest changes into gmcs. Please keep this comment in
9737 here, it makes it easier for me to see what changed in MCS since
9738 the last time I merged.
9740 2004-09-03 Raja R Harinath <rharinath@novell.com>
9743 * expression.cs (BetterConversion): Don't allow either conversion
9744 to be null. Remove redundant implicit conversion test when 'q ==
9745 null' -- when this function is invoked, we already know that the
9746 implicit conversion exists.
9747 (BetterFunction): Assume that 'best' is non-null. Remove
9748 redundant reimplementation of IsApplicable when 'best' is null.
9749 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9750 number of arguments.
9751 (IsAncestralType): Extract from OverloadResolve.
9752 (OverloadResolve): Make robust to the MethodGroupExpr being
9753 unsorted. Implement all the logic of Section 14.5.5.1, and
9754 support overloading of methods from multiple applicable types.
9755 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9757 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9758 (RealError, Warning): Append type of report to related symbol.
9760 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9762 * enum.cs: Fixed CLS-Compliance checks for enum members.
9763 Error tests cs3008-8.cs, cs3014-8.cs
9765 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9767 Fixed bug #62342, #63102
9768 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9769 like ImplementMethod.
9771 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9773 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9776 2004-09-02 Martin Baulig <martin@ximian.com>
9778 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9779 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9782 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9784 C# 2.0 Static classes implemented
9786 * class.cs (TypeContainer): instance_constructors,
9787 initialized_fields, initialized_static_fields,
9788 default_constructor, base_inteface_types are protected to be
9789 accessible from StaticClass.
9790 (TypeContainer.DefineDefaultConstructor): New virtual method
9791 for custom default constructor generating
9792 (StaticClass): New class to handle "Static classes" feature.
9794 * cs-parser.jay: Handle static keyword on class like instance
9797 * driver.cs: Added "/langversion" command line switch with two
9798 options (iso-1, default).
9800 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9802 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9804 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9806 * delegate.cs: Style.
9808 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9810 * delegate.cs: Add seperate instance expr field for miguel.
9812 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9814 * PointerArithmetic (Resolve): make sure we are not doing
9815 pointer arith on void*. Also, make sure we are resolved
9816 by not setting eclass until resolve.
9818 All callers: Make sure that PointerArithmetic gets resolved.
9820 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9822 * ArrayCreation (LookupType): If the type does not resolve
9823 to an array, give an error.
9825 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9827 * statement.cs (Try.Resolve): Fixed bug #64222
9829 2004-08-27 Martin Baulig <martin@ximian.com>
9832 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9835 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9837 * ecore.cs (Constantify): Get underlying type via
9838 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9839 Windows in special cases.
9841 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9843 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9844 for obtaining also private methods.
9845 (GetRemoveMethod): Used GetRemoveMethod (true)
9846 for obtaining also private methods.
9848 2004-09-02 Martin Baulig <martin@ximian.com>
9850 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9851 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9854 2004-08-27 Martin Baulig <martin@ximian.com>
9857 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9860 2004-08-25 Martin Baulig <martin@ximian.com>
9862 * support.cs (ReflectionParameters..ctor): If this is a generic
9863 method, retrieve and store its type parameters.
9864 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9865 (ReflectionParameters.GenericConstraints): The argument specifies
9866 the type parameter, not the method parameter.
9867 (InternalParameters.GenericConstraints): Likewise.
9869 * generic.cs (TypeParameter.DefineType): Correctly handle
9870 constraints wrt. generic methods in interfaces and their
9873 2004-08-24 Martin Baulig <martin@ximian.com>
9875 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9876 (Constraints.IsSubclassOf): New internal method.
9878 * typemanager.cs (TypeManager.FindMembers): Added special support
9879 for GenericTypeParameterBuilder's.
9880 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
9883 2004-08-24 Martin Baulig <martin@ximian.com>
9886 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
9887 this for accessibility checks.
9888 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
9889 IsNestedFamilyAccessible.
9890 (TypeManager.IsSubclassOf): New method, do what the name actually
9893 2004-08-24 Martin Baulig <martin@ximian.com>
9895 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
9896 as a SimpleName, include the generic arity.
9898 2004-08-24 Martin Baulig <martin@ximian.com>
9900 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
9901 MethodAttributes.HideBySig for operators.
9903 2004-08-23 Martin Baulig <martin@ximian.com>
9905 Back to the old error reporting system :-)
9907 * report.cs (Message): Removed.
9908 (Report.MessageData, ErrorData, WarningData): Removed.
9909 (Report.Error, Warning): Back to the old system.
9911 2004-08-23 Martin Baulig <martin@ximian.com>
9913 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
9915 * class.cs (TypeContainer.ParentContainer): New public virtual
9916 method; replaces the explicit interface implementation.
9917 (ClassPart.ParentContainer): Override.
9919 2004-08-23 Martin Baulig <martin@ximian.com>
9921 * statement.cs (Switch): Added support for constant switches; see
9922 #59428 or test-285.cs.
9924 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9927 * statement.cs (GetEnumeratorFilter): Removed useless
9928 logic because C# specs is strict. GetEnumerator must be
9931 2004-08-22 Martin Baulig <martin@ximian.com>
9933 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9934 a switch and may break, reset the barrier. Fixes #59867.
9936 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9938 CLS-Compliance speed up (~5% for corlib)
9940 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
9941 New method. Tests container for CLS-Compliant names
9943 * class.cs (TypeContainer.VerifyClsName): New method.
9944 Checks whether container name is CLS Compliant.
9945 (Constructor): Implements IMethodData.
9947 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
9948 low-case table for CLS Compliance test.
9949 (MemberCache.VerifyClsParameterConflict): New method.
9950 Checks method parameters for CS3006 error.
9952 * enum.cs (EnumMember): Is derived from MemberCore.
9953 (Enum.VerifyClsName): Optimized for better performance.
9955 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9957 * report.cs: Renamed Error_T to Error and changed all
9960 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9962 * class.cs (TypeContainer.IndexerArrayList): New inner class
9963 container for indexers.
9964 (TypeContainer.DefaultIndexerName): New constant for default
9965 indexer name. Replaced all "Item" with this constant.
9966 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
9968 * typemanager.cs (TypeManager.default_member_ctor): Cache here
9969 DefaultMemberAttribute constructor.
9971 2004-08-05 Martin Baulig <martin@ximian.com>
9973 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9976 2004-08-05 Marek Safar <marek.safar@seznam.cz>
9978 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
9979 multi platforms problem.
9981 * compiler.csproj: Included shared files.
9983 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9985 Fix bug 60333, 55971 in the more general way
9986 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9987 Added arg_type argument for constant conversion.
9988 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
9990 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9993 * class.cs (TypeContainer ): New inner classes MethodArrayList,
9994 OperatorArrayList, MethodCoreArrayList for typecontainer
9995 containers. Changed class member types to these new types.
9996 (MethodArrayList.DefineMembers): Added test for CS0659.
9998 2004-08-04 Miguel de Icaza <miguel@ximian.com>
10000 * cfold.cs: Synchronize the folding with the code in expression.cs
10001 Binary.DoNumericPromotions for uint operands.
10003 * attribute.cs: Revert patch from Raja, it introduced a regression
10004 while building Blam-1.2.1 (hard to isolate a test case).
10006 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10010 (TypeContainer.Define): Renamed to DefineContainerMembers because of
10012 (MethodCore.parent_method): New member. The method we're overriding
10013 if this is an override method.
10014 (MethodCore.CheckBase): Moved from Method class and made common.
10015 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
10017 (MethodCore.CheckForDuplications): New abstract method. For custom
10018 member duplication search in a container
10019 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
10020 method and its return type.
10021 (Event.conflict_symbol): New member. Symbol with same name in the
10025 (MemberCache.FindMemberWithSameName): New method. The method
10026 is looking for conflict with inherited symbols.
10028 2004-08-04 Martin Baulig <martin@ximian.com>
10030 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10032 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10034 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10036 * report.cs (Message): New enum for better error, warning reference in
10038 (MessageData): New inner abstract class. It generally handles printing of
10039 error and warning messages.
10040 Removed unused Error, Warning, Message methods.
10042 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10044 Fix for cs0592-8.cs test
10046 (Attributable.ValidAttributeTargets): Made public.
10047 (Attribute.ExplicitTarget): New member for explicit target value.
10048 (Attribute.CheckTargets): Now we translate explicit attribute
10049 target to Target here.
10051 2004-08-03 Ben Maurer <bmaurer@ximian.com>
10053 * ecore.cs (MethodGroupExpr): new IsBase property.
10055 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
10057 * delegate.cs (DelegateCreation): store a MethodGroupExpr
10058 rather than an instance expr.
10060 (DelegateCreation.Emit): Use the method group rather than
10061 the instance expression. Also, if you have base.Foo as the
10062 method for a delegate, make sure to emit ldftn, not ldftnvirt.
10064 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
10066 (NewDelegate.DoResolve): Only check for the existance of Invoke
10067 if the method is going to be needed. Use MethodGroupExpr.
10069 (NewDelegate.Emit): Remove, DelegateCreation implements this.
10071 * expression.cs: For pointer arith., make sure to use
10072 the size of the type, not the size of the pointer to
10075 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10078 * class.cs (Class): Added error CS0502 test.
10080 2004-08-03 John Luke <jluke@cfl.rr.com>
10081 Raja R Harinath <rharinath@novell.com>
10084 * attribute.cs (Attribute.complained_before): New flag.
10085 (Attribute.ResolveType, Attribute.Resolve),
10086 (Attribute.DefinePInvokeMethod): Set it.
10087 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
10089 2004-08-03 Martin Baulig <martin@ximian.com>
10091 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10092 use a user-defined operator; we still need to do numeric
10093 promotions in case one argument is a builtin type and the other
10094 one has an implicit conversion to that type. Fixes #62322.
10096 2004-08-18 Martin Baulig <martin@ximian.com>
10098 * class.cs (Method.Define): Use the correct method name when
10099 creating the MethodBuilder for a generic method.
10101 2004-08-17 Martin Baulig <martin@ximian.com>
10103 * generic.cs (Constraints): Support type parameter constraints.
10105 2004-08-16 Martin Baulig <martin@ximian.com>
10107 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
10108 (Token.GENERIC_DIMENSION): New token; this is returned if we
10109 encounter an unbound generic type in a typeof() expression.
10111 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
10112 this token is only generated while parsing a typeof() expression.
10113 (typeof_expression): Removed the old unbound_type hack.
10115 * generic.cs (TypeArguments.IsUnbound): New public property.
10117 * decl.cs (MemberName): Added support for unbound types.
10119 2004-08-14 Martin Baulig <martin@ximian.com>
10122 (TypeManager.IsEqualGenericInstance): New static method.
10123 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
10124 just used to check accessibility, so follow the rules of 26.1.6.
10126 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
10127 ConstructedType instead of a TypeExpression if we have type arguments.
10129 * cs-parser.jay (typeof_expression): Support unbound generic types.
10131 * ecore.cs (UnboundTypeExpression): New public class.
10133 2004-08-12 Martin Baulig <martin@ximian.com>
10135 * typemanager.cs (TypeManager.IsNestedChildOf): Use
10136 TypeManager.IsEqual() rather than `=='.
10138 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
10139 generic instances as well.
10141 2004-08-12 Martin Baulig <martin@ximian.com>
10143 * expression.cs (Invocation.InferType): We can only infer method
10144 type parameters. Fixes #62647.
10146 2004-08-11 Martin Baulig <martin@ximian.com>
10148 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
10149 before resolving the base classes.
10151 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10153 * Makefile: install .mdb file too.
10155 2004-08-05 Martin Baulig <martin@ximian.com>
10157 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
10158 initializer, the current type is just the TypeBuilder, not the
10159 instantiated generic type.
10160 (FieldExpr.IsFieldInitializer): New public property.
10162 2004-08-04 Martin Baulig <martin@ximian.com>
10164 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10166 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10168 2004-08-03 Martin Baulig <martin@ximian.com>
10170 * class.cs (MethodData.Define): If we're an explicit
10171 implementation, remove the generic arity from the type name.
10173 2004-08-03 Martin Baulig <martin@ximian.com>
10175 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10176 use a user-defined operator; we still need to do numeric
10177 promotions in case one argument is a builtin type and the other
10178 one has an implicit conversion to that type. Fixes #62322.
10180 2004-08-02 Martin Baulig <martin@ximian.com>
10182 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
10183 `TypeExpr[]' array.
10184 (TypeContainer.GetClassBases): Return the unexpanded list of
10185 interfaces; we expand them later.
10186 (TypeContainer.DefineType): After creating the TypeBuilder, call
10187 TypeManager.ExpandInterfaces() to get an expanded and resolved
10188 list of interfaces.
10190 * ecore.cs (TypeExpr.GetInterfaces): Removed
10192 * generics.cs (Constraints.InterfaceConstraints): Remove.
10193 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
10194 register the interface constraints.
10197 (TypeManager.AddUserType): Removed the `ifaces' argument.
10198 (TypeManager.AddTypeParameter): Likewise.
10199 (TypeManager.AddUserInterface): Removed, was unused.
10200 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
10201 `TypeExpr[]' array for the interfaces.
10202 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
10203 has been defined, returns a list of the resolved interfaces types.
10204 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
10205 (TypeManager.GetExplicitInterfaces): Likewise.
10207 2004-08-02 Martin Baulig <martin@ximian.com>
10209 * expression.cs (Invocation.EmitCall): If we're invoking a method
10210 on a type parameter, use the new `Constrained' prefix opcode.
10212 2004-08-02 Martin Baulig <martin@ximian.com>
10214 * statement.cs (LocalInfo.Flags): Added `IsThis'.
10215 (LocalInfo.IsThis): New public property.
10216 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
10218 2004-08-01 Martin Baulig <martin@ximian.com>
10220 * class.cs (TypeContainer.GetClassBases): Don't set the default
10221 here since we may get called from GetPartialBases().
10222 (TypeContainer.DefineType): If GetClassBases() didn't return a
10223 parent, use the default one.
10225 2004-07-30 Martin Baulig <martin@ximian.com>
10227 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
10229 * class.cs (SourceMethod): New public class, derive from the
10230 symbol writer's ISourceMethod.
10231 (Method): Use the new symbol writer API.
10233 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
10234 as argument and use the new symbol writer.
10237 (SourceFile): Implement the symbol writer's ISourceFile.
10238 (Location.SymbolDocument): Removed.
10239 (Location.SourceFile): New public property.
10241 * symbolwriter.cs: Use the new symbol writer API.
10243 2004-07-30 Raja R Harinath <rharinath@novell.com>
10245 * Makefile (install-local): Remove. Functionality moved to
10248 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
10250 * Makefile: Install mcs.exe.config file together with mcs.exe.
10251 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
10252 correct runtime version.
10254 2004-07-25 Martin Baulig <martin@ximian.com>
10257 (TypeContainer.RegisterOrder): Removed, this was unused.
10258 (TypeContainer, interface_order): Removed.
10259 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
10260 TypeContainer as argument since we can also be called with a
10261 `PartialContainer' for a partial class/struct/interface.
10262 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
10263 of checking whether we're an `Interface' - we could be a
10264 `PartialContainer'.
10265 (PartialContainer.Register): Override; call
10266 AddClass()/AddStruct()/AddInterface() on our parent.
10268 * cs-parser.jay (interface_member_declaration): Add things to the
10269 `current_container', not the `current_class'.
10271 * rootcontext.cs (RegisterOrder): The overloaded version which
10272 takes an `Interface' was unused, removed.
10274 * typemanager.cs (TypeManager.LookupInterface): Return a
10275 `TypeContainer', not an `Interface'.
10276 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10277 contain a `PartialContainer' for an interface, so check it's
10278 `Kind' to figure out what it is.
10280 2004-07-25 Martin Baulig <martin@ximian.com>
10282 * class.cs (Class.DefaultTypeAttributes): New public constant.
10283 (Struct.DefaultTypeAttributes): Likewise.
10284 (Interface.DefaultTypeAttributes): Likewise.
10285 (PartialContainer.TypeAttr): Override this and add the
10286 DefaultTypeAttributes.
10288 2004-07-25 Martin Baulig <martin@ximian.com>
10290 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10291 we can just use the `Parent' field instead.
10293 2004-07-25 Martin Baulig <martin@ximian.com>
10295 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10297 2004-07-25 Martin Baulig <martin@ximian.com>
10299 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10300 our parts before defining any methods.
10301 (TypeContainer.VerifyImplements): Make this virtual.
10302 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10303 on our PartialContainer.
10305 2004-07-25 Martin Baulig <martin@ximian.com>
10307 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10309 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10310 argument, we can just use the `Parent' field instead.
10313 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10314 (MemberBase.DoDefine): Likewise.
10316 2004-07-24 Martin Baulig <martin@ximian.com>
10318 * decl.cs (MemberCore.Parent): New public field.
10319 (DeclSpace.Parent): Moved to MemberCore.
10321 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10322 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10324 (FieldBase, Field, Operator): Likewise.
10325 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10326 (EventField, Event): Likewise.
10328 2004-07-23 Martin Baulig <martin@ximian.com>
10330 * class.cs (PartialContainer): New public class.
10331 (ClassPart): New public class.
10332 (TypeContainer): Added support for partial classes.
10333 (TypeContainer.GetClassBases): Splitted some of the functionality
10334 out into GetNormalBases() and GetPartialBases().
10336 * cs-tokenizer.cs (Token.PARTIAL): New token.
10337 (Tokenizer.consume_identifier): Added some hacks to recognize
10338 `partial', but only if it's immediately followed by `class',
10339 `struct' or `interface'.
10341 * cs-parser.jay: Added support for partial clases.
10343 2004-07-23 Martin Baulig <martin@ximian.com>
10345 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10346 a `DeclSpace' and also made it readonly.
10347 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10348 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10349 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10351 * cs-parser.jay: Pass the `current_class', not the
10352 `current_container' (at the moment, this is still the same thing)
10353 to a new Method, Property, Event, Indexer or Constructor.
10355 2004-07-23 Martin Baulig <martin@ximian.com>
10357 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10358 and removed the `current_interface' one.
10359 (struct_declaration, class_declaration, interface_declaration):
10360 Set `current_class' to the newly created class/struct/interface;
10361 set their `Bases' and call Register() before parsing their body.
10363 2004-07-23 Martin Baulig <martin@ximian.com>
10365 * class.cs (Kind): New public enum.
10366 (TypeContainer): Made this class abstract.
10367 (TypeContainer.Kind): New public readonly field.
10368 (TypeContainer.CheckDef): New public method; moved here from
10370 (TypeContainer.Register): New public abstract method.
10371 (TypeContainer.GetPendingImplementations): New public abstract
10373 (TypeContainer.GetClassBases): Removed the `is_class' and
10374 `is_iface' parameters.
10375 (TypeContainer.DefineNestedTypes): Formerly known as
10377 (ClassOrStruct): Made this class abstract.
10379 * tree.cs (RootTypes): New public type.
10381 2004-07-20 Martin Baulig <martin@ximian.com>
10383 * tree.cs (Tree.RecordNamespace): Removed.
10384 (Tree.Namespaces): Removed.
10386 * rootcontext.cs (RootContext.IsNamespace): Removed.
10388 * cs-parser.jay (namespace_declaration): Just create a new
10389 NamespaceEntry here.
10391 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10393 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10394 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10395 entry to make sure it runs in the correct runtime version.
10397 2004-07-18 Martin Baulig <martin@ximian.com>
10399 * generic.cs (ConstructedType.CheckConstraints): Improved
10400 constraints checking.
10402 2004-07-18 Martin Baulig <martin@ximian.com>
10404 * expression.cs (Invocation.BetterMethod): Call
10405 TypeManager.TypeToCoreType() on all types and removed my previous
10406 hack; we're already doig the right thing here.
10408 2004-07-17 Martin Baulig <martin@ximian.com>
10410 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10412 2004-07-16 Martin Baulig <martin@ximian.com>
10414 * iterators.cs: Added generics support.
10416 2004-07-16 Martin Baulig <martin@ximian.com>
10418 * iterators.cs: Rewrote this. We're now using one single Proxy
10419 class for both the IEnumerable and the IEnumerator interface and
10420 `Iterator' derives from Class so we can use the high-level API.
10422 * class.cs (TypeContainer.AddIterator): New method.
10423 (TypeContainer.DoDefineType): New protected virtual method, which
10424 is called from DefineType().
10425 (TypeContainer.DoDefineMembers): Call DefineType() and
10426 DefineMembers() on all our iterators.
10427 (TypeContainer.Emit): Call Emit() on all our iterators.
10428 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10430 * codegen.cs (EmitContext.CurrentIterator): New public field.
10432 2004-07-15 Martin Baulig <martin@ximian.com>
10435 (TypeManager.not_supported_exception_type): New type.
10437 2004-07-14 Martin Baulig <martin@ximian.com>
10440 (TypeManager.generic_ienumerable_type): New type.
10441 (TypeManager.generic_ienumerator_type): New type.
10444 (RootContext.interfaces_first_stage): Added
10445 "System.Collections.Generic.IEnumerator`1" and
10446 "System.Collections.Generic.IEnumerable`1".
10448 2004-07-14 Martin Baulig <martin@ximian.com>
10450 * iterators.cs: Use real error numbers.
10452 2004-07-14 Martin Baulig <martin@ximian.com>
10454 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10455 requires this to be a System.Collection.IEnumerable and not a
10456 class implementing that interface.
10457 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10459 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10461 * class.cs: Fixed previous fix, it broke some error tests.
10463 2004-07-12 Martin Baulig <martin@ximian.com>
10465 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10468 2004-07-14 Martin Baulig <martin@ximian.com>
10470 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10471 an exclamation mark (!) for the generic arity to reflect the
10472 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10474 2004-07-13 Martin Baulig <martin@ximian.com>
10476 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10477 specifiers being part of a type argument.
10479 2004-07-13 Martin Baulig <martin@ximian.com>
10481 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10482 name for generic types.
10484 2004-07-13 Martin Baulig <martin@ximian.com>
10486 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10489 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10491 * assign.cs (LocalTemporary): Add new argument: is_address,If
10492 `is_address' is true, then the value that we store is the address
10493 to the real value, and not the value itself.
10495 * ecore.cs (PropertyExpr): use the new local temporary
10496 stuff to allow us to handle X.Y += z (where X is a struct)
10498 2004-07-08 Martin Baulig <martin@ximian.com>
10500 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10501 not always return, just like we're doing in Using.Resolve().
10503 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10505 * cs-parser.jay (fixed_statement): flag this as Pinned.
10507 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10509 * typemanager.cs (TypeManager): Removed MakePinned method, this
10510 mechanism is replaced with the .NET 2.x compatible mechanism of
10511 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10513 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10514 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10515 `IsFixed' property which has a different meaning.
10517 2004-07-02 Raja R Harinath <rharinath@novell.com>
10519 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10520 visible from inside a nested class, not just the names of the
10521 immediately enclosing class.
10522 Fix for bug #60730.
10524 2004-06-24 Raja R Harinath <rharinath@novell.com>
10526 * expression.cs (BetterConversion): Remove buggy special-case
10527 handling of "implicit constant expression conversions". At this
10528 point, we already know that the conversion is possible -- we're
10529 only checking to see which is better.
10531 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10533 * cs-parser.jay: Added error CS0210 test.
10535 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10537 * cs-parser.jay: Added error CS0134 test.
10539 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10542 * cs-parser.jay: Added error CS0145 test.
10544 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10546 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10548 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10550 * expression.cs (StackAlloc.Resolve): The argument may not
10551 be a constant; deal with this case.
10553 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10555 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10556 GetIndexerAttributeValue.
10557 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10559 * class.cs (Indexer.Define): Added error tests for CS0415,
10562 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10564 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10567 2004-06-23 Martin Baulig <martin@ximian.com>
10569 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10570 neither return nor throw, reset the barrier as well. Fixes #60457.
10572 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10574 * class.cs : EventAttributes is now set to None by default.
10575 This fixes bug #60459.
10577 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10580 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10581 Don't throw exception but return null (it's sufficient now).
10583 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10585 * typemanager.cs (GetArgumentTypes): Faster implementation.
10587 2004-06-18 Martin Baulig <martin@ximian.com>
10589 * attribute.cs (Attribute.Resolve): Check whether we're an
10590 EmptyCast which a Constant child. Fixes #60333.
10592 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10594 * statement.cs (EmitCollectionForeach): Account for the fact that
10595 not all valuetypes are in areas which we can take the address of.
10596 For these variables, we store to a temporary variable. Also, make
10597 sure that we dont emit a `callvirt' on a valuetype method.
10599 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10601 * expression.cs (StackAlloc.DoReSolve): Added test for
10602 negative parameter (CS0247).
10604 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10607 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10609 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10612 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10615 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10617 Fix bug #58254 & cs1555.cs, cs1556.cs
10618 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10620 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10622 * cs-parser.jay: Added error CS1669 test for indexers.
10624 2004-06-18 Martin Baulig <martin@ximian.com>
10626 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10627 argument. Fixes #60441.
10629 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10630 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10631 The name needs to have the actual name of the method in order
10632 for other tests (such as the one in OverloadResolve for Invoke
10633 on a delegate) to work. As well, it does not really help
10634 error reporting because the method group had multiple methods.
10635 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10636 Make profiling work.
10638 2004-06-13 Martin Baulig <martin@ximian.com>
10640 * cs-parser.jay: Don't allow generic attributes.
10642 2004-06-13 Martin Baulig <martin@ximian.com>
10644 * class.cs (MemberBase.DoDefineBase): New protected method.
10645 (MemberBase.DoDefine): Compute the `flags' in the new
10646 DoDefineBase() which must be called first.
10647 (Method.Define): Call DoDefineBase() first so we have the flags
10648 when defining the generic method.
10650 * cs-parser.jay (interface_method_declaration): Support generic methods.
10652 2004-06-13 Martin Baulig <martin@ximian.com>
10654 * decl.cs (TypeName): Removed.
10655 (MemberName): Removed TypeName and MemberNow; now we just have
10658 * cs-parser.jay: Don't distinguish between type arguments and type
10659 parameters in the grammar and simplified the rules a bit. The
10660 reduce/reduce conflicts are now gone (except the one we inherited
10663 2004-06-11 Martin Baulig <martin@ximian.com>
10665 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10666 call this twice: for params and varargs methods.
10668 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10671 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10673 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10675 * attribute.cs (Attribute.GetValidTargets): Made public.
10678 (AbstractPropertyEventMethod): New class for better code sharing.
10679 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10681 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10683 2004-06-09 Martin Baulig <martin@ximian.com>
10685 * cs-parser.jay: Removed a reduce/reduce conflict.
10687 2004-06-03 Martin Baulig <martin@ximian.com>
10689 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10690 GetSimpleName() and return a SimpleName.
10692 * ecore.cs (SimpleName.Arguments): New public field.
10693 (SimpleName): Added overloaded ctor which takes an additional
10694 TypeArguments argument.
10695 (SimpleName.SimpleNameResolve): Added support for generic methods.
10696 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10697 formerly in MemberAccess.DoResolve(), but we also need it in
10698 SimpleNameResolve().
10700 * expression.cs (MemberAccess.DoResolve): Use the new
10701 MethodGroupExpr.ResolveGeneric().
10703 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10705 * decl.cs: If possible, use lookuptypedirect here. We can only do
10706 this if there is no `.' after the namespace. Avoids using
10707 LookupType, which does lots of slow processing.
10708 (FindNestedType) New method, does what it says :-).
10709 * namespace.cs: use LookupTypeDirect.
10710 * rootcontext.cs: use membercache, if possible.
10711 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10713 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10716 According to the spec,
10718 In a member access of the form E.I, if E is a single identifier,
10719 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10720 field, property, localvariable, or parameter with the same type as
10721 the meaning of E as a type-name (§3.8), then both possible
10722 meanings of E are permitted.
10724 We did not check that E as a simple-name had the same type as E as
10727 This trivial check gives us 5-7% on bootstrap time.
10729 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10731 * expression.cs (Invocation.OverloadResolve): Avoid the
10732 use of hashtables and boxing here by allocating on demand.
10734 2004-05-30 Martin Baulig <martin@ximian.com>
10736 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10737 we're doing a silent lookup. Don't try to lookup nested types in
10738 TypeManager.object_type (thanks to Ben Maurer).
10740 2004-05-30 Martin Baulig <martin@ximian.com>
10742 Committing a patch from Ben Maurer.
10744 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10746 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10748 * convert.cs: add a trivial cache for overload operator resolution.
10750 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10753 (AttributeTester.GetObsoleteAttribute): Returns instance of
10754 ObsoleteAttribute when type is obsolete.
10757 (TypeContainer.VerifyObsoleteAttribute): Override.
10758 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10759 (MethodCode.VerifyObsoleteAttribute): Override.
10760 (MemberBase.VerifyObsoleteAttribute): Override.
10763 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10764 and report proper error.
10767 (Delegate.VerifyObsoleteAttribute): Override.
10770 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10771 and report proper error.
10772 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10775 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10779 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10780 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10781 Added test for ObsoleteAttribute.
10784 (Catch): Derived from Statement.
10786 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10788 * decl.cs: If possible, use lookuptypedirect here. We can only do
10789 this if there is no `.' after the namespace. Avoids using
10790 LookupType, which does lots of slow processing.
10791 (FindNestedType) New method, does what it says :-).
10792 * namespace.cs: use LookupTypeDirect.
10793 * rootcontext.cs: use membercache, if possible.
10794 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10796 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10799 According to the spec,
10801 In a member access of the form E.I, if E is a single identifier,
10802 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10803 field, property, localvariable, or parameter with the same type as
10804 the meaning of E as a type-name (§3.8), then both possible
10805 meanings of E are permitted.
10807 We did not check that E as a simple-name had the same type as E as
10810 This trivial check gives us 5-7% on bootstrap time.
10812 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10814 Fixed bug #59071 & cs0160.cs
10815 * statement.cs (Try.Resolve): Check here whether order of catch
10816 clauses matches their dependencies.
10818 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10821 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10824 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10826 * expression.cs (Invocation.OverloadResolve): Avoid the
10827 use of hashtables and boxing here by allocating on demand.
10829 2004-05-30 Martin Baulig <martin@ximian.com>
10831 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10832 we're doing a silent lookup. Don't try to lookup nested types in
10833 TypeManager.object_type (thanks to Ben Maurer).
10835 2004-05-30 Martin Baulig <martin@ximian.com>
10837 Committing a patch from Ben Maurer.
10839 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10841 2004-05-29 Martin Baulig <martin@ximian.com>
10843 * class.cs (IMethodData.ShouldIgnore): New method.
10845 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10846 `Location' argument, we don't need it anywhere. Use
10847 `IMethodData.ShouldIgnore ()' instead of
10848 `MethodData.GetMethodFlags ()'.
10849 (TypeManager.AddMethod): Removed.
10850 (TypeManager.AddMethod2): Renamed to AddMethod.
10852 2004-05-29 Martin Baulig <martin@ximian.com>
10854 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10856 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10857 converting from a class type S to an interface type and we already
10858 have an object on the stack, don't box it again. Fixes #52578.
10860 2004-05-29 Martin Baulig <martin@ximian.com>
10862 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10863 Added support for `params' parameters. Fixes #59267.
10865 2004-05-29 Martin Baulig <martin@ximian.com>
10867 * literal.cs (NullPointer): Provide a private .ctor which sets
10868 `type' to TypeManager.object_type. Fixes #59048.
10870 2004-05-29 Martin Baulig <martin@ximian.com>
10872 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10873 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10875 * ecore.cs (EventExpr.instance_expr): Make the field private.
10877 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10879 Fixed bug #50080 & cs0214-2.cs
10880 * expression.cs (Cast.DoResolve): Check unsafe context here.
10882 * statement.cs (Resolve.DoResolve): Likewise.
10884 2004-05-26 Martin Baulig <martin@ximian.com>
10886 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
10888 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
10889 (RootContext.LookupType): Pass down the `silent' flag.
10891 2004-05-25 Martin Baulig <martin@ximian.com>
10894 (MethodGroupExpr.IdenticalTypeName): New public property.
10895 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
10896 expression actually refers to a type.
10898 2004-05-25 Martin Baulig <martin@ximian.com>
10900 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
10901 for #56176 and made it actually work.
10903 2004-05-25 Martin Baulig <martin@ximian.com>
10905 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
10906 (FieldExpr, PropertyExpr): Override and implement
10907 CacheTemporaries. Fixes #52279.
10909 2004-05-25 Miguel de Icaza <miguel@ximian.com>
10911 * location.cs: In the new compiler listing a file twice is a
10912 warning, not an error.
10914 2004-05-24 Martin Baulig <martin@ximian.com>
10916 * enum.cs (Enum.DefineType): For the `BaseType' to be a
10917 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
10919 2004-05-24 Martin Baulig <martin@ximian.com>
10921 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
10922 walking the `using' list. Fixes #53921.
10924 2004-05-24 Martin Baulig <martin@ximian.com>
10926 * const.cs (Const.LookupConstantValue): Added support for
10927 EmptyCast's; fixes #55251.
10929 2004-05-24 Martin Baulig <martin@ximian.com>
10931 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
10932 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
10933 which does the CS0135 check. The reason is that we first need to
10934 check whether the variable actually exists.
10936 2004-05-24 Martin Baulig <martin@ximian.com>
10938 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
10939 than RootContext.LookupType() to find the explicit interface
10940 type. Fixes #58584.
10942 2004-05-24 Raja R Harinath <rharinath@novell.com>
10944 * Makefile: Simplify. Use executable.make.
10945 * mcs.exe.sources: New file. List of sources of mcs.exe.
10947 2004-05-24 Anders Carlsson <andersca@gnome.org>
10951 Use the invariant culture when doing String.Compare for CLS case
10954 2004-05-23 Martin Baulig <martin@ximian.com>
10956 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
10957 don't have any dots. Fixes #52622, added cs0246-8.cs.
10959 * namespace.cs (NamespaceEntry.Lookup): Likewise.
10961 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10963 * class.cs (MemberBase.Define): Reuse MemberType member for
10964 resolved type. Other methods can use it too.
10966 2004-05-23 Martin Baulig <martin@ximian.com>
10968 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
10969 the variable also exists in the current block (otherwise, we need
10970 to report a CS0103). Fixes #58670.
10972 2004-05-23 Martin Baulig <martin@ximian.com>
10974 * flowanalysis.cs (Reachability.Reachable): Compute this
10975 on-the-fly rather than storing it as a field.
10977 2004-05-23 Martin Baulig <martin@ximian.com>
10979 * flowanalysis.cs (Reachability.And): Manually compute the
10980 resulting `barrier' from the reachability.
10982 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10985 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
10986 instance of ObsoleteAttribute when symbol is obsolete.
10989 (IMethodData): Extended interface for ObsoleteAttribute support.
10991 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10993 * attribute.cs: Fix bug #55970
10995 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10999 (GetObsoleteAttribute): New method. Creates the instance of
11001 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
11002 ObsoleteAttribute when member is obsolete.
11003 (AttributeTester.Report_ObsoleteMessage): Common method for
11004 Obsolete error/warning reporting.
11007 (TypeContainer.base_classs_type): New member for storing parent type.
11010 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
11011 for this MemberCore.
11013 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11015 * attribute.cs, const.cs: Fix bug #58590
11017 2004-05-21 Martin Baulig <martin@ximian.com>
11019 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
11020 out parameters if the end of the method is unreachable. Fixes
11023 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11025 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
11026 Hari was right, why extra method.
11028 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11030 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
11032 2004-05-20 Martin Baulig <martin@ximian.com>
11034 * delegate.cs: Convert this file to Unix mode - like the original
11037 2004-05-20 Martin Baulig <martin@ximian.com>
11039 * attribute.cs: Convert this file to Unix mode - like the original
11042 2004-05-19 Marek Safar <marek.safar@seznam.cz>
11044 Fix bug #58688 (MCS does not report error when the same attribute
11047 * attribute.cs (Attribute.Emit): Distinction between null and default.
11049 2004-05-19 Raja R Harinath <rharinath@novell.com>
11051 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
11052 of a top-level attribute without an attribute target.
11053 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
11055 (Attribute.Conditional_GetConditionName),
11056 (Attribute.Obsolete_GetObsoleteMessage): Update.
11057 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
11058 part of ScanForIndexerName.
11059 (Attribute.CanIgnoreInvalidAttribute): New function.
11060 (Attribute.ScanForIndexerName): Move to ...
11061 (Attributes.ScanForIndexerName): ... here.
11062 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
11063 (Attributes.Search): New internal variant that can choose not to
11064 complain if types aren't resolved. The original signature now
11066 (Attributes.GetClsCompliantAttribute): Use internal variant, with
11067 complaints suppressed.
11068 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
11069 only if it not useful.
11070 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
11071 top-level for attributes that are shared between the assembly
11072 and a top-level class.
11073 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
11074 * class.cs: Update to reflect changes.
11075 (DefineIndexers): Fuse loops.
11076 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
11077 a couple more variants of attribute names.
11079 2004-05-18 Marek Safar <marek.safar@seznam.cz>
11081 Fix bug #52585 (Implemented explicit attribute declaration)
11084 (Attributable.ValidAttributeTargets): New abstract method. It gets
11085 list of valid attribute targets for explicit target declaration.
11086 (Attribute.Target): It holds target itself.
11087 (AttributeSection): Removed.
11088 (Attribute.CheckTargets): New method. It checks whether attribute
11089 target is valid for the current element.
11092 (EventProperty): New class. For events that are declared like
11093 property (with add and remove accessors).
11094 (EventField): New class. For events that are declared like field.
11097 * cs-parser.jay: Implemented explicit attribute target declaration.
11099 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
11100 Override ValidAttributeTargets.
11103 (ReturnParameter): Class for applying custom attributes on
11105 (ParameterAtribute): New class. Class for applying custom
11106 attributes on the parameter type.
11108 2004-05-17 Miguel de Icaza <miguel@ximian.com>
11110 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
11113 (Method): Allow UNSAFE here.
11115 * modifiers.cs: Support unsafe reporting.
11117 2004-05-17 Marek Safar <marek.safar@seznam.cz>
11119 * decl.cs: Fix bug #58478.
11121 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11123 * statement.cs: When checking for unreachable code on an EmptyStatement,
11124 set the location. Fixes bug #58488.
11126 2004-05-13 Miguel de Icaza <miguel@ximian.com>
11128 * driver.cs: Add -pkg handling.
11130 From Gonzalo: UseShelLExecute=false
11132 2004-05-12 Marek Safar <marek.safar@seznam.cz>
11135 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
11137 (Attribute.IsClsCompliaceRequired): Moved to base for better
11139 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
11140 when attribute is AttributeUsageAttribute.
11141 (Attribute.GetValidTargets): Simplified.
11142 (Attribute.GetAttributeUsage): New method returns AttributeUsage
11143 attribute for this type.
11144 (Attribute.ApplyAttributes): Method renamed to Emit and make
11146 (GlobalAttributeSection): New class for special handling of global
11147 attributes (assembly, module).
11148 (AttributeSection.Emit): New method.
11150 * class.cs: Implemented Attributable abstract methods.
11151 (MethodCore.LabelParameters): Moved to Parameter class.
11152 (Accessor): Is back simple class.
11153 (PropertyMethod): Implemented Attributable abstract class.
11154 (DelegateMethod): Implemented Attributable abstract class.
11155 (Event): New constructor for disctintion between normal Event
11156 and Event with accessors.
11158 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
11160 * codegen.cs, const.cs, decl.cs, delegate.cs:
11161 (CommonAssemblyModulClass): Implemented Attributable abstract class
11164 * enum.cs: Implement IAttributeSupport interface.
11165 (EnumMember): New class for emum members. Implemented Attributable
11169 (ParameterBase): Is abstract.
11170 (ReturnParameter): New class for easier [return:] attribute handling.
11172 * typemanager.cs: Removed builder_to_attr.
11174 2004-05-11 Raja R Harinath <rharinath@novell.com>
11177 * attribute.cs (Attribute.GetPositionalValue): New function.
11178 * class.cs (TypeContainer.VerifyMembers): New function.
11179 (TypeContainer.Emit): Use it.
11180 (ClassOrStruct): New base class for Class and Struct.
11181 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
11182 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
11184 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
11185 then each non-static field should have a FieldOffset attribute.
11186 Otherwise, none of the fields should have a FieldOffset attribute.
11187 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
11188 and FieldOffset attributes.
11189 * typemanager.cs (TypeManager.struct_layout_attribute_type)
11190 (TypeManager.field_offset_attribute_type): New core types.
11191 (TypeManager.InitCoreTypes): Initialize them.
11193 2004-05-11 Michal Moskal <malekith@pld-linux.org>
11195 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
11196 Return correct type.
11199 2004-05-09 Miguel de Icaza <miguel@ximian.com>
11201 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
11202 be implicitly converted to ulong.
11204 * expression.cs: The logic for allowing operator &, | and ^ worked
11205 was wrong, it worked before because we did not report an error in
11206 an else branch. Fixes 57895.
11208 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
11209 allow volatile fields to be reference types.
11211 2004-05-07 Miguel de Icaza <miguel@ximian.com>
11213 * driver.cs: Add support for /debug-
11215 2004-05-07 Raja R Harinath <rharinath@novell.com>
11217 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
11218 Add a 'complain' parameter to silence errors.
11219 (Attribute.Resolve): Update to changes. Put in sanity check to catch
11220 silently overlooked type-resolutions.
11221 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
11222 to reflect changes.
11223 (Attributes.Search): New function.
11224 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
11225 (Attributes.GetAttributeFullName): Remove hack.
11226 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
11227 Update to reflect changes.
11228 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11229 Use Attributes.Search instead of nested loops.
11231 2004-05-07 Marek Safar <marek.safar@seznam.cz>
11234 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
11235 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
11236 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
11238 * report.cs: (Report.Warning): Renamed to Warning_T because of
11239 parameter collision.
11241 2004-05-05 Raja R Harinath <rharinath@novell.com>
11243 * expression.cs (MemberAccess.ResolveMemberAccess):
11244 Exit with non-zero status after Report.Error.
11245 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
11247 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
11249 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11251 * support.cs: Don't hang when the file is empty.
11253 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11255 * support.cs: In SeekableStreamReader, compute the preamble size of the
11256 underlying stream. Position changes should take into account that initial
11259 2004-05-03 Todd Berman <tberman@sevenl.net>
11261 * driver.cs: remove unused GetSysVersion function.
11263 2004-05-03 Todd Berman <tberman@sevenl.net>
11265 * driver.cs: Remove the hack from saturday, as well as the hack
11266 from jackson (LoadAssemblyFromGac), also adds the CWD to the
11267 link_paths to get that bit proper.
11269 2004-05-01 Todd Berman <tberman@sevenl.net>
11271 * driver.cs: Try a LoadFrom before a Load, this checks the current
11272 path. This is currently a bug in mono that is be fixed, however, this
11273 provides a workaround for now. This will be removed when the bug
11276 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11278 * CryptoConvert.cs: Updated to latest version. Fix issue with
11279 incomplete key pairs (#57941).
11281 2004-05-01 Todd Berman <tberman@sevenl.net>
11283 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11286 2004-04-30 Jackson Harper <jackson@ximian.com>
11288 * codegen.cs: Open keys readonly.
11290 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11292 * typemanager.cs: don't report cyclic struct layout when a struct
11293 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11294 which has 2 Pango.Rectangle fields.
11296 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11298 * expression.cs: Handle IntPtr comparisons with IL code
11299 rather than a method call.
11301 2004-04-29 Martin Baulig <martin@ximian.com>
11303 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11304 the list of PropertyInfo's in class hierarchy and find the
11305 accessor. Fixes #56013.
11307 2004-04-29 Martin Baulig <martin@ximian.com>
11309 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11311 2004-04-29 Martin Baulig <martin@ximian.com>
11313 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11315 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11317 2004-04-29 Martin Baulig <martin@ximian.com>
11319 * class.cs (ConstructorInitializer.Resolve): Check whether the
11320 parent .ctor is accessible. Fixes #52146.
11322 2004-04-29 Martin Baulig <martin@ximian.com>
11324 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11326 * statement.cs (Using.EmitLocalVariableDecls): Use
11327 TypeManager.idisposable_type, not typeof (IDisposable).
11328 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11330 2004-04-29 Martin Baulig <martin@ximian.com>
11332 * class.cs (Event.Define): Don't emit the field and don't set
11333 RTSpecialName and SpecialName for events on interfaces. Fixes
11336 2004-04-29 Raja R Harinath <rharinath@novell.com>
11338 Refactor Attribute.ApplyAttributes.
11339 * attribute.cs (Attributable): New base class for objects that can
11340 have Attributes applied on them.
11341 (Attribute): Make AttributeUsage fields public.
11342 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11343 (Attribute.IsInternalCall): New property.
11344 (Attribute.UsageAttr): Convert to a public read-only property.
11345 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11346 (Attribute.ResolveType, Attribute.Resolve)
11347 (Attribute.ScanForIndexerName): Update to reflect changes.
11348 (Attribute.CheckAttributeTarget): Re-format.
11349 (Attribute.ApplyAttributes): Refactor, to various
11350 Attributable.ApplyAttributeBuilder methods.
11351 * decl.cs (MemberCore): Make Attributable.
11352 * class.cs (Accessor): Make Attributable.
11353 (MethodData.ApplyAttributes): Use proper attribute types, not
11355 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11356 (TypeContainer.ApplyAttributeBuilder)
11357 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11358 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11359 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11360 (Operator.ApplyAttributeBuilder): New factored-out methods.
11361 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11362 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11363 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11364 * parameter.cs (ParameterBase): New Attributable base class
11365 that can also represent Return types.
11366 (Parameter): Update to the changes.
11368 2004-04-29 Jackson Harper <jackson@ximian.com>
11370 * driver.cs: Prefer the corlib system version when looking for
11371 assemblies in the GAC. This is still a hack, but its a better hack
11374 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11376 * decl.cs, enum.cs: Improved error 3005 reporting.
11378 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11379 (related_symbols): New private member for list of symbols
11380 related to reported error/warning.
11382 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11384 2004-04-29 Martin Baulig <martin@ximian.com>
11386 * ecore.cs (Expression.Constantify): If we're an enum and
11387 TypeManager.TypeToCoreType() doesn't give us another type, use
11388 t.UnderlyingSystemType. Fixes #56178.
11390 2004-04-29 Martin Baulig <martin@ximian.com>
11392 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11393 interfaces and for each interface, only add members directly
11394 declared in that interface. Fixes #53255.
11396 2004-04-28 Martin Baulig <martin@ximian.com>
11398 * expression.cs (ConditionalLogicalOperator): Use a temporary
11399 variable for `left' to avoid that we evaluate it more than once;
11402 2004-04-28 Martin Baulig <martin@ximian.com>
11404 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11407 2004-04-28 Martin Baulig <martin@ximian.com>
11409 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11412 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11413 whether the type is not void (CS1547).
11415 2004-04-28 Martin Baulig <martin@ximian.com>
11417 * expression.cs (Unary.DoResolveLValue): Override this and report
11418 CS0131 for anything but Operator.Indirection.
11420 2004-04-28 Martin Baulig <martin@ximian.com>
11422 Committing a patch from Ben Maurer; see bug #50820.
11424 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11427 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11430 2004-04-28 Martin Baulig <martin@ximian.com>
11432 Committing a patch from Ben Maurer; see bug #50820.
11434 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11437 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11440 2004-04-28 Martin Baulig <martin@ximian.com>
11442 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11443 (Block.AddLabel): Call DoLookupLabel() to only search in the
11446 2004-04-28 Martin Baulig <martin@ximian.com>
11448 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11449 comparing StringConstants and NullLiterals in Equality and Inequality.
11451 2004-04-28 Jackson Harper <jackson@ximian.com>
11453 * driver.cs: Attempt to load referenced assemblies from the
11454 GAC. This is the quick and dirty version of this method that
11455 doesnt take into account versions and just takes the first
11456 canidate found. Will be good enough for now as we will not have more
11457 then one version installed into the GAC until I update this method.
11459 2004-04-28 Martin Baulig <martin@ximian.com>
11461 * typemanager.cs (TypeManager.CheckStructCycles): New public
11462 static method to check for cycles in the struct layout.
11464 * rootcontext.cs (RootContext.PopulateTypes): Call
11465 TypeManager.CheckStructCycles() for each TypeContainer.
11466 [Note: We only need to visit each type once.]
11468 2004-04-28 Martin Baulig <martin@ximian.com>
11470 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11472 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11473 success and added `out object value'. Use a `bool resolved' field
11474 to check whether we've already been called rather than
11475 `ConstantValue != null' since this breaks for NullLiterals.
11477 2004-04-28 Raja R Harinath <rharinath@novell.com>
11479 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11480 setting of this flag, since the 'set' method may be non-public.
11482 2004-04-28 Raja R Harinath <rharinath@novell.com>
11484 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11485 check on current_vector.Block.
11487 2004-04-27 Martin Baulig <martin@ximian.com>
11489 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11490 a field initializer. Fixes #56459.
11492 2004-04-27 Martin Baulig <martin@ximian.com>
11494 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11495 we're not attempting to use an indexer. Fixes #52154.
11497 2004-04-27 Martin Baulig <martin@ximian.com>
11499 * statement.cs (Return): Don't create a return label if we don't
11500 need it; reverts my change from January 20th. Thanks to Ben
11503 2004-04-27 Martin Baulig <martin@ximian.com>
11505 According to the spec, `goto' can only leave a nested scope, but
11508 * statement.cs (Block.LookupLabel): Only lookup in the current
11509 block, don't recurse into parent or child blocks.
11510 (Block.AddLabel): Check in parent and child blocks, report
11511 CS0140/CS0158 if we find a duplicate.
11512 (Block): Removed this indexer for label lookups.
11513 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11514 this already does the error reporting for us.
11517 (FlowBranching.UsageVector.Block): New public variable; may be null.
11518 (FlowBranching.CreateSibling): Added `Block' argument.
11519 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11520 label for the target of a `goto' and check whether we're not
11521 leaving a `finally'.
11523 2004-04-27 Martin Baulig <martin@ximian.com>
11525 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11526 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11529 2004-04-27 Martin Baulig <martin@ximian.com>
11531 * statement.cs (Block.AddLabel): Also check for implicit blocks
11532 and added a CS0158 check.
11534 2004-04-27 Martin Baulig <martin@ximian.com>
11536 * flowanalysis.cs (FlowBranchingLoop): New class.
11537 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11538 UsageVector's instead of an ArrayList.
11539 (FlowBranching.Label): Likewise.
11540 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11541 (FlowBranching.AddBreakVector): New method.
11543 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11545 * attribute.cs: Small regression fix: only convert the type if we
11546 the type is different, fixes System.Drawing build.
11548 2004-04-27 Martin Baulig <martin@ximian.com>
11550 * attribute.cs (Attribute.Resolve): If we have a constant value
11551 for a named field or property, implicity convert it to the correct
11554 2004-04-27 Raja R Harinath <rharinath@novell.com>
11556 * statement.cs (Block.Block): Implicit blocks share
11557 'child_variable_names' fields with parent blocks.
11558 (Block.AddChildVariableNames): Remove.
11559 (Block.AddVariable): Mark variable as "used by a child block" in
11560 every surrounding block.
11561 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11562 been used in a child block, complain about violation of "Invariant
11563 meaning in blocks" rule.
11564 * cs-parser.jay (declare_local_variables): Don't use
11565 AddChildVariableNames.
11566 (foreach_statement): Don't create an implicit block: 'foreach'
11567 introduces a scope.
11569 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11571 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11572 converting from 0L to ulong. Fixes 57522.
11574 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11576 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11577 derived class hides via 'new' keyword field from base class (test-242.cs).
11578 TODO: Handle this in the more general way.
11580 * class.cs (CheckBase): Ditto.
11582 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11584 * decl.cs (caching_flags): New member for storing cached values
11586 (MemberCore.Flags): New enum where bit flags for caching_flags
11588 (MemberCore.cls_compliance): Moved to caching_flags.
11589 (DeclSpace.Created): Moved to caching_flags.
11591 * class.cs: Use caching_flags instead of DeclSpace.Created
11593 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11595 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11596 if we are only a derived class, not a nested class.
11598 * typemanager.cs: Same as above, but do this at the MemberLookup
11599 level (used by field and methods, properties are handled in
11600 PropertyExpr). Allow for the qualified access if we are a nested
11603 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11605 * class.cs: Refactoring.
11606 (IMethodData): New inteface; Holds links to parent members
11607 to avoid member duplication (reduced memory allocation).
11608 (Method): Implemented IMethodData interface.
11609 (PropertyBase): New inner classes for get/set methods.
11610 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11611 (Event): New inner classes for add/remove methods.
11612 (Event.DelegateMethod): Implemented IMethodData interface.
11614 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11615 EmitContext (related to class.cs refactoring).
11617 2004-04-21 Raja R Harinath <rharinath@novell.com>
11619 * delegate.cs (Delegate.VerifyApplicability): If the number of
11620 arguments are the same as the number of parameters, first try to
11621 verify applicability ignoring any 'params' modifier on the last
11625 2004-04-08 Martin Baulig <martin@ximian.com>
11627 Merged latest changes into gmcs. Please keep this comment in
11628 here, it makes it easier for me to see what changed in MCS since
11629 the last time I merged.
11631 2004-04-16 Raja R Harinath <rharinath@novell.com>
11633 * class.cs (TypeContainer.AddIndexer): Use
11634 'ExplicitInterfaceName' to determine if interface name was
11635 explicitly specified. 'InterfaceType' is not initialized at this time.
11636 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11637 Indexers array is already in the required order. Initialize
11638 'IndexerName' only if there are normal indexers.
11639 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11640 (TypeContainer.Emit): Emit DefaultMember attribute only if
11641 IndexerName is initialized.
11644 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11646 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11649 2004-04-15 Raja R Harinath <rharinath@novell.com>
11651 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11655 * attribute.cs (Attribute.Resolve): Check for duplicate named
11659 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11661 * iterators.cs (MarkYield): track whether we are in an exception,
11662 and generate code accordingly. Use a temporary value to store the
11663 result for our state.
11665 I had ignored a bit the interaction of try/catch with iterators
11666 since their behavior was not entirely obvious, but now it is
11667 possible to verify that our behavior is the same as MS .NET 2.0
11671 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11673 * iterators.cs: Avoid creating temporaries if there is no work to
11676 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11677 Enumerations, use TypeManager.EnumToUnderlying and call
11680 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11683 (This.Emit): Use EmitContext.EmitThis to emit our
11686 (This.EmitAssign): Ditto.
11688 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11689 codepaths, we will move all the functionality into
11692 (FieldExpr.EmitAssign): Ditto.
11694 This fixes several hidden bugs that I uncovered while doing a code
11695 review of this today.
11697 * codegen.cs (EmitThis): reworked so the semantics are more clear
11698 and also support value types "this" instances.
11700 * iterators.cs: Changed so that for iterators in value types, we
11701 do not pass the value type as a parameter.
11703 Initialization of the enumerator helpers is now done in the caller
11704 instead of passing the parameters to the constructors and having
11705 the constructor set the fields.
11707 The fields have now `assembly' visibility instead of private.
11709 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11711 * expression.cs (Argument.Resolve): Check if fields passed as ref
11712 or out are contained in a MarshalByRefObject.
11714 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11715 another compiler type.
11717 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11719 * class.cs (Indexer.Define): use the new name checking method.
11720 Also, return false on an error.
11721 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11722 (is_identifier_[start/part]_character): make static.
11724 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11726 * expression.cs (Binary.ResolveOperator): Do no append strings
11727 twice: since we can be invoked more than once (array evaluation)
11728 on the same concatenation, take care of this here. Based on a fix
11729 from Ben (bug #56454)
11731 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11733 * codegen.cs: Fix another case where CS1548 must be reported (when
11734 delay-sign isn't specified and no private is available #56564). Fix
11735 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11736 error when MCS is used on the MS runtime and we need to delay-sign
11737 (which seems unsupported by AssemblyBuilder - see #56621).
11739 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11741 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11742 (TypeManager.ComputeNamespaces): Faster implementation for
11745 * compiler.csproj: Updated AssemblyName to mcs.
11747 2004-05-11 Jackson Harper <jackson@ximian.com>
11749 * Makefile: Preserve MONO_PATH
11751 2004-05-11 Jackson Harper <jackson@ximian.com>
11753 * Makefile: Use mono and mcs to build gmcs
11755 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11757 * codegen.cs: Add patch from Robert Shade
11758 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11761 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11763 * CryptoConvert.cs: Updated to latest version. Fix issue with
11764 incomplete key pairs (#57941).
11766 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11768 * codegen.cs: Fix another case where CS1548 must be reported (when
11769 delay-sign isn't specified and no private is available #56564). Fix
11770 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11771 error when MCS is used on the MS runtime and we need to delay-sign
11772 (which seems unsupported by AssemblyBuilder - see #56621).
11774 2004-04-29 Jackson Harper <jackson@ximian.com>
11776 * Makefile: Set MONO_PATH to use the bootstrap corlib
11777 * driver.cs: Check the GAC for referenced assemblies.
11779 2004-04-29 Martin Baulig <martin@ximian.com>
11781 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11783 2004-04-07 Martin Baulig <martin@ximian.com>
11785 * expression.cs (Binary.ResolveOperator): Added special case for
11786 Equality/Inequality between a type parameter and a null literal.
11788 2004-04-07 Martin Baulig <martin@ximian.com>
11790 * convert.cs: Check null literal -> type parameter conversions.
11792 2004-04-07 Martin Baulig <martin@ximian.com>
11794 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11795 `class' and `struct' constraints.
11797 2004-04-07 Martin Baulig <martin@ximian.com>
11799 * generic.cs (SpecialConstraint): New public enum.
11800 (Constraints.Resolve): Added support for the `class' and `struct'
11803 * cs-parser.jay (type_parameter_constraint): Added support for the
11804 `class' and `struct' constraints.
11806 2004-04-07 Martin Baulig <martin@ximian.com>
11808 * support.cs (GenericConstraints): Replaced `Types' by
11809 `ClassConstraint' and `InterfaceConstraints'; added
11810 `HasClassConstraint'.
11812 2004-04-07 Martin Baulig <martin@ximian.com>
11815 (Constraints.InterfaceConstraints): New public property.
11816 (Constraints.Types): Make this property public
11817 (TypeParameter): Implement IMemberContainer.
11818 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11819 instead of a TypeBuilder/MethodBuilder; pass the interface
11820 constraints to TypeManager.AddTypeParameter().
11821 (TypeParameter.DefineType): Just take an EmitContext and no
11822 TypeBuilder/MethodBuilder. Use the new public API.
11824 * typemanager.cs (TypeManager.AddTypeParameter): Added
11825 `TypeExpr[]' argument; add the interfaces to the
11826 `builder_to_ifaces' hash.
11827 (TypeManager.LookupMemberContainer): For
11828 GenericTypeParameterBuilders, get the TypeParameter from the
11829 `builder_to_type_param'.
11830 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11831 the TypeParameter and call FindMembers on it.
11833 2004-04-07 Martin Baulig <martin@ximian.com>
11836 (MethodCore.GenericMethod): Moved this field here from Method.
11837 (MethodCore.IsDuplicateImplementation): Take the number of type
11838 parameters into account if we're a generic method.
11840 * expression.cs (Invocation.InferTypeArguments): Don't return true
11841 if `arguments' is null; we still need to check whether we actually
11842 don't need to infer anything in this case.
11843 (MemberAccess): Merged the functionality from GenericMemberAccess
11846 * generic.cs (GenericMemberAccess): Removed.
11848 2004-04-05 Martin Baulig <martin@ximian.com>
11850 * decl.cs (MemberCore): For generic classes, interfaces and
11851 structs, `Name' now includes the number of type parameters
11852 ("Stack!1.Node!1").
11853 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11854 encode the number of type arguments in the type name.
11856 * expression.cs (Expression.MemberLookup): Removed the
11857 `num_type_args' argument; we now encode the number of type
11858 arguments in the type name.
11860 * ecore.cs (SimpleName): Encode the number of type arguments in
11861 the type name itself.
11863 * generic.cs (ConstructedType): Likewise.
11865 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11866 `MemberName'; we now include the number of type parameters in the
11869 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11870 (TypeManager.MemberLookup): Removed the
11871 `num_type_args' argument; we now encode the number of type
11872 arguments in the type name.
11874 2004-04-03 Martin Baulig <martin@ximian.com>
11876 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11877 (MemberCore.MemberName): Moved here from MemberBase.
11878 (DeclSpace.SetParameterInfo): Just take the constraints as an
11879 ArrayList; we already have the type parameters in our
11880 `MemberName'; also do the CS0080 reporting here.
11882 * cs-parser.jay (struct_declaration): Use `member_name' instead of
11883 `IDENTIFIER opt_type_parameter_list'; when constructing our
11884 `MemberName', it'll already include our type parameters.
11885 (class_declaration, interface_declaration): Likewise.
11886 (delegate_declaration): Likewise.
11887 (MakeName): Take a MemberName and return a MemberName.
11888 The following two changes are required to avoid shift/reduce conflicts:
11889 (member_name): Don't include a TypeName anymore; ie. this is now
11890 just 'IDENTIFIER opt_type_parameter_list'.
11891 (property_declaration, event_declaration): Use a
11892 `namespace_or_type_name' instead of a `member_name'.
11894 2004-04-03 Martin Baulig <martin@ximian.com>
11896 * decl.cs (MemberName): Renamed to `TypeName' and created a new
11897 `MemberName' class.
11898 (TypeName): Formerly known as MemberName.
11900 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
11901 instead of a `MemberName'.
11903 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
11904 (member_name): New rule; create a MemberName.
11906 2004-04-02 Martin Baulig <martin@ximian.com>
11908 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
11909 (CS0305 and CS0308).
11911 2004-04-02 Martin Baulig <martin@ximian.com>
11913 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
11914 support for nested types.
11916 2004-04-02 Martin Baulig <martin@ximian.com>
11918 * ecore.cs (IAlias): New public interface.
11919 (TypeExpr, TypeExpression): Implement IAlias.
11920 (TypeAliasExpression): New public class.
11922 * namespace.cs (Namespace): Implement IAlias.
11923 (Namespace.Lookup): Return an IAlias instead on an object.
11924 (Namespace.DefineName): Take an IAlias instead of an object.
11925 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
11927 (NamespaceEntry.UsingAlias): Take a Membername instead of an
11929 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
11931 (NamespaceEntry.Lookup): Likewise.
11933 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
11936 * decl.cs (DeclSpace): Implement IAlias.
11937 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
11939 * generic.cs (ConstructedType): Improved error checking.
11941 2004-04-02 Martin Baulig <martin@ximian.com>
11943 * convert.cs: Added type parameter conversions.
11946 (UnboxCast.Emit): Emit an `unbox.any' for type params.
11947 (ClassCast.Emit): If the source type is a type parameter, box it.
11948 If the target type is a type parameter, emit an `unbox.any'
11949 instead of a `classcast'.1
11951 2004-04-01 Martin Baulig <martin@ximian.com>
11953 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
11955 2004-04-01 Martin Baulig <martin@ximian.com>
11957 * generic.cs (ConstructedType.CheckConstraints): Use
11958 Convert.ImplicitStandardConversionExists(); user-defined implicit
11959 conversions are not allowed according to the spec.
11961 2004-03-30 Martin Baulig <martin@ximian.com>
11963 * expression.cs (New): Added support for type parameters.
11966 (TypeManager.activator_type): New public static field.
11967 (TypeManager.activator_create_instance): Likewise.
11969 2004-03-30 Martin Baulig <martin@ximian.com>
11971 * typemanager.cs (TypeManager.HasConstructorConstraint): New
11974 2004-03-30 Martin Baulig <martin@ximian.com>
11976 * generic.cs (ConstructedType.CheckConstraints): Actually follow
11977 the spec here: the argument type must be convertible to the
11980 2004-03-30 Martin Baulig <martin@ximian.com>
11983 (TypeParameter.Define, TypeParameter.DefineMethod): Call
11984 TypeManager.AddTypeParameter().
11985 (ConstructedType.CheckConstraints): Re-enable this and actually
11986 check whether we have a constructor constraint.
11989 (TypeManager.builder_to_type_param): New static field.
11990 (TypeManager.AddTypeParameter): New static method.
11991 (TypeManager.LookupTypeParameter): New public method.
11993 2004-03-30 Martin Baulig <martin@ximian.com>
11995 * generic.cs (TypeParameter.DefineType): Return a boolean and use
11996 the new API to actually define the constructor constraint.
11999 (TypeManager.new_constraint_attr_type): New static field.
12000 (TypeManager.InitCoreTypes): Initialize it.
12002 2004-03-30 Martin Baulig <martin@ximian.com>
12004 * generic.cs (Constraints): Completed error checking, use correct
12007 2004-03-29 Martin Baulig <martin@ximian.com>
12009 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
12011 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12012 public version which takes a `ParameterData pd' instead of an
12015 2004-03-29 Martin Baulig <martin@ximian.com>
12017 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
12020 2004-03-29 Martin Baulig <martin@ximian.com>
12022 * expression.cs (Argument.ResolveMethodGroup): If we're a
12023 ConstructedType, call GetMemberAccess() on it.
12025 2004-03-29 Martin Baulig <martin@ximian.com>
12027 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
12028 (MethodCore.CheckGenericOverride): When overriding a generic
12029 method, check whether the constraints match.
12031 * support.cs (GenericConstraints): New public interface.
12032 (ParameterData.GenericConstraints): New public method.
12034 * parameter.cs (Parameter.Resolve): Check whether we're a generic
12035 method parameter and compute our constraints if appropriate.
12036 (Parameter.GenericConstraints): New public property.
12038 * generic.cs (Constraints): Implement GenericConstraints.
12040 2004-03-29 Martin Baulig <martin@ximian.com>
12042 * decl.cs (MemberCache.FindMemberToOverride): Use
12043 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
12045 2004-03-29 Martin Baulig <martin@ximian.com>
12047 * generic.cs (GenericMethod.Define): Resolve our type parameters.
12049 2004-03-29 Martin Baulig <martin@ximian.com>
12051 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
12052 not allowed on non-generic declarations").
12054 2004-03-29 Martin Baulig <martin@ximian.com>
12056 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12057 public version of this method.
12059 * class.cs (MethodCore.IsDuplicateImplementation): Use
12060 Invocation.InferTypeArguments() to check this.
12062 2004-03-29 Martin Baulig <martin@ximian.com>
12064 * convert.cs: Use TypeManager.IsDelegateType() instead of
12065 comparing types correctly.
12067 2004-03-29 Martin Baulig <martin@ximian.com>
12069 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
12070 types directly to make it work for generic instances.
12072 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
12074 2004-03-29 Martin Baulig <martin@ximian.com>
12076 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
12077 support for arrays.
12079 2004-03-24 Martin Baulig <martin@ximian.com>
12081 * decl.cs (DeclSpace.FindType): Also use
12082 TypeManager.CheckGeneric() for types from the using clauses.
12084 2004-03-23 Martin Baulig <martin@ximian.com>
12086 * expression.cs (Invocation.OverloadResolve): Added `bool
12087 may_fail' argument and use it instead of the Location.IsNull() hack.
12089 2004-03-23 Martin Baulig <martin@ximian.com>
12091 * expression.cs (Invocation.InferType): Use correct type inference
12094 2004-03-23 Martin Baulig <martin@ximian.com>
12096 * ecore.cs (MethodGroupExpr.Name): Use
12097 TypeManager.CSharpSignature() instead of just the name.
12099 * expression.cs (Invocation.OverloadResolve): Provide better error
12101 (Invocation.DoResolve): OverloadResolve() never returns null
12102 without reporting an error, so removed the error -6 reporting here.
12104 2004-03-23 Martin Baulig <martin@ximian.com>
12106 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
12109 * cs-parser.jay (delegate_declaration): Support generic delegates.
12111 * delegate.cs: Support generic delegates.
12113 2004-03-22 Martin Baulig <martin@ximian.com>
12115 * expression.cs (Invocation.InferParamsTypeArguments): New static
12116 method; does type inference for params arguments.
12118 2004-03-21 Martin Baulig <martin@ximian.com>
12120 * typemanager.cs (TypeManager.IsGenericMethod): New public static
12121 method; checks whether a method is a generic method.
12123 * expression.cs (Invocation.InferTypeArguments): New static method;
12124 infer type arguments for generic method invocation.
12126 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
12127 property; we set this to true if we're resolving a generic method
12128 invocation and the user specified type arguments, ie. we're not
12129 doing type inference.
12131 2004-03-20 Martin Baulig <martin@ximian.com>
12133 * class.cs (MethodData.DeclaringType): New public property.
12134 (MethodData.Define): Set DeclaringType here.
12135 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
12136 instead of OperatorMethodBuilder.DeclaringType.
12138 2004-03-20 Martin Baulig <martin@ximian.com>
12140 * cs-tokenizer.cs (xtoken): Return a special
12141 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
12143 * cs-parser.jay (default_value_expression): Switch to the new
12146 2004-03-19 Martin Baulig <martin@ximian.com>
12148 * decl.cs (MemberName): New class. We use this to "construct"
12149 namespace_or_type_name's.
12151 * generics.cs (TypeArguments.GetDeclarations): New public method;
12152 returns the type arguments as a string[] and reports a CS0081 if
12153 one of them is not an identifier.
12155 * class.cs (MemberBase): The .ctor now takes the name as a
12156 MemberName instead of a string.
12157 (MemberBase.ExplicitInterfaceName): Changed type from string to
12159 (MemberBase.DoDefine): If we're an explicit implementation, the
12160 InterfaceType may be a generic instance.
12162 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
12163 (namespace_name): Call MemberName.GetName () to transform the
12164 MemberName into a string and ensure we don't have any type
12166 (type_name): Call MemberName.GetTypeExpression() to transfrom the
12167 MemberName into an expression.
12168 (method_header): Use namespace_or_type_name instead of member_name.
12170 2004-04-07 Miguel de Icaza <miguel@ximian.com>
12172 * rootcontext.cs: Add new types to the boot resolution.
12174 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
12175 MulticastDelegate is not allowed.
12177 * typemanager.cs: Add new types to lookup: System.TypedReference
12180 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
12181 check for TypedReference or ArgIterator, they are not allowed.
12183 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
12184 makes us properly catch 1510 in some conditions (see bug 56016 for
12187 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
12189 * CryptoConvert.cs: update from corlib version
12192 2004-04-05 Miguel de Icaza <miguel@ximian.com>
12194 * class.cs (Indexer.Define): Check indexername declaration
12196 2004-04-05 Marek Safar <marek.safar@seznam.cz>
12198 * attribute.cs (IsClsCompliant): Fixed problem with handling
12199 all three states (compliant, not-compliant, undetected).
12201 2004-03-30 Marek Safar <marek.safar@seznam.cz>
12203 * attribute.cs (Attribute): Location is now public.
12204 (Resolve): Store resolved arguments (pos_values) in attribute class.
12205 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
12206 (GetClsCompliantAttributeValue): New method that gets
12207 CLSCompliantAttribute value.
12208 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
12209 if exists else null.
12210 (AttributeTester): New class for CLS-Compliant verification routines.
12212 * class.cs (Emit): Add CLS-Compliant verification.
12213 (Method.GetSignatureForError): Implemented.
12214 (Constructor.GetSignatureForError): Implemented
12215 (Constructor.HasCompliantArgs): Returns if constructor has
12216 CLS-Compliant arguments.
12217 (Constructor.Emit): Override.
12218 (Construcor.IsIdentifierClsCompliant): New method; For constructors
12219 is needed to test only parameters.
12220 (FieldBase.GetSignatureForError): Implemented.
12221 (TypeContainer): New member for storing base interfaces.
12222 (TypeContainer.FindMembers): Search in base interfaces too.
12224 * codegen.cs (GetClsComplianceAttribute): New method that gets
12225 assembly or module CLSCompliantAttribute value.
12226 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
12228 (ModuleClass.Emit): Add error 3012 test.
12230 * const.cs (Emit): Override and call base for CLS-Compliant tests.
12232 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
12233 state for all decl types.
12234 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
12235 if CLS-Compliant tests are required.
12236 (IsClsCompliaceRequired): New method. Analyze whether code
12237 must be CLS-Compliant.
12238 (IsExposedFromAssembly): New method. Returns true when MemberCore
12239 is exposed from assembly.
12240 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
12241 value or gets cached value.
12242 (HasClsCompliantAttribute): New method. Returns true if MemberCore
12243 is explicitly marked with CLSCompliantAttribute.
12244 (IsIdentifierClsCompliant): New abstract method. This method is
12245 used to testing error 3005.
12246 (IsIdentifierAndParamClsCompliant): New method. Common helper method
12247 for identifier and parameters CLS-Compliant testing.
12248 (VerifyClsCompliance): New method. The main virtual method for
12249 CLS-Compliant verifications.
12250 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
12251 null. I don't know why is null (too many public members !).
12252 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
12253 and get value of first CLSCompliantAttribute that found.
12255 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
12256 (VerifyClsCompliance): Override and add extra tests.
12258 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
12259 clscheck- disable CLS-Compliant verification event if assembly is has
12260 CLSCompliantAttribute(true).
12262 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
12263 ApllyAttribute is now called in emit section as in the other cases.
12264 Possible future Emit integration.
12265 (IsIdentifierClsCompliant): New override.
12266 (VerifyClsCompliance): New override.
12267 (GetEnumeratorName): Returns full enum name.
12269 * parameter.cs (GetSignatureForError): Implemented.
12271 * report.cs (WarningData): New struct for Warning message information.
12272 (LocationOfPreviousError): New method.
12273 (Warning): New method. Reports warning based on the warning table.
12274 (Error_T): New method. Reports error based on the error table.
12276 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12277 verifications are done here.
12279 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12281 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12282 CLSCompliantAttribute.
12283 (all_imported_types): New member holds all imported types from other
12285 (LoadAllImportedTypes): New method fills static table with exported types
12286 from all referenced assemblies.
12287 (Modules): New property returns all assembly modules.
12289 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12291 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12292 throwing a parser error.
12294 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12295 which removes the hardcoded get_/set_ prefixes for properties, as
12296 IL allows for the properties to be named something else.
12300 * expression.cs: Do not override operand before we know if it is
12301 non-null. Fix 56207
12303 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12305 * typemanager.cs: support for pinned variables.
12307 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12309 * decl.cs, typemanager.cs: Avoid using an arraylist
12310 as a buffer if there is only one result set.
12312 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12314 * expression.cs: Make sure you cant call a static method
12315 with an instance expression, bug #56174.
12317 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12319 * class.cs (IsDuplicateImplementation): Improve error reporting to
12320 flag 663 (method only differs in parameter modifier).
12322 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12323 in preprocessor directives.
12325 * location.cs (LookupFile): Allow for the empty path.
12327 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12328 better approach for some of that patch, but its failing with the
12329 CharSet enumeration. For now try/catch will do.
12331 * typemanager.cs: Do not crash if a struct does not have fields.
12334 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12336 * expression.cs: cs0213, cant fix a fixed expression.
12339 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12341 * cs-parser.jay: detect invalid embeded statements gracefully.
12344 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12346 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12349 the invocation type may not be a subclass of the tye of the item/
12350 The type of the item must be a subclass of the invocation item.
12355 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12357 * attribute.cs: Added methods to get a string and a bool from an
12358 attribute. Required to information from AssemblyKeyFileAttribute,
12359 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12360 * codegen.cs: Modified AssemblyName creation to include support for
12361 strongnames. Catch additional exceptions to report them as CS1548.
12362 * compiler.csproj: Updated include CryptoConvert.cs.
12363 * compiler.csproj.user: Removed file - user specific configuration.
12364 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12365 Mono.Security assembly. The original class is maintained and tested in
12366 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12367 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12368 like CSC 8.0 (C# v2) supports.
12369 * Makefile: Added CryptoConvert.cs to mcs sources.
12370 * rootcontext.cs: Added new options for strongnames.
12372 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12374 * driver.cs: For --expect-error, report error code `2'
12375 if the program compiled with no errors, error code `1' if
12376 it compiled with an error other than the one expected.
12378 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12380 * compiler.csproj: Updated for Visual Studio .NET 2003.
12381 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12382 * compiler.sln: Updated for Visual Studio .NET 2003.
12384 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12386 * expression.cs: Fix bug #47234. We basically need to apply the
12387 rule that we prefer the conversion of null to a reference type
12388 when faced with a conversion to 'object' (csc behaviour).
12390 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12392 * statement.cs: Shorter form for foreach, eliminates
12393 a local variable. r=Martin.
12395 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12397 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12398 checks if we can use brtrue/brfalse to test for 0.
12399 * expression.cs: use the above in the test for using brtrue/brfalse.
12400 cleanup code a bit.
12402 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12404 * expression.cs: Rewrite string concat stuff. Benefits:
12406 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12407 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12408 rather than a concat chain.
12410 * typemanager.cs: Add lookups for more concat overloads.
12412 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12414 * expression.cs: Emit shorter il code for array init.
12431 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12433 * statement.cs: Before, two switch blocks would be merged if the
12434 total size of the blocks (end_item - begin_item + 1) was less than
12435 two times the combined sizes of the blocks.
12437 Now, it will only merge if after the merge at least half of the
12442 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12444 * class.cs : csc build fix for GetMethods(). See bug #52503.
12446 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12448 * expression.cs: Make sure fp comparisons work with NaN.
12449 This fixes bug #54303. Mig approved this patch a long
12450 time ago, but we were not able to test b/c the runtime
12453 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12455 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12457 2004-03-19 Martin Baulig <martin@ximian.com>
12459 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12460 two overloads may unify for some type parameter substitutions and
12461 report a CS0408 if appropriate.
12463 2004-03-19 Martin Baulig <martin@ximian.com>
12465 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12466 error here and not in our caller.
12468 2004-03-19 Martin Baulig <martin@ximian.com>
12470 * interface.cs: Completely killed this file.
12471 (Interface): We're now a TypeContainer and live in class.cs.
12473 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12474 argument; we're now also called for interfaces.
12475 (TypeContainer.DefineMembers): Allow this method being called
12477 (TypeContainer.GetMethods): New public method; formerly known as
12478 Interface.GetMethod(). This is used by PendingImplementation.
12479 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12480 it's now private and non-static.
12481 (Interface): Moved this here; it's now implemented similar to
12483 (Method, Property, Event, Indexer): Added `bool is_interface'
12484 argument to their .ctor's.
12485 (MemberBase.IsInterface): New public field.
12487 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12488 instances instead of InterfaceMethod, InterfaceProperty, etc.
12489 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12490 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12492 2004-03-19 Martin Baulig <martin@ximian.com>
12494 * class.cs (MethodCore.IsDuplicateImplementation): New private
12495 method which does the CS0111 checking.
12496 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12497 Use IsDuplicateImplementation().
12499 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12501 * decl.cs (FindMemberToOverride): New method to find the correct
12502 method or property to override in the base class.
12504 - Make Method/Property use the above method to find the
12505 version in the base class.
12506 - Remove the InheritableMemberSignatureCompare as it is now
12509 This patch makes large code bases much faster to compile, as it is
12510 O(n) rather than O(n^2) to do this validation.
12512 Also, it fixes bug 52458 which is that nested classes are not
12513 taken into account when finding the base class member.
12515 Reviewed/Approved by Martin.
12517 2004-03-17 Martin Baulig <martin@ximian.com>
12519 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12520 of type arguments into account; use the `real_num_type_args'
12521 approach like in DoResolveAsTypeStep().
12523 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12526 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12528 * interface.cs: In all interface classes removed redundant
12529 member initialization.
12531 2004-03-16 Martin Baulig <martin@ximian.com>
12533 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12535 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12537 * decl.cs (DefineTypeAndParents): New helper method to define a
12538 type's containers before the type itself is defined; This is a
12539 bug exposed by the recent changes to Windows.Forms when an
12540 implemented interface was defined inside a class that had not been
12543 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12545 (Check): Loop correctly to report errors modifiers
12546 (UNSAFE was not in the loop, since it was the same as TOP).
12548 * interface.cs: Every interface member now takes a ModFlags,
12549 instead of a "is_new" bool, which we set on the base MemberCore.
12551 Every place where we called "UnsafeOk" in the interface, now we
12552 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12553 the unsafe settings from the member declaration instead of the
12554 container interface.
12556 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12558 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12559 `set_indexer_name' to the pending bits (one per type).
12561 We fixed a bug today that was picking the wrong method to
12562 override, since for properties the existing InterfaceMethod code
12563 basically ignored the method name. Now we make sure that the
12564 method name is one of the valid indexer names.
12566 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12568 * support.cs (SeekableStreamReader): Keep track of stream byte
12569 positions and don't mix them with character offsets to the buffer.
12571 Patch from Gustavo Giráldez
12573 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12575 * interface.cs (InterfaceSetGetBase): Removed double member
12576 initialization, base class does it as well.
12578 2004-03-13 Martin Baulig <martin@ximian.com>
12580 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12581 when compiling corlib.
12583 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12585 * convert.cs (ExplicitConversion): We were reporting an error on
12586 certain conversions (object_type source to a value type, when the
12587 expression was `null') before we had a chance to pass it through
12588 the user defined conversions.
12590 * driver.cs: Replace / and \ in resource specifications to dots.
12593 * class.cs: Add check for duplicate operators. Fixes 52477
12595 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12597 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12598 that are in the middle of the statements, not only at the end.
12601 * class.cs (TypeContainer.AddField): No longer set the
12602 `HaveStaticConstructor' flag, now we call it
12603 `UserDefineStaticConstructor' to diferentiate the slightly
12604 semantic difference.
12606 The situation is that we were not adding BeforeFieldInit (from
12607 Modifiers.TypeAttr) to classes that could have it.
12608 BeforeFieldInit should be set to classes that have no static
12613 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12615 And most importantly Zoltan's comment:
12617 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12619 "I think beforefieldinit means 'it's ok to initialize the type sometime
12620 before its static fields are used', i.e. initialization does not need
12621 to be triggered by the first access to the type. Setting this flag
12622 helps the JIT to compile better code, since it can run the static
12623 constructor at JIT time, and does not need to generate code to call it
12624 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12625 this flag for lots of classes like String.
12627 csc sets this flag if the type does not have an explicit static
12628 constructor. The reasoning seems to be that if there are only static
12629 initalizers for a type, and no static constructor, then the programmer
12630 does not care when this initialization happens, so beforefieldinit
12633 This bug prevents the AOT compiler from being usable, since it
12634 generates so many calls to mono_runtime_class_init that the AOT code
12635 is much slower than the JITted code. The JITted code is faster,
12636 because it does not generate these calls if the vtable is type is
12637 already initialized, which is true in the majority of cases. But the
12638 AOT compiler can't do this."
12640 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12642 * class.cs (MethodData.Emit): Refactor the code so symbolic
12643 information is generated for destructors; For some reasons we
12644 were taking a code path that did not generate symbolic information
12647 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12649 * class.cs: Create a Constructor.CheckBase method that
12650 takes care of all validation type code. The method
12651 contains some code that was moved from Define.
12653 It also includes new code that checks for duplicate ctors.
12654 This fixes bug #55148.
12656 2004-03-09 Joshua Tauberer <tauberer@for.net>
12658 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12659 a { ... }-style array creation invokes EmitStaticInitializers
12660 which is not good for reference-type arrays. String, decimal
12661 and now null constants (NullCast) are not counted toward
12662 static initializers.
12664 2004-03-05 Martin Baulig <martin@ximian.com>
12666 * location.cs (SourceFile.HasLineDirective): New public field;
12667 specifies whether the file contains or is referenced by a "#line"
12669 (Location.DefineSymbolDocuments): Ignore source files which
12670 either contain or are referenced by a "#line" directive.
12672 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12674 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12675 direct access to our parent, so check the method inline there.
12677 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12679 * expression.cs (Invocation.EmitCall): Miguel's last commit
12680 caused a regression. If you had:
12685 In Foo the implict this would be null.
12687 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12689 * expression.cs (Invocation.EmitCall): If the method is not
12690 virtual, do not emit a CallVirt to it, use Call.
12692 * typemanager.cs (GetFullNameSignature): Improve the method to
12693 cope with ".ctor" and replace it with the type name.
12695 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12696 as an argument the ConstructorBuilder where it is being defined,
12697 to catch the recursive constructor invocations.
12699 2004-03-16 Martin Baulig <martin@ximian.com>
12701 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12702 ConstructedType, call ResolveType() on it to get the type rather
12703 than just using `expr.Type'.
12705 2004-03-16 Martin Baulig <martin@ximian.com>
12707 * generics.cs (ConstructedType.GetMemberAccess): Take the
12708 EmitContext instead on the TypeExpr and use
12709 ec.TypeContainer.CurrentType/ec.ContainerType.
12711 2004-03-16 Martin Baulig <martin@ximian.com>
12713 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12714 parameters before aliases.
12716 2004-03-16 Martin Baulig <martin@ximian.com>
12718 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12719 New oublic function; checks whether two generic instances may become
12720 equal under some instantiations (26.3.1).
12722 * class.cs (TypeContainer.Define): Call
12723 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12726 2004-03-16 Martin Baulig <martin@ximian.com>
12728 * class.cs (TypeContainer.GetClassBases): Moved
12729 Error_TypeParameterAsBase() here and also check whether the base
12730 class is not an attribute.
12732 2004-03-16 Martin Baulig <martin@ximian.com>
12734 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12736 2004-03-16 Martin Baulig <martin@ximian.com>
12738 * class.cs (Error_TypeParameterAsBase): Use correct error number
12741 2004-03-16 Martin Baulig <martin@ximian.com>
12743 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12746 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12749 2004-03-15 Martin Baulig <martin@ximian.com>
12751 * typemanager.cs (TypeManager.GetFullName): New public method.
12752 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12753 argument; only return members with the correct number of type
12755 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12756 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12757 whether the number of type arguments matches.
12759 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12760 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12762 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12763 field; it's set by the protected .ctor when we're actually a
12764 GenericMemberAccess.
12765 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12766 arguments and pass it to MemberLookupFinal ().
12768 * ecore.cs (Expression.MemberLookup): Added `int
12769 num_type_arguments' argument; only return members with the correct
12770 number of type arguments.
12771 (Expression.MemberLookupFailed): Check whether the MemberLookup
12772 failed because we did not have the correct number of type
12773 arguments; report CS0305 in this case.
12775 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12776 `e.ResolveAsTypeTerminal()' already did so.
12778 2004-03-15 Martin Baulig <martin@ximian.com>
12780 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12781 we're a ConstructedType; in this case, the caller must report an
12782 error (for instance CS0131).
12784 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12785 (TypeArguments.Resolve): Actually report errors here.
12787 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12789 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12790 `set_indexer_name' to the pending bits (one per type).
12792 We fixed a bug today that was picking the wrong method to
12793 override, since for properties the existing InterfaceMethod code
12794 basically ignored the method name. Now we make sure that the
12795 method name is one of the valid indexer names.
12797 2004-03-15 Martin Baulig <martin@ximian.com>
12799 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12800 for generic instances.
12802 2004-03-13 Martin Baulig <martin@ximian.com>
12804 * class.cs (TypeContainer.DefineType): Call
12805 TypeManager.AddUserType() immediately after creating the
12806 TypeBuilder; pass all type parameters when creating the
12809 * decl.cs (DeclSpace.FindNestedType): New public method.
12810 (DeclSpace.FindType): Added `int num_type_args' argument; only
12811 return types with the correct number of type parameters.
12812 (DeclSpace.CountTypeParams): New public property.
12814 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12815 the number of type parameters; defaults to zero.
12817 * generic.cs (TypeArguments.Count): New public property.
12818 (ConstructedType.DoResolveAsTypeStep): First call
12819 ds.FindNestedType() to find out whether we're nested in the
12820 current generic type; in this case, we inherit all type parameters
12821 from the current class.
12823 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12824 num_type_args' argument.
12825 (RootContext.LookupType): Added overloaded version which takes the
12826 number of type arguments; only return types with the correct
12827 number of type arguments.
12829 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12830 checks whether `Type t' has `int num_type_args'.
12832 2004-03-13 Martin Baulig <martin@ximian.com>
12834 * generic.cs (GenericMethod.DefineType): New method; calls
12835 DefineType() on all the type parameters.
12837 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12838 (MethodData.Define): If we're a generic method, call
12839 GenericMethod.DefineType() to define the type parameters.
12841 2004-03-10 Martin Baulig <martin@ximian.com>
12843 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12844 instead of IsAssignableFrom.
12846 2004-03-10 Martin Baulig <martin@ximian.com>
12848 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12850 * support.cs (ParameterData.HasArrayParameter): New property.
12851 (ReflectionParameters.ctor): Take a MethodBase instead of a
12852 ParameterInfo[]. If we have any type parameters, get the generic
12853 method definition and ask it whether we have variable arguments.
12855 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12857 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12858 routines to check if a type is an enumerable/enumerator allow
12859 classes that implement the IEnumerable or IEnumerator interfaces.
12861 * class.cs (Property, Operator): Implement IIteratorContainer, and
12862 implement SetYields.
12864 (Property.Define): Do the block swapping for get_methods in the
12865 context of iterators. We need to check if Properties also
12866 include indexers or not.
12868 (Operator): Assign the Block before invoking the
12869 OperatorMethod.Define, so we can trigger the Iterator code
12872 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12873 Property and Operator classes are not created when we parse the
12874 declarator but until we have the block completed, so we use a
12875 singleton SimpleIteratorContainer.Simple to flag whether the
12876 SetYields has been invoked.
12878 We propagate this setting then to the Property or the Operator to
12879 allow the `yield' to function.
12881 2004-02-25 Marek Safar <marek.safar@seznam.cz>
12883 * codegen.cs: Implemented attribute support for modules.
12884 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
12885 Assembly/Module functionality.
12887 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
12888 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
12889 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
12891 2004-02-16 Marek Safar <marek.safar@seznam.cz>
12893 * interface.cs (FindMembers): The operation is performed on all base
12894 interfaces and not only on the first. It is required for future CLS Compliance patch.
12896 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
12898 * statement.cs, codegen.cs:
12899 This patch deals with patterns such as:
12901 public class List : IEnumerable {
12903 public MyEnumerator GetEnumerator () {
12904 return new MyEnumerator(this);
12907 IEnumerator IEnumerable.GetEnumerator () {
12911 public struct MyEnumerator : IEnumerator {
12916 Before, there were a few things we did wrong:
12917 1) we would emit callvirt on a struct, which is illegal
12918 2) we emited ldarg when we needed to emit ldarga
12919 3) we would mistakenly call the interface methods on an enumerator
12920 type that derived from IEnumerator and was in another assembly. For example:
12922 public class MyEnumerator : IEnumerator
12924 Would have the interface methods called, even if there were public impls of the
12925 method. In a struct, this lead to invalid IL code.
12927 2004-02-11 Marek Safar <marek.safar@seznam.cz>
12929 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
12932 * delegate.cs (Define): Fixed crash when delegate type is undefined.
12934 2004-02-11 Miguel de Icaza <miguel@ximian.com>
12936 * cs-parser.jay: Fix small regression: we were not testing V2
12937 compiler features correctly.
12939 * interface.cs: If the emit context is null, then create one
12941 2004-02-09 Marek Safar <marek.safar@seznam.cz>
12943 * decl.cs (GetSignatureForError): New virtual method to get full name
12944 for error messages.
12946 * attribute.cs (IAttributeSupport): New interface for attribute setting.
12947 Now it is possible to rewrite ApplyAttributes method to be less if/else.
12949 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
12950 Duplicated members and code in these classes has been removed.
12951 Better encapsulation in these classes.
12953 2004-02-07 Miguel de Icaza <miguel@ximian.com>
12955 * assign.cs (Assign.DoResolve): When dealing with compound
12956 assignments, there is a new rule in ECMA C# 2.4 (might have been
12957 there before, but it is documented here) that states that in:
12961 If b is of type int, and the `op' is a shift-operator, then the
12962 above is evaluated as:
12966 * expression.cs (Binary.ResolveOperator): Instead of testing for
12967 int/uint/long/ulong, try to implicitly convert to any of those
12968 types and use that in pointer arithmetic.
12970 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
12971 method to print information for from the type, not from the
12972 null-method we were given.
12974 2004-02-01 Duncan Mak <duncan@ximian.com>
12976 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
12977 parsing for cmd, fixes bug #53694.
12979 2004-02-04 Marek Safar <marek.safar@seznam.cz>
12981 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
12982 in the member name duplication tests. Property and operator name duplication
12983 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
12985 2004-02-03 Marek Safar <marek.safar@seznam.cz>
12987 * interface.cs (PopulateMethod): Fixed crash when interface method
12988 returns not existing type (error test cs0246-3.cs).
12990 2004-02-02 Ravi Pratap M <ravi@ximian.com>
12992 * cs-parser.jay (interface_accessors): Re-write actions to also
12993 store attributes attached to get and set methods. Fix spelling
12996 (inteface_property_declaration): Modify accordingly.
12998 (InterfaceAccessorInfo): New helper class to store information to pass
12999 around between rules that use interface_accessors.
13001 * interface.cs (Emit): Apply attributes on the get and set
13002 accessors of properties and indexers too.
13004 * attribute.cs (ApplyAttributes): Modify accordingly to use the
13005 right MethodBuilder when applying attributes to the get and set accessors.
13007 2004-01-31 Miguel de Icaza <miguel@ximian.com>
13009 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
13011 2004-01-26 Miguel de Icaza <miguel@ximian.com>
13013 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
13015 2004-01-25 Miguel de Icaza <miguel@ximian.com>
13017 * cs-parser.jay: Remove YIELD token, instead use the new grammar
13018 changes that treat `yield' specially when present before `break'
13019 or `return' tokens.
13021 * cs-tokenizer.cs: yield is no longer a keyword.
13023 2004-01-23 Marek Safar <marek.safar@seznam.cz>
13025 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
13026 setting for default constructors.
13027 For default constructors are almost every time set wrong Modifier. The
13028 generated IL code has been alright. But inside mcs this values was
13029 wrong and this was reason why several of my CLS Compliance tests
13032 2004-02-27 Martin Baulig <martin@ximian.com>
13034 * generics.cs (ConstructedType.ResolveType): Make the nested type
13035 stuff actually work.
13037 2004-02-25 Martin Baulig <martin@ximian.com>
13039 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
13040 property; returns the type parameters just from the current type,
13041 ie. with the ones from outer classes.
13042 (DeclSpace.LookupGeneric): First search in the current class, then
13044 (DeclSpace.initialize_type_params): When hiding a type parameter
13045 from an outer class, put it into the `type_param_list' anyways.
13047 * expression.cs (MemberAccess.expr): Made this field protected.
13049 * class.cs (TypeContainer.Define): The `CurrentType' just contains
13050 the type parameters from the current class.
13052 * generic.cs (ConstructedType.ResolveType): Support nested generic
13053 types by taking the type parameters which we inherit from outer
13054 classes into account.
13055 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
13056 support for nested generic types.
13058 2004-02-23 Martin Baulig <martin@ximian.com>
13060 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
13061 field and check whether we're nested inside a generic type.
13062 (DeclSpace.ResolveType): If we're resolving to a generic type
13063 definition, create a ConstructedType and return its resolved type.
13064 (DeclSpace.initialize_type_params): New private method;
13065 initializes the `type_param_list' field from the type parameters
13066 from this and all enclosing classes.
13067 (DeclSpace.TypeParameters): Call initialize_type_params() unless
13068 we're already initialized.
13070 2004-02-23 Martin Baulig <martin@ximian.com>
13072 * class.cs (Method.Define): Create the generic method before
13073 calling DoDefine().
13074 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
13075 the TypeContainer one); we use this for generic methods.
13077 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
13078 parent's TypeBuilder.
13080 2004-02-18 Martin Baulig <martin@ximian.com>
13082 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
13083 to check for equality.
13085 2004-02-05 Martin Baulig <martin@ximian.com>
13087 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
13088 `ec.TypeContainer.CurrentType', use it instead of
13089 `ec.ContainerType' to check whether we're in the type's ctor.
13091 2004-01-29 Martin Baulig <martin@ximian.com>
13093 * expression.cs (Invocation.DoResolve): If we're a
13094 `ConstructedType', then we're actually a generic method, so
13095 rewrite the expr as a GenericMemberAccess.
13097 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
13098 here; manually parse it into a string.
13100 2004-01-28 Martin Baulig <martin@ximian.com>
13102 * typemanager.cs (TypeManager.IsEqual): New static method.
13103 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
13104 check for equality instead of using `=='.
13106 2004-01-26 Martin Baulig <martin@ximian.com>
13108 * decl.cs (DeclSpace.CurrentType): New public field.
13110 * expression.cs (This.ResolveBase): If we have an
13111 `ec.TypeContainer.CurrentType', use it instead of
13112 `ec.ContainerType'.
13114 * class.cs (TypeContainer.DefineType): If we're a generic type,
13115 create the `CurrentType' (unresolved).
13116 (TypeContainer.GenericType): New private field.
13117 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
13118 it and store it in `GenericType' before creating the MemberCache.
13119 (TypeContainer.GetMembers): If we have a `GenericType', call
13120 TypeManager.FindMembers() on it.
13122 * interface.cs (Interface.GenericType): New private field.
13123 (Interface.DefineType): If we're a generic type, create the
13124 `CurrentType' (unresolved).
13125 (Interface.DefineMembers): If we have a `CurrentType', resolve it
13126 and store it in `GenericType' before creating the MemberCache.
13127 (Interface.GetMembers): If we have a `GenericType', call
13128 TypeManager.FindMembers() on it.
13130 2004-01-22 Martin Baulig <martin@ximian.com>
13132 * cs-parser.jay (namespace_or_type_name): Return an Expression,
13133 not a QualifiedIdentifier. This is what `type_name_expression'
13134 was previously doing.
13135 (type_name_expression): Removed; the code is now in
13136 `namespace_or_type_name'.
13137 (qualified_identifier): Removed, use `namespace_or_type_name'
13139 (QualifiedIdentifier): Removed this class.
13141 2004-01-22 Martin Baulig <martin@ximian.com>
13143 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
13144 not a string as alias name.
13146 2004-01-21 Miguel de Icaza <miguel@ximian.com>
13148 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
13149 #52730 bug, and instead compute correctly the need to use a
13150 temporary variable when requesting an address based on the
13151 static/instace modified of the field and the constructor.
13153 2004-01-21 Martin Baulig <martin@ximian.com>
13155 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
13156 class and namespace before looking up aliases. Fixes #52517.
13158 2004-01-21 Martin Baulig <martin@ximian.com>
13160 * flowanalysis.cs (UsageVector.Merge): Allow variables being
13161 assinged in a 'try'; fixes exception4.cs.
13163 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13164 * class.cs : Implemented parameter-less constructor for TypeContainer
13166 * decl.cs: Attributes are now stored here. New property OptAttributes
13168 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
13170 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
13172 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13174 * typemanager.cs (CSharpSignature): Now reports also inner class name.
13175 (CSharpSignature): New method for indexer and property signature.
13177 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13179 * pending.cs (IsVirtualFilter): Faster implementation.
13181 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13183 * typemanager.cs: Avoid inclusion of same assembly more than once.
13185 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13187 * cs-parser.jay: Fixed problem where the last assembly attribute
13188 has been applied also to following declaration (class, struct, etc.)
13190 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13192 * class.cs: Added error CS0538, CS0539 reporting.
13193 Fixed crash on Microsoft runtime when field type is void.
13195 * cs-parser.jay: Added error CS0537 reporting.
13197 * pending.cs: Added error CS0535 reporting.
13198 Improved error report for errors CS0536, CS0534.
13200 2004-01-20 Miguel de Icaza <miguel@ximian.com>
13202 Merge a few bits from the Anonymous Method MCS tree.
13204 * statement.cs (ToplevelBlock): New class for toplevel methods,
13205 will hold anonymous methods, lifted variables.
13207 * cs-parser.jay: Create toplevel blocks for delegates and for
13208 regular blocks of code.
13210 2004-01-20 Martin Baulig <martin@ximian.com>
13212 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
13213 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
13214 and `NeedExplicitReturn'; added `IsLastStatement'.
13215 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
13216 have a `ReturnLabel' or we're not unreachable.
13218 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
13219 child's reachability; don't just override ours with it. Fixes
13220 #58058 (lluis's example).
13221 (FlowBranching): Added public InTryOrCatch(), InCatch(),
13222 InFinally(), InLoop(), InSwitch() and
13223 BreakCrossesTryCatchBoundary() methods.
13225 * statement.cs (Return): Do all error checking in Resolve().
13226 Unless we are the last statement in a top-level block, always
13227 create a return label and jump to it.
13228 (Break, Continue): Do all error checking in Resolve(); also make
13229 sure we aren't leaving a `finally'.
13230 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
13231 statement in a top-level block.
13232 (Block.Flags): Added `IsDestructor'.
13233 (Block.IsDestructor): New public property.
13235 2004-01-20 Martin Baulig <martin@ximian.com>
13237 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
13239 2004-01-20 Martin Baulig <martin@ximian.com>
13241 * statement.cs (Statement.ResolveUnreachable): New public method.
13242 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
13243 (Block.Resolve): Resolve unreachable statements.
13245 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13247 * expression.cs: We need to fix the case where we do
13248 not have a temp variable here.
13250 * assign.cs: Only expression compound assignments need
13251 temporary variables.
13253 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13255 * flowanalysis.cs: Reduce memory allocation in a few ways:
13256 - A block with no variables should not allocate a bit
13258 - A method with no out parameters does not need any tracking
13259 for assignment of the parameters, so we need not allocate
13262 public readonly Type[] VariableTypes;
13263 public readonly string[] VariableNames;
13264 Are redundant. The data is already stored in the variable
13265 map, so we need not allocate another array for it.
13266 - We need to add alot of checks for if (params | locals) == null
13267 due to the first two changes.
13269 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13271 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13272 implement IMemoryLocation, we store a copy on a local variable and
13273 take the address of it. Patch from Benjamin Jemlich
13275 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13276 to use a special "type_name_expression" rule which reduces the
13277 number of "QualifiedIdentifier" classes created, and instead
13278 directly creates MemberAccess expressions.
13280 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13282 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13283 that fixes #52853. Null literal assignment to ValueType
13285 * class.cs (MethodData.Emit): Instead of checking the name of the
13286 method to determine if its a destructor, create a new derived
13287 class from Method called Destructor, and test for that.
13289 * cs-parser.jay: Create a Destructor object instead of a Method.
13291 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13295 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13297 * expression.cs (Binary.ResolveOperator): Perform an implicit
13298 conversion from MethodGroups to their delegate types on the
13299 Addition operation.
13301 * delegate.cs: Introduce a new class DelegateCreation that is the
13302 base class for `NewDelegate' and `ImplicitDelegateCreation',
13303 factor some code in here.
13305 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13306 conversion from MethodGroups to compatible delegate types.
13308 * ecore.cs (Expression.Resolve): Do not flag error 654
13309 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13310 we allow conversions from MethodGroups to delegate types now.
13312 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13313 assignments in v2 either.
13315 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13317 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13318 static read-only fields in ctors.
13320 Applied patch from Benjamin Jemlich
13322 * expression.cs (UnaryMutator): Avoid leaking local variables.
13324 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13326 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13327 here to return true, as they can be used like this:
13329 (XXX) int.MEMBER ()
13331 Fixed 49836 and all the other dups
13333 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13335 * driver.cs: Implement /win32res and /win32icon.
13337 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13339 * cs-parser.jay: Add a rule to improve error handling for the
13340 common mistake of placing modifiers after the type.
13342 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13344 * cs-parser.jay (interface_event_declaration): Catch
13345 initialization of events on interfaces, and report cs0068
13347 * cs-parser.jay (interface_event_declaration): Catch
13348 initialization of events.
13350 * ecore.cs: Better report missing constructors.
13352 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13353 the error reporting done in the wrong place. Fix.
13355 * expression.cs (Binary.ResolveOperator): Catch the
13356 operator + (E x, E y) error earlier, and later allow for implicit
13357 conversions in operator +/- (E e, U x) from U to the underlying
13360 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13361 52596, if the container class is abstract, the default constructor
13362 is protected otherwise its public (before, we were always public).
13364 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13367 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13368 Jemlich that fixes bug #52597, MCS was generating invalid code for
13369 idisposable structs. Thanks to Ben for following up with this
13372 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13374 * driver.cs: Allow assemblies without code to be generated, fixes
13377 2004-01-07 Nick Drochak <ndrochak@gol.com>
13379 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13381 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13383 * cs-parser.jay: Add rules to improve error reporting if fields or
13384 methods are declared at the namespace level (error 116)
13386 * Add rules to catch event add/remove
13388 2004-01-04 David Sheldon <dave-mono@earth.li>
13390 * expression.cs: Added matching ")" to error message for
13393 2004-01-03 Todd Berman <tberman@gentoo.org>
13395 * ecore.cs, attribute.cs:
13396 Applying fix from #52429.
13398 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13400 * ecore.cs, expression.cs, statement.cs:
13401 Total rewrite of how we handle branching. We
13402 now handle complex boolean expressions with fewer
13403 jumps. As well if (x == 0) no longer emits a ceq.
13405 if (x is Foo) is much faster now, because we generate
13408 Overall, we get a pretty big improvement on our benchmark
13409 tests. The code we generate is smaller and more readable.
13411 I did a full two-stage bootstrap. The patch was reviewed
13412 by Martin and Miguel.
13414 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13416 * cs-parser.jay: Make primary_expression not take a QI.
13417 we dont need this because the member_access rule covers
13418 us here. So we replace the rule with just IDENTIFIER.
13420 This has two good effects. First, we remove a s/r conflict.
13421 Second, we allocate many fewer QualifiedIdentifier objects.
13423 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13425 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13426 set the correct information via SRE. This prevents
13427 hanging on the MS runtime. Fixes #29374.
13429 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13431 * convert.cs: correctly handle conversions to value types
13432 from Enum and ValueType as unboxing conversions.
13434 Fixes bug #52569. Patch by Benjamin Jemlich.
13436 2004-01-02 Ravi Pratap <ravi@ximian.com>
13438 * expression.cs (BetterConversion): Prefer int -> uint
13439 over int -> ulong (csc's behaviour). This fixed bug #52046.
13441 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13443 * decl.cs (MemberCache.FindMembers): now returns a
13446 * typemanager.cs: In general, go with with ^^.
13447 (CopyNewMethods): take an IList.
13448 (RealMemberLookup): Only allocate an arraylist
13449 if we copy from two sets of methods.
13451 This change basically does two things:
13452 1) Fewer array lists allocated due to CopyNewMethods.
13453 2) the explicit cast in MemberList costed ALOT.
13455 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13457 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13458 a hashtable to avoid needless string allocations when an identifier is
13459 used more than once (the common case).
13461 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13463 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13464 is broken, it will not return anything. So, we
13465 have to use the information we have in mcs to
13468 * typemanager.cs: Add a cache for GetInterfaces,
13469 since this will now be used more often (due to ^^)
13471 (GetExplicitInterfaces) New method that gets the
13472 declared, not effective, interfaces on a type
13473 builder (eg, if you have interface IFoo, interface
13474 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13477 This patch makes MCS able to bootstrap itself on
13480 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13482 * expression.cs: Remove the Nop's that Miguel put
13485 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13487 * report.cs, codegen.cs: Give the real stack trace to
13488 the error when an exception is thrown.
13490 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13492 * decl.cs: only allocate hashtables for ifaces if
13495 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13497 * expression.cs: fix the error from cs0121-2.cs
13498 (a parent interface has two child interfaces that
13499 have a function with the same name and 0 params
13500 and the function is called through the parent).
13502 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13504 * class.cs, rootcontext.cs, typmanager.cs: do not
13507 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13509 * codegen.cs: remove stack for the ec flow branching.
13510 It is already a linked list, so no need.
13512 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13514 * Makefile: Allow custom profiler here.
13516 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13518 * typemanager.cs (LookupType):
13519 - Use a static char [], because split takes
13520 a param array for args, so it was allocating
13522 - Do not store true in a hashtable, it boxes.
13524 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13526 * flowanalysis.cs: bytify common enums.
13528 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13530 * modifiers.cs: Add a new set of flags for the
13531 flags allowed on explicit interface impls.
13532 * cs-parser.jay: catch the use of modifiers in
13533 interfaces correctly.
13534 * class.cs: catch private void IFoo.Blah ().
13536 All related to bug #50572.
13538 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13540 * decl.cs: Rewrite the consistant accessability checking.
13541 Accessability is not linear, it must be implemented in
13542 a tableish way. Fixes #49704.
13544 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13546 * expression.cs: Handle negation in a checked context.
13547 We must use subtraction from zero. Fixes #38674.
13549 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13551 * class.cs: Ignore static void main in DLLs.
13552 * rootcontext.cs: Handle the target type here,
13553 since we are have to access it from class.cs
13554 * driver.cs: account for the above.
13556 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13558 * report.cs: Give line numbers and files if available.
13560 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13562 * driver.cs: Implement /addmodule.
13564 * typemanager.cs: Change 'modules' field so it now contains Modules not
13567 2003-12-20 Martin Baulig <martin@ximian.com>
13569 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13570 (FieldBase.IsAssigned): Removed this field.
13571 (FieldBase.SetAssigned): New public method.
13572 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13574 2003-12-20 Martin Baulig <martin@ximian.com>
13576 * expression.cs (LocalVariableReference.DoResolve): Don't set
13577 `vi.Used' if we're called from DoResolveLValue().
13579 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13580 returns the usage vector it just merged into the current one -
13581 pass this one to UsageWarning().
13582 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13583 of the `EmitContext', don't call this recursively on our children.
13585 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13587 * driver.cs: Implement /target:module.
13589 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13591 * support.cs (CharArrayHashtable): New helper class.
13593 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13594 char arrays, not strings, so we can avoid creating a string in
13595 consume_identifier if the identifier is a keyword.
13597 2003-12-16 Martin Baulig <martin@ximian.com>
13599 * statement.cs (LocalInfo.Assigned): Removed this property.
13600 (LocalInfo.Flags): Removed `Assigned'.
13601 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13602 and uses flow analysis.
13603 (Block.UsageWarning): Made this method private.
13604 (Block.Resolve): Call UsageWarning() if appropriate.
13606 * expression.cs (LocalVariableReference.DoResolve): Always set
13607 LocalInfo.Used here.
13609 2003-12-13 Martin Baulig <martin@ximian.com>
13611 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13612 any value here; we're now using flow analysis to figure out
13613 whether a statement/block returns a value.
13615 2003-12-13 Martin Baulig <martin@ximian.com>
13617 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13619 (FlowBranching.MergeFinally): Don't call
13620 `branching.CheckOutParameters()' here, this is called in
13622 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13623 when adding the `finally' vector.
13625 2003-12-13 Martin Baulig <martin@ximian.com>
13628 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13629 actually work and also fix #48962.
13631 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13633 * decl.cs: Do not check System.Object for nested types,
13634 since we know it does not have any. Big bang for buck:
13637 Run 1: 8.35 seconds
13638 Run 2: 8.32 seconds
13639 corlib: 17.99 seconds
13641 Run 1: 8.17 seconds
13642 Run 2: 8.17 seconds
13643 corlib: 17.39 seconds
13645 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13647 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13648 time we are returning 0 members, so we save alot here.
13650 2003-12-11 Martin Baulig <martin@ximian.com>
13652 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13653 `MergeChild()', also just take the `FlowBranching' as argument;
13654 call Merge() on it and return the result.
13655 (FlowBranching.Merge): We don't need to do anything if we just
13658 2003-12-11 Martin Baulig <martin@ximian.com>
13660 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13661 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13662 Maurer for this idea.
13664 2003-12-11 Martin Baulig <martin@ximian.com>
13666 * flowanalysis.cs (MergeResult): This class is now gone; we now
13667 use the `UsageVector' for this. The reason for this is that if a
13668 branching just has one sibling, we don't need to "merge" them at
13669 all - that's the next step to do.
13670 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13673 2003-12-11 Martin Baulig <martin@ximian.com>
13675 Reworked flow analyis and made it more precise and bug-free. The
13676 most important change is that we're now using a special `Reachability'
13677 class instead of having "magic" meanings of `FlowReturns'. I'll
13678 do some more cleanups and optimizations and also add some more
13679 documentation this week.
13681 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13682 largely reworked this class.
13683 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13684 the new `Reachability' class instead of having "magic" values here.
13685 (FlowBranching): We're now using an instance of `Reachability'
13686 instead of having separate `Returns', `Breaks' etc. fields.
13688 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13689 based on flow analysis; ignore the return value of block.Emit ().
13691 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13693 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13694 if they are private.
13696 2003-12-09 Martin Baulig <martin@ximian.com>
13698 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13699 call them directly on the UsageVector.
13701 2003-12-09 Martin Baulig <martin@ximian.com>
13703 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13704 Changed return type from `FlowReturns' to `Reachability'.
13706 2003-12-09 Martin Baulig <martin@ximian.com>
13708 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13709 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13710 `Reachable' fields with a single `Reachability' one.
13712 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13714 * class.cs (FindMembers): Remove foreach's.
13719 Run 1: 8.74 seconds
13720 Run 2: 8.71 seconds
13723 Run 1: 8.64 seconds
13724 Run 2: 8.58 seconds
13727 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13732 This patch does a few things:
13733 1. EmptyStatement is now a singleton, so it is never reallocated.
13734 2. All blah is EmptyStatement constructs have been changed to
13735 blah == EmptyStatement.Value, which is much faster and valid
13736 now that EmptyStatement is a singleton.
13737 3. When resolving a block, rather than allocating a new array for
13738 the non-empty statements, empty statements are replaced with
13739 EmptyStatement.Value
13740 4. Some recursive functions have been made non-recursive.
13741 Mainly the performance impact is from (3), however (1) and (2) are needed for
13742 this to work. (4) does not make a big difference in normal situations, however
13743 it makes the profile look saner.
13748 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13749 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13750 Total memory allocated: 56397 KB
13753 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13754 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13755 Total memory allocated: 55666 KB
13757 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13759 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13760 than the hashtable in a hashtable version
13762 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13763 we always end up concating a string. This results in a huge perf
13764 loss, because many strings have to be tracked by the GC. In this
13765 patch, we first use a hashtable that works with two keys, so that
13766 the strings do not need to be concat'ed.
13770 Run 1: 8.74 seconds
13771 Run 2: 8.71 seconds
13774 Run 1: 8.65 seconds
13775 Run 2: 8.56 seconds
13777 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13779 * Makefile: Add a new target `do-time' that does a quick and simple
13780 profile, leaving easy to parse output.
13782 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13784 * codegen.cs (Init): Create the dynamic assembly with
13785 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13787 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13789 * support.cs: Make the PtrHashtable use only one
13790 instance of its comparer.
13792 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13794 * typemanager.cs: Fix lookup of GetNamespaces.
13796 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13798 * expression.cs: Removed redundant line.
13800 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13801 ArrayLists, use for loops with bounds.
13803 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13806 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13807 arraylists, use for loop with bounds.
13809 The above three changes give us a 0.071 second performance
13810 improvement out of 3.294 seconds down to 3.223. On my machine
13811 the above changes reduced the memory usage by 1,387 KB during
13812 compiler bootstrap.
13814 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13815 QualifiedIdentifiers. Before we created a new string through
13816 concatenation, and mostly later on, the result would be
13817 manipulated by DecomposeQI through string manipulation.
13819 This reduced the compiler memory usage for bootstrapping from
13820 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13821 compile times in 0.05 seconds.
13823 2003-11-28 Dick Porter <dick@ximian.com>
13825 * support.cs: Do string compares with the Invariant culture.
13833 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13834 the comparison is done with the Invariant culture.
13836 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13838 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13839 GetEnumerator method.
13841 (ProbeCollectionType): Iterate starting at the most specific type
13842 upwards looking for a GetEnumerator
13844 * expression.cs: Shift count can be up to 31 for int/uint and 63
13847 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13849 * statement.cs (Block.LookupLabel): Also look for the label on the
13850 children blocks. Use a hash table to keep track of visited
13853 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13854 we actually did transform the other operand, otherwise fall back
13855 to the common codepath that casts to long.
13857 * cs-tokenizer.cs: Use the same code pattern as the int case.
13858 Maybe I should do the parsing myself, and avoid depending on the
13859 Parse routines to get this done.
13861 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13863 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13864 which fixes bug 51347. This time test it.
13866 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13867 attributes for example can not tell the difference between these.
13868 The difference was only a syntax feature of the language.
13870 * attribute.cs: Apply attributes to delegates.
13872 * delegate.cs: Call the apply attributes method.
13874 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13876 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13877 comparing 0 vs Byte.MinValue, not the value
13879 (ImplicitConversionRequired): When reporting a conversion error,
13880 use error 31 to print out the constant error instead of the
13883 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13884 which fixes bug 51347.
13886 2003-11-22 Miguel de Icaza <miguel@ximian.com>
13888 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
13889 which fixes the -warnaserror command line option.
13891 2003-11-21 Miguel de Icaza <miguel@ximian.com>
13893 * cfold.cs (DoNumericPromotions): During constant folding of
13894 additions on UIntConstant, special case intconstants with
13895 IntConstants like we do on the expression binary operator.
13897 2003-11-12 Miguel de Icaza <miguel@ximian.com>
13899 * convert.cs (ImplicitReferenceConversion): We were missing a case
13900 (System.Enum are not value types or class types, so we need to
13901 classify them separatedly).
13903 * driver.cs: We do not support error 2007.
13905 2003-11-12 Jackson Harper <jackson@ximian.com>
13907 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
13908 system directory. Also use the full file name so users can
13909 libraries names mscorlib-o-tron.dll in a non system dir.
13911 2004-01-04 David Sheldon <dave-mono@earth.li>
13913 * expression.cs: Added matching ")" to error message for CS0077.
13915 2003-12-19 Martin Baulig <martin@ximian.com>
13917 * typemanager.cs (TypeManager.IsEqualGenericType): New public
13918 static method; see documentation in the method.
13919 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
13921 * convert.cs (Convert.ImplicitReferenceConversion,
13922 Convert.ImplicitReferenceConversionExists): Add support for
13923 generic type declarations; see gen-36.cs.
13925 2003-12-19 Martin Baulig <martin@ximian.com>
13927 * pending.cs (Pending.InterfaceMethod): Use
13928 `Type.IsAssignableFrom()' instead of `=='.
13930 2003-12-18 Martin Baulig <martin@ximian.com>
13932 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
13935 * convert.cs (Convert.ImplicitStandardConversionExists): Use
13936 `expr_type.Equals (target_type)' instead of `=='.
13938 2003-12-08 Martin Baulig <martin@ximian.com>
13940 * generics.cs (Constraints.Types): Removed.
13941 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
13943 (Constraints.ResolveTypes): New public method; resolves the
13944 TypeExpr's to Type's.
13945 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
13946 longer takes the constraints.
13947 (TypeParameter.DefineMethod): Likewise.
13948 (TypeParameter.DefineType): New public method. Calls
13949 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
13952 2003-12-08 Martin Baulig <martin@ximian.com>
13954 * convert.cs (Convert.ImplicitConversionStandard): Use
13955 `expr_type.Equals (target_type)' instead of `=='.
13957 2003-12-08 Martin Baulig <martin@ximian.com>
13959 * typemanager.cs (TypeManager.GetReferenceType): Call
13960 `Type.MakeByRefType ()'.
13962 2003-12-08 Martin Baulig <martin@ximian.com>
13964 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
13965 just has some special meaning in some situations. For instance,
13966 it is allowed to use `where' as the name of a variable etc.
13968 2003-12-04 Martin Baulig <martin@ximian.com>
13970 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13971 `Type.MakeArrayType()' for array types.
13973 2003-11-18 Miguel de Icaza <miguel@ximian.com>
13975 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
13978 (SizeOf.DoResolve): assign the `type_queried' field. This gets
13981 2003-11-16 Martin Baulig <martin@ximian.com>
13983 * codegen.cs (EmitContext.IsGeneric): Removed.
13985 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
13986 ResolveGeneric() on the DeclSpace.
13988 2003-11-16 Martin Baulig <martin@ximian.com>
13990 * generic.cs (TypeArguments.Resolve):
13991 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
13992 `ResolveType()' on it to get the Type.
13994 2003-11-15 Martin Baulig <martin@ximian.com>
13996 * generic.cs (ConstructedType.GetInterfaces): Override this.
13998 2003-11-14 Martin Baulig <martin@ximian.com>
14000 * interface.cs (Interface.DefineType): Define all type parameters
14001 before adding the interfaces we inherit.
14003 2003-11-11 Martin Baulig <martin@ximian.com>
14005 * generic.cs (ConstructedType.ResolveType): Always call
14006 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
14008 2003-11-10 Martin Baulig <martin@ximian.com>
14010 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
14011 (TypeManager.InitCoreTypes): Initialize them here, but instead of
14012 calling `ResolveType()' on them, directly assign their `Type'.
14014 2003-11-08 Martin Baulig <martin@ximian.com>
14016 * generic.cs (ConstructedType): Override `IsClass' etc.
14018 2003-11-08 Martin Baulig <martin@ximian.com>
14020 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
14021 return value and the `out parent' parameter.
14022 (TypeContainer.DefineType): Moved the CS0644 check into
14023 GetClassBases(). Don't pass the interface types to the
14024 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
14025 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
14027 * ecore.cs (TypeExpr.IsAttribute): New property.
14028 (TypeExpr.GetInterfaces): New method.
14030 * interface.cs (Interface.GetInterfaceTypeByName): Return a
14031 TypeExpr instead of a Type.
14032 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
14033 (Interface.DefineType): Don't pass the interface types to the
14034 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
14035 them later and then call `TypeBulider.AddInterfaceImplementation()'.
14037 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
14038 instead of a `Type[]'.
14039 (TypeManager.RegisterBuilder): Likewise.
14040 (TypeManager.AddUserInterface): Likewise.
14041 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
14042 `Type[]' and also return a `TypeExpr[]'.
14043 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
14045 2003-11-08 Martin Baulig <martin@ximian.com>
14047 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
14050 2003-11-08 Martin Baulig <martin@ximian.com>
14052 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
14053 TypeManager.ResolveExpressionTypes().
14055 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
14056 instead of an Expression.
14057 (TypeExpr): This is now an abstract base class for `TypeExpression'.
14058 (TypeExpression): New public class; formerly known as `TypeExpr'.
14060 * expression.cs (ComposedCast): Derive from TypeExpr.
14062 * typemanager.cs (TypeManager.system_*_expr): These are now
14063 TypExpr's instead of Expression's.
14064 (TypeManager.ResolveExpressionTypes): New public static function;
14065 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
14068 2003-11-06 Miguel de Icaza <miguel@ximian.com>
14070 * expression.cs (New.DoResolve): Do not dereference value that
14071 might be a null return.
14073 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
14074 sure that the constant value has the right type. Fixes an
14075 unreported bug, similar to 50425.
14077 * const.cs (Const.LookupConstantValue): Call
14078 ImplicitStandardConversionExists before doing a conversion to
14079 avoid havng the TypeManager.ChangeType do conversions.
14081 Reduced the number of casts used
14083 (Const.ChangeType): New routine to enable reuse of the constant
14084 type changing code from statement.
14086 * typemanager.cs (ChangeType): Move common initialization to
14087 static global variables.
14091 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
14092 every value type to go through, even if it was void. Fix that.
14094 * cs-tokenizer.cs: Use is_identifier_start_character on the start
14095 character of the define, and the is_identifier_part_character for
14096 the rest of the string.
14098 2003-11-05 Miguel de Icaza <miguel@ximian.com>
14100 * expression.cs (UnaryMutator.EmitCode): When I updated
14101 LocalVariableReference.DoResolve, I overdid it, and dropped an
14102 optimization done on local variable references.
14104 2003-11-04 Miguel de Icaza <miguel@ximian.com>
14106 * ecore.cs: Convert the return from Ldlen into an int.
14108 2003-10-20 Miguel de Icaza <miguel@ximian.com>
14110 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
14111 the accessibility, this is a special case for toplevel non-public
14112 classes (internal for instance).
14114 2003-10-20 Nick Drochak <ndrochak@gol.com>
14116 * ecore.cs: Fix typo and build. Needed another right paren.
14118 2003-10-19 Miguel de Icaza <miguel@ximian.com>
14120 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
14121 `internal' case regular and protected, but not allowing protected
14122 to be evaluated later. Bug 49840
14124 2003-10-15 Miguel de Icaza <miguel@ximian.com>
14126 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
14127 to kb.Nlast, and not the kb.nFirst to isolate the switch
14130 Extract the underlying type, so enumerations of long/ulong are
14131 treated like long/ulong.
14133 2003-10-14 Miguel de Icaza <miguel@ximian.com>
14135 * expression.cs (New): Overload the meaning of RequestedType to
14136 track the possible creation of the NewDelegate type, since
14137 DoResolve is invoked more than once for new constructors on field
14140 See bugs: #48800 and #37014
14142 * cs-parser.jay (declare_local_constants): Take an arraylist
14143 instead of a single constant.
14145 (local_constant_declaration): It should take a
14146 constant_declarators, not a constant_declarator. Fixes 49487
14148 * convert.cs: Fix error report.
14150 2003-10-13 Jackson Harper <jackson@ximian.com>
14152 * typemanager.cs (TypeToCoreType): Add float and double this fixes
14155 2003-11-03 Martin Baulig <martin@ximian.com>
14157 * expression.cs (ArrayAccess.GetStoreOpcode): Added
14158 `out bool has_type_arg'; if set, we need to pass the type to
14160 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
14161 Stelem_Any/Ldelem_Any for generic parameters.
14163 2003-11-02 Martin Baulig <martin@ximian.com>
14165 * expression.cs (Invocation.EmitCall): Use
14166 `TypeManager.IsValueType()' to check whether it's a value type.
14167 Don't set `struct_call' when calling a method on a type parameter.
14169 2003-11-02 Martin Baulig <martin@ximian.com>
14171 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
14172 and removed the TypeBuilder argument.
14174 * typemanager.cs (TypeManager.IsValueType): Return
14175 `t.IsGenericParameter || t.IsValueType'.
14177 2003-10-25 Martin Baulig <martin@ximian.com>
14179 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
14180 call ConstructedType.Resolve() on it.
14182 * generic.cs (ConstructedType.Resolve): Set `type' on success.
14184 2003-10-25 Martin Baulig <martin@ximian.com>
14186 * class.cs (TypeContainer.GetClassBases): Changed
14187 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
14188 CS8214 reporting here.
14189 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
14190 instead of a `Type' for our parent. In case of a recursive
14191 declaration (see tests/gen-23.cs for an example), our parent is a
14192 ConstructedType and it doesn't have its type set. So, first
14193 create our own TypeBuilder, then call constructed.Resolve() to get
14194 the parent's type and finally TypeBuilder.SetParent() it.
14196 * ecore.cs (TypeExpr.Name): New public virtual property.
14199 (ConstructedType): We're now a TypeExpr and not just an Expression.
14200 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
14201 arguments here; this is done later.
14202 (ConstructedType.Resolve): New public method to resolve the type
14203 arguments and bind them.
14205 2003-10-21 Martin Baulig <martin@ximian.com>
14207 * convert.cs: Use `TypeManager.IsValueType' instead of
14208 'type.IsValueType' everywhere.
14210 * typemanager.cs (TypeManager.IsValueType): Return true for type
14211 parameters. The reason for this is that we need to box a type
14212 parameter when converting it to a reference type.
14214 * cs-parser.jay: Added support for default value expressions.
14216 * generics.cs (DefaultValueExpression): New public class.
14218 2003-10-17 Martin Baulig <martin@ximian.com>
14220 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
14221 TypeContainer so we can also use this for Interfaces.
14222 (TypeParameter.Resolve): Likewise.
14224 * interface.cs (Interface.DefineType): Added support for generic
14227 * cs-parser.jay: Added support for generic structs and interfaces.
14229 2003-10-17 Martin Baulig <martin@ximian.com>
14231 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
14232 call generic methods :-)
14234 2003-10-16 Martin Baulig <martin@ximian.com>
14236 * cs-parser.jay (namespace_or_type_name): Only create a
14237 GenericMemberAccess if we actually have type arguments.
14239 2003-10-13 Martin Baulig <martin@ximian.com>
14241 * class.cs (Method.Define): If we're a generic method, call
14242 TypeBuilder.DefineGenericMethod () before resolving
14244 (MethodData): Added .ctor which takes an additional MethodBuilder
14245 argument; this is used for generic methods.
14246 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
14247 we already have a MethodBuilder.
14249 2003-10-10 Martin Baulig <martin@ximian.com>
14251 * class.cs (Method): Added .ctor which takes a `GenericMethod'
14252 instead of a `DeclSpace'. This is used for generic methods.
14254 * cs-parser.jay (method_header): Added support for generic
14255 methods; create a `GenericMethod' instance and pass it to the
14256 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
14257 parameters and locals.
14259 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
14260 since we already have the location. Check whether we're a generic
14261 type declaration or a generic method and create the correct type
14264 * generic.cs (TypeParameter.DefineMethod): New public method.
14265 (GenericMethod): New public class; derives from DeclSpace and is
14266 used for generic methods.
14268 2003-10-09 Martin Baulig <martin@ximian.com>
14270 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14272 (MethodCore.DoDefineParameters): Removed the TypeContainer
14273 argument; use the DeclSpace which was passed to the .ctor instead.
14274 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14275 TypeContainer; we only need a DeclSpace here.
14277 2003-10-09 Martin Baulig <martin@ximian.com>
14279 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14281 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14282 EmitContext's .ctor.
14284 2003-10-09 Martin Baulig <martin@ximian.com>
14286 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14287 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14288 AsAccessible(), moved them as well.
14290 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14292 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14294 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14295 generation for >=, as spotted by Paolo, bug 48679.
14296 Patch from David Waite.
14298 * cs-tokenizer.cs: Add handling for #pragma.
14300 * cs-parser.jay: Allow for both yield and yield return in the
14301 syntax. The anti-cobolization of C# fight will go on!
14303 * class.cs (TypeBuilder.DefineType): Catch error condition here
14304 (Parent.DefineType erroring out and returning null).
14306 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14307 coping with enumerations variables, we were mistakenly processing
14308 them as a regular value type instead of built-in types. Fixes the
14311 * typemanager.cs (IsBuiltinOrEnum): New method.
14313 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14315 * cs-parser.jay: Upgrade: yield now needs the return clause.
14317 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14319 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14321 2003-09-29 Martin Baulig <martin@ximian.com>
14323 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14324 inflated generic methods.
14326 * generics.cs (ConstructedType): Distinguish between open and
14327 closed constructed types; correctly resolve the arguments.
14329 2003-09-22 Martin Baulig <martin@ximian.com>
14331 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14332 all type arguments meet their constraints.
14334 2003-09-19 Martin Baulig <martin@ximian.com>
14336 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14337 `MemberCache parent' argument. Normally, an interface doesn't
14338 have a parent type except System.Object, but we use this in gmcs
14339 for generic type parameters.
14341 2003-09-18 Martin Baulig <martin@ximian.com>
14343 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14344 on `type.IsInterface'; don't check whether the type has a parent
14345 to determine whether it's an interface.
14347 2003-09-17 Martin Baulig <martin@ximian.com>
14349 * generic.cs (ConstructedType.ToString): Always use `name' as the
14352 2003-09-15 Martin Baulig <martin@ximian.com>
14354 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14356 * generic.cs (Constraints.Resolve): New public method; this is
14357 called to resolve the constraint types and to check whether all
14358 the constraints are correct.
14359 (Constraints.Types): New public property.
14360 (TypeParameter.Resolve): New public method; resolves all the
14361 type's constraints.
14363 * class.cs (TypeContainer.DefineType): Call
14364 TypeParameter.Resolve() before actually defining the type.
14366 2003-09-15 Martin Baulig <martin@ximian.com>
14368 * class.cs (TypeContainer.DefineType): Added an error flag to
14369 avoid reporting duplicate CS0146's ("class definition is
14372 * driver.cs (Driver.MainDriver): Abort if
14373 RootContext.ResolveTree() reported any errors.
14375 2003-09-07 Martin Baulig <martin@ximian.com>
14377 * report.cs (Error, Warning): Added overloaded versions which take
14378 a `params object[] args' and call String.Format().
14380 2003-09-07 Martin Baulig <martin@ximian.com>
14382 * decl.cs (DeclSpace..ctor): Don't call
14383 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14384 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14385 (DeclSpace.RecordDecl): New method.
14387 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14389 2003-09-02 Ravi Pratap <ravi@ximian.com>
14391 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14392 value attributes to be applied to ParameterBuilders.
14394 * class.cs (MethodCore.LabelParameters): Make static and more
14395 generic so that it can be used from other places - like interface
14396 methods, for instance.
14398 * interface.cs (Interface.Emit): Call LabelParameters before
14399 emitting attributes on the InterfaceMethod.
14401 2003-09-07 Martin Baulig <martin@ximian.com>
14403 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14404 if the number of type parameters doesn't match.
14406 2003-09-04 Martin Baulig <martin@ximian.com>
14408 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14409 for arrays of generic type params (ie. `!0[]').
14411 2003-09-04 Martin Baulig <martin@ximian.com>
14413 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14416 2003-09-04 Martin Baulig <martin@ximian.com>
14418 * decl.cs (DeclSpace.LookupGeneric): New method.
14419 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14422 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14423 argument, not just a string.
14424 (TypeParameter.Define): New public method; this is called to
14425 actually define the generic parameter; after this, you can use the
14426 new `Type' property to get the type.
14428 2003-09-04 Martin Baulig <martin@ximian.com>
14430 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14431 is now an ArrayList; initialize the result of the `TypeParameters'
14433 (DeclSpace.GetGenericData): Removed.
14434 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14435 implement this in a different way.
14436 (DeclSpace.GetTypeParameters): Removed; there's now a
14437 `TypeParameters' property.
14438 (DeclSpace.TypeParameters): New public property.
14440 * generic.cs (Constraints): Make this class public.
14441 (TypeParameter): New public class.
14443 2003-09-04 Martin Baulig <martin@ximian.com>
14445 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14446 generic parameters.
14448 * class.cs (TypeContainer.DefineType): Call
14449 TypeBuilder.DefineGenericParameter () on all generic parameters if
14450 this is a generic type.
14452 2003-08-28 Martin Baulig <martin@ximian.com>
14454 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14457 * sample-hello.cs: Compile this with gmcs: "gmcs
14458 /r:sample-stack.dll sample-hello.cs".
14460 2003-08-28 Martin Baulig <martin@ximian.com>
14462 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14463 the parameters to the generic type.
14465 2003-08-28 Martin Baulig <martin@ximian.com>
14467 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14469 2003-08-28 Martin Baulig <martin@ximian.com>
14471 * cs-parser.jay (opt_type_argument_list): Use
14472 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14473 (primary_expression): Replace `qualified_identifier' with `type_name'.
14474 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14476 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14477 parser to check whether it is syntactically a type parameter list;
14478 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14481 2003-08-26 Martin Baulig <martin@ximian.com>
14483 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14484 resolving aliases; fixes #47927.
14486 2003-08-26 Martin Baulig <martin@ximian.com>
14488 * statement.cs (Using.DoResolve): This is internally emitting a
14489 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14490 do not always return. Fixes #47681.
14492 2003-08-26 Martin Baulig <martin@ximian.com>
14494 * decl.cs (MemberCore): Moved WarningNotHiding(),
14495 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14497 (AdditionResult): Make this nested in DeclSpace.
14498 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14499 argument; call NamespaceEntry.Define() unless we're nested in a
14502 * namespace.cs (Namespace.DefineName): New public function. This
14503 is called from DeclSpace's .ctor to add
14504 (Namespace.Lookup): Include DeclSpaces in the lookup.
14506 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14508 * const.cs (Const): Derive from MemberBase, not MemberCore.
14510 2003-08-25 Martin Baulig <martin@ximian.com>
14512 * convert.cs (Convert.ExplicitReferenceConversion): When
14513 converting from an interface type to a class, unbox if the target
14514 type is a struct type. Fixes #47822.
14516 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14518 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14521 2003-08-22 Martin Baulig <martin@ximian.com>
14523 * class.cs (TypeManager.DefineType): When defining a nested type,
14524 call DefineType() on our parent; fixes #47801.
14526 2003-08-22 Martin Baulig <martin@ximian.com>
14528 * class.cs (MethodData.Define): While checking if a method is an
14529 interface implementation, improve the test a bit more to fix #47654.
14531 2003-08-22 Martin Baulig <martin@ximian.com>
14533 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14534 correctly; fixes #47722.
14536 2003-08-22 Martin Baulig <martin@ximian.com>
14538 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14539 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14541 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14543 2003-08-22 Martin Baulig <martin@ximian.com>
14545 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14546 can only be assigned in static constructors. Fixes #47161.
14548 2003-08-22 Martin Baulig <martin@ximian.com>
14550 Rewrote and improved the flow analysis code.
14552 * flowbranching.cs (FlowBranching): Make this class abstract.
14553 (FlowBranching.CreateBranching): New static function to create a
14554 new flow branching.
14555 (FlowBranchingBlock, FlowBranchingException): New classes.
14556 (FlowBranching.UsageVector.Type): New public readonly field.
14557 (FlowBranching.UsageVector.Breaks): Removed the setter.
14558 (FlowBranching.UsageVector.Returns): Removed the setter.
14559 (FlowBranching.UsageVector): Added Break(), Return(),
14560 NeverReachable() and Throw() methods to modify the reachability.
14561 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14562 done by FlowBranching.Merge().
14563 (FlowBranching.UsageVector.MergeChild): New method; merges the
14564 merge result into the current vector.
14565 (FlowBranching.Merge): New abstract method to merge a branching.
14567 2003-08-12 Martin Baulig <martin@ximian.com>
14569 * expression.cs (Indirection.CacheTemporaries): Create the
14570 LocalTemporary with the pointer type, not its element type.
14572 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14574 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14575 token was a keyword or not.
14577 Add `error' options where an IDENTIFIER was expected; Provide
14578 CheckToken and CheckIdentifierToken convenience error reporting
14581 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14583 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14584 NameSpaceEntry NameSpaceEntry.
14586 (LookupInterfaceOrClass): Avoid creating a full qualified name
14587 from namespace and name: avoid doing lookups when we know the
14588 namespace is non-existant. Use new Tree.LookupByNamespace which
14589 looks up DeclSpaces based on their namespace, name pair.
14591 * driver.cs: Provide a new `parser verbose' to display the
14592 exception thrown during parsing. This is turned off by default
14593 now, so the output of a failure from mcs is more graceful.
14595 * namespace.cs: Track all the namespaces defined in a hashtable
14598 (IsNamespace): New method
14600 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14602 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14603 we know that we need to concatenate (full typename can never be
14608 * statement.cs: Use a bitfield; Do not initialize to null things
14609 which are done by the constructor by default.
14611 * cs-parser.jay: bug fix, parameter was 4, not 3.
14613 * expression.cs: Just use the property;
14615 * statement.cs: No need for GetVariableInfo method.
14617 2003-08-08 Martin Baulig <martin@ximian.com>
14619 * flowanalysis.cs (FlowReturns): This is now nested in the
14620 `FlowBranching' class.
14621 (MyBitVector): Moved this here from statement.cs.
14622 (FlowBranching.SiblingType): New enum type.
14623 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14625 2003-08-07 Martin Baulig <martin@ximian.com>
14627 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14628 `FlowBranching' class and called `BranchingType'.
14630 2003-08-07 Martin Baulig <martin@ximian.com>
14632 * flowanalysis.cs: Moved all the control flow analysis code into
14635 2003-08-07 Martin Baulig <martin@ximian.com>
14637 * assign.cs (Assign.DoResolve): `target' must either be an
14638 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14641 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14643 * expression.cs (BinaryMethod): This kind of expression is created by the
14644 Binary class if it determines that the operator has to be handled
14647 (BinaryDelegate): This kind of expression is created if we are
14648 dealing with a + or - operator on delegates.
14650 (Binary): remove method, argumetns, and DelegateOperator: when
14651 dealing with methods,
14653 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14655 * statement.cs (Block): use bitfields for the three extra booleans
14656 we had in use. Remove unused topblock parameter.
14658 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14660 * assign.cs: Drop extra unneeded tests.
14662 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14664 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14666 * statement.cs (Foreach): Use VariableStorage instead of
14669 * codegen.cs (VariableStorage): New class used by clients that
14670 require a variable stored: locals or fields for variables that
14671 need to live across yield.
14673 Maybe provide a convenience api for EmitThis+EmitLoad?
14675 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14678 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14680 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14681 RemapParameterLValue): New methods that are used to turn a
14682 precomputed FieldInfo into an expression like this:
14686 The idea is to use this instead of making LocalVariableReference
14687 have more than one meaning.
14689 * cs-parser.jay: Add error production to BASE.
14691 * ecore.cs: Deal with TypeManager.GetField returning null, which
14692 is now a valid return value.
14694 (FieldExprNoAddress): New expression for Fields whose address can
14697 * expression.cs (LocalVariableReference): During the resolve
14698 phases, create new expressions if we are in a remapping context.
14699 Remove code that dealt with remapping here.
14701 (ParameterReference): same.
14703 (ProxyInstance): New expression, like the `This' expression, but
14704 it is born fully resolved. We know what we are doing, so remove
14705 the errors that are targeted to user-provided uses of `this'.
14707 * statement.cs (Foreach): our variable is now stored as an
14708 Expression; During resolution, follow the protocol, dont just
14709 assume it will return this.
14711 2003-08-06 Martin Baulig <martin@ximian.com>
14713 * support.cs (SeekableStreamReader.cs): New public class.
14715 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14716 SeekableStreamReader instead of the normal StreamReader.
14718 2003-08-04 Martin Baulig <martin@ximian.com>
14720 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14721 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14722 deambiguate casts and delegate invocations.
14723 (parenthesized_expression): Use the new tokens to ensure this is
14724 not a cast of method invocation.
14726 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14727 when reading a `)' and Deambiguate_CloseParens () was previously
14730 * expression.cs (ParenthesizedExpression): New class. This is
14731 just used for the CS0075 test.
14732 (Binary.DoResolve): Check for CS0075.
14734 2003-07-29 Ravi Pratap <ravi@ximian.com>
14736 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14737 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14738 reference comparison.
14740 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14741 examine the ReturnType for equality - this is necessary in the
14742 cases of implicit and explicit operators whose signature also
14743 includes the return type.
14745 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14747 * namespace.cs: Cache the result of the namespace computation,
14748 instead of computing it every time.
14750 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14752 * decl.cs: Use a global arraylist that we reuse over invocations
14753 to avoid excesive memory consumption. Reduces memory usage on an
14754 mcs compile by one meg (45 average).
14756 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14757 private, work around that.
14759 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14761 * literal.cs (IntLiteral): Define Zero and One static literals.
14763 * cs-parser.jay (integer_literal): use static literals to reduce
14764 memory usage for the most used literals (0, 1 and -1). 211kb
14765 reduced in memory usage.
14767 Replace all calls to `new ArrayList' with `new
14768 ArrayList(4)' which is a good average number for most allocations,
14769 and also requires only 16 bytes of memory for its buffer by
14772 This reduced MCS memory usage in seven megabytes for the RSS after
14775 2003-07-28 Ravi Pratap <ravi@ximian.com>
14777 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14778 handle params methods the correct way by forming only one
14779 applicable set with params and normal methods in them. Earlier we
14780 were looking at params methods only if we found no normal methods
14781 which was not the correct thing to do.
14783 (Invocation.BetterFunction): Take separate arguments indicating
14784 when candidate and the best method are params methods in their
14787 This fixes bugs #43367 and #46199.
14789 * attribute.cs: Documentation updates.
14791 (CheckAttribute): Rename to CheckAttributeTarget.
14792 (GetValidPlaces): Rename to GetValidTargets.
14794 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14795 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14799 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14801 * codegen.cs: Compute IsGeneric correctly.
14803 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14806 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14807 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14808 regressions, and I was chasing more bugs than I required.
14810 * interface.cs: Use expressions for base type names (like classes
14811 and structs have been doing for a while now), and resolve that.
14812 This patch should probably go into head as well.
14814 This makes it one less user of FindType.
14816 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14818 This compiler can not self host currently. Need to fix that.
14820 * Makefile: compile to `gmcs.exe'
14822 * driver.cs: Turn on v2 by default on gmcs.
14824 * generic.cs (ConstructedType): Does no longer take a container
14825 type argument; That will be taken care of later.
14827 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14828 Use SimpleName to resolve for now, so we can continue the work on
14829 the parser, until we get Type.GetType that understands generics.
14831 (ConstructedType.ToString): Implement
14833 (TypeArguments.Resolve): Resolve the child expressions as types.
14835 * cs-parser.jay: Rename interface_constraints to
14836 type_parameter_constraints
14838 (namespace_or_type_name): Only use constructed types for the basic
14839 construction, we will deal with identifier<...> later.
14841 (type/type_name): No longer call DecomposeQI, as
14842 namespace_or_type_name is always decoded now.
14844 2003-07-22 Ravi Pratap <ravi@ximian.com>
14846 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14847 closely: we eliminate methods in base types when we have an
14848 applicable method in a top-level type.
14850 Please see section 14.5.5.1 for an exact description of what goes
14853 This fixes bug #45127 and a host of other related to corlib compilation.
14855 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14856 array is the method corresponding to the top-level type (this is
14857 because of the changes made to icall.c) so we change this
14860 (MethodGroupExpr.Name): This too.
14862 * typemanager.cs (GetElementType): New method which does the right
14863 thing when compiling corlib.
14865 * everywhere: Make use of the above in the relevant places.
14867 2003-07-22 Martin Baulig <martin@ximian.com>
14869 * cs-parser.jay (invocation_expression): Moved
14870 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14871 `cast_expression', but create a InvocationOrCast which later
14872 resolves to either an Invocation or a Cast.
14874 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14875 method; call this before EmitStatement() to make sure that this
14876 expression can be used as a statement.
14878 * expression.cs (InvocationOrCast): New class; resolves to either
14879 an Invocation or a Cast.
14881 * statement.cs (StatementExpression): Call ResolveStatement() on
14882 the ExpressionStatement before emitting it.
14884 2003-07-21 Martin Baulig <martin@ximian.com>
14886 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
14887 `ref' and `out' attributes match; fixes #46220.
14888 (MemberAccess.ResolveMemberAccess): You can't reference a type
14889 through an expression; fixes #33180.
14890 (Indexers.GetIndexersForType): Don't return the indexers from
14891 interfaces the class implements; fixes #46502.
14893 2003-07-21 Martin Baulig <martin@ximian.com>
14895 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
14896 CS0661 checks; fixes bug #30442.
14898 2003-07-21 Martin Baulig <martin@ximian.com>
14900 * decl.cs (AdditionResult): Added `Error'.
14902 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
14904 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
14905 cs0031.cs actually work.
14907 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14909 * cs-parser.jay (namespace_name): do not use
14910 namespace_or_type_name, use qualified_identifier, because
14911 namespace_or_type_name will soon return a composed expression
14912 instead of a string.
14914 (namespace_or_type_name): Instead of returning a string, now this
14915 production returns an expression.
14917 * codegen.cs (EmitContext): Setup IsGeneric property based on
14918 whether our DeclSpace is generic, our the method is generic.
14920 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
14921 the method is generic.
14923 * cs-parser.jay (type_arguments, opt_type_argument_list,
14924 type_parameters, type_parameter_list, opt_type_parameter_list,
14925 type_parameter,, opt_type_parameter_constraints_clauses,
14926 type_parameter_constraints_clauses,
14927 type_parameter_constraint_clause, type_parameter_constraint,
14928 interface_constraints): Add new production
14930 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
14931 DeclSpace is generic or not.
14933 (DeclSpace.SetParameterInfo): New routine, used to set the
14934 parameter info for a type.
14936 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
14937 returns a GenericTypeExpr
14939 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
14940 generic, lookup the generic argument.
14942 * attribute.cs: Do not allow TypeParameterExpressions in
14945 * class.cs: Do not allow the Main method to be defined in a
14948 * expression.cs (SizeOf): Do not allow generic types to be used as
14949 arguments to sizeof.
14951 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
14952 it: whether a type is generic or not. Only works for types we are
14953 currently building for now.
14955 2003-07-20 Martin Baulig <martin@ximian.com>
14957 * namespace.cs: Fixed that bug which caused a crash when compiling
14958 the debugger's GUI.
14960 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14962 * typemanager.cs (LookupTypeReflection): Never expose types which
14963 are NotPublic, NestedPrivate, NestedAssembly, or
14964 NestedFamANDAssem. We used to return these, and later do a check
14965 that would report a meaningful error, but the problem is that we
14966 would not get the real match, if there was a name override.
14968 2003-07-18 Miguel de Icaza <miguel@ximian.com>
14970 * namespace.cs (Namespace, Name): Do not compute the namespace
14971 name dynamically, compute it in the constructor. This reduced
14972 memory usage by 1697 KB.
14974 * driver.cs: Use --pause to pause at the end.
14976 2003-07-17 Peter Williams <peter@newton.cx>
14978 * Makefile: Change the name of the test target so that it doesn't
14979 conflict with the recursive test target.
14981 2003-07-17 Miguel de Icaza <miguel@ximian.com>
14983 * expression.cs (LocalVariableReference.Emit, EmitAssign,
14984 AddressOf): Do not use EmitThis, that was wrong, use the actual
14987 2003-07-15 Miguel de Icaza <miguel@ximian.com>
14989 * class.cs (MethodData.Define): While checking if a method is an
14990 interface implementation, improve the test: If we are not public
14991 (use new test here: use the computed MethodAttributes directly,
14992 instead of the parsed modifier flags) check if the `implementing'
14993 method comes from an interface or not.
14995 * pending.cs (VerifyPendingMethods): Slightly better error
14998 * makefile: add test target that does the mcs bootstrap.
15000 2003-07-16 Ravi Pratap <ravi@ximian.com>
15002 * interface.cs (Define): Do nothing here since there are no
15003 members to populate etc. Move the attribute emission out of here
15004 since this was just totally the wrong place to put it. Attribute
15005 application happens during the 'Emit' phase, not in the 'Define'
15008 (Emit): Add this method and move the attribute emission here
15010 * rootcontext.cs (EmitCode): Call the Emit method on interface
15013 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15015 * expression.cs (OverloadResolve): Report error only if Location
15016 is not 'Null' which means that there was a probe going on.
15018 2003-07-14 Martin Baulig <martin@ximian.com>
15020 * expression.cs (ConditionalLogicalOperator): New public class to
15021 implement user defined conditional logical operators.
15022 This is section 14.11.2 in the spec and bug #40505.
15024 2003-07-14 Martin Baulig <martin@ximian.com>
15026 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
15028 2003-07-14 Martin Baulig <martin@ximian.com>
15030 * codegen.cs (EmitContext.InFixedInitializer): New public field.
15032 * ecore.cs (IVariable.VerifyFixed): New interface method.
15034 * expression.cs (Unary.ResolveOperator): When resolving the `&'
15035 operator, check whether the variable is actually fixed. Fixes bug
15036 #36055. Set a variable definitely assigned when taking its
15037 address as required by the spec.
15039 * statement.cs (LocalInfo.IsFixed): New field.
15040 (LocalInfo.MakePinned): Set `IsFixed' to true.
15042 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15044 * attribute.cs (Attribute.Resolve): While doing a Member lookup
15045 for .ctors, ensure that we only ask for members declared in the
15046 attribute type (BindingFlags.DeclaredOnly).
15050 * expression.cs (Error_WrongNumArguments): Report error 1501
15051 correctly the way CSC does.
15053 2003-07-13 Martin Baulig <martin@ximian.com>
15055 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
15056 lookup on the fully qualified name, to make things like "X.X" work
15057 where "X.X" is a fully qualified type name, but we also have a
15058 namespace "X" in the using list. Fixes #41975.
15060 2003-07-13 Martin Baulig <martin@ximian.com>
15062 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
15063 function. If we're a CompoundAssign, we need to create an embedded
15064 CompoundAssign, not an embedded Assign.
15065 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
15068 2003-07-13 Martin Baulig <martin@ximian.com>
15070 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
15071 work to fix bug #46088.
15073 2003-07-13 Ravi Pratap <ravi@ximian.com>
15075 * class.cs (Operator.Emit): Do not emit attributes here - it is
15076 taken care of by the Method class that we delegate too. This takes
15077 care of bug #45876.
15079 2003-07-10 Martin Baulig <martin@ximian.com>
15081 * expression.cs (TypeOfVoid): New class.
15082 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
15084 2003-07-10 Martin Baulig <martin@ximian.com>
15086 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
15089 2003-07-10 Martin Baulig <martin@ximian.com>
15091 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
15092 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
15094 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
15096 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
15098 2003-07-10 Martin Baulig <martin@ximian.com>
15100 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
15101 of decimal. Fixes #42850.
15103 NOTE: I also fixed the created byte blob, but this doesn't work on
15104 the MS runtime and csc never produces any byte blobs for decimal
15107 2003-07-10 Martin Baulig <martin@ximian.com>
15109 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
15110 structs; fixes #32068.
15111 (Block.AddChildVariableNames): Fixed #44302.
15113 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15115 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
15117 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15119 * attribute.cs: And this test is onger needed.
15121 2003-07-08 Martin Baulig <martin@ximian.com>
15123 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
15124 inaccessible types. Fixes #36313.
15126 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
15128 * namespace.cs (NamespaceEntry): Create implicit entries for all
15129 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
15130 implicit entries for N1.N2 and N1.
15132 2003-07-08 Martin Baulig <martin@ximian.com>
15134 Rewrote the handling of namespaces to fix a lot of the issues
15135 wrt. `using' aliases etc.
15137 * namespace.cs (Namespace): Splitted this class into a
15138 per-assembly `Namespace' and a per-file `NamespaceEntry'.
15140 * typemanager.cs (TypeManager.IsNamespace): Removed.
15141 (TypeManager.ComputeNamespaces): Only compute namespaces from
15142 loaded assemblies here, not the namespaces from the assembly we're
15143 currently compiling.
15145 2003-07-08 Martin Baulig <martin@ximian.com>
15147 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
15149 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15151 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
15154 I thought about the memory savings here, but LookupTypeReflection
15155 is used under already very constrained scenarios. Compiling
15156 corlib or mcs only exposes one hit, so it would not really reduce
15157 any memory consumption.
15159 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15161 * typemanager.cs: fixes bug #45889 by only adding public types from
15162 other assemblies to the list of known types.
15164 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15166 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
15167 on the type we resolved.
15169 2003-07-05 Martin Baulig <martin@ximian.com>
15171 * pending.cs (PendingImplementation.ParentImplements): Don't
15172 create the proxy if the parent is abstract.
15174 * class.cs (TypeContainer.DefineIndexers): Process explicit
15175 interface implementations first. Fixes #37714.
15177 2003-07-04 Miguel de Icaza <miguel@ximian.com>
15179 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
15180 defined recursively; but since we modify the input parameters
15181 (left is set to `this' temporarily), we reset this value if the
15182 left_is_explicit is false, which gives the original semantics to
15185 * literal.cs (NullPointer): new class used to represent a null
15186 literal in a pointer context.
15188 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
15189 type is a pointer, use a NullPointer object instead of a
15190 NullLiteral. Closes 43687
15192 (ExplicitConversion): Convert pointer values using
15193 the conv opcode to the proper type.
15195 * ecore.cs (New): change ValueTypeVariable property into a method,
15196 that returns whether the valuetype is suitable for being used.
15198 * expression.cs (Binary.DoNumericPromotions): Only return if we
15199 the int constant was a valid uint, and we can return both left and
15200 right as uints. If not, we continue processing, to trigger the
15201 type conversion. This fixes 39018.
15203 * statement.cs (Block.EmitMeta): During constant resolution, set
15204 the CurrentBlock property on the emitcontext, so that we resolve
15205 constants propertly.
15207 2003-07-02 Martin Baulig <martin@ximian.com>
15209 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
15210 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
15212 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
15213 than emitting it here.
15215 * statement.cs: Fixed some more flow analysis bugs.
15217 2003-07-02 Martin Baulig <martin@ximian.com>
15219 * class.cs (MethodData.Define): When implementing interface
15220 methods, set Final unless we're Virtual.
15222 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
15223 check work for interface methods.
15225 2003-07-01 Martin Baulig <martin@ximian.com>
15227 * ecore.cs (EmitContext.This): Replaced this property with a
15228 GetThis() method which takes a Location argument. This ensures
15229 that we get the correct error location for a CS0188.
15231 2003-07-01 Miguel de Icaza <miguel@ximian.com>
15233 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
15234 ImplicitStandardConversion.
15236 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
15238 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
15240 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
15243 2003-06-30 Miguel de Icaza <miguel@ximian.com>
15245 * class.cs (Constructor.Define): Turn off initlocals for unsafe
15248 (MethodData.Define): Turn off initlocals for unsafe methods.
15250 2003-06-29 Miguel de Icaza <miguel@ximian.com>
15252 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
15253 complete; Fixes #37521.
15255 * delegate.cs: Use Modifiers.TypeAttr to compute the
15256 TypeAttributes, instead of rolling our own. This makes the flags
15257 correct for the delegates.
15259 2003-06-28 Miguel de Icaza <miguel@ximian.com>
15261 * class.cs (Constructor.Define): Set the private flag for static
15262 constructors as well.
15264 * cs-parser.jay (statement_expression): Set the return value to
15265 null, to avoid a crash when we catch an error.
15267 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15269 * cs-parser.jay: Applied patch from Jackson that adds support for
15270 extern and unsafe modifiers to destructor declarations.
15272 * expression.cs: Report error 21 if the user is trying to index a
15275 * driver.cs: Add an error message, suggested by the bug report.
15277 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15278 if we do not have a ": this ()" constructor initializer. Fixes 45149
15280 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15282 * namespace.cs: Add some information to reduce FAQs.
15284 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15286 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15287 underlying enumeration types. Fixes #43915.
15289 * expression.cs: Treat ushort/short as legal values to be used in
15290 bitwise operations.
15292 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15294 * delegate.cs: transfer custom attributes for paramenters from
15295 the delegate declaration to Invoke and BeginInvoke.
15297 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15299 * attribute.cs: handle custom marshalers and emit marshal info
15302 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15304 * makefile.gnu: Added anonymous.cs to the compiler sources.
15306 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15308 * iterators.cs: Change the name of the proxy class to include two
15311 * cs-parser.jay: Update grammar to include anonymous methods.
15313 * anonymous.cs: new file.
15315 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15317 * class.cs (Field.Define): Add missing test for pointers and
15320 2003-05-27 Ravi Pratap <ravi@ximian.com>
15322 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15323 we use the stobj opcode.
15325 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15326 since it wasn't the correct fix.
15328 It still is puzzling that we are required to use stobj for IntPtr
15329 which seems to be a ValueType.
15331 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15333 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15334 during regular simple name resolution. Now, the trick is that
15335 instead of returning for processing the simplename, we do a
15336 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15337 contextual lookup type). If a match is found, return that, if
15338 not, return for further composition.
15340 This fixes long-standing 30485.
15342 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15343 using the address to initialize an object, do an Stobj instead of
15344 using the regular Stelem.
15346 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15347 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15348 Because if we are a BaseIndexerAccess that value will be true.
15351 * statement.cs (GotoCase.Resolve): Return after reporting an
15352 error, do not attempt to continue.
15354 * expression.cs (PointerArithmetic.Emit): If our operand is a
15355 long, convert our constants to match the operand before
15356 multiplying. Convert to I type before adding. Fixes 43670.
15358 2003-05-14 Ravi Pratap <ravi@ximian.com>
15360 * enum.cs (ImplicitConversionExists) : Rename to
15361 ImplicitEnumConversionExists to remove ambiguity.
15363 * ecore.cs (NullCast): New type of cast expression class which
15364 basically is very similar to EmptyCast with the difference being
15365 it still is a constant since it is used only to cast a null to
15367 (eg. (string) null)
15369 * convert.cs (ImplicitReferenceConversion): When casting a null
15370 literal, we return a NullCast.
15372 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15373 should be around anymore.
15375 The renaming (reported was slightly wrong). Corrections:
15377 ConvertImplicitStandard -> ImplicitConversionStandard
15378 ConvertExplicitStandard -> ExplicitConversionStandard
15380 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15381 before passing them in !
15383 * convert.cs (ImplicitConversionStandard): When comparing for
15384 equal expr and target types, ensure that expr is not a
15387 In general, we must not be checking (expr_type ==
15388 target_type) in the top level conversion methods
15389 (ImplicitConversion, ExplicitConversion etc). This checking is
15390 done in the methods that they delegate to.
15392 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15394 * convert.cs: Move Error_CannotConvertType,
15395 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15396 ImplicitNumericConversion, ImplicitConversionExists,
15397 ImplicitUserConversionExists, StandardConversionExists,
15398 FindMostEncompassedType, FindMostSpecificSource,
15399 FindMostSpecificTarget, ImplicitUserConversion,
15400 ExplicitUserConversion, GetConversionOperators,
15401 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15402 TryImplicitIntConversion, Error_CannotConvertImplicit,
15403 ConvertImplicitRequired, ConvertNumericExplicit,
15404 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15405 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15408 Perform the following renames:
15410 StandardConversionExists -> ImplicitStandardConversionExists
15411 ConvertImplicit -> ImplicitConversion
15412 ConvertImplicitStandard -> ImplicitStandardConversion
15413 TryImplicitIntConversion -> ImplicitIntConversion
15414 ConvertImplicitRequired -> ImplicitConversionRequired
15415 ConvertNumericExplicit -> ExplicitNumericConversion
15416 ConvertReferenceExplicit -> ExplicitReferenceConversion
15417 ConvertExplicit -> ExplicitConversion
15418 ConvertExplicitStandard -> ExplicitStandardConversion
15420 2003-05-19 Martin Baulig <martin@ximian.com>
15422 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15423 (TypeInfo): Added support for structs having structs as fields.
15425 * ecore.cs (FieldExpr): Implement IVariable.
15426 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15427 VariableInfo for the field.
15429 2003-05-18 Martin Baulig <martin@ximian.com>
15431 * expression.cs (This.DoResolve): Report a CS0027 if we're
15432 emitting a field initializer.
15434 2003-05-18 Martin Baulig <martin@ximian.com>
15436 * expression.cs (This.ResolveBase): New public function.
15437 (This.DoResolve): Check for CS0188.
15439 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15442 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15443 `instance_expression' to null if we don't have any non-static
15446 2003-05-18 Martin Baulig <martin@ximian.com>
15448 Reworked the way how local variables and parameters are handled by
15449 the flow analysis code.
15451 * statement.cs (TypeInfo, VariableMap): New public classes.
15452 (VariableInfo): New public class. This is now responsible for
15453 checking whether a variable has been assigned. It is used for
15454 parameters and local variables.
15455 (Block.EmitMeta): Take the InternalParameters as argument; compute
15456 the layout of the flow vectors here.
15457 (Block.LocalMap, Block.ParameterMap): New public properties.
15458 (FlowBranching): The .ctor doesn't get the InternalParameters
15459 anymore since Block.EmitMeta() now computes the layout of the flow
15461 (MyStructInfo): This class is now known as `StructInfo' and nested
15462 in `TypeInfo'; we don't access this directly anymore.
15464 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15465 property and removed IsAssigned(), IsFieldAssigned(),
15466 SetAssigned() and SetFieldAssigned(); we now call them on the
15467 VariableInfo so we don't need to duplicate this code everywhere.
15469 * expression.cs (ParameterReference): Added `Block block' argument
15471 (LocalVariableReference, ParameterReference, This): The new
15472 VariableInfo class is now responsible for all the definite
15475 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15476 IsParameterAssigned, SetParameterAssigned): Removed.
15478 2003-05-18 Martin Baulig <martin@ximian.com>
15480 * typemanager.cs (InitCoreTypes): Try calling
15481 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15482 the 3-args-version. Corlib now also needs our `void_type'.
15483 (GetMethod): Added overloaded version which takes an optional
15484 `bool report_errors' to allow lookups of optional methods.
15486 2003-05-12 Martin Baulig <martin@ximian.com>
15488 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15489 only used for locals and not for parameters.
15491 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15493 * support.cs (InternalParameters.ParameterType): Return the
15494 ExternalType of the parameter.
15496 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15499 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15501 * class.cs (MethodData.Define): Do not set the `newslot' on
15502 interface members, if they are also flagged as "override".
15504 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15505 better code for ++i and i++. This only works for static fields
15506 and local variables.
15508 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15509 want to pull the DeclSpace out of the builder_to_declspace instead
15510 of the TypeBuilder (like in TypeContainer.FindMembers).
15512 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15513 instead of LookupTypeContainer. Fixes the crash on .NET for
15514 looking up interface members.
15516 * const.cs: Create our own emit context during the Definition
15517 stage, so that constants are evaluated in the proper context, when
15518 a recursive definition happens.
15520 2003-05-11 Martin Baulig <martin@ximian.com>
15522 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15523 new block for a switch section.
15524 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15525 the adding/lookup in the switch block. Fixes #39828.
15527 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15529 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15530 functionality: I needed to convert the data after I had performed
15531 the add/sub operation into the operands type size.
15533 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15534 pass the type for the box operation, otherwise the resulting
15535 object would have been of type object.
15537 (BoxedCast): Add constructor to specify the type to box as.
15539 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15541 * iterators.cs: I was reusing the `count' variable inadvertently,
15542 take steps to not allow this to happen.
15544 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15546 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15547 by creating an array at the point where the params starts and
15548 putting all those arguments there, then adjusting the size of the
15551 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15553 * expression.cs (New.AddressOf): Implement interface
15554 IMemoryLocation. This is used when the `new' operator is used in
15555 the context of an invocation to a method on a value type.
15557 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15560 * namespace.cs: Also check the using aliases here.
15562 * driver.cs: Move the test for using validity after the types have
15563 been entered, so we do a single pass that also includes the using
15566 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15567 in the regular case. CreateSiblingForFinally is doing extra
15570 * attribute.cs (GetAttributeArgumentExpression): Store the result
15571 on an out value, and use the return value to indicate failure
15572 instead of using null (which is a valid return for Constant.GetValue).
15574 * statement.cs: Perform the analysis flow for the increment
15575 portion after the statement, because this will be the real flow of
15576 execution. Fixes #42385
15578 * codegen.cs (EmitContext.EmitArgument,
15579 EmitContext.EmitStoreArgument): New helper functions when the
15580 RemapToProxy flag is set.
15582 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15585 Add support for remapping parameters.
15587 * iterators.cs: Propagate parameter values; Store parameter
15588 values in the proxy classes.
15590 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15592 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15593 need a proxy reference; I do not know what I was thinking
15595 * cs-parser.jay (constructor_initializer): catch another error,
15596 and display nice message.
15598 (field_declaration): catch void field declaration
15599 to flag a better error.
15601 * class.cs (MemberBase.CheckBase): Report an error instead of a
15602 warning if a new protected member is declared in a struct.
15603 (Field.Define): catch the error of readonly/volatile.
15605 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15607 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15608 volatile variable is taken
15610 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15612 * statement.cs (Fixed.Resolve): Report an error if we are not in
15615 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15617 * typemanager.cs: reuse the code that handles type clashes for
15618 delegates and enumerations.
15620 * class.cs (Report28): Always report.
15622 * expression.cs (EncodeAsAttribute): Allow nulls here.
15624 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15626 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15627 the functionality for testing whether an expression is valid for
15628 an attribute here. Also handle the case of arrays of elements
15631 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15632 encoding a linear array into an array of objects that are suitable
15633 to be passed to an CustomAttributeBuilder.
15635 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15637 * ecore.cs: (FieldExpr): Handle field remapping here.
15639 * iteratators.cs: Pass the instance variable (if the method is an
15640 instance method) to the constructors, so we can access the field
15641 variables on the class.
15643 TODO: Test this with structs. I think the THIS variable on
15644 structs might have to be a pointer, and not a refenrece
15646 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15648 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15649 local variables to fields in a proxy class.
15651 * iterators.cs (PopulateProxy): Rename our internal fields to
15653 Create a <THIS> field if we are an instance method, so we can
15654 reference our parent container variables.
15655 (MapVariable): Called back from the EmitContext code to enter a
15656 new variable to field mapping into the proxy class (we just create
15660 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15661 for using the remapped locals to fields.
15663 I placed the code here, because that gives the same semantics to
15664 local variables, and only changes the Emit code.
15666 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15667 statements inside iterators.
15668 (VariableInfo): Add a FieldBuilder for the cases when we are
15669 remapping local variables to fields in a proxy class
15671 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15672 current_block != null.
15674 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15675 not cope with strings, as it has been moved to the
15676 TableSwitchEmit. Fixed bug in switch generation.
15678 * expression.cs (New.DoResolve): Provide more context for the user
15679 when reporting an error.
15681 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15684 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15685 check the permissions for it. Note than in a type-resolution
15686 context the check was already present in DeclSpace.ResolveType,
15687 but was missing from the MemberAccess.
15689 (ArrayCreation.CheckIndices): warn if the user has
15690 more nested levels of expressions, but there are no more
15691 dimensions specified. Avoids crash on bug 41906.
15693 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15695 * statement.cs (Block): replace Implicit bool, for a generic
15697 New flag: `Unchecked'. This is used during the EmitMeta phase
15698 (which is out-of-line with the regular Resolve/Emit process for a
15699 statement, as this is done ahead of time, but still gets a chance
15700 to call constant resolve).
15702 (Block.Flags): new enum for adding a new flag.
15704 (Block.EmitMeta): track the state of unchecked.
15706 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15707 to enable constant resolution to work there as well.
15709 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15711 * typemanager.cs (ienumerable_type): Also look up
15712 System.Collections.IEnumerable.
15714 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15716 TODO: Test more than one conditional per method.
15718 * class.cs (Indexer.Define): Report the location where the user is
15719 referencing the unsupported feature.
15721 (MethodData): Overload the use of `conditionals' to
15722 minimize the creation of needless ArrayLists. This saves roughly
15723 212kb on my machine.
15725 (Method): Implement the new IIteratorContainer interface.
15726 (Method.SetYields): Implement the method by setting the ModFlags
15727 to contain METHOD_YIELDS.
15729 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15730 which just got set to null.
15732 * iterators.cs: New file.
15734 (Yield, YieldBreak): New statements.
15736 * statement.cs (Return.Resolve): Flag an error if we are used in
15737 an iterator method.
15739 * codegen.cs (InIterator): New flag set if the code is being
15740 compiled in an iterator method.
15742 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15743 internal modifier, and we just use it to avoid adding extra
15744 fields, as this is seldom used.
15746 * cs-parser.jay: Add yield_statement (yield and yield break).
15748 * driver.cs: New flag -v2 to turn on version 2 features.
15750 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15751 hashtable when v2 is enabled.
15753 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15755 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15756 there is already a namespace defined with this name.
15758 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15759 people upgraded their corlibs.
15761 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15762 always use fully qualified types, no need to use the compiler
15765 (TypeManager.IsNamespace): Use binarysearch.
15767 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15768 AddDelegate): I did not quite use the new IsValid API properly: I
15769 have to pass the short-name and the fullname. I was passing only
15770 the basename instead of the fullname sometimes.
15772 (TypeContainer.DefineType): call NamespaceClash.
15774 * interface.cs (Interface.DefineType): use NamespaceClash before
15777 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15780 * enum.cs: (Enum.DefineType): use NamespaceClash before
15783 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15784 speed increase. First, use the negative_hits cache when we get a
15785 negative. Second, add the type with its full original name
15786 instead of the new . and + encoded name (reflection uses + to
15787 separate type from a nested type). Use LookupTypeReflection
15788 directly which bypasses the type->name hashtable (that we already
15789 know does not contain the type.
15791 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15792 location/container type.
15794 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15796 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15798 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15800 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15801 method is being referenced in the method group from a static
15802 context, and report error 120 if so.
15804 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15807 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15808 is created, we create the A namespace).
15810 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15813 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15815 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15816 invocation to ModuleBuilder.GetType with the same values will
15817 return a new type instance, so we need to cache its return
15820 * expression.cs (Binary.ResolveOperator): Only allow the compare
15821 operators on enums if they are of the same type.
15823 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15824 types of ValueType on their own case. Before we were giving them
15825 the same treatment as objects.
15827 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15828 fullname. Short name is used to compare against container name.
15829 Fullname is used to check against defined namespace names.
15831 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15832 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15834 (Method.CheckBase): Call parent.
15835 (MemberBase.CheckBase): Check for protected members on sealed
15837 (PropertyBase.CheckBase): Call parent.
15838 (Field.Define): Call parent.
15840 * report.cs: Negative error codes are now mapped to 8000 - code,
15841 so that the display is render more nicely.
15843 * typemanager.cs: Do not use try/catch, instead report a regular
15846 (GetPointerType, GetReferenceType): These methods provide
15847 mechanisms to obtain the T* and T& from a T. We had the code
15848 previously scattered around the code base, and it also used
15849 TypeManager.LookupType that would go through plenty of caches.
15850 This one goes directly to the type source.
15852 In some places we did the Type.GetType followed by
15853 ModuleBuilder.GetType, but not in others, so this unifies the
15854 processing as well.
15856 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15857 statements now that we have namespace information.
15859 * typemanager.cs (IsNamespace): New method, returns whether the
15860 string presented is a namespace or not.
15862 (ComputeNamespaces): New public entry point, computes the list of
15863 available namespaces, using the GetNamespaces API call in Mono, or
15864 the slower version in MS.NET.
15866 Now before we start the semantic analysis phase, we have a
15867 complete list of namespaces including everything that the user has
15870 Deleted old code to cache namespaces in .nsc files.
15872 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15874 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15875 class/struct location definition Location for the implicit
15876 constructor location.
15878 (Operator.Define): Use the location of the operator for the
15879 implicit Method definition.
15881 (Constructor.Emit): use the constructor location for the implicit
15882 base initializer constructor.
15884 * ecore.cs: Remove ITypeExpression. This interface is now gone,
15885 and the Expression class now contains two new methods:
15887 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
15888 isolate type lookup from the rest of the resolution process.
15890 Since we use Expressions to hold type definitions due to the way
15891 we parse the input we have historically overloaded Resolve to
15892 perform the Type lookups if a special flag is passed. Now this is
15893 eliminated and two methods take their place.
15895 The differences in the two methods between xStep and xTerminal is
15896 that xStep is involved in our current lookup system that uses
15897 SimpleNames to compose a name, while xTerminal is used just to
15898 catch the case where the simplename lookup failed.
15900 2003-04-16 Miguel de Icaza <miguel@ximian.com>
15902 * expression.cs (ResolveMemberAccess): Remove redundant code.
15903 TypeExpr expressions are always born fully resolved.
15905 * interface.cs (PopulateMethod): Do not lookup the types twice.
15906 We were doing it once during SemanticAnalysis and once during
15909 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
15910 in local variable type definitions, were being returned as a
15911 SimpleName (we decomposed everything into a string), that is
15912 because primary_expression was being used instead of a type in the
15913 grammar (reduce/reduce conflicts).
15915 The part that was wrong is that we converted the expression into a
15916 string (an oversimplification in one hand, compounded with primary
15917 expressions doing string concatenation).
15923 Would return "A.B.C[]" as a SimpleName. This stopped things like
15924 using clauses from working on this particular context. And a type
15925 was being matched directly against "A.B.C[]".
15927 We now use the correct approach, and allow for ComposedCast to be
15928 part of the unary expression. So the "A.B.C []" become a composed
15929 cast of "A.B.C" (as a nested group of MemberAccess with a
15930 SimpleName at the end) plus the rank composition "[]".
15934 2003-04-10 Miguel de Icaza <miguel@ximian.com>
15936 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
15937 for the access level checking.
15939 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
15940 `TypeContainer container', because I kept getting confused when I
15941 was debugging this code.
15943 * expression.cs (Indexers): Instead of tracking getters/setters,
15944 we now track them in parallel. We create one arraylist less, but
15945 most importantly it is possible now for the LValue code to find a
15946 matching get for a set.
15948 (IndexerAccess.DoResolveLValue): Update the code.
15949 GetIndexersForType has been modified already to extract all the
15950 indexers from a type. The code assumed it did not.
15952 Also make the code set the correct return type for the indexer.
15953 This was fixed a long time ago for properties, but was missing for
15954 indexers. It used to be void_type.
15956 (Binary.Emit): Test first for doubles instead of
15957 floats, as they are more common.
15959 (Binary.EmitBranchable): Use the .un version of the branch opcodes
15960 when dealing with floats and the <=, >= operators. This fixes bug
15963 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
15964 to load the array value by emitting a load on the foreach variable
15965 type. This was incorrect.
15967 We now emit the code to load an element using the the array
15968 variable type, and then we emit the conversion operator.
15972 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
15974 * attribute.cs: Avoid allocation of ArrayLists in the common case.
15976 2003-04-09 Miguel de Icaza <miguel@ximian.com>
15978 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
15979 test for protection before we test for signatures.
15981 (MethodSignature.ToString): implement.
15983 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
15984 to the case where we reduced into a LongConstant.
15986 * decl.cs (CheckAccessLevel): If the type is an array, we can not
15987 depend on whether the information is acurrate, because the
15988 Microsoft runtime will always claim that the array type is public,
15989 regardless of the real state.
15991 If the type is a pointer, another problem happens: the type is
15992 reported as non-public in Microsoft.
15994 In both cases we have to call CheckAccessLevel recursively with
15995 the underlying type as the argument to be tested.
15997 2003-04-08 Miguel de Icaza <miguel@ximian.com>
15999 * assign.cs (Assign.Emit): If we are dealing with a compound
16000 assignment expression, we should use the code path that stores the
16001 intermediate result in a temporary value. This fixes #40903.
16003 *expression.cs (Indirection.ToString): Provide ToString method for
16006 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
16008 * class.cs: Null out fields holding references to Block objects so
16009 they can be garbage collected.
16011 * expression.cs (OverloadResolve): Remove unused local.
16013 2003-04-07 Martin Baulig <martin@ximian.com>
16015 * codegen.cs (EmitContext.CurrentFile): New public field.
16016 (EmitContext.Mark): Use the CurrentFile to check whether the
16017 location is in the correct file.
16018 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
16020 2003-04-07 Martin Baulig <martin@ximian.com>
16022 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
16024 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
16025 location. [FIXME: The location argument which gets passed to this
16026 method is sometimes wrong!]
16028 2003-04-07 Nick Drochak <ndrochak@gol.com>
16030 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
16032 2003-04-07 Miguel de Icaza <miguel@ximian.com>
16034 * expression.cs (Indirection.EmitAssign): We were using the
16035 temporary, but returning immediately instead of continuing the
16038 2003-04-06 Martin Baulig <martin@ximian.com>
16040 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
16041 if it's a nested child, but also deriving from the outer class.
16044 * typemanager.cs (IsNestedChildOf): Make this work if it's a
16045 nested child, but also deriving from the outer class. See
16047 (FilterWithClosure): We may access private members of the outer
16048 class if we're a nested child and deriving from the outer class.
16049 (RealMemberLookup): Only set `closure_private_ok' if the
16050 `original_bf' contained BindingFlags.NonPublic.
16052 2003-04-05 Martin Baulig <martin@ximian.com>
16054 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
16055 probe if its a type parameter, and if so, flag an error.
16057 * decl.cs: Move here the SetParameterInfo code from class.cs.
16058 Handle IsGeneric here.
16060 Handle a variety of errors in the parameter info definition.
16062 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
16063 type parameters here.
16065 * cs-parser.jay (class_declaration): report errors for parameters
16068 2003-01-21 Miguel de Icaza <miguel@ximian.com>
16070 * generic.cs: New file, contains support code for generics.
16072 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
16073 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
16075 Update parser for the above removals.
16077 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
16078 now taken care of in the parser.
16080 2003-04-02 Miguel de Icaza <miguel@ximian.com>
16082 * class.cs (Event.Define): Do not allow abstract events to have
16085 2003-04-01 Miguel de Icaza <miguel@ximian.com>
16087 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
16088 block in event declarations.
16090 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
16091 value type, get its address.
16093 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
16094 leaving a class on the stack instead of a boolean value (int
16095 0/1). Change the code so we compare against null, and then the
16096 result against zero.
16098 * class.cs (TypeContainer.GetClassBases): We were checking for the
16099 parent class being sealed too late.
16101 * expression.cs (Binary.Emit): For <= and >= when dealing with
16102 floating point values, use cgt.un and clt.un instead of cgt and
16105 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
16107 * statement.cs: Apply the same optimization as MS: skip the
16108 GetEnumerator returning an IEnumerator, and use the one returning a
16109 CharEnumerator instead. This allows us to avoid the try-finally block
16112 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
16114 * cs-parser.jay: Attributes cannot be applied to
16115 namespaces. Fixes #40473
16117 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16120 (Add*): check if the name is valid using the full name for constants,
16121 fields, properties and events.
16123 2003-03-28 Miguel de Icaza <miguel@ximian.com>
16125 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
16126 char constants to be part of the enumeration.
16128 * expression.cs (Conditional.DoResolve): Add support for operator
16129 true. Implements the missing functionality from 14.12
16131 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
16132 operator true/false as required by the spec.
16134 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
16135 implicit conversion to boolean.
16137 * statement.cs (Statement.ResolveBoolean): A boolean expression is
16138 also one where the type implements `operator true'.
16140 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
16141 get an expression that will invoke operator true based on an
16144 (GetConversionOperators): Removed the hack that called op_True
16147 (Expression.ResolveBoolean): Move this from Statement.
16149 2003-03-17 Miguel de Icaza <miguel@ximian.com>
16151 * ecore.cs (FieldExpr): do not allow initialization of initonly
16152 fields on derived classes
16154 2003-03-13 Martin Baulig <martin@ximian.com>
16156 * statement.cs (Block.Emit): Call ig.BeginScope() and
16157 ig.EndScope() when compiling with debugging info; call
16158 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
16160 2003-03-08 Miguel de Icaza <miguel@ximian.com>
16162 * expression.cs (Indexers): Do not construct immediately, allow
16163 for new members to be appended as we go. Fixes 38143
16165 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16167 * expression.cs: save/restore context when resolving an unchecked
16170 2003-03-05 Miguel de Icaza <miguel@ximian.com>
16172 * cfold.cs: Catch division by zero in modulus operator during
16175 2003-03-03 Miguel de Icaza <miguel@ximian.com>
16177 * interface.cs (Interface.DefineMembers): Avoid defining members
16180 2003-02-27 Miguel de Icaza <miguel@ximian.com>
16182 * driver.cs: handle the +/- options for -noconfig
16184 * statement.cs (Unckeched.Resolve): Also track the state of
16185 unchecked in the Resolve phase.
16187 2003-02-27 Martin Baulig <martin@ximian.com>
16189 * ecore.cs (Expression.MemberLookup): Don't create a
16190 MethodGroupExpr for something which is not a method. Fixes #38291.
16192 2003-02-25 Miguel de Icaza <miguel@ximian.com>
16194 * class.cs (MemberBase.CheckParameters): Also check that the type
16195 is unmanaged if it is a pointer.
16197 * expression.cs (SizeOf.Resolve): Add location information.
16199 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
16200 a managed type is declared.
16202 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
16203 parameter modifiers as well. Fixes bug 38606
16205 * class.cs: Very sad. Am backing out the speed up changes
16206 introduced by the ArrayList -> Array in the TypeContainer, as they
16207 were not actually that much faster, and introduced a bug (no error
16208 reports on duplicated methods).
16210 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
16211 source first, this will guarantee that we have a valid expression
16212 before calling in lower levels functions that will require a
16213 resolved object. Then use this original_source in the
16214 target.ResolveLValue instead of the original source that was
16217 Another change. Use target.Resolve instead of LValueResolve.
16218 Although we are resolving for LValues, we will let the Assign code
16219 take care of that (it will be called again from Resolve). This
16220 basically allows code like this:
16222 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
16223 class Y { void A (X x) { x [0] += o; }
16225 The problem was that the indexer was trying to resolve for
16226 set_Item (idx, object o) and never finding one. The real set_Item
16227 was set_Item (idx, X). By delaying the process we get the right
16232 2003-02-23 Martin Baulig <martin@ximian.com>
16234 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
16235 while calling DoEmit ().
16237 * codegen.cs (EmitContext.Mark): Don't mark locations in other
16238 source files; if you use the #line directive inside a method, the
16239 compiler stops emitting line numbers for the debugger until it
16240 reaches the end of the method or another #line directive which
16241 restores the original file.
16243 2003-02-23 Martin Baulig <martin@ximian.com>
16245 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
16247 2003-02-23 Martin Baulig <martin@ximian.com>
16249 * statement.cs (Block.AddChildVariableNames): We need to call this
16250 recursively, not just for our immediate children.
16252 2003-02-23 Martin Baulig <martin@ximian.com>
16254 * class.cs (Event.Define): Always make the field private, like csc does.
16256 * typemanager.cs (TypeManager.RealMemberLookup): Make events
16257 actually work, fixes bug #37521.
16259 2003-02-23 Miguel de Icaza <miguel@ximian.com>
16261 * delegate.cs: When creating the various temporary "Parameters"
16262 classes, make sure that we call the ComputeAndDefineParameterTypes
16263 on those new parameters (just like we do with the formal ones), to
16264 allow them to be resolved in the context of the DeclSpace.
16266 This fixes the bug that Dick observed in Bugzilla #38530.
16268 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16270 * expression.cs (ResolveMemberAccess): When resolving a constant,
16271 do not attempt to pull a constant if the value was not able to
16272 generate a valid constant.
16274 * const.cs (LookupConstantValue): Do not report more errors than required.
16276 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16278 * expression.cs: fixes bug #38328.
16280 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16282 * class.cs: Changed all the various members that can be part of a
16283 class from being an ArrayList to be an Array of the right type.
16284 During the DefineType type_list, interface_list, delegate_list and
16285 enum_list are turned into types, interfaces, delegates and enums
16288 And during the member population, indexer_list, event_list,
16289 constant_list, field_list, instance_constructor_list, method_list,
16290 operator_list and property_list are turned into their real arrays.
16292 Although we could probably perform this operation earlier, for
16293 good error reporting we need to keep the lists and remove the
16294 lists for longer than required.
16296 This optimization was triggered by Paolo profiling the compiler
16297 speed on the output of `gen-sample-program.pl' perl script.
16299 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16300 not crash in methods like MemberLookupFailed that use this field.
16302 This problem arises when the compiler fails to resolve a type
16303 during interface type definition for example.
16305 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16307 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16308 inherit from System.Object, so we have to stop at null, not only
16309 when reaching System.Object.
16311 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16313 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16314 DeclaredOnly because the parent indexer might have had a different
16315 name, but did not loop until the top of the hierarchy was reached.
16317 The problem this one fixes is 35492: when a class implemented an
16318 indexer from an interface, we were getting the interface method
16319 (which was abstract) and we were flagging an error (can not invoke
16322 This also keeps bug 33089 functioning, and test-148 functioning.
16324 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16325 out if a method is special is to see if it is declared in a
16326 property or event, or whether it is one of the predefined operator
16327 names. This should fix correctly #36804.
16329 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16331 The goal here is to remove the dependency on EmptyCast.Peel ().
16332 Killing it completely.
16334 The problem is that currently in a number of places where
16335 constants are expected, we have to "probe" for an EmptyCast, and
16336 Peel, which is not the correct thing to do, as this will be
16337 repetitive and will likely lead to errors.
16339 The idea is to remove any EmptyCasts that are used in casts that
16340 can be reduced to constants, so we only have to cope with
16343 This bug hunt was triggered by Bug 37363 and the desire to remove
16344 the duplicate pattern where we were "peeling" emptycasts to check
16345 whether they were constants. Now constants will always be
16348 * ecore.cs: Use an enumconstant here instead of wrapping with
16351 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16352 throwing me off. By handling this we can get rid of a few hacks.
16354 * statement.cs (Switch): Removed Peel() code.
16356 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16358 * class.cs: Location information for error 508
16360 * expression.cs (New.DoResolve): Add a guard against double
16361 resolution of an expression.
16363 The New DoResolve might be called twice when initializing field
16364 expressions (see EmitFieldInitializers, the call to
16365 GetInitializerExpression will perform a resolve on the expression,
16366 and later the assign will trigger another resolution
16368 This leads to bugs (#37014)
16370 * delegate.cs: The signature for EndInvoke should contain any ref
16371 or out parameters as well. We were not doing this in the past.
16373 * class.cs (Field.Define): Do not overwrite the type definition
16374 inside the `volatile' group. Turns out that volatile enumerations
16375 were changing the type here to perform a validity test, which
16378 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16380 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16381 and structs, we do not want to load the instance variable
16383 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16384 enum_type has to be handled like an object reference (implicit
16385 conversions exists from this to object), but the regular IsClass
16386 and IsValueType tests will never return true for this one.
16388 Also we use TypeManager.IsValueType instead of type.IsValueType,
16389 just for consistency with the rest of the code (this is only
16390 needed if we ever use the construct exposed by test-180.cs inside
16391 corlib, which we dont today).
16393 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16395 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16398 2003-02-09 Martin Baulig <martin@ximian.com>
16400 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16401 (Namespace.DefineNamespaces): New static public method; this is
16402 called when we're compiling with debugging to add all namespaces
16403 to the symbol file.
16405 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16406 pass it to the Namespace's .ctor.
16408 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16409 and MethodBase arguments; pass the namespace ID to the symwriter;
16410 pass the MethodBase instead of the token to the symwriter.
16411 (SymbolWriter.DefineNamespace): New method to add a namespace to
16414 2003-02-09 Martin Baulig <martin@ximian.com>
16416 * symbolwriter.cs: New file. This is a wrapper around
16417 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16418 methods here in near future.
16420 2003-02-09 Martin Baulig <martin@ximian.com>
16422 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16423 ILGenerator.MarkSequencePoint() which are actually used by the
16426 2003-02-09 Martin Baulig <martin@ximian.com>
16428 * location.cs (SourceFile): New public sealed class. This
16429 contains the name and an index which is used in the location's token.
16430 (Location): Reserve an appropriate number of bits in the token for
16431 the source file instead of walking over that list, this gives us a
16432 really huge performance improvement when compiling with debugging.
16434 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16435 `SourceFile' argument instead of a string.
16436 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16437 but don't parse/tokenize here, we need to generate the list of all
16438 source files before we do that.
16439 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16442 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16443 instead of a string.
16445 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16448 2003-02-09 Martin Baulig <martin@ximian.com>
16450 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16451 filename on `#line default'.
16453 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16455 * statement.cs: don't clear the pinned var when the fixed statement
16456 returns from the method (fixes bug#37752).
16458 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16460 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16463 2003-02-07 Martin Baulig <martin@ximian.com>
16465 * driver.cs: Removed the `--debug-args' command line argument.
16467 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16468 automatically by the AsssemblyBuilder.
16469 (CodeGen.InitializeSymbolWriter): We don't need to call any
16470 initialization function on the symbol writer anymore. This method
16471 doesn't take any arguments.
16473 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16475 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16476 from referenced assemblies as well.
16478 2003-02-02 Martin Baulig <martin@ximian.com>
16480 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16482 2003-02-02 Martin Baulig <martin@ximian.com>
16484 * class.cs (Constructor.Emit): Open the symbol writer before
16485 emitting the constructor initializer.
16486 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16487 single-stepping through constructor initializers.
16489 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16491 * class.cs: Handle error 549: do not allow virtual methods in
16494 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16496 * decl.cs: Check access levels when resolving types
16498 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16500 * statement.cs: Add parameters and locals set in catch blocks that might
16501 return to set vector
16503 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16505 * class.cs (Operator): Set the SpecialName flags for operators.
16507 * expression.cs (Invocation.DoResolve): Only block calls to
16508 accessors and operators on SpecialName methods.
16510 (Cast.TryReduce): Handle conversions from char constants.
16513 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16515 * statement.cs: small memory and time optimization in FlowBranching.
16517 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16519 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16520 problem that the last fix but in the other sid (Set).
16522 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16523 access when there is no indexer in the hierarchy.
16525 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16527 * class.cs: Combine some if statements.
16529 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16531 * driver.cs: fixed bug #37187.
16533 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16535 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16536 any indexer, it's needed to build a list with all the indexers in the
16537 hierarchy (AllGetters), else we have problems. Fixes #35653.
16539 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16541 * class.cs (MethodData.Define): It is wrong for an interface
16542 implementation to be static in both cases: explicit and implicit.
16543 We were only handling this in one case.
16545 Improve the if situation there to not have negations.
16547 * class.cs (Field.Define): Turns out that we do not need to check
16548 the unsafe bit on field definition, only on usage. Remove the test.
16550 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16552 * driver.cs: use assembly.Location instead of Codebase (the latest
16553 patch made mcs fail when using MS assemblies).
16555 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16557 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16558 get the path to *corlib.dll.
16560 2003-01-21 Nick Drochak <ndrochak@gol.com>
16564 * typemanager.cs: Remove compiler warnings
16566 2003-01-20 Duncan Mak <duncan@ximian.com>
16568 * AssemblyInfo.cs: Bump the version number to 0.19.
16570 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16572 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16574 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16576 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16578 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16580 * cs-parser.jay: Small fix: we were not comparing the constructor
16581 name correctly. Thanks to Zoltan for the initial pointer.
16583 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16585 * cs-tokenizer.cs: Set file name when specified with #line
16587 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16589 * cs-parser.jay: Only perform the constructor checks here if we
16590 are named like the class; This will help provider a better
16591 error. The constructor path is taken when a type definition is
16592 not found, but most likely the user forgot to add the type, so
16593 report that rather than the constructor error.
16595 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16597 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16600 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16602 * cs-parser.jay: Add cleanup call.
16604 2003-01-13 Duncan Mak <duncan@ximian.com>
16606 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16607 consistent with other methods.
16609 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16611 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16613 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16615 * attribute.cs: only set GuidAttr to true when we have a
16618 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16622 * typemanager.cs: fixes to allow mcs compile corlib with the new
16623 Type.IsSubclassOf fix.
16625 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16627 * expression.cs (LocalVariableReference.DoResolve): Classify a
16628 constant as a value, not as a variable. Also, set the type for
16631 * cs-parser.jay (fixed_statement): take a type instead of a
16632 pointer_type, so we can produce a better error message later.
16634 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16637 (For.DoEmit): Make inifinite loops have a
16638 non-conditional branch back.
16640 (Fixed.DoEmit): First populate the pinned variables, then emit the
16641 statement, then clear the variables. Before I was emitting the
16642 code once for each fixed piece.
16645 2003-01-08 Martin Baulig <martin@ximian.com>
16647 * statement.cs (FlowBranching.MergeChild): A break in a
16648 SWITCH_SECTION does not leave a loop. Fixes #36155.
16650 2003-01-08 Martin Baulig <martin@ximian.com>
16652 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16653 lives in the same number space than `param_map'. Fixes #36154.
16655 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16657 * cs-parser.jay (constructor_declaration): Set the
16658 Constructor.ModFlags before probing for it. This makes the
16659 compiler report 514, 515 and 132 (the code was there, but got
16662 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16663 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16664 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16666 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16668 * enum.cs: create the enum static fields using the enum type.
16670 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16672 * class.cs: don't try to create the ParamBuilder for the return
16673 type if it's not needed (and handle it breaking for the ms runtime
16676 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16678 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16680 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16682 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16683 the command. This showed up while compiling the JANET source
16684 code, which used \r as its only newline separator.
16686 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16688 * class.cs (Method.Define): If we are an operator (because it
16689 reuses our code), then set the SpecialName and HideBySig. #36128
16691 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16693 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16694 exception, report error 120 `object reference required'.
16696 * driver.cs: Add --pause option, used during to measure the size
16697 of the process as it goes with --timestamp.
16699 * expression.cs (Invocation.DoResolve): Do not allow methods with
16700 SpecialName to be invoked.
16702 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16704 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16705 number before adding it.
16707 2002-12-21 Ravi Pratap <ravi@ximian.com>
16709 * ecore.cs (StandardImplicitConversion): When in an unsafe
16710 context, we allow conversion between void * to any other pointer
16711 type. This fixes bug #35973.
16713 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16715 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16716 is not thrown when extensionless outputs are used
16718 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16720 * rootcontext.cs: fixed compilation of corlib.
16722 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16724 * attribute.cs (Attributes.Contains): Add new method.
16726 * class.cs (MethodCore.LabelParameters): if the parameter is an
16727 `out' parameter, check that no attribute `[In]' has been passed.
16729 * enum.cs: Handle the `value__' name in an enumeration.
16731 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16733 * decl.cs: Added special case to allow overrides on "protected
16736 2002-12-18 Ravi Pratap <ravi@ximian.com>
16738 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16739 since it makes much more sense.
16741 (Attributes.ctor): Don't require a Location parameter.
16743 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16745 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16746 since we already have that information per attribute.
16748 * everywhere : make appropriate changes.
16750 * class.cs (LabelParameters): Write the code which actually
16751 applies attributes to the return type. We can't do this on the MS
16752 .NET runtime so we flag a warning in the case an exception is
16755 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16757 * const.cs: Handle implicit null conversions here too.
16759 2002-12-17 Ravi Pratap <ravi@ximian.com>
16761 * class.cs (MethodCore.LabelParameters): Remove the extra
16762 Type [] parameter since it is completely unnecessary. Instead
16763 pass in the method's attributes so that we can extract
16764 the "return" attribute.
16766 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16768 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16769 of ignoring it and letting the compile continue.
16771 * typemanager.cs (ChangeType): use an extra argument to return an
16772 error condition instead of throwing an exception.
16774 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16776 * expression.cs (Unary.TryReduce): mimic the code for the regular
16777 code path. Perform an implicit cast in the cases where we can
16778 implicitly convert to one of the integral types, and then reduce
16779 based on that constant. This fixes bug #35483.
16781 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16783 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16785 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16787 * namespace.cs: fixed bug #35489.
16789 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16791 * class.cs: Remove some dead code.
16793 * cs-parser.jay: Estimate the number of methods needed
16794 (RootContext.MethodCount);
16796 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16797 numbers instead of StringBuilders.
16799 * support.cs (PtrHashtable): Add constructor with initial size;
16800 We can now reduce reallocations of the method table.
16802 2002-12-10 Ravi Pratap <ravi@ximian.com>
16804 * attribute.cs (ApplyAttributes): Keep track of the emitted
16805 attributes on a per-target basis. This fixes bug #35413.
16807 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16809 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16810 default to the Windows 1252 encoding.
16812 (UnixParseOption): Support version, thanks to Alp for the missing
16815 * AssemblyInfo.cs: Add nice assembly information.
16817 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16820 * cs-parser.jay: Allow a trailing comma before the close bracked
16821 in the attribute_section production.
16823 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16824 address of the instance was being taken, I will take this out,
16825 because we take the address of the object immediately here.
16827 2002-12-09 Ravi Pratap <ravi@ximian.com>
16829 * typemanager.cs (AreMultipleAllowed): Take care of the most
16830 obvious case where attribute type is not in the current assembly -
16833 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16835 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16836 definitions, instead of doing that afterwards.
16838 Also we use a nice little hack, depending on the constructor, we
16839 know if we are a "composed" name or a simple name. Hence, we
16840 avoid the IndexOf test, and we avoid
16842 * codegen.cs: Add code to assist in a bug reporter to track down
16843 the source of a compiler crash.
16845 2002-12-07 Ravi Pratap <ravi@ximian.com>
16847 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16848 types have been emitted for a given element and flag an error
16849 if something which does not have AllowMultiple set is used more
16852 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16853 attribute types and their corresponding AllowMultiple properties
16855 (AreMultipleAllowed): Check the property for a given type.
16857 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16858 property in the case we have a TypeContainer.
16860 (Attributes.AddAttribute): Detect duplicates and just skip on
16861 adding them. This trivial fix catches a pretty gross error in our
16862 attribute emission - global attributes were being emitted twice!
16864 Bugzilla bug #33187 is now fixed.
16866 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16868 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16869 instead of pp_and).
16871 * expression.cs (Binary.ResolveOperator): I can only use the
16872 Concat (string, string, string) and Concat (string, string,
16873 string, string) if the child is actually a concatenation of
16876 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16878 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16879 context where we need a 2-character lookahead.
16881 * pending.cs (PendingImplementation): Rework so we can keep track
16882 of interface types all the time, and flag those which were
16883 implemented by parents as optional.
16885 2002-12-03 Miguel de Icaza <miguel@ximian.com>
16887 * expression.cs (Binary.ResolveOperator): Use
16888 String.Concat(string,string,string) or
16889 String.Concat(string,string,string,string) when possible.
16891 * typemanager: More helper methods.
16894 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
16896 * pending.cs: remove the bogus return from GetMissingInterfaces()
16897 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
16899 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16901 * namespace.cs: avoid duplicated 'using xxx' being added to
16902 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
16903 when we get more than one 'using' statement for the same namespace.
16904 Report a CS0105 warning for it.
16906 2002-11-30 Miguel de Icaza <miguel@ximian.com>
16908 * cs-tokenizer.cs (consume_identifier): use read directly, instead
16909 of calling getChar/putback, uses internal knowledge of it.
16911 (xtoken): Reorder tokenizer so most common patterns are checked
16912 first. This reduces the compilation time in another 5% (from 8.11s
16913 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
16915 The parsing time is 22% of the compilation in mcs, and from that
16916 64% is spent on the tokenization process.
16918 I tried using a binary search for keywords, but this is slower
16919 than the hashtable. Another option would be to do a couple of
16922 * Not use a StringBuilder, instead use an array of chars,
16923 with a set value. Notice that this way we could catch
16924 the 645 error without having to do it *afterwards*.
16926 * We could write a hand-parser to avoid the hashtable
16927 compares altogether.
16929 The identifier consumption process takes 37% of the tokenization
16930 time. Another 15% is spent on is_number. 56% of the time spent
16931 on is_number is spent on Int64.Parse:
16933 * We could probably choose based on the string length to
16934 use Int32.Parse or Int64.Parse and avoid all the 64-bit
16937 Another 3% is spend on wrapping `xtoken' in the `token' function.
16939 Handle 0xa0 as whitespace (#34752)
16941 2002-11-26 Miguel de Icaza <miguel@ximian.com>
16943 * typemanager.cs (IsCLRType): New routine to tell whether a type
16944 is one of the builtin types.
16946 Maybe it needs to use TypeCodes to be faster. Maybe we could use
16947 typecode in more places instead of doing pointer comparissions.
16948 We could leverage some knowledge about the way the typecodes are
16951 New code to cache namespaces in assemblies, it is currently not
16952 invoked, to be used soon.
16954 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
16956 * expression.cs (Binary.ResolveOperator): specially handle
16957 strings, and do not perform user-defined operator overloading for
16960 2002-11-24 Miguel de Icaza <miguel@ximian.com>
16962 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
16963 internalcall as it is a pretty simple operation; Avoid whenever
16964 possible to call Char.IsLetter.
16966 (consume_identifier): Cut by half the number of
16967 hashtable calls by merging the is_keyword and GetKeyword behavior.
16969 Do not short-circuit, because if we do, we
16970 report errors (ie, #if false && true would produce an invalid
16974 2002-11-24 Martin Baulig <martin@ximian.com>
16976 * expression.cs (Cast.TryReduce): If we're in checked syntax,
16977 check constant ranges and report a CS0221. Fixes #33186.
16979 2002-11-24 Martin Baulig <martin@ximian.com>
16981 * cs-parser.jay: Make this work for uninitialized variable
16982 declarations in the `for' initializer. Fixes #32416.
16984 2002-11-24 Martin Baulig <martin@ximian.com>
16986 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
16987 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
16989 2002-11-24 Martin Baulig <martin@ximian.com>
16991 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
16992 argument; if true, we also check for user-defined conversions.
16993 This is only needed if both arguments are of a user-defined type.
16994 Fixes #30443, added test-175.cs.
16995 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
16997 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
16999 2002-11-24 Martin Baulig <martin@ximian.com>
17001 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
17002 function to get the store opcode.
17003 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
17004 only emit the Ldelema if the store opcode is Stobj. You must run
17005 both test-34 and test-167 to test this. Fixes #34529.
17007 2002-11-23 Martin Baulig <martin@ximian.com>
17009 * ecore.cs (Expression.MemberLookup): Added additional
17010 `qualifier_type' argument which is used when we're being called
17011 from MemberAccess.DoResolve() and null if we're called from a
17013 (Expression.MemberLookupFailed): New method to report errors; this
17014 does the CS1540 check and reports the correct error message.
17016 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
17017 argument for the CS1540 check and redone the way how we're dealing
17018 with private members. See the comment in the source code for details.
17019 (FilterWithClosure): Reverted this back to revision 1.197; renamed
17020 `closure_start_type' to `closure_qualifier_type' and check whether
17021 it's not null. It was not this filter being broken, it was just
17022 being called with the wrong arguments.
17024 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
17025 and pass it the correct `qualifier_type'; this also does the error
17028 2002-11-22 Miguel de Icaza <miguel@ximian.com>
17030 * expression.cs (Invocation.EmitParams): If the we are dealing
17031 with a non-built-in value type, load its address as well.
17033 (ArrayCreation): Use a a pretty constant instead
17034 of the hardcoded value 2. Use 6 instead of 2 for the number of
17035 static initializers.
17037 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
17038 because they are not really value types, just glorified integers.
17040 * driver.cs: Do not append .exe, the CSC compiler does not do it.
17042 * ecore.cs: Remove redundant code for enumerations, make them use
17043 the same code path as everything else, fixes the casting issue
17044 with enumerations in Windows.Forms.
17046 * attribute.cs: Do only cast to string if it is a string, the
17047 validation happens later.
17049 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
17050 people upgrade their corlibs.
17052 * ecore.cs: Oops, enumerations were not following the entire code path
17054 2002-11-21 Miguel de Icaza <miguel@ximian.com>
17056 * typemanager.cs (FilterWithClosure): Commented out the test for
17057 1540 in typemanager.cs, as it has problems when accessing
17058 protected methods from a parent class (see test-174.cs).
17060 * attribute.cs (Attribute.ValidateGuid): new method.
17061 (Attribute.Resolve): Use above.
17063 2002-11-19 Miguel de Icaza <miguel@ximian.com>
17065 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
17067 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
17068 handling for enumerations, as we only needed the TypeContainer
17069 functionality to begin with (this is required for the fix below to
17070 work for enums that reference constants in a container class for
17073 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
17075 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
17076 a valid TypeBuilder to perform lookups on.o
17078 * class.cs (InheritableMemberSignatureCompare): Use true in the
17079 call to GetGetMethod and GetSetMethod, because we are comparing
17080 the signature, and we need to get the methods *even* if they are
17083 (PropertyBase.CheckBase): ditto.
17085 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
17086 GotoCase.Resolve): Use Peel on EmpytCasts.
17088 * ecore.cs (EmptyCast): drop child, add Peel method.
17090 2002-11-17 Martin Baulig <martin@ximian.com>
17092 * ecore.cs (EmptyCast.Child): New public property.
17094 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
17095 label resolved to an EmptyCast. Fixes #34162.
17096 (GotoCase.Resolve): Likewise.
17097 (Block.EmitMeta): Likewise.
17099 2002-11-17 Martin Baulig <martin@ximian.com>
17101 * expression.cs (Invocation.BetterConversion): Prefer int over
17102 uint; short over ushort; long over ulong for integer literals.
17103 Use ImplicitConversionExists instead of StandardConversionExists
17104 since we also need to check for user-defined implicit conversions.
17105 Fixes #34165. Added test-173.cs.
17107 2002-11-16 Martin Baulig <martin@ximian.com>
17109 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
17110 with the `true' and `false' literals. Fixes #33151.
17112 2002-11-16 Martin Baulig <martin@ximian.com>
17114 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
17115 October 22nd; don't do the cs1540 check for static members.
17117 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
17118 now using our own filter here and doing the cs1540 check again.
17120 2002-11-16 Martin Baulig <martin@ximian.com>
17122 * support.cs (InternalParameters): Don't crash if we don't have
17123 any fixed parameters. Fixes #33532.
17125 2002-11-16 Martin Baulig <martin@ximian.com>
17127 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
17128 when looking up static methods to make this work on Windows.
17131 2002-11-16 Martin Baulig <martin@ximian.com>
17133 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
17134 a setter rather than using PropertyInfo.CanWrite.
17136 2002-11-15 Nick Drochak <ndrochak@gol.com>
17138 * class.cs: Allow acces to block member by subclasses. Fixes build
17141 2002-11-14 Martin Baulig <martin@ximian.com>
17143 * class.cs (Constructor.Emit): Added the extern/block check.
17146 2002-11-14 Martin Baulig <martin@ximian.com>
17148 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
17149 iteration while looking for indexers, this is needed because the
17150 indexer may have a different name in our base classes. Fixed the
17151 error reporting (no indexers at all, not get accessor, no
17152 overloaded match). Fixes bug #33089.
17153 (IndexerAccess.DoResolveLValue): Likewise.
17155 2002-11-14 Martin Baulig <martin@ximian.com>
17157 * class.cs (PropertyBase.CheckBase): Make this work for multiple
17158 indexers. Fixes the first part of bug #33089.
17159 (MethodSignature.InheritableMemberSignatureCompare): Added support
17162 2002-11-13 Ravi Pratap <ravi@ximian.com>
17164 * attribute.cs (Attribute.Resolve): Catch the
17165 NullReferenceException and report it since it isn't supposed to
17168 2002-11-12 Miguel de Icaza <miguel@ximian.com>
17170 * expression.cs (Binary.EmitBranchable): Also handle the cases for
17171 LogicalOr and LogicalAnd that can benefit from recursively
17172 handling EmitBranchable. The code now should be nice for Paolo.
17174 2002-11-08 Miguel de Icaza <miguel@ximian.com>
17176 * typemanager.cs (LookupType): Added a negative-hit hashtable for
17177 the Type lookups, as we perform quite a number of lookups on
17178 non-Types. This can be removed once we can deterministically tell
17179 whether we have a type or a namespace in advance.
17181 But this might require special hacks from our corlib.
17185 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
17186 and double which avoids a conversion from an integer to a double.
17188 * expression.cs: tiny optimization, avoid calling IsConstant,
17189 because it effectively performs the lookup twice.
17191 2002-11-06 Miguel de Icaza <miguel@ximian.com>
17193 But a bogus return here to keep the semantics of the old code
17194 until the Mono runtime is fixed.
17196 * pending.cs (GetMissingInterfaces): New method used to remove all
17197 the interfaces that are already implemented by our parent
17198 classes from the list of pending methods.
17200 * interface.cs: Add checks for calls after ResolveTypeExpr.
17202 2002-11-05 Miguel de Icaza <miguel@ximian.com>
17204 * class.cs (Class.Emit): Report warning 67: event not used if the
17205 warning level is beyond 3.
17207 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
17208 being a NullLiteral.
17210 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
17213 * class.cs (TypeContainer.GetClassBases): Cover a missing code
17214 path that might fail if a type can not be resolved.
17216 * expression.cs (Binary.Emit): Emit unsigned versions of the
17219 * driver.cs: use error 5.
17221 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
17223 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
17225 2002-11-01 Miguel de Icaza <miguel@ximian.com>
17227 * cs-parser.jay (switch_section): A beautiful patch from Martin
17228 Baulig that fixed 33094.
17230 2002-10-31 Miguel de Icaza <miguel@ximian.com>
17232 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
17233 Check whether the base is abstract and report an error if so.
17235 * expression.cs (IndexerAccess.DoResolveLValue,
17236 IndexerAccess.DoResolve): ditto.
17238 (Invocation.DoResolve): ditto.
17240 (Invocation.FullMethodDesc): Improve the report string.
17242 * statement.cs (Block): Eliminate IsVariableDefined as it is
17243 basically just a wrapper for GetVariableInfo.
17245 * ecore.cs (SimpleName): Use new
17247 * support.cs (ReflectionParamter.ParameterType): We unwrap the
17248 type, as we return the actual parameter ref/unref state on a
17251 2002-10-30 Miguel de Icaza <miguel@ximian.com>
17253 * support.cs: Return proper flags REF/OUT fixing the previous
17256 * expression.cs: Reverted last patch, that was wrong. Is_ref is
17257 not used to mean `ref' but `ref or out' in ParameterReference
17259 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
17260 full type signature instead of calling TypeManger.CSharpName
17263 * support.cs (InternalParameters.ParameterDesc): Do not compare
17264 directly to the modflags, because REF/OUT will actually be bitsets
17267 * delegate.cs (VerifyMethod): Check also the modifiers.
17269 * cs-tokenizer.cs: Fix bug where floating point values with an
17270 exponent where a sign was missing was ignored.
17272 * driver.cs: Allow multiple assemblies to be specified in a single
17275 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17277 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17278 because identifiers after a parenthesis would end up in this kind
17279 of production, and we needed to desamiguate it for having casts
17282 (UserDefinedType *) xxx
17284 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17286 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17287 we should set on the Bindingflags.NonPublic, but not turn on
17288 private_ok. private_ok controls whether a Private member is
17289 returned (this is chekced on the filter routine), while the
17290 BindingFlags.NonPublic just controls whether private/protected
17291 will be allowed. This fixes the problem part of the problem of
17292 private properties being allowed to be used in derived classes.
17294 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17295 so we can call the children DoResolveLValue method (this will
17296 properly signal errors on lvalue assignments to base properties)
17298 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17299 getter are null, and we have a property info, we know that this
17300 happened because the lookup failed, so we report an error 122 for
17301 protection level violation.
17303 We also silently return if setter and getter are null in the
17304 resolve functions, this condition only happens if we have flagged
17305 the error before. This is the other half of the problem.
17307 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17308 not have accessibility information, that is why we were returning
17309 true in the filter function in typemanager.cs.
17311 To properly report 122 (property is inaccessible because of its
17312 protection level) correctly, we report this error in ResolveAccess
17313 by failing if both the setter and the getter are lacking (ie, the
17316 DoResolve and DoLResolve have been modified to check for both
17317 setter/getter being null and returning silently, the reason being
17318 that I did not want to put the knowledge about this error in upper
17321 int old = Report.Errors;
17322 x = new PropertyExpr (...);
17323 if (old != Report.Errors)
17328 So the property expr is returned, but it is invalid, so the error
17329 will be flagged during the resolve process.
17331 * class.cs: Remove InheritablePropertySignatureCompare from the
17332 class, as we no longer depend on the property signature to compute
17333 whether it is possible to implement a method or not.
17335 The reason is that calling PropertyInfo.GetGetMethod will return
17336 null (in .NET, in Mono it works, and we should change this), in
17337 cases where the Get Method does not exist in that particular
17342 class X { public virtual int A { get { return 1; } } }
17344 class Z : Y { public override int A { get { return 2; } } }
17346 Would fail in Z because the parent (Y) would not have the property
17347 defined. So we avoid this completely now (because the alternative
17348 fix was ugly and slow), and we now depend exclusively on the
17351 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17352 reference method, instead of using the property.
17354 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17355 routines are gone now.
17357 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17358 names, they were incorrectly named.
17360 * cs-tokenizer.cs: Return are more gentle token on failure.
17362 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17363 had an out-of-sync index variable, which caused it to remove from
17364 the list of pending methods the wrong method sometimes.
17366 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17368 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17369 CanWrite, because those refer to this particular instance of the
17370 property, and do not take into account the fact that we can
17371 override single members of a property.
17373 Constructor requires an EmitContext. The resolution process does
17374 not happen here, but we need to compute the accessors before,
17375 because the resolution does not always happen for properties.
17377 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17378 subclass, before we did not update this flag, but we did update
17381 (GetAccessors): Drop this routine, as it did not work in the
17382 presence of partially overwritten set/get methods.
17384 Notice that this broke the cs1540 detection, but that will require
17387 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17391 * driver.cs: issue a warning instead of an error if we don't support
17392 debugging for the platform. Also ignore a couple of errors that may
17393 arise when trying to write the symbols. Undo my previous patch.
17395 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17397 * driver.cs: ignore /debug switch except for Unix platforms.
17399 2002-10-23 Nick Drochak <ndrochak@gol.com>
17401 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17403 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17405 * driver.cs: Do not make mcs-debug conditional, so we do not break
17406 builds that use it.
17408 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17409 review this patch. But basically after all the children variables
17410 have been merged, the value of "Breaks" was not being set to
17411 new_breaks for Switch blocks. I think that it should be set after
17412 it has executed. Currently I set this to the value of new_breaks,
17413 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17414 conservative, but I do not understand this code very well.
17416 I did not break anything in the build, so that is good ;-)
17418 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17420 2002-10-20 Mark Crichton <crichton@gimp.org>
17422 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17424 2002-10-20 Nick Drochak <ndrochak@gol.com>
17426 * cfold.cs: Fixed compile blocker.
17428 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17430 * driver.cs: I was chekcing the key, not the file.
17432 2002-10-19 Ravi Pratap <ravi@ximian.com>
17434 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17435 message that we were generating - we just need to silently return
17438 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17440 * class.cs (Event.Define): Change my previous commit, as this
17441 breaks the debugger. This is a temporary hack, as it seems like
17442 the compiler is generating events incorrectly to begin with.
17444 * expression.cs (Binary.ResolveOperator): Added support for
17445 "U operator - (E x, E y)"
17447 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17450 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17451 init-only variables, but this path did not take into account that
17452 there might be also instance readonly variables. Correct this
17455 This fixes bug 32253
17457 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17460 * driver.cs: Change the extension for modules to `netmodule'
17462 * cs-parser.jay: Improved slightly the location tracking for
17463 the debugger symbols.
17465 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17466 modifiers that were specified instead of the hardcoded value
17467 (FamAndAssem). This was basically ignoring the static modifier,
17468 and others. Fixes 32429.
17470 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17471 fixed a bug in the process (32476)
17473 * expression.cs (ArrayAccess.EmitAssign): Patch from
17474 hwang_rob@yahoo.ca that fixes bug 31834.3
17476 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17478 * driver.cs: Make the module extension .netmodule.
17480 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17482 * driver.cs: Report an error if the resource file is not found
17483 instead of crashing.
17485 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17486 false, like Emit does.
17488 2002-10-16 Nick Drochak <ndrochak@gol.com>
17490 * typemanager.cs: Remove unused private member. Also reported mcs
17491 bug to report this as a warning like csc.
17493 2002-10-15 Martin Baulig <martin@gnome.org>
17495 * statement.cs (Statement.Emit): Made this a virtual method; emits
17496 the line number info and calls DoEmit().
17497 (Statement.DoEmit): New protected abstract method, formerly knows
17498 as Statement.Emit().
17500 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17502 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17504 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17505 have fixed a remaining problem: not every AddXXXX was adding a
17506 fully qualified name.
17508 Now everyone registers a fully qualified name in the DeclSpace as
17509 being defined instead of the partial name.
17511 Downsides: we are slower than we need to be due to the excess
17512 copies and the names being registered this way.
17514 The reason for this is that we currently depend (on the corlib
17515 bootstrap for instance) that types are fully qualified, because
17516 we dump all the types in the namespace, and we should really have
17517 types inserted into the proper namespace, so we can only store the
17518 basenames in the defined_names array.
17520 2002-10-10 Martin Baulig <martin@gnome.org>
17522 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17523 from bug #31834, see the bug report for a testcase which is
17526 2002-10-10 Martin Baulig <martin@gnome.org>
17528 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17529 flow analysis code for this.
17531 * statement.cs (Do, While, For): Tell the flow analysis code about
17533 (FlowBranching.UsageVector): Added support for infinite loops.
17534 (Block.Resolve): Moved the dead code elimination here and use flow
17537 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17539 * class.cs (Field.Define): Catch cycles on struct type
17542 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17543 fields if the fields are static. We only need to check instance
17546 * expression.cs (As.DoResolve): Test for reference type.
17548 * statement.cs (Using.ResolveExpression): Use
17549 ConvertImplicitRequired, not ConvertImplicit which reports an
17551 (Using.ResolveLocalVariableDecls): ditto.
17553 * expression.cs (Binary.ResolveOperator): Report errors in a few
17554 places where we had to.
17556 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17558 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17560 * expression.cs: Use StoreFromPtr instead of extracting the type
17561 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17563 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17564 an enumeration value to a System.Enum, but System.Enum is not a
17565 value type, but an class type, so we need to box.
17567 (Expression.ConvertExplicit): One codepath could return
17568 errors but not flag them. Fix this. Fixes #31853
17570 * parameter.cs (Resolve): Do not allow void as a parameter type.
17572 2002-10-06 Martin Baulig <martin@gnome.org>
17574 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17575 if it's a class type and not a struct. Fixes #31815.
17577 2002-10-06 Martin Baulig <martin@gnome.org>
17579 * statement.cs: Reworked the flow analysis code a bit to make it
17580 usable for dead code elimination.
17582 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17584 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17586 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17588 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17589 to fix the test 165, will investigate deeper.
17591 2002-10-04 Martin Baulig <martin@gnome.org>
17593 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17594 finally blocks actually work.
17595 (Try.Resolve): We don't need to create a sibling for `finally' if
17596 there is no finally block.
17598 2002-10-04 Martin Baulig <martin@gnome.org>
17600 * class.cs (Constructor.Define): The default accessibility for a
17601 non-default constructor is private, not public.
17603 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17605 * class.cs (Constructor): Make AllowedModifiers public, add
17608 * cs-parser.jay: Perform the modifiers test here, as the
17609 constructor for the Constructor class usually receives a zero
17610 because of the way we create it (first we create, later we
17611 customize, and we were never checking the modifiers).
17613 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17614 is a version of LookupTypeReflection that includes the type-name
17615 cache. This can be used as a fast path for functions that know
17616 the fully qualified name and are only calling into *.GetType() to
17617 obtain a composed type.
17619 This is also used by TypeManager.LookupType during its type
17622 (LookupType): We now also track the real type name, as sometimes
17623 we can get a quey for the real type name from things like
17624 ComposedCast. This fixes bug 31422.
17626 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17627 complete type fullname, it does not have to go through the type
17628 resolution system to obtain the composed version of the type (for
17629 obtaining arrays or pointers).
17631 (Conditional.Emit): Use the EmitBoolExpression to
17632 generate nicer code, as requested by Paolo.
17634 (ArrayCreation.CheckIndices): Use the patch from
17635 hwang_rob@yahoo.ca to validate the array initializers.
17637 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17639 * class.cs (ConstructorInitializer.Emit): simplify code by using
17640 Invocation.EmitCall, and at the same time, fix the bugs in calling
17641 parent constructors that took variable arguments.
17643 * ecore.cs (Expression.ConvertNumericExplicit,
17644 Expression.ImplicitNumericConversion): Remove the code that
17645 manually wrapped decimal (InternalTypeConstructor call is now gone
17648 * expression.cs (Cast.TryReduce): Also handle decimal types when
17649 trying to perform a constant fold on the type.
17651 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17653 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17654 that only turned off an error report, and did nothing else.
17656 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17658 * driver.cs: Handle and ignore /fullpaths
17660 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17662 * expression.cs (Binary.ResolveOperator): Catch the case where
17663 DoNumericPromotions returns true,
17665 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17667 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17669 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17672 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17674 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17675 conversion exists, but it is also required that the conversion be
17676 performed. This manifested in "(Type64Enum) 2".
17678 * class.cs (TypeManager.AddMethod): The fix is not to change
17679 AddEnum, because that one was using a fully qualified name (every
17680 DeclSpace derivative does), but to change the AddMethod routine
17681 that was using an un-namespaced name. This now correctly reports
17682 the duplicated name.
17684 Revert patch until I can properly fix it. The issue
17685 is that we have a shared Type space across all namespaces
17686 currently, which is wrong.
17688 Options include making the Namespace a DeclSpace, and merge
17689 current_namespace/current_container in the parser.
17691 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17693 * cs-parser.jay: Improve error reporting when we get a different
17694 kind of expression in local_variable_type and
17695 local_variable_pointer_type.
17697 Propagate this to avoid missleading errors being reported.
17699 * ecore.cs (ImplicitReferenceConversion): treat
17700 TypeManager.value_type as a target just like object_type. As
17705 Is valid, and needs to result in the int 1 being boxed before it
17706 is assigned to the value type v.
17708 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17709 to validate the enumeration name.
17711 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17712 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17713 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17715 * ecore.cs (TryImplicitIntConversion): When doing an
17716 implicit-enumeration-conversion, check if the type is 64-bits and
17717 perform a conversion before passing to EnumConstant.
17719 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17721 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17722 report ambiguous type references. Unlike the MS version, we
17723 report what the ambiguity is. Innovation at work ;-)
17725 (DeclSpace.FindType): Require a location argument to
17726 display when we display an ambiguous error.
17728 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17730 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17732 * expression.cs (EmitDynamicInitializers): Apply patch from
17733 hwang_rob@yahoo.ca that fixes the order in which we emit our
17736 2002-09-21 Martin Baulig <martin@gnome.org>
17738 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17739 delegate takes no arguments.
17741 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17743 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17746 * expression.cs: Extract the underlying type.
17748 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17750 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17752 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17754 * class.cs (TypeContainer.DefineType): We can not use the nice
17755 PackingSize with the size set to 1 DefineType method, because it
17756 will not allow us to define the interfaces that the struct
17759 This completes the fixing of bug 27287
17761 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17762 means also structs. This fixes part of the problem.
17763 (Expresion.ImplicitReferenceConversionExists): ditto.
17765 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17766 error if there were no errors reported during the type lookup
17767 process, to avoid duplicates or redundant errors. Without this
17768 you would get an ambiguous errors plus a type not found. We have
17769 beaten the user enough with the first error.
17771 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17774 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17775 during the resolution process, stop the lookup, this avoids
17776 repeated error reports (same error twice).
17778 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17780 * typemanager.cs (LookupType): Redo the type lookup code to match
17781 the needs of System.Reflection.
17783 The issue is that System.Reflection requires references to nested
17784 types to begin with a "+" sign instead of a dot. So toplevel
17785 types look like: "NameSpace.TopLevelClass", and nested ones look
17786 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17789 2002-09-19 Martin Baulig <martin@gnome.org>
17791 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17792 says that a method always returns or always throws an exception,
17793 don't report the CS0161.
17795 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17796 set `Returns = new_returns'.
17798 2002-09-19 Martin Baulig <martin@gnome.org>
17800 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17801 to an enum constant, check for a CS0176.
17803 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17805 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17806 for operators that must be in pairs and report errors.
17808 * ecore.cs (SimpleName.DoResolveType): During the initial type
17809 resolution process, when we define types recursively, we must
17810 check first for types in our current scope before we perform
17811 lookups in the enclosing scopes.
17813 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17815 (Invocation.VerifyArgumentsCompat): Call
17816 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17817 I thought we were supposed to always call this, but there are a
17818 few places in the code where we dont do it.
17820 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17822 * driver.cs: Add support in -linkres and -resource to specify the
17823 name of the identifier.
17825 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17827 * ecore.cs (StandardConversionExists): Sync with the conversion
17828 code: allow anything-* to void* conversions.
17830 (FindMostSpecificSource): Use an Expression argument
17831 instead of a Type, because we might be handed over a Literal which
17832 gets a few more implicit conversions that plain types do not. So
17833 this information was being lost.
17835 Also, we drop the temporary type-holder expression when not
17838 2002-09-17 Martin Baulig <martin@gnome.org>
17840 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17841 this is an explicit interface implementation.
17843 2002-09-17 Martin Baulig <martin@gnome.org>
17845 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17846 different `IndexerName' attributes.
17848 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17849 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17850 virtual CommonResolve().
17852 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17854 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17855 and convert that to the UnderlyingType.
17857 * statement.cs (Foreach.Resolve): Indexers are just like variables
17858 or PropertyAccesses.
17860 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17861 inside quoted strings, we were not doing this before.
17863 2002-09-16 Martin Baulig <martin@gnome.org>
17865 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17866 resolve it. This is needed for the definite assignment check of the
17867 instance expression, fixes bug #29846.
17868 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17870 2002-09-16 Nick Drochak <ndrochak@gol.com>
17872 * parameter.cs: Fix compile error. Cannot reference static member
17873 from an instance object. Is this an mcs bug?
17875 2002-09-14 Martin Baulig <martin@gnome.org>
17877 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17878 multiple times. Fixes bug #30295, added test-166.cs.
17880 2002-09-14 Martin Baulig <martin@gnome.org>
17882 * statement.cs (Block.Emit): Don't emit unreachable code.
17883 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
17884 `break' statements.
17885 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
17887 2002-09-14 Martin Baulig <martin@gnome.org>
17889 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
17892 2002-09-14 Martin Baulig <martin@gnome.org>
17894 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
17895 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
17896 be false on the ms runtime.
17898 2002-09-13 Martin Baulig <martin@gnome.org>
17900 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
17901 the CS0038 error message.
17903 2002-09-12 Miguel de Icaza <miguel@ximian.com>
17905 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
17906 constant inside, return it.
17908 2002-09-12 Martin Baulig <martin@gnome.org>
17910 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
17911 implicit conversion can be done between enum types.
17913 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
17914 check whether an implicit conversion to the current enum's UnderlyingType
17915 exists and report an error if not.
17917 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
17918 without debugging support.
17920 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
17921 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
17923 2002-09-12 Martin Baulig <martin@gnome.org>
17925 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
17927 * ecore.cs (IMemberExpr.DeclaringType): New property.
17928 (SimpleName.SimpleNameResolve): Check whether we're accessing a
17929 nonstatic member of an outer type (CS0038).
17931 2002-09-11 Miguel de Icaza <miguel@ximian.com>
17933 * driver.cs: Activate the using-error detector at warning level
17934 4 (at least for MS-compatible APIs).
17936 * namespace.cs (VerifyUsing): Small buglett fix.
17938 * pending.cs (PendingImplementation): pass the container pointer.
17940 * interface.cs (GetMethods): Allow for recursive definition. Long
17941 term, I would like to move every type to support recursive
17942 definitions, not the current ordering mechanism that we have right
17945 The situation is this: Attributes are handled before interfaces,
17946 so we can apply attributes to interfaces. But some attributes
17947 implement interfaces, we will now handle the simple cases
17948 (recursive definitions will just get an error).
17950 * parameter.cs: Only invalidate types at the end if we fail to
17953 2002-09-09 Martin Baulig <martin@gnome.org>
17955 * ecore.cs (PropertyExpr.Emit): Also check for
17956 TypeManager.system_int_array_get_length so this'll also work when
17957 compiling corlib. Fixes #30003.
17959 2002-09-09 Martin Baulig <martin@gnome.org>
17961 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
17962 and throw an exception if we can't get the type's size. Fixed #30040,
17965 2002-09-09 Martin Baulig <martin@gnome.org>
17967 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
17969 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
17970 context. Fixes bug #30027.
17972 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
17973 virtual functions. Fixes bug #30043, added test-164.cs.
17975 2002-09-08 Ravi Pratap <ravi@ximian.com>
17977 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
17979 2002-09-08 Nick Drochak <ndrochak@gol.com>
17981 * driver.cs: Use an object to get the windows codepage since it's not a
17984 2002-09-08 Miguel de Icaza <miguel@ximian.com>
17986 * statement.cs (For.Emit): for infinite loops (test == null)
17987 return whether there is a break inside, not always "true".
17989 * namespace.cs (UsingEntry): New struct to hold the name of the
17990 using definition, the location where it is defined, and whether it
17991 has been used in a successful type lookup.
17993 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
17998 2002-09-06 Ravi Pratap <ravi@ximian.com>
18000 * attribute.cs : Fix incorrect code which relied on catching
18001 a NullReferenceException to detect a null being passed in
18002 where an object was expected.
18004 2002-09-06 Miguel de Icaza <miguel@ximian.com>
18006 * statement.cs (Try): flag the catch variable as assigned
18008 * expression.cs (Cast): Simplified by using ResolveType instead of
18009 manually resolving.
18011 * statement.cs (Catch): Fix bug by using ResolveType.
18013 2002-09-06 Ravi Pratap <ravi@ximian.com>
18015 * expression.cs (BetterConversion): Special case for when we have
18016 a NullLiteral as the argument and we have to choose between string
18017 and object types - we choose string the way csc does.
18019 * attribute.cs (Attribute.Resolve): Catch the
18020 NullReferenceException and report error #182 since the Mono
18021 runtime no more has the bug and having this exception raised means
18022 we tried to select a constructor which takes an object and is
18025 2002-09-05 Ravi Pratap <ravi@ximian.com>
18027 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
18028 message (1502, 1503) when we can't locate a method after overload
18029 resolution. This is much more informative and closes the bug
18032 * interface.cs (PopulateMethod): Return if there are no argument
18033 types. Fixes a NullReferenceException bug.
18035 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
18036 expressions too. Previously we were checking only in one place for
18037 positional arguments leaving out named arguments.
18039 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
18040 type to the enum type is not allowed. Remove code corresponding to
18043 (ConvertNumericExplicit): Allow explicit conversions from
18044 the underlying type to enum type. This precisely follows the spec
18045 and closes a bug filed by Gonzalo.
18047 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18050 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
18052 2002-09-03 Miguel de Icaza <miguel@ximian.com>
18054 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
18055 it was important that we stored the right value after the
18056 reduction in `converted'.
18058 2002-09-04 Martin Baulig <martin@gnome.org>
18060 * location.cs (Location.SymbolDocument): Use full pathnames for the
18063 2002-08-30 Miguel de Icaza <miguel@ximian.com>
18065 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
18066 of the expression resolve mechanism, because that will catch the
18067 SimpleName error failures.
18069 (Conditional): If we can not resolve the
18070 expression, return, do not crash.
18072 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18075 (location): display token name instead of its number.
18077 2002-08-28 Martin Baulig <martin@gnome.org>
18079 * expression.cs (Binary.ResolveOperator): Don't silently return
18080 but return an error if an operator cannot be applied between two
18083 2002-08-28 Martin Baulig <martin@gnome.org>
18085 * class.cs (Constructor.Define): Set the permission attributes
18086 correctly instead of making all constructors public.
18088 2002-08-28 Martin Baulig <martin@gnome.org>
18090 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
18091 for private members before reporting a CS0103; if we find anything,
18094 2002-08-28 Martin Baulig <martin@gnome.org>
18096 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
18097 to check whether `closure_start_type == closure_invocation_type',
18098 we also need to check whether `m.DeclaringType == closure_invocation_type'
18099 before bypassing the permission checks. We might be accessing
18100 protected/private members from the base class.
18101 (TypeManager.RealMemberLookup): Only set private_ok if private
18102 members were requested via BindingFlags.NonPublic.
18104 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
18106 * expression.cs (MemberAccess.ResolveMemberAccess): Set
18107 MethodGroupExpr.IsExplicitImpl if appropriate.
18108 (Invocation.DoResolve): Don't report the CS0120 for explicit
18109 interface implementations.
18111 2002-08-27 Martin Baulig <martin@gnome.org>
18113 * expression.cs (Invocation.DoResolve): If this is a static
18114 method and we don't have an InstanceExpression, we must report
18117 2002-08-25 Martin Baulig <martin@gnome.org>
18119 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
18120 `==' between a valuetype and an object.
18122 2002-08-25 Miguel de Icaza <miguel@ximian.com>
18124 * ecore.cs (TypeExpr): Provide a ToString method.
18126 2002-08-24 Martin Baulig <martin@gnome.org>
18128 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
18129 now called proggie.dbg and it's a binary file.
18131 2002-08-23 Martin Baulig <martin@gnome.org>
18133 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
18135 2002-08-23 Martin Baulig <martin@gnome.org>
18137 * struct.cs (MyStructInfo.ctor): Make this work with empty
18138 structs; it's not allowed to use foreach() on null.
18140 2002-08-23 Martin Baulig <martin@gnome.org>
18142 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
18143 writer the full pathname of the generated assembly.
18145 2002-08-23 Martin Baulig <martin@gnome.org>
18147 * statements.cs (FlowBranching.UsageVector.MergeChildren):
18148 A `finally' block never returns or breaks; improved handling of
18151 2002-08-23 Martin Baulig <martin@gnome.org>
18153 * statement.cs (Throw.Resolve): Allow `throw null'.
18155 2002-08-23 Martin Baulig <martin@gnome.org>
18157 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
18158 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
18159 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
18160 MemberLookup would return a wrong event if this is an explicit
18161 interface implementation and the class has an event with the same
18164 2002-08-23 Martin Baulig <martin@gnome.org>
18166 * statement.cs (Block.AddChildVariableNames): New public method.
18167 (Block.AddChildVariableName): Likewise.
18168 (Block.IsVariableNameUsedInChildBlock): Likewise.
18169 (Block.AddVariable): Check whether a variable name has already
18170 been used in a child block.
18172 * cs-parser.jay (declare_local_variables): Mark all variable names
18173 from the current block as being used in a child block in the
18176 2002-08-23 Martin Baulig <martin@gnome.org>
18178 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
18179 find the symbol writer.
18181 * driver.cs: csc also allows the arguments to /define being
18182 separated by commas, not only by semicolons.
18184 2002-08-23 Martin Baulig <martin@gnome.org>
18186 * interface.cs (Interface.GetMembers): Added static check for events.
18188 2002-08-15 Martin Baulig <martin@gnome.org>
18190 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
18191 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
18193 * ecore.cs (Expression.MemberLookup): Added documentation and explained
18194 why the MethodData.EmitDestructor() change was necessary.
18196 2002-08-20 Martin Baulig <martin@gnome.org>
18198 * class.cs (TypeContainer.FindMembers): Added static check for events.
18200 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
18202 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
18203 use Type.GetEvents(), not Type.FindMembers().
18205 2002-08-20 Martin Baulig <martin@gnome.org>
18207 * decl.cs (MemberCache): Added a special method cache which will
18208 be used for method-only searched. This ensures that a method
18209 search will return a MethodInfo with the correct ReflectedType for
18212 2002-08-20 Martin Baulig <martin@gnome.org>
18214 * decl.cs (DeclSpace.FindMembers): Made this public.
18216 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18218 * delegate.cs: fixed build on windows.
18219 [FIXME: Filed as bug #29150: MCS must report these errors.]
18221 2002-08-19 Ravi Pratap <ravi@ximian.com>
18223 * ecore.cs (StandardConversionExists): Return a false
18224 if we are trying to convert the void type to anything else
18225 since that is not allowed.
18227 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
18228 we flag error 70 in the event an event is trying to be accessed
18229 directly from outside the declaring type.
18231 2002-08-20 Martin Baulig <martin@gnome.org>
18233 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
18234 MemberCache from typemanager.cs to decl.cs.
18236 2002-08-19 Martin Baulig <martin@gnome.org>
18238 * class.cs (TypeContainer): Implement IMemberContainer.
18239 (TypeContainer.DefineMembers): Create the MemberCache.
18240 (TypeContainer.FindMembers): Do better BindingFlags checking; only
18241 return public members if BindingFlags.Public was given, check
18242 whether members are static.
18244 2002-08-16 Martin Baulig <martin@gnome.org>
18246 * decl.cs (DeclSpace.Define): Splitted this in Define and
18247 DefineMembers. DefineMembers is called first and initializes the
18250 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
18251 DefineMembers() on all our DeclSpaces.
18253 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
18254 but call DefineMembers() on all nested interfaces. We call their
18255 Define() in our new Define() function.
18257 * interface.cs (Interface): Implement IMemberContainer.
18258 (Interface.Define): Moved all code except the attribute stuf to
18260 (Interface.DefineMembers): Initialize the member cache.
18262 * typemanager.cs (IMemberFinder): Removed this interface, we don't
18263 need this anymore since we can use MemberCache.FindMembers directly.
18265 2002-08-19 Martin Baulig <martin@gnome.org>
18267 * typemanager.cs (MemberCache): When creating the cache for an
18268 interface type, add all inherited members.
18269 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18270 to `out bool used_cache' and documented it.
18271 (TypeManager.MemberLookup): If we already used the cache in the first
18272 iteration, we don't need to do the interfaces check.
18274 2002-08-19 Martin Baulig <martin@gnome.org>
18276 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18277 here from IMemberFinder and don't implement this interface anymore.
18278 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18280 * typemanager.cs (IMemberFinder): This interface is now only used by
18281 classes which actually support the member cache.
18282 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18283 since we only put DeclSpaces into this Hashtable.
18284 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18285 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18287 2002-08-16 Martin Baulig <martin@gnome.org>
18289 * typemanager.cs (ICachingMemberFinder): Removed.
18290 (IMemberFinder.MemberCache): New property.
18291 (TypeManager.FindMembers): Merged this with RealFindMembers().
18292 This function will never be called from TypeManager.MemberLookup()
18293 so we can't use the cache here, just the IMemberFinder.
18294 (TypeManager.MemberLookup_FindMembers): Check whether the
18295 IMemberFinder has a MemberCache and call the cache's FindMembers
18297 (MemberCache): Rewrote larger parts of this yet another time and
18298 cleaned it up a bit.
18300 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18302 * driver.cs (LoadArgs): Support quoting.
18304 (Usage): Show the CSC-like command line arguments.
18306 Improved a few error messages.
18308 2002-08-15 Martin Baulig <martin@gnome.org>
18310 * typemanager.cs (IMemberContainer.Type): New property.
18311 (IMemberContainer.IsInterface): New property.
18313 The following changes are conditional to BROKEN_RUNTIME, which is
18314 defined at the top of the file.
18316 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18317 class'es members, but add all members from TypeHandle.ObjectType
18318 if we're an interface.
18319 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18320 is the current type.
18321 (MemberCache.CacheEntry.Container): Removed this field.
18322 (TypeHandle.GetMembers): Include inherited members.
18324 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18326 * typemanager.cs: fixed compilation and added a comment on a field that
18329 2002-08-15 Martin Baulig <martin@gnome.org>
18331 * class.cs (ConstructorInitializer.Resolve): In the
18332 Expression.MemberLookup call, use the queried_type as
18335 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18336 declared' attribute, it's always true.
18337 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18338 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18339 temporary wrapper for FindMembers which tells MemberLookup whether
18340 members from the base classes are included in the return value.
18341 This will go away soon.
18342 (TypeManager.MemberLookup): Use this temporary hack here; once the
18343 new MemberCache is completed, we don't need to do the DeclaredOnly
18344 looping here anymore since the MemberCache will take care of this.
18345 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18346 (MemberCache): When creating the MemberCache for a class, get
18347 members from the current class and all its base classes.
18348 (MemberCache.CacheEntry.Container): New field. This is a
18349 temporary hack until the Mono runtime is fixed to distinguish
18350 between ReflectedType and DeclaringType. It allows us to use MCS
18351 with both the MS runtime and the unfixed Mono runtime without
18352 problems and without accecting performance.
18353 (MemberCache.SearchMembers): The DeclaredOnly looping from
18354 TypeManager.MemberLookup is now done here.
18356 2002-08-14 Martin Baulig <martin@gnome.org>
18358 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18359 Type.GetFields on dynamic types but get the fields from the
18360 corresponding TypeContainer.
18361 (MyStructInfo.GetStructInfo): Added check for enum types.
18363 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18364 (MemberList.SyncRoot): Implemented.
18365 (TypeManager.FilterWithClosure): No need to check permissions if
18366 closure_start_type == closure_invocation_type, don't crash if
18367 closure_invocation_type is null.
18369 2002-08-13 Martin Baulig <martin@gnome.org>
18371 Rewrote TypeContainer.FindMembers to use a member cache. This
18372 gives us a speed increase of about 35% for the self-hosting MCS
18373 build and of about 15-20% for the class libs (both on GNU/Linux).
18375 * report.cs (Timer): New class to get enhanced profiling. This
18376 whole class is "TIMER" conditional since it remarkably slows down
18379 * class.cs (MemberList): New class. This is an IList wrapper
18380 which we're now using instead of passing MemberInfo[]'s around to
18381 avoid copying this array unnecessarily.
18382 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18383 (ICachingMemberFinder, IMemberContainer): New interface.
18384 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18385 has already been checked, otherwise use it for the name comparision.
18386 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18387 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18388 if possible. Returns a MemberList, not a MemberInfo [].
18389 (TypeHandle): New class, implements IMemberContainer. We create
18390 one instance of this class per type, it contains a MemberCache
18391 which is used to do the member lookups.
18392 (MemberCache): New class. Each instance of this class contains
18393 all members of a type and a name-based hash table.
18394 (MemberCache.FindMembers): This is our new member lookup
18395 function. First, it looks up all members of the requested name in
18396 the hash table. Then, it walks this list and sorts out all
18397 applicable members and returns them.
18399 2002-08-13 Martin Baulig <martin@gnome.org>
18401 In addition to a nice code cleanup, this gives us a performance
18402 increase of about 1.4% on GNU/Linux - not much, but it's already
18403 half a second for the self-hosting MCS compilation.
18405 * typemanager.cs (IMemberFinder): New interface. It is used by
18406 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18407 Enum, Delegate or Interface.
18408 (TypeManager.finder_to_member_finder): New PtrHashtable.
18409 (TypeManager.finder_to_container): Removed.
18410 (TypeManager.finder_to_delegate): Removed.
18411 (TypeManager.finder_to_interface): Removed.
18412 (TypeManager.finder_to_enum): Removed.
18414 * interface.cs (Interface): Implement IMemberFinder.
18416 * delegate.cs (Delegate): Implement IMemberFinder.
18418 * enum.cs (Enum): Implement IMemberFinder.
18420 * class.cs (TypeContainer): Implement IMemberFinder.
18422 2002-08-12 Martin Baulig <martin@gnome.org>
18424 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18426 2002-08-12 Martin Baulig <martin@gnome.org>
18428 * ecore.cs (ITypeExpression): New interface for expressions which
18430 (TypeExpression): Renamed to TypeLookupExpression.
18431 (Expression.DoResolve): If we're doing a types-only lookup, the
18432 expression must implement the ITypeExpression interface and we
18433 call DoResolveType() on it.
18434 (SimpleName): Implement the new ITypeExpression interface.
18435 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18436 hack, the situation that we're only looking up types can't happen
18437 anymore when this method is called. Moved the type lookup code to
18438 DoResolveType() and call it.
18439 (SimpleName.DoResolveType): This ITypeExpression interface method
18440 is now doing the types-only lookup.
18441 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18442 (ResolveFlags): Added MaskExprClass.
18444 * expression.cs (MemberAccess): Implement the ITypeExpression
18446 (MemberAccess.DoResolve): Added support for a types-only lookup
18447 when we're called via ITypeExpression.DoResolveType().
18448 (ComposedCast): Implement the ITypeExpression interface.
18450 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18451 Expression.Resolve() with ResolveFlags.Type instead.
18453 2002-08-12 Martin Baulig <martin@gnome.org>
18455 * interface.cs (Interface.Define): Apply attributes.
18457 * attribute.cs (Attribute.ApplyAttributes): Added support for
18458 interface attributes.
18460 2002-08-11 Martin Baulig <martin@gnome.org>
18462 * statement.cs (Block.Emit): Only check the "this" variable if we
18463 do not always throw an exception.
18465 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18466 whether the property has a set accessor.
18468 2002-08-11 Martin Baulig <martin@gnome.org>
18470 Added control flow analysis support for structs.
18472 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18473 with control flow analysis turned off.
18474 (IVariable): New interface.
18475 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18476 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18477 (FieldExpr.DoResolve): Resolve the instance expression with flow
18478 analysis turned off and do the definite assignment check after the
18479 resolving when we know what the expression will resolve to.
18481 * expression.cs (LocalVariableReference, ParameterReference):
18482 Implement the new IVariable interface, only call the flow analysis
18483 code if ec.DoFlowAnalysis is true.
18484 (This): Added constructor which takes a Block argument. Implement
18485 the new IVariable interface.
18486 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18487 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18488 This does the definite assignment checks for struct members.
18490 * class.cs (Constructor.Emit): If this is a non-static `struct'
18491 constructor which doesn't have any initializer, call
18492 Block.AddThisVariable() to tell the flow analysis code that all
18493 struct elements must be initialized before control returns from
18496 * statement.cs (MyStructInfo): New public class.
18497 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18498 argument to this indexer. If non-zero, check an individual struct
18499 member, not the whole struct.
18500 (FlowBranching.CheckOutParameters): Check struct members.
18501 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18502 overloaded versions of these methods which take an additional
18503 `int field_idx' argument to check struct members.
18504 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18505 overloaded versions of these methods which take an additional
18506 `string field_name' argument to check struct member.s
18507 (VariableInfo): Implement the IVariable interface.
18508 (VariableInfo.StructInfo): New public property. Returns the
18509 MyStructInfo instance of the variable if it's a struct or null.
18510 (Block.AddThisVariable): New public method. This is called from
18511 Constructor.Emit() for non-static `struct' constructor which do
18512 not have any initializer. It creates a special variable for the
18513 "this" instance variable which will be checked by the flow
18514 analysis code to ensure that all of the struct's fields are
18515 initialized before control returns from the constructor.
18516 (UsageVector): Added support for struct members. If a
18517 variable/parameter is a struct with N members, we reserve a slot
18518 in the usage vector for each member. A struct is considered fully
18519 initialized if either the struct itself (slot 0) or all its
18520 members are initialized.
18522 2002-08-08 Martin Baulig <martin@gnome.org>
18524 * driver.cs (Driver.MainDriver): Only report an error CS5001
18525 if there were no compilation errors.
18527 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18528 `UnsafeContext' property to determine whether the parent is in
18529 unsafe context rather than checking the parent's ModFlags:
18530 classes nested in an unsafe class are unsafe as well.
18532 2002-08-08 Martin Baulig <martin@gnome.org>
18534 * statement.cs (UsageVector.MergeChildren): Distinguish between
18535 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18536 we return. Added test17() and test18() to test-154.cs.
18538 2002-08-08 Martin Baulig <martin@gnome.org>
18540 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18541 Family access, make sure the invoking type isn't a subclass of the
18542 queried type (that'd be a CS1540).
18544 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18545 this method which takes an additional `Type invocation_type'.
18547 * expression.cs (BaseAccess.DoResolve): Use the base type as
18548 invocation and query type.
18549 (MemberAccess.DoResolve): If the lookup failed and we're about to
18550 report a CS0122, try a lookup with the ec.ContainerType - if this
18551 succeeds, we must report a CS1540.
18553 2002-08-08 Martin Baulig <martin@gnome.org>
18555 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18556 (MethodGroupExpr): Implement the IMemberExpr interface.
18558 * expression (MemberAccess.ResolveMemberAccess): No need to have
18559 any special code for MethodGroupExprs anymore, they're now
18562 2002-08-08 Martin Baulig <martin@gnome.org>
18564 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18565 Family, FamANDAssem and FamORAssem permissions.
18566 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18568 2002-08-08 Martin Baulig <martin@gnome.org>
18570 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18571 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18574 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18576 * driver.cs: implemented /resource option to embed managed resources.
18578 2002-08-07 Martin Baulig <martin@gnome.org>
18580 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18581 (FieldBase.HasFieldInitializer): New public property.
18582 (FieldBase.GetInitializerExpression): New public method. Resolves and
18583 returns the field initializer and makes sure it is only resolved once.
18584 (TypeContainer.EmitFieldInitializers): Call
18585 FieldBase.GetInitializerExpression to get the initializer, this ensures
18586 that it isn't resolved multiple times.
18588 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18589 the resolving process (SimpleName/MemberLookup) that we're currently
18590 emitting a field initializer (which must not access any instance members,
18591 this is an error CS0236).
18593 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18594 argument, if the `IsFieldInitializer' flag is set, we must report and
18595 error CS0236 and not an error CS0120.
18597 2002-08-07 Martin Baulig <martin@gnome.org>
18599 * ecore.cs (IMemberExpr): New public interface.
18600 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18601 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18602 if the expression is an IMemberExpr.
18604 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18605 to be null, implicitly default to `this' if we're non-static in
18606 this case. Simplified the code a lot by using the new IMemberExpr
18607 interface. Also fixed bug #28176 here.
18609 2002-08-06 Martin Baulig <martin@gnome.org>
18611 * cs-parser.jay (SimpleLookup): Removed. We need to create
18612 ParameterReferences during semantic analysis so that we can do a
18613 type-only search when resolving Cast, TypeOf and SizeOf.
18614 (block): Pass the `current_local_parameters' to the Block's
18617 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18618 argument to the constructor.
18619 (ConstructorInitializer.Resolve): Create a temporary implicit
18620 block with the parameters.
18622 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18623 references here if we aren't doing a type-only search.
18625 * statement.cs (Block): Added constructor which takes a
18626 `Parameters parameters' argument.
18627 (Block.Parameters): New public property.
18629 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18630 to `Parameters' and made it public readonly.
18632 2002-08-06 Martin Baulig <martin@gnome.org>
18634 * ecore.cs (Expression.Warning): Made this public as well.
18636 * report.cs (Report.Debug): Print the contents of collections.
18638 2002-08-06 Martin Baulig <martin@gnome.org>
18640 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18641 used to tell Resolve() which kinds of expressions it may return.
18642 (Expression.Resolve): Added overloaded version of this method which
18643 takes a `ResolveFlags flags' argument. This can be used to tell
18644 Resolve() which kinds of expressions it may return. Reports a
18646 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18647 ResolveFlags.SimpleName.
18648 (Expression.Error118): Added overloaded version of this method which
18649 takes a `ResolveFlags flags' argument. It uses the flags to determine
18650 which kinds of expressions are allowed.
18652 * expression.cs (Argument.ResolveMethodGroup): New public method.
18653 Resolves an argument, but allows a MethodGroup to be returned.
18654 This is used when invoking a delegate.
18656 * TODO: Updated a bit.
18658 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18660 Fixed compilation with csc.
18662 * ecore.cs: Expression.Error made public. Is this correct? Should
18663 Warning be made public too?
18665 * expression.cs: use ea.Location instead of ea.loc.
18666 [FIXME: Filed as bug #28607: MCS must report these errors.]
18668 2002-08-06 Martin Baulig <martin@gnome.org>
18670 * ecore.cs (Expression.loc): Moved the location here instead of
18671 duplicating it in all derived classes.
18672 (Expression.Location): New public property.
18673 (Expression.Error, Expression.Warning): Made them non-static and
18674 removed the location argument.
18675 (Expression.Warning): Added overloaded version which takes an
18676 `int level' argument.
18677 (Expression.Error118): Make this non-static and removed the
18678 expression and location arguments.
18679 (TypeExpr): Added location argument to the constructor.
18681 * expression.cs (StaticCallExpr): Added location argument to
18683 (Indirection, PointerArithmetic): Likewise.
18684 (CheckedExpr, UnCheckedExpr): Likewise.
18685 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18686 (StringPtr): Likewise.
18689 2002-08-05 Martin Baulig <martin@gnome.org>
18691 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18693 * assign.cs (Assign.DoResolve): Check whether the source
18694 expression is a value or variable.
18696 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18697 while resolving the corresponding blocks.
18699 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18700 an error, don't silently return null.
18702 * statement.cs (Block.AddVariable): Do the error reporting here
18703 and distinguish between CS0128 and CS0136.
18704 (Block.DoResolve): Report all unused labels (warning CS0164).
18705 (LabeledStatement): Pass the location to the constructor.
18706 (LabeledStatement.HasBeenReferenced): New property.
18707 (LabeledStatement.Resolve): Set it to true here.
18709 * statement.cs (Return.Emit): Return success even after reporting
18710 a type mismatch error (CS0126 or CS0127), this is what csc does and
18711 it avoids confusing the users with any consecutive errors.
18713 2002-08-05 Martin Baulig <martin@gnome.org>
18715 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18717 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18719 * expression.cs (MemberAccess.DoResolve): Silently return if an
18720 error has already been reported.
18722 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18723 error has already been reported.
18725 2002-08-05 Martin Baulig <martin@gnome.org>
18727 * statement.cs (UsageVector): Only initialize the `parameters'
18728 vector if we actually have any "out" parameters.
18730 2002-08-05 Martin Baulig <martin@gnome.org>
18732 * expression.cs (Binary.ResolveOperator): When combining delegates,
18733 they must have the same type.
18735 2002-08-05 Martin Baulig <martin@gnome.org>
18737 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18738 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18739 work with the ms runtime and we also don't need it: if we're a
18740 PropertyBuilder and not in the `indexer_arguments' hash, then we
18741 are a property and not an indexer.
18743 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18744 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18745 since the latter one doesn't work with the ms runtime.
18747 2002-08-03 Martin Baulig <martin@gnome.org>
18749 Fixed bugs #27998 and #22735.
18751 * class.cs (Method.IsOperator): New public field.
18752 (Method.CheckBase): Report CS0111 if there's already a method
18753 with the same parameters in the current class. Report CS0508 when
18754 attempting to change the return type of an inherited method.
18755 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18756 and it's not marked abstract or extern.
18757 (PropertyBase): New abstract base class for Property and Indexer.
18758 (PropertyBase.CheckBase): Moved here from Property and made it work
18760 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18761 the same so we can reuse it there.
18762 (Property, Indexer): Derive from PropertyBase.
18763 (MethodSignature.inheritable_property_signature_filter): New delegate
18764 to find properties and indexers.
18766 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18767 argument and improved error reporting.
18769 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18770 EmptyReadOnlyParameters and made it a property.
18772 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18773 version of this method which takes a `PropertyInfo indexer'.
18774 (TypeManager.RegisterIndexer): New method.
18776 * class.cs: Added myself as author of this file :-)
18778 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18780 * class.cs: fixed compilation on windoze.
18782 2002-08-03 Martin Baulig <martin@gnome.org>
18784 * interface.cs (Interface.GetInterfaceBases): Check whether all
18785 base interfaces are at least as accessible than the current one.
18787 * class.cs (TypeContainer.GetClassBases): Check whether base types
18788 are at least as accessible than the current type.
18789 (TypeContainer.AsAccessible): Implemented and made non-static.
18790 (MemberBase.CheckParameters): Report errors if the accessibility
18793 * delegate.cs (Delegate.Delegate): The default visibility is
18794 internal for top-level types and private for nested types.
18795 (Delegate.Define): Report errors if the accessibility checks fail.
18797 * enum.cs (Enum.Enum): The default visibility is internal for
18798 top-level types and private for nested types.
18799 (Enum.DefineType): Compute the correct visibility.
18801 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18802 function which takes a `bool is_toplevel' instead of a TypeContainer.
18804 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18807 2002-08-02 Martin Baulig <martin@gnome.org>
18809 * expression.cs (LocalVariableReferenc): Added constructor which
18810 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18811 (LocalVariableReference.IsReadOnly): New property.
18812 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18813 variable is readonly, use our own readonly flag to do this; you can
18814 use the new constructor to get a writable reference to a read-only
18817 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18818 reference to the local variable.
18820 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18822 * rootcontext.cs (ResolveCore): Also include System.Exception
18824 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18825 we reach an EmptyStatement.
18827 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18830 * expression.cs (Binary.ResolveOperator): Check error result in
18833 use brtrue/brfalse directly and avoid compares to null.
18835 2002-08-02 Martin Baulig <martin@gnome.org>
18837 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18838 Fixes bug #28407, added test-155.cs.
18840 2002-08-01 Martin Baulig <martin@gnome.org>
18842 * class.cs (Event.EmitDefaultMethod): Make this work with static
18843 events. Fixes #28311, added verify-3.cs.
18845 2002-08-01 Martin Baulig <martin@gnome.org>
18847 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18848 `is_disposable' fields.
18849 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18850 `hm.is_disposable' if we're using the collection pattern.
18851 (Foreach.EmitCollectionForeach): Use the correct type for the
18852 enumerator's local variable, only emit the try/finally block if
18853 necessary (fixes #27713).
18855 2002-08-01 Martin Baulig <martin@gnome.org>
18857 * ecore.cs (Expression.report118): Renamed to Error118 and made
18860 * statement.cs (Throw.Resolve): Check whether the expression is of
18861 the correct type (CS0118) and whether the type derives from
18862 System.Exception (CS0155).
18863 (Catch.Resolve): New method. Do the type lookup here and check
18864 whether it derives from System.Exception (CS0155).
18865 (Catch.CatchType, Catch.IsGeneral): New public properties.
18867 * typemanager.cs (TypeManager.exception_type): Added.
18869 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18871 * driver.cs: Updated About function.
18873 2002-07-31 Martin Baulig <martin@gnome.org>
18875 Implemented Control Flow Analysis.
18877 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18878 (EmitContext.CurrentBranching): Added.
18879 (EmitContext.StartFlowBranching): Added.
18880 (EmitContext.EndFlowBranching): Added.
18881 (EmitContext.KillFlowBranching): Added.
18882 (EmitContext.IsVariableAssigned): Added.
18883 (EmitContext.SetVariableAssigned): Added.
18884 (EmitContext.IsParameterAssigned): Added.
18885 (EmitContext.SetParameterAssigned): Added.
18886 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
18887 Added control flow analysis stuff here.
18889 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
18890 resolve the expression as lvalue.
18891 (LocalVariableReference.DoResolve): Check whether the variable has
18892 already been assigned.
18893 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
18894 the parameter as assigned here.
18895 (ParameterReference.DoResolve): Check whether the parameter has already
18897 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
18898 expression as lvalue.
18900 * statement.cs (FlowBranching): New class for the flow analysis code.
18901 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
18902 (LabeledStatement.IsDefined): New public property.
18903 (LabeledStatement.AddUsageVector): New public method to tell flow
18904 analyis that the label may be reached via a forward jump.
18905 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
18907 (VariableInfo.Number): New public field. This is used by flow analysis
18908 to number all locals of a block.
18909 (Block.CountVariables): New public property. This is the number of
18910 local variables in this block (including the locals from all parent
18912 (Block.EmitMeta): Number all the variables.
18914 * statement.cs: Added flow analysis support to all classes.
18916 2002-07-31 Martin Baulig <martin@gnome.org>
18918 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
18919 To get debugging messages, compile mcs with /define:MCS_DEBUG and
18920 then use this argument.
18922 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
18924 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
18925 use this to specify /define options.
18927 2002-07-29 Martin Baulig <martin@gnome.org>
18929 * statement.cs (Fixed): Moved all code that does variable lookups
18930 and resolvings from Emit to Resolve.
18932 * statement.cs (For): Moved all code that does variable lookups
18933 and resolvings from Emit to Resolve.
18935 * statement.cs (Using): Moved all code that does variable lookups
18936 and resolvings from Emit to Resolve.
18938 2002-07-29 Martin Baulig <martin@gnome.org>
18940 * attribute.cs (Attribute.Resolve): Explicitly catch a
18941 System.NullReferenceException when creating the
18942 CustromAttributeBuilder and report a different warning message.
18944 2002-07-29 Martin Baulig <martin@gnome.org>
18946 * support.cs (ParameterData.ParameterName): Added method to
18947 get the name of a parameter.
18949 * typemanager.cs (TypeManager.IsValueType): New public method.
18951 2002-07-29 Martin Baulig <martin@gnome.org>
18953 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
18954 is a flag which specifies that it's either ref or out.
18955 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
18956 the out parameter to `out Parameter.Modifier mod', also set the
18957 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
18959 * support.cs (InternalParameters.ParameterModifier): Distinguish
18960 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18961 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18963 * expression.cs (Argument.GetParameterModifier): Distinguish
18964 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18965 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18967 2002-07-29 Martin Baulig <martin@gnome.org>
18969 * expression.cs (ParameterReference.ParameterReference): Added
18970 `Location loc' argument to the constructor.
18972 * cs-parser.jay: Pass location to ParameterReference.
18974 2002-07-28 Miguel de Icaza <miguel@ximian.com>
18976 * statement.cs (Try): Initialize the location.
18978 * cs-parser.jay: pass location to Try.
18980 * expression.cs (Unary.Reduce): Change the prototype to return
18981 whether a constant fold could be performed or not. The result is
18982 returned in an out parameters. In the case of Indirection and
18983 AddressOf, we want to perform the full tests.
18985 2002-07-26 Miguel de Icaza <miguel@ximian.com>
18987 * statement.cs (Statement.Emit): Flag dead code.
18989 2002-07-27 Andrew Birkett <andy@nobugs.org>
18991 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
18993 2002-07-27 Martin Baulig <martin@gnome.org>
18995 * class.cs (MethodData.Define): Put back call to
18996 TypeManager.AddMethod(), accidentally commented this out.
18998 * report.cs (Debug): New public method to print debugging information,
18999 this is `[Conditional ("DEBUG")]'.
19001 2002-07-26 Martin Baulig <martin@gnome.org>
19003 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
19004 (switch_statement): Push the current_block to the switch_stack and
19005 pop it again when we're done with the switch.
19006 (switch_section): The new block is a child of the current_block.
19007 Fixes bug #24007, added test-152.cs.
19009 2002-07-27 Martin Baulig <martin@gnome.org>
19011 * expression.cs (Invocation.EmitArguments): When calling a varargs
19012 function with only its fixed arguments, we need to pass an empty
19015 2002-07-27 Martin Baulig <martin@gnome.org>
19017 Mono 0.13 has been released.
19019 2002-07-25 Miguel de Icaza <miguel@ximian.com>
19021 * driver.cs: Rename --resource to --linkres, because that is what
19022 we do currently, we dont support --resource yet.
19024 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
19026 2002-07-25 Martin Baulig <martin@gnome.org>
19028 * class.cs (MethodData): New public class. This is a `method builder'
19029 class for a method or one accessor of a Property/Indexer/Event.
19030 (MethodData.GetMethodFlags): Moved here from MemberBase.
19031 (MethodData.ApplyAttributes): Likewise.
19032 (MethodData.ApplyObsoleteAttribute): Likewise.
19033 (MethodData.ApplyConditionalAttribute): Likewise.
19034 (MethodData.ApplyDllImportAttribute): Likewise.
19035 (MethodData.CheckAbstractAndExternal): Likewise.
19036 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
19037 (MethodData.Emit): Formerly known as Method.Emit().
19038 (MemberBase): Moved everything which was specific to a single
19039 accessor/method to MethodData.
19040 (Method): Create a new MethodData and call Define() and Emit() on it.
19041 (Property, Indexer, Event): Create a new MethodData objects for each
19042 accessor and call Define() and Emit() on them.
19044 2002-07-25 Martin Baulig <martin@gnome.org>
19046 Made MethodCore derive from MemberBase to reuse the code from there.
19047 MemberBase now also checks for attributes.
19049 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
19050 (MemberBase.GetMethodFlags): Moved here from class Method and marked
19052 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
19053 `CallingConventions cc' and `Attributes opt_attrs' arguments.
19054 (MemberBase.ApplyAttributes): New virtual method; applies the
19055 attributes to a method or accessor.
19056 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
19057 (MemberBase.ApplyConditionalAttribute): Likewise.
19058 (MemberBase.ApplyDllImportAttribute): Likewise.
19059 (MemberBase.CheckAbstractAndExternal): Likewise.
19060 (MethodCore.ParameterTypes): This is now a property instead of a
19061 method, it's initialized from DoDefineParameters().
19062 (MethodCore.ParameterInfo): Removed the set accessor.
19063 (MethodCore.DoDefineParameters): New protected virtual method to
19064 initialize ParameterTypes and ParameterInfo.
19065 (Method.GetReturnType): We can now simply return the MemberType.
19066 (Method.GetMethodFlags): Override the MemberBase version and add
19067 the conditional flags.
19068 (Method.CheckBase): Moved some code from Define() here, call
19069 DoDefineParameters() here.
19070 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
19071 here to avoid some larger code duplication.
19072 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
19073 ensure that abstract and external accessors don't declare a body.
19075 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
19076 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
19077 lookup in the attribute's parent classes, so we need to abort as soon
19078 as we found the first match.
19079 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
19080 the attribute has no arguments.
19082 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
19085 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19087 * cs-parser.jay: reverted previous patch.
19089 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19091 * cs-parser.jay: fixed bug #22119.
19093 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19095 * attribute.cs: fixed compilation. The error was:
19096 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
19097 be assigned to before control leaves the current method."
19098 [FIXME: Filed as bug #28186: MCS must report this error.]
19100 2002-07-25 Martin Baulig <martin@gnome.org>
19102 * attribute.cs (Attribute.Conditional_GetConditionName): New static
19103 method to pull the condition name ouf of a Conditional attribute.
19104 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
19105 the obsolete message and error flag out of an Obsolete attribute.
19107 * class.cs (Method.GetMethodFlags): New public method to get the
19108 TypeManager.MethodFlags for this method.
19109 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
19111 (Method.Define): Get and apply the Obsolete and Conditional attributes;
19112 if we're overriding a virtual function, set the new private variable
19113 `parent_method'; call the new TypeManager.AddMethod().
19115 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19116 the MethodBuilder and the Method in a PtrHashtable.
19117 (TypeManager.builder_to_method): Added for this purpose.
19118 (TypeManager.MethodFlags): Added IsObsoleteError.
19119 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
19120 Obsolete and Conditional arguments in MethodBuilders. If we discover
19121 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
19122 the message from the attribute.
19124 2002-07-24 Martin Baulig <martin@gnome.org>
19126 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
19127 preprocessor directives, ensure that the argument to #define/#undef is
19128 exactly one identifier and that it's actually an identifier.
19130 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
19133 2002-07-24 Martin Baulig <martin@gnome.org>
19135 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
19136 initialize it to TypeManager.object_type in the constructor.
19137 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
19138 of the `hm.get_current' method if we're using the collection pattern.
19139 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
19140 for the explicit conversion to make it work when we're using the collection
19141 pattern and the `Current' property has a different return type than `object'.
19144 2002-07-24 Martin Baulig <martin@gnome.org>
19146 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
19147 does not match, but don't report any errors. This method is called in
19148 order for all methods in a MethodGroupExpr until a matching method is
19149 found, so we don't want to bail out if the first method doesn't match.
19150 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
19151 matches, report the 123. Fixes #28070.
19153 2002-07-24 Martin Baulig <martin@gnome.org>
19155 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
19156 TypeManager.TypeToCoreType() to the top of the method so the
19157 following equality checks will work. Fixes #28107.
19159 2002-07-24 Martin Baulig <martin@gnome.org>
19161 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
19162 operand is of type uint, and the other operand is of type sbyte,
19163 short or int, the operands are converted to type long." -
19164 Actually do what this comment already told us. Fixes bug #28106,
19167 2002-07-24 Martin Baulig <martin@gnome.org>
19169 * class.cs (MethodBase): New abstract class. This is now a base
19170 class for Property, Indexer and Event to avoid some code duplication
19171 in their Define() and DefineMethods() methods.
19172 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
19173 generic methods for Define() and DefineMethods().
19174 (FieldBase): Derive from MemberBase, not MemberCore.
19175 (Property): Derive from MemberBase, not MemberCore.
19176 (Property.DefineMethod): Moved all the code from this method to the
19177 new MethodBase.DefineAccessor(), just call it with appropriate
19179 (Property.Define): Call the new Property.DoDefine(), this does some
19180 sanity checks and we don't need to duplicate the code everywhere.
19181 (Event): Derive from MemberBase, not MemberCore.
19182 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
19183 accessors, this will also make them work with interface events.
19184 (Indexer): Derive from MemberBase, not MemberCore.
19185 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
19186 (Indexer.Define): Use the new MethodBase functions.
19188 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
19189 argument to the constructor.
19190 (Interface.FindMembers): Added support for interface events.
19191 (Interface.PopluateEvent): Implemented.
19193 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
19195 2002-07-22 Miguel de Icaza <miguel@ximian.com>
19197 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
19198 but this is required to check for a method name being the same as
19199 the containing class.
19203 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19205 * interface.cs: initialize variable.
19207 2002-07-23 Martin Baulig <martin@gnome.org>
19209 Implemented the IndexerName attribute in interfaces.
19211 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
19212 name if this is an explicit interface implementation.
19213 (Indexer.InterfaceIndexerName): New public variable. If we're
19214 implementing an interface indexer, this is the IndexerName in that
19215 interface. Otherwise, it's the IndexerName.
19216 (Indexer.DefineMethod): If we're implementing interface indexer,
19217 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
19218 and Pending.ImplementIndexer methods.
19219 (Indexer.Define): Also define the PropertyBuilder if we're
19220 implementing an interface indexer and this is neither an explicit
19221 interface implementation nor do the IndexerName match the one in
19224 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
19225 If a method is defined here, then we always need to create a proxy
19226 for it. This is used when implementing interface indexers.
19227 (Pending.IsInterfaceIndexer): New public method.
19228 (Pending.ImplementIndexer): New public method.
19229 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
19230 This is used when implementing interface indexers to define a proxy
19232 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
19233 define a proxy if necessary.
19235 * interface.cs (Interface.IndexerName): New public variable.
19236 (Interface.PopulateIndexer): Set the IndexerName.
19237 (Interface.DefineIndexers): New private method. Populate all the
19238 indexers and make sure their IndexerNames match.
19240 * typemanager.cs (IndexerPropertyName): Added support for interface
19243 2002-07-22 Martin Baulig <martin@gnome.org>
19245 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
19246 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
19247 ret if HasReturnLabel.
19248 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
19251 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
19252 and set the ec.LoopBeginTryCatchLevel.
19253 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
19254 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
19255 the current ec.TryCatchLevel, the branch goes out of an exception
19256 block. In this case, we need to use Leave and not Br.
19258 2002-07-22 Martin Baulig <martin@gnome.org>
19260 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
19261 block unless the block does not always return or it is contained in
19262 another try { ... } catch { ... } block. Fixes bug #26506.
19263 Added verify-1.cs to the test suite.
19265 2002-07-22 Martin Baulig <martin@gnome.org>
19267 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
19268 then we do not always return. Fixes bug #24985.
19270 2002-07-22 Martin Baulig <martin@gnome.org>
19272 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19273 lookup on a per-class level; ie. walk up the class hierarchy until we
19274 found at least one applicable method, then choose the best among them.
19275 Fixes bug #24463 and test-29.cs.
19277 2002-07-22 Martin Baulig <martin@gnome.org>
19279 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19280 return types of the methods. The return type is not part of the
19281 signature and we must not check it to make the `new' modifier work.
19282 Fixes bug #27999, also added test-147.cs.
19283 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19285 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19286 on the method's return type.
19288 2002-07-21 Martin Baulig <martin@gnome.org>
19290 * assign.cs: Make this work if the rightmost source is a constant and
19291 we need to do an implicit type conversion. Also adding a few more tests
19292 to test-38.cs which should have caught this.
19294 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19295 target in the makefile for this. The makefile.gnu is primarily intended
19296 for end-users who don't want to debug the compiler.
19298 2002-07-21 Martin Baulig <martin@gnome.org>
19300 * assign.cs: Improved the Assign class so it can now handle embedded
19301 assignments (X = Y = Z = something). As a side-effect this'll now also
19302 consume less local variables. test-38.cs now passes with MCS, added
19303 a few new test cases to that test.
19305 2002-07-20 Martin Baulig <martin@gnome.org>
19307 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19308 instructions. Fixes bug #27977, also added test-146.cs.
19310 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19312 * cs-tokenizer.cs: fixed getHex ().
19314 2002-07-19 Martin Baulig <martin@gnome.org>
19316 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19317 not Type.GetType() to lookup the array type. This is needed when
19318 we're constructing an array of a user-defined type.
19319 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19320 single-dimensional arrays, but also for single-dimensial arrays of
19323 2002-07-19 Martin Baulig <martin@gnome.org>
19325 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19326 this function is called, it's not allowed to share LocalBuilders
19327 among ILGenerators.
19329 2002-07-19 Martin Baulig <martin@gnome.org>
19331 * expression.cs (Argument.Resolve): Report an error 118 when trying
19332 to pass a type as argument.
19334 2002-07-18 Martin Baulig <martin@gnome.org>
19336 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19337 Conv_R_Un for the signed `long' type.
19339 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19341 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19342 `expr' for the temporary result, as that will fail if we do
19343 multiple resolves on the same expression.
19345 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19347 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19348 ec.TypeContainer for looking up aliases.
19350 * class.cs (TypeContainer): Remove LookupAlias from here.
19352 * decl.cs (DeclSpace); Move here.
19354 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19356 * class.cs (FindMembers): Only call filter if the constructor
19357 bulider is not null.
19359 Also handle delegates in `NestedTypes' now. Now we will perform
19360 type lookups using the standard resolution process. This also
19363 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19364 This uses Expressions (the limited kind that can be parsed by the
19365 tree) instead of strings.
19367 * expression.cs (ComposedCast.ToString): Implement, used to flag
19368 errors since now we have to render expressions.
19370 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19373 * ecore.cs (SimpleName.ToString): ditto.
19375 * cs-parser.jay: Instead of using strings to assemble types, use
19376 Expressions to assemble the type (using SimpleName, ComposedCast,
19377 MemberAccess). This should fix the type lookups in declarations,
19378 because we were using a different code path for this.
19380 * statement.cs (Block.Resolve): Continue processing statements
19381 even when there is an error.
19383 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19385 * class.cs (Event.Define): Also remove the `remove' method from
19386 the list of pending items.
19388 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19389 generate more compact code.
19391 2002-07-17 Martin Baulig <martin@gnome.org>
19393 * const.cs (Const.LookupConstantValue): Add support for constant
19394 `unchecked' and `checked' expressions.
19395 Also adding test case test-140.cs for this.
19397 2002-07-17 Martin Baulig <martin@gnome.org>
19399 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19400 check whether mi.ReturnType implements the IEnumerator interface; the
19401 `==' and the IsAssignableFrom() will fail in this situation.
19403 2002-07-16 Ravi Pratap <ravi@ximian.com>
19405 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19408 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19410 * expression.cs: fixed bug #27811.
19412 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19414 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19415 Molaro: when we are a ref, the value already contains a pointer
19416 value, do not take the address of it.
19418 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19419 * removed mb-parser.jay and mb-tokenizer.cs
19421 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19423 * expression.cs: check against the building corlib void type.
19425 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19427 * ecore.cs: fix for valuetype static readonly fields: when
19428 initializing them, we need their address, not the address of a copy.
19430 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19432 * typemanager.cs: register also enum_type in corlib.
19434 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19436 * class.cs: allow calling this (but not base) initializers in structs.
19438 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19440 * ecore.cs: make sure we compare against the building base types
19443 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19445 * typemanager.cs: fix TypeToCoreType() to handle void and object
19446 (corlib gets no more typerefs after this change).
19448 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19450 * expression.cs (ArrayCreation.EmitArrayArguments): use
19451 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19453 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19454 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19455 array indexes, the runtime actually forbids them.
19457 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19458 for array arguments here.
19460 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19461 instead of the default for ValueTypes.
19463 (New.DoEmit): Use IsValueType instead of
19464 IsSubclassOf (value_type)
19465 (New.DoResolve): ditto.
19466 (Invocation.EmitCall): ditto.
19468 * assign.cs (Assign): ditto.
19470 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19471 Statements *are* currently doing part of their resolution during
19474 Expressions do always resolve during resolve, but statements are
19475 only required to propagate resolution to their children.
19477 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19479 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19481 (LoadAssembly): Do not add the dll if it is already specified
19483 (MainDriver): Add the System directory to the link path at the end,
19484 after all the other -L arguments.
19486 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19487 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19488 ldelem.u1) and using the opposite for sbytes.
19490 This fixes Digger, and we can finally run it.
19492 * driver.cs (UnixParseOption): Move the option parsing here.
19493 (CSCParseOption): Implement CSC-like parsing of options.
19495 We now support both modes of operation, the old Unix way, and the
19496 new CSC-like way. This should help those who wanted to make cross
19497 platform makefiles.
19499 The only thing broken is that /r:, /reference: and /lib: are not
19500 implemented, because I want to make those have the same semantics
19501 as the CSC compiler has, and kill once and for all the confussion
19502 around this. Will be doing this tomorrow.
19504 * statement.cs (Unsafe.Resolve): The state is checked during
19505 resolve, not emit, so we have to set the flags for IsUnsfe here.
19507 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19509 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19510 not catch the Error_ObjectRefRequired in SimpleName (as it is
19511 possible to have a class/instance variable name that later gets
19512 deambiguated), we have to check this here.
19514 2002-07-10 Ravi Pratap <ravi@ximian.com>
19516 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19517 make static and put into Expression.
19519 (Event.Define): Register the private field of the event with the
19520 TypeManager so that GetFieldFromEvent can get at it.
19522 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19523 keep track of the private field associated with an event which
19526 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19529 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19531 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19533 * expression.cs (Binary.EmitBranchable): this routine emits the
19534 Binary expression in a branchable context. This basically means:
19535 we need to branch somewhere, not just get the value on the stack.
19537 This works together with Statement.EmitBoolExpression.
19539 * statement.cs (Statement.EmitBoolExpression): Use
19542 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19544 * statement.cs (For): Reduce the number of jumps in loops.
19546 (For): Implement loop inversion for the For statement.
19548 (Break): We can be breaking out of a Try/Catch controlled section
19549 (foreach might have an implicit try/catch clause), so we need to
19550 use Leave instead of Br.
19552 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19553 now). If the instace expression supports IMemoryLocation, we use
19554 the AddressOf method from the IMemoryLocation to extract the
19555 address instead of emitting the instance.
19557 This showed up with `This', as we were emitting the instance
19558 always (Emit) instead of the Address of This. Particularly
19559 interesting when This is a value type, as we dont want the Emit
19560 effect (which was to load the object).
19562 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19564 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19566 * statement.cs (Checked): Set the CheckedState during the resolve
19567 process too, as the ConvCast operations track the checked state on
19568 the resolve process, and not emit.
19570 * cs-parser.jay (namespace_member_declaration): Flag that we have
19571 found a declaration when we do. This is used to flag error 1529
19573 * driver.cs: Report ok when we display the help only.
19575 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19577 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19579 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19581 * cs-tokenizer.cs (define): We also have to track locally the
19582 defines. AllDefines is just used for the Conditional Attribute,
19583 but we also need the local defines for the current source code.
19585 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19587 * statement.cs (While, For, Do): These loops can exit through a
19588 Break statement, use this information to tell whether the
19589 statement is the last piece of code.
19591 (Break): Flag that we break.
19593 * codegen.cs (EmitContexts): New `Breaks' state variable.
19595 2002-07-03 Martin Baulig <martin@gnome.org>
19597 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19598 modifiers in method declarations in structs. Otherwise, you won't
19599 be able to override things like Object.Equals().
19601 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19603 * class.cs (Method, Property, Indexer): Do not allow the public
19604 modifier to be used in explicit interface implementations.
19606 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19607 override modifiers in method declarations in structs
19609 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19611 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19612 integer or real overflow, report an error
19614 2002-07-02 Martin Baulig <martin@gnome.org>
19616 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19617 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19618 to tell the runtime about our newly created System.Object and
19619 System.ValueType types.
19621 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19623 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19624 struct instead of Ldarg/Starg.
19626 2002-07-02 Martin Baulig <martin@gnome.org>
19628 * expression.cs (Indirection.Indirection): Call
19629 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19631 2002-07-02 Martin Baulig <martin@gnome.org>
19633 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19634 ValueType, call TypeManager.TypeToCoreType() on it.
19635 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19636 the OpCodes.Newarr argument.
19638 2002-07-02 Martin Baulig <martin@gnome.org>
19640 * expression.cs (Invocation.EmitCall): When compiling corlib,
19641 replace all calls to the system's System.Array type to calls to
19642 the newly created one.
19644 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19645 System.Array methods.
19646 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19647 from the system's System.Array type which must be replaced.
19649 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19651 * typemanager.cs: load unverifiable_code_ctor so we can build
19652 corlib using the correct type. Avoid using GetTypeCode() with
19654 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19655 TypeManager.object_type to allow building corlib.
19657 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19659 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19661 2002-07-01 Martin Baulig <martin@gnome.org>
19663 * class.cs: Make the last change actually work, we need to check
19664 whether `ifaces != null' to avoid a crash.
19666 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19668 * class.cs: when we build structs without fields that implement
19669 interfaces, we need to add the interfaces separately, since there is
19670 no API to both set the size and add the interfaces at type creation
19673 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19675 * expression.cs: the dimension arguments to the array constructors
19676 need to be converted if they are a long.
19678 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19680 * class.cs: don't emit ldarg.0 if there is no parent constructor
19681 (fixes showstopper for corlib).
19683 2002-06-29 Martin Baulig <martin@gnome.org>
19685 MCS now compiles corlib on GNU/Linux :-)
19687 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19688 ie. check for MethodImplOptions.InternalCall.
19690 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19691 and TypeManager.attribute_type are null, so we must explicitly check
19692 whether parent is not null to find out whether it's an attribute type.
19693 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19694 and SetBuilder, not only if the property is neither abstract nor external.
19695 This is necessary to set the MethodImplOptions on the accessor methods.
19696 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19697 SetBuilder, see Property.Emit().
19699 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19700 populate "System.Object", "System.ValueType" and "System.Attribute" since
19701 they've already been populated from BootCorlib_PopulateCoreTypes().
19703 2002-06-29 Martin Baulig <martin@gnome.org>
19705 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19706 is the NullLiteral, we also need to make sure that target_type is not
19709 2002-06-29 Martin Baulig <martin@gnome.org>
19711 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19712 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19713 before calling BootstrapCorlib_ResolveDelegate ().
19715 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19717 * statement.cs: fixed build-breaker. All tests passed ok.
19719 2002-06-27 Martin Baulig <martin@gnome.org>
19721 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19722 for System.Decimal when compiling corlib.
19724 2002-06-27 Martin Baulig <martin@gnome.org>
19726 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19727 switch blocks which contain nothing but a default clause.
19729 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19731 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19733 2002-06-27 Martin Baulig <martin@gnome.org>
19735 * ecore.cs (PropertyExpr.PropertyExpr): Call
19736 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19738 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19739 is already a TypeBuilder.
19741 2002-06-27 Martin Baulig <martin@gnome.org>
19743 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19744 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19745 the "from an array-type to System.Array" case. This makes it work
19746 when compiling corlib.
19748 2002-06-27 Martin Baulig <martin@gnome.org>
19750 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19751 non-static PropertyExpr, set its InstanceExpression. This makes
19752 the `ICollection.Count' property work in System/Array.cs.
19754 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19756 * driver.cs: Made error handling more consistent. Errors now
19757 tracked by Report class, so many methods which used to return int
19758 now return void. Main() now prints success/failure and
19759 errors/warnings message.
19761 Renamed '--probe' compiler argument to '--expect-error'. Removed
19762 the magic number return values (123 and 124). Now, if the
19763 expected error occurs, the compiler exits with success (exit value
19764 0). If the compilation completes without seeing that particular
19765 error, the compiler exits with failure (exit value 1). The
19766 makefile in mcs/errors has been changed to handle the new behaviour.
19768 * report.cs: Made 'expected error' number a property and renamed
19769 it from 'Probe' to 'ExpectedError'.
19771 * genericparser.cs: Removed error handling support, since it is
19772 now all done by Report class.
19774 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19775 class, so parse() no longer returns an int.
19777 * namespace.cs: Use Report.Error instead of GenericParser.error
19779 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19781 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19782 TypeContainer.AddOperator): At the front of the list put the
19783 explicit implementations, so they get resolved/defined first.
19785 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19787 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19788 interface type is implemented by this TypeContainer. Used during
19789 explicit interface implementation.
19791 (Property.Define, Indexer.Define, Method.Define): Validate that
19792 the given interface in the explicit implementation is one of the
19793 base classes for the containing type.
19795 Also if we are explicitly implementing an interface, but there is
19796 no match in the pending implementation table, report an error.
19798 (Property.Define): Only define the property if we are
19799 not explicitly implementing a property from an interface. Use the
19800 correct name also for those properties (the same CSC uses,
19801 although that is really not needed).
19803 (Property.Emit): Do not emit attributes for explicitly implemented
19804 properties, as there is no TypeBuilder.
19806 (Indexer.Emit): ditto.
19808 Hiding then means that we do not really *implement* a pending
19809 implementation, which makes code fail.
19811 2002-06-22 Martin Baulig <martin@gnome.org>
19813 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19814 the return value of Object.GetType(). [FIXME: we need to do this whenever
19815 we get a type back from the reflection library].
19817 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19819 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19821 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19823 * attribute.cs: Return null if we can not look up the type.
19825 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19826 the interface types found.
19828 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19829 interface types found.
19831 * typemanager.cs (GetInterfaces): Make this routine returns alll
19832 the interfaces and work around the lame differences between
19833 System.Type and System.Reflection.Emit.TypeBuilder in the results
19834 result for GetInterfaces.
19836 (ExpandInterfaces): Given an array of interface types, expand and
19837 eliminate repeated ocurrences of an interface. This expands in
19838 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19841 2002-06-21 Martin Baulig <martin@gnome.org>
19843 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19846 2002-06-21 Martin Baulig <martin@gnome.org>
19848 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19849 and called with one of the core types, return the corresponding typebuilder for
19852 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19855 2002-06-21 Martin Baulig <martin@gnome.org>
19857 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19858 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19859 (Expression.ConvertReferenceExplicit): Likewise.
19861 * expression.cs (ElementAccess.DoResolve): Likewise.
19862 (ElementAccess.DoResolveLValue): Likewise.
19864 2002-06-10 Martin Baulig <martin@gnome.org>
19866 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19867 add the "value" parameter to the parameter list.
19869 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19872 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19874 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19875 the argument to an int, uint, long or ulong, per the spec. Also
19876 catch negative constants in array creation.
19878 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
19880 * class.cs: do not allow the same interface to appear twice in
19881 the definition list.
19883 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
19885 * ecore.cs: don't use ldlen with System.Array.
19887 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
19889 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
19891 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
19893 * modifiers.cs: produce correct field attributes for protected
19894 internal. Easy fix so miguel can work on ther harder stuff:-)
19896 2002-06-18 Miguel de Icaza <miguel@ximian.com>
19898 * pending.cs: New file. Move the code from class.cs here.
19899 Support clearning the pending flag for all methods (when not doing
19900 explicit interface implementation).
19902 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
19904 * rootcontext.cs: added a couple more types needed to bootstrap.
19906 2002-06-17 Miguel de Icaza <miguel@ximian.com>
19908 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
19909 constructor in the type, instead of any constructor in the type
19910 hierarchy. Thanks to Paolo for finding this bug (it showed up as
19911 a bug in the Mono runtime when applying the params attribute).
19913 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19914 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
19916 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
19918 * expression.cs (Unary.ResolveOperator): Use TypeManager
19919 to resolve the type.
19921 2002-06-13 Ravi Pratap <ravi@ximian.com>
19923 * cs-parser.jay (enum_member_declaration): Pass in the attributes
19926 * enum.cs (AddEnumMember): Add support to store the attributes associated
19927 with each member too.
19929 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
19930 field builders too - this takes care of the enum member case.
19932 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
19934 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
19935 address-of operator on both value types and pointers.
19937 2002-06-10 Martin Baulig <martin@gnome.org>
19939 * interface.cs (Interface.PopulateIndexer): Add the indexer's
19940 PropertyBuilder to the `property_builders' list.
19942 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
19943 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
19944 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
19945 find any indexers which are inherited from an interface.
19947 2002-06-09 Martin Baulig <martin@gnome.org>
19949 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
19950 the same type as the constant if necessary. There's also a test-130.cs
19953 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
19955 * typemanager.cs (TypeManager.ChangeType): Previously known as
19956 Enum.ChangeEnumType().
19958 2002-06-09 Martin Baulig <martin@gnome.org>
19960 * expression.cs (Cast.TryReduce): Added support for consts.
19962 2002-06-08 Ravi Pratap <ravi@ximian.com>
19964 * class.cs (Accessor): Hold attributes information so we can pass
19967 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
19968 Modify to pass in attributes attached to the methods.
19970 (add_accessor_declaration, remove_accessor_declaration): Ditto.
19972 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
19973 to handle the Accessor kind :-)
19975 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
19977 2002-06-08 Martin Baulig <martin@gnome.org>
19979 * expression.cs (Unary.TryReduceNegative): Added support for
19982 2002-06-08 Martin Baulig <martin@gnome.org>
19984 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
19985 name can't be found in the `defined_names' - the caller will do a
19986 MemberLookup in this case and thus find methods in System.Enum
19987 such as Enum.IsDefined().
19989 2002-06-08 Martin Baulig <martin@gnome.org>
19991 * enum.cs (Enum.ChangeEnumType): This is a custom version of
19992 Convert.ChangeType() which works with TypeBuilder created types.
19993 (Enum.LookupEnumValue, Enum.Define): Use it here.
19995 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
19996 `TypeBuilder.BaseType != null' check.
19997 (TypeContainer.FindMembers): Only lookup parent members if we
19998 actually have a parent.
19999 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
20000 (ConstructorInitializer.Resolve): Likewise.
20002 * interface.cs (Interface.FindMembers): Added
20003 `TypeBuilder.BaseType != null' check.
20005 * rootcontext.cs (RootContext.ResolveCore): Added
20006 "System.Runtime.CompilerServices.IndexerNameAttribute" to
20007 classes_second_stage.
20009 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20010 debug_type and trace_type when compiling with --nostdlib.
20012 2002-06-07 Martin Baulig <martin@gnome.org>
20014 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
20015 (AddField): Set it to true when adding a non-static field.
20016 (DefineType): Use `have_nonstatic_fields' to find out whether we
20017 have non-static fields, not `Fields != null'.
20019 2002-06-02 Miguel de Icaza <miguel@ximian.com>
20021 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
20022 dereferencing a null on the static-field code path)
20024 2002-05-30 Martin Baulig <martin@gnome.org>
20026 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
20027 to take command line arguments. Use reflection to call the new
20028 custom `Initialize' function on the symbol writer and pass it the
20029 command line arguments.
20031 * driver.cs (--debug-args): New command line argument to pass command
20032 line arguments to the symbol writer.
20034 2002-05-28 Miguel de Icaza <miguel@ximian.com>
20036 * assign.cs (DoResolve): Forgot to do the implicit conversion to
20037 the target type for indexers and properties. Thanks to Joe for
20040 2002-05-27 Miguel de Icaza <miguel@ximian.com>
20042 * typemanager.cs (MethodFlags): returns the method flags
20043 (Obsolete/ShouldIgnore) that control warning emission and whether
20044 the invocation should be made, or ignored.
20046 * expression.cs (Invocation.Emit): Remove previous hack, we should
20047 not do this on matching a base type, we should do this based on an attribute
20049 Only emit calls to System.Diagnostics.Debug and
20050 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
20051 on the command line.
20053 * rootcontext.cs: Global settings for tracing and debugging.
20055 * cs-tokenizer.cs (define): New utility function to track
20056 defines. Set the global settings for TRACE and DEBUG if found.
20058 2002-05-25 Ravi Pratap <ravi@ximian.com>
20060 * interface.cs (Populate*): Pass in the TypeContainer as well as
20061 the DeclSpace as parameters so that we can create EmitContexts and
20062 then use that to apply attributes etc.
20064 (PopulateMethod, PopulateEvent, PopulateProperty)
20065 (PopulateIndexer): Apply attributes everywhere.
20067 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
20070 (ApplyAttributes): Update accordingly.
20072 We now apply interface attributes for all members too.
20074 2002-05-26 Miguel de Icaza <miguel@ximian.com>
20076 * class.cs (Indexer.Define); Correctly check if we are explicit
20077 implementation (instead of checking the Name for a ".", we
20078 directly look up if the InterfaceType was specified).
20080 Delay the creation of the PropertyBuilder.
20082 Only create the PropertyBuilder if we are not an explicit
20083 interface implementation. This means that explicit interface
20084 implementation members do not participate in regular function
20085 lookups, and hence fixes another major ambiguity problem in
20086 overload resolution (that was the visible effect).
20088 (DefineMethod): Return whether we are doing an interface
20091 * typemanager.cs: Temporary hack until we get attributes in
20092 interfaces (Ravi is working on that) and we get IndexerName
20093 support in interfaces.
20095 * interface.cs: Register the indexers as properties.
20097 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
20098 warning, I have verified that this is a bug in the .NET runtime
20099 (JavaScript suffers of the same problem).
20101 * typemanager.cs (MemberLookup): When looking up members for
20102 interfaces, the parent of an interface is the implicit
20103 System.Object (so we succeed in searches of Object methods in an
20104 interface method invocation. Example: IEnumerable x; x.ToString
20107 2002-05-25 Miguel de Icaza <miguel@ximian.com>
20109 * class.cs (Event): Events should also register if they do
20110 implement the methods that an interface requires.
20112 * typemanager.cs (MemberLookup); use the new GetInterfaces
20115 (GetInterfaces): The code used to lookup interfaces for a type is
20116 used in more than one place, factor it here.
20118 * driver.cs: Track the errors at the bottom of the file, we kept
20121 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
20122 instance if the method we are calling is static!
20124 2002-05-24 Miguel de Icaza <miguel@ximian.com>
20126 * attribute.cs (ApplyAttributes): Make this function filter out
20127 the IndexerName attribute (as that attribute in reality is never
20128 applied) and return the string constant for the IndexerName
20131 * class.cs (TypeContainer.Emit): Validate that all the indexers
20132 have the same IndexerName attribute, and if so, set the
20133 DefaultName attribute on the class.
20135 * typemanager.cs: The return value might contain other stuff (not
20136 only methods). For instance, consider a method with an "Item"
20137 property and an Item method.
20139 * class.cs: If there is a problem with the parameter types,
20142 2002-05-24 Ravi Pratap <ravi@ximian.com>
20144 * ecore.cs (ImplicitConversionExists): Wrapper function which also
20145 looks at user defined conversion after making a call to
20146 StandardConversionExists - we need this for overload resolution.
20148 * expression.cs : Update accordingly the various method calls.
20150 This fixes 2 bugs filed against implicit user defined conversions
20152 2002-05-22 Miguel de Icaza <miguel@ximian.com>
20154 * statement.cs: Track the result of the assignment.
20156 2002-05-21 Miguel de Icaza <miguel@ximian.com>
20158 * expression.cs (MemberAccess): Improved error reporting for
20159 inaccessible members.
20161 2002-05-22 Martin Baulig <martin@gnome.org>
20163 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
20164 itself with debugging support.
20166 2002-05-22 Martin Baulig <martin@gnome.org>
20168 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
20169 Removed, this isn't needed anymore.
20171 2002-05-20 Martin Baulig <martin@gnome.org>
20173 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
20174 be underlying type for an enum.
20176 2002-05-20 Miguel de Icaza <miguel@ximian.com>
20178 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
20179 that splits out the loading of just the core types.
20181 * rootcontext.cs (ResolveCore): Split the struct resolution in
20182 two, so we can load the enumeration underlying types before any
20185 * expression.cs (Is): Bandaid until we fix properly Switch (see
20186 bug #24985 for details).
20188 * typemanager.cs (ImplementsInterface): The hashtable will contain
20189 a null if there are no interfaces implemented.
20191 2002-05-18 Miguel de Icaza <miguel@ximian.com>
20193 * cs-parser.jay (indexer_declarator): It is fine to have array
20196 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20198 * typemanager.cs: (RegisterBuilder): New function used to register
20199 TypeBuilders that implement interfaces. Since
20200 TypeBuilder.GetInterfaces (as usual) does not work with lame
20202 (AddUserType): register interfaces.
20204 (ImplementsInterface): Use the builder_to_ifaces hash if we are
20205 dealing with TypeBuilder. Also, arrays are showing up as
20206 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
20207 methods can not be invoked on them!
20209 * ecore.cs (ExplicitReferenceConversionExists): Made public.
20210 (ImplicitReferenceConversionExists): Split out from
20211 StandardConversionExists.
20213 * expression.cs (As): We were only implementing one of the three
20214 cases for the as operator. We now implement them all.
20215 (Is): Implement the various other cases for Is as well.
20217 * typemanager.cs (CACHE): New define used to control if we want or
20218 not the FindMembers cache. Seems to have a negative impact on
20219 performance currently
20221 (MemberLookup): Nested types have full acess to
20222 enclosing type members
20224 Remove code that coped with instance/static returns for events, we
20225 now catch this in RealFindMembers.
20227 (RealFindMembers): only perform static lookup if the instance
20228 lookup did not return a type or an event.
20230 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20232 * assign.cs (CompoundAssign): We pass more semantic information
20233 now to Compound Assignments than we did before: now we have all
20234 the information at hand, and now we resolve the target *before* we
20235 do the expression expansion, which allows the "CacheValue" method
20236 to have the effect we intended (before, a [x] += 1 would generate
20237 two differen ArrayAccess expressions from the ElementAccess,
20238 during the resolution process).
20240 (CompoundAssign.DoResolve): Resolve target and original_source here.
20242 2002-05-16 Miguel de Icaza <miguel@ximian.com>
20244 * expression.cs (ArrayAccess): dropped debugging information.
20246 * typemanager.cs: Small bug fix: I was always returning i_members,
20247 instead of one of i_members or s_members (depending on which had
20250 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
20251 method is invoked before any code generation takes place, and it
20252 is a mechanism to inform that the expression will be invoked more
20253 than once, and that the method should use temporary values to
20254 avoid having side effects
20256 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
20258 * ecore.cs (Expression.CacheTemporaries): Provide empty default
20261 * expression.cs (Indirection, ArrayAccess): Add support for
20262 CacheTemporaries in these two bad boys.
20264 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
20265 ldobj or ldind_ref.
20266 (StoreFromPtr): Handle stobj as well.
20268 * expression.cs (UnaryMutator): Share more code.
20270 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20271 down: I was not tracking the Filter function as well, which
20272 was affecting the results of the cache.
20274 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20276 * attribute.cs: Remove the hack to handle the CharSet property on
20279 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20281 * attribute.cs (DoResolve): More uglyness, we now only try to
20282 resolve the attribute partially, to extract the CharSet
20283 information (only if we are a StructLayout attribute). Otherwise
20285 (GetExtraTypeInfo): Add some code to conditionally kill in the
20286 future this. I am more and more convinced that the .NET
20287 framework has special code to handle the attribute setting on
20290 * expression.cs (IsParamsMethodApplicable): Revert my previous
20291 foreach change here, it was wrong.
20293 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20295 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20296 (pp_expr): do not abort on unknown input, just return.
20297 (eval): abort if there are pending chars.
20299 * attribute.cs (Attribute.Resolve): Positional parameters are
20300 optional. Deal with that case.
20302 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20303 the Ansi/Unicode/Auto information for the type.
20305 (TypeContainer.DefineType): instantiate the EmitContext here, as
20306 we will be using it during the type definition (to resolve
20307 attributes) and during the emit phase.
20309 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20310 to pull type information out of the attributes
20312 (Attribute.Resolve): track the constructor builder, and allow for
20313 multiple invocations (structs and classes will use this).
20315 * ecore.cs (MemberLookupFinal): new version with all the
20316 parameters customizable.
20318 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20319 constructors. Return if the result value is null (as the error
20320 would have been flagged already by MemberLookupFinal)
20322 Do not allow instances of abstract classes or interfaces to be
20325 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20326 We have to compare the assembly property here when dealing with
20327 FamANDAssem and Assembly access modifiers, because we might be
20328 creating an assembly from *modules* (that means that we are not
20329 getting TypeBuilders for types defined in other modules that are
20330 part of this assembly).
20332 (Method.Emit): If the method is marked abstract and has a body,
20335 (TypeContainer.DefineMembers): If both the defined member and the
20336 parent name match are methods, then do not emit any warnings: let
20337 the Method.Define routine take care of flagging warnings. But if
20338 there is a mismatch (method overrides something else, or method is
20339 overriwritten by something, then emit warning).
20341 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20342 set to null, this means `do not check for the return type on the
20345 (Method.Define): set the return type for the method signature to
20346 null, so that we get methods with the same name and parameters and
20347 different return types. This is used to flag warning 114 (you are
20348 hiding a method, and you probably want to use the new/override
20351 * typemanager.cs (MemberLookup): Implemented proper access
20352 control, closing a long standing set of bug reports. The problem
20353 was that the Framework only has two bits: Public and NonPublic,
20354 and NonPublic includes private and protected methods, but we need
20355 to enforce the FamANDAssem, FamOrAssem and Family.
20357 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20359 * statement.cs (GotoCase): Return true: Ammounts to giving up
20360 knowledge on whether we return or not, and letting the other case
20361 be responsible for it.
20363 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20365 * driver.cs: Do not load directories for each file processed, only
20366 do it if there is a pattern.
20368 * ecore.cs: Report readonly assigns here as well, as we might have
20369 been resolved only by MemberAccess.
20371 (SimpleName.SimpleNameResolve): Also be useful for LValue
20372 resolution. We need this to propagate assign to local readonly variables
20374 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20375 do not want to reuse potential criteria memory.
20377 * class.cs (MyEventBuilder): Set reflected_type;
20379 * ecore.cs (Constantify): Added support for constifying bools.
20381 (RootContext.LookupType): Added a cache for values looked up in
20382 the declaration space.
20384 * typemanager.cs (FindMembers): Now is a front-end to
20385 RealFindMembers, and provides a two-level hashtable-based cache to
20388 15% performance improvement: from 22.5 to 19.2 seconds.
20390 * expression.cs (IsParamsMethodApplicable): use foreach.
20391 (Invocation.DoResolve): ditto.
20392 (New.DoResolve): ditto.
20393 (ArrayCreation.DoResolve): ditto.
20395 * ecore.cs (FindMostEncompassingType): use foreach.
20397 * delegate.cs (NewDelegate.DoResolve): Use foreach
20399 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20400 (RemoveMethods): use foreach.
20402 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20403 nested foreach statements instead of for, and also break out of
20404 the inner loop once a match is found.
20406 (Invocation.OverloadResolve): Use foreach, simplify the code.
20408 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20410 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20411 we actually unwrap the expression to allow for extra information
20414 * expression.cs: Use Shr_Un on unsigned operations.
20416 2002-05-08 Ravi Pratap <ravi@ximian.com>
20418 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20419 applicable operators was not being considered correctly. This closes
20420 the bug Miguel reported.
20422 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20424 * attribute.cs: check that the type derives from System.Attribute
20425 and report the correct error in that case (moved the duplicate code to
20426 its own method, too).
20428 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20430 * attribute.cs: lookup attribute type name as the spec says: first the
20431 bare attribute name and then name + "Attribute" (nant compiles with
20432 mcs after this fix).
20434 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20436 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20437 Because of the way we parse things, we should try to see if a
20438 UIntConstant can fit in an integer.
20440 2002-05-07 Ravi Pratap <ravi@ximian.com>
20442 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20443 when we are in an explicit context.
20445 (ConvertReferenceExplicit): When converting from Iface type S to Class
20446 T make sure the rules are implemented as an OR.
20448 * parameter.cs (ParameterType): Make it a property for now although the
20449 purpose really isn't anything immediate.
20451 * expression.cs (Is*Applicable): Do better checking on the parameter type
20452 of a ref/out parameter. The ones from the system assemblies are already
20453 marked with the correct type so we don't need to do any correction.
20455 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20456 the object type is standard too so include that.
20458 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20460 * ecore.cs (StandardConversionExists): Augment with missing code:
20461 deal with IntConstant, LongConstants and Enumerations.
20463 * assign.cs: Report the error, instead of failing silently
20465 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20466 typecontainer that they are declared, because the
20467 typecontainer/namespace will have the list of using clauses that
20468 need to be applied.
20470 Assembly Attributes were escaping the normal registration
20473 (EmitCode): Apply attributes within an EmitContext that represents
20474 the container they were declared on.
20476 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20478 2002-05-06 Ravi Pratap <ravi@ximian.com>
20480 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20481 Revamp completely - make much cleaner as we now operate only
20484 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20485 to implement the logic detailed in the spec more correctly.
20487 (UserDefinedConversion): Update accordingly.
20489 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20491 * statement.cs: Return flow analysis information up.
20493 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20496 (token): Do not consume an extra character before calling
20499 2002-05-06 Piers Haken <piersh@friskit.com>
20501 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20503 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20505 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20506 EmitContext during the instance constructor initializer
20507 resolution, to stop access to instance variables.
20509 This is mandated by the spec, last paragraph of the `constructor
20510 initializers' section.
20512 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20514 * cs-parser.jay, class.cs (Accessor): new class used to represent
20515 an accessor (get or set). In the past we used `null' to represent
20516 a missing accessor. But this is ambiguous because there was no
20517 way to tell in abstract indexers/properties if one of them was
20520 Now there is a way of addressing that.
20522 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20523 instead of FindMembers.
20525 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20526 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20528 * attribute.cs: Treat indexers and properties as the same in terms
20529 of applying attributes
20531 * ecore.cs (FindMostEncompassedType): Use statically initialized
20532 EmptyExpressions()s like we do elsewhere to avoid creating useless
20533 objects (and we take this out of the tight loop).
20535 (GetConversionOperators): Move the code to extract the actual
20536 operators to a separate routine to clean things up.
20538 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20540 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20541 events are always registered FieldBuilders.
20543 * class.cs (FieldBase): New class shared by Fields
20545 * delegate.cs: If we are a toplevel delegate, use our full name.
20546 If we are a nested delegate, then only use our tail name.
20548 2002-05-02 Ravi Pratap <ravi@ximian.com>
20550 * expression.cs (IsApplicable): Ensure that we add the "&" to
20551 ref/out types before comparing it with the type of the argument.
20553 (IsParamsMethodApplicable): Ditto.
20555 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20558 * delegate.cs : Handle the case when we have more than one applicable
20559 method. Flag an error only when we finish checking all.
20561 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20563 * expression.cs: Add support for boolean static initializers.
20565 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20567 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20569 * parameter.cs (ComputeParameterTypes,
20570 ComputeAndDefineParameterTypes): Better error handling: now we
20571 clear the `types' cache if we fail during any of the type lookups.
20572 We also return the status code correctly to our caller
20574 * delegate.cs: If we fail to define a delegate, abort the extra
20577 * expression.cs (Binary.ResolveOperator): for
20578 operator==(object,object) and operator !=(object, object) we also
20579 have to verify that there is an implicit conversion from one to
20582 (ArrayAccess.DoResolve): Array Access can operate on
20585 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20587 * assign.cs (CompoundAssign): A new class used as a "flag" that
20588 the assignment actually is happening as part of a compound
20589 assignment operator.
20591 During compound assignment, a few new rules exist to enable things
20598 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20599 to the type of x) if y is implicitly convertible to the type of x,
20600 and the operator is a builtin operator and the return type of the
20601 operator is explicitly convertible to the type of x.
20603 * rootcontext.cs: Reset warning level to 2. 4 catches various
20604 "interesting" features in mcs, we must clean this up at some
20605 point, but currently am trying to kill other bugs ;-)
20607 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20608 in container classes as well.
20610 * expression.cs (Binary.ResolveOperator): Handle string case
20611 before anything else (as operator overloading does emit an error
20612 before doing anything else).
20614 This code could go away when we move to a table driven model, but
20615 i could not come up with a good plan last night.
20617 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20619 * typemanager.cs (CSharpName): reimplementation using regex.
20620 * class.cs: added null check for fields in Emit
20621 * rootcontext.cs: set warninglevel to 4
20623 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20625 * typemanager.cs (CSharpName): reimplemented with Lupus
20628 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20630 * statement.cs (If): correclty implement Resolve, because we were
20631 not catching sem errors in there. The same process is needed
20633 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20636 (Statement.Warning_DeadCodeFound): Factorize code.
20637 (While): Report dead code here too.
20639 (Statement): Added Resolve virtual method to allow
20640 for resolution split from the emit code.
20642 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20644 * statement.cs (EmitBoolExpression): No longer try to resolve the
20646 (MakeBoolean): New utility function that resolve, implicitly
20647 converts to boolean and tags the expression.
20650 (If, Do): Implement dead code elimination.
20651 (While): Implement loop inversion
20653 (Do, While, For, If): Resolve the expression prior to calling our
20656 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20659 - added method Report28 (warning: program has more than one entry point)
20660 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20661 - modified method Method.Define, the part at the end of the method
20663 * rootcontext.cs: added static public Location EntryPointLocation;
20665 * ../errors/cs0028.cs : Add test case for the above warning.
20668 - modified method CSharpName to allow arrays of primitive type to
20669 be printed nicely (e.g. instead of System.Int32[][] it now prints
20671 - added method CSharpSignature: returns the signature of a method
20672 in string format to be used in reporting errors, warnings, etc.
20674 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20677 2002-04-26 Ravi Pratap <ravi@ximian.com>
20679 * delegate.cs (Define): Fix extremely silly bug where I was
20680 setting the type of the 'object' parameter of the BeginInvoke
20681 method to System.IAsyncResult instead of System.Object ;-)
20683 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20685 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20688 (Constructor.Emit): return if we fail to initialize the
20689 constructor. Another door closed!
20691 * expression.cs (New.DoResolve): Improve error message (from -6 to
20692 1501). Use DeclaredOnly lookup to find the exact constructor.
20694 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20695 loop. This is useful.
20697 * cs-parser.jay: Adjust the default parameters so that destructors
20698 have the proper signature.
20700 2002-04-26 Martin Baulig <martin@gnome.org>
20702 * driver.cs (LoadAssembly): If `assembly' contains any characters
20703 which are only valid in path names and not in assembly names
20704 (currently slash, backslash and point), use Assembly.LoadFrom ()
20705 instead of Assembly.Load () on the `assembly' (before iteration
20706 over the link_paths).
20708 2002-04-26 Martin Baulig <martin@gnome.org>
20710 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20712 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20714 * class.cs (Property): use the new typemanager.MemberLookup
20716 (TypeContainer.MemberLookup): Implement using the
20717 TypeManager.MemberLookup now.
20719 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20720 and return MemberInfos, so that these can be used without an
20721 EmitContext (what we had before).
20723 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20725 * expression.cs: Fix the case where the argument to params if the
20726 type of the params. I omitted handling this before. Fixed
20728 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20730 * driver.cs: Call BootCorlib_PopulateCoreType
20732 * class.cs (Property.CheckBase): Check for properties only, not
20735 * interface.cs: Temporary hack: try/catch around the
20736 CustomAttributeBuilder, because I am getting an exception that I
20739 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20740 types whose definitions are required to be there (attributes are
20741 defined before standard types).
20743 Compute definitions as we boot the various types, as they are used
20744 immediately (value_type class will need object_type, but if we do
20745 not initialize object_type, we will pass a null, which will let
20746 the runtime pick the System.Object from the existing corlib, which
20747 is not what we want).
20749 2002-04-22 Patrik Torstensson <totte@labs2.com>
20751 * cs-tokenizer.cs: fixed a number of trim() issues.
20753 2002-04-22 Ravi Pratap <ravi@ximian.com>
20755 * expression.cs (Argument.Type): Ensure that we return the correct
20756 type when we have out or ref parameters [in which case we
20759 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20761 * class.cs (Property, Indexer): Allow extern modifier in there.
20763 * typemanager.cs (InitBaseTypes): Initializes object_type and
20764 value_type, since those will be used early on during the bootstrap
20765 process to compile corlib.
20767 (InitCoreTypes): Move code from here to InitBaseTypes.
20769 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20771 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20772 single-dimension arrays as using the ldlen opcode.
20774 Daniel Lewis discovered this optimization.
20776 * typemanager.cs: Add signature for System.Array::get_Length
20778 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20780 * statement.cs: report the error when the foreach does not apply to an
20781 array nor a collection.
20783 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20785 * expression.cs: Add implicit conversions to the operator ~.
20787 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20789 * typemanager.cs: Locate the decimal constructor.
20791 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20793 * attribute.cs: use the new property of TypeOf.
20794 * expression.cs: added 'get' property around typearg.
20796 These changes fix a build breaker reported by NickD. Is this the
20797 correct way to fix? If not, please, revert my changes and make it
20800 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20802 * attribute.cs: Add support for typeof in attribute invocations.
20803 I am not sure that this is right though.
20805 2002-04-14 Duncan Mak <duncan@ximian.com>
20807 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20808 Binary.Operator.Division case.
20810 2002-04-13 Ravi Pratap <ravi@ximian.com>
20812 * class.cs (DefineType): Ensure that we do a proper check on
20813 attribute types and also register it with the TypeManager.
20815 (TypeContainer.Targets): The default for attribute types is
20816 AttributeTargets.All.
20818 * attribute.cs (ApplyAttributes): Registering the attribute type
20819 is done elsewhere, not when we discover we have a Usage attribute.
20821 2002-04-12 Ravi Pratap <ravi@ximian.com>
20823 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20824 and get rid of is_delegate parameter.
20826 * everywhere : update.
20828 2002-04-12 Ravi Pratap <ravi@ximian.com>
20830 * cs-parser.jay (compilation_unit): Revamp completely to use
20831 some new ideas that I got from Rhys' grammar to solve the problems
20832 with assembly level attributes.
20834 (outer_declaration): New grammar production.
20836 (attribute_sections): Add.
20838 (opt_attributes): Base on attribute_sections
20840 (namespace_declaration): Allow opt_attributes to tackle the case
20841 when we have assembly level attributes - we are clever in this
20844 * attribute.cs (ApplyAttributes): Do not worry about assembly
20845 attributes in the non-global context.
20847 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20848 instead of SetGlobalAttributes.
20850 * class.cs, rootcontext.cs : Ensure we define and generate
20851 attribute types before anything else.
20853 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20854 and flag the new error -20 for the case when the attribute type
20855 does not have valid targets specified. csc does not catch this.
20857 * ../errors/errors.txt : update for error # -20
20859 2002-04-11 Ravi Pratap <ravi@ximian.com>
20861 * support.cs (InternalParameters.ParameterModifier): Do some null
20862 checking and return sane values.
20864 * class.cs (Method.Define): If we are a PInvoke method, ensure
20865 that we are static and extern. Report error # 601
20867 * ../errors/cs0601.cs : Add test case for the above error.
20869 2002-04-07 Ravi Pratap <ravi@ximian.com>
20871 * rootcontext.cs (attribute_types): We need to keep type of
20872 all attribute types separately and emit code for them first.
20874 (RegisterAttribute) : Implement.
20876 * class.cs (DefineType): Check if the current Type is a custom
20877 attribute type and register it accordingly.
20879 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
20880 adding the first attribute twice and rename to
20882 (SetGlobalAttributes): this.
20884 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
20887 * attribute.cs (ApplyAttributes): Take an additional argument telling us
20888 if we are processing global arguments. Hmm, I am unsure of this.
20890 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20892 * expression.cs: added static array of strings to avoid calling
20893 Enum.ToString () for Operator in Binary. Significant recover of
20896 2002-04-10 Miguel de Icaza <miguel@ximian.com>
20898 * class.cs (FindMembers): Allow the Builders of the various
20899 members to be null. If they are skip them. This only happens
20900 during the PInvoke declaration.
20902 2002-04-09 Miguel de Icaza <miguel@ximian.com>
20904 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
20905 failure, so we do not keep going afterwards.
20907 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
20908 wanted to pass `false' as the `is_delegate' argument. If this is
20909 the case, why not use delegate_type == null to mean `is_delegate =
20910 false' and anything else as is_delegate = true.
20912 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
20914 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
20915 code for the section, not the beginning of the tests.
20917 2002-04-08 Miguel de Icaza <miguel@ximian.com>
20919 * cfold.cs: Handle operator + (Enum x, Underlying x)
20921 * expression.cs (Binary): same. Warn about errors where we have
20922 Enum/Enum in operator + as well.
20924 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
20927 - added support for switch(bool)
20928 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
20929 - add TableSwitchEmit() to handle table-based switch statements
20931 2002-04-05 Ravi Pratap <ravi@ximian.com>
20933 * expression.cs (Invocation.OverloadResolve): Factor out code which
20934 does parameter compatibility checking with arguments so that we can
20935 re-use the code even from Delegate.VerifyApplicability
20937 (VerifyArgumentsCompat): Move above code here.
20939 * delegate.cs (VerifyApplicability): Get rid of duplicate code
20940 and instead make a call to the above method.
20942 2002-03-31 Ravi Pratap <ravi@ximian.com>
20944 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
20945 We use it to keep track of classes which are attribute types.
20947 2002-04-02 Miguel de Icaza <miguel@ximian.com>
20949 * delegate.cs (Delegate.Define): Correctly define the types in the
20950 presence of fixed and array parameters.
20952 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
20955 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
20956 include NonPublic after the first iteration.
20958 * class.cs (Indexer.CheckBase): Only check if both parents are
20961 * cs-parser.jay (accessor_body): If empty, set to null.
20963 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
20964 same code path here to resolve constants names that we did have in
20965 MemberAccess.DoResolve. There is too much code duplicated here.
20967 2002-04-01 Miguel de Icaza <miguel@ximian.com>
20969 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
20971 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
20974 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
20975 tokens, numbers and strings.
20977 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
20980 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
20981 asyncronous parameters and the regular parameters.
20983 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
20984 specify the target directory.
20986 * expression.cs: (This.DoResolve): Simplify
20987 (As.Emit): Optimize, do not generate IsInst if the expression is
20988 always of the given type.
20990 (Is.DoResolve): Bug fix, we were reporting both always/never for
20993 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
20994 creating too many unnecessary arrays.
20996 2002-03-31 Miguel de Icaza <miguel@ximian.com>
20998 * class.cs (EmitFieldInitializer): Use Assign expression to assign
20999 fields instead of rolling our own initializer. Takes care of all
21000 implicit conversions, and drops unnecessary static checks/argument.
21002 2002-03-31 Dick Porter <dick@ximian.com>
21004 * driver.cs: use the GetDirectories() return values properly, and
21005 use "/" as path separator.
21007 2002-03-30 Miguel de Icaza <miguel@ximian.com>
21009 * expression.cs (Unary): Optimize - - expr into expr.
21010 (Binary): Optimize a + (-b) into a -b.
21012 * codegen.cs (CodeGen): Made all methods static.
21014 2002-03-29 Miguel de Icaza <miguel@ximian.com>
21018 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
21019 TypeBuilder property.
21021 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
21024 * tree.cs: Removed the various RecordXXXX, and replaced with a
21025 single RecordDecl. Removed all the accessor methods, and just
21026 left a single access point Type
21028 * enum.cs: Rename DefineEnum to DefineType.
21030 * decl.cs: New abstract method `DefineType' used to unify the
21031 Defines for Enumerations, Interfaces, TypeContainers and
21034 (FindType): Moved LookupInterfaceOrClass here. Moved the
21035 LookupBaseClasses method that used to live in class.cs and
21036 interface.cs here, and renamed to FindType.
21038 * delegate.cs: Implement DefineType. Take advantage of the
21039 refactored pattern for locating the parent builder without taking
21040 the parent_builder argument (which we know does not work if we are
21041 nested, and triggering a toplevel definition).
21043 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21045 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21046 accessibility of a member has changed during override and report
21049 * class.cs (Method.Define, Property.Define): Only complain on
21050 overrides if the method is private, any other accessibility is
21051 fine (and since we just checked the permission is the same, we are
21054 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
21055 and elif are processed always. The other pre-processing
21056 directives are only processed if we are "taking" the path
21058 2002-03-29 Martin Baulig <martin@gnome.org>
21060 * class.cs (Method.Emit): Only emit symbolic debugging info if the
21061 current location is not Null.
21063 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
21064 a separate method so we can profile it.
21066 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
21067 `span.Seconds' are just seconds, but no minutes or hours.
21068 (MainDriver): Profile the CodeGen.SaveSymbols calls.
21070 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21072 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
21073 Remove the gratuitous set of Final:
21075 // If an interface implementation, then we can set Final.
21076 if (((flags & MethodAttributes.Abstract) == 0) &&
21077 implementing.DeclaringType.IsInterface)
21078 flags |= MethodAttributes.Final;
21080 I do not know what I was smoking when I used that.
21083 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
21084 step into fixing the name resolution issues for delegates and
21085 unifying the toplevel name resolution.
21087 2002-03-28 Martin Baulig <martin@gnome.org>
21089 * class.cs (Method.Emit): If we have a symbol writer, call its
21090 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
21091 tell it about the current method.
21093 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
21094 writer that we're going to emit the first byte of IL code for a new
21095 statement (a new source line).
21096 (EmitContext.EmitTopBlock): If we have a symbol writer, call
21097 EmitContext.Mark() before emitting any code.
21099 * location.cs (SymbolDocument): Return null when we're Null.
21101 * statement.cs (Statement): Moved the `Location loc' variable here.
21102 (Statement.EmitBoolExpression): If we have a symbol writer, call
21103 ec.Mark() before emitting any code to tell it that we're at the
21104 beginning of a new statement.
21105 (StatementExpression): Added `Location' argument to the constructor.
21106 (Block): Added public readonly variable `StartLocation' and public
21107 variable `EndLocation'. The latter is to be set using SetEndLocation().
21108 (Block): Added constructor which takes a start and end location.
21109 (Block.SetEndLocation): New method. This sets the end location.
21110 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
21111 local variables we create.
21112 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
21113 each statement and do also mark the begin and end of the block.
21115 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21116 tell it the current lexer.Location, use Location.Null for the end of the
21118 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
21119 current block, set its end location using SetEndLocation().
21120 (statement_expression): StatementExpression constructor now takes the
21121 lexer.Location as additional argument.
21122 (for_statement, declare_local_variables): Likewise.
21123 (declare_local_variables): When creating a new implicit block, use the
21124 new Block constructor and pass it the lexer.Location.
21126 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21128 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
21129 members also on the parent interfaces recursively.
21131 2002-03-27 Miguel de Icaza <miguel@ximian.com>
21133 * report.cs: Use new formats, since Gonzalo finished the missing
21136 * expression.cs (Binary.ResolveOperator): added missing operator|
21137 operator& and operator^ for bool/bool.
21139 * cs-parser.jay: CheckDef now takes a Location argument that is
21140 used to report errors more precisly (instead of reporting the end
21141 of a definition, we try to track something which is a lot closer
21142 to the source of the problem).
21144 * cs-tokenizer.cs: Track global token use, so we can properly flag
21145 the use of #define/#undef after the first token has been seen.
21147 Also, rename the reportXXXX to Error_DescriptiveName
21149 * decl.cs (DeclSpace.IsTopLevel): Move property here from
21150 TypeContainer, so that Enum and Interface can use this too.
21152 * class.cs (TypeContainer.LookupInterfaceOrClass,
21153 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
21154 `builder' argument. Typically this was used to pass the parent
21155 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
21158 The problem is that a nested class could trigger the definition of
21159 a toplevel class, and the builder would be obviously wrong in that
21162 So we drop this argument, and we compute dynamically the
21163 TypeBuilder/ModuleBuilder (the correct information was available
21164 to us anyways from DeclSpace.Parent)
21166 * interface.cs (Interface.DefineInterface): Drop builder
21167 parameter cleanup like class.cs
21169 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
21172 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
21175 (Try.Emit): Propagate the returns value from the statement.
21177 (Return.Emit): Even if we are leavning
21179 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
21181 * modifiers.cs: Fix the computation of MethodAttributes flags.
21183 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
21185 * driver.cs: allow compilation of files that start with '/'.
21186 Add a default case when checking the argument of --target.
21188 2002-03-25 Miguel de Icaza <miguel@ximian.com>
21190 * interface.cs: Implement the same search algorithm for types in
21191 the interface code.
21193 * delegate.cs: Do not allow multiple definition.
21195 * Recovered ChangeLog that got accidentally amputated
21197 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
21199 * rootcontext.cs: Load manually enum to allow core classes to
21200 contain enumerations.
21202 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
21203 Update to new static methods in TypeManager.
21205 * typemanager.cs (GetMethod, GetConstructor): Use our
21206 implementation of FindMembers to find the members, since during
21207 corlib compilation, the types are TypeBuilders and GetMethod and
21208 GetConstructor do not work.
21210 Make all methods in TypeManager static.
21212 (InitCodeHelpers): Split the functionality from
21213 the InitCodeTypes function.
21215 * driver.cs: Call InitCodeHelpers after we have populated the
21218 * cs-parser.jay (delegate_declaration): we did not used to compute
21219 the delegate name correctly for void delegates.
21221 2002-03-24 Miguel de Icaza <miguel@ximian.com>
21223 * rootcontext.cs (RootContext): Init the interface_resolve_order
21224 and type_container_resolve_order always.
21226 (ResolveCore, BootstrapCorlib_ResolveClass,
21227 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
21228 compiler when compiling with --nostdlib
21230 * class.cs (TypeContainer.DefineType): Check that our parent is
21231 not null. This test is most important when we are bootstraping
21234 * codegen.cs: Split out the symbol writing code.
21236 2002-03-25 Martin Baulig <martin@gnome.org>
21238 * driver.cs (-g): Made -g an alias for --debug.
21240 2002-03-24 Martin Baulig <martin@gnome.org>
21242 * codegen.cs (SymbolWriter): New public variable. Returns the
21243 current symbol writer.
21244 (CodeGen): Added `bool want_debugging_support' argument to the
21245 constructor. If true, tell the ModuleBuild that we want debugging
21246 support and ask it for the ISymbolWriter.
21247 (Save): If we have a symbol writer, call it's Close() method after
21248 saving the assembly.
21250 * driver.c (--debug): New command line argument to create a
21251 debugger information file.
21253 * location.cs (SymbolDocument): New public property. Returns an
21254 ISymbolDocumentWriter object for the current source file or null
21255 if we don't have a symbol writer.
21257 2002-03-21 Miguel de Icaza <miguel@ximian.com>
21259 * driver.cs (LoadAssembly): Correctly return when all the paths
21260 have been tried and not before.
21262 * statement.cs (Switch.Emit): return the actual coverage for this
21263 statement (returns/not-returns)
21265 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
21266 switch of the statement if we are the last switch section. That
21267 kills two problems: try/catch problems (we used to emit an empty
21268 nop at the end) and switch statements where all branches would
21271 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21273 * driver.cs: Add default assemblies (the equivalent to the
21274 Microsoft CSC.RSP file)
21276 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21277 also update tokens_seen and set it to false.
21279 * driver.cs: Implement --recurse for Mike.
21281 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21282 correctly splitting out the paths.
21284 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21286 * interface.cs (Interface.PopulateProperty): Instead of using
21287 `parent' as the declaration space for the set parameters, use
21290 * support.cs (InternalParameters): InternalParameters constructor
21291 takes a DeclSpace instead of a TypeContainer.
21293 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21294 types are being initialized, load the address of it before calling
21297 (New): Provide a mechanism to disable the generation of local
21298 value type temporaries when the caller will be providing us with
21299 an address to store it.
21301 (ArrayCreation.EmitDynamicInitializers): Use it.
21303 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21305 * expression.cs (Invocation.EmitArguments): Only probe for array
21306 property if there is more than one argument. Sorry about that.
21308 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21309 empty param arrays.
21311 * class.cs (Method.LabelParameters): Fix incorrect code path that
21312 prevented the `ParamArrayAttribute' from being applied to the
21315 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21317 * support.cs (ReflectionParameters): Correctly compute whether the
21318 last argument is a params array. Fixes the problem with
21321 * typemanager.cs: Make the assemblies array always be non-null
21322 (empty, but non-null)
21324 * tree.cs (RecordDecl): New function that abstracts the recording
21325 of names. This reports error 101, and provides a pointer to the
21326 previous declaration. Fixes a crash in the compiler.
21328 * cs-parser.jay (constructor_declaration): Update to new grammar,
21329 and provide a constructor_body that can be empty.
21331 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21333 * driver.cs: Add support for --resources.
21335 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21336 Make all types for the various array helper methods be integer.
21338 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21339 CheckState to ConvCast.
21341 (ConvCast): Now it takes a `checked' state argument, to avoid
21342 depending on the emit context for the conversion, and just using
21343 the resolve time setting.
21345 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21346 instead of Invocation.EmitArguments. We do not emit the original
21347 arguments, instead we emit those which have been converted to
21348 unsigned int expressions.
21350 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21352 * codegen.cs: ditto.
21354 * expression.cs (LocalVariableReference): Drop the use of the
21355 Store function that depended on the variable index.
21357 * statement.cs (VariableInfo): Drop the `Idx' property from this
21358 class, as this is not taking into account the indexes for
21359 temporaries tat we generate during the execution, getting the
21362 * class.cs: First emit class initializers, then call the parent
21365 * expression.cs (Binary): Fix opcode emision.
21366 (UnaryMutator.EmitCode): Support checked code generation
21368 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21369 matches for events for both the Static and Instance scans,
21370 pointing to the same element. Fix that.
21372 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21374 * rootcontext.cs (ResolveTree): Always set the
21375 interface_resolve_order, because nested interfaces will be calling
21378 * class.cs (GetInterfaceOrClass): Track the same resolution
21379 process used by TypeManager.LookupType. This fixes the nested
21380 type lookups in class declarations (separate path from
21383 (TypeContainer.DefineType): Also define nested interfaces.
21384 (TypeContainer.RegisterOrder): New public function used to
21385 register the order in which child interfaces need to be closed.
21387 Nested interfaces need to be closed after their parents have been
21390 * interface.cs (InterfaceAttr): Put all the logic for computing
21391 the interface attribute here.
21393 (DefineInterface): Register our interface order with the
21394 RootContext or with the TypeContainer depending on the case.
21396 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21398 * cs-parser.jay: rework foreach statement to work with the new
21399 changes to the policy on SimpleNames.
21401 * report.cs: support Stacktrace on warnings as well.
21403 * makefile: drop --unsafe and /unsafe from the compile.
21405 2002-03-13 Ravi Pratap <ravi@ximian.com>
21407 * ecore.cs (StandardConversionExists): Modify to take an Expression
21408 as the first parameter. Ensure we do null -> reference type conversion
21411 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21412 temporary Expression objects.
21414 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21416 * interface.cs: workaround bug in method overloading resolution
21417 (there is already a bugzilla bug for it).
21419 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21421 We could also solve this problem by having a separate path for
21422 performing type lookups, instead of DoResolve, we could have a
21423 ResolveType entry point, and only participating pieces of the
21424 production (simplename, deref, array) would implement this.
21426 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21427 signal SimpleName to only resolve type names and not attempt to
21428 resolve anything else.
21430 * expression.cs (Cast): Set the flag.
21432 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21434 * class.cs: Only report 108 if there is no `new' modifier.
21436 * cs-parser.jay: rework foreach statement to work with the new
21437 changes to the policy on SimpleNames.
21439 * report.cs: support Stacktrace on warnings as well.
21441 * makefile: drop --unsafe and /unsafe from the compile.
21443 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21445 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21446 lookups here, instead of doing that at parse time. This means
21447 that our grammar will not introduce `LocalVariableReferences' as
21448 expressions at this point. That solves the problem of code like
21452 static void Main ()
21456 This is only half the fix. The full fix requires parameters to
21457 also be handled in this way.
21459 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21460 makes the use more obvious of the DeclSpace. The
21461 ec.TypeContainer.TypeBuilder is now only used to pull the
21462 TypeBuilder for it.
21464 My theory is that I can get rid of the TypeBuilder completely from
21465 the EmitContext, and have typecasts where it is used (from
21466 DeclSpace to where it matters).
21468 The only pending problem is that the code that implements Aliases
21469 is on TypeContainer, and probably should go in DeclSpace.
21471 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21472 lookups here, instead of doing that at parse time. This means
21473 that our grammar will not introduce `LocalVariableReferences' as
21474 expressions at this point. That solves the problem of code like
21478 static void Main ()
21482 This is only half the fix. The full fix requires parameters to
21483 also be handled in this way.
21485 * class.cs (Property.DefineMethod): When implementing an interface
21486 method, set newslot, when implementing an abstract method, do not
21487 set the flag (before we tried never setting it, or always setting
21488 it, which is the difference).
21489 (Indexer.DefineMethod): same.
21490 (Method.DefineMethod): same.
21492 * ecore.cs: Only set the status used flag if we get back a Field.
21494 * attribute.cs: Temporary hack, so Paolo can keep working.
21496 2002-03-08 Ravi Pratap <ravi@ximian.com>
21498 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21499 the unmanaged type in the case we have a MarshalAs attribute.
21501 (Resolve): Handle the case when we are parsing the special MarshalAs
21502 attribute [we need to store the unmanaged type to use later]
21504 * typemanager.cs (marshal_as_attr_type): Built in type for the
21505 MarshalAs Attribute.
21507 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21508 on parameters and accordingly set the marshalling info.
21510 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21512 * class.cs: Optimizing slightly by removing redundant code after
21513 we switched to the `NoTypes' return value.
21514 (Property.DefineMethod): use NoTypes here too.
21516 This fixes the bug I introduced in my last batch of changes.
21518 2002-03-05 Ravi Pratap <ravi@ximian.com>
21520 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21522 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21523 Enums since those are types too.
21525 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21527 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21528 thanks to a call during the lookup process.
21530 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21532 * statement.cs (Foreach): Lots of work to accomodate a particular
21533 kind of foreach statement that I had not kept in mind. It is
21534 possible to have foreachs on classes that provide a GetEnumerator
21535 method that return objects that implement the "pattern" for using
21536 a foreach, there is no need to support GetEnumerator
21539 This is needed to compile nant.
21541 * decl.cs: Only report 114 if the member is not `Finalize' and if
21542 the warning level is at least 2.
21544 * class.cs: Moved the compare function from Method to
21547 (MethodSignature.InheritableMemberSignatureCompare): Add new
21548 filter function that is used to extract inheritable methods from a
21551 (Method.Define): Use the new `inheritable_method_signature_filter'
21554 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21557 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21559 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21561 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21563 * expression.cs: Pass location information to
21564 ConvertImplicitStandard.
21566 * class.cs: Added debugging code to track return values from
21569 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21571 * expression.cs (Is.DoResolve): If either side of the `is' is an
21572 interface, do not flag the warning.
21574 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21577 * report.cs: Allow for --fatal to be used with --probe.
21579 * typemanager.cs (NoTypes): Move the definition for the empty Type
21582 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21584 (TypeContainer.DefineProxy): New function used to proxy to parent
21585 implementations when implementing interfaces.
21586 (TypeContainer.ParentImplements): used to lookup if our parent
21587 implements a public function that is required by an interface.
21588 (TypeContainer.VerifyPendingMethods): Hook this up.
21590 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21591 `modules' and `assemblies' arraylists into arrays. We only grow
21592 these are the very early start up of the program, so this improves
21593 the speedof LookupType (nicely measured).
21595 * expression.cs (MakeByteBlob): Replaced unsafe code with
21596 BitConverter, as suggested by Paolo.
21598 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21599 folding of string concatenation, but if either side is a string,
21600 and the other is not, then return null, and let the runtime use
21601 the concatenation on the string plus the object (using
21602 `Object.ToString').
21604 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21606 Constant Folding has been implemented now.
21608 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21609 the error instead on types that are not supported in one's
21612 * constant.cs (Constant and all children): New set of functions to
21613 perform implict and explicit conversions.
21615 * ecore.cs (EnumConstant): Implement the new functions to perform
21616 conversion by proxying to the child expression.
21618 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21619 own separate setting that can not be turned off from the command
21620 line using --unchecked or --checked and is only controlled using
21621 the checked/unchecked statements and expressions. This setting is
21622 used by the constant folder to flag errors.
21624 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21625 ConstantCheckState as well.
21627 During Resolve, they also have to flag the state, because the
21628 constant folder runs completely in the Resolve phase.
21630 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21633 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21635 * cfold.cs: New file, this file contains the constant folder.
21637 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21638 argument to track whether we are using the resulting address to
21639 load or store a value and provide better error messages.
21641 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21642 new AddressOf arguments.
21644 * statement.cs (Foreach.EmitCollectionForeach): Update
21646 * expression.cs (Argument.Emit): Call AddressOf with proper
21647 arguments to track usage.
21649 (New.DoEmit): Call AddressOf with new arguments.
21651 (Unary.Emit): Adjust AddressOf call.
21653 2002-03-01 Ravi Pratap <ravi@ximian.com>
21655 * cs-parser.jay (member_access): Change the case for pre-defined types
21656 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21659 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21662 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21663 essentially like methods and apply attributes like MethodImplOptions to them too.
21665 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21668 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21669 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21672 * Update code everywhere accordingly.
21674 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21676 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21678 2002-02-28 Ravi Pratap <ravi@ximian.com>
21680 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21681 try performing lookups against those instead of jumping straight into using
21682 the 'using' clauses.
21684 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21686 (LookupType): Perform lookups in implicit parents too.
21688 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21689 sequence as RootContext.LookupType.
21691 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21692 the various cases of namespace lookups into this method.
21694 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21696 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21697 in positional arguments)
21699 * class.cs (Operator): Update the AllowedModifiers to contain
21702 * cs-parser.jay: Update operator declaration to allow for the
21703 operator body to be empty.
21705 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21708 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21710 * class.cs (Method.Emit): Label parameters.
21712 * driver.cs: Return 1 or 0 as the program exit code.
21714 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21716 * expression.cs: Special case the `null' object when trying to
21717 auto-compute the type, as anything can be explicitly converted to
21720 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21721 spotting this Paolo.
21723 (Expression.ImplicitNumericConversion): Perform comparissions of
21724 the type using the underlying type in the case of an enumeration
21725 rather than using the enumeration type for the compare.
21727 Cope with the underlying == type case, which is not possible to
21730 (Expression.ConvertNumericExplicit): Perform comparissions of
21731 the type using the underlying type in the case of an enumeration
21732 rather than using the enumeration type for the compare.
21734 * driver.cs: If the user does not supply an extension, assume .exe
21736 * cs-parser.jay (if_statement): Rewrote so that we can track the
21737 location for the if statement.
21739 * expression.cs (Binary.ConstantFold): Only concat strings when
21740 the operation is "+", not everything ;-)
21742 * statement.cs (Statement.EmitBoolExpression): Take a location
21744 (If, While, Do): Track location.
21746 * expression.cs (Binary.ResolveOperator): In the object + string
21747 case, I was missing a call to ConvertImplicit
21749 2002-02-25 Ravi Pratap <ravi@ximian.com>
21751 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21752 Location arguments. Ensure we use RootContext.LookupType to do our work
21753 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21755 * interface.cs (PopulateMethod): Handle the type of the parameter being
21758 * expression.cs (Invocation.BetterFunction): Handle the case when we
21759 have a params method with no fixed arguments and a call is made with no
21762 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21764 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21765 the verbatim-string-literal
21767 * support.cs (InternalParameters.ParameterModifier): handle null
21769 (InternalParameters.ParameterType): ditto.
21771 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21772 duplicating the name of the variable parameter.
21773 (GetParameterByName): Fix bug where we were not looking up array
21774 paramters if they were the only present (thanks Paolo!).
21775 (GetParameterInfo): We only have an empty set of types if both
21776 fixed and array are set to null.
21777 (GetParameterInfo-idx): Handle FixedParameter == null
21779 * cs-parser.jay: Handle the case where there is no catch
21780 statements (missing null test).
21782 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21784 * driver.cs (MainDriver): Be conservative on our command line
21787 Catch DirectoryNotFoundException when calling GetFiles.
21789 (SplitPathAndPattern): Used to split the input specification into
21790 a path and a pattern that we can feed to Directory.GetFiles.
21792 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21794 * statement.cs (Fixed): Implement the last case of the Fixed
21795 statement (string handling).
21797 * expression.cs (StringPtr): New class used to return a char * to
21798 a string; Used by the Fixed statement.
21800 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21802 * expression.cs (Binary.ResolveOperator): Remove redundant
21803 MemberLookup pn parent type.
21804 Optimize union call, we do not need a union if the types are the same.
21805 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21808 Specialize the use of MemberLookup everywhere, instead of using
21809 the default settings.
21811 (StackAlloc): Implement stackalloc keyword.
21813 * cs-parser.jay: Add rule to parse stackalloc.
21815 * driver.cs: Handle /h, /help, /?
21817 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21818 before we supported unsafe code.
21820 * makefile: add --unsafe to the self compilation of mcs.
21822 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21824 * expression.cs (PointerArithmetic): New class that is used to
21825 perform pointer arithmetic.
21826 (Binary.Resolve): Handle pointer arithmetic
21827 Handle pointer comparission.
21828 (ArrayPtr): Utility expression class that is used to take the
21829 address of an array.
21831 (ElementAccess): Implement array access for pointers
21833 * statement.cs (Fixed): Implement fixed statement for arrays, we
21834 are missing one more case before we are done.
21836 * expression.cs (Indirection): Implement EmitAssign and set the
21837 ExprClass to Variable. This allows pointer dereferences to be
21838 treated as variables, and to have values assigned to them.
21840 * ecore.cs (Expression.StoreFromPtr): New utility function to
21841 store values dereferencing.
21843 2002-02-20 Ravi Pratap <ravi@ximian.com>
21845 * expression.cs (Binary.ResolveOperator): Ensure that we are
21846 not trying to operate on a void type - this fixes the reported
21849 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21850 the parent implementation is sealed.
21852 * ../errors/cs0239.cs : Add.
21854 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21856 * typemanager.cs (unverifiable_code_type): Corresponds to
21857 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21858 which have unsafe code in them.
21860 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21863 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21865 * cs-tokenizer.cs: Add support for @"litreal strings"
21867 Make tokenizer accept pre-processor directives
21868 on any column (remove the old C-like limitation).
21870 * rootcontext.cs (EmitCode): Emit any global attributes.
21871 (AddGlobalAttributes): Used to keep track of assembly attributes.
21873 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21875 * cs-parser.jay: Add support for global attributes.
21877 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21879 * expression.cs (Indirection): New helper class. Unary will
21880 create Indirection classes to be able to implement the
21881 IMemoryLocation interface on it.
21883 2002-02-16 Miguel de Icaza <miguel@ximian.com>
21885 * cs-parser.jay (fixed_statement): reference the right statement.
21887 * statement.cs (Fixed.Emit): Finish implementing the fixed
21888 statement for the &x case.
21890 2002-02-14 Miguel de Icaza <miguel@ximian.com>
21892 * class.cs (Property.Define, Method.Define): Remove newslot when
21895 * modifiers.cs: My use of NewSlot when `Abstract' was set was
21896 wrong. NewSlot should only be used if the `new' keyword is present.
21898 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
21899 locating our system dir. Sorry about this.
21901 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21903 * driver.cs (GetSystemDir): Compute correctly the location of our
21904 system assemblies. I was using the compiler directory instead of
21905 the library directory.
21907 2002-02-13 Ravi Pratap <ravi@ximian.com>
21909 * expression.cs (BetterFunction): Put back in what Miguel commented out
21910 since it is the correct fix. The problem is elsewhere ;-)
21912 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
21913 parameters of the parms method are themselves compatible or not !
21915 (StandardConversionExists): Fix very dangerous bug where we were forgetting
21916 to check that a class implements an interface before saying that an implicit
21917 conversion was allowed. Use ImplementsInterface to do the checking.
21919 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21921 * class.cs (Method.Define): Track whether we are an explicit
21922 implementation or not. And only call DefineMethodOverride if we
21923 are an explicit implementation.
21925 (Property.DefineMethod): Ditto.
21927 2002-02-11 Ravi Pratap <ravi@ximian.com>
21929 * expression.cs (BetterFunction): Catch hideous bug which was
21930 preventing us from detecting ambiguous calls due to implicit casts i.e
21933 2002-01-29 Miguel de Icaza <miguel@ximian.com>
21935 * support.cs (Pair): Remove un-needed method. I figured why I was
21936 getting the error in cs-parser.jay, the variable in a foreach loop
21937 is readonly, and the compiler does not really treat this as a variable.
21939 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
21940 instead of EQUALS in grammar.
21942 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
21944 * expression.cs (Unary.DoResolve): Check whether the argument is
21947 2002-01-28 Miguel de Icaza <miguel@ximian.com>
21949 * support.cs: Api for Pair to set a value. Despite the fact that
21950 the variables are public the MS C# compiler refuses to compile
21951 code that accesses the field if the variable is part of a foreach
21954 * statement.cs (Fixed): Begin implementation of the fixed
21957 (Block.AddVariable): Return the VariableInfo on success and null
21958 on failure instead of true/false.
21960 * cs-parser.jay (foreach): Catch errors on variables already
21961 defined (we were ignoring this value before) and properly unwind
21962 the block hierarchy
21964 (fixed_statement): grammar for the fixed statement.
21966 2002-01-25 Miguel de Icaza <miguel@ximian.com>
21968 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
21969 pointer types to be incretemented.
21971 (SizeOf): Implement.
21973 * cs-parser.jay (pointer_member_access): Implement
21974 expr->IDENTIFIER production.
21976 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
21977 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
21980 (Unary): Implement indirection.
21982 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
21983 use in non-unsafe context).
21985 (SimpleName.DoResolve): Check for pointers in field access on safe
21988 (Expression.LoadFromPtr): Factor the load-indirect code in this
21989 function. This was duplicated in UnboxCast and ParameterReference
21991 2002-01-24 Miguel de Icaza <miguel@ximian.com>
21993 * expression.cs (ComposedCast): report an error if a pointer cast
21994 is used in a safe region.
21996 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
21997 pointer type casts in unsafe context.
21999 * codegen.cs (EmitContext): Set up IsUnsafe.
22001 * cs-parser.jay (non_expression_type): Add productions for pointer
22004 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
22005 code. We should not use force into static mode if the method is
22006 not virtual. Fixes bug in MIS
22008 * statement.cs (Do.Emit, While.Emit, For.Emit,
22009 Statement.EmitBoolExpression): Add support to Do and While to
22010 propagate infinite loop as `I do return' semantics.
22012 Improve the For case to also test for boolean constants.
22014 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
22015 to the list of attributes we can add.
22017 Remove `EmitContext' argument.
22019 * class.cs (Method.Define): Apply parameter attributes.
22020 (Constructor.Define): Apply parameter attributes.
22021 (MethodCore.LabelParameters): Move here the core of labeling
22024 * support.cs (ReflectionParameters.ParameterModifier,
22025 InternalParameters.ParameterModifier): Use IsByRef on the type and
22026 only return the OUT bit for these parameters instead of in/out/ref
22029 This is because I miss-understood things. The ParameterInfo.IsIn
22030 and IsOut represent whether the parameter has the [In] and [Out]
22033 2002-01-22 Miguel de Icaza <miguel@ximian.com>
22035 * ecore.cs (FieldExpr.Emit): Release temporaries.
22037 * assign.cs (LocalTemporary.Release): new function.
22039 * codegen.cs (EmitContext.GetTemporaryStorage,
22040 EmitContext.FreeTemporaryStorage): Rework the way we deal with
22041 temporary storage. Now we can "put back" localbuilders when we
22044 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22046 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22047 need to make a copy of the variable to generate verifiable code.
22049 2002-01-19 Miguel de Icaza <miguel@ximian.com>
22051 * driver.cs: Compute dynamically the system directory.
22053 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
22054 Slower, but more generally useful. Used by the abstract
22055 registering implementation.
22057 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
22058 the rules for the special rule on Type/instances. First check if
22059 we have the same name, and if so, try that special static path
22060 rather than the instance path.
22062 2002-01-18 Miguel de Icaza <miguel@ximian.com>
22064 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
22067 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
22068 Enum, ValueType, Delegate or Array for non-corlib compiles.
22070 * cs-tokenizer.cs: Catch long identifiers (645)
22072 * typemanager.cs (IndexerPropetyName): Ravi never tested this
22075 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
22076 fix, we were returning too early, so we were not registering
22077 pending methods from abstract classes.
22079 Do not register pending methods if the class is abstract.
22081 * expression.cs (Conditional.DoResolve): Report circular implicit
22082 conversions when we neecd to compute it for conditional
22085 (Is.DoResolve): If the expression is always of the provided type,
22086 flag warning 183. If the expression can not ever be of the
22087 provided type flag warning 184.
22089 * class.cs: Catch 169 as well.
22091 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
22094 2002-01-18 Nick Drochak <ndrochak@gol.com>
22096 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
22098 2002-01-17 Miguel de Icaza <miguel@ximian.com>
22100 * interface.cs: (PopulateMethod): Check for pointers being defined
22101 only if the unsafe context is active.
22102 (PopulateProperty): ditto.
22103 (PopulateIndexer): ditto.
22105 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
22106 specified. If pointers are present, make sure that they are
22107 present in an unsafe context.
22108 (Constructor, Constructor.Define): ditto.
22109 (Field, Field.Define): ditto.
22110 (Property, Property.Define): ditto.
22111 (Event, Event.Define): ditto.
22113 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
22114 hashtable if there are classes or structs defined.
22116 * expression.cs (LocalVariableReference.DoResolve): Simplify this
22117 code, as the constant resolution moved.
22119 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
22120 the metadata, so we can flag error 133.
22122 * decl.cs (MemberCore.UnsafeOK): New function to test that a
22123 pointer is being declared in an unsafe context.
22125 2002-01-16 Miguel de Icaza <miguel@ximian.com>
22127 * modifiers.cs (Modifiers.Check): Require a Location argument.
22128 Report error 227 for Unsafe use.
22130 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
22132 * statement.cs (For.Emit): If the test is null, then report that
22133 we do `return', as we wont reach anything afterwards.
22135 (Switch.SwitchGoverningType): Track the expression that matched
22138 * driver.cs: Allow negative numbers as an error code to flag.
22140 * cs-parser.jay: Handle 1551.
22142 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
22144 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22146 * cs-parser.jay: Report 1518 (type declaration can only contain
22147 class, struct, interface, enum or delegate)
22149 (switch_label): Report 1523 (keywords `case' or `default' must
22152 (opt_switch_sections): Report 1522 (empty switch)
22154 * driver.cs: Report 1515 (response file specified multiple times)
22155 Report 1516 (Source file specified multiple times).
22157 * expression.cs (Argument.Resolve): Signal 1510
22159 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
22160 access not allowed in static code)
22162 2002-01-11 Ravi Pratap <ravi@ximian.com>
22164 * typemanager.cs (IsPointerType): Utility method which we are going
22167 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
22168 the object type, so we take care of that.
22170 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
22172 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
22173 added to non-params parameters :-)
22175 * typemanager.cs (CSharpName): Include 'void' type too.
22177 (void_ptr_type): Include in the set of core types.
22179 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
22182 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
22185 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
22186 completely forgotten about it.
22188 2002-01-10 Ravi Pratap <ravi@ximian.com>
22190 * cs-parser.jay (pointer_type): Add. This begins our implementation
22191 of parsing rules for unsafe code.
22193 (unsafe_statement): Implement.
22195 (embedded_statement): Modify to include the above.
22197 * statement.cs (Unsafe): Implement new class for unsafe blocks.
22199 * codegen.cs (EmitContext.InUnsafe): Add. This determines
22200 if the current context is an unsafe one.
22202 * cs-parser.jay (local_variable_pointer_type): Since local variable types
22203 are handled differently, we need separate rules for them.
22205 (local_variable_declaration): Update to use local_variable_pointer_type
22206 to allow variable declarations of unmanaged pointer types.
22208 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
22209 in unsafe contexts.
22211 * ../errors/cs0214.cs : Add.
22213 2002-01-16 Nick Drochak <ndrochak@gol.com>
22215 * makefile: remove 'response' file when cleaning.
22217 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22219 * cs-parser.jay: Report 1524.
22221 2002-01-14 Miguel de Icaza <miguel@ximian.com>
22223 * typemanager.cs (RegisterMethod): drop checking if we have
22224 registered this from here
22226 2002-01-12 Miguel de Icaza <miguel@ximian.com>
22228 * class.cs (Method.EmitDestructor): Implement calling our base
22231 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
22232 value of InFinally.
22234 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
22235 this routine and will wrap the call in a try/catch block. Deal
22238 2002-01-11 Miguel de Icaza <miguel@ximian.com>
22240 * ecore.cs (Expression.MemberLookup): instead of taking a
22241 parameter `same_type' that was used to tell whether we could
22242 access private members we compute our containing type from the
22245 (FieldExpr): Added partial support for volatile fields. This does
22246 not work for volatile fields exposed from assemblies, as I can not
22247 figure out how to extract the modreq from it.
22249 Updated all the source files to use this.
22251 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
22252 because it is referenced by MemberLookup very often.
22254 2002-01-09 Ravi Pratap <ravi@ximian.com>
22256 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
22257 TypeBuilder.GetCustomAttributes to retrieve what we need.
22259 Get rid of redundant default_member_attr_type as this is the same as
22260 default_member_type which already exists.
22262 * interface.cs, attribute.cs : Update accordingly.
22264 2002-01-08 Miguel de Icaza <miguel@ximian.com>
22266 * typemanager.cs: Enable IndexerPropertyName again. It does not
22267 work for TYpeBuilders though. Ravi, can you please fix this?
22269 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22271 * expression.cs (Argument.Emit): Handle the case of ref objects
22272 being passed to ref functions;
22274 (ParameterReference.EmitLoad): Loads the content of the pointer
22275 without dereferencing.
22277 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22279 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22281 2002-01-08 Ravi Pratap <ravi@ximian.com>
22283 * class.cs (Indexer.DefineMethod): Incorporate the interface
22284 type in the name of the method if we are doing explicit interface
22287 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22289 (BetterConversion): Fix extremely trivial bug where we were referring to
22290 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22293 * ../errors/bug16.cs : Add although we have fixed it.
22295 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22297 * expression.cs (BaseIndexer): Begin implementation.
22299 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22301 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22302 production directly to remove a shift/reduce, and implement
22303 explicit interface implementation.
22305 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22306 after a floating point suffix.
22308 * expression.cs (DoNumericPromotions): Improved the conversion for
22309 uint/uint. If we have a constant, we avoid doing a typecast to a
22312 * class.cs (Indexer): Implement explicit interface implementation
22315 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22317 * class.cs: make the default instance constructor public and hidebysig.
22319 2001-01-03 Ravi Pratap <ravi@ximian.com>
22321 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22322 so we can call it from elsewhere.
22324 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22325 we emit it internally if the class has a defined indexer; otherwise the user
22326 emits it by decorating the class definition with the DefaultMemberAttribute.
22328 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22329 attribute is not used on a type which defines an indexer.
22331 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22332 character when we skip whitespace.
22334 * ../errors/cs0646.cs : Add.
22336 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22338 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22341 * makefile: Add practical target `mcs3.exe' which builds the third
22342 generation compiler.
22344 * expression.cs (New): Fix structures constructor calling.
22346 * class.cs (Property, Method, Indexer): Emit Final flag on the
22347 method if we are an interface implementation and we are not
22350 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22351 whether this property is referencing a `base' method.
22353 * expression.cs (Invocation.EmitCall): take an extra argument:
22354 is_base, this is used to determine whether the `call' or
22355 `callvirt' opcode should be used.
22358 * delegate.cs: update EmitCall.
22360 * class.cs (Method.Define): Set NewSlot for the cases where we are
22361 not implementing an interface method.
22363 (Property.Define): ditto.
22365 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22367 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22368 'r'. Allows mcs to parse itself fully.
22370 2002-01-02 Ravi Pratap <ravi@ximian.com>
22372 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22373 of the number of initializers that require the InitializeArray method.
22375 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22376 update the above field where necessary.
22378 (MakeByteBlob): Update accordingly.
22380 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22383 (EmitDynamicInitializers): Update in accordance with the new optimization.
22385 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22386 same OpCode applies.
22388 * cs-parser.jay : Fix some glaring errors I introduced.
22390 2002-01-01 Ravi Pratap <ravi@ximian.com>
22392 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22393 so that we can check for name clashes there too.
22395 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22396 for interface indexers.
22398 * interfaces.cs (Define): Emit the default member attribute.
22400 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22401 variable was being referred to while setting the value ;-)
22403 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22405 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22406 byte-by-byte information when we know the data is zero.
22408 Make the block always a multiple of 4, because
22409 DefineInitializedData has a bug.
22411 * assign.cs: Fix, we should assign from the temporary, not from
22414 * expression.cs (MakeByteBlob): Fix my incorrect code.
22416 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22418 * typemanager.cs (EnumToUnderlying): This function is used to get
22419 the underlying type from an enumeration, because it does not
22422 * constant.cs: Use the I4_S form for values between -128 and 127.
22424 * statement.cs (Block.LookupLabel): Looks up a label.
22425 (Block): Drop support for labeled blocks.
22427 (LabeledStatement): New kind of statement that represents a label
22430 (Goto): Finally implement this bad boy.
22432 * cs-parser.jay: Update to reflect new mechanism to implement
22435 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22437 * codegen.cs (EmitContext.This): a codegen property that keeps the
22438 a single instance of this instead of creating many different this
22441 * delegate.cs (Delegate.DoResolve): Update to use the property;
22443 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22445 * expression.cs (BaseAccess.DoResolve): Ditto.
22447 2001-12-29 Ravi Pratap <ravi@ximian.com>
22449 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22450 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22452 (InitCoreTypes): Update accordingly.
22454 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22455 so we can quickly store the state.
22457 (ApplyAttributes): Set the correct implementation flags
22458 for InternalCall methods.
22460 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22462 * expression.cs (EmitCall): if a method is not virtual, then do
22463 not use callvirt on it.
22465 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22466 user defined stuff) requires the use of stobj, which takes an
22467 address on the stack instead of an array and an index. So emit
22468 the Ldelema operation for it.
22470 (EmitStoreOpcode): Use stobj for valuetypes.
22472 (UnaryMutator.EmitCode): Use the right 1 value depending on
22473 whether we are dealing with int64/uint64, float or doubles.
22475 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22476 constructors that I implemented last night.
22478 (Constructor.IsDefault): Fix to work properly for static
22481 * cs-parser.jay (CheckDef): report method signature errors.
22482 Update error number 103 to be 132.
22484 * decl.cs: New AdditionResult enumeration value: MethodExists.
22485 Although we do this check for methods later on in the semantic
22486 analysis, catching repeated default constructors is so easy that
22487 we catch these here.
22489 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22492 (ParameterReference.EmitAssign, Emit): handle
22495 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22496 (ArrayAccess.EmitStoreOpcode): ditto.
22498 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22500 * expression.cs (MakeByteBlob): Complete all the missing types
22501 (uint, short, ushort, byte, sbyte)
22503 * class.cs: Only init instance field initializers on instance
22506 Rename `constructors' to instance_constructors.
22508 (TypeContainer.AddConstructor): Only add constructors to the list
22509 if it is not static.
22511 Make sure that we handle default_static_constructor independently
22512 everywhere where we handle instance_constructors
22514 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22516 * class.cs: Do not lookup or create a base initializer for a
22517 static constructor.
22519 (ConstructorInitializer.Resolve): use the proper type to lookup
22522 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22524 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22527 * decl.cs: CloseType is now an virtual method, the default
22528 implementation just closes this type.
22530 2001-12-28 Ravi Pratap <ravi@ximian.com>
22532 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22533 to PreserveSig by default. Also emit HideBySig on such methods.
22535 Basically, set the defaults to standard values.
22537 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22538 argument, if candidate is better, it can't be worse than the best !
22540 (Invocation): Re-write bits to differentiate between methods being
22541 applicable in their expanded form and their normal form - for params
22544 Get rid of use_standard everywhere as only standard conversions are allowed
22545 in overload resolution.
22547 More spec conformance.
22549 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22551 * driver.cs: Add --timestamp, to see where the compiler spends
22554 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22555 `this' in static code.
22557 (SimpleName.DoResolve): Implement in terms of a helper function
22558 that allows static-references to be passed upstream to
22561 (Expression.ResolveWithSimpleName): Resolve specially simple
22562 names when called by MemberAccess to implement the special
22565 (Expression.ImplicitReferenceConversion): Handle conversions from
22566 Null to reference types before others, as Null's type is
22569 * expression.cs (Invocation.EmitCall): Handle the special case of
22570 calling methods declared on a reference type from a ValueType
22571 (Base classes System.Object and System.Enum)
22573 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22574 the left hand side is a TypeExpr, not on every enumeration.
22576 (Binary.Resolve): If types are reference types, then do a cast to
22577 object on operators != and == of both arguments.
22579 * typemanager.cs (FindMembers): Extract instance and static
22580 members if requested.
22582 * interface.cs (PopulateProperty): Use void_type instead of null
22583 as the return type for the setter method.
22585 (PopulateIndexer): ditto.
22587 2001-12-27 Ravi Pratap <ravi@ximian.com>
22589 * support.cs (ReflectionParameters): Fix minor bug where we
22590 were examining the wrong parameter for the ParamArray attribute.
22592 Cope with requests for the type of the parameter at position
22593 greater than the params parameter's. We now return the element
22594 type of the params array as that makes more sense.
22596 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22597 accordingly as we no longer have to extract the element type
22600 (Invocation.OverloadResolve): Update.
22602 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22604 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22605 against IEnumerator, test whether the return value is a descendant
22606 of the IEnumerator interface.
22608 * class.cs (Indexer.Define): Use an auxiliary method to implement
22609 the other bits of the method definition. Begin support for
22610 explicit interface implementation.
22612 (Property.DefineMethod): Use TypeManager.void_type instead of null
22613 for an empty return value.
22615 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22617 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22618 dealing with a FieldExpr which is composed of a FieldBuilder, in
22619 the code path we did extract the constant, but we should have
22620 obtained the underlying value to be able to cast it (otherwise we
22621 end up in an infinite loop, this is what Ravi was running into).
22623 (ArrayCreation.UpdateIndices): Arrays might be empty.
22625 (MemberAccess.ResolveMemberAccess): Add support for section
22626 14.5.4.1 that deals with the special case of E.I when E is a type
22627 and something else, that I can be a reference to a static member.
22629 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22630 handle a particular array type to create byte blobs, it is just
22631 something we dont generate byteblobs for.
22633 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22636 * location.cs (Push): remove the key from the hashtable that we
22637 are about to add. This happens for empty files.
22639 * driver.cs: Dispose files after we have parsed them.
22641 (tokenize): new function that only runs the tokenizer on its
22642 input, for speed testing.
22644 2001-12-26 Ravi Pratap <ravi@ximian.com>
22646 * class.cs (Event.Define): Define the private field only if there
22647 are no accessors defined.
22649 * expression.cs (ResolveMemberAccess): If there is no associated
22650 field with the event, that means we have an event defined with its
22651 own accessors and we should flag error cs0070 since transforming
22652 ourselves into a field is not valid in that case.
22654 * ecore.cs (SimpleName.DoResolve): Same as above.
22656 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22657 and charset to sane values.
22659 2001-12-25 Ravi Pratap <ravi@ximian.com>
22661 * assign.cs (DoResolve): Perform check on events only if they
22662 are being accessed outside the declaring type.
22664 * cs-parser.jay (event_declarations): Update rules to correctly
22665 set the type of the implicit parameter etc.
22667 (add_accessor, remove_accessor): Set current local parameters.
22669 * expression.cs (Binary): For delegate addition and subtraction,
22670 cast the return value from the method into the appropriate delegate
22673 2001-12-24 Ravi Pratap <ravi@ximian.com>
22675 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22676 of these as the workaround is unnecessary.
22678 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22679 delegate data - none of that is needed at all.
22681 Re-write bits to extract the instance expression and the delegate method
22684 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22687 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22688 of attaching attributes instead of duplicating code everywhere.
22690 * everywhere : Update code to do attribute emission using the above method.
22692 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22694 * expression.cs (IsParamsMethodApplicable): if there are not
22695 parameters, return immediately.
22697 * ecore.cs: The 0 literal can be implicity converted to an enum
22700 (SimpleName.DoResolve): First lookup the type, then lookup the
22703 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22704 want to get its address. If the InstanceExpression is not
22705 addressable, store the result in a temporary variable, then get
22708 * codegen.cs: Only display 219 errors on warning level or above.
22710 * expression.cs (ArrayAccess): Make it implement the
22711 IMemoryLocation interface.
22713 (Binary.DoResolve): handle the operator == (object a, object b)
22714 and operator != (object a, object b) without incurring into a
22715 BoxedCast (because 5 != o should never be performed).
22717 Handle binary enumerator operators.
22719 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22720 value type, otherwise use Ldelem_ref.
22722 Use precomputed names;
22724 (AddressOf): Implement address of
22726 * cs-parser.jay (labeled_statement): Fix recursive block
22727 addition by reworking the production.
22729 * expression.cs (New.DoEmit): New has a special case:
22731 If we are dealing with a ValueType, we have a few
22732 situations to deal with:
22734 * The target of New is a ValueType variable, that is
22735 easy, we just pass this as the variable reference
22737 * The target of New is being passed as an argument,
22738 to a boxing operation or a function that takes a
22741 In this case, we need to create a temporary variable
22742 that is the argument of New.
22745 2001-12-23 Ravi Pratap <ravi@ximian.com>
22747 * rootcontext.cs (LookupType): Check that current_type is not null before
22748 going about looking at nested types.
22750 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22751 not implement the IAssignMethod interface any more.
22753 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22754 where we tranform them into FieldExprs if they are being resolved from within
22755 the declaring type.
22757 * ecore.cs (SimpleName.DoResolve): Do the same here.
22759 * assign.cs (DoResolve, Emit): Clean up code considerably.
22761 * ../errors/bug10.cs : Add.
22763 * ../errors/cs0070.cs : Add.
22765 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22767 * assign.cs : Get rid of EventIsLocal everywhere.
22769 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22771 * ecore.cs (ConvertIntLiteral): finished the implementation.
22773 * statement.cs (SwitchLabel): Convert the value we are using as a
22774 key before looking up the table.
22776 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22778 * codegen.cs (EmitTopBlock): Require a Location argument now.
22780 * cs-parser.jay (constructor_declarator): We need to setup
22781 current_local_parameters before we parse the
22782 opt_constructor_initializer, to allow the variables to be bound
22783 to the constructor arguments.
22785 * rootcontext.cs (LookupType): First lookup nested classes in our
22786 class and our parents before we go looking outside our class.
22788 * expression.cs (ConstantFold): Extract/debox the values at the
22791 * rootcontext.cs (EmitCode): Resolve the constants first before we
22792 resolve the types. This is not really needed, but it helps debugging.
22794 * statement.cs: report location.
22796 * cs-parser.jay: pass location to throw statement.
22798 * driver.cs: Small bug fix.
22800 * report.cs: Updated format to be 4-zero filled digits.
22802 2001-12-22 Ravi Pratap <ravi@ximian.com>
22804 * expression.cs (CheckIndices): Fix minor bug where the wrong
22805 variable was being referred to ;-)
22807 (DoEmit): Do not call EmitStaticInitializers when the
22808 underlying type is System.Object.
22810 2001-12-21 Ravi Pratap <ravi@ximian.com>
22812 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22813 and do the usual workaround for SRE.
22815 * class.cs (MyEventBuilder.EventType): New member to get at the type
22816 of the event, quickly.
22818 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22820 * assign.cs (Assign.DoResolve): Handle the case when the target
22821 is an EventExpr and perform the necessary checks.
22823 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22826 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22828 (EventExpr): Set the type in the constructor itself since we
22829 are meant to be born fully resolved.
22831 (EventExpr.Define): Revert code I wrote earlier.
22833 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22834 instance expression is null. The instance expression is a This in that case
22835 or a null, depending on whether it is a static method or not.
22837 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22838 refers to more than one method.
22840 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22841 and accordingly flag errors.
22843 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22845 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22847 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22849 * location.cs (ToString): Provide useful rutine.
22851 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22853 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22854 objects, return the actual integral boxed.
22856 * statement.cs (SwitchLabel): define an ILLabel for each
22859 (Switch.CheckSwitch): If the value is a Literal, extract
22860 the underlying literal.
22862 Also in the unused hashtable we had, add the SwitchLabel so we can
22863 quickly look this value up.
22865 * constant.cs: Implement a bunch of new constants. Rewrite
22866 Literal based on this. Made changes everywhere to adapt to this.
22868 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22869 dereferencing array only once, and also copes with enumrations.
22871 bytes are two bytes wide, not one.
22873 (Cast): Perform constant conversions.
22875 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22876 wrappers to the literals here.
22878 * expression.cs (DoNumericPromotions): long literals can converted
22879 to ulong implicity (this is taken care of elsewhere, but I was
22880 missing this spot).
22882 * ecore.cs (Expression.Literalize): Make the return type Literal,
22883 to improve type checking.
22885 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
22887 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22889 * literal.cs: Revert code from ravi that checked the bounds. The
22890 bounds are sane by the definition of the type itself.
22892 * typemanager.cs: Fix implementation of ImplementsInterface. We
22893 need to actually look up in our parent hierarchy for interfaces
22896 * const.cs: Use the underlying type for enumerations
22898 * delegate.cs: Compute the basename for the delegate creation,
22899 that should fix the delegate test case, and restore the correct
22900 Type Lookup semantics in rootcontext
22902 * rootcontext.cs: Revert Ravi's last patch. The correct way of
22903 referencing a nested type with the Reflection API is using the "+"
22906 * cs-parser.jay: Do not require EOF token at the end.
22908 2001-12-20 Ravi Pratap <ravi@ximian.com>
22910 * rootcontext.cs (LookupType): Concatenate type names with
22911 a '.' instead of a '+' The test suite passes again.
22913 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
22914 field of the enumeration.
22916 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
22917 the case when the member is an EventExpr.
22919 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
22920 static has an associated instance expression.
22922 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
22924 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
22926 * class.cs (Event.Define): Register event and perform appropriate checks
22929 We define the Add and Remove methods even if the use provides none because
22930 in that case, we provide default implementations ourselves.
22932 Define a private field of the type of the event. This is done by the CSC compiler
22933 and we should be doing it too ;-)
22935 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
22936 More methods we use in code we generate.
22938 (multicast_delegate_type, delegate_type): Two separate types since the distinction
22941 (InitCoreTypes): Update accordingly for the above.
22943 * class.cs (Event.Emit): Generate code for default accessors that we provide
22945 (EmitDefaultMethod): Do the job in the above.
22947 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
22950 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22952 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
22953 builders even if we were missing one.
22955 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
22956 pass the Basename as our class name instead of the Name. The
22957 basename will be correctly composed for us.
22959 * parameter.cs (Paramters): Now takes a Location argument.
22961 * decl.cs (DeclSpace.LookupType): Removed convenience function and
22962 make all the code call directly LookupType in RootContext and take
22963 this chance to pass the Location information everywhere.
22965 * Everywhere: pass Location information.
22967 2001-12-19 Miguel de Icaza <miguel@ximian.com>
22969 * class.cs (Constructor.Define): Updated way of detecting the
22970 length of the parameters.
22972 (TypeContainer.DefineType): Use basename as the type name for
22975 (TypeContainer.Define): Do not recursively define types here, as
22976 definition is taken care in order by the RootContext.
22978 * tree.cs: Keep track of namespaces in a per-file basis.
22980 * parameter.cs (Parameter.ComputeSignature): Update to use
22983 (Parameters.GetSignature): ditto.
22985 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
22986 instead of a TypeContainer.
22988 (Interface.SemanticAnalysis): Use `this' instead of our parent to
22989 resolve names. Because we need to be resolve in our context, not
22992 * driver.cs: Implement response files.
22994 * class.cs (TypeContainer.DefineType): If we are defined, do not
22995 redefine ourselves.
22997 (Event.Emit): Emit the code for add/remove handlers.
22998 (Event.Define): Save the MethodBuilders for add/remove.
23000 * typemanager.cs: Use pair here too.
23002 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
23003 DictionaryEntry requires the first argument to be non-null.
23005 (enum_declaration): Compute full name for registering the
23008 (delegate_declaration): Instead of using
23009 formal_parameter_list, use opt_formal_parameter_list as the list
23012 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
23013 (EventParsing): New property that controls whether `add' and
23014 `remove' are returned as tokens or identifiers (for events);
23016 2001-12-19 Ravi Pratap <ravi@ximian.com>
23018 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
23019 use MyEventBuilder only and let it wrap the real builder for us.
23021 (MyEventBuilder): Revamp constructor etc.
23023 Implement all operations that we perform on EventBuilder in precisely the same
23026 (FindMembers): Update to use the EventBuilder member.
23028 (Event.Emit): Update accordingly.
23030 2001-12-18 Ravi Pratap <ravi@ximian.com>
23032 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
23033 by calling the appropriate methods.
23035 (GetCustomAttributes): Make stubs as they cannot possibly do anything
23038 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
23040 2001-12-17 Ravi Pratap <ravi@ximian.com>
23042 * delegate.cs (Delegate.Populate): Check that the return type
23043 and various parameters types are indeed accessible.
23045 * class.cs (Constructor.Define): Same here.
23047 (Field.Define): Ditto.
23049 (Event.Define): Ditto.
23051 (Operator.Define): Check that the underlying Method defined itself
23052 correctly - so it's MethodBuilder should not be null.
23054 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
23055 expression happens to be null.
23057 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
23058 members but as of now we don't seem to be able to do anything really useful with it.
23060 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
23061 not the EventBuilder.
23063 2001-12-18 Miguel de Icaza <miguel@ximian.com>
23065 * cs-tokenizer.cs: Add support for defines.
23066 Add support for #if, #elif, #else, #endif
23068 (eval_var): evaluates a variable.
23069 (eval): stubbed for evaluating functions.
23071 * cs-parser.jay: Pass the defines information
23073 * driver.cs: Add --define command line option.
23075 * decl.cs: Move MemberCore here.
23077 Make it the base class for DeclSpace. This allows us to catch and
23078 report 108 and 109 for everything now.
23080 * class.cs (TypeContainer.Define): Extract all the members
23081 before populating and emit the warning 108 (new keyword required
23082 to override) instead of having each member implement this.
23084 (MemberCore.Define): New abstract method, we will be using this in
23085 the warning reporting engine in Populate.
23087 (Operator.Define): Adjust to new MemberCore protocol.
23089 * const.cs (Const): This does not derive from Expression, it is a
23090 temporary object we use to create fields, it is a MemberCore.
23092 * class.cs (Method.Define): Allow the entry point to be in a
23095 * driver.cs: Rewrite the argument handler to clean it up a bit.
23097 * rootcontext.cs: Made it just an auxiliary namespace feature by
23098 making everything static.
23100 * driver.cs: Adapt code to use RootContext type name instead of
23103 * delegate.cs: Remove RootContext argument.
23105 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
23108 * class.cs (Event.Define): The lookup can fail.
23110 * cs-tokenizer.cs: Begin implementation of pre-procesor.
23112 * expression.cs: Resolve the this instance before invoking the code.
23114 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23116 * cs-parser.jay: Add a production in element_access that allows
23117 the thing to become a "type" reference. This way we can parse
23118 things like "(string [])" as a type.
23120 Note that this still does not handle the more complex rules of
23124 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
23126 * ecore.cs: (CopyNewMethods): new utility function used to
23127 assemble the list of methods from running FindMembers.
23129 (MemberLookup): Rework FindMembers so that
23131 2001-12-16 Miguel de Icaza <miguel@ximian.com>
23133 * class.cs (TypeContainer): Remove Delegates who fail to be
23136 * delegate.cs (Populate): Verify that we dont get null return
23137 values. TODO: Check for AsAccessible.
23139 * cs-parser.jay: Use basename to emit error 574 (destructor should
23140 have the same name as container class), not the full name.
23142 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
23143 possible representation.
23145 Also implements integer type suffixes U and L.
23147 2001-12-15 Miguel de Icaza <miguel@ximian.com>
23149 * expression.cs (ArrayCreation.DoResolve): We need to do the
23150 argument resolution *always*.
23152 * decl.cs: Make this hold the namespace. Hold the root context as
23154 (LookupType): Move here.
23156 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
23158 * location.cs (Row, Name): Fixed the code, it was always returning
23159 references to the first file.
23161 * interface.cs: Register properties defined through interfaces.
23163 * driver.cs: Add support for globbing on the command line
23165 * class.cs (Field): Make it derive from MemberCore as well.
23168 2001-12-15 Ravi Pratap <ravi@ximian.com>
23170 * class.cs (Event::Define): Check that the type of the event is a delegate
23171 type else flag error #66.
23173 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
23176 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
23177 values of EntryPoint, CharSet etc etc.
23179 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
23181 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
23182 be null and we should ignore this. I am not sure if this is really clean. Apparently,
23183 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
23184 which needs this to do its work.
23186 * ../errors/cs0066.cs : Add.
23188 2001-12-14 Miguel de Icaza <miguel@ximian.com>
23190 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
23193 * class.cs: (MethodSignature.MethodSignature): Removed hack that
23194 clears out the parameters field.
23195 (MemberSignatureCompare): Cleanup
23197 (MemberCore): New base class used to share code between MethodCore
23200 (RegisterRequiredImplementations) BindingFlags.Public requires
23201 either BindingFlags.Instace or Static. Use instance here.
23203 (Property): Refactored code to cope better with the full spec.
23205 * parameter.cs (GetParameterInfo): Return an empty array instead
23208 * class.cs (Property): Abstract or extern properties have no bodies.
23210 * parameter.cs (GetParameterInfo): return a zero-sized array.
23212 * class.cs (TypeContainer.MethodModifiersValid): Move all the
23213 method modifier validation to the typecontainer so we can reuse
23214 this on properties.
23216 (MethodCore.ParameterTypes): return an empty sized array of types.
23218 (Property.Define): Test property modifier validity.
23220 Add tests for sealed/override too.
23222 (Method.Emit): abstract or extern methods have no bodies.
23224 2001-12-14 Ravi Pratap <ravi@ximian.com>
23226 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
23229 (Method::Define, ::Emit): Modify accordingly.
23231 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
23233 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
23235 * makefile: Pass in /unsafe.
23237 2001-12-13 Miguel de Icaza <miguel@ximian.com>
23239 * class.cs (MakeKey): Kill routine.
23241 * class.cs (TypeContainer.Define): Correctly define explicit
23242 method implementations (they require the full interface name plus
23245 * typemanager.cs: Deply the PtrHashtable here and stop using the
23246 lame keys. Things work so much better.
23248 This of course broke everyone who depended on `RegisterMethod' to
23249 do the `test for existance' test. This has to be done elsewhere.
23251 * support.cs (PtrHashtable): A hashtable that avoid comparing with
23252 the object stupid Equals method (because, that like fails all over
23253 the place). We still do not use it.
23255 * class.cs (TypeContainer.SetRequiredInterface,
23256 TypeContainer.RequireMethods): Killed these two routines and moved
23257 all the functionality to RegisterRequiredImplementations.
23259 (TypeContainer.RegisterRequiredImplementations): This routine now
23260 registers all the implementations required in an array for the
23261 interfaces and abstract methods. We use an array of structures
23262 which can be computed ahead of time to reduce memory usage and we
23263 also assume that lookups are cheap as most classes will not
23264 implement too many interfaces.
23266 We also avoid creating too many MethodSignatures.
23268 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23269 clear the "pending" bit if we find that there are problems with
23272 (TypeContainer.VerifyPendingMethods): Update to report errors of
23273 methods that look like implementations but are not.
23275 (TypeContainer.Define): Add support for explicit interface method
23278 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23280 * typemanager.cs: Keep track of the parameters here instead of
23281 being a feature of the TypeContainer.
23283 * class.cs: Drop the registration of parameters here, as
23284 InterfaceMethods are also interface declarations.
23286 * delegate.cs: Register methods with the TypeManager not only with
23287 the TypeContainer. This code was buggy.
23289 * interface.cs: Full registation here.
23291 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23293 * expression.cs: Remove reducer for binary expressions, it can not
23296 * const.cs: Put here the code that used to go into constant.cs
23298 * constant.cs: Put here the code for constants, this is a new base
23299 class for Literals.
23301 * literal.cs: Make Literal derive from Constant.
23303 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23305 * statement.cs (Return.Emit): Report error 157 if the user
23306 attempts to return from a finally block.
23308 (Return.Emit): Instead of emitting a return, jump to the end of
23311 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23312 LocalBuilder to store the result of the function. ReturnLabel is
23313 the target where we jump.
23316 2001-12-09 Radek Doulik <rodo@ximian.com>
23318 * cs-parser.jay: remember alias in current namespace
23320 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23323 * class.cs (LookupAlias): lookup alias in my_namespace
23325 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23327 (LookupAlias): lookup alias in this and if needed in parent
23330 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23334 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23335 making things static. I need this to avoid passing the
23336 TypeContainer when calling ParameterType.
23338 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23339 that did string manipulation to compute the type and then call
23340 GetType. Use Parameter.ParameterType instead.
23342 * cs-tokenizer.cs: Consume the suffix for floating values.
23344 * expression.cs (ParameterReference): figure out whether this is a
23345 reference parameter or not. Kill an extra variable by computing
23346 the arg_idx during emission.
23348 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23349 function that returns whether a parameter is an out/ref value or not.
23351 (Parameter.ParameterType): The type of the parameter (base,
23352 without ref/out applied).
23354 (Parameter.Resolve): Perform resolution here.
23355 (Parameter.ExternalType): The full type (with ref/out applied).
23357 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23358 support for expressions on the using statement.
23360 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23362 * statement.cs (Using.EmitLocalVariableDecls): Split the
23363 localvariable handling of the using statement.
23365 (Block.EmitMeta): Keep track of variable count across blocks. We
23366 were reusing slots on separate branches of blocks.
23368 (Try.Emit): Emit the general code block, we were not emitting it.
23370 Check the type of the declaration to be an IDisposable or
23371 something that can be implicity converted to it.
23373 Emit conversions if required.
23375 * ecore.cs (EmptyExpression): New utility class.
23376 (Expression.ImplicitConversionExists): New utility function.
23378 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23380 * statement.cs (Using): Implement.
23382 * expression.cs (LocalVariableReference): Support read only variables.
23384 * statement.cs: Remove the explicit emit for the Leave opcode.
23385 (VariableInfo): Add a readonly field.
23387 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23389 * ecore.cs (ConvCast): new class used to encapsulate the various
23390 explicit integer conversions that works in both checked and
23391 unchecked contexts.
23393 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23394 properly generate the overflow opcodes.
23396 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23398 * statement.cs: The correct type for the EmptyExpression is the
23399 element_type, not the variable type. Ravi pointed this out.
23401 2001-12-04 Ravi Pratap <ravi@ximian.com>
23403 * class.cs (Method::Define): Handle PInvoke methods specially
23404 by using DefinePInvokeMethod instead of the usual one.
23406 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23407 above to do the task of extracting information and defining the method.
23409 2001-12-04 Ravi Pratap <ravi@ximian.com>
23411 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23412 of the condition for string type.
23414 (Emit): Move that here.
23416 (ArrayCreation::CheckIndices): Keep string literals in their expression
23419 (EmitDynamicInitializers): Handle strings appropriately.
23421 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23423 * codegen.cs (EmitContext): Replace multiple variables with a
23424 single pointer to the current Switch statement.
23426 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23429 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23433 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23436 (Foreach.Emit): Foreach on arrays was not setting
23437 up the loop variables (for break/continue).
23439 (GotoCase): Semi-implented.
23441 2001-12-03 Ravi Pratap <ravi@ximian.com>
23443 * attribute.cs (CheckAttribute): Handle system attributes by using
23444 Attribute.GetAttributes to examine information we need.
23446 (GetValidPlaces): Same here.
23448 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23450 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23452 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23454 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23456 (Method::Emit): Handle the case when we are a PInvoke method.
23458 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23460 * expression.cs: Use ResolveWithSimpleName on compound names.
23462 2001-12-02 Ravi Pratap <ravi@ximian.com>
23464 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23465 before trying to reduce it.
23467 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23469 * constant.cs (LookupConstantValue): Implement.
23471 (EmitConstant): Use the above in emitting the constant.
23473 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23474 that are user-defined by doing a LookupConstantValue on them.
23476 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23479 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23481 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23483 (BaseAccess.DoResolve): Implement.
23485 (MemberAccess.DoResolve): Split this routine into a
23486 ResolveMemberAccess routine that can be used independently
23488 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23490 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23491 As that share bits of the implementation. Is returns a boolean,
23492 while As returns the Type that is being probed.
23494 2001-12-01 Ravi Pratap <ravi@ximian.com>
23496 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23497 instead of a Literal - much easier.
23499 (EnumInTransit): Remove - utterly useless :-)
23501 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23503 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23505 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23506 chain when we have no associated expression.
23508 2001-11-30 Ravi Pratap <ravi@ximian.com>
23510 * constant.cs (Define): Use Location while reporting the errror.
23512 Also emit a warning when 'new' is used and there is no inherited
23515 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23518 (LookupEnumValue): Implement to lookup an enum member's value and define it
23521 (Populate): Re-write accordingly to use the above routine.
23523 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23525 * expression.cs (This): Fix prototype for DoResolveLValue to
23526 override the base class DoResolveLValue.
23528 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23531 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23532 (we need to load the address of the field here). This fixes
23535 (FieldExpr.DoResolveLValue): Call the DoResolve
23536 function to initialize the Instance expression.
23538 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23539 correctly the GetEnumerator operation on a value type.
23541 * cs-parser.jay: Add more simple parsing error catches.
23543 * statement.cs (Switch): Add support for string switches.
23544 Handle null specially.
23546 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23548 2001-11-28 Ravi Pratap <ravi@ximian.com>
23550 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23552 (declare_local_constant): New helper function.
23554 * statement.cs (AddConstant): Keep a separate record of constants
23556 (IsConstant): Implement to determine if a variable is a constant.
23558 (GetConstantExpression): Implement.
23560 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23562 * statement.cs (IsVariableDefined): Re-write.
23564 2001-11-27 Ravi Pratap <ravi@ximian.com>
23566 * class.cs (TypeContainer::FindMembers): Look for constants
23567 in the case when we are looking for MemberTypes.Field
23569 * expression.cs (MemberAccess::DoResolve): Check that in the
23570 case we are a FieldExpr and a Literal, we are not being accessed
23571 by an instance reference.
23573 * cs-parser.jay (local_constant_declaration): Implement.
23575 (declaration_statement): Implement for constant declarations.
23577 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23579 * statement.cs (Switch): Catch double defaults.
23581 (Switch): More work on the switch() statement
23582 implementation. It works for integral values now, need to finish
23586 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23588 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23589 integer literals into other integer literals. To be used by
23592 2001-11-24 Ravi Pratap <ravi@ximian.com>
23594 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23597 (EmitDynamicInitializers): Cope with the above since we extract data
23598 directly from ArrayData now.
23600 (ExpectInitializers): Keep track of whether initializers are mandatory
23603 (Bounds): Make it a hashtable to prevent the same dimension being
23604 recorded for every element in that dimension.
23606 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23609 Also fix bug which was causing the indices to be emitted in the reverse
23612 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23614 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23615 unfinished. They do not work, because the underlying code is
23618 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23620 * cs-parser.jay: Remove bogus fixme.
23622 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23623 on Switch statement.
23625 2001-11-23 Ravi Pratap <ravi@ximian.com>
23627 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23630 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23631 parameter. Apparently, any expression is allowed.
23633 (ValidateInitializers): Update accordingly.
23635 (CheckIndices): Fix some tricky bugs thanks to recursion.
23637 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23638 I was being completely brain-dead.
23640 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23641 and re-write acordingly.
23643 (DelegateInvocation): Re-write accordingly.
23645 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23647 (MakeByteBlob): Handle types more correctly.
23649 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23650 initialization from expressions but it is incomplete because I am a complete
23653 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23655 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23656 on If. Basically, we have to return `true' (ie, we do return to
23657 our caller) only if both branches of the if return.
23659 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23660 short-circuit operators, handle them as short circuit operators.
23662 (Cast.DoResolve): Resolve type.
23663 (Cast.Cast): Take an expression as the target type.
23665 * cs-parser.jay (cast_expression): Remove old hack that only
23666 allowed a limited set of types to be handled. Now we take a
23667 unary_expression and we resolve to a type during semantic
23670 Use the grammar productions from Rhys to handle casts (this is
23671 not complete like Rhys syntax yet, we fail to handle that corner
23672 case that C# has regarding (-x), but we will get there.
23674 2001-11-22 Ravi Pratap <ravi@ximian.com>
23676 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23677 field which is an array type.
23679 * cs-parser.jay (declare_local_variables): Support array initialization too.
23681 * typemanager.cs (MakeKey): Implement.
23683 (everywhere): Use the above appropriately.
23685 * cs-parser.jay (for_statement): Update for array initialization while
23686 declaring variables.
23688 * ecore.cs : The error message was correct, it's the variable's names that
23689 were misleading ;-) Make the code more readable.
23691 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23692 the correct type etc.
23694 (ConvertExplicit): Handle Enum types by examining the underlying type.
23696 2001-11-21 Ravi Pratap <ravi@ximian.com>
23698 * parameter.cs (GetCallingConvention): Always return
23699 CallingConventions.Standard for now.
23701 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23703 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23704 and `r' after calling DoNumericPromotions.
23706 * ecore.cs: Fix error message (the types were in the wrong order).
23708 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23709 BindingFlags.Instance as well
23711 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23712 implicit int literal conversion in an empty cast so that we
23713 propagate the right type upstream.
23715 (UnboxCast): new class used to unbox value types.
23716 (Expression.ConvertExplicit): Add explicit type conversions done
23719 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23720 the target type before applying the implicit LongLiterals to ULong
23723 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23725 * cs-parser.jay (for_statement): Reworked the way For works: now
23726 we declare manually any variables that are introduced in
23727 for_initializer to solve the problem of having out-of-band code
23728 emition (that is what got for broken).
23730 (declaration_statement): Perform the actual variable declaration
23731 that used to be done in local_variable_declaration here.
23733 (local_variable_declaration): Do not declare anything, just pass
23734 the information on a DictionaryEntry
23736 2001-11-20 Ravi Pratap <ravi@ximian.com>
23738 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23739 re-write of the logic to now make it recursive.
23741 (UpdateIndices): Re-write accordingly.
23743 Store element data in a separate ArrayData list in the above methods.
23745 (MakeByteBlob): Implement to dump the array data into a byte array.
23747 2001-11-19 Ravi Pratap <ravi@ximian.com>
23749 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23752 * constant.cs (Define): Implement.
23754 (EmitConstant): Re-write fully.
23756 Pass in location info.
23758 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23761 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23762 DictionaryEntry since we need location info too.
23764 (constant_declaration): Update accordingly.
23766 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23767 code into another method : UpdateIndices.
23769 2001-11-18 Ravi Pratap <ravi@ximian.com>
23771 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23772 some type checking etc.
23774 2001-11-17 Ravi Pratap <ravi@ximian.com>
23776 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23777 bits to provide dimension info if the user skips doing that.
23779 Update second constructor to store the rank correctly.
23781 2001-11-16 Ravi Pratap <ravi@ximian.com>
23783 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23784 and try to implement.
23786 * ../errors/cs0150.cs : Add.
23788 * ../errors/cs0178.cs : Add.
23790 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23792 * statement.cs: Implement foreach on multi-dimensional arrays.
23794 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23795 name of the params argument.
23797 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23798 initializing the array.
23800 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23801 we can use this elsewhere.
23803 * statement.cs: Finish implementation of foreach for single
23806 * cs-parser.jay: Use an out-of-band stack to pass information
23807 around, I wonder why I need this.
23809 foreach_block: Make the new foreach_block the current_block.
23811 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23812 function used to return a static Parameters structure. Used for
23813 empty parameters, as those are created very frequently.
23815 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23817 2001-11-15 Ravi Pratap <ravi@ximian.com>
23819 * interface.cs : Default modifier is private, not public. The
23820 make verify test passes again.
23822 2001-11-15 Ravi Pratap <ravi@ximian.com>
23824 * support.cs (ReflectionParameters): Fix logic to determine
23825 whether the last parameter is a params one. Test 9 passes again.
23827 * delegate.cs (Populate): Register the builders we define with
23828 RegisterParameterForBuilder. Test 19 passes again.
23830 * cs-parser.jay (property_declaration): Reference $6 instead
23831 of $$ to get at the location.
23833 (indexer_declaration): Similar stuff.
23835 (attribute): Ditto.
23837 * class.cs (Property): Register parameters for the Get and Set methods
23838 if they exist. Test 23 passes again.
23840 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23841 call to EmitArguments as we are sure there aren't any params arguments.
23842 Test 32 passes again.
23844 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23845 IndexOutOfRangeException.
23847 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23848 Test 33 now passes again.
23850 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23852 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23853 broke a bunch of things. Will have to come up with a better way
23854 of tracking locations.
23856 * statement.cs: Implemented foreach for single dimension arrays.
23858 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23860 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23861 an error. This removes the lookup from the critical path.
23863 * cs-parser.jay: Removed use of temporary_loc, which is completely
23866 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23868 * support.cs (ReflectionParameters.ParameterModifier): Report
23869 whether the argument is a PARAMS argument or not.
23871 * class.cs: Set the attribute `ParamArrayAttribute' on the
23872 parameter argument.
23874 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23875 and cons_param_array_attribute (ConstructorInfo for
23876 ParamArrayAttribute).,
23878 * codegen.cs: Emit the return using the `Return' statement, that
23879 way we can report the error correctly for missing return values.
23881 * class.cs (Method.Emit): Clean up.
23883 * expression.cs (Argument.Resolve): Take another argument: the
23884 location where this argument is used. Notice that this is not
23885 part of the "Argument" class as to reduce the size of the
23886 structure (we know the approximate location anyways).
23888 Test if the argument is a variable-reference, if not, then
23889 complain with a 206.
23891 (Argument.Emit): Emit addresses of variables.
23893 (Argument.FullDesc): Simplify.
23895 (Invocation.DoResolve): Update for Argument.Resolve.
23897 (ElementAccess.DoResolve): ditto.
23899 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
23900 method should be virtual, as this method is always virtual.
23902 (NewDelegate.DoResolve): Update for Argument.Resolve.
23904 * class.cs (ConstructorInitializer.DoResolve): ditto.
23906 * attribute.cs (Attribute.Resolve): ditto.
23908 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23910 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
23912 * expression.cs (ParameterReference): Drop IStackStorage and implement
23913 IAssignMethod instead.
23915 (LocalVariableReference): ditto.
23917 * ecore.cs (FieldExpr): Drop IStackStorage and implement
23918 IAssignMethod instead.
23920 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23922 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
23923 enumerations that are used in heavily used structures derive from
23924 byte in a laughable and pathetic attempt to reduce memory usage.
23925 This is the kind of pre-optimzations that you should not do at
23926 home without adult supervision.
23928 * expression.cs (UnaryMutator): New class, used to handle ++ and
23929 -- separatedly from the other unary operators. Cleans up the
23930 code, and kills the ExpressionStatement dependency in Unary.
23932 (Unary): Removed `method' and `Arguments' from this class, making
23933 it smaller, and moving it all to SimpleCall, so I can reuse this
23934 code in other locations and avoid creating a lot of transient data
23935 strucutres when not required.
23937 * cs-parser.jay: Adjust for new changes.
23939 2001-11-11 Miguel de Icaza <miguel@ximian.com>
23941 * enum.cs (Enum.Populate): If there is a failure during
23944 * cs-parser.jay (opt_enum_base): we used to catch type errors
23945 here, but this is really incorrect. The type error should be
23946 catched during semantic analysis.
23948 2001-12-11 Ravi Pratap <ravi@ximian.com>
23950 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
23951 current_local_parameters as expected since I, in my stupidity, had forgotten
23954 * attribute.cs (GetValidPlaces): Fix stupid bug.
23956 * class.cs (Method::Emit): Perform check on applicability of attributes.
23958 (Constructor::Emit): Ditto.
23960 (Field::Emit): Ditto.
23962 (Field.Location): Store location information.
23964 (Property, Event, Indexer, Operator): Ditto.
23966 * cs-parser.jay (field_declaration): Pass in location for each field.
23968 * ../errors/cs0592.cs : Add.
23970 2001-11-12 Ravi Pratap <ravi@ximian.com>
23972 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
23974 (InitCoreTypes): Update accordingly.
23976 (RegisterAttrType, LookupAttr): Implement.
23978 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
23979 info about the same.
23981 (Resolve): Update to populate the above as necessary.
23983 (Error592): Helper.
23985 (GetValidPlaces): Helper to the above.
23987 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
23989 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
23991 2001-11-12 Ravi Pratap <ravi@ximian.com>
23993 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
23995 * ../errors/cs0617.cs : Add.
23997 2001-11-11 Ravi Pratap <ravi@ximian.com>
23999 * enum.cs (Emit): Rename to Populate to be more consistent with what
24000 we expect it to do and when exactly it is called.
24002 * class.cs, rootcontext.cs : Update accordingly.
24004 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
24005 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
24007 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
24009 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24010 of a fieldinfo using the above, when dealing with a FieldBuilder.
24012 2001-11-10 Ravi Pratap <ravi@ximian.com>
24014 * ../errors/cs0031.cs : Add.
24016 * ../errors/cs1008.cs : Add.
24018 * ../errrors/cs0543.cs : Add.
24020 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
24023 (FindMembers): Implement.
24025 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
24026 enums and delegates too.
24028 (enum_types): Rename to builder_to_enum.
24030 (delegate_types): Rename to builder_to_delegate.
24032 * delegate.cs (FindMembers): Implement.
24034 2001-11-09 Ravi Pratap <ravi@ximian.com>
24036 * typemanager.cs (IsEnumType): Implement.
24038 * enum.cs (Emit): Re-write parts to account for the underlying type
24039 better and perform checking etc.
24041 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
24042 of the underlying type.
24044 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24047 * enum.cs (error31): Helper to report error #31.
24049 * cs-parser.jay (enum_declaration): Store location of each member too.
24051 * enum.cs (member_to_location): New hashtable.
24053 (AddEnumMember): Update location hashtable.
24055 (Emit): Use the location of each member while reporting errors.
24057 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24059 * cs-parser.jay: A for_initializer if is a
24060 local_variable_declaration really ammount to have an implicit
24061 block with the variable declaration and no initializer for for.
24063 * statement.cs (For.Emit): Cope with null initializers.
24065 This fixes the infinite loop on for initializers.
24067 2001-11-08 Miguel de Icaza <miguel@ximian.com>
24069 * enum.cs: More cleanup.
24071 * ecore.cs: Remove dead code.
24073 * class.cs (Property.Emit): More simplification.
24074 (Event.Emit): ditto.
24076 Reworked to have less levels of indentation.
24078 2001-11-08 Ravi Pratap <ravi@ximian.com>
24080 * class.cs (Property): Emit attributes.
24090 * enum.cs (Emit): Ditto.
24092 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
24095 * class.cs (Field, Event, etc.): Move attribute generation into the
24096 Emit method everywhere.
24098 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
24099 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
24100 as we had no way of defining nested enums !
24102 * rootcontext.cs : Adjust code accordingly.
24104 * typemanager.cs (AddEnumType): To keep track of enum types separately.
24106 2001-11-07 Ravi Pratap <ravi@ximian.com>
24108 * expression.cs (EvalConstantExpression): Move into ecore.cs
24110 * enum.cs (Enum): Rename some members and make them public and readonly
24111 according to our convention.
24113 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24116 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
24118 (Enum::Emit): Write a simple version for now which doesn't try to compute
24119 expressions. I shall modify this to be more robust in just a while.
24121 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
24123 (TypeContainer::CloseType): Create the Enum types too.
24125 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
24127 * expression.cs (EvalConstantExpression): Get rid of completely.
24129 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
24130 user-defined values and other cases.
24132 (IsValidEnumLiteral): Helper function.
24134 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
24135 out there in the case we had a literal FieldExpr.
24137 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
24139 (Literalize): Revamp a bit to take two arguments.
24141 (EnumLiteral): New class which derives from Literal to wrap enum literals.
24143 2001-11-06 Ravi Pratap <ravi@ximian.com>
24145 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
24147 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
24149 (Resolve): Use the above to ensure we have proper initializers.
24151 2001-11-05 Ravi Pratap <ravi@ximian.com>
24153 * expression.cs (Expression::EvalConstantExpression): New method to
24154 evaluate constant expressions.
24156 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
24158 2001-11-07 Miguel de Icaza <miguel@ximian.com>
24160 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
24163 (Binary.ResolveOperator): Handle operator != (object a, object b)
24164 and operator == (object a, object b);
24166 (Binary.DoNumericPromotions): Indicate whether the numeric
24167 promotion was possible.
24169 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
24172 Made the ArrayAccess implement interface IAssignMethod instead of
24173 IStackStore as the order in which arguments are passed reflects
24176 * assign.cs: Instead of using expr.ExprClass to select the way of
24177 assinging, probe for the IStackStore/IAssignMethod interfaces.
24179 * typemanager.cs: Load InitializeArray definition.
24181 * rootcontext.cs (RootContext.MakeStaticData): Used to define
24182 static data that can be used to initialize arrays.
24184 2001-11-05 Miguel de Icaza <miguel@ximian.com>
24186 * expression.cs: Handle operator== and operator!= for booleans.
24188 (Conditioal.Reduce): Implement reducer for the ?: operator.
24190 (Conditional.Resolve): Implement dead code elimination.
24192 (Binary.Resolve): Catch string literals and return a new
24193 concatenated string.
24195 (Unary.Reduce): Implement reduction of unary expressions.
24197 * ecore.cs: Split out the expression core handling here.
24199 (Expression.Reduce): New method used to perform constant folding
24200 and CSE. This is needed to support constant-expressions.
24202 * statement.cs (Statement.EmitBoolExpression): Pass true and false
24203 targets, and optimize for !x.
24205 2001-11-04 Ravi Pratap <ravi@ximian.com>
24207 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
24208 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
24209 set custom atttributes.
24211 * literal.cs (Literal::GetValue): New abstract method to return the actual
24212 value of the literal, cast as an object.
24214 (*Literal): Implement GetValue method.
24216 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
24217 expressions to the arraylist but objects of type Argument.
24219 * class.cs (TypeContainer::Emit): Emit our attributes too.
24221 (Method::Emit, Constructor::Emit): Ditto.
24223 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
24224 to be ignoring earlier.
24226 2001-11-03 Ravi Pratap <ravi@ximian.com>
24228 * attribute.cs (AttributeSection::Define): Implement to do the business
24229 of constructing a CustomAttributeBuilder.
24231 (Attribute): New trivial class. Increases readability of code.
24233 * cs-parser.jay : Update accordingly.
24235 (positional_argument_list, named_argument_list, named_argument): New rules
24237 (attribute_arguments): Use the above so that we are more correct.
24239 2001-11-02 Ravi Pratap <ravi@ximian.com>
24241 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
24242 to perform all checks for a method with a params parameter.
24244 (Invocation::OverloadResolve): Update to use the above method and therefore
24245 cope correctly with params method invocations.
24247 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
24250 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
24251 constructors in our parent too because we can't afford to miss out on
24254 * attribute.cs (AttributeSection): New name for the class Attribute
24256 Other trivial changes to improve readability.
24258 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
24259 use the new class names.
24261 2001-11-01 Ravi Pratap <ravi@ximian.com>
24263 * class.cs (Method::Define): Complete definition for params types too
24265 (Indexer::Define): Ditto.
24267 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
24268 Cope everywhere with a request for info about the array parameter.
24270 2001-11-01 Ravi Pratap <ravi@ximian.com>
24272 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24274 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24275 local_variable_type to extract the string corresponding to the type.
24277 (local_variable_type): Fixup the action to use the new helper method.
24279 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24282 * expression.cs : Clean out code which uses the above.
24284 2001-10-31 Ravi Pratap <ravi@ximian.com>
24286 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24287 and bale out if necessary by returning a false.
24289 (RegisterProperty): Ditto.
24291 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24292 and print out appropriate error messages.
24294 * interface.cs (everywhere): Ditto.
24296 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24297 location to constructor.
24299 * class.cs (Property, Event, Indexer): Update accordingly.
24301 * ../errors/cs111.cs : Added.
24303 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24304 of a method, as laid down by the spec.
24306 (Invocation::OverloadResolve): Use the above method.
24308 2001-10-31 Ravi Pratap <ravi@ximian.com>
24310 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24311 now take a TypeContainer and a Parameters object.
24313 (ParameterData): Modify return type of ParameterModifier method to be
24314 Parameter.Modifier and not a string.
24316 (ReflectionParameters, InternalParameters): Update accordingly.
24318 * expression.cs (Argument::GetParameterModifier): Same here.
24320 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24321 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24322 symbol in it at all so maybe this is only for now.
24324 2001-10-30 Ravi Pratap <ravi@ximian.com>
24326 * support.cs (InternalParameters): Constructor now takes an extra argument
24327 which is the actual Parameters class.
24329 (ParameterDesc): Update to provide info on ref/out modifiers.
24331 * class.cs (everywhere): Update call to InternalParameters to pass in
24332 the second argument too.
24334 * support.cs (ParameterData): Add ParameterModifier, which is a method
24335 to return the modifier info [ref/out etc]
24337 (InternalParameters, ReflectionParameters): Implement the above.
24339 * expression.cs (Argument::ParameterModifier): Similar function to return
24340 info about the argument's modifiers.
24342 (Invocation::OverloadResolve): Update to take into account matching modifiers
24345 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24346 a new SetFormalParameters object which we pass to InternalParameters.
24348 2001-10-30 Ravi Pratap <ravi@ximian.com>
24350 * expression.cs (NewArray): Merge into the ArrayCreation class.
24352 2001-10-29 Ravi Pratap <ravi@ximian.com>
24354 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24355 NewUserdefinedArray into one as there wasn't much of a use in having
24358 * expression.cs (Argument): Change field's name to ArgType from Type.
24360 (Type): New readonly property which returns the proper type, taking into
24361 account ref/out modifiers.
24363 (everywhere): Adjust code accordingly for the above.
24365 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24366 whether we are emitting for a ref or out parameter.
24368 * expression.cs (Argument::Emit): Use the above field to set the state.
24370 (LocalVariableReference::Emit): Update to honour the flag and emit the
24373 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24375 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24377 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24379 (ReflectionParameters, InternalParameters): Implement the above method.
24381 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24384 (Invocation::FullMethodDesc): Ditto.
24386 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24388 * cs-parser.jay: Add extra production for the second form of array
24391 * expression.cs (ArrayCreation): Update to reflect the above
24394 * Small changes to prepare for Array initialization.
24396 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24398 * typemanager.cs (ImplementsInterface): interface might be null;
24399 Deal with this problem;
24401 Also, we do store negative hits on the cache (null values), so use
24402 this instead of calling t.GetInterfaces on the type everytime.
24404 2001-10-28 Ravi Pratap <ravi@ximian.com>
24406 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24408 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24409 split functionality out into different classes.
24411 (New::FormArrayType): Move into NewBuiltinArray.
24413 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24416 (NewBuiltinArray): New class to handle creation of built-in arrays.
24418 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24419 account creation of one-dimensional arrays.
24421 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24423 (NewUserdefinedArray::DoResolve): Implement.
24425 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24427 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24428 we maintain inside the TypeManager. This is necessary to perform lookups on the
24431 (LookupType): Update to perform GetType on the module builders too.
24433 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24435 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24437 2001-10-23 Ravi Pratap <ravi@ximian.com>
24439 * expression.cs (New::DoResolve): Implement guts of array creation.
24441 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24443 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24445 * expression.cs: Fix bug I introduced lsat night that broke
24448 (Expression.Resolve): Report a 246 error (can not resolve name)
24449 if we find a SimpleName in the stream.
24451 (Expression.ResolveLValue): Ditto.
24453 (Expression.ResolveWithSimpleName): This function is a variant of
24454 ResolveName, this one allows SimpleNames to be returned without a
24455 warning. The only consumer of SimpleNames is MemberAccess
24457 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24459 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24460 might arrive here. I have my doubts that this is correct.
24462 * statement.cs (Lock): Implement lock statement.
24464 * cs-parser.jay: Small fixes to support `lock' and `using'
24466 * cs-tokenizer.cs: Remove extra space
24468 * driver.cs: New flag --checked, allows to turn on integer math
24471 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24472 Threading.Monitor.Exit
24474 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24476 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24477 Expression Class to be IndexerAccess.
24479 Notice that Indexer::DoResolve sets the eclass to Value.
24481 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24483 * class.cs (TypeContainer::Emit): Emit code for indexers.
24485 * assign.cs (IAssignMethod): New interface implemented by Indexers
24486 and Properties for handling assignment.
24488 (Assign::Emit): Simplify and reuse code.
24490 * expression.cs (IndexerAccess, PropertyExpr): Implement
24491 IAssignMethod, clean up old code.
24493 2001-10-22 Ravi Pratap <ravi@ximian.com>
24495 * typemanager.cs (ImplementsInterface): New method to determine if a type
24496 implements a given interface. Provides a nice cache too.
24498 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24501 (ConvertReferenceExplicit): Ditto.
24503 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24504 various methods, with correct names etc.
24506 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24507 Operator.UnaryNegation.
24509 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24510 we have a unary plus or minus operator.
24512 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24515 * everywhere : update accordingly.
24517 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24520 * class.cs (Method::Define): For the case where we are implementing a method
24521 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24522 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24524 2001-10-21 Ravi Pratap <ravi@ximian.com>
24526 * interface.cs (FindMembers): Implement to work around S.R.E
24529 * typemanager.cs (IsInterfaceType): Implement.
24531 (FindMembers): Update to handle interface types too.
24533 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24534 use IsAssignableFrom as that is not correct - it doesn't work.
24536 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24537 and accordingly override EmitStatement.
24539 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24540 using the correct logic :-)
24542 2001-10-19 Ravi Pratap <ravi@ximian.com>
24544 * ../errors/cs-11.cs : Add to demonstrate error -11
24546 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24548 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24549 then pass this as a hint to ResolveLValue.
24551 * expression.cs (FieldExpr): Add Location information
24553 (FieldExpr::LValueResolve): Report assignment to readonly
24556 (Expression::ExprClassFromMemberInfo): Pass location information.
24558 (Expression::ResolveLValue): Add new method that resolves an
24561 (Expression::DoResolveLValue): Default invocation calls
24564 (Indexers): New class used to keep track of indexers in a given
24567 (IStackStore): Renamed from LValue, as it did not really describe
24568 what this did. Also ResolveLValue is gone from this interface and
24569 now is part of Expression.
24571 (ElementAccess): Depending on the element access type
24573 * typemanager.cs: Add `indexer_name_type' as a Core type
24574 (System.Runtime.CompilerServices.IndexerNameAttribute)
24576 * statement.cs (Goto): Take a location.
24578 2001-10-18 Ravi Pratap <ravi@ximian.com>
24580 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24581 if two delegates are compatible.
24583 (NewDelegate::DoResolve): Update to take care of the case when
24584 we instantiate a delegate from another delegate.
24586 * typemanager.cs (FindMembers): Don't even try to look up members
24587 of Delegate types for now.
24589 2001-10-18 Ravi Pratap <ravi@ximian.com>
24591 * delegate.cs (NewDelegate): New class to take care of delegate
24594 * expression.cs (New): Split the delegate related code out into
24595 the NewDelegate class.
24597 * delegate.cs (DelegateInvocation): New class to handle delegate
24600 * expression.cs (Invocation): Split out delegate related code into
24601 the DelegateInvocation class.
24603 2001-10-17 Ravi Pratap <ravi@ximian.com>
24605 * expression.cs (New::DoResolve): Implement delegate creation fully
24606 and according to the spec.
24608 (New::DoEmit): Update to handle delegates differently.
24610 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24611 because of which we were printing out arguments in reverse order !
24613 * delegate.cs (VerifyMethod): Implement to check if the given method
24614 matches the delegate.
24616 (FullDelegateDesc): Implement.
24618 (VerifyApplicability): Implement.
24620 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24621 delegate invocations too.
24623 (Invocation::Emit): Ditto.
24625 * ../errors/cs1593.cs : Added.
24627 * ../errors/cs1594.cs : Added.
24629 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24631 2001-10-16 Ravi Pratap <ravi@ximian.com>
24633 * typemanager.cs (intptr_type): Core type for System.IntPtr
24635 (InitCoreTypes): Update for the same.
24637 (iasyncresult_type, asynccallback_type): Ditto.
24639 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24642 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24645 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24646 the builders for the 4 members of a delegate type :-)
24648 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24651 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24653 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24655 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24657 * statement.cs (Break::Emit): Implement.
24658 (Continue::Emit): Implement.
24660 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24661 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24662 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24663 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24666 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24667 properties that track the label for the current loop (begin of the
24668 loop and end of the loop).
24670 2001-10-15 Ravi Pratap <ravi@ximian.com>
24672 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24673 use of emitting anything at all.
24675 * class.cs, rootcontext.cs : Get rid of calls to the same.
24677 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24679 (Populate): Define the constructor correctly and set the implementation
24682 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24685 (AddDelegateType): Implement.
24687 (IsDelegateType): Implement helper method.
24689 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24691 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24692 and accordingly handle it.
24694 * delegate.cs (Populate): Take TypeContainer argument.
24695 Implement bits to define the Invoke method. However, I still haven't figured out
24696 how to take care of the native int bit :-(
24698 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24699 Qualify the name of the delegate, not its return type !
24701 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24704 (StandardConversionExists): Checking for array types turns out to be recursive.
24706 (ConvertReferenceExplicit): Implement array conversion.
24708 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24710 2001-10-12 Ravi Pratap <ravi@ximian.com>
24712 * cs-parser.jay (delegate_declaration): Store the fully qualified
24713 name as it is a type declaration.
24715 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24718 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24719 as TypeContainer::DefineType.
24721 (Populate): Method in which all the definition of the various methods (Invoke)
24724 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24727 (CloseDelegate): Finally creates the delegate.
24729 * class.cs (TypeContainer::DefineType): Update to define delegates.
24730 (Populate, Emit and CloseType): Do the same thing here too.
24732 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24733 delegates in all these operations.
24735 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24737 * expression.cs: LocalTemporary: a new expression used to
24738 reference a temporary that has been created.
24740 * assign.cs: Handle PropertyAccess back here, so that we can
24741 provide the proper semantic access to properties.
24743 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24744 a few more explicit conversions.
24746 * modifiers.cs: `NEW' modifier maps to HideBySig.
24748 * expression.cs (PropertyExpr): Make this into an
24749 ExpressionStatement, and support the EmitStatement code path.
24751 Perform get/set error checking, clean up the interface.
24753 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24754 them into toplevel access objects.
24756 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24758 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24761 * typemanager.cs: Keep track here of our PropertyBuilders again to
24762 work around lameness in SRE.
24764 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24766 * expression.cs (LValue::LValueResolve): New method in the
24767 interface, used to perform a second resolution pass for LValues.
24769 (This::DoResolve): Catch the use of this in static methods.
24771 (This::LValueResolve): Implement.
24773 (This::Store): Remove warning, assigning to `this' in structures
24776 (Invocation::Emit): Deal with invocation of
24777 methods on value types. We need to pass the address to structure
24778 methods rather than the object itself. (The equivalent code to
24779 emit "this" for structures leaves the entire structure on the
24780 stack instead of a pointer to it).
24782 (ParameterReference::DoResolve): Compute the real index for the
24783 argument based on whether the method takes or not a `this' pointer
24784 (ie, the method is static).
24786 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24787 value types returned from functions when we need to invoke a
24788 method on the sturcture.
24791 2001-10-11 Ravi Pratap <ravi@ximian.com>
24793 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24794 defining the type in the Modulebuilder or Typebuilder. This is to take
24795 care of nested types which need to be defined on the TypeBuilder using
24796 DefineNestedMethod.
24798 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24799 methods in RootContext, only ported to be part of TypeContainer.
24801 (TypeContainer::GetInterfaceOrClass): Ditto.
24803 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24805 * interface.cs (Interface::DefineInterface): New method. Does exactly
24806 what RootContext.CreateInterface did earlier, only it takes care of nested types
24809 (Interface::GetInterfaces): Move from RootContext here and port.
24811 (Interface::GetInterfaceByName): Same here.
24813 * rootcontext.cs (ResolveTree): Re-write.
24815 (PopulateTypes): Re-write.
24817 * class.cs (TypeContainer::Populate): Populate nested types too.
24818 (TypeContainer::Emit): Emit nested members too.
24820 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24821 instead just use the name argument passed in as it is already fully
24824 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24825 to TypeContainer mapping to see if a type is user-defined.
24827 * class.cs (TypeContainer::CloseType): Implement.
24829 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24830 the default constructor.
24832 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24835 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24837 * interface.cs (CloseType): Create the type here.
24839 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24842 Remove all the methods which are now in TypeContainer.
24844 2001-10-10 Ravi Pratap <ravi@ximian.com>
24846 * delegate.cs (Define): Re-write bits to define the delegate
24849 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24851 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24853 * expression.cs (ImplicitReferenceConversion): handle null as well
24854 as a source to convert to any reference type.
24856 * statement.cs (Return): Perform any implicit conversions to
24857 expected return type.
24859 Validate use of return statement.
24861 * codegen.cs (EmitContext): Pass the expected return type here.
24863 * class.cs (Method, Constructor, Property): Pass expected return
24864 type to EmitContext.
24866 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24868 * expression.cs: Make DoResolve take an EmitContext instead of a
24871 Replaced `l' and `location' for `loc', for consistency.
24873 (Error, Warning): Remove unneeded Tc argument.
24875 * assign.cs, literal.cs, constant.cs: Update to new calling
24878 * codegen.cs: EmitContext now contains a flag indicating whether
24879 code is being generated in a static method or not.
24881 * cs-parser.jay: DecomposeQI, new function that replaces the old
24882 QualifiedIdentifier. Now we always decompose the assembled
24883 strings from qualified_identifier productions into a group of
24886 2001-10-08 Miguel de Icaza <miguel@ximian.com>
24888 * rootcontext.cs: Deal with field-less struct types correctly now
24889 by passing the size option to Define Type.
24891 * class.cs: Removed hack that created one static field.
24893 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24895 * statement.cs: Moved most of the code generation here.
24897 2001-10-09 Ravi Pratap <ravi@ximian.com>
24899 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
24902 (ElementAccess): Remove useless bits for now - keep checks as the spec
24905 2001-10-08 Ravi Pratap <ravi@ximian.com>
24907 * expression.cs (ElementAccess::DoResolve): Remove my crap code
24908 and start performing checks according to the spec.
24910 2001-10-07 Ravi Pratap <ravi@ximian.com>
24912 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
24913 rank_specifiers instead.
24915 (rank_specifiers): Change the order in which the rank specifiers are stored
24917 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
24919 * expression.cs (ElementAccess): Implement the LValue interface too.
24921 2001-10-06 Ravi Pratap <ravi@ximian.com>
24923 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
24924 except that user defined conversions are not included.
24926 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
24927 perform the conversion of the return type, if necessary.
24929 (New::DoResolve): Check whether we are creating an array or an object
24930 and accordingly do the needful.
24932 (New::Emit): Same here.
24934 (New::DoResolve): Implement guts of array creation.
24936 (New::FormLookupType): Helper function.
24938 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24940 * codegen.cs: Removed most of the code generation here, and move the
24941 corresponding code generation bits to the statement classes.
24943 Added support for try/catch/finalize and throw.
24945 * cs-parser.jay: Added support for try/catch/finalize.
24947 * class.cs: Catch static methods having the flags override,
24948 virtual or abstract.
24950 * expression.cs (UserCast): This user cast was not really doing
24951 what it was supposed to do. Which is to be born in fully resolved
24952 state. Parts of the resolution were being performed at Emit time!
24956 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24958 * expression.cs: Implicity convert the result from UserCast.
24960 2001-10-05 Ravi Pratap <ravi@ximian.com>
24962 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
24963 prevented it from working correctly.
24965 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
24966 merely ConvertImplicit.
24968 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24970 * typemanager.cs: Make the LookupTypeContainer function static,
24971 and not per-instance.
24973 * class.cs: Make static FindMembers (the one that takes a Type
24976 * codegen.cs: Add EmitForeach here.
24978 * cs-parser.jay: Make foreach a toplevel object instead of the
24979 inline expansion, as we need to perform semantic analysis on it.
24981 2001-10-05 Ravi Pratap <ravi@ximian.com>
24983 * expression.cs (Expression::ImplicitUserConversion): Rename to
24984 UserDefinedConversion.
24986 (Expression::UserDefinedConversion): Take an extra argument specifying
24987 whether we look for explicit user conversions too.
24989 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
24991 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
24993 (ExplicitUserConversion): Make it a call to UserDefinedConversion
24994 with the appropriate arguments.
24996 * cs-parser.jay (cast_expression): Record location too.
24998 * expression.cs (Cast): Record location info.
25000 (Expression::ConvertExplicit): Take location argument.
25002 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
25003 to determine if we are doing explicit conversions.
25005 (UserCast::Emit): Update accordingly.
25007 (Expression::ConvertExplicit): Report an error if everything fails.
25009 * ../errors/cs0030.cs : Add.
25011 2001-10-04 Miguel de Icaza <miguel@ximian.com>
25013 * modifiers.cs: If the ABSTRACT keyword is present, also set the
25014 virtual and newslot bits.
25016 * class.cs (TypeContainer::RegisterRequiredImplementations):
25017 Record methods we need.
25019 (TypeContainer::MakeKey): Helper function to make keys for
25020 MethodBases, since the Methodbase key is useless.
25022 (TypeContainer::Populate): Call RegisterRequiredImplementations
25023 before defining the methods.
25025 Create a mapping for method_builders_to_methods ahead of time
25026 instead of inside a tight loop.
25028 (::RequireMethods): Accept an object as the data to set into the
25029 hashtable so we can report interface vs abstract method mismatch.
25031 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25033 * report.cs: Make all of it static.
25035 * rootcontext.cs: Drop object_type and value_type computations, as
25036 we have those in the TypeManager anyways.
25038 Drop report instance variable too, now it is a global.
25040 * driver.cs: Use try/catch on command line handling.
25042 Add --probe option to debug the error reporting system with a test
25045 * report.cs: Add support for exiting program when a probe
25046 condition is reached.
25048 2001-10-03 Ravi Pratap <ravi@ximian.com>
25050 * expression.cs (Binary::DoNumericPromotions): Fix the case when
25051 we do a forcible conversion regardless of type, to check if
25052 ForceConversion returns a null.
25054 (Binary::error19): Use location to report error.
25056 (Unary::error23): Use location here too.
25058 * ../errors/cs0019.cs : Check in.
25060 * ../errors/cs0023.cs : Check in.
25062 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
25063 case of a non-null MethodInfo object with a length of 0 !
25065 (Binary::ResolveOperator): Flag error if overload resolution fails to find
25066 an applicable member - according to the spec :-)
25067 Also fix logic to find members in base types.
25069 (Unary::ResolveOperator): Same here.
25071 (Unary::report23): Change name to error23 and make first argument a TypeContainer
25072 as I was getting thoroughly confused between this and error19 :-)
25074 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
25075 (::FindMostEncompassedType): Implement.
25076 (::FindMostEncompassingType): Implement.
25077 (::StandardConversionExists): Implement.
25079 (UserImplicitCast): Re-vamp. We now need info about most specific
25080 source and target types so that we can do the necessary conversions.
25082 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
25083 mathematical union with no duplicates.
25085 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25087 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
25088 in order from base classes to child classes, so that we can in
25089 child classes look up in our parent for method names and
25090 attributes (required for handling abstract, virtual, new, override
25091 constructs: we need to instrospect our base class, and if we dont
25092 populate the classes in order, the introspection might be
25093 incorrect. For example, a method could query its parent before
25094 the parent has any methods and would determine that the parent has
25095 no abstract methods (while it could have had them)).
25097 (RootContext::CreateType): Record the order in which we define the
25100 2001-10-02 Miguel de Icaza <miguel@ximian.com>
25102 * class.cs (TypeContainer::Populate): Also method definitions can
25103 fail now, keep track of this.
25105 (TypeContainer::FindMembers): Implement support for
25106 DeclaredOnly/noDeclaredOnly flag.
25108 (Constructor::Emit) Return the ConstructorBuilder.
25110 (Method::Emit) Return the MethodBuilder.
25111 Check for abstract or virtual methods to be public.
25113 * rootcontext.cs (RootContext::CreateType): Register all the
25114 abstract methods required for the class to be complete and the
25115 interface methods that must be implemented.
25117 * cs-parser.jay: Report error 501 (method requires body if it is
25118 not marked abstract or extern).
25120 * expression.cs (TypeOf::Emit): Implement.
25122 * typemanager.cs: runtime_handle_type, new global type.
25124 * class.cs (Property::Emit): Generate code for properties.
25126 2001-10-02 Ravi Pratap <ravi@ximian.com>
25128 * expression.cs (Unary::ResolveOperator): Find operators on base type
25129 too - we now conform exactly to the spec.
25131 (Binary::ResolveOperator): Same here.
25133 * class.cs (Operator::Define): Fix minor quirk in the tests.
25135 * ../errors/cs0215.cs : Added.
25137 * ../errors/cs0556.cs : Added.
25139 * ../errors/cs0555.cs : Added.
25141 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25143 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
25144 single integer which is really efficient
25146 2001-10-01 Ravi Pratap <ravi@ximian.com>
25148 * expression.cs (Expression::ImplicitUserConversion): Use location
25149 even in the case when we are examining True operators.
25151 * class.cs (Operator::Define): Perform extensive checks to conform
25152 with the rules for operator overloading in the spec.
25154 * expression.cs (Expression::ImplicitReferenceConversion): Implement
25155 some of the other conversions mentioned in the spec.
25157 * typemanager.cs (array_type): New static member for the System.Array built-in
25160 (cloneable_interface): For System.ICloneable interface.
25162 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
25163 we start resolving the tree and populating types.
25165 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
25167 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25169 * expression.cs (Expression::ExprClassFromMemberInfo,
25170 Expression::Literalize): Create literal expressions from
25171 FieldInfos which are literals.
25173 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
25174 type casts, because they were wrong. The test suite in tests
25177 (ImplicitNumericConversion): ushort to ulong requires a widening
25180 Int32 constant to long requires widening cast as well.
25182 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
25183 for integers because the type on the stack is not i4.
25185 2001-09-30 Miguel de Icaza <miguel@ximian.com>
25187 * expression.cs (report118): require location argument.
25189 * parameter.cs: Do not dereference potential null value.
25191 * class.cs: Catch methods that lack the `new' keyword when
25192 overriding a name. Report warnings when `new' is used without
25193 anything being there to override.
25195 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
25197 * class.cs: Only add constructor to hashtable if it is non-null
25198 (as now constructors can fail on define).
25200 (TypeManager, Class, Struct): Take location arguments.
25202 Catch field instance initialization in structs as errors.
25204 accepting_filter: a new filter for FindMembers that is static so
25205 that we dont create an instance per invocation.
25207 (Constructor::Define): Catch errors where a struct constructor is
25210 * cs-parser.jay: Pass location information for various new
25213 * delegate.cs (Delegate): take a location argument.
25215 * driver.cs: Do not call EmitCode if there were problesm in the
25216 Definition of the types, as many Builders wont be there.
25218 * decl.cs (Decl::Decl): Require a location argument.
25220 * cs-tokenizer.cs: Handle properly hex constants that can not fit
25221 into integers, and find the most appropiate integer for it.
25223 * literal.cs: Implement ULongLiteral.
25225 * rootcontext.cs: Provide better information about the location of
25226 failure when CreateType fails.
25228 2001-09-29 Miguel de Icaza <miguel@ximian.com>
25230 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
25233 * expression.cs (Binary::CheckShiftArguments): Add missing type
25235 (Binary::ResolveOperator): Add type to the logical and and logical
25236 or, Bitwise And/Or and Exclusive Or code paths, it was missing
25239 (Binary::DoNumericPromotions): In the case where either argument
25240 is ulong (and most signed types combined with ulong cause an
25241 error) perform implicit integer constant conversions as well.
25243 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25245 * expression.cs (UserImplicitCast): Method should always be
25247 (Invocation::BetterConversion): Simplified test for IntLiteral.
25249 (Expression::ImplicitNumericConversion): Split this routine out.
25250 Put the code that performs implicit constant integer conversions
25253 (Expression::Resolve): Become a wrapper around DoResolve so we can
25254 check eclass and type being set after resolve.
25256 (Invocation::Badness): Remove this dead function
25258 (Binary::ResolveOperator): Do not compute the expensive argumnets
25259 unless we have a union for it.
25261 (Probe::Emit): Is needs to do an isinst and then
25262 compare against null.
25264 (::CanConvert): Added Location argument. If the Location argument
25265 is null (Location.Null), then we do not report errors. This is
25266 used by the `probe' mechanism of the Explicit conversion. We do
25267 not want to generate an error for something that the user
25268 explicitly requested to be casted. But the pipeline for an
25269 explicit cast first tests for potential implicit casts.
25271 So for now, if the Location is null, it means `Probe only' to
25272 avoid adding another argument. Might have to revise this
25275 (ClassCast): New class used to type cast objects into arbitrary
25276 classes (used in Explicit Reference Conversions).
25278 Implement `as' as well.
25280 Reverted all the patches from Ravi below: they were broken:
25282 * The use of `level' as a mechanism to stop recursive
25283 invocations is wrong. That was there just to catch the
25284 bug with a strack trace but not as a way of addressing
25287 To fix the problem we have to *understand* what is going
25288 on and the interactions and come up with a plan, not
25289 just get things going.
25291 * The use of the type conversion cache that I proposed
25292 last night had an open topic: How does this work across
25293 protection domains. A user defined conversion might not
25294 be public in the location where we are applying the
25295 conversion, a different conversion might be selected
25296 (ie, private A->B (better) but public B->A (worse),
25297 inside A, A->B applies, but outside it, B->A will
25300 * On top of that (ie, even if the above is solved),
25301 conversions in a cache need to be abstract. Ie, `To
25302 convert from an Int to a Short use an OpcodeCast', not
25303 `To convert from an Int to a Short use the OpcodeCast on
25304 the variable 5' (which is what this patch was doing).
25306 2001-09-28 Ravi Pratap <ravi@ximian.com>
25308 * expression.cs (Invocation::ConversionExists): Re-write to use
25309 the conversion cache
25311 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25312 cache all conversions done, not just user-defined ones.
25314 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25315 to determine if a conversion exists instead of acutually trying to
25316 perform the conversion. It's faster too.
25318 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25319 and only then attempt the implicit conversion.
25321 2001-09-28 Ravi Pratap <ravi@ximian.com>
25323 * expression.cs (ConvertImplicit): Use a cache for conversions
25324 already found. Check level of recursion and bail out if necessary.
25326 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25328 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25329 Export standard methods that we expect for string operations.
25331 * statement.cs (Block::UsageWarning): Track usage of variables and
25332 report the errors for not used variables.
25334 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25337 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25339 * codegen.cs: remove unnneded code
25341 * expression.cs: Removed BuiltinTypeAccess class
25343 Fix the order in which implicit conversions are
25346 The previous fixed dropped support for boxed conversions (adding a
25347 test to the test suite now)
25349 (UserImplicitCast::CanConvert): Remove test for source being null,
25350 that code is broken. We should not feed a null to begin with, if
25351 we do, then we should track the bug where the problem originates
25352 and not try to cover it up here.
25354 Return a resolved expression of type UserImplicitCast on success
25355 rather than true/false. Ravi: this is what I was talking about,
25356 the pattern is to use a static method as a "constructor" for
25359 Also, do not create arguments until the very last minute,
25360 otherwise we always create the arguments even for lookups that
25361 will never be performed.
25363 (UserImplicitCast::Resolve): Eliminate, objects of type
25364 UserImplicitCast are born in a fully resolved state.
25366 * typemanager.cs (InitCoreTypes): Init also value_type
25367 (System.ValueType).
25369 * expression.cs (Cast::Resolve): First resolve the child expression.
25371 (LValue): Add new method AddressOf to be used by
25374 Change the argument of Store to take an EmitContext instead of an
25375 ILGenerator, because things like FieldExpr need to be able to call
25376 their children expression to generate the instance code.
25378 (Expression::Error, Expression::Warning): Sugar functions for
25381 (Expression::MemberLookup): Accept a TypeContainer instead of a
25382 Report as the first argument.
25384 (Expression::ResolvePrimary): Killed. I still want to improve
25385 this as currently the code is just not right.
25387 (Expression::ResolveMemberAccess): Simplify, but it is still
25390 (Unary::Resolve): Catch errors in AddressOf operators.
25392 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25393 index to a byte for the short-version, or the compiler will choose
25394 the wrong Emit call, which generates the wrong data.
25396 (ParameterReference::Emit, ::Store): same.
25398 (FieldExpr::AddressOf): Implement.
25400 * typemanager.cs: TypeManager: made public variable instead of
25403 * driver.cs: document --fatal.
25405 * report.cs (ErrorMessage, WarningMessage): new names for the old
25406 Error and Warning classes.
25408 * cs-parser.jay (member_access): Turn built-in access to types
25409 into a normal simplename
25411 2001-09-27 Ravi Pratap <ravi@ximian.com>
25413 * expression.cs (Invocation::BetterConversion): Fix to cope
25414 with q being null, since this was introducing a bug.
25416 * expression.cs (ConvertImplicit): Do built-in conversions first.
25418 2001-09-27 Ravi Pratap <ravi@ximian.com>
25420 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25422 2001-09-27 Ravi Pratap <ravi@ximian.com>
25424 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25425 I had introduced long ago (what's new ?).
25427 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25428 the work of all the checking.
25429 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25430 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25432 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25433 that is the right way.
25435 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25436 overloading resolution. Use everywhere instead of cutting and pasting code.
25438 (Binary::ResolveOperator): Use MakeUnionSet.
25440 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25441 we have to convert to bool types. Not complete yet.
25443 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25445 * typemanager.cs (TypeManager::CSharpName): support ushort.
25447 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25448 to provide an expression that performsn an implicit constant int
25449 conversion (section 6.1.6).
25450 (Expression::ConvertImplicitRequired): Reworked to include
25451 implicit constant expression conversions.
25453 (Expression::ConvertNumericExplicit): Finished.
25455 (Invocation::Emit): If InstanceExpression is null, then it means
25456 that we perform a call on this.
25458 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25460 * expression.cs (Unary::Emit): Remove some dead code.
25461 (Probe): Implement Resolve and Emit for `is'.
25462 (Expression::ConvertImplicitRequired): Attempt to do constant
25463 expression conversions here. Maybe should be moved to
25464 ConvertImplicit, but I am not sure.
25465 (Expression::ImplicitLongConstantConversionPossible,
25466 Expression::ImplicitIntConstantConversionPossible): New functions
25467 that tell whether is it possible to apply an implicit constant
25468 expression conversion.
25470 (ConvertNumericExplicit): Started work on explicit numeric
25473 * cs-parser.jay: Update operator constants.
25475 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25476 (Parameters::GetSignature): Hook up VerifyArgs here.
25477 (Parameters::VerifyArgs): Verifies that no two arguments have the
25480 * class.cs (Operator): Update the operator names to reflect the
25481 ones that the spec expects (as we are just stringizing the
25484 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25485 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25486 previous usage did only work for our methods.
25487 (Expression::ConvertImplicit): Handle decimal implicit numeric
25488 conversions as well.
25489 (Expression::InternalTypeConstructor): Used to invoke constructors
25490 on internal types for default promotions.
25492 (Unary::Emit): Implement special handling for the pre/post
25493 increment/decrement for overloaded operators, as they need to have
25494 the same semantics as the other operators.
25496 (Binary::ResolveOperator): ditto.
25497 (Invocation::ConversionExists): ditto.
25498 (UserImplicitCast::Resolve): ditto.
25500 2001-09-26 Ravi Pratap <ravi@ximian.com>
25502 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25503 operator, return after emitting body. Regression tests pass again !
25505 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25506 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25507 (Invocation::OverloadResolve): Ditto.
25508 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25510 * everywhere : update calls to the above methods accordingly.
25512 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25514 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25516 * expression.cs (ExpressionStatement): New base class used for
25517 expressions that can appear in statements, so that we can provide
25518 an alternate path to generate expression that do not leave a value
25521 (Expression::Emit, and all the derivatives): We no longer return
25522 whether a value is left on the stack or not. Every expression
25523 after being emitted leaves a single value on the stack.
25525 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25526 facilties of ExpressionStatement if possible.
25528 * cs-parser.jay: Update statement_expression.
25530 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25532 * driver.cs: Change the wording of message
25534 2001-09-25 Ravi Pratap <ravi@ximian.com>
25536 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25537 the type of the expression to the return type of the method if
25538 we have an overloaded operator match ! The regression tests pass again !
25539 (Unary::ResolveOperator): Ditto.
25541 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25542 to find "op_Implicit", not "implicit" ;-)
25543 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25544 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25546 * everywhere : Correct calls to the above accordingly.
25548 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25549 (ConvertImplicit): Do user-defined conversion if it exists.
25551 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25553 * assign.cs: track location.
25554 (Resolve): Use implicit conversions on assignment.
25556 * literal.cs: Oops. Not good, Emit of short access values should
25557 pass (Bytes) or the wrong argument will be selected.
25559 * expression.cs (Unary::Emit): Emit code for -expr.
25561 (Unary::ResolveOperator): Handle `Substract' for non-constants
25562 (substract from zero from the non-constants).
25563 Deal with Doubles as well.
25565 (Expression::ConvertImplicitRequired): New routine that reports an
25566 error if no implicit conversion exists.
25568 (Invocation::OverloadResolve): Store the converted implicit
25569 expressions if we make them
25571 2001-09-24 Ravi Pratap <ravi@ximian.com>
25573 * class.cs (ConstructorInitializer): Take a Location argument.
25574 (ConstructorBaseInitializer): Same here.
25575 (ConstructorThisInitializer): Same here.
25577 * cs-parser.jay : Update all calls accordingly.
25579 * expression.cs (Unary, Binary, New): Take location argument.
25580 Update accordingly everywhere.
25582 * cs-parser.jay : Update all calls to the above to take a location
25585 * class.cs : Ditto.
25587 2001-09-24 Ravi Pratap <ravi@ximian.com>
25589 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25590 (Invocation::BetterConversion): Same here
25591 (Invocation::ConversionExists): Ditto.
25593 (Invocation::ConversionExists): Implement.
25595 2001-09-22 Ravi Pratap <ravi@ximian.com>
25597 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25598 Also take an additional TypeContainer argument.
25600 * All over : Pass in TypeContainer as argument to OverloadResolve.
25602 * typemanager.cs (CSharpName): Update to check for the string type and return
25605 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25608 2001-09-21 Ravi Pratap <ravi@ximian.com>
25610 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25611 (Invocation::BetterFunction): Implement.
25612 (Invocation::BetterConversion): Implement.
25613 (Invocation::ConversionExists): Skeleton, no implementation yet.
25615 Okay, things work fine !
25617 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25619 * typemanager.cs: declare and load enum_type, delegate_type and
25622 * expression.cs (Expression::Emit): Now emit returns a value that
25623 tells whether a value is left on the stack or not. This strategy
25624 might be reveted tomorrow with a mechanism that would address
25625 multiple assignments.
25626 (Expression::report118): Utility routine to report mismatches on
25629 (Unary::Report23): Report impossible type/operator combination
25632 (Unary::IsIncrementableNumber): Whether the type can be
25633 incremented or decremented with add.
25634 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25636 (Unary::ResolveOperator): Implement ++, !, ~,
25638 (Invocation::Emit): Deal with new Emit convetion.
25640 * All Expression derivatives: Updated their Emit method to return
25641 whether they leave values on the stack or not.
25643 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25644 stack for expressions that are statements.
25646 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25648 * expression.cs (LValue): New interface. Must be implemented by
25650 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25653 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25654 interface for generating code, simplifies the code.
25656 2001-09-20 Ravi Pratap <ravi@ximian.com>
25658 * expression.cs (everywhere): Comment out return statements in ::Resolve
25659 methods to avoid the warnings.
25661 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25663 * driver.cs (parse): Report error 2001 if we can not open the
25666 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25669 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25672 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25673 otherwise nested blocks end up with the same index.
25675 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25677 * expression.cs: Instead of having FIXMEs in the Resolve
25678 functions, throw exceptions so it is obvious that we are facing a
25681 * cs-parser.jay (invocation_expression): Pass Location information.
25683 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25684 Use a basename for those routines because .NET does not like paths
25687 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25690 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25692 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25693 are loading the correct data types (throws an exception if not).
25694 (TypeManager::InitCoreTypes): Use CoreLookupType
25696 * expression.cs (Unary::ResolveOperator): return the child
25697 expression for expressions which are just +expr.
25698 (Unary::ResolveOperator): Return negative literals for -LITERAL
25699 expressions (otherwise they are Unary {Literal}).
25700 (Invocation::Badness): Take into account `Implicit constant
25701 expression conversions'.
25703 * literal.cs (LongLiteral): Implement long literal class.
25704 (IntLiteral): export the `Value' of the intliteral.
25706 2001-09-19 Ravi Pratap <ravi@ximian.com>
25708 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25710 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25711 instead of 'Operator'
25713 * expression.cs (Binary::ResolveOperator): Update accordingly.
25714 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25717 * cs-parser.jay (unary_expression): Update to use the new names.
25719 * gen-treedump.cs (GetUnary): Same here.
25721 * expression.cs (Unary::Resolve): Implement.
25722 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25723 operators are found instead of making noise ;-)
25724 (Unary::ResolveOperator): New method to do precisely the same thing which
25725 Binary::ResolveOperator does for Binary expressions.
25726 (Unary.method, .Arguments): Add.
25727 (Unary::OperName): Implement.
25728 (Unary::ForceConversion): Copy and Paste !
25730 * class.cs (Operator::Define): Fix a small bug for the case when we have
25733 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25734 for the inbuilt operators. Only overloading works for now ;-)
25736 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25738 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25739 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25741 * expression.cs (This::Emit): Implement.
25742 (This::Resolve): Implement.
25743 (TypeOf:Resolve): Implement.
25744 (Expression::ResolveSimpleName): Add an implicit this to instance
25746 (MemberAccess::Resolve): Deal with Parameters and Fields.
25747 Bind instance variable to Field expressions.
25748 (FieldExpr::Instance): New field used to track the expression that
25749 represents the object instance.
25750 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25752 (FieldExpr::Emit): Implement.
25754 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25755 the last instruction contains a return opcode to avoid generating
25756 the last `ret' instruction (this generates correct code, and it is
25757 nice to pass the peverify output).
25759 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25760 initializer for static and instance variables.
25761 (Constructor::Emit): Allow initializer to be null in the case of
25762 static constructors. Only emit initializer for instance
25765 (TypeContainer::FindMembers): Return a null array if there are no
25768 Also fix the code for the MemberTypes.Method branch, as it was not
25769 scanning that for operators (or tried to access null variables before).
25771 * assign.cs (Assign::Emit): Handle instance and static fields.
25775 * driver.cs: Stop compilation if there are parse errors.
25777 * cs-parser.jay (constructor_declaration): Provide default base
25778 initializer for non-static constructors.
25779 (constructor_declarator): Do not provide a default base
25780 initializers if none was specified.
25781 Catch the fact that constructors should not have parameters.
25783 * class.cs: Do not emit parent class initializers for static
25784 constructors, that should be flagged as an error.
25786 2001-09-18 Ravi Pratap <ravi@ximian.com>
25788 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25789 Move back code into TypeContainer::Populate.
25791 2001-09-18 Ravi Pratap <ravi@ximian.com>
25793 * class.cs (TypeContainer::AddConstructor): Fix the check to
25794 compare against Name, not Basename.
25795 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25797 * cs-parser.jay : Update accordingly.
25799 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25800 for methods, don't forget to look into the operators too.
25801 (RegisterMethodBuilder): Helper method to take care of this for
25802 methods, constructors and operators.
25803 (Operator::Define): Completely revamp.
25804 (Operator.OperatorMethod, MethodName): New fields.
25805 (TypeContainer::Populate): Move the registering of builders into
25806 RegisterMethodBuilder.
25807 (Operator::Emit): Re-write.
25809 * expression.cs (Binary::Emit): Comment out code path to emit method
25810 invocation stuff for the case when we have a user defined operator. I am
25811 just not able to get it right !
25813 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25815 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25818 (Expression::MemberLookup): Provide a version that allows to
25819 specify the MemberTypes and BindingFlags.
25821 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25822 so it was not fetching variable information from outer blocks.
25824 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25825 Beforefieldinit as it was buggy.
25827 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25828 that Ravi put here.
25830 * class.cs (Constructor::Emit): Only emit if block is not null.
25831 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25832 deal with this by semantically definining it as if the user had
25835 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25836 constructors as we now "emit" them at a higher level.
25838 (TypeContainer::DefineDefaultConstructor): Used to define the
25839 default constructors if none was provided.
25841 (ConstructorInitializer): Add methods Resolve and Emit.
25843 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25845 2001-09-17 Ravi Pratap <ravi@ximian.com>
25847 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25848 the default constructor builder with our hashtable for methodbuilders
25851 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25852 and argument_count is 0 in which case we have a match.
25853 (Binary::ResolveOperator): More null checking and miscellaneous coding
25856 2001-09-17 Ravi Pratap <ravi@ximian.com>
25858 * rootcontext.cs (IsNameSpace): Compare against null.
25860 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25862 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25863 and Unary::Operator.
25865 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25868 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25869 we have overloaded operators.
25870 (Binary::ResolveOperator): Implement the part which does the operator overload
25873 * class.cs (Operator::Emit): Implement.
25874 (TypeContainer::Emit): Emit the operators we have too.
25876 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25877 the case when we have a user-defined operator.
25879 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25881 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
25883 2001-09-16 Ravi Pratap <ravi@ximian.com>
25885 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
25886 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
25887 (Constructor::Emit): Implement.
25888 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
25889 if we have no work to do.
25890 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
25893 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
25894 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
25896 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
25899 2001-09-15 Ravi Pratap <ravi@ximian.com>
25901 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
25903 (Tree::RecordNamespace): Method to do what the name says ;-)
25904 (Tree::Namespaces): Property to get at the namespaces hashtable.
25906 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
25909 * rootcontext.cs (IsNamespace): Fixed it :-)
25911 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25913 * class.cs (TypeContainer::FindMembers): Add support for
25915 (MethodCore): New class that encapsulates both the shared aspects
25916 of a Constructor and a Method.
25917 (Method, Constructor): Factored pieces into MethodCore.
25919 * driver.cs: Added --fatal which makes errors throw exceptions.
25920 Load System assembly as well as part of the standard library.
25922 * report.cs: Allow throwing exceptions on errors for debugging.
25924 * modifiers.cs: Do not use `parent', instead use the real type
25925 container to evaluate permission settings.
25927 * class.cs: Put Ravi's patch back in. He is right, and we will
25928 have to cope with the
25930 2001-09-14 Ravi Pratap <ravi@ximian.com>
25932 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
25933 FamORAssem, not FamANDAssem.
25935 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25937 * driver.cs: Added --parse option that only parses its input files
25940 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
25941 incorrect. IsTopLevel is not used to tell whether an object is
25942 root_types or not (that can be achieved by testing this ==
25943 root_types). But to see if this is a top-level *class* (not
25944 necessarly our "toplevel" container).
25946 2001-09-14 Ravi Pratap <ravi@ximian.com>
25948 * enum.cs (Enum::Define): Modify to call the Lookup method on the
25949 parent instead of a direct call to GetType.
25951 2001-09-14 Ravi Pratap <ravi@ximian.com>
25953 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
25954 Modifiers.TypeAttr. This should just be a call to that method.
25956 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
25957 object so that we can determine if we are top-level or not.
25959 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
25962 * enum.cs (Enum::Define): Ditto.
25964 * modifiers.cs (FieldAttr): Re-write.
25966 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
25967 (TypeContainer::HaveStaticConstructor): New property to provide access
25968 to precisely that info.
25970 * modifiers.cs (MethodAttr): Re-write.
25971 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
25973 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
25974 of top-level types as claimed.
25976 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25978 * expression.cs (MemberLookup): Fruitless attempt to lookup
25979 constructors. Maybe I need to emit default constructors? That
25980 might be it (currently .NET emits this for me automatically).
25981 (Invocation::OverloadResolve): Cope with Arguments == null.
25982 (Invocation::EmitArguments): new function, shared by the new
25983 constructor and us.
25984 (Invocation::Emit): Handle static and instance methods. Emit
25985 proper call instruction for virtual or non-virtual invocations.
25986 (New::Emit): Implement.
25987 (New::Resolve): Implement.
25988 (MemberAccess:Resolve): Implement.
25989 (MethodGroupExpr::InstanceExpression): used conforming to the spec
25990 to track instances.
25991 (FieldExpr::Resolve): Set type.
25993 * support.cs: Handle empty arguments.
25995 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
25996 SimpleLookup): Auxiliary routines to help parse a qualifier
25999 Update qualifier_identifier rule.
26001 * codegen.cs: Removed debugging messages.
26003 * class.cs: Make this a global thing, this acts just as a "key" to
26004 objects that we might have around.
26006 (Populate): Only initialize method_builders_to_methods once.
26008 * expression.cs (PropertyExpr): Initialize type from the
26011 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
26012 Resolve pattern. Attempt to implicitly convert value to boolean.
26015 * expression.cs: Set the type for the int32/int32 argument case.
26016 (Binary::ResolveOperator): Set the return type to boolean for
26017 comparission operators
26019 * typemanager.cs: Remove debugging print code.
26021 (Invocation::Resolve): resolve type.
26023 * class.cs: Allocate a MemberInfo of the correct size, as the code
26024 elsewhere depends on the test to reflect the correct contents.
26026 (Method::) Keep track of parameters, due to System.Reflection holes
26028 (TypeContainer::Populate): Keep track of MethodBuilders to Method
26031 (TypeContainer::FindMembers): Use ArrayList and then copy an array
26032 of the exact size and return that.
26034 (Class::LookupMethodByBuilder): New function that maps
26035 MethodBuilders to its methods. Required to locate the information
26036 on methods because System.Reflection bit us again.
26038 * support.cs: New file, contains an interface ParameterData and
26039 two implementations: ReflectionParameters and InternalParameters
26040 used to access Parameter information. We will need to grow this
26043 * expression.cs (Invocation::GetParameterData): implement a cache
26044 and a wrapper around the ParameterData creation for methods.
26045 (Invocation::OverloadResolve): Use new code.
26047 2001-09-13 Ravi Pratap <ravi@ximian.com>
26049 * class.cs (TypeContainer::EmitField): Remove and move into
26050 (Field::Define): here and modify accordingly.
26051 (Field.FieldBuilder): New member.
26052 (TypeContainer::Populate): Update accordingly.
26053 (TypeContainer::FindMembers): Implement.
26055 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26057 * statement.cs: (VariableInfo::VariableType): New field to be
26058 initialized with the full type once it is resolved.
26060 2001-09-12 Miguel de Icaza <miguel@ximian.com>
26062 * parameter.cs (GetParameterInfo): Use a type cache to compute
26063 things only once, and to reuse this information
26065 * expression.cs (LocalVariableReference::Emit): Implement.
26066 (OpcodeCast::Emit): fix.
26068 (ParameterReference::Resolve): Implement.
26069 (ParameterReference::Emit): Implement.
26071 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
26072 that are expressions need to stay as Expressions.
26074 * typemanager.cs (CSharpName): Returns the C# name of a type if
26077 * expression.cs (Expression::ConvertImplicit): New function that
26078 implements implicit type conversions.
26080 (Expression::ImplicitReferenceConversion): Implements implicit
26081 reference conversions.
26083 (EmptyCast): New type for transparent casts.
26085 (OpcodeCast): New type for casts of types that are performed with
26086 a sequence of bytecodes.
26088 (BoxedCast): New type used for casting value types into reference
26089 types. Emits a box opcode.
26091 (Binary::DoNumericPromotions): Implements numeric promotions of
26092 and computation of the Binary::Type.
26094 (Binary::EmitBranchable): Optimization.
26096 (Binary::Emit): Implement code emission for expressions.
26098 * typemanager.cs (TypeManager): Added two new core types: sbyte
26101 2001-09-12 Ravi Pratap <ravi@ximian.com>
26103 * class.cs (TypeContainer::FindMembers): Method which does exactly
26104 what Type.FindMembers does, only we don't have to use reflection. No
26105 implementation yet.
26107 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
26108 typecontainer objects as we need to get at them.
26109 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
26111 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
26112 typecontainer object.
26114 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
26115 of just a Report object.
26117 2001-09-11 Ravi Pratap <ravi@ximian.com>
26119 * class.cs (Event::Define): Go back to using the prefixes "add_" and
26121 (TypeContainer::Populate): Now define the delegates of the type too.
26122 (TypeContainer.Delegates): Property to access the list of delegates defined
26125 * delegates.cs (Delegate::Define): Implement partially.
26127 * modifiers.cs (TypeAttr): Handle more flags.
26129 2001-09-11 Ravi Pratap <ravi@ximian.com>
26131 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
26133 (Operator::Define): Re-write logic to get types by using the LookupType method
26134 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
26135 (Indexer::Define): Ditto.
26136 (Event::Define): Ditto.
26137 (Property::Define): Ditto.
26139 2001-09-10 Ravi Pratap <ravi@ximian.com>
26141 * class.cs (TypeContainer::Populate): Now define operators too.
26142 (TypeContainer.Operators): New property to access the list of operators
26144 (Operator.OperatorMethodBuilder): New member to hold the method builder
26145 for the operator we are defining.
26146 (Operator::Define): Implement.
26148 2001-09-10 Ravi Pratap <ravi@ximian.com>
26150 * class.cs (Event::Define): Make the prefixes of the accessor methods
26151 addOn_ and removeOn_
26153 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
26154 of the location being passed in too. Ideally, this should go later since all
26155 error reporting should be done through the Report object.
26157 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
26158 (Populate): Iterate thru the indexers we have and define them too.
26159 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
26160 for the get and set accessors.
26161 (Indexer::Define): Implement.
26163 2001-09-09 Miguel de Icaza <miguel@ximian.com>
26165 * expression.cs (Binary::Resolve): Beginning of it. I scratched
26166 my previous implementation, did not work.
26168 * typemanager.cs: Add a couple of missing types (the longs).
26170 * literal.cs: Use TypeManager.bool_type instead of getting it.
26172 * expression.cs (EventExpr): New kind of expressions.
26173 (Expressio::ExprClassFromMemberInfo): finish
26175 2001-09-08 Miguel de Icaza <miguel@ximian.com>
26177 * assign.cs: Emit stores to static fields differently.
26179 2001-09-08 Ravi Pratap <ravi@ximian.com>
26181 * Merge in changes and adjust code to tackle conflicts. Backed out my
26182 code in Assign::Resolve ;-)
26184 2001-09-08 Ravi Pratap <ravi@ximian.com>
26186 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
26187 instead Report.Error and also pass in the location.
26188 (CSharpParser::Lexer): New readonly property to return the reference
26189 to the Tokenizer object.
26190 (declare_local_variables): Use Report.Error with location instead of plain
26194 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
26195 (Operator.CheckBinaryOperator): Ditto.
26197 * cs-parser.jay (operator_declarator): Update accordingly.
26199 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
26200 (CheckBinaryOperator): Same here.
26202 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
26203 on the name without any prefixes of namespace names etc. This is because we
26204 already might have something already fully qualified like
26205 'System.Console.WriteLine'
26207 * assign.cs (Resolve): Begin implementation. Stuck ;-)
26209 2001-09-07 Ravi Pratap <ravi@ximian.com>
26211 * cs-tokenizer.cs (location): Return a string which also contains
26214 * expression.cs (ElementAccess): New class for expressions of the
26215 type 'element access.'
26216 (BaseAccess): New class for expressions of the type 'base access.'
26217 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
26220 * cs-parser.jay (element_access): Implement action.
26221 (base_access): Implement actions.
26222 (checked_expression, unchecked_expression): Implement.
26224 * cs-parser.jay (local_variable_type): Correct and implement.
26225 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
26227 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
26229 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
26230 name and the specifiers.
26232 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
26234 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
26235 making them all public ;-)
26237 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
26240 2001-09-07 Miguel de Icaza <miguel@ximian.com>
26242 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
26244 (FieldExpr, PropertyExprs): New resolved expressions.
26245 (SimpleName::MemberStaticCheck): Perform static checks for access
26246 to non-static fields on static methods. Maybe this should be
26247 generalized for MemberAccesses.
26248 (SimpleName::ResolveSimpleName): More work on simple name
26251 * cs-parser.jay (primary_expression/qualified_identifier): track
26252 the parameter index.
26254 * codegen.cs (CodeGen::Save): Catch save exception, report error.
26255 (EmitContext::EmitBoolExpression): Chain to expression generation
26256 instead of temporary hack.
26257 (::EmitStatementExpression): Put generic expression code generation.
26259 * assign.cs (Assign::Emit): Implement variable assignments to
26260 local variables, parameters and fields.
26262 2001-09-06 Miguel de Icaza <miguel@ximian.com>
26264 * statement.cs (Block::GetVariableInfo): New method, returns the
26265 VariableInfo for a variable name in a block.
26266 (Block::GetVariableType): Implement in terms of GetVariableInfo
26268 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26269 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26271 2001-09-06 Ravi Pratap <ravi@ximian.com>
26273 * cs-parser.jay (operator_declaration): Continue on my quest : update
26274 to take attributes argument.
26275 (event_declaration): Ditto.
26276 (enum_declaration): Ditto.
26277 (indexer_declaration): Ditto.
26279 * class.cs (Operator::Operator): Update constructor accordingly.
26280 (Event::Event): Ditto.
26282 * delegate.cs (Delegate::Delegate): Same here.
26284 * enum.cs (Enum::Enum): Same here.
26286 2001-09-05 Ravi Pratap <ravi@ximian.com>
26288 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26290 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26292 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26293 being passed around as an arraylist.
26294 (Attributes::AddAttribute): Method to add attribute sections.
26296 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26297 (struct_declaration): Update accordingly.
26298 (constant_declaration): Update.
26299 (field_declaration): Update.
26300 (method_header): Update.
26301 (fixed_parameter): Update.
26302 (parameter_array): Ditto.
26303 (property_declaration): Ditto.
26304 (destructor_declaration): Ditto.
26306 * class.cs (Struct::Struct): Update constructors accordingly.
26307 (Class::Class): Ditto.
26308 (Field::Field): Ditto.
26309 (Method::Method): Ditto.
26310 (Property::Property): Ditto.
26311 (TypeContainer::OptAttribute): update property's return type.
26313 * interface.cs (Interface.opt_attributes): New member.
26314 (Interface::Interface): Update to take the extra Attributes argument.
26316 * parameter.cs (Parameter::Parameter): Ditto.
26318 * constant.cs (Constant::Constant): Ditto.
26320 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26321 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26322 the attributes as a parameter.
26323 (InterfaceProperty): Update constructor call.
26324 (InterfaceEvent): Ditto.
26325 (InterfaceMethod): Ditto.
26326 (InterfaceIndexer): Ditto.
26328 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26329 pass the attributes too.
26330 (interface_event_declaration): Ditto.
26331 (interface_property_declaration): Ditto.
26332 (interface_method_declaration): Ditto.
26333 (interface_declaration): Ditto.
26335 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26337 * class.cs (Method::Define): Track the "static Main" definition to
26338 create an entry point.
26340 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26341 EntryPoint if we find it.
26343 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26344 (EmitContext::ig): Make this variable public.
26346 * driver.cs: Make the default output file be the first file name
26347 with the .exe extension.
26349 Detect empty compilations
26351 Handle various kinds of output targets. Handle --target and
26352 rename -t to --dumper.
26354 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26355 methods inherited from Expression return now an Expression. This
26356 will is used during the tree rewriting as we resolve them during
26359 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26360 the spec. Missing entirely is the information about
26361 accessability of elements of it.
26363 (Expression::ExprClassFromMemberInfo): New constructor for
26364 Expressions that creates a fully initialized Expression based on
26365 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26368 (Invocation::Resolve): Begin implementing resolution of invocations.
26370 * literal.cs (StringLiteral): Implement Emit.
26372 2001-09-05 Ravi Pratap <ravi@ximian.com>
26374 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26377 2001-09-04 Ravi Pratap <ravi@ximian.com>
26379 * cs-parser.jay (attribute_arguments): Implement actions.
26380 (attribute): Fix bug in production. Implement action.
26381 (attribute_list): Implement.
26382 (attribute_target): Implement.
26383 (attribute_target_specifier, opt_target_specifier): Implement
26384 (CheckAttributeTarget): New method to check if the attribute target
26386 (attribute_section): Implement.
26387 (opt_attributes): Implement.
26389 * attribute.cs : New file to handle attributes.
26390 (Attribute): Class to hold attribute info.
26392 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26393 (attribute_section): Modify production to use 2 different rules to
26394 achieve the same thing. 1 s/r conflict down !
26395 Clean out commented, useless, non-reducing dimension_separator rules.
26397 * class.cs (TypeContainer.attributes): New member to hold list
26398 of attributes for a type.
26399 (Struct::Struct): Modify to take one more argument, the attribute list.
26400 (Class::Class): Ditto.
26401 (Field::Field): Ditto.
26402 (Method::Method): Ditto.
26403 (Property::Property): Ditto.
26405 * cs-parser.jay (struct_declaration): Update constructor call to
26406 pass in the attributes too.
26407 (class_declaration): Ditto.
26408 (constant_declaration): Ditto.
26409 (field_declaration): Ditto.
26410 (method_header): Ditto.
26411 (fixed_parameter): Ditto.
26412 (parameter_array): Ditto.
26413 (property_declaration): Ditto.
26415 * constant.cs (Constant::Constant): Update constructor similarly.
26416 Use System.Collections.
26418 * parameter.cs (Parameter::Parameter): Update as above.
26420 2001-09-02 Ravi Pratap <ravi@ximian.com>
26422 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26423 (TypeContainer.delegates): New member to hold list of delegates.
26425 * cs-parser.jay (delegate_declaration): Implement the action correctly
26426 this time as I seem to be on crack ;-)
26428 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26430 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26431 tell whether an identifier represents a namespace.
26433 * expression.cs (NamespaceExpr): A namespace expression, used only
26434 temporarly during expression resolution.
26435 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26436 utility functions to resolve names on expressions.
26438 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26440 * codegen.cs: Add hook for StatementExpressions.
26442 * class.cs: Fix inverted test for static flag in methods.
26444 2001-09-02 Ravi Pratap <ravi@ximian.com>
26446 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26447 to make it coincide with MS' number.
26448 (Operator::CheckBinaryOperator): Ditto.
26450 * ../errors/errors.txt : Remove error numbers added earlier.
26452 * ../errors/cs1019.cs : Test case for error # 1019
26454 * ../errros/cs1020.cs : Test case for error # 1020
26456 * cs-parser.jay : Clean out commented cruft.
26457 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26458 used anywhere - non-reducing rule.
26459 (namespace_declarations): Non-reducing rule - comment out.
26461 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26462 with TypeContainer::AddEnum.
26464 * delegate.cs : New file for delegate handling classes.
26465 (Delegate): Class for declaring delegates.
26467 * makefile : Update.
26469 * cs-parser.jay (delegate_declaration): Implement.
26471 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26473 * class.cs (Event::Define): Implement.
26474 (Event.EventBuilder): New member.
26476 * class.cs (TypeContainer::Populate): Update to define all enums and events
26478 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26479 readonly fields for all these cases ?
26481 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26483 * class.cs (Property): Revamp to use the convention of making fields readonly.
26484 Accordingly modify code elsewhere.
26486 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26487 the Define method of the Property class.
26489 * class.cs : Clean up applied patch and update references to variables etc. Fix
26491 (TypeContainer::Populate): Update to define all the properties we have. Also
26492 define all enumerations.
26494 * enum.cs (Define): Implement.
26496 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26498 * cs-parser.jay (overloadable_operator): The semantic value is an
26499 enum of the Operator class.
26500 (operator_declarator): Implement actions.
26501 (operator_declaration): Implement.
26503 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26504 validity of definitions.
26505 (Operator::CheckBinaryOperator): Static method to check for binary operators
26506 (TypeContainer::AddOperator): New method to add an operator to a type.
26508 * cs-parser.jay (indexer_declaration): Added line to actually call the
26509 AddIndexer method so it gets added ;-)
26511 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26512 already taken care of by the MS compiler ?
26514 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26516 * class.cs (Operator): New class for operator declarations.
26517 (Operator::OpType): Enum for the various operators.
26519 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26521 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26522 ostensibly handle this in semantic analysis.
26524 * cs-parser.jay (general_catch_clause): Comment out
26525 (specific_catch_clauses, specific_catch_clause): Ditto.
26526 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26527 (catch_args, opt_catch_args): New productions.
26528 (catch_clause): Rewrite to use the new productions above
26529 (catch_clauses): Modify accordingly.
26530 (opt_catch_clauses): New production to use in try_statement
26531 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26532 and re-write the code in the actions to extract the specific and
26533 general catch clauses by being a little smart ;-)
26535 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26536 Hooray, try and catch statements parse fine !
26538 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26540 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26541 string from the hashtable of variables.
26543 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26544 I end up making that mistake ;-)
26545 (catch_clauses): Fixed gross error which made Key and Value of the
26546 DictionaryEntry the same : $1 !!
26548 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26550 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26552 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26553 when the add and remove accessors are specified.
26555 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26557 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26558 information about indexer_declarator.
26559 (indexer_declarator): Implement actions.
26560 (parsing_indexer): New local boolean used to keep track of whether
26561 we are parsing indexers or properties. This is necessary because
26562 implicit_parameters come into picture even for the get accessor in the
26563 case of an indexer.
26564 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26566 * class.cs (Indexer): New class for indexer declarations.
26567 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26568 (TypeContainer::indexers): New member to hold list of indexers for the
26571 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26573 * cs-parser.jay (add_accessor_declaration): Implement action.
26574 (remove_accessor_declaration): Implement action.
26575 (event_accessors_declaration): Implement
26576 (variable_declarators): swap statements for first rule - trivial.
26578 * class.cs (Event): New class to hold information about event
26580 (TypeContainer::AddEvent): New method to add an event to a type
26581 (TypeContainer::events): New member to hold list of events.
26583 * cs-parser.jay (event_declaration): Implement actions.
26585 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26587 * cs-parser.jay (dim_separators): Implement. Make it a string
26588 concatenating all the commas together, just as they appear.
26589 (opt_dim_separators): Modify accordingly
26590 (rank_specifiers): Update accordingly. Basically do the same
26591 thing - instead, collect the brackets here.
26592 (opt_rank_sepcifiers): Modify accordingly.
26593 (array_type): Modify to actually return the complete type string
26594 instead of ignoring the rank_specifiers.
26595 (expression_list): Implement to collect the expressions
26596 (variable_initializer): Implement. We make it a list of expressions
26597 essentially so that we can handle the array_initializer case neatly too.
26598 (variable_initializer_list): Implement.
26599 (array_initializer): Make it a list of variable_initializers
26600 (opt_array_initializer): Modify accordingly.
26602 * expression.cs (New::NType): Add enumeration to help us
26603 keep track of whether we have an object/delegate creation
26604 or an array creation.
26605 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26606 members to hold data about array creation.
26607 (New:New): Modify to update NewType
26608 (New:New): New Overloaded contructor for the array creation
26611 * cs-parser.jay (array_creation_expression): Implement to call
26612 the overloaded New constructor.
26614 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26616 * class.cs (TypeContainer::Constructors): Return member
26617 constructors instead of returning null.
26619 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26621 * typemanager.cs (InitCoreTypes): Initialize the various core
26622 types after we have populated the type manager with the user
26623 defined types (this distinction will be important later while
26624 compiling corlib.dll)
26626 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26627 on Expression Classification. Now all expressions have a method
26628 `Resolve' and a method `Emit'.
26630 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26631 generation from working. Also add some temporary debugging
26634 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26636 * codegen.cs: Lots of code generation pieces. This is only the
26637 beginning, will continue tomorrow with more touches of polish. We
26638 handle the fundamentals of if, while, do, for, return. Others are
26639 trickier and I need to start working on invocations soon.
26641 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26644 * codegen.cs (EmitContext): New struct, used during code
26645 emission to keep a context. Most of the code generation will be
26648 * cs-parser.jay: Add embedded blocks to the list of statements of
26649 this block. So code generation proceeds in a top down fashion.
26651 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26653 * statement.cs: Add support for multiple child blocks.
26655 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26657 * codegen.cs (EmitCode): New function, will emit the code for a
26658 Block of code given a TypeContainer and its ILGenerator.
26660 * statement.cs (Block): Standard public readonly optimization.
26661 (Block::Block constructors): Link children.
26662 (Block::Child): Child Linker.
26663 (Block::EmitVariables): Emits IL variable declarations.
26665 * class.cs: Drop support for MethodGroups here, delay until
26667 (Method::): Applied the same simplification that I did before, and
26668 move from Properties to public readonly fields.
26669 (Method::ParameterTypes): Returns the parameter types for the
26670 function, and implements a cache that will be useful later when I
26671 do error checking and the semantic analysis on the methods is
26673 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26674 and made a method, optional argument tells whether this is a class
26675 or a structure to apply the `has-this' bit.
26676 (Method::GetCallingConvention): Implement, returns the calling
26678 (Method::Define): Defines the type, a second pass is performed
26679 later to populate the methods.
26681 (Constructor::ParameterTypes): implement a cache similar to the
26682 one on Method::ParameterTypes, useful later when we do semantic
26685 (TypeContainer::EmitMethod): New method. Emits methods.
26687 * expression.cs: Removed MethodGroup class from here.
26689 * parameter.cs (Parameters::GetCallingConvention): new method.
26691 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26693 * class.cs (TypeContainer::Populate): Drop RootContext from the
26696 (Constructor::CallingConvention): Returns the calling convention.
26697 (Constructor::ParameterTypes): Returns the constructor parameter
26700 (TypeContainer::AddConstructor): Keep track of default constructor
26701 and the default static constructor.
26703 (Constructor::) Another class that starts using `public readonly'
26704 instead of properties.
26706 (Constructor::IsDefault): Whether this is a default constructor.
26708 (Field::) use readonly public fields instead of properties also.
26710 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26711 track of static constructors; If none is used, turn on
26712 BeforeFieldInit in the TypeAttributes.
26714 * cs-parser.jay (opt_argument_list): now the return can be null
26715 for the cases where there are no arguments.
26717 (constructor_declarator): If there is no implicit `base' or
26718 `this', then invoke the default parent constructor.
26720 * modifiers.cs (MethodAttr): New static function maps a set of
26721 modifiers flags into a MethodAttributes enum
26722 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26723 MethodAttr, TypeAttr to represent the various mappings where the
26724 modifiers are used.
26725 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26727 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26729 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26732 * interface.cs (PopulateIndexer): Implemented the code generator
26733 for interface indexers.
26735 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26737 * interface.cs (InterfaceMemberBase): Now we track the new status
26740 (PopulateProperty): Implement property population. Woohoo! Got
26741 Methods and Properties going today.
26743 Removed all the properties for interfaces, and replaced them with
26744 `public readonly' fields.
26746 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26748 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26749 initialize their hashtables/arraylists only when they are needed
26750 instead of doing this always.
26752 * parameter.cs: Handle refs and out parameters.
26754 * cs-parser.jay: Use an ArrayList to construct the arguments
26755 instead of the ParameterCollection, and then cast that to a
26758 * parameter.cs: Drop the use of ParameterCollection and use
26759 instead arrays of Parameters.
26761 (GetParameterInfo): Use the Type, not the Name when resolving
26764 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26766 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26767 and instead use public readonly fields.
26769 * class.cs: Put back walking code for type containers.
26771 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26773 * class.cs (MakeConstant): Code to define constants.
26775 * rootcontext.cs (LookupType): New function. Used to locate types
26778 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26780 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26781 this System.Reflection code is. Kudos to Microsoft
26783 * typemanager.cs: Implement a type cache and avoid loading all
26784 types at boot time. Wrap in LookupType the internals. This made
26785 the compiler so much faster. Wow. I rule!
26787 * driver.cs: Make sure we always load mscorlib first (for
26788 debugging purposes, nothing really important).
26790 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26791 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26793 * rootcontext.cs: Lookup types on their namespace; Lookup types
26794 on namespaces that have been imported using the `using' keyword.
26796 * class.cs (TypeContainer::TypeAttr): Virtualize.
26797 (Class::TypeAttr): Return attributes suitable for this bad boy.
26798 (Struct::TypeAttr): ditto.
26799 Handle nested classes.
26800 (TypeContainer::) Remove all the type visiting code, it is now
26801 replaced with the rootcontext.cs code
26803 * rootcontext.cs (GetClassBases): Added support for structs.
26805 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26807 * interface.cs, statement.cs, class.cs, parameter.cs,
26808 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26809 Drop use of TypeRefs, and use strings instead.
26811 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26815 * class.cs (Struct::Struct): set the SEALED flags after
26816 checking the modifiers.
26817 (TypeContainer::TypeAttr): new property, returns the
26818 TypeAttributes for a class.
26820 * cs-parser.jay (type_list): Oops, list production was creating a
26821 new list of base types.
26823 * rootcontext.cs (StdLib): New property.
26824 (GetInterfaceTypeByName): returns an interface by type name, and
26825 encapsulates error handling here.
26826 (GetInterfaces): simplified.
26827 (ResolveTree): Encapsulated all the tree resolution here.
26828 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26831 * driver.cs: Add support for --nostdlib, to avoid loading the
26832 default assemblies.
26833 (Main): Do not put tree resolution here.
26835 * rootcontext.cs: Beginning of the class resolution.
26837 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26839 * rootcontext.cs: Provide better error reporting.
26841 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26843 * rootcontext.cs (CreateInterface): Handle the case where there
26844 are no parent interfaces.
26846 (CloseTypes): Routine to flush types at the end.
26847 (CreateInterface): Track types.
26848 (GetInterfaces): Returns an array of Types from the list of
26849 defined interfaces.
26851 * typemanager.c (AddUserType): Mechanism to track user types (puts
26852 the type on the global type hash, and allows us to close it at the
26855 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26857 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26858 RecordInterface instead.
26860 * cs-parser.jay: Updated to reflect changes above.
26862 * decl.cs (Definition): Keep track of the TypeBuilder type that
26863 represents this type here. Not sure we will use it in the long
26864 run, but wont hurt for now.
26866 * driver.cs: Smaller changes to accomodate the new code.
26868 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26871 * rootcontext.cs (CreateInterface): New method, used to create
26872 the System.TypeBuilder type for interfaces.
26873 (ResolveInterfaces): new entry point to resolve the interface
26875 (CodeGen): Property, used to keep track of the code generator.
26877 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26879 * cs-parser.jay: Add a second production for delegate_declaration
26882 (enum_body): Put an opt_comma here instead of putting it on
26883 enum_body or enum_member_declarations so we can handle trailing
26884 commas on enumeration members. Gets rid of a shift/reduce.
26886 (type_list): Need a COMMA in the middle.
26888 (indexer_declaration): Tell tokenizer to recognize get/set
26890 * Remove old targets.
26892 * Re-add the parser target.
26894 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26896 * cs-parser.jay: Add precendence rules for a number of operators
26897 ot reduce the number of shift/reduce conflicts in the grammar.
26899 2001-07-17 Miguel de Icaza <miguel@ximian.com>
26901 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
26904 Get rid of old crufty code.
26906 * rootcontext.cs: Use this to keep track of the parsed
26907 representation and the defined types available to the program.
26909 * gen-treedump.cs: adjust for new convention.
26911 * type.cs: Split out the type manager, and the assembly builder
26914 * typemanager.cs: the type manager will live here now.
26916 * cil-codegen.cs: And the code generator here.
26918 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
26920 * makefile: Fixed up for easy making.
26922 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26924 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
26927 (unary_expression): Expand pre_increment_expression and
26928 post_decrement_expression to reduce a shift/reduce.
26930 2001-07-11 Simon Cozens
26932 * cs-tokenizer.cs: Hex numbers should begin with a 0.
26934 Improve allow_keyword_as_indent name.
26936 2001-06-19 Miguel de Icaza <miguel@ximian.com>
26938 * Adjustments for Beta2.
26940 2001-06-13 Miguel de Icaza <miguel@ximian.com>
26942 * decl.cs: Added `Define' abstract method.
26943 (InTransit): new property, used to catch recursive definitions.
26945 * interface.cs: Implement `Define'.
26947 * modifiers.cs: Map Modifiers.constants to
26948 System.Reflection.TypeAttribute flags.
26950 * class.cs: Keep track of types and user-defined types.
26951 (BuilderInit): New method for creating an assembly
26952 (ResolveType): New function to launch the resolution process, only
26953 used by interfaces for now.
26955 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
26956 that are inserted into the name space.
26958 2001-06-08 Miguel de Icaza <miguel@ximian.com>
26960 * ARGH. I have screwed up my tree so many times due to the use of
26961 rsync rather than using CVS. Going to fix this at once.
26963 * driver.cs: Objetify driver. Load assemblies, use assemblies to
26966 2001-06-07 Miguel de Icaza <miguel@ximian.com>
26968 * Experiment successful: Use System.Type rather that our own
26971 2001-05-25 Miguel de Icaza <miguel@ximian.com>
26973 * cs-parser.jay: Removed nsAliases from here.
26975 Use new namespaces, handle `using XXX;'
26977 * namespace.cs: Reimplemented namespace handling, use a recursive
26978 definition of the class. Now we can keep track of using clauses
26979 and catch invalid using clauses.
26981 2001-05-24 Miguel de Icaza <miguel@ximian.com>
26983 * gen-treedump.cs: Adapted for all the renaming.
26985 * expression.cs (Expression): this class now has a Type property
26986 which returns an expression Type.
26988 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
26989 `Type', as this has a different meaning now in the base
26991 2001-05-22 Miguel de Icaza <miguel@ximian.com>
26993 * interface.cs, class.cs: Removed from all the sources the
26994 references to signature computation, as we can not do method
26995 signature computation during the parsing time, as we are not
26996 trying to solve at that point distinguishing:
27000 void a (NS.Blah x) {}
27003 Which depending on the context might be valid or not, as we do not
27004 know if Blah is the same thing as NS.Blah at that point.
27006 * Redid everything so the code uses TypeRefs now instead of
27007 Types. TypeRefs are just temporary type placeholders, that need
27008 to be resolved. They initially have a pointer to a string and the
27009 current scope in which they are used. This is used later by the
27010 compiler to resolve the reference to an actual Type.
27012 * DeclSpace is no longer a CIR.Type, and neither are
27013 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
27014 are all DeclSpaces, but no Types.
27016 * type.cs (TypeRefManager): This implements the TypeRef manager,
27017 which keeps track of all the types that need to be resolved after
27018 the parsing has finished.
27020 2001-05-13 Miguel de Icaza <miguel@ximian.com>
27022 * ARGH. We are going to have to store `foreach' as a class rather
27023 than resolving it, as we need to verify error 1579 after name
27024 resolution. *OR* we could keep a flag that says `This request to
27025 IEnumerator comes from a foreach statement' which we can then use
27026 to generate the error.
27028 2001-05-10 Miguel de Icaza <miguel@ximian.com>
27030 * class.cs (TypeContainer.AddMethod): we now add methods to the
27031 MethodGroup instead of the method hashtable.
27033 * expression.cs: Add MethodGroup abstraction, which gets us one
27034 step closer to the specification in the way we handle method
27037 * cs-parser.jay (primary_expression): qualified_identifier now
27038 tried to match up an identifier to a local variable reference or
27039 to a parameter reference.
27041 current_local_parameters is now a parser global variable that
27042 points to the current parameters for the block, used during name
27045 (property_declaration): Now creates an implicit `value' argument to
27048 2001-05-09 Miguel de Icaza <miguel@ximian.com>
27050 * parameter.cs: Do not use `param' arguments as part of the
27051 signature, per the spec.
27053 2001-05-08 Miguel de Icaza <miguel@ximian.com>
27055 * decl.cs: Base class for classes, structs and interfaces. This
27056 is the "Declaration Space"
27058 * cs-parser.jay: Use CheckDef for checking declaration errors
27059 instead of having one on each function.
27061 * class.cs: Factor out some code for handling error handling in
27062 accordance to the "Declarations" section in the "Basic Concepts"
27063 chapter in the ECMA C# spec.
27065 * interface.cs: Make all interface member classes derive from
27066 InterfaceMemberBase.
27068 2001-05-07 Miguel de Icaza <miguel@ximian.com>
27070 * Many things: all interfaces are parsed and generated in
27071 gen-treedump. Support for member variables, constructors,
27072 destructors, properties, constants is there.
27074 Beginning of the IL backend, but very little done, just there for
27077 2001-04-29 Miguel de Icaza <miguel@ximian.com>
27079 * cs-parser.jay: Fix labeled statement.
27081 * cs-tokenizer.cs (escape): Escape " and ' always.
27082 ref_line, ref_name: keep track of the line/filename as instructed
27083 by #line by the compiler.
27086 2001-04-27 Miguel de Icaza <miguel@ximian.com>
27088 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
27089 to match the values in System.CodeDOM.
27091 Divid renamed to Divide.
27093 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
27095 (Statements.set): remove.
27097 * System.CodeDOM/CodeCatchClause.cs: always have a valid
27100 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
27101 falseStatements always have valid values.
27103 * cs-parser.jay: Use System.CodeDOM now.