1 2007-07-03 Marek Safar <marek.safar@gmail.com>
3 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
6 * linq.cs (QueryExpression.DoResolve): Resolve implicitly typed query
9 2007-06-20 Marek Safar <marek.safar@gmail.com>
11 * cs-parser.jay: Reworked var keyword handling. We cannot handle var as
12 static keyword because var becomes keyword only if no type with the var
13 name exists in the scope of variable which uses var declaration.
15 2007-06-18 Marek Safar <marek.safar@gmail.com>
17 * cs-parser.jay: Add implicitly typed local variable checks.
19 2007-06-15 Marek Safar <marek.safar@gmail.com>
21 * cs-parser.jay: Correctly split generic arguments and generic
22 parameters. Correctly implemented typeof of generic unbound types.
24 2007-06-14 Marek Safar <marek.safar@gmail.com>
26 * cs-parser.jay: Assembly and module attributes must precede all other
27 elements except using clauses and extern alias declarations.
29 2007-06-08 Marek Safar <marek.safar@gmail.com>
31 * cs-parser.jay: Uses newly defined GroupBy class.
33 * linq.cs (GroupBy): Implemented.
34 (AQueryClause.BuildQueryClause): Refactored to allow customize query
37 2007-06-08 Marek Safar <marek.safar@gmail.com>
39 * generics.cs (InferTypeArguments): Uses AnonymousMethodExpression
42 2007-06-06 Marek Safar <marek.safar@gmail.com>
44 * generics.cs (TypeArguments): New contructor fow known number of
47 2007-06-04 Raja R Harinath <rharinath@novell.com>
49 * linq.cs (Select.DoResolve): Pass the created parameters to the
52 2007-05-29 Raja R Harinath <rharinath@novell.com>
54 * cs-parser.jay: Update to changes in ToplevelBlock.
55 (top_current_block): Remove.
57 2007-05-27 Raja R Harinath <harinath@gmail.com>
59 * cs-parser.jay: Update to new ExplicitBlock invariant.
61 * cs-parser.jay: Update to changes introduced in Block and
64 2007-05-25 Raja R Harinath <rharinath@novell.com>
66 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
67 modifying current_block directly.
69 2007-05-22 Scott Peterson <lunchtimemama@gmail.com>
71 * cs-parser.jay: Implemented automatic properties (C# 3.0)
73 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
75 * cs-parser.jay: Improved grammar for object and collection
78 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
80 This code is contributed under the MIT X11 license
82 * cs-parser.jay: Added support for C# 3.0 language features:
83 Variable type inference (the "var" keyword)
87 Collection initialization
89 2007-05-06 Marek Safar <marek.safar@gmail.com>
92 * cs-parser.jay: Add special handling for coalescing operator.
94 2007-05-02 Raja R Harinath <rharinath@novell.com>
96 Fix regression in cs0631-3.cs
97 * cs-parser.jay (operator_declarator): Add opt_attributes to error
98 fallback. Make error fallback catch more cases.
100 2007-05-01 Miguel de Icaza <miguel@novell.com>
102 * cs-parser.jay: Allow parameters in operator declarations to have
105 2007-04-27 Miguel de Icaza <miguel@novell.com>
107 * generic.cs (TypeManager.LambdaInfer): now this routine will
108 make only one inference from the list of lambda expression that
109 have not participated in inferring a type.
111 (TypeManager.InferTypeArguments): The logic that drives the type
112 inference in lambda expressions is now driven here.
114 2007-04-23 Miguel de Icaza <miguel@novell.com>
116 * generic.cs: Large update to LambdaInfer, this is merely an
117 update to start the lambda type inference. It is by no means
118 complete. It is currently merely able to build a sample program
119 (with no iteration for the type parameters).
121 2007-04-12 Duncan Mak <duncan@a-chinaman.com>
123 * cs-parser.jay (interface_method_declaration_body): Fixed typo.
125 2007-04-08 Marek Safar <marek.safar@gmail.com>
127 * cs-parser.jay, linq.cs: First select implementation (hacky).
129 * generic.cs (InferTypeArguments): Simplified.
131 2007-03-31 Marek Safar <marek.safar@gmail.com>
133 * generic.cs (InferTypeArguments): Restored validation check.
134 (InferTypeArguments): Move all logic to Compatible method for re-usability.
136 2007-03-25 Marek Safar <marek.safar@gmail.com>
138 * generic.cs (InferTypeArguments): Infer arguments before they are used
139 for compatibility check.
141 2007-03-15 Marek Safar <marek.safar@gmail.com>
143 * generic.cs (InflatedConstraints): Fixed the check order.
144 (TypeArguments.Resolve): Small optimization for generic parameters.
145 (InferTypeArguments): Add infering support for anonymous methods.
147 2007-03-15 Martin Baulig <martin@ximian.com>
152 (TypeParameter.HasConstructorConstraint): Removed.
153 (ConstraintChecker.HasDefaultConstructor): Removed the
154 `TypeBuilder' argument here; correctly check for the ctor
155 constraint on type parameters.
157 2007-03-15 Martin Baulig <martin@ximian.com>
162 (TypeParameter): Create a `MemberCache' here as well. Note that
163 we need to create this on-demand when it's actually used.
165 2007-03-10 Marek Safar <marek.safar@gmail.com>
167 * generic.cs (TypeArguments.Resolve): Avoid redundant checks.
169 2007-03-09 Raja R Harinath <rharinath@novell.com>
171 * cs-parser.jay (WHERE): Move before QUERY_FIRST_TOKEN. 'where'
172 is a valid keyword outside a linq expression too.
174 2007-03-03 Marek Safar <marek.safar@gmail.com>
176 * cs-parser.jay: Implemented basic linq grammar.
178 * linq.cs: New file for hosting query specific classes.
180 2007-02-26 Marek Safar <marek.safar@gmail.com>
182 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
184 2007-02-20 Marek Safar <marek.safar@gmail.com>
187 * cs-parser.jay: Anonymous container starts at constructor declaration
188 and not at block beginning because it has to be usable in constructor
191 2007-02-18 Marek Safar <marek.safar@gmail.com>
193 A fix for bug #80493 by Atsushi Enomoto
194 * cs-parser.jay: Ignore invalid attribute target.
196 2007-02-15 Miguel de Icaza <miguel@novell.com>
198 * Remove the call to SetExpression for lambda expressions, we do
199 not actually need it.
201 Remove expression tracking code as its not needed.
203 2007-02-11 Miguel de Icaza <miguel@novell.com>
205 * cs-parser.jay (lambda_expression_body): when the body is an
206 expression add a statement of the form:
208 contextual-return expression.
210 Where `contextual-return' is similar to `return', the difference
211 being that if the delegate that the lambda will be converted to
212 has a void return type, it will check that the result is a
213 ExpressionStatement and the result is a plain ret (no return
214 values on the stack). If the return type of the delegate is of a
215 given type, this turns into a return with a value and does the
216 regular checking to check that the computed value can be
217 implicitly converted to the delegate return.
219 2007-01-30 Miguel de Icaza <miguel@novell.com>
221 * cs-parser.jay (anonymous_method_expression): move the
222 before/after productions to the start_anonymous and end_anonymous
223 methods so the code can be reused for lambda functions.
225 (lambda_expression_body): wrap expressions implicitly into a
228 (block): factor out the setup/teardown of parsing a block so we
229 can reuse that in lambda_expression_body
231 (lambda_expression): use new anonymous method helper methods.
233 2007-01-29 Miguel de Icaza <miguel@novell.com>
235 * cs-parser.jay: oob_stack make it static (am guessing that is why
236 we no longer initialize it anymore) and reuse it across
239 2007-01-28 Miguel de Icaza <miguel@novell.com>
241 * cs-parser.jay (open_parens): Introduce new non-terminal that
242 abstracts OPEN_PARENS and OPEN_PARENS_LAMBDA as the later can now
243 be returned in places where types are followed by identifiers
244 (this is expected in declaration, fixed, using, foreach and catch
247 Use open_parens in those places, keep OPEN_PARENS in the
250 cs-parser.jay: New grammar bits for parsing lambda expressions.
252 2007-01-28 Raja R Harinath <rharinath@novell.com>
254 Fix #80534, gtest-309.cs
255 * generic.cs (UnifyType): Rename from InferType. Make unification
256 of generic insts simpler and don't insist on inferring all generic
257 parameters in a single generic inst unification.
259 (InferGenericInstance): Remove.
260 Analysis and initial patch by David Mitchell <dmitchell@logos.com>.
262 2007-01-20 Marek Safar <marek.safar@gmail.com>
264 * cs-parser.jay: Better parameter error handling.
266 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
267 Raja R Harinath <rharinath@novell.com>
269 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
270 Note the order in which accessors are declared in the source.
272 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
274 * generic.cs (TypeParameter.FindMembers): Use the generic
275 constraints, not the constraints to check for methods (first fix
278 2006-12-30 Marek Safar <marek.safar@gmail.com>
280 * cs-parser.jay: Better syntax errors handling.
282 2006-11-21 Marek Safar <marek.safar@gmail.com>
284 * cs-parser.jay: Tiny change to work with mcs tokenizer.
286 * cs-tokenizer.cs: Remove after unification with mcs.
288 2006-10-28 Marek Safar <marek.safar@gmail.com>
291 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
294 2006-10-26 Marek Safar <marek.safar@gmail.com>
297 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
299 2006-10-25 Brian Crowell <brian@fluggo.com>
302 * generic.cs (CheckConstraints): Allow generic parameters with
303 inheritance constraints to satisfy reference type constraints.
305 2006-10-09 Martin Baulig <martin@ximian.com>
308 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
310 2006-09-25 Martin Baulig <martin@ximian.com>
312 * class.cs: Remove after unification with mcs source.
314 2006-09-24 Raja R Harinath <harinath@gmail.com>
316 * convert.cs: Remove after unification with mcs source.
318 2006-09-24 Marek Safar <marek.safar@seznam.cz>
320 * class.cs (MemberBase.VerifyClsCompliance): When method has type
321 parameters verify them as well.
323 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
324 the type parameter constraints.
325 (Generics.VerifyClsCompliance): Ditto.
327 2006-09-24 Marek Safar <marek.safar@seznam.cz>
329 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
330 for anonymous block with out argument.
332 2006-09-24 Marek Safar <marek.safar@seznam.cz>
334 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
335 not used private events only.
337 2006-09-23 Marek Safar <marek.safar@seznam.cz>
339 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
341 * cs-parser.jay: Parse correctly cast of default (T).
343 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
344 Store original type via EmptyConstantCast.
346 2006-09-22 Martin Baulig <martin@ximian.com>
348 * delegate.cs: Removed; this file is now shared with mcs.
350 * attribute.cs: Removed; this file is now shared with mcs.
352 2006-09-22 Martin Baulig <martin@ximian.com>
354 * ecore.cs: Removed; this file is now shared with mcs.
356 2006-09-21 Marek Safar <marek.safar@seznam.cz>
358 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
360 * ecore.cs (NullCast): Derives from NullConstant.
362 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
365 2006-09-21 Martin Baulig <martin@ximian.com>
367 * decl.cs: Removed; this file is now shared with mcs.
369 2006-09-21 Raja R Harinath <rharinath@novell.com>
371 * rootcontext.cs: Remove after unification with mcs source.
373 * report.cs: Remove after unification with mcs source.
374 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
376 (InitGenerics, CleanUpGenerics): Remove.
378 * support.cs: Remove after unification with mcs source.
380 2006-09-20 Raja R Harinath <rharinath@novell.com>
382 * codegen.cs: Remove after unification with mcs source.
384 2006-09-19 Martin Baulig <martin@ximian.com>
386 * expression.cs: Removed; this file is now shared with mcs.
388 2006-09-19 Martin Baulig <martin@ximian.com>
391 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
392 (TypeManager.DropGenericTypeArguments): Likewise.
393 (TypeManager.DropGenericMethodArguments): Likewise.
394 (TypeManager.GetTypeArguments): Likewise.
395 (TypeManager.HasGenericArguments): Likewise.
397 2006-09-19 Martin Baulig <martin@ximian.com>
399 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
401 2006-09-19 Martin Baulig <martin@ximian.com>
403 * typemanager.cs: Removed; this file is now shared with mcs.
405 2006-09-16 Raja R Harinath <rharinath@novell.com>
407 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
408 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
410 2006-09-16 Marek Safar <marek.safar@seznam.cz>
413 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
414 only if parent type is class.
415 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
418 2006-09-15 Marek Safar <marek.safar@seznam.cz>
421 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
423 * typemanager.cs(CSharpName): Converts NullType to null.
425 2006-09-15 Martin Baulig <martin@ximian.com>
427 * pending.cs: Removed; this file is now shared with mcs.
429 2006-09-15 Martin Baulig <martin@ximian.com>
431 * statement.cs: Removed; this file is now shared with mcs.
433 2006-09-15 Martin Baulig <martin@ximian.com>
435 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
437 * driver.cs: Removed the `--broken-cycles' argument.
439 2006-09-15 Martin Baulig <martin@ximian.com>
441 * namespace.cs: Removed; this file is now shared with mcs.
443 2006-09-15 Martin Baulig <martin@ximian.com>
445 * decl.cs (MemberName): Minor code cleanups.
447 2006-09-15 Martin Baulig <martin@ximian.com>
449 * parameter.cs: Removed; this file is now shared with mcs.
451 2006-09-15 Martin Baulig <martin@ximian.com>
453 * enum.cs: Removed; this file is now shared with mcs.
455 2006-09-15 Martin Baulig <martin@ximian.com>
457 * Makefile: Define `GMCS_SOURCE'.
459 * flowanalysis.cs: Removed; this file is now shared with mcs.
461 2006-09-15 Martin Baulig <martin@ximian.com>
463 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
464 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
465 doc.cs - they are now shared with mcs.
467 * gmcs.exe.sources: Include these files from ../mcs/.
469 2006-09-15 Martin Baulig <martin@ximian.com>
471 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
472 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
474 2006-09-14 Marek Safar <marek.safar@seznam.cz>
476 * assign.cs, ecore.cs, expression.cs: Share error message text.
477 * class.cs (FieldMember.Define): Check for variable of static type.
478 * decl.cs (check_type_parameter): Report correct type name.
479 * driver.cs (LoadAssembly): Uses error output for errors.
480 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
481 (TypeArguments.Resolve): Static class cannot be used as an argument.
482 * statement.cs (ResolveMeta): Constants cannot be generic types.
484 2006-09-12 Martin Baulig <martin@ximian.com>
486 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
488 * convert.cs (Convert.Array_To_IList): Moved here and correctly
489 implement it; fixes #79345.
491 2006-09-08 Marek Safar <marek.safar@seznam.cz>
493 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
495 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
497 * generic.cs: Improved error messages.
498 * typemanager.cs (RemoveGenericArity): Made public.
500 2006-09-08 Martin Baulig <martin@ximian.com>
502 * typemanager.cs (TypeManager.interlocked_type): New public field.
503 (TypeManager.int_interlocked_compare-exchange): New public field.
504 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
505 enumerator types here and call InitGenericCoreTypes().
506 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
507 after calling InitEnumUnderlyingTypes().
510 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
511 `classes_second_stage'.
513 2006-09-07 Marek Safar <marek.safar@seznam.cz>
515 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
517 * statement.cs (Block.Variables): Made public.
519 2006-09-07 Martin Baulig <martin@ximian.com>
522 (MainDriver): Revert r62663 from Marek; see #70506 for details.
524 2006-09-01 Martin Baulig <martin@ximian.com>
527 (TypeManager.IsIList): Also handle base classes and interfaces.
529 2006-09-01 Raja R Harinath <rharinath@novell.com>
532 * expression.cs (Invocation.MoreSpecific): Check for reference
535 2006-08-29 Miguel de Icaza <miguel@novell.com>
537 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
539 2006-08-17 Miguel de Icaza <miguel@novell.com>
541 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
542 #52019 and #79064, the use of the \uXXXX sequence in source code
543 to represent unicode characters.
545 2006-08-15 Marek Safar <marek.safar@seznam.cz>
547 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
549 * class.cs, ecore.cs, statement.cs: Merged to one error message.
551 2006-08-14 Raja R Harinath <rharinath@novell.com>
554 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
555 parameter too. This only avoids a parse error -- the semantic
556 error is caught elsewhere.
558 2006-08-13 Miguel de Icaza <miguel@novell.com>
560 * assign.cs: Catch attempts to assign to a method groups in += and
563 2006-08-13 Marek Safar <marek.safar@seznam.cz>
566 * cs-parser.jay: Don't destroy current array type by typeof of array's.
568 2006-08-12 Marek Safar <marek.safar@seznam.cz>
570 * cs-parser.jay: Check whether a constraint clause has already been
571 specified for type parameter.
572 * generic.cs (Constraints): Exposed location.
574 2006-08-12 Marek Safar <marek.safar@seznam.cz>
576 * class.cs (Method.Define): Issue a warning when generic method looks like
578 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
580 * report.cs: New warning number.
582 2006-08-09 Marek Safar <marek.safar@seznam.cz>
584 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
586 * decl.cs (MemberCache.FindMembers): When container is interface we need to
587 search all base interfaces as a member can be ambiguous.
588 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
589 Constructor member type filter.
590 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
591 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
592 reporting for returned memberinfos.
593 * report.cs: Updated.
594 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
595 version to work on all runtimes.
596 (TypeManager.RealMemberLookup): Removed members filtering.
598 2006-08-08 Raja R Harinath <rharinath@novell.com>
600 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
601 (PropertyExpr.EmitAssign): Likewise.
602 * expression.cs (Indirection.EmitAssign): Likewise.
603 (LocalVariableReference.EmitAssign): Likewise.
604 (ParameterReference.EmitAssign): Likewise.
605 (Invocation.EmitArguments): Likewise.
606 (ArrayAccess.EmitAssign): Likewise.
607 (IndexerAccess.EmitAssign): Likewise.
608 (This.EmitAssign): Likewise.
609 (ConditionalLogicalOperator.Emit): Likewise.
612 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
613 instead of ArrayList. If the hashtable has a LocalBuilder, don't
614 leave it in after returning it.
615 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
617 2006-08-06 Marek Safar <marek.safar@seznam.cz>
619 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
622 2006-08-05 Marek Safar <marek.safar@seznam.cz>
624 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
625 with different type names.
626 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
628 2006-08-03 Raja R Harinath <rharinath@novell.com>
630 Fix cs0146-3.cs and cs0146-4.cs.
631 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
632 enclosing types don't depend on the current type.
634 2006-08-02 Raja R Harinath <rharinath@novell.com>
637 * class.cs (TypeContainer.DoDefineMembers): Use
638 FindBaseMemberWithSameName on Parent, since we're interested in
639 whether we hide inherited members or not.
640 (FindBaseMemberWithSameName): Make slightly more robust.
643 * codegen.cs (IResolveContext.GenericDeclContainer): New.
644 (EmitContext): Implement new interface requirement.
645 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
646 * decl.cs (MemberCore): Likewise.
647 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
648 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
649 ec.GenericDeclContainer to check for generic parameters.
650 (SimpleName.DoSimpleNameResolve): Likewise.
651 * generic.cs (TypeParameter.DeclContainer): Remove override.
653 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
654 declspaces for doppelgangers too.
655 (UsingEntry): Implement IResolveContext.
656 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
657 'this' as the resolve context.
658 (LocalAliasEntry): Likewise.
660 Implement parts of #77403
661 * roottypes.cs (RootDeclSpace): New. Used to represent the
662 toplevel declaration space. Each namespace declaration introduces
663 a "partial" root declaretion space.
664 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
665 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
666 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
667 from 'current_namespace.SlaveDeclSpace'.
668 (namespace_declaration): Likewise.
669 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
670 check. It can't happen now.
671 * decl.cs (DeclSpace.LookupType): Likewise.
672 * driver.cs (MainDriver): Sanity check.
674 2006-08-01 Raja R Harinath <rharinath@novell.com>
676 * decl.cs (DeclSpace.FindNestedType): Remove.
677 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
678 LookupTypeContainer to get the container of the nested type.
679 * class.cs (TypeContainer.FindNestedType): Make non-override.
681 2006-07-31 Raja R Harinath <rharinath@novell.com>
683 * decl.cs (DeclSpace.PartialContainer): Move field from ...
684 * class.cs (TypeContainer.PartialContainer): ... here.
685 (TypeContainer.AddBasesForPart): New helper.
686 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
688 * cs-parser.jay (current_class): Convert to DeclSpace.
689 (struct_declaration, interface_declaration, class_declaration):
690 Use AddBasesForPart instead of .Bases directly.
691 * const.cs, iterators.cs: Update to changes.
693 2006-07-28 Raja R Harinath <rharinath@novell.com>
695 * class.cs (TypeContainer.AddMemberType): Rename from
697 (TypeContainer.AddMember): Rename from AddToMemberContainer.
698 (AddTypeContainer): New. Combine AddClassOrStruct and
700 (AddPartial): Update. Add 'is_partial' argument.
701 * roottypes.cs: Update to changes.
702 * cs-parser.jay (push_current_class): New helper for handling
703 current_container and current_class.
704 (struct_declaration, interface_declaration, class_declaration):
707 2006-07-26 Raja R Harinath <rharinath@novell.com>
709 * roottypes.cs: Rename from tree.cs.
711 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
712 * tree.cs (Tree, ITreeDump): Remove types.
713 * rootcontext.cs (tree, Tree): Remove fields.
714 (root, ToplevelTypes): New.
715 * *.cs: Update to rename.
717 * tree.cs (Tree.RecordDecl): Remove.
718 (RootTypes.AddToTypeContainer): Record the toplevel type in its
720 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
722 2006-07-23 Raja R Harinath <harinath@gmail.com>
724 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
725 DoFlowAnalysis and OmitStructFlowAnalysis here.
726 (ec.With): Rename from WithUnsafe and generalize.
727 (ec.WithCheckState): Remove. All users can be handled by 'With'.
728 (ec.WithFlowAnalyis): New.
729 * ecore.cs, expression.cs, statement.cs: Update.
731 2006-07-22 Raja R Harinath <harinath@gmail.com>
733 * statement.cs (Block.ResolveMeta): Simplify slightly.
735 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
736 multiple boolean fields. Convert InUnsafe, constant_check_state,
737 check_state to flags.
738 (CheckState, ConstantCheckState): Update.
739 (InUnsafe): New read-only property.
740 (FlagsHandle): Rename from CheckStateHandle and convert to handle
742 (WithUnsafe): New helper similar to WithCheckState.
743 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
744 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
746 2006-07-21 Raja R Harinath <rharinath@novell.com>
748 Make comparisons use the same IL irrespective of whether they're
749 in a 'checked' or 'unchecked' context: one of the issues in #78899
750 * codegen.cs (EmitContext.CheckState): Make read-only property.
751 (EmitContext.ConstantCheckState): Likewise.
752 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
753 helper that implement a save/restore stack for CheckState
754 values. This is the only way to change check-state.
755 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
756 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
757 (CheckedExpr.EmitBranchable): New forwarding method.
758 (UnCheckedExpr): Likewise.
759 * statement.cs (Block.ResolveMeta): Use WithCheckState.
760 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
761 (Checked.Resolve, checked.DoEmit): Likewise.
763 2006-07-21 Martin Baulig <martin@ximian.com>
765 * generic.cs (TypeManager.InferType): When inferring an array
766 type, also allow IList<T> and ICollection<T>. Fixes #78900.
768 2006-07-21 Martin Baulig <martin@ximian.com>
770 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
771 and allow IList`1 and all its base interfaces.
773 * convert.cs (Convert.ImplicitReferenceConversion): Allow
774 converting from an array-type of T to IList<T>.
776 2006-07-21 Martin Baulig <martin@ximian.com>
778 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
780 2006-07-20 Miguel de Icaza <miguel@novell.com>
782 * anonymous.cs: Cache the resolved anonymous delegate, and return
783 this so that the ResolveTopBlock is only triggered once, not
786 Currently we trigger ResolvetopBlock twice due to a first pass of
787 argument check compatibility, and a second pass that does the
790 2006-07-15 Marek Safar <marek.safar@seznam.cz>
792 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
794 * rootcontext.cs (Reset): Add helper_classes.
796 2006-07-15 Marek Safar <marek.safar@seznam.cz>
799 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
802 2006-07-13 Miguel de Icaza <miguel@novell.com>
804 * statement.cs (Lock): Handle expressions of type
805 TypeManager.null_type specially. Fixes #78770
807 2006-07-08 Marek Safar <marek.safar@seznam.cz>
809 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
812 2006-07-08 Marek Safar <marek.safar@seznam.cz>
814 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
815 for accessors as well.
816 * ecore.cs (EventExpr): Add AccessorTable.
818 2006-07-03 Martin Baulig <martin@ximian.com>
820 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
821 instances of value types.
823 * convert.cs (Convert.ExplicitConversion): Correctly handle
824 object->nullable conversions.
826 2006-07-01 Marek Safar <marek.safar@seznam.cz>
829 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
830 for CS0122 where appropriate.
831 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
833 (Filter): Assembly can be null in the case of top level attributes.
835 2006-06-28 Raja R Harinath <rharinath@novell.com>
838 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
839 no arguments, return 'false': nothing can be inferred.
841 2006-06-25 Marek Safar <marek.safar@seznam.cz>
845 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
846 is done at global level.
848 2006-06-24 Marek Safar <marek.safar@seznam.cz>
850 A fix for #77002, Implemented TypeForwarder support.
852 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
853 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
855 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
856 * typemanager.cs (): Add type_forwarder_attr_type.
858 2006-06-24 Marek Safar <marek.safar@seznam.cz>
860 * report.cs: Add CS0469 warning.
862 2006-06-22 Martin Baulig <martin@ximian.com>
865 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
866 for interfaces; fixes #78686, which is a modification of #78380
867 with interfaces instead of classes.
869 2006-06-21 Martin Baulig <martin@ximian.com>
871 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
872 the `try'-block, so we also report CS0016 etc. there.
874 2006-06-21 Martin Baulig <martin@ximian.com>
876 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
877 handle SetAssigned() and SetMemberIsUsed() for generic types;
880 2006-06-21 Martin Baulig <martin@ximian.com>
883 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
885 2006-06-21 Martin Baulig <martin@ximian.com>
887 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
888 also report CS1686 for parameters.
890 2006-06-21 Martin Baulig <martin@ximian.com>
892 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
893 instead of an error if the value is not implicitly convertible to
894 the switch types; fixes #77964.
896 2006-06-21 Raja R Harinath <rharinath@novell.com>
899 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
900 FieldBuilder is null.
903 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
904 'left' and 'right' before error-checking.
906 2006-06-19 Martin Baulig <martin@ximian.com>
909 (Convert.ImplicitConversionStandard): Cleanup and correctly
910 implement nullable conversions.
911 (Convert.ImplicitStandardConversionExists): Likewise.
912 (Convert.ExplicitConversion): Likewise.
914 2006-06-19 Martin Baulig <martin@ximian.com>
917 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
918 methods; make the ctors protected.
920 2006-06-19 Martin Baulig <martin@ximian.com>
922 Fixed #78380; added gtest-273.cs.
925 (Expression.ResolveAsBaseTerminal): Move the constraint checking
926 into ResolveAsTypeTerminal().
929 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
930 TypeManager.FindMembers() to check for the default ctor.
932 2006-06-18 Marek Safar <marek.safar@seznam.cz>
934 * generic.cs: Fixed NullableInfo accessibility.
936 2006-06-16 Martin Baulig <martin@ximian.com>
939 (Constraints.InflatedConstraints.inflate): Correctly inflate
940 generic types; fixes #78400.
942 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
944 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
946 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
947 (FieldExpr.DoResolve): likewise.
948 (PropertyExpr.InstanceResolve): likewise.
949 (EventExpr.InstanceResolve): likewise.
951 2006-06-15 Martin Baulig <martin@ximian.com>
954 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
955 argument; always allow a `null' label if true.
956 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
957 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
958 we have a `null' label and mark the new `null_target' label;
959 default to the `default' label.
960 (Switch.Resolve): Add support for nullable types. Fixes #78630.
962 2006-06-15 Martin Baulig <martin@ximian.com>
964 * class.cs (Operator.Define): Allow an implicit/explicit operator
965 to convert to/from a nullable value of the enclosing type.
967 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
968 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
971 (Convert.ImplicitStandardConversionExists): Add support for lifted
972 implicit/explicit conversions.
973 (Convert.ImplicitConversionStandard): Likewise.
975 2006-06-13 Martin Baulig <martin@ximian.com>
977 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
978 type arguments and create a ConstructedType if necessary. Fixes #78400.
980 2006-06-04 Marek Safar <marek.safar@seznam.cz>
982 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
983 attribute applicable tests for attribute argument.
985 2006-06-02 Raja R Harinath <rharinath@novell.com>
988 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
989 (Binary.OverloadResolve_PredefinedIntegral): New.
990 (Binary.OverloadResolve_PredefinedFloating): New.
991 (Binary.OverloadResolve_PredefinedString): New.
992 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
993 Follow the standard more closely, and treat numeric promotions in
994 terms of overload resolution.
995 (Binary.CheckShiftArguments): Simplify.
997 2006-06-01 Raja R Harinath <rharinath@novell.com>
999 * flowanalysis.cs (MyBitVector): Simplify representation.
1000 (MyBitVector.Clone): Avoid allocating BitArray.
1001 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
1002 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
1003 (*): Update. Change all references to MyBitVector.And and
1004 MyBitVector.Or to &= and |=.
1006 2006-05-31 Raja R Harinath <rharinath@novell.com>
1008 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
1009 Use bne.un instead of ceq+brfalse.
1012 * typemanager.cs (IsUnmanagedType): Disallow generic types and
1015 2006-05-29 Raja R Harinath <rharinath@novell.com>
1018 * cs-parser.jay (formal_parameter_list): Extend the pattern below
1019 to param arguments too.
1021 2006-05-26 Miguel de Icaza <miguel@novell.com>
1023 * cs-parser.jay: Catch another parsing form for arglist being
1024 followed by other arguments. Fixes #78313.
1026 2006-05-25 Raja R Harinath <rharinath@novell.com>
1029 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
1030 also when one of the operands is a null literal.
1031 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
1032 to improve clarity, and generate slightly better code.
1034 2006-05-24 Raja R Harinath <rharinath@novell.com>
1036 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
1037 checking of out parameters to ...
1038 (FlowBranchingToplevel.Merge): ... here.
1039 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
1040 set, propagate the origin upward, and only complain if there was
1042 (FlowBranchingException.AddContinueOrigin): Likewise.
1043 (FlowBranchingException.AddReturnOrigin): Likewise.
1044 (FlowBranchingException.AddGotoOrigin): Likewise.
1046 2006-05-23 Raja R Harinath <rharinath@novell.com>
1048 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
1049 unreachable, skip it.
1050 (FlowBranchingException.Merge): Always propagate jumps, even if
1051 the finally block renders subsequent code unreachable.
1053 2006-05-18 Raja R Harinath <rharinath@novell.com>
1056 * statement.cs (Goto.Resolve): Move responsibility for resolving
1057 'goto' to FlowBranching.AddGotoOrigin.
1058 (Goto.SetResolvedTarget): New. Callback to set the
1059 LabeledStatement that's the target of the goto.
1060 (Goto.DoEmit): Use Leave instead of Br when crossing an
1061 unwind-protect boundary.
1062 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
1063 LookupLabel and adjust to new semantics.
1064 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
1065 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
1066 Goto.SetResolvedTarget to update target.
1067 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
1068 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
1069 AddBreakOrigin & co. Delay propagation until ...
1070 (FlowBranchingException.Merge): ... this.
1072 * statement.cs (Block.Resolve): Always depend on flow-branching to
1073 determine unreachability. Kill workaround that originally emitted
1074 only one statement after an "unreachable" label (see infloop in
1077 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
1078 This is still "wrong", but anything better would probably need a
1079 multi-pass algorithm.
1080 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
1081 usage vector. Force current usage vector to be reachable, to
1082 optimistically signify backward jumps.
1083 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
1085 (FlowBranchingLabeled.Merge): New. If no backward jump was
1086 detected, return the original salted-away usage vector instead,
1087 updated with appropriate changes. Print unreachable warning if
1089 * statement.cs (Block.Resolve): Don't print unreachable warning on
1090 a labeled statement.
1092 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
1094 * driver.cs: Pass filename without path to AssemblyBuilder's
1095 AddResourceFile. Fixes bug #78407.
1097 2006-05-17 Raja R Harinath <rharinath@novell.com>
1099 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
1100 * flowanalysis.cs (FlowBranchingLabeled): ... here.
1101 (FlowBranching.MergeChild): Overwrite
1102 reachability information from Labeled branchings too.
1104 2006-05-16 Raja R Harinath <rharinath@novell.com>
1106 * statement.cs (Goto.Resolve): Merge jump origins here ...
1107 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
1109 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
1110 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
1111 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
1112 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
1114 * statement.cs (Goto.Resolve): ... not here.
1115 (Goto.Emit): Remove CS1632 check.
1117 2006-05-14 Marek Safar <marek.safar@seznam.cz>
1119 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
1122 2006-05-11 Raja R Harinath <rharinath@novell.com>
1124 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
1125 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
1126 (FlowBranchingException.Label): Likewise.
1128 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
1130 (MyBitVector.Or): Use it to avoid losing information (Count).
1131 (FlowBranching.MergeOrigins): Likewise.
1133 * flowanalysis.cs (UsageVector.IsDirty): Remove.
1134 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
1135 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
1136 (UsageVector.ToString): Simplify.
1137 (UsageVector.MergeSiblings): Move here from ...
1138 (FlowBranching.Merge): ... here.
1139 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
1142 2006-05-10 Raja R Harinath <rharinath@novell.com>
1144 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
1145 null bitvector is treated as all-true.
1147 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
1148 (MyBitVector): Rationalize invariants. 'vector != null' implies
1149 that we have our own copy of the bitvector. Otherwise,
1150 'InheritsFrom == null' implies all inherited bits are true.
1152 2006-05-09 Marek Safar <marek.safar@seznam.cz>
1154 * statement.cs (LocalInfo): Add IsConstant.
1155 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
1156 local variable for constants.
1158 2006-05-09 Raja R Harinath <rharinath@novell.com>
1160 * flowanalysis.cs (MyBitVector.Empty): New.
1161 (MyBitVector): Don't allow InheritedFrom to be null.
1162 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
1163 (UsageVector, FlowBranching): Update to changes.
1165 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
1166 recursion. The 'Parent == null' condition isn't sufficient for
1168 (FlowBranching.AddBreakOrigin): Likewise.
1169 (FlowBranching.AddContinueOrigin): Likewise.
1170 (FlowBranching.AddReturnOrigin): Likewise.
1171 (FlowBranching.StealFinallyClauses): Likewise.
1172 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
1173 (FlowBranching.CheckOutParameters): Likewise.
1174 (FlowBranchingToplevel): Terminate all the above recursions here.
1175 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
1176 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
1178 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
1180 (FlowBranchingToplevel): New. Empty for now.
1181 (FlowBranching.MergeTopBlock): Update.
1182 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
1183 branching for the anonymous delegate.
1184 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
1186 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
1187 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
1188 information at the start of the merge. Reorganize.
1190 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1192 * class.cs (MethodData.Define): Method cannot implement interface accessor.
1194 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1196 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
1197 to newly introduced ctor.
1199 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
1200 message to one place.
1201 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
1204 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1206 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
1208 * ecore.cs (Expression.ResolveAsConstant): Updated.
1210 * statement.cs (ResolveMeta): Updated.
1212 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1214 * cs-parser.jay: __arglist cannot be used in initializer.
1216 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1219 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
1222 2006-05-05 Raja R Harinath <rharinath@novell.com>
1224 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
1225 (LabeledStatement): Add 'name' parameter.
1226 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
1227 (Block.AddLabel): Update to changes.
1228 * cs-parser.jay (labeled_statement): Likewise.
1230 * flowanalysis.cs (BranchingType.Labeled): New.
1231 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
1232 (FlowBranchingLabeled): New. Does nothing for now, but will
1233 eventually handle 'goto' flows.
1234 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
1235 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
1236 that's terminated ...
1237 (Block.Resolve): ... here.
1239 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
1240 (UsageVector.MergeFinallyOrigins): Likewise.
1241 (FlowBranching.InTryOrCatch): Likewise.
1242 (FlowBranching.AddFinallyVector): Likewise.
1243 (FlowBranchingException): Update to changes.
1246 * statement.cs (Return.Resolve): Move error checking to ...
1247 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
1248 (FlowBranchingException): Handle return origins like break and
1250 (FlowBranching.UsageVector.CheckOutParameters): Remove.
1252 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1255 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
1258 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1261 * class.cs (MethodData.Define): Do public accessor check only when method
1262 implements an interface.
1264 2006-05-04 Raja R Harinath <rharinath@novell.com>
1266 Remove special handling of 'break'
1267 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
1268 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
1269 (UsageVector.Break): Remove.
1270 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
1272 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
1274 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
1275 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1277 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1280 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1281 be the interface member.
1283 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1286 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1287 for emitting small (int) values.
1289 2006-05-03 Raja R Harinath <rharinath@novell.com>
1292 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1293 control-flow passes through the 'finally' after merging-in all the
1294 control-flows from 'try' and the 'catch' clauses.
1296 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1297 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1298 always true at the only non-recursive entry point.
1299 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1300 FlowBranchingBreakable.
1301 (FlowBranchingLoop): Remove.
1302 * statement.cs (Return.DoResolve): Update to changes.
1305 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1306 (FlowBranching.CreateBranching): Handle it: create a
1307 FlowBranchingContinuable.
1308 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1309 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1310 except that it handles the 'continue' command.
1311 (FlowBranching.UsageVector.MergeOrigins): Rename from
1313 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1314 except that it overrides AddContinueOrigin.
1315 (FlowBranchingException): Override AddContinueOrigin, similar to
1317 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1318 Create a new branching around the embedded statement.
1319 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1320 control flow after the embedded statement.
1321 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1323 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1324 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1325 FlowBranchingBreakable.
1326 (FlowBranchingSwitch): Remove.
1329 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1330 error reporting to ...
1331 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1332 Rename from 'AddBreakVector'. Add new location argument. Return
1333 a bool indicating whether the 'break' crosses an unwind-protect.
1334 (FlowBranchingException.AddBreakOrigin): Add.
1335 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1336 flowbranching after updating with the effects of the 'finally'
1338 (FlowBranchingBreakable): New common base class for
1339 FlowBranchingLoop and FlowBranchingSwitch.
1341 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1343 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1345 2006-05-02 Raja R Harinath <rharinath@novell.com>
1347 * statement.cs (Do.Resolve): If the loop is infinite, set the
1349 (While.Resolve, For.Resolve): Set a barrier after the embedded
1350 statement. There's no direct control flow that goes from the end
1351 of the embedded statement to the end of the loop.
1352 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1353 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1354 above ensure that the reachability is correctly computed.
1356 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1357 (UsageVector.MergeBreakOrigins): If the current path is
1358 unreachable, treat it as if all parameters/locals are initialized.
1359 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1360 infinite loops before merging-in break origins.
1362 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1363 (Reachability.Reachable): Split part into ...
1364 (Reachability.Unreachable): ... this. Simplify.
1365 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1367 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1368 (Reachability.SetThrowsSometimes): Likewise.
1369 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1370 TriState.Always, use corresponding property.
1371 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1372 (Block.Resolve): Likewise. Remove some redundant checks.
1374 2006-05-02 Raja R Harinath <harinath@gmail.com>
1376 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1377 (Reachability.Meet): Don't bother checking AlwaysThrows --
1378 barrier is always set.
1379 (FlowBranchingBlock.Merge): Likewise.
1381 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1383 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1384 defined, so it's references should also compile only for NET_2_0
1385 (as occurs in mcs version)
1387 2006-05-01 Raja R Harinath <harinath@gmail.com>
1389 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1390 checks for unreachable.
1392 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1395 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1397 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1398 whether field is really assigned.
1400 2006-04-30 Raja R Harinath <harinath@gmail.com>
1402 * flowanalysis.cs (Reachability): Make 4-argument constructor
1404 (Reachability.Meet): Rename from 'And'. Remove static variant.
1405 (Reachability.Always): Rename from the highly misleading
1406 'Reachability.Never'.
1407 (FlowBranching.Merge): Update to changes. Mark an impossible
1408 situation with a 'throw'.
1409 (*): Update to changes.
1411 2006-04-29 Raja R Harinath <harinath@gmail.com>
1413 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1415 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1416 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1417 (*): Update to changes.
1418 * statement.cs: Update to changes.
1420 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1423 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1425 2006-04-28 Raja R Harinath <harinath@gmail.com>
1427 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1430 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1431 argument to two arguments: an usage-vector and a bool. Move call
1432 to FlowBranching.Merge () ...
1433 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1435 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1436 handling of loop and switch reachability to ...
1437 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1439 2006-04-27 Raja R Harinath <harinath@gmail.com>
1441 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1442 handling to FlowBranchingLoop.InLoop.
1443 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1445 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1448 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1449 anonymous method is allowed from AnonymousContainer here.
1451 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1453 2006-04-24 Raja R Harinath <rharinath@novell.com>
1456 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1458 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1461 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1462 (DoubleConstant.Reduce): Ditto.
1464 2006-04-23 Raja R Harinath <rharinath@novell.com>
1466 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1467 Remove 'lvalue_right_side' argument. Move parts to ...
1468 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1469 (LocalVariable.DoResolveLValue): ... these.
1471 2006-04-21 Raja R Harinath <rharinath@novell.com>
1474 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1475 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1476 (LocalVariableReference.DoResolveBase): Use it to implement new
1478 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1479 (Argument.Resolve): Simplify. Move CS1510 check ...
1480 * ecore.cs (Expression.ResolveLValue): ... here.
1481 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1482 (PropertyExpr.DoResolveLValue): Likewise.
1483 (FieldExpr.Report_AssignToReadonly): Likewise.
1484 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1485 LValueMemberAccess or LValueMemberOutAccess on instance depending
1487 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1488 DoResolve as appropriate.
1490 2006-04-20 Raja R Harinath <rharinath@novell.com>
1493 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1494 implicit conversions on 'out' and 'ref' arguments.
1496 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1497 improve clarity. Remove dead code.
1500 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1501 (Catch.Resolve): Resolve VarBlock if it exists.
1503 2006-04-19 Miguel de Icaza <miguel@novell.com>
1505 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1506 twice, this was some residual code, the enumerator was emitted
1507 properly in the two branche of if later.
1511 Thanks to Martin for finding the source of the problem
1513 2006-04-19 Raja R Harinath <rharinath@novell.com>
1515 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1516 cast is never an lvalue.
1517 (Cast.DoResolve, Cast.ResolveRest): Combine.
1518 (Argument.Emit): Simplify slightly. Move 'Expr is
1519 IMemoryLocation' check ...
1520 (Argument.Resolve): ... here.
1521 (Argument.Error_LValueRequired): Remove. Inline into only user.
1523 Simplifications. Fix cs0191-2.cs
1524 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1525 CS1649 and CS1651 to ...
1526 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1527 the actual selection of the error code and message to a lookup
1528 table. Add a dummy return value to simplify callsites.
1529 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1530 readonly fields of other instances of the same type. Move CS0197
1532 * expression.cs (Argument.Resolve): ... here. Simplify code.
1533 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1534 resolution of an out or ref argument. The code simplification
1535 above uses this invariant.
1537 2006-04-18 Raja R Harinath <rharinath@novell.com>
1539 Possibly fix #77752. Fix cs1690-[4-7].cs.
1540 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1541 CheckMarshallByRefAccess. Drop parameter.
1542 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1544 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1546 * report.cs (AllWarnings): Add CS1690.
1547 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1549 (LocalVariableReference.DoResolveBase): Update.
1551 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1553 * class.cs (MethodOrOperator): Moved common parts from method class.
1554 detect obsolete attributes.
1555 (Method.Define): Simplified as it reuses code from base.
1556 (Constructor.ValidAttributeTargets): Fixed issue found during
1558 (Destructor.ValidAttributeTargets): Fixed issue found during
1560 (Operator): Finished refactoring set off by #78020. Operator class is now
1561 ordinary method class.
1563 * anonymous.cs: Updated.
1565 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1567 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1569 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1571 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1572 detect obsolete attributes.
1573 (Method.CreateEmitContext): Moved to MethodOrOperator.
1575 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1578 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1579 customized exception to make crash detection easier.
1580 (MethodOrOperator): Started to work on new base class for methods and
1582 (Method): Derives from MethodOrOperator.
1583 (Constructor.Emit): Emits its own attributes.
1584 (AbstractPropertyEventMethod.Emit): Ditto.
1585 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1587 (Operator.Emit): It's temporary more tricky than should be.
1589 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1591 * report.cs (InternalErrorException): Add ctor with inner exception.
1593 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1596 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1599 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1602 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1605 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1607 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1608 attribute is present and Guid not.
1609 (Interface.ApplyAttributeBuilder): Ditto.
1611 * attribute.cs: Add error message.
1613 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1617 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1618 sources (it's composite) so hold them in extra array as they are used in
1619 Emit phase only. It worked in the previous versions by mistake.
1620 (Attribute.Emit): Emit attribute for more owners when exist.
1622 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1623 it has now different behaviour.
1625 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1627 * constant.cs (Constant.IsDefaultInitializer): New method.
1629 * class.cs: Updated.
1631 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1632 re-initialize default values. It saves KBs almost for every assembly.
1633 Thanks Zoltan for the idea.
1634 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1635 (ArrayCreation.DoResolve): Resolve only once.
1636 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1637 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1639 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1641 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1644 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1646 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1647 in an embedded statement too.
1649 2006-04-01 Raja R Harinath <rharinath@novell.com>
1652 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1656 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1659 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1660 arguments before checking whether a type is reflected or not.
1663 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1664 definition doesn't take part in overload resolution.
1665 (Invocation.IsParamsMethodApplicable): Likewise.
1666 (Invocation.OverloadResolve): When replacing a reflected override
1667 method with its base definition, ensure that type arguments are
1670 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1674 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1677 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1679 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1681 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1684 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1685 LocalTemporary change.
1687 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1689 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1690 initializers optimization.
1691 (ClassOrStruct.TypeAttr): Moved from modifiers.
1692 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1693 (FieldBase.ResolveInitializer): Resolves initializer.
1694 (FieldBase.HasDefaultInitializer): New property.
1696 * cs-parser.jay: Removed message.
1698 * expression.cs (CompilerGeneratedThis): New specialization.
1700 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1702 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1704 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1706 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1708 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1709 be now EnumConstants only.
1711 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1713 * attribute.cs, driver.cs: Reset more caches.
1715 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1717 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1719 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1721 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1722 for easier reuse. Updated all overrides.
1723 (IntegralConstant): New base class for all integral constants.
1724 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1725 of the constant range, report custom error.
1726 (UIntConstant.Reduce): Fixed uint conversion.
1728 * ecore.cs, literal.cs: Reduce updates.
1730 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1734 * class.cs (Constructor.Define): Removed extra if for default ctors.
1735 A patch from Atsushi Enomoto.
1737 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1739 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1740 GetAttributableValue.
1742 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1745 * convert.cs (ImplicitConversionRequired): Error message moved to
1748 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1749 automatic implicit conversion of an output value.
1750 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1752 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1754 (TypeOf.GetAttributableValue): Add extra handling for object type.
1756 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1757 special error message.
1759 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1761 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1763 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1764 compatible with MS runtime.
1766 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1768 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1769 attribute arguments here.
1771 * class.cs (Indexer.Define): The check was moved to attribute class.
1773 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1775 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1777 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1779 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1781 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1784 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1786 * doc-bootstrap.cs : fix build.
1788 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1790 * expression.cs (StringConcat.Append): Issue a warning when empty string
1793 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1795 * assign.cs (CompoundAssign.ResolveSource): Removed.
1797 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1800 * class.cs (TypeContainer.FindMethods): Removed.
1801 (TypeContainer.CheckMemberUsage): Made static.
1803 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1805 * constant.cs (CheckRange): Removed unused type argument.
1806 (CheckUnsigned): Removed unused type argument.
1808 * cs-parser.jay: Updated after MemberAccess clean up.
1809 Uses Length for empty string test.
1811 * cs-tokenizer.cs: Uses Length for empty string test.
1812 (IsCastToken): Made static.
1813 (is_hex): Made static.
1814 (real_type_suffix): Made static.
1816 * decl.cs (SetupCache): Made static.
1817 (OnGenerateDocComment): Removed unused ds argument.
1819 * delegate.cs (VerifyDelegate): Removed unused argument.
1821 * doc.cs: Uses Length for empty string test.
1823 * driver.cs: Uses Length for empty string test.
1825 * enum.cs (IsValidEnumType): Made static
1827 * expression.cs (EnumLiftUp): Removed unused argument.
1828 (ResolveMethodGroup): Ditto.
1829 (BetterConversion): Ditto.
1830 (GetVarargsTypes): Ditto.
1831 (UpdateIndices): Ditto.
1832 (ValidateInitializers): Ditto.
1833 (MemberAccess.ctor): Ditto.
1834 (GetIndexersForType): Ditto.
1836 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1838 * iterators.cs: Updated after MemberAccess clean up.
1840 * location.cs: Uses Length for empty string test.
1842 * namespace.cs: Uses Length for empty string test.
1844 * report.cs (CheckWarningCode): Made static.
1846 * statement.cs (LabeledStatement): Removed unused argument.
1848 * typemanager.cs (FilterNone): Removed.
1850 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1852 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1855 * class.cs: Updated.
1857 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1859 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1861 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1865 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1867 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1868 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1869 Add more error reporting; Fixed issue with params.
1871 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1873 * cs-parser.jay: AnonymousMethod requires host container.
1875 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1877 2006-03-18 Raja R Harinath <harinath@gmail.com>
1879 * class.cs: Change 'TypeContainer ds' constructor argument to
1880 'DeclSpace parent'. Some classes were missed below due to
1881 different naming convention.
1883 * class.cs (MemberCore.Parent): Delete. This makes the
1884 ParentContainer changes below enforceable by the compiler.
1886 Treat pointers to enclosing declaration space as 'DeclSpace', not
1888 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
1889 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
1891 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
1893 (Block.AddThisVariable): Likewise.
1894 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
1895 (AbstractPropertyEventMethod.Emit): Likewise.
1896 (AbstractPropertyEventMethod.EmitMethod): Likewise.
1897 (GetMethod.Define, SetMethod.Define): Likewise.
1898 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
1899 (DelegateMethod.EmitMethod): Likewise.
1901 Fix regression test-partial-13.cs.
1902 Rationalize use of PartialContainer. Ensure that the partial
1903 class semantics can be tied to type-correctness, i.e., any
1904 violation will cause a compile error.
1905 * class.cs, const.cs: Access all fields that belong to class
1906 TypeContainer via ParentContainer. Arguments of EmitContexts and
1907 Resolve()-like functions still use 'Parent'.
1909 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
1910 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
1911 (PropertyMethod.CheckModifiers): Remove unused argument.
1912 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
1915 2006-03-28 Raja R Harinath <rharinath@novell.com>
1917 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
1919 2006-03-17 Raja R Harinath <harinath@gmail.com>
1921 Make semantics of PartialContainer simpler.
1922 * decl.cs (DeclSpace.IsPartial): Remove.
1923 * class.cs (TypeContainer.IsPartial): Likewise.
1924 (TypeContainer..ctor): Set PartialContainer to point to self.
1925 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
1926 (TypeContainer.FindNestedType): Likewise.
1927 (MemberCore.ParentContainer): Simplify. Remove deprecation.
1929 2006-03-17 Marek Safar <marek.safar@seznam.cz>
1931 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
1933 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1935 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
1938 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1940 * class.cs (Operator.Define): An error for base conversion was not
1943 2006-03-13 Marek Safar <marek.safar@seznam.cz>
1945 A fix for #77593, #77574.
1947 * class.cs (MethodCore.CheckBase): Another if for operator.
1949 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1953 * expression.cs (VerifyArgumentsCompat): Reverted to double error
1954 reporting, it's more tricky than I thought.
1956 2006-03-09 Marek Safar <marek.safar@seznam.cz>
1958 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
1961 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
1962 (DelegateCreation.ImplicitStandardConversionExists): New method for just
1965 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
1968 2006-03-04 Marek Safar <marek.safar@seznam.cz>
1972 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
1973 (Event.Define): ditto
1974 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
1976 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
1977 Removed redundant code and set NewSlot for Invoke method too.
1979 * parameter.cs (Parameters.ctor): Add custom, type ctor.
1980 (Parameters.MergeGenerated): New method. Use this method when you merge
1981 compiler generated argument with user arguments.
1983 2006-03-03 Marek Safar <marek.safar@seznam.cz>
1985 * attribute.cs (ResolveAsTypeTerminal): Removed.
1987 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
1988 specialization for predefined types; 30% speed up.
1989 Finally placed obsolete check to right place.
1990 (Expression.ResolveType): Removed.
1992 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
1993 Updated after ResolveType was removed.
1995 * expression.cs (Cast.ctor): Check void cast.
1996 (Binary.ResolveAsTypeTerminal): Is never type.
1997 (Conditional.ResolveAsTypeTerminal): Is never type.
1999 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
2001 2006-03-26 Marek Safar <marek.safar@seznam.cz>
2003 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
2005 2006-03-23 Martin Baulig <martin@ximian.com>
2007 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
2008 type check if either of the types is an open generic type.
2010 2006-03-23 Martin Baulig <martin@ximian.com>
2013 (Convert.ExplicitTypeParameterConversion): New method; implement
2014 explicit type parameter conversions.
2016 2006-03-23 Martin Baulig <martin@ximian.com>
2018 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
2019 blindly allow all conversions if we do not have any constraints.
2021 2006-02-27 Marek Safar <marek.safar@seznam.cz>
2023 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
2024 these two separated members to simplify the code.
2025 (Attribute.Resolve): Refactored to use new fields and methods.
2026 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
2027 implemented obsolete attribute checking.
2028 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
2029 implemented obsolete checking again. It look line never ending quest ;-)
2030 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
2032 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
2034 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
2036 *class.cs (Property.Define): Add RegisterProperty call.
2038 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
2039 argument groups (only 2).
2041 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
2042 encoding expression to arguments.
2043 (Expression.ExprClassToResolveFlags): Just turned to property.
2045 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
2046 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
2047 optimized as well as implemented support for zero-length attributes.
2049 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
2050 Add caching of PropertyInfo's.
2052 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2054 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
2055 error multiple times.
2057 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2059 New partial class implementation.
2060 A fix for #77027, #77029, #77403
2062 * attribute.cs (Attributable): Made attributes protected.
2064 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
2065 the replacements of ClassPart and PartialContainer.
2066 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
2067 (TypeContainer.AddInterface): Ditto.
2068 (TypeContainer.AddPartial): The main method for partial classes. It checks
2069 for errors and merges ModFlags and attributes. At the end class is added to
2071 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
2073 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
2074 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
2075 from the rest of partial classes.
2076 (TypeContainer.GetClassBases): Simplified.
2077 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
2079 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
2080 (TypeContainer.HasExplicitLayout): Uses Flags now.
2081 (PartialContainer): Removed.
2082 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
2083 (StaticClass): Was merged with Class.
2084 (Class.GetClassBases): class and static class bases are verified here.
2085 (Class.TypeAttr): Added static attributes when class is static.
2086 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
2087 (MemberBase): In some cases we need to call parent container for partial
2088 class. It should be eliminated but it's not easy now.
2090 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
2092 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
2093 partial classed to accumulate class comments.
2094 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
2096 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
2098 * driver.cs (MainDriver): Tree.GetDecl was removed.
2100 * modifiers.cs (Modifiers): Add partial modifier.
2102 * tree.cs (Tree.decl): Removed.
2103 (RootTypes): Started to use this class more often for root types
2106 2006-03-23 Raja R Harinath <rharinath@novell.com>
2108 * generic.cs (TypeParameter.UpdateConstraints): Update
2109 'constraints' if null.
2111 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2115 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
2116 external interface does not have an attribute.
2118 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2120 Another prerequisites for new partial classs implementation.
2122 * attribute.cs (Attribute.Equal): Implemented.
2123 (Attribute.Emit): Changed as attributes can be applied more than twice.
2124 (Attributes.Emit): Check for duplicate attributes here.
2126 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
2127 as a parameter, clean-up.
2129 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2133 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
2134 contains obsolete attribute check which can in some cases look for base
2135 type of current class which is not initialized yet.
2136 (TypeContainer.BaseType): Replacement of ptype.
2138 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
2140 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2142 First of prerequisites for new partial classs implemention.
2144 * attribute.cs (Attributable): Extended by ResolveContext;
2145 Attributes finally have correct context for resolving in all cases.
2146 (AttachTo): Attribute owner is assigned here.
2148 * codegen.cs (IResolveContext): Introduce new interface to hold
2149 all information needed in resolving phase.
2150 (EmitContext): Implements IResolveContext; more clean-up needed here.
2152 * decl.cs (MemberCore): Implemented IResolveContext.
2154 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
2155 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
2156 parameter.cs, statement.cs, tree.cs, typemanager.cs:
2157 Refactored to use new IResolveContext instead of EmitContext; cleanup
2159 2006-03-22 Raja R Harinath <rharinath@novell.com>
2161 Support ParameterDefaultValueAttribute in gmcs. Also applied to
2162 mcs to keep code differences small.
2163 * attribute.cs (Attribute.GetParameterDefaultValue): New.
2164 * typemanager.cs (parameter_default_value_attribute_type): New.
2165 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
2168 2006-03-22 Martin Baulig <martin@ximian.com>
2171 (Nullable.NullableLiteral): Derive from `NullLiteral'.
2174 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
2175 instead of the normal `NullLiteral'.
2177 2006-03-21 Martin Baulig <martin@ximian.com>
2180 * generic.cs (TypeManager.InferType): If `pt' is a generic
2181 parameter, don't check whether `pt == at'.
2183 2006-03-20 Raja R Harinath <rharinath@novell.com>
2186 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
2187 (TypeParameter.Resolve): Update to change.
2188 (ConstraintChecker.CheckConstraints): Resolve type-argument
2189 constraints before use.
2191 2006-03-16 Martin Baulig <martin@ximian.com>
2194 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
2195 and don't have any instance constructors, also lookup in the base class.
2196 (TypeManager.IsNullableValueType): New public method.
2198 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
2199 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
2200 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
2202 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
2203 instead of just TypeManager.IsNullableType() to determine whether
2204 a lifted operator exists.
2205 (UnaryMutator.DoResolve): Likewise.
2206 (Conditional.DoResolve): Likewise.
2207 (Binary.DoResolve): A lifted operator only exists if both operands
2208 are valuetypes and at least one of them is a nullable type.
2210 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
2212 * iterator.cs : yield break is allowed in try statement which has
2213 catch clauses. Fixed bug #77767.
2215 2006-03-12 Martin Baulig <martin@ximian.com>
2217 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
2218 private IsSignatureEqual() to compare types; see the comment in
2219 that method; fixes #77674.
2221 2006-03-10 Raja R Harinath <rharinath@novell.com>
2223 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
2224 (Expression.ResolveAsTypeTerminal): Likewise.
2225 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
2226 * expression.cs, generic.cs, iterators.cs: Likewise.
2227 * parameter.cs, statement.cs, typemanager.cs: Likewise.
2229 2006-03-09 Martin Baulig <martin@ximian.com>
2231 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
2232 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
2234 2006-03-09 Martin Baulig <martin@ximian.com>
2236 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
2237 `prepared' flag is set.
2239 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
2240 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
2241 issues; see gtest-254.cs.
2243 2006-03-07 Martin Baulig <martin@ximian.com>
2245 * generic.cs (TypeManager.InferType): Allow infering
2246 `IEnumerable<T>' with an array of T; see gtest-251.cs.
2248 2006-03-06 Martin Baulig <martin@ximian.com>
2251 (TypeManager.InferType): Fix gtest-250.cs.
2254 (TypeManager.IsSubclassOf): Also check the base class.
2257 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
2260 2006-03-01 Raja R Harinath <rharinath@novell.com>
2263 * expression.cs (ParameterReference.DoResolveBase): Change return
2265 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
2269 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
2272 * typemanager.cs (GetFullNameSignature): Don't nullref on
2273 protected accessors.
2275 2006-02-16 Martin Baulig <martin@ximian.com>
2278 (TypeManager.GetGenericFieldDefinition): New public method; use it
2279 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2281 2006-02-14 Martin Baulig <martin@ximian.com>
2283 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2285 2006-02-14 Martin Baulig <martin@ximian.com>
2288 (TypeManager.DropGenericMethodArguments): New public method; don't
2289 use GetGenericMethodDefinition() on something which is not a
2292 2006-02-14 Martin Baulig <martin@ximian.com>
2295 (ConstraintChecker.CheckConstraints): If a type parameter has the
2296 `struct' constraint, the type must be a non-nullable valuetype.
2298 2006-02-10 Martin Baulig <martin@ximian.com>
2301 (TypeManager.IsOverride): Make this work for instantiated methods
2302 in a generic class; fixes #77509.
2303 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2304 rather than calling it directly; fixes #77488.
2306 2006-02-08 Martin Baulig <martin@ximian.com>
2308 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2309 reporting into CheckConstraint() so we can use the correctly
2312 2006-02-08 Martin Baulig <martin@ximian.com>
2314 * expression.cs (BaseAccess): Add support for generic methods.
2316 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2317 the new MethodGroupExpr.
2319 2006-02-07 Martin Baulig <martin@ximian.com>
2321 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2322 also reference types; fixes #77483.
2324 2006-02-07 Martin Baulig <martin@ximian.com>
2327 (TypeManager.IsGenericMethod): We now return whether something is
2328 an instantiated generic method (and not a generic method def).
2329 (TypeManager.IsGenericMethodDefinition): New public method.
2332 (TypeManager.CSharpSignature): Only include type arguments for
2333 "real" generic methods, not for any instantiated method.
2334 (TypeManager.GetMethodName): Likewise, but also allow generic
2335 method definitions here.
2337 2006-02-06 Miguel de Icaza <miguel@novell.com>
2339 * codegen.cs (EmitScopeInitFromBlock): check here the
2340 capture_context, there is no need to make two calls to the
2343 * anonymous.cs: Add some debugging messages that might help me
2344 track other instances of this problem in the future (the
2345 regression of test 467).
2347 * cs-parser.jay: track the variable block, as we need to initalize
2348 any captured variables declared in this block for the "catch"
2349 portion of the "Try" statement.
2351 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2352 scope initialization for captured variables.
2354 Also, move the emit for the variables after the block location has
2357 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2359 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2361 2006-02-06 Martin Baulig <martin@ximian.com>
2363 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2364 `TypeManager.value_type' as parent type to
2365 ModuleBuilder.DefineType(). Fixes #77358.
2367 2006-02-02 Miguel de Icaza <miguel@novell.com>
2369 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2370 commit yesterday, the initialization for the roots is necessary.
2371 What is not necessary is the scope activation.
2373 2006-02-02 Raja R Harinath <rharinath@novell.com>
2375 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2376 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2378 (Argument.Resolve): Remove CS0206 checks.
2380 2006-02-01 Miguel de Icaza <miguel@novell.com>
2382 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2383 scopes for all the roots, the scopes will now be emitted when the
2384 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2386 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2387 code. This reduces a lot of existing cruft.
2389 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2390 that the ScopeInfo is generated as we enter the scope, not at the
2391 time of use, which is what we used to do before.
2393 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2394 every time a Block is about to be emitted if we have a
2397 2006-02-01 Raja R Harinath <rharinath@novell.com>
2399 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2400 attribute for mscorlib too.
2402 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2404 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2406 * typemanager.cs (cons_param_array_attribute): Make private.
2407 (Reset): Set it to null.
2408 (InitCoreHelpers): Don't initialize it.
2409 (ConsParamArrayAttribute): New. Initialize it as needed.
2410 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2412 2006-01-31 Miguel de Icaza <miguel@novell.com>
2414 * expression.cs: There might be errors reported during the
2415 selection of applicable methods. If there are errors, do not
2416 continue execution as it will lead the compiler to crash.
2418 2006-01-30 Miguel de Icaza <miguel@novell.com>
2420 * expression.cs: Member access is not allowed on anonymous
2421 methods. Fixes #77402.
2423 2006-01-30 Raja R Harinath <rharinath@novell.com>
2426 * cs-parser.jay (VariableDeclaration): Don't set
2427 current_array_type to null.
2428 (field_declaration, event_declaration, declaration_statement):
2429 Set it to null here.
2431 2006-01-29 Raja R Harinath <harinath@gmail.com>
2434 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2436 2006-01-28 Raja R Harinath <harinath@gmail.com>
2438 * typemanager.cs (GenericParameterPosition): New.
2441 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2443 * doc.cs : To process "include" elements, first we should create
2444 another list than XmlNodeList, because it could result in node
2445 removal, which could result in that the XmlNodeList gives up
2448 2006-01-25 Miguel de Icaza <miguel@novell.com>
2450 * expression.cs: Introduce an error report that we were not
2451 catching before. Gonzalo ran into it.
2453 2006-01-23 Miguel de Icaza <miguel@novell.com>
2455 A fix for bug: #76957
2457 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2458 ComputeMethodHost before creating the method, this is a new
2461 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2462 that this method references (RegisterScope). The actual scope
2463 where the method is hosted is computed with the ComputeMethodHost
2464 before we create the method.
2466 Moved the Deepest routine here.
2468 (AnonymousContainer.ComputeMethodHost): New routine used to
2469 compute the proper ScopeInfo that will host the anonymous method.
2471 (ScopeInfo): Deal with multiple roots. The problem was that we
2472 did not have a unique root where all ScopeInfos could be hanged
2473 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2476 Remove AdjustMethodScope which is now computed at the end. Remove
2477 LinkScope which did a partial link, instead link all ScopeInfos
2478 before code generation from the new "LinkScopes" routine.
2480 Simplify all the Add* routines as they no longer need to maintain
2481 the tree, they just need to record that they are using variables
2484 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2485 routines to produce the forest of ScopeInfo trees.
2487 * class.cs (TypeContainer.AppendMethod): This is just like
2488 AddMethod, but ensures that an interface implementation method
2489 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2490 methods, but at the end.
2492 We use this functionality to ensure that the generated MoveNext
2493 method in the iterator class is resolved/emitted before the
2494 enumerator methods created.
2496 This is required because the MoveNext method computes the right
2497 ScopeInfo for the method. And the other methods will eventually
2498 need to resolve and fetch information computed from the anonymous
2502 2006-01-23 Raja R Harinath <rharinath@novell.com>
2504 Improve implementation of section 14.4.2.2 (Better function member).
2505 * expression.cs (Invocation.MoreSpecific): Compare all type
2506 arguments before deciding if one type is more specific than
2507 another. Handle array types too. Return the more specific type.
2508 (Invocation.BetterFunction): Add more tie-breaking rules from
2509 section 14.4.2.2. Perform "more specific" check after
2510 other tie-breaking rules. Compare all parameter types before
2511 choosing the "more specific" method.
2513 2006-01-21 Raja R Harinath <harinath@gmail.com>
2514 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2517 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2519 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2520 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2522 2006-01-18 Martin Baulig <martin@ximian.com>
2524 * class.cs (TypeContainer.AddToMemberContainer): Use
2525 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2528 2006-01-18 Martin Baulig <martin@ximian.com>
2530 Fix #76417: a generic class may now have methods which may unify
2531 for some type parameter substitutions.
2533 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2534 for methods which may unify anymore.
2536 * expression.cs (Invocation.MoreSpecific): New private static
2537 method; checks whether one method is more specific than another
2538 according to 14.4.2.2 of the spec.
2539 (Invocation.BetterFunction): Implement the tie-breaking rules from
2540 14.4.2.2 of the spec: if two methods unify for some type parameter
2541 substitution, we need to pick the more specific one.
2543 2006-01-18 Raja R Harinath <rharinath@novell.com>
2545 Fix #76656, cs0231-2.cs.
2546 * cs-parser.jay (formal_parameter_list): Make error case catch
2548 (parenthesized_expression_0): Add CS1026 check.
2549 (invocation_expression): Remove unused { $$ = lexer.Location }.
2551 2006-01-17 Raja R Harinath <rharinath@novell.com>
2554 * cs-parser.jay (statement_expression): Don't list out the
2555 individual statement-expressions. Convert syntax error into
2558 2006-01-16 Raja R Harinath <rharinath@novell.com>
2561 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2562 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2563 CheckIntermediateModification.
2564 (FieldExpr.DoResolve): Add new two-argument version that
2565 allows us to resolve the InstanceExpression as an lvalue.
2566 The one-argument variant is now just a wrapper.
2567 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2568 Resolve the lhs as an lvalue if the it has a value type.
2569 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2570 from Assign.DoResolve.
2571 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2572 resolved as an lvalue.
2573 (PropertyExpr.DoResolve): Update.
2574 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2575 has a value type. Move CS1612 check here from
2576 CheckIntermediateModification.
2577 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2578 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2579 'right_side' of a ResolveLValue on an 'out' argument.
2580 (EmptyExpression.LValueMemberAccess): New. Used as the
2581 'right_side' of a propagated ResolveLValue on a value type.
2582 (LocalVariableReference.DoResolveBase): Recognize
2583 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2585 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2586 EmptyExpression.Null.
2588 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2590 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2591 Type.IsGenericParameter(). Fixed bug #77183.
2592 * doc.cs : it is now identical to doc.cs in mcs.
2594 2006-01-16 Martin Baulig <martin@ximian.com>
2596 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2598 2006-01-16 Martin Baulig <martin@ximian.com>
2600 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2601 ctors; fixes #77250.
2603 2006-01-12 Miguel de Icaza <miguel@novell.com>
2605 This fixes the problem where we used ldfld instead of ldflda to
2606 load the "THIS" pointer on captured parameters, when THIS is a
2607 value type. See bug #77205.
2609 * iterators.cs (CapturedThisReference.Emit): Pass false to
2610 EmitThis (we do not need the address).
2612 * codegen.cs (EmitThis): it needs to know whether we need the
2613 address of `this' or not. This is used by value types.
2615 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2616 every other call passes false.
2618 2006-01-12 Raja R Harinath <rharinath@novell.com>
2621 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2623 * expression.cs (Invocation.OverloadResolve): Update.
2624 (Invocation.DoResolve): Avoid double resolution of invocation.
2626 2006-01-11 Raja R Harinath <rharinath@novell.com>
2629 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2630 unary negation of floating point types as 0-expr; negation cannot
2631 overflow in floating point types.
2634 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2635 on operands of 'void' type.
2638 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2639 and ExclusiveOr for boolean constants too.
2641 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2643 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2645 2006-01-12 Miguel de Icaza <miguel@novell.com>
2647 * cs-tokenizer.cs (Position): New class used to save and restore
2648 the position state in the tokenizer. Before this patch the save
2649 and restore was not complete enough so the line and columns would
2650 start to drift and the debugger and stack traces will get the
2653 2006-01-10 Martin Baulig <martin@ximian.com>
2656 (TypeParameter.InflateConstraints): New public method.
2658 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2659 constraints; fixes #77042.
2661 2006-01-10 Martin Baulig <martin@ximian.com>
2663 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2664 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2667 2006-01-09 Raja R Harinath <rharinath@novell.com>
2670 * expression.cs (Invocation.OverloadResolve): Replace reflected
2671 override methods with their base virtual methods, rather than
2673 * typemanager.cs (TypeManager.GetOverride): New.
2675 2005-12-21 Miguel de Icaza <miguel@novell.com>
2677 * driver.cs: Report the case of no source files and no -out:
2680 2005-12-20 Raja R Harinath <rharinath@novell.com>
2683 * expression.cs (ComposedCast.GetSignatureForError): Define.
2685 2006-01-05 Jb Evain <jbevain@gmail.com>
2687 * class.cs (Property.Define, Indexer.Define): do not tag the
2688 properties as SpecialName | RTSpecialName.
2690 2006-01-04 Miguel de Icaza <miguel@novell.com>
2692 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2693 doing a low-level comparission of parameter types. It was lacking
2694 a check for __argslist.
2696 2005-12-30 Miguel de Icaza <miguel@novell.com>
2698 * expression.cs (ParameterReference.DoResolveBase): Allow
2699 reference parameters if they are local to this block.
2701 This allows the ref and out parameters of a delegate to be used in
2702 an anonymous method, for example:
2704 delegate void set (out int x);
2706 set s = delegate (out int x){
2710 This is used by functionality introduced late in the C# language.
2712 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2713 method that take ref and out parameters.
2715 Fixes #77119 which was a late change in the spec.
2717 2005-12-23 Miguel de Icaza <miguel@novell.com>
2719 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2720 parent if its the same scope. Fixes #77060.
2722 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2724 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2726 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2728 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2729 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2730 that doesn't contain the full public key. This is a update of the
2731 friend assemblies in .Net 2.0 release.
2733 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2737 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2738 ListDictionary, to contain the ExternAliasEntry entries (in
2739 addition to the NamespaceEntry.aliases hashtable). This field is
2740 shared between the original entry and its doppelganger (bodyless
2742 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2743 extern_aliases field.
2744 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2745 lookup in extern_aliases.
2747 2005-12-16 Raja R Harinath <rharinath@novell.com>
2750 * class.cs (TypeContainer.Mark_HasEquals): New.
2751 (TypeContainer.Mark_HasGetHashCode): New.
2752 (ClassPart): Override them.
2753 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2755 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2756 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2760 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2761 'parent' argument to the base constructor.
2763 Remove all mention of TypeContainer from decl.cs.
2764 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2765 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2766 (DeclSpace.DeclSpace): Likewise.
2767 (DeclSpace.DefineMembers): Remove unused argument.
2768 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2769 debugging check -- we don't care if the debug code throws an
2770 InvalidCastException instead of an InternalErrorException.
2771 * class.cs (TypeContainer.DefineMembers): Update to changes.
2772 (TypeContainer.DoDefineMembers): Likewise.
2773 (TypeContainer.GetMethods): Likewise.
2774 (PropertyMember.Define): Likewise.
2775 (MemberBase.Parent): New property that forwards to
2776 MemberCore.Parent, but ensures that we get a TypeContainer.
2777 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2778 (RootContext.PopulateTypes): Likewise. Remove special case code
2779 for !RootContext.StdLib: DefineMembers is idempotent.
2781 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2783 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2785 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2787 * doc.cs : The search for referenced namespace was insufficient to
2788 get global one as it used to do. Fixed bug #76965.
2790 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2792 * doc.cs : check name in cref in the last phase that whether it is
2795 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2797 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2800 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2802 * doc.cs : so it turned out that we cannot skip override check for
2803 interface members. Fixed bug #76954.
2805 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2807 * cs-tokenizer.cs : fixed bug #75984:
2808 - #warning and #error should not be handled when the source line
2810 - #line is not checked strictly when the source line is disabled.
2811 - #define and #undef is on the other hand checked strictly at any
2814 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2816 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2819 2005-12-15 Raja R Harinath <rharinath@novell.com>
2821 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2823 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2826 2005-12-14 Martin Baulig <martin@ximian.com>
2828 * typemanager.cs (TypeManager.GetFullName): Make this public;
2829 `Type.Fullname' now never returns null.
2831 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2832 explicit interface implementations; we're now using the same
2833 naming convention than csc does.
2835 2005-12-14 Miguel de Icaza <miguel@novell.com>
2837 * convert.cs (ExplicitConversionCore): Check the return value from
2838 ExplicitConversionCore which can return null on failure. Fixes #76914
2840 2005-12-09 Raja R Harinath <rharinath@novell.com>
2842 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2843 instead of IsGenericInstance.
2844 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2845 code that's now covered by the more general test.
2846 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2848 * generic.cs (DropGenericTypeArguments): New. Captures the common
2849 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2850 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2851 * generic.cs, report.cs, typemanager.cs: Likewise.
2853 2005-12-08 Martin Baulig <martin@ximian.com>
2855 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2857 * typemanager.cs (TypeManager.CSharpSignature): Include type
2858 arguments in the signature of a generic method.
2860 2005-12-07 Martin Baulig <martin@ximian.com>
2862 Add support for custom attributes on type parameters.
2864 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2866 * generic.cs (TypeParameterName): New public class; we use this
2867 instead of a `string' to store the name of a type parameter, so we
2868 can also have `Attributes'.
2869 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2870 array instead of a `string[]' array.
2871 (TypeParameter.ctor): We now also take an `Attributes' argument.
2872 (TypeParameter.EmitAttributes): New public method; emit our
2873 `OptAttributes' here.
2874 (GenericMethod.EmitAttributes): New public method; emit the custom
2875 attributes on all our type parameters.
2877 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2878 our type parameters.
2879 (MethodData.Define): If we're a generic method, call
2880 EmitAttributes() on it.
2882 2005-12-07 Martin Baulig <martin@ximian.com>
2885 (ConstraintChecker): New public abstract class; move the
2886 constraint checking here from `ConstructedType' and also do
2887 constraint checking for generic methods here.
2889 * expression.cs (Invocation.OverloadResolve): Use
2890 ConstraintChecker.CheckConstraints() if we resolved to a generic
2893 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2895 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
2897 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
2899 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
2900 (FieldBase.Initializer): Initializer is now optional.
2901 (EventField.Define): Only event field can have initializer.
2903 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
2905 * const.cs (Const): Reuse initializer.
2907 * cs-parser.jay: Updated after FieldBase changes.
2908 Added current_array_type to simplify array initializers.
2910 * ecore.cs (NullCast.IsDefaultValue): Implemented.
2912 * expression.cs, iterators.cs: Updated.
2914 * namespace.cs (NamespaceEntry): Made UsingFound private.
2916 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2918 * parameterCollection.cs: Obsolete, removed.
2919 * parser.cs: Obsolete, removed.
2921 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2924 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
2926 * enum.cs (Enum.Define): Set obsolete context here.
2928 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2931 - FindDocumentedMember() now expects 1) paramList as null
2932 when "we don't have to check the number of parameters" and
2933 2) Type.EmptyTypes when "there is no arguments".
2934 - Introduced FoundMember struct to hold the exact type which was
2935 used to find the documented member (the above change broke
2936 test-xml-044; it might be better just to use DeclaringType than
2937 what MS does, like this change does, but it depends on usage.)
2939 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2941 * doc.cs : documented member might be from DeclaringType for nested
2942 types. Fixed bug #76782.
2944 2005-12-03 Ben Maurer <bmaurer@ximian.com>
2946 * anonymous.cs: Have the param code handle leaving copies on the
2947 stack etc. Allows anonymous params to take part in the assignment
2948 code (++, +=, etc). Fixes bug #76550
2950 * expression.cs: Handle the prepare_for_load/leave_copy by passing
2951 it down to the anon code.
2953 * iterators.cs: Use dummy var here
2955 * codegen.cs: Handle new vars
2957 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2960 * class.cs (MethodData.Define): Set proper Obsolete context.
2962 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
2964 (FieldExpr.DoResolve): Ditto.
2966 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2969 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
2970 parent is not obsolete.
2972 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
2974 * doc.cs : (FindDocumentedMember) find parameterless members first
2975 and get CS0419 in the early stage. Fixed first case of bug #76727.
2977 2005-11-30 Marek Safar <marek.safar@seznam.cz>
2980 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
2981 no error was reported.
2983 *expression.cs (Binary.DoResolve): left can be null.
2985 2005-12-06 Raja R Harinath <rharinath@novell.com>
2987 * class.cs (MethodCore.CheckGenericOverride): Delete unused
2988 abstract method and all overrides.
2989 * support.cs (ParameterData.GenericConstraints): Delete.
2990 (ReflectionParameters.type_params): Delete.
2991 (ReflectionParameters.ReflectionParameters): Make private.
2992 (ReflectionParameters.GetConstaints): New factory method.
2993 * generic.cs (TypeParameterDefineType): Use it.
2994 (TypeManager.GetTypeParameterConstraints): Likewise.
2996 2005-11-22 Marek Safar <marek.safar@seznam.cz>
2999 * class.cs (MethodData.Emit): Parameters should be labeled first.
3001 2005-11-21 Marek Safar <marek.safar@seznam.cz>
3004 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
3006 2005-11-18 Marek Safar <marek.safar@seznam.cz>
3008 * attribute.cs (AreParametersCompliant): Moved to Parameter.
3010 * class.cs (MethodCore): Parameter clean up.
3011 (IMethodData): Added ParameterInfo.
3012 (MethodData): Parameter clean up.
3013 (Indexer.Define): Parameter clean up.
3025 * typemanager.cs: Parameter clean up.
3027 * delegate.cs (Define): Get rid of duplicated code.
3029 * expression.cs (ParameterReference): Removed useless parameters
3031 (Invocation): Ditto.
3033 * parameter.cs (ParamsParameter): New class, params specialization.
3034 (ArglistParameter): Attemp to separate arglist.
3035 (Parameter): Refactored to be reusable and faster.
3036 (Parameter.Modifier): Made understandable.
3037 (Parameters): Changed to be used as a class for `this' assembly
3038 parameters. Refactored to use new specialized classes.
3040 * support.cs (ParameterData): Added Types property.
3041 (InternalParameters): Deleted.
3043 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3045 * doc.cs : the previous patch does not actually fix the bug.
3046 PropertyInfo override check is now implemented and really fixed it.
3047 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
3049 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3051 * doc.cs : apply "override filter" also to properties.
3054 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3056 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
3057 no need to check overrides. For classes, omit those results from
3058 interfaces since they must exist in the class. Fixed bug #76726.
3060 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3062 * typemanager.cs : (GetFullNameSignature) differentiate indexers
3063 with different parameters. Fixed the second problem in #76685.
3065 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3067 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
3068 get expected 'protected' access in CheckValidFamilyAccess()).
3071 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3073 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
3074 Fixed bug #76705. CS1569 was incorrectly commented out.
3076 2005-11-23 Martin Baulig <martin@ximian.com>
3078 * generic.cs (Constraints.Define): Removed.
3079 (TypeParameter.DefineConstraints): Removed.
3080 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
3081 on the GenericTypeParameterBuilder here.
3083 2005-11-23 Martin Baulig <martin@ximian.com>
3085 * typemanager.cs (TypeManager.GetProperty): Make this public.
3087 * generic.cs (Nullable.NullableInfo.ctor): Use
3088 TypeManager.GetProperty() rather than using reflection directly.
3090 2005-11-17 Martin Baulig <martin@ximian.com>
3092 * expression.cs (Indexers.GetIndexersForType): Added support for
3093 generic parameters; fixes #76587.
3095 2005-11-17 Martin Baulig <martin@ximian.com>
3098 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
3099 inherit the scope from our parent. Fixes #76653.
3101 2005-11-15 Martin Baulig <martin@ximian.com>
3103 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
3104 instead of `ScopeTypeBuilder' to refer to the "current" type.
3105 (AnonymousMethod.CreateScopeType): Correctly create the helper
3106 class if we're inside a generic type definition.
3108 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3110 * doc.cs : use Invocation.IsOverride() to do real override check.
3111 * expression.cs : made Invocation.IsOverride() internal.
3113 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3115 * doc.cs : use TypeManager.FindMembers() instead of (possible)
3116 TypeBuilder.FindMembers() and filter overriden base members out.
3119 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3121 * doc.cs : ref/out parameters are represented as '@' (instead of
3122 '&' in type FullName). Fixed bug #76630 (additionally crefs).
3124 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3126 * doc.cs : when there was no '.' in cref to methods in doc comment,
3127 then parameters were missing in the output. Fixed bug #76691.
3129 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3131 * driver.cs : don't output docs when there is an error.
3134 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3137 Now it should detect indexers. Fixed primary concern in bug #76685.
3138 Fixed CS0419 message to not show the identical member signature in
3141 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3143 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
3144 instead of Type.FindMembers() since it does not handle events.
3147 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
3149 * codegen.cs: Fixed typo (speficied -> specified).
3151 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3154 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
3156 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3158 * attribute.cs: Changed error message.
3160 * cs-tokenizer.cs: One more check.
3162 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3164 * statement.cs (Block.Resolve): Ignore empty statement.
3166 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3168 * report.cs: Made error/warning methods more strict to avoid
3171 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
3172 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
3173 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
3174 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
3176 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3178 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
3179 Use the more explicit AssemblyName.FullName instead of
3180 AssemblyName.Name to report errors.
3182 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3184 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
3187 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3197 * report.cs: Fixed error reporting and typos.
3199 * generic.cs (TypeParameter.GetSignatureForError): New method.
3200 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
3202 * typemanager.cs (GetFullName): Refactored.
3204 2005-11-08 Marek Safar <marek.safar@seznam.cz>
3206 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
3207 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
3209 * class.cs (TypeContainer.IsComImport): New property.
3210 (Constructor.Define): Create proper ctor for ComImport types.
3212 * expression.cs (New.CheckComImport): Fixed.
3214 2005-11-07 Miguel de Icaza <miguel@novell.com>
3216 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
3217 that a parameter has been captured does not mean that we do not
3218 have to do the rest of the processing. This fixes the second part
3219 of #76592. If there was another anonymous method capturing
3220 values in the past, the Scope would never be set for the second
3221 method that captured the same parameter.
3223 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
3224 properly manipulate the stack. Second part of fix for #76592.
3226 * expression.cs (New): Add support for invoking "new" on
3227 interfaces that have been flagged with the ComImport attribute and
3228 the CoClass. Fixes #76637
3230 * statement.cs (Try.DoEmit): When a variable is captured, do not
3231 try to emit the vi.LocalBuilder variable as it has been captured.
3232 Create a temporary variable and store the results on the
3233 FieldBuilder. Fixes #76642
3235 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3237 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
3239 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
3241 * expression.cs (Binary.DoResolve): Added && optimalization.
3243 * typemanager.cs (AddUserType): Removed useless argument.
3245 2005-11-04 Marek Safar <marek.safar@seznam.cz>
3247 * statement.cs (Block.variables): Uses ListDictionary.
3249 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3252 * class.cs (PartialContainer.EmitType): Customized to emit
3253 security attributes.
3254 (ClassPart.ApplyAttributeBuilder): Transform security attribute
3255 for partial classes.
3257 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3260 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
3261 access has to be fixed.
3263 * typemanager.cs (IsUnmanagedType): Wrong common field type.
3265 2005-11-01 Marek Safar <marek.safar@seznam.cz>
3268 * ecore.cs (NullCast.Reduce): Implemented.
3270 * expression.cs (ArrayCreation.CheckIndices): Correcly check
3273 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
3275 (Foreach.Resolve): Catch null properly.
3277 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3279 * cs-tokenizer.cs: Warning text fix.
3281 * driver.cs: AllWarningNumbers exposed on public interface.
3283 * report.cs (): Reviewed warning numbers.
3284 (IsValidWarning): Use binary search.
3286 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3288 * driver.cs: Implemeted resource visibility.
3289 (Resources): New class for code sharing between /res: and
3292 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3294 decl.cs (CurrentTypeParameters): Fixed to be public.
3296 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3298 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3300 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3302 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3304 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3306 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3308 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3310 Add friend assembly access support.
3311 * typemanager.cs: assembly_internals_vis_attrs
3312 cache for friend assembly access.
3313 (TypeManager.IsFriendAssembly): New method for
3314 checking friend assembly access.
3315 (TypeManager.Error_FriendAccessNameNotMatching): New
3317 (TypeManager.CompareKeyTokens): Likewise.
3318 (TypeManager.Filter): Handle friend accessible
3321 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3322 friend accessible types.
3324 * ecore.cs (Expression.IsAccessorAccessible): Handle
3325 friend accessible properties.
3327 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3330 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3333 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3336 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3339 * ecore.cs (NullCast): Child is contant only.
3341 * literal.cs (NullLiteral.Reduce): null can be converted to any
3344 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3346 * driver.cs: Use Encoding.Default as default code page instead
3349 2005-10-27 Raja R Harinath <rharinath@novell.com>
3352 * expression.cs (Invocation.Error_InvalidArguments): Handle
3353 __arglist parameters.
3354 (Invocation.VerifyArgumentsCompat): Likewise.
3355 * support.cs (ReflectionParameters.GetSignatureForError): Print
3356 __arglist parameters.
3357 (InternalParamters.GetSignatureForError): Likewise.
3358 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3360 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3362 * attribute.cs (GetPropertyValue): Made public.
3364 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3366 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3368 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3371 * driver.cs: Reflect method name change.
3373 * statement.cs (Try.Resolve): Warn when try has both general
3376 * typemanager.cs: runtime_compatibility_attr_type new predefined
3379 2005-10-26 Raja R Harinath <harinath@gmail.com>
3382 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3383 treat it as an empty parameter list.
3385 2005-10-26 Raja R Harinath <rharinath@novell.com>
3388 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3389 ResolveAsTypeStep silent.
3390 * statement.cs (Block.AddConstant): Mark block as used.
3391 (Block.ResolveMeta): Avoid piling on error messages
3392 if a constant initializer resolution fails.
3394 2005-10-25 Raja R Harinath <rharinath@novell.com>
3396 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3398 (NamespaceEntry.VerifyAllUsing): New.
3399 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3400 behaviour. Delegates actual resolution of alias to ...
3401 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3402 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3404 * driver.cs (Driver.MainDriver): Update.
3406 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3407 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3409 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3411 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3412 RootNamespace.DefineNamespacesForAll.
3414 2005-10-24 Raja R Harinath <harinath@gmail.com>
3416 * typemanager.cs (assemblies, external_aliases, modules)
3417 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3418 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3419 overhead. Move resposibility ...
3420 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3421 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3423 2005-10-23 Raja R Harinath <harinath@gmail.com>
3425 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3426 cached_namespaces. Improve usage.
3427 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3428 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3429 Move from GlobalRootNamespace and simplify.
3430 (RootNamespace.Global): Make instance variable.
3431 (RootNamespace.RootNamespace): Add "alias name" parameter.
3432 (GlobalRootNamespace): Simplify drastically.
3433 (Namespace.Lookup): Don't use GetNamespace.
3434 * typemanager.cs (GetRootNamespace): Rename from
3435 ComputeNamespaceForAlias.
3436 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3438 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3440 * anonymous.cs (AnonymousContainer): Don't crash when container
3443 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3445 * expression.cs (Binary.DoResolve): Warn when comparing same
3448 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3451 * expression.cs (Binary.DoResolve): It looks like there are no
3452 convetsion rules in enum context.
3454 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3456 Add support for extern alias qualifiers.
3457 * typemanager.cs: Move some LookupTypeReflection code
3458 to namespace.cs, to have cleaner code. Added some methods
3459 to help us keep track of the extern aliased references.
3460 * driver.cs: Add suport for extern alias assemblies on command
3461 line and check for their warnings/errors. Also keep track of the
3462 extern aliased assemblies.
3463 * namespace.cs: Move the global functionality of Namespace
3464 to GlobalRootNamespace/RootNamespace. Now the global namespace
3465 is GlobalRootNamespace.Globa. Also the code moved from
3466 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3467 Finally added LocalAliasEntry (AliasEntry before) and
3468 ExternAliasEntry, to handle alias statements.
3469 * cs-parser.jay: Add support in the grammar for extern alias
3471 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3472 Update callings to Namespace (now in GlobalRootNamespace).
3474 2005-10-25 Martin Baulig <martin@ximian.com>
3476 * convert.cs (ImplicitTypeParameterConversion): Make base
3477 interfaces actually work; fixes #76557.
3479 2005-10-25 Martin Baulig <martin@ximian.com>
3482 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3483 all the type parameters; fixes #76551.
3485 2005-10-25 Martin Baulig <martin@ximian.com>
3490 (GenericMethod.ctor): Added `Expression return_type' and
3491 `Parameters parameters' arguments.
3492 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3493 parameter and return types to check their constraints if they're
3496 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3499 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3500 constraints of a generic type if `ec.ResolvingGenericMethod'.
3502 * class.cs (MethodCore.DoDefineParameters): Set
3503 `ec.ResolvingGenericMethod' if we're a generic method.
3504 (MemberBase.MemberType): Likewise.
3506 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3508 * typemanager.cs (TypeManager): Added
3509 TypeManager.internals_visible_attr_type to cache
3510 S.R.CompilerServices.InternalsVisibleToAttribute.
3512 * codegen.cs (AssemblyClass): Added checks for
3513 InternalsVisibleToAttribute in new method
3514 CheckInternalsVisibleAttribute () and also cache the
3515 AssemblyName in AssemblyClass.Name.
3517 2005-10-24 Martin Baulig <martin@ximian.com>
3520 (TypeManager.ExpandInterfaces): Added overloaded version which
3521 just takes a `Type[]' array.
3524 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3525 just use the interfaces which were explicitly specified and not
3526 the interfaces they inherit. Fixes #76482.
3527 (TypeParameter.FindMembers): Expand the interfaces here.
3529 2005-10-21 Martin Baulig <martin@ximian.com>
3532 (Constraints.Resolve): Also resolve the actual types here.
3533 (Constraints.ResolveTypes): Just check the constraints here.
3534 Fixes #76363; see gtest-218.cs.
3536 2005-10-21 Martin Baulig <martin@ximian.com>
3539 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3540 instead of a `BoxedCast'; fixes gtest-217.cs.
3542 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3544 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3545 1) "new()" is specified as generic parameter constraint and 2) the
3546 type is TypeBuilder and 3) the type is abstract even if it has a
3547 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3549 2005-10-20 Martin Baulig <martin@ximian.com>
3552 (GenericConstraints.TypeParameter): New public property.
3553 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3554 (TypeParameter.DeclSpace): New public property.
3555 (TypeParameter.DefineType): Inflate the constraints if our
3556 `DeclSpace' is an `Iterator'.
3558 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3560 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3561 GenericMethod argument to compare methods' generic type arguments.
3564 2005-10-19 Martin Baulig <martin@ximian.com>
3566 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3567 not ResolveType() when resolving the base type, so we're not
3568 checking the constraints here.
3569 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3572 2005-10-19 Martin Baulig <martin@ximian.com>
3574 * generic.cs (ConstructedType.CheckConstraints): Committing
3575 untested fix for #76441.
3577 2005-10-18 Raja R Harinath <rharinath@novell.com>
3580 * class.cs (TypeContainer.DefineType): Move updating of
3581 topological sort earlier in the code.
3582 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3584 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3587 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3589 * constant.cs (Constant.TryReduce): Moved from Cast class.
3590 (Reduce): Made little bit more OO and fixed missing conversions.
3592 * ecore.cs (Reduce): Implemented.
3593 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3595 * literal.cs (Reduce): Implemented.
3597 * class.cs: Reverted Miguel's wrong commit.
3599 2005-10-14 Miguel de Icaza <miguel@novell.com>
3601 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3603 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3605 * cs-parser.jay, expression.cs : CS0214 was missing error location
3606 for constants. Fixed bug #76404.
3608 2005-10-10 Raja R Harinath <rharinath@novell.com>
3610 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3612 (PropertyExpr.EmitCall): Likewise.
3613 * expression.cs (Invocation.EmitArguments): Handle case where
3615 (Invocation.EmitCall): Avoid allocating temporary variable if
3616 there are no arguments.
3618 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3621 * convert.cs (ExplicitConversionCore): Fixed object->enum
3624 2005-10-07 Raja R Harinath <rharinath@novell.com>
3627 * convert.cs (ImplicitConversionStandard): Move conversion of
3628 void* to arbitrary pointer types ...
3629 (ExplicitConversionStandard): .. here.
3630 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3631 error to always print typenames.
3633 2005-10-07 Raja R Harinath <rharinath@novell.com>
3635 * convert.cs (GetConversionOperator): Rename from
3636 GetConversionOperators. Move operator selection code from ...
3637 (UserDefinedConversion): ... here.
3639 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3641 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3644 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3646 * assign.cs (Assign.DoResolve): Error method changed.
3648 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3650 * const.cs (ResolveValue): Reset in_transit immediately.
3652 * constant.cs: Error method changed.
3654 * convert.cs: Removed useless location parameter.
3655 (ExplicitNumericConversion): Don't do double enum check.
3656 (ExplicitConversionCore): Renamed from ExplicitConversion.
3657 (ExplicitUnsafe): Extracted from ExplicitConversion.
3658 (ExplicitConversion): Uses for error reporting.
3660 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3662 (ResolveBoolean): Uses common error method.
3663 (CastToDecimal): Get rid of ec.
3664 (CastFromDecimal): Optimized.
3665 (ConvCast): Get rid of ec.
3667 * enum.cs (ResolveValue): Reset in_transit immediately.
3668 (Emit): Return after first error.
3670 * expression.cs: Convert changes.
3672 * literal.cs: Error method changed.
3674 * statement.cs: Error method changed.
3676 2005-10-06 Raja R Harinath <rharinath@novell.com>
3678 Fix gtest-131.cs and gtest-211.cs.
3679 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3680 Only emit code for a label if it is used. Unreachable code can
3681 violate ECMA evaluation stack invariants.
3683 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3685 * anonymous.cs: Implemented ExprClassName.
3687 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3690 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3693 * class.cs (StaticClass.DefineContainerMembers): Report protected
3696 * codegen.cs: if(ed) PRODUCTION.
3698 * convert.cs (Error_CannotImplicitConversion): Better error
3701 * cs-parser.jay: More error checks.
3703 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3705 * driver.cs (CSCParseOption): Enabled wrong option check.
3707 * ecore.cs (Expression.ExprClassName): Turned to property.
3708 (MemberExpr.CheckIntermediateModification): For checking boxed
3709 value types modification.
3711 * statement.cs (Fixed.Resolve): Expression type must be
3712 convertible to fixed type.
3713 (CollectionForeach.GetEnumeratorFilter,TryType):
3714 Small refactoring for easier error checking.
3716 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3718 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3721 * class.cs (GeneratedBaseInitializer): New class for customization
3722 compiler generated initializers.
3723 (MemberBase.DoDefine): Check Obsolete attribute here.
3724 (FieldMember.DoDefine): Ditto.
3726 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3729 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3730 (MemberCore.GetObsoleteAttribute): Removed argument.
3731 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3732 (MemberCore.CheckObsoleteType): New helper.
3736 * statement.cs: Updates after MemberCore changes.
3738 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3739 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3741 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3742 obsolete attribute for compiler construct.
3743 (As.DoResolve): Cache result.
3745 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3747 2005-10-01 Miguel de Icaza <miguel@novell.com>
3749 * expression.cs (Probe): instead of having a "Type probe_type"
3750 keep the extra information as a TypeExpr probe_type_expr since the
3751 "As" operator needs to perform some type checks.
3753 * (As.DoResolve): If the type is a type parameter, ensure that it
3754 is constrained by a class.
3756 2005-09-22 Miguel de Icaza <miguel@novell.com>
3758 * statement.cs (Lock): Use the TemporaryVariable class instead of
3759 manually using local variables as those do not work when variables
3762 * ecore.cs: Moved the TemporaryVariable class from being a nested
3763 class inside Foreach to be a public class that can be employed in
3766 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3768 * cs-parser.jay: interface_accessors replaced by
3769 accessor_declarations.
3771 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3774 * statement.cs (GotoCase.Resolve): Convert null constant to
3776 (SwitchLabel.ResolveAndReduce): Ditto.
3777 (SwitchLabel.NullStringCase): Custom null stamp.
3778 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3780 typemanager.cs (CSharpSignature): Don't skip first argument
3783 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3785 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3786 expression.cs, iterators.cs, literal.cs: Store constants and
3789 * class.cs (MemberBase.ShortName): Pass location.
3791 * cs-parser.jay: Some location fixes.
3793 * ecore.cs (Expression.Location): Made virtual.
3795 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3798 * const.cs (Const.ResolveValue): Check for assigning non-null
3799 value to reference type.
3801 2005-09-26 Raja R Harinath <rharinath@novell.com>
3804 * expression.cs (This.VerifyFixed): In a value type T, the type of
3805 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3806 value type R, 'this' is treated as a value parameter.
3808 2005-09-05 Miguel de Icaza <miguel@novell.com>
3810 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3811 if the underlying types are the same, otherwise we need to produce
3812 code that will do the proper cast.
3814 This was exposed by Marek's constant rewrite which produced
3815 invalid code for the call site:
3818 void Method (X v) {}
3822 This fixes test-49.cs
3824 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3826 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3827 Type/Object should be allowed as well. Fixed bug #75968.
3829 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3831 * expression.cs : (Binary.DoResolve): when one is enum constant and
3832 another is constant 0, then return enum one *as enum type*.
3835 2005-10-04 Martin Baulig <martin@ximian.com>
3837 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3838 `SetMemberIsUsed()' work for generics, too.
3840 2005-10-04 Martin Baulig <martin@ximian.com>
3842 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3843 for corlib. Fixes #75691.
3845 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3848 * driver.cs: Fix compilation files with full root path.
3850 2005-09-25 Miguel de Icaza <miguel@novell.com>
3852 * report.cs (SymbolRelatedToPreviousError): Format the output so
3853 it does not use an open parenthesis that is never closed.
3855 * driver.cs: Follow coding guidelines
3857 2005-09-18 Miguel de Icaza <miguel@novell.com>
3859 * driver.cs: Set InEmacs based on the environment variable EMACS.
3861 * location.cs (InEmacs): in this mode, do not report column
3862 location as it confuses Emacs.
3864 2005-10-03 Raja R Harinath <rharinath@novell.com>
3866 * support.cs (SeekableStreamReader.Position): Don't error out when
3867 the requested position is just beyond the end of the current
3870 2005-09-28 Raja R Harinath <rharinath@novell.com>
3872 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3873 try to keep in sync with the byte count of the underlying Stream.
3874 However, this limits us to a window size of 2048 characters: i.e.,
3875 the maximum lookahead of our lexer/parser can be 2048 characters.
3877 2005-09-22 Martin Baulig <martin@ximian.com>
3879 * driver.cs: Removed a debugging FIXME.
3881 2005-09-21 Raja R Harinath <rharinath@novell.com>
3883 * cs-parser.jay (type_arguments): Add CS1644 check.
3884 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3886 2005-09-15 Raja R Harinath <rharinath@novell.com>
3888 * Makefile (PROGRAM): Make profile specific.
3889 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
3890 the current directory.
3893 * expression.cs (Invocation.EmitCall): Remove optimization on
3894 this_call since it doesn't handle 'this' being a value type.
3896 2005-09-05 Geoff Norton <gnorton@customerdna.com>
3898 * driver.cs: Ensure file handles are closed after parsing
3900 2005-09-05 Miguel de Icaza <miguel@novell.com>
3902 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3903 if the underlying types are the same, otherwise we need to produce
3904 code that will do the proper cast.
3906 This was exposed by Marek's constant rewrite which produced
3907 invalid code for the call site:
3910 void Method (X v) {}
3914 This fixes test-49.cs
3916 2005-09-05 Martin Baulig <martin@ximian.com>
3918 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
3919 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
3921 * cs-parser.jay (delegate_declaration): Small fix for #75852.
3923 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3925 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
3926 to be a pointer type due to the spec 25.2, so check if declaring
3927 type is generic type definition. Fixed bug #75772.
3929 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3932 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
3933 both types are not defined by methods.
3934 * expression.cs : (Invocation.IsApplicable): it should work when
3935 the argument type is equal to the parameter type, not only when
3936 ImplicitConversionExists() returns true.
3938 2005-09-02 Raja R Harinath <rharinath@novell.com>
3940 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
3944 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
3945 flow-branching for LocalVariableReferences in case we were invoked
3946 from a MemberAccess.
3947 * expression.cs (LocalVariableReference.VerifyAssigned): New.
3949 (LocalVariableReference.DoResolveBase): ... this.
3950 (MemberAccess.Resolve): Do the check that was disabled during
3953 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3956 (PartialContainer.Create): check abstract/sealed/static strictly
3957 but abstract/sealed can exist only at one side. Fixed bug #75883.
3959 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
3962 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
3963 specified, don't default to UnmanagedType.I4.
3965 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3967 * expression.cs : conditional operator should check possibly
3968 incorrect assign expression. Fixed bug #75946.
3970 2005-08-30 Raja R Harinath <rharinath@novell.com>
3973 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
3974 (ScopeInfo.EmitScopeType): Use it to construct field names from
3975 names of captured locals.
3978 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
3979 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
3980 Pass 'target_type' to BoxedCast. Don't default to 'object'.
3981 (ExplicitConversion): Remove enum cases already handled by
3982 implicit conversion. Move implicit conversion check to the beginning.
3983 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
3984 * expression.cs (ArrayCreation.EmitDynamicInitializers):
3985 Don't treat System.Enum as a struct.
3987 2005-08-30 Jb Evain <jbevain@gmail.com>
3989 * attribute.cs: handles as expression in parameters.
3991 2005-08-30 Raja R Harinath <rharinath@novell.com>
3994 * class.cs (TypeContainer.VerifyClsName): Don't use a
3995 PartialContainer when verifying CLS compliance.
3996 (AbstractPropertyEventMethod): Set Parent here, ...
3997 (PropertyMethod): ... not here.
3999 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
4001 * attribute.cs : escaped attribute name should not be allowed to be
4002 resolved (e.g. @class as classAttribute). Fixed bug #75930.
4004 2005-08-29 Raja R Harinath <rharinath@novell.com>
4007 * convert.cs (ImplicitStandardConversionExists): Allow zero also
4008 when converting a long constant to unsigned long.
4009 * expression.cs (Invocation.OverloadResolve): Add sanity check to
4010 detect where IsApplicable and VerifyArgumentsCompat disagree.
4012 2005-08-29 Raja R Harinath <rharinath@novell.com>
4013 and Carlos Alberto Cortez <carlos@unixmexico.org>
4016 * class.cs (TypeContainer.CanElideInitializer): New helper.
4017 (TypeContainer.EmitFieldInitializers): Use it to determine if we
4018 can safely emitting the initializer of a field.
4020 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4022 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
4023 allowed inside a switch (without loop). Fixed bug #75433.
4025 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4027 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4028 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4030 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4032 * driver.cs : kinda reverting the default encoding changes (not exact
4033 revert since I noticed that "codepage:reset" might not work fine).
4035 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4037 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
4038 Location. Now getter and setter store location correctly.
4039 (errors/cs0111-12.cs now reports the expected location.)
4041 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4043 * driver.cs : Use default encoding on the environment.
4044 Removed (now that) extra parameter for SeekableStreamReader.
4045 * support.cs : (SeekableStreamReader) third .ctor() argument for
4046 StreamReader is not required (always true). preamble size could
4047 be acquired in simpler and safe way.
4049 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
4051 * cs-parser.jay: report CS0642 at warning level 3
4052 and report CS0642 for an if else statement also
4053 fixes bug #74745. Patch by John Luke (and a bit
4055 Removed extra CS0642 warning check for "while",
4057 * statement.cs: In Block.Resolve(), CS0642 check
4058 is reimplemented to check a sequence of an empty
4059 statement and a block.
4061 Both fix bug #66777.
4063 2005-08-24 Marek Safar <marek.safar@seznam.cz>
4065 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
4066 detection until I fix it.
4068 * cs-tokenizer.cs: Changed error message.
4070 * cs-parser.jay: Fixed 2 error locations.
4072 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
4073 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
4076 * enum.cs (GetSignatureForError): Fixed.
4078 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
4082 * typemanager.cs (RegisterProperty): Removed.
4084 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
4086 2005-08-24 Raja R Harinath <rharinath@novell.com>
4089 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
4090 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
4092 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4094 * expression.cs : tiny fix is required for not warning positive ulong.
4097 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4099 * expression.cs : add CS0652 check for constant and integral
4100 expression. Fixed bug #53974.
4102 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4104 * expression.cs : in DoNumericPromotions(), check if there is implicit
4105 conversion overload for string (to check CS0034). Fixed bug #52492.
4107 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4109 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
4111 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4113 * ecore.cs : report location when it is *not* Null.
4115 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4121 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
4122 correctly. Fixed bug #75721.
4124 2005-08-23 Raja R Harinath <rharinath@novell.com>
4126 * support.cs (SeekableStreamReader.Position): Avoid an expensive
4127 loop that performs 'min (pos, char_count)'.
4130 * expression.cs (Unary.ResolveOperator): Don't discard implicit
4131 converted value in Operator.OnesComplement.
4133 2005-08-22 Ben Maurer <bmaurer@ximian.com>
4135 * anonymous.cs: If the anon method is pulled into a helper class,
4136 it needs to be `internal' not `private'. Fixes runtime behavior on
4139 2005-08-17 Marek Safar <marek.safar@seznam.cz>
4142 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
4145 2005-08-16 Marek Safar <marek.safar@seznam.cz>
4147 The big constants rewrite
4148 Fix #75746, #75685 and more
4149 As a side effect saved 1MB for MWF ;-)
4151 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
4152 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
4153 enum based for corlib compilation.
4155 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
4158 * class.cs (FixedField.Define): Use ResolveAsConstant.
4160 * const.cs (IConstant): Interface constants and enums.
4161 (Const.ResolveValue): New method for constant resolvning.
4162 (ExternalConstant): Constants from imported assemblies.
4164 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
4165 conversion; like enums.
4166 (Constant.ToType): Converts this constant to different type.
4167 (Constant.Increment): Adds 1.
4169 * convert.cs (ImplicitConversionRequired): Simplified.
4171 * cs-parser.jay: Create EnumMember directly.
4173 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
4175 * doc.cs (GenerateEnumDocComment): Removed.
4177 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
4178 (ConvertIntLiteral): Removed.
4179 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
4181 * enum.cs (EnumMember): Implement IConstant.
4182 (Enum.IsValidEnumConstant): Removed.
4183 (Enum.GetNextDefaultValue): Removed.
4184 (Enum.FindMembers): Updated.
4185 (Enum.GenerateDocComment): Iterate enum members.
4187 * expression.cs (Cast.TryReduce): Handle enums correctly.
4188 (New.Constantify): Made public.
4189 (MemberAccess.DoResolve): Removed contant specific if(s).
4191 * literal.cs (NullLiteral): Implement new abstract methods.
4193 * statement.cs (GotoCase.Resolve): Use new constant methods.
4194 (SwitchLabel.ResolveAndReduce): Use new constant methods.
4196 * typemanager.cs (LookupEnum): Removed.
4197 (IsEnumType): Fixed to work with corlib.
4198 (RegisterConstant): Removed.
4199 (LookupConstant): Removed.
4200 (GetConstant): Changed to work with IConstant.
4202 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
4204 * location.cs : Fixed overflown (>255) column number.
4206 2005-08-03 Raja R Harinath <rharinath@novell.com>
4208 First cut of the qualified-alias-member feature.
4209 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
4211 * cs-parser.jay (DOUBLE_COLON): New token.
4212 (namespace_or_type_name): Add rule for recognizing
4213 qualified-alias-members.
4214 (primary_expression): Likewise.
4215 (element_access): Allow QualifiedAliasMember as a possible
4216 type-bearing expression.
4217 (local_variable_type, local_variable_pointer_type): Likewise.
4218 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
4219 aliases in the current and enclosing namespace declarations.
4220 (NamespaceEntry.UsingAlias): Add CS0440 warning.
4221 * decl.cs (MemberName.is_double_colon): New.
4222 (MemberName.MemberName): Add new constructor for alias-member.
4223 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
4224 * expression.cs (QualifiedAliasMember): New expression type.
4226 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4228 * location.cs : it borked when no argument was specified.
4230 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4232 * location.cs : tiny ToString() format fix.
4234 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4236 * statement.cs : oops, it was missing.
4238 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4240 A set of fixes for precise line/column location.
4243 "token" field now holds a file/line "delta", a line number offset
4244 from the segment, and a column number. See also:
4245 http://lists.ximian.com/pipermail/mono-devel-list/2004-
4246 December/009508.html
4247 Removed static IsNull. Use instance IsNull property instead.
4249 For some tokens it stores Location. For Identifier it stores
4250 LocatedToken which is a pair of string name and location.
4251 Column numbers are adjusted only at getChar().
4253 Use Location.ToString() for reporting (it now contains column).
4255 Largely modified to use LocatedToken instead of
4256 string (IDENTIFIER), and to acquire Location from some tokens.
4257 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
4258 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
4260 Now MemberName holds Location. DeclSpace.ctor() receives Location
4261 as a parameter. Removed extra parameters to all derived classes.
4262 Replaced Location.IsNull() with instance property.
4263 * assign.cs, expression.cs :
4264 Added .ctor() overload that omits Location.
4266 Added "nameEscaped" flag that indicates the identifier was escaped
4267 in the source file. This fixes bug #57047.
4269 2005-09-02 Martin Baulig <martin@ximian.com>
4271 * class.cs: Make CS3005 a warning, not an error.
4273 2005-08-02 Marek Safar <marek.safar@seznam.cz>
4275 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
4276 New method, looking for lo-case imported cls type.
4278 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4281 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4283 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4285 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4287 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4289 Optimized to save 3.5 MB for SWF compilation.
4291 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4293 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4294 (PartialContainer.Create): Moved logic AddToContainer.
4295 (PartialContainer.MarkForDuplicationCheck): Shares name.
4297 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4300 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4302 (Namespace.GetSignatureForError): New method.
4304 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4305 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4307 2005-08-01 Raja R Harinath <rharinath@novell.com>
4310 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4311 member lookup rather than qualifier_type, since qualifier_type can
4314 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4316 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4319 2005-07-31 Miguel de Icaza <miguel@novell.com>
4321 * statement.cs: Copy the local exception into the exception
4322 captured local. Fixes 75674
4324 2005-07-31 Raja R Harinath <harinath@gmail.com>
4327 * expression.cs (Invocation.OverloadResolve): Don't report error
4328 CS1501 if error CS1502 has been reported.
4329 (New.DoResolve): Delegate CS1501 reporting to
4330 Invocation.OverloadResolve.
4333 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4334 invariant-meaning-in-block property in an enclosing block if
4337 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4339 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4340 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4341 (Switch.CheckSwitch): Just save 50kb for SWF.
4343 2005-07-27 Martin Baulig <martin@ximian.com>
4345 * anonymous.cs (CaptureContext.AddField): Added
4346 `AnonymousContainer am' argument; compute its toplevel scope if
4347 it's not already computed. Fixes #75649.
4349 2005-07-26 Raja R Harinath <rharinath@novell.com>
4352 * class.cs (Constructor.Emit): Reset block to null if the block
4355 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4357 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4359 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4361 * class.cs (MethodData.Define): Check whether accessor implementing
4362 interface is public.
4364 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4366 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4369 * namespace.cs (LookupType): Moved same type check to...
4371 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4374 2005-07-21 Raja R Harinath <rharinath@novell.com>
4376 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4377 already found a typebuilder.
4378 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4379 MemberNames, not strings.
4381 * const.cs (Error_ExpressionMustBeConst):
4382 Rename from Error_EpressionMustBeConst.
4383 * const.cs, class.cs, statement.cd: Update.
4385 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4389 * const.cs (Const.LookupConstantValue): Report missing contant expression
4391 (Error_EpressionMustBeConstant): Only one error method.
4393 * class.cs, statement.c: Updated.
4395 2005-07-20 Raja R Harinath <rharinath@novell.com>
4397 * statement.cs (Block.Flags): Add back HasVarargs.
4398 (Block.flags): Make protected.
4399 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4401 * typemanager.cs (types, typecontainers, user_types): Remove.
4402 (UserTypes, TypeContainers): Likewise.
4403 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4404 (CleanUp, Reset): Update.
4405 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4406 (GetNestedType): Use Type.GetNestedType.
4407 (CoreLookupType): Take two arguments, the namespace and the
4408 basename of the type. Update to use the Namespace.Lookup
4410 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4411 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4412 string concatenation and substring matches.
4413 * class.cs, enum.cs, delegate.cs: Update to changes.
4415 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4417 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4418 Expression and made virtual.
4420 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4421 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4423 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4425 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4428 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4431 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4434 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4435 AssemblyCultureAttribute is not used on executable.
4438 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4440 2005-07-16 Raja R Harinath <rharinath@novell.com>
4443 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4444 New. Reports CS0252/CS0253.
4445 Mostly taken from preliminary patch by Duncak Mak.
4446 (Binary.DoResolveOperator): Store results of operator lookup.
4447 Use them to detect if we need to warn about unintended reference
4450 2005-07-15 Raja R Harinath <rharinath@novell.com>
4453 * namespace.cs (Namespace.Lookup): Add back location parameter.
4454 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4455 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4457 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4458 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4459 (Namespace.LookupType): ... this.
4460 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4462 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4463 purported to handle pointers.
4464 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4467 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4469 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4472 2005-07-15 Raja R Harinath <rharinath@novell.com>
4474 * namespace.cs (Namespace.Lookup): Drop location parameter.
4475 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4476 (NamespaceEntry.Lookup): ... this.
4477 (NamespaceEntry.Error_AmbiguousTypeReference):
4478 Move here from DeclSpace.
4479 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4481 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4482 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4483 Move to NamespaceEntry.
4484 * delegate.cs, expression.cs: Update to changes.
4486 2005-08-31 Martin Baulig <martin@ximian.com>
4488 Committing a patch from Atsushi Enomoto for #75850.
4490 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4491 Prefer a generic enumerator over a non-generic one.
4493 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4495 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4496 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4498 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4500 * driver.cs : reverting default encoding change as well as mcs.
4502 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4504 * driver.cs, support.cs : merged r48826.
4506 > could you integrate your mcs changes to gmcs otherwise
4507 > gmcs cannot compile some files.
4509 2005-08-20 Martin Baulig <martin@ximian.com>
4511 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4512 scope if we don't already have it.
4514 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4515 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4518 2005-07-31 Miguel de Icaza <miguel@novell.com>
4520 * statement.cs: Copy the local exception into the exception
4521 captured local. Fixes 75674
4523 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4525 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4528 2005-08-12 Martin Baulig <martin@ximian.com>
4530 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4531 for nested types here to avoid hitting the cache too early.
4533 2005-08-09 Miguel de Icaza <miguel@novell.com>
4535 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4538 2005-08-03 Martin Baulig <martin@ximian.com>
4540 Make iterators in generic methods work; see gtest-191.cs.
4543 (Constraints.Resolve): Protect against being called twice.
4546 (TypeContainer.GetClassBases): Make this `protected virtual'.
4548 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4549 (Iterator.GetClassBases): Override this and compute the base
4551 (Iterator.DefineNestedTypes): If we're a generic method, all our
4552 method type parameters become class type parameters on the proxy
4556 (ToplevelBlock.Parameters): Make this a property, not a field.
4557 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4559 2005-08-03 Martin Baulig <martin@ximian.com>
4561 * typemanager.cs (TypeManager.IsSubclassOf): Use
4562 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4563 (TypeManager.GetFullName_recursed): Improved.
4565 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4568 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4569 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4570 invocation_type == mi.DeclaringType, since the first one also checks
4571 other condition used by generic instances.
4573 2005-07-27 Martin Baulig <martin@ximian.com>
4575 * anonymous.cs (CaptureContext.AddField): Added
4576 `AnonymousContainer am' argument; compute its toplevel scope if
4577 it's not already computed. Fixes #75649.
4579 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4581 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4582 CheckAttributeType and refactored.
4583 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4584 ResolveAsTypeTerminal error handling.
4585 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4587 (GetSignatureForError): Print errors in same way.
4590 * codegen.cs: Reflect attribute GetSignatureForError change.
4593 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4595 * namespace.cs (UsingEntry): Refactored to make fields private.
4598 statement.cs: Error_UnexpectedKind has extra parameter.
4600 2005-07-14 Raja R Harinath <rharinath@novell.com>
4602 * ecore.cs (IAlias): Remove.
4603 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4604 that implement the interface.
4605 * namespace.cs (Namespace): Likewise.
4606 (Namespace.declspaces): Renamed from 'defined_names'.
4607 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4608 DeclSpace instead of an IAlias.
4609 * tree.cs (Tree.AddDecl): Update.
4611 2005-07-12 Raja R Harinath <rharinath@novell.com>
4613 * statement.cs (Block.Flags); Remove HasVarargs.
4614 (Block.HasVarargs): Move to ToplevelBlock.
4615 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4616 (Block.Variables): Make protected. Initialize variable hashtable
4618 (Block.AddVariable): Update.
4619 (Block.Resolve): Update to changes.
4620 (ToplevelBlock.HasVarargs): New boolean.
4621 (ToplevelBlock.ThisVariable): Move here from Block.
4622 (ToplevelBlock.AddThisVariable): Likewise.
4623 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4624 * expression.cs (This.ResolveBase): Update to changes.
4625 (ArglistAccess.DoResolve): Likewise.
4627 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4630 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4632 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4633 not used and not used & assigned.
4634 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4636 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4639 * expression.cs (Is.DoResolve): null is never provided type.
4641 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4644 * cs-parser.jay: Less strict event error rule to catch more errors.
4646 2005-07-11 Martin Baulig <martin@ximian.com>
4648 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4649 for the constructor constraint: we do not only have to check
4650 whether the class has a public constructor, but also ensure that
4651 it's parameterless. Fixes #75492.
4653 2005-07-11 Martin Baulig <martin@ximian.com>
4655 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4656 between type parameters if they either have the reference type
4657 constraint or the class constraint.
4659 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4661 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4663 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4666 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4667 (ExtractSecurityPermissionSet): Cope with self referencing security
4668 attributes properly.
4670 * driver.cs (SetOutputFile): Made public property OutputFile.
4672 2005-07-07 Raja R Harinath <rharinath@novell.com>
4675 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4676 has_nonstatic_fields. Make into a FieldBase pointer.
4677 (TypeContainer.AddField): Add CS0282 check.
4678 (TypeContainer.EmitType): Update.
4680 2005-07-06 Miguel de Icaza <miguel@novell.com>
4682 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4683 compare if they start with __.
4685 2005-07-06 Raja R Harinath <rharinath@novell.com>
4687 * statement.cs (Switch.SwitchGoverningType): Only look at
4688 UserCasts that don't need implicit standard conversions to one of
4689 the allowed switch types (Fixes test-322.cs).
4690 (LocalInfo.Resolve): Re-enable sanity-test.
4692 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4694 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4696 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4698 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4700 2005-07-06 Raja R Harinath <rharinath@novell.com>
4703 * ecore.cs (SimpleName.GetSignatureForError): Add.
4704 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4705 (MemberAccess.GetSignatureForError): Add.
4707 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4709 The big error and warning messages review.
4739 * typemanager.cs: Updated.
4741 * class.cs: (MethodCore.SetYields): Moved here to share.
4742 (PropertyMethod.Define): Moved iterator setup here.
4744 * iterators.cs: Add orig_method to have full access to parent
4747 2005-07-05 Raja R Harinath <rharinath@novell.com>
4749 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4750 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4751 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4752 variable of struct type.
4753 * expression.cs (Unary.ResolveOperator): Update to change.
4754 (Indirection.VerifyFixed): Likewise.
4755 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4756 (ParameterReference.VerifyFixed): Value parameters are fixed.
4757 (This.VerifyFixed): Treat 'this' as a value parameter.
4758 * statement.cs (LocalInfo.IsFixed): Remove.
4760 2005-07-01 Martin Baulig <martin@ximian.com>
4762 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4763 `ec.EmitThis ()' to get the correct scope.
4765 2005-07-01 Martin Baulig <martin@ximian.com>
4767 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4768 instance is a ParameterReference; fixes #75299.
4770 2005-06-30 Raja R Harinath <rharinath@novell.com>
4773 * expression.cs (Indexers.map): Remove.
4774 (Indexers.Append): Filter out inaccessible setters and getters.
4775 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4778 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4780 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4781 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4782 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4783 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4785 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4788 * class.cs (FieldBase.GetInitializerExpression): One more field
4791 2005-06-28 Miguel de Icaza <miguel@novell.com>
4793 * pending.cs: Do not define a proxy if the base method is virtual,
4794 it will be picked up by the runtime (bug 75270).
4796 2005-07-08 Martin Baulig <martin@ximian.com>
4798 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4799 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4801 2005-07-07 Martin Baulig <martin@ximian.com>
4803 * generic.cs (ConstructedType.CheckConstraint): Use
4804 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4805 called recursively; fixes #75329.
4807 2005-07-06 Martin Baulig <martin@ximian.com>
4809 * generic.cs (TypeManager.InferTypeArguments): Added support for
4810 anonymous methods; fixes #75461.
4812 2005-07-01 Martin Baulig <martin@ximian.com>
4814 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4815 `ec.EmitThis ()' to get the correct scope.
4817 2005-07-01 Martin Baulig <martin@ximian.com>
4819 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4820 instance is `This'; fixes #75299.
4822 2005-06-30 Martin Baulig <martin@ximian.com>
4824 * class.cs (Indexer): Implement IIteratorContainer; added support
4825 for iterators in indexers.
4828 (EmitContext.CurrentIterator): Make this a property, not a field.
4830 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4832 2005-06-28 Miguel de Icaza <miguel@novell.com>
4834 * pending.cs: Do not define a proxy if the base method is virtual,
4835 it will be picked up by the runtime (bug 75270).
4837 2005-06-28 Martin Baulig <martin@ximian.com>
4839 * cs-parser.jay (interface_method_declaration): Avoid a
4840 reduce/reduce conflict by moving some of the code into a separate
4841 `interface_method_declaration_body' rule; fixes #75368.
4843 2005-06-28 Martin Baulig <martin@ximian.com>
4845 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4846 array check after the check for TypeBuilder's.
4848 2005-06-21 Raja R Harinath <rharinath@novell.com>
4850 * convert.cs (FindMostEncompassedType): Add two trivial special
4851 cases (number_of_types == 0 || number_of_types == 1).
4852 (FindMostEncompasingType): Likewise.
4854 2005-06-17 Raja R Harinath <rharinath@novell.com>
4856 Some cleanups preparing for the fix of #75283.
4857 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4859 (EventExpr.InstanceResolve): Likewise.
4860 (EventExpr.DoResolve): Remove redundant checks.
4862 2005-06-08 Miguel de Icaza <miguel@novell.com>
4864 * class.cs: Small fix.
4866 2005-06-08 Raja R Harinath <rharinath@novell.com>
4869 * class.cs (GetPartialBases): Fix return value check of
4872 2005-06-07 Raja R Harinath <rharinath@novell.com>
4874 Ensure that partial classes are registered in their enclosing
4875 namespace. Initial part of fix of #75160.
4876 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4877 Register declspace with namespace here, not in
4878 DeclSpace.RecordDecl.
4879 * cs-parser.jay: Pass namespace to RecordDecl.
4880 * class.cs (PartialContainer.Create): Likewise.
4881 (ClassPart.DefineType): New sanity-check. Throws an exception if
4883 * decl.cs (Declspace.RecordDecl): Remove.
4884 * namespace.cs (NamespaceEntry.DefineName): Remove.
4886 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4888 * rootcontext.cs: Reset TargetExt as well.
4890 2005-06-03 Raja R Harinath <rharinath@novell.com>
4892 * ecore.cs (Expression.Resolve): Emit CS0654 error when
4895 2005-06-02 Raja R Harinath <rharinath@novell.com>
4897 Fix #75080, cs0119.cs.
4898 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
4900 (Expression.Resolve): ... this. Use it. Remove bogus code
4901 allowing ExprClass.Type and ExprClass.Namespace for
4902 ResolveFlags.VariableOrValue.
4903 (Expression.Resolve) [1-argument variant]: Change default resolve
4904 flags based on language version.
4905 (Expression.Error_UnexpectedKind): Use a simple string array
4906 rather than an ArrayList.
4907 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
4909 (TypeOfVoid.DoResolve): Likewise.
4910 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
4911 flags argument -- it always has the same value.
4913 2005-05-31 Raja R Harinath <rharinath@novell.com>
4916 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
4917 Use it in the error message.
4918 * assign.cs, expression.cs, statement.cs: Update.
4920 2005-05-30 Raja R Harinath <rharinath@novell.com>
4923 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
4924 the "almostMatchedMember" case too.
4925 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
4926 that failed the accessibility checks to 'almost_match'.
4928 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
4930 * attribute.cs: Use internal MethodBuilder methods to set
4931 ExactSpelling and SetLastError on PInvoke methods, instead
4932 of passing them via charset. Fixes #75060.
4934 2005-05-27 Raja R Harinath <rharinath@novell.com>
4936 * parameter.cs (Parameter): Remove TODO comment.
4937 (Parameter.DefineParameter): Remove Location parameter.
4938 (Parameters.LabelParameters): Likewise.
4939 * class.cs (Constructor.Emit): Update to change.
4940 (MethodData.Emit): Likewise.
4941 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
4942 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
4944 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
4947 Removed Parameters.Location and added Parameter.Location instead.
4948 Removed Location parameter from Emit() and GetSignature().
4955 Modified all related calls.
4957 2005-06-21 Martin Baulig <martin@ximian.com>
4959 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
4960 left-hand side is not a nullable type; fixes #75328.
4962 2005-06-21 Martin Baulig <martin@ximian.com>
4965 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
4966 (TypeManager.GetFullNameSignature): Likewise.
4968 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
4969 `source.FullName' and `target.FullName' to check whether there are
4970 two conflicting definitions.
4972 2005-06-21 Martin Baulig <martin@ximian.com>
4974 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
4975 a BoxedCast - also for reference types - to be compatible with csc.
4977 2005-06-21 Martin Baulig <martin@ximian.com>
4979 * expression.cs (MemberAccess.DoResolve): Add support for nested
4980 types in a generic instance; fixes #75320.
4982 2005-06-20 Martin Baulig <martin@ximian.com>
4984 * generic.cs (TypeManager.InferType): Also walk the class
4985 hierarchy for generic instances; fixes #75261.
4987 2005-06-17 Martin Baulig <martin@ximian.com>
4989 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
4990 to make things work for corlib.
4992 2005-06-15 Martin Baulig <martin@ximian.com>
4994 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
4995 obsolete `SecurityAction' values.
4997 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4999 * rootcontext.cs: Reset TargetExt as well.
5001 2005-06-09 Martin Baulig <martin@ximian.com>
5003 * delegate.cs (Delegate.VerifyMethod): Added
5004 `MethodGroupExpr old_mg' argument; inherit its
5005 `HasTypeParameters'; fix #75085.
5007 2005-06-09 Martin Baulig <martin@ximian.com>
5009 * expression.cs (Invocation.OverloadResolve): Correctly handle
5010 generic methods for the SetMemberIsUsed(); fix #75064.
5012 2005-06-09 Martin Baulig <martin@ximian.com>
5014 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
5017 2005-06-08 Martin Baulig <martin@ximian.com>
5019 * cs-parser.jay (nullable_type_or_conditional): If we put the
5020 nullable back and our `type' is a `ComposedCast', remove the
5021 nullable from it. Fixes #75156.
5023 * expression.cs (ComposedCast.RemoveNullable): New public method.
5025 2005-06-08 Martin Baulig <martin@ximian.com>
5027 The big Iterators rewrite :-)
5029 * iterators.cs: Rewrite this to use the anonymous methods framework.
5031 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
5032 before the TypeContainers; see 2test-21.cs.
5035 (TypeContainer.DefineType): Don't create a new EmitContext if we
5036 already have one (this only happens if we're an Iterator).
5037 (TypeContainer.Define): Also call Define() on all our iterators.
5038 (Method.CreateEmitContext): Added support for iterators.
5041 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
5042 (AnonymousContainer.CreateMethodHost): Moved here from
5043 AnonymousMethod and made abstract.
5044 (AnonymousContainer.CreateScopeType): New abstract method.
5045 (AnonymousContainer.IsIterator): New public property.
5046 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
5047 get the ScopeTypeBuilder rather than manually defining it here.
5048 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
5051 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
5052 before RootContext.DefineTypes().
5054 * codegen.cs (EmitContext.RemapToProxy): Removed.
5055 (EmitContext.CurrentAnonymousMethod): Changed type from
5056 AnonymousMethod -> AnonymousContainer.
5057 (EmitContext.ResolveTopBlock): Protect from being called twice.
5058 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
5059 (EmitContext.EmitThis): Removed the iterators hacks; use the
5060 anonymous methods framework for that.
5063 (ToplevelBlock.Container): Make this a property, not a field.
5064 (ToplevelBlock.ReParent): New public method; move the
5065 ToplevelBlock into a new container.
5066 (Foreach.TemporaryVariable): Simplify.
5068 2005-06-05 Martin Baulig <martin@ximian.com>
5070 * statement.cs (LocalInfo.CompilerGenerated): New flag.
5071 (Block.AddTemporaryVariable): New public method; creates a new
5072 `LocalInfo' for a temporary variable.
5073 (Block.EmitMeta): Create the LocalBuilders for all the temporary
5075 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
5076 non-iterator variables.
5078 2005-06-05 Martin Baulig <martin@ximian.com>
5080 * statement.cs (Foreach.TemporaryVariable): Create the
5081 LocalBuilder in the Emit phase and not in Resolve since in some
5082 situations, we don't have an ILGenerator during Resolve; see
5083 2test-19.cs for an example.
5085 2005-06-04 Martin Baulig <martin@ximian.com>
5087 The big Foreach rewrite - Part II.
5089 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
5090 with `PropertyInfo ienumerator_getcurrent'.
5092 * codegen.cs (VariableStorage): Removed.
5095 (Foreach): Derive from Statement, not ExceptionStatement.
5096 (Foreach.CollectionForeach): New nested class. Moved all the code
5097 dealing with collection foreach here.
5098 (Foreach.ForeachHelperMethods): Removed.
5099 (Foreach.TemporaryVariable): Implement IMemoryLocation.
5101 2005-05-23 Martin Baulig <martin@ximian.com>
5103 * statement.cs (Try.DoResolve): Don't create a `finally' if we
5104 don't need to. Fix #75014.
5106 2005-05-26 Raja R Harinath <rharinath@novell.com>
5108 Improve user-defined conversion handling.
5109 * convert.cs (GetConversionOperators): Rewrite. Return only the
5110 applicable operators.
5111 (AddConversionOperators): New. Helper for GetConversionOperators.
5112 (FindMostEncompassedType, FindMostEncompassingType): Verify that
5113 there is only one most encompassed/encompassing type.
5114 (FindMostSpecificSource, FindMostSpecificTarget): Remove
5115 "applicable operator" handling.
5116 (UserConversion): Move cache here from GetConversionOperators.
5117 Directly cache the chosen operator, rather than the whole
5119 (ExplicitNumericConversion): Fix buggy implementation of Decimal
5120 case. Allow conversion of decimal to sbyte and byte too.
5121 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5122 New static methods. Used to avoid allocating EmptyExpressions in
5125 2005-05-24 Duncan Mak <duncan@novell.com>
5127 * ecore.cs (CastFromDecimal): New class for casting a decimal to
5128 another class, used in Convert.ExplicitNumericConversion.
5129 (CastToDecimal): New class, similar to above, but casts to
5130 System.Decimal, used in Convert.ImplicitNumericConversion and also
5131 in explicit convesion from double/float to decimal.
5133 * convert.cs (ImplicitNumericConversion): Handle implicit
5134 conversions to System.Decimal.
5135 (ExplicitNumericConversion): handle explicit conversions to
5140 2005-05-20 Miguel de Icaza <miguel@novell.com>
5142 * typemanager.cs: Do not throw an exception in the TypeBuilder
5143 case, we take care of it on the TypeCode.
5145 2005-05-17 Marek Safar <marek.safar@seznam.cz>
5147 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
5150 * cs-parser.jay: Catch more lexical errors.
5152 * report.cs: Add one more Error method.
5155 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
5157 2005-05-20 Martin Baulig <martin@ximian.com>
5159 * class.cs (TypeContainer.CircularDepException): Removed.
5160 (TypeContainer.DefineType): Removed the `InTransit' stuff.
5161 (TypeContainer.CheckRecursiveDefinition): Check for circular class
5162 (CS0146) and interface (CS0529) dependencies here.
5164 2005-05-20 Martin Baulig <martin@ximian.com>
5166 * expression.cs (New.DoResolve): Move the CS0712 check above the
5167 CS0144 check; otherwise it can never be reached.
5169 2005-05-20 Martin Baulig <martin@ximian.com>
5171 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
5173 2005-05-20 Martin Baulig <martin@ximian.com>
5175 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
5177 * typemanager.cs (TypeManager.IsAttributeType): New public method.
5179 2005-05-19 Martin Baulig <martin@ximian.com>
5182 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
5183 to disable error reporting.
5185 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
5186 here since we don't want to report an error; see the new test-336.cs.
5188 2005-05-19 Raja R Harinath <rharinath@novell.com>
5190 * statement.cs (ToplevelBlock.GetParameterReference)
5191 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
5192 Move here from class Block.
5193 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
5194 * expression.cs (ParameterReference.DoResolveBase): Likewise.
5196 2005-05-18 Martin Baulig <martin@ximian.com>
5201 (FlowBranching.Reachability): Add non-static public And() and Or()
5203 (FlowBranchingSwitch): New class; do the `break_origins' thing
5204 like in FlowBranchingLoop.
5205 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
5206 reachability, not just locals and parameters.
5207 (FlowBranching.MergeChild): Remove some of the hacks for loop and
5208 switch; MergeBreakOrigins() now takes care of that.
5210 2005-05-18 Martin Baulig <martin@ximian.com>
5212 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
5213 a loop and may leave it, reset the barrier; fixes #74974.
5215 2005-05-16 Raja R Harinath <rharinath@novell.com>
5217 Fix test-382.cs. Emit values of decimal constants.
5218 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
5220 (TypeContainer.AddField): ... this.
5221 (TypeContainer.EmitFieldInitializers): Allow the list of fields
5222 with initializers to include 'Const's.
5223 (ClassPart.RegisterFieldForInitialization): Forward to
5225 * const.cs (Const.Const): Pass initializer to base class.
5226 (Const.Define): In case of decimal constants, register them for
5227 initialization in a static constructor.
5229 2005-05-14 Martin Baulig <martin@ximian.com>
5231 * statement.cs (Block.Resolve): Correctly handle unreachable code;
5232 do not call ResolveUnreachable() on unreachable statements in
5233 here, see the comment in the source code.
5235 2005-05-13 Raja R Harinath <rharinath@novell.com>
5238 * expression.cs (BinaryResolveOperator): If one of the operands of
5239 an equality comparison is 'null' and the other is a pointer type,
5240 convert the null to a NullPointer.
5241 * convert.cs (ImplicitReferenceConversion): If the expression is a
5242 NullLiteral and the target type is a pointer type, return a
5243 NullPointer instead.
5244 (ImplicitConversionStandard): Likewise.
5246 2005-05-13 Marek Safar <marek.safar@seznam.cz>
5248 * cs-parser.jay: Set readonly context based on special constructs.
5250 * expression.cs (LocalVariableReference.DoResolveBase): Improved
5251 readonly variable error handling.
5253 * rootcontext.cs (EmitCode): Don't verify members when error
5256 * statement.cs (LocalInfo): Add reaodnly context information.
5257 (SetReadOnlyContext, GetReadOnlyContext): New methods.
5259 2005-05-17 Martin Baulig <martin@ximian.com>
5261 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
5264 2005-05-13 Martin Baulig <martin@ximian.com>
5266 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
5267 handle unreachable blocks.
5269 2005-05-13 Martin Baulig <martin@ximian.com>
5272 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
5273 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
5276 2005-05-13 Martin Baulig <martin@ximian.com>
5278 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5279 instance variable, not a local. Fix #74873.
5280 (Block.ResolveUnreachable): Set it to true here.
5282 2005-05-12 Martin Baulig <martin@ximian.com>
5284 * cs-parser.jay (property_declaration): Pass the `current_class',
5285 not the `current_container' to Property's .ctor. Fixes #74912.
5287 2005-05-11 Martin Baulig <martin@ximian.com>
5289 * typemanager.cs (Closure): Copy this from MCS and merge all the
5290 GMCS-specific changes into it.
5292 2005-05-12 Raja R Harinath <harinath@gmail.com>
5295 * typemanager.cs (unmanaged_enclosing_types): New.
5296 (IsUnmanagedType): Avoid infloops by using
5297 'unmanaged_enclosing_types' to talk with recursive invocations.
5299 2005-05-11 Duncan Mak <duncan@novell.com>
5301 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5302 continuing to process for 'arg'.
5303 (handle_preprocessing_directive): Check the argument of the #endif
5304 directive and report error CS1025 if there are any trailing
5307 According to the C# spec, having even whitespace after the #endif
5308 directive is illegal; however, because we call arg.TrimEnd ()
5309 beforehand, we have the same behavior as csc, allowing whitespace
5310 after the directive.
5314 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5318 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5319 (Constructor.GetObsoleteAttribute): Implemented correctly.
5321 2005-05-10 Martin Baulig <martin@ximian.com>
5323 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5324 resolve the type; fixes #74864.
5325 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5326 in DoResolve(); fixes #74862.
5328 2005-05-10 Martin Baulig <martin@ximian.com>
5330 * support.cs (ReflectionParameters.ParameterModifier): Use
5331 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5332 and `ParameterAttributes.In'. Fixes #74884.
5334 2005-05-10 Martin Baulig <martin@ximian.com>
5336 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5337 the cache if we're just looking for `MemberTypes.NestedType' in a
5340 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5341 constraints if we're still resolving the type tree.
5342 (Expression.MemberLookup): If we're resolving the type tree, only
5343 look for `MemberTypes.NestedType' since we're only interested in
5346 * class.cs (TypeContainer.DefineType): Don't resolve the type
5347 parameters here; do this later in ResolveType() after the type
5348 tree has been resolved.
5349 (TypeContainer.ResolveType): New public method; this is called
5350 after the type tree is resolved and before the types are being
5351 populated. We resolve the generic constraints here.
5352 (TypeContainer.DoDefineMember): Check the constraints on our base
5353 class and interfaces.
5355 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5356 set the `ResolvingTypeTree' flag on the EmitContext.
5358 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5360 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5362 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5364 * expression.cs (Argument.GetParameterModifier): Turned to property.
5365 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5367 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5370 2005-05-09 Raja R Harinath <rharinath@novell.com>
5373 * decl.cs (MemberCache.AddMethods): Register override methods,
5374 rather than non-override methods.
5375 * typemanager.cs (RegisterOverride): New.
5376 (IsOverride): Update.
5378 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5380 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5382 2005-05-06 Martin Baulig <martin@ximian.com>
5385 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5386 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5388 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5392 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5393 recursive declaration.
5395 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5397 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5399 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5401 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5403 2005-05-05 Raja R Harinath <rharinath@novell.com>
5406 * decl.cs (DeclSpace.FamilyAccessible):
5407 Use TypeManager.IsNestedFamilyAccessible.
5409 Fix reopened #64812.
5410 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5413 2005-05-04 Raja R Harinath <rharinath@novell.com>
5414 Abin Thomas <projectmonokochi@rediffmail.com>
5415 Anoob V E <projectmonokochi@rediffmail.com>
5416 Harilal P R <projectmonokochi@rediffmail.com>
5419 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5420 allow access to all static members.
5422 2005-05-04 Martin Baulig <martin@ximian.com>
5424 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5426 2005-05-04 Martin Baulig <martin@ximian.com>
5430 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5431 section at the end; make things work if `default' is not the last
5434 2005-05-04 Martin Baulig <martin@ximian.com>
5438 * statement.cs (Switch): Replaced the `got_default' field with a
5439 `default_section' one.
5440 (Switch.CheckSwitch): Set `default_section' here.
5441 (Switch.Resolve): If we're a constant switch and the constant is
5442 not found, use the default section.
5444 2005-05-03 Martin Baulig <martin@ximian.com>
5446 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5448 * statement.cs (Foreach.ArrayForeach): New nested class.
5449 (Foreach.TemporaryVariable): New nested class.
5450 (Foreach.EmitArrayForeach): Removed; this is now in the new
5453 2005-05-03 Raja R Harinath <rharinath@novell.com>
5455 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5457 (VerifyPendingMethods): Revert change below.
5459 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5460 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5461 that used to trigger warning -28. Remove warning -28.
5462 * expression.cs (Invocation.OverloadResolve): Use
5463 TypeManager.IsOverride to distinguish override methods.
5466 * pending.cs (VerifyPendingMethods): If a base type implements the
5467 requested interface, don't bother checking individual methods of
5468 the base type. As a side-effect, this prevents the creation of
5469 unnecessary proxies.
5471 2005-05-02 Martin Baulig <martin@ximian.com>
5475 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5476 Also `And' the locals if the old vector is null.
5477 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5478 null; in this case we basically reset all the variables.
5480 2005-05-02 Martin Baulig <martin@ximian.com>
5484 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5485 Added `FlowBranching branching' argument; always `and' the
5486 variables instead of `or'ing them unless we're an infinite loop.
5488 * statement.cs (While.Resolve): Create a new sibling unless we're
5491 2005-05-02 Martin Baulig <martin@ximian.com>
5495 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5496 arguments; use it instead of creating a new TopLevelBlock.
5497 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5498 our ConstructorInitializer.
5501 (TopLevelBlock.TopLevelBranching): New public property.
5502 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5503 and create our `TopLevelBranching'.
5505 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5506 anonymous method host, use `block.TopLevelBranching' rather than
5507 creating a new branching.
5509 2005-04-20 Miguel de Icaza <miguel@novell.com>
5511 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5512 a ScopeInfo, if any of the current children is a child of the new
5513 entry, move those children there.
5515 2005-04-30 Martin Baulig <martin@ximian.com>
5517 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5518 at the beginning of a SwitchSection. Fix #73335.
5520 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5523 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5525 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5526 (FieldExpr.DoResolve): Obsolete members are ignored for field
5529 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5531 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5532 of arrays detection.
5534 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5536 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5538 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5541 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5543 * cs-parser.jay: Use the prefered version of -unsafe in error
5546 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5548 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5551 2005-04-20 John Luke <john.luke@gmail.com>
5553 * driver.cs: fix typo in error message, --outout to --output
5555 2005-04-30 Martin Baulig <martin@ximian.com>
5557 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5558 handle the .NET 2.x security attributes.
5560 2005-04-30 Martin Baulig <martin@ximian.com>
5563 (TypeManager.ExpandInterfaces): Don't add things twice.
5566 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5568 2005-04-29 Martin Baulig <martin@ximian.com>
5570 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5572 * anonymous.cs: Added support for anonymous generic methods.
5574 2005-04-29 Martin Baulig <martin@ximian.com>
5576 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5579 2005-04-29 Martin Baulig <martin@ximian.com>
5581 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5583 * expression.cs (New.DoResolve): Fix the CS0304 check.
5585 2005-04-29 Martin Baulig <martin@ximian.com>
5587 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5590 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5591 explicit interface implementation, compare the interface types.
5592 (MethodData.Define): Use the new naming scheme from the latest
5594 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5596 * decl.cs (MemberName.GetMemberName): Removed.
5597 (MemberName.MethodName, FullName): New properties.
5599 2005-04-25 Raja R Harinath <rharinath@novell.com>
5601 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5603 2005-04-22 Martin Baulig <martin@ximian.com>
5605 * generic.cs (GenericMethod): Create the EmitContext in the
5606 `Define()'; in `Define(MethodBuilder)', create the type parameters
5607 before calling `Define()'. Fixes #73933.
5609 2005-04-22 Martin Baulig <martin@ximian.com>
5612 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5613 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5615 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5616 ConstructedType, check its constraints.
5618 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5620 * codegen.cs (InRefOutArgumentResolving): New field.
5622 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5623 fields outside contructor.
5625 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5627 2005-04-19 Miguel de Icaza <miguel@novell.com>
5629 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5630 parameter code was not completed ever, so it was not as up-to-date
5631 as local variables. Must finish it.
5633 The bug fix was to compare the Toplevel of the block, not the
5634 current block. Thanks for Ben for pointing this out.
5636 2005-04-19 Raja R Harinath <rharinath@novell.com>
5638 * decl.cs (AddMethods): Use the declaring type of the problem
5639 method to determine if we want to squash a warning.
5641 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5643 * attribute.cs: Removed debug output.
5645 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5647 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5650 2005-04-18 Raja R Harinath <rharinath@novell.com>
5653 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5654 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5655 all null comparisons against reference types.
5657 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5660 * class.cs (TypeContainer.CircularDepException) New nested
5662 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5663 (TypeContainer.DefineType): Removed error, reset InTransit before
5665 (Class.DefineType): Throw exception when is in Transit.
5666 Catch exception and report error.
5667 (Struct.DefineType): Throw exception when is in Transit.
5668 Catch exception and report error.
5669 (Interface.DefineType): Throw exception when is in Transit.
5670 Catch exception and report error.
5672 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5673 handle nested exception handlers.
5675 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5678 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5679 InFinally and InCatch storage.
5681 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5682 (Catch.Resolve): Set and Restore ec.InCatch.
5683 (Try.Resolve): Set and Restore ec.InFinally.
5684 (Try.HasCatch): True when try has catch.
5686 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5688 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5689 for the same event member, so exclude such cases from warning 419.
5692 2005-04-16 Miguel de Icaza <miguel@novell.com>
5694 * expression.cs (Binary.ResolveOperator): Apply patch from John
5695 Luke to fix bug 59864: operators &, | and ^ on enumerations
5696 require that the same enum type on both sides.
5698 * driver.cs: Add warnings to old flag usage, this is to assist
5699 people who produce Makefiles and hope that the Makefiles will be
5702 * class.cs (TypeContainer.EmitType): Moved the definition of the
5703 special $PRIVATE$ field from the resolve phase to the Emit phase.
5704 During resolve we do not know if we are a struct with
5705 HasExplicitLayout, we know this only after the attributes for the
5708 Set the FieldOffset to zero on the dummy field that we create for
5709 the class. Fixes 74590.
5711 2005-04-16 Raja R Harinath <rharinath@novell.com>
5714 * ecore.cs (PropertyExpr.resolved): New.
5715 (DoResolve): Use it to handle a case of double resolution here.
5716 Handle a case of identical-name-and-type-name.
5717 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5718 resolution by storing the results of expression resolution back
5719 into the "probes" array.
5721 2005-04-15 Raja R Harinath <rharinath@novell.com>
5723 Fix cs0208-7.cs and cs0208-8.cs.
5724 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5725 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5726 error reporting to point out the reason a struct is not unmanaged.
5728 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5730 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5731 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5733 2005-04-13 Raja R Harinath <rharinath@novell.com>
5736 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5737 IdenticalNameAndTypeName here.
5738 (EventExpr.InstanceResolve): Likewise.
5740 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5742 C# 2.0 DefaultCharSetAttribute implementation
5744 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5745 which allows us to set GlobalNamespace for every resolve.
5746 (Attribute.ResolveArguments): Cut from Resolve.
5747 (Attribute.GetCharSetValue): Returns CharSet named argument.
5748 (Attribute.DefinePInvokeMethod): Gets default charset from
5750 (GlobalAttribute.ResolveAsTypeStep): Override.
5751 (GlobalAttribute.ResolveArguments): Override.
5753 * class.cs (TypeAttr): Is protected.
5755 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5756 (ModuleClass.DefaultCharSetType): New memeber.
5757 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5759 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5760 charset from module.
5762 * delegate.cs (TypeAttr): Override.
5763 (Delegate.DefineType): Use this TypeAttr.
5765 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5766 at very early stage (before types are defined) to resolve model
5767 module attributes. It will probably not work with corlib but it
5770 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5771 charset from module.
5773 * typemanager.cs (default_charset_type): New type.
5775 2005-04-13 Raja R Harinath <rharinath@novell.com>
5777 * decl.cs (MemberCache.AddMethods): Don't warn if
5778 System.Object.Finalize has buggy MethodAttributes.
5780 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5783 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5785 * doc.cs : detect ambiguous reference to overloaded members.
5786 Fixed bug #71603. MS 1.1 csc does not detect it.
5788 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5790 * doc.cs : delegates must not be referenced with parameters.
5793 2005-04-12 Miguel de Icaza <miguel@novell.com>
5795 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5797 2005-04-10 Miguel de Icaza <miguel@novell.com>
5799 * driver.cs (MainDriver): Stop processing if the CLS stage found
5802 (CompilerCallableEntryPoint.InvokeCompiler): Always
5803 reset after execution; Take a TextWriter argument for the
5806 * report.cs: Use the error stream instead of hardcoding stderr.
5808 2005-04-09 Miguel de Icaza <miguel@novell.com>
5810 * class.cs: Reduce code paths to test, too small of an
5811 optimization to make it worth the extra testing. Always perform
5814 2005-04-08 Raja R Harinath <rharinath@novell.com>
5817 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5818 operators that had errors reported on them.
5820 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5822 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5824 (Attribute.Resolve): Add named argument type checking.
5826 * class.cs (FixedField.Define): Use IsPrimitiveType
5828 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5830 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5831 unsafe parameter types.
5833 * statement.cs (Using.ResolveExpression): Add better error description.
5835 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5837 2005-04-08 Raja R Harinath <rharinath@novell.com>
5840 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5841 AttributeUsageAttribute in the emitcontext of the attribute class,
5842 not in the emitcontext of the attributable entity it was attached to.
5843 * cs-parser.jay: Use 'current_class', not 'current_container',
5844 when creating a GlobalAttribute.
5846 2005-04-08 Alp Toker <alp@atoker.com>
5848 * pending.cs: The fix to #58413 failed to compile methods implementing
5849 interfaces with/without params modifiers and vice versa, even though
5850 params modifiers aren't part of the signature. Make the modifier check
5851 less strict as in csc.
5853 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5854 Anoob V E <projectmonokochi@rediffmail.com>
5855 Harilal P R <projectmonokochi@rediffmail.com>
5858 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5859 modifiers of pending methods.
5860 (PendingImplementation.PendingImplementation): Initialize it.
5861 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5862 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5863 with ParameterData. Add check for modifiers.
5864 * class.cs (MethodData.Define): Update to changes.
5866 2005-04-07 Raja R Harinath <rharinath@novell.com>
5868 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5870 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5872 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5875 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5878 * typemanager.cs: Registered RequiredAttributeAttribute.
5880 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5882 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5883 Warning CS0169 is back at level 3.
5884 (IMethodData.SetMemberIsUsed): New method.
5886 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5887 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
5889 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
5891 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
5893 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
5896 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
5899 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
5900 to avoid the problems with nested types.
5902 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
5903 Anoob V.E <projectmonokochi@rediffmail.com>
5904 Harilal P.R <projectmonokochi@rediffmail.com>
5905 Raja R Harinath <rharinath@novell.com>
5908 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
5910 * typemanager (GetConstructor): Make public.
5912 2005-04-05 John Luke <john.luke@gmail.com>
5913 Raja R Harinath <rharinath@novell.com>
5916 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
5917 struct too. Return false quicker in a few cases.
5918 (VerifyUnManaged): Use it.
5920 2005-04-05 Raja R Harinath <rharinath@novell.com>
5923 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
5924 not 'unreachable_seen'.
5926 2005-04-04 Marek Safar <marek.safar@seznam.cz>
5928 * attribute.cs (Attribute.GetValue): Removed unused.
5930 * codegen.cs (CodeGen.TrimExt): Removed unused.
5932 * cs-parser.jay (output): Removed unused.
5934 * cs-tokenizer.cs (hex_digits): Removed unused.
5936 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
5938 * expression.cs (Indirection.LoadExprValue): Removed unused.
5939 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
5941 * iterators.cs (Iterator.param_types): Removed unused.
5943 * statement.cs (Goto.block): Removed unused.
5944 (ToplevelBlock.did): Removed unused.
5945 (Switch.ResolveConstantSwitch): Removed unused.
5947 2005-04-01 Ben Maurer <bmaurer@ximian.com>
5949 * rootcontext.cs: Allow mcs to bootstrap with the compilation
5952 2005-04-19 Martin Baulig <martin@ximian.com>
5954 Merged r42462 from MCS and made it work for GMCS.
5956 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
5958 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
5960 2005-04-01 Raja R Harinath <rharinath@novell.com>
5962 Fix #74232 and cs0208-3.cs.
5963 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
5964 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
5965 unmanaged type. Don't use FieldBuilders when 't' is a
5966 TypeBuilder. Use ModFlags and MemberType fields.
5967 * class.cs (MemberBase.member_type): Rename from MemberType.
5968 (MemberBase.MemberType): New property. Determines member_type on
5970 (MemberBase.DoDefine): Don't initialize MemberType here.
5971 (FieldMember.Define): Likewise.
5973 2005-04-01 Marek Safar <marek.safar@seznam.cz>
5976 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
5977 Attributes are emitted there.
5979 2005-04-01 Raja R Harinath <rharinath@novell.com>
5981 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
5982 keyword in 'partial enum' too.
5983 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
5985 Report from Kamil Skalski <nazgul@omega.pl>.
5988 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
5989 have partial containers too.
5991 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
5992 in block' checks to Block.CheckInvariantMeaningInBlock.
5993 * statement.cs (Block.GetKnownVariableInfo): Make private.
5994 (Block.IsVariableUsedInChildBlock): Remove.
5995 (Block.IsVariableUsedInBlock): Likewise.
5996 (Block.CheckInvariantMeaningInBlock): New. Show location of
5997 conflicting declaration.
5998 (Block.AddVariable): Make error messages less long-winded and more
5999 specific. Show location of conflicting declaration.
6000 * parameter.cs (Parameters.Location): New readonly property.
6002 2005-03-31 Raja R Harinath <rharinath@novell.com>
6004 Clean up semantics of invoking ResolveMemberAccess.
6005 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
6006 can have an instance, ensure that we pass in a non-TypeExpression
6007 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
6008 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
6009 argument. Update to changes and simplify.
6010 (FieldExpr.Emitinstance): Remove CS0120 check.
6011 (PropertyExpr.EmitInstance): Likewise.
6012 * expression.cs (Argument.Resolve): Likewise.
6013 (Invocation.DoResolve): Update to changes in semantics of
6016 2005-03-31 Marek Safar <marek.safar@seznam.cz>
6019 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
6022 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
6024 2005-03-31 Raja R Harinath <rharinath@novell.com>
6026 Fix difference in behaviour with commandline invocation.
6027 * driver.cs (Driver.Reset): New.
6028 (CompilerCallableEntryPoint): Call it.
6030 * statement.cs (If.Resolve): Avoid spurious "uninitialized
6031 variable" warnings if the boolean expression failed to resolve.
6033 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
6035 * attribute.cs: Fix the union of several permissions when some of them
6036 are unrestricted (so the result isn't an unrestricted permission set).
6039 2005-03-30 Raja R Harinath <rharinath@novell.com>
6041 * ecore.cs (MemberExpr): New class. Convert from interface
6043 (MemberExpr.ResolveMemberAccess): Refactor and move here from
6044 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
6046 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
6047 (MethodGroupExpr.IsExplicitImpl): Remove.
6048 (Expression.GetFieldFromEvent): Remove.
6049 (SimpleName.MemberStaticCheck): Remove.
6050 (SimpleName.DoSimpleNameResolve): Update to changes.
6051 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
6052 (MemberAccess.IdenticalNameAndTypeName): Remove.
6053 (MemberAccess.error176): Move to MemberExpr.
6054 (MemberAccess.DoResolve): Update to changes.
6055 (BaseAccess.DoResolve): Likewise.
6057 2005-03-30 Marek Safar <marek.safar@seznam.cz>
6059 C# 2.0 Conditional attribute class implementation
6061 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
6062 Analyzes class whether it has attribute which has ConditionalAttribute
6063 and its condition is not defined.
6065 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
6066 (Class.IsExcluded): New method. Search for at least one defined
6067 condition in ConditionalAttribute of attribute class.
6069 2005-03-30 Raja R Harinath <rharinath@novell.com>
6071 * ecore.cs (PropertyExpr): Derive from Expression, not
6072 ExpressionStatement.
6073 (PropertyExpr.EmitStatement): Remove.
6075 2005-03-29 Raja R Harinath <rharinath@novell.com>
6078 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
6079 internal field "value__" of an enum be private. The examples for
6080 "value__" that I found on MSDN all used FieldAttributes.Private.
6082 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
6083 Don't mention IL method attribute names.
6085 Fix #47991. Remove a TODO.
6086 * statement.cs (Block.Toplevel): Make into a field.
6087 (Block.Parameters): Move into ToplevelBlock.
6088 (Block.known_variables): Rename from child_variable_names.
6089 (Block.Block): Remove variants that take Parameters. Initialize
6090 'Toplevel' with the immediately surrounding toplevel block.
6091 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
6092 LocalInfo parameter.
6093 (Block.GetKnownVariableInfo): New.
6094 (Block.IsVariableNameUsedInChildBlock): Update.
6095 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
6096 the block, even though it may not be in scope.
6097 (Block.AddVariable): Remove Parameters parameter. Use
6098 Toplevel.Parameters instead.
6099 (Block.AddConstant): Remove Parameters parameter.
6100 (Block.GetParameterReference): Update to use Toplevel.Parameters.
6101 (Block.IsParamaterReference): Likewise.
6102 (Block.IsLocalParameter): Likewise. Simplify a lot.
6103 (ToplevelBlock.Parameters): New. Moved from Block.
6104 (ToplevelBlock.ToplevelBlock): Update to changes. Always
6105 initialize Parameters to a non-null value.
6106 * cs-parser.jay: Update to changes.
6107 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
6108 simple names that mean different things in the same block. Use
6109 Block.IsVariableNameUsedInBlock.
6111 2005-03-28 Raja R Harinath <rharinath@novell.com>
6113 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
6115 2005-03-26 Raja R Harinath <harinath@acm.org>
6118 * assign.cs (Assign.DoResolve): When the RHS of an assignment
6119 fails to resolve, ensure that the LHS is still resolved as an
6122 2005-03-25 Raja R Harinath <harinath@acm.org>
6124 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
6126 (Enum.current_ec): Remove.
6127 (Enum.LookupEnumValue): Remove EmitContext argument.
6128 Just uses the one created during DefineType.
6129 (Enum.FindMembers): Update.
6130 * expression.cs (MemberAccess.DoResolve): Update.
6132 2005-03-22 Marek Safar <marek.safar@seznam.cz>
6134 * assign.cs (Assign.DoResolve): Check for CS1717 when
6135 source and target are same (uses Equals).
6137 * expression.cs (LocalVariableReference, ParameterReference,
6138 This): Implemented Equals, GetHashCode.
6140 * statement.cs (Block.GetParameterReference): Removed useless
6143 2005-03-22 Raja R Harinath <rharinath@novell.com>
6146 * statement.cs (Block.AddVariable): Ensure that we skip implicit
6147 blocks before deciding whether the error is cs0136 or cs0128.
6149 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
6150 (using_alias_directive, using_namespace_directive): Pass
6151 MemberName, not an expression to Namespace.UsingAlias and
6153 (MakeName): Use the MemberName of the namespace.
6154 * namespace.cs (Namespace.MemberName): New.
6155 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
6156 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
6158 * decl.cs (MemberName.Name): Make readonly.
6159 (MemberName.FromDotted): New "constructor".
6160 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
6161 (MemberCore.Name): Compute from MemberName on demand.
6162 (MemberCore.SetMemberName): Provide a way to change the
6164 (MemberCore.AddToContainer): Don't take a fullname parameter.
6165 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
6166 fully qualified name of the container to the member name.
6167 (TypeContainer.AddToTypeContainer): Use a fully qualified name
6168 only if the type is a member of the root container.
6169 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
6170 MemberName.Left rather than searching for an embedded ".".
6171 (PartialContainer.CreatePart): Update to changes in RootContext.
6172 (MemberBase.ShortName): Turn into a property. Use
6173 MemberCore.SetMemberName.
6174 (MemberBase.ExplicitInterfaceName): Remove.
6175 (MemberBase.UpdateMemberName): Remove.
6176 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
6177 (PropertyBase.SetMemberName): New override.
6178 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
6179 (Tree.GetDecl): New.
6180 (Tree.AllDecls): Rename from Decls.
6181 * attribute.cs, enum.cs, report.cs: Update to changes.
6182 * driver.cs (MainDriver): Use MemberName.FromDotted on
6183 RootContext.MainClass.
6185 2005-03-21 Marek Safar <marek.safar@seznam.cz>
6187 * class.cs (FixedField.Define): Check for CS1664 and more sanity
6190 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
6192 2005-03-18 Marek Safar <marek.safar@seznam.cz>
6194 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
6195 property accessor modifiers.
6197 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
6198 fixed buffer attribute (CS1716).
6199 (PropertyMethod.HasCustomAccessModifier): When property accessor
6200 has custom modifier.
6202 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
6204 (PropertyExpr.DoResolveLValue): Add CS0272.
6206 2005-03-17 Miguel de Icaza <miguel@novell.com>
6208 * convert.cs: When converting to a pointer, use the proper Conv.U
6209 or Conv.I depending on the source data type.
6211 * cs-tokenizer.cs: Make the size for large decimal constants,
6214 2005-03-17 Martin Baulig <martin@ximian.com>
6216 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6217 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6219 2005-03-17 Martin Baulig <martin@ximian.com>
6221 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6222 to bool so we can return an error condition.
6223 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6226 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
6228 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
6231 2005-03-16 Raja R Harinath <rharinath@novell.com>
6233 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
6234 Refactor to avoid traversing the list of assemblies, and to avoid
6235 string concatenation.
6236 * typemanager.cs (guid_attr_type): Remove.
6237 (negative_hits, pointers, references): Remove hashes.
6239 (GetConstructedType): New. Uses type_hash to handle constructed
6240 types (arrays, references, pointers).
6241 (GetReferenceType, GetPointerType): Use it.
6242 (GetNestedType): New. Uses type_hash to handle nested types of
6244 (LookupType, LookupTypeDirect): Remove.
6245 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
6246 'types' hash and LookupTypeReflection directly.
6247 (params_string, params_object): Use GetConstructedType.
6248 * namespace.cs (Namespace.cached_types): New. Cache of reflected
6250 (Namespace.Lookup): Use cached_types.
6251 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
6252 provided by old TypeManager.LookupType.
6253 * rootcontext.cs (MakeFQN): Remove.
6254 * decl.cs (DeclSpace.MakeFQN): Likewise.
6255 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
6256 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6257 TypeManager.GetConstructedType.
6258 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
6260 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
6262 * cs-parser.jay: Fix build.
6264 2005-03-15 Marek Safar <marek.safar@seznam.cz>
6266 * class.cs (TypeContainer.CircularDepException) New nested
6267 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
6269 * cs-parser.jay: Reports CS1527 for any namespace element.
6271 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
6274 * expression.cs (ParameterReference.IsAssigned): Changed error to
6276 (Error_WrongNumArguments): Moved CS0245 detection here.
6278 * statement.cs (Return.Resolve): Add CS1622 report.
6280 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6282 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6284 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6286 * attribute.cs expression.cs: Get rid of some allocations.
6288 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6290 * doc.cs : just eliminate the latest change.
6292 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6294 * doc.cs : commented out the latest change. It breaks xml-030.cs
6296 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6298 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6299 fail. So invoke CreateType() in FindDocumentedType().
6301 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6303 * cs-tokenizer.cs : added IsKeyword().
6304 * doc.cs : Detect keyword incorrectly used as identifier.
6305 Allow identifiers prefixed by @.
6307 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6309 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6310 It caused exception in namespace resolving (again!).
6312 * class.cs (Class.ctor): Removed exit.
6313 (PropertyMethod.ctor): ditto.
6315 * codegen.cs (Codegen.Reset): Reset static data.
6316 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6318 * cs-tokenizer.cs (Cleanup): Removed.
6320 * driver.cs (GetSystemDir): Rewrote to one line command.
6321 It caused problem with unloaded dynamic modules.
6322 (UnixParseOption): Removed Exit.
6323 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6324 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6325 Now can be mcs used as library.
6327 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6330 * location.cs (Reset): Reset static data.
6332 * namespace.cs (Reset): Reset static data.
6334 * report.cs (Report.Reset): Reset static data.
6336 * rootcontext.cs (RootContext.Reset): Reset static data.
6338 * tree.cs (RootTypes.ctor): Use Location.Null
6340 * typemanager.cs (TypeManager.Reset): Reset static data.
6341 (CoreLookupType): Removed Exit.
6342 (TypeHandle.Reset): Reset static data.
6344 2005-03-10 Raja R Harinath <rharinath@novell.com>
6347 * typemanager.cs (ComputeNamespaces): Import namespaces from
6348 referenced modules too.
6350 2005-03-09 Raja R Harinath <rharinath@novell.com>
6352 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6355 2005-03-09 Raja R Harinath <rharinath@novell.com>
6357 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6358 enclosing DeclSpace. This ensures that a name-lookup populates
6359 more caches and there are fewer 'TypeExpression's. Carve out
6360 nested type lookup into ...
6361 (LookupNestedTypeInHierarchy): ... this.
6363 2005-04-15 Martin Baulig <martin@ximian.com>
6365 Merged r41590 from MCS and make it work in the generics land.
6367 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6370 * class.cs (PartialContainer.UpdateConstraints): Removed.
6371 (PartialContainer.CheckConstraints): Removed.
6372 (PartialContainer.SetParameterInfo): Store the constraints here.
6373 (PartialContainer.DefineTypeParameters): New public method;
6374 resolve the type parameter's constraints here. Note that the
6375 PartialContainer doesn't have an EmitContext anymore, so we must
6376 do this in the ClassPart.
6378 2005-03-09 Raja R Harinath <rharinath@novell.com>
6380 Clean up a few partial-class semantics.
6381 Fixes test-357.cs and cs1618-2.cs.
6382 * cs-parser.jay (struct_declaration): Use 'current_class' as
6383 parent of newly-created struct. Remove call to Register ().
6384 Use 'pop_current_class' to complete handing the current struct.
6385 (interface_declaration): Likewise.
6386 (class_declaration): Likewise.
6387 (enum_declaration): Use 'current_class' as parent of newly created
6389 (delegate_declaration): Likewise.
6390 (pop_current_class): New function. This is used to handle closing
6391 up the 'current_class' and 'current_container', and pointing them
6392 to the enclosing class/container.
6393 (CSharpParser): Initialize 'current_class' too.
6394 * decl.cs (MemberCore): Add check for invariant: a partial
6395 container is not a parsed entity, and thus does not enclose any
6397 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6398 (DeclSpace.BaseTypeExpr): Use it.
6399 (DeclSpace.LookupType): Add check for invariant.
6400 * class.cs (TypeContainer): Add check for invariant: a nested
6401 class should have the same NamespaceEntry as its enclosing class.
6402 (TypeContainer.EmitFieldInitializers): Make virtual.
6403 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6405 (TypeContainer.Register): Remove.
6406 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6407 null. Use TypeResolveEmitContext for resolving base types and
6408 interfaces. Move initialization of Parts.TypeBuilder here from
6410 (TypeContainer.DefineNestedTypes): ... here.
6411 (PartialContainer): Take a Namespace not a NamespaceEntry.
6412 (PartialContainer.Create): Don't use Register. Call the
6413 appropriate Add... function directly.
6414 (ClassPart): Take both the PartialContainer and the enclosing
6415 class as constructor arguments.
6416 (ClassPart.EmitFieldInitializers): Override.
6417 (ClassPart.PartFindNestedTypes): Remove.
6418 (FieldBase.GetInitializerExpression): Resolve the initializer
6419 expression in the emit context of the enclosing class.
6420 * tree.cs (RootTypes): Remove Register ().
6422 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6424 * cs-parser.jay: Removed CS0134.
6426 * driver.cs: Removed CS1901.
6428 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6429 for predefined types.
6431 2005-03-07 Duncan Mak <duncan@novell.com>
6433 * codegen.cs (Save): Catch UnauthorizedAccessException as
6434 well. Fixes bug #73454.
6436 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6438 * cs-tokenizer.cs (xtoken): Add CS1035.
6440 * class.cs (MethodData.Define): Add CS0683.
6441 (FieldMember.ctor): Add CS0681.
6443 2005-03-07 Raja R Harinath <rharinath@novell.com>
6445 * ecore.cs (SimpleName.DoResolve): Rename from
6446 SimpleName.DoResolveAllowStatic.
6447 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6448 Pass 'intermediate' flag to MemberStaticCheck.
6449 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6450 of "intermediate" lookups via MemberAccess.
6451 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6452 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6454 2005-03-07 Raja R Harinath <rharinath@novell.com>
6457 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6458 slipped in because of variable names that are identical to a
6459 builtin type's BCL equivalent ('string String;', 'int Int32;').
6460 (PropertyExpr.EmitInstance): Likewise.
6462 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6464 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6466 * report.cs (warning_ignore_table): Made public.
6468 2005-03-04 Raja R Harinath <rharinath@novell.com>
6471 * class.cs (MethodData.Emit): Pass 'container' to
6472 container.GetObsoleteAttribute instead of 'container.Parent'.
6474 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6476 * cs-parser.jay: Add 1534 error test.
6478 * iterators.cs (Yield.CheckContext): Add error 1629.
6479 (Iterator.ctor): Save unsafe modifier.
6480 (MoveNextMethod.DoEmit): Restore unsafe context.
6482 * namespace.cs (UsingAlias): Better error message.
6484 2005-03-03 Dan Winship <danw@novell.com>
6486 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6487 the warning message [#73219]
6489 2005-03-03 Raja R Harinath <rharinath@novell.com>
6491 Fix compile with MCS 1.0.0.0.
6492 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6493 w_restore to not depend on string constant folding.
6495 2005-03-03 Raja R Harinath <rharinath@novell.com>
6497 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6498 CS0246 check to users who passed 'silent = false'.
6499 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6501 (SimpleName.SimpleNameResolve): Update.
6502 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6503 (MemberAccess.IdenticalNameAndTypeName): Update.
6504 * doc.cs (FindDocumentedTypeNonArray): Update.
6506 2005-03-03 Raja R Harinath <rharinath@novell.com>
6508 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6509 * parameters.cs (ComputeAndDefineParameters): Remove.
6510 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6511 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6512 Use GetParameterInfo.
6514 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6516 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6518 2005-03-02 Raja R Harinath <rharinath@novell.com>
6520 Unify DeclSpace.LookupType and DeclSpace.FindType.
6521 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6522 is in charge of defining nested types on demand.
6523 (DeclSpace.LookupType): Use it when the current_type is a
6524 TypeBuilder. Use LookupTypeDirect for reflected types.
6525 (DeclSpace.FindType): Remove.
6526 (DeclSpace.LookupInterfaceOrClass): Likewise.
6527 (DeclSpace.DefineTypeAndParents): Likewise.
6528 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6529 DeclSpace.LookupType.
6530 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6531 * typemanager.cs (LookupType): Simplify.
6532 (AddUserType): Remove type from negative_hits.
6533 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6534 * class.cs (TypeContainer.FindMembers): Move handling of nested
6536 (TypeContainer.FindMembers_NestedTypes): ... here.
6537 (TypeContainer.FindNestedType): Implement override.
6538 (ClassPart.FindNestedType): Delegate to PartialContainer.
6539 (ClassPart.PartFindNestedType): Looks up the nested types of the
6542 2005-04-14 Martin Baulig <martin@ximian.com>
6544 * generic.cs (ConstructedType): Moved all the type lookup and
6545 nested class logic into SimpleName.
6546 (ConstructedType.ResolveConstructedType): Our underlying type is
6547 already fully resolved; all the type lookup stuff is in
6550 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6551 constructed types here instead of in ConstructedType.
6553 * decl.cs (MemberName.GetTypeExpression): Always create a
6554 SimpleName, not a ConstructedType.
6555 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6557 2005-03-02 Martin Baulig <martin@ximian.com>
6559 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6560 static constructor in static classes.
6562 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6564 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6565 sizeParamIndex is not specified.
6567 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6570 * report.cs (WarningMessage.IsEnabled): Missing null check.
6572 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6574 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6575 in the fields and not in the properties.
6577 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6579 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6582 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6584 * attribute.cs: Small refactoring (improved robustness).
6585 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6586 (ValidateGuid): Removed.
6587 (Resolve): Removed referenced to above mentioned.
6588 (GetAttributeUsage): Made private and changed to work without
6590 (GetIndexerAttributeValue): Don't crash.
6591 (GetConditionalAttributeValue): Ditto.
6592 (GetClsCompliantAttributeValue): Ditto.
6593 (ExtractSecurityPermissionSet): All attributes exceptions are
6595 (GetPropertyValue): New helper.
6596 (GetMethodImplOptions): New method.
6597 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6598 some missing properties.
6600 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6601 (Method.ApplyAttributeBuilder): Updated.
6603 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6606 2005-02-28 Raja R Harinath <rharinath@novell.com>
6609 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6610 non-simple types (array, pointer, reference).
6612 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6614 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6616 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6618 (Method.CheckBase): Catch wrong destructor here.
6619 (MethodData.Define): Add errors 550, 668.
6621 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6623 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6625 * pending.cs (VerifyPendingMethods): Add error 551.
6627 * typemanager.cs (CSharpName): Next error report helper.
6629 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6631 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6632 attributes. Removed useless attribute double check.
6633 It saves almost 2MBs for corlib.
6635 2005-02-25 Raja R Harinath <rharinath@novell.com>
6638 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6639 called twice in case of error.
6641 2005-02-23 Chris Toshok <toshok@ximian.com>
6643 Fix compiler portions of #72827.
6644 * statement.cs (Block.Emit): call Begin/EndScope on the
6645 EmitContext instead of the ILGenerator.
6647 * codegen.cs (EmitContext.BeginScope): new method, call
6648 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6650 (EmitContext.BeginScope): same, but EndScope and CloseScope
6652 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6653 offset and call the superclass's OpenScope(int) with it.
6654 (SymbolWriter.CloseScope): get the current il
6655 offset and call superclass's CloseScope(int) with it.
6657 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6659 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6660 CS1677 for out and ref as well.
6662 * class.cs (Method.Define): Add error CS1599 detection.
6664 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6666 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6668 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6670 * support.cs.cs (ModifierDesc): New helper method.
6672 2005-02-23 Raja R Harinath <rharinath@novell.com>
6673 Abin Thomas <projectmonokochi@rediffmail.com>
6674 Anoob V E <projectmonokochi@rediffmail.com>
6675 Harilal P R <projectmonokochi@rediffmail.com>
6678 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6679 MemberLookup (used for error reporting) actually returns a result.
6680 Fix error report number (122, not 112).
6682 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6683 Anoob V E <projectmonokochi@rediffmail.com>
6684 Harilal P R <projectmonokochi@rediffmail.com>
6687 * pending.cs (PendingImplementation.GetAbstractMethods):
6688 Find NonPublic members too.
6690 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6692 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6695 * class.cs (MethodCore.CheckMethodAgainstBase):
6696 Add error 239 report.
6698 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6700 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6702 * class.cs (Operator.Define): Add error 217 report.
6704 2005-02-21 Raja R Harinath <rharinath@novell.com>
6707 * expression.cs (Invocation.IsApplicable): Make public.
6708 (Invocation.IsParamsMethodApplicable): Likewise.
6709 * delegate.cs (Delegate.VerifyApplicability): Don't use
6710 Invocation.VerifyArgumentCompat for parameter applicability
6711 testing. Use Invocation.IsApplicable and
6712 Invocation.IsParamsMethodApplicable.
6714 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6716 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6718 * class.cs (Operator.Define): Add error 217 report.
6720 2005-02-21 Raja R Harinath <rharinath@novell.com>
6722 * namespace.cs (UsingEntry.Resolve): Undo change below.
6724 2005-02-21 Raja R Harinath <rharinath@novell.com>
6727 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6728 disable the error message when the extended MemberLookup also
6730 (Expression.MemberLookupFinal): Update.
6731 (SimpleName.DoSimpleNameResolve): Update.
6732 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6733 Don't use MemberLookupFinal.
6734 (New.DoResolve): Update.
6735 (BaseAccess.CommonResolve): Update.
6737 2005-02-21 Raja R Harinath <rharinath@novell.com>
6740 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6741 occured previously, don't resolve again.
6743 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6746 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6747 argument. Call ResolveAttributeUsage for unresolved.
6748 when types doesn't match ctor arguments.
6750 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6751 for nested attribute classes.
6752 (Class.attribute_usage): Removed.
6753 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6754 for attribute class.
6756 * ecore.cs (IsAttribute): Removed.
6758 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6760 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6762 (attribute_types): Removed.
6763 (EmitCode): Global attributes are emited as the latest.
6765 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6767 * class.cs (EmitFieldInitializers): Don't emit field initializer
6768 for default values when optimilization is on.
6770 * constant.cs (Constant.IsDefaultValue): New property.
6772 * driver.cs: Add /optimize handling.
6776 * literal.cs: Implement new IsDefaultValue property.
6778 * rootcontext.cs (Optimize): New field, holds /optimize option.
6780 2005-02-18 Raja R Harinath <rharinath@novell.com>
6782 Fix crasher in re-opened #72347.
6783 * namespace.cs (Namespace.Lookup): Return null if
6784 DeclSpace.DefineType returns null.
6787 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6789 2005-02-18 Raja R Harinath <rharinath@novell.com>
6791 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6792 now returns null if it cannot resolve to an lvalue.
6793 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6794 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6795 returned null. Remove check for SimpleName.
6796 (EventExpr.DoResolveLValue): New.
6797 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6798 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6800 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6802 (Unary.ResolveOperator): Move CS0211 check ...
6803 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6805 (Unary.DoResolveLValue): Simplify.
6806 (AddressOf.DoResolveLValue): New.
6807 (ArrayAccess.DoResolveLValue): New.
6809 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6811 * attribute.cs (Attribute.Resolve): Add arguments casting for
6812 when types doesn't match ctor arguments.
6814 2005-02-16 Raja R Harinath <rharinath@novell.com>
6816 Fix parts of #63202.
6817 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6818 lookup of operator in base type. Ensure that all checks happen
6819 when the operator resolves to an "op_..." method.
6821 2005-02-15 Raja R Harinath <rharinath@novell.com>
6824 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6825 'ignore_cs0104' parameter. Pass it to ...
6826 (NamespaceEntry.Lookup): ... this.
6827 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6828 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6829 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6830 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6831 Update. Request that cs0104 errors be ignored.
6832 (ComposedCast.ResolveAsTypeStep): Update.
6834 2005-02-14 Raja R Harinath <rharinath@novell.com>
6837 * expression.cs (Invocation.BetterFunction): Remove support for
6838 comparing virtual functions and their overrides.
6839 (Invocation.IsOverride): New.
6840 (Invocation.OverloadResolve): Don't consider 'override' functions
6841 during candidate selection. Store them in a lookaside list.
6842 If the selected method is a 'virtual' function, use the list to
6843 find any overrides that are closer to the LHS type.
6845 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6847 * expression.cs (New.DoResolve): Add complex core type reduction.
6848 (New.Constantify): Converts complex core type syntax like 'new int ()'
6851 2005-02-14 Raja R Harinath <rharinath@novell.com>
6853 * decl.cs (EntryType.EntryType): New constructor to create an
6854 updated copy of a cache entry.
6855 (MemberCache.AddMethods): Use it.
6856 (MemberCache.ClearDeclaredOnly): Remove.
6857 (MemberCache.MemberCache): Update.
6859 2005-02-11 Miguel de Icaza <miguel@novell.com>
6861 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6862 variable. This one is represents the actual low-level declaration
6863 of the method, as opposed to the semantic level `IsStatic'.
6865 An anonymous method which is hosted into a static method might be
6866 actually an instance method. IsStatic would reflect the
6867 container, while MethodIsStatic represents the actual code
6870 * expression.cs (ParameterReference): Use the new MethodIsStatic
6871 instead of IsStatic.
6873 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6874 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6875 set on the current EmitContext.
6877 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6878 resolve our casted expression as an LValue. This triggers the
6879 proper LValue processing that is later required by Assign.
6883 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6885 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6887 C# 2.0 Fixed buffer implementation
6889 * anonymous.cs: Update after RegisterHelperClass renaming.
6891 * attribute.cs (AttributeTester.fixed_buffer_cache):
6892 Cache of external fixed buffers.
6893 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
6894 implementation if field is fixed buffer else null.
6897 (TypeContainer.AddField): Accept FieldMember instead of Field.
6898 (FieldBase.IsFieldClsCompliant): Extracted code from
6899 VerifyClsCompliance descendant customization.
6900 (FixedField): New class handles fixed buffer fields.
6901 (FixedFieldExternal): Keeps information about imported fixed
6903 (IFixedField): Make access to internal or external fixed buffer
6906 * cs-parser.jay: Add fixed buffer parsing.
6908 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
6911 * expression.cs (Indirection): Extended implementation to accept
6913 (PointerArithmetic.Emit): Get element from fixed buffer as well.
6914 (ElementAccess.MakePointerAccess): Get type as parameter.
6915 (DoResolve): Add fixed buffer field expression conversion.
6916 (DoResolveLValue): Ditto.
6917 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
6918 (ArrayPtr): Derives from FixedBufferPtr.
6919 (ArrayPtr.Emit): Add extra emit for array elements.
6921 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
6923 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
6924 for compiler generated types.
6925 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
6927 * statement.cs (Fixed): Refactored to be easier add fixed buffer
6928 and consume less memory.
6929 (Fixed.Resolve): Add fixed buffer case.
6931 * typemanager.cs (compiler_generated_attr_ctor,
6932 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
6933 (HasElementType): Add our own implementation to work on every
6936 2005-02-11 Miguel de Icaza <miguel@novell.com>
6938 * anonymous.cs (CaptureContext): Track whether `this' has been
6941 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
6942 only captured `this' if it was implicitly done (instance
6943 methods/variables were used).
6945 * codegen.cs (EmitContext.CaptureThis): New method to flag that
6946 `this' must be captured.
6948 2005-01-30 Miguel de Icaza <miguel@novell.com>
6950 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
6951 is null it means that there has been no need to capture anything,
6952 so we just create a sibling.
6954 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
6956 Just a partial fix. The other half is fairly elusive.
6958 2005-02-10 Raja R Harinath <rharinath@novell.com>
6960 Fix #52586, cs0121-4.cs.
6961 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
6962 and return a hashtable.
6963 (MemberCache.ClearDeclaredOnly): New.
6964 (MemberCache.MemberCache): Update to change. Make a deep copy of
6965 the method_hash of a base type too.
6966 (MemberCache.AddMethods): Adapt to having a deep copy of the base
6967 type methods. Overwrite entries with the same MethodHandle so
6968 that the ReflectedType is correct. The process leaves in base
6969 virtual functions and their overrides as distinct entries.
6970 (CacheEntry): Now a class instead of a struct. It shouldn't alter
6971 matters since it was boxed in a ArrayList before.
6972 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
6974 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
6975 case of a virtual function and its override (choose the overload
6977 (Invocation.OverloadResolve): Avoid 'override' members during
6978 'applicable_type' calculation.
6980 2005-03-28 Raja R Harinath <rharinath@novell.com>
6982 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
6983 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
6984 GetTypeHandle. It is possible for a reflected type to derive from
6985 a TypeBuilder (e.g., int[] derives from the TypeBuilder
6986 System.Array during mscorlib compilation).
6987 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
6988 contain a method_hash, don't create one either. Don't create a
6989 deep copy of the base cache's method_hash.
6990 (MemberCache.SetupCache): Rename back from DeepCopy.
6991 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
6992 already initialized. If we see an override function, add its
6993 underlying base virtual function to the member_hash too.
6995 2005-02-09 Raja R Harinath <rharinath@novell.com>
6997 Combine two near-redundant caches.
6998 * typemanager.cs (method_params): Rename from method_internal_params.
6999 (TypeManager.GetParameterData): New. Replace
7000 Invocation.GetParameterData.
7001 (TypeManager.LookupParametersByBuilder): Remove.
7002 * expression.cs (Invocation.method_parameter_cache): Remove.
7003 (Invocation.GetParameterData): Remove.
7005 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
7008 2005-02-08 Raja R Harinath <rharinath@novell.com>
7011 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
7012 TypeManager.multicast_delegate_type is null, resolve it by looking
7013 up "System.MulticastDelegate".
7014 * rootcontext.cs (RootContext.ResolveCore): Simplify.
7016 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
7017 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
7018 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
7021 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
7022 (LabeledStatement.AddReference): New. Set 'referenced'.
7023 (Goto.Resolve): Use it.
7025 2005-02-05 John Luke <john.luke@gmail.com>
7027 * driver.cs: remove duplicate -doc line in Usage ()
7029 2005-02-04 Raja R Harinath <rharinath@novell.com>
7031 * location.cs (Location.AddFile): Fix CS2002 error report.
7033 2005-02-02 Martin Baulig <martin@ximian.com>
7035 * delegate.cs (Delegate.DefineType): Report an internal error if
7036 TypeManager.multicast_delegate_type is null. See bug #72015 for
7039 2005-02-02 Raja R Harinath <rharinath@novell.com>
7041 Fix a crasher in a variant of #31984.
7042 * const.cs (Constant.CheckBase): New override that defers the
7043 new-or-override check in case the base type hasn't been populated
7045 (Constant.Define): Ensure the new-or-override check is performed.
7047 2005-02-01 Duncan Mak <duncan@ximian.com>
7049 * const.cs (LookupConstantValue): Check that `ce' is not null
7050 before calling GetValue ().
7052 2005-02-01 Raja R Harinath <rharinath@novell.com>
7054 Fix test-334.cs (#69519).
7055 * cs-parser.jay (using_alias_directive): Pass in an expression to
7056 NamespaceEntry.UsingAlias.
7057 (using_namespace_directive): Pass in an expression to
7058 NamespaceEntry.Using.
7059 (namespace_name): Don't flatten to a string.
7060 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
7061 (NamespaceEntry.AliasEntry.Resolve): Lookup using
7063 (NamespaceEntry.UsingEntry): Likewise.
7064 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
7066 (NamespaceEntry.LookupForUsing): Remove.
7067 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
7069 (NamespaceEntry.Lookup): Remove support for dotted names.
7071 2005-02-01 Raja R Harinath <rharinath@novell.com>
7073 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
7075 (NamespaceEntry.ImplicitParent): Compute on demand.
7076 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
7077 parallels the current.
7078 (NamespaceEntry.LookupForUsing): Use it.
7079 (NamespaceEntry.Lookup): If the current namespace-entry is
7080 implicit, don't search aliases and using tables.
7082 2005-02-01 Raja R Harinath <rharinath@novell.com>
7085 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
7087 (TypeContainer.BaseCache): Compute on demand.
7088 (TypeContainer.FindMembers): Define constants and types if they're
7089 not already created.
7090 (FieldMember.Define): Move resetting of ec.InUnsafe before error
7092 * const.cs (Constant.Define): Make idempotent.
7094 2005-01-29 Miguel de Icaza <miguel@novell.com>
7096 * pending.cs: Produce better code (no nops produced by using Ldarg
7099 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7100 i - 1' it should be arg + 1.
7104 2005-01-28 Raja R Harinath <rharinath@novell.com>
7106 * attribute.cs (Attribute.CheckAttributeType): Make private
7108 (Attribute.ResolveType): Make virtual.
7109 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
7110 handling of RootContext.Tree.Types.
7112 2005-01-27 Raja R Harinath <rharinath@novell.com>
7114 Update attribute-handling to use the SimpleName/MemberAccess
7116 * cs-parser.jay (attribute): Pass in an expression to the
7117 constructors of Attribute and GlobalAttribute.
7118 * attribute.cs (Attribute): Take an expression for the name.
7119 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
7120 passed in attribute name expression.
7121 (Attribute.CheckAttributeType): Use it.
7122 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
7123 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
7124 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
7125 argument to prevent error messages if the lookup fails.
7127 2005-01-27 Marek Safar <marek.safar@seznam.cz>
7129 * expression.cs (Indirection): Implemented IVariable interface
7130 to support indirection in AddressOf operator.
7131 (PointerArithmetic.Emit): Add optimalization for case where
7132 result can be precomputed.
7134 2005-01-26 Martin Baulig <martin@ximian.com>
7136 * class.cs (TypeContainer.AttributeTargets): Return the correct
7137 AttributeTargets depending on our `Kind' instead of throwing an
7138 exception; fixes #71632.
7140 2005-01-26 Marek Safar <marek.safar@seznam.cz>
7143 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
7146 2005-03-17 Martin Baulig <martin@ximian.com>
7148 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
7149 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
7151 2005-03-17 Martin Baulig <martin@ximian.com>
7153 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
7154 to bool so we can return an error condition.
7155 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
7158 2005-03-17 Martin Baulig <martin@ximian.com>
7160 * generic.cs (TypeMananager.IsIEnumerable): New public method.
7162 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
7163 converting from an array-type of T to `IEnumerable<T>'.
7165 2005-03-16 Martin Baulig <martin@ximian.com>
7167 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
7168 (Nullable.LiftedUnaryMutator): New public class.
7170 * expression.cs (UnaryMutator.DoResolve): Added support for
7173 2005-03-14 Martin Baulig <martin@ximian.com>
7175 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
7177 2005-03-14 Martin Baulig <martin@ximian.com>
7179 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
7180 the comparision operators `<', `>', `<=' and `>='.
7182 2005-03-13 Martin Baulig <martin@ximian.com>
7185 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
7186 avoid confusion with the `NullLiteral'.
7187 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
7189 2005-03-13 Martin Baulig <martin@ximian.com>
7191 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
7192 comparing arbitrary types with the null literal.
7194 2005-03-13 Martin Baulig <martin@ximian.com>
7196 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
7197 boolean operators '&&', '||', '&' and '|'.
7198 (Nullable.OperatorTrueOrFalse): New public class.
7200 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
7201 instead of a `StaticCallExpr'; added support for nullables.
7203 2005-03-10 Martin Baulig <martin@ximian.com>
7206 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
7207 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
7209 2005-03-07 Martin Baulig <martin@ximian.com>
7211 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
7212 it work if `expr' is not an IMemoryLocation.
7213 (Nullable.Lifted): Implement IMemoryLocation.
7214 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
7217 2005-03-05 Martin Baulig <martin@ximian.com>
7219 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
7220 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
7221 (Nullable): Added support for lifted unary and binary operators.
7223 * expression.cs (Unary.DoResolve): Added support for nullable types.
7224 (Binary.DoResolve): Likewise.
7225 (Conditional.DoResolve): Likewise.
7227 2005-03-02 Martin Baulig <martin@ximian.com>
7229 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
7231 * class.cs (ClassPart.SetParameterInfo): Override this.
7232 (PartialContainer.SetParameterInfo): Override this.
7233 (TypeContainer.CheckConstraints): New protected method.
7234 (PartialContainer.CheckConstraints): Override this and check
7235 whether the same contraints were specified in all parts of a
7236 partial generic type definition.
7237 (PartialContainer.UpdateConstraints): New public method.
7239 * generic.cs (TypeParameter.UpdateConstraints): New public method.
7241 2005-03-02 Martin Baulig <martin@ximian.com>
7243 Committing a patch from Carlos Alberto Cortez to fix #72887.
7245 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
7246 casts from `T []' to `int []'.
7248 2005-03-02 Martin Baulig <martin@ximian.com>
7250 * generic.cs (TypeManager.IsEqual): Make this symmetric.
7252 * expression.cs (Binary.ResolveOperator): When resolving a
7253 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
7254 `=='. Fixes #71866. See gen-127.cs.
7256 2005-03-02 Martin Baulig <martin@ximian.com>
7258 * class.cs (TypeContainer.DoDefineMembers): We also need a default
7259 static constructor in static classes.
7261 2005-03-02 Martin Baulig <martin@ximian.com>
7264 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
7265 (Nullable.LiftedConversion): Added support for user-defined
7268 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
7270 * cs-parser.jay: Use ComposedCast everywhere instead of
7271 NullableType, so we don't need to check for NullableType
7273 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
7274 case where we'll be resolved into a `parenthesized_expression_0'
7278 (Convert.UserDefinedConversion): Added nullable conversions.
7280 2005-02-28 Martin Baulig <martin@ximian.com>
7282 * generic.cs (TypeManager.IsNullableType): New static method.
7283 (Nullable): New abstract class.
7284 (Nullable.NullLiteral): New public class.
7285 (Nullable.LiftedConversion): New public class.
7287 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7288 `builtin_types opt_nullable'.
7291 (Convert.ImplicitConversionStandard): Added nullable conversions.
7292 (Convert.ExplicitConversionStandard): Likewise.
7293 (Convert.ExplicitConversion): Likewise.
7295 2005-02-26 Martin Baulig <martin@ximian.com>
7297 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7298 begin with a "?", for instance "?[]". Don't do a type lookup if
7301 2005-02-25 Martin Baulig <martin@ximian.com>
7303 The first part of Nullable Types :-)
7305 * generic.cs (NullableType): New public class.
7306 (NullCoalescingOperator): New public class.
7307 (TypeArguments.Resolve): Add a CS0306 check.
7309 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7310 (opt_nullable): New rule.
7311 (type): Added `opt_nullable' to `namespace_or_type_name',
7312 `builtin_types' and `pointer_type'.
7313 (array_type): Added `opt_nullable'.
7314 (opt_rank_specifier_or_nullable): New rule; this is the
7315 combination of `opt_rank_specifier' and `opt_nullable'.
7316 (opt_error): New rule; catch errors here.
7317 (nullable_type_or_conditional): New rule; we use this to check for
7318 nullable and still detect the conditional operator.
7319 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7320 instead `opt_rank_specifier'.
7322 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7325 2005-02-24 Martin Baulig <martin@ximian.com>
7327 * README, README.Changes: Removed; they're old and obsolete.
7329 2005-02-22 Martin Baulig <martin@ximian.com>
7331 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7332 returned an error, set `constraints' to null to avoid a crash
7334 (TypeParameter.ResolveType): Likewise.
7336 2005-02-22 Martin Baulig <martin@ximian.com>
7339 (Constraints.ResolveTypes): Protect against being called twice.
7340 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7341 (TypeParameter.ResolveType): New public method; calls
7342 constraints.ResolveTypes().
7343 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7344 into the new ResolveType().
7345 (GenericMethod.Define): Call ResolveType() on all our
7348 2005-02-21 Martin Baulig <martin@ximian.com>
7351 (TypeManager.generic_nullable_type): New static public field.
7352 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7355 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7357 2005-02-15 Martin Baulig <martin@ximian.com>
7359 * generic.cs (ConstructedType.Constraints): Correctly check
7360 constraints if the argument type is a type parameter; fixes
7363 2005-02-02 Martin Baulig <martin@ximian.com>
7365 * delegate.cs (Delegate.DefineType): Report an internal error if
7366 TypeManager.multicast_delegate_type is null. See bug #72015 for
7369 2005-01-29 Miguel de Icaza <miguel@novell.com>
7371 * pending.cs: Produce better code (no nops produced by using Ldarg
7374 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7375 i - 1' it should be arg + 1.
7379 2005-01-26 Martin Baulig <martin@ximian.com>
7381 * cs-parser.jay (indexer_declarator): Don't report an error if we
7382 have type parameters since we can be an explicit interface
7383 implementation; fixes #71449.
7385 2005-01-26 Martin Baulig <martin@ximian.com>
7387 * class.cs (TypeContainer.AttributeTargets): Return the correct
7388 AttributeTargets depending on our `Kind' instead of throwing an
7389 exception; fixes #71632.
7391 2005-01-26 Martin Baulig <martin@ximian.com>
7393 * delegate.cs (Delegate.DefineType): Correctly define our type
7394 parameters. Fixes #71483.
7396 2005-01-25 Raja R Harinath <rharinath@novell.com>
7399 * expression.cs (MemberAccess.DoResolve): Don't complain with
7400 cs0572 when the LHS of a member access has identical name and type
7403 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7406 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7408 Create custom PermissionSet only for PermissionSetAttribute.
7410 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7413 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7414 delegates in static class.
7416 2005-01-24 Martin Baulig <martin@ximian.com>
7418 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7419 merging an implicit block, just use its reachability.
7421 * statement.cs (Block.Resolve): Make the unreachable code check
7422 work wrt. implicit blocks; see test-337 from #63842.
7424 2005-01-21 Alp Toker <alp@atoker.com>
7426 * cs-parser.jay: destructor_declaration's container is PartialContainer
7427 not Class when partial types are used, so use Kind prop instead of
7430 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7432 * cs-parser.jay: Improve error reporting when an interface
7435 2005-01-20 Dick Porter <dick@ximian.com>
7437 * support.cs: SeekableStreamReader fix from Sandor Dobos
7438 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7439 chars are read. Fixes bug 70369.
7441 2005-01-20 Raja R Harinath <rharinath@novell.com>
7443 * cs-parser.jay (catch_clause): Simplify current_block handling
7446 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7448 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7449 code with ImplicitStandardConversion to handle the implicit
7450 conversion of method groups into valid delegate invocations.
7452 The problem is that in parameter handling we were using this code
7453 path. Fixes bug #64698
7455 2005-01-19 Raja R Harinath <rharinath@novell.com>
7457 * cs-parser.jay: Fix several infelicities.
7458 - Avoid assigning to the parser value stack. Code like
7459 '$3 = null' is unclean. Synthesize a value for the code block
7461 - Avoid using oob_stack for storing location information. Use ...
7462 (_mark_): ... this. New (empty) rule. Saves the current location
7464 (foreach_statement): Avoid using oob_stack for current_block
7465 handling. Use technique used in for_statement and
7466 using_statement. Synthesize a value for the code block to store
7467 additional intermediate information.
7469 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7471 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7472 of a different type is only allowed to private fields of a
7473 containing type, not on fields of a base class.
7475 See test-174.cs and error cs0122-9.cs
7477 2005-01-13 Raja R Harinath <rharinath@novell.com>
7479 Fix test-335.cs (bug #58126).
7480 * cs-parser.jay (argument): Split out non-expression parts of the
7481 rule into 'non_simple_argument'.
7482 (invocation_expression): Support parenthesized invocations with
7483 multiple arguments, and with single non-simple arguments.
7485 2005-01-13 Raja R Harinath <rharinath@novell.com>
7487 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7490 2005-01-12 Raja R Harinath <rharinath@novell.com>
7492 Fix cs0038-1.cs, cs1640-6.cs.
7493 * ecore.cs (Expression.Resolve): Remove special-case for
7494 SimpleName in error-handling.
7495 (Expression.almostMatchedMembers): Relax access permission to
7497 (Expression.MemberLookupFailed): Handle duplicates in
7498 almostMatchedMembers list.
7499 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7500 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7501 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7502 overload if the passed in MemberInfo is a MethodBase.
7504 2005-01-25 Martin Baulig <martin@ximian.com>
7507 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7509 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7512 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7513 for non-CAS & merge permission sets properly.
7515 2005-01-11 Raja R Harinath <rharinath@novell.com>
7517 Improve standard-compliance of simple name and member access
7518 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7519 * ecore.cs (FullNamedExpression): New abstract base class
7520 for Namespaces and TypeExpressions.
7521 (ResolveFlags.SimpleName): Remove.
7522 (SimpleName): Remove support for dotted names.
7523 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7524 DeclSpace.FindType and DeclSpace.LookupType.
7525 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7526 (Expression.ExprClassName): Make member function.
7527 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7528 a namespace. Remove creation of dotted "SimpleName"s.
7529 (MemberAccess.DoResolve): Likewise.
7530 * decl.cs (DeclSpace.Cache): Make private.
7531 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7532 (DeclSpace.FindType): Update.
7533 (DeclSpace.LookupType): Move here from RootContext. Return a
7534 FullNamedExpression.
7535 * namespace.cs (Namespace): Derive from FullNamedExpression
7536 so that it can be part of expression resolution.
7537 (Namespace.Lookup): Return an FullNamedExpression.
7538 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7540 * rootcontext.cs (NamespaceLookup): Remove.
7541 (LookupType): Move to DeclSpace.
7542 * attribute.cs (CheckAttributeType): Update.
7543 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7544 (FindDocumentedTypeNonArray): Likewise.
7546 2005-01-11 Raja R Harinath <rharinath@novell.com>
7548 Fix cs0509.cs, cs1632.cs.
7549 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7550 is the same as IsInterface.
7551 (TypeContainer.GetClassBases): Likewise.
7552 * statement.cs (LabeledStatement.ig): New field.
7553 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7555 (LabeledStatement.DoEmit): Check that the label was created with
7556 the same ILGenerator.
7558 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7561 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7562 accessors to its properties.
7564 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7565 from accessors to property.
7567 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7570 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7573 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7575 * attribute.cs: Check for null and empty strings.
7577 I have lost another battle to Paolo.
7579 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7582 * class.cs (PropertyMethod): Set Parent field in ctors.
7583 (SetMethod.InternalParameters): Add unsafe switch hack.
7584 Override MarkForDuplicationCheck where it is appropriate.
7586 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7587 It says whether container allows members with the same name.
7589 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7590 Removed is_method parameter.
7592 2005-01-06 Duncan Mak <duncan@ximian.com>
7594 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7595 because the previous change led to incorrect reporting of CS1032
7596 ("Cannot define/undefine preprocessor symbols after first token in
7597 file"). Instead of using `tokens_seen' as the only flag that
7598 triggers CS1040, introduce `comments_seen'. This new flag is used
7599 to signify having seen comments on the current line, so it is
7600 unset after a newline.
7602 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7604 * doc.cs : When searching for a type, find nested type too.
7605 This fixes bug #71040.
7607 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7610 - Warn missing member comment on those classes which also does not
7611 have doc comments. Fixed bug #71041.
7612 - Don't warn missing doc comment on default constructor.
7615 2005-01-06 Duncan Mak <duncan@ximian.com>
7617 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7618 comments, set `tokens_seen' to true. This allows us to detect
7619 misplaced preprocessor directives (i.e. not at the beginning of
7620 the a line, nor after whitespaces). In that case, report error
7621 CS1040. This fixes bug #56460.
7623 * cs-parser.jay (interface_member_declaration): Add checks for
7624 IsExplicitImpl, and report CS0541 error if an interface member is
7625 defined as an explicit interface declaration.
7627 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7630 * class.cs (PropertyMethod): Set Parent field in ctors.
7631 (SetMethod.InternalParameters): Add unsafe switch hack.
7633 * decl.cs (MemberCore.Parent): Cannot be readonly.
7635 2005-01-06 Raja R Harinath <rharinath@novell.com>
7637 * decl.cs (DeclSpace.ResolveType): Remove.
7638 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7639 Merge in code from ...
7640 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7641 * class.cs, enum.cs: Update to changes.
7643 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7645 * anonymous.cs: Ensure that we init the scope of our parent if it
7646 has not been initialized yet.
7648 2004-12-30 Duncan Mak <duncan@ximian.com>
7650 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7651 if field.FieldBuilder is null. Fixes #70758.
7653 * convert.cs: Fixed some typos and updated some of the comments.
7654 (ImplicitStandardConversionExists):
7655 (TryImplicitIntConversion): If `target_type' is an interface and
7656 the type of `ic' implements this interface, return true or a new
7657 BoxedCast instead of null. This fixes #70468.
7659 2004-12-29 Duncan Mak <duncan@ximian.com>
7661 * expression.cs (Argument.Emit): Check that Expr is
7662 IMemoryLocation before casting to it, and report CS1510 otherwise.
7666 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7668 * statement.cs (Block.ThisVariable): remove the recursion here, to
7669 make the --profile more sane.
7671 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7673 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7674 assembly, by JB Evain.
7676 2004-12-17 Raja R Harinath <rharinath@novell.com>
7678 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7679 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7680 "parent" refers to enclosing type/class. "base" refers to superclass.
7682 2004-12-17 Raja R Harinath <rharinath@novell.com>
7684 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7685 Ensure that we only have GlobalAttributes.
7686 * attribute.cs (Attribute.Emit): Make non-virtual.
7687 (GlobalAttribute.Emit): Remove.
7688 (Attribute.Resolve): Make virtual.
7689 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7690 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7691 the argument. Don't create one.
7692 (Attribute.GetObsoleteAttribute): Likewise.
7693 (Attribute.GetClsCompliantAttributeValue): Likewise.
7694 * class.cs, decl.cs: Update to changes.
7696 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7698 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7700 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7702 * statement.cs (Foreach.Resolve): Add error 186 report.
7704 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7706 * expression.cs (Conditional.DoResolve): Add warning 429.
7708 * statement.cs (If.Resolve): Add warning 665.
7710 2004-12-16 Raja R Harinath <rharinath@novell.com>
7712 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7713 except when in the parser, and in GlobalAttribute.
7714 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7715 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7716 RootContext.Tree.Types.NamespaceEntry once work is done.
7717 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7718 and resets RootContext.Tree.Types.NamespaceEntry.
7720 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7722 * cs-parser.jay: Don't create a block for every variable.
7724 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7726 * location.cs: Provide extra information.
7728 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7729 variables from the captured environment, it is the ldarg_0.
7731 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7733 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7736 * class.cs: Changed warning level for 169 to avoid developer
7737 displeasure from warning flooding. It will be changed back when they
7738 fix most of current BCL warnings.
7740 * RootContext.cs: Pushed default WarningLevel to 3.
7742 * statement.cs: Removed unused variable.
7744 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7746 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7747 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7748 Add error 502 report.
7749 (StaticClass.DefineType): Add error 441 report.
7750 (Class.AllowedModifiersProp): New virtual property as temporary
7751 extension to AllowedModifiers.
7752 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7753 to share implementation with StaticClass and don't call virtual
7756 * driver.cs (MainDriver): Add error 1558 test.
7758 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7759 report. Moved error 36 test here.
7761 * statement.cs (Throw.Resolve): Add error 724 report.
7763 * typemanager.cs: Add out_attribute_type core type.
7765 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7767 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7769 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7771 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7774 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7776 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7777 Add error 3023 report.
7778 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7780 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7783 2004-12-12 John Luke <john.luke@gmail.com>
7785 * driver.cs (AddArgs): take -- into account when
7786 adding arguments, fixes bug 65710
7788 2004-12-12 Martin Baulig <martin@ximian.com>
7790 * expression.cs (Unary.TryReduceNegative): Added support for
7791 SByteConstant and ByteConstant.
7792 (Unary.Reduce): Check error values from TryReduceNegative().
7794 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7796 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7797 and report exception as error 182.
7799 2004-12-10 Raja R Harinath <rharinath@novell.com>
7801 * driver.cs (Main): Fix message when there are warnings.
7803 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7805 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7807 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7809 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7810 Reduced number of warnings.
7812 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7814 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7816 * driver.cs: Removed message.
7818 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7820 2004-12-08 <vargaz@freemail.hu>
7822 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7824 2004-12-08 Martin Baulig <martin@ximian.com>
7826 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7827 instead of a CS3002 for properties and indexer.
7829 2004-12-08 Martin Baulig <martin@ximian.com>
7831 * decl.cs (MemberName.ToString): Make this work again.
7833 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7835 * attribute.cs (Resolve): Add error 591 detection.
7837 * class.cs (FieldMember.Define): Add error 1547 detection.
7838 (Indexer.Define): Add error 620 detection.
7839 (Operator.Define): Add error 590 detection.
7841 * ecore.cs: Missing argument for error 79.
7843 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7846 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7849 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7852 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7854 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7855 Some operator comments were suppressed.
7856 * doc.cs : Implicit/explicit operator name in doc comments are like
7857 "op_Explicit(type)~returnType", so added suffix handling.
7859 2005-01-21 Alp Toker <alp@atoker.com>
7861 * cs-parser.jay: destructor_declaration's container is PartialContainer
7862 not Class when partial types are used, so use Kind prop instead of 'is'.
7864 2004-12-12 Martin Baulig <martin@ximian.com>
7866 * expression.cs (Unary.TryReduceNegative): Added support for
7867 SByteConstant and ByteConstant.
7868 (Unary.Reduce): Check error values from TryReduceNegative().
7870 2004-12-11 Martin Baulig <martin@ximian.com>
7872 * support.cs (ReflectionParameters.ParameterName): If we have a
7873 `gpd', call `ParameterName' on it.
7875 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7877 * pending.cs (PendingImplementation.DefineProxy): Call
7878 DefineParameter() for all of the MethodBuilder's arguments.
7880 2004-12-09 Martin Baulig <martin@ximian.com>
7882 * doc.cs (DocUtil): Make this a static class.
7884 2004-12-09 Martin Baulig <martin@ximian.com>
7886 * expression.cs (Invocation.InferType): Moved the type inference
7887 implementation into TypeManager.
7889 * generics.cs (TypeManager): Moved the type inference
7890 implementation here.
7892 2004-12-09 Martin Baulig <martin@ximian.com>
7894 * typemanager.cs (TypeManager): Make this a partial class.
7897 (TypeManager): Move the generics part of `TypeManager' here.
7899 2004-12-08 Martin Baulig <martin@ximian.com>
7901 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7902 instead of a CS3002 for properties and indexer. Added CS3024
7903 check for generic interfaces.
7905 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
7906 instances are not CLS-compliant.
7908 2004-12-08 Martin Baulig <martin@ximian.com>
7911 (void_pointer_expression): New rule for `void*', `void**' etc.
7912 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
7914 2004-12-08 Martin Baulig <martin@ximian.com>
7916 * expression.cs (Invocation.InferType): Removed the hack for
7917 MethodCore.MayUnify().
7919 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
7922 * class.cs (MethodCore.MayUnify): Use
7923 TypeManager.MayBecomeEqualGenericTypes().
7925 2004-12-08 Martin Baulig <martin@ximian.com>
7927 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
7928 parameter, box it. Fixes #69233.
7930 2004-12-08 Martin Baulig <martin@ximian.com>
7932 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
7933 have the ctor constraint. Fixes #68326.
7935 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7937 * cs-parser.jay : interface comment was not consumed because of
7938 extra opt_semicolon before doc handling.
7940 2004-12-03 Raja R Harinath <rharinath@novell.com>
7942 Fix test-327.cs, test-328.cs, and put in early infrastructure
7943 for eventually fixing #52697.
7944 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
7945 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
7947 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
7948 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
7949 (VerifyUsing, error246): Update.
7950 * rootcontext.cs (RootContext.NamespaceLookup): Just use
7951 'NamespaceEntry.LookupNamespaceOrType'.
7953 2004-12-07 Martin Baulig <martin@ximian.com>
7955 * driver.cs: Call it "BETA SOFTWARE" :-)
7957 2004-12-06 Raja R Harinath <rharinath@novell.com>
7959 Fix crash on cs0657-17.cs.
7960 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7961 Use RootContext.Tree.Types, not 'new RootTypes ()'.
7962 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
7963 the case where the NamespaceEntry gets overwritten.
7965 2004-12-06 Marek Safar <marek.safar@seznam.cz>
7967 Fixed #69195, #56821
7968 * ecore.cs (ResolveBoolean): Tiny refactoring.
7970 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
7971 of right expression resolving when left is false constant and
7972 operator is LogicalAnd OR true constant and operator is LogicalOr.
7974 * statement.cs (ResolveUnreachable): Always reports warning.
7976 2004-12-05 Miguel de Icaza <miguel@ximian.com>
7978 * class.cs: Distinguish between 1721 and 1722 (just a little help
7979 for the programmer).
7981 2004-12-03 Miguel de Icaza <miguel@ximian.com>
7983 * delegate.cs: Only allow this on new versions of the language.
7985 2004-12-02 Duncan Mak <duncan@ximian.com>
7987 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
7989 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
7990 here as a static method. Take an additional bool out parameter
7991 `must_do_cs1540_check' for signaling to InstanceResolve.
7992 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
7993 member field from PropertyExpr class and made it an argument of
7995 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
7996 check for MarshalByRefObject, and report CS0122 instead of CS1540.
7997 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
7998 and `remove_accessor' as well as InstanceResolve: report CS0122
8003 2004-12-07 Martin Baulig <martin@ximian.com>
8005 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
8006 and CS0692 where appropriate.
8008 2004-12-06 Martin Baulig <martin@ximian.com>
8010 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
8011 IsDuplicateImplementation() and improved it.
8013 * expression.cs (Invocation.InferTypeArguments): Added
8014 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
8015 and removed the "ref" modifier from `infered_types'.
8017 * decl.cs (MemberName.ToString): Removed the exception.
8019 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
8021 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
8022 comments are allowed.
8024 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8026 * delegate.cs: Add checks for subtypes in paramaters and return values
8027 in VerifyMethod () to add support for Covariance/Contravariance
8030 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8032 * report.cs: Remove extra closing parenthesis.
8034 * convert.cs (Error_CannotImplicitConversion): If the name of the
8035 types are the same, provide some extra information.
8037 2004-12-02 Marek Safar <marek.safar@seznam.cz>
8040 * attribute.cs (Resolve): Improved implementation of params
8041 attribute arguments.
8043 * support.cs (ParameterData): Add HasParams to be faster.
8045 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
8047 all things are for /doc support:
8049 * doc.cs: new file that supports XML documentation generation.
8050 * mcs.exe.sources: added doc.cs.
8052 Handle /doc command line option.
8053 Report error 2006 instead of 5 for missing file name for /doc.
8054 Generate XML documentation when required, after type resolution.
8056 Added support for picking up documentation (/// and /** ... */),
8057 including a new XmlCommentState enumeration.
8059 Added lines to fill Documentation element for field, constant,
8060 property, indexer, method, constructor, destructor, operator, event
8061 and class, struct, interface, delegate, enum.
8062 Added lines to warn incorrect comment.
8064 Added Documentation field (passed only when /doc was specified).
8066 Added DocComment, DocCommentHeader, GenerateDocComment() and
8067 OnGenerateDocComment() and some supporting private members for
8068 /doc feature to MemberCore.
8070 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
8072 Added overriden DocCommentHeader.
8074 Added overriden DocCommentHeader and GenerateDocComment().
8076 2004-12-01 Miguel de Icaza <miguel@ximian.com>
8078 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
8079 unwrapping the enumeration values, chain to
8080 DoConstantNumericPromotions again, so we can promote things to the
8081 fundamental types (takes care of enums that are bytes, sbytes).
8085 2004-12-01 Raja R Harinath <rharinath@novell.com>
8087 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
8088 Fix long-standing bug in type-lookup. Use FindType instead of
8089 LookupType when ec.ResolvingTypeTree.
8090 (Attribute.ResolveType, Attribute.Resolve)
8091 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
8093 (Attributes.Search): Remove internal version. Update.
8094 (Attributes.SearchMulti): Update.
8095 (Attributes.GetClsCompliantAttribute): Remove.
8096 (Attributes.GetIndexerNameAttribute): Remove.
8097 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
8098 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
8099 * class.cs (Indexer.Define): Likewise.
8101 2004-12-01 Marek Safar <marek.safar@seznam.cz>
8104 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
8105 MarshallByReference members access.
8107 * expression.cs: Use CheckMarshallByRefAccess;
8108 Better error CS0197 message.
8110 * report.cs: Print whole related error message.
8112 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8114 * class (GetClassBases): Better error 60 report.
8115 (EventProperty): Disabled warning 67 detection.
8117 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8120 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
8122 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
8125 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8128 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
8130 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
8132 2004-11-26 Miguel de Icaza <miguel@ximian.com>
8134 * attribute.cs (Attribute.Resolve): Refine error reporting and
8135 report a cs0117 if the identifier does not exist, to distinguish
8136 from 0617 which is a miss-use of the actual identifier.
8138 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
8139 between cs0070 and cs0079.
8141 * class.cs (MemberBase.DoDefine): When reporting a wrong
8142 accessibility level, we use MethodCore to compare instead of
8143 Method (this was a regression in some refactoring effort).
8145 So now we correctly report cs0056 again.
8147 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
8148 testing the target_type (which was known to be object_type) and
8149 not the source type (which is anonymous_method).
8151 Fixed reporting of error cs1660.
8153 * expression.cs (UserCast.Source): Expose the underlying cast.
8155 * statement.cs (Switch.SwitchGoverningType): Sort the list of
8156 allowed types to find a match to int32 first (most common).
8158 In addition, it ignores any ImplicitUserConversions that did an
8159 internal implicit conversion (as the switch statement allows only
8160 one integral conversion to exist).
8162 * class.cs (PartialContainer.Create): rename `name' to
8163 `member_name' for clarity. Then replace the string calls with a
8164 call to MemberName.GetPartialName, as now using
8165 MemberName.ToString is an error (this is due to the side effects
8166 it had, that were fixed in the past).
8168 This will restore the error reporting on a number of partial class
8169 errors that were missusing this (and getting an exception as a
8170 results, which is now just a plain textual warning, because
8171 yyparse debug output would crash otherwise).
8173 2004-11-26 Raja R Harinath <rharinath@novell.com>
8175 * Makefile (PROGRAM_INSTALL_DIR): Remove.
8177 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8179 * rootcontext.cs (LookupType): Make sure to cache lookups that
8180 don't give us a negative result. This saves about 5% of corlib
8183 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8185 * report.cs (AbstractMessage.Print): messages are sent to stderr
8187 * class.cs (TypeContainer.GetClassBases): It is an error to have a
8188 non-interface in the list of interfaces (at this point, either
8189 parent was properly set, or a base class is being listed in the
8190 interfaces section).
8192 This flags error 1722, and resolves the crash from bug 69259.
8194 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8196 * statement.cs (Using.EmitExpressionFinally): make this work right
8197 for valuetypes. Fixes 69926.
8199 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8201 * const.cs (Const.ChangeType): Cope with the "0 literal can be
8202 converted to an enum" here, before we try to change the underlying
8203 type. This code exists, but it is a different code path than the
8204 one used while encoding constants.
8206 (ImplicitReferenceConversionExists): In addition, resynchronized
8207 the code here, so it matches the same code in
8208 ImplicitReferenceConversionExists for the `from any class-type S
8209 to any interface-type T'.
8211 2004-11-25 Marek Safar <marek.safar@seznam.cz>
8213 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
8215 2004-11-24 Miguel de Icaza <miguel@ximian.com>
8217 * cs-parser.jay: Use verbosity accordingly.
8219 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8221 * expression.cs (Unary.ResolveOperator): Do not report warning;
8222 AddressOf reads from variable.
8224 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
8226 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8230 * attribute.cs (Attributable): Removed CheckTargets.
8231 (Attributes.Emit): Explicit attribute targets are tested here.
8233 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
8234 not enabled for interfaces.
8236 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
8237 (GetAssemblyName): Ouch next bug there.
8239 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8241 * expression.cs: Error 275 added.
8243 2004-11-23 Marek Safar <marek.safar@seznam.cz>
8245 Fix bug #69177 (Implemented decimal constant support)
8247 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
8248 (BinaryFold): Add DecimalConstant.
8250 * const.cs (Define): Decimal constant
8252 (ChangeType): Add decimal type handling.
8253 (LookupConstantValue): Don't set value for decimal type but
8254 emit DecimalConstantAttribute. Needed for constant optimization.
8256 * constant.cs (ToDecimal): New method.
8257 (ConvertToDecimal): New method.
8258 (IntConstant): Implemented ConvertToDecimal.
8259 (DecimalConstant.Emit): Emit optimized version for decimals in
8262 * expression.cs (ResolveOperator): Changed order of constant
8263 reduction to work correctly with native types which have
8264 overloaded operators.
8265 (ResolveMemberAccess): Extract constant value from attribute
8268 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
8270 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
8271 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
8272 (ChangeType): Decimal is special.
8273 (TypeToCoreType): Add decimal type.
8275 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8277 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8280 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8282 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8285 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8287 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8289 * pending.cs (PendingImplementation): Grab only interfaces.
8291 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8293 * statement.cs (ForeachHelperMethods): Add location member and
8294 error 202 detection.
8296 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8298 * expression.cs (DoResolveBase): Fixed wrong warning for out
8301 2004-12-04 Martin Baulig <martin@ximian.com>
8303 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8304 to check whether the conversion is ok.
8306 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8307 `Type.EmptyTypes' if we're not a generic TypeContainer.
8309 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8311 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8312 old bug: when converting from the null literal to a pointer,
8313 return an EmptyCast, not the NullLiteral.
8315 This fixes #69921, the recent null_type changes probably made this
8318 2004-12-03 Martin Baulig <martin@ximian.com>
8320 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8321 method as our child, call AnonymousMethod.Compatible() on it.
8323 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8325 * class.cs (FieldBase): Use an unused bit field from the field to
8326 encode the `has_offset' property from the FieldMember. This saves
8327 a couple of Ks on bootstrap compilation.
8329 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8330 method as our child, return the AnonymousMethod resolved
8333 * expression.cs (New.DoResolve): Allow return values from
8334 NewDelegate to also include AnonymousMethods.
8338 2004-11-29 Raja R Harinath <rharinath@novell.com>
8340 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8342 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8343 System.Runtime.InteropServices._Exception, since it's a base
8344 interface of the core type System.Exception in the net_2_0 profile.
8346 2004-11-27 Martin Baulig <martin@ximian.com>
8348 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8350 2004-11-26 Raja R Harinath <rharinath@novell.com>
8352 * Makefile: Convert to use executable.make.
8353 * gmcs.exe.sources: New.
8355 2004-11-25 Martin Baulig <martin@ximian.com>
8357 * expression.cs (Invocation.InferType): Added support for byref types.
8359 2004-11-25 Martin Baulig <martin@ximian.com>
8361 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8362 in TypeManager.TypeToCoreType().
8364 2004-11-25 Martin Baulig <martin@ximian.com>
8366 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8367 "Dispose" method from the `current_type'.
8368 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8369 DoDefineMembers() instead of using the MethodBuilder; this is
8370 required for generic iterators.
8372 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8374 2004-11-24 Martin Baulig <martin@ximian.com>
8376 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8378 2004-11-20 Martin Baulig <martin@ximian.com>
8380 * expression.cs (Invocation.InferType): Correctly infer generic
8381 instances; see gen-103.cs.
8382 (Invocation.InferTypeArguments): If a generic method doesn't have
8383 any unbound type parameters, we don't need to infer anything.
8385 2004-11-19 Raja R Harinath <rharinath@novell.com>
8387 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8389 2004-11-17 Raja R Harinath <rharinath@novell.com>
8391 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8392 (TypeHandle.GetMemberCache): New.
8393 (TypeHandle.TypeHandle): Update.
8394 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8395 (TypeManager.LookupParentInterfacesCache):
8396 Rename from LookupInterfaceCache. Optimize slightly.
8397 (TypeManager.MemberLookup_FindMembers): Update.
8398 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8400 (AddCacheContents): Rename from AddHashtable.
8401 * class.cs (TypeContainer.parent_container): Remove.
8402 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8403 (TypeContainer.DoDefineMembers): Don't initialize it.
8404 Update to name changes.
8406 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8408 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8409 that factors the code to check access modifiers on override.
8411 (PropertyBase): Use the code here.
8413 Patch from Lluis S'anchez, fixes bug #69361.
8415 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8417 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8418 routine that is used to report the use of a captured variable
8419 whose address has been taken.
8421 There are two checks: one when variables are being captured and
8422 the other check is when the address of a variable is taken.
8424 (because an anonymous methods might be resolved before *or* after
8425 the address has been taken) and
8427 * expression.cs (Conditional.DoResolve): Remove the special
8428 casing that Martin added to trueExpr and falseExpr being both
8429 NullLiteral. We get the right behavior now just by introducing
8430 the null_type into the compiler.
8432 * convert.cs (ExplicitConversion): Change the code to use
8433 null_type instead of testing `expr is NullLiteral'.
8434 (ImplicitConversionStandard): use null_type too.
8435 (ImplicitReferenceConversionExists): use null_type too.
8436 (ImplicitReferenceConversion): use null_type too.
8438 * literal.cs: The type of `NullLiteral' is now null_type instead
8440 (Resolve): Set the type here.
8442 * typemanager.cs: Introduce null_type.
8444 2004-11-18 Martin Baulig <martin@ximian.com>
8447 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8449 2004-11-18 Martin Baulig <martin@ximian.com>
8451 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8453 2004-11-18 Martin Baulig <martin@ximian.com>
8455 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8456 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8457 call ResolveConstructedType() on it to resolve it without checking
8459 (Constraints.ResolveTypes): Check them here.
8460 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8461 but don't check constraints.
8462 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8463 check constraints here.
8464 (ConstructedType.ResolveConstructedType): New public method. This
8465 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8466 resolve ourselves without checking constraints.
8468 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8470 2004-11-18 Martin Baulig <martin@ximian.com>
8473 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8475 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8477 2004-11-18 Martin Baulig <martin@ximian.com>
8479 * ecore.cs (TypeExpr.ResolveType): Removed.
8480 (Expression.ResolveAsTypeTerminal): We always return a fully
8481 resolved `TypeExpr', so we can just access its `Type'.
8483 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8485 2004-11-17 Martin Baulig <martin@ximian.com>
8487 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8488 sure we don't return any unresolved TypeExpr's.
8489 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8491 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8493 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8494 unresolved `ConstructedType's.
8496 2004-11-17 Martin Baulig <martin@ximian.com>
8498 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8500 2004-11-17 Martin Baulig <martin@ximian.com>
8503 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8505 * decl.cs (DeclSpace.ResolveType): Removed.
8506 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8508 2004-11-17 Martin Baulig <martin@ximian.com>
8510 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8511 direction, like FindMembers() does. Fixes #69546, testcase is in
8514 2004-11-16 Martin Baulig <martin@ximian.com>
8516 This is based on a patch from Marek Safar, see bug #69082.
8517 Fixes bugs #63705 and #67130.
8519 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8520 method; create a MemberCache for an interface type and cache the
8523 * decl.cs (IMemberContainer.ParentContainer): Removed.
8524 (IMemberContainer.ParentCache): New property.
8525 (MemberCache.SetupCacheForInterface): Removed.
8526 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8527 to create a cache for an interface's "parent".
8529 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8532 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8534 * statement.cs: Avoid adding bools to a hashtable.
8536 2004-11-15 Martin Baulig <martin@ximian.com>
8538 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8540 2004-11-11 Martin Baulig <martin@ximian.com>
8542 * typemanager.cs (TypeManager.GetMethodName): New method.
8544 * class.cs (MethodData.Define): Include the generic arity in the
8545 name of an explicit interface; also add it to the method name.
8547 * pending.cs (PendingImplementation.InterfaceMethod): The method
8548 name now includes the generic arity.
8550 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8552 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8553 calling an unsafe method from a safe location.
8555 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8558 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8560 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8562 * namespace.cs (VerifyUsing): use GetPartialName instead of
8565 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8567 * statement.cs (Return.Resolve): Fix regression in typo: if
8568 `in_exc', we have to request a NeedReturnLabel, this was a typo
8569 introduced in the anonymous method check-in. Fixes #69131.
8571 * Indexers were using the ShortName when defining themselves,
8572 causing a regression in the compiler bootstrap when applying the
8573 patch from 2004-11-02 (first part), now they use their full name
8574 and the bug is gone.
8576 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8578 * driver.cs: Strip the path from the names of embedded resources. Fixes
8581 2004-11-04 Raja R Harinath <rharinath@novell.com>
8583 Fix error message regression: cs0104-2.cs.
8584 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8585 (AliasEntry.Resolve): Update.
8586 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8588 (RootContext.LookupType): Update.
8590 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8592 * cs-parser.jay: Add support for handling accessor modifiers
8593 * class: Add support port accessor modifiers and error checking,
8594 define PropertyMethod.Define as virtual (not abstract anymore)
8595 * ecore.cs: Add checking for proeprties access with access modifiers
8596 * iterators.cs: Modify Accessor constructor call based in the modified
8598 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8600 * expression.cs (StringConcat): Handle being called twice,
8601 as when we have a concat in a field init with more than two
8604 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8606 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8607 special case explicit implementations, we should always produce
8608 the .property or .event declaration.
8610 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8611 since it will not return correct data if people use this
8612 unresolved in the presence of using statements (see test-313).
8614 * class.cs (MethodData.Define): If we are an explicit interface
8615 implementation, set the method name to the full name of the
8616 interface plus the name of the method.
8618 Notice that using the method.MethodName.GetFullName() does not
8619 work, as it will only contain the name as declared on the source
8620 file (it can be a shorthand in the presence of using statements)
8621 and not the fully qualifed type name, for example:
8625 class D : ICloneable {
8626 object ICloneable.Clone () {
8630 Would produce a method called `ICloneable.Clone' instead of
8631 `System.ICloneable.Clone'.
8633 * namespace.cs (Alias.Resolve): Use GetPartialName.
8635 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8637 * cs-parser.jay: Add error 1055 report.
8639 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8641 * assign.cs (Assign.DoResolve): Only do the transform of
8642 assignment into a New if the types are compatible, if not, fall
8643 through and let the implicit code deal with the errors and with
8644 the necessary conversions.
8646 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8648 * cs-parser.jay: Add error 1031 report.
8650 * cs-tokenizer.cs: Add location for error 1038.
8652 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8654 * cs-parser.jay: Add error 1016 report.
8656 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8658 * cs-parser.jay: Add errors 1575,1611 report.
8660 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8662 * cs-parser.jay: Add error 1001 report.
8664 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8667 * attribute.cs (GetMarshal): Add method argument for
8668 caller identification.
8670 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8671 agument for GetMarshal and RuntimeMissingSupport.
8673 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8675 * attribute.cs (ExtractSecurityPermissionSet): Removed
8676 TypeManager.code_access_permission_type.
8678 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8680 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8682 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8683 for obsolete use of a variable here. Fixes regression on errors
8684 cs0619-25 and cs0619-26.
8686 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8688 Fix #62358, implemented security attribute encoding.
8690 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8691 Tests permitted SecurityAction for assembly or other types.
8692 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8693 data from SecurityPermissionAttribute to PermisionSet class.
8695 * class.cs (ApplyAttributeBuilder): Added special handling
8696 for System.Security.Permissions.SecurityAttribute based types.
8698 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8699 special handling for System.Security.Permissions.SecurityAttribute
8702 * enum.cs (ApplyAttributeBuilder): Added special handling
8703 for System.Security.Permissions.SecurityAttribute based types.
8705 * parameter.cs (ApplyAttributeBuilder): Added special handling
8706 for System.Security.Permissions.SecurityAttribute based types.
8708 * rootcontext.cs: Next 2 core types.
8710 * typemanager.cs (TypeManager.security_permission_attr_type):
8711 Built in type for the SecurityPermission Attribute.
8712 (code_access_permission_type): Build in type.
8714 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8716 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8717 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8718 all of this information into
8719 EmitContext.EmitCapturedVariableInstance.
8721 * codegen.cs (EmitCapturedVariableInstance): move here the
8722 funcionality of emitting an ldarg.0 in the presence of a
8723 remapping. This centralizes the instance emit code.
8725 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8726 then emit a load of this: it means that we have reached the
8727 topmost ScopeInfo: the one that contains the pointer to the
8728 instance of the class hosting the anonymous method.
8730 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8731 captures to the topmost CaptureContext.
8733 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8735 * expression.cs (LocalVariableReference): Move the knowledge about
8736 the iterators into codegen's EmitCapturedVariableInstance.
8738 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8740 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8741 all code paths return a value from an anonymous method (it is the
8742 same as the 161 error, but for anonymous methods).
8744 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8746 The introduction of anonymous methods in the compiler changed
8747 various ways of doing things in the compiler. The most
8748 significant one is the hard split between the resolution phase
8749 and the emission phases of the compiler.
8751 For instance, routines that referenced local variables no
8752 longer can safely create temporary variables during the
8753 resolution phase: they must do so from the emission phase,
8754 since the variable might have been "captured", hence access to
8755 it can not be done with the local-variable operations from the runtime.
8759 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8760 is a toplevel block.
8762 (ToplevelBlock): A new kind of Block, these are the blocks that
8763 are created by the parser for all toplevel method bodies. These
8764 include methods, accessors and anonymous methods.
8766 These contain some extra information not found in regular blocks:
8767 A pointer to an optional CaptureContext (for tracking captured
8768 local variables and parameters). A pointer to the parent
8771 (Return.Resolve): Catch missmatches when returning a value from an
8772 anonymous method (error 1662).
8773 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8776 (Break.Resolve): ditto.
8778 (SwitchLabel): instead of defining the labels during the
8779 resolution phase, we now turned the public ILLabel and ILLabelCode
8780 labels into methods called GetILLabelCode() and GetILLabel() that
8781 only define the label during the Emit phase.
8783 (GotoCase): Track the SwitchLabel instead of the computed label
8784 (its contained therein). Emit the code by using
8785 SwitchLabel.GetILLabelCode ().
8787 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8788 whether the Local has been captured or not.
8790 (LocalInfo.IsCaptured): New property, used to tell whether the
8791 local has been captured.
8793 * anonymous.cs: Vastly updated to contain the anonymous method
8796 The main classes here are: CaptureContext which tracks any
8797 captured information for a toplevel block and ScopeInfo used to
8798 track the activation frames for various local variables.
8800 Each toplevel block has an optional capture context associated
8801 with it. When a method contains an anonymous method both the
8802 toplevel method and the anonymous method will create a capture
8803 context. When variables or parameters are captured, they are
8804 recorded on the CaptureContext that owns them, for example:
8808 MyDelegate d = delegate {
8813 Here `a' will be recorded as captured on the toplevel
8814 CapturedContext, the inner captured context will not have anything
8815 (it will only have data if local variables or parameters from it
8816 are captured in a nested anonymous method.
8818 The ScopeInfo is used to track the activation frames for local
8819 variables, for example:
8821 for (int i = 0; i < 10; i++)
8822 for (int j = 0; j < 10; j++){
8823 MyDelegate d = delegate {
8828 At runtime this captures a single captured variable `i', but it
8829 captures 10 different versions of the variable `j'. The variable
8830 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8831 recorded on a child.
8833 The toplevel ScopeInfo will also track information like the `this'
8834 pointer if instance variables were referenced (this is necessary
8835 as the anonymous method lives inside a nested class in the host
8836 type of the method).
8838 (AnonymousMethod): Expanded to track the Toplevel, implement
8839 `AnonymousMethod.Compatible' to tell whether an anonymous method
8840 can be converted to a target delegate type.
8842 The routine now also produces the anonymous method content
8844 (AnonymousDelegate): A helper class that derives from
8845 DelegateCreation, this is used to generate the code necessary to
8846 produce the delegate for the anonymous method that was created.
8848 * assign.cs: API adjustments for new changes in
8849 Convert.ImplicitStandardConversionExists.
8851 * class.cs: Adjustments to cope with the fact that now toplevel
8852 blocks are of type `ToplevelBlock'.
8854 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8855 insteda of standard blocks.
8857 Flag errors if params arguments are passed to anonymous methods.
8859 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8860 `CurrentAnonymousMethod' which points to the current Anonymous
8861 Method. The variable points to the AnonymousMethod class that
8862 holds the code being compiled. It is set in the new EmitContext
8863 created for the anonymous method.
8865 (EmitContext.Phase): Introduce a variable and an enumeration to
8866 assist in enforcing some rules about when and where we are allowed
8867 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8868 only one that enfonces this right now).
8870 (EmitContext.HaveCaptureInfo): new helper method that returns
8871 whether we have a CapturedContext initialized.
8873 (EmitContext.CaptureVariable): New method used to register that a
8874 LocalInfo must be flagged for capturing.
8876 (EmitContext.CapturedParameter): New method used to register that a
8877 parameters must be flagged for capturing.
8879 (EmitContext.CapturedField): New method used to register that a
8880 field must be flagged for capturing.
8882 (EmitContext.HaveCapturedVariables,
8883 EmitContext.HaveCapturedFields): Return whether there are captured
8884 variables or fields.
8886 (EmitContext.EmitMethodHostInstance): This is used to emit the
8887 instance for the anonymous method. The instance might be null
8888 (static methods), this (for anonymous methods that capture nothing
8889 and happen to live side-by-side with the current method body) or a
8890 more complicated expression if the method has a CaptureContext.
8892 (EmitContext.EmitTopBlock): Routine that drives the emission of
8893 code: it will first resolve the top block, then emit any metadata
8894 and then emit the code. The split is done so that we can extract
8895 any anonymous methods and flag any captured variables/parameters.
8897 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
8898 during this phase, the ILGenerator should not be used as labels
8899 and local variables declared here might not be accessible to any
8900 code that is part of an anonymous method.
8902 Exceptions to this include the temporary variables that are
8903 created by some statements internally for holding temporary
8906 (EmitContext.EmitMeta): New routine, in charge of emitting all the
8909 (EmitContext.TemporaryReturn): This method is typically called
8910 from the Emit phase, and its the only place where we allow the
8911 ReturnLabel to be defined other than the EmitMeta. The reason is
8912 that otherwise we would have to duplicate a lot of logic in the
8913 Resolve phases of various methods that today is on the Emit
8916 (EmitContext.NeedReturnLabel): This no longer creates the label,
8917 as the ILGenerator is not valid during the resolve phase.
8919 (EmitContext.EmitThis): Extended the knowledge in this class to
8920 work in anonymous methods in addition to iterators.
8922 (EmitContext.EmitCapturedVariableInstance): This emits whatever
8923 code is necessary on the stack to access the instance to a local
8924 variable (the variable will be accessed as a field).
8926 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
8927 EmitContext.EmitAddressOfParameter): Routines to support
8928 parameters (not completed at this point).
8930 Removals: Removed RemapLocal and RemapLocalLValue. We probably
8931 will also remove the parameters.
8933 * convert.cs (Convert): Define a `ConstantEC' which points to a
8934 null. This is just to prefity some code that uses
8935 ImplicitStandardConversion code and do not have an EmitContext
8938 The idea is to flag explicitly that at that point in time, it is
8939 known that the conversion will not trigger the delegate checking
8940 code in implicit conversions (which requires a valid
8943 Everywhere: pass new EmitContext parameter since
8944 ImplicitStandardConversionExists now requires it to check for
8945 anonymous method conversions.
8947 (Convert.ImplicitStandardConversionExists): If the type of an
8948 expression is the anonymous_method_type, and the type is a
8949 delegate, we invoke the AnonymousMethod.Compatible method to check
8950 whether an implicit conversion is possible.
8952 (Convert.ImplicitConversionStandard): Only do implicit method
8953 group conversions if the language level is not ISO_1.
8955 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
8956 MethodInfo for the Invoke method. used by Delegate and
8959 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
8960 method conversions if the target type is a delegate.
8962 Removed extra debugging nops.
8964 (LocalVariableReference): Turn the `local_info' into a public
8967 Add `prepared' field, the same hack used for FieldExprs to cope
8968 with composed assignments, as Local variables do not necessarily
8969 operate purely on the stack as they used to: they can be captured
8972 Add `temp' for a temporary result, like fields.
8974 Refactor DoResolve and DoResolveLValue into DoResolveBase.
8976 It now copes with Local variables that are captured and emits the
8977 proper instance variable to load it from a field in the captured
8980 (ParameterReference.DoResolveBase): During the resolve phase,
8981 capture parameters if we are in an anonymous method.
8983 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
8984 anonymous method, use the EmitContext helper routines to emit the
8985 parameter reference.
8987 * iterators.cs: Set RemapToProxy to true/false during the
8990 * parameters.cs (GetParameterByName): New helper method.
8992 * typemanager.cs (anonymous_method_type) a new type that
8993 represents an anonyous method. This is always an internal type,
8994 used as a fencepost to test against the anonymous-methodness of an
8997 2004-10-20 Marek Safar <marek.safar@seznam.cz>
8999 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
9001 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
9003 2004-11-10 Martin Baulig <martin@ximian.com>
9005 * expression.cs (Invocation.BetterFunction): If two methods have
9006 equal parameter types, but only one of them is generic, the
9007 non-generic one wins.
9008 (New.DoResolve): Don't set `is_struct' to false if we're a generic
9009 instance; just use `Type.IsValueType' to determine whether
9010 something is a struct or not.
9011 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
9012 so we can be called multiple times.
9014 2004-11-10 Martin Baulig <martin@ximian.com>
9016 * generic.cs (TypeParameter.DefineConstraints): New public method.
9017 (TypeParameter.CheckAccessLevel): Override this and return true.
9018 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
9019 override ResolveType() anymore.
9020 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
9022 2004-11-10 Martin Baulig <martin@ximian.com>
9024 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
9025 call DeclSpace.ResolveNestedType() on it.
9027 2004-11-10 Martin Baulig <martin@ximian.com>
9029 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
9030 non-null, call ParameterModifier() on it.
9032 2004-11-10 Martin Baulig <martin@ximian.com>
9035 (Iterators): Added `current_type' and `this_type' fields.
9036 (Iterators.DefineIterator): Create a new EmitContext and store it
9037 in `ec'; compute `this_type'.
9039 2004-11-10 Martin Baulig <martin@ximian.com>
9042 (TypeManager.IsPrivateAccessible): New public method.
9043 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
9045 2004-11-10 Martin Baulig <martin@ximian.com>
9047 * class.cs (TypeContainer.DefineType): Call
9048 TypeBuilder.DefineGenericParameters() before resolving the type
9050 (MethodData.parent_method): New protected field.
9051 (MethodData..ctor): Added `MethodInfo parent_method' argument.
9052 (MethodData.Define): Compute `parent_method'.
9055 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
9056 (MemberCore.GetClsCompliantAttributeValue): Likewise.
9057 (DeclSpace.ec): New protected field; store the EmitContext here.
9058 (DeclSpace.EmitContext): New public property.
9059 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
9060 (DeclSpace.ResolveNestedType): New public method.
9061 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
9062 (DeclSpace.NestedAccessible): Added `Type tb' argument.
9063 (DeclSpace.FamilyAccessible): Likewise.
9064 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
9065 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
9068 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
9071 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
9072 (Enum.Emit): Don't create a new EmitContext.
9074 2004-10-18 Martin Baulig <martin@ximian.com>
9076 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
9077 `Type' directly, but call ResolveType() on it.
9078 (Catch.Resolve): Likewise.
9079 (Foreach.Resolve): Likewise.
9081 2004-10-18 Martin Baulig <martin@ximian.com>
9083 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
9084 `Type' directly, but call ResolveType() on it.
9085 (Probe.DoResolve): Likewise.
9086 (ArrayCreation.LookupType): Likewise.
9087 (TypeOf.DoResolve): Likewise.
9088 (SizeOf.DoResolve): Likewise.
9090 2004-10-18 Raja R Harinath <rharinath@novell.com>
9092 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
9095 2004-10-17 John Luke <john.luke@gmail.com>
9097 * class.cs (Operator.GetSignatureForError): use CSharpName
9099 * parameter.cs (Parameter.GetSignatureForError): Returns
9100 correct name even if was not defined.
9102 2004-10-13 Raja R Harinath <rharinath@novell.com>
9105 * class.cs (TypeContainer.EmitContext): New property.
9106 (DefineNestedTypes): Create an emitcontext for each part.
9107 (MethodCore.DoDefineParameters): Use container's emitcontext.
9108 Pass type array to InternalParameters.
9109 (MemberBase.DoDefine): Use container's emitcontext.
9110 (FieldMember.Define): Likewise.
9111 (Event.Define): Likewise.
9112 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9113 Pass type array to InternalParameters.
9114 (SetIndexerMethod.GetParameterInfo): Likewise.
9115 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9116 * delegate.cs (Define): Pass emitcontext to
9117 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9118 array to InternalParameters.
9119 * expression.cs (ParameterReference.DoResolveBase): Pass
9120 emitcontext to GetParameterInfo.
9121 (ComposedCast.DoResolveAsTypeStep): Remove check on
9122 ec.ResolvingTypeTree.
9123 * parameter.cs (Parameter.Resolve): Change argument to
9124 EmitContext. Use ResolveAsTypeTerminal.
9125 (Parameter.GetSignature): Change argument to EmitContext.
9126 (Parameters.ComputeSignature): Likewise.
9127 (Parameters.ComputeParameterTypes): Likewise.
9128 (Parameters.GetParameterInfo): Likewise.
9129 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9130 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9131 * support.cs (InternalParameters..ctor): Remove variant that takes
9133 * typemanager.cs (system_intptr_expr): New.
9134 (InitExpressionTypes): Initialize it.
9136 2004-10-12 Chris Toshok <toshok@ximian.com>
9138 * cs-parser.jay: fix location for try_statement and catch_clause.
9140 2004-10-18 Martin Baulig <martin@ximian.com>
9142 * class.cs (FieldMember.Define): Don't access the TypeExpr's
9143 `Type' directly, but call ResolveType() on it.
9144 (MemberBase.DoDefine): Likewise.
9146 * expression.cs (New.DoResolve): Don't access the TypeExpr's
9147 `Type' directly, but call ResolveType() on it.
9148 (ComposedCast.DoResolveAsTypeStep): Likewise.
9150 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
9151 `Type' directly, but call ResolveType() on it.
9153 2004-10-17 John Luke <john.luke@gmail.com>
9155 * class.cs (Operator.GetSignatureForError): use CSharpName
9157 * parameter.cs (Parameter.GetSignatureForError): Returns
9158 correct name even if was not defined.
9160 2004-10-13 Raja R Harinath <rharinath@novell.com>
9163 * class.cs (TypeContainer.EmitContext): New property.
9164 (DefineNestedTypes): Create an emitcontext for each part.
9165 (MethodCore.DoDefineParameters): Use container's emitcontext.
9166 Pass type array to InternalParameters.
9167 (MemberBase.DoDefine): Use container's emitcontext.
9168 (FieldMember.Define): Likewise.
9169 (Event.Define): Likewise.
9170 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9171 Pass type array to InternalParameters.
9172 (SetIndexerMethod.GetParameterInfo): Likewise.
9173 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9174 * delegate.cs (Define): Pass emitcontext to
9175 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9176 array to InternalParameters.
9177 * expression.cs (ParameterReference.DoResolveBase): Pass
9178 emitcontext to GetParameterInfo.
9179 (ComposedCast.DoResolveAsTypeStep): Remove check on
9180 ec.ResolvingTypeTree.
9181 * parameter.cs (Parameter.Resolve): Change argument to
9182 EmitContext. Use ResolveAsTypeTerminal.
9183 (Parameter.GetSignature): Change argument to EmitContext.
9184 (Parameters.ComputeSignature): Likewise.
9185 (Parameters.ComputeParameterTypes): Likewise.
9186 (Parameters.GetParameterInfo): Likewise.
9187 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9188 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9189 * support.cs (InternalParameters..ctor): Remove variant that takes
9191 * typemanager.cs (system_intptr_expr): New.
9192 (InitExpressionTypes): Initialize it.
9194 2004-10-12 Chris Toshok <toshok@ximian.com>
9196 * cs-parser.jay: fix location for try_statement and catch_clause.
9198 2004-10-07 Raja R Harinath <rharinath@novell.com>
9200 More DeclSpace.ResolveType avoidance.
9201 * decl.cs (MemberCore.InUnsafe): New property.
9202 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
9203 with newly created EmitContext.
9204 (FieldMember.Define): Likewise.
9205 * delegate.cs (Delegate.Define): Likewise.
9206 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
9207 only if normal name-lookup fails.
9208 (TypeExpr.DoResolve): Enable error-checking.
9209 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
9210 (SizeOf.DoResolve): Likewise.
9211 (ComposedCast.DoResolveAsTypeStep): Likewise.
9212 (StackAlloc.DoResolve): Likewise.
9213 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
9214 (Block.Unsafe): New property.
9215 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
9216 (Unsafe): Set 'unsafe' flag of contained block.
9217 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
9218 (Fixed.Resolve): Likewise.
9219 (Catch.Resolve): Likewise.
9220 (Using.ResolveLocalVariableDecls): Likewise.
9221 (Foreach.Resolve): Likewise.
9223 2004-10-05 John Luke <john.luke@gmail.com>
9225 * cs-parser.jay: add location to error CS0175
9227 2004-10-04 Miguel de Icaza <miguel@ximian.com>
9229 * ecore.cs (Expression.Constantity): Add support for turning null
9232 * const.cs (Const.Define): Allow constants to be reference types
9233 as long as the value is Null.
9235 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
9237 * namespace.cs (NamespaceEntry.Using): No matter which warning
9238 level is set, check if this namespace name has already been added.
9240 2004-10-03 Ben Maurer <bmaurer@ximian.com>
9242 * expression.cs: reftype [!=]= null should always use br[true,false].
9245 2004-10-03 Marek Safar <marek.safar@seznam.cz>
9248 * attribute.cs: Enum conversion moved to
9249 GetAttributeArgumentExpression to be applied to the all
9252 2004-10-01 Raja R Harinath <rharinath@novell.com>
9254 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
9255 * class.c (TypeContainer.DefineType): Flag error if
9256 base types aren't accessible due to access permissions.
9257 * decl.cs (DeclSpace.ResolveType): Move logic to
9258 Expression.ResolveAsTypeTerminal.
9259 (DeclSpace.ResolveTypeExpr): Thin layer over
9260 Expression.ResolveAsTypeTerminal.
9261 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
9262 Refactor code into NestedAccess. Use it.
9263 (DeclSpace.NestedAccess): New.
9264 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
9265 argument to silence errors. Check access permissions.
9266 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
9267 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
9268 (Cast.DoResolve): Likewise.
9269 (New.DoResolve): Likewise.
9270 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
9271 (TypeOf.DoResolve): Likewise.
9273 * expression.cs (Invocation.BetterConversion): Return the Type of
9274 the better conversion. Implement section 14.4.2.3 more faithfully.
9275 (Invocation.BetterFunction): Make boolean. Make correspondence to
9276 section 14.4.2.2 explicit.
9277 (Invocation.OverloadResolve): Update.
9278 (Invocation): Remove is_base field.
9279 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9280 (Invocation.Emit): Likewise.
9282 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9284 * cs-parser.jay: Reverted 642 warning fix.
9286 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9289 * decl.cs (FindMemberWithSameName): Indexer can have more than
9292 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9294 * expression.cs (LocalVariableReference.DoResolveLValue):
9295 Do not report warning 219 for out values.
9296 (EmptyExpression.Null): New member to avoid extra allocations.
9298 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9300 * cs-parser.jay: Fix wrong warning 642 report.
9302 * cs-tokenizer.cs (CheckNextToken): New helper;
9303 Inspect next character if is same as expected.
9305 2004-09-23 Martin Baulig <martin@ximian.com>
9307 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9308 (Convert.ImplicitReferenceConversionExists): Likewise.
9310 2004-11-09 Raja R Harinath <rharinath@novell.com>
9312 * Makefile (DISTFILES): Comment out a few missing files.
9314 2004-10-29 Raja R Harinath <rharinath@novell.com>
9316 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9317 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9318 (gmcs.exe): Invoke bootstrap-libs.
9319 (clean-local): Clean the net_2_0_bootstrap profile too.
9320 (PROGRAM_INSTALL_DIR): New.
9321 (install-local): Use it.
9323 2004-10-13 Martin Baulig <martin@ximian.com>
9325 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9326 (TypeParameter.DefineType): If we're a method type parameter and
9327 that method is overriding something, "inflate" its constraints.
9329 2004-10-12 Martin Baulig <martin@ximian.com>
9331 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9332 and have type arguments, create and resolve a ConstructedType.
9334 2004-10-12 Martin Baulig <martin@ximian.com>
9336 * decl.cs (MemberCache.FindMemberToOverride): Use
9337 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9338 to compare the invocationType.
9340 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9341 When comparing two type parameters, only do the signature-only
9342 comparision for method type parameters.
9344 2004-10-11 Martin Baulig <martin@ximian.com>
9346 * report.cs: Don't make --fatal abort on warnings, we have
9347 -warnaserror for that.
9349 2004-10-11 Martin Baulig <martin@ximian.com>
9352 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9353 (TypeManager.IsEqual): Call ourself recursively instead of using
9356 2004-10-11 Martin Baulig <martin@ximian.com>
9358 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9359 on our own type parameters, not on the ones we inherit from a containing
9362 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9365 * generic.cs (TypeParameter.Define): We may only be called once.
9367 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9368 instead of TypeManager.IsEqual().
9370 2004-09-28 Martin Baulig <martin@ximian.com>
9373 (GenericConstraints.EffectiveBaseClass): New public property.
9374 (TypeParameter.GenericConstraints): New public property.
9375 (ConstructedType.CheckConstraints): Improved.
9377 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9378 (Convert.TypeParameterConversion): New private method; use this in
9379 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9380 for all conversions related to type parameters.
9382 2004-09-24 Martin Baulig <martin@ximian.com>
9384 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9385 type parameter conversions for type parameters which are known to
9388 2004-09-24 Martin Baulig <martin@ximian.com>
9390 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9391 `IsValueType' properties.
9393 * support.cs (ReflectionConstraints): Use
9394 Type.GetGenericParameterConstraints() instead of the old hack.
9396 2004-09-24 Martin Baulig <martin@ximian.com>
9398 * generic.cs (GenericConstraints): Moved here and made it an
9401 * support.cs (GenericConstraints): Moved to generic.cs.
9403 2004-09-24 Martin Baulig <martin@ximian.com>
9406 (ReflectionConstraints): Un-nested this class and made it public.
9409 (TypeManager.GetTypeParameterConstraints): New public method.
9410 (TypeManager.HasConstructorConstraint): Use the attributes.
9412 2004-09-24 Martin Baulig <martin@ximian.com>
9414 * support.cs (GenericConstraints): Replaced `HasConstructor',
9415 `IsReferenceType' and `IsValueType' with `Attributes'.
9416 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9417 method and made the .ctor public.
9419 * generic.cs (Constraints.Attributes): New public property.
9420 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9421 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9422 `IsValueType' -> `HasValueTypeConstraint'.
9424 2004-09-23 Martin Baulig <martin@ximian.com>
9426 * generic.cs (Constraints): Reflect latest runtime changes.
9428 2004-09-23 Martin Baulig <martin@ximian.com>
9430 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9431 (Convert.ImplicitReferenceConversionExists): Likewise.
9433 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9435 * class.cs (Operator.Define): Add error 448 and 559 report.
9437 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9439 * class.cs (MemberBase.IsTypePermitted): New protected
9440 method for checking error CS0610.
9442 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9444 * class.cs (TypeContainer.HasExplicitLayout): New property
9445 Returns whether container has StructLayout attribute set Explicit.
9446 (FieldMember): New abstract class for consts and fields.
9447 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9448 (Field): Reuse FieldMember.
9450 * const.cs (Const): Reuse FieldMember.
9452 * rootcontext.cs: EmitConstants call moved to class.
9454 2004-09-22 Martin Baulig <martin@ximian.com>
9456 Marek and me just fixed one of our oldest bugs: #28562 :-)
9458 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9460 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9461 we're an EnumConstant, just return that.
9462 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9463 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9464 to get the value which'll actually be written into the attribute.
9465 However, we have to use GetValue() to access the attribute's value
9468 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9470 * constant.cs (Constant.IsNegative): New abstract property
9473 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9474 (StackAlloc.DoResolve): Reused IsNegative.
9476 2004-09-22 Martin Baulig <martin@ximian.com>
9478 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9479 public method; like LookupTypeContainer, but also works for
9482 * report.cs (Report.SymbolRelatedToPreviousError): Use
9483 TypeManager.LookupGenericTypeContainer().
9485 2004-09-22 Martin Baulig <martin@ximian.com>
9487 Thanks to Peter Sestoft for this bug report.
9489 * expression.cs (Conditional): If both the `trueExpr' and the
9490 `falseExpr' is a NullLiteral, return a NullLiteral.
9492 2004-09-22 Martin Baulig <martin@ximian.com>
9494 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9495 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9496 for the "get_Current" call.
9498 2004-09-21 Martin Baulig <martin@ximian.com>
9500 * convert.cs (Convert.ImplicitReferenceConversion): When
9501 converting to an interface type, first check whether we're
9502 converting from a reference type.
9504 2004-09-14 Martin Baulig <martin@ximian.com>
9506 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9508 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9511 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9512 called and is obsolete then this member suppress message
9513 when call is inside next [Obsolete] method or type.
9515 * expression.cs: Use TestObsoleteMethodUsage member.
9517 2004-09-14 Martin Baulig <martin@ximian.com>
9519 * genericparser.cs: Removed.
9521 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9523 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9525 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9527 * attribute.cs (Attribute.Resolve): Add error 653 report.
9529 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9531 (Method.ApplyAttributeBuilder): Add error 685 report.
9532 (Operator.Define): Add error 564 report.
9534 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9536 * expression.cs (Invocation.DoResolve): Add error
9539 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9542 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9544 * class.cs (ConstructorInitializer.Resolve):
9545 Wrong error number (515->516).
9547 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9549 * class.cs (Indexer.Define): Add error 631 report.
9551 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9553 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9555 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9557 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9559 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9561 * cs-parser.jay: Added error CS0241 report.
9563 2004-09-10 Raja R Harinath <rharinath@novell.com>
9565 * cs-parser.jay (fixed_statement): Introduce a scope for the
9566 declaration in the 'fixed' statement.
9568 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9570 * cs-parser.jay: Added CS0230 error report.
9572 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9574 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9576 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9578 * expression.cs (Argument.Resolve): Added error CS0192 and
9581 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9583 C# 2.0 #pragma warning feature
9585 * cs-tokenizer.cs (PreProcessPragma): New method;
9586 Handles #pragma directive.
9588 * report.cs (WarningRegions): New class; Support
9589 class for #pragma warning directive. It tests whether
9590 warning is enabled for a given line.
9592 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9594 * const.cs: Add more descriptive error report, tahnks to
9597 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9599 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9601 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9603 * expression.cs: Apply patch from Ben: Remove dead code from
9604 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9605 as that code just threw an exception anwyays.
9607 * const.cs: Remove the call to the turnintoconstant, for details
9610 * literal.cs: The type of the null-literal is the null type; So
9611 we use a placeholder type (literal.cs:System.Null, defined here)
9614 * expression.cs (Conditional.DoResolve): Remove some old code that
9615 is no longer needed, conversions have been fixed.
9617 (ArrayCreationExpression.DoResolve): Return false if we fail to
9618 resolve the inner expression.
9620 2004-09-07 Raja R Harinath <rharinath@novell.com>
9623 * cs-parser.jay (delegate_declaration): Record a delegate
9624 declaration as a type declaration.
9625 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9627 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9629 * parameter.cs: Do not crash if the type can not be resolved.
9631 * expression.cs: Report errors with unsafe pointers, fixes #64896
9633 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9635 * expression.cs: Pointer arith always needs to do a conv.i
9636 if the operand is a long. fix 65320
9638 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9640 Fixed cs0619-37.cs, cs0619-38.cs
9642 * enum.cs (GetObsoleteAttribute): Removed.
9644 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9645 on Enum member is double staged. The first is tested member
9648 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9650 Fixed #56986, #63631, #65231
9652 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9653 adds member to name container.
9654 (TypeContainer.AddToTypeContainer): New method, adds type to
9656 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9657 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9658 AddOperator): Simplified by reusing AddToMemberContainer.
9659 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9661 (Method.CheckForDuplications): Fixed implementation to test all
9663 (MemberBase): Detection whether member is explicit interface
9664 implementation is now in constructor.
9665 (MemberBase.UpdateMemberName): Handles IndexerName.
9666 (Accessor): Changed to keep also location information.
9667 (AbstractPropertyEventMethod): Is derived from MemberCore.
9668 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9669 will be emited or not.
9670 (PropertyBase.AreAccessorsDuplicateImplementation):
9671 Tests whether accessors are not in collision with some method.
9672 (Operator): Is derived from MethodCore to simplify common
9675 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9677 (DeclSpace.AddToContainer): Adds the member to defined_names
9678 table. It tests for duplications and enclosing name conflicts.
9680 * enum.cs (EnumMember): Clean up to reuse the base structures
9682 2004-09-03 Martin Baulig <martin@ximian.com>
9684 Merged latest changes into gmcs. Please keep this comment in
9685 here, it makes it easier for me to see what changed in MCS since
9686 the last time I merged.
9688 2004-09-03 Martin Baulig <martin@ximian.com>
9690 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9691 into TypeContainer, to make partial classes work again.
9693 2004-09-03 Martin Baulig <martin@ximian.com>
9695 * rootcontext.cs (RootContext.V2): Removed.
9697 2004-03-23 Martin Baulig <martin@ximian.com>
9699 * expression.cs (Invocation.OverloadResolve): Added `bool
9700 may_fail' argument and use it instead of the Location.IsNull() hack.
9702 2004-09-09 Martin Baulig <martin@ximian.com>
9704 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9706 2004-09-09 Martin Baulig <martin@ximian.com>
9708 * generic.cs (TypeParameter.DefineType): Added support for
9709 explicit interface methods.
9711 2004-09-09 Martin Baulig <martin@ximian.com>
9713 * README.Changes: New document. Started to list important changes
9714 between MCS and GMCS here.
9716 2004-09-08 Martin Baulig <martin@ximian.com>
9719 (TypeContainer.CheckRecursiveDefinition): New protected method.
9720 (TypeContainer.DefineType): Move the CS0146 check into
9721 CheckRecursiveDefinition().
9723 2004-09-06 Martin Baulig <martin@ximian.com>
9725 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9726 types for the constructor constraint.
9728 2004-09-03 Martin Baulig <martin@ximian.com>
9730 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9731 into TypeContainer, to make partial classes work again.
9733 2004-09-03 Martin Baulig <martin@ximian.com>
9735 * rootcontext.cs (RootContext.V2): Removed.
9737 2004-03-23 Martin Baulig <martin@ximian.com>
9739 * expression.cs (Invocation.OverloadResolve): Added `bool
9740 may_fail' argument and use it instead of the Location.IsNull() hack.
9742 2004-09-03 Martin Baulig <martin@ximian.com>
9744 Merged latest changes into gmcs. Please keep this comment in
9745 here, it makes it easier for me to see what changed in MCS since
9746 the last time I merged.
9748 2004-09-03 Raja R Harinath <rharinath@novell.com>
9751 * expression.cs (BetterConversion): Don't allow either conversion
9752 to be null. Remove redundant implicit conversion test when 'q ==
9753 null' -- when this function is invoked, we already know that the
9754 implicit conversion exists.
9755 (BetterFunction): Assume that 'best' is non-null. Remove
9756 redundant reimplementation of IsApplicable when 'best' is null.
9757 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9758 number of arguments.
9759 (IsAncestralType): Extract from OverloadResolve.
9760 (OverloadResolve): Make robust to the MethodGroupExpr being
9761 unsorted. Implement all the logic of Section 14.5.5.1, and
9762 support overloading of methods from multiple applicable types.
9763 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9765 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9766 (RealError, Warning): Append type of report to related symbol.
9768 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9770 * enum.cs: Fixed CLS-Compliance checks for enum members.
9771 Error tests cs3008-8.cs, cs3014-8.cs
9773 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9775 Fixed bug #62342, #63102
9776 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9777 like ImplementMethod.
9779 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9781 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9784 2004-09-02 Martin Baulig <martin@ximian.com>
9786 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9787 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9790 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9792 C# 2.0 Static classes implemented
9794 * class.cs (TypeContainer): instance_constructors,
9795 initialized_fields, initialized_static_fields,
9796 default_constructor, base_inteface_types are protected to be
9797 accessible from StaticClass.
9798 (TypeContainer.DefineDefaultConstructor): New virtual method
9799 for custom default constructor generating
9800 (StaticClass): New class to handle "Static classes" feature.
9802 * cs-parser.jay: Handle static keyword on class like instance
9805 * driver.cs: Added "/langversion" command line switch with two
9806 options (iso-1, default).
9808 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9810 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9812 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9814 * delegate.cs: Style.
9816 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9818 * delegate.cs: Add seperate instance expr field for miguel.
9820 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9822 * PointerArithmetic (Resolve): make sure we are not doing
9823 pointer arith on void*. Also, make sure we are resolved
9824 by not setting eclass until resolve.
9826 All callers: Make sure that PointerArithmetic gets resolved.
9828 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9830 * ArrayCreation (LookupType): If the type does not resolve
9831 to an array, give an error.
9833 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9835 * statement.cs (Try.Resolve): Fixed bug #64222
9837 2004-08-27 Martin Baulig <martin@ximian.com>
9840 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9843 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9845 * ecore.cs (Constantify): Get underlying type via
9846 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9847 Windows in special cases.
9849 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9851 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9852 for obtaining also private methods.
9853 (GetRemoveMethod): Used GetRemoveMethod (true)
9854 for obtaining also private methods.
9856 2004-09-02 Martin Baulig <martin@ximian.com>
9858 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9859 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9862 2004-08-27 Martin Baulig <martin@ximian.com>
9865 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9868 2004-08-25 Martin Baulig <martin@ximian.com>
9870 * support.cs (ReflectionParameters..ctor): If this is a generic
9871 method, retrieve and store its type parameters.
9872 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9873 (ReflectionParameters.GenericConstraints): The argument specifies
9874 the type parameter, not the method parameter.
9875 (InternalParameters.GenericConstraints): Likewise.
9877 * generic.cs (TypeParameter.DefineType): Correctly handle
9878 constraints wrt. generic methods in interfaces and their
9881 2004-08-24 Martin Baulig <martin@ximian.com>
9883 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9884 (Constraints.IsSubclassOf): New internal method.
9886 * typemanager.cs (TypeManager.FindMembers): Added special support
9887 for GenericTypeParameterBuilder's.
9888 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
9891 2004-08-24 Martin Baulig <martin@ximian.com>
9894 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
9895 this for accessibility checks.
9896 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
9897 IsNestedFamilyAccessible.
9898 (TypeManager.IsSubclassOf): New method, do what the name actually
9901 2004-08-24 Martin Baulig <martin@ximian.com>
9903 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
9904 as a SimpleName, include the generic arity.
9906 2004-08-24 Martin Baulig <martin@ximian.com>
9908 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
9909 MethodAttributes.HideBySig for operators.
9911 2004-08-23 Martin Baulig <martin@ximian.com>
9913 Back to the old error reporting system :-)
9915 * report.cs (Message): Removed.
9916 (Report.MessageData, ErrorData, WarningData): Removed.
9917 (Report.Error, Warning): Back to the old system.
9919 2004-08-23 Martin Baulig <martin@ximian.com>
9921 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
9923 * class.cs (TypeContainer.ParentContainer): New public virtual
9924 method; replaces the explicit interface implementation.
9925 (ClassPart.ParentContainer): Override.
9927 2004-08-23 Martin Baulig <martin@ximian.com>
9929 * statement.cs (Switch): Added support for constant switches; see
9930 #59428 or test-285.cs.
9932 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9935 * statement.cs (GetEnumeratorFilter): Removed useless
9936 logic because C# specs is strict. GetEnumerator must be
9939 2004-08-22 Martin Baulig <martin@ximian.com>
9941 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9942 a switch and may break, reset the barrier. Fixes #59867.
9944 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9946 CLS-Compliance speed up (~5% for corlib)
9948 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
9949 New method. Tests container for CLS-Compliant names
9951 * class.cs (TypeContainer.VerifyClsName): New method.
9952 Checks whether container name is CLS Compliant.
9953 (Constructor): Implements IMethodData.
9955 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
9956 low-case table for CLS Compliance test.
9957 (MemberCache.VerifyClsParameterConflict): New method.
9958 Checks method parameters for CS3006 error.
9960 * enum.cs (EnumMember): Is derived from MemberCore.
9961 (Enum.VerifyClsName): Optimized for better performance.
9963 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9965 * report.cs: Renamed Error_T to Error and changed all
9968 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9970 * class.cs (TypeContainer.IndexerArrayList): New inner class
9971 container for indexers.
9972 (TypeContainer.DefaultIndexerName): New constant for default
9973 indexer name. Replaced all "Item" with this constant.
9974 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
9976 * typemanager.cs (TypeManager.default_member_ctor): Cache here
9977 DefaultMemberAttribute constructor.
9979 2004-08-05 Martin Baulig <martin@ximian.com>
9981 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9984 2004-08-05 Marek Safar <marek.safar@seznam.cz>
9986 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
9987 multi platforms problem.
9989 * compiler.csproj: Included shared files.
9991 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9993 Fix bug 60333, 55971 in the more general way
9994 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9995 Added arg_type argument for constant conversion.
9996 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
9998 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10001 * class.cs (TypeContainer ): New inner classes MethodArrayList,
10002 OperatorArrayList, MethodCoreArrayList for typecontainer
10003 containers. Changed class member types to these new types.
10004 (MethodArrayList.DefineMembers): Added test for CS0659.
10006 2004-08-04 Miguel de Icaza <miguel@ximian.com>
10008 * cfold.cs: Synchronize the folding with the code in expression.cs
10009 Binary.DoNumericPromotions for uint operands.
10011 * attribute.cs: Revert patch from Raja, it introduced a regression
10012 while building Blam-1.2.1 (hard to isolate a test case).
10014 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10018 (TypeContainer.Define): Renamed to DefineContainerMembers because of
10020 (MethodCore.parent_method): New member. The method we're overriding
10021 if this is an override method.
10022 (MethodCore.CheckBase): Moved from Method class and made common.
10023 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
10025 (MethodCore.CheckForDuplications): New abstract method. For custom
10026 member duplication search in a container
10027 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
10028 method and its return type.
10029 (Event.conflict_symbol): New member. Symbol with same name in the
10033 (MemberCache.FindMemberWithSameName): New method. The method
10034 is looking for conflict with inherited symbols.
10036 2004-08-04 Martin Baulig <martin@ximian.com>
10038 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10040 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10042 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10044 * report.cs (Message): New enum for better error, warning reference in
10046 (MessageData): New inner abstract class. It generally handles printing of
10047 error and warning messages.
10048 Removed unused Error, Warning, Message methods.
10050 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10052 Fix for cs0592-8.cs test
10054 (Attributable.ValidAttributeTargets): Made public.
10055 (Attribute.ExplicitTarget): New member for explicit target value.
10056 (Attribute.CheckTargets): Now we translate explicit attribute
10057 target to Target here.
10059 2004-08-03 Ben Maurer <bmaurer@ximian.com>
10061 * ecore.cs (MethodGroupExpr): new IsBase property.
10063 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
10065 * delegate.cs (DelegateCreation): store a MethodGroupExpr
10066 rather than an instance expr.
10068 (DelegateCreation.Emit): Use the method group rather than
10069 the instance expression. Also, if you have base.Foo as the
10070 method for a delegate, make sure to emit ldftn, not ldftnvirt.
10072 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
10074 (NewDelegate.DoResolve): Only check for the existance of Invoke
10075 if the method is going to be needed. Use MethodGroupExpr.
10077 (NewDelegate.Emit): Remove, DelegateCreation implements this.
10079 * expression.cs: For pointer arith., make sure to use
10080 the size of the type, not the size of the pointer to
10083 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10086 * class.cs (Class): Added error CS0502 test.
10088 2004-08-03 John Luke <jluke@cfl.rr.com>
10089 Raja R Harinath <rharinath@novell.com>
10092 * attribute.cs (Attribute.complained_before): New flag.
10093 (Attribute.ResolveType, Attribute.Resolve),
10094 (Attribute.DefinePInvokeMethod): Set it.
10095 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
10097 2004-08-03 Martin Baulig <martin@ximian.com>
10099 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10100 use a user-defined operator; we still need to do numeric
10101 promotions in case one argument is a builtin type and the other
10102 one has an implicit conversion to that type. Fixes #62322.
10104 2004-08-18 Martin Baulig <martin@ximian.com>
10106 * class.cs (Method.Define): Use the correct method name when
10107 creating the MethodBuilder for a generic method.
10109 2004-08-17 Martin Baulig <martin@ximian.com>
10111 * generic.cs (Constraints): Support type parameter constraints.
10113 2004-08-16 Martin Baulig <martin@ximian.com>
10115 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
10116 (Token.GENERIC_DIMENSION): New token; this is returned if we
10117 encounter an unbound generic type in a typeof() expression.
10119 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
10120 this token is only generated while parsing a typeof() expression.
10121 (typeof_expression): Removed the old unbound_type hack.
10123 * generic.cs (TypeArguments.IsUnbound): New public property.
10125 * decl.cs (MemberName): Added support for unbound types.
10127 2004-08-14 Martin Baulig <martin@ximian.com>
10130 (TypeManager.IsEqualGenericInstance): New static method.
10131 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
10132 just used to check accessibility, so follow the rules of 26.1.6.
10134 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
10135 ConstructedType instead of a TypeExpression if we have type arguments.
10137 * cs-parser.jay (typeof_expression): Support unbound generic types.
10139 * ecore.cs (UnboundTypeExpression): New public class.
10141 2004-08-12 Martin Baulig <martin@ximian.com>
10143 * typemanager.cs (TypeManager.IsNestedChildOf): Use
10144 TypeManager.IsEqual() rather than `=='.
10146 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
10147 generic instances as well.
10149 2004-08-12 Martin Baulig <martin@ximian.com>
10151 * expression.cs (Invocation.InferType): We can only infer method
10152 type parameters. Fixes #62647.
10154 2004-08-11 Martin Baulig <martin@ximian.com>
10156 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
10157 before resolving the base classes.
10159 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10161 * Makefile: install .mdb file too.
10163 2004-08-05 Martin Baulig <martin@ximian.com>
10165 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
10166 initializer, the current type is just the TypeBuilder, not the
10167 instantiated generic type.
10168 (FieldExpr.IsFieldInitializer): New public property.
10170 2004-08-04 Martin Baulig <martin@ximian.com>
10172 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10174 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10176 2004-08-03 Martin Baulig <martin@ximian.com>
10178 * class.cs (MethodData.Define): If we're an explicit
10179 implementation, remove the generic arity from the type name.
10181 2004-08-03 Martin Baulig <martin@ximian.com>
10183 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10184 use a user-defined operator; we still need to do numeric
10185 promotions in case one argument is a builtin type and the other
10186 one has an implicit conversion to that type. Fixes #62322.
10188 2004-08-02 Martin Baulig <martin@ximian.com>
10190 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
10191 `TypeExpr[]' array.
10192 (TypeContainer.GetClassBases): Return the unexpanded list of
10193 interfaces; we expand them later.
10194 (TypeContainer.DefineType): After creating the TypeBuilder, call
10195 TypeManager.ExpandInterfaces() to get an expanded and resolved
10196 list of interfaces.
10198 * ecore.cs (TypeExpr.GetInterfaces): Removed
10200 * generics.cs (Constraints.InterfaceConstraints): Remove.
10201 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
10202 register the interface constraints.
10205 (TypeManager.AddUserType): Removed the `ifaces' argument.
10206 (TypeManager.AddTypeParameter): Likewise.
10207 (TypeManager.AddUserInterface): Removed, was unused.
10208 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
10209 `TypeExpr[]' array for the interfaces.
10210 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
10211 has been defined, returns a list of the resolved interfaces types.
10212 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
10213 (TypeManager.GetExplicitInterfaces): Likewise.
10215 2004-08-02 Martin Baulig <martin@ximian.com>
10217 * expression.cs (Invocation.EmitCall): If we're invoking a method
10218 on a type parameter, use the new `Constrained' prefix opcode.
10220 2004-08-02 Martin Baulig <martin@ximian.com>
10222 * statement.cs (LocalInfo.Flags): Added `IsThis'.
10223 (LocalInfo.IsThis): New public property.
10224 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
10226 2004-08-01 Martin Baulig <martin@ximian.com>
10228 * class.cs (TypeContainer.GetClassBases): Don't set the default
10229 here since we may get called from GetPartialBases().
10230 (TypeContainer.DefineType): If GetClassBases() didn't return a
10231 parent, use the default one.
10233 2004-07-30 Martin Baulig <martin@ximian.com>
10235 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
10237 * class.cs (SourceMethod): New public class, derive from the
10238 symbol writer's ISourceMethod.
10239 (Method): Use the new symbol writer API.
10241 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
10242 as argument and use the new symbol writer.
10245 (SourceFile): Implement the symbol writer's ISourceFile.
10246 (Location.SymbolDocument): Removed.
10247 (Location.SourceFile): New public property.
10249 * symbolwriter.cs: Use the new symbol writer API.
10251 2004-07-30 Raja R Harinath <rharinath@novell.com>
10253 * Makefile (install-local): Remove. Functionality moved to
10256 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
10258 * Makefile: Install mcs.exe.config file together with mcs.exe.
10259 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
10260 correct runtime version.
10262 2004-07-25 Martin Baulig <martin@ximian.com>
10265 (TypeContainer.RegisterOrder): Removed, this was unused.
10266 (TypeContainer, interface_order): Removed.
10267 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
10268 TypeContainer as argument since we can also be called with a
10269 `PartialContainer' for a partial class/struct/interface.
10270 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
10271 of checking whether we're an `Interface' - we could be a
10272 `PartialContainer'.
10273 (PartialContainer.Register): Override; call
10274 AddClass()/AddStruct()/AddInterface() on our parent.
10276 * cs-parser.jay (interface_member_declaration): Add things to the
10277 `current_container', not the `current_class'.
10279 * rootcontext.cs (RegisterOrder): The overloaded version which
10280 takes an `Interface' was unused, removed.
10282 * typemanager.cs (TypeManager.LookupInterface): Return a
10283 `TypeContainer', not an `Interface'.
10284 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10285 contain a `PartialContainer' for an interface, so check it's
10286 `Kind' to figure out what it is.
10288 2004-07-25 Martin Baulig <martin@ximian.com>
10290 * class.cs (Class.DefaultTypeAttributes): New public constant.
10291 (Struct.DefaultTypeAttributes): Likewise.
10292 (Interface.DefaultTypeAttributes): Likewise.
10293 (PartialContainer.TypeAttr): Override this and add the
10294 DefaultTypeAttributes.
10296 2004-07-25 Martin Baulig <martin@ximian.com>
10298 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10299 we can just use the `Parent' field instead.
10301 2004-07-25 Martin Baulig <martin@ximian.com>
10303 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10305 2004-07-25 Martin Baulig <martin@ximian.com>
10307 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10308 our parts before defining any methods.
10309 (TypeContainer.VerifyImplements): Make this virtual.
10310 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10311 on our PartialContainer.
10313 2004-07-25 Martin Baulig <martin@ximian.com>
10315 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10317 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10318 argument, we can just use the `Parent' field instead.
10321 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10322 (MemberBase.DoDefine): Likewise.
10324 2004-07-24 Martin Baulig <martin@ximian.com>
10326 * decl.cs (MemberCore.Parent): New public field.
10327 (DeclSpace.Parent): Moved to MemberCore.
10329 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10330 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10332 (FieldBase, Field, Operator): Likewise.
10333 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10334 (EventField, Event): Likewise.
10336 2004-07-23 Martin Baulig <martin@ximian.com>
10338 * class.cs (PartialContainer): New public class.
10339 (ClassPart): New public class.
10340 (TypeContainer): Added support for partial classes.
10341 (TypeContainer.GetClassBases): Splitted some of the functionality
10342 out into GetNormalBases() and GetPartialBases().
10344 * cs-tokenizer.cs (Token.PARTIAL): New token.
10345 (Tokenizer.consume_identifier): Added some hacks to recognize
10346 `partial', but only if it's immediately followed by `class',
10347 `struct' or `interface'.
10349 * cs-parser.jay: Added support for partial clases.
10351 2004-07-23 Martin Baulig <martin@ximian.com>
10353 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10354 a `DeclSpace' and also made it readonly.
10355 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10356 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10357 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10359 * cs-parser.jay: Pass the `current_class', not the
10360 `current_container' (at the moment, this is still the same thing)
10361 to a new Method, Property, Event, Indexer or Constructor.
10363 2004-07-23 Martin Baulig <martin@ximian.com>
10365 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10366 and removed the `current_interface' one.
10367 (struct_declaration, class_declaration, interface_declaration):
10368 Set `current_class' to the newly created class/struct/interface;
10369 set their `Bases' and call Register() before parsing their body.
10371 2004-07-23 Martin Baulig <martin@ximian.com>
10373 * class.cs (Kind): New public enum.
10374 (TypeContainer): Made this class abstract.
10375 (TypeContainer.Kind): New public readonly field.
10376 (TypeContainer.CheckDef): New public method; moved here from
10378 (TypeContainer.Register): New public abstract method.
10379 (TypeContainer.GetPendingImplementations): New public abstract
10381 (TypeContainer.GetClassBases): Removed the `is_class' and
10382 `is_iface' parameters.
10383 (TypeContainer.DefineNestedTypes): Formerly known as
10385 (ClassOrStruct): Made this class abstract.
10387 * tree.cs (RootTypes): New public type.
10389 2004-07-20 Martin Baulig <martin@ximian.com>
10391 * tree.cs (Tree.RecordNamespace): Removed.
10392 (Tree.Namespaces): Removed.
10394 * rootcontext.cs (RootContext.IsNamespace): Removed.
10396 * cs-parser.jay (namespace_declaration): Just create a new
10397 NamespaceEntry here.
10399 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10401 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10402 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10403 entry to make sure it runs in the correct runtime version.
10405 2004-07-18 Martin Baulig <martin@ximian.com>
10407 * generic.cs (ConstructedType.CheckConstraints): Improved
10408 constraints checking.
10410 2004-07-18 Martin Baulig <martin@ximian.com>
10412 * expression.cs (Invocation.BetterMethod): Call
10413 TypeManager.TypeToCoreType() on all types and removed my previous
10414 hack; we're already doig the right thing here.
10416 2004-07-17 Martin Baulig <martin@ximian.com>
10418 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10420 2004-07-16 Martin Baulig <martin@ximian.com>
10422 * iterators.cs: Added generics support.
10424 2004-07-16 Martin Baulig <martin@ximian.com>
10426 * iterators.cs: Rewrote this. We're now using one single Proxy
10427 class for both the IEnumerable and the IEnumerator interface and
10428 `Iterator' derives from Class so we can use the high-level API.
10430 * class.cs (TypeContainer.AddIterator): New method.
10431 (TypeContainer.DoDefineType): New protected virtual method, which
10432 is called from DefineType().
10433 (TypeContainer.DoDefineMembers): Call DefineType() and
10434 DefineMembers() on all our iterators.
10435 (TypeContainer.Emit): Call Emit() on all our iterators.
10436 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10438 * codegen.cs (EmitContext.CurrentIterator): New public field.
10440 2004-07-15 Martin Baulig <martin@ximian.com>
10443 (TypeManager.not_supported_exception_type): New type.
10445 2004-07-14 Martin Baulig <martin@ximian.com>
10448 (TypeManager.generic_ienumerable_type): New type.
10449 (TypeManager.generic_ienumerator_type): New type.
10452 (RootContext.interfaces_first_stage): Added
10453 "System.Collections.Generic.IEnumerator`1" and
10454 "System.Collections.Generic.IEnumerable`1".
10456 2004-07-14 Martin Baulig <martin@ximian.com>
10458 * iterators.cs: Use real error numbers.
10460 2004-07-14 Martin Baulig <martin@ximian.com>
10462 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10463 requires this to be a System.Collection.IEnumerable and not a
10464 class implementing that interface.
10465 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10467 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10469 * class.cs: Fixed previous fix, it broke some error tests.
10471 2004-07-12 Martin Baulig <martin@ximian.com>
10473 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10476 2004-07-14 Martin Baulig <martin@ximian.com>
10478 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10479 an exclamation mark (!) for the generic arity to reflect the
10480 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10482 2004-07-13 Martin Baulig <martin@ximian.com>
10484 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10485 specifiers being part of a type argument.
10487 2004-07-13 Martin Baulig <martin@ximian.com>
10489 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10490 name for generic types.
10492 2004-07-13 Martin Baulig <martin@ximian.com>
10494 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10497 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10499 * assign.cs (LocalTemporary): Add new argument: is_address,If
10500 `is_address' is true, then the value that we store is the address
10501 to the real value, and not the value itself.
10503 * ecore.cs (PropertyExpr): use the new local temporary
10504 stuff to allow us to handle X.Y += z (where X is a struct)
10506 2004-07-08 Martin Baulig <martin@ximian.com>
10508 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10509 not always return, just like we're doing in Using.Resolve().
10511 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10513 * cs-parser.jay (fixed_statement): flag this as Pinned.
10515 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10517 * typemanager.cs (TypeManager): Removed MakePinned method, this
10518 mechanism is replaced with the .NET 2.x compatible mechanism of
10519 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10521 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10522 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10523 `IsFixed' property which has a different meaning.
10525 2004-07-02 Raja R Harinath <rharinath@novell.com>
10527 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10528 visible from inside a nested class, not just the names of the
10529 immediately enclosing class.
10530 Fix for bug #60730.
10532 2004-06-24 Raja R Harinath <rharinath@novell.com>
10534 * expression.cs (BetterConversion): Remove buggy special-case
10535 handling of "implicit constant expression conversions". At this
10536 point, we already know that the conversion is possible -- we're
10537 only checking to see which is better.
10539 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10541 * cs-parser.jay: Added error CS0210 test.
10543 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10545 * cs-parser.jay: Added error CS0134 test.
10547 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10550 * cs-parser.jay: Added error CS0145 test.
10552 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10554 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10556 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10558 * expression.cs (StackAlloc.Resolve): The argument may not
10559 be a constant; deal with this case.
10561 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10563 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10564 GetIndexerAttributeValue.
10565 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10567 * class.cs (Indexer.Define): Added error tests for CS0415,
10570 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10572 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10575 2004-06-23 Martin Baulig <martin@ximian.com>
10577 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10578 neither return nor throw, reset the barrier as well. Fixes #60457.
10580 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10582 * class.cs : EventAttributes is now set to None by default.
10583 This fixes bug #60459.
10585 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10588 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10589 Don't throw exception but return null (it's sufficient now).
10591 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10593 * typemanager.cs (GetArgumentTypes): Faster implementation.
10595 2004-06-18 Martin Baulig <martin@ximian.com>
10597 * attribute.cs (Attribute.Resolve): Check whether we're an
10598 EmptyCast which a Constant child. Fixes #60333.
10600 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10602 * statement.cs (EmitCollectionForeach): Account for the fact that
10603 not all valuetypes are in areas which we can take the address of.
10604 For these variables, we store to a temporary variable. Also, make
10605 sure that we dont emit a `callvirt' on a valuetype method.
10607 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10609 * expression.cs (StackAlloc.DoReSolve): Added test for
10610 negative parameter (CS0247).
10612 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10615 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10617 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10620 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10623 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10625 Fix bug #58254 & cs1555.cs, cs1556.cs
10626 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10628 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10630 * cs-parser.jay: Added error CS1669 test for indexers.
10632 2004-06-18 Martin Baulig <martin@ximian.com>
10634 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10635 argument. Fixes #60441.
10637 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10638 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10639 The name needs to have the actual name of the method in order
10640 for other tests (such as the one in OverloadResolve for Invoke
10641 on a delegate) to work. As well, it does not really help
10642 error reporting because the method group had multiple methods.
10643 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10644 Make profiling work.
10646 2004-06-13 Martin Baulig <martin@ximian.com>
10648 * cs-parser.jay: Don't allow generic attributes.
10650 2004-06-13 Martin Baulig <martin@ximian.com>
10652 * class.cs (MemberBase.DoDefineBase): New protected method.
10653 (MemberBase.DoDefine): Compute the `flags' in the new
10654 DoDefineBase() which must be called first.
10655 (Method.Define): Call DoDefineBase() first so we have the flags
10656 when defining the generic method.
10658 * cs-parser.jay (interface_method_declaration): Support generic methods.
10660 2004-06-13 Martin Baulig <martin@ximian.com>
10662 * decl.cs (TypeName): Removed.
10663 (MemberName): Removed TypeName and MemberNow; now we just have
10666 * cs-parser.jay: Don't distinguish between type arguments and type
10667 parameters in the grammar and simplified the rules a bit. The
10668 reduce/reduce conflicts are now gone (except the one we inherited
10671 2004-06-11 Martin Baulig <martin@ximian.com>
10673 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10674 call this twice: for params and varargs methods.
10676 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10679 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10681 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10683 * attribute.cs (Attribute.GetValidTargets): Made public.
10686 (AbstractPropertyEventMethod): New class for better code sharing.
10687 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10689 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10691 2004-06-09 Martin Baulig <martin@ximian.com>
10693 * cs-parser.jay: Removed a reduce/reduce conflict.
10695 2004-06-03 Martin Baulig <martin@ximian.com>
10697 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10698 GetSimpleName() and return a SimpleName.
10700 * ecore.cs (SimpleName.Arguments): New public field.
10701 (SimpleName): Added overloaded ctor which takes an additional
10702 TypeArguments argument.
10703 (SimpleName.SimpleNameResolve): Added support for generic methods.
10704 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10705 formerly in MemberAccess.DoResolve(), but we also need it in
10706 SimpleNameResolve().
10708 * expression.cs (MemberAccess.DoResolve): Use the new
10709 MethodGroupExpr.ResolveGeneric().
10711 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10713 * decl.cs: If possible, use lookuptypedirect here. We can only do
10714 this if there is no `.' after the namespace. Avoids using
10715 LookupType, which does lots of slow processing.
10716 (FindNestedType) New method, does what it says :-).
10717 * namespace.cs: use LookupTypeDirect.
10718 * rootcontext.cs: use membercache, if possible.
10719 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10721 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10724 According to the spec,
10726 In a member access of the form E.I, if E is a single identifier,
10727 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10728 field, property, localvariable, or parameter with the same type as
10729 the meaning of E as a type-name (§3.8), then both possible
10730 meanings of E are permitted.
10732 We did not check that E as a simple-name had the same type as E as
10735 This trivial check gives us 5-7% on bootstrap time.
10737 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10739 * expression.cs (Invocation.OverloadResolve): Avoid the
10740 use of hashtables and boxing here by allocating on demand.
10742 2004-05-30 Martin Baulig <martin@ximian.com>
10744 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10745 we're doing a silent lookup. Don't try to lookup nested types in
10746 TypeManager.object_type (thanks to Ben Maurer).
10748 2004-05-30 Martin Baulig <martin@ximian.com>
10750 Committing a patch from Ben Maurer.
10752 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10754 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10756 * convert.cs: add a trivial cache for overload operator resolution.
10758 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10761 (AttributeTester.GetObsoleteAttribute): Returns instance of
10762 ObsoleteAttribute when type is obsolete.
10765 (TypeContainer.VerifyObsoleteAttribute): Override.
10766 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10767 (MethodCode.VerifyObsoleteAttribute): Override.
10768 (MemberBase.VerifyObsoleteAttribute): Override.
10771 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10772 and report proper error.
10775 (Delegate.VerifyObsoleteAttribute): Override.
10778 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10779 and report proper error.
10780 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10783 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10787 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10788 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10789 Added test for ObsoleteAttribute.
10792 (Catch): Derived from Statement.
10794 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10796 * decl.cs: If possible, use lookuptypedirect here. We can only do
10797 this if there is no `.' after the namespace. Avoids using
10798 LookupType, which does lots of slow processing.
10799 (FindNestedType) New method, does what it says :-).
10800 * namespace.cs: use LookupTypeDirect.
10801 * rootcontext.cs: use membercache, if possible.
10802 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10804 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10807 According to the spec,
10809 In a member access of the form E.I, if E is a single identifier,
10810 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10811 field, property, localvariable, or parameter with the same type as
10812 the meaning of E as a type-name (§3.8), then both possible
10813 meanings of E are permitted.
10815 We did not check that E as a simple-name had the same type as E as
10818 This trivial check gives us 5-7% on bootstrap time.
10820 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10822 Fixed bug #59071 & cs0160.cs
10823 * statement.cs (Try.Resolve): Check here whether order of catch
10824 clauses matches their dependencies.
10826 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10829 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10832 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10834 * expression.cs (Invocation.OverloadResolve): Avoid the
10835 use of hashtables and boxing here by allocating on demand.
10837 2004-05-30 Martin Baulig <martin@ximian.com>
10839 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10840 we're doing a silent lookup. Don't try to lookup nested types in
10841 TypeManager.object_type (thanks to Ben Maurer).
10843 2004-05-30 Martin Baulig <martin@ximian.com>
10845 Committing a patch from Ben Maurer.
10847 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10849 2004-05-29 Martin Baulig <martin@ximian.com>
10851 * class.cs (IMethodData.ShouldIgnore): New method.
10853 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10854 `Location' argument, we don't need it anywhere. Use
10855 `IMethodData.ShouldIgnore ()' instead of
10856 `MethodData.GetMethodFlags ()'.
10857 (TypeManager.AddMethod): Removed.
10858 (TypeManager.AddMethod2): Renamed to AddMethod.
10860 2004-05-29 Martin Baulig <martin@ximian.com>
10862 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10864 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10865 converting from a class type S to an interface type and we already
10866 have an object on the stack, don't box it again. Fixes #52578.
10868 2004-05-29 Martin Baulig <martin@ximian.com>
10870 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10871 Added support for `params' parameters. Fixes #59267.
10873 2004-05-29 Martin Baulig <martin@ximian.com>
10875 * literal.cs (NullPointer): Provide a private .ctor which sets
10876 `type' to TypeManager.object_type. Fixes #59048.
10878 2004-05-29 Martin Baulig <martin@ximian.com>
10880 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10881 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10883 * ecore.cs (EventExpr.instance_expr): Make the field private.
10885 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10887 Fixed bug #50080 & cs0214-2.cs
10888 * expression.cs (Cast.DoResolve): Check unsafe context here.
10890 * statement.cs (Resolve.DoResolve): Likewise.
10892 2004-05-26 Martin Baulig <martin@ximian.com>
10894 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
10896 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
10897 (RootContext.LookupType): Pass down the `silent' flag.
10899 2004-05-25 Martin Baulig <martin@ximian.com>
10902 (MethodGroupExpr.IdenticalTypeName): New public property.
10903 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
10904 expression actually refers to a type.
10906 2004-05-25 Martin Baulig <martin@ximian.com>
10908 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
10909 for #56176 and made it actually work.
10911 2004-05-25 Martin Baulig <martin@ximian.com>
10913 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
10914 (FieldExpr, PropertyExpr): Override and implement
10915 CacheTemporaries. Fixes #52279.
10917 2004-05-25 Miguel de Icaza <miguel@ximian.com>
10919 * location.cs: In the new compiler listing a file twice is a
10920 warning, not an error.
10922 2004-05-24 Martin Baulig <martin@ximian.com>
10924 * enum.cs (Enum.DefineType): For the `BaseType' to be a
10925 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
10927 2004-05-24 Martin Baulig <martin@ximian.com>
10929 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
10930 walking the `using' list. Fixes #53921.
10932 2004-05-24 Martin Baulig <martin@ximian.com>
10934 * const.cs (Const.LookupConstantValue): Added support for
10935 EmptyCast's; fixes #55251.
10937 2004-05-24 Martin Baulig <martin@ximian.com>
10939 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
10940 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
10941 which does the CS0135 check. The reason is that we first need to
10942 check whether the variable actually exists.
10944 2004-05-24 Martin Baulig <martin@ximian.com>
10946 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
10947 than RootContext.LookupType() to find the explicit interface
10948 type. Fixes #58584.
10950 2004-05-24 Raja R Harinath <rharinath@novell.com>
10952 * Makefile: Simplify. Use executable.make.
10953 * mcs.exe.sources: New file. List of sources of mcs.exe.
10955 2004-05-24 Anders Carlsson <andersca@gnome.org>
10959 Use the invariant culture when doing String.Compare for CLS case
10962 2004-05-23 Martin Baulig <martin@ximian.com>
10964 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
10965 don't have any dots. Fixes #52622, added cs0246-8.cs.
10967 * namespace.cs (NamespaceEntry.Lookup): Likewise.
10969 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10971 * class.cs (MemberBase.Define): Reuse MemberType member for
10972 resolved type. Other methods can use it too.
10974 2004-05-23 Martin Baulig <martin@ximian.com>
10976 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
10977 the variable also exists in the current block (otherwise, we need
10978 to report a CS0103). Fixes #58670.
10980 2004-05-23 Martin Baulig <martin@ximian.com>
10982 * flowanalysis.cs (Reachability.Reachable): Compute this
10983 on-the-fly rather than storing it as a field.
10985 2004-05-23 Martin Baulig <martin@ximian.com>
10987 * flowanalysis.cs (Reachability.And): Manually compute the
10988 resulting `barrier' from the reachability.
10990 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10993 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
10994 instance of ObsoleteAttribute when symbol is obsolete.
10997 (IMethodData): Extended interface for ObsoleteAttribute support.
10999 2004-05-22 Marek Safar <marek.safar@seznam.cz>
11001 * attribute.cs: Fix bug #55970
11003 2004-05-22 Marek Safar <marek.safar@seznam.cz>
11007 (GetObsoleteAttribute): New method. Creates the instance of
11009 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
11010 ObsoleteAttribute when member is obsolete.
11011 (AttributeTester.Report_ObsoleteMessage): Common method for
11012 Obsolete error/warning reporting.
11015 (TypeContainer.base_classs_type): New member for storing parent type.
11018 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
11019 for this MemberCore.
11021 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11023 * attribute.cs, const.cs: Fix bug #58590
11025 2004-05-21 Martin Baulig <martin@ximian.com>
11027 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
11028 out parameters if the end of the method is unreachable. Fixes
11031 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11033 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
11034 Hari was right, why extra method.
11036 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11038 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
11040 2004-05-20 Martin Baulig <martin@ximian.com>
11042 * delegate.cs: Convert this file to Unix mode - like the original
11045 2004-05-20 Martin Baulig <martin@ximian.com>
11047 * attribute.cs: Convert this file to Unix mode - like the original
11050 2004-05-19 Marek Safar <marek.safar@seznam.cz>
11052 Fix bug #58688 (MCS does not report error when the same attribute
11055 * attribute.cs (Attribute.Emit): Distinction between null and default.
11057 2004-05-19 Raja R Harinath <rharinath@novell.com>
11059 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
11060 of a top-level attribute without an attribute target.
11061 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
11063 (Attribute.Conditional_GetConditionName),
11064 (Attribute.Obsolete_GetObsoleteMessage): Update.
11065 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
11066 part of ScanForIndexerName.
11067 (Attribute.CanIgnoreInvalidAttribute): New function.
11068 (Attribute.ScanForIndexerName): Move to ...
11069 (Attributes.ScanForIndexerName): ... here.
11070 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
11071 (Attributes.Search): New internal variant that can choose not to
11072 complain if types aren't resolved. The original signature now
11074 (Attributes.GetClsCompliantAttribute): Use internal variant, with
11075 complaints suppressed.
11076 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
11077 only if it not useful.
11078 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
11079 top-level for attributes that are shared between the assembly
11080 and a top-level class.
11081 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
11082 * class.cs: Update to reflect changes.
11083 (DefineIndexers): Fuse loops.
11084 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
11085 a couple more variants of attribute names.
11087 2004-05-18 Marek Safar <marek.safar@seznam.cz>
11089 Fix bug #52585 (Implemented explicit attribute declaration)
11092 (Attributable.ValidAttributeTargets): New abstract method. It gets
11093 list of valid attribute targets for explicit target declaration.
11094 (Attribute.Target): It holds target itself.
11095 (AttributeSection): Removed.
11096 (Attribute.CheckTargets): New method. It checks whether attribute
11097 target is valid for the current element.
11100 (EventProperty): New class. For events that are declared like
11101 property (with add and remove accessors).
11102 (EventField): New class. For events that are declared like field.
11105 * cs-parser.jay: Implemented explicit attribute target declaration.
11107 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
11108 Override ValidAttributeTargets.
11111 (ReturnParameter): Class for applying custom attributes on
11113 (ParameterAtribute): New class. Class for applying custom
11114 attributes on the parameter type.
11116 2004-05-17 Miguel de Icaza <miguel@ximian.com>
11118 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
11121 (Method): Allow UNSAFE here.
11123 * modifiers.cs: Support unsafe reporting.
11125 2004-05-17 Marek Safar <marek.safar@seznam.cz>
11127 * decl.cs: Fix bug #58478.
11129 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11131 * statement.cs: When checking for unreachable code on an EmptyStatement,
11132 set the location. Fixes bug #58488.
11134 2004-05-13 Miguel de Icaza <miguel@ximian.com>
11136 * driver.cs: Add -pkg handling.
11138 From Gonzalo: UseShelLExecute=false
11140 2004-05-12 Marek Safar <marek.safar@seznam.cz>
11143 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
11145 (Attribute.IsClsCompliaceRequired): Moved to base for better
11147 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
11148 when attribute is AttributeUsageAttribute.
11149 (Attribute.GetValidTargets): Simplified.
11150 (Attribute.GetAttributeUsage): New method returns AttributeUsage
11151 attribute for this type.
11152 (Attribute.ApplyAttributes): Method renamed to Emit and make
11154 (GlobalAttributeSection): New class for special handling of global
11155 attributes (assembly, module).
11156 (AttributeSection.Emit): New method.
11158 * class.cs: Implemented Attributable abstract methods.
11159 (MethodCore.LabelParameters): Moved to Parameter class.
11160 (Accessor): Is back simple class.
11161 (PropertyMethod): Implemented Attributable abstract class.
11162 (DelegateMethod): Implemented Attributable abstract class.
11163 (Event): New constructor for disctintion between normal Event
11164 and Event with accessors.
11166 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
11168 * codegen.cs, const.cs, decl.cs, delegate.cs:
11169 (CommonAssemblyModulClass): Implemented Attributable abstract class
11172 * enum.cs: Implement IAttributeSupport interface.
11173 (EnumMember): New class for emum members. Implemented Attributable
11177 (ParameterBase): Is abstract.
11178 (ReturnParameter): New class for easier [return:] attribute handling.
11180 * typemanager.cs: Removed builder_to_attr.
11182 2004-05-11 Raja R Harinath <rharinath@novell.com>
11185 * attribute.cs (Attribute.GetPositionalValue): New function.
11186 * class.cs (TypeContainer.VerifyMembers): New function.
11187 (TypeContainer.Emit): Use it.
11188 (ClassOrStruct): New base class for Class and Struct.
11189 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
11190 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
11192 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
11193 then each non-static field should have a FieldOffset attribute.
11194 Otherwise, none of the fields should have a FieldOffset attribute.
11195 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
11196 and FieldOffset attributes.
11197 * typemanager.cs (TypeManager.struct_layout_attribute_type)
11198 (TypeManager.field_offset_attribute_type): New core types.
11199 (TypeManager.InitCoreTypes): Initialize them.
11201 2004-05-11 Michal Moskal <malekith@pld-linux.org>
11203 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
11204 Return correct type.
11207 2004-05-09 Miguel de Icaza <miguel@ximian.com>
11209 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
11210 be implicitly converted to ulong.
11212 * expression.cs: The logic for allowing operator &, | and ^ worked
11213 was wrong, it worked before because we did not report an error in
11214 an else branch. Fixes 57895.
11216 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
11217 allow volatile fields to be reference types.
11219 2004-05-07 Miguel de Icaza <miguel@ximian.com>
11221 * driver.cs: Add support for /debug-
11223 2004-05-07 Raja R Harinath <rharinath@novell.com>
11225 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
11226 Add a 'complain' parameter to silence errors.
11227 (Attribute.Resolve): Update to changes. Put in sanity check to catch
11228 silently overlooked type-resolutions.
11229 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
11230 to reflect changes.
11231 (Attributes.Search): New function.
11232 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
11233 (Attributes.GetAttributeFullName): Remove hack.
11234 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
11235 Update to reflect changes.
11236 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11237 Use Attributes.Search instead of nested loops.
11239 2004-05-07 Marek Safar <marek.safar@seznam.cz>
11242 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
11243 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
11244 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
11246 * report.cs: (Report.Warning): Renamed to Warning_T because of
11247 parameter collision.
11249 2004-05-05 Raja R Harinath <rharinath@novell.com>
11251 * expression.cs (MemberAccess.ResolveMemberAccess):
11252 Exit with non-zero status after Report.Error.
11253 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
11255 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
11257 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11259 * support.cs: Don't hang when the file is empty.
11261 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11263 * support.cs: In SeekableStreamReader, compute the preamble size of the
11264 underlying stream. Position changes should take into account that initial
11267 2004-05-03 Todd Berman <tberman@sevenl.net>
11269 * driver.cs: remove unused GetSysVersion function.
11271 2004-05-03 Todd Berman <tberman@sevenl.net>
11273 * driver.cs: Remove the hack from saturday, as well as the hack
11274 from jackson (LoadAssemblyFromGac), also adds the CWD to the
11275 link_paths to get that bit proper.
11277 2004-05-01 Todd Berman <tberman@sevenl.net>
11279 * driver.cs: Try a LoadFrom before a Load, this checks the current
11280 path. This is currently a bug in mono that is be fixed, however, this
11281 provides a workaround for now. This will be removed when the bug
11284 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11286 * CryptoConvert.cs: Updated to latest version. Fix issue with
11287 incomplete key pairs (#57941).
11289 2004-05-01 Todd Berman <tberman@sevenl.net>
11291 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11294 2004-04-30 Jackson Harper <jackson@ximian.com>
11296 * codegen.cs: Open keys readonly.
11298 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11300 * typemanager.cs: don't report cyclic struct layout when a struct
11301 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11302 which has 2 Pango.Rectangle fields.
11304 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11306 * expression.cs: Handle IntPtr comparisons with IL code
11307 rather than a method call.
11309 2004-04-29 Martin Baulig <martin@ximian.com>
11311 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11312 the list of PropertyInfo's in class hierarchy and find the
11313 accessor. Fixes #56013.
11315 2004-04-29 Martin Baulig <martin@ximian.com>
11317 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11319 2004-04-29 Martin Baulig <martin@ximian.com>
11321 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11323 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11325 2004-04-29 Martin Baulig <martin@ximian.com>
11327 * class.cs (ConstructorInitializer.Resolve): Check whether the
11328 parent .ctor is accessible. Fixes #52146.
11330 2004-04-29 Martin Baulig <martin@ximian.com>
11332 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11334 * statement.cs (Using.EmitLocalVariableDecls): Use
11335 TypeManager.idisposable_type, not typeof (IDisposable).
11336 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11338 2004-04-29 Martin Baulig <martin@ximian.com>
11340 * class.cs (Event.Define): Don't emit the field and don't set
11341 RTSpecialName and SpecialName for events on interfaces. Fixes
11344 2004-04-29 Raja R Harinath <rharinath@novell.com>
11346 Refactor Attribute.ApplyAttributes.
11347 * attribute.cs (Attributable): New base class for objects that can
11348 have Attributes applied on them.
11349 (Attribute): Make AttributeUsage fields public.
11350 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11351 (Attribute.IsInternalCall): New property.
11352 (Attribute.UsageAttr): Convert to a public read-only property.
11353 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11354 (Attribute.ResolveType, Attribute.Resolve)
11355 (Attribute.ScanForIndexerName): Update to reflect changes.
11356 (Attribute.CheckAttributeTarget): Re-format.
11357 (Attribute.ApplyAttributes): Refactor, to various
11358 Attributable.ApplyAttributeBuilder methods.
11359 * decl.cs (MemberCore): Make Attributable.
11360 * class.cs (Accessor): Make Attributable.
11361 (MethodData.ApplyAttributes): Use proper attribute types, not
11363 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11364 (TypeContainer.ApplyAttributeBuilder)
11365 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11366 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11367 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11368 (Operator.ApplyAttributeBuilder): New factored-out methods.
11369 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11370 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11371 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11372 * parameter.cs (ParameterBase): New Attributable base class
11373 that can also represent Return types.
11374 (Parameter): Update to the changes.
11376 2004-04-29 Jackson Harper <jackson@ximian.com>
11378 * driver.cs: Prefer the corlib system version when looking for
11379 assemblies in the GAC. This is still a hack, but its a better hack
11382 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11384 * decl.cs, enum.cs: Improved error 3005 reporting.
11386 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11387 (related_symbols): New private member for list of symbols
11388 related to reported error/warning.
11390 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11392 2004-04-29 Martin Baulig <martin@ximian.com>
11394 * ecore.cs (Expression.Constantify): If we're an enum and
11395 TypeManager.TypeToCoreType() doesn't give us another type, use
11396 t.UnderlyingSystemType. Fixes #56178.
11398 2004-04-29 Martin Baulig <martin@ximian.com>
11400 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11401 interfaces and for each interface, only add members directly
11402 declared in that interface. Fixes #53255.
11404 2004-04-28 Martin Baulig <martin@ximian.com>
11406 * expression.cs (ConditionalLogicalOperator): Use a temporary
11407 variable for `left' to avoid that we evaluate it more than once;
11410 2004-04-28 Martin Baulig <martin@ximian.com>
11412 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11415 2004-04-28 Martin Baulig <martin@ximian.com>
11417 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11420 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11421 whether the type is not void (CS1547).
11423 2004-04-28 Martin Baulig <martin@ximian.com>
11425 * expression.cs (Unary.DoResolveLValue): Override this and report
11426 CS0131 for anything but Operator.Indirection.
11428 2004-04-28 Martin Baulig <martin@ximian.com>
11430 Committing a patch from Ben Maurer; see bug #50820.
11432 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11435 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11438 2004-04-28 Martin Baulig <martin@ximian.com>
11440 Committing a patch from Ben Maurer; see bug #50820.
11442 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11445 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11448 2004-04-28 Martin Baulig <martin@ximian.com>
11450 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11451 (Block.AddLabel): Call DoLookupLabel() to only search in the
11454 2004-04-28 Martin Baulig <martin@ximian.com>
11456 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11457 comparing StringConstants and NullLiterals in Equality and Inequality.
11459 2004-04-28 Jackson Harper <jackson@ximian.com>
11461 * driver.cs: Attempt to load referenced assemblies from the
11462 GAC. This is the quick and dirty version of this method that
11463 doesnt take into account versions and just takes the first
11464 canidate found. Will be good enough for now as we will not have more
11465 then one version installed into the GAC until I update this method.
11467 2004-04-28 Martin Baulig <martin@ximian.com>
11469 * typemanager.cs (TypeManager.CheckStructCycles): New public
11470 static method to check for cycles in the struct layout.
11472 * rootcontext.cs (RootContext.PopulateTypes): Call
11473 TypeManager.CheckStructCycles() for each TypeContainer.
11474 [Note: We only need to visit each type once.]
11476 2004-04-28 Martin Baulig <martin@ximian.com>
11478 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11480 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11481 success and added `out object value'. Use a `bool resolved' field
11482 to check whether we've already been called rather than
11483 `ConstantValue != null' since this breaks for NullLiterals.
11485 2004-04-28 Raja R Harinath <rharinath@novell.com>
11487 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11488 setting of this flag, since the 'set' method may be non-public.
11490 2004-04-28 Raja R Harinath <rharinath@novell.com>
11492 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11493 check on current_vector.Block.
11495 2004-04-27 Martin Baulig <martin@ximian.com>
11497 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11498 a field initializer. Fixes #56459.
11500 2004-04-27 Martin Baulig <martin@ximian.com>
11502 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11503 we're not attempting to use an indexer. Fixes #52154.
11505 2004-04-27 Martin Baulig <martin@ximian.com>
11507 * statement.cs (Return): Don't create a return label if we don't
11508 need it; reverts my change from January 20th. Thanks to Ben
11511 2004-04-27 Martin Baulig <martin@ximian.com>
11513 According to the spec, `goto' can only leave a nested scope, but
11516 * statement.cs (Block.LookupLabel): Only lookup in the current
11517 block, don't recurse into parent or child blocks.
11518 (Block.AddLabel): Check in parent and child blocks, report
11519 CS0140/CS0158 if we find a duplicate.
11520 (Block): Removed this indexer for label lookups.
11521 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11522 this already does the error reporting for us.
11525 (FlowBranching.UsageVector.Block): New public variable; may be null.
11526 (FlowBranching.CreateSibling): Added `Block' argument.
11527 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11528 label for the target of a `goto' and check whether we're not
11529 leaving a `finally'.
11531 2004-04-27 Martin Baulig <martin@ximian.com>
11533 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11534 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11537 2004-04-27 Martin Baulig <martin@ximian.com>
11539 * statement.cs (Block.AddLabel): Also check for implicit blocks
11540 and added a CS0158 check.
11542 2004-04-27 Martin Baulig <martin@ximian.com>
11544 * flowanalysis.cs (FlowBranchingLoop): New class.
11545 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11546 UsageVector's instead of an ArrayList.
11547 (FlowBranching.Label): Likewise.
11548 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11549 (FlowBranching.AddBreakVector): New method.
11551 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11553 * attribute.cs: Small regression fix: only convert the type if we
11554 the type is different, fixes System.Drawing build.
11556 2004-04-27 Martin Baulig <martin@ximian.com>
11558 * attribute.cs (Attribute.Resolve): If we have a constant value
11559 for a named field or property, implicity convert it to the correct
11562 2004-04-27 Raja R Harinath <rharinath@novell.com>
11564 * statement.cs (Block.Block): Implicit blocks share
11565 'child_variable_names' fields with parent blocks.
11566 (Block.AddChildVariableNames): Remove.
11567 (Block.AddVariable): Mark variable as "used by a child block" in
11568 every surrounding block.
11569 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11570 been used in a child block, complain about violation of "Invariant
11571 meaning in blocks" rule.
11572 * cs-parser.jay (declare_local_variables): Don't use
11573 AddChildVariableNames.
11574 (foreach_statement): Don't create an implicit block: 'foreach'
11575 introduces a scope.
11577 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11579 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11580 converting from 0L to ulong. Fixes 57522.
11582 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11584 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11585 derived class hides via 'new' keyword field from base class (test-242.cs).
11586 TODO: Handle this in the more general way.
11588 * class.cs (CheckBase): Ditto.
11590 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11592 * decl.cs (caching_flags): New member for storing cached values
11594 (MemberCore.Flags): New enum where bit flags for caching_flags
11596 (MemberCore.cls_compliance): Moved to caching_flags.
11597 (DeclSpace.Created): Moved to caching_flags.
11599 * class.cs: Use caching_flags instead of DeclSpace.Created
11601 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11603 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11604 if we are only a derived class, not a nested class.
11606 * typemanager.cs: Same as above, but do this at the MemberLookup
11607 level (used by field and methods, properties are handled in
11608 PropertyExpr). Allow for the qualified access if we are a nested
11611 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11613 * class.cs: Refactoring.
11614 (IMethodData): New inteface; Holds links to parent members
11615 to avoid member duplication (reduced memory allocation).
11616 (Method): Implemented IMethodData interface.
11617 (PropertyBase): New inner classes for get/set methods.
11618 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11619 (Event): New inner classes for add/remove methods.
11620 (Event.DelegateMethod): Implemented IMethodData interface.
11622 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11623 EmitContext (related to class.cs refactoring).
11625 2004-04-21 Raja R Harinath <rharinath@novell.com>
11627 * delegate.cs (Delegate.VerifyApplicability): If the number of
11628 arguments are the same as the number of parameters, first try to
11629 verify applicability ignoring any 'params' modifier on the last
11633 2004-04-08 Martin Baulig <martin@ximian.com>
11635 Merged latest changes into gmcs. Please keep this comment in
11636 here, it makes it easier for me to see what changed in MCS since
11637 the last time I merged.
11639 2004-04-16 Raja R Harinath <rharinath@novell.com>
11641 * class.cs (TypeContainer.AddIndexer): Use
11642 'ExplicitInterfaceName' to determine if interface name was
11643 explicitly specified. 'InterfaceType' is not initialized at this time.
11644 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11645 Indexers array is already in the required order. Initialize
11646 'IndexerName' only if there are normal indexers.
11647 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11648 (TypeContainer.Emit): Emit DefaultMember attribute only if
11649 IndexerName is initialized.
11652 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11654 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11657 2004-04-15 Raja R Harinath <rharinath@novell.com>
11659 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11663 * attribute.cs (Attribute.Resolve): Check for duplicate named
11667 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11669 * iterators.cs (MarkYield): track whether we are in an exception,
11670 and generate code accordingly. Use a temporary value to store the
11671 result for our state.
11673 I had ignored a bit the interaction of try/catch with iterators
11674 since their behavior was not entirely obvious, but now it is
11675 possible to verify that our behavior is the same as MS .NET 2.0
11679 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11681 * iterators.cs: Avoid creating temporaries if there is no work to
11684 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11685 Enumerations, use TypeManager.EnumToUnderlying and call
11688 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11691 (This.Emit): Use EmitContext.EmitThis to emit our
11694 (This.EmitAssign): Ditto.
11696 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11697 codepaths, we will move all the functionality into
11700 (FieldExpr.EmitAssign): Ditto.
11702 This fixes several hidden bugs that I uncovered while doing a code
11703 review of this today.
11705 * codegen.cs (EmitThis): reworked so the semantics are more clear
11706 and also support value types "this" instances.
11708 * iterators.cs: Changed so that for iterators in value types, we
11709 do not pass the value type as a parameter.
11711 Initialization of the enumerator helpers is now done in the caller
11712 instead of passing the parameters to the constructors and having
11713 the constructor set the fields.
11715 The fields have now `assembly' visibility instead of private.
11717 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11719 * expression.cs (Argument.Resolve): Check if fields passed as ref
11720 or out are contained in a MarshalByRefObject.
11722 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11723 another compiler type.
11725 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11727 * class.cs (Indexer.Define): use the new name checking method.
11728 Also, return false on an error.
11729 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11730 (is_identifier_[start/part]_character): make static.
11732 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11734 * expression.cs (Binary.ResolveOperator): Do no append strings
11735 twice: since we can be invoked more than once (array evaluation)
11736 on the same concatenation, take care of this here. Based on a fix
11737 from Ben (bug #56454)
11739 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11741 * codegen.cs: Fix another case where CS1548 must be reported (when
11742 delay-sign isn't specified and no private is available #56564). Fix
11743 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11744 error when MCS is used on the MS runtime and we need to delay-sign
11745 (which seems unsupported by AssemblyBuilder - see #56621).
11747 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11749 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11750 (TypeManager.ComputeNamespaces): Faster implementation for
11753 * compiler.csproj: Updated AssemblyName to mcs.
11755 2004-05-11 Jackson Harper <jackson@ximian.com>
11757 * Makefile: Preserve MONO_PATH
11759 2004-05-11 Jackson Harper <jackson@ximian.com>
11761 * Makefile: Use mono and mcs to build gmcs
11763 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11765 * codegen.cs: Add patch from Robert Shade
11766 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11769 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11771 * CryptoConvert.cs: Updated to latest version. Fix issue with
11772 incomplete key pairs (#57941).
11774 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11776 * codegen.cs: Fix another case where CS1548 must be reported (when
11777 delay-sign isn't specified and no private is available #56564). Fix
11778 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11779 error when MCS is used on the MS runtime and we need to delay-sign
11780 (which seems unsupported by AssemblyBuilder - see #56621).
11782 2004-04-29 Jackson Harper <jackson@ximian.com>
11784 * Makefile: Set MONO_PATH to use the bootstrap corlib
11785 * driver.cs: Check the GAC for referenced assemblies.
11787 2004-04-29 Martin Baulig <martin@ximian.com>
11789 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11791 2004-04-07 Martin Baulig <martin@ximian.com>
11793 * expression.cs (Binary.ResolveOperator): Added special case for
11794 Equality/Inequality between a type parameter and a null literal.
11796 2004-04-07 Martin Baulig <martin@ximian.com>
11798 * convert.cs: Check null literal -> type parameter conversions.
11800 2004-04-07 Martin Baulig <martin@ximian.com>
11802 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11803 `class' and `struct' constraints.
11805 2004-04-07 Martin Baulig <martin@ximian.com>
11807 * generic.cs (SpecialConstraint): New public enum.
11808 (Constraints.Resolve): Added support for the `class' and `struct'
11811 * cs-parser.jay (type_parameter_constraint): Added support for the
11812 `class' and `struct' constraints.
11814 2004-04-07 Martin Baulig <martin@ximian.com>
11816 * support.cs (GenericConstraints): Replaced `Types' by
11817 `ClassConstraint' and `InterfaceConstraints'; added
11818 `HasClassConstraint'.
11820 2004-04-07 Martin Baulig <martin@ximian.com>
11823 (Constraints.InterfaceConstraints): New public property.
11824 (Constraints.Types): Make this property public
11825 (TypeParameter): Implement IMemberContainer.
11826 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11827 instead of a TypeBuilder/MethodBuilder; pass the interface
11828 constraints to TypeManager.AddTypeParameter().
11829 (TypeParameter.DefineType): Just take an EmitContext and no
11830 TypeBuilder/MethodBuilder. Use the new public API.
11832 * typemanager.cs (TypeManager.AddTypeParameter): Added
11833 `TypeExpr[]' argument; add the interfaces to the
11834 `builder_to_ifaces' hash.
11835 (TypeManager.LookupMemberContainer): For
11836 GenericTypeParameterBuilders, get the TypeParameter from the
11837 `builder_to_type_param'.
11838 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11839 the TypeParameter and call FindMembers on it.
11841 2004-04-07 Martin Baulig <martin@ximian.com>
11844 (MethodCore.GenericMethod): Moved this field here from Method.
11845 (MethodCore.IsDuplicateImplementation): Take the number of type
11846 parameters into account if we're a generic method.
11848 * expression.cs (Invocation.InferTypeArguments): Don't return true
11849 if `arguments' is null; we still need to check whether we actually
11850 don't need to infer anything in this case.
11851 (MemberAccess): Merged the functionality from GenericMemberAccess
11854 * generic.cs (GenericMemberAccess): Removed.
11856 2004-04-05 Martin Baulig <martin@ximian.com>
11858 * decl.cs (MemberCore): For generic classes, interfaces and
11859 structs, `Name' now includes the number of type parameters
11860 ("Stack!1.Node!1").
11861 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11862 encode the number of type arguments in the type name.
11864 * expression.cs (Expression.MemberLookup): Removed the
11865 `num_type_args' argument; we now encode the number of type
11866 arguments in the type name.
11868 * ecore.cs (SimpleName): Encode the number of type arguments in
11869 the type name itself.
11871 * generic.cs (ConstructedType): Likewise.
11873 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11874 `MemberName'; we now include the number of type parameters in the
11877 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11878 (TypeManager.MemberLookup): Removed the
11879 `num_type_args' argument; we now encode the number of type
11880 arguments in the type name.
11882 2004-04-03 Martin Baulig <martin@ximian.com>
11884 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11885 (MemberCore.MemberName): Moved here from MemberBase.
11886 (DeclSpace.SetParameterInfo): Just take the constraints as an
11887 ArrayList; we already have the type parameters in our
11888 `MemberName'; also do the CS0080 reporting here.
11890 * cs-parser.jay (struct_declaration): Use `member_name' instead of
11891 `IDENTIFIER opt_type_parameter_list'; when constructing our
11892 `MemberName', it'll already include our type parameters.
11893 (class_declaration, interface_declaration): Likewise.
11894 (delegate_declaration): Likewise.
11895 (MakeName): Take a MemberName and return a MemberName.
11896 The following two changes are required to avoid shift/reduce conflicts:
11897 (member_name): Don't include a TypeName anymore; ie. this is now
11898 just 'IDENTIFIER opt_type_parameter_list'.
11899 (property_declaration, event_declaration): Use a
11900 `namespace_or_type_name' instead of a `member_name'.
11902 2004-04-03 Martin Baulig <martin@ximian.com>
11904 * decl.cs (MemberName): Renamed to `TypeName' and created a new
11905 `MemberName' class.
11906 (TypeName): Formerly known as MemberName.
11908 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
11909 instead of a `MemberName'.
11911 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
11912 (member_name): New rule; create a MemberName.
11914 2004-04-02 Martin Baulig <martin@ximian.com>
11916 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
11917 (CS0305 and CS0308).
11919 2004-04-02 Martin Baulig <martin@ximian.com>
11921 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
11922 support for nested types.
11924 2004-04-02 Martin Baulig <martin@ximian.com>
11926 * ecore.cs (IAlias): New public interface.
11927 (TypeExpr, TypeExpression): Implement IAlias.
11928 (TypeAliasExpression): New public class.
11930 * namespace.cs (Namespace): Implement IAlias.
11931 (Namespace.Lookup): Return an IAlias instead on an object.
11932 (Namespace.DefineName): Take an IAlias instead of an object.
11933 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
11935 (NamespaceEntry.UsingAlias): Take a Membername instead of an
11937 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
11939 (NamespaceEntry.Lookup): Likewise.
11941 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
11944 * decl.cs (DeclSpace): Implement IAlias.
11945 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
11947 * generic.cs (ConstructedType): Improved error checking.
11949 2004-04-02 Martin Baulig <martin@ximian.com>
11951 * convert.cs: Added type parameter conversions.
11954 (UnboxCast.Emit): Emit an `unbox.any' for type params.
11955 (ClassCast.Emit): If the source type is a type parameter, box it.
11956 If the target type is a type parameter, emit an `unbox.any'
11957 instead of a `classcast'.1
11959 2004-04-01 Martin Baulig <martin@ximian.com>
11961 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
11963 2004-04-01 Martin Baulig <martin@ximian.com>
11965 * generic.cs (ConstructedType.CheckConstraints): Use
11966 Convert.ImplicitStandardConversionExists(); user-defined implicit
11967 conversions are not allowed according to the spec.
11969 2004-03-30 Martin Baulig <martin@ximian.com>
11971 * expression.cs (New): Added support for type parameters.
11974 (TypeManager.activator_type): New public static field.
11975 (TypeManager.activator_create_instance): Likewise.
11977 2004-03-30 Martin Baulig <martin@ximian.com>
11979 * typemanager.cs (TypeManager.HasConstructorConstraint): New
11982 2004-03-30 Martin Baulig <martin@ximian.com>
11984 * generic.cs (ConstructedType.CheckConstraints): Actually follow
11985 the spec here: the argument type must be convertible to the
11988 2004-03-30 Martin Baulig <martin@ximian.com>
11991 (TypeParameter.Define, TypeParameter.DefineMethod): Call
11992 TypeManager.AddTypeParameter().
11993 (ConstructedType.CheckConstraints): Re-enable this and actually
11994 check whether we have a constructor constraint.
11997 (TypeManager.builder_to_type_param): New static field.
11998 (TypeManager.AddTypeParameter): New static method.
11999 (TypeManager.LookupTypeParameter): New public method.
12001 2004-03-30 Martin Baulig <martin@ximian.com>
12003 * generic.cs (TypeParameter.DefineType): Return a boolean and use
12004 the new API to actually define the constructor constraint.
12007 (TypeManager.new_constraint_attr_type): New static field.
12008 (TypeManager.InitCoreTypes): Initialize it.
12010 2004-03-30 Martin Baulig <martin@ximian.com>
12012 * generic.cs (Constraints): Completed error checking, use correct
12015 2004-03-29 Martin Baulig <martin@ximian.com>
12017 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
12019 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12020 public version which takes a `ParameterData pd' instead of an
12023 2004-03-29 Martin Baulig <martin@ximian.com>
12025 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
12028 2004-03-29 Martin Baulig <martin@ximian.com>
12030 * expression.cs (Argument.ResolveMethodGroup): If we're a
12031 ConstructedType, call GetMemberAccess() on it.
12033 2004-03-29 Martin Baulig <martin@ximian.com>
12035 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
12036 (MethodCore.CheckGenericOverride): When overriding a generic
12037 method, check whether the constraints match.
12039 * support.cs (GenericConstraints): New public interface.
12040 (ParameterData.GenericConstraints): New public method.
12042 * parameter.cs (Parameter.Resolve): Check whether we're a generic
12043 method parameter and compute our constraints if appropriate.
12044 (Parameter.GenericConstraints): New public property.
12046 * generic.cs (Constraints): Implement GenericConstraints.
12048 2004-03-29 Martin Baulig <martin@ximian.com>
12050 * decl.cs (MemberCache.FindMemberToOverride): Use
12051 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
12053 2004-03-29 Martin Baulig <martin@ximian.com>
12055 * generic.cs (GenericMethod.Define): Resolve our type parameters.
12057 2004-03-29 Martin Baulig <martin@ximian.com>
12059 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
12060 not allowed on non-generic declarations").
12062 2004-03-29 Martin Baulig <martin@ximian.com>
12064 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12065 public version of this method.
12067 * class.cs (MethodCore.IsDuplicateImplementation): Use
12068 Invocation.InferTypeArguments() to check this.
12070 2004-03-29 Martin Baulig <martin@ximian.com>
12072 * convert.cs: Use TypeManager.IsDelegateType() instead of
12073 comparing types correctly.
12075 2004-03-29 Martin Baulig <martin@ximian.com>
12077 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
12078 types directly to make it work for generic instances.
12080 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
12082 2004-03-29 Martin Baulig <martin@ximian.com>
12084 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
12085 support for arrays.
12087 2004-03-24 Martin Baulig <martin@ximian.com>
12089 * decl.cs (DeclSpace.FindType): Also use
12090 TypeManager.CheckGeneric() for types from the using clauses.
12092 2004-03-23 Martin Baulig <martin@ximian.com>
12094 * expression.cs (Invocation.OverloadResolve): Added `bool
12095 may_fail' argument and use it instead of the Location.IsNull() hack.
12097 2004-03-23 Martin Baulig <martin@ximian.com>
12099 * expression.cs (Invocation.InferType): Use correct type inference
12102 2004-03-23 Martin Baulig <martin@ximian.com>
12104 * ecore.cs (MethodGroupExpr.Name): Use
12105 TypeManager.CSharpSignature() instead of just the name.
12107 * expression.cs (Invocation.OverloadResolve): Provide better error
12109 (Invocation.DoResolve): OverloadResolve() never returns null
12110 without reporting an error, so removed the error -6 reporting here.
12112 2004-03-23 Martin Baulig <martin@ximian.com>
12114 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
12117 * cs-parser.jay (delegate_declaration): Support generic delegates.
12119 * delegate.cs: Support generic delegates.
12121 2004-03-22 Martin Baulig <martin@ximian.com>
12123 * expression.cs (Invocation.InferParamsTypeArguments): New static
12124 method; does type inference for params arguments.
12126 2004-03-21 Martin Baulig <martin@ximian.com>
12128 * typemanager.cs (TypeManager.IsGenericMethod): New public static
12129 method; checks whether a method is a generic method.
12131 * expression.cs (Invocation.InferTypeArguments): New static method;
12132 infer type arguments for generic method invocation.
12134 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
12135 property; we set this to true if we're resolving a generic method
12136 invocation and the user specified type arguments, ie. we're not
12137 doing type inference.
12139 2004-03-20 Martin Baulig <martin@ximian.com>
12141 * class.cs (MethodData.DeclaringType): New public property.
12142 (MethodData.Define): Set DeclaringType here.
12143 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
12144 instead of OperatorMethodBuilder.DeclaringType.
12146 2004-03-20 Martin Baulig <martin@ximian.com>
12148 * cs-tokenizer.cs (xtoken): Return a special
12149 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
12151 * cs-parser.jay (default_value_expression): Switch to the new
12154 2004-03-19 Martin Baulig <martin@ximian.com>
12156 * decl.cs (MemberName): New class. We use this to "construct"
12157 namespace_or_type_name's.
12159 * generics.cs (TypeArguments.GetDeclarations): New public method;
12160 returns the type arguments as a string[] and reports a CS0081 if
12161 one of them is not an identifier.
12163 * class.cs (MemberBase): The .ctor now takes the name as a
12164 MemberName instead of a string.
12165 (MemberBase.ExplicitInterfaceName): Changed type from string to
12167 (MemberBase.DoDefine): If we're an explicit implementation, the
12168 InterfaceType may be a generic instance.
12170 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
12171 (namespace_name): Call MemberName.GetName () to transform the
12172 MemberName into a string and ensure we don't have any type
12174 (type_name): Call MemberName.GetTypeExpression() to transfrom the
12175 MemberName into an expression.
12176 (method_header): Use namespace_or_type_name instead of member_name.
12178 2004-04-07 Miguel de Icaza <miguel@ximian.com>
12180 * rootcontext.cs: Add new types to the boot resolution.
12182 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
12183 MulticastDelegate is not allowed.
12185 * typemanager.cs: Add new types to lookup: System.TypedReference
12188 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
12189 check for TypedReference or ArgIterator, they are not allowed.
12191 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
12192 makes us properly catch 1510 in some conditions (see bug 56016 for
12195 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
12197 * CryptoConvert.cs: update from corlib version
12200 2004-04-05 Miguel de Icaza <miguel@ximian.com>
12202 * class.cs (Indexer.Define): Check indexername declaration
12204 2004-04-05 Marek Safar <marek.safar@seznam.cz>
12206 * attribute.cs (IsClsCompliant): Fixed problem with handling
12207 all three states (compliant, not-compliant, undetected).
12209 2004-03-30 Marek Safar <marek.safar@seznam.cz>
12211 * attribute.cs (Attribute): Location is now public.
12212 (Resolve): Store resolved arguments (pos_values) in attribute class.
12213 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
12214 (GetClsCompliantAttributeValue): New method that gets
12215 CLSCompliantAttribute value.
12216 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
12217 if exists else null.
12218 (AttributeTester): New class for CLS-Compliant verification routines.
12220 * class.cs (Emit): Add CLS-Compliant verification.
12221 (Method.GetSignatureForError): Implemented.
12222 (Constructor.GetSignatureForError): Implemented
12223 (Constructor.HasCompliantArgs): Returns if constructor has
12224 CLS-Compliant arguments.
12225 (Constructor.Emit): Override.
12226 (Construcor.IsIdentifierClsCompliant): New method; For constructors
12227 is needed to test only parameters.
12228 (FieldBase.GetSignatureForError): Implemented.
12229 (TypeContainer): New member for storing base interfaces.
12230 (TypeContainer.FindMembers): Search in base interfaces too.
12232 * codegen.cs (GetClsComplianceAttribute): New method that gets
12233 assembly or module CLSCompliantAttribute value.
12234 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
12236 (ModuleClass.Emit): Add error 3012 test.
12238 * const.cs (Emit): Override and call base for CLS-Compliant tests.
12240 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
12241 state for all decl types.
12242 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
12243 if CLS-Compliant tests are required.
12244 (IsClsCompliaceRequired): New method. Analyze whether code
12245 must be CLS-Compliant.
12246 (IsExposedFromAssembly): New method. Returns true when MemberCore
12247 is exposed from assembly.
12248 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
12249 value or gets cached value.
12250 (HasClsCompliantAttribute): New method. Returns true if MemberCore
12251 is explicitly marked with CLSCompliantAttribute.
12252 (IsIdentifierClsCompliant): New abstract method. This method is
12253 used to testing error 3005.
12254 (IsIdentifierAndParamClsCompliant): New method. Common helper method
12255 for identifier and parameters CLS-Compliant testing.
12256 (VerifyClsCompliance): New method. The main virtual method for
12257 CLS-Compliant verifications.
12258 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
12259 null. I don't know why is null (too many public members !).
12260 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
12261 and get value of first CLSCompliantAttribute that found.
12263 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
12264 (VerifyClsCompliance): Override and add extra tests.
12266 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
12267 clscheck- disable CLS-Compliant verification event if assembly is has
12268 CLSCompliantAttribute(true).
12270 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
12271 ApllyAttribute is now called in emit section as in the other cases.
12272 Possible future Emit integration.
12273 (IsIdentifierClsCompliant): New override.
12274 (VerifyClsCompliance): New override.
12275 (GetEnumeratorName): Returns full enum name.
12277 * parameter.cs (GetSignatureForError): Implemented.
12279 * report.cs (WarningData): New struct for Warning message information.
12280 (LocationOfPreviousError): New method.
12281 (Warning): New method. Reports warning based on the warning table.
12282 (Error_T): New method. Reports error based on the error table.
12284 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12285 verifications are done here.
12287 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12289 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12290 CLSCompliantAttribute.
12291 (all_imported_types): New member holds all imported types from other
12293 (LoadAllImportedTypes): New method fills static table with exported types
12294 from all referenced assemblies.
12295 (Modules): New property returns all assembly modules.
12297 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12299 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12300 throwing a parser error.
12302 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12303 which removes the hardcoded get_/set_ prefixes for properties, as
12304 IL allows for the properties to be named something else.
12308 * expression.cs: Do not override operand before we know if it is
12309 non-null. Fix 56207
12311 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12313 * typemanager.cs: support for pinned variables.
12315 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12317 * decl.cs, typemanager.cs: Avoid using an arraylist
12318 as a buffer if there is only one result set.
12320 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12322 * expression.cs: Make sure you cant call a static method
12323 with an instance expression, bug #56174.
12325 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12327 * class.cs (IsDuplicateImplementation): Improve error reporting to
12328 flag 663 (method only differs in parameter modifier).
12330 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12331 in preprocessor directives.
12333 * location.cs (LookupFile): Allow for the empty path.
12335 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12336 better approach for some of that patch, but its failing with the
12337 CharSet enumeration. For now try/catch will do.
12339 * typemanager.cs: Do not crash if a struct does not have fields.
12342 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12344 * expression.cs: cs0213, cant fix a fixed expression.
12347 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12349 * cs-parser.jay: detect invalid embeded statements gracefully.
12352 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12354 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12357 the invocation type may not be a subclass of the tye of the item/
12358 The type of the item must be a subclass of the invocation item.
12363 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12365 * attribute.cs: Added methods to get a string and a bool from an
12366 attribute. Required to information from AssemblyKeyFileAttribute,
12367 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12368 * codegen.cs: Modified AssemblyName creation to include support for
12369 strongnames. Catch additional exceptions to report them as CS1548.
12370 * compiler.csproj: Updated include CryptoConvert.cs.
12371 * compiler.csproj.user: Removed file - user specific configuration.
12372 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12373 Mono.Security assembly. The original class is maintained and tested in
12374 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12375 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12376 like CSC 8.0 (C# v2) supports.
12377 * Makefile: Added CryptoConvert.cs to mcs sources.
12378 * rootcontext.cs: Added new options for strongnames.
12380 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12382 * driver.cs: For --expect-error, report error code `2'
12383 if the program compiled with no errors, error code `1' if
12384 it compiled with an error other than the one expected.
12386 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12388 * compiler.csproj: Updated for Visual Studio .NET 2003.
12389 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12390 * compiler.sln: Updated for Visual Studio .NET 2003.
12392 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12394 * expression.cs: Fix bug #47234. We basically need to apply the
12395 rule that we prefer the conversion of null to a reference type
12396 when faced with a conversion to 'object' (csc behaviour).
12398 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12400 * statement.cs: Shorter form for foreach, eliminates
12401 a local variable. r=Martin.
12403 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12405 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12406 checks if we can use brtrue/brfalse to test for 0.
12407 * expression.cs: use the above in the test for using brtrue/brfalse.
12408 cleanup code a bit.
12410 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12412 * expression.cs: Rewrite string concat stuff. Benefits:
12414 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12415 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12416 rather than a concat chain.
12418 * typemanager.cs: Add lookups for more concat overloads.
12420 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12422 * expression.cs: Emit shorter il code for array init.
12439 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12441 * statement.cs: Before, two switch blocks would be merged if the
12442 total size of the blocks (end_item - begin_item + 1) was less than
12443 two times the combined sizes of the blocks.
12445 Now, it will only merge if after the merge at least half of the
12450 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12452 * class.cs : csc build fix for GetMethods(). See bug #52503.
12454 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12456 * expression.cs: Make sure fp comparisons work with NaN.
12457 This fixes bug #54303. Mig approved this patch a long
12458 time ago, but we were not able to test b/c the runtime
12461 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12463 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12465 2004-03-19 Martin Baulig <martin@ximian.com>
12467 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12468 two overloads may unify for some type parameter substitutions and
12469 report a CS0408 if appropriate.
12471 2004-03-19 Martin Baulig <martin@ximian.com>
12473 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12474 error here and not in our caller.
12476 2004-03-19 Martin Baulig <martin@ximian.com>
12478 * interface.cs: Completely killed this file.
12479 (Interface): We're now a TypeContainer and live in class.cs.
12481 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12482 argument; we're now also called for interfaces.
12483 (TypeContainer.DefineMembers): Allow this method being called
12485 (TypeContainer.GetMethods): New public method; formerly known as
12486 Interface.GetMethod(). This is used by PendingImplementation.
12487 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12488 it's now private and non-static.
12489 (Interface): Moved this here; it's now implemented similar to
12491 (Method, Property, Event, Indexer): Added `bool is_interface'
12492 argument to their .ctor's.
12493 (MemberBase.IsInterface): New public field.
12495 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12496 instances instead of InterfaceMethod, InterfaceProperty, etc.
12497 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12498 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12500 2004-03-19 Martin Baulig <martin@ximian.com>
12502 * class.cs (MethodCore.IsDuplicateImplementation): New private
12503 method which does the CS0111 checking.
12504 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12505 Use IsDuplicateImplementation().
12507 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12509 * decl.cs (FindMemberToOverride): New method to find the correct
12510 method or property to override in the base class.
12512 - Make Method/Property use the above method to find the
12513 version in the base class.
12514 - Remove the InheritableMemberSignatureCompare as it is now
12517 This patch makes large code bases much faster to compile, as it is
12518 O(n) rather than O(n^2) to do this validation.
12520 Also, it fixes bug 52458 which is that nested classes are not
12521 taken into account when finding the base class member.
12523 Reviewed/Approved by Martin.
12525 2004-03-17 Martin Baulig <martin@ximian.com>
12527 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12528 of type arguments into account; use the `real_num_type_args'
12529 approach like in DoResolveAsTypeStep().
12531 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12534 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12536 * interface.cs: In all interface classes removed redundant
12537 member initialization.
12539 2004-03-16 Martin Baulig <martin@ximian.com>
12541 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12543 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12545 * decl.cs (DefineTypeAndParents): New helper method to define a
12546 type's containers before the type itself is defined; This is a
12547 bug exposed by the recent changes to Windows.Forms when an
12548 implemented interface was defined inside a class that had not been
12551 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12553 (Check): Loop correctly to report errors modifiers
12554 (UNSAFE was not in the loop, since it was the same as TOP).
12556 * interface.cs: Every interface member now takes a ModFlags,
12557 instead of a "is_new" bool, which we set on the base MemberCore.
12559 Every place where we called "UnsafeOk" in the interface, now we
12560 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12561 the unsafe settings from the member declaration instead of the
12562 container interface.
12564 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12566 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12567 `set_indexer_name' to the pending bits (one per type).
12569 We fixed a bug today that was picking the wrong method to
12570 override, since for properties the existing InterfaceMethod code
12571 basically ignored the method name. Now we make sure that the
12572 method name is one of the valid indexer names.
12574 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12576 * support.cs (SeekableStreamReader): Keep track of stream byte
12577 positions and don't mix them with character offsets to the buffer.
12579 Patch from Gustavo Giráldez
12581 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12583 * interface.cs (InterfaceSetGetBase): Removed double member
12584 initialization, base class does it as well.
12586 2004-03-13 Martin Baulig <martin@ximian.com>
12588 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12589 when compiling corlib.
12591 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12593 * convert.cs (ExplicitConversion): We were reporting an error on
12594 certain conversions (object_type source to a value type, when the
12595 expression was `null') before we had a chance to pass it through
12596 the user defined conversions.
12598 * driver.cs: Replace / and \ in resource specifications to dots.
12601 * class.cs: Add check for duplicate operators. Fixes 52477
12603 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12605 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12606 that are in the middle of the statements, not only at the end.
12609 * class.cs (TypeContainer.AddField): No longer set the
12610 `HaveStaticConstructor' flag, now we call it
12611 `UserDefineStaticConstructor' to diferentiate the slightly
12612 semantic difference.
12614 The situation is that we were not adding BeforeFieldInit (from
12615 Modifiers.TypeAttr) to classes that could have it.
12616 BeforeFieldInit should be set to classes that have no static
12621 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12623 And most importantly Zoltan's comment:
12625 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12627 "I think beforefieldinit means 'it's ok to initialize the type sometime
12628 before its static fields are used', i.e. initialization does not need
12629 to be triggered by the first access to the type. Setting this flag
12630 helps the JIT to compile better code, since it can run the static
12631 constructor at JIT time, and does not need to generate code to call it
12632 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12633 this flag for lots of classes like String.
12635 csc sets this flag if the type does not have an explicit static
12636 constructor. The reasoning seems to be that if there are only static
12637 initalizers for a type, and no static constructor, then the programmer
12638 does not care when this initialization happens, so beforefieldinit
12641 This bug prevents the AOT compiler from being usable, since it
12642 generates so many calls to mono_runtime_class_init that the AOT code
12643 is much slower than the JITted code. The JITted code is faster,
12644 because it does not generate these calls if the vtable is type is
12645 already initialized, which is true in the majority of cases. But the
12646 AOT compiler can't do this."
12648 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12650 * class.cs (MethodData.Emit): Refactor the code so symbolic
12651 information is generated for destructors; For some reasons we
12652 were taking a code path that did not generate symbolic information
12655 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12657 * class.cs: Create a Constructor.CheckBase method that
12658 takes care of all validation type code. The method
12659 contains some code that was moved from Define.
12661 It also includes new code that checks for duplicate ctors.
12662 This fixes bug #55148.
12664 2004-03-09 Joshua Tauberer <tauberer@for.net>
12666 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12667 a { ... }-style array creation invokes EmitStaticInitializers
12668 which is not good for reference-type arrays. String, decimal
12669 and now null constants (NullCast) are not counted toward
12670 static initializers.
12672 2004-03-05 Martin Baulig <martin@ximian.com>
12674 * location.cs (SourceFile.HasLineDirective): New public field;
12675 specifies whether the file contains or is referenced by a "#line"
12677 (Location.DefineSymbolDocuments): Ignore source files which
12678 either contain or are referenced by a "#line" directive.
12680 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12682 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12683 direct access to our parent, so check the method inline there.
12685 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12687 * expression.cs (Invocation.EmitCall): Miguel's last commit
12688 caused a regression. If you had:
12693 In Foo the implict this would be null.
12695 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12697 * expression.cs (Invocation.EmitCall): If the method is not
12698 virtual, do not emit a CallVirt to it, use Call.
12700 * typemanager.cs (GetFullNameSignature): Improve the method to
12701 cope with ".ctor" and replace it with the type name.
12703 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12704 as an argument the ConstructorBuilder where it is being defined,
12705 to catch the recursive constructor invocations.
12707 2004-03-16 Martin Baulig <martin@ximian.com>
12709 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12710 ConstructedType, call ResolveType() on it to get the type rather
12711 than just using `expr.Type'.
12713 2004-03-16 Martin Baulig <martin@ximian.com>
12715 * generics.cs (ConstructedType.GetMemberAccess): Take the
12716 EmitContext instead on the TypeExpr and use
12717 ec.TypeContainer.CurrentType/ec.ContainerType.
12719 2004-03-16 Martin Baulig <martin@ximian.com>
12721 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12722 parameters before aliases.
12724 2004-03-16 Martin Baulig <martin@ximian.com>
12726 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12727 New oublic function; checks whether two generic instances may become
12728 equal under some instantiations (26.3.1).
12730 * class.cs (TypeContainer.Define): Call
12731 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12734 2004-03-16 Martin Baulig <martin@ximian.com>
12736 * class.cs (TypeContainer.GetClassBases): Moved
12737 Error_TypeParameterAsBase() here and also check whether the base
12738 class is not an attribute.
12740 2004-03-16 Martin Baulig <martin@ximian.com>
12742 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12744 2004-03-16 Martin Baulig <martin@ximian.com>
12746 * class.cs (Error_TypeParameterAsBase): Use correct error number
12749 2004-03-16 Martin Baulig <martin@ximian.com>
12751 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12754 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12757 2004-03-15 Martin Baulig <martin@ximian.com>
12759 * typemanager.cs (TypeManager.GetFullName): New public method.
12760 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12761 argument; only return members with the correct number of type
12763 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12764 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12765 whether the number of type arguments matches.
12767 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12768 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12770 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12771 field; it's set by the protected .ctor when we're actually a
12772 GenericMemberAccess.
12773 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12774 arguments and pass it to MemberLookupFinal ().
12776 * ecore.cs (Expression.MemberLookup): Added `int
12777 num_type_arguments' argument; only return members with the correct
12778 number of type arguments.
12779 (Expression.MemberLookupFailed): Check whether the MemberLookup
12780 failed because we did not have the correct number of type
12781 arguments; report CS0305 in this case.
12783 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12784 `e.ResolveAsTypeTerminal()' already did so.
12786 2004-03-15 Martin Baulig <martin@ximian.com>
12788 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12789 we're a ConstructedType; in this case, the caller must report an
12790 error (for instance CS0131).
12792 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12793 (TypeArguments.Resolve): Actually report errors here.
12795 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12797 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12798 `set_indexer_name' to the pending bits (one per type).
12800 We fixed a bug today that was picking the wrong method to
12801 override, since for properties the existing InterfaceMethod code
12802 basically ignored the method name. Now we make sure that the
12803 method name is one of the valid indexer names.
12805 2004-03-15 Martin Baulig <martin@ximian.com>
12807 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12808 for generic instances.
12810 2004-03-13 Martin Baulig <martin@ximian.com>
12812 * class.cs (TypeContainer.DefineType): Call
12813 TypeManager.AddUserType() immediately after creating the
12814 TypeBuilder; pass all type parameters when creating the
12817 * decl.cs (DeclSpace.FindNestedType): New public method.
12818 (DeclSpace.FindType): Added `int num_type_args' argument; only
12819 return types with the correct number of type parameters.
12820 (DeclSpace.CountTypeParams): New public property.
12822 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12823 the number of type parameters; defaults to zero.
12825 * generic.cs (TypeArguments.Count): New public property.
12826 (ConstructedType.DoResolveAsTypeStep): First call
12827 ds.FindNestedType() to find out whether we're nested in the
12828 current generic type; in this case, we inherit all type parameters
12829 from the current class.
12831 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12832 num_type_args' argument.
12833 (RootContext.LookupType): Added overloaded version which takes the
12834 number of type arguments; only return types with the correct
12835 number of type arguments.
12837 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12838 checks whether `Type t' has `int num_type_args'.
12840 2004-03-13 Martin Baulig <martin@ximian.com>
12842 * generic.cs (GenericMethod.DefineType): New method; calls
12843 DefineType() on all the type parameters.
12845 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12846 (MethodData.Define): If we're a generic method, call
12847 GenericMethod.DefineType() to define the type parameters.
12849 2004-03-10 Martin Baulig <martin@ximian.com>
12851 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12852 instead of IsAssignableFrom.
12854 2004-03-10 Martin Baulig <martin@ximian.com>
12856 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12858 * support.cs (ParameterData.HasArrayParameter): New property.
12859 (ReflectionParameters.ctor): Take a MethodBase instead of a
12860 ParameterInfo[]. If we have any type parameters, get the generic
12861 method definition and ask it whether we have variable arguments.
12863 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12865 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12866 routines to check if a type is an enumerable/enumerator allow
12867 classes that implement the IEnumerable or IEnumerator interfaces.
12869 * class.cs (Property, Operator): Implement IIteratorContainer, and
12870 implement SetYields.
12872 (Property.Define): Do the block swapping for get_methods in the
12873 context of iterators. We need to check if Properties also
12874 include indexers or not.
12876 (Operator): Assign the Block before invoking the
12877 OperatorMethod.Define, so we can trigger the Iterator code
12880 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12881 Property and Operator classes are not created when we parse the
12882 declarator but until we have the block completed, so we use a
12883 singleton SimpleIteratorContainer.Simple to flag whether the
12884 SetYields has been invoked.
12886 We propagate this setting then to the Property or the Operator to
12887 allow the `yield' to function.
12889 2004-02-25 Marek Safar <marek.safar@seznam.cz>
12891 * codegen.cs: Implemented attribute support for modules.
12892 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
12893 Assembly/Module functionality.
12895 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
12896 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
12897 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
12899 2004-02-16 Marek Safar <marek.safar@seznam.cz>
12901 * interface.cs (FindMembers): The operation is performed on all base
12902 interfaces and not only on the first. It is required for future CLS Compliance patch.
12904 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
12906 * statement.cs, codegen.cs:
12907 This patch deals with patterns such as:
12909 public class List : IEnumerable {
12911 public MyEnumerator GetEnumerator () {
12912 return new MyEnumerator(this);
12915 IEnumerator IEnumerable.GetEnumerator () {
12919 public struct MyEnumerator : IEnumerator {
12924 Before, there were a few things we did wrong:
12925 1) we would emit callvirt on a struct, which is illegal
12926 2) we emited ldarg when we needed to emit ldarga
12927 3) we would mistakenly call the interface methods on an enumerator
12928 type that derived from IEnumerator and was in another assembly. For example:
12930 public class MyEnumerator : IEnumerator
12932 Would have the interface methods called, even if there were public impls of the
12933 method. In a struct, this lead to invalid IL code.
12935 2004-02-11 Marek Safar <marek.safar@seznam.cz>
12937 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
12940 * delegate.cs (Define): Fixed crash when delegate type is undefined.
12942 2004-02-11 Miguel de Icaza <miguel@ximian.com>
12944 * cs-parser.jay: Fix small regression: we were not testing V2
12945 compiler features correctly.
12947 * interface.cs: If the emit context is null, then create one
12949 2004-02-09 Marek Safar <marek.safar@seznam.cz>
12951 * decl.cs (GetSignatureForError): New virtual method to get full name
12952 for error messages.
12954 * attribute.cs (IAttributeSupport): New interface for attribute setting.
12955 Now it is possible to rewrite ApplyAttributes method to be less if/else.
12957 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
12958 Duplicated members and code in these classes has been removed.
12959 Better encapsulation in these classes.
12961 2004-02-07 Miguel de Icaza <miguel@ximian.com>
12963 * assign.cs (Assign.DoResolve): When dealing with compound
12964 assignments, there is a new rule in ECMA C# 2.4 (might have been
12965 there before, but it is documented here) that states that in:
12969 If b is of type int, and the `op' is a shift-operator, then the
12970 above is evaluated as:
12974 * expression.cs (Binary.ResolveOperator): Instead of testing for
12975 int/uint/long/ulong, try to implicitly convert to any of those
12976 types and use that in pointer arithmetic.
12978 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
12979 method to print information for from the type, not from the
12980 null-method we were given.
12982 2004-02-01 Duncan Mak <duncan@ximian.com>
12984 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
12985 parsing for cmd, fixes bug #53694.
12987 2004-02-04 Marek Safar <marek.safar@seznam.cz>
12989 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
12990 in the member name duplication tests. Property and operator name duplication
12991 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
12993 2004-02-03 Marek Safar <marek.safar@seznam.cz>
12995 * interface.cs (PopulateMethod): Fixed crash when interface method
12996 returns not existing type (error test cs0246-3.cs).
12998 2004-02-02 Ravi Pratap M <ravi@ximian.com>
13000 * cs-parser.jay (interface_accessors): Re-write actions to also
13001 store attributes attached to get and set methods. Fix spelling
13004 (inteface_property_declaration): Modify accordingly.
13006 (InterfaceAccessorInfo): New helper class to store information to pass
13007 around between rules that use interface_accessors.
13009 * interface.cs (Emit): Apply attributes on the get and set
13010 accessors of properties and indexers too.
13012 * attribute.cs (ApplyAttributes): Modify accordingly to use the
13013 right MethodBuilder when applying attributes to the get and set accessors.
13015 2004-01-31 Miguel de Icaza <miguel@ximian.com>
13017 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
13019 2004-01-26 Miguel de Icaza <miguel@ximian.com>
13021 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
13023 2004-01-25 Miguel de Icaza <miguel@ximian.com>
13025 * cs-parser.jay: Remove YIELD token, instead use the new grammar
13026 changes that treat `yield' specially when present before `break'
13027 or `return' tokens.
13029 * cs-tokenizer.cs: yield is no longer a keyword.
13031 2004-01-23 Marek Safar <marek.safar@seznam.cz>
13033 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
13034 setting for default constructors.
13035 For default constructors are almost every time set wrong Modifier. The
13036 generated IL code has been alright. But inside mcs this values was
13037 wrong and this was reason why several of my CLS Compliance tests
13040 2004-02-27 Martin Baulig <martin@ximian.com>
13042 * generics.cs (ConstructedType.ResolveType): Make the nested type
13043 stuff actually work.
13045 2004-02-25 Martin Baulig <martin@ximian.com>
13047 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
13048 property; returns the type parameters just from the current type,
13049 ie. with the ones from outer classes.
13050 (DeclSpace.LookupGeneric): First search in the current class, then
13052 (DeclSpace.initialize_type_params): When hiding a type parameter
13053 from an outer class, put it into the `type_param_list' anyways.
13055 * expression.cs (MemberAccess.expr): Made this field protected.
13057 * class.cs (TypeContainer.Define): The `CurrentType' just contains
13058 the type parameters from the current class.
13060 * generic.cs (ConstructedType.ResolveType): Support nested generic
13061 types by taking the type parameters which we inherit from outer
13062 classes into account.
13063 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
13064 support for nested generic types.
13066 2004-02-23 Martin Baulig <martin@ximian.com>
13068 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
13069 field and check whether we're nested inside a generic type.
13070 (DeclSpace.ResolveType): If we're resolving to a generic type
13071 definition, create a ConstructedType and return its resolved type.
13072 (DeclSpace.initialize_type_params): New private method;
13073 initializes the `type_param_list' field from the type parameters
13074 from this and all enclosing classes.
13075 (DeclSpace.TypeParameters): Call initialize_type_params() unless
13076 we're already initialized.
13078 2004-02-23 Martin Baulig <martin@ximian.com>
13080 * class.cs (Method.Define): Create the generic method before
13081 calling DoDefine().
13082 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
13083 the TypeContainer one); we use this for generic methods.
13085 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
13086 parent's TypeBuilder.
13088 2004-02-18 Martin Baulig <martin@ximian.com>
13090 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
13091 to check for equality.
13093 2004-02-05 Martin Baulig <martin@ximian.com>
13095 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
13096 `ec.TypeContainer.CurrentType', use it instead of
13097 `ec.ContainerType' to check whether we're in the type's ctor.
13099 2004-01-29 Martin Baulig <martin@ximian.com>
13101 * expression.cs (Invocation.DoResolve): If we're a
13102 `ConstructedType', then we're actually a generic method, so
13103 rewrite the expr as a GenericMemberAccess.
13105 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
13106 here; manually parse it into a string.
13108 2004-01-28 Martin Baulig <martin@ximian.com>
13110 * typemanager.cs (TypeManager.IsEqual): New static method.
13111 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
13112 check for equality instead of using `=='.
13114 2004-01-26 Martin Baulig <martin@ximian.com>
13116 * decl.cs (DeclSpace.CurrentType): New public field.
13118 * expression.cs (This.ResolveBase): If we have an
13119 `ec.TypeContainer.CurrentType', use it instead of
13120 `ec.ContainerType'.
13122 * class.cs (TypeContainer.DefineType): If we're a generic type,
13123 create the `CurrentType' (unresolved).
13124 (TypeContainer.GenericType): New private field.
13125 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
13126 it and store it in `GenericType' before creating the MemberCache.
13127 (TypeContainer.GetMembers): If we have a `GenericType', call
13128 TypeManager.FindMembers() on it.
13130 * interface.cs (Interface.GenericType): New private field.
13131 (Interface.DefineType): If we're a generic type, create the
13132 `CurrentType' (unresolved).
13133 (Interface.DefineMembers): If we have a `CurrentType', resolve it
13134 and store it in `GenericType' before creating the MemberCache.
13135 (Interface.GetMembers): If we have a `GenericType', call
13136 TypeManager.FindMembers() on it.
13138 2004-01-22 Martin Baulig <martin@ximian.com>
13140 * cs-parser.jay (namespace_or_type_name): Return an Expression,
13141 not a QualifiedIdentifier. This is what `type_name_expression'
13142 was previously doing.
13143 (type_name_expression): Removed; the code is now in
13144 `namespace_or_type_name'.
13145 (qualified_identifier): Removed, use `namespace_or_type_name'
13147 (QualifiedIdentifier): Removed this class.
13149 2004-01-22 Martin Baulig <martin@ximian.com>
13151 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
13152 not a string as alias name.
13154 2004-01-21 Miguel de Icaza <miguel@ximian.com>
13156 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
13157 #52730 bug, and instead compute correctly the need to use a
13158 temporary variable when requesting an address based on the
13159 static/instace modified of the field and the constructor.
13161 2004-01-21 Martin Baulig <martin@ximian.com>
13163 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
13164 class and namespace before looking up aliases. Fixes #52517.
13166 2004-01-21 Martin Baulig <martin@ximian.com>
13168 * flowanalysis.cs (UsageVector.Merge): Allow variables being
13169 assinged in a 'try'; fixes exception4.cs.
13171 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13172 * class.cs : Implemented parameter-less constructor for TypeContainer
13174 * decl.cs: Attributes are now stored here. New property OptAttributes
13176 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
13178 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
13180 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13182 * typemanager.cs (CSharpSignature): Now reports also inner class name.
13183 (CSharpSignature): New method for indexer and property signature.
13185 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13187 * pending.cs (IsVirtualFilter): Faster implementation.
13189 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13191 * typemanager.cs: Avoid inclusion of same assembly more than once.
13193 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13195 * cs-parser.jay: Fixed problem where the last assembly attribute
13196 has been applied also to following declaration (class, struct, etc.)
13198 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13200 * class.cs: Added error CS0538, CS0539 reporting.
13201 Fixed crash on Microsoft runtime when field type is void.
13203 * cs-parser.jay: Added error CS0537 reporting.
13205 * pending.cs: Added error CS0535 reporting.
13206 Improved error report for errors CS0536, CS0534.
13208 2004-01-20 Miguel de Icaza <miguel@ximian.com>
13210 Merge a few bits from the Anonymous Method MCS tree.
13212 * statement.cs (ToplevelBlock): New class for toplevel methods,
13213 will hold anonymous methods, lifted variables.
13215 * cs-parser.jay: Create toplevel blocks for delegates and for
13216 regular blocks of code.
13218 2004-01-20 Martin Baulig <martin@ximian.com>
13220 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
13221 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
13222 and `NeedExplicitReturn'; added `IsLastStatement'.
13223 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
13224 have a `ReturnLabel' or we're not unreachable.
13226 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
13227 child's reachability; don't just override ours with it. Fixes
13228 #58058 (lluis's example).
13229 (FlowBranching): Added public InTryOrCatch(), InCatch(),
13230 InFinally(), InLoop(), InSwitch() and
13231 BreakCrossesTryCatchBoundary() methods.
13233 * statement.cs (Return): Do all error checking in Resolve().
13234 Unless we are the last statement in a top-level block, always
13235 create a return label and jump to it.
13236 (Break, Continue): Do all error checking in Resolve(); also make
13237 sure we aren't leaving a `finally'.
13238 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
13239 statement in a top-level block.
13240 (Block.Flags): Added `IsDestructor'.
13241 (Block.IsDestructor): New public property.
13243 2004-01-20 Martin Baulig <martin@ximian.com>
13245 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
13247 2004-01-20 Martin Baulig <martin@ximian.com>
13249 * statement.cs (Statement.ResolveUnreachable): New public method.
13250 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
13251 (Block.Resolve): Resolve unreachable statements.
13253 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13255 * expression.cs: We need to fix the case where we do
13256 not have a temp variable here.
13258 * assign.cs: Only expression compound assignments need
13259 temporary variables.
13261 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13263 * flowanalysis.cs: Reduce memory allocation in a few ways:
13264 - A block with no variables should not allocate a bit
13266 - A method with no out parameters does not need any tracking
13267 for assignment of the parameters, so we need not allocate
13270 public readonly Type[] VariableTypes;
13271 public readonly string[] VariableNames;
13272 Are redundant. The data is already stored in the variable
13273 map, so we need not allocate another array for it.
13274 - We need to add alot of checks for if (params | locals) == null
13275 due to the first two changes.
13277 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13279 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13280 implement IMemoryLocation, we store a copy on a local variable and
13281 take the address of it. Patch from Benjamin Jemlich
13283 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13284 to use a special "type_name_expression" rule which reduces the
13285 number of "QualifiedIdentifier" classes created, and instead
13286 directly creates MemberAccess expressions.
13288 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13290 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13291 that fixes #52853. Null literal assignment to ValueType
13293 * class.cs (MethodData.Emit): Instead of checking the name of the
13294 method to determine if its a destructor, create a new derived
13295 class from Method called Destructor, and test for that.
13297 * cs-parser.jay: Create a Destructor object instead of a Method.
13299 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13303 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13305 * expression.cs (Binary.ResolveOperator): Perform an implicit
13306 conversion from MethodGroups to their delegate types on the
13307 Addition operation.
13309 * delegate.cs: Introduce a new class DelegateCreation that is the
13310 base class for `NewDelegate' and `ImplicitDelegateCreation',
13311 factor some code in here.
13313 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13314 conversion from MethodGroups to compatible delegate types.
13316 * ecore.cs (Expression.Resolve): Do not flag error 654
13317 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13318 we allow conversions from MethodGroups to delegate types now.
13320 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13321 assignments in v2 either.
13323 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13325 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13326 static read-only fields in ctors.
13328 Applied patch from Benjamin Jemlich
13330 * expression.cs (UnaryMutator): Avoid leaking local variables.
13332 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13334 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13335 here to return true, as they can be used like this:
13337 (XXX) int.MEMBER ()
13339 Fixed 49836 and all the other dups
13341 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13343 * driver.cs: Implement /win32res and /win32icon.
13345 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13347 * cs-parser.jay: Add a rule to improve error handling for the
13348 common mistake of placing modifiers after the type.
13350 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13352 * cs-parser.jay (interface_event_declaration): Catch
13353 initialization of events on interfaces, and report cs0068
13355 * cs-parser.jay (interface_event_declaration): Catch
13356 initialization of events.
13358 * ecore.cs: Better report missing constructors.
13360 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13361 the error reporting done in the wrong place. Fix.
13363 * expression.cs (Binary.ResolveOperator): Catch the
13364 operator + (E x, E y) error earlier, and later allow for implicit
13365 conversions in operator +/- (E e, U x) from U to the underlying
13368 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13369 52596, if the container class is abstract, the default constructor
13370 is protected otherwise its public (before, we were always public).
13372 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13375 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13376 Jemlich that fixes bug #52597, MCS was generating invalid code for
13377 idisposable structs. Thanks to Ben for following up with this
13380 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13382 * driver.cs: Allow assemblies without code to be generated, fixes
13385 2004-01-07 Nick Drochak <ndrochak@gol.com>
13387 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13389 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13391 * cs-parser.jay: Add rules to improve error reporting if fields or
13392 methods are declared at the namespace level (error 116)
13394 * Add rules to catch event add/remove
13396 2004-01-04 David Sheldon <dave-mono@earth.li>
13398 * expression.cs: Added matching ")" to error message for
13401 2004-01-03 Todd Berman <tberman@gentoo.org>
13403 * ecore.cs, attribute.cs:
13404 Applying fix from #52429.
13406 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13408 * ecore.cs, expression.cs, statement.cs:
13409 Total rewrite of how we handle branching. We
13410 now handle complex boolean expressions with fewer
13411 jumps. As well if (x == 0) no longer emits a ceq.
13413 if (x is Foo) is much faster now, because we generate
13416 Overall, we get a pretty big improvement on our benchmark
13417 tests. The code we generate is smaller and more readable.
13419 I did a full two-stage bootstrap. The patch was reviewed
13420 by Martin and Miguel.
13422 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13424 * cs-parser.jay: Make primary_expression not take a QI.
13425 we dont need this because the member_access rule covers
13426 us here. So we replace the rule with just IDENTIFIER.
13428 This has two good effects. First, we remove a s/r conflict.
13429 Second, we allocate many fewer QualifiedIdentifier objects.
13431 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13433 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13434 set the correct information via SRE. This prevents
13435 hanging on the MS runtime. Fixes #29374.
13437 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13439 * convert.cs: correctly handle conversions to value types
13440 from Enum and ValueType as unboxing conversions.
13442 Fixes bug #52569. Patch by Benjamin Jemlich.
13444 2004-01-02 Ravi Pratap <ravi@ximian.com>
13446 * expression.cs (BetterConversion): Prefer int -> uint
13447 over int -> ulong (csc's behaviour). This fixed bug #52046.
13449 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13451 * decl.cs (MemberCache.FindMembers): now returns a
13454 * typemanager.cs: In general, go with with ^^.
13455 (CopyNewMethods): take an IList.
13456 (RealMemberLookup): Only allocate an arraylist
13457 if we copy from two sets of methods.
13459 This change basically does two things:
13460 1) Fewer array lists allocated due to CopyNewMethods.
13461 2) the explicit cast in MemberList costed ALOT.
13463 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13465 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13466 a hashtable to avoid needless string allocations when an identifier is
13467 used more than once (the common case).
13469 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13471 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13472 is broken, it will not return anything. So, we
13473 have to use the information we have in mcs to
13476 * typemanager.cs: Add a cache for GetInterfaces,
13477 since this will now be used more often (due to ^^)
13479 (GetExplicitInterfaces) New method that gets the
13480 declared, not effective, interfaces on a type
13481 builder (eg, if you have interface IFoo, interface
13482 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13485 This patch makes MCS able to bootstrap itself on
13488 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13490 * expression.cs: Remove the Nop's that Miguel put
13493 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13495 * report.cs, codegen.cs: Give the real stack trace to
13496 the error when an exception is thrown.
13498 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13500 * decl.cs: only allocate hashtables for ifaces if
13503 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13505 * expression.cs: fix the error from cs0121-2.cs
13506 (a parent interface has two child interfaces that
13507 have a function with the same name and 0 params
13508 and the function is called through the parent).
13510 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13512 * class.cs, rootcontext.cs, typmanager.cs: do not
13515 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13517 * codegen.cs: remove stack for the ec flow branching.
13518 It is already a linked list, so no need.
13520 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13522 * Makefile: Allow custom profiler here.
13524 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13526 * typemanager.cs (LookupType):
13527 - Use a static char [], because split takes
13528 a param array for args, so it was allocating
13530 - Do not store true in a hashtable, it boxes.
13532 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13534 * flowanalysis.cs: bytify common enums.
13536 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13538 * modifiers.cs: Add a new set of flags for the
13539 flags allowed on explicit interface impls.
13540 * cs-parser.jay: catch the use of modifiers in
13541 interfaces correctly.
13542 * class.cs: catch private void IFoo.Blah ().
13544 All related to bug #50572.
13546 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13548 * decl.cs: Rewrite the consistant accessability checking.
13549 Accessability is not linear, it must be implemented in
13550 a tableish way. Fixes #49704.
13552 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13554 * expression.cs: Handle negation in a checked context.
13555 We must use subtraction from zero. Fixes #38674.
13557 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13559 * class.cs: Ignore static void main in DLLs.
13560 * rootcontext.cs: Handle the target type here,
13561 since we are have to access it from class.cs
13562 * driver.cs: account for the above.
13564 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13566 * report.cs: Give line numbers and files if available.
13568 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13570 * driver.cs: Implement /addmodule.
13572 * typemanager.cs: Change 'modules' field so it now contains Modules not
13575 2003-12-20 Martin Baulig <martin@ximian.com>
13577 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13578 (FieldBase.IsAssigned): Removed this field.
13579 (FieldBase.SetAssigned): New public method.
13580 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13582 2003-12-20 Martin Baulig <martin@ximian.com>
13584 * expression.cs (LocalVariableReference.DoResolve): Don't set
13585 `vi.Used' if we're called from DoResolveLValue().
13587 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13588 returns the usage vector it just merged into the current one -
13589 pass this one to UsageWarning().
13590 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13591 of the `EmitContext', don't call this recursively on our children.
13593 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13595 * driver.cs: Implement /target:module.
13597 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13599 * support.cs (CharArrayHashtable): New helper class.
13601 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13602 char arrays, not strings, so we can avoid creating a string in
13603 consume_identifier if the identifier is a keyword.
13605 2003-12-16 Martin Baulig <martin@ximian.com>
13607 * statement.cs (LocalInfo.Assigned): Removed this property.
13608 (LocalInfo.Flags): Removed `Assigned'.
13609 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13610 and uses flow analysis.
13611 (Block.UsageWarning): Made this method private.
13612 (Block.Resolve): Call UsageWarning() if appropriate.
13614 * expression.cs (LocalVariableReference.DoResolve): Always set
13615 LocalInfo.Used here.
13617 2003-12-13 Martin Baulig <martin@ximian.com>
13619 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13620 any value here; we're now using flow analysis to figure out
13621 whether a statement/block returns a value.
13623 2003-12-13 Martin Baulig <martin@ximian.com>
13625 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13627 (FlowBranching.MergeFinally): Don't call
13628 `branching.CheckOutParameters()' here, this is called in
13630 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13631 when adding the `finally' vector.
13633 2003-12-13 Martin Baulig <martin@ximian.com>
13636 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13637 actually work and also fix #48962.
13639 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13641 * decl.cs: Do not check System.Object for nested types,
13642 since we know it does not have any. Big bang for buck:
13645 Run 1: 8.35 seconds
13646 Run 2: 8.32 seconds
13647 corlib: 17.99 seconds
13649 Run 1: 8.17 seconds
13650 Run 2: 8.17 seconds
13651 corlib: 17.39 seconds
13653 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13655 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13656 time we are returning 0 members, so we save alot here.
13658 2003-12-11 Martin Baulig <martin@ximian.com>
13660 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13661 `MergeChild()', also just take the `FlowBranching' as argument;
13662 call Merge() on it and return the result.
13663 (FlowBranching.Merge): We don't need to do anything if we just
13666 2003-12-11 Martin Baulig <martin@ximian.com>
13668 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13669 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13670 Maurer for this idea.
13672 2003-12-11 Martin Baulig <martin@ximian.com>
13674 * flowanalysis.cs (MergeResult): This class is now gone; we now
13675 use the `UsageVector' for this. The reason for this is that if a
13676 branching just has one sibling, we don't need to "merge" them at
13677 all - that's the next step to do.
13678 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13681 2003-12-11 Martin Baulig <martin@ximian.com>
13683 Reworked flow analyis and made it more precise and bug-free. The
13684 most important change is that we're now using a special `Reachability'
13685 class instead of having "magic" meanings of `FlowReturns'. I'll
13686 do some more cleanups and optimizations and also add some more
13687 documentation this week.
13689 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13690 largely reworked this class.
13691 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13692 the new `Reachability' class instead of having "magic" values here.
13693 (FlowBranching): We're now using an instance of `Reachability'
13694 instead of having separate `Returns', `Breaks' etc. fields.
13696 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13697 based on flow analysis; ignore the return value of block.Emit ().
13699 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13701 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13702 if they are private.
13704 2003-12-09 Martin Baulig <martin@ximian.com>
13706 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13707 call them directly on the UsageVector.
13709 2003-12-09 Martin Baulig <martin@ximian.com>
13711 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13712 Changed return type from `FlowReturns' to `Reachability'.
13714 2003-12-09 Martin Baulig <martin@ximian.com>
13716 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13717 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13718 `Reachable' fields with a single `Reachability' one.
13720 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13722 * class.cs (FindMembers): Remove foreach's.
13727 Run 1: 8.74 seconds
13728 Run 2: 8.71 seconds
13731 Run 1: 8.64 seconds
13732 Run 2: 8.58 seconds
13735 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13740 This patch does a few things:
13741 1. EmptyStatement is now a singleton, so it is never reallocated.
13742 2. All blah is EmptyStatement constructs have been changed to
13743 blah == EmptyStatement.Value, which is much faster and valid
13744 now that EmptyStatement is a singleton.
13745 3. When resolving a block, rather than allocating a new array for
13746 the non-empty statements, empty statements are replaced with
13747 EmptyStatement.Value
13748 4. Some recursive functions have been made non-recursive.
13749 Mainly the performance impact is from (3), however (1) and (2) are needed for
13750 this to work. (4) does not make a big difference in normal situations, however
13751 it makes the profile look saner.
13756 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13757 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13758 Total memory allocated: 56397 KB
13761 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13762 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13763 Total memory allocated: 55666 KB
13765 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13767 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13768 than the hashtable in a hashtable version
13770 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13771 we always end up concating a string. This results in a huge perf
13772 loss, because many strings have to be tracked by the GC. In this
13773 patch, we first use a hashtable that works with two keys, so that
13774 the strings do not need to be concat'ed.
13778 Run 1: 8.74 seconds
13779 Run 2: 8.71 seconds
13782 Run 1: 8.65 seconds
13783 Run 2: 8.56 seconds
13785 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13787 * Makefile: Add a new target `do-time' that does a quick and simple
13788 profile, leaving easy to parse output.
13790 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13792 * codegen.cs (Init): Create the dynamic assembly with
13793 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13795 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13797 * support.cs: Make the PtrHashtable use only one
13798 instance of its comparer.
13800 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13802 * typemanager.cs: Fix lookup of GetNamespaces.
13804 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13806 * expression.cs: Removed redundant line.
13808 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13809 ArrayLists, use for loops with bounds.
13811 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13814 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13815 arraylists, use for loop with bounds.
13817 The above three changes give us a 0.071 second performance
13818 improvement out of 3.294 seconds down to 3.223. On my machine
13819 the above changes reduced the memory usage by 1,387 KB during
13820 compiler bootstrap.
13822 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13823 QualifiedIdentifiers. Before we created a new string through
13824 concatenation, and mostly later on, the result would be
13825 manipulated by DecomposeQI through string manipulation.
13827 This reduced the compiler memory usage for bootstrapping from
13828 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13829 compile times in 0.05 seconds.
13831 2003-11-28 Dick Porter <dick@ximian.com>
13833 * support.cs: Do string compares with the Invariant culture.
13841 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13842 the comparison is done with the Invariant culture.
13844 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13846 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13847 GetEnumerator method.
13849 (ProbeCollectionType): Iterate starting at the most specific type
13850 upwards looking for a GetEnumerator
13852 * expression.cs: Shift count can be up to 31 for int/uint and 63
13855 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13857 * statement.cs (Block.LookupLabel): Also look for the label on the
13858 children blocks. Use a hash table to keep track of visited
13861 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13862 we actually did transform the other operand, otherwise fall back
13863 to the common codepath that casts to long.
13865 * cs-tokenizer.cs: Use the same code pattern as the int case.
13866 Maybe I should do the parsing myself, and avoid depending on the
13867 Parse routines to get this done.
13869 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13871 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13872 which fixes bug 51347. This time test it.
13874 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13875 attributes for example can not tell the difference between these.
13876 The difference was only a syntax feature of the language.
13878 * attribute.cs: Apply attributes to delegates.
13880 * delegate.cs: Call the apply attributes method.
13882 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13884 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13885 comparing 0 vs Byte.MinValue, not the value
13887 (ImplicitConversionRequired): When reporting a conversion error,
13888 use error 31 to print out the constant error instead of the
13891 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13892 which fixes bug 51347.
13894 2003-11-22 Miguel de Icaza <miguel@ximian.com>
13896 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
13897 which fixes the -warnaserror command line option.
13899 2003-11-21 Miguel de Icaza <miguel@ximian.com>
13901 * cfold.cs (DoNumericPromotions): During constant folding of
13902 additions on UIntConstant, special case intconstants with
13903 IntConstants like we do on the expression binary operator.
13905 2003-11-12 Miguel de Icaza <miguel@ximian.com>
13907 * convert.cs (ImplicitReferenceConversion): We were missing a case
13908 (System.Enum are not value types or class types, so we need to
13909 classify them separatedly).
13911 * driver.cs: We do not support error 2007.
13913 2003-11-12 Jackson Harper <jackson@ximian.com>
13915 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
13916 system directory. Also use the full file name so users can
13917 libraries names mscorlib-o-tron.dll in a non system dir.
13919 2004-01-04 David Sheldon <dave-mono@earth.li>
13921 * expression.cs: Added matching ")" to error message for CS0077.
13923 2003-12-19 Martin Baulig <martin@ximian.com>
13925 * typemanager.cs (TypeManager.IsEqualGenericType): New public
13926 static method; see documentation in the method.
13927 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
13929 * convert.cs (Convert.ImplicitReferenceConversion,
13930 Convert.ImplicitReferenceConversionExists): Add support for
13931 generic type declarations; see gen-36.cs.
13933 2003-12-19 Martin Baulig <martin@ximian.com>
13935 * pending.cs (Pending.InterfaceMethod): Use
13936 `Type.IsAssignableFrom()' instead of `=='.
13938 2003-12-18 Martin Baulig <martin@ximian.com>
13940 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
13943 * convert.cs (Convert.ImplicitStandardConversionExists): Use
13944 `expr_type.Equals (target_type)' instead of `=='.
13946 2003-12-08 Martin Baulig <martin@ximian.com>
13948 * generics.cs (Constraints.Types): Removed.
13949 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
13951 (Constraints.ResolveTypes): New public method; resolves the
13952 TypeExpr's to Type's.
13953 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
13954 longer takes the constraints.
13955 (TypeParameter.DefineMethod): Likewise.
13956 (TypeParameter.DefineType): New public method. Calls
13957 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
13960 2003-12-08 Martin Baulig <martin@ximian.com>
13962 * convert.cs (Convert.ImplicitConversionStandard): Use
13963 `expr_type.Equals (target_type)' instead of `=='.
13965 2003-12-08 Martin Baulig <martin@ximian.com>
13967 * typemanager.cs (TypeManager.GetReferenceType): Call
13968 `Type.MakeByRefType ()'.
13970 2003-12-08 Martin Baulig <martin@ximian.com>
13972 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
13973 just has some special meaning in some situations. For instance,
13974 it is allowed to use `where' as the name of a variable etc.
13976 2003-12-04 Martin Baulig <martin@ximian.com>
13978 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13979 `Type.MakeArrayType()' for array types.
13981 2003-11-18 Miguel de Icaza <miguel@ximian.com>
13983 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
13986 (SizeOf.DoResolve): assign the `type_queried' field. This gets
13989 2003-11-16 Martin Baulig <martin@ximian.com>
13991 * codegen.cs (EmitContext.IsGeneric): Removed.
13993 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
13994 ResolveGeneric() on the DeclSpace.
13996 2003-11-16 Martin Baulig <martin@ximian.com>
13998 * generic.cs (TypeArguments.Resolve):
13999 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
14000 `ResolveType()' on it to get the Type.
14002 2003-11-15 Martin Baulig <martin@ximian.com>
14004 * generic.cs (ConstructedType.GetInterfaces): Override this.
14006 2003-11-14 Martin Baulig <martin@ximian.com>
14008 * interface.cs (Interface.DefineType): Define all type parameters
14009 before adding the interfaces we inherit.
14011 2003-11-11 Martin Baulig <martin@ximian.com>
14013 * generic.cs (ConstructedType.ResolveType): Always call
14014 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
14016 2003-11-10 Martin Baulig <martin@ximian.com>
14018 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
14019 (TypeManager.InitCoreTypes): Initialize them here, but instead of
14020 calling `ResolveType()' on them, directly assign their `Type'.
14022 2003-11-08 Martin Baulig <martin@ximian.com>
14024 * generic.cs (ConstructedType): Override `IsClass' etc.
14026 2003-11-08 Martin Baulig <martin@ximian.com>
14028 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
14029 return value and the `out parent' parameter.
14030 (TypeContainer.DefineType): Moved the CS0644 check into
14031 GetClassBases(). Don't pass the interface types to the
14032 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
14033 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
14035 * ecore.cs (TypeExpr.IsAttribute): New property.
14036 (TypeExpr.GetInterfaces): New method.
14038 * interface.cs (Interface.GetInterfaceTypeByName): Return a
14039 TypeExpr instead of a Type.
14040 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
14041 (Interface.DefineType): Don't pass the interface types to the
14042 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
14043 them later and then call `TypeBulider.AddInterfaceImplementation()'.
14045 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
14046 instead of a `Type[]'.
14047 (TypeManager.RegisterBuilder): Likewise.
14048 (TypeManager.AddUserInterface): Likewise.
14049 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
14050 `Type[]' and also return a `TypeExpr[]'.
14051 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
14053 2003-11-08 Martin Baulig <martin@ximian.com>
14055 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
14058 2003-11-08 Martin Baulig <martin@ximian.com>
14060 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
14061 TypeManager.ResolveExpressionTypes().
14063 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
14064 instead of an Expression.
14065 (TypeExpr): This is now an abstract base class for `TypeExpression'.
14066 (TypeExpression): New public class; formerly known as `TypeExpr'.
14068 * expression.cs (ComposedCast): Derive from TypeExpr.
14070 * typemanager.cs (TypeManager.system_*_expr): These are now
14071 TypExpr's instead of Expression's.
14072 (TypeManager.ResolveExpressionTypes): New public static function;
14073 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
14076 2003-11-06 Miguel de Icaza <miguel@ximian.com>
14078 * expression.cs (New.DoResolve): Do not dereference value that
14079 might be a null return.
14081 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
14082 sure that the constant value has the right type. Fixes an
14083 unreported bug, similar to 50425.
14085 * const.cs (Const.LookupConstantValue): Call
14086 ImplicitStandardConversionExists before doing a conversion to
14087 avoid havng the TypeManager.ChangeType do conversions.
14089 Reduced the number of casts used
14091 (Const.ChangeType): New routine to enable reuse of the constant
14092 type changing code from statement.
14094 * typemanager.cs (ChangeType): Move common initialization to
14095 static global variables.
14099 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
14100 every value type to go through, even if it was void. Fix that.
14102 * cs-tokenizer.cs: Use is_identifier_start_character on the start
14103 character of the define, and the is_identifier_part_character for
14104 the rest of the string.
14106 2003-11-05 Miguel de Icaza <miguel@ximian.com>
14108 * expression.cs (UnaryMutator.EmitCode): When I updated
14109 LocalVariableReference.DoResolve, I overdid it, and dropped an
14110 optimization done on local variable references.
14112 2003-11-04 Miguel de Icaza <miguel@ximian.com>
14114 * ecore.cs: Convert the return from Ldlen into an int.
14116 2003-10-20 Miguel de Icaza <miguel@ximian.com>
14118 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
14119 the accessibility, this is a special case for toplevel non-public
14120 classes (internal for instance).
14122 2003-10-20 Nick Drochak <ndrochak@gol.com>
14124 * ecore.cs: Fix typo and build. Needed another right paren.
14126 2003-10-19 Miguel de Icaza <miguel@ximian.com>
14128 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
14129 `internal' case regular and protected, but not allowing protected
14130 to be evaluated later. Bug 49840
14132 2003-10-15 Miguel de Icaza <miguel@ximian.com>
14134 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
14135 to kb.Nlast, and not the kb.nFirst to isolate the switch
14138 Extract the underlying type, so enumerations of long/ulong are
14139 treated like long/ulong.
14141 2003-10-14 Miguel de Icaza <miguel@ximian.com>
14143 * expression.cs (New): Overload the meaning of RequestedType to
14144 track the possible creation of the NewDelegate type, since
14145 DoResolve is invoked more than once for new constructors on field
14148 See bugs: #48800 and #37014
14150 * cs-parser.jay (declare_local_constants): Take an arraylist
14151 instead of a single constant.
14153 (local_constant_declaration): It should take a
14154 constant_declarators, not a constant_declarator. Fixes 49487
14156 * convert.cs: Fix error report.
14158 2003-10-13 Jackson Harper <jackson@ximian.com>
14160 * typemanager.cs (TypeToCoreType): Add float and double this fixes
14163 2003-11-03 Martin Baulig <martin@ximian.com>
14165 * expression.cs (ArrayAccess.GetStoreOpcode): Added
14166 `out bool has_type_arg'; if set, we need to pass the type to
14168 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
14169 Stelem_Any/Ldelem_Any for generic parameters.
14171 2003-11-02 Martin Baulig <martin@ximian.com>
14173 * expression.cs (Invocation.EmitCall): Use
14174 `TypeManager.IsValueType()' to check whether it's a value type.
14175 Don't set `struct_call' when calling a method on a type parameter.
14177 2003-11-02 Martin Baulig <martin@ximian.com>
14179 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
14180 and removed the TypeBuilder argument.
14182 * typemanager.cs (TypeManager.IsValueType): Return
14183 `t.IsGenericParameter || t.IsValueType'.
14185 2003-10-25 Martin Baulig <martin@ximian.com>
14187 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
14188 call ConstructedType.Resolve() on it.
14190 * generic.cs (ConstructedType.Resolve): Set `type' on success.
14192 2003-10-25 Martin Baulig <martin@ximian.com>
14194 * class.cs (TypeContainer.GetClassBases): Changed
14195 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
14196 CS8214 reporting here.
14197 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
14198 instead of a `Type' for our parent. In case of a recursive
14199 declaration (see tests/gen-23.cs for an example), our parent is a
14200 ConstructedType and it doesn't have its type set. So, first
14201 create our own TypeBuilder, then call constructed.Resolve() to get
14202 the parent's type and finally TypeBuilder.SetParent() it.
14204 * ecore.cs (TypeExpr.Name): New public virtual property.
14207 (ConstructedType): We're now a TypeExpr and not just an Expression.
14208 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
14209 arguments here; this is done later.
14210 (ConstructedType.Resolve): New public method to resolve the type
14211 arguments and bind them.
14213 2003-10-21 Martin Baulig <martin@ximian.com>
14215 * convert.cs: Use `TypeManager.IsValueType' instead of
14216 'type.IsValueType' everywhere.
14218 * typemanager.cs (TypeManager.IsValueType): Return true for type
14219 parameters. The reason for this is that we need to box a type
14220 parameter when converting it to a reference type.
14222 * cs-parser.jay: Added support for default value expressions.
14224 * generics.cs (DefaultValueExpression): New public class.
14226 2003-10-17 Martin Baulig <martin@ximian.com>
14228 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
14229 TypeContainer so we can also use this for Interfaces.
14230 (TypeParameter.Resolve): Likewise.
14232 * interface.cs (Interface.DefineType): Added support for generic
14235 * cs-parser.jay: Added support for generic structs and interfaces.
14237 2003-10-17 Martin Baulig <martin@ximian.com>
14239 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
14240 call generic methods :-)
14242 2003-10-16 Martin Baulig <martin@ximian.com>
14244 * cs-parser.jay (namespace_or_type_name): Only create a
14245 GenericMemberAccess if we actually have type arguments.
14247 2003-10-13 Martin Baulig <martin@ximian.com>
14249 * class.cs (Method.Define): If we're a generic method, call
14250 TypeBuilder.DefineGenericMethod () before resolving
14252 (MethodData): Added .ctor which takes an additional MethodBuilder
14253 argument; this is used for generic methods.
14254 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
14255 we already have a MethodBuilder.
14257 2003-10-10 Martin Baulig <martin@ximian.com>
14259 * class.cs (Method): Added .ctor which takes a `GenericMethod'
14260 instead of a `DeclSpace'. This is used for generic methods.
14262 * cs-parser.jay (method_header): Added support for generic
14263 methods; create a `GenericMethod' instance and pass it to the
14264 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
14265 parameters and locals.
14267 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
14268 since we already have the location. Check whether we're a generic
14269 type declaration or a generic method and create the correct type
14272 * generic.cs (TypeParameter.DefineMethod): New public method.
14273 (GenericMethod): New public class; derives from DeclSpace and is
14274 used for generic methods.
14276 2003-10-09 Martin Baulig <martin@ximian.com>
14278 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14280 (MethodCore.DoDefineParameters): Removed the TypeContainer
14281 argument; use the DeclSpace which was passed to the .ctor instead.
14282 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14283 TypeContainer; we only need a DeclSpace here.
14285 2003-10-09 Martin Baulig <martin@ximian.com>
14287 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14289 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14290 EmitContext's .ctor.
14292 2003-10-09 Martin Baulig <martin@ximian.com>
14294 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14295 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14296 AsAccessible(), moved them as well.
14298 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14300 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14302 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14303 generation for >=, as spotted by Paolo, bug 48679.
14304 Patch from David Waite.
14306 * cs-tokenizer.cs: Add handling for #pragma.
14308 * cs-parser.jay: Allow for both yield and yield return in the
14309 syntax. The anti-cobolization of C# fight will go on!
14311 * class.cs (TypeBuilder.DefineType): Catch error condition here
14312 (Parent.DefineType erroring out and returning null).
14314 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14315 coping with enumerations variables, we were mistakenly processing
14316 them as a regular value type instead of built-in types. Fixes the
14319 * typemanager.cs (IsBuiltinOrEnum): New method.
14321 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14323 * cs-parser.jay: Upgrade: yield now needs the return clause.
14325 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14327 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14329 2003-09-29 Martin Baulig <martin@ximian.com>
14331 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14332 inflated generic methods.
14334 * generics.cs (ConstructedType): Distinguish between open and
14335 closed constructed types; correctly resolve the arguments.
14337 2003-09-22 Martin Baulig <martin@ximian.com>
14339 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14340 all type arguments meet their constraints.
14342 2003-09-19 Martin Baulig <martin@ximian.com>
14344 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14345 `MemberCache parent' argument. Normally, an interface doesn't
14346 have a parent type except System.Object, but we use this in gmcs
14347 for generic type parameters.
14349 2003-09-18 Martin Baulig <martin@ximian.com>
14351 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14352 on `type.IsInterface'; don't check whether the type has a parent
14353 to determine whether it's an interface.
14355 2003-09-17 Martin Baulig <martin@ximian.com>
14357 * generic.cs (ConstructedType.ToString): Always use `name' as the
14360 2003-09-15 Martin Baulig <martin@ximian.com>
14362 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14364 * generic.cs (Constraints.Resolve): New public method; this is
14365 called to resolve the constraint types and to check whether all
14366 the constraints are correct.
14367 (Constraints.Types): New public property.
14368 (TypeParameter.Resolve): New public method; resolves all the
14369 type's constraints.
14371 * class.cs (TypeContainer.DefineType): Call
14372 TypeParameter.Resolve() before actually defining the type.
14374 2003-09-15 Martin Baulig <martin@ximian.com>
14376 * class.cs (TypeContainer.DefineType): Added an error flag to
14377 avoid reporting duplicate CS0146's ("class definition is
14380 * driver.cs (Driver.MainDriver): Abort if
14381 RootContext.ResolveTree() reported any errors.
14383 2003-09-07 Martin Baulig <martin@ximian.com>
14385 * report.cs (Error, Warning): Added overloaded versions which take
14386 a `params object[] args' and call String.Format().
14388 2003-09-07 Martin Baulig <martin@ximian.com>
14390 * decl.cs (DeclSpace..ctor): Don't call
14391 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14392 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14393 (DeclSpace.RecordDecl): New method.
14395 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14397 2003-09-02 Ravi Pratap <ravi@ximian.com>
14399 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14400 value attributes to be applied to ParameterBuilders.
14402 * class.cs (MethodCore.LabelParameters): Make static and more
14403 generic so that it can be used from other places - like interface
14404 methods, for instance.
14406 * interface.cs (Interface.Emit): Call LabelParameters before
14407 emitting attributes on the InterfaceMethod.
14409 2003-09-07 Martin Baulig <martin@ximian.com>
14411 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14412 if the number of type parameters doesn't match.
14414 2003-09-04 Martin Baulig <martin@ximian.com>
14416 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14417 for arrays of generic type params (ie. `!0[]').
14419 2003-09-04 Martin Baulig <martin@ximian.com>
14421 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14424 2003-09-04 Martin Baulig <martin@ximian.com>
14426 * decl.cs (DeclSpace.LookupGeneric): New method.
14427 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14430 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14431 argument, not just a string.
14432 (TypeParameter.Define): New public method; this is called to
14433 actually define the generic parameter; after this, you can use the
14434 new `Type' property to get the type.
14436 2003-09-04 Martin Baulig <martin@ximian.com>
14438 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14439 is now an ArrayList; initialize the result of the `TypeParameters'
14441 (DeclSpace.GetGenericData): Removed.
14442 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14443 implement this in a different way.
14444 (DeclSpace.GetTypeParameters): Removed; there's now a
14445 `TypeParameters' property.
14446 (DeclSpace.TypeParameters): New public property.
14448 * generic.cs (Constraints): Make this class public.
14449 (TypeParameter): New public class.
14451 2003-09-04 Martin Baulig <martin@ximian.com>
14453 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14454 generic parameters.
14456 * class.cs (TypeContainer.DefineType): Call
14457 TypeBuilder.DefineGenericParameter () on all generic parameters if
14458 this is a generic type.
14460 2003-08-28 Martin Baulig <martin@ximian.com>
14462 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14465 * sample-hello.cs: Compile this with gmcs: "gmcs
14466 /r:sample-stack.dll sample-hello.cs".
14468 2003-08-28 Martin Baulig <martin@ximian.com>
14470 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14471 the parameters to the generic type.
14473 2003-08-28 Martin Baulig <martin@ximian.com>
14475 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14477 2003-08-28 Martin Baulig <martin@ximian.com>
14479 * cs-parser.jay (opt_type_argument_list): Use
14480 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14481 (primary_expression): Replace `qualified_identifier' with `type_name'.
14482 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14484 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14485 parser to check whether it is syntactically a type parameter list;
14486 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14489 2003-08-26 Martin Baulig <martin@ximian.com>
14491 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14492 resolving aliases; fixes #47927.
14494 2003-08-26 Martin Baulig <martin@ximian.com>
14496 * statement.cs (Using.DoResolve): This is internally emitting a
14497 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14498 do not always return. Fixes #47681.
14500 2003-08-26 Martin Baulig <martin@ximian.com>
14502 * decl.cs (MemberCore): Moved WarningNotHiding(),
14503 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14505 (AdditionResult): Make this nested in DeclSpace.
14506 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14507 argument; call NamespaceEntry.Define() unless we're nested in a
14510 * namespace.cs (Namespace.DefineName): New public function. This
14511 is called from DeclSpace's .ctor to add
14512 (Namespace.Lookup): Include DeclSpaces in the lookup.
14514 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14516 * const.cs (Const): Derive from MemberBase, not MemberCore.
14518 2003-08-25 Martin Baulig <martin@ximian.com>
14520 * convert.cs (Convert.ExplicitReferenceConversion): When
14521 converting from an interface type to a class, unbox if the target
14522 type is a struct type. Fixes #47822.
14524 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14526 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14529 2003-08-22 Martin Baulig <martin@ximian.com>
14531 * class.cs (TypeManager.DefineType): When defining a nested type,
14532 call DefineType() on our parent; fixes #47801.
14534 2003-08-22 Martin Baulig <martin@ximian.com>
14536 * class.cs (MethodData.Define): While checking if a method is an
14537 interface implementation, improve the test a bit more to fix #47654.
14539 2003-08-22 Martin Baulig <martin@ximian.com>
14541 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14542 correctly; fixes #47722.
14544 2003-08-22 Martin Baulig <martin@ximian.com>
14546 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14547 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14549 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14551 2003-08-22 Martin Baulig <martin@ximian.com>
14553 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14554 can only be assigned in static constructors. Fixes #47161.
14556 2003-08-22 Martin Baulig <martin@ximian.com>
14558 Rewrote and improved the flow analysis code.
14560 * flowbranching.cs (FlowBranching): Make this class abstract.
14561 (FlowBranching.CreateBranching): New static function to create a
14562 new flow branching.
14563 (FlowBranchingBlock, FlowBranchingException): New classes.
14564 (FlowBranching.UsageVector.Type): New public readonly field.
14565 (FlowBranching.UsageVector.Breaks): Removed the setter.
14566 (FlowBranching.UsageVector.Returns): Removed the setter.
14567 (FlowBranching.UsageVector): Added Break(), Return(),
14568 NeverReachable() and Throw() methods to modify the reachability.
14569 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14570 done by FlowBranching.Merge().
14571 (FlowBranching.UsageVector.MergeChild): New method; merges the
14572 merge result into the current vector.
14573 (FlowBranching.Merge): New abstract method to merge a branching.
14575 2003-08-12 Martin Baulig <martin@ximian.com>
14577 * expression.cs (Indirection.CacheTemporaries): Create the
14578 LocalTemporary with the pointer type, not its element type.
14580 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14582 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14583 token was a keyword or not.
14585 Add `error' options where an IDENTIFIER was expected; Provide
14586 CheckToken and CheckIdentifierToken convenience error reporting
14589 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14591 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14592 NameSpaceEntry NameSpaceEntry.
14594 (LookupInterfaceOrClass): Avoid creating a full qualified name
14595 from namespace and name: avoid doing lookups when we know the
14596 namespace is non-existant. Use new Tree.LookupByNamespace which
14597 looks up DeclSpaces based on their namespace, name pair.
14599 * driver.cs: Provide a new `parser verbose' to display the
14600 exception thrown during parsing. This is turned off by default
14601 now, so the output of a failure from mcs is more graceful.
14603 * namespace.cs: Track all the namespaces defined in a hashtable
14606 (IsNamespace): New method
14608 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14610 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14611 we know that we need to concatenate (full typename can never be
14616 * statement.cs: Use a bitfield; Do not initialize to null things
14617 which are done by the constructor by default.
14619 * cs-parser.jay: bug fix, parameter was 4, not 3.
14621 * expression.cs: Just use the property;
14623 * statement.cs: No need for GetVariableInfo method.
14625 2003-08-08 Martin Baulig <martin@ximian.com>
14627 * flowanalysis.cs (FlowReturns): This is now nested in the
14628 `FlowBranching' class.
14629 (MyBitVector): Moved this here from statement.cs.
14630 (FlowBranching.SiblingType): New enum type.
14631 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14633 2003-08-07 Martin Baulig <martin@ximian.com>
14635 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14636 `FlowBranching' class and called `BranchingType'.
14638 2003-08-07 Martin Baulig <martin@ximian.com>
14640 * flowanalysis.cs: Moved all the control flow analysis code into
14643 2003-08-07 Martin Baulig <martin@ximian.com>
14645 * assign.cs (Assign.DoResolve): `target' must either be an
14646 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14649 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14651 * expression.cs (BinaryMethod): This kind of expression is created by the
14652 Binary class if it determines that the operator has to be handled
14655 (BinaryDelegate): This kind of expression is created if we are
14656 dealing with a + or - operator on delegates.
14658 (Binary): remove method, argumetns, and DelegateOperator: when
14659 dealing with methods,
14661 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14663 * statement.cs (Block): use bitfields for the three extra booleans
14664 we had in use. Remove unused topblock parameter.
14666 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14668 * assign.cs: Drop extra unneeded tests.
14670 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14672 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14674 * statement.cs (Foreach): Use VariableStorage instead of
14677 * codegen.cs (VariableStorage): New class used by clients that
14678 require a variable stored: locals or fields for variables that
14679 need to live across yield.
14681 Maybe provide a convenience api for EmitThis+EmitLoad?
14683 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14686 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14688 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14689 RemapParameterLValue): New methods that are used to turn a
14690 precomputed FieldInfo into an expression like this:
14694 The idea is to use this instead of making LocalVariableReference
14695 have more than one meaning.
14697 * cs-parser.jay: Add error production to BASE.
14699 * ecore.cs: Deal with TypeManager.GetField returning null, which
14700 is now a valid return value.
14702 (FieldExprNoAddress): New expression for Fields whose address can
14705 * expression.cs (LocalVariableReference): During the resolve
14706 phases, create new expressions if we are in a remapping context.
14707 Remove code that dealt with remapping here.
14709 (ParameterReference): same.
14711 (ProxyInstance): New expression, like the `This' expression, but
14712 it is born fully resolved. We know what we are doing, so remove
14713 the errors that are targeted to user-provided uses of `this'.
14715 * statement.cs (Foreach): our variable is now stored as an
14716 Expression; During resolution, follow the protocol, dont just
14717 assume it will return this.
14719 2003-08-06 Martin Baulig <martin@ximian.com>
14721 * support.cs (SeekableStreamReader.cs): New public class.
14723 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14724 SeekableStreamReader instead of the normal StreamReader.
14726 2003-08-04 Martin Baulig <martin@ximian.com>
14728 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14729 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14730 deambiguate casts and delegate invocations.
14731 (parenthesized_expression): Use the new tokens to ensure this is
14732 not a cast of method invocation.
14734 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14735 when reading a `)' and Deambiguate_CloseParens () was previously
14738 * expression.cs (ParenthesizedExpression): New class. This is
14739 just used for the CS0075 test.
14740 (Binary.DoResolve): Check for CS0075.
14742 2003-07-29 Ravi Pratap <ravi@ximian.com>
14744 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14745 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14746 reference comparison.
14748 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14749 examine the ReturnType for equality - this is necessary in the
14750 cases of implicit and explicit operators whose signature also
14751 includes the return type.
14753 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14755 * namespace.cs: Cache the result of the namespace computation,
14756 instead of computing it every time.
14758 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14760 * decl.cs: Use a global arraylist that we reuse over invocations
14761 to avoid excesive memory consumption. Reduces memory usage on an
14762 mcs compile by one meg (45 average).
14764 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14765 private, work around that.
14767 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14769 * literal.cs (IntLiteral): Define Zero and One static literals.
14771 * cs-parser.jay (integer_literal): use static literals to reduce
14772 memory usage for the most used literals (0, 1 and -1). 211kb
14773 reduced in memory usage.
14775 Replace all calls to `new ArrayList' with `new
14776 ArrayList(4)' which is a good average number for most allocations,
14777 and also requires only 16 bytes of memory for its buffer by
14780 This reduced MCS memory usage in seven megabytes for the RSS after
14783 2003-07-28 Ravi Pratap <ravi@ximian.com>
14785 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14786 handle params methods the correct way by forming only one
14787 applicable set with params and normal methods in them. Earlier we
14788 were looking at params methods only if we found no normal methods
14789 which was not the correct thing to do.
14791 (Invocation.BetterFunction): Take separate arguments indicating
14792 when candidate and the best method are params methods in their
14795 This fixes bugs #43367 and #46199.
14797 * attribute.cs: Documentation updates.
14799 (CheckAttribute): Rename to CheckAttributeTarget.
14800 (GetValidPlaces): Rename to GetValidTargets.
14802 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14803 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14807 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14809 * codegen.cs: Compute IsGeneric correctly.
14811 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14814 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14815 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14816 regressions, and I was chasing more bugs than I required.
14818 * interface.cs: Use expressions for base type names (like classes
14819 and structs have been doing for a while now), and resolve that.
14820 This patch should probably go into head as well.
14822 This makes it one less user of FindType.
14824 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14826 This compiler can not self host currently. Need to fix that.
14828 * Makefile: compile to `gmcs.exe'
14830 * driver.cs: Turn on v2 by default on gmcs.
14832 * generic.cs (ConstructedType): Does no longer take a container
14833 type argument; That will be taken care of later.
14835 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14836 Use SimpleName to resolve for now, so we can continue the work on
14837 the parser, until we get Type.GetType that understands generics.
14839 (ConstructedType.ToString): Implement
14841 (TypeArguments.Resolve): Resolve the child expressions as types.
14843 * cs-parser.jay: Rename interface_constraints to
14844 type_parameter_constraints
14846 (namespace_or_type_name): Only use constructed types for the basic
14847 construction, we will deal with identifier<...> later.
14849 (type/type_name): No longer call DecomposeQI, as
14850 namespace_or_type_name is always decoded now.
14852 2003-07-22 Ravi Pratap <ravi@ximian.com>
14854 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14855 closely: we eliminate methods in base types when we have an
14856 applicable method in a top-level type.
14858 Please see section 14.5.5.1 for an exact description of what goes
14861 This fixes bug #45127 and a host of other related to corlib compilation.
14863 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14864 array is the method corresponding to the top-level type (this is
14865 because of the changes made to icall.c) so we change this
14868 (MethodGroupExpr.Name): This too.
14870 * typemanager.cs (GetElementType): New method which does the right
14871 thing when compiling corlib.
14873 * everywhere: Make use of the above in the relevant places.
14875 2003-07-22 Martin Baulig <martin@ximian.com>
14877 * cs-parser.jay (invocation_expression): Moved
14878 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14879 `cast_expression', but create a InvocationOrCast which later
14880 resolves to either an Invocation or a Cast.
14882 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14883 method; call this before EmitStatement() to make sure that this
14884 expression can be used as a statement.
14886 * expression.cs (InvocationOrCast): New class; resolves to either
14887 an Invocation or a Cast.
14889 * statement.cs (StatementExpression): Call ResolveStatement() on
14890 the ExpressionStatement before emitting it.
14892 2003-07-21 Martin Baulig <martin@ximian.com>
14894 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
14895 `ref' and `out' attributes match; fixes #46220.
14896 (MemberAccess.ResolveMemberAccess): You can't reference a type
14897 through an expression; fixes #33180.
14898 (Indexers.GetIndexersForType): Don't return the indexers from
14899 interfaces the class implements; fixes #46502.
14901 2003-07-21 Martin Baulig <martin@ximian.com>
14903 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
14904 CS0661 checks; fixes bug #30442.
14906 2003-07-21 Martin Baulig <martin@ximian.com>
14908 * decl.cs (AdditionResult): Added `Error'.
14910 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
14912 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
14913 cs0031.cs actually work.
14915 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14917 * cs-parser.jay (namespace_name): do not use
14918 namespace_or_type_name, use qualified_identifier, because
14919 namespace_or_type_name will soon return a composed expression
14920 instead of a string.
14922 (namespace_or_type_name): Instead of returning a string, now this
14923 production returns an expression.
14925 * codegen.cs (EmitContext): Setup IsGeneric property based on
14926 whether our DeclSpace is generic, our the method is generic.
14928 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
14929 the method is generic.
14931 * cs-parser.jay (type_arguments, opt_type_argument_list,
14932 type_parameters, type_parameter_list, opt_type_parameter_list,
14933 type_parameter,, opt_type_parameter_constraints_clauses,
14934 type_parameter_constraints_clauses,
14935 type_parameter_constraint_clause, type_parameter_constraint,
14936 interface_constraints): Add new production
14938 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
14939 DeclSpace is generic or not.
14941 (DeclSpace.SetParameterInfo): New routine, used to set the
14942 parameter info for a type.
14944 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
14945 returns a GenericTypeExpr
14947 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
14948 generic, lookup the generic argument.
14950 * attribute.cs: Do not allow TypeParameterExpressions in
14953 * class.cs: Do not allow the Main method to be defined in a
14956 * expression.cs (SizeOf): Do not allow generic types to be used as
14957 arguments to sizeof.
14959 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
14960 it: whether a type is generic or not. Only works for types we are
14961 currently building for now.
14963 2003-07-20 Martin Baulig <martin@ximian.com>
14965 * namespace.cs: Fixed that bug which caused a crash when compiling
14966 the debugger's GUI.
14968 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14970 * typemanager.cs (LookupTypeReflection): Never expose types which
14971 are NotPublic, NestedPrivate, NestedAssembly, or
14972 NestedFamANDAssem. We used to return these, and later do a check
14973 that would report a meaningful error, but the problem is that we
14974 would not get the real match, if there was a name override.
14976 2003-07-18 Miguel de Icaza <miguel@ximian.com>
14978 * namespace.cs (Namespace, Name): Do not compute the namespace
14979 name dynamically, compute it in the constructor. This reduced
14980 memory usage by 1697 KB.
14982 * driver.cs: Use --pause to pause at the end.
14984 2003-07-17 Peter Williams <peter@newton.cx>
14986 * Makefile: Change the name of the test target so that it doesn't
14987 conflict with the recursive test target.
14989 2003-07-17 Miguel de Icaza <miguel@ximian.com>
14991 * expression.cs (LocalVariableReference.Emit, EmitAssign,
14992 AddressOf): Do not use EmitThis, that was wrong, use the actual
14995 2003-07-15 Miguel de Icaza <miguel@ximian.com>
14997 * class.cs (MethodData.Define): While checking if a method is an
14998 interface implementation, improve the test: If we are not public
14999 (use new test here: use the computed MethodAttributes directly,
15000 instead of the parsed modifier flags) check if the `implementing'
15001 method comes from an interface or not.
15003 * pending.cs (VerifyPendingMethods): Slightly better error
15006 * makefile: add test target that does the mcs bootstrap.
15008 2003-07-16 Ravi Pratap <ravi@ximian.com>
15010 * interface.cs (Define): Do nothing here since there are no
15011 members to populate etc. Move the attribute emission out of here
15012 since this was just totally the wrong place to put it. Attribute
15013 application happens during the 'Emit' phase, not in the 'Define'
15016 (Emit): Add this method and move the attribute emission here
15018 * rootcontext.cs (EmitCode): Call the Emit method on interface
15021 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15023 * expression.cs (OverloadResolve): Report error only if Location
15024 is not 'Null' which means that there was a probe going on.
15026 2003-07-14 Martin Baulig <martin@ximian.com>
15028 * expression.cs (ConditionalLogicalOperator): New public class to
15029 implement user defined conditional logical operators.
15030 This is section 14.11.2 in the spec and bug #40505.
15032 2003-07-14 Martin Baulig <martin@ximian.com>
15034 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
15036 2003-07-14 Martin Baulig <martin@ximian.com>
15038 * codegen.cs (EmitContext.InFixedInitializer): New public field.
15040 * ecore.cs (IVariable.VerifyFixed): New interface method.
15042 * expression.cs (Unary.ResolveOperator): When resolving the `&'
15043 operator, check whether the variable is actually fixed. Fixes bug
15044 #36055. Set a variable definitely assigned when taking its
15045 address as required by the spec.
15047 * statement.cs (LocalInfo.IsFixed): New field.
15048 (LocalInfo.MakePinned): Set `IsFixed' to true.
15050 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15052 * attribute.cs (Attribute.Resolve): While doing a Member lookup
15053 for .ctors, ensure that we only ask for members declared in the
15054 attribute type (BindingFlags.DeclaredOnly).
15058 * expression.cs (Error_WrongNumArguments): Report error 1501
15059 correctly the way CSC does.
15061 2003-07-13 Martin Baulig <martin@ximian.com>
15063 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
15064 lookup on the fully qualified name, to make things like "X.X" work
15065 where "X.X" is a fully qualified type name, but we also have a
15066 namespace "X" in the using list. Fixes #41975.
15068 2003-07-13 Martin Baulig <martin@ximian.com>
15070 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
15071 function. If we're a CompoundAssign, we need to create an embedded
15072 CompoundAssign, not an embedded Assign.
15073 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
15076 2003-07-13 Martin Baulig <martin@ximian.com>
15078 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
15079 work to fix bug #46088.
15081 2003-07-13 Ravi Pratap <ravi@ximian.com>
15083 * class.cs (Operator.Emit): Do not emit attributes here - it is
15084 taken care of by the Method class that we delegate too. This takes
15085 care of bug #45876.
15087 2003-07-10 Martin Baulig <martin@ximian.com>
15089 * expression.cs (TypeOfVoid): New class.
15090 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
15092 2003-07-10 Martin Baulig <martin@ximian.com>
15094 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
15097 2003-07-10 Martin Baulig <martin@ximian.com>
15099 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
15100 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
15102 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
15104 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
15106 2003-07-10 Martin Baulig <martin@ximian.com>
15108 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
15109 of decimal. Fixes #42850.
15111 NOTE: I also fixed the created byte blob, but this doesn't work on
15112 the MS runtime and csc never produces any byte blobs for decimal
15115 2003-07-10 Martin Baulig <martin@ximian.com>
15117 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
15118 structs; fixes #32068.
15119 (Block.AddChildVariableNames): Fixed #44302.
15121 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15123 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
15125 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15127 * attribute.cs: And this test is onger needed.
15129 2003-07-08 Martin Baulig <martin@ximian.com>
15131 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
15132 inaccessible types. Fixes #36313.
15134 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
15136 * namespace.cs (NamespaceEntry): Create implicit entries for all
15137 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
15138 implicit entries for N1.N2 and N1.
15140 2003-07-08 Martin Baulig <martin@ximian.com>
15142 Rewrote the handling of namespaces to fix a lot of the issues
15143 wrt. `using' aliases etc.
15145 * namespace.cs (Namespace): Splitted this class into a
15146 per-assembly `Namespace' and a per-file `NamespaceEntry'.
15148 * typemanager.cs (TypeManager.IsNamespace): Removed.
15149 (TypeManager.ComputeNamespaces): Only compute namespaces from
15150 loaded assemblies here, not the namespaces from the assembly we're
15151 currently compiling.
15153 2003-07-08 Martin Baulig <martin@ximian.com>
15155 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
15157 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15159 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
15162 I thought about the memory savings here, but LookupTypeReflection
15163 is used under already very constrained scenarios. Compiling
15164 corlib or mcs only exposes one hit, so it would not really reduce
15165 any memory consumption.
15167 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15169 * typemanager.cs: fixes bug #45889 by only adding public types from
15170 other assemblies to the list of known types.
15172 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15174 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
15175 on the type we resolved.
15177 2003-07-05 Martin Baulig <martin@ximian.com>
15179 * pending.cs (PendingImplementation.ParentImplements): Don't
15180 create the proxy if the parent is abstract.
15182 * class.cs (TypeContainer.DefineIndexers): Process explicit
15183 interface implementations first. Fixes #37714.
15185 2003-07-04 Miguel de Icaza <miguel@ximian.com>
15187 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
15188 defined recursively; but since we modify the input parameters
15189 (left is set to `this' temporarily), we reset this value if the
15190 left_is_explicit is false, which gives the original semantics to
15193 * literal.cs (NullPointer): new class used to represent a null
15194 literal in a pointer context.
15196 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
15197 type is a pointer, use a NullPointer object instead of a
15198 NullLiteral. Closes 43687
15200 (ExplicitConversion): Convert pointer values using
15201 the conv opcode to the proper type.
15203 * ecore.cs (New): change ValueTypeVariable property into a method,
15204 that returns whether the valuetype is suitable for being used.
15206 * expression.cs (Binary.DoNumericPromotions): Only return if we
15207 the int constant was a valid uint, and we can return both left and
15208 right as uints. If not, we continue processing, to trigger the
15209 type conversion. This fixes 39018.
15211 * statement.cs (Block.EmitMeta): During constant resolution, set
15212 the CurrentBlock property on the emitcontext, so that we resolve
15213 constants propertly.
15215 2003-07-02 Martin Baulig <martin@ximian.com>
15217 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
15218 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
15220 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
15221 than emitting it here.
15223 * statement.cs: Fixed some more flow analysis bugs.
15225 2003-07-02 Martin Baulig <martin@ximian.com>
15227 * class.cs (MethodData.Define): When implementing interface
15228 methods, set Final unless we're Virtual.
15230 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
15231 check work for interface methods.
15233 2003-07-01 Martin Baulig <martin@ximian.com>
15235 * ecore.cs (EmitContext.This): Replaced this property with a
15236 GetThis() method which takes a Location argument. This ensures
15237 that we get the correct error location for a CS0188.
15239 2003-07-01 Miguel de Icaza <miguel@ximian.com>
15241 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
15242 ImplicitStandardConversion.
15244 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
15246 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
15248 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
15251 2003-06-30 Miguel de Icaza <miguel@ximian.com>
15253 * class.cs (Constructor.Define): Turn off initlocals for unsafe
15256 (MethodData.Define): Turn off initlocals for unsafe methods.
15258 2003-06-29 Miguel de Icaza <miguel@ximian.com>
15260 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
15261 complete; Fixes #37521.
15263 * delegate.cs: Use Modifiers.TypeAttr to compute the
15264 TypeAttributes, instead of rolling our own. This makes the flags
15265 correct for the delegates.
15267 2003-06-28 Miguel de Icaza <miguel@ximian.com>
15269 * class.cs (Constructor.Define): Set the private flag for static
15270 constructors as well.
15272 * cs-parser.jay (statement_expression): Set the return value to
15273 null, to avoid a crash when we catch an error.
15275 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15277 * cs-parser.jay: Applied patch from Jackson that adds support for
15278 extern and unsafe modifiers to destructor declarations.
15280 * expression.cs: Report error 21 if the user is trying to index a
15283 * driver.cs: Add an error message, suggested by the bug report.
15285 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15286 if we do not have a ": this ()" constructor initializer. Fixes 45149
15288 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15290 * namespace.cs: Add some information to reduce FAQs.
15292 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15294 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15295 underlying enumeration types. Fixes #43915.
15297 * expression.cs: Treat ushort/short as legal values to be used in
15298 bitwise operations.
15300 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15302 * delegate.cs: transfer custom attributes for paramenters from
15303 the delegate declaration to Invoke and BeginInvoke.
15305 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15307 * attribute.cs: handle custom marshalers and emit marshal info
15310 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15312 * makefile.gnu: Added anonymous.cs to the compiler sources.
15314 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15316 * iterators.cs: Change the name of the proxy class to include two
15319 * cs-parser.jay: Update grammar to include anonymous methods.
15321 * anonymous.cs: new file.
15323 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15325 * class.cs (Field.Define): Add missing test for pointers and
15328 2003-05-27 Ravi Pratap <ravi@ximian.com>
15330 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15331 we use the stobj opcode.
15333 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15334 since it wasn't the correct fix.
15336 It still is puzzling that we are required to use stobj for IntPtr
15337 which seems to be a ValueType.
15339 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15341 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15342 during regular simple name resolution. Now, the trick is that
15343 instead of returning for processing the simplename, we do a
15344 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15345 contextual lookup type). If a match is found, return that, if
15346 not, return for further composition.
15348 This fixes long-standing 30485.
15350 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15351 using the address to initialize an object, do an Stobj instead of
15352 using the regular Stelem.
15354 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15355 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15356 Because if we are a BaseIndexerAccess that value will be true.
15359 * statement.cs (GotoCase.Resolve): Return after reporting an
15360 error, do not attempt to continue.
15362 * expression.cs (PointerArithmetic.Emit): If our operand is a
15363 long, convert our constants to match the operand before
15364 multiplying. Convert to I type before adding. Fixes 43670.
15366 2003-05-14 Ravi Pratap <ravi@ximian.com>
15368 * enum.cs (ImplicitConversionExists) : Rename to
15369 ImplicitEnumConversionExists to remove ambiguity.
15371 * ecore.cs (NullCast): New type of cast expression class which
15372 basically is very similar to EmptyCast with the difference being
15373 it still is a constant since it is used only to cast a null to
15375 (eg. (string) null)
15377 * convert.cs (ImplicitReferenceConversion): When casting a null
15378 literal, we return a NullCast.
15380 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15381 should be around anymore.
15383 The renaming (reported was slightly wrong). Corrections:
15385 ConvertImplicitStandard -> ImplicitConversionStandard
15386 ConvertExplicitStandard -> ExplicitConversionStandard
15388 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15389 before passing them in !
15391 * convert.cs (ImplicitConversionStandard): When comparing for
15392 equal expr and target types, ensure that expr is not a
15395 In general, we must not be checking (expr_type ==
15396 target_type) in the top level conversion methods
15397 (ImplicitConversion, ExplicitConversion etc). This checking is
15398 done in the methods that they delegate to.
15400 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15402 * convert.cs: Move Error_CannotConvertType,
15403 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15404 ImplicitNumericConversion, ImplicitConversionExists,
15405 ImplicitUserConversionExists, StandardConversionExists,
15406 FindMostEncompassedType, FindMostSpecificSource,
15407 FindMostSpecificTarget, ImplicitUserConversion,
15408 ExplicitUserConversion, GetConversionOperators,
15409 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15410 TryImplicitIntConversion, Error_CannotConvertImplicit,
15411 ConvertImplicitRequired, ConvertNumericExplicit,
15412 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15413 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15416 Perform the following renames:
15418 StandardConversionExists -> ImplicitStandardConversionExists
15419 ConvertImplicit -> ImplicitConversion
15420 ConvertImplicitStandard -> ImplicitStandardConversion
15421 TryImplicitIntConversion -> ImplicitIntConversion
15422 ConvertImplicitRequired -> ImplicitConversionRequired
15423 ConvertNumericExplicit -> ExplicitNumericConversion
15424 ConvertReferenceExplicit -> ExplicitReferenceConversion
15425 ConvertExplicit -> ExplicitConversion
15426 ConvertExplicitStandard -> ExplicitStandardConversion
15428 2003-05-19 Martin Baulig <martin@ximian.com>
15430 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15431 (TypeInfo): Added support for structs having structs as fields.
15433 * ecore.cs (FieldExpr): Implement IVariable.
15434 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15435 VariableInfo for the field.
15437 2003-05-18 Martin Baulig <martin@ximian.com>
15439 * expression.cs (This.DoResolve): Report a CS0027 if we're
15440 emitting a field initializer.
15442 2003-05-18 Martin Baulig <martin@ximian.com>
15444 * expression.cs (This.ResolveBase): New public function.
15445 (This.DoResolve): Check for CS0188.
15447 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15450 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15451 `instance_expression' to null if we don't have any non-static
15454 2003-05-18 Martin Baulig <martin@ximian.com>
15456 Reworked the way how local variables and parameters are handled by
15457 the flow analysis code.
15459 * statement.cs (TypeInfo, VariableMap): New public classes.
15460 (VariableInfo): New public class. This is now responsible for
15461 checking whether a variable has been assigned. It is used for
15462 parameters and local variables.
15463 (Block.EmitMeta): Take the InternalParameters as argument; compute
15464 the layout of the flow vectors here.
15465 (Block.LocalMap, Block.ParameterMap): New public properties.
15466 (FlowBranching): The .ctor doesn't get the InternalParameters
15467 anymore since Block.EmitMeta() now computes the layout of the flow
15469 (MyStructInfo): This class is now known as `StructInfo' and nested
15470 in `TypeInfo'; we don't access this directly anymore.
15472 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15473 property and removed IsAssigned(), IsFieldAssigned(),
15474 SetAssigned() and SetFieldAssigned(); we now call them on the
15475 VariableInfo so we don't need to duplicate this code everywhere.
15477 * expression.cs (ParameterReference): Added `Block block' argument
15479 (LocalVariableReference, ParameterReference, This): The new
15480 VariableInfo class is now responsible for all the definite
15483 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15484 IsParameterAssigned, SetParameterAssigned): Removed.
15486 2003-05-18 Martin Baulig <martin@ximian.com>
15488 * typemanager.cs (InitCoreTypes): Try calling
15489 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15490 the 3-args-version. Corlib now also needs our `void_type'.
15491 (GetMethod): Added overloaded version which takes an optional
15492 `bool report_errors' to allow lookups of optional methods.
15494 2003-05-12 Martin Baulig <martin@ximian.com>
15496 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15497 only used for locals and not for parameters.
15499 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15501 * support.cs (InternalParameters.ParameterType): Return the
15502 ExternalType of the parameter.
15504 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15507 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15509 * class.cs (MethodData.Define): Do not set the `newslot' on
15510 interface members, if they are also flagged as "override".
15512 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15513 better code for ++i and i++. This only works for static fields
15514 and local variables.
15516 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15517 want to pull the DeclSpace out of the builder_to_declspace instead
15518 of the TypeBuilder (like in TypeContainer.FindMembers).
15520 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15521 instead of LookupTypeContainer. Fixes the crash on .NET for
15522 looking up interface members.
15524 * const.cs: Create our own emit context during the Definition
15525 stage, so that constants are evaluated in the proper context, when
15526 a recursive definition happens.
15528 2003-05-11 Martin Baulig <martin@ximian.com>
15530 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15531 new block for a switch section.
15532 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15533 the adding/lookup in the switch block. Fixes #39828.
15535 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15537 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15538 functionality: I needed to convert the data after I had performed
15539 the add/sub operation into the operands type size.
15541 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15542 pass the type for the box operation, otherwise the resulting
15543 object would have been of type object.
15545 (BoxedCast): Add constructor to specify the type to box as.
15547 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15549 * iterators.cs: I was reusing the `count' variable inadvertently,
15550 take steps to not allow this to happen.
15552 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15554 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15555 by creating an array at the point where the params starts and
15556 putting all those arguments there, then adjusting the size of the
15559 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15561 * expression.cs (New.AddressOf): Implement interface
15562 IMemoryLocation. This is used when the `new' operator is used in
15563 the context of an invocation to a method on a value type.
15565 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15568 * namespace.cs: Also check the using aliases here.
15570 * driver.cs: Move the test for using validity after the types have
15571 been entered, so we do a single pass that also includes the using
15574 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15575 in the regular case. CreateSiblingForFinally is doing extra
15578 * attribute.cs (GetAttributeArgumentExpression): Store the result
15579 on an out value, and use the return value to indicate failure
15580 instead of using null (which is a valid return for Constant.GetValue).
15582 * statement.cs: Perform the analysis flow for the increment
15583 portion after the statement, because this will be the real flow of
15584 execution. Fixes #42385
15586 * codegen.cs (EmitContext.EmitArgument,
15587 EmitContext.EmitStoreArgument): New helper functions when the
15588 RemapToProxy flag is set.
15590 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15593 Add support for remapping parameters.
15595 * iterators.cs: Propagate parameter values; Store parameter
15596 values in the proxy classes.
15598 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15600 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15601 need a proxy reference; I do not know what I was thinking
15603 * cs-parser.jay (constructor_initializer): catch another error,
15604 and display nice message.
15606 (field_declaration): catch void field declaration
15607 to flag a better error.
15609 * class.cs (MemberBase.CheckBase): Report an error instead of a
15610 warning if a new protected member is declared in a struct.
15611 (Field.Define): catch the error of readonly/volatile.
15613 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15615 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15616 volatile variable is taken
15618 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15620 * statement.cs (Fixed.Resolve): Report an error if we are not in
15623 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15625 * typemanager.cs: reuse the code that handles type clashes for
15626 delegates and enumerations.
15628 * class.cs (Report28): Always report.
15630 * expression.cs (EncodeAsAttribute): Allow nulls here.
15632 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15634 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15635 the functionality for testing whether an expression is valid for
15636 an attribute here. Also handle the case of arrays of elements
15639 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15640 encoding a linear array into an array of objects that are suitable
15641 to be passed to an CustomAttributeBuilder.
15643 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15645 * ecore.cs: (FieldExpr): Handle field remapping here.
15647 * iteratators.cs: Pass the instance variable (if the method is an
15648 instance method) to the constructors, so we can access the field
15649 variables on the class.
15651 TODO: Test this with structs. I think the THIS variable on
15652 structs might have to be a pointer, and not a refenrece
15654 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15656 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15657 local variables to fields in a proxy class.
15659 * iterators.cs (PopulateProxy): Rename our internal fields to
15661 Create a <THIS> field if we are an instance method, so we can
15662 reference our parent container variables.
15663 (MapVariable): Called back from the EmitContext code to enter a
15664 new variable to field mapping into the proxy class (we just create
15668 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15669 for using the remapped locals to fields.
15671 I placed the code here, because that gives the same semantics to
15672 local variables, and only changes the Emit code.
15674 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15675 statements inside iterators.
15676 (VariableInfo): Add a FieldBuilder for the cases when we are
15677 remapping local variables to fields in a proxy class
15679 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15680 current_block != null.
15682 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15683 not cope with strings, as it has been moved to the
15684 TableSwitchEmit. Fixed bug in switch generation.
15686 * expression.cs (New.DoResolve): Provide more context for the user
15687 when reporting an error.
15689 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15692 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15693 check the permissions for it. Note than in a type-resolution
15694 context the check was already present in DeclSpace.ResolveType,
15695 but was missing from the MemberAccess.
15697 (ArrayCreation.CheckIndices): warn if the user has
15698 more nested levels of expressions, but there are no more
15699 dimensions specified. Avoids crash on bug 41906.
15701 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15703 * statement.cs (Block): replace Implicit bool, for a generic
15705 New flag: `Unchecked'. This is used during the EmitMeta phase
15706 (which is out-of-line with the regular Resolve/Emit process for a
15707 statement, as this is done ahead of time, but still gets a chance
15708 to call constant resolve).
15710 (Block.Flags): new enum for adding a new flag.
15712 (Block.EmitMeta): track the state of unchecked.
15714 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15715 to enable constant resolution to work there as well.
15717 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15719 * typemanager.cs (ienumerable_type): Also look up
15720 System.Collections.IEnumerable.
15722 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15724 TODO: Test more than one conditional per method.
15726 * class.cs (Indexer.Define): Report the location where the user is
15727 referencing the unsupported feature.
15729 (MethodData): Overload the use of `conditionals' to
15730 minimize the creation of needless ArrayLists. This saves roughly
15731 212kb on my machine.
15733 (Method): Implement the new IIteratorContainer interface.
15734 (Method.SetYields): Implement the method by setting the ModFlags
15735 to contain METHOD_YIELDS.
15737 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15738 which just got set to null.
15740 * iterators.cs: New file.
15742 (Yield, YieldBreak): New statements.
15744 * statement.cs (Return.Resolve): Flag an error if we are used in
15745 an iterator method.
15747 * codegen.cs (InIterator): New flag set if the code is being
15748 compiled in an iterator method.
15750 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15751 internal modifier, and we just use it to avoid adding extra
15752 fields, as this is seldom used.
15754 * cs-parser.jay: Add yield_statement (yield and yield break).
15756 * driver.cs: New flag -v2 to turn on version 2 features.
15758 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15759 hashtable when v2 is enabled.
15761 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15763 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15764 there is already a namespace defined with this name.
15766 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15767 people upgraded their corlibs.
15769 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15770 always use fully qualified types, no need to use the compiler
15773 (TypeManager.IsNamespace): Use binarysearch.
15775 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15776 AddDelegate): I did not quite use the new IsValid API properly: I
15777 have to pass the short-name and the fullname. I was passing only
15778 the basename instead of the fullname sometimes.
15780 (TypeContainer.DefineType): call NamespaceClash.
15782 * interface.cs (Interface.DefineType): use NamespaceClash before
15785 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15788 * enum.cs: (Enum.DefineType): use NamespaceClash before
15791 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15792 speed increase. First, use the negative_hits cache when we get a
15793 negative. Second, add the type with its full original name
15794 instead of the new . and + encoded name (reflection uses + to
15795 separate type from a nested type). Use LookupTypeReflection
15796 directly which bypasses the type->name hashtable (that we already
15797 know does not contain the type.
15799 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15800 location/container type.
15802 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15804 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15806 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15808 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15809 method is being referenced in the method group from a static
15810 context, and report error 120 if so.
15812 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15815 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15816 is created, we create the A namespace).
15818 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15821 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15823 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15824 invocation to ModuleBuilder.GetType with the same values will
15825 return a new type instance, so we need to cache its return
15828 * expression.cs (Binary.ResolveOperator): Only allow the compare
15829 operators on enums if they are of the same type.
15831 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15832 types of ValueType on their own case. Before we were giving them
15833 the same treatment as objects.
15835 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15836 fullname. Short name is used to compare against container name.
15837 Fullname is used to check against defined namespace names.
15839 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15840 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15842 (Method.CheckBase): Call parent.
15843 (MemberBase.CheckBase): Check for protected members on sealed
15845 (PropertyBase.CheckBase): Call parent.
15846 (Field.Define): Call parent.
15848 * report.cs: Negative error codes are now mapped to 8000 - code,
15849 so that the display is render more nicely.
15851 * typemanager.cs: Do not use try/catch, instead report a regular
15854 (GetPointerType, GetReferenceType): These methods provide
15855 mechanisms to obtain the T* and T& from a T. We had the code
15856 previously scattered around the code base, and it also used
15857 TypeManager.LookupType that would go through plenty of caches.
15858 This one goes directly to the type source.
15860 In some places we did the Type.GetType followed by
15861 ModuleBuilder.GetType, but not in others, so this unifies the
15862 processing as well.
15864 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15865 statements now that we have namespace information.
15867 * typemanager.cs (IsNamespace): New method, returns whether the
15868 string presented is a namespace or not.
15870 (ComputeNamespaces): New public entry point, computes the list of
15871 available namespaces, using the GetNamespaces API call in Mono, or
15872 the slower version in MS.NET.
15874 Now before we start the semantic analysis phase, we have a
15875 complete list of namespaces including everything that the user has
15878 Deleted old code to cache namespaces in .nsc files.
15880 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15882 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15883 class/struct location definition Location for the implicit
15884 constructor location.
15886 (Operator.Define): Use the location of the operator for the
15887 implicit Method definition.
15889 (Constructor.Emit): use the constructor location for the implicit
15890 base initializer constructor.
15892 * ecore.cs: Remove ITypeExpression. This interface is now gone,
15893 and the Expression class now contains two new methods:
15895 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
15896 isolate type lookup from the rest of the resolution process.
15898 Since we use Expressions to hold type definitions due to the way
15899 we parse the input we have historically overloaded Resolve to
15900 perform the Type lookups if a special flag is passed. Now this is
15901 eliminated and two methods take their place.
15903 The differences in the two methods between xStep and xTerminal is
15904 that xStep is involved in our current lookup system that uses
15905 SimpleNames to compose a name, while xTerminal is used just to
15906 catch the case where the simplename lookup failed.
15908 2003-04-16 Miguel de Icaza <miguel@ximian.com>
15910 * expression.cs (ResolveMemberAccess): Remove redundant code.
15911 TypeExpr expressions are always born fully resolved.
15913 * interface.cs (PopulateMethod): Do not lookup the types twice.
15914 We were doing it once during SemanticAnalysis and once during
15917 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
15918 in local variable type definitions, were being returned as a
15919 SimpleName (we decomposed everything into a string), that is
15920 because primary_expression was being used instead of a type in the
15921 grammar (reduce/reduce conflicts).
15923 The part that was wrong is that we converted the expression into a
15924 string (an oversimplification in one hand, compounded with primary
15925 expressions doing string concatenation).
15931 Would return "A.B.C[]" as a SimpleName. This stopped things like
15932 using clauses from working on this particular context. And a type
15933 was being matched directly against "A.B.C[]".
15935 We now use the correct approach, and allow for ComposedCast to be
15936 part of the unary expression. So the "A.B.C []" become a composed
15937 cast of "A.B.C" (as a nested group of MemberAccess with a
15938 SimpleName at the end) plus the rank composition "[]".
15942 2003-04-10 Miguel de Icaza <miguel@ximian.com>
15944 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
15945 for the access level checking.
15947 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
15948 `TypeContainer container', because I kept getting confused when I
15949 was debugging this code.
15951 * expression.cs (Indexers): Instead of tracking getters/setters,
15952 we now track them in parallel. We create one arraylist less, but
15953 most importantly it is possible now for the LValue code to find a
15954 matching get for a set.
15956 (IndexerAccess.DoResolveLValue): Update the code.
15957 GetIndexersForType has been modified already to extract all the
15958 indexers from a type. The code assumed it did not.
15960 Also make the code set the correct return type for the indexer.
15961 This was fixed a long time ago for properties, but was missing for
15962 indexers. It used to be void_type.
15964 (Binary.Emit): Test first for doubles instead of
15965 floats, as they are more common.
15967 (Binary.EmitBranchable): Use the .un version of the branch opcodes
15968 when dealing with floats and the <=, >= operators. This fixes bug
15971 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
15972 to load the array value by emitting a load on the foreach variable
15973 type. This was incorrect.
15975 We now emit the code to load an element using the the array
15976 variable type, and then we emit the conversion operator.
15980 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
15982 * attribute.cs: Avoid allocation of ArrayLists in the common case.
15984 2003-04-09 Miguel de Icaza <miguel@ximian.com>
15986 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
15987 test for protection before we test for signatures.
15989 (MethodSignature.ToString): implement.
15991 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
15992 to the case where we reduced into a LongConstant.
15994 * decl.cs (CheckAccessLevel): If the type is an array, we can not
15995 depend on whether the information is acurrate, because the
15996 Microsoft runtime will always claim that the array type is public,
15997 regardless of the real state.
15999 If the type is a pointer, another problem happens: the type is
16000 reported as non-public in Microsoft.
16002 In both cases we have to call CheckAccessLevel recursively with
16003 the underlying type as the argument to be tested.
16005 2003-04-08 Miguel de Icaza <miguel@ximian.com>
16007 * assign.cs (Assign.Emit): If we are dealing with a compound
16008 assignment expression, we should use the code path that stores the
16009 intermediate result in a temporary value. This fixes #40903.
16011 *expression.cs (Indirection.ToString): Provide ToString method for
16014 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
16016 * class.cs: Null out fields holding references to Block objects so
16017 they can be garbage collected.
16019 * expression.cs (OverloadResolve): Remove unused local.
16021 2003-04-07 Martin Baulig <martin@ximian.com>
16023 * codegen.cs (EmitContext.CurrentFile): New public field.
16024 (EmitContext.Mark): Use the CurrentFile to check whether the
16025 location is in the correct file.
16026 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
16028 2003-04-07 Martin Baulig <martin@ximian.com>
16030 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
16032 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
16033 location. [FIXME: The location argument which gets passed to this
16034 method is sometimes wrong!]
16036 2003-04-07 Nick Drochak <ndrochak@gol.com>
16038 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
16040 2003-04-07 Miguel de Icaza <miguel@ximian.com>
16042 * expression.cs (Indirection.EmitAssign): We were using the
16043 temporary, but returning immediately instead of continuing the
16046 2003-04-06 Martin Baulig <martin@ximian.com>
16048 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
16049 if it's a nested child, but also deriving from the outer class.
16052 * typemanager.cs (IsNestedChildOf): Make this work if it's a
16053 nested child, but also deriving from the outer class. See
16055 (FilterWithClosure): We may access private members of the outer
16056 class if we're a nested child and deriving from the outer class.
16057 (RealMemberLookup): Only set `closure_private_ok' if the
16058 `original_bf' contained BindingFlags.NonPublic.
16060 2003-04-05 Martin Baulig <martin@ximian.com>
16062 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
16063 probe if its a type parameter, and if so, flag an error.
16065 * decl.cs: Move here the SetParameterInfo code from class.cs.
16066 Handle IsGeneric here.
16068 Handle a variety of errors in the parameter info definition.
16070 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
16071 type parameters here.
16073 * cs-parser.jay (class_declaration): report errors for parameters
16076 2003-01-21 Miguel de Icaza <miguel@ximian.com>
16078 * generic.cs: New file, contains support code for generics.
16080 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
16081 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
16083 Update parser for the above removals.
16085 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
16086 now taken care of in the parser.
16088 2003-04-02 Miguel de Icaza <miguel@ximian.com>
16090 * class.cs (Event.Define): Do not allow abstract events to have
16093 2003-04-01 Miguel de Icaza <miguel@ximian.com>
16095 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
16096 block in event declarations.
16098 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
16099 value type, get its address.
16101 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
16102 leaving a class on the stack instead of a boolean value (int
16103 0/1). Change the code so we compare against null, and then the
16104 result against zero.
16106 * class.cs (TypeContainer.GetClassBases): We were checking for the
16107 parent class being sealed too late.
16109 * expression.cs (Binary.Emit): For <= and >= when dealing with
16110 floating point values, use cgt.un and clt.un instead of cgt and
16113 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
16115 * statement.cs: Apply the same optimization as MS: skip the
16116 GetEnumerator returning an IEnumerator, and use the one returning a
16117 CharEnumerator instead. This allows us to avoid the try-finally block
16120 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
16122 * cs-parser.jay: Attributes cannot be applied to
16123 namespaces. Fixes #40473
16125 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16128 (Add*): check if the name is valid using the full name for constants,
16129 fields, properties and events.
16131 2003-03-28 Miguel de Icaza <miguel@ximian.com>
16133 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
16134 char constants to be part of the enumeration.
16136 * expression.cs (Conditional.DoResolve): Add support for operator
16137 true. Implements the missing functionality from 14.12
16139 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
16140 operator true/false as required by the spec.
16142 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
16143 implicit conversion to boolean.
16145 * statement.cs (Statement.ResolveBoolean): A boolean expression is
16146 also one where the type implements `operator true'.
16148 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
16149 get an expression that will invoke operator true based on an
16152 (GetConversionOperators): Removed the hack that called op_True
16155 (Expression.ResolveBoolean): Move this from Statement.
16157 2003-03-17 Miguel de Icaza <miguel@ximian.com>
16159 * ecore.cs (FieldExpr): do not allow initialization of initonly
16160 fields on derived classes
16162 2003-03-13 Martin Baulig <martin@ximian.com>
16164 * statement.cs (Block.Emit): Call ig.BeginScope() and
16165 ig.EndScope() when compiling with debugging info; call
16166 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
16168 2003-03-08 Miguel de Icaza <miguel@ximian.com>
16170 * expression.cs (Indexers): Do not construct immediately, allow
16171 for new members to be appended as we go. Fixes 38143
16173 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16175 * expression.cs: save/restore context when resolving an unchecked
16178 2003-03-05 Miguel de Icaza <miguel@ximian.com>
16180 * cfold.cs: Catch division by zero in modulus operator during
16183 2003-03-03 Miguel de Icaza <miguel@ximian.com>
16185 * interface.cs (Interface.DefineMembers): Avoid defining members
16188 2003-02-27 Miguel de Icaza <miguel@ximian.com>
16190 * driver.cs: handle the +/- options for -noconfig
16192 * statement.cs (Unckeched.Resolve): Also track the state of
16193 unchecked in the Resolve phase.
16195 2003-02-27 Martin Baulig <martin@ximian.com>
16197 * ecore.cs (Expression.MemberLookup): Don't create a
16198 MethodGroupExpr for something which is not a method. Fixes #38291.
16200 2003-02-25 Miguel de Icaza <miguel@ximian.com>
16202 * class.cs (MemberBase.CheckParameters): Also check that the type
16203 is unmanaged if it is a pointer.
16205 * expression.cs (SizeOf.Resolve): Add location information.
16207 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
16208 a managed type is declared.
16210 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
16211 parameter modifiers as well. Fixes bug 38606
16213 * class.cs: Very sad. Am backing out the speed up changes
16214 introduced by the ArrayList -> Array in the TypeContainer, as they
16215 were not actually that much faster, and introduced a bug (no error
16216 reports on duplicated methods).
16218 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
16219 source first, this will guarantee that we have a valid expression
16220 before calling in lower levels functions that will require a
16221 resolved object. Then use this original_source in the
16222 target.ResolveLValue instead of the original source that was
16225 Another change. Use target.Resolve instead of LValueResolve.
16226 Although we are resolving for LValues, we will let the Assign code
16227 take care of that (it will be called again from Resolve). This
16228 basically allows code like this:
16230 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
16231 class Y { void A (X x) { x [0] += o; }
16233 The problem was that the indexer was trying to resolve for
16234 set_Item (idx, object o) and never finding one. The real set_Item
16235 was set_Item (idx, X). By delaying the process we get the right
16240 2003-02-23 Martin Baulig <martin@ximian.com>
16242 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
16243 while calling DoEmit ().
16245 * codegen.cs (EmitContext.Mark): Don't mark locations in other
16246 source files; if you use the #line directive inside a method, the
16247 compiler stops emitting line numbers for the debugger until it
16248 reaches the end of the method or another #line directive which
16249 restores the original file.
16251 2003-02-23 Martin Baulig <martin@ximian.com>
16253 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
16255 2003-02-23 Martin Baulig <martin@ximian.com>
16257 * statement.cs (Block.AddChildVariableNames): We need to call this
16258 recursively, not just for our immediate children.
16260 2003-02-23 Martin Baulig <martin@ximian.com>
16262 * class.cs (Event.Define): Always make the field private, like csc does.
16264 * typemanager.cs (TypeManager.RealMemberLookup): Make events
16265 actually work, fixes bug #37521.
16267 2003-02-23 Miguel de Icaza <miguel@ximian.com>
16269 * delegate.cs: When creating the various temporary "Parameters"
16270 classes, make sure that we call the ComputeAndDefineParameterTypes
16271 on those new parameters (just like we do with the formal ones), to
16272 allow them to be resolved in the context of the DeclSpace.
16274 This fixes the bug that Dick observed in Bugzilla #38530.
16276 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16278 * expression.cs (ResolveMemberAccess): When resolving a constant,
16279 do not attempt to pull a constant if the value was not able to
16280 generate a valid constant.
16282 * const.cs (LookupConstantValue): Do not report more errors than required.
16284 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16286 * expression.cs: fixes bug #38328.
16288 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16290 * class.cs: Changed all the various members that can be part of a
16291 class from being an ArrayList to be an Array of the right type.
16292 During the DefineType type_list, interface_list, delegate_list and
16293 enum_list are turned into types, interfaces, delegates and enums
16296 And during the member population, indexer_list, event_list,
16297 constant_list, field_list, instance_constructor_list, method_list,
16298 operator_list and property_list are turned into their real arrays.
16300 Although we could probably perform this operation earlier, for
16301 good error reporting we need to keep the lists and remove the
16302 lists for longer than required.
16304 This optimization was triggered by Paolo profiling the compiler
16305 speed on the output of `gen-sample-program.pl' perl script.
16307 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16308 not crash in methods like MemberLookupFailed that use this field.
16310 This problem arises when the compiler fails to resolve a type
16311 during interface type definition for example.
16313 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16315 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16316 inherit from System.Object, so we have to stop at null, not only
16317 when reaching System.Object.
16319 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16321 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16322 DeclaredOnly because the parent indexer might have had a different
16323 name, but did not loop until the top of the hierarchy was reached.
16325 The problem this one fixes is 35492: when a class implemented an
16326 indexer from an interface, we were getting the interface method
16327 (which was abstract) and we were flagging an error (can not invoke
16330 This also keeps bug 33089 functioning, and test-148 functioning.
16332 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16333 out if a method is special is to see if it is declared in a
16334 property or event, or whether it is one of the predefined operator
16335 names. This should fix correctly #36804.
16337 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16339 The goal here is to remove the dependency on EmptyCast.Peel ().
16340 Killing it completely.
16342 The problem is that currently in a number of places where
16343 constants are expected, we have to "probe" for an EmptyCast, and
16344 Peel, which is not the correct thing to do, as this will be
16345 repetitive and will likely lead to errors.
16347 The idea is to remove any EmptyCasts that are used in casts that
16348 can be reduced to constants, so we only have to cope with
16351 This bug hunt was triggered by Bug 37363 and the desire to remove
16352 the duplicate pattern where we were "peeling" emptycasts to check
16353 whether they were constants. Now constants will always be
16356 * ecore.cs: Use an enumconstant here instead of wrapping with
16359 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16360 throwing me off. By handling this we can get rid of a few hacks.
16362 * statement.cs (Switch): Removed Peel() code.
16364 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16366 * class.cs: Location information for error 508
16368 * expression.cs (New.DoResolve): Add a guard against double
16369 resolution of an expression.
16371 The New DoResolve might be called twice when initializing field
16372 expressions (see EmitFieldInitializers, the call to
16373 GetInitializerExpression will perform a resolve on the expression,
16374 and later the assign will trigger another resolution
16376 This leads to bugs (#37014)
16378 * delegate.cs: The signature for EndInvoke should contain any ref
16379 or out parameters as well. We were not doing this in the past.
16381 * class.cs (Field.Define): Do not overwrite the type definition
16382 inside the `volatile' group. Turns out that volatile enumerations
16383 were changing the type here to perform a validity test, which
16386 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16388 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16389 and structs, we do not want to load the instance variable
16391 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16392 enum_type has to be handled like an object reference (implicit
16393 conversions exists from this to object), but the regular IsClass
16394 and IsValueType tests will never return true for this one.
16396 Also we use TypeManager.IsValueType instead of type.IsValueType,
16397 just for consistency with the rest of the code (this is only
16398 needed if we ever use the construct exposed by test-180.cs inside
16399 corlib, which we dont today).
16401 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16403 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16406 2003-02-09 Martin Baulig <martin@ximian.com>
16408 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16409 (Namespace.DefineNamespaces): New static public method; this is
16410 called when we're compiling with debugging to add all namespaces
16411 to the symbol file.
16413 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16414 pass it to the Namespace's .ctor.
16416 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16417 and MethodBase arguments; pass the namespace ID to the symwriter;
16418 pass the MethodBase instead of the token to the symwriter.
16419 (SymbolWriter.DefineNamespace): New method to add a namespace to
16422 2003-02-09 Martin Baulig <martin@ximian.com>
16424 * symbolwriter.cs: New file. This is a wrapper around
16425 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16426 methods here in near future.
16428 2003-02-09 Martin Baulig <martin@ximian.com>
16430 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16431 ILGenerator.MarkSequencePoint() which are actually used by the
16434 2003-02-09 Martin Baulig <martin@ximian.com>
16436 * location.cs (SourceFile): New public sealed class. This
16437 contains the name and an index which is used in the location's token.
16438 (Location): Reserve an appropriate number of bits in the token for
16439 the source file instead of walking over that list, this gives us a
16440 really huge performance improvement when compiling with debugging.
16442 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16443 `SourceFile' argument instead of a string.
16444 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16445 but don't parse/tokenize here, we need to generate the list of all
16446 source files before we do that.
16447 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16450 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16451 instead of a string.
16453 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16456 2003-02-09 Martin Baulig <martin@ximian.com>
16458 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16459 filename on `#line default'.
16461 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16463 * statement.cs: don't clear the pinned var when the fixed statement
16464 returns from the method (fixes bug#37752).
16466 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16468 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16471 2003-02-07 Martin Baulig <martin@ximian.com>
16473 * driver.cs: Removed the `--debug-args' command line argument.
16475 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16476 automatically by the AsssemblyBuilder.
16477 (CodeGen.InitializeSymbolWriter): We don't need to call any
16478 initialization function on the symbol writer anymore. This method
16479 doesn't take any arguments.
16481 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16483 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16484 from referenced assemblies as well.
16486 2003-02-02 Martin Baulig <martin@ximian.com>
16488 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16490 2003-02-02 Martin Baulig <martin@ximian.com>
16492 * class.cs (Constructor.Emit): Open the symbol writer before
16493 emitting the constructor initializer.
16494 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16495 single-stepping through constructor initializers.
16497 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16499 * class.cs: Handle error 549: do not allow virtual methods in
16502 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16504 * decl.cs: Check access levels when resolving types
16506 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16508 * statement.cs: Add parameters and locals set in catch blocks that might
16509 return to set vector
16511 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16513 * class.cs (Operator): Set the SpecialName flags for operators.
16515 * expression.cs (Invocation.DoResolve): Only block calls to
16516 accessors and operators on SpecialName methods.
16518 (Cast.TryReduce): Handle conversions from char constants.
16521 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16523 * statement.cs: small memory and time optimization in FlowBranching.
16525 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16527 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16528 problem that the last fix but in the other sid (Set).
16530 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16531 access when there is no indexer in the hierarchy.
16533 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16535 * class.cs: Combine some if statements.
16537 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16539 * driver.cs: fixed bug #37187.
16541 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16543 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16544 any indexer, it's needed to build a list with all the indexers in the
16545 hierarchy (AllGetters), else we have problems. Fixes #35653.
16547 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16549 * class.cs (MethodData.Define): It is wrong for an interface
16550 implementation to be static in both cases: explicit and implicit.
16551 We were only handling this in one case.
16553 Improve the if situation there to not have negations.
16555 * class.cs (Field.Define): Turns out that we do not need to check
16556 the unsafe bit on field definition, only on usage. Remove the test.
16558 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16560 * driver.cs: use assembly.Location instead of Codebase (the latest
16561 patch made mcs fail when using MS assemblies).
16563 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16565 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16566 get the path to *corlib.dll.
16568 2003-01-21 Nick Drochak <ndrochak@gol.com>
16572 * typemanager.cs: Remove compiler warnings
16574 2003-01-20 Duncan Mak <duncan@ximian.com>
16576 * AssemblyInfo.cs: Bump the version number to 0.19.
16578 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16580 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16582 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16584 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16586 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16588 * cs-parser.jay: Small fix: we were not comparing the constructor
16589 name correctly. Thanks to Zoltan for the initial pointer.
16591 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16593 * cs-tokenizer.cs: Set file name when specified with #line
16595 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16597 * cs-parser.jay: Only perform the constructor checks here if we
16598 are named like the class; This will help provider a better
16599 error. The constructor path is taken when a type definition is
16600 not found, but most likely the user forgot to add the type, so
16601 report that rather than the constructor error.
16603 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16605 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16608 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16610 * cs-parser.jay: Add cleanup call.
16612 2003-01-13 Duncan Mak <duncan@ximian.com>
16614 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16615 consistent with other methods.
16617 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16619 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16621 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16623 * attribute.cs: only set GuidAttr to true when we have a
16626 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16630 * typemanager.cs: fixes to allow mcs compile corlib with the new
16631 Type.IsSubclassOf fix.
16633 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16635 * expression.cs (LocalVariableReference.DoResolve): Classify a
16636 constant as a value, not as a variable. Also, set the type for
16639 * cs-parser.jay (fixed_statement): take a type instead of a
16640 pointer_type, so we can produce a better error message later.
16642 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16645 (For.DoEmit): Make inifinite loops have a
16646 non-conditional branch back.
16648 (Fixed.DoEmit): First populate the pinned variables, then emit the
16649 statement, then clear the variables. Before I was emitting the
16650 code once for each fixed piece.
16653 2003-01-08 Martin Baulig <martin@ximian.com>
16655 * statement.cs (FlowBranching.MergeChild): A break in a
16656 SWITCH_SECTION does not leave a loop. Fixes #36155.
16658 2003-01-08 Martin Baulig <martin@ximian.com>
16660 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16661 lives in the same number space than `param_map'. Fixes #36154.
16663 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16665 * cs-parser.jay (constructor_declaration): Set the
16666 Constructor.ModFlags before probing for it. This makes the
16667 compiler report 514, 515 and 132 (the code was there, but got
16670 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16671 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16672 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16674 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16676 * enum.cs: create the enum static fields using the enum type.
16678 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16680 * class.cs: don't try to create the ParamBuilder for the return
16681 type if it's not needed (and handle it breaking for the ms runtime
16684 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16686 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16688 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16690 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16691 the command. This showed up while compiling the JANET source
16692 code, which used \r as its only newline separator.
16694 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16696 * class.cs (Method.Define): If we are an operator (because it
16697 reuses our code), then set the SpecialName and HideBySig. #36128
16699 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16701 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16702 exception, report error 120 `object reference required'.
16704 * driver.cs: Add --pause option, used during to measure the size
16705 of the process as it goes with --timestamp.
16707 * expression.cs (Invocation.DoResolve): Do not allow methods with
16708 SpecialName to be invoked.
16710 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16712 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16713 number before adding it.
16715 2002-12-21 Ravi Pratap <ravi@ximian.com>
16717 * ecore.cs (StandardImplicitConversion): When in an unsafe
16718 context, we allow conversion between void * to any other pointer
16719 type. This fixes bug #35973.
16721 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16723 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16724 is not thrown when extensionless outputs are used
16726 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16728 * rootcontext.cs: fixed compilation of corlib.
16730 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16732 * attribute.cs (Attributes.Contains): Add new method.
16734 * class.cs (MethodCore.LabelParameters): if the parameter is an
16735 `out' parameter, check that no attribute `[In]' has been passed.
16737 * enum.cs: Handle the `value__' name in an enumeration.
16739 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16741 * decl.cs: Added special case to allow overrides on "protected
16744 2002-12-18 Ravi Pratap <ravi@ximian.com>
16746 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16747 since it makes much more sense.
16749 (Attributes.ctor): Don't require a Location parameter.
16751 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16753 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16754 since we already have that information per attribute.
16756 * everywhere : make appropriate changes.
16758 * class.cs (LabelParameters): Write the code which actually
16759 applies attributes to the return type. We can't do this on the MS
16760 .NET runtime so we flag a warning in the case an exception is
16763 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16765 * const.cs: Handle implicit null conversions here too.
16767 2002-12-17 Ravi Pratap <ravi@ximian.com>
16769 * class.cs (MethodCore.LabelParameters): Remove the extra
16770 Type [] parameter since it is completely unnecessary. Instead
16771 pass in the method's attributes so that we can extract
16772 the "return" attribute.
16774 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16776 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16777 of ignoring it and letting the compile continue.
16779 * typemanager.cs (ChangeType): use an extra argument to return an
16780 error condition instead of throwing an exception.
16782 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16784 * expression.cs (Unary.TryReduce): mimic the code for the regular
16785 code path. Perform an implicit cast in the cases where we can
16786 implicitly convert to one of the integral types, and then reduce
16787 based on that constant. This fixes bug #35483.
16789 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16791 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16793 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16795 * namespace.cs: fixed bug #35489.
16797 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16799 * class.cs: Remove some dead code.
16801 * cs-parser.jay: Estimate the number of methods needed
16802 (RootContext.MethodCount);
16804 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16805 numbers instead of StringBuilders.
16807 * support.cs (PtrHashtable): Add constructor with initial size;
16808 We can now reduce reallocations of the method table.
16810 2002-12-10 Ravi Pratap <ravi@ximian.com>
16812 * attribute.cs (ApplyAttributes): Keep track of the emitted
16813 attributes on a per-target basis. This fixes bug #35413.
16815 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16817 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16818 default to the Windows 1252 encoding.
16820 (UnixParseOption): Support version, thanks to Alp for the missing
16823 * AssemblyInfo.cs: Add nice assembly information.
16825 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16828 * cs-parser.jay: Allow a trailing comma before the close bracked
16829 in the attribute_section production.
16831 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16832 address of the instance was being taken, I will take this out,
16833 because we take the address of the object immediately here.
16835 2002-12-09 Ravi Pratap <ravi@ximian.com>
16837 * typemanager.cs (AreMultipleAllowed): Take care of the most
16838 obvious case where attribute type is not in the current assembly -
16841 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16843 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16844 definitions, instead of doing that afterwards.
16846 Also we use a nice little hack, depending on the constructor, we
16847 know if we are a "composed" name or a simple name. Hence, we
16848 avoid the IndexOf test, and we avoid
16850 * codegen.cs: Add code to assist in a bug reporter to track down
16851 the source of a compiler crash.
16853 2002-12-07 Ravi Pratap <ravi@ximian.com>
16855 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16856 types have been emitted for a given element and flag an error
16857 if something which does not have AllowMultiple set is used more
16860 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16861 attribute types and their corresponding AllowMultiple properties
16863 (AreMultipleAllowed): Check the property for a given type.
16865 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16866 property in the case we have a TypeContainer.
16868 (Attributes.AddAttribute): Detect duplicates and just skip on
16869 adding them. This trivial fix catches a pretty gross error in our
16870 attribute emission - global attributes were being emitted twice!
16872 Bugzilla bug #33187 is now fixed.
16874 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16876 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16877 instead of pp_and).
16879 * expression.cs (Binary.ResolveOperator): I can only use the
16880 Concat (string, string, string) and Concat (string, string,
16881 string, string) if the child is actually a concatenation of
16884 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16886 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16887 context where we need a 2-character lookahead.
16889 * pending.cs (PendingImplementation): Rework so we can keep track
16890 of interface types all the time, and flag those which were
16891 implemented by parents as optional.
16893 2002-12-03 Miguel de Icaza <miguel@ximian.com>
16895 * expression.cs (Binary.ResolveOperator): Use
16896 String.Concat(string,string,string) or
16897 String.Concat(string,string,string,string) when possible.
16899 * typemanager: More helper methods.
16902 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
16904 * pending.cs: remove the bogus return from GetMissingInterfaces()
16905 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
16907 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16909 * namespace.cs: avoid duplicated 'using xxx' being added to
16910 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
16911 when we get more than one 'using' statement for the same namespace.
16912 Report a CS0105 warning for it.
16914 2002-11-30 Miguel de Icaza <miguel@ximian.com>
16916 * cs-tokenizer.cs (consume_identifier): use read directly, instead
16917 of calling getChar/putback, uses internal knowledge of it.
16919 (xtoken): Reorder tokenizer so most common patterns are checked
16920 first. This reduces the compilation time in another 5% (from 8.11s
16921 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
16923 The parsing time is 22% of the compilation in mcs, and from that
16924 64% is spent on the tokenization process.
16926 I tried using a binary search for keywords, but this is slower
16927 than the hashtable. Another option would be to do a couple of
16930 * Not use a StringBuilder, instead use an array of chars,
16931 with a set value. Notice that this way we could catch
16932 the 645 error without having to do it *afterwards*.
16934 * We could write a hand-parser to avoid the hashtable
16935 compares altogether.
16937 The identifier consumption process takes 37% of the tokenization
16938 time. Another 15% is spent on is_number. 56% of the time spent
16939 on is_number is spent on Int64.Parse:
16941 * We could probably choose based on the string length to
16942 use Int32.Parse or Int64.Parse and avoid all the 64-bit
16945 Another 3% is spend on wrapping `xtoken' in the `token' function.
16947 Handle 0xa0 as whitespace (#34752)
16949 2002-11-26 Miguel de Icaza <miguel@ximian.com>
16951 * typemanager.cs (IsCLRType): New routine to tell whether a type
16952 is one of the builtin types.
16954 Maybe it needs to use TypeCodes to be faster. Maybe we could use
16955 typecode in more places instead of doing pointer comparissions.
16956 We could leverage some knowledge about the way the typecodes are
16959 New code to cache namespaces in assemblies, it is currently not
16960 invoked, to be used soon.
16962 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
16964 * expression.cs (Binary.ResolveOperator): specially handle
16965 strings, and do not perform user-defined operator overloading for
16968 2002-11-24 Miguel de Icaza <miguel@ximian.com>
16970 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
16971 internalcall as it is a pretty simple operation; Avoid whenever
16972 possible to call Char.IsLetter.
16974 (consume_identifier): Cut by half the number of
16975 hashtable calls by merging the is_keyword and GetKeyword behavior.
16977 Do not short-circuit, because if we do, we
16978 report errors (ie, #if false && true would produce an invalid
16982 2002-11-24 Martin Baulig <martin@ximian.com>
16984 * expression.cs (Cast.TryReduce): If we're in checked syntax,
16985 check constant ranges and report a CS0221. Fixes #33186.
16987 2002-11-24 Martin Baulig <martin@ximian.com>
16989 * cs-parser.jay: Make this work for uninitialized variable
16990 declarations in the `for' initializer. Fixes #32416.
16992 2002-11-24 Martin Baulig <martin@ximian.com>
16994 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
16995 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
16997 2002-11-24 Martin Baulig <martin@ximian.com>
16999 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
17000 argument; if true, we also check for user-defined conversions.
17001 This is only needed if both arguments are of a user-defined type.
17002 Fixes #30443, added test-175.cs.
17003 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
17005 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
17007 2002-11-24 Martin Baulig <martin@ximian.com>
17009 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
17010 function to get the store opcode.
17011 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
17012 only emit the Ldelema if the store opcode is Stobj. You must run
17013 both test-34 and test-167 to test this. Fixes #34529.
17015 2002-11-23 Martin Baulig <martin@ximian.com>
17017 * ecore.cs (Expression.MemberLookup): Added additional
17018 `qualifier_type' argument which is used when we're being called
17019 from MemberAccess.DoResolve() and null if we're called from a
17021 (Expression.MemberLookupFailed): New method to report errors; this
17022 does the CS1540 check and reports the correct error message.
17024 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
17025 argument for the CS1540 check and redone the way how we're dealing
17026 with private members. See the comment in the source code for details.
17027 (FilterWithClosure): Reverted this back to revision 1.197; renamed
17028 `closure_start_type' to `closure_qualifier_type' and check whether
17029 it's not null. It was not this filter being broken, it was just
17030 being called with the wrong arguments.
17032 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
17033 and pass it the correct `qualifier_type'; this also does the error
17036 2002-11-22 Miguel de Icaza <miguel@ximian.com>
17038 * expression.cs (Invocation.EmitParams): If the we are dealing
17039 with a non-built-in value type, load its address as well.
17041 (ArrayCreation): Use a a pretty constant instead
17042 of the hardcoded value 2. Use 6 instead of 2 for the number of
17043 static initializers.
17045 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
17046 because they are not really value types, just glorified integers.
17048 * driver.cs: Do not append .exe, the CSC compiler does not do it.
17050 * ecore.cs: Remove redundant code for enumerations, make them use
17051 the same code path as everything else, fixes the casting issue
17052 with enumerations in Windows.Forms.
17054 * attribute.cs: Do only cast to string if it is a string, the
17055 validation happens later.
17057 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
17058 people upgrade their corlibs.
17060 * ecore.cs: Oops, enumerations were not following the entire code path
17062 2002-11-21 Miguel de Icaza <miguel@ximian.com>
17064 * typemanager.cs (FilterWithClosure): Commented out the test for
17065 1540 in typemanager.cs, as it has problems when accessing
17066 protected methods from a parent class (see test-174.cs).
17068 * attribute.cs (Attribute.ValidateGuid): new method.
17069 (Attribute.Resolve): Use above.
17071 2002-11-19 Miguel de Icaza <miguel@ximian.com>
17073 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
17075 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
17076 handling for enumerations, as we only needed the TypeContainer
17077 functionality to begin with (this is required for the fix below to
17078 work for enums that reference constants in a container class for
17081 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
17083 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
17084 a valid TypeBuilder to perform lookups on.o
17086 * class.cs (InheritableMemberSignatureCompare): Use true in the
17087 call to GetGetMethod and GetSetMethod, because we are comparing
17088 the signature, and we need to get the methods *even* if they are
17091 (PropertyBase.CheckBase): ditto.
17093 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
17094 GotoCase.Resolve): Use Peel on EmpytCasts.
17096 * ecore.cs (EmptyCast): drop child, add Peel method.
17098 2002-11-17 Martin Baulig <martin@ximian.com>
17100 * ecore.cs (EmptyCast.Child): New public property.
17102 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
17103 label resolved to an EmptyCast. Fixes #34162.
17104 (GotoCase.Resolve): Likewise.
17105 (Block.EmitMeta): Likewise.
17107 2002-11-17 Martin Baulig <martin@ximian.com>
17109 * expression.cs (Invocation.BetterConversion): Prefer int over
17110 uint; short over ushort; long over ulong for integer literals.
17111 Use ImplicitConversionExists instead of StandardConversionExists
17112 since we also need to check for user-defined implicit conversions.
17113 Fixes #34165. Added test-173.cs.
17115 2002-11-16 Martin Baulig <martin@ximian.com>
17117 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
17118 with the `true' and `false' literals. Fixes #33151.
17120 2002-11-16 Martin Baulig <martin@ximian.com>
17122 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
17123 October 22nd; don't do the cs1540 check for static members.
17125 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
17126 now using our own filter here and doing the cs1540 check again.
17128 2002-11-16 Martin Baulig <martin@ximian.com>
17130 * support.cs (InternalParameters): Don't crash if we don't have
17131 any fixed parameters. Fixes #33532.
17133 2002-11-16 Martin Baulig <martin@ximian.com>
17135 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
17136 when looking up static methods to make this work on Windows.
17139 2002-11-16 Martin Baulig <martin@ximian.com>
17141 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
17142 a setter rather than using PropertyInfo.CanWrite.
17144 2002-11-15 Nick Drochak <ndrochak@gol.com>
17146 * class.cs: Allow acces to block member by subclasses. Fixes build
17149 2002-11-14 Martin Baulig <martin@ximian.com>
17151 * class.cs (Constructor.Emit): Added the extern/block check.
17154 2002-11-14 Martin Baulig <martin@ximian.com>
17156 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
17157 iteration while looking for indexers, this is needed because the
17158 indexer may have a different name in our base classes. Fixed the
17159 error reporting (no indexers at all, not get accessor, no
17160 overloaded match). Fixes bug #33089.
17161 (IndexerAccess.DoResolveLValue): Likewise.
17163 2002-11-14 Martin Baulig <martin@ximian.com>
17165 * class.cs (PropertyBase.CheckBase): Make this work for multiple
17166 indexers. Fixes the first part of bug #33089.
17167 (MethodSignature.InheritableMemberSignatureCompare): Added support
17170 2002-11-13 Ravi Pratap <ravi@ximian.com>
17172 * attribute.cs (Attribute.Resolve): Catch the
17173 NullReferenceException and report it since it isn't supposed to
17176 2002-11-12 Miguel de Icaza <miguel@ximian.com>
17178 * expression.cs (Binary.EmitBranchable): Also handle the cases for
17179 LogicalOr and LogicalAnd that can benefit from recursively
17180 handling EmitBranchable. The code now should be nice for Paolo.
17182 2002-11-08 Miguel de Icaza <miguel@ximian.com>
17184 * typemanager.cs (LookupType): Added a negative-hit hashtable for
17185 the Type lookups, as we perform quite a number of lookups on
17186 non-Types. This can be removed once we can deterministically tell
17187 whether we have a type or a namespace in advance.
17189 But this might require special hacks from our corlib.
17193 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
17194 and double which avoids a conversion from an integer to a double.
17196 * expression.cs: tiny optimization, avoid calling IsConstant,
17197 because it effectively performs the lookup twice.
17199 2002-11-06 Miguel de Icaza <miguel@ximian.com>
17201 But a bogus return here to keep the semantics of the old code
17202 until the Mono runtime is fixed.
17204 * pending.cs (GetMissingInterfaces): New method used to remove all
17205 the interfaces that are already implemented by our parent
17206 classes from the list of pending methods.
17208 * interface.cs: Add checks for calls after ResolveTypeExpr.
17210 2002-11-05 Miguel de Icaza <miguel@ximian.com>
17212 * class.cs (Class.Emit): Report warning 67: event not used if the
17213 warning level is beyond 3.
17215 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
17216 being a NullLiteral.
17218 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
17221 * class.cs (TypeContainer.GetClassBases): Cover a missing code
17222 path that might fail if a type can not be resolved.
17224 * expression.cs (Binary.Emit): Emit unsigned versions of the
17227 * driver.cs: use error 5.
17229 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
17231 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
17233 2002-11-01 Miguel de Icaza <miguel@ximian.com>
17235 * cs-parser.jay (switch_section): A beautiful patch from Martin
17236 Baulig that fixed 33094.
17238 2002-10-31 Miguel de Icaza <miguel@ximian.com>
17240 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
17241 Check whether the base is abstract and report an error if so.
17243 * expression.cs (IndexerAccess.DoResolveLValue,
17244 IndexerAccess.DoResolve): ditto.
17246 (Invocation.DoResolve): ditto.
17248 (Invocation.FullMethodDesc): Improve the report string.
17250 * statement.cs (Block): Eliminate IsVariableDefined as it is
17251 basically just a wrapper for GetVariableInfo.
17253 * ecore.cs (SimpleName): Use new
17255 * support.cs (ReflectionParamter.ParameterType): We unwrap the
17256 type, as we return the actual parameter ref/unref state on a
17259 2002-10-30 Miguel de Icaza <miguel@ximian.com>
17261 * support.cs: Return proper flags REF/OUT fixing the previous
17264 * expression.cs: Reverted last patch, that was wrong. Is_ref is
17265 not used to mean `ref' but `ref or out' in ParameterReference
17267 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
17268 full type signature instead of calling TypeManger.CSharpName
17271 * support.cs (InternalParameters.ParameterDesc): Do not compare
17272 directly to the modflags, because REF/OUT will actually be bitsets
17275 * delegate.cs (VerifyMethod): Check also the modifiers.
17277 * cs-tokenizer.cs: Fix bug where floating point values with an
17278 exponent where a sign was missing was ignored.
17280 * driver.cs: Allow multiple assemblies to be specified in a single
17283 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17285 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17286 because identifiers after a parenthesis would end up in this kind
17287 of production, and we needed to desamiguate it for having casts
17290 (UserDefinedType *) xxx
17292 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17294 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17295 we should set on the Bindingflags.NonPublic, but not turn on
17296 private_ok. private_ok controls whether a Private member is
17297 returned (this is chekced on the filter routine), while the
17298 BindingFlags.NonPublic just controls whether private/protected
17299 will be allowed. This fixes the problem part of the problem of
17300 private properties being allowed to be used in derived classes.
17302 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17303 so we can call the children DoResolveLValue method (this will
17304 properly signal errors on lvalue assignments to base properties)
17306 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17307 getter are null, and we have a property info, we know that this
17308 happened because the lookup failed, so we report an error 122 for
17309 protection level violation.
17311 We also silently return if setter and getter are null in the
17312 resolve functions, this condition only happens if we have flagged
17313 the error before. This is the other half of the problem.
17315 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17316 not have accessibility information, that is why we were returning
17317 true in the filter function in typemanager.cs.
17319 To properly report 122 (property is inaccessible because of its
17320 protection level) correctly, we report this error in ResolveAccess
17321 by failing if both the setter and the getter are lacking (ie, the
17324 DoResolve and DoLResolve have been modified to check for both
17325 setter/getter being null and returning silently, the reason being
17326 that I did not want to put the knowledge about this error in upper
17329 int old = Report.Errors;
17330 x = new PropertyExpr (...);
17331 if (old != Report.Errors)
17336 So the property expr is returned, but it is invalid, so the error
17337 will be flagged during the resolve process.
17339 * class.cs: Remove InheritablePropertySignatureCompare from the
17340 class, as we no longer depend on the property signature to compute
17341 whether it is possible to implement a method or not.
17343 The reason is that calling PropertyInfo.GetGetMethod will return
17344 null (in .NET, in Mono it works, and we should change this), in
17345 cases where the Get Method does not exist in that particular
17350 class X { public virtual int A { get { return 1; } } }
17352 class Z : Y { public override int A { get { return 2; } } }
17354 Would fail in Z because the parent (Y) would not have the property
17355 defined. So we avoid this completely now (because the alternative
17356 fix was ugly and slow), and we now depend exclusively on the
17359 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17360 reference method, instead of using the property.
17362 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17363 routines are gone now.
17365 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17366 names, they were incorrectly named.
17368 * cs-tokenizer.cs: Return are more gentle token on failure.
17370 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17371 had an out-of-sync index variable, which caused it to remove from
17372 the list of pending methods the wrong method sometimes.
17374 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17376 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17377 CanWrite, because those refer to this particular instance of the
17378 property, and do not take into account the fact that we can
17379 override single members of a property.
17381 Constructor requires an EmitContext. The resolution process does
17382 not happen here, but we need to compute the accessors before,
17383 because the resolution does not always happen for properties.
17385 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17386 subclass, before we did not update this flag, but we did update
17389 (GetAccessors): Drop this routine, as it did not work in the
17390 presence of partially overwritten set/get methods.
17392 Notice that this broke the cs1540 detection, but that will require
17395 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17399 * driver.cs: issue a warning instead of an error if we don't support
17400 debugging for the platform. Also ignore a couple of errors that may
17401 arise when trying to write the symbols. Undo my previous patch.
17403 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17405 * driver.cs: ignore /debug switch except for Unix platforms.
17407 2002-10-23 Nick Drochak <ndrochak@gol.com>
17409 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17411 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17413 * driver.cs: Do not make mcs-debug conditional, so we do not break
17414 builds that use it.
17416 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17417 review this patch. But basically after all the children variables
17418 have been merged, the value of "Breaks" was not being set to
17419 new_breaks for Switch blocks. I think that it should be set after
17420 it has executed. Currently I set this to the value of new_breaks,
17421 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17422 conservative, but I do not understand this code very well.
17424 I did not break anything in the build, so that is good ;-)
17426 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17428 2002-10-20 Mark Crichton <crichton@gimp.org>
17430 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17432 2002-10-20 Nick Drochak <ndrochak@gol.com>
17434 * cfold.cs: Fixed compile blocker.
17436 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17438 * driver.cs: I was chekcing the key, not the file.
17440 2002-10-19 Ravi Pratap <ravi@ximian.com>
17442 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17443 message that we were generating - we just need to silently return
17446 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17448 * class.cs (Event.Define): Change my previous commit, as this
17449 breaks the debugger. This is a temporary hack, as it seems like
17450 the compiler is generating events incorrectly to begin with.
17452 * expression.cs (Binary.ResolveOperator): Added support for
17453 "U operator - (E x, E y)"
17455 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17458 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17459 init-only variables, but this path did not take into account that
17460 there might be also instance readonly variables. Correct this
17463 This fixes bug 32253
17465 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17468 * driver.cs: Change the extension for modules to `netmodule'
17470 * cs-parser.jay: Improved slightly the location tracking for
17471 the debugger symbols.
17473 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17474 modifiers that were specified instead of the hardcoded value
17475 (FamAndAssem). This was basically ignoring the static modifier,
17476 and others. Fixes 32429.
17478 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17479 fixed a bug in the process (32476)
17481 * expression.cs (ArrayAccess.EmitAssign): Patch from
17482 hwang_rob@yahoo.ca that fixes bug 31834.3
17484 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17486 * driver.cs: Make the module extension .netmodule.
17488 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17490 * driver.cs: Report an error if the resource file is not found
17491 instead of crashing.
17493 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17494 false, like Emit does.
17496 2002-10-16 Nick Drochak <ndrochak@gol.com>
17498 * typemanager.cs: Remove unused private member. Also reported mcs
17499 bug to report this as a warning like csc.
17501 2002-10-15 Martin Baulig <martin@gnome.org>
17503 * statement.cs (Statement.Emit): Made this a virtual method; emits
17504 the line number info and calls DoEmit().
17505 (Statement.DoEmit): New protected abstract method, formerly knows
17506 as Statement.Emit().
17508 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17510 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17512 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17513 have fixed a remaining problem: not every AddXXXX was adding a
17514 fully qualified name.
17516 Now everyone registers a fully qualified name in the DeclSpace as
17517 being defined instead of the partial name.
17519 Downsides: we are slower than we need to be due to the excess
17520 copies and the names being registered this way.
17522 The reason for this is that we currently depend (on the corlib
17523 bootstrap for instance) that types are fully qualified, because
17524 we dump all the types in the namespace, and we should really have
17525 types inserted into the proper namespace, so we can only store the
17526 basenames in the defined_names array.
17528 2002-10-10 Martin Baulig <martin@gnome.org>
17530 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17531 from bug #31834, see the bug report for a testcase which is
17534 2002-10-10 Martin Baulig <martin@gnome.org>
17536 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17537 flow analysis code for this.
17539 * statement.cs (Do, While, For): Tell the flow analysis code about
17541 (FlowBranching.UsageVector): Added support for infinite loops.
17542 (Block.Resolve): Moved the dead code elimination here and use flow
17545 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17547 * class.cs (Field.Define): Catch cycles on struct type
17550 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17551 fields if the fields are static. We only need to check instance
17554 * expression.cs (As.DoResolve): Test for reference type.
17556 * statement.cs (Using.ResolveExpression): Use
17557 ConvertImplicitRequired, not ConvertImplicit which reports an
17559 (Using.ResolveLocalVariableDecls): ditto.
17561 * expression.cs (Binary.ResolveOperator): Report errors in a few
17562 places where we had to.
17564 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17566 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17568 * expression.cs: Use StoreFromPtr instead of extracting the type
17569 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17571 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17572 an enumeration value to a System.Enum, but System.Enum is not a
17573 value type, but an class type, so we need to box.
17575 (Expression.ConvertExplicit): One codepath could return
17576 errors but not flag them. Fix this. Fixes #31853
17578 * parameter.cs (Resolve): Do not allow void as a parameter type.
17580 2002-10-06 Martin Baulig <martin@gnome.org>
17582 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17583 if it's a class type and not a struct. Fixes #31815.
17585 2002-10-06 Martin Baulig <martin@gnome.org>
17587 * statement.cs: Reworked the flow analysis code a bit to make it
17588 usable for dead code elimination.
17590 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17592 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17594 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17596 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17597 to fix the test 165, will investigate deeper.
17599 2002-10-04 Martin Baulig <martin@gnome.org>
17601 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17602 finally blocks actually work.
17603 (Try.Resolve): We don't need to create a sibling for `finally' if
17604 there is no finally block.
17606 2002-10-04 Martin Baulig <martin@gnome.org>
17608 * class.cs (Constructor.Define): The default accessibility for a
17609 non-default constructor is private, not public.
17611 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17613 * class.cs (Constructor): Make AllowedModifiers public, add
17616 * cs-parser.jay: Perform the modifiers test here, as the
17617 constructor for the Constructor class usually receives a zero
17618 because of the way we create it (first we create, later we
17619 customize, and we were never checking the modifiers).
17621 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17622 is a version of LookupTypeReflection that includes the type-name
17623 cache. This can be used as a fast path for functions that know
17624 the fully qualified name and are only calling into *.GetType() to
17625 obtain a composed type.
17627 This is also used by TypeManager.LookupType during its type
17630 (LookupType): We now also track the real type name, as sometimes
17631 we can get a quey for the real type name from things like
17632 ComposedCast. This fixes bug 31422.
17634 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17635 complete type fullname, it does not have to go through the type
17636 resolution system to obtain the composed version of the type (for
17637 obtaining arrays or pointers).
17639 (Conditional.Emit): Use the EmitBoolExpression to
17640 generate nicer code, as requested by Paolo.
17642 (ArrayCreation.CheckIndices): Use the patch from
17643 hwang_rob@yahoo.ca to validate the array initializers.
17645 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17647 * class.cs (ConstructorInitializer.Emit): simplify code by using
17648 Invocation.EmitCall, and at the same time, fix the bugs in calling
17649 parent constructors that took variable arguments.
17651 * ecore.cs (Expression.ConvertNumericExplicit,
17652 Expression.ImplicitNumericConversion): Remove the code that
17653 manually wrapped decimal (InternalTypeConstructor call is now gone
17656 * expression.cs (Cast.TryReduce): Also handle decimal types when
17657 trying to perform a constant fold on the type.
17659 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17661 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17662 that only turned off an error report, and did nothing else.
17664 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17666 * driver.cs: Handle and ignore /fullpaths
17668 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17670 * expression.cs (Binary.ResolveOperator): Catch the case where
17671 DoNumericPromotions returns true,
17673 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17675 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17677 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17680 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17682 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17683 conversion exists, but it is also required that the conversion be
17684 performed. This manifested in "(Type64Enum) 2".
17686 * class.cs (TypeManager.AddMethod): The fix is not to change
17687 AddEnum, because that one was using a fully qualified name (every
17688 DeclSpace derivative does), but to change the AddMethod routine
17689 that was using an un-namespaced name. This now correctly reports
17690 the duplicated name.
17692 Revert patch until I can properly fix it. The issue
17693 is that we have a shared Type space across all namespaces
17694 currently, which is wrong.
17696 Options include making the Namespace a DeclSpace, and merge
17697 current_namespace/current_container in the parser.
17699 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17701 * cs-parser.jay: Improve error reporting when we get a different
17702 kind of expression in local_variable_type and
17703 local_variable_pointer_type.
17705 Propagate this to avoid missleading errors being reported.
17707 * ecore.cs (ImplicitReferenceConversion): treat
17708 TypeManager.value_type as a target just like object_type. As
17713 Is valid, and needs to result in the int 1 being boxed before it
17714 is assigned to the value type v.
17716 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17717 to validate the enumeration name.
17719 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17720 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17721 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17723 * ecore.cs (TryImplicitIntConversion): When doing an
17724 implicit-enumeration-conversion, check if the type is 64-bits and
17725 perform a conversion before passing to EnumConstant.
17727 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17729 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17730 report ambiguous type references. Unlike the MS version, we
17731 report what the ambiguity is. Innovation at work ;-)
17733 (DeclSpace.FindType): Require a location argument to
17734 display when we display an ambiguous error.
17736 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17738 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17740 * expression.cs (EmitDynamicInitializers): Apply patch from
17741 hwang_rob@yahoo.ca that fixes the order in which we emit our
17744 2002-09-21 Martin Baulig <martin@gnome.org>
17746 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17747 delegate takes no arguments.
17749 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17751 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17754 * expression.cs: Extract the underlying type.
17756 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17758 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17760 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17762 * class.cs (TypeContainer.DefineType): We can not use the nice
17763 PackingSize with the size set to 1 DefineType method, because it
17764 will not allow us to define the interfaces that the struct
17767 This completes the fixing of bug 27287
17769 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17770 means also structs. This fixes part of the problem.
17771 (Expresion.ImplicitReferenceConversionExists): ditto.
17773 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17774 error if there were no errors reported during the type lookup
17775 process, to avoid duplicates or redundant errors. Without this
17776 you would get an ambiguous errors plus a type not found. We have
17777 beaten the user enough with the first error.
17779 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17782 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17783 during the resolution process, stop the lookup, this avoids
17784 repeated error reports (same error twice).
17786 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17788 * typemanager.cs (LookupType): Redo the type lookup code to match
17789 the needs of System.Reflection.
17791 The issue is that System.Reflection requires references to nested
17792 types to begin with a "+" sign instead of a dot. So toplevel
17793 types look like: "NameSpace.TopLevelClass", and nested ones look
17794 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17797 2002-09-19 Martin Baulig <martin@gnome.org>
17799 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17800 says that a method always returns or always throws an exception,
17801 don't report the CS0161.
17803 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17804 set `Returns = new_returns'.
17806 2002-09-19 Martin Baulig <martin@gnome.org>
17808 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17809 to an enum constant, check for a CS0176.
17811 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17813 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17814 for operators that must be in pairs and report errors.
17816 * ecore.cs (SimpleName.DoResolveType): During the initial type
17817 resolution process, when we define types recursively, we must
17818 check first for types in our current scope before we perform
17819 lookups in the enclosing scopes.
17821 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17823 (Invocation.VerifyArgumentsCompat): Call
17824 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17825 I thought we were supposed to always call this, but there are a
17826 few places in the code where we dont do it.
17828 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17830 * driver.cs: Add support in -linkres and -resource to specify the
17831 name of the identifier.
17833 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17835 * ecore.cs (StandardConversionExists): Sync with the conversion
17836 code: allow anything-* to void* conversions.
17838 (FindMostSpecificSource): Use an Expression argument
17839 instead of a Type, because we might be handed over a Literal which
17840 gets a few more implicit conversions that plain types do not. So
17841 this information was being lost.
17843 Also, we drop the temporary type-holder expression when not
17846 2002-09-17 Martin Baulig <martin@gnome.org>
17848 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17849 this is an explicit interface implementation.
17851 2002-09-17 Martin Baulig <martin@gnome.org>
17853 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17854 different `IndexerName' attributes.
17856 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17857 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17858 virtual CommonResolve().
17860 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17862 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17863 and convert that to the UnderlyingType.
17865 * statement.cs (Foreach.Resolve): Indexers are just like variables
17866 or PropertyAccesses.
17868 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17869 inside quoted strings, we were not doing this before.
17871 2002-09-16 Martin Baulig <martin@gnome.org>
17873 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17874 resolve it. This is needed for the definite assignment check of the
17875 instance expression, fixes bug #29846.
17876 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17878 2002-09-16 Nick Drochak <ndrochak@gol.com>
17880 * parameter.cs: Fix compile error. Cannot reference static member
17881 from an instance object. Is this an mcs bug?
17883 2002-09-14 Martin Baulig <martin@gnome.org>
17885 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17886 multiple times. Fixes bug #30295, added test-166.cs.
17888 2002-09-14 Martin Baulig <martin@gnome.org>
17890 * statement.cs (Block.Emit): Don't emit unreachable code.
17891 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
17892 `break' statements.
17893 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
17895 2002-09-14 Martin Baulig <martin@gnome.org>
17897 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
17900 2002-09-14 Martin Baulig <martin@gnome.org>
17902 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
17903 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
17904 be false on the ms runtime.
17906 2002-09-13 Martin Baulig <martin@gnome.org>
17908 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
17909 the CS0038 error message.
17911 2002-09-12 Miguel de Icaza <miguel@ximian.com>
17913 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
17914 constant inside, return it.
17916 2002-09-12 Martin Baulig <martin@gnome.org>
17918 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
17919 implicit conversion can be done between enum types.
17921 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
17922 check whether an implicit conversion to the current enum's UnderlyingType
17923 exists and report an error if not.
17925 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
17926 without debugging support.
17928 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
17929 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
17931 2002-09-12 Martin Baulig <martin@gnome.org>
17933 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
17935 * ecore.cs (IMemberExpr.DeclaringType): New property.
17936 (SimpleName.SimpleNameResolve): Check whether we're accessing a
17937 nonstatic member of an outer type (CS0038).
17939 2002-09-11 Miguel de Icaza <miguel@ximian.com>
17941 * driver.cs: Activate the using-error detector at warning level
17942 4 (at least for MS-compatible APIs).
17944 * namespace.cs (VerifyUsing): Small buglett fix.
17946 * pending.cs (PendingImplementation): pass the container pointer.
17948 * interface.cs (GetMethods): Allow for recursive definition. Long
17949 term, I would like to move every type to support recursive
17950 definitions, not the current ordering mechanism that we have right
17953 The situation is this: Attributes are handled before interfaces,
17954 so we can apply attributes to interfaces. But some attributes
17955 implement interfaces, we will now handle the simple cases
17956 (recursive definitions will just get an error).
17958 * parameter.cs: Only invalidate types at the end if we fail to
17961 2002-09-09 Martin Baulig <martin@gnome.org>
17963 * ecore.cs (PropertyExpr.Emit): Also check for
17964 TypeManager.system_int_array_get_length so this'll also work when
17965 compiling corlib. Fixes #30003.
17967 2002-09-09 Martin Baulig <martin@gnome.org>
17969 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
17970 and throw an exception if we can't get the type's size. Fixed #30040,
17973 2002-09-09 Martin Baulig <martin@gnome.org>
17975 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
17977 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
17978 context. Fixes bug #30027.
17980 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
17981 virtual functions. Fixes bug #30043, added test-164.cs.
17983 2002-09-08 Ravi Pratap <ravi@ximian.com>
17985 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
17987 2002-09-08 Nick Drochak <ndrochak@gol.com>
17989 * driver.cs: Use an object to get the windows codepage since it's not a
17992 2002-09-08 Miguel de Icaza <miguel@ximian.com>
17994 * statement.cs (For.Emit): for infinite loops (test == null)
17995 return whether there is a break inside, not always "true".
17997 * namespace.cs (UsingEntry): New struct to hold the name of the
17998 using definition, the location where it is defined, and whether it
17999 has been used in a successful type lookup.
18001 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
18006 2002-09-06 Ravi Pratap <ravi@ximian.com>
18008 * attribute.cs : Fix incorrect code which relied on catching
18009 a NullReferenceException to detect a null being passed in
18010 where an object was expected.
18012 2002-09-06 Miguel de Icaza <miguel@ximian.com>
18014 * statement.cs (Try): flag the catch variable as assigned
18016 * expression.cs (Cast): Simplified by using ResolveType instead of
18017 manually resolving.
18019 * statement.cs (Catch): Fix bug by using ResolveType.
18021 2002-09-06 Ravi Pratap <ravi@ximian.com>
18023 * expression.cs (BetterConversion): Special case for when we have
18024 a NullLiteral as the argument and we have to choose between string
18025 and object types - we choose string the way csc does.
18027 * attribute.cs (Attribute.Resolve): Catch the
18028 NullReferenceException and report error #182 since the Mono
18029 runtime no more has the bug and having this exception raised means
18030 we tried to select a constructor which takes an object and is
18033 2002-09-05 Ravi Pratap <ravi@ximian.com>
18035 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
18036 message (1502, 1503) when we can't locate a method after overload
18037 resolution. This is much more informative and closes the bug
18040 * interface.cs (PopulateMethod): Return if there are no argument
18041 types. Fixes a NullReferenceException bug.
18043 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
18044 expressions too. Previously we were checking only in one place for
18045 positional arguments leaving out named arguments.
18047 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
18048 type to the enum type is not allowed. Remove code corresponding to
18051 (ConvertNumericExplicit): Allow explicit conversions from
18052 the underlying type to enum type. This precisely follows the spec
18053 and closes a bug filed by Gonzalo.
18055 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18058 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
18060 2002-09-03 Miguel de Icaza <miguel@ximian.com>
18062 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
18063 it was important that we stored the right value after the
18064 reduction in `converted'.
18066 2002-09-04 Martin Baulig <martin@gnome.org>
18068 * location.cs (Location.SymbolDocument): Use full pathnames for the
18071 2002-08-30 Miguel de Icaza <miguel@ximian.com>
18073 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
18074 of the expression resolve mechanism, because that will catch the
18075 SimpleName error failures.
18077 (Conditional): If we can not resolve the
18078 expression, return, do not crash.
18080 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18083 (location): display token name instead of its number.
18085 2002-08-28 Martin Baulig <martin@gnome.org>
18087 * expression.cs (Binary.ResolveOperator): Don't silently return
18088 but return an error if an operator cannot be applied between two
18091 2002-08-28 Martin Baulig <martin@gnome.org>
18093 * class.cs (Constructor.Define): Set the permission attributes
18094 correctly instead of making all constructors public.
18096 2002-08-28 Martin Baulig <martin@gnome.org>
18098 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
18099 for private members before reporting a CS0103; if we find anything,
18102 2002-08-28 Martin Baulig <martin@gnome.org>
18104 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
18105 to check whether `closure_start_type == closure_invocation_type',
18106 we also need to check whether `m.DeclaringType == closure_invocation_type'
18107 before bypassing the permission checks. We might be accessing
18108 protected/private members from the base class.
18109 (TypeManager.RealMemberLookup): Only set private_ok if private
18110 members were requested via BindingFlags.NonPublic.
18112 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
18114 * expression.cs (MemberAccess.ResolveMemberAccess): Set
18115 MethodGroupExpr.IsExplicitImpl if appropriate.
18116 (Invocation.DoResolve): Don't report the CS0120 for explicit
18117 interface implementations.
18119 2002-08-27 Martin Baulig <martin@gnome.org>
18121 * expression.cs (Invocation.DoResolve): If this is a static
18122 method and we don't have an InstanceExpression, we must report
18125 2002-08-25 Martin Baulig <martin@gnome.org>
18127 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
18128 `==' between a valuetype and an object.
18130 2002-08-25 Miguel de Icaza <miguel@ximian.com>
18132 * ecore.cs (TypeExpr): Provide a ToString method.
18134 2002-08-24 Martin Baulig <martin@gnome.org>
18136 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
18137 now called proggie.dbg and it's a binary file.
18139 2002-08-23 Martin Baulig <martin@gnome.org>
18141 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
18143 2002-08-23 Martin Baulig <martin@gnome.org>
18145 * struct.cs (MyStructInfo.ctor): Make this work with empty
18146 structs; it's not allowed to use foreach() on null.
18148 2002-08-23 Martin Baulig <martin@gnome.org>
18150 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
18151 writer the full pathname of the generated assembly.
18153 2002-08-23 Martin Baulig <martin@gnome.org>
18155 * statements.cs (FlowBranching.UsageVector.MergeChildren):
18156 A `finally' block never returns or breaks; improved handling of
18159 2002-08-23 Martin Baulig <martin@gnome.org>
18161 * statement.cs (Throw.Resolve): Allow `throw null'.
18163 2002-08-23 Martin Baulig <martin@gnome.org>
18165 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
18166 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
18167 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
18168 MemberLookup would return a wrong event if this is an explicit
18169 interface implementation and the class has an event with the same
18172 2002-08-23 Martin Baulig <martin@gnome.org>
18174 * statement.cs (Block.AddChildVariableNames): New public method.
18175 (Block.AddChildVariableName): Likewise.
18176 (Block.IsVariableNameUsedInChildBlock): Likewise.
18177 (Block.AddVariable): Check whether a variable name has already
18178 been used in a child block.
18180 * cs-parser.jay (declare_local_variables): Mark all variable names
18181 from the current block as being used in a child block in the
18184 2002-08-23 Martin Baulig <martin@gnome.org>
18186 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
18187 find the symbol writer.
18189 * driver.cs: csc also allows the arguments to /define being
18190 separated by commas, not only by semicolons.
18192 2002-08-23 Martin Baulig <martin@gnome.org>
18194 * interface.cs (Interface.GetMembers): Added static check for events.
18196 2002-08-15 Martin Baulig <martin@gnome.org>
18198 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
18199 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
18201 * ecore.cs (Expression.MemberLookup): Added documentation and explained
18202 why the MethodData.EmitDestructor() change was necessary.
18204 2002-08-20 Martin Baulig <martin@gnome.org>
18206 * class.cs (TypeContainer.FindMembers): Added static check for events.
18208 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
18210 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
18211 use Type.GetEvents(), not Type.FindMembers().
18213 2002-08-20 Martin Baulig <martin@gnome.org>
18215 * decl.cs (MemberCache): Added a special method cache which will
18216 be used for method-only searched. This ensures that a method
18217 search will return a MethodInfo with the correct ReflectedType for
18220 2002-08-20 Martin Baulig <martin@gnome.org>
18222 * decl.cs (DeclSpace.FindMembers): Made this public.
18224 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18226 * delegate.cs: fixed build on windows.
18227 [FIXME: Filed as bug #29150: MCS must report these errors.]
18229 2002-08-19 Ravi Pratap <ravi@ximian.com>
18231 * ecore.cs (StandardConversionExists): Return a false
18232 if we are trying to convert the void type to anything else
18233 since that is not allowed.
18235 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
18236 we flag error 70 in the event an event is trying to be accessed
18237 directly from outside the declaring type.
18239 2002-08-20 Martin Baulig <martin@gnome.org>
18241 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
18242 MemberCache from typemanager.cs to decl.cs.
18244 2002-08-19 Martin Baulig <martin@gnome.org>
18246 * class.cs (TypeContainer): Implement IMemberContainer.
18247 (TypeContainer.DefineMembers): Create the MemberCache.
18248 (TypeContainer.FindMembers): Do better BindingFlags checking; only
18249 return public members if BindingFlags.Public was given, check
18250 whether members are static.
18252 2002-08-16 Martin Baulig <martin@gnome.org>
18254 * decl.cs (DeclSpace.Define): Splitted this in Define and
18255 DefineMembers. DefineMembers is called first and initializes the
18258 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
18259 DefineMembers() on all our DeclSpaces.
18261 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
18262 but call DefineMembers() on all nested interfaces. We call their
18263 Define() in our new Define() function.
18265 * interface.cs (Interface): Implement IMemberContainer.
18266 (Interface.Define): Moved all code except the attribute stuf to
18268 (Interface.DefineMembers): Initialize the member cache.
18270 * typemanager.cs (IMemberFinder): Removed this interface, we don't
18271 need this anymore since we can use MemberCache.FindMembers directly.
18273 2002-08-19 Martin Baulig <martin@gnome.org>
18275 * typemanager.cs (MemberCache): When creating the cache for an
18276 interface type, add all inherited members.
18277 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18278 to `out bool used_cache' and documented it.
18279 (TypeManager.MemberLookup): If we already used the cache in the first
18280 iteration, we don't need to do the interfaces check.
18282 2002-08-19 Martin Baulig <martin@gnome.org>
18284 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18285 here from IMemberFinder and don't implement this interface anymore.
18286 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18288 * typemanager.cs (IMemberFinder): This interface is now only used by
18289 classes which actually support the member cache.
18290 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18291 since we only put DeclSpaces into this Hashtable.
18292 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18293 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18295 2002-08-16 Martin Baulig <martin@gnome.org>
18297 * typemanager.cs (ICachingMemberFinder): Removed.
18298 (IMemberFinder.MemberCache): New property.
18299 (TypeManager.FindMembers): Merged this with RealFindMembers().
18300 This function will never be called from TypeManager.MemberLookup()
18301 so we can't use the cache here, just the IMemberFinder.
18302 (TypeManager.MemberLookup_FindMembers): Check whether the
18303 IMemberFinder has a MemberCache and call the cache's FindMembers
18305 (MemberCache): Rewrote larger parts of this yet another time and
18306 cleaned it up a bit.
18308 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18310 * driver.cs (LoadArgs): Support quoting.
18312 (Usage): Show the CSC-like command line arguments.
18314 Improved a few error messages.
18316 2002-08-15 Martin Baulig <martin@gnome.org>
18318 * typemanager.cs (IMemberContainer.Type): New property.
18319 (IMemberContainer.IsInterface): New property.
18321 The following changes are conditional to BROKEN_RUNTIME, which is
18322 defined at the top of the file.
18324 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18325 class'es members, but add all members from TypeHandle.ObjectType
18326 if we're an interface.
18327 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18328 is the current type.
18329 (MemberCache.CacheEntry.Container): Removed this field.
18330 (TypeHandle.GetMembers): Include inherited members.
18332 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18334 * typemanager.cs: fixed compilation and added a comment on a field that
18337 2002-08-15 Martin Baulig <martin@gnome.org>
18339 * class.cs (ConstructorInitializer.Resolve): In the
18340 Expression.MemberLookup call, use the queried_type as
18343 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18344 declared' attribute, it's always true.
18345 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18346 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18347 temporary wrapper for FindMembers which tells MemberLookup whether
18348 members from the base classes are included in the return value.
18349 This will go away soon.
18350 (TypeManager.MemberLookup): Use this temporary hack here; once the
18351 new MemberCache is completed, we don't need to do the DeclaredOnly
18352 looping here anymore since the MemberCache will take care of this.
18353 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18354 (MemberCache): When creating the MemberCache for a class, get
18355 members from the current class and all its base classes.
18356 (MemberCache.CacheEntry.Container): New field. This is a
18357 temporary hack until the Mono runtime is fixed to distinguish
18358 between ReflectedType and DeclaringType. It allows us to use MCS
18359 with both the MS runtime and the unfixed Mono runtime without
18360 problems and without accecting performance.
18361 (MemberCache.SearchMembers): The DeclaredOnly looping from
18362 TypeManager.MemberLookup is now done here.
18364 2002-08-14 Martin Baulig <martin@gnome.org>
18366 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18367 Type.GetFields on dynamic types but get the fields from the
18368 corresponding TypeContainer.
18369 (MyStructInfo.GetStructInfo): Added check for enum types.
18371 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18372 (MemberList.SyncRoot): Implemented.
18373 (TypeManager.FilterWithClosure): No need to check permissions if
18374 closure_start_type == closure_invocation_type, don't crash if
18375 closure_invocation_type is null.
18377 2002-08-13 Martin Baulig <martin@gnome.org>
18379 Rewrote TypeContainer.FindMembers to use a member cache. This
18380 gives us a speed increase of about 35% for the self-hosting MCS
18381 build and of about 15-20% for the class libs (both on GNU/Linux).
18383 * report.cs (Timer): New class to get enhanced profiling. This
18384 whole class is "TIMER" conditional since it remarkably slows down
18387 * class.cs (MemberList): New class. This is an IList wrapper
18388 which we're now using instead of passing MemberInfo[]'s around to
18389 avoid copying this array unnecessarily.
18390 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18391 (ICachingMemberFinder, IMemberContainer): New interface.
18392 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18393 has already been checked, otherwise use it for the name comparision.
18394 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18395 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18396 if possible. Returns a MemberList, not a MemberInfo [].
18397 (TypeHandle): New class, implements IMemberContainer. We create
18398 one instance of this class per type, it contains a MemberCache
18399 which is used to do the member lookups.
18400 (MemberCache): New class. Each instance of this class contains
18401 all members of a type and a name-based hash table.
18402 (MemberCache.FindMembers): This is our new member lookup
18403 function. First, it looks up all members of the requested name in
18404 the hash table. Then, it walks this list and sorts out all
18405 applicable members and returns them.
18407 2002-08-13 Martin Baulig <martin@gnome.org>
18409 In addition to a nice code cleanup, this gives us a performance
18410 increase of about 1.4% on GNU/Linux - not much, but it's already
18411 half a second for the self-hosting MCS compilation.
18413 * typemanager.cs (IMemberFinder): New interface. It is used by
18414 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18415 Enum, Delegate or Interface.
18416 (TypeManager.finder_to_member_finder): New PtrHashtable.
18417 (TypeManager.finder_to_container): Removed.
18418 (TypeManager.finder_to_delegate): Removed.
18419 (TypeManager.finder_to_interface): Removed.
18420 (TypeManager.finder_to_enum): Removed.
18422 * interface.cs (Interface): Implement IMemberFinder.
18424 * delegate.cs (Delegate): Implement IMemberFinder.
18426 * enum.cs (Enum): Implement IMemberFinder.
18428 * class.cs (TypeContainer): Implement IMemberFinder.
18430 2002-08-12 Martin Baulig <martin@gnome.org>
18432 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18434 2002-08-12 Martin Baulig <martin@gnome.org>
18436 * ecore.cs (ITypeExpression): New interface for expressions which
18438 (TypeExpression): Renamed to TypeLookupExpression.
18439 (Expression.DoResolve): If we're doing a types-only lookup, the
18440 expression must implement the ITypeExpression interface and we
18441 call DoResolveType() on it.
18442 (SimpleName): Implement the new ITypeExpression interface.
18443 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18444 hack, the situation that we're only looking up types can't happen
18445 anymore when this method is called. Moved the type lookup code to
18446 DoResolveType() and call it.
18447 (SimpleName.DoResolveType): This ITypeExpression interface method
18448 is now doing the types-only lookup.
18449 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18450 (ResolveFlags): Added MaskExprClass.
18452 * expression.cs (MemberAccess): Implement the ITypeExpression
18454 (MemberAccess.DoResolve): Added support for a types-only lookup
18455 when we're called via ITypeExpression.DoResolveType().
18456 (ComposedCast): Implement the ITypeExpression interface.
18458 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18459 Expression.Resolve() with ResolveFlags.Type instead.
18461 2002-08-12 Martin Baulig <martin@gnome.org>
18463 * interface.cs (Interface.Define): Apply attributes.
18465 * attribute.cs (Attribute.ApplyAttributes): Added support for
18466 interface attributes.
18468 2002-08-11 Martin Baulig <martin@gnome.org>
18470 * statement.cs (Block.Emit): Only check the "this" variable if we
18471 do not always throw an exception.
18473 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18474 whether the property has a set accessor.
18476 2002-08-11 Martin Baulig <martin@gnome.org>
18478 Added control flow analysis support for structs.
18480 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18481 with control flow analysis turned off.
18482 (IVariable): New interface.
18483 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18484 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18485 (FieldExpr.DoResolve): Resolve the instance expression with flow
18486 analysis turned off and do the definite assignment check after the
18487 resolving when we know what the expression will resolve to.
18489 * expression.cs (LocalVariableReference, ParameterReference):
18490 Implement the new IVariable interface, only call the flow analysis
18491 code if ec.DoFlowAnalysis is true.
18492 (This): Added constructor which takes a Block argument. Implement
18493 the new IVariable interface.
18494 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18495 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18496 This does the definite assignment checks for struct members.
18498 * class.cs (Constructor.Emit): If this is a non-static `struct'
18499 constructor which doesn't have any initializer, call
18500 Block.AddThisVariable() to tell the flow analysis code that all
18501 struct elements must be initialized before control returns from
18504 * statement.cs (MyStructInfo): New public class.
18505 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18506 argument to this indexer. If non-zero, check an individual struct
18507 member, not the whole struct.
18508 (FlowBranching.CheckOutParameters): Check struct members.
18509 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18510 overloaded versions of these methods which take an additional
18511 `int field_idx' argument to check struct members.
18512 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18513 overloaded versions of these methods which take an additional
18514 `string field_name' argument to check struct member.s
18515 (VariableInfo): Implement the IVariable interface.
18516 (VariableInfo.StructInfo): New public property. Returns the
18517 MyStructInfo instance of the variable if it's a struct or null.
18518 (Block.AddThisVariable): New public method. This is called from
18519 Constructor.Emit() for non-static `struct' constructor which do
18520 not have any initializer. It creates a special variable for the
18521 "this" instance variable which will be checked by the flow
18522 analysis code to ensure that all of the struct's fields are
18523 initialized before control returns from the constructor.
18524 (UsageVector): Added support for struct members. If a
18525 variable/parameter is a struct with N members, we reserve a slot
18526 in the usage vector for each member. A struct is considered fully
18527 initialized if either the struct itself (slot 0) or all its
18528 members are initialized.
18530 2002-08-08 Martin Baulig <martin@gnome.org>
18532 * driver.cs (Driver.MainDriver): Only report an error CS5001
18533 if there were no compilation errors.
18535 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18536 `UnsafeContext' property to determine whether the parent is in
18537 unsafe context rather than checking the parent's ModFlags:
18538 classes nested in an unsafe class are unsafe as well.
18540 2002-08-08 Martin Baulig <martin@gnome.org>
18542 * statement.cs (UsageVector.MergeChildren): Distinguish between
18543 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18544 we return. Added test17() and test18() to test-154.cs.
18546 2002-08-08 Martin Baulig <martin@gnome.org>
18548 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18549 Family access, make sure the invoking type isn't a subclass of the
18550 queried type (that'd be a CS1540).
18552 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18553 this method which takes an additional `Type invocation_type'.
18555 * expression.cs (BaseAccess.DoResolve): Use the base type as
18556 invocation and query type.
18557 (MemberAccess.DoResolve): If the lookup failed and we're about to
18558 report a CS0122, try a lookup with the ec.ContainerType - if this
18559 succeeds, we must report a CS1540.
18561 2002-08-08 Martin Baulig <martin@gnome.org>
18563 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18564 (MethodGroupExpr): Implement the IMemberExpr interface.
18566 * expression (MemberAccess.ResolveMemberAccess): No need to have
18567 any special code for MethodGroupExprs anymore, they're now
18570 2002-08-08 Martin Baulig <martin@gnome.org>
18572 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18573 Family, FamANDAssem and FamORAssem permissions.
18574 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18576 2002-08-08 Martin Baulig <martin@gnome.org>
18578 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18579 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18582 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18584 * driver.cs: implemented /resource option to embed managed resources.
18586 2002-08-07 Martin Baulig <martin@gnome.org>
18588 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18589 (FieldBase.HasFieldInitializer): New public property.
18590 (FieldBase.GetInitializerExpression): New public method. Resolves and
18591 returns the field initializer and makes sure it is only resolved once.
18592 (TypeContainer.EmitFieldInitializers): Call
18593 FieldBase.GetInitializerExpression to get the initializer, this ensures
18594 that it isn't resolved multiple times.
18596 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18597 the resolving process (SimpleName/MemberLookup) that we're currently
18598 emitting a field initializer (which must not access any instance members,
18599 this is an error CS0236).
18601 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18602 argument, if the `IsFieldInitializer' flag is set, we must report and
18603 error CS0236 and not an error CS0120.
18605 2002-08-07 Martin Baulig <martin@gnome.org>
18607 * ecore.cs (IMemberExpr): New public interface.
18608 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18609 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18610 if the expression is an IMemberExpr.
18612 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18613 to be null, implicitly default to `this' if we're non-static in
18614 this case. Simplified the code a lot by using the new IMemberExpr
18615 interface. Also fixed bug #28176 here.
18617 2002-08-06 Martin Baulig <martin@gnome.org>
18619 * cs-parser.jay (SimpleLookup): Removed. We need to create
18620 ParameterReferences during semantic analysis so that we can do a
18621 type-only search when resolving Cast, TypeOf and SizeOf.
18622 (block): Pass the `current_local_parameters' to the Block's
18625 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18626 argument to the constructor.
18627 (ConstructorInitializer.Resolve): Create a temporary implicit
18628 block with the parameters.
18630 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18631 references here if we aren't doing a type-only search.
18633 * statement.cs (Block): Added constructor which takes a
18634 `Parameters parameters' argument.
18635 (Block.Parameters): New public property.
18637 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18638 to `Parameters' and made it public readonly.
18640 2002-08-06 Martin Baulig <martin@gnome.org>
18642 * ecore.cs (Expression.Warning): Made this public as well.
18644 * report.cs (Report.Debug): Print the contents of collections.
18646 2002-08-06 Martin Baulig <martin@gnome.org>
18648 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18649 used to tell Resolve() which kinds of expressions it may return.
18650 (Expression.Resolve): Added overloaded version of this method which
18651 takes a `ResolveFlags flags' argument. This can be used to tell
18652 Resolve() which kinds of expressions it may return. Reports a
18654 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18655 ResolveFlags.SimpleName.
18656 (Expression.Error118): Added overloaded version of this method which
18657 takes a `ResolveFlags flags' argument. It uses the flags to determine
18658 which kinds of expressions are allowed.
18660 * expression.cs (Argument.ResolveMethodGroup): New public method.
18661 Resolves an argument, but allows a MethodGroup to be returned.
18662 This is used when invoking a delegate.
18664 * TODO: Updated a bit.
18666 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18668 Fixed compilation with csc.
18670 * ecore.cs: Expression.Error made public. Is this correct? Should
18671 Warning be made public too?
18673 * expression.cs: use ea.Location instead of ea.loc.
18674 [FIXME: Filed as bug #28607: MCS must report these errors.]
18676 2002-08-06 Martin Baulig <martin@gnome.org>
18678 * ecore.cs (Expression.loc): Moved the location here instead of
18679 duplicating it in all derived classes.
18680 (Expression.Location): New public property.
18681 (Expression.Error, Expression.Warning): Made them non-static and
18682 removed the location argument.
18683 (Expression.Warning): Added overloaded version which takes an
18684 `int level' argument.
18685 (Expression.Error118): Make this non-static and removed the
18686 expression and location arguments.
18687 (TypeExpr): Added location argument to the constructor.
18689 * expression.cs (StaticCallExpr): Added location argument to
18691 (Indirection, PointerArithmetic): Likewise.
18692 (CheckedExpr, UnCheckedExpr): Likewise.
18693 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18694 (StringPtr): Likewise.
18697 2002-08-05 Martin Baulig <martin@gnome.org>
18699 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18701 * assign.cs (Assign.DoResolve): Check whether the source
18702 expression is a value or variable.
18704 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18705 while resolving the corresponding blocks.
18707 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18708 an error, don't silently return null.
18710 * statement.cs (Block.AddVariable): Do the error reporting here
18711 and distinguish between CS0128 and CS0136.
18712 (Block.DoResolve): Report all unused labels (warning CS0164).
18713 (LabeledStatement): Pass the location to the constructor.
18714 (LabeledStatement.HasBeenReferenced): New property.
18715 (LabeledStatement.Resolve): Set it to true here.
18717 * statement.cs (Return.Emit): Return success even after reporting
18718 a type mismatch error (CS0126 or CS0127), this is what csc does and
18719 it avoids confusing the users with any consecutive errors.
18721 2002-08-05 Martin Baulig <martin@gnome.org>
18723 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18725 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18727 * expression.cs (MemberAccess.DoResolve): Silently return if an
18728 error has already been reported.
18730 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18731 error has already been reported.
18733 2002-08-05 Martin Baulig <martin@gnome.org>
18735 * statement.cs (UsageVector): Only initialize the `parameters'
18736 vector if we actually have any "out" parameters.
18738 2002-08-05 Martin Baulig <martin@gnome.org>
18740 * expression.cs (Binary.ResolveOperator): When combining delegates,
18741 they must have the same type.
18743 2002-08-05 Martin Baulig <martin@gnome.org>
18745 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18746 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18747 work with the ms runtime and we also don't need it: if we're a
18748 PropertyBuilder and not in the `indexer_arguments' hash, then we
18749 are a property and not an indexer.
18751 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18752 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18753 since the latter one doesn't work with the ms runtime.
18755 2002-08-03 Martin Baulig <martin@gnome.org>
18757 Fixed bugs #27998 and #22735.
18759 * class.cs (Method.IsOperator): New public field.
18760 (Method.CheckBase): Report CS0111 if there's already a method
18761 with the same parameters in the current class. Report CS0508 when
18762 attempting to change the return type of an inherited method.
18763 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18764 and it's not marked abstract or extern.
18765 (PropertyBase): New abstract base class for Property and Indexer.
18766 (PropertyBase.CheckBase): Moved here from Property and made it work
18768 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18769 the same so we can reuse it there.
18770 (Property, Indexer): Derive from PropertyBase.
18771 (MethodSignature.inheritable_property_signature_filter): New delegate
18772 to find properties and indexers.
18774 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18775 argument and improved error reporting.
18777 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18778 EmptyReadOnlyParameters and made it a property.
18780 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18781 version of this method which takes a `PropertyInfo indexer'.
18782 (TypeManager.RegisterIndexer): New method.
18784 * class.cs: Added myself as author of this file :-)
18786 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18788 * class.cs: fixed compilation on windoze.
18790 2002-08-03 Martin Baulig <martin@gnome.org>
18792 * interface.cs (Interface.GetInterfaceBases): Check whether all
18793 base interfaces are at least as accessible than the current one.
18795 * class.cs (TypeContainer.GetClassBases): Check whether base types
18796 are at least as accessible than the current type.
18797 (TypeContainer.AsAccessible): Implemented and made non-static.
18798 (MemberBase.CheckParameters): Report errors if the accessibility
18801 * delegate.cs (Delegate.Delegate): The default visibility is
18802 internal for top-level types and private for nested types.
18803 (Delegate.Define): Report errors if the accessibility checks fail.
18805 * enum.cs (Enum.Enum): The default visibility is internal for
18806 top-level types and private for nested types.
18807 (Enum.DefineType): Compute the correct visibility.
18809 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18810 function which takes a `bool is_toplevel' instead of a TypeContainer.
18812 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18815 2002-08-02 Martin Baulig <martin@gnome.org>
18817 * expression.cs (LocalVariableReferenc): Added constructor which
18818 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18819 (LocalVariableReference.IsReadOnly): New property.
18820 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18821 variable is readonly, use our own readonly flag to do this; you can
18822 use the new constructor to get a writable reference to a read-only
18825 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18826 reference to the local variable.
18828 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18830 * rootcontext.cs (ResolveCore): Also include System.Exception
18832 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18833 we reach an EmptyStatement.
18835 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18838 * expression.cs (Binary.ResolveOperator): Check error result in
18841 use brtrue/brfalse directly and avoid compares to null.
18843 2002-08-02 Martin Baulig <martin@gnome.org>
18845 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18846 Fixes bug #28407, added test-155.cs.
18848 2002-08-01 Martin Baulig <martin@gnome.org>
18850 * class.cs (Event.EmitDefaultMethod): Make this work with static
18851 events. Fixes #28311, added verify-3.cs.
18853 2002-08-01 Martin Baulig <martin@gnome.org>
18855 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18856 `is_disposable' fields.
18857 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18858 `hm.is_disposable' if we're using the collection pattern.
18859 (Foreach.EmitCollectionForeach): Use the correct type for the
18860 enumerator's local variable, only emit the try/finally block if
18861 necessary (fixes #27713).
18863 2002-08-01 Martin Baulig <martin@gnome.org>
18865 * ecore.cs (Expression.report118): Renamed to Error118 and made
18868 * statement.cs (Throw.Resolve): Check whether the expression is of
18869 the correct type (CS0118) and whether the type derives from
18870 System.Exception (CS0155).
18871 (Catch.Resolve): New method. Do the type lookup here and check
18872 whether it derives from System.Exception (CS0155).
18873 (Catch.CatchType, Catch.IsGeneral): New public properties.
18875 * typemanager.cs (TypeManager.exception_type): Added.
18877 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18879 * driver.cs: Updated About function.
18881 2002-07-31 Martin Baulig <martin@gnome.org>
18883 Implemented Control Flow Analysis.
18885 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18886 (EmitContext.CurrentBranching): Added.
18887 (EmitContext.StartFlowBranching): Added.
18888 (EmitContext.EndFlowBranching): Added.
18889 (EmitContext.KillFlowBranching): Added.
18890 (EmitContext.IsVariableAssigned): Added.
18891 (EmitContext.SetVariableAssigned): Added.
18892 (EmitContext.IsParameterAssigned): Added.
18893 (EmitContext.SetParameterAssigned): Added.
18894 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
18895 Added control flow analysis stuff here.
18897 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
18898 resolve the expression as lvalue.
18899 (LocalVariableReference.DoResolve): Check whether the variable has
18900 already been assigned.
18901 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
18902 the parameter as assigned here.
18903 (ParameterReference.DoResolve): Check whether the parameter has already
18905 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
18906 expression as lvalue.
18908 * statement.cs (FlowBranching): New class for the flow analysis code.
18909 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
18910 (LabeledStatement.IsDefined): New public property.
18911 (LabeledStatement.AddUsageVector): New public method to tell flow
18912 analyis that the label may be reached via a forward jump.
18913 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
18915 (VariableInfo.Number): New public field. This is used by flow analysis
18916 to number all locals of a block.
18917 (Block.CountVariables): New public property. This is the number of
18918 local variables in this block (including the locals from all parent
18920 (Block.EmitMeta): Number all the variables.
18922 * statement.cs: Added flow analysis support to all classes.
18924 2002-07-31 Martin Baulig <martin@gnome.org>
18926 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
18927 To get debugging messages, compile mcs with /define:MCS_DEBUG and
18928 then use this argument.
18930 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
18932 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
18933 use this to specify /define options.
18935 2002-07-29 Martin Baulig <martin@gnome.org>
18937 * statement.cs (Fixed): Moved all code that does variable lookups
18938 and resolvings from Emit to Resolve.
18940 * statement.cs (For): Moved all code that does variable lookups
18941 and resolvings from Emit to Resolve.
18943 * statement.cs (Using): Moved all code that does variable lookups
18944 and resolvings from Emit to Resolve.
18946 2002-07-29 Martin Baulig <martin@gnome.org>
18948 * attribute.cs (Attribute.Resolve): Explicitly catch a
18949 System.NullReferenceException when creating the
18950 CustromAttributeBuilder and report a different warning message.
18952 2002-07-29 Martin Baulig <martin@gnome.org>
18954 * support.cs (ParameterData.ParameterName): Added method to
18955 get the name of a parameter.
18957 * typemanager.cs (TypeManager.IsValueType): New public method.
18959 2002-07-29 Martin Baulig <martin@gnome.org>
18961 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
18962 is a flag which specifies that it's either ref or out.
18963 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
18964 the out parameter to `out Parameter.Modifier mod', also set the
18965 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
18967 * support.cs (InternalParameters.ParameterModifier): Distinguish
18968 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18969 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18971 * expression.cs (Argument.GetParameterModifier): Distinguish
18972 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18973 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18975 2002-07-29 Martin Baulig <martin@gnome.org>
18977 * expression.cs (ParameterReference.ParameterReference): Added
18978 `Location loc' argument to the constructor.
18980 * cs-parser.jay: Pass location to ParameterReference.
18982 2002-07-28 Miguel de Icaza <miguel@ximian.com>
18984 * statement.cs (Try): Initialize the location.
18986 * cs-parser.jay: pass location to Try.
18988 * expression.cs (Unary.Reduce): Change the prototype to return
18989 whether a constant fold could be performed or not. The result is
18990 returned in an out parameters. In the case of Indirection and
18991 AddressOf, we want to perform the full tests.
18993 2002-07-26 Miguel de Icaza <miguel@ximian.com>
18995 * statement.cs (Statement.Emit): Flag dead code.
18997 2002-07-27 Andrew Birkett <andy@nobugs.org>
18999 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
19001 2002-07-27 Martin Baulig <martin@gnome.org>
19003 * class.cs (MethodData.Define): Put back call to
19004 TypeManager.AddMethod(), accidentally commented this out.
19006 * report.cs (Debug): New public method to print debugging information,
19007 this is `[Conditional ("DEBUG")]'.
19009 2002-07-26 Martin Baulig <martin@gnome.org>
19011 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
19012 (switch_statement): Push the current_block to the switch_stack and
19013 pop it again when we're done with the switch.
19014 (switch_section): The new block is a child of the current_block.
19015 Fixes bug #24007, added test-152.cs.
19017 2002-07-27 Martin Baulig <martin@gnome.org>
19019 * expression.cs (Invocation.EmitArguments): When calling a varargs
19020 function with only its fixed arguments, we need to pass an empty
19023 2002-07-27 Martin Baulig <martin@gnome.org>
19025 Mono 0.13 has been released.
19027 2002-07-25 Miguel de Icaza <miguel@ximian.com>
19029 * driver.cs: Rename --resource to --linkres, because that is what
19030 we do currently, we dont support --resource yet.
19032 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
19034 2002-07-25 Martin Baulig <martin@gnome.org>
19036 * class.cs (MethodData): New public class. This is a `method builder'
19037 class for a method or one accessor of a Property/Indexer/Event.
19038 (MethodData.GetMethodFlags): Moved here from MemberBase.
19039 (MethodData.ApplyAttributes): Likewise.
19040 (MethodData.ApplyObsoleteAttribute): Likewise.
19041 (MethodData.ApplyConditionalAttribute): Likewise.
19042 (MethodData.ApplyDllImportAttribute): Likewise.
19043 (MethodData.CheckAbstractAndExternal): Likewise.
19044 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
19045 (MethodData.Emit): Formerly known as Method.Emit().
19046 (MemberBase): Moved everything which was specific to a single
19047 accessor/method to MethodData.
19048 (Method): Create a new MethodData and call Define() and Emit() on it.
19049 (Property, Indexer, Event): Create a new MethodData objects for each
19050 accessor and call Define() and Emit() on them.
19052 2002-07-25 Martin Baulig <martin@gnome.org>
19054 Made MethodCore derive from MemberBase to reuse the code from there.
19055 MemberBase now also checks for attributes.
19057 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
19058 (MemberBase.GetMethodFlags): Moved here from class Method and marked
19060 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
19061 `CallingConventions cc' and `Attributes opt_attrs' arguments.
19062 (MemberBase.ApplyAttributes): New virtual method; applies the
19063 attributes to a method or accessor.
19064 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
19065 (MemberBase.ApplyConditionalAttribute): Likewise.
19066 (MemberBase.ApplyDllImportAttribute): Likewise.
19067 (MemberBase.CheckAbstractAndExternal): Likewise.
19068 (MethodCore.ParameterTypes): This is now a property instead of a
19069 method, it's initialized from DoDefineParameters().
19070 (MethodCore.ParameterInfo): Removed the set accessor.
19071 (MethodCore.DoDefineParameters): New protected virtual method to
19072 initialize ParameterTypes and ParameterInfo.
19073 (Method.GetReturnType): We can now simply return the MemberType.
19074 (Method.GetMethodFlags): Override the MemberBase version and add
19075 the conditional flags.
19076 (Method.CheckBase): Moved some code from Define() here, call
19077 DoDefineParameters() here.
19078 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
19079 here to avoid some larger code duplication.
19080 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
19081 ensure that abstract and external accessors don't declare a body.
19083 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
19084 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
19085 lookup in the attribute's parent classes, so we need to abort as soon
19086 as we found the first match.
19087 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
19088 the attribute has no arguments.
19090 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
19093 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19095 * cs-parser.jay: reverted previous patch.
19097 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19099 * cs-parser.jay: fixed bug #22119.
19101 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19103 * attribute.cs: fixed compilation. The error was:
19104 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
19105 be assigned to before control leaves the current method."
19106 [FIXME: Filed as bug #28186: MCS must report this error.]
19108 2002-07-25 Martin Baulig <martin@gnome.org>
19110 * attribute.cs (Attribute.Conditional_GetConditionName): New static
19111 method to pull the condition name ouf of a Conditional attribute.
19112 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
19113 the obsolete message and error flag out of an Obsolete attribute.
19115 * class.cs (Method.GetMethodFlags): New public method to get the
19116 TypeManager.MethodFlags for this method.
19117 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
19119 (Method.Define): Get and apply the Obsolete and Conditional attributes;
19120 if we're overriding a virtual function, set the new private variable
19121 `parent_method'; call the new TypeManager.AddMethod().
19123 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19124 the MethodBuilder and the Method in a PtrHashtable.
19125 (TypeManager.builder_to_method): Added for this purpose.
19126 (TypeManager.MethodFlags): Added IsObsoleteError.
19127 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
19128 Obsolete and Conditional arguments in MethodBuilders. If we discover
19129 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
19130 the message from the attribute.
19132 2002-07-24 Martin Baulig <martin@gnome.org>
19134 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
19135 preprocessor directives, ensure that the argument to #define/#undef is
19136 exactly one identifier and that it's actually an identifier.
19138 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
19141 2002-07-24 Martin Baulig <martin@gnome.org>
19143 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
19144 initialize it to TypeManager.object_type in the constructor.
19145 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
19146 of the `hm.get_current' method if we're using the collection pattern.
19147 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
19148 for the explicit conversion to make it work when we're using the collection
19149 pattern and the `Current' property has a different return type than `object'.
19152 2002-07-24 Martin Baulig <martin@gnome.org>
19154 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
19155 does not match, but don't report any errors. This method is called in
19156 order for all methods in a MethodGroupExpr until a matching method is
19157 found, so we don't want to bail out if the first method doesn't match.
19158 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
19159 matches, report the 123. Fixes #28070.
19161 2002-07-24 Martin Baulig <martin@gnome.org>
19163 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
19164 TypeManager.TypeToCoreType() to the top of the method so the
19165 following equality checks will work. Fixes #28107.
19167 2002-07-24 Martin Baulig <martin@gnome.org>
19169 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
19170 operand is of type uint, and the other operand is of type sbyte,
19171 short or int, the operands are converted to type long." -
19172 Actually do what this comment already told us. Fixes bug #28106,
19175 2002-07-24 Martin Baulig <martin@gnome.org>
19177 * class.cs (MethodBase): New abstract class. This is now a base
19178 class for Property, Indexer and Event to avoid some code duplication
19179 in their Define() and DefineMethods() methods.
19180 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
19181 generic methods for Define() and DefineMethods().
19182 (FieldBase): Derive from MemberBase, not MemberCore.
19183 (Property): Derive from MemberBase, not MemberCore.
19184 (Property.DefineMethod): Moved all the code from this method to the
19185 new MethodBase.DefineAccessor(), just call it with appropriate
19187 (Property.Define): Call the new Property.DoDefine(), this does some
19188 sanity checks and we don't need to duplicate the code everywhere.
19189 (Event): Derive from MemberBase, not MemberCore.
19190 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
19191 accessors, this will also make them work with interface events.
19192 (Indexer): Derive from MemberBase, not MemberCore.
19193 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
19194 (Indexer.Define): Use the new MethodBase functions.
19196 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
19197 argument to the constructor.
19198 (Interface.FindMembers): Added support for interface events.
19199 (Interface.PopluateEvent): Implemented.
19201 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
19203 2002-07-22 Miguel de Icaza <miguel@ximian.com>
19205 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
19206 but this is required to check for a method name being the same as
19207 the containing class.
19211 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19213 * interface.cs: initialize variable.
19215 2002-07-23 Martin Baulig <martin@gnome.org>
19217 Implemented the IndexerName attribute in interfaces.
19219 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
19220 name if this is an explicit interface implementation.
19221 (Indexer.InterfaceIndexerName): New public variable. If we're
19222 implementing an interface indexer, this is the IndexerName in that
19223 interface. Otherwise, it's the IndexerName.
19224 (Indexer.DefineMethod): If we're implementing interface indexer,
19225 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
19226 and Pending.ImplementIndexer methods.
19227 (Indexer.Define): Also define the PropertyBuilder if we're
19228 implementing an interface indexer and this is neither an explicit
19229 interface implementation nor do the IndexerName match the one in
19232 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
19233 If a method is defined here, then we always need to create a proxy
19234 for it. This is used when implementing interface indexers.
19235 (Pending.IsInterfaceIndexer): New public method.
19236 (Pending.ImplementIndexer): New public method.
19237 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
19238 This is used when implementing interface indexers to define a proxy
19240 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
19241 define a proxy if necessary.
19243 * interface.cs (Interface.IndexerName): New public variable.
19244 (Interface.PopulateIndexer): Set the IndexerName.
19245 (Interface.DefineIndexers): New private method. Populate all the
19246 indexers and make sure their IndexerNames match.
19248 * typemanager.cs (IndexerPropertyName): Added support for interface
19251 2002-07-22 Martin Baulig <martin@gnome.org>
19253 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
19254 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
19255 ret if HasReturnLabel.
19256 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
19259 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
19260 and set the ec.LoopBeginTryCatchLevel.
19261 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
19262 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
19263 the current ec.TryCatchLevel, the branch goes out of an exception
19264 block. In this case, we need to use Leave and not Br.
19266 2002-07-22 Martin Baulig <martin@gnome.org>
19268 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
19269 block unless the block does not always return or it is contained in
19270 another try { ... } catch { ... } block. Fixes bug #26506.
19271 Added verify-1.cs to the test suite.
19273 2002-07-22 Martin Baulig <martin@gnome.org>
19275 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
19276 then we do not always return. Fixes bug #24985.
19278 2002-07-22 Martin Baulig <martin@gnome.org>
19280 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19281 lookup on a per-class level; ie. walk up the class hierarchy until we
19282 found at least one applicable method, then choose the best among them.
19283 Fixes bug #24463 and test-29.cs.
19285 2002-07-22 Martin Baulig <martin@gnome.org>
19287 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19288 return types of the methods. The return type is not part of the
19289 signature and we must not check it to make the `new' modifier work.
19290 Fixes bug #27999, also added test-147.cs.
19291 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19293 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19294 on the method's return type.
19296 2002-07-21 Martin Baulig <martin@gnome.org>
19298 * assign.cs: Make this work if the rightmost source is a constant and
19299 we need to do an implicit type conversion. Also adding a few more tests
19300 to test-38.cs which should have caught this.
19302 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19303 target in the makefile for this. The makefile.gnu is primarily intended
19304 for end-users who don't want to debug the compiler.
19306 2002-07-21 Martin Baulig <martin@gnome.org>
19308 * assign.cs: Improved the Assign class so it can now handle embedded
19309 assignments (X = Y = Z = something). As a side-effect this'll now also
19310 consume less local variables. test-38.cs now passes with MCS, added
19311 a few new test cases to that test.
19313 2002-07-20 Martin Baulig <martin@gnome.org>
19315 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19316 instructions. Fixes bug #27977, also added test-146.cs.
19318 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19320 * cs-tokenizer.cs: fixed getHex ().
19322 2002-07-19 Martin Baulig <martin@gnome.org>
19324 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19325 not Type.GetType() to lookup the array type. This is needed when
19326 we're constructing an array of a user-defined type.
19327 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19328 single-dimensional arrays, but also for single-dimensial arrays of
19331 2002-07-19 Martin Baulig <martin@gnome.org>
19333 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19334 this function is called, it's not allowed to share LocalBuilders
19335 among ILGenerators.
19337 2002-07-19 Martin Baulig <martin@gnome.org>
19339 * expression.cs (Argument.Resolve): Report an error 118 when trying
19340 to pass a type as argument.
19342 2002-07-18 Martin Baulig <martin@gnome.org>
19344 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19345 Conv_R_Un for the signed `long' type.
19347 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19349 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19350 `expr' for the temporary result, as that will fail if we do
19351 multiple resolves on the same expression.
19353 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19355 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19356 ec.TypeContainer for looking up aliases.
19358 * class.cs (TypeContainer): Remove LookupAlias from here.
19360 * decl.cs (DeclSpace); Move here.
19362 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19364 * class.cs (FindMembers): Only call filter if the constructor
19365 bulider is not null.
19367 Also handle delegates in `NestedTypes' now. Now we will perform
19368 type lookups using the standard resolution process. This also
19371 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19372 This uses Expressions (the limited kind that can be parsed by the
19373 tree) instead of strings.
19375 * expression.cs (ComposedCast.ToString): Implement, used to flag
19376 errors since now we have to render expressions.
19378 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19381 * ecore.cs (SimpleName.ToString): ditto.
19383 * cs-parser.jay: Instead of using strings to assemble types, use
19384 Expressions to assemble the type (using SimpleName, ComposedCast,
19385 MemberAccess). This should fix the type lookups in declarations,
19386 because we were using a different code path for this.
19388 * statement.cs (Block.Resolve): Continue processing statements
19389 even when there is an error.
19391 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19393 * class.cs (Event.Define): Also remove the `remove' method from
19394 the list of pending items.
19396 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19397 generate more compact code.
19399 2002-07-17 Martin Baulig <martin@gnome.org>
19401 * const.cs (Const.LookupConstantValue): Add support for constant
19402 `unchecked' and `checked' expressions.
19403 Also adding test case test-140.cs for this.
19405 2002-07-17 Martin Baulig <martin@gnome.org>
19407 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19408 check whether mi.ReturnType implements the IEnumerator interface; the
19409 `==' and the IsAssignableFrom() will fail in this situation.
19411 2002-07-16 Ravi Pratap <ravi@ximian.com>
19413 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19416 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19418 * expression.cs: fixed bug #27811.
19420 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19422 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19423 Molaro: when we are a ref, the value already contains a pointer
19424 value, do not take the address of it.
19426 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19427 * removed mb-parser.jay and mb-tokenizer.cs
19429 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19431 * expression.cs: check against the building corlib void type.
19433 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19435 * ecore.cs: fix for valuetype static readonly fields: when
19436 initializing them, we need their address, not the address of a copy.
19438 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19440 * typemanager.cs: register also enum_type in corlib.
19442 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19444 * class.cs: allow calling this (but not base) initializers in structs.
19446 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19448 * ecore.cs: make sure we compare against the building base types
19451 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19453 * typemanager.cs: fix TypeToCoreType() to handle void and object
19454 (corlib gets no more typerefs after this change).
19456 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19458 * expression.cs (ArrayCreation.EmitArrayArguments): use
19459 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19461 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19462 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19463 array indexes, the runtime actually forbids them.
19465 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19466 for array arguments here.
19468 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19469 instead of the default for ValueTypes.
19471 (New.DoEmit): Use IsValueType instead of
19472 IsSubclassOf (value_type)
19473 (New.DoResolve): ditto.
19474 (Invocation.EmitCall): ditto.
19476 * assign.cs (Assign): ditto.
19478 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19479 Statements *are* currently doing part of their resolution during
19482 Expressions do always resolve during resolve, but statements are
19483 only required to propagate resolution to their children.
19485 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19487 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19489 (LoadAssembly): Do not add the dll if it is already specified
19491 (MainDriver): Add the System directory to the link path at the end,
19492 after all the other -L arguments.
19494 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19495 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19496 ldelem.u1) and using the opposite for sbytes.
19498 This fixes Digger, and we can finally run it.
19500 * driver.cs (UnixParseOption): Move the option parsing here.
19501 (CSCParseOption): Implement CSC-like parsing of options.
19503 We now support both modes of operation, the old Unix way, and the
19504 new CSC-like way. This should help those who wanted to make cross
19505 platform makefiles.
19507 The only thing broken is that /r:, /reference: and /lib: are not
19508 implemented, because I want to make those have the same semantics
19509 as the CSC compiler has, and kill once and for all the confussion
19510 around this. Will be doing this tomorrow.
19512 * statement.cs (Unsafe.Resolve): The state is checked during
19513 resolve, not emit, so we have to set the flags for IsUnsfe here.
19515 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19517 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19518 not catch the Error_ObjectRefRequired in SimpleName (as it is
19519 possible to have a class/instance variable name that later gets
19520 deambiguated), we have to check this here.
19522 2002-07-10 Ravi Pratap <ravi@ximian.com>
19524 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19525 make static and put into Expression.
19527 (Event.Define): Register the private field of the event with the
19528 TypeManager so that GetFieldFromEvent can get at it.
19530 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19531 keep track of the private field associated with an event which
19534 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19537 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19539 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19541 * expression.cs (Binary.EmitBranchable): this routine emits the
19542 Binary expression in a branchable context. This basically means:
19543 we need to branch somewhere, not just get the value on the stack.
19545 This works together with Statement.EmitBoolExpression.
19547 * statement.cs (Statement.EmitBoolExpression): Use
19550 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19552 * statement.cs (For): Reduce the number of jumps in loops.
19554 (For): Implement loop inversion for the For statement.
19556 (Break): We can be breaking out of a Try/Catch controlled section
19557 (foreach might have an implicit try/catch clause), so we need to
19558 use Leave instead of Br.
19560 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19561 now). If the instace expression supports IMemoryLocation, we use
19562 the AddressOf method from the IMemoryLocation to extract the
19563 address instead of emitting the instance.
19565 This showed up with `This', as we were emitting the instance
19566 always (Emit) instead of the Address of This. Particularly
19567 interesting when This is a value type, as we dont want the Emit
19568 effect (which was to load the object).
19570 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19572 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19574 * statement.cs (Checked): Set the CheckedState during the resolve
19575 process too, as the ConvCast operations track the checked state on
19576 the resolve process, and not emit.
19578 * cs-parser.jay (namespace_member_declaration): Flag that we have
19579 found a declaration when we do. This is used to flag error 1529
19581 * driver.cs: Report ok when we display the help only.
19583 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19585 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19587 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19589 * cs-tokenizer.cs (define): We also have to track locally the
19590 defines. AllDefines is just used for the Conditional Attribute,
19591 but we also need the local defines for the current source code.
19593 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19595 * statement.cs (While, For, Do): These loops can exit through a
19596 Break statement, use this information to tell whether the
19597 statement is the last piece of code.
19599 (Break): Flag that we break.
19601 * codegen.cs (EmitContexts): New `Breaks' state variable.
19603 2002-07-03 Martin Baulig <martin@gnome.org>
19605 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19606 modifiers in method declarations in structs. Otherwise, you won't
19607 be able to override things like Object.Equals().
19609 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19611 * class.cs (Method, Property, Indexer): Do not allow the public
19612 modifier to be used in explicit interface implementations.
19614 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19615 override modifiers in method declarations in structs
19617 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19619 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19620 integer or real overflow, report an error
19622 2002-07-02 Martin Baulig <martin@gnome.org>
19624 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19625 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19626 to tell the runtime about our newly created System.Object and
19627 System.ValueType types.
19629 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19631 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19632 struct instead of Ldarg/Starg.
19634 2002-07-02 Martin Baulig <martin@gnome.org>
19636 * expression.cs (Indirection.Indirection): Call
19637 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19639 2002-07-02 Martin Baulig <martin@gnome.org>
19641 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19642 ValueType, call TypeManager.TypeToCoreType() on it.
19643 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19644 the OpCodes.Newarr argument.
19646 2002-07-02 Martin Baulig <martin@gnome.org>
19648 * expression.cs (Invocation.EmitCall): When compiling corlib,
19649 replace all calls to the system's System.Array type to calls to
19650 the newly created one.
19652 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19653 System.Array methods.
19654 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19655 from the system's System.Array type which must be replaced.
19657 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19659 * typemanager.cs: load unverifiable_code_ctor so we can build
19660 corlib using the correct type. Avoid using GetTypeCode() with
19662 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19663 TypeManager.object_type to allow building corlib.
19665 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19667 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19669 2002-07-01 Martin Baulig <martin@gnome.org>
19671 * class.cs: Make the last change actually work, we need to check
19672 whether `ifaces != null' to avoid a crash.
19674 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19676 * class.cs: when we build structs without fields that implement
19677 interfaces, we need to add the interfaces separately, since there is
19678 no API to both set the size and add the interfaces at type creation
19681 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19683 * expression.cs: the dimension arguments to the array constructors
19684 need to be converted if they are a long.
19686 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19688 * class.cs: don't emit ldarg.0 if there is no parent constructor
19689 (fixes showstopper for corlib).
19691 2002-06-29 Martin Baulig <martin@gnome.org>
19693 MCS now compiles corlib on GNU/Linux :-)
19695 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19696 ie. check for MethodImplOptions.InternalCall.
19698 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19699 and TypeManager.attribute_type are null, so we must explicitly check
19700 whether parent is not null to find out whether it's an attribute type.
19701 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19702 and SetBuilder, not only if the property is neither abstract nor external.
19703 This is necessary to set the MethodImplOptions on the accessor methods.
19704 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19705 SetBuilder, see Property.Emit().
19707 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19708 populate "System.Object", "System.ValueType" and "System.Attribute" since
19709 they've already been populated from BootCorlib_PopulateCoreTypes().
19711 2002-06-29 Martin Baulig <martin@gnome.org>
19713 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19714 is the NullLiteral, we also need to make sure that target_type is not
19717 2002-06-29 Martin Baulig <martin@gnome.org>
19719 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19720 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19721 before calling BootstrapCorlib_ResolveDelegate ().
19723 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19725 * statement.cs: fixed build-breaker. All tests passed ok.
19727 2002-06-27 Martin Baulig <martin@gnome.org>
19729 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19730 for System.Decimal when compiling corlib.
19732 2002-06-27 Martin Baulig <martin@gnome.org>
19734 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19735 switch blocks which contain nothing but a default clause.
19737 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19739 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19741 2002-06-27 Martin Baulig <martin@gnome.org>
19743 * ecore.cs (PropertyExpr.PropertyExpr): Call
19744 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19746 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19747 is already a TypeBuilder.
19749 2002-06-27 Martin Baulig <martin@gnome.org>
19751 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19752 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19753 the "from an array-type to System.Array" case. This makes it work
19754 when compiling corlib.
19756 2002-06-27 Martin Baulig <martin@gnome.org>
19758 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19759 non-static PropertyExpr, set its InstanceExpression. This makes
19760 the `ICollection.Count' property work in System/Array.cs.
19762 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19764 * driver.cs: Made error handling more consistent. Errors now
19765 tracked by Report class, so many methods which used to return int
19766 now return void. Main() now prints success/failure and
19767 errors/warnings message.
19769 Renamed '--probe' compiler argument to '--expect-error'. Removed
19770 the magic number return values (123 and 124). Now, if the
19771 expected error occurs, the compiler exits with success (exit value
19772 0). If the compilation completes without seeing that particular
19773 error, the compiler exits with failure (exit value 1). The
19774 makefile in mcs/errors has been changed to handle the new behaviour.
19776 * report.cs: Made 'expected error' number a property and renamed
19777 it from 'Probe' to 'ExpectedError'.
19779 * genericparser.cs: Removed error handling support, since it is
19780 now all done by Report class.
19782 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19783 class, so parse() no longer returns an int.
19785 * namespace.cs: Use Report.Error instead of GenericParser.error
19787 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19789 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19790 TypeContainer.AddOperator): At the front of the list put the
19791 explicit implementations, so they get resolved/defined first.
19793 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19795 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19796 interface type is implemented by this TypeContainer. Used during
19797 explicit interface implementation.
19799 (Property.Define, Indexer.Define, Method.Define): Validate that
19800 the given interface in the explicit implementation is one of the
19801 base classes for the containing type.
19803 Also if we are explicitly implementing an interface, but there is
19804 no match in the pending implementation table, report an error.
19806 (Property.Define): Only define the property if we are
19807 not explicitly implementing a property from an interface. Use the
19808 correct name also for those properties (the same CSC uses,
19809 although that is really not needed).
19811 (Property.Emit): Do not emit attributes for explicitly implemented
19812 properties, as there is no TypeBuilder.
19814 (Indexer.Emit): ditto.
19816 Hiding then means that we do not really *implement* a pending
19817 implementation, which makes code fail.
19819 2002-06-22 Martin Baulig <martin@gnome.org>
19821 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19822 the return value of Object.GetType(). [FIXME: we need to do this whenever
19823 we get a type back from the reflection library].
19825 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19827 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19829 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19831 * attribute.cs: Return null if we can not look up the type.
19833 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19834 the interface types found.
19836 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19837 interface types found.
19839 * typemanager.cs (GetInterfaces): Make this routine returns alll
19840 the interfaces and work around the lame differences between
19841 System.Type and System.Reflection.Emit.TypeBuilder in the results
19842 result for GetInterfaces.
19844 (ExpandInterfaces): Given an array of interface types, expand and
19845 eliminate repeated ocurrences of an interface. This expands in
19846 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19849 2002-06-21 Martin Baulig <martin@gnome.org>
19851 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19854 2002-06-21 Martin Baulig <martin@gnome.org>
19856 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19857 and called with one of the core types, return the corresponding typebuilder for
19860 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19863 2002-06-21 Martin Baulig <martin@gnome.org>
19865 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19866 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19867 (Expression.ConvertReferenceExplicit): Likewise.
19869 * expression.cs (ElementAccess.DoResolve): Likewise.
19870 (ElementAccess.DoResolveLValue): Likewise.
19872 2002-06-10 Martin Baulig <martin@gnome.org>
19874 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19875 add the "value" parameter to the parameter list.
19877 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19880 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19882 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19883 the argument to an int, uint, long or ulong, per the spec. Also
19884 catch negative constants in array creation.
19886 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
19888 * class.cs: do not allow the same interface to appear twice in
19889 the definition list.
19891 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
19893 * ecore.cs: don't use ldlen with System.Array.
19895 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
19897 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
19899 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
19901 * modifiers.cs: produce correct field attributes for protected
19902 internal. Easy fix so miguel can work on ther harder stuff:-)
19904 2002-06-18 Miguel de Icaza <miguel@ximian.com>
19906 * pending.cs: New file. Move the code from class.cs here.
19907 Support clearning the pending flag for all methods (when not doing
19908 explicit interface implementation).
19910 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
19912 * rootcontext.cs: added a couple more types needed to bootstrap.
19914 2002-06-17 Miguel de Icaza <miguel@ximian.com>
19916 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
19917 constructor in the type, instead of any constructor in the type
19918 hierarchy. Thanks to Paolo for finding this bug (it showed up as
19919 a bug in the Mono runtime when applying the params attribute).
19921 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19922 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
19924 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
19926 * expression.cs (Unary.ResolveOperator): Use TypeManager
19927 to resolve the type.
19929 2002-06-13 Ravi Pratap <ravi@ximian.com>
19931 * cs-parser.jay (enum_member_declaration): Pass in the attributes
19934 * enum.cs (AddEnumMember): Add support to store the attributes associated
19935 with each member too.
19937 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
19938 field builders too - this takes care of the enum member case.
19940 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
19942 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
19943 address-of operator on both value types and pointers.
19945 2002-06-10 Martin Baulig <martin@gnome.org>
19947 * interface.cs (Interface.PopulateIndexer): Add the indexer's
19948 PropertyBuilder to the `property_builders' list.
19950 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
19951 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
19952 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
19953 find any indexers which are inherited from an interface.
19955 2002-06-09 Martin Baulig <martin@gnome.org>
19957 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
19958 the same type as the constant if necessary. There's also a test-130.cs
19961 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
19963 * typemanager.cs (TypeManager.ChangeType): Previously known as
19964 Enum.ChangeEnumType().
19966 2002-06-09 Martin Baulig <martin@gnome.org>
19968 * expression.cs (Cast.TryReduce): Added support for consts.
19970 2002-06-08 Ravi Pratap <ravi@ximian.com>
19972 * class.cs (Accessor): Hold attributes information so we can pass
19975 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
19976 Modify to pass in attributes attached to the methods.
19978 (add_accessor_declaration, remove_accessor_declaration): Ditto.
19980 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
19981 to handle the Accessor kind :-)
19983 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
19985 2002-06-08 Martin Baulig <martin@gnome.org>
19987 * expression.cs (Unary.TryReduceNegative): Added support for
19990 2002-06-08 Martin Baulig <martin@gnome.org>
19992 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
19993 name can't be found in the `defined_names' - the caller will do a
19994 MemberLookup in this case and thus find methods in System.Enum
19995 such as Enum.IsDefined().
19997 2002-06-08 Martin Baulig <martin@gnome.org>
19999 * enum.cs (Enum.ChangeEnumType): This is a custom version of
20000 Convert.ChangeType() which works with TypeBuilder created types.
20001 (Enum.LookupEnumValue, Enum.Define): Use it here.
20003 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
20004 `TypeBuilder.BaseType != null' check.
20005 (TypeContainer.FindMembers): Only lookup parent members if we
20006 actually have a parent.
20007 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
20008 (ConstructorInitializer.Resolve): Likewise.
20010 * interface.cs (Interface.FindMembers): Added
20011 `TypeBuilder.BaseType != null' check.
20013 * rootcontext.cs (RootContext.ResolveCore): Added
20014 "System.Runtime.CompilerServices.IndexerNameAttribute" to
20015 classes_second_stage.
20017 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20018 debug_type and trace_type when compiling with --nostdlib.
20020 2002-06-07 Martin Baulig <martin@gnome.org>
20022 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
20023 (AddField): Set it to true when adding a non-static field.
20024 (DefineType): Use `have_nonstatic_fields' to find out whether we
20025 have non-static fields, not `Fields != null'.
20027 2002-06-02 Miguel de Icaza <miguel@ximian.com>
20029 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
20030 dereferencing a null on the static-field code path)
20032 2002-05-30 Martin Baulig <martin@gnome.org>
20034 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
20035 to take command line arguments. Use reflection to call the new
20036 custom `Initialize' function on the symbol writer and pass it the
20037 command line arguments.
20039 * driver.cs (--debug-args): New command line argument to pass command
20040 line arguments to the symbol writer.
20042 2002-05-28 Miguel de Icaza <miguel@ximian.com>
20044 * assign.cs (DoResolve): Forgot to do the implicit conversion to
20045 the target type for indexers and properties. Thanks to Joe for
20048 2002-05-27 Miguel de Icaza <miguel@ximian.com>
20050 * typemanager.cs (MethodFlags): returns the method flags
20051 (Obsolete/ShouldIgnore) that control warning emission and whether
20052 the invocation should be made, or ignored.
20054 * expression.cs (Invocation.Emit): Remove previous hack, we should
20055 not do this on matching a base type, we should do this based on an attribute
20057 Only emit calls to System.Diagnostics.Debug and
20058 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
20059 on the command line.
20061 * rootcontext.cs: Global settings for tracing and debugging.
20063 * cs-tokenizer.cs (define): New utility function to track
20064 defines. Set the global settings for TRACE and DEBUG if found.
20066 2002-05-25 Ravi Pratap <ravi@ximian.com>
20068 * interface.cs (Populate*): Pass in the TypeContainer as well as
20069 the DeclSpace as parameters so that we can create EmitContexts and
20070 then use that to apply attributes etc.
20072 (PopulateMethod, PopulateEvent, PopulateProperty)
20073 (PopulateIndexer): Apply attributes everywhere.
20075 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
20078 (ApplyAttributes): Update accordingly.
20080 We now apply interface attributes for all members too.
20082 2002-05-26 Miguel de Icaza <miguel@ximian.com>
20084 * class.cs (Indexer.Define); Correctly check if we are explicit
20085 implementation (instead of checking the Name for a ".", we
20086 directly look up if the InterfaceType was specified).
20088 Delay the creation of the PropertyBuilder.
20090 Only create the PropertyBuilder if we are not an explicit
20091 interface implementation. This means that explicit interface
20092 implementation members do not participate in regular function
20093 lookups, and hence fixes another major ambiguity problem in
20094 overload resolution (that was the visible effect).
20096 (DefineMethod): Return whether we are doing an interface
20099 * typemanager.cs: Temporary hack until we get attributes in
20100 interfaces (Ravi is working on that) and we get IndexerName
20101 support in interfaces.
20103 * interface.cs: Register the indexers as properties.
20105 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
20106 warning, I have verified that this is a bug in the .NET runtime
20107 (JavaScript suffers of the same problem).
20109 * typemanager.cs (MemberLookup): When looking up members for
20110 interfaces, the parent of an interface is the implicit
20111 System.Object (so we succeed in searches of Object methods in an
20112 interface method invocation. Example: IEnumerable x; x.ToString
20115 2002-05-25 Miguel de Icaza <miguel@ximian.com>
20117 * class.cs (Event): Events should also register if they do
20118 implement the methods that an interface requires.
20120 * typemanager.cs (MemberLookup); use the new GetInterfaces
20123 (GetInterfaces): The code used to lookup interfaces for a type is
20124 used in more than one place, factor it here.
20126 * driver.cs: Track the errors at the bottom of the file, we kept
20129 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
20130 instance if the method we are calling is static!
20132 2002-05-24 Miguel de Icaza <miguel@ximian.com>
20134 * attribute.cs (ApplyAttributes): Make this function filter out
20135 the IndexerName attribute (as that attribute in reality is never
20136 applied) and return the string constant for the IndexerName
20139 * class.cs (TypeContainer.Emit): Validate that all the indexers
20140 have the same IndexerName attribute, and if so, set the
20141 DefaultName attribute on the class.
20143 * typemanager.cs: The return value might contain other stuff (not
20144 only methods). For instance, consider a method with an "Item"
20145 property and an Item method.
20147 * class.cs: If there is a problem with the parameter types,
20150 2002-05-24 Ravi Pratap <ravi@ximian.com>
20152 * ecore.cs (ImplicitConversionExists): Wrapper function which also
20153 looks at user defined conversion after making a call to
20154 StandardConversionExists - we need this for overload resolution.
20156 * expression.cs : Update accordingly the various method calls.
20158 This fixes 2 bugs filed against implicit user defined conversions
20160 2002-05-22 Miguel de Icaza <miguel@ximian.com>
20162 * statement.cs: Track the result of the assignment.
20164 2002-05-21 Miguel de Icaza <miguel@ximian.com>
20166 * expression.cs (MemberAccess): Improved error reporting for
20167 inaccessible members.
20169 2002-05-22 Martin Baulig <martin@gnome.org>
20171 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
20172 itself with debugging support.
20174 2002-05-22 Martin Baulig <martin@gnome.org>
20176 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
20177 Removed, this isn't needed anymore.
20179 2002-05-20 Martin Baulig <martin@gnome.org>
20181 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
20182 be underlying type for an enum.
20184 2002-05-20 Miguel de Icaza <miguel@ximian.com>
20186 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
20187 that splits out the loading of just the core types.
20189 * rootcontext.cs (ResolveCore): Split the struct resolution in
20190 two, so we can load the enumeration underlying types before any
20193 * expression.cs (Is): Bandaid until we fix properly Switch (see
20194 bug #24985 for details).
20196 * typemanager.cs (ImplementsInterface): The hashtable will contain
20197 a null if there are no interfaces implemented.
20199 2002-05-18 Miguel de Icaza <miguel@ximian.com>
20201 * cs-parser.jay (indexer_declarator): It is fine to have array
20204 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20206 * typemanager.cs: (RegisterBuilder): New function used to register
20207 TypeBuilders that implement interfaces. Since
20208 TypeBuilder.GetInterfaces (as usual) does not work with lame
20210 (AddUserType): register interfaces.
20212 (ImplementsInterface): Use the builder_to_ifaces hash if we are
20213 dealing with TypeBuilder. Also, arrays are showing up as
20214 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
20215 methods can not be invoked on them!
20217 * ecore.cs (ExplicitReferenceConversionExists): Made public.
20218 (ImplicitReferenceConversionExists): Split out from
20219 StandardConversionExists.
20221 * expression.cs (As): We were only implementing one of the three
20222 cases for the as operator. We now implement them all.
20223 (Is): Implement the various other cases for Is as well.
20225 * typemanager.cs (CACHE): New define used to control if we want or
20226 not the FindMembers cache. Seems to have a negative impact on
20227 performance currently
20229 (MemberLookup): Nested types have full acess to
20230 enclosing type members
20232 Remove code that coped with instance/static returns for events, we
20233 now catch this in RealFindMembers.
20235 (RealFindMembers): only perform static lookup if the instance
20236 lookup did not return a type or an event.
20238 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20240 * assign.cs (CompoundAssign): We pass more semantic information
20241 now to Compound Assignments than we did before: now we have all
20242 the information at hand, and now we resolve the target *before* we
20243 do the expression expansion, which allows the "CacheValue" method
20244 to have the effect we intended (before, a [x] += 1 would generate
20245 two differen ArrayAccess expressions from the ElementAccess,
20246 during the resolution process).
20248 (CompoundAssign.DoResolve): Resolve target and original_source here.
20250 2002-05-16 Miguel de Icaza <miguel@ximian.com>
20252 * expression.cs (ArrayAccess): dropped debugging information.
20254 * typemanager.cs: Small bug fix: I was always returning i_members,
20255 instead of one of i_members or s_members (depending on which had
20258 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
20259 method is invoked before any code generation takes place, and it
20260 is a mechanism to inform that the expression will be invoked more
20261 than once, and that the method should use temporary values to
20262 avoid having side effects
20264 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
20266 * ecore.cs (Expression.CacheTemporaries): Provide empty default
20269 * expression.cs (Indirection, ArrayAccess): Add support for
20270 CacheTemporaries in these two bad boys.
20272 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
20273 ldobj or ldind_ref.
20274 (StoreFromPtr): Handle stobj as well.
20276 * expression.cs (UnaryMutator): Share more code.
20278 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20279 down: I was not tracking the Filter function as well, which
20280 was affecting the results of the cache.
20282 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20284 * attribute.cs: Remove the hack to handle the CharSet property on
20287 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20289 * attribute.cs (DoResolve): More uglyness, we now only try to
20290 resolve the attribute partially, to extract the CharSet
20291 information (only if we are a StructLayout attribute). Otherwise
20293 (GetExtraTypeInfo): Add some code to conditionally kill in the
20294 future this. I am more and more convinced that the .NET
20295 framework has special code to handle the attribute setting on
20298 * expression.cs (IsParamsMethodApplicable): Revert my previous
20299 foreach change here, it was wrong.
20301 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20303 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20304 (pp_expr): do not abort on unknown input, just return.
20305 (eval): abort if there are pending chars.
20307 * attribute.cs (Attribute.Resolve): Positional parameters are
20308 optional. Deal with that case.
20310 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20311 the Ansi/Unicode/Auto information for the type.
20313 (TypeContainer.DefineType): instantiate the EmitContext here, as
20314 we will be using it during the type definition (to resolve
20315 attributes) and during the emit phase.
20317 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20318 to pull type information out of the attributes
20320 (Attribute.Resolve): track the constructor builder, and allow for
20321 multiple invocations (structs and classes will use this).
20323 * ecore.cs (MemberLookupFinal): new version with all the
20324 parameters customizable.
20326 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20327 constructors. Return if the result value is null (as the error
20328 would have been flagged already by MemberLookupFinal)
20330 Do not allow instances of abstract classes or interfaces to be
20333 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20334 We have to compare the assembly property here when dealing with
20335 FamANDAssem and Assembly access modifiers, because we might be
20336 creating an assembly from *modules* (that means that we are not
20337 getting TypeBuilders for types defined in other modules that are
20338 part of this assembly).
20340 (Method.Emit): If the method is marked abstract and has a body,
20343 (TypeContainer.DefineMembers): If both the defined member and the
20344 parent name match are methods, then do not emit any warnings: let
20345 the Method.Define routine take care of flagging warnings. But if
20346 there is a mismatch (method overrides something else, or method is
20347 overriwritten by something, then emit warning).
20349 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20350 set to null, this means `do not check for the return type on the
20353 (Method.Define): set the return type for the method signature to
20354 null, so that we get methods with the same name and parameters and
20355 different return types. This is used to flag warning 114 (you are
20356 hiding a method, and you probably want to use the new/override
20359 * typemanager.cs (MemberLookup): Implemented proper access
20360 control, closing a long standing set of bug reports. The problem
20361 was that the Framework only has two bits: Public and NonPublic,
20362 and NonPublic includes private and protected methods, but we need
20363 to enforce the FamANDAssem, FamOrAssem and Family.
20365 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20367 * statement.cs (GotoCase): Return true: Ammounts to giving up
20368 knowledge on whether we return or not, and letting the other case
20369 be responsible for it.
20371 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20373 * driver.cs: Do not load directories for each file processed, only
20374 do it if there is a pattern.
20376 * ecore.cs: Report readonly assigns here as well, as we might have
20377 been resolved only by MemberAccess.
20379 (SimpleName.SimpleNameResolve): Also be useful for LValue
20380 resolution. We need this to propagate assign to local readonly variables
20382 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20383 do not want to reuse potential criteria memory.
20385 * class.cs (MyEventBuilder): Set reflected_type;
20387 * ecore.cs (Constantify): Added support for constifying bools.
20389 (RootContext.LookupType): Added a cache for values looked up in
20390 the declaration space.
20392 * typemanager.cs (FindMembers): Now is a front-end to
20393 RealFindMembers, and provides a two-level hashtable-based cache to
20396 15% performance improvement: from 22.5 to 19.2 seconds.
20398 * expression.cs (IsParamsMethodApplicable): use foreach.
20399 (Invocation.DoResolve): ditto.
20400 (New.DoResolve): ditto.
20401 (ArrayCreation.DoResolve): ditto.
20403 * ecore.cs (FindMostEncompassingType): use foreach.
20405 * delegate.cs (NewDelegate.DoResolve): Use foreach
20407 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20408 (RemoveMethods): use foreach.
20410 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20411 nested foreach statements instead of for, and also break out of
20412 the inner loop once a match is found.
20414 (Invocation.OverloadResolve): Use foreach, simplify the code.
20416 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20418 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20419 we actually unwrap the expression to allow for extra information
20422 * expression.cs: Use Shr_Un on unsigned operations.
20424 2002-05-08 Ravi Pratap <ravi@ximian.com>
20426 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20427 applicable operators was not being considered correctly. This closes
20428 the bug Miguel reported.
20430 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20432 * attribute.cs: check that the type derives from System.Attribute
20433 and report the correct error in that case (moved the duplicate code to
20434 its own method, too).
20436 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20438 * attribute.cs: lookup attribute type name as the spec says: first the
20439 bare attribute name and then name + "Attribute" (nant compiles with
20440 mcs after this fix).
20442 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20444 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20445 Because of the way we parse things, we should try to see if a
20446 UIntConstant can fit in an integer.
20448 2002-05-07 Ravi Pratap <ravi@ximian.com>
20450 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20451 when we are in an explicit context.
20453 (ConvertReferenceExplicit): When converting from Iface type S to Class
20454 T make sure the rules are implemented as an OR.
20456 * parameter.cs (ParameterType): Make it a property for now although the
20457 purpose really isn't anything immediate.
20459 * expression.cs (Is*Applicable): Do better checking on the parameter type
20460 of a ref/out parameter. The ones from the system assemblies are already
20461 marked with the correct type so we don't need to do any correction.
20463 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20464 the object type is standard too so include that.
20466 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20468 * ecore.cs (StandardConversionExists): Augment with missing code:
20469 deal with IntConstant, LongConstants and Enumerations.
20471 * assign.cs: Report the error, instead of failing silently
20473 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20474 typecontainer that they are declared, because the
20475 typecontainer/namespace will have the list of using clauses that
20476 need to be applied.
20478 Assembly Attributes were escaping the normal registration
20481 (EmitCode): Apply attributes within an EmitContext that represents
20482 the container they were declared on.
20484 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20486 2002-05-06 Ravi Pratap <ravi@ximian.com>
20488 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20489 Revamp completely - make much cleaner as we now operate only
20492 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20493 to implement the logic detailed in the spec more correctly.
20495 (UserDefinedConversion): Update accordingly.
20497 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20499 * statement.cs: Return flow analysis information up.
20501 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20504 (token): Do not consume an extra character before calling
20507 2002-05-06 Piers Haken <piersh@friskit.com>
20509 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20511 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20513 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20514 EmitContext during the instance constructor initializer
20515 resolution, to stop access to instance variables.
20517 This is mandated by the spec, last paragraph of the `constructor
20518 initializers' section.
20520 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20522 * cs-parser.jay, class.cs (Accessor): new class used to represent
20523 an accessor (get or set). In the past we used `null' to represent
20524 a missing accessor. But this is ambiguous because there was no
20525 way to tell in abstract indexers/properties if one of them was
20528 Now there is a way of addressing that.
20530 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20531 instead of FindMembers.
20533 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20534 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20536 * attribute.cs: Treat indexers and properties as the same in terms
20537 of applying attributes
20539 * ecore.cs (FindMostEncompassedType): Use statically initialized
20540 EmptyExpressions()s like we do elsewhere to avoid creating useless
20541 objects (and we take this out of the tight loop).
20543 (GetConversionOperators): Move the code to extract the actual
20544 operators to a separate routine to clean things up.
20546 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20548 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20549 events are always registered FieldBuilders.
20551 * class.cs (FieldBase): New class shared by Fields
20553 * delegate.cs: If we are a toplevel delegate, use our full name.
20554 If we are a nested delegate, then only use our tail name.
20556 2002-05-02 Ravi Pratap <ravi@ximian.com>
20558 * expression.cs (IsApplicable): Ensure that we add the "&" to
20559 ref/out types before comparing it with the type of the argument.
20561 (IsParamsMethodApplicable): Ditto.
20563 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20566 * delegate.cs : Handle the case when we have more than one applicable
20567 method. Flag an error only when we finish checking all.
20569 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20571 * expression.cs: Add support for boolean static initializers.
20573 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20575 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20577 * parameter.cs (ComputeParameterTypes,
20578 ComputeAndDefineParameterTypes): Better error handling: now we
20579 clear the `types' cache if we fail during any of the type lookups.
20580 We also return the status code correctly to our caller
20582 * delegate.cs: If we fail to define a delegate, abort the extra
20585 * expression.cs (Binary.ResolveOperator): for
20586 operator==(object,object) and operator !=(object, object) we also
20587 have to verify that there is an implicit conversion from one to
20590 (ArrayAccess.DoResolve): Array Access can operate on
20593 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20595 * assign.cs (CompoundAssign): A new class used as a "flag" that
20596 the assignment actually is happening as part of a compound
20597 assignment operator.
20599 During compound assignment, a few new rules exist to enable things
20606 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20607 to the type of x) if y is implicitly convertible to the type of x,
20608 and the operator is a builtin operator and the return type of the
20609 operator is explicitly convertible to the type of x.
20611 * rootcontext.cs: Reset warning level to 2. 4 catches various
20612 "interesting" features in mcs, we must clean this up at some
20613 point, but currently am trying to kill other bugs ;-)
20615 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20616 in container classes as well.
20618 * expression.cs (Binary.ResolveOperator): Handle string case
20619 before anything else (as operator overloading does emit an error
20620 before doing anything else).
20622 This code could go away when we move to a table driven model, but
20623 i could not come up with a good plan last night.
20625 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20627 * typemanager.cs (CSharpName): reimplementation using regex.
20628 * class.cs: added null check for fields in Emit
20629 * rootcontext.cs: set warninglevel to 4
20631 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20633 * typemanager.cs (CSharpName): reimplemented with Lupus
20636 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20638 * statement.cs (If): correclty implement Resolve, because we were
20639 not catching sem errors in there. The same process is needed
20641 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20644 (Statement.Warning_DeadCodeFound): Factorize code.
20645 (While): Report dead code here too.
20647 (Statement): Added Resolve virtual method to allow
20648 for resolution split from the emit code.
20650 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20652 * statement.cs (EmitBoolExpression): No longer try to resolve the
20654 (MakeBoolean): New utility function that resolve, implicitly
20655 converts to boolean and tags the expression.
20658 (If, Do): Implement dead code elimination.
20659 (While): Implement loop inversion
20661 (Do, While, For, If): Resolve the expression prior to calling our
20664 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20667 - added method Report28 (warning: program has more than one entry point)
20668 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20669 - modified method Method.Define, the part at the end of the method
20671 * rootcontext.cs: added static public Location EntryPointLocation;
20673 * ../errors/cs0028.cs : Add test case for the above warning.
20676 - modified method CSharpName to allow arrays of primitive type to
20677 be printed nicely (e.g. instead of System.Int32[][] it now prints
20679 - added method CSharpSignature: returns the signature of a method
20680 in string format to be used in reporting errors, warnings, etc.
20682 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20685 2002-04-26 Ravi Pratap <ravi@ximian.com>
20687 * delegate.cs (Define): Fix extremely silly bug where I was
20688 setting the type of the 'object' parameter of the BeginInvoke
20689 method to System.IAsyncResult instead of System.Object ;-)
20691 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20693 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20696 (Constructor.Emit): return if we fail to initialize the
20697 constructor. Another door closed!
20699 * expression.cs (New.DoResolve): Improve error message (from -6 to
20700 1501). Use DeclaredOnly lookup to find the exact constructor.
20702 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20703 loop. This is useful.
20705 * cs-parser.jay: Adjust the default parameters so that destructors
20706 have the proper signature.
20708 2002-04-26 Martin Baulig <martin@gnome.org>
20710 * driver.cs (LoadAssembly): If `assembly' contains any characters
20711 which are only valid in path names and not in assembly names
20712 (currently slash, backslash and point), use Assembly.LoadFrom ()
20713 instead of Assembly.Load () on the `assembly' (before iteration
20714 over the link_paths).
20716 2002-04-26 Martin Baulig <martin@gnome.org>
20718 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20720 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20722 * class.cs (Property): use the new typemanager.MemberLookup
20724 (TypeContainer.MemberLookup): Implement using the
20725 TypeManager.MemberLookup now.
20727 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20728 and return MemberInfos, so that these can be used without an
20729 EmitContext (what we had before).
20731 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20733 * expression.cs: Fix the case where the argument to params if the
20734 type of the params. I omitted handling this before. Fixed
20736 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20738 * driver.cs: Call BootCorlib_PopulateCoreType
20740 * class.cs (Property.CheckBase): Check for properties only, not
20743 * interface.cs: Temporary hack: try/catch around the
20744 CustomAttributeBuilder, because I am getting an exception that I
20747 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20748 types whose definitions are required to be there (attributes are
20749 defined before standard types).
20751 Compute definitions as we boot the various types, as they are used
20752 immediately (value_type class will need object_type, but if we do
20753 not initialize object_type, we will pass a null, which will let
20754 the runtime pick the System.Object from the existing corlib, which
20755 is not what we want).
20757 2002-04-22 Patrik Torstensson <totte@labs2.com>
20759 * cs-tokenizer.cs: fixed a number of trim() issues.
20761 2002-04-22 Ravi Pratap <ravi@ximian.com>
20763 * expression.cs (Argument.Type): Ensure that we return the correct
20764 type when we have out or ref parameters [in which case we
20767 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20769 * class.cs (Property, Indexer): Allow extern modifier in there.
20771 * typemanager.cs (InitBaseTypes): Initializes object_type and
20772 value_type, since those will be used early on during the bootstrap
20773 process to compile corlib.
20775 (InitCoreTypes): Move code from here to InitBaseTypes.
20777 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20779 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20780 single-dimension arrays as using the ldlen opcode.
20782 Daniel Lewis discovered this optimization.
20784 * typemanager.cs: Add signature for System.Array::get_Length
20786 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20788 * statement.cs: report the error when the foreach does not apply to an
20789 array nor a collection.
20791 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20793 * expression.cs: Add implicit conversions to the operator ~.
20795 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20797 * typemanager.cs: Locate the decimal constructor.
20799 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20801 * attribute.cs: use the new property of TypeOf.
20802 * expression.cs: added 'get' property around typearg.
20804 These changes fix a build breaker reported by NickD. Is this the
20805 correct way to fix? If not, please, revert my changes and make it
20808 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20810 * attribute.cs: Add support for typeof in attribute invocations.
20811 I am not sure that this is right though.
20813 2002-04-14 Duncan Mak <duncan@ximian.com>
20815 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20816 Binary.Operator.Division case.
20818 2002-04-13 Ravi Pratap <ravi@ximian.com>
20820 * class.cs (DefineType): Ensure that we do a proper check on
20821 attribute types and also register it with the TypeManager.
20823 (TypeContainer.Targets): The default for attribute types is
20824 AttributeTargets.All.
20826 * attribute.cs (ApplyAttributes): Registering the attribute type
20827 is done elsewhere, not when we discover we have a Usage attribute.
20829 2002-04-12 Ravi Pratap <ravi@ximian.com>
20831 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20832 and get rid of is_delegate parameter.
20834 * everywhere : update.
20836 2002-04-12 Ravi Pratap <ravi@ximian.com>
20838 * cs-parser.jay (compilation_unit): Revamp completely to use
20839 some new ideas that I got from Rhys' grammar to solve the problems
20840 with assembly level attributes.
20842 (outer_declaration): New grammar production.
20844 (attribute_sections): Add.
20846 (opt_attributes): Base on attribute_sections
20848 (namespace_declaration): Allow opt_attributes to tackle the case
20849 when we have assembly level attributes - we are clever in this
20852 * attribute.cs (ApplyAttributes): Do not worry about assembly
20853 attributes in the non-global context.
20855 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20856 instead of SetGlobalAttributes.
20858 * class.cs, rootcontext.cs : Ensure we define and generate
20859 attribute types before anything else.
20861 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20862 and flag the new error -20 for the case when the attribute type
20863 does not have valid targets specified. csc does not catch this.
20865 * ../errors/errors.txt : update for error # -20
20867 2002-04-11 Ravi Pratap <ravi@ximian.com>
20869 * support.cs (InternalParameters.ParameterModifier): Do some null
20870 checking and return sane values.
20872 * class.cs (Method.Define): If we are a PInvoke method, ensure
20873 that we are static and extern. Report error # 601
20875 * ../errors/cs0601.cs : Add test case for the above error.
20877 2002-04-07 Ravi Pratap <ravi@ximian.com>
20879 * rootcontext.cs (attribute_types): We need to keep type of
20880 all attribute types separately and emit code for them first.
20882 (RegisterAttribute) : Implement.
20884 * class.cs (DefineType): Check if the current Type is a custom
20885 attribute type and register it accordingly.
20887 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
20888 adding the first attribute twice and rename to
20890 (SetGlobalAttributes): this.
20892 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
20895 * attribute.cs (ApplyAttributes): Take an additional argument telling us
20896 if we are processing global arguments. Hmm, I am unsure of this.
20898 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20900 * expression.cs: added static array of strings to avoid calling
20901 Enum.ToString () for Operator in Binary. Significant recover of
20904 2002-04-10 Miguel de Icaza <miguel@ximian.com>
20906 * class.cs (FindMembers): Allow the Builders of the various
20907 members to be null. If they are skip them. This only happens
20908 during the PInvoke declaration.
20910 2002-04-09 Miguel de Icaza <miguel@ximian.com>
20912 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
20913 failure, so we do not keep going afterwards.
20915 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
20916 wanted to pass `false' as the `is_delegate' argument. If this is
20917 the case, why not use delegate_type == null to mean `is_delegate =
20918 false' and anything else as is_delegate = true.
20920 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
20922 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
20923 code for the section, not the beginning of the tests.
20925 2002-04-08 Miguel de Icaza <miguel@ximian.com>
20927 * cfold.cs: Handle operator + (Enum x, Underlying x)
20929 * expression.cs (Binary): same. Warn about errors where we have
20930 Enum/Enum in operator + as well.
20932 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
20935 - added support for switch(bool)
20936 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
20937 - add TableSwitchEmit() to handle table-based switch statements
20939 2002-04-05 Ravi Pratap <ravi@ximian.com>
20941 * expression.cs (Invocation.OverloadResolve): Factor out code which
20942 does parameter compatibility checking with arguments so that we can
20943 re-use the code even from Delegate.VerifyApplicability
20945 (VerifyArgumentsCompat): Move above code here.
20947 * delegate.cs (VerifyApplicability): Get rid of duplicate code
20948 and instead make a call to the above method.
20950 2002-03-31 Ravi Pratap <ravi@ximian.com>
20952 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
20953 We use it to keep track of classes which are attribute types.
20955 2002-04-02 Miguel de Icaza <miguel@ximian.com>
20957 * delegate.cs (Delegate.Define): Correctly define the types in the
20958 presence of fixed and array parameters.
20960 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
20963 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
20964 include NonPublic after the first iteration.
20966 * class.cs (Indexer.CheckBase): Only check if both parents are
20969 * cs-parser.jay (accessor_body): If empty, set to null.
20971 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
20972 same code path here to resolve constants names that we did have in
20973 MemberAccess.DoResolve. There is too much code duplicated here.
20975 2002-04-01 Miguel de Icaza <miguel@ximian.com>
20977 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
20979 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
20982 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
20983 tokens, numbers and strings.
20985 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
20988 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
20989 asyncronous parameters and the regular parameters.
20991 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
20992 specify the target directory.
20994 * expression.cs: (This.DoResolve): Simplify
20995 (As.Emit): Optimize, do not generate IsInst if the expression is
20996 always of the given type.
20998 (Is.DoResolve): Bug fix, we were reporting both always/never for
21001 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
21002 creating too many unnecessary arrays.
21004 2002-03-31 Miguel de Icaza <miguel@ximian.com>
21006 * class.cs (EmitFieldInitializer): Use Assign expression to assign
21007 fields instead of rolling our own initializer. Takes care of all
21008 implicit conversions, and drops unnecessary static checks/argument.
21010 2002-03-31 Dick Porter <dick@ximian.com>
21012 * driver.cs: use the GetDirectories() return values properly, and
21013 use "/" as path separator.
21015 2002-03-30 Miguel de Icaza <miguel@ximian.com>
21017 * expression.cs (Unary): Optimize - - expr into expr.
21018 (Binary): Optimize a + (-b) into a -b.
21020 * codegen.cs (CodeGen): Made all methods static.
21022 2002-03-29 Miguel de Icaza <miguel@ximian.com>
21026 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
21027 TypeBuilder property.
21029 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
21032 * tree.cs: Removed the various RecordXXXX, and replaced with a
21033 single RecordDecl. Removed all the accessor methods, and just
21034 left a single access point Type
21036 * enum.cs: Rename DefineEnum to DefineType.
21038 * decl.cs: New abstract method `DefineType' used to unify the
21039 Defines for Enumerations, Interfaces, TypeContainers and
21042 (FindType): Moved LookupInterfaceOrClass here. Moved the
21043 LookupBaseClasses method that used to live in class.cs and
21044 interface.cs here, and renamed to FindType.
21046 * delegate.cs: Implement DefineType. Take advantage of the
21047 refactored pattern for locating the parent builder without taking
21048 the parent_builder argument (which we know does not work if we are
21049 nested, and triggering a toplevel definition).
21051 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21053 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21054 accessibility of a member has changed during override and report
21057 * class.cs (Method.Define, Property.Define): Only complain on
21058 overrides if the method is private, any other accessibility is
21059 fine (and since we just checked the permission is the same, we are
21062 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
21063 and elif are processed always. The other pre-processing
21064 directives are only processed if we are "taking" the path
21066 2002-03-29 Martin Baulig <martin@gnome.org>
21068 * class.cs (Method.Emit): Only emit symbolic debugging info if the
21069 current location is not Null.
21071 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
21072 a separate method so we can profile it.
21074 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
21075 `span.Seconds' are just seconds, but no minutes or hours.
21076 (MainDriver): Profile the CodeGen.SaveSymbols calls.
21078 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21080 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
21081 Remove the gratuitous set of Final:
21083 // If an interface implementation, then we can set Final.
21084 if (((flags & MethodAttributes.Abstract) == 0) &&
21085 implementing.DeclaringType.IsInterface)
21086 flags |= MethodAttributes.Final;
21088 I do not know what I was smoking when I used that.
21091 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
21092 step into fixing the name resolution issues for delegates and
21093 unifying the toplevel name resolution.
21095 2002-03-28 Martin Baulig <martin@gnome.org>
21097 * class.cs (Method.Emit): If we have a symbol writer, call its
21098 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
21099 tell it about the current method.
21101 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
21102 writer that we're going to emit the first byte of IL code for a new
21103 statement (a new source line).
21104 (EmitContext.EmitTopBlock): If we have a symbol writer, call
21105 EmitContext.Mark() before emitting any code.
21107 * location.cs (SymbolDocument): Return null when we're Null.
21109 * statement.cs (Statement): Moved the `Location loc' variable here.
21110 (Statement.EmitBoolExpression): If we have a symbol writer, call
21111 ec.Mark() before emitting any code to tell it that we're at the
21112 beginning of a new statement.
21113 (StatementExpression): Added `Location' argument to the constructor.
21114 (Block): Added public readonly variable `StartLocation' and public
21115 variable `EndLocation'. The latter is to be set using SetEndLocation().
21116 (Block): Added constructor which takes a start and end location.
21117 (Block.SetEndLocation): New method. This sets the end location.
21118 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
21119 local variables we create.
21120 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
21121 each statement and do also mark the begin and end of the block.
21123 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21124 tell it the current lexer.Location, use Location.Null for the end of the
21126 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
21127 current block, set its end location using SetEndLocation().
21128 (statement_expression): StatementExpression constructor now takes the
21129 lexer.Location as additional argument.
21130 (for_statement, declare_local_variables): Likewise.
21131 (declare_local_variables): When creating a new implicit block, use the
21132 new Block constructor and pass it the lexer.Location.
21134 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21136 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
21137 members also on the parent interfaces recursively.
21139 2002-03-27 Miguel de Icaza <miguel@ximian.com>
21141 * report.cs: Use new formats, since Gonzalo finished the missing
21144 * expression.cs (Binary.ResolveOperator): added missing operator|
21145 operator& and operator^ for bool/bool.
21147 * cs-parser.jay: CheckDef now takes a Location argument that is
21148 used to report errors more precisly (instead of reporting the end
21149 of a definition, we try to track something which is a lot closer
21150 to the source of the problem).
21152 * cs-tokenizer.cs: Track global token use, so we can properly flag
21153 the use of #define/#undef after the first token has been seen.
21155 Also, rename the reportXXXX to Error_DescriptiveName
21157 * decl.cs (DeclSpace.IsTopLevel): Move property here from
21158 TypeContainer, so that Enum and Interface can use this too.
21160 * class.cs (TypeContainer.LookupInterfaceOrClass,
21161 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
21162 `builder' argument. Typically this was used to pass the parent
21163 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
21166 The problem is that a nested class could trigger the definition of
21167 a toplevel class, and the builder would be obviously wrong in that
21170 So we drop this argument, and we compute dynamically the
21171 TypeBuilder/ModuleBuilder (the correct information was available
21172 to us anyways from DeclSpace.Parent)
21174 * interface.cs (Interface.DefineInterface): Drop builder
21175 parameter cleanup like class.cs
21177 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
21180 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
21183 (Try.Emit): Propagate the returns value from the statement.
21185 (Return.Emit): Even if we are leavning
21187 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
21189 * modifiers.cs: Fix the computation of MethodAttributes flags.
21191 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
21193 * driver.cs: allow compilation of files that start with '/'.
21194 Add a default case when checking the argument of --target.
21196 2002-03-25 Miguel de Icaza <miguel@ximian.com>
21198 * interface.cs: Implement the same search algorithm for types in
21199 the interface code.
21201 * delegate.cs: Do not allow multiple definition.
21203 * Recovered ChangeLog that got accidentally amputated
21205 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
21207 * rootcontext.cs: Load manually enum to allow core classes to
21208 contain enumerations.
21210 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
21211 Update to new static methods in TypeManager.
21213 * typemanager.cs (GetMethod, GetConstructor): Use our
21214 implementation of FindMembers to find the members, since during
21215 corlib compilation, the types are TypeBuilders and GetMethod and
21216 GetConstructor do not work.
21218 Make all methods in TypeManager static.
21220 (InitCodeHelpers): Split the functionality from
21221 the InitCodeTypes function.
21223 * driver.cs: Call InitCodeHelpers after we have populated the
21226 * cs-parser.jay (delegate_declaration): we did not used to compute
21227 the delegate name correctly for void delegates.
21229 2002-03-24 Miguel de Icaza <miguel@ximian.com>
21231 * rootcontext.cs (RootContext): Init the interface_resolve_order
21232 and type_container_resolve_order always.
21234 (ResolveCore, BootstrapCorlib_ResolveClass,
21235 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
21236 compiler when compiling with --nostdlib
21238 * class.cs (TypeContainer.DefineType): Check that our parent is
21239 not null. This test is most important when we are bootstraping
21242 * codegen.cs: Split out the symbol writing code.
21244 2002-03-25 Martin Baulig <martin@gnome.org>
21246 * driver.cs (-g): Made -g an alias for --debug.
21248 2002-03-24 Martin Baulig <martin@gnome.org>
21250 * codegen.cs (SymbolWriter): New public variable. Returns the
21251 current symbol writer.
21252 (CodeGen): Added `bool want_debugging_support' argument to the
21253 constructor. If true, tell the ModuleBuild that we want debugging
21254 support and ask it for the ISymbolWriter.
21255 (Save): If we have a symbol writer, call it's Close() method after
21256 saving the assembly.
21258 * driver.c (--debug): New command line argument to create a
21259 debugger information file.
21261 * location.cs (SymbolDocument): New public property. Returns an
21262 ISymbolDocumentWriter object for the current source file or null
21263 if we don't have a symbol writer.
21265 2002-03-21 Miguel de Icaza <miguel@ximian.com>
21267 * driver.cs (LoadAssembly): Correctly return when all the paths
21268 have been tried and not before.
21270 * statement.cs (Switch.Emit): return the actual coverage for this
21271 statement (returns/not-returns)
21273 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
21274 switch of the statement if we are the last switch section. That
21275 kills two problems: try/catch problems (we used to emit an empty
21276 nop at the end) and switch statements where all branches would
21279 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21281 * driver.cs: Add default assemblies (the equivalent to the
21282 Microsoft CSC.RSP file)
21284 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21285 also update tokens_seen and set it to false.
21287 * driver.cs: Implement --recurse for Mike.
21289 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21290 correctly splitting out the paths.
21292 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21294 * interface.cs (Interface.PopulateProperty): Instead of using
21295 `parent' as the declaration space for the set parameters, use
21298 * support.cs (InternalParameters): InternalParameters constructor
21299 takes a DeclSpace instead of a TypeContainer.
21301 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21302 types are being initialized, load the address of it before calling
21305 (New): Provide a mechanism to disable the generation of local
21306 value type temporaries when the caller will be providing us with
21307 an address to store it.
21309 (ArrayCreation.EmitDynamicInitializers): Use it.
21311 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21313 * expression.cs (Invocation.EmitArguments): Only probe for array
21314 property if there is more than one argument. Sorry about that.
21316 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21317 empty param arrays.
21319 * class.cs (Method.LabelParameters): Fix incorrect code path that
21320 prevented the `ParamArrayAttribute' from being applied to the
21323 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21325 * support.cs (ReflectionParameters): Correctly compute whether the
21326 last argument is a params array. Fixes the problem with
21329 * typemanager.cs: Make the assemblies array always be non-null
21330 (empty, but non-null)
21332 * tree.cs (RecordDecl): New function that abstracts the recording
21333 of names. This reports error 101, and provides a pointer to the
21334 previous declaration. Fixes a crash in the compiler.
21336 * cs-parser.jay (constructor_declaration): Update to new grammar,
21337 and provide a constructor_body that can be empty.
21339 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21341 * driver.cs: Add support for --resources.
21343 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21344 Make all types for the various array helper methods be integer.
21346 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21347 CheckState to ConvCast.
21349 (ConvCast): Now it takes a `checked' state argument, to avoid
21350 depending on the emit context for the conversion, and just using
21351 the resolve time setting.
21353 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21354 instead of Invocation.EmitArguments. We do not emit the original
21355 arguments, instead we emit those which have been converted to
21356 unsigned int expressions.
21358 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21360 * codegen.cs: ditto.
21362 * expression.cs (LocalVariableReference): Drop the use of the
21363 Store function that depended on the variable index.
21365 * statement.cs (VariableInfo): Drop the `Idx' property from this
21366 class, as this is not taking into account the indexes for
21367 temporaries tat we generate during the execution, getting the
21370 * class.cs: First emit class initializers, then call the parent
21373 * expression.cs (Binary): Fix opcode emision.
21374 (UnaryMutator.EmitCode): Support checked code generation
21376 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21377 matches for events for both the Static and Instance scans,
21378 pointing to the same element. Fix that.
21380 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21382 * rootcontext.cs (ResolveTree): Always set the
21383 interface_resolve_order, because nested interfaces will be calling
21386 * class.cs (GetInterfaceOrClass): Track the same resolution
21387 process used by TypeManager.LookupType. This fixes the nested
21388 type lookups in class declarations (separate path from
21391 (TypeContainer.DefineType): Also define nested interfaces.
21392 (TypeContainer.RegisterOrder): New public function used to
21393 register the order in which child interfaces need to be closed.
21395 Nested interfaces need to be closed after their parents have been
21398 * interface.cs (InterfaceAttr): Put all the logic for computing
21399 the interface attribute here.
21401 (DefineInterface): Register our interface order with the
21402 RootContext or with the TypeContainer depending on the case.
21404 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21406 * cs-parser.jay: rework foreach statement to work with the new
21407 changes to the policy on SimpleNames.
21409 * report.cs: support Stacktrace on warnings as well.
21411 * makefile: drop --unsafe and /unsafe from the compile.
21413 2002-03-13 Ravi Pratap <ravi@ximian.com>
21415 * ecore.cs (StandardConversionExists): Modify to take an Expression
21416 as the first parameter. Ensure we do null -> reference type conversion
21419 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21420 temporary Expression objects.
21422 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21424 * interface.cs: workaround bug in method overloading resolution
21425 (there is already a bugzilla bug for it).
21427 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21429 We could also solve this problem by having a separate path for
21430 performing type lookups, instead of DoResolve, we could have a
21431 ResolveType entry point, and only participating pieces of the
21432 production (simplename, deref, array) would implement this.
21434 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21435 signal SimpleName to only resolve type names and not attempt to
21436 resolve anything else.
21438 * expression.cs (Cast): Set the flag.
21440 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21442 * class.cs: Only report 108 if there is no `new' modifier.
21444 * cs-parser.jay: rework foreach statement to work with the new
21445 changes to the policy on SimpleNames.
21447 * report.cs: support Stacktrace on warnings as well.
21449 * makefile: drop --unsafe and /unsafe from the compile.
21451 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21453 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21454 lookups here, instead of doing that at parse time. This means
21455 that our grammar will not introduce `LocalVariableReferences' as
21456 expressions at this point. That solves the problem of code like
21460 static void Main ()
21464 This is only half the fix. The full fix requires parameters to
21465 also be handled in this way.
21467 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21468 makes the use more obvious of the DeclSpace. The
21469 ec.TypeContainer.TypeBuilder is now only used to pull the
21470 TypeBuilder for it.
21472 My theory is that I can get rid of the TypeBuilder completely from
21473 the EmitContext, and have typecasts where it is used (from
21474 DeclSpace to where it matters).
21476 The only pending problem is that the code that implements Aliases
21477 is on TypeContainer, and probably should go in DeclSpace.
21479 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21480 lookups here, instead of doing that at parse time. This means
21481 that our grammar will not introduce `LocalVariableReferences' as
21482 expressions at this point. That solves the problem of code like
21486 static void Main ()
21490 This is only half the fix. The full fix requires parameters to
21491 also be handled in this way.
21493 * class.cs (Property.DefineMethod): When implementing an interface
21494 method, set newslot, when implementing an abstract method, do not
21495 set the flag (before we tried never setting it, or always setting
21496 it, which is the difference).
21497 (Indexer.DefineMethod): same.
21498 (Method.DefineMethod): same.
21500 * ecore.cs: Only set the status used flag if we get back a Field.
21502 * attribute.cs: Temporary hack, so Paolo can keep working.
21504 2002-03-08 Ravi Pratap <ravi@ximian.com>
21506 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21507 the unmanaged type in the case we have a MarshalAs attribute.
21509 (Resolve): Handle the case when we are parsing the special MarshalAs
21510 attribute [we need to store the unmanaged type to use later]
21512 * typemanager.cs (marshal_as_attr_type): Built in type for the
21513 MarshalAs Attribute.
21515 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21516 on parameters and accordingly set the marshalling info.
21518 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21520 * class.cs: Optimizing slightly by removing redundant code after
21521 we switched to the `NoTypes' return value.
21522 (Property.DefineMethod): use NoTypes here too.
21524 This fixes the bug I introduced in my last batch of changes.
21526 2002-03-05 Ravi Pratap <ravi@ximian.com>
21528 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21530 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21531 Enums since those are types too.
21533 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21535 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21536 thanks to a call during the lookup process.
21538 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21540 * statement.cs (Foreach): Lots of work to accomodate a particular
21541 kind of foreach statement that I had not kept in mind. It is
21542 possible to have foreachs on classes that provide a GetEnumerator
21543 method that return objects that implement the "pattern" for using
21544 a foreach, there is no need to support GetEnumerator
21547 This is needed to compile nant.
21549 * decl.cs: Only report 114 if the member is not `Finalize' and if
21550 the warning level is at least 2.
21552 * class.cs: Moved the compare function from Method to
21555 (MethodSignature.InheritableMemberSignatureCompare): Add new
21556 filter function that is used to extract inheritable methods from a
21559 (Method.Define): Use the new `inheritable_method_signature_filter'
21562 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21565 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21567 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21569 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21571 * expression.cs: Pass location information to
21572 ConvertImplicitStandard.
21574 * class.cs: Added debugging code to track return values from
21577 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21579 * expression.cs (Is.DoResolve): If either side of the `is' is an
21580 interface, do not flag the warning.
21582 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21585 * report.cs: Allow for --fatal to be used with --probe.
21587 * typemanager.cs (NoTypes): Move the definition for the empty Type
21590 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21592 (TypeContainer.DefineProxy): New function used to proxy to parent
21593 implementations when implementing interfaces.
21594 (TypeContainer.ParentImplements): used to lookup if our parent
21595 implements a public function that is required by an interface.
21596 (TypeContainer.VerifyPendingMethods): Hook this up.
21598 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21599 `modules' and `assemblies' arraylists into arrays. We only grow
21600 these are the very early start up of the program, so this improves
21601 the speedof LookupType (nicely measured).
21603 * expression.cs (MakeByteBlob): Replaced unsafe code with
21604 BitConverter, as suggested by Paolo.
21606 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21607 folding of string concatenation, but if either side is a string,
21608 and the other is not, then return null, and let the runtime use
21609 the concatenation on the string plus the object (using
21610 `Object.ToString').
21612 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21614 Constant Folding has been implemented now.
21616 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21617 the error instead on types that are not supported in one's
21620 * constant.cs (Constant and all children): New set of functions to
21621 perform implict and explicit conversions.
21623 * ecore.cs (EnumConstant): Implement the new functions to perform
21624 conversion by proxying to the child expression.
21626 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21627 own separate setting that can not be turned off from the command
21628 line using --unchecked or --checked and is only controlled using
21629 the checked/unchecked statements and expressions. This setting is
21630 used by the constant folder to flag errors.
21632 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21633 ConstantCheckState as well.
21635 During Resolve, they also have to flag the state, because the
21636 constant folder runs completely in the Resolve phase.
21638 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21641 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21643 * cfold.cs: New file, this file contains the constant folder.
21645 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21646 argument to track whether we are using the resulting address to
21647 load or store a value and provide better error messages.
21649 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21650 new AddressOf arguments.
21652 * statement.cs (Foreach.EmitCollectionForeach): Update
21654 * expression.cs (Argument.Emit): Call AddressOf with proper
21655 arguments to track usage.
21657 (New.DoEmit): Call AddressOf with new arguments.
21659 (Unary.Emit): Adjust AddressOf call.
21661 2002-03-01 Ravi Pratap <ravi@ximian.com>
21663 * cs-parser.jay (member_access): Change the case for pre-defined types
21664 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21667 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21670 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21671 essentially like methods and apply attributes like MethodImplOptions to them too.
21673 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21676 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21677 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21680 * Update code everywhere accordingly.
21682 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21684 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21686 2002-02-28 Ravi Pratap <ravi@ximian.com>
21688 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21689 try performing lookups against those instead of jumping straight into using
21690 the 'using' clauses.
21692 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21694 (LookupType): Perform lookups in implicit parents too.
21696 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21697 sequence as RootContext.LookupType.
21699 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21700 the various cases of namespace lookups into this method.
21702 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21704 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21705 in positional arguments)
21707 * class.cs (Operator): Update the AllowedModifiers to contain
21710 * cs-parser.jay: Update operator declaration to allow for the
21711 operator body to be empty.
21713 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21716 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21718 * class.cs (Method.Emit): Label parameters.
21720 * driver.cs: Return 1 or 0 as the program exit code.
21722 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21724 * expression.cs: Special case the `null' object when trying to
21725 auto-compute the type, as anything can be explicitly converted to
21728 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21729 spotting this Paolo.
21731 (Expression.ImplicitNumericConversion): Perform comparissions of
21732 the type using the underlying type in the case of an enumeration
21733 rather than using the enumeration type for the compare.
21735 Cope with the underlying == type case, which is not possible to
21738 (Expression.ConvertNumericExplicit): Perform comparissions of
21739 the type using the underlying type in the case of an enumeration
21740 rather than using the enumeration type for the compare.
21742 * driver.cs: If the user does not supply an extension, assume .exe
21744 * cs-parser.jay (if_statement): Rewrote so that we can track the
21745 location for the if statement.
21747 * expression.cs (Binary.ConstantFold): Only concat strings when
21748 the operation is "+", not everything ;-)
21750 * statement.cs (Statement.EmitBoolExpression): Take a location
21752 (If, While, Do): Track location.
21754 * expression.cs (Binary.ResolveOperator): In the object + string
21755 case, I was missing a call to ConvertImplicit
21757 2002-02-25 Ravi Pratap <ravi@ximian.com>
21759 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21760 Location arguments. Ensure we use RootContext.LookupType to do our work
21761 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21763 * interface.cs (PopulateMethod): Handle the type of the parameter being
21766 * expression.cs (Invocation.BetterFunction): Handle the case when we
21767 have a params method with no fixed arguments and a call is made with no
21770 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21772 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21773 the verbatim-string-literal
21775 * support.cs (InternalParameters.ParameterModifier): handle null
21777 (InternalParameters.ParameterType): ditto.
21779 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21780 duplicating the name of the variable parameter.
21781 (GetParameterByName): Fix bug where we were not looking up array
21782 paramters if they were the only present (thanks Paolo!).
21783 (GetParameterInfo): We only have an empty set of types if both
21784 fixed and array are set to null.
21785 (GetParameterInfo-idx): Handle FixedParameter == null
21787 * cs-parser.jay: Handle the case where there is no catch
21788 statements (missing null test).
21790 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21792 * driver.cs (MainDriver): Be conservative on our command line
21795 Catch DirectoryNotFoundException when calling GetFiles.
21797 (SplitPathAndPattern): Used to split the input specification into
21798 a path and a pattern that we can feed to Directory.GetFiles.
21800 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21802 * statement.cs (Fixed): Implement the last case of the Fixed
21803 statement (string handling).
21805 * expression.cs (StringPtr): New class used to return a char * to
21806 a string; Used by the Fixed statement.
21808 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21810 * expression.cs (Binary.ResolveOperator): Remove redundant
21811 MemberLookup pn parent type.
21812 Optimize union call, we do not need a union if the types are the same.
21813 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21816 Specialize the use of MemberLookup everywhere, instead of using
21817 the default settings.
21819 (StackAlloc): Implement stackalloc keyword.
21821 * cs-parser.jay: Add rule to parse stackalloc.
21823 * driver.cs: Handle /h, /help, /?
21825 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21826 before we supported unsafe code.
21828 * makefile: add --unsafe to the self compilation of mcs.
21830 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21832 * expression.cs (PointerArithmetic): New class that is used to
21833 perform pointer arithmetic.
21834 (Binary.Resolve): Handle pointer arithmetic
21835 Handle pointer comparission.
21836 (ArrayPtr): Utility expression class that is used to take the
21837 address of an array.
21839 (ElementAccess): Implement array access for pointers
21841 * statement.cs (Fixed): Implement fixed statement for arrays, we
21842 are missing one more case before we are done.
21844 * expression.cs (Indirection): Implement EmitAssign and set the
21845 ExprClass to Variable. This allows pointer dereferences to be
21846 treated as variables, and to have values assigned to them.
21848 * ecore.cs (Expression.StoreFromPtr): New utility function to
21849 store values dereferencing.
21851 2002-02-20 Ravi Pratap <ravi@ximian.com>
21853 * expression.cs (Binary.ResolveOperator): Ensure that we are
21854 not trying to operate on a void type - this fixes the reported
21857 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21858 the parent implementation is sealed.
21860 * ../errors/cs0239.cs : Add.
21862 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21864 * typemanager.cs (unverifiable_code_type): Corresponds to
21865 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21866 which have unsafe code in them.
21868 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21871 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21873 * cs-tokenizer.cs: Add support for @"litreal strings"
21875 Make tokenizer accept pre-processor directives
21876 on any column (remove the old C-like limitation).
21878 * rootcontext.cs (EmitCode): Emit any global attributes.
21879 (AddGlobalAttributes): Used to keep track of assembly attributes.
21881 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21883 * cs-parser.jay: Add support for global attributes.
21885 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21887 * expression.cs (Indirection): New helper class. Unary will
21888 create Indirection classes to be able to implement the
21889 IMemoryLocation interface on it.
21891 2002-02-16 Miguel de Icaza <miguel@ximian.com>
21893 * cs-parser.jay (fixed_statement): reference the right statement.
21895 * statement.cs (Fixed.Emit): Finish implementing the fixed
21896 statement for the &x case.
21898 2002-02-14 Miguel de Icaza <miguel@ximian.com>
21900 * class.cs (Property.Define, Method.Define): Remove newslot when
21903 * modifiers.cs: My use of NewSlot when `Abstract' was set was
21904 wrong. NewSlot should only be used if the `new' keyword is present.
21906 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
21907 locating our system dir. Sorry about this.
21909 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21911 * driver.cs (GetSystemDir): Compute correctly the location of our
21912 system assemblies. I was using the compiler directory instead of
21913 the library directory.
21915 2002-02-13 Ravi Pratap <ravi@ximian.com>
21917 * expression.cs (BetterFunction): Put back in what Miguel commented out
21918 since it is the correct fix. The problem is elsewhere ;-)
21920 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
21921 parameters of the parms method are themselves compatible or not !
21923 (StandardConversionExists): Fix very dangerous bug where we were forgetting
21924 to check that a class implements an interface before saying that an implicit
21925 conversion was allowed. Use ImplementsInterface to do the checking.
21927 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21929 * class.cs (Method.Define): Track whether we are an explicit
21930 implementation or not. And only call DefineMethodOverride if we
21931 are an explicit implementation.
21933 (Property.DefineMethod): Ditto.
21935 2002-02-11 Ravi Pratap <ravi@ximian.com>
21937 * expression.cs (BetterFunction): Catch hideous bug which was
21938 preventing us from detecting ambiguous calls due to implicit casts i.e
21941 2002-01-29 Miguel de Icaza <miguel@ximian.com>
21943 * support.cs (Pair): Remove un-needed method. I figured why I was
21944 getting the error in cs-parser.jay, the variable in a foreach loop
21945 is readonly, and the compiler does not really treat this as a variable.
21947 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
21948 instead of EQUALS in grammar.
21950 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
21952 * expression.cs (Unary.DoResolve): Check whether the argument is
21955 2002-01-28 Miguel de Icaza <miguel@ximian.com>
21957 * support.cs: Api for Pair to set a value. Despite the fact that
21958 the variables are public the MS C# compiler refuses to compile
21959 code that accesses the field if the variable is part of a foreach
21962 * statement.cs (Fixed): Begin implementation of the fixed
21965 (Block.AddVariable): Return the VariableInfo on success and null
21966 on failure instead of true/false.
21968 * cs-parser.jay (foreach): Catch errors on variables already
21969 defined (we were ignoring this value before) and properly unwind
21970 the block hierarchy
21972 (fixed_statement): grammar for the fixed statement.
21974 2002-01-25 Miguel de Icaza <miguel@ximian.com>
21976 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
21977 pointer types to be incretemented.
21979 (SizeOf): Implement.
21981 * cs-parser.jay (pointer_member_access): Implement
21982 expr->IDENTIFIER production.
21984 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
21985 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
21988 (Unary): Implement indirection.
21990 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
21991 use in non-unsafe context).
21993 (SimpleName.DoResolve): Check for pointers in field access on safe
21996 (Expression.LoadFromPtr): Factor the load-indirect code in this
21997 function. This was duplicated in UnboxCast and ParameterReference
21999 2002-01-24 Miguel de Icaza <miguel@ximian.com>
22001 * expression.cs (ComposedCast): report an error if a pointer cast
22002 is used in a safe region.
22004 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
22005 pointer type casts in unsafe context.
22007 * codegen.cs (EmitContext): Set up IsUnsafe.
22009 * cs-parser.jay (non_expression_type): Add productions for pointer
22012 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
22013 code. We should not use force into static mode if the method is
22014 not virtual. Fixes bug in MIS
22016 * statement.cs (Do.Emit, While.Emit, For.Emit,
22017 Statement.EmitBoolExpression): Add support to Do and While to
22018 propagate infinite loop as `I do return' semantics.
22020 Improve the For case to also test for boolean constants.
22022 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
22023 to the list of attributes we can add.
22025 Remove `EmitContext' argument.
22027 * class.cs (Method.Define): Apply parameter attributes.
22028 (Constructor.Define): Apply parameter attributes.
22029 (MethodCore.LabelParameters): Move here the core of labeling
22032 * support.cs (ReflectionParameters.ParameterModifier,
22033 InternalParameters.ParameterModifier): Use IsByRef on the type and
22034 only return the OUT bit for these parameters instead of in/out/ref
22037 This is because I miss-understood things. The ParameterInfo.IsIn
22038 and IsOut represent whether the parameter has the [In] and [Out]
22041 2002-01-22 Miguel de Icaza <miguel@ximian.com>
22043 * ecore.cs (FieldExpr.Emit): Release temporaries.
22045 * assign.cs (LocalTemporary.Release): new function.
22047 * codegen.cs (EmitContext.GetTemporaryStorage,
22048 EmitContext.FreeTemporaryStorage): Rework the way we deal with
22049 temporary storage. Now we can "put back" localbuilders when we
22052 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22054 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22055 need to make a copy of the variable to generate verifiable code.
22057 2002-01-19 Miguel de Icaza <miguel@ximian.com>
22059 * driver.cs: Compute dynamically the system directory.
22061 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
22062 Slower, but more generally useful. Used by the abstract
22063 registering implementation.
22065 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
22066 the rules for the special rule on Type/instances. First check if
22067 we have the same name, and if so, try that special static path
22068 rather than the instance path.
22070 2002-01-18 Miguel de Icaza <miguel@ximian.com>
22072 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
22075 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
22076 Enum, ValueType, Delegate or Array for non-corlib compiles.
22078 * cs-tokenizer.cs: Catch long identifiers (645)
22080 * typemanager.cs (IndexerPropetyName): Ravi never tested this
22083 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
22084 fix, we were returning too early, so we were not registering
22085 pending methods from abstract classes.
22087 Do not register pending methods if the class is abstract.
22089 * expression.cs (Conditional.DoResolve): Report circular implicit
22090 conversions when we neecd to compute it for conditional
22093 (Is.DoResolve): If the expression is always of the provided type,
22094 flag warning 183. If the expression can not ever be of the
22095 provided type flag warning 184.
22097 * class.cs: Catch 169 as well.
22099 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
22102 2002-01-18 Nick Drochak <ndrochak@gol.com>
22104 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
22106 2002-01-17 Miguel de Icaza <miguel@ximian.com>
22108 * interface.cs: (PopulateMethod): Check for pointers being defined
22109 only if the unsafe context is active.
22110 (PopulateProperty): ditto.
22111 (PopulateIndexer): ditto.
22113 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
22114 specified. If pointers are present, make sure that they are
22115 present in an unsafe context.
22116 (Constructor, Constructor.Define): ditto.
22117 (Field, Field.Define): ditto.
22118 (Property, Property.Define): ditto.
22119 (Event, Event.Define): ditto.
22121 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
22122 hashtable if there are classes or structs defined.
22124 * expression.cs (LocalVariableReference.DoResolve): Simplify this
22125 code, as the constant resolution moved.
22127 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
22128 the metadata, so we can flag error 133.
22130 * decl.cs (MemberCore.UnsafeOK): New function to test that a
22131 pointer is being declared in an unsafe context.
22133 2002-01-16 Miguel de Icaza <miguel@ximian.com>
22135 * modifiers.cs (Modifiers.Check): Require a Location argument.
22136 Report error 227 for Unsafe use.
22138 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
22140 * statement.cs (For.Emit): If the test is null, then report that
22141 we do `return', as we wont reach anything afterwards.
22143 (Switch.SwitchGoverningType): Track the expression that matched
22146 * driver.cs: Allow negative numbers as an error code to flag.
22148 * cs-parser.jay: Handle 1551.
22150 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
22152 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22154 * cs-parser.jay: Report 1518 (type declaration can only contain
22155 class, struct, interface, enum or delegate)
22157 (switch_label): Report 1523 (keywords `case' or `default' must
22160 (opt_switch_sections): Report 1522 (empty switch)
22162 * driver.cs: Report 1515 (response file specified multiple times)
22163 Report 1516 (Source file specified multiple times).
22165 * expression.cs (Argument.Resolve): Signal 1510
22167 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
22168 access not allowed in static code)
22170 2002-01-11 Ravi Pratap <ravi@ximian.com>
22172 * typemanager.cs (IsPointerType): Utility method which we are going
22175 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
22176 the object type, so we take care of that.
22178 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
22180 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
22181 added to non-params parameters :-)
22183 * typemanager.cs (CSharpName): Include 'void' type too.
22185 (void_ptr_type): Include in the set of core types.
22187 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
22190 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
22193 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
22194 completely forgotten about it.
22196 2002-01-10 Ravi Pratap <ravi@ximian.com>
22198 * cs-parser.jay (pointer_type): Add. This begins our implementation
22199 of parsing rules for unsafe code.
22201 (unsafe_statement): Implement.
22203 (embedded_statement): Modify to include the above.
22205 * statement.cs (Unsafe): Implement new class for unsafe blocks.
22207 * codegen.cs (EmitContext.InUnsafe): Add. This determines
22208 if the current context is an unsafe one.
22210 * cs-parser.jay (local_variable_pointer_type): Since local variable types
22211 are handled differently, we need separate rules for them.
22213 (local_variable_declaration): Update to use local_variable_pointer_type
22214 to allow variable declarations of unmanaged pointer types.
22216 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
22217 in unsafe contexts.
22219 * ../errors/cs0214.cs : Add.
22221 2002-01-16 Nick Drochak <ndrochak@gol.com>
22223 * makefile: remove 'response' file when cleaning.
22225 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22227 * cs-parser.jay: Report 1524.
22229 2002-01-14 Miguel de Icaza <miguel@ximian.com>
22231 * typemanager.cs (RegisterMethod): drop checking if we have
22232 registered this from here
22234 2002-01-12 Miguel de Icaza <miguel@ximian.com>
22236 * class.cs (Method.EmitDestructor): Implement calling our base
22239 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
22240 value of InFinally.
22242 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
22243 this routine and will wrap the call in a try/catch block. Deal
22246 2002-01-11 Miguel de Icaza <miguel@ximian.com>
22248 * ecore.cs (Expression.MemberLookup): instead of taking a
22249 parameter `same_type' that was used to tell whether we could
22250 access private members we compute our containing type from the
22253 (FieldExpr): Added partial support for volatile fields. This does
22254 not work for volatile fields exposed from assemblies, as I can not
22255 figure out how to extract the modreq from it.
22257 Updated all the source files to use this.
22259 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
22260 because it is referenced by MemberLookup very often.
22262 2002-01-09 Ravi Pratap <ravi@ximian.com>
22264 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
22265 TypeBuilder.GetCustomAttributes to retrieve what we need.
22267 Get rid of redundant default_member_attr_type as this is the same as
22268 default_member_type which already exists.
22270 * interface.cs, attribute.cs : Update accordingly.
22272 2002-01-08 Miguel de Icaza <miguel@ximian.com>
22274 * typemanager.cs: Enable IndexerPropertyName again. It does not
22275 work for TYpeBuilders though. Ravi, can you please fix this?
22277 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22279 * expression.cs (Argument.Emit): Handle the case of ref objects
22280 being passed to ref functions;
22282 (ParameterReference.EmitLoad): Loads the content of the pointer
22283 without dereferencing.
22285 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22287 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22289 2002-01-08 Ravi Pratap <ravi@ximian.com>
22291 * class.cs (Indexer.DefineMethod): Incorporate the interface
22292 type in the name of the method if we are doing explicit interface
22295 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22297 (BetterConversion): Fix extremely trivial bug where we were referring to
22298 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22301 * ../errors/bug16.cs : Add although we have fixed it.
22303 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22305 * expression.cs (BaseIndexer): Begin implementation.
22307 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22309 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22310 production directly to remove a shift/reduce, and implement
22311 explicit interface implementation.
22313 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22314 after a floating point suffix.
22316 * expression.cs (DoNumericPromotions): Improved the conversion for
22317 uint/uint. If we have a constant, we avoid doing a typecast to a
22320 * class.cs (Indexer): Implement explicit interface implementation
22323 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22325 * class.cs: make the default instance constructor public and hidebysig.
22327 2001-01-03 Ravi Pratap <ravi@ximian.com>
22329 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22330 so we can call it from elsewhere.
22332 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22333 we emit it internally if the class has a defined indexer; otherwise the user
22334 emits it by decorating the class definition with the DefaultMemberAttribute.
22336 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22337 attribute is not used on a type which defines an indexer.
22339 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22340 character when we skip whitespace.
22342 * ../errors/cs0646.cs : Add.
22344 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22346 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22349 * makefile: Add practical target `mcs3.exe' which builds the third
22350 generation compiler.
22352 * expression.cs (New): Fix structures constructor calling.
22354 * class.cs (Property, Method, Indexer): Emit Final flag on the
22355 method if we are an interface implementation and we are not
22358 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22359 whether this property is referencing a `base' method.
22361 * expression.cs (Invocation.EmitCall): take an extra argument:
22362 is_base, this is used to determine whether the `call' or
22363 `callvirt' opcode should be used.
22366 * delegate.cs: update EmitCall.
22368 * class.cs (Method.Define): Set NewSlot for the cases where we are
22369 not implementing an interface method.
22371 (Property.Define): ditto.
22373 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22375 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22376 'r'. Allows mcs to parse itself fully.
22378 2002-01-02 Ravi Pratap <ravi@ximian.com>
22380 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22381 of the number of initializers that require the InitializeArray method.
22383 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22384 update the above field where necessary.
22386 (MakeByteBlob): Update accordingly.
22388 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22391 (EmitDynamicInitializers): Update in accordance with the new optimization.
22393 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22394 same OpCode applies.
22396 * cs-parser.jay : Fix some glaring errors I introduced.
22398 2002-01-01 Ravi Pratap <ravi@ximian.com>
22400 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22401 so that we can check for name clashes there too.
22403 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22404 for interface indexers.
22406 * interfaces.cs (Define): Emit the default member attribute.
22408 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22409 variable was being referred to while setting the value ;-)
22411 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22413 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22414 byte-by-byte information when we know the data is zero.
22416 Make the block always a multiple of 4, because
22417 DefineInitializedData has a bug.
22419 * assign.cs: Fix, we should assign from the temporary, not from
22422 * expression.cs (MakeByteBlob): Fix my incorrect code.
22424 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22426 * typemanager.cs (EnumToUnderlying): This function is used to get
22427 the underlying type from an enumeration, because it does not
22430 * constant.cs: Use the I4_S form for values between -128 and 127.
22432 * statement.cs (Block.LookupLabel): Looks up a label.
22433 (Block): Drop support for labeled blocks.
22435 (LabeledStatement): New kind of statement that represents a label
22438 (Goto): Finally implement this bad boy.
22440 * cs-parser.jay: Update to reflect new mechanism to implement
22443 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22445 * codegen.cs (EmitContext.This): a codegen property that keeps the
22446 a single instance of this instead of creating many different this
22449 * delegate.cs (Delegate.DoResolve): Update to use the property;
22451 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22453 * expression.cs (BaseAccess.DoResolve): Ditto.
22455 2001-12-29 Ravi Pratap <ravi@ximian.com>
22457 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22458 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22460 (InitCoreTypes): Update accordingly.
22462 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22463 so we can quickly store the state.
22465 (ApplyAttributes): Set the correct implementation flags
22466 for InternalCall methods.
22468 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22470 * expression.cs (EmitCall): if a method is not virtual, then do
22471 not use callvirt on it.
22473 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22474 user defined stuff) requires the use of stobj, which takes an
22475 address on the stack instead of an array and an index. So emit
22476 the Ldelema operation for it.
22478 (EmitStoreOpcode): Use stobj for valuetypes.
22480 (UnaryMutator.EmitCode): Use the right 1 value depending on
22481 whether we are dealing with int64/uint64, float or doubles.
22483 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22484 constructors that I implemented last night.
22486 (Constructor.IsDefault): Fix to work properly for static
22489 * cs-parser.jay (CheckDef): report method signature errors.
22490 Update error number 103 to be 132.
22492 * decl.cs: New AdditionResult enumeration value: MethodExists.
22493 Although we do this check for methods later on in the semantic
22494 analysis, catching repeated default constructors is so easy that
22495 we catch these here.
22497 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22500 (ParameterReference.EmitAssign, Emit): handle
22503 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22504 (ArrayAccess.EmitStoreOpcode): ditto.
22506 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22508 * expression.cs (MakeByteBlob): Complete all the missing types
22509 (uint, short, ushort, byte, sbyte)
22511 * class.cs: Only init instance field initializers on instance
22514 Rename `constructors' to instance_constructors.
22516 (TypeContainer.AddConstructor): Only add constructors to the list
22517 if it is not static.
22519 Make sure that we handle default_static_constructor independently
22520 everywhere where we handle instance_constructors
22522 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22524 * class.cs: Do not lookup or create a base initializer for a
22525 static constructor.
22527 (ConstructorInitializer.Resolve): use the proper type to lookup
22530 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22532 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22535 * decl.cs: CloseType is now an virtual method, the default
22536 implementation just closes this type.
22538 2001-12-28 Ravi Pratap <ravi@ximian.com>
22540 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22541 to PreserveSig by default. Also emit HideBySig on such methods.
22543 Basically, set the defaults to standard values.
22545 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22546 argument, if candidate is better, it can't be worse than the best !
22548 (Invocation): Re-write bits to differentiate between methods being
22549 applicable in their expanded form and their normal form - for params
22552 Get rid of use_standard everywhere as only standard conversions are allowed
22553 in overload resolution.
22555 More spec conformance.
22557 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22559 * driver.cs: Add --timestamp, to see where the compiler spends
22562 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22563 `this' in static code.
22565 (SimpleName.DoResolve): Implement in terms of a helper function
22566 that allows static-references to be passed upstream to
22569 (Expression.ResolveWithSimpleName): Resolve specially simple
22570 names when called by MemberAccess to implement the special
22573 (Expression.ImplicitReferenceConversion): Handle conversions from
22574 Null to reference types before others, as Null's type is
22577 * expression.cs (Invocation.EmitCall): Handle the special case of
22578 calling methods declared on a reference type from a ValueType
22579 (Base classes System.Object and System.Enum)
22581 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22582 the left hand side is a TypeExpr, not on every enumeration.
22584 (Binary.Resolve): If types are reference types, then do a cast to
22585 object on operators != and == of both arguments.
22587 * typemanager.cs (FindMembers): Extract instance and static
22588 members if requested.
22590 * interface.cs (PopulateProperty): Use void_type instead of null
22591 as the return type for the setter method.
22593 (PopulateIndexer): ditto.
22595 2001-12-27 Ravi Pratap <ravi@ximian.com>
22597 * support.cs (ReflectionParameters): Fix minor bug where we
22598 were examining the wrong parameter for the ParamArray attribute.
22600 Cope with requests for the type of the parameter at position
22601 greater than the params parameter's. We now return the element
22602 type of the params array as that makes more sense.
22604 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22605 accordingly as we no longer have to extract the element type
22608 (Invocation.OverloadResolve): Update.
22610 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22612 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22613 against IEnumerator, test whether the return value is a descendant
22614 of the IEnumerator interface.
22616 * class.cs (Indexer.Define): Use an auxiliary method to implement
22617 the other bits of the method definition. Begin support for
22618 explicit interface implementation.
22620 (Property.DefineMethod): Use TypeManager.void_type instead of null
22621 for an empty return value.
22623 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22625 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22626 dealing with a FieldExpr which is composed of a FieldBuilder, in
22627 the code path we did extract the constant, but we should have
22628 obtained the underlying value to be able to cast it (otherwise we
22629 end up in an infinite loop, this is what Ravi was running into).
22631 (ArrayCreation.UpdateIndices): Arrays might be empty.
22633 (MemberAccess.ResolveMemberAccess): Add support for section
22634 14.5.4.1 that deals with the special case of E.I when E is a type
22635 and something else, that I can be a reference to a static member.
22637 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22638 handle a particular array type to create byte blobs, it is just
22639 something we dont generate byteblobs for.
22641 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22644 * location.cs (Push): remove the key from the hashtable that we
22645 are about to add. This happens for empty files.
22647 * driver.cs: Dispose files after we have parsed them.
22649 (tokenize): new function that only runs the tokenizer on its
22650 input, for speed testing.
22652 2001-12-26 Ravi Pratap <ravi@ximian.com>
22654 * class.cs (Event.Define): Define the private field only if there
22655 are no accessors defined.
22657 * expression.cs (ResolveMemberAccess): If there is no associated
22658 field with the event, that means we have an event defined with its
22659 own accessors and we should flag error cs0070 since transforming
22660 ourselves into a field is not valid in that case.
22662 * ecore.cs (SimpleName.DoResolve): Same as above.
22664 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22665 and charset to sane values.
22667 2001-12-25 Ravi Pratap <ravi@ximian.com>
22669 * assign.cs (DoResolve): Perform check on events only if they
22670 are being accessed outside the declaring type.
22672 * cs-parser.jay (event_declarations): Update rules to correctly
22673 set the type of the implicit parameter etc.
22675 (add_accessor, remove_accessor): Set current local parameters.
22677 * expression.cs (Binary): For delegate addition and subtraction,
22678 cast the return value from the method into the appropriate delegate
22681 2001-12-24 Ravi Pratap <ravi@ximian.com>
22683 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22684 of these as the workaround is unnecessary.
22686 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22687 delegate data - none of that is needed at all.
22689 Re-write bits to extract the instance expression and the delegate method
22692 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22695 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22696 of attaching attributes instead of duplicating code everywhere.
22698 * everywhere : Update code to do attribute emission using the above method.
22700 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22702 * expression.cs (IsParamsMethodApplicable): if there are not
22703 parameters, return immediately.
22705 * ecore.cs: The 0 literal can be implicity converted to an enum
22708 (SimpleName.DoResolve): First lookup the type, then lookup the
22711 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22712 want to get its address. If the InstanceExpression is not
22713 addressable, store the result in a temporary variable, then get
22716 * codegen.cs: Only display 219 errors on warning level or above.
22718 * expression.cs (ArrayAccess): Make it implement the
22719 IMemoryLocation interface.
22721 (Binary.DoResolve): handle the operator == (object a, object b)
22722 and operator != (object a, object b) without incurring into a
22723 BoxedCast (because 5 != o should never be performed).
22725 Handle binary enumerator operators.
22727 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22728 value type, otherwise use Ldelem_ref.
22730 Use precomputed names;
22732 (AddressOf): Implement address of
22734 * cs-parser.jay (labeled_statement): Fix recursive block
22735 addition by reworking the production.
22737 * expression.cs (New.DoEmit): New has a special case:
22739 If we are dealing with a ValueType, we have a few
22740 situations to deal with:
22742 * The target of New is a ValueType variable, that is
22743 easy, we just pass this as the variable reference
22745 * The target of New is being passed as an argument,
22746 to a boxing operation or a function that takes a
22749 In this case, we need to create a temporary variable
22750 that is the argument of New.
22753 2001-12-23 Ravi Pratap <ravi@ximian.com>
22755 * rootcontext.cs (LookupType): Check that current_type is not null before
22756 going about looking at nested types.
22758 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22759 not implement the IAssignMethod interface any more.
22761 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22762 where we tranform them into FieldExprs if they are being resolved from within
22763 the declaring type.
22765 * ecore.cs (SimpleName.DoResolve): Do the same here.
22767 * assign.cs (DoResolve, Emit): Clean up code considerably.
22769 * ../errors/bug10.cs : Add.
22771 * ../errors/cs0070.cs : Add.
22773 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22775 * assign.cs : Get rid of EventIsLocal everywhere.
22777 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22779 * ecore.cs (ConvertIntLiteral): finished the implementation.
22781 * statement.cs (SwitchLabel): Convert the value we are using as a
22782 key before looking up the table.
22784 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22786 * codegen.cs (EmitTopBlock): Require a Location argument now.
22788 * cs-parser.jay (constructor_declarator): We need to setup
22789 current_local_parameters before we parse the
22790 opt_constructor_initializer, to allow the variables to be bound
22791 to the constructor arguments.
22793 * rootcontext.cs (LookupType): First lookup nested classes in our
22794 class and our parents before we go looking outside our class.
22796 * expression.cs (ConstantFold): Extract/debox the values at the
22799 * rootcontext.cs (EmitCode): Resolve the constants first before we
22800 resolve the types. This is not really needed, but it helps debugging.
22802 * statement.cs: report location.
22804 * cs-parser.jay: pass location to throw statement.
22806 * driver.cs: Small bug fix.
22808 * report.cs: Updated format to be 4-zero filled digits.
22810 2001-12-22 Ravi Pratap <ravi@ximian.com>
22812 * expression.cs (CheckIndices): Fix minor bug where the wrong
22813 variable was being referred to ;-)
22815 (DoEmit): Do not call EmitStaticInitializers when the
22816 underlying type is System.Object.
22818 2001-12-21 Ravi Pratap <ravi@ximian.com>
22820 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22821 and do the usual workaround for SRE.
22823 * class.cs (MyEventBuilder.EventType): New member to get at the type
22824 of the event, quickly.
22826 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22828 * assign.cs (Assign.DoResolve): Handle the case when the target
22829 is an EventExpr and perform the necessary checks.
22831 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22834 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22836 (EventExpr): Set the type in the constructor itself since we
22837 are meant to be born fully resolved.
22839 (EventExpr.Define): Revert code I wrote earlier.
22841 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22842 instance expression is null. The instance expression is a This in that case
22843 or a null, depending on whether it is a static method or not.
22845 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22846 refers to more than one method.
22848 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22849 and accordingly flag errors.
22851 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22853 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22855 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22857 * location.cs (ToString): Provide useful rutine.
22859 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22861 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22862 objects, return the actual integral boxed.
22864 * statement.cs (SwitchLabel): define an ILLabel for each
22867 (Switch.CheckSwitch): If the value is a Literal, extract
22868 the underlying literal.
22870 Also in the unused hashtable we had, add the SwitchLabel so we can
22871 quickly look this value up.
22873 * constant.cs: Implement a bunch of new constants. Rewrite
22874 Literal based on this. Made changes everywhere to adapt to this.
22876 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22877 dereferencing array only once, and also copes with enumrations.
22879 bytes are two bytes wide, not one.
22881 (Cast): Perform constant conversions.
22883 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22884 wrappers to the literals here.
22886 * expression.cs (DoNumericPromotions): long literals can converted
22887 to ulong implicity (this is taken care of elsewhere, but I was
22888 missing this spot).
22890 * ecore.cs (Expression.Literalize): Make the return type Literal,
22891 to improve type checking.
22893 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
22895 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22897 * literal.cs: Revert code from ravi that checked the bounds. The
22898 bounds are sane by the definition of the type itself.
22900 * typemanager.cs: Fix implementation of ImplementsInterface. We
22901 need to actually look up in our parent hierarchy for interfaces
22904 * const.cs: Use the underlying type for enumerations
22906 * delegate.cs: Compute the basename for the delegate creation,
22907 that should fix the delegate test case, and restore the correct
22908 Type Lookup semantics in rootcontext
22910 * rootcontext.cs: Revert Ravi's last patch. The correct way of
22911 referencing a nested type with the Reflection API is using the "+"
22914 * cs-parser.jay: Do not require EOF token at the end.
22916 2001-12-20 Ravi Pratap <ravi@ximian.com>
22918 * rootcontext.cs (LookupType): Concatenate type names with
22919 a '.' instead of a '+' The test suite passes again.
22921 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
22922 field of the enumeration.
22924 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
22925 the case when the member is an EventExpr.
22927 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
22928 static has an associated instance expression.
22930 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
22932 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
22934 * class.cs (Event.Define): Register event and perform appropriate checks
22937 We define the Add and Remove methods even if the use provides none because
22938 in that case, we provide default implementations ourselves.
22940 Define a private field of the type of the event. This is done by the CSC compiler
22941 and we should be doing it too ;-)
22943 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
22944 More methods we use in code we generate.
22946 (multicast_delegate_type, delegate_type): Two separate types since the distinction
22949 (InitCoreTypes): Update accordingly for the above.
22951 * class.cs (Event.Emit): Generate code for default accessors that we provide
22953 (EmitDefaultMethod): Do the job in the above.
22955 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
22958 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22960 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
22961 builders even if we were missing one.
22963 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
22964 pass the Basename as our class name instead of the Name. The
22965 basename will be correctly composed for us.
22967 * parameter.cs (Paramters): Now takes a Location argument.
22969 * decl.cs (DeclSpace.LookupType): Removed convenience function and
22970 make all the code call directly LookupType in RootContext and take
22971 this chance to pass the Location information everywhere.
22973 * Everywhere: pass Location information.
22975 2001-12-19 Miguel de Icaza <miguel@ximian.com>
22977 * class.cs (Constructor.Define): Updated way of detecting the
22978 length of the parameters.
22980 (TypeContainer.DefineType): Use basename as the type name for
22983 (TypeContainer.Define): Do not recursively define types here, as
22984 definition is taken care in order by the RootContext.
22986 * tree.cs: Keep track of namespaces in a per-file basis.
22988 * parameter.cs (Parameter.ComputeSignature): Update to use
22991 (Parameters.GetSignature): ditto.
22993 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
22994 instead of a TypeContainer.
22996 (Interface.SemanticAnalysis): Use `this' instead of our parent to
22997 resolve names. Because we need to be resolve in our context, not
23000 * driver.cs: Implement response files.
23002 * class.cs (TypeContainer.DefineType): If we are defined, do not
23003 redefine ourselves.
23005 (Event.Emit): Emit the code for add/remove handlers.
23006 (Event.Define): Save the MethodBuilders for add/remove.
23008 * typemanager.cs: Use pair here too.
23010 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
23011 DictionaryEntry requires the first argument to be non-null.
23013 (enum_declaration): Compute full name for registering the
23016 (delegate_declaration): Instead of using
23017 formal_parameter_list, use opt_formal_parameter_list as the list
23020 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
23021 (EventParsing): New property that controls whether `add' and
23022 `remove' are returned as tokens or identifiers (for events);
23024 2001-12-19 Ravi Pratap <ravi@ximian.com>
23026 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
23027 use MyEventBuilder only and let it wrap the real builder for us.
23029 (MyEventBuilder): Revamp constructor etc.
23031 Implement all operations that we perform on EventBuilder in precisely the same
23034 (FindMembers): Update to use the EventBuilder member.
23036 (Event.Emit): Update accordingly.
23038 2001-12-18 Ravi Pratap <ravi@ximian.com>
23040 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
23041 by calling the appropriate methods.
23043 (GetCustomAttributes): Make stubs as they cannot possibly do anything
23046 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
23048 2001-12-17 Ravi Pratap <ravi@ximian.com>
23050 * delegate.cs (Delegate.Populate): Check that the return type
23051 and various parameters types are indeed accessible.
23053 * class.cs (Constructor.Define): Same here.
23055 (Field.Define): Ditto.
23057 (Event.Define): Ditto.
23059 (Operator.Define): Check that the underlying Method defined itself
23060 correctly - so it's MethodBuilder should not be null.
23062 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
23063 expression happens to be null.
23065 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
23066 members but as of now we don't seem to be able to do anything really useful with it.
23068 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
23069 not the EventBuilder.
23071 2001-12-18 Miguel de Icaza <miguel@ximian.com>
23073 * cs-tokenizer.cs: Add support for defines.
23074 Add support for #if, #elif, #else, #endif
23076 (eval_var): evaluates a variable.
23077 (eval): stubbed for evaluating functions.
23079 * cs-parser.jay: Pass the defines information
23081 * driver.cs: Add --define command line option.
23083 * decl.cs: Move MemberCore here.
23085 Make it the base class for DeclSpace. This allows us to catch and
23086 report 108 and 109 for everything now.
23088 * class.cs (TypeContainer.Define): Extract all the members
23089 before populating and emit the warning 108 (new keyword required
23090 to override) instead of having each member implement this.
23092 (MemberCore.Define): New abstract method, we will be using this in
23093 the warning reporting engine in Populate.
23095 (Operator.Define): Adjust to new MemberCore protocol.
23097 * const.cs (Const): This does not derive from Expression, it is a
23098 temporary object we use to create fields, it is a MemberCore.
23100 * class.cs (Method.Define): Allow the entry point to be in a
23103 * driver.cs: Rewrite the argument handler to clean it up a bit.
23105 * rootcontext.cs: Made it just an auxiliary namespace feature by
23106 making everything static.
23108 * driver.cs: Adapt code to use RootContext type name instead of
23111 * delegate.cs: Remove RootContext argument.
23113 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
23116 * class.cs (Event.Define): The lookup can fail.
23118 * cs-tokenizer.cs: Begin implementation of pre-procesor.
23120 * expression.cs: Resolve the this instance before invoking the code.
23122 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23124 * cs-parser.jay: Add a production in element_access that allows
23125 the thing to become a "type" reference. This way we can parse
23126 things like "(string [])" as a type.
23128 Note that this still does not handle the more complex rules of
23132 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
23134 * ecore.cs: (CopyNewMethods): new utility function used to
23135 assemble the list of methods from running FindMembers.
23137 (MemberLookup): Rework FindMembers so that
23139 2001-12-16 Miguel de Icaza <miguel@ximian.com>
23141 * class.cs (TypeContainer): Remove Delegates who fail to be
23144 * delegate.cs (Populate): Verify that we dont get null return
23145 values. TODO: Check for AsAccessible.
23147 * cs-parser.jay: Use basename to emit error 574 (destructor should
23148 have the same name as container class), not the full name.
23150 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
23151 possible representation.
23153 Also implements integer type suffixes U and L.
23155 2001-12-15 Miguel de Icaza <miguel@ximian.com>
23157 * expression.cs (ArrayCreation.DoResolve): We need to do the
23158 argument resolution *always*.
23160 * decl.cs: Make this hold the namespace. Hold the root context as
23162 (LookupType): Move here.
23164 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
23166 * location.cs (Row, Name): Fixed the code, it was always returning
23167 references to the first file.
23169 * interface.cs: Register properties defined through interfaces.
23171 * driver.cs: Add support for globbing on the command line
23173 * class.cs (Field): Make it derive from MemberCore as well.
23176 2001-12-15 Ravi Pratap <ravi@ximian.com>
23178 * class.cs (Event::Define): Check that the type of the event is a delegate
23179 type else flag error #66.
23181 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
23184 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
23185 values of EntryPoint, CharSet etc etc.
23187 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
23189 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
23190 be null and we should ignore this. I am not sure if this is really clean. Apparently,
23191 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
23192 which needs this to do its work.
23194 * ../errors/cs0066.cs : Add.
23196 2001-12-14 Miguel de Icaza <miguel@ximian.com>
23198 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
23201 * class.cs: (MethodSignature.MethodSignature): Removed hack that
23202 clears out the parameters field.
23203 (MemberSignatureCompare): Cleanup
23205 (MemberCore): New base class used to share code between MethodCore
23208 (RegisterRequiredImplementations) BindingFlags.Public requires
23209 either BindingFlags.Instace or Static. Use instance here.
23211 (Property): Refactored code to cope better with the full spec.
23213 * parameter.cs (GetParameterInfo): Return an empty array instead
23216 * class.cs (Property): Abstract or extern properties have no bodies.
23218 * parameter.cs (GetParameterInfo): return a zero-sized array.
23220 * class.cs (TypeContainer.MethodModifiersValid): Move all the
23221 method modifier validation to the typecontainer so we can reuse
23222 this on properties.
23224 (MethodCore.ParameterTypes): return an empty sized array of types.
23226 (Property.Define): Test property modifier validity.
23228 Add tests for sealed/override too.
23230 (Method.Emit): abstract or extern methods have no bodies.
23232 2001-12-14 Ravi Pratap <ravi@ximian.com>
23234 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
23237 (Method::Define, ::Emit): Modify accordingly.
23239 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
23241 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
23243 * makefile: Pass in /unsafe.
23245 2001-12-13 Miguel de Icaza <miguel@ximian.com>
23247 * class.cs (MakeKey): Kill routine.
23249 * class.cs (TypeContainer.Define): Correctly define explicit
23250 method implementations (they require the full interface name plus
23253 * typemanager.cs: Deply the PtrHashtable here and stop using the
23254 lame keys. Things work so much better.
23256 This of course broke everyone who depended on `RegisterMethod' to
23257 do the `test for existance' test. This has to be done elsewhere.
23259 * support.cs (PtrHashtable): A hashtable that avoid comparing with
23260 the object stupid Equals method (because, that like fails all over
23261 the place). We still do not use it.
23263 * class.cs (TypeContainer.SetRequiredInterface,
23264 TypeContainer.RequireMethods): Killed these two routines and moved
23265 all the functionality to RegisterRequiredImplementations.
23267 (TypeContainer.RegisterRequiredImplementations): This routine now
23268 registers all the implementations required in an array for the
23269 interfaces and abstract methods. We use an array of structures
23270 which can be computed ahead of time to reduce memory usage and we
23271 also assume that lookups are cheap as most classes will not
23272 implement too many interfaces.
23274 We also avoid creating too many MethodSignatures.
23276 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23277 clear the "pending" bit if we find that there are problems with
23280 (TypeContainer.VerifyPendingMethods): Update to report errors of
23281 methods that look like implementations but are not.
23283 (TypeContainer.Define): Add support for explicit interface method
23286 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23288 * typemanager.cs: Keep track of the parameters here instead of
23289 being a feature of the TypeContainer.
23291 * class.cs: Drop the registration of parameters here, as
23292 InterfaceMethods are also interface declarations.
23294 * delegate.cs: Register methods with the TypeManager not only with
23295 the TypeContainer. This code was buggy.
23297 * interface.cs: Full registation here.
23299 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23301 * expression.cs: Remove reducer for binary expressions, it can not
23304 * const.cs: Put here the code that used to go into constant.cs
23306 * constant.cs: Put here the code for constants, this is a new base
23307 class for Literals.
23309 * literal.cs: Make Literal derive from Constant.
23311 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23313 * statement.cs (Return.Emit): Report error 157 if the user
23314 attempts to return from a finally block.
23316 (Return.Emit): Instead of emitting a return, jump to the end of
23319 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23320 LocalBuilder to store the result of the function. ReturnLabel is
23321 the target where we jump.
23324 2001-12-09 Radek Doulik <rodo@ximian.com>
23326 * cs-parser.jay: remember alias in current namespace
23328 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23331 * class.cs (LookupAlias): lookup alias in my_namespace
23333 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23335 (LookupAlias): lookup alias in this and if needed in parent
23338 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23342 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23343 making things static. I need this to avoid passing the
23344 TypeContainer when calling ParameterType.
23346 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23347 that did string manipulation to compute the type and then call
23348 GetType. Use Parameter.ParameterType instead.
23350 * cs-tokenizer.cs: Consume the suffix for floating values.
23352 * expression.cs (ParameterReference): figure out whether this is a
23353 reference parameter or not. Kill an extra variable by computing
23354 the arg_idx during emission.
23356 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23357 function that returns whether a parameter is an out/ref value or not.
23359 (Parameter.ParameterType): The type of the parameter (base,
23360 without ref/out applied).
23362 (Parameter.Resolve): Perform resolution here.
23363 (Parameter.ExternalType): The full type (with ref/out applied).
23365 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23366 support for expressions on the using statement.
23368 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23370 * statement.cs (Using.EmitLocalVariableDecls): Split the
23371 localvariable handling of the using statement.
23373 (Block.EmitMeta): Keep track of variable count across blocks. We
23374 were reusing slots on separate branches of blocks.
23376 (Try.Emit): Emit the general code block, we were not emitting it.
23378 Check the type of the declaration to be an IDisposable or
23379 something that can be implicity converted to it.
23381 Emit conversions if required.
23383 * ecore.cs (EmptyExpression): New utility class.
23384 (Expression.ImplicitConversionExists): New utility function.
23386 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23388 * statement.cs (Using): Implement.
23390 * expression.cs (LocalVariableReference): Support read only variables.
23392 * statement.cs: Remove the explicit emit for the Leave opcode.
23393 (VariableInfo): Add a readonly field.
23395 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23397 * ecore.cs (ConvCast): new class used to encapsulate the various
23398 explicit integer conversions that works in both checked and
23399 unchecked contexts.
23401 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23402 properly generate the overflow opcodes.
23404 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23406 * statement.cs: The correct type for the EmptyExpression is the
23407 element_type, not the variable type. Ravi pointed this out.
23409 2001-12-04 Ravi Pratap <ravi@ximian.com>
23411 * class.cs (Method::Define): Handle PInvoke methods specially
23412 by using DefinePInvokeMethod instead of the usual one.
23414 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23415 above to do the task of extracting information and defining the method.
23417 2001-12-04 Ravi Pratap <ravi@ximian.com>
23419 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23420 of the condition for string type.
23422 (Emit): Move that here.
23424 (ArrayCreation::CheckIndices): Keep string literals in their expression
23427 (EmitDynamicInitializers): Handle strings appropriately.
23429 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23431 * codegen.cs (EmitContext): Replace multiple variables with a
23432 single pointer to the current Switch statement.
23434 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23437 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23441 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23444 (Foreach.Emit): Foreach on arrays was not setting
23445 up the loop variables (for break/continue).
23447 (GotoCase): Semi-implented.
23449 2001-12-03 Ravi Pratap <ravi@ximian.com>
23451 * attribute.cs (CheckAttribute): Handle system attributes by using
23452 Attribute.GetAttributes to examine information we need.
23454 (GetValidPlaces): Same here.
23456 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23458 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23460 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23462 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23464 (Method::Emit): Handle the case when we are a PInvoke method.
23466 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23468 * expression.cs: Use ResolveWithSimpleName on compound names.
23470 2001-12-02 Ravi Pratap <ravi@ximian.com>
23472 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23473 before trying to reduce it.
23475 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23477 * constant.cs (LookupConstantValue): Implement.
23479 (EmitConstant): Use the above in emitting the constant.
23481 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23482 that are user-defined by doing a LookupConstantValue on them.
23484 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23487 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23489 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23491 (BaseAccess.DoResolve): Implement.
23493 (MemberAccess.DoResolve): Split this routine into a
23494 ResolveMemberAccess routine that can be used independently
23496 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23498 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23499 As that share bits of the implementation. Is returns a boolean,
23500 while As returns the Type that is being probed.
23502 2001-12-01 Ravi Pratap <ravi@ximian.com>
23504 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23505 instead of a Literal - much easier.
23507 (EnumInTransit): Remove - utterly useless :-)
23509 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23511 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23513 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23514 chain when we have no associated expression.
23516 2001-11-30 Ravi Pratap <ravi@ximian.com>
23518 * constant.cs (Define): Use Location while reporting the errror.
23520 Also emit a warning when 'new' is used and there is no inherited
23523 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23526 (LookupEnumValue): Implement to lookup an enum member's value and define it
23529 (Populate): Re-write accordingly to use the above routine.
23531 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23533 * expression.cs (This): Fix prototype for DoResolveLValue to
23534 override the base class DoResolveLValue.
23536 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23539 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23540 (we need to load the address of the field here). This fixes
23543 (FieldExpr.DoResolveLValue): Call the DoResolve
23544 function to initialize the Instance expression.
23546 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23547 correctly the GetEnumerator operation on a value type.
23549 * cs-parser.jay: Add more simple parsing error catches.
23551 * statement.cs (Switch): Add support for string switches.
23552 Handle null specially.
23554 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23556 2001-11-28 Ravi Pratap <ravi@ximian.com>
23558 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23560 (declare_local_constant): New helper function.
23562 * statement.cs (AddConstant): Keep a separate record of constants
23564 (IsConstant): Implement to determine if a variable is a constant.
23566 (GetConstantExpression): Implement.
23568 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23570 * statement.cs (IsVariableDefined): Re-write.
23572 2001-11-27 Ravi Pratap <ravi@ximian.com>
23574 * class.cs (TypeContainer::FindMembers): Look for constants
23575 in the case when we are looking for MemberTypes.Field
23577 * expression.cs (MemberAccess::DoResolve): Check that in the
23578 case we are a FieldExpr and a Literal, we are not being accessed
23579 by an instance reference.
23581 * cs-parser.jay (local_constant_declaration): Implement.
23583 (declaration_statement): Implement for constant declarations.
23585 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23587 * statement.cs (Switch): Catch double defaults.
23589 (Switch): More work on the switch() statement
23590 implementation. It works for integral values now, need to finish
23594 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23596 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23597 integer literals into other integer literals. To be used by
23600 2001-11-24 Ravi Pratap <ravi@ximian.com>
23602 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23605 (EmitDynamicInitializers): Cope with the above since we extract data
23606 directly from ArrayData now.
23608 (ExpectInitializers): Keep track of whether initializers are mandatory
23611 (Bounds): Make it a hashtable to prevent the same dimension being
23612 recorded for every element in that dimension.
23614 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23617 Also fix bug which was causing the indices to be emitted in the reverse
23620 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23622 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23623 unfinished. They do not work, because the underlying code is
23626 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23628 * cs-parser.jay: Remove bogus fixme.
23630 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23631 on Switch statement.
23633 2001-11-23 Ravi Pratap <ravi@ximian.com>
23635 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23638 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23639 parameter. Apparently, any expression is allowed.
23641 (ValidateInitializers): Update accordingly.
23643 (CheckIndices): Fix some tricky bugs thanks to recursion.
23645 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23646 I was being completely brain-dead.
23648 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23649 and re-write acordingly.
23651 (DelegateInvocation): Re-write accordingly.
23653 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23655 (MakeByteBlob): Handle types more correctly.
23657 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23658 initialization from expressions but it is incomplete because I am a complete
23661 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23663 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23664 on If. Basically, we have to return `true' (ie, we do return to
23665 our caller) only if both branches of the if return.
23667 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23668 short-circuit operators, handle them as short circuit operators.
23670 (Cast.DoResolve): Resolve type.
23671 (Cast.Cast): Take an expression as the target type.
23673 * cs-parser.jay (cast_expression): Remove old hack that only
23674 allowed a limited set of types to be handled. Now we take a
23675 unary_expression and we resolve to a type during semantic
23678 Use the grammar productions from Rhys to handle casts (this is
23679 not complete like Rhys syntax yet, we fail to handle that corner
23680 case that C# has regarding (-x), but we will get there.
23682 2001-11-22 Ravi Pratap <ravi@ximian.com>
23684 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23685 field which is an array type.
23687 * cs-parser.jay (declare_local_variables): Support array initialization too.
23689 * typemanager.cs (MakeKey): Implement.
23691 (everywhere): Use the above appropriately.
23693 * cs-parser.jay (for_statement): Update for array initialization while
23694 declaring variables.
23696 * ecore.cs : The error message was correct, it's the variable's names that
23697 were misleading ;-) Make the code more readable.
23699 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23700 the correct type etc.
23702 (ConvertExplicit): Handle Enum types by examining the underlying type.
23704 2001-11-21 Ravi Pratap <ravi@ximian.com>
23706 * parameter.cs (GetCallingConvention): Always return
23707 CallingConventions.Standard for now.
23709 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23711 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23712 and `r' after calling DoNumericPromotions.
23714 * ecore.cs: Fix error message (the types were in the wrong order).
23716 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23717 BindingFlags.Instance as well
23719 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23720 implicit int literal conversion in an empty cast so that we
23721 propagate the right type upstream.
23723 (UnboxCast): new class used to unbox value types.
23724 (Expression.ConvertExplicit): Add explicit type conversions done
23727 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23728 the target type before applying the implicit LongLiterals to ULong
23731 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23733 * cs-parser.jay (for_statement): Reworked the way For works: now
23734 we declare manually any variables that are introduced in
23735 for_initializer to solve the problem of having out-of-band code
23736 emition (that is what got for broken).
23738 (declaration_statement): Perform the actual variable declaration
23739 that used to be done in local_variable_declaration here.
23741 (local_variable_declaration): Do not declare anything, just pass
23742 the information on a DictionaryEntry
23744 2001-11-20 Ravi Pratap <ravi@ximian.com>
23746 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23747 re-write of the logic to now make it recursive.
23749 (UpdateIndices): Re-write accordingly.
23751 Store element data in a separate ArrayData list in the above methods.
23753 (MakeByteBlob): Implement to dump the array data into a byte array.
23755 2001-11-19 Ravi Pratap <ravi@ximian.com>
23757 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23760 * constant.cs (Define): Implement.
23762 (EmitConstant): Re-write fully.
23764 Pass in location info.
23766 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23769 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23770 DictionaryEntry since we need location info too.
23772 (constant_declaration): Update accordingly.
23774 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23775 code into another method : UpdateIndices.
23777 2001-11-18 Ravi Pratap <ravi@ximian.com>
23779 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23780 some type checking etc.
23782 2001-11-17 Ravi Pratap <ravi@ximian.com>
23784 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23785 bits to provide dimension info if the user skips doing that.
23787 Update second constructor to store the rank correctly.
23789 2001-11-16 Ravi Pratap <ravi@ximian.com>
23791 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23792 and try to implement.
23794 * ../errors/cs0150.cs : Add.
23796 * ../errors/cs0178.cs : Add.
23798 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23800 * statement.cs: Implement foreach on multi-dimensional arrays.
23802 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23803 name of the params argument.
23805 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23806 initializing the array.
23808 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23809 we can use this elsewhere.
23811 * statement.cs: Finish implementation of foreach for single
23814 * cs-parser.jay: Use an out-of-band stack to pass information
23815 around, I wonder why I need this.
23817 foreach_block: Make the new foreach_block the current_block.
23819 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23820 function used to return a static Parameters structure. Used for
23821 empty parameters, as those are created very frequently.
23823 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23825 2001-11-15 Ravi Pratap <ravi@ximian.com>
23827 * interface.cs : Default modifier is private, not public. The
23828 make verify test passes again.
23830 2001-11-15 Ravi Pratap <ravi@ximian.com>
23832 * support.cs (ReflectionParameters): Fix logic to determine
23833 whether the last parameter is a params one. Test 9 passes again.
23835 * delegate.cs (Populate): Register the builders we define with
23836 RegisterParameterForBuilder. Test 19 passes again.
23838 * cs-parser.jay (property_declaration): Reference $6 instead
23839 of $$ to get at the location.
23841 (indexer_declaration): Similar stuff.
23843 (attribute): Ditto.
23845 * class.cs (Property): Register parameters for the Get and Set methods
23846 if they exist. Test 23 passes again.
23848 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23849 call to EmitArguments as we are sure there aren't any params arguments.
23850 Test 32 passes again.
23852 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23853 IndexOutOfRangeException.
23855 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23856 Test 33 now passes again.
23858 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23860 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23861 broke a bunch of things. Will have to come up with a better way
23862 of tracking locations.
23864 * statement.cs: Implemented foreach for single dimension arrays.
23866 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23868 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23869 an error. This removes the lookup from the critical path.
23871 * cs-parser.jay: Removed use of temporary_loc, which is completely
23874 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23876 * support.cs (ReflectionParameters.ParameterModifier): Report
23877 whether the argument is a PARAMS argument or not.
23879 * class.cs: Set the attribute `ParamArrayAttribute' on the
23880 parameter argument.
23882 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23883 and cons_param_array_attribute (ConstructorInfo for
23884 ParamArrayAttribute).,
23886 * codegen.cs: Emit the return using the `Return' statement, that
23887 way we can report the error correctly for missing return values.
23889 * class.cs (Method.Emit): Clean up.
23891 * expression.cs (Argument.Resolve): Take another argument: the
23892 location where this argument is used. Notice that this is not
23893 part of the "Argument" class as to reduce the size of the
23894 structure (we know the approximate location anyways).
23896 Test if the argument is a variable-reference, if not, then
23897 complain with a 206.
23899 (Argument.Emit): Emit addresses of variables.
23901 (Argument.FullDesc): Simplify.
23903 (Invocation.DoResolve): Update for Argument.Resolve.
23905 (ElementAccess.DoResolve): ditto.
23907 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
23908 method should be virtual, as this method is always virtual.
23910 (NewDelegate.DoResolve): Update for Argument.Resolve.
23912 * class.cs (ConstructorInitializer.DoResolve): ditto.
23914 * attribute.cs (Attribute.Resolve): ditto.
23916 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23918 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
23920 * expression.cs (ParameterReference): Drop IStackStorage and implement
23921 IAssignMethod instead.
23923 (LocalVariableReference): ditto.
23925 * ecore.cs (FieldExpr): Drop IStackStorage and implement
23926 IAssignMethod instead.
23928 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23930 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
23931 enumerations that are used in heavily used structures derive from
23932 byte in a laughable and pathetic attempt to reduce memory usage.
23933 This is the kind of pre-optimzations that you should not do at
23934 home without adult supervision.
23936 * expression.cs (UnaryMutator): New class, used to handle ++ and
23937 -- separatedly from the other unary operators. Cleans up the
23938 code, and kills the ExpressionStatement dependency in Unary.
23940 (Unary): Removed `method' and `Arguments' from this class, making
23941 it smaller, and moving it all to SimpleCall, so I can reuse this
23942 code in other locations and avoid creating a lot of transient data
23943 strucutres when not required.
23945 * cs-parser.jay: Adjust for new changes.
23947 2001-11-11 Miguel de Icaza <miguel@ximian.com>
23949 * enum.cs (Enum.Populate): If there is a failure during
23952 * cs-parser.jay (opt_enum_base): we used to catch type errors
23953 here, but this is really incorrect. The type error should be
23954 catched during semantic analysis.
23956 2001-12-11 Ravi Pratap <ravi@ximian.com>
23958 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
23959 current_local_parameters as expected since I, in my stupidity, had forgotten
23962 * attribute.cs (GetValidPlaces): Fix stupid bug.
23964 * class.cs (Method::Emit): Perform check on applicability of attributes.
23966 (Constructor::Emit): Ditto.
23968 (Field::Emit): Ditto.
23970 (Field.Location): Store location information.
23972 (Property, Event, Indexer, Operator): Ditto.
23974 * cs-parser.jay (field_declaration): Pass in location for each field.
23976 * ../errors/cs0592.cs : Add.
23978 2001-11-12 Ravi Pratap <ravi@ximian.com>
23980 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
23982 (InitCoreTypes): Update accordingly.
23984 (RegisterAttrType, LookupAttr): Implement.
23986 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
23987 info about the same.
23989 (Resolve): Update to populate the above as necessary.
23991 (Error592): Helper.
23993 (GetValidPlaces): Helper to the above.
23995 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
23997 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
23999 2001-11-12 Ravi Pratap <ravi@ximian.com>
24001 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
24003 * ../errors/cs0617.cs : Add.
24005 2001-11-11 Ravi Pratap <ravi@ximian.com>
24007 * enum.cs (Emit): Rename to Populate to be more consistent with what
24008 we expect it to do and when exactly it is called.
24010 * class.cs, rootcontext.cs : Update accordingly.
24012 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
24013 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
24015 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
24017 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24018 of a fieldinfo using the above, when dealing with a FieldBuilder.
24020 2001-11-10 Ravi Pratap <ravi@ximian.com>
24022 * ../errors/cs0031.cs : Add.
24024 * ../errors/cs1008.cs : Add.
24026 * ../errrors/cs0543.cs : Add.
24028 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
24031 (FindMembers): Implement.
24033 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
24034 enums and delegates too.
24036 (enum_types): Rename to builder_to_enum.
24038 (delegate_types): Rename to builder_to_delegate.
24040 * delegate.cs (FindMembers): Implement.
24042 2001-11-09 Ravi Pratap <ravi@ximian.com>
24044 * typemanager.cs (IsEnumType): Implement.
24046 * enum.cs (Emit): Re-write parts to account for the underlying type
24047 better and perform checking etc.
24049 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
24050 of the underlying type.
24052 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24055 * enum.cs (error31): Helper to report error #31.
24057 * cs-parser.jay (enum_declaration): Store location of each member too.
24059 * enum.cs (member_to_location): New hashtable.
24061 (AddEnumMember): Update location hashtable.
24063 (Emit): Use the location of each member while reporting errors.
24065 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24067 * cs-parser.jay: A for_initializer if is a
24068 local_variable_declaration really ammount to have an implicit
24069 block with the variable declaration and no initializer for for.
24071 * statement.cs (For.Emit): Cope with null initializers.
24073 This fixes the infinite loop on for initializers.
24075 2001-11-08 Miguel de Icaza <miguel@ximian.com>
24077 * enum.cs: More cleanup.
24079 * ecore.cs: Remove dead code.
24081 * class.cs (Property.Emit): More simplification.
24082 (Event.Emit): ditto.
24084 Reworked to have less levels of indentation.
24086 2001-11-08 Ravi Pratap <ravi@ximian.com>
24088 * class.cs (Property): Emit attributes.
24098 * enum.cs (Emit): Ditto.
24100 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
24103 * class.cs (Field, Event, etc.): Move attribute generation into the
24104 Emit method everywhere.
24106 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
24107 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
24108 as we had no way of defining nested enums !
24110 * rootcontext.cs : Adjust code accordingly.
24112 * typemanager.cs (AddEnumType): To keep track of enum types separately.
24114 2001-11-07 Ravi Pratap <ravi@ximian.com>
24116 * expression.cs (EvalConstantExpression): Move into ecore.cs
24118 * enum.cs (Enum): Rename some members and make them public and readonly
24119 according to our convention.
24121 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24124 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
24126 (Enum::Emit): Write a simple version for now which doesn't try to compute
24127 expressions. I shall modify this to be more robust in just a while.
24129 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
24131 (TypeContainer::CloseType): Create the Enum types too.
24133 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
24135 * expression.cs (EvalConstantExpression): Get rid of completely.
24137 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
24138 user-defined values and other cases.
24140 (IsValidEnumLiteral): Helper function.
24142 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
24143 out there in the case we had a literal FieldExpr.
24145 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
24147 (Literalize): Revamp a bit to take two arguments.
24149 (EnumLiteral): New class which derives from Literal to wrap enum literals.
24151 2001-11-06 Ravi Pratap <ravi@ximian.com>
24153 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
24155 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
24157 (Resolve): Use the above to ensure we have proper initializers.
24159 2001-11-05 Ravi Pratap <ravi@ximian.com>
24161 * expression.cs (Expression::EvalConstantExpression): New method to
24162 evaluate constant expressions.
24164 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
24166 2001-11-07 Miguel de Icaza <miguel@ximian.com>
24168 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
24171 (Binary.ResolveOperator): Handle operator != (object a, object b)
24172 and operator == (object a, object b);
24174 (Binary.DoNumericPromotions): Indicate whether the numeric
24175 promotion was possible.
24177 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
24180 Made the ArrayAccess implement interface IAssignMethod instead of
24181 IStackStore as the order in which arguments are passed reflects
24184 * assign.cs: Instead of using expr.ExprClass to select the way of
24185 assinging, probe for the IStackStore/IAssignMethod interfaces.
24187 * typemanager.cs: Load InitializeArray definition.
24189 * rootcontext.cs (RootContext.MakeStaticData): Used to define
24190 static data that can be used to initialize arrays.
24192 2001-11-05 Miguel de Icaza <miguel@ximian.com>
24194 * expression.cs: Handle operator== and operator!= for booleans.
24196 (Conditioal.Reduce): Implement reducer for the ?: operator.
24198 (Conditional.Resolve): Implement dead code elimination.
24200 (Binary.Resolve): Catch string literals and return a new
24201 concatenated string.
24203 (Unary.Reduce): Implement reduction of unary expressions.
24205 * ecore.cs: Split out the expression core handling here.
24207 (Expression.Reduce): New method used to perform constant folding
24208 and CSE. This is needed to support constant-expressions.
24210 * statement.cs (Statement.EmitBoolExpression): Pass true and false
24211 targets, and optimize for !x.
24213 2001-11-04 Ravi Pratap <ravi@ximian.com>
24215 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
24216 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
24217 set custom atttributes.
24219 * literal.cs (Literal::GetValue): New abstract method to return the actual
24220 value of the literal, cast as an object.
24222 (*Literal): Implement GetValue method.
24224 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
24225 expressions to the arraylist but objects of type Argument.
24227 * class.cs (TypeContainer::Emit): Emit our attributes too.
24229 (Method::Emit, Constructor::Emit): Ditto.
24231 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
24232 to be ignoring earlier.
24234 2001-11-03 Ravi Pratap <ravi@ximian.com>
24236 * attribute.cs (AttributeSection::Define): Implement to do the business
24237 of constructing a CustomAttributeBuilder.
24239 (Attribute): New trivial class. Increases readability of code.
24241 * cs-parser.jay : Update accordingly.
24243 (positional_argument_list, named_argument_list, named_argument): New rules
24245 (attribute_arguments): Use the above so that we are more correct.
24247 2001-11-02 Ravi Pratap <ravi@ximian.com>
24249 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
24250 to perform all checks for a method with a params parameter.
24252 (Invocation::OverloadResolve): Update to use the above method and therefore
24253 cope correctly with params method invocations.
24255 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
24258 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
24259 constructors in our parent too because we can't afford to miss out on
24262 * attribute.cs (AttributeSection): New name for the class Attribute
24264 Other trivial changes to improve readability.
24266 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
24267 use the new class names.
24269 2001-11-01 Ravi Pratap <ravi@ximian.com>
24271 * class.cs (Method::Define): Complete definition for params types too
24273 (Indexer::Define): Ditto.
24275 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
24276 Cope everywhere with a request for info about the array parameter.
24278 2001-11-01 Ravi Pratap <ravi@ximian.com>
24280 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24282 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24283 local_variable_type to extract the string corresponding to the type.
24285 (local_variable_type): Fixup the action to use the new helper method.
24287 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24290 * expression.cs : Clean out code which uses the above.
24292 2001-10-31 Ravi Pratap <ravi@ximian.com>
24294 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24295 and bale out if necessary by returning a false.
24297 (RegisterProperty): Ditto.
24299 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24300 and print out appropriate error messages.
24302 * interface.cs (everywhere): Ditto.
24304 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24305 location to constructor.
24307 * class.cs (Property, Event, Indexer): Update accordingly.
24309 * ../errors/cs111.cs : Added.
24311 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24312 of a method, as laid down by the spec.
24314 (Invocation::OverloadResolve): Use the above method.
24316 2001-10-31 Ravi Pratap <ravi@ximian.com>
24318 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24319 now take a TypeContainer and a Parameters object.
24321 (ParameterData): Modify return type of ParameterModifier method to be
24322 Parameter.Modifier and not a string.
24324 (ReflectionParameters, InternalParameters): Update accordingly.
24326 * expression.cs (Argument::GetParameterModifier): Same here.
24328 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24329 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24330 symbol in it at all so maybe this is only for now.
24332 2001-10-30 Ravi Pratap <ravi@ximian.com>
24334 * support.cs (InternalParameters): Constructor now takes an extra argument
24335 which is the actual Parameters class.
24337 (ParameterDesc): Update to provide info on ref/out modifiers.
24339 * class.cs (everywhere): Update call to InternalParameters to pass in
24340 the second argument too.
24342 * support.cs (ParameterData): Add ParameterModifier, which is a method
24343 to return the modifier info [ref/out etc]
24345 (InternalParameters, ReflectionParameters): Implement the above.
24347 * expression.cs (Argument::ParameterModifier): Similar function to return
24348 info about the argument's modifiers.
24350 (Invocation::OverloadResolve): Update to take into account matching modifiers
24353 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24354 a new SetFormalParameters object which we pass to InternalParameters.
24356 2001-10-30 Ravi Pratap <ravi@ximian.com>
24358 * expression.cs (NewArray): Merge into the ArrayCreation class.
24360 2001-10-29 Ravi Pratap <ravi@ximian.com>
24362 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24363 NewUserdefinedArray into one as there wasn't much of a use in having
24366 * expression.cs (Argument): Change field's name to ArgType from Type.
24368 (Type): New readonly property which returns the proper type, taking into
24369 account ref/out modifiers.
24371 (everywhere): Adjust code accordingly for the above.
24373 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24374 whether we are emitting for a ref or out parameter.
24376 * expression.cs (Argument::Emit): Use the above field to set the state.
24378 (LocalVariableReference::Emit): Update to honour the flag and emit the
24381 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24383 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24385 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24387 (ReflectionParameters, InternalParameters): Implement the above method.
24389 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24392 (Invocation::FullMethodDesc): Ditto.
24394 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24396 * cs-parser.jay: Add extra production for the second form of array
24399 * expression.cs (ArrayCreation): Update to reflect the above
24402 * Small changes to prepare for Array initialization.
24404 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24406 * typemanager.cs (ImplementsInterface): interface might be null;
24407 Deal with this problem;
24409 Also, we do store negative hits on the cache (null values), so use
24410 this instead of calling t.GetInterfaces on the type everytime.
24412 2001-10-28 Ravi Pratap <ravi@ximian.com>
24414 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24416 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24417 split functionality out into different classes.
24419 (New::FormArrayType): Move into NewBuiltinArray.
24421 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24424 (NewBuiltinArray): New class to handle creation of built-in arrays.
24426 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24427 account creation of one-dimensional arrays.
24429 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24431 (NewUserdefinedArray::DoResolve): Implement.
24433 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24435 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24436 we maintain inside the TypeManager. This is necessary to perform lookups on the
24439 (LookupType): Update to perform GetType on the module builders too.
24441 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24443 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24445 2001-10-23 Ravi Pratap <ravi@ximian.com>
24447 * expression.cs (New::DoResolve): Implement guts of array creation.
24449 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24451 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24453 * expression.cs: Fix bug I introduced lsat night that broke
24456 (Expression.Resolve): Report a 246 error (can not resolve name)
24457 if we find a SimpleName in the stream.
24459 (Expression.ResolveLValue): Ditto.
24461 (Expression.ResolveWithSimpleName): This function is a variant of
24462 ResolveName, this one allows SimpleNames to be returned without a
24463 warning. The only consumer of SimpleNames is MemberAccess
24465 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24467 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24468 might arrive here. I have my doubts that this is correct.
24470 * statement.cs (Lock): Implement lock statement.
24472 * cs-parser.jay: Small fixes to support `lock' and `using'
24474 * cs-tokenizer.cs: Remove extra space
24476 * driver.cs: New flag --checked, allows to turn on integer math
24479 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24480 Threading.Monitor.Exit
24482 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24484 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24485 Expression Class to be IndexerAccess.
24487 Notice that Indexer::DoResolve sets the eclass to Value.
24489 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24491 * class.cs (TypeContainer::Emit): Emit code for indexers.
24493 * assign.cs (IAssignMethod): New interface implemented by Indexers
24494 and Properties for handling assignment.
24496 (Assign::Emit): Simplify and reuse code.
24498 * expression.cs (IndexerAccess, PropertyExpr): Implement
24499 IAssignMethod, clean up old code.
24501 2001-10-22 Ravi Pratap <ravi@ximian.com>
24503 * typemanager.cs (ImplementsInterface): New method to determine if a type
24504 implements a given interface. Provides a nice cache too.
24506 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24509 (ConvertReferenceExplicit): Ditto.
24511 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24512 various methods, with correct names etc.
24514 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24515 Operator.UnaryNegation.
24517 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24518 we have a unary plus or minus operator.
24520 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24523 * everywhere : update accordingly.
24525 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24528 * class.cs (Method::Define): For the case where we are implementing a method
24529 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24530 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24532 2001-10-21 Ravi Pratap <ravi@ximian.com>
24534 * interface.cs (FindMembers): Implement to work around S.R.E
24537 * typemanager.cs (IsInterfaceType): Implement.
24539 (FindMembers): Update to handle interface types too.
24541 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24542 use IsAssignableFrom as that is not correct - it doesn't work.
24544 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24545 and accordingly override EmitStatement.
24547 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24548 using the correct logic :-)
24550 2001-10-19 Ravi Pratap <ravi@ximian.com>
24552 * ../errors/cs-11.cs : Add to demonstrate error -11
24554 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24556 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24557 then pass this as a hint to ResolveLValue.
24559 * expression.cs (FieldExpr): Add Location information
24561 (FieldExpr::LValueResolve): Report assignment to readonly
24564 (Expression::ExprClassFromMemberInfo): Pass location information.
24566 (Expression::ResolveLValue): Add new method that resolves an
24569 (Expression::DoResolveLValue): Default invocation calls
24572 (Indexers): New class used to keep track of indexers in a given
24575 (IStackStore): Renamed from LValue, as it did not really describe
24576 what this did. Also ResolveLValue is gone from this interface and
24577 now is part of Expression.
24579 (ElementAccess): Depending on the element access type
24581 * typemanager.cs: Add `indexer_name_type' as a Core type
24582 (System.Runtime.CompilerServices.IndexerNameAttribute)
24584 * statement.cs (Goto): Take a location.
24586 2001-10-18 Ravi Pratap <ravi@ximian.com>
24588 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24589 if two delegates are compatible.
24591 (NewDelegate::DoResolve): Update to take care of the case when
24592 we instantiate a delegate from another delegate.
24594 * typemanager.cs (FindMembers): Don't even try to look up members
24595 of Delegate types for now.
24597 2001-10-18 Ravi Pratap <ravi@ximian.com>
24599 * delegate.cs (NewDelegate): New class to take care of delegate
24602 * expression.cs (New): Split the delegate related code out into
24603 the NewDelegate class.
24605 * delegate.cs (DelegateInvocation): New class to handle delegate
24608 * expression.cs (Invocation): Split out delegate related code into
24609 the DelegateInvocation class.
24611 2001-10-17 Ravi Pratap <ravi@ximian.com>
24613 * expression.cs (New::DoResolve): Implement delegate creation fully
24614 and according to the spec.
24616 (New::DoEmit): Update to handle delegates differently.
24618 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24619 because of which we were printing out arguments in reverse order !
24621 * delegate.cs (VerifyMethod): Implement to check if the given method
24622 matches the delegate.
24624 (FullDelegateDesc): Implement.
24626 (VerifyApplicability): Implement.
24628 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24629 delegate invocations too.
24631 (Invocation::Emit): Ditto.
24633 * ../errors/cs1593.cs : Added.
24635 * ../errors/cs1594.cs : Added.
24637 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24639 2001-10-16 Ravi Pratap <ravi@ximian.com>
24641 * typemanager.cs (intptr_type): Core type for System.IntPtr
24643 (InitCoreTypes): Update for the same.
24645 (iasyncresult_type, asynccallback_type): Ditto.
24647 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24650 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24653 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24654 the builders for the 4 members of a delegate type :-)
24656 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24659 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24661 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24663 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24665 * statement.cs (Break::Emit): Implement.
24666 (Continue::Emit): Implement.
24668 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24669 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24670 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24671 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24674 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24675 properties that track the label for the current loop (begin of the
24676 loop and end of the loop).
24678 2001-10-15 Ravi Pratap <ravi@ximian.com>
24680 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24681 use of emitting anything at all.
24683 * class.cs, rootcontext.cs : Get rid of calls to the same.
24685 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24687 (Populate): Define the constructor correctly and set the implementation
24690 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24693 (AddDelegateType): Implement.
24695 (IsDelegateType): Implement helper method.
24697 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24699 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24700 and accordingly handle it.
24702 * delegate.cs (Populate): Take TypeContainer argument.
24703 Implement bits to define the Invoke method. However, I still haven't figured out
24704 how to take care of the native int bit :-(
24706 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24707 Qualify the name of the delegate, not its return type !
24709 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24712 (StandardConversionExists): Checking for array types turns out to be recursive.
24714 (ConvertReferenceExplicit): Implement array conversion.
24716 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24718 2001-10-12 Ravi Pratap <ravi@ximian.com>
24720 * cs-parser.jay (delegate_declaration): Store the fully qualified
24721 name as it is a type declaration.
24723 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24726 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24727 as TypeContainer::DefineType.
24729 (Populate): Method in which all the definition of the various methods (Invoke)
24732 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24735 (CloseDelegate): Finally creates the delegate.
24737 * class.cs (TypeContainer::DefineType): Update to define delegates.
24738 (Populate, Emit and CloseType): Do the same thing here too.
24740 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24741 delegates in all these operations.
24743 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24745 * expression.cs: LocalTemporary: a new expression used to
24746 reference a temporary that has been created.
24748 * assign.cs: Handle PropertyAccess back here, so that we can
24749 provide the proper semantic access to properties.
24751 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24752 a few more explicit conversions.
24754 * modifiers.cs: `NEW' modifier maps to HideBySig.
24756 * expression.cs (PropertyExpr): Make this into an
24757 ExpressionStatement, and support the EmitStatement code path.
24759 Perform get/set error checking, clean up the interface.
24761 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24762 them into toplevel access objects.
24764 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24766 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24769 * typemanager.cs: Keep track here of our PropertyBuilders again to
24770 work around lameness in SRE.
24772 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24774 * expression.cs (LValue::LValueResolve): New method in the
24775 interface, used to perform a second resolution pass for LValues.
24777 (This::DoResolve): Catch the use of this in static methods.
24779 (This::LValueResolve): Implement.
24781 (This::Store): Remove warning, assigning to `this' in structures
24784 (Invocation::Emit): Deal with invocation of
24785 methods on value types. We need to pass the address to structure
24786 methods rather than the object itself. (The equivalent code to
24787 emit "this" for structures leaves the entire structure on the
24788 stack instead of a pointer to it).
24790 (ParameterReference::DoResolve): Compute the real index for the
24791 argument based on whether the method takes or not a `this' pointer
24792 (ie, the method is static).
24794 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24795 value types returned from functions when we need to invoke a
24796 method on the sturcture.
24799 2001-10-11 Ravi Pratap <ravi@ximian.com>
24801 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24802 defining the type in the Modulebuilder or Typebuilder. This is to take
24803 care of nested types which need to be defined on the TypeBuilder using
24804 DefineNestedMethod.
24806 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24807 methods in RootContext, only ported to be part of TypeContainer.
24809 (TypeContainer::GetInterfaceOrClass): Ditto.
24811 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24813 * interface.cs (Interface::DefineInterface): New method. Does exactly
24814 what RootContext.CreateInterface did earlier, only it takes care of nested types
24817 (Interface::GetInterfaces): Move from RootContext here and port.
24819 (Interface::GetInterfaceByName): Same here.
24821 * rootcontext.cs (ResolveTree): Re-write.
24823 (PopulateTypes): Re-write.
24825 * class.cs (TypeContainer::Populate): Populate nested types too.
24826 (TypeContainer::Emit): Emit nested members too.
24828 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24829 instead just use the name argument passed in as it is already fully
24832 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24833 to TypeContainer mapping to see if a type is user-defined.
24835 * class.cs (TypeContainer::CloseType): Implement.
24837 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24838 the default constructor.
24840 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24843 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24845 * interface.cs (CloseType): Create the type here.
24847 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24850 Remove all the methods which are now in TypeContainer.
24852 2001-10-10 Ravi Pratap <ravi@ximian.com>
24854 * delegate.cs (Define): Re-write bits to define the delegate
24857 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24859 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24861 * expression.cs (ImplicitReferenceConversion): handle null as well
24862 as a source to convert to any reference type.
24864 * statement.cs (Return): Perform any implicit conversions to
24865 expected return type.
24867 Validate use of return statement.
24869 * codegen.cs (EmitContext): Pass the expected return type here.
24871 * class.cs (Method, Constructor, Property): Pass expected return
24872 type to EmitContext.
24874 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24876 * expression.cs: Make DoResolve take an EmitContext instead of a
24879 Replaced `l' and `location' for `loc', for consistency.
24881 (Error, Warning): Remove unneeded Tc argument.
24883 * assign.cs, literal.cs, constant.cs: Update to new calling
24886 * codegen.cs: EmitContext now contains a flag indicating whether
24887 code is being generated in a static method or not.
24889 * cs-parser.jay: DecomposeQI, new function that replaces the old
24890 QualifiedIdentifier. Now we always decompose the assembled
24891 strings from qualified_identifier productions into a group of
24894 2001-10-08 Miguel de Icaza <miguel@ximian.com>
24896 * rootcontext.cs: Deal with field-less struct types correctly now
24897 by passing the size option to Define Type.
24899 * class.cs: Removed hack that created one static field.
24901 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24903 * statement.cs: Moved most of the code generation here.
24905 2001-10-09 Ravi Pratap <ravi@ximian.com>
24907 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
24910 (ElementAccess): Remove useless bits for now - keep checks as the spec
24913 2001-10-08 Ravi Pratap <ravi@ximian.com>
24915 * expression.cs (ElementAccess::DoResolve): Remove my crap code
24916 and start performing checks according to the spec.
24918 2001-10-07 Ravi Pratap <ravi@ximian.com>
24920 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
24921 rank_specifiers instead.
24923 (rank_specifiers): Change the order in which the rank specifiers are stored
24925 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
24927 * expression.cs (ElementAccess): Implement the LValue interface too.
24929 2001-10-06 Ravi Pratap <ravi@ximian.com>
24931 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
24932 except that user defined conversions are not included.
24934 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
24935 perform the conversion of the return type, if necessary.
24937 (New::DoResolve): Check whether we are creating an array or an object
24938 and accordingly do the needful.
24940 (New::Emit): Same here.
24942 (New::DoResolve): Implement guts of array creation.
24944 (New::FormLookupType): Helper function.
24946 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24948 * codegen.cs: Removed most of the code generation here, and move the
24949 corresponding code generation bits to the statement classes.
24951 Added support for try/catch/finalize and throw.
24953 * cs-parser.jay: Added support for try/catch/finalize.
24955 * class.cs: Catch static methods having the flags override,
24956 virtual or abstract.
24958 * expression.cs (UserCast): This user cast was not really doing
24959 what it was supposed to do. Which is to be born in fully resolved
24960 state. Parts of the resolution were being performed at Emit time!
24964 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24966 * expression.cs: Implicity convert the result from UserCast.
24968 2001-10-05 Ravi Pratap <ravi@ximian.com>
24970 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
24971 prevented it from working correctly.
24973 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
24974 merely ConvertImplicit.
24976 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24978 * typemanager.cs: Make the LookupTypeContainer function static,
24979 and not per-instance.
24981 * class.cs: Make static FindMembers (the one that takes a Type
24984 * codegen.cs: Add EmitForeach here.
24986 * cs-parser.jay: Make foreach a toplevel object instead of the
24987 inline expansion, as we need to perform semantic analysis on it.
24989 2001-10-05 Ravi Pratap <ravi@ximian.com>
24991 * expression.cs (Expression::ImplicitUserConversion): Rename to
24992 UserDefinedConversion.
24994 (Expression::UserDefinedConversion): Take an extra argument specifying
24995 whether we look for explicit user conversions too.
24997 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
24999 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
25001 (ExplicitUserConversion): Make it a call to UserDefinedConversion
25002 with the appropriate arguments.
25004 * cs-parser.jay (cast_expression): Record location too.
25006 * expression.cs (Cast): Record location info.
25008 (Expression::ConvertExplicit): Take location argument.
25010 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
25011 to determine if we are doing explicit conversions.
25013 (UserCast::Emit): Update accordingly.
25015 (Expression::ConvertExplicit): Report an error if everything fails.
25017 * ../errors/cs0030.cs : Add.
25019 2001-10-04 Miguel de Icaza <miguel@ximian.com>
25021 * modifiers.cs: If the ABSTRACT keyword is present, also set the
25022 virtual and newslot bits.
25024 * class.cs (TypeContainer::RegisterRequiredImplementations):
25025 Record methods we need.
25027 (TypeContainer::MakeKey): Helper function to make keys for
25028 MethodBases, since the Methodbase key is useless.
25030 (TypeContainer::Populate): Call RegisterRequiredImplementations
25031 before defining the methods.
25033 Create a mapping for method_builders_to_methods ahead of time
25034 instead of inside a tight loop.
25036 (::RequireMethods): Accept an object as the data to set into the
25037 hashtable so we can report interface vs abstract method mismatch.
25039 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25041 * report.cs: Make all of it static.
25043 * rootcontext.cs: Drop object_type and value_type computations, as
25044 we have those in the TypeManager anyways.
25046 Drop report instance variable too, now it is a global.
25048 * driver.cs: Use try/catch on command line handling.
25050 Add --probe option to debug the error reporting system with a test
25053 * report.cs: Add support for exiting program when a probe
25054 condition is reached.
25056 2001-10-03 Ravi Pratap <ravi@ximian.com>
25058 * expression.cs (Binary::DoNumericPromotions): Fix the case when
25059 we do a forcible conversion regardless of type, to check if
25060 ForceConversion returns a null.
25062 (Binary::error19): Use location to report error.
25064 (Unary::error23): Use location here too.
25066 * ../errors/cs0019.cs : Check in.
25068 * ../errors/cs0023.cs : Check in.
25070 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
25071 case of a non-null MethodInfo object with a length of 0 !
25073 (Binary::ResolveOperator): Flag error if overload resolution fails to find
25074 an applicable member - according to the spec :-)
25075 Also fix logic to find members in base types.
25077 (Unary::ResolveOperator): Same here.
25079 (Unary::report23): Change name to error23 and make first argument a TypeContainer
25080 as I was getting thoroughly confused between this and error19 :-)
25082 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
25083 (::FindMostEncompassedType): Implement.
25084 (::FindMostEncompassingType): Implement.
25085 (::StandardConversionExists): Implement.
25087 (UserImplicitCast): Re-vamp. We now need info about most specific
25088 source and target types so that we can do the necessary conversions.
25090 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
25091 mathematical union with no duplicates.
25093 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25095 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
25096 in order from base classes to child classes, so that we can in
25097 child classes look up in our parent for method names and
25098 attributes (required for handling abstract, virtual, new, override
25099 constructs: we need to instrospect our base class, and if we dont
25100 populate the classes in order, the introspection might be
25101 incorrect. For example, a method could query its parent before
25102 the parent has any methods and would determine that the parent has
25103 no abstract methods (while it could have had them)).
25105 (RootContext::CreateType): Record the order in which we define the
25108 2001-10-02 Miguel de Icaza <miguel@ximian.com>
25110 * class.cs (TypeContainer::Populate): Also method definitions can
25111 fail now, keep track of this.
25113 (TypeContainer::FindMembers): Implement support for
25114 DeclaredOnly/noDeclaredOnly flag.
25116 (Constructor::Emit) Return the ConstructorBuilder.
25118 (Method::Emit) Return the MethodBuilder.
25119 Check for abstract or virtual methods to be public.
25121 * rootcontext.cs (RootContext::CreateType): Register all the
25122 abstract methods required for the class to be complete and the
25123 interface methods that must be implemented.
25125 * cs-parser.jay: Report error 501 (method requires body if it is
25126 not marked abstract or extern).
25128 * expression.cs (TypeOf::Emit): Implement.
25130 * typemanager.cs: runtime_handle_type, new global type.
25132 * class.cs (Property::Emit): Generate code for properties.
25134 2001-10-02 Ravi Pratap <ravi@ximian.com>
25136 * expression.cs (Unary::ResolveOperator): Find operators on base type
25137 too - we now conform exactly to the spec.
25139 (Binary::ResolveOperator): Same here.
25141 * class.cs (Operator::Define): Fix minor quirk in the tests.
25143 * ../errors/cs0215.cs : Added.
25145 * ../errors/cs0556.cs : Added.
25147 * ../errors/cs0555.cs : Added.
25149 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25151 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
25152 single integer which is really efficient
25154 2001-10-01 Ravi Pratap <ravi@ximian.com>
25156 * expression.cs (Expression::ImplicitUserConversion): Use location
25157 even in the case when we are examining True operators.
25159 * class.cs (Operator::Define): Perform extensive checks to conform
25160 with the rules for operator overloading in the spec.
25162 * expression.cs (Expression::ImplicitReferenceConversion): Implement
25163 some of the other conversions mentioned in the spec.
25165 * typemanager.cs (array_type): New static member for the System.Array built-in
25168 (cloneable_interface): For System.ICloneable interface.
25170 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
25171 we start resolving the tree and populating types.
25173 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
25175 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25177 * expression.cs (Expression::ExprClassFromMemberInfo,
25178 Expression::Literalize): Create literal expressions from
25179 FieldInfos which are literals.
25181 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
25182 type casts, because they were wrong. The test suite in tests
25185 (ImplicitNumericConversion): ushort to ulong requires a widening
25188 Int32 constant to long requires widening cast as well.
25190 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
25191 for integers because the type on the stack is not i4.
25193 2001-09-30 Miguel de Icaza <miguel@ximian.com>
25195 * expression.cs (report118): require location argument.
25197 * parameter.cs: Do not dereference potential null value.
25199 * class.cs: Catch methods that lack the `new' keyword when
25200 overriding a name. Report warnings when `new' is used without
25201 anything being there to override.
25203 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
25205 * class.cs: Only add constructor to hashtable if it is non-null
25206 (as now constructors can fail on define).
25208 (TypeManager, Class, Struct): Take location arguments.
25210 Catch field instance initialization in structs as errors.
25212 accepting_filter: a new filter for FindMembers that is static so
25213 that we dont create an instance per invocation.
25215 (Constructor::Define): Catch errors where a struct constructor is
25218 * cs-parser.jay: Pass location information for various new
25221 * delegate.cs (Delegate): take a location argument.
25223 * driver.cs: Do not call EmitCode if there were problesm in the
25224 Definition of the types, as many Builders wont be there.
25226 * decl.cs (Decl::Decl): Require a location argument.
25228 * cs-tokenizer.cs: Handle properly hex constants that can not fit
25229 into integers, and find the most appropiate integer for it.
25231 * literal.cs: Implement ULongLiteral.
25233 * rootcontext.cs: Provide better information about the location of
25234 failure when CreateType fails.
25236 2001-09-29 Miguel de Icaza <miguel@ximian.com>
25238 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
25241 * expression.cs (Binary::CheckShiftArguments): Add missing type
25243 (Binary::ResolveOperator): Add type to the logical and and logical
25244 or, Bitwise And/Or and Exclusive Or code paths, it was missing
25247 (Binary::DoNumericPromotions): In the case where either argument
25248 is ulong (and most signed types combined with ulong cause an
25249 error) perform implicit integer constant conversions as well.
25251 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25253 * expression.cs (UserImplicitCast): Method should always be
25255 (Invocation::BetterConversion): Simplified test for IntLiteral.
25257 (Expression::ImplicitNumericConversion): Split this routine out.
25258 Put the code that performs implicit constant integer conversions
25261 (Expression::Resolve): Become a wrapper around DoResolve so we can
25262 check eclass and type being set after resolve.
25264 (Invocation::Badness): Remove this dead function
25266 (Binary::ResolveOperator): Do not compute the expensive argumnets
25267 unless we have a union for it.
25269 (Probe::Emit): Is needs to do an isinst and then
25270 compare against null.
25272 (::CanConvert): Added Location argument. If the Location argument
25273 is null (Location.Null), then we do not report errors. This is
25274 used by the `probe' mechanism of the Explicit conversion. We do
25275 not want to generate an error for something that the user
25276 explicitly requested to be casted. But the pipeline for an
25277 explicit cast first tests for potential implicit casts.
25279 So for now, if the Location is null, it means `Probe only' to
25280 avoid adding another argument. Might have to revise this
25283 (ClassCast): New class used to type cast objects into arbitrary
25284 classes (used in Explicit Reference Conversions).
25286 Implement `as' as well.
25288 Reverted all the patches from Ravi below: they were broken:
25290 * The use of `level' as a mechanism to stop recursive
25291 invocations is wrong. That was there just to catch the
25292 bug with a strack trace but not as a way of addressing
25295 To fix the problem we have to *understand* what is going
25296 on and the interactions and come up with a plan, not
25297 just get things going.
25299 * The use of the type conversion cache that I proposed
25300 last night had an open topic: How does this work across
25301 protection domains. A user defined conversion might not
25302 be public in the location where we are applying the
25303 conversion, a different conversion might be selected
25304 (ie, private A->B (better) but public B->A (worse),
25305 inside A, A->B applies, but outside it, B->A will
25308 * On top of that (ie, even if the above is solved),
25309 conversions in a cache need to be abstract. Ie, `To
25310 convert from an Int to a Short use an OpcodeCast', not
25311 `To convert from an Int to a Short use the OpcodeCast on
25312 the variable 5' (which is what this patch was doing).
25314 2001-09-28 Ravi Pratap <ravi@ximian.com>
25316 * expression.cs (Invocation::ConversionExists): Re-write to use
25317 the conversion cache
25319 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25320 cache all conversions done, not just user-defined ones.
25322 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25323 to determine if a conversion exists instead of acutually trying to
25324 perform the conversion. It's faster too.
25326 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25327 and only then attempt the implicit conversion.
25329 2001-09-28 Ravi Pratap <ravi@ximian.com>
25331 * expression.cs (ConvertImplicit): Use a cache for conversions
25332 already found. Check level of recursion and bail out if necessary.
25334 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25336 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25337 Export standard methods that we expect for string operations.
25339 * statement.cs (Block::UsageWarning): Track usage of variables and
25340 report the errors for not used variables.
25342 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25345 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25347 * codegen.cs: remove unnneded code
25349 * expression.cs: Removed BuiltinTypeAccess class
25351 Fix the order in which implicit conversions are
25354 The previous fixed dropped support for boxed conversions (adding a
25355 test to the test suite now)
25357 (UserImplicitCast::CanConvert): Remove test for source being null,
25358 that code is broken. We should not feed a null to begin with, if
25359 we do, then we should track the bug where the problem originates
25360 and not try to cover it up here.
25362 Return a resolved expression of type UserImplicitCast on success
25363 rather than true/false. Ravi: this is what I was talking about,
25364 the pattern is to use a static method as a "constructor" for
25367 Also, do not create arguments until the very last minute,
25368 otherwise we always create the arguments even for lookups that
25369 will never be performed.
25371 (UserImplicitCast::Resolve): Eliminate, objects of type
25372 UserImplicitCast are born in a fully resolved state.
25374 * typemanager.cs (InitCoreTypes): Init also value_type
25375 (System.ValueType).
25377 * expression.cs (Cast::Resolve): First resolve the child expression.
25379 (LValue): Add new method AddressOf to be used by
25382 Change the argument of Store to take an EmitContext instead of an
25383 ILGenerator, because things like FieldExpr need to be able to call
25384 their children expression to generate the instance code.
25386 (Expression::Error, Expression::Warning): Sugar functions for
25389 (Expression::MemberLookup): Accept a TypeContainer instead of a
25390 Report as the first argument.
25392 (Expression::ResolvePrimary): Killed. I still want to improve
25393 this as currently the code is just not right.
25395 (Expression::ResolveMemberAccess): Simplify, but it is still
25398 (Unary::Resolve): Catch errors in AddressOf operators.
25400 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25401 index to a byte for the short-version, or the compiler will choose
25402 the wrong Emit call, which generates the wrong data.
25404 (ParameterReference::Emit, ::Store): same.
25406 (FieldExpr::AddressOf): Implement.
25408 * typemanager.cs: TypeManager: made public variable instead of
25411 * driver.cs: document --fatal.
25413 * report.cs (ErrorMessage, WarningMessage): new names for the old
25414 Error and Warning classes.
25416 * cs-parser.jay (member_access): Turn built-in access to types
25417 into a normal simplename
25419 2001-09-27 Ravi Pratap <ravi@ximian.com>
25421 * expression.cs (Invocation::BetterConversion): Fix to cope
25422 with q being null, since this was introducing a bug.
25424 * expression.cs (ConvertImplicit): Do built-in conversions first.
25426 2001-09-27 Ravi Pratap <ravi@ximian.com>
25428 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25430 2001-09-27 Ravi Pratap <ravi@ximian.com>
25432 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25433 I had introduced long ago (what's new ?).
25435 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25436 the work of all the checking.
25437 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25438 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25440 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25441 that is the right way.
25443 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25444 overloading resolution. Use everywhere instead of cutting and pasting code.
25446 (Binary::ResolveOperator): Use MakeUnionSet.
25448 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25449 we have to convert to bool types. Not complete yet.
25451 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25453 * typemanager.cs (TypeManager::CSharpName): support ushort.
25455 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25456 to provide an expression that performsn an implicit constant int
25457 conversion (section 6.1.6).
25458 (Expression::ConvertImplicitRequired): Reworked to include
25459 implicit constant expression conversions.
25461 (Expression::ConvertNumericExplicit): Finished.
25463 (Invocation::Emit): If InstanceExpression is null, then it means
25464 that we perform a call on this.
25466 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25468 * expression.cs (Unary::Emit): Remove some dead code.
25469 (Probe): Implement Resolve and Emit for `is'.
25470 (Expression::ConvertImplicitRequired): Attempt to do constant
25471 expression conversions here. Maybe should be moved to
25472 ConvertImplicit, but I am not sure.
25473 (Expression::ImplicitLongConstantConversionPossible,
25474 Expression::ImplicitIntConstantConversionPossible): New functions
25475 that tell whether is it possible to apply an implicit constant
25476 expression conversion.
25478 (ConvertNumericExplicit): Started work on explicit numeric
25481 * cs-parser.jay: Update operator constants.
25483 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25484 (Parameters::GetSignature): Hook up VerifyArgs here.
25485 (Parameters::VerifyArgs): Verifies that no two arguments have the
25488 * class.cs (Operator): Update the operator names to reflect the
25489 ones that the spec expects (as we are just stringizing the
25492 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25493 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25494 previous usage did only work for our methods.
25495 (Expression::ConvertImplicit): Handle decimal implicit numeric
25496 conversions as well.
25497 (Expression::InternalTypeConstructor): Used to invoke constructors
25498 on internal types for default promotions.
25500 (Unary::Emit): Implement special handling for the pre/post
25501 increment/decrement for overloaded operators, as they need to have
25502 the same semantics as the other operators.
25504 (Binary::ResolveOperator): ditto.
25505 (Invocation::ConversionExists): ditto.
25506 (UserImplicitCast::Resolve): ditto.
25508 2001-09-26 Ravi Pratap <ravi@ximian.com>
25510 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25511 operator, return after emitting body. Regression tests pass again !
25513 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25514 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25515 (Invocation::OverloadResolve): Ditto.
25516 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25518 * everywhere : update calls to the above methods accordingly.
25520 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25522 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25524 * expression.cs (ExpressionStatement): New base class used for
25525 expressions that can appear in statements, so that we can provide
25526 an alternate path to generate expression that do not leave a value
25529 (Expression::Emit, and all the derivatives): We no longer return
25530 whether a value is left on the stack or not. Every expression
25531 after being emitted leaves a single value on the stack.
25533 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25534 facilties of ExpressionStatement if possible.
25536 * cs-parser.jay: Update statement_expression.
25538 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25540 * driver.cs: Change the wording of message
25542 2001-09-25 Ravi Pratap <ravi@ximian.com>
25544 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25545 the type of the expression to the return type of the method if
25546 we have an overloaded operator match ! The regression tests pass again !
25547 (Unary::ResolveOperator): Ditto.
25549 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25550 to find "op_Implicit", not "implicit" ;-)
25551 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25552 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25554 * everywhere : Correct calls to the above accordingly.
25556 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25557 (ConvertImplicit): Do user-defined conversion if it exists.
25559 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25561 * assign.cs: track location.
25562 (Resolve): Use implicit conversions on assignment.
25564 * literal.cs: Oops. Not good, Emit of short access values should
25565 pass (Bytes) or the wrong argument will be selected.
25567 * expression.cs (Unary::Emit): Emit code for -expr.
25569 (Unary::ResolveOperator): Handle `Substract' for non-constants
25570 (substract from zero from the non-constants).
25571 Deal with Doubles as well.
25573 (Expression::ConvertImplicitRequired): New routine that reports an
25574 error if no implicit conversion exists.
25576 (Invocation::OverloadResolve): Store the converted implicit
25577 expressions if we make them
25579 2001-09-24 Ravi Pratap <ravi@ximian.com>
25581 * class.cs (ConstructorInitializer): Take a Location argument.
25582 (ConstructorBaseInitializer): Same here.
25583 (ConstructorThisInitializer): Same here.
25585 * cs-parser.jay : Update all calls accordingly.
25587 * expression.cs (Unary, Binary, New): Take location argument.
25588 Update accordingly everywhere.
25590 * cs-parser.jay : Update all calls to the above to take a location
25593 * class.cs : Ditto.
25595 2001-09-24 Ravi Pratap <ravi@ximian.com>
25597 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25598 (Invocation::BetterConversion): Same here
25599 (Invocation::ConversionExists): Ditto.
25601 (Invocation::ConversionExists): Implement.
25603 2001-09-22 Ravi Pratap <ravi@ximian.com>
25605 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25606 Also take an additional TypeContainer argument.
25608 * All over : Pass in TypeContainer as argument to OverloadResolve.
25610 * typemanager.cs (CSharpName): Update to check for the string type and return
25613 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25616 2001-09-21 Ravi Pratap <ravi@ximian.com>
25618 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25619 (Invocation::BetterFunction): Implement.
25620 (Invocation::BetterConversion): Implement.
25621 (Invocation::ConversionExists): Skeleton, no implementation yet.
25623 Okay, things work fine !
25625 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25627 * typemanager.cs: declare and load enum_type, delegate_type and
25630 * expression.cs (Expression::Emit): Now emit returns a value that
25631 tells whether a value is left on the stack or not. This strategy
25632 might be reveted tomorrow with a mechanism that would address
25633 multiple assignments.
25634 (Expression::report118): Utility routine to report mismatches on
25637 (Unary::Report23): Report impossible type/operator combination
25640 (Unary::IsIncrementableNumber): Whether the type can be
25641 incremented or decremented with add.
25642 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25644 (Unary::ResolveOperator): Implement ++, !, ~,
25646 (Invocation::Emit): Deal with new Emit convetion.
25648 * All Expression derivatives: Updated their Emit method to return
25649 whether they leave values on the stack or not.
25651 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25652 stack for expressions that are statements.
25654 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25656 * expression.cs (LValue): New interface. Must be implemented by
25658 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25661 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25662 interface for generating code, simplifies the code.
25664 2001-09-20 Ravi Pratap <ravi@ximian.com>
25666 * expression.cs (everywhere): Comment out return statements in ::Resolve
25667 methods to avoid the warnings.
25669 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25671 * driver.cs (parse): Report error 2001 if we can not open the
25674 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25677 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25680 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25681 otherwise nested blocks end up with the same index.
25683 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25685 * expression.cs: Instead of having FIXMEs in the Resolve
25686 functions, throw exceptions so it is obvious that we are facing a
25689 * cs-parser.jay (invocation_expression): Pass Location information.
25691 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25692 Use a basename for those routines because .NET does not like paths
25695 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25698 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25700 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25701 are loading the correct data types (throws an exception if not).
25702 (TypeManager::InitCoreTypes): Use CoreLookupType
25704 * expression.cs (Unary::ResolveOperator): return the child
25705 expression for expressions which are just +expr.
25706 (Unary::ResolveOperator): Return negative literals for -LITERAL
25707 expressions (otherwise they are Unary {Literal}).
25708 (Invocation::Badness): Take into account `Implicit constant
25709 expression conversions'.
25711 * literal.cs (LongLiteral): Implement long literal class.
25712 (IntLiteral): export the `Value' of the intliteral.
25714 2001-09-19 Ravi Pratap <ravi@ximian.com>
25716 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25718 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25719 instead of 'Operator'
25721 * expression.cs (Binary::ResolveOperator): Update accordingly.
25722 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25725 * cs-parser.jay (unary_expression): Update to use the new names.
25727 * gen-treedump.cs (GetUnary): Same here.
25729 * expression.cs (Unary::Resolve): Implement.
25730 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25731 operators are found instead of making noise ;-)
25732 (Unary::ResolveOperator): New method to do precisely the same thing which
25733 Binary::ResolveOperator does for Binary expressions.
25734 (Unary.method, .Arguments): Add.
25735 (Unary::OperName): Implement.
25736 (Unary::ForceConversion): Copy and Paste !
25738 * class.cs (Operator::Define): Fix a small bug for the case when we have
25741 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25742 for the inbuilt operators. Only overloading works for now ;-)
25744 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25746 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25747 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25749 * expression.cs (This::Emit): Implement.
25750 (This::Resolve): Implement.
25751 (TypeOf:Resolve): Implement.
25752 (Expression::ResolveSimpleName): Add an implicit this to instance
25754 (MemberAccess::Resolve): Deal with Parameters and Fields.
25755 Bind instance variable to Field expressions.
25756 (FieldExpr::Instance): New field used to track the expression that
25757 represents the object instance.
25758 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25760 (FieldExpr::Emit): Implement.
25762 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25763 the last instruction contains a return opcode to avoid generating
25764 the last `ret' instruction (this generates correct code, and it is
25765 nice to pass the peverify output).
25767 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25768 initializer for static and instance variables.
25769 (Constructor::Emit): Allow initializer to be null in the case of
25770 static constructors. Only emit initializer for instance
25773 (TypeContainer::FindMembers): Return a null array if there are no
25776 Also fix the code for the MemberTypes.Method branch, as it was not
25777 scanning that for operators (or tried to access null variables before).
25779 * assign.cs (Assign::Emit): Handle instance and static fields.
25783 * driver.cs: Stop compilation if there are parse errors.
25785 * cs-parser.jay (constructor_declaration): Provide default base
25786 initializer for non-static constructors.
25787 (constructor_declarator): Do not provide a default base
25788 initializers if none was specified.
25789 Catch the fact that constructors should not have parameters.
25791 * class.cs: Do not emit parent class initializers for static
25792 constructors, that should be flagged as an error.
25794 2001-09-18 Ravi Pratap <ravi@ximian.com>
25796 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25797 Move back code into TypeContainer::Populate.
25799 2001-09-18 Ravi Pratap <ravi@ximian.com>
25801 * class.cs (TypeContainer::AddConstructor): Fix the check to
25802 compare against Name, not Basename.
25803 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25805 * cs-parser.jay : Update accordingly.
25807 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25808 for methods, don't forget to look into the operators too.
25809 (RegisterMethodBuilder): Helper method to take care of this for
25810 methods, constructors and operators.
25811 (Operator::Define): Completely revamp.
25812 (Operator.OperatorMethod, MethodName): New fields.
25813 (TypeContainer::Populate): Move the registering of builders into
25814 RegisterMethodBuilder.
25815 (Operator::Emit): Re-write.
25817 * expression.cs (Binary::Emit): Comment out code path to emit method
25818 invocation stuff for the case when we have a user defined operator. I am
25819 just not able to get it right !
25821 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25823 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25826 (Expression::MemberLookup): Provide a version that allows to
25827 specify the MemberTypes and BindingFlags.
25829 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25830 so it was not fetching variable information from outer blocks.
25832 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25833 Beforefieldinit as it was buggy.
25835 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25836 that Ravi put here.
25838 * class.cs (Constructor::Emit): Only emit if block is not null.
25839 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25840 deal with this by semantically definining it as if the user had
25843 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25844 constructors as we now "emit" them at a higher level.
25846 (TypeContainer::DefineDefaultConstructor): Used to define the
25847 default constructors if none was provided.
25849 (ConstructorInitializer): Add methods Resolve and Emit.
25851 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25853 2001-09-17 Ravi Pratap <ravi@ximian.com>
25855 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25856 the default constructor builder with our hashtable for methodbuilders
25859 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25860 and argument_count is 0 in which case we have a match.
25861 (Binary::ResolveOperator): More null checking and miscellaneous coding
25864 2001-09-17 Ravi Pratap <ravi@ximian.com>
25866 * rootcontext.cs (IsNameSpace): Compare against null.
25868 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25870 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25871 and Unary::Operator.
25873 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25876 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25877 we have overloaded operators.
25878 (Binary::ResolveOperator): Implement the part which does the operator overload
25881 * class.cs (Operator::Emit): Implement.
25882 (TypeContainer::Emit): Emit the operators we have too.
25884 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25885 the case when we have a user-defined operator.
25887 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25889 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
25891 2001-09-16 Ravi Pratap <ravi@ximian.com>
25893 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
25894 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
25895 (Constructor::Emit): Implement.
25896 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
25897 if we have no work to do.
25898 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
25901 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
25902 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
25904 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
25907 2001-09-15 Ravi Pratap <ravi@ximian.com>
25909 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
25911 (Tree::RecordNamespace): Method to do what the name says ;-)
25912 (Tree::Namespaces): Property to get at the namespaces hashtable.
25914 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
25917 * rootcontext.cs (IsNamespace): Fixed it :-)
25919 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25921 * class.cs (TypeContainer::FindMembers): Add support for
25923 (MethodCore): New class that encapsulates both the shared aspects
25924 of a Constructor and a Method.
25925 (Method, Constructor): Factored pieces into MethodCore.
25927 * driver.cs: Added --fatal which makes errors throw exceptions.
25928 Load System assembly as well as part of the standard library.
25930 * report.cs: Allow throwing exceptions on errors for debugging.
25932 * modifiers.cs: Do not use `parent', instead use the real type
25933 container to evaluate permission settings.
25935 * class.cs: Put Ravi's patch back in. He is right, and we will
25936 have to cope with the
25938 2001-09-14 Ravi Pratap <ravi@ximian.com>
25940 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
25941 FamORAssem, not FamANDAssem.
25943 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25945 * driver.cs: Added --parse option that only parses its input files
25948 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
25949 incorrect. IsTopLevel is not used to tell whether an object is
25950 root_types or not (that can be achieved by testing this ==
25951 root_types). But to see if this is a top-level *class* (not
25952 necessarly our "toplevel" container).
25954 2001-09-14 Ravi Pratap <ravi@ximian.com>
25956 * enum.cs (Enum::Define): Modify to call the Lookup method on the
25957 parent instead of a direct call to GetType.
25959 2001-09-14 Ravi Pratap <ravi@ximian.com>
25961 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
25962 Modifiers.TypeAttr. This should just be a call to that method.
25964 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
25965 object so that we can determine if we are top-level or not.
25967 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
25970 * enum.cs (Enum::Define): Ditto.
25972 * modifiers.cs (FieldAttr): Re-write.
25974 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
25975 (TypeContainer::HaveStaticConstructor): New property to provide access
25976 to precisely that info.
25978 * modifiers.cs (MethodAttr): Re-write.
25979 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
25981 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
25982 of top-level types as claimed.
25984 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25986 * expression.cs (MemberLookup): Fruitless attempt to lookup
25987 constructors. Maybe I need to emit default constructors? That
25988 might be it (currently .NET emits this for me automatically).
25989 (Invocation::OverloadResolve): Cope with Arguments == null.
25990 (Invocation::EmitArguments): new function, shared by the new
25991 constructor and us.
25992 (Invocation::Emit): Handle static and instance methods. Emit
25993 proper call instruction for virtual or non-virtual invocations.
25994 (New::Emit): Implement.
25995 (New::Resolve): Implement.
25996 (MemberAccess:Resolve): Implement.
25997 (MethodGroupExpr::InstanceExpression): used conforming to the spec
25998 to track instances.
25999 (FieldExpr::Resolve): Set type.
26001 * support.cs: Handle empty arguments.
26003 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
26004 SimpleLookup): Auxiliary routines to help parse a qualifier
26007 Update qualifier_identifier rule.
26009 * codegen.cs: Removed debugging messages.
26011 * class.cs: Make this a global thing, this acts just as a "key" to
26012 objects that we might have around.
26014 (Populate): Only initialize method_builders_to_methods once.
26016 * expression.cs (PropertyExpr): Initialize type from the
26019 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
26020 Resolve pattern. Attempt to implicitly convert value to boolean.
26023 * expression.cs: Set the type for the int32/int32 argument case.
26024 (Binary::ResolveOperator): Set the return type to boolean for
26025 comparission operators
26027 * typemanager.cs: Remove debugging print code.
26029 (Invocation::Resolve): resolve type.
26031 * class.cs: Allocate a MemberInfo of the correct size, as the code
26032 elsewhere depends on the test to reflect the correct contents.
26034 (Method::) Keep track of parameters, due to System.Reflection holes
26036 (TypeContainer::Populate): Keep track of MethodBuilders to Method
26039 (TypeContainer::FindMembers): Use ArrayList and then copy an array
26040 of the exact size and return that.
26042 (Class::LookupMethodByBuilder): New function that maps
26043 MethodBuilders to its methods. Required to locate the information
26044 on methods because System.Reflection bit us again.
26046 * support.cs: New file, contains an interface ParameterData and
26047 two implementations: ReflectionParameters and InternalParameters
26048 used to access Parameter information. We will need to grow this
26051 * expression.cs (Invocation::GetParameterData): implement a cache
26052 and a wrapper around the ParameterData creation for methods.
26053 (Invocation::OverloadResolve): Use new code.
26055 2001-09-13 Ravi Pratap <ravi@ximian.com>
26057 * class.cs (TypeContainer::EmitField): Remove and move into
26058 (Field::Define): here and modify accordingly.
26059 (Field.FieldBuilder): New member.
26060 (TypeContainer::Populate): Update accordingly.
26061 (TypeContainer::FindMembers): Implement.
26063 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26065 * statement.cs: (VariableInfo::VariableType): New field to be
26066 initialized with the full type once it is resolved.
26068 2001-09-12 Miguel de Icaza <miguel@ximian.com>
26070 * parameter.cs (GetParameterInfo): Use a type cache to compute
26071 things only once, and to reuse this information
26073 * expression.cs (LocalVariableReference::Emit): Implement.
26074 (OpcodeCast::Emit): fix.
26076 (ParameterReference::Resolve): Implement.
26077 (ParameterReference::Emit): Implement.
26079 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
26080 that are expressions need to stay as Expressions.
26082 * typemanager.cs (CSharpName): Returns the C# name of a type if
26085 * expression.cs (Expression::ConvertImplicit): New function that
26086 implements implicit type conversions.
26088 (Expression::ImplicitReferenceConversion): Implements implicit
26089 reference conversions.
26091 (EmptyCast): New type for transparent casts.
26093 (OpcodeCast): New type for casts of types that are performed with
26094 a sequence of bytecodes.
26096 (BoxedCast): New type used for casting value types into reference
26097 types. Emits a box opcode.
26099 (Binary::DoNumericPromotions): Implements numeric promotions of
26100 and computation of the Binary::Type.
26102 (Binary::EmitBranchable): Optimization.
26104 (Binary::Emit): Implement code emission for expressions.
26106 * typemanager.cs (TypeManager): Added two new core types: sbyte
26109 2001-09-12 Ravi Pratap <ravi@ximian.com>
26111 * class.cs (TypeContainer::FindMembers): Method which does exactly
26112 what Type.FindMembers does, only we don't have to use reflection. No
26113 implementation yet.
26115 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
26116 typecontainer objects as we need to get at them.
26117 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
26119 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
26120 typecontainer object.
26122 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
26123 of just a Report object.
26125 2001-09-11 Ravi Pratap <ravi@ximian.com>
26127 * class.cs (Event::Define): Go back to using the prefixes "add_" and
26129 (TypeContainer::Populate): Now define the delegates of the type too.
26130 (TypeContainer.Delegates): Property to access the list of delegates defined
26133 * delegates.cs (Delegate::Define): Implement partially.
26135 * modifiers.cs (TypeAttr): Handle more flags.
26137 2001-09-11 Ravi Pratap <ravi@ximian.com>
26139 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
26141 (Operator::Define): Re-write logic to get types by using the LookupType method
26142 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
26143 (Indexer::Define): Ditto.
26144 (Event::Define): Ditto.
26145 (Property::Define): Ditto.
26147 2001-09-10 Ravi Pratap <ravi@ximian.com>
26149 * class.cs (TypeContainer::Populate): Now define operators too.
26150 (TypeContainer.Operators): New property to access the list of operators
26152 (Operator.OperatorMethodBuilder): New member to hold the method builder
26153 for the operator we are defining.
26154 (Operator::Define): Implement.
26156 2001-09-10 Ravi Pratap <ravi@ximian.com>
26158 * class.cs (Event::Define): Make the prefixes of the accessor methods
26159 addOn_ and removeOn_
26161 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
26162 of the location being passed in too. Ideally, this should go later since all
26163 error reporting should be done through the Report object.
26165 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
26166 (Populate): Iterate thru the indexers we have and define them too.
26167 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
26168 for the get and set accessors.
26169 (Indexer::Define): Implement.
26171 2001-09-09 Miguel de Icaza <miguel@ximian.com>
26173 * expression.cs (Binary::Resolve): Beginning of it. I scratched
26174 my previous implementation, did not work.
26176 * typemanager.cs: Add a couple of missing types (the longs).
26178 * literal.cs: Use TypeManager.bool_type instead of getting it.
26180 * expression.cs (EventExpr): New kind of expressions.
26181 (Expressio::ExprClassFromMemberInfo): finish
26183 2001-09-08 Miguel de Icaza <miguel@ximian.com>
26185 * assign.cs: Emit stores to static fields differently.
26187 2001-09-08 Ravi Pratap <ravi@ximian.com>
26189 * Merge in changes and adjust code to tackle conflicts. Backed out my
26190 code in Assign::Resolve ;-)
26192 2001-09-08 Ravi Pratap <ravi@ximian.com>
26194 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
26195 instead Report.Error and also pass in the location.
26196 (CSharpParser::Lexer): New readonly property to return the reference
26197 to the Tokenizer object.
26198 (declare_local_variables): Use Report.Error with location instead of plain
26202 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
26203 (Operator.CheckBinaryOperator): Ditto.
26205 * cs-parser.jay (operator_declarator): Update accordingly.
26207 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
26208 (CheckBinaryOperator): Same here.
26210 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
26211 on the name without any prefixes of namespace names etc. This is because we
26212 already might have something already fully qualified like
26213 'System.Console.WriteLine'
26215 * assign.cs (Resolve): Begin implementation. Stuck ;-)
26217 2001-09-07 Ravi Pratap <ravi@ximian.com>
26219 * cs-tokenizer.cs (location): Return a string which also contains
26222 * expression.cs (ElementAccess): New class for expressions of the
26223 type 'element access.'
26224 (BaseAccess): New class for expressions of the type 'base access.'
26225 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
26228 * cs-parser.jay (element_access): Implement action.
26229 (base_access): Implement actions.
26230 (checked_expression, unchecked_expression): Implement.
26232 * cs-parser.jay (local_variable_type): Correct and implement.
26233 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
26235 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
26237 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
26238 name and the specifiers.
26240 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
26242 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
26243 making them all public ;-)
26245 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
26248 2001-09-07 Miguel de Icaza <miguel@ximian.com>
26250 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
26252 (FieldExpr, PropertyExprs): New resolved expressions.
26253 (SimpleName::MemberStaticCheck): Perform static checks for access
26254 to non-static fields on static methods. Maybe this should be
26255 generalized for MemberAccesses.
26256 (SimpleName::ResolveSimpleName): More work on simple name
26259 * cs-parser.jay (primary_expression/qualified_identifier): track
26260 the parameter index.
26262 * codegen.cs (CodeGen::Save): Catch save exception, report error.
26263 (EmitContext::EmitBoolExpression): Chain to expression generation
26264 instead of temporary hack.
26265 (::EmitStatementExpression): Put generic expression code generation.
26267 * assign.cs (Assign::Emit): Implement variable assignments to
26268 local variables, parameters and fields.
26270 2001-09-06 Miguel de Icaza <miguel@ximian.com>
26272 * statement.cs (Block::GetVariableInfo): New method, returns the
26273 VariableInfo for a variable name in a block.
26274 (Block::GetVariableType): Implement in terms of GetVariableInfo
26276 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26277 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26279 2001-09-06 Ravi Pratap <ravi@ximian.com>
26281 * cs-parser.jay (operator_declaration): Continue on my quest : update
26282 to take attributes argument.
26283 (event_declaration): Ditto.
26284 (enum_declaration): Ditto.
26285 (indexer_declaration): Ditto.
26287 * class.cs (Operator::Operator): Update constructor accordingly.
26288 (Event::Event): Ditto.
26290 * delegate.cs (Delegate::Delegate): Same here.
26292 * enum.cs (Enum::Enum): Same here.
26294 2001-09-05 Ravi Pratap <ravi@ximian.com>
26296 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26298 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26300 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26301 being passed around as an arraylist.
26302 (Attributes::AddAttribute): Method to add attribute sections.
26304 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26305 (struct_declaration): Update accordingly.
26306 (constant_declaration): Update.
26307 (field_declaration): Update.
26308 (method_header): Update.
26309 (fixed_parameter): Update.
26310 (parameter_array): Ditto.
26311 (property_declaration): Ditto.
26312 (destructor_declaration): Ditto.
26314 * class.cs (Struct::Struct): Update constructors accordingly.
26315 (Class::Class): Ditto.
26316 (Field::Field): Ditto.
26317 (Method::Method): Ditto.
26318 (Property::Property): Ditto.
26319 (TypeContainer::OptAttribute): update property's return type.
26321 * interface.cs (Interface.opt_attributes): New member.
26322 (Interface::Interface): Update to take the extra Attributes argument.
26324 * parameter.cs (Parameter::Parameter): Ditto.
26326 * constant.cs (Constant::Constant): Ditto.
26328 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26329 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26330 the attributes as a parameter.
26331 (InterfaceProperty): Update constructor call.
26332 (InterfaceEvent): Ditto.
26333 (InterfaceMethod): Ditto.
26334 (InterfaceIndexer): Ditto.
26336 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26337 pass the attributes too.
26338 (interface_event_declaration): Ditto.
26339 (interface_property_declaration): Ditto.
26340 (interface_method_declaration): Ditto.
26341 (interface_declaration): Ditto.
26343 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26345 * class.cs (Method::Define): Track the "static Main" definition to
26346 create an entry point.
26348 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26349 EntryPoint if we find it.
26351 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26352 (EmitContext::ig): Make this variable public.
26354 * driver.cs: Make the default output file be the first file name
26355 with the .exe extension.
26357 Detect empty compilations
26359 Handle various kinds of output targets. Handle --target and
26360 rename -t to --dumper.
26362 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26363 methods inherited from Expression return now an Expression. This
26364 will is used during the tree rewriting as we resolve them during
26367 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26368 the spec. Missing entirely is the information about
26369 accessability of elements of it.
26371 (Expression::ExprClassFromMemberInfo): New constructor for
26372 Expressions that creates a fully initialized Expression based on
26373 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26376 (Invocation::Resolve): Begin implementing resolution of invocations.
26378 * literal.cs (StringLiteral): Implement Emit.
26380 2001-09-05 Ravi Pratap <ravi@ximian.com>
26382 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26385 2001-09-04 Ravi Pratap <ravi@ximian.com>
26387 * cs-parser.jay (attribute_arguments): Implement actions.
26388 (attribute): Fix bug in production. Implement action.
26389 (attribute_list): Implement.
26390 (attribute_target): Implement.
26391 (attribute_target_specifier, opt_target_specifier): Implement
26392 (CheckAttributeTarget): New method to check if the attribute target
26394 (attribute_section): Implement.
26395 (opt_attributes): Implement.
26397 * attribute.cs : New file to handle attributes.
26398 (Attribute): Class to hold attribute info.
26400 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26401 (attribute_section): Modify production to use 2 different rules to
26402 achieve the same thing. 1 s/r conflict down !
26403 Clean out commented, useless, non-reducing dimension_separator rules.
26405 * class.cs (TypeContainer.attributes): New member to hold list
26406 of attributes for a type.
26407 (Struct::Struct): Modify to take one more argument, the attribute list.
26408 (Class::Class): Ditto.
26409 (Field::Field): Ditto.
26410 (Method::Method): Ditto.
26411 (Property::Property): Ditto.
26413 * cs-parser.jay (struct_declaration): Update constructor call to
26414 pass in the attributes too.
26415 (class_declaration): Ditto.
26416 (constant_declaration): Ditto.
26417 (field_declaration): Ditto.
26418 (method_header): Ditto.
26419 (fixed_parameter): Ditto.
26420 (parameter_array): Ditto.
26421 (property_declaration): Ditto.
26423 * constant.cs (Constant::Constant): Update constructor similarly.
26424 Use System.Collections.
26426 * parameter.cs (Parameter::Parameter): Update as above.
26428 2001-09-02 Ravi Pratap <ravi@ximian.com>
26430 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26431 (TypeContainer.delegates): New member to hold list of delegates.
26433 * cs-parser.jay (delegate_declaration): Implement the action correctly
26434 this time as I seem to be on crack ;-)
26436 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26438 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26439 tell whether an identifier represents a namespace.
26441 * expression.cs (NamespaceExpr): A namespace expression, used only
26442 temporarly during expression resolution.
26443 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26444 utility functions to resolve names on expressions.
26446 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26448 * codegen.cs: Add hook for StatementExpressions.
26450 * class.cs: Fix inverted test for static flag in methods.
26452 2001-09-02 Ravi Pratap <ravi@ximian.com>
26454 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26455 to make it coincide with MS' number.
26456 (Operator::CheckBinaryOperator): Ditto.
26458 * ../errors/errors.txt : Remove error numbers added earlier.
26460 * ../errors/cs1019.cs : Test case for error # 1019
26462 * ../errros/cs1020.cs : Test case for error # 1020
26464 * cs-parser.jay : Clean out commented cruft.
26465 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26466 used anywhere - non-reducing rule.
26467 (namespace_declarations): Non-reducing rule - comment out.
26469 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26470 with TypeContainer::AddEnum.
26472 * delegate.cs : New file for delegate handling classes.
26473 (Delegate): Class for declaring delegates.
26475 * makefile : Update.
26477 * cs-parser.jay (delegate_declaration): Implement.
26479 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26481 * class.cs (Event::Define): Implement.
26482 (Event.EventBuilder): New member.
26484 * class.cs (TypeContainer::Populate): Update to define all enums and events
26486 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26487 readonly fields for all these cases ?
26489 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26491 * class.cs (Property): Revamp to use the convention of making fields readonly.
26492 Accordingly modify code elsewhere.
26494 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26495 the Define method of the Property class.
26497 * class.cs : Clean up applied patch and update references to variables etc. Fix
26499 (TypeContainer::Populate): Update to define all the properties we have. Also
26500 define all enumerations.
26502 * enum.cs (Define): Implement.
26504 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26506 * cs-parser.jay (overloadable_operator): The semantic value is an
26507 enum of the Operator class.
26508 (operator_declarator): Implement actions.
26509 (operator_declaration): Implement.
26511 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26512 validity of definitions.
26513 (Operator::CheckBinaryOperator): Static method to check for binary operators
26514 (TypeContainer::AddOperator): New method to add an operator to a type.
26516 * cs-parser.jay (indexer_declaration): Added line to actually call the
26517 AddIndexer method so it gets added ;-)
26519 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26520 already taken care of by the MS compiler ?
26522 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26524 * class.cs (Operator): New class for operator declarations.
26525 (Operator::OpType): Enum for the various operators.
26527 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26529 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26530 ostensibly handle this in semantic analysis.
26532 * cs-parser.jay (general_catch_clause): Comment out
26533 (specific_catch_clauses, specific_catch_clause): Ditto.
26534 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26535 (catch_args, opt_catch_args): New productions.
26536 (catch_clause): Rewrite to use the new productions above
26537 (catch_clauses): Modify accordingly.
26538 (opt_catch_clauses): New production to use in try_statement
26539 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26540 and re-write the code in the actions to extract the specific and
26541 general catch clauses by being a little smart ;-)
26543 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26544 Hooray, try and catch statements parse fine !
26546 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26548 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26549 string from the hashtable of variables.
26551 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26552 I end up making that mistake ;-)
26553 (catch_clauses): Fixed gross error which made Key and Value of the
26554 DictionaryEntry the same : $1 !!
26556 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26558 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26560 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26561 when the add and remove accessors are specified.
26563 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26565 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26566 information about indexer_declarator.
26567 (indexer_declarator): Implement actions.
26568 (parsing_indexer): New local boolean used to keep track of whether
26569 we are parsing indexers or properties. This is necessary because
26570 implicit_parameters come into picture even for the get accessor in the
26571 case of an indexer.
26572 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26574 * class.cs (Indexer): New class for indexer declarations.
26575 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26576 (TypeContainer::indexers): New member to hold list of indexers for the
26579 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26581 * cs-parser.jay (add_accessor_declaration): Implement action.
26582 (remove_accessor_declaration): Implement action.
26583 (event_accessors_declaration): Implement
26584 (variable_declarators): swap statements for first rule - trivial.
26586 * class.cs (Event): New class to hold information about event
26588 (TypeContainer::AddEvent): New method to add an event to a type
26589 (TypeContainer::events): New member to hold list of events.
26591 * cs-parser.jay (event_declaration): Implement actions.
26593 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26595 * cs-parser.jay (dim_separators): Implement. Make it a string
26596 concatenating all the commas together, just as they appear.
26597 (opt_dim_separators): Modify accordingly
26598 (rank_specifiers): Update accordingly. Basically do the same
26599 thing - instead, collect the brackets here.
26600 (opt_rank_sepcifiers): Modify accordingly.
26601 (array_type): Modify to actually return the complete type string
26602 instead of ignoring the rank_specifiers.
26603 (expression_list): Implement to collect the expressions
26604 (variable_initializer): Implement. We make it a list of expressions
26605 essentially so that we can handle the array_initializer case neatly too.
26606 (variable_initializer_list): Implement.
26607 (array_initializer): Make it a list of variable_initializers
26608 (opt_array_initializer): Modify accordingly.
26610 * expression.cs (New::NType): Add enumeration to help us
26611 keep track of whether we have an object/delegate creation
26612 or an array creation.
26613 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26614 members to hold data about array creation.
26615 (New:New): Modify to update NewType
26616 (New:New): New Overloaded contructor for the array creation
26619 * cs-parser.jay (array_creation_expression): Implement to call
26620 the overloaded New constructor.
26622 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26624 * class.cs (TypeContainer::Constructors): Return member
26625 constructors instead of returning null.
26627 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26629 * typemanager.cs (InitCoreTypes): Initialize the various core
26630 types after we have populated the type manager with the user
26631 defined types (this distinction will be important later while
26632 compiling corlib.dll)
26634 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26635 on Expression Classification. Now all expressions have a method
26636 `Resolve' and a method `Emit'.
26638 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26639 generation from working. Also add some temporary debugging
26642 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26644 * codegen.cs: Lots of code generation pieces. This is only the
26645 beginning, will continue tomorrow with more touches of polish. We
26646 handle the fundamentals of if, while, do, for, return. Others are
26647 trickier and I need to start working on invocations soon.
26649 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26652 * codegen.cs (EmitContext): New struct, used during code
26653 emission to keep a context. Most of the code generation will be
26656 * cs-parser.jay: Add embedded blocks to the list of statements of
26657 this block. So code generation proceeds in a top down fashion.
26659 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26661 * statement.cs: Add support for multiple child blocks.
26663 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26665 * codegen.cs (EmitCode): New function, will emit the code for a
26666 Block of code given a TypeContainer and its ILGenerator.
26668 * statement.cs (Block): Standard public readonly optimization.
26669 (Block::Block constructors): Link children.
26670 (Block::Child): Child Linker.
26671 (Block::EmitVariables): Emits IL variable declarations.
26673 * class.cs: Drop support for MethodGroups here, delay until
26675 (Method::): Applied the same simplification that I did before, and
26676 move from Properties to public readonly fields.
26677 (Method::ParameterTypes): Returns the parameter types for the
26678 function, and implements a cache that will be useful later when I
26679 do error checking and the semantic analysis on the methods is
26681 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26682 and made a method, optional argument tells whether this is a class
26683 or a structure to apply the `has-this' bit.
26684 (Method::GetCallingConvention): Implement, returns the calling
26686 (Method::Define): Defines the type, a second pass is performed
26687 later to populate the methods.
26689 (Constructor::ParameterTypes): implement a cache similar to the
26690 one on Method::ParameterTypes, useful later when we do semantic
26693 (TypeContainer::EmitMethod): New method. Emits methods.
26695 * expression.cs: Removed MethodGroup class from here.
26697 * parameter.cs (Parameters::GetCallingConvention): new method.
26699 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26701 * class.cs (TypeContainer::Populate): Drop RootContext from the
26704 (Constructor::CallingConvention): Returns the calling convention.
26705 (Constructor::ParameterTypes): Returns the constructor parameter
26708 (TypeContainer::AddConstructor): Keep track of default constructor
26709 and the default static constructor.
26711 (Constructor::) Another class that starts using `public readonly'
26712 instead of properties.
26714 (Constructor::IsDefault): Whether this is a default constructor.
26716 (Field::) use readonly public fields instead of properties also.
26718 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26719 track of static constructors; If none is used, turn on
26720 BeforeFieldInit in the TypeAttributes.
26722 * cs-parser.jay (opt_argument_list): now the return can be null
26723 for the cases where there are no arguments.
26725 (constructor_declarator): If there is no implicit `base' or
26726 `this', then invoke the default parent constructor.
26728 * modifiers.cs (MethodAttr): New static function maps a set of
26729 modifiers flags into a MethodAttributes enum
26730 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26731 MethodAttr, TypeAttr to represent the various mappings where the
26732 modifiers are used.
26733 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26735 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26737 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26740 * interface.cs (PopulateIndexer): Implemented the code generator
26741 for interface indexers.
26743 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26745 * interface.cs (InterfaceMemberBase): Now we track the new status
26748 (PopulateProperty): Implement property population. Woohoo! Got
26749 Methods and Properties going today.
26751 Removed all the properties for interfaces, and replaced them with
26752 `public readonly' fields.
26754 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26756 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26757 initialize their hashtables/arraylists only when they are needed
26758 instead of doing this always.
26760 * parameter.cs: Handle refs and out parameters.
26762 * cs-parser.jay: Use an ArrayList to construct the arguments
26763 instead of the ParameterCollection, and then cast that to a
26766 * parameter.cs: Drop the use of ParameterCollection and use
26767 instead arrays of Parameters.
26769 (GetParameterInfo): Use the Type, not the Name when resolving
26772 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26774 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26775 and instead use public readonly fields.
26777 * class.cs: Put back walking code for type containers.
26779 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26781 * class.cs (MakeConstant): Code to define constants.
26783 * rootcontext.cs (LookupType): New function. Used to locate types
26786 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26788 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26789 this System.Reflection code is. Kudos to Microsoft
26791 * typemanager.cs: Implement a type cache and avoid loading all
26792 types at boot time. Wrap in LookupType the internals. This made
26793 the compiler so much faster. Wow. I rule!
26795 * driver.cs: Make sure we always load mscorlib first (for
26796 debugging purposes, nothing really important).
26798 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26799 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26801 * rootcontext.cs: Lookup types on their namespace; Lookup types
26802 on namespaces that have been imported using the `using' keyword.
26804 * class.cs (TypeContainer::TypeAttr): Virtualize.
26805 (Class::TypeAttr): Return attributes suitable for this bad boy.
26806 (Struct::TypeAttr): ditto.
26807 Handle nested classes.
26808 (TypeContainer::) Remove all the type visiting code, it is now
26809 replaced with the rootcontext.cs code
26811 * rootcontext.cs (GetClassBases): Added support for structs.
26813 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26815 * interface.cs, statement.cs, class.cs, parameter.cs,
26816 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26817 Drop use of TypeRefs, and use strings instead.
26819 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26823 * class.cs (Struct::Struct): set the SEALED flags after
26824 checking the modifiers.
26825 (TypeContainer::TypeAttr): new property, returns the
26826 TypeAttributes for a class.
26828 * cs-parser.jay (type_list): Oops, list production was creating a
26829 new list of base types.
26831 * rootcontext.cs (StdLib): New property.
26832 (GetInterfaceTypeByName): returns an interface by type name, and
26833 encapsulates error handling here.
26834 (GetInterfaces): simplified.
26835 (ResolveTree): Encapsulated all the tree resolution here.
26836 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26839 * driver.cs: Add support for --nostdlib, to avoid loading the
26840 default assemblies.
26841 (Main): Do not put tree resolution here.
26843 * rootcontext.cs: Beginning of the class resolution.
26845 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26847 * rootcontext.cs: Provide better error reporting.
26849 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26851 * rootcontext.cs (CreateInterface): Handle the case where there
26852 are no parent interfaces.
26854 (CloseTypes): Routine to flush types at the end.
26855 (CreateInterface): Track types.
26856 (GetInterfaces): Returns an array of Types from the list of
26857 defined interfaces.
26859 * typemanager.c (AddUserType): Mechanism to track user types (puts
26860 the type on the global type hash, and allows us to close it at the
26863 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26865 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26866 RecordInterface instead.
26868 * cs-parser.jay: Updated to reflect changes above.
26870 * decl.cs (Definition): Keep track of the TypeBuilder type that
26871 represents this type here. Not sure we will use it in the long
26872 run, but wont hurt for now.
26874 * driver.cs: Smaller changes to accomodate the new code.
26876 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26879 * rootcontext.cs (CreateInterface): New method, used to create
26880 the System.TypeBuilder type for interfaces.
26881 (ResolveInterfaces): new entry point to resolve the interface
26883 (CodeGen): Property, used to keep track of the code generator.
26885 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26887 * cs-parser.jay: Add a second production for delegate_declaration
26890 (enum_body): Put an opt_comma here instead of putting it on
26891 enum_body or enum_member_declarations so we can handle trailing
26892 commas on enumeration members. Gets rid of a shift/reduce.
26894 (type_list): Need a COMMA in the middle.
26896 (indexer_declaration): Tell tokenizer to recognize get/set
26898 * Remove old targets.
26900 * Re-add the parser target.
26902 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26904 * cs-parser.jay: Add precendence rules for a number of operators
26905 ot reduce the number of shift/reduce conflicts in the grammar.
26907 2001-07-17 Miguel de Icaza <miguel@ximian.com>
26909 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
26912 Get rid of old crufty code.
26914 * rootcontext.cs: Use this to keep track of the parsed
26915 representation and the defined types available to the program.
26917 * gen-treedump.cs: adjust for new convention.
26919 * type.cs: Split out the type manager, and the assembly builder
26922 * typemanager.cs: the type manager will live here now.
26924 * cil-codegen.cs: And the code generator here.
26926 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
26928 * makefile: Fixed up for easy making.
26930 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26932 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
26935 (unary_expression): Expand pre_increment_expression and
26936 post_decrement_expression to reduce a shift/reduce.
26938 2001-07-11 Simon Cozens
26940 * cs-tokenizer.cs: Hex numbers should begin with a 0.
26942 Improve allow_keyword_as_indent name.
26944 2001-06-19 Miguel de Icaza <miguel@ximian.com>
26946 * Adjustments for Beta2.
26948 2001-06-13 Miguel de Icaza <miguel@ximian.com>
26950 * decl.cs: Added `Define' abstract method.
26951 (InTransit): new property, used to catch recursive definitions.
26953 * interface.cs: Implement `Define'.
26955 * modifiers.cs: Map Modifiers.constants to
26956 System.Reflection.TypeAttribute flags.
26958 * class.cs: Keep track of types and user-defined types.
26959 (BuilderInit): New method for creating an assembly
26960 (ResolveType): New function to launch the resolution process, only
26961 used by interfaces for now.
26963 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
26964 that are inserted into the name space.
26966 2001-06-08 Miguel de Icaza <miguel@ximian.com>
26968 * ARGH. I have screwed up my tree so many times due to the use of
26969 rsync rather than using CVS. Going to fix this at once.
26971 * driver.cs: Objetify driver. Load assemblies, use assemblies to
26974 2001-06-07 Miguel de Icaza <miguel@ximian.com>
26976 * Experiment successful: Use System.Type rather that our own
26979 2001-05-25 Miguel de Icaza <miguel@ximian.com>
26981 * cs-parser.jay: Removed nsAliases from here.
26983 Use new namespaces, handle `using XXX;'
26985 * namespace.cs: Reimplemented namespace handling, use a recursive
26986 definition of the class. Now we can keep track of using clauses
26987 and catch invalid using clauses.
26989 2001-05-24 Miguel de Icaza <miguel@ximian.com>
26991 * gen-treedump.cs: Adapted for all the renaming.
26993 * expression.cs (Expression): this class now has a Type property
26994 which returns an expression Type.
26996 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
26997 `Type', as this has a different meaning now in the base
26999 2001-05-22 Miguel de Icaza <miguel@ximian.com>
27001 * interface.cs, class.cs: Removed from all the sources the
27002 references to signature computation, as we can not do method
27003 signature computation during the parsing time, as we are not
27004 trying to solve at that point distinguishing:
27008 void a (NS.Blah x) {}
27011 Which depending on the context might be valid or not, as we do not
27012 know if Blah is the same thing as NS.Blah at that point.
27014 * Redid everything so the code uses TypeRefs now instead of
27015 Types. TypeRefs are just temporary type placeholders, that need
27016 to be resolved. They initially have a pointer to a string and the
27017 current scope in which they are used. This is used later by the
27018 compiler to resolve the reference to an actual Type.
27020 * DeclSpace is no longer a CIR.Type, and neither are
27021 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
27022 are all DeclSpaces, but no Types.
27024 * type.cs (TypeRefManager): This implements the TypeRef manager,
27025 which keeps track of all the types that need to be resolved after
27026 the parsing has finished.
27028 2001-05-13 Miguel de Icaza <miguel@ximian.com>
27030 * ARGH. We are going to have to store `foreach' as a class rather
27031 than resolving it, as we need to verify error 1579 after name
27032 resolution. *OR* we could keep a flag that says `This request to
27033 IEnumerator comes from a foreach statement' which we can then use
27034 to generate the error.
27036 2001-05-10 Miguel de Icaza <miguel@ximian.com>
27038 * class.cs (TypeContainer.AddMethod): we now add methods to the
27039 MethodGroup instead of the method hashtable.
27041 * expression.cs: Add MethodGroup abstraction, which gets us one
27042 step closer to the specification in the way we handle method
27045 * cs-parser.jay (primary_expression): qualified_identifier now
27046 tried to match up an identifier to a local variable reference or
27047 to a parameter reference.
27049 current_local_parameters is now a parser global variable that
27050 points to the current parameters for the block, used during name
27053 (property_declaration): Now creates an implicit `value' argument to
27056 2001-05-09 Miguel de Icaza <miguel@ximian.com>
27058 * parameter.cs: Do not use `param' arguments as part of the
27059 signature, per the spec.
27061 2001-05-08 Miguel de Icaza <miguel@ximian.com>
27063 * decl.cs: Base class for classes, structs and interfaces. This
27064 is the "Declaration Space"
27066 * cs-parser.jay: Use CheckDef for checking declaration errors
27067 instead of having one on each function.
27069 * class.cs: Factor out some code for handling error handling in
27070 accordance to the "Declarations" section in the "Basic Concepts"
27071 chapter in the ECMA C# spec.
27073 * interface.cs: Make all interface member classes derive from
27074 InterfaceMemberBase.
27076 2001-05-07 Miguel de Icaza <miguel@ximian.com>
27078 * Many things: all interfaces are parsed and generated in
27079 gen-treedump. Support for member variables, constructors,
27080 destructors, properties, constants is there.
27082 Beginning of the IL backend, but very little done, just there for
27085 2001-04-29 Miguel de Icaza <miguel@ximian.com>
27087 * cs-parser.jay: Fix labeled statement.
27089 * cs-tokenizer.cs (escape): Escape " and ' always.
27090 ref_line, ref_name: keep track of the line/filename as instructed
27091 by #line by the compiler.
27094 2001-04-27 Miguel de Icaza <miguel@ximian.com>
27096 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
27097 to match the values in System.CodeDOM.
27099 Divid renamed to Divide.
27101 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
27103 (Statements.set): remove.
27105 * System.CodeDOM/CodeCatchClause.cs: always have a valid
27108 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
27109 falseStatements always have valid values.
27111 * cs-parser.jay: Use System.CodeDOM now.