1 2004-11-15 Martin Baulig <martin@ximian.com>
3 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
5 2004-11-11 Martin Baulig <martin@ximian.com>
7 * typemanager.cs (TypeManager.GetMethodName): New method.
9 * class.cs (MethodData.Define): Include the generic arity in the
10 name of an explicit interface; also add it to the method name.
12 * pending.cs (PendingImplementation.InterfaceMethod): The method
13 name now includes the generic arity.
15 2004-11-07 Miguel de Icaza <miguel@ximian.com>
17 * expression.cs (Invocation.OverloadResolve): Flag error if we are
18 calling an unsafe method from a safe location.
20 2004-11-06 Marek Safar <marek.safar@seznam.cz>
23 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
25 2004-11-06 Miguel de Icaza <miguel@ximian.com>
27 * namespace.cs (VerifyUsing): use GetPartialName instead of
30 2004-11-05 Miguel de Icaza <miguel@ximian.com>
32 * statement.cs (Return.Resolve): Fix regression in typo: if
33 `in_exc', we have to request a NeedReturnLabel, this was a typo
34 introduced in the anonymous method check-in. Fixes #69131.
36 * Indexers were using the ShortName when defining themselves,
37 causing a regression in the compiler bootstrap when applying the
38 patch from 2004-11-02 (first part), now they use their full name
41 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
43 * driver.cs: Strip the path from the names of embedded resources. Fixes
46 2004-11-04 Raja R Harinath <rharinath@novell.com>
48 Fix error message regression: cs0104-2.cs.
49 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
50 (AliasEntry.Resolve): Update.
51 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
53 (RootContext.LookupType): Update.
55 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
57 * cs-parser.jay: Add support for handling accessor modifiers
58 * class: Add support port accessor modifiers and error checking,
59 define PropertyMethod.Define as virtual (not abstract anymore)
60 * ecore.cs: Add checking for proeprties access with access modifiers
61 * iterators.cs: Modify Accessor constructor call based in the modified
63 2004-11-02 Ben Maurer <bmaurer@ximian.com>
65 * expression.cs (StringConcat): Handle being called twice,
66 as when we have a concat in a field init with more than two
69 2004-11-02 Miguel de Icaza <miguel@ximian.com>
71 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
72 special case explicit implementations, we should always produce
73 the .property or .event declaration.
75 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
76 since it will not return correct data if people use this
77 unresolved in the presence of using statements (see test-313).
79 * class.cs (MethodData.Define): If we are an explicit interface
80 implementation, set the method name to the full name of the
81 interface plus the name of the method.
83 Notice that using the method.MethodName.GetFullName() does not
84 work, as it will only contain the name as declared on the source
85 file (it can be a shorthand in the presence of using statements)
86 and not the fully qualifed type name, for example:
90 class D : ICloneable {
91 object ICloneable.Clone () {
95 Would produce a method called `ICloneable.Clone' instead of
96 `System.ICloneable.Clone'.
98 * namespace.cs (Alias.Resolve): Use GetPartialName.
100 2004-11-01 Marek Safar <marek.safar@seznam.cz>
102 * cs-parser.jay: Add error 1055 report.
104 2004-11-01 Miguel de Icaza <miguel@ximian.com>
106 * assign.cs (Assign.DoResolve): Only do the transform of
107 assignment into a New if the types are compatible, if not, fall
108 through and let the implicit code deal with the errors and with
109 the necessary conversions.
111 2004-11-01 Marek Safar <marek.safar@seznam.cz>
113 * cs-parser.jay: Add error 1031 report.
115 * cs-tokenizer.cs: Add location for error 1038.
117 2004-10-31 Marek Safar <marek.safar@seznam.cz>
119 * cs-parser.jay: Add error 1016 report.
121 2004-10-31 Marek Safar <marek.safar@seznam.cz>
123 * cs-parser.jay: Add errors 1575,1611 report.
125 2004-10-31 Marek Safar <marek.safar@seznam.cz>
127 * cs-parser.jay: Add error 1001 report.
129 2004-10-31 Marek Safar <marek.safar@seznam.cz>
132 * attribute.cs (GetMarshal): Add method argument for
133 caller identification.
135 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
136 agument for GetMarshal and RuntimeMissingSupport.
138 2004-10-31 Marek Safar <marek.safar@seznam.cz>
140 * attribute.cs (ExtractSecurityPermissionSet): Removed
141 TypeManager.code_access_permission_type.
143 * typemanager.cs: Removed TypeManager.code_access_permission_type.
145 2004-10-27 Miguel de Icaza <miguel@ximian.com>
147 * expression.cs (LocalVariableReference.DoResolveLValue): Check
148 for obsolete use of a variable here. Fixes regression on errors
149 cs0619-25 and cs0619-26.
151 2004-10-27 Marek Safar <marek.safar@seznam.cz>
153 Fix #62358, implemented security attribute encoding.
155 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
156 Tests permitted SecurityAction for assembly or other types.
157 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
158 data from SecurityPermissionAttribute to PermisionSet class.
160 * class.cs (ApplyAttributeBuilder): Added special handling
161 for System.Security.Permissions.SecurityAttribute based types.
163 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
164 special handling for System.Security.Permissions.SecurityAttribute
167 * enum.cs (ApplyAttributeBuilder): Added special handling
168 for System.Security.Permissions.SecurityAttribute based types.
170 * parameter.cs (ApplyAttributeBuilder): Added special handling
171 for System.Security.Permissions.SecurityAttribute based types.
173 * rootcontext.cs: Next 2 core types.
175 * typemanager.cs (TypeManager.security_permission_attr_type):
176 Built in type for the SecurityPermission Attribute.
177 (code_access_permission_type): Build in type.
179 2004-10-17 Miguel de Icaza <miguel@ximian.com>
181 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
182 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
183 all of this information into
184 EmitContext.EmitCapturedVariableInstance.
186 * codegen.cs (EmitCapturedVariableInstance): move here the
187 funcionality of emitting an ldarg.0 in the presence of a
188 remapping. This centralizes the instance emit code.
190 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
191 then emit a load of this: it means that we have reached the
192 topmost ScopeInfo: the one that contains the pointer to the
193 instance of the class hosting the anonymous method.
195 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
196 captures to the topmost CaptureContext.
198 2004-10-12 Miguel de Icaza <miguel@ximian.com>
200 * expression.cs (LocalVariableReference): Move the knowledge about
201 the iterators into codegen's EmitCapturedVariableInstance.
203 2004-10-11 Miguel de Icaza <miguel@ximian.com>
205 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
206 all code paths return a value from an anonymous method (it is the
207 same as the 161 error, but for anonymous methods).
209 2004-10-08 Miguel de Icaza <miguel@ximian.com>
211 The introduction of anonymous methods in the compiler changed
212 various ways of doing things in the compiler. The most
213 significant one is the hard split between the resolution phase
214 and the emission phases of the compiler.
216 For instance, routines that referenced local variables no
217 longer can safely create temporary variables during the
218 resolution phase: they must do so from the emission phase,
219 since the variable might have been "captured", hence access to
220 it can not be done with the local-variable operations from the runtime.
224 (Block.Flags): New flag `IsTopLevel' to indicate that this block
227 (ToplevelBlock): A new kind of Block, these are the blocks that
228 are created by the parser for all toplevel method bodies. These
229 include methods, accessors and anonymous methods.
231 These contain some extra information not found in regular blocks:
232 A pointer to an optional CaptureContext (for tracking captured
233 local variables and parameters). A pointer to the parent
236 (Return.Resolve): Catch missmatches when returning a value from an
237 anonymous method (error 1662).
238 Invoke NeedReturnLabel from the Resolve phase instead of the emit
241 (Break.Resolve): ditto.
243 (SwitchLabel): instead of defining the labels during the
244 resolution phase, we now turned the public ILLabel and ILLabelCode
245 labels into methods called GetILLabelCode() and GetILLabel() that
246 only define the label during the Emit phase.
248 (GotoCase): Track the SwitchLabel instead of the computed label
249 (its contained therein). Emit the code by using
250 SwitchLabel.GetILLabelCode ().
252 (LocalInfo.Flags.Captured): A new flag has been introduce to track
253 whether the Local has been captured or not.
255 (LocalInfo.IsCaptured): New property, used to tell whether the
256 local has been captured.
258 * anonymous.cs: Vastly updated to contain the anonymous method
261 The main classes here are: CaptureContext which tracks any
262 captured information for a toplevel block and ScopeInfo used to
263 track the activation frames for various local variables.
265 Each toplevel block has an optional capture context associated
266 with it. When a method contains an anonymous method both the
267 toplevel method and the anonymous method will create a capture
268 context. When variables or parameters are captured, they are
269 recorded on the CaptureContext that owns them, for example:
273 MyDelegate d = delegate {
278 Here `a' will be recorded as captured on the toplevel
279 CapturedContext, the inner captured context will not have anything
280 (it will only have data if local variables or parameters from it
281 are captured in a nested anonymous method.
283 The ScopeInfo is used to track the activation frames for local
284 variables, for example:
286 for (int i = 0; i < 10; i++)
287 for (int j = 0; j < 10; j++){
288 MyDelegate d = delegate {
293 At runtime this captures a single captured variable `i', but it
294 captures 10 different versions of the variable `j'. The variable
295 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
298 The toplevel ScopeInfo will also track information like the `this'
299 pointer if instance variables were referenced (this is necessary
300 as the anonymous method lives inside a nested class in the host
303 (AnonymousMethod): Expanded to track the Toplevel, implement
304 `AnonymousMethod.Compatible' to tell whether an anonymous method
305 can be converted to a target delegate type.
307 The routine now also produces the anonymous method content
309 (AnonymousDelegate): A helper class that derives from
310 DelegateCreation, this is used to generate the code necessary to
311 produce the delegate for the anonymous method that was created.
313 * assign.cs: API adjustments for new changes in
314 Convert.ImplicitStandardConversionExists.
316 * class.cs: Adjustments to cope with the fact that now toplevel
317 blocks are of type `ToplevelBlock'.
319 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
320 insteda of standard blocks.
322 Flag errors if params arguments are passed to anonymous methods.
324 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
325 `CurrentAnonymousMethod' which points to the current Anonymous
326 Method. The variable points to the AnonymousMethod class that
327 holds the code being compiled. It is set in the new EmitContext
328 created for the anonymous method.
330 (EmitContext.Phase): Introduce a variable and an enumeration to
331 assist in enforcing some rules about when and where we are allowed
332 to invoke certain methods (EmitContext.NeedsReturnLabel is the
333 only one that enfonces this right now).
335 (EmitContext.HaveCaptureInfo): new helper method that returns
336 whether we have a CapturedContext initialized.
338 (EmitContext.CaptureVariable): New method used to register that a
339 LocalInfo must be flagged for capturing.
341 (EmitContext.CapturedParameter): New method used to register that a
342 parameters must be flagged for capturing.
344 (EmitContext.CapturedField): New method used to register that a
345 field must be flagged for capturing.
347 (EmitContext.HaveCapturedVariables,
348 EmitContext.HaveCapturedFields): Return whether there are captured
351 (EmitContext.EmitMethodHostInstance): This is used to emit the
352 instance for the anonymous method. The instance might be null
353 (static methods), this (for anonymous methods that capture nothing
354 and happen to live side-by-side with the current method body) or a
355 more complicated expression if the method has a CaptureContext.
357 (EmitContext.EmitTopBlock): Routine that drives the emission of
358 code: it will first resolve the top block, then emit any metadata
359 and then emit the code. The split is done so that we can extract
360 any anonymous methods and flag any captured variables/parameters.
362 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
363 during this phase, the ILGenerator should not be used as labels
364 and local variables declared here might not be accessible to any
365 code that is part of an anonymous method.
367 Exceptions to this include the temporary variables that are
368 created by some statements internally for holding temporary
371 (EmitContext.EmitMeta): New routine, in charge of emitting all the
374 (EmitContext.TemporaryReturn): This method is typically called
375 from the Emit phase, and its the only place where we allow the
376 ReturnLabel to be defined other than the EmitMeta. The reason is
377 that otherwise we would have to duplicate a lot of logic in the
378 Resolve phases of various methods that today is on the Emit
381 (EmitContext.NeedReturnLabel): This no longer creates the label,
382 as the ILGenerator is not valid during the resolve phase.
384 (EmitContext.EmitThis): Extended the knowledge in this class to
385 work in anonymous methods in addition to iterators.
387 (EmitContext.EmitCapturedVariableInstance): This emits whatever
388 code is necessary on the stack to access the instance to a local
389 variable (the variable will be accessed as a field).
391 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
392 EmitContext.EmitAddressOfParameter): Routines to support
393 parameters (not completed at this point).
395 Removals: Removed RemapLocal and RemapLocalLValue. We probably
396 will also remove the parameters.
398 * convert.cs (Convert): Define a `ConstantEC' which points to a
399 null. This is just to prefity some code that uses
400 ImplicitStandardConversion code and do not have an EmitContext
403 The idea is to flag explicitly that at that point in time, it is
404 known that the conversion will not trigger the delegate checking
405 code in implicit conversions (which requires a valid
408 Everywhere: pass new EmitContext parameter since
409 ImplicitStandardConversionExists now requires it to check for
410 anonymous method conversions.
412 (Convert.ImplicitStandardConversionExists): If the type of an
413 expression is the anonymous_method_type, and the type is a
414 delegate, we invoke the AnonymousMethod.Compatible method to check
415 whether an implicit conversion is possible.
417 (Convert.ImplicitConversionStandard): Only do implicit method
418 group conversions if the language level is not ISO_1.
420 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
421 MethodInfo for the Invoke method. used by Delegate and
424 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
425 method conversions if the target type is a delegate.
427 Removed extra debugging nops.
429 (LocalVariableReference): Turn the `local_info' into a public
432 Add `prepared' field, the same hack used for FieldExprs to cope
433 with composed assignments, as Local variables do not necessarily
434 operate purely on the stack as they used to: they can be captured
437 Add `temp' for a temporary result, like fields.
439 Refactor DoResolve and DoResolveLValue into DoResolveBase.
441 It now copes with Local variables that are captured and emits the
442 proper instance variable to load it from a field in the captured
445 (ParameterReference.DoResolveBase): During the resolve phase,
446 capture parameters if we are in an anonymous method.
448 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
449 anonymous method, use the EmitContext helper routines to emit the
452 * iterators.cs: Set RemapToProxy to true/false during the
455 * parameters.cs (GetParameterByName): New helper method.
457 * typemanager.cs (anonymous_method_type) a new type that
458 represents an anonyous method. This is always an internal type,
459 used as a fencepost to test against the anonymous-methodness of an
462 2004-10-20 Marek Safar <marek.safar@seznam.cz>
464 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
466 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
468 2004-11-10 Martin Baulig <martin@ximian.com>
470 * expression.cs (Invocation.BetterFunction): If two methods have
471 equal parameter types, but only one of them is generic, the
472 non-generic one wins.
473 (New.DoResolve): Don't set `is_struct' to false if we're a generic
474 instance; just use `Type.IsValueType' to determine whether
475 something is a struct or not.
476 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
477 so we can be called multiple times.
479 2004-11-10 Martin Baulig <martin@ximian.com>
481 * generic.cs (TypeParameter.DefineConstraints): New public method.
482 (TypeParameter.CheckAccessLevel): Override this and return true.
483 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
484 override ResolveType() anymore.
485 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
487 2004-11-10 Martin Baulig <martin@ximian.com>
489 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
490 call DeclSpace.ResolveNestedType() on it.
492 2004-11-10 Martin Baulig <martin@ximian.com>
494 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
495 non-null, call ParameterModifier() on it.
497 2004-11-10 Martin Baulig <martin@ximian.com>
500 (Iterators): Added `current_type' and `this_type' fields.
501 (Iterators.DefineIterator): Create a new EmitContext and store it
502 in `ec'; compute `this_type'.
504 2004-11-10 Martin Baulig <martin@ximian.com>
507 (TypeManager.IsPrivateAccessible): New public method.
508 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
510 2004-11-10 Martin Baulig <martin@ximian.com>
512 * class.cs (TypeContainer.DefineType): Call
513 TypeBuilder.DefineGenericParameters() before resolving the type
515 (MethodData.parent_method): New protected field.
516 (MethodData..ctor): Added `MethodInfo parent_method' argument.
517 (MethodData.Define): Compute `parent_method'.
520 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
521 (MemberCore.GetClsCompliantAttributeValue): Likewise.
522 (DeclSpace.ec): New protected field; store the EmitContext here.
523 (DeclSpace.EmitContext): New public property.
524 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
525 (DeclSpace.ResolveNestedType): New public method.
526 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
527 (DeclSpace.NestedAccessible): Added `Type tb' argument.
528 (DeclSpace.FamilyAccessible): Likewise.
529 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
530 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
533 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
536 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
537 (Enum.Emit): Don't create a new EmitContext.
539 2004-10-18 Martin Baulig <martin@ximian.com>
541 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
542 `Type' directly, but call ResolveType() on it.
543 (Catch.Resolve): Likewise.
544 (Foreach.Resolve): Likewise.
546 2004-10-18 Martin Baulig <martin@ximian.com>
548 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
549 `Type' directly, but call ResolveType() on it.
550 (Probe.DoResolve): Likewise.
551 (ArrayCreation.LookupType): Likewise.
552 (TypeOf.DoResolve): Likewise.
553 (SizeOf.DoResolve): Likewise.
555 2004-10-18 Raja R Harinath <rharinath@novell.com>
557 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
560 2004-10-17 John Luke <john.luke@gmail.com>
562 * class.cs (Operator.GetSignatureForError): use CSharpName
564 * parameter.cs (Parameter.GetSignatureForError): Returns
565 correct name even if was not defined.
567 2004-10-13 Raja R Harinath <rharinath@novell.com>
570 * class.cs (TypeContainer.EmitContext): New property.
571 (DefineNestedTypes): Create an emitcontext for each part.
572 (MethodCore.DoDefineParameters): Use container's emitcontext.
573 Pass type array to InternalParameters.
574 (MemberBase.DoDefine): Use container's emitcontext.
575 (FieldMember.Define): Likewise.
576 (Event.Define): Likewise.
577 (SetMethod.GetParameterInfo): Change argument to EmitContext.
578 Pass type array to InternalParameters.
579 (SetIndexerMethod.GetParameterInfo): Likewise.
580 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
581 * delegate.cs (Define): Pass emitcontext to
582 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
583 array to InternalParameters.
584 * expression.cs (ParameterReference.DoResolveBase): Pass
585 emitcontext to GetParameterInfo.
586 (ComposedCast.DoResolveAsTypeStep): Remove check on
587 ec.ResolvingTypeTree.
588 * parameter.cs (Parameter.Resolve): Change argument to
589 EmitContext. Use ResolveAsTypeTerminal.
590 (Parameter.GetSignature): Change argument to EmitContext.
591 (Parameters.ComputeSignature): Likewise.
592 (Parameters.ComputeParameterTypes): Likewise.
593 (Parameters.GetParameterInfo): Likewise.
594 (Parameters.ComputeAndDefineParameterTypes): Likewise.
595 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
596 * support.cs (InternalParameters..ctor): Remove variant that takes
598 * typemanager.cs (system_intptr_expr): New.
599 (InitExpressionTypes): Initialize it.
601 2004-10-12 Chris Toshok <toshok@ximian.com>
603 * cs-parser.jay: fix location for try_statement and catch_clause.
605 2004-10-18 Martin Baulig <martin@ximian.com>
607 * class.cs (FieldMember.Define): Don't access the TypeExpr's
608 `Type' directly, but call ResolveType() on it.
609 (MemberBase.DoDefine): Likewise.
611 * expression.cs (New.DoResolve): Don't access the TypeExpr's
612 `Type' directly, but call ResolveType() on it.
613 (ComposedCast.DoResolveAsTypeStep): Likewise.
615 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
616 `Type' directly, but call ResolveType() on it.
618 2004-10-17 John Luke <john.luke@gmail.com>
620 * class.cs (Operator.GetSignatureForError): use CSharpName
622 * parameter.cs (Parameter.GetSignatureForError): Returns
623 correct name even if was not defined.
625 2004-10-13 Raja R Harinath <rharinath@novell.com>
628 * class.cs (TypeContainer.EmitContext): New property.
629 (DefineNestedTypes): Create an emitcontext for each part.
630 (MethodCore.DoDefineParameters): Use container's emitcontext.
631 Pass type array to InternalParameters.
632 (MemberBase.DoDefine): Use container's emitcontext.
633 (FieldMember.Define): Likewise.
634 (Event.Define): Likewise.
635 (SetMethod.GetParameterInfo): Change argument to EmitContext.
636 Pass type array to InternalParameters.
637 (SetIndexerMethod.GetParameterInfo): Likewise.
638 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
639 * delegate.cs (Define): Pass emitcontext to
640 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
641 array to InternalParameters.
642 * expression.cs (ParameterReference.DoResolveBase): Pass
643 emitcontext to GetParameterInfo.
644 (ComposedCast.DoResolveAsTypeStep): Remove check on
645 ec.ResolvingTypeTree.
646 * parameter.cs (Parameter.Resolve): Change argument to
647 EmitContext. Use ResolveAsTypeTerminal.
648 (Parameter.GetSignature): Change argument to EmitContext.
649 (Parameters.ComputeSignature): Likewise.
650 (Parameters.ComputeParameterTypes): Likewise.
651 (Parameters.GetParameterInfo): Likewise.
652 (Parameters.ComputeAndDefineParameterTypes): Likewise.
653 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
654 * support.cs (InternalParameters..ctor): Remove variant that takes
656 * typemanager.cs (system_intptr_expr): New.
657 (InitExpressionTypes): Initialize it.
659 2004-10-12 Chris Toshok <toshok@ximian.com>
661 * cs-parser.jay: fix location for try_statement and catch_clause.
663 2004-10-07 Raja R Harinath <rharinath@novell.com>
665 More DeclSpace.ResolveType avoidance.
666 * decl.cs (MemberCore.InUnsafe): New property.
667 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
668 with newly created EmitContext.
669 (FieldMember.Define): Likewise.
670 * delegate.cs (Delegate.Define): Likewise.
671 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
672 only if normal name-lookup fails.
673 (TypeExpr.DoResolve): Enable error-checking.
674 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
675 (SizeOf.DoResolve): Likewise.
676 (ComposedCast.DoResolveAsTypeStep): Likewise.
677 (StackAlloc.DoResolve): Likewise.
678 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
679 (Block.Unsafe): New property.
680 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
681 (Unsafe): Set 'unsafe' flag of contained block.
682 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
683 (Fixed.Resolve): Likewise.
684 (Catch.Resolve): Likewise.
685 (Using.ResolveLocalVariableDecls): Likewise.
686 (Foreach.Resolve): Likewise.
688 2004-10-05 John Luke <john.luke@gmail.com>
690 * cs-parser.jay: add location to error CS0175
692 2004-10-04 Miguel de Icaza <miguel@ximian.com>
694 * ecore.cs (Expression.Constantity): Add support for turning null
697 * const.cs (Const.Define): Allow constants to be reference types
698 as long as the value is Null.
700 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
702 * namespace.cs (NamespaceEntry.Using): No matter which warning
703 level is set, check if this namespace name has already been added.
705 2004-10-03 Ben Maurer <bmaurer@ximian.com>
707 * expression.cs: reftype [!=]= null should always use br[true,false].
710 2004-10-03 Marek Safar <marek.safar@seznam.cz>
713 * attribute.cs: Enum conversion moved to
714 GetAttributeArgumentExpression to be applied to the all
717 2004-10-01 Raja R Harinath <rharinath@novell.com>
719 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
720 * class.c (TypeContainer.DefineType): Flag error if
721 base types aren't accessible due to access permissions.
722 * decl.cs (DeclSpace.ResolveType): Move logic to
723 Expression.ResolveAsTypeTerminal.
724 (DeclSpace.ResolveTypeExpr): Thin layer over
725 Expression.ResolveAsTypeTerminal.
726 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
727 Refactor code into NestedAccess. Use it.
728 (DeclSpace.NestedAccess): New.
729 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
730 argument to silence errors. Check access permissions.
731 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
732 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
733 (Cast.DoResolve): Likewise.
734 (New.DoResolve): Likewise.
735 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
736 (TypeOf.DoResolve): Likewise.
738 * expression.cs (Invocation.BetterConversion): Return the Type of
739 the better conversion. Implement section 14.4.2.3 more faithfully.
740 (Invocation.BetterFunction): Make boolean. Make correspondence to
741 section 14.4.2.2 explicit.
742 (Invocation.OverloadResolve): Update.
743 (Invocation): Remove is_base field.
744 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
745 (Invocation.Emit): Likewise.
747 2004-09-24 Marek Safar <marek.safar@seznam.cz>
749 * cs-parser.jay: Reverted 642 warning fix.
751 2004-09-23 Marek Safar <marek.safar@seznam.cz>
754 * decl.cs (FindMemberWithSameName): Indexer can have more than
757 2004-09-23 Marek Safar <marek.safar@seznam.cz>
759 * expression.cs (LocalVariableReference.DoResolveLValue):
760 Do not report warning 219 for out values.
761 (EmptyExpression.Null): New member to avoid extra allocations.
763 2004-09-23 Marek Safar <marek.safar@seznam.cz>
765 * cs-parser.jay: Fix wrong warning 642 report.
767 * cs-tokenizer.cs (CheckNextToken): New helper;
768 Inspect next character if is same as expected.
770 2004-09-23 Martin Baulig <martin@ximian.com>
772 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
773 (Convert.ImplicitReferenceConversionExists): Likewise.
775 2004-11-09 Raja R Harinath <rharinath@novell.com>
777 * Makefile (DISTFILES): Comment out a few missing files.
779 2004-10-29 Raja R Harinath <rharinath@novell.com>
781 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
782 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
783 (gmcs.exe): Invoke bootstrap-libs.
784 (clean-local): Clean the net_2_0_bootstrap profile too.
785 (PROGRAM_INSTALL_DIR): New.
786 (install-local): Use it.
788 2004-10-13 Martin Baulig <martin@ximian.com>
790 * generic.cs (TypeManager.InflatedConstraints): New nested class.
791 (TypeParameter.DefineType): If we're a method type parameter and
792 that method is overriding something, "inflate" its constraints.
794 2004-10-12 Martin Baulig <martin@ximian.com>
796 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
797 and have type arguments, create and resolve a ConstructedType.
799 2004-10-12 Martin Baulig <martin@ximian.com>
801 * decl.cs (MemberCache.FindMemberToOverride): Use
802 TypeManager.IsEqual() to compare the parameters and Type.Equals()
803 to compare the invocationType.
805 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
806 When comparing two type parameters, only do the signature-only
807 comparision for method type parameters.
809 2004-10-11 Martin Baulig <martin@ximian.com>
811 * report.cs: Don't make --fatal abort on warnings, we have
812 -warnaserror for that.
814 2004-10-11 Martin Baulig <martin@ximian.com>
817 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
818 (TypeManager.IsEqual): Call ourself recursively instead of using
821 2004-10-11 Martin Baulig <martin@ximian.com>
823 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
824 on our own type parameters, not on the ones we inherit from a containing
827 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
830 * generic.cs (TypeParameter.Define): We may only be called once.
832 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
833 instead of TypeManager.IsEqual().
835 2004-09-28 Martin Baulig <martin@ximian.com>
838 (GenericConstraints.EffectiveBaseClass): New public property.
839 (TypeParameter.GenericConstraints): New public property.
840 (ConstructedType.CheckConstraints): Improved.
842 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
843 (Convert.TypeParameterConversion): New private method; use this in
844 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
845 for all conversions related to type parameters.
847 2004-09-24 Martin Baulig <martin@ximian.com>
849 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
850 type parameter conversions for type parameters which are known to
853 2004-09-24 Martin Baulig <martin@ximian.com>
855 * generic.cs (GenericConstraints): Added `IsReferenceType' and
856 `IsValueType' properties.
858 * support.cs (ReflectionConstraints): Use
859 Type.GetGenericParameterConstraints() instead of the old hack.
861 2004-09-24 Martin Baulig <martin@ximian.com>
863 * generic.cs (GenericConstraints): Moved here and made it an
866 * support.cs (GenericConstraints): Moved to generic.cs.
868 2004-09-24 Martin Baulig <martin@ximian.com>
871 (ReflectionConstraints): Un-nested this class and made it public.
874 (TypeManager.GetTypeParameterConstraints): New public method.
875 (TypeManager.HasConstructorConstraint): Use the attributes.
877 2004-09-24 Martin Baulig <martin@ximian.com>
879 * support.cs (GenericConstraints): Replaced `HasConstructor',
880 `IsReferenceType' and `IsValueType' with `Attributes'.
881 (ReflectionParameters.ReflectionConstraints): Removed the Create()
882 method and made the .ctor public.
884 * generic.cs (Constraints.Attributes): New public property.
885 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
886 `IsReferenceType' -> `HasReferenceTypeConstraint' and
887 `IsValueType' -> `HasValueTypeConstraint'.
889 2004-09-23 Martin Baulig <martin@ximian.com>
891 * generic.cs (Constraints): Reflect latest runtime changes.
893 2004-09-23 Martin Baulig <martin@ximian.com>
895 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
896 (Convert.ImplicitReferenceConversionExists): Likewise.
898 2004-09-23 Marek Safar <marek.safar@seznam.cz>
900 * class.cs (Operator.Define): Add error 448 and 559 report.
902 2004-09-22 Marek Safar <marek.safar@seznam.cz>
904 * class.cs (MemberBase.IsTypePermitted): New protected
905 method for checking error CS0610.
907 2004-09-22 Marek Safar <marek.safar@seznam.cz>
909 * class.cs (TypeContainer.HasExplicitLayout): New property
910 Returns whether container has StructLayout attribute set Explicit.
911 (FieldMember): New abstract class for consts and fields.
912 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
913 (Field): Reuse FieldMember.
915 * const.cs (Const): Reuse FieldMember.
917 * rootcontext.cs: EmitConstants call moved to class.
919 2004-09-22 Martin Baulig <martin@ximian.com>
921 Marek and me just fixed one of our oldest bugs: #28562 :-)
923 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
925 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
926 we're an EnumConstant, just return that.
927 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
928 an EnumConstant. In this case, we need to use GetValueAsEnumType()
929 to get the value which'll actually be written into the attribute.
930 However, we have to use GetValue() to access the attribute's value
933 2004-09-22 Marek Safar <marek.safar@seznam.cz>
935 * constant.cs (Constant.IsNegative): New abstract property
938 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
939 (StackAlloc.DoResolve): Reused IsNegative.
941 2004-09-22 Martin Baulig <martin@ximian.com>
943 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
944 public method; like LookupTypeContainer, but also works for
947 * report.cs (Report.SymbolRelatedToPreviousError): Use
948 TypeManager.LookupGenericTypeContainer().
950 2004-09-22 Martin Baulig <martin@ximian.com>
952 Thanks to Peter Sestoft for this bug report.
954 * expression.cs (Conditional): If both the `trueExpr' and the
955 `falseExpr' is a NullLiteral, return a NullLiteral.
957 2004-09-22 Martin Baulig <martin@ximian.com>
959 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
960 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
961 for the "get_Current" call.
963 2004-09-21 Martin Baulig <martin@ximian.com>
965 * convert.cs (Convert.ImplicitReferenceConversion): When
966 converting to an interface type, first check whether we're
967 converting from a reference type.
969 2004-09-14 Martin Baulig <martin@ximian.com>
971 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
973 2004-09-14 Marek Safar <marek.safar@seznam.cz>
976 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
977 called and is obsolete then this member suppress message
978 when call is inside next [Obsolete] method or type.
980 * expression.cs: Use TestObsoleteMethodUsage member.
982 2004-09-14 Martin Baulig <martin@ximian.com>
984 * genericparser.cs: Removed.
986 2004-09-13 Marek Safar <marek.safar@seznam.cz>
988 * class.cs (MethodCore.CheckBase): Fix bug #65757.
990 2004-09-12 Marek Safar <marek.safar@seznam.cz>
992 * attribute.cs (Attribute.Resolve): Add error 653 report.
994 * class.cs (Class.ApplyAttributeBuilder): Add error 641
996 (Method.ApplyAttributeBuilder): Add error 685 report.
997 (Operator.Define): Add error 564 report.
999 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1001 * expression.cs (Invocation.DoResolve): Add error
1004 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1007 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1009 * class.cs (ConstructorInitializer.Resolve):
1010 Wrong error number (515->516).
1012 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1014 * class.cs (Indexer.Define): Add error 631 report.
1016 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1018 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1020 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1022 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1024 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1026 * cs-parser.jay: Added error CS0241 report.
1028 2004-09-10 Raja R Harinath <rharinath@novell.com>
1030 * cs-parser.jay (fixed_statement): Introduce a scope for the
1031 declaration in the 'fixed' statement.
1033 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1035 * cs-parser.jay: Added CS0230 error report.
1037 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1039 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1041 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1043 * expression.cs (Argument.Resolve): Added error CS0192 and
1046 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1048 C# 2.0 #pragma warning feature
1050 * cs-tokenizer.cs (PreProcessPragma): New method;
1051 Handles #pragma directive.
1053 * report.cs (WarningRegions): New class; Support
1054 class for #pragma warning directive. It tests whether
1055 warning is enabled for a given line.
1057 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1059 * const.cs: Add more descriptive error report, tahnks to
1062 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1064 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1066 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1068 * expression.cs: Apply patch from Ben: Remove dead code from
1069 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1070 as that code just threw an exception anwyays.
1072 * const.cs: Remove the call to the turnintoconstant, for details
1075 * literal.cs: The type of the null-literal is the null type; So
1076 we use a placeholder type (literal.cs:System.Null, defined here)
1079 * expression.cs (Conditional.DoResolve): Remove some old code that
1080 is no longer needed, conversions have been fixed.
1082 (ArrayCreationExpression.DoResolve): Return false if we fail to
1083 resolve the inner expression.
1085 2004-09-07 Raja R Harinath <rharinath@novell.com>
1088 * cs-parser.jay (delegate_declaration): Record a delegate
1089 declaration as a type declaration.
1090 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1092 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1094 * parameter.cs: Do not crash if the type can not be resolved.
1096 * expression.cs: Report errors with unsafe pointers, fixes #64896
1098 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1100 * expression.cs: Pointer arith always needs to do a conv.i
1101 if the operand is a long. fix 65320
1103 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1105 Fixed cs0619-37.cs, cs0619-38.cs
1107 * enum.cs (GetObsoleteAttribute): Removed.
1109 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1110 on Enum member is double staged. The first is tested member
1113 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1115 Fixed #56986, #63631, #65231
1117 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1118 adds member to name container.
1119 (TypeContainer.AddToTypeContainer): New method, adds type to
1121 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1122 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1123 AddOperator): Simplified by reusing AddToMemberContainer.
1124 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1126 (Method.CheckForDuplications): Fixed implementation to test all
1128 (MemberBase): Detection whether member is explicit interface
1129 implementation is now in constructor.
1130 (MemberBase.UpdateMemberName): Handles IndexerName.
1131 (Accessor): Changed to keep also location information.
1132 (AbstractPropertyEventMethod): Is derived from MemberCore.
1133 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1134 will be emited or not.
1135 (PropertyBase.AreAccessorsDuplicateImplementation):
1136 Tests whether accessors are not in collision with some method.
1137 (Operator): Is derived from MethodCore to simplify common
1140 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1142 (DeclSpace.AddToContainer): Adds the member to defined_names
1143 table. It tests for duplications and enclosing name conflicts.
1145 * enum.cs (EnumMember): Clean up to reuse the base structures
1147 2004-09-03 Martin Baulig <martin@ximian.com>
1149 Merged latest changes into gmcs. Please keep this comment in
1150 here, it makes it easier for me to see what changed in MCS since
1151 the last time I merged.
1153 2004-09-03 Martin Baulig <martin@ximian.com>
1155 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1156 into TypeContainer, to make partial classes work again.
1158 2004-09-03 Martin Baulig <martin@ximian.com>
1160 * rootcontext.cs (RootContext.V2): Removed.
1162 2004-03-23 Martin Baulig <martin@ximian.com>
1164 * expression.cs (Invocation.OverloadResolve): Added `bool
1165 may_fail' argument and use it instead of the Location.IsNull() hack.
1167 2004-09-09 Martin Baulig <martin@ximian.com>
1169 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
1171 2004-09-09 Martin Baulig <martin@ximian.com>
1173 * generic.cs (TypeParameter.DefineType): Added support for
1174 explicit interface methods.
1176 2004-09-09 Martin Baulig <martin@ximian.com>
1178 * README.Changes: New document. Started to list important changes
1179 between MCS and GMCS here.
1181 2004-09-08 Martin Baulig <martin@ximian.com>
1184 (TypeContainer.CheckRecursiveDefinition): New protected method.
1185 (TypeContainer.DefineType): Move the CS0146 check into
1186 CheckRecursiveDefinition().
1188 2004-09-06 Martin Baulig <martin@ximian.com>
1190 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
1191 types for the constructor constraint.
1193 2004-09-03 Martin Baulig <martin@ximian.com>
1195 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1196 into TypeContainer, to make partial classes work again.
1198 2004-09-03 Martin Baulig <martin@ximian.com>
1200 * rootcontext.cs (RootContext.V2): Removed.
1202 2004-03-23 Martin Baulig <martin@ximian.com>
1204 * expression.cs (Invocation.OverloadResolve): Added `bool
1205 may_fail' argument and use it instead of the Location.IsNull() hack.
1207 2004-09-03 Martin Baulig <martin@ximian.com>
1209 Merged latest changes into gmcs. Please keep this comment in
1210 here, it makes it easier for me to see what changed in MCS since
1211 the last time I merged.
1213 2004-09-03 Raja R Harinath <rharinath@novell.com>
1216 * expression.cs (BetterConversion): Don't allow either conversion
1217 to be null. Remove redundant implicit conversion test when 'q ==
1218 null' -- when this function is invoked, we already know that the
1219 implicit conversion exists.
1220 (BetterFunction): Assume that 'best' is non-null. Remove
1221 redundant reimplementation of IsApplicable when 'best' is null.
1222 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1223 number of arguments.
1224 (IsAncestralType): Extract from OverloadResolve.
1225 (OverloadResolve): Make robust to the MethodGroupExpr being
1226 unsorted. Implement all the logic of Section 14.5.5.1, and
1227 support overloading of methods from multiple applicable types.
1228 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1230 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1231 (RealError, Warning): Append type of report to related symbol.
1233 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1235 * enum.cs: Fixed CLS-Compliance checks for enum members.
1236 Error tests cs3008-8.cs, cs3014-8.cs
1238 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1240 Fixed bug #62342, #63102
1241 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1242 like ImplementMethod.
1244 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1246 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1249 2004-09-02 Martin Baulig <martin@ximian.com>
1251 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1252 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1255 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1257 C# 2.0 Static classes implemented
1259 * class.cs (TypeContainer): instance_constructors,
1260 initialized_fields, initialized_static_fields,
1261 default_constructor, base_inteface_types are protected to be
1262 accessible from StaticClass.
1263 (TypeContainer.DefineDefaultConstructor): New virtual method
1264 for custom default constructor generating
1265 (StaticClass): New class to handle "Static classes" feature.
1267 * cs-parser.jay: Handle static keyword on class like instance
1270 * driver.cs: Added "/langversion" command line switch with two
1271 options (iso-1, default).
1273 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1275 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1277 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1279 * delegate.cs: Style.
1281 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1283 * delegate.cs: Add seperate instance expr field for miguel.
1285 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1287 * PointerArithmetic (Resolve): make sure we are not doing
1288 pointer arith on void*. Also, make sure we are resolved
1289 by not setting eclass until resolve.
1291 All callers: Make sure that PointerArithmetic gets resolved.
1293 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1295 * ArrayCreation (LookupType): If the type does not resolve
1296 to an array, give an error.
1298 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1300 * statement.cs (Try.Resolve): Fixed bug #64222
1302 2004-08-27 Martin Baulig <martin@ximian.com>
1305 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1308 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1310 * ecore.cs (Constantify): Get underlying type via
1311 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1312 Windows in special cases.
1314 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1316 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1317 for obtaining also private methods.
1318 (GetRemoveMethod): Used GetRemoveMethod (true)
1319 for obtaining also private methods.
1321 2004-09-02 Martin Baulig <martin@ximian.com>
1323 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1324 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1327 2004-08-27 Martin Baulig <martin@ximian.com>
1330 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1333 2004-08-25 Martin Baulig <martin@ximian.com>
1335 * support.cs (ReflectionParameters..ctor): If this is a generic
1336 method, retrieve and store its type parameters.
1337 (InternalParameters..ctor): Added `TypeParameter[]' argument.
1338 (ReflectionParameters.GenericConstraints): The argument specifies
1339 the type parameter, not the method parameter.
1340 (InternalParameters.GenericConstraints): Likewise.
1342 * generic.cs (TypeParameter.DefineType): Correctly handle
1343 constraints wrt. generic methods in interfaces and their
1346 2004-08-24 Martin Baulig <martin@ximian.com>
1348 * generic.cs (TypeParameter.IsSubclassOf): New public method.
1349 (Constraints.IsSubclassOf): New internal method.
1351 * typemanager.cs (TypeManager.FindMembers): Added special support
1352 for GenericTypeParameterBuilder's.
1353 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
1356 2004-08-24 Martin Baulig <martin@ximian.com>
1359 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
1360 this for accessibility checks.
1361 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
1362 IsNestedFamilyAccessible.
1363 (TypeManager.IsSubclassOf): New method, do what the name actually
1366 2004-08-24 Martin Baulig <martin@ximian.com>
1368 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
1369 as a SimpleName, include the generic arity.
1371 2004-08-24 Martin Baulig <martin@ximian.com>
1373 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1374 MethodAttributes.HideBySig for operators.
1376 2004-08-23 Martin Baulig <martin@ximian.com>
1378 Back to the old error reporting system :-)
1380 * report.cs (Message): Removed.
1381 (Report.MessageData, ErrorData, WarningData): Removed.
1382 (Report.Error, Warning): Back to the old system.
1384 2004-08-23 Martin Baulig <martin@ximian.com>
1386 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1388 * class.cs (TypeContainer.ParentContainer): New public virtual
1389 method; replaces the explicit interface implementation.
1390 (ClassPart.ParentContainer): Override.
1392 2004-08-23 Martin Baulig <martin@ximian.com>
1394 * statement.cs (Switch): Added support for constant switches; see
1395 #59428 or test-285.cs.
1397 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1400 * statement.cs (GetEnumeratorFilter): Removed useless
1401 logic because C# specs is strict. GetEnumerator must be
1404 2004-08-22 Martin Baulig <martin@ximian.com>
1406 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1407 a switch and may break, reset the barrier. Fixes #59867.
1409 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1411 CLS-Compliance speed up (~5% for corlib)
1413 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1414 New method. Tests container for CLS-Compliant names
1416 * class.cs (TypeContainer.VerifyClsName): New method.
1417 Checks whether container name is CLS Compliant.
1418 (Constructor): Implements IMethodData.
1420 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1421 low-case table for CLS Compliance test.
1422 (MemberCache.VerifyClsParameterConflict): New method.
1423 Checks method parameters for CS3006 error.
1425 * enum.cs (EnumMember): Is derived from MemberCore.
1426 (Enum.VerifyClsName): Optimized for better performance.
1428 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1430 * report.cs: Renamed Error_T to Error and changed all
1433 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1435 * class.cs (TypeContainer.IndexerArrayList): New inner class
1436 container for indexers.
1437 (TypeContainer.DefaultIndexerName): New constant for default
1438 indexer name. Replaced all "Item" with this constant.
1439 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1441 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1442 DefaultMemberAttribute constructor.
1444 2004-08-05 Martin Baulig <martin@ximian.com>
1446 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1449 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1451 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1452 multi platforms problem.
1454 * compiler.csproj: Included shared files.
1456 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1458 Fix bug 60333, 55971 in the more general way
1459 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1460 Added arg_type argument for constant conversion.
1461 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1463 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1466 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1467 OperatorArrayList, MethodCoreArrayList for typecontainer
1468 containers. Changed class member types to these new types.
1469 (MethodArrayList.DefineMembers): Added test for CS0659.
1471 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1473 * cfold.cs: Synchronize the folding with the code in expression.cs
1474 Binary.DoNumericPromotions for uint operands.
1476 * attribute.cs: Revert patch from Raja, it introduced a regression
1477 while building Blam-1.2.1 (hard to isolate a test case).
1479 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1483 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1485 (MethodCore.parent_method): New member. The method we're overriding
1486 if this is an override method.
1487 (MethodCore.CheckBase): Moved from Method class and made common.
1488 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1490 (MethodCore.CheckForDuplications): New abstract method. For custom
1491 member duplication search in a container
1492 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1493 method and its return type.
1494 (Event.conflict_symbol): New member. Symbol with same name in the
1498 (MemberCache.FindMemberWithSameName): New method. The method
1499 is looking for conflict with inherited symbols.
1501 2004-08-04 Martin Baulig <martin@ximian.com>
1503 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1505 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1507 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1509 * report.cs (Message): New enum for better error, warning reference in
1511 (MessageData): New inner abstract class. It generally handles printing of
1512 error and warning messages.
1513 Removed unused Error, Warning, Message methods.
1515 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1517 Fix for cs0592-8.cs test
1519 (Attributable.ValidAttributeTargets): Made public.
1520 (Attribute.ExplicitTarget): New member for explicit target value.
1521 (Attribute.CheckTargets): Now we translate explicit attribute
1522 target to Target here.
1524 2004-08-03 Ben Maurer <bmaurer@ximian.com>
1526 * ecore.cs (MethodGroupExpr): new IsBase property.
1528 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
1530 * delegate.cs (DelegateCreation): store a MethodGroupExpr
1531 rather than an instance expr.
1533 (DelegateCreation.Emit): Use the method group rather than
1534 the instance expression. Also, if you have base.Foo as the
1535 method for a delegate, make sure to emit ldftn, not ldftnvirt.
1537 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
1539 (NewDelegate.DoResolve): Only check for the existance of Invoke
1540 if the method is going to be needed. Use MethodGroupExpr.
1542 (NewDelegate.Emit): Remove, DelegateCreation implements this.
1544 * expression.cs: For pointer arith., make sure to use
1545 the size of the type, not the size of the pointer to
1548 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1551 * class.cs (Class): Added error CS0502 test.
1553 2004-08-03 John Luke <jluke@cfl.rr.com>
1554 Raja R Harinath <rharinath@novell.com>
1557 * attribute.cs (Attribute.complained_before): New flag.
1558 (Attribute.ResolveType, Attribute.Resolve),
1559 (Attribute.DefinePInvokeMethod): Set it.
1560 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1562 2004-08-03 Martin Baulig <martin@ximian.com>
1564 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1565 use a user-defined operator; we still need to do numeric
1566 promotions in case one argument is a builtin type and the other
1567 one has an implicit conversion to that type. Fixes #62322.
1569 2004-08-18 Martin Baulig <martin@ximian.com>
1571 * class.cs (Method.Define): Use the correct method name when
1572 creating the MethodBuilder for a generic method.
1574 2004-08-17 Martin Baulig <martin@ximian.com>
1576 * generic.cs (Constraints): Support type parameter constraints.
1578 2004-08-16 Martin Baulig <martin@ximian.com>
1580 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
1581 (Token.GENERIC_DIMENSION): New token; this is returned if we
1582 encounter an unbound generic type in a typeof() expression.
1584 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
1585 this token is only generated while parsing a typeof() expression.
1586 (typeof_expression): Removed the old unbound_type hack.
1588 * generic.cs (TypeArguments.IsUnbound): New public property.
1590 * decl.cs (MemberName): Added support for unbound types.
1592 2004-08-14 Martin Baulig <martin@ximian.com>
1595 (TypeManager.IsEqualGenericInstance): New static method.
1596 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
1597 just used to check accessibility, so follow the rules of 26.1.6.
1599 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
1600 ConstructedType instead of a TypeExpression if we have type arguments.
1602 * cs-parser.jay (typeof_expression): Support unbound generic types.
1604 * ecore.cs (UnboundTypeExpression): New public class.
1606 2004-08-12 Martin Baulig <martin@ximian.com>
1608 * typemanager.cs (TypeManager.IsNestedChildOf): Use
1609 TypeManager.IsEqual() rather than `=='.
1611 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
1612 generic instances as well.
1614 2004-08-12 Martin Baulig <martin@ximian.com>
1616 * expression.cs (Invocation.InferType): We can only infer method
1617 type parameters. Fixes #62647.
1619 2004-08-11 Martin Baulig <martin@ximian.com>
1621 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
1622 before resolving the base classes.
1624 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1626 * Makefile: install .mdb file too.
1628 2004-08-05 Martin Baulig <martin@ximian.com>
1630 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
1631 initializer, the current type is just the TypeBuilder, not the
1632 instantiated generic type.
1633 (FieldExpr.IsFieldInitializer): New public property.
1635 2004-08-04 Martin Baulig <martin@ximian.com>
1637 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1639 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1641 2004-08-03 Martin Baulig <martin@ximian.com>
1643 * class.cs (MethodData.Define): If we're an explicit
1644 implementation, remove the generic arity from the type name.
1646 2004-08-03 Martin Baulig <martin@ximian.com>
1648 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1649 use a user-defined operator; we still need to do numeric
1650 promotions in case one argument is a builtin type and the other
1651 one has an implicit conversion to that type. Fixes #62322.
1653 2004-08-02 Martin Baulig <martin@ximian.com>
1655 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
1657 (TypeContainer.GetClassBases): Return the unexpanded list of
1658 interfaces; we expand them later.
1659 (TypeContainer.DefineType): After creating the TypeBuilder, call
1660 TypeManager.ExpandInterfaces() to get an expanded and resolved
1663 * ecore.cs (TypeExpr.GetInterfaces): Removed
1665 * generics.cs (Constraints.InterfaceConstraints): Remove.
1666 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
1667 register the interface constraints.
1670 (TypeManager.AddUserType): Removed the `ifaces' argument.
1671 (TypeManager.AddTypeParameter): Likewise.
1672 (TypeManager.AddUserInterface): Removed, was unused.
1673 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
1674 `TypeExpr[]' array for the interfaces.
1675 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
1676 has been defined, returns a list of the resolved interfaces types.
1677 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
1678 (TypeManager.GetExplicitInterfaces): Likewise.
1680 2004-08-02 Martin Baulig <martin@ximian.com>
1682 * expression.cs (Invocation.EmitCall): If we're invoking a method
1683 on a type parameter, use the new `Constrained' prefix opcode.
1685 2004-08-02 Martin Baulig <martin@ximian.com>
1687 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1688 (LocalInfo.IsThis): New public property.
1689 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1691 2004-08-01 Martin Baulig <martin@ximian.com>
1693 * class.cs (TypeContainer.GetClassBases): Don't set the default
1694 here since we may get called from GetPartialBases().
1695 (TypeContainer.DefineType): If GetClassBases() didn't return a
1696 parent, use the default one.
1698 2004-07-30 Martin Baulig <martin@ximian.com>
1700 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1702 * class.cs (SourceMethod): New public class, derive from the
1703 symbol writer's ISourceMethod.
1704 (Method): Use the new symbol writer API.
1706 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1707 as argument and use the new symbol writer.
1710 (SourceFile): Implement the symbol writer's ISourceFile.
1711 (Location.SymbolDocument): Removed.
1712 (Location.SourceFile): New public property.
1714 * symbolwriter.cs: Use the new symbol writer API.
1716 2004-07-30 Raja R Harinath <rharinath@novell.com>
1718 * Makefile (install-local): Remove. Functionality moved to
1721 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1723 * Makefile: Install mcs.exe.config file together with mcs.exe.
1724 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1725 correct runtime version.
1727 2004-07-25 Martin Baulig <martin@ximian.com>
1730 (TypeContainer.RegisterOrder): Removed, this was unused.
1731 (TypeContainer, interface_order): Removed.
1732 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1733 TypeContainer as argument since we can also be called with a
1734 `PartialContainer' for a partial class/struct/interface.
1735 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
1736 of checking whether we're an `Interface' - we could be a
1738 (PartialContainer.Register): Override; call
1739 AddClass()/AddStruct()/AddInterface() on our parent.
1741 * cs-parser.jay (interface_member_declaration): Add things to the
1742 `current_container', not the `current_class'.
1744 * rootcontext.cs (RegisterOrder): The overloaded version which
1745 takes an `Interface' was unused, removed.
1747 * typemanager.cs (TypeManager.LookupInterface): Return a
1748 `TypeContainer', not an `Interface'.
1749 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
1750 contain a `PartialContainer' for an interface, so check it's
1751 `Kind' to figure out what it is.
1753 2004-07-25 Martin Baulig <martin@ximian.com>
1755 * class.cs (Class.DefaultTypeAttributes): New public constant.
1756 (Struct.DefaultTypeAttributes): Likewise.
1757 (Interface.DefaultTypeAttributes): Likewise.
1758 (PartialContainer.TypeAttr): Override this and add the
1759 DefaultTypeAttributes.
1761 2004-07-25 Martin Baulig <martin@ximian.com>
1763 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
1764 we can just use the `Parent' field instead.
1766 2004-07-25 Martin Baulig <martin@ximian.com>
1768 * class.cs (TypeContainer.Emit): Renamed to EmitType().
1770 2004-07-25 Martin Baulig <martin@ximian.com>
1772 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
1773 our parts before defining any methods.
1774 (TypeContainer.VerifyImplements): Make this virtual.
1775 (ClassPart.VerifyImplements): Override and call VerifyImplements()
1776 on our PartialContainer.
1778 2004-07-25 Martin Baulig <martin@ximian.com>
1780 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
1782 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
1783 argument, we can just use the `Parent' field instead.
1786 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
1787 (MemberBase.DoDefine): Likewise.
1789 2004-07-24 Martin Baulig <martin@ximian.com>
1791 * decl.cs (MemberCore.Parent): New public field.
1792 (DeclSpace.Parent): Moved to MemberCore.
1794 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
1795 (MemberBase.ctor): Added TypeContainer argument, pass it to our
1797 (FieldBase, Field, Operator): Likewise.
1798 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
1799 (EventField, Event): Likewise.
1801 2004-07-23 Martin Baulig <martin@ximian.com>
1803 * class.cs (PartialContainer): New public class.
1804 (ClassPart): New public class.
1805 (TypeContainer): Added support for partial classes.
1806 (TypeContainer.GetClassBases): Splitted some of the functionality
1807 out into GetNormalBases() and GetPartialBases().
1809 * cs-tokenizer.cs (Token.PARTIAL): New token.
1810 (Tokenizer.consume_identifier): Added some hacks to recognize
1811 `partial', but only if it's immediately followed by `class',
1812 `struct' or `interface'.
1814 * cs-parser.jay: Added support for partial clases.
1816 2004-07-23 Martin Baulig <martin@ximian.com>
1818 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
1819 a `DeclSpace' and also made it readonly.
1820 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
1821 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
1822 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
1824 * cs-parser.jay: Pass the `current_class', not the
1825 `current_container' (at the moment, this is still the same thing)
1826 to a new Method, Property, Event, Indexer or Constructor.
1828 2004-07-23 Martin Baulig <martin@ximian.com>
1830 * cs-parser.jay (CSharpParser): Added a new `current_class' field
1831 and removed the `current_interface' one.
1832 (struct_declaration, class_declaration, interface_declaration):
1833 Set `current_class' to the newly created class/struct/interface;
1834 set their `Bases' and call Register() before parsing their body.
1836 2004-07-23 Martin Baulig <martin@ximian.com>
1838 * class.cs (Kind): New public enum.
1839 (TypeContainer): Made this class abstract.
1840 (TypeContainer.Kind): New public readonly field.
1841 (TypeContainer.CheckDef): New public method; moved here from
1843 (TypeContainer.Register): New public abstract method.
1844 (TypeContainer.GetPendingImplementations): New public abstract
1846 (TypeContainer.GetClassBases): Removed the `is_class' and
1847 `is_iface' parameters.
1848 (TypeContainer.DefineNestedTypes): Formerly known as
1850 (ClassOrStruct): Made this class abstract.
1852 * tree.cs (RootTypes): New public type.
1854 2004-07-20 Martin Baulig <martin@ximian.com>
1856 * tree.cs (Tree.RecordNamespace): Removed.
1857 (Tree.Namespaces): Removed.
1859 * rootcontext.cs (RootContext.IsNamespace): Removed.
1861 * cs-parser.jay (namespace_declaration): Just create a new
1862 NamespaceEntry here.
1864 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
1866 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
1867 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
1868 entry to make sure it runs in the correct runtime version.
1870 2004-07-18 Martin Baulig <martin@ximian.com>
1872 * generic.cs (ConstructedType.CheckConstraints): Improved
1873 constraints checking.
1875 2004-07-18 Martin Baulig <martin@ximian.com>
1877 * expression.cs (Invocation.BetterMethod): Call
1878 TypeManager.TypeToCoreType() on all types and removed my previous
1879 hack; we're already doig the right thing here.
1881 2004-07-17 Martin Baulig <martin@ximian.com>
1883 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
1885 2004-07-16 Martin Baulig <martin@ximian.com>
1887 * iterators.cs: Added generics support.
1889 2004-07-16 Martin Baulig <martin@ximian.com>
1891 * iterators.cs: Rewrote this. We're now using one single Proxy
1892 class for both the IEnumerable and the IEnumerator interface and
1893 `Iterator' derives from Class so we can use the high-level API.
1895 * class.cs (TypeContainer.AddIterator): New method.
1896 (TypeContainer.DoDefineType): New protected virtual method, which
1897 is called from DefineType().
1898 (TypeContainer.DoDefineMembers): Call DefineType() and
1899 DefineMembers() on all our iterators.
1900 (TypeContainer.Emit): Call Emit() on all our iterators.
1901 (TypeContainer.CloseType): Call CloseType() on all our iterators.
1903 * codegen.cs (EmitContext.CurrentIterator): New public field.
1905 2004-07-15 Martin Baulig <martin@ximian.com>
1908 (TypeManager.not_supported_exception_type): New type.
1910 2004-07-14 Martin Baulig <martin@ximian.com>
1913 (TypeManager.generic_ienumerable_type): New type.
1914 (TypeManager.generic_ienumerator_type): New type.
1917 (RootContext.interfaces_first_stage): Added
1918 "System.Collections.Generic.IEnumerator`1" and
1919 "System.Collections.Generic.IEnumerable`1".
1921 2004-07-14 Martin Baulig <martin@ximian.com>
1923 * iterators.cs: Use real error numbers.
1925 2004-07-14 Martin Baulig <martin@ximian.com>
1927 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
1928 requires this to be a System.Collection.IEnumerable and not a
1929 class implementing that interface.
1930 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
1932 2004-07-13 Marek Safar <marek.safar@seznam.cz>
1934 * class.cs: Fixed previous fix, it broke some error tests.
1936 2004-07-12 Martin Baulig <martin@ximian.com>
1938 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
1941 2004-07-14 Martin Baulig <martin@ximian.com>
1943 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
1944 an exclamation mark (!) for the generic arity to reflect the
1945 latest spec changes; ie. use "System.Collections.Generic.IList`1".
1947 2004-07-13 Martin Baulig <martin@ximian.com>
1949 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
1950 specifiers being part of a type argument.
1952 2004-07-13 Martin Baulig <martin@ximian.com>
1954 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
1955 name for generic types.
1957 2004-07-13 Martin Baulig <martin@ximian.com>
1959 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
1962 2004-07-09 Miguel de Icaza <miguel@ximian.com>
1964 * assign.cs (LocalTemporary): Add new argument: is_address,If
1965 `is_address' is true, then the value that we store is the address
1966 to the real value, and not the value itself.
1968 * ecore.cs (PropertyExpr): use the new local temporary
1969 stuff to allow us to handle X.Y += z (where X is a struct)
1971 2004-07-08 Martin Baulig <martin@ximian.com>
1973 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
1974 not always return, just like we're doing in Using.Resolve().
1976 2004-07-07 Miguel de Icaza <miguel@ximian.com>
1978 * cs-parser.jay (fixed_statement): flag this as Pinned.
1980 2004-07-06 Miguel de Icaza <miguel@ximian.com>
1982 * typemanager.cs (TypeManager): Removed MakePinned method, this
1983 mechanism is replaced with the .NET 2.x compatible mechanism of
1984 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
1986 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
1987 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
1988 `IsFixed' property which has a different meaning.
1990 2004-07-02 Raja R Harinath <rharinath@novell.com>
1992 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
1993 visible from inside a nested class, not just the names of the
1994 immediately enclosing class.
1997 2004-06-24 Raja R Harinath <rharinath@novell.com>
1999 * expression.cs (BetterConversion): Remove buggy special-case
2000 handling of "implicit constant expression conversions". At this
2001 point, we already know that the conversion is possible -- we're
2002 only checking to see which is better.
2004 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2006 * cs-parser.jay: Added error CS0210 test.
2008 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2010 * cs-parser.jay: Added error CS0134 test.
2012 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2015 * cs-parser.jay: Added error CS0145 test.
2017 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2019 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2021 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2023 * expression.cs (StackAlloc.Resolve): The argument may not
2024 be a constant; deal with this case.
2026 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2028 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2029 GetIndexerAttributeValue.
2030 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2032 * class.cs (Indexer.Define): Added error tests for CS0415,
2035 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2037 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2040 2004-06-23 Martin Baulig <martin@ximian.com>
2042 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2043 neither return nor throw, reset the barrier as well. Fixes #60457.
2045 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2047 * class.cs : EventAttributes is now set to None by default.
2048 This fixes bug #60459.
2050 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2053 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2054 Don't throw exception but return null (it's sufficient now).
2056 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2058 * typemanager.cs (GetArgumentTypes): Faster implementation.
2060 2004-06-18 Martin Baulig <martin@ximian.com>
2062 * attribute.cs (Attribute.Resolve): Check whether we're an
2063 EmptyCast which a Constant child. Fixes #60333.
2065 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2067 * statement.cs (EmitCollectionForeach): Account for the fact that
2068 not all valuetypes are in areas which we can take the address of.
2069 For these variables, we store to a temporary variable. Also, make
2070 sure that we dont emit a `callvirt' on a valuetype method.
2072 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2074 * expression.cs (StackAlloc.DoReSolve): Added test for
2075 negative parameter (CS0247).
2077 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2080 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2082 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2085 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2088 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2090 Fix bug #58254 & cs1555.cs, cs1556.cs
2091 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2093 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2095 * cs-parser.jay: Added error CS1669 test for indexers.
2097 2004-06-18 Martin Baulig <martin@ximian.com>
2099 * generics.cs (GenericMethod.ctor): Don't take an Attributes
2100 argument. Fixes #60441.
2102 2004-06-16 Ben Maurer <bmaurer@ximian.com>
2103 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
2104 The name needs to have the actual name of the method in order
2105 for other tests (such as the one in OverloadResolve for Invoke
2106 on a delegate) to work. As well, it does not really help
2107 error reporting because the method group had multiple methods.
2108 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
2109 Make profiling work.
2111 2004-06-13 Martin Baulig <martin@ximian.com>
2113 * cs-parser.jay: Don't allow generic attributes.
2115 2004-06-13 Martin Baulig <martin@ximian.com>
2117 * class.cs (MemberBase.DoDefineBase): New protected method.
2118 (MemberBase.DoDefine): Compute the `flags' in the new
2119 DoDefineBase() which must be called first.
2120 (Method.Define): Call DoDefineBase() first so we have the flags
2121 when defining the generic method.
2123 * cs-parser.jay (interface_method_declaration): Support generic methods.
2125 2004-06-13 Martin Baulig <martin@ximian.com>
2127 * decl.cs (TypeName): Removed.
2128 (MemberName): Removed TypeName and MemberNow; now we just have
2131 * cs-parser.jay: Don't distinguish between type arguments and type
2132 parameters in the grammar and simplified the rules a bit. The
2133 reduce/reduce conflicts are now gone (except the one we inherited
2136 2004-06-11 Martin Baulig <martin@ximian.com>
2138 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2139 call this twice: for params and varargs methods.
2141 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2144 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2146 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2148 * attribute.cs (Attribute.GetValidTargets): Made public.
2151 (AbstractPropertyEventMethod): New class for better code sharing.
2152 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2154 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2156 2004-06-09 Martin Baulig <martin@ximian.com>
2158 * cs-parser.jay: Removed a reduce/reduce conflict.
2160 2004-06-03 Martin Baulig <martin@ximian.com>
2162 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
2163 GetSimpleName() and return a SimpleName.
2165 * ecore.cs (SimpleName.Arguments): New public field.
2166 (SimpleName): Added overloaded ctor which takes an additional
2167 TypeArguments argument.
2168 (SimpleName.SimpleNameResolve): Added support for generic methods.
2169 (MethodGroupExpr.ResolveGeneric): New public method. The code was
2170 formerly in MemberAccess.DoResolve(), but we also need it in
2171 SimpleNameResolve().
2173 * expression.cs (MemberAccess.DoResolve): Use the new
2174 MethodGroupExpr.ResolveGeneric().
2176 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2178 * decl.cs: If possible, use lookuptypedirect here. We can only do
2179 this if there is no `.' after the namespace. Avoids using
2180 LookupType, which does lots of slow processing.
2181 (FindNestedType) New method, does what it says :-).
2182 * namespace.cs: use LookupTypeDirect.
2183 * rootcontext.cs: use membercache, if possible.
2184 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2186 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2189 According to the spec,
2191 In a member access of the form E.I, if E is a single identifier,
2192 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2193 field, property, localvariable, or parameter with the same type as
2194 the meaning of E as a type-name (§3.8), then both possible
2195 meanings of E are permitted.
2197 We did not check that E as a simple-name had the same type as E as
2200 This trivial check gives us 5-7% on bootstrap time.
2202 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2204 * expression.cs (Invocation.OverloadResolve): Avoid the
2205 use of hashtables and boxing here by allocating on demand.
2207 2004-05-30 Martin Baulig <martin@ximian.com>
2209 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2210 we're doing a silent lookup. Don't try to lookup nested types in
2211 TypeManager.object_type (thanks to Ben Maurer).
2213 2004-05-30 Martin Baulig <martin@ximian.com>
2215 Committing a patch from Ben Maurer.
2217 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2219 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2221 * convert.cs: add a trivial cache for overload operator resolution.
2223 2004-05-31 Marek Safar <marek.safar@seznam.cz>
2226 (AttributeTester.GetObsoleteAttribute): Returns instance of
2227 ObsoleteAttribute when type is obsolete.
2230 (TypeContainer.VerifyObsoleteAttribute): Override.
2231 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2232 (MethodCode.VerifyObsoleteAttribute): Override.
2233 (MemberBase.VerifyObsoleteAttribute): Override.
2236 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2237 and report proper error.
2240 (Delegate.VerifyObsoleteAttribute): Override.
2243 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2244 and report proper error.
2245 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2248 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2252 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2253 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2254 Added test for ObsoleteAttribute.
2257 (Catch): Derived from Statement.
2259 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2261 * decl.cs: If possible, use lookuptypedirect here. We can only do
2262 this if there is no `.' after the namespace. Avoids using
2263 LookupType, which does lots of slow processing.
2264 (FindNestedType) New method, does what it says :-).
2265 * namespace.cs: use LookupTypeDirect.
2266 * rootcontext.cs: use membercache, if possible.
2267 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2269 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2272 According to the spec,
2274 In a member access of the form E.I, if E is a single identifier,
2275 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2276 field, property, localvariable, or parameter with the same type as
2277 the meaning of E as a type-name (§3.8), then both possible
2278 meanings of E are permitted.
2280 We did not check that E as a simple-name had the same type as E as
2283 This trivial check gives us 5-7% on bootstrap time.
2285 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2287 Fixed bug #59071 & cs0160.cs
2288 * statement.cs (Try.Resolve): Check here whether order of catch
2289 clauses matches their dependencies.
2291 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2294 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
2297 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2299 * expression.cs (Invocation.OverloadResolve): Avoid the
2300 use of hashtables and boxing here by allocating on demand.
2302 2004-05-30 Martin Baulig <martin@ximian.com>
2304 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2305 we're doing a silent lookup. Don't try to lookup nested types in
2306 TypeManager.object_type (thanks to Ben Maurer).
2308 2004-05-30 Martin Baulig <martin@ximian.com>
2310 Committing a patch from Ben Maurer.
2312 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2314 2004-05-29 Martin Baulig <martin@ximian.com>
2316 * class.cs (IMethodData.ShouldIgnore): New method.
2318 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2319 `Location' argument, we don't need it anywhere. Use
2320 `IMethodData.ShouldIgnore ()' instead of
2321 `MethodData.GetMethodFlags ()'.
2322 (TypeManager.AddMethod): Removed.
2323 (TypeManager.AddMethod2): Renamed to AddMethod.
2325 2004-05-29 Martin Baulig <martin@ximian.com>
2327 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2329 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2330 converting from a class type S to an interface type and we already
2331 have an object on the stack, don't box it again. Fixes #52578.
2333 2004-05-29 Martin Baulig <martin@ximian.com>
2335 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2336 Added support for `params' parameters. Fixes #59267.
2338 2004-05-29 Martin Baulig <martin@ximian.com>
2340 * literal.cs (NullPointer): Provide a private .ctor which sets
2341 `type' to TypeManager.object_type. Fixes #59048.
2343 2004-05-29 Martin Baulig <martin@ximian.com>
2345 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2346 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2348 * ecore.cs (EventExpr.instance_expr): Make the field private.
2350 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2352 Fixed bug #50080 & cs0214-2.cs
2353 * expression.cs (Cast.DoResolve): Check unsafe context here.
2355 * statement.cs (Resolve.DoResolve): Likewise.
2357 2004-05-26 Martin Baulig <martin@ximian.com>
2359 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2361 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2362 (RootContext.LookupType): Pass down the `silent' flag.
2364 2004-05-25 Martin Baulig <martin@ximian.com>
2367 (MethodGroupExpr.IdenticalTypeName): New public property.
2368 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2369 expression actually refers to a type.
2371 2004-05-25 Martin Baulig <martin@ximian.com>
2373 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2374 for #56176 and made it actually work.
2376 2004-05-25 Martin Baulig <martin@ximian.com>
2378 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2379 (FieldExpr, PropertyExpr): Override and implement
2380 CacheTemporaries. Fixes #52279.
2382 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2384 * location.cs: In the new compiler listing a file twice is a
2385 warning, not an error.
2387 2004-05-24 Martin Baulig <martin@ximian.com>
2389 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2390 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2392 2004-05-24 Martin Baulig <martin@ximian.com>
2394 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2395 walking the `using' list. Fixes #53921.
2397 2004-05-24 Martin Baulig <martin@ximian.com>
2399 * const.cs (Const.LookupConstantValue): Added support for
2400 EmptyCast's; fixes #55251.
2402 2004-05-24 Martin Baulig <martin@ximian.com>
2404 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2405 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2406 which does the CS0135 check. The reason is that we first need to
2407 check whether the variable actually exists.
2409 2004-05-24 Martin Baulig <martin@ximian.com>
2411 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2412 than RootContext.LookupType() to find the explicit interface
2415 2004-05-24 Raja R Harinath <rharinath@novell.com>
2417 * Makefile: Simplify. Use executable.make.
2418 * mcs.exe.sources: New file. List of sources of mcs.exe.
2420 2004-05-24 Anders Carlsson <andersca@gnome.org>
2424 Use the invariant culture when doing String.Compare for CLS case
2427 2004-05-23 Martin Baulig <martin@ximian.com>
2429 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2430 don't have any dots. Fixes #52622, added cs0246-8.cs.
2432 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2434 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2436 * class.cs (MemberBase.Define): Reuse MemberType member for
2437 resolved type. Other methods can use it too.
2439 2004-05-23 Martin Baulig <martin@ximian.com>
2441 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2442 the variable also exists in the current block (otherwise, we need
2443 to report a CS0103). Fixes #58670.
2445 2004-05-23 Martin Baulig <martin@ximian.com>
2447 * flowanalysis.cs (Reachability.Reachable): Compute this
2448 on-the-fly rather than storing it as a field.
2450 2004-05-23 Martin Baulig <martin@ximian.com>
2452 * flowanalysis.cs (Reachability.And): Manually compute the
2453 resulting `barrier' from the reachability.
2455 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2458 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2459 instance of ObsoleteAttribute when symbol is obsolete.
2462 (IMethodData): Extended interface for ObsoleteAttribute support.
2464 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2466 * attribute.cs: Fix bug #55970
2468 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2472 (GetObsoleteAttribute): New method. Creates the instance of
2474 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2475 ObsoleteAttribute when member is obsolete.
2476 (AttributeTester.Report_ObsoleteMessage): Common method for
2477 Obsolete error/warning reporting.
2480 (TypeContainer.base_classs_type): New member for storing parent type.
2483 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2484 for this MemberCore.
2486 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2488 * attribute.cs, const.cs: Fix bug #58590
2490 2004-05-21 Martin Baulig <martin@ximian.com>
2492 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2493 out parameters if the end of the method is unreachable. Fixes
2496 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2498 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2499 Hari was right, why extra method.
2501 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2503 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2505 2004-05-20 Martin Baulig <martin@ximian.com>
2507 * delegate.cs: Convert this file to Unix mode - like the original
2510 2004-05-20 Martin Baulig <martin@ximian.com>
2512 * attribute.cs: Convert this file to Unix mode - like the original
2515 2004-05-19 Marek Safar <marek.safar@seznam.cz>
2517 Fix bug #58688 (MCS does not report error when the same attribute
2520 * attribute.cs (Attribute.Emit): Distinction between null and default.
2522 2004-05-19 Raja R Harinath <rharinath@novell.com>
2524 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
2525 of a top-level attribute without an attribute target.
2526 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
2528 (Attribute.Conditional_GetConditionName),
2529 (Attribute.Obsolete_GetObsoleteMessage): Update.
2530 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
2531 part of ScanForIndexerName.
2532 (Attribute.CanIgnoreInvalidAttribute): New function.
2533 (Attribute.ScanForIndexerName): Move to ...
2534 (Attributes.ScanForIndexerName): ... here.
2535 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
2536 (Attributes.Search): New internal variant that can choose not to
2537 complain if types aren't resolved. The original signature now
2539 (Attributes.GetClsCompliantAttribute): Use internal variant, with
2540 complaints suppressed.
2541 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
2542 only if it not useful.
2543 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
2544 top-level for attributes that are shared between the assembly
2545 and a top-level class.
2546 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
2547 * class.cs: Update to reflect changes.
2548 (DefineIndexers): Fuse loops.
2549 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2550 a couple more variants of attribute names.
2552 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2554 Fix bug #52585 (Implemented explicit attribute declaration)
2557 (Attributable.ValidAttributeTargets): New abstract method. It gets
2558 list of valid attribute targets for explicit target declaration.
2559 (Attribute.Target): It holds target itself.
2560 (AttributeSection): Removed.
2561 (Attribute.CheckTargets): New method. It checks whether attribute
2562 target is valid for the current element.
2565 (EventProperty): New class. For events that are declared like
2566 property (with add and remove accessors).
2567 (EventField): New class. For events that are declared like field.
2570 * cs-parser.jay: Implemented explicit attribute target declaration.
2572 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2573 Override ValidAttributeTargets.
2576 (ReturnParameter): Class for applying custom attributes on
2578 (ParameterAtribute): New class. Class for applying custom
2579 attributes on the parameter type.
2581 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2583 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
2586 (Method): Allow UNSAFE here.
2588 * modifiers.cs: Support unsafe reporting.
2590 2004-05-17 Marek Safar <marek.safar@seznam.cz>
2592 * decl.cs: Fix bug #58478.
2594 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2596 * statement.cs: When checking for unreachable code on an EmptyStatement,
2597 set the location. Fixes bug #58488.
2599 2004-05-13 Miguel de Icaza <miguel@ximian.com>
2601 * driver.cs: Add -pkg handling.
2603 From Gonzalo: UseShelLExecute=false
2605 2004-05-12 Marek Safar <marek.safar@seznam.cz>
2608 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
2610 (Attribute.IsClsCompliaceRequired): Moved to base for better
2612 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2613 when attribute is AttributeUsageAttribute.
2614 (Attribute.GetValidTargets): Simplified.
2615 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2616 attribute for this type.
2617 (Attribute.ApplyAttributes): Method renamed to Emit and make
2619 (GlobalAttributeSection): New class for special handling of global
2620 attributes (assembly, module).
2621 (AttributeSection.Emit): New method.
2623 * class.cs: Implemented Attributable abstract methods.
2624 (MethodCore.LabelParameters): Moved to Parameter class.
2625 (Accessor): Is back simple class.
2626 (PropertyMethod): Implemented Attributable abstract class.
2627 (DelegateMethod): Implemented Attributable abstract class.
2628 (Event): New constructor for disctintion between normal Event
2629 and Event with accessors.
2631 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
2633 * codegen.cs, const.cs, decl.cs, delegate.cs:
2634 (CommonAssemblyModulClass): Implemented Attributable abstract class
2637 * enum.cs: Implement IAttributeSupport interface.
2638 (EnumMember): New class for emum members. Implemented Attributable
2642 (ParameterBase): Is abstract.
2643 (ReturnParameter): New class for easier [return:] attribute handling.
2645 * typemanager.cs: Removed builder_to_attr.
2647 2004-05-11 Raja R Harinath <rharinath@novell.com>
2650 * attribute.cs (Attribute.GetPositionalValue): New function.
2651 * class.cs (TypeContainer.VerifyMembers): New function.
2652 (TypeContainer.Emit): Use it.
2653 (ClassOrStruct): New base class for Class and Struct.
2654 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
2655 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
2657 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
2658 then each non-static field should have a FieldOffset attribute.
2659 Otherwise, none of the fields should have a FieldOffset attribute.
2660 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
2661 and FieldOffset attributes.
2662 * typemanager.cs (TypeManager.struct_layout_attribute_type)
2663 (TypeManager.field_offset_attribute_type): New core types.
2664 (TypeManager.InitCoreTypes): Initialize them.
2666 2004-05-11 Michal Moskal <malekith@pld-linux.org>
2668 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
2669 Return correct type.
2672 2004-05-09 Miguel de Icaza <miguel@ximian.com>
2674 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
2675 be implicitly converted to ulong.
2677 * expression.cs: The logic for allowing operator &, | and ^ worked
2678 was wrong, it worked before because we did not report an error in
2679 an else branch. Fixes 57895.
2681 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
2682 allow volatile fields to be reference types.
2684 2004-05-07 Miguel de Icaza <miguel@ximian.com>
2686 * driver.cs: Add support for /debug-
2688 2004-05-07 Raja R Harinath <rharinath@novell.com>
2690 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
2691 Add a 'complain' parameter to silence errors.
2692 (Attribute.Resolve): Update to changes. Put in sanity check to catch
2693 silently overlooked type-resolutions.
2694 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
2696 (Attributes.Search): New function.
2697 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
2698 (Attributes.GetAttributeFullName): Remove hack.
2699 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
2700 Update to reflect changes.
2701 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
2702 Use Attributes.Search instead of nested loops.
2704 2004-05-07 Marek Safar <marek.safar@seznam.cz>
2707 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
2708 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
2709 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
2711 * report.cs: (Report.Warning): Renamed to Warning_T because of
2712 parameter collision.
2714 2004-05-05 Raja R Harinath <rharinath@novell.com>
2716 * expression.cs (MemberAccess.ResolveMemberAccess):
2717 Exit with non-zero status after Report.Error.
2718 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
2720 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
2722 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2724 * support.cs: Don't hang when the file is empty.
2726 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2728 * support.cs: In SeekableStreamReader, compute the preamble size of the
2729 underlying stream. Position changes should take into account that initial
2732 2004-05-03 Todd Berman <tberman@sevenl.net>
2734 * driver.cs: remove unused GetSysVersion function.
2736 2004-05-03 Todd Berman <tberman@sevenl.net>
2738 * driver.cs: Remove the hack from saturday, as well as the hack
2739 from jackson (LoadAssemblyFromGac), also adds the CWD to the
2740 link_paths to get that bit proper.
2742 2004-05-01 Todd Berman <tberman@sevenl.net>
2744 * driver.cs: Try a LoadFrom before a Load, this checks the current
2745 path. This is currently a bug in mono that is be fixed, however, this
2746 provides a workaround for now. This will be removed when the bug
2749 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
2751 * CryptoConvert.cs: Updated to latest version. Fix issue with
2752 incomplete key pairs (#57941).
2754 2004-05-01 Todd Berman <tberman@sevenl.net>
2756 * driver.cs: Remove '.' from path_chars, now System.* loads properly
2759 2004-04-30 Jackson Harper <jackson@ximian.com>
2761 * codegen.cs: Open keys readonly.
2763 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2765 * typemanager.cs: don't report cyclic struct layout when a struct
2766 contains 2 or more fields of the same type. Failed for Pango.AttrShape
2767 which has 2 Pango.Rectangle fields.
2769 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
2771 * expression.cs: Handle IntPtr comparisons with IL code
2772 rather than a method call.
2774 2004-04-29 Martin Baulig <martin@ximian.com>
2776 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
2777 the list of PropertyInfo's in class hierarchy and find the
2778 accessor. Fixes #56013.
2780 2004-04-29 Martin Baulig <martin@ximian.com>
2782 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
2784 2004-04-29 Martin Baulig <martin@ximian.com>
2786 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2788 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
2790 2004-04-29 Martin Baulig <martin@ximian.com>
2792 * class.cs (ConstructorInitializer.Resolve): Check whether the
2793 parent .ctor is accessible. Fixes #52146.
2795 2004-04-29 Martin Baulig <martin@ximian.com>
2797 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2799 * statement.cs (Using.EmitLocalVariableDecls): Use
2800 TypeManager.idisposable_type, not typeof (IDisposable).
2801 (Foreach.EmitCollectionForeach): Added support for valuetypes.
2803 2004-04-29 Martin Baulig <martin@ximian.com>
2805 * class.cs (Event.Define): Don't emit the field and don't set
2806 RTSpecialName and SpecialName for events on interfaces. Fixes
2809 2004-04-29 Raja R Harinath <rharinath@novell.com>
2811 Refactor Attribute.ApplyAttributes.
2812 * attribute.cs (Attributable): New base class for objects that can
2813 have Attributes applied on them.
2814 (Attribute): Make AttributeUsage fields public.
2815 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
2816 (Attribute.IsInternalCall): New property.
2817 (Attribute.UsageAttr): Convert to a public read-only property.
2818 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
2819 (Attribute.ResolveType, Attribute.Resolve)
2820 (Attribute.ScanForIndexerName): Update to reflect changes.
2821 (Attribute.CheckAttributeTarget): Re-format.
2822 (Attribute.ApplyAttributes): Refactor, to various
2823 Attributable.ApplyAttributeBuilder methods.
2824 * decl.cs (MemberCore): Make Attributable.
2825 * class.cs (Accessor): Make Attributable.
2826 (MethodData.ApplyAttributes): Use proper attribute types, not
2828 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
2829 (TypeContainer.ApplyAttributeBuilder)
2830 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
2831 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
2832 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
2833 (Operator.ApplyAttributeBuilder): New factored-out methods.
2834 * const.cs (Const.ApplyAttributeBuilder): Likewise.
2835 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
2836 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
2837 * parameter.cs (ParameterBase): New Attributable base class
2838 that can also represent Return types.
2839 (Parameter): Update to the changes.
2841 2004-04-29 Jackson Harper <jackson@ximian.com>
2843 * driver.cs: Prefer the corlib system version when looking for
2844 assemblies in the GAC. This is still a hack, but its a better hack
2847 2004-04-29 Marek Safar <marek.safar@seznam.cz>
2849 * decl.cs, enum.cs: Improved error 3005 reporting.
2851 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
2852 (related_symbols): New private member for list of symbols
2853 related to reported error/warning.
2855 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
2857 2004-04-29 Martin Baulig <martin@ximian.com>
2859 * ecore.cs (Expression.Constantify): If we're an enum and
2860 TypeManager.TypeToCoreType() doesn't give us another type, use
2861 t.UnderlyingSystemType. Fixes #56178.
2863 2004-04-29 Martin Baulig <martin@ximian.com>
2865 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
2866 interfaces and for each interface, only add members directly
2867 declared in that interface. Fixes #53255.
2869 2004-04-28 Martin Baulig <martin@ximian.com>
2871 * expression.cs (ConditionalLogicalOperator): Use a temporary
2872 variable for `left' to avoid that we evaluate it more than once;
2875 2004-04-28 Martin Baulig <martin@ximian.com>
2877 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
2880 2004-04-28 Martin Baulig <martin@ximian.com>
2882 * statement.cs (LocalInfo.Resolve): Check whether the type is not
2885 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
2886 whether the type is not void (CS1547).
2888 2004-04-28 Martin Baulig <martin@ximian.com>
2890 * expression.cs (Unary.DoResolveLValue): Override this and report
2891 CS0131 for anything but Operator.Indirection.
2893 2004-04-28 Martin Baulig <martin@ximian.com>
2895 Committing a patch from Ben Maurer; see bug #50820.
2897 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2900 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2903 2004-04-28 Martin Baulig <martin@ximian.com>
2905 Committing a patch from Ben Maurer; see bug #50820.
2907 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2910 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2913 2004-04-28 Martin Baulig <martin@ximian.com>
2915 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
2916 (Block.AddLabel): Call DoLookupLabel() to only search in the
2919 2004-04-28 Martin Baulig <martin@ximian.com>
2921 * cfold.cs (ConstantFold.BinaryFold): Added special support for
2922 comparing StringConstants and NullLiterals in Equality and Inequality.
2924 2004-04-28 Jackson Harper <jackson@ximian.com>
2926 * driver.cs: Attempt to load referenced assemblies from the
2927 GAC. This is the quick and dirty version of this method that
2928 doesnt take into account versions and just takes the first
2929 canidate found. Will be good enough for now as we will not have more
2930 then one version installed into the GAC until I update this method.
2932 2004-04-28 Martin Baulig <martin@ximian.com>
2934 * typemanager.cs (TypeManager.CheckStructCycles): New public
2935 static method to check for cycles in the struct layout.
2937 * rootcontext.cs (RootContext.PopulateTypes): Call
2938 TypeManager.CheckStructCycles() for each TypeContainer.
2939 [Note: We only need to visit each type once.]
2941 2004-04-28 Martin Baulig <martin@ximian.com>
2943 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
2945 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
2946 success and added `out object value'. Use a `bool resolved' field
2947 to check whether we've already been called rather than
2948 `ConstantValue != null' since this breaks for NullLiterals.
2950 2004-04-28 Raja R Harinath <rharinath@novell.com>
2952 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
2953 setting of this flag, since the 'set' method may be non-public.
2955 2004-04-28 Raja R Harinath <rharinath@novell.com>
2957 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
2958 check on current_vector.Block.
2960 2004-04-27 Martin Baulig <martin@ximian.com>
2962 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
2963 a field initializer. Fixes #56459.
2965 2004-04-27 Martin Baulig <martin@ximian.com>
2967 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
2968 we're not attempting to use an indexer. Fixes #52154.
2970 2004-04-27 Martin Baulig <martin@ximian.com>
2972 * statement.cs (Return): Don't create a return label if we don't
2973 need it; reverts my change from January 20th. Thanks to Ben
2976 2004-04-27 Martin Baulig <martin@ximian.com>
2978 According to the spec, `goto' can only leave a nested scope, but
2981 * statement.cs (Block.LookupLabel): Only lookup in the current
2982 block, don't recurse into parent or child blocks.
2983 (Block.AddLabel): Check in parent and child blocks, report
2984 CS0140/CS0158 if we find a duplicate.
2985 (Block): Removed this indexer for label lookups.
2986 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
2987 this already does the error reporting for us.
2990 (FlowBranching.UsageVector.Block): New public variable; may be null.
2991 (FlowBranching.CreateSibling): Added `Block' argument.
2992 (FlowBranching.LookupLabel): New public virtual method. Lookup a
2993 label for the target of a `goto' and check whether we're not
2994 leaving a `finally'.
2996 2004-04-27 Martin Baulig <martin@ximian.com>
2998 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2999 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3002 2004-04-27 Martin Baulig <martin@ximian.com>
3004 * statement.cs (Block.AddLabel): Also check for implicit blocks
3005 and added a CS0158 check.
3007 2004-04-27 Martin Baulig <martin@ximian.com>
3009 * flowanalysis.cs (FlowBranchingLoop): New class.
3010 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3011 UsageVector's instead of an ArrayList.
3012 (FlowBranching.Label): Likewise.
3013 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3014 (FlowBranching.AddBreakVector): New method.
3016 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3018 * attribute.cs: Small regression fix: only convert the type if we
3019 the type is different, fixes System.Drawing build.
3021 2004-04-27 Martin Baulig <martin@ximian.com>
3023 * attribute.cs (Attribute.Resolve): If we have a constant value
3024 for a named field or property, implicity convert it to the correct
3027 2004-04-27 Raja R Harinath <rharinath@novell.com>
3029 * statement.cs (Block.Block): Implicit blocks share
3030 'child_variable_names' fields with parent blocks.
3031 (Block.AddChildVariableNames): Remove.
3032 (Block.AddVariable): Mark variable as "used by a child block" in
3033 every surrounding block.
3034 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3035 been used in a child block, complain about violation of "Invariant
3036 meaning in blocks" rule.
3037 * cs-parser.jay (declare_local_variables): Don't use
3038 AddChildVariableNames.
3039 (foreach_statement): Don't create an implicit block: 'foreach'
3042 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3044 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3045 converting from 0L to ulong. Fixes 57522.
3047 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3049 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3050 derived class hides via 'new' keyword field from base class (test-242.cs).
3051 TODO: Handle this in the more general way.
3053 * class.cs (CheckBase): Ditto.
3055 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3057 * decl.cs (caching_flags): New member for storing cached values
3059 (MemberCore.Flags): New enum where bit flags for caching_flags
3061 (MemberCore.cls_compliance): Moved to caching_flags.
3062 (DeclSpace.Created): Moved to caching_flags.
3064 * class.cs: Use caching_flags instead of DeclSpace.Created
3066 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3068 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3069 if we are only a derived class, not a nested class.
3071 * typemanager.cs: Same as above, but do this at the MemberLookup
3072 level (used by field and methods, properties are handled in
3073 PropertyExpr). Allow for the qualified access if we are a nested
3076 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3078 * class.cs: Refactoring.
3079 (IMethodData): New inteface; Holds links to parent members
3080 to avoid member duplication (reduced memory allocation).
3081 (Method): Implemented IMethodData interface.
3082 (PropertyBase): New inner classes for get/set methods.
3083 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3084 (Event): New inner classes for add/remove methods.
3085 (Event.DelegateMethod): Implemented IMethodData interface.
3087 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3088 EmitContext (related to class.cs refactoring).
3090 2004-04-21 Raja R Harinath <rharinath@novell.com>
3092 * delegate.cs (Delegate.VerifyApplicability): If the number of
3093 arguments are the same as the number of parameters, first try to
3094 verify applicability ignoring any 'params' modifier on the last
3098 2004-04-08 Martin Baulig <martin@ximian.com>
3100 Merged latest changes into gmcs. Please keep this comment in
3101 here, it makes it easier for me to see what changed in MCS since
3102 the last time I merged.
3104 2004-04-16 Raja R Harinath <rharinath@novell.com>
3106 * class.cs (TypeContainer.AddIndexer): Use
3107 'ExplicitInterfaceName' to determine if interface name was
3108 explicitly specified. 'InterfaceType' is not initialized at this time.
3109 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3110 Indexers array is already in the required order. Initialize
3111 'IndexerName' only if there are normal indexers.
3112 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3113 (TypeContainer.Emit): Emit DefaultMember attribute only if
3114 IndexerName is initialized.
3117 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3119 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3122 2004-04-15 Raja R Harinath <rharinath@novell.com>
3124 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3128 * attribute.cs (Attribute.Resolve): Check for duplicate named
3132 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3134 * iterators.cs (MarkYield): track whether we are in an exception,
3135 and generate code accordingly. Use a temporary value to store the
3136 result for our state.
3138 I had ignored a bit the interaction of try/catch with iterators
3139 since their behavior was not entirely obvious, but now it is
3140 possible to verify that our behavior is the same as MS .NET 2.0
3144 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3146 * iterators.cs: Avoid creating temporaries if there is no work to
3149 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3150 Enumerations, use TypeManager.EnumToUnderlying and call
3153 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3156 (This.Emit): Use EmitContext.EmitThis to emit our
3159 (This.EmitAssign): Ditto.
3161 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3162 codepaths, we will move all the functionality into
3165 (FieldExpr.EmitAssign): Ditto.
3167 This fixes several hidden bugs that I uncovered while doing a code
3168 review of this today.
3170 * codegen.cs (EmitThis): reworked so the semantics are more clear
3171 and also support value types "this" instances.
3173 * iterators.cs: Changed so that for iterators in value types, we
3174 do not pass the value type as a parameter.
3176 Initialization of the enumerator helpers is now done in the caller
3177 instead of passing the parameters to the constructors and having
3178 the constructor set the fields.
3180 The fields have now `assembly' visibility instead of private.
3182 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3184 * expression.cs (Argument.Resolve): Check if fields passed as ref
3185 or out are contained in a MarshalByRefObject.
3187 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3188 another compiler type.
3190 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3192 * class.cs (Indexer.Define): use the new name checking method.
3193 Also, return false on an error.
3194 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3195 (is_identifier_[start/part]_character): make static.
3197 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3199 * expression.cs (Binary.ResolveOperator): Do no append strings
3200 twice: since we can be invoked more than once (array evaluation)
3201 on the same concatenation, take care of this here. Based on a fix
3202 from Ben (bug #56454)
3204 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3206 * codegen.cs: Fix another case where CS1548 must be reported (when
3207 delay-sign isn't specified and no private is available #56564). Fix
3208 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3209 error when MCS is used on the MS runtime and we need to delay-sign
3210 (which seems unsupported by AssemblyBuilder - see #56621).
3212 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3214 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3215 (TypeManager.ComputeNamespaces): Faster implementation for
3218 * compiler.csproj: Updated AssemblyName to mcs.
3220 2004-05-11 Jackson Harper <jackson@ximian.com>
3222 * Makefile: Preserve MONO_PATH
3224 2004-05-11 Jackson Harper <jackson@ximian.com>
3226 * Makefile: Use mono and mcs to build gmcs
3228 2004-05-03 Miguel de Icaza <miguel@ximian.com>
3230 * codegen.cs: Add patch from Robert Shade
3231 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
3234 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
3236 * CryptoConvert.cs: Updated to latest version. Fix issue with
3237 incomplete key pairs (#57941).
3239 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3241 * codegen.cs: Fix another case where CS1548 must be reported (when
3242 delay-sign isn't specified and no private is available #56564). Fix
3243 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3244 error when MCS is used on the MS runtime and we need to delay-sign
3245 (which seems unsupported by AssemblyBuilder - see #56621).
3247 2004-04-29 Jackson Harper <jackson@ximian.com>
3249 * Makefile: Set MONO_PATH to use the bootstrap corlib
3250 * driver.cs: Check the GAC for referenced assemblies.
3252 2004-04-29 Martin Baulig <martin@ximian.com>
3254 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
3256 2004-04-07 Martin Baulig <martin@ximian.com>
3258 * expression.cs (Binary.ResolveOperator): Added special case for
3259 Equality/Inequality between a type parameter and a null literal.
3261 2004-04-07 Martin Baulig <martin@ximian.com>
3263 * convert.cs: Check null literal -> type parameter conversions.
3265 2004-04-07 Martin Baulig <martin@ximian.com>
3267 * generic.cs (ConstructedType.CheckConstraints): Enforce the
3268 `class' and `struct' constraints.
3270 2004-04-07 Martin Baulig <martin@ximian.com>
3272 * generic.cs (SpecialConstraint): New public enum.
3273 (Constraints.Resolve): Added support for the `class' and `struct'
3276 * cs-parser.jay (type_parameter_constraint): Added support for the
3277 `class' and `struct' constraints.
3279 2004-04-07 Martin Baulig <martin@ximian.com>
3281 * support.cs (GenericConstraints): Replaced `Types' by
3282 `ClassConstraint' and `InterfaceConstraints'; added
3283 `HasClassConstraint'.
3285 2004-04-07 Martin Baulig <martin@ximian.com>
3288 (Constraints.InterfaceConstraints): New public property.
3289 (Constraints.Types): Make this property public
3290 (TypeParameter): Implement IMemberContainer.
3291 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
3292 instead of a TypeBuilder/MethodBuilder; pass the interface
3293 constraints to TypeManager.AddTypeParameter().
3294 (TypeParameter.DefineType): Just take an EmitContext and no
3295 TypeBuilder/MethodBuilder. Use the new public API.
3297 * typemanager.cs (TypeManager.AddTypeParameter): Added
3298 `TypeExpr[]' argument; add the interfaces to the
3299 `builder_to_ifaces' hash.
3300 (TypeManager.LookupMemberContainer): For
3301 GenericTypeParameterBuilders, get the TypeParameter from the
3302 `builder_to_type_param'.
3303 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
3304 the TypeParameter and call FindMembers on it.
3306 2004-04-07 Martin Baulig <martin@ximian.com>
3309 (MethodCore.GenericMethod): Moved this field here from Method.
3310 (MethodCore.IsDuplicateImplementation): Take the number of type
3311 parameters into account if we're a generic method.
3313 * expression.cs (Invocation.InferTypeArguments): Don't return true
3314 if `arguments' is null; we still need to check whether we actually
3315 don't need to infer anything in this case.
3316 (MemberAccess): Merged the functionality from GenericMemberAccess
3319 * generic.cs (GenericMemberAccess): Removed.
3321 2004-04-05 Martin Baulig <martin@ximian.com>
3323 * decl.cs (MemberCore): For generic classes, interfaces and
3324 structs, `Name' now includes the number of type parameters
3326 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
3327 encode the number of type arguments in the type name.
3329 * expression.cs (Expression.MemberLookup): Removed the
3330 `num_type_args' argument; we now encode the number of type
3331 arguments in the type name.
3333 * ecore.cs (SimpleName): Encode the number of type arguments in
3334 the type name itself.
3336 * generic.cs (ConstructedType): Likewise.
3338 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
3339 `MemberName'; we now include the number of type parameters in the
3342 * typemanager.cs (TypeManager.CheckGeneric): Removed.
3343 (TypeManager.MemberLookup): Removed the
3344 `num_type_args' argument; we now encode the number of type
3345 arguments in the type name.
3347 2004-04-03 Martin Baulig <martin@ximian.com>
3349 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
3350 (MemberCore.MemberName): Moved here from MemberBase.
3351 (DeclSpace.SetParameterInfo): Just take the constraints as an
3352 ArrayList; we already have the type parameters in our
3353 `MemberName'; also do the CS0080 reporting here.
3355 * cs-parser.jay (struct_declaration): Use `member_name' instead of
3356 `IDENTIFIER opt_type_parameter_list'; when constructing our
3357 `MemberName', it'll already include our type parameters.
3358 (class_declaration, interface_declaration): Likewise.
3359 (delegate_declaration): Likewise.
3360 (MakeName): Take a MemberName and return a MemberName.
3361 The following two changes are required to avoid shift/reduce conflicts:
3362 (member_name): Don't include a TypeName anymore; ie. this is now
3363 just 'IDENTIFIER opt_type_parameter_list'.
3364 (property_declaration, event_declaration): Use a
3365 `namespace_or_type_name' instead of a `member_name'.
3367 2004-04-03 Martin Baulig <martin@ximian.com>
3369 * decl.cs (MemberName): Renamed to `TypeName' and created a new
3371 (TypeName): Formerly known as MemberName.
3373 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
3374 instead of a `MemberName'.
3376 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
3377 (member_name): New rule; create a MemberName.
3379 2004-04-02 Martin Baulig <martin@ximian.com>
3381 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
3382 (CS0305 and CS0308).
3384 2004-04-02 Martin Baulig <martin@ximian.com>
3386 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
3387 support for nested types.
3389 2004-04-02 Martin Baulig <martin@ximian.com>
3391 * ecore.cs (IAlias): New public interface.
3392 (TypeExpr, TypeExpression): Implement IAlias.
3393 (TypeAliasExpression): New public class.
3395 * namespace.cs (Namespace): Implement IAlias.
3396 (Namespace.Lookup): Return an IAlias instead on an object.
3397 (Namespace.DefineName): Take an IAlias instead of an object.
3398 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
3400 (NamespaceEntry.UsingAlias): Take a Membername instead of an
3402 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
3404 (NamespaceEntry.Lookup): Likewise.
3406 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
3409 * decl.cs (DeclSpace): Implement IAlias.
3410 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
3412 * generic.cs (ConstructedType): Improved error checking.
3414 2004-04-02 Martin Baulig <martin@ximian.com>
3416 * convert.cs: Added type parameter conversions.
3419 (UnboxCast.Emit): Emit an `unbox.any' for type params.
3420 (ClassCast.Emit): If the source type is a type parameter, box it.
3421 If the target type is a type parameter, emit an `unbox.any'
3422 instead of a `classcast'.1
3424 2004-04-01 Martin Baulig <martin@ximian.com>
3426 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
3428 2004-04-01 Martin Baulig <martin@ximian.com>
3430 * generic.cs (ConstructedType.CheckConstraints): Use
3431 Convert.ImplicitStandardConversionExists(); user-defined implicit
3432 conversions are not allowed according to the spec.
3434 2004-03-30 Martin Baulig <martin@ximian.com>
3436 * expression.cs (New): Added support for type parameters.
3439 (TypeManager.activator_type): New public static field.
3440 (TypeManager.activator_create_instance): Likewise.
3442 2004-03-30 Martin Baulig <martin@ximian.com>
3444 * typemanager.cs (TypeManager.HasConstructorConstraint): New
3447 2004-03-30 Martin Baulig <martin@ximian.com>
3449 * generic.cs (ConstructedType.CheckConstraints): Actually follow
3450 the spec here: the argument type must be convertible to the
3453 2004-03-30 Martin Baulig <martin@ximian.com>
3456 (TypeParameter.Define, TypeParameter.DefineMethod): Call
3457 TypeManager.AddTypeParameter().
3458 (ConstructedType.CheckConstraints): Re-enable this and actually
3459 check whether we have a constructor constraint.
3462 (TypeManager.builder_to_type_param): New static field.
3463 (TypeManager.AddTypeParameter): New static method.
3464 (TypeManager.LookupTypeParameter): New public method.
3466 2004-03-30 Martin Baulig <martin@ximian.com>
3468 * generic.cs (TypeParameter.DefineType): Return a boolean and use
3469 the new API to actually define the constructor constraint.
3472 (TypeManager.new_constraint_attr_type): New static field.
3473 (TypeManager.InitCoreTypes): Initialize it.
3475 2004-03-30 Martin Baulig <martin@ximian.com>
3477 * generic.cs (Constraints): Completed error checking, use correct
3480 2004-03-29 Martin Baulig <martin@ximian.com>
3482 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
3484 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3485 public version which takes a `ParameterData pd' instead of an
3488 2004-03-29 Martin Baulig <martin@ximian.com>
3490 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
3493 2004-03-29 Martin Baulig <martin@ximian.com>
3495 * expression.cs (Argument.ResolveMethodGroup): If we're a
3496 ConstructedType, call GetMemberAccess() on it.
3498 2004-03-29 Martin Baulig <martin@ximian.com>
3500 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
3501 (MethodCore.CheckGenericOverride): When overriding a generic
3502 method, check whether the constraints match.
3504 * support.cs (GenericConstraints): New public interface.
3505 (ParameterData.GenericConstraints): New public method.
3507 * parameter.cs (Parameter.Resolve): Check whether we're a generic
3508 method parameter and compute our constraints if appropriate.
3509 (Parameter.GenericConstraints): New public property.
3511 * generic.cs (Constraints): Implement GenericConstraints.
3513 2004-03-29 Martin Baulig <martin@ximian.com>
3515 * decl.cs (MemberCache.FindMemberToOverride): Use
3516 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
3518 2004-03-29 Martin Baulig <martin@ximian.com>
3520 * generic.cs (GenericMethod.Define): Resolve our type parameters.
3522 2004-03-29 Martin Baulig <martin@ximian.com>
3524 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
3525 not allowed on non-generic declarations").
3527 2004-03-29 Martin Baulig <martin@ximian.com>
3529 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3530 public version of this method.
3532 * class.cs (MethodCore.IsDuplicateImplementation): Use
3533 Invocation.InferTypeArguments() to check this.
3535 2004-03-29 Martin Baulig <martin@ximian.com>
3537 * convert.cs: Use TypeManager.IsDelegateType() instead of
3538 comparing types correctly.
3540 2004-03-29 Martin Baulig <martin@ximian.com>
3542 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
3543 types directly to make it work for generic instances.
3545 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
3547 2004-03-29 Martin Baulig <martin@ximian.com>
3549 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
3552 2004-03-24 Martin Baulig <martin@ximian.com>
3554 * decl.cs (DeclSpace.FindType): Also use
3555 TypeManager.CheckGeneric() for types from the using clauses.
3557 2004-03-23 Martin Baulig <martin@ximian.com>
3559 * expression.cs (Invocation.OverloadResolve): Added `bool
3560 may_fail' argument and use it instead of the Location.IsNull() hack.
3562 2004-03-23 Martin Baulig <martin@ximian.com>
3564 * expression.cs (Invocation.InferType): Use correct type inference
3567 2004-03-23 Martin Baulig <martin@ximian.com>
3569 * ecore.cs (MethodGroupExpr.Name): Use
3570 TypeManager.CSharpSignature() instead of just the name.
3572 * expression.cs (Invocation.OverloadResolve): Provide better error
3574 (Invocation.DoResolve): OverloadResolve() never returns null
3575 without reporting an error, so removed the error -6 reporting here.
3577 2004-03-23 Martin Baulig <martin@ximian.com>
3579 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
3582 * cs-parser.jay (delegate_declaration): Support generic delegates.
3584 * delegate.cs: Support generic delegates.
3586 2004-03-22 Martin Baulig <martin@ximian.com>
3588 * expression.cs (Invocation.InferParamsTypeArguments): New static
3589 method; does type inference for params arguments.
3591 2004-03-21 Martin Baulig <martin@ximian.com>
3593 * typemanager.cs (TypeManager.IsGenericMethod): New public static
3594 method; checks whether a method is a generic method.
3596 * expression.cs (Invocation.InferTypeArguments): New static method;
3597 infer type arguments for generic method invocation.
3599 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
3600 property; we set this to true if we're resolving a generic method
3601 invocation and the user specified type arguments, ie. we're not
3602 doing type inference.
3604 2004-03-20 Martin Baulig <martin@ximian.com>
3606 * class.cs (MethodData.DeclaringType): New public property.
3607 (MethodData.Define): Set DeclaringType here.
3608 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
3609 instead of OperatorMethodBuilder.DeclaringType.
3611 2004-03-20 Martin Baulig <martin@ximian.com>
3613 * cs-tokenizer.cs (xtoken): Return a special
3614 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
3616 * cs-parser.jay (default_value_expression): Switch to the new
3619 2004-03-19 Martin Baulig <martin@ximian.com>
3621 * decl.cs (MemberName): New class. We use this to "construct"
3622 namespace_or_type_name's.
3624 * generics.cs (TypeArguments.GetDeclarations): New public method;
3625 returns the type arguments as a string[] and reports a CS0081 if
3626 one of them is not an identifier.
3628 * class.cs (MemberBase): The .ctor now takes the name as a
3629 MemberName instead of a string.
3630 (MemberBase.ExplicitInterfaceName): Changed type from string to
3632 (MemberBase.DoDefine): If we're an explicit implementation, the
3633 InterfaceType may be a generic instance.
3635 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
3636 (namespace_name): Call MemberName.GetName () to transform the
3637 MemberName into a string and ensure we don't have any type
3639 (type_name): Call MemberName.GetTypeExpression() to transfrom the
3640 MemberName into an expression.
3641 (method_header): Use namespace_or_type_name instead of member_name.
3643 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3645 * rootcontext.cs: Add new types to the boot resolution.
3647 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3648 MulticastDelegate is not allowed.
3650 * typemanager.cs: Add new types to lookup: System.TypedReference
3653 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3654 check for TypedReference or ArgIterator, they are not allowed.
3656 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3657 makes us properly catch 1510 in some conditions (see bug 56016 for
3660 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3662 * CryptoConvert.cs: update from corlib version
3665 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3667 * class.cs (Indexer.Define): Check indexername declaration
3669 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3671 * attribute.cs (IsClsCompliant): Fixed problem with handling
3672 all three states (compliant, not-compliant, undetected).
3674 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3676 * attribute.cs (Attribute): Location is now public.
3677 (Resolve): Store resolved arguments (pos_values) in attribute class.
3678 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3679 (GetClsCompliantAttributeValue): New method that gets
3680 CLSCompliantAttribute value.
3681 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3682 if exists else null.
3683 (AttributeTester): New class for CLS-Compliant verification routines.
3685 * class.cs (Emit): Add CLS-Compliant verification.
3686 (Method.GetSignatureForError): Implemented.
3687 (Constructor.GetSignatureForError): Implemented
3688 (Constructor.HasCompliantArgs): Returns if constructor has
3689 CLS-Compliant arguments.
3690 (Constructor.Emit): Override.
3691 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3692 is needed to test only parameters.
3693 (FieldBase.GetSignatureForError): Implemented.
3694 (TypeContainer): New member for storing base interfaces.
3695 (TypeContainer.FindMembers): Search in base interfaces too.
3697 * codegen.cs (GetClsComplianceAttribute): New method that gets
3698 assembly or module CLSCompliantAttribute value.
3699 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3701 (ModuleClass.Emit): Add error 3012 test.
3703 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3705 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3706 state for all decl types.
3707 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3708 if CLS-Compliant tests are required.
3709 (IsClsCompliaceRequired): New method. Analyze whether code
3710 must be CLS-Compliant.
3711 (IsExposedFromAssembly): New method. Returns true when MemberCore
3712 is exposed from assembly.
3713 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3714 value or gets cached value.
3715 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3716 is explicitly marked with CLSCompliantAttribute.
3717 (IsIdentifierClsCompliant): New abstract method. This method is
3718 used to testing error 3005.
3719 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3720 for identifier and parameters CLS-Compliant testing.
3721 (VerifyClsCompliance): New method. The main virtual method for
3722 CLS-Compliant verifications.
3723 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3724 null. I don't know why is null (too many public members !).
3725 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3726 and get value of first CLSCompliantAttribute that found.
3728 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3729 (VerifyClsCompliance): Override and add extra tests.
3731 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3732 clscheck- disable CLS-Compliant verification event if assembly is has
3733 CLSCompliantAttribute(true).
3735 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3736 ApllyAttribute is now called in emit section as in the other cases.
3737 Possible future Emit integration.
3738 (IsIdentifierClsCompliant): New override.
3739 (VerifyClsCompliance): New override.
3740 (GetEnumeratorName): Returns full enum name.
3742 * parameter.cs (GetSignatureForError): Implemented.
3744 * report.cs (WarningData): New struct for Warning message information.
3745 (LocationOfPreviousError): New method.
3746 (Warning): New method. Reports warning based on the warning table.
3747 (Error_T): New method. Reports error based on the error table.
3749 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3750 verifications are done here.
3752 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3754 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3755 CLSCompliantAttribute.
3756 (all_imported_types): New member holds all imported types from other
3758 (LoadAllImportedTypes): New method fills static table with exported types
3759 from all referenced assemblies.
3760 (Modules): New property returns all assembly modules.
3762 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3764 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3765 throwing a parser error.
3767 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3768 which removes the hardcoded get_/set_ prefixes for properties, as
3769 IL allows for the properties to be named something else.
3773 * expression.cs: Do not override operand before we know if it is
3776 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3778 * typemanager.cs: support for pinned variables.
3780 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3782 * decl.cs, typemanager.cs: Avoid using an arraylist
3783 as a buffer if there is only one result set.
3785 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3787 * expression.cs: Make sure you cant call a static method
3788 with an instance expression, bug #56174.
3790 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3792 * class.cs (IsDuplicateImplementation): Improve error reporting to
3793 flag 663 (method only differs in parameter modifier).
3795 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3796 in preprocessor directives.
3798 * location.cs (LookupFile): Allow for the empty path.
3800 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3801 better approach for some of that patch, but its failing with the
3802 CharSet enumeration. For now try/catch will do.
3804 * typemanager.cs: Do not crash if a struct does not have fields.
3807 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3809 * expression.cs: cs0213, cant fix a fixed expression.
3812 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3814 * cs-parser.jay: detect invalid embeded statements gracefully.
3817 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3819 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3822 the invocation type may not be a subclass of the tye of the item/
3823 The type of the item must be a subclass of the invocation item.
3828 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3830 * attribute.cs: Added methods to get a string and a bool from an
3831 attribute. Required to information from AssemblyKeyFileAttribute,
3832 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3833 * codegen.cs: Modified AssemblyName creation to include support for
3834 strongnames. Catch additional exceptions to report them as CS1548.
3835 * compiler.csproj: Updated include CryptoConvert.cs.
3836 * compiler.csproj.user: Removed file - user specific configuration.
3837 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
3838 Mono.Security assembly. The original class is maintained and tested in
3839 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
3840 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
3841 like CSC 8.0 (C# v2) supports.
3842 * Makefile: Added CryptoConvert.cs to mcs sources.
3843 * rootcontext.cs: Added new options for strongnames.
3845 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
3847 * driver.cs: For --expect-error, report error code `2'
3848 if the program compiled with no errors, error code `1' if
3849 it compiled with an error other than the one expected.
3851 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
3853 * compiler.csproj: Updated for Visual Studio .NET 2003.
3854 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
3855 * compiler.sln: Updated for Visual Studio .NET 2003.
3857 2004-03-24 Ravi Pratap M <ravi@ximian.com>
3859 * expression.cs: Fix bug #47234. We basically need to apply the
3860 rule that we prefer the conversion of null to a reference type
3861 when faced with a conversion to 'object' (csc behaviour).
3863 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3865 * statement.cs: Shorter form for foreach, eliminates
3866 a local variable. r=Martin.
3868 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3870 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
3871 checks if we can use brtrue/brfalse to test for 0.
3872 * expression.cs: use the above in the test for using brtrue/brfalse.
3875 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3877 * expression.cs: Rewrite string concat stuff. Benefits:
3879 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
3880 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
3881 rather than a concat chain.
3883 * typemanager.cs: Add lookups for more concat overloads.
3885 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3887 * expression.cs: Emit shorter il code for array init.
3904 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
3906 * statement.cs: Before, two switch blocks would be merged if the
3907 total size of the blocks (end_item - begin_item + 1) was less than
3908 two times the combined sizes of the blocks.
3910 Now, it will only merge if after the merge at least half of the
3915 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
3917 * class.cs : csc build fix for GetMethods(). See bug #52503.
3919 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
3921 * expression.cs: Make sure fp comparisons work with NaN.
3922 This fixes bug #54303. Mig approved this patch a long
3923 time ago, but we were not able to test b/c the runtime
3926 2004-03-19 Miguel de Icaza <miguel@ximian.com>
3928 * ecore.cs (TypExpr.GetHashCode): implement this overload.
3930 2004-03-19 Martin Baulig <martin@ximian.com>
3932 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
3933 two overloads may unify for some type parameter substitutions and
3934 report a CS0408 if appropriate.
3936 2004-03-19 Martin Baulig <martin@ximian.com>
3938 * class.cs (MemberCore.IsDuplicateImplementation): Report the
3939 error here and not in our caller.
3941 2004-03-19 Martin Baulig <martin@ximian.com>
3943 * interface.cs: Completely killed this file.
3944 (Interface): We're now a TypeContainer and live in class.cs.
3946 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
3947 argument; we're now also called for interfaces.
3948 (TypeContainer.DefineMembers): Allow this method being called
3950 (TypeContainer.GetMethods): New public method; formerly known as
3951 Interface.GetMethod(). This is used by PendingImplementation.
3952 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
3953 it's now private and non-static.
3954 (Interface): Moved this here; it's now implemented similar to
3956 (Method, Property, Event, Indexer): Added `bool is_interface'
3957 argument to their .ctor's.
3958 (MemberBase.IsInterface): New public field.
3960 * cs-parser.jay: Create normal Method, Property, Event, Indexer
3961 instances instead of InterfaceMethod, InterfaceProperty, etc.
3962 (opt_interface_base): Removed; we now use `opt_class_base' instead.
3963 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
3965 2004-03-19 Martin Baulig <martin@ximian.com>
3967 * class.cs (MethodCore.IsDuplicateImplementation): New private
3968 method which does the CS0111 checking.
3969 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
3970 Use IsDuplicateImplementation().
3972 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
3974 * decl.cs (FindMemberToOverride): New method to find the correct
3975 method or property to override in the base class.
3977 - Make Method/Property use the above method to find the
3978 version in the base class.
3979 - Remove the InheritableMemberSignatureCompare as it is now
3982 This patch makes large code bases much faster to compile, as it is
3983 O(n) rather than O(n^2) to do this validation.
3985 Also, it fixes bug 52458 which is that nested classes are not
3986 taken into account when finding the base class member.
3988 Reviewed/Approved by Martin.
3990 2004-03-17 Martin Baulig <martin@ximian.com>
3992 * expression.cs (MemberAccess.DoResolve): Take the parent's number
3993 of type arguments into account; use the `real_num_type_args'
3994 approach like in DoResolveAsTypeStep().
3996 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
3999 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4001 * interface.cs: In all interface classes removed redundant
4002 member initialization.
4004 2004-03-16 Martin Baulig <martin@ximian.com>
4006 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4008 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4010 * decl.cs (DefineTypeAndParents): New helper method to define a
4011 type's containers before the type itself is defined; This is a
4012 bug exposed by the recent changes to Windows.Forms when an
4013 implemented interface was defined inside a class that had not been
4016 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4018 (Check): Loop correctly to report errors modifiers
4019 (UNSAFE was not in the loop, since it was the same as TOP).
4021 * interface.cs: Every interface member now takes a ModFlags,
4022 instead of a "is_new" bool, which we set on the base MemberCore.
4024 Every place where we called "UnsafeOk" in the interface, now we
4025 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4026 the unsafe settings from the member declaration instead of the
4027 container interface.
4029 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4031 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4032 `set_indexer_name' to the pending bits (one per type).
4034 We fixed a bug today that was picking the wrong method to
4035 override, since for properties the existing InterfaceMethod code
4036 basically ignored the method name. Now we make sure that the
4037 method name is one of the valid indexer names.
4039 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4041 * support.cs (SeekableStreamReader): Keep track of stream byte
4042 positions and don't mix them with character offsets to the buffer.
4044 Patch from Gustavo Giráldez
4046 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4048 * interface.cs (InterfaceSetGetBase): Removed double member
4049 initialization, base class does it as well.
4051 2004-03-13 Martin Baulig <martin@ximian.com>
4053 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4054 when compiling corlib.
4056 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4058 * convert.cs (ExplicitConversion): We were reporting an error on
4059 certain conversions (object_type source to a value type, when the
4060 expression was `null') before we had a chance to pass it through
4061 the user defined conversions.
4063 * driver.cs: Replace / and \ in resource specifications to dots.
4066 * class.cs: Add check for duplicate operators. Fixes 52477
4068 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4070 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4071 that are in the middle of the statements, not only at the end.
4074 * class.cs (TypeContainer.AddField): No longer set the
4075 `HaveStaticConstructor' flag, now we call it
4076 `UserDefineStaticConstructor' to diferentiate the slightly
4077 semantic difference.
4079 The situation is that we were not adding BeforeFieldInit (from
4080 Modifiers.TypeAttr) to classes that could have it.
4081 BeforeFieldInit should be set to classes that have no static
4086 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4088 And most importantly Zoltan's comment:
4090 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4092 "I think beforefieldinit means 'it's ok to initialize the type sometime
4093 before its static fields are used', i.e. initialization does not need
4094 to be triggered by the first access to the type. Setting this flag
4095 helps the JIT to compile better code, since it can run the static
4096 constructor at JIT time, and does not need to generate code to call it
4097 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4098 this flag for lots of classes like String.
4100 csc sets this flag if the type does not have an explicit static
4101 constructor. The reasoning seems to be that if there are only static
4102 initalizers for a type, and no static constructor, then the programmer
4103 does not care when this initialization happens, so beforefieldinit
4106 This bug prevents the AOT compiler from being usable, since it
4107 generates so many calls to mono_runtime_class_init that the AOT code
4108 is much slower than the JITted code. The JITted code is faster,
4109 because it does not generate these calls if the vtable is type is
4110 already initialized, which is true in the majority of cases. But the
4111 AOT compiler can't do this."
4113 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4115 * class.cs (MethodData.Emit): Refactor the code so symbolic
4116 information is generated for destructors; For some reasons we
4117 were taking a code path that did not generate symbolic information
4120 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4122 * class.cs: Create a Constructor.CheckBase method that
4123 takes care of all validation type code. The method
4124 contains some code that was moved from Define.
4126 It also includes new code that checks for duplicate ctors.
4127 This fixes bug #55148.
4129 2004-03-09 Joshua Tauberer <tauberer@for.net>
4131 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4132 a { ... }-style array creation invokes EmitStaticInitializers
4133 which is not good for reference-type arrays. String, decimal
4134 and now null constants (NullCast) are not counted toward
4135 static initializers.
4137 2004-03-05 Martin Baulig <martin@ximian.com>
4139 * location.cs (SourceFile.HasLineDirective): New public field;
4140 specifies whether the file contains or is referenced by a "#line"
4142 (Location.DefineSymbolDocuments): Ignore source files which
4143 either contain or are referenced by a "#line" directive.
4145 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4147 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4148 direct access to our parent, so check the method inline there.
4150 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4152 * expression.cs (Invocation.EmitCall): Miguel's last commit
4153 caused a regression. If you had:
4158 In Foo the implict this would be null.
4160 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4162 * expression.cs (Invocation.EmitCall): If the method is not
4163 virtual, do not emit a CallVirt to it, use Call.
4165 * typemanager.cs (GetFullNameSignature): Improve the method to
4166 cope with ".ctor" and replace it with the type name.
4168 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4169 as an argument the ConstructorBuilder where it is being defined,
4170 to catch the recursive constructor invocations.
4172 2004-03-16 Martin Baulig <martin@ximian.com>
4174 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
4175 ConstructedType, call ResolveType() on it to get the type rather
4176 than just using `expr.Type'.
4178 2004-03-16 Martin Baulig <martin@ximian.com>
4180 * generics.cs (ConstructedType.GetMemberAccess): Take the
4181 EmitContext instead on the TypeExpr and use
4182 ec.TypeContainer.CurrentType/ec.ContainerType.
4184 2004-03-16 Martin Baulig <martin@ximian.com>
4186 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
4187 parameters before aliases.
4189 2004-03-16 Martin Baulig <martin@ximian.com>
4191 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
4192 New oublic function; checks whether two generic instances may become
4193 equal under some instantiations (26.3.1).
4195 * class.cs (TypeContainer.Define): Call
4196 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
4199 2004-03-16 Martin Baulig <martin@ximian.com>
4201 * class.cs (TypeContainer.GetClassBases): Moved
4202 Error_TypeParameterAsBase() here and also check whether the base
4203 class is not an attribute.
4205 2004-03-16 Martin Baulig <martin@ximian.com>
4207 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4209 2004-03-16 Martin Baulig <martin@ximian.com>
4211 * class.cs (Error_TypeParameterAsBase): Use correct error number
4214 2004-03-16 Martin Baulig <martin@ximian.com>
4216 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
4219 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
4222 2004-03-15 Martin Baulig <martin@ximian.com>
4224 * typemanager.cs (TypeManager.GetFullName): New public method.
4225 (TypeManager.MemberLookup): Added `int_num_type_arguments'
4226 argument; only return members with the correct number of type
4228 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
4229 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
4230 whether the number of type arguments matches.
4232 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
4233 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
4235 * expression.cs (MemberAccess): Added public `NumTypeArguments'
4236 field; it's set by the protected .ctor when we're actually a
4237 GenericMemberAccess.
4238 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
4239 arguments and pass it to MemberLookupFinal ().
4241 * ecore.cs (Expression.MemberLookup): Added `int
4242 num_type_arguments' argument; only return members with the correct
4243 number of type arguments.
4244 (Expression.MemberLookupFailed): Check whether the MemberLookup
4245 failed because we did not have the correct number of type
4246 arguments; report CS0305 in this case.
4248 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
4249 `e.ResolveAsTypeTerminal()' already did so.
4251 2004-03-15 Martin Baulig <martin@ximian.com>
4253 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
4254 we're a ConstructedType; in this case, the caller must report an
4255 error (for instance CS0131).
4257 * generic.cs (TypeArguments): Added Location argument to the .ctor.
4258 (TypeArguments.Resolve): Actually report errors here.
4260 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4262 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4263 `set_indexer_name' to the pending bits (one per type).
4265 We fixed a bug today that was picking the wrong method to
4266 override, since for properties the existing InterfaceMethod code
4267 basically ignored the method name. Now we make sure that the
4268 method name is one of the valid indexer names.
4270 2004-03-15 Martin Baulig <martin@ximian.com>
4272 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
4273 for generic instances.
4275 2004-03-13 Martin Baulig <martin@ximian.com>
4277 * class.cs (TypeContainer.DefineType): Call
4278 TypeManager.AddUserType() immediately after creating the
4279 TypeBuilder; pass all type parameters when creating the
4282 * decl.cs (DeclSpace.FindNestedType): New public method.
4283 (DeclSpace.FindType): Added `int num_type_args' argument; only
4284 return types with the correct number of type parameters.
4285 (DeclSpace.CountTypeParams): New public property.
4287 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
4288 the number of type parameters; defaults to zero.
4290 * generic.cs (TypeArguments.Count): New public property.
4291 (ConstructedType.DoResolveAsTypeStep): First call
4292 ds.FindNestedType() to find out whether we're nested in the
4293 current generic type; in this case, we inherit all type parameters
4294 from the current class.
4296 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
4297 num_type_args' argument.
4298 (RootContext.LookupType): Added overloaded version which takes the
4299 number of type arguments; only return types with the correct
4300 number of type arguments.
4302 * typemanager.cs (TypeManager.CheckGeneric): New public function;
4303 checks whether `Type t' has `int num_type_args'.
4305 2004-03-13 Martin Baulig <martin@ximian.com>
4307 * generic.cs (GenericMethod.DefineType): New method; calls
4308 DefineType() on all the type parameters.
4310 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
4311 (MethodData.Define): If we're a generic method, call
4312 GenericMethod.DefineType() to define the type parameters.
4314 2004-03-10 Martin Baulig <martin@ximian.com>
4316 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
4317 instead of IsAssignableFrom.
4319 2004-03-10 Martin Baulig <martin@ximian.com>
4321 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
4323 * support.cs (ParameterData.HasArrayParameter): New property.
4324 (ReflectionParameters.ctor): Take a MethodBase instead of a
4325 ParameterInfo[]. If we have any type parameters, get the generic
4326 method definition and ask it whether we have variable arguments.
4328 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4330 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4331 routines to check if a type is an enumerable/enumerator allow
4332 classes that implement the IEnumerable or IEnumerator interfaces.
4334 * class.cs (Property, Operator): Implement IIteratorContainer, and
4335 implement SetYields.
4337 (Property.Define): Do the block swapping for get_methods in the
4338 context of iterators. We need to check if Properties also
4339 include indexers or not.
4341 (Operator): Assign the Block before invoking the
4342 OperatorMethod.Define, so we can trigger the Iterator code
4345 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4346 Property and Operator classes are not created when we parse the
4347 declarator but until we have the block completed, so we use a
4348 singleton SimpleIteratorContainer.Simple to flag whether the
4349 SetYields has been invoked.
4351 We propagate this setting then to the Property or the Operator to
4352 allow the `yield' to function.
4354 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4356 * codegen.cs: Implemented attribute support for modules.
4357 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4358 Assembly/Module functionality.
4360 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4361 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4362 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4364 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4366 * interface.cs (FindMembers): The operation is performed on all base
4367 interfaces and not only on the first. It is required for future CLS Compliance patch.
4369 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4371 * statement.cs, codegen.cs:
4372 This patch deals with patterns such as:
4374 public class List : IEnumerable {
4376 public MyEnumerator GetEnumerator () {
4377 return new MyEnumerator(this);
4380 IEnumerator IEnumerable.GetEnumerator () {
4384 public struct MyEnumerator : IEnumerator {
4389 Before, there were a few things we did wrong:
4390 1) we would emit callvirt on a struct, which is illegal
4391 2) we emited ldarg when we needed to emit ldarga
4392 3) we would mistakenly call the interface methods on an enumerator
4393 type that derived from IEnumerator and was in another assembly. For example:
4395 public class MyEnumerator : IEnumerator
4397 Would have the interface methods called, even if there were public impls of the
4398 method. In a struct, this lead to invalid IL code.
4400 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4402 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4405 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4407 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4409 * cs-parser.jay: Fix small regression: we were not testing V2
4410 compiler features correctly.
4412 * interface.cs: If the emit context is null, then create one
4414 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4416 * decl.cs (GetSignatureForError): New virtual method to get full name
4419 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4420 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4422 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4423 Duplicated members and code in these classes has been removed.
4424 Better encapsulation in these classes.
4426 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4428 * assign.cs (Assign.DoResolve): When dealing with compound
4429 assignments, there is a new rule in ECMA C# 2.4 (might have been
4430 there before, but it is documented here) that states that in:
4434 If b is of type int, and the `op' is a shift-operator, then the
4435 above is evaluated as:
4439 * expression.cs (Binary.ResolveOperator): Instead of testing for
4440 int/uint/long/ulong, try to implicitly convert to any of those
4441 types and use that in pointer arithmetic.
4443 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4444 method to print information for from the type, not from the
4445 null-method we were given.
4447 2004-02-01 Duncan Mak <duncan@ximian.com>
4449 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4450 parsing for cmd, fixes bug #53694.
4452 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4454 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4455 in the member name duplication tests. Property and operator name duplication
4456 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4458 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4460 * interface.cs (PopulateMethod): Fixed crash when interface method
4461 returns not existing type (error test cs0246-3.cs).
4463 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4465 * cs-parser.jay (interface_accessors): Re-write actions to also
4466 store attributes attached to get and set methods. Fix spelling
4469 (inteface_property_declaration): Modify accordingly.
4471 (InterfaceAccessorInfo): New helper class to store information to pass
4472 around between rules that use interface_accessors.
4474 * interface.cs (Emit): Apply attributes on the get and set
4475 accessors of properties and indexers too.
4477 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4478 right MethodBuilder when applying attributes to the get and set accessors.
4480 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4482 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4484 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4486 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4488 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4490 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4491 changes that treat `yield' specially when present before `break'
4494 * cs-tokenizer.cs: yield is no longer a keyword.
4496 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4498 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4499 setting for default constructors.
4500 For default constructors are almost every time set wrong Modifier. The
4501 generated IL code has been alright. But inside mcs this values was
4502 wrong and this was reason why several of my CLS Compliance tests
4505 2004-02-27 Martin Baulig <martin@ximian.com>
4507 * generics.cs (ConstructedType.ResolveType): Make the nested type
4508 stuff actually work.
4510 2004-02-25 Martin Baulig <martin@ximian.com>
4512 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
4513 property; returns the type parameters just from the current type,
4514 ie. with the ones from outer classes.
4515 (DeclSpace.LookupGeneric): First search in the current class, then
4517 (DeclSpace.initialize_type_params): When hiding a type parameter
4518 from an outer class, put it into the `type_param_list' anyways.
4520 * expression.cs (MemberAccess.expr): Made this field protected.
4522 * class.cs (TypeContainer.Define): The `CurrentType' just contains
4523 the type parameters from the current class.
4525 * generic.cs (ConstructedType.ResolveType): Support nested generic
4526 types by taking the type parameters which we inherit from outer
4527 classes into account.
4528 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
4529 support for nested generic types.
4531 2004-02-23 Martin Baulig <martin@ximian.com>
4533 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
4534 field and check whether we're nested inside a generic type.
4535 (DeclSpace.ResolveType): If we're resolving to a generic type
4536 definition, create a ConstructedType and return its resolved type.
4537 (DeclSpace.initialize_type_params): New private method;
4538 initializes the `type_param_list' field from the type parameters
4539 from this and all enclosing classes.
4540 (DeclSpace.TypeParameters): Call initialize_type_params() unless
4541 we're already initialized.
4543 2004-02-23 Martin Baulig <martin@ximian.com>
4545 * class.cs (Method.Define): Create the generic method before
4547 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
4548 the TypeContainer one); we use this for generic methods.
4550 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
4551 parent's TypeBuilder.
4553 2004-02-18 Martin Baulig <martin@ximian.com>
4555 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
4556 to check for equality.
4558 2004-02-05 Martin Baulig <martin@ximian.com>
4560 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
4561 `ec.TypeContainer.CurrentType', use it instead of
4562 `ec.ContainerType' to check whether we're in the type's ctor.
4564 2004-01-29 Martin Baulig <martin@ximian.com>
4566 * expression.cs (Invocation.DoResolve): If we're a
4567 `ConstructedType', then we're actually a generic method, so
4568 rewrite the expr as a GenericMemberAccess.
4570 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
4571 here; manually parse it into a string.
4573 2004-01-28 Martin Baulig <martin@ximian.com>
4575 * typemanager.cs (TypeManager.IsEqual): New static method.
4576 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
4577 check for equality instead of using `=='.
4579 2004-01-26 Martin Baulig <martin@ximian.com>
4581 * decl.cs (DeclSpace.CurrentType): New public field.
4583 * expression.cs (This.ResolveBase): If we have an
4584 `ec.TypeContainer.CurrentType', use it instead of
4587 * class.cs (TypeContainer.DefineType): If we're a generic type,
4588 create the `CurrentType' (unresolved).
4589 (TypeContainer.GenericType): New private field.
4590 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
4591 it and store it in `GenericType' before creating the MemberCache.
4592 (TypeContainer.GetMembers): If we have a `GenericType', call
4593 TypeManager.FindMembers() on it.
4595 * interface.cs (Interface.GenericType): New private field.
4596 (Interface.DefineType): If we're a generic type, create the
4597 `CurrentType' (unresolved).
4598 (Interface.DefineMembers): If we have a `CurrentType', resolve it
4599 and store it in `GenericType' before creating the MemberCache.
4600 (Interface.GetMembers): If we have a `GenericType', call
4601 TypeManager.FindMembers() on it.
4603 2004-01-22 Martin Baulig <martin@ximian.com>
4605 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4606 not a QualifiedIdentifier. This is what `type_name_expression'
4607 was previously doing.
4608 (type_name_expression): Removed; the code is now in
4609 `namespace_or_type_name'.
4610 (qualified_identifier): Removed, use `namespace_or_type_name'
4612 (QualifiedIdentifier): Removed this class.
4614 2004-01-22 Martin Baulig <martin@ximian.com>
4616 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4617 not a string as alias name.
4619 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4621 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4622 #52730 bug, and instead compute correctly the need to use a
4623 temporary variable when requesting an address based on the
4624 static/instace modified of the field and the constructor.
4626 2004-01-21 Martin Baulig <martin@ximian.com>
4628 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4629 class and namespace before looking up aliases. Fixes #52517.
4631 2004-01-21 Martin Baulig <martin@ximian.com>
4633 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4634 assinged in a 'try'; fixes exception4.cs.
4636 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4637 * class.cs : Implemented parameter-less constructor for TypeContainer
4639 * decl.cs: Attributes are now stored here. New property OptAttributes
4641 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4643 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4645 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4647 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4648 (CSharpSignature): New method for indexer and property signature.
4650 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4652 * pending.cs (IsVirtualFilter): Faster implementation.
4654 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4656 * typemanager.cs: Avoid inclusion of same assembly more than once.
4658 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4660 * cs-parser.jay: Fixed problem where the last assembly attribute
4661 has been applied also to following declaration (class, struct, etc.)
4663 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4665 * class.cs: Added error CS0538, CS0539 reporting.
4666 Fixed crash on Microsoft runtime when field type is void.
4668 * cs-parser.jay: Added error CS0537 reporting.
4670 * pending.cs: Added error CS0535 reporting.
4671 Improved error report for errors CS0536, CS0534.
4673 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4675 Merge a few bits from the Anonymous Method MCS tree.
4677 * statement.cs (ToplevelBlock): New class for toplevel methods,
4678 will hold anonymous methods, lifted variables.
4680 * cs-parser.jay: Create toplevel blocks for delegates and for
4681 regular blocks of code.
4683 2004-01-20 Martin Baulig <martin@ximian.com>
4685 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4686 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4687 and `NeedExplicitReturn'; added `IsLastStatement'.
4688 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4689 have a `ReturnLabel' or we're not unreachable.
4691 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4692 child's reachability; don't just override ours with it. Fixes
4693 #58058 (lluis's example).
4694 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4695 InFinally(), InLoop(), InSwitch() and
4696 BreakCrossesTryCatchBoundary() methods.
4698 * statement.cs (Return): Do all error checking in Resolve().
4699 Unless we are the last statement in a top-level block, always
4700 create a return label and jump to it.
4701 (Break, Continue): Do all error checking in Resolve(); also make
4702 sure we aren't leaving a `finally'.
4703 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4704 statement in a top-level block.
4705 (Block.Flags): Added `IsDestructor'.
4706 (Block.IsDestructor): New public property.
4708 2004-01-20 Martin Baulig <martin@ximian.com>
4710 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4712 2004-01-20 Martin Baulig <martin@ximian.com>
4714 * statement.cs (Statement.ResolveUnreachable): New public method.
4715 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4716 (Block.Resolve): Resolve unreachable statements.
4718 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4720 * expression.cs: We need to fix the case where we do
4721 not have a temp variable here.
4723 * assign.cs: Only expression compound assignments need
4724 temporary variables.
4726 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4728 * flowanalysis.cs: Reduce memory allocation in a few ways:
4729 - A block with no variables should not allocate a bit
4731 - A method with no out parameters does not need any tracking
4732 for assignment of the parameters, so we need not allocate
4735 public readonly Type[] VariableTypes;
4736 public readonly string[] VariableNames;
4737 Are redundant. The data is already stored in the variable
4738 map, so we need not allocate another array for it.
4739 - We need to add alot of checks for if (params | locals) == null
4740 due to the first two changes.
4742 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4744 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4745 implement IMemoryLocation, we store a copy on a local variable and
4746 take the address of it. Patch from Benjamin Jemlich
4748 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4749 to use a special "type_name_expression" rule which reduces the
4750 number of "QualifiedIdentifier" classes created, and instead
4751 directly creates MemberAccess expressions.
4753 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4755 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4756 that fixes #52853. Null literal assignment to ValueType
4758 * class.cs (MethodData.Emit): Instead of checking the name of the
4759 method to determine if its a destructor, create a new derived
4760 class from Method called Destructor, and test for that.
4762 * cs-parser.jay: Create a Destructor object instead of a Method.
4764 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4768 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4770 * expression.cs (Binary.ResolveOperator): Perform an implicit
4771 conversion from MethodGroups to their delegate types on the
4774 * delegate.cs: Introduce a new class DelegateCreation that is the
4775 base class for `NewDelegate' and `ImplicitDelegateCreation',
4776 factor some code in here.
4778 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4779 conversion from MethodGroups to compatible delegate types.
4781 * ecore.cs (Expression.Resolve): Do not flag error 654
4782 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4783 we allow conversions from MethodGroups to delegate types now.
4785 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4786 assignments in v2 either.
4788 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4790 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4791 static read-only fields in ctors.
4793 Applied patch from Benjamin Jemlich
4795 * expression.cs (UnaryMutator): Avoid leaking local variables.
4797 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4799 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4800 here to return true, as they can be used like this:
4804 Fixed 49836 and all the other dups
4806 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4808 * driver.cs: Implement /win32res and /win32icon.
4810 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4812 * cs-parser.jay: Add a rule to improve error handling for the
4813 common mistake of placing modifiers after the type.
4815 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4817 * cs-parser.jay (interface_event_declaration): Catch
4818 initialization of events on interfaces, and report cs0068
4820 * cs-parser.jay (interface_event_declaration): Catch
4821 initialization of events.
4823 * ecore.cs: Better report missing constructors.
4825 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4826 the error reporting done in the wrong place. Fix.
4828 * expression.cs (Binary.ResolveOperator): Catch the
4829 operator + (E x, E y) error earlier, and later allow for implicit
4830 conversions in operator +/- (E e, U x) from U to the underlying
4833 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4834 52596, if the container class is abstract, the default constructor
4835 is protected otherwise its public (before, we were always public).
4837 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4840 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4841 Jemlich that fixes bug #52597, MCS was generating invalid code for
4842 idisposable structs. Thanks to Ben for following up with this
4845 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4847 * driver.cs: Allow assemblies without code to be generated, fixes
4850 2004-01-07 Nick Drochak <ndrochak@gol.com>
4852 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4854 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4856 * cs-parser.jay: Add rules to improve error reporting if fields or
4857 methods are declared at the namespace level (error 116)
4859 * Add rules to catch event add/remove
4861 2004-01-04 David Sheldon <dave-mono@earth.li>
4863 * expression.cs: Added matching ")" to error message for
4866 2004-01-03 Todd Berman <tberman@gentoo.org>
4868 * ecore.cs, attribute.cs:
4869 Applying fix from #52429.
4871 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4873 * ecore.cs, expression.cs, statement.cs:
4874 Total rewrite of how we handle branching. We
4875 now handle complex boolean expressions with fewer
4876 jumps. As well if (x == 0) no longer emits a ceq.
4878 if (x is Foo) is much faster now, because we generate
4881 Overall, we get a pretty big improvement on our benchmark
4882 tests. The code we generate is smaller and more readable.
4884 I did a full two-stage bootstrap. The patch was reviewed
4885 by Martin and Miguel.
4887 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4889 * cs-parser.jay: Make primary_expression not take a QI.
4890 we dont need this because the member_access rule covers
4891 us here. So we replace the rule with just IDENTIFIER.
4893 This has two good effects. First, we remove a s/r conflict.
4894 Second, we allocate many fewer QualifiedIdentifier objects.
4896 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4898 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4899 set the correct information via SRE. This prevents
4900 hanging on the MS runtime. Fixes #29374.
4902 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4904 * convert.cs: correctly handle conversions to value types
4905 from Enum and ValueType as unboxing conversions.
4907 Fixes bug #52569. Patch by Benjamin Jemlich.
4909 2004-01-02 Ravi Pratap <ravi@ximian.com>
4911 * expression.cs (BetterConversion): Prefer int -> uint
4912 over int -> ulong (csc's behaviour). This fixed bug #52046.
4914 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4916 * decl.cs (MemberCache.FindMembers): now returns a
4919 * typemanager.cs: In general, go with with ^^.
4920 (CopyNewMethods): take an IList.
4921 (RealMemberLookup): Only allocate an arraylist
4922 if we copy from two sets of methods.
4924 This change basically does two things:
4925 1) Fewer array lists allocated due to CopyNewMethods.
4926 2) the explicit cast in MemberList costed ALOT.
4928 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
4930 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
4931 a hashtable to avoid needless string allocations when an identifier is
4932 used more than once (the common case).
4934 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4936 * pending.cs: MS's TypeBuilder.GetInterfaces ()
4937 is broken, it will not return anything. So, we
4938 have to use the information we have in mcs to
4941 * typemanager.cs: Add a cache for GetInterfaces,
4942 since this will now be used more often (due to ^^)
4944 (GetExplicitInterfaces) New method that gets the
4945 declared, not effective, interfaces on a type
4946 builder (eg, if you have interface IFoo, interface
4947 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
4950 This patch makes MCS able to bootstrap itself on
4953 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4955 * expression.cs: Remove the Nop's that Miguel put
4958 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4960 * report.cs, codegen.cs: Give the real stack trace to
4961 the error when an exception is thrown.
4963 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4965 * decl.cs: only allocate hashtables for ifaces if
4968 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4970 * expression.cs: fix the error from cs0121-2.cs
4971 (a parent interface has two child interfaces that
4972 have a function with the same name and 0 params
4973 and the function is called through the parent).
4975 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
4977 * class.cs, rootcontext.cs, typmanager.cs: do not
4980 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
4982 * codegen.cs: remove stack for the ec flow branching.
4983 It is already a linked list, so no need.
4985 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
4987 * Makefile: Allow custom profiler here.
4989 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4991 * typemanager.cs (LookupType):
4992 - Use a static char [], because split takes
4993 a param array for args, so it was allocating
4995 - Do not store true in a hashtable, it boxes.
4997 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4999 * flowanalysis.cs: bytify common enums.
5001 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5003 * modifiers.cs: Add a new set of flags for the
5004 flags allowed on explicit interface impls.
5005 * cs-parser.jay: catch the use of modifiers in
5006 interfaces correctly.
5007 * class.cs: catch private void IFoo.Blah ().
5009 All related to bug #50572.
5011 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5013 * decl.cs: Rewrite the consistant accessability checking.
5014 Accessability is not linear, it must be implemented in
5015 a tableish way. Fixes #49704.
5017 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5019 * expression.cs: Handle negation in a checked context.
5020 We must use subtraction from zero. Fixes #38674.
5022 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5024 * class.cs: Ignore static void main in DLLs.
5025 * rootcontext.cs: Handle the target type here,
5026 since we are have to access it from class.cs
5027 * driver.cs: account for the above.
5029 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5031 * report.cs: Give line numbers and files if available.
5033 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5035 * driver.cs: Implement /addmodule.
5037 * typemanager.cs: Change 'modules' field so it now contains Modules not
5040 2003-12-20 Martin Baulig <martin@ximian.com>
5042 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5043 (FieldBase.IsAssigned): Removed this field.
5044 (FieldBase.SetAssigned): New public method.
5045 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5047 2003-12-20 Martin Baulig <martin@ximian.com>
5049 * expression.cs (LocalVariableReference.DoResolve): Don't set
5050 `vi.Used' if we're called from DoResolveLValue().
5052 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5053 returns the usage vector it just merged into the current one -
5054 pass this one to UsageWarning().
5055 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5056 of the `EmitContext', don't call this recursively on our children.
5058 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5060 * driver.cs: Implement /target:module.
5062 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5064 * support.cs (CharArrayHashtable): New helper class.
5066 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5067 char arrays, not strings, so we can avoid creating a string in
5068 consume_identifier if the identifier is a keyword.
5070 2003-12-16 Martin Baulig <martin@ximian.com>
5072 * statement.cs (LocalInfo.Assigned): Removed this property.
5073 (LocalInfo.Flags): Removed `Assigned'.
5074 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5075 and uses flow analysis.
5076 (Block.UsageWarning): Made this method private.
5077 (Block.Resolve): Call UsageWarning() if appropriate.
5079 * expression.cs (LocalVariableReference.DoResolve): Always set
5080 LocalInfo.Used here.
5082 2003-12-13 Martin Baulig <martin@ximian.com>
5084 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5085 any value here; we're now using flow analysis to figure out
5086 whether a statement/block returns a value.
5088 2003-12-13 Martin Baulig <martin@ximian.com>
5090 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5092 (FlowBranching.MergeFinally): Don't call
5093 `branching.CheckOutParameters()' here, this is called in
5095 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5096 when adding the `finally' vector.
5098 2003-12-13 Martin Baulig <martin@ximian.com>
5101 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5102 actually work and also fix #48962.
5104 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5106 * decl.cs: Do not check System.Object for nested types,
5107 since we know it does not have any. Big bang for buck:
5112 corlib: 17.99 seconds
5116 corlib: 17.39 seconds
5118 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5120 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5121 time we are returning 0 members, so we save alot here.
5123 2003-12-11 Martin Baulig <martin@ximian.com>
5125 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5126 `MergeChild()', also just take the `FlowBranching' as argument;
5127 call Merge() on it and return the result.
5128 (FlowBranching.Merge): We don't need to do anything if we just
5131 2003-12-11 Martin Baulig <martin@ximian.com>
5133 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5134 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5135 Maurer for this idea.
5137 2003-12-11 Martin Baulig <martin@ximian.com>
5139 * flowanalysis.cs (MergeResult): This class is now gone; we now
5140 use the `UsageVector' for this. The reason for this is that if a
5141 branching just has one sibling, we don't need to "merge" them at
5142 all - that's the next step to do.
5143 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5146 2003-12-11 Martin Baulig <martin@ximian.com>
5148 Reworked flow analyis and made it more precise and bug-free. The
5149 most important change is that we're now using a special `Reachability'
5150 class instead of having "magic" meanings of `FlowReturns'. I'll
5151 do some more cleanups and optimizations and also add some more
5152 documentation this week.
5154 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5155 largely reworked this class.
5156 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5157 the new `Reachability' class instead of having "magic" values here.
5158 (FlowBranching): We're now using an instance of `Reachability'
5159 instead of having separate `Returns', `Breaks' etc. fields.
5161 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5162 based on flow analysis; ignore the return value of block.Emit ().
5164 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5166 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5167 if they are private.
5169 2003-12-09 Martin Baulig <martin@ximian.com>
5171 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5172 call them directly on the UsageVector.
5174 2003-12-09 Martin Baulig <martin@ximian.com>
5176 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5177 Changed return type from `FlowReturns' to `Reachability'.
5179 2003-12-09 Martin Baulig <martin@ximian.com>
5181 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5182 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5183 `Reachable' fields with a single `Reachability' one.
5185 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5187 * class.cs (FindMembers): Remove foreach's.
5200 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5205 This patch does a few things:
5206 1. EmptyStatement is now a singleton, so it is never reallocated.
5207 2. All blah is EmptyStatement constructs have been changed to
5208 blah == EmptyStatement.Value, which is much faster and valid
5209 now that EmptyStatement is a singleton.
5210 3. When resolving a block, rather than allocating a new array for
5211 the non-empty statements, empty statements are replaced with
5212 EmptyStatement.Value
5213 4. Some recursive functions have been made non-recursive.
5214 Mainly the performance impact is from (3), however (1) and (2) are needed for
5215 this to work. (4) does not make a big difference in normal situations, however
5216 it makes the profile look saner.
5221 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5222 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5223 Total memory allocated: 56397 KB
5226 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5227 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5228 Total memory allocated: 55666 KB
5230 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5232 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5233 than the hashtable in a hashtable version
5235 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5236 we always end up concating a string. This results in a huge perf
5237 loss, because many strings have to be tracked by the GC. In this
5238 patch, we first use a hashtable that works with two keys, so that
5239 the strings do not need to be concat'ed.
5250 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5252 * Makefile: Add a new target `do-time' that does a quick and simple
5253 profile, leaving easy to parse output.
5255 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5257 * codegen.cs (Init): Create the dynamic assembly with
5258 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5260 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5262 * support.cs: Make the PtrHashtable use only one
5263 instance of its comparer.
5265 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5267 * typemanager.cs: Fix lookup of GetNamespaces.
5269 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5271 * expression.cs: Removed redundant line.
5273 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5274 ArrayLists, use for loops with bounds.
5276 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5279 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5280 arraylists, use for loop with bounds.
5282 The above three changes give us a 0.071 second performance
5283 improvement out of 3.294 seconds down to 3.223. On my machine
5284 the above changes reduced the memory usage by 1,387 KB during
5287 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5288 QualifiedIdentifiers. Before we created a new string through
5289 concatenation, and mostly later on, the result would be
5290 manipulated by DecomposeQI through string manipulation.
5292 This reduced the compiler memory usage for bootstrapping from
5293 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5294 compile times in 0.05 seconds.
5296 2003-11-28 Dick Porter <dick@ximian.com>
5298 * support.cs: Do string compares with the Invariant culture.
5306 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5307 the comparison is done with the Invariant culture.
5309 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5311 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5312 GetEnumerator method.
5314 (ProbeCollectionType): Iterate starting at the most specific type
5315 upwards looking for a GetEnumerator
5317 * expression.cs: Shift count can be up to 31 for int/uint and 63
5320 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5322 * statement.cs (Block.LookupLabel): Also look for the label on the
5323 children blocks. Use a hash table to keep track of visited
5326 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5327 we actually did transform the other operand, otherwise fall back
5328 to the common codepath that casts to long.
5330 * cs-tokenizer.cs: Use the same code pattern as the int case.
5331 Maybe I should do the parsing myself, and avoid depending on the
5332 Parse routines to get this done.
5334 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5336 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5337 which fixes bug 51347. This time test it.
5339 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5340 attributes for example can not tell the difference between these.
5341 The difference was only a syntax feature of the language.
5343 * attribute.cs: Apply attributes to delegates.
5345 * delegate.cs: Call the apply attributes method.
5347 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5349 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5350 comparing 0 vs Byte.MinValue, not the value
5352 (ImplicitConversionRequired): When reporting a conversion error,
5353 use error 31 to print out the constant error instead of the
5356 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5357 which fixes bug 51347.
5359 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5361 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5362 which fixes the -warnaserror command line option.
5364 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5366 * cfold.cs (DoNumericPromotions): During constant folding of
5367 additions on UIntConstant, special case intconstants with
5368 IntConstants like we do on the expression binary operator.
5370 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5372 * convert.cs (ImplicitReferenceConversion): We were missing a case
5373 (System.Enum are not value types or class types, so we need to
5374 classify them separatedly).
5376 * driver.cs: We do not support error 2007.
5378 2003-11-12 Jackson Harper <jackson@ximian.com>
5380 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5381 system directory. Also use the full file name so users can
5382 libraries names mscorlib-o-tron.dll in a non system dir.
5384 2004-01-04 David Sheldon <dave-mono@earth.li>
5386 * expression.cs: Added matching ")" to error message for CS0077.
5388 2003-12-19 Martin Baulig <martin@ximian.com>
5390 * typemanager.cs (TypeManager.IsEqualGenericType): New public
5391 static method; see documentation in the method.
5392 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
5394 * convert.cs (Convert.ImplicitReferenceConversion,
5395 Convert.ImplicitReferenceConversionExists): Add support for
5396 generic type declarations; see gen-36.cs.
5398 2003-12-19 Martin Baulig <martin@ximian.com>
5400 * pending.cs (Pending.InterfaceMethod): Use
5401 `Type.IsAssignableFrom()' instead of `=='.
5403 2003-12-18 Martin Baulig <martin@ximian.com>
5405 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
5408 * convert.cs (Convert.ImplicitStandardConversionExists): Use
5409 `expr_type.Equals (target_type)' instead of `=='.
5411 2003-12-08 Martin Baulig <martin@ximian.com>
5413 * generics.cs (Constraints.Types): Removed.
5414 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
5416 (Constraints.ResolveTypes): New public method; resolves the
5417 TypeExpr's to Type's.
5418 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
5419 longer takes the constraints.
5420 (TypeParameter.DefineMethod): Likewise.
5421 (TypeParameter.DefineType): New public method. Calls
5422 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
5425 2003-12-08 Martin Baulig <martin@ximian.com>
5427 * convert.cs (Convert.ImplicitConversionStandard): Use
5428 `expr_type.Equals (target_type)' instead of `=='.
5430 2003-12-08 Martin Baulig <martin@ximian.com>
5432 * typemanager.cs (TypeManager.GetReferenceType): Call
5433 `Type.MakeByRefType ()'.
5435 2003-12-08 Martin Baulig <martin@ximian.com>
5437 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
5438 just has some special meaning in some situations. For instance,
5439 it is allowed to use `where' as the name of a variable etc.
5441 2003-12-04 Martin Baulig <martin@ximian.com>
5443 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
5444 `Type.MakeArrayType()' for array types.
5446 2003-11-18 Miguel de Icaza <miguel@ximian.com>
5448 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
5451 (SizeOf.DoResolve): assign the `type_queried' field. This gets
5454 2003-11-16 Martin Baulig <martin@ximian.com>
5456 * codegen.cs (EmitContext.IsGeneric): Removed.
5458 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
5459 ResolveGeneric() on the DeclSpace.
5461 2003-11-16 Martin Baulig <martin@ximian.com>
5463 * generic.cs (TypeArguments.Resolve):
5464 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
5465 `ResolveType()' on it to get the Type.
5467 2003-11-15 Martin Baulig <martin@ximian.com>
5469 * generic.cs (ConstructedType.GetInterfaces): Override this.
5471 2003-11-14 Martin Baulig <martin@ximian.com>
5473 * interface.cs (Interface.DefineType): Define all type parameters
5474 before adding the interfaces we inherit.
5476 2003-11-11 Martin Baulig <martin@ximian.com>
5478 * generic.cs (ConstructedType.ResolveType): Always call
5479 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
5481 2003-11-10 Martin Baulig <martin@ximian.com>
5483 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5484 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5485 calling `ResolveType()' on them, directly assign their `Type'.
5487 2003-11-08 Martin Baulig <martin@ximian.com>
5489 * generic.cs (ConstructedType): Override `IsClass' etc.
5491 2003-11-08 Martin Baulig <martin@ximian.com>
5493 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5494 return value and the `out parent' parameter.
5495 (TypeContainer.DefineType): Moved the CS0644 check into
5496 GetClassBases(). Don't pass the interface types to the
5497 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5498 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5500 * ecore.cs (TypeExpr.IsAttribute): New property.
5501 (TypeExpr.GetInterfaces): New method.
5503 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5504 TypeExpr instead of a Type.
5505 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5506 (Interface.DefineType): Don't pass the interface types to the
5507 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5508 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5510 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5511 instead of a `Type[]'.
5512 (TypeManager.RegisterBuilder): Likewise.
5513 (TypeManager.AddUserInterface): Likewise.
5514 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5515 `Type[]' and also return a `TypeExpr[]'.
5516 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5518 2003-11-08 Martin Baulig <martin@ximian.com>
5520 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5523 2003-11-08 Martin Baulig <martin@ximian.com>
5525 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5526 TypeManager.ResolveExpressionTypes().
5528 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5529 instead of an Expression.
5530 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5531 (TypeExpression): New public class; formerly known as `TypeExpr'.
5533 * expression.cs (ComposedCast): Derive from TypeExpr.
5535 * typemanager.cs (TypeManager.system_*_expr): These are now
5536 TypExpr's instead of Expression's.
5537 (TypeManager.ResolveExpressionTypes): New public static function;
5538 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5541 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5543 * expression.cs (New.DoResolve): Do not dereference value that
5544 might be a null return.
5546 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5547 sure that the constant value has the right type. Fixes an
5548 unreported bug, similar to 50425.
5550 * const.cs (Const.LookupConstantValue): Call
5551 ImplicitStandardConversionExists before doing a conversion to
5552 avoid havng the TypeManager.ChangeType do conversions.
5554 Reduced the number of casts used
5556 (Const.ChangeType): New routine to enable reuse of the constant
5557 type changing code from statement.
5559 * typemanager.cs (ChangeType): Move common initialization to
5560 static global variables.
5564 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5565 every value type to go through, even if it was void. Fix that.
5567 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5568 character of the define, and the is_identifier_part_character for
5569 the rest of the string.
5571 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5573 * expression.cs (UnaryMutator.EmitCode): When I updated
5574 LocalVariableReference.DoResolve, I overdid it, and dropped an
5575 optimization done on local variable references.
5577 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5579 * ecore.cs: Convert the return from Ldlen into an int.
5581 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5583 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5584 the accessibility, this is a special case for toplevel non-public
5585 classes (internal for instance).
5587 2003-10-20 Nick Drochak <ndrochak@gol.com>
5589 * ecore.cs: Fix typo and build. Needed another right paren.
5591 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5593 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5594 `internal' case regular and protected, but not allowing protected
5595 to be evaluated later. Bug 49840
5597 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5599 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5600 to kb.Nlast, and not the kb.nFirst to isolate the switch
5603 Extract the underlying type, so enumerations of long/ulong are
5604 treated like long/ulong.
5606 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5608 * expression.cs (New): Overload the meaning of RequestedType to
5609 track the possible creation of the NewDelegate type, since
5610 DoResolve is invoked more than once for new constructors on field
5613 See bugs: #48800 and #37014
5615 * cs-parser.jay (declare_local_constants): Take an arraylist
5616 instead of a single constant.
5618 (local_constant_declaration): It should take a
5619 constant_declarators, not a constant_declarator. Fixes 49487
5621 * convert.cs: Fix error report.
5623 2003-10-13 Jackson Harper <jackson@ximian.com>
5625 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5628 2003-11-03 Martin Baulig <martin@ximian.com>
5630 * expression.cs (ArrayAccess.GetStoreOpcode): Added
5631 `out bool has_type_arg'; if set, we need to pass the type to
5633 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
5634 Stelem_Any/Ldelem_Any for generic parameters.
5636 2003-11-02 Martin Baulig <martin@ximian.com>
5638 * expression.cs (Invocation.EmitCall): Use
5639 `TypeManager.IsValueType()' to check whether it's a value type.
5640 Don't set `struct_call' when calling a method on a type parameter.
5642 2003-11-02 Martin Baulig <martin@ximian.com>
5644 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
5645 and removed the TypeBuilder argument.
5647 * typemanager.cs (TypeManager.IsValueType): Return
5648 `t.IsGenericParameter || t.IsValueType'.
5650 2003-10-25 Martin Baulig <martin@ximian.com>
5652 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
5653 call ConstructedType.Resolve() on it.
5655 * generic.cs (ConstructedType.Resolve): Set `type' on success.
5657 2003-10-25 Martin Baulig <martin@ximian.com>
5659 * class.cs (TypeContainer.GetClassBases): Changed
5660 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
5661 CS8214 reporting here.
5662 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
5663 instead of a `Type' for our parent. In case of a recursive
5664 declaration (see tests/gen-23.cs for an example), our parent is a
5665 ConstructedType and it doesn't have its type set. So, first
5666 create our own TypeBuilder, then call constructed.Resolve() to get
5667 the parent's type and finally TypeBuilder.SetParent() it.
5669 * ecore.cs (TypeExpr.Name): New public virtual property.
5672 (ConstructedType): We're now a TypeExpr and not just an Expression.
5673 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
5674 arguments here; this is done later.
5675 (ConstructedType.Resolve): New public method to resolve the type
5676 arguments and bind them.
5678 2003-10-21 Martin Baulig <martin@ximian.com>
5680 * convert.cs: Use `TypeManager.IsValueType' instead of
5681 'type.IsValueType' everywhere.
5683 * typemanager.cs (TypeManager.IsValueType): Return true for type
5684 parameters. The reason for this is that we need to box a type
5685 parameter when converting it to a reference type.
5687 * cs-parser.jay: Added support for default value expressions.
5689 * generics.cs (DefaultValueExpression): New public class.
5691 2003-10-17 Martin Baulig <martin@ximian.com>
5693 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
5694 TypeContainer so we can also use this for Interfaces.
5695 (TypeParameter.Resolve): Likewise.
5697 * interface.cs (Interface.DefineType): Added support for generic
5700 * cs-parser.jay: Added support for generic structs and interfaces.
5702 2003-10-17 Martin Baulig <martin@ximian.com>
5704 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
5705 call generic methods :-)
5707 2003-10-16 Martin Baulig <martin@ximian.com>
5709 * cs-parser.jay (namespace_or_type_name): Only create a
5710 GenericMemberAccess if we actually have type arguments.
5712 2003-10-13 Martin Baulig <martin@ximian.com>
5714 * class.cs (Method.Define): If we're a generic method, call
5715 TypeBuilder.DefineGenericMethod () before resolving
5717 (MethodData): Added .ctor which takes an additional MethodBuilder
5718 argument; this is used for generic methods.
5719 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
5720 we already have a MethodBuilder.
5722 2003-10-10 Martin Baulig <martin@ximian.com>
5724 * class.cs (Method): Added .ctor which takes a `GenericMethod'
5725 instead of a `DeclSpace'. This is used for generic methods.
5727 * cs-parser.jay (method_header): Added support for generic
5728 methods; create a `GenericMethod' instance and pass it to the
5729 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
5730 parameters and locals.
5732 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
5733 since we already have the location. Check whether we're a generic
5734 type declaration or a generic method and create the correct type
5737 * generic.cs (TypeParameter.DefineMethod): New public method.
5738 (GenericMethod): New public class; derives from DeclSpace and is
5739 used for generic methods.
5741 2003-10-09 Martin Baulig <martin@ximian.com>
5743 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5745 (MethodCore.DoDefineParameters): Removed the TypeContainer
5746 argument; use the DeclSpace which was passed to the .ctor instead.
5747 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5748 TypeContainer; we only need a DeclSpace here.
5750 2003-10-09 Martin Baulig <martin@ximian.com>
5752 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5754 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5755 EmitContext's .ctor.
5757 2003-10-09 Martin Baulig <martin@ximian.com>
5759 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5760 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5761 AsAccessible(), moved them as well.
5763 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5765 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5767 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5768 generation for >=, as spotted by Paolo, bug 48679.
5769 Patch from David Waite.
5771 * cs-tokenizer.cs: Add handling for #pragma.
5773 * cs-parser.jay: Allow for both yield and yield return in the
5774 syntax. The anti-cobolization of C# fight will go on!
5776 * class.cs (TypeBuilder.DefineType): Catch error condition here
5777 (Parent.DefineType erroring out and returning null).
5779 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5780 coping with enumerations variables, we were mistakenly processing
5781 them as a regular value type instead of built-in types. Fixes the
5784 * typemanager.cs (IsBuiltinOrEnum): New method.
5786 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5788 * cs-parser.jay: Upgrade: yield now needs the return clause.
5790 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5792 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5794 2003-09-29 Martin Baulig <martin@ximian.com>
5796 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
5797 inflated generic methods.
5799 * generics.cs (ConstructedType): Distinguish between open and
5800 closed constructed types; correctly resolve the arguments.
5802 2003-09-22 Martin Baulig <martin@ximian.com>
5804 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
5805 all type arguments meet their constraints.
5807 2003-09-19 Martin Baulig <martin@ximian.com>
5809 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5810 `MemberCache parent' argument. Normally, an interface doesn't
5811 have a parent type except System.Object, but we use this in gmcs
5812 for generic type parameters.
5814 2003-09-18 Martin Baulig <martin@ximian.com>
5816 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5817 on `type.IsInterface'; don't check whether the type has a parent
5818 to determine whether it's an interface.
5820 2003-09-17 Martin Baulig <martin@ximian.com>
5822 * generic.cs (ConstructedType.ToString): Always use `name' as the
5825 2003-09-15 Martin Baulig <martin@ximian.com>
5827 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
5829 * generic.cs (Constraints.Resolve): New public method; this is
5830 called to resolve the constraint types and to check whether all
5831 the constraints are correct.
5832 (Constraints.Types): New public property.
5833 (TypeParameter.Resolve): New public method; resolves all the
5836 * class.cs (TypeContainer.DefineType): Call
5837 TypeParameter.Resolve() before actually defining the type.
5839 2003-09-15 Martin Baulig <martin@ximian.com>
5841 * class.cs (TypeContainer.DefineType): Added an error flag to
5842 avoid reporting duplicate CS0146's ("class definition is
5845 * driver.cs (Driver.MainDriver): Abort if
5846 RootContext.ResolveTree() reported any errors.
5848 2003-09-07 Martin Baulig <martin@ximian.com>
5850 * report.cs (Error, Warning): Added overloaded versions which take
5851 a `params object[] args' and call String.Format().
5853 2003-09-07 Martin Baulig <martin@ximian.com>
5855 * decl.cs (DeclSpace..ctor): Don't call
5856 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5857 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5858 (DeclSpace.RecordDecl): New method.
5860 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5862 2003-09-02 Ravi Pratap <ravi@ximian.com>
5864 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5865 value attributes to be applied to ParameterBuilders.
5867 * class.cs (MethodCore.LabelParameters): Make static and more
5868 generic so that it can be used from other places - like interface
5869 methods, for instance.
5871 * interface.cs (Interface.Emit): Call LabelParameters before
5872 emitting attributes on the InterfaceMethod.
5874 2003-09-07 Martin Baulig <martin@ximian.com>
5876 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
5877 if the number of type parameters doesn't match.
5879 2003-09-04 Martin Baulig <martin@ximian.com>
5881 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
5882 for arrays of generic type params (ie. `!0[]').
5884 2003-09-04 Martin Baulig <martin@ximian.com>
5886 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
5889 2003-09-04 Martin Baulig <martin@ximian.com>
5891 * decl.cs (DeclSpace.LookupGeneric): New method.
5892 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
5895 * generic.cs (TypeParameterExpr): Take a TypeParameter as
5896 argument, not just a string.
5897 (TypeParameter.Define): New public method; this is called to
5898 actually define the generic parameter; after this, you can use the
5899 new `Type' property to get the type.
5901 2003-09-04 Martin Baulig <martin@ximian.com>
5903 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
5904 is now an ArrayList; initialize the result of the `TypeParameters'
5906 (DeclSpace.GetGenericData): Removed.
5907 (DeclSpace.LookupGeneric): Temporarily removed; we need to
5908 implement this in a different way.
5909 (DeclSpace.GetTypeParameters): Removed; there's now a
5910 `TypeParameters' property.
5911 (DeclSpace.TypeParameters): New public property.
5913 * generic.cs (Constraints): Make this class public.
5914 (TypeParameter): New public class.
5916 2003-09-04 Martin Baulig <martin@ximian.com>
5918 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
5921 * class.cs (TypeContainer.DefineType): Call
5922 TypeBuilder.DefineGenericParameter () on all generic parameters if
5923 this is a generic type.
5925 2003-08-28 Martin Baulig <martin@ximian.com>
5927 * sample-stack.il: Compile this with ilasm: "ilasm /dll
5930 * sample-hello.cs: Compile this with gmcs: "gmcs
5931 /r:sample-stack.dll sample-hello.cs".
5933 2003-08-28 Martin Baulig <martin@ximian.com>
5935 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
5936 the parameters to the generic type.
5938 2003-08-28 Martin Baulig <martin@ximian.com>
5940 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
5942 2003-08-28 Martin Baulig <martin@ximian.com>
5944 * cs-parser.jay (opt_type_argument_list): Use
5945 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
5946 (primary_expression): Replace `qualified_identifier' with `type_name'.
5947 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
5949 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
5950 parser to check whether it is syntactically a type parameter list;
5951 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
5954 2003-08-26 Martin Baulig <martin@ximian.com>
5956 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5957 resolving aliases; fixes #47927.
5959 2003-08-26 Martin Baulig <martin@ximian.com>
5961 * statement.cs (Using.DoResolve): This is internally emitting a
5962 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5963 do not always return. Fixes #47681.
5965 2003-08-26 Martin Baulig <martin@ximian.com>
5967 * decl.cs (MemberCore): Moved WarningNotHiding(),
5968 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5970 (AdditionResult): Make this nested in DeclSpace.
5971 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5972 argument; call NamespaceEntry.Define() unless we're nested in a
5975 * namespace.cs (Namespace.DefineName): New public function. This
5976 is called from DeclSpace's .ctor to add
5977 (Namespace.Lookup): Include DeclSpaces in the lookup.
5979 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5981 * const.cs (Const): Derive from MemberBase, not MemberCore.
5983 2003-08-25 Martin Baulig <martin@ximian.com>
5985 * convert.cs (Convert.ExplicitReferenceConversion): When
5986 converting from an interface type to a class, unbox if the target
5987 type is a struct type. Fixes #47822.
5989 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5991 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5994 2003-08-22 Martin Baulig <martin@ximian.com>
5996 * class.cs (TypeManager.DefineType): When defining a nested type,
5997 call DefineType() on our parent; fixes #47801.
5999 2003-08-22 Martin Baulig <martin@ximian.com>
6001 * class.cs (MethodData.Define): While checking if a method is an
6002 interface implementation, improve the test a bit more to fix #47654.
6004 2003-08-22 Martin Baulig <martin@ximian.com>
6006 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
6007 correctly; fixes #47722.
6009 2003-08-22 Martin Baulig <martin@ximian.com>
6011 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
6012 LocalVariableReference, ensure it's not read-only. Fixes #47536.
6014 * statement.cs (Fixed.DoResolve): Make all variables read-only.
6016 2003-08-22 Martin Baulig <martin@ximian.com>
6018 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
6019 can only be assigned in static constructors. Fixes #47161.
6021 2003-08-22 Martin Baulig <martin@ximian.com>
6023 Rewrote and improved the flow analysis code.
6025 * flowbranching.cs (FlowBranching): Make this class abstract.
6026 (FlowBranching.CreateBranching): New static function to create a
6028 (FlowBranchingBlock, FlowBranchingException): New classes.
6029 (FlowBranching.UsageVector.Type): New public readonly field.
6030 (FlowBranching.UsageVector.Breaks): Removed the setter.
6031 (FlowBranching.UsageVector.Returns): Removed the setter.
6032 (FlowBranching.UsageVector): Added Break(), Return(),
6033 NeverReachable() and Throw() methods to modify the reachability.
6034 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
6035 done by FlowBranching.Merge().
6036 (FlowBranching.UsageVector.MergeChild): New method; merges the
6037 merge result into the current vector.
6038 (FlowBranching.Merge): New abstract method to merge a branching.
6040 2003-08-12 Martin Baulig <martin@ximian.com>
6042 * expression.cs (Indirection.CacheTemporaries): Create the
6043 LocalTemporary with the pointer type, not its element type.
6045 2003-08-10 Miguel de Icaza <miguel@ximian.com>
6047 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
6048 token was a keyword or not.
6050 Add `error' options where an IDENTIFIER was expected; Provide
6051 CheckToken and CheckIdentifierToken convenience error reporting
6054 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
6056 * decl.cs: Rename `NamespaceEntry Namespace' public field into
6057 NameSpaceEntry NameSpaceEntry.
6059 (LookupInterfaceOrClass): Avoid creating a full qualified name
6060 from namespace and name: avoid doing lookups when we know the
6061 namespace is non-existant. Use new Tree.LookupByNamespace which
6062 looks up DeclSpaces based on their namespace, name pair.
6064 * driver.cs: Provide a new `parser verbose' to display the
6065 exception thrown during parsing. This is turned off by default
6066 now, so the output of a failure from mcs is more graceful.
6068 * namespace.cs: Track all the namespaces defined in a hashtable
6071 (IsNamespace): New method
6073 2003-08-09 Miguel de Icaza <miguel@ximian.com>
6075 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
6076 we know that we need to concatenate (full typename can never be
6081 * statement.cs: Use a bitfield; Do not initialize to null things
6082 which are done by the constructor by default.
6084 * cs-parser.jay: bug fix, parameter was 4, not 3.
6086 * expression.cs: Just use the property;
6088 * statement.cs: No need for GetVariableInfo method.
6090 2003-08-08 Martin Baulig <martin@ximian.com>
6092 * flowanalysis.cs (FlowReturns): This is now nested in the
6093 `FlowBranching' class.
6094 (MyBitVector): Moved this here from statement.cs.
6095 (FlowBranching.SiblingType): New enum type.
6096 (FlowBranching.CreateSibling): Added `SiblingType' argument.
6098 2003-08-07 Martin Baulig <martin@ximian.com>
6100 * flowanalysis.cs (FlowBranchingType): This is now nested in the
6101 `FlowBranching' class and called `BranchingType'.
6103 2003-08-07 Martin Baulig <martin@ximian.com>
6105 * flowanalysis.cs: Moved all the control flow analysis code into
6108 2003-08-07 Martin Baulig <martin@ximian.com>
6110 * assign.cs (Assign.DoResolve): `target' must either be an
6111 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
6114 2003-08-07 Miguel de Icaza <miguel@ximian.com>
6116 * expression.cs (BinaryMethod): This kind of expression is created by the
6117 Binary class if it determines that the operator has to be handled
6120 (BinaryDelegate): This kind of expression is created if we are
6121 dealing with a + or - operator on delegates.
6123 (Binary): remove method, argumetns, and DelegateOperator: when
6124 dealing with methods,
6126 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
6128 * statement.cs (Block): use bitfields for the three extra booleans
6129 we had in use. Remove unused topblock parameter.
6131 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
6133 * assign.cs: Drop extra unneeded tests.
6135 2003-08-06 Miguel de Icaza <miguel@ximian.com>
6137 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
6139 * statement.cs (Foreach): Use VariableStorage instead of
6142 * codegen.cs (VariableStorage): New class used by clients that
6143 require a variable stored: locals or fields for variables that
6144 need to live across yield.
6146 Maybe provide a convenience api for EmitThis+EmitLoad?
6148 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
6151 2003-08-05 Miguel de Icaza <miguel@ximian.com>
6153 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
6154 RemapParameterLValue): New methods that are used to turn a
6155 precomputed FieldInfo into an expression like this:
6159 The idea is to use this instead of making LocalVariableReference
6160 have more than one meaning.
6162 * cs-parser.jay: Add error production to BASE.
6164 * ecore.cs: Deal with TypeManager.GetField returning null, which
6165 is now a valid return value.
6167 (FieldExprNoAddress): New expression for Fields whose address can
6170 * expression.cs (LocalVariableReference): During the resolve
6171 phases, create new expressions if we are in a remapping context.
6172 Remove code that dealt with remapping here.
6174 (ParameterReference): same.
6176 (ProxyInstance): New expression, like the `This' expression, but
6177 it is born fully resolved. We know what we are doing, so remove
6178 the errors that are targeted to user-provided uses of `this'.
6180 * statement.cs (Foreach): our variable is now stored as an
6181 Expression; During resolution, follow the protocol, dont just
6182 assume it will return this.
6184 2003-08-06 Martin Baulig <martin@ximian.com>
6186 * support.cs (SeekableStreamReader.cs): New public class.
6188 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
6189 SeekableStreamReader instead of the normal StreamReader.
6191 2003-08-04 Martin Baulig <martin@ximian.com>
6193 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
6194 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
6195 deambiguate casts and delegate invocations.
6196 (parenthesized_expression): Use the new tokens to ensure this is
6197 not a cast of method invocation.
6199 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
6200 when reading a `)' and Deambiguate_CloseParens () was previously
6203 * expression.cs (ParenthesizedExpression): New class. This is
6204 just used for the CS0075 test.
6205 (Binary.DoResolve): Check for CS0075.
6207 2003-07-29 Ravi Pratap <ravi@ximian.com>
6209 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
6210 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
6211 reference comparison.
6213 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
6214 examine the ReturnType for equality - this is necessary in the
6215 cases of implicit and explicit operators whose signature also
6216 includes the return type.
6218 2003-07-26 Miguel de Icaza <miguel@ximian.com>
6220 * namespace.cs: Cache the result of the namespace computation,
6221 instead of computing it every time.
6223 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6225 * decl.cs: Use a global arraylist that we reuse over invocations
6226 to avoid excesive memory consumption. Reduces memory usage on an
6227 mcs compile by one meg (45 average).
6229 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6230 private, work around that.
6232 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6234 * literal.cs (IntLiteral): Define Zero and One static literals.
6236 * cs-parser.jay (integer_literal): use static literals to reduce
6237 memory usage for the most used literals (0, 1 and -1). 211kb
6238 reduced in memory usage.
6240 Replace all calls to `new ArrayList' with `new
6241 ArrayList(4)' which is a good average number for most allocations,
6242 and also requires only 16 bytes of memory for its buffer by
6245 This reduced MCS memory usage in seven megabytes for the RSS after
6248 2003-07-28 Ravi Pratap <ravi@ximian.com>
6250 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6251 handle params methods the correct way by forming only one
6252 applicable set with params and normal methods in them. Earlier we
6253 were looking at params methods only if we found no normal methods
6254 which was not the correct thing to do.
6256 (Invocation.BetterFunction): Take separate arguments indicating
6257 when candidate and the best method are params methods in their
6260 This fixes bugs #43367 and #46199.
6262 * attribute.cs: Documentation updates.
6264 (CheckAttribute): Rename to CheckAttributeTarget.
6265 (GetValidPlaces): Rename to GetValidTargets.
6267 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6268 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6272 2003-07-28 Miguel de Icaza <miguel@ximian.com>
6274 * codegen.cs: Compute IsGeneric correctly.
6276 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
6279 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
6280 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
6281 regressions, and I was chasing more bugs than I required.
6283 * interface.cs: Use expressions for base type names (like classes
6284 and structs have been doing for a while now), and resolve that.
6285 This patch should probably go into head as well.
6287 This makes it one less user of FindType.
6289 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6291 This compiler can not self host currently. Need to fix that.
6293 * Makefile: compile to `gmcs.exe'
6295 * driver.cs: Turn on v2 by default on gmcs.
6297 * generic.cs (ConstructedType): Does no longer take a container
6298 type argument; That will be taken care of later.
6300 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
6301 Use SimpleName to resolve for now, so we can continue the work on
6302 the parser, until we get Type.GetType that understands generics.
6304 (ConstructedType.ToString): Implement
6306 (TypeArguments.Resolve): Resolve the child expressions as types.
6308 * cs-parser.jay: Rename interface_constraints to
6309 type_parameter_constraints
6311 (namespace_or_type_name): Only use constructed types for the basic
6312 construction, we will deal with identifier<...> later.
6314 (type/type_name): No longer call DecomposeQI, as
6315 namespace_or_type_name is always decoded now.
6317 2003-07-22 Ravi Pratap <ravi@ximian.com>
6319 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6320 closely: we eliminate methods in base types when we have an
6321 applicable method in a top-level type.
6323 Please see section 14.5.5.1 for an exact description of what goes
6326 This fixes bug #45127 and a host of other related to corlib compilation.
6328 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6329 array is the method corresponding to the top-level type (this is
6330 because of the changes made to icall.c) so we change this
6333 (MethodGroupExpr.Name): This too.
6335 * typemanager.cs (GetElementType): New method which does the right
6336 thing when compiling corlib.
6338 * everywhere: Make use of the above in the relevant places.
6340 2003-07-22 Martin Baulig <martin@ximian.com>
6342 * cs-parser.jay (invocation_expression): Moved
6343 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6344 `cast_expression', but create a InvocationOrCast which later
6345 resolves to either an Invocation or a Cast.
6347 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6348 method; call this before EmitStatement() to make sure that this
6349 expression can be used as a statement.
6351 * expression.cs (InvocationOrCast): New class; resolves to either
6352 an Invocation or a Cast.
6354 * statement.cs (StatementExpression): Call ResolveStatement() on
6355 the ExpressionStatement before emitting it.
6357 2003-07-21 Martin Baulig <martin@ximian.com>
6359 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6360 `ref' and `out' attributes match; fixes #46220.
6361 (MemberAccess.ResolveMemberAccess): You can't reference a type
6362 through an expression; fixes #33180.
6363 (Indexers.GetIndexersForType): Don't return the indexers from
6364 interfaces the class implements; fixes #46502.
6366 2003-07-21 Martin Baulig <martin@ximian.com>
6368 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6369 CS0661 checks; fixes bug #30442.
6371 2003-07-21 Martin Baulig <martin@ximian.com>
6373 * decl.cs (AdditionResult): Added `Error'.
6375 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6377 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
6378 cs0031.cs actually work.
6380 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6382 * cs-parser.jay (namespace_name): do not use
6383 namespace_or_type_name, use qualified_identifier, because
6384 namespace_or_type_name will soon return a composed expression
6385 instead of a string.
6387 (namespace_or_type_name): Instead of returning a string, now this
6388 production returns an expression.
6390 * codegen.cs (EmitContext): Setup IsGeneric property based on
6391 whether our DeclSpace is generic, our the method is generic.
6393 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
6394 the method is generic.
6396 * cs-parser.jay (type_arguments, opt_type_argument_list,
6397 type_parameters, type_parameter_list, opt_type_parameter_list,
6398 type_parameter,, opt_type_parameter_constraints_clauses,
6399 type_parameter_constraints_clauses,
6400 type_parameter_constraint_clause, type_parameter_constraint,
6401 interface_constraints): Add new production
6403 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
6404 DeclSpace is generic or not.
6406 (DeclSpace.SetParameterInfo): New routine, used to set the
6407 parameter info for a type.
6409 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
6410 returns a GenericTypeExpr
6412 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
6413 generic, lookup the generic argument.
6415 * attribute.cs: Do not allow TypeParameterExpressions in
6418 * class.cs: Do not allow the Main method to be defined in a
6421 * expression.cs (SizeOf): Do not allow generic types to be used as
6422 arguments to sizeof.
6424 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
6425 it: whether a type is generic or not. Only works for types we are
6426 currently building for now.
6428 2003-07-20 Martin Baulig <martin@ximian.com>
6430 * namespace.cs: Fixed that bug which caused a crash when compiling
6433 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6435 * typemanager.cs (LookupTypeReflection): Never expose types which
6436 are NotPublic, NestedPrivate, NestedAssembly, or
6437 NestedFamANDAssem. We used to return these, and later do a check
6438 that would report a meaningful error, but the problem is that we
6439 would not get the real match, if there was a name override.
6441 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6443 * namespace.cs (Namespace, Name): Do not compute the namespace
6444 name dynamically, compute it in the constructor. This reduced
6445 memory usage by 1697 KB.
6447 * driver.cs: Use --pause to pause at the end.
6449 2003-07-17 Peter Williams <peter@newton.cx>
6451 * Makefile: Change the name of the test target so that it doesn't
6452 conflict with the recursive test target.
6454 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6456 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6457 AddressOf): Do not use EmitThis, that was wrong, use the actual
6460 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6462 * class.cs (MethodData.Define): While checking if a method is an
6463 interface implementation, improve the test: If we are not public
6464 (use new test here: use the computed MethodAttributes directly,
6465 instead of the parsed modifier flags) check if the `implementing'
6466 method comes from an interface or not.
6468 * pending.cs (VerifyPendingMethods): Slightly better error
6471 * makefile: add test target that does the mcs bootstrap.
6473 2003-07-16 Ravi Pratap <ravi@ximian.com>
6475 * interface.cs (Define): Do nothing here since there are no
6476 members to populate etc. Move the attribute emission out of here
6477 since this was just totally the wrong place to put it. Attribute
6478 application happens during the 'Emit' phase, not in the 'Define'
6481 (Emit): Add this method and move the attribute emission here
6483 * rootcontext.cs (EmitCode): Call the Emit method on interface
6486 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6488 * expression.cs (OverloadResolve): Report error only if Location
6489 is not 'Null' which means that there was a probe going on.
6491 2003-07-14 Martin Baulig <martin@ximian.com>
6493 * expression.cs (ConditionalLogicalOperator): New public class to
6494 implement user defined conditional logical operators.
6495 This is section 14.11.2 in the spec and bug #40505.
6497 2003-07-14 Martin Baulig <martin@ximian.com>
6499 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6501 2003-07-14 Martin Baulig <martin@ximian.com>
6503 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6505 * ecore.cs (IVariable.VerifyFixed): New interface method.
6507 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6508 operator, check whether the variable is actually fixed. Fixes bug
6509 #36055. Set a variable definitely assigned when taking its
6510 address as required by the spec.
6512 * statement.cs (LocalInfo.IsFixed): New field.
6513 (LocalInfo.MakePinned): Set `IsFixed' to true.
6515 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6517 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6518 for .ctors, ensure that we only ask for members declared in the
6519 attribute type (BindingFlags.DeclaredOnly).
6523 * expression.cs (Error_WrongNumArguments): Report error 1501
6524 correctly the way CSC does.
6526 2003-07-13 Martin Baulig <martin@ximian.com>
6528 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6529 lookup on the fully qualified name, to make things like "X.X" work
6530 where "X.X" is a fully qualified type name, but we also have a
6531 namespace "X" in the using list. Fixes #41975.
6533 2003-07-13 Martin Baulig <martin@ximian.com>
6535 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6536 function. If we're a CompoundAssign, we need to create an embedded
6537 CompoundAssign, not an embedded Assign.
6538 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6541 2003-07-13 Martin Baulig <martin@ximian.com>
6543 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6544 work to fix bug #46088.
6546 2003-07-13 Ravi Pratap <ravi@ximian.com>
6548 * class.cs (Operator.Emit): Do not emit attributes here - it is
6549 taken care of by the Method class that we delegate too. This takes
6552 2003-07-10 Martin Baulig <martin@ximian.com>
6554 * expression.cs (TypeOfVoid): New class.
6555 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6557 2003-07-10 Martin Baulig <martin@ximian.com>
6559 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6562 2003-07-10 Martin Baulig <martin@ximian.com>
6564 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6565 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6567 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6569 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6571 2003-07-10 Martin Baulig <martin@ximian.com>
6573 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6574 of decimal. Fixes #42850.
6576 NOTE: I also fixed the created byte blob, but this doesn't work on
6577 the MS runtime and csc never produces any byte blobs for decimal
6580 2003-07-10 Martin Baulig <martin@ximian.com>
6582 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6583 structs; fixes #32068.
6584 (Block.AddChildVariableNames): Fixed #44302.
6586 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6588 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6590 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6592 * attribute.cs: And this test is onger needed.
6594 2003-07-08 Martin Baulig <martin@ximian.com>
6596 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6597 inaccessible types. Fixes #36313.
6599 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6601 * namespace.cs (NamespaceEntry): Create implicit entries for all
6602 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6603 implicit entries for N1.N2 and N1.
6605 2003-07-08 Martin Baulig <martin@ximian.com>
6607 Rewrote the handling of namespaces to fix a lot of the issues
6608 wrt. `using' aliases etc.
6610 * namespace.cs (Namespace): Splitted this class into a
6611 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6613 * typemanager.cs (TypeManager.IsNamespace): Removed.
6614 (TypeManager.ComputeNamespaces): Only compute namespaces from
6615 loaded assemblies here, not the namespaces from the assembly we're
6616 currently compiling.
6618 2003-07-08 Martin Baulig <martin@ximian.com>
6620 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6622 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6624 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6627 I thought about the memory savings here, but LookupTypeReflection
6628 is used under already very constrained scenarios. Compiling
6629 corlib or mcs only exposes one hit, so it would not really reduce
6630 any memory consumption.
6632 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6634 * typemanager.cs: fixes bug #45889 by only adding public types from
6635 other assemblies to the list of known types.
6637 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6639 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6640 on the type we resolved.
6642 2003-07-05 Martin Baulig <martin@ximian.com>
6644 * pending.cs (PendingImplementation.ParentImplements): Don't
6645 create the proxy if the parent is abstract.
6647 * class.cs (TypeContainer.DefineIndexers): Process explicit
6648 interface implementations first. Fixes #37714.
6650 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6652 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6653 defined recursively; but since we modify the input parameters
6654 (left is set to `this' temporarily), we reset this value if the
6655 left_is_explicit is false, which gives the original semantics to
6658 * literal.cs (NullPointer): new class used to represent a null
6659 literal in a pointer context.
6661 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6662 type is a pointer, use a NullPointer object instead of a
6663 NullLiteral. Closes 43687
6665 (ExplicitConversion): Convert pointer values using
6666 the conv opcode to the proper type.
6668 * ecore.cs (New): change ValueTypeVariable property into a method,
6669 that returns whether the valuetype is suitable for being used.
6671 * expression.cs (Binary.DoNumericPromotions): Only return if we
6672 the int constant was a valid uint, and we can return both left and
6673 right as uints. If not, we continue processing, to trigger the
6674 type conversion. This fixes 39018.
6676 * statement.cs (Block.EmitMeta): During constant resolution, set
6677 the CurrentBlock property on the emitcontext, so that we resolve
6678 constants propertly.
6680 2003-07-02 Martin Baulig <martin@ximian.com>
6682 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6683 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6685 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6686 than emitting it here.
6688 * statement.cs: Fixed some more flow analysis bugs.
6690 2003-07-02 Martin Baulig <martin@ximian.com>
6692 * class.cs (MethodData.Define): When implementing interface
6693 methods, set Final unless we're Virtual.
6695 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6696 check work for interface methods.
6698 2003-07-01 Martin Baulig <martin@ximian.com>
6700 * ecore.cs (EmitContext.This): Replaced this property with a
6701 GetThis() method which takes a Location argument. This ensures
6702 that we get the correct error location for a CS0188.
6704 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6706 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6707 ImplicitStandardConversion.
6709 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6711 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6713 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6716 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6718 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6721 (MethodData.Define): Turn off initlocals for unsafe methods.
6723 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6725 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6726 complete; Fixes #37521.
6728 * delegate.cs: Use Modifiers.TypeAttr to compute the
6729 TypeAttributes, instead of rolling our own. This makes the flags
6730 correct for the delegates.
6732 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6734 * class.cs (Constructor.Define): Set the private flag for static
6735 constructors as well.
6737 * cs-parser.jay (statement_expression): Set the return value to
6738 null, to avoid a crash when we catch an error.
6740 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6742 * cs-parser.jay: Applied patch from Jackson that adds support for
6743 extern and unsafe modifiers to destructor declarations.
6745 * expression.cs: Report error 21 if the user is trying to index a
6748 * driver.cs: Add an error message, suggested by the bug report.
6750 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6751 if we do not have a ": this ()" constructor initializer. Fixes 45149
6753 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6755 * namespace.cs: Add some information to reduce FAQs.
6757 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6759 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6760 underlying enumeration types. Fixes #43915.
6762 * expression.cs: Treat ushort/short as legal values to be used in
6765 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6767 * delegate.cs: transfer custom attributes for paramenters from
6768 the delegate declaration to Invoke and BeginInvoke.
6770 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6772 * attribute.cs: handle custom marshalers and emit marshal info
6775 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6777 * makefile.gnu: Added anonymous.cs to the compiler sources.
6779 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6781 * iterators.cs: Change the name of the proxy class to include two
6784 * cs-parser.jay: Update grammar to include anonymous methods.
6786 * anonymous.cs: new file.
6788 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6790 * class.cs (Field.Define): Add missing test for pointers and
6793 2003-05-27 Ravi Pratap <ravi@ximian.com>
6795 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6796 we use the stobj opcode.
6798 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6799 since it wasn't the correct fix.
6801 It still is puzzling that we are required to use stobj for IntPtr
6802 which seems to be a ValueType.
6804 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6806 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6807 during regular simple name resolution. Now, the trick is that
6808 instead of returning for processing the simplename, we do a
6809 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6810 contextual lookup type). If a match is found, return that, if
6811 not, return for further composition.
6813 This fixes long-standing 30485.
6815 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6816 using the address to initialize an object, do an Stobj instead of
6817 using the regular Stelem.
6819 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6820 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6821 Because if we are a BaseIndexerAccess that value will be true.
6824 * statement.cs (GotoCase.Resolve): Return after reporting an
6825 error, do not attempt to continue.
6827 * expression.cs (PointerArithmetic.Emit): If our operand is a
6828 long, convert our constants to match the operand before
6829 multiplying. Convert to I type before adding. Fixes 43670.
6831 2003-05-14 Ravi Pratap <ravi@ximian.com>
6833 * enum.cs (ImplicitConversionExists) : Rename to
6834 ImplicitEnumConversionExists to remove ambiguity.
6836 * ecore.cs (NullCast): New type of cast expression class which
6837 basically is very similar to EmptyCast with the difference being
6838 it still is a constant since it is used only to cast a null to
6842 * convert.cs (ImplicitReferenceConversion): When casting a null
6843 literal, we return a NullCast.
6845 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6846 should be around anymore.
6848 The renaming (reported was slightly wrong). Corrections:
6850 ConvertImplicitStandard -> ImplicitConversionStandard
6851 ConvertExplicitStandard -> ExplicitConversionStandard
6853 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6854 before passing them in !
6856 * convert.cs (ImplicitConversionStandard): When comparing for
6857 equal expr and target types, ensure that expr is not a
6860 In general, we must not be checking (expr_type ==
6861 target_type) in the top level conversion methods
6862 (ImplicitConversion, ExplicitConversion etc). This checking is
6863 done in the methods that they delegate to.
6865 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6867 * convert.cs: Move Error_CannotConvertType,
6868 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6869 ImplicitNumericConversion, ImplicitConversionExists,
6870 ImplicitUserConversionExists, StandardConversionExists,
6871 FindMostEncompassedType, FindMostSpecificSource,
6872 FindMostSpecificTarget, ImplicitUserConversion,
6873 ExplicitUserConversion, GetConversionOperators,
6874 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6875 TryImplicitIntConversion, Error_CannotConvertImplicit,
6876 ConvertImplicitRequired, ConvertNumericExplicit,
6877 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6878 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6881 Perform the following renames:
6883 StandardConversionExists -> ImplicitStandardConversionExists
6884 ConvertImplicit -> ImplicitConversion
6885 ConvertImplicitStandard -> ImplicitStandardConversion
6886 TryImplicitIntConversion -> ImplicitIntConversion
6887 ConvertImplicitRequired -> ImplicitConversionRequired
6888 ConvertNumericExplicit -> ExplicitNumericConversion
6889 ConvertReferenceExplicit -> ExplicitReferenceConversion
6890 ConvertExplicit -> ExplicitConversion
6891 ConvertExplicitStandard -> ExplicitStandardConversion
6893 2003-05-19 Martin Baulig <martin@ximian.com>
6895 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6896 (TypeInfo): Added support for structs having structs as fields.
6898 * ecore.cs (FieldExpr): Implement IVariable.
6899 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6900 VariableInfo for the field.
6902 2003-05-18 Martin Baulig <martin@ximian.com>
6904 * expression.cs (This.DoResolve): Report a CS0027 if we're
6905 emitting a field initializer.
6907 2003-05-18 Martin Baulig <martin@ximian.com>
6909 * expression.cs (This.ResolveBase): New public function.
6910 (This.DoResolve): Check for CS0188.
6912 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6915 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6916 `instance_expression' to null if we don't have any non-static
6919 2003-05-18 Martin Baulig <martin@ximian.com>
6921 Reworked the way how local variables and parameters are handled by
6922 the flow analysis code.
6924 * statement.cs (TypeInfo, VariableMap): New public classes.
6925 (VariableInfo): New public class. This is now responsible for
6926 checking whether a variable has been assigned. It is used for
6927 parameters and local variables.
6928 (Block.EmitMeta): Take the InternalParameters as argument; compute
6929 the layout of the flow vectors here.
6930 (Block.LocalMap, Block.ParameterMap): New public properties.
6931 (FlowBranching): The .ctor doesn't get the InternalParameters
6932 anymore since Block.EmitMeta() now computes the layout of the flow
6934 (MyStructInfo): This class is now known as `StructInfo' and nested
6935 in `TypeInfo'; we don't access this directly anymore.
6937 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6938 property and removed IsAssigned(), IsFieldAssigned(),
6939 SetAssigned() and SetFieldAssigned(); we now call them on the
6940 VariableInfo so we don't need to duplicate this code everywhere.
6942 * expression.cs (ParameterReference): Added `Block block' argument
6944 (LocalVariableReference, ParameterReference, This): The new
6945 VariableInfo class is now responsible for all the definite
6948 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6949 IsParameterAssigned, SetParameterAssigned): Removed.
6951 2003-05-18 Martin Baulig <martin@ximian.com>
6953 * typemanager.cs (InitCoreTypes): Try calling
6954 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6955 the 3-args-version. Corlib now also needs our `void_type'.
6956 (GetMethod): Added overloaded version which takes an optional
6957 `bool report_errors' to allow lookups of optional methods.
6959 2003-05-12 Martin Baulig <martin@ximian.com>
6961 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6962 only used for locals and not for parameters.
6964 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6966 * support.cs (InternalParameters.ParameterType): Return the
6967 ExternalType of the parameter.
6969 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6972 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6974 * class.cs (MethodData.Define): Do not set the `newslot' on
6975 interface members, if they are also flagged as "override".
6977 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6978 better code for ++i and i++. This only works for static fields
6979 and local variables.
6981 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6982 want to pull the DeclSpace out of the builder_to_declspace instead
6983 of the TypeBuilder (like in TypeContainer.FindMembers).
6985 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6986 instead of LookupTypeContainer. Fixes the crash on .NET for
6987 looking up interface members.
6989 * const.cs: Create our own emit context during the Definition
6990 stage, so that constants are evaluated in the proper context, when
6991 a recursive definition happens.
6993 2003-05-11 Martin Baulig <martin@ximian.com>
6995 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6996 new block for a switch section.
6997 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6998 the adding/lookup in the switch block. Fixes #39828.
7000 2003-05-09 Miguel de Icaza <miguel@ximian.com>
7002 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
7003 functionality: I needed to convert the data after I had performed
7004 the add/sub operation into the operands type size.
7006 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
7007 pass the type for the box operation, otherwise the resulting
7008 object would have been of type object.
7010 (BoxedCast): Add constructor to specify the type to box as.
7012 2003-05-07 Miguel de Icaza <miguel@ximian.com>
7014 * iterators.cs: I was reusing the `count' variable inadvertently,
7015 take steps to not allow this to happen.
7017 2003-05-06 Miguel de Icaza <miguel@ximian.com>
7019 * attribute.cs (Attribute.Resolve): Params attributes are encoded
7020 by creating an array at the point where the params starts and
7021 putting all those arguments there, then adjusting the size of the
7024 2003-05-05 Miguel de Icaza <miguel@ximian.com>
7026 * expression.cs (New.AddressOf): Implement interface
7027 IMemoryLocation. This is used when the `new' operator is used in
7028 the context of an invocation to a method on a value type.
7030 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
7033 * namespace.cs: Also check the using aliases here.
7035 * driver.cs: Move the test for using validity after the types have
7036 been entered, so we do a single pass that also includes the using
7039 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
7040 in the regular case. CreateSiblingForFinally is doing extra
7043 * attribute.cs (GetAttributeArgumentExpression): Store the result
7044 on an out value, and use the return value to indicate failure
7045 instead of using null (which is a valid return for Constant.GetValue).
7047 * statement.cs: Perform the analysis flow for the increment
7048 portion after the statement, because this will be the real flow of
7049 execution. Fixes #42385
7051 * codegen.cs (EmitContext.EmitArgument,
7052 EmitContext.EmitStoreArgument): New helper functions when the
7053 RemapToProxy flag is set.
7055 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
7058 Add support for remapping parameters.
7060 * iterators.cs: Propagate parameter values; Store parameter
7061 values in the proxy classes.
7063 2003-05-04 Miguel de Icaza <miguel@ximian.com>
7065 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
7066 need a proxy reference; I do not know what I was thinking
7068 * cs-parser.jay (constructor_initializer): catch another error,
7069 and display nice message.
7071 (field_declaration): catch void field declaration
7072 to flag a better error.
7074 * class.cs (MemberBase.CheckBase): Report an error instead of a
7075 warning if a new protected member is declared in a struct.
7076 (Field.Define): catch the error of readonly/volatile.
7078 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
7080 (FieldExpr.AddressOf): ditto. Catch error where the address of a
7081 volatile variable is taken
7083 2003-05-02 Miguel de Icaza <miguel@ximian.com>
7085 * statement.cs (Fixed.Resolve): Report an error if we are not in
7088 2003-05-01 Miguel de Icaza <miguel@ximian.com>
7090 * typemanager.cs: reuse the code that handles type clashes for
7091 delegates and enumerations.
7093 * class.cs (Report28): Always report.
7095 * expression.cs (EncodeAsAttribute): Allow nulls here.
7097 2003-04-28 Miguel de Icaza <miguel@ximian.com>
7099 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
7100 the functionality for testing whether an expression is valid for
7101 an attribute here. Also handle the case of arrays of elements
7104 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
7105 encoding a linear array into an array of objects that are suitable
7106 to be passed to an CustomAttributeBuilder.
7108 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
7110 * ecore.cs: (FieldExpr): Handle field remapping here.
7112 * iteratators.cs: Pass the instance variable (if the method is an
7113 instance method) to the constructors, so we can access the field
7114 variables on the class.
7116 TODO: Test this with structs. I think the THIS variable on
7117 structs might have to be a pointer, and not a refenrece
7119 2003-04-27 Miguel de Icaza <miguel@ximian.com>
7121 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
7122 local variables to fields in a proxy class.
7124 * iterators.cs (PopulateProxy): Rename our internal fields to
7126 Create a <THIS> field if we are an instance method, so we can
7127 reference our parent container variables.
7128 (MapVariable): Called back from the EmitContext code to enter a
7129 new variable to field mapping into the proxy class (we just create
7133 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
7134 for using the remapped locals to fields.
7136 I placed the code here, because that gives the same semantics to
7137 local variables, and only changes the Emit code.
7139 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
7140 statements inside iterators.
7141 (VariableInfo): Add a FieldBuilder for the cases when we are
7142 remapping local variables to fields in a proxy class
7144 * ecore.cs (SimpleNameResolve): Avoid testing two times for
7145 current_block != null.
7147 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
7148 not cope with strings, as it has been moved to the
7149 TableSwitchEmit. Fixed bug in switch generation.
7151 * expression.cs (New.DoResolve): Provide more context for the user
7152 when reporting an error.
7154 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
7157 * expression.cs (MemberAccess.DoResolve): When we get a type back,
7158 check the permissions for it. Note than in a type-resolution
7159 context the check was already present in DeclSpace.ResolveType,
7160 but was missing from the MemberAccess.
7162 (ArrayCreation.CheckIndices): warn if the user has
7163 more nested levels of expressions, but there are no more
7164 dimensions specified. Avoids crash on bug 41906.
7166 2003-04-26 Miguel de Icaza <miguel@ximian.com>
7168 * statement.cs (Block): replace Implicit bool, for a generic
7170 New flag: `Unchecked'. This is used during the EmitMeta phase
7171 (which is out-of-line with the regular Resolve/Emit process for a
7172 statement, as this is done ahead of time, but still gets a chance
7173 to call constant resolve).
7175 (Block.Flags): new enum for adding a new flag.
7177 (Block.EmitMeta): track the state of unchecked.
7179 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
7180 to enable constant resolution to work there as well.
7182 2003-04-22 Miguel de Icaza <miguel@ximian.com>
7184 * typemanager.cs (ienumerable_type): Also look up
7185 System.Collections.IEnumerable.
7187 2003-04-21 Miguel de Icaza <miguel@ximian.com>
7189 TODO: Test more than one conditional per method.
7191 * class.cs (Indexer.Define): Report the location where the user is
7192 referencing the unsupported feature.
7194 (MethodData): Overload the use of `conditionals' to
7195 minimize the creation of needless ArrayLists. This saves roughly
7196 212kb on my machine.
7198 (Method): Implement the new IIteratorContainer interface.
7199 (Method.SetYields): Implement the method by setting the ModFlags
7200 to contain METHOD_YIELDS.
7202 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
7203 which just got set to null.
7205 * iterators.cs: New file.
7207 (Yield, YieldBreak): New statements.
7209 * statement.cs (Return.Resolve): Flag an error if we are used in
7212 * codegen.cs (InIterator): New flag set if the code is being
7213 compiled in an iterator method.
7215 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
7216 internal modifier, and we just use it to avoid adding extra
7217 fields, as this is seldom used.
7219 * cs-parser.jay: Add yield_statement (yield and yield break).
7221 * driver.cs: New flag -v2 to turn on version 2 features.
7223 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
7224 hashtable when v2 is enabled.
7226 2003-04-20 Miguel de Icaza <miguel@ximian.com>
7228 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
7229 there is already a namespace defined with this name.
7231 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
7232 people upgraded their corlibs.
7234 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7235 always use fully qualified types, no need to use the compiler
7238 (TypeManager.IsNamespace): Use binarysearch.
7240 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7241 AddDelegate): I did not quite use the new IsValid API properly: I
7242 have to pass the short-name and the fullname. I was passing only
7243 the basename instead of the fullname sometimes.
7245 (TypeContainer.DefineType): call NamespaceClash.
7247 * interface.cs (Interface.DefineType): use NamespaceClash before
7250 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7253 * enum.cs: (Enum.DefineType): use NamespaceClash before
7256 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7257 speed increase. First, use the negative_hits cache when we get a
7258 negative. Second, add the type with its full original name
7259 instead of the new . and + encoded name (reflection uses + to
7260 separate type from a nested type). Use LookupTypeReflection
7261 directly which bypasses the type->name hashtable (that we already
7262 know does not contain the type.
7264 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7265 location/container type.
7267 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7269 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7271 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7273 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7274 method is being referenced in the method group from a static
7275 context, and report error 120 if so.
7277 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7280 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7281 is created, we create the A namespace).
7283 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7286 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7288 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7289 invocation to ModuleBuilder.GetType with the same values will
7290 return a new type instance, so we need to cache its return
7293 * expression.cs (Binary.ResolveOperator): Only allow the compare
7294 operators on enums if they are of the same type.
7296 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7297 types of ValueType on their own case. Before we were giving them
7298 the same treatment as objects.
7300 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7301 fullname. Short name is used to compare against container name.
7302 Fullname is used to check against defined namespace names.
7304 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7305 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7307 (Method.CheckBase): Call parent.
7308 (MemberBase.CheckBase): Check for protected members on sealed
7310 (PropertyBase.CheckBase): Call parent.
7311 (Field.Define): Call parent.
7313 * report.cs: Negative error codes are now mapped to 8000 - code,
7314 so that the display is render more nicely.
7316 * typemanager.cs: Do not use try/catch, instead report a regular
7319 (GetPointerType, GetReferenceType): These methods provide
7320 mechanisms to obtain the T* and T& from a T. We had the code
7321 previously scattered around the code base, and it also used
7322 TypeManager.LookupType that would go through plenty of caches.
7323 This one goes directly to the type source.
7325 In some places we did the Type.GetType followed by
7326 ModuleBuilder.GetType, but not in others, so this unifies the
7329 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7330 statements now that we have namespace information.
7332 * typemanager.cs (IsNamespace): New method, returns whether the
7333 string presented is a namespace or not.
7335 (ComputeNamespaces): New public entry point, computes the list of
7336 available namespaces, using the GetNamespaces API call in Mono, or
7337 the slower version in MS.NET.
7339 Now before we start the semantic analysis phase, we have a
7340 complete list of namespaces including everything that the user has
7343 Deleted old code to cache namespaces in .nsc files.
7345 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7347 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7348 class/struct location definition Location for the implicit
7349 constructor location.
7351 (Operator.Define): Use the location of the operator for the
7352 implicit Method definition.
7354 (Constructor.Emit): use the constructor location for the implicit
7355 base initializer constructor.
7357 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7358 and the Expression class now contains two new methods:
7360 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7361 isolate type lookup from the rest of the resolution process.
7363 Since we use Expressions to hold type definitions due to the way
7364 we parse the input we have historically overloaded Resolve to
7365 perform the Type lookups if a special flag is passed. Now this is
7366 eliminated and two methods take their place.
7368 The differences in the two methods between xStep and xTerminal is
7369 that xStep is involved in our current lookup system that uses
7370 SimpleNames to compose a name, while xTerminal is used just to
7371 catch the case where the simplename lookup failed.
7373 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7375 * expression.cs (ResolveMemberAccess): Remove redundant code.
7376 TypeExpr expressions are always born fully resolved.
7378 * interface.cs (PopulateMethod): Do not lookup the types twice.
7379 We were doing it once during SemanticAnalysis and once during
7382 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7383 in local variable type definitions, were being returned as a
7384 SimpleName (we decomposed everything into a string), that is
7385 because primary_expression was being used instead of a type in the
7386 grammar (reduce/reduce conflicts).
7388 The part that was wrong is that we converted the expression into a
7389 string (an oversimplification in one hand, compounded with primary
7390 expressions doing string concatenation).
7396 Would return "A.B.C[]" as a SimpleName. This stopped things like
7397 using clauses from working on this particular context. And a type
7398 was being matched directly against "A.B.C[]".
7400 We now use the correct approach, and allow for ComposedCast to be
7401 part of the unary expression. So the "A.B.C []" become a composed
7402 cast of "A.B.C" (as a nested group of MemberAccess with a
7403 SimpleName at the end) plus the rank composition "[]".
7407 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7409 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7410 for the access level checking.
7412 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7413 `TypeContainer container', because I kept getting confused when I
7414 was debugging this code.
7416 * expression.cs (Indexers): Instead of tracking getters/setters,
7417 we now track them in parallel. We create one arraylist less, but
7418 most importantly it is possible now for the LValue code to find a
7419 matching get for a set.
7421 (IndexerAccess.DoResolveLValue): Update the code.
7422 GetIndexersForType has been modified already to extract all the
7423 indexers from a type. The code assumed it did not.
7425 Also make the code set the correct return type for the indexer.
7426 This was fixed a long time ago for properties, but was missing for
7427 indexers. It used to be void_type.
7429 (Binary.Emit): Test first for doubles instead of
7430 floats, as they are more common.
7432 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7433 when dealing with floats and the <=, >= operators. This fixes bug
7436 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7437 to load the array value by emitting a load on the foreach variable
7438 type. This was incorrect.
7440 We now emit the code to load an element using the the array
7441 variable type, and then we emit the conversion operator.
7445 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7447 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7449 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7451 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7452 test for protection before we test for signatures.
7454 (MethodSignature.ToString): implement.
7456 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7457 to the case where we reduced into a LongConstant.
7459 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7460 depend on whether the information is acurrate, because the
7461 Microsoft runtime will always claim that the array type is public,
7462 regardless of the real state.
7464 If the type is a pointer, another problem happens: the type is
7465 reported as non-public in Microsoft.
7467 In both cases we have to call CheckAccessLevel recursively with
7468 the underlying type as the argument to be tested.
7470 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7472 * assign.cs (Assign.Emit): If we are dealing with a compound
7473 assignment expression, we should use the code path that stores the
7474 intermediate result in a temporary value. This fixes #40903.
7476 *expression.cs (Indirection.ToString): Provide ToString method for
7479 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7481 * class.cs: Null out fields holding references to Block objects so
7482 they can be garbage collected.
7484 * expression.cs (OverloadResolve): Remove unused local.
7486 2003-04-07 Martin Baulig <martin@ximian.com>
7488 * codegen.cs (EmitContext.CurrentFile): New public field.
7489 (EmitContext.Mark): Use the CurrentFile to check whether the
7490 location is in the correct file.
7491 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7493 2003-04-07 Martin Baulig <martin@ximian.com>
7495 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7497 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7498 location. [FIXME: The location argument which gets passed to this
7499 method is sometimes wrong!]
7501 2003-04-07 Nick Drochak <ndrochak@gol.com>
7503 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7505 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7507 * expression.cs (Indirection.EmitAssign): We were using the
7508 temporary, but returning immediately instead of continuing the
7511 2003-04-06 Martin Baulig <martin@ximian.com>
7513 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7514 if it's a nested child, but also deriving from the outer class.
7517 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7518 nested child, but also deriving from the outer class. See
7520 (FilterWithClosure): We may access private members of the outer
7521 class if we're a nested child and deriving from the outer class.
7522 (RealMemberLookup): Only set `closure_private_ok' if the
7523 `original_bf' contained BindingFlags.NonPublic.
7525 2003-04-05 Martin Baulig <martin@ximian.com>
7527 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
7528 probe if its a type parameter, and if so, flag an error.
7530 * decl.cs: Move here the SetParameterInfo code from class.cs.
7531 Handle IsGeneric here.
7533 Handle a variety of errors in the parameter info definition.
7535 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
7536 type parameters here.
7538 * cs-parser.jay (class_declaration): report errors for parameters
7541 2003-01-21 Miguel de Icaza <miguel@ximian.com>
7543 * generic.cs: New file, contains support code for generics.
7545 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
7546 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
7548 Update parser for the above removals.
7550 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
7551 now taken care of in the parser.
7553 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7555 * class.cs (Event.Define): Do not allow abstract events to have
7558 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7560 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7561 block in event declarations.
7563 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7564 value type, get its address.
7566 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7567 leaving a class on the stack instead of a boolean value (int
7568 0/1). Change the code so we compare against null, and then the
7569 result against zero.
7571 * class.cs (TypeContainer.GetClassBases): We were checking for the
7572 parent class being sealed too late.
7574 * expression.cs (Binary.Emit): For <= and >= when dealing with
7575 floating point values, use cgt.un and clt.un instead of cgt and
7578 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7580 * statement.cs: Apply the same optimization as MS: skip the
7581 GetEnumerator returning an IEnumerator, and use the one returning a
7582 CharEnumerator instead. This allows us to avoid the try-finally block
7585 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7587 * cs-parser.jay: Attributes cannot be applied to
7588 namespaces. Fixes #40473
7590 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7593 (Add*): check if the name is valid using the full name for constants,
7594 fields, properties and events.
7596 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7598 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7599 char constants to be part of the enumeration.
7601 * expression.cs (Conditional.DoResolve): Add support for operator
7602 true. Implements the missing functionality from 14.12
7604 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7605 operator true/false as required by the spec.
7607 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7608 implicit conversion to boolean.
7610 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7611 also one where the type implements `operator true'.
7613 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7614 get an expression that will invoke operator true based on an
7617 (GetConversionOperators): Removed the hack that called op_True
7620 (Expression.ResolveBoolean): Move this from Statement.
7622 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7624 * ecore.cs (FieldExpr): do not allow initialization of initonly
7625 fields on derived classes
7627 2003-03-13 Martin Baulig <martin@ximian.com>
7629 * statement.cs (Block.Emit): Call ig.BeginScope() and
7630 ig.EndScope() when compiling with debugging info; call
7631 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7633 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7635 * expression.cs (Indexers): Do not construct immediately, allow
7636 for new members to be appended as we go. Fixes 38143
7638 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7640 * expression.cs: save/restore context when resolving an unchecked
7643 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7645 * cfold.cs: Catch division by zero in modulus operator during
7648 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7650 * interface.cs (Interface.DefineMembers): Avoid defining members
7653 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7655 * driver.cs: handle the +/- options for -noconfig
7657 * statement.cs (Unckeched.Resolve): Also track the state of
7658 unchecked in the Resolve phase.
7660 2003-02-27 Martin Baulig <martin@ximian.com>
7662 * ecore.cs (Expression.MemberLookup): Don't create a
7663 MethodGroupExpr for something which is not a method. Fixes #38291.
7665 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7667 * class.cs (MemberBase.CheckParameters): Also check that the type
7668 is unmanaged if it is a pointer.
7670 * expression.cs (SizeOf.Resolve): Add location information.
7672 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7673 a managed type is declared.
7675 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7676 parameter modifiers as well. Fixes bug 38606
7678 * class.cs: Very sad. Am backing out the speed up changes
7679 introduced by the ArrayList -> Array in the TypeContainer, as they
7680 were not actually that much faster, and introduced a bug (no error
7681 reports on duplicated methods).
7683 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7684 source first, this will guarantee that we have a valid expression
7685 before calling in lower levels functions that will require a
7686 resolved object. Then use this original_source in the
7687 target.ResolveLValue instead of the original source that was
7690 Another change. Use target.Resolve instead of LValueResolve.
7691 Although we are resolving for LValues, we will let the Assign code
7692 take care of that (it will be called again from Resolve). This
7693 basically allows code like this:
7695 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7696 class Y { void A (X x) { x [0] += o; }
7698 The problem was that the indexer was trying to resolve for
7699 set_Item (idx, object o) and never finding one. The real set_Item
7700 was set_Item (idx, X). By delaying the process we get the right
7705 2003-02-23 Martin Baulig <martin@ximian.com>
7707 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7708 while calling DoEmit ().
7710 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7711 source files; if you use the #line directive inside a method, the
7712 compiler stops emitting line numbers for the debugger until it
7713 reaches the end of the method or another #line directive which
7714 restores the original file.
7716 2003-02-23 Martin Baulig <martin@ximian.com>
7718 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7720 2003-02-23 Martin Baulig <martin@ximian.com>
7722 * statement.cs (Block.AddChildVariableNames): We need to call this
7723 recursively, not just for our immediate children.
7725 2003-02-23 Martin Baulig <martin@ximian.com>
7727 * class.cs (Event.Define): Always make the field private, like csc does.
7729 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7730 actually work, fixes bug #37521.
7732 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7734 * delegate.cs: When creating the various temporary "Parameters"
7735 classes, make sure that we call the ComputeAndDefineParameterTypes
7736 on those new parameters (just like we do with the formal ones), to
7737 allow them to be resolved in the context of the DeclSpace.
7739 This fixes the bug that Dick observed in Bugzilla #38530.
7741 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7743 * expression.cs (ResolveMemberAccess): When resolving a constant,
7744 do not attempt to pull a constant if the value was not able to
7745 generate a valid constant.
7747 * const.cs (LookupConstantValue): Do not report more errors than required.
7749 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7751 * expression.cs: fixes bug #38328.
7753 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7755 * class.cs: Changed all the various members that can be part of a
7756 class from being an ArrayList to be an Array of the right type.
7757 During the DefineType type_list, interface_list, delegate_list and
7758 enum_list are turned into types, interfaces, delegates and enums
7761 And during the member population, indexer_list, event_list,
7762 constant_list, field_list, instance_constructor_list, method_list,
7763 operator_list and property_list are turned into their real arrays.
7765 Although we could probably perform this operation earlier, for
7766 good error reporting we need to keep the lists and remove the
7767 lists for longer than required.
7769 This optimization was triggered by Paolo profiling the compiler
7770 speed on the output of `gen-sample-program.pl' perl script.
7772 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7773 not crash in methods like MemberLookupFailed that use this field.
7775 This problem arises when the compiler fails to resolve a type
7776 during interface type definition for example.
7778 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7780 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7781 inherit from System.Object, so we have to stop at null, not only
7782 when reaching System.Object.
7784 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7786 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7787 DeclaredOnly because the parent indexer might have had a different
7788 name, but did not loop until the top of the hierarchy was reached.
7790 The problem this one fixes is 35492: when a class implemented an
7791 indexer from an interface, we were getting the interface method
7792 (which was abstract) and we were flagging an error (can not invoke
7795 This also keeps bug 33089 functioning, and test-148 functioning.
7797 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7798 out if a method is special is to see if it is declared in a
7799 property or event, or whether it is one of the predefined operator
7800 names. This should fix correctly #36804.
7802 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7804 The goal here is to remove the dependency on EmptyCast.Peel ().
7805 Killing it completely.
7807 The problem is that currently in a number of places where
7808 constants are expected, we have to "probe" for an EmptyCast, and
7809 Peel, which is not the correct thing to do, as this will be
7810 repetitive and will likely lead to errors.
7812 The idea is to remove any EmptyCasts that are used in casts that
7813 can be reduced to constants, so we only have to cope with
7816 This bug hunt was triggered by Bug 37363 and the desire to remove
7817 the duplicate pattern where we were "peeling" emptycasts to check
7818 whether they were constants. Now constants will always be
7821 * ecore.cs: Use an enumconstant here instead of wrapping with
7824 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7825 throwing me off. By handling this we can get rid of a few hacks.
7827 * statement.cs (Switch): Removed Peel() code.
7829 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7831 * class.cs: Location information for error 508
7833 * expression.cs (New.DoResolve): Add a guard against double
7834 resolution of an expression.
7836 The New DoResolve might be called twice when initializing field
7837 expressions (see EmitFieldInitializers, the call to
7838 GetInitializerExpression will perform a resolve on the expression,
7839 and later the assign will trigger another resolution
7841 This leads to bugs (#37014)
7843 * delegate.cs: The signature for EndInvoke should contain any ref
7844 or out parameters as well. We were not doing this in the past.
7846 * class.cs (Field.Define): Do not overwrite the type definition
7847 inside the `volatile' group. Turns out that volatile enumerations
7848 were changing the type here to perform a validity test, which
7851 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7853 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7854 and structs, we do not want to load the instance variable
7856 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7857 enum_type has to be handled like an object reference (implicit
7858 conversions exists from this to object), but the regular IsClass
7859 and IsValueType tests will never return true for this one.
7861 Also we use TypeManager.IsValueType instead of type.IsValueType,
7862 just for consistency with the rest of the code (this is only
7863 needed if we ever use the construct exposed by test-180.cs inside
7864 corlib, which we dont today).
7866 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7868 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7871 2003-02-09 Martin Baulig <martin@ximian.com>
7873 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7874 (Namespace.DefineNamespaces): New static public method; this is
7875 called when we're compiling with debugging to add all namespaces
7878 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7879 pass it to the Namespace's .ctor.
7881 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7882 and MethodBase arguments; pass the namespace ID to the symwriter;
7883 pass the MethodBase instead of the token to the symwriter.
7884 (SymbolWriter.DefineNamespace): New method to add a namespace to
7887 2003-02-09 Martin Baulig <martin@ximian.com>
7889 * symbolwriter.cs: New file. This is a wrapper around
7890 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7891 methods here in near future.
7893 2003-02-09 Martin Baulig <martin@ximian.com>
7895 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7896 ILGenerator.MarkSequencePoint() which are actually used by the
7899 2003-02-09 Martin Baulig <martin@ximian.com>
7901 * location.cs (SourceFile): New public sealed class. This
7902 contains the name and an index which is used in the location's token.
7903 (Location): Reserve an appropriate number of bits in the token for
7904 the source file instead of walking over that list, this gives us a
7905 really huge performance improvement when compiling with debugging.
7907 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7908 `SourceFile' argument instead of a string.
7909 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7910 but don't parse/tokenize here, we need to generate the list of all
7911 source files before we do that.
7912 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7915 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7916 instead of a string.
7918 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7921 2003-02-09 Martin Baulig <martin@ximian.com>
7923 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7924 filename on `#line default'.
7926 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7928 * statement.cs: don't clear the pinned var when the fixed statement
7929 returns from the method (fixes bug#37752).
7931 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7933 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7936 2003-02-07 Martin Baulig <martin@ximian.com>
7938 * driver.cs: Removed the `--debug-args' command line argument.
7940 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7941 automatically by the AsssemblyBuilder.
7942 (CodeGen.InitializeSymbolWriter): We don't need to call any
7943 initialization function on the symbol writer anymore. This method
7944 doesn't take any arguments.
7946 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7948 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7949 from referenced assemblies as well.
7951 2003-02-02 Martin Baulig <martin@ximian.com>
7953 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7955 2003-02-02 Martin Baulig <martin@ximian.com>
7957 * class.cs (Constructor.Emit): Open the symbol writer before
7958 emitting the constructor initializer.
7959 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7960 single-stepping through constructor initializers.
7962 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7964 * class.cs: Handle error 549: do not allow virtual methods in
7967 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7969 * decl.cs: Check access levels when resolving types
7971 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7973 * statement.cs: Add parameters and locals set in catch blocks that might
7974 return to set vector
7976 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7978 * class.cs (Operator): Set the SpecialName flags for operators.
7980 * expression.cs (Invocation.DoResolve): Only block calls to
7981 accessors and operators on SpecialName methods.
7983 (Cast.TryReduce): Handle conversions from char constants.
7986 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7988 * statement.cs: small memory and time optimization in FlowBranching.
7990 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7992 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7993 problem that the last fix but in the other sid (Set).
7995 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7996 access when there is no indexer in the hierarchy.
7998 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
8000 * class.cs: Combine some if statements.
8002 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8004 * driver.cs: fixed bug #37187.
8006 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
8008 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
8009 any indexer, it's needed to build a list with all the indexers in the
8010 hierarchy (AllGetters), else we have problems. Fixes #35653.
8012 2003-01-23 Miguel de Icaza <miguel@ximian.com>
8014 * class.cs (MethodData.Define): It is wrong for an interface
8015 implementation to be static in both cases: explicit and implicit.
8016 We were only handling this in one case.
8018 Improve the if situation there to not have negations.
8020 * class.cs (Field.Define): Turns out that we do not need to check
8021 the unsafe bit on field definition, only on usage. Remove the test.
8023 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8025 * driver.cs: use assembly.Location instead of Codebase (the latest
8026 patch made mcs fail when using MS assemblies).
8028 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
8030 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
8031 get the path to *corlib.dll.
8033 2003-01-21 Nick Drochak <ndrochak@gol.com>
8037 * typemanager.cs: Remove compiler warnings
8039 2003-01-20 Duncan Mak <duncan@ximian.com>
8041 * AssemblyInfo.cs: Bump the version number to 0.19.
8043 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8045 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
8047 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
8049 * class.cs (Constructor::Emit): Emit debugging info for constructors.
8051 2003-01-17 Miguel de Icaza <miguel@ximian.com>
8053 * cs-parser.jay: Small fix: we were not comparing the constructor
8054 name correctly. Thanks to Zoltan for the initial pointer.
8056 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
8058 * cs-tokenizer.cs: Set file name when specified with #line
8060 2003-01-15 Miguel de Icaza <miguel@ximian.com>
8062 * cs-parser.jay: Only perform the constructor checks here if we
8063 are named like the class; This will help provider a better
8064 error. The constructor path is taken when a type definition is
8065 not found, but most likely the user forgot to add the type, so
8066 report that rather than the constructor error.
8068 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
8070 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
8073 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8075 * cs-parser.jay: Add cleanup call.
8077 2003-01-13 Duncan Mak <duncan@ximian.com>
8079 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
8080 consistent with other methods.
8082 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8084 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
8086 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
8088 * attribute.cs: only set GuidAttr to true when we have a
8091 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8095 * typemanager.cs: fixes to allow mcs compile corlib with the new
8096 Type.IsSubclassOf fix.
8098 2003-01-08 Miguel de Icaza <miguel@ximian.com>
8100 * expression.cs (LocalVariableReference.DoResolve): Classify a
8101 constant as a value, not as a variable. Also, set the type for
8104 * cs-parser.jay (fixed_statement): take a type instead of a
8105 pointer_type, so we can produce a better error message later.
8107 * statement.cs (Fixed.Resolve): Flag types that are not pointers
8110 (For.DoEmit): Make inifinite loops have a
8111 non-conditional branch back.
8113 (Fixed.DoEmit): First populate the pinned variables, then emit the
8114 statement, then clear the variables. Before I was emitting the
8115 code once for each fixed piece.
8118 2003-01-08 Martin Baulig <martin@ximian.com>
8120 * statement.cs (FlowBranching.MergeChild): A break in a
8121 SWITCH_SECTION does not leave a loop. Fixes #36155.
8123 2003-01-08 Martin Baulig <martin@ximian.com>
8125 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
8126 lives in the same number space than `param_map'. Fixes #36154.
8128 2003-01-07 Miguel de Icaza <miguel@ximian.com>
8130 * cs-parser.jay (constructor_declaration): Set the
8131 Constructor.ModFlags before probing for it. This makes the
8132 compiler report 514, 515 and 132 (the code was there, but got
8135 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
8136 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
8137 (GotoCase.Resolve): Set `Returns' to ALWAYS.
8139 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
8141 * enum.cs: create the enum static fields using the enum type.
8143 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
8145 * class.cs: don't try to create the ParamBuilder for the return
8146 type if it's not needed (and handle it breaking for the ms runtime
8149 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
8151 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
8153 2002-12-29 Miguel de Icaza <miguel@ximian.com>
8155 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
8156 the command. This showed up while compiling the JANET source
8157 code, which used \r as its only newline separator.
8159 2002-12-28 Miguel de Icaza <miguel@ximian.com>
8161 * class.cs (Method.Define): If we are an operator (because it
8162 reuses our code), then set the SpecialName and HideBySig. #36128
8164 2002-12-22 Miguel de Icaza <miguel@ximian.com>
8166 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
8167 exception, report error 120 `object reference required'.
8169 * driver.cs: Add --pause option, used during to measure the size
8170 of the process as it goes with --timestamp.
8172 * expression.cs (Invocation.DoResolve): Do not allow methods with
8173 SpecialName to be invoked.
8175 2002-12-21 Miguel de Icaza <miguel@ximian.com>
8177 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
8178 number before adding it.
8180 2002-12-21 Ravi Pratap <ravi@ximian.com>
8182 * ecore.cs (StandardImplicitConversion): When in an unsafe
8183 context, we allow conversion between void * to any other pointer
8184 type. This fixes bug #35973.
8186 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
8188 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
8189 is not thrown when extensionless outputs are used
8191 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8193 * rootcontext.cs: fixed compilation of corlib.
8195 2002-12-19 Miguel de Icaza <miguel@ximian.com>
8197 * attribute.cs (Attributes.Contains): Add new method.
8199 * class.cs (MethodCore.LabelParameters): if the parameter is an
8200 `out' parameter, check that no attribute `[In]' has been passed.
8202 * enum.cs: Handle the `value__' name in an enumeration.
8204 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
8206 * decl.cs: Added special case to allow overrides on "protected
8209 2002-12-18 Ravi Pratap <ravi@ximian.com>
8211 * attribute.cs (Attributes.AddAttributeSection): Rename to this
8212 since it makes much more sense.
8214 (Attributes.ctor): Don't require a Location parameter.
8216 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
8218 * attribute.cs (ApplyAttributes): Remove extra Location parameters
8219 since we already have that information per attribute.
8221 * everywhere : make appropriate changes.
8223 * class.cs (LabelParameters): Write the code which actually
8224 applies attributes to the return type. We can't do this on the MS
8225 .NET runtime so we flag a warning in the case an exception is
8228 2002-12-18 Miguel de Icaza <miguel@ximian.com>
8230 * const.cs: Handle implicit null conversions here too.
8232 2002-12-17 Ravi Pratap <ravi@ximian.com>
8234 * class.cs (MethodCore.LabelParameters): Remove the extra
8235 Type [] parameter since it is completely unnecessary. Instead
8236 pass in the method's attributes so that we can extract
8237 the "return" attribute.
8239 2002-12-17 Miguel de Icaza <miguel@ximian.com>
8241 * cs-parser.jay (parse): Use Report.Error to flag errors instead
8242 of ignoring it and letting the compile continue.
8244 * typemanager.cs (ChangeType): use an extra argument to return an
8245 error condition instead of throwing an exception.
8247 2002-12-15 Miguel de Icaza <miguel@ximian.com>
8249 * expression.cs (Unary.TryReduce): mimic the code for the regular
8250 code path. Perform an implicit cast in the cases where we can
8251 implicitly convert to one of the integral types, and then reduce
8252 based on that constant. This fixes bug #35483.
8254 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8256 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
8258 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8260 * namespace.cs: fixed bug #35489.
8262 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8264 * class.cs: Remove some dead code.
8266 * cs-parser.jay: Estimate the number of methods needed
8267 (RootContext.MethodCount);
8269 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8270 numbers instead of StringBuilders.
8272 * support.cs (PtrHashtable): Add constructor with initial size;
8273 We can now reduce reallocations of the method table.
8275 2002-12-10 Ravi Pratap <ravi@ximian.com>
8277 * attribute.cs (ApplyAttributes): Keep track of the emitted
8278 attributes on a per-target basis. This fixes bug #35413.
8280 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8282 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8283 default to the Windows 1252 encoding.
8285 (UnixParseOption): Support version, thanks to Alp for the missing
8288 * AssemblyInfo.cs: Add nice assembly information.
8290 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8293 * cs-parser.jay: Allow a trailing comma before the close bracked
8294 in the attribute_section production.
8296 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8297 address of the instance was being taken, I will take this out,
8298 because we take the address of the object immediately here.
8300 2002-12-09 Ravi Pratap <ravi@ximian.com>
8302 * typemanager.cs (AreMultipleAllowed): Take care of the most
8303 obvious case where attribute type is not in the current assembly -
8306 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8308 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8309 definitions, instead of doing that afterwards.
8311 Also we use a nice little hack, depending on the constructor, we
8312 know if we are a "composed" name or a simple name. Hence, we
8313 avoid the IndexOf test, and we avoid
8315 * codegen.cs: Add code to assist in a bug reporter to track down
8316 the source of a compiler crash.
8318 2002-12-07 Ravi Pratap <ravi@ximian.com>
8320 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8321 types have been emitted for a given element and flag an error
8322 if something which does not have AllowMultiple set is used more
8325 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8326 attribute types and their corresponding AllowMultiple properties
8328 (AreMultipleAllowed): Check the property for a given type.
8330 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8331 property in the case we have a TypeContainer.
8333 (Attributes.AddAttribute): Detect duplicates and just skip on
8334 adding them. This trivial fix catches a pretty gross error in our
8335 attribute emission - global attributes were being emitted twice!
8337 Bugzilla bug #33187 is now fixed.
8339 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8341 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8344 * expression.cs (Binary.ResolveOperator): I can only use the
8345 Concat (string, string, string) and Concat (string, string,
8346 string, string) if the child is actually a concatenation of
8349 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8351 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8352 context where we need a 2-character lookahead.
8354 * pending.cs (PendingImplementation): Rework so we can keep track
8355 of interface types all the time, and flag those which were
8356 implemented by parents as optional.
8358 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8360 * expression.cs (Binary.ResolveOperator): Use
8361 String.Concat(string,string,string) or
8362 String.Concat(string,string,string,string) when possible.
8364 * typemanager: More helper methods.
8367 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8369 * pending.cs: remove the bogus return from GetMissingInterfaces()
8370 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8372 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8374 * namespace.cs: avoid duplicated 'using xxx' being added to
8375 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8376 when we get more than one 'using' statement for the same namespace.
8377 Report a CS0105 warning for it.
8379 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8381 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8382 of calling getChar/putback, uses internal knowledge of it.
8384 (xtoken): Reorder tokenizer so most common patterns are checked
8385 first. This reduces the compilation time in another 5% (from 8.11s
8386 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8388 The parsing time is 22% of the compilation in mcs, and from that
8389 64% is spent on the tokenization process.
8391 I tried using a binary search for keywords, but this is slower
8392 than the hashtable. Another option would be to do a couple of
8395 * Not use a StringBuilder, instead use an array of chars,
8396 with a set value. Notice that this way we could catch
8397 the 645 error without having to do it *afterwards*.
8399 * We could write a hand-parser to avoid the hashtable
8400 compares altogether.
8402 The identifier consumption process takes 37% of the tokenization
8403 time. Another 15% is spent on is_number. 56% of the time spent
8404 on is_number is spent on Int64.Parse:
8406 * We could probably choose based on the string length to
8407 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8410 Another 3% is spend on wrapping `xtoken' in the `token' function.
8412 Handle 0xa0 as whitespace (#34752)
8414 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8416 * typemanager.cs (IsCLRType): New routine to tell whether a type
8417 is one of the builtin types.
8419 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8420 typecode in more places instead of doing pointer comparissions.
8421 We could leverage some knowledge about the way the typecodes are
8424 New code to cache namespaces in assemblies, it is currently not
8425 invoked, to be used soon.
8427 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8429 * expression.cs (Binary.ResolveOperator): specially handle
8430 strings, and do not perform user-defined operator overloading for
8433 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8435 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8436 internalcall as it is a pretty simple operation; Avoid whenever
8437 possible to call Char.IsLetter.
8439 (consume_identifier): Cut by half the number of
8440 hashtable calls by merging the is_keyword and GetKeyword behavior.
8442 Do not short-circuit, because if we do, we
8443 report errors (ie, #if false && true would produce an invalid
8447 2002-11-24 Martin Baulig <martin@ximian.com>
8449 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8450 check constant ranges and report a CS0221. Fixes #33186.
8452 2002-11-24 Martin Baulig <martin@ximian.com>
8454 * cs-parser.jay: Make this work for uninitialized variable
8455 declarations in the `for' initializer. Fixes #32416.
8457 2002-11-24 Martin Baulig <martin@ximian.com>
8459 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8460 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8462 2002-11-24 Martin Baulig <martin@ximian.com>
8464 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8465 argument; if true, we also check for user-defined conversions.
8466 This is only needed if both arguments are of a user-defined type.
8467 Fixes #30443, added test-175.cs.
8468 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8470 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8472 2002-11-24 Martin Baulig <martin@ximian.com>
8474 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8475 function to get the store opcode.
8476 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8477 only emit the Ldelema if the store opcode is Stobj. You must run
8478 both test-34 and test-167 to test this. Fixes #34529.
8480 2002-11-23 Martin Baulig <martin@ximian.com>
8482 * ecore.cs (Expression.MemberLookup): Added additional
8483 `qualifier_type' argument which is used when we're being called
8484 from MemberAccess.DoResolve() and null if we're called from a
8486 (Expression.MemberLookupFailed): New method to report errors; this
8487 does the CS1540 check and reports the correct error message.
8489 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8490 argument for the CS1540 check and redone the way how we're dealing
8491 with private members. See the comment in the source code for details.
8492 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8493 `closure_start_type' to `closure_qualifier_type' and check whether
8494 it's not null. It was not this filter being broken, it was just
8495 being called with the wrong arguments.
8497 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8498 and pass it the correct `qualifier_type'; this also does the error
8501 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8503 * expression.cs (Invocation.EmitParams): If the we are dealing
8504 with a non-built-in value type, load its address as well.
8506 (ArrayCreation): Use a a pretty constant instead
8507 of the hardcoded value 2. Use 6 instead of 2 for the number of
8508 static initializers.
8510 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8511 because they are not really value types, just glorified integers.
8513 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8515 * ecore.cs: Remove redundant code for enumerations, make them use
8516 the same code path as everything else, fixes the casting issue
8517 with enumerations in Windows.Forms.
8519 * attribute.cs: Do only cast to string if it is a string, the
8520 validation happens later.
8522 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8523 people upgrade their corlibs.
8525 * ecore.cs: Oops, enumerations were not following the entire code path
8527 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8529 * typemanager.cs (FilterWithClosure): Commented out the test for
8530 1540 in typemanager.cs, as it has problems when accessing
8531 protected methods from a parent class (see test-174.cs).
8533 * attribute.cs (Attribute.ValidateGuid): new method.
8534 (Attribute.Resolve): Use above.
8536 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8538 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8540 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8541 handling for enumerations, as we only needed the TypeContainer
8542 functionality to begin with (this is required for the fix below to
8543 work for enums that reference constants in a container class for
8546 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8548 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8549 a valid TypeBuilder to perform lookups on.o
8551 * class.cs (InheritableMemberSignatureCompare): Use true in the
8552 call to GetGetMethod and GetSetMethod, because we are comparing
8553 the signature, and we need to get the methods *even* if they are
8556 (PropertyBase.CheckBase): ditto.
8558 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8559 GotoCase.Resolve): Use Peel on EmpytCasts.
8561 * ecore.cs (EmptyCast): drop child, add Peel method.
8563 2002-11-17 Martin Baulig <martin@ximian.com>
8565 * ecore.cs (EmptyCast.Child): New public property.
8567 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8568 label resolved to an EmptyCast. Fixes #34162.
8569 (GotoCase.Resolve): Likewise.
8570 (Block.EmitMeta): Likewise.
8572 2002-11-17 Martin Baulig <martin@ximian.com>
8574 * expression.cs (Invocation.BetterConversion): Prefer int over
8575 uint; short over ushort; long over ulong for integer literals.
8576 Use ImplicitConversionExists instead of StandardConversionExists
8577 since we also need to check for user-defined implicit conversions.
8578 Fixes #34165. Added test-173.cs.
8580 2002-11-16 Martin Baulig <martin@ximian.com>
8582 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8583 with the `true' and `false' literals. Fixes #33151.
8585 2002-11-16 Martin Baulig <martin@ximian.com>
8587 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8588 October 22nd; don't do the cs1540 check for static members.
8590 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8591 now using our own filter here and doing the cs1540 check again.
8593 2002-11-16 Martin Baulig <martin@ximian.com>
8595 * support.cs (InternalParameters): Don't crash if we don't have
8596 any fixed parameters. Fixes #33532.
8598 2002-11-16 Martin Baulig <martin@ximian.com>
8600 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8601 when looking up static methods to make this work on Windows.
8604 2002-11-16 Martin Baulig <martin@ximian.com>
8606 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8607 a setter rather than using PropertyInfo.CanWrite.
8609 2002-11-15 Nick Drochak <ndrochak@gol.com>
8611 * class.cs: Allow acces to block member by subclasses. Fixes build
8614 2002-11-14 Martin Baulig <martin@ximian.com>
8616 * class.cs (Constructor.Emit): Added the extern/block check.
8619 2002-11-14 Martin Baulig <martin@ximian.com>
8621 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8622 iteration while looking for indexers, this is needed because the
8623 indexer may have a different name in our base classes. Fixed the
8624 error reporting (no indexers at all, not get accessor, no
8625 overloaded match). Fixes bug #33089.
8626 (IndexerAccess.DoResolveLValue): Likewise.
8628 2002-11-14 Martin Baulig <martin@ximian.com>
8630 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8631 indexers. Fixes the first part of bug #33089.
8632 (MethodSignature.InheritableMemberSignatureCompare): Added support
8635 2002-11-13 Ravi Pratap <ravi@ximian.com>
8637 * attribute.cs (Attribute.Resolve): Catch the
8638 NullReferenceException and report it since it isn't supposed to
8641 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8643 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8644 LogicalOr and LogicalAnd that can benefit from recursively
8645 handling EmitBranchable. The code now should be nice for Paolo.
8647 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8649 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8650 the Type lookups, as we perform quite a number of lookups on
8651 non-Types. This can be removed once we can deterministically tell
8652 whether we have a type or a namespace in advance.
8654 But this might require special hacks from our corlib.
8658 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8659 and double which avoids a conversion from an integer to a double.
8661 * expression.cs: tiny optimization, avoid calling IsConstant,
8662 because it effectively performs the lookup twice.
8664 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8666 But a bogus return here to keep the semantics of the old code
8667 until the Mono runtime is fixed.
8669 * pending.cs (GetMissingInterfaces): New method used to remove all
8670 the interfaces that are already implemented by our parent
8671 classes from the list of pending methods.
8673 * interface.cs: Add checks for calls after ResolveTypeExpr.
8675 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8677 * class.cs (Class.Emit): Report warning 67: event not used if the
8678 warning level is beyond 3.
8680 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8681 being a NullLiteral.
8683 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8686 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8687 path that might fail if a type can not be resolved.
8689 * expression.cs (Binary.Emit): Emit unsigned versions of the
8692 * driver.cs: use error 5.
8694 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8696 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8698 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8700 * cs-parser.jay (switch_section): A beautiful patch from Martin
8701 Baulig that fixed 33094.
8703 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8705 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8706 Check whether the base is abstract and report an error if so.
8708 * expression.cs (IndexerAccess.DoResolveLValue,
8709 IndexerAccess.DoResolve): ditto.
8711 (Invocation.DoResolve): ditto.
8713 (Invocation.FullMethodDesc): Improve the report string.
8715 * statement.cs (Block): Eliminate IsVariableDefined as it is
8716 basically just a wrapper for GetVariableInfo.
8718 * ecore.cs (SimpleName): Use new
8720 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8721 type, as we return the actual parameter ref/unref state on a
8724 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8726 * support.cs: Return proper flags REF/OUT fixing the previous
8729 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8730 not used to mean `ref' but `ref or out' in ParameterReference
8732 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8733 full type signature instead of calling TypeManger.CSharpName
8736 * support.cs (InternalParameters.ParameterDesc): Do not compare
8737 directly to the modflags, because REF/OUT will actually be bitsets
8740 * delegate.cs (VerifyMethod): Check also the modifiers.
8742 * cs-tokenizer.cs: Fix bug where floating point values with an
8743 exponent where a sign was missing was ignored.
8745 * driver.cs: Allow multiple assemblies to be specified in a single
8748 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8750 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8751 because identifiers after a parenthesis would end up in this kind
8752 of production, and we needed to desamiguate it for having casts
8755 (UserDefinedType *) xxx
8757 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8759 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8760 we should set on the Bindingflags.NonPublic, but not turn on
8761 private_ok. private_ok controls whether a Private member is
8762 returned (this is chekced on the filter routine), while the
8763 BindingFlags.NonPublic just controls whether private/protected
8764 will be allowed. This fixes the problem part of the problem of
8765 private properties being allowed to be used in derived classes.
8767 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8768 so we can call the children DoResolveLValue method (this will
8769 properly signal errors on lvalue assignments to base properties)
8771 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8772 getter are null, and we have a property info, we know that this
8773 happened because the lookup failed, so we report an error 122 for
8774 protection level violation.
8776 We also silently return if setter and getter are null in the
8777 resolve functions, this condition only happens if we have flagged
8778 the error before. This is the other half of the problem.
8780 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8781 not have accessibility information, that is why we were returning
8782 true in the filter function in typemanager.cs.
8784 To properly report 122 (property is inaccessible because of its
8785 protection level) correctly, we report this error in ResolveAccess
8786 by failing if both the setter and the getter are lacking (ie, the
8789 DoResolve and DoLResolve have been modified to check for both
8790 setter/getter being null and returning silently, the reason being
8791 that I did not want to put the knowledge about this error in upper
8794 int old = Report.Errors;
8795 x = new PropertyExpr (...);
8796 if (old != Report.Errors)
8801 So the property expr is returned, but it is invalid, so the error
8802 will be flagged during the resolve process.
8804 * class.cs: Remove InheritablePropertySignatureCompare from the
8805 class, as we no longer depend on the property signature to compute
8806 whether it is possible to implement a method or not.
8808 The reason is that calling PropertyInfo.GetGetMethod will return
8809 null (in .NET, in Mono it works, and we should change this), in
8810 cases where the Get Method does not exist in that particular
8815 class X { public virtual int A { get { return 1; } } }
8817 class Z : Y { public override int A { get { return 2; } } }
8819 Would fail in Z because the parent (Y) would not have the property
8820 defined. So we avoid this completely now (because the alternative
8821 fix was ugly and slow), and we now depend exclusively on the
8824 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8825 reference method, instead of using the property.
8827 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8828 routines are gone now.
8830 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8831 names, they were incorrectly named.
8833 * cs-tokenizer.cs: Return are more gentle token on failure.
8835 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8836 had an out-of-sync index variable, which caused it to remove from
8837 the list of pending methods the wrong method sometimes.
8839 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8841 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8842 CanWrite, because those refer to this particular instance of the
8843 property, and do not take into account the fact that we can
8844 override single members of a property.
8846 Constructor requires an EmitContext. The resolution process does
8847 not happen here, but we need to compute the accessors before,
8848 because the resolution does not always happen for properties.
8850 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8851 subclass, before we did not update this flag, but we did update
8854 (GetAccessors): Drop this routine, as it did not work in the
8855 presence of partially overwritten set/get methods.
8857 Notice that this broke the cs1540 detection, but that will require
8860 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8864 * driver.cs: issue a warning instead of an error if we don't support
8865 debugging for the platform. Also ignore a couple of errors that may
8866 arise when trying to write the symbols. Undo my previous patch.
8868 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8870 * driver.cs: ignore /debug switch except for Unix platforms.
8872 2002-10-23 Nick Drochak <ndrochak@gol.com>
8874 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8876 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8878 * driver.cs: Do not make mcs-debug conditional, so we do not break
8881 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8882 review this patch. But basically after all the children variables
8883 have been merged, the value of "Breaks" was not being set to
8884 new_breaks for Switch blocks. I think that it should be set after
8885 it has executed. Currently I set this to the value of new_breaks,
8886 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8887 conservative, but I do not understand this code very well.
8889 I did not break anything in the build, so that is good ;-)
8891 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8893 2002-10-20 Mark Crichton <crichton@gimp.org>
8895 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8897 2002-10-20 Nick Drochak <ndrochak@gol.com>
8899 * cfold.cs: Fixed compile blocker.
8901 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8903 * driver.cs: I was chekcing the key, not the file.
8905 2002-10-19 Ravi Pratap <ravi@ximian.com>
8907 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8908 message that we were generating - we just need to silently return
8911 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8913 * class.cs (Event.Define): Change my previous commit, as this
8914 breaks the debugger. This is a temporary hack, as it seems like
8915 the compiler is generating events incorrectly to begin with.
8917 * expression.cs (Binary.ResolveOperator): Added support for
8918 "U operator - (E x, E y)"
8920 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8923 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8924 init-only variables, but this path did not take into account that
8925 there might be also instance readonly variables. Correct this
8928 This fixes bug 32253
8930 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8933 * driver.cs: Change the extension for modules to `netmodule'
8935 * cs-parser.jay: Improved slightly the location tracking for
8936 the debugger symbols.
8938 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8939 modifiers that were specified instead of the hardcoded value
8940 (FamAndAssem). This was basically ignoring the static modifier,
8941 and others. Fixes 32429.
8943 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8944 fixed a bug in the process (32476)
8946 * expression.cs (ArrayAccess.EmitAssign): Patch from
8947 hwang_rob@yahoo.ca that fixes bug 31834.3
8949 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8951 * driver.cs: Make the module extension .netmodule.
8953 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8955 * driver.cs: Report an error if the resource file is not found
8956 instead of crashing.
8958 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8959 false, like Emit does.
8961 2002-10-16 Nick Drochak <ndrochak@gol.com>
8963 * typemanager.cs: Remove unused private member. Also reported mcs
8964 bug to report this as a warning like csc.
8966 2002-10-15 Martin Baulig <martin@gnome.org>
8968 * statement.cs (Statement.Emit): Made this a virtual method; emits
8969 the line number info and calls DoEmit().
8970 (Statement.DoEmit): New protected abstract method, formerly knows
8971 as Statement.Emit().
8973 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8975 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8977 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8978 have fixed a remaining problem: not every AddXXXX was adding a
8979 fully qualified name.
8981 Now everyone registers a fully qualified name in the DeclSpace as
8982 being defined instead of the partial name.
8984 Downsides: we are slower than we need to be due to the excess
8985 copies and the names being registered this way.
8987 The reason for this is that we currently depend (on the corlib
8988 bootstrap for instance) that types are fully qualified, because
8989 we dump all the types in the namespace, and we should really have
8990 types inserted into the proper namespace, so we can only store the
8991 basenames in the defined_names array.
8993 2002-10-10 Martin Baulig <martin@gnome.org>
8995 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8996 from bug #31834, see the bug report for a testcase which is
8999 2002-10-10 Martin Baulig <martin@gnome.org>
9001 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
9002 flow analysis code for this.
9004 * statement.cs (Do, While, For): Tell the flow analysis code about
9006 (FlowBranching.UsageVector): Added support for infinite loops.
9007 (Block.Resolve): Moved the dead code elimination here and use flow
9010 2002-10-09 Miguel de Icaza <miguel@ximian.com>
9012 * class.cs (Field.Define): Catch cycles on struct type
9015 * typemanager.cs (IsUnmanagedtype): Do not recursively check
9016 fields if the fields are static. We only need to check instance
9019 * expression.cs (As.DoResolve): Test for reference type.
9021 * statement.cs (Using.ResolveExpression): Use
9022 ConvertImplicitRequired, not ConvertImplicit which reports an
9024 (Using.ResolveLocalVariableDecls): ditto.
9026 * expression.cs (Binary.ResolveOperator): Report errors in a few
9027 places where we had to.
9029 * typemanager.cs (IsUnmanagedtype): Finish implementation.
9031 2002-10-08 Miguel de Icaza <miguel@ximian.com>
9033 * expression.cs: Use StoreFromPtr instead of extracting the type
9034 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
9036 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
9037 an enumeration value to a System.Enum, but System.Enum is not a
9038 value type, but an class type, so we need to box.
9040 (Expression.ConvertExplicit): One codepath could return
9041 errors but not flag them. Fix this. Fixes #31853
9043 * parameter.cs (Resolve): Do not allow void as a parameter type.
9045 2002-10-06 Martin Baulig <martin@gnome.org>
9047 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
9048 if it's a class type and not a struct. Fixes #31815.
9050 2002-10-06 Martin Baulig <martin@gnome.org>
9052 * statement.cs: Reworked the flow analysis code a bit to make it
9053 usable for dead code elimination.
9055 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9057 * cs-parser.jay: allow empty source files. Fixes bug #31781.
9059 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9061 * expression.cs (ComposedCast.DoResolveType): A quick workaround
9062 to fix the test 165, will investigate deeper.
9064 2002-10-04 Martin Baulig <martin@gnome.org>
9066 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
9067 finally blocks actually work.
9068 (Try.Resolve): We don't need to create a sibling for `finally' if
9069 there is no finally block.
9071 2002-10-04 Martin Baulig <martin@gnome.org>
9073 * class.cs (Constructor.Define): The default accessibility for a
9074 non-default constructor is private, not public.
9076 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9078 * class.cs (Constructor): Make AllowedModifiers public, add
9081 * cs-parser.jay: Perform the modifiers test here, as the
9082 constructor for the Constructor class usually receives a zero
9083 because of the way we create it (first we create, later we
9084 customize, and we were never checking the modifiers).
9086 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
9087 is a version of LookupTypeReflection that includes the type-name
9088 cache. This can be used as a fast path for functions that know
9089 the fully qualified name and are only calling into *.GetType() to
9090 obtain a composed type.
9092 This is also used by TypeManager.LookupType during its type
9095 (LookupType): We now also track the real type name, as sometimes
9096 we can get a quey for the real type name from things like
9097 ComposedCast. This fixes bug 31422.
9099 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
9100 complete type fullname, it does not have to go through the type
9101 resolution system to obtain the composed version of the type (for
9102 obtaining arrays or pointers).
9104 (Conditional.Emit): Use the EmitBoolExpression to
9105 generate nicer code, as requested by Paolo.
9107 (ArrayCreation.CheckIndices): Use the patch from
9108 hwang_rob@yahoo.ca to validate the array initializers.
9110 2002-10-03 Miguel de Icaza <miguel@ximian.com>
9112 * class.cs (ConstructorInitializer.Emit): simplify code by using
9113 Invocation.EmitCall, and at the same time, fix the bugs in calling
9114 parent constructors that took variable arguments.
9116 * ecore.cs (Expression.ConvertNumericExplicit,
9117 Expression.ImplicitNumericConversion): Remove the code that
9118 manually wrapped decimal (InternalTypeConstructor call is now gone
9121 * expression.cs (Cast.TryReduce): Also handle decimal types when
9122 trying to perform a constant fold on the type.
9124 * typemanager.cs (IsUnmanagedtype): Partially implemented.
9126 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
9127 that only turned off an error report, and did nothing else.
9129 2002-10-02 Miguel de Icaza <miguel@ximian.com>
9131 * driver.cs: Handle and ignore /fullpaths
9133 2002-10-01 Miguel de Icaza <miguel@ximian.com>
9135 * expression.cs (Binary.ResolveOperator): Catch the case where
9136 DoNumericPromotions returns true,
9138 (Binary.DoNumericPromotions): Simplify the code, and the tests.
9140 2002-09-27 Miguel de Icaza <miguel@ximian.com>
9142 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
9145 2002-09-26 Miguel de Icaza <miguel@ximian.com>
9147 * ecore.cs (ConvertNumericExplicit): It is not enough that the
9148 conversion exists, but it is also required that the conversion be
9149 performed. This manifested in "(Type64Enum) 2".
9151 * class.cs (TypeManager.AddMethod): The fix is not to change
9152 AddEnum, because that one was using a fully qualified name (every
9153 DeclSpace derivative does), but to change the AddMethod routine
9154 that was using an un-namespaced name. This now correctly reports
9155 the duplicated name.
9157 Revert patch until I can properly fix it. The issue
9158 is that we have a shared Type space across all namespaces
9159 currently, which is wrong.
9161 Options include making the Namespace a DeclSpace, and merge
9162 current_namespace/current_container in the parser.
9164 2002-09-25 Miguel de Icaza <miguel@ximian.com>
9166 * cs-parser.jay: Improve error reporting when we get a different
9167 kind of expression in local_variable_type and
9168 local_variable_pointer_type.
9170 Propagate this to avoid missleading errors being reported.
9172 * ecore.cs (ImplicitReferenceConversion): treat
9173 TypeManager.value_type as a target just like object_type. As
9178 Is valid, and needs to result in the int 1 being boxed before it
9179 is assigned to the value type v.
9181 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
9182 to validate the enumeration name.
9184 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
9185 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
9186 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
9188 * ecore.cs (TryImplicitIntConversion): When doing an
9189 implicit-enumeration-conversion, check if the type is 64-bits and
9190 perform a conversion before passing to EnumConstant.
9192 2002-09-23 Miguel de Icaza <miguel@ximian.com>
9194 * decl.cs (Error_AmbiguousTypeReference); New routine used to
9195 report ambiguous type references. Unlike the MS version, we
9196 report what the ambiguity is. Innovation at work ;-)
9198 (DeclSpace.FindType): Require a location argument to
9199 display when we display an ambiguous error.
9201 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
9203 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
9205 * expression.cs (EmitDynamicInitializers): Apply patch from
9206 hwang_rob@yahoo.ca that fixes the order in which we emit our
9209 2002-09-21 Martin Baulig <martin@gnome.org>
9211 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
9212 delegate takes no arguments.
9214 2002-09-20 Miguel de Icaza <miguel@ximian.com>
9216 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
9219 * expression.cs: Extract the underlying type.
9221 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
9223 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
9225 2002-09-19 Miguel de Icaza <miguel@ximian.com>
9227 * class.cs (TypeContainer.DefineType): We can not use the nice
9228 PackingSize with the size set to 1 DefineType method, because it
9229 will not allow us to define the interfaces that the struct
9232 This completes the fixing of bug 27287
9234 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
9235 means also structs. This fixes part of the problem.
9236 (Expresion.ImplicitReferenceConversionExists): ditto.
9238 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
9239 error if there were no errors reported during the type lookup
9240 process, to avoid duplicates or redundant errors. Without this
9241 you would get an ambiguous errors plus a type not found. We have
9242 beaten the user enough with the first error.
9244 (DeclSparce.FindType): Emit a warning if we have an ambiguous
9247 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
9248 during the resolution process, stop the lookup, this avoids
9249 repeated error reports (same error twice).
9251 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
9253 * typemanager.cs (LookupType): Redo the type lookup code to match
9254 the needs of System.Reflection.
9256 The issue is that System.Reflection requires references to nested
9257 types to begin with a "+" sign instead of a dot. So toplevel
9258 types look like: "NameSpace.TopLevelClass", and nested ones look
9259 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9262 2002-09-19 Martin Baulig <martin@gnome.org>
9264 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9265 says that a method always returns or always throws an exception,
9266 don't report the CS0161.
9268 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9269 set `Returns = new_returns'.
9271 2002-09-19 Martin Baulig <martin@gnome.org>
9273 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9274 to an enum constant, check for a CS0176.
9276 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9278 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9279 for operators that must be in pairs and report errors.
9281 * ecore.cs (SimpleName.DoResolveType): During the initial type
9282 resolution process, when we define types recursively, we must
9283 check first for types in our current scope before we perform
9284 lookups in the enclosing scopes.
9286 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9288 (Invocation.VerifyArgumentsCompat): Call
9289 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9290 I thought we were supposed to always call this, but there are a
9291 few places in the code where we dont do it.
9293 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9295 * driver.cs: Add support in -linkres and -resource to specify the
9296 name of the identifier.
9298 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9300 * ecore.cs (StandardConversionExists): Sync with the conversion
9301 code: allow anything-* to void* conversions.
9303 (FindMostSpecificSource): Use an Expression argument
9304 instead of a Type, because we might be handed over a Literal which
9305 gets a few more implicit conversions that plain types do not. So
9306 this information was being lost.
9308 Also, we drop the temporary type-holder expression when not
9311 2002-09-17 Martin Baulig <martin@gnome.org>
9313 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9314 this is an explicit interface implementation.
9316 2002-09-17 Martin Baulig <martin@gnome.org>
9318 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9319 different `IndexerName' attributes.
9321 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9322 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9323 virtual CommonResolve().
9325 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9327 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9328 and convert that to the UnderlyingType.
9330 * statement.cs (Foreach.Resolve): Indexers are just like variables
9331 or PropertyAccesses.
9333 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9334 inside quoted strings, we were not doing this before.
9336 2002-09-16 Martin Baulig <martin@gnome.org>
9338 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9339 resolve it. This is needed for the definite assignment check of the
9340 instance expression, fixes bug #29846.
9341 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9343 2002-09-16 Nick Drochak <ndrochak@gol.com>
9345 * parameter.cs: Fix compile error. Cannot reference static member
9346 from an instance object. Is this an mcs bug?
9348 2002-09-14 Martin Baulig <martin@gnome.org>
9350 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9351 multiple times. Fixes bug #30295, added test-166.cs.
9353 2002-09-14 Martin Baulig <martin@gnome.org>
9355 * statement.cs (Block.Emit): Don't emit unreachable code.
9356 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9358 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9360 2002-09-14 Martin Baulig <martin@gnome.org>
9362 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9365 2002-09-14 Martin Baulig <martin@gnome.org>
9367 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9368 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9369 be false on the ms runtime.
9371 2002-09-13 Martin Baulig <martin@gnome.org>
9373 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9374 the CS0038 error message.
9376 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9378 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9379 constant inside, return it.
9381 2002-09-12 Martin Baulig <martin@gnome.org>
9383 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9384 implicit conversion can be done between enum types.
9386 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9387 check whether an implicit conversion to the current enum's UnderlyingType
9388 exists and report an error if not.
9390 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9391 without debugging support.
9393 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9394 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9396 2002-09-12 Martin Baulig <martin@gnome.org>
9398 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9400 * ecore.cs (IMemberExpr.DeclaringType): New property.
9401 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9402 nonstatic member of an outer type (CS0038).
9404 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9406 * driver.cs: Activate the using-error detector at warning level
9407 4 (at least for MS-compatible APIs).
9409 * namespace.cs (VerifyUsing): Small buglett fix.
9411 * pending.cs (PendingImplementation): pass the container pointer.
9413 * interface.cs (GetMethods): Allow for recursive definition. Long
9414 term, I would like to move every type to support recursive
9415 definitions, not the current ordering mechanism that we have right
9418 The situation is this: Attributes are handled before interfaces,
9419 so we can apply attributes to interfaces. But some attributes
9420 implement interfaces, we will now handle the simple cases
9421 (recursive definitions will just get an error).
9423 * parameter.cs: Only invalidate types at the end if we fail to
9426 2002-09-09 Martin Baulig <martin@gnome.org>
9428 * ecore.cs (PropertyExpr.Emit): Also check for
9429 TypeManager.system_int_array_get_length so this'll also work when
9430 compiling corlib. Fixes #30003.
9432 2002-09-09 Martin Baulig <martin@gnome.org>
9434 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9435 and throw an exception if we can't get the type's size. Fixed #30040,
9438 2002-09-09 Martin Baulig <martin@gnome.org>
9440 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9442 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9443 context. Fixes bug #30027.
9445 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9446 virtual functions. Fixes bug #30043, added test-164.cs.
9448 2002-09-08 Ravi Pratap <ravi@ximian.com>
9450 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9452 2002-09-08 Nick Drochak <ndrochak@gol.com>
9454 * driver.cs: Use an object to get the windows codepage since it's not a
9457 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9459 * statement.cs (For.Emit): for infinite loops (test == null)
9460 return whether there is a break inside, not always "true".
9462 * namespace.cs (UsingEntry): New struct to hold the name of the
9463 using definition, the location where it is defined, and whether it
9464 has been used in a successful type lookup.
9466 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9471 2002-09-06 Ravi Pratap <ravi@ximian.com>
9473 * attribute.cs : Fix incorrect code which relied on catching
9474 a NullReferenceException to detect a null being passed in
9475 where an object was expected.
9477 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9479 * statement.cs (Try): flag the catch variable as assigned
9481 * expression.cs (Cast): Simplified by using ResolveType instead of
9484 * statement.cs (Catch): Fix bug by using ResolveType.
9486 2002-09-06 Ravi Pratap <ravi@ximian.com>
9488 * expression.cs (BetterConversion): Special case for when we have
9489 a NullLiteral as the argument and we have to choose between string
9490 and object types - we choose string the way csc does.
9492 * attribute.cs (Attribute.Resolve): Catch the
9493 NullReferenceException and report error #182 since the Mono
9494 runtime no more has the bug and having this exception raised means
9495 we tried to select a constructor which takes an object and is
9498 2002-09-05 Ravi Pratap <ravi@ximian.com>
9500 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9501 message (1502, 1503) when we can't locate a method after overload
9502 resolution. This is much more informative and closes the bug
9505 * interface.cs (PopulateMethod): Return if there are no argument
9506 types. Fixes a NullReferenceException bug.
9508 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9509 expressions too. Previously we were checking only in one place for
9510 positional arguments leaving out named arguments.
9512 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9513 type to the enum type is not allowed. Remove code corresponding to
9516 (ConvertNumericExplicit): Allow explicit conversions from
9517 the underlying type to enum type. This precisely follows the spec
9518 and closes a bug filed by Gonzalo.
9520 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9523 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9525 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9527 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9528 it was important that we stored the right value after the
9529 reduction in `converted'.
9531 2002-09-04 Martin Baulig <martin@gnome.org>
9533 * location.cs (Location.SymbolDocument): Use full pathnames for the
9536 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9538 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9539 of the expression resolve mechanism, because that will catch the
9540 SimpleName error failures.
9542 (Conditional): If we can not resolve the
9543 expression, return, do not crash.
9545 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9548 (location): display token name instead of its number.
9550 2002-08-28 Martin Baulig <martin@gnome.org>
9552 * expression.cs (Binary.ResolveOperator): Don't silently return
9553 but return an error if an operator cannot be applied between two
9556 2002-08-28 Martin Baulig <martin@gnome.org>
9558 * class.cs (Constructor.Define): Set the permission attributes
9559 correctly instead of making all constructors public.
9561 2002-08-28 Martin Baulig <martin@gnome.org>
9563 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9564 for private members before reporting a CS0103; if we find anything,
9567 2002-08-28 Martin Baulig <martin@gnome.org>
9569 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9570 to check whether `closure_start_type == closure_invocation_type',
9571 we also need to check whether `m.DeclaringType == closure_invocation_type'
9572 before bypassing the permission checks. We might be accessing
9573 protected/private members from the base class.
9574 (TypeManager.RealMemberLookup): Only set private_ok if private
9575 members were requested via BindingFlags.NonPublic.
9577 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9579 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9580 MethodGroupExpr.IsExplicitImpl if appropriate.
9581 (Invocation.DoResolve): Don't report the CS0120 for explicit
9582 interface implementations.
9584 2002-08-27 Martin Baulig <martin@gnome.org>
9586 * expression.cs (Invocation.DoResolve): If this is a static
9587 method and we don't have an InstanceExpression, we must report
9590 2002-08-25 Martin Baulig <martin@gnome.org>
9592 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9593 `==' between a valuetype and an object.
9595 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9597 * ecore.cs (TypeExpr): Provide a ToString method.
9599 2002-08-24 Martin Baulig <martin@gnome.org>
9601 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9602 now called proggie.dbg and it's a binary file.
9604 2002-08-23 Martin Baulig <martin@gnome.org>
9606 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9608 2002-08-23 Martin Baulig <martin@gnome.org>
9610 * struct.cs (MyStructInfo.ctor): Make this work with empty
9611 structs; it's not allowed to use foreach() on null.
9613 2002-08-23 Martin Baulig <martin@gnome.org>
9615 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9616 writer the full pathname of the generated assembly.
9618 2002-08-23 Martin Baulig <martin@gnome.org>
9620 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9621 A `finally' block never returns or breaks; improved handling of
9624 2002-08-23 Martin Baulig <martin@gnome.org>
9626 * statement.cs (Throw.Resolve): Allow `throw null'.
9628 2002-08-23 Martin Baulig <martin@gnome.org>
9630 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9631 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9632 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9633 MemberLookup would return a wrong event if this is an explicit
9634 interface implementation and the class has an event with the same
9637 2002-08-23 Martin Baulig <martin@gnome.org>
9639 * statement.cs (Block.AddChildVariableNames): New public method.
9640 (Block.AddChildVariableName): Likewise.
9641 (Block.IsVariableNameUsedInChildBlock): Likewise.
9642 (Block.AddVariable): Check whether a variable name has already
9643 been used in a child block.
9645 * cs-parser.jay (declare_local_variables): Mark all variable names
9646 from the current block as being used in a child block in the
9649 2002-08-23 Martin Baulig <martin@gnome.org>
9651 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9652 find the symbol writer.
9654 * driver.cs: csc also allows the arguments to /define being
9655 separated by commas, not only by semicolons.
9657 2002-08-23 Martin Baulig <martin@gnome.org>
9659 * interface.cs (Interface.GetMembers): Added static check for events.
9661 2002-08-15 Martin Baulig <martin@gnome.org>
9663 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9664 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9666 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9667 why the MethodData.EmitDestructor() change was necessary.
9669 2002-08-20 Martin Baulig <martin@gnome.org>
9671 * class.cs (TypeContainer.FindMembers): Added static check for events.
9673 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9675 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9676 use Type.GetEvents(), not Type.FindMembers().
9678 2002-08-20 Martin Baulig <martin@gnome.org>
9680 * decl.cs (MemberCache): Added a special method cache which will
9681 be used for method-only searched. This ensures that a method
9682 search will return a MethodInfo with the correct ReflectedType for
9685 2002-08-20 Martin Baulig <martin@gnome.org>
9687 * decl.cs (DeclSpace.FindMembers): Made this public.
9689 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9691 * delegate.cs: fixed build on windows.
9692 [FIXME: Filed as bug #29150: MCS must report these errors.]
9694 2002-08-19 Ravi Pratap <ravi@ximian.com>
9696 * ecore.cs (StandardConversionExists): Return a false
9697 if we are trying to convert the void type to anything else
9698 since that is not allowed.
9700 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9701 we flag error 70 in the event an event is trying to be accessed
9702 directly from outside the declaring type.
9704 2002-08-20 Martin Baulig <martin@gnome.org>
9706 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9707 MemberCache from typemanager.cs to decl.cs.
9709 2002-08-19 Martin Baulig <martin@gnome.org>
9711 * class.cs (TypeContainer): Implement IMemberContainer.
9712 (TypeContainer.DefineMembers): Create the MemberCache.
9713 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9714 return public members if BindingFlags.Public was given, check
9715 whether members are static.
9717 2002-08-16 Martin Baulig <martin@gnome.org>
9719 * decl.cs (DeclSpace.Define): Splitted this in Define and
9720 DefineMembers. DefineMembers is called first and initializes the
9723 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9724 DefineMembers() on all our DeclSpaces.
9726 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9727 but call DefineMembers() on all nested interfaces. We call their
9728 Define() in our new Define() function.
9730 * interface.cs (Interface): Implement IMemberContainer.
9731 (Interface.Define): Moved all code except the attribute stuf to
9733 (Interface.DefineMembers): Initialize the member cache.
9735 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9736 need this anymore since we can use MemberCache.FindMembers directly.
9738 2002-08-19 Martin Baulig <martin@gnome.org>
9740 * typemanager.cs (MemberCache): When creating the cache for an
9741 interface type, add all inherited members.
9742 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9743 to `out bool used_cache' and documented it.
9744 (TypeManager.MemberLookup): If we already used the cache in the first
9745 iteration, we don't need to do the interfaces check.
9747 2002-08-19 Martin Baulig <martin@gnome.org>
9749 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9750 here from IMemberFinder and don't implement this interface anymore.
9751 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9753 * typemanager.cs (IMemberFinder): This interface is now only used by
9754 classes which actually support the member cache.
9755 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9756 since we only put DeclSpaces into this Hashtable.
9757 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9758 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9760 2002-08-16 Martin Baulig <martin@gnome.org>
9762 * typemanager.cs (ICachingMemberFinder): Removed.
9763 (IMemberFinder.MemberCache): New property.
9764 (TypeManager.FindMembers): Merged this with RealFindMembers().
9765 This function will never be called from TypeManager.MemberLookup()
9766 so we can't use the cache here, just the IMemberFinder.
9767 (TypeManager.MemberLookup_FindMembers): Check whether the
9768 IMemberFinder has a MemberCache and call the cache's FindMembers
9770 (MemberCache): Rewrote larger parts of this yet another time and
9771 cleaned it up a bit.
9773 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9775 * driver.cs (LoadArgs): Support quoting.
9777 (Usage): Show the CSC-like command line arguments.
9779 Improved a few error messages.
9781 2002-08-15 Martin Baulig <martin@gnome.org>
9783 * typemanager.cs (IMemberContainer.Type): New property.
9784 (IMemberContainer.IsInterface): New property.
9786 The following changes are conditional to BROKEN_RUNTIME, which is
9787 defined at the top of the file.
9789 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9790 class'es members, but add all members from TypeHandle.ObjectType
9791 if we're an interface.
9792 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9793 is the current type.
9794 (MemberCache.CacheEntry.Container): Removed this field.
9795 (TypeHandle.GetMembers): Include inherited members.
9797 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9799 * typemanager.cs: fixed compilation and added a comment on a field that
9802 2002-08-15 Martin Baulig <martin@gnome.org>
9804 * class.cs (ConstructorInitializer.Resolve): In the
9805 Expression.MemberLookup call, use the queried_type as
9808 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9809 declared' attribute, it's always true.
9810 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9811 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9812 temporary wrapper for FindMembers which tells MemberLookup whether
9813 members from the base classes are included in the return value.
9814 This will go away soon.
9815 (TypeManager.MemberLookup): Use this temporary hack here; once the
9816 new MemberCache is completed, we don't need to do the DeclaredOnly
9817 looping here anymore since the MemberCache will take care of this.
9818 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9819 (MemberCache): When creating the MemberCache for a class, get
9820 members from the current class and all its base classes.
9821 (MemberCache.CacheEntry.Container): New field. This is a
9822 temporary hack until the Mono runtime is fixed to distinguish
9823 between ReflectedType and DeclaringType. It allows us to use MCS
9824 with both the MS runtime and the unfixed Mono runtime without
9825 problems and without accecting performance.
9826 (MemberCache.SearchMembers): The DeclaredOnly looping from
9827 TypeManager.MemberLookup is now done here.
9829 2002-08-14 Martin Baulig <martin@gnome.org>
9831 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9832 Type.GetFields on dynamic types but get the fields from the
9833 corresponding TypeContainer.
9834 (MyStructInfo.GetStructInfo): Added check for enum types.
9836 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9837 (MemberList.SyncRoot): Implemented.
9838 (TypeManager.FilterWithClosure): No need to check permissions if
9839 closure_start_type == closure_invocation_type, don't crash if
9840 closure_invocation_type is null.
9842 2002-08-13 Martin Baulig <martin@gnome.org>
9844 Rewrote TypeContainer.FindMembers to use a member cache. This
9845 gives us a speed increase of about 35% for the self-hosting MCS
9846 build and of about 15-20% for the class libs (both on GNU/Linux).
9848 * report.cs (Timer): New class to get enhanced profiling. This
9849 whole class is "TIMER" conditional since it remarkably slows down
9852 * class.cs (MemberList): New class. This is an IList wrapper
9853 which we're now using instead of passing MemberInfo[]'s around to
9854 avoid copying this array unnecessarily.
9855 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9856 (ICachingMemberFinder, IMemberContainer): New interface.
9857 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9858 has already been checked, otherwise use it for the name comparision.
9859 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9860 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9861 if possible. Returns a MemberList, not a MemberInfo [].
9862 (TypeHandle): New class, implements IMemberContainer. We create
9863 one instance of this class per type, it contains a MemberCache
9864 which is used to do the member lookups.
9865 (MemberCache): New class. Each instance of this class contains
9866 all members of a type and a name-based hash table.
9867 (MemberCache.FindMembers): This is our new member lookup
9868 function. First, it looks up all members of the requested name in
9869 the hash table. Then, it walks this list and sorts out all
9870 applicable members and returns them.
9872 2002-08-13 Martin Baulig <martin@gnome.org>
9874 In addition to a nice code cleanup, this gives us a performance
9875 increase of about 1.4% on GNU/Linux - not much, but it's already
9876 half a second for the self-hosting MCS compilation.
9878 * typemanager.cs (IMemberFinder): New interface. It is used by
9879 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9880 Enum, Delegate or Interface.
9881 (TypeManager.finder_to_member_finder): New PtrHashtable.
9882 (TypeManager.finder_to_container): Removed.
9883 (TypeManager.finder_to_delegate): Removed.
9884 (TypeManager.finder_to_interface): Removed.
9885 (TypeManager.finder_to_enum): Removed.
9887 * interface.cs (Interface): Implement IMemberFinder.
9889 * delegate.cs (Delegate): Implement IMemberFinder.
9891 * enum.cs (Enum): Implement IMemberFinder.
9893 * class.cs (TypeContainer): Implement IMemberFinder.
9895 2002-08-12 Martin Baulig <martin@gnome.org>
9897 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9899 2002-08-12 Martin Baulig <martin@gnome.org>
9901 * ecore.cs (ITypeExpression): New interface for expressions which
9903 (TypeExpression): Renamed to TypeLookupExpression.
9904 (Expression.DoResolve): If we're doing a types-only lookup, the
9905 expression must implement the ITypeExpression interface and we
9906 call DoResolveType() on it.
9907 (SimpleName): Implement the new ITypeExpression interface.
9908 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9909 hack, the situation that we're only looking up types can't happen
9910 anymore when this method is called. Moved the type lookup code to
9911 DoResolveType() and call it.
9912 (SimpleName.DoResolveType): This ITypeExpression interface method
9913 is now doing the types-only lookup.
9914 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9915 (ResolveFlags): Added MaskExprClass.
9917 * expression.cs (MemberAccess): Implement the ITypeExpression
9919 (MemberAccess.DoResolve): Added support for a types-only lookup
9920 when we're called via ITypeExpression.DoResolveType().
9921 (ComposedCast): Implement the ITypeExpression interface.
9923 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9924 Expression.Resolve() with ResolveFlags.Type instead.
9926 2002-08-12 Martin Baulig <martin@gnome.org>
9928 * interface.cs (Interface.Define): Apply attributes.
9930 * attribute.cs (Attribute.ApplyAttributes): Added support for
9931 interface attributes.
9933 2002-08-11 Martin Baulig <martin@gnome.org>
9935 * statement.cs (Block.Emit): Only check the "this" variable if we
9936 do not always throw an exception.
9938 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9939 whether the property has a set accessor.
9941 2002-08-11 Martin Baulig <martin@gnome.org>
9943 Added control flow analysis support for structs.
9945 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9946 with control flow analysis turned off.
9947 (IVariable): New interface.
9948 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9949 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9950 (FieldExpr.DoResolve): Resolve the instance expression with flow
9951 analysis turned off and do the definite assignment check after the
9952 resolving when we know what the expression will resolve to.
9954 * expression.cs (LocalVariableReference, ParameterReference):
9955 Implement the new IVariable interface, only call the flow analysis
9956 code if ec.DoFlowAnalysis is true.
9957 (This): Added constructor which takes a Block argument. Implement
9958 the new IVariable interface.
9959 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9960 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9961 This does the definite assignment checks for struct members.
9963 * class.cs (Constructor.Emit): If this is a non-static `struct'
9964 constructor which doesn't have any initializer, call
9965 Block.AddThisVariable() to tell the flow analysis code that all
9966 struct elements must be initialized before control returns from
9969 * statement.cs (MyStructInfo): New public class.
9970 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9971 argument to this indexer. If non-zero, check an individual struct
9972 member, not the whole struct.
9973 (FlowBranching.CheckOutParameters): Check struct members.
9974 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9975 overloaded versions of these methods which take an additional
9976 `int field_idx' argument to check struct members.
9977 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9978 overloaded versions of these methods which take an additional
9979 `string field_name' argument to check struct member.s
9980 (VariableInfo): Implement the IVariable interface.
9981 (VariableInfo.StructInfo): New public property. Returns the
9982 MyStructInfo instance of the variable if it's a struct or null.
9983 (Block.AddThisVariable): New public method. This is called from
9984 Constructor.Emit() for non-static `struct' constructor which do
9985 not have any initializer. It creates a special variable for the
9986 "this" instance variable which will be checked by the flow
9987 analysis code to ensure that all of the struct's fields are
9988 initialized before control returns from the constructor.
9989 (UsageVector): Added support for struct members. If a
9990 variable/parameter is a struct with N members, we reserve a slot
9991 in the usage vector for each member. A struct is considered fully
9992 initialized if either the struct itself (slot 0) or all its
9993 members are initialized.
9995 2002-08-08 Martin Baulig <martin@gnome.org>
9997 * driver.cs (Driver.MainDriver): Only report an error CS5001
9998 if there were no compilation errors.
10000 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
10001 `UnsafeContext' property to determine whether the parent is in
10002 unsafe context rather than checking the parent's ModFlags:
10003 classes nested in an unsafe class are unsafe as well.
10005 2002-08-08 Martin Baulig <martin@gnome.org>
10007 * statement.cs (UsageVector.MergeChildren): Distinguish between
10008 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
10009 we return. Added test17() and test18() to test-154.cs.
10011 2002-08-08 Martin Baulig <martin@gnome.org>
10013 * typemanager.cs (TypeManager.FilterWithClosure): If we have
10014 Family access, make sure the invoking type isn't a subclass of the
10015 queried type (that'd be a CS1540).
10017 * ecore.cs (Expression.MemberLookup): Added overloaded version of
10018 this method which takes an additional `Type invocation_type'.
10020 * expression.cs (BaseAccess.DoResolve): Use the base type as
10021 invocation and query type.
10022 (MemberAccess.DoResolve): If the lookup failed and we're about to
10023 report a CS0122, try a lookup with the ec.ContainerType - if this
10024 succeeds, we must report a CS1540.
10026 2002-08-08 Martin Baulig <martin@gnome.org>
10028 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
10029 (MethodGroupExpr): Implement the IMemberExpr interface.
10031 * expression (MemberAccess.ResolveMemberAccess): No need to have
10032 any special code for MethodGroupExprs anymore, they're now
10035 2002-08-08 Martin Baulig <martin@gnome.org>
10037 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
10038 Family, FamANDAssem and FamORAssem permissions.
10039 (TypeManager.IsSubclassOrNestedChildOf): New public method.
10041 2002-08-08 Martin Baulig <martin@gnome.org>
10043 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
10044 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
10047 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
10049 * driver.cs: implemented /resource option to embed managed resources.
10051 2002-08-07 Martin Baulig <martin@gnome.org>
10053 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
10054 (FieldBase.HasFieldInitializer): New public property.
10055 (FieldBase.GetInitializerExpression): New public method. Resolves and
10056 returns the field initializer and makes sure it is only resolved once.
10057 (TypeContainer.EmitFieldInitializers): Call
10058 FieldBase.GetInitializerExpression to get the initializer, this ensures
10059 that it isn't resolved multiple times.
10061 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
10062 the resolving process (SimpleName/MemberLookup) that we're currently
10063 emitting a field initializer (which must not access any instance members,
10064 this is an error CS0236).
10066 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
10067 argument, if the `IsFieldInitializer' flag is set, we must report and
10068 error CS0236 and not an error CS0120.
10070 2002-08-07 Martin Baulig <martin@gnome.org>
10072 * ecore.cs (IMemberExpr): New public interface.
10073 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
10074 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
10075 if the expression is an IMemberExpr.
10077 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
10078 to be null, implicitly default to `this' if we're non-static in
10079 this case. Simplified the code a lot by using the new IMemberExpr
10080 interface. Also fixed bug #28176 here.
10082 2002-08-06 Martin Baulig <martin@gnome.org>
10084 * cs-parser.jay (SimpleLookup): Removed. We need to create
10085 ParameterReferences during semantic analysis so that we can do a
10086 type-only search when resolving Cast, TypeOf and SizeOf.
10087 (block): Pass the `current_local_parameters' to the Block's
10090 * class.cs (ConstructorInitializer): Added `Parameters parameters'
10091 argument to the constructor.
10092 (ConstructorInitializer.Resolve): Create a temporary implicit
10093 block with the parameters.
10095 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
10096 references here if we aren't doing a type-only search.
10098 * statement.cs (Block): Added constructor which takes a
10099 `Parameters parameters' argument.
10100 (Block.Parameters): New public property.
10102 * support.cs (InternalParameters.Parameters): Renamed `parameters'
10103 to `Parameters' and made it public readonly.
10105 2002-08-06 Martin Baulig <martin@gnome.org>
10107 * ecore.cs (Expression.Warning): Made this public as well.
10109 * report.cs (Report.Debug): Print the contents of collections.
10111 2002-08-06 Martin Baulig <martin@gnome.org>
10113 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
10114 used to tell Resolve() which kinds of expressions it may return.
10115 (Expression.Resolve): Added overloaded version of this method which
10116 takes a `ResolveFlags flags' argument. This can be used to tell
10117 Resolve() which kinds of expressions it may return. Reports a
10119 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
10120 ResolveFlags.SimpleName.
10121 (Expression.Error118): Added overloaded version of this method which
10122 takes a `ResolveFlags flags' argument. It uses the flags to determine
10123 which kinds of expressions are allowed.
10125 * expression.cs (Argument.ResolveMethodGroup): New public method.
10126 Resolves an argument, but allows a MethodGroup to be returned.
10127 This is used when invoking a delegate.
10129 * TODO: Updated a bit.
10131 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10133 Fixed compilation with csc.
10135 * ecore.cs: Expression.Error made public. Is this correct? Should
10136 Warning be made public too?
10138 * expression.cs: use ea.Location instead of ea.loc.
10139 [FIXME: Filed as bug #28607: MCS must report these errors.]
10141 2002-08-06 Martin Baulig <martin@gnome.org>
10143 * ecore.cs (Expression.loc): Moved the location here instead of
10144 duplicating it in all derived classes.
10145 (Expression.Location): New public property.
10146 (Expression.Error, Expression.Warning): Made them non-static and
10147 removed the location argument.
10148 (Expression.Warning): Added overloaded version which takes an
10149 `int level' argument.
10150 (Expression.Error118): Make this non-static and removed the
10151 expression and location arguments.
10152 (TypeExpr): Added location argument to the constructor.
10154 * expression.cs (StaticCallExpr): Added location argument to
10156 (Indirection, PointerArithmetic): Likewise.
10157 (CheckedExpr, UnCheckedExpr): Likewise.
10158 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
10159 (StringPtr): Likewise.
10162 2002-08-05 Martin Baulig <martin@gnome.org>
10164 * expression.cs (BaseAccess.DoResolve): Actually report errors.
10166 * assign.cs (Assign.DoResolve): Check whether the source
10167 expression is a value or variable.
10169 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
10170 while resolving the corresponding blocks.
10172 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
10173 an error, don't silently return null.
10175 * statement.cs (Block.AddVariable): Do the error reporting here
10176 and distinguish between CS0128 and CS0136.
10177 (Block.DoResolve): Report all unused labels (warning CS0164).
10178 (LabeledStatement): Pass the location to the constructor.
10179 (LabeledStatement.HasBeenReferenced): New property.
10180 (LabeledStatement.Resolve): Set it to true here.
10182 * statement.cs (Return.Emit): Return success even after reporting
10183 a type mismatch error (CS0126 or CS0127), this is what csc does and
10184 it avoids confusing the users with any consecutive errors.
10186 2002-08-05 Martin Baulig <martin@gnome.org>
10188 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
10190 * const.cs (Const.LookupConstantValue): Catch circular definitions.
10192 * expression.cs (MemberAccess.DoResolve): Silently return if an
10193 error has already been reported.
10195 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
10196 error has already been reported.
10198 2002-08-05 Martin Baulig <martin@gnome.org>
10200 * statement.cs (UsageVector): Only initialize the `parameters'
10201 vector if we actually have any "out" parameters.
10203 2002-08-05 Martin Baulig <martin@gnome.org>
10205 * expression.cs (Binary.ResolveOperator): When combining delegates,
10206 they must have the same type.
10208 2002-08-05 Martin Baulig <martin@gnome.org>
10210 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
10211 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
10212 work with the ms runtime and we also don't need it: if we're a
10213 PropertyBuilder and not in the `indexer_arguments' hash, then we
10214 are a property and not an indexer.
10216 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
10217 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
10218 since the latter one doesn't work with the ms runtime.
10220 2002-08-03 Martin Baulig <martin@gnome.org>
10222 Fixed bugs #27998 and #22735.
10224 * class.cs (Method.IsOperator): New public field.
10225 (Method.CheckBase): Report CS0111 if there's already a method
10226 with the same parameters in the current class. Report CS0508 when
10227 attempting to change the return type of an inherited method.
10228 (MethodData.Emit): Report CS0179 if a method doesn't have a body
10229 and it's not marked abstract or extern.
10230 (PropertyBase): New abstract base class for Property and Indexer.
10231 (PropertyBase.CheckBase): Moved here from Property and made it work
10233 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
10234 the same so we can reuse it there.
10235 (Property, Indexer): Derive from PropertyBase.
10236 (MethodSignature.inheritable_property_signature_filter): New delegate
10237 to find properties and indexers.
10239 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
10240 argument and improved error reporting.
10242 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
10243 EmptyReadOnlyParameters and made it a property.
10245 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
10246 version of this method which takes a `PropertyInfo indexer'.
10247 (TypeManager.RegisterIndexer): New method.
10249 * class.cs: Added myself as author of this file :-)
10251 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10253 * class.cs: fixed compilation on windoze.
10255 2002-08-03 Martin Baulig <martin@gnome.org>
10257 * interface.cs (Interface.GetInterfaceBases): Check whether all
10258 base interfaces are at least as accessible than the current one.
10260 * class.cs (TypeContainer.GetClassBases): Check whether base types
10261 are at least as accessible than the current type.
10262 (TypeContainer.AsAccessible): Implemented and made non-static.
10263 (MemberBase.CheckParameters): Report errors if the accessibility
10266 * delegate.cs (Delegate.Delegate): The default visibility is
10267 internal for top-level types and private for nested types.
10268 (Delegate.Define): Report errors if the accessibility checks fail.
10270 * enum.cs (Enum.Enum): The default visibility is internal for
10271 top-level types and private for nested types.
10272 (Enum.DefineType): Compute the correct visibility.
10274 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10275 function which takes a `bool is_toplevel' instead of a TypeContainer.
10277 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10280 2002-08-02 Martin Baulig <martin@gnome.org>
10282 * expression.cs (LocalVariableReferenc): Added constructor which
10283 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10284 (LocalVariableReference.IsReadOnly): New property.
10285 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10286 variable is readonly, use our own readonly flag to do this; you can
10287 use the new constructor to get a writable reference to a read-only
10290 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10291 reference to the local variable.
10293 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10295 * rootcontext.cs (ResolveCore): Also include System.Exception
10297 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10298 we reach an EmptyStatement.
10300 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10303 * expression.cs (Binary.ResolveOperator): Check error result in
10306 use brtrue/brfalse directly and avoid compares to null.
10308 2002-08-02 Martin Baulig <martin@gnome.org>
10310 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10311 Fixes bug #28407, added test-155.cs.
10313 2002-08-01 Martin Baulig <martin@gnome.org>
10315 * class.cs (Event.EmitDefaultMethod): Make this work with static
10316 events. Fixes #28311, added verify-3.cs.
10318 2002-08-01 Martin Baulig <martin@gnome.org>
10320 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10321 `is_disposable' fields.
10322 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10323 `hm.is_disposable' if we're using the collection pattern.
10324 (Foreach.EmitCollectionForeach): Use the correct type for the
10325 enumerator's local variable, only emit the try/finally block if
10326 necessary (fixes #27713).
10328 2002-08-01 Martin Baulig <martin@gnome.org>
10330 * ecore.cs (Expression.report118): Renamed to Error118 and made
10333 * statement.cs (Throw.Resolve): Check whether the expression is of
10334 the correct type (CS0118) and whether the type derives from
10335 System.Exception (CS0155).
10336 (Catch.Resolve): New method. Do the type lookup here and check
10337 whether it derives from System.Exception (CS0155).
10338 (Catch.CatchType, Catch.IsGeneral): New public properties.
10340 * typemanager.cs (TypeManager.exception_type): Added.
10342 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10344 * driver.cs: Updated About function.
10346 2002-07-31 Martin Baulig <martin@gnome.org>
10348 Implemented Control Flow Analysis.
10350 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10351 (EmitContext.CurrentBranching): Added.
10352 (EmitContext.StartFlowBranching): Added.
10353 (EmitContext.EndFlowBranching): Added.
10354 (EmitContext.KillFlowBranching): Added.
10355 (EmitContext.IsVariableAssigned): Added.
10356 (EmitContext.SetVariableAssigned): Added.
10357 (EmitContext.IsParameterAssigned): Added.
10358 (EmitContext.SetParameterAssigned): Added.
10359 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10360 Added control flow analysis stuff here.
10362 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10363 resolve the expression as lvalue.
10364 (LocalVariableReference.DoResolve): Check whether the variable has
10365 already been assigned.
10366 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10367 the parameter as assigned here.
10368 (ParameterReference.DoResolve): Check whether the parameter has already
10370 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10371 expression as lvalue.
10373 * statement.cs (FlowBranching): New class for the flow analysis code.
10374 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10375 (LabeledStatement.IsDefined): New public property.
10376 (LabeledStatement.AddUsageVector): New public method to tell flow
10377 analyis that the label may be reached via a forward jump.
10378 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10380 (VariableInfo.Number): New public field. This is used by flow analysis
10381 to number all locals of a block.
10382 (Block.CountVariables): New public property. This is the number of
10383 local variables in this block (including the locals from all parent
10385 (Block.EmitMeta): Number all the variables.
10387 * statement.cs: Added flow analysis support to all classes.
10389 2002-07-31 Martin Baulig <martin@gnome.org>
10391 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10392 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10393 then use this argument.
10395 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10397 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10398 use this to specify /define options.
10400 2002-07-29 Martin Baulig <martin@gnome.org>
10402 * statement.cs (Fixed): Moved all code that does variable lookups
10403 and resolvings from Emit to Resolve.
10405 * statement.cs (For): Moved all code that does variable lookups
10406 and resolvings from Emit to Resolve.
10408 * statement.cs (Using): Moved all code that does variable lookups
10409 and resolvings from Emit to Resolve.
10411 2002-07-29 Martin Baulig <martin@gnome.org>
10413 * attribute.cs (Attribute.Resolve): Explicitly catch a
10414 System.NullReferenceException when creating the
10415 CustromAttributeBuilder and report a different warning message.
10417 2002-07-29 Martin Baulig <martin@gnome.org>
10419 * support.cs (ParameterData.ParameterName): Added method to
10420 get the name of a parameter.
10422 * typemanager.cs (TypeManager.IsValueType): New public method.
10424 2002-07-29 Martin Baulig <martin@gnome.org>
10426 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10427 is a flag which specifies that it's either ref or out.
10428 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10429 the out parameter to `out Parameter.Modifier mod', also set the
10430 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10432 * support.cs (InternalParameters.ParameterModifier): Distinguish
10433 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10434 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10436 * expression.cs (Argument.GetParameterModifier): Distinguish
10437 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10438 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10440 2002-07-29 Martin Baulig <martin@gnome.org>
10442 * expression.cs (ParameterReference.ParameterReference): Added
10443 `Location loc' argument to the constructor.
10445 * cs-parser.jay: Pass location to ParameterReference.
10447 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10449 * statement.cs (Try): Initialize the location.
10451 * cs-parser.jay: pass location to Try.
10453 * expression.cs (Unary.Reduce): Change the prototype to return
10454 whether a constant fold could be performed or not. The result is
10455 returned in an out parameters. In the case of Indirection and
10456 AddressOf, we want to perform the full tests.
10458 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10460 * statement.cs (Statement.Emit): Flag dead code.
10462 2002-07-27 Andrew Birkett <andy@nobugs.org>
10464 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10466 2002-07-27 Martin Baulig <martin@gnome.org>
10468 * class.cs (MethodData.Define): Put back call to
10469 TypeManager.AddMethod(), accidentally commented this out.
10471 * report.cs (Debug): New public method to print debugging information,
10472 this is `[Conditional ("DEBUG")]'.
10474 2002-07-26 Martin Baulig <martin@gnome.org>
10476 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10477 (switch_statement): Push the current_block to the switch_stack and
10478 pop it again when we're done with the switch.
10479 (switch_section): The new block is a child of the current_block.
10480 Fixes bug #24007, added test-152.cs.
10482 2002-07-27 Martin Baulig <martin@gnome.org>
10484 * expression.cs (Invocation.EmitArguments): When calling a varargs
10485 function with only its fixed arguments, we need to pass an empty
10488 2002-07-27 Martin Baulig <martin@gnome.org>
10490 Mono 0.13 has been released.
10492 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10494 * driver.cs: Rename --resource to --linkres, because that is what
10495 we do currently, we dont support --resource yet.
10497 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10499 2002-07-25 Martin Baulig <martin@gnome.org>
10501 * class.cs (MethodData): New public class. This is a `method builder'
10502 class for a method or one accessor of a Property/Indexer/Event.
10503 (MethodData.GetMethodFlags): Moved here from MemberBase.
10504 (MethodData.ApplyAttributes): Likewise.
10505 (MethodData.ApplyObsoleteAttribute): Likewise.
10506 (MethodData.ApplyConditionalAttribute): Likewise.
10507 (MethodData.ApplyDllImportAttribute): Likewise.
10508 (MethodData.CheckAbstractAndExternal): Likewise.
10509 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10510 (MethodData.Emit): Formerly known as Method.Emit().
10511 (MemberBase): Moved everything which was specific to a single
10512 accessor/method to MethodData.
10513 (Method): Create a new MethodData and call Define() and Emit() on it.
10514 (Property, Indexer, Event): Create a new MethodData objects for each
10515 accessor and call Define() and Emit() on them.
10517 2002-07-25 Martin Baulig <martin@gnome.org>
10519 Made MethodCore derive from MemberBase to reuse the code from there.
10520 MemberBase now also checks for attributes.
10522 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10523 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10525 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10526 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10527 (MemberBase.ApplyAttributes): New virtual method; applies the
10528 attributes to a method or accessor.
10529 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10530 (MemberBase.ApplyConditionalAttribute): Likewise.
10531 (MemberBase.ApplyDllImportAttribute): Likewise.
10532 (MemberBase.CheckAbstractAndExternal): Likewise.
10533 (MethodCore.ParameterTypes): This is now a property instead of a
10534 method, it's initialized from DoDefineParameters().
10535 (MethodCore.ParameterInfo): Removed the set accessor.
10536 (MethodCore.DoDefineParameters): New protected virtual method to
10537 initialize ParameterTypes and ParameterInfo.
10538 (Method.GetReturnType): We can now simply return the MemberType.
10539 (Method.GetMethodFlags): Override the MemberBase version and add
10540 the conditional flags.
10541 (Method.CheckBase): Moved some code from Define() here, call
10542 DoDefineParameters() here.
10543 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10544 here to avoid some larger code duplication.
10545 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10546 ensure that abstract and external accessors don't declare a body.
10548 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10549 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10550 lookup in the attribute's parent classes, so we need to abort as soon
10551 as we found the first match.
10552 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10553 the attribute has no arguments.
10555 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10558 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10560 * cs-parser.jay: reverted previous patch.
10562 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10564 * cs-parser.jay: fixed bug #22119.
10566 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10568 * attribute.cs: fixed compilation. The error was:
10569 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10570 be assigned to before control leaves the current method."
10571 [FIXME: Filed as bug #28186: MCS must report this error.]
10573 2002-07-25 Martin Baulig <martin@gnome.org>
10575 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10576 method to pull the condition name ouf of a Conditional attribute.
10577 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10578 the obsolete message and error flag out of an Obsolete attribute.
10580 * class.cs (Method.GetMethodFlags): New public method to get the
10581 TypeManager.MethodFlags for this method.
10582 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10584 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10585 if we're overriding a virtual function, set the new private variable
10586 `parent_method'; call the new TypeManager.AddMethod().
10588 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10589 the MethodBuilder and the Method in a PtrHashtable.
10590 (TypeManager.builder_to_method): Added for this purpose.
10591 (TypeManager.MethodFlags): Added IsObsoleteError.
10592 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10593 Obsolete and Conditional arguments in MethodBuilders. If we discover
10594 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10595 the message from the attribute.
10597 2002-07-24 Martin Baulig <martin@gnome.org>
10599 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10600 preprocessor directives, ensure that the argument to #define/#undef is
10601 exactly one identifier and that it's actually an identifier.
10603 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10606 2002-07-24 Martin Baulig <martin@gnome.org>
10608 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10609 initialize it to TypeManager.object_type in the constructor.
10610 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10611 of the `hm.get_current' method if we're using the collection pattern.
10612 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10613 for the explicit conversion to make it work when we're using the collection
10614 pattern and the `Current' property has a different return type than `object'.
10617 2002-07-24 Martin Baulig <martin@gnome.org>
10619 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10620 does not match, but don't report any errors. This method is called in
10621 order for all methods in a MethodGroupExpr until a matching method is
10622 found, so we don't want to bail out if the first method doesn't match.
10623 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10624 matches, report the 123. Fixes #28070.
10626 2002-07-24 Martin Baulig <martin@gnome.org>
10628 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10629 TypeManager.TypeToCoreType() to the top of the method so the
10630 following equality checks will work. Fixes #28107.
10632 2002-07-24 Martin Baulig <martin@gnome.org>
10634 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10635 operand is of type uint, and the other operand is of type sbyte,
10636 short or int, the operands are converted to type long." -
10637 Actually do what this comment already told us. Fixes bug #28106,
10640 2002-07-24 Martin Baulig <martin@gnome.org>
10642 * class.cs (MethodBase): New abstract class. This is now a base
10643 class for Property, Indexer and Event to avoid some code duplication
10644 in their Define() and DefineMethods() methods.
10645 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10646 generic methods for Define() and DefineMethods().
10647 (FieldBase): Derive from MemberBase, not MemberCore.
10648 (Property): Derive from MemberBase, not MemberCore.
10649 (Property.DefineMethod): Moved all the code from this method to the
10650 new MethodBase.DefineAccessor(), just call it with appropriate
10652 (Property.Define): Call the new Property.DoDefine(), this does some
10653 sanity checks and we don't need to duplicate the code everywhere.
10654 (Event): Derive from MemberBase, not MemberCore.
10655 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10656 accessors, this will also make them work with interface events.
10657 (Indexer): Derive from MemberBase, not MemberCore.
10658 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10659 (Indexer.Define): Use the new MethodBase functions.
10661 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10662 argument to the constructor.
10663 (Interface.FindMembers): Added support for interface events.
10664 (Interface.PopluateEvent): Implemented.
10666 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10668 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10670 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10671 but this is required to check for a method name being the same as
10672 the containing class.
10676 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10678 * interface.cs: initialize variable.
10680 2002-07-23 Martin Baulig <martin@gnome.org>
10682 Implemented the IndexerName attribute in interfaces.
10684 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10685 name if this is an explicit interface implementation.
10686 (Indexer.InterfaceIndexerName): New public variable. If we're
10687 implementing an interface indexer, this is the IndexerName in that
10688 interface. Otherwise, it's the IndexerName.
10689 (Indexer.DefineMethod): If we're implementing interface indexer,
10690 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10691 and Pending.ImplementIndexer methods.
10692 (Indexer.Define): Also define the PropertyBuilder if we're
10693 implementing an interface indexer and this is neither an explicit
10694 interface implementation nor do the IndexerName match the one in
10697 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10698 If a method is defined here, then we always need to create a proxy
10699 for it. This is used when implementing interface indexers.
10700 (Pending.IsInterfaceIndexer): New public method.
10701 (Pending.ImplementIndexer): New public method.
10702 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10703 This is used when implementing interface indexers to define a proxy
10705 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10706 define a proxy if necessary.
10708 * interface.cs (Interface.IndexerName): New public variable.
10709 (Interface.PopulateIndexer): Set the IndexerName.
10710 (Interface.DefineIndexers): New private method. Populate all the
10711 indexers and make sure their IndexerNames match.
10713 * typemanager.cs (IndexerPropertyName): Added support for interface
10716 2002-07-22 Martin Baulig <martin@gnome.org>
10718 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10719 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10720 ret if HasReturnLabel.
10721 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10724 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10725 and set the ec.LoopBeginTryCatchLevel.
10726 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10727 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10728 the current ec.TryCatchLevel, the branch goes out of an exception
10729 block. In this case, we need to use Leave and not Br.
10731 2002-07-22 Martin Baulig <martin@gnome.org>
10733 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10734 block unless the block does not always return or it is contained in
10735 another try { ... } catch { ... } block. Fixes bug #26506.
10736 Added verify-1.cs to the test suite.
10738 2002-07-22 Martin Baulig <martin@gnome.org>
10740 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10741 then we do not always return. Fixes bug #24985.
10743 2002-07-22 Martin Baulig <martin@gnome.org>
10745 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10746 lookup on a per-class level; ie. walk up the class hierarchy until we
10747 found at least one applicable method, then choose the best among them.
10748 Fixes bug #24463 and test-29.cs.
10750 2002-07-22 Martin Baulig <martin@gnome.org>
10752 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10753 return types of the methods. The return type is not part of the
10754 signature and we must not check it to make the `new' modifier work.
10755 Fixes bug #27999, also added test-147.cs.
10756 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10758 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10759 on the method's return type.
10761 2002-07-21 Martin Baulig <martin@gnome.org>
10763 * assign.cs: Make this work if the rightmost source is a constant and
10764 we need to do an implicit type conversion. Also adding a few more tests
10765 to test-38.cs which should have caught this.
10767 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10768 target in the makefile for this. The makefile.gnu is primarily intended
10769 for end-users who don't want to debug the compiler.
10771 2002-07-21 Martin Baulig <martin@gnome.org>
10773 * assign.cs: Improved the Assign class so it can now handle embedded
10774 assignments (X = Y = Z = something). As a side-effect this'll now also
10775 consume less local variables. test-38.cs now passes with MCS, added
10776 a few new test cases to that test.
10778 2002-07-20 Martin Baulig <martin@gnome.org>
10780 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10781 instructions. Fixes bug #27977, also added test-146.cs.
10783 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10785 * cs-tokenizer.cs: fixed getHex ().
10787 2002-07-19 Martin Baulig <martin@gnome.org>
10789 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10790 not Type.GetType() to lookup the array type. This is needed when
10791 we're constructing an array of a user-defined type.
10792 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10793 single-dimensional arrays, but also for single-dimensial arrays of
10796 2002-07-19 Martin Baulig <martin@gnome.org>
10798 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10799 this function is called, it's not allowed to share LocalBuilders
10800 among ILGenerators.
10802 2002-07-19 Martin Baulig <martin@gnome.org>
10804 * expression.cs (Argument.Resolve): Report an error 118 when trying
10805 to pass a type as argument.
10807 2002-07-18 Martin Baulig <martin@gnome.org>
10809 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10810 Conv_R_Un for the signed `long' type.
10812 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10814 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10815 `expr' for the temporary result, as that will fail if we do
10816 multiple resolves on the same expression.
10818 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10820 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10821 ec.TypeContainer for looking up aliases.
10823 * class.cs (TypeContainer): Remove LookupAlias from here.
10825 * decl.cs (DeclSpace); Move here.
10827 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10829 * class.cs (FindMembers): Only call filter if the constructor
10830 bulider is not null.
10832 Also handle delegates in `NestedTypes' now. Now we will perform
10833 type lookups using the standard resolution process. This also
10836 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10837 This uses Expressions (the limited kind that can be parsed by the
10838 tree) instead of strings.
10840 * expression.cs (ComposedCast.ToString): Implement, used to flag
10841 errors since now we have to render expressions.
10843 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10846 * ecore.cs (SimpleName.ToString): ditto.
10848 * cs-parser.jay: Instead of using strings to assemble types, use
10849 Expressions to assemble the type (using SimpleName, ComposedCast,
10850 MemberAccess). This should fix the type lookups in declarations,
10851 because we were using a different code path for this.
10853 * statement.cs (Block.Resolve): Continue processing statements
10854 even when there is an error.
10856 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10858 * class.cs (Event.Define): Also remove the `remove' method from
10859 the list of pending items.
10861 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10862 generate more compact code.
10864 2002-07-17 Martin Baulig <martin@gnome.org>
10866 * const.cs (Const.LookupConstantValue): Add support for constant
10867 `unchecked' and `checked' expressions.
10868 Also adding test case test-140.cs for this.
10870 2002-07-17 Martin Baulig <martin@gnome.org>
10872 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10873 check whether mi.ReturnType implements the IEnumerator interface; the
10874 `==' and the IsAssignableFrom() will fail in this situation.
10876 2002-07-16 Ravi Pratap <ravi@ximian.com>
10878 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10881 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10883 * expression.cs: fixed bug #27811.
10885 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10887 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10888 Molaro: when we are a ref, the value already contains a pointer
10889 value, do not take the address of it.
10891 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10892 * removed mb-parser.jay and mb-tokenizer.cs
10894 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10896 * expression.cs: check against the building corlib void type.
10898 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10900 * ecore.cs: fix for valuetype static readonly fields: when
10901 initializing them, we need their address, not the address of a copy.
10903 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10905 * typemanager.cs: register also enum_type in corlib.
10907 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10909 * class.cs: allow calling this (but not base) initializers in structs.
10911 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10913 * ecore.cs: make sure we compare against the building base types
10916 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10918 * typemanager.cs: fix TypeToCoreType() to handle void and object
10919 (corlib gets no more typerefs after this change).
10921 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10923 * expression.cs (ArrayCreation.EmitArrayArguments): use
10924 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10926 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10927 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10928 array indexes, the runtime actually forbids them.
10930 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10931 for array arguments here.
10933 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10934 instead of the default for ValueTypes.
10936 (New.DoEmit): Use IsValueType instead of
10937 IsSubclassOf (value_type)
10938 (New.DoResolve): ditto.
10939 (Invocation.EmitCall): ditto.
10941 * assign.cs (Assign): ditto.
10943 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10944 Statements *are* currently doing part of their resolution during
10947 Expressions do always resolve during resolve, but statements are
10948 only required to propagate resolution to their children.
10950 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10952 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10954 (LoadAssembly): Do not add the dll if it is already specified
10956 (MainDriver): Add the System directory to the link path at the end,
10957 after all the other -L arguments.
10959 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10960 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10961 ldelem.u1) and using the opposite for sbytes.
10963 This fixes Digger, and we can finally run it.
10965 * driver.cs (UnixParseOption): Move the option parsing here.
10966 (CSCParseOption): Implement CSC-like parsing of options.
10968 We now support both modes of operation, the old Unix way, and the
10969 new CSC-like way. This should help those who wanted to make cross
10970 platform makefiles.
10972 The only thing broken is that /r:, /reference: and /lib: are not
10973 implemented, because I want to make those have the same semantics
10974 as the CSC compiler has, and kill once and for all the confussion
10975 around this. Will be doing this tomorrow.
10977 * statement.cs (Unsafe.Resolve): The state is checked during
10978 resolve, not emit, so we have to set the flags for IsUnsfe here.
10980 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10982 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10983 not catch the Error_ObjectRefRequired in SimpleName (as it is
10984 possible to have a class/instance variable name that later gets
10985 deambiguated), we have to check this here.
10987 2002-07-10 Ravi Pratap <ravi@ximian.com>
10989 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10990 make static and put into Expression.
10992 (Event.Define): Register the private field of the event with the
10993 TypeManager so that GetFieldFromEvent can get at it.
10995 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10996 keep track of the private field associated with an event which
10999 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
11002 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
11004 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11006 * expression.cs (Binary.EmitBranchable): this routine emits the
11007 Binary expression in a branchable context. This basically means:
11008 we need to branch somewhere, not just get the value on the stack.
11010 This works together with Statement.EmitBoolExpression.
11012 * statement.cs (Statement.EmitBoolExpression): Use
11015 2002-07-09 Miguel de Icaza <miguel@ximian.com>
11017 * statement.cs (For): Reduce the number of jumps in loops.
11019 (For): Implement loop inversion for the For statement.
11021 (Break): We can be breaking out of a Try/Catch controlled section
11022 (foreach might have an implicit try/catch clause), so we need to
11023 use Leave instead of Br.
11025 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
11026 now). If the instace expression supports IMemoryLocation, we use
11027 the AddressOf method from the IMemoryLocation to extract the
11028 address instead of emitting the instance.
11030 This showed up with `This', as we were emitting the instance
11031 always (Emit) instead of the Address of This. Particularly
11032 interesting when This is a value type, as we dont want the Emit
11033 effect (which was to load the object).
11035 2002-07-08 Miguel de Icaza <miguel@ximian.com>
11037 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
11039 * statement.cs (Checked): Set the CheckedState during the resolve
11040 process too, as the ConvCast operations track the checked state on
11041 the resolve process, and not emit.
11043 * cs-parser.jay (namespace_member_declaration): Flag that we have
11044 found a declaration when we do. This is used to flag error 1529
11046 * driver.cs: Report ok when we display the help only.
11048 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
11050 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
11052 2002-07-04 Miguel de Icaza <miguel@ximian.com>
11054 * cs-tokenizer.cs (define): We also have to track locally the
11055 defines. AllDefines is just used for the Conditional Attribute,
11056 but we also need the local defines for the current source code.
11058 2002-07-03 Miguel de Icaza <miguel@ximian.com>
11060 * statement.cs (While, For, Do): These loops can exit through a
11061 Break statement, use this information to tell whether the
11062 statement is the last piece of code.
11064 (Break): Flag that we break.
11066 * codegen.cs (EmitContexts): New `Breaks' state variable.
11068 2002-07-03 Martin Baulig <martin@gnome.org>
11070 * class.cs (TypeContainer.MethodModifiersValid): Allow override
11071 modifiers in method declarations in structs. Otherwise, you won't
11072 be able to override things like Object.Equals().
11074 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11076 * class.cs (Method, Property, Indexer): Do not allow the public
11077 modifier to be used in explicit interface implementations.
11079 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
11080 override modifiers in method declarations in structs
11082 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
11084 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
11085 integer or real overflow, report an error
11087 2002-07-02 Martin Baulig <martin@gnome.org>
11089 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
11090 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
11091 to tell the runtime about our newly created System.Object and
11092 System.ValueType types.
11094 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11096 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
11097 struct instead of Ldarg/Starg.
11099 2002-07-02 Martin Baulig <martin@gnome.org>
11101 * expression.cs (Indirection.Indirection): Call
11102 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
11104 2002-07-02 Martin Baulig <martin@gnome.org>
11106 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
11107 ValueType, call TypeManager.TypeToCoreType() on it.
11108 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
11109 the OpCodes.Newarr argument.
11111 2002-07-02 Martin Baulig <martin@gnome.org>
11113 * expression.cs (Invocation.EmitCall): When compiling corlib,
11114 replace all calls to the system's System.Array type to calls to
11115 the newly created one.
11117 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
11118 System.Array methods.
11119 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
11120 from the system's System.Array type which must be replaced.
11122 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
11124 * typemanager.cs: load unverifiable_code_ctor so we can build
11125 corlib using the correct type. Avoid using GetTypeCode() with
11127 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
11128 TypeManager.object_type to allow building corlib.
11130 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
11132 * ecore.cs: handle System.Enum separately in LoadFromPtr().
11134 2002-07-01 Martin Baulig <martin@gnome.org>
11136 * class.cs: Make the last change actually work, we need to check
11137 whether `ifaces != null' to avoid a crash.
11139 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11141 * class.cs: when we build structs without fields that implement
11142 interfaces, we need to add the interfaces separately, since there is
11143 no API to both set the size and add the interfaces at type creation
11146 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11148 * expression.cs: the dimension arguments to the array constructors
11149 need to be converted if they are a long.
11151 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
11153 * class.cs: don't emit ldarg.0 if there is no parent constructor
11154 (fixes showstopper for corlib).
11156 2002-06-29 Martin Baulig <martin@gnome.org>
11158 MCS now compiles corlib on GNU/Linux :-)
11160 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
11161 ie. check for MethodImplOptions.InternalCall.
11163 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
11164 and TypeManager.attribute_type are null, so we must explicitly check
11165 whether parent is not null to find out whether it's an attribute type.
11166 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
11167 and SetBuilder, not only if the property is neither abstract nor external.
11168 This is necessary to set the MethodImplOptions on the accessor methods.
11169 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
11170 SetBuilder, see Property.Emit().
11172 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
11173 populate "System.Object", "System.ValueType" and "System.Attribute" since
11174 they've already been populated from BootCorlib_PopulateCoreTypes().
11176 2002-06-29 Martin Baulig <martin@gnome.org>
11178 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
11179 is the NullLiteral, we also need to make sure that target_type is not
11182 2002-06-29 Martin Baulig <martin@gnome.org>
11184 * rootcontext.cs (RootContext.ResolveCore): We must initialize
11185 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
11186 before calling BootstrapCorlib_ResolveDelegate ().
11188 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11190 * statement.cs: fixed build-breaker. All tests passed ok.
11192 2002-06-27 Martin Baulig <martin@gnome.org>
11194 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
11195 for System.Decimal when compiling corlib.
11197 2002-06-27 Martin Baulig <martin@gnome.org>
11199 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
11200 switch blocks which contain nothing but a default clause.
11202 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
11204 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
11206 2002-06-27 Martin Baulig <martin@gnome.org>
11208 * ecore.cs (PropertyExpr.PropertyExpr): Call
11209 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
11211 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
11212 is already a TypeBuilder.
11214 2002-06-27 Martin Baulig <martin@gnome.org>
11216 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
11217 `target_type == TypeManager.array_type', not IsAssignableFrom() in
11218 the "from an array-type to System.Array" case. This makes it work
11219 when compiling corlib.
11221 2002-06-27 Martin Baulig <martin@gnome.org>
11223 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
11224 non-static PropertyExpr, set its InstanceExpression. This makes
11225 the `ICollection.Count' property work in System/Array.cs.
11227 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
11229 * driver.cs: Made error handling more consistent. Errors now
11230 tracked by Report class, so many methods which used to return int
11231 now return void. Main() now prints success/failure and
11232 errors/warnings message.
11234 Renamed '--probe' compiler argument to '--expect-error'. Removed
11235 the magic number return values (123 and 124). Now, if the
11236 expected error occurs, the compiler exits with success (exit value
11237 0). If the compilation completes without seeing that particular
11238 error, the compiler exits with failure (exit value 1). The
11239 makefile in mcs/errors has been changed to handle the new behaviour.
11241 * report.cs: Made 'expected error' number a property and renamed
11242 it from 'Probe' to 'ExpectedError'.
11244 * genericparser.cs: Removed error handling support, since it is
11245 now all done by Report class.
11247 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
11248 class, so parse() no longer returns an int.
11250 * namespace.cs: Use Report.Error instead of GenericParser.error
11252 2002-06-22 Miguel de Icaza <miguel@ximian.com>
11254 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
11255 TypeContainer.AddOperator): At the front of the list put the
11256 explicit implementations, so they get resolved/defined first.
11258 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11260 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11261 interface type is implemented by this TypeContainer. Used during
11262 explicit interface implementation.
11264 (Property.Define, Indexer.Define, Method.Define): Validate that
11265 the given interface in the explicit implementation is one of the
11266 base classes for the containing type.
11268 Also if we are explicitly implementing an interface, but there is
11269 no match in the pending implementation table, report an error.
11271 (Property.Define): Only define the property if we are
11272 not explicitly implementing a property from an interface. Use the
11273 correct name also for those properties (the same CSC uses,
11274 although that is really not needed).
11276 (Property.Emit): Do not emit attributes for explicitly implemented
11277 properties, as there is no TypeBuilder.
11279 (Indexer.Emit): ditto.
11281 Hiding then means that we do not really *implement* a pending
11282 implementation, which makes code fail.
11284 2002-06-22 Martin Baulig <martin@gnome.org>
11286 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11287 the return value of Object.GetType(). [FIXME: we need to do this whenever
11288 we get a type back from the reflection library].
11290 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11292 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11294 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11296 * attribute.cs: Return null if we can not look up the type.
11298 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11299 the interface types found.
11301 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11302 interface types found.
11304 * typemanager.cs (GetInterfaces): Make this routine returns alll
11305 the interfaces and work around the lame differences between
11306 System.Type and System.Reflection.Emit.TypeBuilder in the results
11307 result for GetInterfaces.
11309 (ExpandInterfaces): Given an array of interface types, expand and
11310 eliminate repeated ocurrences of an interface. This expands in
11311 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11314 2002-06-21 Martin Baulig <martin@gnome.org>
11316 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11319 2002-06-21 Martin Baulig <martin@gnome.org>
11321 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11322 and called with one of the core types, return the corresponding typebuilder for
11325 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11328 2002-06-21 Martin Baulig <martin@gnome.org>
11330 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11331 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11332 (Expression.ConvertReferenceExplicit): Likewise.
11334 * expression.cs (ElementAccess.DoResolve): Likewise.
11335 (ElementAccess.DoResolveLValue): Likewise.
11337 2002-06-10 Martin Baulig <martin@gnome.org>
11339 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11340 add the "value" parameter to the parameter list.
11342 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11345 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11347 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11348 the argument to an int, uint, long or ulong, per the spec. Also
11349 catch negative constants in array creation.
11351 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11353 * class.cs: do not allow the same interface to appear twice in
11354 the definition list.
11356 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11358 * ecore.cs: don't use ldlen with System.Array.
11360 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11362 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11364 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11366 * modifiers.cs: produce correct field attributes for protected
11367 internal. Easy fix so miguel can work on ther harder stuff:-)
11369 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11371 * pending.cs: New file. Move the code from class.cs here.
11372 Support clearning the pending flag for all methods (when not doing
11373 explicit interface implementation).
11375 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11377 * rootcontext.cs: added a couple more types needed to bootstrap.
11379 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11381 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11382 constructor in the type, instead of any constructor in the type
11383 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11384 a bug in the Mono runtime when applying the params attribute).
11386 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11387 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11389 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11391 * expression.cs (Unary.ResolveOperator): Use TypeManager
11392 to resolve the type.
11394 2002-06-13 Ravi Pratap <ravi@ximian.com>
11396 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11399 * enum.cs (AddEnumMember): Add support to store the attributes associated
11400 with each member too.
11402 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11403 field builders too - this takes care of the enum member case.
11405 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11407 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11408 address-of operator on both value types and pointers.
11410 2002-06-10 Martin Baulig <martin@gnome.org>
11412 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11413 PropertyBuilder to the `property_builders' list.
11415 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11416 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11417 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11418 find any indexers which are inherited from an interface.
11420 2002-06-09 Martin Baulig <martin@gnome.org>
11422 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11423 the same type as the constant if necessary. There's also a test-130.cs
11426 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11428 * typemanager.cs (TypeManager.ChangeType): Previously known as
11429 Enum.ChangeEnumType().
11431 2002-06-09 Martin Baulig <martin@gnome.org>
11433 * expression.cs (Cast.TryReduce): Added support for consts.
11435 2002-06-08 Ravi Pratap <ravi@ximian.com>
11437 * class.cs (Accessor): Hold attributes information so we can pass
11440 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11441 Modify to pass in attributes attached to the methods.
11443 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11445 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11446 to handle the Accessor kind :-)
11448 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11450 2002-06-08 Martin Baulig <martin@gnome.org>
11452 * expression.cs (Unary.TryReduceNegative): Added support for
11455 2002-06-08 Martin Baulig <martin@gnome.org>
11457 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11458 name can't be found in the `defined_names' - the caller will do a
11459 MemberLookup in this case and thus find methods in System.Enum
11460 such as Enum.IsDefined().
11462 2002-06-08 Martin Baulig <martin@gnome.org>
11464 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11465 Convert.ChangeType() which works with TypeBuilder created types.
11466 (Enum.LookupEnumValue, Enum.Define): Use it here.
11468 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11469 `TypeBuilder.BaseType != null' check.
11470 (TypeContainer.FindMembers): Only lookup parent members if we
11471 actually have a parent.
11472 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11473 (ConstructorInitializer.Resolve): Likewise.
11475 * interface.cs (Interface.FindMembers): Added
11476 `TypeBuilder.BaseType != null' check.
11478 * rootcontext.cs (RootContext.ResolveCore): Added
11479 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11480 classes_second_stage.
11482 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11483 debug_type and trace_type when compiling with --nostdlib.
11485 2002-06-07 Martin Baulig <martin@gnome.org>
11487 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11488 (AddField): Set it to true when adding a non-static field.
11489 (DefineType): Use `have_nonstatic_fields' to find out whether we
11490 have non-static fields, not `Fields != null'.
11492 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11494 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11495 dereferencing a null on the static-field code path)
11497 2002-05-30 Martin Baulig <martin@gnome.org>
11499 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11500 to take command line arguments. Use reflection to call the new
11501 custom `Initialize' function on the symbol writer and pass it the
11502 command line arguments.
11504 * driver.cs (--debug-args): New command line argument to pass command
11505 line arguments to the symbol writer.
11507 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11509 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11510 the target type for indexers and properties. Thanks to Joe for
11513 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11515 * typemanager.cs (MethodFlags): returns the method flags
11516 (Obsolete/ShouldIgnore) that control warning emission and whether
11517 the invocation should be made, or ignored.
11519 * expression.cs (Invocation.Emit): Remove previous hack, we should
11520 not do this on matching a base type, we should do this based on an attribute
11522 Only emit calls to System.Diagnostics.Debug and
11523 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11524 on the command line.
11526 * rootcontext.cs: Global settings for tracing and debugging.
11528 * cs-tokenizer.cs (define): New utility function to track
11529 defines. Set the global settings for TRACE and DEBUG if found.
11531 2002-05-25 Ravi Pratap <ravi@ximian.com>
11533 * interface.cs (Populate*): Pass in the TypeContainer as well as
11534 the DeclSpace as parameters so that we can create EmitContexts and
11535 then use that to apply attributes etc.
11537 (PopulateMethod, PopulateEvent, PopulateProperty)
11538 (PopulateIndexer): Apply attributes everywhere.
11540 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11543 (ApplyAttributes): Update accordingly.
11545 We now apply interface attributes for all members too.
11547 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11549 * class.cs (Indexer.Define); Correctly check if we are explicit
11550 implementation (instead of checking the Name for a ".", we
11551 directly look up if the InterfaceType was specified).
11553 Delay the creation of the PropertyBuilder.
11555 Only create the PropertyBuilder if we are not an explicit
11556 interface implementation. This means that explicit interface
11557 implementation members do not participate in regular function
11558 lookups, and hence fixes another major ambiguity problem in
11559 overload resolution (that was the visible effect).
11561 (DefineMethod): Return whether we are doing an interface
11564 * typemanager.cs: Temporary hack until we get attributes in
11565 interfaces (Ravi is working on that) and we get IndexerName
11566 support in interfaces.
11568 * interface.cs: Register the indexers as properties.
11570 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11571 warning, I have verified that this is a bug in the .NET runtime
11572 (JavaScript suffers of the same problem).
11574 * typemanager.cs (MemberLookup): When looking up members for
11575 interfaces, the parent of an interface is the implicit
11576 System.Object (so we succeed in searches of Object methods in an
11577 interface method invocation. Example: IEnumerable x; x.ToString
11580 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11582 * class.cs (Event): Events should also register if they do
11583 implement the methods that an interface requires.
11585 * typemanager.cs (MemberLookup); use the new GetInterfaces
11588 (GetInterfaces): The code used to lookup interfaces for a type is
11589 used in more than one place, factor it here.
11591 * driver.cs: Track the errors at the bottom of the file, we kept
11594 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11595 instance if the method we are calling is static!
11597 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11599 * attribute.cs (ApplyAttributes): Make this function filter out
11600 the IndexerName attribute (as that attribute in reality is never
11601 applied) and return the string constant for the IndexerName
11604 * class.cs (TypeContainer.Emit): Validate that all the indexers
11605 have the same IndexerName attribute, and if so, set the
11606 DefaultName attribute on the class.
11608 * typemanager.cs: The return value might contain other stuff (not
11609 only methods). For instance, consider a method with an "Item"
11610 property and an Item method.
11612 * class.cs: If there is a problem with the parameter types,
11615 2002-05-24 Ravi Pratap <ravi@ximian.com>
11617 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11618 looks at user defined conversion after making a call to
11619 StandardConversionExists - we need this for overload resolution.
11621 * expression.cs : Update accordingly the various method calls.
11623 This fixes 2 bugs filed against implicit user defined conversions
11625 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11627 * statement.cs: Track the result of the assignment.
11629 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11631 * expression.cs (MemberAccess): Improved error reporting for
11632 inaccessible members.
11634 2002-05-22 Martin Baulig <martin@gnome.org>
11636 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11637 itself with debugging support.
11639 2002-05-22 Martin Baulig <martin@gnome.org>
11641 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11642 Removed, this isn't needed anymore.
11644 2002-05-20 Martin Baulig <martin@gnome.org>
11646 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11647 be underlying type for an enum.
11649 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11651 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11652 that splits out the loading of just the core types.
11654 * rootcontext.cs (ResolveCore): Split the struct resolution in
11655 two, so we can load the enumeration underlying types before any
11658 * expression.cs (Is): Bandaid until we fix properly Switch (see
11659 bug #24985 for details).
11661 * typemanager.cs (ImplementsInterface): The hashtable will contain
11662 a null if there are no interfaces implemented.
11664 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11666 * cs-parser.jay (indexer_declarator): It is fine to have array
11669 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11671 * typemanager.cs: (RegisterBuilder): New function used to register
11672 TypeBuilders that implement interfaces. Since
11673 TypeBuilder.GetInterfaces (as usual) does not work with lame
11675 (AddUserType): register interfaces.
11677 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11678 dealing with TypeBuilder. Also, arrays are showing up as
11679 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11680 methods can not be invoked on them!
11682 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11683 (ImplicitReferenceConversionExists): Split out from
11684 StandardConversionExists.
11686 * expression.cs (As): We were only implementing one of the three
11687 cases for the as operator. We now implement them all.
11688 (Is): Implement the various other cases for Is as well.
11690 * typemanager.cs (CACHE): New define used to control if we want or
11691 not the FindMembers cache. Seems to have a negative impact on
11692 performance currently
11694 (MemberLookup): Nested types have full acess to
11695 enclosing type members
11697 Remove code that coped with instance/static returns for events, we
11698 now catch this in RealFindMembers.
11700 (RealFindMembers): only perform static lookup if the instance
11701 lookup did not return a type or an event.
11703 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11705 * assign.cs (CompoundAssign): We pass more semantic information
11706 now to Compound Assignments than we did before: now we have all
11707 the information at hand, and now we resolve the target *before* we
11708 do the expression expansion, which allows the "CacheValue" method
11709 to have the effect we intended (before, a [x] += 1 would generate
11710 two differen ArrayAccess expressions from the ElementAccess,
11711 during the resolution process).
11713 (CompoundAssign.DoResolve): Resolve target and original_source here.
11715 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11717 * expression.cs (ArrayAccess): dropped debugging information.
11719 * typemanager.cs: Small bug fix: I was always returning i_members,
11720 instead of one of i_members or s_members (depending on which had
11723 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11724 method is invoked before any code generation takes place, and it
11725 is a mechanism to inform that the expression will be invoked more
11726 than once, and that the method should use temporary values to
11727 avoid having side effects
11729 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11731 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11734 * expression.cs (Indirection, ArrayAccess): Add support for
11735 CacheTemporaries in these two bad boys.
11737 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11738 ldobj or ldind_ref.
11739 (StoreFromPtr): Handle stobj as well.
11741 * expression.cs (UnaryMutator): Share more code.
11743 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11744 down: I was not tracking the Filter function as well, which
11745 was affecting the results of the cache.
11747 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11749 * attribute.cs: Remove the hack to handle the CharSet property on
11752 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11754 * attribute.cs (DoResolve): More uglyness, we now only try to
11755 resolve the attribute partially, to extract the CharSet
11756 information (only if we are a StructLayout attribute). Otherwise
11758 (GetExtraTypeInfo): Add some code to conditionally kill in the
11759 future this. I am more and more convinced that the .NET
11760 framework has special code to handle the attribute setting on
11763 * expression.cs (IsParamsMethodApplicable): Revert my previous
11764 foreach change here, it was wrong.
11766 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11768 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11769 (pp_expr): do not abort on unknown input, just return.
11770 (eval): abort if there are pending chars.
11772 * attribute.cs (Attribute.Resolve): Positional parameters are
11773 optional. Deal with that case.
11775 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11776 the Ansi/Unicode/Auto information for the type.
11778 (TypeContainer.DefineType): instantiate the EmitContext here, as
11779 we will be using it during the type definition (to resolve
11780 attributes) and during the emit phase.
11782 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11783 to pull type information out of the attributes
11785 (Attribute.Resolve): track the constructor builder, and allow for
11786 multiple invocations (structs and classes will use this).
11788 * ecore.cs (MemberLookupFinal): new version with all the
11789 parameters customizable.
11791 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11792 constructors. Return if the result value is null (as the error
11793 would have been flagged already by MemberLookupFinal)
11795 Do not allow instances of abstract classes or interfaces to be
11798 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11799 We have to compare the assembly property here when dealing with
11800 FamANDAssem and Assembly access modifiers, because we might be
11801 creating an assembly from *modules* (that means that we are not
11802 getting TypeBuilders for types defined in other modules that are
11803 part of this assembly).
11805 (Method.Emit): If the method is marked abstract and has a body,
11808 (TypeContainer.DefineMembers): If both the defined member and the
11809 parent name match are methods, then do not emit any warnings: let
11810 the Method.Define routine take care of flagging warnings. But if
11811 there is a mismatch (method overrides something else, or method is
11812 overriwritten by something, then emit warning).
11814 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11815 set to null, this means `do not check for the return type on the
11818 (Method.Define): set the return type for the method signature to
11819 null, so that we get methods with the same name and parameters and
11820 different return types. This is used to flag warning 114 (you are
11821 hiding a method, and you probably want to use the new/override
11824 * typemanager.cs (MemberLookup): Implemented proper access
11825 control, closing a long standing set of bug reports. The problem
11826 was that the Framework only has two bits: Public and NonPublic,
11827 and NonPublic includes private and protected methods, but we need
11828 to enforce the FamANDAssem, FamOrAssem and Family.
11830 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11832 * statement.cs (GotoCase): Return true: Ammounts to giving up
11833 knowledge on whether we return or not, and letting the other case
11834 be responsible for it.
11836 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11838 * driver.cs: Do not load directories for each file processed, only
11839 do it if there is a pattern.
11841 * ecore.cs: Report readonly assigns here as well, as we might have
11842 been resolved only by MemberAccess.
11844 (SimpleName.SimpleNameResolve): Also be useful for LValue
11845 resolution. We need this to propagate assign to local readonly variables
11847 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11848 do not want to reuse potential criteria memory.
11850 * class.cs (MyEventBuilder): Set reflected_type;
11852 * ecore.cs (Constantify): Added support for constifying bools.
11854 (RootContext.LookupType): Added a cache for values looked up in
11855 the declaration space.
11857 * typemanager.cs (FindMembers): Now is a front-end to
11858 RealFindMembers, and provides a two-level hashtable-based cache to
11861 15% performance improvement: from 22.5 to 19.2 seconds.
11863 * expression.cs (IsParamsMethodApplicable): use foreach.
11864 (Invocation.DoResolve): ditto.
11865 (New.DoResolve): ditto.
11866 (ArrayCreation.DoResolve): ditto.
11868 * ecore.cs (FindMostEncompassingType): use foreach.
11870 * delegate.cs (NewDelegate.DoResolve): Use foreach
11872 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11873 (RemoveMethods): use foreach.
11875 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11876 nested foreach statements instead of for, and also break out of
11877 the inner loop once a match is found.
11879 (Invocation.OverloadResolve): Use foreach, simplify the code.
11881 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11883 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11884 we actually unwrap the expression to allow for extra information
11887 * expression.cs: Use Shr_Un on unsigned operations.
11889 2002-05-08 Ravi Pratap <ravi@ximian.com>
11891 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11892 applicable operators was not being considered correctly. This closes
11893 the bug Miguel reported.
11895 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11897 * attribute.cs: check that the type derives from System.Attribute
11898 and report the correct error in that case (moved the duplicate code to
11899 its own method, too).
11901 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11903 * attribute.cs: lookup attribute type name as the spec says: first the
11904 bare attribute name and then name + "Attribute" (nant compiles with
11905 mcs after this fix).
11907 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11909 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11910 Because of the way we parse things, we should try to see if a
11911 UIntConstant can fit in an integer.
11913 2002-05-07 Ravi Pratap <ravi@ximian.com>
11915 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11916 when we are in an explicit context.
11918 (ConvertReferenceExplicit): When converting from Iface type S to Class
11919 T make sure the rules are implemented as an OR.
11921 * parameter.cs (ParameterType): Make it a property for now although the
11922 purpose really isn't anything immediate.
11924 * expression.cs (Is*Applicable): Do better checking on the parameter type
11925 of a ref/out parameter. The ones from the system assemblies are already
11926 marked with the correct type so we don't need to do any correction.
11928 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11929 the object type is standard too so include that.
11931 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11933 * ecore.cs (StandardConversionExists): Augment with missing code:
11934 deal with IntConstant, LongConstants and Enumerations.
11936 * assign.cs: Report the error, instead of failing silently
11938 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11939 typecontainer that they are declared, because the
11940 typecontainer/namespace will have the list of using clauses that
11941 need to be applied.
11943 Assembly Attributes were escaping the normal registration
11946 (EmitCode): Apply attributes within an EmitContext that represents
11947 the container they were declared on.
11949 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11951 2002-05-06 Ravi Pratap <ravi@ximian.com>
11953 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11954 Revamp completely - make much cleaner as we now operate only
11957 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11958 to implement the logic detailed in the spec more correctly.
11960 (UserDefinedConversion): Update accordingly.
11962 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11964 * statement.cs: Return flow analysis information up.
11966 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11969 (token): Do not consume an extra character before calling
11972 2002-05-06 Piers Haken <piersh@friskit.com>
11974 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11976 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11978 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11979 EmitContext during the instance constructor initializer
11980 resolution, to stop access to instance variables.
11982 This is mandated by the spec, last paragraph of the `constructor
11983 initializers' section.
11985 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11987 * cs-parser.jay, class.cs (Accessor): new class used to represent
11988 an accessor (get or set). In the past we used `null' to represent
11989 a missing accessor. But this is ambiguous because there was no
11990 way to tell in abstract indexers/properties if one of them was
11993 Now there is a way of addressing that.
11995 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11996 instead of FindMembers.
11998 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11999 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
12001 * attribute.cs: Treat indexers and properties as the same in terms
12002 of applying attributes
12004 * ecore.cs (FindMostEncompassedType): Use statically initialized
12005 EmptyExpressions()s like we do elsewhere to avoid creating useless
12006 objects (and we take this out of the tight loop).
12008 (GetConversionOperators): Move the code to extract the actual
12009 operators to a separate routine to clean things up.
12011 2002-05-04 Miguel de Icaza <miguel@ximian.com>
12013 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
12014 events are always registered FieldBuilders.
12016 * class.cs (FieldBase): New class shared by Fields
12018 * delegate.cs: If we are a toplevel delegate, use our full name.
12019 If we are a nested delegate, then only use our tail name.
12021 2002-05-02 Ravi Pratap <ravi@ximian.com>
12023 * expression.cs (IsApplicable): Ensure that we add the "&" to
12024 ref/out types before comparing it with the type of the argument.
12026 (IsParamsMethodApplicable): Ditto.
12028 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
12031 * delegate.cs : Handle the case when we have more than one applicable
12032 method. Flag an error only when we finish checking all.
12034 2002-05-02 Miguel de Icaza <miguel@ximian.com>
12036 * expression.cs: Add support for boolean static initializers.
12038 2002-05-01 Miguel de Icaza <miguel@ximian.com>
12040 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
12042 * parameter.cs (ComputeParameterTypes,
12043 ComputeAndDefineParameterTypes): Better error handling: now we
12044 clear the `types' cache if we fail during any of the type lookups.
12045 We also return the status code correctly to our caller
12047 * delegate.cs: If we fail to define a delegate, abort the extra
12050 * expression.cs (Binary.ResolveOperator): for
12051 operator==(object,object) and operator !=(object, object) we also
12052 have to verify that there is an implicit conversion from one to
12055 (ArrayAccess.DoResolve): Array Access can operate on
12058 2002-04-30 Miguel de Icaza <miguel@ximian.com>
12060 * assign.cs (CompoundAssign): A new class used as a "flag" that
12061 the assignment actually is happening as part of a compound
12062 assignment operator.
12064 During compound assignment, a few new rules exist to enable things
12071 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
12072 to the type of x) if y is implicitly convertible to the type of x,
12073 and the operator is a builtin operator and the return type of the
12074 operator is explicitly convertible to the type of x.
12076 * rootcontext.cs: Reset warning level to 2. 4 catches various
12077 "interesting" features in mcs, we must clean this up at some
12078 point, but currently am trying to kill other bugs ;-)
12080 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
12081 in container classes as well.
12083 * expression.cs (Binary.ResolveOperator): Handle string case
12084 before anything else (as operator overloading does emit an error
12085 before doing anything else).
12087 This code could go away when we move to a table driven model, but
12088 i could not come up with a good plan last night.
12090 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
12092 * typemanager.cs (CSharpName): reimplementation using regex.
12093 * class.cs: added null check for fields in Emit
12094 * rootcontext.cs: set warninglevel to 4
12096 2002-04-29 Miguel de Icaza <miguel@ximian.com>
12098 * typemanager.cs (CSharpName): reimplemented with Lupus
12101 2002-04-28 Miguel de Icaza <miguel@ximian.com>
12103 * statement.cs (If): correclty implement Resolve, because we were
12104 not catching sem errors in there. The same process is needed
12106 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
12109 (Statement.Warning_DeadCodeFound): Factorize code.
12110 (While): Report dead code here too.
12112 (Statement): Added Resolve virtual method to allow
12113 for resolution split from the emit code.
12115 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12117 * statement.cs (EmitBoolExpression): No longer try to resolve the
12119 (MakeBoolean): New utility function that resolve, implicitly
12120 converts to boolean and tags the expression.
12123 (If, Do): Implement dead code elimination.
12124 (While): Implement loop inversion
12126 (Do, While, For, If): Resolve the expression prior to calling our
12129 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
12132 - added method Report28 (warning: program has more than one entry point)
12133 - added method IsEntryPoint, implements paragraph 10.1 of the spec
12134 - modified method Method.Define, the part at the end of the method
12136 * rootcontext.cs: added static public Location EntryPointLocation;
12138 * ../errors/cs0028.cs : Add test case for the above warning.
12141 - modified method CSharpName to allow arrays of primitive type to
12142 be printed nicely (e.g. instead of System.Int32[][] it now prints
12144 - added method CSharpSignature: returns the signature of a method
12145 in string format to be used in reporting errors, warnings, etc.
12147 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
12150 2002-04-26 Ravi Pratap <ravi@ximian.com>
12152 * delegate.cs (Define): Fix extremely silly bug where I was
12153 setting the type of the 'object' parameter of the BeginInvoke
12154 method to System.IAsyncResult instead of System.Object ;-)
12156 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12158 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
12161 (Constructor.Emit): return if we fail to initialize the
12162 constructor. Another door closed!
12164 * expression.cs (New.DoResolve): Improve error message (from -6 to
12165 1501). Use DeclaredOnly lookup to find the exact constructor.
12167 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
12168 loop. This is useful.
12170 * cs-parser.jay: Adjust the default parameters so that destructors
12171 have the proper signature.
12173 2002-04-26 Martin Baulig <martin@gnome.org>
12175 * driver.cs (LoadAssembly): If `assembly' contains any characters
12176 which are only valid in path names and not in assembly names
12177 (currently slash, backslash and point), use Assembly.LoadFrom ()
12178 instead of Assembly.Load () on the `assembly' (before iteration
12179 over the link_paths).
12181 2002-04-26 Martin Baulig <martin@gnome.org>
12183 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
12185 2002-04-25 Miguel de Icaza <miguel@ximian.com>
12187 * class.cs (Property): use the new typemanager.MemberLookup
12189 (TypeContainer.MemberLookup): Implement using the
12190 TypeManager.MemberLookup now.
12192 * typemanager.cs: Make MemberLookup a function of the TypeManager,
12193 and return MemberInfos, so that these can be used without an
12194 EmitContext (what we had before).
12196 2002-04-24 Miguel de Icaza <miguel@ximian.com>
12198 * expression.cs: Fix the case where the argument to params if the
12199 type of the params. I omitted handling this before. Fixed
12201 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12203 * driver.cs: Call BootCorlib_PopulateCoreType
12205 * class.cs (Property.CheckBase): Check for properties only, not
12208 * interface.cs: Temporary hack: try/catch around the
12209 CustomAttributeBuilder, because I am getting an exception that I
12212 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
12213 types whose definitions are required to be there (attributes are
12214 defined before standard types).
12216 Compute definitions as we boot the various types, as they are used
12217 immediately (value_type class will need object_type, but if we do
12218 not initialize object_type, we will pass a null, which will let
12219 the runtime pick the System.Object from the existing corlib, which
12220 is not what we want).
12222 2002-04-22 Patrik Torstensson <totte@labs2.com>
12224 * cs-tokenizer.cs: fixed a number of trim() issues.
12226 2002-04-22 Ravi Pratap <ravi@ximian.com>
12228 * expression.cs (Argument.Type): Ensure that we return the correct
12229 type when we have out or ref parameters [in which case we
12232 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12234 * class.cs (Property, Indexer): Allow extern modifier in there.
12236 * typemanager.cs (InitBaseTypes): Initializes object_type and
12237 value_type, since those will be used early on during the bootstrap
12238 process to compile corlib.
12240 (InitCoreTypes): Move code from here to InitBaseTypes.
12242 2002-04-21 Miguel de Icaza <miguel@ximian.com>
12244 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
12245 single-dimension arrays as using the ldlen opcode.
12247 Daniel Lewis discovered this optimization.
12249 * typemanager.cs: Add signature for System.Array::get_Length
12251 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12253 * statement.cs: report the error when the foreach does not apply to an
12254 array nor a collection.
12256 2002-04-19 Miguel de Icaza <miguel@ximian.com>
12258 * expression.cs: Add implicit conversions to the operator ~.
12260 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12262 * typemanager.cs: Locate the decimal constructor.
12264 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12266 * attribute.cs: use the new property of TypeOf.
12267 * expression.cs: added 'get' property around typearg.
12269 These changes fix a build breaker reported by NickD. Is this the
12270 correct way to fix? If not, please, revert my changes and make it
12273 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12275 * attribute.cs: Add support for typeof in attribute invocations.
12276 I am not sure that this is right though.
12278 2002-04-14 Duncan Mak <duncan@ximian.com>
12280 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12281 Binary.Operator.Division case.
12283 2002-04-13 Ravi Pratap <ravi@ximian.com>
12285 * class.cs (DefineType): Ensure that we do a proper check on
12286 attribute types and also register it with the TypeManager.
12288 (TypeContainer.Targets): The default for attribute types is
12289 AttributeTargets.All.
12291 * attribute.cs (ApplyAttributes): Registering the attribute type
12292 is done elsewhere, not when we discover we have a Usage attribute.
12294 2002-04-12 Ravi Pratap <ravi@ximian.com>
12296 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12297 and get rid of is_delegate parameter.
12299 * everywhere : update.
12301 2002-04-12 Ravi Pratap <ravi@ximian.com>
12303 * cs-parser.jay (compilation_unit): Revamp completely to use
12304 some new ideas that I got from Rhys' grammar to solve the problems
12305 with assembly level attributes.
12307 (outer_declaration): New grammar production.
12309 (attribute_sections): Add.
12311 (opt_attributes): Base on attribute_sections
12313 (namespace_declaration): Allow opt_attributes to tackle the case
12314 when we have assembly level attributes - we are clever in this
12317 * attribute.cs (ApplyAttributes): Do not worry about assembly
12318 attributes in the non-global context.
12320 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12321 instead of SetGlobalAttributes.
12323 * class.cs, rootcontext.cs : Ensure we define and generate
12324 attribute types before anything else.
12326 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12327 and flag the new error -20 for the case when the attribute type
12328 does not have valid targets specified. csc does not catch this.
12330 * ../errors/errors.txt : update for error # -20
12332 2002-04-11 Ravi Pratap <ravi@ximian.com>
12334 * support.cs (InternalParameters.ParameterModifier): Do some null
12335 checking and return sane values.
12337 * class.cs (Method.Define): If we are a PInvoke method, ensure
12338 that we are static and extern. Report error # 601
12340 * ../errors/cs0601.cs : Add test case for the above error.
12342 2002-04-07 Ravi Pratap <ravi@ximian.com>
12344 * rootcontext.cs (attribute_types): We need to keep type of
12345 all attribute types separately and emit code for them first.
12347 (RegisterAttribute) : Implement.
12349 * class.cs (DefineType): Check if the current Type is a custom
12350 attribute type and register it accordingly.
12352 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12353 adding the first attribute twice and rename to
12355 (SetGlobalAttributes): this.
12357 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12360 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12361 if we are processing global arguments. Hmm, I am unsure of this.
12363 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12365 * expression.cs: added static array of strings to avoid calling
12366 Enum.ToString () for Operator in Binary. Significant recover of
12369 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12371 * class.cs (FindMembers): Allow the Builders of the various
12372 members to be null. If they are skip them. This only happens
12373 during the PInvoke declaration.
12375 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12377 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12378 failure, so we do not keep going afterwards.
12380 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12381 wanted to pass `false' as the `is_delegate' argument. If this is
12382 the case, why not use delegate_type == null to mean `is_delegate =
12383 false' and anything else as is_delegate = true.
12385 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12387 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12388 code for the section, not the beginning of the tests.
12390 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12392 * cfold.cs: Handle operator + (Enum x, Underlying x)
12394 * expression.cs (Binary): same. Warn about errors where we have
12395 Enum/Enum in operator + as well.
12397 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12400 - added support for switch(bool)
12401 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12402 - add TableSwitchEmit() to handle table-based switch statements
12404 2002-04-05 Ravi Pratap <ravi@ximian.com>
12406 * expression.cs (Invocation.OverloadResolve): Factor out code which
12407 does parameter compatibility checking with arguments so that we can
12408 re-use the code even from Delegate.VerifyApplicability
12410 (VerifyArgumentsCompat): Move above code here.
12412 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12413 and instead make a call to the above method.
12415 2002-03-31 Ravi Pratap <ravi@ximian.com>
12417 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12418 We use it to keep track of classes which are attribute types.
12420 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12422 * delegate.cs (Delegate.Define): Correctly define the types in the
12423 presence of fixed and array parameters.
12425 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12428 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12429 include NonPublic after the first iteration.
12431 * class.cs (Indexer.CheckBase): Only check if both parents are
12434 * cs-parser.jay (accessor_body): If empty, set to null.
12436 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12437 same code path here to resolve constants names that we did have in
12438 MemberAccess.DoResolve. There is too much code duplicated here.
12440 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12442 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12444 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12447 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12448 tokens, numbers and strings.
12450 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12453 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12454 asyncronous parameters and the regular parameters.
12456 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12457 specify the target directory.
12459 * expression.cs: (This.DoResolve): Simplify
12460 (As.Emit): Optimize, do not generate IsInst if the expression is
12461 always of the given type.
12463 (Is.DoResolve): Bug fix, we were reporting both always/never for
12466 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12467 creating too many unnecessary arrays.
12469 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12471 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12472 fields instead of rolling our own initializer. Takes care of all
12473 implicit conversions, and drops unnecessary static checks/argument.
12475 2002-03-31 Dick Porter <dick@ximian.com>
12477 * driver.cs: use the GetDirectories() return values properly, and
12478 use "/" as path separator.
12480 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12482 * expression.cs (Unary): Optimize - - expr into expr.
12483 (Binary): Optimize a + (-b) into a -b.
12485 * codegen.cs (CodeGen): Made all methods static.
12487 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12491 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12492 TypeBuilder property.
12494 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12497 * tree.cs: Removed the various RecordXXXX, and replaced with a
12498 single RecordDecl. Removed all the accessor methods, and just
12499 left a single access point Type
12501 * enum.cs: Rename DefineEnum to DefineType.
12503 * decl.cs: New abstract method `DefineType' used to unify the
12504 Defines for Enumerations, Interfaces, TypeContainers and
12507 (FindType): Moved LookupInterfaceOrClass here. Moved the
12508 LookupBaseClasses method that used to live in class.cs and
12509 interface.cs here, and renamed to FindType.
12511 * delegate.cs: Implement DefineType. Take advantage of the
12512 refactored pattern for locating the parent builder without taking
12513 the parent_builder argument (which we know does not work if we are
12514 nested, and triggering a toplevel definition).
12516 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12518 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12519 accessibility of a member has changed during override and report
12522 * class.cs (Method.Define, Property.Define): Only complain on
12523 overrides if the method is private, any other accessibility is
12524 fine (and since we just checked the permission is the same, we are
12527 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12528 and elif are processed always. The other pre-processing
12529 directives are only processed if we are "taking" the path
12531 2002-03-29 Martin Baulig <martin@gnome.org>
12533 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12534 current location is not Null.
12536 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12537 a separate method so we can profile it.
12539 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12540 `span.Seconds' are just seconds, but no minutes or hours.
12541 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12543 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12545 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12546 Remove the gratuitous set of Final:
12548 // If an interface implementation, then we can set Final.
12549 if (((flags & MethodAttributes.Abstract) == 0) &&
12550 implementing.DeclaringType.IsInterface)
12551 flags |= MethodAttributes.Final;
12553 I do not know what I was smoking when I used that.
12556 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12557 step into fixing the name resolution issues for delegates and
12558 unifying the toplevel name resolution.
12560 2002-03-28 Martin Baulig <martin@gnome.org>
12562 * class.cs (Method.Emit): If we have a symbol writer, call its
12563 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12564 tell it about the current method.
12566 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12567 writer that we're going to emit the first byte of IL code for a new
12568 statement (a new source line).
12569 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12570 EmitContext.Mark() before emitting any code.
12572 * location.cs (SymbolDocument): Return null when we're Null.
12574 * statement.cs (Statement): Moved the `Location loc' variable here.
12575 (Statement.EmitBoolExpression): If we have a symbol writer, call
12576 ec.Mark() before emitting any code to tell it that we're at the
12577 beginning of a new statement.
12578 (StatementExpression): Added `Location' argument to the constructor.
12579 (Block): Added public readonly variable `StartLocation' and public
12580 variable `EndLocation'. The latter is to be set using SetEndLocation().
12581 (Block): Added constructor which takes a start and end location.
12582 (Block.SetEndLocation): New method. This sets the end location.
12583 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12584 local variables we create.
12585 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12586 each statement and do also mark the begin and end of the block.
12588 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12589 tell it the current lexer.Location, use Location.Null for the end of the
12591 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12592 current block, set its end location using SetEndLocation().
12593 (statement_expression): StatementExpression constructor now takes the
12594 lexer.Location as additional argument.
12595 (for_statement, declare_local_variables): Likewise.
12596 (declare_local_variables): When creating a new implicit block, use the
12597 new Block constructor and pass it the lexer.Location.
12599 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12601 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12602 members also on the parent interfaces recursively.
12604 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12606 * report.cs: Use new formats, since Gonzalo finished the missing
12609 * expression.cs (Binary.ResolveOperator): added missing operator|
12610 operator& and operator^ for bool/bool.
12612 * cs-parser.jay: CheckDef now takes a Location argument that is
12613 used to report errors more precisly (instead of reporting the end
12614 of a definition, we try to track something which is a lot closer
12615 to the source of the problem).
12617 * cs-tokenizer.cs: Track global token use, so we can properly flag
12618 the use of #define/#undef after the first token has been seen.
12620 Also, rename the reportXXXX to Error_DescriptiveName
12622 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12623 TypeContainer, so that Enum and Interface can use this too.
12625 * class.cs (TypeContainer.LookupInterfaceOrClass,
12626 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12627 `builder' argument. Typically this was used to pass the parent
12628 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12631 The problem is that a nested class could trigger the definition of
12632 a toplevel class, and the builder would be obviously wrong in that
12635 So we drop this argument, and we compute dynamically the
12636 TypeBuilder/ModuleBuilder (the correct information was available
12637 to us anyways from DeclSpace.Parent)
12639 * interface.cs (Interface.DefineInterface): Drop builder
12640 parameter cleanup like class.cs
12642 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12645 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12648 (Try.Emit): Propagate the returns value from the statement.
12650 (Return.Emit): Even if we are leavning
12652 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12654 * modifiers.cs: Fix the computation of MethodAttributes flags.
12656 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12658 * driver.cs: allow compilation of files that start with '/'.
12659 Add a default case when checking the argument of --target.
12661 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12663 * interface.cs: Implement the same search algorithm for types in
12664 the interface code.
12666 * delegate.cs: Do not allow multiple definition.
12668 * Recovered ChangeLog that got accidentally amputated
12670 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12672 * rootcontext.cs: Load manually enum to allow core classes to
12673 contain enumerations.
12675 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12676 Update to new static methods in TypeManager.
12678 * typemanager.cs (GetMethod, GetConstructor): Use our
12679 implementation of FindMembers to find the members, since during
12680 corlib compilation, the types are TypeBuilders and GetMethod and
12681 GetConstructor do not work.
12683 Make all methods in TypeManager static.
12685 (InitCodeHelpers): Split the functionality from
12686 the InitCodeTypes function.
12688 * driver.cs: Call InitCodeHelpers after we have populated the
12691 * cs-parser.jay (delegate_declaration): we did not used to compute
12692 the delegate name correctly for void delegates.
12694 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12696 * rootcontext.cs (RootContext): Init the interface_resolve_order
12697 and type_container_resolve_order always.
12699 (ResolveCore, BootstrapCorlib_ResolveClass,
12700 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12701 compiler when compiling with --nostdlib
12703 * class.cs (TypeContainer.DefineType): Check that our parent is
12704 not null. This test is most important when we are bootstraping
12707 * codegen.cs: Split out the symbol writing code.
12709 2002-03-25 Martin Baulig <martin@gnome.org>
12711 * driver.cs (-g): Made -g an alias for --debug.
12713 2002-03-24 Martin Baulig <martin@gnome.org>
12715 * codegen.cs (SymbolWriter): New public variable. Returns the
12716 current symbol writer.
12717 (CodeGen): Added `bool want_debugging_support' argument to the
12718 constructor. If true, tell the ModuleBuild that we want debugging
12719 support and ask it for the ISymbolWriter.
12720 (Save): If we have a symbol writer, call it's Close() method after
12721 saving the assembly.
12723 * driver.c (--debug): New command line argument to create a
12724 debugger information file.
12726 * location.cs (SymbolDocument): New public property. Returns an
12727 ISymbolDocumentWriter object for the current source file or null
12728 if we don't have a symbol writer.
12730 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12732 * driver.cs (LoadAssembly): Correctly return when all the paths
12733 have been tried and not before.
12735 * statement.cs (Switch.Emit): return the actual coverage for this
12736 statement (returns/not-returns)
12738 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12739 switch of the statement if we are the last switch section. That
12740 kills two problems: try/catch problems (we used to emit an empty
12741 nop at the end) and switch statements where all branches would
12744 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12746 * driver.cs: Add default assemblies (the equivalent to the
12747 Microsoft CSC.RSP file)
12749 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12750 also update tokens_seen and set it to false.
12752 * driver.cs: Implement --recurse for Mike.
12754 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12755 correctly splitting out the paths.
12757 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12759 * interface.cs (Interface.PopulateProperty): Instead of using
12760 `parent' as the declaration space for the set parameters, use
12763 * support.cs (InternalParameters): InternalParameters constructor
12764 takes a DeclSpace instead of a TypeContainer.
12766 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12767 types are being initialized, load the address of it before calling
12770 (New): Provide a mechanism to disable the generation of local
12771 value type temporaries when the caller will be providing us with
12772 an address to store it.
12774 (ArrayCreation.EmitDynamicInitializers): Use it.
12776 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12778 * expression.cs (Invocation.EmitArguments): Only probe for array
12779 property if there is more than one argument. Sorry about that.
12781 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12782 empty param arrays.
12784 * class.cs (Method.LabelParameters): Fix incorrect code path that
12785 prevented the `ParamArrayAttribute' from being applied to the
12788 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12790 * support.cs (ReflectionParameters): Correctly compute whether the
12791 last argument is a params array. Fixes the problem with
12794 * typemanager.cs: Make the assemblies array always be non-null
12795 (empty, but non-null)
12797 * tree.cs (RecordDecl): New function that abstracts the recording
12798 of names. This reports error 101, and provides a pointer to the
12799 previous declaration. Fixes a crash in the compiler.
12801 * cs-parser.jay (constructor_declaration): Update to new grammar,
12802 and provide a constructor_body that can be empty.
12804 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12806 * driver.cs: Add support for --resources.
12808 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12809 Make all types for the various array helper methods be integer.
12811 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12812 CheckState to ConvCast.
12814 (ConvCast): Now it takes a `checked' state argument, to avoid
12815 depending on the emit context for the conversion, and just using
12816 the resolve time setting.
12818 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12819 instead of Invocation.EmitArguments. We do not emit the original
12820 arguments, instead we emit those which have been converted to
12821 unsigned int expressions.
12823 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12825 * codegen.cs: ditto.
12827 * expression.cs (LocalVariableReference): Drop the use of the
12828 Store function that depended on the variable index.
12830 * statement.cs (VariableInfo): Drop the `Idx' property from this
12831 class, as this is not taking into account the indexes for
12832 temporaries tat we generate during the execution, getting the
12835 * class.cs: First emit class initializers, then call the parent
12838 * expression.cs (Binary): Fix opcode emision.
12839 (UnaryMutator.EmitCode): Support checked code generation
12841 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12842 matches for events for both the Static and Instance scans,
12843 pointing to the same element. Fix that.
12845 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12847 * rootcontext.cs (ResolveTree): Always set the
12848 interface_resolve_order, because nested interfaces will be calling
12851 * class.cs (GetInterfaceOrClass): Track the same resolution
12852 process used by TypeManager.LookupType. This fixes the nested
12853 type lookups in class declarations (separate path from
12856 (TypeContainer.DefineType): Also define nested interfaces.
12857 (TypeContainer.RegisterOrder): New public function used to
12858 register the order in which child interfaces need to be closed.
12860 Nested interfaces need to be closed after their parents have been
12863 * interface.cs (InterfaceAttr): Put all the logic for computing
12864 the interface attribute here.
12866 (DefineInterface): Register our interface order with the
12867 RootContext or with the TypeContainer depending on the case.
12869 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12871 * cs-parser.jay: rework foreach statement to work with the new
12872 changes to the policy on SimpleNames.
12874 * report.cs: support Stacktrace on warnings as well.
12876 * makefile: drop --unsafe and /unsafe from the compile.
12878 2002-03-13 Ravi Pratap <ravi@ximian.com>
12880 * ecore.cs (StandardConversionExists): Modify to take an Expression
12881 as the first parameter. Ensure we do null -> reference type conversion
12884 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12885 temporary Expression objects.
12887 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12889 * interface.cs: workaround bug in method overloading resolution
12890 (there is already a bugzilla bug for it).
12892 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12894 We could also solve this problem by having a separate path for
12895 performing type lookups, instead of DoResolve, we could have a
12896 ResolveType entry point, and only participating pieces of the
12897 production (simplename, deref, array) would implement this.
12899 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12900 signal SimpleName to only resolve type names and not attempt to
12901 resolve anything else.
12903 * expression.cs (Cast): Set the flag.
12905 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12907 * class.cs: Only report 108 if there is no `new' modifier.
12909 * cs-parser.jay: rework foreach statement to work with the new
12910 changes to the policy on SimpleNames.
12912 * report.cs: support Stacktrace on warnings as well.
12914 * makefile: drop --unsafe and /unsafe from the compile.
12916 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12918 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12919 lookups here, instead of doing that at parse time. This means
12920 that our grammar will not introduce `LocalVariableReferences' as
12921 expressions at this point. That solves the problem of code like
12925 static void Main ()
12929 This is only half the fix. The full fix requires parameters to
12930 also be handled in this way.
12932 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12933 makes the use more obvious of the DeclSpace. The
12934 ec.TypeContainer.TypeBuilder is now only used to pull the
12935 TypeBuilder for it.
12937 My theory is that I can get rid of the TypeBuilder completely from
12938 the EmitContext, and have typecasts where it is used (from
12939 DeclSpace to where it matters).
12941 The only pending problem is that the code that implements Aliases
12942 is on TypeContainer, and probably should go in DeclSpace.
12944 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12945 lookups here, instead of doing that at parse time. This means
12946 that our grammar will not introduce `LocalVariableReferences' as
12947 expressions at this point. That solves the problem of code like
12951 static void Main ()
12955 This is only half the fix. The full fix requires parameters to
12956 also be handled in this way.
12958 * class.cs (Property.DefineMethod): When implementing an interface
12959 method, set newslot, when implementing an abstract method, do not
12960 set the flag (before we tried never setting it, or always setting
12961 it, which is the difference).
12962 (Indexer.DefineMethod): same.
12963 (Method.DefineMethod): same.
12965 * ecore.cs: Only set the status used flag if we get back a Field.
12967 * attribute.cs: Temporary hack, so Paolo can keep working.
12969 2002-03-08 Ravi Pratap <ravi@ximian.com>
12971 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12972 the unmanaged type in the case we have a MarshalAs attribute.
12974 (Resolve): Handle the case when we are parsing the special MarshalAs
12975 attribute [we need to store the unmanaged type to use later]
12977 * typemanager.cs (marshal_as_attr_type): Built in type for the
12978 MarshalAs Attribute.
12980 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12981 on parameters and accordingly set the marshalling info.
12983 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12985 * class.cs: Optimizing slightly by removing redundant code after
12986 we switched to the `NoTypes' return value.
12987 (Property.DefineMethod): use NoTypes here too.
12989 This fixes the bug I introduced in my last batch of changes.
12991 2002-03-05 Ravi Pratap <ravi@ximian.com>
12993 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12995 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12996 Enums since those are types too.
12998 * cs-parser.jay (enum_declaration): Record enums as we parse them.
13000 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
13001 thanks to a call during the lookup process.
13003 2002-03-07 Miguel de Icaza <miguel@ximian.com>
13005 * statement.cs (Foreach): Lots of work to accomodate a particular
13006 kind of foreach statement that I had not kept in mind. It is
13007 possible to have foreachs on classes that provide a GetEnumerator
13008 method that return objects that implement the "pattern" for using
13009 a foreach, there is no need to support GetEnumerator
13012 This is needed to compile nant.
13014 * decl.cs: Only report 114 if the member is not `Finalize' and if
13015 the warning level is at least 2.
13017 * class.cs: Moved the compare function from Method to
13020 (MethodSignature.InheritableMemberSignatureCompare): Add new
13021 filter function that is used to extract inheritable methods from a
13024 (Method.Define): Use the new `inheritable_method_signature_filter'
13027 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
13030 2002-03-06 Miguel de Icaza <miguel@ximian.com>
13032 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
13034 * cs-parser.jay: Add opt_semicolon to the interface declaration.
13036 * expression.cs: Pass location information to
13037 ConvertImplicitStandard.
13039 * class.cs: Added debugging code to track return values from
13042 2002-03-05 Miguel de Icaza <miguel@ximian.com>
13044 * expression.cs (Is.DoResolve): If either side of the `is' is an
13045 interface, do not flag the warning.
13047 * ecore.cs (ImplicitReferenceConversion): We need a separate test
13050 * report.cs: Allow for --fatal to be used with --probe.
13052 * typemanager.cs (NoTypes): Move the definition for the empty Type
13055 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
13057 (TypeContainer.DefineProxy): New function used to proxy to parent
13058 implementations when implementing interfaces.
13059 (TypeContainer.ParentImplements): used to lookup if our parent
13060 implements a public function that is required by an interface.
13061 (TypeContainer.VerifyPendingMethods): Hook this up.
13063 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
13064 `modules' and `assemblies' arraylists into arrays. We only grow
13065 these are the very early start up of the program, so this improves
13066 the speedof LookupType (nicely measured).
13068 * expression.cs (MakeByteBlob): Replaced unsafe code with
13069 BitConverter, as suggested by Paolo.
13071 * cfold.cs (ConstantFold.Binary): Special case: perform constant
13072 folding of string concatenation, but if either side is a string,
13073 and the other is not, then return null, and let the runtime use
13074 the concatenation on the string plus the object (using
13075 `Object.ToString').
13077 2002-03-04 Miguel de Icaza <miguel@ximian.com>
13079 Constant Folding has been implemented now.
13081 * expression.cs (Unary.Reduce): Do not throw an exception, catch
13082 the error instead on types that are not supported in one's
13085 * constant.cs (Constant and all children): New set of functions to
13086 perform implict and explicit conversions.
13088 * ecore.cs (EnumConstant): Implement the new functions to perform
13089 conversion by proxying to the child expression.
13091 * codegen.cs: (ConstantCheckState): Constant evaluation has its
13092 own separate setting that can not be turned off from the command
13093 line using --unchecked or --checked and is only controlled using
13094 the checked/unchecked statements and expressions. This setting is
13095 used by the constant folder to flag errors.
13097 * expression.cs (CheckedExpr, UncheckedExpr): Set the
13098 ConstantCheckState as well.
13100 During Resolve, they also have to flag the state, because the
13101 constant folder runs completely in the Resolve phase.
13103 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
13106 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13108 * cfold.cs: New file, this file contains the constant folder.
13110 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
13111 argument to track whether we are using the resulting address to
13112 load or store a value and provide better error messages.
13114 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
13115 new AddressOf arguments.
13117 * statement.cs (Foreach.EmitCollectionForeach): Update
13119 * expression.cs (Argument.Emit): Call AddressOf with proper
13120 arguments to track usage.
13122 (New.DoEmit): Call AddressOf with new arguments.
13124 (Unary.Emit): Adjust AddressOf call.
13126 2002-03-01 Ravi Pratap <ravi@ximian.com>
13128 * cs-parser.jay (member_access): Change the case for pre-defined types
13129 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
13132 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
13135 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
13136 essentially like methods and apply attributes like MethodImplOptions to them too.
13138 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
13141 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
13142 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
13145 * Update code everywhere accordingly.
13147 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
13149 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
13151 2002-02-28 Ravi Pratap <ravi@ximian.com>
13153 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
13154 try performing lookups against those instead of jumping straight into using
13155 the 'using' clauses.
13157 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
13159 (LookupType): Perform lookups in implicit parents too.
13161 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
13162 sequence as RootContext.LookupType.
13164 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
13165 the various cases of namespace lookups into this method.
13167 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13169 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
13170 in positional arguments)
13172 * class.cs (Operator): Update the AllowedModifiers to contain
13175 * cs-parser.jay: Update operator declaration to allow for the
13176 operator body to be empty.
13178 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
13181 2002-02-27 Miguel de Icaza <miguel@ximian.com>
13183 * class.cs (Method.Emit): Label parameters.
13185 * driver.cs: Return 1 or 0 as the program exit code.
13187 2002-02-26 Miguel de Icaza <miguel@ximian.com>
13189 * expression.cs: Special case the `null' object when trying to
13190 auto-compute the type, as anything can be explicitly converted to
13193 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
13194 spotting this Paolo.
13196 (Expression.ImplicitNumericConversion): Perform comparissions of
13197 the type using the underlying type in the case of an enumeration
13198 rather than using the enumeration type for the compare.
13200 Cope with the underlying == type case, which is not possible to
13203 (Expression.ConvertNumericExplicit): Perform comparissions of
13204 the type using the underlying type in the case of an enumeration
13205 rather than using the enumeration type for the compare.
13207 * driver.cs: If the user does not supply an extension, assume .exe
13209 * cs-parser.jay (if_statement): Rewrote so that we can track the
13210 location for the if statement.
13212 * expression.cs (Binary.ConstantFold): Only concat strings when
13213 the operation is "+", not everything ;-)
13215 * statement.cs (Statement.EmitBoolExpression): Take a location
13217 (If, While, Do): Track location.
13219 * expression.cs (Binary.ResolveOperator): In the object + string
13220 case, I was missing a call to ConvertImplicit
13222 2002-02-25 Ravi Pratap <ravi@ximian.com>
13224 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
13225 Location arguments. Ensure we use RootContext.LookupType to do our work
13226 and not try to do a direct Type.GetType and ModuleBuilder.GetType
13228 * interface.cs (PopulateMethod): Handle the type of the parameter being
13231 * expression.cs (Invocation.BetterFunction): Handle the case when we
13232 have a params method with no fixed arguments and a call is made with no
13235 2002-02-25 Miguel de Icaza <miguel@ximian.com>
13237 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
13238 the verbatim-string-literal
13240 * support.cs (InternalParameters.ParameterModifier): handle null
13242 (InternalParameters.ParameterType): ditto.
13244 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
13245 duplicating the name of the variable parameter.
13246 (GetParameterByName): Fix bug where we were not looking up array
13247 paramters if they were the only present (thanks Paolo!).
13248 (GetParameterInfo): We only have an empty set of types if both
13249 fixed and array are set to null.
13250 (GetParameterInfo-idx): Handle FixedParameter == null
13252 * cs-parser.jay: Handle the case where there is no catch
13253 statements (missing null test).
13255 2002-02-22 Miguel de Icaza <miguel@ximian.com>
13257 * driver.cs (MainDriver): Be conservative on our command line
13260 Catch DirectoryNotFoundException when calling GetFiles.
13262 (SplitPathAndPattern): Used to split the input specification into
13263 a path and a pattern that we can feed to Directory.GetFiles.
13265 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13267 * statement.cs (Fixed): Implement the last case of the Fixed
13268 statement (string handling).
13270 * expression.cs (StringPtr): New class used to return a char * to
13271 a string; Used by the Fixed statement.
13273 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13275 * expression.cs (Binary.ResolveOperator): Remove redundant
13276 MemberLookup pn parent type.
13277 Optimize union call, we do not need a union if the types are the same.
13278 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13281 Specialize the use of MemberLookup everywhere, instead of using
13282 the default settings.
13284 (StackAlloc): Implement stackalloc keyword.
13286 * cs-parser.jay: Add rule to parse stackalloc.
13288 * driver.cs: Handle /h, /help, /?
13290 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13291 before we supported unsafe code.
13293 * makefile: add --unsafe to the self compilation of mcs.
13295 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13297 * expression.cs (PointerArithmetic): New class that is used to
13298 perform pointer arithmetic.
13299 (Binary.Resolve): Handle pointer arithmetic
13300 Handle pointer comparission.
13301 (ArrayPtr): Utility expression class that is used to take the
13302 address of an array.
13304 (ElementAccess): Implement array access for pointers
13306 * statement.cs (Fixed): Implement fixed statement for arrays, we
13307 are missing one more case before we are done.
13309 * expression.cs (Indirection): Implement EmitAssign and set the
13310 ExprClass to Variable. This allows pointer dereferences to be
13311 treated as variables, and to have values assigned to them.
13313 * ecore.cs (Expression.StoreFromPtr): New utility function to
13314 store values dereferencing.
13316 2002-02-20 Ravi Pratap <ravi@ximian.com>
13318 * expression.cs (Binary.ResolveOperator): Ensure that we are
13319 not trying to operate on a void type - this fixes the reported
13322 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13323 the parent implementation is sealed.
13325 * ../errors/cs0239.cs : Add.
13327 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13329 * typemanager.cs (unverifiable_code_type): Corresponds to
13330 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13331 which have unsafe code in them.
13333 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13336 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13338 * cs-tokenizer.cs: Add support for @"litreal strings"
13340 Make tokenizer accept pre-processor directives
13341 on any column (remove the old C-like limitation).
13343 * rootcontext.cs (EmitCode): Emit any global attributes.
13344 (AddGlobalAttributes): Used to keep track of assembly attributes.
13346 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13348 * cs-parser.jay: Add support for global attributes.
13350 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13352 * expression.cs (Indirection): New helper class. Unary will
13353 create Indirection classes to be able to implement the
13354 IMemoryLocation interface on it.
13356 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13358 * cs-parser.jay (fixed_statement): reference the right statement.
13360 * statement.cs (Fixed.Emit): Finish implementing the fixed
13361 statement for the &x case.
13363 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13365 * class.cs (Property.Define, Method.Define): Remove newslot when
13368 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13369 wrong. NewSlot should only be used if the `new' keyword is present.
13371 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13372 locating our system dir. Sorry about this.
13374 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13376 * driver.cs (GetSystemDir): Compute correctly the location of our
13377 system assemblies. I was using the compiler directory instead of
13378 the library directory.
13380 2002-02-13 Ravi Pratap <ravi@ximian.com>
13382 * expression.cs (BetterFunction): Put back in what Miguel commented out
13383 since it is the correct fix. The problem is elsewhere ;-)
13385 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13386 parameters of the parms method are themselves compatible or not !
13388 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13389 to check that a class implements an interface before saying that an implicit
13390 conversion was allowed. Use ImplementsInterface to do the checking.
13392 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13394 * class.cs (Method.Define): Track whether we are an explicit
13395 implementation or not. And only call DefineMethodOverride if we
13396 are an explicit implementation.
13398 (Property.DefineMethod): Ditto.
13400 2002-02-11 Ravi Pratap <ravi@ximian.com>
13402 * expression.cs (BetterFunction): Catch hideous bug which was
13403 preventing us from detecting ambiguous calls due to implicit casts i.e
13406 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13408 * support.cs (Pair): Remove un-needed method. I figured why I was
13409 getting the error in cs-parser.jay, the variable in a foreach loop
13410 is readonly, and the compiler does not really treat this as a variable.
13412 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13413 instead of EQUALS in grammar.
13415 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13417 * expression.cs (Unary.DoResolve): Check whether the argument is
13420 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13422 * support.cs: Api for Pair to set a value. Despite the fact that
13423 the variables are public the MS C# compiler refuses to compile
13424 code that accesses the field if the variable is part of a foreach
13427 * statement.cs (Fixed): Begin implementation of the fixed
13430 (Block.AddVariable): Return the VariableInfo on success and null
13431 on failure instead of true/false.
13433 * cs-parser.jay (foreach): Catch errors on variables already
13434 defined (we were ignoring this value before) and properly unwind
13435 the block hierarchy
13437 (fixed_statement): grammar for the fixed statement.
13439 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13441 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13442 pointer types to be incretemented.
13444 (SizeOf): Implement.
13446 * cs-parser.jay (pointer_member_access): Implement
13447 expr->IDENTIFIER production.
13449 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13450 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13453 (Unary): Implement indirection.
13455 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13456 use in non-unsafe context).
13458 (SimpleName.DoResolve): Check for pointers in field access on safe
13461 (Expression.LoadFromPtr): Factor the load-indirect code in this
13462 function. This was duplicated in UnboxCast and ParameterReference
13464 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13466 * expression.cs (ComposedCast): report an error if a pointer cast
13467 is used in a safe region.
13469 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13470 pointer type casts in unsafe context.
13472 * codegen.cs (EmitContext): Set up IsUnsafe.
13474 * cs-parser.jay (non_expression_type): Add productions for pointer
13477 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13478 code. We should not use force into static mode if the method is
13479 not virtual. Fixes bug in MIS
13481 * statement.cs (Do.Emit, While.Emit, For.Emit,
13482 Statement.EmitBoolExpression): Add support to Do and While to
13483 propagate infinite loop as `I do return' semantics.
13485 Improve the For case to also test for boolean constants.
13487 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13488 to the list of attributes we can add.
13490 Remove `EmitContext' argument.
13492 * class.cs (Method.Define): Apply parameter attributes.
13493 (Constructor.Define): Apply parameter attributes.
13494 (MethodCore.LabelParameters): Move here the core of labeling
13497 * support.cs (ReflectionParameters.ParameterModifier,
13498 InternalParameters.ParameterModifier): Use IsByRef on the type and
13499 only return the OUT bit for these parameters instead of in/out/ref
13502 This is because I miss-understood things. The ParameterInfo.IsIn
13503 and IsOut represent whether the parameter has the [In] and [Out]
13506 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13508 * ecore.cs (FieldExpr.Emit): Release temporaries.
13510 * assign.cs (LocalTemporary.Release): new function.
13512 * codegen.cs (EmitContext.GetTemporaryStorage,
13513 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13514 temporary storage. Now we can "put back" localbuilders when we
13517 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13519 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13520 need to make a copy of the variable to generate verifiable code.
13522 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13524 * driver.cs: Compute dynamically the system directory.
13526 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13527 Slower, but more generally useful. Used by the abstract
13528 registering implementation.
13530 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13531 the rules for the special rule on Type/instances. First check if
13532 we have the same name, and if so, try that special static path
13533 rather than the instance path.
13535 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13537 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13540 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13541 Enum, ValueType, Delegate or Array for non-corlib compiles.
13543 * cs-tokenizer.cs: Catch long identifiers (645)
13545 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13548 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13549 fix, we were returning too early, so we were not registering
13550 pending methods from abstract classes.
13552 Do not register pending methods if the class is abstract.
13554 * expression.cs (Conditional.DoResolve): Report circular implicit
13555 conversions when we neecd to compute it for conditional
13558 (Is.DoResolve): If the expression is always of the provided type,
13559 flag warning 183. If the expression can not ever be of the
13560 provided type flag warning 184.
13562 * class.cs: Catch 169 as well.
13564 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13567 2002-01-18 Nick Drochak <ndrochak@gol.com>
13569 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13571 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13573 * interface.cs: (PopulateMethod): Check for pointers being defined
13574 only if the unsafe context is active.
13575 (PopulateProperty): ditto.
13576 (PopulateIndexer): ditto.
13578 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13579 specified. If pointers are present, make sure that they are
13580 present in an unsafe context.
13581 (Constructor, Constructor.Define): ditto.
13582 (Field, Field.Define): ditto.
13583 (Property, Property.Define): ditto.
13584 (Event, Event.Define): ditto.
13586 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13587 hashtable if there are classes or structs defined.
13589 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13590 code, as the constant resolution moved.
13592 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13593 the metadata, so we can flag error 133.
13595 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13596 pointer is being declared in an unsafe context.
13598 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13600 * modifiers.cs (Modifiers.Check): Require a Location argument.
13601 Report error 227 for Unsafe use.
13603 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13605 * statement.cs (For.Emit): If the test is null, then report that
13606 we do `return', as we wont reach anything afterwards.
13608 (Switch.SwitchGoverningType): Track the expression that matched
13611 * driver.cs: Allow negative numbers as an error code to flag.
13613 * cs-parser.jay: Handle 1551.
13615 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13617 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13619 * cs-parser.jay: Report 1518 (type declaration can only contain
13620 class, struct, interface, enum or delegate)
13622 (switch_label): Report 1523 (keywords `case' or `default' must
13625 (opt_switch_sections): Report 1522 (empty switch)
13627 * driver.cs: Report 1515 (response file specified multiple times)
13628 Report 1516 (Source file specified multiple times).
13630 * expression.cs (Argument.Resolve): Signal 1510
13632 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13633 access not allowed in static code)
13635 2002-01-11 Ravi Pratap <ravi@ximian.com>
13637 * typemanager.cs (IsPointerType): Utility method which we are going
13640 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13641 the object type, so we take care of that.
13643 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13645 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13646 added to non-params parameters :-)
13648 * typemanager.cs (CSharpName): Include 'void' type too.
13650 (void_ptr_type): Include in the set of core types.
13652 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13655 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13658 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13659 completely forgotten about it.
13661 2002-01-10 Ravi Pratap <ravi@ximian.com>
13663 * cs-parser.jay (pointer_type): Add. This begins our implementation
13664 of parsing rules for unsafe code.
13666 (unsafe_statement): Implement.
13668 (embedded_statement): Modify to include the above.
13670 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13672 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13673 if the current context is an unsafe one.
13675 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13676 are handled differently, we need separate rules for them.
13678 (local_variable_declaration): Update to use local_variable_pointer_type
13679 to allow variable declarations of unmanaged pointer types.
13681 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13682 in unsafe contexts.
13684 * ../errors/cs0214.cs : Add.
13686 2002-01-16 Nick Drochak <ndrochak@gol.com>
13688 * makefile: remove 'response' file when cleaning.
13690 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13692 * cs-parser.jay: Report 1524.
13694 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13696 * typemanager.cs (RegisterMethod): drop checking if we have
13697 registered this from here
13699 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13701 * class.cs (Method.EmitDestructor): Implement calling our base
13704 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13705 value of InFinally.
13707 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13708 this routine and will wrap the call in a try/catch block. Deal
13711 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13713 * ecore.cs (Expression.MemberLookup): instead of taking a
13714 parameter `same_type' that was used to tell whether we could
13715 access private members we compute our containing type from the
13718 (FieldExpr): Added partial support for volatile fields. This does
13719 not work for volatile fields exposed from assemblies, as I can not
13720 figure out how to extract the modreq from it.
13722 Updated all the source files to use this.
13724 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13725 because it is referenced by MemberLookup very often.
13727 2002-01-09 Ravi Pratap <ravi@ximian.com>
13729 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13730 TypeBuilder.GetCustomAttributes to retrieve what we need.
13732 Get rid of redundant default_member_attr_type as this is the same as
13733 default_member_type which already exists.
13735 * interface.cs, attribute.cs : Update accordingly.
13737 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13739 * typemanager.cs: Enable IndexerPropertyName again. It does not
13740 work for TYpeBuilders though. Ravi, can you please fix this?
13742 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13744 * expression.cs (Argument.Emit): Handle the case of ref objects
13745 being passed to ref functions;
13747 (ParameterReference.EmitLoad): Loads the content of the pointer
13748 without dereferencing.
13750 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13752 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13754 2002-01-08 Ravi Pratap <ravi@ximian.com>
13756 * class.cs (Indexer.DefineMethod): Incorporate the interface
13757 type in the name of the method if we are doing explicit interface
13760 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13762 (BetterConversion): Fix extremely trivial bug where we were referring to
13763 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13766 * ../errors/bug16.cs : Add although we have fixed it.
13768 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13770 * expression.cs (BaseIndexer): Begin implementation.
13772 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13774 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13775 production directly to remove a shift/reduce, and implement
13776 explicit interface implementation.
13778 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13779 after a floating point suffix.
13781 * expression.cs (DoNumericPromotions): Improved the conversion for
13782 uint/uint. If we have a constant, we avoid doing a typecast to a
13785 * class.cs (Indexer): Implement explicit interface implementation
13788 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13790 * class.cs: make the default instance constructor public and hidebysig.
13792 2001-01-03 Ravi Pratap <ravi@ximian.com>
13794 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13795 so we can call it from elsewhere.
13797 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13798 we emit it internally if the class has a defined indexer; otherwise the user
13799 emits it by decorating the class definition with the DefaultMemberAttribute.
13801 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13802 attribute is not used on a type which defines an indexer.
13804 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13805 character when we skip whitespace.
13807 * ../errors/cs0646.cs : Add.
13809 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13811 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13814 * makefile: Add practical target `mcs3.exe' which builds the third
13815 generation compiler.
13817 * expression.cs (New): Fix structures constructor calling.
13819 * class.cs (Property, Method, Indexer): Emit Final flag on the
13820 method if we are an interface implementation and we are not
13823 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13824 whether this property is referencing a `base' method.
13826 * expression.cs (Invocation.EmitCall): take an extra argument:
13827 is_base, this is used to determine whether the `call' or
13828 `callvirt' opcode should be used.
13831 * delegate.cs: update EmitCall.
13833 * class.cs (Method.Define): Set NewSlot for the cases where we are
13834 not implementing an interface method.
13836 (Property.Define): ditto.
13838 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13840 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13841 'r'. Allows mcs to parse itself fully.
13843 2002-01-02 Ravi Pratap <ravi@ximian.com>
13845 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13846 of the number of initializers that require the InitializeArray method.
13848 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13849 update the above field where necessary.
13851 (MakeByteBlob): Update accordingly.
13853 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13856 (EmitDynamicInitializers): Update in accordance with the new optimization.
13858 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13859 same OpCode applies.
13861 * cs-parser.jay : Fix some glaring errors I introduced.
13863 2002-01-01 Ravi Pratap <ravi@ximian.com>
13865 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13866 so that we can check for name clashes there too.
13868 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13869 for interface indexers.
13871 * interfaces.cs (Define): Emit the default member attribute.
13873 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13874 variable was being referred to while setting the value ;-)
13876 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13878 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13879 byte-by-byte information when we know the data is zero.
13881 Make the block always a multiple of 4, because
13882 DefineInitializedData has a bug.
13884 * assign.cs: Fix, we should assign from the temporary, not from
13887 * expression.cs (MakeByteBlob): Fix my incorrect code.
13889 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13891 * typemanager.cs (EnumToUnderlying): This function is used to get
13892 the underlying type from an enumeration, because it does not
13895 * constant.cs: Use the I4_S form for values between -128 and 127.
13897 * statement.cs (Block.LookupLabel): Looks up a label.
13898 (Block): Drop support for labeled blocks.
13900 (LabeledStatement): New kind of statement that represents a label
13903 (Goto): Finally implement this bad boy.
13905 * cs-parser.jay: Update to reflect new mechanism to implement
13908 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13910 * codegen.cs (EmitContext.This): a codegen property that keeps the
13911 a single instance of this instead of creating many different this
13914 * delegate.cs (Delegate.DoResolve): Update to use the property;
13916 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13918 * expression.cs (BaseAccess.DoResolve): Ditto.
13920 2001-12-29 Ravi Pratap <ravi@ximian.com>
13922 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13923 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13925 (InitCoreTypes): Update accordingly.
13927 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13928 so we can quickly store the state.
13930 (ApplyAttributes): Set the correct implementation flags
13931 for InternalCall methods.
13933 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13935 * expression.cs (EmitCall): if a method is not virtual, then do
13936 not use callvirt on it.
13938 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13939 user defined stuff) requires the use of stobj, which takes an
13940 address on the stack instead of an array and an index. So emit
13941 the Ldelema operation for it.
13943 (EmitStoreOpcode): Use stobj for valuetypes.
13945 (UnaryMutator.EmitCode): Use the right 1 value depending on
13946 whether we are dealing with int64/uint64, float or doubles.
13948 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13949 constructors that I implemented last night.
13951 (Constructor.IsDefault): Fix to work properly for static
13954 * cs-parser.jay (CheckDef): report method signature errors.
13955 Update error number 103 to be 132.
13957 * decl.cs: New AdditionResult enumeration value: MethodExists.
13958 Although we do this check for methods later on in the semantic
13959 analysis, catching repeated default constructors is so easy that
13960 we catch these here.
13962 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13965 (ParameterReference.EmitAssign, Emit): handle
13968 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13969 (ArrayAccess.EmitStoreOpcode): ditto.
13971 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13973 * expression.cs (MakeByteBlob): Complete all the missing types
13974 (uint, short, ushort, byte, sbyte)
13976 * class.cs: Only init instance field initializers on instance
13979 Rename `constructors' to instance_constructors.
13981 (TypeContainer.AddConstructor): Only add constructors to the list
13982 if it is not static.
13984 Make sure that we handle default_static_constructor independently
13985 everywhere where we handle instance_constructors
13987 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13989 * class.cs: Do not lookup or create a base initializer for a
13990 static constructor.
13992 (ConstructorInitializer.Resolve): use the proper type to lookup
13995 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13997 * enum.cs, interface.cs: Remove CloseType, this is taken care by
14000 * decl.cs: CloseType is now an virtual method, the default
14001 implementation just closes this type.
14003 2001-12-28 Ravi Pratap <ravi@ximian.com>
14005 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
14006 to PreserveSig by default. Also emit HideBySig on such methods.
14008 Basically, set the defaults to standard values.
14010 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
14011 argument, if candidate is better, it can't be worse than the best !
14013 (Invocation): Re-write bits to differentiate between methods being
14014 applicable in their expanded form and their normal form - for params
14017 Get rid of use_standard everywhere as only standard conversions are allowed
14018 in overload resolution.
14020 More spec conformance.
14022 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14024 * driver.cs: Add --timestamp, to see where the compiler spends
14027 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
14028 `this' in static code.
14030 (SimpleName.DoResolve): Implement in terms of a helper function
14031 that allows static-references to be passed upstream to
14034 (Expression.ResolveWithSimpleName): Resolve specially simple
14035 names when called by MemberAccess to implement the special
14038 (Expression.ImplicitReferenceConversion): Handle conversions from
14039 Null to reference types before others, as Null's type is
14042 * expression.cs (Invocation.EmitCall): Handle the special case of
14043 calling methods declared on a reference type from a ValueType
14044 (Base classes System.Object and System.Enum)
14046 (MemberAccess.Resolve): Only perform lookups on Enumerations if
14047 the left hand side is a TypeExpr, not on every enumeration.
14049 (Binary.Resolve): If types are reference types, then do a cast to
14050 object on operators != and == of both arguments.
14052 * typemanager.cs (FindMembers): Extract instance and static
14053 members if requested.
14055 * interface.cs (PopulateProperty): Use void_type instead of null
14056 as the return type for the setter method.
14058 (PopulateIndexer): ditto.
14060 2001-12-27 Ravi Pratap <ravi@ximian.com>
14062 * support.cs (ReflectionParameters): Fix minor bug where we
14063 were examining the wrong parameter for the ParamArray attribute.
14065 Cope with requests for the type of the parameter at position
14066 greater than the params parameter's. We now return the element
14067 type of the params array as that makes more sense.
14069 * expression.cs (Invocation.IsParamsMethodApplicable): Update
14070 accordingly as we no longer have to extract the element type
14073 (Invocation.OverloadResolve): Update.
14075 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14077 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
14078 against IEnumerator, test whether the return value is a descendant
14079 of the IEnumerator interface.
14081 * class.cs (Indexer.Define): Use an auxiliary method to implement
14082 the other bits of the method definition. Begin support for
14083 explicit interface implementation.
14085 (Property.DefineMethod): Use TypeManager.void_type instead of null
14086 for an empty return value.
14088 2001-12-26 Miguel de Icaza <miguel@ximian.com>
14090 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
14091 dealing with a FieldExpr which is composed of a FieldBuilder, in
14092 the code path we did extract the constant, but we should have
14093 obtained the underlying value to be able to cast it (otherwise we
14094 end up in an infinite loop, this is what Ravi was running into).
14096 (ArrayCreation.UpdateIndices): Arrays might be empty.
14098 (MemberAccess.ResolveMemberAccess): Add support for section
14099 14.5.4.1 that deals with the special case of E.I when E is a type
14100 and something else, that I can be a reference to a static member.
14102 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
14103 handle a particular array type to create byte blobs, it is just
14104 something we dont generate byteblobs for.
14106 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
14109 * location.cs (Push): remove the key from the hashtable that we
14110 are about to add. This happens for empty files.
14112 * driver.cs: Dispose files after we have parsed them.
14114 (tokenize): new function that only runs the tokenizer on its
14115 input, for speed testing.
14117 2001-12-26 Ravi Pratap <ravi@ximian.com>
14119 * class.cs (Event.Define): Define the private field only if there
14120 are no accessors defined.
14122 * expression.cs (ResolveMemberAccess): If there is no associated
14123 field with the event, that means we have an event defined with its
14124 own accessors and we should flag error cs0070 since transforming
14125 ourselves into a field is not valid in that case.
14127 * ecore.cs (SimpleName.DoResolve): Same as above.
14129 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
14130 and charset to sane values.
14132 2001-12-25 Ravi Pratap <ravi@ximian.com>
14134 * assign.cs (DoResolve): Perform check on events only if they
14135 are being accessed outside the declaring type.
14137 * cs-parser.jay (event_declarations): Update rules to correctly
14138 set the type of the implicit parameter etc.
14140 (add_accessor, remove_accessor): Set current local parameters.
14142 * expression.cs (Binary): For delegate addition and subtraction,
14143 cast the return value from the method into the appropriate delegate
14146 2001-12-24 Ravi Pratap <ravi@ximian.com>
14148 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
14149 of these as the workaround is unnecessary.
14151 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
14152 delegate data - none of that is needed at all.
14154 Re-write bits to extract the instance expression and the delegate method
14157 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
14160 * attribute.cs (ApplyAttributes): New method to take care of common tasks
14161 of attaching attributes instead of duplicating code everywhere.
14163 * everywhere : Update code to do attribute emission using the above method.
14165 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14167 * expression.cs (IsParamsMethodApplicable): if there are not
14168 parameters, return immediately.
14170 * ecore.cs: The 0 literal can be implicity converted to an enum
14173 (SimpleName.DoResolve): First lookup the type, then lookup the
14176 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
14177 want to get its address. If the InstanceExpression is not
14178 addressable, store the result in a temporary variable, then get
14181 * codegen.cs: Only display 219 errors on warning level or above.
14183 * expression.cs (ArrayAccess): Make it implement the
14184 IMemoryLocation interface.
14186 (Binary.DoResolve): handle the operator == (object a, object b)
14187 and operator != (object a, object b) without incurring into a
14188 BoxedCast (because 5 != o should never be performed).
14190 Handle binary enumerator operators.
14192 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
14193 value type, otherwise use Ldelem_ref.
14195 Use precomputed names;
14197 (AddressOf): Implement address of
14199 * cs-parser.jay (labeled_statement): Fix recursive block
14200 addition by reworking the production.
14202 * expression.cs (New.DoEmit): New has a special case:
14204 If we are dealing with a ValueType, we have a few
14205 situations to deal with:
14207 * The target of New is a ValueType variable, that is
14208 easy, we just pass this as the variable reference
14210 * The target of New is being passed as an argument,
14211 to a boxing operation or a function that takes a
14214 In this case, we need to create a temporary variable
14215 that is the argument of New.
14218 2001-12-23 Ravi Pratap <ravi@ximian.com>
14220 * rootcontext.cs (LookupType): Check that current_type is not null before
14221 going about looking at nested types.
14223 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
14224 not implement the IAssignMethod interface any more.
14226 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
14227 where we tranform them into FieldExprs if they are being resolved from within
14228 the declaring type.
14230 * ecore.cs (SimpleName.DoResolve): Do the same here.
14232 * assign.cs (DoResolve, Emit): Clean up code considerably.
14234 * ../errors/bug10.cs : Add.
14236 * ../errors/cs0070.cs : Add.
14238 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
14240 * assign.cs : Get rid of EventIsLocal everywhere.
14242 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14244 * ecore.cs (ConvertIntLiteral): finished the implementation.
14246 * statement.cs (SwitchLabel): Convert the value we are using as a
14247 key before looking up the table.
14249 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14251 * codegen.cs (EmitTopBlock): Require a Location argument now.
14253 * cs-parser.jay (constructor_declarator): We need to setup
14254 current_local_parameters before we parse the
14255 opt_constructor_initializer, to allow the variables to be bound
14256 to the constructor arguments.
14258 * rootcontext.cs (LookupType): First lookup nested classes in our
14259 class and our parents before we go looking outside our class.
14261 * expression.cs (ConstantFold): Extract/debox the values at the
14264 * rootcontext.cs (EmitCode): Resolve the constants first before we
14265 resolve the types. This is not really needed, but it helps debugging.
14267 * statement.cs: report location.
14269 * cs-parser.jay: pass location to throw statement.
14271 * driver.cs: Small bug fix.
14273 * report.cs: Updated format to be 4-zero filled digits.
14275 2001-12-22 Ravi Pratap <ravi@ximian.com>
14277 * expression.cs (CheckIndices): Fix minor bug where the wrong
14278 variable was being referred to ;-)
14280 (DoEmit): Do not call EmitStaticInitializers when the
14281 underlying type is System.Object.
14283 2001-12-21 Ravi Pratap <ravi@ximian.com>
14285 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14286 and do the usual workaround for SRE.
14288 * class.cs (MyEventBuilder.EventType): New member to get at the type
14289 of the event, quickly.
14291 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14293 * assign.cs (Assign.DoResolve): Handle the case when the target
14294 is an EventExpr and perform the necessary checks.
14296 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14299 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14301 (EventExpr): Set the type in the constructor itself since we
14302 are meant to be born fully resolved.
14304 (EventExpr.Define): Revert code I wrote earlier.
14306 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14307 instance expression is null. The instance expression is a This in that case
14308 or a null, depending on whether it is a static method or not.
14310 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14311 refers to more than one method.
14313 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14314 and accordingly flag errors.
14316 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14318 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14320 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14322 * location.cs (ToString): Provide useful rutine.
14324 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14326 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14327 objects, return the actual integral boxed.
14329 * statement.cs (SwitchLabel): define an ILLabel for each
14332 (Switch.CheckSwitch): If the value is a Literal, extract
14333 the underlying literal.
14335 Also in the unused hashtable we had, add the SwitchLabel so we can
14336 quickly look this value up.
14338 * constant.cs: Implement a bunch of new constants. Rewrite
14339 Literal based on this. Made changes everywhere to adapt to this.
14341 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14342 dereferencing array only once, and also copes with enumrations.
14344 bytes are two bytes wide, not one.
14346 (Cast): Perform constant conversions.
14348 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14349 wrappers to the literals here.
14351 * expression.cs (DoNumericPromotions): long literals can converted
14352 to ulong implicity (this is taken care of elsewhere, but I was
14353 missing this spot).
14355 * ecore.cs (Expression.Literalize): Make the return type Literal,
14356 to improve type checking.
14358 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14360 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14362 * literal.cs: Revert code from ravi that checked the bounds. The
14363 bounds are sane by the definition of the type itself.
14365 * typemanager.cs: Fix implementation of ImplementsInterface. We
14366 need to actually look up in our parent hierarchy for interfaces
14369 * const.cs: Use the underlying type for enumerations
14371 * delegate.cs: Compute the basename for the delegate creation,
14372 that should fix the delegate test case, and restore the correct
14373 Type Lookup semantics in rootcontext
14375 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14376 referencing a nested type with the Reflection API is using the "+"
14379 * cs-parser.jay: Do not require EOF token at the end.
14381 2001-12-20 Ravi Pratap <ravi@ximian.com>
14383 * rootcontext.cs (LookupType): Concatenate type names with
14384 a '.' instead of a '+' The test suite passes again.
14386 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14387 field of the enumeration.
14389 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14390 the case when the member is an EventExpr.
14392 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14393 static has an associated instance expression.
14395 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14397 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14399 * class.cs (Event.Define): Register event and perform appropriate checks
14402 We define the Add and Remove methods even if the use provides none because
14403 in that case, we provide default implementations ourselves.
14405 Define a private field of the type of the event. This is done by the CSC compiler
14406 and we should be doing it too ;-)
14408 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14409 More methods we use in code we generate.
14411 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14414 (InitCoreTypes): Update accordingly for the above.
14416 * class.cs (Event.Emit): Generate code for default accessors that we provide
14418 (EmitDefaultMethod): Do the job in the above.
14420 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14423 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14425 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14426 builders even if we were missing one.
14428 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14429 pass the Basename as our class name instead of the Name. The
14430 basename will be correctly composed for us.
14432 * parameter.cs (Paramters): Now takes a Location argument.
14434 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14435 make all the code call directly LookupType in RootContext and take
14436 this chance to pass the Location information everywhere.
14438 * Everywhere: pass Location information.
14440 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14442 * class.cs (Constructor.Define): Updated way of detecting the
14443 length of the parameters.
14445 (TypeContainer.DefineType): Use basename as the type name for
14448 (TypeContainer.Define): Do not recursively define types here, as
14449 definition is taken care in order by the RootContext.
14451 * tree.cs: Keep track of namespaces in a per-file basis.
14453 * parameter.cs (Parameter.ComputeSignature): Update to use
14456 (Parameters.GetSignature): ditto.
14458 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14459 instead of a TypeContainer.
14461 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14462 resolve names. Because we need to be resolve in our context, not
14465 * driver.cs: Implement response files.
14467 * class.cs (TypeContainer.DefineType): If we are defined, do not
14468 redefine ourselves.
14470 (Event.Emit): Emit the code for add/remove handlers.
14471 (Event.Define): Save the MethodBuilders for add/remove.
14473 * typemanager.cs: Use pair here too.
14475 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14476 DictionaryEntry requires the first argument to be non-null.
14478 (enum_declaration): Compute full name for registering the
14481 (delegate_declaration): Instead of using
14482 formal_parameter_list, use opt_formal_parameter_list as the list
14485 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14486 (EventParsing): New property that controls whether `add' and
14487 `remove' are returned as tokens or identifiers (for events);
14489 2001-12-19 Ravi Pratap <ravi@ximian.com>
14491 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14492 use MyEventBuilder only and let it wrap the real builder for us.
14494 (MyEventBuilder): Revamp constructor etc.
14496 Implement all operations that we perform on EventBuilder in precisely the same
14499 (FindMembers): Update to use the EventBuilder member.
14501 (Event.Emit): Update accordingly.
14503 2001-12-18 Ravi Pratap <ravi@ximian.com>
14505 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14506 by calling the appropriate methods.
14508 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14511 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14513 2001-12-17 Ravi Pratap <ravi@ximian.com>
14515 * delegate.cs (Delegate.Populate): Check that the return type
14516 and various parameters types are indeed accessible.
14518 * class.cs (Constructor.Define): Same here.
14520 (Field.Define): Ditto.
14522 (Event.Define): Ditto.
14524 (Operator.Define): Check that the underlying Method defined itself
14525 correctly - so it's MethodBuilder should not be null.
14527 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14528 expression happens to be null.
14530 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14531 members but as of now we don't seem to be able to do anything really useful with it.
14533 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14534 not the EventBuilder.
14536 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14538 * cs-tokenizer.cs: Add support for defines.
14539 Add support for #if, #elif, #else, #endif
14541 (eval_var): evaluates a variable.
14542 (eval): stubbed for evaluating functions.
14544 * cs-parser.jay: Pass the defines information
14546 * driver.cs: Add --define command line option.
14548 * decl.cs: Move MemberCore here.
14550 Make it the base class for DeclSpace. This allows us to catch and
14551 report 108 and 109 for everything now.
14553 * class.cs (TypeContainer.Define): Extract all the members
14554 before populating and emit the warning 108 (new keyword required
14555 to override) instead of having each member implement this.
14557 (MemberCore.Define): New abstract method, we will be using this in
14558 the warning reporting engine in Populate.
14560 (Operator.Define): Adjust to new MemberCore protocol.
14562 * const.cs (Const): This does not derive from Expression, it is a
14563 temporary object we use to create fields, it is a MemberCore.
14565 * class.cs (Method.Define): Allow the entry point to be in a
14568 * driver.cs: Rewrite the argument handler to clean it up a bit.
14570 * rootcontext.cs: Made it just an auxiliary namespace feature by
14571 making everything static.
14573 * driver.cs: Adapt code to use RootContext type name instead of
14576 * delegate.cs: Remove RootContext argument.
14578 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14581 * class.cs (Event.Define): The lookup can fail.
14583 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14585 * expression.cs: Resolve the this instance before invoking the code.
14587 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14589 * cs-parser.jay: Add a production in element_access that allows
14590 the thing to become a "type" reference. This way we can parse
14591 things like "(string [])" as a type.
14593 Note that this still does not handle the more complex rules of
14597 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14599 * ecore.cs: (CopyNewMethods): new utility function used to
14600 assemble the list of methods from running FindMembers.
14602 (MemberLookup): Rework FindMembers so that
14604 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14606 * class.cs (TypeContainer): Remove Delegates who fail to be
14609 * delegate.cs (Populate): Verify that we dont get null return
14610 values. TODO: Check for AsAccessible.
14612 * cs-parser.jay: Use basename to emit error 574 (destructor should
14613 have the same name as container class), not the full name.
14615 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14616 possible representation.
14618 Also implements integer type suffixes U and L.
14620 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14622 * expression.cs (ArrayCreation.DoResolve): We need to do the
14623 argument resolution *always*.
14625 * decl.cs: Make this hold the namespace. Hold the root context as
14627 (LookupType): Move here.
14629 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14631 * location.cs (Row, Name): Fixed the code, it was always returning
14632 references to the first file.
14634 * interface.cs: Register properties defined through interfaces.
14636 * driver.cs: Add support for globbing on the command line
14638 * class.cs (Field): Make it derive from MemberCore as well.
14641 2001-12-15 Ravi Pratap <ravi@ximian.com>
14643 * class.cs (Event::Define): Check that the type of the event is a delegate
14644 type else flag error #66.
14646 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14649 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14650 values of EntryPoint, CharSet etc etc.
14652 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14654 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14655 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14656 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14657 which needs this to do its work.
14659 * ../errors/cs0066.cs : Add.
14661 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14663 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14666 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14667 clears out the parameters field.
14668 (MemberSignatureCompare): Cleanup
14670 (MemberCore): New base class used to share code between MethodCore
14673 (RegisterRequiredImplementations) BindingFlags.Public requires
14674 either BindingFlags.Instace or Static. Use instance here.
14676 (Property): Refactored code to cope better with the full spec.
14678 * parameter.cs (GetParameterInfo): Return an empty array instead
14681 * class.cs (Property): Abstract or extern properties have no bodies.
14683 * parameter.cs (GetParameterInfo): return a zero-sized array.
14685 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14686 method modifier validation to the typecontainer so we can reuse
14687 this on properties.
14689 (MethodCore.ParameterTypes): return an empty sized array of types.
14691 (Property.Define): Test property modifier validity.
14693 Add tests for sealed/override too.
14695 (Method.Emit): abstract or extern methods have no bodies.
14697 2001-12-14 Ravi Pratap <ravi@ximian.com>
14699 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14702 (Method::Define, ::Emit): Modify accordingly.
14704 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14706 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14708 * makefile: Pass in /unsafe.
14710 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14712 * class.cs (MakeKey): Kill routine.
14714 * class.cs (TypeContainer.Define): Correctly define explicit
14715 method implementations (they require the full interface name plus
14718 * typemanager.cs: Deply the PtrHashtable here and stop using the
14719 lame keys. Things work so much better.
14721 This of course broke everyone who depended on `RegisterMethod' to
14722 do the `test for existance' test. This has to be done elsewhere.
14724 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14725 the object stupid Equals method (because, that like fails all over
14726 the place). We still do not use it.
14728 * class.cs (TypeContainer.SetRequiredInterface,
14729 TypeContainer.RequireMethods): Killed these two routines and moved
14730 all the functionality to RegisterRequiredImplementations.
14732 (TypeContainer.RegisterRequiredImplementations): This routine now
14733 registers all the implementations required in an array for the
14734 interfaces and abstract methods. We use an array of structures
14735 which can be computed ahead of time to reduce memory usage and we
14736 also assume that lookups are cheap as most classes will not
14737 implement too many interfaces.
14739 We also avoid creating too many MethodSignatures.
14741 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14742 clear the "pending" bit if we find that there are problems with
14745 (TypeContainer.VerifyPendingMethods): Update to report errors of
14746 methods that look like implementations but are not.
14748 (TypeContainer.Define): Add support for explicit interface method
14751 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14753 * typemanager.cs: Keep track of the parameters here instead of
14754 being a feature of the TypeContainer.
14756 * class.cs: Drop the registration of parameters here, as
14757 InterfaceMethods are also interface declarations.
14759 * delegate.cs: Register methods with the TypeManager not only with
14760 the TypeContainer. This code was buggy.
14762 * interface.cs: Full registation here.
14764 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14766 * expression.cs: Remove reducer for binary expressions, it can not
14769 * const.cs: Put here the code that used to go into constant.cs
14771 * constant.cs: Put here the code for constants, this is a new base
14772 class for Literals.
14774 * literal.cs: Make Literal derive from Constant.
14776 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14778 * statement.cs (Return.Emit): Report error 157 if the user
14779 attempts to return from a finally block.
14781 (Return.Emit): Instead of emitting a return, jump to the end of
14784 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14785 LocalBuilder to store the result of the function. ReturnLabel is
14786 the target where we jump.
14789 2001-12-09 Radek Doulik <rodo@ximian.com>
14791 * cs-parser.jay: remember alias in current namespace
14793 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14796 * class.cs (LookupAlias): lookup alias in my_namespace
14798 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14800 (LookupAlias): lookup alias in this and if needed in parent
14803 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14807 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14808 making things static. I need this to avoid passing the
14809 TypeContainer when calling ParameterType.
14811 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14812 that did string manipulation to compute the type and then call
14813 GetType. Use Parameter.ParameterType instead.
14815 * cs-tokenizer.cs: Consume the suffix for floating values.
14817 * expression.cs (ParameterReference): figure out whether this is a
14818 reference parameter or not. Kill an extra variable by computing
14819 the arg_idx during emission.
14821 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14822 function that returns whether a parameter is an out/ref value or not.
14824 (Parameter.ParameterType): The type of the parameter (base,
14825 without ref/out applied).
14827 (Parameter.Resolve): Perform resolution here.
14828 (Parameter.ExternalType): The full type (with ref/out applied).
14830 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14831 support for expressions on the using statement.
14833 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14835 * statement.cs (Using.EmitLocalVariableDecls): Split the
14836 localvariable handling of the using statement.
14838 (Block.EmitMeta): Keep track of variable count across blocks. We
14839 were reusing slots on separate branches of blocks.
14841 (Try.Emit): Emit the general code block, we were not emitting it.
14843 Check the type of the declaration to be an IDisposable or
14844 something that can be implicity converted to it.
14846 Emit conversions if required.
14848 * ecore.cs (EmptyExpression): New utility class.
14849 (Expression.ImplicitConversionExists): New utility function.
14851 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14853 * statement.cs (Using): Implement.
14855 * expression.cs (LocalVariableReference): Support read only variables.
14857 * statement.cs: Remove the explicit emit for the Leave opcode.
14858 (VariableInfo): Add a readonly field.
14860 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14862 * ecore.cs (ConvCast): new class used to encapsulate the various
14863 explicit integer conversions that works in both checked and
14864 unchecked contexts.
14866 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14867 properly generate the overflow opcodes.
14869 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14871 * statement.cs: The correct type for the EmptyExpression is the
14872 element_type, not the variable type. Ravi pointed this out.
14874 2001-12-04 Ravi Pratap <ravi@ximian.com>
14876 * class.cs (Method::Define): Handle PInvoke methods specially
14877 by using DefinePInvokeMethod instead of the usual one.
14879 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14880 above to do the task of extracting information and defining the method.
14882 2001-12-04 Ravi Pratap <ravi@ximian.com>
14884 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14885 of the condition for string type.
14887 (Emit): Move that here.
14889 (ArrayCreation::CheckIndices): Keep string literals in their expression
14892 (EmitDynamicInitializers): Handle strings appropriately.
14894 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14896 * codegen.cs (EmitContext): Replace multiple variables with a
14897 single pointer to the current Switch statement.
14899 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14902 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14906 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14909 (Foreach.Emit): Foreach on arrays was not setting
14910 up the loop variables (for break/continue).
14912 (GotoCase): Semi-implented.
14914 2001-12-03 Ravi Pratap <ravi@ximian.com>
14916 * attribute.cs (CheckAttribute): Handle system attributes by using
14917 Attribute.GetAttributes to examine information we need.
14919 (GetValidPlaces): Same here.
14921 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14923 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14925 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14927 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14929 (Method::Emit): Handle the case when we are a PInvoke method.
14931 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14933 * expression.cs: Use ResolveWithSimpleName on compound names.
14935 2001-12-02 Ravi Pratap <ravi@ximian.com>
14937 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14938 before trying to reduce it.
14940 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14942 * constant.cs (LookupConstantValue): Implement.
14944 (EmitConstant): Use the above in emitting the constant.
14946 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14947 that are user-defined by doing a LookupConstantValue on them.
14949 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14952 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14954 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14956 (BaseAccess.DoResolve): Implement.
14958 (MemberAccess.DoResolve): Split this routine into a
14959 ResolveMemberAccess routine that can be used independently
14961 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14963 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14964 As that share bits of the implementation. Is returns a boolean,
14965 while As returns the Type that is being probed.
14967 2001-12-01 Ravi Pratap <ravi@ximian.com>
14969 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14970 instead of a Literal - much easier.
14972 (EnumInTransit): Remove - utterly useless :-)
14974 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14976 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14978 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14979 chain when we have no associated expression.
14981 2001-11-30 Ravi Pratap <ravi@ximian.com>
14983 * constant.cs (Define): Use Location while reporting the errror.
14985 Also emit a warning when 'new' is used and there is no inherited
14988 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14991 (LookupEnumValue): Implement to lookup an enum member's value and define it
14994 (Populate): Re-write accordingly to use the above routine.
14996 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14998 * expression.cs (This): Fix prototype for DoResolveLValue to
14999 override the base class DoResolveLValue.
15001 * cs-parser.cs: Report errors cs574 and cs575 (destructor
15004 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
15005 (we need to load the address of the field here). This fixes
15008 (FieldExpr.DoResolveLValue): Call the DoResolve
15009 function to initialize the Instance expression.
15011 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
15012 correctly the GetEnumerator operation on a value type.
15014 * cs-parser.jay: Add more simple parsing error catches.
15016 * statement.cs (Switch): Add support for string switches.
15017 Handle null specially.
15019 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
15021 2001-11-28 Ravi Pratap <ravi@ximian.com>
15023 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
15025 (declare_local_constant): New helper function.
15027 * statement.cs (AddConstant): Keep a separate record of constants
15029 (IsConstant): Implement to determine if a variable is a constant.
15031 (GetConstantExpression): Implement.
15033 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
15035 * statement.cs (IsVariableDefined): Re-write.
15037 2001-11-27 Ravi Pratap <ravi@ximian.com>
15039 * class.cs (TypeContainer::FindMembers): Look for constants
15040 in the case when we are looking for MemberTypes.Field
15042 * expression.cs (MemberAccess::DoResolve): Check that in the
15043 case we are a FieldExpr and a Literal, we are not being accessed
15044 by an instance reference.
15046 * cs-parser.jay (local_constant_declaration): Implement.
15048 (declaration_statement): Implement for constant declarations.
15050 2001-11-26 Miguel de Icaza <miguel@ximian.com>
15052 * statement.cs (Switch): Catch double defaults.
15054 (Switch): More work on the switch() statement
15055 implementation. It works for integral values now, need to finish
15059 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15061 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
15062 integer literals into other integer literals. To be used by
15065 2001-11-24 Ravi Pratap <ravi@ximian.com>
15067 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
15070 (EmitDynamicInitializers): Cope with the above since we extract data
15071 directly from ArrayData now.
15073 (ExpectInitializers): Keep track of whether initializers are mandatory
15076 (Bounds): Make it a hashtable to prevent the same dimension being
15077 recorded for every element in that dimension.
15079 (EmitDynamicInitializers): Fix bug which prevented the Set array method
15082 Also fix bug which was causing the indices to be emitted in the reverse
15085 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15087 * expression.cs (ArrayCreation): Implement the bits that Ravi left
15088 unfinished. They do not work, because the underlying code is
15091 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15093 * cs-parser.jay: Remove bogus fixme.
15095 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
15096 on Switch statement.
15098 2001-11-23 Ravi Pratap <ravi@ximian.com>
15100 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
15103 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
15104 parameter. Apparently, any expression is allowed.
15106 (ValidateInitializers): Update accordingly.
15108 (CheckIndices): Fix some tricky bugs thanks to recursion.
15110 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
15111 I was being completely brain-dead.
15113 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
15114 and re-write acordingly.
15116 (DelegateInvocation): Re-write accordingly.
15118 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
15120 (MakeByteBlob): Handle types more correctly.
15122 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
15123 initialization from expressions but it is incomplete because I am a complete
15126 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15128 * statement.cs (If.Emit): Fix a bug that generated incorrect code
15129 on If. Basically, we have to return `true' (ie, we do return to
15130 our caller) only if both branches of the if return.
15132 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
15133 short-circuit operators, handle them as short circuit operators.
15135 (Cast.DoResolve): Resolve type.
15136 (Cast.Cast): Take an expression as the target type.
15138 * cs-parser.jay (cast_expression): Remove old hack that only
15139 allowed a limited set of types to be handled. Now we take a
15140 unary_expression and we resolve to a type during semantic
15143 Use the grammar productions from Rhys to handle casts (this is
15144 not complete like Rhys syntax yet, we fail to handle that corner
15145 case that C# has regarding (-x), but we will get there.
15147 2001-11-22 Ravi Pratap <ravi@ximian.com>
15149 * class.cs (EmitFieldInitializer): Take care of the case when we have a
15150 field which is an array type.
15152 * cs-parser.jay (declare_local_variables): Support array initialization too.
15154 * typemanager.cs (MakeKey): Implement.
15156 (everywhere): Use the above appropriately.
15158 * cs-parser.jay (for_statement): Update for array initialization while
15159 declaring variables.
15161 * ecore.cs : The error message was correct, it's the variable's names that
15162 were misleading ;-) Make the code more readable.
15164 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
15165 the correct type etc.
15167 (ConvertExplicit): Handle Enum types by examining the underlying type.
15169 2001-11-21 Ravi Pratap <ravi@ximian.com>
15171 * parameter.cs (GetCallingConvention): Always return
15172 CallingConventions.Standard for now.
15174 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15176 * expression.cs (Binary.ResolveOperator): Update the values of `l'
15177 and `r' after calling DoNumericPromotions.
15179 * ecore.cs: Fix error message (the types were in the wrong order).
15181 * statement.cs (Foreach.ProbeCollectionType): Need to pass
15182 BindingFlags.Instance as well
15184 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
15185 implicit int literal conversion in an empty cast so that we
15186 propagate the right type upstream.
15188 (UnboxCast): new class used to unbox value types.
15189 (Expression.ConvertExplicit): Add explicit type conversions done
15192 (Expression.ImplicitNumericConversion): Oops, forgot to test for
15193 the target type before applying the implicit LongLiterals to ULong
15196 2001-11-21 Miguel de Icaza <miguel@ximian.com>
15198 * cs-parser.jay (for_statement): Reworked the way For works: now
15199 we declare manually any variables that are introduced in
15200 for_initializer to solve the problem of having out-of-band code
15201 emition (that is what got for broken).
15203 (declaration_statement): Perform the actual variable declaration
15204 that used to be done in local_variable_declaration here.
15206 (local_variable_declaration): Do not declare anything, just pass
15207 the information on a DictionaryEntry
15209 2001-11-20 Ravi Pratap <ravi@ximian.com>
15211 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
15212 re-write of the logic to now make it recursive.
15214 (UpdateIndices): Re-write accordingly.
15216 Store element data in a separate ArrayData list in the above methods.
15218 (MakeByteBlob): Implement to dump the array data into a byte array.
15220 2001-11-19 Ravi Pratap <ravi@ximian.com>
15222 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
15225 * constant.cs (Define): Implement.
15227 (EmitConstant): Re-write fully.
15229 Pass in location info.
15231 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
15234 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
15235 DictionaryEntry since we need location info too.
15237 (constant_declaration): Update accordingly.
15239 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
15240 code into another method : UpdateIndices.
15242 2001-11-18 Ravi Pratap <ravi@ximian.com>
15244 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
15245 some type checking etc.
15247 2001-11-17 Ravi Pratap <ravi@ximian.com>
15249 * expression.cs (ArrayCreation::ValidateInitializers): Implement
15250 bits to provide dimension info if the user skips doing that.
15252 Update second constructor to store the rank correctly.
15254 2001-11-16 Ravi Pratap <ravi@ximian.com>
15256 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
15257 and try to implement.
15259 * ../errors/cs0150.cs : Add.
15261 * ../errors/cs0178.cs : Add.
15263 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15265 * statement.cs: Implement foreach on multi-dimensional arrays.
15267 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15268 name of the params argument.
15270 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15271 initializing the array.
15273 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15274 we can use this elsewhere.
15276 * statement.cs: Finish implementation of foreach for single
15279 * cs-parser.jay: Use an out-of-band stack to pass information
15280 around, I wonder why I need this.
15282 foreach_block: Make the new foreach_block the current_block.
15284 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15285 function used to return a static Parameters structure. Used for
15286 empty parameters, as those are created very frequently.
15288 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15290 2001-11-15 Ravi Pratap <ravi@ximian.com>
15292 * interface.cs : Default modifier is private, not public. The
15293 make verify test passes again.
15295 2001-11-15 Ravi Pratap <ravi@ximian.com>
15297 * support.cs (ReflectionParameters): Fix logic to determine
15298 whether the last parameter is a params one. Test 9 passes again.
15300 * delegate.cs (Populate): Register the builders we define with
15301 RegisterParameterForBuilder. Test 19 passes again.
15303 * cs-parser.jay (property_declaration): Reference $6 instead
15304 of $$ to get at the location.
15306 (indexer_declaration): Similar stuff.
15308 (attribute): Ditto.
15310 * class.cs (Property): Register parameters for the Get and Set methods
15311 if they exist. Test 23 passes again.
15313 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15314 call to EmitArguments as we are sure there aren't any params arguments.
15315 Test 32 passes again.
15317 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15318 IndexOutOfRangeException.
15320 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15321 Test 33 now passes again.
15323 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15325 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15326 broke a bunch of things. Will have to come up with a better way
15327 of tracking locations.
15329 * statement.cs: Implemented foreach for single dimension arrays.
15331 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15333 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15334 an error. This removes the lookup from the critical path.
15336 * cs-parser.jay: Removed use of temporary_loc, which is completely
15339 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15341 * support.cs (ReflectionParameters.ParameterModifier): Report
15342 whether the argument is a PARAMS argument or not.
15344 * class.cs: Set the attribute `ParamArrayAttribute' on the
15345 parameter argument.
15347 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15348 and cons_param_array_attribute (ConstructorInfo for
15349 ParamArrayAttribute).,
15351 * codegen.cs: Emit the return using the `Return' statement, that
15352 way we can report the error correctly for missing return values.
15354 * class.cs (Method.Emit): Clean up.
15356 * expression.cs (Argument.Resolve): Take another argument: the
15357 location where this argument is used. Notice that this is not
15358 part of the "Argument" class as to reduce the size of the
15359 structure (we know the approximate location anyways).
15361 Test if the argument is a variable-reference, if not, then
15362 complain with a 206.
15364 (Argument.Emit): Emit addresses of variables.
15366 (Argument.FullDesc): Simplify.
15368 (Invocation.DoResolve): Update for Argument.Resolve.
15370 (ElementAccess.DoResolve): ditto.
15372 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15373 method should be virtual, as this method is always virtual.
15375 (NewDelegate.DoResolve): Update for Argument.Resolve.
15377 * class.cs (ConstructorInitializer.DoResolve): ditto.
15379 * attribute.cs (Attribute.Resolve): ditto.
15381 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15383 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15385 * expression.cs (ParameterReference): Drop IStackStorage and implement
15386 IAssignMethod instead.
15388 (LocalVariableReference): ditto.
15390 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15391 IAssignMethod instead.
15393 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15395 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15396 enumerations that are used in heavily used structures derive from
15397 byte in a laughable and pathetic attempt to reduce memory usage.
15398 This is the kind of pre-optimzations that you should not do at
15399 home without adult supervision.
15401 * expression.cs (UnaryMutator): New class, used to handle ++ and
15402 -- separatedly from the other unary operators. Cleans up the
15403 code, and kills the ExpressionStatement dependency in Unary.
15405 (Unary): Removed `method' and `Arguments' from this class, making
15406 it smaller, and moving it all to SimpleCall, so I can reuse this
15407 code in other locations and avoid creating a lot of transient data
15408 strucutres when not required.
15410 * cs-parser.jay: Adjust for new changes.
15412 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15414 * enum.cs (Enum.Populate): If there is a failure during
15417 * cs-parser.jay (opt_enum_base): we used to catch type errors
15418 here, but this is really incorrect. The type error should be
15419 catched during semantic analysis.
15421 2001-12-11 Ravi Pratap <ravi@ximian.com>
15423 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15424 current_local_parameters as expected since I, in my stupidity, had forgotten
15427 * attribute.cs (GetValidPlaces): Fix stupid bug.
15429 * class.cs (Method::Emit): Perform check on applicability of attributes.
15431 (Constructor::Emit): Ditto.
15433 (Field::Emit): Ditto.
15435 (Field.Location): Store location information.
15437 (Property, Event, Indexer, Operator): Ditto.
15439 * cs-parser.jay (field_declaration): Pass in location for each field.
15441 * ../errors/cs0592.cs : Add.
15443 2001-11-12 Ravi Pratap <ravi@ximian.com>
15445 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15447 (InitCoreTypes): Update accordingly.
15449 (RegisterAttrType, LookupAttr): Implement.
15451 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15452 info about the same.
15454 (Resolve): Update to populate the above as necessary.
15456 (Error592): Helper.
15458 (GetValidPlaces): Helper to the above.
15460 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15462 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15464 2001-11-12 Ravi Pratap <ravi@ximian.com>
15466 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15468 * ../errors/cs0617.cs : Add.
15470 2001-11-11 Ravi Pratap <ravi@ximian.com>
15472 * enum.cs (Emit): Rename to Populate to be more consistent with what
15473 we expect it to do and when exactly it is called.
15475 * class.cs, rootcontext.cs : Update accordingly.
15477 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15478 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15480 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15482 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15483 of a fieldinfo using the above, when dealing with a FieldBuilder.
15485 2001-11-10 Ravi Pratap <ravi@ximian.com>
15487 * ../errors/cs0031.cs : Add.
15489 * ../errors/cs1008.cs : Add.
15491 * ../errrors/cs0543.cs : Add.
15493 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15496 (FindMembers): Implement.
15498 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15499 enums and delegates too.
15501 (enum_types): Rename to builder_to_enum.
15503 (delegate_types): Rename to builder_to_delegate.
15505 * delegate.cs (FindMembers): Implement.
15507 2001-11-09 Ravi Pratap <ravi@ximian.com>
15509 * typemanager.cs (IsEnumType): Implement.
15511 * enum.cs (Emit): Re-write parts to account for the underlying type
15512 better and perform checking etc.
15514 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15515 of the underlying type.
15517 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15520 * enum.cs (error31): Helper to report error #31.
15522 * cs-parser.jay (enum_declaration): Store location of each member too.
15524 * enum.cs (member_to_location): New hashtable.
15526 (AddEnumMember): Update location hashtable.
15528 (Emit): Use the location of each member while reporting errors.
15530 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15532 * cs-parser.jay: A for_initializer if is a
15533 local_variable_declaration really ammount to have an implicit
15534 block with the variable declaration and no initializer for for.
15536 * statement.cs (For.Emit): Cope with null initializers.
15538 This fixes the infinite loop on for initializers.
15540 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15542 * enum.cs: More cleanup.
15544 * ecore.cs: Remove dead code.
15546 * class.cs (Property.Emit): More simplification.
15547 (Event.Emit): ditto.
15549 Reworked to have less levels of indentation.
15551 2001-11-08 Ravi Pratap <ravi@ximian.com>
15553 * class.cs (Property): Emit attributes.
15563 * enum.cs (Emit): Ditto.
15565 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15568 * class.cs (Field, Event, etc.): Move attribute generation into the
15569 Emit method everywhere.
15571 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15572 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15573 as we had no way of defining nested enums !
15575 * rootcontext.cs : Adjust code accordingly.
15577 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15579 2001-11-07 Ravi Pratap <ravi@ximian.com>
15581 * expression.cs (EvalConstantExpression): Move into ecore.cs
15583 * enum.cs (Enum): Rename some members and make them public and readonly
15584 according to our convention.
15586 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15589 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15591 (Enum::Emit): Write a simple version for now which doesn't try to compute
15592 expressions. I shall modify this to be more robust in just a while.
15594 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15596 (TypeContainer::CloseType): Create the Enum types too.
15598 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15600 * expression.cs (EvalConstantExpression): Get rid of completely.
15602 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15603 user-defined values and other cases.
15605 (IsValidEnumLiteral): Helper function.
15607 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15608 out there in the case we had a literal FieldExpr.
15610 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15612 (Literalize): Revamp a bit to take two arguments.
15614 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15616 2001-11-06 Ravi Pratap <ravi@ximian.com>
15618 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15620 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15622 (Resolve): Use the above to ensure we have proper initializers.
15624 2001-11-05 Ravi Pratap <ravi@ximian.com>
15626 * expression.cs (Expression::EvalConstantExpression): New method to
15627 evaluate constant expressions.
15629 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15631 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15633 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15636 (Binary.ResolveOperator): Handle operator != (object a, object b)
15637 and operator == (object a, object b);
15639 (Binary.DoNumericPromotions): Indicate whether the numeric
15640 promotion was possible.
15642 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15645 Made the ArrayAccess implement interface IAssignMethod instead of
15646 IStackStore as the order in which arguments are passed reflects
15649 * assign.cs: Instead of using expr.ExprClass to select the way of
15650 assinging, probe for the IStackStore/IAssignMethod interfaces.
15652 * typemanager.cs: Load InitializeArray definition.
15654 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15655 static data that can be used to initialize arrays.
15657 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15659 * expression.cs: Handle operator== and operator!= for booleans.
15661 (Conditioal.Reduce): Implement reducer for the ?: operator.
15663 (Conditional.Resolve): Implement dead code elimination.
15665 (Binary.Resolve): Catch string literals and return a new
15666 concatenated string.
15668 (Unary.Reduce): Implement reduction of unary expressions.
15670 * ecore.cs: Split out the expression core handling here.
15672 (Expression.Reduce): New method used to perform constant folding
15673 and CSE. This is needed to support constant-expressions.
15675 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15676 targets, and optimize for !x.
15678 2001-11-04 Ravi Pratap <ravi@ximian.com>
15680 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15681 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15682 set custom atttributes.
15684 * literal.cs (Literal::GetValue): New abstract method to return the actual
15685 value of the literal, cast as an object.
15687 (*Literal): Implement GetValue method.
15689 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15690 expressions to the arraylist but objects of type Argument.
15692 * class.cs (TypeContainer::Emit): Emit our attributes too.
15694 (Method::Emit, Constructor::Emit): Ditto.
15696 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15697 to be ignoring earlier.
15699 2001-11-03 Ravi Pratap <ravi@ximian.com>
15701 * attribute.cs (AttributeSection::Define): Implement to do the business
15702 of constructing a CustomAttributeBuilder.
15704 (Attribute): New trivial class. Increases readability of code.
15706 * cs-parser.jay : Update accordingly.
15708 (positional_argument_list, named_argument_list, named_argument): New rules
15710 (attribute_arguments): Use the above so that we are more correct.
15712 2001-11-02 Ravi Pratap <ravi@ximian.com>
15714 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15715 to perform all checks for a method with a params parameter.
15717 (Invocation::OverloadResolve): Update to use the above method and therefore
15718 cope correctly with params method invocations.
15720 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15723 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15724 constructors in our parent too because we can't afford to miss out on
15727 * attribute.cs (AttributeSection): New name for the class Attribute
15729 Other trivial changes to improve readability.
15731 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15732 use the new class names.
15734 2001-11-01 Ravi Pratap <ravi@ximian.com>
15736 * class.cs (Method::Define): Complete definition for params types too
15738 (Indexer::Define): Ditto.
15740 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15741 Cope everywhere with a request for info about the array parameter.
15743 2001-11-01 Ravi Pratap <ravi@ximian.com>
15745 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15747 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15748 local_variable_type to extract the string corresponding to the type.
15750 (local_variable_type): Fixup the action to use the new helper method.
15752 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15755 * expression.cs : Clean out code which uses the above.
15757 2001-10-31 Ravi Pratap <ravi@ximian.com>
15759 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15760 and bale out if necessary by returning a false.
15762 (RegisterProperty): Ditto.
15764 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15765 and print out appropriate error messages.
15767 * interface.cs (everywhere): Ditto.
15769 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15770 location to constructor.
15772 * class.cs (Property, Event, Indexer): Update accordingly.
15774 * ../errors/cs111.cs : Added.
15776 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15777 of a method, as laid down by the spec.
15779 (Invocation::OverloadResolve): Use the above method.
15781 2001-10-31 Ravi Pratap <ravi@ximian.com>
15783 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15784 now take a TypeContainer and a Parameters object.
15786 (ParameterData): Modify return type of ParameterModifier method to be
15787 Parameter.Modifier and not a string.
15789 (ReflectionParameters, InternalParameters): Update accordingly.
15791 * expression.cs (Argument::GetParameterModifier): Same here.
15793 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15794 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15795 symbol in it at all so maybe this is only for now.
15797 2001-10-30 Ravi Pratap <ravi@ximian.com>
15799 * support.cs (InternalParameters): Constructor now takes an extra argument
15800 which is the actual Parameters class.
15802 (ParameterDesc): Update to provide info on ref/out modifiers.
15804 * class.cs (everywhere): Update call to InternalParameters to pass in
15805 the second argument too.
15807 * support.cs (ParameterData): Add ParameterModifier, which is a method
15808 to return the modifier info [ref/out etc]
15810 (InternalParameters, ReflectionParameters): Implement the above.
15812 * expression.cs (Argument::ParameterModifier): Similar function to return
15813 info about the argument's modifiers.
15815 (Invocation::OverloadResolve): Update to take into account matching modifiers
15818 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15819 a new SetFormalParameters object which we pass to InternalParameters.
15821 2001-10-30 Ravi Pratap <ravi@ximian.com>
15823 * expression.cs (NewArray): Merge into the ArrayCreation class.
15825 2001-10-29 Ravi Pratap <ravi@ximian.com>
15827 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15828 NewUserdefinedArray into one as there wasn't much of a use in having
15831 * expression.cs (Argument): Change field's name to ArgType from Type.
15833 (Type): New readonly property which returns the proper type, taking into
15834 account ref/out modifiers.
15836 (everywhere): Adjust code accordingly for the above.
15838 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15839 whether we are emitting for a ref or out parameter.
15841 * expression.cs (Argument::Emit): Use the above field to set the state.
15843 (LocalVariableReference::Emit): Update to honour the flag and emit the
15846 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15848 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15850 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15852 (ReflectionParameters, InternalParameters): Implement the above method.
15854 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15857 (Invocation::FullMethodDesc): Ditto.
15859 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15861 * cs-parser.jay: Add extra production for the second form of array
15864 * expression.cs (ArrayCreation): Update to reflect the above
15867 * Small changes to prepare for Array initialization.
15869 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15871 * typemanager.cs (ImplementsInterface): interface might be null;
15872 Deal with this problem;
15874 Also, we do store negative hits on the cache (null values), so use
15875 this instead of calling t.GetInterfaces on the type everytime.
15877 2001-10-28 Ravi Pratap <ravi@ximian.com>
15879 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15881 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15882 split functionality out into different classes.
15884 (New::FormArrayType): Move into NewBuiltinArray.
15886 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15889 (NewBuiltinArray): New class to handle creation of built-in arrays.
15891 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15892 account creation of one-dimensional arrays.
15894 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15896 (NewUserdefinedArray::DoResolve): Implement.
15898 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15900 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15901 we maintain inside the TypeManager. This is necessary to perform lookups on the
15904 (LookupType): Update to perform GetType on the module builders too.
15906 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15908 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15910 2001-10-23 Ravi Pratap <ravi@ximian.com>
15912 * expression.cs (New::DoResolve): Implement guts of array creation.
15914 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15916 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15918 * expression.cs: Fix bug I introduced lsat night that broke
15921 (Expression.Resolve): Report a 246 error (can not resolve name)
15922 if we find a SimpleName in the stream.
15924 (Expression.ResolveLValue): Ditto.
15926 (Expression.ResolveWithSimpleName): This function is a variant of
15927 ResolveName, this one allows SimpleNames to be returned without a
15928 warning. The only consumer of SimpleNames is MemberAccess
15930 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15932 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15933 might arrive here. I have my doubts that this is correct.
15935 * statement.cs (Lock): Implement lock statement.
15937 * cs-parser.jay: Small fixes to support `lock' and `using'
15939 * cs-tokenizer.cs: Remove extra space
15941 * driver.cs: New flag --checked, allows to turn on integer math
15944 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15945 Threading.Monitor.Exit
15947 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15949 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15950 Expression Class to be IndexerAccess.
15952 Notice that Indexer::DoResolve sets the eclass to Value.
15954 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15956 * class.cs (TypeContainer::Emit): Emit code for indexers.
15958 * assign.cs (IAssignMethod): New interface implemented by Indexers
15959 and Properties for handling assignment.
15961 (Assign::Emit): Simplify and reuse code.
15963 * expression.cs (IndexerAccess, PropertyExpr): Implement
15964 IAssignMethod, clean up old code.
15966 2001-10-22 Ravi Pratap <ravi@ximian.com>
15968 * typemanager.cs (ImplementsInterface): New method to determine if a type
15969 implements a given interface. Provides a nice cache too.
15971 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15974 (ConvertReferenceExplicit): Ditto.
15976 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15977 various methods, with correct names etc.
15979 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15980 Operator.UnaryNegation.
15982 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15983 we have a unary plus or minus operator.
15985 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15988 * everywhere : update accordingly.
15990 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15993 * class.cs (Method::Define): For the case where we are implementing a method
15994 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15995 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15997 2001-10-21 Ravi Pratap <ravi@ximian.com>
15999 * interface.cs (FindMembers): Implement to work around S.R.E
16002 * typemanager.cs (IsInterfaceType): Implement.
16004 (FindMembers): Update to handle interface types too.
16006 * expression.cs (ImplicitReferenceConversion): Re-write bits which
16007 use IsAssignableFrom as that is not correct - it doesn't work.
16009 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
16010 and accordingly override EmitStatement.
16012 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
16013 using the correct logic :-)
16015 2001-10-19 Ravi Pratap <ravi@ximian.com>
16017 * ../errors/cs-11.cs : Add to demonstrate error -11
16019 2001-10-17 Miguel de Icaza <miguel@ximian.com>
16021 * assign.cs (Assign::Resolve): Resolve right hand side first, and
16022 then pass this as a hint to ResolveLValue.
16024 * expression.cs (FieldExpr): Add Location information
16026 (FieldExpr::LValueResolve): Report assignment to readonly
16029 (Expression::ExprClassFromMemberInfo): Pass location information.
16031 (Expression::ResolveLValue): Add new method that resolves an
16034 (Expression::DoResolveLValue): Default invocation calls
16037 (Indexers): New class used to keep track of indexers in a given
16040 (IStackStore): Renamed from LValue, as it did not really describe
16041 what this did. Also ResolveLValue is gone from this interface and
16042 now is part of Expression.
16044 (ElementAccess): Depending on the element access type
16046 * typemanager.cs: Add `indexer_name_type' as a Core type
16047 (System.Runtime.CompilerServices.IndexerNameAttribute)
16049 * statement.cs (Goto): Take a location.
16051 2001-10-18 Ravi Pratap <ravi@ximian.com>
16053 * delegate.cs (Delegate::VerifyDelegate): New method to verify
16054 if two delegates are compatible.
16056 (NewDelegate::DoResolve): Update to take care of the case when
16057 we instantiate a delegate from another delegate.
16059 * typemanager.cs (FindMembers): Don't even try to look up members
16060 of Delegate types for now.
16062 2001-10-18 Ravi Pratap <ravi@ximian.com>
16064 * delegate.cs (NewDelegate): New class to take care of delegate
16067 * expression.cs (New): Split the delegate related code out into
16068 the NewDelegate class.
16070 * delegate.cs (DelegateInvocation): New class to handle delegate
16073 * expression.cs (Invocation): Split out delegate related code into
16074 the DelegateInvocation class.
16076 2001-10-17 Ravi Pratap <ravi@ximian.com>
16078 * expression.cs (New::DoResolve): Implement delegate creation fully
16079 and according to the spec.
16081 (New::DoEmit): Update to handle delegates differently.
16083 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
16084 because of which we were printing out arguments in reverse order !
16086 * delegate.cs (VerifyMethod): Implement to check if the given method
16087 matches the delegate.
16089 (FullDelegateDesc): Implement.
16091 (VerifyApplicability): Implement.
16093 * expression.cs (Invocation::DoResolve): Update to accordingly handle
16094 delegate invocations too.
16096 (Invocation::Emit): Ditto.
16098 * ../errors/cs1593.cs : Added.
16100 * ../errors/cs1594.cs : Added.
16102 * delegate.cs (InstanceExpression, TargetMethod): New properties.
16104 2001-10-16 Ravi Pratap <ravi@ximian.com>
16106 * typemanager.cs (intptr_type): Core type for System.IntPtr
16108 (InitCoreTypes): Update for the same.
16110 (iasyncresult_type, asynccallback_type): Ditto.
16112 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
16115 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
16118 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
16119 the builders for the 4 members of a delegate type :-)
16121 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
16124 * expression.cs (New::DoResolve): Implement guts for delegate creation.
16126 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
16128 2001-10-15 Miguel de Icaza <miguel@ximian.com>
16130 * statement.cs (Break::Emit): Implement.
16131 (Continue::Emit): Implement.
16133 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
16134 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
16135 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
16136 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
16139 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
16140 properties that track the label for the current loop (begin of the
16141 loop and end of the loop).
16143 2001-10-15 Ravi Pratap <ravi@ximian.com>
16145 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
16146 use of emitting anything at all.
16148 * class.cs, rootcontext.cs : Get rid of calls to the same.
16150 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
16152 (Populate): Define the constructor correctly and set the implementation
16155 * typemanager.cs (delegate_types): New hashtable to hold delegates that
16158 (AddDelegateType): Implement.
16160 (IsDelegateType): Implement helper method.
16162 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
16164 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
16165 and accordingly handle it.
16167 * delegate.cs (Populate): Take TypeContainer argument.
16168 Implement bits to define the Invoke method. However, I still haven't figured out
16169 how to take care of the native int bit :-(
16171 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
16172 Qualify the name of the delegate, not its return type !
16174 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
16177 (StandardConversionExists): Checking for array types turns out to be recursive.
16179 (ConvertReferenceExplicit): Implement array conversion.
16181 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
16183 2001-10-12 Ravi Pratap <ravi@ximian.com>
16185 * cs-parser.jay (delegate_declaration): Store the fully qualified
16186 name as it is a type declaration.
16188 * delegate.cs (ReturnType, Name): Rename members to these. Make them
16191 (DefineDelegate): Renamed from Define. Does the same thing essentially,
16192 as TypeContainer::DefineType.
16194 (Populate): Method in which all the definition of the various methods (Invoke)
16197 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
16200 (CloseDelegate): Finally creates the delegate.
16202 * class.cs (TypeContainer::DefineType): Update to define delegates.
16203 (Populate, Emit and CloseType): Do the same thing here too.
16205 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
16206 delegates in all these operations.
16208 2001-10-14 Miguel de Icaza <miguel@ximian.com>
16210 * expression.cs: LocalTemporary: a new expression used to
16211 reference a temporary that has been created.
16213 * assign.cs: Handle PropertyAccess back here, so that we can
16214 provide the proper semantic access to properties.
16216 * expression.cs (Expression::ConvertReferenceExplicit): Implement
16217 a few more explicit conversions.
16219 * modifiers.cs: `NEW' modifier maps to HideBySig.
16221 * expression.cs (PropertyExpr): Make this into an
16222 ExpressionStatement, and support the EmitStatement code path.
16224 Perform get/set error checking, clean up the interface.
16226 * assign.cs: recognize PropertyExprs as targets, and if so, turn
16227 them into toplevel access objects.
16229 2001-10-12 Miguel de Icaza <miguel@ximian.com>
16231 * expression.cs: PropertyExpr::PropertyExpr: use work around the
16234 * typemanager.cs: Keep track here of our PropertyBuilders again to
16235 work around lameness in SRE.
16237 2001-10-11 Miguel de Icaza <miguel@ximian.com>
16239 * expression.cs (LValue::LValueResolve): New method in the
16240 interface, used to perform a second resolution pass for LValues.
16242 (This::DoResolve): Catch the use of this in static methods.
16244 (This::LValueResolve): Implement.
16246 (This::Store): Remove warning, assigning to `this' in structures
16249 (Invocation::Emit): Deal with invocation of
16250 methods on value types. We need to pass the address to structure
16251 methods rather than the object itself. (The equivalent code to
16252 emit "this" for structures leaves the entire structure on the
16253 stack instead of a pointer to it).
16255 (ParameterReference::DoResolve): Compute the real index for the
16256 argument based on whether the method takes or not a `this' pointer
16257 (ie, the method is static).
16259 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16260 value types returned from functions when we need to invoke a
16261 method on the sturcture.
16264 2001-10-11 Ravi Pratap <ravi@ximian.com>
16266 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16267 defining the type in the Modulebuilder or Typebuilder. This is to take
16268 care of nested types which need to be defined on the TypeBuilder using
16269 DefineNestedMethod.
16271 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16272 methods in RootContext, only ported to be part of TypeContainer.
16274 (TypeContainer::GetInterfaceOrClass): Ditto.
16276 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16278 * interface.cs (Interface::DefineInterface): New method. Does exactly
16279 what RootContext.CreateInterface did earlier, only it takes care of nested types
16282 (Interface::GetInterfaces): Move from RootContext here and port.
16284 (Interface::GetInterfaceByName): Same here.
16286 * rootcontext.cs (ResolveTree): Re-write.
16288 (PopulateTypes): Re-write.
16290 * class.cs (TypeContainer::Populate): Populate nested types too.
16291 (TypeContainer::Emit): Emit nested members too.
16293 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16294 instead just use the name argument passed in as it is already fully
16297 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16298 to TypeContainer mapping to see if a type is user-defined.
16300 * class.cs (TypeContainer::CloseType): Implement.
16302 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16303 the default constructor.
16305 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16308 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16310 * interface.cs (CloseType): Create the type here.
16312 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16315 Remove all the methods which are now in TypeContainer.
16317 2001-10-10 Ravi Pratap <ravi@ximian.com>
16319 * delegate.cs (Define): Re-write bits to define the delegate
16322 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16324 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16326 * expression.cs (ImplicitReferenceConversion): handle null as well
16327 as a source to convert to any reference type.
16329 * statement.cs (Return): Perform any implicit conversions to
16330 expected return type.
16332 Validate use of return statement.
16334 * codegen.cs (EmitContext): Pass the expected return type here.
16336 * class.cs (Method, Constructor, Property): Pass expected return
16337 type to EmitContext.
16339 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16341 * expression.cs: Make DoResolve take an EmitContext instead of a
16344 Replaced `l' and `location' for `loc', for consistency.
16346 (Error, Warning): Remove unneeded Tc argument.
16348 * assign.cs, literal.cs, constant.cs: Update to new calling
16351 * codegen.cs: EmitContext now contains a flag indicating whether
16352 code is being generated in a static method or not.
16354 * cs-parser.jay: DecomposeQI, new function that replaces the old
16355 QualifiedIdentifier. Now we always decompose the assembled
16356 strings from qualified_identifier productions into a group of
16359 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16361 * rootcontext.cs: Deal with field-less struct types correctly now
16362 by passing the size option to Define Type.
16364 * class.cs: Removed hack that created one static field.
16366 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16368 * statement.cs: Moved most of the code generation here.
16370 2001-10-09 Ravi Pratap <ravi@ximian.com>
16372 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16375 (ElementAccess): Remove useless bits for now - keep checks as the spec
16378 2001-10-08 Ravi Pratap <ravi@ximian.com>
16380 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16381 and start performing checks according to the spec.
16383 2001-10-07 Ravi Pratap <ravi@ximian.com>
16385 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16386 rank_specifiers instead.
16388 (rank_specifiers): Change the order in which the rank specifiers are stored
16390 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16392 * expression.cs (ElementAccess): Implement the LValue interface too.
16394 2001-10-06 Ravi Pratap <ravi@ximian.com>
16396 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16397 except that user defined conversions are not included.
16399 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16400 perform the conversion of the return type, if necessary.
16402 (New::DoResolve): Check whether we are creating an array or an object
16403 and accordingly do the needful.
16405 (New::Emit): Same here.
16407 (New::DoResolve): Implement guts of array creation.
16409 (New::FormLookupType): Helper function.
16411 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16413 * codegen.cs: Removed most of the code generation here, and move the
16414 corresponding code generation bits to the statement classes.
16416 Added support for try/catch/finalize and throw.
16418 * cs-parser.jay: Added support for try/catch/finalize.
16420 * class.cs: Catch static methods having the flags override,
16421 virtual or abstract.
16423 * expression.cs (UserCast): This user cast was not really doing
16424 what it was supposed to do. Which is to be born in fully resolved
16425 state. Parts of the resolution were being performed at Emit time!
16429 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16431 * expression.cs: Implicity convert the result from UserCast.
16433 2001-10-05 Ravi Pratap <ravi@ximian.com>
16435 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16436 prevented it from working correctly.
16438 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16439 merely ConvertImplicit.
16441 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16443 * typemanager.cs: Make the LookupTypeContainer function static,
16444 and not per-instance.
16446 * class.cs: Make static FindMembers (the one that takes a Type
16449 * codegen.cs: Add EmitForeach here.
16451 * cs-parser.jay: Make foreach a toplevel object instead of the
16452 inline expansion, as we need to perform semantic analysis on it.
16454 2001-10-05 Ravi Pratap <ravi@ximian.com>
16456 * expression.cs (Expression::ImplicitUserConversion): Rename to
16457 UserDefinedConversion.
16459 (Expression::UserDefinedConversion): Take an extra argument specifying
16460 whether we look for explicit user conversions too.
16462 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16464 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16466 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16467 with the appropriate arguments.
16469 * cs-parser.jay (cast_expression): Record location too.
16471 * expression.cs (Cast): Record location info.
16473 (Expression::ConvertExplicit): Take location argument.
16475 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16476 to determine if we are doing explicit conversions.
16478 (UserCast::Emit): Update accordingly.
16480 (Expression::ConvertExplicit): Report an error if everything fails.
16482 * ../errors/cs0030.cs : Add.
16484 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16486 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16487 virtual and newslot bits.
16489 * class.cs (TypeContainer::RegisterRequiredImplementations):
16490 Record methods we need.
16492 (TypeContainer::MakeKey): Helper function to make keys for
16493 MethodBases, since the Methodbase key is useless.
16495 (TypeContainer::Populate): Call RegisterRequiredImplementations
16496 before defining the methods.
16498 Create a mapping for method_builders_to_methods ahead of time
16499 instead of inside a tight loop.
16501 (::RequireMethods): Accept an object as the data to set into the
16502 hashtable so we can report interface vs abstract method mismatch.
16504 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16506 * report.cs: Make all of it static.
16508 * rootcontext.cs: Drop object_type and value_type computations, as
16509 we have those in the TypeManager anyways.
16511 Drop report instance variable too, now it is a global.
16513 * driver.cs: Use try/catch on command line handling.
16515 Add --probe option to debug the error reporting system with a test
16518 * report.cs: Add support for exiting program when a probe
16519 condition is reached.
16521 2001-10-03 Ravi Pratap <ravi@ximian.com>
16523 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16524 we do a forcible conversion regardless of type, to check if
16525 ForceConversion returns a null.
16527 (Binary::error19): Use location to report error.
16529 (Unary::error23): Use location here too.
16531 * ../errors/cs0019.cs : Check in.
16533 * ../errors/cs0023.cs : Check in.
16535 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16536 case of a non-null MethodInfo object with a length of 0 !
16538 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16539 an applicable member - according to the spec :-)
16540 Also fix logic to find members in base types.
16542 (Unary::ResolveOperator): Same here.
16544 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16545 as I was getting thoroughly confused between this and error19 :-)
16547 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16548 (::FindMostEncompassedType): Implement.
16549 (::FindMostEncompassingType): Implement.
16550 (::StandardConversionExists): Implement.
16552 (UserImplicitCast): Re-vamp. We now need info about most specific
16553 source and target types so that we can do the necessary conversions.
16555 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16556 mathematical union with no duplicates.
16558 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16560 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16561 in order from base classes to child classes, so that we can in
16562 child classes look up in our parent for method names and
16563 attributes (required for handling abstract, virtual, new, override
16564 constructs: we need to instrospect our base class, and if we dont
16565 populate the classes in order, the introspection might be
16566 incorrect. For example, a method could query its parent before
16567 the parent has any methods and would determine that the parent has
16568 no abstract methods (while it could have had them)).
16570 (RootContext::CreateType): Record the order in which we define the
16573 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16575 * class.cs (TypeContainer::Populate): Also method definitions can
16576 fail now, keep track of this.
16578 (TypeContainer::FindMembers): Implement support for
16579 DeclaredOnly/noDeclaredOnly flag.
16581 (Constructor::Emit) Return the ConstructorBuilder.
16583 (Method::Emit) Return the MethodBuilder.
16584 Check for abstract or virtual methods to be public.
16586 * rootcontext.cs (RootContext::CreateType): Register all the
16587 abstract methods required for the class to be complete and the
16588 interface methods that must be implemented.
16590 * cs-parser.jay: Report error 501 (method requires body if it is
16591 not marked abstract or extern).
16593 * expression.cs (TypeOf::Emit): Implement.
16595 * typemanager.cs: runtime_handle_type, new global type.
16597 * class.cs (Property::Emit): Generate code for properties.
16599 2001-10-02 Ravi Pratap <ravi@ximian.com>
16601 * expression.cs (Unary::ResolveOperator): Find operators on base type
16602 too - we now conform exactly to the spec.
16604 (Binary::ResolveOperator): Same here.
16606 * class.cs (Operator::Define): Fix minor quirk in the tests.
16608 * ../errors/cs0215.cs : Added.
16610 * ../errors/cs0556.cs : Added.
16612 * ../errors/cs0555.cs : Added.
16614 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16616 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16617 single integer which is really efficient
16619 2001-10-01 Ravi Pratap <ravi@ximian.com>
16621 * expression.cs (Expression::ImplicitUserConversion): Use location
16622 even in the case when we are examining True operators.
16624 * class.cs (Operator::Define): Perform extensive checks to conform
16625 with the rules for operator overloading in the spec.
16627 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16628 some of the other conversions mentioned in the spec.
16630 * typemanager.cs (array_type): New static member for the System.Array built-in
16633 (cloneable_interface): For System.ICloneable interface.
16635 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16636 we start resolving the tree and populating types.
16638 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16640 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16642 * expression.cs (Expression::ExprClassFromMemberInfo,
16643 Expression::Literalize): Create literal expressions from
16644 FieldInfos which are literals.
16646 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16647 type casts, because they were wrong. The test suite in tests
16650 (ImplicitNumericConversion): ushort to ulong requires a widening
16653 Int32 constant to long requires widening cast as well.
16655 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16656 for integers because the type on the stack is not i4.
16658 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16660 * expression.cs (report118): require location argument.
16662 * parameter.cs: Do not dereference potential null value.
16664 * class.cs: Catch methods that lack the `new' keyword when
16665 overriding a name. Report warnings when `new' is used without
16666 anything being there to override.
16668 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16670 * class.cs: Only add constructor to hashtable if it is non-null
16671 (as now constructors can fail on define).
16673 (TypeManager, Class, Struct): Take location arguments.
16675 Catch field instance initialization in structs as errors.
16677 accepting_filter: a new filter for FindMembers that is static so
16678 that we dont create an instance per invocation.
16680 (Constructor::Define): Catch errors where a struct constructor is
16683 * cs-parser.jay: Pass location information for various new
16686 * delegate.cs (Delegate): take a location argument.
16688 * driver.cs: Do not call EmitCode if there were problesm in the
16689 Definition of the types, as many Builders wont be there.
16691 * decl.cs (Decl::Decl): Require a location argument.
16693 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16694 into integers, and find the most appropiate integer for it.
16696 * literal.cs: Implement ULongLiteral.
16698 * rootcontext.cs: Provide better information about the location of
16699 failure when CreateType fails.
16701 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16703 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16706 * expression.cs (Binary::CheckShiftArguments): Add missing type
16708 (Binary::ResolveOperator): Add type to the logical and and logical
16709 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16712 (Binary::DoNumericPromotions): In the case where either argument
16713 is ulong (and most signed types combined with ulong cause an
16714 error) perform implicit integer constant conversions as well.
16716 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16718 * expression.cs (UserImplicitCast): Method should always be
16720 (Invocation::BetterConversion): Simplified test for IntLiteral.
16722 (Expression::ImplicitNumericConversion): Split this routine out.
16723 Put the code that performs implicit constant integer conversions
16726 (Expression::Resolve): Become a wrapper around DoResolve so we can
16727 check eclass and type being set after resolve.
16729 (Invocation::Badness): Remove this dead function
16731 (Binary::ResolveOperator): Do not compute the expensive argumnets
16732 unless we have a union for it.
16734 (Probe::Emit): Is needs to do an isinst and then
16735 compare against null.
16737 (::CanConvert): Added Location argument. If the Location argument
16738 is null (Location.Null), then we do not report errors. This is
16739 used by the `probe' mechanism of the Explicit conversion. We do
16740 not want to generate an error for something that the user
16741 explicitly requested to be casted. But the pipeline for an
16742 explicit cast first tests for potential implicit casts.
16744 So for now, if the Location is null, it means `Probe only' to
16745 avoid adding another argument. Might have to revise this
16748 (ClassCast): New class used to type cast objects into arbitrary
16749 classes (used in Explicit Reference Conversions).
16751 Implement `as' as well.
16753 Reverted all the patches from Ravi below: they were broken:
16755 * The use of `level' as a mechanism to stop recursive
16756 invocations is wrong. That was there just to catch the
16757 bug with a strack trace but not as a way of addressing
16760 To fix the problem we have to *understand* what is going
16761 on and the interactions and come up with a plan, not
16762 just get things going.
16764 * The use of the type conversion cache that I proposed
16765 last night had an open topic: How does this work across
16766 protection domains. A user defined conversion might not
16767 be public in the location where we are applying the
16768 conversion, a different conversion might be selected
16769 (ie, private A->B (better) but public B->A (worse),
16770 inside A, A->B applies, but outside it, B->A will
16773 * On top of that (ie, even if the above is solved),
16774 conversions in a cache need to be abstract. Ie, `To
16775 convert from an Int to a Short use an OpcodeCast', not
16776 `To convert from an Int to a Short use the OpcodeCast on
16777 the variable 5' (which is what this patch was doing).
16779 2001-09-28 Ravi Pratap <ravi@ximian.com>
16781 * expression.cs (Invocation::ConversionExists): Re-write to use
16782 the conversion cache
16784 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16785 cache all conversions done, not just user-defined ones.
16787 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16788 to determine if a conversion exists instead of acutually trying to
16789 perform the conversion. It's faster too.
16791 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16792 and only then attempt the implicit conversion.
16794 2001-09-28 Ravi Pratap <ravi@ximian.com>
16796 * expression.cs (ConvertImplicit): Use a cache for conversions
16797 already found. Check level of recursion and bail out if necessary.
16799 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16801 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16802 Export standard methods that we expect for string operations.
16804 * statement.cs (Block::UsageWarning): Track usage of variables and
16805 report the errors for not used variables.
16807 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16810 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16812 * codegen.cs: remove unnneded code
16814 * expression.cs: Removed BuiltinTypeAccess class
16816 Fix the order in which implicit conversions are
16819 The previous fixed dropped support for boxed conversions (adding a
16820 test to the test suite now)
16822 (UserImplicitCast::CanConvert): Remove test for source being null,
16823 that code is broken. We should not feed a null to begin with, if
16824 we do, then we should track the bug where the problem originates
16825 and not try to cover it up here.
16827 Return a resolved expression of type UserImplicitCast on success
16828 rather than true/false. Ravi: this is what I was talking about,
16829 the pattern is to use a static method as a "constructor" for
16832 Also, do not create arguments until the very last minute,
16833 otherwise we always create the arguments even for lookups that
16834 will never be performed.
16836 (UserImplicitCast::Resolve): Eliminate, objects of type
16837 UserImplicitCast are born in a fully resolved state.
16839 * typemanager.cs (InitCoreTypes): Init also value_type
16840 (System.ValueType).
16842 * expression.cs (Cast::Resolve): First resolve the child expression.
16844 (LValue): Add new method AddressOf to be used by
16847 Change the argument of Store to take an EmitContext instead of an
16848 ILGenerator, because things like FieldExpr need to be able to call
16849 their children expression to generate the instance code.
16851 (Expression::Error, Expression::Warning): Sugar functions for
16854 (Expression::MemberLookup): Accept a TypeContainer instead of a
16855 Report as the first argument.
16857 (Expression::ResolvePrimary): Killed. I still want to improve
16858 this as currently the code is just not right.
16860 (Expression::ResolveMemberAccess): Simplify, but it is still
16863 (Unary::Resolve): Catch errors in AddressOf operators.
16865 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16866 index to a byte for the short-version, or the compiler will choose
16867 the wrong Emit call, which generates the wrong data.
16869 (ParameterReference::Emit, ::Store): same.
16871 (FieldExpr::AddressOf): Implement.
16873 * typemanager.cs: TypeManager: made public variable instead of
16876 * driver.cs: document --fatal.
16878 * report.cs (ErrorMessage, WarningMessage): new names for the old
16879 Error and Warning classes.
16881 * cs-parser.jay (member_access): Turn built-in access to types
16882 into a normal simplename
16884 2001-09-27 Ravi Pratap <ravi@ximian.com>
16886 * expression.cs (Invocation::BetterConversion): Fix to cope
16887 with q being null, since this was introducing a bug.
16889 * expression.cs (ConvertImplicit): Do built-in conversions first.
16891 2001-09-27 Ravi Pratap <ravi@ximian.com>
16893 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16895 2001-09-27 Ravi Pratap <ravi@ximian.com>
16897 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16898 I had introduced long ago (what's new ?).
16900 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16901 the work of all the checking.
16902 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16903 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16905 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16906 that is the right way.
16908 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16909 overloading resolution. Use everywhere instead of cutting and pasting code.
16911 (Binary::ResolveOperator): Use MakeUnionSet.
16913 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16914 we have to convert to bool types. Not complete yet.
16916 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16918 * typemanager.cs (TypeManager::CSharpName): support ushort.
16920 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16921 to provide an expression that performsn an implicit constant int
16922 conversion (section 6.1.6).
16923 (Expression::ConvertImplicitRequired): Reworked to include
16924 implicit constant expression conversions.
16926 (Expression::ConvertNumericExplicit): Finished.
16928 (Invocation::Emit): If InstanceExpression is null, then it means
16929 that we perform a call on this.
16931 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16933 * expression.cs (Unary::Emit): Remove some dead code.
16934 (Probe): Implement Resolve and Emit for `is'.
16935 (Expression::ConvertImplicitRequired): Attempt to do constant
16936 expression conversions here. Maybe should be moved to
16937 ConvertImplicit, but I am not sure.
16938 (Expression::ImplicitLongConstantConversionPossible,
16939 Expression::ImplicitIntConstantConversionPossible): New functions
16940 that tell whether is it possible to apply an implicit constant
16941 expression conversion.
16943 (ConvertNumericExplicit): Started work on explicit numeric
16946 * cs-parser.jay: Update operator constants.
16948 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16949 (Parameters::GetSignature): Hook up VerifyArgs here.
16950 (Parameters::VerifyArgs): Verifies that no two arguments have the
16953 * class.cs (Operator): Update the operator names to reflect the
16954 ones that the spec expects (as we are just stringizing the
16957 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16958 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16959 previous usage did only work for our methods.
16960 (Expression::ConvertImplicit): Handle decimal implicit numeric
16961 conversions as well.
16962 (Expression::InternalTypeConstructor): Used to invoke constructors
16963 on internal types for default promotions.
16965 (Unary::Emit): Implement special handling for the pre/post
16966 increment/decrement for overloaded operators, as they need to have
16967 the same semantics as the other operators.
16969 (Binary::ResolveOperator): ditto.
16970 (Invocation::ConversionExists): ditto.
16971 (UserImplicitCast::Resolve): ditto.
16973 2001-09-26 Ravi Pratap <ravi@ximian.com>
16975 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16976 operator, return after emitting body. Regression tests pass again !
16978 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16979 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16980 (Invocation::OverloadResolve): Ditto.
16981 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16983 * everywhere : update calls to the above methods accordingly.
16985 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16987 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16989 * expression.cs (ExpressionStatement): New base class used for
16990 expressions that can appear in statements, so that we can provide
16991 an alternate path to generate expression that do not leave a value
16994 (Expression::Emit, and all the derivatives): We no longer return
16995 whether a value is left on the stack or not. Every expression
16996 after being emitted leaves a single value on the stack.
16998 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16999 facilties of ExpressionStatement if possible.
17001 * cs-parser.jay: Update statement_expression.
17003 2001-09-25 Miguel de Icaza <miguel@ximian.com>
17005 * driver.cs: Change the wording of message
17007 2001-09-25 Ravi Pratap <ravi@ximian.com>
17009 * expression.cs (Binary::ResolveOperator): Had forgottten to set
17010 the type of the expression to the return type of the method if
17011 we have an overloaded operator match ! The regression tests pass again !
17012 (Unary::ResolveOperator): Ditto.
17014 * expression.cs (Invocation::ConversionExists): Correct the member lookup
17015 to find "op_Implicit", not "implicit" ;-)
17016 (UserImplicitCast): New class to take care of user-defined implicit conversions.
17017 (ConvertImplicit, ForceConversion): Take TypeContainer argument
17019 * everywhere : Correct calls to the above accordingly.
17021 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
17022 (ConvertImplicit): Do user-defined conversion if it exists.
17024 2001-09-24 Miguel de Icaza <miguel@ximian.com>
17026 * assign.cs: track location.
17027 (Resolve): Use implicit conversions on assignment.
17029 * literal.cs: Oops. Not good, Emit of short access values should
17030 pass (Bytes) or the wrong argument will be selected.
17032 * expression.cs (Unary::Emit): Emit code for -expr.
17034 (Unary::ResolveOperator): Handle `Substract' for non-constants
17035 (substract from zero from the non-constants).
17036 Deal with Doubles as well.
17038 (Expression::ConvertImplicitRequired): New routine that reports an
17039 error if no implicit conversion exists.
17041 (Invocation::OverloadResolve): Store the converted implicit
17042 expressions if we make them
17044 2001-09-24 Ravi Pratap <ravi@ximian.com>
17046 * class.cs (ConstructorInitializer): Take a Location argument.
17047 (ConstructorBaseInitializer): Same here.
17048 (ConstructorThisInitializer): Same here.
17050 * cs-parser.jay : Update all calls accordingly.
17052 * expression.cs (Unary, Binary, New): Take location argument.
17053 Update accordingly everywhere.
17055 * cs-parser.jay : Update all calls to the above to take a location
17058 * class.cs : Ditto.
17060 2001-09-24 Ravi Pratap <ravi@ximian.com>
17062 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
17063 (Invocation::BetterConversion): Same here
17064 (Invocation::ConversionExists): Ditto.
17066 (Invocation::ConversionExists): Implement.
17068 2001-09-22 Ravi Pratap <ravi@ximian.com>
17070 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
17071 Also take an additional TypeContainer argument.
17073 * All over : Pass in TypeContainer as argument to OverloadResolve.
17075 * typemanager.cs (CSharpName): Update to check for the string type and return
17078 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
17081 2001-09-21 Ravi Pratap <ravi@ximian.com>
17083 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
17084 (Invocation::BetterFunction): Implement.
17085 (Invocation::BetterConversion): Implement.
17086 (Invocation::ConversionExists): Skeleton, no implementation yet.
17088 Okay, things work fine !
17090 2001-09-21 Miguel de Icaza <miguel@ximian.com>
17092 * typemanager.cs: declare and load enum_type, delegate_type and
17095 * expression.cs (Expression::Emit): Now emit returns a value that
17096 tells whether a value is left on the stack or not. This strategy
17097 might be reveted tomorrow with a mechanism that would address
17098 multiple assignments.
17099 (Expression::report118): Utility routine to report mismatches on
17102 (Unary::Report23): Report impossible type/operator combination
17105 (Unary::IsIncrementableNumber): Whether the type can be
17106 incremented or decremented with add.
17107 (Unary::ResolveOperator): Also allow enumerations to be bitwise
17109 (Unary::ResolveOperator): Implement ++, !, ~,
17111 (Invocation::Emit): Deal with new Emit convetion.
17113 * All Expression derivatives: Updated their Emit method to return
17114 whether they leave values on the stack or not.
17116 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
17117 stack for expressions that are statements.
17119 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17121 * expression.cs (LValue): New interface. Must be implemented by
17123 (LocalVariableReference, ParameterReference, FieldExpr): Implement
17126 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
17127 interface for generating code, simplifies the code.
17129 2001-09-20 Ravi Pratap <ravi@ximian.com>
17131 * expression.cs (everywhere): Comment out return statements in ::Resolve
17132 methods to avoid the warnings.
17134 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17136 * driver.cs (parse): Report error 2001 if we can not open the
17139 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
17142 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
17145 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
17146 otherwise nested blocks end up with the same index.
17148 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
17150 * expression.cs: Instead of having FIXMEs in the Resolve
17151 functions, throw exceptions so it is obvious that we are facing a
17154 * cs-parser.jay (invocation_expression): Pass Location information.
17156 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
17157 Use a basename for those routines because .NET does not like paths
17160 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
17163 2001-09-19 Miguel de Icaza <miguel@ximian.com>
17165 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
17166 are loading the correct data types (throws an exception if not).
17167 (TypeManager::InitCoreTypes): Use CoreLookupType
17169 * expression.cs (Unary::ResolveOperator): return the child
17170 expression for expressions which are just +expr.
17171 (Unary::ResolveOperator): Return negative literals for -LITERAL
17172 expressions (otherwise they are Unary {Literal}).
17173 (Invocation::Badness): Take into account `Implicit constant
17174 expression conversions'.
17176 * literal.cs (LongLiteral): Implement long literal class.
17177 (IntLiteral): export the `Value' of the intliteral.
17179 2001-09-19 Ravi Pratap <ravi@ximian.com>
17181 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
17183 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
17184 instead of 'Operator'
17186 * expression.cs (Binary::ResolveOperator): Update accordingly.
17187 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
17190 * cs-parser.jay (unary_expression): Update to use the new names.
17192 * gen-treedump.cs (GetUnary): Same here.
17194 * expression.cs (Unary::Resolve): Implement.
17195 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
17196 operators are found instead of making noise ;-)
17197 (Unary::ResolveOperator): New method to do precisely the same thing which
17198 Binary::ResolveOperator does for Binary expressions.
17199 (Unary.method, .Arguments): Add.
17200 (Unary::OperName): Implement.
17201 (Unary::ForceConversion): Copy and Paste !
17203 * class.cs (Operator::Define): Fix a small bug for the case when we have
17206 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
17207 for the inbuilt operators. Only overloading works for now ;-)
17209 2001-09-18 Miguel de Icaza <miguel@ximian.com>
17211 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
17212 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
17214 * expression.cs (This::Emit): Implement.
17215 (This::Resolve): Implement.
17216 (TypeOf:Resolve): Implement.
17217 (Expression::ResolveSimpleName): Add an implicit this to instance
17219 (MemberAccess::Resolve): Deal with Parameters and Fields.
17220 Bind instance variable to Field expressions.
17221 (FieldExpr::Instance): New field used to track the expression that
17222 represents the object instance.
17223 (FieldExpr::Resolve): Track potential errors from MemberLookup not
17225 (FieldExpr::Emit): Implement.
17227 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
17228 the last instruction contains a return opcode to avoid generating
17229 the last `ret' instruction (this generates correct code, and it is
17230 nice to pass the peverify output).
17232 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
17233 initializer for static and instance variables.
17234 (Constructor::Emit): Allow initializer to be null in the case of
17235 static constructors. Only emit initializer for instance
17238 (TypeContainer::FindMembers): Return a null array if there are no
17241 Also fix the code for the MemberTypes.Method branch, as it was not
17242 scanning that for operators (or tried to access null variables before).
17244 * assign.cs (Assign::Emit): Handle instance and static fields.
17248 * driver.cs: Stop compilation if there are parse errors.
17250 * cs-parser.jay (constructor_declaration): Provide default base
17251 initializer for non-static constructors.
17252 (constructor_declarator): Do not provide a default base
17253 initializers if none was specified.
17254 Catch the fact that constructors should not have parameters.
17256 * class.cs: Do not emit parent class initializers for static
17257 constructors, that should be flagged as an error.
17259 2001-09-18 Ravi Pratap <ravi@ximian.com>
17261 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17262 Move back code into TypeContainer::Populate.
17264 2001-09-18 Ravi Pratap <ravi@ximian.com>
17266 * class.cs (TypeContainer::AddConstructor): Fix the check to
17267 compare against Name, not Basename.
17268 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17270 * cs-parser.jay : Update accordingly.
17272 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17273 for methods, don't forget to look into the operators too.
17274 (RegisterMethodBuilder): Helper method to take care of this for
17275 methods, constructors and operators.
17276 (Operator::Define): Completely revamp.
17277 (Operator.OperatorMethod, MethodName): New fields.
17278 (TypeContainer::Populate): Move the registering of builders into
17279 RegisterMethodBuilder.
17280 (Operator::Emit): Re-write.
17282 * expression.cs (Binary::Emit): Comment out code path to emit method
17283 invocation stuff for the case when we have a user defined operator. I am
17284 just not able to get it right !
17286 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17288 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17291 (Expression::MemberLookup): Provide a version that allows to
17292 specify the MemberTypes and BindingFlags.
17294 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17295 so it was not fetching variable information from outer blocks.
17297 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17298 Beforefieldinit as it was buggy.
17300 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17301 that Ravi put here.
17303 * class.cs (Constructor::Emit): Only emit if block is not null.
17304 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17305 deal with this by semantically definining it as if the user had
17308 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17309 constructors as we now "emit" them at a higher level.
17311 (TypeContainer::DefineDefaultConstructor): Used to define the
17312 default constructors if none was provided.
17314 (ConstructorInitializer): Add methods Resolve and Emit.
17316 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17318 2001-09-17 Ravi Pratap <ravi@ximian.com>
17320 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17321 the default constructor builder with our hashtable for methodbuilders
17324 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17325 and argument_count is 0 in which case we have a match.
17326 (Binary::ResolveOperator): More null checking and miscellaneous coding
17329 2001-09-17 Ravi Pratap <ravi@ximian.com>
17331 * rootcontext.cs (IsNameSpace): Compare against null.
17333 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17335 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17336 and Unary::Operator.
17338 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17341 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17342 we have overloaded operators.
17343 (Binary::ResolveOperator): Implement the part which does the operator overload
17346 * class.cs (Operator::Emit): Implement.
17347 (TypeContainer::Emit): Emit the operators we have too.
17349 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17350 the case when we have a user-defined operator.
17352 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17354 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17356 2001-09-16 Ravi Pratap <ravi@ximian.com>
17358 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17359 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17360 (Constructor::Emit): Implement.
17361 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17362 if we have no work to do.
17363 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17366 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17367 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17369 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17372 2001-09-15 Ravi Pratap <ravi@ximian.com>
17374 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17376 (Tree::RecordNamespace): Method to do what the name says ;-)
17377 (Tree::Namespaces): Property to get at the namespaces hashtable.
17379 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17382 * rootcontext.cs (IsNamespace): Fixed it :-)
17384 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17386 * class.cs (TypeContainer::FindMembers): Add support for
17388 (MethodCore): New class that encapsulates both the shared aspects
17389 of a Constructor and a Method.
17390 (Method, Constructor): Factored pieces into MethodCore.
17392 * driver.cs: Added --fatal which makes errors throw exceptions.
17393 Load System assembly as well as part of the standard library.
17395 * report.cs: Allow throwing exceptions on errors for debugging.
17397 * modifiers.cs: Do not use `parent', instead use the real type
17398 container to evaluate permission settings.
17400 * class.cs: Put Ravi's patch back in. He is right, and we will
17401 have to cope with the
17403 2001-09-14 Ravi Pratap <ravi@ximian.com>
17405 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17406 FamORAssem, not FamANDAssem.
17408 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17410 * driver.cs: Added --parse option that only parses its input files
17413 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17414 incorrect. IsTopLevel is not used to tell whether an object is
17415 root_types or not (that can be achieved by testing this ==
17416 root_types). But to see if this is a top-level *class* (not
17417 necessarly our "toplevel" container).
17419 2001-09-14 Ravi Pratap <ravi@ximian.com>
17421 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17422 parent instead of a direct call to GetType.
17424 2001-09-14 Ravi Pratap <ravi@ximian.com>
17426 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17427 Modifiers.TypeAttr. This should just be a call to that method.
17429 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17430 object so that we can determine if we are top-level or not.
17432 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17435 * enum.cs (Enum::Define): Ditto.
17437 * modifiers.cs (FieldAttr): Re-write.
17439 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17440 (TypeContainer::HaveStaticConstructor): New property to provide access
17441 to precisely that info.
17443 * modifiers.cs (MethodAttr): Re-write.
17444 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17446 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17447 of top-level types as claimed.
17449 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17451 * expression.cs (MemberLookup): Fruitless attempt to lookup
17452 constructors. Maybe I need to emit default constructors? That
17453 might be it (currently .NET emits this for me automatically).
17454 (Invocation::OverloadResolve): Cope with Arguments == null.
17455 (Invocation::EmitArguments): new function, shared by the new
17456 constructor and us.
17457 (Invocation::Emit): Handle static and instance methods. Emit
17458 proper call instruction for virtual or non-virtual invocations.
17459 (New::Emit): Implement.
17460 (New::Resolve): Implement.
17461 (MemberAccess:Resolve): Implement.
17462 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17463 to track instances.
17464 (FieldExpr::Resolve): Set type.
17466 * support.cs: Handle empty arguments.
17468 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17469 SimpleLookup): Auxiliary routines to help parse a qualifier
17472 Update qualifier_identifier rule.
17474 * codegen.cs: Removed debugging messages.
17476 * class.cs: Make this a global thing, this acts just as a "key" to
17477 objects that we might have around.
17479 (Populate): Only initialize method_builders_to_methods once.
17481 * expression.cs (PropertyExpr): Initialize type from the
17484 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17485 Resolve pattern. Attempt to implicitly convert value to boolean.
17488 * expression.cs: Set the type for the int32/int32 argument case.
17489 (Binary::ResolveOperator): Set the return type to boolean for
17490 comparission operators
17492 * typemanager.cs: Remove debugging print code.
17494 (Invocation::Resolve): resolve type.
17496 * class.cs: Allocate a MemberInfo of the correct size, as the code
17497 elsewhere depends on the test to reflect the correct contents.
17499 (Method::) Keep track of parameters, due to System.Reflection holes
17501 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17504 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17505 of the exact size and return that.
17507 (Class::LookupMethodByBuilder): New function that maps
17508 MethodBuilders to its methods. Required to locate the information
17509 on methods because System.Reflection bit us again.
17511 * support.cs: New file, contains an interface ParameterData and
17512 two implementations: ReflectionParameters and InternalParameters
17513 used to access Parameter information. We will need to grow this
17516 * expression.cs (Invocation::GetParameterData): implement a cache
17517 and a wrapper around the ParameterData creation for methods.
17518 (Invocation::OverloadResolve): Use new code.
17520 2001-09-13 Ravi Pratap <ravi@ximian.com>
17522 * class.cs (TypeContainer::EmitField): Remove and move into
17523 (Field::Define): here and modify accordingly.
17524 (Field.FieldBuilder): New member.
17525 (TypeContainer::Populate): Update accordingly.
17526 (TypeContainer::FindMembers): Implement.
17528 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17530 * statement.cs: (VariableInfo::VariableType): New field to be
17531 initialized with the full type once it is resolved.
17533 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17535 * parameter.cs (GetParameterInfo): Use a type cache to compute
17536 things only once, and to reuse this information
17538 * expression.cs (LocalVariableReference::Emit): Implement.
17539 (OpcodeCast::Emit): fix.
17541 (ParameterReference::Resolve): Implement.
17542 (ParameterReference::Emit): Implement.
17544 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17545 that are expressions need to stay as Expressions.
17547 * typemanager.cs (CSharpName): Returns the C# name of a type if
17550 * expression.cs (Expression::ConvertImplicit): New function that
17551 implements implicit type conversions.
17553 (Expression::ImplicitReferenceConversion): Implements implicit
17554 reference conversions.
17556 (EmptyCast): New type for transparent casts.
17558 (OpcodeCast): New type for casts of types that are performed with
17559 a sequence of bytecodes.
17561 (BoxedCast): New type used for casting value types into reference
17562 types. Emits a box opcode.
17564 (Binary::DoNumericPromotions): Implements numeric promotions of
17565 and computation of the Binary::Type.
17567 (Binary::EmitBranchable): Optimization.
17569 (Binary::Emit): Implement code emission for expressions.
17571 * typemanager.cs (TypeManager): Added two new core types: sbyte
17574 2001-09-12 Ravi Pratap <ravi@ximian.com>
17576 * class.cs (TypeContainer::FindMembers): Method which does exactly
17577 what Type.FindMembers does, only we don't have to use reflection. No
17578 implementation yet.
17580 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17581 typecontainer objects as we need to get at them.
17582 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17584 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17585 typecontainer object.
17587 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17588 of just a Report object.
17590 2001-09-11 Ravi Pratap <ravi@ximian.com>
17592 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17594 (TypeContainer::Populate): Now define the delegates of the type too.
17595 (TypeContainer.Delegates): Property to access the list of delegates defined
17598 * delegates.cs (Delegate::Define): Implement partially.
17600 * modifiers.cs (TypeAttr): Handle more flags.
17602 2001-09-11 Ravi Pratap <ravi@ximian.com>
17604 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17606 (Operator::Define): Re-write logic to get types by using the LookupType method
17607 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17608 (Indexer::Define): Ditto.
17609 (Event::Define): Ditto.
17610 (Property::Define): Ditto.
17612 2001-09-10 Ravi Pratap <ravi@ximian.com>
17614 * class.cs (TypeContainer::Populate): Now define operators too.
17615 (TypeContainer.Operators): New property to access the list of operators
17617 (Operator.OperatorMethodBuilder): New member to hold the method builder
17618 for the operator we are defining.
17619 (Operator::Define): Implement.
17621 2001-09-10 Ravi Pratap <ravi@ximian.com>
17623 * class.cs (Event::Define): Make the prefixes of the accessor methods
17624 addOn_ and removeOn_
17626 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17627 of the location being passed in too. Ideally, this should go later since all
17628 error reporting should be done through the Report object.
17630 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17631 (Populate): Iterate thru the indexers we have and define them too.
17632 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17633 for the get and set accessors.
17634 (Indexer::Define): Implement.
17636 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17638 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17639 my previous implementation, did not work.
17641 * typemanager.cs: Add a couple of missing types (the longs).
17643 * literal.cs: Use TypeManager.bool_type instead of getting it.
17645 * expression.cs (EventExpr): New kind of expressions.
17646 (Expressio::ExprClassFromMemberInfo): finish
17648 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17650 * assign.cs: Emit stores to static fields differently.
17652 2001-09-08 Ravi Pratap <ravi@ximian.com>
17654 * Merge in changes and adjust code to tackle conflicts. Backed out my
17655 code in Assign::Resolve ;-)
17657 2001-09-08 Ravi Pratap <ravi@ximian.com>
17659 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17660 instead Report.Error and also pass in the location.
17661 (CSharpParser::Lexer): New readonly property to return the reference
17662 to the Tokenizer object.
17663 (declare_local_variables): Use Report.Error with location instead of plain
17667 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17668 (Operator.CheckBinaryOperator): Ditto.
17670 * cs-parser.jay (operator_declarator): Update accordingly.
17672 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17673 (CheckBinaryOperator): Same here.
17675 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17676 on the name without any prefixes of namespace names etc. This is because we
17677 already might have something already fully qualified like
17678 'System.Console.WriteLine'
17680 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17682 2001-09-07 Ravi Pratap <ravi@ximian.com>
17684 * cs-tokenizer.cs (location): Return a string which also contains
17687 * expression.cs (ElementAccess): New class for expressions of the
17688 type 'element access.'
17689 (BaseAccess): New class for expressions of the type 'base access.'
17690 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17693 * cs-parser.jay (element_access): Implement action.
17694 (base_access): Implement actions.
17695 (checked_expression, unchecked_expression): Implement.
17697 * cs-parser.jay (local_variable_type): Correct and implement.
17698 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17700 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17702 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17703 name and the specifiers.
17705 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17707 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17708 making them all public ;-)
17710 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17713 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17715 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17717 (FieldExpr, PropertyExprs): New resolved expressions.
17718 (SimpleName::MemberStaticCheck): Perform static checks for access
17719 to non-static fields on static methods. Maybe this should be
17720 generalized for MemberAccesses.
17721 (SimpleName::ResolveSimpleName): More work on simple name
17724 * cs-parser.jay (primary_expression/qualified_identifier): track
17725 the parameter index.
17727 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17728 (EmitContext::EmitBoolExpression): Chain to expression generation
17729 instead of temporary hack.
17730 (::EmitStatementExpression): Put generic expression code generation.
17732 * assign.cs (Assign::Emit): Implement variable assignments to
17733 local variables, parameters and fields.
17735 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17737 * statement.cs (Block::GetVariableInfo): New method, returns the
17738 VariableInfo for a variable name in a block.
17739 (Block::GetVariableType): Implement in terms of GetVariableInfo
17741 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17742 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17744 2001-09-06 Ravi Pratap <ravi@ximian.com>
17746 * cs-parser.jay (operator_declaration): Continue on my quest : update
17747 to take attributes argument.
17748 (event_declaration): Ditto.
17749 (enum_declaration): Ditto.
17750 (indexer_declaration): Ditto.
17752 * class.cs (Operator::Operator): Update constructor accordingly.
17753 (Event::Event): Ditto.
17755 * delegate.cs (Delegate::Delegate): Same here.
17757 * enum.cs (Enum::Enum): Same here.
17759 2001-09-05 Ravi Pratap <ravi@ximian.com>
17761 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17763 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17765 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17766 being passed around as an arraylist.
17767 (Attributes::AddAttribute): Method to add attribute sections.
17769 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17770 (struct_declaration): Update accordingly.
17771 (constant_declaration): Update.
17772 (field_declaration): Update.
17773 (method_header): Update.
17774 (fixed_parameter): Update.
17775 (parameter_array): Ditto.
17776 (property_declaration): Ditto.
17777 (destructor_declaration): Ditto.
17779 * class.cs (Struct::Struct): Update constructors accordingly.
17780 (Class::Class): Ditto.
17781 (Field::Field): Ditto.
17782 (Method::Method): Ditto.
17783 (Property::Property): Ditto.
17784 (TypeContainer::OptAttribute): update property's return type.
17786 * interface.cs (Interface.opt_attributes): New member.
17787 (Interface::Interface): Update to take the extra Attributes argument.
17789 * parameter.cs (Parameter::Parameter): Ditto.
17791 * constant.cs (Constant::Constant): Ditto.
17793 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17794 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17795 the attributes as a parameter.
17796 (InterfaceProperty): Update constructor call.
17797 (InterfaceEvent): Ditto.
17798 (InterfaceMethod): Ditto.
17799 (InterfaceIndexer): Ditto.
17801 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17802 pass the attributes too.
17803 (interface_event_declaration): Ditto.
17804 (interface_property_declaration): Ditto.
17805 (interface_method_declaration): Ditto.
17806 (interface_declaration): Ditto.
17808 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17810 * class.cs (Method::Define): Track the "static Main" definition to
17811 create an entry point.
17813 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17814 EntryPoint if we find it.
17816 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17817 (EmitContext::ig): Make this variable public.
17819 * driver.cs: Make the default output file be the first file name
17820 with the .exe extension.
17822 Detect empty compilations
17824 Handle various kinds of output targets. Handle --target and
17825 rename -t to --dumper.
17827 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17828 methods inherited from Expression return now an Expression. This
17829 will is used during the tree rewriting as we resolve them during
17832 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17833 the spec. Missing entirely is the information about
17834 accessability of elements of it.
17836 (Expression::ExprClassFromMemberInfo): New constructor for
17837 Expressions that creates a fully initialized Expression based on
17838 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17841 (Invocation::Resolve): Begin implementing resolution of invocations.
17843 * literal.cs (StringLiteral): Implement Emit.
17845 2001-09-05 Ravi Pratap <ravi@ximian.com>
17847 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17850 2001-09-04 Ravi Pratap <ravi@ximian.com>
17852 * cs-parser.jay (attribute_arguments): Implement actions.
17853 (attribute): Fix bug in production. Implement action.
17854 (attribute_list): Implement.
17855 (attribute_target): Implement.
17856 (attribute_target_specifier, opt_target_specifier): Implement
17857 (CheckAttributeTarget): New method to check if the attribute target
17859 (attribute_section): Implement.
17860 (opt_attributes): Implement.
17862 * attribute.cs : New file to handle attributes.
17863 (Attribute): Class to hold attribute info.
17865 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17866 (attribute_section): Modify production to use 2 different rules to
17867 achieve the same thing. 1 s/r conflict down !
17868 Clean out commented, useless, non-reducing dimension_separator rules.
17870 * class.cs (TypeContainer.attributes): New member to hold list
17871 of attributes for a type.
17872 (Struct::Struct): Modify to take one more argument, the attribute list.
17873 (Class::Class): Ditto.
17874 (Field::Field): Ditto.
17875 (Method::Method): Ditto.
17876 (Property::Property): Ditto.
17878 * cs-parser.jay (struct_declaration): Update constructor call to
17879 pass in the attributes too.
17880 (class_declaration): Ditto.
17881 (constant_declaration): Ditto.
17882 (field_declaration): Ditto.
17883 (method_header): Ditto.
17884 (fixed_parameter): Ditto.
17885 (parameter_array): Ditto.
17886 (property_declaration): Ditto.
17888 * constant.cs (Constant::Constant): Update constructor similarly.
17889 Use System.Collections.
17891 * parameter.cs (Parameter::Parameter): Update as above.
17893 2001-09-02 Ravi Pratap <ravi@ximian.com>
17895 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17896 (TypeContainer.delegates): New member to hold list of delegates.
17898 * cs-parser.jay (delegate_declaration): Implement the action correctly
17899 this time as I seem to be on crack ;-)
17901 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17903 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17904 tell whether an identifier represents a namespace.
17906 * expression.cs (NamespaceExpr): A namespace expression, used only
17907 temporarly during expression resolution.
17908 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17909 utility functions to resolve names on expressions.
17911 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17913 * codegen.cs: Add hook for StatementExpressions.
17915 * class.cs: Fix inverted test for static flag in methods.
17917 2001-09-02 Ravi Pratap <ravi@ximian.com>
17919 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17920 to make it coincide with MS' number.
17921 (Operator::CheckBinaryOperator): Ditto.
17923 * ../errors/errors.txt : Remove error numbers added earlier.
17925 * ../errors/cs1019.cs : Test case for error # 1019
17927 * ../errros/cs1020.cs : Test case for error # 1020
17929 * cs-parser.jay : Clean out commented cruft.
17930 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17931 used anywhere - non-reducing rule.
17932 (namespace_declarations): Non-reducing rule - comment out.
17934 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17935 with TypeContainer::AddEnum.
17937 * delegate.cs : New file for delegate handling classes.
17938 (Delegate): Class for declaring delegates.
17940 * makefile : Update.
17942 * cs-parser.jay (delegate_declaration): Implement.
17944 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17946 * class.cs (Event::Define): Implement.
17947 (Event.EventBuilder): New member.
17949 * class.cs (TypeContainer::Populate): Update to define all enums and events
17951 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17952 readonly fields for all these cases ?
17954 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17956 * class.cs (Property): Revamp to use the convention of making fields readonly.
17957 Accordingly modify code elsewhere.
17959 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17960 the Define method of the Property class.
17962 * class.cs : Clean up applied patch and update references to variables etc. Fix
17964 (TypeContainer::Populate): Update to define all the properties we have. Also
17965 define all enumerations.
17967 * enum.cs (Define): Implement.
17969 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17971 * cs-parser.jay (overloadable_operator): The semantic value is an
17972 enum of the Operator class.
17973 (operator_declarator): Implement actions.
17974 (operator_declaration): Implement.
17976 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17977 validity of definitions.
17978 (Operator::CheckBinaryOperator): Static method to check for binary operators
17979 (TypeContainer::AddOperator): New method to add an operator to a type.
17981 * cs-parser.jay (indexer_declaration): Added line to actually call the
17982 AddIndexer method so it gets added ;-)
17984 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17985 already taken care of by the MS compiler ?
17987 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17989 * class.cs (Operator): New class for operator declarations.
17990 (Operator::OpType): Enum for the various operators.
17992 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17994 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17995 ostensibly handle this in semantic analysis.
17997 * cs-parser.jay (general_catch_clause): Comment out
17998 (specific_catch_clauses, specific_catch_clause): Ditto.
17999 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
18000 (catch_args, opt_catch_args): New productions.
18001 (catch_clause): Rewrite to use the new productions above
18002 (catch_clauses): Modify accordingly.
18003 (opt_catch_clauses): New production to use in try_statement
18004 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
18005 and re-write the code in the actions to extract the specific and
18006 general catch clauses by being a little smart ;-)
18008 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
18009 Hooray, try and catch statements parse fine !
18011 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18013 * statement.cs (Block::GetVariableType): Fix logic to extract the type
18014 string from the hashtable of variables.
18016 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
18017 I end up making that mistake ;-)
18018 (catch_clauses): Fixed gross error which made Key and Value of the
18019 DictionaryEntry the same : $1 !!
18021 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18023 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
18025 * cs-parser.jay (event_declaration): Correct to remove the semicolon
18026 when the add and remove accessors are specified.
18028 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18030 * cs-parser.jay (IndexerDeclaration): New helper class to hold
18031 information about indexer_declarator.
18032 (indexer_declarator): Implement actions.
18033 (parsing_indexer): New local boolean used to keep track of whether
18034 we are parsing indexers or properties. This is necessary because
18035 implicit_parameters come into picture even for the get accessor in the
18036 case of an indexer.
18037 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
18039 * class.cs (Indexer): New class for indexer declarations.
18040 (TypeContainer::AddIndexer): New method to add an indexer to a type.
18041 (TypeContainer::indexers): New member to hold list of indexers for the
18044 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18046 * cs-parser.jay (add_accessor_declaration): Implement action.
18047 (remove_accessor_declaration): Implement action.
18048 (event_accessors_declaration): Implement
18049 (variable_declarators): swap statements for first rule - trivial.
18051 * class.cs (Event): New class to hold information about event
18053 (TypeContainer::AddEvent): New method to add an event to a type
18054 (TypeContainer::events): New member to hold list of events.
18056 * cs-parser.jay (event_declaration): Implement actions.
18058 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18060 * cs-parser.jay (dim_separators): Implement. Make it a string
18061 concatenating all the commas together, just as they appear.
18062 (opt_dim_separators): Modify accordingly
18063 (rank_specifiers): Update accordingly. Basically do the same
18064 thing - instead, collect the brackets here.
18065 (opt_rank_sepcifiers): Modify accordingly.
18066 (array_type): Modify to actually return the complete type string
18067 instead of ignoring the rank_specifiers.
18068 (expression_list): Implement to collect the expressions
18069 (variable_initializer): Implement. We make it a list of expressions
18070 essentially so that we can handle the array_initializer case neatly too.
18071 (variable_initializer_list): Implement.
18072 (array_initializer): Make it a list of variable_initializers
18073 (opt_array_initializer): Modify accordingly.
18075 * expression.cs (New::NType): Add enumeration to help us
18076 keep track of whether we have an object/delegate creation
18077 or an array creation.
18078 (New:NewType, New::Rank, New::Indices, New::Initializers): New
18079 members to hold data about array creation.
18080 (New:New): Modify to update NewType
18081 (New:New): New Overloaded contructor for the array creation
18084 * cs-parser.jay (array_creation_expression): Implement to call
18085 the overloaded New constructor.
18087 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
18089 * class.cs (TypeContainer::Constructors): Return member
18090 constructors instead of returning null.
18092 2001-08-26 Miguel de Icaza <miguel@ximian.com>
18094 * typemanager.cs (InitCoreTypes): Initialize the various core
18095 types after we have populated the type manager with the user
18096 defined types (this distinction will be important later while
18097 compiling corlib.dll)
18099 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
18100 on Expression Classification. Now all expressions have a method
18101 `Resolve' and a method `Emit'.
18103 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
18104 generation from working. Also add some temporary debugging
18107 2001-08-24 Miguel de Icaza <miguel@ximian.com>
18109 * codegen.cs: Lots of code generation pieces. This is only the
18110 beginning, will continue tomorrow with more touches of polish. We
18111 handle the fundamentals of if, while, do, for, return. Others are
18112 trickier and I need to start working on invocations soon.
18114 * gen-treedump.cs: Bug fix, use s.Increment here instead of
18117 * codegen.cs (EmitContext): New struct, used during code
18118 emission to keep a context. Most of the code generation will be
18121 * cs-parser.jay: Add embedded blocks to the list of statements of
18122 this block. So code generation proceeds in a top down fashion.
18124 2001-08-23 Miguel de Icaza <miguel@ximian.com>
18126 * statement.cs: Add support for multiple child blocks.
18128 2001-08-22 Miguel de Icaza <miguel@ximian.com>
18130 * codegen.cs (EmitCode): New function, will emit the code for a
18131 Block of code given a TypeContainer and its ILGenerator.
18133 * statement.cs (Block): Standard public readonly optimization.
18134 (Block::Block constructors): Link children.
18135 (Block::Child): Child Linker.
18136 (Block::EmitVariables): Emits IL variable declarations.
18138 * class.cs: Drop support for MethodGroups here, delay until
18140 (Method::): Applied the same simplification that I did before, and
18141 move from Properties to public readonly fields.
18142 (Method::ParameterTypes): Returns the parameter types for the
18143 function, and implements a cache that will be useful later when I
18144 do error checking and the semantic analysis on the methods is
18146 (Constructor::GetCallingConvention): Renamed from CallingConvetion
18147 and made a method, optional argument tells whether this is a class
18148 or a structure to apply the `has-this' bit.
18149 (Method::GetCallingConvention): Implement, returns the calling
18151 (Method::Define): Defines the type, a second pass is performed
18152 later to populate the methods.
18154 (Constructor::ParameterTypes): implement a cache similar to the
18155 one on Method::ParameterTypes, useful later when we do semantic
18158 (TypeContainer::EmitMethod): New method. Emits methods.
18160 * expression.cs: Removed MethodGroup class from here.
18162 * parameter.cs (Parameters::GetCallingConvention): new method.
18164 2001-08-21 Miguel de Icaza <miguel@ximian.com>
18166 * class.cs (TypeContainer::Populate): Drop RootContext from the
18169 (Constructor::CallingConvention): Returns the calling convention.
18170 (Constructor::ParameterTypes): Returns the constructor parameter
18173 (TypeContainer::AddConstructor): Keep track of default constructor
18174 and the default static constructor.
18176 (Constructor::) Another class that starts using `public readonly'
18177 instead of properties.
18179 (Constructor::IsDefault): Whether this is a default constructor.
18181 (Field::) use readonly public fields instead of properties also.
18183 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
18184 track of static constructors; If none is used, turn on
18185 BeforeFieldInit in the TypeAttributes.
18187 * cs-parser.jay (opt_argument_list): now the return can be null
18188 for the cases where there are no arguments.
18190 (constructor_declarator): If there is no implicit `base' or
18191 `this', then invoke the default parent constructor.
18193 * modifiers.cs (MethodAttr): New static function maps a set of
18194 modifiers flags into a MethodAttributes enum
18195 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
18196 MethodAttr, TypeAttr to represent the various mappings where the
18197 modifiers are used.
18198 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
18200 2001-08-19 Miguel de Icaza <miguel@ximian.com>
18202 * parameter.cs (GetParameterInfo): Fix bug where there would be no
18205 * interface.cs (PopulateIndexer): Implemented the code generator
18206 for interface indexers.
18208 2001-08-17 Miguel de Icaza <miguel@ximian.com>
18210 * interface.cs (InterfaceMemberBase): Now we track the new status
18213 (PopulateProperty): Implement property population. Woohoo! Got
18214 Methods and Properties going today.
18216 Removed all the properties for interfaces, and replaced them with
18217 `public readonly' fields.
18219 2001-08-16 Miguel de Icaza <miguel@ximian.com>
18221 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
18222 initialize their hashtables/arraylists only when they are needed
18223 instead of doing this always.
18225 * parameter.cs: Handle refs and out parameters.
18227 * cs-parser.jay: Use an ArrayList to construct the arguments
18228 instead of the ParameterCollection, and then cast that to a
18231 * parameter.cs: Drop the use of ParameterCollection and use
18232 instead arrays of Parameters.
18234 (GetParameterInfo): Use the Type, not the Name when resolving
18237 2001-08-13 Miguel de Icaza <miguel@ximian.com>
18239 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
18240 and instead use public readonly fields.
18242 * class.cs: Put back walking code for type containers.
18244 2001-08-11 Miguel de Icaza <miguel@ximian.com>
18246 * class.cs (MakeConstant): Code to define constants.
18248 * rootcontext.cs (LookupType): New function. Used to locate types
18251 2001-08-08 Miguel de Icaza <miguel@ximian.com>
18253 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
18254 this System.Reflection code is. Kudos to Microsoft
18256 * typemanager.cs: Implement a type cache and avoid loading all
18257 types at boot time. Wrap in LookupType the internals. This made
18258 the compiler so much faster. Wow. I rule!
18260 * driver.cs: Make sure we always load mscorlib first (for
18261 debugging purposes, nothing really important).
18263 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18264 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18266 * rootcontext.cs: Lookup types on their namespace; Lookup types
18267 on namespaces that have been imported using the `using' keyword.
18269 * class.cs (TypeContainer::TypeAttr): Virtualize.
18270 (Class::TypeAttr): Return attributes suitable for this bad boy.
18271 (Struct::TypeAttr): ditto.
18272 Handle nested classes.
18273 (TypeContainer::) Remove all the type visiting code, it is now
18274 replaced with the rootcontext.cs code
18276 * rootcontext.cs (GetClassBases): Added support for structs.
18278 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18280 * interface.cs, statement.cs, class.cs, parameter.cs,
18281 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18282 Drop use of TypeRefs, and use strings instead.
18284 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18288 * class.cs (Struct::Struct): set the SEALED flags after
18289 checking the modifiers.
18290 (TypeContainer::TypeAttr): new property, returns the
18291 TypeAttributes for a class.
18293 * cs-parser.jay (type_list): Oops, list production was creating a
18294 new list of base types.
18296 * rootcontext.cs (StdLib): New property.
18297 (GetInterfaceTypeByName): returns an interface by type name, and
18298 encapsulates error handling here.
18299 (GetInterfaces): simplified.
18300 (ResolveTree): Encapsulated all the tree resolution here.
18301 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18304 * driver.cs: Add support for --nostdlib, to avoid loading the
18305 default assemblies.
18306 (Main): Do not put tree resolution here.
18308 * rootcontext.cs: Beginning of the class resolution.
18310 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18312 * rootcontext.cs: Provide better error reporting.
18314 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18316 * rootcontext.cs (CreateInterface): Handle the case where there
18317 are no parent interfaces.
18319 (CloseTypes): Routine to flush types at the end.
18320 (CreateInterface): Track types.
18321 (GetInterfaces): Returns an array of Types from the list of
18322 defined interfaces.
18324 * typemanager.c (AddUserType): Mechanism to track user types (puts
18325 the type on the global type hash, and allows us to close it at the
18328 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18330 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18331 RecordInterface instead.
18333 * cs-parser.jay: Updated to reflect changes above.
18335 * decl.cs (Definition): Keep track of the TypeBuilder type that
18336 represents this type here. Not sure we will use it in the long
18337 run, but wont hurt for now.
18339 * driver.cs: Smaller changes to accomodate the new code.
18341 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18344 * rootcontext.cs (CreateInterface): New method, used to create
18345 the System.TypeBuilder type for interfaces.
18346 (ResolveInterfaces): new entry point to resolve the interface
18348 (CodeGen): Property, used to keep track of the code generator.
18350 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18352 * cs-parser.jay: Add a second production for delegate_declaration
18355 (enum_body): Put an opt_comma here instead of putting it on
18356 enum_body or enum_member_declarations so we can handle trailing
18357 commas on enumeration members. Gets rid of a shift/reduce.
18359 (type_list): Need a COMMA in the middle.
18361 (indexer_declaration): Tell tokenizer to recognize get/set
18363 * Remove old targets.
18365 * Re-add the parser target.
18367 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18369 * cs-parser.jay: Add precendence rules for a number of operators
18370 ot reduce the number of shift/reduce conflicts in the grammar.
18372 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18374 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18377 Get rid of old crufty code.
18379 * rootcontext.cs: Use this to keep track of the parsed
18380 representation and the defined types available to the program.
18382 * gen-treedump.cs: adjust for new convention.
18384 * type.cs: Split out the type manager, and the assembly builder
18387 * typemanager.cs: the type manager will live here now.
18389 * cil-codegen.cs: And the code generator here.
18391 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18393 * makefile: Fixed up for easy making.
18395 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18397 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18400 (unary_expression): Expand pre_increment_expression and
18401 post_decrement_expression to reduce a shift/reduce.
18403 2001-07-11 Simon Cozens
18405 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18407 Improve allow_keyword_as_indent name.
18409 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18411 * Adjustments for Beta2.
18413 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18415 * decl.cs: Added `Define' abstract method.
18416 (InTransit): new property, used to catch recursive definitions.
18418 * interface.cs: Implement `Define'.
18420 * modifiers.cs: Map Modifiers.constants to
18421 System.Reflection.TypeAttribute flags.
18423 * class.cs: Keep track of types and user-defined types.
18424 (BuilderInit): New method for creating an assembly
18425 (ResolveType): New function to launch the resolution process, only
18426 used by interfaces for now.
18428 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18429 that are inserted into the name space.
18431 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18433 * ARGH. I have screwed up my tree so many times due to the use of
18434 rsync rather than using CVS. Going to fix this at once.
18436 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18439 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18441 * Experiment successful: Use System.Type rather that our own
18444 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18446 * cs-parser.jay: Removed nsAliases from here.
18448 Use new namespaces, handle `using XXX;'
18450 * namespace.cs: Reimplemented namespace handling, use a recursive
18451 definition of the class. Now we can keep track of using clauses
18452 and catch invalid using clauses.
18454 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18456 * gen-treedump.cs: Adapted for all the renaming.
18458 * expression.cs (Expression): this class now has a Type property
18459 which returns an expression Type.
18461 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18462 `Type', as this has a different meaning now in the base
18464 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18466 * interface.cs, class.cs: Removed from all the sources the
18467 references to signature computation, as we can not do method
18468 signature computation during the parsing time, as we are not
18469 trying to solve at that point distinguishing:
18473 void a (NS.Blah x) {}
18476 Which depending on the context might be valid or not, as we do not
18477 know if Blah is the same thing as NS.Blah at that point.
18479 * Redid everything so the code uses TypeRefs now instead of
18480 Types. TypeRefs are just temporary type placeholders, that need
18481 to be resolved. They initially have a pointer to a string and the
18482 current scope in which they are used. This is used later by the
18483 compiler to resolve the reference to an actual Type.
18485 * DeclSpace is no longer a CIR.Type, and neither are
18486 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18487 are all DeclSpaces, but no Types.
18489 * type.cs (TypeRefManager): This implements the TypeRef manager,
18490 which keeps track of all the types that need to be resolved after
18491 the parsing has finished.
18493 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18495 * ARGH. We are going to have to store `foreach' as a class rather
18496 than resolving it, as we need to verify error 1579 after name
18497 resolution. *OR* we could keep a flag that says `This request to
18498 IEnumerator comes from a foreach statement' which we can then use
18499 to generate the error.
18501 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18503 * class.cs (TypeContainer.AddMethod): we now add methods to the
18504 MethodGroup instead of the method hashtable.
18506 * expression.cs: Add MethodGroup abstraction, which gets us one
18507 step closer to the specification in the way we handle method
18510 * cs-parser.jay (primary_expression): qualified_identifier now
18511 tried to match up an identifier to a local variable reference or
18512 to a parameter reference.
18514 current_local_parameters is now a parser global variable that
18515 points to the current parameters for the block, used during name
18518 (property_declaration): Now creates an implicit `value' argument to
18521 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18523 * parameter.cs: Do not use `param' arguments as part of the
18524 signature, per the spec.
18526 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18528 * decl.cs: Base class for classes, structs and interfaces. This
18529 is the "Declaration Space"
18531 * cs-parser.jay: Use CheckDef for checking declaration errors
18532 instead of having one on each function.
18534 * class.cs: Factor out some code for handling error handling in
18535 accordance to the "Declarations" section in the "Basic Concepts"
18536 chapter in the ECMA C# spec.
18538 * interface.cs: Make all interface member classes derive from
18539 InterfaceMemberBase.
18541 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18543 * Many things: all interfaces are parsed and generated in
18544 gen-treedump. Support for member variables, constructors,
18545 destructors, properties, constants is there.
18547 Beginning of the IL backend, but very little done, just there for
18550 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18552 * cs-parser.jay: Fix labeled statement.
18554 * cs-tokenizer.cs (escape): Escape " and ' always.
18555 ref_line, ref_name: keep track of the line/filename as instructed
18556 by #line by the compiler.
18559 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18561 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18562 to match the values in System.CodeDOM.
18564 Divid renamed to Divide.
18566 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18568 (Statements.set): remove.
18570 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18573 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18574 falseStatements always have valid values.
18576 * cs-parser.jay: Use System.CodeDOM now.