1 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
2 Raja R Harinath <rharinath@novell.com>
4 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
5 Note the order in which accessors are declared in the source.
7 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
9 * generic.cs (TypeParameter.FindMembers): Use the generic
10 constraints, not the constraints to check for methods (first fix
13 2006-12-30 Marek Safar <marek.safar@gmail.com>
15 * cs-parser.jay: Better syntax errors handling.
17 2006-11-21 Marek Safar <marek.safar@gmail.com>
19 * cs-parser.jay: Tiny change to work with mcs tokenizer.
21 * cs-tokenizer.cs: Remove after unification with mcs.
23 2006-10-28 Marek Safar <marek.safar@gmail.com>
26 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
29 2006-10-26 Marek Safar <marek.safar@gmail.com>
32 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
34 2006-10-25 Brian Crowell <brian@fluggo.com>
37 * generic.cs (CheckConstraints): Allow generic parameters with
38 inheritance constraints to satisfy reference type constraints.
40 2006-10-09 Martin Baulig <martin@ximian.com>
43 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
45 2006-09-25 Martin Baulig <martin@ximian.com>
47 * class.cs: Remove after unification with mcs source.
49 2006-09-24 Raja R Harinath <harinath@gmail.com>
51 * convert.cs: Remove after unification with mcs source.
53 2006-09-24 Marek Safar <marek.safar@seznam.cz>
55 * class.cs (MemberBase.VerifyClsCompliance): When method has type
56 parameters verify them as well.
58 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
59 the type parameter constraints.
60 (Generics.VerifyClsCompliance): Ditto.
62 2006-09-24 Marek Safar <marek.safar@seznam.cz>
64 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
65 for anonymous block with out argument.
67 2006-09-24 Marek Safar <marek.safar@seznam.cz>
69 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
70 not used private events only.
72 2006-09-23 Marek Safar <marek.safar@seznam.cz>
74 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
76 * cs-parser.jay: Parse correctly cast of default (T).
78 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
79 Store original type via EmptyConstantCast.
81 2006-09-22 Martin Baulig <martin@ximian.com>
83 * delegate.cs: Removed; this file is now shared with mcs.
85 * attribute.cs: Removed; this file is now shared with mcs.
87 2006-09-22 Martin Baulig <martin@ximian.com>
89 * ecore.cs: Removed; this file is now shared with mcs.
91 2006-09-21 Marek Safar <marek.safar@seznam.cz>
93 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
95 * ecore.cs (NullCast): Derives from NullConstant.
97 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
100 2006-09-21 Martin Baulig <martin@ximian.com>
102 * decl.cs: Removed; this file is now shared with mcs.
104 2006-09-21 Raja R Harinath <rharinath@novell.com>
106 * rootcontext.cs: Remove after unification with mcs source.
108 * report.cs: Remove after unification with mcs source.
109 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
111 (InitGenerics, CleanUpGenerics): Remove.
113 * support.cs: Remove after unification with mcs source.
115 2006-09-20 Raja R Harinath <rharinath@novell.com>
117 * codegen.cs: Remove after unification with mcs source.
119 2006-09-19 Martin Baulig <martin@ximian.com>
121 * expression.cs: Removed; this file is now shared with mcs.
123 2006-09-19 Martin Baulig <martin@ximian.com>
126 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
127 (TypeManager.DropGenericTypeArguments): Likewise.
128 (TypeManager.DropGenericMethodArguments): Likewise.
129 (TypeManager.GetTypeArguments): Likewise.
130 (TypeManager.HasGenericArguments): Likewise.
132 2006-09-19 Martin Baulig <martin@ximian.com>
134 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
136 2006-09-19 Martin Baulig <martin@ximian.com>
138 * typemanager.cs: Removed; this file is now shared with mcs.
140 2006-09-16 Raja R Harinath <rharinath@novell.com>
142 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
143 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
145 2006-09-16 Marek Safar <marek.safar@seznam.cz>
148 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
149 only if parent type is class.
150 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
153 2006-09-15 Marek Safar <marek.safar@seznam.cz>
156 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
158 * typemanager.cs(CSharpName): Converts NullType to null.
160 2006-09-15 Martin Baulig <martin@ximian.com>
162 * pending.cs: Removed; this file is now shared with mcs.
164 2006-09-15 Martin Baulig <martin@ximian.com>
166 * statement.cs: Removed; this file is now shared with mcs.
168 2006-09-15 Martin Baulig <martin@ximian.com>
170 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
172 * driver.cs: Removed the `--broken-cycles' argument.
174 2006-09-15 Martin Baulig <martin@ximian.com>
176 * namespace.cs: Removed; this file is now shared with mcs.
178 2006-09-15 Martin Baulig <martin@ximian.com>
180 * decl.cs (MemberName): Minor code cleanups.
182 2006-09-15 Martin Baulig <martin@ximian.com>
184 * parameter.cs: Removed; this file is now shared with mcs.
186 2006-09-15 Martin Baulig <martin@ximian.com>
188 * enum.cs: Removed; this file is now shared with mcs.
190 2006-09-15 Martin Baulig <martin@ximian.com>
192 * Makefile: Define `GMCS_SOURCE'.
194 * flowanalysis.cs: Removed; this file is now shared with mcs.
196 2006-09-15 Martin Baulig <martin@ximian.com>
198 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
199 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
200 doc.cs - they are now shared with mcs.
202 * gmcs.exe.sources: Include these files from ../mcs/.
204 2006-09-15 Martin Baulig <martin@ximian.com>
206 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
207 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
209 2006-09-14 Marek Safar <marek.safar@seznam.cz>
211 * assign.cs, ecore.cs, expression.cs: Share error message text.
212 * class.cs (FieldMember.Define): Check for variable of static type.
213 * decl.cs (check_type_parameter): Report correct type name.
214 * driver.cs (LoadAssembly): Uses error output for errors.
215 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
216 (TypeArguments.Resolve): Static class cannot be used as an argument.
217 * statement.cs (ResolveMeta): Constants cannot be generic types.
219 2006-09-12 Martin Baulig <martin@ximian.com>
221 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
223 * convert.cs (Convert.Array_To_IList): Moved here and correctly
224 implement it; fixes #79345.
226 2006-09-08 Marek Safar <marek.safar@seznam.cz>
228 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
230 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
232 * generic.cs: Improved error messages.
233 * typemanager.cs (RemoveGenericArity): Made public.
235 2006-09-08 Martin Baulig <martin@ximian.com>
237 * typemanager.cs (TypeManager.interlocked_type): New public field.
238 (TypeManager.int_interlocked_compare-exchange): New public field.
239 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
240 enumerator types here and call InitGenericCoreTypes().
241 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
242 after calling InitEnumUnderlyingTypes().
245 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
246 `classes_second_stage'.
248 2006-09-07 Marek Safar <marek.safar@seznam.cz>
250 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
252 * statement.cs (Block.Variables): Made public.
254 2006-09-07 Martin Baulig <martin@ximian.com>
257 (MainDriver): Revert r62663 from Marek; see #70506 for details.
259 2006-09-01 Martin Baulig <martin@ximian.com>
262 (TypeManager.IsIList): Also handle base classes and interfaces.
264 2006-09-01 Raja R Harinath <rharinath@novell.com>
267 * expression.cs (Invocation.MoreSpecific): Check for reference
270 2006-08-29 Miguel de Icaza <miguel@novell.com>
272 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
274 2006-08-17 Miguel de Icaza <miguel@novell.com>
276 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
277 #52019 and #79064, the use of the \uXXXX sequence in source code
278 to represent unicode characters.
280 2006-08-15 Marek Safar <marek.safar@seznam.cz>
282 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
284 * class.cs, ecore.cs, statement.cs: Merged to one error message.
286 2006-08-14 Raja R Harinath <rharinath@novell.com>
289 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
290 parameter too. This only avoids a parse error -- the semantic
291 error is caught elsewhere.
293 2006-08-13 Miguel de Icaza <miguel@novell.com>
295 * assign.cs: Catch attempts to assign to a method groups in += and
298 2006-08-13 Marek Safar <marek.safar@seznam.cz>
301 * cs-parser.jay: Don't destroy current array type by typeof of array's.
303 2006-08-12 Marek Safar <marek.safar@seznam.cz>
305 * cs-parser.jay: Check whether a constraint clause has already been
306 specified for type parameter.
307 * generic.cs (Constraints): Exposed location.
309 2006-08-12 Marek Safar <marek.safar@seznam.cz>
311 * class.cs (Method.Define): Issue a warning when generic method looks like
313 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
315 * report.cs: New warning number.
317 2006-08-09 Marek Safar <marek.safar@seznam.cz>
319 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
321 * decl.cs (MemberCache.FindMembers): When container is interface we need to
322 search all base interfaces as a member can be ambiguous.
323 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
324 Constructor member type filter.
325 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
326 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
327 reporting for returned memberinfos.
328 * report.cs: Updated.
329 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
330 version to work on all runtimes.
331 (TypeManager.RealMemberLookup): Removed members filtering.
333 2006-08-08 Raja R Harinath <rharinath@novell.com>
335 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
336 (PropertyExpr.EmitAssign): Likewise.
337 * expression.cs (Indirection.EmitAssign): Likewise.
338 (LocalVariableReference.EmitAssign): Likewise.
339 (ParameterReference.EmitAssign): Likewise.
340 (Invocation.EmitArguments): Likewise.
341 (ArrayAccess.EmitAssign): Likewise.
342 (IndexerAccess.EmitAssign): Likewise.
343 (This.EmitAssign): Likewise.
344 (ConditionalLogicalOperator.Emit): Likewise.
347 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
348 instead of ArrayList. If the hashtable has a LocalBuilder, don't
349 leave it in after returning it.
350 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
352 2006-08-06 Marek Safar <marek.safar@seznam.cz>
354 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
357 2006-08-05 Marek Safar <marek.safar@seznam.cz>
359 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
360 with different type names.
361 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
363 2006-08-03 Raja R Harinath <rharinath@novell.com>
365 Fix cs0146-3.cs and cs0146-4.cs.
366 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
367 enclosing types don't depend on the current type.
369 2006-08-02 Raja R Harinath <rharinath@novell.com>
372 * class.cs (TypeContainer.DoDefineMembers): Use
373 FindBaseMemberWithSameName on Parent, since we're interested in
374 whether we hide inherited members or not.
375 (FindBaseMemberWithSameName): Make slightly more robust.
378 * codegen.cs (IResolveContext.GenericDeclContainer): New.
379 (EmitContext): Implement new interface requirement.
380 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
381 * decl.cs (MemberCore): Likewise.
382 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
383 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
384 ec.GenericDeclContainer to check for generic parameters.
385 (SimpleName.DoSimpleNameResolve): Likewise.
386 * generic.cs (TypeParameter.DeclContainer): Remove override.
388 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
389 declspaces for doppelgangers too.
390 (UsingEntry): Implement IResolveContext.
391 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
392 'this' as the resolve context.
393 (LocalAliasEntry): Likewise.
395 Implement parts of #77403
396 * roottypes.cs (RootDeclSpace): New. Used to represent the
397 toplevel declaration space. Each namespace declaration introduces
398 a "partial" root declaretion space.
399 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
400 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
401 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
402 from 'current_namespace.SlaveDeclSpace'.
403 (namespace_declaration): Likewise.
404 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
405 check. It can't happen now.
406 * decl.cs (DeclSpace.LookupType): Likewise.
407 * driver.cs (MainDriver): Sanity check.
409 2006-08-01 Raja R Harinath <rharinath@novell.com>
411 * decl.cs (DeclSpace.FindNestedType): Remove.
412 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
413 LookupTypeContainer to get the container of the nested type.
414 * class.cs (TypeContainer.FindNestedType): Make non-override.
416 2006-07-31 Raja R Harinath <rharinath@novell.com>
418 * decl.cs (DeclSpace.PartialContainer): Move field from ...
419 * class.cs (TypeContainer.PartialContainer): ... here.
420 (TypeContainer.AddBasesForPart): New helper.
421 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
423 * cs-parser.jay (current_class): Convert to DeclSpace.
424 (struct_declaration, interface_declaration, class_declaration):
425 Use AddBasesForPart instead of .Bases directly.
426 * const.cs, iterators.cs: Update to changes.
428 2006-07-28 Raja R Harinath <rharinath@novell.com>
430 * class.cs (TypeContainer.AddMemberType): Rename from
432 (TypeContainer.AddMember): Rename from AddToMemberContainer.
433 (AddTypeContainer): New. Combine AddClassOrStruct and
435 (AddPartial): Update. Add 'is_partial' argument.
436 * roottypes.cs: Update to changes.
437 * cs-parser.jay (push_current_class): New helper for handling
438 current_container and current_class.
439 (struct_declaration, interface_declaration, class_declaration):
442 2006-07-26 Raja R Harinath <rharinath@novell.com>
444 * roottypes.cs: Rename from tree.cs.
446 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
447 * tree.cs (Tree, ITreeDump): Remove types.
448 * rootcontext.cs (tree, Tree): Remove fields.
449 (root, ToplevelTypes): New.
450 * *.cs: Update to rename.
452 * tree.cs (Tree.RecordDecl): Remove.
453 (RootTypes.AddToTypeContainer): Record the toplevel type in its
455 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
457 2006-07-23 Raja R Harinath <harinath@gmail.com>
459 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
460 DoFlowAnalysis and OmitStructFlowAnalysis here.
461 (ec.With): Rename from WithUnsafe and generalize.
462 (ec.WithCheckState): Remove. All users can be handled by 'With'.
463 (ec.WithFlowAnalyis): New.
464 * ecore.cs, expression.cs, statement.cs: Update.
466 2006-07-22 Raja R Harinath <harinath@gmail.com>
468 * statement.cs (Block.ResolveMeta): Simplify slightly.
470 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
471 multiple boolean fields. Convert InUnsafe, constant_check_state,
472 check_state to flags.
473 (CheckState, ConstantCheckState): Update.
474 (InUnsafe): New read-only property.
475 (FlagsHandle): Rename from CheckStateHandle and convert to handle
477 (WithUnsafe): New helper similar to WithCheckState.
478 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
479 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
481 2006-07-21 Raja R Harinath <rharinath@novell.com>
483 Make comparisons use the same IL irrespective of whether they're
484 in a 'checked' or 'unchecked' context: one of the issues in #78899
485 * codegen.cs (EmitContext.CheckState): Make read-only property.
486 (EmitContext.ConstantCheckState): Likewise.
487 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
488 helper that implement a save/restore stack for CheckState
489 values. This is the only way to change check-state.
490 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
491 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
492 (CheckedExpr.EmitBranchable): New forwarding method.
493 (UnCheckedExpr): Likewise.
494 * statement.cs (Block.ResolveMeta): Use WithCheckState.
495 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
496 (Checked.Resolve, checked.DoEmit): Likewise.
498 2006-07-21 Martin Baulig <martin@ximian.com>
500 * generic.cs (TypeManager.InferType): When inferring an array
501 type, also allow IList<T> and ICollection<T>. Fixes #78900.
503 2006-07-21 Martin Baulig <martin@ximian.com>
505 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
506 and allow IList`1 and all its base interfaces.
508 * convert.cs (Convert.ImplicitReferenceConversion): Allow
509 converting from an array-type of T to IList<T>.
511 2006-07-21 Martin Baulig <martin@ximian.com>
513 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
515 2006-07-20 Miguel de Icaza <miguel@novell.com>
517 * anonymous.cs: Cache the resolved anonymous delegate, and return
518 this so that the ResolveTopBlock is only triggered once, not
521 Currently we trigger ResolvetopBlock twice due to a first pass of
522 argument check compatibility, and a second pass that does the
525 2006-07-15 Marek Safar <marek.safar@seznam.cz>
527 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
529 * rootcontext.cs (Reset): Add helper_classes.
531 2006-07-15 Marek Safar <marek.safar@seznam.cz>
534 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
537 2006-07-13 Miguel de Icaza <miguel@novell.com>
539 * statement.cs (Lock): Handle expressions of type
540 TypeManager.null_type specially. Fixes #78770
542 2006-07-08 Marek Safar <marek.safar@seznam.cz>
544 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
547 2006-07-08 Marek Safar <marek.safar@seznam.cz>
549 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
550 for accessors as well.
551 * ecore.cs (EventExpr): Add AccessorTable.
553 2006-07-03 Martin Baulig <martin@ximian.com>
555 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
556 instances of value types.
558 * convert.cs (Convert.ExplicitConversion): Correctly handle
559 object->nullable conversions.
561 2006-07-01 Marek Safar <marek.safar@seznam.cz>
564 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
565 for CS0122 where appropriate.
566 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
568 (Filter): Assembly can be null in the case of top level attributes.
570 2006-06-28 Raja R Harinath <rharinath@novell.com>
573 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
574 no arguments, return 'false': nothing can be inferred.
576 2006-06-25 Marek Safar <marek.safar@seznam.cz>
580 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
581 is done at global level.
583 2006-06-24 Marek Safar <marek.safar@seznam.cz>
585 A fix for #77002, Implemented TypeForwarder support.
587 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
588 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
590 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
591 * typemanager.cs (): Add type_forwarder_attr_type.
593 2006-06-24 Marek Safar <marek.safar@seznam.cz>
595 * report.cs: Add CS0469 warning.
597 2006-06-22 Martin Baulig <martin@ximian.com>
600 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
601 for interfaces; fixes #78686, which is a modification of #78380
602 with interfaces instead of classes.
604 2006-06-21 Martin Baulig <martin@ximian.com>
606 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
607 the `try'-block, so we also report CS0016 etc. there.
609 2006-06-21 Martin Baulig <martin@ximian.com>
611 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
612 handle SetAssigned() and SetMemberIsUsed() for generic types;
615 2006-06-21 Martin Baulig <martin@ximian.com>
618 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
620 2006-06-21 Martin Baulig <martin@ximian.com>
622 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
623 also report CS1686 for parameters.
625 2006-06-21 Martin Baulig <martin@ximian.com>
627 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
628 instead of an error if the value is not implicitly convertible to
629 the switch types; fixes #77964.
631 2006-06-21 Raja R Harinath <rharinath@novell.com>
634 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
635 FieldBuilder is null.
638 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
639 'left' and 'right' before error-checking.
641 2006-06-19 Martin Baulig <martin@ximian.com>
644 (Convert.ImplicitConversionStandard): Cleanup and correctly
645 implement nullable conversions.
646 (Convert.ImplicitStandardConversionExists): Likewise.
647 (Convert.ExplicitConversion): Likewise.
649 2006-06-19 Martin Baulig <martin@ximian.com>
652 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
653 methods; make the ctors protected.
655 2006-06-19 Martin Baulig <martin@ximian.com>
657 Fixed #78380; added gtest-273.cs.
660 (Expression.ResolveAsBaseTerminal): Move the constraint checking
661 into ResolveAsTypeTerminal().
664 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
665 TypeManager.FindMembers() to check for the default ctor.
667 2006-06-18 Marek Safar <marek.safar@seznam.cz>
669 * generic.cs: Fixed NullableInfo accessibility.
671 2006-06-16 Martin Baulig <martin@ximian.com>
674 (Constraints.InflatedConstraints.inflate): Correctly inflate
675 generic types; fixes #78400.
677 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
679 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
681 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
682 (FieldExpr.DoResolve): likewise.
683 (PropertyExpr.InstanceResolve): likewise.
684 (EventExpr.InstanceResolve): likewise.
686 2006-06-15 Martin Baulig <martin@ximian.com>
689 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
690 argument; always allow a `null' label if true.
691 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
692 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
693 we have a `null' label and mark the new `null_target' label;
694 default to the `default' label.
695 (Switch.Resolve): Add support for nullable types. Fixes #78630.
697 2006-06-15 Martin Baulig <martin@ximian.com>
699 * class.cs (Operator.Define): Allow an implicit/explicit operator
700 to convert to/from a nullable value of the enclosing type.
702 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
703 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
706 (Convert.ImplicitStandardConversionExists): Add support for lifted
707 implicit/explicit conversions.
708 (Convert.ImplicitConversionStandard): Likewise.
710 2006-06-13 Martin Baulig <martin@ximian.com>
712 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
713 type arguments and create a ConstructedType if necessary. Fixes #78400.
715 2006-06-04 Marek Safar <marek.safar@seznam.cz>
717 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
718 attribute applicable tests for attribute argument.
720 2006-06-02 Raja R Harinath <rharinath@novell.com>
723 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
724 (Binary.OverloadResolve_PredefinedIntegral): New.
725 (Binary.OverloadResolve_PredefinedFloating): New.
726 (Binary.OverloadResolve_PredefinedString): New.
727 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
728 Follow the standard more closely, and treat numeric promotions in
729 terms of overload resolution.
730 (Binary.CheckShiftArguments): Simplify.
732 2006-06-01 Raja R Harinath <rharinath@novell.com>
734 * flowanalysis.cs (MyBitVector): Simplify representation.
735 (MyBitVector.Clone): Avoid allocating BitArray.
736 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
737 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
738 (*): Update. Change all references to MyBitVector.And and
739 MyBitVector.Or to &= and |=.
741 2006-05-31 Raja R Harinath <rharinath@novell.com>
743 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
744 Use bne.un instead of ceq+brfalse.
747 * typemanager.cs (IsUnmanagedType): Disallow generic types and
750 2006-05-29 Raja R Harinath <rharinath@novell.com>
753 * cs-parser.jay (formal_parameter_list): Extend the pattern below
754 to param arguments too.
756 2006-05-26 Miguel de Icaza <miguel@novell.com>
758 * cs-parser.jay: Catch another parsing form for arglist being
759 followed by other arguments. Fixes #78313.
761 2006-05-25 Raja R Harinath <rharinath@novell.com>
764 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
765 also when one of the operands is a null literal.
766 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
767 to improve clarity, and generate slightly better code.
769 2006-05-24 Raja R Harinath <rharinath@novell.com>
771 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
772 checking of out parameters to ...
773 (FlowBranchingToplevel.Merge): ... here.
774 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
775 set, propagate the origin upward, and only complain if there was
777 (FlowBranchingException.AddContinueOrigin): Likewise.
778 (FlowBranchingException.AddReturnOrigin): Likewise.
779 (FlowBranchingException.AddGotoOrigin): Likewise.
781 2006-05-23 Raja R Harinath <rharinath@novell.com>
783 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
784 unreachable, skip it.
785 (FlowBranchingException.Merge): Always propagate jumps, even if
786 the finally block renders subsequent code unreachable.
788 2006-05-18 Raja R Harinath <rharinath@novell.com>
791 * statement.cs (Goto.Resolve): Move responsibility for resolving
792 'goto' to FlowBranching.AddGotoOrigin.
793 (Goto.SetResolvedTarget): New. Callback to set the
794 LabeledStatement that's the target of the goto.
795 (Goto.DoEmit): Use Leave instead of Br when crossing an
796 unwind-protect boundary.
797 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
798 LookupLabel and adjust to new semantics.
799 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
800 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
801 Goto.SetResolvedTarget to update target.
802 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
803 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
804 AddBreakOrigin & co. Delay propagation until ...
805 (FlowBranchingException.Merge): ... this.
807 * statement.cs (Block.Resolve): Always depend on flow-branching to
808 determine unreachability. Kill workaround that originally emitted
809 only one statement after an "unreachable" label (see infloop in
812 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
813 This is still "wrong", but anything better would probably need a
814 multi-pass algorithm.
815 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
816 usage vector. Force current usage vector to be reachable, to
817 optimistically signify backward jumps.
818 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
820 (FlowBranchingLabeled.Merge): New. If no backward jump was
821 detected, return the original salted-away usage vector instead,
822 updated with appropriate changes. Print unreachable warning if
824 * statement.cs (Block.Resolve): Don't print unreachable warning on
827 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
829 * driver.cs: Pass filename without path to AssemblyBuilder's
830 AddResourceFile. Fixes bug #78407.
832 2006-05-17 Raja R Harinath <rharinath@novell.com>
834 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
835 * flowanalysis.cs (FlowBranchingLabeled): ... here.
836 (FlowBranching.MergeChild): Overwrite
837 reachability information from Labeled branchings too.
839 2006-05-16 Raja R Harinath <rharinath@novell.com>
841 * statement.cs (Goto.Resolve): Merge jump origins here ...
842 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
844 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
845 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
846 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
847 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
849 * statement.cs (Goto.Resolve): ... not here.
850 (Goto.Emit): Remove CS1632 check.
852 2006-05-14 Marek Safar <marek.safar@seznam.cz>
854 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
857 2006-05-11 Raja R Harinath <rharinath@novell.com>
859 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
860 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
861 (FlowBranchingException.Label): Likewise.
863 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
865 (MyBitVector.Or): Use it to avoid losing information (Count).
866 (FlowBranching.MergeOrigins): Likewise.
868 * flowanalysis.cs (UsageVector.IsDirty): Remove.
869 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
870 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
871 (UsageVector.ToString): Simplify.
872 (UsageVector.MergeSiblings): Move here from ...
873 (FlowBranching.Merge): ... here.
874 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
877 2006-05-10 Raja R Harinath <rharinath@novell.com>
879 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
880 null bitvector is treated as all-true.
882 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
883 (MyBitVector): Rationalize invariants. 'vector != null' implies
884 that we have our own copy of the bitvector. Otherwise,
885 'InheritsFrom == null' implies all inherited bits are true.
887 2006-05-09 Marek Safar <marek.safar@seznam.cz>
889 * statement.cs (LocalInfo): Add IsConstant.
890 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
891 local variable for constants.
893 2006-05-09 Raja R Harinath <rharinath@novell.com>
895 * flowanalysis.cs (MyBitVector.Empty): New.
896 (MyBitVector): Don't allow InheritedFrom to be null.
897 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
898 (UsageVector, FlowBranching): Update to changes.
900 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
901 recursion. The 'Parent == null' condition isn't sufficient for
903 (FlowBranching.AddBreakOrigin): Likewise.
904 (FlowBranching.AddContinueOrigin): Likewise.
905 (FlowBranching.AddReturnOrigin): Likewise.
906 (FlowBranching.StealFinallyClauses): Likewise.
907 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
908 (FlowBranching.CheckOutParameters): Likewise.
909 (FlowBranchingToplevel): Terminate all the above recursions here.
910 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
911 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
913 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
915 (FlowBranchingToplevel): New. Empty for now.
916 (FlowBranching.MergeTopBlock): Update.
917 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
918 branching for the anonymous delegate.
919 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
921 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
922 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
923 information at the start of the merge. Reorganize.
925 2006-05-07 Marek Safar <marek.safar@seznam.cz>
927 * class.cs (MethodData.Define): Method cannot implement interface accessor.
929 2006-05-07 Marek Safar <marek.safar@seznam.cz>
931 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
932 to newly introduced ctor.
934 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
935 message to one place.
936 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
939 2006-05-07 Marek Safar <marek.safar@seznam.cz>
941 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
943 * ecore.cs (Expression.ResolveAsConstant): Updated.
945 * statement.cs (ResolveMeta): Updated.
947 2006-05-06 Marek Safar <marek.safar@seznam.cz>
949 * cs-parser.jay: __arglist cannot be used in initializer.
951 2006-05-06 Marek Safar <marek.safar@seznam.cz>
954 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
957 2006-05-05 Raja R Harinath <rharinath@novell.com>
959 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
960 (LabeledStatement): Add 'name' parameter.
961 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
962 (Block.AddLabel): Update to changes.
963 * cs-parser.jay (labeled_statement): Likewise.
965 * flowanalysis.cs (BranchingType.Labeled): New.
966 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
967 (FlowBranchingLabeled): New. Does nothing for now, but will
968 eventually handle 'goto' flows.
969 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
970 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
971 that's terminated ...
972 (Block.Resolve): ... here.
974 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
975 (UsageVector.MergeFinallyOrigins): Likewise.
976 (FlowBranching.InTryOrCatch): Likewise.
977 (FlowBranching.AddFinallyVector): Likewise.
978 (FlowBranchingException): Update to changes.
981 * statement.cs (Return.Resolve): Move error checking to ...
982 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
983 (FlowBranchingException): Handle return origins like break and
985 (FlowBranching.UsageVector.CheckOutParameters): Remove.
987 2006-05-04 Marek Safar <marek.safar@seznam.cz>
990 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
993 2006-05-04 Marek Safar <marek.safar@seznam.cz>
996 * class.cs (MethodData.Define): Do public accessor check only when method
997 implements an interface.
999 2006-05-04 Raja R Harinath <rharinath@novell.com>
1001 Remove special handling of 'break'
1002 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
1003 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
1004 (UsageVector.Break): Remove.
1005 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
1007 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
1009 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
1010 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1012 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1015 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1016 be the interface member.
1018 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1021 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1022 for emitting small (int) values.
1024 2006-05-03 Raja R Harinath <rharinath@novell.com>
1027 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1028 control-flow passes through the 'finally' after merging-in all the
1029 control-flows from 'try' and the 'catch' clauses.
1031 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1032 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1033 always true at the only non-recursive entry point.
1034 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1035 FlowBranchingBreakable.
1036 (FlowBranchingLoop): Remove.
1037 * statement.cs (Return.DoResolve): Update to changes.
1040 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1041 (FlowBranching.CreateBranching): Handle it: create a
1042 FlowBranchingContinuable.
1043 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1044 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1045 except that it handles the 'continue' command.
1046 (FlowBranching.UsageVector.MergeOrigins): Rename from
1048 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1049 except that it overrides AddContinueOrigin.
1050 (FlowBranchingException): Override AddContinueOrigin, similar to
1052 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1053 Create a new branching around the embedded statement.
1054 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1055 control flow after the embedded statement.
1056 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1058 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1059 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1060 FlowBranchingBreakable.
1061 (FlowBranchingSwitch): Remove.
1064 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1065 error reporting to ...
1066 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1067 Rename from 'AddBreakVector'. Add new location argument. Return
1068 a bool indicating whether the 'break' crosses an unwind-protect.
1069 (FlowBranchingException.AddBreakOrigin): Add.
1070 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1071 flowbranching after updating with the effects of the 'finally'
1073 (FlowBranchingBreakable): New common base class for
1074 FlowBranchingLoop and FlowBranchingSwitch.
1076 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1078 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1080 2006-05-02 Raja R Harinath <rharinath@novell.com>
1082 * statement.cs (Do.Resolve): If the loop is infinite, set the
1084 (While.Resolve, For.Resolve): Set a barrier after the embedded
1085 statement. There's no direct control flow that goes from the end
1086 of the embedded statement to the end of the loop.
1087 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1088 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1089 above ensure that the reachability is correctly computed.
1091 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1092 (UsageVector.MergeBreakOrigins): If the current path is
1093 unreachable, treat it as if all parameters/locals are initialized.
1094 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1095 infinite loops before merging-in break origins.
1097 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1098 (Reachability.Reachable): Split part into ...
1099 (Reachability.Unreachable): ... this. Simplify.
1100 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1102 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1103 (Reachability.SetThrowsSometimes): Likewise.
1104 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1105 TriState.Always, use corresponding property.
1106 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1107 (Block.Resolve): Likewise. Remove some redundant checks.
1109 2006-05-02 Raja R Harinath <harinath@gmail.com>
1111 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1112 (Reachability.Meet): Don't bother checking AlwaysThrows --
1113 barrier is always set.
1114 (FlowBranchingBlock.Merge): Likewise.
1116 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1118 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1119 defined, so it's references should also compile only for NET_2_0
1120 (as occurs in mcs version)
1122 2006-05-01 Raja R Harinath <harinath@gmail.com>
1124 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1125 checks for unreachable.
1127 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1130 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1132 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1133 whether field is really assigned.
1135 2006-04-30 Raja R Harinath <harinath@gmail.com>
1137 * flowanalysis.cs (Reachability): Make 4-argument constructor
1139 (Reachability.Meet): Rename from 'And'. Remove static variant.
1140 (Reachability.Always): Rename from the highly misleading
1141 'Reachability.Never'.
1142 (FlowBranching.Merge): Update to changes. Mark an impossible
1143 situation with a 'throw'.
1144 (*): Update to changes.
1146 2006-04-29 Raja R Harinath <harinath@gmail.com>
1148 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1150 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1151 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1152 (*): Update to changes.
1153 * statement.cs: Update to changes.
1155 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1158 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1160 2006-04-28 Raja R Harinath <harinath@gmail.com>
1162 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1165 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1166 argument to two arguments: an usage-vector and a bool. Move call
1167 to FlowBranching.Merge () ...
1168 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1170 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1171 handling of loop and switch reachability to ...
1172 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1174 2006-04-27 Raja R Harinath <harinath@gmail.com>
1176 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1177 handling to FlowBranchingLoop.InLoop.
1178 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1180 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1183 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1184 anonymous method is allowed from AnonymousContainer here.
1186 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1188 2006-04-24 Raja R Harinath <rharinath@novell.com>
1191 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1193 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1196 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1197 (DoubleConstant.Reduce): Ditto.
1199 2006-04-23 Raja R Harinath <rharinath@novell.com>
1201 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1202 Remove 'lvalue_right_side' argument. Move parts to ...
1203 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1204 (LocalVariable.DoResolveLValue): ... these.
1206 2006-04-21 Raja R Harinath <rharinath@novell.com>
1209 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1210 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1211 (LocalVariableReference.DoResolveBase): Use it to implement new
1213 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1214 (Argument.Resolve): Simplify. Move CS1510 check ...
1215 * ecore.cs (Expression.ResolveLValue): ... here.
1216 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1217 (PropertyExpr.DoResolveLValue): Likewise.
1218 (FieldExpr.Report_AssignToReadonly): Likewise.
1219 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1220 LValueMemberAccess or LValueMemberOutAccess on instance depending
1222 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1223 DoResolve as appropriate.
1225 2006-04-20 Raja R Harinath <rharinath@novell.com>
1228 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1229 implicit conversions on 'out' and 'ref' arguments.
1231 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1232 improve clarity. Remove dead code.
1235 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1236 (Catch.Resolve): Resolve VarBlock if it exists.
1238 2006-04-19 Miguel de Icaza <miguel@novell.com>
1240 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1241 twice, this was some residual code, the enumerator was emitted
1242 properly in the two branche of if later.
1246 Thanks to Martin for finding the source of the problem
1248 2006-04-19 Raja R Harinath <rharinath@novell.com>
1250 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1251 cast is never an lvalue.
1252 (Cast.DoResolve, Cast.ResolveRest): Combine.
1253 (Argument.Emit): Simplify slightly. Move 'Expr is
1254 IMemoryLocation' check ...
1255 (Argument.Resolve): ... here.
1256 (Argument.Error_LValueRequired): Remove. Inline into only user.
1258 Simplifications. Fix cs0191-2.cs
1259 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1260 CS1649 and CS1651 to ...
1261 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1262 the actual selection of the error code and message to a lookup
1263 table. Add a dummy return value to simplify callsites.
1264 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1265 readonly fields of other instances of the same type. Move CS0197
1267 * expression.cs (Argument.Resolve): ... here. Simplify code.
1268 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1269 resolution of an out or ref argument. The code simplification
1270 above uses this invariant.
1272 2006-04-18 Raja R Harinath <rharinath@novell.com>
1274 Possibly fix #77752. Fix cs1690-[4-7].cs.
1275 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1276 CheckMarshallByRefAccess. Drop parameter.
1277 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1279 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1281 * report.cs (AllWarnings): Add CS1690.
1282 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1284 (LocalVariableReference.DoResolveBase): Update.
1286 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1288 * class.cs (MethodOrOperator): Moved common parts from method class.
1289 detect obsolete attributes.
1290 (Method.Define): Simplified as it reuses code from base.
1291 (Constructor.ValidAttributeTargets): Fixed issue found during
1293 (Destructor.ValidAttributeTargets): Fixed issue found during
1295 (Operator): Finished refactoring set off by #78020. Operator class is now
1296 ordinary method class.
1298 * anonymous.cs: Updated.
1300 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1302 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1304 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1306 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1307 detect obsolete attributes.
1308 (Method.CreateEmitContext): Moved to MethodOrOperator.
1310 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1313 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1314 customized exception to make crash detection easier.
1315 (MethodOrOperator): Started to work on new base class for methods and
1317 (Method): Derives from MethodOrOperator.
1318 (Constructor.Emit): Emits its own attributes.
1319 (AbstractPropertyEventMethod.Emit): Ditto.
1320 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1322 (Operator.Emit): It's temporary more tricky than should be.
1324 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1326 * report.cs (InternalErrorException): Add ctor with inner exception.
1328 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1331 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1334 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1337 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1340 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1342 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1343 attribute is present and Guid not.
1344 (Interface.ApplyAttributeBuilder): Ditto.
1346 * attribute.cs: Add error message.
1348 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1352 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1353 sources (it's composite) so hold them in extra array as they are used in
1354 Emit phase only. It worked in the previous versions by mistake.
1355 (Attribute.Emit): Emit attribute for more owners when exist.
1357 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1358 it has now different behaviour.
1360 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1362 * constant.cs (Constant.IsDefaultInitializer): New method.
1364 * class.cs: Updated.
1366 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1367 re-initialize default values. It saves KBs almost for every assembly.
1368 Thanks Zoltan for the idea.
1369 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1370 (ArrayCreation.DoResolve): Resolve only once.
1371 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1372 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1374 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1376 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1379 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1381 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1382 in an embedded statement too.
1384 2006-04-01 Raja R Harinath <rharinath@novell.com>
1387 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1391 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1394 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1395 arguments before checking whether a type is reflected or not.
1398 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1399 definition doesn't take part in overload resolution.
1400 (Invocation.IsParamsMethodApplicable): Likewise.
1401 (Invocation.OverloadResolve): When replacing a reflected override
1402 method with its base definition, ensure that type arguments are
1405 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1409 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1412 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1414 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1416 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1419 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1420 LocalTemporary change.
1422 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1424 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1425 initializers optimization.
1426 (ClassOrStruct.TypeAttr): Moved from modifiers.
1427 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1428 (FieldBase.ResolveInitializer): Resolves initializer.
1429 (FieldBase.HasDefaultInitializer): New property.
1431 * cs-parser.jay: Removed message.
1433 * expression.cs (CompilerGeneratedThis): New specialization.
1435 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1437 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1439 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1441 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1443 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1444 be now EnumConstants only.
1446 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1448 * attribute.cs, driver.cs: Reset more caches.
1450 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1452 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1454 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1456 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1457 for easier reuse. Updated all overrides.
1458 (IntegralConstant): New base class for all integral constants.
1459 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1460 of the constant range, report custom error.
1461 (UIntConstant.Reduce): Fixed uint conversion.
1463 * ecore.cs, literal.cs: Reduce updates.
1465 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1469 * class.cs (Constructor.Define): Removed extra if for default ctors.
1470 A patch from Atsushi Enomoto.
1472 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1474 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1475 GetAttributableValue.
1477 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1480 * convert.cs (ImplicitConversionRequired): Error message moved to
1483 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1484 automatic implicit conversion of an output value.
1485 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1487 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1489 (TypeOf.GetAttributableValue): Add extra handling for object type.
1491 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1492 special error message.
1494 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1496 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1498 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1499 compatible with MS runtime.
1501 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1503 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1504 attribute arguments here.
1506 * class.cs (Indexer.Define): The check was moved to attribute class.
1508 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1510 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1512 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1514 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1516 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1519 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1521 * doc-bootstrap.cs : fix build.
1523 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1525 * expression.cs (StringConcat.Append): Issue a warning when empty string
1528 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1530 * assign.cs (CompoundAssign.ResolveSource): Removed.
1532 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1535 * class.cs (TypeContainer.FindMethods): Removed.
1536 (TypeContainer.CheckMemberUsage): Made static.
1538 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1540 * constant.cs (CheckRange): Removed unused type argument.
1541 (CheckUnsigned): Removed unused type argument.
1543 * cs-parser.jay: Updated after MemberAccess clean up.
1544 Uses Length for empty string test.
1546 * cs-tokenizer.cs: Uses Length for empty string test.
1547 (IsCastToken): Made static.
1548 (is_hex): Made static.
1549 (real_type_suffix): Made static.
1551 * decl.cs (SetupCache): Made static.
1552 (OnGenerateDocComment): Removed unused ds argument.
1554 * delegate.cs (VerifyDelegate): Removed unused argument.
1556 * doc.cs: Uses Length for empty string test.
1558 * driver.cs: Uses Length for empty string test.
1560 * enum.cs (IsValidEnumType): Made static
1562 * expression.cs (EnumLiftUp): Removed unused argument.
1563 (ResolveMethodGroup): Ditto.
1564 (BetterConversion): Ditto.
1565 (GetVarargsTypes): Ditto.
1566 (UpdateIndices): Ditto.
1567 (ValidateInitializers): Ditto.
1568 (MemberAccess.ctor): Ditto.
1569 (GetIndexersForType): Ditto.
1571 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1573 * iterators.cs: Updated after MemberAccess clean up.
1575 * location.cs: Uses Length for empty string test.
1577 * namespace.cs: Uses Length for empty string test.
1579 * report.cs (CheckWarningCode): Made static.
1581 * statement.cs (LabeledStatement): Removed unused argument.
1583 * typemanager.cs (FilterNone): Removed.
1585 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1587 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1590 * class.cs: Updated.
1592 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1594 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1596 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1600 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1602 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1603 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1604 Add more error reporting; Fixed issue with params.
1606 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1608 * cs-parser.jay: AnonymousMethod requires host container.
1610 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1612 2006-03-18 Raja R Harinath <harinath@gmail.com>
1614 * class.cs: Change 'TypeContainer ds' constructor argument to
1615 'DeclSpace parent'. Some classes were missed below due to
1616 different naming convention.
1618 * class.cs (MemberCore.Parent): Delete. This makes the
1619 ParentContainer changes below enforceable by the compiler.
1621 Treat pointers to enclosing declaration space as 'DeclSpace', not
1623 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
1624 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
1626 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
1628 (Block.AddThisVariable): Likewise.
1629 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
1630 (AbstractPropertyEventMethod.Emit): Likewise.
1631 (AbstractPropertyEventMethod.EmitMethod): Likewise.
1632 (GetMethod.Define, SetMethod.Define): Likewise.
1633 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
1634 (DelegateMethod.EmitMethod): Likewise.
1636 Fix regression test-partial-13.cs.
1637 Rationalize use of PartialContainer. Ensure that the partial
1638 class semantics can be tied to type-correctness, i.e., any
1639 violation will cause a compile error.
1640 * class.cs, const.cs: Access all fields that belong to class
1641 TypeContainer via ParentContainer. Arguments of EmitContexts and
1642 Resolve()-like functions still use 'Parent'.
1644 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
1645 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
1646 (PropertyMethod.CheckModifiers): Remove unused argument.
1647 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
1650 2006-03-28 Raja R Harinath <rharinath@novell.com>
1652 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
1654 2006-03-17 Raja R Harinath <harinath@gmail.com>
1656 Make semantics of PartialContainer simpler.
1657 * decl.cs (DeclSpace.IsPartial): Remove.
1658 * class.cs (TypeContainer.IsPartial): Likewise.
1659 (TypeContainer..ctor): Set PartialContainer to point to self.
1660 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
1661 (TypeContainer.FindNestedType): Likewise.
1662 (MemberCore.ParentContainer): Simplify. Remove deprecation.
1664 2006-03-17 Marek Safar <marek.safar@seznam.cz>
1666 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
1668 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1670 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
1673 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1675 * class.cs (Operator.Define): An error for base conversion was not
1678 2006-03-13 Marek Safar <marek.safar@seznam.cz>
1680 A fix for #77593, #77574.
1682 * class.cs (MethodCore.CheckBase): Another if for operator.
1684 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1688 * expression.cs (VerifyArgumentsCompat): Reverted to double error
1689 reporting, it's more tricky than I thought.
1691 2006-03-09 Marek Safar <marek.safar@seznam.cz>
1693 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
1696 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
1697 (DelegateCreation.ImplicitStandardConversionExists): New method for just
1700 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
1703 2006-03-04 Marek Safar <marek.safar@seznam.cz>
1707 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
1708 (Event.Define): ditto
1709 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
1711 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
1712 Removed redundant code and set NewSlot for Invoke method too.
1714 * parameter.cs (Parameters.ctor): Add custom, type ctor.
1715 (Parameters.MergeGenerated): New method. Use this method when you merge
1716 compiler generated argument with user arguments.
1718 2006-03-03 Marek Safar <marek.safar@seznam.cz>
1720 * attribute.cs (ResolveAsTypeTerminal): Removed.
1722 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
1723 specialization for predefined types; 30% speed up.
1724 Finally placed obsolete check to right place.
1725 (Expression.ResolveType): Removed.
1727 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
1728 Updated after ResolveType was removed.
1730 * expression.cs (Cast.ctor): Check void cast.
1731 (Binary.ResolveAsTypeTerminal): Is never type.
1732 (Conditional.ResolveAsTypeTerminal): Is never type.
1734 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
1736 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1738 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
1740 2006-03-23 Martin Baulig <martin@ximian.com>
1742 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
1743 type check if either of the types is an open generic type.
1745 2006-03-23 Martin Baulig <martin@ximian.com>
1748 (Convert.ExplicitTypeParameterConversion): New method; implement
1749 explicit type parameter conversions.
1751 2006-03-23 Martin Baulig <martin@ximian.com>
1753 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
1754 blindly allow all conversions if we do not have any constraints.
1756 2006-02-27 Marek Safar <marek.safar@seznam.cz>
1758 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
1759 these two separated members to simplify the code.
1760 (Attribute.Resolve): Refactored to use new fields and methods.
1761 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
1762 implemented obsolete attribute checking.
1763 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
1764 implemented obsolete checking again. It look line never ending quest ;-)
1765 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
1767 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
1769 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
1771 *class.cs (Property.Define): Add RegisterProperty call.
1773 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
1774 argument groups (only 2).
1776 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
1777 encoding expression to arguments.
1778 (Expression.ExprClassToResolveFlags): Just turned to property.
1780 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
1781 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
1782 optimized as well as implemented support for zero-length attributes.
1784 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
1785 Add caching of PropertyInfo's.
1787 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1789 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
1790 error multiple times.
1792 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1794 New partial class implementation.
1795 A fix for #77027, #77029, #77403
1797 * attribute.cs (Attributable): Made attributes protected.
1799 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
1800 the replacements of ClassPart and PartialContainer.
1801 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
1802 (TypeContainer.AddInterface): Ditto.
1803 (TypeContainer.AddPartial): The main method for partial classes. It checks
1804 for errors and merges ModFlags and attributes. At the end class is added to
1806 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
1808 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
1809 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
1810 from the rest of partial classes.
1811 (TypeContainer.GetClassBases): Simplified.
1812 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
1814 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
1815 (TypeContainer.HasExplicitLayout): Uses Flags now.
1816 (PartialContainer): Removed.
1817 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
1818 (StaticClass): Was merged with Class.
1819 (Class.GetClassBases): class and static class bases are verified here.
1820 (Class.TypeAttr): Added static attributes when class is static.
1821 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
1822 (MemberBase): In some cases we need to call parent container for partial
1823 class. It should be eliminated but it's not easy now.
1825 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
1827 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
1828 partial classed to accumulate class comments.
1829 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
1831 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
1833 * driver.cs (MainDriver): Tree.GetDecl was removed.
1835 * modifiers.cs (Modifiers): Add partial modifier.
1837 * tree.cs (Tree.decl): Removed.
1838 (RootTypes): Started to use this class more often for root types
1841 2006-03-23 Raja R Harinath <rharinath@novell.com>
1843 * generic.cs (TypeParameter.UpdateConstraints): Update
1844 'constraints' if null.
1846 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1850 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
1851 external interface does not have an attribute.
1853 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1855 Another prerequisites for new partial classs implementation.
1857 * attribute.cs (Attribute.Equal): Implemented.
1858 (Attribute.Emit): Changed as attributes can be applied more than twice.
1859 (Attributes.Emit): Check for duplicate attributes here.
1861 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
1862 as a parameter, clean-up.
1864 2006-02-11 Marek Safar <marek.safar@seznam.cz>
1868 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
1869 contains obsolete attribute check which can in some cases look for base
1870 type of current class which is not initialized yet.
1871 (TypeContainer.BaseType): Replacement of ptype.
1873 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
1875 2006-02-11 Marek Safar <marek.safar@seznam.cz>
1877 First of prerequisites for new partial classs implemention.
1879 * attribute.cs (Attributable): Extended by ResolveContext;
1880 Attributes finally have correct context for resolving in all cases.
1881 (AttachTo): Attribute owner is assigned here.
1883 * codegen.cs (IResolveContext): Introduce new interface to hold
1884 all information needed in resolving phase.
1885 (EmitContext): Implements IResolveContext; more clean-up needed here.
1887 * decl.cs (MemberCore): Implemented IResolveContext.
1889 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
1890 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
1891 parameter.cs, statement.cs, tree.cs, typemanager.cs:
1892 Refactored to use new IResolveContext instead of EmitContext; cleanup
1894 2006-03-22 Raja R Harinath <rharinath@novell.com>
1896 Support ParameterDefaultValueAttribute in gmcs. Also applied to
1897 mcs to keep code differences small.
1898 * attribute.cs (Attribute.GetParameterDefaultValue): New.
1899 * typemanager.cs (parameter_default_value_attribute_type): New.
1900 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
1903 2006-03-22 Martin Baulig <martin@ximian.com>
1906 (Nullable.NullableLiteral): Derive from `NullLiteral'.
1909 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
1910 instead of the normal `NullLiteral'.
1912 2006-03-21 Martin Baulig <martin@ximian.com>
1915 * generic.cs (TypeManager.InferType): If `pt' is a generic
1916 parameter, don't check whether `pt == at'.
1918 2006-03-20 Raja R Harinath <rharinath@novell.com>
1921 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
1922 (TypeParameter.Resolve): Update to change.
1923 (ConstraintChecker.CheckConstraints): Resolve type-argument
1924 constraints before use.
1926 2006-03-16 Martin Baulig <martin@ximian.com>
1929 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
1930 and don't have any instance constructors, also lookup in the base class.
1931 (TypeManager.IsNullableValueType): New public method.
1933 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
1934 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
1935 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
1937 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
1938 instead of just TypeManager.IsNullableType() to determine whether
1939 a lifted operator exists.
1940 (UnaryMutator.DoResolve): Likewise.
1941 (Conditional.DoResolve): Likewise.
1942 (Binary.DoResolve): A lifted operator only exists if both operands
1943 are valuetypes and at least one of them is a nullable type.
1945 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
1947 * iterator.cs : yield break is allowed in try statement which has
1948 catch clauses. Fixed bug #77767.
1950 2006-03-12 Martin Baulig <martin@ximian.com>
1952 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
1953 private IsSignatureEqual() to compare types; see the comment in
1954 that method; fixes #77674.
1956 2006-03-10 Raja R Harinath <rharinath@novell.com>
1958 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
1959 (Expression.ResolveAsTypeTerminal): Likewise.
1960 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
1961 * expression.cs, generic.cs, iterators.cs: Likewise.
1962 * parameter.cs, statement.cs, typemanager.cs: Likewise.
1964 2006-03-09 Martin Baulig <martin@ximian.com>
1966 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
1967 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
1969 2006-03-09 Martin Baulig <martin@ximian.com>
1971 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
1972 `prepared' flag is set.
1974 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
1975 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
1976 issues; see gtest-254.cs.
1978 2006-03-07 Martin Baulig <martin@ximian.com>
1980 * generic.cs (TypeManager.InferType): Allow infering
1981 `IEnumerable<T>' with an array of T; see gtest-251.cs.
1983 2006-03-06 Martin Baulig <martin@ximian.com>
1986 (TypeManager.InferType): Fix gtest-250.cs.
1989 (TypeManager.IsSubclassOf): Also check the base class.
1992 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
1995 2006-03-01 Raja R Harinath <rharinath@novell.com>
1998 * expression.cs (ParameterReference.DoResolveBase): Change return
2000 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
2004 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
2007 * typemanager.cs (GetFullNameSignature): Don't nullref on
2008 protected accessors.
2010 2006-02-16 Martin Baulig <martin@ximian.com>
2013 (TypeManager.GetGenericFieldDefinition): New public method; use it
2014 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2016 2006-02-14 Martin Baulig <martin@ximian.com>
2018 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2020 2006-02-14 Martin Baulig <martin@ximian.com>
2023 (TypeManager.DropGenericMethodArguments): New public method; don't
2024 use GetGenericMethodDefinition() on something which is not a
2027 2006-02-14 Martin Baulig <martin@ximian.com>
2030 (ConstraintChecker.CheckConstraints): If a type parameter has the
2031 `struct' constraint, the type must be a non-nullable valuetype.
2033 2006-02-10 Martin Baulig <martin@ximian.com>
2036 (TypeManager.IsOverride): Make this work for instantiated methods
2037 in a generic class; fixes #77509.
2038 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2039 rather than calling it directly; fixes #77488.
2041 2006-02-08 Martin Baulig <martin@ximian.com>
2043 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2044 reporting into CheckConstraint() so we can use the correctly
2047 2006-02-08 Martin Baulig <martin@ximian.com>
2049 * expression.cs (BaseAccess): Add support for generic methods.
2051 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2052 the new MethodGroupExpr.
2054 2006-02-07 Martin Baulig <martin@ximian.com>
2056 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2057 also reference types; fixes #77483.
2059 2006-02-07 Martin Baulig <martin@ximian.com>
2062 (TypeManager.IsGenericMethod): We now return whether something is
2063 an instantiated generic method (and not a generic method def).
2064 (TypeManager.IsGenericMethodDefinition): New public method.
2067 (TypeManager.CSharpSignature): Only include type arguments for
2068 "real" generic methods, not for any instantiated method.
2069 (TypeManager.GetMethodName): Likewise, but also allow generic
2070 method definitions here.
2072 2006-02-06 Miguel de Icaza <miguel@novell.com>
2074 * codegen.cs (EmitScopeInitFromBlock): check here the
2075 capture_context, there is no need to make two calls to the
2078 * anonymous.cs: Add some debugging messages that might help me
2079 track other instances of this problem in the future (the
2080 regression of test 467).
2082 * cs-parser.jay: track the variable block, as we need to initalize
2083 any captured variables declared in this block for the "catch"
2084 portion of the "Try" statement.
2086 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2087 scope initialization for captured variables.
2089 Also, move the emit for the variables after the block location has
2092 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2094 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2096 2006-02-06 Martin Baulig <martin@ximian.com>
2098 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2099 `TypeManager.value_type' as parent type to
2100 ModuleBuilder.DefineType(). Fixes #77358.
2102 2006-02-02 Miguel de Icaza <miguel@novell.com>
2104 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2105 commit yesterday, the initialization for the roots is necessary.
2106 What is not necessary is the scope activation.
2108 2006-02-02 Raja R Harinath <rharinath@novell.com>
2110 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2111 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2113 (Argument.Resolve): Remove CS0206 checks.
2115 2006-02-01 Miguel de Icaza <miguel@novell.com>
2117 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2118 scopes for all the roots, the scopes will now be emitted when the
2119 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2121 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2122 code. This reduces a lot of existing cruft.
2124 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2125 that the ScopeInfo is generated as we enter the scope, not at the
2126 time of use, which is what we used to do before.
2128 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2129 every time a Block is about to be emitted if we have a
2132 2006-02-01 Raja R Harinath <rharinath@novell.com>
2134 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2135 attribute for mscorlib too.
2137 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2139 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2141 * typemanager.cs (cons_param_array_attribute): Make private.
2142 (Reset): Set it to null.
2143 (InitCoreHelpers): Don't initialize it.
2144 (ConsParamArrayAttribute): New. Initialize it as needed.
2145 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2147 2006-01-31 Miguel de Icaza <miguel@novell.com>
2149 * expression.cs: There might be errors reported during the
2150 selection of applicable methods. If there are errors, do not
2151 continue execution as it will lead the compiler to crash.
2153 2006-01-30 Miguel de Icaza <miguel@novell.com>
2155 * expression.cs: Member access is not allowed on anonymous
2156 methods. Fixes #77402.
2158 2006-01-30 Raja R Harinath <rharinath@novell.com>
2161 * cs-parser.jay (VariableDeclaration): Don't set
2162 current_array_type to null.
2163 (field_declaration, event_declaration, declaration_statement):
2164 Set it to null here.
2166 2006-01-29 Raja R Harinath <harinath@gmail.com>
2169 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2171 2006-01-28 Raja R Harinath <harinath@gmail.com>
2173 * typemanager.cs (GenericParameterPosition): New.
2176 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2178 * doc.cs : To process "include" elements, first we should create
2179 another list than XmlNodeList, because it could result in node
2180 removal, which could result in that the XmlNodeList gives up
2183 2006-01-25 Miguel de Icaza <miguel@novell.com>
2185 * expression.cs: Introduce an error report that we were not
2186 catching before. Gonzalo ran into it.
2188 2006-01-23 Miguel de Icaza <miguel@novell.com>
2190 A fix for bug: #76957
2192 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2193 ComputeMethodHost before creating the method, this is a new
2196 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2197 that this method references (RegisterScope). The actual scope
2198 where the method is hosted is computed with the ComputeMethodHost
2199 before we create the method.
2201 Moved the Deepest routine here.
2203 (AnonymousContainer.ComputeMethodHost): New routine used to
2204 compute the proper ScopeInfo that will host the anonymous method.
2206 (ScopeInfo): Deal with multiple roots. The problem was that we
2207 did not have a unique root where all ScopeInfos could be hanged
2208 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2211 Remove AdjustMethodScope which is now computed at the end. Remove
2212 LinkScope which did a partial link, instead link all ScopeInfos
2213 before code generation from the new "LinkScopes" routine.
2215 Simplify all the Add* routines as they no longer need to maintain
2216 the tree, they just need to record that they are using variables
2219 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2220 routines to produce the forest of ScopeInfo trees.
2222 * class.cs (TypeContainer.AppendMethod): This is just like
2223 AddMethod, but ensures that an interface implementation method
2224 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2225 methods, but at the end.
2227 We use this functionality to ensure that the generated MoveNext
2228 method in the iterator class is resolved/emitted before the
2229 enumerator methods created.
2231 This is required because the MoveNext method computes the right
2232 ScopeInfo for the method. And the other methods will eventually
2233 need to resolve and fetch information computed from the anonymous
2237 2006-01-23 Raja R Harinath <rharinath@novell.com>
2239 Improve implementation of section 14.4.2.2 (Better function member).
2240 * expression.cs (Invocation.MoreSpecific): Compare all type
2241 arguments before deciding if one type is more specific than
2242 another. Handle array types too. Return the more specific type.
2243 (Invocation.BetterFunction): Add more tie-breaking rules from
2244 section 14.4.2.2. Perform "more specific" check after
2245 other tie-breaking rules. Compare all parameter types before
2246 choosing the "more specific" method.
2248 2006-01-21 Raja R Harinath <harinath@gmail.com>
2249 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2252 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2254 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2255 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2257 2006-01-18 Martin Baulig <martin@ximian.com>
2259 * class.cs (TypeContainer.AddToMemberContainer): Use
2260 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2263 2006-01-18 Martin Baulig <martin@ximian.com>
2265 Fix #76417: a generic class may now have methods which may unify
2266 for some type parameter substitutions.
2268 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2269 for methods which may unify anymore.
2271 * expression.cs (Invocation.MoreSpecific): New private static
2272 method; checks whether one method is more specific than another
2273 according to 14.4.2.2 of the spec.
2274 (Invocation.BetterFunction): Implement the tie-breaking rules from
2275 14.4.2.2 of the spec: if two methods unify for some type parameter
2276 substitution, we need to pick the more specific one.
2278 2006-01-18 Raja R Harinath <rharinath@novell.com>
2280 Fix #76656, cs0231-2.cs.
2281 * cs-parser.jay (formal_parameter_list): Make error case catch
2283 (parenthesized_expression_0): Add CS1026 check.
2284 (invocation_expression): Remove unused { $$ = lexer.Location }.
2286 2006-01-17 Raja R Harinath <rharinath@novell.com>
2289 * cs-parser.jay (statement_expression): Don't list out the
2290 individual statement-expressions. Convert syntax error into
2293 2006-01-16 Raja R Harinath <rharinath@novell.com>
2296 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2297 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2298 CheckIntermediateModification.
2299 (FieldExpr.DoResolve): Add new two-argument version that
2300 allows us to resolve the InstanceExpression as an lvalue.
2301 The one-argument variant is now just a wrapper.
2302 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2303 Resolve the lhs as an lvalue if the it has a value type.
2304 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2305 from Assign.DoResolve.
2306 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2307 resolved as an lvalue.
2308 (PropertyExpr.DoResolve): Update.
2309 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2310 has a value type. Move CS1612 check here from
2311 CheckIntermediateModification.
2312 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2313 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2314 'right_side' of a ResolveLValue on an 'out' argument.
2315 (EmptyExpression.LValueMemberAccess): New. Used as the
2316 'right_side' of a propagated ResolveLValue on a value type.
2317 (LocalVariableReference.DoResolveBase): Recognize
2318 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2320 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2321 EmptyExpression.Null.
2323 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2325 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2326 Type.IsGenericParameter(). Fixed bug #77183.
2327 * doc.cs : it is now identical to doc.cs in mcs.
2329 2006-01-16 Martin Baulig <martin@ximian.com>
2331 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2333 2006-01-16 Martin Baulig <martin@ximian.com>
2335 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2336 ctors; fixes #77250.
2338 2006-01-12 Miguel de Icaza <miguel@novell.com>
2340 This fixes the problem where we used ldfld instead of ldflda to
2341 load the "THIS" pointer on captured parameters, when THIS is a
2342 value type. See bug #77205.
2344 * iterators.cs (CapturedThisReference.Emit): Pass false to
2345 EmitThis (we do not need the address).
2347 * codegen.cs (EmitThis): it needs to know whether we need the
2348 address of `this' or not. This is used by value types.
2350 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2351 every other call passes false.
2353 2006-01-12 Raja R Harinath <rharinath@novell.com>
2356 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2358 * expression.cs (Invocation.OverloadResolve): Update.
2359 (Invocation.DoResolve): Avoid double resolution of invocation.
2361 2006-01-11 Raja R Harinath <rharinath@novell.com>
2364 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2365 unary negation of floating point types as 0-expr; negation cannot
2366 overflow in floating point types.
2369 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2370 on operands of 'void' type.
2373 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2374 and ExclusiveOr for boolean constants too.
2376 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2378 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2380 2006-01-12 Miguel de Icaza <miguel@novell.com>
2382 * cs-tokenizer.cs (Position): New class used to save and restore
2383 the position state in the tokenizer. Before this patch the save
2384 and restore was not complete enough so the line and columns would
2385 start to drift and the debugger and stack traces will get the
2388 2006-01-10 Martin Baulig <martin@ximian.com>
2391 (TypeParameter.InflateConstraints): New public method.
2393 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2394 constraints; fixes #77042.
2396 2006-01-10 Martin Baulig <martin@ximian.com>
2398 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2399 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2402 2006-01-09 Raja R Harinath <rharinath@novell.com>
2405 * expression.cs (Invocation.OverloadResolve): Replace reflected
2406 override methods with their base virtual methods, rather than
2408 * typemanager.cs (TypeManager.GetOverride): New.
2410 2005-12-21 Miguel de Icaza <miguel@novell.com>
2412 * driver.cs: Report the case of no source files and no -out:
2415 2005-12-20 Raja R Harinath <rharinath@novell.com>
2418 * expression.cs (ComposedCast.GetSignatureForError): Define.
2420 2006-01-05 Jb Evain <jbevain@gmail.com>
2422 * class.cs (Property.Define, Indexer.Define): do not tag the
2423 properties as SpecialName | RTSpecialName.
2425 2006-01-04 Miguel de Icaza <miguel@novell.com>
2427 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2428 doing a low-level comparission of parameter types. It was lacking
2429 a check for __argslist.
2431 2005-12-30 Miguel de Icaza <miguel@novell.com>
2433 * expression.cs (ParameterReference.DoResolveBase): Allow
2434 reference parameters if they are local to this block.
2436 This allows the ref and out parameters of a delegate to be used in
2437 an anonymous method, for example:
2439 delegate void set (out int x);
2441 set s = delegate (out int x){
2445 This is used by functionality introduced late in the C# language.
2447 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2448 method that take ref and out parameters.
2450 Fixes #77119 which was a late change in the spec.
2452 2005-12-23 Miguel de Icaza <miguel@novell.com>
2454 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2455 parent if its the same scope. Fixes #77060.
2457 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2459 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2461 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2463 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2464 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2465 that doesn't contain the full public key. This is a update of the
2466 friend assemblies in .Net 2.0 release.
2468 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2472 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2473 ListDictionary, to contain the ExternAliasEntry entries (in
2474 addition to the NamespaceEntry.aliases hashtable). This field is
2475 shared between the original entry and its doppelganger (bodyless
2477 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2478 extern_aliases field.
2479 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2480 lookup in extern_aliases.
2482 2005-12-16 Raja R Harinath <rharinath@novell.com>
2485 * class.cs (TypeContainer.Mark_HasEquals): New.
2486 (TypeContainer.Mark_HasGetHashCode): New.
2487 (ClassPart): Override them.
2488 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2490 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2491 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2495 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2496 'parent' argument to the base constructor.
2498 Remove all mention of TypeContainer from decl.cs.
2499 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2500 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2501 (DeclSpace.DeclSpace): Likewise.
2502 (DeclSpace.DefineMembers): Remove unused argument.
2503 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2504 debugging check -- we don't care if the debug code throws an
2505 InvalidCastException instead of an InternalErrorException.
2506 * class.cs (TypeContainer.DefineMembers): Update to changes.
2507 (TypeContainer.DoDefineMembers): Likewise.
2508 (TypeContainer.GetMethods): Likewise.
2509 (PropertyMember.Define): Likewise.
2510 (MemberBase.Parent): New property that forwards to
2511 MemberCore.Parent, but ensures that we get a TypeContainer.
2512 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2513 (RootContext.PopulateTypes): Likewise. Remove special case code
2514 for !RootContext.StdLib: DefineMembers is idempotent.
2516 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2518 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2520 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2522 * doc.cs : The search for referenced namespace was insufficient to
2523 get global one as it used to do. Fixed bug #76965.
2525 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2527 * doc.cs : check name in cref in the last phase that whether it is
2530 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2532 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2535 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2537 * doc.cs : so it turned out that we cannot skip override check for
2538 interface members. Fixed bug #76954.
2540 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2542 * cs-tokenizer.cs : fixed bug #75984:
2543 - #warning and #error should not be handled when the source line
2545 - #line is not checked strictly when the source line is disabled.
2546 - #define and #undef is on the other hand checked strictly at any
2549 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2551 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2554 2005-12-15 Raja R Harinath <rharinath@novell.com>
2556 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2558 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2561 2005-12-14 Martin Baulig <martin@ximian.com>
2563 * typemanager.cs (TypeManager.GetFullName): Make this public;
2564 `Type.Fullname' now never returns null.
2566 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2567 explicit interface implementations; we're now using the same
2568 naming convention than csc does.
2570 2005-12-14 Miguel de Icaza <miguel@novell.com>
2572 * convert.cs (ExplicitConversionCore): Check the return value from
2573 ExplicitConversionCore which can return null on failure. Fixes #76914
2575 2005-12-09 Raja R Harinath <rharinath@novell.com>
2577 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2578 instead of IsGenericInstance.
2579 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2580 code that's now covered by the more general test.
2581 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2583 * generic.cs (DropGenericTypeArguments): New. Captures the common
2584 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2585 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2586 * generic.cs, report.cs, typemanager.cs: Likewise.
2588 2005-12-08 Martin Baulig <martin@ximian.com>
2590 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2592 * typemanager.cs (TypeManager.CSharpSignature): Include type
2593 arguments in the signature of a generic method.
2595 2005-12-07 Martin Baulig <martin@ximian.com>
2597 Add support for custom attributes on type parameters.
2599 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2601 * generic.cs (TypeParameterName): New public class; we use this
2602 instead of a `string' to store the name of a type parameter, so we
2603 can also have `Attributes'.
2604 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2605 array instead of a `string[]' array.
2606 (TypeParameter.ctor): We now also take an `Attributes' argument.
2607 (TypeParameter.EmitAttributes): New public method; emit our
2608 `OptAttributes' here.
2609 (GenericMethod.EmitAttributes): New public method; emit the custom
2610 attributes on all our type parameters.
2612 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2613 our type parameters.
2614 (MethodData.Define): If we're a generic method, call
2615 EmitAttributes() on it.
2617 2005-12-07 Martin Baulig <martin@ximian.com>
2620 (ConstraintChecker): New public abstract class; move the
2621 constraint checking here from `ConstructedType' and also do
2622 constraint checking for generic methods here.
2624 * expression.cs (Invocation.OverloadResolve): Use
2625 ConstraintChecker.CheckConstraints() if we resolved to a generic
2628 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2630 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
2632 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
2634 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
2635 (FieldBase.Initializer): Initializer is now optional.
2636 (EventField.Define): Only event field can have initializer.
2638 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
2640 * const.cs (Const): Reuse initializer.
2642 * cs-parser.jay: Updated after FieldBase changes.
2643 Added current_array_type to simplify array initializers.
2645 * ecore.cs (NullCast.IsDefaultValue): Implemented.
2647 * expression.cs, iterators.cs: Updated.
2649 * namespace.cs (NamespaceEntry): Made UsingFound private.
2651 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2653 * parameterCollection.cs: Obsolete, removed.
2654 * parser.cs: Obsolete, removed.
2656 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2659 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
2661 * enum.cs (Enum.Define): Set obsolete context here.
2663 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2666 - FindDocumentedMember() now expects 1) paramList as null
2667 when "we don't have to check the number of parameters" and
2668 2) Type.EmptyTypes when "there is no arguments".
2669 - Introduced FoundMember struct to hold the exact type which was
2670 used to find the documented member (the above change broke
2671 test-xml-044; it might be better just to use DeclaringType than
2672 what MS does, like this change does, but it depends on usage.)
2674 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2676 * doc.cs : documented member might be from DeclaringType for nested
2677 types. Fixed bug #76782.
2679 2005-12-03 Ben Maurer <bmaurer@ximian.com>
2681 * anonymous.cs: Have the param code handle leaving copies on the
2682 stack etc. Allows anonymous params to take part in the assignment
2683 code (++, +=, etc). Fixes bug #76550
2685 * expression.cs: Handle the prepare_for_load/leave_copy by passing
2686 it down to the anon code.
2688 * iterators.cs: Use dummy var here
2690 * codegen.cs: Handle new vars
2692 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2695 * class.cs (MethodData.Define): Set proper Obsolete context.
2697 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
2699 (FieldExpr.DoResolve): Ditto.
2701 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2704 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
2705 parent is not obsolete.
2707 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
2709 * doc.cs : (FindDocumentedMember) find parameterless members first
2710 and get CS0419 in the early stage. Fixed first case of bug #76727.
2712 2005-11-30 Marek Safar <marek.safar@seznam.cz>
2715 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
2716 no error was reported.
2718 *expression.cs (Binary.DoResolve): left can be null.
2720 2005-12-06 Raja R Harinath <rharinath@novell.com>
2722 * class.cs (MethodCore.CheckGenericOverride): Delete unused
2723 abstract method and all overrides.
2724 * support.cs (ParameterData.GenericConstraints): Delete.
2725 (ReflectionParameters.type_params): Delete.
2726 (ReflectionParameters.ReflectionParameters): Make private.
2727 (ReflectionParameters.GetConstaints): New factory method.
2728 * generic.cs (TypeParameterDefineType): Use it.
2729 (TypeManager.GetTypeParameterConstraints): Likewise.
2731 2005-11-22 Marek Safar <marek.safar@seznam.cz>
2734 * class.cs (MethodData.Emit): Parameters should be labeled first.
2736 2005-11-21 Marek Safar <marek.safar@seznam.cz>
2739 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
2741 2005-11-18 Marek Safar <marek.safar@seznam.cz>
2743 * attribute.cs (AreParametersCompliant): Moved to Parameter.
2745 * class.cs (MethodCore): Parameter clean up.
2746 (IMethodData): Added ParameterInfo.
2747 (MethodData): Parameter clean up.
2748 (Indexer.Define): Parameter clean up.
2760 * typemanager.cs: Parameter clean up.
2762 * delegate.cs (Define): Get rid of duplicated code.
2764 * expression.cs (ParameterReference): Removed useless parameters
2766 (Invocation): Ditto.
2768 * parameter.cs (ParamsParameter): New class, params specialization.
2769 (ArglistParameter): Attemp to separate arglist.
2770 (Parameter): Refactored to be reusable and faster.
2771 (Parameter.Modifier): Made understandable.
2772 (Parameters): Changed to be used as a class for `this' assembly
2773 parameters. Refactored to use new specialized classes.
2775 * support.cs (ParameterData): Added Types property.
2776 (InternalParameters): Deleted.
2778 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2780 * doc.cs : the previous patch does not actually fix the bug.
2781 PropertyInfo override check is now implemented and really fixed it.
2782 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
2784 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2786 * doc.cs : apply "override filter" also to properties.
2789 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2791 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
2792 no need to check overrides. For classes, omit those results from
2793 interfaces since they must exist in the class. Fixed bug #76726.
2795 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2797 * typemanager.cs : (GetFullNameSignature) differentiate indexers
2798 with different parameters. Fixed the second problem in #76685.
2800 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2802 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
2803 get expected 'protected' access in CheckValidFamilyAccess()).
2806 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2808 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
2809 Fixed bug #76705. CS1569 was incorrectly commented out.
2811 2005-11-23 Martin Baulig <martin@ximian.com>
2813 * generic.cs (Constraints.Define): Removed.
2814 (TypeParameter.DefineConstraints): Removed.
2815 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
2816 on the GenericTypeParameterBuilder here.
2818 2005-11-23 Martin Baulig <martin@ximian.com>
2820 * typemanager.cs (TypeManager.GetProperty): Make this public.
2822 * generic.cs (Nullable.NullableInfo.ctor): Use
2823 TypeManager.GetProperty() rather than using reflection directly.
2825 2005-11-17 Martin Baulig <martin@ximian.com>
2827 * expression.cs (Indexers.GetIndexersForType): Added support for
2828 generic parameters; fixes #76587.
2830 2005-11-17 Martin Baulig <martin@ximian.com>
2833 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
2834 inherit the scope from our parent. Fixes #76653.
2836 2005-11-15 Martin Baulig <martin@ximian.com>
2838 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
2839 instead of `ScopeTypeBuilder' to refer to the "current" type.
2840 (AnonymousMethod.CreateScopeType): Correctly create the helper
2841 class if we're inside a generic type definition.
2843 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2845 * doc.cs : use Invocation.IsOverride() to do real override check.
2846 * expression.cs : made Invocation.IsOverride() internal.
2848 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2850 * doc.cs : use TypeManager.FindMembers() instead of (possible)
2851 TypeBuilder.FindMembers() and filter overriden base members out.
2854 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2856 * doc.cs : ref/out parameters are represented as '@' (instead of
2857 '&' in type FullName). Fixed bug #76630 (additionally crefs).
2859 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2861 * doc.cs : when there was no '.' in cref to methods in doc comment,
2862 then parameters were missing in the output. Fixed bug #76691.
2864 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2866 * driver.cs : don't output docs when there is an error.
2869 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2872 Now it should detect indexers. Fixed primary concern in bug #76685.
2873 Fixed CS0419 message to not show the identical member signature in
2876 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2878 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
2879 instead of Type.FindMembers() since it does not handle events.
2882 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
2884 * codegen.cs: Fixed typo (speficied -> specified).
2886 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2889 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
2891 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2893 * attribute.cs: Changed error message.
2895 * cs-tokenizer.cs: One more check.
2897 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2899 * statement.cs (Block.Resolve): Ignore empty statement.
2901 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2903 * report.cs: Made error/warning methods more strict to avoid
2906 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
2907 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
2908 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
2909 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
2911 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2913 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
2914 Use the more explicit AssemblyName.FullName instead of
2915 AssemblyName.Name to report errors.
2917 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2919 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
2922 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2932 * report.cs: Fixed error reporting and typos.
2934 * generic.cs (TypeParameter.GetSignatureForError): New method.
2935 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
2937 * typemanager.cs (GetFullName): Refactored.
2939 2005-11-08 Marek Safar <marek.safar@seznam.cz>
2941 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
2942 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
2944 * class.cs (TypeContainer.IsComImport): New property.
2945 (Constructor.Define): Create proper ctor for ComImport types.
2947 * expression.cs (New.CheckComImport): Fixed.
2949 2005-11-07 Miguel de Icaza <miguel@novell.com>
2951 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
2952 that a parameter has been captured does not mean that we do not
2953 have to do the rest of the processing. This fixes the second part
2954 of #76592. If there was another anonymous method capturing
2955 values in the past, the Scope would never be set for the second
2956 method that captured the same parameter.
2958 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
2959 properly manipulate the stack. Second part of fix for #76592.
2961 * expression.cs (New): Add support for invoking "new" on
2962 interfaces that have been flagged with the ComImport attribute and
2963 the CoClass. Fixes #76637
2965 * statement.cs (Try.DoEmit): When a variable is captured, do not
2966 try to emit the vi.LocalBuilder variable as it has been captured.
2967 Create a temporary variable and store the results on the
2968 FieldBuilder. Fixes #76642
2970 2005-11-07 Marek Safar <marek.safar@seznam.cz>
2972 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
2974 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
2976 * expression.cs (Binary.DoResolve): Added && optimalization.
2978 * typemanager.cs (AddUserType): Removed useless argument.
2980 2005-11-04 Marek Safar <marek.safar@seznam.cz>
2982 * statement.cs (Block.variables): Uses ListDictionary.
2984 2005-11-03 Marek Safar <marek.safar@seznam.cz>
2987 * class.cs (PartialContainer.EmitType): Customized to emit
2988 security attributes.
2989 (ClassPart.ApplyAttributeBuilder): Transform security attribute
2990 for partial classes.
2992 2005-11-03 Marek Safar <marek.safar@seznam.cz>
2995 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
2996 access has to be fixed.
2998 * typemanager.cs (IsUnmanagedType): Wrong common field type.
3000 2005-11-01 Marek Safar <marek.safar@seznam.cz>
3003 * ecore.cs (NullCast.Reduce): Implemented.
3005 * expression.cs (ArrayCreation.CheckIndices): Correcly check
3008 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
3010 (Foreach.Resolve): Catch null properly.
3012 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3014 * cs-tokenizer.cs: Warning text fix.
3016 * driver.cs: AllWarningNumbers exposed on public interface.
3018 * report.cs (): Reviewed warning numbers.
3019 (IsValidWarning): Use binary search.
3021 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3023 * driver.cs: Implemeted resource visibility.
3024 (Resources): New class for code sharing between /res: and
3027 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3029 decl.cs (CurrentTypeParameters): Fixed to be public.
3031 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3033 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3035 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3037 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3039 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3041 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3043 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3045 Add friend assembly access support.
3046 * typemanager.cs: assembly_internals_vis_attrs
3047 cache for friend assembly access.
3048 (TypeManager.IsFriendAssembly): New method for
3049 checking friend assembly access.
3050 (TypeManager.Error_FriendAccessNameNotMatching): New
3052 (TypeManager.CompareKeyTokens): Likewise.
3053 (TypeManager.Filter): Handle friend accessible
3056 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3057 friend accessible types.
3059 * ecore.cs (Expression.IsAccessorAccessible): Handle
3060 friend accessible properties.
3062 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3065 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3068 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3071 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3074 * ecore.cs (NullCast): Child is contant only.
3076 * literal.cs (NullLiteral.Reduce): null can be converted to any
3079 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3081 * driver.cs: Use Encoding.Default as default code page instead
3084 2005-10-27 Raja R Harinath <rharinath@novell.com>
3087 * expression.cs (Invocation.Error_InvalidArguments): Handle
3088 __arglist parameters.
3089 (Invocation.VerifyArgumentsCompat): Likewise.
3090 * support.cs (ReflectionParameters.GetSignatureForError): Print
3091 __arglist parameters.
3092 (InternalParamters.GetSignatureForError): Likewise.
3093 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3095 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3097 * attribute.cs (GetPropertyValue): Made public.
3099 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3101 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3103 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3106 * driver.cs: Reflect method name change.
3108 * statement.cs (Try.Resolve): Warn when try has both general
3111 * typemanager.cs: runtime_compatibility_attr_type new predefined
3114 2005-10-26 Raja R Harinath <harinath@gmail.com>
3117 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3118 treat it as an empty parameter list.
3120 2005-10-26 Raja R Harinath <rharinath@novell.com>
3123 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3124 ResolveAsTypeStep silent.
3125 * statement.cs (Block.AddConstant): Mark block as used.
3126 (Block.ResolveMeta): Avoid piling on error messages
3127 if a constant initializer resolution fails.
3129 2005-10-25 Raja R Harinath <rharinath@novell.com>
3131 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3133 (NamespaceEntry.VerifyAllUsing): New.
3134 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3135 behaviour. Delegates actual resolution of alias to ...
3136 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3137 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3139 * driver.cs (Driver.MainDriver): Update.
3141 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3142 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3144 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3146 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3147 RootNamespace.DefineNamespacesForAll.
3149 2005-10-24 Raja R Harinath <harinath@gmail.com>
3151 * typemanager.cs (assemblies, external_aliases, modules)
3152 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3153 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3154 overhead. Move resposibility ...
3155 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3156 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3158 2005-10-23 Raja R Harinath <harinath@gmail.com>
3160 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3161 cached_namespaces. Improve usage.
3162 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3163 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3164 Move from GlobalRootNamespace and simplify.
3165 (RootNamespace.Global): Make instance variable.
3166 (RootNamespace.RootNamespace): Add "alias name" parameter.
3167 (GlobalRootNamespace): Simplify drastically.
3168 (Namespace.Lookup): Don't use GetNamespace.
3169 * typemanager.cs (GetRootNamespace): Rename from
3170 ComputeNamespaceForAlias.
3171 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3173 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3175 * anonymous.cs (AnonymousContainer): Don't crash when container
3178 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3180 * expression.cs (Binary.DoResolve): Warn when comparing same
3183 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3186 * expression.cs (Binary.DoResolve): It looks like there are no
3187 convetsion rules in enum context.
3189 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3191 Add support for extern alias qualifiers.
3192 * typemanager.cs: Move some LookupTypeReflection code
3193 to namespace.cs, to have cleaner code. Added some methods
3194 to help us keep track of the extern aliased references.
3195 * driver.cs: Add suport for extern alias assemblies on command
3196 line and check for their warnings/errors. Also keep track of the
3197 extern aliased assemblies.
3198 * namespace.cs: Move the global functionality of Namespace
3199 to GlobalRootNamespace/RootNamespace. Now the global namespace
3200 is GlobalRootNamespace.Globa. Also the code moved from
3201 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3202 Finally added LocalAliasEntry (AliasEntry before) and
3203 ExternAliasEntry, to handle alias statements.
3204 * cs-parser.jay: Add support in the grammar for extern alias
3206 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3207 Update callings to Namespace (now in GlobalRootNamespace).
3209 2005-10-25 Martin Baulig <martin@ximian.com>
3211 * convert.cs (ImplicitTypeParameterConversion): Make base
3212 interfaces actually work; fixes #76557.
3214 2005-10-25 Martin Baulig <martin@ximian.com>
3217 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3218 all the type parameters; fixes #76551.
3220 2005-10-25 Martin Baulig <martin@ximian.com>
3225 (GenericMethod.ctor): Added `Expression return_type' and
3226 `Parameters parameters' arguments.
3227 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3228 parameter and return types to check their constraints if they're
3231 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3234 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3235 constraints of a generic type if `ec.ResolvingGenericMethod'.
3237 * class.cs (MethodCore.DoDefineParameters): Set
3238 `ec.ResolvingGenericMethod' if we're a generic method.
3239 (MemberBase.MemberType): Likewise.
3241 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3243 * typemanager.cs (TypeManager): Added
3244 TypeManager.internals_visible_attr_type to cache
3245 S.R.CompilerServices.InternalsVisibleToAttribute.
3247 * codegen.cs (AssemblyClass): Added checks for
3248 InternalsVisibleToAttribute in new method
3249 CheckInternalsVisibleAttribute () and also cache the
3250 AssemblyName in AssemblyClass.Name.
3252 2005-10-24 Martin Baulig <martin@ximian.com>
3255 (TypeManager.ExpandInterfaces): Added overloaded version which
3256 just takes a `Type[]' array.
3259 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3260 just use the interfaces which were explicitly specified and not
3261 the interfaces they inherit. Fixes #76482.
3262 (TypeParameter.FindMembers): Expand the interfaces here.
3264 2005-10-21 Martin Baulig <martin@ximian.com>
3267 (Constraints.Resolve): Also resolve the actual types here.
3268 (Constraints.ResolveTypes): Just check the constraints here.
3269 Fixes #76363; see gtest-218.cs.
3271 2005-10-21 Martin Baulig <martin@ximian.com>
3274 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3275 instead of a `BoxedCast'; fixes gtest-217.cs.
3277 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3279 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3280 1) "new()" is specified as generic parameter constraint and 2) the
3281 type is TypeBuilder and 3) the type is abstract even if it has a
3282 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3284 2005-10-20 Martin Baulig <martin@ximian.com>
3287 (GenericConstraints.TypeParameter): New public property.
3288 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3289 (TypeParameter.DeclSpace): New public property.
3290 (TypeParameter.DefineType): Inflate the constraints if our
3291 `DeclSpace' is an `Iterator'.
3293 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3295 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3296 GenericMethod argument to compare methods' generic type arguments.
3299 2005-10-19 Martin Baulig <martin@ximian.com>
3301 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3302 not ResolveType() when resolving the base type, so we're not
3303 checking the constraints here.
3304 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3307 2005-10-19 Martin Baulig <martin@ximian.com>
3309 * generic.cs (ConstructedType.CheckConstraints): Committing
3310 untested fix for #76441.
3312 2005-10-18 Raja R Harinath <rharinath@novell.com>
3315 * class.cs (TypeContainer.DefineType): Move updating of
3316 topological sort earlier in the code.
3317 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3319 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3322 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3324 * constant.cs (Constant.TryReduce): Moved from Cast class.
3325 (Reduce): Made little bit more OO and fixed missing conversions.
3327 * ecore.cs (Reduce): Implemented.
3328 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3330 * literal.cs (Reduce): Implemented.
3332 * class.cs: Reverted Miguel's wrong commit.
3334 2005-10-14 Miguel de Icaza <miguel@novell.com>
3336 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3338 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3340 * cs-parser.jay, expression.cs : CS0214 was missing error location
3341 for constants. Fixed bug #76404.
3343 2005-10-10 Raja R Harinath <rharinath@novell.com>
3345 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3347 (PropertyExpr.EmitCall): Likewise.
3348 * expression.cs (Invocation.EmitArguments): Handle case where
3350 (Invocation.EmitCall): Avoid allocating temporary variable if
3351 there are no arguments.
3353 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3356 * convert.cs (ExplicitConversionCore): Fixed object->enum
3359 2005-10-07 Raja R Harinath <rharinath@novell.com>
3362 * convert.cs (ImplicitConversionStandard): Move conversion of
3363 void* to arbitrary pointer types ...
3364 (ExplicitConversionStandard): .. here.
3365 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3366 error to always print typenames.
3368 2005-10-07 Raja R Harinath <rharinath@novell.com>
3370 * convert.cs (GetConversionOperator): Rename from
3371 GetConversionOperators. Move operator selection code from ...
3372 (UserDefinedConversion): ... here.
3374 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3376 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3379 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3381 * assign.cs (Assign.DoResolve): Error method changed.
3383 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3385 * const.cs (ResolveValue): Reset in_transit immediately.
3387 * constant.cs: Error method changed.
3389 * convert.cs: Removed useless location parameter.
3390 (ExplicitNumericConversion): Don't do double enum check.
3391 (ExplicitConversionCore): Renamed from ExplicitConversion.
3392 (ExplicitUnsafe): Extracted from ExplicitConversion.
3393 (ExplicitConversion): Uses for error reporting.
3395 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3397 (ResolveBoolean): Uses common error method.
3398 (CastToDecimal): Get rid of ec.
3399 (CastFromDecimal): Optimized.
3400 (ConvCast): Get rid of ec.
3402 * enum.cs (ResolveValue): Reset in_transit immediately.
3403 (Emit): Return after first error.
3405 * expression.cs: Convert changes.
3407 * literal.cs: Error method changed.
3409 * statement.cs: Error method changed.
3411 2005-10-06 Raja R Harinath <rharinath@novell.com>
3413 Fix gtest-131.cs and gtest-211.cs.
3414 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3415 Only emit code for a label if it is used. Unreachable code can
3416 violate ECMA evaluation stack invariants.
3418 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3420 * anonymous.cs: Implemented ExprClassName.
3422 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3425 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3428 * class.cs (StaticClass.DefineContainerMembers): Report protected
3431 * codegen.cs: if(ed) PRODUCTION.
3433 * convert.cs (Error_CannotImplicitConversion): Better error
3436 * cs-parser.jay: More error checks.
3438 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3440 * driver.cs (CSCParseOption): Enabled wrong option check.
3442 * ecore.cs (Expression.ExprClassName): Turned to property.
3443 (MemberExpr.CheckIntermediateModification): For checking boxed
3444 value types modification.
3446 * statement.cs (Fixed.Resolve): Expression type must be
3447 convertible to fixed type.
3448 (CollectionForeach.GetEnumeratorFilter,TryType):
3449 Small refactoring for easier error checking.
3451 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3453 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3456 * class.cs (GeneratedBaseInitializer): New class for customization
3457 compiler generated initializers.
3458 (MemberBase.DoDefine): Check Obsolete attribute here.
3459 (FieldMember.DoDefine): Ditto.
3461 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3464 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3465 (MemberCore.GetObsoleteAttribute): Removed argument.
3466 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3467 (MemberCore.CheckObsoleteType): New helper.
3471 * statement.cs: Updates after MemberCore changes.
3473 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3474 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3476 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3477 obsolete attribute for compiler construct.
3478 (As.DoResolve): Cache result.
3480 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3482 2005-10-01 Miguel de Icaza <miguel@novell.com>
3484 * expression.cs (Probe): instead of having a "Type probe_type"
3485 keep the extra information as a TypeExpr probe_type_expr since the
3486 "As" operator needs to perform some type checks.
3488 * (As.DoResolve): If the type is a type parameter, ensure that it
3489 is constrained by a class.
3491 2005-09-22 Miguel de Icaza <miguel@novell.com>
3493 * statement.cs (Lock): Use the TemporaryVariable class instead of
3494 manually using local variables as those do not work when variables
3497 * ecore.cs: Moved the TemporaryVariable class from being a nested
3498 class inside Foreach to be a public class that can be employed in
3501 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3503 * cs-parser.jay: interface_accessors replaced by
3504 accessor_declarations.
3506 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3509 * statement.cs (GotoCase.Resolve): Convert null constant to
3511 (SwitchLabel.ResolveAndReduce): Ditto.
3512 (SwitchLabel.NullStringCase): Custom null stamp.
3513 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3515 typemanager.cs (CSharpSignature): Don't skip first argument
3518 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3520 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3521 expression.cs, iterators.cs, literal.cs: Store constants and
3524 * class.cs (MemberBase.ShortName): Pass location.
3526 * cs-parser.jay: Some location fixes.
3528 * ecore.cs (Expression.Location): Made virtual.
3530 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3533 * const.cs (Const.ResolveValue): Check for assigning non-null
3534 value to reference type.
3536 2005-09-26 Raja R Harinath <rharinath@novell.com>
3539 * expression.cs (This.VerifyFixed): In a value type T, the type of
3540 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3541 value type R, 'this' is treated as a value parameter.
3543 2005-09-05 Miguel de Icaza <miguel@novell.com>
3545 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3546 if the underlying types are the same, otherwise we need to produce
3547 code that will do the proper cast.
3549 This was exposed by Marek's constant rewrite which produced
3550 invalid code for the call site:
3553 void Method (X v) {}
3557 This fixes test-49.cs
3559 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3561 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3562 Type/Object should be allowed as well. Fixed bug #75968.
3564 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3566 * expression.cs : (Binary.DoResolve): when one is enum constant and
3567 another is constant 0, then return enum one *as enum type*.
3570 2005-10-04 Martin Baulig <martin@ximian.com>
3572 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3573 `SetMemberIsUsed()' work for generics, too.
3575 2005-10-04 Martin Baulig <martin@ximian.com>
3577 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3578 for corlib. Fixes #75691.
3580 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3583 * driver.cs: Fix compilation files with full root path.
3585 2005-09-25 Miguel de Icaza <miguel@novell.com>
3587 * report.cs (SymbolRelatedToPreviousError): Format the output so
3588 it does not use an open parenthesis that is never closed.
3590 * driver.cs: Follow coding guidelines
3592 2005-09-18 Miguel de Icaza <miguel@novell.com>
3594 * driver.cs: Set InEmacs based on the environment variable EMACS.
3596 * location.cs (InEmacs): in this mode, do not report column
3597 location as it confuses Emacs.
3599 2005-10-03 Raja R Harinath <rharinath@novell.com>
3601 * support.cs (SeekableStreamReader.Position): Don't error out when
3602 the requested position is just beyond the end of the current
3605 2005-09-28 Raja R Harinath <rharinath@novell.com>
3607 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3608 try to keep in sync with the byte count of the underlying Stream.
3609 However, this limits us to a window size of 2048 characters: i.e.,
3610 the maximum lookahead of our lexer/parser can be 2048 characters.
3612 2005-09-22 Martin Baulig <martin@ximian.com>
3614 * driver.cs: Removed a debugging FIXME.
3616 2005-09-21 Raja R Harinath <rharinath@novell.com>
3618 * cs-parser.jay (type_arguments): Add CS1644 check.
3619 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3621 2005-09-15 Raja R Harinath <rharinath@novell.com>
3623 * Makefile (PROGRAM): Make profile specific.
3624 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
3625 the current directory.
3628 * expression.cs (Invocation.EmitCall): Remove optimization on
3629 this_call since it doesn't handle 'this' being a value type.
3631 2005-09-05 Geoff Norton <gnorton@customerdna.com>
3633 * driver.cs: Ensure file handles are closed after parsing
3635 2005-09-05 Miguel de Icaza <miguel@novell.com>
3637 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3638 if the underlying types are the same, otherwise we need to produce
3639 code that will do the proper cast.
3641 This was exposed by Marek's constant rewrite which produced
3642 invalid code for the call site:
3645 void Method (X v) {}
3649 This fixes test-49.cs
3651 2005-09-05 Martin Baulig <martin@ximian.com>
3653 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
3654 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
3656 * cs-parser.jay (delegate_declaration): Small fix for #75852.
3658 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3660 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
3661 to be a pointer type due to the spec 25.2, so check if declaring
3662 type is generic type definition. Fixed bug #75772.
3664 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3667 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
3668 both types are not defined by methods.
3669 * expression.cs : (Invocation.IsApplicable): it should work when
3670 the argument type is equal to the parameter type, not only when
3671 ImplicitConversionExists() returns true.
3673 2005-09-02 Raja R Harinath <rharinath@novell.com>
3675 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
3679 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
3680 flow-branching for LocalVariableReferences in case we were invoked
3681 from a MemberAccess.
3682 * expression.cs (LocalVariableReference.VerifyAssigned): New.
3684 (LocalVariableReference.DoResolveBase): ... this.
3685 (MemberAccess.Resolve): Do the check that was disabled during
3688 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3691 (PartialContainer.Create): check abstract/sealed/static strictly
3692 but abstract/sealed can exist only at one side. Fixed bug #75883.
3694 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
3697 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
3698 specified, don't default to UnmanagedType.I4.
3700 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3702 * expression.cs : conditional operator should check possibly
3703 incorrect assign expression. Fixed bug #75946.
3705 2005-08-30 Raja R Harinath <rharinath@novell.com>
3708 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
3709 (ScopeInfo.EmitScopeType): Use it to construct field names from
3710 names of captured locals.
3713 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
3714 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
3715 Pass 'target_type' to BoxedCast. Don't default to 'object'.
3716 (ExplicitConversion): Remove enum cases already handled by
3717 implicit conversion. Move implicit conversion check to the beginning.
3718 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
3719 * expression.cs (ArrayCreation.EmitDynamicInitializers):
3720 Don't treat System.Enum as a struct.
3722 2005-08-30 Jb Evain <jbevain@gmail.com>
3724 * attribute.cs: handles as expression in parameters.
3726 2005-08-30 Raja R Harinath <rharinath@novell.com>
3729 * class.cs (TypeContainer.VerifyClsName): Don't use a
3730 PartialContainer when verifying CLS compliance.
3731 (AbstractPropertyEventMethod): Set Parent here, ...
3732 (PropertyMethod): ... not here.
3734 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
3736 * attribute.cs : escaped attribute name should not be allowed to be
3737 resolved (e.g. @class as classAttribute). Fixed bug #75930.
3739 2005-08-29 Raja R Harinath <rharinath@novell.com>
3742 * convert.cs (ImplicitStandardConversionExists): Allow zero also
3743 when converting a long constant to unsigned long.
3744 * expression.cs (Invocation.OverloadResolve): Add sanity check to
3745 detect where IsApplicable and VerifyArgumentsCompat disagree.
3747 2005-08-29 Raja R Harinath <rharinath@novell.com>
3748 and Carlos Alberto Cortez <carlos@unixmexico.org>
3751 * class.cs (TypeContainer.CanElideInitializer): New helper.
3752 (TypeContainer.EmitFieldInitializers): Use it to determine if we
3753 can safely emitting the initializer of a field.
3755 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3757 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
3758 allowed inside a switch (without loop). Fixed bug #75433.
3760 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
3762 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
3763 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
3765 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3767 * driver.cs : kinda reverting the default encoding changes (not exact
3768 revert since I noticed that "codepage:reset" might not work fine).
3770 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3772 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
3773 Location. Now getter and setter store location correctly.
3774 (errors/cs0111-12.cs now reports the expected location.)
3776 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3778 * driver.cs : Use default encoding on the environment.
3779 Removed (now that) extra parameter for SeekableStreamReader.
3780 * support.cs : (SeekableStreamReader) third .ctor() argument for
3781 StreamReader is not required (always true). preamble size could
3782 be acquired in simpler and safe way.
3784 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
3786 * cs-parser.jay: report CS0642 at warning level 3
3787 and report CS0642 for an if else statement also
3788 fixes bug #74745. Patch by John Luke (and a bit
3790 Removed extra CS0642 warning check for "while",
3792 * statement.cs: In Block.Resolve(), CS0642 check
3793 is reimplemented to check a sequence of an empty
3794 statement and a block.
3796 Both fix bug #66777.
3798 2005-08-24 Marek Safar <marek.safar@seznam.cz>
3800 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
3801 detection until I fix it.
3803 * cs-tokenizer.cs: Changed error message.
3805 * cs-parser.jay: Fixed 2 error locations.
3807 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
3808 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
3811 * enum.cs (GetSignatureForError): Fixed.
3813 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
3817 * typemanager.cs (RegisterProperty): Removed.
3819 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
3821 2005-08-24 Raja R Harinath <rharinath@novell.com>
3824 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
3825 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
3827 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3829 * expression.cs : tiny fix is required for not warning positive ulong.
3832 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3834 * expression.cs : add CS0652 check for constant and integral
3835 expression. Fixed bug #53974.
3837 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3839 * expression.cs : in DoNumericPromotions(), check if there is implicit
3840 conversion overload for string (to check CS0034). Fixed bug #52492.
3842 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3844 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
3846 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3848 * ecore.cs : report location when it is *not* Null.
3850 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3856 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
3857 correctly. Fixed bug #75721.
3859 2005-08-23 Raja R Harinath <rharinath@novell.com>
3861 * support.cs (SeekableStreamReader.Position): Avoid an expensive
3862 loop that performs 'min (pos, char_count)'.
3865 * expression.cs (Unary.ResolveOperator): Don't discard implicit
3866 converted value in Operator.OnesComplement.
3868 2005-08-22 Ben Maurer <bmaurer@ximian.com>
3870 * anonymous.cs: If the anon method is pulled into a helper class,
3871 it needs to be `internal' not `private'. Fixes runtime behavior on
3874 2005-08-17 Marek Safar <marek.safar@seznam.cz>
3877 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
3880 2005-08-16 Marek Safar <marek.safar@seznam.cz>
3882 The big constants rewrite
3883 Fix #75746, #75685 and more
3884 As a side effect saved 1MB for MWF ;-)
3886 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
3887 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
3888 enum based for corlib compilation.
3890 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
3893 * class.cs (FixedField.Define): Use ResolveAsConstant.
3895 * const.cs (IConstant): Interface constants and enums.
3896 (Const.ResolveValue): New method for constant resolvning.
3897 (ExternalConstant): Constants from imported assemblies.
3899 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
3900 conversion; like enums.
3901 (Constant.ToType): Converts this constant to different type.
3902 (Constant.Increment): Adds 1.
3904 * convert.cs (ImplicitConversionRequired): Simplified.
3906 * cs-parser.jay: Create EnumMember directly.
3908 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
3910 * doc.cs (GenerateEnumDocComment): Removed.
3912 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
3913 (ConvertIntLiteral): Removed.
3914 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
3916 * enum.cs (EnumMember): Implement IConstant.
3917 (Enum.IsValidEnumConstant): Removed.
3918 (Enum.GetNextDefaultValue): Removed.
3919 (Enum.FindMembers): Updated.
3920 (Enum.GenerateDocComment): Iterate enum members.
3922 * expression.cs (Cast.TryReduce): Handle enums correctly.
3923 (New.Constantify): Made public.
3924 (MemberAccess.DoResolve): Removed contant specific if(s).
3926 * literal.cs (NullLiteral): Implement new abstract methods.
3928 * statement.cs (GotoCase.Resolve): Use new constant methods.
3929 (SwitchLabel.ResolveAndReduce): Use new constant methods.
3931 * typemanager.cs (LookupEnum): Removed.
3932 (IsEnumType): Fixed to work with corlib.
3933 (RegisterConstant): Removed.
3934 (LookupConstant): Removed.
3935 (GetConstant): Changed to work with IConstant.
3937 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
3939 * location.cs : Fixed overflown (>255) column number.
3941 2005-08-03 Raja R Harinath <rharinath@novell.com>
3943 First cut of the qualified-alias-member feature.
3944 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
3946 * cs-parser.jay (DOUBLE_COLON): New token.
3947 (namespace_or_type_name): Add rule for recognizing
3948 qualified-alias-members.
3949 (primary_expression): Likewise.
3950 (element_access): Allow QualifiedAliasMember as a possible
3951 type-bearing expression.
3952 (local_variable_type, local_variable_pointer_type): Likewise.
3953 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
3954 aliases in the current and enclosing namespace declarations.
3955 (NamespaceEntry.UsingAlias): Add CS0440 warning.
3956 * decl.cs (MemberName.is_double_colon): New.
3957 (MemberName.MemberName): Add new constructor for alias-member.
3958 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
3959 * expression.cs (QualifiedAliasMember): New expression type.
3961 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3963 * location.cs : it borked when no argument was specified.
3965 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3967 * location.cs : tiny ToString() format fix.
3969 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3971 * statement.cs : oops, it was missing.
3973 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3975 A set of fixes for precise line/column location.
3978 "token" field now holds a file/line "delta", a line number offset
3979 from the segment, and a column number. See also:
3980 http://lists.ximian.com/pipermail/mono-devel-list/2004-
3981 December/009508.html
3982 Removed static IsNull. Use instance IsNull property instead.
3984 For some tokens it stores Location. For Identifier it stores
3985 LocatedToken which is a pair of string name and location.
3986 Column numbers are adjusted only at getChar().
3988 Use Location.ToString() for reporting (it now contains column).
3990 Largely modified to use LocatedToken instead of
3991 string (IDENTIFIER), and to acquire Location from some tokens.
3992 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
3993 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
3995 Now MemberName holds Location. DeclSpace.ctor() receives Location
3996 as a parameter. Removed extra parameters to all derived classes.
3997 Replaced Location.IsNull() with instance property.
3998 * assign.cs, expression.cs :
3999 Added .ctor() overload that omits Location.
4001 Added "nameEscaped" flag that indicates the identifier was escaped
4002 in the source file. This fixes bug #57047.
4004 2005-09-02 Martin Baulig <martin@ximian.com>
4006 * class.cs: Make CS3005 a warning, not an error.
4008 2005-08-02 Marek Safar <marek.safar@seznam.cz>
4010 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
4011 New method, looking for lo-case imported cls type.
4013 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4016 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4018 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4020 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4022 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4024 Optimized to save 3.5 MB for SWF compilation.
4026 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4028 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4029 (PartialContainer.Create): Moved logic AddToContainer.
4030 (PartialContainer.MarkForDuplicationCheck): Shares name.
4032 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4035 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4037 (Namespace.GetSignatureForError): New method.
4039 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4040 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4042 2005-08-01 Raja R Harinath <rharinath@novell.com>
4045 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4046 member lookup rather than qualifier_type, since qualifier_type can
4049 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4051 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4054 2005-07-31 Miguel de Icaza <miguel@novell.com>
4056 * statement.cs: Copy the local exception into the exception
4057 captured local. Fixes 75674
4059 2005-07-31 Raja R Harinath <harinath@gmail.com>
4062 * expression.cs (Invocation.OverloadResolve): Don't report error
4063 CS1501 if error CS1502 has been reported.
4064 (New.DoResolve): Delegate CS1501 reporting to
4065 Invocation.OverloadResolve.
4068 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4069 invariant-meaning-in-block property in an enclosing block if
4072 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4074 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4075 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4076 (Switch.CheckSwitch): Just save 50kb for SWF.
4078 2005-07-27 Martin Baulig <martin@ximian.com>
4080 * anonymous.cs (CaptureContext.AddField): Added
4081 `AnonymousContainer am' argument; compute its toplevel scope if
4082 it's not already computed. Fixes #75649.
4084 2005-07-26 Raja R Harinath <rharinath@novell.com>
4087 * class.cs (Constructor.Emit): Reset block to null if the block
4090 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4092 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4094 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4096 * class.cs (MethodData.Define): Check whether accessor implementing
4097 interface is public.
4099 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4101 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4104 * namespace.cs (LookupType): Moved same type check to...
4106 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4109 2005-07-21 Raja R Harinath <rharinath@novell.com>
4111 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4112 already found a typebuilder.
4113 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4114 MemberNames, not strings.
4116 * const.cs (Error_ExpressionMustBeConst):
4117 Rename from Error_EpressionMustBeConst.
4118 * const.cs, class.cs, statement.cd: Update.
4120 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4124 * const.cs (Const.LookupConstantValue): Report missing contant expression
4126 (Error_EpressionMustBeConstant): Only one error method.
4128 * class.cs, statement.c: Updated.
4130 2005-07-20 Raja R Harinath <rharinath@novell.com>
4132 * statement.cs (Block.Flags): Add back HasVarargs.
4133 (Block.flags): Make protected.
4134 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4136 * typemanager.cs (types, typecontainers, user_types): Remove.
4137 (UserTypes, TypeContainers): Likewise.
4138 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4139 (CleanUp, Reset): Update.
4140 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4141 (GetNestedType): Use Type.GetNestedType.
4142 (CoreLookupType): Take two arguments, the namespace and the
4143 basename of the type. Update to use the Namespace.Lookup
4145 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4146 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4147 string concatenation and substring matches.
4148 * class.cs, enum.cs, delegate.cs: Update to changes.
4150 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4152 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4153 Expression and made virtual.
4155 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4156 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4158 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4160 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4163 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4166 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4169 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4170 AssemblyCultureAttribute is not used on executable.
4173 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4175 2005-07-16 Raja R Harinath <rharinath@novell.com>
4178 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4179 New. Reports CS0252/CS0253.
4180 Mostly taken from preliminary patch by Duncak Mak.
4181 (Binary.DoResolveOperator): Store results of operator lookup.
4182 Use them to detect if we need to warn about unintended reference
4185 2005-07-15 Raja R Harinath <rharinath@novell.com>
4188 * namespace.cs (Namespace.Lookup): Add back location parameter.
4189 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4190 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4192 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4193 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4194 (Namespace.LookupType): ... this.
4195 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4197 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4198 purported to handle pointers.
4199 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4202 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4204 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4207 2005-07-15 Raja R Harinath <rharinath@novell.com>
4209 * namespace.cs (Namespace.Lookup): Drop location parameter.
4210 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4211 (NamespaceEntry.Lookup): ... this.
4212 (NamespaceEntry.Error_AmbiguousTypeReference):
4213 Move here from DeclSpace.
4214 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4216 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4217 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4218 Move to NamespaceEntry.
4219 * delegate.cs, expression.cs: Update to changes.
4221 2005-08-31 Martin Baulig <martin@ximian.com>
4223 Committing a patch from Atsushi Enomoto for #75850.
4225 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4226 Prefer a generic enumerator over a non-generic one.
4228 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4230 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4231 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4233 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4235 * driver.cs : reverting default encoding change as well as mcs.
4237 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4239 * driver.cs, support.cs : merged r48826.
4241 > could you integrate your mcs changes to gmcs otherwise
4242 > gmcs cannot compile some files.
4244 2005-08-20 Martin Baulig <martin@ximian.com>
4246 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4247 scope if we don't already have it.
4249 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4250 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4253 2005-07-31 Miguel de Icaza <miguel@novell.com>
4255 * statement.cs: Copy the local exception into the exception
4256 captured local. Fixes 75674
4258 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4260 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4263 2005-08-12 Martin Baulig <martin@ximian.com>
4265 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4266 for nested types here to avoid hitting the cache too early.
4268 2005-08-09 Miguel de Icaza <miguel@novell.com>
4270 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4273 2005-08-03 Martin Baulig <martin@ximian.com>
4275 Make iterators in generic methods work; see gtest-191.cs.
4278 (Constraints.Resolve): Protect against being called twice.
4281 (TypeContainer.GetClassBases): Make this `protected virtual'.
4283 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4284 (Iterator.GetClassBases): Override this and compute the base
4286 (Iterator.DefineNestedTypes): If we're a generic method, all our
4287 method type parameters become class type parameters on the proxy
4291 (ToplevelBlock.Parameters): Make this a property, not a field.
4292 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4294 2005-08-03 Martin Baulig <martin@ximian.com>
4296 * typemanager.cs (TypeManager.IsSubclassOf): Use
4297 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4298 (TypeManager.GetFullName_recursed): Improved.
4300 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4303 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4304 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4305 invocation_type == mi.DeclaringType, since the first one also checks
4306 other condition used by generic instances.
4308 2005-07-27 Martin Baulig <martin@ximian.com>
4310 * anonymous.cs (CaptureContext.AddField): Added
4311 `AnonymousContainer am' argument; compute its toplevel scope if
4312 it's not already computed. Fixes #75649.
4314 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4316 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4317 CheckAttributeType and refactored.
4318 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4319 ResolveAsTypeTerminal error handling.
4320 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4322 (GetSignatureForError): Print errors in same way.
4325 * codegen.cs: Reflect attribute GetSignatureForError change.
4328 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4330 * namespace.cs (UsingEntry): Refactored to make fields private.
4333 statement.cs: Error_UnexpectedKind has extra parameter.
4335 2005-07-14 Raja R Harinath <rharinath@novell.com>
4337 * ecore.cs (IAlias): Remove.
4338 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4339 that implement the interface.
4340 * namespace.cs (Namespace): Likewise.
4341 (Namespace.declspaces): Renamed from 'defined_names'.
4342 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4343 DeclSpace instead of an IAlias.
4344 * tree.cs (Tree.AddDecl): Update.
4346 2005-07-12 Raja R Harinath <rharinath@novell.com>
4348 * statement.cs (Block.Flags); Remove HasVarargs.
4349 (Block.HasVarargs): Move to ToplevelBlock.
4350 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4351 (Block.Variables): Make protected. Initialize variable hashtable
4353 (Block.AddVariable): Update.
4354 (Block.Resolve): Update to changes.
4355 (ToplevelBlock.HasVarargs): New boolean.
4356 (ToplevelBlock.ThisVariable): Move here from Block.
4357 (ToplevelBlock.AddThisVariable): Likewise.
4358 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4359 * expression.cs (This.ResolveBase): Update to changes.
4360 (ArglistAccess.DoResolve): Likewise.
4362 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4365 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4367 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4368 not used and not used & assigned.
4369 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4371 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4374 * expression.cs (Is.DoResolve): null is never provided type.
4376 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4379 * cs-parser.jay: Less strict event error rule to catch more errors.
4381 2005-07-11 Martin Baulig <martin@ximian.com>
4383 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4384 for the constructor constraint: we do not only have to check
4385 whether the class has a public constructor, but also ensure that
4386 it's parameterless. Fixes #75492.
4388 2005-07-11 Martin Baulig <martin@ximian.com>
4390 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4391 between type parameters if they either have the reference type
4392 constraint or the class constraint.
4394 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4396 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4398 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4401 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4402 (ExtractSecurityPermissionSet): Cope with self referencing security
4403 attributes properly.
4405 * driver.cs (SetOutputFile): Made public property OutputFile.
4407 2005-07-07 Raja R Harinath <rharinath@novell.com>
4410 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4411 has_nonstatic_fields. Make into a FieldBase pointer.
4412 (TypeContainer.AddField): Add CS0282 check.
4413 (TypeContainer.EmitType): Update.
4415 2005-07-06 Miguel de Icaza <miguel@novell.com>
4417 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4418 compare if they start with __.
4420 2005-07-06 Raja R Harinath <rharinath@novell.com>
4422 * statement.cs (Switch.SwitchGoverningType): Only look at
4423 UserCasts that don't need implicit standard conversions to one of
4424 the allowed switch types (Fixes test-322.cs).
4425 (LocalInfo.Resolve): Re-enable sanity-test.
4427 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4429 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4431 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4433 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4435 2005-07-06 Raja R Harinath <rharinath@novell.com>
4438 * ecore.cs (SimpleName.GetSignatureForError): Add.
4439 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4440 (MemberAccess.GetSignatureForError): Add.
4442 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4444 The big error and warning messages review.
4474 * typemanager.cs: Updated.
4476 * class.cs: (MethodCore.SetYields): Moved here to share.
4477 (PropertyMethod.Define): Moved iterator setup here.
4479 * iterators.cs: Add orig_method to have full access to parent
4482 2005-07-05 Raja R Harinath <rharinath@novell.com>
4484 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4485 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4486 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4487 variable of struct type.
4488 * expression.cs (Unary.ResolveOperator): Update to change.
4489 (Indirection.VerifyFixed): Likewise.
4490 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4491 (ParameterReference.VerifyFixed): Value parameters are fixed.
4492 (This.VerifyFixed): Treat 'this' as a value parameter.
4493 * statement.cs (LocalInfo.IsFixed): Remove.
4495 2005-07-01 Martin Baulig <martin@ximian.com>
4497 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4498 `ec.EmitThis ()' to get the correct scope.
4500 2005-07-01 Martin Baulig <martin@ximian.com>
4502 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4503 instance is a ParameterReference; fixes #75299.
4505 2005-06-30 Raja R Harinath <rharinath@novell.com>
4508 * expression.cs (Indexers.map): Remove.
4509 (Indexers.Append): Filter out inaccessible setters and getters.
4510 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4513 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4515 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4516 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4517 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4518 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4520 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4523 * class.cs (FieldBase.GetInitializerExpression): One more field
4526 2005-06-28 Miguel de Icaza <miguel@novell.com>
4528 * pending.cs: Do not define a proxy if the base method is virtual,
4529 it will be picked up by the runtime (bug 75270).
4531 2005-07-08 Martin Baulig <martin@ximian.com>
4533 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4534 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4536 2005-07-07 Martin Baulig <martin@ximian.com>
4538 * generic.cs (ConstructedType.CheckConstraint): Use
4539 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4540 called recursively; fixes #75329.
4542 2005-07-06 Martin Baulig <martin@ximian.com>
4544 * generic.cs (TypeManager.InferTypeArguments): Added support for
4545 anonymous methods; fixes #75461.
4547 2005-07-01 Martin Baulig <martin@ximian.com>
4549 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4550 `ec.EmitThis ()' to get the correct scope.
4552 2005-07-01 Martin Baulig <martin@ximian.com>
4554 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4555 instance is `This'; fixes #75299.
4557 2005-06-30 Martin Baulig <martin@ximian.com>
4559 * class.cs (Indexer): Implement IIteratorContainer; added support
4560 for iterators in indexers.
4563 (EmitContext.CurrentIterator): Make this a property, not a field.
4565 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4567 2005-06-28 Miguel de Icaza <miguel@novell.com>
4569 * pending.cs: Do not define a proxy if the base method is virtual,
4570 it will be picked up by the runtime (bug 75270).
4572 2005-06-28 Martin Baulig <martin@ximian.com>
4574 * cs-parser.jay (interface_method_declaration): Avoid a
4575 reduce/reduce conflict by moving some of the code into a separate
4576 `interface_method_declaration_body' rule; fixes #75368.
4578 2005-06-28 Martin Baulig <martin@ximian.com>
4580 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4581 array check after the check for TypeBuilder's.
4583 2005-06-21 Raja R Harinath <rharinath@novell.com>
4585 * convert.cs (FindMostEncompassedType): Add two trivial special
4586 cases (number_of_types == 0 || number_of_types == 1).
4587 (FindMostEncompasingType): Likewise.
4589 2005-06-17 Raja R Harinath <rharinath@novell.com>
4591 Some cleanups preparing for the fix of #75283.
4592 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4594 (EventExpr.InstanceResolve): Likewise.
4595 (EventExpr.DoResolve): Remove redundant checks.
4597 2005-06-08 Miguel de Icaza <miguel@novell.com>
4599 * class.cs: Small fix.
4601 2005-06-08 Raja R Harinath <rharinath@novell.com>
4604 * class.cs (GetPartialBases): Fix return value check of
4607 2005-06-07 Raja R Harinath <rharinath@novell.com>
4609 Ensure that partial classes are registered in their enclosing
4610 namespace. Initial part of fix of #75160.
4611 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4612 Register declspace with namespace here, not in
4613 DeclSpace.RecordDecl.
4614 * cs-parser.jay: Pass namespace to RecordDecl.
4615 * class.cs (PartialContainer.Create): Likewise.
4616 (ClassPart.DefineType): New sanity-check. Throws an exception if
4618 * decl.cs (Declspace.RecordDecl): Remove.
4619 * namespace.cs (NamespaceEntry.DefineName): Remove.
4621 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4623 * rootcontext.cs: Reset TargetExt as well.
4625 2005-06-03 Raja R Harinath <rharinath@novell.com>
4627 * ecore.cs (Expression.Resolve): Emit CS0654 error when
4630 2005-06-02 Raja R Harinath <rharinath@novell.com>
4632 Fix #75080, cs0119.cs.
4633 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
4635 (Expression.Resolve): ... this. Use it. Remove bogus code
4636 allowing ExprClass.Type and ExprClass.Namespace for
4637 ResolveFlags.VariableOrValue.
4638 (Expression.Resolve) [1-argument variant]: Change default resolve
4639 flags based on language version.
4640 (Expression.Error_UnexpectedKind): Use a simple string array
4641 rather than an ArrayList.
4642 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
4644 (TypeOfVoid.DoResolve): Likewise.
4645 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
4646 flags argument -- it always has the same value.
4648 2005-05-31 Raja R Harinath <rharinath@novell.com>
4651 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
4652 Use it in the error message.
4653 * assign.cs, expression.cs, statement.cs: Update.
4655 2005-05-30 Raja R Harinath <rharinath@novell.com>
4658 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
4659 the "almostMatchedMember" case too.
4660 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
4661 that failed the accessibility checks to 'almost_match'.
4663 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
4665 * attribute.cs: Use internal MethodBuilder methods to set
4666 ExactSpelling and SetLastError on PInvoke methods, instead
4667 of passing them via charset. Fixes #75060.
4669 2005-05-27 Raja R Harinath <rharinath@novell.com>
4671 * parameter.cs (Parameter): Remove TODO comment.
4672 (Parameter.DefineParameter): Remove Location parameter.
4673 (Parameters.LabelParameters): Likewise.
4674 * class.cs (Constructor.Emit): Update to change.
4675 (MethodData.Emit): Likewise.
4676 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
4677 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
4679 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
4682 Removed Parameters.Location and added Parameter.Location instead.
4683 Removed Location parameter from Emit() and GetSignature().
4690 Modified all related calls.
4692 2005-06-21 Martin Baulig <martin@ximian.com>
4694 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
4695 left-hand side is not a nullable type; fixes #75328.
4697 2005-06-21 Martin Baulig <martin@ximian.com>
4700 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
4701 (TypeManager.GetFullNameSignature): Likewise.
4703 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
4704 `source.FullName' and `target.FullName' to check whether there are
4705 two conflicting definitions.
4707 2005-06-21 Martin Baulig <martin@ximian.com>
4709 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
4710 a BoxedCast - also for reference types - to be compatible with csc.
4712 2005-06-21 Martin Baulig <martin@ximian.com>
4714 * expression.cs (MemberAccess.DoResolve): Add support for nested
4715 types in a generic instance; fixes #75320.
4717 2005-06-20 Martin Baulig <martin@ximian.com>
4719 * generic.cs (TypeManager.InferType): Also walk the class
4720 hierarchy for generic instances; fixes #75261.
4722 2005-06-17 Martin Baulig <martin@ximian.com>
4724 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
4725 to make things work for corlib.
4727 2005-06-15 Martin Baulig <martin@ximian.com>
4729 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
4730 obsolete `SecurityAction' values.
4732 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4734 * rootcontext.cs: Reset TargetExt as well.
4736 2005-06-09 Martin Baulig <martin@ximian.com>
4738 * delegate.cs (Delegate.VerifyMethod): Added
4739 `MethodGroupExpr old_mg' argument; inherit its
4740 `HasTypeParameters'; fix #75085.
4742 2005-06-09 Martin Baulig <martin@ximian.com>
4744 * expression.cs (Invocation.OverloadResolve): Correctly handle
4745 generic methods for the SetMemberIsUsed(); fix #75064.
4747 2005-06-09 Martin Baulig <martin@ximian.com>
4749 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
4752 2005-06-08 Martin Baulig <martin@ximian.com>
4754 * cs-parser.jay (nullable_type_or_conditional): If we put the
4755 nullable back and our `type' is a `ComposedCast', remove the
4756 nullable from it. Fixes #75156.
4758 * expression.cs (ComposedCast.RemoveNullable): New public method.
4760 2005-06-08 Martin Baulig <martin@ximian.com>
4762 The big Iterators rewrite :-)
4764 * iterators.cs: Rewrite this to use the anonymous methods framework.
4766 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
4767 before the TypeContainers; see 2test-21.cs.
4770 (TypeContainer.DefineType): Don't create a new EmitContext if we
4771 already have one (this only happens if we're an Iterator).
4772 (TypeContainer.Define): Also call Define() on all our iterators.
4773 (Method.CreateEmitContext): Added support for iterators.
4776 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
4777 (AnonymousContainer.CreateMethodHost): Moved here from
4778 AnonymousMethod and made abstract.
4779 (AnonymousContainer.CreateScopeType): New abstract method.
4780 (AnonymousContainer.IsIterator): New public property.
4781 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
4782 get the ScopeTypeBuilder rather than manually defining it here.
4783 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
4786 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
4787 before RootContext.DefineTypes().
4789 * codegen.cs (EmitContext.RemapToProxy): Removed.
4790 (EmitContext.CurrentAnonymousMethod): Changed type from
4791 AnonymousMethod -> AnonymousContainer.
4792 (EmitContext.ResolveTopBlock): Protect from being called twice.
4793 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
4794 (EmitContext.EmitThis): Removed the iterators hacks; use the
4795 anonymous methods framework for that.
4798 (ToplevelBlock.Container): Make this a property, not a field.
4799 (ToplevelBlock.ReParent): New public method; move the
4800 ToplevelBlock into a new container.
4801 (Foreach.TemporaryVariable): Simplify.
4803 2005-06-05 Martin Baulig <martin@ximian.com>
4805 * statement.cs (LocalInfo.CompilerGenerated): New flag.
4806 (Block.AddTemporaryVariable): New public method; creates a new
4807 `LocalInfo' for a temporary variable.
4808 (Block.EmitMeta): Create the LocalBuilders for all the temporary
4810 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
4811 non-iterator variables.
4813 2005-06-05 Martin Baulig <martin@ximian.com>
4815 * statement.cs (Foreach.TemporaryVariable): Create the
4816 LocalBuilder in the Emit phase and not in Resolve since in some
4817 situations, we don't have an ILGenerator during Resolve; see
4818 2test-19.cs for an example.
4820 2005-06-04 Martin Baulig <martin@ximian.com>
4822 The big Foreach rewrite - Part II.
4824 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
4825 with `PropertyInfo ienumerator_getcurrent'.
4827 * codegen.cs (VariableStorage): Removed.
4830 (Foreach): Derive from Statement, not ExceptionStatement.
4831 (Foreach.CollectionForeach): New nested class. Moved all the code
4832 dealing with collection foreach here.
4833 (Foreach.ForeachHelperMethods): Removed.
4834 (Foreach.TemporaryVariable): Implement IMemoryLocation.
4836 2005-05-23 Martin Baulig <martin@ximian.com>
4838 * statement.cs (Try.DoResolve): Don't create a `finally' if we
4839 don't need to. Fix #75014.
4841 2005-05-26 Raja R Harinath <rharinath@novell.com>
4843 Improve user-defined conversion handling.
4844 * convert.cs (GetConversionOperators): Rewrite. Return only the
4845 applicable operators.
4846 (AddConversionOperators): New. Helper for GetConversionOperators.
4847 (FindMostEncompassedType, FindMostEncompassingType): Verify that
4848 there is only one most encompassed/encompassing type.
4849 (FindMostSpecificSource, FindMostSpecificTarget): Remove
4850 "applicable operator" handling.
4851 (UserConversion): Move cache here from GetConversionOperators.
4852 Directly cache the chosen operator, rather than the whole
4854 (ExplicitNumericConversion): Fix buggy implementation of Decimal
4855 case. Allow conversion of decimal to sbyte and byte too.
4856 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
4857 New static methods. Used to avoid allocating EmptyExpressions in
4860 2005-05-24 Duncan Mak <duncan@novell.com>
4862 * ecore.cs (CastFromDecimal): New class for casting a decimal to
4863 another class, used in Convert.ExplicitNumericConversion.
4864 (CastToDecimal): New class, similar to above, but casts to
4865 System.Decimal, used in Convert.ImplicitNumericConversion and also
4866 in explicit convesion from double/float to decimal.
4868 * convert.cs (ImplicitNumericConversion): Handle implicit
4869 conversions to System.Decimal.
4870 (ExplicitNumericConversion): handle explicit conversions to
4875 2005-05-20 Miguel de Icaza <miguel@novell.com>
4877 * typemanager.cs: Do not throw an exception in the TypeBuilder
4878 case, we take care of it on the TypeCode.
4880 2005-05-17 Marek Safar <marek.safar@seznam.cz>
4882 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
4885 * cs-parser.jay: Catch more lexical errors.
4887 * report.cs: Add one more Error method.
4890 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
4892 2005-05-20 Martin Baulig <martin@ximian.com>
4894 * class.cs (TypeContainer.CircularDepException): Removed.
4895 (TypeContainer.DefineType): Removed the `InTransit' stuff.
4896 (TypeContainer.CheckRecursiveDefinition): Check for circular class
4897 (CS0146) and interface (CS0529) dependencies here.
4899 2005-05-20 Martin Baulig <martin@ximian.com>
4901 * expression.cs (New.DoResolve): Move the CS0712 check above the
4902 CS0144 check; otherwise it can never be reached.
4904 2005-05-20 Martin Baulig <martin@ximian.com>
4906 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
4908 2005-05-20 Martin Baulig <martin@ximian.com>
4910 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
4912 * typemanager.cs (TypeManager.IsAttributeType): New public method.
4914 2005-05-19 Martin Baulig <martin@ximian.com>
4917 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
4918 to disable error reporting.
4920 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
4921 here since we don't want to report an error; see the new test-336.cs.
4923 2005-05-19 Raja R Harinath <rharinath@novell.com>
4925 * statement.cs (ToplevelBlock.GetParameterReference)
4926 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
4927 Move here from class Block.
4928 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
4929 * expression.cs (ParameterReference.DoResolveBase): Likewise.
4931 2005-05-18 Martin Baulig <martin@ximian.com>
4936 (FlowBranching.Reachability): Add non-static public And() and Or()
4938 (FlowBranchingSwitch): New class; do the `break_origins' thing
4939 like in FlowBranchingLoop.
4940 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
4941 reachability, not just locals and parameters.
4942 (FlowBranching.MergeChild): Remove some of the hacks for loop and
4943 switch; MergeBreakOrigins() now takes care of that.
4945 2005-05-18 Martin Baulig <martin@ximian.com>
4947 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4948 a loop and may leave it, reset the barrier; fixes #74974.
4950 2005-05-16 Raja R Harinath <rharinath@novell.com>
4952 Fix test-382.cs. Emit values of decimal constants.
4953 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
4955 (TypeContainer.AddField): ... this.
4956 (TypeContainer.EmitFieldInitializers): Allow the list of fields
4957 with initializers to include 'Const's.
4958 (ClassPart.RegisterFieldForInitialization): Forward to
4960 * const.cs (Const.Const): Pass initializer to base class.
4961 (Const.Define): In case of decimal constants, register them for
4962 initialization in a static constructor.
4964 2005-05-14 Martin Baulig <martin@ximian.com>
4966 * statement.cs (Block.Resolve): Correctly handle unreachable code;
4967 do not call ResolveUnreachable() on unreachable statements in
4968 here, see the comment in the source code.
4970 2005-05-13 Raja R Harinath <rharinath@novell.com>
4973 * expression.cs (BinaryResolveOperator): If one of the operands of
4974 an equality comparison is 'null' and the other is a pointer type,
4975 convert the null to a NullPointer.
4976 * convert.cs (ImplicitReferenceConversion): If the expression is a
4977 NullLiteral and the target type is a pointer type, return a
4978 NullPointer instead.
4979 (ImplicitConversionStandard): Likewise.
4981 2005-05-13 Marek Safar <marek.safar@seznam.cz>
4983 * cs-parser.jay: Set readonly context based on special constructs.
4985 * expression.cs (LocalVariableReference.DoResolveBase): Improved
4986 readonly variable error handling.
4988 * rootcontext.cs (EmitCode): Don't verify members when error
4991 * statement.cs (LocalInfo): Add reaodnly context information.
4992 (SetReadOnlyContext, GetReadOnlyContext): New methods.
4994 2005-05-17 Martin Baulig <martin@ximian.com>
4996 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
4999 2005-05-13 Martin Baulig <martin@ximian.com>
5001 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
5002 handle unreachable blocks.
5004 2005-05-13 Martin Baulig <martin@ximian.com>
5007 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
5008 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
5011 2005-05-13 Martin Baulig <martin@ximian.com>
5013 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5014 instance variable, not a local. Fix #74873.
5015 (Block.ResolveUnreachable): Set it to true here.
5017 2005-05-12 Martin Baulig <martin@ximian.com>
5019 * cs-parser.jay (property_declaration): Pass the `current_class',
5020 not the `current_container' to Property's .ctor. Fixes #74912.
5022 2005-05-11 Martin Baulig <martin@ximian.com>
5024 * typemanager.cs (Closure): Copy this from MCS and merge all the
5025 GMCS-specific changes into it.
5027 2005-05-12 Raja R Harinath <harinath@gmail.com>
5030 * typemanager.cs (unmanaged_enclosing_types): New.
5031 (IsUnmanagedType): Avoid infloops by using
5032 'unmanaged_enclosing_types' to talk with recursive invocations.
5034 2005-05-11 Duncan Mak <duncan@novell.com>
5036 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5037 continuing to process for 'arg'.
5038 (handle_preprocessing_directive): Check the argument of the #endif
5039 directive and report error CS1025 if there are any trailing
5042 According to the C# spec, having even whitespace after the #endif
5043 directive is illegal; however, because we call arg.TrimEnd ()
5044 beforehand, we have the same behavior as csc, allowing whitespace
5045 after the directive.
5049 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5053 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5054 (Constructor.GetObsoleteAttribute): Implemented correctly.
5056 2005-05-10 Martin Baulig <martin@ximian.com>
5058 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5059 resolve the type; fixes #74864.
5060 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5061 in DoResolve(); fixes #74862.
5063 2005-05-10 Martin Baulig <martin@ximian.com>
5065 * support.cs (ReflectionParameters.ParameterModifier): Use
5066 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5067 and `ParameterAttributes.In'. Fixes #74884.
5069 2005-05-10 Martin Baulig <martin@ximian.com>
5071 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5072 the cache if we're just looking for `MemberTypes.NestedType' in a
5075 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5076 constraints if we're still resolving the type tree.
5077 (Expression.MemberLookup): If we're resolving the type tree, only
5078 look for `MemberTypes.NestedType' since we're only interested in
5081 * class.cs (TypeContainer.DefineType): Don't resolve the type
5082 parameters here; do this later in ResolveType() after the type
5083 tree has been resolved.
5084 (TypeContainer.ResolveType): New public method; this is called
5085 after the type tree is resolved and before the types are being
5086 populated. We resolve the generic constraints here.
5087 (TypeContainer.DoDefineMember): Check the constraints on our base
5088 class and interfaces.
5090 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5091 set the `ResolvingTypeTree' flag on the EmitContext.
5093 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5095 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5097 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5099 * expression.cs (Argument.GetParameterModifier): Turned to property.
5100 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5102 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5105 2005-05-09 Raja R Harinath <rharinath@novell.com>
5108 * decl.cs (MemberCache.AddMethods): Register override methods,
5109 rather than non-override methods.
5110 * typemanager.cs (RegisterOverride): New.
5111 (IsOverride): Update.
5113 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5115 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5117 2005-05-06 Martin Baulig <martin@ximian.com>
5120 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5121 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5123 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5127 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5128 recursive declaration.
5130 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5132 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5134 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5136 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5138 2005-05-05 Raja R Harinath <rharinath@novell.com>
5141 * decl.cs (DeclSpace.FamilyAccessible):
5142 Use TypeManager.IsNestedFamilyAccessible.
5144 Fix reopened #64812.
5145 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5148 2005-05-04 Raja R Harinath <rharinath@novell.com>
5149 Abin Thomas <projectmonokochi@rediffmail.com>
5150 Anoob V E <projectmonokochi@rediffmail.com>
5151 Harilal P R <projectmonokochi@rediffmail.com>
5154 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5155 allow access to all static members.
5157 2005-05-04 Martin Baulig <martin@ximian.com>
5159 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5161 2005-05-04 Martin Baulig <martin@ximian.com>
5165 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5166 section at the end; make things work if `default' is not the last
5169 2005-05-04 Martin Baulig <martin@ximian.com>
5173 * statement.cs (Switch): Replaced the `got_default' field with a
5174 `default_section' one.
5175 (Switch.CheckSwitch): Set `default_section' here.
5176 (Switch.Resolve): If we're a constant switch and the constant is
5177 not found, use the default section.
5179 2005-05-03 Martin Baulig <martin@ximian.com>
5181 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5183 * statement.cs (Foreach.ArrayForeach): New nested class.
5184 (Foreach.TemporaryVariable): New nested class.
5185 (Foreach.EmitArrayForeach): Removed; this is now in the new
5188 2005-05-03 Raja R Harinath <rharinath@novell.com>
5190 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5192 (VerifyPendingMethods): Revert change below.
5194 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5195 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5196 that used to trigger warning -28. Remove warning -28.
5197 * expression.cs (Invocation.OverloadResolve): Use
5198 TypeManager.IsOverride to distinguish override methods.
5201 * pending.cs (VerifyPendingMethods): If a base type implements the
5202 requested interface, don't bother checking individual methods of
5203 the base type. As a side-effect, this prevents the creation of
5204 unnecessary proxies.
5206 2005-05-02 Martin Baulig <martin@ximian.com>
5210 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5211 Also `And' the locals if the old vector is null.
5212 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5213 null; in this case we basically reset all the variables.
5215 2005-05-02 Martin Baulig <martin@ximian.com>
5219 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5220 Added `FlowBranching branching' argument; always `and' the
5221 variables instead of `or'ing them unless we're an infinite loop.
5223 * statement.cs (While.Resolve): Create a new sibling unless we're
5226 2005-05-02 Martin Baulig <martin@ximian.com>
5230 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5231 arguments; use it instead of creating a new TopLevelBlock.
5232 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5233 our ConstructorInitializer.
5236 (TopLevelBlock.TopLevelBranching): New public property.
5237 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5238 and create our `TopLevelBranching'.
5240 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5241 anonymous method host, use `block.TopLevelBranching' rather than
5242 creating a new branching.
5244 2005-04-20 Miguel de Icaza <miguel@novell.com>
5246 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5247 a ScopeInfo, if any of the current children is a child of the new
5248 entry, move those children there.
5250 2005-04-30 Martin Baulig <martin@ximian.com>
5252 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5253 at the beginning of a SwitchSection. Fix #73335.
5255 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5258 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5260 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5261 (FieldExpr.DoResolve): Obsolete members are ignored for field
5264 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5266 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5267 of arrays detection.
5269 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5271 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5273 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5276 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5278 * cs-parser.jay: Use the prefered version of -unsafe in error
5281 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5283 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5286 2005-04-20 John Luke <john.luke@gmail.com>
5288 * driver.cs: fix typo in error message, --outout to --output
5290 2005-04-30 Martin Baulig <martin@ximian.com>
5292 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5293 handle the .NET 2.x security attributes.
5295 2005-04-30 Martin Baulig <martin@ximian.com>
5298 (TypeManager.ExpandInterfaces): Don't add things twice.
5301 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5303 2005-04-29 Martin Baulig <martin@ximian.com>
5305 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5307 * anonymous.cs: Added support for anonymous generic methods.
5309 2005-04-29 Martin Baulig <martin@ximian.com>
5311 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5314 2005-04-29 Martin Baulig <martin@ximian.com>
5316 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5318 * expression.cs (New.DoResolve): Fix the CS0304 check.
5320 2005-04-29 Martin Baulig <martin@ximian.com>
5322 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5325 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5326 explicit interface implementation, compare the interface types.
5327 (MethodData.Define): Use the new naming scheme from the latest
5329 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5331 * decl.cs (MemberName.GetMemberName): Removed.
5332 (MemberName.MethodName, FullName): New properties.
5334 2005-04-25 Raja R Harinath <rharinath@novell.com>
5336 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5338 2005-04-22 Martin Baulig <martin@ximian.com>
5340 * generic.cs (GenericMethod): Create the EmitContext in the
5341 `Define()'; in `Define(MethodBuilder)', create the type parameters
5342 before calling `Define()'. Fixes #73933.
5344 2005-04-22 Martin Baulig <martin@ximian.com>
5347 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5348 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5350 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5351 ConstructedType, check its constraints.
5353 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5355 * codegen.cs (InRefOutArgumentResolving): New field.
5357 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5358 fields outside contructor.
5360 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5362 2005-04-19 Miguel de Icaza <miguel@novell.com>
5364 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5365 parameter code was not completed ever, so it was not as up-to-date
5366 as local variables. Must finish it.
5368 The bug fix was to compare the Toplevel of the block, not the
5369 current block. Thanks for Ben for pointing this out.
5371 2005-04-19 Raja R Harinath <rharinath@novell.com>
5373 * decl.cs (AddMethods): Use the declaring type of the problem
5374 method to determine if we want to squash a warning.
5376 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5378 * attribute.cs: Removed debug output.
5380 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5382 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5385 2005-04-18 Raja R Harinath <rharinath@novell.com>
5388 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5389 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5390 all null comparisons against reference types.
5392 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5395 * class.cs (TypeContainer.CircularDepException) New nested
5397 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5398 (TypeContainer.DefineType): Removed error, reset InTransit before
5400 (Class.DefineType): Throw exception when is in Transit.
5401 Catch exception and report error.
5402 (Struct.DefineType): Throw exception when is in Transit.
5403 Catch exception and report error.
5404 (Interface.DefineType): Throw exception when is in Transit.
5405 Catch exception and report error.
5407 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5408 handle nested exception handlers.
5410 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5413 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5414 InFinally and InCatch storage.
5416 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5417 (Catch.Resolve): Set and Restore ec.InCatch.
5418 (Try.Resolve): Set and Restore ec.InFinally.
5419 (Try.HasCatch): True when try has catch.
5421 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5423 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5424 for the same event member, so exclude such cases from warning 419.
5427 2005-04-16 Miguel de Icaza <miguel@novell.com>
5429 * expression.cs (Binary.ResolveOperator): Apply patch from John
5430 Luke to fix bug 59864: operators &, | and ^ on enumerations
5431 require that the same enum type on both sides.
5433 * driver.cs: Add warnings to old flag usage, this is to assist
5434 people who produce Makefiles and hope that the Makefiles will be
5437 * class.cs (TypeContainer.EmitType): Moved the definition of the
5438 special $PRIVATE$ field from the resolve phase to the Emit phase.
5439 During resolve we do not know if we are a struct with
5440 HasExplicitLayout, we know this only after the attributes for the
5443 Set the FieldOffset to zero on the dummy field that we create for
5444 the class. Fixes 74590.
5446 2005-04-16 Raja R Harinath <rharinath@novell.com>
5449 * ecore.cs (PropertyExpr.resolved): New.
5450 (DoResolve): Use it to handle a case of double resolution here.
5451 Handle a case of identical-name-and-type-name.
5452 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5453 resolution by storing the results of expression resolution back
5454 into the "probes" array.
5456 2005-04-15 Raja R Harinath <rharinath@novell.com>
5458 Fix cs0208-7.cs and cs0208-8.cs.
5459 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5460 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5461 error reporting to point out the reason a struct is not unmanaged.
5463 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5465 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5466 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5468 2005-04-13 Raja R Harinath <rharinath@novell.com>
5471 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5472 IdenticalNameAndTypeName here.
5473 (EventExpr.InstanceResolve): Likewise.
5475 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5477 C# 2.0 DefaultCharSetAttribute implementation
5479 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5480 which allows us to set GlobalNamespace for every resolve.
5481 (Attribute.ResolveArguments): Cut from Resolve.
5482 (Attribute.GetCharSetValue): Returns CharSet named argument.
5483 (Attribute.DefinePInvokeMethod): Gets default charset from
5485 (GlobalAttribute.ResolveAsTypeStep): Override.
5486 (GlobalAttribute.ResolveArguments): Override.
5488 * class.cs (TypeAttr): Is protected.
5490 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5491 (ModuleClass.DefaultCharSetType): New memeber.
5492 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5494 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5495 charset from module.
5497 * delegate.cs (TypeAttr): Override.
5498 (Delegate.DefineType): Use this TypeAttr.
5500 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5501 at very early stage (before types are defined) to resolve model
5502 module attributes. It will probably not work with corlib but it
5505 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5506 charset from module.
5508 * typemanager.cs (default_charset_type): New type.
5510 2005-04-13 Raja R Harinath <rharinath@novell.com>
5512 * decl.cs (MemberCache.AddMethods): Don't warn if
5513 System.Object.Finalize has buggy MethodAttributes.
5515 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5518 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5520 * doc.cs : detect ambiguous reference to overloaded members.
5521 Fixed bug #71603. MS 1.1 csc does not detect it.
5523 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5525 * doc.cs : delegates must not be referenced with parameters.
5528 2005-04-12 Miguel de Icaza <miguel@novell.com>
5530 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5532 2005-04-10 Miguel de Icaza <miguel@novell.com>
5534 * driver.cs (MainDriver): Stop processing if the CLS stage found
5537 (CompilerCallableEntryPoint.InvokeCompiler): Always
5538 reset after execution; Take a TextWriter argument for the
5541 * report.cs: Use the error stream instead of hardcoding stderr.
5543 2005-04-09 Miguel de Icaza <miguel@novell.com>
5545 * class.cs: Reduce code paths to test, too small of an
5546 optimization to make it worth the extra testing. Always perform
5549 2005-04-08 Raja R Harinath <rharinath@novell.com>
5552 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5553 operators that had errors reported on them.
5555 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5557 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5559 (Attribute.Resolve): Add named argument type checking.
5561 * class.cs (FixedField.Define): Use IsPrimitiveType
5563 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5565 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5566 unsafe parameter types.
5568 * statement.cs (Using.ResolveExpression): Add better error description.
5570 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5572 2005-04-08 Raja R Harinath <rharinath@novell.com>
5575 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5576 AttributeUsageAttribute in the emitcontext of the attribute class,
5577 not in the emitcontext of the attributable entity it was attached to.
5578 * cs-parser.jay: Use 'current_class', not 'current_container',
5579 when creating a GlobalAttribute.
5581 2005-04-08 Alp Toker <alp@atoker.com>
5583 * pending.cs: The fix to #58413 failed to compile methods implementing
5584 interfaces with/without params modifiers and vice versa, even though
5585 params modifiers aren't part of the signature. Make the modifier check
5586 less strict as in csc.
5588 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5589 Anoob V E <projectmonokochi@rediffmail.com>
5590 Harilal P R <projectmonokochi@rediffmail.com>
5593 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5594 modifiers of pending methods.
5595 (PendingImplementation.PendingImplementation): Initialize it.
5596 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5597 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5598 with ParameterData. Add check for modifiers.
5599 * class.cs (MethodData.Define): Update to changes.
5601 2005-04-07 Raja R Harinath <rharinath@novell.com>
5603 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5605 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5607 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5610 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5613 * typemanager.cs: Registered RequiredAttributeAttribute.
5615 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5617 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5618 Warning CS0169 is back at level 3.
5619 (IMethodData.SetMemberIsUsed): New method.
5621 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5622 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
5624 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
5626 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
5628 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
5631 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
5634 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
5635 to avoid the problems with nested types.
5637 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
5638 Anoob V.E <projectmonokochi@rediffmail.com>
5639 Harilal P.R <projectmonokochi@rediffmail.com>
5640 Raja R Harinath <rharinath@novell.com>
5643 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
5645 * typemanager (GetConstructor): Make public.
5647 2005-04-05 John Luke <john.luke@gmail.com>
5648 Raja R Harinath <rharinath@novell.com>
5651 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
5652 struct too. Return false quicker in a few cases.
5653 (VerifyUnManaged): Use it.
5655 2005-04-05 Raja R Harinath <rharinath@novell.com>
5658 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
5659 not 'unreachable_seen'.
5661 2005-04-04 Marek Safar <marek.safar@seznam.cz>
5663 * attribute.cs (Attribute.GetValue): Removed unused.
5665 * codegen.cs (CodeGen.TrimExt): Removed unused.
5667 * cs-parser.jay (output): Removed unused.
5669 * cs-tokenizer.cs (hex_digits): Removed unused.
5671 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
5673 * expression.cs (Indirection.LoadExprValue): Removed unused.
5674 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
5676 * iterators.cs (Iterator.param_types): Removed unused.
5678 * statement.cs (Goto.block): Removed unused.
5679 (ToplevelBlock.did): Removed unused.
5680 (Switch.ResolveConstantSwitch): Removed unused.
5682 2005-04-01 Ben Maurer <bmaurer@ximian.com>
5684 * rootcontext.cs: Allow mcs to bootstrap with the compilation
5687 2005-04-19 Martin Baulig <martin@ximian.com>
5689 Merged r42462 from MCS and made it work for GMCS.
5691 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
5693 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
5695 2005-04-01 Raja R Harinath <rharinath@novell.com>
5697 Fix #74232 and cs0208-3.cs.
5698 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
5699 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
5700 unmanaged type. Don't use FieldBuilders when 't' is a
5701 TypeBuilder. Use ModFlags and MemberType fields.
5702 * class.cs (MemberBase.member_type): Rename from MemberType.
5703 (MemberBase.MemberType): New property. Determines member_type on
5705 (MemberBase.DoDefine): Don't initialize MemberType here.
5706 (FieldMember.Define): Likewise.
5708 2005-04-01 Marek Safar <marek.safar@seznam.cz>
5711 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
5712 Attributes are emitted there.
5714 2005-04-01 Raja R Harinath <rharinath@novell.com>
5716 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
5717 keyword in 'partial enum' too.
5718 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
5720 Report from Kamil Skalski <nazgul@omega.pl>.
5723 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
5724 have partial containers too.
5726 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
5727 in block' checks to Block.CheckInvariantMeaningInBlock.
5728 * statement.cs (Block.GetKnownVariableInfo): Make private.
5729 (Block.IsVariableUsedInChildBlock): Remove.
5730 (Block.IsVariableUsedInBlock): Likewise.
5731 (Block.CheckInvariantMeaningInBlock): New. Show location of
5732 conflicting declaration.
5733 (Block.AddVariable): Make error messages less long-winded and more
5734 specific. Show location of conflicting declaration.
5735 * parameter.cs (Parameters.Location): New readonly property.
5737 2005-03-31 Raja R Harinath <rharinath@novell.com>
5739 Clean up semantics of invoking ResolveMemberAccess.
5740 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
5741 can have an instance, ensure that we pass in a non-TypeExpression
5742 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
5743 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
5744 argument. Update to changes and simplify.
5745 (FieldExpr.Emitinstance): Remove CS0120 check.
5746 (PropertyExpr.EmitInstance): Likewise.
5747 * expression.cs (Argument.Resolve): Likewise.
5748 (Invocation.DoResolve): Update to changes in semantics of
5751 2005-03-31 Marek Safar <marek.safar@seznam.cz>
5754 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
5757 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
5759 2005-03-31 Raja R Harinath <rharinath@novell.com>
5761 Fix difference in behaviour with commandline invocation.
5762 * driver.cs (Driver.Reset): New.
5763 (CompilerCallableEntryPoint): Call it.
5765 * statement.cs (If.Resolve): Avoid spurious "uninitialized
5766 variable" warnings if the boolean expression failed to resolve.
5768 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
5770 * attribute.cs: Fix the union of several permissions when some of them
5771 are unrestricted (so the result isn't an unrestricted permission set).
5774 2005-03-30 Raja R Harinath <rharinath@novell.com>
5776 * ecore.cs (MemberExpr): New class. Convert from interface
5778 (MemberExpr.ResolveMemberAccess): Refactor and move here from
5779 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
5781 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
5782 (MethodGroupExpr.IsExplicitImpl): Remove.
5783 (Expression.GetFieldFromEvent): Remove.
5784 (SimpleName.MemberStaticCheck): Remove.
5785 (SimpleName.DoSimpleNameResolve): Update to changes.
5786 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
5787 (MemberAccess.IdenticalNameAndTypeName): Remove.
5788 (MemberAccess.error176): Move to MemberExpr.
5789 (MemberAccess.DoResolve): Update to changes.
5790 (BaseAccess.DoResolve): Likewise.
5792 2005-03-30 Marek Safar <marek.safar@seznam.cz>
5794 C# 2.0 Conditional attribute class implementation
5796 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
5797 Analyzes class whether it has attribute which has ConditionalAttribute
5798 and its condition is not defined.
5800 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
5801 (Class.IsExcluded): New method. Search for at least one defined
5802 condition in ConditionalAttribute of attribute class.
5804 2005-03-30 Raja R Harinath <rharinath@novell.com>
5806 * ecore.cs (PropertyExpr): Derive from Expression, not
5807 ExpressionStatement.
5808 (PropertyExpr.EmitStatement): Remove.
5810 2005-03-29 Raja R Harinath <rharinath@novell.com>
5813 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
5814 internal field "value__" of an enum be private. The examples for
5815 "value__" that I found on MSDN all used FieldAttributes.Private.
5817 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
5818 Don't mention IL method attribute names.
5820 Fix #47991. Remove a TODO.
5821 * statement.cs (Block.Toplevel): Make into a field.
5822 (Block.Parameters): Move into ToplevelBlock.
5823 (Block.known_variables): Rename from child_variable_names.
5824 (Block.Block): Remove variants that take Parameters. Initialize
5825 'Toplevel' with the immediately surrounding toplevel block.
5826 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
5827 LocalInfo parameter.
5828 (Block.GetKnownVariableInfo): New.
5829 (Block.IsVariableNameUsedInChildBlock): Update.
5830 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
5831 the block, even though it may not be in scope.
5832 (Block.AddVariable): Remove Parameters parameter. Use
5833 Toplevel.Parameters instead.
5834 (Block.AddConstant): Remove Parameters parameter.
5835 (Block.GetParameterReference): Update to use Toplevel.Parameters.
5836 (Block.IsParamaterReference): Likewise.
5837 (Block.IsLocalParameter): Likewise. Simplify a lot.
5838 (ToplevelBlock.Parameters): New. Moved from Block.
5839 (ToplevelBlock.ToplevelBlock): Update to changes. Always
5840 initialize Parameters to a non-null value.
5841 * cs-parser.jay: Update to changes.
5842 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
5843 simple names that mean different things in the same block. Use
5844 Block.IsVariableNameUsedInBlock.
5846 2005-03-28 Raja R Harinath <rharinath@novell.com>
5848 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
5850 2005-03-26 Raja R Harinath <harinath@acm.org>
5853 * assign.cs (Assign.DoResolve): When the RHS of an assignment
5854 fails to resolve, ensure that the LHS is still resolved as an
5857 2005-03-25 Raja R Harinath <harinath@acm.org>
5859 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
5861 (Enum.current_ec): Remove.
5862 (Enum.LookupEnumValue): Remove EmitContext argument.
5863 Just uses the one created during DefineType.
5864 (Enum.FindMembers): Update.
5865 * expression.cs (MemberAccess.DoResolve): Update.
5867 2005-03-22 Marek Safar <marek.safar@seznam.cz>
5869 * assign.cs (Assign.DoResolve): Check for CS1717 when
5870 source and target are same (uses Equals).
5872 * expression.cs (LocalVariableReference, ParameterReference,
5873 This): Implemented Equals, GetHashCode.
5875 * statement.cs (Block.GetParameterReference): Removed useless
5878 2005-03-22 Raja R Harinath <rharinath@novell.com>
5881 * statement.cs (Block.AddVariable): Ensure that we skip implicit
5882 blocks before deciding whether the error is cs0136 or cs0128.
5884 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
5885 (using_alias_directive, using_namespace_directive): Pass
5886 MemberName, not an expression to Namespace.UsingAlias and
5888 (MakeName): Use the MemberName of the namespace.
5889 * namespace.cs (Namespace.MemberName): New.
5890 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
5891 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
5893 * decl.cs (MemberName.Name): Make readonly.
5894 (MemberName.FromDotted): New "constructor".
5895 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
5896 (MemberCore.Name): Compute from MemberName on demand.
5897 (MemberCore.SetMemberName): Provide a way to change the
5899 (MemberCore.AddToContainer): Don't take a fullname parameter.
5900 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
5901 fully qualified name of the container to the member name.
5902 (TypeContainer.AddToTypeContainer): Use a fully qualified name
5903 only if the type is a member of the root container.
5904 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
5905 MemberName.Left rather than searching for an embedded ".".
5906 (PartialContainer.CreatePart): Update to changes in RootContext.
5907 (MemberBase.ShortName): Turn into a property. Use
5908 MemberCore.SetMemberName.
5909 (MemberBase.ExplicitInterfaceName): Remove.
5910 (MemberBase.UpdateMemberName): Remove.
5911 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
5912 (PropertyBase.SetMemberName): New override.
5913 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
5914 (Tree.GetDecl): New.
5915 (Tree.AllDecls): Rename from Decls.
5916 * attribute.cs, enum.cs, report.cs: Update to changes.
5917 * driver.cs (MainDriver): Use MemberName.FromDotted on
5918 RootContext.MainClass.
5920 2005-03-21 Marek Safar <marek.safar@seznam.cz>
5922 * class.cs (FixedField.Define): Check for CS1664 and more sanity
5925 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
5927 2005-03-18 Marek Safar <marek.safar@seznam.cz>
5929 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
5930 property accessor modifiers.
5932 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
5933 fixed buffer attribute (CS1716).
5934 (PropertyMethod.HasCustomAccessModifier): When property accessor
5935 has custom modifier.
5937 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
5939 (PropertyExpr.DoResolveLValue): Add CS0272.
5941 2005-03-17 Miguel de Icaza <miguel@novell.com>
5943 * convert.cs: When converting to a pointer, use the proper Conv.U
5944 or Conv.I depending on the source data type.
5946 * cs-tokenizer.cs: Make the size for large decimal constants,
5949 2005-03-17 Martin Baulig <martin@ximian.com>
5951 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
5952 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
5954 2005-03-17 Martin Baulig <martin@ximian.com>
5956 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
5957 to bool so we can return an error condition.
5958 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
5961 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
5963 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
5966 2005-03-16 Raja R Harinath <rharinath@novell.com>
5968 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
5969 Refactor to avoid traversing the list of assemblies, and to avoid
5970 string concatenation.
5971 * typemanager.cs (guid_attr_type): Remove.
5972 (negative_hits, pointers, references): Remove hashes.
5974 (GetConstructedType): New. Uses type_hash to handle constructed
5975 types (arrays, references, pointers).
5976 (GetReferenceType, GetPointerType): Use it.
5977 (GetNestedType): New. Uses type_hash to handle nested types of
5979 (LookupType, LookupTypeDirect): Remove.
5980 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
5981 'types' hash and LookupTypeReflection directly.
5982 (params_string, params_object): Use GetConstructedType.
5983 * namespace.cs (Namespace.cached_types): New. Cache of reflected
5985 (Namespace.Lookup): Use cached_types.
5986 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
5987 provided by old TypeManager.LookupType.
5988 * rootcontext.cs (MakeFQN): Remove.
5989 * decl.cs (DeclSpace.MakeFQN): Likewise.
5990 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
5991 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
5992 TypeManager.GetConstructedType.
5993 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
5995 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
5997 * cs-parser.jay: Fix build.
5999 2005-03-15 Marek Safar <marek.safar@seznam.cz>
6001 * class.cs (TypeContainer.CircularDepException) New nested
6002 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
6004 * cs-parser.jay: Reports CS1527 for any namespace element.
6006 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
6009 * expression.cs (ParameterReference.IsAssigned): Changed error to
6011 (Error_WrongNumArguments): Moved CS0245 detection here.
6013 * statement.cs (Return.Resolve): Add CS1622 report.
6015 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6017 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6019 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6021 * attribute.cs expression.cs: Get rid of some allocations.
6023 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6025 * doc.cs : just eliminate the latest change.
6027 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6029 * doc.cs : commented out the latest change. It breaks xml-030.cs
6031 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6033 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6034 fail. So invoke CreateType() in FindDocumentedType().
6036 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6038 * cs-tokenizer.cs : added IsKeyword().
6039 * doc.cs : Detect keyword incorrectly used as identifier.
6040 Allow identifiers prefixed by @.
6042 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6044 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6045 It caused exception in namespace resolving (again!).
6047 * class.cs (Class.ctor): Removed exit.
6048 (PropertyMethod.ctor): ditto.
6050 * codegen.cs (Codegen.Reset): Reset static data.
6051 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6053 * cs-tokenizer.cs (Cleanup): Removed.
6055 * driver.cs (GetSystemDir): Rewrote to one line command.
6056 It caused problem with unloaded dynamic modules.
6057 (UnixParseOption): Removed Exit.
6058 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6059 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6060 Now can be mcs used as library.
6062 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6065 * location.cs (Reset): Reset static data.
6067 * namespace.cs (Reset): Reset static data.
6069 * report.cs (Report.Reset): Reset static data.
6071 * rootcontext.cs (RootContext.Reset): Reset static data.
6073 * tree.cs (RootTypes.ctor): Use Location.Null
6075 * typemanager.cs (TypeManager.Reset): Reset static data.
6076 (CoreLookupType): Removed Exit.
6077 (TypeHandle.Reset): Reset static data.
6079 2005-03-10 Raja R Harinath <rharinath@novell.com>
6082 * typemanager.cs (ComputeNamespaces): Import namespaces from
6083 referenced modules too.
6085 2005-03-09 Raja R Harinath <rharinath@novell.com>
6087 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6090 2005-03-09 Raja R Harinath <rharinath@novell.com>
6092 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6093 enclosing DeclSpace. This ensures that a name-lookup populates
6094 more caches and there are fewer 'TypeExpression's. Carve out
6095 nested type lookup into ...
6096 (LookupNestedTypeInHierarchy): ... this.
6098 2005-04-15 Martin Baulig <martin@ximian.com>
6100 Merged r41590 from MCS and make it work in the generics land.
6102 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6105 * class.cs (PartialContainer.UpdateConstraints): Removed.
6106 (PartialContainer.CheckConstraints): Removed.
6107 (PartialContainer.SetParameterInfo): Store the constraints here.
6108 (PartialContainer.DefineTypeParameters): New public method;
6109 resolve the type parameter's constraints here. Note that the
6110 PartialContainer doesn't have an EmitContext anymore, so we must
6111 do this in the ClassPart.
6113 2005-03-09 Raja R Harinath <rharinath@novell.com>
6115 Clean up a few partial-class semantics.
6116 Fixes test-357.cs and cs1618-2.cs.
6117 * cs-parser.jay (struct_declaration): Use 'current_class' as
6118 parent of newly-created struct. Remove call to Register ().
6119 Use 'pop_current_class' to complete handing the current struct.
6120 (interface_declaration): Likewise.
6121 (class_declaration): Likewise.
6122 (enum_declaration): Use 'current_class' as parent of newly created
6124 (delegate_declaration): Likewise.
6125 (pop_current_class): New function. This is used to handle closing
6126 up the 'current_class' and 'current_container', and pointing them
6127 to the enclosing class/container.
6128 (CSharpParser): Initialize 'current_class' too.
6129 * decl.cs (MemberCore): Add check for invariant: a partial
6130 container is not a parsed entity, and thus does not enclose any
6132 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6133 (DeclSpace.BaseTypeExpr): Use it.
6134 (DeclSpace.LookupType): Add check for invariant.
6135 * class.cs (TypeContainer): Add check for invariant: a nested
6136 class should have the same NamespaceEntry as its enclosing class.
6137 (TypeContainer.EmitFieldInitializers): Make virtual.
6138 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6140 (TypeContainer.Register): Remove.
6141 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6142 null. Use TypeResolveEmitContext for resolving base types and
6143 interfaces. Move initialization of Parts.TypeBuilder here from
6145 (TypeContainer.DefineNestedTypes): ... here.
6146 (PartialContainer): Take a Namespace not a NamespaceEntry.
6147 (PartialContainer.Create): Don't use Register. Call the
6148 appropriate Add... function directly.
6149 (ClassPart): Take both the PartialContainer and the enclosing
6150 class as constructor arguments.
6151 (ClassPart.EmitFieldInitializers): Override.
6152 (ClassPart.PartFindNestedTypes): Remove.
6153 (FieldBase.GetInitializerExpression): Resolve the initializer
6154 expression in the emit context of the enclosing class.
6155 * tree.cs (RootTypes): Remove Register ().
6157 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6159 * cs-parser.jay: Removed CS0134.
6161 * driver.cs: Removed CS1901.
6163 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6164 for predefined types.
6166 2005-03-07 Duncan Mak <duncan@novell.com>
6168 * codegen.cs (Save): Catch UnauthorizedAccessException as
6169 well. Fixes bug #73454.
6171 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6173 * cs-tokenizer.cs (xtoken): Add CS1035.
6175 * class.cs (MethodData.Define): Add CS0683.
6176 (FieldMember.ctor): Add CS0681.
6178 2005-03-07 Raja R Harinath <rharinath@novell.com>
6180 * ecore.cs (SimpleName.DoResolve): Rename from
6181 SimpleName.DoResolveAllowStatic.
6182 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6183 Pass 'intermediate' flag to MemberStaticCheck.
6184 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6185 of "intermediate" lookups via MemberAccess.
6186 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6187 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6189 2005-03-07 Raja R Harinath <rharinath@novell.com>
6192 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6193 slipped in because of variable names that are identical to a
6194 builtin type's BCL equivalent ('string String;', 'int Int32;').
6195 (PropertyExpr.EmitInstance): Likewise.
6197 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6199 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6201 * report.cs (warning_ignore_table): Made public.
6203 2005-03-04 Raja R Harinath <rharinath@novell.com>
6206 * class.cs (MethodData.Emit): Pass 'container' to
6207 container.GetObsoleteAttribute instead of 'container.Parent'.
6209 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6211 * cs-parser.jay: Add 1534 error test.
6213 * iterators.cs (Yield.CheckContext): Add error 1629.
6214 (Iterator.ctor): Save unsafe modifier.
6215 (MoveNextMethod.DoEmit): Restore unsafe context.
6217 * namespace.cs (UsingAlias): Better error message.
6219 2005-03-03 Dan Winship <danw@novell.com>
6221 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6222 the warning message [#73219]
6224 2005-03-03 Raja R Harinath <rharinath@novell.com>
6226 Fix compile with MCS 1.0.0.0.
6227 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6228 w_restore to not depend on string constant folding.
6230 2005-03-03 Raja R Harinath <rharinath@novell.com>
6232 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6233 CS0246 check to users who passed 'silent = false'.
6234 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6236 (SimpleName.SimpleNameResolve): Update.
6237 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6238 (MemberAccess.IdenticalNameAndTypeName): Update.
6239 * doc.cs (FindDocumentedTypeNonArray): Update.
6241 2005-03-03 Raja R Harinath <rharinath@novell.com>
6243 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6244 * parameters.cs (ComputeAndDefineParameters): Remove.
6245 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6246 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6247 Use GetParameterInfo.
6249 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6251 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6253 2005-03-02 Raja R Harinath <rharinath@novell.com>
6255 Unify DeclSpace.LookupType and DeclSpace.FindType.
6256 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6257 is in charge of defining nested types on demand.
6258 (DeclSpace.LookupType): Use it when the current_type is a
6259 TypeBuilder. Use LookupTypeDirect for reflected types.
6260 (DeclSpace.FindType): Remove.
6261 (DeclSpace.LookupInterfaceOrClass): Likewise.
6262 (DeclSpace.DefineTypeAndParents): Likewise.
6263 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6264 DeclSpace.LookupType.
6265 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6266 * typemanager.cs (LookupType): Simplify.
6267 (AddUserType): Remove type from negative_hits.
6268 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6269 * class.cs (TypeContainer.FindMembers): Move handling of nested
6271 (TypeContainer.FindMembers_NestedTypes): ... here.
6272 (TypeContainer.FindNestedType): Implement override.
6273 (ClassPart.FindNestedType): Delegate to PartialContainer.
6274 (ClassPart.PartFindNestedType): Looks up the nested types of the
6277 2005-04-14 Martin Baulig <martin@ximian.com>
6279 * generic.cs (ConstructedType): Moved all the type lookup and
6280 nested class logic into SimpleName.
6281 (ConstructedType.ResolveConstructedType): Our underlying type is
6282 already fully resolved; all the type lookup stuff is in
6285 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6286 constructed types here instead of in ConstructedType.
6288 * decl.cs (MemberName.GetTypeExpression): Always create a
6289 SimpleName, not a ConstructedType.
6290 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6292 2005-03-02 Martin Baulig <martin@ximian.com>
6294 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6295 static constructor in static classes.
6297 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6299 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6300 sizeParamIndex is not specified.
6302 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6305 * report.cs (WarningMessage.IsEnabled): Missing null check.
6307 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6309 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6310 in the fields and not in the properties.
6312 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6314 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6317 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6319 * attribute.cs: Small refactoring (improved robustness).
6320 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6321 (ValidateGuid): Removed.
6322 (Resolve): Removed referenced to above mentioned.
6323 (GetAttributeUsage): Made private and changed to work without
6325 (GetIndexerAttributeValue): Don't crash.
6326 (GetConditionalAttributeValue): Ditto.
6327 (GetClsCompliantAttributeValue): Ditto.
6328 (ExtractSecurityPermissionSet): All attributes exceptions are
6330 (GetPropertyValue): New helper.
6331 (GetMethodImplOptions): New method.
6332 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6333 some missing properties.
6335 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6336 (Method.ApplyAttributeBuilder): Updated.
6338 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6341 2005-02-28 Raja R Harinath <rharinath@novell.com>
6344 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6345 non-simple types (array, pointer, reference).
6347 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6349 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6351 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6353 (Method.CheckBase): Catch wrong destructor here.
6354 (MethodData.Define): Add errors 550, 668.
6356 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6358 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6360 * pending.cs (VerifyPendingMethods): Add error 551.
6362 * typemanager.cs (CSharpName): Next error report helper.
6364 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6366 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6367 attributes. Removed useless attribute double check.
6368 It saves almost 2MBs for corlib.
6370 2005-02-25 Raja R Harinath <rharinath@novell.com>
6373 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6374 called twice in case of error.
6376 2005-02-23 Chris Toshok <toshok@ximian.com>
6378 Fix compiler portions of #72827.
6379 * statement.cs (Block.Emit): call Begin/EndScope on the
6380 EmitContext instead of the ILGenerator.
6382 * codegen.cs (EmitContext.BeginScope): new method, call
6383 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6385 (EmitContext.BeginScope): same, but EndScope and CloseScope
6387 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6388 offset and call the superclass's OpenScope(int) with it.
6389 (SymbolWriter.CloseScope): get the current il
6390 offset and call superclass's CloseScope(int) with it.
6392 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6394 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6395 CS1677 for out and ref as well.
6397 * class.cs (Method.Define): Add error CS1599 detection.
6399 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6401 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6403 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6405 * support.cs.cs (ModifierDesc): New helper method.
6407 2005-02-23 Raja R Harinath <rharinath@novell.com>
6408 Abin Thomas <projectmonokochi@rediffmail.com>
6409 Anoob V E <projectmonokochi@rediffmail.com>
6410 Harilal P R <projectmonokochi@rediffmail.com>
6413 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6414 MemberLookup (used for error reporting) actually returns a result.
6415 Fix error report number (122, not 112).
6417 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6418 Anoob V E <projectmonokochi@rediffmail.com>
6419 Harilal P R <projectmonokochi@rediffmail.com>
6422 * pending.cs (PendingImplementation.GetAbstractMethods):
6423 Find NonPublic members too.
6425 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6427 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6430 * class.cs (MethodCore.CheckMethodAgainstBase):
6431 Add error 239 report.
6433 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6435 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6437 * class.cs (Operator.Define): Add error 217 report.
6439 2005-02-21 Raja R Harinath <rharinath@novell.com>
6442 * expression.cs (Invocation.IsApplicable): Make public.
6443 (Invocation.IsParamsMethodApplicable): Likewise.
6444 * delegate.cs (Delegate.VerifyApplicability): Don't use
6445 Invocation.VerifyArgumentCompat for parameter applicability
6446 testing. Use Invocation.IsApplicable and
6447 Invocation.IsParamsMethodApplicable.
6449 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6451 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6453 * class.cs (Operator.Define): Add error 217 report.
6455 2005-02-21 Raja R Harinath <rharinath@novell.com>
6457 * namespace.cs (UsingEntry.Resolve): Undo change below.
6459 2005-02-21 Raja R Harinath <rharinath@novell.com>
6462 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6463 disable the error message when the extended MemberLookup also
6465 (Expression.MemberLookupFinal): Update.
6466 (SimpleName.DoSimpleNameResolve): Update.
6467 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6468 Don't use MemberLookupFinal.
6469 (New.DoResolve): Update.
6470 (BaseAccess.CommonResolve): Update.
6472 2005-02-21 Raja R Harinath <rharinath@novell.com>
6475 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6476 occured previously, don't resolve again.
6478 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6481 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6482 argument. Call ResolveAttributeUsage for unresolved.
6483 when types doesn't match ctor arguments.
6485 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6486 for nested attribute classes.
6487 (Class.attribute_usage): Removed.
6488 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6489 for attribute class.
6491 * ecore.cs (IsAttribute): Removed.
6493 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6495 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6497 (attribute_types): Removed.
6498 (EmitCode): Global attributes are emited as the latest.
6500 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6502 * class.cs (EmitFieldInitializers): Don't emit field initializer
6503 for default values when optimilization is on.
6505 * constant.cs (Constant.IsDefaultValue): New property.
6507 * driver.cs: Add /optimize handling.
6511 * literal.cs: Implement new IsDefaultValue property.
6513 * rootcontext.cs (Optimize): New field, holds /optimize option.
6515 2005-02-18 Raja R Harinath <rharinath@novell.com>
6517 Fix crasher in re-opened #72347.
6518 * namespace.cs (Namespace.Lookup): Return null if
6519 DeclSpace.DefineType returns null.
6522 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6524 2005-02-18 Raja R Harinath <rharinath@novell.com>
6526 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6527 now returns null if it cannot resolve to an lvalue.
6528 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6529 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6530 returned null. Remove check for SimpleName.
6531 (EventExpr.DoResolveLValue): New.
6532 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6533 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6535 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6537 (Unary.ResolveOperator): Move CS0211 check ...
6538 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6540 (Unary.DoResolveLValue): Simplify.
6541 (AddressOf.DoResolveLValue): New.
6542 (ArrayAccess.DoResolveLValue): New.
6544 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6546 * attribute.cs (Attribute.Resolve): Add arguments casting for
6547 when types doesn't match ctor arguments.
6549 2005-02-16 Raja R Harinath <rharinath@novell.com>
6551 Fix parts of #63202.
6552 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6553 lookup of operator in base type. Ensure that all checks happen
6554 when the operator resolves to an "op_..." method.
6556 2005-02-15 Raja R Harinath <rharinath@novell.com>
6559 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6560 'ignore_cs0104' parameter. Pass it to ...
6561 (NamespaceEntry.Lookup): ... this.
6562 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6563 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6564 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6565 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6566 Update. Request that cs0104 errors be ignored.
6567 (ComposedCast.ResolveAsTypeStep): Update.
6569 2005-02-14 Raja R Harinath <rharinath@novell.com>
6572 * expression.cs (Invocation.BetterFunction): Remove support for
6573 comparing virtual functions and their overrides.
6574 (Invocation.IsOverride): New.
6575 (Invocation.OverloadResolve): Don't consider 'override' functions
6576 during candidate selection. Store them in a lookaside list.
6577 If the selected method is a 'virtual' function, use the list to
6578 find any overrides that are closer to the LHS type.
6580 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6582 * expression.cs (New.DoResolve): Add complex core type reduction.
6583 (New.Constantify): Converts complex core type syntax like 'new int ()'
6586 2005-02-14 Raja R Harinath <rharinath@novell.com>
6588 * decl.cs (EntryType.EntryType): New constructor to create an
6589 updated copy of a cache entry.
6590 (MemberCache.AddMethods): Use it.
6591 (MemberCache.ClearDeclaredOnly): Remove.
6592 (MemberCache.MemberCache): Update.
6594 2005-02-11 Miguel de Icaza <miguel@novell.com>
6596 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6597 variable. This one is represents the actual low-level declaration
6598 of the method, as opposed to the semantic level `IsStatic'.
6600 An anonymous method which is hosted into a static method might be
6601 actually an instance method. IsStatic would reflect the
6602 container, while MethodIsStatic represents the actual code
6605 * expression.cs (ParameterReference): Use the new MethodIsStatic
6606 instead of IsStatic.
6608 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6609 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6610 set on the current EmitContext.
6612 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6613 resolve our casted expression as an LValue. This triggers the
6614 proper LValue processing that is later required by Assign.
6618 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6620 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6622 C# 2.0 Fixed buffer implementation
6624 * anonymous.cs: Update after RegisterHelperClass renaming.
6626 * attribute.cs (AttributeTester.fixed_buffer_cache):
6627 Cache of external fixed buffers.
6628 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
6629 implementation if field is fixed buffer else null.
6632 (TypeContainer.AddField): Accept FieldMember instead of Field.
6633 (FieldBase.IsFieldClsCompliant): Extracted code from
6634 VerifyClsCompliance descendant customization.
6635 (FixedField): New class handles fixed buffer fields.
6636 (FixedFieldExternal): Keeps information about imported fixed
6638 (IFixedField): Make access to internal or external fixed buffer
6641 * cs-parser.jay: Add fixed buffer parsing.
6643 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
6646 * expression.cs (Indirection): Extended implementation to accept
6648 (PointerArithmetic.Emit): Get element from fixed buffer as well.
6649 (ElementAccess.MakePointerAccess): Get type as parameter.
6650 (DoResolve): Add fixed buffer field expression conversion.
6651 (DoResolveLValue): Ditto.
6652 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
6653 (ArrayPtr): Derives from FixedBufferPtr.
6654 (ArrayPtr.Emit): Add extra emit for array elements.
6656 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
6658 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
6659 for compiler generated types.
6660 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
6662 * statement.cs (Fixed): Refactored to be easier add fixed buffer
6663 and consume less memory.
6664 (Fixed.Resolve): Add fixed buffer case.
6666 * typemanager.cs (compiler_generated_attr_ctor,
6667 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
6668 (HasElementType): Add our own implementation to work on every
6671 2005-02-11 Miguel de Icaza <miguel@novell.com>
6673 * anonymous.cs (CaptureContext): Track whether `this' has been
6676 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
6677 only captured `this' if it was implicitly done (instance
6678 methods/variables were used).
6680 * codegen.cs (EmitContext.CaptureThis): New method to flag that
6681 `this' must be captured.
6683 2005-01-30 Miguel de Icaza <miguel@novell.com>
6685 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
6686 is null it means that there has been no need to capture anything,
6687 so we just create a sibling.
6689 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
6691 Just a partial fix. The other half is fairly elusive.
6693 2005-02-10 Raja R Harinath <rharinath@novell.com>
6695 Fix #52586, cs0121-4.cs.
6696 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
6697 and return a hashtable.
6698 (MemberCache.ClearDeclaredOnly): New.
6699 (MemberCache.MemberCache): Update to change. Make a deep copy of
6700 the method_hash of a base type too.
6701 (MemberCache.AddMethods): Adapt to having a deep copy of the base
6702 type methods. Overwrite entries with the same MethodHandle so
6703 that the ReflectedType is correct. The process leaves in base
6704 virtual functions and their overrides as distinct entries.
6705 (CacheEntry): Now a class instead of a struct. It shouldn't alter
6706 matters since it was boxed in a ArrayList before.
6707 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
6709 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
6710 case of a virtual function and its override (choose the overload
6712 (Invocation.OverloadResolve): Avoid 'override' members during
6713 'applicable_type' calculation.
6715 2005-03-28 Raja R Harinath <rharinath@novell.com>
6717 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
6718 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
6719 GetTypeHandle. It is possible for a reflected type to derive from
6720 a TypeBuilder (e.g., int[] derives from the TypeBuilder
6721 System.Array during mscorlib compilation).
6722 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
6723 contain a method_hash, don't create one either. Don't create a
6724 deep copy of the base cache's method_hash.
6725 (MemberCache.SetupCache): Rename back from DeepCopy.
6726 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
6727 already initialized. If we see an override function, add its
6728 underlying base virtual function to the member_hash too.
6730 2005-02-09 Raja R Harinath <rharinath@novell.com>
6732 Combine two near-redundant caches.
6733 * typemanager.cs (method_params): Rename from method_internal_params.
6734 (TypeManager.GetParameterData): New. Replace
6735 Invocation.GetParameterData.
6736 (TypeManager.LookupParametersByBuilder): Remove.
6737 * expression.cs (Invocation.method_parameter_cache): Remove.
6738 (Invocation.GetParameterData): Remove.
6740 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
6743 2005-02-08 Raja R Harinath <rharinath@novell.com>
6746 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
6747 TypeManager.multicast_delegate_type is null, resolve it by looking
6748 up "System.MulticastDelegate".
6749 * rootcontext.cs (RootContext.ResolveCore): Simplify.
6751 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
6752 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
6753 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
6756 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
6757 (LabeledStatement.AddReference): New. Set 'referenced'.
6758 (Goto.Resolve): Use it.
6760 2005-02-05 John Luke <john.luke@gmail.com>
6762 * driver.cs: remove duplicate -doc line in Usage ()
6764 2005-02-04 Raja R Harinath <rharinath@novell.com>
6766 * location.cs (Location.AddFile): Fix CS2002 error report.
6768 2005-02-02 Martin Baulig <martin@ximian.com>
6770 * delegate.cs (Delegate.DefineType): Report an internal error if
6771 TypeManager.multicast_delegate_type is null. See bug #72015 for
6774 2005-02-02 Raja R Harinath <rharinath@novell.com>
6776 Fix a crasher in a variant of #31984.
6777 * const.cs (Constant.CheckBase): New override that defers the
6778 new-or-override check in case the base type hasn't been populated
6780 (Constant.Define): Ensure the new-or-override check is performed.
6782 2005-02-01 Duncan Mak <duncan@ximian.com>
6784 * const.cs (LookupConstantValue): Check that `ce' is not null
6785 before calling GetValue ().
6787 2005-02-01 Raja R Harinath <rharinath@novell.com>
6789 Fix test-334.cs (#69519).
6790 * cs-parser.jay (using_alias_directive): Pass in an expression to
6791 NamespaceEntry.UsingAlias.
6792 (using_namespace_directive): Pass in an expression to
6793 NamespaceEntry.Using.
6794 (namespace_name): Don't flatten to a string.
6795 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
6796 (NamespaceEntry.AliasEntry.Resolve): Lookup using
6798 (NamespaceEntry.UsingEntry): Likewise.
6799 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
6801 (NamespaceEntry.LookupForUsing): Remove.
6802 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
6804 (NamespaceEntry.Lookup): Remove support for dotted names.
6806 2005-02-01 Raja R Harinath <rharinath@novell.com>
6808 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
6810 (NamespaceEntry.ImplicitParent): Compute on demand.
6811 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
6812 parallels the current.
6813 (NamespaceEntry.LookupForUsing): Use it.
6814 (NamespaceEntry.Lookup): If the current namespace-entry is
6815 implicit, don't search aliases and using tables.
6817 2005-02-01 Raja R Harinath <rharinath@novell.com>
6820 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
6822 (TypeContainer.BaseCache): Compute on demand.
6823 (TypeContainer.FindMembers): Define constants and types if they're
6824 not already created.
6825 (FieldMember.Define): Move resetting of ec.InUnsafe before error
6827 * const.cs (Constant.Define): Make idempotent.
6829 2005-01-29 Miguel de Icaza <miguel@novell.com>
6831 * pending.cs: Produce better code (no nops produced by using Ldarg
6834 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
6835 i - 1' it should be arg + 1.
6839 2005-01-28 Raja R Harinath <rharinath@novell.com>
6841 * attribute.cs (Attribute.CheckAttributeType): Make private
6843 (Attribute.ResolveType): Make virtual.
6844 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
6845 handling of RootContext.Tree.Types.
6847 2005-01-27 Raja R Harinath <rharinath@novell.com>
6849 Update attribute-handling to use the SimpleName/MemberAccess
6851 * cs-parser.jay (attribute): Pass in an expression to the
6852 constructors of Attribute and GlobalAttribute.
6853 * attribute.cs (Attribute): Take an expression for the name.
6854 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
6855 passed in attribute name expression.
6856 (Attribute.CheckAttributeType): Use it.
6857 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
6858 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
6859 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
6860 argument to prevent error messages if the lookup fails.
6862 2005-01-27 Marek Safar <marek.safar@seznam.cz>
6864 * expression.cs (Indirection): Implemented IVariable interface
6865 to support indirection in AddressOf operator.
6866 (PointerArithmetic.Emit): Add optimalization for case where
6867 result can be precomputed.
6869 2005-01-26 Martin Baulig <martin@ximian.com>
6871 * class.cs (TypeContainer.AttributeTargets): Return the correct
6872 AttributeTargets depending on our `Kind' instead of throwing an
6873 exception; fixes #71632.
6875 2005-01-26 Marek Safar <marek.safar@seznam.cz>
6878 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
6881 2005-03-17 Martin Baulig <martin@ximian.com>
6883 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6884 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6886 2005-03-17 Martin Baulig <martin@ximian.com>
6888 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6889 to bool so we can return an error condition.
6890 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6893 2005-03-17 Martin Baulig <martin@ximian.com>
6895 * generic.cs (TypeMananager.IsIEnumerable): New public method.
6897 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
6898 converting from an array-type of T to `IEnumerable<T>'.
6900 2005-03-16 Martin Baulig <martin@ximian.com>
6902 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
6903 (Nullable.LiftedUnaryMutator): New public class.
6905 * expression.cs (UnaryMutator.DoResolve): Added support for
6908 2005-03-14 Martin Baulig <martin@ximian.com>
6910 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
6912 2005-03-14 Martin Baulig <martin@ximian.com>
6914 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
6915 the comparision operators `<', `>', `<=' and `>='.
6917 2005-03-13 Martin Baulig <martin@ximian.com>
6920 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
6921 avoid confusion with the `NullLiteral'.
6922 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
6924 2005-03-13 Martin Baulig <martin@ximian.com>
6926 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
6927 comparing arbitrary types with the null literal.
6929 2005-03-13 Martin Baulig <martin@ximian.com>
6931 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
6932 boolean operators '&&', '||', '&' and '|'.
6933 (Nullable.OperatorTrueOrFalse): New public class.
6935 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
6936 instead of a `StaticCallExpr'; added support for nullables.
6938 2005-03-10 Martin Baulig <martin@ximian.com>
6941 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
6942 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
6944 2005-03-07 Martin Baulig <martin@ximian.com>
6946 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
6947 it work if `expr' is not an IMemoryLocation.
6948 (Nullable.Lifted): Implement IMemoryLocation.
6949 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
6952 2005-03-05 Martin Baulig <martin@ximian.com>
6954 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
6955 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
6956 (Nullable): Added support for lifted unary and binary operators.
6958 * expression.cs (Unary.DoResolve): Added support for nullable types.
6959 (Binary.DoResolve): Likewise.
6960 (Conditional.DoResolve): Likewise.
6962 2005-03-02 Martin Baulig <martin@ximian.com>
6964 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
6966 * class.cs (ClassPart.SetParameterInfo): Override this.
6967 (PartialContainer.SetParameterInfo): Override this.
6968 (TypeContainer.CheckConstraints): New protected method.
6969 (PartialContainer.CheckConstraints): Override this and check
6970 whether the same contraints were specified in all parts of a
6971 partial generic type definition.
6972 (PartialContainer.UpdateConstraints): New public method.
6974 * generic.cs (TypeParameter.UpdateConstraints): New public method.
6976 2005-03-02 Martin Baulig <martin@ximian.com>
6978 Committing a patch from Carlos Alberto Cortez to fix #72887.
6980 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
6981 casts from `T []' to `int []'.
6983 2005-03-02 Martin Baulig <martin@ximian.com>
6985 * generic.cs (TypeManager.IsEqual): Make this symmetric.
6987 * expression.cs (Binary.ResolveOperator): When resolving a
6988 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
6989 `=='. Fixes #71866. See gen-127.cs.
6991 2005-03-02 Martin Baulig <martin@ximian.com>
6993 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6994 static constructor in static classes.
6996 2005-03-02 Martin Baulig <martin@ximian.com>
6999 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
7000 (Nullable.LiftedConversion): Added support for user-defined
7003 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
7005 * cs-parser.jay: Use ComposedCast everywhere instead of
7006 NullableType, so we don't need to check for NullableType
7008 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
7009 case where we'll be resolved into a `parenthesized_expression_0'
7013 (Convert.UserDefinedConversion): Added nullable conversions.
7015 2005-02-28 Martin Baulig <martin@ximian.com>
7017 * generic.cs (TypeManager.IsNullableType): New static method.
7018 (Nullable): New abstract class.
7019 (Nullable.NullLiteral): New public class.
7020 (Nullable.LiftedConversion): New public class.
7022 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7023 `builtin_types opt_nullable'.
7026 (Convert.ImplicitConversionStandard): Added nullable conversions.
7027 (Convert.ExplicitConversionStandard): Likewise.
7028 (Convert.ExplicitConversion): Likewise.
7030 2005-02-26 Martin Baulig <martin@ximian.com>
7032 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7033 begin with a "?", for instance "?[]". Don't do a type lookup if
7036 2005-02-25 Martin Baulig <martin@ximian.com>
7038 The first part of Nullable Types :-)
7040 * generic.cs (NullableType): New public class.
7041 (NullCoalescingOperator): New public class.
7042 (TypeArguments.Resolve): Add a CS0306 check.
7044 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7045 (opt_nullable): New rule.
7046 (type): Added `opt_nullable' to `namespace_or_type_name',
7047 `builtin_types' and `pointer_type'.
7048 (array_type): Added `opt_nullable'.
7049 (opt_rank_specifier_or_nullable): New rule; this is the
7050 combination of `opt_rank_specifier' and `opt_nullable'.
7051 (opt_error): New rule; catch errors here.
7052 (nullable_type_or_conditional): New rule; we use this to check for
7053 nullable and still detect the conditional operator.
7054 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7055 instead `opt_rank_specifier'.
7057 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7060 2005-02-24 Martin Baulig <martin@ximian.com>
7062 * README, README.Changes: Removed; they're old and obsolete.
7064 2005-02-22 Martin Baulig <martin@ximian.com>
7066 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7067 returned an error, set `constraints' to null to avoid a crash
7069 (TypeParameter.ResolveType): Likewise.
7071 2005-02-22 Martin Baulig <martin@ximian.com>
7074 (Constraints.ResolveTypes): Protect against being called twice.
7075 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7076 (TypeParameter.ResolveType): New public method; calls
7077 constraints.ResolveTypes().
7078 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7079 into the new ResolveType().
7080 (GenericMethod.Define): Call ResolveType() on all our
7083 2005-02-21 Martin Baulig <martin@ximian.com>
7086 (TypeManager.generic_nullable_type): New static public field.
7087 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7090 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7092 2005-02-15 Martin Baulig <martin@ximian.com>
7094 * generic.cs (ConstructedType.Constraints): Correctly check
7095 constraints if the argument type is a type parameter; fixes
7098 2005-02-02 Martin Baulig <martin@ximian.com>
7100 * delegate.cs (Delegate.DefineType): Report an internal error if
7101 TypeManager.multicast_delegate_type is null. See bug #72015 for
7104 2005-01-29 Miguel de Icaza <miguel@novell.com>
7106 * pending.cs: Produce better code (no nops produced by using Ldarg
7109 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7110 i - 1' it should be arg + 1.
7114 2005-01-26 Martin Baulig <martin@ximian.com>
7116 * cs-parser.jay (indexer_declarator): Don't report an error if we
7117 have type parameters since we can be an explicit interface
7118 implementation; fixes #71449.
7120 2005-01-26 Martin Baulig <martin@ximian.com>
7122 * class.cs (TypeContainer.AttributeTargets): Return the correct
7123 AttributeTargets depending on our `Kind' instead of throwing an
7124 exception; fixes #71632.
7126 2005-01-26 Martin Baulig <martin@ximian.com>
7128 * delegate.cs (Delegate.DefineType): Correctly define our type
7129 parameters. Fixes #71483.
7131 2005-01-25 Raja R Harinath <rharinath@novell.com>
7134 * expression.cs (MemberAccess.DoResolve): Don't complain with
7135 cs0572 when the LHS of a member access has identical name and type
7138 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7141 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7143 Create custom PermissionSet only for PermissionSetAttribute.
7145 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7148 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7149 delegates in static class.
7151 2005-01-24 Martin Baulig <martin@ximian.com>
7153 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7154 merging an implicit block, just use its reachability.
7156 * statement.cs (Block.Resolve): Make the unreachable code check
7157 work wrt. implicit blocks; see test-337 from #63842.
7159 2005-01-21 Alp Toker <alp@atoker.com>
7161 * cs-parser.jay: destructor_declaration's container is PartialContainer
7162 not Class when partial types are used, so use Kind prop instead of
7165 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7167 * cs-parser.jay: Improve error reporting when an interface
7170 2005-01-20 Dick Porter <dick@ximian.com>
7172 * support.cs: SeekableStreamReader fix from Sandor Dobos
7173 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7174 chars are read. Fixes bug 70369.
7176 2005-01-20 Raja R Harinath <rharinath@novell.com>
7178 * cs-parser.jay (catch_clause): Simplify current_block handling
7181 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7183 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7184 code with ImplicitStandardConversion to handle the implicit
7185 conversion of method groups into valid delegate invocations.
7187 The problem is that in parameter handling we were using this code
7188 path. Fixes bug #64698
7190 2005-01-19 Raja R Harinath <rharinath@novell.com>
7192 * cs-parser.jay: Fix several infelicities.
7193 - Avoid assigning to the parser value stack. Code like
7194 '$3 = null' is unclean. Synthesize a value for the code block
7196 - Avoid using oob_stack for storing location information. Use ...
7197 (_mark_): ... this. New (empty) rule. Saves the current location
7199 (foreach_statement): Avoid using oob_stack for current_block
7200 handling. Use technique used in for_statement and
7201 using_statement. Synthesize a value for the code block to store
7202 additional intermediate information.
7204 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7206 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7207 of a different type is only allowed to private fields of a
7208 containing type, not on fields of a base class.
7210 See test-174.cs and error cs0122-9.cs
7212 2005-01-13 Raja R Harinath <rharinath@novell.com>
7214 Fix test-335.cs (bug #58126).
7215 * cs-parser.jay (argument): Split out non-expression parts of the
7216 rule into 'non_simple_argument'.
7217 (invocation_expression): Support parenthesized invocations with
7218 multiple arguments, and with single non-simple arguments.
7220 2005-01-13 Raja R Harinath <rharinath@novell.com>
7222 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7225 2005-01-12 Raja R Harinath <rharinath@novell.com>
7227 Fix cs0038-1.cs, cs1640-6.cs.
7228 * ecore.cs (Expression.Resolve): Remove special-case for
7229 SimpleName in error-handling.
7230 (Expression.almostMatchedMembers): Relax access permission to
7232 (Expression.MemberLookupFailed): Handle duplicates in
7233 almostMatchedMembers list.
7234 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7235 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7236 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7237 overload if the passed in MemberInfo is a MethodBase.
7239 2005-01-25 Martin Baulig <martin@ximian.com>
7242 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7244 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7247 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7248 for non-CAS & merge permission sets properly.
7250 2005-01-11 Raja R Harinath <rharinath@novell.com>
7252 Improve standard-compliance of simple name and member access
7253 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7254 * ecore.cs (FullNamedExpression): New abstract base class
7255 for Namespaces and TypeExpressions.
7256 (ResolveFlags.SimpleName): Remove.
7257 (SimpleName): Remove support for dotted names.
7258 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7259 DeclSpace.FindType and DeclSpace.LookupType.
7260 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7261 (Expression.ExprClassName): Make member function.
7262 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7263 a namespace. Remove creation of dotted "SimpleName"s.
7264 (MemberAccess.DoResolve): Likewise.
7265 * decl.cs (DeclSpace.Cache): Make private.
7266 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7267 (DeclSpace.FindType): Update.
7268 (DeclSpace.LookupType): Move here from RootContext. Return a
7269 FullNamedExpression.
7270 * namespace.cs (Namespace): Derive from FullNamedExpression
7271 so that it can be part of expression resolution.
7272 (Namespace.Lookup): Return an FullNamedExpression.
7273 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7275 * rootcontext.cs (NamespaceLookup): Remove.
7276 (LookupType): Move to DeclSpace.
7277 * attribute.cs (CheckAttributeType): Update.
7278 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7279 (FindDocumentedTypeNonArray): Likewise.
7281 2005-01-11 Raja R Harinath <rharinath@novell.com>
7283 Fix cs0509.cs, cs1632.cs.
7284 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7285 is the same as IsInterface.
7286 (TypeContainer.GetClassBases): Likewise.
7287 * statement.cs (LabeledStatement.ig): New field.
7288 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7290 (LabeledStatement.DoEmit): Check that the label was created with
7291 the same ILGenerator.
7293 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7296 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7297 accessors to its properties.
7299 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7300 from accessors to property.
7302 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7305 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7308 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7310 * attribute.cs: Check for null and empty strings.
7312 I have lost another battle to Paolo.
7314 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7317 * class.cs (PropertyMethod): Set Parent field in ctors.
7318 (SetMethod.InternalParameters): Add unsafe switch hack.
7319 Override MarkForDuplicationCheck where it is appropriate.
7321 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7322 It says whether container allows members with the same name.
7324 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7325 Removed is_method parameter.
7327 2005-01-06 Duncan Mak <duncan@ximian.com>
7329 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7330 because the previous change led to incorrect reporting of CS1032
7331 ("Cannot define/undefine preprocessor symbols after first token in
7332 file"). Instead of using `tokens_seen' as the only flag that
7333 triggers CS1040, introduce `comments_seen'. This new flag is used
7334 to signify having seen comments on the current line, so it is
7335 unset after a newline.
7337 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7339 * doc.cs : When searching for a type, find nested type too.
7340 This fixes bug #71040.
7342 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7345 - Warn missing member comment on those classes which also does not
7346 have doc comments. Fixed bug #71041.
7347 - Don't warn missing doc comment on default constructor.
7350 2005-01-06 Duncan Mak <duncan@ximian.com>
7352 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7353 comments, set `tokens_seen' to true. This allows us to detect
7354 misplaced preprocessor directives (i.e. not at the beginning of
7355 the a line, nor after whitespaces). In that case, report error
7356 CS1040. This fixes bug #56460.
7358 * cs-parser.jay (interface_member_declaration): Add checks for
7359 IsExplicitImpl, and report CS0541 error if an interface member is
7360 defined as an explicit interface declaration.
7362 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7365 * class.cs (PropertyMethod): Set Parent field in ctors.
7366 (SetMethod.InternalParameters): Add unsafe switch hack.
7368 * decl.cs (MemberCore.Parent): Cannot be readonly.
7370 2005-01-06 Raja R Harinath <rharinath@novell.com>
7372 * decl.cs (DeclSpace.ResolveType): Remove.
7373 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7374 Merge in code from ...
7375 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7376 * class.cs, enum.cs: Update to changes.
7378 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7380 * anonymous.cs: Ensure that we init the scope of our parent if it
7381 has not been initialized yet.
7383 2004-12-30 Duncan Mak <duncan@ximian.com>
7385 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7386 if field.FieldBuilder is null. Fixes #70758.
7388 * convert.cs: Fixed some typos and updated some of the comments.
7389 (ImplicitStandardConversionExists):
7390 (TryImplicitIntConversion): If `target_type' is an interface and
7391 the type of `ic' implements this interface, return true or a new
7392 BoxedCast instead of null. This fixes #70468.
7394 2004-12-29 Duncan Mak <duncan@ximian.com>
7396 * expression.cs (Argument.Emit): Check that Expr is
7397 IMemoryLocation before casting to it, and report CS1510 otherwise.
7401 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7403 * statement.cs (Block.ThisVariable): remove the recursion here, to
7404 make the --profile more sane.
7406 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7408 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7409 assembly, by JB Evain.
7411 2004-12-17 Raja R Harinath <rharinath@novell.com>
7413 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7414 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7415 "parent" refers to enclosing type/class. "base" refers to superclass.
7417 2004-12-17 Raja R Harinath <rharinath@novell.com>
7419 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7420 Ensure that we only have GlobalAttributes.
7421 * attribute.cs (Attribute.Emit): Make non-virtual.
7422 (GlobalAttribute.Emit): Remove.
7423 (Attribute.Resolve): Make virtual.
7424 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7425 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7426 the argument. Don't create one.
7427 (Attribute.GetObsoleteAttribute): Likewise.
7428 (Attribute.GetClsCompliantAttributeValue): Likewise.
7429 * class.cs, decl.cs: Update to changes.
7431 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7433 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7435 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7437 * statement.cs (Foreach.Resolve): Add error 186 report.
7439 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7441 * expression.cs (Conditional.DoResolve): Add warning 429.
7443 * statement.cs (If.Resolve): Add warning 665.
7445 2004-12-16 Raja R Harinath <rharinath@novell.com>
7447 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7448 except when in the parser, and in GlobalAttribute.
7449 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7450 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7451 RootContext.Tree.Types.NamespaceEntry once work is done.
7452 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7453 and resets RootContext.Tree.Types.NamespaceEntry.
7455 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7457 * cs-parser.jay: Don't create a block for every variable.
7459 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7461 * location.cs: Provide extra information.
7463 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7464 variables from the captured environment, it is the ldarg_0.
7466 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7468 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7471 * class.cs: Changed warning level for 169 to avoid developer
7472 displeasure from warning flooding. It will be changed back when they
7473 fix most of current BCL warnings.
7475 * RootContext.cs: Pushed default WarningLevel to 3.
7477 * statement.cs: Removed unused variable.
7479 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7481 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7482 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7483 Add error 502 report.
7484 (StaticClass.DefineType): Add error 441 report.
7485 (Class.AllowedModifiersProp): New virtual property as temporary
7486 extension to AllowedModifiers.
7487 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7488 to share implementation with StaticClass and don't call virtual
7491 * driver.cs (MainDriver): Add error 1558 test.
7493 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7494 report. Moved error 36 test here.
7496 * statement.cs (Throw.Resolve): Add error 724 report.
7498 * typemanager.cs: Add out_attribute_type core type.
7500 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7502 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7504 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7506 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7509 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7511 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7512 Add error 3023 report.
7513 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7515 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7518 2004-12-12 John Luke <john.luke@gmail.com>
7520 * driver.cs (AddArgs): take -- into account when
7521 adding arguments, fixes bug 65710
7523 2004-12-12 Martin Baulig <martin@ximian.com>
7525 * expression.cs (Unary.TryReduceNegative): Added support for
7526 SByteConstant and ByteConstant.
7527 (Unary.Reduce): Check error values from TryReduceNegative().
7529 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7531 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7532 and report exception as error 182.
7534 2004-12-10 Raja R Harinath <rharinath@novell.com>
7536 * driver.cs (Main): Fix message when there are warnings.
7538 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7540 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7542 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7544 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7545 Reduced number of warnings.
7547 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7549 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7551 * driver.cs: Removed message.
7553 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7555 2004-12-08 <vargaz@freemail.hu>
7557 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7559 2004-12-08 Martin Baulig <martin@ximian.com>
7561 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7562 instead of a CS3002 for properties and indexer.
7564 2004-12-08 Martin Baulig <martin@ximian.com>
7566 * decl.cs (MemberName.ToString): Make this work again.
7568 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7570 * attribute.cs (Resolve): Add error 591 detection.
7572 * class.cs (FieldMember.Define): Add error 1547 detection.
7573 (Indexer.Define): Add error 620 detection.
7574 (Operator.Define): Add error 590 detection.
7576 * ecore.cs: Missing argument for error 79.
7578 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7581 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7584 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7587 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7589 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7590 Some operator comments were suppressed.
7591 * doc.cs : Implicit/explicit operator name in doc comments are like
7592 "op_Explicit(type)~returnType", so added suffix handling.
7594 2005-01-21 Alp Toker <alp@atoker.com>
7596 * cs-parser.jay: destructor_declaration's container is PartialContainer
7597 not Class when partial types are used, so use Kind prop instead of 'is'.
7599 2004-12-12 Martin Baulig <martin@ximian.com>
7601 * expression.cs (Unary.TryReduceNegative): Added support for
7602 SByteConstant and ByteConstant.
7603 (Unary.Reduce): Check error values from TryReduceNegative().
7605 2004-12-11 Martin Baulig <martin@ximian.com>
7607 * support.cs (ReflectionParameters.ParameterName): If we have a
7608 `gpd', call `ParameterName' on it.
7610 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7612 * pending.cs (PendingImplementation.DefineProxy): Call
7613 DefineParameter() for all of the MethodBuilder's arguments.
7615 2004-12-09 Martin Baulig <martin@ximian.com>
7617 * doc.cs (DocUtil): Make this a static class.
7619 2004-12-09 Martin Baulig <martin@ximian.com>
7621 * expression.cs (Invocation.InferType): Moved the type inference
7622 implementation into TypeManager.
7624 * generics.cs (TypeManager): Moved the type inference
7625 implementation here.
7627 2004-12-09 Martin Baulig <martin@ximian.com>
7629 * typemanager.cs (TypeManager): Make this a partial class.
7632 (TypeManager): Move the generics part of `TypeManager' here.
7634 2004-12-08 Martin Baulig <martin@ximian.com>
7636 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7637 instead of a CS3002 for properties and indexer. Added CS3024
7638 check for generic interfaces.
7640 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
7641 instances are not CLS-compliant.
7643 2004-12-08 Martin Baulig <martin@ximian.com>
7646 (void_pointer_expression): New rule for `void*', `void**' etc.
7647 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
7649 2004-12-08 Martin Baulig <martin@ximian.com>
7651 * expression.cs (Invocation.InferType): Removed the hack for
7652 MethodCore.MayUnify().
7654 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
7657 * class.cs (MethodCore.MayUnify): Use
7658 TypeManager.MayBecomeEqualGenericTypes().
7660 2004-12-08 Martin Baulig <martin@ximian.com>
7662 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
7663 parameter, box it. Fixes #69233.
7665 2004-12-08 Martin Baulig <martin@ximian.com>
7667 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
7668 have the ctor constraint. Fixes #68326.
7670 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7672 * cs-parser.jay : interface comment was not consumed because of
7673 extra opt_semicolon before doc handling.
7675 2004-12-03 Raja R Harinath <rharinath@novell.com>
7677 Fix test-327.cs, test-328.cs, and put in early infrastructure
7678 for eventually fixing #52697.
7679 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
7680 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
7682 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
7683 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
7684 (VerifyUsing, error246): Update.
7685 * rootcontext.cs (RootContext.NamespaceLookup): Just use
7686 'NamespaceEntry.LookupNamespaceOrType'.
7688 2004-12-07 Martin Baulig <martin@ximian.com>
7690 * driver.cs: Call it "BETA SOFTWARE" :-)
7692 2004-12-06 Raja R Harinath <rharinath@novell.com>
7694 Fix crash on cs0657-17.cs.
7695 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7696 Use RootContext.Tree.Types, not 'new RootTypes ()'.
7697 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
7698 the case where the NamespaceEntry gets overwritten.
7700 2004-12-06 Marek Safar <marek.safar@seznam.cz>
7702 Fixed #69195, #56821
7703 * ecore.cs (ResolveBoolean): Tiny refactoring.
7705 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
7706 of right expression resolving when left is false constant and
7707 operator is LogicalAnd OR true constant and operator is LogicalOr.
7709 * statement.cs (ResolveUnreachable): Always reports warning.
7711 2004-12-05 Miguel de Icaza <miguel@ximian.com>
7713 * class.cs: Distinguish between 1721 and 1722 (just a little help
7714 for the programmer).
7716 2004-12-03 Miguel de Icaza <miguel@ximian.com>
7718 * delegate.cs: Only allow this on new versions of the language.
7720 2004-12-02 Duncan Mak <duncan@ximian.com>
7722 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
7724 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
7725 here as a static method. Take an additional bool out parameter
7726 `must_do_cs1540_check' for signaling to InstanceResolve.
7727 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
7728 member field from PropertyExpr class and made it an argument of
7730 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
7731 check for MarshalByRefObject, and report CS0122 instead of CS1540.
7732 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
7733 and `remove_accessor' as well as InstanceResolve: report CS0122
7738 2004-12-07 Martin Baulig <martin@ximian.com>
7740 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
7741 and CS0692 where appropriate.
7743 2004-12-06 Martin Baulig <martin@ximian.com>
7745 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
7746 IsDuplicateImplementation() and improved it.
7748 * expression.cs (Invocation.InferTypeArguments): Added
7749 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
7750 and removed the "ref" modifier from `infered_types'.
7752 * decl.cs (MemberName.ToString): Removed the exception.
7754 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
7756 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
7757 comments are allowed.
7759 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7761 * delegate.cs: Add checks for subtypes in paramaters and return values
7762 in VerifyMethod () to add support for Covariance/Contravariance
7765 2004-12-02 Miguel de Icaza <miguel@ximian.com>
7767 * report.cs: Remove extra closing parenthesis.
7769 * convert.cs (Error_CannotImplicitConversion): If the name of the
7770 types are the same, provide some extra information.
7772 2004-12-02 Marek Safar <marek.safar@seznam.cz>
7775 * attribute.cs (Resolve): Improved implementation of params
7776 attribute arguments.
7778 * support.cs (ParameterData): Add HasParams to be faster.
7780 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
7782 all things are for /doc support:
7784 * doc.cs: new file that supports XML documentation generation.
7785 * mcs.exe.sources: added doc.cs.
7787 Handle /doc command line option.
7788 Report error 2006 instead of 5 for missing file name for /doc.
7789 Generate XML documentation when required, after type resolution.
7791 Added support for picking up documentation (/// and /** ... */),
7792 including a new XmlCommentState enumeration.
7794 Added lines to fill Documentation element for field, constant,
7795 property, indexer, method, constructor, destructor, operator, event
7796 and class, struct, interface, delegate, enum.
7797 Added lines to warn incorrect comment.
7799 Added Documentation field (passed only when /doc was specified).
7801 Added DocComment, DocCommentHeader, GenerateDocComment() and
7802 OnGenerateDocComment() and some supporting private members for
7803 /doc feature to MemberCore.
7805 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
7807 Added overriden DocCommentHeader.
7809 Added overriden DocCommentHeader and GenerateDocComment().
7811 2004-12-01 Miguel de Icaza <miguel@ximian.com>
7813 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
7814 unwrapping the enumeration values, chain to
7815 DoConstantNumericPromotions again, so we can promote things to the
7816 fundamental types (takes care of enums that are bytes, sbytes).
7820 2004-12-01 Raja R Harinath <rharinath@novell.com>
7822 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
7823 Fix long-standing bug in type-lookup. Use FindType instead of
7824 LookupType when ec.ResolvingTypeTree.
7825 (Attribute.ResolveType, Attribute.Resolve)
7826 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
7828 (Attributes.Search): Remove internal version. Update.
7829 (Attributes.SearchMulti): Update.
7830 (Attributes.GetClsCompliantAttribute): Remove.
7831 (Attributes.GetIndexerNameAttribute): Remove.
7832 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
7833 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
7834 * class.cs (Indexer.Define): Likewise.
7836 2004-12-01 Marek Safar <marek.safar@seznam.cz>
7839 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
7840 MarshallByReference members access.
7842 * expression.cs: Use CheckMarshallByRefAccess;
7843 Better error CS0197 message.
7845 * report.cs: Print whole related error message.
7847 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7849 * class (GetClassBases): Better error 60 report.
7850 (EventProperty): Disabled warning 67 detection.
7852 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7855 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
7857 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
7860 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7863 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
7865 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
7867 2004-11-26 Miguel de Icaza <miguel@ximian.com>
7869 * attribute.cs (Attribute.Resolve): Refine error reporting and
7870 report a cs0117 if the identifier does not exist, to distinguish
7871 from 0617 which is a miss-use of the actual identifier.
7873 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
7874 between cs0070 and cs0079.
7876 * class.cs (MemberBase.DoDefine): When reporting a wrong
7877 accessibility level, we use MethodCore to compare instead of
7878 Method (this was a regression in some refactoring effort).
7880 So now we correctly report cs0056 again.
7882 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
7883 testing the target_type (which was known to be object_type) and
7884 not the source type (which is anonymous_method).
7886 Fixed reporting of error cs1660.
7888 * expression.cs (UserCast.Source): Expose the underlying cast.
7890 * statement.cs (Switch.SwitchGoverningType): Sort the list of
7891 allowed types to find a match to int32 first (most common).
7893 In addition, it ignores any ImplicitUserConversions that did an
7894 internal implicit conversion (as the switch statement allows only
7895 one integral conversion to exist).
7897 * class.cs (PartialContainer.Create): rename `name' to
7898 `member_name' for clarity. Then replace the string calls with a
7899 call to MemberName.GetPartialName, as now using
7900 MemberName.ToString is an error (this is due to the side effects
7901 it had, that were fixed in the past).
7903 This will restore the error reporting on a number of partial class
7904 errors that were missusing this (and getting an exception as a
7905 results, which is now just a plain textual warning, because
7906 yyparse debug output would crash otherwise).
7908 2004-11-26 Raja R Harinath <rharinath@novell.com>
7910 * Makefile (PROGRAM_INSTALL_DIR): Remove.
7912 2004-11-25 Ben Maurer <bmaurer@ximian.com>
7914 * rootcontext.cs (LookupType): Make sure to cache lookups that
7915 don't give us a negative result. This saves about 5% of corlib
7918 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7920 * report.cs (AbstractMessage.Print): messages are sent to stderr
7922 * class.cs (TypeContainer.GetClassBases): It is an error to have a
7923 non-interface in the list of interfaces (at this point, either
7924 parent was properly set, or a base class is being listed in the
7925 interfaces section).
7927 This flags error 1722, and resolves the crash from bug 69259.
7929 2004-11-25 Ben Maurer <bmaurer@ximian.com>
7931 * statement.cs (Using.EmitExpressionFinally): make this work right
7932 for valuetypes. Fixes 69926.
7934 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7936 * const.cs (Const.ChangeType): Cope with the "0 literal can be
7937 converted to an enum" here, before we try to change the underlying
7938 type. This code exists, but it is a different code path than the
7939 one used while encoding constants.
7941 (ImplicitReferenceConversionExists): In addition, resynchronized
7942 the code here, so it matches the same code in
7943 ImplicitReferenceConversionExists for the `from any class-type S
7944 to any interface-type T'.
7946 2004-11-25 Marek Safar <marek.safar@seznam.cz>
7948 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
7950 2004-11-24 Miguel de Icaza <miguel@ximian.com>
7952 * cs-parser.jay: Use verbosity accordingly.
7954 2004-11-24 Marek Safar <marek.safar@seznam.cz>
7956 * expression.cs (Unary.ResolveOperator): Do not report warning;
7957 AddressOf reads from variable.
7959 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
7961 2004-11-24 Marek Safar <marek.safar@seznam.cz>
7965 * attribute.cs (Attributable): Removed CheckTargets.
7966 (Attributes.Emit): Explicit attribute targets are tested here.
7968 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
7969 not enabled for interfaces.
7971 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
7972 (GetAssemblyName): Ouch next bug there.
7974 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7976 * expression.cs: Error 275 added.
7978 2004-11-23 Marek Safar <marek.safar@seznam.cz>
7980 Fix bug #69177 (Implemented decimal constant support)
7982 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
7983 (BinaryFold): Add DecimalConstant.
7985 * const.cs (Define): Decimal constant
7987 (ChangeType): Add decimal type handling.
7988 (LookupConstantValue): Don't set value for decimal type but
7989 emit DecimalConstantAttribute. Needed for constant optimization.
7991 * constant.cs (ToDecimal): New method.
7992 (ConvertToDecimal): New method.
7993 (IntConstant): Implemented ConvertToDecimal.
7994 (DecimalConstant.Emit): Emit optimized version for decimals in
7997 * expression.cs (ResolveOperator): Changed order of constant
7998 reduction to work correctly with native types which have
7999 overloaded operators.
8000 (ResolveMemberAccess): Extract constant value from attribute
8003 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
8005 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
8006 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
8007 (ChangeType): Decimal is special.
8008 (TypeToCoreType): Add decimal type.
8010 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8012 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8015 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8017 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8020 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8022 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8024 * pending.cs (PendingImplementation): Grab only interfaces.
8026 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8028 * statement.cs (ForeachHelperMethods): Add location member and
8029 error 202 detection.
8031 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8033 * expression.cs (DoResolveBase): Fixed wrong warning for out
8036 2004-12-04 Martin Baulig <martin@ximian.com>
8038 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8039 to check whether the conversion is ok.
8041 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8042 `Type.EmptyTypes' if we're not a generic TypeContainer.
8044 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8046 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8047 old bug: when converting from the null literal to a pointer,
8048 return an EmptyCast, not the NullLiteral.
8050 This fixes #69921, the recent null_type changes probably made this
8053 2004-12-03 Martin Baulig <martin@ximian.com>
8055 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8056 method as our child, call AnonymousMethod.Compatible() on it.
8058 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8060 * class.cs (FieldBase): Use an unused bit field from the field to
8061 encode the `has_offset' property from the FieldMember. This saves
8062 a couple of Ks on bootstrap compilation.
8064 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8065 method as our child, return the AnonymousMethod resolved
8068 * expression.cs (New.DoResolve): Allow return values from
8069 NewDelegate to also include AnonymousMethods.
8073 2004-11-29 Raja R Harinath <rharinath@novell.com>
8075 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8077 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8078 System.Runtime.InteropServices._Exception, since it's a base
8079 interface of the core type System.Exception in the net_2_0 profile.
8081 2004-11-27 Martin Baulig <martin@ximian.com>
8083 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8085 2004-11-26 Raja R Harinath <rharinath@novell.com>
8087 * Makefile: Convert to use executable.make.
8088 * gmcs.exe.sources: New.
8090 2004-11-25 Martin Baulig <martin@ximian.com>
8092 * expression.cs (Invocation.InferType): Added support for byref types.
8094 2004-11-25 Martin Baulig <martin@ximian.com>
8096 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8097 in TypeManager.TypeToCoreType().
8099 2004-11-25 Martin Baulig <martin@ximian.com>
8101 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8102 "Dispose" method from the `current_type'.
8103 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8104 DoDefineMembers() instead of using the MethodBuilder; this is
8105 required for generic iterators.
8107 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8109 2004-11-24 Martin Baulig <martin@ximian.com>
8111 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8113 2004-11-20 Martin Baulig <martin@ximian.com>
8115 * expression.cs (Invocation.InferType): Correctly infer generic
8116 instances; see gen-103.cs.
8117 (Invocation.InferTypeArguments): If a generic method doesn't have
8118 any unbound type parameters, we don't need to infer anything.
8120 2004-11-19 Raja R Harinath <rharinath@novell.com>
8122 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8124 2004-11-17 Raja R Harinath <rharinath@novell.com>
8126 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8127 (TypeHandle.GetMemberCache): New.
8128 (TypeHandle.TypeHandle): Update.
8129 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8130 (TypeManager.LookupParentInterfacesCache):
8131 Rename from LookupInterfaceCache. Optimize slightly.
8132 (TypeManager.MemberLookup_FindMembers): Update.
8133 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8135 (AddCacheContents): Rename from AddHashtable.
8136 * class.cs (TypeContainer.parent_container): Remove.
8137 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8138 (TypeContainer.DoDefineMembers): Don't initialize it.
8139 Update to name changes.
8141 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8143 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8144 that factors the code to check access modifiers on override.
8146 (PropertyBase): Use the code here.
8148 Patch from Lluis S'anchez, fixes bug #69361.
8150 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8152 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8153 routine that is used to report the use of a captured variable
8154 whose address has been taken.
8156 There are two checks: one when variables are being captured and
8157 the other check is when the address of a variable is taken.
8159 (because an anonymous methods might be resolved before *or* after
8160 the address has been taken) and
8162 * expression.cs (Conditional.DoResolve): Remove the special
8163 casing that Martin added to trueExpr and falseExpr being both
8164 NullLiteral. We get the right behavior now just by introducing
8165 the null_type into the compiler.
8167 * convert.cs (ExplicitConversion): Change the code to use
8168 null_type instead of testing `expr is NullLiteral'.
8169 (ImplicitConversionStandard): use null_type too.
8170 (ImplicitReferenceConversionExists): use null_type too.
8171 (ImplicitReferenceConversion): use null_type too.
8173 * literal.cs: The type of `NullLiteral' is now null_type instead
8175 (Resolve): Set the type here.
8177 * typemanager.cs: Introduce null_type.
8179 2004-11-18 Martin Baulig <martin@ximian.com>
8182 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8184 2004-11-18 Martin Baulig <martin@ximian.com>
8186 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8188 2004-11-18 Martin Baulig <martin@ximian.com>
8190 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8191 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8192 call ResolveConstructedType() on it to resolve it without checking
8194 (Constraints.ResolveTypes): Check them here.
8195 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8196 but don't check constraints.
8197 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8198 check constraints here.
8199 (ConstructedType.ResolveConstructedType): New public method. This
8200 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8201 resolve ourselves without checking constraints.
8203 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8205 2004-11-18 Martin Baulig <martin@ximian.com>
8208 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8210 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8212 2004-11-18 Martin Baulig <martin@ximian.com>
8214 * ecore.cs (TypeExpr.ResolveType): Removed.
8215 (Expression.ResolveAsTypeTerminal): We always return a fully
8216 resolved `TypeExpr', so we can just access its `Type'.
8218 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8220 2004-11-17 Martin Baulig <martin@ximian.com>
8222 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8223 sure we don't return any unresolved TypeExpr's.
8224 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8226 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8228 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8229 unresolved `ConstructedType's.
8231 2004-11-17 Martin Baulig <martin@ximian.com>
8233 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8235 2004-11-17 Martin Baulig <martin@ximian.com>
8238 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8240 * decl.cs (DeclSpace.ResolveType): Removed.
8241 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8243 2004-11-17 Martin Baulig <martin@ximian.com>
8245 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8246 direction, like FindMembers() does. Fixes #69546, testcase is in
8249 2004-11-16 Martin Baulig <martin@ximian.com>
8251 This is based on a patch from Marek Safar, see bug #69082.
8252 Fixes bugs #63705 and #67130.
8254 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8255 method; create a MemberCache for an interface type and cache the
8258 * decl.cs (IMemberContainer.ParentContainer): Removed.
8259 (IMemberContainer.ParentCache): New property.
8260 (MemberCache.SetupCacheForInterface): Removed.
8261 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8262 to create a cache for an interface's "parent".
8264 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8267 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8269 * statement.cs: Avoid adding bools to a hashtable.
8271 2004-11-15 Martin Baulig <martin@ximian.com>
8273 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8275 2004-11-11 Martin Baulig <martin@ximian.com>
8277 * typemanager.cs (TypeManager.GetMethodName): New method.
8279 * class.cs (MethodData.Define): Include the generic arity in the
8280 name of an explicit interface; also add it to the method name.
8282 * pending.cs (PendingImplementation.InterfaceMethod): The method
8283 name now includes the generic arity.
8285 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8287 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8288 calling an unsafe method from a safe location.
8290 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8293 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8295 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8297 * namespace.cs (VerifyUsing): use GetPartialName instead of
8300 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8302 * statement.cs (Return.Resolve): Fix regression in typo: if
8303 `in_exc', we have to request a NeedReturnLabel, this was a typo
8304 introduced in the anonymous method check-in. Fixes #69131.
8306 * Indexers were using the ShortName when defining themselves,
8307 causing a regression in the compiler bootstrap when applying the
8308 patch from 2004-11-02 (first part), now they use their full name
8309 and the bug is gone.
8311 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8313 * driver.cs: Strip the path from the names of embedded resources. Fixes
8316 2004-11-04 Raja R Harinath <rharinath@novell.com>
8318 Fix error message regression: cs0104-2.cs.
8319 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8320 (AliasEntry.Resolve): Update.
8321 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8323 (RootContext.LookupType): Update.
8325 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8327 * cs-parser.jay: Add support for handling accessor modifiers
8328 * class: Add support port accessor modifiers and error checking,
8329 define PropertyMethod.Define as virtual (not abstract anymore)
8330 * ecore.cs: Add checking for proeprties access with access modifiers
8331 * iterators.cs: Modify Accessor constructor call based in the modified
8333 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8335 * expression.cs (StringConcat): Handle being called twice,
8336 as when we have a concat in a field init with more than two
8339 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8341 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8342 special case explicit implementations, we should always produce
8343 the .property or .event declaration.
8345 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8346 since it will not return correct data if people use this
8347 unresolved in the presence of using statements (see test-313).
8349 * class.cs (MethodData.Define): If we are an explicit interface
8350 implementation, set the method name to the full name of the
8351 interface plus the name of the method.
8353 Notice that using the method.MethodName.GetFullName() does not
8354 work, as it will only contain the name as declared on the source
8355 file (it can be a shorthand in the presence of using statements)
8356 and not the fully qualifed type name, for example:
8360 class D : ICloneable {
8361 object ICloneable.Clone () {
8365 Would produce a method called `ICloneable.Clone' instead of
8366 `System.ICloneable.Clone'.
8368 * namespace.cs (Alias.Resolve): Use GetPartialName.
8370 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8372 * cs-parser.jay: Add error 1055 report.
8374 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8376 * assign.cs (Assign.DoResolve): Only do the transform of
8377 assignment into a New if the types are compatible, if not, fall
8378 through and let the implicit code deal with the errors and with
8379 the necessary conversions.
8381 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8383 * cs-parser.jay: Add error 1031 report.
8385 * cs-tokenizer.cs: Add location for error 1038.
8387 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8389 * cs-parser.jay: Add error 1016 report.
8391 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8393 * cs-parser.jay: Add errors 1575,1611 report.
8395 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8397 * cs-parser.jay: Add error 1001 report.
8399 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8402 * attribute.cs (GetMarshal): Add method argument for
8403 caller identification.
8405 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8406 agument for GetMarshal and RuntimeMissingSupport.
8408 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8410 * attribute.cs (ExtractSecurityPermissionSet): Removed
8411 TypeManager.code_access_permission_type.
8413 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8415 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8417 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8418 for obsolete use of a variable here. Fixes regression on errors
8419 cs0619-25 and cs0619-26.
8421 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8423 Fix #62358, implemented security attribute encoding.
8425 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8426 Tests permitted SecurityAction for assembly or other types.
8427 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8428 data from SecurityPermissionAttribute to PermisionSet class.
8430 * class.cs (ApplyAttributeBuilder): Added special handling
8431 for System.Security.Permissions.SecurityAttribute based types.
8433 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8434 special handling for System.Security.Permissions.SecurityAttribute
8437 * enum.cs (ApplyAttributeBuilder): Added special handling
8438 for System.Security.Permissions.SecurityAttribute based types.
8440 * parameter.cs (ApplyAttributeBuilder): Added special handling
8441 for System.Security.Permissions.SecurityAttribute based types.
8443 * rootcontext.cs: Next 2 core types.
8445 * typemanager.cs (TypeManager.security_permission_attr_type):
8446 Built in type for the SecurityPermission Attribute.
8447 (code_access_permission_type): Build in type.
8449 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8451 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8452 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8453 all of this information into
8454 EmitContext.EmitCapturedVariableInstance.
8456 * codegen.cs (EmitCapturedVariableInstance): move here the
8457 funcionality of emitting an ldarg.0 in the presence of a
8458 remapping. This centralizes the instance emit code.
8460 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8461 then emit a load of this: it means that we have reached the
8462 topmost ScopeInfo: the one that contains the pointer to the
8463 instance of the class hosting the anonymous method.
8465 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8466 captures to the topmost CaptureContext.
8468 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8470 * expression.cs (LocalVariableReference): Move the knowledge about
8471 the iterators into codegen's EmitCapturedVariableInstance.
8473 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8475 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8476 all code paths return a value from an anonymous method (it is the
8477 same as the 161 error, but for anonymous methods).
8479 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8481 The introduction of anonymous methods in the compiler changed
8482 various ways of doing things in the compiler. The most
8483 significant one is the hard split between the resolution phase
8484 and the emission phases of the compiler.
8486 For instance, routines that referenced local variables no
8487 longer can safely create temporary variables during the
8488 resolution phase: they must do so from the emission phase,
8489 since the variable might have been "captured", hence access to
8490 it can not be done with the local-variable operations from the runtime.
8494 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8495 is a toplevel block.
8497 (ToplevelBlock): A new kind of Block, these are the blocks that
8498 are created by the parser for all toplevel method bodies. These
8499 include methods, accessors and anonymous methods.
8501 These contain some extra information not found in regular blocks:
8502 A pointer to an optional CaptureContext (for tracking captured
8503 local variables and parameters). A pointer to the parent
8506 (Return.Resolve): Catch missmatches when returning a value from an
8507 anonymous method (error 1662).
8508 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8511 (Break.Resolve): ditto.
8513 (SwitchLabel): instead of defining the labels during the
8514 resolution phase, we now turned the public ILLabel and ILLabelCode
8515 labels into methods called GetILLabelCode() and GetILLabel() that
8516 only define the label during the Emit phase.
8518 (GotoCase): Track the SwitchLabel instead of the computed label
8519 (its contained therein). Emit the code by using
8520 SwitchLabel.GetILLabelCode ().
8522 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8523 whether the Local has been captured or not.
8525 (LocalInfo.IsCaptured): New property, used to tell whether the
8526 local has been captured.
8528 * anonymous.cs: Vastly updated to contain the anonymous method
8531 The main classes here are: CaptureContext which tracks any
8532 captured information for a toplevel block and ScopeInfo used to
8533 track the activation frames for various local variables.
8535 Each toplevel block has an optional capture context associated
8536 with it. When a method contains an anonymous method both the
8537 toplevel method and the anonymous method will create a capture
8538 context. When variables or parameters are captured, they are
8539 recorded on the CaptureContext that owns them, for example:
8543 MyDelegate d = delegate {
8548 Here `a' will be recorded as captured on the toplevel
8549 CapturedContext, the inner captured context will not have anything
8550 (it will only have data if local variables or parameters from it
8551 are captured in a nested anonymous method.
8553 The ScopeInfo is used to track the activation frames for local
8554 variables, for example:
8556 for (int i = 0; i < 10; i++)
8557 for (int j = 0; j < 10; j++){
8558 MyDelegate d = delegate {
8563 At runtime this captures a single captured variable `i', but it
8564 captures 10 different versions of the variable `j'. The variable
8565 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8566 recorded on a child.
8568 The toplevel ScopeInfo will also track information like the `this'
8569 pointer if instance variables were referenced (this is necessary
8570 as the anonymous method lives inside a nested class in the host
8571 type of the method).
8573 (AnonymousMethod): Expanded to track the Toplevel, implement
8574 `AnonymousMethod.Compatible' to tell whether an anonymous method
8575 can be converted to a target delegate type.
8577 The routine now also produces the anonymous method content
8579 (AnonymousDelegate): A helper class that derives from
8580 DelegateCreation, this is used to generate the code necessary to
8581 produce the delegate for the anonymous method that was created.
8583 * assign.cs: API adjustments for new changes in
8584 Convert.ImplicitStandardConversionExists.
8586 * class.cs: Adjustments to cope with the fact that now toplevel
8587 blocks are of type `ToplevelBlock'.
8589 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8590 insteda of standard blocks.
8592 Flag errors if params arguments are passed to anonymous methods.
8594 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8595 `CurrentAnonymousMethod' which points to the current Anonymous
8596 Method. The variable points to the AnonymousMethod class that
8597 holds the code being compiled. It is set in the new EmitContext
8598 created for the anonymous method.
8600 (EmitContext.Phase): Introduce a variable and an enumeration to
8601 assist in enforcing some rules about when and where we are allowed
8602 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8603 only one that enfonces this right now).
8605 (EmitContext.HaveCaptureInfo): new helper method that returns
8606 whether we have a CapturedContext initialized.
8608 (EmitContext.CaptureVariable): New method used to register that a
8609 LocalInfo must be flagged for capturing.
8611 (EmitContext.CapturedParameter): New method used to register that a
8612 parameters must be flagged for capturing.
8614 (EmitContext.CapturedField): New method used to register that a
8615 field must be flagged for capturing.
8617 (EmitContext.HaveCapturedVariables,
8618 EmitContext.HaveCapturedFields): Return whether there are captured
8619 variables or fields.
8621 (EmitContext.EmitMethodHostInstance): This is used to emit the
8622 instance for the anonymous method. The instance might be null
8623 (static methods), this (for anonymous methods that capture nothing
8624 and happen to live side-by-side with the current method body) or a
8625 more complicated expression if the method has a CaptureContext.
8627 (EmitContext.EmitTopBlock): Routine that drives the emission of
8628 code: it will first resolve the top block, then emit any metadata
8629 and then emit the code. The split is done so that we can extract
8630 any anonymous methods and flag any captured variables/parameters.
8632 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
8633 during this phase, the ILGenerator should not be used as labels
8634 and local variables declared here might not be accessible to any
8635 code that is part of an anonymous method.
8637 Exceptions to this include the temporary variables that are
8638 created by some statements internally for holding temporary
8641 (EmitContext.EmitMeta): New routine, in charge of emitting all the
8644 (EmitContext.TemporaryReturn): This method is typically called
8645 from the Emit phase, and its the only place where we allow the
8646 ReturnLabel to be defined other than the EmitMeta. The reason is
8647 that otherwise we would have to duplicate a lot of logic in the
8648 Resolve phases of various methods that today is on the Emit
8651 (EmitContext.NeedReturnLabel): This no longer creates the label,
8652 as the ILGenerator is not valid during the resolve phase.
8654 (EmitContext.EmitThis): Extended the knowledge in this class to
8655 work in anonymous methods in addition to iterators.
8657 (EmitContext.EmitCapturedVariableInstance): This emits whatever
8658 code is necessary on the stack to access the instance to a local
8659 variable (the variable will be accessed as a field).
8661 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
8662 EmitContext.EmitAddressOfParameter): Routines to support
8663 parameters (not completed at this point).
8665 Removals: Removed RemapLocal and RemapLocalLValue. We probably
8666 will also remove the parameters.
8668 * convert.cs (Convert): Define a `ConstantEC' which points to a
8669 null. This is just to prefity some code that uses
8670 ImplicitStandardConversion code and do not have an EmitContext
8673 The idea is to flag explicitly that at that point in time, it is
8674 known that the conversion will not trigger the delegate checking
8675 code in implicit conversions (which requires a valid
8678 Everywhere: pass new EmitContext parameter since
8679 ImplicitStandardConversionExists now requires it to check for
8680 anonymous method conversions.
8682 (Convert.ImplicitStandardConversionExists): If the type of an
8683 expression is the anonymous_method_type, and the type is a
8684 delegate, we invoke the AnonymousMethod.Compatible method to check
8685 whether an implicit conversion is possible.
8687 (Convert.ImplicitConversionStandard): Only do implicit method
8688 group conversions if the language level is not ISO_1.
8690 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
8691 MethodInfo for the Invoke method. used by Delegate and
8694 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
8695 method conversions if the target type is a delegate.
8697 Removed extra debugging nops.
8699 (LocalVariableReference): Turn the `local_info' into a public
8702 Add `prepared' field, the same hack used for FieldExprs to cope
8703 with composed assignments, as Local variables do not necessarily
8704 operate purely on the stack as they used to: they can be captured
8707 Add `temp' for a temporary result, like fields.
8709 Refactor DoResolve and DoResolveLValue into DoResolveBase.
8711 It now copes with Local variables that are captured and emits the
8712 proper instance variable to load it from a field in the captured
8715 (ParameterReference.DoResolveBase): During the resolve phase,
8716 capture parameters if we are in an anonymous method.
8718 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
8719 anonymous method, use the EmitContext helper routines to emit the
8720 parameter reference.
8722 * iterators.cs: Set RemapToProxy to true/false during the
8725 * parameters.cs (GetParameterByName): New helper method.
8727 * typemanager.cs (anonymous_method_type) a new type that
8728 represents an anonyous method. This is always an internal type,
8729 used as a fencepost to test against the anonymous-methodness of an
8732 2004-10-20 Marek Safar <marek.safar@seznam.cz>
8734 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
8736 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
8738 2004-11-10 Martin Baulig <martin@ximian.com>
8740 * expression.cs (Invocation.BetterFunction): If two methods have
8741 equal parameter types, but only one of them is generic, the
8742 non-generic one wins.
8743 (New.DoResolve): Don't set `is_struct' to false if we're a generic
8744 instance; just use `Type.IsValueType' to determine whether
8745 something is a struct or not.
8746 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
8747 so we can be called multiple times.
8749 2004-11-10 Martin Baulig <martin@ximian.com>
8751 * generic.cs (TypeParameter.DefineConstraints): New public method.
8752 (TypeParameter.CheckAccessLevel): Override this and return true.
8753 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
8754 override ResolveType() anymore.
8755 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
8757 2004-11-10 Martin Baulig <martin@ximian.com>
8759 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
8760 call DeclSpace.ResolveNestedType() on it.
8762 2004-11-10 Martin Baulig <martin@ximian.com>
8764 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
8765 non-null, call ParameterModifier() on it.
8767 2004-11-10 Martin Baulig <martin@ximian.com>
8770 (Iterators): Added `current_type' and `this_type' fields.
8771 (Iterators.DefineIterator): Create a new EmitContext and store it
8772 in `ec'; compute `this_type'.
8774 2004-11-10 Martin Baulig <martin@ximian.com>
8777 (TypeManager.IsPrivateAccessible): New public method.
8778 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
8780 2004-11-10 Martin Baulig <martin@ximian.com>
8782 * class.cs (TypeContainer.DefineType): Call
8783 TypeBuilder.DefineGenericParameters() before resolving the type
8785 (MethodData.parent_method): New protected field.
8786 (MethodData..ctor): Added `MethodInfo parent_method' argument.
8787 (MethodData.Define): Compute `parent_method'.
8790 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
8791 (MemberCore.GetClsCompliantAttributeValue): Likewise.
8792 (DeclSpace.ec): New protected field; store the EmitContext here.
8793 (DeclSpace.EmitContext): New public property.
8794 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
8795 (DeclSpace.ResolveNestedType): New public method.
8796 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
8797 (DeclSpace.NestedAccessible): Added `Type tb' argument.
8798 (DeclSpace.FamilyAccessible): Likewise.
8799 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
8800 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
8803 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
8806 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
8807 (Enum.Emit): Don't create a new EmitContext.
8809 2004-10-18 Martin Baulig <martin@ximian.com>
8811 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
8812 `Type' directly, but call ResolveType() on it.
8813 (Catch.Resolve): Likewise.
8814 (Foreach.Resolve): Likewise.
8816 2004-10-18 Martin Baulig <martin@ximian.com>
8818 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
8819 `Type' directly, but call ResolveType() on it.
8820 (Probe.DoResolve): Likewise.
8821 (ArrayCreation.LookupType): Likewise.
8822 (TypeOf.DoResolve): Likewise.
8823 (SizeOf.DoResolve): Likewise.
8825 2004-10-18 Raja R Harinath <rharinath@novell.com>
8827 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
8830 2004-10-17 John Luke <john.luke@gmail.com>
8832 * class.cs (Operator.GetSignatureForError): use CSharpName
8834 * parameter.cs (Parameter.GetSignatureForError): Returns
8835 correct name even if was not defined.
8837 2004-10-13 Raja R Harinath <rharinath@novell.com>
8840 * class.cs (TypeContainer.EmitContext): New property.
8841 (DefineNestedTypes): Create an emitcontext for each part.
8842 (MethodCore.DoDefineParameters): Use container's emitcontext.
8843 Pass type array to InternalParameters.
8844 (MemberBase.DoDefine): Use container's emitcontext.
8845 (FieldMember.Define): Likewise.
8846 (Event.Define): Likewise.
8847 (SetMethod.GetParameterInfo): Change argument to EmitContext.
8848 Pass type array to InternalParameters.
8849 (SetIndexerMethod.GetParameterInfo): Likewise.
8850 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
8851 * delegate.cs (Define): Pass emitcontext to
8852 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
8853 array to InternalParameters.
8854 * expression.cs (ParameterReference.DoResolveBase): Pass
8855 emitcontext to GetParameterInfo.
8856 (ComposedCast.DoResolveAsTypeStep): Remove check on
8857 ec.ResolvingTypeTree.
8858 * parameter.cs (Parameter.Resolve): Change argument to
8859 EmitContext. Use ResolveAsTypeTerminal.
8860 (Parameter.GetSignature): Change argument to EmitContext.
8861 (Parameters.ComputeSignature): Likewise.
8862 (Parameters.ComputeParameterTypes): Likewise.
8863 (Parameters.GetParameterInfo): Likewise.
8864 (Parameters.ComputeAndDefineParameterTypes): Likewise.
8865 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
8866 * support.cs (InternalParameters..ctor): Remove variant that takes
8868 * typemanager.cs (system_intptr_expr): New.
8869 (InitExpressionTypes): Initialize it.
8871 2004-10-12 Chris Toshok <toshok@ximian.com>
8873 * cs-parser.jay: fix location for try_statement and catch_clause.
8875 2004-10-18 Martin Baulig <martin@ximian.com>
8877 * class.cs (FieldMember.Define): Don't access the TypeExpr's
8878 `Type' directly, but call ResolveType() on it.
8879 (MemberBase.DoDefine): Likewise.
8881 * expression.cs (New.DoResolve): Don't access the TypeExpr's
8882 `Type' directly, but call ResolveType() on it.
8883 (ComposedCast.DoResolveAsTypeStep): Likewise.
8885 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
8886 `Type' directly, but call ResolveType() on it.
8888 2004-10-17 John Luke <john.luke@gmail.com>
8890 * class.cs (Operator.GetSignatureForError): use CSharpName
8892 * parameter.cs (Parameter.GetSignatureForError): Returns
8893 correct name even if was not defined.
8895 2004-10-13 Raja R Harinath <rharinath@novell.com>
8898 * class.cs (TypeContainer.EmitContext): New property.
8899 (DefineNestedTypes): Create an emitcontext for each part.
8900 (MethodCore.DoDefineParameters): Use container's emitcontext.
8901 Pass type array to InternalParameters.
8902 (MemberBase.DoDefine): Use container's emitcontext.
8903 (FieldMember.Define): Likewise.
8904 (Event.Define): Likewise.
8905 (SetMethod.GetParameterInfo): Change argument to EmitContext.
8906 Pass type array to InternalParameters.
8907 (SetIndexerMethod.GetParameterInfo): Likewise.
8908 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
8909 * delegate.cs (Define): Pass emitcontext to
8910 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
8911 array to InternalParameters.
8912 * expression.cs (ParameterReference.DoResolveBase): Pass
8913 emitcontext to GetParameterInfo.
8914 (ComposedCast.DoResolveAsTypeStep): Remove check on
8915 ec.ResolvingTypeTree.
8916 * parameter.cs (Parameter.Resolve): Change argument to
8917 EmitContext. Use ResolveAsTypeTerminal.
8918 (Parameter.GetSignature): Change argument to EmitContext.
8919 (Parameters.ComputeSignature): Likewise.
8920 (Parameters.ComputeParameterTypes): Likewise.
8921 (Parameters.GetParameterInfo): Likewise.
8922 (Parameters.ComputeAndDefineParameterTypes): Likewise.
8923 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
8924 * support.cs (InternalParameters..ctor): Remove variant that takes
8926 * typemanager.cs (system_intptr_expr): New.
8927 (InitExpressionTypes): Initialize it.
8929 2004-10-12 Chris Toshok <toshok@ximian.com>
8931 * cs-parser.jay: fix location for try_statement and catch_clause.
8933 2004-10-07 Raja R Harinath <rharinath@novell.com>
8935 More DeclSpace.ResolveType avoidance.
8936 * decl.cs (MemberCore.InUnsafe): New property.
8937 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
8938 with newly created EmitContext.
8939 (FieldMember.Define): Likewise.
8940 * delegate.cs (Delegate.Define): Likewise.
8941 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
8942 only if normal name-lookup fails.
8943 (TypeExpr.DoResolve): Enable error-checking.
8944 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
8945 (SizeOf.DoResolve): Likewise.
8946 (ComposedCast.DoResolveAsTypeStep): Likewise.
8947 (StackAlloc.DoResolve): Likewise.
8948 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
8949 (Block.Unsafe): New property.
8950 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
8951 (Unsafe): Set 'unsafe' flag of contained block.
8952 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
8953 (Fixed.Resolve): Likewise.
8954 (Catch.Resolve): Likewise.
8955 (Using.ResolveLocalVariableDecls): Likewise.
8956 (Foreach.Resolve): Likewise.
8958 2004-10-05 John Luke <john.luke@gmail.com>
8960 * cs-parser.jay: add location to error CS0175
8962 2004-10-04 Miguel de Icaza <miguel@ximian.com>
8964 * ecore.cs (Expression.Constantity): Add support for turning null
8967 * const.cs (Const.Define): Allow constants to be reference types
8968 as long as the value is Null.
8970 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
8972 * namespace.cs (NamespaceEntry.Using): No matter which warning
8973 level is set, check if this namespace name has already been added.
8975 2004-10-03 Ben Maurer <bmaurer@ximian.com>
8977 * expression.cs: reftype [!=]= null should always use br[true,false].
8980 2004-10-03 Marek Safar <marek.safar@seznam.cz>
8983 * attribute.cs: Enum conversion moved to
8984 GetAttributeArgumentExpression to be applied to the all
8987 2004-10-01 Raja R Harinath <rharinath@novell.com>
8989 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
8990 * class.c (TypeContainer.DefineType): Flag error if
8991 base types aren't accessible due to access permissions.
8992 * decl.cs (DeclSpace.ResolveType): Move logic to
8993 Expression.ResolveAsTypeTerminal.
8994 (DeclSpace.ResolveTypeExpr): Thin layer over
8995 Expression.ResolveAsTypeTerminal.
8996 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
8997 Refactor code into NestedAccess. Use it.
8998 (DeclSpace.NestedAccess): New.
8999 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
9000 argument to silence errors. Check access permissions.
9001 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
9002 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
9003 (Cast.DoResolve): Likewise.
9004 (New.DoResolve): Likewise.
9005 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
9006 (TypeOf.DoResolve): Likewise.
9008 * expression.cs (Invocation.BetterConversion): Return the Type of
9009 the better conversion. Implement section 14.4.2.3 more faithfully.
9010 (Invocation.BetterFunction): Make boolean. Make correspondence to
9011 section 14.4.2.2 explicit.
9012 (Invocation.OverloadResolve): Update.
9013 (Invocation): Remove is_base field.
9014 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9015 (Invocation.Emit): Likewise.
9017 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9019 * cs-parser.jay: Reverted 642 warning fix.
9021 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9024 * decl.cs (FindMemberWithSameName): Indexer can have more than
9027 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9029 * expression.cs (LocalVariableReference.DoResolveLValue):
9030 Do not report warning 219 for out values.
9031 (EmptyExpression.Null): New member to avoid extra allocations.
9033 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9035 * cs-parser.jay: Fix wrong warning 642 report.
9037 * cs-tokenizer.cs (CheckNextToken): New helper;
9038 Inspect next character if is same as expected.
9040 2004-09-23 Martin Baulig <martin@ximian.com>
9042 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9043 (Convert.ImplicitReferenceConversionExists): Likewise.
9045 2004-11-09 Raja R Harinath <rharinath@novell.com>
9047 * Makefile (DISTFILES): Comment out a few missing files.
9049 2004-10-29 Raja R Harinath <rharinath@novell.com>
9051 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9052 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9053 (gmcs.exe): Invoke bootstrap-libs.
9054 (clean-local): Clean the net_2_0_bootstrap profile too.
9055 (PROGRAM_INSTALL_DIR): New.
9056 (install-local): Use it.
9058 2004-10-13 Martin Baulig <martin@ximian.com>
9060 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9061 (TypeParameter.DefineType): If we're a method type parameter and
9062 that method is overriding something, "inflate" its constraints.
9064 2004-10-12 Martin Baulig <martin@ximian.com>
9066 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9067 and have type arguments, create and resolve a ConstructedType.
9069 2004-10-12 Martin Baulig <martin@ximian.com>
9071 * decl.cs (MemberCache.FindMemberToOverride): Use
9072 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9073 to compare the invocationType.
9075 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9076 When comparing two type parameters, only do the signature-only
9077 comparision for method type parameters.
9079 2004-10-11 Martin Baulig <martin@ximian.com>
9081 * report.cs: Don't make --fatal abort on warnings, we have
9082 -warnaserror for that.
9084 2004-10-11 Martin Baulig <martin@ximian.com>
9087 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9088 (TypeManager.IsEqual): Call ourself recursively instead of using
9091 2004-10-11 Martin Baulig <martin@ximian.com>
9093 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9094 on our own type parameters, not on the ones we inherit from a containing
9097 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9100 * generic.cs (TypeParameter.Define): We may only be called once.
9102 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9103 instead of TypeManager.IsEqual().
9105 2004-09-28 Martin Baulig <martin@ximian.com>
9108 (GenericConstraints.EffectiveBaseClass): New public property.
9109 (TypeParameter.GenericConstraints): New public property.
9110 (ConstructedType.CheckConstraints): Improved.
9112 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9113 (Convert.TypeParameterConversion): New private method; use this in
9114 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9115 for all conversions related to type parameters.
9117 2004-09-24 Martin Baulig <martin@ximian.com>
9119 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9120 type parameter conversions for type parameters which are known to
9123 2004-09-24 Martin Baulig <martin@ximian.com>
9125 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9126 `IsValueType' properties.
9128 * support.cs (ReflectionConstraints): Use
9129 Type.GetGenericParameterConstraints() instead of the old hack.
9131 2004-09-24 Martin Baulig <martin@ximian.com>
9133 * generic.cs (GenericConstraints): Moved here and made it an
9136 * support.cs (GenericConstraints): Moved to generic.cs.
9138 2004-09-24 Martin Baulig <martin@ximian.com>
9141 (ReflectionConstraints): Un-nested this class and made it public.
9144 (TypeManager.GetTypeParameterConstraints): New public method.
9145 (TypeManager.HasConstructorConstraint): Use the attributes.
9147 2004-09-24 Martin Baulig <martin@ximian.com>
9149 * support.cs (GenericConstraints): Replaced `HasConstructor',
9150 `IsReferenceType' and `IsValueType' with `Attributes'.
9151 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9152 method and made the .ctor public.
9154 * generic.cs (Constraints.Attributes): New public property.
9155 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9156 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9157 `IsValueType' -> `HasValueTypeConstraint'.
9159 2004-09-23 Martin Baulig <martin@ximian.com>
9161 * generic.cs (Constraints): Reflect latest runtime changes.
9163 2004-09-23 Martin Baulig <martin@ximian.com>
9165 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9166 (Convert.ImplicitReferenceConversionExists): Likewise.
9168 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9170 * class.cs (Operator.Define): Add error 448 and 559 report.
9172 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9174 * class.cs (MemberBase.IsTypePermitted): New protected
9175 method for checking error CS0610.
9177 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9179 * class.cs (TypeContainer.HasExplicitLayout): New property
9180 Returns whether container has StructLayout attribute set Explicit.
9181 (FieldMember): New abstract class for consts and fields.
9182 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9183 (Field): Reuse FieldMember.
9185 * const.cs (Const): Reuse FieldMember.
9187 * rootcontext.cs: EmitConstants call moved to class.
9189 2004-09-22 Martin Baulig <martin@ximian.com>
9191 Marek and me just fixed one of our oldest bugs: #28562 :-)
9193 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9195 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9196 we're an EnumConstant, just return that.
9197 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9198 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9199 to get the value which'll actually be written into the attribute.
9200 However, we have to use GetValue() to access the attribute's value
9203 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9205 * constant.cs (Constant.IsNegative): New abstract property
9208 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9209 (StackAlloc.DoResolve): Reused IsNegative.
9211 2004-09-22 Martin Baulig <martin@ximian.com>
9213 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9214 public method; like LookupTypeContainer, but also works for
9217 * report.cs (Report.SymbolRelatedToPreviousError): Use
9218 TypeManager.LookupGenericTypeContainer().
9220 2004-09-22 Martin Baulig <martin@ximian.com>
9222 Thanks to Peter Sestoft for this bug report.
9224 * expression.cs (Conditional): If both the `trueExpr' and the
9225 `falseExpr' is a NullLiteral, return a NullLiteral.
9227 2004-09-22 Martin Baulig <martin@ximian.com>
9229 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9230 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9231 for the "get_Current" call.
9233 2004-09-21 Martin Baulig <martin@ximian.com>
9235 * convert.cs (Convert.ImplicitReferenceConversion): When
9236 converting to an interface type, first check whether we're
9237 converting from a reference type.
9239 2004-09-14 Martin Baulig <martin@ximian.com>
9241 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9243 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9246 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9247 called and is obsolete then this member suppress message
9248 when call is inside next [Obsolete] method or type.
9250 * expression.cs: Use TestObsoleteMethodUsage member.
9252 2004-09-14 Martin Baulig <martin@ximian.com>
9254 * genericparser.cs: Removed.
9256 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9258 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9260 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9262 * attribute.cs (Attribute.Resolve): Add error 653 report.
9264 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9266 (Method.ApplyAttributeBuilder): Add error 685 report.
9267 (Operator.Define): Add error 564 report.
9269 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9271 * expression.cs (Invocation.DoResolve): Add error
9274 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9277 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9279 * class.cs (ConstructorInitializer.Resolve):
9280 Wrong error number (515->516).
9282 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9284 * class.cs (Indexer.Define): Add error 631 report.
9286 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9288 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9290 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9292 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9294 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9296 * cs-parser.jay: Added error CS0241 report.
9298 2004-09-10 Raja R Harinath <rharinath@novell.com>
9300 * cs-parser.jay (fixed_statement): Introduce a scope for the
9301 declaration in the 'fixed' statement.
9303 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9305 * cs-parser.jay: Added CS0230 error report.
9307 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9309 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9311 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9313 * expression.cs (Argument.Resolve): Added error CS0192 and
9316 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9318 C# 2.0 #pragma warning feature
9320 * cs-tokenizer.cs (PreProcessPragma): New method;
9321 Handles #pragma directive.
9323 * report.cs (WarningRegions): New class; Support
9324 class for #pragma warning directive. It tests whether
9325 warning is enabled for a given line.
9327 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9329 * const.cs: Add more descriptive error report, tahnks to
9332 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9334 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9336 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9338 * expression.cs: Apply patch from Ben: Remove dead code from
9339 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9340 as that code just threw an exception anwyays.
9342 * const.cs: Remove the call to the turnintoconstant, for details
9345 * literal.cs: The type of the null-literal is the null type; So
9346 we use a placeholder type (literal.cs:System.Null, defined here)
9349 * expression.cs (Conditional.DoResolve): Remove some old code that
9350 is no longer needed, conversions have been fixed.
9352 (ArrayCreationExpression.DoResolve): Return false if we fail to
9353 resolve the inner expression.
9355 2004-09-07 Raja R Harinath <rharinath@novell.com>
9358 * cs-parser.jay (delegate_declaration): Record a delegate
9359 declaration as a type declaration.
9360 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9362 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9364 * parameter.cs: Do not crash if the type can not be resolved.
9366 * expression.cs: Report errors with unsafe pointers, fixes #64896
9368 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9370 * expression.cs: Pointer arith always needs to do a conv.i
9371 if the operand is a long. fix 65320
9373 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9375 Fixed cs0619-37.cs, cs0619-38.cs
9377 * enum.cs (GetObsoleteAttribute): Removed.
9379 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9380 on Enum member is double staged. The first is tested member
9383 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9385 Fixed #56986, #63631, #65231
9387 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9388 adds member to name container.
9389 (TypeContainer.AddToTypeContainer): New method, adds type to
9391 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9392 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9393 AddOperator): Simplified by reusing AddToMemberContainer.
9394 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9396 (Method.CheckForDuplications): Fixed implementation to test all
9398 (MemberBase): Detection whether member is explicit interface
9399 implementation is now in constructor.
9400 (MemberBase.UpdateMemberName): Handles IndexerName.
9401 (Accessor): Changed to keep also location information.
9402 (AbstractPropertyEventMethod): Is derived from MemberCore.
9403 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9404 will be emited or not.
9405 (PropertyBase.AreAccessorsDuplicateImplementation):
9406 Tests whether accessors are not in collision with some method.
9407 (Operator): Is derived from MethodCore to simplify common
9410 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9412 (DeclSpace.AddToContainer): Adds the member to defined_names
9413 table. It tests for duplications and enclosing name conflicts.
9415 * enum.cs (EnumMember): Clean up to reuse the base structures
9417 2004-09-03 Martin Baulig <martin@ximian.com>
9419 Merged latest changes into gmcs. Please keep this comment in
9420 here, it makes it easier for me to see what changed in MCS since
9421 the last time I merged.
9423 2004-09-03 Martin Baulig <martin@ximian.com>
9425 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9426 into TypeContainer, to make partial classes work again.
9428 2004-09-03 Martin Baulig <martin@ximian.com>
9430 * rootcontext.cs (RootContext.V2): Removed.
9432 2004-03-23 Martin Baulig <martin@ximian.com>
9434 * expression.cs (Invocation.OverloadResolve): Added `bool
9435 may_fail' argument and use it instead of the Location.IsNull() hack.
9437 2004-09-09 Martin Baulig <martin@ximian.com>
9439 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9441 2004-09-09 Martin Baulig <martin@ximian.com>
9443 * generic.cs (TypeParameter.DefineType): Added support for
9444 explicit interface methods.
9446 2004-09-09 Martin Baulig <martin@ximian.com>
9448 * README.Changes: New document. Started to list important changes
9449 between MCS and GMCS here.
9451 2004-09-08 Martin Baulig <martin@ximian.com>
9454 (TypeContainer.CheckRecursiveDefinition): New protected method.
9455 (TypeContainer.DefineType): Move the CS0146 check into
9456 CheckRecursiveDefinition().
9458 2004-09-06 Martin Baulig <martin@ximian.com>
9460 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9461 types for the constructor constraint.
9463 2004-09-03 Martin Baulig <martin@ximian.com>
9465 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9466 into TypeContainer, to make partial classes work again.
9468 2004-09-03 Martin Baulig <martin@ximian.com>
9470 * rootcontext.cs (RootContext.V2): Removed.
9472 2004-03-23 Martin Baulig <martin@ximian.com>
9474 * expression.cs (Invocation.OverloadResolve): Added `bool
9475 may_fail' argument and use it instead of the Location.IsNull() hack.
9477 2004-09-03 Martin Baulig <martin@ximian.com>
9479 Merged latest changes into gmcs. Please keep this comment in
9480 here, it makes it easier for me to see what changed in MCS since
9481 the last time I merged.
9483 2004-09-03 Raja R Harinath <rharinath@novell.com>
9486 * expression.cs (BetterConversion): Don't allow either conversion
9487 to be null. Remove redundant implicit conversion test when 'q ==
9488 null' -- when this function is invoked, we already know that the
9489 implicit conversion exists.
9490 (BetterFunction): Assume that 'best' is non-null. Remove
9491 redundant reimplementation of IsApplicable when 'best' is null.
9492 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9493 number of arguments.
9494 (IsAncestralType): Extract from OverloadResolve.
9495 (OverloadResolve): Make robust to the MethodGroupExpr being
9496 unsorted. Implement all the logic of Section 14.5.5.1, and
9497 support overloading of methods from multiple applicable types.
9498 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9500 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9501 (RealError, Warning): Append type of report to related symbol.
9503 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9505 * enum.cs: Fixed CLS-Compliance checks for enum members.
9506 Error tests cs3008-8.cs, cs3014-8.cs
9508 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9510 Fixed bug #62342, #63102
9511 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9512 like ImplementMethod.
9514 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9516 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9519 2004-09-02 Martin Baulig <martin@ximian.com>
9521 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9522 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9525 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9527 C# 2.0 Static classes implemented
9529 * class.cs (TypeContainer): instance_constructors,
9530 initialized_fields, initialized_static_fields,
9531 default_constructor, base_inteface_types are protected to be
9532 accessible from StaticClass.
9533 (TypeContainer.DefineDefaultConstructor): New virtual method
9534 for custom default constructor generating
9535 (StaticClass): New class to handle "Static classes" feature.
9537 * cs-parser.jay: Handle static keyword on class like instance
9540 * driver.cs: Added "/langversion" command line switch with two
9541 options (iso-1, default).
9543 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9545 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9547 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9549 * delegate.cs: Style.
9551 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9553 * delegate.cs: Add seperate instance expr field for miguel.
9555 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9557 * PointerArithmetic (Resolve): make sure we are not doing
9558 pointer arith on void*. Also, make sure we are resolved
9559 by not setting eclass until resolve.
9561 All callers: Make sure that PointerArithmetic gets resolved.
9563 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9565 * ArrayCreation (LookupType): If the type does not resolve
9566 to an array, give an error.
9568 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9570 * statement.cs (Try.Resolve): Fixed bug #64222
9572 2004-08-27 Martin Baulig <martin@ximian.com>
9575 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9578 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9580 * ecore.cs (Constantify): Get underlying type via
9581 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9582 Windows in special cases.
9584 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9586 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9587 for obtaining also private methods.
9588 (GetRemoveMethod): Used GetRemoveMethod (true)
9589 for obtaining also private methods.
9591 2004-09-02 Martin Baulig <martin@ximian.com>
9593 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9594 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9597 2004-08-27 Martin Baulig <martin@ximian.com>
9600 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9603 2004-08-25 Martin Baulig <martin@ximian.com>
9605 * support.cs (ReflectionParameters..ctor): If this is a generic
9606 method, retrieve and store its type parameters.
9607 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9608 (ReflectionParameters.GenericConstraints): The argument specifies
9609 the type parameter, not the method parameter.
9610 (InternalParameters.GenericConstraints): Likewise.
9612 * generic.cs (TypeParameter.DefineType): Correctly handle
9613 constraints wrt. generic methods in interfaces and their
9616 2004-08-24 Martin Baulig <martin@ximian.com>
9618 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9619 (Constraints.IsSubclassOf): New internal method.
9621 * typemanager.cs (TypeManager.FindMembers): Added special support
9622 for GenericTypeParameterBuilder's.
9623 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
9626 2004-08-24 Martin Baulig <martin@ximian.com>
9629 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
9630 this for accessibility checks.
9631 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
9632 IsNestedFamilyAccessible.
9633 (TypeManager.IsSubclassOf): New method, do what the name actually
9636 2004-08-24 Martin Baulig <martin@ximian.com>
9638 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
9639 as a SimpleName, include the generic arity.
9641 2004-08-24 Martin Baulig <martin@ximian.com>
9643 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
9644 MethodAttributes.HideBySig for operators.
9646 2004-08-23 Martin Baulig <martin@ximian.com>
9648 Back to the old error reporting system :-)
9650 * report.cs (Message): Removed.
9651 (Report.MessageData, ErrorData, WarningData): Removed.
9652 (Report.Error, Warning): Back to the old system.
9654 2004-08-23 Martin Baulig <martin@ximian.com>
9656 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
9658 * class.cs (TypeContainer.ParentContainer): New public virtual
9659 method; replaces the explicit interface implementation.
9660 (ClassPart.ParentContainer): Override.
9662 2004-08-23 Martin Baulig <martin@ximian.com>
9664 * statement.cs (Switch): Added support for constant switches; see
9665 #59428 or test-285.cs.
9667 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9670 * statement.cs (GetEnumeratorFilter): Removed useless
9671 logic because C# specs is strict. GetEnumerator must be
9674 2004-08-22 Martin Baulig <martin@ximian.com>
9676 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9677 a switch and may break, reset the barrier. Fixes #59867.
9679 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9681 CLS-Compliance speed up (~5% for corlib)
9683 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
9684 New method. Tests container for CLS-Compliant names
9686 * class.cs (TypeContainer.VerifyClsName): New method.
9687 Checks whether container name is CLS Compliant.
9688 (Constructor): Implements IMethodData.
9690 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
9691 low-case table for CLS Compliance test.
9692 (MemberCache.VerifyClsParameterConflict): New method.
9693 Checks method parameters for CS3006 error.
9695 * enum.cs (EnumMember): Is derived from MemberCore.
9696 (Enum.VerifyClsName): Optimized for better performance.
9698 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9700 * report.cs: Renamed Error_T to Error and changed all
9703 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9705 * class.cs (TypeContainer.IndexerArrayList): New inner class
9706 container for indexers.
9707 (TypeContainer.DefaultIndexerName): New constant for default
9708 indexer name. Replaced all "Item" with this constant.
9709 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
9711 * typemanager.cs (TypeManager.default_member_ctor): Cache here
9712 DefaultMemberAttribute constructor.
9714 2004-08-05 Martin Baulig <martin@ximian.com>
9716 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9719 2004-08-05 Marek Safar <marek.safar@seznam.cz>
9721 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
9722 multi platforms problem.
9724 * compiler.csproj: Included shared files.
9726 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9728 Fix bug 60333, 55971 in the more general way
9729 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9730 Added arg_type argument for constant conversion.
9731 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
9733 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9736 * class.cs (TypeContainer ): New inner classes MethodArrayList,
9737 OperatorArrayList, MethodCoreArrayList for typecontainer
9738 containers. Changed class member types to these new types.
9739 (MethodArrayList.DefineMembers): Added test for CS0659.
9741 2004-08-04 Miguel de Icaza <miguel@ximian.com>
9743 * cfold.cs: Synchronize the folding with the code in expression.cs
9744 Binary.DoNumericPromotions for uint operands.
9746 * attribute.cs: Revert patch from Raja, it introduced a regression
9747 while building Blam-1.2.1 (hard to isolate a test case).
9749 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9753 (TypeContainer.Define): Renamed to DefineContainerMembers because of
9755 (MethodCore.parent_method): New member. The method we're overriding
9756 if this is an override method.
9757 (MethodCore.CheckBase): Moved from Method class and made common.
9758 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
9760 (MethodCore.CheckForDuplications): New abstract method. For custom
9761 member duplication search in a container
9762 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
9763 method and its return type.
9764 (Event.conflict_symbol): New member. Symbol with same name in the
9768 (MemberCache.FindMemberWithSameName): New method. The method
9769 is looking for conflict with inherited symbols.
9771 2004-08-04 Martin Baulig <martin@ximian.com>
9773 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9775 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9777 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9779 * report.cs (Message): New enum for better error, warning reference in
9781 (MessageData): New inner abstract class. It generally handles printing of
9782 error and warning messages.
9783 Removed unused Error, Warning, Message methods.
9785 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9787 Fix for cs0592-8.cs test
9789 (Attributable.ValidAttributeTargets): Made public.
9790 (Attribute.ExplicitTarget): New member for explicit target value.
9791 (Attribute.CheckTargets): Now we translate explicit attribute
9792 target to Target here.
9794 2004-08-03 Ben Maurer <bmaurer@ximian.com>
9796 * ecore.cs (MethodGroupExpr): new IsBase property.
9798 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
9800 * delegate.cs (DelegateCreation): store a MethodGroupExpr
9801 rather than an instance expr.
9803 (DelegateCreation.Emit): Use the method group rather than
9804 the instance expression. Also, if you have base.Foo as the
9805 method for a delegate, make sure to emit ldftn, not ldftnvirt.
9807 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
9809 (NewDelegate.DoResolve): Only check for the existance of Invoke
9810 if the method is going to be needed. Use MethodGroupExpr.
9812 (NewDelegate.Emit): Remove, DelegateCreation implements this.
9814 * expression.cs: For pointer arith., make sure to use
9815 the size of the type, not the size of the pointer to
9818 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9821 * class.cs (Class): Added error CS0502 test.
9823 2004-08-03 John Luke <jluke@cfl.rr.com>
9824 Raja R Harinath <rharinath@novell.com>
9827 * attribute.cs (Attribute.complained_before): New flag.
9828 (Attribute.ResolveType, Attribute.Resolve),
9829 (Attribute.DefinePInvokeMethod): Set it.
9830 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
9832 2004-08-03 Martin Baulig <martin@ximian.com>
9834 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
9835 use a user-defined operator; we still need to do numeric
9836 promotions in case one argument is a builtin type and the other
9837 one has an implicit conversion to that type. Fixes #62322.
9839 2004-08-18 Martin Baulig <martin@ximian.com>
9841 * class.cs (Method.Define): Use the correct method name when
9842 creating the MethodBuilder for a generic method.
9844 2004-08-17 Martin Baulig <martin@ximian.com>
9846 * generic.cs (Constraints): Support type parameter constraints.
9848 2004-08-16 Martin Baulig <martin@ximian.com>
9850 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
9851 (Token.GENERIC_DIMENSION): New token; this is returned if we
9852 encounter an unbound generic type in a typeof() expression.
9854 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
9855 this token is only generated while parsing a typeof() expression.
9856 (typeof_expression): Removed the old unbound_type hack.
9858 * generic.cs (TypeArguments.IsUnbound): New public property.
9860 * decl.cs (MemberName): Added support for unbound types.
9862 2004-08-14 Martin Baulig <martin@ximian.com>
9865 (TypeManager.IsEqualGenericInstance): New static method.
9866 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
9867 just used to check accessibility, so follow the rules of 26.1.6.
9869 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
9870 ConstructedType instead of a TypeExpression if we have type arguments.
9872 * cs-parser.jay (typeof_expression): Support unbound generic types.
9874 * ecore.cs (UnboundTypeExpression): New public class.
9876 2004-08-12 Martin Baulig <martin@ximian.com>
9878 * typemanager.cs (TypeManager.IsNestedChildOf): Use
9879 TypeManager.IsEqual() rather than `=='.
9881 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
9882 generic instances as well.
9884 2004-08-12 Martin Baulig <martin@ximian.com>
9886 * expression.cs (Invocation.InferType): We can only infer method
9887 type parameters. Fixes #62647.
9889 2004-08-11 Martin Baulig <martin@ximian.com>
9891 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
9892 before resolving the base classes.
9894 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9896 * Makefile: install .mdb file too.
9898 2004-08-05 Martin Baulig <martin@ximian.com>
9900 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
9901 initializer, the current type is just the TypeBuilder, not the
9902 instantiated generic type.
9903 (FieldExpr.IsFieldInitializer): New public property.
9905 2004-08-04 Martin Baulig <martin@ximian.com>
9907 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9909 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9911 2004-08-03 Martin Baulig <martin@ximian.com>
9913 * class.cs (MethodData.Define): If we're an explicit
9914 implementation, remove the generic arity from the type name.
9916 2004-08-03 Martin Baulig <martin@ximian.com>
9918 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
9919 use a user-defined operator; we still need to do numeric
9920 promotions in case one argument is a builtin type and the other
9921 one has an implicit conversion to that type. Fixes #62322.
9923 2004-08-02 Martin Baulig <martin@ximian.com>
9925 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
9927 (TypeContainer.GetClassBases): Return the unexpanded list of
9928 interfaces; we expand them later.
9929 (TypeContainer.DefineType): After creating the TypeBuilder, call
9930 TypeManager.ExpandInterfaces() to get an expanded and resolved
9933 * ecore.cs (TypeExpr.GetInterfaces): Removed
9935 * generics.cs (Constraints.InterfaceConstraints): Remove.
9936 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
9937 register the interface constraints.
9940 (TypeManager.AddUserType): Removed the `ifaces' argument.
9941 (TypeManager.AddTypeParameter): Likewise.
9942 (TypeManager.AddUserInterface): Removed, was unused.
9943 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
9944 `TypeExpr[]' array for the interfaces.
9945 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
9946 has been defined, returns a list of the resolved interfaces types.
9947 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
9948 (TypeManager.GetExplicitInterfaces): Likewise.
9950 2004-08-02 Martin Baulig <martin@ximian.com>
9952 * expression.cs (Invocation.EmitCall): If we're invoking a method
9953 on a type parameter, use the new `Constrained' prefix opcode.
9955 2004-08-02 Martin Baulig <martin@ximian.com>
9957 * statement.cs (LocalInfo.Flags): Added `IsThis'.
9958 (LocalInfo.IsThis): New public property.
9959 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
9961 2004-08-01 Martin Baulig <martin@ximian.com>
9963 * class.cs (TypeContainer.GetClassBases): Don't set the default
9964 here since we may get called from GetPartialBases().
9965 (TypeContainer.DefineType): If GetClassBases() didn't return a
9966 parent, use the default one.
9968 2004-07-30 Martin Baulig <martin@ximian.com>
9970 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
9972 * class.cs (SourceMethod): New public class, derive from the
9973 symbol writer's ISourceMethod.
9974 (Method): Use the new symbol writer API.
9976 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
9977 as argument and use the new symbol writer.
9980 (SourceFile): Implement the symbol writer's ISourceFile.
9981 (Location.SymbolDocument): Removed.
9982 (Location.SourceFile): New public property.
9984 * symbolwriter.cs: Use the new symbol writer API.
9986 2004-07-30 Raja R Harinath <rharinath@novell.com>
9988 * Makefile (install-local): Remove. Functionality moved to
9991 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
9993 * Makefile: Install mcs.exe.config file together with mcs.exe.
9994 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
9995 correct runtime version.
9997 2004-07-25 Martin Baulig <martin@ximian.com>
10000 (TypeContainer.RegisterOrder): Removed, this was unused.
10001 (TypeContainer, interface_order): Removed.
10002 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
10003 TypeContainer as argument since we can also be called with a
10004 `PartialContainer' for a partial class/struct/interface.
10005 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
10006 of checking whether we're an `Interface' - we could be a
10007 `PartialContainer'.
10008 (PartialContainer.Register): Override; call
10009 AddClass()/AddStruct()/AddInterface() on our parent.
10011 * cs-parser.jay (interface_member_declaration): Add things to the
10012 `current_container', not the `current_class'.
10014 * rootcontext.cs (RegisterOrder): The overloaded version which
10015 takes an `Interface' was unused, removed.
10017 * typemanager.cs (TypeManager.LookupInterface): Return a
10018 `TypeContainer', not an `Interface'.
10019 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10020 contain a `PartialContainer' for an interface, so check it's
10021 `Kind' to figure out what it is.
10023 2004-07-25 Martin Baulig <martin@ximian.com>
10025 * class.cs (Class.DefaultTypeAttributes): New public constant.
10026 (Struct.DefaultTypeAttributes): Likewise.
10027 (Interface.DefaultTypeAttributes): Likewise.
10028 (PartialContainer.TypeAttr): Override this and add the
10029 DefaultTypeAttributes.
10031 2004-07-25 Martin Baulig <martin@ximian.com>
10033 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10034 we can just use the `Parent' field instead.
10036 2004-07-25 Martin Baulig <martin@ximian.com>
10038 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10040 2004-07-25 Martin Baulig <martin@ximian.com>
10042 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10043 our parts before defining any methods.
10044 (TypeContainer.VerifyImplements): Make this virtual.
10045 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10046 on our PartialContainer.
10048 2004-07-25 Martin Baulig <martin@ximian.com>
10050 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10052 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10053 argument, we can just use the `Parent' field instead.
10056 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10057 (MemberBase.DoDefine): Likewise.
10059 2004-07-24 Martin Baulig <martin@ximian.com>
10061 * decl.cs (MemberCore.Parent): New public field.
10062 (DeclSpace.Parent): Moved to MemberCore.
10064 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10065 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10067 (FieldBase, Field, Operator): Likewise.
10068 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10069 (EventField, Event): Likewise.
10071 2004-07-23 Martin Baulig <martin@ximian.com>
10073 * class.cs (PartialContainer): New public class.
10074 (ClassPart): New public class.
10075 (TypeContainer): Added support for partial classes.
10076 (TypeContainer.GetClassBases): Splitted some of the functionality
10077 out into GetNormalBases() and GetPartialBases().
10079 * cs-tokenizer.cs (Token.PARTIAL): New token.
10080 (Tokenizer.consume_identifier): Added some hacks to recognize
10081 `partial', but only if it's immediately followed by `class',
10082 `struct' or `interface'.
10084 * cs-parser.jay: Added support for partial clases.
10086 2004-07-23 Martin Baulig <martin@ximian.com>
10088 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10089 a `DeclSpace' and also made it readonly.
10090 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10091 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10092 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10094 * cs-parser.jay: Pass the `current_class', not the
10095 `current_container' (at the moment, this is still the same thing)
10096 to a new Method, Property, Event, Indexer or Constructor.
10098 2004-07-23 Martin Baulig <martin@ximian.com>
10100 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10101 and removed the `current_interface' one.
10102 (struct_declaration, class_declaration, interface_declaration):
10103 Set `current_class' to the newly created class/struct/interface;
10104 set their `Bases' and call Register() before parsing their body.
10106 2004-07-23 Martin Baulig <martin@ximian.com>
10108 * class.cs (Kind): New public enum.
10109 (TypeContainer): Made this class abstract.
10110 (TypeContainer.Kind): New public readonly field.
10111 (TypeContainer.CheckDef): New public method; moved here from
10113 (TypeContainer.Register): New public abstract method.
10114 (TypeContainer.GetPendingImplementations): New public abstract
10116 (TypeContainer.GetClassBases): Removed the `is_class' and
10117 `is_iface' parameters.
10118 (TypeContainer.DefineNestedTypes): Formerly known as
10120 (ClassOrStruct): Made this class abstract.
10122 * tree.cs (RootTypes): New public type.
10124 2004-07-20 Martin Baulig <martin@ximian.com>
10126 * tree.cs (Tree.RecordNamespace): Removed.
10127 (Tree.Namespaces): Removed.
10129 * rootcontext.cs (RootContext.IsNamespace): Removed.
10131 * cs-parser.jay (namespace_declaration): Just create a new
10132 NamespaceEntry here.
10134 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10136 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10137 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10138 entry to make sure it runs in the correct runtime version.
10140 2004-07-18 Martin Baulig <martin@ximian.com>
10142 * generic.cs (ConstructedType.CheckConstraints): Improved
10143 constraints checking.
10145 2004-07-18 Martin Baulig <martin@ximian.com>
10147 * expression.cs (Invocation.BetterMethod): Call
10148 TypeManager.TypeToCoreType() on all types and removed my previous
10149 hack; we're already doig the right thing here.
10151 2004-07-17 Martin Baulig <martin@ximian.com>
10153 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10155 2004-07-16 Martin Baulig <martin@ximian.com>
10157 * iterators.cs: Added generics support.
10159 2004-07-16 Martin Baulig <martin@ximian.com>
10161 * iterators.cs: Rewrote this. We're now using one single Proxy
10162 class for both the IEnumerable and the IEnumerator interface and
10163 `Iterator' derives from Class so we can use the high-level API.
10165 * class.cs (TypeContainer.AddIterator): New method.
10166 (TypeContainer.DoDefineType): New protected virtual method, which
10167 is called from DefineType().
10168 (TypeContainer.DoDefineMembers): Call DefineType() and
10169 DefineMembers() on all our iterators.
10170 (TypeContainer.Emit): Call Emit() on all our iterators.
10171 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10173 * codegen.cs (EmitContext.CurrentIterator): New public field.
10175 2004-07-15 Martin Baulig <martin@ximian.com>
10178 (TypeManager.not_supported_exception_type): New type.
10180 2004-07-14 Martin Baulig <martin@ximian.com>
10183 (TypeManager.generic_ienumerable_type): New type.
10184 (TypeManager.generic_ienumerator_type): New type.
10187 (RootContext.interfaces_first_stage): Added
10188 "System.Collections.Generic.IEnumerator`1" and
10189 "System.Collections.Generic.IEnumerable`1".
10191 2004-07-14 Martin Baulig <martin@ximian.com>
10193 * iterators.cs: Use real error numbers.
10195 2004-07-14 Martin Baulig <martin@ximian.com>
10197 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10198 requires this to be a System.Collection.IEnumerable and not a
10199 class implementing that interface.
10200 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10202 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10204 * class.cs: Fixed previous fix, it broke some error tests.
10206 2004-07-12 Martin Baulig <martin@ximian.com>
10208 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10211 2004-07-14 Martin Baulig <martin@ximian.com>
10213 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10214 an exclamation mark (!) for the generic arity to reflect the
10215 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10217 2004-07-13 Martin Baulig <martin@ximian.com>
10219 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10220 specifiers being part of a type argument.
10222 2004-07-13 Martin Baulig <martin@ximian.com>
10224 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10225 name for generic types.
10227 2004-07-13 Martin Baulig <martin@ximian.com>
10229 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10232 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10234 * assign.cs (LocalTemporary): Add new argument: is_address,If
10235 `is_address' is true, then the value that we store is the address
10236 to the real value, and not the value itself.
10238 * ecore.cs (PropertyExpr): use the new local temporary
10239 stuff to allow us to handle X.Y += z (where X is a struct)
10241 2004-07-08 Martin Baulig <martin@ximian.com>
10243 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10244 not always return, just like we're doing in Using.Resolve().
10246 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10248 * cs-parser.jay (fixed_statement): flag this as Pinned.
10250 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10252 * typemanager.cs (TypeManager): Removed MakePinned method, this
10253 mechanism is replaced with the .NET 2.x compatible mechanism of
10254 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10256 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10257 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10258 `IsFixed' property which has a different meaning.
10260 2004-07-02 Raja R Harinath <rharinath@novell.com>
10262 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10263 visible from inside a nested class, not just the names of the
10264 immediately enclosing class.
10265 Fix for bug #60730.
10267 2004-06-24 Raja R Harinath <rharinath@novell.com>
10269 * expression.cs (BetterConversion): Remove buggy special-case
10270 handling of "implicit constant expression conversions". At this
10271 point, we already know that the conversion is possible -- we're
10272 only checking to see which is better.
10274 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10276 * cs-parser.jay: Added error CS0210 test.
10278 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10280 * cs-parser.jay: Added error CS0134 test.
10282 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10285 * cs-parser.jay: Added error CS0145 test.
10287 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10289 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10291 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10293 * expression.cs (StackAlloc.Resolve): The argument may not
10294 be a constant; deal with this case.
10296 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10298 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10299 GetIndexerAttributeValue.
10300 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10302 * class.cs (Indexer.Define): Added error tests for CS0415,
10305 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10307 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10310 2004-06-23 Martin Baulig <martin@ximian.com>
10312 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10313 neither return nor throw, reset the barrier as well. Fixes #60457.
10315 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10317 * class.cs : EventAttributes is now set to None by default.
10318 This fixes bug #60459.
10320 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10323 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10324 Don't throw exception but return null (it's sufficient now).
10326 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10328 * typemanager.cs (GetArgumentTypes): Faster implementation.
10330 2004-06-18 Martin Baulig <martin@ximian.com>
10332 * attribute.cs (Attribute.Resolve): Check whether we're an
10333 EmptyCast which a Constant child. Fixes #60333.
10335 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10337 * statement.cs (EmitCollectionForeach): Account for the fact that
10338 not all valuetypes are in areas which we can take the address of.
10339 For these variables, we store to a temporary variable. Also, make
10340 sure that we dont emit a `callvirt' on a valuetype method.
10342 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10344 * expression.cs (StackAlloc.DoReSolve): Added test for
10345 negative parameter (CS0247).
10347 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10350 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10352 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10355 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10358 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10360 Fix bug #58254 & cs1555.cs, cs1556.cs
10361 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10363 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10365 * cs-parser.jay: Added error CS1669 test for indexers.
10367 2004-06-18 Martin Baulig <martin@ximian.com>
10369 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10370 argument. Fixes #60441.
10372 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10373 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10374 The name needs to have the actual name of the method in order
10375 for other tests (such as the one in OverloadResolve for Invoke
10376 on a delegate) to work. As well, it does not really help
10377 error reporting because the method group had multiple methods.
10378 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10379 Make profiling work.
10381 2004-06-13 Martin Baulig <martin@ximian.com>
10383 * cs-parser.jay: Don't allow generic attributes.
10385 2004-06-13 Martin Baulig <martin@ximian.com>
10387 * class.cs (MemberBase.DoDefineBase): New protected method.
10388 (MemberBase.DoDefine): Compute the `flags' in the new
10389 DoDefineBase() which must be called first.
10390 (Method.Define): Call DoDefineBase() first so we have the flags
10391 when defining the generic method.
10393 * cs-parser.jay (interface_method_declaration): Support generic methods.
10395 2004-06-13 Martin Baulig <martin@ximian.com>
10397 * decl.cs (TypeName): Removed.
10398 (MemberName): Removed TypeName and MemberNow; now we just have
10401 * cs-parser.jay: Don't distinguish between type arguments and type
10402 parameters in the grammar and simplified the rules a bit. The
10403 reduce/reduce conflicts are now gone (except the one we inherited
10406 2004-06-11 Martin Baulig <martin@ximian.com>
10408 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10409 call this twice: for params and varargs methods.
10411 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10414 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10416 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10418 * attribute.cs (Attribute.GetValidTargets): Made public.
10421 (AbstractPropertyEventMethod): New class for better code sharing.
10422 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10424 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10426 2004-06-09 Martin Baulig <martin@ximian.com>
10428 * cs-parser.jay: Removed a reduce/reduce conflict.
10430 2004-06-03 Martin Baulig <martin@ximian.com>
10432 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10433 GetSimpleName() and return a SimpleName.
10435 * ecore.cs (SimpleName.Arguments): New public field.
10436 (SimpleName): Added overloaded ctor which takes an additional
10437 TypeArguments argument.
10438 (SimpleName.SimpleNameResolve): Added support for generic methods.
10439 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10440 formerly in MemberAccess.DoResolve(), but we also need it in
10441 SimpleNameResolve().
10443 * expression.cs (MemberAccess.DoResolve): Use the new
10444 MethodGroupExpr.ResolveGeneric().
10446 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10448 * decl.cs: If possible, use lookuptypedirect here. We can only do
10449 this if there is no `.' after the namespace. Avoids using
10450 LookupType, which does lots of slow processing.
10451 (FindNestedType) New method, does what it says :-).
10452 * namespace.cs: use LookupTypeDirect.
10453 * rootcontext.cs: use membercache, if possible.
10454 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10456 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10459 According to the spec,
10461 In a member access of the form E.I, if E is a single identifier,
10462 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10463 field, property, localvariable, or parameter with the same type as
10464 the meaning of E as a type-name (§3.8), then both possible
10465 meanings of E are permitted.
10467 We did not check that E as a simple-name had the same type as E as
10470 This trivial check gives us 5-7% on bootstrap time.
10472 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10474 * expression.cs (Invocation.OverloadResolve): Avoid the
10475 use of hashtables and boxing here by allocating on demand.
10477 2004-05-30 Martin Baulig <martin@ximian.com>
10479 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10480 we're doing a silent lookup. Don't try to lookup nested types in
10481 TypeManager.object_type (thanks to Ben Maurer).
10483 2004-05-30 Martin Baulig <martin@ximian.com>
10485 Committing a patch from Ben Maurer.
10487 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10489 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10491 * convert.cs: add a trivial cache for overload operator resolution.
10493 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10496 (AttributeTester.GetObsoleteAttribute): Returns instance of
10497 ObsoleteAttribute when type is obsolete.
10500 (TypeContainer.VerifyObsoleteAttribute): Override.
10501 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10502 (MethodCode.VerifyObsoleteAttribute): Override.
10503 (MemberBase.VerifyObsoleteAttribute): Override.
10506 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10507 and report proper error.
10510 (Delegate.VerifyObsoleteAttribute): Override.
10513 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10514 and report proper error.
10515 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10518 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10522 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10523 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10524 Added test for ObsoleteAttribute.
10527 (Catch): Derived from Statement.
10529 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10531 * decl.cs: If possible, use lookuptypedirect here. We can only do
10532 this if there is no `.' after the namespace. Avoids using
10533 LookupType, which does lots of slow processing.
10534 (FindNestedType) New method, does what it says :-).
10535 * namespace.cs: use LookupTypeDirect.
10536 * rootcontext.cs: use membercache, if possible.
10537 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10539 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10542 According to the spec,
10544 In a member access of the form E.I, if E is a single identifier,
10545 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10546 field, property, localvariable, or parameter with the same type as
10547 the meaning of E as a type-name (§3.8), then both possible
10548 meanings of E are permitted.
10550 We did not check that E as a simple-name had the same type as E as
10553 This trivial check gives us 5-7% on bootstrap time.
10555 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10557 Fixed bug #59071 & cs0160.cs
10558 * statement.cs (Try.Resolve): Check here whether order of catch
10559 clauses matches their dependencies.
10561 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10564 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10567 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10569 * expression.cs (Invocation.OverloadResolve): Avoid the
10570 use of hashtables and boxing here by allocating on demand.
10572 2004-05-30 Martin Baulig <martin@ximian.com>
10574 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10575 we're doing a silent lookup. Don't try to lookup nested types in
10576 TypeManager.object_type (thanks to Ben Maurer).
10578 2004-05-30 Martin Baulig <martin@ximian.com>
10580 Committing a patch from Ben Maurer.
10582 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10584 2004-05-29 Martin Baulig <martin@ximian.com>
10586 * class.cs (IMethodData.ShouldIgnore): New method.
10588 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10589 `Location' argument, we don't need it anywhere. Use
10590 `IMethodData.ShouldIgnore ()' instead of
10591 `MethodData.GetMethodFlags ()'.
10592 (TypeManager.AddMethod): Removed.
10593 (TypeManager.AddMethod2): Renamed to AddMethod.
10595 2004-05-29 Martin Baulig <martin@ximian.com>
10597 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10599 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10600 converting from a class type S to an interface type and we already
10601 have an object on the stack, don't box it again. Fixes #52578.
10603 2004-05-29 Martin Baulig <martin@ximian.com>
10605 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10606 Added support for `params' parameters. Fixes #59267.
10608 2004-05-29 Martin Baulig <martin@ximian.com>
10610 * literal.cs (NullPointer): Provide a private .ctor which sets
10611 `type' to TypeManager.object_type. Fixes #59048.
10613 2004-05-29 Martin Baulig <martin@ximian.com>
10615 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10616 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10618 * ecore.cs (EventExpr.instance_expr): Make the field private.
10620 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10622 Fixed bug #50080 & cs0214-2.cs
10623 * expression.cs (Cast.DoResolve): Check unsafe context here.
10625 * statement.cs (Resolve.DoResolve): Likewise.
10627 2004-05-26 Martin Baulig <martin@ximian.com>
10629 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
10631 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
10632 (RootContext.LookupType): Pass down the `silent' flag.
10634 2004-05-25 Martin Baulig <martin@ximian.com>
10637 (MethodGroupExpr.IdenticalTypeName): New public property.
10638 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
10639 expression actually refers to a type.
10641 2004-05-25 Martin Baulig <martin@ximian.com>
10643 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
10644 for #56176 and made it actually work.
10646 2004-05-25 Martin Baulig <martin@ximian.com>
10648 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
10649 (FieldExpr, PropertyExpr): Override and implement
10650 CacheTemporaries. Fixes #52279.
10652 2004-05-25 Miguel de Icaza <miguel@ximian.com>
10654 * location.cs: In the new compiler listing a file twice is a
10655 warning, not an error.
10657 2004-05-24 Martin Baulig <martin@ximian.com>
10659 * enum.cs (Enum.DefineType): For the `BaseType' to be a
10660 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
10662 2004-05-24 Martin Baulig <martin@ximian.com>
10664 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
10665 walking the `using' list. Fixes #53921.
10667 2004-05-24 Martin Baulig <martin@ximian.com>
10669 * const.cs (Const.LookupConstantValue): Added support for
10670 EmptyCast's; fixes #55251.
10672 2004-05-24 Martin Baulig <martin@ximian.com>
10674 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
10675 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
10676 which does the CS0135 check. The reason is that we first need to
10677 check whether the variable actually exists.
10679 2004-05-24 Martin Baulig <martin@ximian.com>
10681 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
10682 than RootContext.LookupType() to find the explicit interface
10683 type. Fixes #58584.
10685 2004-05-24 Raja R Harinath <rharinath@novell.com>
10687 * Makefile: Simplify. Use executable.make.
10688 * mcs.exe.sources: New file. List of sources of mcs.exe.
10690 2004-05-24 Anders Carlsson <andersca@gnome.org>
10694 Use the invariant culture when doing String.Compare for CLS case
10697 2004-05-23 Martin Baulig <martin@ximian.com>
10699 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
10700 don't have any dots. Fixes #52622, added cs0246-8.cs.
10702 * namespace.cs (NamespaceEntry.Lookup): Likewise.
10704 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10706 * class.cs (MemberBase.Define): Reuse MemberType member for
10707 resolved type. Other methods can use it too.
10709 2004-05-23 Martin Baulig <martin@ximian.com>
10711 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
10712 the variable also exists in the current block (otherwise, we need
10713 to report a CS0103). Fixes #58670.
10715 2004-05-23 Martin Baulig <martin@ximian.com>
10717 * flowanalysis.cs (Reachability.Reachable): Compute this
10718 on-the-fly rather than storing it as a field.
10720 2004-05-23 Martin Baulig <martin@ximian.com>
10722 * flowanalysis.cs (Reachability.And): Manually compute the
10723 resulting `barrier' from the reachability.
10725 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10728 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
10729 instance of ObsoleteAttribute when symbol is obsolete.
10732 (IMethodData): Extended interface for ObsoleteAttribute support.
10734 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10736 * attribute.cs: Fix bug #55970
10738 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10742 (GetObsoleteAttribute): New method. Creates the instance of
10744 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
10745 ObsoleteAttribute when member is obsolete.
10746 (AttributeTester.Report_ObsoleteMessage): Common method for
10747 Obsolete error/warning reporting.
10750 (TypeContainer.base_classs_type): New member for storing parent type.
10753 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
10754 for this MemberCore.
10756 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10758 * attribute.cs, const.cs: Fix bug #58590
10760 2004-05-21 Martin Baulig <martin@ximian.com>
10762 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
10763 out parameters if the end of the method is unreachable. Fixes
10766 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10768 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
10769 Hari was right, why extra method.
10771 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10773 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
10775 2004-05-20 Martin Baulig <martin@ximian.com>
10777 * delegate.cs: Convert this file to Unix mode - like the original
10780 2004-05-20 Martin Baulig <martin@ximian.com>
10782 * attribute.cs: Convert this file to Unix mode - like the original
10785 2004-05-19 Marek Safar <marek.safar@seznam.cz>
10787 Fix bug #58688 (MCS does not report error when the same attribute
10790 * attribute.cs (Attribute.Emit): Distinction between null and default.
10792 2004-05-19 Raja R Harinath <rharinath@novell.com>
10794 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
10795 of a top-level attribute without an attribute target.
10796 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
10798 (Attribute.Conditional_GetConditionName),
10799 (Attribute.Obsolete_GetObsoleteMessage): Update.
10800 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
10801 part of ScanForIndexerName.
10802 (Attribute.CanIgnoreInvalidAttribute): New function.
10803 (Attribute.ScanForIndexerName): Move to ...
10804 (Attributes.ScanForIndexerName): ... here.
10805 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
10806 (Attributes.Search): New internal variant that can choose not to
10807 complain if types aren't resolved. The original signature now
10809 (Attributes.GetClsCompliantAttribute): Use internal variant, with
10810 complaints suppressed.
10811 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
10812 only if it not useful.
10813 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
10814 top-level for attributes that are shared between the assembly
10815 and a top-level class.
10816 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
10817 * class.cs: Update to reflect changes.
10818 (DefineIndexers): Fuse loops.
10819 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
10820 a couple more variants of attribute names.
10822 2004-05-18 Marek Safar <marek.safar@seznam.cz>
10824 Fix bug #52585 (Implemented explicit attribute declaration)
10827 (Attributable.ValidAttributeTargets): New abstract method. It gets
10828 list of valid attribute targets for explicit target declaration.
10829 (Attribute.Target): It holds target itself.
10830 (AttributeSection): Removed.
10831 (Attribute.CheckTargets): New method. It checks whether attribute
10832 target is valid for the current element.
10835 (EventProperty): New class. For events that are declared like
10836 property (with add and remove accessors).
10837 (EventField): New class. For events that are declared like field.
10840 * cs-parser.jay: Implemented explicit attribute target declaration.
10842 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
10843 Override ValidAttributeTargets.
10846 (ReturnParameter): Class for applying custom attributes on
10848 (ParameterAtribute): New class. Class for applying custom
10849 attributes on the parameter type.
10851 2004-05-17 Miguel de Icaza <miguel@ximian.com>
10853 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
10856 (Method): Allow UNSAFE here.
10858 * modifiers.cs: Support unsafe reporting.
10860 2004-05-17 Marek Safar <marek.safar@seznam.cz>
10862 * decl.cs: Fix bug #58478.
10864 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10866 * statement.cs: When checking for unreachable code on an EmptyStatement,
10867 set the location. Fixes bug #58488.
10869 2004-05-13 Miguel de Icaza <miguel@ximian.com>
10871 * driver.cs: Add -pkg handling.
10873 From Gonzalo: UseShelLExecute=false
10875 2004-05-12 Marek Safar <marek.safar@seznam.cz>
10878 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
10880 (Attribute.IsClsCompliaceRequired): Moved to base for better
10882 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
10883 when attribute is AttributeUsageAttribute.
10884 (Attribute.GetValidTargets): Simplified.
10885 (Attribute.GetAttributeUsage): New method returns AttributeUsage
10886 attribute for this type.
10887 (Attribute.ApplyAttributes): Method renamed to Emit and make
10889 (GlobalAttributeSection): New class for special handling of global
10890 attributes (assembly, module).
10891 (AttributeSection.Emit): New method.
10893 * class.cs: Implemented Attributable abstract methods.
10894 (MethodCore.LabelParameters): Moved to Parameter class.
10895 (Accessor): Is back simple class.
10896 (PropertyMethod): Implemented Attributable abstract class.
10897 (DelegateMethod): Implemented Attributable abstract class.
10898 (Event): New constructor for disctintion between normal Event
10899 and Event with accessors.
10901 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
10903 * codegen.cs, const.cs, decl.cs, delegate.cs:
10904 (CommonAssemblyModulClass): Implemented Attributable abstract class
10907 * enum.cs: Implement IAttributeSupport interface.
10908 (EnumMember): New class for emum members. Implemented Attributable
10912 (ParameterBase): Is abstract.
10913 (ReturnParameter): New class for easier [return:] attribute handling.
10915 * typemanager.cs: Removed builder_to_attr.
10917 2004-05-11 Raja R Harinath <rharinath@novell.com>
10920 * attribute.cs (Attribute.GetPositionalValue): New function.
10921 * class.cs (TypeContainer.VerifyMembers): New function.
10922 (TypeContainer.Emit): Use it.
10923 (ClassOrStruct): New base class for Class and Struct.
10924 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
10925 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
10927 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
10928 then each non-static field should have a FieldOffset attribute.
10929 Otherwise, none of the fields should have a FieldOffset attribute.
10930 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
10931 and FieldOffset attributes.
10932 * typemanager.cs (TypeManager.struct_layout_attribute_type)
10933 (TypeManager.field_offset_attribute_type): New core types.
10934 (TypeManager.InitCoreTypes): Initialize them.
10936 2004-05-11 Michal Moskal <malekith@pld-linux.org>
10938 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
10939 Return correct type.
10942 2004-05-09 Miguel de Icaza <miguel@ximian.com>
10944 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
10945 be implicitly converted to ulong.
10947 * expression.cs: The logic for allowing operator &, | and ^ worked
10948 was wrong, it worked before because we did not report an error in
10949 an else branch. Fixes 57895.
10951 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
10952 allow volatile fields to be reference types.
10954 2004-05-07 Miguel de Icaza <miguel@ximian.com>
10956 * driver.cs: Add support for /debug-
10958 2004-05-07 Raja R Harinath <rharinath@novell.com>
10960 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
10961 Add a 'complain' parameter to silence errors.
10962 (Attribute.Resolve): Update to changes. Put in sanity check to catch
10963 silently overlooked type-resolutions.
10964 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
10965 to reflect changes.
10966 (Attributes.Search): New function.
10967 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
10968 (Attributes.GetAttributeFullName): Remove hack.
10969 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
10970 Update to reflect changes.
10971 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10972 Use Attributes.Search instead of nested loops.
10974 2004-05-07 Marek Safar <marek.safar@seznam.cz>
10977 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
10978 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
10979 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
10981 * report.cs: (Report.Warning): Renamed to Warning_T because of
10982 parameter collision.
10984 2004-05-05 Raja R Harinath <rharinath@novell.com>
10986 * expression.cs (MemberAccess.ResolveMemberAccess):
10987 Exit with non-zero status after Report.Error.
10988 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
10990 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
10992 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
10994 * support.cs: Don't hang when the file is empty.
10996 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
10998 * support.cs: In SeekableStreamReader, compute the preamble size of the
10999 underlying stream. Position changes should take into account that initial
11002 2004-05-03 Todd Berman <tberman@sevenl.net>
11004 * driver.cs: remove unused GetSysVersion function.
11006 2004-05-03 Todd Berman <tberman@sevenl.net>
11008 * driver.cs: Remove the hack from saturday, as well as the hack
11009 from jackson (LoadAssemblyFromGac), also adds the CWD to the
11010 link_paths to get that bit proper.
11012 2004-05-01 Todd Berman <tberman@sevenl.net>
11014 * driver.cs: Try a LoadFrom before a Load, this checks the current
11015 path. This is currently a bug in mono that is be fixed, however, this
11016 provides a workaround for now. This will be removed when the bug
11019 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11021 * CryptoConvert.cs: Updated to latest version. Fix issue with
11022 incomplete key pairs (#57941).
11024 2004-05-01 Todd Berman <tberman@sevenl.net>
11026 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11029 2004-04-30 Jackson Harper <jackson@ximian.com>
11031 * codegen.cs: Open keys readonly.
11033 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11035 * typemanager.cs: don't report cyclic struct layout when a struct
11036 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11037 which has 2 Pango.Rectangle fields.
11039 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11041 * expression.cs: Handle IntPtr comparisons with IL code
11042 rather than a method call.
11044 2004-04-29 Martin Baulig <martin@ximian.com>
11046 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11047 the list of PropertyInfo's in class hierarchy and find the
11048 accessor. Fixes #56013.
11050 2004-04-29 Martin Baulig <martin@ximian.com>
11052 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11054 2004-04-29 Martin Baulig <martin@ximian.com>
11056 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11058 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11060 2004-04-29 Martin Baulig <martin@ximian.com>
11062 * class.cs (ConstructorInitializer.Resolve): Check whether the
11063 parent .ctor is accessible. Fixes #52146.
11065 2004-04-29 Martin Baulig <martin@ximian.com>
11067 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11069 * statement.cs (Using.EmitLocalVariableDecls): Use
11070 TypeManager.idisposable_type, not typeof (IDisposable).
11071 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11073 2004-04-29 Martin Baulig <martin@ximian.com>
11075 * class.cs (Event.Define): Don't emit the field and don't set
11076 RTSpecialName and SpecialName for events on interfaces. Fixes
11079 2004-04-29 Raja R Harinath <rharinath@novell.com>
11081 Refactor Attribute.ApplyAttributes.
11082 * attribute.cs (Attributable): New base class for objects that can
11083 have Attributes applied on them.
11084 (Attribute): Make AttributeUsage fields public.
11085 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11086 (Attribute.IsInternalCall): New property.
11087 (Attribute.UsageAttr): Convert to a public read-only property.
11088 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11089 (Attribute.ResolveType, Attribute.Resolve)
11090 (Attribute.ScanForIndexerName): Update to reflect changes.
11091 (Attribute.CheckAttributeTarget): Re-format.
11092 (Attribute.ApplyAttributes): Refactor, to various
11093 Attributable.ApplyAttributeBuilder methods.
11094 * decl.cs (MemberCore): Make Attributable.
11095 * class.cs (Accessor): Make Attributable.
11096 (MethodData.ApplyAttributes): Use proper attribute types, not
11098 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11099 (TypeContainer.ApplyAttributeBuilder)
11100 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11101 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11102 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11103 (Operator.ApplyAttributeBuilder): New factored-out methods.
11104 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11105 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11106 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11107 * parameter.cs (ParameterBase): New Attributable base class
11108 that can also represent Return types.
11109 (Parameter): Update to the changes.
11111 2004-04-29 Jackson Harper <jackson@ximian.com>
11113 * driver.cs: Prefer the corlib system version when looking for
11114 assemblies in the GAC. This is still a hack, but its a better hack
11117 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11119 * decl.cs, enum.cs: Improved error 3005 reporting.
11121 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11122 (related_symbols): New private member for list of symbols
11123 related to reported error/warning.
11125 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11127 2004-04-29 Martin Baulig <martin@ximian.com>
11129 * ecore.cs (Expression.Constantify): If we're an enum and
11130 TypeManager.TypeToCoreType() doesn't give us another type, use
11131 t.UnderlyingSystemType. Fixes #56178.
11133 2004-04-29 Martin Baulig <martin@ximian.com>
11135 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11136 interfaces and for each interface, only add members directly
11137 declared in that interface. Fixes #53255.
11139 2004-04-28 Martin Baulig <martin@ximian.com>
11141 * expression.cs (ConditionalLogicalOperator): Use a temporary
11142 variable for `left' to avoid that we evaluate it more than once;
11145 2004-04-28 Martin Baulig <martin@ximian.com>
11147 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11150 2004-04-28 Martin Baulig <martin@ximian.com>
11152 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11155 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11156 whether the type is not void (CS1547).
11158 2004-04-28 Martin Baulig <martin@ximian.com>
11160 * expression.cs (Unary.DoResolveLValue): Override this and report
11161 CS0131 for anything but Operator.Indirection.
11163 2004-04-28 Martin Baulig <martin@ximian.com>
11165 Committing a patch from Ben Maurer; see bug #50820.
11167 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11170 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11173 2004-04-28 Martin Baulig <martin@ximian.com>
11175 Committing a patch from Ben Maurer; see bug #50820.
11177 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11180 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11183 2004-04-28 Martin Baulig <martin@ximian.com>
11185 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11186 (Block.AddLabel): Call DoLookupLabel() to only search in the
11189 2004-04-28 Martin Baulig <martin@ximian.com>
11191 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11192 comparing StringConstants and NullLiterals in Equality and Inequality.
11194 2004-04-28 Jackson Harper <jackson@ximian.com>
11196 * driver.cs: Attempt to load referenced assemblies from the
11197 GAC. This is the quick and dirty version of this method that
11198 doesnt take into account versions and just takes the first
11199 canidate found. Will be good enough for now as we will not have more
11200 then one version installed into the GAC until I update this method.
11202 2004-04-28 Martin Baulig <martin@ximian.com>
11204 * typemanager.cs (TypeManager.CheckStructCycles): New public
11205 static method to check for cycles in the struct layout.
11207 * rootcontext.cs (RootContext.PopulateTypes): Call
11208 TypeManager.CheckStructCycles() for each TypeContainer.
11209 [Note: We only need to visit each type once.]
11211 2004-04-28 Martin Baulig <martin@ximian.com>
11213 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11215 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11216 success and added `out object value'. Use a `bool resolved' field
11217 to check whether we've already been called rather than
11218 `ConstantValue != null' since this breaks for NullLiterals.
11220 2004-04-28 Raja R Harinath <rharinath@novell.com>
11222 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11223 setting of this flag, since the 'set' method may be non-public.
11225 2004-04-28 Raja R Harinath <rharinath@novell.com>
11227 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11228 check on current_vector.Block.
11230 2004-04-27 Martin Baulig <martin@ximian.com>
11232 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11233 a field initializer. Fixes #56459.
11235 2004-04-27 Martin Baulig <martin@ximian.com>
11237 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11238 we're not attempting to use an indexer. Fixes #52154.
11240 2004-04-27 Martin Baulig <martin@ximian.com>
11242 * statement.cs (Return): Don't create a return label if we don't
11243 need it; reverts my change from January 20th. Thanks to Ben
11246 2004-04-27 Martin Baulig <martin@ximian.com>
11248 According to the spec, `goto' can only leave a nested scope, but
11251 * statement.cs (Block.LookupLabel): Only lookup in the current
11252 block, don't recurse into parent or child blocks.
11253 (Block.AddLabel): Check in parent and child blocks, report
11254 CS0140/CS0158 if we find a duplicate.
11255 (Block): Removed this indexer for label lookups.
11256 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11257 this already does the error reporting for us.
11260 (FlowBranching.UsageVector.Block): New public variable; may be null.
11261 (FlowBranching.CreateSibling): Added `Block' argument.
11262 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11263 label for the target of a `goto' and check whether we're not
11264 leaving a `finally'.
11266 2004-04-27 Martin Baulig <martin@ximian.com>
11268 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11269 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11272 2004-04-27 Martin Baulig <martin@ximian.com>
11274 * statement.cs (Block.AddLabel): Also check for implicit blocks
11275 and added a CS0158 check.
11277 2004-04-27 Martin Baulig <martin@ximian.com>
11279 * flowanalysis.cs (FlowBranchingLoop): New class.
11280 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11281 UsageVector's instead of an ArrayList.
11282 (FlowBranching.Label): Likewise.
11283 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11284 (FlowBranching.AddBreakVector): New method.
11286 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11288 * attribute.cs: Small regression fix: only convert the type if we
11289 the type is different, fixes System.Drawing build.
11291 2004-04-27 Martin Baulig <martin@ximian.com>
11293 * attribute.cs (Attribute.Resolve): If we have a constant value
11294 for a named field or property, implicity convert it to the correct
11297 2004-04-27 Raja R Harinath <rharinath@novell.com>
11299 * statement.cs (Block.Block): Implicit blocks share
11300 'child_variable_names' fields with parent blocks.
11301 (Block.AddChildVariableNames): Remove.
11302 (Block.AddVariable): Mark variable as "used by a child block" in
11303 every surrounding block.
11304 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11305 been used in a child block, complain about violation of "Invariant
11306 meaning in blocks" rule.
11307 * cs-parser.jay (declare_local_variables): Don't use
11308 AddChildVariableNames.
11309 (foreach_statement): Don't create an implicit block: 'foreach'
11310 introduces a scope.
11312 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11314 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11315 converting from 0L to ulong. Fixes 57522.
11317 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11319 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11320 derived class hides via 'new' keyword field from base class (test-242.cs).
11321 TODO: Handle this in the more general way.
11323 * class.cs (CheckBase): Ditto.
11325 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11327 * decl.cs (caching_flags): New member for storing cached values
11329 (MemberCore.Flags): New enum where bit flags for caching_flags
11331 (MemberCore.cls_compliance): Moved to caching_flags.
11332 (DeclSpace.Created): Moved to caching_flags.
11334 * class.cs: Use caching_flags instead of DeclSpace.Created
11336 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11338 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11339 if we are only a derived class, not a nested class.
11341 * typemanager.cs: Same as above, but do this at the MemberLookup
11342 level (used by field and methods, properties are handled in
11343 PropertyExpr). Allow for the qualified access if we are a nested
11346 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11348 * class.cs: Refactoring.
11349 (IMethodData): New inteface; Holds links to parent members
11350 to avoid member duplication (reduced memory allocation).
11351 (Method): Implemented IMethodData interface.
11352 (PropertyBase): New inner classes for get/set methods.
11353 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11354 (Event): New inner classes for add/remove methods.
11355 (Event.DelegateMethod): Implemented IMethodData interface.
11357 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11358 EmitContext (related to class.cs refactoring).
11360 2004-04-21 Raja R Harinath <rharinath@novell.com>
11362 * delegate.cs (Delegate.VerifyApplicability): If the number of
11363 arguments are the same as the number of parameters, first try to
11364 verify applicability ignoring any 'params' modifier on the last
11368 2004-04-08 Martin Baulig <martin@ximian.com>
11370 Merged latest changes into gmcs. Please keep this comment in
11371 here, it makes it easier for me to see what changed in MCS since
11372 the last time I merged.
11374 2004-04-16 Raja R Harinath <rharinath@novell.com>
11376 * class.cs (TypeContainer.AddIndexer): Use
11377 'ExplicitInterfaceName' to determine if interface name was
11378 explicitly specified. 'InterfaceType' is not initialized at this time.
11379 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11380 Indexers array is already in the required order. Initialize
11381 'IndexerName' only if there are normal indexers.
11382 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11383 (TypeContainer.Emit): Emit DefaultMember attribute only if
11384 IndexerName is initialized.
11387 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11389 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11392 2004-04-15 Raja R Harinath <rharinath@novell.com>
11394 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11398 * attribute.cs (Attribute.Resolve): Check for duplicate named
11402 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11404 * iterators.cs (MarkYield): track whether we are in an exception,
11405 and generate code accordingly. Use a temporary value to store the
11406 result for our state.
11408 I had ignored a bit the interaction of try/catch with iterators
11409 since their behavior was not entirely obvious, but now it is
11410 possible to verify that our behavior is the same as MS .NET 2.0
11414 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11416 * iterators.cs: Avoid creating temporaries if there is no work to
11419 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11420 Enumerations, use TypeManager.EnumToUnderlying and call
11423 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11426 (This.Emit): Use EmitContext.EmitThis to emit our
11429 (This.EmitAssign): Ditto.
11431 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11432 codepaths, we will move all the functionality into
11435 (FieldExpr.EmitAssign): Ditto.
11437 This fixes several hidden bugs that I uncovered while doing a code
11438 review of this today.
11440 * codegen.cs (EmitThis): reworked so the semantics are more clear
11441 and also support value types "this" instances.
11443 * iterators.cs: Changed so that for iterators in value types, we
11444 do not pass the value type as a parameter.
11446 Initialization of the enumerator helpers is now done in the caller
11447 instead of passing the parameters to the constructors and having
11448 the constructor set the fields.
11450 The fields have now `assembly' visibility instead of private.
11452 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11454 * expression.cs (Argument.Resolve): Check if fields passed as ref
11455 or out are contained in a MarshalByRefObject.
11457 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11458 another compiler type.
11460 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11462 * class.cs (Indexer.Define): use the new name checking method.
11463 Also, return false on an error.
11464 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11465 (is_identifier_[start/part]_character): make static.
11467 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11469 * expression.cs (Binary.ResolveOperator): Do no append strings
11470 twice: since we can be invoked more than once (array evaluation)
11471 on the same concatenation, take care of this here. Based on a fix
11472 from Ben (bug #56454)
11474 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11476 * codegen.cs: Fix another case where CS1548 must be reported (when
11477 delay-sign isn't specified and no private is available #56564). Fix
11478 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11479 error when MCS is used on the MS runtime and we need to delay-sign
11480 (which seems unsupported by AssemblyBuilder - see #56621).
11482 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11484 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11485 (TypeManager.ComputeNamespaces): Faster implementation for
11488 * compiler.csproj: Updated AssemblyName to mcs.
11490 2004-05-11 Jackson Harper <jackson@ximian.com>
11492 * Makefile: Preserve MONO_PATH
11494 2004-05-11 Jackson Harper <jackson@ximian.com>
11496 * Makefile: Use mono and mcs to build gmcs
11498 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11500 * codegen.cs: Add patch from Robert Shade
11501 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11504 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11506 * CryptoConvert.cs: Updated to latest version. Fix issue with
11507 incomplete key pairs (#57941).
11509 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11511 * codegen.cs: Fix another case where CS1548 must be reported (when
11512 delay-sign isn't specified and no private is available #56564). Fix
11513 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11514 error when MCS is used on the MS runtime and we need to delay-sign
11515 (which seems unsupported by AssemblyBuilder - see #56621).
11517 2004-04-29 Jackson Harper <jackson@ximian.com>
11519 * Makefile: Set MONO_PATH to use the bootstrap corlib
11520 * driver.cs: Check the GAC for referenced assemblies.
11522 2004-04-29 Martin Baulig <martin@ximian.com>
11524 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11526 2004-04-07 Martin Baulig <martin@ximian.com>
11528 * expression.cs (Binary.ResolveOperator): Added special case for
11529 Equality/Inequality between a type parameter and a null literal.
11531 2004-04-07 Martin Baulig <martin@ximian.com>
11533 * convert.cs: Check null literal -> type parameter conversions.
11535 2004-04-07 Martin Baulig <martin@ximian.com>
11537 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11538 `class' and `struct' constraints.
11540 2004-04-07 Martin Baulig <martin@ximian.com>
11542 * generic.cs (SpecialConstraint): New public enum.
11543 (Constraints.Resolve): Added support for the `class' and `struct'
11546 * cs-parser.jay (type_parameter_constraint): Added support for the
11547 `class' and `struct' constraints.
11549 2004-04-07 Martin Baulig <martin@ximian.com>
11551 * support.cs (GenericConstraints): Replaced `Types' by
11552 `ClassConstraint' and `InterfaceConstraints'; added
11553 `HasClassConstraint'.
11555 2004-04-07 Martin Baulig <martin@ximian.com>
11558 (Constraints.InterfaceConstraints): New public property.
11559 (Constraints.Types): Make this property public
11560 (TypeParameter): Implement IMemberContainer.
11561 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11562 instead of a TypeBuilder/MethodBuilder; pass the interface
11563 constraints to TypeManager.AddTypeParameter().
11564 (TypeParameter.DefineType): Just take an EmitContext and no
11565 TypeBuilder/MethodBuilder. Use the new public API.
11567 * typemanager.cs (TypeManager.AddTypeParameter): Added
11568 `TypeExpr[]' argument; add the interfaces to the
11569 `builder_to_ifaces' hash.
11570 (TypeManager.LookupMemberContainer): For
11571 GenericTypeParameterBuilders, get the TypeParameter from the
11572 `builder_to_type_param'.
11573 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11574 the TypeParameter and call FindMembers on it.
11576 2004-04-07 Martin Baulig <martin@ximian.com>
11579 (MethodCore.GenericMethod): Moved this field here from Method.
11580 (MethodCore.IsDuplicateImplementation): Take the number of type
11581 parameters into account if we're a generic method.
11583 * expression.cs (Invocation.InferTypeArguments): Don't return true
11584 if `arguments' is null; we still need to check whether we actually
11585 don't need to infer anything in this case.
11586 (MemberAccess): Merged the functionality from GenericMemberAccess
11589 * generic.cs (GenericMemberAccess): Removed.
11591 2004-04-05 Martin Baulig <martin@ximian.com>
11593 * decl.cs (MemberCore): For generic classes, interfaces and
11594 structs, `Name' now includes the number of type parameters
11595 ("Stack!1.Node!1").
11596 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11597 encode the number of type arguments in the type name.
11599 * expression.cs (Expression.MemberLookup): Removed the
11600 `num_type_args' argument; we now encode the number of type
11601 arguments in the type name.
11603 * ecore.cs (SimpleName): Encode the number of type arguments in
11604 the type name itself.
11606 * generic.cs (ConstructedType): Likewise.
11608 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11609 `MemberName'; we now include the number of type parameters in the
11612 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11613 (TypeManager.MemberLookup): Removed the
11614 `num_type_args' argument; we now encode the number of type
11615 arguments in the type name.
11617 2004-04-03 Martin Baulig <martin@ximian.com>
11619 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11620 (MemberCore.MemberName): Moved here from MemberBase.
11621 (DeclSpace.SetParameterInfo): Just take the constraints as an
11622 ArrayList; we already have the type parameters in our
11623 `MemberName'; also do the CS0080 reporting here.
11625 * cs-parser.jay (struct_declaration): Use `member_name' instead of
11626 `IDENTIFIER opt_type_parameter_list'; when constructing our
11627 `MemberName', it'll already include our type parameters.
11628 (class_declaration, interface_declaration): Likewise.
11629 (delegate_declaration): Likewise.
11630 (MakeName): Take a MemberName and return a MemberName.
11631 The following two changes are required to avoid shift/reduce conflicts:
11632 (member_name): Don't include a TypeName anymore; ie. this is now
11633 just 'IDENTIFIER opt_type_parameter_list'.
11634 (property_declaration, event_declaration): Use a
11635 `namespace_or_type_name' instead of a `member_name'.
11637 2004-04-03 Martin Baulig <martin@ximian.com>
11639 * decl.cs (MemberName): Renamed to `TypeName' and created a new
11640 `MemberName' class.
11641 (TypeName): Formerly known as MemberName.
11643 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
11644 instead of a `MemberName'.
11646 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
11647 (member_name): New rule; create a MemberName.
11649 2004-04-02 Martin Baulig <martin@ximian.com>
11651 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
11652 (CS0305 and CS0308).
11654 2004-04-02 Martin Baulig <martin@ximian.com>
11656 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
11657 support for nested types.
11659 2004-04-02 Martin Baulig <martin@ximian.com>
11661 * ecore.cs (IAlias): New public interface.
11662 (TypeExpr, TypeExpression): Implement IAlias.
11663 (TypeAliasExpression): New public class.
11665 * namespace.cs (Namespace): Implement IAlias.
11666 (Namespace.Lookup): Return an IAlias instead on an object.
11667 (Namespace.DefineName): Take an IAlias instead of an object.
11668 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
11670 (NamespaceEntry.UsingAlias): Take a Membername instead of an
11672 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
11674 (NamespaceEntry.Lookup): Likewise.
11676 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
11679 * decl.cs (DeclSpace): Implement IAlias.
11680 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
11682 * generic.cs (ConstructedType): Improved error checking.
11684 2004-04-02 Martin Baulig <martin@ximian.com>
11686 * convert.cs: Added type parameter conversions.
11689 (UnboxCast.Emit): Emit an `unbox.any' for type params.
11690 (ClassCast.Emit): If the source type is a type parameter, box it.
11691 If the target type is a type parameter, emit an `unbox.any'
11692 instead of a `classcast'.1
11694 2004-04-01 Martin Baulig <martin@ximian.com>
11696 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
11698 2004-04-01 Martin Baulig <martin@ximian.com>
11700 * generic.cs (ConstructedType.CheckConstraints): Use
11701 Convert.ImplicitStandardConversionExists(); user-defined implicit
11702 conversions are not allowed according to the spec.
11704 2004-03-30 Martin Baulig <martin@ximian.com>
11706 * expression.cs (New): Added support for type parameters.
11709 (TypeManager.activator_type): New public static field.
11710 (TypeManager.activator_create_instance): Likewise.
11712 2004-03-30 Martin Baulig <martin@ximian.com>
11714 * typemanager.cs (TypeManager.HasConstructorConstraint): New
11717 2004-03-30 Martin Baulig <martin@ximian.com>
11719 * generic.cs (ConstructedType.CheckConstraints): Actually follow
11720 the spec here: the argument type must be convertible to the
11723 2004-03-30 Martin Baulig <martin@ximian.com>
11726 (TypeParameter.Define, TypeParameter.DefineMethod): Call
11727 TypeManager.AddTypeParameter().
11728 (ConstructedType.CheckConstraints): Re-enable this and actually
11729 check whether we have a constructor constraint.
11732 (TypeManager.builder_to_type_param): New static field.
11733 (TypeManager.AddTypeParameter): New static method.
11734 (TypeManager.LookupTypeParameter): New public method.
11736 2004-03-30 Martin Baulig <martin@ximian.com>
11738 * generic.cs (TypeParameter.DefineType): Return a boolean and use
11739 the new API to actually define the constructor constraint.
11742 (TypeManager.new_constraint_attr_type): New static field.
11743 (TypeManager.InitCoreTypes): Initialize it.
11745 2004-03-30 Martin Baulig <martin@ximian.com>
11747 * generic.cs (Constraints): Completed error checking, use correct
11750 2004-03-29 Martin Baulig <martin@ximian.com>
11752 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
11754 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11755 public version which takes a `ParameterData pd' instead of an
11758 2004-03-29 Martin Baulig <martin@ximian.com>
11760 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
11763 2004-03-29 Martin Baulig <martin@ximian.com>
11765 * expression.cs (Argument.ResolveMethodGroup): If we're a
11766 ConstructedType, call GetMemberAccess() on it.
11768 2004-03-29 Martin Baulig <martin@ximian.com>
11770 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
11771 (MethodCore.CheckGenericOverride): When overriding a generic
11772 method, check whether the constraints match.
11774 * support.cs (GenericConstraints): New public interface.
11775 (ParameterData.GenericConstraints): New public method.
11777 * parameter.cs (Parameter.Resolve): Check whether we're a generic
11778 method parameter and compute our constraints if appropriate.
11779 (Parameter.GenericConstraints): New public property.
11781 * generic.cs (Constraints): Implement GenericConstraints.
11783 2004-03-29 Martin Baulig <martin@ximian.com>
11785 * decl.cs (MemberCache.FindMemberToOverride): Use
11786 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
11788 2004-03-29 Martin Baulig <martin@ximian.com>
11790 * generic.cs (GenericMethod.Define): Resolve our type parameters.
11792 2004-03-29 Martin Baulig <martin@ximian.com>
11794 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
11795 not allowed on non-generic declarations").
11797 2004-03-29 Martin Baulig <martin@ximian.com>
11799 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11800 public version of this method.
11802 * class.cs (MethodCore.IsDuplicateImplementation): Use
11803 Invocation.InferTypeArguments() to check this.
11805 2004-03-29 Martin Baulig <martin@ximian.com>
11807 * convert.cs: Use TypeManager.IsDelegateType() instead of
11808 comparing types correctly.
11810 2004-03-29 Martin Baulig <martin@ximian.com>
11812 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
11813 types directly to make it work for generic instances.
11815 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
11817 2004-03-29 Martin Baulig <martin@ximian.com>
11819 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
11820 support for arrays.
11822 2004-03-24 Martin Baulig <martin@ximian.com>
11824 * decl.cs (DeclSpace.FindType): Also use
11825 TypeManager.CheckGeneric() for types from the using clauses.
11827 2004-03-23 Martin Baulig <martin@ximian.com>
11829 * expression.cs (Invocation.OverloadResolve): Added `bool
11830 may_fail' argument and use it instead of the Location.IsNull() hack.
11832 2004-03-23 Martin Baulig <martin@ximian.com>
11834 * expression.cs (Invocation.InferType): Use correct type inference
11837 2004-03-23 Martin Baulig <martin@ximian.com>
11839 * ecore.cs (MethodGroupExpr.Name): Use
11840 TypeManager.CSharpSignature() instead of just the name.
11842 * expression.cs (Invocation.OverloadResolve): Provide better error
11844 (Invocation.DoResolve): OverloadResolve() never returns null
11845 without reporting an error, so removed the error -6 reporting here.
11847 2004-03-23 Martin Baulig <martin@ximian.com>
11849 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
11852 * cs-parser.jay (delegate_declaration): Support generic delegates.
11854 * delegate.cs: Support generic delegates.
11856 2004-03-22 Martin Baulig <martin@ximian.com>
11858 * expression.cs (Invocation.InferParamsTypeArguments): New static
11859 method; does type inference for params arguments.
11861 2004-03-21 Martin Baulig <martin@ximian.com>
11863 * typemanager.cs (TypeManager.IsGenericMethod): New public static
11864 method; checks whether a method is a generic method.
11866 * expression.cs (Invocation.InferTypeArguments): New static method;
11867 infer type arguments for generic method invocation.
11869 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
11870 property; we set this to true if we're resolving a generic method
11871 invocation and the user specified type arguments, ie. we're not
11872 doing type inference.
11874 2004-03-20 Martin Baulig <martin@ximian.com>
11876 * class.cs (MethodData.DeclaringType): New public property.
11877 (MethodData.Define): Set DeclaringType here.
11878 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
11879 instead of OperatorMethodBuilder.DeclaringType.
11881 2004-03-20 Martin Baulig <martin@ximian.com>
11883 * cs-tokenizer.cs (xtoken): Return a special
11884 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
11886 * cs-parser.jay (default_value_expression): Switch to the new
11889 2004-03-19 Martin Baulig <martin@ximian.com>
11891 * decl.cs (MemberName): New class. We use this to "construct"
11892 namespace_or_type_name's.
11894 * generics.cs (TypeArguments.GetDeclarations): New public method;
11895 returns the type arguments as a string[] and reports a CS0081 if
11896 one of them is not an identifier.
11898 * class.cs (MemberBase): The .ctor now takes the name as a
11899 MemberName instead of a string.
11900 (MemberBase.ExplicitInterfaceName): Changed type from string to
11902 (MemberBase.DoDefine): If we're an explicit implementation, the
11903 InterfaceType may be a generic instance.
11905 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
11906 (namespace_name): Call MemberName.GetName () to transform the
11907 MemberName into a string and ensure we don't have any type
11909 (type_name): Call MemberName.GetTypeExpression() to transfrom the
11910 MemberName into an expression.
11911 (method_header): Use namespace_or_type_name instead of member_name.
11913 2004-04-07 Miguel de Icaza <miguel@ximian.com>
11915 * rootcontext.cs: Add new types to the boot resolution.
11917 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
11918 MulticastDelegate is not allowed.
11920 * typemanager.cs: Add new types to lookup: System.TypedReference
11923 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
11924 check for TypedReference or ArgIterator, they are not allowed.
11926 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
11927 makes us properly catch 1510 in some conditions (see bug 56016 for
11930 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
11932 * CryptoConvert.cs: update from corlib version
11935 2004-04-05 Miguel de Icaza <miguel@ximian.com>
11937 * class.cs (Indexer.Define): Check indexername declaration
11939 2004-04-05 Marek Safar <marek.safar@seznam.cz>
11941 * attribute.cs (IsClsCompliant): Fixed problem with handling
11942 all three states (compliant, not-compliant, undetected).
11944 2004-03-30 Marek Safar <marek.safar@seznam.cz>
11946 * attribute.cs (Attribute): Location is now public.
11947 (Resolve): Store resolved arguments (pos_values) in attribute class.
11948 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
11949 (GetClsCompliantAttributeValue): New method that gets
11950 CLSCompliantAttribute value.
11951 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
11952 if exists else null.
11953 (AttributeTester): New class for CLS-Compliant verification routines.
11955 * class.cs (Emit): Add CLS-Compliant verification.
11956 (Method.GetSignatureForError): Implemented.
11957 (Constructor.GetSignatureForError): Implemented
11958 (Constructor.HasCompliantArgs): Returns if constructor has
11959 CLS-Compliant arguments.
11960 (Constructor.Emit): Override.
11961 (Construcor.IsIdentifierClsCompliant): New method; For constructors
11962 is needed to test only parameters.
11963 (FieldBase.GetSignatureForError): Implemented.
11964 (TypeContainer): New member for storing base interfaces.
11965 (TypeContainer.FindMembers): Search in base interfaces too.
11967 * codegen.cs (GetClsComplianceAttribute): New method that gets
11968 assembly or module CLSCompliantAttribute value.
11969 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
11971 (ModuleClass.Emit): Add error 3012 test.
11973 * const.cs (Emit): Override and call base for CLS-Compliant tests.
11975 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
11976 state for all decl types.
11977 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
11978 if CLS-Compliant tests are required.
11979 (IsClsCompliaceRequired): New method. Analyze whether code
11980 must be CLS-Compliant.
11981 (IsExposedFromAssembly): New method. Returns true when MemberCore
11982 is exposed from assembly.
11983 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
11984 value or gets cached value.
11985 (HasClsCompliantAttribute): New method. Returns true if MemberCore
11986 is explicitly marked with CLSCompliantAttribute.
11987 (IsIdentifierClsCompliant): New abstract method. This method is
11988 used to testing error 3005.
11989 (IsIdentifierAndParamClsCompliant): New method. Common helper method
11990 for identifier and parameters CLS-Compliant testing.
11991 (VerifyClsCompliance): New method. The main virtual method for
11992 CLS-Compliant verifications.
11993 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
11994 null. I don't know why is null (too many public members !).
11995 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
11996 and get value of first CLSCompliantAttribute that found.
11998 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
11999 (VerifyClsCompliance): Override and add extra tests.
12001 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
12002 clscheck- disable CLS-Compliant verification event if assembly is has
12003 CLSCompliantAttribute(true).
12005 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
12006 ApllyAttribute is now called in emit section as in the other cases.
12007 Possible future Emit integration.
12008 (IsIdentifierClsCompliant): New override.
12009 (VerifyClsCompliance): New override.
12010 (GetEnumeratorName): Returns full enum name.
12012 * parameter.cs (GetSignatureForError): Implemented.
12014 * report.cs (WarningData): New struct for Warning message information.
12015 (LocationOfPreviousError): New method.
12016 (Warning): New method. Reports warning based on the warning table.
12017 (Error_T): New method. Reports error based on the error table.
12019 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12020 verifications are done here.
12022 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12024 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12025 CLSCompliantAttribute.
12026 (all_imported_types): New member holds all imported types from other
12028 (LoadAllImportedTypes): New method fills static table with exported types
12029 from all referenced assemblies.
12030 (Modules): New property returns all assembly modules.
12032 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12034 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12035 throwing a parser error.
12037 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12038 which removes the hardcoded get_/set_ prefixes for properties, as
12039 IL allows for the properties to be named something else.
12043 * expression.cs: Do not override operand before we know if it is
12044 non-null. Fix 56207
12046 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12048 * typemanager.cs: support for pinned variables.
12050 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12052 * decl.cs, typemanager.cs: Avoid using an arraylist
12053 as a buffer if there is only one result set.
12055 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12057 * expression.cs: Make sure you cant call a static method
12058 with an instance expression, bug #56174.
12060 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12062 * class.cs (IsDuplicateImplementation): Improve error reporting to
12063 flag 663 (method only differs in parameter modifier).
12065 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12066 in preprocessor directives.
12068 * location.cs (LookupFile): Allow for the empty path.
12070 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12071 better approach for some of that patch, but its failing with the
12072 CharSet enumeration. For now try/catch will do.
12074 * typemanager.cs: Do not crash if a struct does not have fields.
12077 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12079 * expression.cs: cs0213, cant fix a fixed expression.
12082 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12084 * cs-parser.jay: detect invalid embeded statements gracefully.
12087 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12089 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12092 the invocation type may not be a subclass of the tye of the item/
12093 The type of the item must be a subclass of the invocation item.
12098 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12100 * attribute.cs: Added methods to get a string and a bool from an
12101 attribute. Required to information from AssemblyKeyFileAttribute,
12102 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12103 * codegen.cs: Modified AssemblyName creation to include support for
12104 strongnames. Catch additional exceptions to report them as CS1548.
12105 * compiler.csproj: Updated include CryptoConvert.cs.
12106 * compiler.csproj.user: Removed file - user specific configuration.
12107 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12108 Mono.Security assembly. The original class is maintained and tested in
12109 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12110 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12111 like CSC 8.0 (C# v2) supports.
12112 * Makefile: Added CryptoConvert.cs to mcs sources.
12113 * rootcontext.cs: Added new options for strongnames.
12115 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12117 * driver.cs: For --expect-error, report error code `2'
12118 if the program compiled with no errors, error code `1' if
12119 it compiled with an error other than the one expected.
12121 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12123 * compiler.csproj: Updated for Visual Studio .NET 2003.
12124 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12125 * compiler.sln: Updated for Visual Studio .NET 2003.
12127 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12129 * expression.cs: Fix bug #47234. We basically need to apply the
12130 rule that we prefer the conversion of null to a reference type
12131 when faced with a conversion to 'object' (csc behaviour).
12133 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12135 * statement.cs: Shorter form for foreach, eliminates
12136 a local variable. r=Martin.
12138 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12140 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12141 checks if we can use brtrue/brfalse to test for 0.
12142 * expression.cs: use the above in the test for using brtrue/brfalse.
12143 cleanup code a bit.
12145 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12147 * expression.cs: Rewrite string concat stuff. Benefits:
12149 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12150 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12151 rather than a concat chain.
12153 * typemanager.cs: Add lookups for more concat overloads.
12155 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12157 * expression.cs: Emit shorter il code for array init.
12174 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12176 * statement.cs: Before, two switch blocks would be merged if the
12177 total size of the blocks (end_item - begin_item + 1) was less than
12178 two times the combined sizes of the blocks.
12180 Now, it will only merge if after the merge at least half of the
12185 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12187 * class.cs : csc build fix for GetMethods(). See bug #52503.
12189 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12191 * expression.cs: Make sure fp comparisons work with NaN.
12192 This fixes bug #54303. Mig approved this patch a long
12193 time ago, but we were not able to test b/c the runtime
12196 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12198 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12200 2004-03-19 Martin Baulig <martin@ximian.com>
12202 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12203 two overloads may unify for some type parameter substitutions and
12204 report a CS0408 if appropriate.
12206 2004-03-19 Martin Baulig <martin@ximian.com>
12208 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12209 error here and not in our caller.
12211 2004-03-19 Martin Baulig <martin@ximian.com>
12213 * interface.cs: Completely killed this file.
12214 (Interface): We're now a TypeContainer and live in class.cs.
12216 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12217 argument; we're now also called for interfaces.
12218 (TypeContainer.DefineMembers): Allow this method being called
12220 (TypeContainer.GetMethods): New public method; formerly known as
12221 Interface.GetMethod(). This is used by PendingImplementation.
12222 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12223 it's now private and non-static.
12224 (Interface): Moved this here; it's now implemented similar to
12226 (Method, Property, Event, Indexer): Added `bool is_interface'
12227 argument to their .ctor's.
12228 (MemberBase.IsInterface): New public field.
12230 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12231 instances instead of InterfaceMethod, InterfaceProperty, etc.
12232 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12233 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12235 2004-03-19 Martin Baulig <martin@ximian.com>
12237 * class.cs (MethodCore.IsDuplicateImplementation): New private
12238 method which does the CS0111 checking.
12239 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12240 Use IsDuplicateImplementation().
12242 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12244 * decl.cs (FindMemberToOverride): New method to find the correct
12245 method or property to override in the base class.
12247 - Make Method/Property use the above method to find the
12248 version in the base class.
12249 - Remove the InheritableMemberSignatureCompare as it is now
12252 This patch makes large code bases much faster to compile, as it is
12253 O(n) rather than O(n^2) to do this validation.
12255 Also, it fixes bug 52458 which is that nested classes are not
12256 taken into account when finding the base class member.
12258 Reviewed/Approved by Martin.
12260 2004-03-17 Martin Baulig <martin@ximian.com>
12262 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12263 of type arguments into account; use the `real_num_type_args'
12264 approach like in DoResolveAsTypeStep().
12266 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12269 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12271 * interface.cs: In all interface classes removed redundant
12272 member initialization.
12274 2004-03-16 Martin Baulig <martin@ximian.com>
12276 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12278 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12280 * decl.cs (DefineTypeAndParents): New helper method to define a
12281 type's containers before the type itself is defined; This is a
12282 bug exposed by the recent changes to Windows.Forms when an
12283 implemented interface was defined inside a class that had not been
12286 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12288 (Check): Loop correctly to report errors modifiers
12289 (UNSAFE was not in the loop, since it was the same as TOP).
12291 * interface.cs: Every interface member now takes a ModFlags,
12292 instead of a "is_new" bool, which we set on the base MemberCore.
12294 Every place where we called "UnsafeOk" in the interface, now we
12295 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12296 the unsafe settings from the member declaration instead of the
12297 container interface.
12299 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12301 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12302 `set_indexer_name' to the pending bits (one per type).
12304 We fixed a bug today that was picking the wrong method to
12305 override, since for properties the existing InterfaceMethod code
12306 basically ignored the method name. Now we make sure that the
12307 method name is one of the valid indexer names.
12309 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12311 * support.cs (SeekableStreamReader): Keep track of stream byte
12312 positions and don't mix them with character offsets to the buffer.
12314 Patch from Gustavo Giráldez
12316 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12318 * interface.cs (InterfaceSetGetBase): Removed double member
12319 initialization, base class does it as well.
12321 2004-03-13 Martin Baulig <martin@ximian.com>
12323 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12324 when compiling corlib.
12326 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12328 * convert.cs (ExplicitConversion): We were reporting an error on
12329 certain conversions (object_type source to a value type, when the
12330 expression was `null') before we had a chance to pass it through
12331 the user defined conversions.
12333 * driver.cs: Replace / and \ in resource specifications to dots.
12336 * class.cs: Add check for duplicate operators. Fixes 52477
12338 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12340 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12341 that are in the middle of the statements, not only at the end.
12344 * class.cs (TypeContainer.AddField): No longer set the
12345 `HaveStaticConstructor' flag, now we call it
12346 `UserDefineStaticConstructor' to diferentiate the slightly
12347 semantic difference.
12349 The situation is that we were not adding BeforeFieldInit (from
12350 Modifiers.TypeAttr) to classes that could have it.
12351 BeforeFieldInit should be set to classes that have no static
12356 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12358 And most importantly Zoltan's comment:
12360 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12362 "I think beforefieldinit means 'it's ok to initialize the type sometime
12363 before its static fields are used', i.e. initialization does not need
12364 to be triggered by the first access to the type. Setting this flag
12365 helps the JIT to compile better code, since it can run the static
12366 constructor at JIT time, and does not need to generate code to call it
12367 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12368 this flag for lots of classes like String.
12370 csc sets this flag if the type does not have an explicit static
12371 constructor. The reasoning seems to be that if there are only static
12372 initalizers for a type, and no static constructor, then the programmer
12373 does not care when this initialization happens, so beforefieldinit
12376 This bug prevents the AOT compiler from being usable, since it
12377 generates so many calls to mono_runtime_class_init that the AOT code
12378 is much slower than the JITted code. The JITted code is faster,
12379 because it does not generate these calls if the vtable is type is
12380 already initialized, which is true in the majority of cases. But the
12381 AOT compiler can't do this."
12383 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12385 * class.cs (MethodData.Emit): Refactor the code so symbolic
12386 information is generated for destructors; For some reasons we
12387 were taking a code path that did not generate symbolic information
12390 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12392 * class.cs: Create a Constructor.CheckBase method that
12393 takes care of all validation type code. The method
12394 contains some code that was moved from Define.
12396 It also includes new code that checks for duplicate ctors.
12397 This fixes bug #55148.
12399 2004-03-09 Joshua Tauberer <tauberer@for.net>
12401 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12402 a { ... }-style array creation invokes EmitStaticInitializers
12403 which is not good for reference-type arrays. String, decimal
12404 and now null constants (NullCast) are not counted toward
12405 static initializers.
12407 2004-03-05 Martin Baulig <martin@ximian.com>
12409 * location.cs (SourceFile.HasLineDirective): New public field;
12410 specifies whether the file contains or is referenced by a "#line"
12412 (Location.DefineSymbolDocuments): Ignore source files which
12413 either contain or are referenced by a "#line" directive.
12415 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12417 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12418 direct access to our parent, so check the method inline there.
12420 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12422 * expression.cs (Invocation.EmitCall): Miguel's last commit
12423 caused a regression. If you had:
12428 In Foo the implict this would be null.
12430 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12432 * expression.cs (Invocation.EmitCall): If the method is not
12433 virtual, do not emit a CallVirt to it, use Call.
12435 * typemanager.cs (GetFullNameSignature): Improve the method to
12436 cope with ".ctor" and replace it with the type name.
12438 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12439 as an argument the ConstructorBuilder where it is being defined,
12440 to catch the recursive constructor invocations.
12442 2004-03-16 Martin Baulig <martin@ximian.com>
12444 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12445 ConstructedType, call ResolveType() on it to get the type rather
12446 than just using `expr.Type'.
12448 2004-03-16 Martin Baulig <martin@ximian.com>
12450 * generics.cs (ConstructedType.GetMemberAccess): Take the
12451 EmitContext instead on the TypeExpr and use
12452 ec.TypeContainer.CurrentType/ec.ContainerType.
12454 2004-03-16 Martin Baulig <martin@ximian.com>
12456 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12457 parameters before aliases.
12459 2004-03-16 Martin Baulig <martin@ximian.com>
12461 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12462 New oublic function; checks whether two generic instances may become
12463 equal under some instantiations (26.3.1).
12465 * class.cs (TypeContainer.Define): Call
12466 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12469 2004-03-16 Martin Baulig <martin@ximian.com>
12471 * class.cs (TypeContainer.GetClassBases): Moved
12472 Error_TypeParameterAsBase() here and also check whether the base
12473 class is not an attribute.
12475 2004-03-16 Martin Baulig <martin@ximian.com>
12477 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12479 2004-03-16 Martin Baulig <martin@ximian.com>
12481 * class.cs (Error_TypeParameterAsBase): Use correct error number
12484 2004-03-16 Martin Baulig <martin@ximian.com>
12486 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12489 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12492 2004-03-15 Martin Baulig <martin@ximian.com>
12494 * typemanager.cs (TypeManager.GetFullName): New public method.
12495 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12496 argument; only return members with the correct number of type
12498 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12499 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12500 whether the number of type arguments matches.
12502 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12503 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12505 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12506 field; it's set by the protected .ctor when we're actually a
12507 GenericMemberAccess.
12508 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12509 arguments and pass it to MemberLookupFinal ().
12511 * ecore.cs (Expression.MemberLookup): Added `int
12512 num_type_arguments' argument; only return members with the correct
12513 number of type arguments.
12514 (Expression.MemberLookupFailed): Check whether the MemberLookup
12515 failed because we did not have the correct number of type
12516 arguments; report CS0305 in this case.
12518 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12519 `e.ResolveAsTypeTerminal()' already did so.
12521 2004-03-15 Martin Baulig <martin@ximian.com>
12523 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12524 we're a ConstructedType; in this case, the caller must report an
12525 error (for instance CS0131).
12527 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12528 (TypeArguments.Resolve): Actually report errors here.
12530 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12532 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12533 `set_indexer_name' to the pending bits (one per type).
12535 We fixed a bug today that was picking the wrong method to
12536 override, since for properties the existing InterfaceMethod code
12537 basically ignored the method name. Now we make sure that the
12538 method name is one of the valid indexer names.
12540 2004-03-15 Martin Baulig <martin@ximian.com>
12542 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12543 for generic instances.
12545 2004-03-13 Martin Baulig <martin@ximian.com>
12547 * class.cs (TypeContainer.DefineType): Call
12548 TypeManager.AddUserType() immediately after creating the
12549 TypeBuilder; pass all type parameters when creating the
12552 * decl.cs (DeclSpace.FindNestedType): New public method.
12553 (DeclSpace.FindType): Added `int num_type_args' argument; only
12554 return types with the correct number of type parameters.
12555 (DeclSpace.CountTypeParams): New public property.
12557 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12558 the number of type parameters; defaults to zero.
12560 * generic.cs (TypeArguments.Count): New public property.
12561 (ConstructedType.DoResolveAsTypeStep): First call
12562 ds.FindNestedType() to find out whether we're nested in the
12563 current generic type; in this case, we inherit all type parameters
12564 from the current class.
12566 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12567 num_type_args' argument.
12568 (RootContext.LookupType): Added overloaded version which takes the
12569 number of type arguments; only return types with the correct
12570 number of type arguments.
12572 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12573 checks whether `Type t' has `int num_type_args'.
12575 2004-03-13 Martin Baulig <martin@ximian.com>
12577 * generic.cs (GenericMethod.DefineType): New method; calls
12578 DefineType() on all the type parameters.
12580 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12581 (MethodData.Define): If we're a generic method, call
12582 GenericMethod.DefineType() to define the type parameters.
12584 2004-03-10 Martin Baulig <martin@ximian.com>
12586 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12587 instead of IsAssignableFrom.
12589 2004-03-10 Martin Baulig <martin@ximian.com>
12591 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12593 * support.cs (ParameterData.HasArrayParameter): New property.
12594 (ReflectionParameters.ctor): Take a MethodBase instead of a
12595 ParameterInfo[]. If we have any type parameters, get the generic
12596 method definition and ask it whether we have variable arguments.
12598 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12600 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12601 routines to check if a type is an enumerable/enumerator allow
12602 classes that implement the IEnumerable or IEnumerator interfaces.
12604 * class.cs (Property, Operator): Implement IIteratorContainer, and
12605 implement SetYields.
12607 (Property.Define): Do the block swapping for get_methods in the
12608 context of iterators. We need to check if Properties also
12609 include indexers or not.
12611 (Operator): Assign the Block before invoking the
12612 OperatorMethod.Define, so we can trigger the Iterator code
12615 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12616 Property and Operator classes are not created when we parse the
12617 declarator but until we have the block completed, so we use a
12618 singleton SimpleIteratorContainer.Simple to flag whether the
12619 SetYields has been invoked.
12621 We propagate this setting then to the Property or the Operator to
12622 allow the `yield' to function.
12624 2004-02-25 Marek Safar <marek.safar@seznam.cz>
12626 * codegen.cs: Implemented attribute support for modules.
12627 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
12628 Assembly/Module functionality.
12630 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
12631 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
12632 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
12634 2004-02-16 Marek Safar <marek.safar@seznam.cz>
12636 * interface.cs (FindMembers): The operation is performed on all base
12637 interfaces and not only on the first. It is required for future CLS Compliance patch.
12639 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
12641 * statement.cs, codegen.cs:
12642 This patch deals with patterns such as:
12644 public class List : IEnumerable {
12646 public MyEnumerator GetEnumerator () {
12647 return new MyEnumerator(this);
12650 IEnumerator IEnumerable.GetEnumerator () {
12654 public struct MyEnumerator : IEnumerator {
12659 Before, there were a few things we did wrong:
12660 1) we would emit callvirt on a struct, which is illegal
12661 2) we emited ldarg when we needed to emit ldarga
12662 3) we would mistakenly call the interface methods on an enumerator
12663 type that derived from IEnumerator and was in another assembly. For example:
12665 public class MyEnumerator : IEnumerator
12667 Would have the interface methods called, even if there were public impls of the
12668 method. In a struct, this lead to invalid IL code.
12670 2004-02-11 Marek Safar <marek.safar@seznam.cz>
12672 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
12675 * delegate.cs (Define): Fixed crash when delegate type is undefined.
12677 2004-02-11 Miguel de Icaza <miguel@ximian.com>
12679 * cs-parser.jay: Fix small regression: we were not testing V2
12680 compiler features correctly.
12682 * interface.cs: If the emit context is null, then create one
12684 2004-02-09 Marek Safar <marek.safar@seznam.cz>
12686 * decl.cs (GetSignatureForError): New virtual method to get full name
12687 for error messages.
12689 * attribute.cs (IAttributeSupport): New interface for attribute setting.
12690 Now it is possible to rewrite ApplyAttributes method to be less if/else.
12692 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
12693 Duplicated members and code in these classes has been removed.
12694 Better encapsulation in these classes.
12696 2004-02-07 Miguel de Icaza <miguel@ximian.com>
12698 * assign.cs (Assign.DoResolve): When dealing with compound
12699 assignments, there is a new rule in ECMA C# 2.4 (might have been
12700 there before, but it is documented here) that states that in:
12704 If b is of type int, and the `op' is a shift-operator, then the
12705 above is evaluated as:
12709 * expression.cs (Binary.ResolveOperator): Instead of testing for
12710 int/uint/long/ulong, try to implicitly convert to any of those
12711 types and use that in pointer arithmetic.
12713 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
12714 method to print information for from the type, not from the
12715 null-method we were given.
12717 2004-02-01 Duncan Mak <duncan@ximian.com>
12719 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
12720 parsing for cmd, fixes bug #53694.
12722 2004-02-04 Marek Safar <marek.safar@seznam.cz>
12724 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
12725 in the member name duplication tests. Property and operator name duplication
12726 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
12728 2004-02-03 Marek Safar <marek.safar@seznam.cz>
12730 * interface.cs (PopulateMethod): Fixed crash when interface method
12731 returns not existing type (error test cs0246-3.cs).
12733 2004-02-02 Ravi Pratap M <ravi@ximian.com>
12735 * cs-parser.jay (interface_accessors): Re-write actions to also
12736 store attributes attached to get and set methods. Fix spelling
12739 (inteface_property_declaration): Modify accordingly.
12741 (InterfaceAccessorInfo): New helper class to store information to pass
12742 around between rules that use interface_accessors.
12744 * interface.cs (Emit): Apply attributes on the get and set
12745 accessors of properties and indexers too.
12747 * attribute.cs (ApplyAttributes): Modify accordingly to use the
12748 right MethodBuilder when applying attributes to the get and set accessors.
12750 2004-01-31 Miguel de Icaza <miguel@ximian.com>
12752 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
12754 2004-01-26 Miguel de Icaza <miguel@ximian.com>
12756 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
12758 2004-01-25 Miguel de Icaza <miguel@ximian.com>
12760 * cs-parser.jay: Remove YIELD token, instead use the new grammar
12761 changes that treat `yield' specially when present before `break'
12762 or `return' tokens.
12764 * cs-tokenizer.cs: yield is no longer a keyword.
12766 2004-01-23 Marek Safar <marek.safar@seznam.cz>
12768 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
12769 setting for default constructors.
12770 For default constructors are almost every time set wrong Modifier. The
12771 generated IL code has been alright. But inside mcs this values was
12772 wrong and this was reason why several of my CLS Compliance tests
12775 2004-02-27 Martin Baulig <martin@ximian.com>
12777 * generics.cs (ConstructedType.ResolveType): Make the nested type
12778 stuff actually work.
12780 2004-02-25 Martin Baulig <martin@ximian.com>
12782 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
12783 property; returns the type parameters just from the current type,
12784 ie. with the ones from outer classes.
12785 (DeclSpace.LookupGeneric): First search in the current class, then
12787 (DeclSpace.initialize_type_params): When hiding a type parameter
12788 from an outer class, put it into the `type_param_list' anyways.
12790 * expression.cs (MemberAccess.expr): Made this field protected.
12792 * class.cs (TypeContainer.Define): The `CurrentType' just contains
12793 the type parameters from the current class.
12795 * generic.cs (ConstructedType.ResolveType): Support nested generic
12796 types by taking the type parameters which we inherit from outer
12797 classes into account.
12798 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
12799 support for nested generic types.
12801 2004-02-23 Martin Baulig <martin@ximian.com>
12803 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
12804 field and check whether we're nested inside a generic type.
12805 (DeclSpace.ResolveType): If we're resolving to a generic type
12806 definition, create a ConstructedType and return its resolved type.
12807 (DeclSpace.initialize_type_params): New private method;
12808 initializes the `type_param_list' field from the type parameters
12809 from this and all enclosing classes.
12810 (DeclSpace.TypeParameters): Call initialize_type_params() unless
12811 we're already initialized.
12813 2004-02-23 Martin Baulig <martin@ximian.com>
12815 * class.cs (Method.Define): Create the generic method before
12816 calling DoDefine().
12817 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
12818 the TypeContainer one); we use this for generic methods.
12820 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
12821 parent's TypeBuilder.
12823 2004-02-18 Martin Baulig <martin@ximian.com>
12825 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
12826 to check for equality.
12828 2004-02-05 Martin Baulig <martin@ximian.com>
12830 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
12831 `ec.TypeContainer.CurrentType', use it instead of
12832 `ec.ContainerType' to check whether we're in the type's ctor.
12834 2004-01-29 Martin Baulig <martin@ximian.com>
12836 * expression.cs (Invocation.DoResolve): If we're a
12837 `ConstructedType', then we're actually a generic method, so
12838 rewrite the expr as a GenericMemberAccess.
12840 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
12841 here; manually parse it into a string.
12843 2004-01-28 Martin Baulig <martin@ximian.com>
12845 * typemanager.cs (TypeManager.IsEqual): New static method.
12846 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
12847 check for equality instead of using `=='.
12849 2004-01-26 Martin Baulig <martin@ximian.com>
12851 * decl.cs (DeclSpace.CurrentType): New public field.
12853 * expression.cs (This.ResolveBase): If we have an
12854 `ec.TypeContainer.CurrentType', use it instead of
12855 `ec.ContainerType'.
12857 * class.cs (TypeContainer.DefineType): If we're a generic type,
12858 create the `CurrentType' (unresolved).
12859 (TypeContainer.GenericType): New private field.
12860 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
12861 it and store it in `GenericType' before creating the MemberCache.
12862 (TypeContainer.GetMembers): If we have a `GenericType', call
12863 TypeManager.FindMembers() on it.
12865 * interface.cs (Interface.GenericType): New private field.
12866 (Interface.DefineType): If we're a generic type, create the
12867 `CurrentType' (unresolved).
12868 (Interface.DefineMembers): If we have a `CurrentType', resolve it
12869 and store it in `GenericType' before creating the MemberCache.
12870 (Interface.GetMembers): If we have a `GenericType', call
12871 TypeManager.FindMembers() on it.
12873 2004-01-22 Martin Baulig <martin@ximian.com>
12875 * cs-parser.jay (namespace_or_type_name): Return an Expression,
12876 not a QualifiedIdentifier. This is what `type_name_expression'
12877 was previously doing.
12878 (type_name_expression): Removed; the code is now in
12879 `namespace_or_type_name'.
12880 (qualified_identifier): Removed, use `namespace_or_type_name'
12882 (QualifiedIdentifier): Removed this class.
12884 2004-01-22 Martin Baulig <martin@ximian.com>
12886 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
12887 not a string as alias name.
12889 2004-01-21 Miguel de Icaza <miguel@ximian.com>
12891 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
12892 #52730 bug, and instead compute correctly the need to use a
12893 temporary variable when requesting an address based on the
12894 static/instace modified of the field and the constructor.
12896 2004-01-21 Martin Baulig <martin@ximian.com>
12898 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
12899 class and namespace before looking up aliases. Fixes #52517.
12901 2004-01-21 Martin Baulig <martin@ximian.com>
12903 * flowanalysis.cs (UsageVector.Merge): Allow variables being
12904 assinged in a 'try'; fixes exception4.cs.
12906 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12907 * class.cs : Implemented parameter-less constructor for TypeContainer
12909 * decl.cs: Attributes are now stored here. New property OptAttributes
12911 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
12913 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
12915 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12917 * typemanager.cs (CSharpSignature): Now reports also inner class name.
12918 (CSharpSignature): New method for indexer and property signature.
12920 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12922 * pending.cs (IsVirtualFilter): Faster implementation.
12924 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12926 * typemanager.cs: Avoid inclusion of same assembly more than once.
12928 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12930 * cs-parser.jay: Fixed problem where the last assembly attribute
12931 has been applied also to following declaration (class, struct, etc.)
12933 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12935 * class.cs: Added error CS0538, CS0539 reporting.
12936 Fixed crash on Microsoft runtime when field type is void.
12938 * cs-parser.jay: Added error CS0537 reporting.
12940 * pending.cs: Added error CS0535 reporting.
12941 Improved error report for errors CS0536, CS0534.
12943 2004-01-20 Miguel de Icaza <miguel@ximian.com>
12945 Merge a few bits from the Anonymous Method MCS tree.
12947 * statement.cs (ToplevelBlock): New class for toplevel methods,
12948 will hold anonymous methods, lifted variables.
12950 * cs-parser.jay: Create toplevel blocks for delegates and for
12951 regular blocks of code.
12953 2004-01-20 Martin Baulig <martin@ximian.com>
12955 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
12956 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
12957 and `NeedExplicitReturn'; added `IsLastStatement'.
12958 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
12959 have a `ReturnLabel' or we're not unreachable.
12961 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
12962 child's reachability; don't just override ours with it. Fixes
12963 #58058 (lluis's example).
12964 (FlowBranching): Added public InTryOrCatch(), InCatch(),
12965 InFinally(), InLoop(), InSwitch() and
12966 BreakCrossesTryCatchBoundary() methods.
12968 * statement.cs (Return): Do all error checking in Resolve().
12969 Unless we are the last statement in a top-level block, always
12970 create a return label and jump to it.
12971 (Break, Continue): Do all error checking in Resolve(); also make
12972 sure we aren't leaving a `finally'.
12973 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
12974 statement in a top-level block.
12975 (Block.Flags): Added `IsDestructor'.
12976 (Block.IsDestructor): New public property.
12978 2004-01-20 Martin Baulig <martin@ximian.com>
12980 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
12982 2004-01-20 Martin Baulig <martin@ximian.com>
12984 * statement.cs (Statement.ResolveUnreachable): New public method.
12985 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
12986 (Block.Resolve): Resolve unreachable statements.
12988 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
12990 * expression.cs: We need to fix the case where we do
12991 not have a temp variable here.
12993 * assign.cs: Only expression compound assignments need
12994 temporary variables.
12996 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
12998 * flowanalysis.cs: Reduce memory allocation in a few ways:
12999 - A block with no variables should not allocate a bit
13001 - A method with no out parameters does not need any tracking
13002 for assignment of the parameters, so we need not allocate
13005 public readonly Type[] VariableTypes;
13006 public readonly string[] VariableNames;
13007 Are redundant. The data is already stored in the variable
13008 map, so we need not allocate another array for it.
13009 - We need to add alot of checks for if (params | locals) == null
13010 due to the first two changes.
13012 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13014 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13015 implement IMemoryLocation, we store a copy on a local variable and
13016 take the address of it. Patch from Benjamin Jemlich
13018 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13019 to use a special "type_name_expression" rule which reduces the
13020 number of "QualifiedIdentifier" classes created, and instead
13021 directly creates MemberAccess expressions.
13023 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13025 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13026 that fixes #52853. Null literal assignment to ValueType
13028 * class.cs (MethodData.Emit): Instead of checking the name of the
13029 method to determine if its a destructor, create a new derived
13030 class from Method called Destructor, and test for that.
13032 * cs-parser.jay: Create a Destructor object instead of a Method.
13034 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13038 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13040 * expression.cs (Binary.ResolveOperator): Perform an implicit
13041 conversion from MethodGroups to their delegate types on the
13042 Addition operation.
13044 * delegate.cs: Introduce a new class DelegateCreation that is the
13045 base class for `NewDelegate' and `ImplicitDelegateCreation',
13046 factor some code in here.
13048 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13049 conversion from MethodGroups to compatible delegate types.
13051 * ecore.cs (Expression.Resolve): Do not flag error 654
13052 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13053 we allow conversions from MethodGroups to delegate types now.
13055 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13056 assignments in v2 either.
13058 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13060 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13061 static read-only fields in ctors.
13063 Applied patch from Benjamin Jemlich
13065 * expression.cs (UnaryMutator): Avoid leaking local variables.
13067 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13069 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13070 here to return true, as they can be used like this:
13072 (XXX) int.MEMBER ()
13074 Fixed 49836 and all the other dups
13076 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13078 * driver.cs: Implement /win32res and /win32icon.
13080 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13082 * cs-parser.jay: Add a rule to improve error handling for the
13083 common mistake of placing modifiers after the type.
13085 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13087 * cs-parser.jay (interface_event_declaration): Catch
13088 initialization of events on interfaces, and report cs0068
13090 * cs-parser.jay (interface_event_declaration): Catch
13091 initialization of events.
13093 * ecore.cs: Better report missing constructors.
13095 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13096 the error reporting done in the wrong place. Fix.
13098 * expression.cs (Binary.ResolveOperator): Catch the
13099 operator + (E x, E y) error earlier, and later allow for implicit
13100 conversions in operator +/- (E e, U x) from U to the underlying
13103 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13104 52596, if the container class is abstract, the default constructor
13105 is protected otherwise its public (before, we were always public).
13107 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13110 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13111 Jemlich that fixes bug #52597, MCS was generating invalid code for
13112 idisposable structs. Thanks to Ben for following up with this
13115 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13117 * driver.cs: Allow assemblies without code to be generated, fixes
13120 2004-01-07 Nick Drochak <ndrochak@gol.com>
13122 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13124 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13126 * cs-parser.jay: Add rules to improve error reporting if fields or
13127 methods are declared at the namespace level (error 116)
13129 * Add rules to catch event add/remove
13131 2004-01-04 David Sheldon <dave-mono@earth.li>
13133 * expression.cs: Added matching ")" to error message for
13136 2004-01-03 Todd Berman <tberman@gentoo.org>
13138 * ecore.cs, attribute.cs:
13139 Applying fix from #52429.
13141 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13143 * ecore.cs, expression.cs, statement.cs:
13144 Total rewrite of how we handle branching. We
13145 now handle complex boolean expressions with fewer
13146 jumps. As well if (x == 0) no longer emits a ceq.
13148 if (x is Foo) is much faster now, because we generate
13151 Overall, we get a pretty big improvement on our benchmark
13152 tests. The code we generate is smaller and more readable.
13154 I did a full two-stage bootstrap. The patch was reviewed
13155 by Martin and Miguel.
13157 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13159 * cs-parser.jay: Make primary_expression not take a QI.
13160 we dont need this because the member_access rule covers
13161 us here. So we replace the rule with just IDENTIFIER.
13163 This has two good effects. First, we remove a s/r conflict.
13164 Second, we allocate many fewer QualifiedIdentifier objects.
13166 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13168 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13169 set the correct information via SRE. This prevents
13170 hanging on the MS runtime. Fixes #29374.
13172 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13174 * convert.cs: correctly handle conversions to value types
13175 from Enum and ValueType as unboxing conversions.
13177 Fixes bug #52569. Patch by Benjamin Jemlich.
13179 2004-01-02 Ravi Pratap <ravi@ximian.com>
13181 * expression.cs (BetterConversion): Prefer int -> uint
13182 over int -> ulong (csc's behaviour). This fixed bug #52046.
13184 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13186 * decl.cs (MemberCache.FindMembers): now returns a
13189 * typemanager.cs: In general, go with with ^^.
13190 (CopyNewMethods): take an IList.
13191 (RealMemberLookup): Only allocate an arraylist
13192 if we copy from two sets of methods.
13194 This change basically does two things:
13195 1) Fewer array lists allocated due to CopyNewMethods.
13196 2) the explicit cast in MemberList costed ALOT.
13198 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13200 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13201 a hashtable to avoid needless string allocations when an identifier is
13202 used more than once (the common case).
13204 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13206 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13207 is broken, it will not return anything. So, we
13208 have to use the information we have in mcs to
13211 * typemanager.cs: Add a cache for GetInterfaces,
13212 since this will now be used more often (due to ^^)
13214 (GetExplicitInterfaces) New method that gets the
13215 declared, not effective, interfaces on a type
13216 builder (eg, if you have interface IFoo, interface
13217 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13220 This patch makes MCS able to bootstrap itself on
13223 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13225 * expression.cs: Remove the Nop's that Miguel put
13228 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13230 * report.cs, codegen.cs: Give the real stack trace to
13231 the error when an exception is thrown.
13233 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13235 * decl.cs: only allocate hashtables for ifaces if
13238 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13240 * expression.cs: fix the error from cs0121-2.cs
13241 (a parent interface has two child interfaces that
13242 have a function with the same name and 0 params
13243 and the function is called through the parent).
13245 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13247 * class.cs, rootcontext.cs, typmanager.cs: do not
13250 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13252 * codegen.cs: remove stack for the ec flow branching.
13253 It is already a linked list, so no need.
13255 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13257 * Makefile: Allow custom profiler here.
13259 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13261 * typemanager.cs (LookupType):
13262 - Use a static char [], because split takes
13263 a param array for args, so it was allocating
13265 - Do not store true in a hashtable, it boxes.
13267 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13269 * flowanalysis.cs: bytify common enums.
13271 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13273 * modifiers.cs: Add a new set of flags for the
13274 flags allowed on explicit interface impls.
13275 * cs-parser.jay: catch the use of modifiers in
13276 interfaces correctly.
13277 * class.cs: catch private void IFoo.Blah ().
13279 All related to bug #50572.
13281 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13283 * decl.cs: Rewrite the consistant accessability checking.
13284 Accessability is not linear, it must be implemented in
13285 a tableish way. Fixes #49704.
13287 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13289 * expression.cs: Handle negation in a checked context.
13290 We must use subtraction from zero. Fixes #38674.
13292 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13294 * class.cs: Ignore static void main in DLLs.
13295 * rootcontext.cs: Handle the target type here,
13296 since we are have to access it from class.cs
13297 * driver.cs: account for the above.
13299 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13301 * report.cs: Give line numbers and files if available.
13303 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13305 * driver.cs: Implement /addmodule.
13307 * typemanager.cs: Change 'modules' field so it now contains Modules not
13310 2003-12-20 Martin Baulig <martin@ximian.com>
13312 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13313 (FieldBase.IsAssigned): Removed this field.
13314 (FieldBase.SetAssigned): New public method.
13315 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13317 2003-12-20 Martin Baulig <martin@ximian.com>
13319 * expression.cs (LocalVariableReference.DoResolve): Don't set
13320 `vi.Used' if we're called from DoResolveLValue().
13322 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13323 returns the usage vector it just merged into the current one -
13324 pass this one to UsageWarning().
13325 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13326 of the `EmitContext', don't call this recursively on our children.
13328 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13330 * driver.cs: Implement /target:module.
13332 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13334 * support.cs (CharArrayHashtable): New helper class.
13336 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13337 char arrays, not strings, so we can avoid creating a string in
13338 consume_identifier if the identifier is a keyword.
13340 2003-12-16 Martin Baulig <martin@ximian.com>
13342 * statement.cs (LocalInfo.Assigned): Removed this property.
13343 (LocalInfo.Flags): Removed `Assigned'.
13344 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13345 and uses flow analysis.
13346 (Block.UsageWarning): Made this method private.
13347 (Block.Resolve): Call UsageWarning() if appropriate.
13349 * expression.cs (LocalVariableReference.DoResolve): Always set
13350 LocalInfo.Used here.
13352 2003-12-13 Martin Baulig <martin@ximian.com>
13354 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13355 any value here; we're now using flow analysis to figure out
13356 whether a statement/block returns a value.
13358 2003-12-13 Martin Baulig <martin@ximian.com>
13360 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13362 (FlowBranching.MergeFinally): Don't call
13363 `branching.CheckOutParameters()' here, this is called in
13365 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13366 when adding the `finally' vector.
13368 2003-12-13 Martin Baulig <martin@ximian.com>
13371 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13372 actually work and also fix #48962.
13374 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13376 * decl.cs: Do not check System.Object for nested types,
13377 since we know it does not have any. Big bang for buck:
13380 Run 1: 8.35 seconds
13381 Run 2: 8.32 seconds
13382 corlib: 17.99 seconds
13384 Run 1: 8.17 seconds
13385 Run 2: 8.17 seconds
13386 corlib: 17.39 seconds
13388 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13390 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13391 time we are returning 0 members, so we save alot here.
13393 2003-12-11 Martin Baulig <martin@ximian.com>
13395 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13396 `MergeChild()', also just take the `FlowBranching' as argument;
13397 call Merge() on it and return the result.
13398 (FlowBranching.Merge): We don't need to do anything if we just
13401 2003-12-11 Martin Baulig <martin@ximian.com>
13403 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13404 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13405 Maurer for this idea.
13407 2003-12-11 Martin Baulig <martin@ximian.com>
13409 * flowanalysis.cs (MergeResult): This class is now gone; we now
13410 use the `UsageVector' for this. The reason for this is that if a
13411 branching just has one sibling, we don't need to "merge" them at
13412 all - that's the next step to do.
13413 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13416 2003-12-11 Martin Baulig <martin@ximian.com>
13418 Reworked flow analyis and made it more precise and bug-free. The
13419 most important change is that we're now using a special `Reachability'
13420 class instead of having "magic" meanings of `FlowReturns'. I'll
13421 do some more cleanups and optimizations and also add some more
13422 documentation this week.
13424 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13425 largely reworked this class.
13426 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13427 the new `Reachability' class instead of having "magic" values here.
13428 (FlowBranching): We're now using an instance of `Reachability'
13429 instead of having separate `Returns', `Breaks' etc. fields.
13431 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13432 based on flow analysis; ignore the return value of block.Emit ().
13434 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13436 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13437 if they are private.
13439 2003-12-09 Martin Baulig <martin@ximian.com>
13441 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13442 call them directly on the UsageVector.
13444 2003-12-09 Martin Baulig <martin@ximian.com>
13446 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13447 Changed return type from `FlowReturns' to `Reachability'.
13449 2003-12-09 Martin Baulig <martin@ximian.com>
13451 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13452 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13453 `Reachable' fields with a single `Reachability' one.
13455 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13457 * class.cs (FindMembers): Remove foreach's.
13462 Run 1: 8.74 seconds
13463 Run 2: 8.71 seconds
13466 Run 1: 8.64 seconds
13467 Run 2: 8.58 seconds
13470 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13475 This patch does a few things:
13476 1. EmptyStatement is now a singleton, so it is never reallocated.
13477 2. All blah is EmptyStatement constructs have been changed to
13478 blah == EmptyStatement.Value, which is much faster and valid
13479 now that EmptyStatement is a singleton.
13480 3. When resolving a block, rather than allocating a new array for
13481 the non-empty statements, empty statements are replaced with
13482 EmptyStatement.Value
13483 4. Some recursive functions have been made non-recursive.
13484 Mainly the performance impact is from (3), however (1) and (2) are needed for
13485 this to work. (4) does not make a big difference in normal situations, however
13486 it makes the profile look saner.
13491 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13492 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13493 Total memory allocated: 56397 KB
13496 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13497 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13498 Total memory allocated: 55666 KB
13500 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13502 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13503 than the hashtable in a hashtable version
13505 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13506 we always end up concating a string. This results in a huge perf
13507 loss, because many strings have to be tracked by the GC. In this
13508 patch, we first use a hashtable that works with two keys, so that
13509 the strings do not need to be concat'ed.
13513 Run 1: 8.74 seconds
13514 Run 2: 8.71 seconds
13517 Run 1: 8.65 seconds
13518 Run 2: 8.56 seconds
13520 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13522 * Makefile: Add a new target `do-time' that does a quick and simple
13523 profile, leaving easy to parse output.
13525 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13527 * codegen.cs (Init): Create the dynamic assembly with
13528 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13530 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13532 * support.cs: Make the PtrHashtable use only one
13533 instance of its comparer.
13535 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13537 * typemanager.cs: Fix lookup of GetNamespaces.
13539 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13541 * expression.cs: Removed redundant line.
13543 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13544 ArrayLists, use for loops with bounds.
13546 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13549 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13550 arraylists, use for loop with bounds.
13552 The above three changes give us a 0.071 second performance
13553 improvement out of 3.294 seconds down to 3.223. On my machine
13554 the above changes reduced the memory usage by 1,387 KB during
13555 compiler bootstrap.
13557 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13558 QualifiedIdentifiers. Before we created a new string through
13559 concatenation, and mostly later on, the result would be
13560 manipulated by DecomposeQI through string manipulation.
13562 This reduced the compiler memory usage for bootstrapping from
13563 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13564 compile times in 0.05 seconds.
13566 2003-11-28 Dick Porter <dick@ximian.com>
13568 * support.cs: Do string compares with the Invariant culture.
13576 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13577 the comparison is done with the Invariant culture.
13579 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13581 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13582 GetEnumerator method.
13584 (ProbeCollectionType): Iterate starting at the most specific type
13585 upwards looking for a GetEnumerator
13587 * expression.cs: Shift count can be up to 31 for int/uint and 63
13590 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13592 * statement.cs (Block.LookupLabel): Also look for the label on the
13593 children blocks. Use a hash table to keep track of visited
13596 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13597 we actually did transform the other operand, otherwise fall back
13598 to the common codepath that casts to long.
13600 * cs-tokenizer.cs: Use the same code pattern as the int case.
13601 Maybe I should do the parsing myself, and avoid depending on the
13602 Parse routines to get this done.
13604 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13606 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13607 which fixes bug 51347. This time test it.
13609 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13610 attributes for example can not tell the difference between these.
13611 The difference was only a syntax feature of the language.
13613 * attribute.cs: Apply attributes to delegates.
13615 * delegate.cs: Call the apply attributes method.
13617 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13619 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13620 comparing 0 vs Byte.MinValue, not the value
13622 (ImplicitConversionRequired): When reporting a conversion error,
13623 use error 31 to print out the constant error instead of the
13626 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13627 which fixes bug 51347.
13629 2003-11-22 Miguel de Icaza <miguel@ximian.com>
13631 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
13632 which fixes the -warnaserror command line option.
13634 2003-11-21 Miguel de Icaza <miguel@ximian.com>
13636 * cfold.cs (DoNumericPromotions): During constant folding of
13637 additions on UIntConstant, special case intconstants with
13638 IntConstants like we do on the expression binary operator.
13640 2003-11-12 Miguel de Icaza <miguel@ximian.com>
13642 * convert.cs (ImplicitReferenceConversion): We were missing a case
13643 (System.Enum are not value types or class types, so we need to
13644 classify them separatedly).
13646 * driver.cs: We do not support error 2007.
13648 2003-11-12 Jackson Harper <jackson@ximian.com>
13650 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
13651 system directory. Also use the full file name so users can
13652 libraries names mscorlib-o-tron.dll in a non system dir.
13654 2004-01-04 David Sheldon <dave-mono@earth.li>
13656 * expression.cs: Added matching ")" to error message for CS0077.
13658 2003-12-19 Martin Baulig <martin@ximian.com>
13660 * typemanager.cs (TypeManager.IsEqualGenericType): New public
13661 static method; see documentation in the method.
13662 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
13664 * convert.cs (Convert.ImplicitReferenceConversion,
13665 Convert.ImplicitReferenceConversionExists): Add support for
13666 generic type declarations; see gen-36.cs.
13668 2003-12-19 Martin Baulig <martin@ximian.com>
13670 * pending.cs (Pending.InterfaceMethod): Use
13671 `Type.IsAssignableFrom()' instead of `=='.
13673 2003-12-18 Martin Baulig <martin@ximian.com>
13675 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
13678 * convert.cs (Convert.ImplicitStandardConversionExists): Use
13679 `expr_type.Equals (target_type)' instead of `=='.
13681 2003-12-08 Martin Baulig <martin@ximian.com>
13683 * generics.cs (Constraints.Types): Removed.
13684 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
13686 (Constraints.ResolveTypes): New public method; resolves the
13687 TypeExpr's to Type's.
13688 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
13689 longer takes the constraints.
13690 (TypeParameter.DefineMethod): Likewise.
13691 (TypeParameter.DefineType): New public method. Calls
13692 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
13695 2003-12-08 Martin Baulig <martin@ximian.com>
13697 * convert.cs (Convert.ImplicitConversionStandard): Use
13698 `expr_type.Equals (target_type)' instead of `=='.
13700 2003-12-08 Martin Baulig <martin@ximian.com>
13702 * typemanager.cs (TypeManager.GetReferenceType): Call
13703 `Type.MakeByRefType ()'.
13705 2003-12-08 Martin Baulig <martin@ximian.com>
13707 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
13708 just has some special meaning in some situations. For instance,
13709 it is allowed to use `where' as the name of a variable etc.
13711 2003-12-04 Martin Baulig <martin@ximian.com>
13713 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13714 `Type.MakeArrayType()' for array types.
13716 2003-11-18 Miguel de Icaza <miguel@ximian.com>
13718 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
13721 (SizeOf.DoResolve): assign the `type_queried' field. This gets
13724 2003-11-16 Martin Baulig <martin@ximian.com>
13726 * codegen.cs (EmitContext.IsGeneric): Removed.
13728 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
13729 ResolveGeneric() on the DeclSpace.
13731 2003-11-16 Martin Baulig <martin@ximian.com>
13733 * generic.cs (TypeArguments.Resolve):
13734 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
13735 `ResolveType()' on it to get the Type.
13737 2003-11-15 Martin Baulig <martin@ximian.com>
13739 * generic.cs (ConstructedType.GetInterfaces): Override this.
13741 2003-11-14 Martin Baulig <martin@ximian.com>
13743 * interface.cs (Interface.DefineType): Define all type parameters
13744 before adding the interfaces we inherit.
13746 2003-11-11 Martin Baulig <martin@ximian.com>
13748 * generic.cs (ConstructedType.ResolveType): Always call
13749 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
13751 2003-11-10 Martin Baulig <martin@ximian.com>
13753 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
13754 (TypeManager.InitCoreTypes): Initialize them here, but instead of
13755 calling `ResolveType()' on them, directly assign their `Type'.
13757 2003-11-08 Martin Baulig <martin@ximian.com>
13759 * generic.cs (ConstructedType): Override `IsClass' etc.
13761 2003-11-08 Martin Baulig <martin@ximian.com>
13763 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
13764 return value and the `out parent' parameter.
13765 (TypeContainer.DefineType): Moved the CS0644 check into
13766 GetClassBases(). Don't pass the interface types to the
13767 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
13768 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
13770 * ecore.cs (TypeExpr.IsAttribute): New property.
13771 (TypeExpr.GetInterfaces): New method.
13773 * interface.cs (Interface.GetInterfaceTypeByName): Return a
13774 TypeExpr instead of a Type.
13775 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
13776 (Interface.DefineType): Don't pass the interface types to the
13777 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
13778 them later and then call `TypeBulider.AddInterfaceImplementation()'.
13780 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
13781 instead of a `Type[]'.
13782 (TypeManager.RegisterBuilder): Likewise.
13783 (TypeManager.AddUserInterface): Likewise.
13784 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
13785 `Type[]' and also return a `TypeExpr[]'.
13786 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
13788 2003-11-08 Martin Baulig <martin@ximian.com>
13790 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
13793 2003-11-08 Martin Baulig <martin@ximian.com>
13795 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
13796 TypeManager.ResolveExpressionTypes().
13798 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
13799 instead of an Expression.
13800 (TypeExpr): This is now an abstract base class for `TypeExpression'.
13801 (TypeExpression): New public class; formerly known as `TypeExpr'.
13803 * expression.cs (ComposedCast): Derive from TypeExpr.
13805 * typemanager.cs (TypeManager.system_*_expr): These are now
13806 TypExpr's instead of Expression's.
13807 (TypeManager.ResolveExpressionTypes): New public static function;
13808 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
13811 2003-11-06 Miguel de Icaza <miguel@ximian.com>
13813 * expression.cs (New.DoResolve): Do not dereference value that
13814 might be a null return.
13816 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
13817 sure that the constant value has the right type. Fixes an
13818 unreported bug, similar to 50425.
13820 * const.cs (Const.LookupConstantValue): Call
13821 ImplicitStandardConversionExists before doing a conversion to
13822 avoid havng the TypeManager.ChangeType do conversions.
13824 Reduced the number of casts used
13826 (Const.ChangeType): New routine to enable reuse of the constant
13827 type changing code from statement.
13829 * typemanager.cs (ChangeType): Move common initialization to
13830 static global variables.
13834 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
13835 every value type to go through, even if it was void. Fix that.
13837 * cs-tokenizer.cs: Use is_identifier_start_character on the start
13838 character of the define, and the is_identifier_part_character for
13839 the rest of the string.
13841 2003-11-05 Miguel de Icaza <miguel@ximian.com>
13843 * expression.cs (UnaryMutator.EmitCode): When I updated
13844 LocalVariableReference.DoResolve, I overdid it, and dropped an
13845 optimization done on local variable references.
13847 2003-11-04 Miguel de Icaza <miguel@ximian.com>
13849 * ecore.cs: Convert the return from Ldlen into an int.
13851 2003-10-20 Miguel de Icaza <miguel@ximian.com>
13853 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
13854 the accessibility, this is a special case for toplevel non-public
13855 classes (internal for instance).
13857 2003-10-20 Nick Drochak <ndrochak@gol.com>
13859 * ecore.cs: Fix typo and build. Needed another right paren.
13861 2003-10-19 Miguel de Icaza <miguel@ximian.com>
13863 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
13864 `internal' case regular and protected, but not allowing protected
13865 to be evaluated later. Bug 49840
13867 2003-10-15 Miguel de Icaza <miguel@ximian.com>
13869 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
13870 to kb.Nlast, and not the kb.nFirst to isolate the switch
13873 Extract the underlying type, so enumerations of long/ulong are
13874 treated like long/ulong.
13876 2003-10-14 Miguel de Icaza <miguel@ximian.com>
13878 * expression.cs (New): Overload the meaning of RequestedType to
13879 track the possible creation of the NewDelegate type, since
13880 DoResolve is invoked more than once for new constructors on field
13883 See bugs: #48800 and #37014
13885 * cs-parser.jay (declare_local_constants): Take an arraylist
13886 instead of a single constant.
13888 (local_constant_declaration): It should take a
13889 constant_declarators, not a constant_declarator. Fixes 49487
13891 * convert.cs: Fix error report.
13893 2003-10-13 Jackson Harper <jackson@ximian.com>
13895 * typemanager.cs (TypeToCoreType): Add float and double this fixes
13898 2003-11-03 Martin Baulig <martin@ximian.com>
13900 * expression.cs (ArrayAccess.GetStoreOpcode): Added
13901 `out bool has_type_arg'; if set, we need to pass the type to
13903 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
13904 Stelem_Any/Ldelem_Any for generic parameters.
13906 2003-11-02 Martin Baulig <martin@ximian.com>
13908 * expression.cs (Invocation.EmitCall): Use
13909 `TypeManager.IsValueType()' to check whether it's a value type.
13910 Don't set `struct_call' when calling a method on a type parameter.
13912 2003-11-02 Martin Baulig <martin@ximian.com>
13914 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
13915 and removed the TypeBuilder argument.
13917 * typemanager.cs (TypeManager.IsValueType): Return
13918 `t.IsGenericParameter || t.IsValueType'.
13920 2003-10-25 Martin Baulig <martin@ximian.com>
13922 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
13923 call ConstructedType.Resolve() on it.
13925 * generic.cs (ConstructedType.Resolve): Set `type' on success.
13927 2003-10-25 Martin Baulig <martin@ximian.com>
13929 * class.cs (TypeContainer.GetClassBases): Changed
13930 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
13931 CS8214 reporting here.
13932 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
13933 instead of a `Type' for our parent. In case of a recursive
13934 declaration (see tests/gen-23.cs for an example), our parent is a
13935 ConstructedType and it doesn't have its type set. So, first
13936 create our own TypeBuilder, then call constructed.Resolve() to get
13937 the parent's type and finally TypeBuilder.SetParent() it.
13939 * ecore.cs (TypeExpr.Name): New public virtual property.
13942 (ConstructedType): We're now a TypeExpr and not just an Expression.
13943 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
13944 arguments here; this is done later.
13945 (ConstructedType.Resolve): New public method to resolve the type
13946 arguments and bind them.
13948 2003-10-21 Martin Baulig <martin@ximian.com>
13950 * convert.cs: Use `TypeManager.IsValueType' instead of
13951 'type.IsValueType' everywhere.
13953 * typemanager.cs (TypeManager.IsValueType): Return true for type
13954 parameters. The reason for this is that we need to box a type
13955 parameter when converting it to a reference type.
13957 * cs-parser.jay: Added support for default value expressions.
13959 * generics.cs (DefaultValueExpression): New public class.
13961 2003-10-17 Martin Baulig <martin@ximian.com>
13963 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
13964 TypeContainer so we can also use this for Interfaces.
13965 (TypeParameter.Resolve): Likewise.
13967 * interface.cs (Interface.DefineType): Added support for generic
13970 * cs-parser.jay: Added support for generic structs and interfaces.
13972 2003-10-17 Martin Baulig <martin@ximian.com>
13974 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
13975 call generic methods :-)
13977 2003-10-16 Martin Baulig <martin@ximian.com>
13979 * cs-parser.jay (namespace_or_type_name): Only create a
13980 GenericMemberAccess if we actually have type arguments.
13982 2003-10-13 Martin Baulig <martin@ximian.com>
13984 * class.cs (Method.Define): If we're a generic method, call
13985 TypeBuilder.DefineGenericMethod () before resolving
13987 (MethodData): Added .ctor which takes an additional MethodBuilder
13988 argument; this is used for generic methods.
13989 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
13990 we already have a MethodBuilder.
13992 2003-10-10 Martin Baulig <martin@ximian.com>
13994 * class.cs (Method): Added .ctor which takes a `GenericMethod'
13995 instead of a `DeclSpace'. This is used for generic methods.
13997 * cs-parser.jay (method_header): Added support for generic
13998 methods; create a `GenericMethod' instance and pass it to the
13999 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
14000 parameters and locals.
14002 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
14003 since we already have the location. Check whether we're a generic
14004 type declaration or a generic method and create the correct type
14007 * generic.cs (TypeParameter.DefineMethod): New public method.
14008 (GenericMethod): New public class; derives from DeclSpace and is
14009 used for generic methods.
14011 2003-10-09 Martin Baulig <martin@ximian.com>
14013 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14015 (MethodCore.DoDefineParameters): Removed the TypeContainer
14016 argument; use the DeclSpace which was passed to the .ctor instead.
14017 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14018 TypeContainer; we only need a DeclSpace here.
14020 2003-10-09 Martin Baulig <martin@ximian.com>
14022 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14024 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14025 EmitContext's .ctor.
14027 2003-10-09 Martin Baulig <martin@ximian.com>
14029 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14030 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14031 AsAccessible(), moved them as well.
14033 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14035 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14037 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14038 generation for >=, as spotted by Paolo, bug 48679.
14039 Patch from David Waite.
14041 * cs-tokenizer.cs: Add handling for #pragma.
14043 * cs-parser.jay: Allow for both yield and yield return in the
14044 syntax. The anti-cobolization of C# fight will go on!
14046 * class.cs (TypeBuilder.DefineType): Catch error condition here
14047 (Parent.DefineType erroring out and returning null).
14049 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14050 coping with enumerations variables, we were mistakenly processing
14051 them as a regular value type instead of built-in types. Fixes the
14054 * typemanager.cs (IsBuiltinOrEnum): New method.
14056 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14058 * cs-parser.jay: Upgrade: yield now needs the return clause.
14060 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14062 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14064 2003-09-29 Martin Baulig <martin@ximian.com>
14066 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14067 inflated generic methods.
14069 * generics.cs (ConstructedType): Distinguish between open and
14070 closed constructed types; correctly resolve the arguments.
14072 2003-09-22 Martin Baulig <martin@ximian.com>
14074 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14075 all type arguments meet their constraints.
14077 2003-09-19 Martin Baulig <martin@ximian.com>
14079 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14080 `MemberCache parent' argument. Normally, an interface doesn't
14081 have a parent type except System.Object, but we use this in gmcs
14082 for generic type parameters.
14084 2003-09-18 Martin Baulig <martin@ximian.com>
14086 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14087 on `type.IsInterface'; don't check whether the type has a parent
14088 to determine whether it's an interface.
14090 2003-09-17 Martin Baulig <martin@ximian.com>
14092 * generic.cs (ConstructedType.ToString): Always use `name' as the
14095 2003-09-15 Martin Baulig <martin@ximian.com>
14097 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14099 * generic.cs (Constraints.Resolve): New public method; this is
14100 called to resolve the constraint types and to check whether all
14101 the constraints are correct.
14102 (Constraints.Types): New public property.
14103 (TypeParameter.Resolve): New public method; resolves all the
14104 type's constraints.
14106 * class.cs (TypeContainer.DefineType): Call
14107 TypeParameter.Resolve() before actually defining the type.
14109 2003-09-15 Martin Baulig <martin@ximian.com>
14111 * class.cs (TypeContainer.DefineType): Added an error flag to
14112 avoid reporting duplicate CS0146's ("class definition is
14115 * driver.cs (Driver.MainDriver): Abort if
14116 RootContext.ResolveTree() reported any errors.
14118 2003-09-07 Martin Baulig <martin@ximian.com>
14120 * report.cs (Error, Warning): Added overloaded versions which take
14121 a `params object[] args' and call String.Format().
14123 2003-09-07 Martin Baulig <martin@ximian.com>
14125 * decl.cs (DeclSpace..ctor): Don't call
14126 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14127 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14128 (DeclSpace.RecordDecl): New method.
14130 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14132 2003-09-02 Ravi Pratap <ravi@ximian.com>
14134 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14135 value attributes to be applied to ParameterBuilders.
14137 * class.cs (MethodCore.LabelParameters): Make static and more
14138 generic so that it can be used from other places - like interface
14139 methods, for instance.
14141 * interface.cs (Interface.Emit): Call LabelParameters before
14142 emitting attributes on the InterfaceMethod.
14144 2003-09-07 Martin Baulig <martin@ximian.com>
14146 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14147 if the number of type parameters doesn't match.
14149 2003-09-04 Martin Baulig <martin@ximian.com>
14151 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14152 for arrays of generic type params (ie. `!0[]').
14154 2003-09-04 Martin Baulig <martin@ximian.com>
14156 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14159 2003-09-04 Martin Baulig <martin@ximian.com>
14161 * decl.cs (DeclSpace.LookupGeneric): New method.
14162 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14165 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14166 argument, not just a string.
14167 (TypeParameter.Define): New public method; this is called to
14168 actually define the generic parameter; after this, you can use the
14169 new `Type' property to get the type.
14171 2003-09-04 Martin Baulig <martin@ximian.com>
14173 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14174 is now an ArrayList; initialize the result of the `TypeParameters'
14176 (DeclSpace.GetGenericData): Removed.
14177 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14178 implement this in a different way.
14179 (DeclSpace.GetTypeParameters): Removed; there's now a
14180 `TypeParameters' property.
14181 (DeclSpace.TypeParameters): New public property.
14183 * generic.cs (Constraints): Make this class public.
14184 (TypeParameter): New public class.
14186 2003-09-04 Martin Baulig <martin@ximian.com>
14188 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14189 generic parameters.
14191 * class.cs (TypeContainer.DefineType): Call
14192 TypeBuilder.DefineGenericParameter () on all generic parameters if
14193 this is a generic type.
14195 2003-08-28 Martin Baulig <martin@ximian.com>
14197 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14200 * sample-hello.cs: Compile this with gmcs: "gmcs
14201 /r:sample-stack.dll sample-hello.cs".
14203 2003-08-28 Martin Baulig <martin@ximian.com>
14205 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14206 the parameters to the generic type.
14208 2003-08-28 Martin Baulig <martin@ximian.com>
14210 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14212 2003-08-28 Martin Baulig <martin@ximian.com>
14214 * cs-parser.jay (opt_type_argument_list): Use
14215 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14216 (primary_expression): Replace `qualified_identifier' with `type_name'.
14217 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14219 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14220 parser to check whether it is syntactically a type parameter list;
14221 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14224 2003-08-26 Martin Baulig <martin@ximian.com>
14226 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14227 resolving aliases; fixes #47927.
14229 2003-08-26 Martin Baulig <martin@ximian.com>
14231 * statement.cs (Using.DoResolve): This is internally emitting a
14232 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14233 do not always return. Fixes #47681.
14235 2003-08-26 Martin Baulig <martin@ximian.com>
14237 * decl.cs (MemberCore): Moved WarningNotHiding(),
14238 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14240 (AdditionResult): Make this nested in DeclSpace.
14241 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14242 argument; call NamespaceEntry.Define() unless we're nested in a
14245 * namespace.cs (Namespace.DefineName): New public function. This
14246 is called from DeclSpace's .ctor to add
14247 (Namespace.Lookup): Include DeclSpaces in the lookup.
14249 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14251 * const.cs (Const): Derive from MemberBase, not MemberCore.
14253 2003-08-25 Martin Baulig <martin@ximian.com>
14255 * convert.cs (Convert.ExplicitReferenceConversion): When
14256 converting from an interface type to a class, unbox if the target
14257 type is a struct type. Fixes #47822.
14259 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14261 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14264 2003-08-22 Martin Baulig <martin@ximian.com>
14266 * class.cs (TypeManager.DefineType): When defining a nested type,
14267 call DefineType() on our parent; fixes #47801.
14269 2003-08-22 Martin Baulig <martin@ximian.com>
14271 * class.cs (MethodData.Define): While checking if a method is an
14272 interface implementation, improve the test a bit more to fix #47654.
14274 2003-08-22 Martin Baulig <martin@ximian.com>
14276 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14277 correctly; fixes #47722.
14279 2003-08-22 Martin Baulig <martin@ximian.com>
14281 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14282 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14284 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14286 2003-08-22 Martin Baulig <martin@ximian.com>
14288 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14289 can only be assigned in static constructors. Fixes #47161.
14291 2003-08-22 Martin Baulig <martin@ximian.com>
14293 Rewrote and improved the flow analysis code.
14295 * flowbranching.cs (FlowBranching): Make this class abstract.
14296 (FlowBranching.CreateBranching): New static function to create a
14297 new flow branching.
14298 (FlowBranchingBlock, FlowBranchingException): New classes.
14299 (FlowBranching.UsageVector.Type): New public readonly field.
14300 (FlowBranching.UsageVector.Breaks): Removed the setter.
14301 (FlowBranching.UsageVector.Returns): Removed the setter.
14302 (FlowBranching.UsageVector): Added Break(), Return(),
14303 NeverReachable() and Throw() methods to modify the reachability.
14304 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14305 done by FlowBranching.Merge().
14306 (FlowBranching.UsageVector.MergeChild): New method; merges the
14307 merge result into the current vector.
14308 (FlowBranching.Merge): New abstract method to merge a branching.
14310 2003-08-12 Martin Baulig <martin@ximian.com>
14312 * expression.cs (Indirection.CacheTemporaries): Create the
14313 LocalTemporary with the pointer type, not its element type.
14315 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14317 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14318 token was a keyword or not.
14320 Add `error' options where an IDENTIFIER was expected; Provide
14321 CheckToken and CheckIdentifierToken convenience error reporting
14324 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14326 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14327 NameSpaceEntry NameSpaceEntry.
14329 (LookupInterfaceOrClass): Avoid creating a full qualified name
14330 from namespace and name: avoid doing lookups when we know the
14331 namespace is non-existant. Use new Tree.LookupByNamespace which
14332 looks up DeclSpaces based on their namespace, name pair.
14334 * driver.cs: Provide a new `parser verbose' to display the
14335 exception thrown during parsing. This is turned off by default
14336 now, so the output of a failure from mcs is more graceful.
14338 * namespace.cs: Track all the namespaces defined in a hashtable
14341 (IsNamespace): New method
14343 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14345 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14346 we know that we need to concatenate (full typename can never be
14351 * statement.cs: Use a bitfield; Do not initialize to null things
14352 which are done by the constructor by default.
14354 * cs-parser.jay: bug fix, parameter was 4, not 3.
14356 * expression.cs: Just use the property;
14358 * statement.cs: No need for GetVariableInfo method.
14360 2003-08-08 Martin Baulig <martin@ximian.com>
14362 * flowanalysis.cs (FlowReturns): This is now nested in the
14363 `FlowBranching' class.
14364 (MyBitVector): Moved this here from statement.cs.
14365 (FlowBranching.SiblingType): New enum type.
14366 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14368 2003-08-07 Martin Baulig <martin@ximian.com>
14370 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14371 `FlowBranching' class and called `BranchingType'.
14373 2003-08-07 Martin Baulig <martin@ximian.com>
14375 * flowanalysis.cs: Moved all the control flow analysis code into
14378 2003-08-07 Martin Baulig <martin@ximian.com>
14380 * assign.cs (Assign.DoResolve): `target' must either be an
14381 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14384 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14386 * expression.cs (BinaryMethod): This kind of expression is created by the
14387 Binary class if it determines that the operator has to be handled
14390 (BinaryDelegate): This kind of expression is created if we are
14391 dealing with a + or - operator on delegates.
14393 (Binary): remove method, argumetns, and DelegateOperator: when
14394 dealing with methods,
14396 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14398 * statement.cs (Block): use bitfields for the three extra booleans
14399 we had in use. Remove unused topblock parameter.
14401 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14403 * assign.cs: Drop extra unneeded tests.
14405 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14407 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14409 * statement.cs (Foreach): Use VariableStorage instead of
14412 * codegen.cs (VariableStorage): New class used by clients that
14413 require a variable stored: locals or fields for variables that
14414 need to live across yield.
14416 Maybe provide a convenience api for EmitThis+EmitLoad?
14418 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14421 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14423 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14424 RemapParameterLValue): New methods that are used to turn a
14425 precomputed FieldInfo into an expression like this:
14429 The idea is to use this instead of making LocalVariableReference
14430 have more than one meaning.
14432 * cs-parser.jay: Add error production to BASE.
14434 * ecore.cs: Deal with TypeManager.GetField returning null, which
14435 is now a valid return value.
14437 (FieldExprNoAddress): New expression for Fields whose address can
14440 * expression.cs (LocalVariableReference): During the resolve
14441 phases, create new expressions if we are in a remapping context.
14442 Remove code that dealt with remapping here.
14444 (ParameterReference): same.
14446 (ProxyInstance): New expression, like the `This' expression, but
14447 it is born fully resolved. We know what we are doing, so remove
14448 the errors that are targeted to user-provided uses of `this'.
14450 * statement.cs (Foreach): our variable is now stored as an
14451 Expression; During resolution, follow the protocol, dont just
14452 assume it will return this.
14454 2003-08-06 Martin Baulig <martin@ximian.com>
14456 * support.cs (SeekableStreamReader.cs): New public class.
14458 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14459 SeekableStreamReader instead of the normal StreamReader.
14461 2003-08-04 Martin Baulig <martin@ximian.com>
14463 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14464 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14465 deambiguate casts and delegate invocations.
14466 (parenthesized_expression): Use the new tokens to ensure this is
14467 not a cast of method invocation.
14469 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14470 when reading a `)' and Deambiguate_CloseParens () was previously
14473 * expression.cs (ParenthesizedExpression): New class. This is
14474 just used for the CS0075 test.
14475 (Binary.DoResolve): Check for CS0075.
14477 2003-07-29 Ravi Pratap <ravi@ximian.com>
14479 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14480 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14481 reference comparison.
14483 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14484 examine the ReturnType for equality - this is necessary in the
14485 cases of implicit and explicit operators whose signature also
14486 includes the return type.
14488 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14490 * namespace.cs: Cache the result of the namespace computation,
14491 instead of computing it every time.
14493 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14495 * decl.cs: Use a global arraylist that we reuse over invocations
14496 to avoid excesive memory consumption. Reduces memory usage on an
14497 mcs compile by one meg (45 average).
14499 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14500 private, work around that.
14502 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14504 * literal.cs (IntLiteral): Define Zero and One static literals.
14506 * cs-parser.jay (integer_literal): use static literals to reduce
14507 memory usage for the most used literals (0, 1 and -1). 211kb
14508 reduced in memory usage.
14510 Replace all calls to `new ArrayList' with `new
14511 ArrayList(4)' which is a good average number for most allocations,
14512 and also requires only 16 bytes of memory for its buffer by
14515 This reduced MCS memory usage in seven megabytes for the RSS after
14518 2003-07-28 Ravi Pratap <ravi@ximian.com>
14520 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14521 handle params methods the correct way by forming only one
14522 applicable set with params and normal methods in them. Earlier we
14523 were looking at params methods only if we found no normal methods
14524 which was not the correct thing to do.
14526 (Invocation.BetterFunction): Take separate arguments indicating
14527 when candidate and the best method are params methods in their
14530 This fixes bugs #43367 and #46199.
14532 * attribute.cs: Documentation updates.
14534 (CheckAttribute): Rename to CheckAttributeTarget.
14535 (GetValidPlaces): Rename to GetValidTargets.
14537 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14538 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14542 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14544 * codegen.cs: Compute IsGeneric correctly.
14546 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14549 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14550 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14551 regressions, and I was chasing more bugs than I required.
14553 * interface.cs: Use expressions for base type names (like classes
14554 and structs have been doing for a while now), and resolve that.
14555 This patch should probably go into head as well.
14557 This makes it one less user of FindType.
14559 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14561 This compiler can not self host currently. Need to fix that.
14563 * Makefile: compile to `gmcs.exe'
14565 * driver.cs: Turn on v2 by default on gmcs.
14567 * generic.cs (ConstructedType): Does no longer take a container
14568 type argument; That will be taken care of later.
14570 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14571 Use SimpleName to resolve for now, so we can continue the work on
14572 the parser, until we get Type.GetType that understands generics.
14574 (ConstructedType.ToString): Implement
14576 (TypeArguments.Resolve): Resolve the child expressions as types.
14578 * cs-parser.jay: Rename interface_constraints to
14579 type_parameter_constraints
14581 (namespace_or_type_name): Only use constructed types for the basic
14582 construction, we will deal with identifier<...> later.
14584 (type/type_name): No longer call DecomposeQI, as
14585 namespace_or_type_name is always decoded now.
14587 2003-07-22 Ravi Pratap <ravi@ximian.com>
14589 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14590 closely: we eliminate methods in base types when we have an
14591 applicable method in a top-level type.
14593 Please see section 14.5.5.1 for an exact description of what goes
14596 This fixes bug #45127 and a host of other related to corlib compilation.
14598 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14599 array is the method corresponding to the top-level type (this is
14600 because of the changes made to icall.c) so we change this
14603 (MethodGroupExpr.Name): This too.
14605 * typemanager.cs (GetElementType): New method which does the right
14606 thing when compiling corlib.
14608 * everywhere: Make use of the above in the relevant places.
14610 2003-07-22 Martin Baulig <martin@ximian.com>
14612 * cs-parser.jay (invocation_expression): Moved
14613 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14614 `cast_expression', but create a InvocationOrCast which later
14615 resolves to either an Invocation or a Cast.
14617 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14618 method; call this before EmitStatement() to make sure that this
14619 expression can be used as a statement.
14621 * expression.cs (InvocationOrCast): New class; resolves to either
14622 an Invocation or a Cast.
14624 * statement.cs (StatementExpression): Call ResolveStatement() on
14625 the ExpressionStatement before emitting it.
14627 2003-07-21 Martin Baulig <martin@ximian.com>
14629 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
14630 `ref' and `out' attributes match; fixes #46220.
14631 (MemberAccess.ResolveMemberAccess): You can't reference a type
14632 through an expression; fixes #33180.
14633 (Indexers.GetIndexersForType): Don't return the indexers from
14634 interfaces the class implements; fixes #46502.
14636 2003-07-21 Martin Baulig <martin@ximian.com>
14638 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
14639 CS0661 checks; fixes bug #30442.
14641 2003-07-21 Martin Baulig <martin@ximian.com>
14643 * decl.cs (AdditionResult): Added `Error'.
14645 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
14647 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
14648 cs0031.cs actually work.
14650 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14652 * cs-parser.jay (namespace_name): do not use
14653 namespace_or_type_name, use qualified_identifier, because
14654 namespace_or_type_name will soon return a composed expression
14655 instead of a string.
14657 (namespace_or_type_name): Instead of returning a string, now this
14658 production returns an expression.
14660 * codegen.cs (EmitContext): Setup IsGeneric property based on
14661 whether our DeclSpace is generic, our the method is generic.
14663 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
14664 the method is generic.
14666 * cs-parser.jay (type_arguments, opt_type_argument_list,
14667 type_parameters, type_parameter_list, opt_type_parameter_list,
14668 type_parameter,, opt_type_parameter_constraints_clauses,
14669 type_parameter_constraints_clauses,
14670 type_parameter_constraint_clause, type_parameter_constraint,
14671 interface_constraints): Add new production
14673 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
14674 DeclSpace is generic or not.
14676 (DeclSpace.SetParameterInfo): New routine, used to set the
14677 parameter info for a type.
14679 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
14680 returns a GenericTypeExpr
14682 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
14683 generic, lookup the generic argument.
14685 * attribute.cs: Do not allow TypeParameterExpressions in
14688 * class.cs: Do not allow the Main method to be defined in a
14691 * expression.cs (SizeOf): Do not allow generic types to be used as
14692 arguments to sizeof.
14694 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
14695 it: whether a type is generic or not. Only works for types we are
14696 currently building for now.
14698 2003-07-20 Martin Baulig <martin@ximian.com>
14700 * namespace.cs: Fixed that bug which caused a crash when compiling
14701 the debugger's GUI.
14703 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14705 * typemanager.cs (LookupTypeReflection): Never expose types which
14706 are NotPublic, NestedPrivate, NestedAssembly, or
14707 NestedFamANDAssem. We used to return these, and later do a check
14708 that would report a meaningful error, but the problem is that we
14709 would not get the real match, if there was a name override.
14711 2003-07-18 Miguel de Icaza <miguel@ximian.com>
14713 * namespace.cs (Namespace, Name): Do not compute the namespace
14714 name dynamically, compute it in the constructor. This reduced
14715 memory usage by 1697 KB.
14717 * driver.cs: Use --pause to pause at the end.
14719 2003-07-17 Peter Williams <peter@newton.cx>
14721 * Makefile: Change the name of the test target so that it doesn't
14722 conflict with the recursive test target.
14724 2003-07-17 Miguel de Icaza <miguel@ximian.com>
14726 * expression.cs (LocalVariableReference.Emit, EmitAssign,
14727 AddressOf): Do not use EmitThis, that was wrong, use the actual
14730 2003-07-15 Miguel de Icaza <miguel@ximian.com>
14732 * class.cs (MethodData.Define): While checking if a method is an
14733 interface implementation, improve the test: If we are not public
14734 (use new test here: use the computed MethodAttributes directly,
14735 instead of the parsed modifier flags) check if the `implementing'
14736 method comes from an interface or not.
14738 * pending.cs (VerifyPendingMethods): Slightly better error
14741 * makefile: add test target that does the mcs bootstrap.
14743 2003-07-16 Ravi Pratap <ravi@ximian.com>
14745 * interface.cs (Define): Do nothing here since there are no
14746 members to populate etc. Move the attribute emission out of here
14747 since this was just totally the wrong place to put it. Attribute
14748 application happens during the 'Emit' phase, not in the 'Define'
14751 (Emit): Add this method and move the attribute emission here
14753 * rootcontext.cs (EmitCode): Call the Emit method on interface
14756 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14758 * expression.cs (OverloadResolve): Report error only if Location
14759 is not 'Null' which means that there was a probe going on.
14761 2003-07-14 Martin Baulig <martin@ximian.com>
14763 * expression.cs (ConditionalLogicalOperator): New public class to
14764 implement user defined conditional logical operators.
14765 This is section 14.11.2 in the spec and bug #40505.
14767 2003-07-14 Martin Baulig <martin@ximian.com>
14769 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
14771 2003-07-14 Martin Baulig <martin@ximian.com>
14773 * codegen.cs (EmitContext.InFixedInitializer): New public field.
14775 * ecore.cs (IVariable.VerifyFixed): New interface method.
14777 * expression.cs (Unary.ResolveOperator): When resolving the `&'
14778 operator, check whether the variable is actually fixed. Fixes bug
14779 #36055. Set a variable definitely assigned when taking its
14780 address as required by the spec.
14782 * statement.cs (LocalInfo.IsFixed): New field.
14783 (LocalInfo.MakePinned): Set `IsFixed' to true.
14785 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14787 * attribute.cs (Attribute.Resolve): While doing a Member lookup
14788 for .ctors, ensure that we only ask for members declared in the
14789 attribute type (BindingFlags.DeclaredOnly).
14793 * expression.cs (Error_WrongNumArguments): Report error 1501
14794 correctly the way CSC does.
14796 2003-07-13 Martin Baulig <martin@ximian.com>
14798 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
14799 lookup on the fully qualified name, to make things like "X.X" work
14800 where "X.X" is a fully qualified type name, but we also have a
14801 namespace "X" in the using list. Fixes #41975.
14803 2003-07-13 Martin Baulig <martin@ximian.com>
14805 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
14806 function. If we're a CompoundAssign, we need to create an embedded
14807 CompoundAssign, not an embedded Assign.
14808 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
14811 2003-07-13 Martin Baulig <martin@ximian.com>
14813 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
14814 work to fix bug #46088.
14816 2003-07-13 Ravi Pratap <ravi@ximian.com>
14818 * class.cs (Operator.Emit): Do not emit attributes here - it is
14819 taken care of by the Method class that we delegate too. This takes
14820 care of bug #45876.
14822 2003-07-10 Martin Baulig <martin@ximian.com>
14824 * expression.cs (TypeOfVoid): New class.
14825 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
14827 2003-07-10 Martin Baulig <martin@ximian.com>
14829 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
14832 2003-07-10 Martin Baulig <martin@ximian.com>
14834 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
14835 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
14837 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
14839 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
14841 2003-07-10 Martin Baulig <martin@ximian.com>
14843 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
14844 of decimal. Fixes #42850.
14846 NOTE: I also fixed the created byte blob, but this doesn't work on
14847 the MS runtime and csc never produces any byte blobs for decimal
14850 2003-07-10 Martin Baulig <martin@ximian.com>
14852 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
14853 structs; fixes #32068.
14854 (Block.AddChildVariableNames): Fixed #44302.
14856 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14858 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
14860 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14862 * attribute.cs: And this test is onger needed.
14864 2003-07-08 Martin Baulig <martin@ximian.com>
14866 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
14867 inaccessible types. Fixes #36313.
14869 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
14871 * namespace.cs (NamespaceEntry): Create implicit entries for all
14872 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
14873 implicit entries for N1.N2 and N1.
14875 2003-07-08 Martin Baulig <martin@ximian.com>
14877 Rewrote the handling of namespaces to fix a lot of the issues
14878 wrt. `using' aliases etc.
14880 * namespace.cs (Namespace): Splitted this class into a
14881 per-assembly `Namespace' and a per-file `NamespaceEntry'.
14883 * typemanager.cs (TypeManager.IsNamespace): Removed.
14884 (TypeManager.ComputeNamespaces): Only compute namespaces from
14885 loaded assemblies here, not the namespaces from the assembly we're
14886 currently compiling.
14888 2003-07-08 Martin Baulig <martin@ximian.com>
14890 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
14892 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14894 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
14897 I thought about the memory savings here, but LookupTypeReflection
14898 is used under already very constrained scenarios. Compiling
14899 corlib or mcs only exposes one hit, so it would not really reduce
14900 any memory consumption.
14902 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14904 * typemanager.cs: fixes bug #45889 by only adding public types from
14905 other assemblies to the list of known types.
14907 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14909 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
14910 on the type we resolved.
14912 2003-07-05 Martin Baulig <martin@ximian.com>
14914 * pending.cs (PendingImplementation.ParentImplements): Don't
14915 create the proxy if the parent is abstract.
14917 * class.cs (TypeContainer.DefineIndexers): Process explicit
14918 interface implementations first. Fixes #37714.
14920 2003-07-04 Miguel de Icaza <miguel@ximian.com>
14922 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
14923 defined recursively; but since we modify the input parameters
14924 (left is set to `this' temporarily), we reset this value if the
14925 left_is_explicit is false, which gives the original semantics to
14928 * literal.cs (NullPointer): new class used to represent a null
14929 literal in a pointer context.
14931 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
14932 type is a pointer, use a NullPointer object instead of a
14933 NullLiteral. Closes 43687
14935 (ExplicitConversion): Convert pointer values using
14936 the conv opcode to the proper type.
14938 * ecore.cs (New): change ValueTypeVariable property into a method,
14939 that returns whether the valuetype is suitable for being used.
14941 * expression.cs (Binary.DoNumericPromotions): Only return if we
14942 the int constant was a valid uint, and we can return both left and
14943 right as uints. If not, we continue processing, to trigger the
14944 type conversion. This fixes 39018.
14946 * statement.cs (Block.EmitMeta): During constant resolution, set
14947 the CurrentBlock property on the emitcontext, so that we resolve
14948 constants propertly.
14950 2003-07-02 Martin Baulig <martin@ximian.com>
14952 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
14953 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
14955 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
14956 than emitting it here.
14958 * statement.cs: Fixed some more flow analysis bugs.
14960 2003-07-02 Martin Baulig <martin@ximian.com>
14962 * class.cs (MethodData.Define): When implementing interface
14963 methods, set Final unless we're Virtual.
14965 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
14966 check work for interface methods.
14968 2003-07-01 Martin Baulig <martin@ximian.com>
14970 * ecore.cs (EmitContext.This): Replaced this property with a
14971 GetThis() method which takes a Location argument. This ensures
14972 that we get the correct error location for a CS0188.
14974 2003-07-01 Miguel de Icaza <miguel@ximian.com>
14976 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
14977 ImplicitStandardConversion.
14979 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
14981 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
14983 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
14986 2003-06-30 Miguel de Icaza <miguel@ximian.com>
14988 * class.cs (Constructor.Define): Turn off initlocals for unsafe
14991 (MethodData.Define): Turn off initlocals for unsafe methods.
14993 2003-06-29 Miguel de Icaza <miguel@ximian.com>
14995 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
14996 complete; Fixes #37521.
14998 * delegate.cs: Use Modifiers.TypeAttr to compute the
14999 TypeAttributes, instead of rolling our own. This makes the flags
15000 correct for the delegates.
15002 2003-06-28 Miguel de Icaza <miguel@ximian.com>
15004 * class.cs (Constructor.Define): Set the private flag for static
15005 constructors as well.
15007 * cs-parser.jay (statement_expression): Set the return value to
15008 null, to avoid a crash when we catch an error.
15010 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15012 * cs-parser.jay: Applied patch from Jackson that adds support for
15013 extern and unsafe modifiers to destructor declarations.
15015 * expression.cs: Report error 21 if the user is trying to index a
15018 * driver.cs: Add an error message, suggested by the bug report.
15020 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15021 if we do not have a ": this ()" constructor initializer. Fixes 45149
15023 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15025 * namespace.cs: Add some information to reduce FAQs.
15027 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15029 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15030 underlying enumeration types. Fixes #43915.
15032 * expression.cs: Treat ushort/short as legal values to be used in
15033 bitwise operations.
15035 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15037 * delegate.cs: transfer custom attributes for paramenters from
15038 the delegate declaration to Invoke and BeginInvoke.
15040 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15042 * attribute.cs: handle custom marshalers and emit marshal info
15045 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15047 * makefile.gnu: Added anonymous.cs to the compiler sources.
15049 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15051 * iterators.cs: Change the name of the proxy class to include two
15054 * cs-parser.jay: Update grammar to include anonymous methods.
15056 * anonymous.cs: new file.
15058 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15060 * class.cs (Field.Define): Add missing test for pointers and
15063 2003-05-27 Ravi Pratap <ravi@ximian.com>
15065 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15066 we use the stobj opcode.
15068 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15069 since it wasn't the correct fix.
15071 It still is puzzling that we are required to use stobj for IntPtr
15072 which seems to be a ValueType.
15074 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15076 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15077 during regular simple name resolution. Now, the trick is that
15078 instead of returning for processing the simplename, we do a
15079 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15080 contextual lookup type). If a match is found, return that, if
15081 not, return for further composition.
15083 This fixes long-standing 30485.
15085 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15086 using the address to initialize an object, do an Stobj instead of
15087 using the regular Stelem.
15089 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15090 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15091 Because if we are a BaseIndexerAccess that value will be true.
15094 * statement.cs (GotoCase.Resolve): Return after reporting an
15095 error, do not attempt to continue.
15097 * expression.cs (PointerArithmetic.Emit): If our operand is a
15098 long, convert our constants to match the operand before
15099 multiplying. Convert to I type before adding. Fixes 43670.
15101 2003-05-14 Ravi Pratap <ravi@ximian.com>
15103 * enum.cs (ImplicitConversionExists) : Rename to
15104 ImplicitEnumConversionExists to remove ambiguity.
15106 * ecore.cs (NullCast): New type of cast expression class which
15107 basically is very similar to EmptyCast with the difference being
15108 it still is a constant since it is used only to cast a null to
15110 (eg. (string) null)
15112 * convert.cs (ImplicitReferenceConversion): When casting a null
15113 literal, we return a NullCast.
15115 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15116 should be around anymore.
15118 The renaming (reported was slightly wrong). Corrections:
15120 ConvertImplicitStandard -> ImplicitConversionStandard
15121 ConvertExplicitStandard -> ExplicitConversionStandard
15123 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15124 before passing them in !
15126 * convert.cs (ImplicitConversionStandard): When comparing for
15127 equal expr and target types, ensure that expr is not a
15130 In general, we must not be checking (expr_type ==
15131 target_type) in the top level conversion methods
15132 (ImplicitConversion, ExplicitConversion etc). This checking is
15133 done in the methods that they delegate to.
15135 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15137 * convert.cs: Move Error_CannotConvertType,
15138 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15139 ImplicitNumericConversion, ImplicitConversionExists,
15140 ImplicitUserConversionExists, StandardConversionExists,
15141 FindMostEncompassedType, FindMostSpecificSource,
15142 FindMostSpecificTarget, ImplicitUserConversion,
15143 ExplicitUserConversion, GetConversionOperators,
15144 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15145 TryImplicitIntConversion, Error_CannotConvertImplicit,
15146 ConvertImplicitRequired, ConvertNumericExplicit,
15147 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15148 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15151 Perform the following renames:
15153 StandardConversionExists -> ImplicitStandardConversionExists
15154 ConvertImplicit -> ImplicitConversion
15155 ConvertImplicitStandard -> ImplicitStandardConversion
15156 TryImplicitIntConversion -> ImplicitIntConversion
15157 ConvertImplicitRequired -> ImplicitConversionRequired
15158 ConvertNumericExplicit -> ExplicitNumericConversion
15159 ConvertReferenceExplicit -> ExplicitReferenceConversion
15160 ConvertExplicit -> ExplicitConversion
15161 ConvertExplicitStandard -> ExplicitStandardConversion
15163 2003-05-19 Martin Baulig <martin@ximian.com>
15165 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15166 (TypeInfo): Added support for structs having structs as fields.
15168 * ecore.cs (FieldExpr): Implement IVariable.
15169 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15170 VariableInfo for the field.
15172 2003-05-18 Martin Baulig <martin@ximian.com>
15174 * expression.cs (This.DoResolve): Report a CS0027 if we're
15175 emitting a field initializer.
15177 2003-05-18 Martin Baulig <martin@ximian.com>
15179 * expression.cs (This.ResolveBase): New public function.
15180 (This.DoResolve): Check for CS0188.
15182 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15185 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15186 `instance_expression' to null if we don't have any non-static
15189 2003-05-18 Martin Baulig <martin@ximian.com>
15191 Reworked the way how local variables and parameters are handled by
15192 the flow analysis code.
15194 * statement.cs (TypeInfo, VariableMap): New public classes.
15195 (VariableInfo): New public class. This is now responsible for
15196 checking whether a variable has been assigned. It is used for
15197 parameters and local variables.
15198 (Block.EmitMeta): Take the InternalParameters as argument; compute
15199 the layout of the flow vectors here.
15200 (Block.LocalMap, Block.ParameterMap): New public properties.
15201 (FlowBranching): The .ctor doesn't get the InternalParameters
15202 anymore since Block.EmitMeta() now computes the layout of the flow
15204 (MyStructInfo): This class is now known as `StructInfo' and nested
15205 in `TypeInfo'; we don't access this directly anymore.
15207 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15208 property and removed IsAssigned(), IsFieldAssigned(),
15209 SetAssigned() and SetFieldAssigned(); we now call them on the
15210 VariableInfo so we don't need to duplicate this code everywhere.
15212 * expression.cs (ParameterReference): Added `Block block' argument
15214 (LocalVariableReference, ParameterReference, This): The new
15215 VariableInfo class is now responsible for all the definite
15218 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15219 IsParameterAssigned, SetParameterAssigned): Removed.
15221 2003-05-18 Martin Baulig <martin@ximian.com>
15223 * typemanager.cs (InitCoreTypes): Try calling
15224 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15225 the 3-args-version. Corlib now also needs our `void_type'.
15226 (GetMethod): Added overloaded version which takes an optional
15227 `bool report_errors' to allow lookups of optional methods.
15229 2003-05-12 Martin Baulig <martin@ximian.com>
15231 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15232 only used for locals and not for parameters.
15234 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15236 * support.cs (InternalParameters.ParameterType): Return the
15237 ExternalType of the parameter.
15239 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15242 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15244 * class.cs (MethodData.Define): Do not set the `newslot' on
15245 interface members, if they are also flagged as "override".
15247 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15248 better code for ++i and i++. This only works for static fields
15249 and local variables.
15251 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15252 want to pull the DeclSpace out of the builder_to_declspace instead
15253 of the TypeBuilder (like in TypeContainer.FindMembers).
15255 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15256 instead of LookupTypeContainer. Fixes the crash on .NET for
15257 looking up interface members.
15259 * const.cs: Create our own emit context during the Definition
15260 stage, so that constants are evaluated in the proper context, when
15261 a recursive definition happens.
15263 2003-05-11 Martin Baulig <martin@ximian.com>
15265 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15266 new block for a switch section.
15267 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15268 the adding/lookup in the switch block. Fixes #39828.
15270 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15272 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15273 functionality: I needed to convert the data after I had performed
15274 the add/sub operation into the operands type size.
15276 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15277 pass the type for the box operation, otherwise the resulting
15278 object would have been of type object.
15280 (BoxedCast): Add constructor to specify the type to box as.
15282 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15284 * iterators.cs: I was reusing the `count' variable inadvertently,
15285 take steps to not allow this to happen.
15287 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15289 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15290 by creating an array at the point where the params starts and
15291 putting all those arguments there, then adjusting the size of the
15294 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15296 * expression.cs (New.AddressOf): Implement interface
15297 IMemoryLocation. This is used when the `new' operator is used in
15298 the context of an invocation to a method on a value type.
15300 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15303 * namespace.cs: Also check the using aliases here.
15305 * driver.cs: Move the test for using validity after the types have
15306 been entered, so we do a single pass that also includes the using
15309 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15310 in the regular case. CreateSiblingForFinally is doing extra
15313 * attribute.cs (GetAttributeArgumentExpression): Store the result
15314 on an out value, and use the return value to indicate failure
15315 instead of using null (which is a valid return for Constant.GetValue).
15317 * statement.cs: Perform the analysis flow for the increment
15318 portion after the statement, because this will be the real flow of
15319 execution. Fixes #42385
15321 * codegen.cs (EmitContext.EmitArgument,
15322 EmitContext.EmitStoreArgument): New helper functions when the
15323 RemapToProxy flag is set.
15325 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15328 Add support for remapping parameters.
15330 * iterators.cs: Propagate parameter values; Store parameter
15331 values in the proxy classes.
15333 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15335 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15336 need a proxy reference; I do not know what I was thinking
15338 * cs-parser.jay (constructor_initializer): catch another error,
15339 and display nice message.
15341 (field_declaration): catch void field declaration
15342 to flag a better error.
15344 * class.cs (MemberBase.CheckBase): Report an error instead of a
15345 warning if a new protected member is declared in a struct.
15346 (Field.Define): catch the error of readonly/volatile.
15348 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15350 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15351 volatile variable is taken
15353 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15355 * statement.cs (Fixed.Resolve): Report an error if we are not in
15358 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15360 * typemanager.cs: reuse the code that handles type clashes for
15361 delegates and enumerations.
15363 * class.cs (Report28): Always report.
15365 * expression.cs (EncodeAsAttribute): Allow nulls here.
15367 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15369 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15370 the functionality for testing whether an expression is valid for
15371 an attribute here. Also handle the case of arrays of elements
15374 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15375 encoding a linear array into an array of objects that are suitable
15376 to be passed to an CustomAttributeBuilder.
15378 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15380 * ecore.cs: (FieldExpr): Handle field remapping here.
15382 * iteratators.cs: Pass the instance variable (if the method is an
15383 instance method) to the constructors, so we can access the field
15384 variables on the class.
15386 TODO: Test this with structs. I think the THIS variable on
15387 structs might have to be a pointer, and not a refenrece
15389 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15391 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15392 local variables to fields in a proxy class.
15394 * iterators.cs (PopulateProxy): Rename our internal fields to
15396 Create a <THIS> field if we are an instance method, so we can
15397 reference our parent container variables.
15398 (MapVariable): Called back from the EmitContext code to enter a
15399 new variable to field mapping into the proxy class (we just create
15403 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15404 for using the remapped locals to fields.
15406 I placed the code here, because that gives the same semantics to
15407 local variables, and only changes the Emit code.
15409 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15410 statements inside iterators.
15411 (VariableInfo): Add a FieldBuilder for the cases when we are
15412 remapping local variables to fields in a proxy class
15414 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15415 current_block != null.
15417 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15418 not cope with strings, as it has been moved to the
15419 TableSwitchEmit. Fixed bug in switch generation.
15421 * expression.cs (New.DoResolve): Provide more context for the user
15422 when reporting an error.
15424 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15427 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15428 check the permissions for it. Note than in a type-resolution
15429 context the check was already present in DeclSpace.ResolveType,
15430 but was missing from the MemberAccess.
15432 (ArrayCreation.CheckIndices): warn if the user has
15433 more nested levels of expressions, but there are no more
15434 dimensions specified. Avoids crash on bug 41906.
15436 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15438 * statement.cs (Block): replace Implicit bool, for a generic
15440 New flag: `Unchecked'. This is used during the EmitMeta phase
15441 (which is out-of-line with the regular Resolve/Emit process for a
15442 statement, as this is done ahead of time, but still gets a chance
15443 to call constant resolve).
15445 (Block.Flags): new enum for adding a new flag.
15447 (Block.EmitMeta): track the state of unchecked.
15449 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15450 to enable constant resolution to work there as well.
15452 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15454 * typemanager.cs (ienumerable_type): Also look up
15455 System.Collections.IEnumerable.
15457 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15459 TODO: Test more than one conditional per method.
15461 * class.cs (Indexer.Define): Report the location where the user is
15462 referencing the unsupported feature.
15464 (MethodData): Overload the use of `conditionals' to
15465 minimize the creation of needless ArrayLists. This saves roughly
15466 212kb on my machine.
15468 (Method): Implement the new IIteratorContainer interface.
15469 (Method.SetYields): Implement the method by setting the ModFlags
15470 to contain METHOD_YIELDS.
15472 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15473 which just got set to null.
15475 * iterators.cs: New file.
15477 (Yield, YieldBreak): New statements.
15479 * statement.cs (Return.Resolve): Flag an error if we are used in
15480 an iterator method.
15482 * codegen.cs (InIterator): New flag set if the code is being
15483 compiled in an iterator method.
15485 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15486 internal modifier, and we just use it to avoid adding extra
15487 fields, as this is seldom used.
15489 * cs-parser.jay: Add yield_statement (yield and yield break).
15491 * driver.cs: New flag -v2 to turn on version 2 features.
15493 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15494 hashtable when v2 is enabled.
15496 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15498 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15499 there is already a namespace defined with this name.
15501 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15502 people upgraded their corlibs.
15504 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15505 always use fully qualified types, no need to use the compiler
15508 (TypeManager.IsNamespace): Use binarysearch.
15510 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15511 AddDelegate): I did not quite use the new IsValid API properly: I
15512 have to pass the short-name and the fullname. I was passing only
15513 the basename instead of the fullname sometimes.
15515 (TypeContainer.DefineType): call NamespaceClash.
15517 * interface.cs (Interface.DefineType): use NamespaceClash before
15520 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15523 * enum.cs: (Enum.DefineType): use NamespaceClash before
15526 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15527 speed increase. First, use the negative_hits cache when we get a
15528 negative. Second, add the type with its full original name
15529 instead of the new . and + encoded name (reflection uses + to
15530 separate type from a nested type). Use LookupTypeReflection
15531 directly which bypasses the type->name hashtable (that we already
15532 know does not contain the type.
15534 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15535 location/container type.
15537 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15539 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15541 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15543 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15544 method is being referenced in the method group from a static
15545 context, and report error 120 if so.
15547 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15550 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15551 is created, we create the A namespace).
15553 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15556 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15558 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15559 invocation to ModuleBuilder.GetType with the same values will
15560 return a new type instance, so we need to cache its return
15563 * expression.cs (Binary.ResolveOperator): Only allow the compare
15564 operators on enums if they are of the same type.
15566 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15567 types of ValueType on their own case. Before we were giving them
15568 the same treatment as objects.
15570 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15571 fullname. Short name is used to compare against container name.
15572 Fullname is used to check against defined namespace names.
15574 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15575 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15577 (Method.CheckBase): Call parent.
15578 (MemberBase.CheckBase): Check for protected members on sealed
15580 (PropertyBase.CheckBase): Call parent.
15581 (Field.Define): Call parent.
15583 * report.cs: Negative error codes are now mapped to 8000 - code,
15584 so that the display is render more nicely.
15586 * typemanager.cs: Do not use try/catch, instead report a regular
15589 (GetPointerType, GetReferenceType): These methods provide
15590 mechanisms to obtain the T* and T& from a T. We had the code
15591 previously scattered around the code base, and it also used
15592 TypeManager.LookupType that would go through plenty of caches.
15593 This one goes directly to the type source.
15595 In some places we did the Type.GetType followed by
15596 ModuleBuilder.GetType, but not in others, so this unifies the
15597 processing as well.
15599 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15600 statements now that we have namespace information.
15602 * typemanager.cs (IsNamespace): New method, returns whether the
15603 string presented is a namespace or not.
15605 (ComputeNamespaces): New public entry point, computes the list of
15606 available namespaces, using the GetNamespaces API call in Mono, or
15607 the slower version in MS.NET.
15609 Now before we start the semantic analysis phase, we have a
15610 complete list of namespaces including everything that the user has
15613 Deleted old code to cache namespaces in .nsc files.
15615 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15617 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15618 class/struct location definition Location for the implicit
15619 constructor location.
15621 (Operator.Define): Use the location of the operator for the
15622 implicit Method definition.
15624 (Constructor.Emit): use the constructor location for the implicit
15625 base initializer constructor.
15627 * ecore.cs: Remove ITypeExpression. This interface is now gone,
15628 and the Expression class now contains two new methods:
15630 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
15631 isolate type lookup from the rest of the resolution process.
15633 Since we use Expressions to hold type definitions due to the way
15634 we parse the input we have historically overloaded Resolve to
15635 perform the Type lookups if a special flag is passed. Now this is
15636 eliminated and two methods take their place.
15638 The differences in the two methods between xStep and xTerminal is
15639 that xStep is involved in our current lookup system that uses
15640 SimpleNames to compose a name, while xTerminal is used just to
15641 catch the case where the simplename lookup failed.
15643 2003-04-16 Miguel de Icaza <miguel@ximian.com>
15645 * expression.cs (ResolveMemberAccess): Remove redundant code.
15646 TypeExpr expressions are always born fully resolved.
15648 * interface.cs (PopulateMethod): Do not lookup the types twice.
15649 We were doing it once during SemanticAnalysis and once during
15652 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
15653 in local variable type definitions, were being returned as a
15654 SimpleName (we decomposed everything into a string), that is
15655 because primary_expression was being used instead of a type in the
15656 grammar (reduce/reduce conflicts).
15658 The part that was wrong is that we converted the expression into a
15659 string (an oversimplification in one hand, compounded with primary
15660 expressions doing string concatenation).
15666 Would return "A.B.C[]" as a SimpleName. This stopped things like
15667 using clauses from working on this particular context. And a type
15668 was being matched directly against "A.B.C[]".
15670 We now use the correct approach, and allow for ComposedCast to be
15671 part of the unary expression. So the "A.B.C []" become a composed
15672 cast of "A.B.C" (as a nested group of MemberAccess with a
15673 SimpleName at the end) plus the rank composition "[]".
15677 2003-04-10 Miguel de Icaza <miguel@ximian.com>
15679 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
15680 for the access level checking.
15682 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
15683 `TypeContainer container', because I kept getting confused when I
15684 was debugging this code.
15686 * expression.cs (Indexers): Instead of tracking getters/setters,
15687 we now track them in parallel. We create one arraylist less, but
15688 most importantly it is possible now for the LValue code to find a
15689 matching get for a set.
15691 (IndexerAccess.DoResolveLValue): Update the code.
15692 GetIndexersForType has been modified already to extract all the
15693 indexers from a type. The code assumed it did not.
15695 Also make the code set the correct return type for the indexer.
15696 This was fixed a long time ago for properties, but was missing for
15697 indexers. It used to be void_type.
15699 (Binary.Emit): Test first for doubles instead of
15700 floats, as they are more common.
15702 (Binary.EmitBranchable): Use the .un version of the branch opcodes
15703 when dealing with floats and the <=, >= operators. This fixes bug
15706 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
15707 to load the array value by emitting a load on the foreach variable
15708 type. This was incorrect.
15710 We now emit the code to load an element using the the array
15711 variable type, and then we emit the conversion operator.
15715 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
15717 * attribute.cs: Avoid allocation of ArrayLists in the common case.
15719 2003-04-09 Miguel de Icaza <miguel@ximian.com>
15721 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
15722 test for protection before we test for signatures.
15724 (MethodSignature.ToString): implement.
15726 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
15727 to the case where we reduced into a LongConstant.
15729 * decl.cs (CheckAccessLevel): If the type is an array, we can not
15730 depend on whether the information is acurrate, because the
15731 Microsoft runtime will always claim that the array type is public,
15732 regardless of the real state.
15734 If the type is a pointer, another problem happens: the type is
15735 reported as non-public in Microsoft.
15737 In both cases we have to call CheckAccessLevel recursively with
15738 the underlying type as the argument to be tested.
15740 2003-04-08 Miguel de Icaza <miguel@ximian.com>
15742 * assign.cs (Assign.Emit): If we are dealing with a compound
15743 assignment expression, we should use the code path that stores the
15744 intermediate result in a temporary value. This fixes #40903.
15746 *expression.cs (Indirection.ToString): Provide ToString method for
15749 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
15751 * class.cs: Null out fields holding references to Block objects so
15752 they can be garbage collected.
15754 * expression.cs (OverloadResolve): Remove unused local.
15756 2003-04-07 Martin Baulig <martin@ximian.com>
15758 * codegen.cs (EmitContext.CurrentFile): New public field.
15759 (EmitContext.Mark): Use the CurrentFile to check whether the
15760 location is in the correct file.
15761 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
15763 2003-04-07 Martin Baulig <martin@ximian.com>
15765 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
15767 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
15768 location. [FIXME: The location argument which gets passed to this
15769 method is sometimes wrong!]
15771 2003-04-07 Nick Drochak <ndrochak@gol.com>
15773 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
15775 2003-04-07 Miguel de Icaza <miguel@ximian.com>
15777 * expression.cs (Indirection.EmitAssign): We were using the
15778 temporary, but returning immediately instead of continuing the
15781 2003-04-06 Martin Baulig <martin@ximian.com>
15783 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
15784 if it's a nested child, but also deriving from the outer class.
15787 * typemanager.cs (IsNestedChildOf): Make this work if it's a
15788 nested child, but also deriving from the outer class. See
15790 (FilterWithClosure): We may access private members of the outer
15791 class if we're a nested child and deriving from the outer class.
15792 (RealMemberLookup): Only set `closure_private_ok' if the
15793 `original_bf' contained BindingFlags.NonPublic.
15795 2003-04-05 Martin Baulig <martin@ximian.com>
15797 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
15798 probe if its a type parameter, and if so, flag an error.
15800 * decl.cs: Move here the SetParameterInfo code from class.cs.
15801 Handle IsGeneric here.
15803 Handle a variety of errors in the parameter info definition.
15805 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
15806 type parameters here.
15808 * cs-parser.jay (class_declaration): report errors for parameters
15811 2003-01-21 Miguel de Icaza <miguel@ximian.com>
15813 * generic.cs: New file, contains support code for generics.
15815 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
15816 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
15818 Update parser for the above removals.
15820 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
15821 now taken care of in the parser.
15823 2003-04-02 Miguel de Icaza <miguel@ximian.com>
15825 * class.cs (Event.Define): Do not allow abstract events to have
15828 2003-04-01 Miguel de Icaza <miguel@ximian.com>
15830 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
15831 block in event declarations.
15833 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
15834 value type, get its address.
15836 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
15837 leaving a class on the stack instead of a boolean value (int
15838 0/1). Change the code so we compare against null, and then the
15839 result against zero.
15841 * class.cs (TypeContainer.GetClassBases): We were checking for the
15842 parent class being sealed too late.
15844 * expression.cs (Binary.Emit): For <= and >= when dealing with
15845 floating point values, use cgt.un and clt.un instead of cgt and
15848 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
15850 * statement.cs: Apply the same optimization as MS: skip the
15851 GetEnumerator returning an IEnumerator, and use the one returning a
15852 CharEnumerator instead. This allows us to avoid the try-finally block
15855 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
15857 * cs-parser.jay: Attributes cannot be applied to
15858 namespaces. Fixes #40473
15860 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15863 (Add*): check if the name is valid using the full name for constants,
15864 fields, properties and events.
15866 2003-03-28 Miguel de Icaza <miguel@ximian.com>
15868 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
15869 char constants to be part of the enumeration.
15871 * expression.cs (Conditional.DoResolve): Add support for operator
15872 true. Implements the missing functionality from 14.12
15874 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
15875 operator true/false as required by the spec.
15877 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
15878 implicit conversion to boolean.
15880 * statement.cs (Statement.ResolveBoolean): A boolean expression is
15881 also one where the type implements `operator true'.
15883 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
15884 get an expression that will invoke operator true based on an
15887 (GetConversionOperators): Removed the hack that called op_True
15890 (Expression.ResolveBoolean): Move this from Statement.
15892 2003-03-17 Miguel de Icaza <miguel@ximian.com>
15894 * ecore.cs (FieldExpr): do not allow initialization of initonly
15895 fields on derived classes
15897 2003-03-13 Martin Baulig <martin@ximian.com>
15899 * statement.cs (Block.Emit): Call ig.BeginScope() and
15900 ig.EndScope() when compiling with debugging info; call
15901 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
15903 2003-03-08 Miguel de Icaza <miguel@ximian.com>
15905 * expression.cs (Indexers): Do not construct immediately, allow
15906 for new members to be appended as we go. Fixes 38143
15908 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15910 * expression.cs: save/restore context when resolving an unchecked
15913 2003-03-05 Miguel de Icaza <miguel@ximian.com>
15915 * cfold.cs: Catch division by zero in modulus operator during
15918 2003-03-03 Miguel de Icaza <miguel@ximian.com>
15920 * interface.cs (Interface.DefineMembers): Avoid defining members
15923 2003-02-27 Miguel de Icaza <miguel@ximian.com>
15925 * driver.cs: handle the +/- options for -noconfig
15927 * statement.cs (Unckeched.Resolve): Also track the state of
15928 unchecked in the Resolve phase.
15930 2003-02-27 Martin Baulig <martin@ximian.com>
15932 * ecore.cs (Expression.MemberLookup): Don't create a
15933 MethodGroupExpr for something which is not a method. Fixes #38291.
15935 2003-02-25 Miguel de Icaza <miguel@ximian.com>
15937 * class.cs (MemberBase.CheckParameters): Also check that the type
15938 is unmanaged if it is a pointer.
15940 * expression.cs (SizeOf.Resolve): Add location information.
15942 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
15943 a managed type is declared.
15945 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
15946 parameter modifiers as well. Fixes bug 38606
15948 * class.cs: Very sad. Am backing out the speed up changes
15949 introduced by the ArrayList -> Array in the TypeContainer, as they
15950 were not actually that much faster, and introduced a bug (no error
15951 reports on duplicated methods).
15953 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
15954 source first, this will guarantee that we have a valid expression
15955 before calling in lower levels functions that will require a
15956 resolved object. Then use this original_source in the
15957 target.ResolveLValue instead of the original source that was
15960 Another change. Use target.Resolve instead of LValueResolve.
15961 Although we are resolving for LValues, we will let the Assign code
15962 take care of that (it will be called again from Resolve). This
15963 basically allows code like this:
15965 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
15966 class Y { void A (X x) { x [0] += o; }
15968 The problem was that the indexer was trying to resolve for
15969 set_Item (idx, object o) and never finding one. The real set_Item
15970 was set_Item (idx, X). By delaying the process we get the right
15975 2003-02-23 Martin Baulig <martin@ximian.com>
15977 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
15978 while calling DoEmit ().
15980 * codegen.cs (EmitContext.Mark): Don't mark locations in other
15981 source files; if you use the #line directive inside a method, the
15982 compiler stops emitting line numbers for the debugger until it
15983 reaches the end of the method or another #line directive which
15984 restores the original file.
15986 2003-02-23 Martin Baulig <martin@ximian.com>
15988 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
15990 2003-02-23 Martin Baulig <martin@ximian.com>
15992 * statement.cs (Block.AddChildVariableNames): We need to call this
15993 recursively, not just for our immediate children.
15995 2003-02-23 Martin Baulig <martin@ximian.com>
15997 * class.cs (Event.Define): Always make the field private, like csc does.
15999 * typemanager.cs (TypeManager.RealMemberLookup): Make events
16000 actually work, fixes bug #37521.
16002 2003-02-23 Miguel de Icaza <miguel@ximian.com>
16004 * delegate.cs: When creating the various temporary "Parameters"
16005 classes, make sure that we call the ComputeAndDefineParameterTypes
16006 on those new parameters (just like we do with the formal ones), to
16007 allow them to be resolved in the context of the DeclSpace.
16009 This fixes the bug that Dick observed in Bugzilla #38530.
16011 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16013 * expression.cs (ResolveMemberAccess): When resolving a constant,
16014 do not attempt to pull a constant if the value was not able to
16015 generate a valid constant.
16017 * const.cs (LookupConstantValue): Do not report more errors than required.
16019 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16021 * expression.cs: fixes bug #38328.
16023 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16025 * class.cs: Changed all the various members that can be part of a
16026 class from being an ArrayList to be an Array of the right type.
16027 During the DefineType type_list, interface_list, delegate_list and
16028 enum_list are turned into types, interfaces, delegates and enums
16031 And during the member population, indexer_list, event_list,
16032 constant_list, field_list, instance_constructor_list, method_list,
16033 operator_list and property_list are turned into their real arrays.
16035 Although we could probably perform this operation earlier, for
16036 good error reporting we need to keep the lists and remove the
16037 lists for longer than required.
16039 This optimization was triggered by Paolo profiling the compiler
16040 speed on the output of `gen-sample-program.pl' perl script.
16042 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16043 not crash in methods like MemberLookupFailed that use this field.
16045 This problem arises when the compiler fails to resolve a type
16046 during interface type definition for example.
16048 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16050 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16051 inherit from System.Object, so we have to stop at null, not only
16052 when reaching System.Object.
16054 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16056 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16057 DeclaredOnly because the parent indexer might have had a different
16058 name, but did not loop until the top of the hierarchy was reached.
16060 The problem this one fixes is 35492: when a class implemented an
16061 indexer from an interface, we were getting the interface method
16062 (which was abstract) and we were flagging an error (can not invoke
16065 This also keeps bug 33089 functioning, and test-148 functioning.
16067 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16068 out if a method is special is to see if it is declared in a
16069 property or event, or whether it is one of the predefined operator
16070 names. This should fix correctly #36804.
16072 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16074 The goal here is to remove the dependency on EmptyCast.Peel ().
16075 Killing it completely.
16077 The problem is that currently in a number of places where
16078 constants are expected, we have to "probe" for an EmptyCast, and
16079 Peel, which is not the correct thing to do, as this will be
16080 repetitive and will likely lead to errors.
16082 The idea is to remove any EmptyCasts that are used in casts that
16083 can be reduced to constants, so we only have to cope with
16086 This bug hunt was triggered by Bug 37363 and the desire to remove
16087 the duplicate pattern where we were "peeling" emptycasts to check
16088 whether they were constants. Now constants will always be
16091 * ecore.cs: Use an enumconstant here instead of wrapping with
16094 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16095 throwing me off. By handling this we can get rid of a few hacks.
16097 * statement.cs (Switch): Removed Peel() code.
16099 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16101 * class.cs: Location information for error 508
16103 * expression.cs (New.DoResolve): Add a guard against double
16104 resolution of an expression.
16106 The New DoResolve might be called twice when initializing field
16107 expressions (see EmitFieldInitializers, the call to
16108 GetInitializerExpression will perform a resolve on the expression,
16109 and later the assign will trigger another resolution
16111 This leads to bugs (#37014)
16113 * delegate.cs: The signature for EndInvoke should contain any ref
16114 or out parameters as well. We were not doing this in the past.
16116 * class.cs (Field.Define): Do not overwrite the type definition
16117 inside the `volatile' group. Turns out that volatile enumerations
16118 were changing the type here to perform a validity test, which
16121 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16123 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16124 and structs, we do not want to load the instance variable
16126 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16127 enum_type has to be handled like an object reference (implicit
16128 conversions exists from this to object), but the regular IsClass
16129 and IsValueType tests will never return true for this one.
16131 Also we use TypeManager.IsValueType instead of type.IsValueType,
16132 just for consistency with the rest of the code (this is only
16133 needed if we ever use the construct exposed by test-180.cs inside
16134 corlib, which we dont today).
16136 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16138 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16141 2003-02-09 Martin Baulig <martin@ximian.com>
16143 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16144 (Namespace.DefineNamespaces): New static public method; this is
16145 called when we're compiling with debugging to add all namespaces
16146 to the symbol file.
16148 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16149 pass it to the Namespace's .ctor.
16151 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16152 and MethodBase arguments; pass the namespace ID to the symwriter;
16153 pass the MethodBase instead of the token to the symwriter.
16154 (SymbolWriter.DefineNamespace): New method to add a namespace to
16157 2003-02-09 Martin Baulig <martin@ximian.com>
16159 * symbolwriter.cs: New file. This is a wrapper around
16160 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16161 methods here in near future.
16163 2003-02-09 Martin Baulig <martin@ximian.com>
16165 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16166 ILGenerator.MarkSequencePoint() which are actually used by the
16169 2003-02-09 Martin Baulig <martin@ximian.com>
16171 * location.cs (SourceFile): New public sealed class. This
16172 contains the name and an index which is used in the location's token.
16173 (Location): Reserve an appropriate number of bits in the token for
16174 the source file instead of walking over that list, this gives us a
16175 really huge performance improvement when compiling with debugging.
16177 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16178 `SourceFile' argument instead of a string.
16179 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16180 but don't parse/tokenize here, we need to generate the list of all
16181 source files before we do that.
16182 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16185 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16186 instead of a string.
16188 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16191 2003-02-09 Martin Baulig <martin@ximian.com>
16193 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16194 filename on `#line default'.
16196 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16198 * statement.cs: don't clear the pinned var when the fixed statement
16199 returns from the method (fixes bug#37752).
16201 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16203 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16206 2003-02-07 Martin Baulig <martin@ximian.com>
16208 * driver.cs: Removed the `--debug-args' command line argument.
16210 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16211 automatically by the AsssemblyBuilder.
16212 (CodeGen.InitializeSymbolWriter): We don't need to call any
16213 initialization function on the symbol writer anymore. This method
16214 doesn't take any arguments.
16216 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16218 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16219 from referenced assemblies as well.
16221 2003-02-02 Martin Baulig <martin@ximian.com>
16223 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16225 2003-02-02 Martin Baulig <martin@ximian.com>
16227 * class.cs (Constructor.Emit): Open the symbol writer before
16228 emitting the constructor initializer.
16229 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16230 single-stepping through constructor initializers.
16232 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16234 * class.cs: Handle error 549: do not allow virtual methods in
16237 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16239 * decl.cs: Check access levels when resolving types
16241 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16243 * statement.cs: Add parameters and locals set in catch blocks that might
16244 return to set vector
16246 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16248 * class.cs (Operator): Set the SpecialName flags for operators.
16250 * expression.cs (Invocation.DoResolve): Only block calls to
16251 accessors and operators on SpecialName methods.
16253 (Cast.TryReduce): Handle conversions from char constants.
16256 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16258 * statement.cs: small memory and time optimization in FlowBranching.
16260 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16262 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16263 problem that the last fix but in the other sid (Set).
16265 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16266 access when there is no indexer in the hierarchy.
16268 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16270 * class.cs: Combine some if statements.
16272 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16274 * driver.cs: fixed bug #37187.
16276 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16278 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16279 any indexer, it's needed to build a list with all the indexers in the
16280 hierarchy (AllGetters), else we have problems. Fixes #35653.
16282 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16284 * class.cs (MethodData.Define): It is wrong for an interface
16285 implementation to be static in both cases: explicit and implicit.
16286 We were only handling this in one case.
16288 Improve the if situation there to not have negations.
16290 * class.cs (Field.Define): Turns out that we do not need to check
16291 the unsafe bit on field definition, only on usage. Remove the test.
16293 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16295 * driver.cs: use assembly.Location instead of Codebase (the latest
16296 patch made mcs fail when using MS assemblies).
16298 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16300 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16301 get the path to *corlib.dll.
16303 2003-01-21 Nick Drochak <ndrochak@gol.com>
16307 * typemanager.cs: Remove compiler warnings
16309 2003-01-20 Duncan Mak <duncan@ximian.com>
16311 * AssemblyInfo.cs: Bump the version number to 0.19.
16313 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16315 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16317 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16319 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16321 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16323 * cs-parser.jay: Small fix: we were not comparing the constructor
16324 name correctly. Thanks to Zoltan for the initial pointer.
16326 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16328 * cs-tokenizer.cs: Set file name when specified with #line
16330 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16332 * cs-parser.jay: Only perform the constructor checks here if we
16333 are named like the class; This will help provider a better
16334 error. The constructor path is taken when a type definition is
16335 not found, but most likely the user forgot to add the type, so
16336 report that rather than the constructor error.
16338 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16340 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16343 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16345 * cs-parser.jay: Add cleanup call.
16347 2003-01-13 Duncan Mak <duncan@ximian.com>
16349 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16350 consistent with other methods.
16352 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16354 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16356 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16358 * attribute.cs: only set GuidAttr to true when we have a
16361 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16365 * typemanager.cs: fixes to allow mcs compile corlib with the new
16366 Type.IsSubclassOf fix.
16368 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16370 * expression.cs (LocalVariableReference.DoResolve): Classify a
16371 constant as a value, not as a variable. Also, set the type for
16374 * cs-parser.jay (fixed_statement): take a type instead of a
16375 pointer_type, so we can produce a better error message later.
16377 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16380 (For.DoEmit): Make inifinite loops have a
16381 non-conditional branch back.
16383 (Fixed.DoEmit): First populate the pinned variables, then emit the
16384 statement, then clear the variables. Before I was emitting the
16385 code once for each fixed piece.
16388 2003-01-08 Martin Baulig <martin@ximian.com>
16390 * statement.cs (FlowBranching.MergeChild): A break in a
16391 SWITCH_SECTION does not leave a loop. Fixes #36155.
16393 2003-01-08 Martin Baulig <martin@ximian.com>
16395 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16396 lives in the same number space than `param_map'. Fixes #36154.
16398 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16400 * cs-parser.jay (constructor_declaration): Set the
16401 Constructor.ModFlags before probing for it. This makes the
16402 compiler report 514, 515 and 132 (the code was there, but got
16405 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16406 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16407 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16409 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16411 * enum.cs: create the enum static fields using the enum type.
16413 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16415 * class.cs: don't try to create the ParamBuilder for the return
16416 type if it's not needed (and handle it breaking for the ms runtime
16419 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16421 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16423 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16425 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16426 the command. This showed up while compiling the JANET source
16427 code, which used \r as its only newline separator.
16429 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16431 * class.cs (Method.Define): If we are an operator (because it
16432 reuses our code), then set the SpecialName and HideBySig. #36128
16434 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16436 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16437 exception, report error 120 `object reference required'.
16439 * driver.cs: Add --pause option, used during to measure the size
16440 of the process as it goes with --timestamp.
16442 * expression.cs (Invocation.DoResolve): Do not allow methods with
16443 SpecialName to be invoked.
16445 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16447 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16448 number before adding it.
16450 2002-12-21 Ravi Pratap <ravi@ximian.com>
16452 * ecore.cs (StandardImplicitConversion): When in an unsafe
16453 context, we allow conversion between void * to any other pointer
16454 type. This fixes bug #35973.
16456 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16458 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16459 is not thrown when extensionless outputs are used
16461 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16463 * rootcontext.cs: fixed compilation of corlib.
16465 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16467 * attribute.cs (Attributes.Contains): Add new method.
16469 * class.cs (MethodCore.LabelParameters): if the parameter is an
16470 `out' parameter, check that no attribute `[In]' has been passed.
16472 * enum.cs: Handle the `value__' name in an enumeration.
16474 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16476 * decl.cs: Added special case to allow overrides on "protected
16479 2002-12-18 Ravi Pratap <ravi@ximian.com>
16481 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16482 since it makes much more sense.
16484 (Attributes.ctor): Don't require a Location parameter.
16486 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16488 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16489 since we already have that information per attribute.
16491 * everywhere : make appropriate changes.
16493 * class.cs (LabelParameters): Write the code which actually
16494 applies attributes to the return type. We can't do this on the MS
16495 .NET runtime so we flag a warning in the case an exception is
16498 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16500 * const.cs: Handle implicit null conversions here too.
16502 2002-12-17 Ravi Pratap <ravi@ximian.com>
16504 * class.cs (MethodCore.LabelParameters): Remove the extra
16505 Type [] parameter since it is completely unnecessary. Instead
16506 pass in the method's attributes so that we can extract
16507 the "return" attribute.
16509 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16511 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16512 of ignoring it and letting the compile continue.
16514 * typemanager.cs (ChangeType): use an extra argument to return an
16515 error condition instead of throwing an exception.
16517 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16519 * expression.cs (Unary.TryReduce): mimic the code for the regular
16520 code path. Perform an implicit cast in the cases where we can
16521 implicitly convert to one of the integral types, and then reduce
16522 based on that constant. This fixes bug #35483.
16524 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16526 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16528 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16530 * namespace.cs: fixed bug #35489.
16532 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16534 * class.cs: Remove some dead code.
16536 * cs-parser.jay: Estimate the number of methods needed
16537 (RootContext.MethodCount);
16539 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16540 numbers instead of StringBuilders.
16542 * support.cs (PtrHashtable): Add constructor with initial size;
16543 We can now reduce reallocations of the method table.
16545 2002-12-10 Ravi Pratap <ravi@ximian.com>
16547 * attribute.cs (ApplyAttributes): Keep track of the emitted
16548 attributes on a per-target basis. This fixes bug #35413.
16550 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16552 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16553 default to the Windows 1252 encoding.
16555 (UnixParseOption): Support version, thanks to Alp for the missing
16558 * AssemblyInfo.cs: Add nice assembly information.
16560 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16563 * cs-parser.jay: Allow a trailing comma before the close bracked
16564 in the attribute_section production.
16566 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16567 address of the instance was being taken, I will take this out,
16568 because we take the address of the object immediately here.
16570 2002-12-09 Ravi Pratap <ravi@ximian.com>
16572 * typemanager.cs (AreMultipleAllowed): Take care of the most
16573 obvious case where attribute type is not in the current assembly -
16576 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16578 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16579 definitions, instead of doing that afterwards.
16581 Also we use a nice little hack, depending on the constructor, we
16582 know if we are a "composed" name or a simple name. Hence, we
16583 avoid the IndexOf test, and we avoid
16585 * codegen.cs: Add code to assist in a bug reporter to track down
16586 the source of a compiler crash.
16588 2002-12-07 Ravi Pratap <ravi@ximian.com>
16590 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16591 types have been emitted for a given element and flag an error
16592 if something which does not have AllowMultiple set is used more
16595 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16596 attribute types and their corresponding AllowMultiple properties
16598 (AreMultipleAllowed): Check the property for a given type.
16600 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16601 property in the case we have a TypeContainer.
16603 (Attributes.AddAttribute): Detect duplicates and just skip on
16604 adding them. This trivial fix catches a pretty gross error in our
16605 attribute emission - global attributes were being emitted twice!
16607 Bugzilla bug #33187 is now fixed.
16609 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16611 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16612 instead of pp_and).
16614 * expression.cs (Binary.ResolveOperator): I can only use the
16615 Concat (string, string, string) and Concat (string, string,
16616 string, string) if the child is actually a concatenation of
16619 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16621 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16622 context where we need a 2-character lookahead.
16624 * pending.cs (PendingImplementation): Rework so we can keep track
16625 of interface types all the time, and flag those which were
16626 implemented by parents as optional.
16628 2002-12-03 Miguel de Icaza <miguel@ximian.com>
16630 * expression.cs (Binary.ResolveOperator): Use
16631 String.Concat(string,string,string) or
16632 String.Concat(string,string,string,string) when possible.
16634 * typemanager: More helper methods.
16637 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
16639 * pending.cs: remove the bogus return from GetMissingInterfaces()
16640 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
16642 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16644 * namespace.cs: avoid duplicated 'using xxx' being added to
16645 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
16646 when we get more than one 'using' statement for the same namespace.
16647 Report a CS0105 warning for it.
16649 2002-11-30 Miguel de Icaza <miguel@ximian.com>
16651 * cs-tokenizer.cs (consume_identifier): use read directly, instead
16652 of calling getChar/putback, uses internal knowledge of it.
16654 (xtoken): Reorder tokenizer so most common patterns are checked
16655 first. This reduces the compilation time in another 5% (from 8.11s
16656 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
16658 The parsing time is 22% of the compilation in mcs, and from that
16659 64% is spent on the tokenization process.
16661 I tried using a binary search for keywords, but this is slower
16662 than the hashtable. Another option would be to do a couple of
16665 * Not use a StringBuilder, instead use an array of chars,
16666 with a set value. Notice that this way we could catch
16667 the 645 error without having to do it *afterwards*.
16669 * We could write a hand-parser to avoid the hashtable
16670 compares altogether.
16672 The identifier consumption process takes 37% of the tokenization
16673 time. Another 15% is spent on is_number. 56% of the time spent
16674 on is_number is spent on Int64.Parse:
16676 * We could probably choose based on the string length to
16677 use Int32.Parse or Int64.Parse and avoid all the 64-bit
16680 Another 3% is spend on wrapping `xtoken' in the `token' function.
16682 Handle 0xa0 as whitespace (#34752)
16684 2002-11-26 Miguel de Icaza <miguel@ximian.com>
16686 * typemanager.cs (IsCLRType): New routine to tell whether a type
16687 is one of the builtin types.
16689 Maybe it needs to use TypeCodes to be faster. Maybe we could use
16690 typecode in more places instead of doing pointer comparissions.
16691 We could leverage some knowledge about the way the typecodes are
16694 New code to cache namespaces in assemblies, it is currently not
16695 invoked, to be used soon.
16697 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
16699 * expression.cs (Binary.ResolveOperator): specially handle
16700 strings, and do not perform user-defined operator overloading for
16703 2002-11-24 Miguel de Icaza <miguel@ximian.com>
16705 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
16706 internalcall as it is a pretty simple operation; Avoid whenever
16707 possible to call Char.IsLetter.
16709 (consume_identifier): Cut by half the number of
16710 hashtable calls by merging the is_keyword and GetKeyword behavior.
16712 Do not short-circuit, because if we do, we
16713 report errors (ie, #if false && true would produce an invalid
16717 2002-11-24 Martin Baulig <martin@ximian.com>
16719 * expression.cs (Cast.TryReduce): If we're in checked syntax,
16720 check constant ranges and report a CS0221. Fixes #33186.
16722 2002-11-24 Martin Baulig <martin@ximian.com>
16724 * cs-parser.jay: Make this work for uninitialized variable
16725 declarations in the `for' initializer. Fixes #32416.
16727 2002-11-24 Martin Baulig <martin@ximian.com>
16729 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
16730 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
16732 2002-11-24 Martin Baulig <martin@ximian.com>
16734 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
16735 argument; if true, we also check for user-defined conversions.
16736 This is only needed if both arguments are of a user-defined type.
16737 Fixes #30443, added test-175.cs.
16738 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
16740 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
16742 2002-11-24 Martin Baulig <martin@ximian.com>
16744 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
16745 function to get the store opcode.
16746 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
16747 only emit the Ldelema if the store opcode is Stobj. You must run
16748 both test-34 and test-167 to test this. Fixes #34529.
16750 2002-11-23 Martin Baulig <martin@ximian.com>
16752 * ecore.cs (Expression.MemberLookup): Added additional
16753 `qualifier_type' argument which is used when we're being called
16754 from MemberAccess.DoResolve() and null if we're called from a
16756 (Expression.MemberLookupFailed): New method to report errors; this
16757 does the CS1540 check and reports the correct error message.
16759 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
16760 argument for the CS1540 check and redone the way how we're dealing
16761 with private members. See the comment in the source code for details.
16762 (FilterWithClosure): Reverted this back to revision 1.197; renamed
16763 `closure_start_type' to `closure_qualifier_type' and check whether
16764 it's not null. It was not this filter being broken, it was just
16765 being called with the wrong arguments.
16767 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
16768 and pass it the correct `qualifier_type'; this also does the error
16771 2002-11-22 Miguel de Icaza <miguel@ximian.com>
16773 * expression.cs (Invocation.EmitParams): If the we are dealing
16774 with a non-built-in value type, load its address as well.
16776 (ArrayCreation): Use a a pretty constant instead
16777 of the hardcoded value 2. Use 6 instead of 2 for the number of
16778 static initializers.
16780 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
16781 because they are not really value types, just glorified integers.
16783 * driver.cs: Do not append .exe, the CSC compiler does not do it.
16785 * ecore.cs: Remove redundant code for enumerations, make them use
16786 the same code path as everything else, fixes the casting issue
16787 with enumerations in Windows.Forms.
16789 * attribute.cs: Do only cast to string if it is a string, the
16790 validation happens later.
16792 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
16793 people upgrade their corlibs.
16795 * ecore.cs: Oops, enumerations were not following the entire code path
16797 2002-11-21 Miguel de Icaza <miguel@ximian.com>
16799 * typemanager.cs (FilterWithClosure): Commented out the test for
16800 1540 in typemanager.cs, as it has problems when accessing
16801 protected methods from a parent class (see test-174.cs).
16803 * attribute.cs (Attribute.ValidateGuid): new method.
16804 (Attribute.Resolve): Use above.
16806 2002-11-19 Miguel de Icaza <miguel@ximian.com>
16808 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
16810 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
16811 handling for enumerations, as we only needed the TypeContainer
16812 functionality to begin with (this is required for the fix below to
16813 work for enums that reference constants in a container class for
16816 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
16818 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
16819 a valid TypeBuilder to perform lookups on.o
16821 * class.cs (InheritableMemberSignatureCompare): Use true in the
16822 call to GetGetMethod and GetSetMethod, because we are comparing
16823 the signature, and we need to get the methods *even* if they are
16826 (PropertyBase.CheckBase): ditto.
16828 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
16829 GotoCase.Resolve): Use Peel on EmpytCasts.
16831 * ecore.cs (EmptyCast): drop child, add Peel method.
16833 2002-11-17 Martin Baulig <martin@ximian.com>
16835 * ecore.cs (EmptyCast.Child): New public property.
16837 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
16838 label resolved to an EmptyCast. Fixes #34162.
16839 (GotoCase.Resolve): Likewise.
16840 (Block.EmitMeta): Likewise.
16842 2002-11-17 Martin Baulig <martin@ximian.com>
16844 * expression.cs (Invocation.BetterConversion): Prefer int over
16845 uint; short over ushort; long over ulong for integer literals.
16846 Use ImplicitConversionExists instead of StandardConversionExists
16847 since we also need to check for user-defined implicit conversions.
16848 Fixes #34165. Added test-173.cs.
16850 2002-11-16 Martin Baulig <martin@ximian.com>
16852 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
16853 with the `true' and `false' literals. Fixes #33151.
16855 2002-11-16 Martin Baulig <martin@ximian.com>
16857 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
16858 October 22nd; don't do the cs1540 check for static members.
16860 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
16861 now using our own filter here and doing the cs1540 check again.
16863 2002-11-16 Martin Baulig <martin@ximian.com>
16865 * support.cs (InternalParameters): Don't crash if we don't have
16866 any fixed parameters. Fixes #33532.
16868 2002-11-16 Martin Baulig <martin@ximian.com>
16870 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
16871 when looking up static methods to make this work on Windows.
16874 2002-11-16 Martin Baulig <martin@ximian.com>
16876 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
16877 a setter rather than using PropertyInfo.CanWrite.
16879 2002-11-15 Nick Drochak <ndrochak@gol.com>
16881 * class.cs: Allow acces to block member by subclasses. Fixes build
16884 2002-11-14 Martin Baulig <martin@ximian.com>
16886 * class.cs (Constructor.Emit): Added the extern/block check.
16889 2002-11-14 Martin Baulig <martin@ximian.com>
16891 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
16892 iteration while looking for indexers, this is needed because the
16893 indexer may have a different name in our base classes. Fixed the
16894 error reporting (no indexers at all, not get accessor, no
16895 overloaded match). Fixes bug #33089.
16896 (IndexerAccess.DoResolveLValue): Likewise.
16898 2002-11-14 Martin Baulig <martin@ximian.com>
16900 * class.cs (PropertyBase.CheckBase): Make this work for multiple
16901 indexers. Fixes the first part of bug #33089.
16902 (MethodSignature.InheritableMemberSignatureCompare): Added support
16905 2002-11-13 Ravi Pratap <ravi@ximian.com>
16907 * attribute.cs (Attribute.Resolve): Catch the
16908 NullReferenceException and report it since it isn't supposed to
16911 2002-11-12 Miguel de Icaza <miguel@ximian.com>
16913 * expression.cs (Binary.EmitBranchable): Also handle the cases for
16914 LogicalOr and LogicalAnd that can benefit from recursively
16915 handling EmitBranchable. The code now should be nice for Paolo.
16917 2002-11-08 Miguel de Icaza <miguel@ximian.com>
16919 * typemanager.cs (LookupType): Added a negative-hit hashtable for
16920 the Type lookups, as we perform quite a number of lookups on
16921 non-Types. This can be removed once we can deterministically tell
16922 whether we have a type or a namespace in advance.
16924 But this might require special hacks from our corlib.
16928 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
16929 and double which avoids a conversion from an integer to a double.
16931 * expression.cs: tiny optimization, avoid calling IsConstant,
16932 because it effectively performs the lookup twice.
16934 2002-11-06 Miguel de Icaza <miguel@ximian.com>
16936 But a bogus return here to keep the semantics of the old code
16937 until the Mono runtime is fixed.
16939 * pending.cs (GetMissingInterfaces): New method used to remove all
16940 the interfaces that are already implemented by our parent
16941 classes from the list of pending methods.
16943 * interface.cs: Add checks for calls after ResolveTypeExpr.
16945 2002-11-05 Miguel de Icaza <miguel@ximian.com>
16947 * class.cs (Class.Emit): Report warning 67: event not used if the
16948 warning level is beyond 3.
16950 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
16951 being a NullLiteral.
16953 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
16956 * class.cs (TypeContainer.GetClassBases): Cover a missing code
16957 path that might fail if a type can not be resolved.
16959 * expression.cs (Binary.Emit): Emit unsigned versions of the
16962 * driver.cs: use error 5.
16964 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
16966 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
16968 2002-11-01 Miguel de Icaza <miguel@ximian.com>
16970 * cs-parser.jay (switch_section): A beautiful patch from Martin
16971 Baulig that fixed 33094.
16973 2002-10-31 Miguel de Icaza <miguel@ximian.com>
16975 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
16976 Check whether the base is abstract and report an error if so.
16978 * expression.cs (IndexerAccess.DoResolveLValue,
16979 IndexerAccess.DoResolve): ditto.
16981 (Invocation.DoResolve): ditto.
16983 (Invocation.FullMethodDesc): Improve the report string.
16985 * statement.cs (Block): Eliminate IsVariableDefined as it is
16986 basically just a wrapper for GetVariableInfo.
16988 * ecore.cs (SimpleName): Use new
16990 * support.cs (ReflectionParamter.ParameterType): We unwrap the
16991 type, as we return the actual parameter ref/unref state on a
16994 2002-10-30 Miguel de Icaza <miguel@ximian.com>
16996 * support.cs: Return proper flags REF/OUT fixing the previous
16999 * expression.cs: Reverted last patch, that was wrong. Is_ref is
17000 not used to mean `ref' but `ref or out' in ParameterReference
17002 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
17003 full type signature instead of calling TypeManger.CSharpName
17006 * support.cs (InternalParameters.ParameterDesc): Do not compare
17007 directly to the modflags, because REF/OUT will actually be bitsets
17010 * delegate.cs (VerifyMethod): Check also the modifiers.
17012 * cs-tokenizer.cs: Fix bug where floating point values with an
17013 exponent where a sign was missing was ignored.
17015 * driver.cs: Allow multiple assemblies to be specified in a single
17018 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17020 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17021 because identifiers after a parenthesis would end up in this kind
17022 of production, and we needed to desamiguate it for having casts
17025 (UserDefinedType *) xxx
17027 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17029 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17030 we should set on the Bindingflags.NonPublic, but not turn on
17031 private_ok. private_ok controls whether a Private member is
17032 returned (this is chekced on the filter routine), while the
17033 BindingFlags.NonPublic just controls whether private/protected
17034 will be allowed. This fixes the problem part of the problem of
17035 private properties being allowed to be used in derived classes.
17037 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17038 so we can call the children DoResolveLValue method (this will
17039 properly signal errors on lvalue assignments to base properties)
17041 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17042 getter are null, and we have a property info, we know that this
17043 happened because the lookup failed, so we report an error 122 for
17044 protection level violation.
17046 We also silently return if setter and getter are null in the
17047 resolve functions, this condition only happens if we have flagged
17048 the error before. This is the other half of the problem.
17050 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17051 not have accessibility information, that is why we were returning
17052 true in the filter function in typemanager.cs.
17054 To properly report 122 (property is inaccessible because of its
17055 protection level) correctly, we report this error in ResolveAccess
17056 by failing if both the setter and the getter are lacking (ie, the
17059 DoResolve and DoLResolve have been modified to check for both
17060 setter/getter being null and returning silently, the reason being
17061 that I did not want to put the knowledge about this error in upper
17064 int old = Report.Errors;
17065 x = new PropertyExpr (...);
17066 if (old != Report.Errors)
17071 So the property expr is returned, but it is invalid, so the error
17072 will be flagged during the resolve process.
17074 * class.cs: Remove InheritablePropertySignatureCompare from the
17075 class, as we no longer depend on the property signature to compute
17076 whether it is possible to implement a method or not.
17078 The reason is that calling PropertyInfo.GetGetMethod will return
17079 null (in .NET, in Mono it works, and we should change this), in
17080 cases where the Get Method does not exist in that particular
17085 class X { public virtual int A { get { return 1; } } }
17087 class Z : Y { public override int A { get { return 2; } } }
17089 Would fail in Z because the parent (Y) would not have the property
17090 defined. So we avoid this completely now (because the alternative
17091 fix was ugly and slow), and we now depend exclusively on the
17094 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17095 reference method, instead of using the property.
17097 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17098 routines are gone now.
17100 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17101 names, they were incorrectly named.
17103 * cs-tokenizer.cs: Return are more gentle token on failure.
17105 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17106 had an out-of-sync index variable, which caused it to remove from
17107 the list of pending methods the wrong method sometimes.
17109 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17111 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17112 CanWrite, because those refer to this particular instance of the
17113 property, and do not take into account the fact that we can
17114 override single members of a property.
17116 Constructor requires an EmitContext. The resolution process does
17117 not happen here, but we need to compute the accessors before,
17118 because the resolution does not always happen for properties.
17120 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17121 subclass, before we did not update this flag, but we did update
17124 (GetAccessors): Drop this routine, as it did not work in the
17125 presence of partially overwritten set/get methods.
17127 Notice that this broke the cs1540 detection, but that will require
17130 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17134 * driver.cs: issue a warning instead of an error if we don't support
17135 debugging for the platform. Also ignore a couple of errors that may
17136 arise when trying to write the symbols. Undo my previous patch.
17138 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17140 * driver.cs: ignore /debug switch except for Unix platforms.
17142 2002-10-23 Nick Drochak <ndrochak@gol.com>
17144 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17146 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17148 * driver.cs: Do not make mcs-debug conditional, so we do not break
17149 builds that use it.
17151 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17152 review this patch. But basically after all the children variables
17153 have been merged, the value of "Breaks" was not being set to
17154 new_breaks for Switch blocks. I think that it should be set after
17155 it has executed. Currently I set this to the value of new_breaks,
17156 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17157 conservative, but I do not understand this code very well.
17159 I did not break anything in the build, so that is good ;-)
17161 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17163 2002-10-20 Mark Crichton <crichton@gimp.org>
17165 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17167 2002-10-20 Nick Drochak <ndrochak@gol.com>
17169 * cfold.cs: Fixed compile blocker.
17171 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17173 * driver.cs: I was chekcing the key, not the file.
17175 2002-10-19 Ravi Pratap <ravi@ximian.com>
17177 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17178 message that we were generating - we just need to silently return
17181 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17183 * class.cs (Event.Define): Change my previous commit, as this
17184 breaks the debugger. This is a temporary hack, as it seems like
17185 the compiler is generating events incorrectly to begin with.
17187 * expression.cs (Binary.ResolveOperator): Added support for
17188 "U operator - (E x, E y)"
17190 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17193 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17194 init-only variables, but this path did not take into account that
17195 there might be also instance readonly variables. Correct this
17198 This fixes bug 32253
17200 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17203 * driver.cs: Change the extension for modules to `netmodule'
17205 * cs-parser.jay: Improved slightly the location tracking for
17206 the debugger symbols.
17208 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17209 modifiers that were specified instead of the hardcoded value
17210 (FamAndAssem). This was basically ignoring the static modifier,
17211 and others. Fixes 32429.
17213 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17214 fixed a bug in the process (32476)
17216 * expression.cs (ArrayAccess.EmitAssign): Patch from
17217 hwang_rob@yahoo.ca that fixes bug 31834.3
17219 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17221 * driver.cs: Make the module extension .netmodule.
17223 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17225 * driver.cs: Report an error if the resource file is not found
17226 instead of crashing.
17228 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17229 false, like Emit does.
17231 2002-10-16 Nick Drochak <ndrochak@gol.com>
17233 * typemanager.cs: Remove unused private member. Also reported mcs
17234 bug to report this as a warning like csc.
17236 2002-10-15 Martin Baulig <martin@gnome.org>
17238 * statement.cs (Statement.Emit): Made this a virtual method; emits
17239 the line number info and calls DoEmit().
17240 (Statement.DoEmit): New protected abstract method, formerly knows
17241 as Statement.Emit().
17243 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17245 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17247 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17248 have fixed a remaining problem: not every AddXXXX was adding a
17249 fully qualified name.
17251 Now everyone registers a fully qualified name in the DeclSpace as
17252 being defined instead of the partial name.
17254 Downsides: we are slower than we need to be due to the excess
17255 copies and the names being registered this way.
17257 The reason for this is that we currently depend (on the corlib
17258 bootstrap for instance) that types are fully qualified, because
17259 we dump all the types in the namespace, and we should really have
17260 types inserted into the proper namespace, so we can only store the
17261 basenames in the defined_names array.
17263 2002-10-10 Martin Baulig <martin@gnome.org>
17265 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17266 from bug #31834, see the bug report for a testcase which is
17269 2002-10-10 Martin Baulig <martin@gnome.org>
17271 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17272 flow analysis code for this.
17274 * statement.cs (Do, While, For): Tell the flow analysis code about
17276 (FlowBranching.UsageVector): Added support for infinite loops.
17277 (Block.Resolve): Moved the dead code elimination here and use flow
17280 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17282 * class.cs (Field.Define): Catch cycles on struct type
17285 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17286 fields if the fields are static. We only need to check instance
17289 * expression.cs (As.DoResolve): Test for reference type.
17291 * statement.cs (Using.ResolveExpression): Use
17292 ConvertImplicitRequired, not ConvertImplicit which reports an
17294 (Using.ResolveLocalVariableDecls): ditto.
17296 * expression.cs (Binary.ResolveOperator): Report errors in a few
17297 places where we had to.
17299 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17301 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17303 * expression.cs: Use StoreFromPtr instead of extracting the type
17304 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17306 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17307 an enumeration value to a System.Enum, but System.Enum is not a
17308 value type, but an class type, so we need to box.
17310 (Expression.ConvertExplicit): One codepath could return
17311 errors but not flag them. Fix this. Fixes #31853
17313 * parameter.cs (Resolve): Do not allow void as a parameter type.
17315 2002-10-06 Martin Baulig <martin@gnome.org>
17317 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17318 if it's a class type and not a struct. Fixes #31815.
17320 2002-10-06 Martin Baulig <martin@gnome.org>
17322 * statement.cs: Reworked the flow analysis code a bit to make it
17323 usable for dead code elimination.
17325 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17327 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17329 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17331 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17332 to fix the test 165, will investigate deeper.
17334 2002-10-04 Martin Baulig <martin@gnome.org>
17336 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17337 finally blocks actually work.
17338 (Try.Resolve): We don't need to create a sibling for `finally' if
17339 there is no finally block.
17341 2002-10-04 Martin Baulig <martin@gnome.org>
17343 * class.cs (Constructor.Define): The default accessibility for a
17344 non-default constructor is private, not public.
17346 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17348 * class.cs (Constructor): Make AllowedModifiers public, add
17351 * cs-parser.jay: Perform the modifiers test here, as the
17352 constructor for the Constructor class usually receives a zero
17353 because of the way we create it (first we create, later we
17354 customize, and we were never checking the modifiers).
17356 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17357 is a version of LookupTypeReflection that includes the type-name
17358 cache. This can be used as a fast path for functions that know
17359 the fully qualified name and are only calling into *.GetType() to
17360 obtain a composed type.
17362 This is also used by TypeManager.LookupType during its type
17365 (LookupType): We now also track the real type name, as sometimes
17366 we can get a quey for the real type name from things like
17367 ComposedCast. This fixes bug 31422.
17369 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17370 complete type fullname, it does not have to go through the type
17371 resolution system to obtain the composed version of the type (for
17372 obtaining arrays or pointers).
17374 (Conditional.Emit): Use the EmitBoolExpression to
17375 generate nicer code, as requested by Paolo.
17377 (ArrayCreation.CheckIndices): Use the patch from
17378 hwang_rob@yahoo.ca to validate the array initializers.
17380 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17382 * class.cs (ConstructorInitializer.Emit): simplify code by using
17383 Invocation.EmitCall, and at the same time, fix the bugs in calling
17384 parent constructors that took variable arguments.
17386 * ecore.cs (Expression.ConvertNumericExplicit,
17387 Expression.ImplicitNumericConversion): Remove the code that
17388 manually wrapped decimal (InternalTypeConstructor call is now gone
17391 * expression.cs (Cast.TryReduce): Also handle decimal types when
17392 trying to perform a constant fold on the type.
17394 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17396 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17397 that only turned off an error report, and did nothing else.
17399 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17401 * driver.cs: Handle and ignore /fullpaths
17403 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17405 * expression.cs (Binary.ResolveOperator): Catch the case where
17406 DoNumericPromotions returns true,
17408 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17410 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17412 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17415 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17417 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17418 conversion exists, but it is also required that the conversion be
17419 performed. This manifested in "(Type64Enum) 2".
17421 * class.cs (TypeManager.AddMethod): The fix is not to change
17422 AddEnum, because that one was using a fully qualified name (every
17423 DeclSpace derivative does), but to change the AddMethod routine
17424 that was using an un-namespaced name. This now correctly reports
17425 the duplicated name.
17427 Revert patch until I can properly fix it. The issue
17428 is that we have a shared Type space across all namespaces
17429 currently, which is wrong.
17431 Options include making the Namespace a DeclSpace, and merge
17432 current_namespace/current_container in the parser.
17434 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17436 * cs-parser.jay: Improve error reporting when we get a different
17437 kind of expression in local_variable_type and
17438 local_variable_pointer_type.
17440 Propagate this to avoid missleading errors being reported.
17442 * ecore.cs (ImplicitReferenceConversion): treat
17443 TypeManager.value_type as a target just like object_type. As
17448 Is valid, and needs to result in the int 1 being boxed before it
17449 is assigned to the value type v.
17451 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17452 to validate the enumeration name.
17454 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17455 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17456 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17458 * ecore.cs (TryImplicitIntConversion): When doing an
17459 implicit-enumeration-conversion, check if the type is 64-bits and
17460 perform a conversion before passing to EnumConstant.
17462 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17464 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17465 report ambiguous type references. Unlike the MS version, we
17466 report what the ambiguity is. Innovation at work ;-)
17468 (DeclSpace.FindType): Require a location argument to
17469 display when we display an ambiguous error.
17471 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17473 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17475 * expression.cs (EmitDynamicInitializers): Apply patch from
17476 hwang_rob@yahoo.ca that fixes the order in which we emit our
17479 2002-09-21 Martin Baulig <martin@gnome.org>
17481 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17482 delegate takes no arguments.
17484 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17486 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17489 * expression.cs: Extract the underlying type.
17491 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17493 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17495 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17497 * class.cs (TypeContainer.DefineType): We can not use the nice
17498 PackingSize with the size set to 1 DefineType method, because it
17499 will not allow us to define the interfaces that the struct
17502 This completes the fixing of bug 27287
17504 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17505 means also structs. This fixes part of the problem.
17506 (Expresion.ImplicitReferenceConversionExists): ditto.
17508 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17509 error if there were no errors reported during the type lookup
17510 process, to avoid duplicates or redundant errors. Without this
17511 you would get an ambiguous errors plus a type not found. We have
17512 beaten the user enough with the first error.
17514 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17517 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17518 during the resolution process, stop the lookup, this avoids
17519 repeated error reports (same error twice).
17521 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17523 * typemanager.cs (LookupType): Redo the type lookup code to match
17524 the needs of System.Reflection.
17526 The issue is that System.Reflection requires references to nested
17527 types to begin with a "+" sign instead of a dot. So toplevel
17528 types look like: "NameSpace.TopLevelClass", and nested ones look
17529 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17532 2002-09-19 Martin Baulig <martin@gnome.org>
17534 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17535 says that a method always returns or always throws an exception,
17536 don't report the CS0161.
17538 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17539 set `Returns = new_returns'.
17541 2002-09-19 Martin Baulig <martin@gnome.org>
17543 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17544 to an enum constant, check for a CS0176.
17546 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17548 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17549 for operators that must be in pairs and report errors.
17551 * ecore.cs (SimpleName.DoResolveType): During the initial type
17552 resolution process, when we define types recursively, we must
17553 check first for types in our current scope before we perform
17554 lookups in the enclosing scopes.
17556 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17558 (Invocation.VerifyArgumentsCompat): Call
17559 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17560 I thought we were supposed to always call this, but there are a
17561 few places in the code where we dont do it.
17563 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17565 * driver.cs: Add support in -linkres and -resource to specify the
17566 name of the identifier.
17568 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17570 * ecore.cs (StandardConversionExists): Sync with the conversion
17571 code: allow anything-* to void* conversions.
17573 (FindMostSpecificSource): Use an Expression argument
17574 instead of a Type, because we might be handed over a Literal which
17575 gets a few more implicit conversions that plain types do not. So
17576 this information was being lost.
17578 Also, we drop the temporary type-holder expression when not
17581 2002-09-17 Martin Baulig <martin@gnome.org>
17583 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17584 this is an explicit interface implementation.
17586 2002-09-17 Martin Baulig <martin@gnome.org>
17588 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17589 different `IndexerName' attributes.
17591 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17592 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17593 virtual CommonResolve().
17595 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17597 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17598 and convert that to the UnderlyingType.
17600 * statement.cs (Foreach.Resolve): Indexers are just like variables
17601 or PropertyAccesses.
17603 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17604 inside quoted strings, we were not doing this before.
17606 2002-09-16 Martin Baulig <martin@gnome.org>
17608 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17609 resolve it. This is needed for the definite assignment check of the
17610 instance expression, fixes bug #29846.
17611 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17613 2002-09-16 Nick Drochak <ndrochak@gol.com>
17615 * parameter.cs: Fix compile error. Cannot reference static member
17616 from an instance object. Is this an mcs bug?
17618 2002-09-14 Martin Baulig <martin@gnome.org>
17620 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17621 multiple times. Fixes bug #30295, added test-166.cs.
17623 2002-09-14 Martin Baulig <martin@gnome.org>
17625 * statement.cs (Block.Emit): Don't emit unreachable code.
17626 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
17627 `break' statements.
17628 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
17630 2002-09-14 Martin Baulig <martin@gnome.org>
17632 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
17635 2002-09-14 Martin Baulig <martin@gnome.org>
17637 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
17638 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
17639 be false on the ms runtime.
17641 2002-09-13 Martin Baulig <martin@gnome.org>
17643 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
17644 the CS0038 error message.
17646 2002-09-12 Miguel de Icaza <miguel@ximian.com>
17648 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
17649 constant inside, return it.
17651 2002-09-12 Martin Baulig <martin@gnome.org>
17653 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
17654 implicit conversion can be done between enum types.
17656 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
17657 check whether an implicit conversion to the current enum's UnderlyingType
17658 exists and report an error if not.
17660 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
17661 without debugging support.
17663 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
17664 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
17666 2002-09-12 Martin Baulig <martin@gnome.org>
17668 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
17670 * ecore.cs (IMemberExpr.DeclaringType): New property.
17671 (SimpleName.SimpleNameResolve): Check whether we're accessing a
17672 nonstatic member of an outer type (CS0038).
17674 2002-09-11 Miguel de Icaza <miguel@ximian.com>
17676 * driver.cs: Activate the using-error detector at warning level
17677 4 (at least for MS-compatible APIs).
17679 * namespace.cs (VerifyUsing): Small buglett fix.
17681 * pending.cs (PendingImplementation): pass the container pointer.
17683 * interface.cs (GetMethods): Allow for recursive definition. Long
17684 term, I would like to move every type to support recursive
17685 definitions, not the current ordering mechanism that we have right
17688 The situation is this: Attributes are handled before interfaces,
17689 so we can apply attributes to interfaces. But some attributes
17690 implement interfaces, we will now handle the simple cases
17691 (recursive definitions will just get an error).
17693 * parameter.cs: Only invalidate types at the end if we fail to
17696 2002-09-09 Martin Baulig <martin@gnome.org>
17698 * ecore.cs (PropertyExpr.Emit): Also check for
17699 TypeManager.system_int_array_get_length so this'll also work when
17700 compiling corlib. Fixes #30003.
17702 2002-09-09 Martin Baulig <martin@gnome.org>
17704 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
17705 and throw an exception if we can't get the type's size. Fixed #30040,
17708 2002-09-09 Martin Baulig <martin@gnome.org>
17710 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
17712 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
17713 context. Fixes bug #30027.
17715 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
17716 virtual functions. Fixes bug #30043, added test-164.cs.
17718 2002-09-08 Ravi Pratap <ravi@ximian.com>
17720 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
17722 2002-09-08 Nick Drochak <ndrochak@gol.com>
17724 * driver.cs: Use an object to get the windows codepage since it's not a
17727 2002-09-08 Miguel de Icaza <miguel@ximian.com>
17729 * statement.cs (For.Emit): for infinite loops (test == null)
17730 return whether there is a break inside, not always "true".
17732 * namespace.cs (UsingEntry): New struct to hold the name of the
17733 using definition, the location where it is defined, and whether it
17734 has been used in a successful type lookup.
17736 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
17741 2002-09-06 Ravi Pratap <ravi@ximian.com>
17743 * attribute.cs : Fix incorrect code which relied on catching
17744 a NullReferenceException to detect a null being passed in
17745 where an object was expected.
17747 2002-09-06 Miguel de Icaza <miguel@ximian.com>
17749 * statement.cs (Try): flag the catch variable as assigned
17751 * expression.cs (Cast): Simplified by using ResolveType instead of
17752 manually resolving.
17754 * statement.cs (Catch): Fix bug by using ResolveType.
17756 2002-09-06 Ravi Pratap <ravi@ximian.com>
17758 * expression.cs (BetterConversion): Special case for when we have
17759 a NullLiteral as the argument and we have to choose between string
17760 and object types - we choose string the way csc does.
17762 * attribute.cs (Attribute.Resolve): Catch the
17763 NullReferenceException and report error #182 since the Mono
17764 runtime no more has the bug and having this exception raised means
17765 we tried to select a constructor which takes an object and is
17768 2002-09-05 Ravi Pratap <ravi@ximian.com>
17770 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
17771 message (1502, 1503) when we can't locate a method after overload
17772 resolution. This is much more informative and closes the bug
17775 * interface.cs (PopulateMethod): Return if there are no argument
17776 types. Fixes a NullReferenceException bug.
17778 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
17779 expressions too. Previously we were checking only in one place for
17780 positional arguments leaving out named arguments.
17782 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
17783 type to the enum type is not allowed. Remove code corresponding to
17786 (ConvertNumericExplicit): Allow explicit conversions from
17787 the underlying type to enum type. This precisely follows the spec
17788 and closes a bug filed by Gonzalo.
17790 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17793 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
17795 2002-09-03 Miguel de Icaza <miguel@ximian.com>
17797 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
17798 it was important that we stored the right value after the
17799 reduction in `converted'.
17801 2002-09-04 Martin Baulig <martin@gnome.org>
17803 * location.cs (Location.SymbolDocument): Use full pathnames for the
17806 2002-08-30 Miguel de Icaza <miguel@ximian.com>
17808 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
17809 of the expression resolve mechanism, because that will catch the
17810 SimpleName error failures.
17812 (Conditional): If we can not resolve the
17813 expression, return, do not crash.
17815 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17818 (location): display token name instead of its number.
17820 2002-08-28 Martin Baulig <martin@gnome.org>
17822 * expression.cs (Binary.ResolveOperator): Don't silently return
17823 but return an error if an operator cannot be applied between two
17826 2002-08-28 Martin Baulig <martin@gnome.org>
17828 * class.cs (Constructor.Define): Set the permission attributes
17829 correctly instead of making all constructors public.
17831 2002-08-28 Martin Baulig <martin@gnome.org>
17833 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
17834 for private members before reporting a CS0103; if we find anything,
17837 2002-08-28 Martin Baulig <martin@gnome.org>
17839 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
17840 to check whether `closure_start_type == closure_invocation_type',
17841 we also need to check whether `m.DeclaringType == closure_invocation_type'
17842 before bypassing the permission checks. We might be accessing
17843 protected/private members from the base class.
17844 (TypeManager.RealMemberLookup): Only set private_ok if private
17845 members were requested via BindingFlags.NonPublic.
17847 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
17849 * expression.cs (MemberAccess.ResolveMemberAccess): Set
17850 MethodGroupExpr.IsExplicitImpl if appropriate.
17851 (Invocation.DoResolve): Don't report the CS0120 for explicit
17852 interface implementations.
17854 2002-08-27 Martin Baulig <martin@gnome.org>
17856 * expression.cs (Invocation.DoResolve): If this is a static
17857 method and we don't have an InstanceExpression, we must report
17860 2002-08-25 Martin Baulig <martin@gnome.org>
17862 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
17863 `==' between a valuetype and an object.
17865 2002-08-25 Miguel de Icaza <miguel@ximian.com>
17867 * ecore.cs (TypeExpr): Provide a ToString method.
17869 2002-08-24 Martin Baulig <martin@gnome.org>
17871 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
17872 now called proggie.dbg and it's a binary file.
17874 2002-08-23 Martin Baulig <martin@gnome.org>
17876 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
17878 2002-08-23 Martin Baulig <martin@gnome.org>
17880 * struct.cs (MyStructInfo.ctor): Make this work with empty
17881 structs; it's not allowed to use foreach() on null.
17883 2002-08-23 Martin Baulig <martin@gnome.org>
17885 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
17886 writer the full pathname of the generated assembly.
17888 2002-08-23 Martin Baulig <martin@gnome.org>
17890 * statements.cs (FlowBranching.UsageVector.MergeChildren):
17891 A `finally' block never returns or breaks; improved handling of
17894 2002-08-23 Martin Baulig <martin@gnome.org>
17896 * statement.cs (Throw.Resolve): Allow `throw null'.
17898 2002-08-23 Martin Baulig <martin@gnome.org>
17900 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
17901 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
17902 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
17903 MemberLookup would return a wrong event if this is an explicit
17904 interface implementation and the class has an event with the same
17907 2002-08-23 Martin Baulig <martin@gnome.org>
17909 * statement.cs (Block.AddChildVariableNames): New public method.
17910 (Block.AddChildVariableName): Likewise.
17911 (Block.IsVariableNameUsedInChildBlock): Likewise.
17912 (Block.AddVariable): Check whether a variable name has already
17913 been used in a child block.
17915 * cs-parser.jay (declare_local_variables): Mark all variable names
17916 from the current block as being used in a child block in the
17919 2002-08-23 Martin Baulig <martin@gnome.org>
17921 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
17922 find the symbol writer.
17924 * driver.cs: csc also allows the arguments to /define being
17925 separated by commas, not only by semicolons.
17927 2002-08-23 Martin Baulig <martin@gnome.org>
17929 * interface.cs (Interface.GetMembers): Added static check for events.
17931 2002-08-15 Martin Baulig <martin@gnome.org>
17933 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
17934 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
17936 * ecore.cs (Expression.MemberLookup): Added documentation and explained
17937 why the MethodData.EmitDestructor() change was necessary.
17939 2002-08-20 Martin Baulig <martin@gnome.org>
17941 * class.cs (TypeContainer.FindMembers): Added static check for events.
17943 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
17945 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
17946 use Type.GetEvents(), not Type.FindMembers().
17948 2002-08-20 Martin Baulig <martin@gnome.org>
17950 * decl.cs (MemberCache): Added a special method cache which will
17951 be used for method-only searched. This ensures that a method
17952 search will return a MethodInfo with the correct ReflectedType for
17955 2002-08-20 Martin Baulig <martin@gnome.org>
17957 * decl.cs (DeclSpace.FindMembers): Made this public.
17959 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17961 * delegate.cs: fixed build on windows.
17962 [FIXME: Filed as bug #29150: MCS must report these errors.]
17964 2002-08-19 Ravi Pratap <ravi@ximian.com>
17966 * ecore.cs (StandardConversionExists): Return a false
17967 if we are trying to convert the void type to anything else
17968 since that is not allowed.
17970 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
17971 we flag error 70 in the event an event is trying to be accessed
17972 directly from outside the declaring type.
17974 2002-08-20 Martin Baulig <martin@gnome.org>
17976 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
17977 MemberCache from typemanager.cs to decl.cs.
17979 2002-08-19 Martin Baulig <martin@gnome.org>
17981 * class.cs (TypeContainer): Implement IMemberContainer.
17982 (TypeContainer.DefineMembers): Create the MemberCache.
17983 (TypeContainer.FindMembers): Do better BindingFlags checking; only
17984 return public members if BindingFlags.Public was given, check
17985 whether members are static.
17987 2002-08-16 Martin Baulig <martin@gnome.org>
17989 * decl.cs (DeclSpace.Define): Splitted this in Define and
17990 DefineMembers. DefineMembers is called first and initializes the
17993 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
17994 DefineMembers() on all our DeclSpaces.
17996 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
17997 but call DefineMembers() on all nested interfaces. We call their
17998 Define() in our new Define() function.
18000 * interface.cs (Interface): Implement IMemberContainer.
18001 (Interface.Define): Moved all code except the attribute stuf to
18003 (Interface.DefineMembers): Initialize the member cache.
18005 * typemanager.cs (IMemberFinder): Removed this interface, we don't
18006 need this anymore since we can use MemberCache.FindMembers directly.
18008 2002-08-19 Martin Baulig <martin@gnome.org>
18010 * typemanager.cs (MemberCache): When creating the cache for an
18011 interface type, add all inherited members.
18012 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18013 to `out bool used_cache' and documented it.
18014 (TypeManager.MemberLookup): If we already used the cache in the first
18015 iteration, we don't need to do the interfaces check.
18017 2002-08-19 Martin Baulig <martin@gnome.org>
18019 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18020 here from IMemberFinder and don't implement this interface anymore.
18021 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18023 * typemanager.cs (IMemberFinder): This interface is now only used by
18024 classes which actually support the member cache.
18025 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18026 since we only put DeclSpaces into this Hashtable.
18027 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18028 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18030 2002-08-16 Martin Baulig <martin@gnome.org>
18032 * typemanager.cs (ICachingMemberFinder): Removed.
18033 (IMemberFinder.MemberCache): New property.
18034 (TypeManager.FindMembers): Merged this with RealFindMembers().
18035 This function will never be called from TypeManager.MemberLookup()
18036 so we can't use the cache here, just the IMemberFinder.
18037 (TypeManager.MemberLookup_FindMembers): Check whether the
18038 IMemberFinder has a MemberCache and call the cache's FindMembers
18040 (MemberCache): Rewrote larger parts of this yet another time and
18041 cleaned it up a bit.
18043 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18045 * driver.cs (LoadArgs): Support quoting.
18047 (Usage): Show the CSC-like command line arguments.
18049 Improved a few error messages.
18051 2002-08-15 Martin Baulig <martin@gnome.org>
18053 * typemanager.cs (IMemberContainer.Type): New property.
18054 (IMemberContainer.IsInterface): New property.
18056 The following changes are conditional to BROKEN_RUNTIME, which is
18057 defined at the top of the file.
18059 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18060 class'es members, but add all members from TypeHandle.ObjectType
18061 if we're an interface.
18062 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18063 is the current type.
18064 (MemberCache.CacheEntry.Container): Removed this field.
18065 (TypeHandle.GetMembers): Include inherited members.
18067 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18069 * typemanager.cs: fixed compilation and added a comment on a field that
18072 2002-08-15 Martin Baulig <martin@gnome.org>
18074 * class.cs (ConstructorInitializer.Resolve): In the
18075 Expression.MemberLookup call, use the queried_type as
18078 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18079 declared' attribute, it's always true.
18080 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18081 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18082 temporary wrapper for FindMembers which tells MemberLookup whether
18083 members from the base classes are included in the return value.
18084 This will go away soon.
18085 (TypeManager.MemberLookup): Use this temporary hack here; once the
18086 new MemberCache is completed, we don't need to do the DeclaredOnly
18087 looping here anymore since the MemberCache will take care of this.
18088 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18089 (MemberCache): When creating the MemberCache for a class, get
18090 members from the current class and all its base classes.
18091 (MemberCache.CacheEntry.Container): New field. This is a
18092 temporary hack until the Mono runtime is fixed to distinguish
18093 between ReflectedType and DeclaringType. It allows us to use MCS
18094 with both the MS runtime and the unfixed Mono runtime without
18095 problems and without accecting performance.
18096 (MemberCache.SearchMembers): The DeclaredOnly looping from
18097 TypeManager.MemberLookup is now done here.
18099 2002-08-14 Martin Baulig <martin@gnome.org>
18101 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18102 Type.GetFields on dynamic types but get the fields from the
18103 corresponding TypeContainer.
18104 (MyStructInfo.GetStructInfo): Added check for enum types.
18106 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18107 (MemberList.SyncRoot): Implemented.
18108 (TypeManager.FilterWithClosure): No need to check permissions if
18109 closure_start_type == closure_invocation_type, don't crash if
18110 closure_invocation_type is null.
18112 2002-08-13 Martin Baulig <martin@gnome.org>
18114 Rewrote TypeContainer.FindMembers to use a member cache. This
18115 gives us a speed increase of about 35% for the self-hosting MCS
18116 build and of about 15-20% for the class libs (both on GNU/Linux).
18118 * report.cs (Timer): New class to get enhanced profiling. This
18119 whole class is "TIMER" conditional since it remarkably slows down
18122 * class.cs (MemberList): New class. This is an IList wrapper
18123 which we're now using instead of passing MemberInfo[]'s around to
18124 avoid copying this array unnecessarily.
18125 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18126 (ICachingMemberFinder, IMemberContainer): New interface.
18127 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18128 has already been checked, otherwise use it for the name comparision.
18129 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18130 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18131 if possible. Returns a MemberList, not a MemberInfo [].
18132 (TypeHandle): New class, implements IMemberContainer. We create
18133 one instance of this class per type, it contains a MemberCache
18134 which is used to do the member lookups.
18135 (MemberCache): New class. Each instance of this class contains
18136 all members of a type and a name-based hash table.
18137 (MemberCache.FindMembers): This is our new member lookup
18138 function. First, it looks up all members of the requested name in
18139 the hash table. Then, it walks this list and sorts out all
18140 applicable members and returns them.
18142 2002-08-13 Martin Baulig <martin@gnome.org>
18144 In addition to a nice code cleanup, this gives us a performance
18145 increase of about 1.4% on GNU/Linux - not much, but it's already
18146 half a second for the self-hosting MCS compilation.
18148 * typemanager.cs (IMemberFinder): New interface. It is used by
18149 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18150 Enum, Delegate or Interface.
18151 (TypeManager.finder_to_member_finder): New PtrHashtable.
18152 (TypeManager.finder_to_container): Removed.
18153 (TypeManager.finder_to_delegate): Removed.
18154 (TypeManager.finder_to_interface): Removed.
18155 (TypeManager.finder_to_enum): Removed.
18157 * interface.cs (Interface): Implement IMemberFinder.
18159 * delegate.cs (Delegate): Implement IMemberFinder.
18161 * enum.cs (Enum): Implement IMemberFinder.
18163 * class.cs (TypeContainer): Implement IMemberFinder.
18165 2002-08-12 Martin Baulig <martin@gnome.org>
18167 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18169 2002-08-12 Martin Baulig <martin@gnome.org>
18171 * ecore.cs (ITypeExpression): New interface for expressions which
18173 (TypeExpression): Renamed to TypeLookupExpression.
18174 (Expression.DoResolve): If we're doing a types-only lookup, the
18175 expression must implement the ITypeExpression interface and we
18176 call DoResolveType() on it.
18177 (SimpleName): Implement the new ITypeExpression interface.
18178 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18179 hack, the situation that we're only looking up types can't happen
18180 anymore when this method is called. Moved the type lookup code to
18181 DoResolveType() and call it.
18182 (SimpleName.DoResolveType): This ITypeExpression interface method
18183 is now doing the types-only lookup.
18184 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18185 (ResolveFlags): Added MaskExprClass.
18187 * expression.cs (MemberAccess): Implement the ITypeExpression
18189 (MemberAccess.DoResolve): Added support for a types-only lookup
18190 when we're called via ITypeExpression.DoResolveType().
18191 (ComposedCast): Implement the ITypeExpression interface.
18193 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18194 Expression.Resolve() with ResolveFlags.Type instead.
18196 2002-08-12 Martin Baulig <martin@gnome.org>
18198 * interface.cs (Interface.Define): Apply attributes.
18200 * attribute.cs (Attribute.ApplyAttributes): Added support for
18201 interface attributes.
18203 2002-08-11 Martin Baulig <martin@gnome.org>
18205 * statement.cs (Block.Emit): Only check the "this" variable if we
18206 do not always throw an exception.
18208 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18209 whether the property has a set accessor.
18211 2002-08-11 Martin Baulig <martin@gnome.org>
18213 Added control flow analysis support for structs.
18215 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18216 with control flow analysis turned off.
18217 (IVariable): New interface.
18218 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18219 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18220 (FieldExpr.DoResolve): Resolve the instance expression with flow
18221 analysis turned off and do the definite assignment check after the
18222 resolving when we know what the expression will resolve to.
18224 * expression.cs (LocalVariableReference, ParameterReference):
18225 Implement the new IVariable interface, only call the flow analysis
18226 code if ec.DoFlowAnalysis is true.
18227 (This): Added constructor which takes a Block argument. Implement
18228 the new IVariable interface.
18229 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18230 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18231 This does the definite assignment checks for struct members.
18233 * class.cs (Constructor.Emit): If this is a non-static `struct'
18234 constructor which doesn't have any initializer, call
18235 Block.AddThisVariable() to tell the flow analysis code that all
18236 struct elements must be initialized before control returns from
18239 * statement.cs (MyStructInfo): New public class.
18240 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18241 argument to this indexer. If non-zero, check an individual struct
18242 member, not the whole struct.
18243 (FlowBranching.CheckOutParameters): Check struct members.
18244 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18245 overloaded versions of these methods which take an additional
18246 `int field_idx' argument to check struct members.
18247 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18248 overloaded versions of these methods which take an additional
18249 `string field_name' argument to check struct member.s
18250 (VariableInfo): Implement the IVariable interface.
18251 (VariableInfo.StructInfo): New public property. Returns the
18252 MyStructInfo instance of the variable if it's a struct or null.
18253 (Block.AddThisVariable): New public method. This is called from
18254 Constructor.Emit() for non-static `struct' constructor which do
18255 not have any initializer. It creates a special variable for the
18256 "this" instance variable which will be checked by the flow
18257 analysis code to ensure that all of the struct's fields are
18258 initialized before control returns from the constructor.
18259 (UsageVector): Added support for struct members. If a
18260 variable/parameter is a struct with N members, we reserve a slot
18261 in the usage vector for each member. A struct is considered fully
18262 initialized if either the struct itself (slot 0) or all its
18263 members are initialized.
18265 2002-08-08 Martin Baulig <martin@gnome.org>
18267 * driver.cs (Driver.MainDriver): Only report an error CS5001
18268 if there were no compilation errors.
18270 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18271 `UnsafeContext' property to determine whether the parent is in
18272 unsafe context rather than checking the parent's ModFlags:
18273 classes nested in an unsafe class are unsafe as well.
18275 2002-08-08 Martin Baulig <martin@gnome.org>
18277 * statement.cs (UsageVector.MergeChildren): Distinguish between
18278 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18279 we return. Added test17() and test18() to test-154.cs.
18281 2002-08-08 Martin Baulig <martin@gnome.org>
18283 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18284 Family access, make sure the invoking type isn't a subclass of the
18285 queried type (that'd be a CS1540).
18287 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18288 this method which takes an additional `Type invocation_type'.
18290 * expression.cs (BaseAccess.DoResolve): Use the base type as
18291 invocation and query type.
18292 (MemberAccess.DoResolve): If the lookup failed and we're about to
18293 report a CS0122, try a lookup with the ec.ContainerType - if this
18294 succeeds, we must report a CS1540.
18296 2002-08-08 Martin Baulig <martin@gnome.org>
18298 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18299 (MethodGroupExpr): Implement the IMemberExpr interface.
18301 * expression (MemberAccess.ResolveMemberAccess): No need to have
18302 any special code for MethodGroupExprs anymore, they're now
18305 2002-08-08 Martin Baulig <martin@gnome.org>
18307 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18308 Family, FamANDAssem and FamORAssem permissions.
18309 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18311 2002-08-08 Martin Baulig <martin@gnome.org>
18313 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18314 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18317 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18319 * driver.cs: implemented /resource option to embed managed resources.
18321 2002-08-07 Martin Baulig <martin@gnome.org>
18323 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18324 (FieldBase.HasFieldInitializer): New public property.
18325 (FieldBase.GetInitializerExpression): New public method. Resolves and
18326 returns the field initializer and makes sure it is only resolved once.
18327 (TypeContainer.EmitFieldInitializers): Call
18328 FieldBase.GetInitializerExpression to get the initializer, this ensures
18329 that it isn't resolved multiple times.
18331 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18332 the resolving process (SimpleName/MemberLookup) that we're currently
18333 emitting a field initializer (which must not access any instance members,
18334 this is an error CS0236).
18336 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18337 argument, if the `IsFieldInitializer' flag is set, we must report and
18338 error CS0236 and not an error CS0120.
18340 2002-08-07 Martin Baulig <martin@gnome.org>
18342 * ecore.cs (IMemberExpr): New public interface.
18343 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18344 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18345 if the expression is an IMemberExpr.
18347 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18348 to be null, implicitly default to `this' if we're non-static in
18349 this case. Simplified the code a lot by using the new IMemberExpr
18350 interface. Also fixed bug #28176 here.
18352 2002-08-06 Martin Baulig <martin@gnome.org>
18354 * cs-parser.jay (SimpleLookup): Removed. We need to create
18355 ParameterReferences during semantic analysis so that we can do a
18356 type-only search when resolving Cast, TypeOf and SizeOf.
18357 (block): Pass the `current_local_parameters' to the Block's
18360 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18361 argument to the constructor.
18362 (ConstructorInitializer.Resolve): Create a temporary implicit
18363 block with the parameters.
18365 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18366 references here if we aren't doing a type-only search.
18368 * statement.cs (Block): Added constructor which takes a
18369 `Parameters parameters' argument.
18370 (Block.Parameters): New public property.
18372 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18373 to `Parameters' and made it public readonly.
18375 2002-08-06 Martin Baulig <martin@gnome.org>
18377 * ecore.cs (Expression.Warning): Made this public as well.
18379 * report.cs (Report.Debug): Print the contents of collections.
18381 2002-08-06 Martin Baulig <martin@gnome.org>
18383 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18384 used to tell Resolve() which kinds of expressions it may return.
18385 (Expression.Resolve): Added overloaded version of this method which
18386 takes a `ResolveFlags flags' argument. This can be used to tell
18387 Resolve() which kinds of expressions it may return. Reports a
18389 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18390 ResolveFlags.SimpleName.
18391 (Expression.Error118): Added overloaded version of this method which
18392 takes a `ResolveFlags flags' argument. It uses the flags to determine
18393 which kinds of expressions are allowed.
18395 * expression.cs (Argument.ResolveMethodGroup): New public method.
18396 Resolves an argument, but allows a MethodGroup to be returned.
18397 This is used when invoking a delegate.
18399 * TODO: Updated a bit.
18401 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18403 Fixed compilation with csc.
18405 * ecore.cs: Expression.Error made public. Is this correct? Should
18406 Warning be made public too?
18408 * expression.cs: use ea.Location instead of ea.loc.
18409 [FIXME: Filed as bug #28607: MCS must report these errors.]
18411 2002-08-06 Martin Baulig <martin@gnome.org>
18413 * ecore.cs (Expression.loc): Moved the location here instead of
18414 duplicating it in all derived classes.
18415 (Expression.Location): New public property.
18416 (Expression.Error, Expression.Warning): Made them non-static and
18417 removed the location argument.
18418 (Expression.Warning): Added overloaded version which takes an
18419 `int level' argument.
18420 (Expression.Error118): Make this non-static and removed the
18421 expression and location arguments.
18422 (TypeExpr): Added location argument to the constructor.
18424 * expression.cs (StaticCallExpr): Added location argument to
18426 (Indirection, PointerArithmetic): Likewise.
18427 (CheckedExpr, UnCheckedExpr): Likewise.
18428 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18429 (StringPtr): Likewise.
18432 2002-08-05 Martin Baulig <martin@gnome.org>
18434 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18436 * assign.cs (Assign.DoResolve): Check whether the source
18437 expression is a value or variable.
18439 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18440 while resolving the corresponding blocks.
18442 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18443 an error, don't silently return null.
18445 * statement.cs (Block.AddVariable): Do the error reporting here
18446 and distinguish between CS0128 and CS0136.
18447 (Block.DoResolve): Report all unused labels (warning CS0164).
18448 (LabeledStatement): Pass the location to the constructor.
18449 (LabeledStatement.HasBeenReferenced): New property.
18450 (LabeledStatement.Resolve): Set it to true here.
18452 * statement.cs (Return.Emit): Return success even after reporting
18453 a type mismatch error (CS0126 or CS0127), this is what csc does and
18454 it avoids confusing the users with any consecutive errors.
18456 2002-08-05 Martin Baulig <martin@gnome.org>
18458 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18460 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18462 * expression.cs (MemberAccess.DoResolve): Silently return if an
18463 error has already been reported.
18465 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18466 error has already been reported.
18468 2002-08-05 Martin Baulig <martin@gnome.org>
18470 * statement.cs (UsageVector): Only initialize the `parameters'
18471 vector if we actually have any "out" parameters.
18473 2002-08-05 Martin Baulig <martin@gnome.org>
18475 * expression.cs (Binary.ResolveOperator): When combining delegates,
18476 they must have the same type.
18478 2002-08-05 Martin Baulig <martin@gnome.org>
18480 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18481 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18482 work with the ms runtime and we also don't need it: if we're a
18483 PropertyBuilder and not in the `indexer_arguments' hash, then we
18484 are a property and not an indexer.
18486 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18487 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18488 since the latter one doesn't work with the ms runtime.
18490 2002-08-03 Martin Baulig <martin@gnome.org>
18492 Fixed bugs #27998 and #22735.
18494 * class.cs (Method.IsOperator): New public field.
18495 (Method.CheckBase): Report CS0111 if there's already a method
18496 with the same parameters in the current class. Report CS0508 when
18497 attempting to change the return type of an inherited method.
18498 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18499 and it's not marked abstract or extern.
18500 (PropertyBase): New abstract base class for Property and Indexer.
18501 (PropertyBase.CheckBase): Moved here from Property and made it work
18503 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18504 the same so we can reuse it there.
18505 (Property, Indexer): Derive from PropertyBase.
18506 (MethodSignature.inheritable_property_signature_filter): New delegate
18507 to find properties and indexers.
18509 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18510 argument and improved error reporting.
18512 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18513 EmptyReadOnlyParameters and made it a property.
18515 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18516 version of this method which takes a `PropertyInfo indexer'.
18517 (TypeManager.RegisterIndexer): New method.
18519 * class.cs: Added myself as author of this file :-)
18521 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18523 * class.cs: fixed compilation on windoze.
18525 2002-08-03 Martin Baulig <martin@gnome.org>
18527 * interface.cs (Interface.GetInterfaceBases): Check whether all
18528 base interfaces are at least as accessible than the current one.
18530 * class.cs (TypeContainer.GetClassBases): Check whether base types
18531 are at least as accessible than the current type.
18532 (TypeContainer.AsAccessible): Implemented and made non-static.
18533 (MemberBase.CheckParameters): Report errors if the accessibility
18536 * delegate.cs (Delegate.Delegate): The default visibility is
18537 internal for top-level types and private for nested types.
18538 (Delegate.Define): Report errors if the accessibility checks fail.
18540 * enum.cs (Enum.Enum): The default visibility is internal for
18541 top-level types and private for nested types.
18542 (Enum.DefineType): Compute the correct visibility.
18544 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18545 function which takes a `bool is_toplevel' instead of a TypeContainer.
18547 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18550 2002-08-02 Martin Baulig <martin@gnome.org>
18552 * expression.cs (LocalVariableReferenc): Added constructor which
18553 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18554 (LocalVariableReference.IsReadOnly): New property.
18555 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18556 variable is readonly, use our own readonly flag to do this; you can
18557 use the new constructor to get a writable reference to a read-only
18560 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18561 reference to the local variable.
18563 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18565 * rootcontext.cs (ResolveCore): Also include System.Exception
18567 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18568 we reach an EmptyStatement.
18570 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18573 * expression.cs (Binary.ResolveOperator): Check error result in
18576 use brtrue/brfalse directly and avoid compares to null.
18578 2002-08-02 Martin Baulig <martin@gnome.org>
18580 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18581 Fixes bug #28407, added test-155.cs.
18583 2002-08-01 Martin Baulig <martin@gnome.org>
18585 * class.cs (Event.EmitDefaultMethod): Make this work with static
18586 events. Fixes #28311, added verify-3.cs.
18588 2002-08-01 Martin Baulig <martin@gnome.org>
18590 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18591 `is_disposable' fields.
18592 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18593 `hm.is_disposable' if we're using the collection pattern.
18594 (Foreach.EmitCollectionForeach): Use the correct type for the
18595 enumerator's local variable, only emit the try/finally block if
18596 necessary (fixes #27713).
18598 2002-08-01 Martin Baulig <martin@gnome.org>
18600 * ecore.cs (Expression.report118): Renamed to Error118 and made
18603 * statement.cs (Throw.Resolve): Check whether the expression is of
18604 the correct type (CS0118) and whether the type derives from
18605 System.Exception (CS0155).
18606 (Catch.Resolve): New method. Do the type lookup here and check
18607 whether it derives from System.Exception (CS0155).
18608 (Catch.CatchType, Catch.IsGeneral): New public properties.
18610 * typemanager.cs (TypeManager.exception_type): Added.
18612 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18614 * driver.cs: Updated About function.
18616 2002-07-31 Martin Baulig <martin@gnome.org>
18618 Implemented Control Flow Analysis.
18620 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18621 (EmitContext.CurrentBranching): Added.
18622 (EmitContext.StartFlowBranching): Added.
18623 (EmitContext.EndFlowBranching): Added.
18624 (EmitContext.KillFlowBranching): Added.
18625 (EmitContext.IsVariableAssigned): Added.
18626 (EmitContext.SetVariableAssigned): Added.
18627 (EmitContext.IsParameterAssigned): Added.
18628 (EmitContext.SetParameterAssigned): Added.
18629 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
18630 Added control flow analysis stuff here.
18632 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
18633 resolve the expression as lvalue.
18634 (LocalVariableReference.DoResolve): Check whether the variable has
18635 already been assigned.
18636 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
18637 the parameter as assigned here.
18638 (ParameterReference.DoResolve): Check whether the parameter has already
18640 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
18641 expression as lvalue.
18643 * statement.cs (FlowBranching): New class for the flow analysis code.
18644 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
18645 (LabeledStatement.IsDefined): New public property.
18646 (LabeledStatement.AddUsageVector): New public method to tell flow
18647 analyis that the label may be reached via a forward jump.
18648 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
18650 (VariableInfo.Number): New public field. This is used by flow analysis
18651 to number all locals of a block.
18652 (Block.CountVariables): New public property. This is the number of
18653 local variables in this block (including the locals from all parent
18655 (Block.EmitMeta): Number all the variables.
18657 * statement.cs: Added flow analysis support to all classes.
18659 2002-07-31 Martin Baulig <martin@gnome.org>
18661 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
18662 To get debugging messages, compile mcs with /define:MCS_DEBUG and
18663 then use this argument.
18665 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
18667 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
18668 use this to specify /define options.
18670 2002-07-29 Martin Baulig <martin@gnome.org>
18672 * statement.cs (Fixed): Moved all code that does variable lookups
18673 and resolvings from Emit to Resolve.
18675 * statement.cs (For): Moved all code that does variable lookups
18676 and resolvings from Emit to Resolve.
18678 * statement.cs (Using): Moved all code that does variable lookups
18679 and resolvings from Emit to Resolve.
18681 2002-07-29 Martin Baulig <martin@gnome.org>
18683 * attribute.cs (Attribute.Resolve): Explicitly catch a
18684 System.NullReferenceException when creating the
18685 CustromAttributeBuilder and report a different warning message.
18687 2002-07-29 Martin Baulig <martin@gnome.org>
18689 * support.cs (ParameterData.ParameterName): Added method to
18690 get the name of a parameter.
18692 * typemanager.cs (TypeManager.IsValueType): New public method.
18694 2002-07-29 Martin Baulig <martin@gnome.org>
18696 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
18697 is a flag which specifies that it's either ref or out.
18698 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
18699 the out parameter to `out Parameter.Modifier mod', also set the
18700 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
18702 * support.cs (InternalParameters.ParameterModifier): Distinguish
18703 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18704 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18706 * expression.cs (Argument.GetParameterModifier): Distinguish
18707 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18708 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18710 2002-07-29 Martin Baulig <martin@gnome.org>
18712 * expression.cs (ParameterReference.ParameterReference): Added
18713 `Location loc' argument to the constructor.
18715 * cs-parser.jay: Pass location to ParameterReference.
18717 2002-07-28 Miguel de Icaza <miguel@ximian.com>
18719 * statement.cs (Try): Initialize the location.
18721 * cs-parser.jay: pass location to Try.
18723 * expression.cs (Unary.Reduce): Change the prototype to return
18724 whether a constant fold could be performed or not. The result is
18725 returned in an out parameters. In the case of Indirection and
18726 AddressOf, we want to perform the full tests.
18728 2002-07-26 Miguel de Icaza <miguel@ximian.com>
18730 * statement.cs (Statement.Emit): Flag dead code.
18732 2002-07-27 Andrew Birkett <andy@nobugs.org>
18734 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
18736 2002-07-27 Martin Baulig <martin@gnome.org>
18738 * class.cs (MethodData.Define): Put back call to
18739 TypeManager.AddMethod(), accidentally commented this out.
18741 * report.cs (Debug): New public method to print debugging information,
18742 this is `[Conditional ("DEBUG")]'.
18744 2002-07-26 Martin Baulig <martin@gnome.org>
18746 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
18747 (switch_statement): Push the current_block to the switch_stack and
18748 pop it again when we're done with the switch.
18749 (switch_section): The new block is a child of the current_block.
18750 Fixes bug #24007, added test-152.cs.
18752 2002-07-27 Martin Baulig <martin@gnome.org>
18754 * expression.cs (Invocation.EmitArguments): When calling a varargs
18755 function with only its fixed arguments, we need to pass an empty
18758 2002-07-27 Martin Baulig <martin@gnome.org>
18760 Mono 0.13 has been released.
18762 2002-07-25 Miguel de Icaza <miguel@ximian.com>
18764 * driver.cs: Rename --resource to --linkres, because that is what
18765 we do currently, we dont support --resource yet.
18767 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
18769 2002-07-25 Martin Baulig <martin@gnome.org>
18771 * class.cs (MethodData): New public class. This is a `method builder'
18772 class for a method or one accessor of a Property/Indexer/Event.
18773 (MethodData.GetMethodFlags): Moved here from MemberBase.
18774 (MethodData.ApplyAttributes): Likewise.
18775 (MethodData.ApplyObsoleteAttribute): Likewise.
18776 (MethodData.ApplyConditionalAttribute): Likewise.
18777 (MethodData.ApplyDllImportAttribute): Likewise.
18778 (MethodData.CheckAbstractAndExternal): Likewise.
18779 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
18780 (MethodData.Emit): Formerly known as Method.Emit().
18781 (MemberBase): Moved everything which was specific to a single
18782 accessor/method to MethodData.
18783 (Method): Create a new MethodData and call Define() and Emit() on it.
18784 (Property, Indexer, Event): Create a new MethodData objects for each
18785 accessor and call Define() and Emit() on them.
18787 2002-07-25 Martin Baulig <martin@gnome.org>
18789 Made MethodCore derive from MemberBase to reuse the code from there.
18790 MemberBase now also checks for attributes.
18792 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
18793 (MemberBase.GetMethodFlags): Moved here from class Method and marked
18795 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
18796 `CallingConventions cc' and `Attributes opt_attrs' arguments.
18797 (MemberBase.ApplyAttributes): New virtual method; applies the
18798 attributes to a method or accessor.
18799 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
18800 (MemberBase.ApplyConditionalAttribute): Likewise.
18801 (MemberBase.ApplyDllImportAttribute): Likewise.
18802 (MemberBase.CheckAbstractAndExternal): Likewise.
18803 (MethodCore.ParameterTypes): This is now a property instead of a
18804 method, it's initialized from DoDefineParameters().
18805 (MethodCore.ParameterInfo): Removed the set accessor.
18806 (MethodCore.DoDefineParameters): New protected virtual method to
18807 initialize ParameterTypes and ParameterInfo.
18808 (Method.GetReturnType): We can now simply return the MemberType.
18809 (Method.GetMethodFlags): Override the MemberBase version and add
18810 the conditional flags.
18811 (Method.CheckBase): Moved some code from Define() here, call
18812 DoDefineParameters() here.
18813 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
18814 here to avoid some larger code duplication.
18815 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
18816 ensure that abstract and external accessors don't declare a body.
18818 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
18819 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
18820 lookup in the attribute's parent classes, so we need to abort as soon
18821 as we found the first match.
18822 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
18823 the attribute has no arguments.
18825 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
18828 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18830 * cs-parser.jay: reverted previous patch.
18832 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18834 * cs-parser.jay: fixed bug #22119.
18836 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18838 * attribute.cs: fixed compilation. The error was:
18839 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
18840 be assigned to before control leaves the current method."
18841 [FIXME: Filed as bug #28186: MCS must report this error.]
18843 2002-07-25 Martin Baulig <martin@gnome.org>
18845 * attribute.cs (Attribute.Conditional_GetConditionName): New static
18846 method to pull the condition name ouf of a Conditional attribute.
18847 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
18848 the obsolete message and error flag out of an Obsolete attribute.
18850 * class.cs (Method.GetMethodFlags): New public method to get the
18851 TypeManager.MethodFlags for this method.
18852 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
18854 (Method.Define): Get and apply the Obsolete and Conditional attributes;
18855 if we're overriding a virtual function, set the new private variable
18856 `parent_method'; call the new TypeManager.AddMethod().
18858 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
18859 the MethodBuilder and the Method in a PtrHashtable.
18860 (TypeManager.builder_to_method): Added for this purpose.
18861 (TypeManager.MethodFlags): Added IsObsoleteError.
18862 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
18863 Obsolete and Conditional arguments in MethodBuilders. If we discover
18864 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
18865 the message from the attribute.
18867 2002-07-24 Martin Baulig <martin@gnome.org>
18869 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
18870 preprocessor directives, ensure that the argument to #define/#undef is
18871 exactly one identifier and that it's actually an identifier.
18873 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
18876 2002-07-24 Martin Baulig <martin@gnome.org>
18878 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
18879 initialize it to TypeManager.object_type in the constructor.
18880 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
18881 of the `hm.get_current' method if we're using the collection pattern.
18882 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
18883 for the explicit conversion to make it work when we're using the collection
18884 pattern and the `Current' property has a different return type than `object'.
18887 2002-07-24 Martin Baulig <martin@gnome.org>
18889 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
18890 does not match, but don't report any errors. This method is called in
18891 order for all methods in a MethodGroupExpr until a matching method is
18892 found, so we don't want to bail out if the first method doesn't match.
18893 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
18894 matches, report the 123. Fixes #28070.
18896 2002-07-24 Martin Baulig <martin@gnome.org>
18898 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
18899 TypeManager.TypeToCoreType() to the top of the method so the
18900 following equality checks will work. Fixes #28107.
18902 2002-07-24 Martin Baulig <martin@gnome.org>
18904 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
18905 operand is of type uint, and the other operand is of type sbyte,
18906 short or int, the operands are converted to type long." -
18907 Actually do what this comment already told us. Fixes bug #28106,
18910 2002-07-24 Martin Baulig <martin@gnome.org>
18912 * class.cs (MethodBase): New abstract class. This is now a base
18913 class for Property, Indexer and Event to avoid some code duplication
18914 in their Define() and DefineMethods() methods.
18915 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
18916 generic methods for Define() and DefineMethods().
18917 (FieldBase): Derive from MemberBase, not MemberCore.
18918 (Property): Derive from MemberBase, not MemberCore.
18919 (Property.DefineMethod): Moved all the code from this method to the
18920 new MethodBase.DefineAccessor(), just call it with appropriate
18922 (Property.Define): Call the new Property.DoDefine(), this does some
18923 sanity checks and we don't need to duplicate the code everywhere.
18924 (Event): Derive from MemberBase, not MemberCore.
18925 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
18926 accessors, this will also make them work with interface events.
18927 (Indexer): Derive from MemberBase, not MemberCore.
18928 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
18929 (Indexer.Define): Use the new MethodBase functions.
18931 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
18932 argument to the constructor.
18933 (Interface.FindMembers): Added support for interface events.
18934 (Interface.PopluateEvent): Implemented.
18936 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
18938 2002-07-22 Miguel de Icaza <miguel@ximian.com>
18940 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
18941 but this is required to check for a method name being the same as
18942 the containing class.
18946 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18948 * interface.cs: initialize variable.
18950 2002-07-23 Martin Baulig <martin@gnome.org>
18952 Implemented the IndexerName attribute in interfaces.
18954 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
18955 name if this is an explicit interface implementation.
18956 (Indexer.InterfaceIndexerName): New public variable. If we're
18957 implementing an interface indexer, this is the IndexerName in that
18958 interface. Otherwise, it's the IndexerName.
18959 (Indexer.DefineMethod): If we're implementing interface indexer,
18960 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
18961 and Pending.ImplementIndexer methods.
18962 (Indexer.Define): Also define the PropertyBuilder if we're
18963 implementing an interface indexer and this is neither an explicit
18964 interface implementation nor do the IndexerName match the one in
18967 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
18968 If a method is defined here, then we always need to create a proxy
18969 for it. This is used when implementing interface indexers.
18970 (Pending.IsInterfaceIndexer): New public method.
18971 (Pending.ImplementIndexer): New public method.
18972 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
18973 This is used when implementing interface indexers to define a proxy
18975 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
18976 define a proxy if necessary.
18978 * interface.cs (Interface.IndexerName): New public variable.
18979 (Interface.PopulateIndexer): Set the IndexerName.
18980 (Interface.DefineIndexers): New private method. Populate all the
18981 indexers and make sure their IndexerNames match.
18983 * typemanager.cs (IndexerPropertyName): Added support for interface
18986 2002-07-22 Martin Baulig <martin@gnome.org>
18988 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
18989 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
18990 ret if HasReturnLabel.
18991 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
18994 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
18995 and set the ec.LoopBeginTryCatchLevel.
18996 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
18997 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
18998 the current ec.TryCatchLevel, the branch goes out of an exception
18999 block. In this case, we need to use Leave and not Br.
19001 2002-07-22 Martin Baulig <martin@gnome.org>
19003 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
19004 block unless the block does not always return or it is contained in
19005 another try { ... } catch { ... } block. Fixes bug #26506.
19006 Added verify-1.cs to the test suite.
19008 2002-07-22 Martin Baulig <martin@gnome.org>
19010 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
19011 then we do not always return. Fixes bug #24985.
19013 2002-07-22 Martin Baulig <martin@gnome.org>
19015 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19016 lookup on a per-class level; ie. walk up the class hierarchy until we
19017 found at least one applicable method, then choose the best among them.
19018 Fixes bug #24463 and test-29.cs.
19020 2002-07-22 Martin Baulig <martin@gnome.org>
19022 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19023 return types of the methods. The return type is not part of the
19024 signature and we must not check it to make the `new' modifier work.
19025 Fixes bug #27999, also added test-147.cs.
19026 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19028 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19029 on the method's return type.
19031 2002-07-21 Martin Baulig <martin@gnome.org>
19033 * assign.cs: Make this work if the rightmost source is a constant and
19034 we need to do an implicit type conversion. Also adding a few more tests
19035 to test-38.cs which should have caught this.
19037 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19038 target in the makefile for this. The makefile.gnu is primarily intended
19039 for end-users who don't want to debug the compiler.
19041 2002-07-21 Martin Baulig <martin@gnome.org>
19043 * assign.cs: Improved the Assign class so it can now handle embedded
19044 assignments (X = Y = Z = something). As a side-effect this'll now also
19045 consume less local variables. test-38.cs now passes with MCS, added
19046 a few new test cases to that test.
19048 2002-07-20 Martin Baulig <martin@gnome.org>
19050 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19051 instructions. Fixes bug #27977, also added test-146.cs.
19053 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19055 * cs-tokenizer.cs: fixed getHex ().
19057 2002-07-19 Martin Baulig <martin@gnome.org>
19059 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19060 not Type.GetType() to lookup the array type. This is needed when
19061 we're constructing an array of a user-defined type.
19062 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19063 single-dimensional arrays, but also for single-dimensial arrays of
19066 2002-07-19 Martin Baulig <martin@gnome.org>
19068 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19069 this function is called, it's not allowed to share LocalBuilders
19070 among ILGenerators.
19072 2002-07-19 Martin Baulig <martin@gnome.org>
19074 * expression.cs (Argument.Resolve): Report an error 118 when trying
19075 to pass a type as argument.
19077 2002-07-18 Martin Baulig <martin@gnome.org>
19079 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19080 Conv_R_Un for the signed `long' type.
19082 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19084 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19085 `expr' for the temporary result, as that will fail if we do
19086 multiple resolves on the same expression.
19088 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19090 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19091 ec.TypeContainer for looking up aliases.
19093 * class.cs (TypeContainer): Remove LookupAlias from here.
19095 * decl.cs (DeclSpace); Move here.
19097 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19099 * class.cs (FindMembers): Only call filter if the constructor
19100 bulider is not null.
19102 Also handle delegates in `NestedTypes' now. Now we will perform
19103 type lookups using the standard resolution process. This also
19106 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19107 This uses Expressions (the limited kind that can be parsed by the
19108 tree) instead of strings.
19110 * expression.cs (ComposedCast.ToString): Implement, used to flag
19111 errors since now we have to render expressions.
19113 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19116 * ecore.cs (SimpleName.ToString): ditto.
19118 * cs-parser.jay: Instead of using strings to assemble types, use
19119 Expressions to assemble the type (using SimpleName, ComposedCast,
19120 MemberAccess). This should fix the type lookups in declarations,
19121 because we were using a different code path for this.
19123 * statement.cs (Block.Resolve): Continue processing statements
19124 even when there is an error.
19126 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19128 * class.cs (Event.Define): Also remove the `remove' method from
19129 the list of pending items.
19131 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19132 generate more compact code.
19134 2002-07-17 Martin Baulig <martin@gnome.org>
19136 * const.cs (Const.LookupConstantValue): Add support for constant
19137 `unchecked' and `checked' expressions.
19138 Also adding test case test-140.cs for this.
19140 2002-07-17 Martin Baulig <martin@gnome.org>
19142 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19143 check whether mi.ReturnType implements the IEnumerator interface; the
19144 `==' and the IsAssignableFrom() will fail in this situation.
19146 2002-07-16 Ravi Pratap <ravi@ximian.com>
19148 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19151 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19153 * expression.cs: fixed bug #27811.
19155 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19157 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19158 Molaro: when we are a ref, the value already contains a pointer
19159 value, do not take the address of it.
19161 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19162 * removed mb-parser.jay and mb-tokenizer.cs
19164 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19166 * expression.cs: check against the building corlib void type.
19168 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19170 * ecore.cs: fix for valuetype static readonly fields: when
19171 initializing them, we need their address, not the address of a copy.
19173 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19175 * typemanager.cs: register also enum_type in corlib.
19177 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19179 * class.cs: allow calling this (but not base) initializers in structs.
19181 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19183 * ecore.cs: make sure we compare against the building base types
19186 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19188 * typemanager.cs: fix TypeToCoreType() to handle void and object
19189 (corlib gets no more typerefs after this change).
19191 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19193 * expression.cs (ArrayCreation.EmitArrayArguments): use
19194 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19196 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19197 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19198 array indexes, the runtime actually forbids them.
19200 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19201 for array arguments here.
19203 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19204 instead of the default for ValueTypes.
19206 (New.DoEmit): Use IsValueType instead of
19207 IsSubclassOf (value_type)
19208 (New.DoResolve): ditto.
19209 (Invocation.EmitCall): ditto.
19211 * assign.cs (Assign): ditto.
19213 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19214 Statements *are* currently doing part of their resolution during
19217 Expressions do always resolve during resolve, but statements are
19218 only required to propagate resolution to their children.
19220 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19222 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19224 (LoadAssembly): Do not add the dll if it is already specified
19226 (MainDriver): Add the System directory to the link path at the end,
19227 after all the other -L arguments.
19229 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19230 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19231 ldelem.u1) and using the opposite for sbytes.
19233 This fixes Digger, and we can finally run it.
19235 * driver.cs (UnixParseOption): Move the option parsing here.
19236 (CSCParseOption): Implement CSC-like parsing of options.
19238 We now support both modes of operation, the old Unix way, and the
19239 new CSC-like way. This should help those who wanted to make cross
19240 platform makefiles.
19242 The only thing broken is that /r:, /reference: and /lib: are not
19243 implemented, because I want to make those have the same semantics
19244 as the CSC compiler has, and kill once and for all the confussion
19245 around this. Will be doing this tomorrow.
19247 * statement.cs (Unsafe.Resolve): The state is checked during
19248 resolve, not emit, so we have to set the flags for IsUnsfe here.
19250 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19252 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19253 not catch the Error_ObjectRefRequired in SimpleName (as it is
19254 possible to have a class/instance variable name that later gets
19255 deambiguated), we have to check this here.
19257 2002-07-10 Ravi Pratap <ravi@ximian.com>
19259 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19260 make static and put into Expression.
19262 (Event.Define): Register the private field of the event with the
19263 TypeManager so that GetFieldFromEvent can get at it.
19265 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19266 keep track of the private field associated with an event which
19269 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19272 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19274 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19276 * expression.cs (Binary.EmitBranchable): this routine emits the
19277 Binary expression in a branchable context. This basically means:
19278 we need to branch somewhere, not just get the value on the stack.
19280 This works together with Statement.EmitBoolExpression.
19282 * statement.cs (Statement.EmitBoolExpression): Use
19285 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19287 * statement.cs (For): Reduce the number of jumps in loops.
19289 (For): Implement loop inversion for the For statement.
19291 (Break): We can be breaking out of a Try/Catch controlled section
19292 (foreach might have an implicit try/catch clause), so we need to
19293 use Leave instead of Br.
19295 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19296 now). If the instace expression supports IMemoryLocation, we use
19297 the AddressOf method from the IMemoryLocation to extract the
19298 address instead of emitting the instance.
19300 This showed up with `This', as we were emitting the instance
19301 always (Emit) instead of the Address of This. Particularly
19302 interesting when This is a value type, as we dont want the Emit
19303 effect (which was to load the object).
19305 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19307 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19309 * statement.cs (Checked): Set the CheckedState during the resolve
19310 process too, as the ConvCast operations track the checked state on
19311 the resolve process, and not emit.
19313 * cs-parser.jay (namespace_member_declaration): Flag that we have
19314 found a declaration when we do. This is used to flag error 1529
19316 * driver.cs: Report ok when we display the help only.
19318 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19320 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19322 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19324 * cs-tokenizer.cs (define): We also have to track locally the
19325 defines. AllDefines is just used for the Conditional Attribute,
19326 but we also need the local defines for the current source code.
19328 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19330 * statement.cs (While, For, Do): These loops can exit through a
19331 Break statement, use this information to tell whether the
19332 statement is the last piece of code.
19334 (Break): Flag that we break.
19336 * codegen.cs (EmitContexts): New `Breaks' state variable.
19338 2002-07-03 Martin Baulig <martin@gnome.org>
19340 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19341 modifiers in method declarations in structs. Otherwise, you won't
19342 be able to override things like Object.Equals().
19344 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19346 * class.cs (Method, Property, Indexer): Do not allow the public
19347 modifier to be used in explicit interface implementations.
19349 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19350 override modifiers in method declarations in structs
19352 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19354 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19355 integer or real overflow, report an error
19357 2002-07-02 Martin Baulig <martin@gnome.org>
19359 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19360 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19361 to tell the runtime about our newly created System.Object and
19362 System.ValueType types.
19364 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19366 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19367 struct instead of Ldarg/Starg.
19369 2002-07-02 Martin Baulig <martin@gnome.org>
19371 * expression.cs (Indirection.Indirection): Call
19372 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19374 2002-07-02 Martin Baulig <martin@gnome.org>
19376 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19377 ValueType, call TypeManager.TypeToCoreType() on it.
19378 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19379 the OpCodes.Newarr argument.
19381 2002-07-02 Martin Baulig <martin@gnome.org>
19383 * expression.cs (Invocation.EmitCall): When compiling corlib,
19384 replace all calls to the system's System.Array type to calls to
19385 the newly created one.
19387 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19388 System.Array methods.
19389 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19390 from the system's System.Array type which must be replaced.
19392 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19394 * typemanager.cs: load unverifiable_code_ctor so we can build
19395 corlib using the correct type. Avoid using GetTypeCode() with
19397 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19398 TypeManager.object_type to allow building corlib.
19400 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19402 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19404 2002-07-01 Martin Baulig <martin@gnome.org>
19406 * class.cs: Make the last change actually work, we need to check
19407 whether `ifaces != null' to avoid a crash.
19409 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19411 * class.cs: when we build structs without fields that implement
19412 interfaces, we need to add the interfaces separately, since there is
19413 no API to both set the size and add the interfaces at type creation
19416 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19418 * expression.cs: the dimension arguments to the array constructors
19419 need to be converted if they are a long.
19421 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19423 * class.cs: don't emit ldarg.0 if there is no parent constructor
19424 (fixes showstopper for corlib).
19426 2002-06-29 Martin Baulig <martin@gnome.org>
19428 MCS now compiles corlib on GNU/Linux :-)
19430 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19431 ie. check for MethodImplOptions.InternalCall.
19433 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19434 and TypeManager.attribute_type are null, so we must explicitly check
19435 whether parent is not null to find out whether it's an attribute type.
19436 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19437 and SetBuilder, not only if the property is neither abstract nor external.
19438 This is necessary to set the MethodImplOptions on the accessor methods.
19439 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19440 SetBuilder, see Property.Emit().
19442 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19443 populate "System.Object", "System.ValueType" and "System.Attribute" since
19444 they've already been populated from BootCorlib_PopulateCoreTypes().
19446 2002-06-29 Martin Baulig <martin@gnome.org>
19448 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19449 is the NullLiteral, we also need to make sure that target_type is not
19452 2002-06-29 Martin Baulig <martin@gnome.org>
19454 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19455 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19456 before calling BootstrapCorlib_ResolveDelegate ().
19458 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19460 * statement.cs: fixed build-breaker. All tests passed ok.
19462 2002-06-27 Martin Baulig <martin@gnome.org>
19464 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19465 for System.Decimal when compiling corlib.
19467 2002-06-27 Martin Baulig <martin@gnome.org>
19469 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19470 switch blocks which contain nothing but a default clause.
19472 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19474 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19476 2002-06-27 Martin Baulig <martin@gnome.org>
19478 * ecore.cs (PropertyExpr.PropertyExpr): Call
19479 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19481 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19482 is already a TypeBuilder.
19484 2002-06-27 Martin Baulig <martin@gnome.org>
19486 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19487 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19488 the "from an array-type to System.Array" case. This makes it work
19489 when compiling corlib.
19491 2002-06-27 Martin Baulig <martin@gnome.org>
19493 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19494 non-static PropertyExpr, set its InstanceExpression. This makes
19495 the `ICollection.Count' property work in System/Array.cs.
19497 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19499 * driver.cs: Made error handling more consistent. Errors now
19500 tracked by Report class, so many methods which used to return int
19501 now return void. Main() now prints success/failure and
19502 errors/warnings message.
19504 Renamed '--probe' compiler argument to '--expect-error'. Removed
19505 the magic number return values (123 and 124). Now, if the
19506 expected error occurs, the compiler exits with success (exit value
19507 0). If the compilation completes without seeing that particular
19508 error, the compiler exits with failure (exit value 1). The
19509 makefile in mcs/errors has been changed to handle the new behaviour.
19511 * report.cs: Made 'expected error' number a property and renamed
19512 it from 'Probe' to 'ExpectedError'.
19514 * genericparser.cs: Removed error handling support, since it is
19515 now all done by Report class.
19517 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19518 class, so parse() no longer returns an int.
19520 * namespace.cs: Use Report.Error instead of GenericParser.error
19522 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19524 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19525 TypeContainer.AddOperator): At the front of the list put the
19526 explicit implementations, so they get resolved/defined first.
19528 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19530 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19531 interface type is implemented by this TypeContainer. Used during
19532 explicit interface implementation.
19534 (Property.Define, Indexer.Define, Method.Define): Validate that
19535 the given interface in the explicit implementation is one of the
19536 base classes for the containing type.
19538 Also if we are explicitly implementing an interface, but there is
19539 no match in the pending implementation table, report an error.
19541 (Property.Define): Only define the property if we are
19542 not explicitly implementing a property from an interface. Use the
19543 correct name also for those properties (the same CSC uses,
19544 although that is really not needed).
19546 (Property.Emit): Do not emit attributes for explicitly implemented
19547 properties, as there is no TypeBuilder.
19549 (Indexer.Emit): ditto.
19551 Hiding then means that we do not really *implement* a pending
19552 implementation, which makes code fail.
19554 2002-06-22 Martin Baulig <martin@gnome.org>
19556 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19557 the return value of Object.GetType(). [FIXME: we need to do this whenever
19558 we get a type back from the reflection library].
19560 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19562 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19564 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19566 * attribute.cs: Return null if we can not look up the type.
19568 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19569 the interface types found.
19571 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19572 interface types found.
19574 * typemanager.cs (GetInterfaces): Make this routine returns alll
19575 the interfaces and work around the lame differences between
19576 System.Type and System.Reflection.Emit.TypeBuilder in the results
19577 result for GetInterfaces.
19579 (ExpandInterfaces): Given an array of interface types, expand and
19580 eliminate repeated ocurrences of an interface. This expands in
19581 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19584 2002-06-21 Martin Baulig <martin@gnome.org>
19586 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19589 2002-06-21 Martin Baulig <martin@gnome.org>
19591 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19592 and called with one of the core types, return the corresponding typebuilder for
19595 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19598 2002-06-21 Martin Baulig <martin@gnome.org>
19600 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19601 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19602 (Expression.ConvertReferenceExplicit): Likewise.
19604 * expression.cs (ElementAccess.DoResolve): Likewise.
19605 (ElementAccess.DoResolveLValue): Likewise.
19607 2002-06-10 Martin Baulig <martin@gnome.org>
19609 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19610 add the "value" parameter to the parameter list.
19612 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19615 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19617 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19618 the argument to an int, uint, long or ulong, per the spec. Also
19619 catch negative constants in array creation.
19621 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
19623 * class.cs: do not allow the same interface to appear twice in
19624 the definition list.
19626 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
19628 * ecore.cs: don't use ldlen with System.Array.
19630 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
19632 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
19634 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
19636 * modifiers.cs: produce correct field attributes for protected
19637 internal. Easy fix so miguel can work on ther harder stuff:-)
19639 2002-06-18 Miguel de Icaza <miguel@ximian.com>
19641 * pending.cs: New file. Move the code from class.cs here.
19642 Support clearning the pending flag for all methods (when not doing
19643 explicit interface implementation).
19645 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
19647 * rootcontext.cs: added a couple more types needed to bootstrap.
19649 2002-06-17 Miguel de Icaza <miguel@ximian.com>
19651 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
19652 constructor in the type, instead of any constructor in the type
19653 hierarchy. Thanks to Paolo for finding this bug (it showed up as
19654 a bug in the Mono runtime when applying the params attribute).
19656 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19657 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
19659 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
19661 * expression.cs (Unary.ResolveOperator): Use TypeManager
19662 to resolve the type.
19664 2002-06-13 Ravi Pratap <ravi@ximian.com>
19666 * cs-parser.jay (enum_member_declaration): Pass in the attributes
19669 * enum.cs (AddEnumMember): Add support to store the attributes associated
19670 with each member too.
19672 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
19673 field builders too - this takes care of the enum member case.
19675 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
19677 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
19678 address-of operator on both value types and pointers.
19680 2002-06-10 Martin Baulig <martin@gnome.org>
19682 * interface.cs (Interface.PopulateIndexer): Add the indexer's
19683 PropertyBuilder to the `property_builders' list.
19685 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
19686 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
19687 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
19688 find any indexers which are inherited from an interface.
19690 2002-06-09 Martin Baulig <martin@gnome.org>
19692 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
19693 the same type as the constant if necessary. There's also a test-130.cs
19696 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
19698 * typemanager.cs (TypeManager.ChangeType): Previously known as
19699 Enum.ChangeEnumType().
19701 2002-06-09 Martin Baulig <martin@gnome.org>
19703 * expression.cs (Cast.TryReduce): Added support for consts.
19705 2002-06-08 Ravi Pratap <ravi@ximian.com>
19707 * class.cs (Accessor): Hold attributes information so we can pass
19710 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
19711 Modify to pass in attributes attached to the methods.
19713 (add_accessor_declaration, remove_accessor_declaration): Ditto.
19715 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
19716 to handle the Accessor kind :-)
19718 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
19720 2002-06-08 Martin Baulig <martin@gnome.org>
19722 * expression.cs (Unary.TryReduceNegative): Added support for
19725 2002-06-08 Martin Baulig <martin@gnome.org>
19727 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
19728 name can't be found in the `defined_names' - the caller will do a
19729 MemberLookup in this case and thus find methods in System.Enum
19730 such as Enum.IsDefined().
19732 2002-06-08 Martin Baulig <martin@gnome.org>
19734 * enum.cs (Enum.ChangeEnumType): This is a custom version of
19735 Convert.ChangeType() which works with TypeBuilder created types.
19736 (Enum.LookupEnumValue, Enum.Define): Use it here.
19738 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
19739 `TypeBuilder.BaseType != null' check.
19740 (TypeContainer.FindMembers): Only lookup parent members if we
19741 actually have a parent.
19742 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
19743 (ConstructorInitializer.Resolve): Likewise.
19745 * interface.cs (Interface.FindMembers): Added
19746 `TypeBuilder.BaseType != null' check.
19748 * rootcontext.cs (RootContext.ResolveCore): Added
19749 "System.Runtime.CompilerServices.IndexerNameAttribute" to
19750 classes_second_stage.
19752 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
19753 debug_type and trace_type when compiling with --nostdlib.
19755 2002-06-07 Martin Baulig <martin@gnome.org>
19757 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
19758 (AddField): Set it to true when adding a non-static field.
19759 (DefineType): Use `have_nonstatic_fields' to find out whether we
19760 have non-static fields, not `Fields != null'.
19762 2002-06-02 Miguel de Icaza <miguel@ximian.com>
19764 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
19765 dereferencing a null on the static-field code path)
19767 2002-05-30 Martin Baulig <martin@gnome.org>
19769 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
19770 to take command line arguments. Use reflection to call the new
19771 custom `Initialize' function on the symbol writer and pass it the
19772 command line arguments.
19774 * driver.cs (--debug-args): New command line argument to pass command
19775 line arguments to the symbol writer.
19777 2002-05-28 Miguel de Icaza <miguel@ximian.com>
19779 * assign.cs (DoResolve): Forgot to do the implicit conversion to
19780 the target type for indexers and properties. Thanks to Joe for
19783 2002-05-27 Miguel de Icaza <miguel@ximian.com>
19785 * typemanager.cs (MethodFlags): returns the method flags
19786 (Obsolete/ShouldIgnore) that control warning emission and whether
19787 the invocation should be made, or ignored.
19789 * expression.cs (Invocation.Emit): Remove previous hack, we should
19790 not do this on matching a base type, we should do this based on an attribute
19792 Only emit calls to System.Diagnostics.Debug and
19793 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
19794 on the command line.
19796 * rootcontext.cs: Global settings for tracing and debugging.
19798 * cs-tokenizer.cs (define): New utility function to track
19799 defines. Set the global settings for TRACE and DEBUG if found.
19801 2002-05-25 Ravi Pratap <ravi@ximian.com>
19803 * interface.cs (Populate*): Pass in the TypeContainer as well as
19804 the DeclSpace as parameters so that we can create EmitContexts and
19805 then use that to apply attributes etc.
19807 (PopulateMethod, PopulateEvent, PopulateProperty)
19808 (PopulateIndexer): Apply attributes everywhere.
19810 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
19813 (ApplyAttributes): Update accordingly.
19815 We now apply interface attributes for all members too.
19817 2002-05-26 Miguel de Icaza <miguel@ximian.com>
19819 * class.cs (Indexer.Define); Correctly check if we are explicit
19820 implementation (instead of checking the Name for a ".", we
19821 directly look up if the InterfaceType was specified).
19823 Delay the creation of the PropertyBuilder.
19825 Only create the PropertyBuilder if we are not an explicit
19826 interface implementation. This means that explicit interface
19827 implementation members do not participate in regular function
19828 lookups, and hence fixes another major ambiguity problem in
19829 overload resolution (that was the visible effect).
19831 (DefineMethod): Return whether we are doing an interface
19834 * typemanager.cs: Temporary hack until we get attributes in
19835 interfaces (Ravi is working on that) and we get IndexerName
19836 support in interfaces.
19838 * interface.cs: Register the indexers as properties.
19840 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
19841 warning, I have verified that this is a bug in the .NET runtime
19842 (JavaScript suffers of the same problem).
19844 * typemanager.cs (MemberLookup): When looking up members for
19845 interfaces, the parent of an interface is the implicit
19846 System.Object (so we succeed in searches of Object methods in an
19847 interface method invocation. Example: IEnumerable x; x.ToString
19850 2002-05-25 Miguel de Icaza <miguel@ximian.com>
19852 * class.cs (Event): Events should also register if they do
19853 implement the methods that an interface requires.
19855 * typemanager.cs (MemberLookup); use the new GetInterfaces
19858 (GetInterfaces): The code used to lookup interfaces for a type is
19859 used in more than one place, factor it here.
19861 * driver.cs: Track the errors at the bottom of the file, we kept
19864 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
19865 instance if the method we are calling is static!
19867 2002-05-24 Miguel de Icaza <miguel@ximian.com>
19869 * attribute.cs (ApplyAttributes): Make this function filter out
19870 the IndexerName attribute (as that attribute in reality is never
19871 applied) and return the string constant for the IndexerName
19874 * class.cs (TypeContainer.Emit): Validate that all the indexers
19875 have the same IndexerName attribute, and if so, set the
19876 DefaultName attribute on the class.
19878 * typemanager.cs: The return value might contain other stuff (not
19879 only methods). For instance, consider a method with an "Item"
19880 property and an Item method.
19882 * class.cs: If there is a problem with the parameter types,
19885 2002-05-24 Ravi Pratap <ravi@ximian.com>
19887 * ecore.cs (ImplicitConversionExists): Wrapper function which also
19888 looks at user defined conversion after making a call to
19889 StandardConversionExists - we need this for overload resolution.
19891 * expression.cs : Update accordingly the various method calls.
19893 This fixes 2 bugs filed against implicit user defined conversions
19895 2002-05-22 Miguel de Icaza <miguel@ximian.com>
19897 * statement.cs: Track the result of the assignment.
19899 2002-05-21 Miguel de Icaza <miguel@ximian.com>
19901 * expression.cs (MemberAccess): Improved error reporting for
19902 inaccessible members.
19904 2002-05-22 Martin Baulig <martin@gnome.org>
19906 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
19907 itself with debugging support.
19909 2002-05-22 Martin Baulig <martin@gnome.org>
19911 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
19912 Removed, this isn't needed anymore.
19914 2002-05-20 Martin Baulig <martin@gnome.org>
19916 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
19917 be underlying type for an enum.
19919 2002-05-20 Miguel de Icaza <miguel@ximian.com>
19921 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
19922 that splits out the loading of just the core types.
19924 * rootcontext.cs (ResolveCore): Split the struct resolution in
19925 two, so we can load the enumeration underlying types before any
19928 * expression.cs (Is): Bandaid until we fix properly Switch (see
19929 bug #24985 for details).
19931 * typemanager.cs (ImplementsInterface): The hashtable will contain
19932 a null if there are no interfaces implemented.
19934 2002-05-18 Miguel de Icaza <miguel@ximian.com>
19936 * cs-parser.jay (indexer_declarator): It is fine to have array
19939 2002-05-17 Miguel de Icaza <miguel@ximian.com>
19941 * typemanager.cs: (RegisterBuilder): New function used to register
19942 TypeBuilders that implement interfaces. Since
19943 TypeBuilder.GetInterfaces (as usual) does not work with lame
19945 (AddUserType): register interfaces.
19947 (ImplementsInterface): Use the builder_to_ifaces hash if we are
19948 dealing with TypeBuilder. Also, arrays are showing up as
19949 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
19950 methods can not be invoked on them!
19952 * ecore.cs (ExplicitReferenceConversionExists): Made public.
19953 (ImplicitReferenceConversionExists): Split out from
19954 StandardConversionExists.
19956 * expression.cs (As): We were only implementing one of the three
19957 cases for the as operator. We now implement them all.
19958 (Is): Implement the various other cases for Is as well.
19960 * typemanager.cs (CACHE): New define used to control if we want or
19961 not the FindMembers cache. Seems to have a negative impact on
19962 performance currently
19964 (MemberLookup): Nested types have full acess to
19965 enclosing type members
19967 Remove code that coped with instance/static returns for events, we
19968 now catch this in RealFindMembers.
19970 (RealFindMembers): only perform static lookup if the instance
19971 lookup did not return a type or an event.
19973 2002-05-17 Miguel de Icaza <miguel@ximian.com>
19975 * assign.cs (CompoundAssign): We pass more semantic information
19976 now to Compound Assignments than we did before: now we have all
19977 the information at hand, and now we resolve the target *before* we
19978 do the expression expansion, which allows the "CacheValue" method
19979 to have the effect we intended (before, a [x] += 1 would generate
19980 two differen ArrayAccess expressions from the ElementAccess,
19981 during the resolution process).
19983 (CompoundAssign.DoResolve): Resolve target and original_source here.
19985 2002-05-16 Miguel de Icaza <miguel@ximian.com>
19987 * expression.cs (ArrayAccess): dropped debugging information.
19989 * typemanager.cs: Small bug fix: I was always returning i_members,
19990 instead of one of i_members or s_members (depending on which had
19993 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
19994 method is invoked before any code generation takes place, and it
19995 is a mechanism to inform that the expression will be invoked more
19996 than once, and that the method should use temporary values to
19997 avoid having side effects
19999 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
20001 * ecore.cs (Expression.CacheTemporaries): Provide empty default
20004 * expression.cs (Indirection, ArrayAccess): Add support for
20005 CacheTemporaries in these two bad boys.
20007 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
20008 ldobj or ldind_ref.
20009 (StoreFromPtr): Handle stobj as well.
20011 * expression.cs (UnaryMutator): Share more code.
20013 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20014 down: I was not tracking the Filter function as well, which
20015 was affecting the results of the cache.
20017 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20019 * attribute.cs: Remove the hack to handle the CharSet property on
20022 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20024 * attribute.cs (DoResolve): More uglyness, we now only try to
20025 resolve the attribute partially, to extract the CharSet
20026 information (only if we are a StructLayout attribute). Otherwise
20028 (GetExtraTypeInfo): Add some code to conditionally kill in the
20029 future this. I am more and more convinced that the .NET
20030 framework has special code to handle the attribute setting on
20033 * expression.cs (IsParamsMethodApplicable): Revert my previous
20034 foreach change here, it was wrong.
20036 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20038 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20039 (pp_expr): do not abort on unknown input, just return.
20040 (eval): abort if there are pending chars.
20042 * attribute.cs (Attribute.Resolve): Positional parameters are
20043 optional. Deal with that case.
20045 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20046 the Ansi/Unicode/Auto information for the type.
20048 (TypeContainer.DefineType): instantiate the EmitContext here, as
20049 we will be using it during the type definition (to resolve
20050 attributes) and during the emit phase.
20052 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20053 to pull type information out of the attributes
20055 (Attribute.Resolve): track the constructor builder, and allow for
20056 multiple invocations (structs and classes will use this).
20058 * ecore.cs (MemberLookupFinal): new version with all the
20059 parameters customizable.
20061 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20062 constructors. Return if the result value is null (as the error
20063 would have been flagged already by MemberLookupFinal)
20065 Do not allow instances of abstract classes or interfaces to be
20068 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20069 We have to compare the assembly property here when dealing with
20070 FamANDAssem and Assembly access modifiers, because we might be
20071 creating an assembly from *modules* (that means that we are not
20072 getting TypeBuilders for types defined in other modules that are
20073 part of this assembly).
20075 (Method.Emit): If the method is marked abstract and has a body,
20078 (TypeContainer.DefineMembers): If both the defined member and the
20079 parent name match are methods, then do not emit any warnings: let
20080 the Method.Define routine take care of flagging warnings. But if
20081 there is a mismatch (method overrides something else, or method is
20082 overriwritten by something, then emit warning).
20084 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20085 set to null, this means `do not check for the return type on the
20088 (Method.Define): set the return type for the method signature to
20089 null, so that we get methods with the same name and parameters and
20090 different return types. This is used to flag warning 114 (you are
20091 hiding a method, and you probably want to use the new/override
20094 * typemanager.cs (MemberLookup): Implemented proper access
20095 control, closing a long standing set of bug reports. The problem
20096 was that the Framework only has two bits: Public and NonPublic,
20097 and NonPublic includes private and protected methods, but we need
20098 to enforce the FamANDAssem, FamOrAssem and Family.
20100 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20102 * statement.cs (GotoCase): Return true: Ammounts to giving up
20103 knowledge on whether we return or not, and letting the other case
20104 be responsible for it.
20106 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20108 * driver.cs: Do not load directories for each file processed, only
20109 do it if there is a pattern.
20111 * ecore.cs: Report readonly assigns here as well, as we might have
20112 been resolved only by MemberAccess.
20114 (SimpleName.SimpleNameResolve): Also be useful for LValue
20115 resolution. We need this to propagate assign to local readonly variables
20117 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20118 do not want to reuse potential criteria memory.
20120 * class.cs (MyEventBuilder): Set reflected_type;
20122 * ecore.cs (Constantify): Added support for constifying bools.
20124 (RootContext.LookupType): Added a cache for values looked up in
20125 the declaration space.
20127 * typemanager.cs (FindMembers): Now is a front-end to
20128 RealFindMembers, and provides a two-level hashtable-based cache to
20131 15% performance improvement: from 22.5 to 19.2 seconds.
20133 * expression.cs (IsParamsMethodApplicable): use foreach.
20134 (Invocation.DoResolve): ditto.
20135 (New.DoResolve): ditto.
20136 (ArrayCreation.DoResolve): ditto.
20138 * ecore.cs (FindMostEncompassingType): use foreach.
20140 * delegate.cs (NewDelegate.DoResolve): Use foreach
20142 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20143 (RemoveMethods): use foreach.
20145 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20146 nested foreach statements instead of for, and also break out of
20147 the inner loop once a match is found.
20149 (Invocation.OverloadResolve): Use foreach, simplify the code.
20151 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20153 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20154 we actually unwrap the expression to allow for extra information
20157 * expression.cs: Use Shr_Un on unsigned operations.
20159 2002-05-08 Ravi Pratap <ravi@ximian.com>
20161 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20162 applicable operators was not being considered correctly. This closes
20163 the bug Miguel reported.
20165 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20167 * attribute.cs: check that the type derives from System.Attribute
20168 and report the correct error in that case (moved the duplicate code to
20169 its own method, too).
20171 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20173 * attribute.cs: lookup attribute type name as the spec says: first the
20174 bare attribute name and then name + "Attribute" (nant compiles with
20175 mcs after this fix).
20177 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20179 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20180 Because of the way we parse things, we should try to see if a
20181 UIntConstant can fit in an integer.
20183 2002-05-07 Ravi Pratap <ravi@ximian.com>
20185 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20186 when we are in an explicit context.
20188 (ConvertReferenceExplicit): When converting from Iface type S to Class
20189 T make sure the rules are implemented as an OR.
20191 * parameter.cs (ParameterType): Make it a property for now although the
20192 purpose really isn't anything immediate.
20194 * expression.cs (Is*Applicable): Do better checking on the parameter type
20195 of a ref/out parameter. The ones from the system assemblies are already
20196 marked with the correct type so we don't need to do any correction.
20198 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20199 the object type is standard too so include that.
20201 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20203 * ecore.cs (StandardConversionExists): Augment with missing code:
20204 deal with IntConstant, LongConstants and Enumerations.
20206 * assign.cs: Report the error, instead of failing silently
20208 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20209 typecontainer that they are declared, because the
20210 typecontainer/namespace will have the list of using clauses that
20211 need to be applied.
20213 Assembly Attributes were escaping the normal registration
20216 (EmitCode): Apply attributes within an EmitContext that represents
20217 the container they were declared on.
20219 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20221 2002-05-06 Ravi Pratap <ravi@ximian.com>
20223 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20224 Revamp completely - make much cleaner as we now operate only
20227 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20228 to implement the logic detailed in the spec more correctly.
20230 (UserDefinedConversion): Update accordingly.
20232 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20234 * statement.cs: Return flow analysis information up.
20236 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20239 (token): Do not consume an extra character before calling
20242 2002-05-06 Piers Haken <piersh@friskit.com>
20244 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20246 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20248 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20249 EmitContext during the instance constructor initializer
20250 resolution, to stop access to instance variables.
20252 This is mandated by the spec, last paragraph of the `constructor
20253 initializers' section.
20255 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20257 * cs-parser.jay, class.cs (Accessor): new class used to represent
20258 an accessor (get or set). In the past we used `null' to represent
20259 a missing accessor. But this is ambiguous because there was no
20260 way to tell in abstract indexers/properties if one of them was
20263 Now there is a way of addressing that.
20265 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20266 instead of FindMembers.
20268 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20269 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20271 * attribute.cs: Treat indexers and properties as the same in terms
20272 of applying attributes
20274 * ecore.cs (FindMostEncompassedType): Use statically initialized
20275 EmptyExpressions()s like we do elsewhere to avoid creating useless
20276 objects (and we take this out of the tight loop).
20278 (GetConversionOperators): Move the code to extract the actual
20279 operators to a separate routine to clean things up.
20281 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20283 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20284 events are always registered FieldBuilders.
20286 * class.cs (FieldBase): New class shared by Fields
20288 * delegate.cs: If we are a toplevel delegate, use our full name.
20289 If we are a nested delegate, then only use our tail name.
20291 2002-05-02 Ravi Pratap <ravi@ximian.com>
20293 * expression.cs (IsApplicable): Ensure that we add the "&" to
20294 ref/out types before comparing it with the type of the argument.
20296 (IsParamsMethodApplicable): Ditto.
20298 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20301 * delegate.cs : Handle the case when we have more than one applicable
20302 method. Flag an error only when we finish checking all.
20304 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20306 * expression.cs: Add support for boolean static initializers.
20308 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20310 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20312 * parameter.cs (ComputeParameterTypes,
20313 ComputeAndDefineParameterTypes): Better error handling: now we
20314 clear the `types' cache if we fail during any of the type lookups.
20315 We also return the status code correctly to our caller
20317 * delegate.cs: If we fail to define a delegate, abort the extra
20320 * expression.cs (Binary.ResolveOperator): for
20321 operator==(object,object) and operator !=(object, object) we also
20322 have to verify that there is an implicit conversion from one to
20325 (ArrayAccess.DoResolve): Array Access can operate on
20328 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20330 * assign.cs (CompoundAssign): A new class used as a "flag" that
20331 the assignment actually is happening as part of a compound
20332 assignment operator.
20334 During compound assignment, a few new rules exist to enable things
20341 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20342 to the type of x) if y is implicitly convertible to the type of x,
20343 and the operator is a builtin operator and the return type of the
20344 operator is explicitly convertible to the type of x.
20346 * rootcontext.cs: Reset warning level to 2. 4 catches various
20347 "interesting" features in mcs, we must clean this up at some
20348 point, but currently am trying to kill other bugs ;-)
20350 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20351 in container classes as well.
20353 * expression.cs (Binary.ResolveOperator): Handle string case
20354 before anything else (as operator overloading does emit an error
20355 before doing anything else).
20357 This code could go away when we move to a table driven model, but
20358 i could not come up with a good plan last night.
20360 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20362 * typemanager.cs (CSharpName): reimplementation using regex.
20363 * class.cs: added null check for fields in Emit
20364 * rootcontext.cs: set warninglevel to 4
20366 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20368 * typemanager.cs (CSharpName): reimplemented with Lupus
20371 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20373 * statement.cs (If): correclty implement Resolve, because we were
20374 not catching sem errors in there. The same process is needed
20376 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20379 (Statement.Warning_DeadCodeFound): Factorize code.
20380 (While): Report dead code here too.
20382 (Statement): Added Resolve virtual method to allow
20383 for resolution split from the emit code.
20385 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20387 * statement.cs (EmitBoolExpression): No longer try to resolve the
20389 (MakeBoolean): New utility function that resolve, implicitly
20390 converts to boolean and tags the expression.
20393 (If, Do): Implement dead code elimination.
20394 (While): Implement loop inversion
20396 (Do, While, For, If): Resolve the expression prior to calling our
20399 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20402 - added method Report28 (warning: program has more than one entry point)
20403 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20404 - modified method Method.Define, the part at the end of the method
20406 * rootcontext.cs: added static public Location EntryPointLocation;
20408 * ../errors/cs0028.cs : Add test case for the above warning.
20411 - modified method CSharpName to allow arrays of primitive type to
20412 be printed nicely (e.g. instead of System.Int32[][] it now prints
20414 - added method CSharpSignature: returns the signature of a method
20415 in string format to be used in reporting errors, warnings, etc.
20417 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20420 2002-04-26 Ravi Pratap <ravi@ximian.com>
20422 * delegate.cs (Define): Fix extremely silly bug where I was
20423 setting the type of the 'object' parameter of the BeginInvoke
20424 method to System.IAsyncResult instead of System.Object ;-)
20426 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20428 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20431 (Constructor.Emit): return if we fail to initialize the
20432 constructor. Another door closed!
20434 * expression.cs (New.DoResolve): Improve error message (from -6 to
20435 1501). Use DeclaredOnly lookup to find the exact constructor.
20437 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20438 loop. This is useful.
20440 * cs-parser.jay: Adjust the default parameters so that destructors
20441 have the proper signature.
20443 2002-04-26 Martin Baulig <martin@gnome.org>
20445 * driver.cs (LoadAssembly): If `assembly' contains any characters
20446 which are only valid in path names and not in assembly names
20447 (currently slash, backslash and point), use Assembly.LoadFrom ()
20448 instead of Assembly.Load () on the `assembly' (before iteration
20449 over the link_paths).
20451 2002-04-26 Martin Baulig <martin@gnome.org>
20453 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20455 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20457 * class.cs (Property): use the new typemanager.MemberLookup
20459 (TypeContainer.MemberLookup): Implement using the
20460 TypeManager.MemberLookup now.
20462 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20463 and return MemberInfos, so that these can be used without an
20464 EmitContext (what we had before).
20466 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20468 * expression.cs: Fix the case where the argument to params if the
20469 type of the params. I omitted handling this before. Fixed
20471 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20473 * driver.cs: Call BootCorlib_PopulateCoreType
20475 * class.cs (Property.CheckBase): Check for properties only, not
20478 * interface.cs: Temporary hack: try/catch around the
20479 CustomAttributeBuilder, because I am getting an exception that I
20482 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20483 types whose definitions are required to be there (attributes are
20484 defined before standard types).
20486 Compute definitions as we boot the various types, as they are used
20487 immediately (value_type class will need object_type, but if we do
20488 not initialize object_type, we will pass a null, which will let
20489 the runtime pick the System.Object from the existing corlib, which
20490 is not what we want).
20492 2002-04-22 Patrik Torstensson <totte@labs2.com>
20494 * cs-tokenizer.cs: fixed a number of trim() issues.
20496 2002-04-22 Ravi Pratap <ravi@ximian.com>
20498 * expression.cs (Argument.Type): Ensure that we return the correct
20499 type when we have out or ref parameters [in which case we
20502 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20504 * class.cs (Property, Indexer): Allow extern modifier in there.
20506 * typemanager.cs (InitBaseTypes): Initializes object_type and
20507 value_type, since those will be used early on during the bootstrap
20508 process to compile corlib.
20510 (InitCoreTypes): Move code from here to InitBaseTypes.
20512 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20514 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20515 single-dimension arrays as using the ldlen opcode.
20517 Daniel Lewis discovered this optimization.
20519 * typemanager.cs: Add signature for System.Array::get_Length
20521 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20523 * statement.cs: report the error when the foreach does not apply to an
20524 array nor a collection.
20526 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20528 * expression.cs: Add implicit conversions to the operator ~.
20530 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20532 * typemanager.cs: Locate the decimal constructor.
20534 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20536 * attribute.cs: use the new property of TypeOf.
20537 * expression.cs: added 'get' property around typearg.
20539 These changes fix a build breaker reported by NickD. Is this the
20540 correct way to fix? If not, please, revert my changes and make it
20543 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20545 * attribute.cs: Add support for typeof in attribute invocations.
20546 I am not sure that this is right though.
20548 2002-04-14 Duncan Mak <duncan@ximian.com>
20550 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20551 Binary.Operator.Division case.
20553 2002-04-13 Ravi Pratap <ravi@ximian.com>
20555 * class.cs (DefineType): Ensure that we do a proper check on
20556 attribute types and also register it with the TypeManager.
20558 (TypeContainer.Targets): The default for attribute types is
20559 AttributeTargets.All.
20561 * attribute.cs (ApplyAttributes): Registering the attribute type
20562 is done elsewhere, not when we discover we have a Usage attribute.
20564 2002-04-12 Ravi Pratap <ravi@ximian.com>
20566 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20567 and get rid of is_delegate parameter.
20569 * everywhere : update.
20571 2002-04-12 Ravi Pratap <ravi@ximian.com>
20573 * cs-parser.jay (compilation_unit): Revamp completely to use
20574 some new ideas that I got from Rhys' grammar to solve the problems
20575 with assembly level attributes.
20577 (outer_declaration): New grammar production.
20579 (attribute_sections): Add.
20581 (opt_attributes): Base on attribute_sections
20583 (namespace_declaration): Allow opt_attributes to tackle the case
20584 when we have assembly level attributes - we are clever in this
20587 * attribute.cs (ApplyAttributes): Do not worry about assembly
20588 attributes in the non-global context.
20590 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20591 instead of SetGlobalAttributes.
20593 * class.cs, rootcontext.cs : Ensure we define and generate
20594 attribute types before anything else.
20596 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20597 and flag the new error -20 for the case when the attribute type
20598 does not have valid targets specified. csc does not catch this.
20600 * ../errors/errors.txt : update for error # -20
20602 2002-04-11 Ravi Pratap <ravi@ximian.com>
20604 * support.cs (InternalParameters.ParameterModifier): Do some null
20605 checking and return sane values.
20607 * class.cs (Method.Define): If we are a PInvoke method, ensure
20608 that we are static and extern. Report error # 601
20610 * ../errors/cs0601.cs : Add test case for the above error.
20612 2002-04-07 Ravi Pratap <ravi@ximian.com>
20614 * rootcontext.cs (attribute_types): We need to keep type of
20615 all attribute types separately and emit code for them first.
20617 (RegisterAttribute) : Implement.
20619 * class.cs (DefineType): Check if the current Type is a custom
20620 attribute type and register it accordingly.
20622 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
20623 adding the first attribute twice and rename to
20625 (SetGlobalAttributes): this.
20627 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
20630 * attribute.cs (ApplyAttributes): Take an additional argument telling us
20631 if we are processing global arguments. Hmm, I am unsure of this.
20633 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20635 * expression.cs: added static array of strings to avoid calling
20636 Enum.ToString () for Operator in Binary. Significant recover of
20639 2002-04-10 Miguel de Icaza <miguel@ximian.com>
20641 * class.cs (FindMembers): Allow the Builders of the various
20642 members to be null. If they are skip them. This only happens
20643 during the PInvoke declaration.
20645 2002-04-09 Miguel de Icaza <miguel@ximian.com>
20647 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
20648 failure, so we do not keep going afterwards.
20650 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
20651 wanted to pass `false' as the `is_delegate' argument. If this is
20652 the case, why not use delegate_type == null to mean `is_delegate =
20653 false' and anything else as is_delegate = true.
20655 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
20657 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
20658 code for the section, not the beginning of the tests.
20660 2002-04-08 Miguel de Icaza <miguel@ximian.com>
20662 * cfold.cs: Handle operator + (Enum x, Underlying x)
20664 * expression.cs (Binary): same. Warn about errors where we have
20665 Enum/Enum in operator + as well.
20667 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
20670 - added support for switch(bool)
20671 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
20672 - add TableSwitchEmit() to handle table-based switch statements
20674 2002-04-05 Ravi Pratap <ravi@ximian.com>
20676 * expression.cs (Invocation.OverloadResolve): Factor out code which
20677 does parameter compatibility checking with arguments so that we can
20678 re-use the code even from Delegate.VerifyApplicability
20680 (VerifyArgumentsCompat): Move above code here.
20682 * delegate.cs (VerifyApplicability): Get rid of duplicate code
20683 and instead make a call to the above method.
20685 2002-03-31 Ravi Pratap <ravi@ximian.com>
20687 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
20688 We use it to keep track of classes which are attribute types.
20690 2002-04-02 Miguel de Icaza <miguel@ximian.com>
20692 * delegate.cs (Delegate.Define): Correctly define the types in the
20693 presence of fixed and array parameters.
20695 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
20698 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
20699 include NonPublic after the first iteration.
20701 * class.cs (Indexer.CheckBase): Only check if both parents are
20704 * cs-parser.jay (accessor_body): If empty, set to null.
20706 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
20707 same code path here to resolve constants names that we did have in
20708 MemberAccess.DoResolve. There is too much code duplicated here.
20710 2002-04-01 Miguel de Icaza <miguel@ximian.com>
20712 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
20714 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
20717 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
20718 tokens, numbers and strings.
20720 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
20723 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
20724 asyncronous parameters and the regular parameters.
20726 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
20727 specify the target directory.
20729 * expression.cs: (This.DoResolve): Simplify
20730 (As.Emit): Optimize, do not generate IsInst if the expression is
20731 always of the given type.
20733 (Is.DoResolve): Bug fix, we were reporting both always/never for
20736 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
20737 creating too many unnecessary arrays.
20739 2002-03-31 Miguel de Icaza <miguel@ximian.com>
20741 * class.cs (EmitFieldInitializer): Use Assign expression to assign
20742 fields instead of rolling our own initializer. Takes care of all
20743 implicit conversions, and drops unnecessary static checks/argument.
20745 2002-03-31 Dick Porter <dick@ximian.com>
20747 * driver.cs: use the GetDirectories() return values properly, and
20748 use "/" as path separator.
20750 2002-03-30 Miguel de Icaza <miguel@ximian.com>
20752 * expression.cs (Unary): Optimize - - expr into expr.
20753 (Binary): Optimize a + (-b) into a -b.
20755 * codegen.cs (CodeGen): Made all methods static.
20757 2002-03-29 Miguel de Icaza <miguel@ximian.com>
20761 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
20762 TypeBuilder property.
20764 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
20767 * tree.cs: Removed the various RecordXXXX, and replaced with a
20768 single RecordDecl. Removed all the accessor methods, and just
20769 left a single access point Type
20771 * enum.cs: Rename DefineEnum to DefineType.
20773 * decl.cs: New abstract method `DefineType' used to unify the
20774 Defines for Enumerations, Interfaces, TypeContainers and
20777 (FindType): Moved LookupInterfaceOrClass here. Moved the
20778 LookupBaseClasses method that used to live in class.cs and
20779 interface.cs here, and renamed to FindType.
20781 * delegate.cs: Implement DefineType. Take advantage of the
20782 refactored pattern for locating the parent builder without taking
20783 the parent_builder argument (which we know does not work if we are
20784 nested, and triggering a toplevel definition).
20786 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20788 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
20789 accessibility of a member has changed during override and report
20792 * class.cs (Method.Define, Property.Define): Only complain on
20793 overrides if the method is private, any other accessibility is
20794 fine (and since we just checked the permission is the same, we are
20797 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
20798 and elif are processed always. The other pre-processing
20799 directives are only processed if we are "taking" the path
20801 2002-03-29 Martin Baulig <martin@gnome.org>
20803 * class.cs (Method.Emit): Only emit symbolic debugging info if the
20804 current location is not Null.
20806 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
20807 a separate method so we can profile it.
20809 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
20810 `span.Seconds' are just seconds, but no minutes or hours.
20811 (MainDriver): Profile the CodeGen.SaveSymbols calls.
20813 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20815 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
20816 Remove the gratuitous set of Final:
20818 // If an interface implementation, then we can set Final.
20819 if (((flags & MethodAttributes.Abstract) == 0) &&
20820 implementing.DeclaringType.IsInterface)
20821 flags |= MethodAttributes.Final;
20823 I do not know what I was smoking when I used that.
20826 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
20827 step into fixing the name resolution issues for delegates and
20828 unifying the toplevel name resolution.
20830 2002-03-28 Martin Baulig <martin@gnome.org>
20832 * class.cs (Method.Emit): If we have a symbol writer, call its
20833 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
20834 tell it about the current method.
20836 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
20837 writer that we're going to emit the first byte of IL code for a new
20838 statement (a new source line).
20839 (EmitContext.EmitTopBlock): If we have a symbol writer, call
20840 EmitContext.Mark() before emitting any code.
20842 * location.cs (SymbolDocument): Return null when we're Null.
20844 * statement.cs (Statement): Moved the `Location loc' variable here.
20845 (Statement.EmitBoolExpression): If we have a symbol writer, call
20846 ec.Mark() before emitting any code to tell it that we're at the
20847 beginning of a new statement.
20848 (StatementExpression): Added `Location' argument to the constructor.
20849 (Block): Added public readonly variable `StartLocation' and public
20850 variable `EndLocation'. The latter is to be set using SetEndLocation().
20851 (Block): Added constructor which takes a start and end location.
20852 (Block.SetEndLocation): New method. This sets the end location.
20853 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
20854 local variables we create.
20855 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
20856 each statement and do also mark the begin and end of the block.
20858 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
20859 tell it the current lexer.Location, use Location.Null for the end of the
20861 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
20862 current block, set its end location using SetEndLocation().
20863 (statement_expression): StatementExpression constructor now takes the
20864 lexer.Location as additional argument.
20865 (for_statement, declare_local_variables): Likewise.
20866 (declare_local_variables): When creating a new implicit block, use the
20867 new Block constructor and pass it the lexer.Location.
20869 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20871 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
20872 members also on the parent interfaces recursively.
20874 2002-03-27 Miguel de Icaza <miguel@ximian.com>
20876 * report.cs: Use new formats, since Gonzalo finished the missing
20879 * expression.cs (Binary.ResolveOperator): added missing operator|
20880 operator& and operator^ for bool/bool.
20882 * cs-parser.jay: CheckDef now takes a Location argument that is
20883 used to report errors more precisly (instead of reporting the end
20884 of a definition, we try to track something which is a lot closer
20885 to the source of the problem).
20887 * cs-tokenizer.cs: Track global token use, so we can properly flag
20888 the use of #define/#undef after the first token has been seen.
20890 Also, rename the reportXXXX to Error_DescriptiveName
20892 * decl.cs (DeclSpace.IsTopLevel): Move property here from
20893 TypeContainer, so that Enum and Interface can use this too.
20895 * class.cs (TypeContainer.LookupInterfaceOrClass,
20896 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
20897 `builder' argument. Typically this was used to pass the parent
20898 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
20901 The problem is that a nested class could trigger the definition of
20902 a toplevel class, and the builder would be obviously wrong in that
20905 So we drop this argument, and we compute dynamically the
20906 TypeBuilder/ModuleBuilder (the correct information was available
20907 to us anyways from DeclSpace.Parent)
20909 * interface.cs (Interface.DefineInterface): Drop builder
20910 parameter cleanup like class.cs
20912 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
20915 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
20918 (Try.Emit): Propagate the returns value from the statement.
20920 (Return.Emit): Even if we are leavning
20922 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
20924 * modifiers.cs: Fix the computation of MethodAttributes flags.
20926 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
20928 * driver.cs: allow compilation of files that start with '/'.
20929 Add a default case when checking the argument of --target.
20931 2002-03-25 Miguel de Icaza <miguel@ximian.com>
20933 * interface.cs: Implement the same search algorithm for types in
20934 the interface code.
20936 * delegate.cs: Do not allow multiple definition.
20938 * Recovered ChangeLog that got accidentally amputated
20940 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
20942 * rootcontext.cs: Load manually enum to allow core classes to
20943 contain enumerations.
20945 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
20946 Update to new static methods in TypeManager.
20948 * typemanager.cs (GetMethod, GetConstructor): Use our
20949 implementation of FindMembers to find the members, since during
20950 corlib compilation, the types are TypeBuilders and GetMethod and
20951 GetConstructor do not work.
20953 Make all methods in TypeManager static.
20955 (InitCodeHelpers): Split the functionality from
20956 the InitCodeTypes function.
20958 * driver.cs: Call InitCodeHelpers after we have populated the
20961 * cs-parser.jay (delegate_declaration): we did not used to compute
20962 the delegate name correctly for void delegates.
20964 2002-03-24 Miguel de Icaza <miguel@ximian.com>
20966 * rootcontext.cs (RootContext): Init the interface_resolve_order
20967 and type_container_resolve_order always.
20969 (ResolveCore, BootstrapCorlib_ResolveClass,
20970 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
20971 compiler when compiling with --nostdlib
20973 * class.cs (TypeContainer.DefineType): Check that our parent is
20974 not null. This test is most important when we are bootstraping
20977 * codegen.cs: Split out the symbol writing code.
20979 2002-03-25 Martin Baulig <martin@gnome.org>
20981 * driver.cs (-g): Made -g an alias for --debug.
20983 2002-03-24 Martin Baulig <martin@gnome.org>
20985 * codegen.cs (SymbolWriter): New public variable. Returns the
20986 current symbol writer.
20987 (CodeGen): Added `bool want_debugging_support' argument to the
20988 constructor. If true, tell the ModuleBuild that we want debugging
20989 support and ask it for the ISymbolWriter.
20990 (Save): If we have a symbol writer, call it's Close() method after
20991 saving the assembly.
20993 * driver.c (--debug): New command line argument to create a
20994 debugger information file.
20996 * location.cs (SymbolDocument): New public property. Returns an
20997 ISymbolDocumentWriter object for the current source file or null
20998 if we don't have a symbol writer.
21000 2002-03-21 Miguel de Icaza <miguel@ximian.com>
21002 * driver.cs (LoadAssembly): Correctly return when all the paths
21003 have been tried and not before.
21005 * statement.cs (Switch.Emit): return the actual coverage for this
21006 statement (returns/not-returns)
21008 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
21009 switch of the statement if we are the last switch section. That
21010 kills two problems: try/catch problems (we used to emit an empty
21011 nop at the end) and switch statements where all branches would
21014 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21016 * driver.cs: Add default assemblies (the equivalent to the
21017 Microsoft CSC.RSP file)
21019 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21020 also update tokens_seen and set it to false.
21022 * driver.cs: Implement --recurse for Mike.
21024 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21025 correctly splitting out the paths.
21027 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21029 * interface.cs (Interface.PopulateProperty): Instead of using
21030 `parent' as the declaration space for the set parameters, use
21033 * support.cs (InternalParameters): InternalParameters constructor
21034 takes a DeclSpace instead of a TypeContainer.
21036 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21037 types are being initialized, load the address of it before calling
21040 (New): Provide a mechanism to disable the generation of local
21041 value type temporaries when the caller will be providing us with
21042 an address to store it.
21044 (ArrayCreation.EmitDynamicInitializers): Use it.
21046 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21048 * expression.cs (Invocation.EmitArguments): Only probe for array
21049 property if there is more than one argument. Sorry about that.
21051 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21052 empty param arrays.
21054 * class.cs (Method.LabelParameters): Fix incorrect code path that
21055 prevented the `ParamArrayAttribute' from being applied to the
21058 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21060 * support.cs (ReflectionParameters): Correctly compute whether the
21061 last argument is a params array. Fixes the problem with
21064 * typemanager.cs: Make the assemblies array always be non-null
21065 (empty, but non-null)
21067 * tree.cs (RecordDecl): New function that abstracts the recording
21068 of names. This reports error 101, and provides a pointer to the
21069 previous declaration. Fixes a crash in the compiler.
21071 * cs-parser.jay (constructor_declaration): Update to new grammar,
21072 and provide a constructor_body that can be empty.
21074 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21076 * driver.cs: Add support for --resources.
21078 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21079 Make all types for the various array helper methods be integer.
21081 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21082 CheckState to ConvCast.
21084 (ConvCast): Now it takes a `checked' state argument, to avoid
21085 depending on the emit context for the conversion, and just using
21086 the resolve time setting.
21088 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21089 instead of Invocation.EmitArguments. We do not emit the original
21090 arguments, instead we emit those which have been converted to
21091 unsigned int expressions.
21093 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21095 * codegen.cs: ditto.
21097 * expression.cs (LocalVariableReference): Drop the use of the
21098 Store function that depended on the variable index.
21100 * statement.cs (VariableInfo): Drop the `Idx' property from this
21101 class, as this is not taking into account the indexes for
21102 temporaries tat we generate during the execution, getting the
21105 * class.cs: First emit class initializers, then call the parent
21108 * expression.cs (Binary): Fix opcode emision.
21109 (UnaryMutator.EmitCode): Support checked code generation
21111 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21112 matches for events for both the Static and Instance scans,
21113 pointing to the same element. Fix that.
21115 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21117 * rootcontext.cs (ResolveTree): Always set the
21118 interface_resolve_order, because nested interfaces will be calling
21121 * class.cs (GetInterfaceOrClass): Track the same resolution
21122 process used by TypeManager.LookupType. This fixes the nested
21123 type lookups in class declarations (separate path from
21126 (TypeContainer.DefineType): Also define nested interfaces.
21127 (TypeContainer.RegisterOrder): New public function used to
21128 register the order in which child interfaces need to be closed.
21130 Nested interfaces need to be closed after their parents have been
21133 * interface.cs (InterfaceAttr): Put all the logic for computing
21134 the interface attribute here.
21136 (DefineInterface): Register our interface order with the
21137 RootContext or with the TypeContainer depending on the case.
21139 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21141 * cs-parser.jay: rework foreach statement to work with the new
21142 changes to the policy on SimpleNames.
21144 * report.cs: support Stacktrace on warnings as well.
21146 * makefile: drop --unsafe and /unsafe from the compile.
21148 2002-03-13 Ravi Pratap <ravi@ximian.com>
21150 * ecore.cs (StandardConversionExists): Modify to take an Expression
21151 as the first parameter. Ensure we do null -> reference type conversion
21154 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21155 temporary Expression objects.
21157 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21159 * interface.cs: workaround bug in method overloading resolution
21160 (there is already a bugzilla bug for it).
21162 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21164 We could also solve this problem by having a separate path for
21165 performing type lookups, instead of DoResolve, we could have a
21166 ResolveType entry point, and only participating pieces of the
21167 production (simplename, deref, array) would implement this.
21169 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21170 signal SimpleName to only resolve type names and not attempt to
21171 resolve anything else.
21173 * expression.cs (Cast): Set the flag.
21175 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21177 * class.cs: Only report 108 if there is no `new' modifier.
21179 * cs-parser.jay: rework foreach statement to work with the new
21180 changes to the policy on SimpleNames.
21182 * report.cs: support Stacktrace on warnings as well.
21184 * makefile: drop --unsafe and /unsafe from the compile.
21186 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21188 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21189 lookups here, instead of doing that at parse time. This means
21190 that our grammar will not introduce `LocalVariableReferences' as
21191 expressions at this point. That solves the problem of code like
21195 static void Main ()
21199 This is only half the fix. The full fix requires parameters to
21200 also be handled in this way.
21202 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21203 makes the use more obvious of the DeclSpace. The
21204 ec.TypeContainer.TypeBuilder is now only used to pull the
21205 TypeBuilder for it.
21207 My theory is that I can get rid of the TypeBuilder completely from
21208 the EmitContext, and have typecasts where it is used (from
21209 DeclSpace to where it matters).
21211 The only pending problem is that the code that implements Aliases
21212 is on TypeContainer, and probably should go in DeclSpace.
21214 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21215 lookups here, instead of doing that at parse time. This means
21216 that our grammar will not introduce `LocalVariableReferences' as
21217 expressions at this point. That solves the problem of code like
21221 static void Main ()
21225 This is only half the fix. The full fix requires parameters to
21226 also be handled in this way.
21228 * class.cs (Property.DefineMethod): When implementing an interface
21229 method, set newslot, when implementing an abstract method, do not
21230 set the flag (before we tried never setting it, or always setting
21231 it, which is the difference).
21232 (Indexer.DefineMethod): same.
21233 (Method.DefineMethod): same.
21235 * ecore.cs: Only set the status used flag if we get back a Field.
21237 * attribute.cs: Temporary hack, so Paolo can keep working.
21239 2002-03-08 Ravi Pratap <ravi@ximian.com>
21241 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21242 the unmanaged type in the case we have a MarshalAs attribute.
21244 (Resolve): Handle the case when we are parsing the special MarshalAs
21245 attribute [we need to store the unmanaged type to use later]
21247 * typemanager.cs (marshal_as_attr_type): Built in type for the
21248 MarshalAs Attribute.
21250 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21251 on parameters and accordingly set the marshalling info.
21253 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21255 * class.cs: Optimizing slightly by removing redundant code after
21256 we switched to the `NoTypes' return value.
21257 (Property.DefineMethod): use NoTypes here too.
21259 This fixes the bug I introduced in my last batch of changes.
21261 2002-03-05 Ravi Pratap <ravi@ximian.com>
21263 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21265 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21266 Enums since those are types too.
21268 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21270 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21271 thanks to a call during the lookup process.
21273 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21275 * statement.cs (Foreach): Lots of work to accomodate a particular
21276 kind of foreach statement that I had not kept in mind. It is
21277 possible to have foreachs on classes that provide a GetEnumerator
21278 method that return objects that implement the "pattern" for using
21279 a foreach, there is no need to support GetEnumerator
21282 This is needed to compile nant.
21284 * decl.cs: Only report 114 if the member is not `Finalize' and if
21285 the warning level is at least 2.
21287 * class.cs: Moved the compare function from Method to
21290 (MethodSignature.InheritableMemberSignatureCompare): Add new
21291 filter function that is used to extract inheritable methods from a
21294 (Method.Define): Use the new `inheritable_method_signature_filter'
21297 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21300 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21302 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21304 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21306 * expression.cs: Pass location information to
21307 ConvertImplicitStandard.
21309 * class.cs: Added debugging code to track return values from
21312 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21314 * expression.cs (Is.DoResolve): If either side of the `is' is an
21315 interface, do not flag the warning.
21317 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21320 * report.cs: Allow for --fatal to be used with --probe.
21322 * typemanager.cs (NoTypes): Move the definition for the empty Type
21325 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21327 (TypeContainer.DefineProxy): New function used to proxy to parent
21328 implementations when implementing interfaces.
21329 (TypeContainer.ParentImplements): used to lookup if our parent
21330 implements a public function that is required by an interface.
21331 (TypeContainer.VerifyPendingMethods): Hook this up.
21333 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21334 `modules' and `assemblies' arraylists into arrays. We only grow
21335 these are the very early start up of the program, so this improves
21336 the speedof LookupType (nicely measured).
21338 * expression.cs (MakeByteBlob): Replaced unsafe code with
21339 BitConverter, as suggested by Paolo.
21341 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21342 folding of string concatenation, but if either side is a string,
21343 and the other is not, then return null, and let the runtime use
21344 the concatenation on the string plus the object (using
21345 `Object.ToString').
21347 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21349 Constant Folding has been implemented now.
21351 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21352 the error instead on types that are not supported in one's
21355 * constant.cs (Constant and all children): New set of functions to
21356 perform implict and explicit conversions.
21358 * ecore.cs (EnumConstant): Implement the new functions to perform
21359 conversion by proxying to the child expression.
21361 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21362 own separate setting that can not be turned off from the command
21363 line using --unchecked or --checked and is only controlled using
21364 the checked/unchecked statements and expressions. This setting is
21365 used by the constant folder to flag errors.
21367 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21368 ConstantCheckState as well.
21370 During Resolve, they also have to flag the state, because the
21371 constant folder runs completely in the Resolve phase.
21373 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21376 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21378 * cfold.cs: New file, this file contains the constant folder.
21380 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21381 argument to track whether we are using the resulting address to
21382 load or store a value and provide better error messages.
21384 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21385 new AddressOf arguments.
21387 * statement.cs (Foreach.EmitCollectionForeach): Update
21389 * expression.cs (Argument.Emit): Call AddressOf with proper
21390 arguments to track usage.
21392 (New.DoEmit): Call AddressOf with new arguments.
21394 (Unary.Emit): Adjust AddressOf call.
21396 2002-03-01 Ravi Pratap <ravi@ximian.com>
21398 * cs-parser.jay (member_access): Change the case for pre-defined types
21399 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21402 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21405 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21406 essentially like methods and apply attributes like MethodImplOptions to them too.
21408 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21411 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21412 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21415 * Update code everywhere accordingly.
21417 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21419 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21421 2002-02-28 Ravi Pratap <ravi@ximian.com>
21423 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21424 try performing lookups against those instead of jumping straight into using
21425 the 'using' clauses.
21427 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21429 (LookupType): Perform lookups in implicit parents too.
21431 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21432 sequence as RootContext.LookupType.
21434 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21435 the various cases of namespace lookups into this method.
21437 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21439 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21440 in positional arguments)
21442 * class.cs (Operator): Update the AllowedModifiers to contain
21445 * cs-parser.jay: Update operator declaration to allow for the
21446 operator body to be empty.
21448 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21451 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21453 * class.cs (Method.Emit): Label parameters.
21455 * driver.cs: Return 1 or 0 as the program exit code.
21457 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21459 * expression.cs: Special case the `null' object when trying to
21460 auto-compute the type, as anything can be explicitly converted to
21463 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21464 spotting this Paolo.
21466 (Expression.ImplicitNumericConversion): Perform comparissions of
21467 the type using the underlying type in the case of an enumeration
21468 rather than using the enumeration type for the compare.
21470 Cope with the underlying == type case, which is not possible to
21473 (Expression.ConvertNumericExplicit): Perform comparissions of
21474 the type using the underlying type in the case of an enumeration
21475 rather than using the enumeration type for the compare.
21477 * driver.cs: If the user does not supply an extension, assume .exe
21479 * cs-parser.jay (if_statement): Rewrote so that we can track the
21480 location for the if statement.
21482 * expression.cs (Binary.ConstantFold): Only concat strings when
21483 the operation is "+", not everything ;-)
21485 * statement.cs (Statement.EmitBoolExpression): Take a location
21487 (If, While, Do): Track location.
21489 * expression.cs (Binary.ResolveOperator): In the object + string
21490 case, I was missing a call to ConvertImplicit
21492 2002-02-25 Ravi Pratap <ravi@ximian.com>
21494 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21495 Location arguments. Ensure we use RootContext.LookupType to do our work
21496 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21498 * interface.cs (PopulateMethod): Handle the type of the parameter being
21501 * expression.cs (Invocation.BetterFunction): Handle the case when we
21502 have a params method with no fixed arguments and a call is made with no
21505 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21507 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21508 the verbatim-string-literal
21510 * support.cs (InternalParameters.ParameterModifier): handle null
21512 (InternalParameters.ParameterType): ditto.
21514 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21515 duplicating the name of the variable parameter.
21516 (GetParameterByName): Fix bug where we were not looking up array
21517 paramters if they were the only present (thanks Paolo!).
21518 (GetParameterInfo): We only have an empty set of types if both
21519 fixed and array are set to null.
21520 (GetParameterInfo-idx): Handle FixedParameter == null
21522 * cs-parser.jay: Handle the case where there is no catch
21523 statements (missing null test).
21525 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21527 * driver.cs (MainDriver): Be conservative on our command line
21530 Catch DirectoryNotFoundException when calling GetFiles.
21532 (SplitPathAndPattern): Used to split the input specification into
21533 a path and a pattern that we can feed to Directory.GetFiles.
21535 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21537 * statement.cs (Fixed): Implement the last case of the Fixed
21538 statement (string handling).
21540 * expression.cs (StringPtr): New class used to return a char * to
21541 a string; Used by the Fixed statement.
21543 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21545 * expression.cs (Binary.ResolveOperator): Remove redundant
21546 MemberLookup pn parent type.
21547 Optimize union call, we do not need a union if the types are the same.
21548 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21551 Specialize the use of MemberLookup everywhere, instead of using
21552 the default settings.
21554 (StackAlloc): Implement stackalloc keyword.
21556 * cs-parser.jay: Add rule to parse stackalloc.
21558 * driver.cs: Handle /h, /help, /?
21560 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21561 before we supported unsafe code.
21563 * makefile: add --unsafe to the self compilation of mcs.
21565 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21567 * expression.cs (PointerArithmetic): New class that is used to
21568 perform pointer arithmetic.
21569 (Binary.Resolve): Handle pointer arithmetic
21570 Handle pointer comparission.
21571 (ArrayPtr): Utility expression class that is used to take the
21572 address of an array.
21574 (ElementAccess): Implement array access for pointers
21576 * statement.cs (Fixed): Implement fixed statement for arrays, we
21577 are missing one more case before we are done.
21579 * expression.cs (Indirection): Implement EmitAssign and set the
21580 ExprClass to Variable. This allows pointer dereferences to be
21581 treated as variables, and to have values assigned to them.
21583 * ecore.cs (Expression.StoreFromPtr): New utility function to
21584 store values dereferencing.
21586 2002-02-20 Ravi Pratap <ravi@ximian.com>
21588 * expression.cs (Binary.ResolveOperator): Ensure that we are
21589 not trying to operate on a void type - this fixes the reported
21592 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21593 the parent implementation is sealed.
21595 * ../errors/cs0239.cs : Add.
21597 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21599 * typemanager.cs (unverifiable_code_type): Corresponds to
21600 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21601 which have unsafe code in them.
21603 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21606 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21608 * cs-tokenizer.cs: Add support for @"litreal strings"
21610 Make tokenizer accept pre-processor directives
21611 on any column (remove the old C-like limitation).
21613 * rootcontext.cs (EmitCode): Emit any global attributes.
21614 (AddGlobalAttributes): Used to keep track of assembly attributes.
21616 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21618 * cs-parser.jay: Add support for global attributes.
21620 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21622 * expression.cs (Indirection): New helper class. Unary will
21623 create Indirection classes to be able to implement the
21624 IMemoryLocation interface on it.
21626 2002-02-16 Miguel de Icaza <miguel@ximian.com>
21628 * cs-parser.jay (fixed_statement): reference the right statement.
21630 * statement.cs (Fixed.Emit): Finish implementing the fixed
21631 statement for the &x case.
21633 2002-02-14 Miguel de Icaza <miguel@ximian.com>
21635 * class.cs (Property.Define, Method.Define): Remove newslot when
21638 * modifiers.cs: My use of NewSlot when `Abstract' was set was
21639 wrong. NewSlot should only be used if the `new' keyword is present.
21641 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
21642 locating our system dir. Sorry about this.
21644 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21646 * driver.cs (GetSystemDir): Compute correctly the location of our
21647 system assemblies. I was using the compiler directory instead of
21648 the library directory.
21650 2002-02-13 Ravi Pratap <ravi@ximian.com>
21652 * expression.cs (BetterFunction): Put back in what Miguel commented out
21653 since it is the correct fix. The problem is elsewhere ;-)
21655 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
21656 parameters of the parms method are themselves compatible or not !
21658 (StandardConversionExists): Fix very dangerous bug where we were forgetting
21659 to check that a class implements an interface before saying that an implicit
21660 conversion was allowed. Use ImplementsInterface to do the checking.
21662 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21664 * class.cs (Method.Define): Track whether we are an explicit
21665 implementation or not. And only call DefineMethodOverride if we
21666 are an explicit implementation.
21668 (Property.DefineMethod): Ditto.
21670 2002-02-11 Ravi Pratap <ravi@ximian.com>
21672 * expression.cs (BetterFunction): Catch hideous bug which was
21673 preventing us from detecting ambiguous calls due to implicit casts i.e
21676 2002-01-29 Miguel de Icaza <miguel@ximian.com>
21678 * support.cs (Pair): Remove un-needed method. I figured why I was
21679 getting the error in cs-parser.jay, the variable in a foreach loop
21680 is readonly, and the compiler does not really treat this as a variable.
21682 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
21683 instead of EQUALS in grammar.
21685 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
21687 * expression.cs (Unary.DoResolve): Check whether the argument is
21690 2002-01-28 Miguel de Icaza <miguel@ximian.com>
21692 * support.cs: Api for Pair to set a value. Despite the fact that
21693 the variables are public the MS C# compiler refuses to compile
21694 code that accesses the field if the variable is part of a foreach
21697 * statement.cs (Fixed): Begin implementation of the fixed
21700 (Block.AddVariable): Return the VariableInfo on success and null
21701 on failure instead of true/false.
21703 * cs-parser.jay (foreach): Catch errors on variables already
21704 defined (we were ignoring this value before) and properly unwind
21705 the block hierarchy
21707 (fixed_statement): grammar for the fixed statement.
21709 2002-01-25 Miguel de Icaza <miguel@ximian.com>
21711 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
21712 pointer types to be incretemented.
21714 (SizeOf): Implement.
21716 * cs-parser.jay (pointer_member_access): Implement
21717 expr->IDENTIFIER production.
21719 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
21720 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
21723 (Unary): Implement indirection.
21725 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
21726 use in non-unsafe context).
21728 (SimpleName.DoResolve): Check for pointers in field access on safe
21731 (Expression.LoadFromPtr): Factor the load-indirect code in this
21732 function. This was duplicated in UnboxCast and ParameterReference
21734 2002-01-24 Miguel de Icaza <miguel@ximian.com>
21736 * expression.cs (ComposedCast): report an error if a pointer cast
21737 is used in a safe region.
21739 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
21740 pointer type casts in unsafe context.
21742 * codegen.cs (EmitContext): Set up IsUnsafe.
21744 * cs-parser.jay (non_expression_type): Add productions for pointer
21747 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
21748 code. We should not use force into static mode if the method is
21749 not virtual. Fixes bug in MIS
21751 * statement.cs (Do.Emit, While.Emit, For.Emit,
21752 Statement.EmitBoolExpression): Add support to Do and While to
21753 propagate infinite loop as `I do return' semantics.
21755 Improve the For case to also test for boolean constants.
21757 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
21758 to the list of attributes we can add.
21760 Remove `EmitContext' argument.
21762 * class.cs (Method.Define): Apply parameter attributes.
21763 (Constructor.Define): Apply parameter attributes.
21764 (MethodCore.LabelParameters): Move here the core of labeling
21767 * support.cs (ReflectionParameters.ParameterModifier,
21768 InternalParameters.ParameterModifier): Use IsByRef on the type and
21769 only return the OUT bit for these parameters instead of in/out/ref
21772 This is because I miss-understood things. The ParameterInfo.IsIn
21773 and IsOut represent whether the parameter has the [In] and [Out]
21776 2002-01-22 Miguel de Icaza <miguel@ximian.com>
21778 * ecore.cs (FieldExpr.Emit): Release temporaries.
21780 * assign.cs (LocalTemporary.Release): new function.
21782 * codegen.cs (EmitContext.GetTemporaryStorage,
21783 EmitContext.FreeTemporaryStorage): Rework the way we deal with
21784 temporary storage. Now we can "put back" localbuilders when we
21787 2002-01-21 Miguel de Icaza <miguel@ximian.com>
21789 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
21790 need to make a copy of the variable to generate verifiable code.
21792 2002-01-19 Miguel de Icaza <miguel@ximian.com>
21794 * driver.cs: Compute dynamically the system directory.
21796 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
21797 Slower, but more generally useful. Used by the abstract
21798 registering implementation.
21800 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
21801 the rules for the special rule on Type/instances. First check if
21802 we have the same name, and if so, try that special static path
21803 rather than the instance path.
21805 2002-01-18 Miguel de Icaza <miguel@ximian.com>
21807 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
21810 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
21811 Enum, ValueType, Delegate or Array for non-corlib compiles.
21813 * cs-tokenizer.cs: Catch long identifiers (645)
21815 * typemanager.cs (IndexerPropetyName): Ravi never tested this
21818 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
21819 fix, we were returning too early, so we were not registering
21820 pending methods from abstract classes.
21822 Do not register pending methods if the class is abstract.
21824 * expression.cs (Conditional.DoResolve): Report circular implicit
21825 conversions when we neecd to compute it for conditional
21828 (Is.DoResolve): If the expression is always of the provided type,
21829 flag warning 183. If the expression can not ever be of the
21830 provided type flag warning 184.
21832 * class.cs: Catch 169 as well.
21834 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
21837 2002-01-18 Nick Drochak <ndrochak@gol.com>
21839 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
21841 2002-01-17 Miguel de Icaza <miguel@ximian.com>
21843 * interface.cs: (PopulateMethod): Check for pointers being defined
21844 only if the unsafe context is active.
21845 (PopulateProperty): ditto.
21846 (PopulateIndexer): ditto.
21848 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
21849 specified. If pointers are present, make sure that they are
21850 present in an unsafe context.
21851 (Constructor, Constructor.Define): ditto.
21852 (Field, Field.Define): ditto.
21853 (Property, Property.Define): ditto.
21854 (Event, Event.Define): ditto.
21856 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
21857 hashtable if there are classes or structs defined.
21859 * expression.cs (LocalVariableReference.DoResolve): Simplify this
21860 code, as the constant resolution moved.
21862 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
21863 the metadata, so we can flag error 133.
21865 * decl.cs (MemberCore.UnsafeOK): New function to test that a
21866 pointer is being declared in an unsafe context.
21868 2002-01-16 Miguel de Icaza <miguel@ximian.com>
21870 * modifiers.cs (Modifiers.Check): Require a Location argument.
21871 Report error 227 for Unsafe use.
21873 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
21875 * statement.cs (For.Emit): If the test is null, then report that
21876 we do `return', as we wont reach anything afterwards.
21878 (Switch.SwitchGoverningType): Track the expression that matched
21881 * driver.cs: Allow negative numbers as an error code to flag.
21883 * cs-parser.jay: Handle 1551.
21885 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
21887 2002-01-15 Miguel de Icaza <miguel@ximian.com>
21889 * cs-parser.jay: Report 1518 (type declaration can only contain
21890 class, struct, interface, enum or delegate)
21892 (switch_label): Report 1523 (keywords `case' or `default' must
21895 (opt_switch_sections): Report 1522 (empty switch)
21897 * driver.cs: Report 1515 (response file specified multiple times)
21898 Report 1516 (Source file specified multiple times).
21900 * expression.cs (Argument.Resolve): Signal 1510
21902 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
21903 access not allowed in static code)
21905 2002-01-11 Ravi Pratap <ravi@ximian.com>
21907 * typemanager.cs (IsPointerType): Utility method which we are going
21910 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
21911 the object type, so we take care of that.
21913 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
21915 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
21916 added to non-params parameters :-)
21918 * typemanager.cs (CSharpName): Include 'void' type too.
21920 (void_ptr_type): Include in the set of core types.
21922 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
21925 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
21928 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
21929 completely forgotten about it.
21931 2002-01-10 Ravi Pratap <ravi@ximian.com>
21933 * cs-parser.jay (pointer_type): Add. This begins our implementation
21934 of parsing rules for unsafe code.
21936 (unsafe_statement): Implement.
21938 (embedded_statement): Modify to include the above.
21940 * statement.cs (Unsafe): Implement new class for unsafe blocks.
21942 * codegen.cs (EmitContext.InUnsafe): Add. This determines
21943 if the current context is an unsafe one.
21945 * cs-parser.jay (local_variable_pointer_type): Since local variable types
21946 are handled differently, we need separate rules for them.
21948 (local_variable_declaration): Update to use local_variable_pointer_type
21949 to allow variable declarations of unmanaged pointer types.
21951 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
21952 in unsafe contexts.
21954 * ../errors/cs0214.cs : Add.
21956 2002-01-16 Nick Drochak <ndrochak@gol.com>
21958 * makefile: remove 'response' file when cleaning.
21960 2002-01-15 Miguel de Icaza <miguel@ximian.com>
21962 * cs-parser.jay: Report 1524.
21964 2002-01-14 Miguel de Icaza <miguel@ximian.com>
21966 * typemanager.cs (RegisterMethod): drop checking if we have
21967 registered this from here
21969 2002-01-12 Miguel de Icaza <miguel@ximian.com>
21971 * class.cs (Method.EmitDestructor): Implement calling our base
21974 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
21975 value of InFinally.
21977 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
21978 this routine and will wrap the call in a try/catch block. Deal
21981 2002-01-11 Miguel de Icaza <miguel@ximian.com>
21983 * ecore.cs (Expression.MemberLookup): instead of taking a
21984 parameter `same_type' that was used to tell whether we could
21985 access private members we compute our containing type from the
21988 (FieldExpr): Added partial support for volatile fields. This does
21989 not work for volatile fields exposed from assemblies, as I can not
21990 figure out how to extract the modreq from it.
21992 Updated all the source files to use this.
21994 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
21995 because it is referenced by MemberLookup very often.
21997 2002-01-09 Ravi Pratap <ravi@ximian.com>
21999 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
22000 TypeBuilder.GetCustomAttributes to retrieve what we need.
22002 Get rid of redundant default_member_attr_type as this is the same as
22003 default_member_type which already exists.
22005 * interface.cs, attribute.cs : Update accordingly.
22007 2002-01-08 Miguel de Icaza <miguel@ximian.com>
22009 * typemanager.cs: Enable IndexerPropertyName again. It does not
22010 work for TYpeBuilders though. Ravi, can you please fix this?
22012 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22014 * expression.cs (Argument.Emit): Handle the case of ref objects
22015 being passed to ref functions;
22017 (ParameterReference.EmitLoad): Loads the content of the pointer
22018 without dereferencing.
22020 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22022 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22024 2002-01-08 Ravi Pratap <ravi@ximian.com>
22026 * class.cs (Indexer.DefineMethod): Incorporate the interface
22027 type in the name of the method if we are doing explicit interface
22030 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22032 (BetterConversion): Fix extremely trivial bug where we were referring to
22033 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22036 * ../errors/bug16.cs : Add although we have fixed it.
22038 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22040 * expression.cs (BaseIndexer): Begin implementation.
22042 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22044 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22045 production directly to remove a shift/reduce, and implement
22046 explicit interface implementation.
22048 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22049 after a floating point suffix.
22051 * expression.cs (DoNumericPromotions): Improved the conversion for
22052 uint/uint. If we have a constant, we avoid doing a typecast to a
22055 * class.cs (Indexer): Implement explicit interface implementation
22058 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22060 * class.cs: make the default instance constructor public and hidebysig.
22062 2001-01-03 Ravi Pratap <ravi@ximian.com>
22064 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22065 so we can call it from elsewhere.
22067 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22068 we emit it internally if the class has a defined indexer; otherwise the user
22069 emits it by decorating the class definition with the DefaultMemberAttribute.
22071 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22072 attribute is not used on a type which defines an indexer.
22074 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22075 character when we skip whitespace.
22077 * ../errors/cs0646.cs : Add.
22079 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22081 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22084 * makefile: Add practical target `mcs3.exe' which builds the third
22085 generation compiler.
22087 * expression.cs (New): Fix structures constructor calling.
22089 * class.cs (Property, Method, Indexer): Emit Final flag on the
22090 method if we are an interface implementation and we are not
22093 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22094 whether this property is referencing a `base' method.
22096 * expression.cs (Invocation.EmitCall): take an extra argument:
22097 is_base, this is used to determine whether the `call' or
22098 `callvirt' opcode should be used.
22101 * delegate.cs: update EmitCall.
22103 * class.cs (Method.Define): Set NewSlot for the cases where we are
22104 not implementing an interface method.
22106 (Property.Define): ditto.
22108 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22110 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22111 'r'. Allows mcs to parse itself fully.
22113 2002-01-02 Ravi Pratap <ravi@ximian.com>
22115 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22116 of the number of initializers that require the InitializeArray method.
22118 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22119 update the above field where necessary.
22121 (MakeByteBlob): Update accordingly.
22123 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22126 (EmitDynamicInitializers): Update in accordance with the new optimization.
22128 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22129 same OpCode applies.
22131 * cs-parser.jay : Fix some glaring errors I introduced.
22133 2002-01-01 Ravi Pratap <ravi@ximian.com>
22135 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22136 so that we can check for name clashes there too.
22138 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22139 for interface indexers.
22141 * interfaces.cs (Define): Emit the default member attribute.
22143 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22144 variable was being referred to while setting the value ;-)
22146 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22148 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22149 byte-by-byte information when we know the data is zero.
22151 Make the block always a multiple of 4, because
22152 DefineInitializedData has a bug.
22154 * assign.cs: Fix, we should assign from the temporary, not from
22157 * expression.cs (MakeByteBlob): Fix my incorrect code.
22159 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22161 * typemanager.cs (EnumToUnderlying): This function is used to get
22162 the underlying type from an enumeration, because it does not
22165 * constant.cs: Use the I4_S form for values between -128 and 127.
22167 * statement.cs (Block.LookupLabel): Looks up a label.
22168 (Block): Drop support for labeled blocks.
22170 (LabeledStatement): New kind of statement that represents a label
22173 (Goto): Finally implement this bad boy.
22175 * cs-parser.jay: Update to reflect new mechanism to implement
22178 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22180 * codegen.cs (EmitContext.This): a codegen property that keeps the
22181 a single instance of this instead of creating many different this
22184 * delegate.cs (Delegate.DoResolve): Update to use the property;
22186 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22188 * expression.cs (BaseAccess.DoResolve): Ditto.
22190 2001-12-29 Ravi Pratap <ravi@ximian.com>
22192 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22193 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22195 (InitCoreTypes): Update accordingly.
22197 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22198 so we can quickly store the state.
22200 (ApplyAttributes): Set the correct implementation flags
22201 for InternalCall methods.
22203 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22205 * expression.cs (EmitCall): if a method is not virtual, then do
22206 not use callvirt on it.
22208 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22209 user defined stuff) requires the use of stobj, which takes an
22210 address on the stack instead of an array and an index. So emit
22211 the Ldelema operation for it.
22213 (EmitStoreOpcode): Use stobj for valuetypes.
22215 (UnaryMutator.EmitCode): Use the right 1 value depending on
22216 whether we are dealing with int64/uint64, float or doubles.
22218 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22219 constructors that I implemented last night.
22221 (Constructor.IsDefault): Fix to work properly for static
22224 * cs-parser.jay (CheckDef): report method signature errors.
22225 Update error number 103 to be 132.
22227 * decl.cs: New AdditionResult enumeration value: MethodExists.
22228 Although we do this check for methods later on in the semantic
22229 analysis, catching repeated default constructors is so easy that
22230 we catch these here.
22232 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22235 (ParameterReference.EmitAssign, Emit): handle
22238 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22239 (ArrayAccess.EmitStoreOpcode): ditto.
22241 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22243 * expression.cs (MakeByteBlob): Complete all the missing types
22244 (uint, short, ushort, byte, sbyte)
22246 * class.cs: Only init instance field initializers on instance
22249 Rename `constructors' to instance_constructors.
22251 (TypeContainer.AddConstructor): Only add constructors to the list
22252 if it is not static.
22254 Make sure that we handle default_static_constructor independently
22255 everywhere where we handle instance_constructors
22257 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22259 * class.cs: Do not lookup or create a base initializer for a
22260 static constructor.
22262 (ConstructorInitializer.Resolve): use the proper type to lookup
22265 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22267 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22270 * decl.cs: CloseType is now an virtual method, the default
22271 implementation just closes this type.
22273 2001-12-28 Ravi Pratap <ravi@ximian.com>
22275 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22276 to PreserveSig by default. Also emit HideBySig on such methods.
22278 Basically, set the defaults to standard values.
22280 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22281 argument, if candidate is better, it can't be worse than the best !
22283 (Invocation): Re-write bits to differentiate between methods being
22284 applicable in their expanded form and their normal form - for params
22287 Get rid of use_standard everywhere as only standard conversions are allowed
22288 in overload resolution.
22290 More spec conformance.
22292 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22294 * driver.cs: Add --timestamp, to see where the compiler spends
22297 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22298 `this' in static code.
22300 (SimpleName.DoResolve): Implement in terms of a helper function
22301 that allows static-references to be passed upstream to
22304 (Expression.ResolveWithSimpleName): Resolve specially simple
22305 names when called by MemberAccess to implement the special
22308 (Expression.ImplicitReferenceConversion): Handle conversions from
22309 Null to reference types before others, as Null's type is
22312 * expression.cs (Invocation.EmitCall): Handle the special case of
22313 calling methods declared on a reference type from a ValueType
22314 (Base classes System.Object and System.Enum)
22316 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22317 the left hand side is a TypeExpr, not on every enumeration.
22319 (Binary.Resolve): If types are reference types, then do a cast to
22320 object on operators != and == of both arguments.
22322 * typemanager.cs (FindMembers): Extract instance and static
22323 members if requested.
22325 * interface.cs (PopulateProperty): Use void_type instead of null
22326 as the return type for the setter method.
22328 (PopulateIndexer): ditto.
22330 2001-12-27 Ravi Pratap <ravi@ximian.com>
22332 * support.cs (ReflectionParameters): Fix minor bug where we
22333 were examining the wrong parameter for the ParamArray attribute.
22335 Cope with requests for the type of the parameter at position
22336 greater than the params parameter's. We now return the element
22337 type of the params array as that makes more sense.
22339 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22340 accordingly as we no longer have to extract the element type
22343 (Invocation.OverloadResolve): Update.
22345 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22347 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22348 against IEnumerator, test whether the return value is a descendant
22349 of the IEnumerator interface.
22351 * class.cs (Indexer.Define): Use an auxiliary method to implement
22352 the other bits of the method definition. Begin support for
22353 explicit interface implementation.
22355 (Property.DefineMethod): Use TypeManager.void_type instead of null
22356 for an empty return value.
22358 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22360 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22361 dealing with a FieldExpr which is composed of a FieldBuilder, in
22362 the code path we did extract the constant, but we should have
22363 obtained the underlying value to be able to cast it (otherwise we
22364 end up in an infinite loop, this is what Ravi was running into).
22366 (ArrayCreation.UpdateIndices): Arrays might be empty.
22368 (MemberAccess.ResolveMemberAccess): Add support for section
22369 14.5.4.1 that deals with the special case of E.I when E is a type
22370 and something else, that I can be a reference to a static member.
22372 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22373 handle a particular array type to create byte blobs, it is just
22374 something we dont generate byteblobs for.
22376 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22379 * location.cs (Push): remove the key from the hashtable that we
22380 are about to add. This happens for empty files.
22382 * driver.cs: Dispose files after we have parsed them.
22384 (tokenize): new function that only runs the tokenizer on its
22385 input, for speed testing.
22387 2001-12-26 Ravi Pratap <ravi@ximian.com>
22389 * class.cs (Event.Define): Define the private field only if there
22390 are no accessors defined.
22392 * expression.cs (ResolveMemberAccess): If there is no associated
22393 field with the event, that means we have an event defined with its
22394 own accessors and we should flag error cs0070 since transforming
22395 ourselves into a field is not valid in that case.
22397 * ecore.cs (SimpleName.DoResolve): Same as above.
22399 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22400 and charset to sane values.
22402 2001-12-25 Ravi Pratap <ravi@ximian.com>
22404 * assign.cs (DoResolve): Perform check on events only if they
22405 are being accessed outside the declaring type.
22407 * cs-parser.jay (event_declarations): Update rules to correctly
22408 set the type of the implicit parameter etc.
22410 (add_accessor, remove_accessor): Set current local parameters.
22412 * expression.cs (Binary): For delegate addition and subtraction,
22413 cast the return value from the method into the appropriate delegate
22416 2001-12-24 Ravi Pratap <ravi@ximian.com>
22418 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22419 of these as the workaround is unnecessary.
22421 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22422 delegate data - none of that is needed at all.
22424 Re-write bits to extract the instance expression and the delegate method
22427 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22430 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22431 of attaching attributes instead of duplicating code everywhere.
22433 * everywhere : Update code to do attribute emission using the above method.
22435 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22437 * expression.cs (IsParamsMethodApplicable): if there are not
22438 parameters, return immediately.
22440 * ecore.cs: The 0 literal can be implicity converted to an enum
22443 (SimpleName.DoResolve): First lookup the type, then lookup the
22446 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22447 want to get its address. If the InstanceExpression is not
22448 addressable, store the result in a temporary variable, then get
22451 * codegen.cs: Only display 219 errors on warning level or above.
22453 * expression.cs (ArrayAccess): Make it implement the
22454 IMemoryLocation interface.
22456 (Binary.DoResolve): handle the operator == (object a, object b)
22457 and operator != (object a, object b) without incurring into a
22458 BoxedCast (because 5 != o should never be performed).
22460 Handle binary enumerator operators.
22462 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22463 value type, otherwise use Ldelem_ref.
22465 Use precomputed names;
22467 (AddressOf): Implement address of
22469 * cs-parser.jay (labeled_statement): Fix recursive block
22470 addition by reworking the production.
22472 * expression.cs (New.DoEmit): New has a special case:
22474 If we are dealing with a ValueType, we have a few
22475 situations to deal with:
22477 * The target of New is a ValueType variable, that is
22478 easy, we just pass this as the variable reference
22480 * The target of New is being passed as an argument,
22481 to a boxing operation or a function that takes a
22484 In this case, we need to create a temporary variable
22485 that is the argument of New.
22488 2001-12-23 Ravi Pratap <ravi@ximian.com>
22490 * rootcontext.cs (LookupType): Check that current_type is not null before
22491 going about looking at nested types.
22493 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22494 not implement the IAssignMethod interface any more.
22496 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22497 where we tranform them into FieldExprs if they are being resolved from within
22498 the declaring type.
22500 * ecore.cs (SimpleName.DoResolve): Do the same here.
22502 * assign.cs (DoResolve, Emit): Clean up code considerably.
22504 * ../errors/bug10.cs : Add.
22506 * ../errors/cs0070.cs : Add.
22508 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22510 * assign.cs : Get rid of EventIsLocal everywhere.
22512 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22514 * ecore.cs (ConvertIntLiteral): finished the implementation.
22516 * statement.cs (SwitchLabel): Convert the value we are using as a
22517 key before looking up the table.
22519 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22521 * codegen.cs (EmitTopBlock): Require a Location argument now.
22523 * cs-parser.jay (constructor_declarator): We need to setup
22524 current_local_parameters before we parse the
22525 opt_constructor_initializer, to allow the variables to be bound
22526 to the constructor arguments.
22528 * rootcontext.cs (LookupType): First lookup nested classes in our
22529 class and our parents before we go looking outside our class.
22531 * expression.cs (ConstantFold): Extract/debox the values at the
22534 * rootcontext.cs (EmitCode): Resolve the constants first before we
22535 resolve the types. This is not really needed, but it helps debugging.
22537 * statement.cs: report location.
22539 * cs-parser.jay: pass location to throw statement.
22541 * driver.cs: Small bug fix.
22543 * report.cs: Updated format to be 4-zero filled digits.
22545 2001-12-22 Ravi Pratap <ravi@ximian.com>
22547 * expression.cs (CheckIndices): Fix minor bug where the wrong
22548 variable was being referred to ;-)
22550 (DoEmit): Do not call EmitStaticInitializers when the
22551 underlying type is System.Object.
22553 2001-12-21 Ravi Pratap <ravi@ximian.com>
22555 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22556 and do the usual workaround for SRE.
22558 * class.cs (MyEventBuilder.EventType): New member to get at the type
22559 of the event, quickly.
22561 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22563 * assign.cs (Assign.DoResolve): Handle the case when the target
22564 is an EventExpr and perform the necessary checks.
22566 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22569 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22571 (EventExpr): Set the type in the constructor itself since we
22572 are meant to be born fully resolved.
22574 (EventExpr.Define): Revert code I wrote earlier.
22576 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22577 instance expression is null. The instance expression is a This in that case
22578 or a null, depending on whether it is a static method or not.
22580 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22581 refers to more than one method.
22583 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22584 and accordingly flag errors.
22586 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22588 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22590 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22592 * location.cs (ToString): Provide useful rutine.
22594 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22596 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22597 objects, return the actual integral boxed.
22599 * statement.cs (SwitchLabel): define an ILLabel for each
22602 (Switch.CheckSwitch): If the value is a Literal, extract
22603 the underlying literal.
22605 Also in the unused hashtable we had, add the SwitchLabel so we can
22606 quickly look this value up.
22608 * constant.cs: Implement a bunch of new constants. Rewrite
22609 Literal based on this. Made changes everywhere to adapt to this.
22611 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22612 dereferencing array only once, and also copes with enumrations.
22614 bytes are two bytes wide, not one.
22616 (Cast): Perform constant conversions.
22618 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22619 wrappers to the literals here.
22621 * expression.cs (DoNumericPromotions): long literals can converted
22622 to ulong implicity (this is taken care of elsewhere, but I was
22623 missing this spot).
22625 * ecore.cs (Expression.Literalize): Make the return type Literal,
22626 to improve type checking.
22628 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
22630 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22632 * literal.cs: Revert code from ravi that checked the bounds. The
22633 bounds are sane by the definition of the type itself.
22635 * typemanager.cs: Fix implementation of ImplementsInterface. We
22636 need to actually look up in our parent hierarchy for interfaces
22639 * const.cs: Use the underlying type for enumerations
22641 * delegate.cs: Compute the basename for the delegate creation,
22642 that should fix the delegate test case, and restore the correct
22643 Type Lookup semantics in rootcontext
22645 * rootcontext.cs: Revert Ravi's last patch. The correct way of
22646 referencing a nested type with the Reflection API is using the "+"
22649 * cs-parser.jay: Do not require EOF token at the end.
22651 2001-12-20 Ravi Pratap <ravi@ximian.com>
22653 * rootcontext.cs (LookupType): Concatenate type names with
22654 a '.' instead of a '+' The test suite passes again.
22656 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
22657 field of the enumeration.
22659 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
22660 the case when the member is an EventExpr.
22662 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
22663 static has an associated instance expression.
22665 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
22667 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
22669 * class.cs (Event.Define): Register event and perform appropriate checks
22672 We define the Add and Remove methods even if the use provides none because
22673 in that case, we provide default implementations ourselves.
22675 Define a private field of the type of the event. This is done by the CSC compiler
22676 and we should be doing it too ;-)
22678 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
22679 More methods we use in code we generate.
22681 (multicast_delegate_type, delegate_type): Two separate types since the distinction
22684 (InitCoreTypes): Update accordingly for the above.
22686 * class.cs (Event.Emit): Generate code for default accessors that we provide
22688 (EmitDefaultMethod): Do the job in the above.
22690 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
22693 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22695 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
22696 builders even if we were missing one.
22698 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
22699 pass the Basename as our class name instead of the Name. The
22700 basename will be correctly composed for us.
22702 * parameter.cs (Paramters): Now takes a Location argument.
22704 * decl.cs (DeclSpace.LookupType): Removed convenience function and
22705 make all the code call directly LookupType in RootContext and take
22706 this chance to pass the Location information everywhere.
22708 * Everywhere: pass Location information.
22710 2001-12-19 Miguel de Icaza <miguel@ximian.com>
22712 * class.cs (Constructor.Define): Updated way of detecting the
22713 length of the parameters.
22715 (TypeContainer.DefineType): Use basename as the type name for
22718 (TypeContainer.Define): Do not recursively define types here, as
22719 definition is taken care in order by the RootContext.
22721 * tree.cs: Keep track of namespaces in a per-file basis.
22723 * parameter.cs (Parameter.ComputeSignature): Update to use
22726 (Parameters.GetSignature): ditto.
22728 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
22729 instead of a TypeContainer.
22731 (Interface.SemanticAnalysis): Use `this' instead of our parent to
22732 resolve names. Because we need to be resolve in our context, not
22735 * driver.cs: Implement response files.
22737 * class.cs (TypeContainer.DefineType): If we are defined, do not
22738 redefine ourselves.
22740 (Event.Emit): Emit the code for add/remove handlers.
22741 (Event.Define): Save the MethodBuilders for add/remove.
22743 * typemanager.cs: Use pair here too.
22745 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
22746 DictionaryEntry requires the first argument to be non-null.
22748 (enum_declaration): Compute full name for registering the
22751 (delegate_declaration): Instead of using
22752 formal_parameter_list, use opt_formal_parameter_list as the list
22755 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
22756 (EventParsing): New property that controls whether `add' and
22757 `remove' are returned as tokens or identifiers (for events);
22759 2001-12-19 Ravi Pratap <ravi@ximian.com>
22761 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
22762 use MyEventBuilder only and let it wrap the real builder for us.
22764 (MyEventBuilder): Revamp constructor etc.
22766 Implement all operations that we perform on EventBuilder in precisely the same
22769 (FindMembers): Update to use the EventBuilder member.
22771 (Event.Emit): Update accordingly.
22773 2001-12-18 Ravi Pratap <ravi@ximian.com>
22775 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
22776 by calling the appropriate methods.
22778 (GetCustomAttributes): Make stubs as they cannot possibly do anything
22781 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
22783 2001-12-17 Ravi Pratap <ravi@ximian.com>
22785 * delegate.cs (Delegate.Populate): Check that the return type
22786 and various parameters types are indeed accessible.
22788 * class.cs (Constructor.Define): Same here.
22790 (Field.Define): Ditto.
22792 (Event.Define): Ditto.
22794 (Operator.Define): Check that the underlying Method defined itself
22795 correctly - so it's MethodBuilder should not be null.
22797 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
22798 expression happens to be null.
22800 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
22801 members but as of now we don't seem to be able to do anything really useful with it.
22803 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
22804 not the EventBuilder.
22806 2001-12-18 Miguel de Icaza <miguel@ximian.com>
22808 * cs-tokenizer.cs: Add support for defines.
22809 Add support for #if, #elif, #else, #endif
22811 (eval_var): evaluates a variable.
22812 (eval): stubbed for evaluating functions.
22814 * cs-parser.jay: Pass the defines information
22816 * driver.cs: Add --define command line option.
22818 * decl.cs: Move MemberCore here.
22820 Make it the base class for DeclSpace. This allows us to catch and
22821 report 108 and 109 for everything now.
22823 * class.cs (TypeContainer.Define): Extract all the members
22824 before populating and emit the warning 108 (new keyword required
22825 to override) instead of having each member implement this.
22827 (MemberCore.Define): New abstract method, we will be using this in
22828 the warning reporting engine in Populate.
22830 (Operator.Define): Adjust to new MemberCore protocol.
22832 * const.cs (Const): This does not derive from Expression, it is a
22833 temporary object we use to create fields, it is a MemberCore.
22835 * class.cs (Method.Define): Allow the entry point to be in a
22838 * driver.cs: Rewrite the argument handler to clean it up a bit.
22840 * rootcontext.cs: Made it just an auxiliary namespace feature by
22841 making everything static.
22843 * driver.cs: Adapt code to use RootContext type name instead of
22846 * delegate.cs: Remove RootContext argument.
22848 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
22851 * class.cs (Event.Define): The lookup can fail.
22853 * cs-tokenizer.cs: Begin implementation of pre-procesor.
22855 * expression.cs: Resolve the this instance before invoking the code.
22857 2001-12-17 Miguel de Icaza <miguel@ximian.com>
22859 * cs-parser.jay: Add a production in element_access that allows
22860 the thing to become a "type" reference. This way we can parse
22861 things like "(string [])" as a type.
22863 Note that this still does not handle the more complex rules of
22867 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
22869 * ecore.cs: (CopyNewMethods): new utility function used to
22870 assemble the list of methods from running FindMembers.
22872 (MemberLookup): Rework FindMembers so that
22874 2001-12-16 Miguel de Icaza <miguel@ximian.com>
22876 * class.cs (TypeContainer): Remove Delegates who fail to be
22879 * delegate.cs (Populate): Verify that we dont get null return
22880 values. TODO: Check for AsAccessible.
22882 * cs-parser.jay: Use basename to emit error 574 (destructor should
22883 have the same name as container class), not the full name.
22885 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
22886 possible representation.
22888 Also implements integer type suffixes U and L.
22890 2001-12-15 Miguel de Icaza <miguel@ximian.com>
22892 * expression.cs (ArrayCreation.DoResolve): We need to do the
22893 argument resolution *always*.
22895 * decl.cs: Make this hold the namespace. Hold the root context as
22897 (LookupType): Move here.
22899 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
22901 * location.cs (Row, Name): Fixed the code, it was always returning
22902 references to the first file.
22904 * interface.cs: Register properties defined through interfaces.
22906 * driver.cs: Add support for globbing on the command line
22908 * class.cs (Field): Make it derive from MemberCore as well.
22911 2001-12-15 Ravi Pratap <ravi@ximian.com>
22913 * class.cs (Event::Define): Check that the type of the event is a delegate
22914 type else flag error #66.
22916 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
22919 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
22920 values of EntryPoint, CharSet etc etc.
22922 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
22924 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
22925 be null and we should ignore this. I am not sure if this is really clean. Apparently,
22926 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
22927 which needs this to do its work.
22929 * ../errors/cs0066.cs : Add.
22931 2001-12-14 Miguel de Icaza <miguel@ximian.com>
22933 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
22936 * class.cs: (MethodSignature.MethodSignature): Removed hack that
22937 clears out the parameters field.
22938 (MemberSignatureCompare): Cleanup
22940 (MemberCore): New base class used to share code between MethodCore
22943 (RegisterRequiredImplementations) BindingFlags.Public requires
22944 either BindingFlags.Instace or Static. Use instance here.
22946 (Property): Refactored code to cope better with the full spec.
22948 * parameter.cs (GetParameterInfo): Return an empty array instead
22951 * class.cs (Property): Abstract or extern properties have no bodies.
22953 * parameter.cs (GetParameterInfo): return a zero-sized array.
22955 * class.cs (TypeContainer.MethodModifiersValid): Move all the
22956 method modifier validation to the typecontainer so we can reuse
22957 this on properties.
22959 (MethodCore.ParameterTypes): return an empty sized array of types.
22961 (Property.Define): Test property modifier validity.
22963 Add tests for sealed/override too.
22965 (Method.Emit): abstract or extern methods have no bodies.
22967 2001-12-14 Ravi Pratap <ravi@ximian.com>
22969 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
22972 (Method::Define, ::Emit): Modify accordingly.
22974 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
22976 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
22978 * makefile: Pass in /unsafe.
22980 2001-12-13 Miguel de Icaza <miguel@ximian.com>
22982 * class.cs (MakeKey): Kill routine.
22984 * class.cs (TypeContainer.Define): Correctly define explicit
22985 method implementations (they require the full interface name plus
22988 * typemanager.cs: Deply the PtrHashtable here and stop using the
22989 lame keys. Things work so much better.
22991 This of course broke everyone who depended on `RegisterMethod' to
22992 do the `test for existance' test. This has to be done elsewhere.
22994 * support.cs (PtrHashtable): A hashtable that avoid comparing with
22995 the object stupid Equals method (because, that like fails all over
22996 the place). We still do not use it.
22998 * class.cs (TypeContainer.SetRequiredInterface,
22999 TypeContainer.RequireMethods): Killed these two routines and moved
23000 all the functionality to RegisterRequiredImplementations.
23002 (TypeContainer.RegisterRequiredImplementations): This routine now
23003 registers all the implementations required in an array for the
23004 interfaces and abstract methods. We use an array of structures
23005 which can be computed ahead of time to reduce memory usage and we
23006 also assume that lookups are cheap as most classes will not
23007 implement too many interfaces.
23009 We also avoid creating too many MethodSignatures.
23011 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23012 clear the "pending" bit if we find that there are problems with
23015 (TypeContainer.VerifyPendingMethods): Update to report errors of
23016 methods that look like implementations but are not.
23018 (TypeContainer.Define): Add support for explicit interface method
23021 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23023 * typemanager.cs: Keep track of the parameters here instead of
23024 being a feature of the TypeContainer.
23026 * class.cs: Drop the registration of parameters here, as
23027 InterfaceMethods are also interface declarations.
23029 * delegate.cs: Register methods with the TypeManager not only with
23030 the TypeContainer. This code was buggy.
23032 * interface.cs: Full registation here.
23034 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23036 * expression.cs: Remove reducer for binary expressions, it can not
23039 * const.cs: Put here the code that used to go into constant.cs
23041 * constant.cs: Put here the code for constants, this is a new base
23042 class for Literals.
23044 * literal.cs: Make Literal derive from Constant.
23046 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23048 * statement.cs (Return.Emit): Report error 157 if the user
23049 attempts to return from a finally block.
23051 (Return.Emit): Instead of emitting a return, jump to the end of
23054 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23055 LocalBuilder to store the result of the function. ReturnLabel is
23056 the target where we jump.
23059 2001-12-09 Radek Doulik <rodo@ximian.com>
23061 * cs-parser.jay: remember alias in current namespace
23063 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23066 * class.cs (LookupAlias): lookup alias in my_namespace
23068 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23070 (LookupAlias): lookup alias in this and if needed in parent
23073 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23077 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23078 making things static. I need this to avoid passing the
23079 TypeContainer when calling ParameterType.
23081 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23082 that did string manipulation to compute the type and then call
23083 GetType. Use Parameter.ParameterType instead.
23085 * cs-tokenizer.cs: Consume the suffix for floating values.
23087 * expression.cs (ParameterReference): figure out whether this is a
23088 reference parameter or not. Kill an extra variable by computing
23089 the arg_idx during emission.
23091 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23092 function that returns whether a parameter is an out/ref value or not.
23094 (Parameter.ParameterType): The type of the parameter (base,
23095 without ref/out applied).
23097 (Parameter.Resolve): Perform resolution here.
23098 (Parameter.ExternalType): The full type (with ref/out applied).
23100 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23101 support for expressions on the using statement.
23103 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23105 * statement.cs (Using.EmitLocalVariableDecls): Split the
23106 localvariable handling of the using statement.
23108 (Block.EmitMeta): Keep track of variable count across blocks. We
23109 were reusing slots on separate branches of blocks.
23111 (Try.Emit): Emit the general code block, we were not emitting it.
23113 Check the type of the declaration to be an IDisposable or
23114 something that can be implicity converted to it.
23116 Emit conversions if required.
23118 * ecore.cs (EmptyExpression): New utility class.
23119 (Expression.ImplicitConversionExists): New utility function.
23121 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23123 * statement.cs (Using): Implement.
23125 * expression.cs (LocalVariableReference): Support read only variables.
23127 * statement.cs: Remove the explicit emit for the Leave opcode.
23128 (VariableInfo): Add a readonly field.
23130 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23132 * ecore.cs (ConvCast): new class used to encapsulate the various
23133 explicit integer conversions that works in both checked and
23134 unchecked contexts.
23136 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23137 properly generate the overflow opcodes.
23139 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23141 * statement.cs: The correct type for the EmptyExpression is the
23142 element_type, not the variable type. Ravi pointed this out.
23144 2001-12-04 Ravi Pratap <ravi@ximian.com>
23146 * class.cs (Method::Define): Handle PInvoke methods specially
23147 by using DefinePInvokeMethod instead of the usual one.
23149 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23150 above to do the task of extracting information and defining the method.
23152 2001-12-04 Ravi Pratap <ravi@ximian.com>
23154 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23155 of the condition for string type.
23157 (Emit): Move that here.
23159 (ArrayCreation::CheckIndices): Keep string literals in their expression
23162 (EmitDynamicInitializers): Handle strings appropriately.
23164 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23166 * codegen.cs (EmitContext): Replace multiple variables with a
23167 single pointer to the current Switch statement.
23169 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23172 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23176 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23179 (Foreach.Emit): Foreach on arrays was not setting
23180 up the loop variables (for break/continue).
23182 (GotoCase): Semi-implented.
23184 2001-12-03 Ravi Pratap <ravi@ximian.com>
23186 * attribute.cs (CheckAttribute): Handle system attributes by using
23187 Attribute.GetAttributes to examine information we need.
23189 (GetValidPlaces): Same here.
23191 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23193 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23195 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23197 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23199 (Method::Emit): Handle the case when we are a PInvoke method.
23201 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23203 * expression.cs: Use ResolveWithSimpleName on compound names.
23205 2001-12-02 Ravi Pratap <ravi@ximian.com>
23207 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23208 before trying to reduce it.
23210 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23212 * constant.cs (LookupConstantValue): Implement.
23214 (EmitConstant): Use the above in emitting the constant.
23216 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23217 that are user-defined by doing a LookupConstantValue on them.
23219 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23222 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23224 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23226 (BaseAccess.DoResolve): Implement.
23228 (MemberAccess.DoResolve): Split this routine into a
23229 ResolveMemberAccess routine that can be used independently
23231 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23233 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23234 As that share bits of the implementation. Is returns a boolean,
23235 while As returns the Type that is being probed.
23237 2001-12-01 Ravi Pratap <ravi@ximian.com>
23239 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23240 instead of a Literal - much easier.
23242 (EnumInTransit): Remove - utterly useless :-)
23244 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23246 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23248 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23249 chain when we have no associated expression.
23251 2001-11-30 Ravi Pratap <ravi@ximian.com>
23253 * constant.cs (Define): Use Location while reporting the errror.
23255 Also emit a warning when 'new' is used and there is no inherited
23258 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23261 (LookupEnumValue): Implement to lookup an enum member's value and define it
23264 (Populate): Re-write accordingly to use the above routine.
23266 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23268 * expression.cs (This): Fix prototype for DoResolveLValue to
23269 override the base class DoResolveLValue.
23271 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23274 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23275 (we need to load the address of the field here). This fixes
23278 (FieldExpr.DoResolveLValue): Call the DoResolve
23279 function to initialize the Instance expression.
23281 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23282 correctly the GetEnumerator operation on a value type.
23284 * cs-parser.jay: Add more simple parsing error catches.
23286 * statement.cs (Switch): Add support for string switches.
23287 Handle null specially.
23289 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23291 2001-11-28 Ravi Pratap <ravi@ximian.com>
23293 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23295 (declare_local_constant): New helper function.
23297 * statement.cs (AddConstant): Keep a separate record of constants
23299 (IsConstant): Implement to determine if a variable is a constant.
23301 (GetConstantExpression): Implement.
23303 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23305 * statement.cs (IsVariableDefined): Re-write.
23307 2001-11-27 Ravi Pratap <ravi@ximian.com>
23309 * class.cs (TypeContainer::FindMembers): Look for constants
23310 in the case when we are looking for MemberTypes.Field
23312 * expression.cs (MemberAccess::DoResolve): Check that in the
23313 case we are a FieldExpr and a Literal, we are not being accessed
23314 by an instance reference.
23316 * cs-parser.jay (local_constant_declaration): Implement.
23318 (declaration_statement): Implement for constant declarations.
23320 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23322 * statement.cs (Switch): Catch double defaults.
23324 (Switch): More work on the switch() statement
23325 implementation. It works for integral values now, need to finish
23329 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23331 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23332 integer literals into other integer literals. To be used by
23335 2001-11-24 Ravi Pratap <ravi@ximian.com>
23337 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23340 (EmitDynamicInitializers): Cope with the above since we extract data
23341 directly from ArrayData now.
23343 (ExpectInitializers): Keep track of whether initializers are mandatory
23346 (Bounds): Make it a hashtable to prevent the same dimension being
23347 recorded for every element in that dimension.
23349 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23352 Also fix bug which was causing the indices to be emitted in the reverse
23355 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23357 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23358 unfinished. They do not work, because the underlying code is
23361 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23363 * cs-parser.jay: Remove bogus fixme.
23365 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23366 on Switch statement.
23368 2001-11-23 Ravi Pratap <ravi@ximian.com>
23370 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23373 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23374 parameter. Apparently, any expression is allowed.
23376 (ValidateInitializers): Update accordingly.
23378 (CheckIndices): Fix some tricky bugs thanks to recursion.
23380 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23381 I was being completely brain-dead.
23383 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23384 and re-write acordingly.
23386 (DelegateInvocation): Re-write accordingly.
23388 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23390 (MakeByteBlob): Handle types more correctly.
23392 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23393 initialization from expressions but it is incomplete because I am a complete
23396 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23398 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23399 on If. Basically, we have to return `true' (ie, we do return to
23400 our caller) only if both branches of the if return.
23402 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23403 short-circuit operators, handle them as short circuit operators.
23405 (Cast.DoResolve): Resolve type.
23406 (Cast.Cast): Take an expression as the target type.
23408 * cs-parser.jay (cast_expression): Remove old hack that only
23409 allowed a limited set of types to be handled. Now we take a
23410 unary_expression and we resolve to a type during semantic
23413 Use the grammar productions from Rhys to handle casts (this is
23414 not complete like Rhys syntax yet, we fail to handle that corner
23415 case that C# has regarding (-x), but we will get there.
23417 2001-11-22 Ravi Pratap <ravi@ximian.com>
23419 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23420 field which is an array type.
23422 * cs-parser.jay (declare_local_variables): Support array initialization too.
23424 * typemanager.cs (MakeKey): Implement.
23426 (everywhere): Use the above appropriately.
23428 * cs-parser.jay (for_statement): Update for array initialization while
23429 declaring variables.
23431 * ecore.cs : The error message was correct, it's the variable's names that
23432 were misleading ;-) Make the code more readable.
23434 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23435 the correct type etc.
23437 (ConvertExplicit): Handle Enum types by examining the underlying type.
23439 2001-11-21 Ravi Pratap <ravi@ximian.com>
23441 * parameter.cs (GetCallingConvention): Always return
23442 CallingConventions.Standard for now.
23444 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23446 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23447 and `r' after calling DoNumericPromotions.
23449 * ecore.cs: Fix error message (the types were in the wrong order).
23451 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23452 BindingFlags.Instance as well
23454 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23455 implicit int literal conversion in an empty cast so that we
23456 propagate the right type upstream.
23458 (UnboxCast): new class used to unbox value types.
23459 (Expression.ConvertExplicit): Add explicit type conversions done
23462 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23463 the target type before applying the implicit LongLiterals to ULong
23466 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23468 * cs-parser.jay (for_statement): Reworked the way For works: now
23469 we declare manually any variables that are introduced in
23470 for_initializer to solve the problem of having out-of-band code
23471 emition (that is what got for broken).
23473 (declaration_statement): Perform the actual variable declaration
23474 that used to be done in local_variable_declaration here.
23476 (local_variable_declaration): Do not declare anything, just pass
23477 the information on a DictionaryEntry
23479 2001-11-20 Ravi Pratap <ravi@ximian.com>
23481 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23482 re-write of the logic to now make it recursive.
23484 (UpdateIndices): Re-write accordingly.
23486 Store element data in a separate ArrayData list in the above methods.
23488 (MakeByteBlob): Implement to dump the array data into a byte array.
23490 2001-11-19 Ravi Pratap <ravi@ximian.com>
23492 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23495 * constant.cs (Define): Implement.
23497 (EmitConstant): Re-write fully.
23499 Pass in location info.
23501 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23504 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23505 DictionaryEntry since we need location info too.
23507 (constant_declaration): Update accordingly.
23509 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23510 code into another method : UpdateIndices.
23512 2001-11-18 Ravi Pratap <ravi@ximian.com>
23514 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23515 some type checking etc.
23517 2001-11-17 Ravi Pratap <ravi@ximian.com>
23519 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23520 bits to provide dimension info if the user skips doing that.
23522 Update second constructor to store the rank correctly.
23524 2001-11-16 Ravi Pratap <ravi@ximian.com>
23526 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23527 and try to implement.
23529 * ../errors/cs0150.cs : Add.
23531 * ../errors/cs0178.cs : Add.
23533 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23535 * statement.cs: Implement foreach on multi-dimensional arrays.
23537 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23538 name of the params argument.
23540 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23541 initializing the array.
23543 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23544 we can use this elsewhere.
23546 * statement.cs: Finish implementation of foreach for single
23549 * cs-parser.jay: Use an out-of-band stack to pass information
23550 around, I wonder why I need this.
23552 foreach_block: Make the new foreach_block the current_block.
23554 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23555 function used to return a static Parameters structure. Used for
23556 empty parameters, as those are created very frequently.
23558 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23560 2001-11-15 Ravi Pratap <ravi@ximian.com>
23562 * interface.cs : Default modifier is private, not public. The
23563 make verify test passes again.
23565 2001-11-15 Ravi Pratap <ravi@ximian.com>
23567 * support.cs (ReflectionParameters): Fix logic to determine
23568 whether the last parameter is a params one. Test 9 passes again.
23570 * delegate.cs (Populate): Register the builders we define with
23571 RegisterParameterForBuilder. Test 19 passes again.
23573 * cs-parser.jay (property_declaration): Reference $6 instead
23574 of $$ to get at the location.
23576 (indexer_declaration): Similar stuff.
23578 (attribute): Ditto.
23580 * class.cs (Property): Register parameters for the Get and Set methods
23581 if they exist. Test 23 passes again.
23583 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23584 call to EmitArguments as we are sure there aren't any params arguments.
23585 Test 32 passes again.
23587 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23588 IndexOutOfRangeException.
23590 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23591 Test 33 now passes again.
23593 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23595 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23596 broke a bunch of things. Will have to come up with a better way
23597 of tracking locations.
23599 * statement.cs: Implemented foreach for single dimension arrays.
23601 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23603 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23604 an error. This removes the lookup from the critical path.
23606 * cs-parser.jay: Removed use of temporary_loc, which is completely
23609 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23611 * support.cs (ReflectionParameters.ParameterModifier): Report
23612 whether the argument is a PARAMS argument or not.
23614 * class.cs: Set the attribute `ParamArrayAttribute' on the
23615 parameter argument.
23617 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23618 and cons_param_array_attribute (ConstructorInfo for
23619 ParamArrayAttribute).,
23621 * codegen.cs: Emit the return using the `Return' statement, that
23622 way we can report the error correctly for missing return values.
23624 * class.cs (Method.Emit): Clean up.
23626 * expression.cs (Argument.Resolve): Take another argument: the
23627 location where this argument is used. Notice that this is not
23628 part of the "Argument" class as to reduce the size of the
23629 structure (we know the approximate location anyways).
23631 Test if the argument is a variable-reference, if not, then
23632 complain with a 206.
23634 (Argument.Emit): Emit addresses of variables.
23636 (Argument.FullDesc): Simplify.
23638 (Invocation.DoResolve): Update for Argument.Resolve.
23640 (ElementAccess.DoResolve): ditto.
23642 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
23643 method should be virtual, as this method is always virtual.
23645 (NewDelegate.DoResolve): Update for Argument.Resolve.
23647 * class.cs (ConstructorInitializer.DoResolve): ditto.
23649 * attribute.cs (Attribute.Resolve): ditto.
23651 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23653 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
23655 * expression.cs (ParameterReference): Drop IStackStorage and implement
23656 IAssignMethod instead.
23658 (LocalVariableReference): ditto.
23660 * ecore.cs (FieldExpr): Drop IStackStorage and implement
23661 IAssignMethod instead.
23663 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23665 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
23666 enumerations that are used in heavily used structures derive from
23667 byte in a laughable and pathetic attempt to reduce memory usage.
23668 This is the kind of pre-optimzations that you should not do at
23669 home without adult supervision.
23671 * expression.cs (UnaryMutator): New class, used to handle ++ and
23672 -- separatedly from the other unary operators. Cleans up the
23673 code, and kills the ExpressionStatement dependency in Unary.
23675 (Unary): Removed `method' and `Arguments' from this class, making
23676 it smaller, and moving it all to SimpleCall, so I can reuse this
23677 code in other locations and avoid creating a lot of transient data
23678 strucutres when not required.
23680 * cs-parser.jay: Adjust for new changes.
23682 2001-11-11 Miguel de Icaza <miguel@ximian.com>
23684 * enum.cs (Enum.Populate): If there is a failure during
23687 * cs-parser.jay (opt_enum_base): we used to catch type errors
23688 here, but this is really incorrect. The type error should be
23689 catched during semantic analysis.
23691 2001-12-11 Ravi Pratap <ravi@ximian.com>
23693 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
23694 current_local_parameters as expected since I, in my stupidity, had forgotten
23697 * attribute.cs (GetValidPlaces): Fix stupid bug.
23699 * class.cs (Method::Emit): Perform check on applicability of attributes.
23701 (Constructor::Emit): Ditto.
23703 (Field::Emit): Ditto.
23705 (Field.Location): Store location information.
23707 (Property, Event, Indexer, Operator): Ditto.
23709 * cs-parser.jay (field_declaration): Pass in location for each field.
23711 * ../errors/cs0592.cs : Add.
23713 2001-11-12 Ravi Pratap <ravi@ximian.com>
23715 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
23717 (InitCoreTypes): Update accordingly.
23719 (RegisterAttrType, LookupAttr): Implement.
23721 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
23722 info about the same.
23724 (Resolve): Update to populate the above as necessary.
23726 (Error592): Helper.
23728 (GetValidPlaces): Helper to the above.
23730 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
23732 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
23734 2001-11-12 Ravi Pratap <ravi@ximian.com>
23736 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
23738 * ../errors/cs0617.cs : Add.
23740 2001-11-11 Ravi Pratap <ravi@ximian.com>
23742 * enum.cs (Emit): Rename to Populate to be more consistent with what
23743 we expect it to do and when exactly it is called.
23745 * class.cs, rootcontext.cs : Update accordingly.
23747 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
23748 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
23750 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
23752 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
23753 of a fieldinfo using the above, when dealing with a FieldBuilder.
23755 2001-11-10 Ravi Pratap <ravi@ximian.com>
23757 * ../errors/cs0031.cs : Add.
23759 * ../errors/cs1008.cs : Add.
23761 * ../errrors/cs0543.cs : Add.
23763 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
23766 (FindMembers): Implement.
23768 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
23769 enums and delegates too.
23771 (enum_types): Rename to builder_to_enum.
23773 (delegate_types): Rename to builder_to_delegate.
23775 * delegate.cs (FindMembers): Implement.
23777 2001-11-09 Ravi Pratap <ravi@ximian.com>
23779 * typemanager.cs (IsEnumType): Implement.
23781 * enum.cs (Emit): Re-write parts to account for the underlying type
23782 better and perform checking etc.
23784 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
23785 of the underlying type.
23787 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
23790 * enum.cs (error31): Helper to report error #31.
23792 * cs-parser.jay (enum_declaration): Store location of each member too.
23794 * enum.cs (member_to_location): New hashtable.
23796 (AddEnumMember): Update location hashtable.
23798 (Emit): Use the location of each member while reporting errors.
23800 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23802 * cs-parser.jay: A for_initializer if is a
23803 local_variable_declaration really ammount to have an implicit
23804 block with the variable declaration and no initializer for for.
23806 * statement.cs (For.Emit): Cope with null initializers.
23808 This fixes the infinite loop on for initializers.
23810 2001-11-08 Miguel de Icaza <miguel@ximian.com>
23812 * enum.cs: More cleanup.
23814 * ecore.cs: Remove dead code.
23816 * class.cs (Property.Emit): More simplification.
23817 (Event.Emit): ditto.
23819 Reworked to have less levels of indentation.
23821 2001-11-08 Ravi Pratap <ravi@ximian.com>
23823 * class.cs (Property): Emit attributes.
23833 * enum.cs (Emit): Ditto.
23835 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
23838 * class.cs (Field, Event, etc.): Move attribute generation into the
23839 Emit method everywhere.
23841 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
23842 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
23843 as we had no way of defining nested enums !
23845 * rootcontext.cs : Adjust code accordingly.
23847 * typemanager.cs (AddEnumType): To keep track of enum types separately.
23849 2001-11-07 Ravi Pratap <ravi@ximian.com>
23851 * expression.cs (EvalConstantExpression): Move into ecore.cs
23853 * enum.cs (Enum): Rename some members and make them public and readonly
23854 according to our convention.
23856 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
23859 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
23861 (Enum::Emit): Write a simple version for now which doesn't try to compute
23862 expressions. I shall modify this to be more robust in just a while.
23864 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
23866 (TypeContainer::CloseType): Create the Enum types too.
23868 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
23870 * expression.cs (EvalConstantExpression): Get rid of completely.
23872 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
23873 user-defined values and other cases.
23875 (IsValidEnumLiteral): Helper function.
23877 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
23878 out there in the case we had a literal FieldExpr.
23880 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
23882 (Literalize): Revamp a bit to take two arguments.
23884 (EnumLiteral): New class which derives from Literal to wrap enum literals.
23886 2001-11-06 Ravi Pratap <ravi@ximian.com>
23888 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
23890 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
23892 (Resolve): Use the above to ensure we have proper initializers.
23894 2001-11-05 Ravi Pratap <ravi@ximian.com>
23896 * expression.cs (Expression::EvalConstantExpression): New method to
23897 evaluate constant expressions.
23899 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
23901 2001-11-07 Miguel de Icaza <miguel@ximian.com>
23903 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
23906 (Binary.ResolveOperator): Handle operator != (object a, object b)
23907 and operator == (object a, object b);
23909 (Binary.DoNumericPromotions): Indicate whether the numeric
23910 promotion was possible.
23912 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
23915 Made the ArrayAccess implement interface IAssignMethod instead of
23916 IStackStore as the order in which arguments are passed reflects
23919 * assign.cs: Instead of using expr.ExprClass to select the way of
23920 assinging, probe for the IStackStore/IAssignMethod interfaces.
23922 * typemanager.cs: Load InitializeArray definition.
23924 * rootcontext.cs (RootContext.MakeStaticData): Used to define
23925 static data that can be used to initialize arrays.
23927 2001-11-05 Miguel de Icaza <miguel@ximian.com>
23929 * expression.cs: Handle operator== and operator!= for booleans.
23931 (Conditioal.Reduce): Implement reducer for the ?: operator.
23933 (Conditional.Resolve): Implement dead code elimination.
23935 (Binary.Resolve): Catch string literals and return a new
23936 concatenated string.
23938 (Unary.Reduce): Implement reduction of unary expressions.
23940 * ecore.cs: Split out the expression core handling here.
23942 (Expression.Reduce): New method used to perform constant folding
23943 and CSE. This is needed to support constant-expressions.
23945 * statement.cs (Statement.EmitBoolExpression): Pass true and false
23946 targets, and optimize for !x.
23948 2001-11-04 Ravi Pratap <ravi@ximian.com>
23950 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
23951 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
23952 set custom atttributes.
23954 * literal.cs (Literal::GetValue): New abstract method to return the actual
23955 value of the literal, cast as an object.
23957 (*Literal): Implement GetValue method.
23959 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
23960 expressions to the arraylist but objects of type Argument.
23962 * class.cs (TypeContainer::Emit): Emit our attributes too.
23964 (Method::Emit, Constructor::Emit): Ditto.
23966 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
23967 to be ignoring earlier.
23969 2001-11-03 Ravi Pratap <ravi@ximian.com>
23971 * attribute.cs (AttributeSection::Define): Implement to do the business
23972 of constructing a CustomAttributeBuilder.
23974 (Attribute): New trivial class. Increases readability of code.
23976 * cs-parser.jay : Update accordingly.
23978 (positional_argument_list, named_argument_list, named_argument): New rules
23980 (attribute_arguments): Use the above so that we are more correct.
23982 2001-11-02 Ravi Pratap <ravi@ximian.com>
23984 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
23985 to perform all checks for a method with a params parameter.
23987 (Invocation::OverloadResolve): Update to use the above method and therefore
23988 cope correctly with params method invocations.
23990 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
23993 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
23994 constructors in our parent too because we can't afford to miss out on
23997 * attribute.cs (AttributeSection): New name for the class Attribute
23999 Other trivial changes to improve readability.
24001 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
24002 use the new class names.
24004 2001-11-01 Ravi Pratap <ravi@ximian.com>
24006 * class.cs (Method::Define): Complete definition for params types too
24008 (Indexer::Define): Ditto.
24010 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
24011 Cope everywhere with a request for info about the array parameter.
24013 2001-11-01 Ravi Pratap <ravi@ximian.com>
24015 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24017 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24018 local_variable_type to extract the string corresponding to the type.
24020 (local_variable_type): Fixup the action to use the new helper method.
24022 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24025 * expression.cs : Clean out code which uses the above.
24027 2001-10-31 Ravi Pratap <ravi@ximian.com>
24029 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24030 and bale out if necessary by returning a false.
24032 (RegisterProperty): Ditto.
24034 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24035 and print out appropriate error messages.
24037 * interface.cs (everywhere): Ditto.
24039 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24040 location to constructor.
24042 * class.cs (Property, Event, Indexer): Update accordingly.
24044 * ../errors/cs111.cs : Added.
24046 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24047 of a method, as laid down by the spec.
24049 (Invocation::OverloadResolve): Use the above method.
24051 2001-10-31 Ravi Pratap <ravi@ximian.com>
24053 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24054 now take a TypeContainer and a Parameters object.
24056 (ParameterData): Modify return type of ParameterModifier method to be
24057 Parameter.Modifier and not a string.
24059 (ReflectionParameters, InternalParameters): Update accordingly.
24061 * expression.cs (Argument::GetParameterModifier): Same here.
24063 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24064 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24065 symbol in it at all so maybe this is only for now.
24067 2001-10-30 Ravi Pratap <ravi@ximian.com>
24069 * support.cs (InternalParameters): Constructor now takes an extra argument
24070 which is the actual Parameters class.
24072 (ParameterDesc): Update to provide info on ref/out modifiers.
24074 * class.cs (everywhere): Update call to InternalParameters to pass in
24075 the second argument too.
24077 * support.cs (ParameterData): Add ParameterModifier, which is a method
24078 to return the modifier info [ref/out etc]
24080 (InternalParameters, ReflectionParameters): Implement the above.
24082 * expression.cs (Argument::ParameterModifier): Similar function to return
24083 info about the argument's modifiers.
24085 (Invocation::OverloadResolve): Update to take into account matching modifiers
24088 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24089 a new SetFormalParameters object which we pass to InternalParameters.
24091 2001-10-30 Ravi Pratap <ravi@ximian.com>
24093 * expression.cs (NewArray): Merge into the ArrayCreation class.
24095 2001-10-29 Ravi Pratap <ravi@ximian.com>
24097 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24098 NewUserdefinedArray into one as there wasn't much of a use in having
24101 * expression.cs (Argument): Change field's name to ArgType from Type.
24103 (Type): New readonly property which returns the proper type, taking into
24104 account ref/out modifiers.
24106 (everywhere): Adjust code accordingly for the above.
24108 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24109 whether we are emitting for a ref or out parameter.
24111 * expression.cs (Argument::Emit): Use the above field to set the state.
24113 (LocalVariableReference::Emit): Update to honour the flag and emit the
24116 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24118 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24120 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24122 (ReflectionParameters, InternalParameters): Implement the above method.
24124 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24127 (Invocation::FullMethodDesc): Ditto.
24129 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24131 * cs-parser.jay: Add extra production for the second form of array
24134 * expression.cs (ArrayCreation): Update to reflect the above
24137 * Small changes to prepare for Array initialization.
24139 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24141 * typemanager.cs (ImplementsInterface): interface might be null;
24142 Deal with this problem;
24144 Also, we do store negative hits on the cache (null values), so use
24145 this instead of calling t.GetInterfaces on the type everytime.
24147 2001-10-28 Ravi Pratap <ravi@ximian.com>
24149 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24151 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24152 split functionality out into different classes.
24154 (New::FormArrayType): Move into NewBuiltinArray.
24156 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24159 (NewBuiltinArray): New class to handle creation of built-in arrays.
24161 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24162 account creation of one-dimensional arrays.
24164 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24166 (NewUserdefinedArray::DoResolve): Implement.
24168 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24170 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24171 we maintain inside the TypeManager. This is necessary to perform lookups on the
24174 (LookupType): Update to perform GetType on the module builders too.
24176 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24178 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24180 2001-10-23 Ravi Pratap <ravi@ximian.com>
24182 * expression.cs (New::DoResolve): Implement guts of array creation.
24184 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24186 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24188 * expression.cs: Fix bug I introduced lsat night that broke
24191 (Expression.Resolve): Report a 246 error (can not resolve name)
24192 if we find a SimpleName in the stream.
24194 (Expression.ResolveLValue): Ditto.
24196 (Expression.ResolveWithSimpleName): This function is a variant of
24197 ResolveName, this one allows SimpleNames to be returned without a
24198 warning. The only consumer of SimpleNames is MemberAccess
24200 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24202 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24203 might arrive here. I have my doubts that this is correct.
24205 * statement.cs (Lock): Implement lock statement.
24207 * cs-parser.jay: Small fixes to support `lock' and `using'
24209 * cs-tokenizer.cs: Remove extra space
24211 * driver.cs: New flag --checked, allows to turn on integer math
24214 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24215 Threading.Monitor.Exit
24217 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24219 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24220 Expression Class to be IndexerAccess.
24222 Notice that Indexer::DoResolve sets the eclass to Value.
24224 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24226 * class.cs (TypeContainer::Emit): Emit code for indexers.
24228 * assign.cs (IAssignMethod): New interface implemented by Indexers
24229 and Properties for handling assignment.
24231 (Assign::Emit): Simplify and reuse code.
24233 * expression.cs (IndexerAccess, PropertyExpr): Implement
24234 IAssignMethod, clean up old code.
24236 2001-10-22 Ravi Pratap <ravi@ximian.com>
24238 * typemanager.cs (ImplementsInterface): New method to determine if a type
24239 implements a given interface. Provides a nice cache too.
24241 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24244 (ConvertReferenceExplicit): Ditto.
24246 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24247 various methods, with correct names etc.
24249 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24250 Operator.UnaryNegation.
24252 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24253 we have a unary plus or minus operator.
24255 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24258 * everywhere : update accordingly.
24260 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24263 * class.cs (Method::Define): For the case where we are implementing a method
24264 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24265 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24267 2001-10-21 Ravi Pratap <ravi@ximian.com>
24269 * interface.cs (FindMembers): Implement to work around S.R.E
24272 * typemanager.cs (IsInterfaceType): Implement.
24274 (FindMembers): Update to handle interface types too.
24276 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24277 use IsAssignableFrom as that is not correct - it doesn't work.
24279 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24280 and accordingly override EmitStatement.
24282 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24283 using the correct logic :-)
24285 2001-10-19 Ravi Pratap <ravi@ximian.com>
24287 * ../errors/cs-11.cs : Add to demonstrate error -11
24289 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24291 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24292 then pass this as a hint to ResolveLValue.
24294 * expression.cs (FieldExpr): Add Location information
24296 (FieldExpr::LValueResolve): Report assignment to readonly
24299 (Expression::ExprClassFromMemberInfo): Pass location information.
24301 (Expression::ResolveLValue): Add new method that resolves an
24304 (Expression::DoResolveLValue): Default invocation calls
24307 (Indexers): New class used to keep track of indexers in a given
24310 (IStackStore): Renamed from LValue, as it did not really describe
24311 what this did. Also ResolveLValue is gone from this interface and
24312 now is part of Expression.
24314 (ElementAccess): Depending on the element access type
24316 * typemanager.cs: Add `indexer_name_type' as a Core type
24317 (System.Runtime.CompilerServices.IndexerNameAttribute)
24319 * statement.cs (Goto): Take a location.
24321 2001-10-18 Ravi Pratap <ravi@ximian.com>
24323 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24324 if two delegates are compatible.
24326 (NewDelegate::DoResolve): Update to take care of the case when
24327 we instantiate a delegate from another delegate.
24329 * typemanager.cs (FindMembers): Don't even try to look up members
24330 of Delegate types for now.
24332 2001-10-18 Ravi Pratap <ravi@ximian.com>
24334 * delegate.cs (NewDelegate): New class to take care of delegate
24337 * expression.cs (New): Split the delegate related code out into
24338 the NewDelegate class.
24340 * delegate.cs (DelegateInvocation): New class to handle delegate
24343 * expression.cs (Invocation): Split out delegate related code into
24344 the DelegateInvocation class.
24346 2001-10-17 Ravi Pratap <ravi@ximian.com>
24348 * expression.cs (New::DoResolve): Implement delegate creation fully
24349 and according to the spec.
24351 (New::DoEmit): Update to handle delegates differently.
24353 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24354 because of which we were printing out arguments in reverse order !
24356 * delegate.cs (VerifyMethod): Implement to check if the given method
24357 matches the delegate.
24359 (FullDelegateDesc): Implement.
24361 (VerifyApplicability): Implement.
24363 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24364 delegate invocations too.
24366 (Invocation::Emit): Ditto.
24368 * ../errors/cs1593.cs : Added.
24370 * ../errors/cs1594.cs : Added.
24372 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24374 2001-10-16 Ravi Pratap <ravi@ximian.com>
24376 * typemanager.cs (intptr_type): Core type for System.IntPtr
24378 (InitCoreTypes): Update for the same.
24380 (iasyncresult_type, asynccallback_type): Ditto.
24382 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24385 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24388 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24389 the builders for the 4 members of a delegate type :-)
24391 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24394 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24396 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24398 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24400 * statement.cs (Break::Emit): Implement.
24401 (Continue::Emit): Implement.
24403 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24404 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24405 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24406 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24409 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24410 properties that track the label for the current loop (begin of the
24411 loop and end of the loop).
24413 2001-10-15 Ravi Pratap <ravi@ximian.com>
24415 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24416 use of emitting anything at all.
24418 * class.cs, rootcontext.cs : Get rid of calls to the same.
24420 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24422 (Populate): Define the constructor correctly and set the implementation
24425 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24428 (AddDelegateType): Implement.
24430 (IsDelegateType): Implement helper method.
24432 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24434 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24435 and accordingly handle it.
24437 * delegate.cs (Populate): Take TypeContainer argument.
24438 Implement bits to define the Invoke method. However, I still haven't figured out
24439 how to take care of the native int bit :-(
24441 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24442 Qualify the name of the delegate, not its return type !
24444 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24447 (StandardConversionExists): Checking for array types turns out to be recursive.
24449 (ConvertReferenceExplicit): Implement array conversion.
24451 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24453 2001-10-12 Ravi Pratap <ravi@ximian.com>
24455 * cs-parser.jay (delegate_declaration): Store the fully qualified
24456 name as it is a type declaration.
24458 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24461 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24462 as TypeContainer::DefineType.
24464 (Populate): Method in which all the definition of the various methods (Invoke)
24467 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24470 (CloseDelegate): Finally creates the delegate.
24472 * class.cs (TypeContainer::DefineType): Update to define delegates.
24473 (Populate, Emit and CloseType): Do the same thing here too.
24475 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24476 delegates in all these operations.
24478 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24480 * expression.cs: LocalTemporary: a new expression used to
24481 reference a temporary that has been created.
24483 * assign.cs: Handle PropertyAccess back here, so that we can
24484 provide the proper semantic access to properties.
24486 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24487 a few more explicit conversions.
24489 * modifiers.cs: `NEW' modifier maps to HideBySig.
24491 * expression.cs (PropertyExpr): Make this into an
24492 ExpressionStatement, and support the EmitStatement code path.
24494 Perform get/set error checking, clean up the interface.
24496 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24497 them into toplevel access objects.
24499 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24501 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24504 * typemanager.cs: Keep track here of our PropertyBuilders again to
24505 work around lameness in SRE.
24507 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24509 * expression.cs (LValue::LValueResolve): New method in the
24510 interface, used to perform a second resolution pass for LValues.
24512 (This::DoResolve): Catch the use of this in static methods.
24514 (This::LValueResolve): Implement.
24516 (This::Store): Remove warning, assigning to `this' in structures
24519 (Invocation::Emit): Deal with invocation of
24520 methods on value types. We need to pass the address to structure
24521 methods rather than the object itself. (The equivalent code to
24522 emit "this" for structures leaves the entire structure on the
24523 stack instead of a pointer to it).
24525 (ParameterReference::DoResolve): Compute the real index for the
24526 argument based on whether the method takes or not a `this' pointer
24527 (ie, the method is static).
24529 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24530 value types returned from functions when we need to invoke a
24531 method on the sturcture.
24534 2001-10-11 Ravi Pratap <ravi@ximian.com>
24536 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24537 defining the type in the Modulebuilder or Typebuilder. This is to take
24538 care of nested types which need to be defined on the TypeBuilder using
24539 DefineNestedMethod.
24541 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24542 methods in RootContext, only ported to be part of TypeContainer.
24544 (TypeContainer::GetInterfaceOrClass): Ditto.
24546 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24548 * interface.cs (Interface::DefineInterface): New method. Does exactly
24549 what RootContext.CreateInterface did earlier, only it takes care of nested types
24552 (Interface::GetInterfaces): Move from RootContext here and port.
24554 (Interface::GetInterfaceByName): Same here.
24556 * rootcontext.cs (ResolveTree): Re-write.
24558 (PopulateTypes): Re-write.
24560 * class.cs (TypeContainer::Populate): Populate nested types too.
24561 (TypeContainer::Emit): Emit nested members too.
24563 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24564 instead just use the name argument passed in as it is already fully
24567 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24568 to TypeContainer mapping to see if a type is user-defined.
24570 * class.cs (TypeContainer::CloseType): Implement.
24572 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24573 the default constructor.
24575 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24578 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24580 * interface.cs (CloseType): Create the type here.
24582 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24585 Remove all the methods which are now in TypeContainer.
24587 2001-10-10 Ravi Pratap <ravi@ximian.com>
24589 * delegate.cs (Define): Re-write bits to define the delegate
24592 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24594 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24596 * expression.cs (ImplicitReferenceConversion): handle null as well
24597 as a source to convert to any reference type.
24599 * statement.cs (Return): Perform any implicit conversions to
24600 expected return type.
24602 Validate use of return statement.
24604 * codegen.cs (EmitContext): Pass the expected return type here.
24606 * class.cs (Method, Constructor, Property): Pass expected return
24607 type to EmitContext.
24609 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24611 * expression.cs: Make DoResolve take an EmitContext instead of a
24614 Replaced `l' and `location' for `loc', for consistency.
24616 (Error, Warning): Remove unneeded Tc argument.
24618 * assign.cs, literal.cs, constant.cs: Update to new calling
24621 * codegen.cs: EmitContext now contains a flag indicating whether
24622 code is being generated in a static method or not.
24624 * cs-parser.jay: DecomposeQI, new function that replaces the old
24625 QualifiedIdentifier. Now we always decompose the assembled
24626 strings from qualified_identifier productions into a group of
24629 2001-10-08 Miguel de Icaza <miguel@ximian.com>
24631 * rootcontext.cs: Deal with field-less struct types correctly now
24632 by passing the size option to Define Type.
24634 * class.cs: Removed hack that created one static field.
24636 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24638 * statement.cs: Moved most of the code generation here.
24640 2001-10-09 Ravi Pratap <ravi@ximian.com>
24642 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
24645 (ElementAccess): Remove useless bits for now - keep checks as the spec
24648 2001-10-08 Ravi Pratap <ravi@ximian.com>
24650 * expression.cs (ElementAccess::DoResolve): Remove my crap code
24651 and start performing checks according to the spec.
24653 2001-10-07 Ravi Pratap <ravi@ximian.com>
24655 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
24656 rank_specifiers instead.
24658 (rank_specifiers): Change the order in which the rank specifiers are stored
24660 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
24662 * expression.cs (ElementAccess): Implement the LValue interface too.
24664 2001-10-06 Ravi Pratap <ravi@ximian.com>
24666 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
24667 except that user defined conversions are not included.
24669 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
24670 perform the conversion of the return type, if necessary.
24672 (New::DoResolve): Check whether we are creating an array or an object
24673 and accordingly do the needful.
24675 (New::Emit): Same here.
24677 (New::DoResolve): Implement guts of array creation.
24679 (New::FormLookupType): Helper function.
24681 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24683 * codegen.cs: Removed most of the code generation here, and move the
24684 corresponding code generation bits to the statement classes.
24686 Added support for try/catch/finalize and throw.
24688 * cs-parser.jay: Added support for try/catch/finalize.
24690 * class.cs: Catch static methods having the flags override,
24691 virtual or abstract.
24693 * expression.cs (UserCast): This user cast was not really doing
24694 what it was supposed to do. Which is to be born in fully resolved
24695 state. Parts of the resolution were being performed at Emit time!
24699 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24701 * expression.cs: Implicity convert the result from UserCast.
24703 2001-10-05 Ravi Pratap <ravi@ximian.com>
24705 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
24706 prevented it from working correctly.
24708 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
24709 merely ConvertImplicit.
24711 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24713 * typemanager.cs: Make the LookupTypeContainer function static,
24714 and not per-instance.
24716 * class.cs: Make static FindMembers (the one that takes a Type
24719 * codegen.cs: Add EmitForeach here.
24721 * cs-parser.jay: Make foreach a toplevel object instead of the
24722 inline expansion, as we need to perform semantic analysis on it.
24724 2001-10-05 Ravi Pratap <ravi@ximian.com>
24726 * expression.cs (Expression::ImplicitUserConversion): Rename to
24727 UserDefinedConversion.
24729 (Expression::UserDefinedConversion): Take an extra argument specifying
24730 whether we look for explicit user conversions too.
24732 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
24734 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
24736 (ExplicitUserConversion): Make it a call to UserDefinedConversion
24737 with the appropriate arguments.
24739 * cs-parser.jay (cast_expression): Record location too.
24741 * expression.cs (Cast): Record location info.
24743 (Expression::ConvertExplicit): Take location argument.
24745 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
24746 to determine if we are doing explicit conversions.
24748 (UserCast::Emit): Update accordingly.
24750 (Expression::ConvertExplicit): Report an error if everything fails.
24752 * ../errors/cs0030.cs : Add.
24754 2001-10-04 Miguel de Icaza <miguel@ximian.com>
24756 * modifiers.cs: If the ABSTRACT keyword is present, also set the
24757 virtual and newslot bits.
24759 * class.cs (TypeContainer::RegisterRequiredImplementations):
24760 Record methods we need.
24762 (TypeContainer::MakeKey): Helper function to make keys for
24763 MethodBases, since the Methodbase key is useless.
24765 (TypeContainer::Populate): Call RegisterRequiredImplementations
24766 before defining the methods.
24768 Create a mapping for method_builders_to_methods ahead of time
24769 instead of inside a tight loop.
24771 (::RequireMethods): Accept an object as the data to set into the
24772 hashtable so we can report interface vs abstract method mismatch.
24774 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24776 * report.cs: Make all of it static.
24778 * rootcontext.cs: Drop object_type and value_type computations, as
24779 we have those in the TypeManager anyways.
24781 Drop report instance variable too, now it is a global.
24783 * driver.cs: Use try/catch on command line handling.
24785 Add --probe option to debug the error reporting system with a test
24788 * report.cs: Add support for exiting program when a probe
24789 condition is reached.
24791 2001-10-03 Ravi Pratap <ravi@ximian.com>
24793 * expression.cs (Binary::DoNumericPromotions): Fix the case when
24794 we do a forcible conversion regardless of type, to check if
24795 ForceConversion returns a null.
24797 (Binary::error19): Use location to report error.
24799 (Unary::error23): Use location here too.
24801 * ../errors/cs0019.cs : Check in.
24803 * ../errors/cs0023.cs : Check in.
24805 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
24806 case of a non-null MethodInfo object with a length of 0 !
24808 (Binary::ResolveOperator): Flag error if overload resolution fails to find
24809 an applicable member - according to the spec :-)
24810 Also fix logic to find members in base types.
24812 (Unary::ResolveOperator): Same here.
24814 (Unary::report23): Change name to error23 and make first argument a TypeContainer
24815 as I was getting thoroughly confused between this and error19 :-)
24817 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
24818 (::FindMostEncompassedType): Implement.
24819 (::FindMostEncompassingType): Implement.
24820 (::StandardConversionExists): Implement.
24822 (UserImplicitCast): Re-vamp. We now need info about most specific
24823 source and target types so that we can do the necessary conversions.
24825 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
24826 mathematical union with no duplicates.
24828 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24830 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
24831 in order from base classes to child classes, so that we can in
24832 child classes look up in our parent for method names and
24833 attributes (required for handling abstract, virtual, new, override
24834 constructs: we need to instrospect our base class, and if we dont
24835 populate the classes in order, the introspection might be
24836 incorrect. For example, a method could query its parent before
24837 the parent has any methods and would determine that the parent has
24838 no abstract methods (while it could have had them)).
24840 (RootContext::CreateType): Record the order in which we define the
24843 2001-10-02 Miguel de Icaza <miguel@ximian.com>
24845 * class.cs (TypeContainer::Populate): Also method definitions can
24846 fail now, keep track of this.
24848 (TypeContainer::FindMembers): Implement support for
24849 DeclaredOnly/noDeclaredOnly flag.
24851 (Constructor::Emit) Return the ConstructorBuilder.
24853 (Method::Emit) Return the MethodBuilder.
24854 Check for abstract or virtual methods to be public.
24856 * rootcontext.cs (RootContext::CreateType): Register all the
24857 abstract methods required for the class to be complete and the
24858 interface methods that must be implemented.
24860 * cs-parser.jay: Report error 501 (method requires body if it is
24861 not marked abstract or extern).
24863 * expression.cs (TypeOf::Emit): Implement.
24865 * typemanager.cs: runtime_handle_type, new global type.
24867 * class.cs (Property::Emit): Generate code for properties.
24869 2001-10-02 Ravi Pratap <ravi@ximian.com>
24871 * expression.cs (Unary::ResolveOperator): Find operators on base type
24872 too - we now conform exactly to the spec.
24874 (Binary::ResolveOperator): Same here.
24876 * class.cs (Operator::Define): Fix minor quirk in the tests.
24878 * ../errors/cs0215.cs : Added.
24880 * ../errors/cs0556.cs : Added.
24882 * ../errors/cs0555.cs : Added.
24884 2001-10-01 Miguel de Icaza <miguel@ximian.com>
24886 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
24887 single integer which is really efficient
24889 2001-10-01 Ravi Pratap <ravi@ximian.com>
24891 * expression.cs (Expression::ImplicitUserConversion): Use location
24892 even in the case when we are examining True operators.
24894 * class.cs (Operator::Define): Perform extensive checks to conform
24895 with the rules for operator overloading in the spec.
24897 * expression.cs (Expression::ImplicitReferenceConversion): Implement
24898 some of the other conversions mentioned in the spec.
24900 * typemanager.cs (array_type): New static member for the System.Array built-in
24903 (cloneable_interface): For System.ICloneable interface.
24905 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
24906 we start resolving the tree and populating types.
24908 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
24910 2001-10-01 Miguel de Icaza <miguel@ximian.com>
24912 * expression.cs (Expression::ExprClassFromMemberInfo,
24913 Expression::Literalize): Create literal expressions from
24914 FieldInfos which are literals.
24916 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
24917 type casts, because they were wrong. The test suite in tests
24920 (ImplicitNumericConversion): ushort to ulong requires a widening
24923 Int32 constant to long requires widening cast as well.
24925 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
24926 for integers because the type on the stack is not i4.
24928 2001-09-30 Miguel de Icaza <miguel@ximian.com>
24930 * expression.cs (report118): require location argument.
24932 * parameter.cs: Do not dereference potential null value.
24934 * class.cs: Catch methods that lack the `new' keyword when
24935 overriding a name. Report warnings when `new' is used without
24936 anything being there to override.
24938 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
24940 * class.cs: Only add constructor to hashtable if it is non-null
24941 (as now constructors can fail on define).
24943 (TypeManager, Class, Struct): Take location arguments.
24945 Catch field instance initialization in structs as errors.
24947 accepting_filter: a new filter for FindMembers that is static so
24948 that we dont create an instance per invocation.
24950 (Constructor::Define): Catch errors where a struct constructor is
24953 * cs-parser.jay: Pass location information for various new
24956 * delegate.cs (Delegate): take a location argument.
24958 * driver.cs: Do not call EmitCode if there were problesm in the
24959 Definition of the types, as many Builders wont be there.
24961 * decl.cs (Decl::Decl): Require a location argument.
24963 * cs-tokenizer.cs: Handle properly hex constants that can not fit
24964 into integers, and find the most appropiate integer for it.
24966 * literal.cs: Implement ULongLiteral.
24968 * rootcontext.cs: Provide better information about the location of
24969 failure when CreateType fails.
24971 2001-09-29 Miguel de Icaza <miguel@ximian.com>
24973 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
24976 * expression.cs (Binary::CheckShiftArguments): Add missing type
24978 (Binary::ResolveOperator): Add type to the logical and and logical
24979 or, Bitwise And/Or and Exclusive Or code paths, it was missing
24982 (Binary::DoNumericPromotions): In the case where either argument
24983 is ulong (and most signed types combined with ulong cause an
24984 error) perform implicit integer constant conversions as well.
24986 2001-09-28 Miguel de Icaza <miguel@ximian.com>
24988 * expression.cs (UserImplicitCast): Method should always be
24990 (Invocation::BetterConversion): Simplified test for IntLiteral.
24992 (Expression::ImplicitNumericConversion): Split this routine out.
24993 Put the code that performs implicit constant integer conversions
24996 (Expression::Resolve): Become a wrapper around DoResolve so we can
24997 check eclass and type being set after resolve.
24999 (Invocation::Badness): Remove this dead function
25001 (Binary::ResolveOperator): Do not compute the expensive argumnets
25002 unless we have a union for it.
25004 (Probe::Emit): Is needs to do an isinst and then
25005 compare against null.
25007 (::CanConvert): Added Location argument. If the Location argument
25008 is null (Location.Null), then we do not report errors. This is
25009 used by the `probe' mechanism of the Explicit conversion. We do
25010 not want to generate an error for something that the user
25011 explicitly requested to be casted. But the pipeline for an
25012 explicit cast first tests for potential implicit casts.
25014 So for now, if the Location is null, it means `Probe only' to
25015 avoid adding another argument. Might have to revise this
25018 (ClassCast): New class used to type cast objects into arbitrary
25019 classes (used in Explicit Reference Conversions).
25021 Implement `as' as well.
25023 Reverted all the patches from Ravi below: they were broken:
25025 * The use of `level' as a mechanism to stop recursive
25026 invocations is wrong. That was there just to catch the
25027 bug with a strack trace but not as a way of addressing
25030 To fix the problem we have to *understand* what is going
25031 on and the interactions and come up with a plan, not
25032 just get things going.
25034 * The use of the type conversion cache that I proposed
25035 last night had an open topic: How does this work across
25036 protection domains. A user defined conversion might not
25037 be public in the location where we are applying the
25038 conversion, a different conversion might be selected
25039 (ie, private A->B (better) but public B->A (worse),
25040 inside A, A->B applies, but outside it, B->A will
25043 * On top of that (ie, even if the above is solved),
25044 conversions in a cache need to be abstract. Ie, `To
25045 convert from an Int to a Short use an OpcodeCast', not
25046 `To convert from an Int to a Short use the OpcodeCast on
25047 the variable 5' (which is what this patch was doing).
25049 2001-09-28 Ravi Pratap <ravi@ximian.com>
25051 * expression.cs (Invocation::ConversionExists): Re-write to use
25052 the conversion cache
25054 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25055 cache all conversions done, not just user-defined ones.
25057 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25058 to determine if a conversion exists instead of acutually trying to
25059 perform the conversion. It's faster too.
25061 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25062 and only then attempt the implicit conversion.
25064 2001-09-28 Ravi Pratap <ravi@ximian.com>
25066 * expression.cs (ConvertImplicit): Use a cache for conversions
25067 already found. Check level of recursion and bail out if necessary.
25069 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25071 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25072 Export standard methods that we expect for string operations.
25074 * statement.cs (Block::UsageWarning): Track usage of variables and
25075 report the errors for not used variables.
25077 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25080 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25082 * codegen.cs: remove unnneded code
25084 * expression.cs: Removed BuiltinTypeAccess class
25086 Fix the order in which implicit conversions are
25089 The previous fixed dropped support for boxed conversions (adding a
25090 test to the test suite now)
25092 (UserImplicitCast::CanConvert): Remove test for source being null,
25093 that code is broken. We should not feed a null to begin with, if
25094 we do, then we should track the bug where the problem originates
25095 and not try to cover it up here.
25097 Return a resolved expression of type UserImplicitCast on success
25098 rather than true/false. Ravi: this is what I was talking about,
25099 the pattern is to use a static method as a "constructor" for
25102 Also, do not create arguments until the very last minute,
25103 otherwise we always create the arguments even for lookups that
25104 will never be performed.
25106 (UserImplicitCast::Resolve): Eliminate, objects of type
25107 UserImplicitCast are born in a fully resolved state.
25109 * typemanager.cs (InitCoreTypes): Init also value_type
25110 (System.ValueType).
25112 * expression.cs (Cast::Resolve): First resolve the child expression.
25114 (LValue): Add new method AddressOf to be used by
25117 Change the argument of Store to take an EmitContext instead of an
25118 ILGenerator, because things like FieldExpr need to be able to call
25119 their children expression to generate the instance code.
25121 (Expression::Error, Expression::Warning): Sugar functions for
25124 (Expression::MemberLookup): Accept a TypeContainer instead of a
25125 Report as the first argument.
25127 (Expression::ResolvePrimary): Killed. I still want to improve
25128 this as currently the code is just not right.
25130 (Expression::ResolveMemberAccess): Simplify, but it is still
25133 (Unary::Resolve): Catch errors in AddressOf operators.
25135 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25136 index to a byte for the short-version, or the compiler will choose
25137 the wrong Emit call, which generates the wrong data.
25139 (ParameterReference::Emit, ::Store): same.
25141 (FieldExpr::AddressOf): Implement.
25143 * typemanager.cs: TypeManager: made public variable instead of
25146 * driver.cs: document --fatal.
25148 * report.cs (ErrorMessage, WarningMessage): new names for the old
25149 Error and Warning classes.
25151 * cs-parser.jay (member_access): Turn built-in access to types
25152 into a normal simplename
25154 2001-09-27 Ravi Pratap <ravi@ximian.com>
25156 * expression.cs (Invocation::BetterConversion): Fix to cope
25157 with q being null, since this was introducing a bug.
25159 * expression.cs (ConvertImplicit): Do built-in conversions first.
25161 2001-09-27 Ravi Pratap <ravi@ximian.com>
25163 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25165 2001-09-27 Ravi Pratap <ravi@ximian.com>
25167 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25168 I had introduced long ago (what's new ?).
25170 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25171 the work of all the checking.
25172 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25173 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25175 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25176 that is the right way.
25178 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25179 overloading resolution. Use everywhere instead of cutting and pasting code.
25181 (Binary::ResolveOperator): Use MakeUnionSet.
25183 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25184 we have to convert to bool types. Not complete yet.
25186 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25188 * typemanager.cs (TypeManager::CSharpName): support ushort.
25190 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25191 to provide an expression that performsn an implicit constant int
25192 conversion (section 6.1.6).
25193 (Expression::ConvertImplicitRequired): Reworked to include
25194 implicit constant expression conversions.
25196 (Expression::ConvertNumericExplicit): Finished.
25198 (Invocation::Emit): If InstanceExpression is null, then it means
25199 that we perform a call on this.
25201 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25203 * expression.cs (Unary::Emit): Remove some dead code.
25204 (Probe): Implement Resolve and Emit for `is'.
25205 (Expression::ConvertImplicitRequired): Attempt to do constant
25206 expression conversions here. Maybe should be moved to
25207 ConvertImplicit, but I am not sure.
25208 (Expression::ImplicitLongConstantConversionPossible,
25209 Expression::ImplicitIntConstantConversionPossible): New functions
25210 that tell whether is it possible to apply an implicit constant
25211 expression conversion.
25213 (ConvertNumericExplicit): Started work on explicit numeric
25216 * cs-parser.jay: Update operator constants.
25218 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25219 (Parameters::GetSignature): Hook up VerifyArgs here.
25220 (Parameters::VerifyArgs): Verifies that no two arguments have the
25223 * class.cs (Operator): Update the operator names to reflect the
25224 ones that the spec expects (as we are just stringizing the
25227 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25228 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25229 previous usage did only work for our methods.
25230 (Expression::ConvertImplicit): Handle decimal implicit numeric
25231 conversions as well.
25232 (Expression::InternalTypeConstructor): Used to invoke constructors
25233 on internal types for default promotions.
25235 (Unary::Emit): Implement special handling for the pre/post
25236 increment/decrement for overloaded operators, as they need to have
25237 the same semantics as the other operators.
25239 (Binary::ResolveOperator): ditto.
25240 (Invocation::ConversionExists): ditto.
25241 (UserImplicitCast::Resolve): ditto.
25243 2001-09-26 Ravi Pratap <ravi@ximian.com>
25245 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25246 operator, return after emitting body. Regression tests pass again !
25248 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25249 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25250 (Invocation::OverloadResolve): Ditto.
25251 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25253 * everywhere : update calls to the above methods accordingly.
25255 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25257 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25259 * expression.cs (ExpressionStatement): New base class used for
25260 expressions that can appear in statements, so that we can provide
25261 an alternate path to generate expression that do not leave a value
25264 (Expression::Emit, and all the derivatives): We no longer return
25265 whether a value is left on the stack or not. Every expression
25266 after being emitted leaves a single value on the stack.
25268 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25269 facilties of ExpressionStatement if possible.
25271 * cs-parser.jay: Update statement_expression.
25273 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25275 * driver.cs: Change the wording of message
25277 2001-09-25 Ravi Pratap <ravi@ximian.com>
25279 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25280 the type of the expression to the return type of the method if
25281 we have an overloaded operator match ! The regression tests pass again !
25282 (Unary::ResolveOperator): Ditto.
25284 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25285 to find "op_Implicit", not "implicit" ;-)
25286 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25287 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25289 * everywhere : Correct calls to the above accordingly.
25291 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25292 (ConvertImplicit): Do user-defined conversion if it exists.
25294 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25296 * assign.cs: track location.
25297 (Resolve): Use implicit conversions on assignment.
25299 * literal.cs: Oops. Not good, Emit of short access values should
25300 pass (Bytes) or the wrong argument will be selected.
25302 * expression.cs (Unary::Emit): Emit code for -expr.
25304 (Unary::ResolveOperator): Handle `Substract' for non-constants
25305 (substract from zero from the non-constants).
25306 Deal with Doubles as well.
25308 (Expression::ConvertImplicitRequired): New routine that reports an
25309 error if no implicit conversion exists.
25311 (Invocation::OverloadResolve): Store the converted implicit
25312 expressions if we make them
25314 2001-09-24 Ravi Pratap <ravi@ximian.com>
25316 * class.cs (ConstructorInitializer): Take a Location argument.
25317 (ConstructorBaseInitializer): Same here.
25318 (ConstructorThisInitializer): Same here.
25320 * cs-parser.jay : Update all calls accordingly.
25322 * expression.cs (Unary, Binary, New): Take location argument.
25323 Update accordingly everywhere.
25325 * cs-parser.jay : Update all calls to the above to take a location
25328 * class.cs : Ditto.
25330 2001-09-24 Ravi Pratap <ravi@ximian.com>
25332 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25333 (Invocation::BetterConversion): Same here
25334 (Invocation::ConversionExists): Ditto.
25336 (Invocation::ConversionExists): Implement.
25338 2001-09-22 Ravi Pratap <ravi@ximian.com>
25340 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25341 Also take an additional TypeContainer argument.
25343 * All over : Pass in TypeContainer as argument to OverloadResolve.
25345 * typemanager.cs (CSharpName): Update to check for the string type and return
25348 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25351 2001-09-21 Ravi Pratap <ravi@ximian.com>
25353 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25354 (Invocation::BetterFunction): Implement.
25355 (Invocation::BetterConversion): Implement.
25356 (Invocation::ConversionExists): Skeleton, no implementation yet.
25358 Okay, things work fine !
25360 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25362 * typemanager.cs: declare and load enum_type, delegate_type and
25365 * expression.cs (Expression::Emit): Now emit returns a value that
25366 tells whether a value is left on the stack or not. This strategy
25367 might be reveted tomorrow with a mechanism that would address
25368 multiple assignments.
25369 (Expression::report118): Utility routine to report mismatches on
25372 (Unary::Report23): Report impossible type/operator combination
25375 (Unary::IsIncrementableNumber): Whether the type can be
25376 incremented or decremented with add.
25377 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25379 (Unary::ResolveOperator): Implement ++, !, ~,
25381 (Invocation::Emit): Deal with new Emit convetion.
25383 * All Expression derivatives: Updated their Emit method to return
25384 whether they leave values on the stack or not.
25386 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25387 stack for expressions that are statements.
25389 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25391 * expression.cs (LValue): New interface. Must be implemented by
25393 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25396 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25397 interface for generating code, simplifies the code.
25399 2001-09-20 Ravi Pratap <ravi@ximian.com>
25401 * expression.cs (everywhere): Comment out return statements in ::Resolve
25402 methods to avoid the warnings.
25404 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25406 * driver.cs (parse): Report error 2001 if we can not open the
25409 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25412 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25415 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25416 otherwise nested blocks end up with the same index.
25418 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25420 * expression.cs: Instead of having FIXMEs in the Resolve
25421 functions, throw exceptions so it is obvious that we are facing a
25424 * cs-parser.jay (invocation_expression): Pass Location information.
25426 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25427 Use a basename for those routines because .NET does not like paths
25430 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25433 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25435 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25436 are loading the correct data types (throws an exception if not).
25437 (TypeManager::InitCoreTypes): Use CoreLookupType
25439 * expression.cs (Unary::ResolveOperator): return the child
25440 expression for expressions which are just +expr.
25441 (Unary::ResolveOperator): Return negative literals for -LITERAL
25442 expressions (otherwise they are Unary {Literal}).
25443 (Invocation::Badness): Take into account `Implicit constant
25444 expression conversions'.
25446 * literal.cs (LongLiteral): Implement long literal class.
25447 (IntLiteral): export the `Value' of the intliteral.
25449 2001-09-19 Ravi Pratap <ravi@ximian.com>
25451 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25453 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25454 instead of 'Operator'
25456 * expression.cs (Binary::ResolveOperator): Update accordingly.
25457 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25460 * cs-parser.jay (unary_expression): Update to use the new names.
25462 * gen-treedump.cs (GetUnary): Same here.
25464 * expression.cs (Unary::Resolve): Implement.
25465 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25466 operators are found instead of making noise ;-)
25467 (Unary::ResolveOperator): New method to do precisely the same thing which
25468 Binary::ResolveOperator does for Binary expressions.
25469 (Unary.method, .Arguments): Add.
25470 (Unary::OperName): Implement.
25471 (Unary::ForceConversion): Copy and Paste !
25473 * class.cs (Operator::Define): Fix a small bug for the case when we have
25476 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25477 for the inbuilt operators. Only overloading works for now ;-)
25479 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25481 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25482 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25484 * expression.cs (This::Emit): Implement.
25485 (This::Resolve): Implement.
25486 (TypeOf:Resolve): Implement.
25487 (Expression::ResolveSimpleName): Add an implicit this to instance
25489 (MemberAccess::Resolve): Deal with Parameters and Fields.
25490 Bind instance variable to Field expressions.
25491 (FieldExpr::Instance): New field used to track the expression that
25492 represents the object instance.
25493 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25495 (FieldExpr::Emit): Implement.
25497 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25498 the last instruction contains a return opcode to avoid generating
25499 the last `ret' instruction (this generates correct code, and it is
25500 nice to pass the peverify output).
25502 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25503 initializer for static and instance variables.
25504 (Constructor::Emit): Allow initializer to be null in the case of
25505 static constructors. Only emit initializer for instance
25508 (TypeContainer::FindMembers): Return a null array if there are no
25511 Also fix the code for the MemberTypes.Method branch, as it was not
25512 scanning that for operators (or tried to access null variables before).
25514 * assign.cs (Assign::Emit): Handle instance and static fields.
25518 * driver.cs: Stop compilation if there are parse errors.
25520 * cs-parser.jay (constructor_declaration): Provide default base
25521 initializer for non-static constructors.
25522 (constructor_declarator): Do not provide a default base
25523 initializers if none was specified.
25524 Catch the fact that constructors should not have parameters.
25526 * class.cs: Do not emit parent class initializers for static
25527 constructors, that should be flagged as an error.
25529 2001-09-18 Ravi Pratap <ravi@ximian.com>
25531 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25532 Move back code into TypeContainer::Populate.
25534 2001-09-18 Ravi Pratap <ravi@ximian.com>
25536 * class.cs (TypeContainer::AddConstructor): Fix the check to
25537 compare against Name, not Basename.
25538 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25540 * cs-parser.jay : Update accordingly.
25542 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25543 for methods, don't forget to look into the operators too.
25544 (RegisterMethodBuilder): Helper method to take care of this for
25545 methods, constructors and operators.
25546 (Operator::Define): Completely revamp.
25547 (Operator.OperatorMethod, MethodName): New fields.
25548 (TypeContainer::Populate): Move the registering of builders into
25549 RegisterMethodBuilder.
25550 (Operator::Emit): Re-write.
25552 * expression.cs (Binary::Emit): Comment out code path to emit method
25553 invocation stuff for the case when we have a user defined operator. I am
25554 just not able to get it right !
25556 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25558 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25561 (Expression::MemberLookup): Provide a version that allows to
25562 specify the MemberTypes and BindingFlags.
25564 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25565 so it was not fetching variable information from outer blocks.
25567 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25568 Beforefieldinit as it was buggy.
25570 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25571 that Ravi put here.
25573 * class.cs (Constructor::Emit): Only emit if block is not null.
25574 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25575 deal with this by semantically definining it as if the user had
25578 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25579 constructors as we now "emit" them at a higher level.
25581 (TypeContainer::DefineDefaultConstructor): Used to define the
25582 default constructors if none was provided.
25584 (ConstructorInitializer): Add methods Resolve and Emit.
25586 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25588 2001-09-17 Ravi Pratap <ravi@ximian.com>
25590 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25591 the default constructor builder with our hashtable for methodbuilders
25594 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25595 and argument_count is 0 in which case we have a match.
25596 (Binary::ResolveOperator): More null checking and miscellaneous coding
25599 2001-09-17 Ravi Pratap <ravi@ximian.com>
25601 * rootcontext.cs (IsNameSpace): Compare against null.
25603 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25605 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25606 and Unary::Operator.
25608 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25611 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25612 we have overloaded operators.
25613 (Binary::ResolveOperator): Implement the part which does the operator overload
25616 * class.cs (Operator::Emit): Implement.
25617 (TypeContainer::Emit): Emit the operators we have too.
25619 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25620 the case when we have a user-defined operator.
25622 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25624 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
25626 2001-09-16 Ravi Pratap <ravi@ximian.com>
25628 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
25629 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
25630 (Constructor::Emit): Implement.
25631 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
25632 if we have no work to do.
25633 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
25636 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
25637 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
25639 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
25642 2001-09-15 Ravi Pratap <ravi@ximian.com>
25644 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
25646 (Tree::RecordNamespace): Method to do what the name says ;-)
25647 (Tree::Namespaces): Property to get at the namespaces hashtable.
25649 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
25652 * rootcontext.cs (IsNamespace): Fixed it :-)
25654 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25656 * class.cs (TypeContainer::FindMembers): Add support for
25658 (MethodCore): New class that encapsulates both the shared aspects
25659 of a Constructor and a Method.
25660 (Method, Constructor): Factored pieces into MethodCore.
25662 * driver.cs: Added --fatal which makes errors throw exceptions.
25663 Load System assembly as well as part of the standard library.
25665 * report.cs: Allow throwing exceptions on errors for debugging.
25667 * modifiers.cs: Do not use `parent', instead use the real type
25668 container to evaluate permission settings.
25670 * class.cs: Put Ravi's patch back in. He is right, and we will
25671 have to cope with the
25673 2001-09-14 Ravi Pratap <ravi@ximian.com>
25675 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
25676 FamORAssem, not FamANDAssem.
25678 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25680 * driver.cs: Added --parse option that only parses its input files
25683 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
25684 incorrect. IsTopLevel is not used to tell whether an object is
25685 root_types or not (that can be achieved by testing this ==
25686 root_types). But to see if this is a top-level *class* (not
25687 necessarly our "toplevel" container).
25689 2001-09-14 Ravi Pratap <ravi@ximian.com>
25691 * enum.cs (Enum::Define): Modify to call the Lookup method on the
25692 parent instead of a direct call to GetType.
25694 2001-09-14 Ravi Pratap <ravi@ximian.com>
25696 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
25697 Modifiers.TypeAttr. This should just be a call to that method.
25699 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
25700 object so that we can determine if we are top-level or not.
25702 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
25705 * enum.cs (Enum::Define): Ditto.
25707 * modifiers.cs (FieldAttr): Re-write.
25709 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
25710 (TypeContainer::HaveStaticConstructor): New property to provide access
25711 to precisely that info.
25713 * modifiers.cs (MethodAttr): Re-write.
25714 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
25716 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
25717 of top-level types as claimed.
25719 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25721 * expression.cs (MemberLookup): Fruitless attempt to lookup
25722 constructors. Maybe I need to emit default constructors? That
25723 might be it (currently .NET emits this for me automatically).
25724 (Invocation::OverloadResolve): Cope with Arguments == null.
25725 (Invocation::EmitArguments): new function, shared by the new
25726 constructor and us.
25727 (Invocation::Emit): Handle static and instance methods. Emit
25728 proper call instruction for virtual or non-virtual invocations.
25729 (New::Emit): Implement.
25730 (New::Resolve): Implement.
25731 (MemberAccess:Resolve): Implement.
25732 (MethodGroupExpr::InstanceExpression): used conforming to the spec
25733 to track instances.
25734 (FieldExpr::Resolve): Set type.
25736 * support.cs: Handle empty arguments.
25738 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
25739 SimpleLookup): Auxiliary routines to help parse a qualifier
25742 Update qualifier_identifier rule.
25744 * codegen.cs: Removed debugging messages.
25746 * class.cs: Make this a global thing, this acts just as a "key" to
25747 objects that we might have around.
25749 (Populate): Only initialize method_builders_to_methods once.
25751 * expression.cs (PropertyExpr): Initialize type from the
25754 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
25755 Resolve pattern. Attempt to implicitly convert value to boolean.
25758 * expression.cs: Set the type for the int32/int32 argument case.
25759 (Binary::ResolveOperator): Set the return type to boolean for
25760 comparission operators
25762 * typemanager.cs: Remove debugging print code.
25764 (Invocation::Resolve): resolve type.
25766 * class.cs: Allocate a MemberInfo of the correct size, as the code
25767 elsewhere depends on the test to reflect the correct contents.
25769 (Method::) Keep track of parameters, due to System.Reflection holes
25771 (TypeContainer::Populate): Keep track of MethodBuilders to Method
25774 (TypeContainer::FindMembers): Use ArrayList and then copy an array
25775 of the exact size and return that.
25777 (Class::LookupMethodByBuilder): New function that maps
25778 MethodBuilders to its methods. Required to locate the information
25779 on methods because System.Reflection bit us again.
25781 * support.cs: New file, contains an interface ParameterData and
25782 two implementations: ReflectionParameters and InternalParameters
25783 used to access Parameter information. We will need to grow this
25786 * expression.cs (Invocation::GetParameterData): implement a cache
25787 and a wrapper around the ParameterData creation for methods.
25788 (Invocation::OverloadResolve): Use new code.
25790 2001-09-13 Ravi Pratap <ravi@ximian.com>
25792 * class.cs (TypeContainer::EmitField): Remove and move into
25793 (Field::Define): here and modify accordingly.
25794 (Field.FieldBuilder): New member.
25795 (TypeContainer::Populate): Update accordingly.
25796 (TypeContainer::FindMembers): Implement.
25798 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25800 * statement.cs: (VariableInfo::VariableType): New field to be
25801 initialized with the full type once it is resolved.
25803 2001-09-12 Miguel de Icaza <miguel@ximian.com>
25805 * parameter.cs (GetParameterInfo): Use a type cache to compute
25806 things only once, and to reuse this information
25808 * expression.cs (LocalVariableReference::Emit): Implement.
25809 (OpcodeCast::Emit): fix.
25811 (ParameterReference::Resolve): Implement.
25812 (ParameterReference::Emit): Implement.
25814 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
25815 that are expressions need to stay as Expressions.
25817 * typemanager.cs (CSharpName): Returns the C# name of a type if
25820 * expression.cs (Expression::ConvertImplicit): New function that
25821 implements implicit type conversions.
25823 (Expression::ImplicitReferenceConversion): Implements implicit
25824 reference conversions.
25826 (EmptyCast): New type for transparent casts.
25828 (OpcodeCast): New type for casts of types that are performed with
25829 a sequence of bytecodes.
25831 (BoxedCast): New type used for casting value types into reference
25832 types. Emits a box opcode.
25834 (Binary::DoNumericPromotions): Implements numeric promotions of
25835 and computation of the Binary::Type.
25837 (Binary::EmitBranchable): Optimization.
25839 (Binary::Emit): Implement code emission for expressions.
25841 * typemanager.cs (TypeManager): Added two new core types: sbyte
25844 2001-09-12 Ravi Pratap <ravi@ximian.com>
25846 * class.cs (TypeContainer::FindMembers): Method which does exactly
25847 what Type.FindMembers does, only we don't have to use reflection. No
25848 implementation yet.
25850 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
25851 typecontainer objects as we need to get at them.
25852 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
25854 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
25855 typecontainer object.
25857 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
25858 of just a Report object.
25860 2001-09-11 Ravi Pratap <ravi@ximian.com>
25862 * class.cs (Event::Define): Go back to using the prefixes "add_" and
25864 (TypeContainer::Populate): Now define the delegates of the type too.
25865 (TypeContainer.Delegates): Property to access the list of delegates defined
25868 * delegates.cs (Delegate::Define): Implement partially.
25870 * modifiers.cs (TypeAttr): Handle more flags.
25872 2001-09-11 Ravi Pratap <ravi@ximian.com>
25874 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
25876 (Operator::Define): Re-write logic to get types by using the LookupType method
25877 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
25878 (Indexer::Define): Ditto.
25879 (Event::Define): Ditto.
25880 (Property::Define): Ditto.
25882 2001-09-10 Ravi Pratap <ravi@ximian.com>
25884 * class.cs (TypeContainer::Populate): Now define operators too.
25885 (TypeContainer.Operators): New property to access the list of operators
25887 (Operator.OperatorMethodBuilder): New member to hold the method builder
25888 for the operator we are defining.
25889 (Operator::Define): Implement.
25891 2001-09-10 Ravi Pratap <ravi@ximian.com>
25893 * class.cs (Event::Define): Make the prefixes of the accessor methods
25894 addOn_ and removeOn_
25896 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
25897 of the location being passed in too. Ideally, this should go later since all
25898 error reporting should be done through the Report object.
25900 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
25901 (Populate): Iterate thru the indexers we have and define them too.
25902 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
25903 for the get and set accessors.
25904 (Indexer::Define): Implement.
25906 2001-09-09 Miguel de Icaza <miguel@ximian.com>
25908 * expression.cs (Binary::Resolve): Beginning of it. I scratched
25909 my previous implementation, did not work.
25911 * typemanager.cs: Add a couple of missing types (the longs).
25913 * literal.cs: Use TypeManager.bool_type instead of getting it.
25915 * expression.cs (EventExpr): New kind of expressions.
25916 (Expressio::ExprClassFromMemberInfo): finish
25918 2001-09-08 Miguel de Icaza <miguel@ximian.com>
25920 * assign.cs: Emit stores to static fields differently.
25922 2001-09-08 Ravi Pratap <ravi@ximian.com>
25924 * Merge in changes and adjust code to tackle conflicts. Backed out my
25925 code in Assign::Resolve ;-)
25927 2001-09-08 Ravi Pratap <ravi@ximian.com>
25929 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
25930 instead Report.Error and also pass in the location.
25931 (CSharpParser::Lexer): New readonly property to return the reference
25932 to the Tokenizer object.
25933 (declare_local_variables): Use Report.Error with location instead of plain
25937 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
25938 (Operator.CheckBinaryOperator): Ditto.
25940 * cs-parser.jay (operator_declarator): Update accordingly.
25942 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
25943 (CheckBinaryOperator): Same here.
25945 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
25946 on the name without any prefixes of namespace names etc. This is because we
25947 already might have something already fully qualified like
25948 'System.Console.WriteLine'
25950 * assign.cs (Resolve): Begin implementation. Stuck ;-)
25952 2001-09-07 Ravi Pratap <ravi@ximian.com>
25954 * cs-tokenizer.cs (location): Return a string which also contains
25957 * expression.cs (ElementAccess): New class for expressions of the
25958 type 'element access.'
25959 (BaseAccess): New class for expressions of the type 'base access.'
25960 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
25963 * cs-parser.jay (element_access): Implement action.
25964 (base_access): Implement actions.
25965 (checked_expression, unchecked_expression): Implement.
25967 * cs-parser.jay (local_variable_type): Correct and implement.
25968 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
25970 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
25972 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
25973 name and the specifiers.
25975 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
25977 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
25978 making them all public ;-)
25980 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
25983 2001-09-07 Miguel de Icaza <miguel@ximian.com>
25985 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
25987 (FieldExpr, PropertyExprs): New resolved expressions.
25988 (SimpleName::MemberStaticCheck): Perform static checks for access
25989 to non-static fields on static methods. Maybe this should be
25990 generalized for MemberAccesses.
25991 (SimpleName::ResolveSimpleName): More work on simple name
25994 * cs-parser.jay (primary_expression/qualified_identifier): track
25995 the parameter index.
25997 * codegen.cs (CodeGen::Save): Catch save exception, report error.
25998 (EmitContext::EmitBoolExpression): Chain to expression generation
25999 instead of temporary hack.
26000 (::EmitStatementExpression): Put generic expression code generation.
26002 * assign.cs (Assign::Emit): Implement variable assignments to
26003 local variables, parameters and fields.
26005 2001-09-06 Miguel de Icaza <miguel@ximian.com>
26007 * statement.cs (Block::GetVariableInfo): New method, returns the
26008 VariableInfo for a variable name in a block.
26009 (Block::GetVariableType): Implement in terms of GetVariableInfo
26011 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26012 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26014 2001-09-06 Ravi Pratap <ravi@ximian.com>
26016 * cs-parser.jay (operator_declaration): Continue on my quest : update
26017 to take attributes argument.
26018 (event_declaration): Ditto.
26019 (enum_declaration): Ditto.
26020 (indexer_declaration): Ditto.
26022 * class.cs (Operator::Operator): Update constructor accordingly.
26023 (Event::Event): Ditto.
26025 * delegate.cs (Delegate::Delegate): Same here.
26027 * enum.cs (Enum::Enum): Same here.
26029 2001-09-05 Ravi Pratap <ravi@ximian.com>
26031 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26033 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26035 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26036 being passed around as an arraylist.
26037 (Attributes::AddAttribute): Method to add attribute sections.
26039 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26040 (struct_declaration): Update accordingly.
26041 (constant_declaration): Update.
26042 (field_declaration): Update.
26043 (method_header): Update.
26044 (fixed_parameter): Update.
26045 (parameter_array): Ditto.
26046 (property_declaration): Ditto.
26047 (destructor_declaration): Ditto.
26049 * class.cs (Struct::Struct): Update constructors accordingly.
26050 (Class::Class): Ditto.
26051 (Field::Field): Ditto.
26052 (Method::Method): Ditto.
26053 (Property::Property): Ditto.
26054 (TypeContainer::OptAttribute): update property's return type.
26056 * interface.cs (Interface.opt_attributes): New member.
26057 (Interface::Interface): Update to take the extra Attributes argument.
26059 * parameter.cs (Parameter::Parameter): Ditto.
26061 * constant.cs (Constant::Constant): Ditto.
26063 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26064 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26065 the attributes as a parameter.
26066 (InterfaceProperty): Update constructor call.
26067 (InterfaceEvent): Ditto.
26068 (InterfaceMethod): Ditto.
26069 (InterfaceIndexer): Ditto.
26071 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26072 pass the attributes too.
26073 (interface_event_declaration): Ditto.
26074 (interface_property_declaration): Ditto.
26075 (interface_method_declaration): Ditto.
26076 (interface_declaration): Ditto.
26078 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26080 * class.cs (Method::Define): Track the "static Main" definition to
26081 create an entry point.
26083 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26084 EntryPoint if we find it.
26086 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26087 (EmitContext::ig): Make this variable public.
26089 * driver.cs: Make the default output file be the first file name
26090 with the .exe extension.
26092 Detect empty compilations
26094 Handle various kinds of output targets. Handle --target and
26095 rename -t to --dumper.
26097 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26098 methods inherited from Expression return now an Expression. This
26099 will is used during the tree rewriting as we resolve them during
26102 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26103 the spec. Missing entirely is the information about
26104 accessability of elements of it.
26106 (Expression::ExprClassFromMemberInfo): New constructor for
26107 Expressions that creates a fully initialized Expression based on
26108 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26111 (Invocation::Resolve): Begin implementing resolution of invocations.
26113 * literal.cs (StringLiteral): Implement Emit.
26115 2001-09-05 Ravi Pratap <ravi@ximian.com>
26117 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26120 2001-09-04 Ravi Pratap <ravi@ximian.com>
26122 * cs-parser.jay (attribute_arguments): Implement actions.
26123 (attribute): Fix bug in production. Implement action.
26124 (attribute_list): Implement.
26125 (attribute_target): Implement.
26126 (attribute_target_specifier, opt_target_specifier): Implement
26127 (CheckAttributeTarget): New method to check if the attribute target
26129 (attribute_section): Implement.
26130 (opt_attributes): Implement.
26132 * attribute.cs : New file to handle attributes.
26133 (Attribute): Class to hold attribute info.
26135 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26136 (attribute_section): Modify production to use 2 different rules to
26137 achieve the same thing. 1 s/r conflict down !
26138 Clean out commented, useless, non-reducing dimension_separator rules.
26140 * class.cs (TypeContainer.attributes): New member to hold list
26141 of attributes for a type.
26142 (Struct::Struct): Modify to take one more argument, the attribute list.
26143 (Class::Class): Ditto.
26144 (Field::Field): Ditto.
26145 (Method::Method): Ditto.
26146 (Property::Property): Ditto.
26148 * cs-parser.jay (struct_declaration): Update constructor call to
26149 pass in the attributes too.
26150 (class_declaration): Ditto.
26151 (constant_declaration): Ditto.
26152 (field_declaration): Ditto.
26153 (method_header): Ditto.
26154 (fixed_parameter): Ditto.
26155 (parameter_array): Ditto.
26156 (property_declaration): Ditto.
26158 * constant.cs (Constant::Constant): Update constructor similarly.
26159 Use System.Collections.
26161 * parameter.cs (Parameter::Parameter): Update as above.
26163 2001-09-02 Ravi Pratap <ravi@ximian.com>
26165 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26166 (TypeContainer.delegates): New member to hold list of delegates.
26168 * cs-parser.jay (delegate_declaration): Implement the action correctly
26169 this time as I seem to be on crack ;-)
26171 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26173 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26174 tell whether an identifier represents a namespace.
26176 * expression.cs (NamespaceExpr): A namespace expression, used only
26177 temporarly during expression resolution.
26178 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26179 utility functions to resolve names on expressions.
26181 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26183 * codegen.cs: Add hook for StatementExpressions.
26185 * class.cs: Fix inverted test for static flag in methods.
26187 2001-09-02 Ravi Pratap <ravi@ximian.com>
26189 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26190 to make it coincide with MS' number.
26191 (Operator::CheckBinaryOperator): Ditto.
26193 * ../errors/errors.txt : Remove error numbers added earlier.
26195 * ../errors/cs1019.cs : Test case for error # 1019
26197 * ../errros/cs1020.cs : Test case for error # 1020
26199 * cs-parser.jay : Clean out commented cruft.
26200 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26201 used anywhere - non-reducing rule.
26202 (namespace_declarations): Non-reducing rule - comment out.
26204 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26205 with TypeContainer::AddEnum.
26207 * delegate.cs : New file for delegate handling classes.
26208 (Delegate): Class for declaring delegates.
26210 * makefile : Update.
26212 * cs-parser.jay (delegate_declaration): Implement.
26214 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26216 * class.cs (Event::Define): Implement.
26217 (Event.EventBuilder): New member.
26219 * class.cs (TypeContainer::Populate): Update to define all enums and events
26221 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26222 readonly fields for all these cases ?
26224 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26226 * class.cs (Property): Revamp to use the convention of making fields readonly.
26227 Accordingly modify code elsewhere.
26229 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26230 the Define method of the Property class.
26232 * class.cs : Clean up applied patch and update references to variables etc. Fix
26234 (TypeContainer::Populate): Update to define all the properties we have. Also
26235 define all enumerations.
26237 * enum.cs (Define): Implement.
26239 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26241 * cs-parser.jay (overloadable_operator): The semantic value is an
26242 enum of the Operator class.
26243 (operator_declarator): Implement actions.
26244 (operator_declaration): Implement.
26246 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26247 validity of definitions.
26248 (Operator::CheckBinaryOperator): Static method to check for binary operators
26249 (TypeContainer::AddOperator): New method to add an operator to a type.
26251 * cs-parser.jay (indexer_declaration): Added line to actually call the
26252 AddIndexer method so it gets added ;-)
26254 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26255 already taken care of by the MS compiler ?
26257 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26259 * class.cs (Operator): New class for operator declarations.
26260 (Operator::OpType): Enum for the various operators.
26262 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26264 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26265 ostensibly handle this in semantic analysis.
26267 * cs-parser.jay (general_catch_clause): Comment out
26268 (specific_catch_clauses, specific_catch_clause): Ditto.
26269 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26270 (catch_args, opt_catch_args): New productions.
26271 (catch_clause): Rewrite to use the new productions above
26272 (catch_clauses): Modify accordingly.
26273 (opt_catch_clauses): New production to use in try_statement
26274 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26275 and re-write the code in the actions to extract the specific and
26276 general catch clauses by being a little smart ;-)
26278 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26279 Hooray, try and catch statements parse fine !
26281 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26283 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26284 string from the hashtable of variables.
26286 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26287 I end up making that mistake ;-)
26288 (catch_clauses): Fixed gross error which made Key and Value of the
26289 DictionaryEntry the same : $1 !!
26291 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26293 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26295 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26296 when the add and remove accessors are specified.
26298 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26300 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26301 information about indexer_declarator.
26302 (indexer_declarator): Implement actions.
26303 (parsing_indexer): New local boolean used to keep track of whether
26304 we are parsing indexers or properties. This is necessary because
26305 implicit_parameters come into picture even for the get accessor in the
26306 case of an indexer.
26307 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26309 * class.cs (Indexer): New class for indexer declarations.
26310 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26311 (TypeContainer::indexers): New member to hold list of indexers for the
26314 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26316 * cs-parser.jay (add_accessor_declaration): Implement action.
26317 (remove_accessor_declaration): Implement action.
26318 (event_accessors_declaration): Implement
26319 (variable_declarators): swap statements for first rule - trivial.
26321 * class.cs (Event): New class to hold information about event
26323 (TypeContainer::AddEvent): New method to add an event to a type
26324 (TypeContainer::events): New member to hold list of events.
26326 * cs-parser.jay (event_declaration): Implement actions.
26328 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26330 * cs-parser.jay (dim_separators): Implement. Make it a string
26331 concatenating all the commas together, just as they appear.
26332 (opt_dim_separators): Modify accordingly
26333 (rank_specifiers): Update accordingly. Basically do the same
26334 thing - instead, collect the brackets here.
26335 (opt_rank_sepcifiers): Modify accordingly.
26336 (array_type): Modify to actually return the complete type string
26337 instead of ignoring the rank_specifiers.
26338 (expression_list): Implement to collect the expressions
26339 (variable_initializer): Implement. We make it a list of expressions
26340 essentially so that we can handle the array_initializer case neatly too.
26341 (variable_initializer_list): Implement.
26342 (array_initializer): Make it a list of variable_initializers
26343 (opt_array_initializer): Modify accordingly.
26345 * expression.cs (New::NType): Add enumeration to help us
26346 keep track of whether we have an object/delegate creation
26347 or an array creation.
26348 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26349 members to hold data about array creation.
26350 (New:New): Modify to update NewType
26351 (New:New): New Overloaded contructor for the array creation
26354 * cs-parser.jay (array_creation_expression): Implement to call
26355 the overloaded New constructor.
26357 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26359 * class.cs (TypeContainer::Constructors): Return member
26360 constructors instead of returning null.
26362 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26364 * typemanager.cs (InitCoreTypes): Initialize the various core
26365 types after we have populated the type manager with the user
26366 defined types (this distinction will be important later while
26367 compiling corlib.dll)
26369 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26370 on Expression Classification. Now all expressions have a method
26371 `Resolve' and a method `Emit'.
26373 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26374 generation from working. Also add some temporary debugging
26377 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26379 * codegen.cs: Lots of code generation pieces. This is only the
26380 beginning, will continue tomorrow with more touches of polish. We
26381 handle the fundamentals of if, while, do, for, return. Others are
26382 trickier and I need to start working on invocations soon.
26384 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26387 * codegen.cs (EmitContext): New struct, used during code
26388 emission to keep a context. Most of the code generation will be
26391 * cs-parser.jay: Add embedded blocks to the list of statements of
26392 this block. So code generation proceeds in a top down fashion.
26394 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26396 * statement.cs: Add support for multiple child blocks.
26398 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26400 * codegen.cs (EmitCode): New function, will emit the code for a
26401 Block of code given a TypeContainer and its ILGenerator.
26403 * statement.cs (Block): Standard public readonly optimization.
26404 (Block::Block constructors): Link children.
26405 (Block::Child): Child Linker.
26406 (Block::EmitVariables): Emits IL variable declarations.
26408 * class.cs: Drop support for MethodGroups here, delay until
26410 (Method::): Applied the same simplification that I did before, and
26411 move from Properties to public readonly fields.
26412 (Method::ParameterTypes): Returns the parameter types for the
26413 function, and implements a cache that will be useful later when I
26414 do error checking and the semantic analysis on the methods is
26416 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26417 and made a method, optional argument tells whether this is a class
26418 or a structure to apply the `has-this' bit.
26419 (Method::GetCallingConvention): Implement, returns the calling
26421 (Method::Define): Defines the type, a second pass is performed
26422 later to populate the methods.
26424 (Constructor::ParameterTypes): implement a cache similar to the
26425 one on Method::ParameterTypes, useful later when we do semantic
26428 (TypeContainer::EmitMethod): New method. Emits methods.
26430 * expression.cs: Removed MethodGroup class from here.
26432 * parameter.cs (Parameters::GetCallingConvention): new method.
26434 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26436 * class.cs (TypeContainer::Populate): Drop RootContext from the
26439 (Constructor::CallingConvention): Returns the calling convention.
26440 (Constructor::ParameterTypes): Returns the constructor parameter
26443 (TypeContainer::AddConstructor): Keep track of default constructor
26444 and the default static constructor.
26446 (Constructor::) Another class that starts using `public readonly'
26447 instead of properties.
26449 (Constructor::IsDefault): Whether this is a default constructor.
26451 (Field::) use readonly public fields instead of properties also.
26453 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26454 track of static constructors; If none is used, turn on
26455 BeforeFieldInit in the TypeAttributes.
26457 * cs-parser.jay (opt_argument_list): now the return can be null
26458 for the cases where there are no arguments.
26460 (constructor_declarator): If there is no implicit `base' or
26461 `this', then invoke the default parent constructor.
26463 * modifiers.cs (MethodAttr): New static function maps a set of
26464 modifiers flags into a MethodAttributes enum
26465 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26466 MethodAttr, TypeAttr to represent the various mappings where the
26467 modifiers are used.
26468 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26470 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26472 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26475 * interface.cs (PopulateIndexer): Implemented the code generator
26476 for interface indexers.
26478 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26480 * interface.cs (InterfaceMemberBase): Now we track the new status
26483 (PopulateProperty): Implement property population. Woohoo! Got
26484 Methods and Properties going today.
26486 Removed all the properties for interfaces, and replaced them with
26487 `public readonly' fields.
26489 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26491 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26492 initialize their hashtables/arraylists only when they are needed
26493 instead of doing this always.
26495 * parameter.cs: Handle refs and out parameters.
26497 * cs-parser.jay: Use an ArrayList to construct the arguments
26498 instead of the ParameterCollection, and then cast that to a
26501 * parameter.cs: Drop the use of ParameterCollection and use
26502 instead arrays of Parameters.
26504 (GetParameterInfo): Use the Type, not the Name when resolving
26507 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26509 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26510 and instead use public readonly fields.
26512 * class.cs: Put back walking code for type containers.
26514 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26516 * class.cs (MakeConstant): Code to define constants.
26518 * rootcontext.cs (LookupType): New function. Used to locate types
26521 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26523 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26524 this System.Reflection code is. Kudos to Microsoft
26526 * typemanager.cs: Implement a type cache and avoid loading all
26527 types at boot time. Wrap in LookupType the internals. This made
26528 the compiler so much faster. Wow. I rule!
26530 * driver.cs: Make sure we always load mscorlib first (for
26531 debugging purposes, nothing really important).
26533 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26534 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26536 * rootcontext.cs: Lookup types on their namespace; Lookup types
26537 on namespaces that have been imported using the `using' keyword.
26539 * class.cs (TypeContainer::TypeAttr): Virtualize.
26540 (Class::TypeAttr): Return attributes suitable for this bad boy.
26541 (Struct::TypeAttr): ditto.
26542 Handle nested classes.
26543 (TypeContainer::) Remove all the type visiting code, it is now
26544 replaced with the rootcontext.cs code
26546 * rootcontext.cs (GetClassBases): Added support for structs.
26548 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26550 * interface.cs, statement.cs, class.cs, parameter.cs,
26551 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26552 Drop use of TypeRefs, and use strings instead.
26554 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26558 * class.cs (Struct::Struct): set the SEALED flags after
26559 checking the modifiers.
26560 (TypeContainer::TypeAttr): new property, returns the
26561 TypeAttributes for a class.
26563 * cs-parser.jay (type_list): Oops, list production was creating a
26564 new list of base types.
26566 * rootcontext.cs (StdLib): New property.
26567 (GetInterfaceTypeByName): returns an interface by type name, and
26568 encapsulates error handling here.
26569 (GetInterfaces): simplified.
26570 (ResolveTree): Encapsulated all the tree resolution here.
26571 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26574 * driver.cs: Add support for --nostdlib, to avoid loading the
26575 default assemblies.
26576 (Main): Do not put tree resolution here.
26578 * rootcontext.cs: Beginning of the class resolution.
26580 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26582 * rootcontext.cs: Provide better error reporting.
26584 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26586 * rootcontext.cs (CreateInterface): Handle the case where there
26587 are no parent interfaces.
26589 (CloseTypes): Routine to flush types at the end.
26590 (CreateInterface): Track types.
26591 (GetInterfaces): Returns an array of Types from the list of
26592 defined interfaces.
26594 * typemanager.c (AddUserType): Mechanism to track user types (puts
26595 the type on the global type hash, and allows us to close it at the
26598 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26600 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26601 RecordInterface instead.
26603 * cs-parser.jay: Updated to reflect changes above.
26605 * decl.cs (Definition): Keep track of the TypeBuilder type that
26606 represents this type here. Not sure we will use it in the long
26607 run, but wont hurt for now.
26609 * driver.cs: Smaller changes to accomodate the new code.
26611 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26614 * rootcontext.cs (CreateInterface): New method, used to create
26615 the System.TypeBuilder type for interfaces.
26616 (ResolveInterfaces): new entry point to resolve the interface
26618 (CodeGen): Property, used to keep track of the code generator.
26620 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26622 * cs-parser.jay: Add a second production for delegate_declaration
26625 (enum_body): Put an opt_comma here instead of putting it on
26626 enum_body or enum_member_declarations so we can handle trailing
26627 commas on enumeration members. Gets rid of a shift/reduce.
26629 (type_list): Need a COMMA in the middle.
26631 (indexer_declaration): Tell tokenizer to recognize get/set
26633 * Remove old targets.
26635 * Re-add the parser target.
26637 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26639 * cs-parser.jay: Add precendence rules for a number of operators
26640 ot reduce the number of shift/reduce conflicts in the grammar.
26642 2001-07-17 Miguel de Icaza <miguel@ximian.com>
26644 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
26647 Get rid of old crufty code.
26649 * rootcontext.cs: Use this to keep track of the parsed
26650 representation and the defined types available to the program.
26652 * gen-treedump.cs: adjust for new convention.
26654 * type.cs: Split out the type manager, and the assembly builder
26657 * typemanager.cs: the type manager will live here now.
26659 * cil-codegen.cs: And the code generator here.
26661 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
26663 * makefile: Fixed up for easy making.
26665 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26667 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
26670 (unary_expression): Expand pre_increment_expression and
26671 post_decrement_expression to reduce a shift/reduce.
26673 2001-07-11 Simon Cozens
26675 * cs-tokenizer.cs: Hex numbers should begin with a 0.
26677 Improve allow_keyword_as_indent name.
26679 2001-06-19 Miguel de Icaza <miguel@ximian.com>
26681 * Adjustments for Beta2.
26683 2001-06-13 Miguel de Icaza <miguel@ximian.com>
26685 * decl.cs: Added `Define' abstract method.
26686 (InTransit): new property, used to catch recursive definitions.
26688 * interface.cs: Implement `Define'.
26690 * modifiers.cs: Map Modifiers.constants to
26691 System.Reflection.TypeAttribute flags.
26693 * class.cs: Keep track of types and user-defined types.
26694 (BuilderInit): New method for creating an assembly
26695 (ResolveType): New function to launch the resolution process, only
26696 used by interfaces for now.
26698 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
26699 that are inserted into the name space.
26701 2001-06-08 Miguel de Icaza <miguel@ximian.com>
26703 * ARGH. I have screwed up my tree so many times due to the use of
26704 rsync rather than using CVS. Going to fix this at once.
26706 * driver.cs: Objetify driver. Load assemblies, use assemblies to
26709 2001-06-07 Miguel de Icaza <miguel@ximian.com>
26711 * Experiment successful: Use System.Type rather that our own
26714 2001-05-25 Miguel de Icaza <miguel@ximian.com>
26716 * cs-parser.jay: Removed nsAliases from here.
26718 Use new namespaces, handle `using XXX;'
26720 * namespace.cs: Reimplemented namespace handling, use a recursive
26721 definition of the class. Now we can keep track of using clauses
26722 and catch invalid using clauses.
26724 2001-05-24 Miguel de Icaza <miguel@ximian.com>
26726 * gen-treedump.cs: Adapted for all the renaming.
26728 * expression.cs (Expression): this class now has a Type property
26729 which returns an expression Type.
26731 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
26732 `Type', as this has a different meaning now in the base
26734 2001-05-22 Miguel de Icaza <miguel@ximian.com>
26736 * interface.cs, class.cs: Removed from all the sources the
26737 references to signature computation, as we can not do method
26738 signature computation during the parsing time, as we are not
26739 trying to solve at that point distinguishing:
26743 void a (NS.Blah x) {}
26746 Which depending on the context might be valid or not, as we do not
26747 know if Blah is the same thing as NS.Blah at that point.
26749 * Redid everything so the code uses TypeRefs now instead of
26750 Types. TypeRefs are just temporary type placeholders, that need
26751 to be resolved. They initially have a pointer to a string and the
26752 current scope in which they are used. This is used later by the
26753 compiler to resolve the reference to an actual Type.
26755 * DeclSpace is no longer a CIR.Type, and neither are
26756 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
26757 are all DeclSpaces, but no Types.
26759 * type.cs (TypeRefManager): This implements the TypeRef manager,
26760 which keeps track of all the types that need to be resolved after
26761 the parsing has finished.
26763 2001-05-13 Miguel de Icaza <miguel@ximian.com>
26765 * ARGH. We are going to have to store `foreach' as a class rather
26766 than resolving it, as we need to verify error 1579 after name
26767 resolution. *OR* we could keep a flag that says `This request to
26768 IEnumerator comes from a foreach statement' which we can then use
26769 to generate the error.
26771 2001-05-10 Miguel de Icaza <miguel@ximian.com>
26773 * class.cs (TypeContainer.AddMethod): we now add methods to the
26774 MethodGroup instead of the method hashtable.
26776 * expression.cs: Add MethodGroup abstraction, which gets us one
26777 step closer to the specification in the way we handle method
26780 * cs-parser.jay (primary_expression): qualified_identifier now
26781 tried to match up an identifier to a local variable reference or
26782 to a parameter reference.
26784 current_local_parameters is now a parser global variable that
26785 points to the current parameters for the block, used during name
26788 (property_declaration): Now creates an implicit `value' argument to
26791 2001-05-09 Miguel de Icaza <miguel@ximian.com>
26793 * parameter.cs: Do not use `param' arguments as part of the
26794 signature, per the spec.
26796 2001-05-08 Miguel de Icaza <miguel@ximian.com>
26798 * decl.cs: Base class for classes, structs and interfaces. This
26799 is the "Declaration Space"
26801 * cs-parser.jay: Use CheckDef for checking declaration errors
26802 instead of having one on each function.
26804 * class.cs: Factor out some code for handling error handling in
26805 accordance to the "Declarations" section in the "Basic Concepts"
26806 chapter in the ECMA C# spec.
26808 * interface.cs: Make all interface member classes derive from
26809 InterfaceMemberBase.
26811 2001-05-07 Miguel de Icaza <miguel@ximian.com>
26813 * Many things: all interfaces are parsed and generated in
26814 gen-treedump. Support for member variables, constructors,
26815 destructors, properties, constants is there.
26817 Beginning of the IL backend, but very little done, just there for
26820 2001-04-29 Miguel de Icaza <miguel@ximian.com>
26822 * cs-parser.jay: Fix labeled statement.
26824 * cs-tokenizer.cs (escape): Escape " and ' always.
26825 ref_line, ref_name: keep track of the line/filename as instructed
26826 by #line by the compiler.
26829 2001-04-27 Miguel de Icaza <miguel@ximian.com>
26831 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
26832 to match the values in System.CodeDOM.
26834 Divid renamed to Divide.
26836 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
26838 (Statements.set): remove.
26840 * System.CodeDOM/CodeCatchClause.cs: always have a valid
26843 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
26844 falseStatements always have valid values.
26846 * cs-parser.jay: Use System.CodeDOM now.