1 2007-04-27 Miguel de Icaza <miguel@novell.com>
3 * generic.cs (TypeManager.LambdaInfer): now this routine will
4 make only one inference from the list of lambda expression that
5 have not participated in inferring a type.
7 (TypeManager.InferTypeArguments): The logic that drives the type
8 inference in lambda expressions is now driven here.
10 2007-04-23 Miguel de Icaza <miguel@novell.com>
12 * generic.cs: Large update to LambdaInfer, this is merely an
13 update to start the lambda type inference. It is by no means
14 complete. It is currently merely able to build a sample program
15 (with no iteration for the type parameters).
17 2007-04-12 Duncan Mak <duncan@a-chinaman.com>
19 * cs-parser.jay (interface_method_declaration_body): Fixed typo.
21 2007-04-08 Marek Safar <marek.safar@gmail.com>
23 * cs-parser.jay, linq.cs: First select implementation (hacky).
25 * generic.cs (InferTypeArguments): Simplified.
27 2007-03-31 Marek Safar <marek.safar@gmail.com>
29 * generic.cs (InferTypeArguments): Restored validation check.
30 (InferTypeArguments): Move all logic to Compatible method for re-usability.
32 2007-03-25 Marek Safar <marek.safar@gmail.com>
34 * generic.cs (InferTypeArguments): Infer arguments before they are used
35 for compatibility check.
37 2007-03-15 Marek Safar <marek.safar@gmail.com>
39 * generic.cs (InflatedConstraints): Fixed the check order.
40 (TypeArguments.Resolve): Small optimization for generic parameters.
41 (InferTypeArguments): Add infering support for anonymous methods.
43 2007-03-15 Martin Baulig <martin@ximian.com>
48 (TypeParameter.HasConstructorConstraint): Removed.
49 (ConstraintChecker.HasDefaultConstructor): Removed the
50 `TypeBuilder' argument here; correctly check for the ctor
51 constraint on type parameters.
53 2007-03-15 Martin Baulig <martin@ximian.com>
58 (TypeParameter): Create a `MemberCache' here as well. Note that
59 we need to create this on-demand when it's actually used.
61 2007-03-10 Marek Safar <marek.safar@gmail.com>
63 * generic.cs (TypeArguments.Resolve): Avoid redundant checks.
65 2007-03-09 Raja R Harinath <rharinath@novell.com>
67 * cs-parser.jay (WHERE): Move before QUERY_FIRST_TOKEN. 'where'
68 is a valid keyword outside a linq expression too.
70 2007-03-03 Marek Safar <marek.safar@gmail.com>
72 * cs-parser.jay: Implemented basic linq grammar.
74 * linq.cs: New file for hosting query specific classes.
76 2007-02-26 Marek Safar <marek.safar@gmail.com>
78 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
80 2007-02-20 Marek Safar <marek.safar@gmail.com>
83 * cs-parser.jay: Anonymous container starts at constructor declaration
84 and not at block beginning because it has to be usable in constructor
87 2007-02-18 Marek Safar <marek.safar@gmail.com>
89 A fix for bug #80493 by Atsushi Enomoto
90 * cs-parser.jay: Ignore invalid attribute target.
92 2007-02-15 Miguel de Icaza <miguel@novell.com>
94 * Remove the call to SetExpression for lambda expressions, we do
97 Remove expression tracking code as its not needed.
99 2007-02-11 Miguel de Icaza <miguel@novell.com>
101 * cs-parser.jay (lambda_expression_body): when the body is an
102 expression add a statement of the form:
104 contextual-return expression.
106 Where `contextual-return' is similar to `return', the difference
107 being that if the delegate that the lambda will be converted to
108 has a void return type, it will check that the result is a
109 ExpressionStatement and the result is a plain ret (no return
110 values on the stack). If the return type of the delegate is of a
111 given type, this turns into a return with a value and does the
112 regular checking to check that the computed value can be
113 implicitly converted to the delegate return.
115 2007-01-30 Miguel de Icaza <miguel@novell.com>
117 * cs-parser.jay (anonymous_method_expression): move the
118 before/after productions to the start_anonymous and end_anonymous
119 methods so the code can be reused for lambda functions.
121 (lambda_expression_body): wrap expressions implicitly into a
124 (block): factor out the setup/teardown of parsing a block so we
125 can reuse that in lambda_expression_body
127 (lambda_expression): use new anonymous method helper methods.
129 2007-01-29 Miguel de Icaza <miguel@novell.com>
131 * cs-parser.jay: oob_stack make it static (am guessing that is why
132 we no longer initialize it anymore) and reuse it across
135 2007-01-28 Miguel de Icaza <miguel@novell.com>
137 * cs-parser.jay (open_parens): Introduce new non-terminal that
138 abstracts OPEN_PARENS and OPEN_PARENS_LAMBDA as the later can now
139 be returned in places where types are followed by identifiers
140 (this is expected in declaration, fixed, using, foreach and catch
143 Use open_parens in those places, keep OPEN_PARENS in the
146 cs-parser.jay: New grammar bits for parsing lambda expressions.
148 2007-01-28 Raja R Harinath <rharinath@novell.com>
150 Fix #80534, gtest-309.cs
151 * generic.cs (UnifyType): Rename from InferType. Make unification
152 of generic insts simpler and don't insist on inferring all generic
153 parameters in a single generic inst unification.
155 (InferGenericInstance): Remove.
156 Analysis and initial patch by David Mitchell <dmitchell@logos.com>.
158 2007-01-20 Marek Safar <marek.safar@gmail.com>
160 * cs-parser.jay: Better parameter error handling.
162 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
163 Raja R Harinath <rharinath@novell.com>
165 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
166 Note the order in which accessors are declared in the source.
168 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
170 * generic.cs (TypeParameter.FindMembers): Use the generic
171 constraints, not the constraints to check for methods (first fix
174 2006-12-30 Marek Safar <marek.safar@gmail.com>
176 * cs-parser.jay: Better syntax errors handling.
178 2006-11-21 Marek Safar <marek.safar@gmail.com>
180 * cs-parser.jay: Tiny change to work with mcs tokenizer.
182 * cs-tokenizer.cs: Remove after unification with mcs.
184 2006-10-28 Marek Safar <marek.safar@gmail.com>
187 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
190 2006-10-26 Marek Safar <marek.safar@gmail.com>
193 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
195 2006-10-25 Brian Crowell <brian@fluggo.com>
198 * generic.cs (CheckConstraints): Allow generic parameters with
199 inheritance constraints to satisfy reference type constraints.
201 2006-10-09 Martin Baulig <martin@ximian.com>
204 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
206 2006-09-25 Martin Baulig <martin@ximian.com>
208 * class.cs: Remove after unification with mcs source.
210 2006-09-24 Raja R Harinath <harinath@gmail.com>
212 * convert.cs: Remove after unification with mcs source.
214 2006-09-24 Marek Safar <marek.safar@seznam.cz>
216 * class.cs (MemberBase.VerifyClsCompliance): When method has type
217 parameters verify them as well.
219 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
220 the type parameter constraints.
221 (Generics.VerifyClsCompliance): Ditto.
223 2006-09-24 Marek Safar <marek.safar@seznam.cz>
225 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
226 for anonymous block with out argument.
228 2006-09-24 Marek Safar <marek.safar@seznam.cz>
230 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
231 not used private events only.
233 2006-09-23 Marek Safar <marek.safar@seznam.cz>
235 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
237 * cs-parser.jay: Parse correctly cast of default (T).
239 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
240 Store original type via EmptyConstantCast.
242 2006-09-22 Martin Baulig <martin@ximian.com>
244 * delegate.cs: Removed; this file is now shared with mcs.
246 * attribute.cs: Removed; this file is now shared with mcs.
248 2006-09-22 Martin Baulig <martin@ximian.com>
250 * ecore.cs: Removed; this file is now shared with mcs.
252 2006-09-21 Marek Safar <marek.safar@seznam.cz>
254 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
256 * ecore.cs (NullCast): Derives from NullConstant.
258 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
261 2006-09-21 Martin Baulig <martin@ximian.com>
263 * decl.cs: Removed; this file is now shared with mcs.
265 2006-09-21 Raja R Harinath <rharinath@novell.com>
267 * rootcontext.cs: Remove after unification with mcs source.
269 * report.cs: Remove after unification with mcs source.
270 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
272 (InitGenerics, CleanUpGenerics): Remove.
274 * support.cs: Remove after unification with mcs source.
276 2006-09-20 Raja R Harinath <rharinath@novell.com>
278 * codegen.cs: Remove after unification with mcs source.
280 2006-09-19 Martin Baulig <martin@ximian.com>
282 * expression.cs: Removed; this file is now shared with mcs.
284 2006-09-19 Martin Baulig <martin@ximian.com>
287 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
288 (TypeManager.DropGenericTypeArguments): Likewise.
289 (TypeManager.DropGenericMethodArguments): Likewise.
290 (TypeManager.GetTypeArguments): Likewise.
291 (TypeManager.HasGenericArguments): Likewise.
293 2006-09-19 Martin Baulig <martin@ximian.com>
295 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
297 2006-09-19 Martin Baulig <martin@ximian.com>
299 * typemanager.cs: Removed; this file is now shared with mcs.
301 2006-09-16 Raja R Harinath <rharinath@novell.com>
303 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
304 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
306 2006-09-16 Marek Safar <marek.safar@seznam.cz>
309 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
310 only if parent type is class.
311 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
314 2006-09-15 Marek Safar <marek.safar@seznam.cz>
317 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
319 * typemanager.cs(CSharpName): Converts NullType to null.
321 2006-09-15 Martin Baulig <martin@ximian.com>
323 * pending.cs: Removed; this file is now shared with mcs.
325 2006-09-15 Martin Baulig <martin@ximian.com>
327 * statement.cs: Removed; this file is now shared with mcs.
329 2006-09-15 Martin Baulig <martin@ximian.com>
331 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
333 * driver.cs: Removed the `--broken-cycles' argument.
335 2006-09-15 Martin Baulig <martin@ximian.com>
337 * namespace.cs: Removed; this file is now shared with mcs.
339 2006-09-15 Martin Baulig <martin@ximian.com>
341 * decl.cs (MemberName): Minor code cleanups.
343 2006-09-15 Martin Baulig <martin@ximian.com>
345 * parameter.cs: Removed; this file is now shared with mcs.
347 2006-09-15 Martin Baulig <martin@ximian.com>
349 * enum.cs: Removed; this file is now shared with mcs.
351 2006-09-15 Martin Baulig <martin@ximian.com>
353 * Makefile: Define `GMCS_SOURCE'.
355 * flowanalysis.cs: Removed; this file is now shared with mcs.
357 2006-09-15 Martin Baulig <martin@ximian.com>
359 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
360 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
361 doc.cs - they are now shared with mcs.
363 * gmcs.exe.sources: Include these files from ../mcs/.
365 2006-09-15 Martin Baulig <martin@ximian.com>
367 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
368 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
370 2006-09-14 Marek Safar <marek.safar@seznam.cz>
372 * assign.cs, ecore.cs, expression.cs: Share error message text.
373 * class.cs (FieldMember.Define): Check for variable of static type.
374 * decl.cs (check_type_parameter): Report correct type name.
375 * driver.cs (LoadAssembly): Uses error output for errors.
376 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
377 (TypeArguments.Resolve): Static class cannot be used as an argument.
378 * statement.cs (ResolveMeta): Constants cannot be generic types.
380 2006-09-12 Martin Baulig <martin@ximian.com>
382 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
384 * convert.cs (Convert.Array_To_IList): Moved here and correctly
385 implement it; fixes #79345.
387 2006-09-08 Marek Safar <marek.safar@seznam.cz>
389 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
391 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
393 * generic.cs: Improved error messages.
394 * typemanager.cs (RemoveGenericArity): Made public.
396 2006-09-08 Martin Baulig <martin@ximian.com>
398 * typemanager.cs (TypeManager.interlocked_type): New public field.
399 (TypeManager.int_interlocked_compare-exchange): New public field.
400 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
401 enumerator types here and call InitGenericCoreTypes().
402 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
403 after calling InitEnumUnderlyingTypes().
406 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
407 `classes_second_stage'.
409 2006-09-07 Marek Safar <marek.safar@seznam.cz>
411 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
413 * statement.cs (Block.Variables): Made public.
415 2006-09-07 Martin Baulig <martin@ximian.com>
418 (MainDriver): Revert r62663 from Marek; see #70506 for details.
420 2006-09-01 Martin Baulig <martin@ximian.com>
423 (TypeManager.IsIList): Also handle base classes and interfaces.
425 2006-09-01 Raja R Harinath <rharinath@novell.com>
428 * expression.cs (Invocation.MoreSpecific): Check for reference
431 2006-08-29 Miguel de Icaza <miguel@novell.com>
433 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
435 2006-08-17 Miguel de Icaza <miguel@novell.com>
437 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
438 #52019 and #79064, the use of the \uXXXX sequence in source code
439 to represent unicode characters.
441 2006-08-15 Marek Safar <marek.safar@seznam.cz>
443 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
445 * class.cs, ecore.cs, statement.cs: Merged to one error message.
447 2006-08-14 Raja R Harinath <rharinath@novell.com>
450 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
451 parameter too. This only avoids a parse error -- the semantic
452 error is caught elsewhere.
454 2006-08-13 Miguel de Icaza <miguel@novell.com>
456 * assign.cs: Catch attempts to assign to a method groups in += and
459 2006-08-13 Marek Safar <marek.safar@seznam.cz>
462 * cs-parser.jay: Don't destroy current array type by typeof of array's.
464 2006-08-12 Marek Safar <marek.safar@seznam.cz>
466 * cs-parser.jay: Check whether a constraint clause has already been
467 specified for type parameter.
468 * generic.cs (Constraints): Exposed location.
470 2006-08-12 Marek Safar <marek.safar@seznam.cz>
472 * class.cs (Method.Define): Issue a warning when generic method looks like
474 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
476 * report.cs: New warning number.
478 2006-08-09 Marek Safar <marek.safar@seznam.cz>
480 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
482 * decl.cs (MemberCache.FindMembers): When container is interface we need to
483 search all base interfaces as a member can be ambiguous.
484 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
485 Constructor member type filter.
486 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
487 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
488 reporting for returned memberinfos.
489 * report.cs: Updated.
490 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
491 version to work on all runtimes.
492 (TypeManager.RealMemberLookup): Removed members filtering.
494 2006-08-08 Raja R Harinath <rharinath@novell.com>
496 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
497 (PropertyExpr.EmitAssign): Likewise.
498 * expression.cs (Indirection.EmitAssign): Likewise.
499 (LocalVariableReference.EmitAssign): Likewise.
500 (ParameterReference.EmitAssign): Likewise.
501 (Invocation.EmitArguments): Likewise.
502 (ArrayAccess.EmitAssign): Likewise.
503 (IndexerAccess.EmitAssign): Likewise.
504 (This.EmitAssign): Likewise.
505 (ConditionalLogicalOperator.Emit): Likewise.
508 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
509 instead of ArrayList. If the hashtable has a LocalBuilder, don't
510 leave it in after returning it.
511 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
513 2006-08-06 Marek Safar <marek.safar@seznam.cz>
515 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
518 2006-08-05 Marek Safar <marek.safar@seznam.cz>
520 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
521 with different type names.
522 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
524 2006-08-03 Raja R Harinath <rharinath@novell.com>
526 Fix cs0146-3.cs and cs0146-4.cs.
527 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
528 enclosing types don't depend on the current type.
530 2006-08-02 Raja R Harinath <rharinath@novell.com>
533 * class.cs (TypeContainer.DoDefineMembers): Use
534 FindBaseMemberWithSameName on Parent, since we're interested in
535 whether we hide inherited members or not.
536 (FindBaseMemberWithSameName): Make slightly more robust.
539 * codegen.cs (IResolveContext.GenericDeclContainer): New.
540 (EmitContext): Implement new interface requirement.
541 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
542 * decl.cs (MemberCore): Likewise.
543 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
544 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
545 ec.GenericDeclContainer to check for generic parameters.
546 (SimpleName.DoSimpleNameResolve): Likewise.
547 * generic.cs (TypeParameter.DeclContainer): Remove override.
549 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
550 declspaces for doppelgangers too.
551 (UsingEntry): Implement IResolveContext.
552 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
553 'this' as the resolve context.
554 (LocalAliasEntry): Likewise.
556 Implement parts of #77403
557 * roottypes.cs (RootDeclSpace): New. Used to represent the
558 toplevel declaration space. Each namespace declaration introduces
559 a "partial" root declaretion space.
560 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
561 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
562 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
563 from 'current_namespace.SlaveDeclSpace'.
564 (namespace_declaration): Likewise.
565 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
566 check. It can't happen now.
567 * decl.cs (DeclSpace.LookupType): Likewise.
568 * driver.cs (MainDriver): Sanity check.
570 2006-08-01 Raja R Harinath <rharinath@novell.com>
572 * decl.cs (DeclSpace.FindNestedType): Remove.
573 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
574 LookupTypeContainer to get the container of the nested type.
575 * class.cs (TypeContainer.FindNestedType): Make non-override.
577 2006-07-31 Raja R Harinath <rharinath@novell.com>
579 * decl.cs (DeclSpace.PartialContainer): Move field from ...
580 * class.cs (TypeContainer.PartialContainer): ... here.
581 (TypeContainer.AddBasesForPart): New helper.
582 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
584 * cs-parser.jay (current_class): Convert to DeclSpace.
585 (struct_declaration, interface_declaration, class_declaration):
586 Use AddBasesForPart instead of .Bases directly.
587 * const.cs, iterators.cs: Update to changes.
589 2006-07-28 Raja R Harinath <rharinath@novell.com>
591 * class.cs (TypeContainer.AddMemberType): Rename from
593 (TypeContainer.AddMember): Rename from AddToMemberContainer.
594 (AddTypeContainer): New. Combine AddClassOrStruct and
596 (AddPartial): Update. Add 'is_partial' argument.
597 * roottypes.cs: Update to changes.
598 * cs-parser.jay (push_current_class): New helper for handling
599 current_container and current_class.
600 (struct_declaration, interface_declaration, class_declaration):
603 2006-07-26 Raja R Harinath <rharinath@novell.com>
605 * roottypes.cs: Rename from tree.cs.
607 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
608 * tree.cs (Tree, ITreeDump): Remove types.
609 * rootcontext.cs (tree, Tree): Remove fields.
610 (root, ToplevelTypes): New.
611 * *.cs: Update to rename.
613 * tree.cs (Tree.RecordDecl): Remove.
614 (RootTypes.AddToTypeContainer): Record the toplevel type in its
616 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
618 2006-07-23 Raja R Harinath <harinath@gmail.com>
620 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
621 DoFlowAnalysis and OmitStructFlowAnalysis here.
622 (ec.With): Rename from WithUnsafe and generalize.
623 (ec.WithCheckState): Remove. All users can be handled by 'With'.
624 (ec.WithFlowAnalyis): New.
625 * ecore.cs, expression.cs, statement.cs: Update.
627 2006-07-22 Raja R Harinath <harinath@gmail.com>
629 * statement.cs (Block.ResolveMeta): Simplify slightly.
631 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
632 multiple boolean fields. Convert InUnsafe, constant_check_state,
633 check_state to flags.
634 (CheckState, ConstantCheckState): Update.
635 (InUnsafe): New read-only property.
636 (FlagsHandle): Rename from CheckStateHandle and convert to handle
638 (WithUnsafe): New helper similar to WithCheckState.
639 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
640 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
642 2006-07-21 Raja R Harinath <rharinath@novell.com>
644 Make comparisons use the same IL irrespective of whether they're
645 in a 'checked' or 'unchecked' context: one of the issues in #78899
646 * codegen.cs (EmitContext.CheckState): Make read-only property.
647 (EmitContext.ConstantCheckState): Likewise.
648 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
649 helper that implement a save/restore stack for CheckState
650 values. This is the only way to change check-state.
651 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
652 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
653 (CheckedExpr.EmitBranchable): New forwarding method.
654 (UnCheckedExpr): Likewise.
655 * statement.cs (Block.ResolveMeta): Use WithCheckState.
656 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
657 (Checked.Resolve, checked.DoEmit): Likewise.
659 2006-07-21 Martin Baulig <martin@ximian.com>
661 * generic.cs (TypeManager.InferType): When inferring an array
662 type, also allow IList<T> and ICollection<T>. Fixes #78900.
664 2006-07-21 Martin Baulig <martin@ximian.com>
666 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
667 and allow IList`1 and all its base interfaces.
669 * convert.cs (Convert.ImplicitReferenceConversion): Allow
670 converting from an array-type of T to IList<T>.
672 2006-07-21 Martin Baulig <martin@ximian.com>
674 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
676 2006-07-20 Miguel de Icaza <miguel@novell.com>
678 * anonymous.cs: Cache the resolved anonymous delegate, and return
679 this so that the ResolveTopBlock is only triggered once, not
682 Currently we trigger ResolvetopBlock twice due to a first pass of
683 argument check compatibility, and a second pass that does the
686 2006-07-15 Marek Safar <marek.safar@seznam.cz>
688 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
690 * rootcontext.cs (Reset): Add helper_classes.
692 2006-07-15 Marek Safar <marek.safar@seznam.cz>
695 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
698 2006-07-13 Miguel de Icaza <miguel@novell.com>
700 * statement.cs (Lock): Handle expressions of type
701 TypeManager.null_type specially. Fixes #78770
703 2006-07-08 Marek Safar <marek.safar@seznam.cz>
705 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
708 2006-07-08 Marek Safar <marek.safar@seznam.cz>
710 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
711 for accessors as well.
712 * ecore.cs (EventExpr): Add AccessorTable.
714 2006-07-03 Martin Baulig <martin@ximian.com>
716 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
717 instances of value types.
719 * convert.cs (Convert.ExplicitConversion): Correctly handle
720 object->nullable conversions.
722 2006-07-01 Marek Safar <marek.safar@seznam.cz>
725 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
726 for CS0122 where appropriate.
727 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
729 (Filter): Assembly can be null in the case of top level attributes.
731 2006-06-28 Raja R Harinath <rharinath@novell.com>
734 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
735 no arguments, return 'false': nothing can be inferred.
737 2006-06-25 Marek Safar <marek.safar@seznam.cz>
741 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
742 is done at global level.
744 2006-06-24 Marek Safar <marek.safar@seznam.cz>
746 A fix for #77002, Implemented TypeForwarder support.
748 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
749 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
751 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
752 * typemanager.cs (): Add type_forwarder_attr_type.
754 2006-06-24 Marek Safar <marek.safar@seznam.cz>
756 * report.cs: Add CS0469 warning.
758 2006-06-22 Martin Baulig <martin@ximian.com>
761 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
762 for interfaces; fixes #78686, which is a modification of #78380
763 with interfaces instead of classes.
765 2006-06-21 Martin Baulig <martin@ximian.com>
767 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
768 the `try'-block, so we also report CS0016 etc. there.
770 2006-06-21 Martin Baulig <martin@ximian.com>
772 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
773 handle SetAssigned() and SetMemberIsUsed() for generic types;
776 2006-06-21 Martin Baulig <martin@ximian.com>
779 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
781 2006-06-21 Martin Baulig <martin@ximian.com>
783 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
784 also report CS1686 for parameters.
786 2006-06-21 Martin Baulig <martin@ximian.com>
788 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
789 instead of an error if the value is not implicitly convertible to
790 the switch types; fixes #77964.
792 2006-06-21 Raja R Harinath <rharinath@novell.com>
795 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
796 FieldBuilder is null.
799 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
800 'left' and 'right' before error-checking.
802 2006-06-19 Martin Baulig <martin@ximian.com>
805 (Convert.ImplicitConversionStandard): Cleanup and correctly
806 implement nullable conversions.
807 (Convert.ImplicitStandardConversionExists): Likewise.
808 (Convert.ExplicitConversion): Likewise.
810 2006-06-19 Martin Baulig <martin@ximian.com>
813 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
814 methods; make the ctors protected.
816 2006-06-19 Martin Baulig <martin@ximian.com>
818 Fixed #78380; added gtest-273.cs.
821 (Expression.ResolveAsBaseTerminal): Move the constraint checking
822 into ResolveAsTypeTerminal().
825 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
826 TypeManager.FindMembers() to check for the default ctor.
828 2006-06-18 Marek Safar <marek.safar@seznam.cz>
830 * generic.cs: Fixed NullableInfo accessibility.
832 2006-06-16 Martin Baulig <martin@ximian.com>
835 (Constraints.InflatedConstraints.inflate): Correctly inflate
836 generic types; fixes #78400.
838 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
840 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
842 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
843 (FieldExpr.DoResolve): likewise.
844 (PropertyExpr.InstanceResolve): likewise.
845 (EventExpr.InstanceResolve): likewise.
847 2006-06-15 Martin Baulig <martin@ximian.com>
850 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
851 argument; always allow a `null' label if true.
852 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
853 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
854 we have a `null' label and mark the new `null_target' label;
855 default to the `default' label.
856 (Switch.Resolve): Add support for nullable types. Fixes #78630.
858 2006-06-15 Martin Baulig <martin@ximian.com>
860 * class.cs (Operator.Define): Allow an implicit/explicit operator
861 to convert to/from a nullable value of the enclosing type.
863 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
864 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
867 (Convert.ImplicitStandardConversionExists): Add support for lifted
868 implicit/explicit conversions.
869 (Convert.ImplicitConversionStandard): Likewise.
871 2006-06-13 Martin Baulig <martin@ximian.com>
873 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
874 type arguments and create a ConstructedType if necessary. Fixes #78400.
876 2006-06-04 Marek Safar <marek.safar@seznam.cz>
878 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
879 attribute applicable tests for attribute argument.
881 2006-06-02 Raja R Harinath <rharinath@novell.com>
884 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
885 (Binary.OverloadResolve_PredefinedIntegral): New.
886 (Binary.OverloadResolve_PredefinedFloating): New.
887 (Binary.OverloadResolve_PredefinedString): New.
888 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
889 Follow the standard more closely, and treat numeric promotions in
890 terms of overload resolution.
891 (Binary.CheckShiftArguments): Simplify.
893 2006-06-01 Raja R Harinath <rharinath@novell.com>
895 * flowanalysis.cs (MyBitVector): Simplify representation.
896 (MyBitVector.Clone): Avoid allocating BitArray.
897 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
898 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
899 (*): Update. Change all references to MyBitVector.And and
900 MyBitVector.Or to &= and |=.
902 2006-05-31 Raja R Harinath <rharinath@novell.com>
904 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
905 Use bne.un instead of ceq+brfalse.
908 * typemanager.cs (IsUnmanagedType): Disallow generic types and
911 2006-05-29 Raja R Harinath <rharinath@novell.com>
914 * cs-parser.jay (formal_parameter_list): Extend the pattern below
915 to param arguments too.
917 2006-05-26 Miguel de Icaza <miguel@novell.com>
919 * cs-parser.jay: Catch another parsing form for arglist being
920 followed by other arguments. Fixes #78313.
922 2006-05-25 Raja R Harinath <rharinath@novell.com>
925 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
926 also when one of the operands is a null literal.
927 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
928 to improve clarity, and generate slightly better code.
930 2006-05-24 Raja R Harinath <rharinath@novell.com>
932 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
933 checking of out parameters to ...
934 (FlowBranchingToplevel.Merge): ... here.
935 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
936 set, propagate the origin upward, and only complain if there was
938 (FlowBranchingException.AddContinueOrigin): Likewise.
939 (FlowBranchingException.AddReturnOrigin): Likewise.
940 (FlowBranchingException.AddGotoOrigin): Likewise.
942 2006-05-23 Raja R Harinath <rharinath@novell.com>
944 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
945 unreachable, skip it.
946 (FlowBranchingException.Merge): Always propagate jumps, even if
947 the finally block renders subsequent code unreachable.
949 2006-05-18 Raja R Harinath <rharinath@novell.com>
952 * statement.cs (Goto.Resolve): Move responsibility for resolving
953 'goto' to FlowBranching.AddGotoOrigin.
954 (Goto.SetResolvedTarget): New. Callback to set the
955 LabeledStatement that's the target of the goto.
956 (Goto.DoEmit): Use Leave instead of Br when crossing an
957 unwind-protect boundary.
958 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
959 LookupLabel and adjust to new semantics.
960 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
961 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
962 Goto.SetResolvedTarget to update target.
963 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
964 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
965 AddBreakOrigin & co. Delay propagation until ...
966 (FlowBranchingException.Merge): ... this.
968 * statement.cs (Block.Resolve): Always depend on flow-branching to
969 determine unreachability. Kill workaround that originally emitted
970 only one statement after an "unreachable" label (see infloop in
973 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
974 This is still "wrong", but anything better would probably need a
975 multi-pass algorithm.
976 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
977 usage vector. Force current usage vector to be reachable, to
978 optimistically signify backward jumps.
979 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
981 (FlowBranchingLabeled.Merge): New. If no backward jump was
982 detected, return the original salted-away usage vector instead,
983 updated with appropriate changes. Print unreachable warning if
985 * statement.cs (Block.Resolve): Don't print unreachable warning on
988 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
990 * driver.cs: Pass filename without path to AssemblyBuilder's
991 AddResourceFile. Fixes bug #78407.
993 2006-05-17 Raja R Harinath <rharinath@novell.com>
995 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
996 * flowanalysis.cs (FlowBranchingLabeled): ... here.
997 (FlowBranching.MergeChild): Overwrite
998 reachability information from Labeled branchings too.
1000 2006-05-16 Raja R Harinath <rharinath@novell.com>
1002 * statement.cs (Goto.Resolve): Merge jump origins here ...
1003 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
1005 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
1006 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
1007 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
1008 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
1010 * statement.cs (Goto.Resolve): ... not here.
1011 (Goto.Emit): Remove CS1632 check.
1013 2006-05-14 Marek Safar <marek.safar@seznam.cz>
1015 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
1018 2006-05-11 Raja R Harinath <rharinath@novell.com>
1020 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
1021 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
1022 (FlowBranchingException.Label): Likewise.
1024 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
1026 (MyBitVector.Or): Use it to avoid losing information (Count).
1027 (FlowBranching.MergeOrigins): Likewise.
1029 * flowanalysis.cs (UsageVector.IsDirty): Remove.
1030 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
1031 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
1032 (UsageVector.ToString): Simplify.
1033 (UsageVector.MergeSiblings): Move here from ...
1034 (FlowBranching.Merge): ... here.
1035 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
1038 2006-05-10 Raja R Harinath <rharinath@novell.com>
1040 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
1041 null bitvector is treated as all-true.
1043 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
1044 (MyBitVector): Rationalize invariants. 'vector != null' implies
1045 that we have our own copy of the bitvector. Otherwise,
1046 'InheritsFrom == null' implies all inherited bits are true.
1048 2006-05-09 Marek Safar <marek.safar@seznam.cz>
1050 * statement.cs (LocalInfo): Add IsConstant.
1051 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
1052 local variable for constants.
1054 2006-05-09 Raja R Harinath <rharinath@novell.com>
1056 * flowanalysis.cs (MyBitVector.Empty): New.
1057 (MyBitVector): Don't allow InheritedFrom to be null.
1058 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
1059 (UsageVector, FlowBranching): Update to changes.
1061 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
1062 recursion. The 'Parent == null' condition isn't sufficient for
1064 (FlowBranching.AddBreakOrigin): Likewise.
1065 (FlowBranching.AddContinueOrigin): Likewise.
1066 (FlowBranching.AddReturnOrigin): Likewise.
1067 (FlowBranching.StealFinallyClauses): Likewise.
1068 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
1069 (FlowBranching.CheckOutParameters): Likewise.
1070 (FlowBranchingToplevel): Terminate all the above recursions here.
1071 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
1072 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
1074 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
1076 (FlowBranchingToplevel): New. Empty for now.
1077 (FlowBranching.MergeTopBlock): Update.
1078 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
1079 branching for the anonymous delegate.
1080 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
1082 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
1083 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
1084 information at the start of the merge. Reorganize.
1086 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1088 * class.cs (MethodData.Define): Method cannot implement interface accessor.
1090 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1092 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
1093 to newly introduced ctor.
1095 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
1096 message to one place.
1097 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
1100 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1102 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
1104 * ecore.cs (Expression.ResolveAsConstant): Updated.
1106 * statement.cs (ResolveMeta): Updated.
1108 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1110 * cs-parser.jay: __arglist cannot be used in initializer.
1112 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1115 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
1118 2006-05-05 Raja R Harinath <rharinath@novell.com>
1120 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
1121 (LabeledStatement): Add 'name' parameter.
1122 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
1123 (Block.AddLabel): Update to changes.
1124 * cs-parser.jay (labeled_statement): Likewise.
1126 * flowanalysis.cs (BranchingType.Labeled): New.
1127 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
1128 (FlowBranchingLabeled): New. Does nothing for now, but will
1129 eventually handle 'goto' flows.
1130 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
1131 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
1132 that's terminated ...
1133 (Block.Resolve): ... here.
1135 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
1136 (UsageVector.MergeFinallyOrigins): Likewise.
1137 (FlowBranching.InTryOrCatch): Likewise.
1138 (FlowBranching.AddFinallyVector): Likewise.
1139 (FlowBranchingException): Update to changes.
1142 * statement.cs (Return.Resolve): Move error checking to ...
1143 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
1144 (FlowBranchingException): Handle return origins like break and
1146 (FlowBranching.UsageVector.CheckOutParameters): Remove.
1148 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1151 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
1154 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1157 * class.cs (MethodData.Define): Do public accessor check only when method
1158 implements an interface.
1160 2006-05-04 Raja R Harinath <rharinath@novell.com>
1162 Remove special handling of 'break'
1163 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
1164 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
1165 (UsageVector.Break): Remove.
1166 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
1168 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
1170 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
1171 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1173 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1176 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1177 be the interface member.
1179 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1182 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1183 for emitting small (int) values.
1185 2006-05-03 Raja R Harinath <rharinath@novell.com>
1188 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1189 control-flow passes through the 'finally' after merging-in all the
1190 control-flows from 'try' and the 'catch' clauses.
1192 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1193 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1194 always true at the only non-recursive entry point.
1195 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1196 FlowBranchingBreakable.
1197 (FlowBranchingLoop): Remove.
1198 * statement.cs (Return.DoResolve): Update to changes.
1201 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1202 (FlowBranching.CreateBranching): Handle it: create a
1203 FlowBranchingContinuable.
1204 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1205 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1206 except that it handles the 'continue' command.
1207 (FlowBranching.UsageVector.MergeOrigins): Rename from
1209 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1210 except that it overrides AddContinueOrigin.
1211 (FlowBranchingException): Override AddContinueOrigin, similar to
1213 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1214 Create a new branching around the embedded statement.
1215 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1216 control flow after the embedded statement.
1217 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1219 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1220 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1221 FlowBranchingBreakable.
1222 (FlowBranchingSwitch): Remove.
1225 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1226 error reporting to ...
1227 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1228 Rename from 'AddBreakVector'. Add new location argument. Return
1229 a bool indicating whether the 'break' crosses an unwind-protect.
1230 (FlowBranchingException.AddBreakOrigin): Add.
1231 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1232 flowbranching after updating with the effects of the 'finally'
1234 (FlowBranchingBreakable): New common base class for
1235 FlowBranchingLoop and FlowBranchingSwitch.
1237 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1239 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1241 2006-05-02 Raja R Harinath <rharinath@novell.com>
1243 * statement.cs (Do.Resolve): If the loop is infinite, set the
1245 (While.Resolve, For.Resolve): Set a barrier after the embedded
1246 statement. There's no direct control flow that goes from the end
1247 of the embedded statement to the end of the loop.
1248 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1249 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1250 above ensure that the reachability is correctly computed.
1252 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1253 (UsageVector.MergeBreakOrigins): If the current path is
1254 unreachable, treat it as if all parameters/locals are initialized.
1255 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1256 infinite loops before merging-in break origins.
1258 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1259 (Reachability.Reachable): Split part into ...
1260 (Reachability.Unreachable): ... this. Simplify.
1261 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1263 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1264 (Reachability.SetThrowsSometimes): Likewise.
1265 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1266 TriState.Always, use corresponding property.
1267 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1268 (Block.Resolve): Likewise. Remove some redundant checks.
1270 2006-05-02 Raja R Harinath <harinath@gmail.com>
1272 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1273 (Reachability.Meet): Don't bother checking AlwaysThrows --
1274 barrier is always set.
1275 (FlowBranchingBlock.Merge): Likewise.
1277 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1279 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1280 defined, so it's references should also compile only for NET_2_0
1281 (as occurs in mcs version)
1283 2006-05-01 Raja R Harinath <harinath@gmail.com>
1285 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1286 checks for unreachable.
1288 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1291 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1293 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1294 whether field is really assigned.
1296 2006-04-30 Raja R Harinath <harinath@gmail.com>
1298 * flowanalysis.cs (Reachability): Make 4-argument constructor
1300 (Reachability.Meet): Rename from 'And'. Remove static variant.
1301 (Reachability.Always): Rename from the highly misleading
1302 'Reachability.Never'.
1303 (FlowBranching.Merge): Update to changes. Mark an impossible
1304 situation with a 'throw'.
1305 (*): Update to changes.
1307 2006-04-29 Raja R Harinath <harinath@gmail.com>
1309 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1311 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1312 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1313 (*): Update to changes.
1314 * statement.cs: Update to changes.
1316 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1319 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1321 2006-04-28 Raja R Harinath <harinath@gmail.com>
1323 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1326 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1327 argument to two arguments: an usage-vector and a bool. Move call
1328 to FlowBranching.Merge () ...
1329 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1331 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1332 handling of loop and switch reachability to ...
1333 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1335 2006-04-27 Raja R Harinath <harinath@gmail.com>
1337 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1338 handling to FlowBranchingLoop.InLoop.
1339 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1341 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1344 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1345 anonymous method is allowed from AnonymousContainer here.
1347 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1349 2006-04-24 Raja R Harinath <rharinath@novell.com>
1352 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1354 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1357 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1358 (DoubleConstant.Reduce): Ditto.
1360 2006-04-23 Raja R Harinath <rharinath@novell.com>
1362 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1363 Remove 'lvalue_right_side' argument. Move parts to ...
1364 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1365 (LocalVariable.DoResolveLValue): ... these.
1367 2006-04-21 Raja R Harinath <rharinath@novell.com>
1370 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1371 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1372 (LocalVariableReference.DoResolveBase): Use it to implement new
1374 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1375 (Argument.Resolve): Simplify. Move CS1510 check ...
1376 * ecore.cs (Expression.ResolveLValue): ... here.
1377 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1378 (PropertyExpr.DoResolveLValue): Likewise.
1379 (FieldExpr.Report_AssignToReadonly): Likewise.
1380 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1381 LValueMemberAccess or LValueMemberOutAccess on instance depending
1383 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1384 DoResolve as appropriate.
1386 2006-04-20 Raja R Harinath <rharinath@novell.com>
1389 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1390 implicit conversions on 'out' and 'ref' arguments.
1392 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1393 improve clarity. Remove dead code.
1396 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1397 (Catch.Resolve): Resolve VarBlock if it exists.
1399 2006-04-19 Miguel de Icaza <miguel@novell.com>
1401 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1402 twice, this was some residual code, the enumerator was emitted
1403 properly in the two branche of if later.
1407 Thanks to Martin for finding the source of the problem
1409 2006-04-19 Raja R Harinath <rharinath@novell.com>
1411 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1412 cast is never an lvalue.
1413 (Cast.DoResolve, Cast.ResolveRest): Combine.
1414 (Argument.Emit): Simplify slightly. Move 'Expr is
1415 IMemoryLocation' check ...
1416 (Argument.Resolve): ... here.
1417 (Argument.Error_LValueRequired): Remove. Inline into only user.
1419 Simplifications. Fix cs0191-2.cs
1420 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1421 CS1649 and CS1651 to ...
1422 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1423 the actual selection of the error code and message to a lookup
1424 table. Add a dummy return value to simplify callsites.
1425 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1426 readonly fields of other instances of the same type. Move CS0197
1428 * expression.cs (Argument.Resolve): ... here. Simplify code.
1429 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1430 resolution of an out or ref argument. The code simplification
1431 above uses this invariant.
1433 2006-04-18 Raja R Harinath <rharinath@novell.com>
1435 Possibly fix #77752. Fix cs1690-[4-7].cs.
1436 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1437 CheckMarshallByRefAccess. Drop parameter.
1438 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1440 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1442 * report.cs (AllWarnings): Add CS1690.
1443 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1445 (LocalVariableReference.DoResolveBase): Update.
1447 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1449 * class.cs (MethodOrOperator): Moved common parts from method class.
1450 detect obsolete attributes.
1451 (Method.Define): Simplified as it reuses code from base.
1452 (Constructor.ValidAttributeTargets): Fixed issue found during
1454 (Destructor.ValidAttributeTargets): Fixed issue found during
1456 (Operator): Finished refactoring set off by #78020. Operator class is now
1457 ordinary method class.
1459 * anonymous.cs: Updated.
1461 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1463 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1465 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1467 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1468 detect obsolete attributes.
1469 (Method.CreateEmitContext): Moved to MethodOrOperator.
1471 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1474 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1475 customized exception to make crash detection easier.
1476 (MethodOrOperator): Started to work on new base class for methods and
1478 (Method): Derives from MethodOrOperator.
1479 (Constructor.Emit): Emits its own attributes.
1480 (AbstractPropertyEventMethod.Emit): Ditto.
1481 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1483 (Operator.Emit): It's temporary more tricky than should be.
1485 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1487 * report.cs (InternalErrorException): Add ctor with inner exception.
1489 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1492 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1495 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1498 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1501 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1503 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1504 attribute is present and Guid not.
1505 (Interface.ApplyAttributeBuilder): Ditto.
1507 * attribute.cs: Add error message.
1509 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1513 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1514 sources (it's composite) so hold them in extra array as they are used in
1515 Emit phase only. It worked in the previous versions by mistake.
1516 (Attribute.Emit): Emit attribute for more owners when exist.
1518 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1519 it has now different behaviour.
1521 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1523 * constant.cs (Constant.IsDefaultInitializer): New method.
1525 * class.cs: Updated.
1527 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1528 re-initialize default values. It saves KBs almost for every assembly.
1529 Thanks Zoltan for the idea.
1530 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1531 (ArrayCreation.DoResolve): Resolve only once.
1532 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1533 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1535 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1537 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1540 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1542 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1543 in an embedded statement too.
1545 2006-04-01 Raja R Harinath <rharinath@novell.com>
1548 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1552 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1555 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1556 arguments before checking whether a type is reflected or not.
1559 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1560 definition doesn't take part in overload resolution.
1561 (Invocation.IsParamsMethodApplicable): Likewise.
1562 (Invocation.OverloadResolve): When replacing a reflected override
1563 method with its base definition, ensure that type arguments are
1566 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1570 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1573 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1575 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1577 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1580 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1581 LocalTemporary change.
1583 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1585 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1586 initializers optimization.
1587 (ClassOrStruct.TypeAttr): Moved from modifiers.
1588 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1589 (FieldBase.ResolveInitializer): Resolves initializer.
1590 (FieldBase.HasDefaultInitializer): New property.
1592 * cs-parser.jay: Removed message.
1594 * expression.cs (CompilerGeneratedThis): New specialization.
1596 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1598 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1600 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1602 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1604 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1605 be now EnumConstants only.
1607 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1609 * attribute.cs, driver.cs: Reset more caches.
1611 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1613 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1615 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1617 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1618 for easier reuse. Updated all overrides.
1619 (IntegralConstant): New base class for all integral constants.
1620 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1621 of the constant range, report custom error.
1622 (UIntConstant.Reduce): Fixed uint conversion.
1624 * ecore.cs, literal.cs: Reduce updates.
1626 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1630 * class.cs (Constructor.Define): Removed extra if for default ctors.
1631 A patch from Atsushi Enomoto.
1633 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1635 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1636 GetAttributableValue.
1638 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1641 * convert.cs (ImplicitConversionRequired): Error message moved to
1644 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1645 automatic implicit conversion of an output value.
1646 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1648 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1650 (TypeOf.GetAttributableValue): Add extra handling for object type.
1652 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1653 special error message.
1655 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1657 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1659 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1660 compatible with MS runtime.
1662 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1664 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1665 attribute arguments here.
1667 * class.cs (Indexer.Define): The check was moved to attribute class.
1669 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1671 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1673 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1675 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1677 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1680 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1682 * doc-bootstrap.cs : fix build.
1684 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1686 * expression.cs (StringConcat.Append): Issue a warning when empty string
1689 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1691 * assign.cs (CompoundAssign.ResolveSource): Removed.
1693 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1696 * class.cs (TypeContainer.FindMethods): Removed.
1697 (TypeContainer.CheckMemberUsage): Made static.
1699 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1701 * constant.cs (CheckRange): Removed unused type argument.
1702 (CheckUnsigned): Removed unused type argument.
1704 * cs-parser.jay: Updated after MemberAccess clean up.
1705 Uses Length for empty string test.
1707 * cs-tokenizer.cs: Uses Length for empty string test.
1708 (IsCastToken): Made static.
1709 (is_hex): Made static.
1710 (real_type_suffix): Made static.
1712 * decl.cs (SetupCache): Made static.
1713 (OnGenerateDocComment): Removed unused ds argument.
1715 * delegate.cs (VerifyDelegate): Removed unused argument.
1717 * doc.cs: Uses Length for empty string test.
1719 * driver.cs: Uses Length for empty string test.
1721 * enum.cs (IsValidEnumType): Made static
1723 * expression.cs (EnumLiftUp): Removed unused argument.
1724 (ResolveMethodGroup): Ditto.
1725 (BetterConversion): Ditto.
1726 (GetVarargsTypes): Ditto.
1727 (UpdateIndices): Ditto.
1728 (ValidateInitializers): Ditto.
1729 (MemberAccess.ctor): Ditto.
1730 (GetIndexersForType): Ditto.
1732 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1734 * iterators.cs: Updated after MemberAccess clean up.
1736 * location.cs: Uses Length for empty string test.
1738 * namespace.cs: Uses Length for empty string test.
1740 * report.cs (CheckWarningCode): Made static.
1742 * statement.cs (LabeledStatement): Removed unused argument.
1744 * typemanager.cs (FilterNone): Removed.
1746 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1748 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1751 * class.cs: Updated.
1753 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1755 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1757 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1761 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1763 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1764 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1765 Add more error reporting; Fixed issue with params.
1767 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1769 * cs-parser.jay: AnonymousMethod requires host container.
1771 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1773 2006-03-18 Raja R Harinath <harinath@gmail.com>
1775 * class.cs: Change 'TypeContainer ds' constructor argument to
1776 'DeclSpace parent'. Some classes were missed below due to
1777 different naming convention.
1779 * class.cs (MemberCore.Parent): Delete. This makes the
1780 ParentContainer changes below enforceable by the compiler.
1782 Treat pointers to enclosing declaration space as 'DeclSpace', not
1784 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
1785 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
1787 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
1789 (Block.AddThisVariable): Likewise.
1790 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
1791 (AbstractPropertyEventMethod.Emit): Likewise.
1792 (AbstractPropertyEventMethod.EmitMethod): Likewise.
1793 (GetMethod.Define, SetMethod.Define): Likewise.
1794 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
1795 (DelegateMethod.EmitMethod): Likewise.
1797 Fix regression test-partial-13.cs.
1798 Rationalize use of PartialContainer. Ensure that the partial
1799 class semantics can be tied to type-correctness, i.e., any
1800 violation will cause a compile error.
1801 * class.cs, const.cs: Access all fields that belong to class
1802 TypeContainer via ParentContainer. Arguments of EmitContexts and
1803 Resolve()-like functions still use 'Parent'.
1805 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
1806 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
1807 (PropertyMethod.CheckModifiers): Remove unused argument.
1808 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
1811 2006-03-28 Raja R Harinath <rharinath@novell.com>
1813 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
1815 2006-03-17 Raja R Harinath <harinath@gmail.com>
1817 Make semantics of PartialContainer simpler.
1818 * decl.cs (DeclSpace.IsPartial): Remove.
1819 * class.cs (TypeContainer.IsPartial): Likewise.
1820 (TypeContainer..ctor): Set PartialContainer to point to self.
1821 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
1822 (TypeContainer.FindNestedType): Likewise.
1823 (MemberCore.ParentContainer): Simplify. Remove deprecation.
1825 2006-03-17 Marek Safar <marek.safar@seznam.cz>
1827 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
1829 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1831 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
1834 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1836 * class.cs (Operator.Define): An error for base conversion was not
1839 2006-03-13 Marek Safar <marek.safar@seznam.cz>
1841 A fix for #77593, #77574.
1843 * class.cs (MethodCore.CheckBase): Another if for operator.
1845 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1849 * expression.cs (VerifyArgumentsCompat): Reverted to double error
1850 reporting, it's more tricky than I thought.
1852 2006-03-09 Marek Safar <marek.safar@seznam.cz>
1854 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
1857 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
1858 (DelegateCreation.ImplicitStandardConversionExists): New method for just
1861 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
1864 2006-03-04 Marek Safar <marek.safar@seznam.cz>
1868 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
1869 (Event.Define): ditto
1870 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
1872 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
1873 Removed redundant code and set NewSlot for Invoke method too.
1875 * parameter.cs (Parameters.ctor): Add custom, type ctor.
1876 (Parameters.MergeGenerated): New method. Use this method when you merge
1877 compiler generated argument with user arguments.
1879 2006-03-03 Marek Safar <marek.safar@seznam.cz>
1881 * attribute.cs (ResolveAsTypeTerminal): Removed.
1883 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
1884 specialization for predefined types; 30% speed up.
1885 Finally placed obsolete check to right place.
1886 (Expression.ResolveType): Removed.
1888 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
1889 Updated after ResolveType was removed.
1891 * expression.cs (Cast.ctor): Check void cast.
1892 (Binary.ResolveAsTypeTerminal): Is never type.
1893 (Conditional.ResolveAsTypeTerminal): Is never type.
1895 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
1897 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1899 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
1901 2006-03-23 Martin Baulig <martin@ximian.com>
1903 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
1904 type check if either of the types is an open generic type.
1906 2006-03-23 Martin Baulig <martin@ximian.com>
1909 (Convert.ExplicitTypeParameterConversion): New method; implement
1910 explicit type parameter conversions.
1912 2006-03-23 Martin Baulig <martin@ximian.com>
1914 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
1915 blindly allow all conversions if we do not have any constraints.
1917 2006-02-27 Marek Safar <marek.safar@seznam.cz>
1919 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
1920 these two separated members to simplify the code.
1921 (Attribute.Resolve): Refactored to use new fields and methods.
1922 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
1923 implemented obsolete attribute checking.
1924 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
1925 implemented obsolete checking again. It look line never ending quest ;-)
1926 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
1928 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
1930 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
1932 *class.cs (Property.Define): Add RegisterProperty call.
1934 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
1935 argument groups (only 2).
1937 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
1938 encoding expression to arguments.
1939 (Expression.ExprClassToResolveFlags): Just turned to property.
1941 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
1942 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
1943 optimized as well as implemented support for zero-length attributes.
1945 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
1946 Add caching of PropertyInfo's.
1948 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1950 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
1951 error multiple times.
1953 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1955 New partial class implementation.
1956 A fix for #77027, #77029, #77403
1958 * attribute.cs (Attributable): Made attributes protected.
1960 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
1961 the replacements of ClassPart and PartialContainer.
1962 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
1963 (TypeContainer.AddInterface): Ditto.
1964 (TypeContainer.AddPartial): The main method for partial classes. It checks
1965 for errors and merges ModFlags and attributes. At the end class is added to
1967 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
1969 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
1970 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
1971 from the rest of partial classes.
1972 (TypeContainer.GetClassBases): Simplified.
1973 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
1975 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
1976 (TypeContainer.HasExplicitLayout): Uses Flags now.
1977 (PartialContainer): Removed.
1978 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
1979 (StaticClass): Was merged with Class.
1980 (Class.GetClassBases): class and static class bases are verified here.
1981 (Class.TypeAttr): Added static attributes when class is static.
1982 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
1983 (MemberBase): In some cases we need to call parent container for partial
1984 class. It should be eliminated but it's not easy now.
1986 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
1988 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
1989 partial classed to accumulate class comments.
1990 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
1992 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
1994 * driver.cs (MainDriver): Tree.GetDecl was removed.
1996 * modifiers.cs (Modifiers): Add partial modifier.
1998 * tree.cs (Tree.decl): Removed.
1999 (RootTypes): Started to use this class more often for root types
2002 2006-03-23 Raja R Harinath <rharinath@novell.com>
2004 * generic.cs (TypeParameter.UpdateConstraints): Update
2005 'constraints' if null.
2007 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2011 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
2012 external interface does not have an attribute.
2014 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2016 Another prerequisites for new partial classs implementation.
2018 * attribute.cs (Attribute.Equal): Implemented.
2019 (Attribute.Emit): Changed as attributes can be applied more than twice.
2020 (Attributes.Emit): Check for duplicate attributes here.
2022 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
2023 as a parameter, clean-up.
2025 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2029 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
2030 contains obsolete attribute check which can in some cases look for base
2031 type of current class which is not initialized yet.
2032 (TypeContainer.BaseType): Replacement of ptype.
2034 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
2036 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2038 First of prerequisites for new partial classs implemention.
2040 * attribute.cs (Attributable): Extended by ResolveContext;
2041 Attributes finally have correct context for resolving in all cases.
2042 (AttachTo): Attribute owner is assigned here.
2044 * codegen.cs (IResolveContext): Introduce new interface to hold
2045 all information needed in resolving phase.
2046 (EmitContext): Implements IResolveContext; more clean-up needed here.
2048 * decl.cs (MemberCore): Implemented IResolveContext.
2050 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
2051 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
2052 parameter.cs, statement.cs, tree.cs, typemanager.cs:
2053 Refactored to use new IResolveContext instead of EmitContext; cleanup
2055 2006-03-22 Raja R Harinath <rharinath@novell.com>
2057 Support ParameterDefaultValueAttribute in gmcs. Also applied to
2058 mcs to keep code differences small.
2059 * attribute.cs (Attribute.GetParameterDefaultValue): New.
2060 * typemanager.cs (parameter_default_value_attribute_type): New.
2061 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
2064 2006-03-22 Martin Baulig <martin@ximian.com>
2067 (Nullable.NullableLiteral): Derive from `NullLiteral'.
2070 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
2071 instead of the normal `NullLiteral'.
2073 2006-03-21 Martin Baulig <martin@ximian.com>
2076 * generic.cs (TypeManager.InferType): If `pt' is a generic
2077 parameter, don't check whether `pt == at'.
2079 2006-03-20 Raja R Harinath <rharinath@novell.com>
2082 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
2083 (TypeParameter.Resolve): Update to change.
2084 (ConstraintChecker.CheckConstraints): Resolve type-argument
2085 constraints before use.
2087 2006-03-16 Martin Baulig <martin@ximian.com>
2090 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
2091 and don't have any instance constructors, also lookup in the base class.
2092 (TypeManager.IsNullableValueType): New public method.
2094 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
2095 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
2096 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
2098 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
2099 instead of just TypeManager.IsNullableType() to determine whether
2100 a lifted operator exists.
2101 (UnaryMutator.DoResolve): Likewise.
2102 (Conditional.DoResolve): Likewise.
2103 (Binary.DoResolve): A lifted operator only exists if both operands
2104 are valuetypes and at least one of them is a nullable type.
2106 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
2108 * iterator.cs : yield break is allowed in try statement which has
2109 catch clauses. Fixed bug #77767.
2111 2006-03-12 Martin Baulig <martin@ximian.com>
2113 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
2114 private IsSignatureEqual() to compare types; see the comment in
2115 that method; fixes #77674.
2117 2006-03-10 Raja R Harinath <rharinath@novell.com>
2119 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
2120 (Expression.ResolveAsTypeTerminal): Likewise.
2121 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
2122 * expression.cs, generic.cs, iterators.cs: Likewise.
2123 * parameter.cs, statement.cs, typemanager.cs: Likewise.
2125 2006-03-09 Martin Baulig <martin@ximian.com>
2127 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
2128 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
2130 2006-03-09 Martin Baulig <martin@ximian.com>
2132 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
2133 `prepared' flag is set.
2135 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
2136 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
2137 issues; see gtest-254.cs.
2139 2006-03-07 Martin Baulig <martin@ximian.com>
2141 * generic.cs (TypeManager.InferType): Allow infering
2142 `IEnumerable<T>' with an array of T; see gtest-251.cs.
2144 2006-03-06 Martin Baulig <martin@ximian.com>
2147 (TypeManager.InferType): Fix gtest-250.cs.
2150 (TypeManager.IsSubclassOf): Also check the base class.
2153 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
2156 2006-03-01 Raja R Harinath <rharinath@novell.com>
2159 * expression.cs (ParameterReference.DoResolveBase): Change return
2161 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
2165 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
2168 * typemanager.cs (GetFullNameSignature): Don't nullref on
2169 protected accessors.
2171 2006-02-16 Martin Baulig <martin@ximian.com>
2174 (TypeManager.GetGenericFieldDefinition): New public method; use it
2175 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2177 2006-02-14 Martin Baulig <martin@ximian.com>
2179 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2181 2006-02-14 Martin Baulig <martin@ximian.com>
2184 (TypeManager.DropGenericMethodArguments): New public method; don't
2185 use GetGenericMethodDefinition() on something which is not a
2188 2006-02-14 Martin Baulig <martin@ximian.com>
2191 (ConstraintChecker.CheckConstraints): If a type parameter has the
2192 `struct' constraint, the type must be a non-nullable valuetype.
2194 2006-02-10 Martin Baulig <martin@ximian.com>
2197 (TypeManager.IsOverride): Make this work for instantiated methods
2198 in a generic class; fixes #77509.
2199 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2200 rather than calling it directly; fixes #77488.
2202 2006-02-08 Martin Baulig <martin@ximian.com>
2204 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2205 reporting into CheckConstraint() so we can use the correctly
2208 2006-02-08 Martin Baulig <martin@ximian.com>
2210 * expression.cs (BaseAccess): Add support for generic methods.
2212 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2213 the new MethodGroupExpr.
2215 2006-02-07 Martin Baulig <martin@ximian.com>
2217 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2218 also reference types; fixes #77483.
2220 2006-02-07 Martin Baulig <martin@ximian.com>
2223 (TypeManager.IsGenericMethod): We now return whether something is
2224 an instantiated generic method (and not a generic method def).
2225 (TypeManager.IsGenericMethodDefinition): New public method.
2228 (TypeManager.CSharpSignature): Only include type arguments for
2229 "real" generic methods, not for any instantiated method.
2230 (TypeManager.GetMethodName): Likewise, but also allow generic
2231 method definitions here.
2233 2006-02-06 Miguel de Icaza <miguel@novell.com>
2235 * codegen.cs (EmitScopeInitFromBlock): check here the
2236 capture_context, there is no need to make two calls to the
2239 * anonymous.cs: Add some debugging messages that might help me
2240 track other instances of this problem in the future (the
2241 regression of test 467).
2243 * cs-parser.jay: track the variable block, as we need to initalize
2244 any captured variables declared in this block for the "catch"
2245 portion of the "Try" statement.
2247 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2248 scope initialization for captured variables.
2250 Also, move the emit for the variables after the block location has
2253 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2255 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2257 2006-02-06 Martin Baulig <martin@ximian.com>
2259 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2260 `TypeManager.value_type' as parent type to
2261 ModuleBuilder.DefineType(). Fixes #77358.
2263 2006-02-02 Miguel de Icaza <miguel@novell.com>
2265 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2266 commit yesterday, the initialization for the roots is necessary.
2267 What is not necessary is the scope activation.
2269 2006-02-02 Raja R Harinath <rharinath@novell.com>
2271 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2272 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2274 (Argument.Resolve): Remove CS0206 checks.
2276 2006-02-01 Miguel de Icaza <miguel@novell.com>
2278 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2279 scopes for all the roots, the scopes will now be emitted when the
2280 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2282 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2283 code. This reduces a lot of existing cruft.
2285 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2286 that the ScopeInfo is generated as we enter the scope, not at the
2287 time of use, which is what we used to do before.
2289 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2290 every time a Block is about to be emitted if we have a
2293 2006-02-01 Raja R Harinath <rharinath@novell.com>
2295 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2296 attribute for mscorlib too.
2298 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2300 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2302 * typemanager.cs (cons_param_array_attribute): Make private.
2303 (Reset): Set it to null.
2304 (InitCoreHelpers): Don't initialize it.
2305 (ConsParamArrayAttribute): New. Initialize it as needed.
2306 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2308 2006-01-31 Miguel de Icaza <miguel@novell.com>
2310 * expression.cs: There might be errors reported during the
2311 selection of applicable methods. If there are errors, do not
2312 continue execution as it will lead the compiler to crash.
2314 2006-01-30 Miguel de Icaza <miguel@novell.com>
2316 * expression.cs: Member access is not allowed on anonymous
2317 methods. Fixes #77402.
2319 2006-01-30 Raja R Harinath <rharinath@novell.com>
2322 * cs-parser.jay (VariableDeclaration): Don't set
2323 current_array_type to null.
2324 (field_declaration, event_declaration, declaration_statement):
2325 Set it to null here.
2327 2006-01-29 Raja R Harinath <harinath@gmail.com>
2330 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2332 2006-01-28 Raja R Harinath <harinath@gmail.com>
2334 * typemanager.cs (GenericParameterPosition): New.
2337 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2339 * doc.cs : To process "include" elements, first we should create
2340 another list than XmlNodeList, because it could result in node
2341 removal, which could result in that the XmlNodeList gives up
2344 2006-01-25 Miguel de Icaza <miguel@novell.com>
2346 * expression.cs: Introduce an error report that we were not
2347 catching before. Gonzalo ran into it.
2349 2006-01-23 Miguel de Icaza <miguel@novell.com>
2351 A fix for bug: #76957
2353 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2354 ComputeMethodHost before creating the method, this is a new
2357 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2358 that this method references (RegisterScope). The actual scope
2359 where the method is hosted is computed with the ComputeMethodHost
2360 before we create the method.
2362 Moved the Deepest routine here.
2364 (AnonymousContainer.ComputeMethodHost): New routine used to
2365 compute the proper ScopeInfo that will host the anonymous method.
2367 (ScopeInfo): Deal with multiple roots. The problem was that we
2368 did not have a unique root where all ScopeInfos could be hanged
2369 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2372 Remove AdjustMethodScope which is now computed at the end. Remove
2373 LinkScope which did a partial link, instead link all ScopeInfos
2374 before code generation from the new "LinkScopes" routine.
2376 Simplify all the Add* routines as they no longer need to maintain
2377 the tree, they just need to record that they are using variables
2380 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2381 routines to produce the forest of ScopeInfo trees.
2383 * class.cs (TypeContainer.AppendMethod): This is just like
2384 AddMethod, but ensures that an interface implementation method
2385 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2386 methods, but at the end.
2388 We use this functionality to ensure that the generated MoveNext
2389 method in the iterator class is resolved/emitted before the
2390 enumerator methods created.
2392 This is required because the MoveNext method computes the right
2393 ScopeInfo for the method. And the other methods will eventually
2394 need to resolve and fetch information computed from the anonymous
2398 2006-01-23 Raja R Harinath <rharinath@novell.com>
2400 Improve implementation of section 14.4.2.2 (Better function member).
2401 * expression.cs (Invocation.MoreSpecific): Compare all type
2402 arguments before deciding if one type is more specific than
2403 another. Handle array types too. Return the more specific type.
2404 (Invocation.BetterFunction): Add more tie-breaking rules from
2405 section 14.4.2.2. Perform "more specific" check after
2406 other tie-breaking rules. Compare all parameter types before
2407 choosing the "more specific" method.
2409 2006-01-21 Raja R Harinath <harinath@gmail.com>
2410 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2413 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2415 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2416 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2418 2006-01-18 Martin Baulig <martin@ximian.com>
2420 * class.cs (TypeContainer.AddToMemberContainer): Use
2421 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2424 2006-01-18 Martin Baulig <martin@ximian.com>
2426 Fix #76417: a generic class may now have methods which may unify
2427 for some type parameter substitutions.
2429 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2430 for methods which may unify anymore.
2432 * expression.cs (Invocation.MoreSpecific): New private static
2433 method; checks whether one method is more specific than another
2434 according to 14.4.2.2 of the spec.
2435 (Invocation.BetterFunction): Implement the tie-breaking rules from
2436 14.4.2.2 of the spec: if two methods unify for some type parameter
2437 substitution, we need to pick the more specific one.
2439 2006-01-18 Raja R Harinath <rharinath@novell.com>
2441 Fix #76656, cs0231-2.cs.
2442 * cs-parser.jay (formal_parameter_list): Make error case catch
2444 (parenthesized_expression_0): Add CS1026 check.
2445 (invocation_expression): Remove unused { $$ = lexer.Location }.
2447 2006-01-17 Raja R Harinath <rharinath@novell.com>
2450 * cs-parser.jay (statement_expression): Don't list out the
2451 individual statement-expressions. Convert syntax error into
2454 2006-01-16 Raja R Harinath <rharinath@novell.com>
2457 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2458 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2459 CheckIntermediateModification.
2460 (FieldExpr.DoResolve): Add new two-argument version that
2461 allows us to resolve the InstanceExpression as an lvalue.
2462 The one-argument variant is now just a wrapper.
2463 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2464 Resolve the lhs as an lvalue if the it has a value type.
2465 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2466 from Assign.DoResolve.
2467 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2468 resolved as an lvalue.
2469 (PropertyExpr.DoResolve): Update.
2470 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2471 has a value type. Move CS1612 check here from
2472 CheckIntermediateModification.
2473 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2474 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2475 'right_side' of a ResolveLValue on an 'out' argument.
2476 (EmptyExpression.LValueMemberAccess): New. Used as the
2477 'right_side' of a propagated ResolveLValue on a value type.
2478 (LocalVariableReference.DoResolveBase): Recognize
2479 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2481 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2482 EmptyExpression.Null.
2484 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2486 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2487 Type.IsGenericParameter(). Fixed bug #77183.
2488 * doc.cs : it is now identical to doc.cs in mcs.
2490 2006-01-16 Martin Baulig <martin@ximian.com>
2492 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2494 2006-01-16 Martin Baulig <martin@ximian.com>
2496 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2497 ctors; fixes #77250.
2499 2006-01-12 Miguel de Icaza <miguel@novell.com>
2501 This fixes the problem where we used ldfld instead of ldflda to
2502 load the "THIS" pointer on captured parameters, when THIS is a
2503 value type. See bug #77205.
2505 * iterators.cs (CapturedThisReference.Emit): Pass false to
2506 EmitThis (we do not need the address).
2508 * codegen.cs (EmitThis): it needs to know whether we need the
2509 address of `this' or not. This is used by value types.
2511 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2512 every other call passes false.
2514 2006-01-12 Raja R Harinath <rharinath@novell.com>
2517 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2519 * expression.cs (Invocation.OverloadResolve): Update.
2520 (Invocation.DoResolve): Avoid double resolution of invocation.
2522 2006-01-11 Raja R Harinath <rharinath@novell.com>
2525 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2526 unary negation of floating point types as 0-expr; negation cannot
2527 overflow in floating point types.
2530 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2531 on operands of 'void' type.
2534 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2535 and ExclusiveOr for boolean constants too.
2537 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2539 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2541 2006-01-12 Miguel de Icaza <miguel@novell.com>
2543 * cs-tokenizer.cs (Position): New class used to save and restore
2544 the position state in the tokenizer. Before this patch the save
2545 and restore was not complete enough so the line and columns would
2546 start to drift and the debugger and stack traces will get the
2549 2006-01-10 Martin Baulig <martin@ximian.com>
2552 (TypeParameter.InflateConstraints): New public method.
2554 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2555 constraints; fixes #77042.
2557 2006-01-10 Martin Baulig <martin@ximian.com>
2559 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2560 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2563 2006-01-09 Raja R Harinath <rharinath@novell.com>
2566 * expression.cs (Invocation.OverloadResolve): Replace reflected
2567 override methods with their base virtual methods, rather than
2569 * typemanager.cs (TypeManager.GetOverride): New.
2571 2005-12-21 Miguel de Icaza <miguel@novell.com>
2573 * driver.cs: Report the case of no source files and no -out:
2576 2005-12-20 Raja R Harinath <rharinath@novell.com>
2579 * expression.cs (ComposedCast.GetSignatureForError): Define.
2581 2006-01-05 Jb Evain <jbevain@gmail.com>
2583 * class.cs (Property.Define, Indexer.Define): do not tag the
2584 properties as SpecialName | RTSpecialName.
2586 2006-01-04 Miguel de Icaza <miguel@novell.com>
2588 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2589 doing a low-level comparission of parameter types. It was lacking
2590 a check for __argslist.
2592 2005-12-30 Miguel de Icaza <miguel@novell.com>
2594 * expression.cs (ParameterReference.DoResolveBase): Allow
2595 reference parameters if they are local to this block.
2597 This allows the ref and out parameters of a delegate to be used in
2598 an anonymous method, for example:
2600 delegate void set (out int x);
2602 set s = delegate (out int x){
2606 This is used by functionality introduced late in the C# language.
2608 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2609 method that take ref and out parameters.
2611 Fixes #77119 which was a late change in the spec.
2613 2005-12-23 Miguel de Icaza <miguel@novell.com>
2615 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2616 parent if its the same scope. Fixes #77060.
2618 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2620 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2622 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2624 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2625 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2626 that doesn't contain the full public key. This is a update of the
2627 friend assemblies in .Net 2.0 release.
2629 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2633 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2634 ListDictionary, to contain the ExternAliasEntry entries (in
2635 addition to the NamespaceEntry.aliases hashtable). This field is
2636 shared between the original entry and its doppelganger (bodyless
2638 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2639 extern_aliases field.
2640 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2641 lookup in extern_aliases.
2643 2005-12-16 Raja R Harinath <rharinath@novell.com>
2646 * class.cs (TypeContainer.Mark_HasEquals): New.
2647 (TypeContainer.Mark_HasGetHashCode): New.
2648 (ClassPart): Override them.
2649 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2651 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2652 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2656 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2657 'parent' argument to the base constructor.
2659 Remove all mention of TypeContainer from decl.cs.
2660 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2661 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2662 (DeclSpace.DeclSpace): Likewise.
2663 (DeclSpace.DefineMembers): Remove unused argument.
2664 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2665 debugging check -- we don't care if the debug code throws an
2666 InvalidCastException instead of an InternalErrorException.
2667 * class.cs (TypeContainer.DefineMembers): Update to changes.
2668 (TypeContainer.DoDefineMembers): Likewise.
2669 (TypeContainer.GetMethods): Likewise.
2670 (PropertyMember.Define): Likewise.
2671 (MemberBase.Parent): New property that forwards to
2672 MemberCore.Parent, but ensures that we get a TypeContainer.
2673 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2674 (RootContext.PopulateTypes): Likewise. Remove special case code
2675 for !RootContext.StdLib: DefineMembers is idempotent.
2677 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2679 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2681 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2683 * doc.cs : The search for referenced namespace was insufficient to
2684 get global one as it used to do. Fixed bug #76965.
2686 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2688 * doc.cs : check name in cref in the last phase that whether it is
2691 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2693 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2696 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2698 * doc.cs : so it turned out that we cannot skip override check for
2699 interface members. Fixed bug #76954.
2701 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2703 * cs-tokenizer.cs : fixed bug #75984:
2704 - #warning and #error should not be handled when the source line
2706 - #line is not checked strictly when the source line is disabled.
2707 - #define and #undef is on the other hand checked strictly at any
2710 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2712 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2715 2005-12-15 Raja R Harinath <rharinath@novell.com>
2717 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2719 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2722 2005-12-14 Martin Baulig <martin@ximian.com>
2724 * typemanager.cs (TypeManager.GetFullName): Make this public;
2725 `Type.Fullname' now never returns null.
2727 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2728 explicit interface implementations; we're now using the same
2729 naming convention than csc does.
2731 2005-12-14 Miguel de Icaza <miguel@novell.com>
2733 * convert.cs (ExplicitConversionCore): Check the return value from
2734 ExplicitConversionCore which can return null on failure. Fixes #76914
2736 2005-12-09 Raja R Harinath <rharinath@novell.com>
2738 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2739 instead of IsGenericInstance.
2740 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2741 code that's now covered by the more general test.
2742 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2744 * generic.cs (DropGenericTypeArguments): New. Captures the common
2745 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2746 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2747 * generic.cs, report.cs, typemanager.cs: Likewise.
2749 2005-12-08 Martin Baulig <martin@ximian.com>
2751 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2753 * typemanager.cs (TypeManager.CSharpSignature): Include type
2754 arguments in the signature of a generic method.
2756 2005-12-07 Martin Baulig <martin@ximian.com>
2758 Add support for custom attributes on type parameters.
2760 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2762 * generic.cs (TypeParameterName): New public class; we use this
2763 instead of a `string' to store the name of a type parameter, so we
2764 can also have `Attributes'.
2765 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2766 array instead of a `string[]' array.
2767 (TypeParameter.ctor): We now also take an `Attributes' argument.
2768 (TypeParameter.EmitAttributes): New public method; emit our
2769 `OptAttributes' here.
2770 (GenericMethod.EmitAttributes): New public method; emit the custom
2771 attributes on all our type parameters.
2773 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2774 our type parameters.
2775 (MethodData.Define): If we're a generic method, call
2776 EmitAttributes() on it.
2778 2005-12-07 Martin Baulig <martin@ximian.com>
2781 (ConstraintChecker): New public abstract class; move the
2782 constraint checking here from `ConstructedType' and also do
2783 constraint checking for generic methods here.
2785 * expression.cs (Invocation.OverloadResolve): Use
2786 ConstraintChecker.CheckConstraints() if we resolved to a generic
2789 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2791 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
2793 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
2795 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
2796 (FieldBase.Initializer): Initializer is now optional.
2797 (EventField.Define): Only event field can have initializer.
2799 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
2801 * const.cs (Const): Reuse initializer.
2803 * cs-parser.jay: Updated after FieldBase changes.
2804 Added current_array_type to simplify array initializers.
2806 * ecore.cs (NullCast.IsDefaultValue): Implemented.
2808 * expression.cs, iterators.cs: Updated.
2810 * namespace.cs (NamespaceEntry): Made UsingFound private.
2812 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2814 * parameterCollection.cs: Obsolete, removed.
2815 * parser.cs: Obsolete, removed.
2817 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2820 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
2822 * enum.cs (Enum.Define): Set obsolete context here.
2824 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2827 - FindDocumentedMember() now expects 1) paramList as null
2828 when "we don't have to check the number of parameters" and
2829 2) Type.EmptyTypes when "there is no arguments".
2830 - Introduced FoundMember struct to hold the exact type which was
2831 used to find the documented member (the above change broke
2832 test-xml-044; it might be better just to use DeclaringType than
2833 what MS does, like this change does, but it depends on usage.)
2835 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2837 * doc.cs : documented member might be from DeclaringType for nested
2838 types. Fixed bug #76782.
2840 2005-12-03 Ben Maurer <bmaurer@ximian.com>
2842 * anonymous.cs: Have the param code handle leaving copies on the
2843 stack etc. Allows anonymous params to take part in the assignment
2844 code (++, +=, etc). Fixes bug #76550
2846 * expression.cs: Handle the prepare_for_load/leave_copy by passing
2847 it down to the anon code.
2849 * iterators.cs: Use dummy var here
2851 * codegen.cs: Handle new vars
2853 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2856 * class.cs (MethodData.Define): Set proper Obsolete context.
2858 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
2860 (FieldExpr.DoResolve): Ditto.
2862 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2865 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
2866 parent is not obsolete.
2868 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
2870 * doc.cs : (FindDocumentedMember) find parameterless members first
2871 and get CS0419 in the early stage. Fixed first case of bug #76727.
2873 2005-11-30 Marek Safar <marek.safar@seznam.cz>
2876 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
2877 no error was reported.
2879 *expression.cs (Binary.DoResolve): left can be null.
2881 2005-12-06 Raja R Harinath <rharinath@novell.com>
2883 * class.cs (MethodCore.CheckGenericOverride): Delete unused
2884 abstract method and all overrides.
2885 * support.cs (ParameterData.GenericConstraints): Delete.
2886 (ReflectionParameters.type_params): Delete.
2887 (ReflectionParameters.ReflectionParameters): Make private.
2888 (ReflectionParameters.GetConstaints): New factory method.
2889 * generic.cs (TypeParameterDefineType): Use it.
2890 (TypeManager.GetTypeParameterConstraints): Likewise.
2892 2005-11-22 Marek Safar <marek.safar@seznam.cz>
2895 * class.cs (MethodData.Emit): Parameters should be labeled first.
2897 2005-11-21 Marek Safar <marek.safar@seznam.cz>
2900 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
2902 2005-11-18 Marek Safar <marek.safar@seznam.cz>
2904 * attribute.cs (AreParametersCompliant): Moved to Parameter.
2906 * class.cs (MethodCore): Parameter clean up.
2907 (IMethodData): Added ParameterInfo.
2908 (MethodData): Parameter clean up.
2909 (Indexer.Define): Parameter clean up.
2921 * typemanager.cs: Parameter clean up.
2923 * delegate.cs (Define): Get rid of duplicated code.
2925 * expression.cs (ParameterReference): Removed useless parameters
2927 (Invocation): Ditto.
2929 * parameter.cs (ParamsParameter): New class, params specialization.
2930 (ArglistParameter): Attemp to separate arglist.
2931 (Parameter): Refactored to be reusable and faster.
2932 (Parameter.Modifier): Made understandable.
2933 (Parameters): Changed to be used as a class for `this' assembly
2934 parameters. Refactored to use new specialized classes.
2936 * support.cs (ParameterData): Added Types property.
2937 (InternalParameters): Deleted.
2939 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2941 * doc.cs : the previous patch does not actually fix the bug.
2942 PropertyInfo override check is now implemented and really fixed it.
2943 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
2945 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2947 * doc.cs : apply "override filter" also to properties.
2950 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2952 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
2953 no need to check overrides. For classes, omit those results from
2954 interfaces since they must exist in the class. Fixed bug #76726.
2956 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2958 * typemanager.cs : (GetFullNameSignature) differentiate indexers
2959 with different parameters. Fixed the second problem in #76685.
2961 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2963 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
2964 get expected 'protected' access in CheckValidFamilyAccess()).
2967 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2969 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
2970 Fixed bug #76705. CS1569 was incorrectly commented out.
2972 2005-11-23 Martin Baulig <martin@ximian.com>
2974 * generic.cs (Constraints.Define): Removed.
2975 (TypeParameter.DefineConstraints): Removed.
2976 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
2977 on the GenericTypeParameterBuilder here.
2979 2005-11-23 Martin Baulig <martin@ximian.com>
2981 * typemanager.cs (TypeManager.GetProperty): Make this public.
2983 * generic.cs (Nullable.NullableInfo.ctor): Use
2984 TypeManager.GetProperty() rather than using reflection directly.
2986 2005-11-17 Martin Baulig <martin@ximian.com>
2988 * expression.cs (Indexers.GetIndexersForType): Added support for
2989 generic parameters; fixes #76587.
2991 2005-11-17 Martin Baulig <martin@ximian.com>
2994 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
2995 inherit the scope from our parent. Fixes #76653.
2997 2005-11-15 Martin Baulig <martin@ximian.com>
2999 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
3000 instead of `ScopeTypeBuilder' to refer to the "current" type.
3001 (AnonymousMethod.CreateScopeType): Correctly create the helper
3002 class if we're inside a generic type definition.
3004 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3006 * doc.cs : use Invocation.IsOverride() to do real override check.
3007 * expression.cs : made Invocation.IsOverride() internal.
3009 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3011 * doc.cs : use TypeManager.FindMembers() instead of (possible)
3012 TypeBuilder.FindMembers() and filter overriden base members out.
3015 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3017 * doc.cs : ref/out parameters are represented as '@' (instead of
3018 '&' in type FullName). Fixed bug #76630 (additionally crefs).
3020 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3022 * doc.cs : when there was no '.' in cref to methods in doc comment,
3023 then parameters were missing in the output. Fixed bug #76691.
3025 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3027 * driver.cs : don't output docs when there is an error.
3030 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3033 Now it should detect indexers. Fixed primary concern in bug #76685.
3034 Fixed CS0419 message to not show the identical member signature in
3037 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3039 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
3040 instead of Type.FindMembers() since it does not handle events.
3043 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
3045 * codegen.cs: Fixed typo (speficied -> specified).
3047 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3050 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
3052 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3054 * attribute.cs: Changed error message.
3056 * cs-tokenizer.cs: One more check.
3058 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3060 * statement.cs (Block.Resolve): Ignore empty statement.
3062 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3064 * report.cs: Made error/warning methods more strict to avoid
3067 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
3068 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
3069 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
3070 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
3072 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3074 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
3075 Use the more explicit AssemblyName.FullName instead of
3076 AssemblyName.Name to report errors.
3078 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3080 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
3083 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3093 * report.cs: Fixed error reporting and typos.
3095 * generic.cs (TypeParameter.GetSignatureForError): New method.
3096 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
3098 * typemanager.cs (GetFullName): Refactored.
3100 2005-11-08 Marek Safar <marek.safar@seznam.cz>
3102 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
3103 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
3105 * class.cs (TypeContainer.IsComImport): New property.
3106 (Constructor.Define): Create proper ctor for ComImport types.
3108 * expression.cs (New.CheckComImport): Fixed.
3110 2005-11-07 Miguel de Icaza <miguel@novell.com>
3112 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
3113 that a parameter has been captured does not mean that we do not
3114 have to do the rest of the processing. This fixes the second part
3115 of #76592. If there was another anonymous method capturing
3116 values in the past, the Scope would never be set for the second
3117 method that captured the same parameter.
3119 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
3120 properly manipulate the stack. Second part of fix for #76592.
3122 * expression.cs (New): Add support for invoking "new" on
3123 interfaces that have been flagged with the ComImport attribute and
3124 the CoClass. Fixes #76637
3126 * statement.cs (Try.DoEmit): When a variable is captured, do not
3127 try to emit the vi.LocalBuilder variable as it has been captured.
3128 Create a temporary variable and store the results on the
3129 FieldBuilder. Fixes #76642
3131 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3133 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
3135 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
3137 * expression.cs (Binary.DoResolve): Added && optimalization.
3139 * typemanager.cs (AddUserType): Removed useless argument.
3141 2005-11-04 Marek Safar <marek.safar@seznam.cz>
3143 * statement.cs (Block.variables): Uses ListDictionary.
3145 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3148 * class.cs (PartialContainer.EmitType): Customized to emit
3149 security attributes.
3150 (ClassPart.ApplyAttributeBuilder): Transform security attribute
3151 for partial classes.
3153 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3156 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
3157 access has to be fixed.
3159 * typemanager.cs (IsUnmanagedType): Wrong common field type.
3161 2005-11-01 Marek Safar <marek.safar@seznam.cz>
3164 * ecore.cs (NullCast.Reduce): Implemented.
3166 * expression.cs (ArrayCreation.CheckIndices): Correcly check
3169 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
3171 (Foreach.Resolve): Catch null properly.
3173 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3175 * cs-tokenizer.cs: Warning text fix.
3177 * driver.cs: AllWarningNumbers exposed on public interface.
3179 * report.cs (): Reviewed warning numbers.
3180 (IsValidWarning): Use binary search.
3182 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3184 * driver.cs: Implemeted resource visibility.
3185 (Resources): New class for code sharing between /res: and
3188 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3190 decl.cs (CurrentTypeParameters): Fixed to be public.
3192 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3194 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3196 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3198 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3200 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3202 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3204 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3206 Add friend assembly access support.
3207 * typemanager.cs: assembly_internals_vis_attrs
3208 cache for friend assembly access.
3209 (TypeManager.IsFriendAssembly): New method for
3210 checking friend assembly access.
3211 (TypeManager.Error_FriendAccessNameNotMatching): New
3213 (TypeManager.CompareKeyTokens): Likewise.
3214 (TypeManager.Filter): Handle friend accessible
3217 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3218 friend accessible types.
3220 * ecore.cs (Expression.IsAccessorAccessible): Handle
3221 friend accessible properties.
3223 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3226 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3229 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3232 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3235 * ecore.cs (NullCast): Child is contant only.
3237 * literal.cs (NullLiteral.Reduce): null can be converted to any
3240 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3242 * driver.cs: Use Encoding.Default as default code page instead
3245 2005-10-27 Raja R Harinath <rharinath@novell.com>
3248 * expression.cs (Invocation.Error_InvalidArguments): Handle
3249 __arglist parameters.
3250 (Invocation.VerifyArgumentsCompat): Likewise.
3251 * support.cs (ReflectionParameters.GetSignatureForError): Print
3252 __arglist parameters.
3253 (InternalParamters.GetSignatureForError): Likewise.
3254 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3256 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3258 * attribute.cs (GetPropertyValue): Made public.
3260 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3262 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3264 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3267 * driver.cs: Reflect method name change.
3269 * statement.cs (Try.Resolve): Warn when try has both general
3272 * typemanager.cs: runtime_compatibility_attr_type new predefined
3275 2005-10-26 Raja R Harinath <harinath@gmail.com>
3278 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3279 treat it as an empty parameter list.
3281 2005-10-26 Raja R Harinath <rharinath@novell.com>
3284 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3285 ResolveAsTypeStep silent.
3286 * statement.cs (Block.AddConstant): Mark block as used.
3287 (Block.ResolveMeta): Avoid piling on error messages
3288 if a constant initializer resolution fails.
3290 2005-10-25 Raja R Harinath <rharinath@novell.com>
3292 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3294 (NamespaceEntry.VerifyAllUsing): New.
3295 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3296 behaviour. Delegates actual resolution of alias to ...
3297 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3298 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3300 * driver.cs (Driver.MainDriver): Update.
3302 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3303 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3305 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3307 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3308 RootNamespace.DefineNamespacesForAll.
3310 2005-10-24 Raja R Harinath <harinath@gmail.com>
3312 * typemanager.cs (assemblies, external_aliases, modules)
3313 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3314 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3315 overhead. Move resposibility ...
3316 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3317 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3319 2005-10-23 Raja R Harinath <harinath@gmail.com>
3321 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3322 cached_namespaces. Improve usage.
3323 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3324 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3325 Move from GlobalRootNamespace and simplify.
3326 (RootNamespace.Global): Make instance variable.
3327 (RootNamespace.RootNamespace): Add "alias name" parameter.
3328 (GlobalRootNamespace): Simplify drastically.
3329 (Namespace.Lookup): Don't use GetNamespace.
3330 * typemanager.cs (GetRootNamespace): Rename from
3331 ComputeNamespaceForAlias.
3332 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3334 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3336 * anonymous.cs (AnonymousContainer): Don't crash when container
3339 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3341 * expression.cs (Binary.DoResolve): Warn when comparing same
3344 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3347 * expression.cs (Binary.DoResolve): It looks like there are no
3348 convetsion rules in enum context.
3350 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3352 Add support for extern alias qualifiers.
3353 * typemanager.cs: Move some LookupTypeReflection code
3354 to namespace.cs, to have cleaner code. Added some methods
3355 to help us keep track of the extern aliased references.
3356 * driver.cs: Add suport for extern alias assemblies on command
3357 line and check for their warnings/errors. Also keep track of the
3358 extern aliased assemblies.
3359 * namespace.cs: Move the global functionality of Namespace
3360 to GlobalRootNamespace/RootNamespace. Now the global namespace
3361 is GlobalRootNamespace.Globa. Also the code moved from
3362 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3363 Finally added LocalAliasEntry (AliasEntry before) and
3364 ExternAliasEntry, to handle alias statements.
3365 * cs-parser.jay: Add support in the grammar for extern alias
3367 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3368 Update callings to Namespace (now in GlobalRootNamespace).
3370 2005-10-25 Martin Baulig <martin@ximian.com>
3372 * convert.cs (ImplicitTypeParameterConversion): Make base
3373 interfaces actually work; fixes #76557.
3375 2005-10-25 Martin Baulig <martin@ximian.com>
3378 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3379 all the type parameters; fixes #76551.
3381 2005-10-25 Martin Baulig <martin@ximian.com>
3386 (GenericMethod.ctor): Added `Expression return_type' and
3387 `Parameters parameters' arguments.
3388 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3389 parameter and return types to check their constraints if they're
3392 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3395 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3396 constraints of a generic type if `ec.ResolvingGenericMethod'.
3398 * class.cs (MethodCore.DoDefineParameters): Set
3399 `ec.ResolvingGenericMethod' if we're a generic method.
3400 (MemberBase.MemberType): Likewise.
3402 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3404 * typemanager.cs (TypeManager): Added
3405 TypeManager.internals_visible_attr_type to cache
3406 S.R.CompilerServices.InternalsVisibleToAttribute.
3408 * codegen.cs (AssemblyClass): Added checks for
3409 InternalsVisibleToAttribute in new method
3410 CheckInternalsVisibleAttribute () and also cache the
3411 AssemblyName in AssemblyClass.Name.
3413 2005-10-24 Martin Baulig <martin@ximian.com>
3416 (TypeManager.ExpandInterfaces): Added overloaded version which
3417 just takes a `Type[]' array.
3420 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3421 just use the interfaces which were explicitly specified and not
3422 the interfaces they inherit. Fixes #76482.
3423 (TypeParameter.FindMembers): Expand the interfaces here.
3425 2005-10-21 Martin Baulig <martin@ximian.com>
3428 (Constraints.Resolve): Also resolve the actual types here.
3429 (Constraints.ResolveTypes): Just check the constraints here.
3430 Fixes #76363; see gtest-218.cs.
3432 2005-10-21 Martin Baulig <martin@ximian.com>
3435 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3436 instead of a `BoxedCast'; fixes gtest-217.cs.
3438 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3440 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3441 1) "new()" is specified as generic parameter constraint and 2) the
3442 type is TypeBuilder and 3) the type is abstract even if it has a
3443 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3445 2005-10-20 Martin Baulig <martin@ximian.com>
3448 (GenericConstraints.TypeParameter): New public property.
3449 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3450 (TypeParameter.DeclSpace): New public property.
3451 (TypeParameter.DefineType): Inflate the constraints if our
3452 `DeclSpace' is an `Iterator'.
3454 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3456 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3457 GenericMethod argument to compare methods' generic type arguments.
3460 2005-10-19 Martin Baulig <martin@ximian.com>
3462 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3463 not ResolveType() when resolving the base type, so we're not
3464 checking the constraints here.
3465 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3468 2005-10-19 Martin Baulig <martin@ximian.com>
3470 * generic.cs (ConstructedType.CheckConstraints): Committing
3471 untested fix for #76441.
3473 2005-10-18 Raja R Harinath <rharinath@novell.com>
3476 * class.cs (TypeContainer.DefineType): Move updating of
3477 topological sort earlier in the code.
3478 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3480 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3483 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3485 * constant.cs (Constant.TryReduce): Moved from Cast class.
3486 (Reduce): Made little bit more OO and fixed missing conversions.
3488 * ecore.cs (Reduce): Implemented.
3489 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3491 * literal.cs (Reduce): Implemented.
3493 * class.cs: Reverted Miguel's wrong commit.
3495 2005-10-14 Miguel de Icaza <miguel@novell.com>
3497 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3499 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3501 * cs-parser.jay, expression.cs : CS0214 was missing error location
3502 for constants. Fixed bug #76404.
3504 2005-10-10 Raja R Harinath <rharinath@novell.com>
3506 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3508 (PropertyExpr.EmitCall): Likewise.
3509 * expression.cs (Invocation.EmitArguments): Handle case where
3511 (Invocation.EmitCall): Avoid allocating temporary variable if
3512 there are no arguments.
3514 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3517 * convert.cs (ExplicitConversionCore): Fixed object->enum
3520 2005-10-07 Raja R Harinath <rharinath@novell.com>
3523 * convert.cs (ImplicitConversionStandard): Move conversion of
3524 void* to arbitrary pointer types ...
3525 (ExplicitConversionStandard): .. here.
3526 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3527 error to always print typenames.
3529 2005-10-07 Raja R Harinath <rharinath@novell.com>
3531 * convert.cs (GetConversionOperator): Rename from
3532 GetConversionOperators. Move operator selection code from ...
3533 (UserDefinedConversion): ... here.
3535 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3537 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3540 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3542 * assign.cs (Assign.DoResolve): Error method changed.
3544 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3546 * const.cs (ResolveValue): Reset in_transit immediately.
3548 * constant.cs: Error method changed.
3550 * convert.cs: Removed useless location parameter.
3551 (ExplicitNumericConversion): Don't do double enum check.
3552 (ExplicitConversionCore): Renamed from ExplicitConversion.
3553 (ExplicitUnsafe): Extracted from ExplicitConversion.
3554 (ExplicitConversion): Uses for error reporting.
3556 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3558 (ResolveBoolean): Uses common error method.
3559 (CastToDecimal): Get rid of ec.
3560 (CastFromDecimal): Optimized.
3561 (ConvCast): Get rid of ec.
3563 * enum.cs (ResolveValue): Reset in_transit immediately.
3564 (Emit): Return after first error.
3566 * expression.cs: Convert changes.
3568 * literal.cs: Error method changed.
3570 * statement.cs: Error method changed.
3572 2005-10-06 Raja R Harinath <rharinath@novell.com>
3574 Fix gtest-131.cs and gtest-211.cs.
3575 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3576 Only emit code for a label if it is used. Unreachable code can
3577 violate ECMA evaluation stack invariants.
3579 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3581 * anonymous.cs: Implemented ExprClassName.
3583 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3586 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3589 * class.cs (StaticClass.DefineContainerMembers): Report protected
3592 * codegen.cs: if(ed) PRODUCTION.
3594 * convert.cs (Error_CannotImplicitConversion): Better error
3597 * cs-parser.jay: More error checks.
3599 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3601 * driver.cs (CSCParseOption): Enabled wrong option check.
3603 * ecore.cs (Expression.ExprClassName): Turned to property.
3604 (MemberExpr.CheckIntermediateModification): For checking boxed
3605 value types modification.
3607 * statement.cs (Fixed.Resolve): Expression type must be
3608 convertible to fixed type.
3609 (CollectionForeach.GetEnumeratorFilter,TryType):
3610 Small refactoring for easier error checking.
3612 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3614 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3617 * class.cs (GeneratedBaseInitializer): New class for customization
3618 compiler generated initializers.
3619 (MemberBase.DoDefine): Check Obsolete attribute here.
3620 (FieldMember.DoDefine): Ditto.
3622 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3625 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3626 (MemberCore.GetObsoleteAttribute): Removed argument.
3627 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3628 (MemberCore.CheckObsoleteType): New helper.
3632 * statement.cs: Updates after MemberCore changes.
3634 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3635 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3637 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3638 obsolete attribute for compiler construct.
3639 (As.DoResolve): Cache result.
3641 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3643 2005-10-01 Miguel de Icaza <miguel@novell.com>
3645 * expression.cs (Probe): instead of having a "Type probe_type"
3646 keep the extra information as a TypeExpr probe_type_expr since the
3647 "As" operator needs to perform some type checks.
3649 * (As.DoResolve): If the type is a type parameter, ensure that it
3650 is constrained by a class.
3652 2005-09-22 Miguel de Icaza <miguel@novell.com>
3654 * statement.cs (Lock): Use the TemporaryVariable class instead of
3655 manually using local variables as those do not work when variables
3658 * ecore.cs: Moved the TemporaryVariable class from being a nested
3659 class inside Foreach to be a public class that can be employed in
3662 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3664 * cs-parser.jay: interface_accessors replaced by
3665 accessor_declarations.
3667 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3670 * statement.cs (GotoCase.Resolve): Convert null constant to
3672 (SwitchLabel.ResolveAndReduce): Ditto.
3673 (SwitchLabel.NullStringCase): Custom null stamp.
3674 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3676 typemanager.cs (CSharpSignature): Don't skip first argument
3679 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3681 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3682 expression.cs, iterators.cs, literal.cs: Store constants and
3685 * class.cs (MemberBase.ShortName): Pass location.
3687 * cs-parser.jay: Some location fixes.
3689 * ecore.cs (Expression.Location): Made virtual.
3691 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3694 * const.cs (Const.ResolveValue): Check for assigning non-null
3695 value to reference type.
3697 2005-09-26 Raja R Harinath <rharinath@novell.com>
3700 * expression.cs (This.VerifyFixed): In a value type T, the type of
3701 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3702 value type R, 'this' is treated as a value parameter.
3704 2005-09-05 Miguel de Icaza <miguel@novell.com>
3706 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3707 if the underlying types are the same, otherwise we need to produce
3708 code that will do the proper cast.
3710 This was exposed by Marek's constant rewrite which produced
3711 invalid code for the call site:
3714 void Method (X v) {}
3718 This fixes test-49.cs
3720 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3722 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3723 Type/Object should be allowed as well. Fixed bug #75968.
3725 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3727 * expression.cs : (Binary.DoResolve): when one is enum constant and
3728 another is constant 0, then return enum one *as enum type*.
3731 2005-10-04 Martin Baulig <martin@ximian.com>
3733 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3734 `SetMemberIsUsed()' work for generics, too.
3736 2005-10-04 Martin Baulig <martin@ximian.com>
3738 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3739 for corlib. Fixes #75691.
3741 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3744 * driver.cs: Fix compilation files with full root path.
3746 2005-09-25 Miguel de Icaza <miguel@novell.com>
3748 * report.cs (SymbolRelatedToPreviousError): Format the output so
3749 it does not use an open parenthesis that is never closed.
3751 * driver.cs: Follow coding guidelines
3753 2005-09-18 Miguel de Icaza <miguel@novell.com>
3755 * driver.cs: Set InEmacs based on the environment variable EMACS.
3757 * location.cs (InEmacs): in this mode, do not report column
3758 location as it confuses Emacs.
3760 2005-10-03 Raja R Harinath <rharinath@novell.com>
3762 * support.cs (SeekableStreamReader.Position): Don't error out when
3763 the requested position is just beyond the end of the current
3766 2005-09-28 Raja R Harinath <rharinath@novell.com>
3768 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3769 try to keep in sync with the byte count of the underlying Stream.
3770 However, this limits us to a window size of 2048 characters: i.e.,
3771 the maximum lookahead of our lexer/parser can be 2048 characters.
3773 2005-09-22 Martin Baulig <martin@ximian.com>
3775 * driver.cs: Removed a debugging FIXME.
3777 2005-09-21 Raja R Harinath <rharinath@novell.com>
3779 * cs-parser.jay (type_arguments): Add CS1644 check.
3780 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3782 2005-09-15 Raja R Harinath <rharinath@novell.com>
3784 * Makefile (PROGRAM): Make profile specific.
3785 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
3786 the current directory.
3789 * expression.cs (Invocation.EmitCall): Remove optimization on
3790 this_call since it doesn't handle 'this' being a value type.
3792 2005-09-05 Geoff Norton <gnorton@customerdna.com>
3794 * driver.cs: Ensure file handles are closed after parsing
3796 2005-09-05 Miguel de Icaza <miguel@novell.com>
3798 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3799 if the underlying types are the same, otherwise we need to produce
3800 code that will do the proper cast.
3802 This was exposed by Marek's constant rewrite which produced
3803 invalid code for the call site:
3806 void Method (X v) {}
3810 This fixes test-49.cs
3812 2005-09-05 Martin Baulig <martin@ximian.com>
3814 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
3815 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
3817 * cs-parser.jay (delegate_declaration): Small fix for #75852.
3819 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3821 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
3822 to be a pointer type due to the spec 25.2, so check if declaring
3823 type is generic type definition. Fixed bug #75772.
3825 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3828 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
3829 both types are not defined by methods.
3830 * expression.cs : (Invocation.IsApplicable): it should work when
3831 the argument type is equal to the parameter type, not only when
3832 ImplicitConversionExists() returns true.
3834 2005-09-02 Raja R Harinath <rharinath@novell.com>
3836 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
3840 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
3841 flow-branching for LocalVariableReferences in case we were invoked
3842 from a MemberAccess.
3843 * expression.cs (LocalVariableReference.VerifyAssigned): New.
3845 (LocalVariableReference.DoResolveBase): ... this.
3846 (MemberAccess.Resolve): Do the check that was disabled during
3849 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3852 (PartialContainer.Create): check abstract/sealed/static strictly
3853 but abstract/sealed can exist only at one side. Fixed bug #75883.
3855 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
3858 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
3859 specified, don't default to UnmanagedType.I4.
3861 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3863 * expression.cs : conditional operator should check possibly
3864 incorrect assign expression. Fixed bug #75946.
3866 2005-08-30 Raja R Harinath <rharinath@novell.com>
3869 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
3870 (ScopeInfo.EmitScopeType): Use it to construct field names from
3871 names of captured locals.
3874 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
3875 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
3876 Pass 'target_type' to BoxedCast. Don't default to 'object'.
3877 (ExplicitConversion): Remove enum cases already handled by
3878 implicit conversion. Move implicit conversion check to the beginning.
3879 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
3880 * expression.cs (ArrayCreation.EmitDynamicInitializers):
3881 Don't treat System.Enum as a struct.
3883 2005-08-30 Jb Evain <jbevain@gmail.com>
3885 * attribute.cs: handles as expression in parameters.
3887 2005-08-30 Raja R Harinath <rharinath@novell.com>
3890 * class.cs (TypeContainer.VerifyClsName): Don't use a
3891 PartialContainer when verifying CLS compliance.
3892 (AbstractPropertyEventMethod): Set Parent here, ...
3893 (PropertyMethod): ... not here.
3895 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
3897 * attribute.cs : escaped attribute name should not be allowed to be
3898 resolved (e.g. @class as classAttribute). Fixed bug #75930.
3900 2005-08-29 Raja R Harinath <rharinath@novell.com>
3903 * convert.cs (ImplicitStandardConversionExists): Allow zero also
3904 when converting a long constant to unsigned long.
3905 * expression.cs (Invocation.OverloadResolve): Add sanity check to
3906 detect where IsApplicable and VerifyArgumentsCompat disagree.
3908 2005-08-29 Raja R Harinath <rharinath@novell.com>
3909 and Carlos Alberto Cortez <carlos@unixmexico.org>
3912 * class.cs (TypeContainer.CanElideInitializer): New helper.
3913 (TypeContainer.EmitFieldInitializers): Use it to determine if we
3914 can safely emitting the initializer of a field.
3916 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3918 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
3919 allowed inside a switch (without loop). Fixed bug #75433.
3921 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
3923 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
3924 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
3926 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3928 * driver.cs : kinda reverting the default encoding changes (not exact
3929 revert since I noticed that "codepage:reset" might not work fine).
3931 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3933 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
3934 Location. Now getter and setter store location correctly.
3935 (errors/cs0111-12.cs now reports the expected location.)
3937 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3939 * driver.cs : Use default encoding on the environment.
3940 Removed (now that) extra parameter for SeekableStreamReader.
3941 * support.cs : (SeekableStreamReader) third .ctor() argument for
3942 StreamReader is not required (always true). preamble size could
3943 be acquired in simpler and safe way.
3945 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
3947 * cs-parser.jay: report CS0642 at warning level 3
3948 and report CS0642 for an if else statement also
3949 fixes bug #74745. Patch by John Luke (and a bit
3951 Removed extra CS0642 warning check for "while",
3953 * statement.cs: In Block.Resolve(), CS0642 check
3954 is reimplemented to check a sequence of an empty
3955 statement and a block.
3957 Both fix bug #66777.
3959 2005-08-24 Marek Safar <marek.safar@seznam.cz>
3961 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
3962 detection until I fix it.
3964 * cs-tokenizer.cs: Changed error message.
3966 * cs-parser.jay: Fixed 2 error locations.
3968 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
3969 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
3972 * enum.cs (GetSignatureForError): Fixed.
3974 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
3978 * typemanager.cs (RegisterProperty): Removed.
3980 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
3982 2005-08-24 Raja R Harinath <rharinath@novell.com>
3985 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
3986 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
3988 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3990 * expression.cs : tiny fix is required for not warning positive ulong.
3993 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3995 * expression.cs : add CS0652 check for constant and integral
3996 expression. Fixed bug #53974.
3998 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4000 * expression.cs : in DoNumericPromotions(), check if there is implicit
4001 conversion overload for string (to check CS0034). Fixed bug #52492.
4003 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4005 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
4007 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4009 * ecore.cs : report location when it is *not* Null.
4011 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4017 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
4018 correctly. Fixed bug #75721.
4020 2005-08-23 Raja R Harinath <rharinath@novell.com>
4022 * support.cs (SeekableStreamReader.Position): Avoid an expensive
4023 loop that performs 'min (pos, char_count)'.
4026 * expression.cs (Unary.ResolveOperator): Don't discard implicit
4027 converted value in Operator.OnesComplement.
4029 2005-08-22 Ben Maurer <bmaurer@ximian.com>
4031 * anonymous.cs: If the anon method is pulled into a helper class,
4032 it needs to be `internal' not `private'. Fixes runtime behavior on
4035 2005-08-17 Marek Safar <marek.safar@seznam.cz>
4038 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
4041 2005-08-16 Marek Safar <marek.safar@seznam.cz>
4043 The big constants rewrite
4044 Fix #75746, #75685 and more
4045 As a side effect saved 1MB for MWF ;-)
4047 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
4048 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
4049 enum based for corlib compilation.
4051 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
4054 * class.cs (FixedField.Define): Use ResolveAsConstant.
4056 * const.cs (IConstant): Interface constants and enums.
4057 (Const.ResolveValue): New method for constant resolvning.
4058 (ExternalConstant): Constants from imported assemblies.
4060 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
4061 conversion; like enums.
4062 (Constant.ToType): Converts this constant to different type.
4063 (Constant.Increment): Adds 1.
4065 * convert.cs (ImplicitConversionRequired): Simplified.
4067 * cs-parser.jay: Create EnumMember directly.
4069 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
4071 * doc.cs (GenerateEnumDocComment): Removed.
4073 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
4074 (ConvertIntLiteral): Removed.
4075 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
4077 * enum.cs (EnumMember): Implement IConstant.
4078 (Enum.IsValidEnumConstant): Removed.
4079 (Enum.GetNextDefaultValue): Removed.
4080 (Enum.FindMembers): Updated.
4081 (Enum.GenerateDocComment): Iterate enum members.
4083 * expression.cs (Cast.TryReduce): Handle enums correctly.
4084 (New.Constantify): Made public.
4085 (MemberAccess.DoResolve): Removed contant specific if(s).
4087 * literal.cs (NullLiteral): Implement new abstract methods.
4089 * statement.cs (GotoCase.Resolve): Use new constant methods.
4090 (SwitchLabel.ResolveAndReduce): Use new constant methods.
4092 * typemanager.cs (LookupEnum): Removed.
4093 (IsEnumType): Fixed to work with corlib.
4094 (RegisterConstant): Removed.
4095 (LookupConstant): Removed.
4096 (GetConstant): Changed to work with IConstant.
4098 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
4100 * location.cs : Fixed overflown (>255) column number.
4102 2005-08-03 Raja R Harinath <rharinath@novell.com>
4104 First cut of the qualified-alias-member feature.
4105 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
4107 * cs-parser.jay (DOUBLE_COLON): New token.
4108 (namespace_or_type_name): Add rule for recognizing
4109 qualified-alias-members.
4110 (primary_expression): Likewise.
4111 (element_access): Allow QualifiedAliasMember as a possible
4112 type-bearing expression.
4113 (local_variable_type, local_variable_pointer_type): Likewise.
4114 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
4115 aliases in the current and enclosing namespace declarations.
4116 (NamespaceEntry.UsingAlias): Add CS0440 warning.
4117 * decl.cs (MemberName.is_double_colon): New.
4118 (MemberName.MemberName): Add new constructor for alias-member.
4119 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
4120 * expression.cs (QualifiedAliasMember): New expression type.
4122 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4124 * location.cs : it borked when no argument was specified.
4126 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4128 * location.cs : tiny ToString() format fix.
4130 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4132 * statement.cs : oops, it was missing.
4134 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4136 A set of fixes for precise line/column location.
4139 "token" field now holds a file/line "delta", a line number offset
4140 from the segment, and a column number. See also:
4141 http://lists.ximian.com/pipermail/mono-devel-list/2004-
4142 December/009508.html
4143 Removed static IsNull. Use instance IsNull property instead.
4145 For some tokens it stores Location. For Identifier it stores
4146 LocatedToken which is a pair of string name and location.
4147 Column numbers are adjusted only at getChar().
4149 Use Location.ToString() for reporting (it now contains column).
4151 Largely modified to use LocatedToken instead of
4152 string (IDENTIFIER), and to acquire Location from some tokens.
4153 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
4154 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
4156 Now MemberName holds Location. DeclSpace.ctor() receives Location
4157 as a parameter. Removed extra parameters to all derived classes.
4158 Replaced Location.IsNull() with instance property.
4159 * assign.cs, expression.cs :
4160 Added .ctor() overload that omits Location.
4162 Added "nameEscaped" flag that indicates the identifier was escaped
4163 in the source file. This fixes bug #57047.
4165 2005-09-02 Martin Baulig <martin@ximian.com>
4167 * class.cs: Make CS3005 a warning, not an error.
4169 2005-08-02 Marek Safar <marek.safar@seznam.cz>
4171 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
4172 New method, looking for lo-case imported cls type.
4174 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4177 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4179 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4181 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4183 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4185 Optimized to save 3.5 MB for SWF compilation.
4187 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4189 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4190 (PartialContainer.Create): Moved logic AddToContainer.
4191 (PartialContainer.MarkForDuplicationCheck): Shares name.
4193 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4196 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4198 (Namespace.GetSignatureForError): New method.
4200 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4201 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4203 2005-08-01 Raja R Harinath <rharinath@novell.com>
4206 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4207 member lookup rather than qualifier_type, since qualifier_type can
4210 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4212 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4215 2005-07-31 Miguel de Icaza <miguel@novell.com>
4217 * statement.cs: Copy the local exception into the exception
4218 captured local. Fixes 75674
4220 2005-07-31 Raja R Harinath <harinath@gmail.com>
4223 * expression.cs (Invocation.OverloadResolve): Don't report error
4224 CS1501 if error CS1502 has been reported.
4225 (New.DoResolve): Delegate CS1501 reporting to
4226 Invocation.OverloadResolve.
4229 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4230 invariant-meaning-in-block property in an enclosing block if
4233 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4235 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4236 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4237 (Switch.CheckSwitch): Just save 50kb for SWF.
4239 2005-07-27 Martin Baulig <martin@ximian.com>
4241 * anonymous.cs (CaptureContext.AddField): Added
4242 `AnonymousContainer am' argument; compute its toplevel scope if
4243 it's not already computed. Fixes #75649.
4245 2005-07-26 Raja R Harinath <rharinath@novell.com>
4248 * class.cs (Constructor.Emit): Reset block to null if the block
4251 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4253 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4255 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4257 * class.cs (MethodData.Define): Check whether accessor implementing
4258 interface is public.
4260 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4262 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4265 * namespace.cs (LookupType): Moved same type check to...
4267 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4270 2005-07-21 Raja R Harinath <rharinath@novell.com>
4272 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4273 already found a typebuilder.
4274 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4275 MemberNames, not strings.
4277 * const.cs (Error_ExpressionMustBeConst):
4278 Rename from Error_EpressionMustBeConst.
4279 * const.cs, class.cs, statement.cd: Update.
4281 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4285 * const.cs (Const.LookupConstantValue): Report missing contant expression
4287 (Error_EpressionMustBeConstant): Only one error method.
4289 * class.cs, statement.c: Updated.
4291 2005-07-20 Raja R Harinath <rharinath@novell.com>
4293 * statement.cs (Block.Flags): Add back HasVarargs.
4294 (Block.flags): Make protected.
4295 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4297 * typemanager.cs (types, typecontainers, user_types): Remove.
4298 (UserTypes, TypeContainers): Likewise.
4299 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4300 (CleanUp, Reset): Update.
4301 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4302 (GetNestedType): Use Type.GetNestedType.
4303 (CoreLookupType): Take two arguments, the namespace and the
4304 basename of the type. Update to use the Namespace.Lookup
4306 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4307 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4308 string concatenation and substring matches.
4309 * class.cs, enum.cs, delegate.cs: Update to changes.
4311 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4313 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4314 Expression and made virtual.
4316 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4317 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4319 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4321 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4324 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4327 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4330 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4331 AssemblyCultureAttribute is not used on executable.
4334 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4336 2005-07-16 Raja R Harinath <rharinath@novell.com>
4339 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4340 New. Reports CS0252/CS0253.
4341 Mostly taken from preliminary patch by Duncak Mak.
4342 (Binary.DoResolveOperator): Store results of operator lookup.
4343 Use them to detect if we need to warn about unintended reference
4346 2005-07-15 Raja R Harinath <rharinath@novell.com>
4349 * namespace.cs (Namespace.Lookup): Add back location parameter.
4350 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4351 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4353 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4354 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4355 (Namespace.LookupType): ... this.
4356 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4358 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4359 purported to handle pointers.
4360 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4363 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4365 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4368 2005-07-15 Raja R Harinath <rharinath@novell.com>
4370 * namespace.cs (Namespace.Lookup): Drop location parameter.
4371 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4372 (NamespaceEntry.Lookup): ... this.
4373 (NamespaceEntry.Error_AmbiguousTypeReference):
4374 Move here from DeclSpace.
4375 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4377 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4378 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4379 Move to NamespaceEntry.
4380 * delegate.cs, expression.cs: Update to changes.
4382 2005-08-31 Martin Baulig <martin@ximian.com>
4384 Committing a patch from Atsushi Enomoto for #75850.
4386 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4387 Prefer a generic enumerator over a non-generic one.
4389 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4391 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4392 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4394 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4396 * driver.cs : reverting default encoding change as well as mcs.
4398 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4400 * driver.cs, support.cs : merged r48826.
4402 > could you integrate your mcs changes to gmcs otherwise
4403 > gmcs cannot compile some files.
4405 2005-08-20 Martin Baulig <martin@ximian.com>
4407 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4408 scope if we don't already have it.
4410 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4411 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4414 2005-07-31 Miguel de Icaza <miguel@novell.com>
4416 * statement.cs: Copy the local exception into the exception
4417 captured local. Fixes 75674
4419 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4421 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4424 2005-08-12 Martin Baulig <martin@ximian.com>
4426 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4427 for nested types here to avoid hitting the cache too early.
4429 2005-08-09 Miguel de Icaza <miguel@novell.com>
4431 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4434 2005-08-03 Martin Baulig <martin@ximian.com>
4436 Make iterators in generic methods work; see gtest-191.cs.
4439 (Constraints.Resolve): Protect against being called twice.
4442 (TypeContainer.GetClassBases): Make this `protected virtual'.
4444 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4445 (Iterator.GetClassBases): Override this and compute the base
4447 (Iterator.DefineNestedTypes): If we're a generic method, all our
4448 method type parameters become class type parameters on the proxy
4452 (ToplevelBlock.Parameters): Make this a property, not a field.
4453 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4455 2005-08-03 Martin Baulig <martin@ximian.com>
4457 * typemanager.cs (TypeManager.IsSubclassOf): Use
4458 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4459 (TypeManager.GetFullName_recursed): Improved.
4461 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4464 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4465 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4466 invocation_type == mi.DeclaringType, since the first one also checks
4467 other condition used by generic instances.
4469 2005-07-27 Martin Baulig <martin@ximian.com>
4471 * anonymous.cs (CaptureContext.AddField): Added
4472 `AnonymousContainer am' argument; compute its toplevel scope if
4473 it's not already computed. Fixes #75649.
4475 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4477 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4478 CheckAttributeType and refactored.
4479 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4480 ResolveAsTypeTerminal error handling.
4481 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4483 (GetSignatureForError): Print errors in same way.
4486 * codegen.cs: Reflect attribute GetSignatureForError change.
4489 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4491 * namespace.cs (UsingEntry): Refactored to make fields private.
4494 statement.cs: Error_UnexpectedKind has extra parameter.
4496 2005-07-14 Raja R Harinath <rharinath@novell.com>
4498 * ecore.cs (IAlias): Remove.
4499 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4500 that implement the interface.
4501 * namespace.cs (Namespace): Likewise.
4502 (Namespace.declspaces): Renamed from 'defined_names'.
4503 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4504 DeclSpace instead of an IAlias.
4505 * tree.cs (Tree.AddDecl): Update.
4507 2005-07-12 Raja R Harinath <rharinath@novell.com>
4509 * statement.cs (Block.Flags); Remove HasVarargs.
4510 (Block.HasVarargs): Move to ToplevelBlock.
4511 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4512 (Block.Variables): Make protected. Initialize variable hashtable
4514 (Block.AddVariable): Update.
4515 (Block.Resolve): Update to changes.
4516 (ToplevelBlock.HasVarargs): New boolean.
4517 (ToplevelBlock.ThisVariable): Move here from Block.
4518 (ToplevelBlock.AddThisVariable): Likewise.
4519 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4520 * expression.cs (This.ResolveBase): Update to changes.
4521 (ArglistAccess.DoResolve): Likewise.
4523 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4526 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4528 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4529 not used and not used & assigned.
4530 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4532 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4535 * expression.cs (Is.DoResolve): null is never provided type.
4537 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4540 * cs-parser.jay: Less strict event error rule to catch more errors.
4542 2005-07-11 Martin Baulig <martin@ximian.com>
4544 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4545 for the constructor constraint: we do not only have to check
4546 whether the class has a public constructor, but also ensure that
4547 it's parameterless. Fixes #75492.
4549 2005-07-11 Martin Baulig <martin@ximian.com>
4551 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4552 between type parameters if they either have the reference type
4553 constraint or the class constraint.
4555 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4557 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4559 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4562 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4563 (ExtractSecurityPermissionSet): Cope with self referencing security
4564 attributes properly.
4566 * driver.cs (SetOutputFile): Made public property OutputFile.
4568 2005-07-07 Raja R Harinath <rharinath@novell.com>
4571 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4572 has_nonstatic_fields. Make into a FieldBase pointer.
4573 (TypeContainer.AddField): Add CS0282 check.
4574 (TypeContainer.EmitType): Update.
4576 2005-07-06 Miguel de Icaza <miguel@novell.com>
4578 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4579 compare if they start with __.
4581 2005-07-06 Raja R Harinath <rharinath@novell.com>
4583 * statement.cs (Switch.SwitchGoverningType): Only look at
4584 UserCasts that don't need implicit standard conversions to one of
4585 the allowed switch types (Fixes test-322.cs).
4586 (LocalInfo.Resolve): Re-enable sanity-test.
4588 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4590 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4592 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4594 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4596 2005-07-06 Raja R Harinath <rharinath@novell.com>
4599 * ecore.cs (SimpleName.GetSignatureForError): Add.
4600 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4601 (MemberAccess.GetSignatureForError): Add.
4603 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4605 The big error and warning messages review.
4635 * typemanager.cs: Updated.
4637 * class.cs: (MethodCore.SetYields): Moved here to share.
4638 (PropertyMethod.Define): Moved iterator setup here.
4640 * iterators.cs: Add orig_method to have full access to parent
4643 2005-07-05 Raja R Harinath <rharinath@novell.com>
4645 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4646 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4647 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4648 variable of struct type.
4649 * expression.cs (Unary.ResolveOperator): Update to change.
4650 (Indirection.VerifyFixed): Likewise.
4651 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4652 (ParameterReference.VerifyFixed): Value parameters are fixed.
4653 (This.VerifyFixed): Treat 'this' as a value parameter.
4654 * statement.cs (LocalInfo.IsFixed): Remove.
4656 2005-07-01 Martin Baulig <martin@ximian.com>
4658 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4659 `ec.EmitThis ()' to get the correct scope.
4661 2005-07-01 Martin Baulig <martin@ximian.com>
4663 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4664 instance is a ParameterReference; fixes #75299.
4666 2005-06-30 Raja R Harinath <rharinath@novell.com>
4669 * expression.cs (Indexers.map): Remove.
4670 (Indexers.Append): Filter out inaccessible setters and getters.
4671 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4674 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4676 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4677 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4678 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4679 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4681 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4684 * class.cs (FieldBase.GetInitializerExpression): One more field
4687 2005-06-28 Miguel de Icaza <miguel@novell.com>
4689 * pending.cs: Do not define a proxy if the base method is virtual,
4690 it will be picked up by the runtime (bug 75270).
4692 2005-07-08 Martin Baulig <martin@ximian.com>
4694 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4695 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4697 2005-07-07 Martin Baulig <martin@ximian.com>
4699 * generic.cs (ConstructedType.CheckConstraint): Use
4700 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4701 called recursively; fixes #75329.
4703 2005-07-06 Martin Baulig <martin@ximian.com>
4705 * generic.cs (TypeManager.InferTypeArguments): Added support for
4706 anonymous methods; fixes #75461.
4708 2005-07-01 Martin Baulig <martin@ximian.com>
4710 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4711 `ec.EmitThis ()' to get the correct scope.
4713 2005-07-01 Martin Baulig <martin@ximian.com>
4715 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4716 instance is `This'; fixes #75299.
4718 2005-06-30 Martin Baulig <martin@ximian.com>
4720 * class.cs (Indexer): Implement IIteratorContainer; added support
4721 for iterators in indexers.
4724 (EmitContext.CurrentIterator): Make this a property, not a field.
4726 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4728 2005-06-28 Miguel de Icaza <miguel@novell.com>
4730 * pending.cs: Do not define a proxy if the base method is virtual,
4731 it will be picked up by the runtime (bug 75270).
4733 2005-06-28 Martin Baulig <martin@ximian.com>
4735 * cs-parser.jay (interface_method_declaration): Avoid a
4736 reduce/reduce conflict by moving some of the code into a separate
4737 `interface_method_declaration_body' rule; fixes #75368.
4739 2005-06-28 Martin Baulig <martin@ximian.com>
4741 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4742 array check after the check for TypeBuilder's.
4744 2005-06-21 Raja R Harinath <rharinath@novell.com>
4746 * convert.cs (FindMostEncompassedType): Add two trivial special
4747 cases (number_of_types == 0 || number_of_types == 1).
4748 (FindMostEncompasingType): Likewise.
4750 2005-06-17 Raja R Harinath <rharinath@novell.com>
4752 Some cleanups preparing for the fix of #75283.
4753 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4755 (EventExpr.InstanceResolve): Likewise.
4756 (EventExpr.DoResolve): Remove redundant checks.
4758 2005-06-08 Miguel de Icaza <miguel@novell.com>
4760 * class.cs: Small fix.
4762 2005-06-08 Raja R Harinath <rharinath@novell.com>
4765 * class.cs (GetPartialBases): Fix return value check of
4768 2005-06-07 Raja R Harinath <rharinath@novell.com>
4770 Ensure that partial classes are registered in their enclosing
4771 namespace. Initial part of fix of #75160.
4772 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4773 Register declspace with namespace here, not in
4774 DeclSpace.RecordDecl.
4775 * cs-parser.jay: Pass namespace to RecordDecl.
4776 * class.cs (PartialContainer.Create): Likewise.
4777 (ClassPart.DefineType): New sanity-check. Throws an exception if
4779 * decl.cs (Declspace.RecordDecl): Remove.
4780 * namespace.cs (NamespaceEntry.DefineName): Remove.
4782 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4784 * rootcontext.cs: Reset TargetExt as well.
4786 2005-06-03 Raja R Harinath <rharinath@novell.com>
4788 * ecore.cs (Expression.Resolve): Emit CS0654 error when
4791 2005-06-02 Raja R Harinath <rharinath@novell.com>
4793 Fix #75080, cs0119.cs.
4794 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
4796 (Expression.Resolve): ... this. Use it. Remove bogus code
4797 allowing ExprClass.Type and ExprClass.Namespace for
4798 ResolveFlags.VariableOrValue.
4799 (Expression.Resolve) [1-argument variant]: Change default resolve
4800 flags based on language version.
4801 (Expression.Error_UnexpectedKind): Use a simple string array
4802 rather than an ArrayList.
4803 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
4805 (TypeOfVoid.DoResolve): Likewise.
4806 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
4807 flags argument -- it always has the same value.
4809 2005-05-31 Raja R Harinath <rharinath@novell.com>
4812 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
4813 Use it in the error message.
4814 * assign.cs, expression.cs, statement.cs: Update.
4816 2005-05-30 Raja R Harinath <rharinath@novell.com>
4819 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
4820 the "almostMatchedMember" case too.
4821 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
4822 that failed the accessibility checks to 'almost_match'.
4824 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
4826 * attribute.cs: Use internal MethodBuilder methods to set
4827 ExactSpelling and SetLastError on PInvoke methods, instead
4828 of passing them via charset. Fixes #75060.
4830 2005-05-27 Raja R Harinath <rharinath@novell.com>
4832 * parameter.cs (Parameter): Remove TODO comment.
4833 (Parameter.DefineParameter): Remove Location parameter.
4834 (Parameters.LabelParameters): Likewise.
4835 * class.cs (Constructor.Emit): Update to change.
4836 (MethodData.Emit): Likewise.
4837 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
4838 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
4840 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
4843 Removed Parameters.Location and added Parameter.Location instead.
4844 Removed Location parameter from Emit() and GetSignature().
4851 Modified all related calls.
4853 2005-06-21 Martin Baulig <martin@ximian.com>
4855 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
4856 left-hand side is not a nullable type; fixes #75328.
4858 2005-06-21 Martin Baulig <martin@ximian.com>
4861 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
4862 (TypeManager.GetFullNameSignature): Likewise.
4864 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
4865 `source.FullName' and `target.FullName' to check whether there are
4866 two conflicting definitions.
4868 2005-06-21 Martin Baulig <martin@ximian.com>
4870 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
4871 a BoxedCast - also for reference types - to be compatible with csc.
4873 2005-06-21 Martin Baulig <martin@ximian.com>
4875 * expression.cs (MemberAccess.DoResolve): Add support for nested
4876 types in a generic instance; fixes #75320.
4878 2005-06-20 Martin Baulig <martin@ximian.com>
4880 * generic.cs (TypeManager.InferType): Also walk the class
4881 hierarchy for generic instances; fixes #75261.
4883 2005-06-17 Martin Baulig <martin@ximian.com>
4885 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
4886 to make things work for corlib.
4888 2005-06-15 Martin Baulig <martin@ximian.com>
4890 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
4891 obsolete `SecurityAction' values.
4893 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4895 * rootcontext.cs: Reset TargetExt as well.
4897 2005-06-09 Martin Baulig <martin@ximian.com>
4899 * delegate.cs (Delegate.VerifyMethod): Added
4900 `MethodGroupExpr old_mg' argument; inherit its
4901 `HasTypeParameters'; fix #75085.
4903 2005-06-09 Martin Baulig <martin@ximian.com>
4905 * expression.cs (Invocation.OverloadResolve): Correctly handle
4906 generic methods for the SetMemberIsUsed(); fix #75064.
4908 2005-06-09 Martin Baulig <martin@ximian.com>
4910 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
4913 2005-06-08 Martin Baulig <martin@ximian.com>
4915 * cs-parser.jay (nullable_type_or_conditional): If we put the
4916 nullable back and our `type' is a `ComposedCast', remove the
4917 nullable from it. Fixes #75156.
4919 * expression.cs (ComposedCast.RemoveNullable): New public method.
4921 2005-06-08 Martin Baulig <martin@ximian.com>
4923 The big Iterators rewrite :-)
4925 * iterators.cs: Rewrite this to use the anonymous methods framework.
4927 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
4928 before the TypeContainers; see 2test-21.cs.
4931 (TypeContainer.DefineType): Don't create a new EmitContext if we
4932 already have one (this only happens if we're an Iterator).
4933 (TypeContainer.Define): Also call Define() on all our iterators.
4934 (Method.CreateEmitContext): Added support for iterators.
4937 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
4938 (AnonymousContainer.CreateMethodHost): Moved here from
4939 AnonymousMethod and made abstract.
4940 (AnonymousContainer.CreateScopeType): New abstract method.
4941 (AnonymousContainer.IsIterator): New public property.
4942 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
4943 get the ScopeTypeBuilder rather than manually defining it here.
4944 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
4947 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
4948 before RootContext.DefineTypes().
4950 * codegen.cs (EmitContext.RemapToProxy): Removed.
4951 (EmitContext.CurrentAnonymousMethod): Changed type from
4952 AnonymousMethod -> AnonymousContainer.
4953 (EmitContext.ResolveTopBlock): Protect from being called twice.
4954 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
4955 (EmitContext.EmitThis): Removed the iterators hacks; use the
4956 anonymous methods framework for that.
4959 (ToplevelBlock.Container): Make this a property, not a field.
4960 (ToplevelBlock.ReParent): New public method; move the
4961 ToplevelBlock into a new container.
4962 (Foreach.TemporaryVariable): Simplify.
4964 2005-06-05 Martin Baulig <martin@ximian.com>
4966 * statement.cs (LocalInfo.CompilerGenerated): New flag.
4967 (Block.AddTemporaryVariable): New public method; creates a new
4968 `LocalInfo' for a temporary variable.
4969 (Block.EmitMeta): Create the LocalBuilders for all the temporary
4971 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
4972 non-iterator variables.
4974 2005-06-05 Martin Baulig <martin@ximian.com>
4976 * statement.cs (Foreach.TemporaryVariable): Create the
4977 LocalBuilder in the Emit phase and not in Resolve since in some
4978 situations, we don't have an ILGenerator during Resolve; see
4979 2test-19.cs for an example.
4981 2005-06-04 Martin Baulig <martin@ximian.com>
4983 The big Foreach rewrite - Part II.
4985 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
4986 with `PropertyInfo ienumerator_getcurrent'.
4988 * codegen.cs (VariableStorage): Removed.
4991 (Foreach): Derive from Statement, not ExceptionStatement.
4992 (Foreach.CollectionForeach): New nested class. Moved all the code
4993 dealing with collection foreach here.
4994 (Foreach.ForeachHelperMethods): Removed.
4995 (Foreach.TemporaryVariable): Implement IMemoryLocation.
4997 2005-05-23 Martin Baulig <martin@ximian.com>
4999 * statement.cs (Try.DoResolve): Don't create a `finally' if we
5000 don't need to. Fix #75014.
5002 2005-05-26 Raja R Harinath <rharinath@novell.com>
5004 Improve user-defined conversion handling.
5005 * convert.cs (GetConversionOperators): Rewrite. Return only the
5006 applicable operators.
5007 (AddConversionOperators): New. Helper for GetConversionOperators.
5008 (FindMostEncompassedType, FindMostEncompassingType): Verify that
5009 there is only one most encompassed/encompassing type.
5010 (FindMostSpecificSource, FindMostSpecificTarget): Remove
5011 "applicable operator" handling.
5012 (UserConversion): Move cache here from GetConversionOperators.
5013 Directly cache the chosen operator, rather than the whole
5015 (ExplicitNumericConversion): Fix buggy implementation of Decimal
5016 case. Allow conversion of decimal to sbyte and byte too.
5017 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5018 New static methods. Used to avoid allocating EmptyExpressions in
5021 2005-05-24 Duncan Mak <duncan@novell.com>
5023 * ecore.cs (CastFromDecimal): New class for casting a decimal to
5024 another class, used in Convert.ExplicitNumericConversion.
5025 (CastToDecimal): New class, similar to above, but casts to
5026 System.Decimal, used in Convert.ImplicitNumericConversion and also
5027 in explicit convesion from double/float to decimal.
5029 * convert.cs (ImplicitNumericConversion): Handle implicit
5030 conversions to System.Decimal.
5031 (ExplicitNumericConversion): handle explicit conversions to
5036 2005-05-20 Miguel de Icaza <miguel@novell.com>
5038 * typemanager.cs: Do not throw an exception in the TypeBuilder
5039 case, we take care of it on the TypeCode.
5041 2005-05-17 Marek Safar <marek.safar@seznam.cz>
5043 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
5046 * cs-parser.jay: Catch more lexical errors.
5048 * report.cs: Add one more Error method.
5051 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
5053 2005-05-20 Martin Baulig <martin@ximian.com>
5055 * class.cs (TypeContainer.CircularDepException): Removed.
5056 (TypeContainer.DefineType): Removed the `InTransit' stuff.
5057 (TypeContainer.CheckRecursiveDefinition): Check for circular class
5058 (CS0146) and interface (CS0529) dependencies here.
5060 2005-05-20 Martin Baulig <martin@ximian.com>
5062 * expression.cs (New.DoResolve): Move the CS0712 check above the
5063 CS0144 check; otherwise it can never be reached.
5065 2005-05-20 Martin Baulig <martin@ximian.com>
5067 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
5069 2005-05-20 Martin Baulig <martin@ximian.com>
5071 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
5073 * typemanager.cs (TypeManager.IsAttributeType): New public method.
5075 2005-05-19 Martin Baulig <martin@ximian.com>
5078 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
5079 to disable error reporting.
5081 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
5082 here since we don't want to report an error; see the new test-336.cs.
5084 2005-05-19 Raja R Harinath <rharinath@novell.com>
5086 * statement.cs (ToplevelBlock.GetParameterReference)
5087 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
5088 Move here from class Block.
5089 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
5090 * expression.cs (ParameterReference.DoResolveBase): Likewise.
5092 2005-05-18 Martin Baulig <martin@ximian.com>
5097 (FlowBranching.Reachability): Add non-static public And() and Or()
5099 (FlowBranchingSwitch): New class; do the `break_origins' thing
5100 like in FlowBranchingLoop.
5101 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
5102 reachability, not just locals and parameters.
5103 (FlowBranching.MergeChild): Remove some of the hacks for loop and
5104 switch; MergeBreakOrigins() now takes care of that.
5106 2005-05-18 Martin Baulig <martin@ximian.com>
5108 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
5109 a loop and may leave it, reset the barrier; fixes #74974.
5111 2005-05-16 Raja R Harinath <rharinath@novell.com>
5113 Fix test-382.cs. Emit values of decimal constants.
5114 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
5116 (TypeContainer.AddField): ... this.
5117 (TypeContainer.EmitFieldInitializers): Allow the list of fields
5118 with initializers to include 'Const's.
5119 (ClassPart.RegisterFieldForInitialization): Forward to
5121 * const.cs (Const.Const): Pass initializer to base class.
5122 (Const.Define): In case of decimal constants, register them for
5123 initialization in a static constructor.
5125 2005-05-14 Martin Baulig <martin@ximian.com>
5127 * statement.cs (Block.Resolve): Correctly handle unreachable code;
5128 do not call ResolveUnreachable() on unreachable statements in
5129 here, see the comment in the source code.
5131 2005-05-13 Raja R Harinath <rharinath@novell.com>
5134 * expression.cs (BinaryResolveOperator): If one of the operands of
5135 an equality comparison is 'null' and the other is a pointer type,
5136 convert the null to a NullPointer.
5137 * convert.cs (ImplicitReferenceConversion): If the expression is a
5138 NullLiteral and the target type is a pointer type, return a
5139 NullPointer instead.
5140 (ImplicitConversionStandard): Likewise.
5142 2005-05-13 Marek Safar <marek.safar@seznam.cz>
5144 * cs-parser.jay: Set readonly context based on special constructs.
5146 * expression.cs (LocalVariableReference.DoResolveBase): Improved
5147 readonly variable error handling.
5149 * rootcontext.cs (EmitCode): Don't verify members when error
5152 * statement.cs (LocalInfo): Add reaodnly context information.
5153 (SetReadOnlyContext, GetReadOnlyContext): New methods.
5155 2005-05-17 Martin Baulig <martin@ximian.com>
5157 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
5160 2005-05-13 Martin Baulig <martin@ximian.com>
5162 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
5163 handle unreachable blocks.
5165 2005-05-13 Martin Baulig <martin@ximian.com>
5168 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
5169 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
5172 2005-05-13 Martin Baulig <martin@ximian.com>
5174 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5175 instance variable, not a local. Fix #74873.
5176 (Block.ResolveUnreachable): Set it to true here.
5178 2005-05-12 Martin Baulig <martin@ximian.com>
5180 * cs-parser.jay (property_declaration): Pass the `current_class',
5181 not the `current_container' to Property's .ctor. Fixes #74912.
5183 2005-05-11 Martin Baulig <martin@ximian.com>
5185 * typemanager.cs (Closure): Copy this from MCS and merge all the
5186 GMCS-specific changes into it.
5188 2005-05-12 Raja R Harinath <harinath@gmail.com>
5191 * typemanager.cs (unmanaged_enclosing_types): New.
5192 (IsUnmanagedType): Avoid infloops by using
5193 'unmanaged_enclosing_types' to talk with recursive invocations.
5195 2005-05-11 Duncan Mak <duncan@novell.com>
5197 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5198 continuing to process for 'arg'.
5199 (handle_preprocessing_directive): Check the argument of the #endif
5200 directive and report error CS1025 if there are any trailing
5203 According to the C# spec, having even whitespace after the #endif
5204 directive is illegal; however, because we call arg.TrimEnd ()
5205 beforehand, we have the same behavior as csc, allowing whitespace
5206 after the directive.
5210 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5214 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5215 (Constructor.GetObsoleteAttribute): Implemented correctly.
5217 2005-05-10 Martin Baulig <martin@ximian.com>
5219 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5220 resolve the type; fixes #74864.
5221 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5222 in DoResolve(); fixes #74862.
5224 2005-05-10 Martin Baulig <martin@ximian.com>
5226 * support.cs (ReflectionParameters.ParameterModifier): Use
5227 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5228 and `ParameterAttributes.In'. Fixes #74884.
5230 2005-05-10 Martin Baulig <martin@ximian.com>
5232 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5233 the cache if we're just looking for `MemberTypes.NestedType' in a
5236 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5237 constraints if we're still resolving the type tree.
5238 (Expression.MemberLookup): If we're resolving the type tree, only
5239 look for `MemberTypes.NestedType' since we're only interested in
5242 * class.cs (TypeContainer.DefineType): Don't resolve the type
5243 parameters here; do this later in ResolveType() after the type
5244 tree has been resolved.
5245 (TypeContainer.ResolveType): New public method; this is called
5246 after the type tree is resolved and before the types are being
5247 populated. We resolve the generic constraints here.
5248 (TypeContainer.DoDefineMember): Check the constraints on our base
5249 class and interfaces.
5251 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5252 set the `ResolvingTypeTree' flag on the EmitContext.
5254 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5256 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5258 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5260 * expression.cs (Argument.GetParameterModifier): Turned to property.
5261 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5263 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5266 2005-05-09 Raja R Harinath <rharinath@novell.com>
5269 * decl.cs (MemberCache.AddMethods): Register override methods,
5270 rather than non-override methods.
5271 * typemanager.cs (RegisterOverride): New.
5272 (IsOverride): Update.
5274 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5276 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5278 2005-05-06 Martin Baulig <martin@ximian.com>
5281 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5282 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5284 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5288 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5289 recursive declaration.
5291 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5293 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5295 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5297 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5299 2005-05-05 Raja R Harinath <rharinath@novell.com>
5302 * decl.cs (DeclSpace.FamilyAccessible):
5303 Use TypeManager.IsNestedFamilyAccessible.
5305 Fix reopened #64812.
5306 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5309 2005-05-04 Raja R Harinath <rharinath@novell.com>
5310 Abin Thomas <projectmonokochi@rediffmail.com>
5311 Anoob V E <projectmonokochi@rediffmail.com>
5312 Harilal P R <projectmonokochi@rediffmail.com>
5315 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5316 allow access to all static members.
5318 2005-05-04 Martin Baulig <martin@ximian.com>
5320 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5322 2005-05-04 Martin Baulig <martin@ximian.com>
5326 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5327 section at the end; make things work if `default' is not the last
5330 2005-05-04 Martin Baulig <martin@ximian.com>
5334 * statement.cs (Switch): Replaced the `got_default' field with a
5335 `default_section' one.
5336 (Switch.CheckSwitch): Set `default_section' here.
5337 (Switch.Resolve): If we're a constant switch and the constant is
5338 not found, use the default section.
5340 2005-05-03 Martin Baulig <martin@ximian.com>
5342 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5344 * statement.cs (Foreach.ArrayForeach): New nested class.
5345 (Foreach.TemporaryVariable): New nested class.
5346 (Foreach.EmitArrayForeach): Removed; this is now in the new
5349 2005-05-03 Raja R Harinath <rharinath@novell.com>
5351 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5353 (VerifyPendingMethods): Revert change below.
5355 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5356 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5357 that used to trigger warning -28. Remove warning -28.
5358 * expression.cs (Invocation.OverloadResolve): Use
5359 TypeManager.IsOverride to distinguish override methods.
5362 * pending.cs (VerifyPendingMethods): If a base type implements the
5363 requested interface, don't bother checking individual methods of
5364 the base type. As a side-effect, this prevents the creation of
5365 unnecessary proxies.
5367 2005-05-02 Martin Baulig <martin@ximian.com>
5371 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5372 Also `And' the locals if the old vector is null.
5373 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5374 null; in this case we basically reset all the variables.
5376 2005-05-02 Martin Baulig <martin@ximian.com>
5380 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5381 Added `FlowBranching branching' argument; always `and' the
5382 variables instead of `or'ing them unless we're an infinite loop.
5384 * statement.cs (While.Resolve): Create a new sibling unless we're
5387 2005-05-02 Martin Baulig <martin@ximian.com>
5391 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5392 arguments; use it instead of creating a new TopLevelBlock.
5393 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5394 our ConstructorInitializer.
5397 (TopLevelBlock.TopLevelBranching): New public property.
5398 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5399 and create our `TopLevelBranching'.
5401 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5402 anonymous method host, use `block.TopLevelBranching' rather than
5403 creating a new branching.
5405 2005-04-20 Miguel de Icaza <miguel@novell.com>
5407 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5408 a ScopeInfo, if any of the current children is a child of the new
5409 entry, move those children there.
5411 2005-04-30 Martin Baulig <martin@ximian.com>
5413 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5414 at the beginning of a SwitchSection. Fix #73335.
5416 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5419 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5421 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5422 (FieldExpr.DoResolve): Obsolete members are ignored for field
5425 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5427 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5428 of arrays detection.
5430 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5432 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5434 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5437 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5439 * cs-parser.jay: Use the prefered version of -unsafe in error
5442 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5444 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5447 2005-04-20 John Luke <john.luke@gmail.com>
5449 * driver.cs: fix typo in error message, --outout to --output
5451 2005-04-30 Martin Baulig <martin@ximian.com>
5453 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5454 handle the .NET 2.x security attributes.
5456 2005-04-30 Martin Baulig <martin@ximian.com>
5459 (TypeManager.ExpandInterfaces): Don't add things twice.
5462 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5464 2005-04-29 Martin Baulig <martin@ximian.com>
5466 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5468 * anonymous.cs: Added support for anonymous generic methods.
5470 2005-04-29 Martin Baulig <martin@ximian.com>
5472 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5475 2005-04-29 Martin Baulig <martin@ximian.com>
5477 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5479 * expression.cs (New.DoResolve): Fix the CS0304 check.
5481 2005-04-29 Martin Baulig <martin@ximian.com>
5483 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5486 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5487 explicit interface implementation, compare the interface types.
5488 (MethodData.Define): Use the new naming scheme from the latest
5490 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5492 * decl.cs (MemberName.GetMemberName): Removed.
5493 (MemberName.MethodName, FullName): New properties.
5495 2005-04-25 Raja R Harinath <rharinath@novell.com>
5497 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5499 2005-04-22 Martin Baulig <martin@ximian.com>
5501 * generic.cs (GenericMethod): Create the EmitContext in the
5502 `Define()'; in `Define(MethodBuilder)', create the type parameters
5503 before calling `Define()'. Fixes #73933.
5505 2005-04-22 Martin Baulig <martin@ximian.com>
5508 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5509 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5511 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5512 ConstructedType, check its constraints.
5514 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5516 * codegen.cs (InRefOutArgumentResolving): New field.
5518 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5519 fields outside contructor.
5521 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5523 2005-04-19 Miguel de Icaza <miguel@novell.com>
5525 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5526 parameter code was not completed ever, so it was not as up-to-date
5527 as local variables. Must finish it.
5529 The bug fix was to compare the Toplevel of the block, not the
5530 current block. Thanks for Ben for pointing this out.
5532 2005-04-19 Raja R Harinath <rharinath@novell.com>
5534 * decl.cs (AddMethods): Use the declaring type of the problem
5535 method to determine if we want to squash a warning.
5537 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5539 * attribute.cs: Removed debug output.
5541 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5543 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5546 2005-04-18 Raja R Harinath <rharinath@novell.com>
5549 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5550 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5551 all null comparisons against reference types.
5553 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5556 * class.cs (TypeContainer.CircularDepException) New nested
5558 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5559 (TypeContainer.DefineType): Removed error, reset InTransit before
5561 (Class.DefineType): Throw exception when is in Transit.
5562 Catch exception and report error.
5563 (Struct.DefineType): Throw exception when is in Transit.
5564 Catch exception and report error.
5565 (Interface.DefineType): Throw exception when is in Transit.
5566 Catch exception and report error.
5568 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5569 handle nested exception handlers.
5571 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5574 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5575 InFinally and InCatch storage.
5577 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5578 (Catch.Resolve): Set and Restore ec.InCatch.
5579 (Try.Resolve): Set and Restore ec.InFinally.
5580 (Try.HasCatch): True when try has catch.
5582 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5584 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5585 for the same event member, so exclude such cases from warning 419.
5588 2005-04-16 Miguel de Icaza <miguel@novell.com>
5590 * expression.cs (Binary.ResolveOperator): Apply patch from John
5591 Luke to fix bug 59864: operators &, | and ^ on enumerations
5592 require that the same enum type on both sides.
5594 * driver.cs: Add warnings to old flag usage, this is to assist
5595 people who produce Makefiles and hope that the Makefiles will be
5598 * class.cs (TypeContainer.EmitType): Moved the definition of the
5599 special $PRIVATE$ field from the resolve phase to the Emit phase.
5600 During resolve we do not know if we are a struct with
5601 HasExplicitLayout, we know this only after the attributes for the
5604 Set the FieldOffset to zero on the dummy field that we create for
5605 the class. Fixes 74590.
5607 2005-04-16 Raja R Harinath <rharinath@novell.com>
5610 * ecore.cs (PropertyExpr.resolved): New.
5611 (DoResolve): Use it to handle a case of double resolution here.
5612 Handle a case of identical-name-and-type-name.
5613 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5614 resolution by storing the results of expression resolution back
5615 into the "probes" array.
5617 2005-04-15 Raja R Harinath <rharinath@novell.com>
5619 Fix cs0208-7.cs and cs0208-8.cs.
5620 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5621 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5622 error reporting to point out the reason a struct is not unmanaged.
5624 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5626 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5627 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5629 2005-04-13 Raja R Harinath <rharinath@novell.com>
5632 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5633 IdenticalNameAndTypeName here.
5634 (EventExpr.InstanceResolve): Likewise.
5636 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5638 C# 2.0 DefaultCharSetAttribute implementation
5640 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5641 which allows us to set GlobalNamespace for every resolve.
5642 (Attribute.ResolveArguments): Cut from Resolve.
5643 (Attribute.GetCharSetValue): Returns CharSet named argument.
5644 (Attribute.DefinePInvokeMethod): Gets default charset from
5646 (GlobalAttribute.ResolveAsTypeStep): Override.
5647 (GlobalAttribute.ResolveArguments): Override.
5649 * class.cs (TypeAttr): Is protected.
5651 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5652 (ModuleClass.DefaultCharSetType): New memeber.
5653 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5655 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5656 charset from module.
5658 * delegate.cs (TypeAttr): Override.
5659 (Delegate.DefineType): Use this TypeAttr.
5661 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5662 at very early stage (before types are defined) to resolve model
5663 module attributes. It will probably not work with corlib but it
5666 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5667 charset from module.
5669 * typemanager.cs (default_charset_type): New type.
5671 2005-04-13 Raja R Harinath <rharinath@novell.com>
5673 * decl.cs (MemberCache.AddMethods): Don't warn if
5674 System.Object.Finalize has buggy MethodAttributes.
5676 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5679 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5681 * doc.cs : detect ambiguous reference to overloaded members.
5682 Fixed bug #71603. MS 1.1 csc does not detect it.
5684 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5686 * doc.cs : delegates must not be referenced with parameters.
5689 2005-04-12 Miguel de Icaza <miguel@novell.com>
5691 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5693 2005-04-10 Miguel de Icaza <miguel@novell.com>
5695 * driver.cs (MainDriver): Stop processing if the CLS stage found
5698 (CompilerCallableEntryPoint.InvokeCompiler): Always
5699 reset after execution; Take a TextWriter argument for the
5702 * report.cs: Use the error stream instead of hardcoding stderr.
5704 2005-04-09 Miguel de Icaza <miguel@novell.com>
5706 * class.cs: Reduce code paths to test, too small of an
5707 optimization to make it worth the extra testing. Always perform
5710 2005-04-08 Raja R Harinath <rharinath@novell.com>
5713 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5714 operators that had errors reported on them.
5716 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5718 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5720 (Attribute.Resolve): Add named argument type checking.
5722 * class.cs (FixedField.Define): Use IsPrimitiveType
5724 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5726 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5727 unsafe parameter types.
5729 * statement.cs (Using.ResolveExpression): Add better error description.
5731 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5733 2005-04-08 Raja R Harinath <rharinath@novell.com>
5736 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5737 AttributeUsageAttribute in the emitcontext of the attribute class,
5738 not in the emitcontext of the attributable entity it was attached to.
5739 * cs-parser.jay: Use 'current_class', not 'current_container',
5740 when creating a GlobalAttribute.
5742 2005-04-08 Alp Toker <alp@atoker.com>
5744 * pending.cs: The fix to #58413 failed to compile methods implementing
5745 interfaces with/without params modifiers and vice versa, even though
5746 params modifiers aren't part of the signature. Make the modifier check
5747 less strict as in csc.
5749 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5750 Anoob V E <projectmonokochi@rediffmail.com>
5751 Harilal P R <projectmonokochi@rediffmail.com>
5754 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5755 modifiers of pending methods.
5756 (PendingImplementation.PendingImplementation): Initialize it.
5757 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5758 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5759 with ParameterData. Add check for modifiers.
5760 * class.cs (MethodData.Define): Update to changes.
5762 2005-04-07 Raja R Harinath <rharinath@novell.com>
5764 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5766 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5768 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5771 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5774 * typemanager.cs: Registered RequiredAttributeAttribute.
5776 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5778 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5779 Warning CS0169 is back at level 3.
5780 (IMethodData.SetMemberIsUsed): New method.
5782 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5783 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
5785 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
5787 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
5789 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
5792 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
5795 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
5796 to avoid the problems with nested types.
5798 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
5799 Anoob V.E <projectmonokochi@rediffmail.com>
5800 Harilal P.R <projectmonokochi@rediffmail.com>
5801 Raja R Harinath <rharinath@novell.com>
5804 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
5806 * typemanager (GetConstructor): Make public.
5808 2005-04-05 John Luke <john.luke@gmail.com>
5809 Raja R Harinath <rharinath@novell.com>
5812 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
5813 struct too. Return false quicker in a few cases.
5814 (VerifyUnManaged): Use it.
5816 2005-04-05 Raja R Harinath <rharinath@novell.com>
5819 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
5820 not 'unreachable_seen'.
5822 2005-04-04 Marek Safar <marek.safar@seznam.cz>
5824 * attribute.cs (Attribute.GetValue): Removed unused.
5826 * codegen.cs (CodeGen.TrimExt): Removed unused.
5828 * cs-parser.jay (output): Removed unused.
5830 * cs-tokenizer.cs (hex_digits): Removed unused.
5832 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
5834 * expression.cs (Indirection.LoadExprValue): Removed unused.
5835 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
5837 * iterators.cs (Iterator.param_types): Removed unused.
5839 * statement.cs (Goto.block): Removed unused.
5840 (ToplevelBlock.did): Removed unused.
5841 (Switch.ResolveConstantSwitch): Removed unused.
5843 2005-04-01 Ben Maurer <bmaurer@ximian.com>
5845 * rootcontext.cs: Allow mcs to bootstrap with the compilation
5848 2005-04-19 Martin Baulig <martin@ximian.com>
5850 Merged r42462 from MCS and made it work for GMCS.
5852 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
5854 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
5856 2005-04-01 Raja R Harinath <rharinath@novell.com>
5858 Fix #74232 and cs0208-3.cs.
5859 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
5860 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
5861 unmanaged type. Don't use FieldBuilders when 't' is a
5862 TypeBuilder. Use ModFlags and MemberType fields.
5863 * class.cs (MemberBase.member_type): Rename from MemberType.
5864 (MemberBase.MemberType): New property. Determines member_type on
5866 (MemberBase.DoDefine): Don't initialize MemberType here.
5867 (FieldMember.Define): Likewise.
5869 2005-04-01 Marek Safar <marek.safar@seznam.cz>
5872 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
5873 Attributes are emitted there.
5875 2005-04-01 Raja R Harinath <rharinath@novell.com>
5877 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
5878 keyword in 'partial enum' too.
5879 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
5881 Report from Kamil Skalski <nazgul@omega.pl>.
5884 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
5885 have partial containers too.
5887 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
5888 in block' checks to Block.CheckInvariantMeaningInBlock.
5889 * statement.cs (Block.GetKnownVariableInfo): Make private.
5890 (Block.IsVariableUsedInChildBlock): Remove.
5891 (Block.IsVariableUsedInBlock): Likewise.
5892 (Block.CheckInvariantMeaningInBlock): New. Show location of
5893 conflicting declaration.
5894 (Block.AddVariable): Make error messages less long-winded and more
5895 specific. Show location of conflicting declaration.
5896 * parameter.cs (Parameters.Location): New readonly property.
5898 2005-03-31 Raja R Harinath <rharinath@novell.com>
5900 Clean up semantics of invoking ResolveMemberAccess.
5901 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
5902 can have an instance, ensure that we pass in a non-TypeExpression
5903 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
5904 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
5905 argument. Update to changes and simplify.
5906 (FieldExpr.Emitinstance): Remove CS0120 check.
5907 (PropertyExpr.EmitInstance): Likewise.
5908 * expression.cs (Argument.Resolve): Likewise.
5909 (Invocation.DoResolve): Update to changes in semantics of
5912 2005-03-31 Marek Safar <marek.safar@seznam.cz>
5915 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
5918 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
5920 2005-03-31 Raja R Harinath <rharinath@novell.com>
5922 Fix difference in behaviour with commandline invocation.
5923 * driver.cs (Driver.Reset): New.
5924 (CompilerCallableEntryPoint): Call it.
5926 * statement.cs (If.Resolve): Avoid spurious "uninitialized
5927 variable" warnings if the boolean expression failed to resolve.
5929 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
5931 * attribute.cs: Fix the union of several permissions when some of them
5932 are unrestricted (so the result isn't an unrestricted permission set).
5935 2005-03-30 Raja R Harinath <rharinath@novell.com>
5937 * ecore.cs (MemberExpr): New class. Convert from interface
5939 (MemberExpr.ResolveMemberAccess): Refactor and move here from
5940 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
5942 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
5943 (MethodGroupExpr.IsExplicitImpl): Remove.
5944 (Expression.GetFieldFromEvent): Remove.
5945 (SimpleName.MemberStaticCheck): Remove.
5946 (SimpleName.DoSimpleNameResolve): Update to changes.
5947 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
5948 (MemberAccess.IdenticalNameAndTypeName): Remove.
5949 (MemberAccess.error176): Move to MemberExpr.
5950 (MemberAccess.DoResolve): Update to changes.
5951 (BaseAccess.DoResolve): Likewise.
5953 2005-03-30 Marek Safar <marek.safar@seznam.cz>
5955 C# 2.0 Conditional attribute class implementation
5957 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
5958 Analyzes class whether it has attribute which has ConditionalAttribute
5959 and its condition is not defined.
5961 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
5962 (Class.IsExcluded): New method. Search for at least one defined
5963 condition in ConditionalAttribute of attribute class.
5965 2005-03-30 Raja R Harinath <rharinath@novell.com>
5967 * ecore.cs (PropertyExpr): Derive from Expression, not
5968 ExpressionStatement.
5969 (PropertyExpr.EmitStatement): Remove.
5971 2005-03-29 Raja R Harinath <rharinath@novell.com>
5974 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
5975 internal field "value__" of an enum be private. The examples for
5976 "value__" that I found on MSDN all used FieldAttributes.Private.
5978 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
5979 Don't mention IL method attribute names.
5981 Fix #47991. Remove a TODO.
5982 * statement.cs (Block.Toplevel): Make into a field.
5983 (Block.Parameters): Move into ToplevelBlock.
5984 (Block.known_variables): Rename from child_variable_names.
5985 (Block.Block): Remove variants that take Parameters. Initialize
5986 'Toplevel' with the immediately surrounding toplevel block.
5987 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
5988 LocalInfo parameter.
5989 (Block.GetKnownVariableInfo): New.
5990 (Block.IsVariableNameUsedInChildBlock): Update.
5991 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
5992 the block, even though it may not be in scope.
5993 (Block.AddVariable): Remove Parameters parameter. Use
5994 Toplevel.Parameters instead.
5995 (Block.AddConstant): Remove Parameters parameter.
5996 (Block.GetParameterReference): Update to use Toplevel.Parameters.
5997 (Block.IsParamaterReference): Likewise.
5998 (Block.IsLocalParameter): Likewise. Simplify a lot.
5999 (ToplevelBlock.Parameters): New. Moved from Block.
6000 (ToplevelBlock.ToplevelBlock): Update to changes. Always
6001 initialize Parameters to a non-null value.
6002 * cs-parser.jay: Update to changes.
6003 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
6004 simple names that mean different things in the same block. Use
6005 Block.IsVariableNameUsedInBlock.
6007 2005-03-28 Raja R Harinath <rharinath@novell.com>
6009 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
6011 2005-03-26 Raja R Harinath <harinath@acm.org>
6014 * assign.cs (Assign.DoResolve): When the RHS of an assignment
6015 fails to resolve, ensure that the LHS is still resolved as an
6018 2005-03-25 Raja R Harinath <harinath@acm.org>
6020 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
6022 (Enum.current_ec): Remove.
6023 (Enum.LookupEnumValue): Remove EmitContext argument.
6024 Just uses the one created during DefineType.
6025 (Enum.FindMembers): Update.
6026 * expression.cs (MemberAccess.DoResolve): Update.
6028 2005-03-22 Marek Safar <marek.safar@seznam.cz>
6030 * assign.cs (Assign.DoResolve): Check for CS1717 when
6031 source and target are same (uses Equals).
6033 * expression.cs (LocalVariableReference, ParameterReference,
6034 This): Implemented Equals, GetHashCode.
6036 * statement.cs (Block.GetParameterReference): Removed useless
6039 2005-03-22 Raja R Harinath <rharinath@novell.com>
6042 * statement.cs (Block.AddVariable): Ensure that we skip implicit
6043 blocks before deciding whether the error is cs0136 or cs0128.
6045 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
6046 (using_alias_directive, using_namespace_directive): Pass
6047 MemberName, not an expression to Namespace.UsingAlias and
6049 (MakeName): Use the MemberName of the namespace.
6050 * namespace.cs (Namespace.MemberName): New.
6051 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
6052 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
6054 * decl.cs (MemberName.Name): Make readonly.
6055 (MemberName.FromDotted): New "constructor".
6056 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
6057 (MemberCore.Name): Compute from MemberName on demand.
6058 (MemberCore.SetMemberName): Provide a way to change the
6060 (MemberCore.AddToContainer): Don't take a fullname parameter.
6061 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
6062 fully qualified name of the container to the member name.
6063 (TypeContainer.AddToTypeContainer): Use a fully qualified name
6064 only if the type is a member of the root container.
6065 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
6066 MemberName.Left rather than searching for an embedded ".".
6067 (PartialContainer.CreatePart): Update to changes in RootContext.
6068 (MemberBase.ShortName): Turn into a property. Use
6069 MemberCore.SetMemberName.
6070 (MemberBase.ExplicitInterfaceName): Remove.
6071 (MemberBase.UpdateMemberName): Remove.
6072 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
6073 (PropertyBase.SetMemberName): New override.
6074 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
6075 (Tree.GetDecl): New.
6076 (Tree.AllDecls): Rename from Decls.
6077 * attribute.cs, enum.cs, report.cs: Update to changes.
6078 * driver.cs (MainDriver): Use MemberName.FromDotted on
6079 RootContext.MainClass.
6081 2005-03-21 Marek Safar <marek.safar@seznam.cz>
6083 * class.cs (FixedField.Define): Check for CS1664 and more sanity
6086 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
6088 2005-03-18 Marek Safar <marek.safar@seznam.cz>
6090 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
6091 property accessor modifiers.
6093 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
6094 fixed buffer attribute (CS1716).
6095 (PropertyMethod.HasCustomAccessModifier): When property accessor
6096 has custom modifier.
6098 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
6100 (PropertyExpr.DoResolveLValue): Add CS0272.
6102 2005-03-17 Miguel de Icaza <miguel@novell.com>
6104 * convert.cs: When converting to a pointer, use the proper Conv.U
6105 or Conv.I depending on the source data type.
6107 * cs-tokenizer.cs: Make the size for large decimal constants,
6110 2005-03-17 Martin Baulig <martin@ximian.com>
6112 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6113 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6115 2005-03-17 Martin Baulig <martin@ximian.com>
6117 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6118 to bool so we can return an error condition.
6119 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6122 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
6124 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
6127 2005-03-16 Raja R Harinath <rharinath@novell.com>
6129 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
6130 Refactor to avoid traversing the list of assemblies, and to avoid
6131 string concatenation.
6132 * typemanager.cs (guid_attr_type): Remove.
6133 (negative_hits, pointers, references): Remove hashes.
6135 (GetConstructedType): New. Uses type_hash to handle constructed
6136 types (arrays, references, pointers).
6137 (GetReferenceType, GetPointerType): Use it.
6138 (GetNestedType): New. Uses type_hash to handle nested types of
6140 (LookupType, LookupTypeDirect): Remove.
6141 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
6142 'types' hash and LookupTypeReflection directly.
6143 (params_string, params_object): Use GetConstructedType.
6144 * namespace.cs (Namespace.cached_types): New. Cache of reflected
6146 (Namespace.Lookup): Use cached_types.
6147 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
6148 provided by old TypeManager.LookupType.
6149 * rootcontext.cs (MakeFQN): Remove.
6150 * decl.cs (DeclSpace.MakeFQN): Likewise.
6151 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
6152 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6153 TypeManager.GetConstructedType.
6154 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
6156 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
6158 * cs-parser.jay: Fix build.
6160 2005-03-15 Marek Safar <marek.safar@seznam.cz>
6162 * class.cs (TypeContainer.CircularDepException) New nested
6163 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
6165 * cs-parser.jay: Reports CS1527 for any namespace element.
6167 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
6170 * expression.cs (ParameterReference.IsAssigned): Changed error to
6172 (Error_WrongNumArguments): Moved CS0245 detection here.
6174 * statement.cs (Return.Resolve): Add CS1622 report.
6176 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6178 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6180 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6182 * attribute.cs expression.cs: Get rid of some allocations.
6184 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6186 * doc.cs : just eliminate the latest change.
6188 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6190 * doc.cs : commented out the latest change. It breaks xml-030.cs
6192 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6194 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6195 fail. So invoke CreateType() in FindDocumentedType().
6197 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6199 * cs-tokenizer.cs : added IsKeyword().
6200 * doc.cs : Detect keyword incorrectly used as identifier.
6201 Allow identifiers prefixed by @.
6203 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6205 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6206 It caused exception in namespace resolving (again!).
6208 * class.cs (Class.ctor): Removed exit.
6209 (PropertyMethod.ctor): ditto.
6211 * codegen.cs (Codegen.Reset): Reset static data.
6212 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6214 * cs-tokenizer.cs (Cleanup): Removed.
6216 * driver.cs (GetSystemDir): Rewrote to one line command.
6217 It caused problem with unloaded dynamic modules.
6218 (UnixParseOption): Removed Exit.
6219 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6220 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6221 Now can be mcs used as library.
6223 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6226 * location.cs (Reset): Reset static data.
6228 * namespace.cs (Reset): Reset static data.
6230 * report.cs (Report.Reset): Reset static data.
6232 * rootcontext.cs (RootContext.Reset): Reset static data.
6234 * tree.cs (RootTypes.ctor): Use Location.Null
6236 * typemanager.cs (TypeManager.Reset): Reset static data.
6237 (CoreLookupType): Removed Exit.
6238 (TypeHandle.Reset): Reset static data.
6240 2005-03-10 Raja R Harinath <rharinath@novell.com>
6243 * typemanager.cs (ComputeNamespaces): Import namespaces from
6244 referenced modules too.
6246 2005-03-09 Raja R Harinath <rharinath@novell.com>
6248 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6251 2005-03-09 Raja R Harinath <rharinath@novell.com>
6253 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6254 enclosing DeclSpace. This ensures that a name-lookup populates
6255 more caches and there are fewer 'TypeExpression's. Carve out
6256 nested type lookup into ...
6257 (LookupNestedTypeInHierarchy): ... this.
6259 2005-04-15 Martin Baulig <martin@ximian.com>
6261 Merged r41590 from MCS and make it work in the generics land.
6263 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6266 * class.cs (PartialContainer.UpdateConstraints): Removed.
6267 (PartialContainer.CheckConstraints): Removed.
6268 (PartialContainer.SetParameterInfo): Store the constraints here.
6269 (PartialContainer.DefineTypeParameters): New public method;
6270 resolve the type parameter's constraints here. Note that the
6271 PartialContainer doesn't have an EmitContext anymore, so we must
6272 do this in the ClassPart.
6274 2005-03-09 Raja R Harinath <rharinath@novell.com>
6276 Clean up a few partial-class semantics.
6277 Fixes test-357.cs and cs1618-2.cs.
6278 * cs-parser.jay (struct_declaration): Use 'current_class' as
6279 parent of newly-created struct. Remove call to Register ().
6280 Use 'pop_current_class' to complete handing the current struct.
6281 (interface_declaration): Likewise.
6282 (class_declaration): Likewise.
6283 (enum_declaration): Use 'current_class' as parent of newly created
6285 (delegate_declaration): Likewise.
6286 (pop_current_class): New function. This is used to handle closing
6287 up the 'current_class' and 'current_container', and pointing them
6288 to the enclosing class/container.
6289 (CSharpParser): Initialize 'current_class' too.
6290 * decl.cs (MemberCore): Add check for invariant: a partial
6291 container is not a parsed entity, and thus does not enclose any
6293 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6294 (DeclSpace.BaseTypeExpr): Use it.
6295 (DeclSpace.LookupType): Add check for invariant.
6296 * class.cs (TypeContainer): Add check for invariant: a nested
6297 class should have the same NamespaceEntry as its enclosing class.
6298 (TypeContainer.EmitFieldInitializers): Make virtual.
6299 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6301 (TypeContainer.Register): Remove.
6302 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6303 null. Use TypeResolveEmitContext for resolving base types and
6304 interfaces. Move initialization of Parts.TypeBuilder here from
6306 (TypeContainer.DefineNestedTypes): ... here.
6307 (PartialContainer): Take a Namespace not a NamespaceEntry.
6308 (PartialContainer.Create): Don't use Register. Call the
6309 appropriate Add... function directly.
6310 (ClassPart): Take both the PartialContainer and the enclosing
6311 class as constructor arguments.
6312 (ClassPart.EmitFieldInitializers): Override.
6313 (ClassPart.PartFindNestedTypes): Remove.
6314 (FieldBase.GetInitializerExpression): Resolve the initializer
6315 expression in the emit context of the enclosing class.
6316 * tree.cs (RootTypes): Remove Register ().
6318 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6320 * cs-parser.jay: Removed CS0134.
6322 * driver.cs: Removed CS1901.
6324 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6325 for predefined types.
6327 2005-03-07 Duncan Mak <duncan@novell.com>
6329 * codegen.cs (Save): Catch UnauthorizedAccessException as
6330 well. Fixes bug #73454.
6332 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6334 * cs-tokenizer.cs (xtoken): Add CS1035.
6336 * class.cs (MethodData.Define): Add CS0683.
6337 (FieldMember.ctor): Add CS0681.
6339 2005-03-07 Raja R Harinath <rharinath@novell.com>
6341 * ecore.cs (SimpleName.DoResolve): Rename from
6342 SimpleName.DoResolveAllowStatic.
6343 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6344 Pass 'intermediate' flag to MemberStaticCheck.
6345 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6346 of "intermediate" lookups via MemberAccess.
6347 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6348 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6350 2005-03-07 Raja R Harinath <rharinath@novell.com>
6353 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6354 slipped in because of variable names that are identical to a
6355 builtin type's BCL equivalent ('string String;', 'int Int32;').
6356 (PropertyExpr.EmitInstance): Likewise.
6358 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6360 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6362 * report.cs (warning_ignore_table): Made public.
6364 2005-03-04 Raja R Harinath <rharinath@novell.com>
6367 * class.cs (MethodData.Emit): Pass 'container' to
6368 container.GetObsoleteAttribute instead of 'container.Parent'.
6370 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6372 * cs-parser.jay: Add 1534 error test.
6374 * iterators.cs (Yield.CheckContext): Add error 1629.
6375 (Iterator.ctor): Save unsafe modifier.
6376 (MoveNextMethod.DoEmit): Restore unsafe context.
6378 * namespace.cs (UsingAlias): Better error message.
6380 2005-03-03 Dan Winship <danw@novell.com>
6382 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6383 the warning message [#73219]
6385 2005-03-03 Raja R Harinath <rharinath@novell.com>
6387 Fix compile with MCS 1.0.0.0.
6388 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6389 w_restore to not depend on string constant folding.
6391 2005-03-03 Raja R Harinath <rharinath@novell.com>
6393 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6394 CS0246 check to users who passed 'silent = false'.
6395 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6397 (SimpleName.SimpleNameResolve): Update.
6398 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6399 (MemberAccess.IdenticalNameAndTypeName): Update.
6400 * doc.cs (FindDocumentedTypeNonArray): Update.
6402 2005-03-03 Raja R Harinath <rharinath@novell.com>
6404 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6405 * parameters.cs (ComputeAndDefineParameters): Remove.
6406 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6407 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6408 Use GetParameterInfo.
6410 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6412 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6414 2005-03-02 Raja R Harinath <rharinath@novell.com>
6416 Unify DeclSpace.LookupType and DeclSpace.FindType.
6417 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6418 is in charge of defining nested types on demand.
6419 (DeclSpace.LookupType): Use it when the current_type is a
6420 TypeBuilder. Use LookupTypeDirect for reflected types.
6421 (DeclSpace.FindType): Remove.
6422 (DeclSpace.LookupInterfaceOrClass): Likewise.
6423 (DeclSpace.DefineTypeAndParents): Likewise.
6424 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6425 DeclSpace.LookupType.
6426 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6427 * typemanager.cs (LookupType): Simplify.
6428 (AddUserType): Remove type from negative_hits.
6429 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6430 * class.cs (TypeContainer.FindMembers): Move handling of nested
6432 (TypeContainer.FindMembers_NestedTypes): ... here.
6433 (TypeContainer.FindNestedType): Implement override.
6434 (ClassPart.FindNestedType): Delegate to PartialContainer.
6435 (ClassPart.PartFindNestedType): Looks up the nested types of the
6438 2005-04-14 Martin Baulig <martin@ximian.com>
6440 * generic.cs (ConstructedType): Moved all the type lookup and
6441 nested class logic into SimpleName.
6442 (ConstructedType.ResolveConstructedType): Our underlying type is
6443 already fully resolved; all the type lookup stuff is in
6446 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6447 constructed types here instead of in ConstructedType.
6449 * decl.cs (MemberName.GetTypeExpression): Always create a
6450 SimpleName, not a ConstructedType.
6451 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6453 2005-03-02 Martin Baulig <martin@ximian.com>
6455 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6456 static constructor in static classes.
6458 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6460 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6461 sizeParamIndex is not specified.
6463 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6466 * report.cs (WarningMessage.IsEnabled): Missing null check.
6468 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6470 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6471 in the fields and not in the properties.
6473 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6475 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6478 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6480 * attribute.cs: Small refactoring (improved robustness).
6481 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6482 (ValidateGuid): Removed.
6483 (Resolve): Removed referenced to above mentioned.
6484 (GetAttributeUsage): Made private and changed to work without
6486 (GetIndexerAttributeValue): Don't crash.
6487 (GetConditionalAttributeValue): Ditto.
6488 (GetClsCompliantAttributeValue): Ditto.
6489 (ExtractSecurityPermissionSet): All attributes exceptions are
6491 (GetPropertyValue): New helper.
6492 (GetMethodImplOptions): New method.
6493 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6494 some missing properties.
6496 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6497 (Method.ApplyAttributeBuilder): Updated.
6499 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6502 2005-02-28 Raja R Harinath <rharinath@novell.com>
6505 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6506 non-simple types (array, pointer, reference).
6508 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6510 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6512 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6514 (Method.CheckBase): Catch wrong destructor here.
6515 (MethodData.Define): Add errors 550, 668.
6517 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6519 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6521 * pending.cs (VerifyPendingMethods): Add error 551.
6523 * typemanager.cs (CSharpName): Next error report helper.
6525 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6527 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6528 attributes. Removed useless attribute double check.
6529 It saves almost 2MBs for corlib.
6531 2005-02-25 Raja R Harinath <rharinath@novell.com>
6534 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6535 called twice in case of error.
6537 2005-02-23 Chris Toshok <toshok@ximian.com>
6539 Fix compiler portions of #72827.
6540 * statement.cs (Block.Emit): call Begin/EndScope on the
6541 EmitContext instead of the ILGenerator.
6543 * codegen.cs (EmitContext.BeginScope): new method, call
6544 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6546 (EmitContext.BeginScope): same, but EndScope and CloseScope
6548 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6549 offset and call the superclass's OpenScope(int) with it.
6550 (SymbolWriter.CloseScope): get the current il
6551 offset and call superclass's CloseScope(int) with it.
6553 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6555 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6556 CS1677 for out and ref as well.
6558 * class.cs (Method.Define): Add error CS1599 detection.
6560 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6562 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6564 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6566 * support.cs.cs (ModifierDesc): New helper method.
6568 2005-02-23 Raja R Harinath <rharinath@novell.com>
6569 Abin Thomas <projectmonokochi@rediffmail.com>
6570 Anoob V E <projectmonokochi@rediffmail.com>
6571 Harilal P R <projectmonokochi@rediffmail.com>
6574 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6575 MemberLookup (used for error reporting) actually returns a result.
6576 Fix error report number (122, not 112).
6578 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6579 Anoob V E <projectmonokochi@rediffmail.com>
6580 Harilal P R <projectmonokochi@rediffmail.com>
6583 * pending.cs (PendingImplementation.GetAbstractMethods):
6584 Find NonPublic members too.
6586 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6588 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6591 * class.cs (MethodCore.CheckMethodAgainstBase):
6592 Add error 239 report.
6594 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6596 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6598 * class.cs (Operator.Define): Add error 217 report.
6600 2005-02-21 Raja R Harinath <rharinath@novell.com>
6603 * expression.cs (Invocation.IsApplicable): Make public.
6604 (Invocation.IsParamsMethodApplicable): Likewise.
6605 * delegate.cs (Delegate.VerifyApplicability): Don't use
6606 Invocation.VerifyArgumentCompat for parameter applicability
6607 testing. Use Invocation.IsApplicable and
6608 Invocation.IsParamsMethodApplicable.
6610 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6612 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6614 * class.cs (Operator.Define): Add error 217 report.
6616 2005-02-21 Raja R Harinath <rharinath@novell.com>
6618 * namespace.cs (UsingEntry.Resolve): Undo change below.
6620 2005-02-21 Raja R Harinath <rharinath@novell.com>
6623 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6624 disable the error message when the extended MemberLookup also
6626 (Expression.MemberLookupFinal): Update.
6627 (SimpleName.DoSimpleNameResolve): Update.
6628 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6629 Don't use MemberLookupFinal.
6630 (New.DoResolve): Update.
6631 (BaseAccess.CommonResolve): Update.
6633 2005-02-21 Raja R Harinath <rharinath@novell.com>
6636 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6637 occured previously, don't resolve again.
6639 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6642 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6643 argument. Call ResolveAttributeUsage for unresolved.
6644 when types doesn't match ctor arguments.
6646 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6647 for nested attribute classes.
6648 (Class.attribute_usage): Removed.
6649 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6650 for attribute class.
6652 * ecore.cs (IsAttribute): Removed.
6654 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6656 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6658 (attribute_types): Removed.
6659 (EmitCode): Global attributes are emited as the latest.
6661 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6663 * class.cs (EmitFieldInitializers): Don't emit field initializer
6664 for default values when optimilization is on.
6666 * constant.cs (Constant.IsDefaultValue): New property.
6668 * driver.cs: Add /optimize handling.
6672 * literal.cs: Implement new IsDefaultValue property.
6674 * rootcontext.cs (Optimize): New field, holds /optimize option.
6676 2005-02-18 Raja R Harinath <rharinath@novell.com>
6678 Fix crasher in re-opened #72347.
6679 * namespace.cs (Namespace.Lookup): Return null if
6680 DeclSpace.DefineType returns null.
6683 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6685 2005-02-18 Raja R Harinath <rharinath@novell.com>
6687 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6688 now returns null if it cannot resolve to an lvalue.
6689 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6690 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6691 returned null. Remove check for SimpleName.
6692 (EventExpr.DoResolveLValue): New.
6693 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6694 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6696 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6698 (Unary.ResolveOperator): Move CS0211 check ...
6699 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6701 (Unary.DoResolveLValue): Simplify.
6702 (AddressOf.DoResolveLValue): New.
6703 (ArrayAccess.DoResolveLValue): New.
6705 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6707 * attribute.cs (Attribute.Resolve): Add arguments casting for
6708 when types doesn't match ctor arguments.
6710 2005-02-16 Raja R Harinath <rharinath@novell.com>
6712 Fix parts of #63202.
6713 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6714 lookup of operator in base type. Ensure that all checks happen
6715 when the operator resolves to an "op_..." method.
6717 2005-02-15 Raja R Harinath <rharinath@novell.com>
6720 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6721 'ignore_cs0104' parameter. Pass it to ...
6722 (NamespaceEntry.Lookup): ... this.
6723 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6724 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6725 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6726 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6727 Update. Request that cs0104 errors be ignored.
6728 (ComposedCast.ResolveAsTypeStep): Update.
6730 2005-02-14 Raja R Harinath <rharinath@novell.com>
6733 * expression.cs (Invocation.BetterFunction): Remove support for
6734 comparing virtual functions and their overrides.
6735 (Invocation.IsOverride): New.
6736 (Invocation.OverloadResolve): Don't consider 'override' functions
6737 during candidate selection. Store them in a lookaside list.
6738 If the selected method is a 'virtual' function, use the list to
6739 find any overrides that are closer to the LHS type.
6741 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6743 * expression.cs (New.DoResolve): Add complex core type reduction.
6744 (New.Constantify): Converts complex core type syntax like 'new int ()'
6747 2005-02-14 Raja R Harinath <rharinath@novell.com>
6749 * decl.cs (EntryType.EntryType): New constructor to create an
6750 updated copy of a cache entry.
6751 (MemberCache.AddMethods): Use it.
6752 (MemberCache.ClearDeclaredOnly): Remove.
6753 (MemberCache.MemberCache): Update.
6755 2005-02-11 Miguel de Icaza <miguel@novell.com>
6757 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6758 variable. This one is represents the actual low-level declaration
6759 of the method, as opposed to the semantic level `IsStatic'.
6761 An anonymous method which is hosted into a static method might be
6762 actually an instance method. IsStatic would reflect the
6763 container, while MethodIsStatic represents the actual code
6766 * expression.cs (ParameterReference): Use the new MethodIsStatic
6767 instead of IsStatic.
6769 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6770 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6771 set on the current EmitContext.
6773 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6774 resolve our casted expression as an LValue. This triggers the
6775 proper LValue processing that is later required by Assign.
6779 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6781 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6783 C# 2.0 Fixed buffer implementation
6785 * anonymous.cs: Update after RegisterHelperClass renaming.
6787 * attribute.cs (AttributeTester.fixed_buffer_cache):
6788 Cache of external fixed buffers.
6789 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
6790 implementation if field is fixed buffer else null.
6793 (TypeContainer.AddField): Accept FieldMember instead of Field.
6794 (FieldBase.IsFieldClsCompliant): Extracted code from
6795 VerifyClsCompliance descendant customization.
6796 (FixedField): New class handles fixed buffer fields.
6797 (FixedFieldExternal): Keeps information about imported fixed
6799 (IFixedField): Make access to internal or external fixed buffer
6802 * cs-parser.jay: Add fixed buffer parsing.
6804 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
6807 * expression.cs (Indirection): Extended implementation to accept
6809 (PointerArithmetic.Emit): Get element from fixed buffer as well.
6810 (ElementAccess.MakePointerAccess): Get type as parameter.
6811 (DoResolve): Add fixed buffer field expression conversion.
6812 (DoResolveLValue): Ditto.
6813 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
6814 (ArrayPtr): Derives from FixedBufferPtr.
6815 (ArrayPtr.Emit): Add extra emit for array elements.
6817 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
6819 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
6820 for compiler generated types.
6821 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
6823 * statement.cs (Fixed): Refactored to be easier add fixed buffer
6824 and consume less memory.
6825 (Fixed.Resolve): Add fixed buffer case.
6827 * typemanager.cs (compiler_generated_attr_ctor,
6828 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
6829 (HasElementType): Add our own implementation to work on every
6832 2005-02-11 Miguel de Icaza <miguel@novell.com>
6834 * anonymous.cs (CaptureContext): Track whether `this' has been
6837 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
6838 only captured `this' if it was implicitly done (instance
6839 methods/variables were used).
6841 * codegen.cs (EmitContext.CaptureThis): New method to flag that
6842 `this' must be captured.
6844 2005-01-30 Miguel de Icaza <miguel@novell.com>
6846 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
6847 is null it means that there has been no need to capture anything,
6848 so we just create a sibling.
6850 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
6852 Just a partial fix. The other half is fairly elusive.
6854 2005-02-10 Raja R Harinath <rharinath@novell.com>
6856 Fix #52586, cs0121-4.cs.
6857 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
6858 and return a hashtable.
6859 (MemberCache.ClearDeclaredOnly): New.
6860 (MemberCache.MemberCache): Update to change. Make a deep copy of
6861 the method_hash of a base type too.
6862 (MemberCache.AddMethods): Adapt to having a deep copy of the base
6863 type methods. Overwrite entries with the same MethodHandle so
6864 that the ReflectedType is correct. The process leaves in base
6865 virtual functions and their overrides as distinct entries.
6866 (CacheEntry): Now a class instead of a struct. It shouldn't alter
6867 matters since it was boxed in a ArrayList before.
6868 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
6870 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
6871 case of a virtual function and its override (choose the overload
6873 (Invocation.OverloadResolve): Avoid 'override' members during
6874 'applicable_type' calculation.
6876 2005-03-28 Raja R Harinath <rharinath@novell.com>
6878 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
6879 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
6880 GetTypeHandle. It is possible for a reflected type to derive from
6881 a TypeBuilder (e.g., int[] derives from the TypeBuilder
6882 System.Array during mscorlib compilation).
6883 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
6884 contain a method_hash, don't create one either. Don't create a
6885 deep copy of the base cache's method_hash.
6886 (MemberCache.SetupCache): Rename back from DeepCopy.
6887 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
6888 already initialized. If we see an override function, add its
6889 underlying base virtual function to the member_hash too.
6891 2005-02-09 Raja R Harinath <rharinath@novell.com>
6893 Combine two near-redundant caches.
6894 * typemanager.cs (method_params): Rename from method_internal_params.
6895 (TypeManager.GetParameterData): New. Replace
6896 Invocation.GetParameterData.
6897 (TypeManager.LookupParametersByBuilder): Remove.
6898 * expression.cs (Invocation.method_parameter_cache): Remove.
6899 (Invocation.GetParameterData): Remove.
6901 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
6904 2005-02-08 Raja R Harinath <rharinath@novell.com>
6907 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
6908 TypeManager.multicast_delegate_type is null, resolve it by looking
6909 up "System.MulticastDelegate".
6910 * rootcontext.cs (RootContext.ResolveCore): Simplify.
6912 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
6913 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
6914 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
6917 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
6918 (LabeledStatement.AddReference): New. Set 'referenced'.
6919 (Goto.Resolve): Use it.
6921 2005-02-05 John Luke <john.luke@gmail.com>
6923 * driver.cs: remove duplicate -doc line in Usage ()
6925 2005-02-04 Raja R Harinath <rharinath@novell.com>
6927 * location.cs (Location.AddFile): Fix CS2002 error report.
6929 2005-02-02 Martin Baulig <martin@ximian.com>
6931 * delegate.cs (Delegate.DefineType): Report an internal error if
6932 TypeManager.multicast_delegate_type is null. See bug #72015 for
6935 2005-02-02 Raja R Harinath <rharinath@novell.com>
6937 Fix a crasher in a variant of #31984.
6938 * const.cs (Constant.CheckBase): New override that defers the
6939 new-or-override check in case the base type hasn't been populated
6941 (Constant.Define): Ensure the new-or-override check is performed.
6943 2005-02-01 Duncan Mak <duncan@ximian.com>
6945 * const.cs (LookupConstantValue): Check that `ce' is not null
6946 before calling GetValue ().
6948 2005-02-01 Raja R Harinath <rharinath@novell.com>
6950 Fix test-334.cs (#69519).
6951 * cs-parser.jay (using_alias_directive): Pass in an expression to
6952 NamespaceEntry.UsingAlias.
6953 (using_namespace_directive): Pass in an expression to
6954 NamespaceEntry.Using.
6955 (namespace_name): Don't flatten to a string.
6956 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
6957 (NamespaceEntry.AliasEntry.Resolve): Lookup using
6959 (NamespaceEntry.UsingEntry): Likewise.
6960 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
6962 (NamespaceEntry.LookupForUsing): Remove.
6963 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
6965 (NamespaceEntry.Lookup): Remove support for dotted names.
6967 2005-02-01 Raja R Harinath <rharinath@novell.com>
6969 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
6971 (NamespaceEntry.ImplicitParent): Compute on demand.
6972 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
6973 parallels the current.
6974 (NamespaceEntry.LookupForUsing): Use it.
6975 (NamespaceEntry.Lookup): If the current namespace-entry is
6976 implicit, don't search aliases and using tables.
6978 2005-02-01 Raja R Harinath <rharinath@novell.com>
6981 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
6983 (TypeContainer.BaseCache): Compute on demand.
6984 (TypeContainer.FindMembers): Define constants and types if they're
6985 not already created.
6986 (FieldMember.Define): Move resetting of ec.InUnsafe before error
6988 * const.cs (Constant.Define): Make idempotent.
6990 2005-01-29 Miguel de Icaza <miguel@novell.com>
6992 * pending.cs: Produce better code (no nops produced by using Ldarg
6995 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
6996 i - 1' it should be arg + 1.
7000 2005-01-28 Raja R Harinath <rharinath@novell.com>
7002 * attribute.cs (Attribute.CheckAttributeType): Make private
7004 (Attribute.ResolveType): Make virtual.
7005 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
7006 handling of RootContext.Tree.Types.
7008 2005-01-27 Raja R Harinath <rharinath@novell.com>
7010 Update attribute-handling to use the SimpleName/MemberAccess
7012 * cs-parser.jay (attribute): Pass in an expression to the
7013 constructors of Attribute and GlobalAttribute.
7014 * attribute.cs (Attribute): Take an expression for the name.
7015 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
7016 passed in attribute name expression.
7017 (Attribute.CheckAttributeType): Use it.
7018 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
7019 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
7020 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
7021 argument to prevent error messages if the lookup fails.
7023 2005-01-27 Marek Safar <marek.safar@seznam.cz>
7025 * expression.cs (Indirection): Implemented IVariable interface
7026 to support indirection in AddressOf operator.
7027 (PointerArithmetic.Emit): Add optimalization for case where
7028 result can be precomputed.
7030 2005-01-26 Martin Baulig <martin@ximian.com>
7032 * class.cs (TypeContainer.AttributeTargets): Return the correct
7033 AttributeTargets depending on our `Kind' instead of throwing an
7034 exception; fixes #71632.
7036 2005-01-26 Marek Safar <marek.safar@seznam.cz>
7039 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
7042 2005-03-17 Martin Baulig <martin@ximian.com>
7044 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
7045 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
7047 2005-03-17 Martin Baulig <martin@ximian.com>
7049 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
7050 to bool so we can return an error condition.
7051 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
7054 2005-03-17 Martin Baulig <martin@ximian.com>
7056 * generic.cs (TypeMananager.IsIEnumerable): New public method.
7058 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
7059 converting from an array-type of T to `IEnumerable<T>'.
7061 2005-03-16 Martin Baulig <martin@ximian.com>
7063 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
7064 (Nullable.LiftedUnaryMutator): New public class.
7066 * expression.cs (UnaryMutator.DoResolve): Added support for
7069 2005-03-14 Martin Baulig <martin@ximian.com>
7071 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
7073 2005-03-14 Martin Baulig <martin@ximian.com>
7075 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
7076 the comparision operators `<', `>', `<=' and `>='.
7078 2005-03-13 Martin Baulig <martin@ximian.com>
7081 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
7082 avoid confusion with the `NullLiteral'.
7083 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
7085 2005-03-13 Martin Baulig <martin@ximian.com>
7087 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
7088 comparing arbitrary types with the null literal.
7090 2005-03-13 Martin Baulig <martin@ximian.com>
7092 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
7093 boolean operators '&&', '||', '&' and '|'.
7094 (Nullable.OperatorTrueOrFalse): New public class.
7096 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
7097 instead of a `StaticCallExpr'; added support for nullables.
7099 2005-03-10 Martin Baulig <martin@ximian.com>
7102 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
7103 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
7105 2005-03-07 Martin Baulig <martin@ximian.com>
7107 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
7108 it work if `expr' is not an IMemoryLocation.
7109 (Nullable.Lifted): Implement IMemoryLocation.
7110 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
7113 2005-03-05 Martin Baulig <martin@ximian.com>
7115 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
7116 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
7117 (Nullable): Added support for lifted unary and binary operators.
7119 * expression.cs (Unary.DoResolve): Added support for nullable types.
7120 (Binary.DoResolve): Likewise.
7121 (Conditional.DoResolve): Likewise.
7123 2005-03-02 Martin Baulig <martin@ximian.com>
7125 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
7127 * class.cs (ClassPart.SetParameterInfo): Override this.
7128 (PartialContainer.SetParameterInfo): Override this.
7129 (TypeContainer.CheckConstraints): New protected method.
7130 (PartialContainer.CheckConstraints): Override this and check
7131 whether the same contraints were specified in all parts of a
7132 partial generic type definition.
7133 (PartialContainer.UpdateConstraints): New public method.
7135 * generic.cs (TypeParameter.UpdateConstraints): New public method.
7137 2005-03-02 Martin Baulig <martin@ximian.com>
7139 Committing a patch from Carlos Alberto Cortez to fix #72887.
7141 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
7142 casts from `T []' to `int []'.
7144 2005-03-02 Martin Baulig <martin@ximian.com>
7146 * generic.cs (TypeManager.IsEqual): Make this symmetric.
7148 * expression.cs (Binary.ResolveOperator): When resolving a
7149 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
7150 `=='. Fixes #71866. See gen-127.cs.
7152 2005-03-02 Martin Baulig <martin@ximian.com>
7154 * class.cs (TypeContainer.DoDefineMembers): We also need a default
7155 static constructor in static classes.
7157 2005-03-02 Martin Baulig <martin@ximian.com>
7160 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
7161 (Nullable.LiftedConversion): Added support for user-defined
7164 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
7166 * cs-parser.jay: Use ComposedCast everywhere instead of
7167 NullableType, so we don't need to check for NullableType
7169 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
7170 case where we'll be resolved into a `parenthesized_expression_0'
7174 (Convert.UserDefinedConversion): Added nullable conversions.
7176 2005-02-28 Martin Baulig <martin@ximian.com>
7178 * generic.cs (TypeManager.IsNullableType): New static method.
7179 (Nullable): New abstract class.
7180 (Nullable.NullLiteral): New public class.
7181 (Nullable.LiftedConversion): New public class.
7183 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7184 `builtin_types opt_nullable'.
7187 (Convert.ImplicitConversionStandard): Added nullable conversions.
7188 (Convert.ExplicitConversionStandard): Likewise.
7189 (Convert.ExplicitConversion): Likewise.
7191 2005-02-26 Martin Baulig <martin@ximian.com>
7193 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7194 begin with a "?", for instance "?[]". Don't do a type lookup if
7197 2005-02-25 Martin Baulig <martin@ximian.com>
7199 The first part of Nullable Types :-)
7201 * generic.cs (NullableType): New public class.
7202 (NullCoalescingOperator): New public class.
7203 (TypeArguments.Resolve): Add a CS0306 check.
7205 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7206 (opt_nullable): New rule.
7207 (type): Added `opt_nullable' to `namespace_or_type_name',
7208 `builtin_types' and `pointer_type'.
7209 (array_type): Added `opt_nullable'.
7210 (opt_rank_specifier_or_nullable): New rule; this is the
7211 combination of `opt_rank_specifier' and `opt_nullable'.
7212 (opt_error): New rule; catch errors here.
7213 (nullable_type_or_conditional): New rule; we use this to check for
7214 nullable and still detect the conditional operator.
7215 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7216 instead `opt_rank_specifier'.
7218 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7221 2005-02-24 Martin Baulig <martin@ximian.com>
7223 * README, README.Changes: Removed; they're old and obsolete.
7225 2005-02-22 Martin Baulig <martin@ximian.com>
7227 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7228 returned an error, set `constraints' to null to avoid a crash
7230 (TypeParameter.ResolveType): Likewise.
7232 2005-02-22 Martin Baulig <martin@ximian.com>
7235 (Constraints.ResolveTypes): Protect against being called twice.
7236 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7237 (TypeParameter.ResolveType): New public method; calls
7238 constraints.ResolveTypes().
7239 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7240 into the new ResolveType().
7241 (GenericMethod.Define): Call ResolveType() on all our
7244 2005-02-21 Martin Baulig <martin@ximian.com>
7247 (TypeManager.generic_nullable_type): New static public field.
7248 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7251 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7253 2005-02-15 Martin Baulig <martin@ximian.com>
7255 * generic.cs (ConstructedType.Constraints): Correctly check
7256 constraints if the argument type is a type parameter; fixes
7259 2005-02-02 Martin Baulig <martin@ximian.com>
7261 * delegate.cs (Delegate.DefineType): Report an internal error if
7262 TypeManager.multicast_delegate_type is null. See bug #72015 for
7265 2005-01-29 Miguel de Icaza <miguel@novell.com>
7267 * pending.cs: Produce better code (no nops produced by using Ldarg
7270 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7271 i - 1' it should be arg + 1.
7275 2005-01-26 Martin Baulig <martin@ximian.com>
7277 * cs-parser.jay (indexer_declarator): Don't report an error if we
7278 have type parameters since we can be an explicit interface
7279 implementation; fixes #71449.
7281 2005-01-26 Martin Baulig <martin@ximian.com>
7283 * class.cs (TypeContainer.AttributeTargets): Return the correct
7284 AttributeTargets depending on our `Kind' instead of throwing an
7285 exception; fixes #71632.
7287 2005-01-26 Martin Baulig <martin@ximian.com>
7289 * delegate.cs (Delegate.DefineType): Correctly define our type
7290 parameters. Fixes #71483.
7292 2005-01-25 Raja R Harinath <rharinath@novell.com>
7295 * expression.cs (MemberAccess.DoResolve): Don't complain with
7296 cs0572 when the LHS of a member access has identical name and type
7299 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7302 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7304 Create custom PermissionSet only for PermissionSetAttribute.
7306 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7309 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7310 delegates in static class.
7312 2005-01-24 Martin Baulig <martin@ximian.com>
7314 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7315 merging an implicit block, just use its reachability.
7317 * statement.cs (Block.Resolve): Make the unreachable code check
7318 work wrt. implicit blocks; see test-337 from #63842.
7320 2005-01-21 Alp Toker <alp@atoker.com>
7322 * cs-parser.jay: destructor_declaration's container is PartialContainer
7323 not Class when partial types are used, so use Kind prop instead of
7326 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7328 * cs-parser.jay: Improve error reporting when an interface
7331 2005-01-20 Dick Porter <dick@ximian.com>
7333 * support.cs: SeekableStreamReader fix from Sandor Dobos
7334 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7335 chars are read. Fixes bug 70369.
7337 2005-01-20 Raja R Harinath <rharinath@novell.com>
7339 * cs-parser.jay (catch_clause): Simplify current_block handling
7342 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7344 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7345 code with ImplicitStandardConversion to handle the implicit
7346 conversion of method groups into valid delegate invocations.
7348 The problem is that in parameter handling we were using this code
7349 path. Fixes bug #64698
7351 2005-01-19 Raja R Harinath <rharinath@novell.com>
7353 * cs-parser.jay: Fix several infelicities.
7354 - Avoid assigning to the parser value stack. Code like
7355 '$3 = null' is unclean. Synthesize a value for the code block
7357 - Avoid using oob_stack for storing location information. Use ...
7358 (_mark_): ... this. New (empty) rule. Saves the current location
7360 (foreach_statement): Avoid using oob_stack for current_block
7361 handling. Use technique used in for_statement and
7362 using_statement. Synthesize a value for the code block to store
7363 additional intermediate information.
7365 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7367 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7368 of a different type is only allowed to private fields of a
7369 containing type, not on fields of a base class.
7371 See test-174.cs and error cs0122-9.cs
7373 2005-01-13 Raja R Harinath <rharinath@novell.com>
7375 Fix test-335.cs (bug #58126).
7376 * cs-parser.jay (argument): Split out non-expression parts of the
7377 rule into 'non_simple_argument'.
7378 (invocation_expression): Support parenthesized invocations with
7379 multiple arguments, and with single non-simple arguments.
7381 2005-01-13 Raja R Harinath <rharinath@novell.com>
7383 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7386 2005-01-12 Raja R Harinath <rharinath@novell.com>
7388 Fix cs0038-1.cs, cs1640-6.cs.
7389 * ecore.cs (Expression.Resolve): Remove special-case for
7390 SimpleName in error-handling.
7391 (Expression.almostMatchedMembers): Relax access permission to
7393 (Expression.MemberLookupFailed): Handle duplicates in
7394 almostMatchedMembers list.
7395 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7396 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7397 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7398 overload if the passed in MemberInfo is a MethodBase.
7400 2005-01-25 Martin Baulig <martin@ximian.com>
7403 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7405 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7408 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7409 for non-CAS & merge permission sets properly.
7411 2005-01-11 Raja R Harinath <rharinath@novell.com>
7413 Improve standard-compliance of simple name and member access
7414 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7415 * ecore.cs (FullNamedExpression): New abstract base class
7416 for Namespaces and TypeExpressions.
7417 (ResolveFlags.SimpleName): Remove.
7418 (SimpleName): Remove support for dotted names.
7419 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7420 DeclSpace.FindType and DeclSpace.LookupType.
7421 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7422 (Expression.ExprClassName): Make member function.
7423 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7424 a namespace. Remove creation of dotted "SimpleName"s.
7425 (MemberAccess.DoResolve): Likewise.
7426 * decl.cs (DeclSpace.Cache): Make private.
7427 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7428 (DeclSpace.FindType): Update.
7429 (DeclSpace.LookupType): Move here from RootContext. Return a
7430 FullNamedExpression.
7431 * namespace.cs (Namespace): Derive from FullNamedExpression
7432 so that it can be part of expression resolution.
7433 (Namespace.Lookup): Return an FullNamedExpression.
7434 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7436 * rootcontext.cs (NamespaceLookup): Remove.
7437 (LookupType): Move to DeclSpace.
7438 * attribute.cs (CheckAttributeType): Update.
7439 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7440 (FindDocumentedTypeNonArray): Likewise.
7442 2005-01-11 Raja R Harinath <rharinath@novell.com>
7444 Fix cs0509.cs, cs1632.cs.
7445 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7446 is the same as IsInterface.
7447 (TypeContainer.GetClassBases): Likewise.
7448 * statement.cs (LabeledStatement.ig): New field.
7449 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7451 (LabeledStatement.DoEmit): Check that the label was created with
7452 the same ILGenerator.
7454 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7457 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7458 accessors to its properties.
7460 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7461 from accessors to property.
7463 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7466 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7469 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7471 * attribute.cs: Check for null and empty strings.
7473 I have lost another battle to Paolo.
7475 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7478 * class.cs (PropertyMethod): Set Parent field in ctors.
7479 (SetMethod.InternalParameters): Add unsafe switch hack.
7480 Override MarkForDuplicationCheck where it is appropriate.
7482 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7483 It says whether container allows members with the same name.
7485 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7486 Removed is_method parameter.
7488 2005-01-06 Duncan Mak <duncan@ximian.com>
7490 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7491 because the previous change led to incorrect reporting of CS1032
7492 ("Cannot define/undefine preprocessor symbols after first token in
7493 file"). Instead of using `tokens_seen' as the only flag that
7494 triggers CS1040, introduce `comments_seen'. This new flag is used
7495 to signify having seen comments on the current line, so it is
7496 unset after a newline.
7498 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7500 * doc.cs : When searching for a type, find nested type too.
7501 This fixes bug #71040.
7503 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7506 - Warn missing member comment on those classes which also does not
7507 have doc comments. Fixed bug #71041.
7508 - Don't warn missing doc comment on default constructor.
7511 2005-01-06 Duncan Mak <duncan@ximian.com>
7513 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7514 comments, set `tokens_seen' to true. This allows us to detect
7515 misplaced preprocessor directives (i.e. not at the beginning of
7516 the a line, nor after whitespaces). In that case, report error
7517 CS1040. This fixes bug #56460.
7519 * cs-parser.jay (interface_member_declaration): Add checks for
7520 IsExplicitImpl, and report CS0541 error if an interface member is
7521 defined as an explicit interface declaration.
7523 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7526 * class.cs (PropertyMethod): Set Parent field in ctors.
7527 (SetMethod.InternalParameters): Add unsafe switch hack.
7529 * decl.cs (MemberCore.Parent): Cannot be readonly.
7531 2005-01-06 Raja R Harinath <rharinath@novell.com>
7533 * decl.cs (DeclSpace.ResolveType): Remove.
7534 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7535 Merge in code from ...
7536 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7537 * class.cs, enum.cs: Update to changes.
7539 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7541 * anonymous.cs: Ensure that we init the scope of our parent if it
7542 has not been initialized yet.
7544 2004-12-30 Duncan Mak <duncan@ximian.com>
7546 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7547 if field.FieldBuilder is null. Fixes #70758.
7549 * convert.cs: Fixed some typos and updated some of the comments.
7550 (ImplicitStandardConversionExists):
7551 (TryImplicitIntConversion): If `target_type' is an interface and
7552 the type of `ic' implements this interface, return true or a new
7553 BoxedCast instead of null. This fixes #70468.
7555 2004-12-29 Duncan Mak <duncan@ximian.com>
7557 * expression.cs (Argument.Emit): Check that Expr is
7558 IMemoryLocation before casting to it, and report CS1510 otherwise.
7562 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7564 * statement.cs (Block.ThisVariable): remove the recursion here, to
7565 make the --profile more sane.
7567 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7569 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7570 assembly, by JB Evain.
7572 2004-12-17 Raja R Harinath <rharinath@novell.com>
7574 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7575 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7576 "parent" refers to enclosing type/class. "base" refers to superclass.
7578 2004-12-17 Raja R Harinath <rharinath@novell.com>
7580 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7581 Ensure that we only have GlobalAttributes.
7582 * attribute.cs (Attribute.Emit): Make non-virtual.
7583 (GlobalAttribute.Emit): Remove.
7584 (Attribute.Resolve): Make virtual.
7585 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7586 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7587 the argument. Don't create one.
7588 (Attribute.GetObsoleteAttribute): Likewise.
7589 (Attribute.GetClsCompliantAttributeValue): Likewise.
7590 * class.cs, decl.cs: Update to changes.
7592 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7594 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7596 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7598 * statement.cs (Foreach.Resolve): Add error 186 report.
7600 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7602 * expression.cs (Conditional.DoResolve): Add warning 429.
7604 * statement.cs (If.Resolve): Add warning 665.
7606 2004-12-16 Raja R Harinath <rharinath@novell.com>
7608 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7609 except when in the parser, and in GlobalAttribute.
7610 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7611 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7612 RootContext.Tree.Types.NamespaceEntry once work is done.
7613 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7614 and resets RootContext.Tree.Types.NamespaceEntry.
7616 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7618 * cs-parser.jay: Don't create a block for every variable.
7620 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7622 * location.cs: Provide extra information.
7624 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7625 variables from the captured environment, it is the ldarg_0.
7627 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7629 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7632 * class.cs: Changed warning level for 169 to avoid developer
7633 displeasure from warning flooding. It will be changed back when they
7634 fix most of current BCL warnings.
7636 * RootContext.cs: Pushed default WarningLevel to 3.
7638 * statement.cs: Removed unused variable.
7640 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7642 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7643 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7644 Add error 502 report.
7645 (StaticClass.DefineType): Add error 441 report.
7646 (Class.AllowedModifiersProp): New virtual property as temporary
7647 extension to AllowedModifiers.
7648 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7649 to share implementation with StaticClass and don't call virtual
7652 * driver.cs (MainDriver): Add error 1558 test.
7654 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7655 report. Moved error 36 test here.
7657 * statement.cs (Throw.Resolve): Add error 724 report.
7659 * typemanager.cs: Add out_attribute_type core type.
7661 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7663 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7665 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7667 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7670 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7672 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7673 Add error 3023 report.
7674 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7676 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7679 2004-12-12 John Luke <john.luke@gmail.com>
7681 * driver.cs (AddArgs): take -- into account when
7682 adding arguments, fixes bug 65710
7684 2004-12-12 Martin Baulig <martin@ximian.com>
7686 * expression.cs (Unary.TryReduceNegative): Added support for
7687 SByteConstant and ByteConstant.
7688 (Unary.Reduce): Check error values from TryReduceNegative().
7690 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7692 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7693 and report exception as error 182.
7695 2004-12-10 Raja R Harinath <rharinath@novell.com>
7697 * driver.cs (Main): Fix message when there are warnings.
7699 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7701 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7703 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7705 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7706 Reduced number of warnings.
7708 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7710 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7712 * driver.cs: Removed message.
7714 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7716 2004-12-08 <vargaz@freemail.hu>
7718 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7720 2004-12-08 Martin Baulig <martin@ximian.com>
7722 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7723 instead of a CS3002 for properties and indexer.
7725 2004-12-08 Martin Baulig <martin@ximian.com>
7727 * decl.cs (MemberName.ToString): Make this work again.
7729 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7731 * attribute.cs (Resolve): Add error 591 detection.
7733 * class.cs (FieldMember.Define): Add error 1547 detection.
7734 (Indexer.Define): Add error 620 detection.
7735 (Operator.Define): Add error 590 detection.
7737 * ecore.cs: Missing argument for error 79.
7739 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7742 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7745 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7748 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7750 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7751 Some operator comments were suppressed.
7752 * doc.cs : Implicit/explicit operator name in doc comments are like
7753 "op_Explicit(type)~returnType", so added suffix handling.
7755 2005-01-21 Alp Toker <alp@atoker.com>
7757 * cs-parser.jay: destructor_declaration's container is PartialContainer
7758 not Class when partial types are used, so use Kind prop instead of 'is'.
7760 2004-12-12 Martin Baulig <martin@ximian.com>
7762 * expression.cs (Unary.TryReduceNegative): Added support for
7763 SByteConstant and ByteConstant.
7764 (Unary.Reduce): Check error values from TryReduceNegative().
7766 2004-12-11 Martin Baulig <martin@ximian.com>
7768 * support.cs (ReflectionParameters.ParameterName): If we have a
7769 `gpd', call `ParameterName' on it.
7771 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7773 * pending.cs (PendingImplementation.DefineProxy): Call
7774 DefineParameter() for all of the MethodBuilder's arguments.
7776 2004-12-09 Martin Baulig <martin@ximian.com>
7778 * doc.cs (DocUtil): Make this a static class.
7780 2004-12-09 Martin Baulig <martin@ximian.com>
7782 * expression.cs (Invocation.InferType): Moved the type inference
7783 implementation into TypeManager.
7785 * generics.cs (TypeManager): Moved the type inference
7786 implementation here.
7788 2004-12-09 Martin Baulig <martin@ximian.com>
7790 * typemanager.cs (TypeManager): Make this a partial class.
7793 (TypeManager): Move the generics part of `TypeManager' here.
7795 2004-12-08 Martin Baulig <martin@ximian.com>
7797 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7798 instead of a CS3002 for properties and indexer. Added CS3024
7799 check for generic interfaces.
7801 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
7802 instances are not CLS-compliant.
7804 2004-12-08 Martin Baulig <martin@ximian.com>
7807 (void_pointer_expression): New rule for `void*', `void**' etc.
7808 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
7810 2004-12-08 Martin Baulig <martin@ximian.com>
7812 * expression.cs (Invocation.InferType): Removed the hack for
7813 MethodCore.MayUnify().
7815 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
7818 * class.cs (MethodCore.MayUnify): Use
7819 TypeManager.MayBecomeEqualGenericTypes().
7821 2004-12-08 Martin Baulig <martin@ximian.com>
7823 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
7824 parameter, box it. Fixes #69233.
7826 2004-12-08 Martin Baulig <martin@ximian.com>
7828 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
7829 have the ctor constraint. Fixes #68326.
7831 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7833 * cs-parser.jay : interface comment was not consumed because of
7834 extra opt_semicolon before doc handling.
7836 2004-12-03 Raja R Harinath <rharinath@novell.com>
7838 Fix test-327.cs, test-328.cs, and put in early infrastructure
7839 for eventually fixing #52697.
7840 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
7841 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
7843 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
7844 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
7845 (VerifyUsing, error246): Update.
7846 * rootcontext.cs (RootContext.NamespaceLookup): Just use
7847 'NamespaceEntry.LookupNamespaceOrType'.
7849 2004-12-07 Martin Baulig <martin@ximian.com>
7851 * driver.cs: Call it "BETA SOFTWARE" :-)
7853 2004-12-06 Raja R Harinath <rharinath@novell.com>
7855 Fix crash on cs0657-17.cs.
7856 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7857 Use RootContext.Tree.Types, not 'new RootTypes ()'.
7858 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
7859 the case where the NamespaceEntry gets overwritten.
7861 2004-12-06 Marek Safar <marek.safar@seznam.cz>
7863 Fixed #69195, #56821
7864 * ecore.cs (ResolveBoolean): Tiny refactoring.
7866 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
7867 of right expression resolving when left is false constant and
7868 operator is LogicalAnd OR true constant and operator is LogicalOr.
7870 * statement.cs (ResolveUnreachable): Always reports warning.
7872 2004-12-05 Miguel de Icaza <miguel@ximian.com>
7874 * class.cs: Distinguish between 1721 and 1722 (just a little help
7875 for the programmer).
7877 2004-12-03 Miguel de Icaza <miguel@ximian.com>
7879 * delegate.cs: Only allow this on new versions of the language.
7881 2004-12-02 Duncan Mak <duncan@ximian.com>
7883 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
7885 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
7886 here as a static method. Take an additional bool out parameter
7887 `must_do_cs1540_check' for signaling to InstanceResolve.
7888 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
7889 member field from PropertyExpr class and made it an argument of
7891 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
7892 check for MarshalByRefObject, and report CS0122 instead of CS1540.
7893 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
7894 and `remove_accessor' as well as InstanceResolve: report CS0122
7899 2004-12-07 Martin Baulig <martin@ximian.com>
7901 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
7902 and CS0692 where appropriate.
7904 2004-12-06 Martin Baulig <martin@ximian.com>
7906 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
7907 IsDuplicateImplementation() and improved it.
7909 * expression.cs (Invocation.InferTypeArguments): Added
7910 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
7911 and removed the "ref" modifier from `infered_types'.
7913 * decl.cs (MemberName.ToString): Removed the exception.
7915 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
7917 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
7918 comments are allowed.
7920 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7922 * delegate.cs: Add checks for subtypes in paramaters and return values
7923 in VerifyMethod () to add support for Covariance/Contravariance
7926 2004-12-02 Miguel de Icaza <miguel@ximian.com>
7928 * report.cs: Remove extra closing parenthesis.
7930 * convert.cs (Error_CannotImplicitConversion): If the name of the
7931 types are the same, provide some extra information.
7933 2004-12-02 Marek Safar <marek.safar@seznam.cz>
7936 * attribute.cs (Resolve): Improved implementation of params
7937 attribute arguments.
7939 * support.cs (ParameterData): Add HasParams to be faster.
7941 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
7943 all things are for /doc support:
7945 * doc.cs: new file that supports XML documentation generation.
7946 * mcs.exe.sources: added doc.cs.
7948 Handle /doc command line option.
7949 Report error 2006 instead of 5 for missing file name for /doc.
7950 Generate XML documentation when required, after type resolution.
7952 Added support for picking up documentation (/// and /** ... */),
7953 including a new XmlCommentState enumeration.
7955 Added lines to fill Documentation element for field, constant,
7956 property, indexer, method, constructor, destructor, operator, event
7957 and class, struct, interface, delegate, enum.
7958 Added lines to warn incorrect comment.
7960 Added Documentation field (passed only when /doc was specified).
7962 Added DocComment, DocCommentHeader, GenerateDocComment() and
7963 OnGenerateDocComment() and some supporting private members for
7964 /doc feature to MemberCore.
7966 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
7968 Added overriden DocCommentHeader.
7970 Added overriden DocCommentHeader and GenerateDocComment().
7972 2004-12-01 Miguel de Icaza <miguel@ximian.com>
7974 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
7975 unwrapping the enumeration values, chain to
7976 DoConstantNumericPromotions again, so we can promote things to the
7977 fundamental types (takes care of enums that are bytes, sbytes).
7981 2004-12-01 Raja R Harinath <rharinath@novell.com>
7983 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
7984 Fix long-standing bug in type-lookup. Use FindType instead of
7985 LookupType when ec.ResolvingTypeTree.
7986 (Attribute.ResolveType, Attribute.Resolve)
7987 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
7989 (Attributes.Search): Remove internal version. Update.
7990 (Attributes.SearchMulti): Update.
7991 (Attributes.GetClsCompliantAttribute): Remove.
7992 (Attributes.GetIndexerNameAttribute): Remove.
7993 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
7994 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
7995 * class.cs (Indexer.Define): Likewise.
7997 2004-12-01 Marek Safar <marek.safar@seznam.cz>
8000 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
8001 MarshallByReference members access.
8003 * expression.cs: Use CheckMarshallByRefAccess;
8004 Better error CS0197 message.
8006 * report.cs: Print whole related error message.
8008 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8010 * class (GetClassBases): Better error 60 report.
8011 (EventProperty): Disabled warning 67 detection.
8013 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8016 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
8018 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
8021 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8024 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
8026 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
8028 2004-11-26 Miguel de Icaza <miguel@ximian.com>
8030 * attribute.cs (Attribute.Resolve): Refine error reporting and
8031 report a cs0117 if the identifier does not exist, to distinguish
8032 from 0617 which is a miss-use of the actual identifier.
8034 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
8035 between cs0070 and cs0079.
8037 * class.cs (MemberBase.DoDefine): When reporting a wrong
8038 accessibility level, we use MethodCore to compare instead of
8039 Method (this was a regression in some refactoring effort).
8041 So now we correctly report cs0056 again.
8043 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
8044 testing the target_type (which was known to be object_type) and
8045 not the source type (which is anonymous_method).
8047 Fixed reporting of error cs1660.
8049 * expression.cs (UserCast.Source): Expose the underlying cast.
8051 * statement.cs (Switch.SwitchGoverningType): Sort the list of
8052 allowed types to find a match to int32 first (most common).
8054 In addition, it ignores any ImplicitUserConversions that did an
8055 internal implicit conversion (as the switch statement allows only
8056 one integral conversion to exist).
8058 * class.cs (PartialContainer.Create): rename `name' to
8059 `member_name' for clarity. Then replace the string calls with a
8060 call to MemberName.GetPartialName, as now using
8061 MemberName.ToString is an error (this is due to the side effects
8062 it had, that were fixed in the past).
8064 This will restore the error reporting on a number of partial class
8065 errors that were missusing this (and getting an exception as a
8066 results, which is now just a plain textual warning, because
8067 yyparse debug output would crash otherwise).
8069 2004-11-26 Raja R Harinath <rharinath@novell.com>
8071 * Makefile (PROGRAM_INSTALL_DIR): Remove.
8073 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8075 * rootcontext.cs (LookupType): Make sure to cache lookups that
8076 don't give us a negative result. This saves about 5% of corlib
8079 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8081 * report.cs (AbstractMessage.Print): messages are sent to stderr
8083 * class.cs (TypeContainer.GetClassBases): It is an error to have a
8084 non-interface in the list of interfaces (at this point, either
8085 parent was properly set, or a base class is being listed in the
8086 interfaces section).
8088 This flags error 1722, and resolves the crash from bug 69259.
8090 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8092 * statement.cs (Using.EmitExpressionFinally): make this work right
8093 for valuetypes. Fixes 69926.
8095 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8097 * const.cs (Const.ChangeType): Cope with the "0 literal can be
8098 converted to an enum" here, before we try to change the underlying
8099 type. This code exists, but it is a different code path than the
8100 one used while encoding constants.
8102 (ImplicitReferenceConversionExists): In addition, resynchronized
8103 the code here, so it matches the same code in
8104 ImplicitReferenceConversionExists for the `from any class-type S
8105 to any interface-type T'.
8107 2004-11-25 Marek Safar <marek.safar@seznam.cz>
8109 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
8111 2004-11-24 Miguel de Icaza <miguel@ximian.com>
8113 * cs-parser.jay: Use verbosity accordingly.
8115 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8117 * expression.cs (Unary.ResolveOperator): Do not report warning;
8118 AddressOf reads from variable.
8120 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
8122 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8126 * attribute.cs (Attributable): Removed CheckTargets.
8127 (Attributes.Emit): Explicit attribute targets are tested here.
8129 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
8130 not enabled for interfaces.
8132 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
8133 (GetAssemblyName): Ouch next bug there.
8135 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8137 * expression.cs: Error 275 added.
8139 2004-11-23 Marek Safar <marek.safar@seznam.cz>
8141 Fix bug #69177 (Implemented decimal constant support)
8143 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
8144 (BinaryFold): Add DecimalConstant.
8146 * const.cs (Define): Decimal constant
8148 (ChangeType): Add decimal type handling.
8149 (LookupConstantValue): Don't set value for decimal type but
8150 emit DecimalConstantAttribute. Needed for constant optimization.
8152 * constant.cs (ToDecimal): New method.
8153 (ConvertToDecimal): New method.
8154 (IntConstant): Implemented ConvertToDecimal.
8155 (DecimalConstant.Emit): Emit optimized version for decimals in
8158 * expression.cs (ResolveOperator): Changed order of constant
8159 reduction to work correctly with native types which have
8160 overloaded operators.
8161 (ResolveMemberAccess): Extract constant value from attribute
8164 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
8166 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
8167 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
8168 (ChangeType): Decimal is special.
8169 (TypeToCoreType): Add decimal type.
8171 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8173 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8176 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8178 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8181 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8183 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8185 * pending.cs (PendingImplementation): Grab only interfaces.
8187 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8189 * statement.cs (ForeachHelperMethods): Add location member and
8190 error 202 detection.
8192 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8194 * expression.cs (DoResolveBase): Fixed wrong warning for out
8197 2004-12-04 Martin Baulig <martin@ximian.com>
8199 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8200 to check whether the conversion is ok.
8202 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8203 `Type.EmptyTypes' if we're not a generic TypeContainer.
8205 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8207 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8208 old bug: when converting from the null literal to a pointer,
8209 return an EmptyCast, not the NullLiteral.
8211 This fixes #69921, the recent null_type changes probably made this
8214 2004-12-03 Martin Baulig <martin@ximian.com>
8216 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8217 method as our child, call AnonymousMethod.Compatible() on it.
8219 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8221 * class.cs (FieldBase): Use an unused bit field from the field to
8222 encode the `has_offset' property from the FieldMember. This saves
8223 a couple of Ks on bootstrap compilation.
8225 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8226 method as our child, return the AnonymousMethod resolved
8229 * expression.cs (New.DoResolve): Allow return values from
8230 NewDelegate to also include AnonymousMethods.
8234 2004-11-29 Raja R Harinath <rharinath@novell.com>
8236 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8238 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8239 System.Runtime.InteropServices._Exception, since it's a base
8240 interface of the core type System.Exception in the net_2_0 profile.
8242 2004-11-27 Martin Baulig <martin@ximian.com>
8244 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8246 2004-11-26 Raja R Harinath <rharinath@novell.com>
8248 * Makefile: Convert to use executable.make.
8249 * gmcs.exe.sources: New.
8251 2004-11-25 Martin Baulig <martin@ximian.com>
8253 * expression.cs (Invocation.InferType): Added support for byref types.
8255 2004-11-25 Martin Baulig <martin@ximian.com>
8257 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8258 in TypeManager.TypeToCoreType().
8260 2004-11-25 Martin Baulig <martin@ximian.com>
8262 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8263 "Dispose" method from the `current_type'.
8264 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8265 DoDefineMembers() instead of using the MethodBuilder; this is
8266 required for generic iterators.
8268 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8270 2004-11-24 Martin Baulig <martin@ximian.com>
8272 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8274 2004-11-20 Martin Baulig <martin@ximian.com>
8276 * expression.cs (Invocation.InferType): Correctly infer generic
8277 instances; see gen-103.cs.
8278 (Invocation.InferTypeArguments): If a generic method doesn't have
8279 any unbound type parameters, we don't need to infer anything.
8281 2004-11-19 Raja R Harinath <rharinath@novell.com>
8283 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8285 2004-11-17 Raja R Harinath <rharinath@novell.com>
8287 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8288 (TypeHandle.GetMemberCache): New.
8289 (TypeHandle.TypeHandle): Update.
8290 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8291 (TypeManager.LookupParentInterfacesCache):
8292 Rename from LookupInterfaceCache. Optimize slightly.
8293 (TypeManager.MemberLookup_FindMembers): Update.
8294 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8296 (AddCacheContents): Rename from AddHashtable.
8297 * class.cs (TypeContainer.parent_container): Remove.
8298 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8299 (TypeContainer.DoDefineMembers): Don't initialize it.
8300 Update to name changes.
8302 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8304 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8305 that factors the code to check access modifiers on override.
8307 (PropertyBase): Use the code here.
8309 Patch from Lluis S'anchez, fixes bug #69361.
8311 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8313 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8314 routine that is used to report the use of a captured variable
8315 whose address has been taken.
8317 There are two checks: one when variables are being captured and
8318 the other check is when the address of a variable is taken.
8320 (because an anonymous methods might be resolved before *or* after
8321 the address has been taken) and
8323 * expression.cs (Conditional.DoResolve): Remove the special
8324 casing that Martin added to trueExpr and falseExpr being both
8325 NullLiteral. We get the right behavior now just by introducing
8326 the null_type into the compiler.
8328 * convert.cs (ExplicitConversion): Change the code to use
8329 null_type instead of testing `expr is NullLiteral'.
8330 (ImplicitConversionStandard): use null_type too.
8331 (ImplicitReferenceConversionExists): use null_type too.
8332 (ImplicitReferenceConversion): use null_type too.
8334 * literal.cs: The type of `NullLiteral' is now null_type instead
8336 (Resolve): Set the type here.
8338 * typemanager.cs: Introduce null_type.
8340 2004-11-18 Martin Baulig <martin@ximian.com>
8343 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8345 2004-11-18 Martin Baulig <martin@ximian.com>
8347 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8349 2004-11-18 Martin Baulig <martin@ximian.com>
8351 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8352 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8353 call ResolveConstructedType() on it to resolve it without checking
8355 (Constraints.ResolveTypes): Check them here.
8356 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8357 but don't check constraints.
8358 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8359 check constraints here.
8360 (ConstructedType.ResolveConstructedType): New public method. This
8361 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8362 resolve ourselves without checking constraints.
8364 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8366 2004-11-18 Martin Baulig <martin@ximian.com>
8369 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8371 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8373 2004-11-18 Martin Baulig <martin@ximian.com>
8375 * ecore.cs (TypeExpr.ResolveType): Removed.
8376 (Expression.ResolveAsTypeTerminal): We always return a fully
8377 resolved `TypeExpr', so we can just access its `Type'.
8379 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8381 2004-11-17 Martin Baulig <martin@ximian.com>
8383 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8384 sure we don't return any unresolved TypeExpr's.
8385 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8387 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8389 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8390 unresolved `ConstructedType's.
8392 2004-11-17 Martin Baulig <martin@ximian.com>
8394 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8396 2004-11-17 Martin Baulig <martin@ximian.com>
8399 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8401 * decl.cs (DeclSpace.ResolveType): Removed.
8402 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8404 2004-11-17 Martin Baulig <martin@ximian.com>
8406 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8407 direction, like FindMembers() does. Fixes #69546, testcase is in
8410 2004-11-16 Martin Baulig <martin@ximian.com>
8412 This is based on a patch from Marek Safar, see bug #69082.
8413 Fixes bugs #63705 and #67130.
8415 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8416 method; create a MemberCache for an interface type and cache the
8419 * decl.cs (IMemberContainer.ParentContainer): Removed.
8420 (IMemberContainer.ParentCache): New property.
8421 (MemberCache.SetupCacheForInterface): Removed.
8422 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8423 to create a cache for an interface's "parent".
8425 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8428 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8430 * statement.cs: Avoid adding bools to a hashtable.
8432 2004-11-15 Martin Baulig <martin@ximian.com>
8434 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8436 2004-11-11 Martin Baulig <martin@ximian.com>
8438 * typemanager.cs (TypeManager.GetMethodName): New method.
8440 * class.cs (MethodData.Define): Include the generic arity in the
8441 name of an explicit interface; also add it to the method name.
8443 * pending.cs (PendingImplementation.InterfaceMethod): The method
8444 name now includes the generic arity.
8446 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8448 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8449 calling an unsafe method from a safe location.
8451 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8454 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8456 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8458 * namespace.cs (VerifyUsing): use GetPartialName instead of
8461 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8463 * statement.cs (Return.Resolve): Fix regression in typo: if
8464 `in_exc', we have to request a NeedReturnLabel, this was a typo
8465 introduced in the anonymous method check-in. Fixes #69131.
8467 * Indexers were using the ShortName when defining themselves,
8468 causing a regression in the compiler bootstrap when applying the
8469 patch from 2004-11-02 (first part), now they use their full name
8470 and the bug is gone.
8472 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8474 * driver.cs: Strip the path from the names of embedded resources. Fixes
8477 2004-11-04 Raja R Harinath <rharinath@novell.com>
8479 Fix error message regression: cs0104-2.cs.
8480 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8481 (AliasEntry.Resolve): Update.
8482 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8484 (RootContext.LookupType): Update.
8486 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8488 * cs-parser.jay: Add support for handling accessor modifiers
8489 * class: Add support port accessor modifiers and error checking,
8490 define PropertyMethod.Define as virtual (not abstract anymore)
8491 * ecore.cs: Add checking for proeprties access with access modifiers
8492 * iterators.cs: Modify Accessor constructor call based in the modified
8494 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8496 * expression.cs (StringConcat): Handle being called twice,
8497 as when we have a concat in a field init with more than two
8500 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8502 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8503 special case explicit implementations, we should always produce
8504 the .property or .event declaration.
8506 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8507 since it will not return correct data if people use this
8508 unresolved in the presence of using statements (see test-313).
8510 * class.cs (MethodData.Define): If we are an explicit interface
8511 implementation, set the method name to the full name of the
8512 interface plus the name of the method.
8514 Notice that using the method.MethodName.GetFullName() does not
8515 work, as it will only contain the name as declared on the source
8516 file (it can be a shorthand in the presence of using statements)
8517 and not the fully qualifed type name, for example:
8521 class D : ICloneable {
8522 object ICloneable.Clone () {
8526 Would produce a method called `ICloneable.Clone' instead of
8527 `System.ICloneable.Clone'.
8529 * namespace.cs (Alias.Resolve): Use GetPartialName.
8531 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8533 * cs-parser.jay: Add error 1055 report.
8535 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8537 * assign.cs (Assign.DoResolve): Only do the transform of
8538 assignment into a New if the types are compatible, if not, fall
8539 through and let the implicit code deal with the errors and with
8540 the necessary conversions.
8542 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8544 * cs-parser.jay: Add error 1031 report.
8546 * cs-tokenizer.cs: Add location for error 1038.
8548 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8550 * cs-parser.jay: Add error 1016 report.
8552 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8554 * cs-parser.jay: Add errors 1575,1611 report.
8556 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8558 * cs-parser.jay: Add error 1001 report.
8560 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8563 * attribute.cs (GetMarshal): Add method argument for
8564 caller identification.
8566 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8567 agument for GetMarshal and RuntimeMissingSupport.
8569 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8571 * attribute.cs (ExtractSecurityPermissionSet): Removed
8572 TypeManager.code_access_permission_type.
8574 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8576 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8578 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8579 for obsolete use of a variable here. Fixes regression on errors
8580 cs0619-25 and cs0619-26.
8582 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8584 Fix #62358, implemented security attribute encoding.
8586 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8587 Tests permitted SecurityAction for assembly or other types.
8588 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8589 data from SecurityPermissionAttribute to PermisionSet class.
8591 * class.cs (ApplyAttributeBuilder): Added special handling
8592 for System.Security.Permissions.SecurityAttribute based types.
8594 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8595 special handling for System.Security.Permissions.SecurityAttribute
8598 * enum.cs (ApplyAttributeBuilder): Added special handling
8599 for System.Security.Permissions.SecurityAttribute based types.
8601 * parameter.cs (ApplyAttributeBuilder): Added special handling
8602 for System.Security.Permissions.SecurityAttribute based types.
8604 * rootcontext.cs: Next 2 core types.
8606 * typemanager.cs (TypeManager.security_permission_attr_type):
8607 Built in type for the SecurityPermission Attribute.
8608 (code_access_permission_type): Build in type.
8610 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8612 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8613 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8614 all of this information into
8615 EmitContext.EmitCapturedVariableInstance.
8617 * codegen.cs (EmitCapturedVariableInstance): move here the
8618 funcionality of emitting an ldarg.0 in the presence of a
8619 remapping. This centralizes the instance emit code.
8621 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8622 then emit a load of this: it means that we have reached the
8623 topmost ScopeInfo: the one that contains the pointer to the
8624 instance of the class hosting the anonymous method.
8626 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8627 captures to the topmost CaptureContext.
8629 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8631 * expression.cs (LocalVariableReference): Move the knowledge about
8632 the iterators into codegen's EmitCapturedVariableInstance.
8634 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8636 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8637 all code paths return a value from an anonymous method (it is the
8638 same as the 161 error, but for anonymous methods).
8640 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8642 The introduction of anonymous methods in the compiler changed
8643 various ways of doing things in the compiler. The most
8644 significant one is the hard split between the resolution phase
8645 and the emission phases of the compiler.
8647 For instance, routines that referenced local variables no
8648 longer can safely create temporary variables during the
8649 resolution phase: they must do so from the emission phase,
8650 since the variable might have been "captured", hence access to
8651 it can not be done with the local-variable operations from the runtime.
8655 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8656 is a toplevel block.
8658 (ToplevelBlock): A new kind of Block, these are the blocks that
8659 are created by the parser for all toplevel method bodies. These
8660 include methods, accessors and anonymous methods.
8662 These contain some extra information not found in regular blocks:
8663 A pointer to an optional CaptureContext (for tracking captured
8664 local variables and parameters). A pointer to the parent
8667 (Return.Resolve): Catch missmatches when returning a value from an
8668 anonymous method (error 1662).
8669 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8672 (Break.Resolve): ditto.
8674 (SwitchLabel): instead of defining the labels during the
8675 resolution phase, we now turned the public ILLabel and ILLabelCode
8676 labels into methods called GetILLabelCode() and GetILLabel() that
8677 only define the label during the Emit phase.
8679 (GotoCase): Track the SwitchLabel instead of the computed label
8680 (its contained therein). Emit the code by using
8681 SwitchLabel.GetILLabelCode ().
8683 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8684 whether the Local has been captured or not.
8686 (LocalInfo.IsCaptured): New property, used to tell whether the
8687 local has been captured.
8689 * anonymous.cs: Vastly updated to contain the anonymous method
8692 The main classes here are: CaptureContext which tracks any
8693 captured information for a toplevel block and ScopeInfo used to
8694 track the activation frames for various local variables.
8696 Each toplevel block has an optional capture context associated
8697 with it. When a method contains an anonymous method both the
8698 toplevel method and the anonymous method will create a capture
8699 context. When variables or parameters are captured, they are
8700 recorded on the CaptureContext that owns them, for example:
8704 MyDelegate d = delegate {
8709 Here `a' will be recorded as captured on the toplevel
8710 CapturedContext, the inner captured context will not have anything
8711 (it will only have data if local variables or parameters from it
8712 are captured in a nested anonymous method.
8714 The ScopeInfo is used to track the activation frames for local
8715 variables, for example:
8717 for (int i = 0; i < 10; i++)
8718 for (int j = 0; j < 10; j++){
8719 MyDelegate d = delegate {
8724 At runtime this captures a single captured variable `i', but it
8725 captures 10 different versions of the variable `j'. The variable
8726 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8727 recorded on a child.
8729 The toplevel ScopeInfo will also track information like the `this'
8730 pointer if instance variables were referenced (this is necessary
8731 as the anonymous method lives inside a nested class in the host
8732 type of the method).
8734 (AnonymousMethod): Expanded to track the Toplevel, implement
8735 `AnonymousMethod.Compatible' to tell whether an anonymous method
8736 can be converted to a target delegate type.
8738 The routine now also produces the anonymous method content
8740 (AnonymousDelegate): A helper class that derives from
8741 DelegateCreation, this is used to generate the code necessary to
8742 produce the delegate for the anonymous method that was created.
8744 * assign.cs: API adjustments for new changes in
8745 Convert.ImplicitStandardConversionExists.
8747 * class.cs: Adjustments to cope with the fact that now toplevel
8748 blocks are of type `ToplevelBlock'.
8750 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8751 insteda of standard blocks.
8753 Flag errors if params arguments are passed to anonymous methods.
8755 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8756 `CurrentAnonymousMethod' which points to the current Anonymous
8757 Method. The variable points to the AnonymousMethod class that
8758 holds the code being compiled. It is set in the new EmitContext
8759 created for the anonymous method.
8761 (EmitContext.Phase): Introduce a variable and an enumeration to
8762 assist in enforcing some rules about when and where we are allowed
8763 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8764 only one that enfonces this right now).
8766 (EmitContext.HaveCaptureInfo): new helper method that returns
8767 whether we have a CapturedContext initialized.
8769 (EmitContext.CaptureVariable): New method used to register that a
8770 LocalInfo must be flagged for capturing.
8772 (EmitContext.CapturedParameter): New method used to register that a
8773 parameters must be flagged for capturing.
8775 (EmitContext.CapturedField): New method used to register that a
8776 field must be flagged for capturing.
8778 (EmitContext.HaveCapturedVariables,
8779 EmitContext.HaveCapturedFields): Return whether there are captured
8780 variables or fields.
8782 (EmitContext.EmitMethodHostInstance): This is used to emit the
8783 instance for the anonymous method. The instance might be null
8784 (static methods), this (for anonymous methods that capture nothing
8785 and happen to live side-by-side with the current method body) or a
8786 more complicated expression if the method has a CaptureContext.
8788 (EmitContext.EmitTopBlock): Routine that drives the emission of
8789 code: it will first resolve the top block, then emit any metadata
8790 and then emit the code. The split is done so that we can extract
8791 any anonymous methods and flag any captured variables/parameters.
8793 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
8794 during this phase, the ILGenerator should not be used as labels
8795 and local variables declared here might not be accessible to any
8796 code that is part of an anonymous method.
8798 Exceptions to this include the temporary variables that are
8799 created by some statements internally for holding temporary
8802 (EmitContext.EmitMeta): New routine, in charge of emitting all the
8805 (EmitContext.TemporaryReturn): This method is typically called
8806 from the Emit phase, and its the only place where we allow the
8807 ReturnLabel to be defined other than the EmitMeta. The reason is
8808 that otherwise we would have to duplicate a lot of logic in the
8809 Resolve phases of various methods that today is on the Emit
8812 (EmitContext.NeedReturnLabel): This no longer creates the label,
8813 as the ILGenerator is not valid during the resolve phase.
8815 (EmitContext.EmitThis): Extended the knowledge in this class to
8816 work in anonymous methods in addition to iterators.
8818 (EmitContext.EmitCapturedVariableInstance): This emits whatever
8819 code is necessary on the stack to access the instance to a local
8820 variable (the variable will be accessed as a field).
8822 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
8823 EmitContext.EmitAddressOfParameter): Routines to support
8824 parameters (not completed at this point).
8826 Removals: Removed RemapLocal and RemapLocalLValue. We probably
8827 will also remove the parameters.
8829 * convert.cs (Convert): Define a `ConstantEC' which points to a
8830 null. This is just to prefity some code that uses
8831 ImplicitStandardConversion code and do not have an EmitContext
8834 The idea is to flag explicitly that at that point in time, it is
8835 known that the conversion will not trigger the delegate checking
8836 code in implicit conversions (which requires a valid
8839 Everywhere: pass new EmitContext parameter since
8840 ImplicitStandardConversionExists now requires it to check for
8841 anonymous method conversions.
8843 (Convert.ImplicitStandardConversionExists): If the type of an
8844 expression is the anonymous_method_type, and the type is a
8845 delegate, we invoke the AnonymousMethod.Compatible method to check
8846 whether an implicit conversion is possible.
8848 (Convert.ImplicitConversionStandard): Only do implicit method
8849 group conversions if the language level is not ISO_1.
8851 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
8852 MethodInfo for the Invoke method. used by Delegate and
8855 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
8856 method conversions if the target type is a delegate.
8858 Removed extra debugging nops.
8860 (LocalVariableReference): Turn the `local_info' into a public
8863 Add `prepared' field, the same hack used for FieldExprs to cope
8864 with composed assignments, as Local variables do not necessarily
8865 operate purely on the stack as they used to: they can be captured
8868 Add `temp' for a temporary result, like fields.
8870 Refactor DoResolve and DoResolveLValue into DoResolveBase.
8872 It now copes with Local variables that are captured and emits the
8873 proper instance variable to load it from a field in the captured
8876 (ParameterReference.DoResolveBase): During the resolve phase,
8877 capture parameters if we are in an anonymous method.
8879 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
8880 anonymous method, use the EmitContext helper routines to emit the
8881 parameter reference.
8883 * iterators.cs: Set RemapToProxy to true/false during the
8886 * parameters.cs (GetParameterByName): New helper method.
8888 * typemanager.cs (anonymous_method_type) a new type that
8889 represents an anonyous method. This is always an internal type,
8890 used as a fencepost to test against the anonymous-methodness of an
8893 2004-10-20 Marek Safar <marek.safar@seznam.cz>
8895 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
8897 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
8899 2004-11-10 Martin Baulig <martin@ximian.com>
8901 * expression.cs (Invocation.BetterFunction): If two methods have
8902 equal parameter types, but only one of them is generic, the
8903 non-generic one wins.
8904 (New.DoResolve): Don't set `is_struct' to false if we're a generic
8905 instance; just use `Type.IsValueType' to determine whether
8906 something is a struct or not.
8907 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
8908 so we can be called multiple times.
8910 2004-11-10 Martin Baulig <martin@ximian.com>
8912 * generic.cs (TypeParameter.DefineConstraints): New public method.
8913 (TypeParameter.CheckAccessLevel): Override this and return true.
8914 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
8915 override ResolveType() anymore.
8916 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
8918 2004-11-10 Martin Baulig <martin@ximian.com>
8920 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
8921 call DeclSpace.ResolveNestedType() on it.
8923 2004-11-10 Martin Baulig <martin@ximian.com>
8925 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
8926 non-null, call ParameterModifier() on it.
8928 2004-11-10 Martin Baulig <martin@ximian.com>
8931 (Iterators): Added `current_type' and `this_type' fields.
8932 (Iterators.DefineIterator): Create a new EmitContext and store it
8933 in `ec'; compute `this_type'.
8935 2004-11-10 Martin Baulig <martin@ximian.com>
8938 (TypeManager.IsPrivateAccessible): New public method.
8939 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
8941 2004-11-10 Martin Baulig <martin@ximian.com>
8943 * class.cs (TypeContainer.DefineType): Call
8944 TypeBuilder.DefineGenericParameters() before resolving the type
8946 (MethodData.parent_method): New protected field.
8947 (MethodData..ctor): Added `MethodInfo parent_method' argument.
8948 (MethodData.Define): Compute `parent_method'.
8951 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
8952 (MemberCore.GetClsCompliantAttributeValue): Likewise.
8953 (DeclSpace.ec): New protected field; store the EmitContext here.
8954 (DeclSpace.EmitContext): New public property.
8955 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
8956 (DeclSpace.ResolveNestedType): New public method.
8957 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
8958 (DeclSpace.NestedAccessible): Added `Type tb' argument.
8959 (DeclSpace.FamilyAccessible): Likewise.
8960 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
8961 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
8964 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
8967 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
8968 (Enum.Emit): Don't create a new EmitContext.
8970 2004-10-18 Martin Baulig <martin@ximian.com>
8972 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
8973 `Type' directly, but call ResolveType() on it.
8974 (Catch.Resolve): Likewise.
8975 (Foreach.Resolve): Likewise.
8977 2004-10-18 Martin Baulig <martin@ximian.com>
8979 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
8980 `Type' directly, but call ResolveType() on it.
8981 (Probe.DoResolve): Likewise.
8982 (ArrayCreation.LookupType): Likewise.
8983 (TypeOf.DoResolve): Likewise.
8984 (SizeOf.DoResolve): Likewise.
8986 2004-10-18 Raja R Harinath <rharinath@novell.com>
8988 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
8991 2004-10-17 John Luke <john.luke@gmail.com>
8993 * class.cs (Operator.GetSignatureForError): use CSharpName
8995 * parameter.cs (Parameter.GetSignatureForError): Returns
8996 correct name even if was not defined.
8998 2004-10-13 Raja R Harinath <rharinath@novell.com>
9001 * class.cs (TypeContainer.EmitContext): New property.
9002 (DefineNestedTypes): Create an emitcontext for each part.
9003 (MethodCore.DoDefineParameters): Use container's emitcontext.
9004 Pass type array to InternalParameters.
9005 (MemberBase.DoDefine): Use container's emitcontext.
9006 (FieldMember.Define): Likewise.
9007 (Event.Define): Likewise.
9008 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9009 Pass type array to InternalParameters.
9010 (SetIndexerMethod.GetParameterInfo): Likewise.
9011 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9012 * delegate.cs (Define): Pass emitcontext to
9013 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9014 array to InternalParameters.
9015 * expression.cs (ParameterReference.DoResolveBase): Pass
9016 emitcontext to GetParameterInfo.
9017 (ComposedCast.DoResolveAsTypeStep): Remove check on
9018 ec.ResolvingTypeTree.
9019 * parameter.cs (Parameter.Resolve): Change argument to
9020 EmitContext. Use ResolveAsTypeTerminal.
9021 (Parameter.GetSignature): Change argument to EmitContext.
9022 (Parameters.ComputeSignature): Likewise.
9023 (Parameters.ComputeParameterTypes): Likewise.
9024 (Parameters.GetParameterInfo): Likewise.
9025 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9026 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9027 * support.cs (InternalParameters..ctor): Remove variant that takes
9029 * typemanager.cs (system_intptr_expr): New.
9030 (InitExpressionTypes): Initialize it.
9032 2004-10-12 Chris Toshok <toshok@ximian.com>
9034 * cs-parser.jay: fix location for try_statement and catch_clause.
9036 2004-10-18 Martin Baulig <martin@ximian.com>
9038 * class.cs (FieldMember.Define): Don't access the TypeExpr's
9039 `Type' directly, but call ResolveType() on it.
9040 (MemberBase.DoDefine): Likewise.
9042 * expression.cs (New.DoResolve): Don't access the TypeExpr's
9043 `Type' directly, but call ResolveType() on it.
9044 (ComposedCast.DoResolveAsTypeStep): Likewise.
9046 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
9047 `Type' directly, but call ResolveType() on it.
9049 2004-10-17 John Luke <john.luke@gmail.com>
9051 * class.cs (Operator.GetSignatureForError): use CSharpName
9053 * parameter.cs (Parameter.GetSignatureForError): Returns
9054 correct name even if was not defined.
9056 2004-10-13 Raja R Harinath <rharinath@novell.com>
9059 * class.cs (TypeContainer.EmitContext): New property.
9060 (DefineNestedTypes): Create an emitcontext for each part.
9061 (MethodCore.DoDefineParameters): Use container's emitcontext.
9062 Pass type array to InternalParameters.
9063 (MemberBase.DoDefine): Use container's emitcontext.
9064 (FieldMember.Define): Likewise.
9065 (Event.Define): Likewise.
9066 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9067 Pass type array to InternalParameters.
9068 (SetIndexerMethod.GetParameterInfo): Likewise.
9069 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9070 * delegate.cs (Define): Pass emitcontext to
9071 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9072 array to InternalParameters.
9073 * expression.cs (ParameterReference.DoResolveBase): Pass
9074 emitcontext to GetParameterInfo.
9075 (ComposedCast.DoResolveAsTypeStep): Remove check on
9076 ec.ResolvingTypeTree.
9077 * parameter.cs (Parameter.Resolve): Change argument to
9078 EmitContext. Use ResolveAsTypeTerminal.
9079 (Parameter.GetSignature): Change argument to EmitContext.
9080 (Parameters.ComputeSignature): Likewise.
9081 (Parameters.ComputeParameterTypes): Likewise.
9082 (Parameters.GetParameterInfo): Likewise.
9083 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9084 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9085 * support.cs (InternalParameters..ctor): Remove variant that takes
9087 * typemanager.cs (system_intptr_expr): New.
9088 (InitExpressionTypes): Initialize it.
9090 2004-10-12 Chris Toshok <toshok@ximian.com>
9092 * cs-parser.jay: fix location for try_statement and catch_clause.
9094 2004-10-07 Raja R Harinath <rharinath@novell.com>
9096 More DeclSpace.ResolveType avoidance.
9097 * decl.cs (MemberCore.InUnsafe): New property.
9098 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
9099 with newly created EmitContext.
9100 (FieldMember.Define): Likewise.
9101 * delegate.cs (Delegate.Define): Likewise.
9102 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
9103 only if normal name-lookup fails.
9104 (TypeExpr.DoResolve): Enable error-checking.
9105 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
9106 (SizeOf.DoResolve): Likewise.
9107 (ComposedCast.DoResolveAsTypeStep): Likewise.
9108 (StackAlloc.DoResolve): Likewise.
9109 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
9110 (Block.Unsafe): New property.
9111 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
9112 (Unsafe): Set 'unsafe' flag of contained block.
9113 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
9114 (Fixed.Resolve): Likewise.
9115 (Catch.Resolve): Likewise.
9116 (Using.ResolveLocalVariableDecls): Likewise.
9117 (Foreach.Resolve): Likewise.
9119 2004-10-05 John Luke <john.luke@gmail.com>
9121 * cs-parser.jay: add location to error CS0175
9123 2004-10-04 Miguel de Icaza <miguel@ximian.com>
9125 * ecore.cs (Expression.Constantity): Add support for turning null
9128 * const.cs (Const.Define): Allow constants to be reference types
9129 as long as the value is Null.
9131 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
9133 * namespace.cs (NamespaceEntry.Using): No matter which warning
9134 level is set, check if this namespace name has already been added.
9136 2004-10-03 Ben Maurer <bmaurer@ximian.com>
9138 * expression.cs: reftype [!=]= null should always use br[true,false].
9141 2004-10-03 Marek Safar <marek.safar@seznam.cz>
9144 * attribute.cs: Enum conversion moved to
9145 GetAttributeArgumentExpression to be applied to the all
9148 2004-10-01 Raja R Harinath <rharinath@novell.com>
9150 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
9151 * class.c (TypeContainer.DefineType): Flag error if
9152 base types aren't accessible due to access permissions.
9153 * decl.cs (DeclSpace.ResolveType): Move logic to
9154 Expression.ResolveAsTypeTerminal.
9155 (DeclSpace.ResolveTypeExpr): Thin layer over
9156 Expression.ResolveAsTypeTerminal.
9157 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
9158 Refactor code into NestedAccess. Use it.
9159 (DeclSpace.NestedAccess): New.
9160 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
9161 argument to silence errors. Check access permissions.
9162 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
9163 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
9164 (Cast.DoResolve): Likewise.
9165 (New.DoResolve): Likewise.
9166 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
9167 (TypeOf.DoResolve): Likewise.
9169 * expression.cs (Invocation.BetterConversion): Return the Type of
9170 the better conversion. Implement section 14.4.2.3 more faithfully.
9171 (Invocation.BetterFunction): Make boolean. Make correspondence to
9172 section 14.4.2.2 explicit.
9173 (Invocation.OverloadResolve): Update.
9174 (Invocation): Remove is_base field.
9175 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9176 (Invocation.Emit): Likewise.
9178 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9180 * cs-parser.jay: Reverted 642 warning fix.
9182 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9185 * decl.cs (FindMemberWithSameName): Indexer can have more than
9188 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9190 * expression.cs (LocalVariableReference.DoResolveLValue):
9191 Do not report warning 219 for out values.
9192 (EmptyExpression.Null): New member to avoid extra allocations.
9194 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9196 * cs-parser.jay: Fix wrong warning 642 report.
9198 * cs-tokenizer.cs (CheckNextToken): New helper;
9199 Inspect next character if is same as expected.
9201 2004-09-23 Martin Baulig <martin@ximian.com>
9203 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9204 (Convert.ImplicitReferenceConversionExists): Likewise.
9206 2004-11-09 Raja R Harinath <rharinath@novell.com>
9208 * Makefile (DISTFILES): Comment out a few missing files.
9210 2004-10-29 Raja R Harinath <rharinath@novell.com>
9212 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9213 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9214 (gmcs.exe): Invoke bootstrap-libs.
9215 (clean-local): Clean the net_2_0_bootstrap profile too.
9216 (PROGRAM_INSTALL_DIR): New.
9217 (install-local): Use it.
9219 2004-10-13 Martin Baulig <martin@ximian.com>
9221 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9222 (TypeParameter.DefineType): If we're a method type parameter and
9223 that method is overriding something, "inflate" its constraints.
9225 2004-10-12 Martin Baulig <martin@ximian.com>
9227 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9228 and have type arguments, create and resolve a ConstructedType.
9230 2004-10-12 Martin Baulig <martin@ximian.com>
9232 * decl.cs (MemberCache.FindMemberToOverride): Use
9233 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9234 to compare the invocationType.
9236 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9237 When comparing two type parameters, only do the signature-only
9238 comparision for method type parameters.
9240 2004-10-11 Martin Baulig <martin@ximian.com>
9242 * report.cs: Don't make --fatal abort on warnings, we have
9243 -warnaserror for that.
9245 2004-10-11 Martin Baulig <martin@ximian.com>
9248 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9249 (TypeManager.IsEqual): Call ourself recursively instead of using
9252 2004-10-11 Martin Baulig <martin@ximian.com>
9254 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9255 on our own type parameters, not on the ones we inherit from a containing
9258 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9261 * generic.cs (TypeParameter.Define): We may only be called once.
9263 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9264 instead of TypeManager.IsEqual().
9266 2004-09-28 Martin Baulig <martin@ximian.com>
9269 (GenericConstraints.EffectiveBaseClass): New public property.
9270 (TypeParameter.GenericConstraints): New public property.
9271 (ConstructedType.CheckConstraints): Improved.
9273 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9274 (Convert.TypeParameterConversion): New private method; use this in
9275 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9276 for all conversions related to type parameters.
9278 2004-09-24 Martin Baulig <martin@ximian.com>
9280 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9281 type parameter conversions for type parameters which are known to
9284 2004-09-24 Martin Baulig <martin@ximian.com>
9286 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9287 `IsValueType' properties.
9289 * support.cs (ReflectionConstraints): Use
9290 Type.GetGenericParameterConstraints() instead of the old hack.
9292 2004-09-24 Martin Baulig <martin@ximian.com>
9294 * generic.cs (GenericConstraints): Moved here and made it an
9297 * support.cs (GenericConstraints): Moved to generic.cs.
9299 2004-09-24 Martin Baulig <martin@ximian.com>
9302 (ReflectionConstraints): Un-nested this class and made it public.
9305 (TypeManager.GetTypeParameterConstraints): New public method.
9306 (TypeManager.HasConstructorConstraint): Use the attributes.
9308 2004-09-24 Martin Baulig <martin@ximian.com>
9310 * support.cs (GenericConstraints): Replaced `HasConstructor',
9311 `IsReferenceType' and `IsValueType' with `Attributes'.
9312 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9313 method and made the .ctor public.
9315 * generic.cs (Constraints.Attributes): New public property.
9316 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9317 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9318 `IsValueType' -> `HasValueTypeConstraint'.
9320 2004-09-23 Martin Baulig <martin@ximian.com>
9322 * generic.cs (Constraints): Reflect latest runtime changes.
9324 2004-09-23 Martin Baulig <martin@ximian.com>
9326 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9327 (Convert.ImplicitReferenceConversionExists): Likewise.
9329 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9331 * class.cs (Operator.Define): Add error 448 and 559 report.
9333 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9335 * class.cs (MemberBase.IsTypePermitted): New protected
9336 method for checking error CS0610.
9338 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9340 * class.cs (TypeContainer.HasExplicitLayout): New property
9341 Returns whether container has StructLayout attribute set Explicit.
9342 (FieldMember): New abstract class for consts and fields.
9343 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9344 (Field): Reuse FieldMember.
9346 * const.cs (Const): Reuse FieldMember.
9348 * rootcontext.cs: EmitConstants call moved to class.
9350 2004-09-22 Martin Baulig <martin@ximian.com>
9352 Marek and me just fixed one of our oldest bugs: #28562 :-)
9354 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9356 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9357 we're an EnumConstant, just return that.
9358 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9359 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9360 to get the value which'll actually be written into the attribute.
9361 However, we have to use GetValue() to access the attribute's value
9364 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9366 * constant.cs (Constant.IsNegative): New abstract property
9369 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9370 (StackAlloc.DoResolve): Reused IsNegative.
9372 2004-09-22 Martin Baulig <martin@ximian.com>
9374 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9375 public method; like LookupTypeContainer, but also works for
9378 * report.cs (Report.SymbolRelatedToPreviousError): Use
9379 TypeManager.LookupGenericTypeContainer().
9381 2004-09-22 Martin Baulig <martin@ximian.com>
9383 Thanks to Peter Sestoft for this bug report.
9385 * expression.cs (Conditional): If both the `trueExpr' and the
9386 `falseExpr' is a NullLiteral, return a NullLiteral.
9388 2004-09-22 Martin Baulig <martin@ximian.com>
9390 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9391 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9392 for the "get_Current" call.
9394 2004-09-21 Martin Baulig <martin@ximian.com>
9396 * convert.cs (Convert.ImplicitReferenceConversion): When
9397 converting to an interface type, first check whether we're
9398 converting from a reference type.
9400 2004-09-14 Martin Baulig <martin@ximian.com>
9402 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9404 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9407 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9408 called and is obsolete then this member suppress message
9409 when call is inside next [Obsolete] method or type.
9411 * expression.cs: Use TestObsoleteMethodUsage member.
9413 2004-09-14 Martin Baulig <martin@ximian.com>
9415 * genericparser.cs: Removed.
9417 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9419 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9421 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9423 * attribute.cs (Attribute.Resolve): Add error 653 report.
9425 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9427 (Method.ApplyAttributeBuilder): Add error 685 report.
9428 (Operator.Define): Add error 564 report.
9430 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9432 * expression.cs (Invocation.DoResolve): Add error
9435 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9438 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9440 * class.cs (ConstructorInitializer.Resolve):
9441 Wrong error number (515->516).
9443 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9445 * class.cs (Indexer.Define): Add error 631 report.
9447 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9449 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9451 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9453 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9455 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9457 * cs-parser.jay: Added error CS0241 report.
9459 2004-09-10 Raja R Harinath <rharinath@novell.com>
9461 * cs-parser.jay (fixed_statement): Introduce a scope for the
9462 declaration in the 'fixed' statement.
9464 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9466 * cs-parser.jay: Added CS0230 error report.
9468 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9470 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9472 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9474 * expression.cs (Argument.Resolve): Added error CS0192 and
9477 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9479 C# 2.0 #pragma warning feature
9481 * cs-tokenizer.cs (PreProcessPragma): New method;
9482 Handles #pragma directive.
9484 * report.cs (WarningRegions): New class; Support
9485 class for #pragma warning directive. It tests whether
9486 warning is enabled for a given line.
9488 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9490 * const.cs: Add more descriptive error report, tahnks to
9493 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9495 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9497 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9499 * expression.cs: Apply patch from Ben: Remove dead code from
9500 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9501 as that code just threw an exception anwyays.
9503 * const.cs: Remove the call to the turnintoconstant, for details
9506 * literal.cs: The type of the null-literal is the null type; So
9507 we use a placeholder type (literal.cs:System.Null, defined here)
9510 * expression.cs (Conditional.DoResolve): Remove some old code that
9511 is no longer needed, conversions have been fixed.
9513 (ArrayCreationExpression.DoResolve): Return false if we fail to
9514 resolve the inner expression.
9516 2004-09-07 Raja R Harinath <rharinath@novell.com>
9519 * cs-parser.jay (delegate_declaration): Record a delegate
9520 declaration as a type declaration.
9521 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9523 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9525 * parameter.cs: Do not crash if the type can not be resolved.
9527 * expression.cs: Report errors with unsafe pointers, fixes #64896
9529 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9531 * expression.cs: Pointer arith always needs to do a conv.i
9532 if the operand is a long. fix 65320
9534 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9536 Fixed cs0619-37.cs, cs0619-38.cs
9538 * enum.cs (GetObsoleteAttribute): Removed.
9540 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9541 on Enum member is double staged. The first is tested member
9544 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9546 Fixed #56986, #63631, #65231
9548 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9549 adds member to name container.
9550 (TypeContainer.AddToTypeContainer): New method, adds type to
9552 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9553 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9554 AddOperator): Simplified by reusing AddToMemberContainer.
9555 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9557 (Method.CheckForDuplications): Fixed implementation to test all
9559 (MemberBase): Detection whether member is explicit interface
9560 implementation is now in constructor.
9561 (MemberBase.UpdateMemberName): Handles IndexerName.
9562 (Accessor): Changed to keep also location information.
9563 (AbstractPropertyEventMethod): Is derived from MemberCore.
9564 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9565 will be emited or not.
9566 (PropertyBase.AreAccessorsDuplicateImplementation):
9567 Tests whether accessors are not in collision with some method.
9568 (Operator): Is derived from MethodCore to simplify common
9571 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9573 (DeclSpace.AddToContainer): Adds the member to defined_names
9574 table. It tests for duplications and enclosing name conflicts.
9576 * enum.cs (EnumMember): Clean up to reuse the base structures
9578 2004-09-03 Martin Baulig <martin@ximian.com>
9580 Merged latest changes into gmcs. Please keep this comment in
9581 here, it makes it easier for me to see what changed in MCS since
9582 the last time I merged.
9584 2004-09-03 Martin Baulig <martin@ximian.com>
9586 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9587 into TypeContainer, to make partial classes work again.
9589 2004-09-03 Martin Baulig <martin@ximian.com>
9591 * rootcontext.cs (RootContext.V2): Removed.
9593 2004-03-23 Martin Baulig <martin@ximian.com>
9595 * expression.cs (Invocation.OverloadResolve): Added `bool
9596 may_fail' argument and use it instead of the Location.IsNull() hack.
9598 2004-09-09 Martin Baulig <martin@ximian.com>
9600 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9602 2004-09-09 Martin Baulig <martin@ximian.com>
9604 * generic.cs (TypeParameter.DefineType): Added support for
9605 explicit interface methods.
9607 2004-09-09 Martin Baulig <martin@ximian.com>
9609 * README.Changes: New document. Started to list important changes
9610 between MCS and GMCS here.
9612 2004-09-08 Martin Baulig <martin@ximian.com>
9615 (TypeContainer.CheckRecursiveDefinition): New protected method.
9616 (TypeContainer.DefineType): Move the CS0146 check into
9617 CheckRecursiveDefinition().
9619 2004-09-06 Martin Baulig <martin@ximian.com>
9621 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9622 types for the constructor constraint.
9624 2004-09-03 Martin Baulig <martin@ximian.com>
9626 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9627 into TypeContainer, to make partial classes work again.
9629 2004-09-03 Martin Baulig <martin@ximian.com>
9631 * rootcontext.cs (RootContext.V2): Removed.
9633 2004-03-23 Martin Baulig <martin@ximian.com>
9635 * expression.cs (Invocation.OverloadResolve): Added `bool
9636 may_fail' argument and use it instead of the Location.IsNull() hack.
9638 2004-09-03 Martin Baulig <martin@ximian.com>
9640 Merged latest changes into gmcs. Please keep this comment in
9641 here, it makes it easier for me to see what changed in MCS since
9642 the last time I merged.
9644 2004-09-03 Raja R Harinath <rharinath@novell.com>
9647 * expression.cs (BetterConversion): Don't allow either conversion
9648 to be null. Remove redundant implicit conversion test when 'q ==
9649 null' -- when this function is invoked, we already know that the
9650 implicit conversion exists.
9651 (BetterFunction): Assume that 'best' is non-null. Remove
9652 redundant reimplementation of IsApplicable when 'best' is null.
9653 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9654 number of arguments.
9655 (IsAncestralType): Extract from OverloadResolve.
9656 (OverloadResolve): Make robust to the MethodGroupExpr being
9657 unsorted. Implement all the logic of Section 14.5.5.1, and
9658 support overloading of methods from multiple applicable types.
9659 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9661 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9662 (RealError, Warning): Append type of report to related symbol.
9664 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9666 * enum.cs: Fixed CLS-Compliance checks for enum members.
9667 Error tests cs3008-8.cs, cs3014-8.cs
9669 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9671 Fixed bug #62342, #63102
9672 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9673 like ImplementMethod.
9675 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9677 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9680 2004-09-02 Martin Baulig <martin@ximian.com>
9682 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9683 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9686 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9688 C# 2.0 Static classes implemented
9690 * class.cs (TypeContainer): instance_constructors,
9691 initialized_fields, initialized_static_fields,
9692 default_constructor, base_inteface_types are protected to be
9693 accessible from StaticClass.
9694 (TypeContainer.DefineDefaultConstructor): New virtual method
9695 for custom default constructor generating
9696 (StaticClass): New class to handle "Static classes" feature.
9698 * cs-parser.jay: Handle static keyword on class like instance
9701 * driver.cs: Added "/langversion" command line switch with two
9702 options (iso-1, default).
9704 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9706 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9708 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9710 * delegate.cs: Style.
9712 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9714 * delegate.cs: Add seperate instance expr field for miguel.
9716 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9718 * PointerArithmetic (Resolve): make sure we are not doing
9719 pointer arith on void*. Also, make sure we are resolved
9720 by not setting eclass until resolve.
9722 All callers: Make sure that PointerArithmetic gets resolved.
9724 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9726 * ArrayCreation (LookupType): If the type does not resolve
9727 to an array, give an error.
9729 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9731 * statement.cs (Try.Resolve): Fixed bug #64222
9733 2004-08-27 Martin Baulig <martin@ximian.com>
9736 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9739 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9741 * ecore.cs (Constantify): Get underlying type via
9742 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9743 Windows in special cases.
9745 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9747 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9748 for obtaining also private methods.
9749 (GetRemoveMethod): Used GetRemoveMethod (true)
9750 for obtaining also private methods.
9752 2004-09-02 Martin Baulig <martin@ximian.com>
9754 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9755 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9758 2004-08-27 Martin Baulig <martin@ximian.com>
9761 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9764 2004-08-25 Martin Baulig <martin@ximian.com>
9766 * support.cs (ReflectionParameters..ctor): If this is a generic
9767 method, retrieve and store its type parameters.
9768 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9769 (ReflectionParameters.GenericConstraints): The argument specifies
9770 the type parameter, not the method parameter.
9771 (InternalParameters.GenericConstraints): Likewise.
9773 * generic.cs (TypeParameter.DefineType): Correctly handle
9774 constraints wrt. generic methods in interfaces and their
9777 2004-08-24 Martin Baulig <martin@ximian.com>
9779 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9780 (Constraints.IsSubclassOf): New internal method.
9782 * typemanager.cs (TypeManager.FindMembers): Added special support
9783 for GenericTypeParameterBuilder's.
9784 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
9787 2004-08-24 Martin Baulig <martin@ximian.com>
9790 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
9791 this for accessibility checks.
9792 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
9793 IsNestedFamilyAccessible.
9794 (TypeManager.IsSubclassOf): New method, do what the name actually
9797 2004-08-24 Martin Baulig <martin@ximian.com>
9799 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
9800 as a SimpleName, include the generic arity.
9802 2004-08-24 Martin Baulig <martin@ximian.com>
9804 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
9805 MethodAttributes.HideBySig for operators.
9807 2004-08-23 Martin Baulig <martin@ximian.com>
9809 Back to the old error reporting system :-)
9811 * report.cs (Message): Removed.
9812 (Report.MessageData, ErrorData, WarningData): Removed.
9813 (Report.Error, Warning): Back to the old system.
9815 2004-08-23 Martin Baulig <martin@ximian.com>
9817 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
9819 * class.cs (TypeContainer.ParentContainer): New public virtual
9820 method; replaces the explicit interface implementation.
9821 (ClassPart.ParentContainer): Override.
9823 2004-08-23 Martin Baulig <martin@ximian.com>
9825 * statement.cs (Switch): Added support for constant switches; see
9826 #59428 or test-285.cs.
9828 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9831 * statement.cs (GetEnumeratorFilter): Removed useless
9832 logic because C# specs is strict. GetEnumerator must be
9835 2004-08-22 Martin Baulig <martin@ximian.com>
9837 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9838 a switch and may break, reset the barrier. Fixes #59867.
9840 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9842 CLS-Compliance speed up (~5% for corlib)
9844 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
9845 New method. Tests container for CLS-Compliant names
9847 * class.cs (TypeContainer.VerifyClsName): New method.
9848 Checks whether container name is CLS Compliant.
9849 (Constructor): Implements IMethodData.
9851 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
9852 low-case table for CLS Compliance test.
9853 (MemberCache.VerifyClsParameterConflict): New method.
9854 Checks method parameters for CS3006 error.
9856 * enum.cs (EnumMember): Is derived from MemberCore.
9857 (Enum.VerifyClsName): Optimized for better performance.
9859 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9861 * report.cs: Renamed Error_T to Error and changed all
9864 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9866 * class.cs (TypeContainer.IndexerArrayList): New inner class
9867 container for indexers.
9868 (TypeContainer.DefaultIndexerName): New constant for default
9869 indexer name. Replaced all "Item" with this constant.
9870 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
9872 * typemanager.cs (TypeManager.default_member_ctor): Cache here
9873 DefaultMemberAttribute constructor.
9875 2004-08-05 Martin Baulig <martin@ximian.com>
9877 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9880 2004-08-05 Marek Safar <marek.safar@seznam.cz>
9882 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
9883 multi platforms problem.
9885 * compiler.csproj: Included shared files.
9887 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9889 Fix bug 60333, 55971 in the more general way
9890 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9891 Added arg_type argument for constant conversion.
9892 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
9894 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9897 * class.cs (TypeContainer ): New inner classes MethodArrayList,
9898 OperatorArrayList, MethodCoreArrayList for typecontainer
9899 containers. Changed class member types to these new types.
9900 (MethodArrayList.DefineMembers): Added test for CS0659.
9902 2004-08-04 Miguel de Icaza <miguel@ximian.com>
9904 * cfold.cs: Synchronize the folding with the code in expression.cs
9905 Binary.DoNumericPromotions for uint operands.
9907 * attribute.cs: Revert patch from Raja, it introduced a regression
9908 while building Blam-1.2.1 (hard to isolate a test case).
9910 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9914 (TypeContainer.Define): Renamed to DefineContainerMembers because of
9916 (MethodCore.parent_method): New member. The method we're overriding
9917 if this is an override method.
9918 (MethodCore.CheckBase): Moved from Method class and made common.
9919 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
9921 (MethodCore.CheckForDuplications): New abstract method. For custom
9922 member duplication search in a container
9923 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
9924 method and its return type.
9925 (Event.conflict_symbol): New member. Symbol with same name in the
9929 (MemberCache.FindMemberWithSameName): New method. The method
9930 is looking for conflict with inherited symbols.
9932 2004-08-04 Martin Baulig <martin@ximian.com>
9934 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9936 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9938 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9940 * report.cs (Message): New enum for better error, warning reference in
9942 (MessageData): New inner abstract class. It generally handles printing of
9943 error and warning messages.
9944 Removed unused Error, Warning, Message methods.
9946 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9948 Fix for cs0592-8.cs test
9950 (Attributable.ValidAttributeTargets): Made public.
9951 (Attribute.ExplicitTarget): New member for explicit target value.
9952 (Attribute.CheckTargets): Now we translate explicit attribute
9953 target to Target here.
9955 2004-08-03 Ben Maurer <bmaurer@ximian.com>
9957 * ecore.cs (MethodGroupExpr): new IsBase property.
9959 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
9961 * delegate.cs (DelegateCreation): store a MethodGroupExpr
9962 rather than an instance expr.
9964 (DelegateCreation.Emit): Use the method group rather than
9965 the instance expression. Also, if you have base.Foo as the
9966 method for a delegate, make sure to emit ldftn, not ldftnvirt.
9968 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
9970 (NewDelegate.DoResolve): Only check for the existance of Invoke
9971 if the method is going to be needed. Use MethodGroupExpr.
9973 (NewDelegate.Emit): Remove, DelegateCreation implements this.
9975 * expression.cs: For pointer arith., make sure to use
9976 the size of the type, not the size of the pointer to
9979 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9982 * class.cs (Class): Added error CS0502 test.
9984 2004-08-03 John Luke <jluke@cfl.rr.com>
9985 Raja R Harinath <rharinath@novell.com>
9988 * attribute.cs (Attribute.complained_before): New flag.
9989 (Attribute.ResolveType, Attribute.Resolve),
9990 (Attribute.DefinePInvokeMethod): Set it.
9991 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
9993 2004-08-03 Martin Baulig <martin@ximian.com>
9995 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
9996 use a user-defined operator; we still need to do numeric
9997 promotions in case one argument is a builtin type and the other
9998 one has an implicit conversion to that type. Fixes #62322.
10000 2004-08-18 Martin Baulig <martin@ximian.com>
10002 * class.cs (Method.Define): Use the correct method name when
10003 creating the MethodBuilder for a generic method.
10005 2004-08-17 Martin Baulig <martin@ximian.com>
10007 * generic.cs (Constraints): Support type parameter constraints.
10009 2004-08-16 Martin Baulig <martin@ximian.com>
10011 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
10012 (Token.GENERIC_DIMENSION): New token; this is returned if we
10013 encounter an unbound generic type in a typeof() expression.
10015 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
10016 this token is only generated while parsing a typeof() expression.
10017 (typeof_expression): Removed the old unbound_type hack.
10019 * generic.cs (TypeArguments.IsUnbound): New public property.
10021 * decl.cs (MemberName): Added support for unbound types.
10023 2004-08-14 Martin Baulig <martin@ximian.com>
10026 (TypeManager.IsEqualGenericInstance): New static method.
10027 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
10028 just used to check accessibility, so follow the rules of 26.1.6.
10030 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
10031 ConstructedType instead of a TypeExpression if we have type arguments.
10033 * cs-parser.jay (typeof_expression): Support unbound generic types.
10035 * ecore.cs (UnboundTypeExpression): New public class.
10037 2004-08-12 Martin Baulig <martin@ximian.com>
10039 * typemanager.cs (TypeManager.IsNestedChildOf): Use
10040 TypeManager.IsEqual() rather than `=='.
10042 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
10043 generic instances as well.
10045 2004-08-12 Martin Baulig <martin@ximian.com>
10047 * expression.cs (Invocation.InferType): We can only infer method
10048 type parameters. Fixes #62647.
10050 2004-08-11 Martin Baulig <martin@ximian.com>
10052 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
10053 before resolving the base classes.
10055 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10057 * Makefile: install .mdb file too.
10059 2004-08-05 Martin Baulig <martin@ximian.com>
10061 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
10062 initializer, the current type is just the TypeBuilder, not the
10063 instantiated generic type.
10064 (FieldExpr.IsFieldInitializer): New public property.
10066 2004-08-04 Martin Baulig <martin@ximian.com>
10068 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10070 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10072 2004-08-03 Martin Baulig <martin@ximian.com>
10074 * class.cs (MethodData.Define): If we're an explicit
10075 implementation, remove the generic arity from the type name.
10077 2004-08-03 Martin Baulig <martin@ximian.com>
10079 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10080 use a user-defined operator; we still need to do numeric
10081 promotions in case one argument is a builtin type and the other
10082 one has an implicit conversion to that type. Fixes #62322.
10084 2004-08-02 Martin Baulig <martin@ximian.com>
10086 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
10087 `TypeExpr[]' array.
10088 (TypeContainer.GetClassBases): Return the unexpanded list of
10089 interfaces; we expand them later.
10090 (TypeContainer.DefineType): After creating the TypeBuilder, call
10091 TypeManager.ExpandInterfaces() to get an expanded and resolved
10092 list of interfaces.
10094 * ecore.cs (TypeExpr.GetInterfaces): Removed
10096 * generics.cs (Constraints.InterfaceConstraints): Remove.
10097 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
10098 register the interface constraints.
10101 (TypeManager.AddUserType): Removed the `ifaces' argument.
10102 (TypeManager.AddTypeParameter): Likewise.
10103 (TypeManager.AddUserInterface): Removed, was unused.
10104 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
10105 `TypeExpr[]' array for the interfaces.
10106 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
10107 has been defined, returns a list of the resolved interfaces types.
10108 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
10109 (TypeManager.GetExplicitInterfaces): Likewise.
10111 2004-08-02 Martin Baulig <martin@ximian.com>
10113 * expression.cs (Invocation.EmitCall): If we're invoking a method
10114 on a type parameter, use the new `Constrained' prefix opcode.
10116 2004-08-02 Martin Baulig <martin@ximian.com>
10118 * statement.cs (LocalInfo.Flags): Added `IsThis'.
10119 (LocalInfo.IsThis): New public property.
10120 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
10122 2004-08-01 Martin Baulig <martin@ximian.com>
10124 * class.cs (TypeContainer.GetClassBases): Don't set the default
10125 here since we may get called from GetPartialBases().
10126 (TypeContainer.DefineType): If GetClassBases() didn't return a
10127 parent, use the default one.
10129 2004-07-30 Martin Baulig <martin@ximian.com>
10131 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
10133 * class.cs (SourceMethod): New public class, derive from the
10134 symbol writer's ISourceMethod.
10135 (Method): Use the new symbol writer API.
10137 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
10138 as argument and use the new symbol writer.
10141 (SourceFile): Implement the symbol writer's ISourceFile.
10142 (Location.SymbolDocument): Removed.
10143 (Location.SourceFile): New public property.
10145 * symbolwriter.cs: Use the new symbol writer API.
10147 2004-07-30 Raja R Harinath <rharinath@novell.com>
10149 * Makefile (install-local): Remove. Functionality moved to
10152 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
10154 * Makefile: Install mcs.exe.config file together with mcs.exe.
10155 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
10156 correct runtime version.
10158 2004-07-25 Martin Baulig <martin@ximian.com>
10161 (TypeContainer.RegisterOrder): Removed, this was unused.
10162 (TypeContainer, interface_order): Removed.
10163 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
10164 TypeContainer as argument since we can also be called with a
10165 `PartialContainer' for a partial class/struct/interface.
10166 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
10167 of checking whether we're an `Interface' - we could be a
10168 `PartialContainer'.
10169 (PartialContainer.Register): Override; call
10170 AddClass()/AddStruct()/AddInterface() on our parent.
10172 * cs-parser.jay (interface_member_declaration): Add things to the
10173 `current_container', not the `current_class'.
10175 * rootcontext.cs (RegisterOrder): The overloaded version which
10176 takes an `Interface' was unused, removed.
10178 * typemanager.cs (TypeManager.LookupInterface): Return a
10179 `TypeContainer', not an `Interface'.
10180 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10181 contain a `PartialContainer' for an interface, so check it's
10182 `Kind' to figure out what it is.
10184 2004-07-25 Martin Baulig <martin@ximian.com>
10186 * class.cs (Class.DefaultTypeAttributes): New public constant.
10187 (Struct.DefaultTypeAttributes): Likewise.
10188 (Interface.DefaultTypeAttributes): Likewise.
10189 (PartialContainer.TypeAttr): Override this and add the
10190 DefaultTypeAttributes.
10192 2004-07-25 Martin Baulig <martin@ximian.com>
10194 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10195 we can just use the `Parent' field instead.
10197 2004-07-25 Martin Baulig <martin@ximian.com>
10199 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10201 2004-07-25 Martin Baulig <martin@ximian.com>
10203 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10204 our parts before defining any methods.
10205 (TypeContainer.VerifyImplements): Make this virtual.
10206 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10207 on our PartialContainer.
10209 2004-07-25 Martin Baulig <martin@ximian.com>
10211 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10213 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10214 argument, we can just use the `Parent' field instead.
10217 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10218 (MemberBase.DoDefine): Likewise.
10220 2004-07-24 Martin Baulig <martin@ximian.com>
10222 * decl.cs (MemberCore.Parent): New public field.
10223 (DeclSpace.Parent): Moved to MemberCore.
10225 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10226 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10228 (FieldBase, Field, Operator): Likewise.
10229 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10230 (EventField, Event): Likewise.
10232 2004-07-23 Martin Baulig <martin@ximian.com>
10234 * class.cs (PartialContainer): New public class.
10235 (ClassPart): New public class.
10236 (TypeContainer): Added support for partial classes.
10237 (TypeContainer.GetClassBases): Splitted some of the functionality
10238 out into GetNormalBases() and GetPartialBases().
10240 * cs-tokenizer.cs (Token.PARTIAL): New token.
10241 (Tokenizer.consume_identifier): Added some hacks to recognize
10242 `partial', but only if it's immediately followed by `class',
10243 `struct' or `interface'.
10245 * cs-parser.jay: Added support for partial clases.
10247 2004-07-23 Martin Baulig <martin@ximian.com>
10249 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10250 a `DeclSpace' and also made it readonly.
10251 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10252 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10253 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10255 * cs-parser.jay: Pass the `current_class', not the
10256 `current_container' (at the moment, this is still the same thing)
10257 to a new Method, Property, Event, Indexer or Constructor.
10259 2004-07-23 Martin Baulig <martin@ximian.com>
10261 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10262 and removed the `current_interface' one.
10263 (struct_declaration, class_declaration, interface_declaration):
10264 Set `current_class' to the newly created class/struct/interface;
10265 set their `Bases' and call Register() before parsing their body.
10267 2004-07-23 Martin Baulig <martin@ximian.com>
10269 * class.cs (Kind): New public enum.
10270 (TypeContainer): Made this class abstract.
10271 (TypeContainer.Kind): New public readonly field.
10272 (TypeContainer.CheckDef): New public method; moved here from
10274 (TypeContainer.Register): New public abstract method.
10275 (TypeContainer.GetPendingImplementations): New public abstract
10277 (TypeContainer.GetClassBases): Removed the `is_class' and
10278 `is_iface' parameters.
10279 (TypeContainer.DefineNestedTypes): Formerly known as
10281 (ClassOrStruct): Made this class abstract.
10283 * tree.cs (RootTypes): New public type.
10285 2004-07-20 Martin Baulig <martin@ximian.com>
10287 * tree.cs (Tree.RecordNamespace): Removed.
10288 (Tree.Namespaces): Removed.
10290 * rootcontext.cs (RootContext.IsNamespace): Removed.
10292 * cs-parser.jay (namespace_declaration): Just create a new
10293 NamespaceEntry here.
10295 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10297 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10298 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10299 entry to make sure it runs in the correct runtime version.
10301 2004-07-18 Martin Baulig <martin@ximian.com>
10303 * generic.cs (ConstructedType.CheckConstraints): Improved
10304 constraints checking.
10306 2004-07-18 Martin Baulig <martin@ximian.com>
10308 * expression.cs (Invocation.BetterMethod): Call
10309 TypeManager.TypeToCoreType() on all types and removed my previous
10310 hack; we're already doig the right thing here.
10312 2004-07-17 Martin Baulig <martin@ximian.com>
10314 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10316 2004-07-16 Martin Baulig <martin@ximian.com>
10318 * iterators.cs: Added generics support.
10320 2004-07-16 Martin Baulig <martin@ximian.com>
10322 * iterators.cs: Rewrote this. We're now using one single Proxy
10323 class for both the IEnumerable and the IEnumerator interface and
10324 `Iterator' derives from Class so we can use the high-level API.
10326 * class.cs (TypeContainer.AddIterator): New method.
10327 (TypeContainer.DoDefineType): New protected virtual method, which
10328 is called from DefineType().
10329 (TypeContainer.DoDefineMembers): Call DefineType() and
10330 DefineMembers() on all our iterators.
10331 (TypeContainer.Emit): Call Emit() on all our iterators.
10332 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10334 * codegen.cs (EmitContext.CurrentIterator): New public field.
10336 2004-07-15 Martin Baulig <martin@ximian.com>
10339 (TypeManager.not_supported_exception_type): New type.
10341 2004-07-14 Martin Baulig <martin@ximian.com>
10344 (TypeManager.generic_ienumerable_type): New type.
10345 (TypeManager.generic_ienumerator_type): New type.
10348 (RootContext.interfaces_first_stage): Added
10349 "System.Collections.Generic.IEnumerator`1" and
10350 "System.Collections.Generic.IEnumerable`1".
10352 2004-07-14 Martin Baulig <martin@ximian.com>
10354 * iterators.cs: Use real error numbers.
10356 2004-07-14 Martin Baulig <martin@ximian.com>
10358 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10359 requires this to be a System.Collection.IEnumerable and not a
10360 class implementing that interface.
10361 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10363 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10365 * class.cs: Fixed previous fix, it broke some error tests.
10367 2004-07-12 Martin Baulig <martin@ximian.com>
10369 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10372 2004-07-14 Martin Baulig <martin@ximian.com>
10374 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10375 an exclamation mark (!) for the generic arity to reflect the
10376 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10378 2004-07-13 Martin Baulig <martin@ximian.com>
10380 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10381 specifiers being part of a type argument.
10383 2004-07-13 Martin Baulig <martin@ximian.com>
10385 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10386 name for generic types.
10388 2004-07-13 Martin Baulig <martin@ximian.com>
10390 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10393 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10395 * assign.cs (LocalTemporary): Add new argument: is_address,If
10396 `is_address' is true, then the value that we store is the address
10397 to the real value, and not the value itself.
10399 * ecore.cs (PropertyExpr): use the new local temporary
10400 stuff to allow us to handle X.Y += z (where X is a struct)
10402 2004-07-08 Martin Baulig <martin@ximian.com>
10404 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10405 not always return, just like we're doing in Using.Resolve().
10407 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10409 * cs-parser.jay (fixed_statement): flag this as Pinned.
10411 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10413 * typemanager.cs (TypeManager): Removed MakePinned method, this
10414 mechanism is replaced with the .NET 2.x compatible mechanism of
10415 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10417 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10418 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10419 `IsFixed' property which has a different meaning.
10421 2004-07-02 Raja R Harinath <rharinath@novell.com>
10423 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10424 visible from inside a nested class, not just the names of the
10425 immediately enclosing class.
10426 Fix for bug #60730.
10428 2004-06-24 Raja R Harinath <rharinath@novell.com>
10430 * expression.cs (BetterConversion): Remove buggy special-case
10431 handling of "implicit constant expression conversions". At this
10432 point, we already know that the conversion is possible -- we're
10433 only checking to see which is better.
10435 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10437 * cs-parser.jay: Added error CS0210 test.
10439 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10441 * cs-parser.jay: Added error CS0134 test.
10443 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10446 * cs-parser.jay: Added error CS0145 test.
10448 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10450 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10452 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10454 * expression.cs (StackAlloc.Resolve): The argument may not
10455 be a constant; deal with this case.
10457 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10459 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10460 GetIndexerAttributeValue.
10461 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10463 * class.cs (Indexer.Define): Added error tests for CS0415,
10466 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10468 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10471 2004-06-23 Martin Baulig <martin@ximian.com>
10473 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10474 neither return nor throw, reset the barrier as well. Fixes #60457.
10476 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10478 * class.cs : EventAttributes is now set to None by default.
10479 This fixes bug #60459.
10481 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10484 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10485 Don't throw exception but return null (it's sufficient now).
10487 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10489 * typemanager.cs (GetArgumentTypes): Faster implementation.
10491 2004-06-18 Martin Baulig <martin@ximian.com>
10493 * attribute.cs (Attribute.Resolve): Check whether we're an
10494 EmptyCast which a Constant child. Fixes #60333.
10496 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10498 * statement.cs (EmitCollectionForeach): Account for the fact that
10499 not all valuetypes are in areas which we can take the address of.
10500 For these variables, we store to a temporary variable. Also, make
10501 sure that we dont emit a `callvirt' on a valuetype method.
10503 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10505 * expression.cs (StackAlloc.DoReSolve): Added test for
10506 negative parameter (CS0247).
10508 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10511 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10513 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10516 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10519 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10521 Fix bug #58254 & cs1555.cs, cs1556.cs
10522 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10524 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10526 * cs-parser.jay: Added error CS1669 test for indexers.
10528 2004-06-18 Martin Baulig <martin@ximian.com>
10530 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10531 argument. Fixes #60441.
10533 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10534 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10535 The name needs to have the actual name of the method in order
10536 for other tests (such as the one in OverloadResolve for Invoke
10537 on a delegate) to work. As well, it does not really help
10538 error reporting because the method group had multiple methods.
10539 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10540 Make profiling work.
10542 2004-06-13 Martin Baulig <martin@ximian.com>
10544 * cs-parser.jay: Don't allow generic attributes.
10546 2004-06-13 Martin Baulig <martin@ximian.com>
10548 * class.cs (MemberBase.DoDefineBase): New protected method.
10549 (MemberBase.DoDefine): Compute the `flags' in the new
10550 DoDefineBase() which must be called first.
10551 (Method.Define): Call DoDefineBase() first so we have the flags
10552 when defining the generic method.
10554 * cs-parser.jay (interface_method_declaration): Support generic methods.
10556 2004-06-13 Martin Baulig <martin@ximian.com>
10558 * decl.cs (TypeName): Removed.
10559 (MemberName): Removed TypeName and MemberNow; now we just have
10562 * cs-parser.jay: Don't distinguish between type arguments and type
10563 parameters in the grammar and simplified the rules a bit. The
10564 reduce/reduce conflicts are now gone (except the one we inherited
10567 2004-06-11 Martin Baulig <martin@ximian.com>
10569 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10570 call this twice: for params and varargs methods.
10572 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10575 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10577 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10579 * attribute.cs (Attribute.GetValidTargets): Made public.
10582 (AbstractPropertyEventMethod): New class for better code sharing.
10583 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10585 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10587 2004-06-09 Martin Baulig <martin@ximian.com>
10589 * cs-parser.jay: Removed a reduce/reduce conflict.
10591 2004-06-03 Martin Baulig <martin@ximian.com>
10593 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10594 GetSimpleName() and return a SimpleName.
10596 * ecore.cs (SimpleName.Arguments): New public field.
10597 (SimpleName): Added overloaded ctor which takes an additional
10598 TypeArguments argument.
10599 (SimpleName.SimpleNameResolve): Added support for generic methods.
10600 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10601 formerly in MemberAccess.DoResolve(), but we also need it in
10602 SimpleNameResolve().
10604 * expression.cs (MemberAccess.DoResolve): Use the new
10605 MethodGroupExpr.ResolveGeneric().
10607 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10609 * decl.cs: If possible, use lookuptypedirect here. We can only do
10610 this if there is no `.' after the namespace. Avoids using
10611 LookupType, which does lots of slow processing.
10612 (FindNestedType) New method, does what it says :-).
10613 * namespace.cs: use LookupTypeDirect.
10614 * rootcontext.cs: use membercache, if possible.
10615 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10617 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10620 According to the spec,
10622 In a member access of the form E.I, if E is a single identifier,
10623 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10624 field, property, localvariable, or parameter with the same type as
10625 the meaning of E as a type-name (§3.8), then both possible
10626 meanings of E are permitted.
10628 We did not check that E as a simple-name had the same type as E as
10631 This trivial check gives us 5-7% on bootstrap time.
10633 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10635 * expression.cs (Invocation.OverloadResolve): Avoid the
10636 use of hashtables and boxing here by allocating on demand.
10638 2004-05-30 Martin Baulig <martin@ximian.com>
10640 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10641 we're doing a silent lookup. Don't try to lookup nested types in
10642 TypeManager.object_type (thanks to Ben Maurer).
10644 2004-05-30 Martin Baulig <martin@ximian.com>
10646 Committing a patch from Ben Maurer.
10648 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10650 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10652 * convert.cs: add a trivial cache for overload operator resolution.
10654 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10657 (AttributeTester.GetObsoleteAttribute): Returns instance of
10658 ObsoleteAttribute when type is obsolete.
10661 (TypeContainer.VerifyObsoleteAttribute): Override.
10662 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10663 (MethodCode.VerifyObsoleteAttribute): Override.
10664 (MemberBase.VerifyObsoleteAttribute): Override.
10667 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10668 and report proper error.
10671 (Delegate.VerifyObsoleteAttribute): Override.
10674 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10675 and report proper error.
10676 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10679 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10683 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10684 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10685 Added test for ObsoleteAttribute.
10688 (Catch): Derived from Statement.
10690 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10692 * decl.cs: If possible, use lookuptypedirect here. We can only do
10693 this if there is no `.' after the namespace. Avoids using
10694 LookupType, which does lots of slow processing.
10695 (FindNestedType) New method, does what it says :-).
10696 * namespace.cs: use LookupTypeDirect.
10697 * rootcontext.cs: use membercache, if possible.
10698 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10700 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10703 According to the spec,
10705 In a member access of the form E.I, if E is a single identifier,
10706 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10707 field, property, localvariable, or parameter with the same type as
10708 the meaning of E as a type-name (§3.8), then both possible
10709 meanings of E are permitted.
10711 We did not check that E as a simple-name had the same type as E as
10714 This trivial check gives us 5-7% on bootstrap time.
10716 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10718 Fixed bug #59071 & cs0160.cs
10719 * statement.cs (Try.Resolve): Check here whether order of catch
10720 clauses matches their dependencies.
10722 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10725 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10728 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10730 * expression.cs (Invocation.OverloadResolve): Avoid the
10731 use of hashtables and boxing here by allocating on demand.
10733 2004-05-30 Martin Baulig <martin@ximian.com>
10735 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10736 we're doing a silent lookup. Don't try to lookup nested types in
10737 TypeManager.object_type (thanks to Ben Maurer).
10739 2004-05-30 Martin Baulig <martin@ximian.com>
10741 Committing a patch from Ben Maurer.
10743 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10745 2004-05-29 Martin Baulig <martin@ximian.com>
10747 * class.cs (IMethodData.ShouldIgnore): New method.
10749 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10750 `Location' argument, we don't need it anywhere. Use
10751 `IMethodData.ShouldIgnore ()' instead of
10752 `MethodData.GetMethodFlags ()'.
10753 (TypeManager.AddMethod): Removed.
10754 (TypeManager.AddMethod2): Renamed to AddMethod.
10756 2004-05-29 Martin Baulig <martin@ximian.com>
10758 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10760 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10761 converting from a class type S to an interface type and we already
10762 have an object on the stack, don't box it again. Fixes #52578.
10764 2004-05-29 Martin Baulig <martin@ximian.com>
10766 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10767 Added support for `params' parameters. Fixes #59267.
10769 2004-05-29 Martin Baulig <martin@ximian.com>
10771 * literal.cs (NullPointer): Provide a private .ctor which sets
10772 `type' to TypeManager.object_type. Fixes #59048.
10774 2004-05-29 Martin Baulig <martin@ximian.com>
10776 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10777 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10779 * ecore.cs (EventExpr.instance_expr): Make the field private.
10781 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10783 Fixed bug #50080 & cs0214-2.cs
10784 * expression.cs (Cast.DoResolve): Check unsafe context here.
10786 * statement.cs (Resolve.DoResolve): Likewise.
10788 2004-05-26 Martin Baulig <martin@ximian.com>
10790 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
10792 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
10793 (RootContext.LookupType): Pass down the `silent' flag.
10795 2004-05-25 Martin Baulig <martin@ximian.com>
10798 (MethodGroupExpr.IdenticalTypeName): New public property.
10799 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
10800 expression actually refers to a type.
10802 2004-05-25 Martin Baulig <martin@ximian.com>
10804 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
10805 for #56176 and made it actually work.
10807 2004-05-25 Martin Baulig <martin@ximian.com>
10809 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
10810 (FieldExpr, PropertyExpr): Override and implement
10811 CacheTemporaries. Fixes #52279.
10813 2004-05-25 Miguel de Icaza <miguel@ximian.com>
10815 * location.cs: In the new compiler listing a file twice is a
10816 warning, not an error.
10818 2004-05-24 Martin Baulig <martin@ximian.com>
10820 * enum.cs (Enum.DefineType): For the `BaseType' to be a
10821 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
10823 2004-05-24 Martin Baulig <martin@ximian.com>
10825 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
10826 walking the `using' list. Fixes #53921.
10828 2004-05-24 Martin Baulig <martin@ximian.com>
10830 * const.cs (Const.LookupConstantValue): Added support for
10831 EmptyCast's; fixes #55251.
10833 2004-05-24 Martin Baulig <martin@ximian.com>
10835 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
10836 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
10837 which does the CS0135 check. The reason is that we first need to
10838 check whether the variable actually exists.
10840 2004-05-24 Martin Baulig <martin@ximian.com>
10842 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
10843 than RootContext.LookupType() to find the explicit interface
10844 type. Fixes #58584.
10846 2004-05-24 Raja R Harinath <rharinath@novell.com>
10848 * Makefile: Simplify. Use executable.make.
10849 * mcs.exe.sources: New file. List of sources of mcs.exe.
10851 2004-05-24 Anders Carlsson <andersca@gnome.org>
10855 Use the invariant culture when doing String.Compare for CLS case
10858 2004-05-23 Martin Baulig <martin@ximian.com>
10860 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
10861 don't have any dots. Fixes #52622, added cs0246-8.cs.
10863 * namespace.cs (NamespaceEntry.Lookup): Likewise.
10865 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10867 * class.cs (MemberBase.Define): Reuse MemberType member for
10868 resolved type. Other methods can use it too.
10870 2004-05-23 Martin Baulig <martin@ximian.com>
10872 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
10873 the variable also exists in the current block (otherwise, we need
10874 to report a CS0103). Fixes #58670.
10876 2004-05-23 Martin Baulig <martin@ximian.com>
10878 * flowanalysis.cs (Reachability.Reachable): Compute this
10879 on-the-fly rather than storing it as a field.
10881 2004-05-23 Martin Baulig <martin@ximian.com>
10883 * flowanalysis.cs (Reachability.And): Manually compute the
10884 resulting `barrier' from the reachability.
10886 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10889 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
10890 instance of ObsoleteAttribute when symbol is obsolete.
10893 (IMethodData): Extended interface for ObsoleteAttribute support.
10895 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10897 * attribute.cs: Fix bug #55970
10899 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10903 (GetObsoleteAttribute): New method. Creates the instance of
10905 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
10906 ObsoleteAttribute when member is obsolete.
10907 (AttributeTester.Report_ObsoleteMessage): Common method for
10908 Obsolete error/warning reporting.
10911 (TypeContainer.base_classs_type): New member for storing parent type.
10914 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
10915 for this MemberCore.
10917 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10919 * attribute.cs, const.cs: Fix bug #58590
10921 2004-05-21 Martin Baulig <martin@ximian.com>
10923 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
10924 out parameters if the end of the method is unreachable. Fixes
10927 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10929 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
10930 Hari was right, why extra method.
10932 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10934 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
10936 2004-05-20 Martin Baulig <martin@ximian.com>
10938 * delegate.cs: Convert this file to Unix mode - like the original
10941 2004-05-20 Martin Baulig <martin@ximian.com>
10943 * attribute.cs: Convert this file to Unix mode - like the original
10946 2004-05-19 Marek Safar <marek.safar@seznam.cz>
10948 Fix bug #58688 (MCS does not report error when the same attribute
10951 * attribute.cs (Attribute.Emit): Distinction between null and default.
10953 2004-05-19 Raja R Harinath <rharinath@novell.com>
10955 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
10956 of a top-level attribute without an attribute target.
10957 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
10959 (Attribute.Conditional_GetConditionName),
10960 (Attribute.Obsolete_GetObsoleteMessage): Update.
10961 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
10962 part of ScanForIndexerName.
10963 (Attribute.CanIgnoreInvalidAttribute): New function.
10964 (Attribute.ScanForIndexerName): Move to ...
10965 (Attributes.ScanForIndexerName): ... here.
10966 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
10967 (Attributes.Search): New internal variant that can choose not to
10968 complain if types aren't resolved. The original signature now
10970 (Attributes.GetClsCompliantAttribute): Use internal variant, with
10971 complaints suppressed.
10972 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
10973 only if it not useful.
10974 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
10975 top-level for attributes that are shared between the assembly
10976 and a top-level class.
10977 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
10978 * class.cs: Update to reflect changes.
10979 (DefineIndexers): Fuse loops.
10980 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
10981 a couple more variants of attribute names.
10983 2004-05-18 Marek Safar <marek.safar@seznam.cz>
10985 Fix bug #52585 (Implemented explicit attribute declaration)
10988 (Attributable.ValidAttributeTargets): New abstract method. It gets
10989 list of valid attribute targets for explicit target declaration.
10990 (Attribute.Target): It holds target itself.
10991 (AttributeSection): Removed.
10992 (Attribute.CheckTargets): New method. It checks whether attribute
10993 target is valid for the current element.
10996 (EventProperty): New class. For events that are declared like
10997 property (with add and remove accessors).
10998 (EventField): New class. For events that are declared like field.
11001 * cs-parser.jay: Implemented explicit attribute target declaration.
11003 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
11004 Override ValidAttributeTargets.
11007 (ReturnParameter): Class for applying custom attributes on
11009 (ParameterAtribute): New class. Class for applying custom
11010 attributes on the parameter type.
11012 2004-05-17 Miguel de Icaza <miguel@ximian.com>
11014 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
11017 (Method): Allow UNSAFE here.
11019 * modifiers.cs: Support unsafe reporting.
11021 2004-05-17 Marek Safar <marek.safar@seznam.cz>
11023 * decl.cs: Fix bug #58478.
11025 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11027 * statement.cs: When checking for unreachable code on an EmptyStatement,
11028 set the location. Fixes bug #58488.
11030 2004-05-13 Miguel de Icaza <miguel@ximian.com>
11032 * driver.cs: Add -pkg handling.
11034 From Gonzalo: UseShelLExecute=false
11036 2004-05-12 Marek Safar <marek.safar@seznam.cz>
11039 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
11041 (Attribute.IsClsCompliaceRequired): Moved to base for better
11043 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
11044 when attribute is AttributeUsageAttribute.
11045 (Attribute.GetValidTargets): Simplified.
11046 (Attribute.GetAttributeUsage): New method returns AttributeUsage
11047 attribute for this type.
11048 (Attribute.ApplyAttributes): Method renamed to Emit and make
11050 (GlobalAttributeSection): New class for special handling of global
11051 attributes (assembly, module).
11052 (AttributeSection.Emit): New method.
11054 * class.cs: Implemented Attributable abstract methods.
11055 (MethodCore.LabelParameters): Moved to Parameter class.
11056 (Accessor): Is back simple class.
11057 (PropertyMethod): Implemented Attributable abstract class.
11058 (DelegateMethod): Implemented Attributable abstract class.
11059 (Event): New constructor for disctintion between normal Event
11060 and Event with accessors.
11062 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
11064 * codegen.cs, const.cs, decl.cs, delegate.cs:
11065 (CommonAssemblyModulClass): Implemented Attributable abstract class
11068 * enum.cs: Implement IAttributeSupport interface.
11069 (EnumMember): New class for emum members. Implemented Attributable
11073 (ParameterBase): Is abstract.
11074 (ReturnParameter): New class for easier [return:] attribute handling.
11076 * typemanager.cs: Removed builder_to_attr.
11078 2004-05-11 Raja R Harinath <rharinath@novell.com>
11081 * attribute.cs (Attribute.GetPositionalValue): New function.
11082 * class.cs (TypeContainer.VerifyMembers): New function.
11083 (TypeContainer.Emit): Use it.
11084 (ClassOrStruct): New base class for Class and Struct.
11085 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
11086 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
11088 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
11089 then each non-static field should have a FieldOffset attribute.
11090 Otherwise, none of the fields should have a FieldOffset attribute.
11091 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
11092 and FieldOffset attributes.
11093 * typemanager.cs (TypeManager.struct_layout_attribute_type)
11094 (TypeManager.field_offset_attribute_type): New core types.
11095 (TypeManager.InitCoreTypes): Initialize them.
11097 2004-05-11 Michal Moskal <malekith@pld-linux.org>
11099 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
11100 Return correct type.
11103 2004-05-09 Miguel de Icaza <miguel@ximian.com>
11105 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
11106 be implicitly converted to ulong.
11108 * expression.cs: The logic for allowing operator &, | and ^ worked
11109 was wrong, it worked before because we did not report an error in
11110 an else branch. Fixes 57895.
11112 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
11113 allow volatile fields to be reference types.
11115 2004-05-07 Miguel de Icaza <miguel@ximian.com>
11117 * driver.cs: Add support for /debug-
11119 2004-05-07 Raja R Harinath <rharinath@novell.com>
11121 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
11122 Add a 'complain' parameter to silence errors.
11123 (Attribute.Resolve): Update to changes. Put in sanity check to catch
11124 silently overlooked type-resolutions.
11125 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
11126 to reflect changes.
11127 (Attributes.Search): New function.
11128 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
11129 (Attributes.GetAttributeFullName): Remove hack.
11130 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
11131 Update to reflect changes.
11132 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11133 Use Attributes.Search instead of nested loops.
11135 2004-05-07 Marek Safar <marek.safar@seznam.cz>
11138 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
11139 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
11140 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
11142 * report.cs: (Report.Warning): Renamed to Warning_T because of
11143 parameter collision.
11145 2004-05-05 Raja R Harinath <rharinath@novell.com>
11147 * expression.cs (MemberAccess.ResolveMemberAccess):
11148 Exit with non-zero status after Report.Error.
11149 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
11151 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
11153 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11155 * support.cs: Don't hang when the file is empty.
11157 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11159 * support.cs: In SeekableStreamReader, compute the preamble size of the
11160 underlying stream. Position changes should take into account that initial
11163 2004-05-03 Todd Berman <tberman@sevenl.net>
11165 * driver.cs: remove unused GetSysVersion function.
11167 2004-05-03 Todd Berman <tberman@sevenl.net>
11169 * driver.cs: Remove the hack from saturday, as well as the hack
11170 from jackson (LoadAssemblyFromGac), also adds the CWD to the
11171 link_paths to get that bit proper.
11173 2004-05-01 Todd Berman <tberman@sevenl.net>
11175 * driver.cs: Try a LoadFrom before a Load, this checks the current
11176 path. This is currently a bug in mono that is be fixed, however, this
11177 provides a workaround for now. This will be removed when the bug
11180 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11182 * CryptoConvert.cs: Updated to latest version. Fix issue with
11183 incomplete key pairs (#57941).
11185 2004-05-01 Todd Berman <tberman@sevenl.net>
11187 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11190 2004-04-30 Jackson Harper <jackson@ximian.com>
11192 * codegen.cs: Open keys readonly.
11194 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11196 * typemanager.cs: don't report cyclic struct layout when a struct
11197 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11198 which has 2 Pango.Rectangle fields.
11200 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11202 * expression.cs: Handle IntPtr comparisons with IL code
11203 rather than a method call.
11205 2004-04-29 Martin Baulig <martin@ximian.com>
11207 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11208 the list of PropertyInfo's in class hierarchy and find the
11209 accessor. Fixes #56013.
11211 2004-04-29 Martin Baulig <martin@ximian.com>
11213 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11215 2004-04-29 Martin Baulig <martin@ximian.com>
11217 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11219 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11221 2004-04-29 Martin Baulig <martin@ximian.com>
11223 * class.cs (ConstructorInitializer.Resolve): Check whether the
11224 parent .ctor is accessible. Fixes #52146.
11226 2004-04-29 Martin Baulig <martin@ximian.com>
11228 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11230 * statement.cs (Using.EmitLocalVariableDecls): Use
11231 TypeManager.idisposable_type, not typeof (IDisposable).
11232 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11234 2004-04-29 Martin Baulig <martin@ximian.com>
11236 * class.cs (Event.Define): Don't emit the field and don't set
11237 RTSpecialName and SpecialName for events on interfaces. Fixes
11240 2004-04-29 Raja R Harinath <rharinath@novell.com>
11242 Refactor Attribute.ApplyAttributes.
11243 * attribute.cs (Attributable): New base class for objects that can
11244 have Attributes applied on them.
11245 (Attribute): Make AttributeUsage fields public.
11246 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11247 (Attribute.IsInternalCall): New property.
11248 (Attribute.UsageAttr): Convert to a public read-only property.
11249 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11250 (Attribute.ResolveType, Attribute.Resolve)
11251 (Attribute.ScanForIndexerName): Update to reflect changes.
11252 (Attribute.CheckAttributeTarget): Re-format.
11253 (Attribute.ApplyAttributes): Refactor, to various
11254 Attributable.ApplyAttributeBuilder methods.
11255 * decl.cs (MemberCore): Make Attributable.
11256 * class.cs (Accessor): Make Attributable.
11257 (MethodData.ApplyAttributes): Use proper attribute types, not
11259 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11260 (TypeContainer.ApplyAttributeBuilder)
11261 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11262 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11263 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11264 (Operator.ApplyAttributeBuilder): New factored-out methods.
11265 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11266 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11267 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11268 * parameter.cs (ParameterBase): New Attributable base class
11269 that can also represent Return types.
11270 (Parameter): Update to the changes.
11272 2004-04-29 Jackson Harper <jackson@ximian.com>
11274 * driver.cs: Prefer the corlib system version when looking for
11275 assemblies in the GAC. This is still a hack, but its a better hack
11278 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11280 * decl.cs, enum.cs: Improved error 3005 reporting.
11282 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11283 (related_symbols): New private member for list of symbols
11284 related to reported error/warning.
11286 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11288 2004-04-29 Martin Baulig <martin@ximian.com>
11290 * ecore.cs (Expression.Constantify): If we're an enum and
11291 TypeManager.TypeToCoreType() doesn't give us another type, use
11292 t.UnderlyingSystemType. Fixes #56178.
11294 2004-04-29 Martin Baulig <martin@ximian.com>
11296 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11297 interfaces and for each interface, only add members directly
11298 declared in that interface. Fixes #53255.
11300 2004-04-28 Martin Baulig <martin@ximian.com>
11302 * expression.cs (ConditionalLogicalOperator): Use a temporary
11303 variable for `left' to avoid that we evaluate it more than once;
11306 2004-04-28 Martin Baulig <martin@ximian.com>
11308 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11311 2004-04-28 Martin Baulig <martin@ximian.com>
11313 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11316 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11317 whether the type is not void (CS1547).
11319 2004-04-28 Martin Baulig <martin@ximian.com>
11321 * expression.cs (Unary.DoResolveLValue): Override this and report
11322 CS0131 for anything but Operator.Indirection.
11324 2004-04-28 Martin Baulig <martin@ximian.com>
11326 Committing a patch from Ben Maurer; see bug #50820.
11328 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11331 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11334 2004-04-28 Martin Baulig <martin@ximian.com>
11336 Committing a patch from Ben Maurer; see bug #50820.
11338 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11341 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11344 2004-04-28 Martin Baulig <martin@ximian.com>
11346 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11347 (Block.AddLabel): Call DoLookupLabel() to only search in the
11350 2004-04-28 Martin Baulig <martin@ximian.com>
11352 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11353 comparing StringConstants and NullLiterals in Equality and Inequality.
11355 2004-04-28 Jackson Harper <jackson@ximian.com>
11357 * driver.cs: Attempt to load referenced assemblies from the
11358 GAC. This is the quick and dirty version of this method that
11359 doesnt take into account versions and just takes the first
11360 canidate found. Will be good enough for now as we will not have more
11361 then one version installed into the GAC until I update this method.
11363 2004-04-28 Martin Baulig <martin@ximian.com>
11365 * typemanager.cs (TypeManager.CheckStructCycles): New public
11366 static method to check for cycles in the struct layout.
11368 * rootcontext.cs (RootContext.PopulateTypes): Call
11369 TypeManager.CheckStructCycles() for each TypeContainer.
11370 [Note: We only need to visit each type once.]
11372 2004-04-28 Martin Baulig <martin@ximian.com>
11374 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11376 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11377 success and added `out object value'. Use a `bool resolved' field
11378 to check whether we've already been called rather than
11379 `ConstantValue != null' since this breaks for NullLiterals.
11381 2004-04-28 Raja R Harinath <rharinath@novell.com>
11383 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11384 setting of this flag, since the 'set' method may be non-public.
11386 2004-04-28 Raja R Harinath <rharinath@novell.com>
11388 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11389 check on current_vector.Block.
11391 2004-04-27 Martin Baulig <martin@ximian.com>
11393 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11394 a field initializer. Fixes #56459.
11396 2004-04-27 Martin Baulig <martin@ximian.com>
11398 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11399 we're not attempting to use an indexer. Fixes #52154.
11401 2004-04-27 Martin Baulig <martin@ximian.com>
11403 * statement.cs (Return): Don't create a return label if we don't
11404 need it; reverts my change from January 20th. Thanks to Ben
11407 2004-04-27 Martin Baulig <martin@ximian.com>
11409 According to the spec, `goto' can only leave a nested scope, but
11412 * statement.cs (Block.LookupLabel): Only lookup in the current
11413 block, don't recurse into parent or child blocks.
11414 (Block.AddLabel): Check in parent and child blocks, report
11415 CS0140/CS0158 if we find a duplicate.
11416 (Block): Removed this indexer for label lookups.
11417 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11418 this already does the error reporting for us.
11421 (FlowBranching.UsageVector.Block): New public variable; may be null.
11422 (FlowBranching.CreateSibling): Added `Block' argument.
11423 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11424 label for the target of a `goto' and check whether we're not
11425 leaving a `finally'.
11427 2004-04-27 Martin Baulig <martin@ximian.com>
11429 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11430 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11433 2004-04-27 Martin Baulig <martin@ximian.com>
11435 * statement.cs (Block.AddLabel): Also check for implicit blocks
11436 and added a CS0158 check.
11438 2004-04-27 Martin Baulig <martin@ximian.com>
11440 * flowanalysis.cs (FlowBranchingLoop): New class.
11441 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11442 UsageVector's instead of an ArrayList.
11443 (FlowBranching.Label): Likewise.
11444 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11445 (FlowBranching.AddBreakVector): New method.
11447 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11449 * attribute.cs: Small regression fix: only convert the type if we
11450 the type is different, fixes System.Drawing build.
11452 2004-04-27 Martin Baulig <martin@ximian.com>
11454 * attribute.cs (Attribute.Resolve): If we have a constant value
11455 for a named field or property, implicity convert it to the correct
11458 2004-04-27 Raja R Harinath <rharinath@novell.com>
11460 * statement.cs (Block.Block): Implicit blocks share
11461 'child_variable_names' fields with parent blocks.
11462 (Block.AddChildVariableNames): Remove.
11463 (Block.AddVariable): Mark variable as "used by a child block" in
11464 every surrounding block.
11465 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11466 been used in a child block, complain about violation of "Invariant
11467 meaning in blocks" rule.
11468 * cs-parser.jay (declare_local_variables): Don't use
11469 AddChildVariableNames.
11470 (foreach_statement): Don't create an implicit block: 'foreach'
11471 introduces a scope.
11473 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11475 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11476 converting from 0L to ulong. Fixes 57522.
11478 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11480 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11481 derived class hides via 'new' keyword field from base class (test-242.cs).
11482 TODO: Handle this in the more general way.
11484 * class.cs (CheckBase): Ditto.
11486 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11488 * decl.cs (caching_flags): New member for storing cached values
11490 (MemberCore.Flags): New enum where bit flags for caching_flags
11492 (MemberCore.cls_compliance): Moved to caching_flags.
11493 (DeclSpace.Created): Moved to caching_flags.
11495 * class.cs: Use caching_flags instead of DeclSpace.Created
11497 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11499 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11500 if we are only a derived class, not a nested class.
11502 * typemanager.cs: Same as above, but do this at the MemberLookup
11503 level (used by field and methods, properties are handled in
11504 PropertyExpr). Allow for the qualified access if we are a nested
11507 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11509 * class.cs: Refactoring.
11510 (IMethodData): New inteface; Holds links to parent members
11511 to avoid member duplication (reduced memory allocation).
11512 (Method): Implemented IMethodData interface.
11513 (PropertyBase): New inner classes for get/set methods.
11514 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11515 (Event): New inner classes for add/remove methods.
11516 (Event.DelegateMethod): Implemented IMethodData interface.
11518 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11519 EmitContext (related to class.cs refactoring).
11521 2004-04-21 Raja R Harinath <rharinath@novell.com>
11523 * delegate.cs (Delegate.VerifyApplicability): If the number of
11524 arguments are the same as the number of parameters, first try to
11525 verify applicability ignoring any 'params' modifier on the last
11529 2004-04-08 Martin Baulig <martin@ximian.com>
11531 Merged latest changes into gmcs. Please keep this comment in
11532 here, it makes it easier for me to see what changed in MCS since
11533 the last time I merged.
11535 2004-04-16 Raja R Harinath <rharinath@novell.com>
11537 * class.cs (TypeContainer.AddIndexer): Use
11538 'ExplicitInterfaceName' to determine if interface name was
11539 explicitly specified. 'InterfaceType' is not initialized at this time.
11540 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11541 Indexers array is already in the required order. Initialize
11542 'IndexerName' only if there are normal indexers.
11543 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11544 (TypeContainer.Emit): Emit DefaultMember attribute only if
11545 IndexerName is initialized.
11548 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11550 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11553 2004-04-15 Raja R Harinath <rharinath@novell.com>
11555 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11559 * attribute.cs (Attribute.Resolve): Check for duplicate named
11563 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11565 * iterators.cs (MarkYield): track whether we are in an exception,
11566 and generate code accordingly. Use a temporary value to store the
11567 result for our state.
11569 I had ignored a bit the interaction of try/catch with iterators
11570 since their behavior was not entirely obvious, but now it is
11571 possible to verify that our behavior is the same as MS .NET 2.0
11575 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11577 * iterators.cs: Avoid creating temporaries if there is no work to
11580 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11581 Enumerations, use TypeManager.EnumToUnderlying and call
11584 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11587 (This.Emit): Use EmitContext.EmitThis to emit our
11590 (This.EmitAssign): Ditto.
11592 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11593 codepaths, we will move all the functionality into
11596 (FieldExpr.EmitAssign): Ditto.
11598 This fixes several hidden bugs that I uncovered while doing a code
11599 review of this today.
11601 * codegen.cs (EmitThis): reworked so the semantics are more clear
11602 and also support value types "this" instances.
11604 * iterators.cs: Changed so that for iterators in value types, we
11605 do not pass the value type as a parameter.
11607 Initialization of the enumerator helpers is now done in the caller
11608 instead of passing the parameters to the constructors and having
11609 the constructor set the fields.
11611 The fields have now `assembly' visibility instead of private.
11613 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11615 * expression.cs (Argument.Resolve): Check if fields passed as ref
11616 or out are contained in a MarshalByRefObject.
11618 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11619 another compiler type.
11621 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11623 * class.cs (Indexer.Define): use the new name checking method.
11624 Also, return false on an error.
11625 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11626 (is_identifier_[start/part]_character): make static.
11628 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11630 * expression.cs (Binary.ResolveOperator): Do no append strings
11631 twice: since we can be invoked more than once (array evaluation)
11632 on the same concatenation, take care of this here. Based on a fix
11633 from Ben (bug #56454)
11635 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11637 * codegen.cs: Fix another case where CS1548 must be reported (when
11638 delay-sign isn't specified and no private is available #56564). Fix
11639 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11640 error when MCS is used on the MS runtime and we need to delay-sign
11641 (which seems unsupported by AssemblyBuilder - see #56621).
11643 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11645 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11646 (TypeManager.ComputeNamespaces): Faster implementation for
11649 * compiler.csproj: Updated AssemblyName to mcs.
11651 2004-05-11 Jackson Harper <jackson@ximian.com>
11653 * Makefile: Preserve MONO_PATH
11655 2004-05-11 Jackson Harper <jackson@ximian.com>
11657 * Makefile: Use mono and mcs to build gmcs
11659 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11661 * codegen.cs: Add patch from Robert Shade
11662 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11665 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11667 * CryptoConvert.cs: Updated to latest version. Fix issue with
11668 incomplete key pairs (#57941).
11670 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11672 * codegen.cs: Fix another case where CS1548 must be reported (when
11673 delay-sign isn't specified and no private is available #56564). Fix
11674 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11675 error when MCS is used on the MS runtime and we need to delay-sign
11676 (which seems unsupported by AssemblyBuilder - see #56621).
11678 2004-04-29 Jackson Harper <jackson@ximian.com>
11680 * Makefile: Set MONO_PATH to use the bootstrap corlib
11681 * driver.cs: Check the GAC for referenced assemblies.
11683 2004-04-29 Martin Baulig <martin@ximian.com>
11685 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11687 2004-04-07 Martin Baulig <martin@ximian.com>
11689 * expression.cs (Binary.ResolveOperator): Added special case for
11690 Equality/Inequality between a type parameter and a null literal.
11692 2004-04-07 Martin Baulig <martin@ximian.com>
11694 * convert.cs: Check null literal -> type parameter conversions.
11696 2004-04-07 Martin Baulig <martin@ximian.com>
11698 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11699 `class' and `struct' constraints.
11701 2004-04-07 Martin Baulig <martin@ximian.com>
11703 * generic.cs (SpecialConstraint): New public enum.
11704 (Constraints.Resolve): Added support for the `class' and `struct'
11707 * cs-parser.jay (type_parameter_constraint): Added support for the
11708 `class' and `struct' constraints.
11710 2004-04-07 Martin Baulig <martin@ximian.com>
11712 * support.cs (GenericConstraints): Replaced `Types' by
11713 `ClassConstraint' and `InterfaceConstraints'; added
11714 `HasClassConstraint'.
11716 2004-04-07 Martin Baulig <martin@ximian.com>
11719 (Constraints.InterfaceConstraints): New public property.
11720 (Constraints.Types): Make this property public
11721 (TypeParameter): Implement IMemberContainer.
11722 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11723 instead of a TypeBuilder/MethodBuilder; pass the interface
11724 constraints to TypeManager.AddTypeParameter().
11725 (TypeParameter.DefineType): Just take an EmitContext and no
11726 TypeBuilder/MethodBuilder. Use the new public API.
11728 * typemanager.cs (TypeManager.AddTypeParameter): Added
11729 `TypeExpr[]' argument; add the interfaces to the
11730 `builder_to_ifaces' hash.
11731 (TypeManager.LookupMemberContainer): For
11732 GenericTypeParameterBuilders, get the TypeParameter from the
11733 `builder_to_type_param'.
11734 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11735 the TypeParameter and call FindMembers on it.
11737 2004-04-07 Martin Baulig <martin@ximian.com>
11740 (MethodCore.GenericMethod): Moved this field here from Method.
11741 (MethodCore.IsDuplicateImplementation): Take the number of type
11742 parameters into account if we're a generic method.
11744 * expression.cs (Invocation.InferTypeArguments): Don't return true
11745 if `arguments' is null; we still need to check whether we actually
11746 don't need to infer anything in this case.
11747 (MemberAccess): Merged the functionality from GenericMemberAccess
11750 * generic.cs (GenericMemberAccess): Removed.
11752 2004-04-05 Martin Baulig <martin@ximian.com>
11754 * decl.cs (MemberCore): For generic classes, interfaces and
11755 structs, `Name' now includes the number of type parameters
11756 ("Stack!1.Node!1").
11757 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11758 encode the number of type arguments in the type name.
11760 * expression.cs (Expression.MemberLookup): Removed the
11761 `num_type_args' argument; we now encode the number of type
11762 arguments in the type name.
11764 * ecore.cs (SimpleName): Encode the number of type arguments in
11765 the type name itself.
11767 * generic.cs (ConstructedType): Likewise.
11769 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11770 `MemberName'; we now include the number of type parameters in the
11773 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11774 (TypeManager.MemberLookup): Removed the
11775 `num_type_args' argument; we now encode the number of type
11776 arguments in the type name.
11778 2004-04-03 Martin Baulig <martin@ximian.com>
11780 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11781 (MemberCore.MemberName): Moved here from MemberBase.
11782 (DeclSpace.SetParameterInfo): Just take the constraints as an
11783 ArrayList; we already have the type parameters in our
11784 `MemberName'; also do the CS0080 reporting here.
11786 * cs-parser.jay (struct_declaration): Use `member_name' instead of
11787 `IDENTIFIER opt_type_parameter_list'; when constructing our
11788 `MemberName', it'll already include our type parameters.
11789 (class_declaration, interface_declaration): Likewise.
11790 (delegate_declaration): Likewise.
11791 (MakeName): Take a MemberName and return a MemberName.
11792 The following two changes are required to avoid shift/reduce conflicts:
11793 (member_name): Don't include a TypeName anymore; ie. this is now
11794 just 'IDENTIFIER opt_type_parameter_list'.
11795 (property_declaration, event_declaration): Use a
11796 `namespace_or_type_name' instead of a `member_name'.
11798 2004-04-03 Martin Baulig <martin@ximian.com>
11800 * decl.cs (MemberName): Renamed to `TypeName' and created a new
11801 `MemberName' class.
11802 (TypeName): Formerly known as MemberName.
11804 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
11805 instead of a `MemberName'.
11807 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
11808 (member_name): New rule; create a MemberName.
11810 2004-04-02 Martin Baulig <martin@ximian.com>
11812 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
11813 (CS0305 and CS0308).
11815 2004-04-02 Martin Baulig <martin@ximian.com>
11817 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
11818 support for nested types.
11820 2004-04-02 Martin Baulig <martin@ximian.com>
11822 * ecore.cs (IAlias): New public interface.
11823 (TypeExpr, TypeExpression): Implement IAlias.
11824 (TypeAliasExpression): New public class.
11826 * namespace.cs (Namespace): Implement IAlias.
11827 (Namespace.Lookup): Return an IAlias instead on an object.
11828 (Namespace.DefineName): Take an IAlias instead of an object.
11829 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
11831 (NamespaceEntry.UsingAlias): Take a Membername instead of an
11833 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
11835 (NamespaceEntry.Lookup): Likewise.
11837 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
11840 * decl.cs (DeclSpace): Implement IAlias.
11841 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
11843 * generic.cs (ConstructedType): Improved error checking.
11845 2004-04-02 Martin Baulig <martin@ximian.com>
11847 * convert.cs: Added type parameter conversions.
11850 (UnboxCast.Emit): Emit an `unbox.any' for type params.
11851 (ClassCast.Emit): If the source type is a type parameter, box it.
11852 If the target type is a type parameter, emit an `unbox.any'
11853 instead of a `classcast'.1
11855 2004-04-01 Martin Baulig <martin@ximian.com>
11857 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
11859 2004-04-01 Martin Baulig <martin@ximian.com>
11861 * generic.cs (ConstructedType.CheckConstraints): Use
11862 Convert.ImplicitStandardConversionExists(); user-defined implicit
11863 conversions are not allowed according to the spec.
11865 2004-03-30 Martin Baulig <martin@ximian.com>
11867 * expression.cs (New): Added support for type parameters.
11870 (TypeManager.activator_type): New public static field.
11871 (TypeManager.activator_create_instance): Likewise.
11873 2004-03-30 Martin Baulig <martin@ximian.com>
11875 * typemanager.cs (TypeManager.HasConstructorConstraint): New
11878 2004-03-30 Martin Baulig <martin@ximian.com>
11880 * generic.cs (ConstructedType.CheckConstraints): Actually follow
11881 the spec here: the argument type must be convertible to the
11884 2004-03-30 Martin Baulig <martin@ximian.com>
11887 (TypeParameter.Define, TypeParameter.DefineMethod): Call
11888 TypeManager.AddTypeParameter().
11889 (ConstructedType.CheckConstraints): Re-enable this and actually
11890 check whether we have a constructor constraint.
11893 (TypeManager.builder_to_type_param): New static field.
11894 (TypeManager.AddTypeParameter): New static method.
11895 (TypeManager.LookupTypeParameter): New public method.
11897 2004-03-30 Martin Baulig <martin@ximian.com>
11899 * generic.cs (TypeParameter.DefineType): Return a boolean and use
11900 the new API to actually define the constructor constraint.
11903 (TypeManager.new_constraint_attr_type): New static field.
11904 (TypeManager.InitCoreTypes): Initialize it.
11906 2004-03-30 Martin Baulig <martin@ximian.com>
11908 * generic.cs (Constraints): Completed error checking, use correct
11911 2004-03-29 Martin Baulig <martin@ximian.com>
11913 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
11915 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11916 public version which takes a `ParameterData pd' instead of an
11919 2004-03-29 Martin Baulig <martin@ximian.com>
11921 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
11924 2004-03-29 Martin Baulig <martin@ximian.com>
11926 * expression.cs (Argument.ResolveMethodGroup): If we're a
11927 ConstructedType, call GetMemberAccess() on it.
11929 2004-03-29 Martin Baulig <martin@ximian.com>
11931 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
11932 (MethodCore.CheckGenericOverride): When overriding a generic
11933 method, check whether the constraints match.
11935 * support.cs (GenericConstraints): New public interface.
11936 (ParameterData.GenericConstraints): New public method.
11938 * parameter.cs (Parameter.Resolve): Check whether we're a generic
11939 method parameter and compute our constraints if appropriate.
11940 (Parameter.GenericConstraints): New public property.
11942 * generic.cs (Constraints): Implement GenericConstraints.
11944 2004-03-29 Martin Baulig <martin@ximian.com>
11946 * decl.cs (MemberCache.FindMemberToOverride): Use
11947 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
11949 2004-03-29 Martin Baulig <martin@ximian.com>
11951 * generic.cs (GenericMethod.Define): Resolve our type parameters.
11953 2004-03-29 Martin Baulig <martin@ximian.com>
11955 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
11956 not allowed on non-generic declarations").
11958 2004-03-29 Martin Baulig <martin@ximian.com>
11960 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11961 public version of this method.
11963 * class.cs (MethodCore.IsDuplicateImplementation): Use
11964 Invocation.InferTypeArguments() to check this.
11966 2004-03-29 Martin Baulig <martin@ximian.com>
11968 * convert.cs: Use TypeManager.IsDelegateType() instead of
11969 comparing types correctly.
11971 2004-03-29 Martin Baulig <martin@ximian.com>
11973 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
11974 types directly to make it work for generic instances.
11976 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
11978 2004-03-29 Martin Baulig <martin@ximian.com>
11980 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
11981 support for arrays.
11983 2004-03-24 Martin Baulig <martin@ximian.com>
11985 * decl.cs (DeclSpace.FindType): Also use
11986 TypeManager.CheckGeneric() for types from the using clauses.
11988 2004-03-23 Martin Baulig <martin@ximian.com>
11990 * expression.cs (Invocation.OverloadResolve): Added `bool
11991 may_fail' argument and use it instead of the Location.IsNull() hack.
11993 2004-03-23 Martin Baulig <martin@ximian.com>
11995 * expression.cs (Invocation.InferType): Use correct type inference
11998 2004-03-23 Martin Baulig <martin@ximian.com>
12000 * ecore.cs (MethodGroupExpr.Name): Use
12001 TypeManager.CSharpSignature() instead of just the name.
12003 * expression.cs (Invocation.OverloadResolve): Provide better error
12005 (Invocation.DoResolve): OverloadResolve() never returns null
12006 without reporting an error, so removed the error -6 reporting here.
12008 2004-03-23 Martin Baulig <martin@ximian.com>
12010 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
12013 * cs-parser.jay (delegate_declaration): Support generic delegates.
12015 * delegate.cs: Support generic delegates.
12017 2004-03-22 Martin Baulig <martin@ximian.com>
12019 * expression.cs (Invocation.InferParamsTypeArguments): New static
12020 method; does type inference for params arguments.
12022 2004-03-21 Martin Baulig <martin@ximian.com>
12024 * typemanager.cs (TypeManager.IsGenericMethod): New public static
12025 method; checks whether a method is a generic method.
12027 * expression.cs (Invocation.InferTypeArguments): New static method;
12028 infer type arguments for generic method invocation.
12030 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
12031 property; we set this to true if we're resolving a generic method
12032 invocation and the user specified type arguments, ie. we're not
12033 doing type inference.
12035 2004-03-20 Martin Baulig <martin@ximian.com>
12037 * class.cs (MethodData.DeclaringType): New public property.
12038 (MethodData.Define): Set DeclaringType here.
12039 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
12040 instead of OperatorMethodBuilder.DeclaringType.
12042 2004-03-20 Martin Baulig <martin@ximian.com>
12044 * cs-tokenizer.cs (xtoken): Return a special
12045 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
12047 * cs-parser.jay (default_value_expression): Switch to the new
12050 2004-03-19 Martin Baulig <martin@ximian.com>
12052 * decl.cs (MemberName): New class. We use this to "construct"
12053 namespace_or_type_name's.
12055 * generics.cs (TypeArguments.GetDeclarations): New public method;
12056 returns the type arguments as a string[] and reports a CS0081 if
12057 one of them is not an identifier.
12059 * class.cs (MemberBase): The .ctor now takes the name as a
12060 MemberName instead of a string.
12061 (MemberBase.ExplicitInterfaceName): Changed type from string to
12063 (MemberBase.DoDefine): If we're an explicit implementation, the
12064 InterfaceType may be a generic instance.
12066 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
12067 (namespace_name): Call MemberName.GetName () to transform the
12068 MemberName into a string and ensure we don't have any type
12070 (type_name): Call MemberName.GetTypeExpression() to transfrom the
12071 MemberName into an expression.
12072 (method_header): Use namespace_or_type_name instead of member_name.
12074 2004-04-07 Miguel de Icaza <miguel@ximian.com>
12076 * rootcontext.cs: Add new types to the boot resolution.
12078 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
12079 MulticastDelegate is not allowed.
12081 * typemanager.cs: Add new types to lookup: System.TypedReference
12084 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
12085 check for TypedReference or ArgIterator, they are not allowed.
12087 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
12088 makes us properly catch 1510 in some conditions (see bug 56016 for
12091 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
12093 * CryptoConvert.cs: update from corlib version
12096 2004-04-05 Miguel de Icaza <miguel@ximian.com>
12098 * class.cs (Indexer.Define): Check indexername declaration
12100 2004-04-05 Marek Safar <marek.safar@seznam.cz>
12102 * attribute.cs (IsClsCompliant): Fixed problem with handling
12103 all three states (compliant, not-compliant, undetected).
12105 2004-03-30 Marek Safar <marek.safar@seznam.cz>
12107 * attribute.cs (Attribute): Location is now public.
12108 (Resolve): Store resolved arguments (pos_values) in attribute class.
12109 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
12110 (GetClsCompliantAttributeValue): New method that gets
12111 CLSCompliantAttribute value.
12112 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
12113 if exists else null.
12114 (AttributeTester): New class for CLS-Compliant verification routines.
12116 * class.cs (Emit): Add CLS-Compliant verification.
12117 (Method.GetSignatureForError): Implemented.
12118 (Constructor.GetSignatureForError): Implemented
12119 (Constructor.HasCompliantArgs): Returns if constructor has
12120 CLS-Compliant arguments.
12121 (Constructor.Emit): Override.
12122 (Construcor.IsIdentifierClsCompliant): New method; For constructors
12123 is needed to test only parameters.
12124 (FieldBase.GetSignatureForError): Implemented.
12125 (TypeContainer): New member for storing base interfaces.
12126 (TypeContainer.FindMembers): Search in base interfaces too.
12128 * codegen.cs (GetClsComplianceAttribute): New method that gets
12129 assembly or module CLSCompliantAttribute value.
12130 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
12132 (ModuleClass.Emit): Add error 3012 test.
12134 * const.cs (Emit): Override and call base for CLS-Compliant tests.
12136 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
12137 state for all decl types.
12138 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
12139 if CLS-Compliant tests are required.
12140 (IsClsCompliaceRequired): New method. Analyze whether code
12141 must be CLS-Compliant.
12142 (IsExposedFromAssembly): New method. Returns true when MemberCore
12143 is exposed from assembly.
12144 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
12145 value or gets cached value.
12146 (HasClsCompliantAttribute): New method. Returns true if MemberCore
12147 is explicitly marked with CLSCompliantAttribute.
12148 (IsIdentifierClsCompliant): New abstract method. This method is
12149 used to testing error 3005.
12150 (IsIdentifierAndParamClsCompliant): New method. Common helper method
12151 for identifier and parameters CLS-Compliant testing.
12152 (VerifyClsCompliance): New method. The main virtual method for
12153 CLS-Compliant verifications.
12154 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
12155 null. I don't know why is null (too many public members !).
12156 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
12157 and get value of first CLSCompliantAttribute that found.
12159 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
12160 (VerifyClsCompliance): Override and add extra tests.
12162 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
12163 clscheck- disable CLS-Compliant verification event if assembly is has
12164 CLSCompliantAttribute(true).
12166 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
12167 ApllyAttribute is now called in emit section as in the other cases.
12168 Possible future Emit integration.
12169 (IsIdentifierClsCompliant): New override.
12170 (VerifyClsCompliance): New override.
12171 (GetEnumeratorName): Returns full enum name.
12173 * parameter.cs (GetSignatureForError): Implemented.
12175 * report.cs (WarningData): New struct for Warning message information.
12176 (LocationOfPreviousError): New method.
12177 (Warning): New method. Reports warning based on the warning table.
12178 (Error_T): New method. Reports error based on the error table.
12180 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12181 verifications are done here.
12183 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12185 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12186 CLSCompliantAttribute.
12187 (all_imported_types): New member holds all imported types from other
12189 (LoadAllImportedTypes): New method fills static table with exported types
12190 from all referenced assemblies.
12191 (Modules): New property returns all assembly modules.
12193 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12195 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12196 throwing a parser error.
12198 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12199 which removes the hardcoded get_/set_ prefixes for properties, as
12200 IL allows for the properties to be named something else.
12204 * expression.cs: Do not override operand before we know if it is
12205 non-null. Fix 56207
12207 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12209 * typemanager.cs: support for pinned variables.
12211 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12213 * decl.cs, typemanager.cs: Avoid using an arraylist
12214 as a buffer if there is only one result set.
12216 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12218 * expression.cs: Make sure you cant call a static method
12219 with an instance expression, bug #56174.
12221 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12223 * class.cs (IsDuplicateImplementation): Improve error reporting to
12224 flag 663 (method only differs in parameter modifier).
12226 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12227 in preprocessor directives.
12229 * location.cs (LookupFile): Allow for the empty path.
12231 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12232 better approach for some of that patch, but its failing with the
12233 CharSet enumeration. For now try/catch will do.
12235 * typemanager.cs: Do not crash if a struct does not have fields.
12238 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12240 * expression.cs: cs0213, cant fix a fixed expression.
12243 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12245 * cs-parser.jay: detect invalid embeded statements gracefully.
12248 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12250 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12253 the invocation type may not be a subclass of the tye of the item/
12254 The type of the item must be a subclass of the invocation item.
12259 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12261 * attribute.cs: Added methods to get a string and a bool from an
12262 attribute. Required to information from AssemblyKeyFileAttribute,
12263 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12264 * codegen.cs: Modified AssemblyName creation to include support for
12265 strongnames. Catch additional exceptions to report them as CS1548.
12266 * compiler.csproj: Updated include CryptoConvert.cs.
12267 * compiler.csproj.user: Removed file - user specific configuration.
12268 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12269 Mono.Security assembly. The original class is maintained and tested in
12270 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12271 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12272 like CSC 8.0 (C# v2) supports.
12273 * Makefile: Added CryptoConvert.cs to mcs sources.
12274 * rootcontext.cs: Added new options for strongnames.
12276 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12278 * driver.cs: For --expect-error, report error code `2'
12279 if the program compiled with no errors, error code `1' if
12280 it compiled with an error other than the one expected.
12282 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12284 * compiler.csproj: Updated for Visual Studio .NET 2003.
12285 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12286 * compiler.sln: Updated for Visual Studio .NET 2003.
12288 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12290 * expression.cs: Fix bug #47234. We basically need to apply the
12291 rule that we prefer the conversion of null to a reference type
12292 when faced with a conversion to 'object' (csc behaviour).
12294 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12296 * statement.cs: Shorter form for foreach, eliminates
12297 a local variable. r=Martin.
12299 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12301 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12302 checks if we can use brtrue/brfalse to test for 0.
12303 * expression.cs: use the above in the test for using brtrue/brfalse.
12304 cleanup code a bit.
12306 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12308 * expression.cs: Rewrite string concat stuff. Benefits:
12310 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12311 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12312 rather than a concat chain.
12314 * typemanager.cs: Add lookups for more concat overloads.
12316 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12318 * expression.cs: Emit shorter il code for array init.
12335 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12337 * statement.cs: Before, two switch blocks would be merged if the
12338 total size of the blocks (end_item - begin_item + 1) was less than
12339 two times the combined sizes of the blocks.
12341 Now, it will only merge if after the merge at least half of the
12346 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12348 * class.cs : csc build fix for GetMethods(). See bug #52503.
12350 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12352 * expression.cs: Make sure fp comparisons work with NaN.
12353 This fixes bug #54303. Mig approved this patch a long
12354 time ago, but we were not able to test b/c the runtime
12357 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12359 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12361 2004-03-19 Martin Baulig <martin@ximian.com>
12363 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12364 two overloads may unify for some type parameter substitutions and
12365 report a CS0408 if appropriate.
12367 2004-03-19 Martin Baulig <martin@ximian.com>
12369 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12370 error here and not in our caller.
12372 2004-03-19 Martin Baulig <martin@ximian.com>
12374 * interface.cs: Completely killed this file.
12375 (Interface): We're now a TypeContainer and live in class.cs.
12377 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12378 argument; we're now also called for interfaces.
12379 (TypeContainer.DefineMembers): Allow this method being called
12381 (TypeContainer.GetMethods): New public method; formerly known as
12382 Interface.GetMethod(). This is used by PendingImplementation.
12383 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12384 it's now private and non-static.
12385 (Interface): Moved this here; it's now implemented similar to
12387 (Method, Property, Event, Indexer): Added `bool is_interface'
12388 argument to their .ctor's.
12389 (MemberBase.IsInterface): New public field.
12391 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12392 instances instead of InterfaceMethod, InterfaceProperty, etc.
12393 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12394 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12396 2004-03-19 Martin Baulig <martin@ximian.com>
12398 * class.cs (MethodCore.IsDuplicateImplementation): New private
12399 method which does the CS0111 checking.
12400 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12401 Use IsDuplicateImplementation().
12403 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12405 * decl.cs (FindMemberToOverride): New method to find the correct
12406 method or property to override in the base class.
12408 - Make Method/Property use the above method to find the
12409 version in the base class.
12410 - Remove the InheritableMemberSignatureCompare as it is now
12413 This patch makes large code bases much faster to compile, as it is
12414 O(n) rather than O(n^2) to do this validation.
12416 Also, it fixes bug 52458 which is that nested classes are not
12417 taken into account when finding the base class member.
12419 Reviewed/Approved by Martin.
12421 2004-03-17 Martin Baulig <martin@ximian.com>
12423 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12424 of type arguments into account; use the `real_num_type_args'
12425 approach like in DoResolveAsTypeStep().
12427 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12430 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12432 * interface.cs: In all interface classes removed redundant
12433 member initialization.
12435 2004-03-16 Martin Baulig <martin@ximian.com>
12437 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12439 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12441 * decl.cs (DefineTypeAndParents): New helper method to define a
12442 type's containers before the type itself is defined; This is a
12443 bug exposed by the recent changes to Windows.Forms when an
12444 implemented interface was defined inside a class that had not been
12447 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12449 (Check): Loop correctly to report errors modifiers
12450 (UNSAFE was not in the loop, since it was the same as TOP).
12452 * interface.cs: Every interface member now takes a ModFlags,
12453 instead of a "is_new" bool, which we set on the base MemberCore.
12455 Every place where we called "UnsafeOk" in the interface, now we
12456 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12457 the unsafe settings from the member declaration instead of the
12458 container interface.
12460 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12462 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12463 `set_indexer_name' to the pending bits (one per type).
12465 We fixed a bug today that was picking the wrong method to
12466 override, since for properties the existing InterfaceMethod code
12467 basically ignored the method name. Now we make sure that the
12468 method name is one of the valid indexer names.
12470 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12472 * support.cs (SeekableStreamReader): Keep track of stream byte
12473 positions and don't mix them with character offsets to the buffer.
12475 Patch from Gustavo Giráldez
12477 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12479 * interface.cs (InterfaceSetGetBase): Removed double member
12480 initialization, base class does it as well.
12482 2004-03-13 Martin Baulig <martin@ximian.com>
12484 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12485 when compiling corlib.
12487 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12489 * convert.cs (ExplicitConversion): We were reporting an error on
12490 certain conversions (object_type source to a value type, when the
12491 expression was `null') before we had a chance to pass it through
12492 the user defined conversions.
12494 * driver.cs: Replace / and \ in resource specifications to dots.
12497 * class.cs: Add check for duplicate operators. Fixes 52477
12499 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12501 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12502 that are in the middle of the statements, not only at the end.
12505 * class.cs (TypeContainer.AddField): No longer set the
12506 `HaveStaticConstructor' flag, now we call it
12507 `UserDefineStaticConstructor' to diferentiate the slightly
12508 semantic difference.
12510 The situation is that we were not adding BeforeFieldInit (from
12511 Modifiers.TypeAttr) to classes that could have it.
12512 BeforeFieldInit should be set to classes that have no static
12517 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12519 And most importantly Zoltan's comment:
12521 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12523 "I think beforefieldinit means 'it's ok to initialize the type sometime
12524 before its static fields are used', i.e. initialization does not need
12525 to be triggered by the first access to the type. Setting this flag
12526 helps the JIT to compile better code, since it can run the static
12527 constructor at JIT time, and does not need to generate code to call it
12528 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12529 this flag for lots of classes like String.
12531 csc sets this flag if the type does not have an explicit static
12532 constructor. The reasoning seems to be that if there are only static
12533 initalizers for a type, and no static constructor, then the programmer
12534 does not care when this initialization happens, so beforefieldinit
12537 This bug prevents the AOT compiler from being usable, since it
12538 generates so many calls to mono_runtime_class_init that the AOT code
12539 is much slower than the JITted code. The JITted code is faster,
12540 because it does not generate these calls if the vtable is type is
12541 already initialized, which is true in the majority of cases. But the
12542 AOT compiler can't do this."
12544 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12546 * class.cs (MethodData.Emit): Refactor the code so symbolic
12547 information is generated for destructors; For some reasons we
12548 were taking a code path that did not generate symbolic information
12551 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12553 * class.cs: Create a Constructor.CheckBase method that
12554 takes care of all validation type code. The method
12555 contains some code that was moved from Define.
12557 It also includes new code that checks for duplicate ctors.
12558 This fixes bug #55148.
12560 2004-03-09 Joshua Tauberer <tauberer@for.net>
12562 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12563 a { ... }-style array creation invokes EmitStaticInitializers
12564 which is not good for reference-type arrays. String, decimal
12565 and now null constants (NullCast) are not counted toward
12566 static initializers.
12568 2004-03-05 Martin Baulig <martin@ximian.com>
12570 * location.cs (SourceFile.HasLineDirective): New public field;
12571 specifies whether the file contains or is referenced by a "#line"
12573 (Location.DefineSymbolDocuments): Ignore source files which
12574 either contain or are referenced by a "#line" directive.
12576 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12578 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12579 direct access to our parent, so check the method inline there.
12581 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12583 * expression.cs (Invocation.EmitCall): Miguel's last commit
12584 caused a regression. If you had:
12589 In Foo the implict this would be null.
12591 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12593 * expression.cs (Invocation.EmitCall): If the method is not
12594 virtual, do not emit a CallVirt to it, use Call.
12596 * typemanager.cs (GetFullNameSignature): Improve the method to
12597 cope with ".ctor" and replace it with the type name.
12599 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12600 as an argument the ConstructorBuilder where it is being defined,
12601 to catch the recursive constructor invocations.
12603 2004-03-16 Martin Baulig <martin@ximian.com>
12605 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12606 ConstructedType, call ResolveType() on it to get the type rather
12607 than just using `expr.Type'.
12609 2004-03-16 Martin Baulig <martin@ximian.com>
12611 * generics.cs (ConstructedType.GetMemberAccess): Take the
12612 EmitContext instead on the TypeExpr and use
12613 ec.TypeContainer.CurrentType/ec.ContainerType.
12615 2004-03-16 Martin Baulig <martin@ximian.com>
12617 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12618 parameters before aliases.
12620 2004-03-16 Martin Baulig <martin@ximian.com>
12622 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12623 New oublic function; checks whether two generic instances may become
12624 equal under some instantiations (26.3.1).
12626 * class.cs (TypeContainer.Define): Call
12627 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12630 2004-03-16 Martin Baulig <martin@ximian.com>
12632 * class.cs (TypeContainer.GetClassBases): Moved
12633 Error_TypeParameterAsBase() here and also check whether the base
12634 class is not an attribute.
12636 2004-03-16 Martin Baulig <martin@ximian.com>
12638 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12640 2004-03-16 Martin Baulig <martin@ximian.com>
12642 * class.cs (Error_TypeParameterAsBase): Use correct error number
12645 2004-03-16 Martin Baulig <martin@ximian.com>
12647 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12650 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12653 2004-03-15 Martin Baulig <martin@ximian.com>
12655 * typemanager.cs (TypeManager.GetFullName): New public method.
12656 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12657 argument; only return members with the correct number of type
12659 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12660 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12661 whether the number of type arguments matches.
12663 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12664 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12666 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12667 field; it's set by the protected .ctor when we're actually a
12668 GenericMemberAccess.
12669 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12670 arguments and pass it to MemberLookupFinal ().
12672 * ecore.cs (Expression.MemberLookup): Added `int
12673 num_type_arguments' argument; only return members with the correct
12674 number of type arguments.
12675 (Expression.MemberLookupFailed): Check whether the MemberLookup
12676 failed because we did not have the correct number of type
12677 arguments; report CS0305 in this case.
12679 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12680 `e.ResolveAsTypeTerminal()' already did so.
12682 2004-03-15 Martin Baulig <martin@ximian.com>
12684 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12685 we're a ConstructedType; in this case, the caller must report an
12686 error (for instance CS0131).
12688 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12689 (TypeArguments.Resolve): Actually report errors here.
12691 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12693 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12694 `set_indexer_name' to the pending bits (one per type).
12696 We fixed a bug today that was picking the wrong method to
12697 override, since for properties the existing InterfaceMethod code
12698 basically ignored the method name. Now we make sure that the
12699 method name is one of the valid indexer names.
12701 2004-03-15 Martin Baulig <martin@ximian.com>
12703 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12704 for generic instances.
12706 2004-03-13 Martin Baulig <martin@ximian.com>
12708 * class.cs (TypeContainer.DefineType): Call
12709 TypeManager.AddUserType() immediately after creating the
12710 TypeBuilder; pass all type parameters when creating the
12713 * decl.cs (DeclSpace.FindNestedType): New public method.
12714 (DeclSpace.FindType): Added `int num_type_args' argument; only
12715 return types with the correct number of type parameters.
12716 (DeclSpace.CountTypeParams): New public property.
12718 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12719 the number of type parameters; defaults to zero.
12721 * generic.cs (TypeArguments.Count): New public property.
12722 (ConstructedType.DoResolveAsTypeStep): First call
12723 ds.FindNestedType() to find out whether we're nested in the
12724 current generic type; in this case, we inherit all type parameters
12725 from the current class.
12727 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12728 num_type_args' argument.
12729 (RootContext.LookupType): Added overloaded version which takes the
12730 number of type arguments; only return types with the correct
12731 number of type arguments.
12733 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12734 checks whether `Type t' has `int num_type_args'.
12736 2004-03-13 Martin Baulig <martin@ximian.com>
12738 * generic.cs (GenericMethod.DefineType): New method; calls
12739 DefineType() on all the type parameters.
12741 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12742 (MethodData.Define): If we're a generic method, call
12743 GenericMethod.DefineType() to define the type parameters.
12745 2004-03-10 Martin Baulig <martin@ximian.com>
12747 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12748 instead of IsAssignableFrom.
12750 2004-03-10 Martin Baulig <martin@ximian.com>
12752 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12754 * support.cs (ParameterData.HasArrayParameter): New property.
12755 (ReflectionParameters.ctor): Take a MethodBase instead of a
12756 ParameterInfo[]. If we have any type parameters, get the generic
12757 method definition and ask it whether we have variable arguments.
12759 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12761 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12762 routines to check if a type is an enumerable/enumerator allow
12763 classes that implement the IEnumerable or IEnumerator interfaces.
12765 * class.cs (Property, Operator): Implement IIteratorContainer, and
12766 implement SetYields.
12768 (Property.Define): Do the block swapping for get_methods in the
12769 context of iterators. We need to check if Properties also
12770 include indexers or not.
12772 (Operator): Assign the Block before invoking the
12773 OperatorMethod.Define, so we can trigger the Iterator code
12776 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12777 Property and Operator classes are not created when we parse the
12778 declarator but until we have the block completed, so we use a
12779 singleton SimpleIteratorContainer.Simple to flag whether the
12780 SetYields has been invoked.
12782 We propagate this setting then to the Property or the Operator to
12783 allow the `yield' to function.
12785 2004-02-25 Marek Safar <marek.safar@seznam.cz>
12787 * codegen.cs: Implemented attribute support for modules.
12788 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
12789 Assembly/Module functionality.
12791 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
12792 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
12793 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
12795 2004-02-16 Marek Safar <marek.safar@seznam.cz>
12797 * interface.cs (FindMembers): The operation is performed on all base
12798 interfaces and not only on the first. It is required for future CLS Compliance patch.
12800 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
12802 * statement.cs, codegen.cs:
12803 This patch deals with patterns such as:
12805 public class List : IEnumerable {
12807 public MyEnumerator GetEnumerator () {
12808 return new MyEnumerator(this);
12811 IEnumerator IEnumerable.GetEnumerator () {
12815 public struct MyEnumerator : IEnumerator {
12820 Before, there were a few things we did wrong:
12821 1) we would emit callvirt on a struct, which is illegal
12822 2) we emited ldarg when we needed to emit ldarga
12823 3) we would mistakenly call the interface methods on an enumerator
12824 type that derived from IEnumerator and was in another assembly. For example:
12826 public class MyEnumerator : IEnumerator
12828 Would have the interface methods called, even if there were public impls of the
12829 method. In a struct, this lead to invalid IL code.
12831 2004-02-11 Marek Safar <marek.safar@seznam.cz>
12833 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
12836 * delegate.cs (Define): Fixed crash when delegate type is undefined.
12838 2004-02-11 Miguel de Icaza <miguel@ximian.com>
12840 * cs-parser.jay: Fix small regression: we were not testing V2
12841 compiler features correctly.
12843 * interface.cs: If the emit context is null, then create one
12845 2004-02-09 Marek Safar <marek.safar@seznam.cz>
12847 * decl.cs (GetSignatureForError): New virtual method to get full name
12848 for error messages.
12850 * attribute.cs (IAttributeSupport): New interface for attribute setting.
12851 Now it is possible to rewrite ApplyAttributes method to be less if/else.
12853 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
12854 Duplicated members and code in these classes has been removed.
12855 Better encapsulation in these classes.
12857 2004-02-07 Miguel de Icaza <miguel@ximian.com>
12859 * assign.cs (Assign.DoResolve): When dealing with compound
12860 assignments, there is a new rule in ECMA C# 2.4 (might have been
12861 there before, but it is documented here) that states that in:
12865 If b is of type int, and the `op' is a shift-operator, then the
12866 above is evaluated as:
12870 * expression.cs (Binary.ResolveOperator): Instead of testing for
12871 int/uint/long/ulong, try to implicitly convert to any of those
12872 types and use that in pointer arithmetic.
12874 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
12875 method to print information for from the type, not from the
12876 null-method we were given.
12878 2004-02-01 Duncan Mak <duncan@ximian.com>
12880 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
12881 parsing for cmd, fixes bug #53694.
12883 2004-02-04 Marek Safar <marek.safar@seznam.cz>
12885 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
12886 in the member name duplication tests. Property and operator name duplication
12887 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
12889 2004-02-03 Marek Safar <marek.safar@seznam.cz>
12891 * interface.cs (PopulateMethod): Fixed crash when interface method
12892 returns not existing type (error test cs0246-3.cs).
12894 2004-02-02 Ravi Pratap M <ravi@ximian.com>
12896 * cs-parser.jay (interface_accessors): Re-write actions to also
12897 store attributes attached to get and set methods. Fix spelling
12900 (inteface_property_declaration): Modify accordingly.
12902 (InterfaceAccessorInfo): New helper class to store information to pass
12903 around between rules that use interface_accessors.
12905 * interface.cs (Emit): Apply attributes on the get and set
12906 accessors of properties and indexers too.
12908 * attribute.cs (ApplyAttributes): Modify accordingly to use the
12909 right MethodBuilder when applying attributes to the get and set accessors.
12911 2004-01-31 Miguel de Icaza <miguel@ximian.com>
12913 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
12915 2004-01-26 Miguel de Icaza <miguel@ximian.com>
12917 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
12919 2004-01-25 Miguel de Icaza <miguel@ximian.com>
12921 * cs-parser.jay: Remove YIELD token, instead use the new grammar
12922 changes that treat `yield' specially when present before `break'
12923 or `return' tokens.
12925 * cs-tokenizer.cs: yield is no longer a keyword.
12927 2004-01-23 Marek Safar <marek.safar@seznam.cz>
12929 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
12930 setting for default constructors.
12931 For default constructors are almost every time set wrong Modifier. The
12932 generated IL code has been alright. But inside mcs this values was
12933 wrong and this was reason why several of my CLS Compliance tests
12936 2004-02-27 Martin Baulig <martin@ximian.com>
12938 * generics.cs (ConstructedType.ResolveType): Make the nested type
12939 stuff actually work.
12941 2004-02-25 Martin Baulig <martin@ximian.com>
12943 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
12944 property; returns the type parameters just from the current type,
12945 ie. with the ones from outer classes.
12946 (DeclSpace.LookupGeneric): First search in the current class, then
12948 (DeclSpace.initialize_type_params): When hiding a type parameter
12949 from an outer class, put it into the `type_param_list' anyways.
12951 * expression.cs (MemberAccess.expr): Made this field protected.
12953 * class.cs (TypeContainer.Define): The `CurrentType' just contains
12954 the type parameters from the current class.
12956 * generic.cs (ConstructedType.ResolveType): Support nested generic
12957 types by taking the type parameters which we inherit from outer
12958 classes into account.
12959 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
12960 support for nested generic types.
12962 2004-02-23 Martin Baulig <martin@ximian.com>
12964 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
12965 field and check whether we're nested inside a generic type.
12966 (DeclSpace.ResolveType): If we're resolving to a generic type
12967 definition, create a ConstructedType and return its resolved type.
12968 (DeclSpace.initialize_type_params): New private method;
12969 initializes the `type_param_list' field from the type parameters
12970 from this and all enclosing classes.
12971 (DeclSpace.TypeParameters): Call initialize_type_params() unless
12972 we're already initialized.
12974 2004-02-23 Martin Baulig <martin@ximian.com>
12976 * class.cs (Method.Define): Create the generic method before
12977 calling DoDefine().
12978 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
12979 the TypeContainer one); we use this for generic methods.
12981 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
12982 parent's TypeBuilder.
12984 2004-02-18 Martin Baulig <martin@ximian.com>
12986 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
12987 to check for equality.
12989 2004-02-05 Martin Baulig <martin@ximian.com>
12991 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
12992 `ec.TypeContainer.CurrentType', use it instead of
12993 `ec.ContainerType' to check whether we're in the type's ctor.
12995 2004-01-29 Martin Baulig <martin@ximian.com>
12997 * expression.cs (Invocation.DoResolve): If we're a
12998 `ConstructedType', then we're actually a generic method, so
12999 rewrite the expr as a GenericMemberAccess.
13001 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
13002 here; manually parse it into a string.
13004 2004-01-28 Martin Baulig <martin@ximian.com>
13006 * typemanager.cs (TypeManager.IsEqual): New static method.
13007 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
13008 check for equality instead of using `=='.
13010 2004-01-26 Martin Baulig <martin@ximian.com>
13012 * decl.cs (DeclSpace.CurrentType): New public field.
13014 * expression.cs (This.ResolveBase): If we have an
13015 `ec.TypeContainer.CurrentType', use it instead of
13016 `ec.ContainerType'.
13018 * class.cs (TypeContainer.DefineType): If we're a generic type,
13019 create the `CurrentType' (unresolved).
13020 (TypeContainer.GenericType): New private field.
13021 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
13022 it and store it in `GenericType' before creating the MemberCache.
13023 (TypeContainer.GetMembers): If we have a `GenericType', call
13024 TypeManager.FindMembers() on it.
13026 * interface.cs (Interface.GenericType): New private field.
13027 (Interface.DefineType): If we're a generic type, create the
13028 `CurrentType' (unresolved).
13029 (Interface.DefineMembers): If we have a `CurrentType', resolve it
13030 and store it in `GenericType' before creating the MemberCache.
13031 (Interface.GetMembers): If we have a `GenericType', call
13032 TypeManager.FindMembers() on it.
13034 2004-01-22 Martin Baulig <martin@ximian.com>
13036 * cs-parser.jay (namespace_or_type_name): Return an Expression,
13037 not a QualifiedIdentifier. This is what `type_name_expression'
13038 was previously doing.
13039 (type_name_expression): Removed; the code is now in
13040 `namespace_or_type_name'.
13041 (qualified_identifier): Removed, use `namespace_or_type_name'
13043 (QualifiedIdentifier): Removed this class.
13045 2004-01-22 Martin Baulig <martin@ximian.com>
13047 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
13048 not a string as alias name.
13050 2004-01-21 Miguel de Icaza <miguel@ximian.com>
13052 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
13053 #52730 bug, and instead compute correctly the need to use a
13054 temporary variable when requesting an address based on the
13055 static/instace modified of the field and the constructor.
13057 2004-01-21 Martin Baulig <martin@ximian.com>
13059 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
13060 class and namespace before looking up aliases. Fixes #52517.
13062 2004-01-21 Martin Baulig <martin@ximian.com>
13064 * flowanalysis.cs (UsageVector.Merge): Allow variables being
13065 assinged in a 'try'; fixes exception4.cs.
13067 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13068 * class.cs : Implemented parameter-less constructor for TypeContainer
13070 * decl.cs: Attributes are now stored here. New property OptAttributes
13072 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
13074 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
13076 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13078 * typemanager.cs (CSharpSignature): Now reports also inner class name.
13079 (CSharpSignature): New method for indexer and property signature.
13081 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13083 * pending.cs (IsVirtualFilter): Faster implementation.
13085 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13087 * typemanager.cs: Avoid inclusion of same assembly more than once.
13089 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13091 * cs-parser.jay: Fixed problem where the last assembly attribute
13092 has been applied also to following declaration (class, struct, etc.)
13094 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13096 * class.cs: Added error CS0538, CS0539 reporting.
13097 Fixed crash on Microsoft runtime when field type is void.
13099 * cs-parser.jay: Added error CS0537 reporting.
13101 * pending.cs: Added error CS0535 reporting.
13102 Improved error report for errors CS0536, CS0534.
13104 2004-01-20 Miguel de Icaza <miguel@ximian.com>
13106 Merge a few bits from the Anonymous Method MCS tree.
13108 * statement.cs (ToplevelBlock): New class for toplevel methods,
13109 will hold anonymous methods, lifted variables.
13111 * cs-parser.jay: Create toplevel blocks for delegates and for
13112 regular blocks of code.
13114 2004-01-20 Martin Baulig <martin@ximian.com>
13116 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
13117 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
13118 and `NeedExplicitReturn'; added `IsLastStatement'.
13119 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
13120 have a `ReturnLabel' or we're not unreachable.
13122 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
13123 child's reachability; don't just override ours with it. Fixes
13124 #58058 (lluis's example).
13125 (FlowBranching): Added public InTryOrCatch(), InCatch(),
13126 InFinally(), InLoop(), InSwitch() and
13127 BreakCrossesTryCatchBoundary() methods.
13129 * statement.cs (Return): Do all error checking in Resolve().
13130 Unless we are the last statement in a top-level block, always
13131 create a return label and jump to it.
13132 (Break, Continue): Do all error checking in Resolve(); also make
13133 sure we aren't leaving a `finally'.
13134 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
13135 statement in a top-level block.
13136 (Block.Flags): Added `IsDestructor'.
13137 (Block.IsDestructor): New public property.
13139 2004-01-20 Martin Baulig <martin@ximian.com>
13141 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
13143 2004-01-20 Martin Baulig <martin@ximian.com>
13145 * statement.cs (Statement.ResolveUnreachable): New public method.
13146 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
13147 (Block.Resolve): Resolve unreachable statements.
13149 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13151 * expression.cs: We need to fix the case where we do
13152 not have a temp variable here.
13154 * assign.cs: Only expression compound assignments need
13155 temporary variables.
13157 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13159 * flowanalysis.cs: Reduce memory allocation in a few ways:
13160 - A block with no variables should not allocate a bit
13162 - A method with no out parameters does not need any tracking
13163 for assignment of the parameters, so we need not allocate
13166 public readonly Type[] VariableTypes;
13167 public readonly string[] VariableNames;
13168 Are redundant. The data is already stored in the variable
13169 map, so we need not allocate another array for it.
13170 - We need to add alot of checks for if (params | locals) == null
13171 due to the first two changes.
13173 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13175 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13176 implement IMemoryLocation, we store a copy on a local variable and
13177 take the address of it. Patch from Benjamin Jemlich
13179 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13180 to use a special "type_name_expression" rule which reduces the
13181 number of "QualifiedIdentifier" classes created, and instead
13182 directly creates MemberAccess expressions.
13184 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13186 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13187 that fixes #52853. Null literal assignment to ValueType
13189 * class.cs (MethodData.Emit): Instead of checking the name of the
13190 method to determine if its a destructor, create a new derived
13191 class from Method called Destructor, and test for that.
13193 * cs-parser.jay: Create a Destructor object instead of a Method.
13195 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13199 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13201 * expression.cs (Binary.ResolveOperator): Perform an implicit
13202 conversion from MethodGroups to their delegate types on the
13203 Addition operation.
13205 * delegate.cs: Introduce a new class DelegateCreation that is the
13206 base class for `NewDelegate' and `ImplicitDelegateCreation',
13207 factor some code in here.
13209 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13210 conversion from MethodGroups to compatible delegate types.
13212 * ecore.cs (Expression.Resolve): Do not flag error 654
13213 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13214 we allow conversions from MethodGroups to delegate types now.
13216 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13217 assignments in v2 either.
13219 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13221 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13222 static read-only fields in ctors.
13224 Applied patch from Benjamin Jemlich
13226 * expression.cs (UnaryMutator): Avoid leaking local variables.
13228 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13230 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13231 here to return true, as they can be used like this:
13233 (XXX) int.MEMBER ()
13235 Fixed 49836 and all the other dups
13237 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13239 * driver.cs: Implement /win32res and /win32icon.
13241 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13243 * cs-parser.jay: Add a rule to improve error handling for the
13244 common mistake of placing modifiers after the type.
13246 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13248 * cs-parser.jay (interface_event_declaration): Catch
13249 initialization of events on interfaces, and report cs0068
13251 * cs-parser.jay (interface_event_declaration): Catch
13252 initialization of events.
13254 * ecore.cs: Better report missing constructors.
13256 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13257 the error reporting done in the wrong place. Fix.
13259 * expression.cs (Binary.ResolveOperator): Catch the
13260 operator + (E x, E y) error earlier, and later allow for implicit
13261 conversions in operator +/- (E e, U x) from U to the underlying
13264 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13265 52596, if the container class is abstract, the default constructor
13266 is protected otherwise its public (before, we were always public).
13268 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13271 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13272 Jemlich that fixes bug #52597, MCS was generating invalid code for
13273 idisposable structs. Thanks to Ben for following up with this
13276 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13278 * driver.cs: Allow assemblies without code to be generated, fixes
13281 2004-01-07 Nick Drochak <ndrochak@gol.com>
13283 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13285 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13287 * cs-parser.jay: Add rules to improve error reporting if fields or
13288 methods are declared at the namespace level (error 116)
13290 * Add rules to catch event add/remove
13292 2004-01-04 David Sheldon <dave-mono@earth.li>
13294 * expression.cs: Added matching ")" to error message for
13297 2004-01-03 Todd Berman <tberman@gentoo.org>
13299 * ecore.cs, attribute.cs:
13300 Applying fix from #52429.
13302 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13304 * ecore.cs, expression.cs, statement.cs:
13305 Total rewrite of how we handle branching. We
13306 now handle complex boolean expressions with fewer
13307 jumps. As well if (x == 0) no longer emits a ceq.
13309 if (x is Foo) is much faster now, because we generate
13312 Overall, we get a pretty big improvement on our benchmark
13313 tests. The code we generate is smaller and more readable.
13315 I did a full two-stage bootstrap. The patch was reviewed
13316 by Martin and Miguel.
13318 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13320 * cs-parser.jay: Make primary_expression not take a QI.
13321 we dont need this because the member_access rule covers
13322 us here. So we replace the rule with just IDENTIFIER.
13324 This has two good effects. First, we remove a s/r conflict.
13325 Second, we allocate many fewer QualifiedIdentifier objects.
13327 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13329 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13330 set the correct information via SRE. This prevents
13331 hanging on the MS runtime. Fixes #29374.
13333 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13335 * convert.cs: correctly handle conversions to value types
13336 from Enum and ValueType as unboxing conversions.
13338 Fixes bug #52569. Patch by Benjamin Jemlich.
13340 2004-01-02 Ravi Pratap <ravi@ximian.com>
13342 * expression.cs (BetterConversion): Prefer int -> uint
13343 over int -> ulong (csc's behaviour). This fixed bug #52046.
13345 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13347 * decl.cs (MemberCache.FindMembers): now returns a
13350 * typemanager.cs: In general, go with with ^^.
13351 (CopyNewMethods): take an IList.
13352 (RealMemberLookup): Only allocate an arraylist
13353 if we copy from two sets of methods.
13355 This change basically does two things:
13356 1) Fewer array lists allocated due to CopyNewMethods.
13357 2) the explicit cast in MemberList costed ALOT.
13359 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13361 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13362 a hashtable to avoid needless string allocations when an identifier is
13363 used more than once (the common case).
13365 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13367 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13368 is broken, it will not return anything. So, we
13369 have to use the information we have in mcs to
13372 * typemanager.cs: Add a cache for GetInterfaces,
13373 since this will now be used more often (due to ^^)
13375 (GetExplicitInterfaces) New method that gets the
13376 declared, not effective, interfaces on a type
13377 builder (eg, if you have interface IFoo, interface
13378 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13381 This patch makes MCS able to bootstrap itself on
13384 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13386 * expression.cs: Remove the Nop's that Miguel put
13389 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13391 * report.cs, codegen.cs: Give the real stack trace to
13392 the error when an exception is thrown.
13394 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13396 * decl.cs: only allocate hashtables for ifaces if
13399 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13401 * expression.cs: fix the error from cs0121-2.cs
13402 (a parent interface has two child interfaces that
13403 have a function with the same name and 0 params
13404 and the function is called through the parent).
13406 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13408 * class.cs, rootcontext.cs, typmanager.cs: do not
13411 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13413 * codegen.cs: remove stack for the ec flow branching.
13414 It is already a linked list, so no need.
13416 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13418 * Makefile: Allow custom profiler here.
13420 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13422 * typemanager.cs (LookupType):
13423 - Use a static char [], because split takes
13424 a param array for args, so it was allocating
13426 - Do not store true in a hashtable, it boxes.
13428 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13430 * flowanalysis.cs: bytify common enums.
13432 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13434 * modifiers.cs: Add a new set of flags for the
13435 flags allowed on explicit interface impls.
13436 * cs-parser.jay: catch the use of modifiers in
13437 interfaces correctly.
13438 * class.cs: catch private void IFoo.Blah ().
13440 All related to bug #50572.
13442 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13444 * decl.cs: Rewrite the consistant accessability checking.
13445 Accessability is not linear, it must be implemented in
13446 a tableish way. Fixes #49704.
13448 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13450 * expression.cs: Handle negation in a checked context.
13451 We must use subtraction from zero. Fixes #38674.
13453 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13455 * class.cs: Ignore static void main in DLLs.
13456 * rootcontext.cs: Handle the target type here,
13457 since we are have to access it from class.cs
13458 * driver.cs: account for the above.
13460 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13462 * report.cs: Give line numbers and files if available.
13464 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13466 * driver.cs: Implement /addmodule.
13468 * typemanager.cs: Change 'modules' field so it now contains Modules not
13471 2003-12-20 Martin Baulig <martin@ximian.com>
13473 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13474 (FieldBase.IsAssigned): Removed this field.
13475 (FieldBase.SetAssigned): New public method.
13476 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13478 2003-12-20 Martin Baulig <martin@ximian.com>
13480 * expression.cs (LocalVariableReference.DoResolve): Don't set
13481 `vi.Used' if we're called from DoResolveLValue().
13483 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13484 returns the usage vector it just merged into the current one -
13485 pass this one to UsageWarning().
13486 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13487 of the `EmitContext', don't call this recursively on our children.
13489 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13491 * driver.cs: Implement /target:module.
13493 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13495 * support.cs (CharArrayHashtable): New helper class.
13497 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13498 char arrays, not strings, so we can avoid creating a string in
13499 consume_identifier if the identifier is a keyword.
13501 2003-12-16 Martin Baulig <martin@ximian.com>
13503 * statement.cs (LocalInfo.Assigned): Removed this property.
13504 (LocalInfo.Flags): Removed `Assigned'.
13505 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13506 and uses flow analysis.
13507 (Block.UsageWarning): Made this method private.
13508 (Block.Resolve): Call UsageWarning() if appropriate.
13510 * expression.cs (LocalVariableReference.DoResolve): Always set
13511 LocalInfo.Used here.
13513 2003-12-13 Martin Baulig <martin@ximian.com>
13515 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13516 any value here; we're now using flow analysis to figure out
13517 whether a statement/block returns a value.
13519 2003-12-13 Martin Baulig <martin@ximian.com>
13521 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13523 (FlowBranching.MergeFinally): Don't call
13524 `branching.CheckOutParameters()' here, this is called in
13526 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13527 when adding the `finally' vector.
13529 2003-12-13 Martin Baulig <martin@ximian.com>
13532 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13533 actually work and also fix #48962.
13535 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13537 * decl.cs: Do not check System.Object for nested types,
13538 since we know it does not have any. Big bang for buck:
13541 Run 1: 8.35 seconds
13542 Run 2: 8.32 seconds
13543 corlib: 17.99 seconds
13545 Run 1: 8.17 seconds
13546 Run 2: 8.17 seconds
13547 corlib: 17.39 seconds
13549 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13551 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13552 time we are returning 0 members, so we save alot here.
13554 2003-12-11 Martin Baulig <martin@ximian.com>
13556 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13557 `MergeChild()', also just take the `FlowBranching' as argument;
13558 call Merge() on it and return the result.
13559 (FlowBranching.Merge): We don't need to do anything if we just
13562 2003-12-11 Martin Baulig <martin@ximian.com>
13564 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13565 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13566 Maurer for this idea.
13568 2003-12-11 Martin Baulig <martin@ximian.com>
13570 * flowanalysis.cs (MergeResult): This class is now gone; we now
13571 use the `UsageVector' for this. The reason for this is that if a
13572 branching just has one sibling, we don't need to "merge" them at
13573 all - that's the next step to do.
13574 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13577 2003-12-11 Martin Baulig <martin@ximian.com>
13579 Reworked flow analyis and made it more precise and bug-free. The
13580 most important change is that we're now using a special `Reachability'
13581 class instead of having "magic" meanings of `FlowReturns'. I'll
13582 do some more cleanups and optimizations and also add some more
13583 documentation this week.
13585 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13586 largely reworked this class.
13587 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13588 the new `Reachability' class instead of having "magic" values here.
13589 (FlowBranching): We're now using an instance of `Reachability'
13590 instead of having separate `Returns', `Breaks' etc. fields.
13592 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13593 based on flow analysis; ignore the return value of block.Emit ().
13595 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13597 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13598 if they are private.
13600 2003-12-09 Martin Baulig <martin@ximian.com>
13602 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13603 call them directly on the UsageVector.
13605 2003-12-09 Martin Baulig <martin@ximian.com>
13607 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13608 Changed return type from `FlowReturns' to `Reachability'.
13610 2003-12-09 Martin Baulig <martin@ximian.com>
13612 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13613 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13614 `Reachable' fields with a single `Reachability' one.
13616 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13618 * class.cs (FindMembers): Remove foreach's.
13623 Run 1: 8.74 seconds
13624 Run 2: 8.71 seconds
13627 Run 1: 8.64 seconds
13628 Run 2: 8.58 seconds
13631 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13636 This patch does a few things:
13637 1. EmptyStatement is now a singleton, so it is never reallocated.
13638 2. All blah is EmptyStatement constructs have been changed to
13639 blah == EmptyStatement.Value, which is much faster and valid
13640 now that EmptyStatement is a singleton.
13641 3. When resolving a block, rather than allocating a new array for
13642 the non-empty statements, empty statements are replaced with
13643 EmptyStatement.Value
13644 4. Some recursive functions have been made non-recursive.
13645 Mainly the performance impact is from (3), however (1) and (2) are needed for
13646 this to work. (4) does not make a big difference in normal situations, however
13647 it makes the profile look saner.
13652 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13653 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13654 Total memory allocated: 56397 KB
13657 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13658 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13659 Total memory allocated: 55666 KB
13661 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13663 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13664 than the hashtable in a hashtable version
13666 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13667 we always end up concating a string. This results in a huge perf
13668 loss, because many strings have to be tracked by the GC. In this
13669 patch, we first use a hashtable that works with two keys, so that
13670 the strings do not need to be concat'ed.
13674 Run 1: 8.74 seconds
13675 Run 2: 8.71 seconds
13678 Run 1: 8.65 seconds
13679 Run 2: 8.56 seconds
13681 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13683 * Makefile: Add a new target `do-time' that does a quick and simple
13684 profile, leaving easy to parse output.
13686 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13688 * codegen.cs (Init): Create the dynamic assembly with
13689 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13691 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13693 * support.cs: Make the PtrHashtable use only one
13694 instance of its comparer.
13696 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13698 * typemanager.cs: Fix lookup of GetNamespaces.
13700 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13702 * expression.cs: Removed redundant line.
13704 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13705 ArrayLists, use for loops with bounds.
13707 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13710 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13711 arraylists, use for loop with bounds.
13713 The above three changes give us a 0.071 second performance
13714 improvement out of 3.294 seconds down to 3.223. On my machine
13715 the above changes reduced the memory usage by 1,387 KB during
13716 compiler bootstrap.
13718 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13719 QualifiedIdentifiers. Before we created a new string through
13720 concatenation, and mostly later on, the result would be
13721 manipulated by DecomposeQI through string manipulation.
13723 This reduced the compiler memory usage for bootstrapping from
13724 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13725 compile times in 0.05 seconds.
13727 2003-11-28 Dick Porter <dick@ximian.com>
13729 * support.cs: Do string compares with the Invariant culture.
13737 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13738 the comparison is done with the Invariant culture.
13740 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13742 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13743 GetEnumerator method.
13745 (ProbeCollectionType): Iterate starting at the most specific type
13746 upwards looking for a GetEnumerator
13748 * expression.cs: Shift count can be up to 31 for int/uint and 63
13751 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13753 * statement.cs (Block.LookupLabel): Also look for the label on the
13754 children blocks. Use a hash table to keep track of visited
13757 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13758 we actually did transform the other operand, otherwise fall back
13759 to the common codepath that casts to long.
13761 * cs-tokenizer.cs: Use the same code pattern as the int case.
13762 Maybe I should do the parsing myself, and avoid depending on the
13763 Parse routines to get this done.
13765 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13767 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13768 which fixes bug 51347. This time test it.
13770 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13771 attributes for example can not tell the difference between these.
13772 The difference was only a syntax feature of the language.
13774 * attribute.cs: Apply attributes to delegates.
13776 * delegate.cs: Call the apply attributes method.
13778 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13780 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13781 comparing 0 vs Byte.MinValue, not the value
13783 (ImplicitConversionRequired): When reporting a conversion error,
13784 use error 31 to print out the constant error instead of the
13787 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13788 which fixes bug 51347.
13790 2003-11-22 Miguel de Icaza <miguel@ximian.com>
13792 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
13793 which fixes the -warnaserror command line option.
13795 2003-11-21 Miguel de Icaza <miguel@ximian.com>
13797 * cfold.cs (DoNumericPromotions): During constant folding of
13798 additions on UIntConstant, special case intconstants with
13799 IntConstants like we do on the expression binary operator.
13801 2003-11-12 Miguel de Icaza <miguel@ximian.com>
13803 * convert.cs (ImplicitReferenceConversion): We were missing a case
13804 (System.Enum are not value types or class types, so we need to
13805 classify them separatedly).
13807 * driver.cs: We do not support error 2007.
13809 2003-11-12 Jackson Harper <jackson@ximian.com>
13811 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
13812 system directory. Also use the full file name so users can
13813 libraries names mscorlib-o-tron.dll in a non system dir.
13815 2004-01-04 David Sheldon <dave-mono@earth.li>
13817 * expression.cs: Added matching ")" to error message for CS0077.
13819 2003-12-19 Martin Baulig <martin@ximian.com>
13821 * typemanager.cs (TypeManager.IsEqualGenericType): New public
13822 static method; see documentation in the method.
13823 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
13825 * convert.cs (Convert.ImplicitReferenceConversion,
13826 Convert.ImplicitReferenceConversionExists): Add support for
13827 generic type declarations; see gen-36.cs.
13829 2003-12-19 Martin Baulig <martin@ximian.com>
13831 * pending.cs (Pending.InterfaceMethod): Use
13832 `Type.IsAssignableFrom()' instead of `=='.
13834 2003-12-18 Martin Baulig <martin@ximian.com>
13836 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
13839 * convert.cs (Convert.ImplicitStandardConversionExists): Use
13840 `expr_type.Equals (target_type)' instead of `=='.
13842 2003-12-08 Martin Baulig <martin@ximian.com>
13844 * generics.cs (Constraints.Types): Removed.
13845 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
13847 (Constraints.ResolveTypes): New public method; resolves the
13848 TypeExpr's to Type's.
13849 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
13850 longer takes the constraints.
13851 (TypeParameter.DefineMethod): Likewise.
13852 (TypeParameter.DefineType): New public method. Calls
13853 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
13856 2003-12-08 Martin Baulig <martin@ximian.com>
13858 * convert.cs (Convert.ImplicitConversionStandard): Use
13859 `expr_type.Equals (target_type)' instead of `=='.
13861 2003-12-08 Martin Baulig <martin@ximian.com>
13863 * typemanager.cs (TypeManager.GetReferenceType): Call
13864 `Type.MakeByRefType ()'.
13866 2003-12-08 Martin Baulig <martin@ximian.com>
13868 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
13869 just has some special meaning in some situations. For instance,
13870 it is allowed to use `where' as the name of a variable etc.
13872 2003-12-04 Martin Baulig <martin@ximian.com>
13874 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13875 `Type.MakeArrayType()' for array types.
13877 2003-11-18 Miguel de Icaza <miguel@ximian.com>
13879 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
13882 (SizeOf.DoResolve): assign the `type_queried' field. This gets
13885 2003-11-16 Martin Baulig <martin@ximian.com>
13887 * codegen.cs (EmitContext.IsGeneric): Removed.
13889 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
13890 ResolveGeneric() on the DeclSpace.
13892 2003-11-16 Martin Baulig <martin@ximian.com>
13894 * generic.cs (TypeArguments.Resolve):
13895 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
13896 `ResolveType()' on it to get the Type.
13898 2003-11-15 Martin Baulig <martin@ximian.com>
13900 * generic.cs (ConstructedType.GetInterfaces): Override this.
13902 2003-11-14 Martin Baulig <martin@ximian.com>
13904 * interface.cs (Interface.DefineType): Define all type parameters
13905 before adding the interfaces we inherit.
13907 2003-11-11 Martin Baulig <martin@ximian.com>
13909 * generic.cs (ConstructedType.ResolveType): Always call
13910 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
13912 2003-11-10 Martin Baulig <martin@ximian.com>
13914 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
13915 (TypeManager.InitCoreTypes): Initialize them here, but instead of
13916 calling `ResolveType()' on them, directly assign their `Type'.
13918 2003-11-08 Martin Baulig <martin@ximian.com>
13920 * generic.cs (ConstructedType): Override `IsClass' etc.
13922 2003-11-08 Martin Baulig <martin@ximian.com>
13924 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
13925 return value and the `out parent' parameter.
13926 (TypeContainer.DefineType): Moved the CS0644 check into
13927 GetClassBases(). Don't pass the interface types to the
13928 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
13929 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
13931 * ecore.cs (TypeExpr.IsAttribute): New property.
13932 (TypeExpr.GetInterfaces): New method.
13934 * interface.cs (Interface.GetInterfaceTypeByName): Return a
13935 TypeExpr instead of a Type.
13936 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
13937 (Interface.DefineType): Don't pass the interface types to the
13938 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
13939 them later and then call `TypeBulider.AddInterfaceImplementation()'.
13941 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
13942 instead of a `Type[]'.
13943 (TypeManager.RegisterBuilder): Likewise.
13944 (TypeManager.AddUserInterface): Likewise.
13945 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
13946 `Type[]' and also return a `TypeExpr[]'.
13947 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
13949 2003-11-08 Martin Baulig <martin@ximian.com>
13951 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
13954 2003-11-08 Martin Baulig <martin@ximian.com>
13956 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
13957 TypeManager.ResolveExpressionTypes().
13959 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
13960 instead of an Expression.
13961 (TypeExpr): This is now an abstract base class for `TypeExpression'.
13962 (TypeExpression): New public class; formerly known as `TypeExpr'.
13964 * expression.cs (ComposedCast): Derive from TypeExpr.
13966 * typemanager.cs (TypeManager.system_*_expr): These are now
13967 TypExpr's instead of Expression's.
13968 (TypeManager.ResolveExpressionTypes): New public static function;
13969 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
13972 2003-11-06 Miguel de Icaza <miguel@ximian.com>
13974 * expression.cs (New.DoResolve): Do not dereference value that
13975 might be a null return.
13977 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
13978 sure that the constant value has the right type. Fixes an
13979 unreported bug, similar to 50425.
13981 * const.cs (Const.LookupConstantValue): Call
13982 ImplicitStandardConversionExists before doing a conversion to
13983 avoid havng the TypeManager.ChangeType do conversions.
13985 Reduced the number of casts used
13987 (Const.ChangeType): New routine to enable reuse of the constant
13988 type changing code from statement.
13990 * typemanager.cs (ChangeType): Move common initialization to
13991 static global variables.
13995 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
13996 every value type to go through, even if it was void. Fix that.
13998 * cs-tokenizer.cs: Use is_identifier_start_character on the start
13999 character of the define, and the is_identifier_part_character for
14000 the rest of the string.
14002 2003-11-05 Miguel de Icaza <miguel@ximian.com>
14004 * expression.cs (UnaryMutator.EmitCode): When I updated
14005 LocalVariableReference.DoResolve, I overdid it, and dropped an
14006 optimization done on local variable references.
14008 2003-11-04 Miguel de Icaza <miguel@ximian.com>
14010 * ecore.cs: Convert the return from Ldlen into an int.
14012 2003-10-20 Miguel de Icaza <miguel@ximian.com>
14014 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
14015 the accessibility, this is a special case for toplevel non-public
14016 classes (internal for instance).
14018 2003-10-20 Nick Drochak <ndrochak@gol.com>
14020 * ecore.cs: Fix typo and build. Needed another right paren.
14022 2003-10-19 Miguel de Icaza <miguel@ximian.com>
14024 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
14025 `internal' case regular and protected, but not allowing protected
14026 to be evaluated later. Bug 49840
14028 2003-10-15 Miguel de Icaza <miguel@ximian.com>
14030 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
14031 to kb.Nlast, and not the kb.nFirst to isolate the switch
14034 Extract the underlying type, so enumerations of long/ulong are
14035 treated like long/ulong.
14037 2003-10-14 Miguel de Icaza <miguel@ximian.com>
14039 * expression.cs (New): Overload the meaning of RequestedType to
14040 track the possible creation of the NewDelegate type, since
14041 DoResolve is invoked more than once for new constructors on field
14044 See bugs: #48800 and #37014
14046 * cs-parser.jay (declare_local_constants): Take an arraylist
14047 instead of a single constant.
14049 (local_constant_declaration): It should take a
14050 constant_declarators, not a constant_declarator. Fixes 49487
14052 * convert.cs: Fix error report.
14054 2003-10-13 Jackson Harper <jackson@ximian.com>
14056 * typemanager.cs (TypeToCoreType): Add float and double this fixes
14059 2003-11-03 Martin Baulig <martin@ximian.com>
14061 * expression.cs (ArrayAccess.GetStoreOpcode): Added
14062 `out bool has_type_arg'; if set, we need to pass the type to
14064 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
14065 Stelem_Any/Ldelem_Any for generic parameters.
14067 2003-11-02 Martin Baulig <martin@ximian.com>
14069 * expression.cs (Invocation.EmitCall): Use
14070 `TypeManager.IsValueType()' to check whether it's a value type.
14071 Don't set `struct_call' when calling a method on a type parameter.
14073 2003-11-02 Martin Baulig <martin@ximian.com>
14075 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
14076 and removed the TypeBuilder argument.
14078 * typemanager.cs (TypeManager.IsValueType): Return
14079 `t.IsGenericParameter || t.IsValueType'.
14081 2003-10-25 Martin Baulig <martin@ximian.com>
14083 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
14084 call ConstructedType.Resolve() on it.
14086 * generic.cs (ConstructedType.Resolve): Set `type' on success.
14088 2003-10-25 Martin Baulig <martin@ximian.com>
14090 * class.cs (TypeContainer.GetClassBases): Changed
14091 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
14092 CS8214 reporting here.
14093 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
14094 instead of a `Type' for our parent. In case of a recursive
14095 declaration (see tests/gen-23.cs for an example), our parent is a
14096 ConstructedType and it doesn't have its type set. So, first
14097 create our own TypeBuilder, then call constructed.Resolve() to get
14098 the parent's type and finally TypeBuilder.SetParent() it.
14100 * ecore.cs (TypeExpr.Name): New public virtual property.
14103 (ConstructedType): We're now a TypeExpr and not just an Expression.
14104 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
14105 arguments here; this is done later.
14106 (ConstructedType.Resolve): New public method to resolve the type
14107 arguments and bind them.
14109 2003-10-21 Martin Baulig <martin@ximian.com>
14111 * convert.cs: Use `TypeManager.IsValueType' instead of
14112 'type.IsValueType' everywhere.
14114 * typemanager.cs (TypeManager.IsValueType): Return true for type
14115 parameters. The reason for this is that we need to box a type
14116 parameter when converting it to a reference type.
14118 * cs-parser.jay: Added support for default value expressions.
14120 * generics.cs (DefaultValueExpression): New public class.
14122 2003-10-17 Martin Baulig <martin@ximian.com>
14124 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
14125 TypeContainer so we can also use this for Interfaces.
14126 (TypeParameter.Resolve): Likewise.
14128 * interface.cs (Interface.DefineType): Added support for generic
14131 * cs-parser.jay: Added support for generic structs and interfaces.
14133 2003-10-17 Martin Baulig <martin@ximian.com>
14135 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
14136 call generic methods :-)
14138 2003-10-16 Martin Baulig <martin@ximian.com>
14140 * cs-parser.jay (namespace_or_type_name): Only create a
14141 GenericMemberAccess if we actually have type arguments.
14143 2003-10-13 Martin Baulig <martin@ximian.com>
14145 * class.cs (Method.Define): If we're a generic method, call
14146 TypeBuilder.DefineGenericMethod () before resolving
14148 (MethodData): Added .ctor which takes an additional MethodBuilder
14149 argument; this is used for generic methods.
14150 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
14151 we already have a MethodBuilder.
14153 2003-10-10 Martin Baulig <martin@ximian.com>
14155 * class.cs (Method): Added .ctor which takes a `GenericMethod'
14156 instead of a `DeclSpace'. This is used for generic methods.
14158 * cs-parser.jay (method_header): Added support for generic
14159 methods; create a `GenericMethod' instance and pass it to the
14160 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
14161 parameters and locals.
14163 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
14164 since we already have the location. Check whether we're a generic
14165 type declaration or a generic method and create the correct type
14168 * generic.cs (TypeParameter.DefineMethod): New public method.
14169 (GenericMethod): New public class; derives from DeclSpace and is
14170 used for generic methods.
14172 2003-10-09 Martin Baulig <martin@ximian.com>
14174 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14176 (MethodCore.DoDefineParameters): Removed the TypeContainer
14177 argument; use the DeclSpace which was passed to the .ctor instead.
14178 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14179 TypeContainer; we only need a DeclSpace here.
14181 2003-10-09 Martin Baulig <martin@ximian.com>
14183 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14185 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14186 EmitContext's .ctor.
14188 2003-10-09 Martin Baulig <martin@ximian.com>
14190 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14191 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14192 AsAccessible(), moved them as well.
14194 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14196 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14198 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14199 generation for >=, as spotted by Paolo, bug 48679.
14200 Patch from David Waite.
14202 * cs-tokenizer.cs: Add handling for #pragma.
14204 * cs-parser.jay: Allow for both yield and yield return in the
14205 syntax. The anti-cobolization of C# fight will go on!
14207 * class.cs (TypeBuilder.DefineType): Catch error condition here
14208 (Parent.DefineType erroring out and returning null).
14210 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14211 coping with enumerations variables, we were mistakenly processing
14212 them as a regular value type instead of built-in types. Fixes the
14215 * typemanager.cs (IsBuiltinOrEnum): New method.
14217 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14219 * cs-parser.jay: Upgrade: yield now needs the return clause.
14221 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14223 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14225 2003-09-29 Martin Baulig <martin@ximian.com>
14227 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14228 inflated generic methods.
14230 * generics.cs (ConstructedType): Distinguish between open and
14231 closed constructed types; correctly resolve the arguments.
14233 2003-09-22 Martin Baulig <martin@ximian.com>
14235 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14236 all type arguments meet their constraints.
14238 2003-09-19 Martin Baulig <martin@ximian.com>
14240 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14241 `MemberCache parent' argument. Normally, an interface doesn't
14242 have a parent type except System.Object, but we use this in gmcs
14243 for generic type parameters.
14245 2003-09-18 Martin Baulig <martin@ximian.com>
14247 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14248 on `type.IsInterface'; don't check whether the type has a parent
14249 to determine whether it's an interface.
14251 2003-09-17 Martin Baulig <martin@ximian.com>
14253 * generic.cs (ConstructedType.ToString): Always use `name' as the
14256 2003-09-15 Martin Baulig <martin@ximian.com>
14258 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14260 * generic.cs (Constraints.Resolve): New public method; this is
14261 called to resolve the constraint types and to check whether all
14262 the constraints are correct.
14263 (Constraints.Types): New public property.
14264 (TypeParameter.Resolve): New public method; resolves all the
14265 type's constraints.
14267 * class.cs (TypeContainer.DefineType): Call
14268 TypeParameter.Resolve() before actually defining the type.
14270 2003-09-15 Martin Baulig <martin@ximian.com>
14272 * class.cs (TypeContainer.DefineType): Added an error flag to
14273 avoid reporting duplicate CS0146's ("class definition is
14276 * driver.cs (Driver.MainDriver): Abort if
14277 RootContext.ResolveTree() reported any errors.
14279 2003-09-07 Martin Baulig <martin@ximian.com>
14281 * report.cs (Error, Warning): Added overloaded versions which take
14282 a `params object[] args' and call String.Format().
14284 2003-09-07 Martin Baulig <martin@ximian.com>
14286 * decl.cs (DeclSpace..ctor): Don't call
14287 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14288 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14289 (DeclSpace.RecordDecl): New method.
14291 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14293 2003-09-02 Ravi Pratap <ravi@ximian.com>
14295 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14296 value attributes to be applied to ParameterBuilders.
14298 * class.cs (MethodCore.LabelParameters): Make static and more
14299 generic so that it can be used from other places - like interface
14300 methods, for instance.
14302 * interface.cs (Interface.Emit): Call LabelParameters before
14303 emitting attributes on the InterfaceMethod.
14305 2003-09-07 Martin Baulig <martin@ximian.com>
14307 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14308 if the number of type parameters doesn't match.
14310 2003-09-04 Martin Baulig <martin@ximian.com>
14312 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14313 for arrays of generic type params (ie. `!0[]').
14315 2003-09-04 Martin Baulig <martin@ximian.com>
14317 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14320 2003-09-04 Martin Baulig <martin@ximian.com>
14322 * decl.cs (DeclSpace.LookupGeneric): New method.
14323 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14326 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14327 argument, not just a string.
14328 (TypeParameter.Define): New public method; this is called to
14329 actually define the generic parameter; after this, you can use the
14330 new `Type' property to get the type.
14332 2003-09-04 Martin Baulig <martin@ximian.com>
14334 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14335 is now an ArrayList; initialize the result of the `TypeParameters'
14337 (DeclSpace.GetGenericData): Removed.
14338 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14339 implement this in a different way.
14340 (DeclSpace.GetTypeParameters): Removed; there's now a
14341 `TypeParameters' property.
14342 (DeclSpace.TypeParameters): New public property.
14344 * generic.cs (Constraints): Make this class public.
14345 (TypeParameter): New public class.
14347 2003-09-04 Martin Baulig <martin@ximian.com>
14349 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14350 generic parameters.
14352 * class.cs (TypeContainer.DefineType): Call
14353 TypeBuilder.DefineGenericParameter () on all generic parameters if
14354 this is a generic type.
14356 2003-08-28 Martin Baulig <martin@ximian.com>
14358 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14361 * sample-hello.cs: Compile this with gmcs: "gmcs
14362 /r:sample-stack.dll sample-hello.cs".
14364 2003-08-28 Martin Baulig <martin@ximian.com>
14366 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14367 the parameters to the generic type.
14369 2003-08-28 Martin Baulig <martin@ximian.com>
14371 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14373 2003-08-28 Martin Baulig <martin@ximian.com>
14375 * cs-parser.jay (opt_type_argument_list): Use
14376 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14377 (primary_expression): Replace `qualified_identifier' with `type_name'.
14378 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14380 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14381 parser to check whether it is syntactically a type parameter list;
14382 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14385 2003-08-26 Martin Baulig <martin@ximian.com>
14387 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14388 resolving aliases; fixes #47927.
14390 2003-08-26 Martin Baulig <martin@ximian.com>
14392 * statement.cs (Using.DoResolve): This is internally emitting a
14393 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14394 do not always return. Fixes #47681.
14396 2003-08-26 Martin Baulig <martin@ximian.com>
14398 * decl.cs (MemberCore): Moved WarningNotHiding(),
14399 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14401 (AdditionResult): Make this nested in DeclSpace.
14402 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14403 argument; call NamespaceEntry.Define() unless we're nested in a
14406 * namespace.cs (Namespace.DefineName): New public function. This
14407 is called from DeclSpace's .ctor to add
14408 (Namespace.Lookup): Include DeclSpaces in the lookup.
14410 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14412 * const.cs (Const): Derive from MemberBase, not MemberCore.
14414 2003-08-25 Martin Baulig <martin@ximian.com>
14416 * convert.cs (Convert.ExplicitReferenceConversion): When
14417 converting from an interface type to a class, unbox if the target
14418 type is a struct type. Fixes #47822.
14420 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14422 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14425 2003-08-22 Martin Baulig <martin@ximian.com>
14427 * class.cs (TypeManager.DefineType): When defining a nested type,
14428 call DefineType() on our parent; fixes #47801.
14430 2003-08-22 Martin Baulig <martin@ximian.com>
14432 * class.cs (MethodData.Define): While checking if a method is an
14433 interface implementation, improve the test a bit more to fix #47654.
14435 2003-08-22 Martin Baulig <martin@ximian.com>
14437 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14438 correctly; fixes #47722.
14440 2003-08-22 Martin Baulig <martin@ximian.com>
14442 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14443 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14445 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14447 2003-08-22 Martin Baulig <martin@ximian.com>
14449 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14450 can only be assigned in static constructors. Fixes #47161.
14452 2003-08-22 Martin Baulig <martin@ximian.com>
14454 Rewrote and improved the flow analysis code.
14456 * flowbranching.cs (FlowBranching): Make this class abstract.
14457 (FlowBranching.CreateBranching): New static function to create a
14458 new flow branching.
14459 (FlowBranchingBlock, FlowBranchingException): New classes.
14460 (FlowBranching.UsageVector.Type): New public readonly field.
14461 (FlowBranching.UsageVector.Breaks): Removed the setter.
14462 (FlowBranching.UsageVector.Returns): Removed the setter.
14463 (FlowBranching.UsageVector): Added Break(), Return(),
14464 NeverReachable() and Throw() methods to modify the reachability.
14465 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14466 done by FlowBranching.Merge().
14467 (FlowBranching.UsageVector.MergeChild): New method; merges the
14468 merge result into the current vector.
14469 (FlowBranching.Merge): New abstract method to merge a branching.
14471 2003-08-12 Martin Baulig <martin@ximian.com>
14473 * expression.cs (Indirection.CacheTemporaries): Create the
14474 LocalTemporary with the pointer type, not its element type.
14476 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14478 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14479 token was a keyword or not.
14481 Add `error' options where an IDENTIFIER was expected; Provide
14482 CheckToken and CheckIdentifierToken convenience error reporting
14485 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14487 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14488 NameSpaceEntry NameSpaceEntry.
14490 (LookupInterfaceOrClass): Avoid creating a full qualified name
14491 from namespace and name: avoid doing lookups when we know the
14492 namespace is non-existant. Use new Tree.LookupByNamespace which
14493 looks up DeclSpaces based on their namespace, name pair.
14495 * driver.cs: Provide a new `parser verbose' to display the
14496 exception thrown during parsing. This is turned off by default
14497 now, so the output of a failure from mcs is more graceful.
14499 * namespace.cs: Track all the namespaces defined in a hashtable
14502 (IsNamespace): New method
14504 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14506 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14507 we know that we need to concatenate (full typename can never be
14512 * statement.cs: Use a bitfield; Do not initialize to null things
14513 which are done by the constructor by default.
14515 * cs-parser.jay: bug fix, parameter was 4, not 3.
14517 * expression.cs: Just use the property;
14519 * statement.cs: No need for GetVariableInfo method.
14521 2003-08-08 Martin Baulig <martin@ximian.com>
14523 * flowanalysis.cs (FlowReturns): This is now nested in the
14524 `FlowBranching' class.
14525 (MyBitVector): Moved this here from statement.cs.
14526 (FlowBranching.SiblingType): New enum type.
14527 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14529 2003-08-07 Martin Baulig <martin@ximian.com>
14531 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14532 `FlowBranching' class and called `BranchingType'.
14534 2003-08-07 Martin Baulig <martin@ximian.com>
14536 * flowanalysis.cs: Moved all the control flow analysis code into
14539 2003-08-07 Martin Baulig <martin@ximian.com>
14541 * assign.cs (Assign.DoResolve): `target' must either be an
14542 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14545 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14547 * expression.cs (BinaryMethod): This kind of expression is created by the
14548 Binary class if it determines that the operator has to be handled
14551 (BinaryDelegate): This kind of expression is created if we are
14552 dealing with a + or - operator on delegates.
14554 (Binary): remove method, argumetns, and DelegateOperator: when
14555 dealing with methods,
14557 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14559 * statement.cs (Block): use bitfields for the three extra booleans
14560 we had in use. Remove unused topblock parameter.
14562 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14564 * assign.cs: Drop extra unneeded tests.
14566 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14568 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14570 * statement.cs (Foreach): Use VariableStorage instead of
14573 * codegen.cs (VariableStorage): New class used by clients that
14574 require a variable stored: locals or fields for variables that
14575 need to live across yield.
14577 Maybe provide a convenience api for EmitThis+EmitLoad?
14579 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14582 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14584 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14585 RemapParameterLValue): New methods that are used to turn a
14586 precomputed FieldInfo into an expression like this:
14590 The idea is to use this instead of making LocalVariableReference
14591 have more than one meaning.
14593 * cs-parser.jay: Add error production to BASE.
14595 * ecore.cs: Deal with TypeManager.GetField returning null, which
14596 is now a valid return value.
14598 (FieldExprNoAddress): New expression for Fields whose address can
14601 * expression.cs (LocalVariableReference): During the resolve
14602 phases, create new expressions if we are in a remapping context.
14603 Remove code that dealt with remapping here.
14605 (ParameterReference): same.
14607 (ProxyInstance): New expression, like the `This' expression, but
14608 it is born fully resolved. We know what we are doing, so remove
14609 the errors that are targeted to user-provided uses of `this'.
14611 * statement.cs (Foreach): our variable is now stored as an
14612 Expression; During resolution, follow the protocol, dont just
14613 assume it will return this.
14615 2003-08-06 Martin Baulig <martin@ximian.com>
14617 * support.cs (SeekableStreamReader.cs): New public class.
14619 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14620 SeekableStreamReader instead of the normal StreamReader.
14622 2003-08-04 Martin Baulig <martin@ximian.com>
14624 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14625 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14626 deambiguate casts and delegate invocations.
14627 (parenthesized_expression): Use the new tokens to ensure this is
14628 not a cast of method invocation.
14630 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14631 when reading a `)' and Deambiguate_CloseParens () was previously
14634 * expression.cs (ParenthesizedExpression): New class. This is
14635 just used for the CS0075 test.
14636 (Binary.DoResolve): Check for CS0075.
14638 2003-07-29 Ravi Pratap <ravi@ximian.com>
14640 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14641 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14642 reference comparison.
14644 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14645 examine the ReturnType for equality - this is necessary in the
14646 cases of implicit and explicit operators whose signature also
14647 includes the return type.
14649 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14651 * namespace.cs: Cache the result of the namespace computation,
14652 instead of computing it every time.
14654 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14656 * decl.cs: Use a global arraylist that we reuse over invocations
14657 to avoid excesive memory consumption. Reduces memory usage on an
14658 mcs compile by one meg (45 average).
14660 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14661 private, work around that.
14663 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14665 * literal.cs (IntLiteral): Define Zero and One static literals.
14667 * cs-parser.jay (integer_literal): use static literals to reduce
14668 memory usage for the most used literals (0, 1 and -1). 211kb
14669 reduced in memory usage.
14671 Replace all calls to `new ArrayList' with `new
14672 ArrayList(4)' which is a good average number for most allocations,
14673 and also requires only 16 bytes of memory for its buffer by
14676 This reduced MCS memory usage in seven megabytes for the RSS after
14679 2003-07-28 Ravi Pratap <ravi@ximian.com>
14681 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14682 handle params methods the correct way by forming only one
14683 applicable set with params and normal methods in them. Earlier we
14684 were looking at params methods only if we found no normal methods
14685 which was not the correct thing to do.
14687 (Invocation.BetterFunction): Take separate arguments indicating
14688 when candidate and the best method are params methods in their
14691 This fixes bugs #43367 and #46199.
14693 * attribute.cs: Documentation updates.
14695 (CheckAttribute): Rename to CheckAttributeTarget.
14696 (GetValidPlaces): Rename to GetValidTargets.
14698 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14699 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14703 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14705 * codegen.cs: Compute IsGeneric correctly.
14707 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14710 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14711 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14712 regressions, and I was chasing more bugs than I required.
14714 * interface.cs: Use expressions for base type names (like classes
14715 and structs have been doing for a while now), and resolve that.
14716 This patch should probably go into head as well.
14718 This makes it one less user of FindType.
14720 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14722 This compiler can not self host currently. Need to fix that.
14724 * Makefile: compile to `gmcs.exe'
14726 * driver.cs: Turn on v2 by default on gmcs.
14728 * generic.cs (ConstructedType): Does no longer take a container
14729 type argument; That will be taken care of later.
14731 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14732 Use SimpleName to resolve for now, so we can continue the work on
14733 the parser, until we get Type.GetType that understands generics.
14735 (ConstructedType.ToString): Implement
14737 (TypeArguments.Resolve): Resolve the child expressions as types.
14739 * cs-parser.jay: Rename interface_constraints to
14740 type_parameter_constraints
14742 (namespace_or_type_name): Only use constructed types for the basic
14743 construction, we will deal with identifier<...> later.
14745 (type/type_name): No longer call DecomposeQI, as
14746 namespace_or_type_name is always decoded now.
14748 2003-07-22 Ravi Pratap <ravi@ximian.com>
14750 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14751 closely: we eliminate methods in base types when we have an
14752 applicable method in a top-level type.
14754 Please see section 14.5.5.1 for an exact description of what goes
14757 This fixes bug #45127 and a host of other related to corlib compilation.
14759 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14760 array is the method corresponding to the top-level type (this is
14761 because of the changes made to icall.c) so we change this
14764 (MethodGroupExpr.Name): This too.
14766 * typemanager.cs (GetElementType): New method which does the right
14767 thing when compiling corlib.
14769 * everywhere: Make use of the above in the relevant places.
14771 2003-07-22 Martin Baulig <martin@ximian.com>
14773 * cs-parser.jay (invocation_expression): Moved
14774 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14775 `cast_expression', but create a InvocationOrCast which later
14776 resolves to either an Invocation or a Cast.
14778 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14779 method; call this before EmitStatement() to make sure that this
14780 expression can be used as a statement.
14782 * expression.cs (InvocationOrCast): New class; resolves to either
14783 an Invocation or a Cast.
14785 * statement.cs (StatementExpression): Call ResolveStatement() on
14786 the ExpressionStatement before emitting it.
14788 2003-07-21 Martin Baulig <martin@ximian.com>
14790 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
14791 `ref' and `out' attributes match; fixes #46220.
14792 (MemberAccess.ResolveMemberAccess): You can't reference a type
14793 through an expression; fixes #33180.
14794 (Indexers.GetIndexersForType): Don't return the indexers from
14795 interfaces the class implements; fixes #46502.
14797 2003-07-21 Martin Baulig <martin@ximian.com>
14799 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
14800 CS0661 checks; fixes bug #30442.
14802 2003-07-21 Martin Baulig <martin@ximian.com>
14804 * decl.cs (AdditionResult): Added `Error'.
14806 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
14808 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
14809 cs0031.cs actually work.
14811 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14813 * cs-parser.jay (namespace_name): do not use
14814 namespace_or_type_name, use qualified_identifier, because
14815 namespace_or_type_name will soon return a composed expression
14816 instead of a string.
14818 (namespace_or_type_name): Instead of returning a string, now this
14819 production returns an expression.
14821 * codegen.cs (EmitContext): Setup IsGeneric property based on
14822 whether our DeclSpace is generic, our the method is generic.
14824 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
14825 the method is generic.
14827 * cs-parser.jay (type_arguments, opt_type_argument_list,
14828 type_parameters, type_parameter_list, opt_type_parameter_list,
14829 type_parameter,, opt_type_parameter_constraints_clauses,
14830 type_parameter_constraints_clauses,
14831 type_parameter_constraint_clause, type_parameter_constraint,
14832 interface_constraints): Add new production
14834 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
14835 DeclSpace is generic or not.
14837 (DeclSpace.SetParameterInfo): New routine, used to set the
14838 parameter info for a type.
14840 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
14841 returns a GenericTypeExpr
14843 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
14844 generic, lookup the generic argument.
14846 * attribute.cs: Do not allow TypeParameterExpressions in
14849 * class.cs: Do not allow the Main method to be defined in a
14852 * expression.cs (SizeOf): Do not allow generic types to be used as
14853 arguments to sizeof.
14855 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
14856 it: whether a type is generic or not. Only works for types we are
14857 currently building for now.
14859 2003-07-20 Martin Baulig <martin@ximian.com>
14861 * namespace.cs: Fixed that bug which caused a crash when compiling
14862 the debugger's GUI.
14864 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14866 * typemanager.cs (LookupTypeReflection): Never expose types which
14867 are NotPublic, NestedPrivate, NestedAssembly, or
14868 NestedFamANDAssem. We used to return these, and later do a check
14869 that would report a meaningful error, but the problem is that we
14870 would not get the real match, if there was a name override.
14872 2003-07-18 Miguel de Icaza <miguel@ximian.com>
14874 * namespace.cs (Namespace, Name): Do not compute the namespace
14875 name dynamically, compute it in the constructor. This reduced
14876 memory usage by 1697 KB.
14878 * driver.cs: Use --pause to pause at the end.
14880 2003-07-17 Peter Williams <peter@newton.cx>
14882 * Makefile: Change the name of the test target so that it doesn't
14883 conflict with the recursive test target.
14885 2003-07-17 Miguel de Icaza <miguel@ximian.com>
14887 * expression.cs (LocalVariableReference.Emit, EmitAssign,
14888 AddressOf): Do not use EmitThis, that was wrong, use the actual
14891 2003-07-15 Miguel de Icaza <miguel@ximian.com>
14893 * class.cs (MethodData.Define): While checking if a method is an
14894 interface implementation, improve the test: If we are not public
14895 (use new test here: use the computed MethodAttributes directly,
14896 instead of the parsed modifier flags) check if the `implementing'
14897 method comes from an interface or not.
14899 * pending.cs (VerifyPendingMethods): Slightly better error
14902 * makefile: add test target that does the mcs bootstrap.
14904 2003-07-16 Ravi Pratap <ravi@ximian.com>
14906 * interface.cs (Define): Do nothing here since there are no
14907 members to populate etc. Move the attribute emission out of here
14908 since this was just totally the wrong place to put it. Attribute
14909 application happens during the 'Emit' phase, not in the 'Define'
14912 (Emit): Add this method and move the attribute emission here
14914 * rootcontext.cs (EmitCode): Call the Emit method on interface
14917 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14919 * expression.cs (OverloadResolve): Report error only if Location
14920 is not 'Null' which means that there was a probe going on.
14922 2003-07-14 Martin Baulig <martin@ximian.com>
14924 * expression.cs (ConditionalLogicalOperator): New public class to
14925 implement user defined conditional logical operators.
14926 This is section 14.11.2 in the spec and bug #40505.
14928 2003-07-14 Martin Baulig <martin@ximian.com>
14930 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
14932 2003-07-14 Martin Baulig <martin@ximian.com>
14934 * codegen.cs (EmitContext.InFixedInitializer): New public field.
14936 * ecore.cs (IVariable.VerifyFixed): New interface method.
14938 * expression.cs (Unary.ResolveOperator): When resolving the `&'
14939 operator, check whether the variable is actually fixed. Fixes bug
14940 #36055. Set a variable definitely assigned when taking its
14941 address as required by the spec.
14943 * statement.cs (LocalInfo.IsFixed): New field.
14944 (LocalInfo.MakePinned): Set `IsFixed' to true.
14946 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14948 * attribute.cs (Attribute.Resolve): While doing a Member lookup
14949 for .ctors, ensure that we only ask for members declared in the
14950 attribute type (BindingFlags.DeclaredOnly).
14954 * expression.cs (Error_WrongNumArguments): Report error 1501
14955 correctly the way CSC does.
14957 2003-07-13 Martin Baulig <martin@ximian.com>
14959 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
14960 lookup on the fully qualified name, to make things like "X.X" work
14961 where "X.X" is a fully qualified type name, but we also have a
14962 namespace "X" in the using list. Fixes #41975.
14964 2003-07-13 Martin Baulig <martin@ximian.com>
14966 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
14967 function. If we're a CompoundAssign, we need to create an embedded
14968 CompoundAssign, not an embedded Assign.
14969 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
14972 2003-07-13 Martin Baulig <martin@ximian.com>
14974 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
14975 work to fix bug #46088.
14977 2003-07-13 Ravi Pratap <ravi@ximian.com>
14979 * class.cs (Operator.Emit): Do not emit attributes here - it is
14980 taken care of by the Method class that we delegate too. This takes
14981 care of bug #45876.
14983 2003-07-10 Martin Baulig <martin@ximian.com>
14985 * expression.cs (TypeOfVoid): New class.
14986 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
14988 2003-07-10 Martin Baulig <martin@ximian.com>
14990 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
14993 2003-07-10 Martin Baulig <martin@ximian.com>
14995 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
14996 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
14998 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
15000 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
15002 2003-07-10 Martin Baulig <martin@ximian.com>
15004 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
15005 of decimal. Fixes #42850.
15007 NOTE: I also fixed the created byte blob, but this doesn't work on
15008 the MS runtime and csc never produces any byte blobs for decimal
15011 2003-07-10 Martin Baulig <martin@ximian.com>
15013 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
15014 structs; fixes #32068.
15015 (Block.AddChildVariableNames): Fixed #44302.
15017 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15019 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
15021 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15023 * attribute.cs: And this test is onger needed.
15025 2003-07-08 Martin Baulig <martin@ximian.com>
15027 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
15028 inaccessible types. Fixes #36313.
15030 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
15032 * namespace.cs (NamespaceEntry): Create implicit entries for all
15033 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
15034 implicit entries for N1.N2 and N1.
15036 2003-07-08 Martin Baulig <martin@ximian.com>
15038 Rewrote the handling of namespaces to fix a lot of the issues
15039 wrt. `using' aliases etc.
15041 * namespace.cs (Namespace): Splitted this class into a
15042 per-assembly `Namespace' and a per-file `NamespaceEntry'.
15044 * typemanager.cs (TypeManager.IsNamespace): Removed.
15045 (TypeManager.ComputeNamespaces): Only compute namespaces from
15046 loaded assemblies here, not the namespaces from the assembly we're
15047 currently compiling.
15049 2003-07-08 Martin Baulig <martin@ximian.com>
15051 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
15053 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15055 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
15058 I thought about the memory savings here, but LookupTypeReflection
15059 is used under already very constrained scenarios. Compiling
15060 corlib or mcs only exposes one hit, so it would not really reduce
15061 any memory consumption.
15063 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15065 * typemanager.cs: fixes bug #45889 by only adding public types from
15066 other assemblies to the list of known types.
15068 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15070 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
15071 on the type we resolved.
15073 2003-07-05 Martin Baulig <martin@ximian.com>
15075 * pending.cs (PendingImplementation.ParentImplements): Don't
15076 create the proxy if the parent is abstract.
15078 * class.cs (TypeContainer.DefineIndexers): Process explicit
15079 interface implementations first. Fixes #37714.
15081 2003-07-04 Miguel de Icaza <miguel@ximian.com>
15083 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
15084 defined recursively; but since we modify the input parameters
15085 (left is set to `this' temporarily), we reset this value if the
15086 left_is_explicit is false, which gives the original semantics to
15089 * literal.cs (NullPointer): new class used to represent a null
15090 literal in a pointer context.
15092 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
15093 type is a pointer, use a NullPointer object instead of a
15094 NullLiteral. Closes 43687
15096 (ExplicitConversion): Convert pointer values using
15097 the conv opcode to the proper type.
15099 * ecore.cs (New): change ValueTypeVariable property into a method,
15100 that returns whether the valuetype is suitable for being used.
15102 * expression.cs (Binary.DoNumericPromotions): Only return if we
15103 the int constant was a valid uint, and we can return both left and
15104 right as uints. If not, we continue processing, to trigger the
15105 type conversion. This fixes 39018.
15107 * statement.cs (Block.EmitMeta): During constant resolution, set
15108 the CurrentBlock property on the emitcontext, so that we resolve
15109 constants propertly.
15111 2003-07-02 Martin Baulig <martin@ximian.com>
15113 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
15114 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
15116 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
15117 than emitting it here.
15119 * statement.cs: Fixed some more flow analysis bugs.
15121 2003-07-02 Martin Baulig <martin@ximian.com>
15123 * class.cs (MethodData.Define): When implementing interface
15124 methods, set Final unless we're Virtual.
15126 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
15127 check work for interface methods.
15129 2003-07-01 Martin Baulig <martin@ximian.com>
15131 * ecore.cs (EmitContext.This): Replaced this property with a
15132 GetThis() method which takes a Location argument. This ensures
15133 that we get the correct error location for a CS0188.
15135 2003-07-01 Miguel de Icaza <miguel@ximian.com>
15137 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
15138 ImplicitStandardConversion.
15140 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
15142 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
15144 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
15147 2003-06-30 Miguel de Icaza <miguel@ximian.com>
15149 * class.cs (Constructor.Define): Turn off initlocals for unsafe
15152 (MethodData.Define): Turn off initlocals for unsafe methods.
15154 2003-06-29 Miguel de Icaza <miguel@ximian.com>
15156 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
15157 complete; Fixes #37521.
15159 * delegate.cs: Use Modifiers.TypeAttr to compute the
15160 TypeAttributes, instead of rolling our own. This makes the flags
15161 correct for the delegates.
15163 2003-06-28 Miguel de Icaza <miguel@ximian.com>
15165 * class.cs (Constructor.Define): Set the private flag for static
15166 constructors as well.
15168 * cs-parser.jay (statement_expression): Set the return value to
15169 null, to avoid a crash when we catch an error.
15171 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15173 * cs-parser.jay: Applied patch from Jackson that adds support for
15174 extern and unsafe modifiers to destructor declarations.
15176 * expression.cs: Report error 21 if the user is trying to index a
15179 * driver.cs: Add an error message, suggested by the bug report.
15181 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15182 if we do not have a ": this ()" constructor initializer. Fixes 45149
15184 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15186 * namespace.cs: Add some information to reduce FAQs.
15188 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15190 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15191 underlying enumeration types. Fixes #43915.
15193 * expression.cs: Treat ushort/short as legal values to be used in
15194 bitwise operations.
15196 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15198 * delegate.cs: transfer custom attributes for paramenters from
15199 the delegate declaration to Invoke and BeginInvoke.
15201 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15203 * attribute.cs: handle custom marshalers and emit marshal info
15206 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15208 * makefile.gnu: Added anonymous.cs to the compiler sources.
15210 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15212 * iterators.cs: Change the name of the proxy class to include two
15215 * cs-parser.jay: Update grammar to include anonymous methods.
15217 * anonymous.cs: new file.
15219 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15221 * class.cs (Field.Define): Add missing test for pointers and
15224 2003-05-27 Ravi Pratap <ravi@ximian.com>
15226 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15227 we use the stobj opcode.
15229 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15230 since it wasn't the correct fix.
15232 It still is puzzling that we are required to use stobj for IntPtr
15233 which seems to be a ValueType.
15235 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15237 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15238 during regular simple name resolution. Now, the trick is that
15239 instead of returning for processing the simplename, we do a
15240 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15241 contextual lookup type). If a match is found, return that, if
15242 not, return for further composition.
15244 This fixes long-standing 30485.
15246 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15247 using the address to initialize an object, do an Stobj instead of
15248 using the regular Stelem.
15250 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15251 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15252 Because if we are a BaseIndexerAccess that value will be true.
15255 * statement.cs (GotoCase.Resolve): Return after reporting an
15256 error, do not attempt to continue.
15258 * expression.cs (PointerArithmetic.Emit): If our operand is a
15259 long, convert our constants to match the operand before
15260 multiplying. Convert to I type before adding. Fixes 43670.
15262 2003-05-14 Ravi Pratap <ravi@ximian.com>
15264 * enum.cs (ImplicitConversionExists) : Rename to
15265 ImplicitEnumConversionExists to remove ambiguity.
15267 * ecore.cs (NullCast): New type of cast expression class which
15268 basically is very similar to EmptyCast with the difference being
15269 it still is a constant since it is used only to cast a null to
15271 (eg. (string) null)
15273 * convert.cs (ImplicitReferenceConversion): When casting a null
15274 literal, we return a NullCast.
15276 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15277 should be around anymore.
15279 The renaming (reported was slightly wrong). Corrections:
15281 ConvertImplicitStandard -> ImplicitConversionStandard
15282 ConvertExplicitStandard -> ExplicitConversionStandard
15284 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15285 before passing them in !
15287 * convert.cs (ImplicitConversionStandard): When comparing for
15288 equal expr and target types, ensure that expr is not a
15291 In general, we must not be checking (expr_type ==
15292 target_type) in the top level conversion methods
15293 (ImplicitConversion, ExplicitConversion etc). This checking is
15294 done in the methods that they delegate to.
15296 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15298 * convert.cs: Move Error_CannotConvertType,
15299 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15300 ImplicitNumericConversion, ImplicitConversionExists,
15301 ImplicitUserConversionExists, StandardConversionExists,
15302 FindMostEncompassedType, FindMostSpecificSource,
15303 FindMostSpecificTarget, ImplicitUserConversion,
15304 ExplicitUserConversion, GetConversionOperators,
15305 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15306 TryImplicitIntConversion, Error_CannotConvertImplicit,
15307 ConvertImplicitRequired, ConvertNumericExplicit,
15308 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15309 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15312 Perform the following renames:
15314 StandardConversionExists -> ImplicitStandardConversionExists
15315 ConvertImplicit -> ImplicitConversion
15316 ConvertImplicitStandard -> ImplicitStandardConversion
15317 TryImplicitIntConversion -> ImplicitIntConversion
15318 ConvertImplicitRequired -> ImplicitConversionRequired
15319 ConvertNumericExplicit -> ExplicitNumericConversion
15320 ConvertReferenceExplicit -> ExplicitReferenceConversion
15321 ConvertExplicit -> ExplicitConversion
15322 ConvertExplicitStandard -> ExplicitStandardConversion
15324 2003-05-19 Martin Baulig <martin@ximian.com>
15326 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15327 (TypeInfo): Added support for structs having structs as fields.
15329 * ecore.cs (FieldExpr): Implement IVariable.
15330 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15331 VariableInfo for the field.
15333 2003-05-18 Martin Baulig <martin@ximian.com>
15335 * expression.cs (This.DoResolve): Report a CS0027 if we're
15336 emitting a field initializer.
15338 2003-05-18 Martin Baulig <martin@ximian.com>
15340 * expression.cs (This.ResolveBase): New public function.
15341 (This.DoResolve): Check for CS0188.
15343 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15346 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15347 `instance_expression' to null if we don't have any non-static
15350 2003-05-18 Martin Baulig <martin@ximian.com>
15352 Reworked the way how local variables and parameters are handled by
15353 the flow analysis code.
15355 * statement.cs (TypeInfo, VariableMap): New public classes.
15356 (VariableInfo): New public class. This is now responsible for
15357 checking whether a variable has been assigned. It is used for
15358 parameters and local variables.
15359 (Block.EmitMeta): Take the InternalParameters as argument; compute
15360 the layout of the flow vectors here.
15361 (Block.LocalMap, Block.ParameterMap): New public properties.
15362 (FlowBranching): The .ctor doesn't get the InternalParameters
15363 anymore since Block.EmitMeta() now computes the layout of the flow
15365 (MyStructInfo): This class is now known as `StructInfo' and nested
15366 in `TypeInfo'; we don't access this directly anymore.
15368 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15369 property and removed IsAssigned(), IsFieldAssigned(),
15370 SetAssigned() and SetFieldAssigned(); we now call them on the
15371 VariableInfo so we don't need to duplicate this code everywhere.
15373 * expression.cs (ParameterReference): Added `Block block' argument
15375 (LocalVariableReference, ParameterReference, This): The new
15376 VariableInfo class is now responsible for all the definite
15379 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15380 IsParameterAssigned, SetParameterAssigned): Removed.
15382 2003-05-18 Martin Baulig <martin@ximian.com>
15384 * typemanager.cs (InitCoreTypes): Try calling
15385 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15386 the 3-args-version. Corlib now also needs our `void_type'.
15387 (GetMethod): Added overloaded version which takes an optional
15388 `bool report_errors' to allow lookups of optional methods.
15390 2003-05-12 Martin Baulig <martin@ximian.com>
15392 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15393 only used for locals and not for parameters.
15395 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15397 * support.cs (InternalParameters.ParameterType): Return the
15398 ExternalType of the parameter.
15400 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15403 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15405 * class.cs (MethodData.Define): Do not set the `newslot' on
15406 interface members, if they are also flagged as "override".
15408 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15409 better code for ++i and i++. This only works for static fields
15410 and local variables.
15412 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15413 want to pull the DeclSpace out of the builder_to_declspace instead
15414 of the TypeBuilder (like in TypeContainer.FindMembers).
15416 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15417 instead of LookupTypeContainer. Fixes the crash on .NET for
15418 looking up interface members.
15420 * const.cs: Create our own emit context during the Definition
15421 stage, so that constants are evaluated in the proper context, when
15422 a recursive definition happens.
15424 2003-05-11 Martin Baulig <martin@ximian.com>
15426 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15427 new block for a switch section.
15428 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15429 the adding/lookup in the switch block. Fixes #39828.
15431 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15433 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15434 functionality: I needed to convert the data after I had performed
15435 the add/sub operation into the operands type size.
15437 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15438 pass the type for the box operation, otherwise the resulting
15439 object would have been of type object.
15441 (BoxedCast): Add constructor to specify the type to box as.
15443 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15445 * iterators.cs: I was reusing the `count' variable inadvertently,
15446 take steps to not allow this to happen.
15448 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15450 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15451 by creating an array at the point where the params starts and
15452 putting all those arguments there, then adjusting the size of the
15455 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15457 * expression.cs (New.AddressOf): Implement interface
15458 IMemoryLocation. This is used when the `new' operator is used in
15459 the context of an invocation to a method on a value type.
15461 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15464 * namespace.cs: Also check the using aliases here.
15466 * driver.cs: Move the test for using validity after the types have
15467 been entered, so we do a single pass that also includes the using
15470 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15471 in the regular case. CreateSiblingForFinally is doing extra
15474 * attribute.cs (GetAttributeArgumentExpression): Store the result
15475 on an out value, and use the return value to indicate failure
15476 instead of using null (which is a valid return for Constant.GetValue).
15478 * statement.cs: Perform the analysis flow for the increment
15479 portion after the statement, because this will be the real flow of
15480 execution. Fixes #42385
15482 * codegen.cs (EmitContext.EmitArgument,
15483 EmitContext.EmitStoreArgument): New helper functions when the
15484 RemapToProxy flag is set.
15486 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15489 Add support for remapping parameters.
15491 * iterators.cs: Propagate parameter values; Store parameter
15492 values in the proxy classes.
15494 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15496 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15497 need a proxy reference; I do not know what I was thinking
15499 * cs-parser.jay (constructor_initializer): catch another error,
15500 and display nice message.
15502 (field_declaration): catch void field declaration
15503 to flag a better error.
15505 * class.cs (MemberBase.CheckBase): Report an error instead of a
15506 warning if a new protected member is declared in a struct.
15507 (Field.Define): catch the error of readonly/volatile.
15509 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15511 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15512 volatile variable is taken
15514 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15516 * statement.cs (Fixed.Resolve): Report an error if we are not in
15519 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15521 * typemanager.cs: reuse the code that handles type clashes for
15522 delegates and enumerations.
15524 * class.cs (Report28): Always report.
15526 * expression.cs (EncodeAsAttribute): Allow nulls here.
15528 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15530 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15531 the functionality for testing whether an expression is valid for
15532 an attribute here. Also handle the case of arrays of elements
15535 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15536 encoding a linear array into an array of objects that are suitable
15537 to be passed to an CustomAttributeBuilder.
15539 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15541 * ecore.cs: (FieldExpr): Handle field remapping here.
15543 * iteratators.cs: Pass the instance variable (if the method is an
15544 instance method) to the constructors, so we can access the field
15545 variables on the class.
15547 TODO: Test this with structs. I think the THIS variable on
15548 structs might have to be a pointer, and not a refenrece
15550 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15552 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15553 local variables to fields in a proxy class.
15555 * iterators.cs (PopulateProxy): Rename our internal fields to
15557 Create a <THIS> field if we are an instance method, so we can
15558 reference our parent container variables.
15559 (MapVariable): Called back from the EmitContext code to enter a
15560 new variable to field mapping into the proxy class (we just create
15564 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15565 for using the remapped locals to fields.
15567 I placed the code here, because that gives the same semantics to
15568 local variables, and only changes the Emit code.
15570 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15571 statements inside iterators.
15572 (VariableInfo): Add a FieldBuilder for the cases when we are
15573 remapping local variables to fields in a proxy class
15575 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15576 current_block != null.
15578 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15579 not cope with strings, as it has been moved to the
15580 TableSwitchEmit. Fixed bug in switch generation.
15582 * expression.cs (New.DoResolve): Provide more context for the user
15583 when reporting an error.
15585 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15588 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15589 check the permissions for it. Note than in a type-resolution
15590 context the check was already present in DeclSpace.ResolveType,
15591 but was missing from the MemberAccess.
15593 (ArrayCreation.CheckIndices): warn if the user has
15594 more nested levels of expressions, but there are no more
15595 dimensions specified. Avoids crash on bug 41906.
15597 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15599 * statement.cs (Block): replace Implicit bool, for a generic
15601 New flag: `Unchecked'. This is used during the EmitMeta phase
15602 (which is out-of-line with the regular Resolve/Emit process for a
15603 statement, as this is done ahead of time, but still gets a chance
15604 to call constant resolve).
15606 (Block.Flags): new enum for adding a new flag.
15608 (Block.EmitMeta): track the state of unchecked.
15610 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15611 to enable constant resolution to work there as well.
15613 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15615 * typemanager.cs (ienumerable_type): Also look up
15616 System.Collections.IEnumerable.
15618 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15620 TODO: Test more than one conditional per method.
15622 * class.cs (Indexer.Define): Report the location where the user is
15623 referencing the unsupported feature.
15625 (MethodData): Overload the use of `conditionals' to
15626 minimize the creation of needless ArrayLists. This saves roughly
15627 212kb on my machine.
15629 (Method): Implement the new IIteratorContainer interface.
15630 (Method.SetYields): Implement the method by setting the ModFlags
15631 to contain METHOD_YIELDS.
15633 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15634 which just got set to null.
15636 * iterators.cs: New file.
15638 (Yield, YieldBreak): New statements.
15640 * statement.cs (Return.Resolve): Flag an error if we are used in
15641 an iterator method.
15643 * codegen.cs (InIterator): New flag set if the code is being
15644 compiled in an iterator method.
15646 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15647 internal modifier, and we just use it to avoid adding extra
15648 fields, as this is seldom used.
15650 * cs-parser.jay: Add yield_statement (yield and yield break).
15652 * driver.cs: New flag -v2 to turn on version 2 features.
15654 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15655 hashtable when v2 is enabled.
15657 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15659 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15660 there is already a namespace defined with this name.
15662 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15663 people upgraded their corlibs.
15665 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15666 always use fully qualified types, no need to use the compiler
15669 (TypeManager.IsNamespace): Use binarysearch.
15671 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15672 AddDelegate): I did not quite use the new IsValid API properly: I
15673 have to pass the short-name and the fullname. I was passing only
15674 the basename instead of the fullname sometimes.
15676 (TypeContainer.DefineType): call NamespaceClash.
15678 * interface.cs (Interface.DefineType): use NamespaceClash before
15681 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15684 * enum.cs: (Enum.DefineType): use NamespaceClash before
15687 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15688 speed increase. First, use the negative_hits cache when we get a
15689 negative. Second, add the type with its full original name
15690 instead of the new . and + encoded name (reflection uses + to
15691 separate type from a nested type). Use LookupTypeReflection
15692 directly which bypasses the type->name hashtable (that we already
15693 know does not contain the type.
15695 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15696 location/container type.
15698 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15700 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15702 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15704 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15705 method is being referenced in the method group from a static
15706 context, and report error 120 if so.
15708 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15711 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15712 is created, we create the A namespace).
15714 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15717 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15719 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15720 invocation to ModuleBuilder.GetType with the same values will
15721 return a new type instance, so we need to cache its return
15724 * expression.cs (Binary.ResolveOperator): Only allow the compare
15725 operators on enums if they are of the same type.
15727 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15728 types of ValueType on their own case. Before we were giving them
15729 the same treatment as objects.
15731 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15732 fullname. Short name is used to compare against container name.
15733 Fullname is used to check against defined namespace names.
15735 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15736 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15738 (Method.CheckBase): Call parent.
15739 (MemberBase.CheckBase): Check for protected members on sealed
15741 (PropertyBase.CheckBase): Call parent.
15742 (Field.Define): Call parent.
15744 * report.cs: Negative error codes are now mapped to 8000 - code,
15745 so that the display is render more nicely.
15747 * typemanager.cs: Do not use try/catch, instead report a regular
15750 (GetPointerType, GetReferenceType): These methods provide
15751 mechanisms to obtain the T* and T& from a T. We had the code
15752 previously scattered around the code base, and it also used
15753 TypeManager.LookupType that would go through plenty of caches.
15754 This one goes directly to the type source.
15756 In some places we did the Type.GetType followed by
15757 ModuleBuilder.GetType, but not in others, so this unifies the
15758 processing as well.
15760 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15761 statements now that we have namespace information.
15763 * typemanager.cs (IsNamespace): New method, returns whether the
15764 string presented is a namespace or not.
15766 (ComputeNamespaces): New public entry point, computes the list of
15767 available namespaces, using the GetNamespaces API call in Mono, or
15768 the slower version in MS.NET.
15770 Now before we start the semantic analysis phase, we have a
15771 complete list of namespaces including everything that the user has
15774 Deleted old code to cache namespaces in .nsc files.
15776 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15778 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15779 class/struct location definition Location for the implicit
15780 constructor location.
15782 (Operator.Define): Use the location of the operator for the
15783 implicit Method definition.
15785 (Constructor.Emit): use the constructor location for the implicit
15786 base initializer constructor.
15788 * ecore.cs: Remove ITypeExpression. This interface is now gone,
15789 and the Expression class now contains two new methods:
15791 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
15792 isolate type lookup from the rest of the resolution process.
15794 Since we use Expressions to hold type definitions due to the way
15795 we parse the input we have historically overloaded Resolve to
15796 perform the Type lookups if a special flag is passed. Now this is
15797 eliminated and two methods take their place.
15799 The differences in the two methods between xStep and xTerminal is
15800 that xStep is involved in our current lookup system that uses
15801 SimpleNames to compose a name, while xTerminal is used just to
15802 catch the case where the simplename lookup failed.
15804 2003-04-16 Miguel de Icaza <miguel@ximian.com>
15806 * expression.cs (ResolveMemberAccess): Remove redundant code.
15807 TypeExpr expressions are always born fully resolved.
15809 * interface.cs (PopulateMethod): Do not lookup the types twice.
15810 We were doing it once during SemanticAnalysis and once during
15813 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
15814 in local variable type definitions, were being returned as a
15815 SimpleName (we decomposed everything into a string), that is
15816 because primary_expression was being used instead of a type in the
15817 grammar (reduce/reduce conflicts).
15819 The part that was wrong is that we converted the expression into a
15820 string (an oversimplification in one hand, compounded with primary
15821 expressions doing string concatenation).
15827 Would return "A.B.C[]" as a SimpleName. This stopped things like
15828 using clauses from working on this particular context. And a type
15829 was being matched directly against "A.B.C[]".
15831 We now use the correct approach, and allow for ComposedCast to be
15832 part of the unary expression. So the "A.B.C []" become a composed
15833 cast of "A.B.C" (as a nested group of MemberAccess with a
15834 SimpleName at the end) plus the rank composition "[]".
15838 2003-04-10 Miguel de Icaza <miguel@ximian.com>
15840 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
15841 for the access level checking.
15843 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
15844 `TypeContainer container', because I kept getting confused when I
15845 was debugging this code.
15847 * expression.cs (Indexers): Instead of tracking getters/setters,
15848 we now track them in parallel. We create one arraylist less, but
15849 most importantly it is possible now for the LValue code to find a
15850 matching get for a set.
15852 (IndexerAccess.DoResolveLValue): Update the code.
15853 GetIndexersForType has been modified already to extract all the
15854 indexers from a type. The code assumed it did not.
15856 Also make the code set the correct return type for the indexer.
15857 This was fixed a long time ago for properties, but was missing for
15858 indexers. It used to be void_type.
15860 (Binary.Emit): Test first for doubles instead of
15861 floats, as they are more common.
15863 (Binary.EmitBranchable): Use the .un version of the branch opcodes
15864 when dealing with floats and the <=, >= operators. This fixes bug
15867 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
15868 to load the array value by emitting a load on the foreach variable
15869 type. This was incorrect.
15871 We now emit the code to load an element using the the array
15872 variable type, and then we emit the conversion operator.
15876 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
15878 * attribute.cs: Avoid allocation of ArrayLists in the common case.
15880 2003-04-09 Miguel de Icaza <miguel@ximian.com>
15882 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
15883 test for protection before we test for signatures.
15885 (MethodSignature.ToString): implement.
15887 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
15888 to the case where we reduced into a LongConstant.
15890 * decl.cs (CheckAccessLevel): If the type is an array, we can not
15891 depend on whether the information is acurrate, because the
15892 Microsoft runtime will always claim that the array type is public,
15893 regardless of the real state.
15895 If the type is a pointer, another problem happens: the type is
15896 reported as non-public in Microsoft.
15898 In both cases we have to call CheckAccessLevel recursively with
15899 the underlying type as the argument to be tested.
15901 2003-04-08 Miguel de Icaza <miguel@ximian.com>
15903 * assign.cs (Assign.Emit): If we are dealing with a compound
15904 assignment expression, we should use the code path that stores the
15905 intermediate result in a temporary value. This fixes #40903.
15907 *expression.cs (Indirection.ToString): Provide ToString method for
15910 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
15912 * class.cs: Null out fields holding references to Block objects so
15913 they can be garbage collected.
15915 * expression.cs (OverloadResolve): Remove unused local.
15917 2003-04-07 Martin Baulig <martin@ximian.com>
15919 * codegen.cs (EmitContext.CurrentFile): New public field.
15920 (EmitContext.Mark): Use the CurrentFile to check whether the
15921 location is in the correct file.
15922 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
15924 2003-04-07 Martin Baulig <martin@ximian.com>
15926 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
15928 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
15929 location. [FIXME: The location argument which gets passed to this
15930 method is sometimes wrong!]
15932 2003-04-07 Nick Drochak <ndrochak@gol.com>
15934 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
15936 2003-04-07 Miguel de Icaza <miguel@ximian.com>
15938 * expression.cs (Indirection.EmitAssign): We were using the
15939 temporary, but returning immediately instead of continuing the
15942 2003-04-06 Martin Baulig <martin@ximian.com>
15944 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
15945 if it's a nested child, but also deriving from the outer class.
15948 * typemanager.cs (IsNestedChildOf): Make this work if it's a
15949 nested child, but also deriving from the outer class. See
15951 (FilterWithClosure): We may access private members of the outer
15952 class if we're a nested child and deriving from the outer class.
15953 (RealMemberLookup): Only set `closure_private_ok' if the
15954 `original_bf' contained BindingFlags.NonPublic.
15956 2003-04-05 Martin Baulig <martin@ximian.com>
15958 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
15959 probe if its a type parameter, and if so, flag an error.
15961 * decl.cs: Move here the SetParameterInfo code from class.cs.
15962 Handle IsGeneric here.
15964 Handle a variety of errors in the parameter info definition.
15966 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
15967 type parameters here.
15969 * cs-parser.jay (class_declaration): report errors for parameters
15972 2003-01-21 Miguel de Icaza <miguel@ximian.com>
15974 * generic.cs: New file, contains support code for generics.
15976 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
15977 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
15979 Update parser for the above removals.
15981 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
15982 now taken care of in the parser.
15984 2003-04-02 Miguel de Icaza <miguel@ximian.com>
15986 * class.cs (Event.Define): Do not allow abstract events to have
15989 2003-04-01 Miguel de Icaza <miguel@ximian.com>
15991 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
15992 block in event declarations.
15994 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
15995 value type, get its address.
15997 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
15998 leaving a class on the stack instead of a boolean value (int
15999 0/1). Change the code so we compare against null, and then the
16000 result against zero.
16002 * class.cs (TypeContainer.GetClassBases): We were checking for the
16003 parent class being sealed too late.
16005 * expression.cs (Binary.Emit): For <= and >= when dealing with
16006 floating point values, use cgt.un and clt.un instead of cgt and
16009 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
16011 * statement.cs: Apply the same optimization as MS: skip the
16012 GetEnumerator returning an IEnumerator, and use the one returning a
16013 CharEnumerator instead. This allows us to avoid the try-finally block
16016 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
16018 * cs-parser.jay: Attributes cannot be applied to
16019 namespaces. Fixes #40473
16021 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16024 (Add*): check if the name is valid using the full name for constants,
16025 fields, properties and events.
16027 2003-03-28 Miguel de Icaza <miguel@ximian.com>
16029 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
16030 char constants to be part of the enumeration.
16032 * expression.cs (Conditional.DoResolve): Add support for operator
16033 true. Implements the missing functionality from 14.12
16035 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
16036 operator true/false as required by the spec.
16038 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
16039 implicit conversion to boolean.
16041 * statement.cs (Statement.ResolveBoolean): A boolean expression is
16042 also one where the type implements `operator true'.
16044 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
16045 get an expression that will invoke operator true based on an
16048 (GetConversionOperators): Removed the hack that called op_True
16051 (Expression.ResolveBoolean): Move this from Statement.
16053 2003-03-17 Miguel de Icaza <miguel@ximian.com>
16055 * ecore.cs (FieldExpr): do not allow initialization of initonly
16056 fields on derived classes
16058 2003-03-13 Martin Baulig <martin@ximian.com>
16060 * statement.cs (Block.Emit): Call ig.BeginScope() and
16061 ig.EndScope() when compiling with debugging info; call
16062 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
16064 2003-03-08 Miguel de Icaza <miguel@ximian.com>
16066 * expression.cs (Indexers): Do not construct immediately, allow
16067 for new members to be appended as we go. Fixes 38143
16069 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16071 * expression.cs: save/restore context when resolving an unchecked
16074 2003-03-05 Miguel de Icaza <miguel@ximian.com>
16076 * cfold.cs: Catch division by zero in modulus operator during
16079 2003-03-03 Miguel de Icaza <miguel@ximian.com>
16081 * interface.cs (Interface.DefineMembers): Avoid defining members
16084 2003-02-27 Miguel de Icaza <miguel@ximian.com>
16086 * driver.cs: handle the +/- options for -noconfig
16088 * statement.cs (Unckeched.Resolve): Also track the state of
16089 unchecked in the Resolve phase.
16091 2003-02-27 Martin Baulig <martin@ximian.com>
16093 * ecore.cs (Expression.MemberLookup): Don't create a
16094 MethodGroupExpr for something which is not a method. Fixes #38291.
16096 2003-02-25 Miguel de Icaza <miguel@ximian.com>
16098 * class.cs (MemberBase.CheckParameters): Also check that the type
16099 is unmanaged if it is a pointer.
16101 * expression.cs (SizeOf.Resolve): Add location information.
16103 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
16104 a managed type is declared.
16106 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
16107 parameter modifiers as well. Fixes bug 38606
16109 * class.cs: Very sad. Am backing out the speed up changes
16110 introduced by the ArrayList -> Array in the TypeContainer, as they
16111 were not actually that much faster, and introduced a bug (no error
16112 reports on duplicated methods).
16114 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
16115 source first, this will guarantee that we have a valid expression
16116 before calling in lower levels functions that will require a
16117 resolved object. Then use this original_source in the
16118 target.ResolveLValue instead of the original source that was
16121 Another change. Use target.Resolve instead of LValueResolve.
16122 Although we are resolving for LValues, we will let the Assign code
16123 take care of that (it will be called again from Resolve). This
16124 basically allows code like this:
16126 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
16127 class Y { void A (X x) { x [0] += o; }
16129 The problem was that the indexer was trying to resolve for
16130 set_Item (idx, object o) and never finding one. The real set_Item
16131 was set_Item (idx, X). By delaying the process we get the right
16136 2003-02-23 Martin Baulig <martin@ximian.com>
16138 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
16139 while calling DoEmit ().
16141 * codegen.cs (EmitContext.Mark): Don't mark locations in other
16142 source files; if you use the #line directive inside a method, the
16143 compiler stops emitting line numbers for the debugger until it
16144 reaches the end of the method or another #line directive which
16145 restores the original file.
16147 2003-02-23 Martin Baulig <martin@ximian.com>
16149 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
16151 2003-02-23 Martin Baulig <martin@ximian.com>
16153 * statement.cs (Block.AddChildVariableNames): We need to call this
16154 recursively, not just for our immediate children.
16156 2003-02-23 Martin Baulig <martin@ximian.com>
16158 * class.cs (Event.Define): Always make the field private, like csc does.
16160 * typemanager.cs (TypeManager.RealMemberLookup): Make events
16161 actually work, fixes bug #37521.
16163 2003-02-23 Miguel de Icaza <miguel@ximian.com>
16165 * delegate.cs: When creating the various temporary "Parameters"
16166 classes, make sure that we call the ComputeAndDefineParameterTypes
16167 on those new parameters (just like we do with the formal ones), to
16168 allow them to be resolved in the context of the DeclSpace.
16170 This fixes the bug that Dick observed in Bugzilla #38530.
16172 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16174 * expression.cs (ResolveMemberAccess): When resolving a constant,
16175 do not attempt to pull a constant if the value was not able to
16176 generate a valid constant.
16178 * const.cs (LookupConstantValue): Do not report more errors than required.
16180 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16182 * expression.cs: fixes bug #38328.
16184 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16186 * class.cs: Changed all the various members that can be part of a
16187 class from being an ArrayList to be an Array of the right type.
16188 During the DefineType type_list, interface_list, delegate_list and
16189 enum_list are turned into types, interfaces, delegates and enums
16192 And during the member population, indexer_list, event_list,
16193 constant_list, field_list, instance_constructor_list, method_list,
16194 operator_list and property_list are turned into their real arrays.
16196 Although we could probably perform this operation earlier, for
16197 good error reporting we need to keep the lists and remove the
16198 lists for longer than required.
16200 This optimization was triggered by Paolo profiling the compiler
16201 speed on the output of `gen-sample-program.pl' perl script.
16203 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16204 not crash in methods like MemberLookupFailed that use this field.
16206 This problem arises when the compiler fails to resolve a type
16207 during interface type definition for example.
16209 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16211 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16212 inherit from System.Object, so we have to stop at null, not only
16213 when reaching System.Object.
16215 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16217 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16218 DeclaredOnly because the parent indexer might have had a different
16219 name, but did not loop until the top of the hierarchy was reached.
16221 The problem this one fixes is 35492: when a class implemented an
16222 indexer from an interface, we were getting the interface method
16223 (which was abstract) and we were flagging an error (can not invoke
16226 This also keeps bug 33089 functioning, and test-148 functioning.
16228 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16229 out if a method is special is to see if it is declared in a
16230 property or event, or whether it is one of the predefined operator
16231 names. This should fix correctly #36804.
16233 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16235 The goal here is to remove the dependency on EmptyCast.Peel ().
16236 Killing it completely.
16238 The problem is that currently in a number of places where
16239 constants are expected, we have to "probe" for an EmptyCast, and
16240 Peel, which is not the correct thing to do, as this will be
16241 repetitive and will likely lead to errors.
16243 The idea is to remove any EmptyCasts that are used in casts that
16244 can be reduced to constants, so we only have to cope with
16247 This bug hunt was triggered by Bug 37363 and the desire to remove
16248 the duplicate pattern where we were "peeling" emptycasts to check
16249 whether they were constants. Now constants will always be
16252 * ecore.cs: Use an enumconstant here instead of wrapping with
16255 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16256 throwing me off. By handling this we can get rid of a few hacks.
16258 * statement.cs (Switch): Removed Peel() code.
16260 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16262 * class.cs: Location information for error 508
16264 * expression.cs (New.DoResolve): Add a guard against double
16265 resolution of an expression.
16267 The New DoResolve might be called twice when initializing field
16268 expressions (see EmitFieldInitializers, the call to
16269 GetInitializerExpression will perform a resolve on the expression,
16270 and later the assign will trigger another resolution
16272 This leads to bugs (#37014)
16274 * delegate.cs: The signature for EndInvoke should contain any ref
16275 or out parameters as well. We were not doing this in the past.
16277 * class.cs (Field.Define): Do not overwrite the type definition
16278 inside the `volatile' group. Turns out that volatile enumerations
16279 were changing the type here to perform a validity test, which
16282 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16284 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16285 and structs, we do not want to load the instance variable
16287 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16288 enum_type has to be handled like an object reference (implicit
16289 conversions exists from this to object), but the regular IsClass
16290 and IsValueType tests will never return true for this one.
16292 Also we use TypeManager.IsValueType instead of type.IsValueType,
16293 just for consistency with the rest of the code (this is only
16294 needed if we ever use the construct exposed by test-180.cs inside
16295 corlib, which we dont today).
16297 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16299 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16302 2003-02-09 Martin Baulig <martin@ximian.com>
16304 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16305 (Namespace.DefineNamespaces): New static public method; this is
16306 called when we're compiling with debugging to add all namespaces
16307 to the symbol file.
16309 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16310 pass it to the Namespace's .ctor.
16312 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16313 and MethodBase arguments; pass the namespace ID to the symwriter;
16314 pass the MethodBase instead of the token to the symwriter.
16315 (SymbolWriter.DefineNamespace): New method to add a namespace to
16318 2003-02-09 Martin Baulig <martin@ximian.com>
16320 * symbolwriter.cs: New file. This is a wrapper around
16321 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16322 methods here in near future.
16324 2003-02-09 Martin Baulig <martin@ximian.com>
16326 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16327 ILGenerator.MarkSequencePoint() which are actually used by the
16330 2003-02-09 Martin Baulig <martin@ximian.com>
16332 * location.cs (SourceFile): New public sealed class. This
16333 contains the name and an index which is used in the location's token.
16334 (Location): Reserve an appropriate number of bits in the token for
16335 the source file instead of walking over that list, this gives us a
16336 really huge performance improvement when compiling with debugging.
16338 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16339 `SourceFile' argument instead of a string.
16340 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16341 but don't parse/tokenize here, we need to generate the list of all
16342 source files before we do that.
16343 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16346 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16347 instead of a string.
16349 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16352 2003-02-09 Martin Baulig <martin@ximian.com>
16354 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16355 filename on `#line default'.
16357 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16359 * statement.cs: don't clear the pinned var when the fixed statement
16360 returns from the method (fixes bug#37752).
16362 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16364 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16367 2003-02-07 Martin Baulig <martin@ximian.com>
16369 * driver.cs: Removed the `--debug-args' command line argument.
16371 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16372 automatically by the AsssemblyBuilder.
16373 (CodeGen.InitializeSymbolWriter): We don't need to call any
16374 initialization function on the symbol writer anymore. This method
16375 doesn't take any arguments.
16377 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16379 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16380 from referenced assemblies as well.
16382 2003-02-02 Martin Baulig <martin@ximian.com>
16384 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16386 2003-02-02 Martin Baulig <martin@ximian.com>
16388 * class.cs (Constructor.Emit): Open the symbol writer before
16389 emitting the constructor initializer.
16390 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16391 single-stepping through constructor initializers.
16393 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16395 * class.cs: Handle error 549: do not allow virtual methods in
16398 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16400 * decl.cs: Check access levels when resolving types
16402 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16404 * statement.cs: Add parameters and locals set in catch blocks that might
16405 return to set vector
16407 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16409 * class.cs (Operator): Set the SpecialName flags for operators.
16411 * expression.cs (Invocation.DoResolve): Only block calls to
16412 accessors and operators on SpecialName methods.
16414 (Cast.TryReduce): Handle conversions from char constants.
16417 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16419 * statement.cs: small memory and time optimization in FlowBranching.
16421 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16423 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16424 problem that the last fix but in the other sid (Set).
16426 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16427 access when there is no indexer in the hierarchy.
16429 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16431 * class.cs: Combine some if statements.
16433 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16435 * driver.cs: fixed bug #37187.
16437 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16439 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16440 any indexer, it's needed to build a list with all the indexers in the
16441 hierarchy (AllGetters), else we have problems. Fixes #35653.
16443 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16445 * class.cs (MethodData.Define): It is wrong for an interface
16446 implementation to be static in both cases: explicit and implicit.
16447 We were only handling this in one case.
16449 Improve the if situation there to not have negations.
16451 * class.cs (Field.Define): Turns out that we do not need to check
16452 the unsafe bit on field definition, only on usage. Remove the test.
16454 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16456 * driver.cs: use assembly.Location instead of Codebase (the latest
16457 patch made mcs fail when using MS assemblies).
16459 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16461 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16462 get the path to *corlib.dll.
16464 2003-01-21 Nick Drochak <ndrochak@gol.com>
16468 * typemanager.cs: Remove compiler warnings
16470 2003-01-20 Duncan Mak <duncan@ximian.com>
16472 * AssemblyInfo.cs: Bump the version number to 0.19.
16474 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16476 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16478 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16480 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16482 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16484 * cs-parser.jay: Small fix: we were not comparing the constructor
16485 name correctly. Thanks to Zoltan for the initial pointer.
16487 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16489 * cs-tokenizer.cs: Set file name when specified with #line
16491 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16493 * cs-parser.jay: Only perform the constructor checks here if we
16494 are named like the class; This will help provider a better
16495 error. The constructor path is taken when a type definition is
16496 not found, but most likely the user forgot to add the type, so
16497 report that rather than the constructor error.
16499 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16501 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16504 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16506 * cs-parser.jay: Add cleanup call.
16508 2003-01-13 Duncan Mak <duncan@ximian.com>
16510 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16511 consistent with other methods.
16513 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16515 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16517 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16519 * attribute.cs: only set GuidAttr to true when we have a
16522 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16526 * typemanager.cs: fixes to allow mcs compile corlib with the new
16527 Type.IsSubclassOf fix.
16529 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16531 * expression.cs (LocalVariableReference.DoResolve): Classify a
16532 constant as a value, not as a variable. Also, set the type for
16535 * cs-parser.jay (fixed_statement): take a type instead of a
16536 pointer_type, so we can produce a better error message later.
16538 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16541 (For.DoEmit): Make inifinite loops have a
16542 non-conditional branch back.
16544 (Fixed.DoEmit): First populate the pinned variables, then emit the
16545 statement, then clear the variables. Before I was emitting the
16546 code once for each fixed piece.
16549 2003-01-08 Martin Baulig <martin@ximian.com>
16551 * statement.cs (FlowBranching.MergeChild): A break in a
16552 SWITCH_SECTION does not leave a loop. Fixes #36155.
16554 2003-01-08 Martin Baulig <martin@ximian.com>
16556 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16557 lives in the same number space than `param_map'. Fixes #36154.
16559 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16561 * cs-parser.jay (constructor_declaration): Set the
16562 Constructor.ModFlags before probing for it. This makes the
16563 compiler report 514, 515 and 132 (the code was there, but got
16566 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16567 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16568 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16570 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16572 * enum.cs: create the enum static fields using the enum type.
16574 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16576 * class.cs: don't try to create the ParamBuilder for the return
16577 type if it's not needed (and handle it breaking for the ms runtime
16580 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16582 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16584 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16586 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16587 the command. This showed up while compiling the JANET source
16588 code, which used \r as its only newline separator.
16590 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16592 * class.cs (Method.Define): If we are an operator (because it
16593 reuses our code), then set the SpecialName and HideBySig. #36128
16595 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16597 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16598 exception, report error 120 `object reference required'.
16600 * driver.cs: Add --pause option, used during to measure the size
16601 of the process as it goes with --timestamp.
16603 * expression.cs (Invocation.DoResolve): Do not allow methods with
16604 SpecialName to be invoked.
16606 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16608 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16609 number before adding it.
16611 2002-12-21 Ravi Pratap <ravi@ximian.com>
16613 * ecore.cs (StandardImplicitConversion): When in an unsafe
16614 context, we allow conversion between void * to any other pointer
16615 type. This fixes bug #35973.
16617 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16619 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16620 is not thrown when extensionless outputs are used
16622 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16624 * rootcontext.cs: fixed compilation of corlib.
16626 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16628 * attribute.cs (Attributes.Contains): Add new method.
16630 * class.cs (MethodCore.LabelParameters): if the parameter is an
16631 `out' parameter, check that no attribute `[In]' has been passed.
16633 * enum.cs: Handle the `value__' name in an enumeration.
16635 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16637 * decl.cs: Added special case to allow overrides on "protected
16640 2002-12-18 Ravi Pratap <ravi@ximian.com>
16642 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16643 since it makes much more sense.
16645 (Attributes.ctor): Don't require a Location parameter.
16647 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16649 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16650 since we already have that information per attribute.
16652 * everywhere : make appropriate changes.
16654 * class.cs (LabelParameters): Write the code which actually
16655 applies attributes to the return type. We can't do this on the MS
16656 .NET runtime so we flag a warning in the case an exception is
16659 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16661 * const.cs: Handle implicit null conversions here too.
16663 2002-12-17 Ravi Pratap <ravi@ximian.com>
16665 * class.cs (MethodCore.LabelParameters): Remove the extra
16666 Type [] parameter since it is completely unnecessary. Instead
16667 pass in the method's attributes so that we can extract
16668 the "return" attribute.
16670 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16672 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16673 of ignoring it and letting the compile continue.
16675 * typemanager.cs (ChangeType): use an extra argument to return an
16676 error condition instead of throwing an exception.
16678 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16680 * expression.cs (Unary.TryReduce): mimic the code for the regular
16681 code path. Perform an implicit cast in the cases where we can
16682 implicitly convert to one of the integral types, and then reduce
16683 based on that constant. This fixes bug #35483.
16685 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16687 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16689 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16691 * namespace.cs: fixed bug #35489.
16693 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16695 * class.cs: Remove some dead code.
16697 * cs-parser.jay: Estimate the number of methods needed
16698 (RootContext.MethodCount);
16700 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16701 numbers instead of StringBuilders.
16703 * support.cs (PtrHashtable): Add constructor with initial size;
16704 We can now reduce reallocations of the method table.
16706 2002-12-10 Ravi Pratap <ravi@ximian.com>
16708 * attribute.cs (ApplyAttributes): Keep track of the emitted
16709 attributes on a per-target basis. This fixes bug #35413.
16711 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16713 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16714 default to the Windows 1252 encoding.
16716 (UnixParseOption): Support version, thanks to Alp for the missing
16719 * AssemblyInfo.cs: Add nice assembly information.
16721 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16724 * cs-parser.jay: Allow a trailing comma before the close bracked
16725 in the attribute_section production.
16727 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16728 address of the instance was being taken, I will take this out,
16729 because we take the address of the object immediately here.
16731 2002-12-09 Ravi Pratap <ravi@ximian.com>
16733 * typemanager.cs (AreMultipleAllowed): Take care of the most
16734 obvious case where attribute type is not in the current assembly -
16737 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16739 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16740 definitions, instead of doing that afterwards.
16742 Also we use a nice little hack, depending on the constructor, we
16743 know if we are a "composed" name or a simple name. Hence, we
16744 avoid the IndexOf test, and we avoid
16746 * codegen.cs: Add code to assist in a bug reporter to track down
16747 the source of a compiler crash.
16749 2002-12-07 Ravi Pratap <ravi@ximian.com>
16751 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16752 types have been emitted for a given element and flag an error
16753 if something which does not have AllowMultiple set is used more
16756 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16757 attribute types and their corresponding AllowMultiple properties
16759 (AreMultipleAllowed): Check the property for a given type.
16761 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16762 property in the case we have a TypeContainer.
16764 (Attributes.AddAttribute): Detect duplicates and just skip on
16765 adding them. This trivial fix catches a pretty gross error in our
16766 attribute emission - global attributes were being emitted twice!
16768 Bugzilla bug #33187 is now fixed.
16770 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16772 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16773 instead of pp_and).
16775 * expression.cs (Binary.ResolveOperator): I can only use the
16776 Concat (string, string, string) and Concat (string, string,
16777 string, string) if the child is actually a concatenation of
16780 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16782 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16783 context where we need a 2-character lookahead.
16785 * pending.cs (PendingImplementation): Rework so we can keep track
16786 of interface types all the time, and flag those which were
16787 implemented by parents as optional.
16789 2002-12-03 Miguel de Icaza <miguel@ximian.com>
16791 * expression.cs (Binary.ResolveOperator): Use
16792 String.Concat(string,string,string) or
16793 String.Concat(string,string,string,string) when possible.
16795 * typemanager: More helper methods.
16798 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
16800 * pending.cs: remove the bogus return from GetMissingInterfaces()
16801 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
16803 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16805 * namespace.cs: avoid duplicated 'using xxx' being added to
16806 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
16807 when we get more than one 'using' statement for the same namespace.
16808 Report a CS0105 warning for it.
16810 2002-11-30 Miguel de Icaza <miguel@ximian.com>
16812 * cs-tokenizer.cs (consume_identifier): use read directly, instead
16813 of calling getChar/putback, uses internal knowledge of it.
16815 (xtoken): Reorder tokenizer so most common patterns are checked
16816 first. This reduces the compilation time in another 5% (from 8.11s
16817 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
16819 The parsing time is 22% of the compilation in mcs, and from that
16820 64% is spent on the tokenization process.
16822 I tried using a binary search for keywords, but this is slower
16823 than the hashtable. Another option would be to do a couple of
16826 * Not use a StringBuilder, instead use an array of chars,
16827 with a set value. Notice that this way we could catch
16828 the 645 error without having to do it *afterwards*.
16830 * We could write a hand-parser to avoid the hashtable
16831 compares altogether.
16833 The identifier consumption process takes 37% of the tokenization
16834 time. Another 15% is spent on is_number. 56% of the time spent
16835 on is_number is spent on Int64.Parse:
16837 * We could probably choose based on the string length to
16838 use Int32.Parse or Int64.Parse and avoid all the 64-bit
16841 Another 3% is spend on wrapping `xtoken' in the `token' function.
16843 Handle 0xa0 as whitespace (#34752)
16845 2002-11-26 Miguel de Icaza <miguel@ximian.com>
16847 * typemanager.cs (IsCLRType): New routine to tell whether a type
16848 is one of the builtin types.
16850 Maybe it needs to use TypeCodes to be faster. Maybe we could use
16851 typecode in more places instead of doing pointer comparissions.
16852 We could leverage some knowledge about the way the typecodes are
16855 New code to cache namespaces in assemblies, it is currently not
16856 invoked, to be used soon.
16858 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
16860 * expression.cs (Binary.ResolveOperator): specially handle
16861 strings, and do not perform user-defined operator overloading for
16864 2002-11-24 Miguel de Icaza <miguel@ximian.com>
16866 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
16867 internalcall as it is a pretty simple operation; Avoid whenever
16868 possible to call Char.IsLetter.
16870 (consume_identifier): Cut by half the number of
16871 hashtable calls by merging the is_keyword and GetKeyword behavior.
16873 Do not short-circuit, because if we do, we
16874 report errors (ie, #if false && true would produce an invalid
16878 2002-11-24 Martin Baulig <martin@ximian.com>
16880 * expression.cs (Cast.TryReduce): If we're in checked syntax,
16881 check constant ranges and report a CS0221. Fixes #33186.
16883 2002-11-24 Martin Baulig <martin@ximian.com>
16885 * cs-parser.jay: Make this work for uninitialized variable
16886 declarations in the `for' initializer. Fixes #32416.
16888 2002-11-24 Martin Baulig <martin@ximian.com>
16890 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
16891 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
16893 2002-11-24 Martin Baulig <martin@ximian.com>
16895 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
16896 argument; if true, we also check for user-defined conversions.
16897 This is only needed if both arguments are of a user-defined type.
16898 Fixes #30443, added test-175.cs.
16899 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
16901 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
16903 2002-11-24 Martin Baulig <martin@ximian.com>
16905 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
16906 function to get the store opcode.
16907 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
16908 only emit the Ldelema if the store opcode is Stobj. You must run
16909 both test-34 and test-167 to test this. Fixes #34529.
16911 2002-11-23 Martin Baulig <martin@ximian.com>
16913 * ecore.cs (Expression.MemberLookup): Added additional
16914 `qualifier_type' argument which is used when we're being called
16915 from MemberAccess.DoResolve() and null if we're called from a
16917 (Expression.MemberLookupFailed): New method to report errors; this
16918 does the CS1540 check and reports the correct error message.
16920 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
16921 argument for the CS1540 check and redone the way how we're dealing
16922 with private members. See the comment in the source code for details.
16923 (FilterWithClosure): Reverted this back to revision 1.197; renamed
16924 `closure_start_type' to `closure_qualifier_type' and check whether
16925 it's not null. It was not this filter being broken, it was just
16926 being called with the wrong arguments.
16928 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
16929 and pass it the correct `qualifier_type'; this also does the error
16932 2002-11-22 Miguel de Icaza <miguel@ximian.com>
16934 * expression.cs (Invocation.EmitParams): If the we are dealing
16935 with a non-built-in value type, load its address as well.
16937 (ArrayCreation): Use a a pretty constant instead
16938 of the hardcoded value 2. Use 6 instead of 2 for the number of
16939 static initializers.
16941 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
16942 because they are not really value types, just glorified integers.
16944 * driver.cs: Do not append .exe, the CSC compiler does not do it.
16946 * ecore.cs: Remove redundant code for enumerations, make them use
16947 the same code path as everything else, fixes the casting issue
16948 with enumerations in Windows.Forms.
16950 * attribute.cs: Do only cast to string if it is a string, the
16951 validation happens later.
16953 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
16954 people upgrade their corlibs.
16956 * ecore.cs: Oops, enumerations were not following the entire code path
16958 2002-11-21 Miguel de Icaza <miguel@ximian.com>
16960 * typemanager.cs (FilterWithClosure): Commented out the test for
16961 1540 in typemanager.cs, as it has problems when accessing
16962 protected methods from a parent class (see test-174.cs).
16964 * attribute.cs (Attribute.ValidateGuid): new method.
16965 (Attribute.Resolve): Use above.
16967 2002-11-19 Miguel de Icaza <miguel@ximian.com>
16969 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
16971 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
16972 handling for enumerations, as we only needed the TypeContainer
16973 functionality to begin with (this is required for the fix below to
16974 work for enums that reference constants in a container class for
16977 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
16979 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
16980 a valid TypeBuilder to perform lookups on.o
16982 * class.cs (InheritableMemberSignatureCompare): Use true in the
16983 call to GetGetMethod and GetSetMethod, because we are comparing
16984 the signature, and we need to get the methods *even* if they are
16987 (PropertyBase.CheckBase): ditto.
16989 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
16990 GotoCase.Resolve): Use Peel on EmpytCasts.
16992 * ecore.cs (EmptyCast): drop child, add Peel method.
16994 2002-11-17 Martin Baulig <martin@ximian.com>
16996 * ecore.cs (EmptyCast.Child): New public property.
16998 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
16999 label resolved to an EmptyCast. Fixes #34162.
17000 (GotoCase.Resolve): Likewise.
17001 (Block.EmitMeta): Likewise.
17003 2002-11-17 Martin Baulig <martin@ximian.com>
17005 * expression.cs (Invocation.BetterConversion): Prefer int over
17006 uint; short over ushort; long over ulong for integer literals.
17007 Use ImplicitConversionExists instead of StandardConversionExists
17008 since we also need to check for user-defined implicit conversions.
17009 Fixes #34165. Added test-173.cs.
17011 2002-11-16 Martin Baulig <martin@ximian.com>
17013 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
17014 with the `true' and `false' literals. Fixes #33151.
17016 2002-11-16 Martin Baulig <martin@ximian.com>
17018 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
17019 October 22nd; don't do the cs1540 check for static members.
17021 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
17022 now using our own filter here and doing the cs1540 check again.
17024 2002-11-16 Martin Baulig <martin@ximian.com>
17026 * support.cs (InternalParameters): Don't crash if we don't have
17027 any fixed parameters. Fixes #33532.
17029 2002-11-16 Martin Baulig <martin@ximian.com>
17031 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
17032 when looking up static methods to make this work on Windows.
17035 2002-11-16 Martin Baulig <martin@ximian.com>
17037 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
17038 a setter rather than using PropertyInfo.CanWrite.
17040 2002-11-15 Nick Drochak <ndrochak@gol.com>
17042 * class.cs: Allow acces to block member by subclasses. Fixes build
17045 2002-11-14 Martin Baulig <martin@ximian.com>
17047 * class.cs (Constructor.Emit): Added the extern/block check.
17050 2002-11-14 Martin Baulig <martin@ximian.com>
17052 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
17053 iteration while looking for indexers, this is needed because the
17054 indexer may have a different name in our base classes. Fixed the
17055 error reporting (no indexers at all, not get accessor, no
17056 overloaded match). Fixes bug #33089.
17057 (IndexerAccess.DoResolveLValue): Likewise.
17059 2002-11-14 Martin Baulig <martin@ximian.com>
17061 * class.cs (PropertyBase.CheckBase): Make this work for multiple
17062 indexers. Fixes the first part of bug #33089.
17063 (MethodSignature.InheritableMemberSignatureCompare): Added support
17066 2002-11-13 Ravi Pratap <ravi@ximian.com>
17068 * attribute.cs (Attribute.Resolve): Catch the
17069 NullReferenceException and report it since it isn't supposed to
17072 2002-11-12 Miguel de Icaza <miguel@ximian.com>
17074 * expression.cs (Binary.EmitBranchable): Also handle the cases for
17075 LogicalOr and LogicalAnd that can benefit from recursively
17076 handling EmitBranchable. The code now should be nice for Paolo.
17078 2002-11-08 Miguel de Icaza <miguel@ximian.com>
17080 * typemanager.cs (LookupType): Added a negative-hit hashtable for
17081 the Type lookups, as we perform quite a number of lookups on
17082 non-Types. This can be removed once we can deterministically tell
17083 whether we have a type or a namespace in advance.
17085 But this might require special hacks from our corlib.
17089 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
17090 and double which avoids a conversion from an integer to a double.
17092 * expression.cs: tiny optimization, avoid calling IsConstant,
17093 because it effectively performs the lookup twice.
17095 2002-11-06 Miguel de Icaza <miguel@ximian.com>
17097 But a bogus return here to keep the semantics of the old code
17098 until the Mono runtime is fixed.
17100 * pending.cs (GetMissingInterfaces): New method used to remove all
17101 the interfaces that are already implemented by our parent
17102 classes from the list of pending methods.
17104 * interface.cs: Add checks for calls after ResolveTypeExpr.
17106 2002-11-05 Miguel de Icaza <miguel@ximian.com>
17108 * class.cs (Class.Emit): Report warning 67: event not used if the
17109 warning level is beyond 3.
17111 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
17112 being a NullLiteral.
17114 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
17117 * class.cs (TypeContainer.GetClassBases): Cover a missing code
17118 path that might fail if a type can not be resolved.
17120 * expression.cs (Binary.Emit): Emit unsigned versions of the
17123 * driver.cs: use error 5.
17125 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
17127 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
17129 2002-11-01 Miguel de Icaza <miguel@ximian.com>
17131 * cs-parser.jay (switch_section): A beautiful patch from Martin
17132 Baulig that fixed 33094.
17134 2002-10-31 Miguel de Icaza <miguel@ximian.com>
17136 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
17137 Check whether the base is abstract and report an error if so.
17139 * expression.cs (IndexerAccess.DoResolveLValue,
17140 IndexerAccess.DoResolve): ditto.
17142 (Invocation.DoResolve): ditto.
17144 (Invocation.FullMethodDesc): Improve the report string.
17146 * statement.cs (Block): Eliminate IsVariableDefined as it is
17147 basically just a wrapper for GetVariableInfo.
17149 * ecore.cs (SimpleName): Use new
17151 * support.cs (ReflectionParamter.ParameterType): We unwrap the
17152 type, as we return the actual parameter ref/unref state on a
17155 2002-10-30 Miguel de Icaza <miguel@ximian.com>
17157 * support.cs: Return proper flags REF/OUT fixing the previous
17160 * expression.cs: Reverted last patch, that was wrong. Is_ref is
17161 not used to mean `ref' but `ref or out' in ParameterReference
17163 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
17164 full type signature instead of calling TypeManger.CSharpName
17167 * support.cs (InternalParameters.ParameterDesc): Do not compare
17168 directly to the modflags, because REF/OUT will actually be bitsets
17171 * delegate.cs (VerifyMethod): Check also the modifiers.
17173 * cs-tokenizer.cs: Fix bug where floating point values with an
17174 exponent where a sign was missing was ignored.
17176 * driver.cs: Allow multiple assemblies to be specified in a single
17179 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17181 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17182 because identifiers after a parenthesis would end up in this kind
17183 of production, and we needed to desamiguate it for having casts
17186 (UserDefinedType *) xxx
17188 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17190 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17191 we should set on the Bindingflags.NonPublic, but not turn on
17192 private_ok. private_ok controls whether a Private member is
17193 returned (this is chekced on the filter routine), while the
17194 BindingFlags.NonPublic just controls whether private/protected
17195 will be allowed. This fixes the problem part of the problem of
17196 private properties being allowed to be used in derived classes.
17198 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17199 so we can call the children DoResolveLValue method (this will
17200 properly signal errors on lvalue assignments to base properties)
17202 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17203 getter are null, and we have a property info, we know that this
17204 happened because the lookup failed, so we report an error 122 for
17205 protection level violation.
17207 We also silently return if setter and getter are null in the
17208 resolve functions, this condition only happens if we have flagged
17209 the error before. This is the other half of the problem.
17211 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17212 not have accessibility information, that is why we were returning
17213 true in the filter function in typemanager.cs.
17215 To properly report 122 (property is inaccessible because of its
17216 protection level) correctly, we report this error in ResolveAccess
17217 by failing if both the setter and the getter are lacking (ie, the
17220 DoResolve and DoLResolve have been modified to check for both
17221 setter/getter being null and returning silently, the reason being
17222 that I did not want to put the knowledge about this error in upper
17225 int old = Report.Errors;
17226 x = new PropertyExpr (...);
17227 if (old != Report.Errors)
17232 So the property expr is returned, but it is invalid, so the error
17233 will be flagged during the resolve process.
17235 * class.cs: Remove InheritablePropertySignatureCompare from the
17236 class, as we no longer depend on the property signature to compute
17237 whether it is possible to implement a method or not.
17239 The reason is that calling PropertyInfo.GetGetMethod will return
17240 null (in .NET, in Mono it works, and we should change this), in
17241 cases where the Get Method does not exist in that particular
17246 class X { public virtual int A { get { return 1; } } }
17248 class Z : Y { public override int A { get { return 2; } } }
17250 Would fail in Z because the parent (Y) would not have the property
17251 defined. So we avoid this completely now (because the alternative
17252 fix was ugly and slow), and we now depend exclusively on the
17255 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17256 reference method, instead of using the property.
17258 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17259 routines are gone now.
17261 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17262 names, they were incorrectly named.
17264 * cs-tokenizer.cs: Return are more gentle token on failure.
17266 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17267 had an out-of-sync index variable, which caused it to remove from
17268 the list of pending methods the wrong method sometimes.
17270 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17272 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17273 CanWrite, because those refer to this particular instance of the
17274 property, and do not take into account the fact that we can
17275 override single members of a property.
17277 Constructor requires an EmitContext. The resolution process does
17278 not happen here, but we need to compute the accessors before,
17279 because the resolution does not always happen for properties.
17281 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17282 subclass, before we did not update this flag, but we did update
17285 (GetAccessors): Drop this routine, as it did not work in the
17286 presence of partially overwritten set/get methods.
17288 Notice that this broke the cs1540 detection, but that will require
17291 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17295 * driver.cs: issue a warning instead of an error if we don't support
17296 debugging for the platform. Also ignore a couple of errors that may
17297 arise when trying to write the symbols. Undo my previous patch.
17299 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17301 * driver.cs: ignore /debug switch except for Unix platforms.
17303 2002-10-23 Nick Drochak <ndrochak@gol.com>
17305 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17307 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17309 * driver.cs: Do not make mcs-debug conditional, so we do not break
17310 builds that use it.
17312 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17313 review this patch. But basically after all the children variables
17314 have been merged, the value of "Breaks" was not being set to
17315 new_breaks for Switch blocks. I think that it should be set after
17316 it has executed. Currently I set this to the value of new_breaks,
17317 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17318 conservative, but I do not understand this code very well.
17320 I did not break anything in the build, so that is good ;-)
17322 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17324 2002-10-20 Mark Crichton <crichton@gimp.org>
17326 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17328 2002-10-20 Nick Drochak <ndrochak@gol.com>
17330 * cfold.cs: Fixed compile blocker.
17332 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17334 * driver.cs: I was chekcing the key, not the file.
17336 2002-10-19 Ravi Pratap <ravi@ximian.com>
17338 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17339 message that we were generating - we just need to silently return
17342 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17344 * class.cs (Event.Define): Change my previous commit, as this
17345 breaks the debugger. This is a temporary hack, as it seems like
17346 the compiler is generating events incorrectly to begin with.
17348 * expression.cs (Binary.ResolveOperator): Added support for
17349 "U operator - (E x, E y)"
17351 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17354 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17355 init-only variables, but this path did not take into account that
17356 there might be also instance readonly variables. Correct this
17359 This fixes bug 32253
17361 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17364 * driver.cs: Change the extension for modules to `netmodule'
17366 * cs-parser.jay: Improved slightly the location tracking for
17367 the debugger symbols.
17369 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17370 modifiers that were specified instead of the hardcoded value
17371 (FamAndAssem). This was basically ignoring the static modifier,
17372 and others. Fixes 32429.
17374 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17375 fixed a bug in the process (32476)
17377 * expression.cs (ArrayAccess.EmitAssign): Patch from
17378 hwang_rob@yahoo.ca that fixes bug 31834.3
17380 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17382 * driver.cs: Make the module extension .netmodule.
17384 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17386 * driver.cs: Report an error if the resource file is not found
17387 instead of crashing.
17389 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17390 false, like Emit does.
17392 2002-10-16 Nick Drochak <ndrochak@gol.com>
17394 * typemanager.cs: Remove unused private member. Also reported mcs
17395 bug to report this as a warning like csc.
17397 2002-10-15 Martin Baulig <martin@gnome.org>
17399 * statement.cs (Statement.Emit): Made this a virtual method; emits
17400 the line number info and calls DoEmit().
17401 (Statement.DoEmit): New protected abstract method, formerly knows
17402 as Statement.Emit().
17404 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17406 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17408 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17409 have fixed a remaining problem: not every AddXXXX was adding a
17410 fully qualified name.
17412 Now everyone registers a fully qualified name in the DeclSpace as
17413 being defined instead of the partial name.
17415 Downsides: we are slower than we need to be due to the excess
17416 copies and the names being registered this way.
17418 The reason for this is that we currently depend (on the corlib
17419 bootstrap for instance) that types are fully qualified, because
17420 we dump all the types in the namespace, and we should really have
17421 types inserted into the proper namespace, so we can only store the
17422 basenames in the defined_names array.
17424 2002-10-10 Martin Baulig <martin@gnome.org>
17426 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17427 from bug #31834, see the bug report for a testcase which is
17430 2002-10-10 Martin Baulig <martin@gnome.org>
17432 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17433 flow analysis code for this.
17435 * statement.cs (Do, While, For): Tell the flow analysis code about
17437 (FlowBranching.UsageVector): Added support for infinite loops.
17438 (Block.Resolve): Moved the dead code elimination here and use flow
17441 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17443 * class.cs (Field.Define): Catch cycles on struct type
17446 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17447 fields if the fields are static. We only need to check instance
17450 * expression.cs (As.DoResolve): Test for reference type.
17452 * statement.cs (Using.ResolveExpression): Use
17453 ConvertImplicitRequired, not ConvertImplicit which reports an
17455 (Using.ResolveLocalVariableDecls): ditto.
17457 * expression.cs (Binary.ResolveOperator): Report errors in a few
17458 places where we had to.
17460 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17462 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17464 * expression.cs: Use StoreFromPtr instead of extracting the type
17465 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17467 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17468 an enumeration value to a System.Enum, but System.Enum is not a
17469 value type, but an class type, so we need to box.
17471 (Expression.ConvertExplicit): One codepath could return
17472 errors but not flag them. Fix this. Fixes #31853
17474 * parameter.cs (Resolve): Do not allow void as a parameter type.
17476 2002-10-06 Martin Baulig <martin@gnome.org>
17478 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17479 if it's a class type and not a struct. Fixes #31815.
17481 2002-10-06 Martin Baulig <martin@gnome.org>
17483 * statement.cs: Reworked the flow analysis code a bit to make it
17484 usable for dead code elimination.
17486 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17488 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17490 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17492 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17493 to fix the test 165, will investigate deeper.
17495 2002-10-04 Martin Baulig <martin@gnome.org>
17497 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17498 finally blocks actually work.
17499 (Try.Resolve): We don't need to create a sibling for `finally' if
17500 there is no finally block.
17502 2002-10-04 Martin Baulig <martin@gnome.org>
17504 * class.cs (Constructor.Define): The default accessibility for a
17505 non-default constructor is private, not public.
17507 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17509 * class.cs (Constructor): Make AllowedModifiers public, add
17512 * cs-parser.jay: Perform the modifiers test here, as the
17513 constructor for the Constructor class usually receives a zero
17514 because of the way we create it (first we create, later we
17515 customize, and we were never checking the modifiers).
17517 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17518 is a version of LookupTypeReflection that includes the type-name
17519 cache. This can be used as a fast path for functions that know
17520 the fully qualified name and are only calling into *.GetType() to
17521 obtain a composed type.
17523 This is also used by TypeManager.LookupType during its type
17526 (LookupType): We now also track the real type name, as sometimes
17527 we can get a quey for the real type name from things like
17528 ComposedCast. This fixes bug 31422.
17530 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17531 complete type fullname, it does not have to go through the type
17532 resolution system to obtain the composed version of the type (for
17533 obtaining arrays or pointers).
17535 (Conditional.Emit): Use the EmitBoolExpression to
17536 generate nicer code, as requested by Paolo.
17538 (ArrayCreation.CheckIndices): Use the patch from
17539 hwang_rob@yahoo.ca to validate the array initializers.
17541 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17543 * class.cs (ConstructorInitializer.Emit): simplify code by using
17544 Invocation.EmitCall, and at the same time, fix the bugs in calling
17545 parent constructors that took variable arguments.
17547 * ecore.cs (Expression.ConvertNumericExplicit,
17548 Expression.ImplicitNumericConversion): Remove the code that
17549 manually wrapped decimal (InternalTypeConstructor call is now gone
17552 * expression.cs (Cast.TryReduce): Also handle decimal types when
17553 trying to perform a constant fold on the type.
17555 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17557 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17558 that only turned off an error report, and did nothing else.
17560 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17562 * driver.cs: Handle and ignore /fullpaths
17564 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17566 * expression.cs (Binary.ResolveOperator): Catch the case where
17567 DoNumericPromotions returns true,
17569 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17571 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17573 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17576 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17578 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17579 conversion exists, but it is also required that the conversion be
17580 performed. This manifested in "(Type64Enum) 2".
17582 * class.cs (TypeManager.AddMethod): The fix is not to change
17583 AddEnum, because that one was using a fully qualified name (every
17584 DeclSpace derivative does), but to change the AddMethod routine
17585 that was using an un-namespaced name. This now correctly reports
17586 the duplicated name.
17588 Revert patch until I can properly fix it. The issue
17589 is that we have a shared Type space across all namespaces
17590 currently, which is wrong.
17592 Options include making the Namespace a DeclSpace, and merge
17593 current_namespace/current_container in the parser.
17595 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17597 * cs-parser.jay: Improve error reporting when we get a different
17598 kind of expression in local_variable_type and
17599 local_variable_pointer_type.
17601 Propagate this to avoid missleading errors being reported.
17603 * ecore.cs (ImplicitReferenceConversion): treat
17604 TypeManager.value_type as a target just like object_type. As
17609 Is valid, and needs to result in the int 1 being boxed before it
17610 is assigned to the value type v.
17612 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17613 to validate the enumeration name.
17615 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17616 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17617 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17619 * ecore.cs (TryImplicitIntConversion): When doing an
17620 implicit-enumeration-conversion, check if the type is 64-bits and
17621 perform a conversion before passing to EnumConstant.
17623 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17625 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17626 report ambiguous type references. Unlike the MS version, we
17627 report what the ambiguity is. Innovation at work ;-)
17629 (DeclSpace.FindType): Require a location argument to
17630 display when we display an ambiguous error.
17632 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17634 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17636 * expression.cs (EmitDynamicInitializers): Apply patch from
17637 hwang_rob@yahoo.ca that fixes the order in which we emit our
17640 2002-09-21 Martin Baulig <martin@gnome.org>
17642 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17643 delegate takes no arguments.
17645 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17647 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17650 * expression.cs: Extract the underlying type.
17652 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17654 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17656 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17658 * class.cs (TypeContainer.DefineType): We can not use the nice
17659 PackingSize with the size set to 1 DefineType method, because it
17660 will not allow us to define the interfaces that the struct
17663 This completes the fixing of bug 27287
17665 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17666 means also structs. This fixes part of the problem.
17667 (Expresion.ImplicitReferenceConversionExists): ditto.
17669 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17670 error if there were no errors reported during the type lookup
17671 process, to avoid duplicates or redundant errors. Without this
17672 you would get an ambiguous errors plus a type not found. We have
17673 beaten the user enough with the first error.
17675 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17678 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17679 during the resolution process, stop the lookup, this avoids
17680 repeated error reports (same error twice).
17682 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17684 * typemanager.cs (LookupType): Redo the type lookup code to match
17685 the needs of System.Reflection.
17687 The issue is that System.Reflection requires references to nested
17688 types to begin with a "+" sign instead of a dot. So toplevel
17689 types look like: "NameSpace.TopLevelClass", and nested ones look
17690 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17693 2002-09-19 Martin Baulig <martin@gnome.org>
17695 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17696 says that a method always returns or always throws an exception,
17697 don't report the CS0161.
17699 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17700 set `Returns = new_returns'.
17702 2002-09-19 Martin Baulig <martin@gnome.org>
17704 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17705 to an enum constant, check for a CS0176.
17707 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17709 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17710 for operators that must be in pairs and report errors.
17712 * ecore.cs (SimpleName.DoResolveType): During the initial type
17713 resolution process, when we define types recursively, we must
17714 check first for types in our current scope before we perform
17715 lookups in the enclosing scopes.
17717 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17719 (Invocation.VerifyArgumentsCompat): Call
17720 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17721 I thought we were supposed to always call this, but there are a
17722 few places in the code where we dont do it.
17724 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17726 * driver.cs: Add support in -linkres and -resource to specify the
17727 name of the identifier.
17729 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17731 * ecore.cs (StandardConversionExists): Sync with the conversion
17732 code: allow anything-* to void* conversions.
17734 (FindMostSpecificSource): Use an Expression argument
17735 instead of a Type, because we might be handed over a Literal which
17736 gets a few more implicit conversions that plain types do not. So
17737 this information was being lost.
17739 Also, we drop the temporary type-holder expression when not
17742 2002-09-17 Martin Baulig <martin@gnome.org>
17744 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17745 this is an explicit interface implementation.
17747 2002-09-17 Martin Baulig <martin@gnome.org>
17749 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17750 different `IndexerName' attributes.
17752 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17753 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17754 virtual CommonResolve().
17756 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17758 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17759 and convert that to the UnderlyingType.
17761 * statement.cs (Foreach.Resolve): Indexers are just like variables
17762 or PropertyAccesses.
17764 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17765 inside quoted strings, we were not doing this before.
17767 2002-09-16 Martin Baulig <martin@gnome.org>
17769 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17770 resolve it. This is needed for the definite assignment check of the
17771 instance expression, fixes bug #29846.
17772 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17774 2002-09-16 Nick Drochak <ndrochak@gol.com>
17776 * parameter.cs: Fix compile error. Cannot reference static member
17777 from an instance object. Is this an mcs bug?
17779 2002-09-14 Martin Baulig <martin@gnome.org>
17781 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17782 multiple times. Fixes bug #30295, added test-166.cs.
17784 2002-09-14 Martin Baulig <martin@gnome.org>
17786 * statement.cs (Block.Emit): Don't emit unreachable code.
17787 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
17788 `break' statements.
17789 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
17791 2002-09-14 Martin Baulig <martin@gnome.org>
17793 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
17796 2002-09-14 Martin Baulig <martin@gnome.org>
17798 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
17799 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
17800 be false on the ms runtime.
17802 2002-09-13 Martin Baulig <martin@gnome.org>
17804 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
17805 the CS0038 error message.
17807 2002-09-12 Miguel de Icaza <miguel@ximian.com>
17809 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
17810 constant inside, return it.
17812 2002-09-12 Martin Baulig <martin@gnome.org>
17814 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
17815 implicit conversion can be done between enum types.
17817 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
17818 check whether an implicit conversion to the current enum's UnderlyingType
17819 exists and report an error if not.
17821 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
17822 without debugging support.
17824 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
17825 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
17827 2002-09-12 Martin Baulig <martin@gnome.org>
17829 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
17831 * ecore.cs (IMemberExpr.DeclaringType): New property.
17832 (SimpleName.SimpleNameResolve): Check whether we're accessing a
17833 nonstatic member of an outer type (CS0038).
17835 2002-09-11 Miguel de Icaza <miguel@ximian.com>
17837 * driver.cs: Activate the using-error detector at warning level
17838 4 (at least for MS-compatible APIs).
17840 * namespace.cs (VerifyUsing): Small buglett fix.
17842 * pending.cs (PendingImplementation): pass the container pointer.
17844 * interface.cs (GetMethods): Allow for recursive definition. Long
17845 term, I would like to move every type to support recursive
17846 definitions, not the current ordering mechanism that we have right
17849 The situation is this: Attributes are handled before interfaces,
17850 so we can apply attributes to interfaces. But some attributes
17851 implement interfaces, we will now handle the simple cases
17852 (recursive definitions will just get an error).
17854 * parameter.cs: Only invalidate types at the end if we fail to
17857 2002-09-09 Martin Baulig <martin@gnome.org>
17859 * ecore.cs (PropertyExpr.Emit): Also check for
17860 TypeManager.system_int_array_get_length so this'll also work when
17861 compiling corlib. Fixes #30003.
17863 2002-09-09 Martin Baulig <martin@gnome.org>
17865 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
17866 and throw an exception if we can't get the type's size. Fixed #30040,
17869 2002-09-09 Martin Baulig <martin@gnome.org>
17871 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
17873 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
17874 context. Fixes bug #30027.
17876 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
17877 virtual functions. Fixes bug #30043, added test-164.cs.
17879 2002-09-08 Ravi Pratap <ravi@ximian.com>
17881 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
17883 2002-09-08 Nick Drochak <ndrochak@gol.com>
17885 * driver.cs: Use an object to get the windows codepage since it's not a
17888 2002-09-08 Miguel de Icaza <miguel@ximian.com>
17890 * statement.cs (For.Emit): for infinite loops (test == null)
17891 return whether there is a break inside, not always "true".
17893 * namespace.cs (UsingEntry): New struct to hold the name of the
17894 using definition, the location where it is defined, and whether it
17895 has been used in a successful type lookup.
17897 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
17902 2002-09-06 Ravi Pratap <ravi@ximian.com>
17904 * attribute.cs : Fix incorrect code which relied on catching
17905 a NullReferenceException to detect a null being passed in
17906 where an object was expected.
17908 2002-09-06 Miguel de Icaza <miguel@ximian.com>
17910 * statement.cs (Try): flag the catch variable as assigned
17912 * expression.cs (Cast): Simplified by using ResolveType instead of
17913 manually resolving.
17915 * statement.cs (Catch): Fix bug by using ResolveType.
17917 2002-09-06 Ravi Pratap <ravi@ximian.com>
17919 * expression.cs (BetterConversion): Special case for when we have
17920 a NullLiteral as the argument and we have to choose between string
17921 and object types - we choose string the way csc does.
17923 * attribute.cs (Attribute.Resolve): Catch the
17924 NullReferenceException and report error #182 since the Mono
17925 runtime no more has the bug and having this exception raised means
17926 we tried to select a constructor which takes an object and is
17929 2002-09-05 Ravi Pratap <ravi@ximian.com>
17931 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
17932 message (1502, 1503) when we can't locate a method after overload
17933 resolution. This is much more informative and closes the bug
17936 * interface.cs (PopulateMethod): Return if there are no argument
17937 types. Fixes a NullReferenceException bug.
17939 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
17940 expressions too. Previously we were checking only in one place for
17941 positional arguments leaving out named arguments.
17943 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
17944 type to the enum type is not allowed. Remove code corresponding to
17947 (ConvertNumericExplicit): Allow explicit conversions from
17948 the underlying type to enum type. This precisely follows the spec
17949 and closes a bug filed by Gonzalo.
17951 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17954 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
17956 2002-09-03 Miguel de Icaza <miguel@ximian.com>
17958 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
17959 it was important that we stored the right value after the
17960 reduction in `converted'.
17962 2002-09-04 Martin Baulig <martin@gnome.org>
17964 * location.cs (Location.SymbolDocument): Use full pathnames for the
17967 2002-08-30 Miguel de Icaza <miguel@ximian.com>
17969 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
17970 of the expression resolve mechanism, because that will catch the
17971 SimpleName error failures.
17973 (Conditional): If we can not resolve the
17974 expression, return, do not crash.
17976 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17979 (location): display token name instead of its number.
17981 2002-08-28 Martin Baulig <martin@gnome.org>
17983 * expression.cs (Binary.ResolveOperator): Don't silently return
17984 but return an error if an operator cannot be applied between two
17987 2002-08-28 Martin Baulig <martin@gnome.org>
17989 * class.cs (Constructor.Define): Set the permission attributes
17990 correctly instead of making all constructors public.
17992 2002-08-28 Martin Baulig <martin@gnome.org>
17994 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
17995 for private members before reporting a CS0103; if we find anything,
17998 2002-08-28 Martin Baulig <martin@gnome.org>
18000 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
18001 to check whether `closure_start_type == closure_invocation_type',
18002 we also need to check whether `m.DeclaringType == closure_invocation_type'
18003 before bypassing the permission checks. We might be accessing
18004 protected/private members from the base class.
18005 (TypeManager.RealMemberLookup): Only set private_ok if private
18006 members were requested via BindingFlags.NonPublic.
18008 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
18010 * expression.cs (MemberAccess.ResolveMemberAccess): Set
18011 MethodGroupExpr.IsExplicitImpl if appropriate.
18012 (Invocation.DoResolve): Don't report the CS0120 for explicit
18013 interface implementations.
18015 2002-08-27 Martin Baulig <martin@gnome.org>
18017 * expression.cs (Invocation.DoResolve): If this is a static
18018 method and we don't have an InstanceExpression, we must report
18021 2002-08-25 Martin Baulig <martin@gnome.org>
18023 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
18024 `==' between a valuetype and an object.
18026 2002-08-25 Miguel de Icaza <miguel@ximian.com>
18028 * ecore.cs (TypeExpr): Provide a ToString method.
18030 2002-08-24 Martin Baulig <martin@gnome.org>
18032 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
18033 now called proggie.dbg and it's a binary file.
18035 2002-08-23 Martin Baulig <martin@gnome.org>
18037 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
18039 2002-08-23 Martin Baulig <martin@gnome.org>
18041 * struct.cs (MyStructInfo.ctor): Make this work with empty
18042 structs; it's not allowed to use foreach() on null.
18044 2002-08-23 Martin Baulig <martin@gnome.org>
18046 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
18047 writer the full pathname of the generated assembly.
18049 2002-08-23 Martin Baulig <martin@gnome.org>
18051 * statements.cs (FlowBranching.UsageVector.MergeChildren):
18052 A `finally' block never returns or breaks; improved handling of
18055 2002-08-23 Martin Baulig <martin@gnome.org>
18057 * statement.cs (Throw.Resolve): Allow `throw null'.
18059 2002-08-23 Martin Baulig <martin@gnome.org>
18061 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
18062 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
18063 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
18064 MemberLookup would return a wrong event if this is an explicit
18065 interface implementation and the class has an event with the same
18068 2002-08-23 Martin Baulig <martin@gnome.org>
18070 * statement.cs (Block.AddChildVariableNames): New public method.
18071 (Block.AddChildVariableName): Likewise.
18072 (Block.IsVariableNameUsedInChildBlock): Likewise.
18073 (Block.AddVariable): Check whether a variable name has already
18074 been used in a child block.
18076 * cs-parser.jay (declare_local_variables): Mark all variable names
18077 from the current block as being used in a child block in the
18080 2002-08-23 Martin Baulig <martin@gnome.org>
18082 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
18083 find the symbol writer.
18085 * driver.cs: csc also allows the arguments to /define being
18086 separated by commas, not only by semicolons.
18088 2002-08-23 Martin Baulig <martin@gnome.org>
18090 * interface.cs (Interface.GetMembers): Added static check for events.
18092 2002-08-15 Martin Baulig <martin@gnome.org>
18094 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
18095 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
18097 * ecore.cs (Expression.MemberLookup): Added documentation and explained
18098 why the MethodData.EmitDestructor() change was necessary.
18100 2002-08-20 Martin Baulig <martin@gnome.org>
18102 * class.cs (TypeContainer.FindMembers): Added static check for events.
18104 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
18106 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
18107 use Type.GetEvents(), not Type.FindMembers().
18109 2002-08-20 Martin Baulig <martin@gnome.org>
18111 * decl.cs (MemberCache): Added a special method cache which will
18112 be used for method-only searched. This ensures that a method
18113 search will return a MethodInfo with the correct ReflectedType for
18116 2002-08-20 Martin Baulig <martin@gnome.org>
18118 * decl.cs (DeclSpace.FindMembers): Made this public.
18120 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18122 * delegate.cs: fixed build on windows.
18123 [FIXME: Filed as bug #29150: MCS must report these errors.]
18125 2002-08-19 Ravi Pratap <ravi@ximian.com>
18127 * ecore.cs (StandardConversionExists): Return a false
18128 if we are trying to convert the void type to anything else
18129 since that is not allowed.
18131 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
18132 we flag error 70 in the event an event is trying to be accessed
18133 directly from outside the declaring type.
18135 2002-08-20 Martin Baulig <martin@gnome.org>
18137 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
18138 MemberCache from typemanager.cs to decl.cs.
18140 2002-08-19 Martin Baulig <martin@gnome.org>
18142 * class.cs (TypeContainer): Implement IMemberContainer.
18143 (TypeContainer.DefineMembers): Create the MemberCache.
18144 (TypeContainer.FindMembers): Do better BindingFlags checking; only
18145 return public members if BindingFlags.Public was given, check
18146 whether members are static.
18148 2002-08-16 Martin Baulig <martin@gnome.org>
18150 * decl.cs (DeclSpace.Define): Splitted this in Define and
18151 DefineMembers. DefineMembers is called first and initializes the
18154 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
18155 DefineMembers() on all our DeclSpaces.
18157 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
18158 but call DefineMembers() on all nested interfaces. We call their
18159 Define() in our new Define() function.
18161 * interface.cs (Interface): Implement IMemberContainer.
18162 (Interface.Define): Moved all code except the attribute stuf to
18164 (Interface.DefineMembers): Initialize the member cache.
18166 * typemanager.cs (IMemberFinder): Removed this interface, we don't
18167 need this anymore since we can use MemberCache.FindMembers directly.
18169 2002-08-19 Martin Baulig <martin@gnome.org>
18171 * typemanager.cs (MemberCache): When creating the cache for an
18172 interface type, add all inherited members.
18173 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18174 to `out bool used_cache' and documented it.
18175 (TypeManager.MemberLookup): If we already used the cache in the first
18176 iteration, we don't need to do the interfaces check.
18178 2002-08-19 Martin Baulig <martin@gnome.org>
18180 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18181 here from IMemberFinder and don't implement this interface anymore.
18182 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18184 * typemanager.cs (IMemberFinder): This interface is now only used by
18185 classes which actually support the member cache.
18186 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18187 since we only put DeclSpaces into this Hashtable.
18188 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18189 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18191 2002-08-16 Martin Baulig <martin@gnome.org>
18193 * typemanager.cs (ICachingMemberFinder): Removed.
18194 (IMemberFinder.MemberCache): New property.
18195 (TypeManager.FindMembers): Merged this with RealFindMembers().
18196 This function will never be called from TypeManager.MemberLookup()
18197 so we can't use the cache here, just the IMemberFinder.
18198 (TypeManager.MemberLookup_FindMembers): Check whether the
18199 IMemberFinder has a MemberCache and call the cache's FindMembers
18201 (MemberCache): Rewrote larger parts of this yet another time and
18202 cleaned it up a bit.
18204 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18206 * driver.cs (LoadArgs): Support quoting.
18208 (Usage): Show the CSC-like command line arguments.
18210 Improved a few error messages.
18212 2002-08-15 Martin Baulig <martin@gnome.org>
18214 * typemanager.cs (IMemberContainer.Type): New property.
18215 (IMemberContainer.IsInterface): New property.
18217 The following changes are conditional to BROKEN_RUNTIME, which is
18218 defined at the top of the file.
18220 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18221 class'es members, but add all members from TypeHandle.ObjectType
18222 if we're an interface.
18223 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18224 is the current type.
18225 (MemberCache.CacheEntry.Container): Removed this field.
18226 (TypeHandle.GetMembers): Include inherited members.
18228 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18230 * typemanager.cs: fixed compilation and added a comment on a field that
18233 2002-08-15 Martin Baulig <martin@gnome.org>
18235 * class.cs (ConstructorInitializer.Resolve): In the
18236 Expression.MemberLookup call, use the queried_type as
18239 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18240 declared' attribute, it's always true.
18241 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18242 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18243 temporary wrapper for FindMembers which tells MemberLookup whether
18244 members from the base classes are included in the return value.
18245 This will go away soon.
18246 (TypeManager.MemberLookup): Use this temporary hack here; once the
18247 new MemberCache is completed, we don't need to do the DeclaredOnly
18248 looping here anymore since the MemberCache will take care of this.
18249 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18250 (MemberCache): When creating the MemberCache for a class, get
18251 members from the current class and all its base classes.
18252 (MemberCache.CacheEntry.Container): New field. This is a
18253 temporary hack until the Mono runtime is fixed to distinguish
18254 between ReflectedType and DeclaringType. It allows us to use MCS
18255 with both the MS runtime and the unfixed Mono runtime without
18256 problems and without accecting performance.
18257 (MemberCache.SearchMembers): The DeclaredOnly looping from
18258 TypeManager.MemberLookup is now done here.
18260 2002-08-14 Martin Baulig <martin@gnome.org>
18262 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18263 Type.GetFields on dynamic types but get the fields from the
18264 corresponding TypeContainer.
18265 (MyStructInfo.GetStructInfo): Added check for enum types.
18267 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18268 (MemberList.SyncRoot): Implemented.
18269 (TypeManager.FilterWithClosure): No need to check permissions if
18270 closure_start_type == closure_invocation_type, don't crash if
18271 closure_invocation_type is null.
18273 2002-08-13 Martin Baulig <martin@gnome.org>
18275 Rewrote TypeContainer.FindMembers to use a member cache. This
18276 gives us a speed increase of about 35% for the self-hosting MCS
18277 build and of about 15-20% for the class libs (both on GNU/Linux).
18279 * report.cs (Timer): New class to get enhanced profiling. This
18280 whole class is "TIMER" conditional since it remarkably slows down
18283 * class.cs (MemberList): New class. This is an IList wrapper
18284 which we're now using instead of passing MemberInfo[]'s around to
18285 avoid copying this array unnecessarily.
18286 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18287 (ICachingMemberFinder, IMemberContainer): New interface.
18288 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18289 has already been checked, otherwise use it for the name comparision.
18290 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18291 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18292 if possible. Returns a MemberList, not a MemberInfo [].
18293 (TypeHandle): New class, implements IMemberContainer. We create
18294 one instance of this class per type, it contains a MemberCache
18295 which is used to do the member lookups.
18296 (MemberCache): New class. Each instance of this class contains
18297 all members of a type and a name-based hash table.
18298 (MemberCache.FindMembers): This is our new member lookup
18299 function. First, it looks up all members of the requested name in
18300 the hash table. Then, it walks this list and sorts out all
18301 applicable members and returns them.
18303 2002-08-13 Martin Baulig <martin@gnome.org>
18305 In addition to a nice code cleanup, this gives us a performance
18306 increase of about 1.4% on GNU/Linux - not much, but it's already
18307 half a second for the self-hosting MCS compilation.
18309 * typemanager.cs (IMemberFinder): New interface. It is used by
18310 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18311 Enum, Delegate or Interface.
18312 (TypeManager.finder_to_member_finder): New PtrHashtable.
18313 (TypeManager.finder_to_container): Removed.
18314 (TypeManager.finder_to_delegate): Removed.
18315 (TypeManager.finder_to_interface): Removed.
18316 (TypeManager.finder_to_enum): Removed.
18318 * interface.cs (Interface): Implement IMemberFinder.
18320 * delegate.cs (Delegate): Implement IMemberFinder.
18322 * enum.cs (Enum): Implement IMemberFinder.
18324 * class.cs (TypeContainer): Implement IMemberFinder.
18326 2002-08-12 Martin Baulig <martin@gnome.org>
18328 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18330 2002-08-12 Martin Baulig <martin@gnome.org>
18332 * ecore.cs (ITypeExpression): New interface for expressions which
18334 (TypeExpression): Renamed to TypeLookupExpression.
18335 (Expression.DoResolve): If we're doing a types-only lookup, the
18336 expression must implement the ITypeExpression interface and we
18337 call DoResolveType() on it.
18338 (SimpleName): Implement the new ITypeExpression interface.
18339 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18340 hack, the situation that we're only looking up types can't happen
18341 anymore when this method is called. Moved the type lookup code to
18342 DoResolveType() and call it.
18343 (SimpleName.DoResolveType): This ITypeExpression interface method
18344 is now doing the types-only lookup.
18345 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18346 (ResolveFlags): Added MaskExprClass.
18348 * expression.cs (MemberAccess): Implement the ITypeExpression
18350 (MemberAccess.DoResolve): Added support for a types-only lookup
18351 when we're called via ITypeExpression.DoResolveType().
18352 (ComposedCast): Implement the ITypeExpression interface.
18354 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18355 Expression.Resolve() with ResolveFlags.Type instead.
18357 2002-08-12 Martin Baulig <martin@gnome.org>
18359 * interface.cs (Interface.Define): Apply attributes.
18361 * attribute.cs (Attribute.ApplyAttributes): Added support for
18362 interface attributes.
18364 2002-08-11 Martin Baulig <martin@gnome.org>
18366 * statement.cs (Block.Emit): Only check the "this" variable if we
18367 do not always throw an exception.
18369 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18370 whether the property has a set accessor.
18372 2002-08-11 Martin Baulig <martin@gnome.org>
18374 Added control flow analysis support for structs.
18376 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18377 with control flow analysis turned off.
18378 (IVariable): New interface.
18379 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18380 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18381 (FieldExpr.DoResolve): Resolve the instance expression with flow
18382 analysis turned off and do the definite assignment check after the
18383 resolving when we know what the expression will resolve to.
18385 * expression.cs (LocalVariableReference, ParameterReference):
18386 Implement the new IVariable interface, only call the flow analysis
18387 code if ec.DoFlowAnalysis is true.
18388 (This): Added constructor which takes a Block argument. Implement
18389 the new IVariable interface.
18390 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18391 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18392 This does the definite assignment checks for struct members.
18394 * class.cs (Constructor.Emit): If this is a non-static `struct'
18395 constructor which doesn't have any initializer, call
18396 Block.AddThisVariable() to tell the flow analysis code that all
18397 struct elements must be initialized before control returns from
18400 * statement.cs (MyStructInfo): New public class.
18401 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18402 argument to this indexer. If non-zero, check an individual struct
18403 member, not the whole struct.
18404 (FlowBranching.CheckOutParameters): Check struct members.
18405 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18406 overloaded versions of these methods which take an additional
18407 `int field_idx' argument to check struct members.
18408 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18409 overloaded versions of these methods which take an additional
18410 `string field_name' argument to check struct member.s
18411 (VariableInfo): Implement the IVariable interface.
18412 (VariableInfo.StructInfo): New public property. Returns the
18413 MyStructInfo instance of the variable if it's a struct or null.
18414 (Block.AddThisVariable): New public method. This is called from
18415 Constructor.Emit() for non-static `struct' constructor which do
18416 not have any initializer. It creates a special variable for the
18417 "this" instance variable which will be checked by the flow
18418 analysis code to ensure that all of the struct's fields are
18419 initialized before control returns from the constructor.
18420 (UsageVector): Added support for struct members. If a
18421 variable/parameter is a struct with N members, we reserve a slot
18422 in the usage vector for each member. A struct is considered fully
18423 initialized if either the struct itself (slot 0) or all its
18424 members are initialized.
18426 2002-08-08 Martin Baulig <martin@gnome.org>
18428 * driver.cs (Driver.MainDriver): Only report an error CS5001
18429 if there were no compilation errors.
18431 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18432 `UnsafeContext' property to determine whether the parent is in
18433 unsafe context rather than checking the parent's ModFlags:
18434 classes nested in an unsafe class are unsafe as well.
18436 2002-08-08 Martin Baulig <martin@gnome.org>
18438 * statement.cs (UsageVector.MergeChildren): Distinguish between
18439 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18440 we return. Added test17() and test18() to test-154.cs.
18442 2002-08-08 Martin Baulig <martin@gnome.org>
18444 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18445 Family access, make sure the invoking type isn't a subclass of the
18446 queried type (that'd be a CS1540).
18448 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18449 this method which takes an additional `Type invocation_type'.
18451 * expression.cs (BaseAccess.DoResolve): Use the base type as
18452 invocation and query type.
18453 (MemberAccess.DoResolve): If the lookup failed and we're about to
18454 report a CS0122, try a lookup with the ec.ContainerType - if this
18455 succeeds, we must report a CS1540.
18457 2002-08-08 Martin Baulig <martin@gnome.org>
18459 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18460 (MethodGroupExpr): Implement the IMemberExpr interface.
18462 * expression (MemberAccess.ResolveMemberAccess): No need to have
18463 any special code for MethodGroupExprs anymore, they're now
18466 2002-08-08 Martin Baulig <martin@gnome.org>
18468 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18469 Family, FamANDAssem and FamORAssem permissions.
18470 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18472 2002-08-08 Martin Baulig <martin@gnome.org>
18474 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18475 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18478 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18480 * driver.cs: implemented /resource option to embed managed resources.
18482 2002-08-07 Martin Baulig <martin@gnome.org>
18484 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18485 (FieldBase.HasFieldInitializer): New public property.
18486 (FieldBase.GetInitializerExpression): New public method. Resolves and
18487 returns the field initializer and makes sure it is only resolved once.
18488 (TypeContainer.EmitFieldInitializers): Call
18489 FieldBase.GetInitializerExpression to get the initializer, this ensures
18490 that it isn't resolved multiple times.
18492 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18493 the resolving process (SimpleName/MemberLookup) that we're currently
18494 emitting a field initializer (which must not access any instance members,
18495 this is an error CS0236).
18497 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18498 argument, if the `IsFieldInitializer' flag is set, we must report and
18499 error CS0236 and not an error CS0120.
18501 2002-08-07 Martin Baulig <martin@gnome.org>
18503 * ecore.cs (IMemberExpr): New public interface.
18504 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18505 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18506 if the expression is an IMemberExpr.
18508 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18509 to be null, implicitly default to `this' if we're non-static in
18510 this case. Simplified the code a lot by using the new IMemberExpr
18511 interface. Also fixed bug #28176 here.
18513 2002-08-06 Martin Baulig <martin@gnome.org>
18515 * cs-parser.jay (SimpleLookup): Removed. We need to create
18516 ParameterReferences during semantic analysis so that we can do a
18517 type-only search when resolving Cast, TypeOf and SizeOf.
18518 (block): Pass the `current_local_parameters' to the Block's
18521 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18522 argument to the constructor.
18523 (ConstructorInitializer.Resolve): Create a temporary implicit
18524 block with the parameters.
18526 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18527 references here if we aren't doing a type-only search.
18529 * statement.cs (Block): Added constructor which takes a
18530 `Parameters parameters' argument.
18531 (Block.Parameters): New public property.
18533 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18534 to `Parameters' and made it public readonly.
18536 2002-08-06 Martin Baulig <martin@gnome.org>
18538 * ecore.cs (Expression.Warning): Made this public as well.
18540 * report.cs (Report.Debug): Print the contents of collections.
18542 2002-08-06 Martin Baulig <martin@gnome.org>
18544 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18545 used to tell Resolve() which kinds of expressions it may return.
18546 (Expression.Resolve): Added overloaded version of this method which
18547 takes a `ResolveFlags flags' argument. This can be used to tell
18548 Resolve() which kinds of expressions it may return. Reports a
18550 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18551 ResolveFlags.SimpleName.
18552 (Expression.Error118): Added overloaded version of this method which
18553 takes a `ResolveFlags flags' argument. It uses the flags to determine
18554 which kinds of expressions are allowed.
18556 * expression.cs (Argument.ResolveMethodGroup): New public method.
18557 Resolves an argument, but allows a MethodGroup to be returned.
18558 This is used when invoking a delegate.
18560 * TODO: Updated a bit.
18562 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18564 Fixed compilation with csc.
18566 * ecore.cs: Expression.Error made public. Is this correct? Should
18567 Warning be made public too?
18569 * expression.cs: use ea.Location instead of ea.loc.
18570 [FIXME: Filed as bug #28607: MCS must report these errors.]
18572 2002-08-06 Martin Baulig <martin@gnome.org>
18574 * ecore.cs (Expression.loc): Moved the location here instead of
18575 duplicating it in all derived classes.
18576 (Expression.Location): New public property.
18577 (Expression.Error, Expression.Warning): Made them non-static and
18578 removed the location argument.
18579 (Expression.Warning): Added overloaded version which takes an
18580 `int level' argument.
18581 (Expression.Error118): Make this non-static and removed the
18582 expression and location arguments.
18583 (TypeExpr): Added location argument to the constructor.
18585 * expression.cs (StaticCallExpr): Added location argument to
18587 (Indirection, PointerArithmetic): Likewise.
18588 (CheckedExpr, UnCheckedExpr): Likewise.
18589 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18590 (StringPtr): Likewise.
18593 2002-08-05 Martin Baulig <martin@gnome.org>
18595 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18597 * assign.cs (Assign.DoResolve): Check whether the source
18598 expression is a value or variable.
18600 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18601 while resolving the corresponding blocks.
18603 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18604 an error, don't silently return null.
18606 * statement.cs (Block.AddVariable): Do the error reporting here
18607 and distinguish between CS0128 and CS0136.
18608 (Block.DoResolve): Report all unused labels (warning CS0164).
18609 (LabeledStatement): Pass the location to the constructor.
18610 (LabeledStatement.HasBeenReferenced): New property.
18611 (LabeledStatement.Resolve): Set it to true here.
18613 * statement.cs (Return.Emit): Return success even after reporting
18614 a type mismatch error (CS0126 or CS0127), this is what csc does and
18615 it avoids confusing the users with any consecutive errors.
18617 2002-08-05 Martin Baulig <martin@gnome.org>
18619 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18621 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18623 * expression.cs (MemberAccess.DoResolve): Silently return if an
18624 error has already been reported.
18626 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18627 error has already been reported.
18629 2002-08-05 Martin Baulig <martin@gnome.org>
18631 * statement.cs (UsageVector): Only initialize the `parameters'
18632 vector if we actually have any "out" parameters.
18634 2002-08-05 Martin Baulig <martin@gnome.org>
18636 * expression.cs (Binary.ResolveOperator): When combining delegates,
18637 they must have the same type.
18639 2002-08-05 Martin Baulig <martin@gnome.org>
18641 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18642 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18643 work with the ms runtime and we also don't need it: if we're a
18644 PropertyBuilder and not in the `indexer_arguments' hash, then we
18645 are a property and not an indexer.
18647 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18648 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18649 since the latter one doesn't work with the ms runtime.
18651 2002-08-03 Martin Baulig <martin@gnome.org>
18653 Fixed bugs #27998 and #22735.
18655 * class.cs (Method.IsOperator): New public field.
18656 (Method.CheckBase): Report CS0111 if there's already a method
18657 with the same parameters in the current class. Report CS0508 when
18658 attempting to change the return type of an inherited method.
18659 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18660 and it's not marked abstract or extern.
18661 (PropertyBase): New abstract base class for Property and Indexer.
18662 (PropertyBase.CheckBase): Moved here from Property and made it work
18664 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18665 the same so we can reuse it there.
18666 (Property, Indexer): Derive from PropertyBase.
18667 (MethodSignature.inheritable_property_signature_filter): New delegate
18668 to find properties and indexers.
18670 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18671 argument and improved error reporting.
18673 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18674 EmptyReadOnlyParameters and made it a property.
18676 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18677 version of this method which takes a `PropertyInfo indexer'.
18678 (TypeManager.RegisterIndexer): New method.
18680 * class.cs: Added myself as author of this file :-)
18682 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18684 * class.cs: fixed compilation on windoze.
18686 2002-08-03 Martin Baulig <martin@gnome.org>
18688 * interface.cs (Interface.GetInterfaceBases): Check whether all
18689 base interfaces are at least as accessible than the current one.
18691 * class.cs (TypeContainer.GetClassBases): Check whether base types
18692 are at least as accessible than the current type.
18693 (TypeContainer.AsAccessible): Implemented and made non-static.
18694 (MemberBase.CheckParameters): Report errors if the accessibility
18697 * delegate.cs (Delegate.Delegate): The default visibility is
18698 internal for top-level types and private for nested types.
18699 (Delegate.Define): Report errors if the accessibility checks fail.
18701 * enum.cs (Enum.Enum): The default visibility is internal for
18702 top-level types and private for nested types.
18703 (Enum.DefineType): Compute the correct visibility.
18705 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18706 function which takes a `bool is_toplevel' instead of a TypeContainer.
18708 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18711 2002-08-02 Martin Baulig <martin@gnome.org>
18713 * expression.cs (LocalVariableReferenc): Added constructor which
18714 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18715 (LocalVariableReference.IsReadOnly): New property.
18716 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18717 variable is readonly, use our own readonly flag to do this; you can
18718 use the new constructor to get a writable reference to a read-only
18721 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18722 reference to the local variable.
18724 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18726 * rootcontext.cs (ResolveCore): Also include System.Exception
18728 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18729 we reach an EmptyStatement.
18731 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18734 * expression.cs (Binary.ResolveOperator): Check error result in
18737 use brtrue/brfalse directly and avoid compares to null.
18739 2002-08-02 Martin Baulig <martin@gnome.org>
18741 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18742 Fixes bug #28407, added test-155.cs.
18744 2002-08-01 Martin Baulig <martin@gnome.org>
18746 * class.cs (Event.EmitDefaultMethod): Make this work with static
18747 events. Fixes #28311, added verify-3.cs.
18749 2002-08-01 Martin Baulig <martin@gnome.org>
18751 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18752 `is_disposable' fields.
18753 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18754 `hm.is_disposable' if we're using the collection pattern.
18755 (Foreach.EmitCollectionForeach): Use the correct type for the
18756 enumerator's local variable, only emit the try/finally block if
18757 necessary (fixes #27713).
18759 2002-08-01 Martin Baulig <martin@gnome.org>
18761 * ecore.cs (Expression.report118): Renamed to Error118 and made
18764 * statement.cs (Throw.Resolve): Check whether the expression is of
18765 the correct type (CS0118) and whether the type derives from
18766 System.Exception (CS0155).
18767 (Catch.Resolve): New method. Do the type lookup here and check
18768 whether it derives from System.Exception (CS0155).
18769 (Catch.CatchType, Catch.IsGeneral): New public properties.
18771 * typemanager.cs (TypeManager.exception_type): Added.
18773 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18775 * driver.cs: Updated About function.
18777 2002-07-31 Martin Baulig <martin@gnome.org>
18779 Implemented Control Flow Analysis.
18781 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18782 (EmitContext.CurrentBranching): Added.
18783 (EmitContext.StartFlowBranching): Added.
18784 (EmitContext.EndFlowBranching): Added.
18785 (EmitContext.KillFlowBranching): Added.
18786 (EmitContext.IsVariableAssigned): Added.
18787 (EmitContext.SetVariableAssigned): Added.
18788 (EmitContext.IsParameterAssigned): Added.
18789 (EmitContext.SetParameterAssigned): Added.
18790 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
18791 Added control flow analysis stuff here.
18793 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
18794 resolve the expression as lvalue.
18795 (LocalVariableReference.DoResolve): Check whether the variable has
18796 already been assigned.
18797 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
18798 the parameter as assigned here.
18799 (ParameterReference.DoResolve): Check whether the parameter has already
18801 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
18802 expression as lvalue.
18804 * statement.cs (FlowBranching): New class for the flow analysis code.
18805 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
18806 (LabeledStatement.IsDefined): New public property.
18807 (LabeledStatement.AddUsageVector): New public method to tell flow
18808 analyis that the label may be reached via a forward jump.
18809 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
18811 (VariableInfo.Number): New public field. This is used by flow analysis
18812 to number all locals of a block.
18813 (Block.CountVariables): New public property. This is the number of
18814 local variables in this block (including the locals from all parent
18816 (Block.EmitMeta): Number all the variables.
18818 * statement.cs: Added flow analysis support to all classes.
18820 2002-07-31 Martin Baulig <martin@gnome.org>
18822 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
18823 To get debugging messages, compile mcs with /define:MCS_DEBUG and
18824 then use this argument.
18826 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
18828 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
18829 use this to specify /define options.
18831 2002-07-29 Martin Baulig <martin@gnome.org>
18833 * statement.cs (Fixed): Moved all code that does variable lookups
18834 and resolvings from Emit to Resolve.
18836 * statement.cs (For): Moved all code that does variable lookups
18837 and resolvings from Emit to Resolve.
18839 * statement.cs (Using): Moved all code that does variable lookups
18840 and resolvings from Emit to Resolve.
18842 2002-07-29 Martin Baulig <martin@gnome.org>
18844 * attribute.cs (Attribute.Resolve): Explicitly catch a
18845 System.NullReferenceException when creating the
18846 CustromAttributeBuilder and report a different warning message.
18848 2002-07-29 Martin Baulig <martin@gnome.org>
18850 * support.cs (ParameterData.ParameterName): Added method to
18851 get the name of a parameter.
18853 * typemanager.cs (TypeManager.IsValueType): New public method.
18855 2002-07-29 Martin Baulig <martin@gnome.org>
18857 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
18858 is a flag which specifies that it's either ref or out.
18859 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
18860 the out parameter to `out Parameter.Modifier mod', also set the
18861 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
18863 * support.cs (InternalParameters.ParameterModifier): Distinguish
18864 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18865 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18867 * expression.cs (Argument.GetParameterModifier): Distinguish
18868 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18869 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18871 2002-07-29 Martin Baulig <martin@gnome.org>
18873 * expression.cs (ParameterReference.ParameterReference): Added
18874 `Location loc' argument to the constructor.
18876 * cs-parser.jay: Pass location to ParameterReference.
18878 2002-07-28 Miguel de Icaza <miguel@ximian.com>
18880 * statement.cs (Try): Initialize the location.
18882 * cs-parser.jay: pass location to Try.
18884 * expression.cs (Unary.Reduce): Change the prototype to return
18885 whether a constant fold could be performed or not. The result is
18886 returned in an out parameters. In the case of Indirection and
18887 AddressOf, we want to perform the full tests.
18889 2002-07-26 Miguel de Icaza <miguel@ximian.com>
18891 * statement.cs (Statement.Emit): Flag dead code.
18893 2002-07-27 Andrew Birkett <andy@nobugs.org>
18895 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
18897 2002-07-27 Martin Baulig <martin@gnome.org>
18899 * class.cs (MethodData.Define): Put back call to
18900 TypeManager.AddMethod(), accidentally commented this out.
18902 * report.cs (Debug): New public method to print debugging information,
18903 this is `[Conditional ("DEBUG")]'.
18905 2002-07-26 Martin Baulig <martin@gnome.org>
18907 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
18908 (switch_statement): Push the current_block to the switch_stack and
18909 pop it again when we're done with the switch.
18910 (switch_section): The new block is a child of the current_block.
18911 Fixes bug #24007, added test-152.cs.
18913 2002-07-27 Martin Baulig <martin@gnome.org>
18915 * expression.cs (Invocation.EmitArguments): When calling a varargs
18916 function with only its fixed arguments, we need to pass an empty
18919 2002-07-27 Martin Baulig <martin@gnome.org>
18921 Mono 0.13 has been released.
18923 2002-07-25 Miguel de Icaza <miguel@ximian.com>
18925 * driver.cs: Rename --resource to --linkres, because that is what
18926 we do currently, we dont support --resource yet.
18928 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
18930 2002-07-25 Martin Baulig <martin@gnome.org>
18932 * class.cs (MethodData): New public class. This is a `method builder'
18933 class for a method or one accessor of a Property/Indexer/Event.
18934 (MethodData.GetMethodFlags): Moved here from MemberBase.
18935 (MethodData.ApplyAttributes): Likewise.
18936 (MethodData.ApplyObsoleteAttribute): Likewise.
18937 (MethodData.ApplyConditionalAttribute): Likewise.
18938 (MethodData.ApplyDllImportAttribute): Likewise.
18939 (MethodData.CheckAbstractAndExternal): Likewise.
18940 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
18941 (MethodData.Emit): Formerly known as Method.Emit().
18942 (MemberBase): Moved everything which was specific to a single
18943 accessor/method to MethodData.
18944 (Method): Create a new MethodData and call Define() and Emit() on it.
18945 (Property, Indexer, Event): Create a new MethodData objects for each
18946 accessor and call Define() and Emit() on them.
18948 2002-07-25 Martin Baulig <martin@gnome.org>
18950 Made MethodCore derive from MemberBase to reuse the code from there.
18951 MemberBase now also checks for attributes.
18953 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
18954 (MemberBase.GetMethodFlags): Moved here from class Method and marked
18956 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
18957 `CallingConventions cc' and `Attributes opt_attrs' arguments.
18958 (MemberBase.ApplyAttributes): New virtual method; applies the
18959 attributes to a method or accessor.
18960 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
18961 (MemberBase.ApplyConditionalAttribute): Likewise.
18962 (MemberBase.ApplyDllImportAttribute): Likewise.
18963 (MemberBase.CheckAbstractAndExternal): Likewise.
18964 (MethodCore.ParameterTypes): This is now a property instead of a
18965 method, it's initialized from DoDefineParameters().
18966 (MethodCore.ParameterInfo): Removed the set accessor.
18967 (MethodCore.DoDefineParameters): New protected virtual method to
18968 initialize ParameterTypes and ParameterInfo.
18969 (Method.GetReturnType): We can now simply return the MemberType.
18970 (Method.GetMethodFlags): Override the MemberBase version and add
18971 the conditional flags.
18972 (Method.CheckBase): Moved some code from Define() here, call
18973 DoDefineParameters() here.
18974 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
18975 here to avoid some larger code duplication.
18976 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
18977 ensure that abstract and external accessors don't declare a body.
18979 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
18980 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
18981 lookup in the attribute's parent classes, so we need to abort as soon
18982 as we found the first match.
18983 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
18984 the attribute has no arguments.
18986 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
18989 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18991 * cs-parser.jay: reverted previous patch.
18993 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18995 * cs-parser.jay: fixed bug #22119.
18997 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18999 * attribute.cs: fixed compilation. The error was:
19000 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
19001 be assigned to before control leaves the current method."
19002 [FIXME: Filed as bug #28186: MCS must report this error.]
19004 2002-07-25 Martin Baulig <martin@gnome.org>
19006 * attribute.cs (Attribute.Conditional_GetConditionName): New static
19007 method to pull the condition name ouf of a Conditional attribute.
19008 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
19009 the obsolete message and error flag out of an Obsolete attribute.
19011 * class.cs (Method.GetMethodFlags): New public method to get the
19012 TypeManager.MethodFlags for this method.
19013 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
19015 (Method.Define): Get and apply the Obsolete and Conditional attributes;
19016 if we're overriding a virtual function, set the new private variable
19017 `parent_method'; call the new TypeManager.AddMethod().
19019 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19020 the MethodBuilder and the Method in a PtrHashtable.
19021 (TypeManager.builder_to_method): Added for this purpose.
19022 (TypeManager.MethodFlags): Added IsObsoleteError.
19023 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
19024 Obsolete and Conditional arguments in MethodBuilders. If we discover
19025 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
19026 the message from the attribute.
19028 2002-07-24 Martin Baulig <martin@gnome.org>
19030 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
19031 preprocessor directives, ensure that the argument to #define/#undef is
19032 exactly one identifier and that it's actually an identifier.
19034 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
19037 2002-07-24 Martin Baulig <martin@gnome.org>
19039 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
19040 initialize it to TypeManager.object_type in the constructor.
19041 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
19042 of the `hm.get_current' method if we're using the collection pattern.
19043 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
19044 for the explicit conversion to make it work when we're using the collection
19045 pattern and the `Current' property has a different return type than `object'.
19048 2002-07-24 Martin Baulig <martin@gnome.org>
19050 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
19051 does not match, but don't report any errors. This method is called in
19052 order for all methods in a MethodGroupExpr until a matching method is
19053 found, so we don't want to bail out if the first method doesn't match.
19054 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
19055 matches, report the 123. Fixes #28070.
19057 2002-07-24 Martin Baulig <martin@gnome.org>
19059 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
19060 TypeManager.TypeToCoreType() to the top of the method so the
19061 following equality checks will work. Fixes #28107.
19063 2002-07-24 Martin Baulig <martin@gnome.org>
19065 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
19066 operand is of type uint, and the other operand is of type sbyte,
19067 short or int, the operands are converted to type long." -
19068 Actually do what this comment already told us. Fixes bug #28106,
19071 2002-07-24 Martin Baulig <martin@gnome.org>
19073 * class.cs (MethodBase): New abstract class. This is now a base
19074 class for Property, Indexer and Event to avoid some code duplication
19075 in their Define() and DefineMethods() methods.
19076 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
19077 generic methods for Define() and DefineMethods().
19078 (FieldBase): Derive from MemberBase, not MemberCore.
19079 (Property): Derive from MemberBase, not MemberCore.
19080 (Property.DefineMethod): Moved all the code from this method to the
19081 new MethodBase.DefineAccessor(), just call it with appropriate
19083 (Property.Define): Call the new Property.DoDefine(), this does some
19084 sanity checks and we don't need to duplicate the code everywhere.
19085 (Event): Derive from MemberBase, not MemberCore.
19086 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
19087 accessors, this will also make them work with interface events.
19088 (Indexer): Derive from MemberBase, not MemberCore.
19089 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
19090 (Indexer.Define): Use the new MethodBase functions.
19092 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
19093 argument to the constructor.
19094 (Interface.FindMembers): Added support for interface events.
19095 (Interface.PopluateEvent): Implemented.
19097 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
19099 2002-07-22 Miguel de Icaza <miguel@ximian.com>
19101 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
19102 but this is required to check for a method name being the same as
19103 the containing class.
19107 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19109 * interface.cs: initialize variable.
19111 2002-07-23 Martin Baulig <martin@gnome.org>
19113 Implemented the IndexerName attribute in interfaces.
19115 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
19116 name if this is an explicit interface implementation.
19117 (Indexer.InterfaceIndexerName): New public variable. If we're
19118 implementing an interface indexer, this is the IndexerName in that
19119 interface. Otherwise, it's the IndexerName.
19120 (Indexer.DefineMethod): If we're implementing interface indexer,
19121 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
19122 and Pending.ImplementIndexer methods.
19123 (Indexer.Define): Also define the PropertyBuilder if we're
19124 implementing an interface indexer and this is neither an explicit
19125 interface implementation nor do the IndexerName match the one in
19128 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
19129 If a method is defined here, then we always need to create a proxy
19130 for it. This is used when implementing interface indexers.
19131 (Pending.IsInterfaceIndexer): New public method.
19132 (Pending.ImplementIndexer): New public method.
19133 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
19134 This is used when implementing interface indexers to define a proxy
19136 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
19137 define a proxy if necessary.
19139 * interface.cs (Interface.IndexerName): New public variable.
19140 (Interface.PopulateIndexer): Set the IndexerName.
19141 (Interface.DefineIndexers): New private method. Populate all the
19142 indexers and make sure their IndexerNames match.
19144 * typemanager.cs (IndexerPropertyName): Added support for interface
19147 2002-07-22 Martin Baulig <martin@gnome.org>
19149 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
19150 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
19151 ret if HasReturnLabel.
19152 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
19155 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
19156 and set the ec.LoopBeginTryCatchLevel.
19157 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
19158 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
19159 the current ec.TryCatchLevel, the branch goes out of an exception
19160 block. In this case, we need to use Leave and not Br.
19162 2002-07-22 Martin Baulig <martin@gnome.org>
19164 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
19165 block unless the block does not always return or it is contained in
19166 another try { ... } catch { ... } block. Fixes bug #26506.
19167 Added verify-1.cs to the test suite.
19169 2002-07-22 Martin Baulig <martin@gnome.org>
19171 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
19172 then we do not always return. Fixes bug #24985.
19174 2002-07-22 Martin Baulig <martin@gnome.org>
19176 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19177 lookup on a per-class level; ie. walk up the class hierarchy until we
19178 found at least one applicable method, then choose the best among them.
19179 Fixes bug #24463 and test-29.cs.
19181 2002-07-22 Martin Baulig <martin@gnome.org>
19183 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19184 return types of the methods. The return type is not part of the
19185 signature and we must not check it to make the `new' modifier work.
19186 Fixes bug #27999, also added test-147.cs.
19187 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19189 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19190 on the method's return type.
19192 2002-07-21 Martin Baulig <martin@gnome.org>
19194 * assign.cs: Make this work if the rightmost source is a constant and
19195 we need to do an implicit type conversion. Also adding a few more tests
19196 to test-38.cs which should have caught this.
19198 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19199 target in the makefile for this. The makefile.gnu is primarily intended
19200 for end-users who don't want to debug the compiler.
19202 2002-07-21 Martin Baulig <martin@gnome.org>
19204 * assign.cs: Improved the Assign class so it can now handle embedded
19205 assignments (X = Y = Z = something). As a side-effect this'll now also
19206 consume less local variables. test-38.cs now passes with MCS, added
19207 a few new test cases to that test.
19209 2002-07-20 Martin Baulig <martin@gnome.org>
19211 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19212 instructions. Fixes bug #27977, also added test-146.cs.
19214 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19216 * cs-tokenizer.cs: fixed getHex ().
19218 2002-07-19 Martin Baulig <martin@gnome.org>
19220 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19221 not Type.GetType() to lookup the array type. This is needed when
19222 we're constructing an array of a user-defined type.
19223 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19224 single-dimensional arrays, but also for single-dimensial arrays of
19227 2002-07-19 Martin Baulig <martin@gnome.org>
19229 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19230 this function is called, it's not allowed to share LocalBuilders
19231 among ILGenerators.
19233 2002-07-19 Martin Baulig <martin@gnome.org>
19235 * expression.cs (Argument.Resolve): Report an error 118 when trying
19236 to pass a type as argument.
19238 2002-07-18 Martin Baulig <martin@gnome.org>
19240 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19241 Conv_R_Un for the signed `long' type.
19243 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19245 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19246 `expr' for the temporary result, as that will fail if we do
19247 multiple resolves on the same expression.
19249 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19251 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19252 ec.TypeContainer for looking up aliases.
19254 * class.cs (TypeContainer): Remove LookupAlias from here.
19256 * decl.cs (DeclSpace); Move here.
19258 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19260 * class.cs (FindMembers): Only call filter if the constructor
19261 bulider is not null.
19263 Also handle delegates in `NestedTypes' now. Now we will perform
19264 type lookups using the standard resolution process. This also
19267 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19268 This uses Expressions (the limited kind that can be parsed by the
19269 tree) instead of strings.
19271 * expression.cs (ComposedCast.ToString): Implement, used to flag
19272 errors since now we have to render expressions.
19274 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19277 * ecore.cs (SimpleName.ToString): ditto.
19279 * cs-parser.jay: Instead of using strings to assemble types, use
19280 Expressions to assemble the type (using SimpleName, ComposedCast,
19281 MemberAccess). This should fix the type lookups in declarations,
19282 because we were using a different code path for this.
19284 * statement.cs (Block.Resolve): Continue processing statements
19285 even when there is an error.
19287 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19289 * class.cs (Event.Define): Also remove the `remove' method from
19290 the list of pending items.
19292 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19293 generate more compact code.
19295 2002-07-17 Martin Baulig <martin@gnome.org>
19297 * const.cs (Const.LookupConstantValue): Add support for constant
19298 `unchecked' and `checked' expressions.
19299 Also adding test case test-140.cs for this.
19301 2002-07-17 Martin Baulig <martin@gnome.org>
19303 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19304 check whether mi.ReturnType implements the IEnumerator interface; the
19305 `==' and the IsAssignableFrom() will fail in this situation.
19307 2002-07-16 Ravi Pratap <ravi@ximian.com>
19309 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19312 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19314 * expression.cs: fixed bug #27811.
19316 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19318 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19319 Molaro: when we are a ref, the value already contains a pointer
19320 value, do not take the address of it.
19322 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19323 * removed mb-parser.jay and mb-tokenizer.cs
19325 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19327 * expression.cs: check against the building corlib void type.
19329 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19331 * ecore.cs: fix for valuetype static readonly fields: when
19332 initializing them, we need their address, not the address of a copy.
19334 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19336 * typemanager.cs: register also enum_type in corlib.
19338 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19340 * class.cs: allow calling this (but not base) initializers in structs.
19342 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19344 * ecore.cs: make sure we compare against the building base types
19347 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19349 * typemanager.cs: fix TypeToCoreType() to handle void and object
19350 (corlib gets no more typerefs after this change).
19352 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19354 * expression.cs (ArrayCreation.EmitArrayArguments): use
19355 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19357 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19358 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19359 array indexes, the runtime actually forbids them.
19361 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19362 for array arguments here.
19364 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19365 instead of the default for ValueTypes.
19367 (New.DoEmit): Use IsValueType instead of
19368 IsSubclassOf (value_type)
19369 (New.DoResolve): ditto.
19370 (Invocation.EmitCall): ditto.
19372 * assign.cs (Assign): ditto.
19374 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19375 Statements *are* currently doing part of their resolution during
19378 Expressions do always resolve during resolve, but statements are
19379 only required to propagate resolution to their children.
19381 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19383 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19385 (LoadAssembly): Do not add the dll if it is already specified
19387 (MainDriver): Add the System directory to the link path at the end,
19388 after all the other -L arguments.
19390 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19391 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19392 ldelem.u1) and using the opposite for sbytes.
19394 This fixes Digger, and we can finally run it.
19396 * driver.cs (UnixParseOption): Move the option parsing here.
19397 (CSCParseOption): Implement CSC-like parsing of options.
19399 We now support both modes of operation, the old Unix way, and the
19400 new CSC-like way. This should help those who wanted to make cross
19401 platform makefiles.
19403 The only thing broken is that /r:, /reference: and /lib: are not
19404 implemented, because I want to make those have the same semantics
19405 as the CSC compiler has, and kill once and for all the confussion
19406 around this. Will be doing this tomorrow.
19408 * statement.cs (Unsafe.Resolve): The state is checked during
19409 resolve, not emit, so we have to set the flags for IsUnsfe here.
19411 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19413 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19414 not catch the Error_ObjectRefRequired in SimpleName (as it is
19415 possible to have a class/instance variable name that later gets
19416 deambiguated), we have to check this here.
19418 2002-07-10 Ravi Pratap <ravi@ximian.com>
19420 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19421 make static and put into Expression.
19423 (Event.Define): Register the private field of the event with the
19424 TypeManager so that GetFieldFromEvent can get at it.
19426 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19427 keep track of the private field associated with an event which
19430 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19433 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19435 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19437 * expression.cs (Binary.EmitBranchable): this routine emits the
19438 Binary expression in a branchable context. This basically means:
19439 we need to branch somewhere, not just get the value on the stack.
19441 This works together with Statement.EmitBoolExpression.
19443 * statement.cs (Statement.EmitBoolExpression): Use
19446 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19448 * statement.cs (For): Reduce the number of jumps in loops.
19450 (For): Implement loop inversion for the For statement.
19452 (Break): We can be breaking out of a Try/Catch controlled section
19453 (foreach might have an implicit try/catch clause), so we need to
19454 use Leave instead of Br.
19456 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19457 now). If the instace expression supports IMemoryLocation, we use
19458 the AddressOf method from the IMemoryLocation to extract the
19459 address instead of emitting the instance.
19461 This showed up with `This', as we were emitting the instance
19462 always (Emit) instead of the Address of This. Particularly
19463 interesting when This is a value type, as we dont want the Emit
19464 effect (which was to load the object).
19466 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19468 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19470 * statement.cs (Checked): Set the CheckedState during the resolve
19471 process too, as the ConvCast operations track the checked state on
19472 the resolve process, and not emit.
19474 * cs-parser.jay (namespace_member_declaration): Flag that we have
19475 found a declaration when we do. This is used to flag error 1529
19477 * driver.cs: Report ok when we display the help only.
19479 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19481 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19483 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19485 * cs-tokenizer.cs (define): We also have to track locally the
19486 defines. AllDefines is just used for the Conditional Attribute,
19487 but we also need the local defines for the current source code.
19489 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19491 * statement.cs (While, For, Do): These loops can exit through a
19492 Break statement, use this information to tell whether the
19493 statement is the last piece of code.
19495 (Break): Flag that we break.
19497 * codegen.cs (EmitContexts): New `Breaks' state variable.
19499 2002-07-03 Martin Baulig <martin@gnome.org>
19501 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19502 modifiers in method declarations in structs. Otherwise, you won't
19503 be able to override things like Object.Equals().
19505 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19507 * class.cs (Method, Property, Indexer): Do not allow the public
19508 modifier to be used in explicit interface implementations.
19510 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19511 override modifiers in method declarations in structs
19513 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19515 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19516 integer or real overflow, report an error
19518 2002-07-02 Martin Baulig <martin@gnome.org>
19520 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19521 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19522 to tell the runtime about our newly created System.Object and
19523 System.ValueType types.
19525 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19527 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19528 struct instead of Ldarg/Starg.
19530 2002-07-02 Martin Baulig <martin@gnome.org>
19532 * expression.cs (Indirection.Indirection): Call
19533 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19535 2002-07-02 Martin Baulig <martin@gnome.org>
19537 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19538 ValueType, call TypeManager.TypeToCoreType() on it.
19539 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19540 the OpCodes.Newarr argument.
19542 2002-07-02 Martin Baulig <martin@gnome.org>
19544 * expression.cs (Invocation.EmitCall): When compiling corlib,
19545 replace all calls to the system's System.Array type to calls to
19546 the newly created one.
19548 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19549 System.Array methods.
19550 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19551 from the system's System.Array type which must be replaced.
19553 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19555 * typemanager.cs: load unverifiable_code_ctor so we can build
19556 corlib using the correct type. Avoid using GetTypeCode() with
19558 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19559 TypeManager.object_type to allow building corlib.
19561 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19563 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19565 2002-07-01 Martin Baulig <martin@gnome.org>
19567 * class.cs: Make the last change actually work, we need to check
19568 whether `ifaces != null' to avoid a crash.
19570 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19572 * class.cs: when we build structs without fields that implement
19573 interfaces, we need to add the interfaces separately, since there is
19574 no API to both set the size and add the interfaces at type creation
19577 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19579 * expression.cs: the dimension arguments to the array constructors
19580 need to be converted if they are a long.
19582 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19584 * class.cs: don't emit ldarg.0 if there is no parent constructor
19585 (fixes showstopper for corlib).
19587 2002-06-29 Martin Baulig <martin@gnome.org>
19589 MCS now compiles corlib on GNU/Linux :-)
19591 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19592 ie. check for MethodImplOptions.InternalCall.
19594 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19595 and TypeManager.attribute_type are null, so we must explicitly check
19596 whether parent is not null to find out whether it's an attribute type.
19597 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19598 and SetBuilder, not only if the property is neither abstract nor external.
19599 This is necessary to set the MethodImplOptions on the accessor methods.
19600 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19601 SetBuilder, see Property.Emit().
19603 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19604 populate "System.Object", "System.ValueType" and "System.Attribute" since
19605 they've already been populated from BootCorlib_PopulateCoreTypes().
19607 2002-06-29 Martin Baulig <martin@gnome.org>
19609 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19610 is the NullLiteral, we also need to make sure that target_type is not
19613 2002-06-29 Martin Baulig <martin@gnome.org>
19615 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19616 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19617 before calling BootstrapCorlib_ResolveDelegate ().
19619 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19621 * statement.cs: fixed build-breaker. All tests passed ok.
19623 2002-06-27 Martin Baulig <martin@gnome.org>
19625 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19626 for System.Decimal when compiling corlib.
19628 2002-06-27 Martin Baulig <martin@gnome.org>
19630 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19631 switch blocks which contain nothing but a default clause.
19633 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19635 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19637 2002-06-27 Martin Baulig <martin@gnome.org>
19639 * ecore.cs (PropertyExpr.PropertyExpr): Call
19640 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19642 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19643 is already a TypeBuilder.
19645 2002-06-27 Martin Baulig <martin@gnome.org>
19647 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19648 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19649 the "from an array-type to System.Array" case. This makes it work
19650 when compiling corlib.
19652 2002-06-27 Martin Baulig <martin@gnome.org>
19654 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19655 non-static PropertyExpr, set its InstanceExpression. This makes
19656 the `ICollection.Count' property work in System/Array.cs.
19658 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19660 * driver.cs: Made error handling more consistent. Errors now
19661 tracked by Report class, so many methods which used to return int
19662 now return void. Main() now prints success/failure and
19663 errors/warnings message.
19665 Renamed '--probe' compiler argument to '--expect-error'. Removed
19666 the magic number return values (123 and 124). Now, if the
19667 expected error occurs, the compiler exits with success (exit value
19668 0). If the compilation completes without seeing that particular
19669 error, the compiler exits with failure (exit value 1). The
19670 makefile in mcs/errors has been changed to handle the new behaviour.
19672 * report.cs: Made 'expected error' number a property and renamed
19673 it from 'Probe' to 'ExpectedError'.
19675 * genericparser.cs: Removed error handling support, since it is
19676 now all done by Report class.
19678 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19679 class, so parse() no longer returns an int.
19681 * namespace.cs: Use Report.Error instead of GenericParser.error
19683 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19685 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19686 TypeContainer.AddOperator): At the front of the list put the
19687 explicit implementations, so they get resolved/defined first.
19689 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19691 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19692 interface type is implemented by this TypeContainer. Used during
19693 explicit interface implementation.
19695 (Property.Define, Indexer.Define, Method.Define): Validate that
19696 the given interface in the explicit implementation is one of the
19697 base classes for the containing type.
19699 Also if we are explicitly implementing an interface, but there is
19700 no match in the pending implementation table, report an error.
19702 (Property.Define): Only define the property if we are
19703 not explicitly implementing a property from an interface. Use the
19704 correct name also for those properties (the same CSC uses,
19705 although that is really not needed).
19707 (Property.Emit): Do not emit attributes for explicitly implemented
19708 properties, as there is no TypeBuilder.
19710 (Indexer.Emit): ditto.
19712 Hiding then means that we do not really *implement* a pending
19713 implementation, which makes code fail.
19715 2002-06-22 Martin Baulig <martin@gnome.org>
19717 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19718 the return value of Object.GetType(). [FIXME: we need to do this whenever
19719 we get a type back from the reflection library].
19721 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19723 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19725 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19727 * attribute.cs: Return null if we can not look up the type.
19729 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19730 the interface types found.
19732 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19733 interface types found.
19735 * typemanager.cs (GetInterfaces): Make this routine returns alll
19736 the interfaces and work around the lame differences between
19737 System.Type and System.Reflection.Emit.TypeBuilder in the results
19738 result for GetInterfaces.
19740 (ExpandInterfaces): Given an array of interface types, expand and
19741 eliminate repeated ocurrences of an interface. This expands in
19742 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19745 2002-06-21 Martin Baulig <martin@gnome.org>
19747 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19750 2002-06-21 Martin Baulig <martin@gnome.org>
19752 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19753 and called with one of the core types, return the corresponding typebuilder for
19756 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19759 2002-06-21 Martin Baulig <martin@gnome.org>
19761 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19762 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19763 (Expression.ConvertReferenceExplicit): Likewise.
19765 * expression.cs (ElementAccess.DoResolve): Likewise.
19766 (ElementAccess.DoResolveLValue): Likewise.
19768 2002-06-10 Martin Baulig <martin@gnome.org>
19770 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19771 add the "value" parameter to the parameter list.
19773 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19776 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19778 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19779 the argument to an int, uint, long or ulong, per the spec. Also
19780 catch negative constants in array creation.
19782 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
19784 * class.cs: do not allow the same interface to appear twice in
19785 the definition list.
19787 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
19789 * ecore.cs: don't use ldlen with System.Array.
19791 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
19793 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
19795 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
19797 * modifiers.cs: produce correct field attributes for protected
19798 internal. Easy fix so miguel can work on ther harder stuff:-)
19800 2002-06-18 Miguel de Icaza <miguel@ximian.com>
19802 * pending.cs: New file. Move the code from class.cs here.
19803 Support clearning the pending flag for all methods (when not doing
19804 explicit interface implementation).
19806 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
19808 * rootcontext.cs: added a couple more types needed to bootstrap.
19810 2002-06-17 Miguel de Icaza <miguel@ximian.com>
19812 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
19813 constructor in the type, instead of any constructor in the type
19814 hierarchy. Thanks to Paolo for finding this bug (it showed up as
19815 a bug in the Mono runtime when applying the params attribute).
19817 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19818 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
19820 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
19822 * expression.cs (Unary.ResolveOperator): Use TypeManager
19823 to resolve the type.
19825 2002-06-13 Ravi Pratap <ravi@ximian.com>
19827 * cs-parser.jay (enum_member_declaration): Pass in the attributes
19830 * enum.cs (AddEnumMember): Add support to store the attributes associated
19831 with each member too.
19833 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
19834 field builders too - this takes care of the enum member case.
19836 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
19838 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
19839 address-of operator on both value types and pointers.
19841 2002-06-10 Martin Baulig <martin@gnome.org>
19843 * interface.cs (Interface.PopulateIndexer): Add the indexer's
19844 PropertyBuilder to the `property_builders' list.
19846 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
19847 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
19848 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
19849 find any indexers which are inherited from an interface.
19851 2002-06-09 Martin Baulig <martin@gnome.org>
19853 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
19854 the same type as the constant if necessary. There's also a test-130.cs
19857 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
19859 * typemanager.cs (TypeManager.ChangeType): Previously known as
19860 Enum.ChangeEnumType().
19862 2002-06-09 Martin Baulig <martin@gnome.org>
19864 * expression.cs (Cast.TryReduce): Added support for consts.
19866 2002-06-08 Ravi Pratap <ravi@ximian.com>
19868 * class.cs (Accessor): Hold attributes information so we can pass
19871 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
19872 Modify to pass in attributes attached to the methods.
19874 (add_accessor_declaration, remove_accessor_declaration): Ditto.
19876 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
19877 to handle the Accessor kind :-)
19879 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
19881 2002-06-08 Martin Baulig <martin@gnome.org>
19883 * expression.cs (Unary.TryReduceNegative): Added support for
19886 2002-06-08 Martin Baulig <martin@gnome.org>
19888 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
19889 name can't be found in the `defined_names' - the caller will do a
19890 MemberLookup in this case and thus find methods in System.Enum
19891 such as Enum.IsDefined().
19893 2002-06-08 Martin Baulig <martin@gnome.org>
19895 * enum.cs (Enum.ChangeEnumType): This is a custom version of
19896 Convert.ChangeType() which works with TypeBuilder created types.
19897 (Enum.LookupEnumValue, Enum.Define): Use it here.
19899 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
19900 `TypeBuilder.BaseType != null' check.
19901 (TypeContainer.FindMembers): Only lookup parent members if we
19902 actually have a parent.
19903 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
19904 (ConstructorInitializer.Resolve): Likewise.
19906 * interface.cs (Interface.FindMembers): Added
19907 `TypeBuilder.BaseType != null' check.
19909 * rootcontext.cs (RootContext.ResolveCore): Added
19910 "System.Runtime.CompilerServices.IndexerNameAttribute" to
19911 classes_second_stage.
19913 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
19914 debug_type and trace_type when compiling with --nostdlib.
19916 2002-06-07 Martin Baulig <martin@gnome.org>
19918 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
19919 (AddField): Set it to true when adding a non-static field.
19920 (DefineType): Use `have_nonstatic_fields' to find out whether we
19921 have non-static fields, not `Fields != null'.
19923 2002-06-02 Miguel de Icaza <miguel@ximian.com>
19925 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
19926 dereferencing a null on the static-field code path)
19928 2002-05-30 Martin Baulig <martin@gnome.org>
19930 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
19931 to take command line arguments. Use reflection to call the new
19932 custom `Initialize' function on the symbol writer and pass it the
19933 command line arguments.
19935 * driver.cs (--debug-args): New command line argument to pass command
19936 line arguments to the symbol writer.
19938 2002-05-28 Miguel de Icaza <miguel@ximian.com>
19940 * assign.cs (DoResolve): Forgot to do the implicit conversion to
19941 the target type for indexers and properties. Thanks to Joe for
19944 2002-05-27 Miguel de Icaza <miguel@ximian.com>
19946 * typemanager.cs (MethodFlags): returns the method flags
19947 (Obsolete/ShouldIgnore) that control warning emission and whether
19948 the invocation should be made, or ignored.
19950 * expression.cs (Invocation.Emit): Remove previous hack, we should
19951 not do this on matching a base type, we should do this based on an attribute
19953 Only emit calls to System.Diagnostics.Debug and
19954 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
19955 on the command line.
19957 * rootcontext.cs: Global settings for tracing and debugging.
19959 * cs-tokenizer.cs (define): New utility function to track
19960 defines. Set the global settings for TRACE and DEBUG if found.
19962 2002-05-25 Ravi Pratap <ravi@ximian.com>
19964 * interface.cs (Populate*): Pass in the TypeContainer as well as
19965 the DeclSpace as parameters so that we can create EmitContexts and
19966 then use that to apply attributes etc.
19968 (PopulateMethod, PopulateEvent, PopulateProperty)
19969 (PopulateIndexer): Apply attributes everywhere.
19971 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
19974 (ApplyAttributes): Update accordingly.
19976 We now apply interface attributes for all members too.
19978 2002-05-26 Miguel de Icaza <miguel@ximian.com>
19980 * class.cs (Indexer.Define); Correctly check if we are explicit
19981 implementation (instead of checking the Name for a ".", we
19982 directly look up if the InterfaceType was specified).
19984 Delay the creation of the PropertyBuilder.
19986 Only create the PropertyBuilder if we are not an explicit
19987 interface implementation. This means that explicit interface
19988 implementation members do not participate in regular function
19989 lookups, and hence fixes another major ambiguity problem in
19990 overload resolution (that was the visible effect).
19992 (DefineMethod): Return whether we are doing an interface
19995 * typemanager.cs: Temporary hack until we get attributes in
19996 interfaces (Ravi is working on that) and we get IndexerName
19997 support in interfaces.
19999 * interface.cs: Register the indexers as properties.
20001 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
20002 warning, I have verified that this is a bug in the .NET runtime
20003 (JavaScript suffers of the same problem).
20005 * typemanager.cs (MemberLookup): When looking up members for
20006 interfaces, the parent of an interface is the implicit
20007 System.Object (so we succeed in searches of Object methods in an
20008 interface method invocation. Example: IEnumerable x; x.ToString
20011 2002-05-25 Miguel de Icaza <miguel@ximian.com>
20013 * class.cs (Event): Events should also register if they do
20014 implement the methods that an interface requires.
20016 * typemanager.cs (MemberLookup); use the new GetInterfaces
20019 (GetInterfaces): The code used to lookup interfaces for a type is
20020 used in more than one place, factor it here.
20022 * driver.cs: Track the errors at the bottom of the file, we kept
20025 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
20026 instance if the method we are calling is static!
20028 2002-05-24 Miguel de Icaza <miguel@ximian.com>
20030 * attribute.cs (ApplyAttributes): Make this function filter out
20031 the IndexerName attribute (as that attribute in reality is never
20032 applied) and return the string constant for the IndexerName
20035 * class.cs (TypeContainer.Emit): Validate that all the indexers
20036 have the same IndexerName attribute, and if so, set the
20037 DefaultName attribute on the class.
20039 * typemanager.cs: The return value might contain other stuff (not
20040 only methods). For instance, consider a method with an "Item"
20041 property and an Item method.
20043 * class.cs: If there is a problem with the parameter types,
20046 2002-05-24 Ravi Pratap <ravi@ximian.com>
20048 * ecore.cs (ImplicitConversionExists): Wrapper function which also
20049 looks at user defined conversion after making a call to
20050 StandardConversionExists - we need this for overload resolution.
20052 * expression.cs : Update accordingly the various method calls.
20054 This fixes 2 bugs filed against implicit user defined conversions
20056 2002-05-22 Miguel de Icaza <miguel@ximian.com>
20058 * statement.cs: Track the result of the assignment.
20060 2002-05-21 Miguel de Icaza <miguel@ximian.com>
20062 * expression.cs (MemberAccess): Improved error reporting for
20063 inaccessible members.
20065 2002-05-22 Martin Baulig <martin@gnome.org>
20067 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
20068 itself with debugging support.
20070 2002-05-22 Martin Baulig <martin@gnome.org>
20072 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
20073 Removed, this isn't needed anymore.
20075 2002-05-20 Martin Baulig <martin@gnome.org>
20077 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
20078 be underlying type for an enum.
20080 2002-05-20 Miguel de Icaza <miguel@ximian.com>
20082 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
20083 that splits out the loading of just the core types.
20085 * rootcontext.cs (ResolveCore): Split the struct resolution in
20086 two, so we can load the enumeration underlying types before any
20089 * expression.cs (Is): Bandaid until we fix properly Switch (see
20090 bug #24985 for details).
20092 * typemanager.cs (ImplementsInterface): The hashtable will contain
20093 a null if there are no interfaces implemented.
20095 2002-05-18 Miguel de Icaza <miguel@ximian.com>
20097 * cs-parser.jay (indexer_declarator): It is fine to have array
20100 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20102 * typemanager.cs: (RegisterBuilder): New function used to register
20103 TypeBuilders that implement interfaces. Since
20104 TypeBuilder.GetInterfaces (as usual) does not work with lame
20106 (AddUserType): register interfaces.
20108 (ImplementsInterface): Use the builder_to_ifaces hash if we are
20109 dealing with TypeBuilder. Also, arrays are showing up as
20110 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
20111 methods can not be invoked on them!
20113 * ecore.cs (ExplicitReferenceConversionExists): Made public.
20114 (ImplicitReferenceConversionExists): Split out from
20115 StandardConversionExists.
20117 * expression.cs (As): We were only implementing one of the three
20118 cases for the as operator. We now implement them all.
20119 (Is): Implement the various other cases for Is as well.
20121 * typemanager.cs (CACHE): New define used to control if we want or
20122 not the FindMembers cache. Seems to have a negative impact on
20123 performance currently
20125 (MemberLookup): Nested types have full acess to
20126 enclosing type members
20128 Remove code that coped with instance/static returns for events, we
20129 now catch this in RealFindMembers.
20131 (RealFindMembers): only perform static lookup if the instance
20132 lookup did not return a type or an event.
20134 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20136 * assign.cs (CompoundAssign): We pass more semantic information
20137 now to Compound Assignments than we did before: now we have all
20138 the information at hand, and now we resolve the target *before* we
20139 do the expression expansion, which allows the "CacheValue" method
20140 to have the effect we intended (before, a [x] += 1 would generate
20141 two differen ArrayAccess expressions from the ElementAccess,
20142 during the resolution process).
20144 (CompoundAssign.DoResolve): Resolve target and original_source here.
20146 2002-05-16 Miguel de Icaza <miguel@ximian.com>
20148 * expression.cs (ArrayAccess): dropped debugging information.
20150 * typemanager.cs: Small bug fix: I was always returning i_members,
20151 instead of one of i_members or s_members (depending on which had
20154 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
20155 method is invoked before any code generation takes place, and it
20156 is a mechanism to inform that the expression will be invoked more
20157 than once, and that the method should use temporary values to
20158 avoid having side effects
20160 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
20162 * ecore.cs (Expression.CacheTemporaries): Provide empty default
20165 * expression.cs (Indirection, ArrayAccess): Add support for
20166 CacheTemporaries in these two bad boys.
20168 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
20169 ldobj or ldind_ref.
20170 (StoreFromPtr): Handle stobj as well.
20172 * expression.cs (UnaryMutator): Share more code.
20174 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20175 down: I was not tracking the Filter function as well, which
20176 was affecting the results of the cache.
20178 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20180 * attribute.cs: Remove the hack to handle the CharSet property on
20183 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20185 * attribute.cs (DoResolve): More uglyness, we now only try to
20186 resolve the attribute partially, to extract the CharSet
20187 information (only if we are a StructLayout attribute). Otherwise
20189 (GetExtraTypeInfo): Add some code to conditionally kill in the
20190 future this. I am more and more convinced that the .NET
20191 framework has special code to handle the attribute setting on
20194 * expression.cs (IsParamsMethodApplicable): Revert my previous
20195 foreach change here, it was wrong.
20197 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20199 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20200 (pp_expr): do not abort on unknown input, just return.
20201 (eval): abort if there are pending chars.
20203 * attribute.cs (Attribute.Resolve): Positional parameters are
20204 optional. Deal with that case.
20206 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20207 the Ansi/Unicode/Auto information for the type.
20209 (TypeContainer.DefineType): instantiate the EmitContext here, as
20210 we will be using it during the type definition (to resolve
20211 attributes) and during the emit phase.
20213 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20214 to pull type information out of the attributes
20216 (Attribute.Resolve): track the constructor builder, and allow for
20217 multiple invocations (structs and classes will use this).
20219 * ecore.cs (MemberLookupFinal): new version with all the
20220 parameters customizable.
20222 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20223 constructors. Return if the result value is null (as the error
20224 would have been flagged already by MemberLookupFinal)
20226 Do not allow instances of abstract classes or interfaces to be
20229 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20230 We have to compare the assembly property here when dealing with
20231 FamANDAssem and Assembly access modifiers, because we might be
20232 creating an assembly from *modules* (that means that we are not
20233 getting TypeBuilders for types defined in other modules that are
20234 part of this assembly).
20236 (Method.Emit): If the method is marked abstract and has a body,
20239 (TypeContainer.DefineMembers): If both the defined member and the
20240 parent name match are methods, then do not emit any warnings: let
20241 the Method.Define routine take care of flagging warnings. But if
20242 there is a mismatch (method overrides something else, or method is
20243 overriwritten by something, then emit warning).
20245 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20246 set to null, this means `do not check for the return type on the
20249 (Method.Define): set the return type for the method signature to
20250 null, so that we get methods with the same name and parameters and
20251 different return types. This is used to flag warning 114 (you are
20252 hiding a method, and you probably want to use the new/override
20255 * typemanager.cs (MemberLookup): Implemented proper access
20256 control, closing a long standing set of bug reports. The problem
20257 was that the Framework only has two bits: Public and NonPublic,
20258 and NonPublic includes private and protected methods, but we need
20259 to enforce the FamANDAssem, FamOrAssem and Family.
20261 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20263 * statement.cs (GotoCase): Return true: Ammounts to giving up
20264 knowledge on whether we return or not, and letting the other case
20265 be responsible for it.
20267 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20269 * driver.cs: Do not load directories for each file processed, only
20270 do it if there is a pattern.
20272 * ecore.cs: Report readonly assigns here as well, as we might have
20273 been resolved only by MemberAccess.
20275 (SimpleName.SimpleNameResolve): Also be useful for LValue
20276 resolution. We need this to propagate assign to local readonly variables
20278 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20279 do not want to reuse potential criteria memory.
20281 * class.cs (MyEventBuilder): Set reflected_type;
20283 * ecore.cs (Constantify): Added support for constifying bools.
20285 (RootContext.LookupType): Added a cache for values looked up in
20286 the declaration space.
20288 * typemanager.cs (FindMembers): Now is a front-end to
20289 RealFindMembers, and provides a two-level hashtable-based cache to
20292 15% performance improvement: from 22.5 to 19.2 seconds.
20294 * expression.cs (IsParamsMethodApplicable): use foreach.
20295 (Invocation.DoResolve): ditto.
20296 (New.DoResolve): ditto.
20297 (ArrayCreation.DoResolve): ditto.
20299 * ecore.cs (FindMostEncompassingType): use foreach.
20301 * delegate.cs (NewDelegate.DoResolve): Use foreach
20303 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20304 (RemoveMethods): use foreach.
20306 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20307 nested foreach statements instead of for, and also break out of
20308 the inner loop once a match is found.
20310 (Invocation.OverloadResolve): Use foreach, simplify the code.
20312 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20314 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20315 we actually unwrap the expression to allow for extra information
20318 * expression.cs: Use Shr_Un on unsigned operations.
20320 2002-05-08 Ravi Pratap <ravi@ximian.com>
20322 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20323 applicable operators was not being considered correctly. This closes
20324 the bug Miguel reported.
20326 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20328 * attribute.cs: check that the type derives from System.Attribute
20329 and report the correct error in that case (moved the duplicate code to
20330 its own method, too).
20332 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20334 * attribute.cs: lookup attribute type name as the spec says: first the
20335 bare attribute name and then name + "Attribute" (nant compiles with
20336 mcs after this fix).
20338 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20340 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20341 Because of the way we parse things, we should try to see if a
20342 UIntConstant can fit in an integer.
20344 2002-05-07 Ravi Pratap <ravi@ximian.com>
20346 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20347 when we are in an explicit context.
20349 (ConvertReferenceExplicit): When converting from Iface type S to Class
20350 T make sure the rules are implemented as an OR.
20352 * parameter.cs (ParameterType): Make it a property for now although the
20353 purpose really isn't anything immediate.
20355 * expression.cs (Is*Applicable): Do better checking on the parameter type
20356 of a ref/out parameter. The ones from the system assemblies are already
20357 marked with the correct type so we don't need to do any correction.
20359 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20360 the object type is standard too so include that.
20362 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20364 * ecore.cs (StandardConversionExists): Augment with missing code:
20365 deal with IntConstant, LongConstants and Enumerations.
20367 * assign.cs: Report the error, instead of failing silently
20369 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20370 typecontainer that they are declared, because the
20371 typecontainer/namespace will have the list of using clauses that
20372 need to be applied.
20374 Assembly Attributes were escaping the normal registration
20377 (EmitCode): Apply attributes within an EmitContext that represents
20378 the container they were declared on.
20380 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20382 2002-05-06 Ravi Pratap <ravi@ximian.com>
20384 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20385 Revamp completely - make much cleaner as we now operate only
20388 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20389 to implement the logic detailed in the spec more correctly.
20391 (UserDefinedConversion): Update accordingly.
20393 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20395 * statement.cs: Return flow analysis information up.
20397 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20400 (token): Do not consume an extra character before calling
20403 2002-05-06 Piers Haken <piersh@friskit.com>
20405 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20407 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20409 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20410 EmitContext during the instance constructor initializer
20411 resolution, to stop access to instance variables.
20413 This is mandated by the spec, last paragraph of the `constructor
20414 initializers' section.
20416 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20418 * cs-parser.jay, class.cs (Accessor): new class used to represent
20419 an accessor (get or set). In the past we used `null' to represent
20420 a missing accessor. But this is ambiguous because there was no
20421 way to tell in abstract indexers/properties if one of them was
20424 Now there is a way of addressing that.
20426 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20427 instead of FindMembers.
20429 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20430 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20432 * attribute.cs: Treat indexers and properties as the same in terms
20433 of applying attributes
20435 * ecore.cs (FindMostEncompassedType): Use statically initialized
20436 EmptyExpressions()s like we do elsewhere to avoid creating useless
20437 objects (and we take this out of the tight loop).
20439 (GetConversionOperators): Move the code to extract the actual
20440 operators to a separate routine to clean things up.
20442 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20444 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20445 events are always registered FieldBuilders.
20447 * class.cs (FieldBase): New class shared by Fields
20449 * delegate.cs: If we are a toplevel delegate, use our full name.
20450 If we are a nested delegate, then only use our tail name.
20452 2002-05-02 Ravi Pratap <ravi@ximian.com>
20454 * expression.cs (IsApplicable): Ensure that we add the "&" to
20455 ref/out types before comparing it with the type of the argument.
20457 (IsParamsMethodApplicable): Ditto.
20459 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20462 * delegate.cs : Handle the case when we have more than one applicable
20463 method. Flag an error only when we finish checking all.
20465 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20467 * expression.cs: Add support for boolean static initializers.
20469 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20471 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20473 * parameter.cs (ComputeParameterTypes,
20474 ComputeAndDefineParameterTypes): Better error handling: now we
20475 clear the `types' cache if we fail during any of the type lookups.
20476 We also return the status code correctly to our caller
20478 * delegate.cs: If we fail to define a delegate, abort the extra
20481 * expression.cs (Binary.ResolveOperator): for
20482 operator==(object,object) and operator !=(object, object) we also
20483 have to verify that there is an implicit conversion from one to
20486 (ArrayAccess.DoResolve): Array Access can operate on
20489 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20491 * assign.cs (CompoundAssign): A new class used as a "flag" that
20492 the assignment actually is happening as part of a compound
20493 assignment operator.
20495 During compound assignment, a few new rules exist to enable things
20502 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20503 to the type of x) if y is implicitly convertible to the type of x,
20504 and the operator is a builtin operator and the return type of the
20505 operator is explicitly convertible to the type of x.
20507 * rootcontext.cs: Reset warning level to 2. 4 catches various
20508 "interesting" features in mcs, we must clean this up at some
20509 point, but currently am trying to kill other bugs ;-)
20511 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20512 in container classes as well.
20514 * expression.cs (Binary.ResolveOperator): Handle string case
20515 before anything else (as operator overloading does emit an error
20516 before doing anything else).
20518 This code could go away when we move to a table driven model, but
20519 i could not come up with a good plan last night.
20521 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20523 * typemanager.cs (CSharpName): reimplementation using regex.
20524 * class.cs: added null check for fields in Emit
20525 * rootcontext.cs: set warninglevel to 4
20527 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20529 * typemanager.cs (CSharpName): reimplemented with Lupus
20532 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20534 * statement.cs (If): correclty implement Resolve, because we were
20535 not catching sem errors in there. The same process is needed
20537 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20540 (Statement.Warning_DeadCodeFound): Factorize code.
20541 (While): Report dead code here too.
20543 (Statement): Added Resolve virtual method to allow
20544 for resolution split from the emit code.
20546 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20548 * statement.cs (EmitBoolExpression): No longer try to resolve the
20550 (MakeBoolean): New utility function that resolve, implicitly
20551 converts to boolean and tags the expression.
20554 (If, Do): Implement dead code elimination.
20555 (While): Implement loop inversion
20557 (Do, While, For, If): Resolve the expression prior to calling our
20560 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20563 - added method Report28 (warning: program has more than one entry point)
20564 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20565 - modified method Method.Define, the part at the end of the method
20567 * rootcontext.cs: added static public Location EntryPointLocation;
20569 * ../errors/cs0028.cs : Add test case for the above warning.
20572 - modified method CSharpName to allow arrays of primitive type to
20573 be printed nicely (e.g. instead of System.Int32[][] it now prints
20575 - added method CSharpSignature: returns the signature of a method
20576 in string format to be used in reporting errors, warnings, etc.
20578 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20581 2002-04-26 Ravi Pratap <ravi@ximian.com>
20583 * delegate.cs (Define): Fix extremely silly bug where I was
20584 setting the type of the 'object' parameter of the BeginInvoke
20585 method to System.IAsyncResult instead of System.Object ;-)
20587 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20589 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20592 (Constructor.Emit): return if we fail to initialize the
20593 constructor. Another door closed!
20595 * expression.cs (New.DoResolve): Improve error message (from -6 to
20596 1501). Use DeclaredOnly lookup to find the exact constructor.
20598 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20599 loop. This is useful.
20601 * cs-parser.jay: Adjust the default parameters so that destructors
20602 have the proper signature.
20604 2002-04-26 Martin Baulig <martin@gnome.org>
20606 * driver.cs (LoadAssembly): If `assembly' contains any characters
20607 which are only valid in path names and not in assembly names
20608 (currently slash, backslash and point), use Assembly.LoadFrom ()
20609 instead of Assembly.Load () on the `assembly' (before iteration
20610 over the link_paths).
20612 2002-04-26 Martin Baulig <martin@gnome.org>
20614 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20616 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20618 * class.cs (Property): use the new typemanager.MemberLookup
20620 (TypeContainer.MemberLookup): Implement using the
20621 TypeManager.MemberLookup now.
20623 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20624 and return MemberInfos, so that these can be used without an
20625 EmitContext (what we had before).
20627 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20629 * expression.cs: Fix the case where the argument to params if the
20630 type of the params. I omitted handling this before. Fixed
20632 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20634 * driver.cs: Call BootCorlib_PopulateCoreType
20636 * class.cs (Property.CheckBase): Check for properties only, not
20639 * interface.cs: Temporary hack: try/catch around the
20640 CustomAttributeBuilder, because I am getting an exception that I
20643 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20644 types whose definitions are required to be there (attributes are
20645 defined before standard types).
20647 Compute definitions as we boot the various types, as they are used
20648 immediately (value_type class will need object_type, but if we do
20649 not initialize object_type, we will pass a null, which will let
20650 the runtime pick the System.Object from the existing corlib, which
20651 is not what we want).
20653 2002-04-22 Patrik Torstensson <totte@labs2.com>
20655 * cs-tokenizer.cs: fixed a number of trim() issues.
20657 2002-04-22 Ravi Pratap <ravi@ximian.com>
20659 * expression.cs (Argument.Type): Ensure that we return the correct
20660 type when we have out or ref parameters [in which case we
20663 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20665 * class.cs (Property, Indexer): Allow extern modifier in there.
20667 * typemanager.cs (InitBaseTypes): Initializes object_type and
20668 value_type, since those will be used early on during the bootstrap
20669 process to compile corlib.
20671 (InitCoreTypes): Move code from here to InitBaseTypes.
20673 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20675 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20676 single-dimension arrays as using the ldlen opcode.
20678 Daniel Lewis discovered this optimization.
20680 * typemanager.cs: Add signature for System.Array::get_Length
20682 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20684 * statement.cs: report the error when the foreach does not apply to an
20685 array nor a collection.
20687 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20689 * expression.cs: Add implicit conversions to the operator ~.
20691 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20693 * typemanager.cs: Locate the decimal constructor.
20695 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20697 * attribute.cs: use the new property of TypeOf.
20698 * expression.cs: added 'get' property around typearg.
20700 These changes fix a build breaker reported by NickD. Is this the
20701 correct way to fix? If not, please, revert my changes and make it
20704 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20706 * attribute.cs: Add support for typeof in attribute invocations.
20707 I am not sure that this is right though.
20709 2002-04-14 Duncan Mak <duncan@ximian.com>
20711 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20712 Binary.Operator.Division case.
20714 2002-04-13 Ravi Pratap <ravi@ximian.com>
20716 * class.cs (DefineType): Ensure that we do a proper check on
20717 attribute types and also register it with the TypeManager.
20719 (TypeContainer.Targets): The default for attribute types is
20720 AttributeTargets.All.
20722 * attribute.cs (ApplyAttributes): Registering the attribute type
20723 is done elsewhere, not when we discover we have a Usage attribute.
20725 2002-04-12 Ravi Pratap <ravi@ximian.com>
20727 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20728 and get rid of is_delegate parameter.
20730 * everywhere : update.
20732 2002-04-12 Ravi Pratap <ravi@ximian.com>
20734 * cs-parser.jay (compilation_unit): Revamp completely to use
20735 some new ideas that I got from Rhys' grammar to solve the problems
20736 with assembly level attributes.
20738 (outer_declaration): New grammar production.
20740 (attribute_sections): Add.
20742 (opt_attributes): Base on attribute_sections
20744 (namespace_declaration): Allow opt_attributes to tackle the case
20745 when we have assembly level attributes - we are clever in this
20748 * attribute.cs (ApplyAttributes): Do not worry about assembly
20749 attributes in the non-global context.
20751 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20752 instead of SetGlobalAttributes.
20754 * class.cs, rootcontext.cs : Ensure we define and generate
20755 attribute types before anything else.
20757 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20758 and flag the new error -20 for the case when the attribute type
20759 does not have valid targets specified. csc does not catch this.
20761 * ../errors/errors.txt : update for error # -20
20763 2002-04-11 Ravi Pratap <ravi@ximian.com>
20765 * support.cs (InternalParameters.ParameterModifier): Do some null
20766 checking and return sane values.
20768 * class.cs (Method.Define): If we are a PInvoke method, ensure
20769 that we are static and extern. Report error # 601
20771 * ../errors/cs0601.cs : Add test case for the above error.
20773 2002-04-07 Ravi Pratap <ravi@ximian.com>
20775 * rootcontext.cs (attribute_types): We need to keep type of
20776 all attribute types separately and emit code for them first.
20778 (RegisterAttribute) : Implement.
20780 * class.cs (DefineType): Check if the current Type is a custom
20781 attribute type and register it accordingly.
20783 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
20784 adding the first attribute twice and rename to
20786 (SetGlobalAttributes): this.
20788 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
20791 * attribute.cs (ApplyAttributes): Take an additional argument telling us
20792 if we are processing global arguments. Hmm, I am unsure of this.
20794 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20796 * expression.cs: added static array of strings to avoid calling
20797 Enum.ToString () for Operator in Binary. Significant recover of
20800 2002-04-10 Miguel de Icaza <miguel@ximian.com>
20802 * class.cs (FindMembers): Allow the Builders of the various
20803 members to be null. If they are skip them. This only happens
20804 during the PInvoke declaration.
20806 2002-04-09 Miguel de Icaza <miguel@ximian.com>
20808 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
20809 failure, so we do not keep going afterwards.
20811 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
20812 wanted to pass `false' as the `is_delegate' argument. If this is
20813 the case, why not use delegate_type == null to mean `is_delegate =
20814 false' and anything else as is_delegate = true.
20816 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
20818 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
20819 code for the section, not the beginning of the tests.
20821 2002-04-08 Miguel de Icaza <miguel@ximian.com>
20823 * cfold.cs: Handle operator + (Enum x, Underlying x)
20825 * expression.cs (Binary): same. Warn about errors where we have
20826 Enum/Enum in operator + as well.
20828 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
20831 - added support for switch(bool)
20832 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
20833 - add TableSwitchEmit() to handle table-based switch statements
20835 2002-04-05 Ravi Pratap <ravi@ximian.com>
20837 * expression.cs (Invocation.OverloadResolve): Factor out code which
20838 does parameter compatibility checking with arguments so that we can
20839 re-use the code even from Delegate.VerifyApplicability
20841 (VerifyArgumentsCompat): Move above code here.
20843 * delegate.cs (VerifyApplicability): Get rid of duplicate code
20844 and instead make a call to the above method.
20846 2002-03-31 Ravi Pratap <ravi@ximian.com>
20848 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
20849 We use it to keep track of classes which are attribute types.
20851 2002-04-02 Miguel de Icaza <miguel@ximian.com>
20853 * delegate.cs (Delegate.Define): Correctly define the types in the
20854 presence of fixed and array parameters.
20856 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
20859 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
20860 include NonPublic after the first iteration.
20862 * class.cs (Indexer.CheckBase): Only check if both parents are
20865 * cs-parser.jay (accessor_body): If empty, set to null.
20867 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
20868 same code path here to resolve constants names that we did have in
20869 MemberAccess.DoResolve. There is too much code duplicated here.
20871 2002-04-01 Miguel de Icaza <miguel@ximian.com>
20873 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
20875 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
20878 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
20879 tokens, numbers and strings.
20881 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
20884 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
20885 asyncronous parameters and the regular parameters.
20887 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
20888 specify the target directory.
20890 * expression.cs: (This.DoResolve): Simplify
20891 (As.Emit): Optimize, do not generate IsInst if the expression is
20892 always of the given type.
20894 (Is.DoResolve): Bug fix, we were reporting both always/never for
20897 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
20898 creating too many unnecessary arrays.
20900 2002-03-31 Miguel de Icaza <miguel@ximian.com>
20902 * class.cs (EmitFieldInitializer): Use Assign expression to assign
20903 fields instead of rolling our own initializer. Takes care of all
20904 implicit conversions, and drops unnecessary static checks/argument.
20906 2002-03-31 Dick Porter <dick@ximian.com>
20908 * driver.cs: use the GetDirectories() return values properly, and
20909 use "/" as path separator.
20911 2002-03-30 Miguel de Icaza <miguel@ximian.com>
20913 * expression.cs (Unary): Optimize - - expr into expr.
20914 (Binary): Optimize a + (-b) into a -b.
20916 * codegen.cs (CodeGen): Made all methods static.
20918 2002-03-29 Miguel de Icaza <miguel@ximian.com>
20922 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
20923 TypeBuilder property.
20925 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
20928 * tree.cs: Removed the various RecordXXXX, and replaced with a
20929 single RecordDecl. Removed all the accessor methods, and just
20930 left a single access point Type
20932 * enum.cs: Rename DefineEnum to DefineType.
20934 * decl.cs: New abstract method `DefineType' used to unify the
20935 Defines for Enumerations, Interfaces, TypeContainers and
20938 (FindType): Moved LookupInterfaceOrClass here. Moved the
20939 LookupBaseClasses method that used to live in class.cs and
20940 interface.cs here, and renamed to FindType.
20942 * delegate.cs: Implement DefineType. Take advantage of the
20943 refactored pattern for locating the parent builder without taking
20944 the parent_builder argument (which we know does not work if we are
20945 nested, and triggering a toplevel definition).
20947 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20949 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
20950 accessibility of a member has changed during override and report
20953 * class.cs (Method.Define, Property.Define): Only complain on
20954 overrides if the method is private, any other accessibility is
20955 fine (and since we just checked the permission is the same, we are
20958 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
20959 and elif are processed always. The other pre-processing
20960 directives are only processed if we are "taking" the path
20962 2002-03-29 Martin Baulig <martin@gnome.org>
20964 * class.cs (Method.Emit): Only emit symbolic debugging info if the
20965 current location is not Null.
20967 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
20968 a separate method so we can profile it.
20970 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
20971 `span.Seconds' are just seconds, but no minutes or hours.
20972 (MainDriver): Profile the CodeGen.SaveSymbols calls.
20974 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20976 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
20977 Remove the gratuitous set of Final:
20979 // If an interface implementation, then we can set Final.
20980 if (((flags & MethodAttributes.Abstract) == 0) &&
20981 implementing.DeclaringType.IsInterface)
20982 flags |= MethodAttributes.Final;
20984 I do not know what I was smoking when I used that.
20987 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
20988 step into fixing the name resolution issues for delegates and
20989 unifying the toplevel name resolution.
20991 2002-03-28 Martin Baulig <martin@gnome.org>
20993 * class.cs (Method.Emit): If we have a symbol writer, call its
20994 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
20995 tell it about the current method.
20997 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
20998 writer that we're going to emit the first byte of IL code for a new
20999 statement (a new source line).
21000 (EmitContext.EmitTopBlock): If we have a symbol writer, call
21001 EmitContext.Mark() before emitting any code.
21003 * location.cs (SymbolDocument): Return null when we're Null.
21005 * statement.cs (Statement): Moved the `Location loc' variable here.
21006 (Statement.EmitBoolExpression): If we have a symbol writer, call
21007 ec.Mark() before emitting any code to tell it that we're at the
21008 beginning of a new statement.
21009 (StatementExpression): Added `Location' argument to the constructor.
21010 (Block): Added public readonly variable `StartLocation' and public
21011 variable `EndLocation'. The latter is to be set using SetEndLocation().
21012 (Block): Added constructor which takes a start and end location.
21013 (Block.SetEndLocation): New method. This sets the end location.
21014 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
21015 local variables we create.
21016 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
21017 each statement and do also mark the begin and end of the block.
21019 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21020 tell it the current lexer.Location, use Location.Null for the end of the
21022 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
21023 current block, set its end location using SetEndLocation().
21024 (statement_expression): StatementExpression constructor now takes the
21025 lexer.Location as additional argument.
21026 (for_statement, declare_local_variables): Likewise.
21027 (declare_local_variables): When creating a new implicit block, use the
21028 new Block constructor and pass it the lexer.Location.
21030 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21032 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
21033 members also on the parent interfaces recursively.
21035 2002-03-27 Miguel de Icaza <miguel@ximian.com>
21037 * report.cs: Use new formats, since Gonzalo finished the missing
21040 * expression.cs (Binary.ResolveOperator): added missing operator|
21041 operator& and operator^ for bool/bool.
21043 * cs-parser.jay: CheckDef now takes a Location argument that is
21044 used to report errors more precisly (instead of reporting the end
21045 of a definition, we try to track something which is a lot closer
21046 to the source of the problem).
21048 * cs-tokenizer.cs: Track global token use, so we can properly flag
21049 the use of #define/#undef after the first token has been seen.
21051 Also, rename the reportXXXX to Error_DescriptiveName
21053 * decl.cs (DeclSpace.IsTopLevel): Move property here from
21054 TypeContainer, so that Enum and Interface can use this too.
21056 * class.cs (TypeContainer.LookupInterfaceOrClass,
21057 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
21058 `builder' argument. Typically this was used to pass the parent
21059 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
21062 The problem is that a nested class could trigger the definition of
21063 a toplevel class, and the builder would be obviously wrong in that
21066 So we drop this argument, and we compute dynamically the
21067 TypeBuilder/ModuleBuilder (the correct information was available
21068 to us anyways from DeclSpace.Parent)
21070 * interface.cs (Interface.DefineInterface): Drop builder
21071 parameter cleanup like class.cs
21073 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
21076 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
21079 (Try.Emit): Propagate the returns value from the statement.
21081 (Return.Emit): Even if we are leavning
21083 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
21085 * modifiers.cs: Fix the computation of MethodAttributes flags.
21087 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
21089 * driver.cs: allow compilation of files that start with '/'.
21090 Add a default case when checking the argument of --target.
21092 2002-03-25 Miguel de Icaza <miguel@ximian.com>
21094 * interface.cs: Implement the same search algorithm for types in
21095 the interface code.
21097 * delegate.cs: Do not allow multiple definition.
21099 * Recovered ChangeLog that got accidentally amputated
21101 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
21103 * rootcontext.cs: Load manually enum to allow core classes to
21104 contain enumerations.
21106 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
21107 Update to new static methods in TypeManager.
21109 * typemanager.cs (GetMethod, GetConstructor): Use our
21110 implementation of FindMembers to find the members, since during
21111 corlib compilation, the types are TypeBuilders and GetMethod and
21112 GetConstructor do not work.
21114 Make all methods in TypeManager static.
21116 (InitCodeHelpers): Split the functionality from
21117 the InitCodeTypes function.
21119 * driver.cs: Call InitCodeHelpers after we have populated the
21122 * cs-parser.jay (delegate_declaration): we did not used to compute
21123 the delegate name correctly for void delegates.
21125 2002-03-24 Miguel de Icaza <miguel@ximian.com>
21127 * rootcontext.cs (RootContext): Init the interface_resolve_order
21128 and type_container_resolve_order always.
21130 (ResolveCore, BootstrapCorlib_ResolveClass,
21131 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
21132 compiler when compiling with --nostdlib
21134 * class.cs (TypeContainer.DefineType): Check that our parent is
21135 not null. This test is most important when we are bootstraping
21138 * codegen.cs: Split out the symbol writing code.
21140 2002-03-25 Martin Baulig <martin@gnome.org>
21142 * driver.cs (-g): Made -g an alias for --debug.
21144 2002-03-24 Martin Baulig <martin@gnome.org>
21146 * codegen.cs (SymbolWriter): New public variable. Returns the
21147 current symbol writer.
21148 (CodeGen): Added `bool want_debugging_support' argument to the
21149 constructor. If true, tell the ModuleBuild that we want debugging
21150 support and ask it for the ISymbolWriter.
21151 (Save): If we have a symbol writer, call it's Close() method after
21152 saving the assembly.
21154 * driver.c (--debug): New command line argument to create a
21155 debugger information file.
21157 * location.cs (SymbolDocument): New public property. Returns an
21158 ISymbolDocumentWriter object for the current source file or null
21159 if we don't have a symbol writer.
21161 2002-03-21 Miguel de Icaza <miguel@ximian.com>
21163 * driver.cs (LoadAssembly): Correctly return when all the paths
21164 have been tried and not before.
21166 * statement.cs (Switch.Emit): return the actual coverage for this
21167 statement (returns/not-returns)
21169 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
21170 switch of the statement if we are the last switch section. That
21171 kills two problems: try/catch problems (we used to emit an empty
21172 nop at the end) and switch statements where all branches would
21175 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21177 * driver.cs: Add default assemblies (the equivalent to the
21178 Microsoft CSC.RSP file)
21180 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21181 also update tokens_seen and set it to false.
21183 * driver.cs: Implement --recurse for Mike.
21185 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21186 correctly splitting out the paths.
21188 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21190 * interface.cs (Interface.PopulateProperty): Instead of using
21191 `parent' as the declaration space for the set parameters, use
21194 * support.cs (InternalParameters): InternalParameters constructor
21195 takes a DeclSpace instead of a TypeContainer.
21197 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21198 types are being initialized, load the address of it before calling
21201 (New): Provide a mechanism to disable the generation of local
21202 value type temporaries when the caller will be providing us with
21203 an address to store it.
21205 (ArrayCreation.EmitDynamicInitializers): Use it.
21207 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21209 * expression.cs (Invocation.EmitArguments): Only probe for array
21210 property if there is more than one argument. Sorry about that.
21212 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21213 empty param arrays.
21215 * class.cs (Method.LabelParameters): Fix incorrect code path that
21216 prevented the `ParamArrayAttribute' from being applied to the
21219 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21221 * support.cs (ReflectionParameters): Correctly compute whether the
21222 last argument is a params array. Fixes the problem with
21225 * typemanager.cs: Make the assemblies array always be non-null
21226 (empty, but non-null)
21228 * tree.cs (RecordDecl): New function that abstracts the recording
21229 of names. This reports error 101, and provides a pointer to the
21230 previous declaration. Fixes a crash in the compiler.
21232 * cs-parser.jay (constructor_declaration): Update to new grammar,
21233 and provide a constructor_body that can be empty.
21235 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21237 * driver.cs: Add support for --resources.
21239 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21240 Make all types for the various array helper methods be integer.
21242 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21243 CheckState to ConvCast.
21245 (ConvCast): Now it takes a `checked' state argument, to avoid
21246 depending on the emit context for the conversion, and just using
21247 the resolve time setting.
21249 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21250 instead of Invocation.EmitArguments. We do not emit the original
21251 arguments, instead we emit those which have been converted to
21252 unsigned int expressions.
21254 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21256 * codegen.cs: ditto.
21258 * expression.cs (LocalVariableReference): Drop the use of the
21259 Store function that depended on the variable index.
21261 * statement.cs (VariableInfo): Drop the `Idx' property from this
21262 class, as this is not taking into account the indexes for
21263 temporaries tat we generate during the execution, getting the
21266 * class.cs: First emit class initializers, then call the parent
21269 * expression.cs (Binary): Fix opcode emision.
21270 (UnaryMutator.EmitCode): Support checked code generation
21272 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21273 matches for events for both the Static and Instance scans,
21274 pointing to the same element. Fix that.
21276 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21278 * rootcontext.cs (ResolveTree): Always set the
21279 interface_resolve_order, because nested interfaces will be calling
21282 * class.cs (GetInterfaceOrClass): Track the same resolution
21283 process used by TypeManager.LookupType. This fixes the nested
21284 type lookups in class declarations (separate path from
21287 (TypeContainer.DefineType): Also define nested interfaces.
21288 (TypeContainer.RegisterOrder): New public function used to
21289 register the order in which child interfaces need to be closed.
21291 Nested interfaces need to be closed after their parents have been
21294 * interface.cs (InterfaceAttr): Put all the logic for computing
21295 the interface attribute here.
21297 (DefineInterface): Register our interface order with the
21298 RootContext or with the TypeContainer depending on the case.
21300 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21302 * cs-parser.jay: rework foreach statement to work with the new
21303 changes to the policy on SimpleNames.
21305 * report.cs: support Stacktrace on warnings as well.
21307 * makefile: drop --unsafe and /unsafe from the compile.
21309 2002-03-13 Ravi Pratap <ravi@ximian.com>
21311 * ecore.cs (StandardConversionExists): Modify to take an Expression
21312 as the first parameter. Ensure we do null -> reference type conversion
21315 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21316 temporary Expression objects.
21318 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21320 * interface.cs: workaround bug in method overloading resolution
21321 (there is already a bugzilla bug for it).
21323 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21325 We could also solve this problem by having a separate path for
21326 performing type lookups, instead of DoResolve, we could have a
21327 ResolveType entry point, and only participating pieces of the
21328 production (simplename, deref, array) would implement this.
21330 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21331 signal SimpleName to only resolve type names and not attempt to
21332 resolve anything else.
21334 * expression.cs (Cast): Set the flag.
21336 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21338 * class.cs: Only report 108 if there is no `new' modifier.
21340 * cs-parser.jay: rework foreach statement to work with the new
21341 changes to the policy on SimpleNames.
21343 * report.cs: support Stacktrace on warnings as well.
21345 * makefile: drop --unsafe and /unsafe from the compile.
21347 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21349 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21350 lookups here, instead of doing that at parse time. This means
21351 that our grammar will not introduce `LocalVariableReferences' as
21352 expressions at this point. That solves the problem of code like
21356 static void Main ()
21360 This is only half the fix. The full fix requires parameters to
21361 also be handled in this way.
21363 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21364 makes the use more obvious of the DeclSpace. The
21365 ec.TypeContainer.TypeBuilder is now only used to pull the
21366 TypeBuilder for it.
21368 My theory is that I can get rid of the TypeBuilder completely from
21369 the EmitContext, and have typecasts where it is used (from
21370 DeclSpace to where it matters).
21372 The only pending problem is that the code that implements Aliases
21373 is on TypeContainer, and probably should go in DeclSpace.
21375 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21376 lookups here, instead of doing that at parse time. This means
21377 that our grammar will not introduce `LocalVariableReferences' as
21378 expressions at this point. That solves the problem of code like
21382 static void Main ()
21386 This is only half the fix. The full fix requires parameters to
21387 also be handled in this way.
21389 * class.cs (Property.DefineMethod): When implementing an interface
21390 method, set newslot, when implementing an abstract method, do not
21391 set the flag (before we tried never setting it, or always setting
21392 it, which is the difference).
21393 (Indexer.DefineMethod): same.
21394 (Method.DefineMethod): same.
21396 * ecore.cs: Only set the status used flag if we get back a Field.
21398 * attribute.cs: Temporary hack, so Paolo can keep working.
21400 2002-03-08 Ravi Pratap <ravi@ximian.com>
21402 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21403 the unmanaged type in the case we have a MarshalAs attribute.
21405 (Resolve): Handle the case when we are parsing the special MarshalAs
21406 attribute [we need to store the unmanaged type to use later]
21408 * typemanager.cs (marshal_as_attr_type): Built in type for the
21409 MarshalAs Attribute.
21411 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21412 on parameters and accordingly set the marshalling info.
21414 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21416 * class.cs: Optimizing slightly by removing redundant code after
21417 we switched to the `NoTypes' return value.
21418 (Property.DefineMethod): use NoTypes here too.
21420 This fixes the bug I introduced in my last batch of changes.
21422 2002-03-05 Ravi Pratap <ravi@ximian.com>
21424 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21426 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21427 Enums since those are types too.
21429 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21431 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21432 thanks to a call during the lookup process.
21434 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21436 * statement.cs (Foreach): Lots of work to accomodate a particular
21437 kind of foreach statement that I had not kept in mind. It is
21438 possible to have foreachs on classes that provide a GetEnumerator
21439 method that return objects that implement the "pattern" for using
21440 a foreach, there is no need to support GetEnumerator
21443 This is needed to compile nant.
21445 * decl.cs: Only report 114 if the member is not `Finalize' and if
21446 the warning level is at least 2.
21448 * class.cs: Moved the compare function from Method to
21451 (MethodSignature.InheritableMemberSignatureCompare): Add new
21452 filter function that is used to extract inheritable methods from a
21455 (Method.Define): Use the new `inheritable_method_signature_filter'
21458 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21461 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21463 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21465 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21467 * expression.cs: Pass location information to
21468 ConvertImplicitStandard.
21470 * class.cs: Added debugging code to track return values from
21473 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21475 * expression.cs (Is.DoResolve): If either side of the `is' is an
21476 interface, do not flag the warning.
21478 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21481 * report.cs: Allow for --fatal to be used with --probe.
21483 * typemanager.cs (NoTypes): Move the definition for the empty Type
21486 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21488 (TypeContainer.DefineProxy): New function used to proxy to parent
21489 implementations when implementing interfaces.
21490 (TypeContainer.ParentImplements): used to lookup if our parent
21491 implements a public function that is required by an interface.
21492 (TypeContainer.VerifyPendingMethods): Hook this up.
21494 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21495 `modules' and `assemblies' arraylists into arrays. We only grow
21496 these are the very early start up of the program, so this improves
21497 the speedof LookupType (nicely measured).
21499 * expression.cs (MakeByteBlob): Replaced unsafe code with
21500 BitConverter, as suggested by Paolo.
21502 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21503 folding of string concatenation, but if either side is a string,
21504 and the other is not, then return null, and let the runtime use
21505 the concatenation on the string plus the object (using
21506 `Object.ToString').
21508 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21510 Constant Folding has been implemented now.
21512 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21513 the error instead on types that are not supported in one's
21516 * constant.cs (Constant and all children): New set of functions to
21517 perform implict and explicit conversions.
21519 * ecore.cs (EnumConstant): Implement the new functions to perform
21520 conversion by proxying to the child expression.
21522 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21523 own separate setting that can not be turned off from the command
21524 line using --unchecked or --checked and is only controlled using
21525 the checked/unchecked statements and expressions. This setting is
21526 used by the constant folder to flag errors.
21528 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21529 ConstantCheckState as well.
21531 During Resolve, they also have to flag the state, because the
21532 constant folder runs completely in the Resolve phase.
21534 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21537 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21539 * cfold.cs: New file, this file contains the constant folder.
21541 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21542 argument to track whether we are using the resulting address to
21543 load or store a value and provide better error messages.
21545 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21546 new AddressOf arguments.
21548 * statement.cs (Foreach.EmitCollectionForeach): Update
21550 * expression.cs (Argument.Emit): Call AddressOf with proper
21551 arguments to track usage.
21553 (New.DoEmit): Call AddressOf with new arguments.
21555 (Unary.Emit): Adjust AddressOf call.
21557 2002-03-01 Ravi Pratap <ravi@ximian.com>
21559 * cs-parser.jay (member_access): Change the case for pre-defined types
21560 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21563 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21566 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21567 essentially like methods and apply attributes like MethodImplOptions to them too.
21569 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21572 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21573 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21576 * Update code everywhere accordingly.
21578 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21580 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21582 2002-02-28 Ravi Pratap <ravi@ximian.com>
21584 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21585 try performing lookups against those instead of jumping straight into using
21586 the 'using' clauses.
21588 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21590 (LookupType): Perform lookups in implicit parents too.
21592 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21593 sequence as RootContext.LookupType.
21595 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21596 the various cases of namespace lookups into this method.
21598 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21600 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21601 in positional arguments)
21603 * class.cs (Operator): Update the AllowedModifiers to contain
21606 * cs-parser.jay: Update operator declaration to allow for the
21607 operator body to be empty.
21609 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21612 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21614 * class.cs (Method.Emit): Label parameters.
21616 * driver.cs: Return 1 or 0 as the program exit code.
21618 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21620 * expression.cs: Special case the `null' object when trying to
21621 auto-compute the type, as anything can be explicitly converted to
21624 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21625 spotting this Paolo.
21627 (Expression.ImplicitNumericConversion): Perform comparissions of
21628 the type using the underlying type in the case of an enumeration
21629 rather than using the enumeration type for the compare.
21631 Cope with the underlying == type case, which is not possible to
21634 (Expression.ConvertNumericExplicit): Perform comparissions of
21635 the type using the underlying type in the case of an enumeration
21636 rather than using the enumeration type for the compare.
21638 * driver.cs: If the user does not supply an extension, assume .exe
21640 * cs-parser.jay (if_statement): Rewrote so that we can track the
21641 location for the if statement.
21643 * expression.cs (Binary.ConstantFold): Only concat strings when
21644 the operation is "+", not everything ;-)
21646 * statement.cs (Statement.EmitBoolExpression): Take a location
21648 (If, While, Do): Track location.
21650 * expression.cs (Binary.ResolveOperator): In the object + string
21651 case, I was missing a call to ConvertImplicit
21653 2002-02-25 Ravi Pratap <ravi@ximian.com>
21655 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21656 Location arguments. Ensure we use RootContext.LookupType to do our work
21657 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21659 * interface.cs (PopulateMethod): Handle the type of the parameter being
21662 * expression.cs (Invocation.BetterFunction): Handle the case when we
21663 have a params method with no fixed arguments and a call is made with no
21666 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21668 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21669 the verbatim-string-literal
21671 * support.cs (InternalParameters.ParameterModifier): handle null
21673 (InternalParameters.ParameterType): ditto.
21675 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21676 duplicating the name of the variable parameter.
21677 (GetParameterByName): Fix bug where we were not looking up array
21678 paramters if they were the only present (thanks Paolo!).
21679 (GetParameterInfo): We only have an empty set of types if both
21680 fixed and array are set to null.
21681 (GetParameterInfo-idx): Handle FixedParameter == null
21683 * cs-parser.jay: Handle the case where there is no catch
21684 statements (missing null test).
21686 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21688 * driver.cs (MainDriver): Be conservative on our command line
21691 Catch DirectoryNotFoundException when calling GetFiles.
21693 (SplitPathAndPattern): Used to split the input specification into
21694 a path and a pattern that we can feed to Directory.GetFiles.
21696 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21698 * statement.cs (Fixed): Implement the last case of the Fixed
21699 statement (string handling).
21701 * expression.cs (StringPtr): New class used to return a char * to
21702 a string; Used by the Fixed statement.
21704 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21706 * expression.cs (Binary.ResolveOperator): Remove redundant
21707 MemberLookup pn parent type.
21708 Optimize union call, we do not need a union if the types are the same.
21709 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21712 Specialize the use of MemberLookup everywhere, instead of using
21713 the default settings.
21715 (StackAlloc): Implement stackalloc keyword.
21717 * cs-parser.jay: Add rule to parse stackalloc.
21719 * driver.cs: Handle /h, /help, /?
21721 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21722 before we supported unsafe code.
21724 * makefile: add --unsafe to the self compilation of mcs.
21726 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21728 * expression.cs (PointerArithmetic): New class that is used to
21729 perform pointer arithmetic.
21730 (Binary.Resolve): Handle pointer arithmetic
21731 Handle pointer comparission.
21732 (ArrayPtr): Utility expression class that is used to take the
21733 address of an array.
21735 (ElementAccess): Implement array access for pointers
21737 * statement.cs (Fixed): Implement fixed statement for arrays, we
21738 are missing one more case before we are done.
21740 * expression.cs (Indirection): Implement EmitAssign and set the
21741 ExprClass to Variable. This allows pointer dereferences to be
21742 treated as variables, and to have values assigned to them.
21744 * ecore.cs (Expression.StoreFromPtr): New utility function to
21745 store values dereferencing.
21747 2002-02-20 Ravi Pratap <ravi@ximian.com>
21749 * expression.cs (Binary.ResolveOperator): Ensure that we are
21750 not trying to operate on a void type - this fixes the reported
21753 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21754 the parent implementation is sealed.
21756 * ../errors/cs0239.cs : Add.
21758 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21760 * typemanager.cs (unverifiable_code_type): Corresponds to
21761 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21762 which have unsafe code in them.
21764 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21767 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21769 * cs-tokenizer.cs: Add support for @"litreal strings"
21771 Make tokenizer accept pre-processor directives
21772 on any column (remove the old C-like limitation).
21774 * rootcontext.cs (EmitCode): Emit any global attributes.
21775 (AddGlobalAttributes): Used to keep track of assembly attributes.
21777 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21779 * cs-parser.jay: Add support for global attributes.
21781 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21783 * expression.cs (Indirection): New helper class. Unary will
21784 create Indirection classes to be able to implement the
21785 IMemoryLocation interface on it.
21787 2002-02-16 Miguel de Icaza <miguel@ximian.com>
21789 * cs-parser.jay (fixed_statement): reference the right statement.
21791 * statement.cs (Fixed.Emit): Finish implementing the fixed
21792 statement for the &x case.
21794 2002-02-14 Miguel de Icaza <miguel@ximian.com>
21796 * class.cs (Property.Define, Method.Define): Remove newslot when
21799 * modifiers.cs: My use of NewSlot when `Abstract' was set was
21800 wrong. NewSlot should only be used if the `new' keyword is present.
21802 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
21803 locating our system dir. Sorry about this.
21805 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21807 * driver.cs (GetSystemDir): Compute correctly the location of our
21808 system assemblies. I was using the compiler directory instead of
21809 the library directory.
21811 2002-02-13 Ravi Pratap <ravi@ximian.com>
21813 * expression.cs (BetterFunction): Put back in what Miguel commented out
21814 since it is the correct fix. The problem is elsewhere ;-)
21816 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
21817 parameters of the parms method are themselves compatible or not !
21819 (StandardConversionExists): Fix very dangerous bug where we were forgetting
21820 to check that a class implements an interface before saying that an implicit
21821 conversion was allowed. Use ImplementsInterface to do the checking.
21823 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21825 * class.cs (Method.Define): Track whether we are an explicit
21826 implementation or not. And only call DefineMethodOverride if we
21827 are an explicit implementation.
21829 (Property.DefineMethod): Ditto.
21831 2002-02-11 Ravi Pratap <ravi@ximian.com>
21833 * expression.cs (BetterFunction): Catch hideous bug which was
21834 preventing us from detecting ambiguous calls due to implicit casts i.e
21837 2002-01-29 Miguel de Icaza <miguel@ximian.com>
21839 * support.cs (Pair): Remove un-needed method. I figured why I was
21840 getting the error in cs-parser.jay, the variable in a foreach loop
21841 is readonly, and the compiler does not really treat this as a variable.
21843 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
21844 instead of EQUALS in grammar.
21846 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
21848 * expression.cs (Unary.DoResolve): Check whether the argument is
21851 2002-01-28 Miguel de Icaza <miguel@ximian.com>
21853 * support.cs: Api for Pair to set a value. Despite the fact that
21854 the variables are public the MS C# compiler refuses to compile
21855 code that accesses the field if the variable is part of a foreach
21858 * statement.cs (Fixed): Begin implementation of the fixed
21861 (Block.AddVariable): Return the VariableInfo on success and null
21862 on failure instead of true/false.
21864 * cs-parser.jay (foreach): Catch errors on variables already
21865 defined (we were ignoring this value before) and properly unwind
21866 the block hierarchy
21868 (fixed_statement): grammar for the fixed statement.
21870 2002-01-25 Miguel de Icaza <miguel@ximian.com>
21872 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
21873 pointer types to be incretemented.
21875 (SizeOf): Implement.
21877 * cs-parser.jay (pointer_member_access): Implement
21878 expr->IDENTIFIER production.
21880 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
21881 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
21884 (Unary): Implement indirection.
21886 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
21887 use in non-unsafe context).
21889 (SimpleName.DoResolve): Check for pointers in field access on safe
21892 (Expression.LoadFromPtr): Factor the load-indirect code in this
21893 function. This was duplicated in UnboxCast and ParameterReference
21895 2002-01-24 Miguel de Icaza <miguel@ximian.com>
21897 * expression.cs (ComposedCast): report an error if a pointer cast
21898 is used in a safe region.
21900 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
21901 pointer type casts in unsafe context.
21903 * codegen.cs (EmitContext): Set up IsUnsafe.
21905 * cs-parser.jay (non_expression_type): Add productions for pointer
21908 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
21909 code. We should not use force into static mode if the method is
21910 not virtual. Fixes bug in MIS
21912 * statement.cs (Do.Emit, While.Emit, For.Emit,
21913 Statement.EmitBoolExpression): Add support to Do and While to
21914 propagate infinite loop as `I do return' semantics.
21916 Improve the For case to also test for boolean constants.
21918 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
21919 to the list of attributes we can add.
21921 Remove `EmitContext' argument.
21923 * class.cs (Method.Define): Apply parameter attributes.
21924 (Constructor.Define): Apply parameter attributes.
21925 (MethodCore.LabelParameters): Move here the core of labeling
21928 * support.cs (ReflectionParameters.ParameterModifier,
21929 InternalParameters.ParameterModifier): Use IsByRef on the type and
21930 only return the OUT bit for these parameters instead of in/out/ref
21933 This is because I miss-understood things. The ParameterInfo.IsIn
21934 and IsOut represent whether the parameter has the [In] and [Out]
21937 2002-01-22 Miguel de Icaza <miguel@ximian.com>
21939 * ecore.cs (FieldExpr.Emit): Release temporaries.
21941 * assign.cs (LocalTemporary.Release): new function.
21943 * codegen.cs (EmitContext.GetTemporaryStorage,
21944 EmitContext.FreeTemporaryStorage): Rework the way we deal with
21945 temporary storage. Now we can "put back" localbuilders when we
21948 2002-01-21 Miguel de Icaza <miguel@ximian.com>
21950 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
21951 need to make a copy of the variable to generate verifiable code.
21953 2002-01-19 Miguel de Icaza <miguel@ximian.com>
21955 * driver.cs: Compute dynamically the system directory.
21957 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
21958 Slower, but more generally useful. Used by the abstract
21959 registering implementation.
21961 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
21962 the rules for the special rule on Type/instances. First check if
21963 we have the same name, and if so, try that special static path
21964 rather than the instance path.
21966 2002-01-18 Miguel de Icaza <miguel@ximian.com>
21968 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
21971 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
21972 Enum, ValueType, Delegate or Array for non-corlib compiles.
21974 * cs-tokenizer.cs: Catch long identifiers (645)
21976 * typemanager.cs (IndexerPropetyName): Ravi never tested this
21979 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
21980 fix, we were returning too early, so we were not registering
21981 pending methods from abstract classes.
21983 Do not register pending methods if the class is abstract.
21985 * expression.cs (Conditional.DoResolve): Report circular implicit
21986 conversions when we neecd to compute it for conditional
21989 (Is.DoResolve): If the expression is always of the provided type,
21990 flag warning 183. If the expression can not ever be of the
21991 provided type flag warning 184.
21993 * class.cs: Catch 169 as well.
21995 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
21998 2002-01-18 Nick Drochak <ndrochak@gol.com>
22000 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
22002 2002-01-17 Miguel de Icaza <miguel@ximian.com>
22004 * interface.cs: (PopulateMethod): Check for pointers being defined
22005 only if the unsafe context is active.
22006 (PopulateProperty): ditto.
22007 (PopulateIndexer): ditto.
22009 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
22010 specified. If pointers are present, make sure that they are
22011 present in an unsafe context.
22012 (Constructor, Constructor.Define): ditto.
22013 (Field, Field.Define): ditto.
22014 (Property, Property.Define): ditto.
22015 (Event, Event.Define): ditto.
22017 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
22018 hashtable if there are classes or structs defined.
22020 * expression.cs (LocalVariableReference.DoResolve): Simplify this
22021 code, as the constant resolution moved.
22023 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
22024 the metadata, so we can flag error 133.
22026 * decl.cs (MemberCore.UnsafeOK): New function to test that a
22027 pointer is being declared in an unsafe context.
22029 2002-01-16 Miguel de Icaza <miguel@ximian.com>
22031 * modifiers.cs (Modifiers.Check): Require a Location argument.
22032 Report error 227 for Unsafe use.
22034 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
22036 * statement.cs (For.Emit): If the test is null, then report that
22037 we do `return', as we wont reach anything afterwards.
22039 (Switch.SwitchGoverningType): Track the expression that matched
22042 * driver.cs: Allow negative numbers as an error code to flag.
22044 * cs-parser.jay: Handle 1551.
22046 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
22048 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22050 * cs-parser.jay: Report 1518 (type declaration can only contain
22051 class, struct, interface, enum or delegate)
22053 (switch_label): Report 1523 (keywords `case' or `default' must
22056 (opt_switch_sections): Report 1522 (empty switch)
22058 * driver.cs: Report 1515 (response file specified multiple times)
22059 Report 1516 (Source file specified multiple times).
22061 * expression.cs (Argument.Resolve): Signal 1510
22063 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
22064 access not allowed in static code)
22066 2002-01-11 Ravi Pratap <ravi@ximian.com>
22068 * typemanager.cs (IsPointerType): Utility method which we are going
22071 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
22072 the object type, so we take care of that.
22074 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
22076 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
22077 added to non-params parameters :-)
22079 * typemanager.cs (CSharpName): Include 'void' type too.
22081 (void_ptr_type): Include in the set of core types.
22083 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
22086 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
22089 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
22090 completely forgotten about it.
22092 2002-01-10 Ravi Pratap <ravi@ximian.com>
22094 * cs-parser.jay (pointer_type): Add. This begins our implementation
22095 of parsing rules for unsafe code.
22097 (unsafe_statement): Implement.
22099 (embedded_statement): Modify to include the above.
22101 * statement.cs (Unsafe): Implement new class for unsafe blocks.
22103 * codegen.cs (EmitContext.InUnsafe): Add. This determines
22104 if the current context is an unsafe one.
22106 * cs-parser.jay (local_variable_pointer_type): Since local variable types
22107 are handled differently, we need separate rules for them.
22109 (local_variable_declaration): Update to use local_variable_pointer_type
22110 to allow variable declarations of unmanaged pointer types.
22112 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
22113 in unsafe contexts.
22115 * ../errors/cs0214.cs : Add.
22117 2002-01-16 Nick Drochak <ndrochak@gol.com>
22119 * makefile: remove 'response' file when cleaning.
22121 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22123 * cs-parser.jay: Report 1524.
22125 2002-01-14 Miguel de Icaza <miguel@ximian.com>
22127 * typemanager.cs (RegisterMethod): drop checking if we have
22128 registered this from here
22130 2002-01-12 Miguel de Icaza <miguel@ximian.com>
22132 * class.cs (Method.EmitDestructor): Implement calling our base
22135 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
22136 value of InFinally.
22138 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
22139 this routine and will wrap the call in a try/catch block. Deal
22142 2002-01-11 Miguel de Icaza <miguel@ximian.com>
22144 * ecore.cs (Expression.MemberLookup): instead of taking a
22145 parameter `same_type' that was used to tell whether we could
22146 access private members we compute our containing type from the
22149 (FieldExpr): Added partial support for volatile fields. This does
22150 not work for volatile fields exposed from assemblies, as I can not
22151 figure out how to extract the modreq from it.
22153 Updated all the source files to use this.
22155 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
22156 because it is referenced by MemberLookup very often.
22158 2002-01-09 Ravi Pratap <ravi@ximian.com>
22160 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
22161 TypeBuilder.GetCustomAttributes to retrieve what we need.
22163 Get rid of redundant default_member_attr_type as this is the same as
22164 default_member_type which already exists.
22166 * interface.cs, attribute.cs : Update accordingly.
22168 2002-01-08 Miguel de Icaza <miguel@ximian.com>
22170 * typemanager.cs: Enable IndexerPropertyName again. It does not
22171 work for TYpeBuilders though. Ravi, can you please fix this?
22173 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22175 * expression.cs (Argument.Emit): Handle the case of ref objects
22176 being passed to ref functions;
22178 (ParameterReference.EmitLoad): Loads the content of the pointer
22179 without dereferencing.
22181 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22183 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22185 2002-01-08 Ravi Pratap <ravi@ximian.com>
22187 * class.cs (Indexer.DefineMethod): Incorporate the interface
22188 type in the name of the method if we are doing explicit interface
22191 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22193 (BetterConversion): Fix extremely trivial bug where we were referring to
22194 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22197 * ../errors/bug16.cs : Add although we have fixed it.
22199 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22201 * expression.cs (BaseIndexer): Begin implementation.
22203 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22205 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22206 production directly to remove a shift/reduce, and implement
22207 explicit interface implementation.
22209 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22210 after a floating point suffix.
22212 * expression.cs (DoNumericPromotions): Improved the conversion for
22213 uint/uint. If we have a constant, we avoid doing a typecast to a
22216 * class.cs (Indexer): Implement explicit interface implementation
22219 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22221 * class.cs: make the default instance constructor public and hidebysig.
22223 2001-01-03 Ravi Pratap <ravi@ximian.com>
22225 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22226 so we can call it from elsewhere.
22228 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22229 we emit it internally if the class has a defined indexer; otherwise the user
22230 emits it by decorating the class definition with the DefaultMemberAttribute.
22232 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22233 attribute is not used on a type which defines an indexer.
22235 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22236 character when we skip whitespace.
22238 * ../errors/cs0646.cs : Add.
22240 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22242 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22245 * makefile: Add practical target `mcs3.exe' which builds the third
22246 generation compiler.
22248 * expression.cs (New): Fix structures constructor calling.
22250 * class.cs (Property, Method, Indexer): Emit Final flag on the
22251 method if we are an interface implementation and we are not
22254 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22255 whether this property is referencing a `base' method.
22257 * expression.cs (Invocation.EmitCall): take an extra argument:
22258 is_base, this is used to determine whether the `call' or
22259 `callvirt' opcode should be used.
22262 * delegate.cs: update EmitCall.
22264 * class.cs (Method.Define): Set NewSlot for the cases where we are
22265 not implementing an interface method.
22267 (Property.Define): ditto.
22269 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22271 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22272 'r'. Allows mcs to parse itself fully.
22274 2002-01-02 Ravi Pratap <ravi@ximian.com>
22276 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22277 of the number of initializers that require the InitializeArray method.
22279 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22280 update the above field where necessary.
22282 (MakeByteBlob): Update accordingly.
22284 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22287 (EmitDynamicInitializers): Update in accordance with the new optimization.
22289 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22290 same OpCode applies.
22292 * cs-parser.jay : Fix some glaring errors I introduced.
22294 2002-01-01 Ravi Pratap <ravi@ximian.com>
22296 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22297 so that we can check for name clashes there too.
22299 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22300 for interface indexers.
22302 * interfaces.cs (Define): Emit the default member attribute.
22304 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22305 variable was being referred to while setting the value ;-)
22307 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22309 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22310 byte-by-byte information when we know the data is zero.
22312 Make the block always a multiple of 4, because
22313 DefineInitializedData has a bug.
22315 * assign.cs: Fix, we should assign from the temporary, not from
22318 * expression.cs (MakeByteBlob): Fix my incorrect code.
22320 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22322 * typemanager.cs (EnumToUnderlying): This function is used to get
22323 the underlying type from an enumeration, because it does not
22326 * constant.cs: Use the I4_S form for values between -128 and 127.
22328 * statement.cs (Block.LookupLabel): Looks up a label.
22329 (Block): Drop support for labeled blocks.
22331 (LabeledStatement): New kind of statement that represents a label
22334 (Goto): Finally implement this bad boy.
22336 * cs-parser.jay: Update to reflect new mechanism to implement
22339 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22341 * codegen.cs (EmitContext.This): a codegen property that keeps the
22342 a single instance of this instead of creating many different this
22345 * delegate.cs (Delegate.DoResolve): Update to use the property;
22347 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22349 * expression.cs (BaseAccess.DoResolve): Ditto.
22351 2001-12-29 Ravi Pratap <ravi@ximian.com>
22353 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22354 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22356 (InitCoreTypes): Update accordingly.
22358 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22359 so we can quickly store the state.
22361 (ApplyAttributes): Set the correct implementation flags
22362 for InternalCall methods.
22364 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22366 * expression.cs (EmitCall): if a method is not virtual, then do
22367 not use callvirt on it.
22369 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22370 user defined stuff) requires the use of stobj, which takes an
22371 address on the stack instead of an array and an index. So emit
22372 the Ldelema operation for it.
22374 (EmitStoreOpcode): Use stobj for valuetypes.
22376 (UnaryMutator.EmitCode): Use the right 1 value depending on
22377 whether we are dealing with int64/uint64, float or doubles.
22379 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22380 constructors that I implemented last night.
22382 (Constructor.IsDefault): Fix to work properly for static
22385 * cs-parser.jay (CheckDef): report method signature errors.
22386 Update error number 103 to be 132.
22388 * decl.cs: New AdditionResult enumeration value: MethodExists.
22389 Although we do this check for methods later on in the semantic
22390 analysis, catching repeated default constructors is so easy that
22391 we catch these here.
22393 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22396 (ParameterReference.EmitAssign, Emit): handle
22399 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22400 (ArrayAccess.EmitStoreOpcode): ditto.
22402 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22404 * expression.cs (MakeByteBlob): Complete all the missing types
22405 (uint, short, ushort, byte, sbyte)
22407 * class.cs: Only init instance field initializers on instance
22410 Rename `constructors' to instance_constructors.
22412 (TypeContainer.AddConstructor): Only add constructors to the list
22413 if it is not static.
22415 Make sure that we handle default_static_constructor independently
22416 everywhere where we handle instance_constructors
22418 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22420 * class.cs: Do not lookup or create a base initializer for a
22421 static constructor.
22423 (ConstructorInitializer.Resolve): use the proper type to lookup
22426 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22428 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22431 * decl.cs: CloseType is now an virtual method, the default
22432 implementation just closes this type.
22434 2001-12-28 Ravi Pratap <ravi@ximian.com>
22436 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22437 to PreserveSig by default. Also emit HideBySig on such methods.
22439 Basically, set the defaults to standard values.
22441 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22442 argument, if candidate is better, it can't be worse than the best !
22444 (Invocation): Re-write bits to differentiate between methods being
22445 applicable in their expanded form and their normal form - for params
22448 Get rid of use_standard everywhere as only standard conversions are allowed
22449 in overload resolution.
22451 More spec conformance.
22453 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22455 * driver.cs: Add --timestamp, to see where the compiler spends
22458 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22459 `this' in static code.
22461 (SimpleName.DoResolve): Implement in terms of a helper function
22462 that allows static-references to be passed upstream to
22465 (Expression.ResolveWithSimpleName): Resolve specially simple
22466 names when called by MemberAccess to implement the special
22469 (Expression.ImplicitReferenceConversion): Handle conversions from
22470 Null to reference types before others, as Null's type is
22473 * expression.cs (Invocation.EmitCall): Handle the special case of
22474 calling methods declared on a reference type from a ValueType
22475 (Base classes System.Object and System.Enum)
22477 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22478 the left hand side is a TypeExpr, not on every enumeration.
22480 (Binary.Resolve): If types are reference types, then do a cast to
22481 object on operators != and == of both arguments.
22483 * typemanager.cs (FindMembers): Extract instance and static
22484 members if requested.
22486 * interface.cs (PopulateProperty): Use void_type instead of null
22487 as the return type for the setter method.
22489 (PopulateIndexer): ditto.
22491 2001-12-27 Ravi Pratap <ravi@ximian.com>
22493 * support.cs (ReflectionParameters): Fix minor bug where we
22494 were examining the wrong parameter for the ParamArray attribute.
22496 Cope with requests for the type of the parameter at position
22497 greater than the params parameter's. We now return the element
22498 type of the params array as that makes more sense.
22500 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22501 accordingly as we no longer have to extract the element type
22504 (Invocation.OverloadResolve): Update.
22506 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22508 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22509 against IEnumerator, test whether the return value is a descendant
22510 of the IEnumerator interface.
22512 * class.cs (Indexer.Define): Use an auxiliary method to implement
22513 the other bits of the method definition. Begin support for
22514 explicit interface implementation.
22516 (Property.DefineMethod): Use TypeManager.void_type instead of null
22517 for an empty return value.
22519 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22521 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22522 dealing with a FieldExpr which is composed of a FieldBuilder, in
22523 the code path we did extract the constant, but we should have
22524 obtained the underlying value to be able to cast it (otherwise we
22525 end up in an infinite loop, this is what Ravi was running into).
22527 (ArrayCreation.UpdateIndices): Arrays might be empty.
22529 (MemberAccess.ResolveMemberAccess): Add support for section
22530 14.5.4.1 that deals with the special case of E.I when E is a type
22531 and something else, that I can be a reference to a static member.
22533 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22534 handle a particular array type to create byte blobs, it is just
22535 something we dont generate byteblobs for.
22537 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22540 * location.cs (Push): remove the key from the hashtable that we
22541 are about to add. This happens for empty files.
22543 * driver.cs: Dispose files after we have parsed them.
22545 (tokenize): new function that only runs the tokenizer on its
22546 input, for speed testing.
22548 2001-12-26 Ravi Pratap <ravi@ximian.com>
22550 * class.cs (Event.Define): Define the private field only if there
22551 are no accessors defined.
22553 * expression.cs (ResolveMemberAccess): If there is no associated
22554 field with the event, that means we have an event defined with its
22555 own accessors and we should flag error cs0070 since transforming
22556 ourselves into a field is not valid in that case.
22558 * ecore.cs (SimpleName.DoResolve): Same as above.
22560 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22561 and charset to sane values.
22563 2001-12-25 Ravi Pratap <ravi@ximian.com>
22565 * assign.cs (DoResolve): Perform check on events only if they
22566 are being accessed outside the declaring type.
22568 * cs-parser.jay (event_declarations): Update rules to correctly
22569 set the type of the implicit parameter etc.
22571 (add_accessor, remove_accessor): Set current local parameters.
22573 * expression.cs (Binary): For delegate addition and subtraction,
22574 cast the return value from the method into the appropriate delegate
22577 2001-12-24 Ravi Pratap <ravi@ximian.com>
22579 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22580 of these as the workaround is unnecessary.
22582 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22583 delegate data - none of that is needed at all.
22585 Re-write bits to extract the instance expression and the delegate method
22588 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22591 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22592 of attaching attributes instead of duplicating code everywhere.
22594 * everywhere : Update code to do attribute emission using the above method.
22596 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22598 * expression.cs (IsParamsMethodApplicable): if there are not
22599 parameters, return immediately.
22601 * ecore.cs: The 0 literal can be implicity converted to an enum
22604 (SimpleName.DoResolve): First lookup the type, then lookup the
22607 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22608 want to get its address. If the InstanceExpression is not
22609 addressable, store the result in a temporary variable, then get
22612 * codegen.cs: Only display 219 errors on warning level or above.
22614 * expression.cs (ArrayAccess): Make it implement the
22615 IMemoryLocation interface.
22617 (Binary.DoResolve): handle the operator == (object a, object b)
22618 and operator != (object a, object b) without incurring into a
22619 BoxedCast (because 5 != o should never be performed).
22621 Handle binary enumerator operators.
22623 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22624 value type, otherwise use Ldelem_ref.
22626 Use precomputed names;
22628 (AddressOf): Implement address of
22630 * cs-parser.jay (labeled_statement): Fix recursive block
22631 addition by reworking the production.
22633 * expression.cs (New.DoEmit): New has a special case:
22635 If we are dealing with a ValueType, we have a few
22636 situations to deal with:
22638 * The target of New is a ValueType variable, that is
22639 easy, we just pass this as the variable reference
22641 * The target of New is being passed as an argument,
22642 to a boxing operation or a function that takes a
22645 In this case, we need to create a temporary variable
22646 that is the argument of New.
22649 2001-12-23 Ravi Pratap <ravi@ximian.com>
22651 * rootcontext.cs (LookupType): Check that current_type is not null before
22652 going about looking at nested types.
22654 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22655 not implement the IAssignMethod interface any more.
22657 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22658 where we tranform them into FieldExprs if they are being resolved from within
22659 the declaring type.
22661 * ecore.cs (SimpleName.DoResolve): Do the same here.
22663 * assign.cs (DoResolve, Emit): Clean up code considerably.
22665 * ../errors/bug10.cs : Add.
22667 * ../errors/cs0070.cs : Add.
22669 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22671 * assign.cs : Get rid of EventIsLocal everywhere.
22673 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22675 * ecore.cs (ConvertIntLiteral): finished the implementation.
22677 * statement.cs (SwitchLabel): Convert the value we are using as a
22678 key before looking up the table.
22680 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22682 * codegen.cs (EmitTopBlock): Require a Location argument now.
22684 * cs-parser.jay (constructor_declarator): We need to setup
22685 current_local_parameters before we parse the
22686 opt_constructor_initializer, to allow the variables to be bound
22687 to the constructor arguments.
22689 * rootcontext.cs (LookupType): First lookup nested classes in our
22690 class and our parents before we go looking outside our class.
22692 * expression.cs (ConstantFold): Extract/debox the values at the
22695 * rootcontext.cs (EmitCode): Resolve the constants first before we
22696 resolve the types. This is not really needed, but it helps debugging.
22698 * statement.cs: report location.
22700 * cs-parser.jay: pass location to throw statement.
22702 * driver.cs: Small bug fix.
22704 * report.cs: Updated format to be 4-zero filled digits.
22706 2001-12-22 Ravi Pratap <ravi@ximian.com>
22708 * expression.cs (CheckIndices): Fix minor bug where the wrong
22709 variable was being referred to ;-)
22711 (DoEmit): Do not call EmitStaticInitializers when the
22712 underlying type is System.Object.
22714 2001-12-21 Ravi Pratap <ravi@ximian.com>
22716 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22717 and do the usual workaround for SRE.
22719 * class.cs (MyEventBuilder.EventType): New member to get at the type
22720 of the event, quickly.
22722 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22724 * assign.cs (Assign.DoResolve): Handle the case when the target
22725 is an EventExpr and perform the necessary checks.
22727 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22730 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22732 (EventExpr): Set the type in the constructor itself since we
22733 are meant to be born fully resolved.
22735 (EventExpr.Define): Revert code I wrote earlier.
22737 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22738 instance expression is null. The instance expression is a This in that case
22739 or a null, depending on whether it is a static method or not.
22741 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22742 refers to more than one method.
22744 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22745 and accordingly flag errors.
22747 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22749 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22751 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22753 * location.cs (ToString): Provide useful rutine.
22755 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22757 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22758 objects, return the actual integral boxed.
22760 * statement.cs (SwitchLabel): define an ILLabel for each
22763 (Switch.CheckSwitch): If the value is a Literal, extract
22764 the underlying literal.
22766 Also in the unused hashtable we had, add the SwitchLabel so we can
22767 quickly look this value up.
22769 * constant.cs: Implement a bunch of new constants. Rewrite
22770 Literal based on this. Made changes everywhere to adapt to this.
22772 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22773 dereferencing array only once, and also copes with enumrations.
22775 bytes are two bytes wide, not one.
22777 (Cast): Perform constant conversions.
22779 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22780 wrappers to the literals here.
22782 * expression.cs (DoNumericPromotions): long literals can converted
22783 to ulong implicity (this is taken care of elsewhere, but I was
22784 missing this spot).
22786 * ecore.cs (Expression.Literalize): Make the return type Literal,
22787 to improve type checking.
22789 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
22791 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22793 * literal.cs: Revert code from ravi that checked the bounds. The
22794 bounds are sane by the definition of the type itself.
22796 * typemanager.cs: Fix implementation of ImplementsInterface. We
22797 need to actually look up in our parent hierarchy for interfaces
22800 * const.cs: Use the underlying type for enumerations
22802 * delegate.cs: Compute the basename for the delegate creation,
22803 that should fix the delegate test case, and restore the correct
22804 Type Lookup semantics in rootcontext
22806 * rootcontext.cs: Revert Ravi's last patch. The correct way of
22807 referencing a nested type with the Reflection API is using the "+"
22810 * cs-parser.jay: Do not require EOF token at the end.
22812 2001-12-20 Ravi Pratap <ravi@ximian.com>
22814 * rootcontext.cs (LookupType): Concatenate type names with
22815 a '.' instead of a '+' The test suite passes again.
22817 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
22818 field of the enumeration.
22820 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
22821 the case when the member is an EventExpr.
22823 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
22824 static has an associated instance expression.
22826 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
22828 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
22830 * class.cs (Event.Define): Register event and perform appropriate checks
22833 We define the Add and Remove methods even if the use provides none because
22834 in that case, we provide default implementations ourselves.
22836 Define a private field of the type of the event. This is done by the CSC compiler
22837 and we should be doing it too ;-)
22839 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
22840 More methods we use in code we generate.
22842 (multicast_delegate_type, delegate_type): Two separate types since the distinction
22845 (InitCoreTypes): Update accordingly for the above.
22847 * class.cs (Event.Emit): Generate code for default accessors that we provide
22849 (EmitDefaultMethod): Do the job in the above.
22851 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
22854 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22856 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
22857 builders even if we were missing one.
22859 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
22860 pass the Basename as our class name instead of the Name. The
22861 basename will be correctly composed for us.
22863 * parameter.cs (Paramters): Now takes a Location argument.
22865 * decl.cs (DeclSpace.LookupType): Removed convenience function and
22866 make all the code call directly LookupType in RootContext and take
22867 this chance to pass the Location information everywhere.
22869 * Everywhere: pass Location information.
22871 2001-12-19 Miguel de Icaza <miguel@ximian.com>
22873 * class.cs (Constructor.Define): Updated way of detecting the
22874 length of the parameters.
22876 (TypeContainer.DefineType): Use basename as the type name for
22879 (TypeContainer.Define): Do not recursively define types here, as
22880 definition is taken care in order by the RootContext.
22882 * tree.cs: Keep track of namespaces in a per-file basis.
22884 * parameter.cs (Parameter.ComputeSignature): Update to use
22887 (Parameters.GetSignature): ditto.
22889 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
22890 instead of a TypeContainer.
22892 (Interface.SemanticAnalysis): Use `this' instead of our parent to
22893 resolve names. Because we need to be resolve in our context, not
22896 * driver.cs: Implement response files.
22898 * class.cs (TypeContainer.DefineType): If we are defined, do not
22899 redefine ourselves.
22901 (Event.Emit): Emit the code for add/remove handlers.
22902 (Event.Define): Save the MethodBuilders for add/remove.
22904 * typemanager.cs: Use pair here too.
22906 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
22907 DictionaryEntry requires the first argument to be non-null.
22909 (enum_declaration): Compute full name for registering the
22912 (delegate_declaration): Instead of using
22913 formal_parameter_list, use opt_formal_parameter_list as the list
22916 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
22917 (EventParsing): New property that controls whether `add' and
22918 `remove' are returned as tokens or identifiers (for events);
22920 2001-12-19 Ravi Pratap <ravi@ximian.com>
22922 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
22923 use MyEventBuilder only and let it wrap the real builder for us.
22925 (MyEventBuilder): Revamp constructor etc.
22927 Implement all operations that we perform on EventBuilder in precisely the same
22930 (FindMembers): Update to use the EventBuilder member.
22932 (Event.Emit): Update accordingly.
22934 2001-12-18 Ravi Pratap <ravi@ximian.com>
22936 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
22937 by calling the appropriate methods.
22939 (GetCustomAttributes): Make stubs as they cannot possibly do anything
22942 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
22944 2001-12-17 Ravi Pratap <ravi@ximian.com>
22946 * delegate.cs (Delegate.Populate): Check that the return type
22947 and various parameters types are indeed accessible.
22949 * class.cs (Constructor.Define): Same here.
22951 (Field.Define): Ditto.
22953 (Event.Define): Ditto.
22955 (Operator.Define): Check that the underlying Method defined itself
22956 correctly - so it's MethodBuilder should not be null.
22958 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
22959 expression happens to be null.
22961 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
22962 members but as of now we don't seem to be able to do anything really useful with it.
22964 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
22965 not the EventBuilder.
22967 2001-12-18 Miguel de Icaza <miguel@ximian.com>
22969 * cs-tokenizer.cs: Add support for defines.
22970 Add support for #if, #elif, #else, #endif
22972 (eval_var): evaluates a variable.
22973 (eval): stubbed for evaluating functions.
22975 * cs-parser.jay: Pass the defines information
22977 * driver.cs: Add --define command line option.
22979 * decl.cs: Move MemberCore here.
22981 Make it the base class for DeclSpace. This allows us to catch and
22982 report 108 and 109 for everything now.
22984 * class.cs (TypeContainer.Define): Extract all the members
22985 before populating and emit the warning 108 (new keyword required
22986 to override) instead of having each member implement this.
22988 (MemberCore.Define): New abstract method, we will be using this in
22989 the warning reporting engine in Populate.
22991 (Operator.Define): Adjust to new MemberCore protocol.
22993 * const.cs (Const): This does not derive from Expression, it is a
22994 temporary object we use to create fields, it is a MemberCore.
22996 * class.cs (Method.Define): Allow the entry point to be in a
22999 * driver.cs: Rewrite the argument handler to clean it up a bit.
23001 * rootcontext.cs: Made it just an auxiliary namespace feature by
23002 making everything static.
23004 * driver.cs: Adapt code to use RootContext type name instead of
23007 * delegate.cs: Remove RootContext argument.
23009 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
23012 * class.cs (Event.Define): The lookup can fail.
23014 * cs-tokenizer.cs: Begin implementation of pre-procesor.
23016 * expression.cs: Resolve the this instance before invoking the code.
23018 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23020 * cs-parser.jay: Add a production in element_access that allows
23021 the thing to become a "type" reference. This way we can parse
23022 things like "(string [])" as a type.
23024 Note that this still does not handle the more complex rules of
23028 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
23030 * ecore.cs: (CopyNewMethods): new utility function used to
23031 assemble the list of methods from running FindMembers.
23033 (MemberLookup): Rework FindMembers so that
23035 2001-12-16 Miguel de Icaza <miguel@ximian.com>
23037 * class.cs (TypeContainer): Remove Delegates who fail to be
23040 * delegate.cs (Populate): Verify that we dont get null return
23041 values. TODO: Check for AsAccessible.
23043 * cs-parser.jay: Use basename to emit error 574 (destructor should
23044 have the same name as container class), not the full name.
23046 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
23047 possible representation.
23049 Also implements integer type suffixes U and L.
23051 2001-12-15 Miguel de Icaza <miguel@ximian.com>
23053 * expression.cs (ArrayCreation.DoResolve): We need to do the
23054 argument resolution *always*.
23056 * decl.cs: Make this hold the namespace. Hold the root context as
23058 (LookupType): Move here.
23060 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
23062 * location.cs (Row, Name): Fixed the code, it was always returning
23063 references to the first file.
23065 * interface.cs: Register properties defined through interfaces.
23067 * driver.cs: Add support for globbing on the command line
23069 * class.cs (Field): Make it derive from MemberCore as well.
23072 2001-12-15 Ravi Pratap <ravi@ximian.com>
23074 * class.cs (Event::Define): Check that the type of the event is a delegate
23075 type else flag error #66.
23077 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
23080 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
23081 values of EntryPoint, CharSet etc etc.
23083 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
23085 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
23086 be null and we should ignore this. I am not sure if this is really clean. Apparently,
23087 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
23088 which needs this to do its work.
23090 * ../errors/cs0066.cs : Add.
23092 2001-12-14 Miguel de Icaza <miguel@ximian.com>
23094 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
23097 * class.cs: (MethodSignature.MethodSignature): Removed hack that
23098 clears out the parameters field.
23099 (MemberSignatureCompare): Cleanup
23101 (MemberCore): New base class used to share code between MethodCore
23104 (RegisterRequiredImplementations) BindingFlags.Public requires
23105 either BindingFlags.Instace or Static. Use instance here.
23107 (Property): Refactored code to cope better with the full spec.
23109 * parameter.cs (GetParameterInfo): Return an empty array instead
23112 * class.cs (Property): Abstract or extern properties have no bodies.
23114 * parameter.cs (GetParameterInfo): return a zero-sized array.
23116 * class.cs (TypeContainer.MethodModifiersValid): Move all the
23117 method modifier validation to the typecontainer so we can reuse
23118 this on properties.
23120 (MethodCore.ParameterTypes): return an empty sized array of types.
23122 (Property.Define): Test property modifier validity.
23124 Add tests for sealed/override too.
23126 (Method.Emit): abstract or extern methods have no bodies.
23128 2001-12-14 Ravi Pratap <ravi@ximian.com>
23130 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
23133 (Method::Define, ::Emit): Modify accordingly.
23135 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
23137 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
23139 * makefile: Pass in /unsafe.
23141 2001-12-13 Miguel de Icaza <miguel@ximian.com>
23143 * class.cs (MakeKey): Kill routine.
23145 * class.cs (TypeContainer.Define): Correctly define explicit
23146 method implementations (they require the full interface name plus
23149 * typemanager.cs: Deply the PtrHashtable here and stop using the
23150 lame keys. Things work so much better.
23152 This of course broke everyone who depended on `RegisterMethod' to
23153 do the `test for existance' test. This has to be done elsewhere.
23155 * support.cs (PtrHashtable): A hashtable that avoid comparing with
23156 the object stupid Equals method (because, that like fails all over
23157 the place). We still do not use it.
23159 * class.cs (TypeContainer.SetRequiredInterface,
23160 TypeContainer.RequireMethods): Killed these two routines and moved
23161 all the functionality to RegisterRequiredImplementations.
23163 (TypeContainer.RegisterRequiredImplementations): This routine now
23164 registers all the implementations required in an array for the
23165 interfaces and abstract methods. We use an array of structures
23166 which can be computed ahead of time to reduce memory usage and we
23167 also assume that lookups are cheap as most classes will not
23168 implement too many interfaces.
23170 We also avoid creating too many MethodSignatures.
23172 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23173 clear the "pending" bit if we find that there are problems with
23176 (TypeContainer.VerifyPendingMethods): Update to report errors of
23177 methods that look like implementations but are not.
23179 (TypeContainer.Define): Add support for explicit interface method
23182 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23184 * typemanager.cs: Keep track of the parameters here instead of
23185 being a feature of the TypeContainer.
23187 * class.cs: Drop the registration of parameters here, as
23188 InterfaceMethods are also interface declarations.
23190 * delegate.cs: Register methods with the TypeManager not only with
23191 the TypeContainer. This code was buggy.
23193 * interface.cs: Full registation here.
23195 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23197 * expression.cs: Remove reducer for binary expressions, it can not
23200 * const.cs: Put here the code that used to go into constant.cs
23202 * constant.cs: Put here the code for constants, this is a new base
23203 class for Literals.
23205 * literal.cs: Make Literal derive from Constant.
23207 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23209 * statement.cs (Return.Emit): Report error 157 if the user
23210 attempts to return from a finally block.
23212 (Return.Emit): Instead of emitting a return, jump to the end of
23215 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23216 LocalBuilder to store the result of the function. ReturnLabel is
23217 the target where we jump.
23220 2001-12-09 Radek Doulik <rodo@ximian.com>
23222 * cs-parser.jay: remember alias in current namespace
23224 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23227 * class.cs (LookupAlias): lookup alias in my_namespace
23229 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23231 (LookupAlias): lookup alias in this and if needed in parent
23234 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23238 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23239 making things static. I need this to avoid passing the
23240 TypeContainer when calling ParameterType.
23242 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23243 that did string manipulation to compute the type and then call
23244 GetType. Use Parameter.ParameterType instead.
23246 * cs-tokenizer.cs: Consume the suffix for floating values.
23248 * expression.cs (ParameterReference): figure out whether this is a
23249 reference parameter or not. Kill an extra variable by computing
23250 the arg_idx during emission.
23252 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23253 function that returns whether a parameter is an out/ref value or not.
23255 (Parameter.ParameterType): The type of the parameter (base,
23256 without ref/out applied).
23258 (Parameter.Resolve): Perform resolution here.
23259 (Parameter.ExternalType): The full type (with ref/out applied).
23261 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23262 support for expressions on the using statement.
23264 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23266 * statement.cs (Using.EmitLocalVariableDecls): Split the
23267 localvariable handling of the using statement.
23269 (Block.EmitMeta): Keep track of variable count across blocks. We
23270 were reusing slots on separate branches of blocks.
23272 (Try.Emit): Emit the general code block, we were not emitting it.
23274 Check the type of the declaration to be an IDisposable or
23275 something that can be implicity converted to it.
23277 Emit conversions if required.
23279 * ecore.cs (EmptyExpression): New utility class.
23280 (Expression.ImplicitConversionExists): New utility function.
23282 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23284 * statement.cs (Using): Implement.
23286 * expression.cs (LocalVariableReference): Support read only variables.
23288 * statement.cs: Remove the explicit emit for the Leave opcode.
23289 (VariableInfo): Add a readonly field.
23291 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23293 * ecore.cs (ConvCast): new class used to encapsulate the various
23294 explicit integer conversions that works in both checked and
23295 unchecked contexts.
23297 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23298 properly generate the overflow opcodes.
23300 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23302 * statement.cs: The correct type for the EmptyExpression is the
23303 element_type, not the variable type. Ravi pointed this out.
23305 2001-12-04 Ravi Pratap <ravi@ximian.com>
23307 * class.cs (Method::Define): Handle PInvoke methods specially
23308 by using DefinePInvokeMethod instead of the usual one.
23310 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23311 above to do the task of extracting information and defining the method.
23313 2001-12-04 Ravi Pratap <ravi@ximian.com>
23315 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23316 of the condition for string type.
23318 (Emit): Move that here.
23320 (ArrayCreation::CheckIndices): Keep string literals in their expression
23323 (EmitDynamicInitializers): Handle strings appropriately.
23325 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23327 * codegen.cs (EmitContext): Replace multiple variables with a
23328 single pointer to the current Switch statement.
23330 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23333 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23337 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23340 (Foreach.Emit): Foreach on arrays was not setting
23341 up the loop variables (for break/continue).
23343 (GotoCase): Semi-implented.
23345 2001-12-03 Ravi Pratap <ravi@ximian.com>
23347 * attribute.cs (CheckAttribute): Handle system attributes by using
23348 Attribute.GetAttributes to examine information we need.
23350 (GetValidPlaces): Same here.
23352 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23354 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23356 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23358 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23360 (Method::Emit): Handle the case when we are a PInvoke method.
23362 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23364 * expression.cs: Use ResolveWithSimpleName on compound names.
23366 2001-12-02 Ravi Pratap <ravi@ximian.com>
23368 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23369 before trying to reduce it.
23371 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23373 * constant.cs (LookupConstantValue): Implement.
23375 (EmitConstant): Use the above in emitting the constant.
23377 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23378 that are user-defined by doing a LookupConstantValue on them.
23380 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23383 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23385 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23387 (BaseAccess.DoResolve): Implement.
23389 (MemberAccess.DoResolve): Split this routine into a
23390 ResolveMemberAccess routine that can be used independently
23392 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23394 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23395 As that share bits of the implementation. Is returns a boolean,
23396 while As returns the Type that is being probed.
23398 2001-12-01 Ravi Pratap <ravi@ximian.com>
23400 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23401 instead of a Literal - much easier.
23403 (EnumInTransit): Remove - utterly useless :-)
23405 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23407 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23409 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23410 chain when we have no associated expression.
23412 2001-11-30 Ravi Pratap <ravi@ximian.com>
23414 * constant.cs (Define): Use Location while reporting the errror.
23416 Also emit a warning when 'new' is used and there is no inherited
23419 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23422 (LookupEnumValue): Implement to lookup an enum member's value and define it
23425 (Populate): Re-write accordingly to use the above routine.
23427 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23429 * expression.cs (This): Fix prototype for DoResolveLValue to
23430 override the base class DoResolveLValue.
23432 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23435 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23436 (we need to load the address of the field here). This fixes
23439 (FieldExpr.DoResolveLValue): Call the DoResolve
23440 function to initialize the Instance expression.
23442 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23443 correctly the GetEnumerator operation on a value type.
23445 * cs-parser.jay: Add more simple parsing error catches.
23447 * statement.cs (Switch): Add support for string switches.
23448 Handle null specially.
23450 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23452 2001-11-28 Ravi Pratap <ravi@ximian.com>
23454 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23456 (declare_local_constant): New helper function.
23458 * statement.cs (AddConstant): Keep a separate record of constants
23460 (IsConstant): Implement to determine if a variable is a constant.
23462 (GetConstantExpression): Implement.
23464 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23466 * statement.cs (IsVariableDefined): Re-write.
23468 2001-11-27 Ravi Pratap <ravi@ximian.com>
23470 * class.cs (TypeContainer::FindMembers): Look for constants
23471 in the case when we are looking for MemberTypes.Field
23473 * expression.cs (MemberAccess::DoResolve): Check that in the
23474 case we are a FieldExpr and a Literal, we are not being accessed
23475 by an instance reference.
23477 * cs-parser.jay (local_constant_declaration): Implement.
23479 (declaration_statement): Implement for constant declarations.
23481 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23483 * statement.cs (Switch): Catch double defaults.
23485 (Switch): More work on the switch() statement
23486 implementation. It works for integral values now, need to finish
23490 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23492 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23493 integer literals into other integer literals. To be used by
23496 2001-11-24 Ravi Pratap <ravi@ximian.com>
23498 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23501 (EmitDynamicInitializers): Cope with the above since we extract data
23502 directly from ArrayData now.
23504 (ExpectInitializers): Keep track of whether initializers are mandatory
23507 (Bounds): Make it a hashtable to prevent the same dimension being
23508 recorded for every element in that dimension.
23510 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23513 Also fix bug which was causing the indices to be emitted in the reverse
23516 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23518 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23519 unfinished. They do not work, because the underlying code is
23522 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23524 * cs-parser.jay: Remove bogus fixme.
23526 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23527 on Switch statement.
23529 2001-11-23 Ravi Pratap <ravi@ximian.com>
23531 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23534 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23535 parameter. Apparently, any expression is allowed.
23537 (ValidateInitializers): Update accordingly.
23539 (CheckIndices): Fix some tricky bugs thanks to recursion.
23541 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23542 I was being completely brain-dead.
23544 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23545 and re-write acordingly.
23547 (DelegateInvocation): Re-write accordingly.
23549 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23551 (MakeByteBlob): Handle types more correctly.
23553 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23554 initialization from expressions but it is incomplete because I am a complete
23557 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23559 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23560 on If. Basically, we have to return `true' (ie, we do return to
23561 our caller) only if both branches of the if return.
23563 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23564 short-circuit operators, handle them as short circuit operators.
23566 (Cast.DoResolve): Resolve type.
23567 (Cast.Cast): Take an expression as the target type.
23569 * cs-parser.jay (cast_expression): Remove old hack that only
23570 allowed a limited set of types to be handled. Now we take a
23571 unary_expression and we resolve to a type during semantic
23574 Use the grammar productions from Rhys to handle casts (this is
23575 not complete like Rhys syntax yet, we fail to handle that corner
23576 case that C# has regarding (-x), but we will get there.
23578 2001-11-22 Ravi Pratap <ravi@ximian.com>
23580 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23581 field which is an array type.
23583 * cs-parser.jay (declare_local_variables): Support array initialization too.
23585 * typemanager.cs (MakeKey): Implement.
23587 (everywhere): Use the above appropriately.
23589 * cs-parser.jay (for_statement): Update for array initialization while
23590 declaring variables.
23592 * ecore.cs : The error message was correct, it's the variable's names that
23593 were misleading ;-) Make the code more readable.
23595 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23596 the correct type etc.
23598 (ConvertExplicit): Handle Enum types by examining the underlying type.
23600 2001-11-21 Ravi Pratap <ravi@ximian.com>
23602 * parameter.cs (GetCallingConvention): Always return
23603 CallingConventions.Standard for now.
23605 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23607 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23608 and `r' after calling DoNumericPromotions.
23610 * ecore.cs: Fix error message (the types were in the wrong order).
23612 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23613 BindingFlags.Instance as well
23615 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23616 implicit int literal conversion in an empty cast so that we
23617 propagate the right type upstream.
23619 (UnboxCast): new class used to unbox value types.
23620 (Expression.ConvertExplicit): Add explicit type conversions done
23623 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23624 the target type before applying the implicit LongLiterals to ULong
23627 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23629 * cs-parser.jay (for_statement): Reworked the way For works: now
23630 we declare manually any variables that are introduced in
23631 for_initializer to solve the problem of having out-of-band code
23632 emition (that is what got for broken).
23634 (declaration_statement): Perform the actual variable declaration
23635 that used to be done in local_variable_declaration here.
23637 (local_variable_declaration): Do not declare anything, just pass
23638 the information on a DictionaryEntry
23640 2001-11-20 Ravi Pratap <ravi@ximian.com>
23642 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23643 re-write of the logic to now make it recursive.
23645 (UpdateIndices): Re-write accordingly.
23647 Store element data in a separate ArrayData list in the above methods.
23649 (MakeByteBlob): Implement to dump the array data into a byte array.
23651 2001-11-19 Ravi Pratap <ravi@ximian.com>
23653 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23656 * constant.cs (Define): Implement.
23658 (EmitConstant): Re-write fully.
23660 Pass in location info.
23662 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23665 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23666 DictionaryEntry since we need location info too.
23668 (constant_declaration): Update accordingly.
23670 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23671 code into another method : UpdateIndices.
23673 2001-11-18 Ravi Pratap <ravi@ximian.com>
23675 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23676 some type checking etc.
23678 2001-11-17 Ravi Pratap <ravi@ximian.com>
23680 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23681 bits to provide dimension info if the user skips doing that.
23683 Update second constructor to store the rank correctly.
23685 2001-11-16 Ravi Pratap <ravi@ximian.com>
23687 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23688 and try to implement.
23690 * ../errors/cs0150.cs : Add.
23692 * ../errors/cs0178.cs : Add.
23694 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23696 * statement.cs: Implement foreach on multi-dimensional arrays.
23698 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23699 name of the params argument.
23701 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23702 initializing the array.
23704 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23705 we can use this elsewhere.
23707 * statement.cs: Finish implementation of foreach for single
23710 * cs-parser.jay: Use an out-of-band stack to pass information
23711 around, I wonder why I need this.
23713 foreach_block: Make the new foreach_block the current_block.
23715 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23716 function used to return a static Parameters structure. Used for
23717 empty parameters, as those are created very frequently.
23719 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23721 2001-11-15 Ravi Pratap <ravi@ximian.com>
23723 * interface.cs : Default modifier is private, not public. The
23724 make verify test passes again.
23726 2001-11-15 Ravi Pratap <ravi@ximian.com>
23728 * support.cs (ReflectionParameters): Fix logic to determine
23729 whether the last parameter is a params one. Test 9 passes again.
23731 * delegate.cs (Populate): Register the builders we define with
23732 RegisterParameterForBuilder. Test 19 passes again.
23734 * cs-parser.jay (property_declaration): Reference $6 instead
23735 of $$ to get at the location.
23737 (indexer_declaration): Similar stuff.
23739 (attribute): Ditto.
23741 * class.cs (Property): Register parameters for the Get and Set methods
23742 if they exist. Test 23 passes again.
23744 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23745 call to EmitArguments as we are sure there aren't any params arguments.
23746 Test 32 passes again.
23748 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23749 IndexOutOfRangeException.
23751 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23752 Test 33 now passes again.
23754 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23756 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23757 broke a bunch of things. Will have to come up with a better way
23758 of tracking locations.
23760 * statement.cs: Implemented foreach for single dimension arrays.
23762 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23764 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23765 an error. This removes the lookup from the critical path.
23767 * cs-parser.jay: Removed use of temporary_loc, which is completely
23770 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23772 * support.cs (ReflectionParameters.ParameterModifier): Report
23773 whether the argument is a PARAMS argument or not.
23775 * class.cs: Set the attribute `ParamArrayAttribute' on the
23776 parameter argument.
23778 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23779 and cons_param_array_attribute (ConstructorInfo for
23780 ParamArrayAttribute).,
23782 * codegen.cs: Emit the return using the `Return' statement, that
23783 way we can report the error correctly for missing return values.
23785 * class.cs (Method.Emit): Clean up.
23787 * expression.cs (Argument.Resolve): Take another argument: the
23788 location where this argument is used. Notice that this is not
23789 part of the "Argument" class as to reduce the size of the
23790 structure (we know the approximate location anyways).
23792 Test if the argument is a variable-reference, if not, then
23793 complain with a 206.
23795 (Argument.Emit): Emit addresses of variables.
23797 (Argument.FullDesc): Simplify.
23799 (Invocation.DoResolve): Update for Argument.Resolve.
23801 (ElementAccess.DoResolve): ditto.
23803 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
23804 method should be virtual, as this method is always virtual.
23806 (NewDelegate.DoResolve): Update for Argument.Resolve.
23808 * class.cs (ConstructorInitializer.DoResolve): ditto.
23810 * attribute.cs (Attribute.Resolve): ditto.
23812 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23814 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
23816 * expression.cs (ParameterReference): Drop IStackStorage and implement
23817 IAssignMethod instead.
23819 (LocalVariableReference): ditto.
23821 * ecore.cs (FieldExpr): Drop IStackStorage and implement
23822 IAssignMethod instead.
23824 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23826 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
23827 enumerations that are used in heavily used structures derive from
23828 byte in a laughable and pathetic attempt to reduce memory usage.
23829 This is the kind of pre-optimzations that you should not do at
23830 home without adult supervision.
23832 * expression.cs (UnaryMutator): New class, used to handle ++ and
23833 -- separatedly from the other unary operators. Cleans up the
23834 code, and kills the ExpressionStatement dependency in Unary.
23836 (Unary): Removed `method' and `Arguments' from this class, making
23837 it smaller, and moving it all to SimpleCall, so I can reuse this
23838 code in other locations and avoid creating a lot of transient data
23839 strucutres when not required.
23841 * cs-parser.jay: Adjust for new changes.
23843 2001-11-11 Miguel de Icaza <miguel@ximian.com>
23845 * enum.cs (Enum.Populate): If there is a failure during
23848 * cs-parser.jay (opt_enum_base): we used to catch type errors
23849 here, but this is really incorrect. The type error should be
23850 catched during semantic analysis.
23852 2001-12-11 Ravi Pratap <ravi@ximian.com>
23854 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
23855 current_local_parameters as expected since I, in my stupidity, had forgotten
23858 * attribute.cs (GetValidPlaces): Fix stupid bug.
23860 * class.cs (Method::Emit): Perform check on applicability of attributes.
23862 (Constructor::Emit): Ditto.
23864 (Field::Emit): Ditto.
23866 (Field.Location): Store location information.
23868 (Property, Event, Indexer, Operator): Ditto.
23870 * cs-parser.jay (field_declaration): Pass in location for each field.
23872 * ../errors/cs0592.cs : Add.
23874 2001-11-12 Ravi Pratap <ravi@ximian.com>
23876 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
23878 (InitCoreTypes): Update accordingly.
23880 (RegisterAttrType, LookupAttr): Implement.
23882 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
23883 info about the same.
23885 (Resolve): Update to populate the above as necessary.
23887 (Error592): Helper.
23889 (GetValidPlaces): Helper to the above.
23891 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
23893 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
23895 2001-11-12 Ravi Pratap <ravi@ximian.com>
23897 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
23899 * ../errors/cs0617.cs : Add.
23901 2001-11-11 Ravi Pratap <ravi@ximian.com>
23903 * enum.cs (Emit): Rename to Populate to be more consistent with what
23904 we expect it to do and when exactly it is called.
23906 * class.cs, rootcontext.cs : Update accordingly.
23908 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
23909 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
23911 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
23913 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
23914 of a fieldinfo using the above, when dealing with a FieldBuilder.
23916 2001-11-10 Ravi Pratap <ravi@ximian.com>
23918 * ../errors/cs0031.cs : Add.
23920 * ../errors/cs1008.cs : Add.
23922 * ../errrors/cs0543.cs : Add.
23924 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
23927 (FindMembers): Implement.
23929 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
23930 enums and delegates too.
23932 (enum_types): Rename to builder_to_enum.
23934 (delegate_types): Rename to builder_to_delegate.
23936 * delegate.cs (FindMembers): Implement.
23938 2001-11-09 Ravi Pratap <ravi@ximian.com>
23940 * typemanager.cs (IsEnumType): Implement.
23942 * enum.cs (Emit): Re-write parts to account for the underlying type
23943 better and perform checking etc.
23945 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
23946 of the underlying type.
23948 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
23951 * enum.cs (error31): Helper to report error #31.
23953 * cs-parser.jay (enum_declaration): Store location of each member too.
23955 * enum.cs (member_to_location): New hashtable.
23957 (AddEnumMember): Update location hashtable.
23959 (Emit): Use the location of each member while reporting errors.
23961 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23963 * cs-parser.jay: A for_initializer if is a
23964 local_variable_declaration really ammount to have an implicit
23965 block with the variable declaration and no initializer for for.
23967 * statement.cs (For.Emit): Cope with null initializers.
23969 This fixes the infinite loop on for initializers.
23971 2001-11-08 Miguel de Icaza <miguel@ximian.com>
23973 * enum.cs: More cleanup.
23975 * ecore.cs: Remove dead code.
23977 * class.cs (Property.Emit): More simplification.
23978 (Event.Emit): ditto.
23980 Reworked to have less levels of indentation.
23982 2001-11-08 Ravi Pratap <ravi@ximian.com>
23984 * class.cs (Property): Emit attributes.
23994 * enum.cs (Emit): Ditto.
23996 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
23999 * class.cs (Field, Event, etc.): Move attribute generation into the
24000 Emit method everywhere.
24002 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
24003 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
24004 as we had no way of defining nested enums !
24006 * rootcontext.cs : Adjust code accordingly.
24008 * typemanager.cs (AddEnumType): To keep track of enum types separately.
24010 2001-11-07 Ravi Pratap <ravi@ximian.com>
24012 * expression.cs (EvalConstantExpression): Move into ecore.cs
24014 * enum.cs (Enum): Rename some members and make them public and readonly
24015 according to our convention.
24017 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24020 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
24022 (Enum::Emit): Write a simple version for now which doesn't try to compute
24023 expressions. I shall modify this to be more robust in just a while.
24025 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
24027 (TypeContainer::CloseType): Create the Enum types too.
24029 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
24031 * expression.cs (EvalConstantExpression): Get rid of completely.
24033 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
24034 user-defined values and other cases.
24036 (IsValidEnumLiteral): Helper function.
24038 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
24039 out there in the case we had a literal FieldExpr.
24041 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
24043 (Literalize): Revamp a bit to take two arguments.
24045 (EnumLiteral): New class which derives from Literal to wrap enum literals.
24047 2001-11-06 Ravi Pratap <ravi@ximian.com>
24049 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
24051 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
24053 (Resolve): Use the above to ensure we have proper initializers.
24055 2001-11-05 Ravi Pratap <ravi@ximian.com>
24057 * expression.cs (Expression::EvalConstantExpression): New method to
24058 evaluate constant expressions.
24060 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
24062 2001-11-07 Miguel de Icaza <miguel@ximian.com>
24064 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
24067 (Binary.ResolveOperator): Handle operator != (object a, object b)
24068 and operator == (object a, object b);
24070 (Binary.DoNumericPromotions): Indicate whether the numeric
24071 promotion was possible.
24073 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
24076 Made the ArrayAccess implement interface IAssignMethod instead of
24077 IStackStore as the order in which arguments are passed reflects
24080 * assign.cs: Instead of using expr.ExprClass to select the way of
24081 assinging, probe for the IStackStore/IAssignMethod interfaces.
24083 * typemanager.cs: Load InitializeArray definition.
24085 * rootcontext.cs (RootContext.MakeStaticData): Used to define
24086 static data that can be used to initialize arrays.
24088 2001-11-05 Miguel de Icaza <miguel@ximian.com>
24090 * expression.cs: Handle operator== and operator!= for booleans.
24092 (Conditioal.Reduce): Implement reducer for the ?: operator.
24094 (Conditional.Resolve): Implement dead code elimination.
24096 (Binary.Resolve): Catch string literals and return a new
24097 concatenated string.
24099 (Unary.Reduce): Implement reduction of unary expressions.
24101 * ecore.cs: Split out the expression core handling here.
24103 (Expression.Reduce): New method used to perform constant folding
24104 and CSE. This is needed to support constant-expressions.
24106 * statement.cs (Statement.EmitBoolExpression): Pass true and false
24107 targets, and optimize for !x.
24109 2001-11-04 Ravi Pratap <ravi@ximian.com>
24111 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
24112 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
24113 set custom atttributes.
24115 * literal.cs (Literal::GetValue): New abstract method to return the actual
24116 value of the literal, cast as an object.
24118 (*Literal): Implement GetValue method.
24120 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
24121 expressions to the arraylist but objects of type Argument.
24123 * class.cs (TypeContainer::Emit): Emit our attributes too.
24125 (Method::Emit, Constructor::Emit): Ditto.
24127 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
24128 to be ignoring earlier.
24130 2001-11-03 Ravi Pratap <ravi@ximian.com>
24132 * attribute.cs (AttributeSection::Define): Implement to do the business
24133 of constructing a CustomAttributeBuilder.
24135 (Attribute): New trivial class. Increases readability of code.
24137 * cs-parser.jay : Update accordingly.
24139 (positional_argument_list, named_argument_list, named_argument): New rules
24141 (attribute_arguments): Use the above so that we are more correct.
24143 2001-11-02 Ravi Pratap <ravi@ximian.com>
24145 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
24146 to perform all checks for a method with a params parameter.
24148 (Invocation::OverloadResolve): Update to use the above method and therefore
24149 cope correctly with params method invocations.
24151 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
24154 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
24155 constructors in our parent too because we can't afford to miss out on
24158 * attribute.cs (AttributeSection): New name for the class Attribute
24160 Other trivial changes to improve readability.
24162 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
24163 use the new class names.
24165 2001-11-01 Ravi Pratap <ravi@ximian.com>
24167 * class.cs (Method::Define): Complete definition for params types too
24169 (Indexer::Define): Ditto.
24171 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
24172 Cope everywhere with a request for info about the array parameter.
24174 2001-11-01 Ravi Pratap <ravi@ximian.com>
24176 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24178 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24179 local_variable_type to extract the string corresponding to the type.
24181 (local_variable_type): Fixup the action to use the new helper method.
24183 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24186 * expression.cs : Clean out code which uses the above.
24188 2001-10-31 Ravi Pratap <ravi@ximian.com>
24190 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24191 and bale out if necessary by returning a false.
24193 (RegisterProperty): Ditto.
24195 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24196 and print out appropriate error messages.
24198 * interface.cs (everywhere): Ditto.
24200 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24201 location to constructor.
24203 * class.cs (Property, Event, Indexer): Update accordingly.
24205 * ../errors/cs111.cs : Added.
24207 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24208 of a method, as laid down by the spec.
24210 (Invocation::OverloadResolve): Use the above method.
24212 2001-10-31 Ravi Pratap <ravi@ximian.com>
24214 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24215 now take a TypeContainer and a Parameters object.
24217 (ParameterData): Modify return type of ParameterModifier method to be
24218 Parameter.Modifier and not a string.
24220 (ReflectionParameters, InternalParameters): Update accordingly.
24222 * expression.cs (Argument::GetParameterModifier): Same here.
24224 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24225 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24226 symbol in it at all so maybe this is only for now.
24228 2001-10-30 Ravi Pratap <ravi@ximian.com>
24230 * support.cs (InternalParameters): Constructor now takes an extra argument
24231 which is the actual Parameters class.
24233 (ParameterDesc): Update to provide info on ref/out modifiers.
24235 * class.cs (everywhere): Update call to InternalParameters to pass in
24236 the second argument too.
24238 * support.cs (ParameterData): Add ParameterModifier, which is a method
24239 to return the modifier info [ref/out etc]
24241 (InternalParameters, ReflectionParameters): Implement the above.
24243 * expression.cs (Argument::ParameterModifier): Similar function to return
24244 info about the argument's modifiers.
24246 (Invocation::OverloadResolve): Update to take into account matching modifiers
24249 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24250 a new SetFormalParameters object which we pass to InternalParameters.
24252 2001-10-30 Ravi Pratap <ravi@ximian.com>
24254 * expression.cs (NewArray): Merge into the ArrayCreation class.
24256 2001-10-29 Ravi Pratap <ravi@ximian.com>
24258 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24259 NewUserdefinedArray into one as there wasn't much of a use in having
24262 * expression.cs (Argument): Change field's name to ArgType from Type.
24264 (Type): New readonly property which returns the proper type, taking into
24265 account ref/out modifiers.
24267 (everywhere): Adjust code accordingly for the above.
24269 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24270 whether we are emitting for a ref or out parameter.
24272 * expression.cs (Argument::Emit): Use the above field to set the state.
24274 (LocalVariableReference::Emit): Update to honour the flag and emit the
24277 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24279 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24281 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24283 (ReflectionParameters, InternalParameters): Implement the above method.
24285 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24288 (Invocation::FullMethodDesc): Ditto.
24290 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24292 * cs-parser.jay: Add extra production for the second form of array
24295 * expression.cs (ArrayCreation): Update to reflect the above
24298 * Small changes to prepare for Array initialization.
24300 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24302 * typemanager.cs (ImplementsInterface): interface might be null;
24303 Deal with this problem;
24305 Also, we do store negative hits on the cache (null values), so use
24306 this instead of calling t.GetInterfaces on the type everytime.
24308 2001-10-28 Ravi Pratap <ravi@ximian.com>
24310 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24312 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24313 split functionality out into different classes.
24315 (New::FormArrayType): Move into NewBuiltinArray.
24317 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24320 (NewBuiltinArray): New class to handle creation of built-in arrays.
24322 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24323 account creation of one-dimensional arrays.
24325 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24327 (NewUserdefinedArray::DoResolve): Implement.
24329 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24331 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24332 we maintain inside the TypeManager. This is necessary to perform lookups on the
24335 (LookupType): Update to perform GetType on the module builders too.
24337 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24339 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24341 2001-10-23 Ravi Pratap <ravi@ximian.com>
24343 * expression.cs (New::DoResolve): Implement guts of array creation.
24345 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24347 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24349 * expression.cs: Fix bug I introduced lsat night that broke
24352 (Expression.Resolve): Report a 246 error (can not resolve name)
24353 if we find a SimpleName in the stream.
24355 (Expression.ResolveLValue): Ditto.
24357 (Expression.ResolveWithSimpleName): This function is a variant of
24358 ResolveName, this one allows SimpleNames to be returned without a
24359 warning. The only consumer of SimpleNames is MemberAccess
24361 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24363 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24364 might arrive here. I have my doubts that this is correct.
24366 * statement.cs (Lock): Implement lock statement.
24368 * cs-parser.jay: Small fixes to support `lock' and `using'
24370 * cs-tokenizer.cs: Remove extra space
24372 * driver.cs: New flag --checked, allows to turn on integer math
24375 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24376 Threading.Monitor.Exit
24378 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24380 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24381 Expression Class to be IndexerAccess.
24383 Notice that Indexer::DoResolve sets the eclass to Value.
24385 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24387 * class.cs (TypeContainer::Emit): Emit code for indexers.
24389 * assign.cs (IAssignMethod): New interface implemented by Indexers
24390 and Properties for handling assignment.
24392 (Assign::Emit): Simplify and reuse code.
24394 * expression.cs (IndexerAccess, PropertyExpr): Implement
24395 IAssignMethod, clean up old code.
24397 2001-10-22 Ravi Pratap <ravi@ximian.com>
24399 * typemanager.cs (ImplementsInterface): New method to determine if a type
24400 implements a given interface. Provides a nice cache too.
24402 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24405 (ConvertReferenceExplicit): Ditto.
24407 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24408 various methods, with correct names etc.
24410 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24411 Operator.UnaryNegation.
24413 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24414 we have a unary plus or minus operator.
24416 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24419 * everywhere : update accordingly.
24421 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24424 * class.cs (Method::Define): For the case where we are implementing a method
24425 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24426 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24428 2001-10-21 Ravi Pratap <ravi@ximian.com>
24430 * interface.cs (FindMembers): Implement to work around S.R.E
24433 * typemanager.cs (IsInterfaceType): Implement.
24435 (FindMembers): Update to handle interface types too.
24437 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24438 use IsAssignableFrom as that is not correct - it doesn't work.
24440 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24441 and accordingly override EmitStatement.
24443 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24444 using the correct logic :-)
24446 2001-10-19 Ravi Pratap <ravi@ximian.com>
24448 * ../errors/cs-11.cs : Add to demonstrate error -11
24450 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24452 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24453 then pass this as a hint to ResolveLValue.
24455 * expression.cs (FieldExpr): Add Location information
24457 (FieldExpr::LValueResolve): Report assignment to readonly
24460 (Expression::ExprClassFromMemberInfo): Pass location information.
24462 (Expression::ResolveLValue): Add new method that resolves an
24465 (Expression::DoResolveLValue): Default invocation calls
24468 (Indexers): New class used to keep track of indexers in a given
24471 (IStackStore): Renamed from LValue, as it did not really describe
24472 what this did. Also ResolveLValue is gone from this interface and
24473 now is part of Expression.
24475 (ElementAccess): Depending on the element access type
24477 * typemanager.cs: Add `indexer_name_type' as a Core type
24478 (System.Runtime.CompilerServices.IndexerNameAttribute)
24480 * statement.cs (Goto): Take a location.
24482 2001-10-18 Ravi Pratap <ravi@ximian.com>
24484 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24485 if two delegates are compatible.
24487 (NewDelegate::DoResolve): Update to take care of the case when
24488 we instantiate a delegate from another delegate.
24490 * typemanager.cs (FindMembers): Don't even try to look up members
24491 of Delegate types for now.
24493 2001-10-18 Ravi Pratap <ravi@ximian.com>
24495 * delegate.cs (NewDelegate): New class to take care of delegate
24498 * expression.cs (New): Split the delegate related code out into
24499 the NewDelegate class.
24501 * delegate.cs (DelegateInvocation): New class to handle delegate
24504 * expression.cs (Invocation): Split out delegate related code into
24505 the DelegateInvocation class.
24507 2001-10-17 Ravi Pratap <ravi@ximian.com>
24509 * expression.cs (New::DoResolve): Implement delegate creation fully
24510 and according to the spec.
24512 (New::DoEmit): Update to handle delegates differently.
24514 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24515 because of which we were printing out arguments in reverse order !
24517 * delegate.cs (VerifyMethod): Implement to check if the given method
24518 matches the delegate.
24520 (FullDelegateDesc): Implement.
24522 (VerifyApplicability): Implement.
24524 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24525 delegate invocations too.
24527 (Invocation::Emit): Ditto.
24529 * ../errors/cs1593.cs : Added.
24531 * ../errors/cs1594.cs : Added.
24533 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24535 2001-10-16 Ravi Pratap <ravi@ximian.com>
24537 * typemanager.cs (intptr_type): Core type for System.IntPtr
24539 (InitCoreTypes): Update for the same.
24541 (iasyncresult_type, asynccallback_type): Ditto.
24543 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24546 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24549 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24550 the builders for the 4 members of a delegate type :-)
24552 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24555 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24557 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24559 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24561 * statement.cs (Break::Emit): Implement.
24562 (Continue::Emit): Implement.
24564 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24565 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24566 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24567 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24570 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24571 properties that track the label for the current loop (begin of the
24572 loop and end of the loop).
24574 2001-10-15 Ravi Pratap <ravi@ximian.com>
24576 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24577 use of emitting anything at all.
24579 * class.cs, rootcontext.cs : Get rid of calls to the same.
24581 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24583 (Populate): Define the constructor correctly and set the implementation
24586 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24589 (AddDelegateType): Implement.
24591 (IsDelegateType): Implement helper method.
24593 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24595 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24596 and accordingly handle it.
24598 * delegate.cs (Populate): Take TypeContainer argument.
24599 Implement bits to define the Invoke method. However, I still haven't figured out
24600 how to take care of the native int bit :-(
24602 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24603 Qualify the name of the delegate, not its return type !
24605 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24608 (StandardConversionExists): Checking for array types turns out to be recursive.
24610 (ConvertReferenceExplicit): Implement array conversion.
24612 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24614 2001-10-12 Ravi Pratap <ravi@ximian.com>
24616 * cs-parser.jay (delegate_declaration): Store the fully qualified
24617 name as it is a type declaration.
24619 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24622 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24623 as TypeContainer::DefineType.
24625 (Populate): Method in which all the definition of the various methods (Invoke)
24628 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24631 (CloseDelegate): Finally creates the delegate.
24633 * class.cs (TypeContainer::DefineType): Update to define delegates.
24634 (Populate, Emit and CloseType): Do the same thing here too.
24636 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24637 delegates in all these operations.
24639 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24641 * expression.cs: LocalTemporary: a new expression used to
24642 reference a temporary that has been created.
24644 * assign.cs: Handle PropertyAccess back here, so that we can
24645 provide the proper semantic access to properties.
24647 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24648 a few more explicit conversions.
24650 * modifiers.cs: `NEW' modifier maps to HideBySig.
24652 * expression.cs (PropertyExpr): Make this into an
24653 ExpressionStatement, and support the EmitStatement code path.
24655 Perform get/set error checking, clean up the interface.
24657 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24658 them into toplevel access objects.
24660 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24662 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24665 * typemanager.cs: Keep track here of our PropertyBuilders again to
24666 work around lameness in SRE.
24668 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24670 * expression.cs (LValue::LValueResolve): New method in the
24671 interface, used to perform a second resolution pass for LValues.
24673 (This::DoResolve): Catch the use of this in static methods.
24675 (This::LValueResolve): Implement.
24677 (This::Store): Remove warning, assigning to `this' in structures
24680 (Invocation::Emit): Deal with invocation of
24681 methods on value types. We need to pass the address to structure
24682 methods rather than the object itself. (The equivalent code to
24683 emit "this" for structures leaves the entire structure on the
24684 stack instead of a pointer to it).
24686 (ParameterReference::DoResolve): Compute the real index for the
24687 argument based on whether the method takes or not a `this' pointer
24688 (ie, the method is static).
24690 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24691 value types returned from functions when we need to invoke a
24692 method on the sturcture.
24695 2001-10-11 Ravi Pratap <ravi@ximian.com>
24697 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24698 defining the type in the Modulebuilder or Typebuilder. This is to take
24699 care of nested types which need to be defined on the TypeBuilder using
24700 DefineNestedMethod.
24702 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24703 methods in RootContext, only ported to be part of TypeContainer.
24705 (TypeContainer::GetInterfaceOrClass): Ditto.
24707 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24709 * interface.cs (Interface::DefineInterface): New method. Does exactly
24710 what RootContext.CreateInterface did earlier, only it takes care of nested types
24713 (Interface::GetInterfaces): Move from RootContext here and port.
24715 (Interface::GetInterfaceByName): Same here.
24717 * rootcontext.cs (ResolveTree): Re-write.
24719 (PopulateTypes): Re-write.
24721 * class.cs (TypeContainer::Populate): Populate nested types too.
24722 (TypeContainer::Emit): Emit nested members too.
24724 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24725 instead just use the name argument passed in as it is already fully
24728 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24729 to TypeContainer mapping to see if a type is user-defined.
24731 * class.cs (TypeContainer::CloseType): Implement.
24733 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24734 the default constructor.
24736 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24739 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24741 * interface.cs (CloseType): Create the type here.
24743 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24746 Remove all the methods which are now in TypeContainer.
24748 2001-10-10 Ravi Pratap <ravi@ximian.com>
24750 * delegate.cs (Define): Re-write bits to define the delegate
24753 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24755 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24757 * expression.cs (ImplicitReferenceConversion): handle null as well
24758 as a source to convert to any reference type.
24760 * statement.cs (Return): Perform any implicit conversions to
24761 expected return type.
24763 Validate use of return statement.
24765 * codegen.cs (EmitContext): Pass the expected return type here.
24767 * class.cs (Method, Constructor, Property): Pass expected return
24768 type to EmitContext.
24770 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24772 * expression.cs: Make DoResolve take an EmitContext instead of a
24775 Replaced `l' and `location' for `loc', for consistency.
24777 (Error, Warning): Remove unneeded Tc argument.
24779 * assign.cs, literal.cs, constant.cs: Update to new calling
24782 * codegen.cs: EmitContext now contains a flag indicating whether
24783 code is being generated in a static method or not.
24785 * cs-parser.jay: DecomposeQI, new function that replaces the old
24786 QualifiedIdentifier. Now we always decompose the assembled
24787 strings from qualified_identifier productions into a group of
24790 2001-10-08 Miguel de Icaza <miguel@ximian.com>
24792 * rootcontext.cs: Deal with field-less struct types correctly now
24793 by passing the size option to Define Type.
24795 * class.cs: Removed hack that created one static field.
24797 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24799 * statement.cs: Moved most of the code generation here.
24801 2001-10-09 Ravi Pratap <ravi@ximian.com>
24803 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
24806 (ElementAccess): Remove useless bits for now - keep checks as the spec
24809 2001-10-08 Ravi Pratap <ravi@ximian.com>
24811 * expression.cs (ElementAccess::DoResolve): Remove my crap code
24812 and start performing checks according to the spec.
24814 2001-10-07 Ravi Pratap <ravi@ximian.com>
24816 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
24817 rank_specifiers instead.
24819 (rank_specifiers): Change the order in which the rank specifiers are stored
24821 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
24823 * expression.cs (ElementAccess): Implement the LValue interface too.
24825 2001-10-06 Ravi Pratap <ravi@ximian.com>
24827 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
24828 except that user defined conversions are not included.
24830 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
24831 perform the conversion of the return type, if necessary.
24833 (New::DoResolve): Check whether we are creating an array or an object
24834 and accordingly do the needful.
24836 (New::Emit): Same here.
24838 (New::DoResolve): Implement guts of array creation.
24840 (New::FormLookupType): Helper function.
24842 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24844 * codegen.cs: Removed most of the code generation here, and move the
24845 corresponding code generation bits to the statement classes.
24847 Added support for try/catch/finalize and throw.
24849 * cs-parser.jay: Added support for try/catch/finalize.
24851 * class.cs: Catch static methods having the flags override,
24852 virtual or abstract.
24854 * expression.cs (UserCast): This user cast was not really doing
24855 what it was supposed to do. Which is to be born in fully resolved
24856 state. Parts of the resolution were being performed at Emit time!
24860 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24862 * expression.cs: Implicity convert the result from UserCast.
24864 2001-10-05 Ravi Pratap <ravi@ximian.com>
24866 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
24867 prevented it from working correctly.
24869 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
24870 merely ConvertImplicit.
24872 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24874 * typemanager.cs: Make the LookupTypeContainer function static,
24875 and not per-instance.
24877 * class.cs: Make static FindMembers (the one that takes a Type
24880 * codegen.cs: Add EmitForeach here.
24882 * cs-parser.jay: Make foreach a toplevel object instead of the
24883 inline expansion, as we need to perform semantic analysis on it.
24885 2001-10-05 Ravi Pratap <ravi@ximian.com>
24887 * expression.cs (Expression::ImplicitUserConversion): Rename to
24888 UserDefinedConversion.
24890 (Expression::UserDefinedConversion): Take an extra argument specifying
24891 whether we look for explicit user conversions too.
24893 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
24895 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
24897 (ExplicitUserConversion): Make it a call to UserDefinedConversion
24898 with the appropriate arguments.
24900 * cs-parser.jay (cast_expression): Record location too.
24902 * expression.cs (Cast): Record location info.
24904 (Expression::ConvertExplicit): Take location argument.
24906 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
24907 to determine if we are doing explicit conversions.
24909 (UserCast::Emit): Update accordingly.
24911 (Expression::ConvertExplicit): Report an error if everything fails.
24913 * ../errors/cs0030.cs : Add.
24915 2001-10-04 Miguel de Icaza <miguel@ximian.com>
24917 * modifiers.cs: If the ABSTRACT keyword is present, also set the
24918 virtual and newslot bits.
24920 * class.cs (TypeContainer::RegisterRequiredImplementations):
24921 Record methods we need.
24923 (TypeContainer::MakeKey): Helper function to make keys for
24924 MethodBases, since the Methodbase key is useless.
24926 (TypeContainer::Populate): Call RegisterRequiredImplementations
24927 before defining the methods.
24929 Create a mapping for method_builders_to_methods ahead of time
24930 instead of inside a tight loop.
24932 (::RequireMethods): Accept an object as the data to set into the
24933 hashtable so we can report interface vs abstract method mismatch.
24935 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24937 * report.cs: Make all of it static.
24939 * rootcontext.cs: Drop object_type and value_type computations, as
24940 we have those in the TypeManager anyways.
24942 Drop report instance variable too, now it is a global.
24944 * driver.cs: Use try/catch on command line handling.
24946 Add --probe option to debug the error reporting system with a test
24949 * report.cs: Add support for exiting program when a probe
24950 condition is reached.
24952 2001-10-03 Ravi Pratap <ravi@ximian.com>
24954 * expression.cs (Binary::DoNumericPromotions): Fix the case when
24955 we do a forcible conversion regardless of type, to check if
24956 ForceConversion returns a null.
24958 (Binary::error19): Use location to report error.
24960 (Unary::error23): Use location here too.
24962 * ../errors/cs0019.cs : Check in.
24964 * ../errors/cs0023.cs : Check in.
24966 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
24967 case of a non-null MethodInfo object with a length of 0 !
24969 (Binary::ResolveOperator): Flag error if overload resolution fails to find
24970 an applicable member - according to the spec :-)
24971 Also fix logic to find members in base types.
24973 (Unary::ResolveOperator): Same here.
24975 (Unary::report23): Change name to error23 and make first argument a TypeContainer
24976 as I was getting thoroughly confused between this and error19 :-)
24978 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
24979 (::FindMostEncompassedType): Implement.
24980 (::FindMostEncompassingType): Implement.
24981 (::StandardConversionExists): Implement.
24983 (UserImplicitCast): Re-vamp. We now need info about most specific
24984 source and target types so that we can do the necessary conversions.
24986 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
24987 mathematical union with no duplicates.
24989 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24991 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
24992 in order from base classes to child classes, so that we can in
24993 child classes look up in our parent for method names and
24994 attributes (required for handling abstract, virtual, new, override
24995 constructs: we need to instrospect our base class, and if we dont
24996 populate the classes in order, the introspection might be
24997 incorrect. For example, a method could query its parent before
24998 the parent has any methods and would determine that the parent has
24999 no abstract methods (while it could have had them)).
25001 (RootContext::CreateType): Record the order in which we define the
25004 2001-10-02 Miguel de Icaza <miguel@ximian.com>
25006 * class.cs (TypeContainer::Populate): Also method definitions can
25007 fail now, keep track of this.
25009 (TypeContainer::FindMembers): Implement support for
25010 DeclaredOnly/noDeclaredOnly flag.
25012 (Constructor::Emit) Return the ConstructorBuilder.
25014 (Method::Emit) Return the MethodBuilder.
25015 Check for abstract or virtual methods to be public.
25017 * rootcontext.cs (RootContext::CreateType): Register all the
25018 abstract methods required for the class to be complete and the
25019 interface methods that must be implemented.
25021 * cs-parser.jay: Report error 501 (method requires body if it is
25022 not marked abstract or extern).
25024 * expression.cs (TypeOf::Emit): Implement.
25026 * typemanager.cs: runtime_handle_type, new global type.
25028 * class.cs (Property::Emit): Generate code for properties.
25030 2001-10-02 Ravi Pratap <ravi@ximian.com>
25032 * expression.cs (Unary::ResolveOperator): Find operators on base type
25033 too - we now conform exactly to the spec.
25035 (Binary::ResolveOperator): Same here.
25037 * class.cs (Operator::Define): Fix minor quirk in the tests.
25039 * ../errors/cs0215.cs : Added.
25041 * ../errors/cs0556.cs : Added.
25043 * ../errors/cs0555.cs : Added.
25045 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25047 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
25048 single integer which is really efficient
25050 2001-10-01 Ravi Pratap <ravi@ximian.com>
25052 * expression.cs (Expression::ImplicitUserConversion): Use location
25053 even in the case when we are examining True operators.
25055 * class.cs (Operator::Define): Perform extensive checks to conform
25056 with the rules for operator overloading in the spec.
25058 * expression.cs (Expression::ImplicitReferenceConversion): Implement
25059 some of the other conversions mentioned in the spec.
25061 * typemanager.cs (array_type): New static member for the System.Array built-in
25064 (cloneable_interface): For System.ICloneable interface.
25066 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
25067 we start resolving the tree and populating types.
25069 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
25071 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25073 * expression.cs (Expression::ExprClassFromMemberInfo,
25074 Expression::Literalize): Create literal expressions from
25075 FieldInfos which are literals.
25077 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
25078 type casts, because they were wrong. The test suite in tests
25081 (ImplicitNumericConversion): ushort to ulong requires a widening
25084 Int32 constant to long requires widening cast as well.
25086 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
25087 for integers because the type on the stack is not i4.
25089 2001-09-30 Miguel de Icaza <miguel@ximian.com>
25091 * expression.cs (report118): require location argument.
25093 * parameter.cs: Do not dereference potential null value.
25095 * class.cs: Catch methods that lack the `new' keyword when
25096 overriding a name. Report warnings when `new' is used without
25097 anything being there to override.
25099 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
25101 * class.cs: Only add constructor to hashtable if it is non-null
25102 (as now constructors can fail on define).
25104 (TypeManager, Class, Struct): Take location arguments.
25106 Catch field instance initialization in structs as errors.
25108 accepting_filter: a new filter for FindMembers that is static so
25109 that we dont create an instance per invocation.
25111 (Constructor::Define): Catch errors where a struct constructor is
25114 * cs-parser.jay: Pass location information for various new
25117 * delegate.cs (Delegate): take a location argument.
25119 * driver.cs: Do not call EmitCode if there were problesm in the
25120 Definition of the types, as many Builders wont be there.
25122 * decl.cs (Decl::Decl): Require a location argument.
25124 * cs-tokenizer.cs: Handle properly hex constants that can not fit
25125 into integers, and find the most appropiate integer for it.
25127 * literal.cs: Implement ULongLiteral.
25129 * rootcontext.cs: Provide better information about the location of
25130 failure when CreateType fails.
25132 2001-09-29 Miguel de Icaza <miguel@ximian.com>
25134 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
25137 * expression.cs (Binary::CheckShiftArguments): Add missing type
25139 (Binary::ResolveOperator): Add type to the logical and and logical
25140 or, Bitwise And/Or and Exclusive Or code paths, it was missing
25143 (Binary::DoNumericPromotions): In the case where either argument
25144 is ulong (and most signed types combined with ulong cause an
25145 error) perform implicit integer constant conversions as well.
25147 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25149 * expression.cs (UserImplicitCast): Method should always be
25151 (Invocation::BetterConversion): Simplified test for IntLiteral.
25153 (Expression::ImplicitNumericConversion): Split this routine out.
25154 Put the code that performs implicit constant integer conversions
25157 (Expression::Resolve): Become a wrapper around DoResolve so we can
25158 check eclass and type being set after resolve.
25160 (Invocation::Badness): Remove this dead function
25162 (Binary::ResolveOperator): Do not compute the expensive argumnets
25163 unless we have a union for it.
25165 (Probe::Emit): Is needs to do an isinst and then
25166 compare against null.
25168 (::CanConvert): Added Location argument. If the Location argument
25169 is null (Location.Null), then we do not report errors. This is
25170 used by the `probe' mechanism of the Explicit conversion. We do
25171 not want to generate an error for something that the user
25172 explicitly requested to be casted. But the pipeline for an
25173 explicit cast first tests for potential implicit casts.
25175 So for now, if the Location is null, it means `Probe only' to
25176 avoid adding another argument. Might have to revise this
25179 (ClassCast): New class used to type cast objects into arbitrary
25180 classes (used in Explicit Reference Conversions).
25182 Implement `as' as well.
25184 Reverted all the patches from Ravi below: they were broken:
25186 * The use of `level' as a mechanism to stop recursive
25187 invocations is wrong. That was there just to catch the
25188 bug with a strack trace but not as a way of addressing
25191 To fix the problem we have to *understand* what is going
25192 on and the interactions and come up with a plan, not
25193 just get things going.
25195 * The use of the type conversion cache that I proposed
25196 last night had an open topic: How does this work across
25197 protection domains. A user defined conversion might not
25198 be public in the location where we are applying the
25199 conversion, a different conversion might be selected
25200 (ie, private A->B (better) but public B->A (worse),
25201 inside A, A->B applies, but outside it, B->A will
25204 * On top of that (ie, even if the above is solved),
25205 conversions in a cache need to be abstract. Ie, `To
25206 convert from an Int to a Short use an OpcodeCast', not
25207 `To convert from an Int to a Short use the OpcodeCast on
25208 the variable 5' (which is what this patch was doing).
25210 2001-09-28 Ravi Pratap <ravi@ximian.com>
25212 * expression.cs (Invocation::ConversionExists): Re-write to use
25213 the conversion cache
25215 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25216 cache all conversions done, not just user-defined ones.
25218 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25219 to determine if a conversion exists instead of acutually trying to
25220 perform the conversion. It's faster too.
25222 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25223 and only then attempt the implicit conversion.
25225 2001-09-28 Ravi Pratap <ravi@ximian.com>
25227 * expression.cs (ConvertImplicit): Use a cache for conversions
25228 already found. Check level of recursion and bail out if necessary.
25230 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25232 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25233 Export standard methods that we expect for string operations.
25235 * statement.cs (Block::UsageWarning): Track usage of variables and
25236 report the errors for not used variables.
25238 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25241 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25243 * codegen.cs: remove unnneded code
25245 * expression.cs: Removed BuiltinTypeAccess class
25247 Fix the order in which implicit conversions are
25250 The previous fixed dropped support for boxed conversions (adding a
25251 test to the test suite now)
25253 (UserImplicitCast::CanConvert): Remove test for source being null,
25254 that code is broken. We should not feed a null to begin with, if
25255 we do, then we should track the bug where the problem originates
25256 and not try to cover it up here.
25258 Return a resolved expression of type UserImplicitCast on success
25259 rather than true/false. Ravi: this is what I was talking about,
25260 the pattern is to use a static method as a "constructor" for
25263 Also, do not create arguments until the very last minute,
25264 otherwise we always create the arguments even for lookups that
25265 will never be performed.
25267 (UserImplicitCast::Resolve): Eliminate, objects of type
25268 UserImplicitCast are born in a fully resolved state.
25270 * typemanager.cs (InitCoreTypes): Init also value_type
25271 (System.ValueType).
25273 * expression.cs (Cast::Resolve): First resolve the child expression.
25275 (LValue): Add new method AddressOf to be used by
25278 Change the argument of Store to take an EmitContext instead of an
25279 ILGenerator, because things like FieldExpr need to be able to call
25280 their children expression to generate the instance code.
25282 (Expression::Error, Expression::Warning): Sugar functions for
25285 (Expression::MemberLookup): Accept a TypeContainer instead of a
25286 Report as the first argument.
25288 (Expression::ResolvePrimary): Killed. I still want to improve
25289 this as currently the code is just not right.
25291 (Expression::ResolveMemberAccess): Simplify, but it is still
25294 (Unary::Resolve): Catch errors in AddressOf operators.
25296 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25297 index to a byte for the short-version, or the compiler will choose
25298 the wrong Emit call, which generates the wrong data.
25300 (ParameterReference::Emit, ::Store): same.
25302 (FieldExpr::AddressOf): Implement.
25304 * typemanager.cs: TypeManager: made public variable instead of
25307 * driver.cs: document --fatal.
25309 * report.cs (ErrorMessage, WarningMessage): new names for the old
25310 Error and Warning classes.
25312 * cs-parser.jay (member_access): Turn built-in access to types
25313 into a normal simplename
25315 2001-09-27 Ravi Pratap <ravi@ximian.com>
25317 * expression.cs (Invocation::BetterConversion): Fix to cope
25318 with q being null, since this was introducing a bug.
25320 * expression.cs (ConvertImplicit): Do built-in conversions first.
25322 2001-09-27 Ravi Pratap <ravi@ximian.com>
25324 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25326 2001-09-27 Ravi Pratap <ravi@ximian.com>
25328 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25329 I had introduced long ago (what's new ?).
25331 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25332 the work of all the checking.
25333 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25334 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25336 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25337 that is the right way.
25339 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25340 overloading resolution. Use everywhere instead of cutting and pasting code.
25342 (Binary::ResolveOperator): Use MakeUnionSet.
25344 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25345 we have to convert to bool types. Not complete yet.
25347 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25349 * typemanager.cs (TypeManager::CSharpName): support ushort.
25351 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25352 to provide an expression that performsn an implicit constant int
25353 conversion (section 6.1.6).
25354 (Expression::ConvertImplicitRequired): Reworked to include
25355 implicit constant expression conversions.
25357 (Expression::ConvertNumericExplicit): Finished.
25359 (Invocation::Emit): If InstanceExpression is null, then it means
25360 that we perform a call on this.
25362 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25364 * expression.cs (Unary::Emit): Remove some dead code.
25365 (Probe): Implement Resolve and Emit for `is'.
25366 (Expression::ConvertImplicitRequired): Attempt to do constant
25367 expression conversions here. Maybe should be moved to
25368 ConvertImplicit, but I am not sure.
25369 (Expression::ImplicitLongConstantConversionPossible,
25370 Expression::ImplicitIntConstantConversionPossible): New functions
25371 that tell whether is it possible to apply an implicit constant
25372 expression conversion.
25374 (ConvertNumericExplicit): Started work on explicit numeric
25377 * cs-parser.jay: Update operator constants.
25379 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25380 (Parameters::GetSignature): Hook up VerifyArgs here.
25381 (Parameters::VerifyArgs): Verifies that no two arguments have the
25384 * class.cs (Operator): Update the operator names to reflect the
25385 ones that the spec expects (as we are just stringizing the
25388 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25389 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25390 previous usage did only work for our methods.
25391 (Expression::ConvertImplicit): Handle decimal implicit numeric
25392 conversions as well.
25393 (Expression::InternalTypeConstructor): Used to invoke constructors
25394 on internal types for default promotions.
25396 (Unary::Emit): Implement special handling for the pre/post
25397 increment/decrement for overloaded operators, as they need to have
25398 the same semantics as the other operators.
25400 (Binary::ResolveOperator): ditto.
25401 (Invocation::ConversionExists): ditto.
25402 (UserImplicitCast::Resolve): ditto.
25404 2001-09-26 Ravi Pratap <ravi@ximian.com>
25406 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25407 operator, return after emitting body. Regression tests pass again !
25409 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25410 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25411 (Invocation::OverloadResolve): Ditto.
25412 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25414 * everywhere : update calls to the above methods accordingly.
25416 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25418 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25420 * expression.cs (ExpressionStatement): New base class used for
25421 expressions that can appear in statements, so that we can provide
25422 an alternate path to generate expression that do not leave a value
25425 (Expression::Emit, and all the derivatives): We no longer return
25426 whether a value is left on the stack or not. Every expression
25427 after being emitted leaves a single value on the stack.
25429 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25430 facilties of ExpressionStatement if possible.
25432 * cs-parser.jay: Update statement_expression.
25434 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25436 * driver.cs: Change the wording of message
25438 2001-09-25 Ravi Pratap <ravi@ximian.com>
25440 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25441 the type of the expression to the return type of the method if
25442 we have an overloaded operator match ! The regression tests pass again !
25443 (Unary::ResolveOperator): Ditto.
25445 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25446 to find "op_Implicit", not "implicit" ;-)
25447 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25448 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25450 * everywhere : Correct calls to the above accordingly.
25452 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25453 (ConvertImplicit): Do user-defined conversion if it exists.
25455 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25457 * assign.cs: track location.
25458 (Resolve): Use implicit conversions on assignment.
25460 * literal.cs: Oops. Not good, Emit of short access values should
25461 pass (Bytes) or the wrong argument will be selected.
25463 * expression.cs (Unary::Emit): Emit code for -expr.
25465 (Unary::ResolveOperator): Handle `Substract' for non-constants
25466 (substract from zero from the non-constants).
25467 Deal with Doubles as well.
25469 (Expression::ConvertImplicitRequired): New routine that reports an
25470 error if no implicit conversion exists.
25472 (Invocation::OverloadResolve): Store the converted implicit
25473 expressions if we make them
25475 2001-09-24 Ravi Pratap <ravi@ximian.com>
25477 * class.cs (ConstructorInitializer): Take a Location argument.
25478 (ConstructorBaseInitializer): Same here.
25479 (ConstructorThisInitializer): Same here.
25481 * cs-parser.jay : Update all calls accordingly.
25483 * expression.cs (Unary, Binary, New): Take location argument.
25484 Update accordingly everywhere.
25486 * cs-parser.jay : Update all calls to the above to take a location
25489 * class.cs : Ditto.
25491 2001-09-24 Ravi Pratap <ravi@ximian.com>
25493 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25494 (Invocation::BetterConversion): Same here
25495 (Invocation::ConversionExists): Ditto.
25497 (Invocation::ConversionExists): Implement.
25499 2001-09-22 Ravi Pratap <ravi@ximian.com>
25501 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25502 Also take an additional TypeContainer argument.
25504 * All over : Pass in TypeContainer as argument to OverloadResolve.
25506 * typemanager.cs (CSharpName): Update to check for the string type and return
25509 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25512 2001-09-21 Ravi Pratap <ravi@ximian.com>
25514 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25515 (Invocation::BetterFunction): Implement.
25516 (Invocation::BetterConversion): Implement.
25517 (Invocation::ConversionExists): Skeleton, no implementation yet.
25519 Okay, things work fine !
25521 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25523 * typemanager.cs: declare and load enum_type, delegate_type and
25526 * expression.cs (Expression::Emit): Now emit returns a value that
25527 tells whether a value is left on the stack or not. This strategy
25528 might be reveted tomorrow with a mechanism that would address
25529 multiple assignments.
25530 (Expression::report118): Utility routine to report mismatches on
25533 (Unary::Report23): Report impossible type/operator combination
25536 (Unary::IsIncrementableNumber): Whether the type can be
25537 incremented or decremented with add.
25538 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25540 (Unary::ResolveOperator): Implement ++, !, ~,
25542 (Invocation::Emit): Deal with new Emit convetion.
25544 * All Expression derivatives: Updated their Emit method to return
25545 whether they leave values on the stack or not.
25547 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25548 stack for expressions that are statements.
25550 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25552 * expression.cs (LValue): New interface. Must be implemented by
25554 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25557 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25558 interface for generating code, simplifies the code.
25560 2001-09-20 Ravi Pratap <ravi@ximian.com>
25562 * expression.cs (everywhere): Comment out return statements in ::Resolve
25563 methods to avoid the warnings.
25565 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25567 * driver.cs (parse): Report error 2001 if we can not open the
25570 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25573 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25576 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25577 otherwise nested blocks end up with the same index.
25579 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25581 * expression.cs: Instead of having FIXMEs in the Resolve
25582 functions, throw exceptions so it is obvious that we are facing a
25585 * cs-parser.jay (invocation_expression): Pass Location information.
25587 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25588 Use a basename for those routines because .NET does not like paths
25591 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25594 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25596 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25597 are loading the correct data types (throws an exception if not).
25598 (TypeManager::InitCoreTypes): Use CoreLookupType
25600 * expression.cs (Unary::ResolveOperator): return the child
25601 expression for expressions which are just +expr.
25602 (Unary::ResolveOperator): Return negative literals for -LITERAL
25603 expressions (otherwise they are Unary {Literal}).
25604 (Invocation::Badness): Take into account `Implicit constant
25605 expression conversions'.
25607 * literal.cs (LongLiteral): Implement long literal class.
25608 (IntLiteral): export the `Value' of the intliteral.
25610 2001-09-19 Ravi Pratap <ravi@ximian.com>
25612 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25614 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25615 instead of 'Operator'
25617 * expression.cs (Binary::ResolveOperator): Update accordingly.
25618 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25621 * cs-parser.jay (unary_expression): Update to use the new names.
25623 * gen-treedump.cs (GetUnary): Same here.
25625 * expression.cs (Unary::Resolve): Implement.
25626 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25627 operators are found instead of making noise ;-)
25628 (Unary::ResolveOperator): New method to do precisely the same thing which
25629 Binary::ResolveOperator does for Binary expressions.
25630 (Unary.method, .Arguments): Add.
25631 (Unary::OperName): Implement.
25632 (Unary::ForceConversion): Copy and Paste !
25634 * class.cs (Operator::Define): Fix a small bug for the case when we have
25637 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25638 for the inbuilt operators. Only overloading works for now ;-)
25640 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25642 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25643 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25645 * expression.cs (This::Emit): Implement.
25646 (This::Resolve): Implement.
25647 (TypeOf:Resolve): Implement.
25648 (Expression::ResolveSimpleName): Add an implicit this to instance
25650 (MemberAccess::Resolve): Deal with Parameters and Fields.
25651 Bind instance variable to Field expressions.
25652 (FieldExpr::Instance): New field used to track the expression that
25653 represents the object instance.
25654 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25656 (FieldExpr::Emit): Implement.
25658 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25659 the last instruction contains a return opcode to avoid generating
25660 the last `ret' instruction (this generates correct code, and it is
25661 nice to pass the peverify output).
25663 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25664 initializer for static and instance variables.
25665 (Constructor::Emit): Allow initializer to be null in the case of
25666 static constructors. Only emit initializer for instance
25669 (TypeContainer::FindMembers): Return a null array if there are no
25672 Also fix the code for the MemberTypes.Method branch, as it was not
25673 scanning that for operators (or tried to access null variables before).
25675 * assign.cs (Assign::Emit): Handle instance and static fields.
25679 * driver.cs: Stop compilation if there are parse errors.
25681 * cs-parser.jay (constructor_declaration): Provide default base
25682 initializer for non-static constructors.
25683 (constructor_declarator): Do not provide a default base
25684 initializers if none was specified.
25685 Catch the fact that constructors should not have parameters.
25687 * class.cs: Do not emit parent class initializers for static
25688 constructors, that should be flagged as an error.
25690 2001-09-18 Ravi Pratap <ravi@ximian.com>
25692 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25693 Move back code into TypeContainer::Populate.
25695 2001-09-18 Ravi Pratap <ravi@ximian.com>
25697 * class.cs (TypeContainer::AddConstructor): Fix the check to
25698 compare against Name, not Basename.
25699 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25701 * cs-parser.jay : Update accordingly.
25703 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25704 for methods, don't forget to look into the operators too.
25705 (RegisterMethodBuilder): Helper method to take care of this for
25706 methods, constructors and operators.
25707 (Operator::Define): Completely revamp.
25708 (Operator.OperatorMethod, MethodName): New fields.
25709 (TypeContainer::Populate): Move the registering of builders into
25710 RegisterMethodBuilder.
25711 (Operator::Emit): Re-write.
25713 * expression.cs (Binary::Emit): Comment out code path to emit method
25714 invocation stuff for the case when we have a user defined operator. I am
25715 just not able to get it right !
25717 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25719 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25722 (Expression::MemberLookup): Provide a version that allows to
25723 specify the MemberTypes and BindingFlags.
25725 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25726 so it was not fetching variable information from outer blocks.
25728 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25729 Beforefieldinit as it was buggy.
25731 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25732 that Ravi put here.
25734 * class.cs (Constructor::Emit): Only emit if block is not null.
25735 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25736 deal with this by semantically definining it as if the user had
25739 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25740 constructors as we now "emit" them at a higher level.
25742 (TypeContainer::DefineDefaultConstructor): Used to define the
25743 default constructors if none was provided.
25745 (ConstructorInitializer): Add methods Resolve and Emit.
25747 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25749 2001-09-17 Ravi Pratap <ravi@ximian.com>
25751 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25752 the default constructor builder with our hashtable for methodbuilders
25755 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25756 and argument_count is 0 in which case we have a match.
25757 (Binary::ResolveOperator): More null checking and miscellaneous coding
25760 2001-09-17 Ravi Pratap <ravi@ximian.com>
25762 * rootcontext.cs (IsNameSpace): Compare against null.
25764 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25766 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25767 and Unary::Operator.
25769 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25772 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25773 we have overloaded operators.
25774 (Binary::ResolveOperator): Implement the part which does the operator overload
25777 * class.cs (Operator::Emit): Implement.
25778 (TypeContainer::Emit): Emit the operators we have too.
25780 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25781 the case when we have a user-defined operator.
25783 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25785 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
25787 2001-09-16 Ravi Pratap <ravi@ximian.com>
25789 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
25790 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
25791 (Constructor::Emit): Implement.
25792 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
25793 if we have no work to do.
25794 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
25797 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
25798 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
25800 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
25803 2001-09-15 Ravi Pratap <ravi@ximian.com>
25805 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
25807 (Tree::RecordNamespace): Method to do what the name says ;-)
25808 (Tree::Namespaces): Property to get at the namespaces hashtable.
25810 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
25813 * rootcontext.cs (IsNamespace): Fixed it :-)
25815 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25817 * class.cs (TypeContainer::FindMembers): Add support for
25819 (MethodCore): New class that encapsulates both the shared aspects
25820 of a Constructor and a Method.
25821 (Method, Constructor): Factored pieces into MethodCore.
25823 * driver.cs: Added --fatal which makes errors throw exceptions.
25824 Load System assembly as well as part of the standard library.
25826 * report.cs: Allow throwing exceptions on errors for debugging.
25828 * modifiers.cs: Do not use `parent', instead use the real type
25829 container to evaluate permission settings.
25831 * class.cs: Put Ravi's patch back in. He is right, and we will
25832 have to cope with the
25834 2001-09-14 Ravi Pratap <ravi@ximian.com>
25836 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
25837 FamORAssem, not FamANDAssem.
25839 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25841 * driver.cs: Added --parse option that only parses its input files
25844 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
25845 incorrect. IsTopLevel is not used to tell whether an object is
25846 root_types or not (that can be achieved by testing this ==
25847 root_types). But to see if this is a top-level *class* (not
25848 necessarly our "toplevel" container).
25850 2001-09-14 Ravi Pratap <ravi@ximian.com>
25852 * enum.cs (Enum::Define): Modify to call the Lookup method on the
25853 parent instead of a direct call to GetType.
25855 2001-09-14 Ravi Pratap <ravi@ximian.com>
25857 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
25858 Modifiers.TypeAttr. This should just be a call to that method.
25860 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
25861 object so that we can determine if we are top-level or not.
25863 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
25866 * enum.cs (Enum::Define): Ditto.
25868 * modifiers.cs (FieldAttr): Re-write.
25870 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
25871 (TypeContainer::HaveStaticConstructor): New property to provide access
25872 to precisely that info.
25874 * modifiers.cs (MethodAttr): Re-write.
25875 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
25877 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
25878 of top-level types as claimed.
25880 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25882 * expression.cs (MemberLookup): Fruitless attempt to lookup
25883 constructors. Maybe I need to emit default constructors? That
25884 might be it (currently .NET emits this for me automatically).
25885 (Invocation::OverloadResolve): Cope with Arguments == null.
25886 (Invocation::EmitArguments): new function, shared by the new
25887 constructor and us.
25888 (Invocation::Emit): Handle static and instance methods. Emit
25889 proper call instruction for virtual or non-virtual invocations.
25890 (New::Emit): Implement.
25891 (New::Resolve): Implement.
25892 (MemberAccess:Resolve): Implement.
25893 (MethodGroupExpr::InstanceExpression): used conforming to the spec
25894 to track instances.
25895 (FieldExpr::Resolve): Set type.
25897 * support.cs: Handle empty arguments.
25899 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
25900 SimpleLookup): Auxiliary routines to help parse a qualifier
25903 Update qualifier_identifier rule.
25905 * codegen.cs: Removed debugging messages.
25907 * class.cs: Make this a global thing, this acts just as a "key" to
25908 objects that we might have around.
25910 (Populate): Only initialize method_builders_to_methods once.
25912 * expression.cs (PropertyExpr): Initialize type from the
25915 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
25916 Resolve pattern. Attempt to implicitly convert value to boolean.
25919 * expression.cs: Set the type for the int32/int32 argument case.
25920 (Binary::ResolveOperator): Set the return type to boolean for
25921 comparission operators
25923 * typemanager.cs: Remove debugging print code.
25925 (Invocation::Resolve): resolve type.
25927 * class.cs: Allocate a MemberInfo of the correct size, as the code
25928 elsewhere depends on the test to reflect the correct contents.
25930 (Method::) Keep track of parameters, due to System.Reflection holes
25932 (TypeContainer::Populate): Keep track of MethodBuilders to Method
25935 (TypeContainer::FindMembers): Use ArrayList and then copy an array
25936 of the exact size and return that.
25938 (Class::LookupMethodByBuilder): New function that maps
25939 MethodBuilders to its methods. Required to locate the information
25940 on methods because System.Reflection bit us again.
25942 * support.cs: New file, contains an interface ParameterData and
25943 two implementations: ReflectionParameters and InternalParameters
25944 used to access Parameter information. We will need to grow this
25947 * expression.cs (Invocation::GetParameterData): implement a cache
25948 and a wrapper around the ParameterData creation for methods.
25949 (Invocation::OverloadResolve): Use new code.
25951 2001-09-13 Ravi Pratap <ravi@ximian.com>
25953 * class.cs (TypeContainer::EmitField): Remove and move into
25954 (Field::Define): here and modify accordingly.
25955 (Field.FieldBuilder): New member.
25956 (TypeContainer::Populate): Update accordingly.
25957 (TypeContainer::FindMembers): Implement.
25959 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25961 * statement.cs: (VariableInfo::VariableType): New field to be
25962 initialized with the full type once it is resolved.
25964 2001-09-12 Miguel de Icaza <miguel@ximian.com>
25966 * parameter.cs (GetParameterInfo): Use a type cache to compute
25967 things only once, and to reuse this information
25969 * expression.cs (LocalVariableReference::Emit): Implement.
25970 (OpcodeCast::Emit): fix.
25972 (ParameterReference::Resolve): Implement.
25973 (ParameterReference::Emit): Implement.
25975 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
25976 that are expressions need to stay as Expressions.
25978 * typemanager.cs (CSharpName): Returns the C# name of a type if
25981 * expression.cs (Expression::ConvertImplicit): New function that
25982 implements implicit type conversions.
25984 (Expression::ImplicitReferenceConversion): Implements implicit
25985 reference conversions.
25987 (EmptyCast): New type for transparent casts.
25989 (OpcodeCast): New type for casts of types that are performed with
25990 a sequence of bytecodes.
25992 (BoxedCast): New type used for casting value types into reference
25993 types. Emits a box opcode.
25995 (Binary::DoNumericPromotions): Implements numeric promotions of
25996 and computation of the Binary::Type.
25998 (Binary::EmitBranchable): Optimization.
26000 (Binary::Emit): Implement code emission for expressions.
26002 * typemanager.cs (TypeManager): Added two new core types: sbyte
26005 2001-09-12 Ravi Pratap <ravi@ximian.com>
26007 * class.cs (TypeContainer::FindMembers): Method which does exactly
26008 what Type.FindMembers does, only we don't have to use reflection. No
26009 implementation yet.
26011 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
26012 typecontainer objects as we need to get at them.
26013 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
26015 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
26016 typecontainer object.
26018 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
26019 of just a Report object.
26021 2001-09-11 Ravi Pratap <ravi@ximian.com>
26023 * class.cs (Event::Define): Go back to using the prefixes "add_" and
26025 (TypeContainer::Populate): Now define the delegates of the type too.
26026 (TypeContainer.Delegates): Property to access the list of delegates defined
26029 * delegates.cs (Delegate::Define): Implement partially.
26031 * modifiers.cs (TypeAttr): Handle more flags.
26033 2001-09-11 Ravi Pratap <ravi@ximian.com>
26035 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
26037 (Operator::Define): Re-write logic to get types by using the LookupType method
26038 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
26039 (Indexer::Define): Ditto.
26040 (Event::Define): Ditto.
26041 (Property::Define): Ditto.
26043 2001-09-10 Ravi Pratap <ravi@ximian.com>
26045 * class.cs (TypeContainer::Populate): Now define operators too.
26046 (TypeContainer.Operators): New property to access the list of operators
26048 (Operator.OperatorMethodBuilder): New member to hold the method builder
26049 for the operator we are defining.
26050 (Operator::Define): Implement.
26052 2001-09-10 Ravi Pratap <ravi@ximian.com>
26054 * class.cs (Event::Define): Make the prefixes of the accessor methods
26055 addOn_ and removeOn_
26057 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
26058 of the location being passed in too. Ideally, this should go later since all
26059 error reporting should be done through the Report object.
26061 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
26062 (Populate): Iterate thru the indexers we have and define them too.
26063 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
26064 for the get and set accessors.
26065 (Indexer::Define): Implement.
26067 2001-09-09 Miguel de Icaza <miguel@ximian.com>
26069 * expression.cs (Binary::Resolve): Beginning of it. I scratched
26070 my previous implementation, did not work.
26072 * typemanager.cs: Add a couple of missing types (the longs).
26074 * literal.cs: Use TypeManager.bool_type instead of getting it.
26076 * expression.cs (EventExpr): New kind of expressions.
26077 (Expressio::ExprClassFromMemberInfo): finish
26079 2001-09-08 Miguel de Icaza <miguel@ximian.com>
26081 * assign.cs: Emit stores to static fields differently.
26083 2001-09-08 Ravi Pratap <ravi@ximian.com>
26085 * Merge in changes and adjust code to tackle conflicts. Backed out my
26086 code in Assign::Resolve ;-)
26088 2001-09-08 Ravi Pratap <ravi@ximian.com>
26090 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
26091 instead Report.Error and also pass in the location.
26092 (CSharpParser::Lexer): New readonly property to return the reference
26093 to the Tokenizer object.
26094 (declare_local_variables): Use Report.Error with location instead of plain
26098 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
26099 (Operator.CheckBinaryOperator): Ditto.
26101 * cs-parser.jay (operator_declarator): Update accordingly.
26103 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
26104 (CheckBinaryOperator): Same here.
26106 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
26107 on the name without any prefixes of namespace names etc. This is because we
26108 already might have something already fully qualified like
26109 'System.Console.WriteLine'
26111 * assign.cs (Resolve): Begin implementation. Stuck ;-)
26113 2001-09-07 Ravi Pratap <ravi@ximian.com>
26115 * cs-tokenizer.cs (location): Return a string which also contains
26118 * expression.cs (ElementAccess): New class for expressions of the
26119 type 'element access.'
26120 (BaseAccess): New class for expressions of the type 'base access.'
26121 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
26124 * cs-parser.jay (element_access): Implement action.
26125 (base_access): Implement actions.
26126 (checked_expression, unchecked_expression): Implement.
26128 * cs-parser.jay (local_variable_type): Correct and implement.
26129 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
26131 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
26133 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
26134 name and the specifiers.
26136 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
26138 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
26139 making them all public ;-)
26141 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
26144 2001-09-07 Miguel de Icaza <miguel@ximian.com>
26146 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
26148 (FieldExpr, PropertyExprs): New resolved expressions.
26149 (SimpleName::MemberStaticCheck): Perform static checks for access
26150 to non-static fields on static methods. Maybe this should be
26151 generalized for MemberAccesses.
26152 (SimpleName::ResolveSimpleName): More work on simple name
26155 * cs-parser.jay (primary_expression/qualified_identifier): track
26156 the parameter index.
26158 * codegen.cs (CodeGen::Save): Catch save exception, report error.
26159 (EmitContext::EmitBoolExpression): Chain to expression generation
26160 instead of temporary hack.
26161 (::EmitStatementExpression): Put generic expression code generation.
26163 * assign.cs (Assign::Emit): Implement variable assignments to
26164 local variables, parameters and fields.
26166 2001-09-06 Miguel de Icaza <miguel@ximian.com>
26168 * statement.cs (Block::GetVariableInfo): New method, returns the
26169 VariableInfo for a variable name in a block.
26170 (Block::GetVariableType): Implement in terms of GetVariableInfo
26172 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26173 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26175 2001-09-06 Ravi Pratap <ravi@ximian.com>
26177 * cs-parser.jay (operator_declaration): Continue on my quest : update
26178 to take attributes argument.
26179 (event_declaration): Ditto.
26180 (enum_declaration): Ditto.
26181 (indexer_declaration): Ditto.
26183 * class.cs (Operator::Operator): Update constructor accordingly.
26184 (Event::Event): Ditto.
26186 * delegate.cs (Delegate::Delegate): Same here.
26188 * enum.cs (Enum::Enum): Same here.
26190 2001-09-05 Ravi Pratap <ravi@ximian.com>
26192 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26194 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26196 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26197 being passed around as an arraylist.
26198 (Attributes::AddAttribute): Method to add attribute sections.
26200 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26201 (struct_declaration): Update accordingly.
26202 (constant_declaration): Update.
26203 (field_declaration): Update.
26204 (method_header): Update.
26205 (fixed_parameter): Update.
26206 (parameter_array): Ditto.
26207 (property_declaration): Ditto.
26208 (destructor_declaration): Ditto.
26210 * class.cs (Struct::Struct): Update constructors accordingly.
26211 (Class::Class): Ditto.
26212 (Field::Field): Ditto.
26213 (Method::Method): Ditto.
26214 (Property::Property): Ditto.
26215 (TypeContainer::OptAttribute): update property's return type.
26217 * interface.cs (Interface.opt_attributes): New member.
26218 (Interface::Interface): Update to take the extra Attributes argument.
26220 * parameter.cs (Parameter::Parameter): Ditto.
26222 * constant.cs (Constant::Constant): Ditto.
26224 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26225 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26226 the attributes as a parameter.
26227 (InterfaceProperty): Update constructor call.
26228 (InterfaceEvent): Ditto.
26229 (InterfaceMethod): Ditto.
26230 (InterfaceIndexer): Ditto.
26232 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26233 pass the attributes too.
26234 (interface_event_declaration): Ditto.
26235 (interface_property_declaration): Ditto.
26236 (interface_method_declaration): Ditto.
26237 (interface_declaration): Ditto.
26239 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26241 * class.cs (Method::Define): Track the "static Main" definition to
26242 create an entry point.
26244 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26245 EntryPoint if we find it.
26247 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26248 (EmitContext::ig): Make this variable public.
26250 * driver.cs: Make the default output file be the first file name
26251 with the .exe extension.
26253 Detect empty compilations
26255 Handle various kinds of output targets. Handle --target and
26256 rename -t to --dumper.
26258 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26259 methods inherited from Expression return now an Expression. This
26260 will is used during the tree rewriting as we resolve them during
26263 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26264 the spec. Missing entirely is the information about
26265 accessability of elements of it.
26267 (Expression::ExprClassFromMemberInfo): New constructor for
26268 Expressions that creates a fully initialized Expression based on
26269 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26272 (Invocation::Resolve): Begin implementing resolution of invocations.
26274 * literal.cs (StringLiteral): Implement Emit.
26276 2001-09-05 Ravi Pratap <ravi@ximian.com>
26278 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26281 2001-09-04 Ravi Pratap <ravi@ximian.com>
26283 * cs-parser.jay (attribute_arguments): Implement actions.
26284 (attribute): Fix bug in production. Implement action.
26285 (attribute_list): Implement.
26286 (attribute_target): Implement.
26287 (attribute_target_specifier, opt_target_specifier): Implement
26288 (CheckAttributeTarget): New method to check if the attribute target
26290 (attribute_section): Implement.
26291 (opt_attributes): Implement.
26293 * attribute.cs : New file to handle attributes.
26294 (Attribute): Class to hold attribute info.
26296 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26297 (attribute_section): Modify production to use 2 different rules to
26298 achieve the same thing. 1 s/r conflict down !
26299 Clean out commented, useless, non-reducing dimension_separator rules.
26301 * class.cs (TypeContainer.attributes): New member to hold list
26302 of attributes for a type.
26303 (Struct::Struct): Modify to take one more argument, the attribute list.
26304 (Class::Class): Ditto.
26305 (Field::Field): Ditto.
26306 (Method::Method): Ditto.
26307 (Property::Property): Ditto.
26309 * cs-parser.jay (struct_declaration): Update constructor call to
26310 pass in the attributes too.
26311 (class_declaration): Ditto.
26312 (constant_declaration): Ditto.
26313 (field_declaration): Ditto.
26314 (method_header): Ditto.
26315 (fixed_parameter): Ditto.
26316 (parameter_array): Ditto.
26317 (property_declaration): Ditto.
26319 * constant.cs (Constant::Constant): Update constructor similarly.
26320 Use System.Collections.
26322 * parameter.cs (Parameter::Parameter): Update as above.
26324 2001-09-02 Ravi Pratap <ravi@ximian.com>
26326 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26327 (TypeContainer.delegates): New member to hold list of delegates.
26329 * cs-parser.jay (delegate_declaration): Implement the action correctly
26330 this time as I seem to be on crack ;-)
26332 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26334 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26335 tell whether an identifier represents a namespace.
26337 * expression.cs (NamespaceExpr): A namespace expression, used only
26338 temporarly during expression resolution.
26339 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26340 utility functions to resolve names on expressions.
26342 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26344 * codegen.cs: Add hook for StatementExpressions.
26346 * class.cs: Fix inverted test for static flag in methods.
26348 2001-09-02 Ravi Pratap <ravi@ximian.com>
26350 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26351 to make it coincide with MS' number.
26352 (Operator::CheckBinaryOperator): Ditto.
26354 * ../errors/errors.txt : Remove error numbers added earlier.
26356 * ../errors/cs1019.cs : Test case for error # 1019
26358 * ../errros/cs1020.cs : Test case for error # 1020
26360 * cs-parser.jay : Clean out commented cruft.
26361 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26362 used anywhere - non-reducing rule.
26363 (namespace_declarations): Non-reducing rule - comment out.
26365 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26366 with TypeContainer::AddEnum.
26368 * delegate.cs : New file for delegate handling classes.
26369 (Delegate): Class for declaring delegates.
26371 * makefile : Update.
26373 * cs-parser.jay (delegate_declaration): Implement.
26375 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26377 * class.cs (Event::Define): Implement.
26378 (Event.EventBuilder): New member.
26380 * class.cs (TypeContainer::Populate): Update to define all enums and events
26382 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26383 readonly fields for all these cases ?
26385 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26387 * class.cs (Property): Revamp to use the convention of making fields readonly.
26388 Accordingly modify code elsewhere.
26390 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26391 the Define method of the Property class.
26393 * class.cs : Clean up applied patch and update references to variables etc. Fix
26395 (TypeContainer::Populate): Update to define all the properties we have. Also
26396 define all enumerations.
26398 * enum.cs (Define): Implement.
26400 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26402 * cs-parser.jay (overloadable_operator): The semantic value is an
26403 enum of the Operator class.
26404 (operator_declarator): Implement actions.
26405 (operator_declaration): Implement.
26407 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26408 validity of definitions.
26409 (Operator::CheckBinaryOperator): Static method to check for binary operators
26410 (TypeContainer::AddOperator): New method to add an operator to a type.
26412 * cs-parser.jay (indexer_declaration): Added line to actually call the
26413 AddIndexer method so it gets added ;-)
26415 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26416 already taken care of by the MS compiler ?
26418 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26420 * class.cs (Operator): New class for operator declarations.
26421 (Operator::OpType): Enum for the various operators.
26423 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26425 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26426 ostensibly handle this in semantic analysis.
26428 * cs-parser.jay (general_catch_clause): Comment out
26429 (specific_catch_clauses, specific_catch_clause): Ditto.
26430 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26431 (catch_args, opt_catch_args): New productions.
26432 (catch_clause): Rewrite to use the new productions above
26433 (catch_clauses): Modify accordingly.
26434 (opt_catch_clauses): New production to use in try_statement
26435 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26436 and re-write the code in the actions to extract the specific and
26437 general catch clauses by being a little smart ;-)
26439 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26440 Hooray, try and catch statements parse fine !
26442 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26444 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26445 string from the hashtable of variables.
26447 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26448 I end up making that mistake ;-)
26449 (catch_clauses): Fixed gross error which made Key and Value of the
26450 DictionaryEntry the same : $1 !!
26452 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26454 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26456 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26457 when the add and remove accessors are specified.
26459 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26461 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26462 information about indexer_declarator.
26463 (indexer_declarator): Implement actions.
26464 (parsing_indexer): New local boolean used to keep track of whether
26465 we are parsing indexers or properties. This is necessary because
26466 implicit_parameters come into picture even for the get accessor in the
26467 case of an indexer.
26468 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26470 * class.cs (Indexer): New class for indexer declarations.
26471 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26472 (TypeContainer::indexers): New member to hold list of indexers for the
26475 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26477 * cs-parser.jay (add_accessor_declaration): Implement action.
26478 (remove_accessor_declaration): Implement action.
26479 (event_accessors_declaration): Implement
26480 (variable_declarators): swap statements for first rule - trivial.
26482 * class.cs (Event): New class to hold information about event
26484 (TypeContainer::AddEvent): New method to add an event to a type
26485 (TypeContainer::events): New member to hold list of events.
26487 * cs-parser.jay (event_declaration): Implement actions.
26489 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26491 * cs-parser.jay (dim_separators): Implement. Make it a string
26492 concatenating all the commas together, just as they appear.
26493 (opt_dim_separators): Modify accordingly
26494 (rank_specifiers): Update accordingly. Basically do the same
26495 thing - instead, collect the brackets here.
26496 (opt_rank_sepcifiers): Modify accordingly.
26497 (array_type): Modify to actually return the complete type string
26498 instead of ignoring the rank_specifiers.
26499 (expression_list): Implement to collect the expressions
26500 (variable_initializer): Implement. We make it a list of expressions
26501 essentially so that we can handle the array_initializer case neatly too.
26502 (variable_initializer_list): Implement.
26503 (array_initializer): Make it a list of variable_initializers
26504 (opt_array_initializer): Modify accordingly.
26506 * expression.cs (New::NType): Add enumeration to help us
26507 keep track of whether we have an object/delegate creation
26508 or an array creation.
26509 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26510 members to hold data about array creation.
26511 (New:New): Modify to update NewType
26512 (New:New): New Overloaded contructor for the array creation
26515 * cs-parser.jay (array_creation_expression): Implement to call
26516 the overloaded New constructor.
26518 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26520 * class.cs (TypeContainer::Constructors): Return member
26521 constructors instead of returning null.
26523 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26525 * typemanager.cs (InitCoreTypes): Initialize the various core
26526 types after we have populated the type manager with the user
26527 defined types (this distinction will be important later while
26528 compiling corlib.dll)
26530 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26531 on Expression Classification. Now all expressions have a method
26532 `Resolve' and a method `Emit'.
26534 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26535 generation from working. Also add some temporary debugging
26538 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26540 * codegen.cs: Lots of code generation pieces. This is only the
26541 beginning, will continue tomorrow with more touches of polish. We
26542 handle the fundamentals of if, while, do, for, return. Others are
26543 trickier and I need to start working on invocations soon.
26545 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26548 * codegen.cs (EmitContext): New struct, used during code
26549 emission to keep a context. Most of the code generation will be
26552 * cs-parser.jay: Add embedded blocks to the list of statements of
26553 this block. So code generation proceeds in a top down fashion.
26555 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26557 * statement.cs: Add support for multiple child blocks.
26559 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26561 * codegen.cs (EmitCode): New function, will emit the code for a
26562 Block of code given a TypeContainer and its ILGenerator.
26564 * statement.cs (Block): Standard public readonly optimization.
26565 (Block::Block constructors): Link children.
26566 (Block::Child): Child Linker.
26567 (Block::EmitVariables): Emits IL variable declarations.
26569 * class.cs: Drop support for MethodGroups here, delay until
26571 (Method::): Applied the same simplification that I did before, and
26572 move from Properties to public readonly fields.
26573 (Method::ParameterTypes): Returns the parameter types for the
26574 function, and implements a cache that will be useful later when I
26575 do error checking and the semantic analysis on the methods is
26577 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26578 and made a method, optional argument tells whether this is a class
26579 or a structure to apply the `has-this' bit.
26580 (Method::GetCallingConvention): Implement, returns the calling
26582 (Method::Define): Defines the type, a second pass is performed
26583 later to populate the methods.
26585 (Constructor::ParameterTypes): implement a cache similar to the
26586 one on Method::ParameterTypes, useful later when we do semantic
26589 (TypeContainer::EmitMethod): New method. Emits methods.
26591 * expression.cs: Removed MethodGroup class from here.
26593 * parameter.cs (Parameters::GetCallingConvention): new method.
26595 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26597 * class.cs (TypeContainer::Populate): Drop RootContext from the
26600 (Constructor::CallingConvention): Returns the calling convention.
26601 (Constructor::ParameterTypes): Returns the constructor parameter
26604 (TypeContainer::AddConstructor): Keep track of default constructor
26605 and the default static constructor.
26607 (Constructor::) Another class that starts using `public readonly'
26608 instead of properties.
26610 (Constructor::IsDefault): Whether this is a default constructor.
26612 (Field::) use readonly public fields instead of properties also.
26614 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26615 track of static constructors; If none is used, turn on
26616 BeforeFieldInit in the TypeAttributes.
26618 * cs-parser.jay (opt_argument_list): now the return can be null
26619 for the cases where there are no arguments.
26621 (constructor_declarator): If there is no implicit `base' or
26622 `this', then invoke the default parent constructor.
26624 * modifiers.cs (MethodAttr): New static function maps a set of
26625 modifiers flags into a MethodAttributes enum
26626 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26627 MethodAttr, TypeAttr to represent the various mappings where the
26628 modifiers are used.
26629 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26631 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26633 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26636 * interface.cs (PopulateIndexer): Implemented the code generator
26637 for interface indexers.
26639 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26641 * interface.cs (InterfaceMemberBase): Now we track the new status
26644 (PopulateProperty): Implement property population. Woohoo! Got
26645 Methods and Properties going today.
26647 Removed all the properties for interfaces, and replaced them with
26648 `public readonly' fields.
26650 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26652 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26653 initialize their hashtables/arraylists only when they are needed
26654 instead of doing this always.
26656 * parameter.cs: Handle refs and out parameters.
26658 * cs-parser.jay: Use an ArrayList to construct the arguments
26659 instead of the ParameterCollection, and then cast that to a
26662 * parameter.cs: Drop the use of ParameterCollection and use
26663 instead arrays of Parameters.
26665 (GetParameterInfo): Use the Type, not the Name when resolving
26668 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26670 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26671 and instead use public readonly fields.
26673 * class.cs: Put back walking code for type containers.
26675 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26677 * class.cs (MakeConstant): Code to define constants.
26679 * rootcontext.cs (LookupType): New function. Used to locate types
26682 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26684 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26685 this System.Reflection code is. Kudos to Microsoft
26687 * typemanager.cs: Implement a type cache and avoid loading all
26688 types at boot time. Wrap in LookupType the internals. This made
26689 the compiler so much faster. Wow. I rule!
26691 * driver.cs: Make sure we always load mscorlib first (for
26692 debugging purposes, nothing really important).
26694 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26695 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26697 * rootcontext.cs: Lookup types on their namespace; Lookup types
26698 on namespaces that have been imported using the `using' keyword.
26700 * class.cs (TypeContainer::TypeAttr): Virtualize.
26701 (Class::TypeAttr): Return attributes suitable for this bad boy.
26702 (Struct::TypeAttr): ditto.
26703 Handle nested classes.
26704 (TypeContainer::) Remove all the type visiting code, it is now
26705 replaced with the rootcontext.cs code
26707 * rootcontext.cs (GetClassBases): Added support for structs.
26709 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26711 * interface.cs, statement.cs, class.cs, parameter.cs,
26712 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26713 Drop use of TypeRefs, and use strings instead.
26715 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26719 * class.cs (Struct::Struct): set the SEALED flags after
26720 checking the modifiers.
26721 (TypeContainer::TypeAttr): new property, returns the
26722 TypeAttributes for a class.
26724 * cs-parser.jay (type_list): Oops, list production was creating a
26725 new list of base types.
26727 * rootcontext.cs (StdLib): New property.
26728 (GetInterfaceTypeByName): returns an interface by type name, and
26729 encapsulates error handling here.
26730 (GetInterfaces): simplified.
26731 (ResolveTree): Encapsulated all the tree resolution here.
26732 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26735 * driver.cs: Add support for --nostdlib, to avoid loading the
26736 default assemblies.
26737 (Main): Do not put tree resolution here.
26739 * rootcontext.cs: Beginning of the class resolution.
26741 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26743 * rootcontext.cs: Provide better error reporting.
26745 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26747 * rootcontext.cs (CreateInterface): Handle the case where there
26748 are no parent interfaces.
26750 (CloseTypes): Routine to flush types at the end.
26751 (CreateInterface): Track types.
26752 (GetInterfaces): Returns an array of Types from the list of
26753 defined interfaces.
26755 * typemanager.c (AddUserType): Mechanism to track user types (puts
26756 the type on the global type hash, and allows us to close it at the
26759 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26761 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26762 RecordInterface instead.
26764 * cs-parser.jay: Updated to reflect changes above.
26766 * decl.cs (Definition): Keep track of the TypeBuilder type that
26767 represents this type here. Not sure we will use it in the long
26768 run, but wont hurt for now.
26770 * driver.cs: Smaller changes to accomodate the new code.
26772 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26775 * rootcontext.cs (CreateInterface): New method, used to create
26776 the System.TypeBuilder type for interfaces.
26777 (ResolveInterfaces): new entry point to resolve the interface
26779 (CodeGen): Property, used to keep track of the code generator.
26781 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26783 * cs-parser.jay: Add a second production for delegate_declaration
26786 (enum_body): Put an opt_comma here instead of putting it on
26787 enum_body or enum_member_declarations so we can handle trailing
26788 commas on enumeration members. Gets rid of a shift/reduce.
26790 (type_list): Need a COMMA in the middle.
26792 (indexer_declaration): Tell tokenizer to recognize get/set
26794 * Remove old targets.
26796 * Re-add the parser target.
26798 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26800 * cs-parser.jay: Add precendence rules for a number of operators
26801 ot reduce the number of shift/reduce conflicts in the grammar.
26803 2001-07-17 Miguel de Icaza <miguel@ximian.com>
26805 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
26808 Get rid of old crufty code.
26810 * rootcontext.cs: Use this to keep track of the parsed
26811 representation and the defined types available to the program.
26813 * gen-treedump.cs: adjust for new convention.
26815 * type.cs: Split out the type manager, and the assembly builder
26818 * typemanager.cs: the type manager will live here now.
26820 * cil-codegen.cs: And the code generator here.
26822 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
26824 * makefile: Fixed up for easy making.
26826 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26828 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
26831 (unary_expression): Expand pre_increment_expression and
26832 post_decrement_expression to reduce a shift/reduce.
26834 2001-07-11 Simon Cozens
26836 * cs-tokenizer.cs: Hex numbers should begin with a 0.
26838 Improve allow_keyword_as_indent name.
26840 2001-06-19 Miguel de Icaza <miguel@ximian.com>
26842 * Adjustments for Beta2.
26844 2001-06-13 Miguel de Icaza <miguel@ximian.com>
26846 * decl.cs: Added `Define' abstract method.
26847 (InTransit): new property, used to catch recursive definitions.
26849 * interface.cs: Implement `Define'.
26851 * modifiers.cs: Map Modifiers.constants to
26852 System.Reflection.TypeAttribute flags.
26854 * class.cs: Keep track of types and user-defined types.
26855 (BuilderInit): New method for creating an assembly
26856 (ResolveType): New function to launch the resolution process, only
26857 used by interfaces for now.
26859 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
26860 that are inserted into the name space.
26862 2001-06-08 Miguel de Icaza <miguel@ximian.com>
26864 * ARGH. I have screwed up my tree so many times due to the use of
26865 rsync rather than using CVS. Going to fix this at once.
26867 * driver.cs: Objetify driver. Load assemblies, use assemblies to
26870 2001-06-07 Miguel de Icaza <miguel@ximian.com>
26872 * Experiment successful: Use System.Type rather that our own
26875 2001-05-25 Miguel de Icaza <miguel@ximian.com>
26877 * cs-parser.jay: Removed nsAliases from here.
26879 Use new namespaces, handle `using XXX;'
26881 * namespace.cs: Reimplemented namespace handling, use a recursive
26882 definition of the class. Now we can keep track of using clauses
26883 and catch invalid using clauses.
26885 2001-05-24 Miguel de Icaza <miguel@ximian.com>
26887 * gen-treedump.cs: Adapted for all the renaming.
26889 * expression.cs (Expression): this class now has a Type property
26890 which returns an expression Type.
26892 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
26893 `Type', as this has a different meaning now in the base
26895 2001-05-22 Miguel de Icaza <miguel@ximian.com>
26897 * interface.cs, class.cs: Removed from all the sources the
26898 references to signature computation, as we can not do method
26899 signature computation during the parsing time, as we are not
26900 trying to solve at that point distinguishing:
26904 void a (NS.Blah x) {}
26907 Which depending on the context might be valid or not, as we do not
26908 know if Blah is the same thing as NS.Blah at that point.
26910 * Redid everything so the code uses TypeRefs now instead of
26911 Types. TypeRefs are just temporary type placeholders, that need
26912 to be resolved. They initially have a pointer to a string and the
26913 current scope in which they are used. This is used later by the
26914 compiler to resolve the reference to an actual Type.
26916 * DeclSpace is no longer a CIR.Type, and neither are
26917 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
26918 are all DeclSpaces, but no Types.
26920 * type.cs (TypeRefManager): This implements the TypeRef manager,
26921 which keeps track of all the types that need to be resolved after
26922 the parsing has finished.
26924 2001-05-13 Miguel de Icaza <miguel@ximian.com>
26926 * ARGH. We are going to have to store `foreach' as a class rather
26927 than resolving it, as we need to verify error 1579 after name
26928 resolution. *OR* we could keep a flag that says `This request to
26929 IEnumerator comes from a foreach statement' which we can then use
26930 to generate the error.
26932 2001-05-10 Miguel de Icaza <miguel@ximian.com>
26934 * class.cs (TypeContainer.AddMethod): we now add methods to the
26935 MethodGroup instead of the method hashtable.
26937 * expression.cs: Add MethodGroup abstraction, which gets us one
26938 step closer to the specification in the way we handle method
26941 * cs-parser.jay (primary_expression): qualified_identifier now
26942 tried to match up an identifier to a local variable reference or
26943 to a parameter reference.
26945 current_local_parameters is now a parser global variable that
26946 points to the current parameters for the block, used during name
26949 (property_declaration): Now creates an implicit `value' argument to
26952 2001-05-09 Miguel de Icaza <miguel@ximian.com>
26954 * parameter.cs: Do not use `param' arguments as part of the
26955 signature, per the spec.
26957 2001-05-08 Miguel de Icaza <miguel@ximian.com>
26959 * decl.cs: Base class for classes, structs and interfaces. This
26960 is the "Declaration Space"
26962 * cs-parser.jay: Use CheckDef for checking declaration errors
26963 instead of having one on each function.
26965 * class.cs: Factor out some code for handling error handling in
26966 accordance to the "Declarations" section in the "Basic Concepts"
26967 chapter in the ECMA C# spec.
26969 * interface.cs: Make all interface member classes derive from
26970 InterfaceMemberBase.
26972 2001-05-07 Miguel de Icaza <miguel@ximian.com>
26974 * Many things: all interfaces are parsed and generated in
26975 gen-treedump. Support for member variables, constructors,
26976 destructors, properties, constants is there.
26978 Beginning of the IL backend, but very little done, just there for
26981 2001-04-29 Miguel de Icaza <miguel@ximian.com>
26983 * cs-parser.jay: Fix labeled statement.
26985 * cs-tokenizer.cs (escape): Escape " and ' always.
26986 ref_line, ref_name: keep track of the line/filename as instructed
26987 by #line by the compiler.
26990 2001-04-27 Miguel de Icaza <miguel@ximian.com>
26992 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
26993 to match the values in System.CodeDOM.
26995 Divid renamed to Divide.
26997 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
26999 (Statements.set): remove.
27001 * System.CodeDOM/CodeCatchClause.cs: always have a valid
27004 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
27005 falseStatements always have valid values.
27007 * cs-parser.jay: Use System.CodeDOM now.