1 2006-10-28 Marek Safar <marek.safar@gmail.com>
4 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
7 2006-10-26 Marek Safar <marek.safar@gmail.com>
10 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
12 2006-10-25 Brian Crowell <brian@fluggo.com>
15 * generic.cs (CheckConstraints): Allow generic parameters with
16 inheritance constraints to satisfy reference type constraints.
18 2006-10-09 Martin Baulig <martin@ximian.com>
21 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
23 2006-09-25 Martin Baulig <martin@ximian.com>
25 * class.cs: Remove after unification with mcs source.
27 2006-09-24 Raja R Harinath <harinath@gmail.com>
29 * convert.cs: Remove after unification with mcs source.
31 2006-09-24 Marek Safar <marek.safar@seznam.cz>
33 * class.cs (MemberBase.VerifyClsCompliance): When method has type
34 parameters verify them as well.
36 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
37 the type parameter constraints.
38 (Generics.VerifyClsCompliance): Ditto.
40 2006-09-24 Marek Safar <marek.safar@seznam.cz>
42 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
43 for anonymous block with out argument.
45 2006-09-24 Marek Safar <marek.safar@seznam.cz>
47 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
48 not used private events only.
50 2006-09-23 Marek Safar <marek.safar@seznam.cz>
52 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
54 * cs-parser.jay: Parse correctly cast of default (T).
56 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
57 Store original type via EmptyConstantCast.
59 2006-09-22 Martin Baulig <martin@ximian.com>
61 * delegate.cs: Removed; this file is now shared with mcs.
63 * attribute.cs: Removed; this file is now shared with mcs.
65 2006-09-22 Martin Baulig <martin@ximian.com>
67 * ecore.cs: Removed; this file is now shared with mcs.
69 2006-09-21 Marek Safar <marek.safar@seznam.cz>
71 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
73 * ecore.cs (NullCast): Derives from NullConstant.
75 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
78 2006-09-21 Martin Baulig <martin@ximian.com>
80 * decl.cs: Removed; this file is now shared with mcs.
82 2006-09-21 Raja R Harinath <rharinath@novell.com>
84 * rootcontext.cs: Remove after unification with mcs source.
86 * report.cs: Remove after unification with mcs source.
87 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
89 (InitGenerics, CleanUpGenerics): Remove.
91 * support.cs: Remove after unification with mcs source.
93 2006-09-20 Raja R Harinath <rharinath@novell.com>
95 * codegen.cs: Remove after unification with mcs source.
97 2006-09-19 Martin Baulig <martin@ximian.com>
99 * expression.cs: Removed; this file is now shared with mcs.
101 2006-09-19 Martin Baulig <martin@ximian.com>
104 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
105 (TypeManager.DropGenericTypeArguments): Likewise.
106 (TypeManager.DropGenericMethodArguments): Likewise.
107 (TypeManager.GetTypeArguments): Likewise.
108 (TypeManager.HasGenericArguments): Likewise.
110 2006-09-19 Martin Baulig <martin@ximian.com>
112 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
114 2006-09-19 Martin Baulig <martin@ximian.com>
116 * typemanager.cs: Removed; this file is now shared with mcs.
118 2006-09-16 Raja R Harinath <rharinath@novell.com>
120 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
121 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
123 2006-09-16 Marek Safar <marek.safar@seznam.cz>
126 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
127 only if parent type is class.
128 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
131 2006-09-15 Marek Safar <marek.safar@seznam.cz>
134 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
136 * typemanager.cs(CSharpName): Converts NullType to null.
138 2006-09-15 Martin Baulig <martin@ximian.com>
140 * pending.cs: Removed; this file is now shared with mcs.
142 2006-09-15 Martin Baulig <martin@ximian.com>
144 * statement.cs: Removed; this file is now shared with mcs.
146 2006-09-15 Martin Baulig <martin@ximian.com>
148 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
150 * driver.cs: Removed the `--broken-cycles' argument.
152 2006-09-15 Martin Baulig <martin@ximian.com>
154 * namespace.cs: Removed; this file is now shared with mcs.
156 2006-09-15 Martin Baulig <martin@ximian.com>
158 * decl.cs (MemberName): Minor code cleanups.
160 2006-09-15 Martin Baulig <martin@ximian.com>
162 * parameter.cs: Removed; this file is now shared with mcs.
164 2006-09-15 Martin Baulig <martin@ximian.com>
166 * enum.cs: Removed; this file is now shared with mcs.
168 2006-09-15 Martin Baulig <martin@ximian.com>
170 * Makefile: Define `GMCS_SOURCE'.
172 * flowanalysis.cs: Removed; this file is now shared with mcs.
174 2006-09-15 Martin Baulig <martin@ximian.com>
176 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
177 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
178 doc.cs - they are now shared with mcs.
180 * gmcs.exe.sources: Include these files from ../mcs/.
182 2006-09-15 Martin Baulig <martin@ximian.com>
184 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
185 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
187 2006-09-14 Marek Safar <marek.safar@seznam.cz>
189 * assign.cs, ecore.cs, expression.cs: Share error message text.
190 * class.cs (FieldMember.Define): Check for variable of static type.
191 * decl.cs (check_type_parameter): Report correct type name.
192 * driver.cs (LoadAssembly): Uses error output for errors.
193 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
194 (TypeArguments.Resolve): Static class cannot be used as an argument.
195 * statement.cs (ResolveMeta): Constants cannot be generic types.
197 2006-09-12 Martin Baulig <martin@ximian.com>
199 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
201 * convert.cs (Convert.Array_To_IList): Moved here and correctly
202 implement it; fixes #79345.
204 2006-09-08 Marek Safar <marek.safar@seznam.cz>
206 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
208 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
210 * generic.cs: Improved error messages.
211 * typemanager.cs (RemoveGenericArity): Made public.
213 2006-09-08 Martin Baulig <martin@ximian.com>
215 * typemanager.cs (TypeManager.interlocked_type): New public field.
216 (TypeManager.int_interlocked_compare-exchange): New public field.
217 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
218 enumerator types here and call InitGenericCoreTypes().
219 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
220 after calling InitEnumUnderlyingTypes().
223 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
224 `classes_second_stage'.
226 2006-09-07 Marek Safar <marek.safar@seznam.cz>
228 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
230 * statement.cs (Block.Variables): Made public.
232 2006-09-07 Martin Baulig <martin@ximian.com>
235 (MainDriver): Revert r62663 from Marek; see #70506 for details.
237 2006-09-01 Martin Baulig <martin@ximian.com>
240 (TypeManager.IsIList): Also handle base classes and interfaces.
242 2006-09-01 Raja R Harinath <rharinath@novell.com>
245 * expression.cs (Invocation.MoreSpecific): Check for reference
248 2006-08-29 Miguel de Icaza <miguel@novell.com>
250 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
252 2006-08-17 Miguel de Icaza <miguel@novell.com>
254 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
255 #52019 and #79064, the use of the \uXXXX sequence in source code
256 to represent unicode characters.
258 2006-08-15 Marek Safar <marek.safar@seznam.cz>
260 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
262 * class.cs, ecore.cs, statement.cs: Merged to one error message.
264 2006-08-14 Raja R Harinath <rharinath@novell.com>
267 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
268 parameter too. This only avoids a parse error -- the semantic
269 error is caught elsewhere.
271 2006-08-13 Miguel de Icaza <miguel@novell.com>
273 * assign.cs: Catch attempts to assign to a method groups in += and
276 2006-08-13 Marek Safar <marek.safar@seznam.cz>
279 * cs-parser.jay: Don't destroy current array type by typeof of array's.
281 2006-08-12 Marek Safar <marek.safar@seznam.cz>
283 * cs-parser.jay: Check whether a constraint clause has already been
284 specified for type parameter.
285 * generic.cs (Constraints): Exposed location.
287 2006-08-12 Marek Safar <marek.safar@seznam.cz>
289 * class.cs (Method.Define): Issue a warning when generic method looks like
291 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
293 * report.cs: New warning number.
295 2006-08-09 Marek Safar <marek.safar@seznam.cz>
297 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
299 * decl.cs (MemberCache.FindMembers): When container is interface we need to
300 search all base interfaces as a member can be ambiguous.
301 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
302 Constructor member type filter.
303 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
304 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
305 reporting for returned memberinfos.
306 * report.cs: Updated.
307 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
308 version to work on all runtimes.
309 (TypeManager.RealMemberLookup): Removed members filtering.
311 2006-08-08 Raja R Harinath <rharinath@novell.com>
313 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
314 (PropertyExpr.EmitAssign): Likewise.
315 * expression.cs (Indirection.EmitAssign): Likewise.
316 (LocalVariableReference.EmitAssign): Likewise.
317 (ParameterReference.EmitAssign): Likewise.
318 (Invocation.EmitArguments): Likewise.
319 (ArrayAccess.EmitAssign): Likewise.
320 (IndexerAccess.EmitAssign): Likewise.
321 (This.EmitAssign): Likewise.
322 (ConditionalLogicalOperator.Emit): Likewise.
325 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
326 instead of ArrayList. If the hashtable has a LocalBuilder, don't
327 leave it in after returning it.
328 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
330 2006-08-06 Marek Safar <marek.safar@seznam.cz>
332 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
335 2006-08-05 Marek Safar <marek.safar@seznam.cz>
337 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
338 with different type names.
339 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
341 2006-08-03 Raja R Harinath <rharinath@novell.com>
343 Fix cs0146-3.cs and cs0146-4.cs.
344 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
345 enclosing types don't depend on the current type.
347 2006-08-02 Raja R Harinath <rharinath@novell.com>
350 * class.cs (TypeContainer.DoDefineMembers): Use
351 FindBaseMemberWithSameName on Parent, since we're interested in
352 whether we hide inherited members or not.
353 (FindBaseMemberWithSameName): Make slightly more robust.
356 * codegen.cs (IResolveContext.GenericDeclContainer): New.
357 (EmitContext): Implement new interface requirement.
358 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
359 * decl.cs (MemberCore): Likewise.
360 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
361 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
362 ec.GenericDeclContainer to check for generic parameters.
363 (SimpleName.DoSimpleNameResolve): Likewise.
364 * generic.cs (TypeParameter.DeclContainer): Remove override.
366 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
367 declspaces for doppelgangers too.
368 (UsingEntry): Implement IResolveContext.
369 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
370 'this' as the resolve context.
371 (LocalAliasEntry): Likewise.
373 Implement parts of #77403
374 * roottypes.cs (RootDeclSpace): New. Used to represent the
375 toplevel declaration space. Each namespace declaration introduces
376 a "partial" root declaretion space.
377 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
378 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
379 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
380 from 'current_namespace.SlaveDeclSpace'.
381 (namespace_declaration): Likewise.
382 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
383 check. It can't happen now.
384 * decl.cs (DeclSpace.LookupType): Likewise.
385 * driver.cs (MainDriver): Sanity check.
387 2006-08-01 Raja R Harinath <rharinath@novell.com>
389 * decl.cs (DeclSpace.FindNestedType): Remove.
390 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
391 LookupTypeContainer to get the container of the nested type.
392 * class.cs (TypeContainer.FindNestedType): Make non-override.
394 2006-07-31 Raja R Harinath <rharinath@novell.com>
396 * decl.cs (DeclSpace.PartialContainer): Move field from ...
397 * class.cs (TypeContainer.PartialContainer): ... here.
398 (TypeContainer.AddBasesForPart): New helper.
399 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
401 * cs-parser.jay (current_class): Convert to DeclSpace.
402 (struct_declaration, interface_declaration, class_declaration):
403 Use AddBasesForPart instead of .Bases directly.
404 * const.cs, iterators.cs: Update to changes.
406 2006-07-28 Raja R Harinath <rharinath@novell.com>
408 * class.cs (TypeContainer.AddMemberType): Rename from
410 (TypeContainer.AddMember): Rename from AddToMemberContainer.
411 (AddTypeContainer): New. Combine AddClassOrStruct and
413 (AddPartial): Update. Add 'is_partial' argument.
414 * roottypes.cs: Update to changes.
415 * cs-parser.jay (push_current_class): New helper for handling
416 current_container and current_class.
417 (struct_declaration, interface_declaration, class_declaration):
420 2006-07-26 Raja R Harinath <rharinath@novell.com>
422 * roottypes.cs: Rename from tree.cs.
424 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
425 * tree.cs (Tree, ITreeDump): Remove types.
426 * rootcontext.cs (tree, Tree): Remove fields.
427 (root, ToplevelTypes): New.
428 * *.cs: Update to rename.
430 * tree.cs (Tree.RecordDecl): Remove.
431 (RootTypes.AddToTypeContainer): Record the toplevel type in its
433 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
435 2006-07-23 Raja R Harinath <harinath@gmail.com>
437 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
438 DoFlowAnalysis and OmitStructFlowAnalysis here.
439 (ec.With): Rename from WithUnsafe and generalize.
440 (ec.WithCheckState): Remove. All users can be handled by 'With'.
441 (ec.WithFlowAnalyis): New.
442 * ecore.cs, expression.cs, statement.cs: Update.
444 2006-07-22 Raja R Harinath <harinath@gmail.com>
446 * statement.cs (Block.ResolveMeta): Simplify slightly.
448 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
449 multiple boolean fields. Convert InUnsafe, constant_check_state,
450 check_state to flags.
451 (CheckState, ConstantCheckState): Update.
452 (InUnsafe): New read-only property.
453 (FlagsHandle): Rename from CheckStateHandle and convert to handle
455 (WithUnsafe): New helper similar to WithCheckState.
456 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
457 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
459 2006-07-21 Raja R Harinath <rharinath@novell.com>
461 Make comparisons use the same IL irrespective of whether they're
462 in a 'checked' or 'unchecked' context: one of the issues in #78899
463 * codegen.cs (EmitContext.CheckState): Make read-only property.
464 (EmitContext.ConstantCheckState): Likewise.
465 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
466 helper that implement a save/restore stack for CheckState
467 values. This is the only way to change check-state.
468 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
469 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
470 (CheckedExpr.EmitBranchable): New forwarding method.
471 (UnCheckedExpr): Likewise.
472 * statement.cs (Block.ResolveMeta): Use WithCheckState.
473 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
474 (Checked.Resolve, checked.DoEmit): Likewise.
476 2006-07-21 Martin Baulig <martin@ximian.com>
478 * generic.cs (TypeManager.InferType): When inferring an array
479 type, also allow IList<T> and ICollection<T>. Fixes #78900.
481 2006-07-21 Martin Baulig <martin@ximian.com>
483 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
484 and allow IList`1 and all its base interfaces.
486 * convert.cs (Convert.ImplicitReferenceConversion): Allow
487 converting from an array-type of T to IList<T>.
489 2006-07-21 Martin Baulig <martin@ximian.com>
491 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
493 2006-07-20 Miguel de Icaza <miguel@novell.com>
495 * anonymous.cs: Cache the resolved anonymous delegate, and return
496 this so that the ResolveTopBlock is only triggered once, not
499 Currently we trigger ResolvetopBlock twice due to a first pass of
500 argument check compatibility, and a second pass that does the
503 2006-07-15 Marek Safar <marek.safar@seznam.cz>
505 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
507 * rootcontext.cs (Reset): Add helper_classes.
509 2006-07-15 Marek Safar <marek.safar@seznam.cz>
512 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
515 2006-07-13 Miguel de Icaza <miguel@novell.com>
517 * statement.cs (Lock): Handle expressions of type
518 TypeManager.null_type specially. Fixes #78770
520 2006-07-08 Marek Safar <marek.safar@seznam.cz>
522 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
525 2006-07-08 Marek Safar <marek.safar@seznam.cz>
527 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
528 for accessors as well.
529 * ecore.cs (EventExpr): Add AccessorTable.
531 2006-07-03 Martin Baulig <martin@ximian.com>
533 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
534 instances of value types.
536 * convert.cs (Convert.ExplicitConversion): Correctly handle
537 object->nullable conversions.
539 2006-07-01 Marek Safar <marek.safar@seznam.cz>
542 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
543 for CS0122 where appropriate.
544 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
546 (Filter): Assembly can be null in the case of top level attributes.
548 2006-06-28 Raja R Harinath <rharinath@novell.com>
551 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
552 no arguments, return 'false': nothing can be inferred.
554 2006-06-25 Marek Safar <marek.safar@seznam.cz>
558 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
559 is done at global level.
561 2006-06-24 Marek Safar <marek.safar@seznam.cz>
563 A fix for #77002, Implemented TypeForwarder support.
565 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
566 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
568 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
569 * typemanager.cs (): Add type_forwarder_attr_type.
571 2006-06-24 Marek Safar <marek.safar@seznam.cz>
573 * report.cs: Add CS0469 warning.
575 2006-06-22 Martin Baulig <martin@ximian.com>
578 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
579 for interfaces; fixes #78686, which is a modification of #78380
580 with interfaces instead of classes.
582 2006-06-21 Martin Baulig <martin@ximian.com>
584 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
585 the `try'-block, so we also report CS0016 etc. there.
587 2006-06-21 Martin Baulig <martin@ximian.com>
589 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
590 handle SetAssigned() and SetMemberIsUsed() for generic types;
593 2006-06-21 Martin Baulig <martin@ximian.com>
596 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
598 2006-06-21 Martin Baulig <martin@ximian.com>
600 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
601 also report CS1686 for parameters.
603 2006-06-21 Martin Baulig <martin@ximian.com>
605 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
606 instead of an error if the value is not implicitly convertible to
607 the switch types; fixes #77964.
609 2006-06-21 Raja R Harinath <rharinath@novell.com>
612 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
613 FieldBuilder is null.
616 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
617 'left' and 'right' before error-checking.
619 2006-06-19 Martin Baulig <martin@ximian.com>
622 (Convert.ImplicitConversionStandard): Cleanup and correctly
623 implement nullable conversions.
624 (Convert.ImplicitStandardConversionExists): Likewise.
625 (Convert.ExplicitConversion): Likewise.
627 2006-06-19 Martin Baulig <martin@ximian.com>
630 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
631 methods; make the ctors protected.
633 2006-06-19 Martin Baulig <martin@ximian.com>
635 Fixed #78380; added gtest-273.cs.
638 (Expression.ResolveAsBaseTerminal): Move the constraint checking
639 into ResolveAsTypeTerminal().
642 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
643 TypeManager.FindMembers() to check for the default ctor.
645 2006-06-18 Marek Safar <marek.safar@seznam.cz>
647 * generic.cs: Fixed NullableInfo accessibility.
649 2006-06-16 Martin Baulig <martin@ximian.com>
652 (Constraints.InflatedConstraints.inflate): Correctly inflate
653 generic types; fixes #78400.
655 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
657 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
659 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
660 (FieldExpr.DoResolve): likewise.
661 (PropertyExpr.InstanceResolve): likewise.
662 (EventExpr.InstanceResolve): likewise.
664 2006-06-15 Martin Baulig <martin@ximian.com>
667 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
668 argument; always allow a `null' label if true.
669 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
670 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
671 we have a `null' label and mark the new `null_target' label;
672 default to the `default' label.
673 (Switch.Resolve): Add support for nullable types. Fixes #78630.
675 2006-06-15 Martin Baulig <martin@ximian.com>
677 * class.cs (Operator.Define): Allow an implicit/explicit operator
678 to convert to/from a nullable value of the enclosing type.
680 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
681 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
684 (Convert.ImplicitStandardConversionExists): Add support for lifted
685 implicit/explicit conversions.
686 (Convert.ImplicitConversionStandard): Likewise.
688 2006-06-13 Martin Baulig <martin@ximian.com>
690 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
691 type arguments and create a ConstructedType if necessary. Fixes #78400.
693 2006-06-04 Marek Safar <marek.safar@seznam.cz>
695 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
696 attribute applicable tests for attribute argument.
698 2006-06-02 Raja R Harinath <rharinath@novell.com>
701 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
702 (Binary.OverloadResolve_PredefinedIntegral): New.
703 (Binary.OverloadResolve_PredefinedFloating): New.
704 (Binary.OverloadResolve_PredefinedString): New.
705 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
706 Follow the standard more closely, and treat numeric promotions in
707 terms of overload resolution.
708 (Binary.CheckShiftArguments): Simplify.
710 2006-06-01 Raja R Harinath <rharinath@novell.com>
712 * flowanalysis.cs (MyBitVector): Simplify representation.
713 (MyBitVector.Clone): Avoid allocating BitArray.
714 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
715 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
716 (*): Update. Change all references to MyBitVector.And and
717 MyBitVector.Or to &= and |=.
719 2006-05-31 Raja R Harinath <rharinath@novell.com>
721 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
722 Use bne.un instead of ceq+brfalse.
725 * typemanager.cs (IsUnmanagedType): Disallow generic types and
728 2006-05-29 Raja R Harinath <rharinath@novell.com>
731 * cs-parser.jay (formal_parameter_list): Extend the pattern below
732 to param arguments too.
734 2006-05-26 Miguel de Icaza <miguel@novell.com>
736 * cs-parser.jay: Catch another parsing form for arglist being
737 followed by other arguments. Fixes #78313.
739 2006-05-25 Raja R Harinath <rharinath@novell.com>
742 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
743 also when one of the operands is a null literal.
744 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
745 to improve clarity, and generate slightly better code.
747 2006-05-24 Raja R Harinath <rharinath@novell.com>
749 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
750 checking of out parameters to ...
751 (FlowBranchingToplevel.Merge): ... here.
752 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
753 set, propagate the origin upward, and only complain if there was
755 (FlowBranchingException.AddContinueOrigin): Likewise.
756 (FlowBranchingException.AddReturnOrigin): Likewise.
757 (FlowBranchingException.AddGotoOrigin): Likewise.
759 2006-05-23 Raja R Harinath <rharinath@novell.com>
761 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
762 unreachable, skip it.
763 (FlowBranchingException.Merge): Always propagate jumps, even if
764 the finally block renders subsequent code unreachable.
766 2006-05-18 Raja R Harinath <rharinath@novell.com>
769 * statement.cs (Goto.Resolve): Move responsibility for resolving
770 'goto' to FlowBranching.AddGotoOrigin.
771 (Goto.SetResolvedTarget): New. Callback to set the
772 LabeledStatement that's the target of the goto.
773 (Goto.DoEmit): Use Leave instead of Br when crossing an
774 unwind-protect boundary.
775 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
776 LookupLabel and adjust to new semantics.
777 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
778 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
779 Goto.SetResolvedTarget to update target.
780 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
781 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
782 AddBreakOrigin & co. Delay propagation until ...
783 (FlowBranchingException.Merge): ... this.
785 * statement.cs (Block.Resolve): Always depend on flow-branching to
786 determine unreachability. Kill workaround that originally emitted
787 only one statement after an "unreachable" label (see infloop in
790 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
791 This is still "wrong", but anything better would probably need a
792 multi-pass algorithm.
793 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
794 usage vector. Force current usage vector to be reachable, to
795 optimistically signify backward jumps.
796 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
798 (FlowBranchingLabeled.Merge): New. If no backward jump was
799 detected, return the original salted-away usage vector instead,
800 updated with appropriate changes. Print unreachable warning if
802 * statement.cs (Block.Resolve): Don't print unreachable warning on
805 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
807 * driver.cs: Pass filename without path to AssemblyBuilder's
808 AddResourceFile. Fixes bug #78407.
810 2006-05-17 Raja R Harinath <rharinath@novell.com>
812 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
813 * flowanalysis.cs (FlowBranchingLabeled): ... here.
814 (FlowBranching.MergeChild): Overwrite
815 reachability information from Labeled branchings too.
817 2006-05-16 Raja R Harinath <rharinath@novell.com>
819 * statement.cs (Goto.Resolve): Merge jump origins here ...
820 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
822 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
823 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
824 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
825 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
827 * statement.cs (Goto.Resolve): ... not here.
828 (Goto.Emit): Remove CS1632 check.
830 2006-05-14 Marek Safar <marek.safar@seznam.cz>
832 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
835 2006-05-11 Raja R Harinath <rharinath@novell.com>
837 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
838 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
839 (FlowBranchingException.Label): Likewise.
841 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
843 (MyBitVector.Or): Use it to avoid losing information (Count).
844 (FlowBranching.MergeOrigins): Likewise.
846 * flowanalysis.cs (UsageVector.IsDirty): Remove.
847 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
848 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
849 (UsageVector.ToString): Simplify.
850 (UsageVector.MergeSiblings): Move here from ...
851 (FlowBranching.Merge): ... here.
852 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
855 2006-05-10 Raja R Harinath <rharinath@novell.com>
857 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
858 null bitvector is treated as all-true.
860 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
861 (MyBitVector): Rationalize invariants. 'vector != null' implies
862 that we have our own copy of the bitvector. Otherwise,
863 'InheritsFrom == null' implies all inherited bits are true.
865 2006-05-09 Marek Safar <marek.safar@seznam.cz>
867 * statement.cs (LocalInfo): Add IsConstant.
868 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
869 local variable for constants.
871 2006-05-09 Raja R Harinath <rharinath@novell.com>
873 * flowanalysis.cs (MyBitVector.Empty): New.
874 (MyBitVector): Don't allow InheritedFrom to be null.
875 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
876 (UsageVector, FlowBranching): Update to changes.
878 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
879 recursion. The 'Parent == null' condition isn't sufficient for
881 (FlowBranching.AddBreakOrigin): Likewise.
882 (FlowBranching.AddContinueOrigin): Likewise.
883 (FlowBranching.AddReturnOrigin): Likewise.
884 (FlowBranching.StealFinallyClauses): Likewise.
885 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
886 (FlowBranching.CheckOutParameters): Likewise.
887 (FlowBranchingToplevel): Terminate all the above recursions here.
888 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
889 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
891 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
893 (FlowBranchingToplevel): New. Empty for now.
894 (FlowBranching.MergeTopBlock): Update.
895 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
896 branching for the anonymous delegate.
897 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
899 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
900 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
901 information at the start of the merge. Reorganize.
903 2006-05-07 Marek Safar <marek.safar@seznam.cz>
905 * class.cs (MethodData.Define): Method cannot implement interface accessor.
907 2006-05-07 Marek Safar <marek.safar@seznam.cz>
909 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
910 to newly introduced ctor.
912 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
913 message to one place.
914 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
917 2006-05-07 Marek Safar <marek.safar@seznam.cz>
919 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
921 * ecore.cs (Expression.ResolveAsConstant): Updated.
923 * statement.cs (ResolveMeta): Updated.
925 2006-05-06 Marek Safar <marek.safar@seznam.cz>
927 * cs-parser.jay: __arglist cannot be used in initializer.
929 2006-05-06 Marek Safar <marek.safar@seznam.cz>
932 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
935 2006-05-05 Raja R Harinath <rharinath@novell.com>
937 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
938 (LabeledStatement): Add 'name' parameter.
939 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
940 (Block.AddLabel): Update to changes.
941 * cs-parser.jay (labeled_statement): Likewise.
943 * flowanalysis.cs (BranchingType.Labeled): New.
944 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
945 (FlowBranchingLabeled): New. Does nothing for now, but will
946 eventually handle 'goto' flows.
947 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
948 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
949 that's terminated ...
950 (Block.Resolve): ... here.
952 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
953 (UsageVector.MergeFinallyOrigins): Likewise.
954 (FlowBranching.InTryOrCatch): Likewise.
955 (FlowBranching.AddFinallyVector): Likewise.
956 (FlowBranchingException): Update to changes.
959 * statement.cs (Return.Resolve): Move error checking to ...
960 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
961 (FlowBranchingException): Handle return origins like break and
963 (FlowBranching.UsageVector.CheckOutParameters): Remove.
965 2006-05-04 Marek Safar <marek.safar@seznam.cz>
968 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
971 2006-05-04 Marek Safar <marek.safar@seznam.cz>
974 * class.cs (MethodData.Define): Do public accessor check only when method
975 implements an interface.
977 2006-05-04 Raja R Harinath <rharinath@novell.com>
979 Remove special handling of 'break'
980 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
981 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
982 (UsageVector.Break): Remove.
983 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
985 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
987 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
988 UsageVector.Breaks (). Don't set NeedsReturnLabel.
990 2006-05-03 Marek Safar <marek.safar@seznam.cz>
993 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
994 be the interface member.
996 2006-05-03 Marek Safar <marek.safar@seznam.cz>
999 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1000 for emitting small (int) values.
1002 2006-05-03 Raja R Harinath <rharinath@novell.com>
1005 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1006 control-flow passes through the 'finally' after merging-in all the
1007 control-flows from 'try' and the 'catch' clauses.
1009 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1010 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1011 always true at the only non-recursive entry point.
1012 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1013 FlowBranchingBreakable.
1014 (FlowBranchingLoop): Remove.
1015 * statement.cs (Return.DoResolve): Update to changes.
1018 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1019 (FlowBranching.CreateBranching): Handle it: create a
1020 FlowBranchingContinuable.
1021 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1022 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1023 except that it handles the 'continue' command.
1024 (FlowBranching.UsageVector.MergeOrigins): Rename from
1026 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1027 except that it overrides AddContinueOrigin.
1028 (FlowBranchingException): Override AddContinueOrigin, similar to
1030 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1031 Create a new branching around the embedded statement.
1032 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1033 control flow after the embedded statement.
1034 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1036 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1037 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1038 FlowBranchingBreakable.
1039 (FlowBranchingSwitch): Remove.
1042 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1043 error reporting to ...
1044 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1045 Rename from 'AddBreakVector'. Add new location argument. Return
1046 a bool indicating whether the 'break' crosses an unwind-protect.
1047 (FlowBranchingException.AddBreakOrigin): Add.
1048 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1049 flowbranching after updating with the effects of the 'finally'
1051 (FlowBranchingBreakable): New common base class for
1052 FlowBranchingLoop and FlowBranchingSwitch.
1054 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1056 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1058 2006-05-02 Raja R Harinath <rharinath@novell.com>
1060 * statement.cs (Do.Resolve): If the loop is infinite, set the
1062 (While.Resolve, For.Resolve): Set a barrier after the embedded
1063 statement. There's no direct control flow that goes from the end
1064 of the embedded statement to the end of the loop.
1065 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1066 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1067 above ensure that the reachability is correctly computed.
1069 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1070 (UsageVector.MergeBreakOrigins): If the current path is
1071 unreachable, treat it as if all parameters/locals are initialized.
1072 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1073 infinite loops before merging-in break origins.
1075 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1076 (Reachability.Reachable): Split part into ...
1077 (Reachability.Unreachable): ... this. Simplify.
1078 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1080 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1081 (Reachability.SetThrowsSometimes): Likewise.
1082 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1083 TriState.Always, use corresponding property.
1084 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1085 (Block.Resolve): Likewise. Remove some redundant checks.
1087 2006-05-02 Raja R Harinath <harinath@gmail.com>
1089 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1090 (Reachability.Meet): Don't bother checking AlwaysThrows --
1091 barrier is always set.
1092 (FlowBranchingBlock.Merge): Likewise.
1094 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1096 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1097 defined, so it's references should also compile only for NET_2_0
1098 (as occurs in mcs version)
1100 2006-05-01 Raja R Harinath <harinath@gmail.com>
1102 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1103 checks for unreachable.
1105 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1108 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1110 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1111 whether field is really assigned.
1113 2006-04-30 Raja R Harinath <harinath@gmail.com>
1115 * flowanalysis.cs (Reachability): Make 4-argument constructor
1117 (Reachability.Meet): Rename from 'And'. Remove static variant.
1118 (Reachability.Always): Rename from the highly misleading
1119 'Reachability.Never'.
1120 (FlowBranching.Merge): Update to changes. Mark an impossible
1121 situation with a 'throw'.
1122 (*): Update to changes.
1124 2006-04-29 Raja R Harinath <harinath@gmail.com>
1126 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1128 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1129 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1130 (*): Update to changes.
1131 * statement.cs: Update to changes.
1133 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1136 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1138 2006-04-28 Raja R Harinath <harinath@gmail.com>
1140 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1143 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1144 argument to two arguments: an usage-vector and a bool. Move call
1145 to FlowBranching.Merge () ...
1146 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1148 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1149 handling of loop and switch reachability to ...
1150 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1152 2006-04-27 Raja R Harinath <harinath@gmail.com>
1154 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1155 handling to FlowBranchingLoop.InLoop.
1156 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1158 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1161 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1162 anonymous method is allowed from AnonymousContainer here.
1164 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1166 2006-04-24 Raja R Harinath <rharinath@novell.com>
1169 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1171 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1174 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1175 (DoubleConstant.Reduce): Ditto.
1177 2006-04-23 Raja R Harinath <rharinath@novell.com>
1179 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1180 Remove 'lvalue_right_side' argument. Move parts to ...
1181 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1182 (LocalVariable.DoResolveLValue): ... these.
1184 2006-04-21 Raja R Harinath <rharinath@novell.com>
1187 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1188 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1189 (LocalVariableReference.DoResolveBase): Use it to implement new
1191 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1192 (Argument.Resolve): Simplify. Move CS1510 check ...
1193 * ecore.cs (Expression.ResolveLValue): ... here.
1194 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1195 (PropertyExpr.DoResolveLValue): Likewise.
1196 (FieldExpr.Report_AssignToReadonly): Likewise.
1197 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1198 LValueMemberAccess or LValueMemberOutAccess on instance depending
1200 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1201 DoResolve as appropriate.
1203 2006-04-20 Raja R Harinath <rharinath@novell.com>
1206 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1207 implicit conversions on 'out' and 'ref' arguments.
1209 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1210 improve clarity. Remove dead code.
1213 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1214 (Catch.Resolve): Resolve VarBlock if it exists.
1216 2006-04-19 Miguel de Icaza <miguel@novell.com>
1218 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1219 twice, this was some residual code, the enumerator was emitted
1220 properly in the two branche of if later.
1224 Thanks to Martin for finding the source of the problem
1226 2006-04-19 Raja R Harinath <rharinath@novell.com>
1228 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1229 cast is never an lvalue.
1230 (Cast.DoResolve, Cast.ResolveRest): Combine.
1231 (Argument.Emit): Simplify slightly. Move 'Expr is
1232 IMemoryLocation' check ...
1233 (Argument.Resolve): ... here.
1234 (Argument.Error_LValueRequired): Remove. Inline into only user.
1236 Simplifications. Fix cs0191-2.cs
1237 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1238 CS1649 and CS1651 to ...
1239 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1240 the actual selection of the error code and message to a lookup
1241 table. Add a dummy return value to simplify callsites.
1242 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1243 readonly fields of other instances of the same type. Move CS0197
1245 * expression.cs (Argument.Resolve): ... here. Simplify code.
1246 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1247 resolution of an out or ref argument. The code simplification
1248 above uses this invariant.
1250 2006-04-18 Raja R Harinath <rharinath@novell.com>
1252 Possibly fix #77752. Fix cs1690-[4-7].cs.
1253 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1254 CheckMarshallByRefAccess. Drop parameter.
1255 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1257 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1259 * report.cs (AllWarnings): Add CS1690.
1260 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1262 (LocalVariableReference.DoResolveBase): Update.
1264 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1266 * class.cs (MethodOrOperator): Moved common parts from method class.
1267 detect obsolete attributes.
1268 (Method.Define): Simplified as it reuses code from base.
1269 (Constructor.ValidAttributeTargets): Fixed issue found during
1271 (Destructor.ValidAttributeTargets): Fixed issue found during
1273 (Operator): Finished refactoring set off by #78020. Operator class is now
1274 ordinary method class.
1276 * anonymous.cs: Updated.
1278 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1280 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1282 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1284 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1285 detect obsolete attributes.
1286 (Method.CreateEmitContext): Moved to MethodOrOperator.
1288 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1291 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1292 customized exception to make crash detection easier.
1293 (MethodOrOperator): Started to work on new base class for methods and
1295 (Method): Derives from MethodOrOperator.
1296 (Constructor.Emit): Emits its own attributes.
1297 (AbstractPropertyEventMethod.Emit): Ditto.
1298 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1300 (Operator.Emit): It's temporary more tricky than should be.
1302 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1304 * report.cs (InternalErrorException): Add ctor with inner exception.
1306 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1309 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1312 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1315 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1318 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1320 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1321 attribute is present and Guid not.
1322 (Interface.ApplyAttributeBuilder): Ditto.
1324 * attribute.cs: Add error message.
1326 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1330 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1331 sources (it's composite) so hold them in extra array as they are used in
1332 Emit phase only. It worked in the previous versions by mistake.
1333 (Attribute.Emit): Emit attribute for more owners when exist.
1335 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1336 it has now different behaviour.
1338 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1340 * constant.cs (Constant.IsDefaultInitializer): New method.
1342 * class.cs: Updated.
1344 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1345 re-initialize default values. It saves KBs almost for every assembly.
1346 Thanks Zoltan for the idea.
1347 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1348 (ArrayCreation.DoResolve): Resolve only once.
1349 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1350 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1352 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1354 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1357 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1359 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1360 in an embedded statement too.
1362 2006-04-01 Raja R Harinath <rharinath@novell.com>
1365 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1369 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1372 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1373 arguments before checking whether a type is reflected or not.
1376 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1377 definition doesn't take part in overload resolution.
1378 (Invocation.IsParamsMethodApplicable): Likewise.
1379 (Invocation.OverloadResolve): When replacing a reflected override
1380 method with its base definition, ensure that type arguments are
1383 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1387 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1390 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1392 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1394 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1397 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1398 LocalTemporary change.
1400 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1402 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1403 initializers optimization.
1404 (ClassOrStruct.TypeAttr): Moved from modifiers.
1405 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1406 (FieldBase.ResolveInitializer): Resolves initializer.
1407 (FieldBase.HasDefaultInitializer): New property.
1409 * cs-parser.jay: Removed message.
1411 * expression.cs (CompilerGeneratedThis): New specialization.
1413 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1415 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1417 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1419 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1421 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1422 be now EnumConstants only.
1424 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1426 * attribute.cs, driver.cs: Reset more caches.
1428 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1430 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1432 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1434 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1435 for easier reuse. Updated all overrides.
1436 (IntegralConstant): New base class for all integral constants.
1437 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1438 of the constant range, report custom error.
1439 (UIntConstant.Reduce): Fixed uint conversion.
1441 * ecore.cs, literal.cs: Reduce updates.
1443 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1447 * class.cs (Constructor.Define): Removed extra if for default ctors.
1448 A patch from Atsushi Enomoto.
1450 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1452 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1453 GetAttributableValue.
1455 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1458 * convert.cs (ImplicitConversionRequired): Error message moved to
1461 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1462 automatic implicit conversion of an output value.
1463 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1465 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1467 (TypeOf.GetAttributableValue): Add extra handling for object type.
1469 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1470 special error message.
1472 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1474 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1476 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1477 compatible with MS runtime.
1479 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1481 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1482 attribute arguments here.
1484 * class.cs (Indexer.Define): The check was moved to attribute class.
1486 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1488 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1490 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1492 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1494 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1497 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1499 * doc-bootstrap.cs : fix build.
1501 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1503 * expression.cs (StringConcat.Append): Issue a warning when empty string
1506 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1508 * assign.cs (CompoundAssign.ResolveSource): Removed.
1510 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1513 * class.cs (TypeContainer.FindMethods): Removed.
1514 (TypeContainer.CheckMemberUsage): Made static.
1516 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1518 * constant.cs (CheckRange): Removed unused type argument.
1519 (CheckUnsigned): Removed unused type argument.
1521 * cs-parser.jay: Updated after MemberAccess clean up.
1522 Uses Length for empty string test.
1524 * cs-tokenizer.cs: Uses Length for empty string test.
1525 (IsCastToken): Made static.
1526 (is_hex): Made static.
1527 (real_type_suffix): Made static.
1529 * decl.cs (SetupCache): Made static.
1530 (OnGenerateDocComment): Removed unused ds argument.
1532 * delegate.cs (VerifyDelegate): Removed unused argument.
1534 * doc.cs: Uses Length for empty string test.
1536 * driver.cs: Uses Length for empty string test.
1538 * enum.cs (IsValidEnumType): Made static
1540 * expression.cs (EnumLiftUp): Removed unused argument.
1541 (ResolveMethodGroup): Ditto.
1542 (BetterConversion): Ditto.
1543 (GetVarargsTypes): Ditto.
1544 (UpdateIndices): Ditto.
1545 (ValidateInitializers): Ditto.
1546 (MemberAccess.ctor): Ditto.
1547 (GetIndexersForType): Ditto.
1549 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1551 * iterators.cs: Updated after MemberAccess clean up.
1553 * location.cs: Uses Length for empty string test.
1555 * namespace.cs: Uses Length for empty string test.
1557 * report.cs (CheckWarningCode): Made static.
1559 * statement.cs (LabeledStatement): Removed unused argument.
1561 * typemanager.cs (FilterNone): Removed.
1563 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1565 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1568 * class.cs: Updated.
1570 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1572 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1574 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1578 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1580 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1581 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1582 Add more error reporting; Fixed issue with params.
1584 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1586 * cs-parser.jay: AnonymousMethod requires host container.
1588 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1590 2006-03-18 Raja R Harinath <harinath@gmail.com>
1592 * class.cs: Change 'TypeContainer ds' constructor argument to
1593 'DeclSpace parent'. Some classes were missed below due to
1594 different naming convention.
1596 * class.cs (MemberCore.Parent): Delete. This makes the
1597 ParentContainer changes below enforceable by the compiler.
1599 Treat pointers to enclosing declaration space as 'DeclSpace', not
1601 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
1602 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
1604 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
1606 (Block.AddThisVariable): Likewise.
1607 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
1608 (AbstractPropertyEventMethod.Emit): Likewise.
1609 (AbstractPropertyEventMethod.EmitMethod): Likewise.
1610 (GetMethod.Define, SetMethod.Define): Likewise.
1611 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
1612 (DelegateMethod.EmitMethod): Likewise.
1614 Fix regression test-partial-13.cs.
1615 Rationalize use of PartialContainer. Ensure that the partial
1616 class semantics can be tied to type-correctness, i.e., any
1617 violation will cause a compile error.
1618 * class.cs, const.cs: Access all fields that belong to class
1619 TypeContainer via ParentContainer. Arguments of EmitContexts and
1620 Resolve()-like functions still use 'Parent'.
1622 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
1623 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
1624 (PropertyMethod.CheckModifiers): Remove unused argument.
1625 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
1628 2006-03-28 Raja R Harinath <rharinath@novell.com>
1630 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
1632 2006-03-17 Raja R Harinath <harinath@gmail.com>
1634 Make semantics of PartialContainer simpler.
1635 * decl.cs (DeclSpace.IsPartial): Remove.
1636 * class.cs (TypeContainer.IsPartial): Likewise.
1637 (TypeContainer..ctor): Set PartialContainer to point to self.
1638 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
1639 (TypeContainer.FindNestedType): Likewise.
1640 (MemberCore.ParentContainer): Simplify. Remove deprecation.
1642 2006-03-17 Marek Safar <marek.safar@seznam.cz>
1644 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
1646 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1648 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
1651 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1653 * class.cs (Operator.Define): An error for base conversion was not
1656 2006-03-13 Marek Safar <marek.safar@seznam.cz>
1658 A fix for #77593, #77574.
1660 * class.cs (MethodCore.CheckBase): Another if for operator.
1662 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1666 * expression.cs (VerifyArgumentsCompat): Reverted to double error
1667 reporting, it's more tricky than I thought.
1669 2006-03-09 Marek Safar <marek.safar@seznam.cz>
1671 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
1674 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
1675 (DelegateCreation.ImplicitStandardConversionExists): New method for just
1678 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
1681 2006-03-04 Marek Safar <marek.safar@seznam.cz>
1685 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
1686 (Event.Define): ditto
1687 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
1689 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
1690 Removed redundant code and set NewSlot for Invoke method too.
1692 * parameter.cs (Parameters.ctor): Add custom, type ctor.
1693 (Parameters.MergeGenerated): New method. Use this method when you merge
1694 compiler generated argument with user arguments.
1696 2006-03-03 Marek Safar <marek.safar@seznam.cz>
1698 * attribute.cs (ResolveAsTypeTerminal): Removed.
1700 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
1701 specialization for predefined types; 30% speed up.
1702 Finally placed obsolete check to right place.
1703 (Expression.ResolveType): Removed.
1705 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
1706 Updated after ResolveType was removed.
1708 * expression.cs (Cast.ctor): Check void cast.
1709 (Binary.ResolveAsTypeTerminal): Is never type.
1710 (Conditional.ResolveAsTypeTerminal): Is never type.
1712 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
1714 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1716 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
1718 2006-03-23 Martin Baulig <martin@ximian.com>
1720 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
1721 type check if either of the types is an open generic type.
1723 2006-03-23 Martin Baulig <martin@ximian.com>
1726 (Convert.ExplicitTypeParameterConversion): New method; implement
1727 explicit type parameter conversions.
1729 2006-03-23 Martin Baulig <martin@ximian.com>
1731 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
1732 blindly allow all conversions if we do not have any constraints.
1734 2006-02-27 Marek Safar <marek.safar@seznam.cz>
1736 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
1737 these two separated members to simplify the code.
1738 (Attribute.Resolve): Refactored to use new fields and methods.
1739 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
1740 implemented obsolete attribute checking.
1741 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
1742 implemented obsolete checking again. It look line never ending quest ;-)
1743 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
1745 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
1747 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
1749 *class.cs (Property.Define): Add RegisterProperty call.
1751 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
1752 argument groups (only 2).
1754 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
1755 encoding expression to arguments.
1756 (Expression.ExprClassToResolveFlags): Just turned to property.
1758 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
1759 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
1760 optimized as well as implemented support for zero-length attributes.
1762 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
1763 Add caching of PropertyInfo's.
1765 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1767 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
1768 error multiple times.
1770 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1772 New partial class implementation.
1773 A fix for #77027, #77029, #77403
1775 * attribute.cs (Attributable): Made attributes protected.
1777 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
1778 the replacements of ClassPart and PartialContainer.
1779 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
1780 (TypeContainer.AddInterface): Ditto.
1781 (TypeContainer.AddPartial): The main method for partial classes. It checks
1782 for errors and merges ModFlags and attributes. At the end class is added to
1784 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
1786 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
1787 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
1788 from the rest of partial classes.
1789 (TypeContainer.GetClassBases): Simplified.
1790 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
1792 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
1793 (TypeContainer.HasExplicitLayout): Uses Flags now.
1794 (PartialContainer): Removed.
1795 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
1796 (StaticClass): Was merged with Class.
1797 (Class.GetClassBases): class and static class bases are verified here.
1798 (Class.TypeAttr): Added static attributes when class is static.
1799 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
1800 (MemberBase): In some cases we need to call parent container for partial
1801 class. It should be eliminated but it's not easy now.
1803 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
1805 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
1806 partial classed to accumulate class comments.
1807 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
1809 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
1811 * driver.cs (MainDriver): Tree.GetDecl was removed.
1813 * modifiers.cs (Modifiers): Add partial modifier.
1815 * tree.cs (Tree.decl): Removed.
1816 (RootTypes): Started to use this class more often for root types
1819 2006-03-23 Raja R Harinath <rharinath@novell.com>
1821 * generic.cs (TypeParameter.UpdateConstraints): Update
1822 'constraints' if null.
1824 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1828 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
1829 external interface does not have an attribute.
1831 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1833 Another prerequisites for new partial classs implementation.
1835 * attribute.cs (Attribute.Equal): Implemented.
1836 (Attribute.Emit): Changed as attributes can be applied more than twice.
1837 (Attributes.Emit): Check for duplicate attributes here.
1839 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
1840 as a parameter, clean-up.
1842 2006-02-11 Marek Safar <marek.safar@seznam.cz>
1846 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
1847 contains obsolete attribute check which can in some cases look for base
1848 type of current class which is not initialized yet.
1849 (TypeContainer.BaseType): Replacement of ptype.
1851 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
1853 2006-02-11 Marek Safar <marek.safar@seznam.cz>
1855 First of prerequisites for new partial classs implemention.
1857 * attribute.cs (Attributable): Extended by ResolveContext;
1858 Attributes finally have correct context for resolving in all cases.
1859 (AttachTo): Attribute owner is assigned here.
1861 * codegen.cs (IResolveContext): Introduce new interface to hold
1862 all information needed in resolving phase.
1863 (EmitContext): Implements IResolveContext; more clean-up needed here.
1865 * decl.cs (MemberCore): Implemented IResolveContext.
1867 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
1868 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
1869 parameter.cs, statement.cs, tree.cs, typemanager.cs:
1870 Refactored to use new IResolveContext instead of EmitContext; cleanup
1872 2006-03-22 Raja R Harinath <rharinath@novell.com>
1874 Support ParameterDefaultValueAttribute in gmcs. Also applied to
1875 mcs to keep code differences small.
1876 * attribute.cs (Attribute.GetParameterDefaultValue): New.
1877 * typemanager.cs (parameter_default_value_attribute_type): New.
1878 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
1881 2006-03-22 Martin Baulig <martin@ximian.com>
1884 (Nullable.NullableLiteral): Derive from `NullLiteral'.
1887 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
1888 instead of the normal `NullLiteral'.
1890 2006-03-21 Martin Baulig <martin@ximian.com>
1893 * generic.cs (TypeManager.InferType): If `pt' is a generic
1894 parameter, don't check whether `pt == at'.
1896 2006-03-20 Raja R Harinath <rharinath@novell.com>
1899 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
1900 (TypeParameter.Resolve): Update to change.
1901 (ConstraintChecker.CheckConstraints): Resolve type-argument
1902 constraints before use.
1904 2006-03-16 Martin Baulig <martin@ximian.com>
1907 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
1908 and don't have any instance constructors, also lookup in the base class.
1909 (TypeManager.IsNullableValueType): New public method.
1911 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
1912 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
1913 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
1915 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
1916 instead of just TypeManager.IsNullableType() to determine whether
1917 a lifted operator exists.
1918 (UnaryMutator.DoResolve): Likewise.
1919 (Conditional.DoResolve): Likewise.
1920 (Binary.DoResolve): A lifted operator only exists if both operands
1921 are valuetypes and at least one of them is a nullable type.
1923 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
1925 * iterator.cs : yield break is allowed in try statement which has
1926 catch clauses. Fixed bug #77767.
1928 2006-03-12 Martin Baulig <martin@ximian.com>
1930 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
1931 private IsSignatureEqual() to compare types; see the comment in
1932 that method; fixes #77674.
1934 2006-03-10 Raja R Harinath <rharinath@novell.com>
1936 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
1937 (Expression.ResolveAsTypeTerminal): Likewise.
1938 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
1939 * expression.cs, generic.cs, iterators.cs: Likewise.
1940 * parameter.cs, statement.cs, typemanager.cs: Likewise.
1942 2006-03-09 Martin Baulig <martin@ximian.com>
1944 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
1945 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
1947 2006-03-09 Martin Baulig <martin@ximian.com>
1949 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
1950 `prepared' flag is set.
1952 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
1953 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
1954 issues; see gtest-254.cs.
1956 2006-03-07 Martin Baulig <martin@ximian.com>
1958 * generic.cs (TypeManager.InferType): Allow infering
1959 `IEnumerable<T>' with an array of T; see gtest-251.cs.
1961 2006-03-06 Martin Baulig <martin@ximian.com>
1964 (TypeManager.InferType): Fix gtest-250.cs.
1967 (TypeManager.IsSubclassOf): Also check the base class.
1970 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
1973 2006-03-01 Raja R Harinath <rharinath@novell.com>
1976 * expression.cs (ParameterReference.DoResolveBase): Change return
1978 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
1982 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
1985 * typemanager.cs (GetFullNameSignature): Don't nullref on
1986 protected accessors.
1988 2006-02-16 Martin Baulig <martin@ximian.com>
1991 (TypeManager.GetGenericFieldDefinition): New public method; use it
1992 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
1994 2006-02-14 Martin Baulig <martin@ximian.com>
1996 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
1998 2006-02-14 Martin Baulig <martin@ximian.com>
2001 (TypeManager.DropGenericMethodArguments): New public method; don't
2002 use GetGenericMethodDefinition() on something which is not a
2005 2006-02-14 Martin Baulig <martin@ximian.com>
2008 (ConstraintChecker.CheckConstraints): If a type parameter has the
2009 `struct' constraint, the type must be a non-nullable valuetype.
2011 2006-02-10 Martin Baulig <martin@ximian.com>
2014 (TypeManager.IsOverride): Make this work for instantiated methods
2015 in a generic class; fixes #77509.
2016 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2017 rather than calling it directly; fixes #77488.
2019 2006-02-08 Martin Baulig <martin@ximian.com>
2021 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2022 reporting into CheckConstraint() so we can use the correctly
2025 2006-02-08 Martin Baulig <martin@ximian.com>
2027 * expression.cs (BaseAccess): Add support for generic methods.
2029 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2030 the new MethodGroupExpr.
2032 2006-02-07 Martin Baulig <martin@ximian.com>
2034 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2035 also reference types; fixes #77483.
2037 2006-02-07 Martin Baulig <martin@ximian.com>
2040 (TypeManager.IsGenericMethod): We now return whether something is
2041 an instantiated generic method (and not a generic method def).
2042 (TypeManager.IsGenericMethodDefinition): New public method.
2045 (TypeManager.CSharpSignature): Only include type arguments for
2046 "real" generic methods, not for any instantiated method.
2047 (TypeManager.GetMethodName): Likewise, but also allow generic
2048 method definitions here.
2050 2006-02-06 Miguel de Icaza <miguel@novell.com>
2052 * codegen.cs (EmitScopeInitFromBlock): check here the
2053 capture_context, there is no need to make two calls to the
2056 * anonymous.cs: Add some debugging messages that might help me
2057 track other instances of this problem in the future (the
2058 regression of test 467).
2060 * cs-parser.jay: track the variable block, as we need to initalize
2061 any captured variables declared in this block for the "catch"
2062 portion of the "Try" statement.
2064 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2065 scope initialization for captured variables.
2067 Also, move the emit for the variables after the block location has
2070 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2072 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2074 2006-02-06 Martin Baulig <martin@ximian.com>
2076 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2077 `TypeManager.value_type' as parent type to
2078 ModuleBuilder.DefineType(). Fixes #77358.
2080 2006-02-02 Miguel de Icaza <miguel@novell.com>
2082 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2083 commit yesterday, the initialization for the roots is necessary.
2084 What is not necessary is the scope activation.
2086 2006-02-02 Raja R Harinath <rharinath@novell.com>
2088 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2089 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2091 (Argument.Resolve): Remove CS0206 checks.
2093 2006-02-01 Miguel de Icaza <miguel@novell.com>
2095 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2096 scopes for all the roots, the scopes will now be emitted when the
2097 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2099 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2100 code. This reduces a lot of existing cruft.
2102 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2103 that the ScopeInfo is generated as we enter the scope, not at the
2104 time of use, which is what we used to do before.
2106 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2107 every time a Block is about to be emitted if we have a
2110 2006-02-01 Raja R Harinath <rharinath@novell.com>
2112 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2113 attribute for mscorlib too.
2115 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2117 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2119 * typemanager.cs (cons_param_array_attribute): Make private.
2120 (Reset): Set it to null.
2121 (InitCoreHelpers): Don't initialize it.
2122 (ConsParamArrayAttribute): New. Initialize it as needed.
2123 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2125 2006-01-31 Miguel de Icaza <miguel@novell.com>
2127 * expression.cs: There might be errors reported during the
2128 selection of applicable methods. If there are errors, do not
2129 continue execution as it will lead the compiler to crash.
2131 2006-01-30 Miguel de Icaza <miguel@novell.com>
2133 * expression.cs: Member access is not allowed on anonymous
2134 methods. Fixes #77402.
2136 2006-01-30 Raja R Harinath <rharinath@novell.com>
2139 * cs-parser.jay (VariableDeclaration): Don't set
2140 current_array_type to null.
2141 (field_declaration, event_declaration, declaration_statement):
2142 Set it to null here.
2144 2006-01-29 Raja R Harinath <harinath@gmail.com>
2147 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2149 2006-01-28 Raja R Harinath <harinath@gmail.com>
2151 * typemanager.cs (GenericParameterPosition): New.
2154 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2156 * doc.cs : To process "include" elements, first we should create
2157 another list than XmlNodeList, because it could result in node
2158 removal, which could result in that the XmlNodeList gives up
2161 2006-01-25 Miguel de Icaza <miguel@novell.com>
2163 * expression.cs: Introduce an error report that we were not
2164 catching before. Gonzalo ran into it.
2166 2006-01-23 Miguel de Icaza <miguel@novell.com>
2168 A fix for bug: #76957
2170 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2171 ComputeMethodHost before creating the method, this is a new
2174 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2175 that this method references (RegisterScope). The actual scope
2176 where the method is hosted is computed with the ComputeMethodHost
2177 before we create the method.
2179 Moved the Deepest routine here.
2181 (AnonymousContainer.ComputeMethodHost): New routine used to
2182 compute the proper ScopeInfo that will host the anonymous method.
2184 (ScopeInfo): Deal with multiple roots. The problem was that we
2185 did not have a unique root where all ScopeInfos could be hanged
2186 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2189 Remove AdjustMethodScope which is now computed at the end. Remove
2190 LinkScope which did a partial link, instead link all ScopeInfos
2191 before code generation from the new "LinkScopes" routine.
2193 Simplify all the Add* routines as they no longer need to maintain
2194 the tree, they just need to record that they are using variables
2197 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2198 routines to produce the forest of ScopeInfo trees.
2200 * class.cs (TypeContainer.AppendMethod): This is just like
2201 AddMethod, but ensures that an interface implementation method
2202 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2203 methods, but at the end.
2205 We use this functionality to ensure that the generated MoveNext
2206 method in the iterator class is resolved/emitted before the
2207 enumerator methods created.
2209 This is required because the MoveNext method computes the right
2210 ScopeInfo for the method. And the other methods will eventually
2211 need to resolve and fetch information computed from the anonymous
2215 2006-01-23 Raja R Harinath <rharinath@novell.com>
2217 Improve implementation of section 14.4.2.2 (Better function member).
2218 * expression.cs (Invocation.MoreSpecific): Compare all type
2219 arguments before deciding if one type is more specific than
2220 another. Handle array types too. Return the more specific type.
2221 (Invocation.BetterFunction): Add more tie-breaking rules from
2222 section 14.4.2.2. Perform "more specific" check after
2223 other tie-breaking rules. Compare all parameter types before
2224 choosing the "more specific" method.
2226 2006-01-21 Raja R Harinath <harinath@gmail.com>
2227 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2230 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2232 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2233 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2235 2006-01-18 Martin Baulig <martin@ximian.com>
2237 * class.cs (TypeContainer.AddToMemberContainer): Use
2238 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2241 2006-01-18 Martin Baulig <martin@ximian.com>
2243 Fix #76417: a generic class may now have methods which may unify
2244 for some type parameter substitutions.
2246 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2247 for methods which may unify anymore.
2249 * expression.cs (Invocation.MoreSpecific): New private static
2250 method; checks whether one method is more specific than another
2251 according to 14.4.2.2 of the spec.
2252 (Invocation.BetterFunction): Implement the tie-breaking rules from
2253 14.4.2.2 of the spec: if two methods unify for some type parameter
2254 substitution, we need to pick the more specific one.
2256 2006-01-18 Raja R Harinath <rharinath@novell.com>
2258 Fix #76656, cs0231-2.cs.
2259 * cs-parser.jay (formal_parameter_list): Make error case catch
2261 (parenthesized_expression_0): Add CS1026 check.
2262 (invocation_expression): Remove unused { $$ = lexer.Location }.
2264 2006-01-17 Raja R Harinath <rharinath@novell.com>
2267 * cs-parser.jay (statement_expression): Don't list out the
2268 individual statement-expressions. Convert syntax error into
2271 2006-01-16 Raja R Harinath <rharinath@novell.com>
2274 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2275 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2276 CheckIntermediateModification.
2277 (FieldExpr.DoResolve): Add new two-argument version that
2278 allows us to resolve the InstanceExpression as an lvalue.
2279 The one-argument variant is now just a wrapper.
2280 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2281 Resolve the lhs as an lvalue if the it has a value type.
2282 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2283 from Assign.DoResolve.
2284 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2285 resolved as an lvalue.
2286 (PropertyExpr.DoResolve): Update.
2287 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2288 has a value type. Move CS1612 check here from
2289 CheckIntermediateModification.
2290 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2291 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2292 'right_side' of a ResolveLValue on an 'out' argument.
2293 (EmptyExpression.LValueMemberAccess): New. Used as the
2294 'right_side' of a propagated ResolveLValue on a value type.
2295 (LocalVariableReference.DoResolveBase): Recognize
2296 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2298 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2299 EmptyExpression.Null.
2301 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2303 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2304 Type.IsGenericParameter(). Fixed bug #77183.
2305 * doc.cs : it is now identical to doc.cs in mcs.
2307 2006-01-16 Martin Baulig <martin@ximian.com>
2309 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2311 2006-01-16 Martin Baulig <martin@ximian.com>
2313 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2314 ctors; fixes #77250.
2316 2006-01-12 Miguel de Icaza <miguel@novell.com>
2318 This fixes the problem where we used ldfld instead of ldflda to
2319 load the "THIS" pointer on captured parameters, when THIS is a
2320 value type. See bug #77205.
2322 * iterators.cs (CapturedThisReference.Emit): Pass false to
2323 EmitThis (we do not need the address).
2325 * codegen.cs (EmitThis): it needs to know whether we need the
2326 address of `this' or not. This is used by value types.
2328 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2329 every other call passes false.
2331 2006-01-12 Raja R Harinath <rharinath@novell.com>
2334 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2336 * expression.cs (Invocation.OverloadResolve): Update.
2337 (Invocation.DoResolve): Avoid double resolution of invocation.
2339 2006-01-11 Raja R Harinath <rharinath@novell.com>
2342 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2343 unary negation of floating point types as 0-expr; negation cannot
2344 overflow in floating point types.
2347 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2348 on operands of 'void' type.
2351 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2352 and ExclusiveOr for boolean constants too.
2354 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2356 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2358 2006-01-12 Miguel de Icaza <miguel@novell.com>
2360 * cs-tokenizer.cs (Position): New class used to save and restore
2361 the position state in the tokenizer. Before this patch the save
2362 and restore was not complete enough so the line and columns would
2363 start to drift and the debugger and stack traces will get the
2366 2006-01-10 Martin Baulig <martin@ximian.com>
2369 (TypeParameter.InflateConstraints): New public method.
2371 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2372 constraints; fixes #77042.
2374 2006-01-10 Martin Baulig <martin@ximian.com>
2376 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2377 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2380 2006-01-09 Raja R Harinath <rharinath@novell.com>
2383 * expression.cs (Invocation.OverloadResolve): Replace reflected
2384 override methods with their base virtual methods, rather than
2386 * typemanager.cs (TypeManager.GetOverride): New.
2388 2005-12-21 Miguel de Icaza <miguel@novell.com>
2390 * driver.cs: Report the case of no source files and no -out:
2393 2005-12-20 Raja R Harinath <rharinath@novell.com>
2396 * expression.cs (ComposedCast.GetSignatureForError): Define.
2398 2006-01-05 Jb Evain <jbevain@gmail.com>
2400 * class.cs (Property.Define, Indexer.Define): do not tag the
2401 properties as SpecialName | RTSpecialName.
2403 2006-01-04 Miguel de Icaza <miguel@novell.com>
2405 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2406 doing a low-level comparission of parameter types. It was lacking
2407 a check for __argslist.
2409 2005-12-30 Miguel de Icaza <miguel@novell.com>
2411 * expression.cs (ParameterReference.DoResolveBase): Allow
2412 reference parameters if they are local to this block.
2414 This allows the ref and out parameters of a delegate to be used in
2415 an anonymous method, for example:
2417 delegate void set (out int x);
2419 set s = delegate (out int x){
2423 This is used by functionality introduced late in the C# language.
2425 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2426 method that take ref and out parameters.
2428 Fixes #77119 which was a late change in the spec.
2430 2005-12-23 Miguel de Icaza <miguel@novell.com>
2432 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2433 parent if its the same scope. Fixes #77060.
2435 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2437 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2439 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2441 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2442 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2443 that doesn't contain the full public key. This is a update of the
2444 friend assemblies in .Net 2.0 release.
2446 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2450 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2451 ListDictionary, to contain the ExternAliasEntry entries (in
2452 addition to the NamespaceEntry.aliases hashtable). This field is
2453 shared between the original entry and its doppelganger (bodyless
2455 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2456 extern_aliases field.
2457 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2458 lookup in extern_aliases.
2460 2005-12-16 Raja R Harinath <rharinath@novell.com>
2463 * class.cs (TypeContainer.Mark_HasEquals): New.
2464 (TypeContainer.Mark_HasGetHashCode): New.
2465 (ClassPart): Override them.
2466 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2468 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2469 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2473 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2474 'parent' argument to the base constructor.
2476 Remove all mention of TypeContainer from decl.cs.
2477 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2478 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2479 (DeclSpace.DeclSpace): Likewise.
2480 (DeclSpace.DefineMembers): Remove unused argument.
2481 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2482 debugging check -- we don't care if the debug code throws an
2483 InvalidCastException instead of an InternalErrorException.
2484 * class.cs (TypeContainer.DefineMembers): Update to changes.
2485 (TypeContainer.DoDefineMembers): Likewise.
2486 (TypeContainer.GetMethods): Likewise.
2487 (PropertyMember.Define): Likewise.
2488 (MemberBase.Parent): New property that forwards to
2489 MemberCore.Parent, but ensures that we get a TypeContainer.
2490 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2491 (RootContext.PopulateTypes): Likewise. Remove special case code
2492 for !RootContext.StdLib: DefineMembers is idempotent.
2494 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2496 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2498 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2500 * doc.cs : The search for referenced namespace was insufficient to
2501 get global one as it used to do. Fixed bug #76965.
2503 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2505 * doc.cs : check name in cref in the last phase that whether it is
2508 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2510 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2513 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2515 * doc.cs : so it turned out that we cannot skip override check for
2516 interface members. Fixed bug #76954.
2518 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2520 * cs-tokenizer.cs : fixed bug #75984:
2521 - #warning and #error should not be handled when the source line
2523 - #line is not checked strictly when the source line is disabled.
2524 - #define and #undef is on the other hand checked strictly at any
2527 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2529 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2532 2005-12-15 Raja R Harinath <rharinath@novell.com>
2534 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2536 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2539 2005-12-14 Martin Baulig <martin@ximian.com>
2541 * typemanager.cs (TypeManager.GetFullName): Make this public;
2542 `Type.Fullname' now never returns null.
2544 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2545 explicit interface implementations; we're now using the same
2546 naming convention than csc does.
2548 2005-12-14 Miguel de Icaza <miguel@novell.com>
2550 * convert.cs (ExplicitConversionCore): Check the return value from
2551 ExplicitConversionCore which can return null on failure. Fixes #76914
2553 2005-12-09 Raja R Harinath <rharinath@novell.com>
2555 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2556 instead of IsGenericInstance.
2557 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2558 code that's now covered by the more general test.
2559 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2561 * generic.cs (DropGenericTypeArguments): New. Captures the common
2562 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2563 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2564 * generic.cs, report.cs, typemanager.cs: Likewise.
2566 2005-12-08 Martin Baulig <martin@ximian.com>
2568 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2570 * typemanager.cs (TypeManager.CSharpSignature): Include type
2571 arguments in the signature of a generic method.
2573 2005-12-07 Martin Baulig <martin@ximian.com>
2575 Add support for custom attributes on type parameters.
2577 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2579 * generic.cs (TypeParameterName): New public class; we use this
2580 instead of a `string' to store the name of a type parameter, so we
2581 can also have `Attributes'.
2582 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2583 array instead of a `string[]' array.
2584 (TypeParameter.ctor): We now also take an `Attributes' argument.
2585 (TypeParameter.EmitAttributes): New public method; emit our
2586 `OptAttributes' here.
2587 (GenericMethod.EmitAttributes): New public method; emit the custom
2588 attributes on all our type parameters.
2590 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2591 our type parameters.
2592 (MethodData.Define): If we're a generic method, call
2593 EmitAttributes() on it.
2595 2005-12-07 Martin Baulig <martin@ximian.com>
2598 (ConstraintChecker): New public abstract class; move the
2599 constraint checking here from `ConstructedType' and also do
2600 constraint checking for generic methods here.
2602 * expression.cs (Invocation.OverloadResolve): Use
2603 ConstraintChecker.CheckConstraints() if we resolved to a generic
2606 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2608 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
2610 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
2612 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
2613 (FieldBase.Initializer): Initializer is now optional.
2614 (EventField.Define): Only event field can have initializer.
2616 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
2618 * const.cs (Const): Reuse initializer.
2620 * cs-parser.jay: Updated after FieldBase changes.
2621 Added current_array_type to simplify array initializers.
2623 * ecore.cs (NullCast.IsDefaultValue): Implemented.
2625 * expression.cs, iterators.cs: Updated.
2627 * namespace.cs (NamespaceEntry): Made UsingFound private.
2629 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2631 * parameterCollection.cs: Obsolete, removed.
2632 * parser.cs: Obsolete, removed.
2634 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2637 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
2639 * enum.cs (Enum.Define): Set obsolete context here.
2641 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2644 - FindDocumentedMember() now expects 1) paramList as null
2645 when "we don't have to check the number of parameters" and
2646 2) Type.EmptyTypes when "there is no arguments".
2647 - Introduced FoundMember struct to hold the exact type which was
2648 used to find the documented member (the above change broke
2649 test-xml-044; it might be better just to use DeclaringType than
2650 what MS does, like this change does, but it depends on usage.)
2652 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2654 * doc.cs : documented member might be from DeclaringType for nested
2655 types. Fixed bug #76782.
2657 2005-12-03 Ben Maurer <bmaurer@ximian.com>
2659 * anonymous.cs: Have the param code handle leaving copies on the
2660 stack etc. Allows anonymous params to take part in the assignment
2661 code (++, +=, etc). Fixes bug #76550
2663 * expression.cs: Handle the prepare_for_load/leave_copy by passing
2664 it down to the anon code.
2666 * iterators.cs: Use dummy var here
2668 * codegen.cs: Handle new vars
2670 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2673 * class.cs (MethodData.Define): Set proper Obsolete context.
2675 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
2677 (FieldExpr.DoResolve): Ditto.
2679 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2682 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
2683 parent is not obsolete.
2685 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
2687 * doc.cs : (FindDocumentedMember) find parameterless members first
2688 and get CS0419 in the early stage. Fixed first case of bug #76727.
2690 2005-11-30 Marek Safar <marek.safar@seznam.cz>
2693 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
2694 no error was reported.
2696 *expression.cs (Binary.DoResolve): left can be null.
2698 2005-12-06 Raja R Harinath <rharinath@novell.com>
2700 * class.cs (MethodCore.CheckGenericOverride): Delete unused
2701 abstract method and all overrides.
2702 * support.cs (ParameterData.GenericConstraints): Delete.
2703 (ReflectionParameters.type_params): Delete.
2704 (ReflectionParameters.ReflectionParameters): Make private.
2705 (ReflectionParameters.GetConstaints): New factory method.
2706 * generic.cs (TypeParameterDefineType): Use it.
2707 (TypeManager.GetTypeParameterConstraints): Likewise.
2709 2005-11-22 Marek Safar <marek.safar@seznam.cz>
2712 * class.cs (MethodData.Emit): Parameters should be labeled first.
2714 2005-11-21 Marek Safar <marek.safar@seznam.cz>
2717 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
2719 2005-11-18 Marek Safar <marek.safar@seznam.cz>
2721 * attribute.cs (AreParametersCompliant): Moved to Parameter.
2723 * class.cs (MethodCore): Parameter clean up.
2724 (IMethodData): Added ParameterInfo.
2725 (MethodData): Parameter clean up.
2726 (Indexer.Define): Parameter clean up.
2738 * typemanager.cs: Parameter clean up.
2740 * delegate.cs (Define): Get rid of duplicated code.
2742 * expression.cs (ParameterReference): Removed useless parameters
2744 (Invocation): Ditto.
2746 * parameter.cs (ParamsParameter): New class, params specialization.
2747 (ArglistParameter): Attemp to separate arglist.
2748 (Parameter): Refactored to be reusable and faster.
2749 (Parameter.Modifier): Made understandable.
2750 (Parameters): Changed to be used as a class for `this' assembly
2751 parameters. Refactored to use new specialized classes.
2753 * support.cs (ParameterData): Added Types property.
2754 (InternalParameters): Deleted.
2756 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2758 * doc.cs : the previous patch does not actually fix the bug.
2759 PropertyInfo override check is now implemented and really fixed it.
2760 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
2762 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2764 * doc.cs : apply "override filter" also to properties.
2767 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2769 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
2770 no need to check overrides. For classes, omit those results from
2771 interfaces since they must exist in the class. Fixed bug #76726.
2773 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2775 * typemanager.cs : (GetFullNameSignature) differentiate indexers
2776 with different parameters. Fixed the second problem in #76685.
2778 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2780 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
2781 get expected 'protected' access in CheckValidFamilyAccess()).
2784 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2786 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
2787 Fixed bug #76705. CS1569 was incorrectly commented out.
2789 2005-11-23 Martin Baulig <martin@ximian.com>
2791 * generic.cs (Constraints.Define): Removed.
2792 (TypeParameter.DefineConstraints): Removed.
2793 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
2794 on the GenericTypeParameterBuilder here.
2796 2005-11-23 Martin Baulig <martin@ximian.com>
2798 * typemanager.cs (TypeManager.GetProperty): Make this public.
2800 * generic.cs (Nullable.NullableInfo.ctor): Use
2801 TypeManager.GetProperty() rather than using reflection directly.
2803 2005-11-17 Martin Baulig <martin@ximian.com>
2805 * expression.cs (Indexers.GetIndexersForType): Added support for
2806 generic parameters; fixes #76587.
2808 2005-11-17 Martin Baulig <martin@ximian.com>
2811 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
2812 inherit the scope from our parent. Fixes #76653.
2814 2005-11-15 Martin Baulig <martin@ximian.com>
2816 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
2817 instead of `ScopeTypeBuilder' to refer to the "current" type.
2818 (AnonymousMethod.CreateScopeType): Correctly create the helper
2819 class if we're inside a generic type definition.
2821 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2823 * doc.cs : use Invocation.IsOverride() to do real override check.
2824 * expression.cs : made Invocation.IsOverride() internal.
2826 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2828 * doc.cs : use TypeManager.FindMembers() instead of (possible)
2829 TypeBuilder.FindMembers() and filter overriden base members out.
2832 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2834 * doc.cs : ref/out parameters are represented as '@' (instead of
2835 '&' in type FullName). Fixed bug #76630 (additionally crefs).
2837 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2839 * doc.cs : when there was no '.' in cref to methods in doc comment,
2840 then parameters were missing in the output. Fixed bug #76691.
2842 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2844 * driver.cs : don't output docs when there is an error.
2847 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2850 Now it should detect indexers. Fixed primary concern in bug #76685.
2851 Fixed CS0419 message to not show the identical member signature in
2854 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2856 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
2857 instead of Type.FindMembers() since it does not handle events.
2860 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
2862 * codegen.cs: Fixed typo (speficied -> specified).
2864 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2867 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
2869 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2871 * attribute.cs: Changed error message.
2873 * cs-tokenizer.cs: One more check.
2875 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2877 * statement.cs (Block.Resolve): Ignore empty statement.
2879 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2881 * report.cs: Made error/warning methods more strict to avoid
2884 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
2885 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
2886 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
2887 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
2889 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2891 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
2892 Use the more explicit AssemblyName.FullName instead of
2893 AssemblyName.Name to report errors.
2895 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2897 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
2900 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2910 * report.cs: Fixed error reporting and typos.
2912 * generic.cs (TypeParameter.GetSignatureForError): New method.
2913 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
2915 * typemanager.cs (GetFullName): Refactored.
2917 2005-11-08 Marek Safar <marek.safar@seznam.cz>
2919 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
2920 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
2922 * class.cs (TypeContainer.IsComImport): New property.
2923 (Constructor.Define): Create proper ctor for ComImport types.
2925 * expression.cs (New.CheckComImport): Fixed.
2927 2005-11-07 Miguel de Icaza <miguel@novell.com>
2929 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
2930 that a parameter has been captured does not mean that we do not
2931 have to do the rest of the processing. This fixes the second part
2932 of #76592. If there was another anonymous method capturing
2933 values in the past, the Scope would never be set for the second
2934 method that captured the same parameter.
2936 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
2937 properly manipulate the stack. Second part of fix for #76592.
2939 * expression.cs (New): Add support for invoking "new" on
2940 interfaces that have been flagged with the ComImport attribute and
2941 the CoClass. Fixes #76637
2943 * statement.cs (Try.DoEmit): When a variable is captured, do not
2944 try to emit the vi.LocalBuilder variable as it has been captured.
2945 Create a temporary variable and store the results on the
2946 FieldBuilder. Fixes #76642
2948 2005-11-07 Marek Safar <marek.safar@seznam.cz>
2950 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
2952 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
2954 * expression.cs (Binary.DoResolve): Added && optimalization.
2956 * typemanager.cs (AddUserType): Removed useless argument.
2958 2005-11-04 Marek Safar <marek.safar@seznam.cz>
2960 * statement.cs (Block.variables): Uses ListDictionary.
2962 2005-11-03 Marek Safar <marek.safar@seznam.cz>
2965 * class.cs (PartialContainer.EmitType): Customized to emit
2966 security attributes.
2967 (ClassPart.ApplyAttributeBuilder): Transform security attribute
2968 for partial classes.
2970 2005-11-03 Marek Safar <marek.safar@seznam.cz>
2973 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
2974 access has to be fixed.
2976 * typemanager.cs (IsUnmanagedType): Wrong common field type.
2978 2005-11-01 Marek Safar <marek.safar@seznam.cz>
2981 * ecore.cs (NullCast.Reduce): Implemented.
2983 * expression.cs (ArrayCreation.CheckIndices): Correcly check
2986 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
2988 (Foreach.Resolve): Catch null properly.
2990 2005-10-29 Marek Safar <marek.safar@seznam.cz>
2992 * cs-tokenizer.cs: Warning text fix.
2994 * driver.cs: AllWarningNumbers exposed on public interface.
2996 * report.cs (): Reviewed warning numbers.
2997 (IsValidWarning): Use binary search.
2999 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3001 * driver.cs: Implemeted resource visibility.
3002 (Resources): New class for code sharing between /res: and
3005 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3007 decl.cs (CurrentTypeParameters): Fixed to be public.
3009 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3011 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3013 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3015 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3017 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3019 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3021 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3023 Add friend assembly access support.
3024 * typemanager.cs: assembly_internals_vis_attrs
3025 cache for friend assembly access.
3026 (TypeManager.IsFriendAssembly): New method for
3027 checking friend assembly access.
3028 (TypeManager.Error_FriendAccessNameNotMatching): New
3030 (TypeManager.CompareKeyTokens): Likewise.
3031 (TypeManager.Filter): Handle friend accessible
3034 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3035 friend accessible types.
3037 * ecore.cs (Expression.IsAccessorAccessible): Handle
3038 friend accessible properties.
3040 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3043 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3046 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3049 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3052 * ecore.cs (NullCast): Child is contant only.
3054 * literal.cs (NullLiteral.Reduce): null can be converted to any
3057 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3059 * driver.cs: Use Encoding.Default as default code page instead
3062 2005-10-27 Raja R Harinath <rharinath@novell.com>
3065 * expression.cs (Invocation.Error_InvalidArguments): Handle
3066 __arglist parameters.
3067 (Invocation.VerifyArgumentsCompat): Likewise.
3068 * support.cs (ReflectionParameters.GetSignatureForError): Print
3069 __arglist parameters.
3070 (InternalParamters.GetSignatureForError): Likewise.
3071 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3073 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3075 * attribute.cs (GetPropertyValue): Made public.
3077 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3079 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3081 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3084 * driver.cs: Reflect method name change.
3086 * statement.cs (Try.Resolve): Warn when try has both general
3089 * typemanager.cs: runtime_compatibility_attr_type new predefined
3092 2005-10-26 Raja R Harinath <harinath@gmail.com>
3095 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3096 treat it as an empty parameter list.
3098 2005-10-26 Raja R Harinath <rharinath@novell.com>
3101 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3102 ResolveAsTypeStep silent.
3103 * statement.cs (Block.AddConstant): Mark block as used.
3104 (Block.ResolveMeta): Avoid piling on error messages
3105 if a constant initializer resolution fails.
3107 2005-10-25 Raja R Harinath <rharinath@novell.com>
3109 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3111 (NamespaceEntry.VerifyAllUsing): New.
3112 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3113 behaviour. Delegates actual resolution of alias to ...
3114 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3115 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3117 * driver.cs (Driver.MainDriver): Update.
3119 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3120 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3122 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3124 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3125 RootNamespace.DefineNamespacesForAll.
3127 2005-10-24 Raja R Harinath <harinath@gmail.com>
3129 * typemanager.cs (assemblies, external_aliases, modules)
3130 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3131 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3132 overhead. Move resposibility ...
3133 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3134 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3136 2005-10-23 Raja R Harinath <harinath@gmail.com>
3138 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3139 cached_namespaces. Improve usage.
3140 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3141 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3142 Move from GlobalRootNamespace and simplify.
3143 (RootNamespace.Global): Make instance variable.
3144 (RootNamespace.RootNamespace): Add "alias name" parameter.
3145 (GlobalRootNamespace): Simplify drastically.
3146 (Namespace.Lookup): Don't use GetNamespace.
3147 * typemanager.cs (GetRootNamespace): Rename from
3148 ComputeNamespaceForAlias.
3149 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3151 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3153 * anonymous.cs (AnonymousContainer): Don't crash when container
3156 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3158 * expression.cs (Binary.DoResolve): Warn when comparing same
3161 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3164 * expression.cs (Binary.DoResolve): It looks like there are no
3165 convetsion rules in enum context.
3167 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3169 Add support for extern alias qualifiers.
3170 * typemanager.cs: Move some LookupTypeReflection code
3171 to namespace.cs, to have cleaner code. Added some methods
3172 to help us keep track of the extern aliased references.
3173 * driver.cs: Add suport for extern alias assemblies on command
3174 line and check for their warnings/errors. Also keep track of the
3175 extern aliased assemblies.
3176 * namespace.cs: Move the global functionality of Namespace
3177 to GlobalRootNamespace/RootNamespace. Now the global namespace
3178 is GlobalRootNamespace.Globa. Also the code moved from
3179 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3180 Finally added LocalAliasEntry (AliasEntry before) and
3181 ExternAliasEntry, to handle alias statements.
3182 * cs-parser.jay: Add support in the grammar for extern alias
3184 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3185 Update callings to Namespace (now in GlobalRootNamespace).
3187 2005-10-25 Martin Baulig <martin@ximian.com>
3189 * convert.cs (ImplicitTypeParameterConversion): Make base
3190 interfaces actually work; fixes #76557.
3192 2005-10-25 Martin Baulig <martin@ximian.com>
3195 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3196 all the type parameters; fixes #76551.
3198 2005-10-25 Martin Baulig <martin@ximian.com>
3203 (GenericMethod.ctor): Added `Expression return_type' and
3204 `Parameters parameters' arguments.
3205 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3206 parameter and return types to check their constraints if they're
3209 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3212 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3213 constraints of a generic type if `ec.ResolvingGenericMethod'.
3215 * class.cs (MethodCore.DoDefineParameters): Set
3216 `ec.ResolvingGenericMethod' if we're a generic method.
3217 (MemberBase.MemberType): Likewise.
3219 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3221 * typemanager.cs (TypeManager): Added
3222 TypeManager.internals_visible_attr_type to cache
3223 S.R.CompilerServices.InternalsVisibleToAttribute.
3225 * codegen.cs (AssemblyClass): Added checks for
3226 InternalsVisibleToAttribute in new method
3227 CheckInternalsVisibleAttribute () and also cache the
3228 AssemblyName in AssemblyClass.Name.
3230 2005-10-24 Martin Baulig <martin@ximian.com>
3233 (TypeManager.ExpandInterfaces): Added overloaded version which
3234 just takes a `Type[]' array.
3237 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3238 just use the interfaces which were explicitly specified and not
3239 the interfaces they inherit. Fixes #76482.
3240 (TypeParameter.FindMembers): Expand the interfaces here.
3242 2005-10-21 Martin Baulig <martin@ximian.com>
3245 (Constraints.Resolve): Also resolve the actual types here.
3246 (Constraints.ResolveTypes): Just check the constraints here.
3247 Fixes #76363; see gtest-218.cs.
3249 2005-10-21 Martin Baulig <martin@ximian.com>
3252 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3253 instead of a `BoxedCast'; fixes gtest-217.cs.
3255 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3257 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3258 1) "new()" is specified as generic parameter constraint and 2) the
3259 type is TypeBuilder and 3) the type is abstract even if it has a
3260 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3262 2005-10-20 Martin Baulig <martin@ximian.com>
3265 (GenericConstraints.TypeParameter): New public property.
3266 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3267 (TypeParameter.DeclSpace): New public property.
3268 (TypeParameter.DefineType): Inflate the constraints if our
3269 `DeclSpace' is an `Iterator'.
3271 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3273 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3274 GenericMethod argument to compare methods' generic type arguments.
3277 2005-10-19 Martin Baulig <martin@ximian.com>
3279 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3280 not ResolveType() when resolving the base type, so we're not
3281 checking the constraints here.
3282 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3285 2005-10-19 Martin Baulig <martin@ximian.com>
3287 * generic.cs (ConstructedType.CheckConstraints): Committing
3288 untested fix for #76441.
3290 2005-10-18 Raja R Harinath <rharinath@novell.com>
3293 * class.cs (TypeContainer.DefineType): Move updating of
3294 topological sort earlier in the code.
3295 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3297 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3300 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3302 * constant.cs (Constant.TryReduce): Moved from Cast class.
3303 (Reduce): Made little bit more OO and fixed missing conversions.
3305 * ecore.cs (Reduce): Implemented.
3306 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3308 * literal.cs (Reduce): Implemented.
3310 * class.cs: Reverted Miguel's wrong commit.
3312 2005-10-14 Miguel de Icaza <miguel@novell.com>
3314 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3316 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3318 * cs-parser.jay, expression.cs : CS0214 was missing error location
3319 for constants. Fixed bug #76404.
3321 2005-10-10 Raja R Harinath <rharinath@novell.com>
3323 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3325 (PropertyExpr.EmitCall): Likewise.
3326 * expression.cs (Invocation.EmitArguments): Handle case where
3328 (Invocation.EmitCall): Avoid allocating temporary variable if
3329 there are no arguments.
3331 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3334 * convert.cs (ExplicitConversionCore): Fixed object->enum
3337 2005-10-07 Raja R Harinath <rharinath@novell.com>
3340 * convert.cs (ImplicitConversionStandard): Move conversion of
3341 void* to arbitrary pointer types ...
3342 (ExplicitConversionStandard): .. here.
3343 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3344 error to always print typenames.
3346 2005-10-07 Raja R Harinath <rharinath@novell.com>
3348 * convert.cs (GetConversionOperator): Rename from
3349 GetConversionOperators. Move operator selection code from ...
3350 (UserDefinedConversion): ... here.
3352 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3354 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3357 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3359 * assign.cs (Assign.DoResolve): Error method changed.
3361 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3363 * const.cs (ResolveValue): Reset in_transit immediately.
3365 * constant.cs: Error method changed.
3367 * convert.cs: Removed useless location parameter.
3368 (ExplicitNumericConversion): Don't do double enum check.
3369 (ExplicitConversionCore): Renamed from ExplicitConversion.
3370 (ExplicitUnsafe): Extracted from ExplicitConversion.
3371 (ExplicitConversion): Uses for error reporting.
3373 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3375 (ResolveBoolean): Uses common error method.
3376 (CastToDecimal): Get rid of ec.
3377 (CastFromDecimal): Optimized.
3378 (ConvCast): Get rid of ec.
3380 * enum.cs (ResolveValue): Reset in_transit immediately.
3381 (Emit): Return after first error.
3383 * expression.cs: Convert changes.
3385 * literal.cs: Error method changed.
3387 * statement.cs: Error method changed.
3389 2005-10-06 Raja R Harinath <rharinath@novell.com>
3391 Fix gtest-131.cs and gtest-211.cs.
3392 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3393 Only emit code for a label if it is used. Unreachable code can
3394 violate ECMA evaluation stack invariants.
3396 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3398 * anonymous.cs: Implemented ExprClassName.
3400 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3403 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3406 * class.cs (StaticClass.DefineContainerMembers): Report protected
3409 * codegen.cs: if(ed) PRODUCTION.
3411 * convert.cs (Error_CannotImplicitConversion): Better error
3414 * cs-parser.jay: More error checks.
3416 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3418 * driver.cs (CSCParseOption): Enabled wrong option check.
3420 * ecore.cs (Expression.ExprClassName): Turned to property.
3421 (MemberExpr.CheckIntermediateModification): For checking boxed
3422 value types modification.
3424 * statement.cs (Fixed.Resolve): Expression type must be
3425 convertible to fixed type.
3426 (CollectionForeach.GetEnumeratorFilter,TryType):
3427 Small refactoring for easier error checking.
3429 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3431 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3434 * class.cs (GeneratedBaseInitializer): New class for customization
3435 compiler generated initializers.
3436 (MemberBase.DoDefine): Check Obsolete attribute here.
3437 (FieldMember.DoDefine): Ditto.
3439 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3442 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3443 (MemberCore.GetObsoleteAttribute): Removed argument.
3444 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3445 (MemberCore.CheckObsoleteType): New helper.
3449 * statement.cs: Updates after MemberCore changes.
3451 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3452 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3454 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3455 obsolete attribute for compiler construct.
3456 (As.DoResolve): Cache result.
3458 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3460 2005-10-01 Miguel de Icaza <miguel@novell.com>
3462 * expression.cs (Probe): instead of having a "Type probe_type"
3463 keep the extra information as a TypeExpr probe_type_expr since the
3464 "As" operator needs to perform some type checks.
3466 * (As.DoResolve): If the type is a type parameter, ensure that it
3467 is constrained by a class.
3469 2005-09-22 Miguel de Icaza <miguel@novell.com>
3471 * statement.cs (Lock): Use the TemporaryVariable class instead of
3472 manually using local variables as those do not work when variables
3475 * ecore.cs: Moved the TemporaryVariable class from being a nested
3476 class inside Foreach to be a public class that can be employed in
3479 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3481 * cs-parser.jay: interface_accessors replaced by
3482 accessor_declarations.
3484 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3487 * statement.cs (GotoCase.Resolve): Convert null constant to
3489 (SwitchLabel.ResolveAndReduce): Ditto.
3490 (SwitchLabel.NullStringCase): Custom null stamp.
3491 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3493 typemanager.cs (CSharpSignature): Don't skip first argument
3496 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3498 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3499 expression.cs, iterators.cs, literal.cs: Store constants and
3502 * class.cs (MemberBase.ShortName): Pass location.
3504 * cs-parser.jay: Some location fixes.
3506 * ecore.cs (Expression.Location): Made virtual.
3508 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3511 * const.cs (Const.ResolveValue): Check for assigning non-null
3512 value to reference type.
3514 2005-09-26 Raja R Harinath <rharinath@novell.com>
3517 * expression.cs (This.VerifyFixed): In a value type T, the type of
3518 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3519 value type R, 'this' is treated as a value parameter.
3521 2005-09-05 Miguel de Icaza <miguel@novell.com>
3523 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3524 if the underlying types are the same, otherwise we need to produce
3525 code that will do the proper cast.
3527 This was exposed by Marek's constant rewrite which produced
3528 invalid code for the call site:
3531 void Method (X v) {}
3535 This fixes test-49.cs
3537 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3539 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3540 Type/Object should be allowed as well. Fixed bug #75968.
3542 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3544 * expression.cs : (Binary.DoResolve): when one is enum constant and
3545 another is constant 0, then return enum one *as enum type*.
3548 2005-10-04 Martin Baulig <martin@ximian.com>
3550 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3551 `SetMemberIsUsed()' work for generics, too.
3553 2005-10-04 Martin Baulig <martin@ximian.com>
3555 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3556 for corlib. Fixes #75691.
3558 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3561 * driver.cs: Fix compilation files with full root path.
3563 2005-09-25 Miguel de Icaza <miguel@novell.com>
3565 * report.cs (SymbolRelatedToPreviousError): Format the output so
3566 it does not use an open parenthesis that is never closed.
3568 * driver.cs: Follow coding guidelines
3570 2005-09-18 Miguel de Icaza <miguel@novell.com>
3572 * driver.cs: Set InEmacs based on the environment variable EMACS.
3574 * location.cs (InEmacs): in this mode, do not report column
3575 location as it confuses Emacs.
3577 2005-10-03 Raja R Harinath <rharinath@novell.com>
3579 * support.cs (SeekableStreamReader.Position): Don't error out when
3580 the requested position is just beyond the end of the current
3583 2005-09-28 Raja R Harinath <rharinath@novell.com>
3585 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3586 try to keep in sync with the byte count of the underlying Stream.
3587 However, this limits us to a window size of 2048 characters: i.e.,
3588 the maximum lookahead of our lexer/parser can be 2048 characters.
3590 2005-09-22 Martin Baulig <martin@ximian.com>
3592 * driver.cs: Removed a debugging FIXME.
3594 2005-09-21 Raja R Harinath <rharinath@novell.com>
3596 * cs-parser.jay (type_arguments): Add CS1644 check.
3597 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3599 2005-09-15 Raja R Harinath <rharinath@novell.com>
3601 * Makefile (PROGRAM): Make profile specific.
3602 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
3603 the current directory.
3606 * expression.cs (Invocation.EmitCall): Remove optimization on
3607 this_call since it doesn't handle 'this' being a value type.
3609 2005-09-05 Geoff Norton <gnorton@customerdna.com>
3611 * driver.cs: Ensure file handles are closed after parsing
3613 2005-09-05 Miguel de Icaza <miguel@novell.com>
3615 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3616 if the underlying types are the same, otherwise we need to produce
3617 code that will do the proper cast.
3619 This was exposed by Marek's constant rewrite which produced
3620 invalid code for the call site:
3623 void Method (X v) {}
3627 This fixes test-49.cs
3629 2005-09-05 Martin Baulig <martin@ximian.com>
3631 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
3632 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
3634 * cs-parser.jay (delegate_declaration): Small fix for #75852.
3636 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3638 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
3639 to be a pointer type due to the spec 25.2, so check if declaring
3640 type is generic type definition. Fixed bug #75772.
3642 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3645 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
3646 both types are not defined by methods.
3647 * expression.cs : (Invocation.IsApplicable): it should work when
3648 the argument type is equal to the parameter type, not only when
3649 ImplicitConversionExists() returns true.
3651 2005-09-02 Raja R Harinath <rharinath@novell.com>
3653 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
3657 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
3658 flow-branching for LocalVariableReferences in case we were invoked
3659 from a MemberAccess.
3660 * expression.cs (LocalVariableReference.VerifyAssigned): New.
3662 (LocalVariableReference.DoResolveBase): ... this.
3663 (MemberAccess.Resolve): Do the check that was disabled during
3666 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3669 (PartialContainer.Create): check abstract/sealed/static strictly
3670 but abstract/sealed can exist only at one side. Fixed bug #75883.
3672 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
3675 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
3676 specified, don't default to UnmanagedType.I4.
3678 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3680 * expression.cs : conditional operator should check possibly
3681 incorrect assign expression. Fixed bug #75946.
3683 2005-08-30 Raja R Harinath <rharinath@novell.com>
3686 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
3687 (ScopeInfo.EmitScopeType): Use it to construct field names from
3688 names of captured locals.
3691 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
3692 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
3693 Pass 'target_type' to BoxedCast. Don't default to 'object'.
3694 (ExplicitConversion): Remove enum cases already handled by
3695 implicit conversion. Move implicit conversion check to the beginning.
3696 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
3697 * expression.cs (ArrayCreation.EmitDynamicInitializers):
3698 Don't treat System.Enum as a struct.
3700 2005-08-30 Jb Evain <jbevain@gmail.com>
3702 * attribute.cs: handles as expression in parameters.
3704 2005-08-30 Raja R Harinath <rharinath@novell.com>
3707 * class.cs (TypeContainer.VerifyClsName): Don't use a
3708 PartialContainer when verifying CLS compliance.
3709 (AbstractPropertyEventMethod): Set Parent here, ...
3710 (PropertyMethod): ... not here.
3712 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
3714 * attribute.cs : escaped attribute name should not be allowed to be
3715 resolved (e.g. @class as classAttribute). Fixed bug #75930.
3717 2005-08-29 Raja R Harinath <rharinath@novell.com>
3720 * convert.cs (ImplicitStandardConversionExists): Allow zero also
3721 when converting a long constant to unsigned long.
3722 * expression.cs (Invocation.OverloadResolve): Add sanity check to
3723 detect where IsApplicable and VerifyArgumentsCompat disagree.
3725 2005-08-29 Raja R Harinath <rharinath@novell.com>
3726 and Carlos Alberto Cortez <carlos@unixmexico.org>
3729 * class.cs (TypeContainer.CanElideInitializer): New helper.
3730 (TypeContainer.EmitFieldInitializers): Use it to determine if we
3731 can safely emitting the initializer of a field.
3733 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3735 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
3736 allowed inside a switch (without loop). Fixed bug #75433.
3738 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
3740 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
3741 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
3743 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3745 * driver.cs : kinda reverting the default encoding changes (not exact
3746 revert since I noticed that "codepage:reset" might not work fine).
3748 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3750 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
3751 Location. Now getter and setter store location correctly.
3752 (errors/cs0111-12.cs now reports the expected location.)
3754 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3756 * driver.cs : Use default encoding on the environment.
3757 Removed (now that) extra parameter for SeekableStreamReader.
3758 * support.cs : (SeekableStreamReader) third .ctor() argument for
3759 StreamReader is not required (always true). preamble size could
3760 be acquired in simpler and safe way.
3762 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
3764 * cs-parser.jay: report CS0642 at warning level 3
3765 and report CS0642 for an if else statement also
3766 fixes bug #74745. Patch by John Luke (and a bit
3768 Removed extra CS0642 warning check for "while",
3770 * statement.cs: In Block.Resolve(), CS0642 check
3771 is reimplemented to check a sequence of an empty
3772 statement and a block.
3774 Both fix bug #66777.
3776 2005-08-24 Marek Safar <marek.safar@seznam.cz>
3778 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
3779 detection until I fix it.
3781 * cs-tokenizer.cs: Changed error message.
3783 * cs-parser.jay: Fixed 2 error locations.
3785 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
3786 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
3789 * enum.cs (GetSignatureForError): Fixed.
3791 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
3795 * typemanager.cs (RegisterProperty): Removed.
3797 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
3799 2005-08-24 Raja R Harinath <rharinath@novell.com>
3802 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
3803 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
3805 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3807 * expression.cs : tiny fix is required for not warning positive ulong.
3810 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3812 * expression.cs : add CS0652 check for constant and integral
3813 expression. Fixed bug #53974.
3815 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3817 * expression.cs : in DoNumericPromotions(), check if there is implicit
3818 conversion overload for string (to check CS0034). Fixed bug #52492.
3820 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3822 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
3824 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3826 * ecore.cs : report location when it is *not* Null.
3828 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3834 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
3835 correctly. Fixed bug #75721.
3837 2005-08-23 Raja R Harinath <rharinath@novell.com>
3839 * support.cs (SeekableStreamReader.Position): Avoid an expensive
3840 loop that performs 'min (pos, char_count)'.
3843 * expression.cs (Unary.ResolveOperator): Don't discard implicit
3844 converted value in Operator.OnesComplement.
3846 2005-08-22 Ben Maurer <bmaurer@ximian.com>
3848 * anonymous.cs: If the anon method is pulled into a helper class,
3849 it needs to be `internal' not `private'. Fixes runtime behavior on
3852 2005-08-17 Marek Safar <marek.safar@seznam.cz>
3855 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
3858 2005-08-16 Marek Safar <marek.safar@seznam.cz>
3860 The big constants rewrite
3861 Fix #75746, #75685 and more
3862 As a side effect saved 1MB for MWF ;-)
3864 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
3865 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
3866 enum based for corlib compilation.
3868 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
3871 * class.cs (FixedField.Define): Use ResolveAsConstant.
3873 * const.cs (IConstant): Interface constants and enums.
3874 (Const.ResolveValue): New method for constant resolvning.
3875 (ExternalConstant): Constants from imported assemblies.
3877 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
3878 conversion; like enums.
3879 (Constant.ToType): Converts this constant to different type.
3880 (Constant.Increment): Adds 1.
3882 * convert.cs (ImplicitConversionRequired): Simplified.
3884 * cs-parser.jay: Create EnumMember directly.
3886 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
3888 * doc.cs (GenerateEnumDocComment): Removed.
3890 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
3891 (ConvertIntLiteral): Removed.
3892 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
3894 * enum.cs (EnumMember): Implement IConstant.
3895 (Enum.IsValidEnumConstant): Removed.
3896 (Enum.GetNextDefaultValue): Removed.
3897 (Enum.FindMembers): Updated.
3898 (Enum.GenerateDocComment): Iterate enum members.
3900 * expression.cs (Cast.TryReduce): Handle enums correctly.
3901 (New.Constantify): Made public.
3902 (MemberAccess.DoResolve): Removed contant specific if(s).
3904 * literal.cs (NullLiteral): Implement new abstract methods.
3906 * statement.cs (GotoCase.Resolve): Use new constant methods.
3907 (SwitchLabel.ResolveAndReduce): Use new constant methods.
3909 * typemanager.cs (LookupEnum): Removed.
3910 (IsEnumType): Fixed to work with corlib.
3911 (RegisterConstant): Removed.
3912 (LookupConstant): Removed.
3913 (GetConstant): Changed to work with IConstant.
3915 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
3917 * location.cs : Fixed overflown (>255) column number.
3919 2005-08-03 Raja R Harinath <rharinath@novell.com>
3921 First cut of the qualified-alias-member feature.
3922 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
3924 * cs-parser.jay (DOUBLE_COLON): New token.
3925 (namespace_or_type_name): Add rule for recognizing
3926 qualified-alias-members.
3927 (primary_expression): Likewise.
3928 (element_access): Allow QualifiedAliasMember as a possible
3929 type-bearing expression.
3930 (local_variable_type, local_variable_pointer_type): Likewise.
3931 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
3932 aliases in the current and enclosing namespace declarations.
3933 (NamespaceEntry.UsingAlias): Add CS0440 warning.
3934 * decl.cs (MemberName.is_double_colon): New.
3935 (MemberName.MemberName): Add new constructor for alias-member.
3936 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
3937 * expression.cs (QualifiedAliasMember): New expression type.
3939 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3941 * location.cs : it borked when no argument was specified.
3943 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3945 * location.cs : tiny ToString() format fix.
3947 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3949 * statement.cs : oops, it was missing.
3951 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3953 A set of fixes for precise line/column location.
3956 "token" field now holds a file/line "delta", a line number offset
3957 from the segment, and a column number. See also:
3958 http://lists.ximian.com/pipermail/mono-devel-list/2004-
3959 December/009508.html
3960 Removed static IsNull. Use instance IsNull property instead.
3962 For some tokens it stores Location. For Identifier it stores
3963 LocatedToken which is a pair of string name and location.
3964 Column numbers are adjusted only at getChar().
3966 Use Location.ToString() for reporting (it now contains column).
3968 Largely modified to use LocatedToken instead of
3969 string (IDENTIFIER), and to acquire Location from some tokens.
3970 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
3971 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
3973 Now MemberName holds Location. DeclSpace.ctor() receives Location
3974 as a parameter. Removed extra parameters to all derived classes.
3975 Replaced Location.IsNull() with instance property.
3976 * assign.cs, expression.cs :
3977 Added .ctor() overload that omits Location.
3979 Added "nameEscaped" flag that indicates the identifier was escaped
3980 in the source file. This fixes bug #57047.
3982 2005-09-02 Martin Baulig <martin@ximian.com>
3984 * class.cs: Make CS3005 a warning, not an error.
3986 2005-08-02 Marek Safar <marek.safar@seznam.cz>
3988 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
3989 New method, looking for lo-case imported cls type.
3991 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
3994 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
3996 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
3998 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4000 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4002 Optimized to save 3.5 MB for SWF compilation.
4004 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4006 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4007 (PartialContainer.Create): Moved logic AddToContainer.
4008 (PartialContainer.MarkForDuplicationCheck): Shares name.
4010 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4013 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4015 (Namespace.GetSignatureForError): New method.
4017 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4018 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4020 2005-08-01 Raja R Harinath <rharinath@novell.com>
4023 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4024 member lookup rather than qualifier_type, since qualifier_type can
4027 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4029 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4032 2005-07-31 Miguel de Icaza <miguel@novell.com>
4034 * statement.cs: Copy the local exception into the exception
4035 captured local. Fixes 75674
4037 2005-07-31 Raja R Harinath <harinath@gmail.com>
4040 * expression.cs (Invocation.OverloadResolve): Don't report error
4041 CS1501 if error CS1502 has been reported.
4042 (New.DoResolve): Delegate CS1501 reporting to
4043 Invocation.OverloadResolve.
4046 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4047 invariant-meaning-in-block property in an enclosing block if
4050 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4052 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4053 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4054 (Switch.CheckSwitch): Just save 50kb for SWF.
4056 2005-07-27 Martin Baulig <martin@ximian.com>
4058 * anonymous.cs (CaptureContext.AddField): Added
4059 `AnonymousContainer am' argument; compute its toplevel scope if
4060 it's not already computed. Fixes #75649.
4062 2005-07-26 Raja R Harinath <rharinath@novell.com>
4065 * class.cs (Constructor.Emit): Reset block to null if the block
4068 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4070 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4072 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4074 * class.cs (MethodData.Define): Check whether accessor implementing
4075 interface is public.
4077 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4079 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4082 * namespace.cs (LookupType): Moved same type check to...
4084 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4087 2005-07-21 Raja R Harinath <rharinath@novell.com>
4089 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4090 already found a typebuilder.
4091 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4092 MemberNames, not strings.
4094 * const.cs (Error_ExpressionMustBeConst):
4095 Rename from Error_EpressionMustBeConst.
4096 * const.cs, class.cs, statement.cd: Update.
4098 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4102 * const.cs (Const.LookupConstantValue): Report missing contant expression
4104 (Error_EpressionMustBeConstant): Only one error method.
4106 * class.cs, statement.c: Updated.
4108 2005-07-20 Raja R Harinath <rharinath@novell.com>
4110 * statement.cs (Block.Flags): Add back HasVarargs.
4111 (Block.flags): Make protected.
4112 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4114 * typemanager.cs (types, typecontainers, user_types): Remove.
4115 (UserTypes, TypeContainers): Likewise.
4116 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4117 (CleanUp, Reset): Update.
4118 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4119 (GetNestedType): Use Type.GetNestedType.
4120 (CoreLookupType): Take two arguments, the namespace and the
4121 basename of the type. Update to use the Namespace.Lookup
4123 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4124 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4125 string concatenation and substring matches.
4126 * class.cs, enum.cs, delegate.cs: Update to changes.
4128 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4130 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4131 Expression and made virtual.
4133 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4134 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4136 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4138 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4141 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4144 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4147 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4148 AssemblyCultureAttribute is not used on executable.
4151 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4153 2005-07-16 Raja R Harinath <rharinath@novell.com>
4156 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4157 New. Reports CS0252/CS0253.
4158 Mostly taken from preliminary patch by Duncak Mak.
4159 (Binary.DoResolveOperator): Store results of operator lookup.
4160 Use them to detect if we need to warn about unintended reference
4163 2005-07-15 Raja R Harinath <rharinath@novell.com>
4166 * namespace.cs (Namespace.Lookup): Add back location parameter.
4167 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4168 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4170 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4171 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4172 (Namespace.LookupType): ... this.
4173 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4175 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4176 purported to handle pointers.
4177 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4180 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4182 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4185 2005-07-15 Raja R Harinath <rharinath@novell.com>
4187 * namespace.cs (Namespace.Lookup): Drop location parameter.
4188 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4189 (NamespaceEntry.Lookup): ... this.
4190 (NamespaceEntry.Error_AmbiguousTypeReference):
4191 Move here from DeclSpace.
4192 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4194 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4195 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4196 Move to NamespaceEntry.
4197 * delegate.cs, expression.cs: Update to changes.
4199 2005-08-31 Martin Baulig <martin@ximian.com>
4201 Committing a patch from Atsushi Enomoto for #75850.
4203 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4204 Prefer a generic enumerator over a non-generic one.
4206 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4208 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4209 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4211 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4213 * driver.cs : reverting default encoding change as well as mcs.
4215 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4217 * driver.cs, support.cs : merged r48826.
4219 > could you integrate your mcs changes to gmcs otherwise
4220 > gmcs cannot compile some files.
4222 2005-08-20 Martin Baulig <martin@ximian.com>
4224 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4225 scope if we don't already have it.
4227 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4228 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4231 2005-07-31 Miguel de Icaza <miguel@novell.com>
4233 * statement.cs: Copy the local exception into the exception
4234 captured local. Fixes 75674
4236 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4238 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4241 2005-08-12 Martin Baulig <martin@ximian.com>
4243 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4244 for nested types here to avoid hitting the cache too early.
4246 2005-08-09 Miguel de Icaza <miguel@novell.com>
4248 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4251 2005-08-03 Martin Baulig <martin@ximian.com>
4253 Make iterators in generic methods work; see gtest-191.cs.
4256 (Constraints.Resolve): Protect against being called twice.
4259 (TypeContainer.GetClassBases): Make this `protected virtual'.
4261 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4262 (Iterator.GetClassBases): Override this and compute the base
4264 (Iterator.DefineNestedTypes): If we're a generic method, all our
4265 method type parameters become class type parameters on the proxy
4269 (ToplevelBlock.Parameters): Make this a property, not a field.
4270 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4272 2005-08-03 Martin Baulig <martin@ximian.com>
4274 * typemanager.cs (TypeManager.IsSubclassOf): Use
4275 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4276 (TypeManager.GetFullName_recursed): Improved.
4278 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4281 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4282 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4283 invocation_type == mi.DeclaringType, since the first one also checks
4284 other condition used by generic instances.
4286 2005-07-27 Martin Baulig <martin@ximian.com>
4288 * anonymous.cs (CaptureContext.AddField): Added
4289 `AnonymousContainer am' argument; compute its toplevel scope if
4290 it's not already computed. Fixes #75649.
4292 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4294 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4295 CheckAttributeType and refactored.
4296 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4297 ResolveAsTypeTerminal error handling.
4298 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4300 (GetSignatureForError): Print errors in same way.
4303 * codegen.cs: Reflect attribute GetSignatureForError change.
4306 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4308 * namespace.cs (UsingEntry): Refactored to make fields private.
4311 statement.cs: Error_UnexpectedKind has extra parameter.
4313 2005-07-14 Raja R Harinath <rharinath@novell.com>
4315 * ecore.cs (IAlias): Remove.
4316 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4317 that implement the interface.
4318 * namespace.cs (Namespace): Likewise.
4319 (Namespace.declspaces): Renamed from 'defined_names'.
4320 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4321 DeclSpace instead of an IAlias.
4322 * tree.cs (Tree.AddDecl): Update.
4324 2005-07-12 Raja R Harinath <rharinath@novell.com>
4326 * statement.cs (Block.Flags); Remove HasVarargs.
4327 (Block.HasVarargs): Move to ToplevelBlock.
4328 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4329 (Block.Variables): Make protected. Initialize variable hashtable
4331 (Block.AddVariable): Update.
4332 (Block.Resolve): Update to changes.
4333 (ToplevelBlock.HasVarargs): New boolean.
4334 (ToplevelBlock.ThisVariable): Move here from Block.
4335 (ToplevelBlock.AddThisVariable): Likewise.
4336 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4337 * expression.cs (This.ResolveBase): Update to changes.
4338 (ArglistAccess.DoResolve): Likewise.
4340 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4343 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4345 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4346 not used and not used & assigned.
4347 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4349 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4352 * expression.cs (Is.DoResolve): null is never provided type.
4354 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4357 * cs-parser.jay: Less strict event error rule to catch more errors.
4359 2005-07-11 Martin Baulig <martin@ximian.com>
4361 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4362 for the constructor constraint: we do not only have to check
4363 whether the class has a public constructor, but also ensure that
4364 it's parameterless. Fixes #75492.
4366 2005-07-11 Martin Baulig <martin@ximian.com>
4368 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4369 between type parameters if they either have the reference type
4370 constraint or the class constraint.
4372 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4374 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4376 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4379 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4380 (ExtractSecurityPermissionSet): Cope with self referencing security
4381 attributes properly.
4383 * driver.cs (SetOutputFile): Made public property OutputFile.
4385 2005-07-07 Raja R Harinath <rharinath@novell.com>
4388 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4389 has_nonstatic_fields. Make into a FieldBase pointer.
4390 (TypeContainer.AddField): Add CS0282 check.
4391 (TypeContainer.EmitType): Update.
4393 2005-07-06 Miguel de Icaza <miguel@novell.com>
4395 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4396 compare if they start with __.
4398 2005-07-06 Raja R Harinath <rharinath@novell.com>
4400 * statement.cs (Switch.SwitchGoverningType): Only look at
4401 UserCasts that don't need implicit standard conversions to one of
4402 the allowed switch types (Fixes test-322.cs).
4403 (LocalInfo.Resolve): Re-enable sanity-test.
4405 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4407 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4409 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4411 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4413 2005-07-06 Raja R Harinath <rharinath@novell.com>
4416 * ecore.cs (SimpleName.GetSignatureForError): Add.
4417 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4418 (MemberAccess.GetSignatureForError): Add.
4420 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4422 The big error and warning messages review.
4452 * typemanager.cs: Updated.
4454 * class.cs: (MethodCore.SetYields): Moved here to share.
4455 (PropertyMethod.Define): Moved iterator setup here.
4457 * iterators.cs: Add orig_method to have full access to parent
4460 2005-07-05 Raja R Harinath <rharinath@novell.com>
4462 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4463 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4464 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4465 variable of struct type.
4466 * expression.cs (Unary.ResolveOperator): Update to change.
4467 (Indirection.VerifyFixed): Likewise.
4468 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4469 (ParameterReference.VerifyFixed): Value parameters are fixed.
4470 (This.VerifyFixed): Treat 'this' as a value parameter.
4471 * statement.cs (LocalInfo.IsFixed): Remove.
4473 2005-07-01 Martin Baulig <martin@ximian.com>
4475 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4476 `ec.EmitThis ()' to get the correct scope.
4478 2005-07-01 Martin Baulig <martin@ximian.com>
4480 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4481 instance is a ParameterReference; fixes #75299.
4483 2005-06-30 Raja R Harinath <rharinath@novell.com>
4486 * expression.cs (Indexers.map): Remove.
4487 (Indexers.Append): Filter out inaccessible setters and getters.
4488 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4491 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4493 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4494 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4495 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4496 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4498 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4501 * class.cs (FieldBase.GetInitializerExpression): One more field
4504 2005-06-28 Miguel de Icaza <miguel@novell.com>
4506 * pending.cs: Do not define a proxy if the base method is virtual,
4507 it will be picked up by the runtime (bug 75270).
4509 2005-07-08 Martin Baulig <martin@ximian.com>
4511 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4512 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4514 2005-07-07 Martin Baulig <martin@ximian.com>
4516 * generic.cs (ConstructedType.CheckConstraint): Use
4517 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4518 called recursively; fixes #75329.
4520 2005-07-06 Martin Baulig <martin@ximian.com>
4522 * generic.cs (TypeManager.InferTypeArguments): Added support for
4523 anonymous methods; fixes #75461.
4525 2005-07-01 Martin Baulig <martin@ximian.com>
4527 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4528 `ec.EmitThis ()' to get the correct scope.
4530 2005-07-01 Martin Baulig <martin@ximian.com>
4532 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4533 instance is `This'; fixes #75299.
4535 2005-06-30 Martin Baulig <martin@ximian.com>
4537 * class.cs (Indexer): Implement IIteratorContainer; added support
4538 for iterators in indexers.
4541 (EmitContext.CurrentIterator): Make this a property, not a field.
4543 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4545 2005-06-28 Miguel de Icaza <miguel@novell.com>
4547 * pending.cs: Do not define a proxy if the base method is virtual,
4548 it will be picked up by the runtime (bug 75270).
4550 2005-06-28 Martin Baulig <martin@ximian.com>
4552 * cs-parser.jay (interface_method_declaration): Avoid a
4553 reduce/reduce conflict by moving some of the code into a separate
4554 `interface_method_declaration_body' rule; fixes #75368.
4556 2005-06-28 Martin Baulig <martin@ximian.com>
4558 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4559 array check after the check for TypeBuilder's.
4561 2005-06-21 Raja R Harinath <rharinath@novell.com>
4563 * convert.cs (FindMostEncompassedType): Add two trivial special
4564 cases (number_of_types == 0 || number_of_types == 1).
4565 (FindMostEncompasingType): Likewise.
4567 2005-06-17 Raja R Harinath <rharinath@novell.com>
4569 Some cleanups preparing for the fix of #75283.
4570 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4572 (EventExpr.InstanceResolve): Likewise.
4573 (EventExpr.DoResolve): Remove redundant checks.
4575 2005-06-08 Miguel de Icaza <miguel@novell.com>
4577 * class.cs: Small fix.
4579 2005-06-08 Raja R Harinath <rharinath@novell.com>
4582 * class.cs (GetPartialBases): Fix return value check of
4585 2005-06-07 Raja R Harinath <rharinath@novell.com>
4587 Ensure that partial classes are registered in their enclosing
4588 namespace. Initial part of fix of #75160.
4589 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4590 Register declspace with namespace here, not in
4591 DeclSpace.RecordDecl.
4592 * cs-parser.jay: Pass namespace to RecordDecl.
4593 * class.cs (PartialContainer.Create): Likewise.
4594 (ClassPart.DefineType): New sanity-check. Throws an exception if
4596 * decl.cs (Declspace.RecordDecl): Remove.
4597 * namespace.cs (NamespaceEntry.DefineName): Remove.
4599 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4601 * rootcontext.cs: Reset TargetExt as well.
4603 2005-06-03 Raja R Harinath <rharinath@novell.com>
4605 * ecore.cs (Expression.Resolve): Emit CS0654 error when
4608 2005-06-02 Raja R Harinath <rharinath@novell.com>
4610 Fix #75080, cs0119.cs.
4611 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
4613 (Expression.Resolve): ... this. Use it. Remove bogus code
4614 allowing ExprClass.Type and ExprClass.Namespace for
4615 ResolveFlags.VariableOrValue.
4616 (Expression.Resolve) [1-argument variant]: Change default resolve
4617 flags based on language version.
4618 (Expression.Error_UnexpectedKind): Use a simple string array
4619 rather than an ArrayList.
4620 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
4622 (TypeOfVoid.DoResolve): Likewise.
4623 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
4624 flags argument -- it always has the same value.
4626 2005-05-31 Raja R Harinath <rharinath@novell.com>
4629 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
4630 Use it in the error message.
4631 * assign.cs, expression.cs, statement.cs: Update.
4633 2005-05-30 Raja R Harinath <rharinath@novell.com>
4636 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
4637 the "almostMatchedMember" case too.
4638 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
4639 that failed the accessibility checks to 'almost_match'.
4641 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
4643 * attribute.cs: Use internal MethodBuilder methods to set
4644 ExactSpelling and SetLastError on PInvoke methods, instead
4645 of passing them via charset. Fixes #75060.
4647 2005-05-27 Raja R Harinath <rharinath@novell.com>
4649 * parameter.cs (Parameter): Remove TODO comment.
4650 (Parameter.DefineParameter): Remove Location parameter.
4651 (Parameters.LabelParameters): Likewise.
4652 * class.cs (Constructor.Emit): Update to change.
4653 (MethodData.Emit): Likewise.
4654 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
4655 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
4657 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
4660 Removed Parameters.Location and added Parameter.Location instead.
4661 Removed Location parameter from Emit() and GetSignature().
4668 Modified all related calls.
4670 2005-06-21 Martin Baulig <martin@ximian.com>
4672 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
4673 left-hand side is not a nullable type; fixes #75328.
4675 2005-06-21 Martin Baulig <martin@ximian.com>
4678 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
4679 (TypeManager.GetFullNameSignature): Likewise.
4681 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
4682 `source.FullName' and `target.FullName' to check whether there are
4683 two conflicting definitions.
4685 2005-06-21 Martin Baulig <martin@ximian.com>
4687 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
4688 a BoxedCast - also for reference types - to be compatible with csc.
4690 2005-06-21 Martin Baulig <martin@ximian.com>
4692 * expression.cs (MemberAccess.DoResolve): Add support for nested
4693 types in a generic instance; fixes #75320.
4695 2005-06-20 Martin Baulig <martin@ximian.com>
4697 * generic.cs (TypeManager.InferType): Also walk the class
4698 hierarchy for generic instances; fixes #75261.
4700 2005-06-17 Martin Baulig <martin@ximian.com>
4702 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
4703 to make things work for corlib.
4705 2005-06-15 Martin Baulig <martin@ximian.com>
4707 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
4708 obsolete `SecurityAction' values.
4710 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4712 * rootcontext.cs: Reset TargetExt as well.
4714 2005-06-09 Martin Baulig <martin@ximian.com>
4716 * delegate.cs (Delegate.VerifyMethod): Added
4717 `MethodGroupExpr old_mg' argument; inherit its
4718 `HasTypeParameters'; fix #75085.
4720 2005-06-09 Martin Baulig <martin@ximian.com>
4722 * expression.cs (Invocation.OverloadResolve): Correctly handle
4723 generic methods for the SetMemberIsUsed(); fix #75064.
4725 2005-06-09 Martin Baulig <martin@ximian.com>
4727 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
4730 2005-06-08 Martin Baulig <martin@ximian.com>
4732 * cs-parser.jay (nullable_type_or_conditional): If we put the
4733 nullable back and our `type' is a `ComposedCast', remove the
4734 nullable from it. Fixes #75156.
4736 * expression.cs (ComposedCast.RemoveNullable): New public method.
4738 2005-06-08 Martin Baulig <martin@ximian.com>
4740 The big Iterators rewrite :-)
4742 * iterators.cs: Rewrite this to use the anonymous methods framework.
4744 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
4745 before the TypeContainers; see 2test-21.cs.
4748 (TypeContainer.DefineType): Don't create a new EmitContext if we
4749 already have one (this only happens if we're an Iterator).
4750 (TypeContainer.Define): Also call Define() on all our iterators.
4751 (Method.CreateEmitContext): Added support for iterators.
4754 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
4755 (AnonymousContainer.CreateMethodHost): Moved here from
4756 AnonymousMethod and made abstract.
4757 (AnonymousContainer.CreateScopeType): New abstract method.
4758 (AnonymousContainer.IsIterator): New public property.
4759 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
4760 get the ScopeTypeBuilder rather than manually defining it here.
4761 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
4764 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
4765 before RootContext.DefineTypes().
4767 * codegen.cs (EmitContext.RemapToProxy): Removed.
4768 (EmitContext.CurrentAnonymousMethod): Changed type from
4769 AnonymousMethod -> AnonymousContainer.
4770 (EmitContext.ResolveTopBlock): Protect from being called twice.
4771 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
4772 (EmitContext.EmitThis): Removed the iterators hacks; use the
4773 anonymous methods framework for that.
4776 (ToplevelBlock.Container): Make this a property, not a field.
4777 (ToplevelBlock.ReParent): New public method; move the
4778 ToplevelBlock into a new container.
4779 (Foreach.TemporaryVariable): Simplify.
4781 2005-06-05 Martin Baulig <martin@ximian.com>
4783 * statement.cs (LocalInfo.CompilerGenerated): New flag.
4784 (Block.AddTemporaryVariable): New public method; creates a new
4785 `LocalInfo' for a temporary variable.
4786 (Block.EmitMeta): Create the LocalBuilders for all the temporary
4788 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
4789 non-iterator variables.
4791 2005-06-05 Martin Baulig <martin@ximian.com>
4793 * statement.cs (Foreach.TemporaryVariable): Create the
4794 LocalBuilder in the Emit phase and not in Resolve since in some
4795 situations, we don't have an ILGenerator during Resolve; see
4796 2test-19.cs for an example.
4798 2005-06-04 Martin Baulig <martin@ximian.com>
4800 The big Foreach rewrite - Part II.
4802 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
4803 with `PropertyInfo ienumerator_getcurrent'.
4805 * codegen.cs (VariableStorage): Removed.
4808 (Foreach): Derive from Statement, not ExceptionStatement.
4809 (Foreach.CollectionForeach): New nested class. Moved all the code
4810 dealing with collection foreach here.
4811 (Foreach.ForeachHelperMethods): Removed.
4812 (Foreach.TemporaryVariable): Implement IMemoryLocation.
4814 2005-05-23 Martin Baulig <martin@ximian.com>
4816 * statement.cs (Try.DoResolve): Don't create a `finally' if we
4817 don't need to. Fix #75014.
4819 2005-05-26 Raja R Harinath <rharinath@novell.com>
4821 Improve user-defined conversion handling.
4822 * convert.cs (GetConversionOperators): Rewrite. Return only the
4823 applicable operators.
4824 (AddConversionOperators): New. Helper for GetConversionOperators.
4825 (FindMostEncompassedType, FindMostEncompassingType): Verify that
4826 there is only one most encompassed/encompassing type.
4827 (FindMostSpecificSource, FindMostSpecificTarget): Remove
4828 "applicable operator" handling.
4829 (UserConversion): Move cache here from GetConversionOperators.
4830 Directly cache the chosen operator, rather than the whole
4832 (ExplicitNumericConversion): Fix buggy implementation of Decimal
4833 case. Allow conversion of decimal to sbyte and byte too.
4834 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
4835 New static methods. Used to avoid allocating EmptyExpressions in
4838 2005-05-24 Duncan Mak <duncan@novell.com>
4840 * ecore.cs (CastFromDecimal): New class for casting a decimal to
4841 another class, used in Convert.ExplicitNumericConversion.
4842 (CastToDecimal): New class, similar to above, but casts to
4843 System.Decimal, used in Convert.ImplicitNumericConversion and also
4844 in explicit convesion from double/float to decimal.
4846 * convert.cs (ImplicitNumericConversion): Handle implicit
4847 conversions to System.Decimal.
4848 (ExplicitNumericConversion): handle explicit conversions to
4853 2005-05-20 Miguel de Icaza <miguel@novell.com>
4855 * typemanager.cs: Do not throw an exception in the TypeBuilder
4856 case, we take care of it on the TypeCode.
4858 2005-05-17 Marek Safar <marek.safar@seznam.cz>
4860 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
4863 * cs-parser.jay: Catch more lexical errors.
4865 * report.cs: Add one more Error method.
4868 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
4870 2005-05-20 Martin Baulig <martin@ximian.com>
4872 * class.cs (TypeContainer.CircularDepException): Removed.
4873 (TypeContainer.DefineType): Removed the `InTransit' stuff.
4874 (TypeContainer.CheckRecursiveDefinition): Check for circular class
4875 (CS0146) and interface (CS0529) dependencies here.
4877 2005-05-20 Martin Baulig <martin@ximian.com>
4879 * expression.cs (New.DoResolve): Move the CS0712 check above the
4880 CS0144 check; otherwise it can never be reached.
4882 2005-05-20 Martin Baulig <martin@ximian.com>
4884 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
4886 2005-05-20 Martin Baulig <martin@ximian.com>
4888 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
4890 * typemanager.cs (TypeManager.IsAttributeType): New public method.
4892 2005-05-19 Martin Baulig <martin@ximian.com>
4895 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
4896 to disable error reporting.
4898 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
4899 here since we don't want to report an error; see the new test-336.cs.
4901 2005-05-19 Raja R Harinath <rharinath@novell.com>
4903 * statement.cs (ToplevelBlock.GetParameterReference)
4904 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
4905 Move here from class Block.
4906 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
4907 * expression.cs (ParameterReference.DoResolveBase): Likewise.
4909 2005-05-18 Martin Baulig <martin@ximian.com>
4914 (FlowBranching.Reachability): Add non-static public And() and Or()
4916 (FlowBranchingSwitch): New class; do the `break_origins' thing
4917 like in FlowBranchingLoop.
4918 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
4919 reachability, not just locals and parameters.
4920 (FlowBranching.MergeChild): Remove some of the hacks for loop and
4921 switch; MergeBreakOrigins() now takes care of that.
4923 2005-05-18 Martin Baulig <martin@ximian.com>
4925 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4926 a loop and may leave it, reset the barrier; fixes #74974.
4928 2005-05-16 Raja R Harinath <rharinath@novell.com>
4930 Fix test-382.cs. Emit values of decimal constants.
4931 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
4933 (TypeContainer.AddField): ... this.
4934 (TypeContainer.EmitFieldInitializers): Allow the list of fields
4935 with initializers to include 'Const's.
4936 (ClassPart.RegisterFieldForInitialization): Forward to
4938 * const.cs (Const.Const): Pass initializer to base class.
4939 (Const.Define): In case of decimal constants, register them for
4940 initialization in a static constructor.
4942 2005-05-14 Martin Baulig <martin@ximian.com>
4944 * statement.cs (Block.Resolve): Correctly handle unreachable code;
4945 do not call ResolveUnreachable() on unreachable statements in
4946 here, see the comment in the source code.
4948 2005-05-13 Raja R Harinath <rharinath@novell.com>
4951 * expression.cs (BinaryResolveOperator): If one of the operands of
4952 an equality comparison is 'null' and the other is a pointer type,
4953 convert the null to a NullPointer.
4954 * convert.cs (ImplicitReferenceConversion): If the expression is a
4955 NullLiteral and the target type is a pointer type, return a
4956 NullPointer instead.
4957 (ImplicitConversionStandard): Likewise.
4959 2005-05-13 Marek Safar <marek.safar@seznam.cz>
4961 * cs-parser.jay: Set readonly context based on special constructs.
4963 * expression.cs (LocalVariableReference.DoResolveBase): Improved
4964 readonly variable error handling.
4966 * rootcontext.cs (EmitCode): Don't verify members when error
4969 * statement.cs (LocalInfo): Add reaodnly context information.
4970 (SetReadOnlyContext, GetReadOnlyContext): New methods.
4972 2005-05-17 Martin Baulig <martin@ximian.com>
4974 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
4977 2005-05-13 Martin Baulig <martin@ximian.com>
4979 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
4980 handle unreachable blocks.
4982 2005-05-13 Martin Baulig <martin@ximian.com>
4985 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
4986 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
4989 2005-05-13 Martin Baulig <martin@ximian.com>
4991 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
4992 instance variable, not a local. Fix #74873.
4993 (Block.ResolveUnreachable): Set it to true here.
4995 2005-05-12 Martin Baulig <martin@ximian.com>
4997 * cs-parser.jay (property_declaration): Pass the `current_class',
4998 not the `current_container' to Property's .ctor. Fixes #74912.
5000 2005-05-11 Martin Baulig <martin@ximian.com>
5002 * typemanager.cs (Closure): Copy this from MCS and merge all the
5003 GMCS-specific changes into it.
5005 2005-05-12 Raja R Harinath <harinath@gmail.com>
5008 * typemanager.cs (unmanaged_enclosing_types): New.
5009 (IsUnmanagedType): Avoid infloops by using
5010 'unmanaged_enclosing_types' to talk with recursive invocations.
5012 2005-05-11 Duncan Mak <duncan@novell.com>
5014 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5015 continuing to process for 'arg'.
5016 (handle_preprocessing_directive): Check the argument of the #endif
5017 directive and report error CS1025 if there are any trailing
5020 According to the C# spec, having even whitespace after the #endif
5021 directive is illegal; however, because we call arg.TrimEnd ()
5022 beforehand, we have the same behavior as csc, allowing whitespace
5023 after the directive.
5027 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5031 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5032 (Constructor.GetObsoleteAttribute): Implemented correctly.
5034 2005-05-10 Martin Baulig <martin@ximian.com>
5036 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5037 resolve the type; fixes #74864.
5038 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5039 in DoResolve(); fixes #74862.
5041 2005-05-10 Martin Baulig <martin@ximian.com>
5043 * support.cs (ReflectionParameters.ParameterModifier): Use
5044 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5045 and `ParameterAttributes.In'. Fixes #74884.
5047 2005-05-10 Martin Baulig <martin@ximian.com>
5049 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5050 the cache if we're just looking for `MemberTypes.NestedType' in a
5053 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5054 constraints if we're still resolving the type tree.
5055 (Expression.MemberLookup): If we're resolving the type tree, only
5056 look for `MemberTypes.NestedType' since we're only interested in
5059 * class.cs (TypeContainer.DefineType): Don't resolve the type
5060 parameters here; do this later in ResolveType() after the type
5061 tree has been resolved.
5062 (TypeContainer.ResolveType): New public method; this is called
5063 after the type tree is resolved and before the types are being
5064 populated. We resolve the generic constraints here.
5065 (TypeContainer.DoDefineMember): Check the constraints on our base
5066 class and interfaces.
5068 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5069 set the `ResolvingTypeTree' flag on the EmitContext.
5071 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5073 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5075 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5077 * expression.cs (Argument.GetParameterModifier): Turned to property.
5078 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5080 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5083 2005-05-09 Raja R Harinath <rharinath@novell.com>
5086 * decl.cs (MemberCache.AddMethods): Register override methods,
5087 rather than non-override methods.
5088 * typemanager.cs (RegisterOverride): New.
5089 (IsOverride): Update.
5091 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5093 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5095 2005-05-06 Martin Baulig <martin@ximian.com>
5098 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5099 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5101 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5105 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5106 recursive declaration.
5108 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5110 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5112 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5114 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5116 2005-05-05 Raja R Harinath <rharinath@novell.com>
5119 * decl.cs (DeclSpace.FamilyAccessible):
5120 Use TypeManager.IsNestedFamilyAccessible.
5122 Fix reopened #64812.
5123 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5126 2005-05-04 Raja R Harinath <rharinath@novell.com>
5127 Abin Thomas <projectmonokochi@rediffmail.com>
5128 Anoob V E <projectmonokochi@rediffmail.com>
5129 Harilal P R <projectmonokochi@rediffmail.com>
5132 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5133 allow access to all static members.
5135 2005-05-04 Martin Baulig <martin@ximian.com>
5137 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5139 2005-05-04 Martin Baulig <martin@ximian.com>
5143 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5144 section at the end; make things work if `default' is not the last
5147 2005-05-04 Martin Baulig <martin@ximian.com>
5151 * statement.cs (Switch): Replaced the `got_default' field with a
5152 `default_section' one.
5153 (Switch.CheckSwitch): Set `default_section' here.
5154 (Switch.Resolve): If we're a constant switch and the constant is
5155 not found, use the default section.
5157 2005-05-03 Martin Baulig <martin@ximian.com>
5159 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5161 * statement.cs (Foreach.ArrayForeach): New nested class.
5162 (Foreach.TemporaryVariable): New nested class.
5163 (Foreach.EmitArrayForeach): Removed; this is now in the new
5166 2005-05-03 Raja R Harinath <rharinath@novell.com>
5168 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5170 (VerifyPendingMethods): Revert change below.
5172 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5173 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5174 that used to trigger warning -28. Remove warning -28.
5175 * expression.cs (Invocation.OverloadResolve): Use
5176 TypeManager.IsOverride to distinguish override methods.
5179 * pending.cs (VerifyPendingMethods): If a base type implements the
5180 requested interface, don't bother checking individual methods of
5181 the base type. As a side-effect, this prevents the creation of
5182 unnecessary proxies.
5184 2005-05-02 Martin Baulig <martin@ximian.com>
5188 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5189 Also `And' the locals if the old vector is null.
5190 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5191 null; in this case we basically reset all the variables.
5193 2005-05-02 Martin Baulig <martin@ximian.com>
5197 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5198 Added `FlowBranching branching' argument; always `and' the
5199 variables instead of `or'ing them unless we're an infinite loop.
5201 * statement.cs (While.Resolve): Create a new sibling unless we're
5204 2005-05-02 Martin Baulig <martin@ximian.com>
5208 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5209 arguments; use it instead of creating a new TopLevelBlock.
5210 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5211 our ConstructorInitializer.
5214 (TopLevelBlock.TopLevelBranching): New public property.
5215 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5216 and create our `TopLevelBranching'.
5218 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5219 anonymous method host, use `block.TopLevelBranching' rather than
5220 creating a new branching.
5222 2005-04-20 Miguel de Icaza <miguel@novell.com>
5224 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5225 a ScopeInfo, if any of the current children is a child of the new
5226 entry, move those children there.
5228 2005-04-30 Martin Baulig <martin@ximian.com>
5230 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5231 at the beginning of a SwitchSection. Fix #73335.
5233 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5236 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5238 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5239 (FieldExpr.DoResolve): Obsolete members are ignored for field
5242 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5244 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5245 of arrays detection.
5247 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5249 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5251 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5254 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5256 * cs-parser.jay: Use the prefered version of -unsafe in error
5259 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5261 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5264 2005-04-20 John Luke <john.luke@gmail.com>
5266 * driver.cs: fix typo in error message, --outout to --output
5268 2005-04-30 Martin Baulig <martin@ximian.com>
5270 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5271 handle the .NET 2.x security attributes.
5273 2005-04-30 Martin Baulig <martin@ximian.com>
5276 (TypeManager.ExpandInterfaces): Don't add things twice.
5279 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5281 2005-04-29 Martin Baulig <martin@ximian.com>
5283 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5285 * anonymous.cs: Added support for anonymous generic methods.
5287 2005-04-29 Martin Baulig <martin@ximian.com>
5289 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5292 2005-04-29 Martin Baulig <martin@ximian.com>
5294 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5296 * expression.cs (New.DoResolve): Fix the CS0304 check.
5298 2005-04-29 Martin Baulig <martin@ximian.com>
5300 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5303 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5304 explicit interface implementation, compare the interface types.
5305 (MethodData.Define): Use the new naming scheme from the latest
5307 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5309 * decl.cs (MemberName.GetMemberName): Removed.
5310 (MemberName.MethodName, FullName): New properties.
5312 2005-04-25 Raja R Harinath <rharinath@novell.com>
5314 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5316 2005-04-22 Martin Baulig <martin@ximian.com>
5318 * generic.cs (GenericMethod): Create the EmitContext in the
5319 `Define()'; in `Define(MethodBuilder)', create the type parameters
5320 before calling `Define()'. Fixes #73933.
5322 2005-04-22 Martin Baulig <martin@ximian.com>
5325 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5326 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5328 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5329 ConstructedType, check its constraints.
5331 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5333 * codegen.cs (InRefOutArgumentResolving): New field.
5335 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5336 fields outside contructor.
5338 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5340 2005-04-19 Miguel de Icaza <miguel@novell.com>
5342 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5343 parameter code was not completed ever, so it was not as up-to-date
5344 as local variables. Must finish it.
5346 The bug fix was to compare the Toplevel of the block, not the
5347 current block. Thanks for Ben for pointing this out.
5349 2005-04-19 Raja R Harinath <rharinath@novell.com>
5351 * decl.cs (AddMethods): Use the declaring type of the problem
5352 method to determine if we want to squash a warning.
5354 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5356 * attribute.cs: Removed debug output.
5358 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5360 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5363 2005-04-18 Raja R Harinath <rharinath@novell.com>
5366 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5367 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5368 all null comparisons against reference types.
5370 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5373 * class.cs (TypeContainer.CircularDepException) New nested
5375 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5376 (TypeContainer.DefineType): Removed error, reset InTransit before
5378 (Class.DefineType): Throw exception when is in Transit.
5379 Catch exception and report error.
5380 (Struct.DefineType): Throw exception when is in Transit.
5381 Catch exception and report error.
5382 (Interface.DefineType): Throw exception when is in Transit.
5383 Catch exception and report error.
5385 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5386 handle nested exception handlers.
5388 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5391 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5392 InFinally and InCatch storage.
5394 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5395 (Catch.Resolve): Set and Restore ec.InCatch.
5396 (Try.Resolve): Set and Restore ec.InFinally.
5397 (Try.HasCatch): True when try has catch.
5399 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5401 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5402 for the same event member, so exclude such cases from warning 419.
5405 2005-04-16 Miguel de Icaza <miguel@novell.com>
5407 * expression.cs (Binary.ResolveOperator): Apply patch from John
5408 Luke to fix bug 59864: operators &, | and ^ on enumerations
5409 require that the same enum type on both sides.
5411 * driver.cs: Add warnings to old flag usage, this is to assist
5412 people who produce Makefiles and hope that the Makefiles will be
5415 * class.cs (TypeContainer.EmitType): Moved the definition of the
5416 special $PRIVATE$ field from the resolve phase to the Emit phase.
5417 During resolve we do not know if we are a struct with
5418 HasExplicitLayout, we know this only after the attributes for the
5421 Set the FieldOffset to zero on the dummy field that we create for
5422 the class. Fixes 74590.
5424 2005-04-16 Raja R Harinath <rharinath@novell.com>
5427 * ecore.cs (PropertyExpr.resolved): New.
5428 (DoResolve): Use it to handle a case of double resolution here.
5429 Handle a case of identical-name-and-type-name.
5430 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5431 resolution by storing the results of expression resolution back
5432 into the "probes" array.
5434 2005-04-15 Raja R Harinath <rharinath@novell.com>
5436 Fix cs0208-7.cs and cs0208-8.cs.
5437 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5438 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5439 error reporting to point out the reason a struct is not unmanaged.
5441 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5443 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5444 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5446 2005-04-13 Raja R Harinath <rharinath@novell.com>
5449 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5450 IdenticalNameAndTypeName here.
5451 (EventExpr.InstanceResolve): Likewise.
5453 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5455 C# 2.0 DefaultCharSetAttribute implementation
5457 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5458 which allows us to set GlobalNamespace for every resolve.
5459 (Attribute.ResolveArguments): Cut from Resolve.
5460 (Attribute.GetCharSetValue): Returns CharSet named argument.
5461 (Attribute.DefinePInvokeMethod): Gets default charset from
5463 (GlobalAttribute.ResolveAsTypeStep): Override.
5464 (GlobalAttribute.ResolveArguments): Override.
5466 * class.cs (TypeAttr): Is protected.
5468 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5469 (ModuleClass.DefaultCharSetType): New memeber.
5470 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5472 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5473 charset from module.
5475 * delegate.cs (TypeAttr): Override.
5476 (Delegate.DefineType): Use this TypeAttr.
5478 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5479 at very early stage (before types are defined) to resolve model
5480 module attributes. It will probably not work with corlib but it
5483 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5484 charset from module.
5486 * typemanager.cs (default_charset_type): New type.
5488 2005-04-13 Raja R Harinath <rharinath@novell.com>
5490 * decl.cs (MemberCache.AddMethods): Don't warn if
5491 System.Object.Finalize has buggy MethodAttributes.
5493 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5496 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5498 * doc.cs : detect ambiguous reference to overloaded members.
5499 Fixed bug #71603. MS 1.1 csc does not detect it.
5501 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5503 * doc.cs : delegates must not be referenced with parameters.
5506 2005-04-12 Miguel de Icaza <miguel@novell.com>
5508 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5510 2005-04-10 Miguel de Icaza <miguel@novell.com>
5512 * driver.cs (MainDriver): Stop processing if the CLS stage found
5515 (CompilerCallableEntryPoint.InvokeCompiler): Always
5516 reset after execution; Take a TextWriter argument for the
5519 * report.cs: Use the error stream instead of hardcoding stderr.
5521 2005-04-09 Miguel de Icaza <miguel@novell.com>
5523 * class.cs: Reduce code paths to test, too small of an
5524 optimization to make it worth the extra testing. Always perform
5527 2005-04-08 Raja R Harinath <rharinath@novell.com>
5530 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5531 operators that had errors reported on them.
5533 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5535 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5537 (Attribute.Resolve): Add named argument type checking.
5539 * class.cs (FixedField.Define): Use IsPrimitiveType
5541 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5543 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5544 unsafe parameter types.
5546 * statement.cs (Using.ResolveExpression): Add better error description.
5548 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5550 2005-04-08 Raja R Harinath <rharinath@novell.com>
5553 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5554 AttributeUsageAttribute in the emitcontext of the attribute class,
5555 not in the emitcontext of the attributable entity it was attached to.
5556 * cs-parser.jay: Use 'current_class', not 'current_container',
5557 when creating a GlobalAttribute.
5559 2005-04-08 Alp Toker <alp@atoker.com>
5561 * pending.cs: The fix to #58413 failed to compile methods implementing
5562 interfaces with/without params modifiers and vice versa, even though
5563 params modifiers aren't part of the signature. Make the modifier check
5564 less strict as in csc.
5566 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5567 Anoob V E <projectmonokochi@rediffmail.com>
5568 Harilal P R <projectmonokochi@rediffmail.com>
5571 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5572 modifiers of pending methods.
5573 (PendingImplementation.PendingImplementation): Initialize it.
5574 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5575 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5576 with ParameterData. Add check for modifiers.
5577 * class.cs (MethodData.Define): Update to changes.
5579 2005-04-07 Raja R Harinath <rharinath@novell.com>
5581 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5583 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5585 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5588 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5591 * typemanager.cs: Registered RequiredAttributeAttribute.
5593 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5595 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5596 Warning CS0169 is back at level 3.
5597 (IMethodData.SetMemberIsUsed): New method.
5599 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5600 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
5602 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
5604 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
5606 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
5609 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
5612 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
5613 to avoid the problems with nested types.
5615 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
5616 Anoob V.E <projectmonokochi@rediffmail.com>
5617 Harilal P.R <projectmonokochi@rediffmail.com>
5618 Raja R Harinath <rharinath@novell.com>
5621 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
5623 * typemanager (GetConstructor): Make public.
5625 2005-04-05 John Luke <john.luke@gmail.com>
5626 Raja R Harinath <rharinath@novell.com>
5629 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
5630 struct too. Return false quicker in a few cases.
5631 (VerifyUnManaged): Use it.
5633 2005-04-05 Raja R Harinath <rharinath@novell.com>
5636 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
5637 not 'unreachable_seen'.
5639 2005-04-04 Marek Safar <marek.safar@seznam.cz>
5641 * attribute.cs (Attribute.GetValue): Removed unused.
5643 * codegen.cs (CodeGen.TrimExt): Removed unused.
5645 * cs-parser.jay (output): Removed unused.
5647 * cs-tokenizer.cs (hex_digits): Removed unused.
5649 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
5651 * expression.cs (Indirection.LoadExprValue): Removed unused.
5652 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
5654 * iterators.cs (Iterator.param_types): Removed unused.
5656 * statement.cs (Goto.block): Removed unused.
5657 (ToplevelBlock.did): Removed unused.
5658 (Switch.ResolveConstantSwitch): Removed unused.
5660 2005-04-01 Ben Maurer <bmaurer@ximian.com>
5662 * rootcontext.cs: Allow mcs to bootstrap with the compilation
5665 2005-04-19 Martin Baulig <martin@ximian.com>
5667 Merged r42462 from MCS and made it work for GMCS.
5669 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
5671 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
5673 2005-04-01 Raja R Harinath <rharinath@novell.com>
5675 Fix #74232 and cs0208-3.cs.
5676 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
5677 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
5678 unmanaged type. Don't use FieldBuilders when 't' is a
5679 TypeBuilder. Use ModFlags and MemberType fields.
5680 * class.cs (MemberBase.member_type): Rename from MemberType.
5681 (MemberBase.MemberType): New property. Determines member_type on
5683 (MemberBase.DoDefine): Don't initialize MemberType here.
5684 (FieldMember.Define): Likewise.
5686 2005-04-01 Marek Safar <marek.safar@seznam.cz>
5689 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
5690 Attributes are emitted there.
5692 2005-04-01 Raja R Harinath <rharinath@novell.com>
5694 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
5695 keyword in 'partial enum' too.
5696 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
5698 Report from Kamil Skalski <nazgul@omega.pl>.
5701 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
5702 have partial containers too.
5704 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
5705 in block' checks to Block.CheckInvariantMeaningInBlock.
5706 * statement.cs (Block.GetKnownVariableInfo): Make private.
5707 (Block.IsVariableUsedInChildBlock): Remove.
5708 (Block.IsVariableUsedInBlock): Likewise.
5709 (Block.CheckInvariantMeaningInBlock): New. Show location of
5710 conflicting declaration.
5711 (Block.AddVariable): Make error messages less long-winded and more
5712 specific. Show location of conflicting declaration.
5713 * parameter.cs (Parameters.Location): New readonly property.
5715 2005-03-31 Raja R Harinath <rharinath@novell.com>
5717 Clean up semantics of invoking ResolveMemberAccess.
5718 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
5719 can have an instance, ensure that we pass in a non-TypeExpression
5720 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
5721 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
5722 argument. Update to changes and simplify.
5723 (FieldExpr.Emitinstance): Remove CS0120 check.
5724 (PropertyExpr.EmitInstance): Likewise.
5725 * expression.cs (Argument.Resolve): Likewise.
5726 (Invocation.DoResolve): Update to changes in semantics of
5729 2005-03-31 Marek Safar <marek.safar@seznam.cz>
5732 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
5735 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
5737 2005-03-31 Raja R Harinath <rharinath@novell.com>
5739 Fix difference in behaviour with commandline invocation.
5740 * driver.cs (Driver.Reset): New.
5741 (CompilerCallableEntryPoint): Call it.
5743 * statement.cs (If.Resolve): Avoid spurious "uninitialized
5744 variable" warnings if the boolean expression failed to resolve.
5746 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
5748 * attribute.cs: Fix the union of several permissions when some of them
5749 are unrestricted (so the result isn't an unrestricted permission set).
5752 2005-03-30 Raja R Harinath <rharinath@novell.com>
5754 * ecore.cs (MemberExpr): New class. Convert from interface
5756 (MemberExpr.ResolveMemberAccess): Refactor and move here from
5757 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
5759 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
5760 (MethodGroupExpr.IsExplicitImpl): Remove.
5761 (Expression.GetFieldFromEvent): Remove.
5762 (SimpleName.MemberStaticCheck): Remove.
5763 (SimpleName.DoSimpleNameResolve): Update to changes.
5764 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
5765 (MemberAccess.IdenticalNameAndTypeName): Remove.
5766 (MemberAccess.error176): Move to MemberExpr.
5767 (MemberAccess.DoResolve): Update to changes.
5768 (BaseAccess.DoResolve): Likewise.
5770 2005-03-30 Marek Safar <marek.safar@seznam.cz>
5772 C# 2.0 Conditional attribute class implementation
5774 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
5775 Analyzes class whether it has attribute which has ConditionalAttribute
5776 and its condition is not defined.
5778 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
5779 (Class.IsExcluded): New method. Search for at least one defined
5780 condition in ConditionalAttribute of attribute class.
5782 2005-03-30 Raja R Harinath <rharinath@novell.com>
5784 * ecore.cs (PropertyExpr): Derive from Expression, not
5785 ExpressionStatement.
5786 (PropertyExpr.EmitStatement): Remove.
5788 2005-03-29 Raja R Harinath <rharinath@novell.com>
5791 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
5792 internal field "value__" of an enum be private. The examples for
5793 "value__" that I found on MSDN all used FieldAttributes.Private.
5795 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
5796 Don't mention IL method attribute names.
5798 Fix #47991. Remove a TODO.
5799 * statement.cs (Block.Toplevel): Make into a field.
5800 (Block.Parameters): Move into ToplevelBlock.
5801 (Block.known_variables): Rename from child_variable_names.
5802 (Block.Block): Remove variants that take Parameters. Initialize
5803 'Toplevel' with the immediately surrounding toplevel block.
5804 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
5805 LocalInfo parameter.
5806 (Block.GetKnownVariableInfo): New.
5807 (Block.IsVariableNameUsedInChildBlock): Update.
5808 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
5809 the block, even though it may not be in scope.
5810 (Block.AddVariable): Remove Parameters parameter. Use
5811 Toplevel.Parameters instead.
5812 (Block.AddConstant): Remove Parameters parameter.
5813 (Block.GetParameterReference): Update to use Toplevel.Parameters.
5814 (Block.IsParamaterReference): Likewise.
5815 (Block.IsLocalParameter): Likewise. Simplify a lot.
5816 (ToplevelBlock.Parameters): New. Moved from Block.
5817 (ToplevelBlock.ToplevelBlock): Update to changes. Always
5818 initialize Parameters to a non-null value.
5819 * cs-parser.jay: Update to changes.
5820 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
5821 simple names that mean different things in the same block. Use
5822 Block.IsVariableNameUsedInBlock.
5824 2005-03-28 Raja R Harinath <rharinath@novell.com>
5826 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
5828 2005-03-26 Raja R Harinath <harinath@acm.org>
5831 * assign.cs (Assign.DoResolve): When the RHS of an assignment
5832 fails to resolve, ensure that the LHS is still resolved as an
5835 2005-03-25 Raja R Harinath <harinath@acm.org>
5837 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
5839 (Enum.current_ec): Remove.
5840 (Enum.LookupEnumValue): Remove EmitContext argument.
5841 Just uses the one created during DefineType.
5842 (Enum.FindMembers): Update.
5843 * expression.cs (MemberAccess.DoResolve): Update.
5845 2005-03-22 Marek Safar <marek.safar@seznam.cz>
5847 * assign.cs (Assign.DoResolve): Check for CS1717 when
5848 source and target are same (uses Equals).
5850 * expression.cs (LocalVariableReference, ParameterReference,
5851 This): Implemented Equals, GetHashCode.
5853 * statement.cs (Block.GetParameterReference): Removed useless
5856 2005-03-22 Raja R Harinath <rharinath@novell.com>
5859 * statement.cs (Block.AddVariable): Ensure that we skip implicit
5860 blocks before deciding whether the error is cs0136 or cs0128.
5862 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
5863 (using_alias_directive, using_namespace_directive): Pass
5864 MemberName, not an expression to Namespace.UsingAlias and
5866 (MakeName): Use the MemberName of the namespace.
5867 * namespace.cs (Namespace.MemberName): New.
5868 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
5869 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
5871 * decl.cs (MemberName.Name): Make readonly.
5872 (MemberName.FromDotted): New "constructor".
5873 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
5874 (MemberCore.Name): Compute from MemberName on demand.
5875 (MemberCore.SetMemberName): Provide a way to change the
5877 (MemberCore.AddToContainer): Don't take a fullname parameter.
5878 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
5879 fully qualified name of the container to the member name.
5880 (TypeContainer.AddToTypeContainer): Use a fully qualified name
5881 only if the type is a member of the root container.
5882 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
5883 MemberName.Left rather than searching for an embedded ".".
5884 (PartialContainer.CreatePart): Update to changes in RootContext.
5885 (MemberBase.ShortName): Turn into a property. Use
5886 MemberCore.SetMemberName.
5887 (MemberBase.ExplicitInterfaceName): Remove.
5888 (MemberBase.UpdateMemberName): Remove.
5889 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
5890 (PropertyBase.SetMemberName): New override.
5891 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
5892 (Tree.GetDecl): New.
5893 (Tree.AllDecls): Rename from Decls.
5894 * attribute.cs, enum.cs, report.cs: Update to changes.
5895 * driver.cs (MainDriver): Use MemberName.FromDotted on
5896 RootContext.MainClass.
5898 2005-03-21 Marek Safar <marek.safar@seznam.cz>
5900 * class.cs (FixedField.Define): Check for CS1664 and more sanity
5903 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
5905 2005-03-18 Marek Safar <marek.safar@seznam.cz>
5907 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
5908 property accessor modifiers.
5910 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
5911 fixed buffer attribute (CS1716).
5912 (PropertyMethod.HasCustomAccessModifier): When property accessor
5913 has custom modifier.
5915 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
5917 (PropertyExpr.DoResolveLValue): Add CS0272.
5919 2005-03-17 Miguel de Icaza <miguel@novell.com>
5921 * convert.cs: When converting to a pointer, use the proper Conv.U
5922 or Conv.I depending on the source data type.
5924 * cs-tokenizer.cs: Make the size for large decimal constants,
5927 2005-03-17 Martin Baulig <martin@ximian.com>
5929 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
5930 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
5932 2005-03-17 Martin Baulig <martin@ximian.com>
5934 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
5935 to bool so we can return an error condition.
5936 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
5939 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
5941 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
5944 2005-03-16 Raja R Harinath <rharinath@novell.com>
5946 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
5947 Refactor to avoid traversing the list of assemblies, and to avoid
5948 string concatenation.
5949 * typemanager.cs (guid_attr_type): Remove.
5950 (negative_hits, pointers, references): Remove hashes.
5952 (GetConstructedType): New. Uses type_hash to handle constructed
5953 types (arrays, references, pointers).
5954 (GetReferenceType, GetPointerType): Use it.
5955 (GetNestedType): New. Uses type_hash to handle nested types of
5957 (LookupType, LookupTypeDirect): Remove.
5958 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
5959 'types' hash and LookupTypeReflection directly.
5960 (params_string, params_object): Use GetConstructedType.
5961 * namespace.cs (Namespace.cached_types): New. Cache of reflected
5963 (Namespace.Lookup): Use cached_types.
5964 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
5965 provided by old TypeManager.LookupType.
5966 * rootcontext.cs (MakeFQN): Remove.
5967 * decl.cs (DeclSpace.MakeFQN): Likewise.
5968 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
5969 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
5970 TypeManager.GetConstructedType.
5971 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
5973 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
5975 * cs-parser.jay: Fix build.
5977 2005-03-15 Marek Safar <marek.safar@seznam.cz>
5979 * class.cs (TypeContainer.CircularDepException) New nested
5980 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
5982 * cs-parser.jay: Reports CS1527 for any namespace element.
5984 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
5987 * expression.cs (ParameterReference.IsAssigned): Changed error to
5989 (Error_WrongNumArguments): Moved CS0245 detection here.
5991 * statement.cs (Return.Resolve): Add CS1622 report.
5993 2005-03-11 Marek Safar <marek.safar@seznam.cz>
5995 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
5997 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
5999 * attribute.cs expression.cs: Get rid of some allocations.
6001 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6003 * doc.cs : just eliminate the latest change.
6005 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6007 * doc.cs : commented out the latest change. It breaks xml-030.cs
6009 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6011 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6012 fail. So invoke CreateType() in FindDocumentedType().
6014 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6016 * cs-tokenizer.cs : added IsKeyword().
6017 * doc.cs : Detect keyword incorrectly used as identifier.
6018 Allow identifiers prefixed by @.
6020 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6022 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6023 It caused exception in namespace resolving (again!).
6025 * class.cs (Class.ctor): Removed exit.
6026 (PropertyMethod.ctor): ditto.
6028 * codegen.cs (Codegen.Reset): Reset static data.
6029 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6031 * cs-tokenizer.cs (Cleanup): Removed.
6033 * driver.cs (GetSystemDir): Rewrote to one line command.
6034 It caused problem with unloaded dynamic modules.
6035 (UnixParseOption): Removed Exit.
6036 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6037 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6038 Now can be mcs used as library.
6040 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6043 * location.cs (Reset): Reset static data.
6045 * namespace.cs (Reset): Reset static data.
6047 * report.cs (Report.Reset): Reset static data.
6049 * rootcontext.cs (RootContext.Reset): Reset static data.
6051 * tree.cs (RootTypes.ctor): Use Location.Null
6053 * typemanager.cs (TypeManager.Reset): Reset static data.
6054 (CoreLookupType): Removed Exit.
6055 (TypeHandle.Reset): Reset static data.
6057 2005-03-10 Raja R Harinath <rharinath@novell.com>
6060 * typemanager.cs (ComputeNamespaces): Import namespaces from
6061 referenced modules too.
6063 2005-03-09 Raja R Harinath <rharinath@novell.com>
6065 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6068 2005-03-09 Raja R Harinath <rharinath@novell.com>
6070 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6071 enclosing DeclSpace. This ensures that a name-lookup populates
6072 more caches and there are fewer 'TypeExpression's. Carve out
6073 nested type lookup into ...
6074 (LookupNestedTypeInHierarchy): ... this.
6076 2005-04-15 Martin Baulig <martin@ximian.com>
6078 Merged r41590 from MCS and make it work in the generics land.
6080 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6083 * class.cs (PartialContainer.UpdateConstraints): Removed.
6084 (PartialContainer.CheckConstraints): Removed.
6085 (PartialContainer.SetParameterInfo): Store the constraints here.
6086 (PartialContainer.DefineTypeParameters): New public method;
6087 resolve the type parameter's constraints here. Note that the
6088 PartialContainer doesn't have an EmitContext anymore, so we must
6089 do this in the ClassPart.
6091 2005-03-09 Raja R Harinath <rharinath@novell.com>
6093 Clean up a few partial-class semantics.
6094 Fixes test-357.cs and cs1618-2.cs.
6095 * cs-parser.jay (struct_declaration): Use 'current_class' as
6096 parent of newly-created struct. Remove call to Register ().
6097 Use 'pop_current_class' to complete handing the current struct.
6098 (interface_declaration): Likewise.
6099 (class_declaration): Likewise.
6100 (enum_declaration): Use 'current_class' as parent of newly created
6102 (delegate_declaration): Likewise.
6103 (pop_current_class): New function. This is used to handle closing
6104 up the 'current_class' and 'current_container', and pointing them
6105 to the enclosing class/container.
6106 (CSharpParser): Initialize 'current_class' too.
6107 * decl.cs (MemberCore): Add check for invariant: a partial
6108 container is not a parsed entity, and thus does not enclose any
6110 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6111 (DeclSpace.BaseTypeExpr): Use it.
6112 (DeclSpace.LookupType): Add check for invariant.
6113 * class.cs (TypeContainer): Add check for invariant: a nested
6114 class should have the same NamespaceEntry as its enclosing class.
6115 (TypeContainer.EmitFieldInitializers): Make virtual.
6116 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6118 (TypeContainer.Register): Remove.
6119 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6120 null. Use TypeResolveEmitContext for resolving base types and
6121 interfaces. Move initialization of Parts.TypeBuilder here from
6123 (TypeContainer.DefineNestedTypes): ... here.
6124 (PartialContainer): Take a Namespace not a NamespaceEntry.
6125 (PartialContainer.Create): Don't use Register. Call the
6126 appropriate Add... function directly.
6127 (ClassPart): Take both the PartialContainer and the enclosing
6128 class as constructor arguments.
6129 (ClassPart.EmitFieldInitializers): Override.
6130 (ClassPart.PartFindNestedTypes): Remove.
6131 (FieldBase.GetInitializerExpression): Resolve the initializer
6132 expression in the emit context of the enclosing class.
6133 * tree.cs (RootTypes): Remove Register ().
6135 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6137 * cs-parser.jay: Removed CS0134.
6139 * driver.cs: Removed CS1901.
6141 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6142 for predefined types.
6144 2005-03-07 Duncan Mak <duncan@novell.com>
6146 * codegen.cs (Save): Catch UnauthorizedAccessException as
6147 well. Fixes bug #73454.
6149 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6151 * cs-tokenizer.cs (xtoken): Add CS1035.
6153 * class.cs (MethodData.Define): Add CS0683.
6154 (FieldMember.ctor): Add CS0681.
6156 2005-03-07 Raja R Harinath <rharinath@novell.com>
6158 * ecore.cs (SimpleName.DoResolve): Rename from
6159 SimpleName.DoResolveAllowStatic.
6160 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6161 Pass 'intermediate' flag to MemberStaticCheck.
6162 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6163 of "intermediate" lookups via MemberAccess.
6164 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6165 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6167 2005-03-07 Raja R Harinath <rharinath@novell.com>
6170 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6171 slipped in because of variable names that are identical to a
6172 builtin type's BCL equivalent ('string String;', 'int Int32;').
6173 (PropertyExpr.EmitInstance): Likewise.
6175 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6177 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6179 * report.cs (warning_ignore_table): Made public.
6181 2005-03-04 Raja R Harinath <rharinath@novell.com>
6184 * class.cs (MethodData.Emit): Pass 'container' to
6185 container.GetObsoleteAttribute instead of 'container.Parent'.
6187 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6189 * cs-parser.jay: Add 1534 error test.
6191 * iterators.cs (Yield.CheckContext): Add error 1629.
6192 (Iterator.ctor): Save unsafe modifier.
6193 (MoveNextMethod.DoEmit): Restore unsafe context.
6195 * namespace.cs (UsingAlias): Better error message.
6197 2005-03-03 Dan Winship <danw@novell.com>
6199 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6200 the warning message [#73219]
6202 2005-03-03 Raja R Harinath <rharinath@novell.com>
6204 Fix compile with MCS 1.0.0.0.
6205 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6206 w_restore to not depend on string constant folding.
6208 2005-03-03 Raja R Harinath <rharinath@novell.com>
6210 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6211 CS0246 check to users who passed 'silent = false'.
6212 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6214 (SimpleName.SimpleNameResolve): Update.
6215 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6216 (MemberAccess.IdenticalNameAndTypeName): Update.
6217 * doc.cs (FindDocumentedTypeNonArray): Update.
6219 2005-03-03 Raja R Harinath <rharinath@novell.com>
6221 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6222 * parameters.cs (ComputeAndDefineParameters): Remove.
6223 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6224 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6225 Use GetParameterInfo.
6227 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6229 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6231 2005-03-02 Raja R Harinath <rharinath@novell.com>
6233 Unify DeclSpace.LookupType and DeclSpace.FindType.
6234 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6235 is in charge of defining nested types on demand.
6236 (DeclSpace.LookupType): Use it when the current_type is a
6237 TypeBuilder. Use LookupTypeDirect for reflected types.
6238 (DeclSpace.FindType): Remove.
6239 (DeclSpace.LookupInterfaceOrClass): Likewise.
6240 (DeclSpace.DefineTypeAndParents): Likewise.
6241 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6242 DeclSpace.LookupType.
6243 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6244 * typemanager.cs (LookupType): Simplify.
6245 (AddUserType): Remove type from negative_hits.
6246 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6247 * class.cs (TypeContainer.FindMembers): Move handling of nested
6249 (TypeContainer.FindMembers_NestedTypes): ... here.
6250 (TypeContainer.FindNestedType): Implement override.
6251 (ClassPart.FindNestedType): Delegate to PartialContainer.
6252 (ClassPart.PartFindNestedType): Looks up the nested types of the
6255 2005-04-14 Martin Baulig <martin@ximian.com>
6257 * generic.cs (ConstructedType): Moved all the type lookup and
6258 nested class logic into SimpleName.
6259 (ConstructedType.ResolveConstructedType): Our underlying type is
6260 already fully resolved; all the type lookup stuff is in
6263 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6264 constructed types here instead of in ConstructedType.
6266 * decl.cs (MemberName.GetTypeExpression): Always create a
6267 SimpleName, not a ConstructedType.
6268 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6270 2005-03-02 Martin Baulig <martin@ximian.com>
6272 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6273 static constructor in static classes.
6275 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6277 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6278 sizeParamIndex is not specified.
6280 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6283 * report.cs (WarningMessage.IsEnabled): Missing null check.
6285 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6287 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6288 in the fields and not in the properties.
6290 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6292 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6295 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6297 * attribute.cs: Small refactoring (improved robustness).
6298 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6299 (ValidateGuid): Removed.
6300 (Resolve): Removed referenced to above mentioned.
6301 (GetAttributeUsage): Made private and changed to work without
6303 (GetIndexerAttributeValue): Don't crash.
6304 (GetConditionalAttributeValue): Ditto.
6305 (GetClsCompliantAttributeValue): Ditto.
6306 (ExtractSecurityPermissionSet): All attributes exceptions are
6308 (GetPropertyValue): New helper.
6309 (GetMethodImplOptions): New method.
6310 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6311 some missing properties.
6313 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6314 (Method.ApplyAttributeBuilder): Updated.
6316 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6319 2005-02-28 Raja R Harinath <rharinath@novell.com>
6322 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6323 non-simple types (array, pointer, reference).
6325 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6327 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6329 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6331 (Method.CheckBase): Catch wrong destructor here.
6332 (MethodData.Define): Add errors 550, 668.
6334 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6336 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6338 * pending.cs (VerifyPendingMethods): Add error 551.
6340 * typemanager.cs (CSharpName): Next error report helper.
6342 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6344 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6345 attributes. Removed useless attribute double check.
6346 It saves almost 2MBs for corlib.
6348 2005-02-25 Raja R Harinath <rharinath@novell.com>
6351 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6352 called twice in case of error.
6354 2005-02-23 Chris Toshok <toshok@ximian.com>
6356 Fix compiler portions of #72827.
6357 * statement.cs (Block.Emit): call Begin/EndScope on the
6358 EmitContext instead of the ILGenerator.
6360 * codegen.cs (EmitContext.BeginScope): new method, call
6361 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6363 (EmitContext.BeginScope): same, but EndScope and CloseScope
6365 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6366 offset and call the superclass's OpenScope(int) with it.
6367 (SymbolWriter.CloseScope): get the current il
6368 offset and call superclass's CloseScope(int) with it.
6370 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6372 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6373 CS1677 for out and ref as well.
6375 * class.cs (Method.Define): Add error CS1599 detection.
6377 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6379 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6381 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6383 * support.cs.cs (ModifierDesc): New helper method.
6385 2005-02-23 Raja R Harinath <rharinath@novell.com>
6386 Abin Thomas <projectmonokochi@rediffmail.com>
6387 Anoob V E <projectmonokochi@rediffmail.com>
6388 Harilal P R <projectmonokochi@rediffmail.com>
6391 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6392 MemberLookup (used for error reporting) actually returns a result.
6393 Fix error report number (122, not 112).
6395 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6396 Anoob V E <projectmonokochi@rediffmail.com>
6397 Harilal P R <projectmonokochi@rediffmail.com>
6400 * pending.cs (PendingImplementation.GetAbstractMethods):
6401 Find NonPublic members too.
6403 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6405 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6408 * class.cs (MethodCore.CheckMethodAgainstBase):
6409 Add error 239 report.
6411 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6413 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6415 * class.cs (Operator.Define): Add error 217 report.
6417 2005-02-21 Raja R Harinath <rharinath@novell.com>
6420 * expression.cs (Invocation.IsApplicable): Make public.
6421 (Invocation.IsParamsMethodApplicable): Likewise.
6422 * delegate.cs (Delegate.VerifyApplicability): Don't use
6423 Invocation.VerifyArgumentCompat for parameter applicability
6424 testing. Use Invocation.IsApplicable and
6425 Invocation.IsParamsMethodApplicable.
6427 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6429 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6431 * class.cs (Operator.Define): Add error 217 report.
6433 2005-02-21 Raja R Harinath <rharinath@novell.com>
6435 * namespace.cs (UsingEntry.Resolve): Undo change below.
6437 2005-02-21 Raja R Harinath <rharinath@novell.com>
6440 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6441 disable the error message when the extended MemberLookup also
6443 (Expression.MemberLookupFinal): Update.
6444 (SimpleName.DoSimpleNameResolve): Update.
6445 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6446 Don't use MemberLookupFinal.
6447 (New.DoResolve): Update.
6448 (BaseAccess.CommonResolve): Update.
6450 2005-02-21 Raja R Harinath <rharinath@novell.com>
6453 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6454 occured previously, don't resolve again.
6456 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6459 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6460 argument. Call ResolveAttributeUsage for unresolved.
6461 when types doesn't match ctor arguments.
6463 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6464 for nested attribute classes.
6465 (Class.attribute_usage): Removed.
6466 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6467 for attribute class.
6469 * ecore.cs (IsAttribute): Removed.
6471 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6473 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6475 (attribute_types): Removed.
6476 (EmitCode): Global attributes are emited as the latest.
6478 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6480 * class.cs (EmitFieldInitializers): Don't emit field initializer
6481 for default values when optimilization is on.
6483 * constant.cs (Constant.IsDefaultValue): New property.
6485 * driver.cs: Add /optimize handling.
6489 * literal.cs: Implement new IsDefaultValue property.
6491 * rootcontext.cs (Optimize): New field, holds /optimize option.
6493 2005-02-18 Raja R Harinath <rharinath@novell.com>
6495 Fix crasher in re-opened #72347.
6496 * namespace.cs (Namespace.Lookup): Return null if
6497 DeclSpace.DefineType returns null.
6500 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6502 2005-02-18 Raja R Harinath <rharinath@novell.com>
6504 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6505 now returns null if it cannot resolve to an lvalue.
6506 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6507 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6508 returned null. Remove check for SimpleName.
6509 (EventExpr.DoResolveLValue): New.
6510 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6511 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6513 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6515 (Unary.ResolveOperator): Move CS0211 check ...
6516 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6518 (Unary.DoResolveLValue): Simplify.
6519 (AddressOf.DoResolveLValue): New.
6520 (ArrayAccess.DoResolveLValue): New.
6522 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6524 * attribute.cs (Attribute.Resolve): Add arguments casting for
6525 when types doesn't match ctor arguments.
6527 2005-02-16 Raja R Harinath <rharinath@novell.com>
6529 Fix parts of #63202.
6530 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6531 lookup of operator in base type. Ensure that all checks happen
6532 when the operator resolves to an "op_..." method.
6534 2005-02-15 Raja R Harinath <rharinath@novell.com>
6537 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6538 'ignore_cs0104' parameter. Pass it to ...
6539 (NamespaceEntry.Lookup): ... this.
6540 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6541 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6542 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6543 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6544 Update. Request that cs0104 errors be ignored.
6545 (ComposedCast.ResolveAsTypeStep): Update.
6547 2005-02-14 Raja R Harinath <rharinath@novell.com>
6550 * expression.cs (Invocation.BetterFunction): Remove support for
6551 comparing virtual functions and their overrides.
6552 (Invocation.IsOverride): New.
6553 (Invocation.OverloadResolve): Don't consider 'override' functions
6554 during candidate selection. Store them in a lookaside list.
6555 If the selected method is a 'virtual' function, use the list to
6556 find any overrides that are closer to the LHS type.
6558 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6560 * expression.cs (New.DoResolve): Add complex core type reduction.
6561 (New.Constantify): Converts complex core type syntax like 'new int ()'
6564 2005-02-14 Raja R Harinath <rharinath@novell.com>
6566 * decl.cs (EntryType.EntryType): New constructor to create an
6567 updated copy of a cache entry.
6568 (MemberCache.AddMethods): Use it.
6569 (MemberCache.ClearDeclaredOnly): Remove.
6570 (MemberCache.MemberCache): Update.
6572 2005-02-11 Miguel de Icaza <miguel@novell.com>
6574 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6575 variable. This one is represents the actual low-level declaration
6576 of the method, as opposed to the semantic level `IsStatic'.
6578 An anonymous method which is hosted into a static method might be
6579 actually an instance method. IsStatic would reflect the
6580 container, while MethodIsStatic represents the actual code
6583 * expression.cs (ParameterReference): Use the new MethodIsStatic
6584 instead of IsStatic.
6586 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6587 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6588 set on the current EmitContext.
6590 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6591 resolve our casted expression as an LValue. This triggers the
6592 proper LValue processing that is later required by Assign.
6596 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6598 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6600 C# 2.0 Fixed buffer implementation
6602 * anonymous.cs: Update after RegisterHelperClass renaming.
6604 * attribute.cs (AttributeTester.fixed_buffer_cache):
6605 Cache of external fixed buffers.
6606 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
6607 implementation if field is fixed buffer else null.
6610 (TypeContainer.AddField): Accept FieldMember instead of Field.
6611 (FieldBase.IsFieldClsCompliant): Extracted code from
6612 VerifyClsCompliance descendant customization.
6613 (FixedField): New class handles fixed buffer fields.
6614 (FixedFieldExternal): Keeps information about imported fixed
6616 (IFixedField): Make access to internal or external fixed buffer
6619 * cs-parser.jay: Add fixed buffer parsing.
6621 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
6624 * expression.cs (Indirection): Extended implementation to accept
6626 (PointerArithmetic.Emit): Get element from fixed buffer as well.
6627 (ElementAccess.MakePointerAccess): Get type as parameter.
6628 (DoResolve): Add fixed buffer field expression conversion.
6629 (DoResolveLValue): Ditto.
6630 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
6631 (ArrayPtr): Derives from FixedBufferPtr.
6632 (ArrayPtr.Emit): Add extra emit for array elements.
6634 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
6636 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
6637 for compiler generated types.
6638 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
6640 * statement.cs (Fixed): Refactored to be easier add fixed buffer
6641 and consume less memory.
6642 (Fixed.Resolve): Add fixed buffer case.
6644 * typemanager.cs (compiler_generated_attr_ctor,
6645 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
6646 (HasElementType): Add our own implementation to work on every
6649 2005-02-11 Miguel de Icaza <miguel@novell.com>
6651 * anonymous.cs (CaptureContext): Track whether `this' has been
6654 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
6655 only captured `this' if it was implicitly done (instance
6656 methods/variables were used).
6658 * codegen.cs (EmitContext.CaptureThis): New method to flag that
6659 `this' must be captured.
6661 2005-01-30 Miguel de Icaza <miguel@novell.com>
6663 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
6664 is null it means that there has been no need to capture anything,
6665 so we just create a sibling.
6667 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
6669 Just a partial fix. The other half is fairly elusive.
6671 2005-02-10 Raja R Harinath <rharinath@novell.com>
6673 Fix #52586, cs0121-4.cs.
6674 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
6675 and return a hashtable.
6676 (MemberCache.ClearDeclaredOnly): New.
6677 (MemberCache.MemberCache): Update to change. Make a deep copy of
6678 the method_hash of a base type too.
6679 (MemberCache.AddMethods): Adapt to having a deep copy of the base
6680 type methods. Overwrite entries with the same MethodHandle so
6681 that the ReflectedType is correct. The process leaves in base
6682 virtual functions and their overrides as distinct entries.
6683 (CacheEntry): Now a class instead of a struct. It shouldn't alter
6684 matters since it was boxed in a ArrayList before.
6685 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
6687 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
6688 case of a virtual function and its override (choose the overload
6690 (Invocation.OverloadResolve): Avoid 'override' members during
6691 'applicable_type' calculation.
6693 2005-03-28 Raja R Harinath <rharinath@novell.com>
6695 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
6696 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
6697 GetTypeHandle. It is possible for a reflected type to derive from
6698 a TypeBuilder (e.g., int[] derives from the TypeBuilder
6699 System.Array during mscorlib compilation).
6700 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
6701 contain a method_hash, don't create one either. Don't create a
6702 deep copy of the base cache's method_hash.
6703 (MemberCache.SetupCache): Rename back from DeepCopy.
6704 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
6705 already initialized. If we see an override function, add its
6706 underlying base virtual function to the member_hash too.
6708 2005-02-09 Raja R Harinath <rharinath@novell.com>
6710 Combine two near-redundant caches.
6711 * typemanager.cs (method_params): Rename from method_internal_params.
6712 (TypeManager.GetParameterData): New. Replace
6713 Invocation.GetParameterData.
6714 (TypeManager.LookupParametersByBuilder): Remove.
6715 * expression.cs (Invocation.method_parameter_cache): Remove.
6716 (Invocation.GetParameterData): Remove.
6718 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
6721 2005-02-08 Raja R Harinath <rharinath@novell.com>
6724 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
6725 TypeManager.multicast_delegate_type is null, resolve it by looking
6726 up "System.MulticastDelegate".
6727 * rootcontext.cs (RootContext.ResolveCore): Simplify.
6729 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
6730 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
6731 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
6734 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
6735 (LabeledStatement.AddReference): New. Set 'referenced'.
6736 (Goto.Resolve): Use it.
6738 2005-02-05 John Luke <john.luke@gmail.com>
6740 * driver.cs: remove duplicate -doc line in Usage ()
6742 2005-02-04 Raja R Harinath <rharinath@novell.com>
6744 * location.cs (Location.AddFile): Fix CS2002 error report.
6746 2005-02-02 Martin Baulig <martin@ximian.com>
6748 * delegate.cs (Delegate.DefineType): Report an internal error if
6749 TypeManager.multicast_delegate_type is null. See bug #72015 for
6752 2005-02-02 Raja R Harinath <rharinath@novell.com>
6754 Fix a crasher in a variant of #31984.
6755 * const.cs (Constant.CheckBase): New override that defers the
6756 new-or-override check in case the base type hasn't been populated
6758 (Constant.Define): Ensure the new-or-override check is performed.
6760 2005-02-01 Duncan Mak <duncan@ximian.com>
6762 * const.cs (LookupConstantValue): Check that `ce' is not null
6763 before calling GetValue ().
6765 2005-02-01 Raja R Harinath <rharinath@novell.com>
6767 Fix test-334.cs (#69519).
6768 * cs-parser.jay (using_alias_directive): Pass in an expression to
6769 NamespaceEntry.UsingAlias.
6770 (using_namespace_directive): Pass in an expression to
6771 NamespaceEntry.Using.
6772 (namespace_name): Don't flatten to a string.
6773 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
6774 (NamespaceEntry.AliasEntry.Resolve): Lookup using
6776 (NamespaceEntry.UsingEntry): Likewise.
6777 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
6779 (NamespaceEntry.LookupForUsing): Remove.
6780 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
6782 (NamespaceEntry.Lookup): Remove support for dotted names.
6784 2005-02-01 Raja R Harinath <rharinath@novell.com>
6786 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
6788 (NamespaceEntry.ImplicitParent): Compute on demand.
6789 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
6790 parallels the current.
6791 (NamespaceEntry.LookupForUsing): Use it.
6792 (NamespaceEntry.Lookup): If the current namespace-entry is
6793 implicit, don't search aliases and using tables.
6795 2005-02-01 Raja R Harinath <rharinath@novell.com>
6798 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
6800 (TypeContainer.BaseCache): Compute on demand.
6801 (TypeContainer.FindMembers): Define constants and types if they're
6802 not already created.
6803 (FieldMember.Define): Move resetting of ec.InUnsafe before error
6805 * const.cs (Constant.Define): Make idempotent.
6807 2005-01-29 Miguel de Icaza <miguel@novell.com>
6809 * pending.cs: Produce better code (no nops produced by using Ldarg
6812 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
6813 i - 1' it should be arg + 1.
6817 2005-01-28 Raja R Harinath <rharinath@novell.com>
6819 * attribute.cs (Attribute.CheckAttributeType): Make private
6821 (Attribute.ResolveType): Make virtual.
6822 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
6823 handling of RootContext.Tree.Types.
6825 2005-01-27 Raja R Harinath <rharinath@novell.com>
6827 Update attribute-handling to use the SimpleName/MemberAccess
6829 * cs-parser.jay (attribute): Pass in an expression to the
6830 constructors of Attribute and GlobalAttribute.
6831 * attribute.cs (Attribute): Take an expression for the name.
6832 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
6833 passed in attribute name expression.
6834 (Attribute.CheckAttributeType): Use it.
6835 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
6836 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
6837 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
6838 argument to prevent error messages if the lookup fails.
6840 2005-01-27 Marek Safar <marek.safar@seznam.cz>
6842 * expression.cs (Indirection): Implemented IVariable interface
6843 to support indirection in AddressOf operator.
6844 (PointerArithmetic.Emit): Add optimalization for case where
6845 result can be precomputed.
6847 2005-01-26 Martin Baulig <martin@ximian.com>
6849 * class.cs (TypeContainer.AttributeTargets): Return the correct
6850 AttributeTargets depending on our `Kind' instead of throwing an
6851 exception; fixes #71632.
6853 2005-01-26 Marek Safar <marek.safar@seznam.cz>
6856 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
6859 2005-03-17 Martin Baulig <martin@ximian.com>
6861 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6862 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6864 2005-03-17 Martin Baulig <martin@ximian.com>
6866 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6867 to bool so we can return an error condition.
6868 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6871 2005-03-17 Martin Baulig <martin@ximian.com>
6873 * generic.cs (TypeMananager.IsIEnumerable): New public method.
6875 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
6876 converting from an array-type of T to `IEnumerable<T>'.
6878 2005-03-16 Martin Baulig <martin@ximian.com>
6880 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
6881 (Nullable.LiftedUnaryMutator): New public class.
6883 * expression.cs (UnaryMutator.DoResolve): Added support for
6886 2005-03-14 Martin Baulig <martin@ximian.com>
6888 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
6890 2005-03-14 Martin Baulig <martin@ximian.com>
6892 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
6893 the comparision operators `<', `>', `<=' and `>='.
6895 2005-03-13 Martin Baulig <martin@ximian.com>
6898 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
6899 avoid confusion with the `NullLiteral'.
6900 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
6902 2005-03-13 Martin Baulig <martin@ximian.com>
6904 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
6905 comparing arbitrary types with the null literal.
6907 2005-03-13 Martin Baulig <martin@ximian.com>
6909 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
6910 boolean operators '&&', '||', '&' and '|'.
6911 (Nullable.OperatorTrueOrFalse): New public class.
6913 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
6914 instead of a `StaticCallExpr'; added support for nullables.
6916 2005-03-10 Martin Baulig <martin@ximian.com>
6919 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
6920 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
6922 2005-03-07 Martin Baulig <martin@ximian.com>
6924 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
6925 it work if `expr' is not an IMemoryLocation.
6926 (Nullable.Lifted): Implement IMemoryLocation.
6927 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
6930 2005-03-05 Martin Baulig <martin@ximian.com>
6932 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
6933 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
6934 (Nullable): Added support for lifted unary and binary operators.
6936 * expression.cs (Unary.DoResolve): Added support for nullable types.
6937 (Binary.DoResolve): Likewise.
6938 (Conditional.DoResolve): Likewise.
6940 2005-03-02 Martin Baulig <martin@ximian.com>
6942 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
6944 * class.cs (ClassPart.SetParameterInfo): Override this.
6945 (PartialContainer.SetParameterInfo): Override this.
6946 (TypeContainer.CheckConstraints): New protected method.
6947 (PartialContainer.CheckConstraints): Override this and check
6948 whether the same contraints were specified in all parts of a
6949 partial generic type definition.
6950 (PartialContainer.UpdateConstraints): New public method.
6952 * generic.cs (TypeParameter.UpdateConstraints): New public method.
6954 2005-03-02 Martin Baulig <martin@ximian.com>
6956 Committing a patch from Carlos Alberto Cortez to fix #72887.
6958 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
6959 casts from `T []' to `int []'.
6961 2005-03-02 Martin Baulig <martin@ximian.com>
6963 * generic.cs (TypeManager.IsEqual): Make this symmetric.
6965 * expression.cs (Binary.ResolveOperator): When resolving a
6966 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
6967 `=='. Fixes #71866. See gen-127.cs.
6969 2005-03-02 Martin Baulig <martin@ximian.com>
6971 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6972 static constructor in static classes.
6974 2005-03-02 Martin Baulig <martin@ximian.com>
6977 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
6978 (Nullable.LiftedConversion): Added support for user-defined
6981 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
6983 * cs-parser.jay: Use ComposedCast everywhere instead of
6984 NullableType, so we don't need to check for NullableType
6986 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
6987 case where we'll be resolved into a `parenthesized_expression_0'
6991 (Convert.UserDefinedConversion): Added nullable conversions.
6993 2005-02-28 Martin Baulig <martin@ximian.com>
6995 * generic.cs (TypeManager.IsNullableType): New static method.
6996 (Nullable): New abstract class.
6997 (Nullable.NullLiteral): New public class.
6998 (Nullable.LiftedConversion): New public class.
7000 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7001 `builtin_types opt_nullable'.
7004 (Convert.ImplicitConversionStandard): Added nullable conversions.
7005 (Convert.ExplicitConversionStandard): Likewise.
7006 (Convert.ExplicitConversion): Likewise.
7008 2005-02-26 Martin Baulig <martin@ximian.com>
7010 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7011 begin with a "?", for instance "?[]". Don't do a type lookup if
7014 2005-02-25 Martin Baulig <martin@ximian.com>
7016 The first part of Nullable Types :-)
7018 * generic.cs (NullableType): New public class.
7019 (NullCoalescingOperator): New public class.
7020 (TypeArguments.Resolve): Add a CS0306 check.
7022 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7023 (opt_nullable): New rule.
7024 (type): Added `opt_nullable' to `namespace_or_type_name',
7025 `builtin_types' and `pointer_type'.
7026 (array_type): Added `opt_nullable'.
7027 (opt_rank_specifier_or_nullable): New rule; this is the
7028 combination of `opt_rank_specifier' and `opt_nullable'.
7029 (opt_error): New rule; catch errors here.
7030 (nullable_type_or_conditional): New rule; we use this to check for
7031 nullable and still detect the conditional operator.
7032 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7033 instead `opt_rank_specifier'.
7035 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7038 2005-02-24 Martin Baulig <martin@ximian.com>
7040 * README, README.Changes: Removed; they're old and obsolete.
7042 2005-02-22 Martin Baulig <martin@ximian.com>
7044 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7045 returned an error, set `constraints' to null to avoid a crash
7047 (TypeParameter.ResolveType): Likewise.
7049 2005-02-22 Martin Baulig <martin@ximian.com>
7052 (Constraints.ResolveTypes): Protect against being called twice.
7053 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7054 (TypeParameter.ResolveType): New public method; calls
7055 constraints.ResolveTypes().
7056 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7057 into the new ResolveType().
7058 (GenericMethod.Define): Call ResolveType() on all our
7061 2005-02-21 Martin Baulig <martin@ximian.com>
7064 (TypeManager.generic_nullable_type): New static public field.
7065 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7068 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7070 2005-02-15 Martin Baulig <martin@ximian.com>
7072 * generic.cs (ConstructedType.Constraints): Correctly check
7073 constraints if the argument type is a type parameter; fixes
7076 2005-02-02 Martin Baulig <martin@ximian.com>
7078 * delegate.cs (Delegate.DefineType): Report an internal error if
7079 TypeManager.multicast_delegate_type is null. See bug #72015 for
7082 2005-01-29 Miguel de Icaza <miguel@novell.com>
7084 * pending.cs: Produce better code (no nops produced by using Ldarg
7087 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7088 i - 1' it should be arg + 1.
7092 2005-01-26 Martin Baulig <martin@ximian.com>
7094 * cs-parser.jay (indexer_declarator): Don't report an error if we
7095 have type parameters since we can be an explicit interface
7096 implementation; fixes #71449.
7098 2005-01-26 Martin Baulig <martin@ximian.com>
7100 * class.cs (TypeContainer.AttributeTargets): Return the correct
7101 AttributeTargets depending on our `Kind' instead of throwing an
7102 exception; fixes #71632.
7104 2005-01-26 Martin Baulig <martin@ximian.com>
7106 * delegate.cs (Delegate.DefineType): Correctly define our type
7107 parameters. Fixes #71483.
7109 2005-01-25 Raja R Harinath <rharinath@novell.com>
7112 * expression.cs (MemberAccess.DoResolve): Don't complain with
7113 cs0572 when the LHS of a member access has identical name and type
7116 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7119 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7121 Create custom PermissionSet only for PermissionSetAttribute.
7123 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7126 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7127 delegates in static class.
7129 2005-01-24 Martin Baulig <martin@ximian.com>
7131 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7132 merging an implicit block, just use its reachability.
7134 * statement.cs (Block.Resolve): Make the unreachable code check
7135 work wrt. implicit blocks; see test-337 from #63842.
7137 2005-01-21 Alp Toker <alp@atoker.com>
7139 * cs-parser.jay: destructor_declaration's container is PartialContainer
7140 not Class when partial types are used, so use Kind prop instead of
7143 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7145 * cs-parser.jay: Improve error reporting when an interface
7148 2005-01-20 Dick Porter <dick@ximian.com>
7150 * support.cs: SeekableStreamReader fix from Sandor Dobos
7151 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7152 chars are read. Fixes bug 70369.
7154 2005-01-20 Raja R Harinath <rharinath@novell.com>
7156 * cs-parser.jay (catch_clause): Simplify current_block handling
7159 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7161 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7162 code with ImplicitStandardConversion to handle the implicit
7163 conversion of method groups into valid delegate invocations.
7165 The problem is that in parameter handling we were using this code
7166 path. Fixes bug #64698
7168 2005-01-19 Raja R Harinath <rharinath@novell.com>
7170 * cs-parser.jay: Fix several infelicities.
7171 - Avoid assigning to the parser value stack. Code like
7172 '$3 = null' is unclean. Synthesize a value for the code block
7174 - Avoid using oob_stack for storing location information. Use ...
7175 (_mark_): ... this. New (empty) rule. Saves the current location
7177 (foreach_statement): Avoid using oob_stack for current_block
7178 handling. Use technique used in for_statement and
7179 using_statement. Synthesize a value for the code block to store
7180 additional intermediate information.
7182 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7184 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7185 of a different type is only allowed to private fields of a
7186 containing type, not on fields of a base class.
7188 See test-174.cs and error cs0122-9.cs
7190 2005-01-13 Raja R Harinath <rharinath@novell.com>
7192 Fix test-335.cs (bug #58126).
7193 * cs-parser.jay (argument): Split out non-expression parts of the
7194 rule into 'non_simple_argument'.
7195 (invocation_expression): Support parenthesized invocations with
7196 multiple arguments, and with single non-simple arguments.
7198 2005-01-13 Raja R Harinath <rharinath@novell.com>
7200 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7203 2005-01-12 Raja R Harinath <rharinath@novell.com>
7205 Fix cs0038-1.cs, cs1640-6.cs.
7206 * ecore.cs (Expression.Resolve): Remove special-case for
7207 SimpleName in error-handling.
7208 (Expression.almostMatchedMembers): Relax access permission to
7210 (Expression.MemberLookupFailed): Handle duplicates in
7211 almostMatchedMembers list.
7212 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7213 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7214 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7215 overload if the passed in MemberInfo is a MethodBase.
7217 2005-01-25 Martin Baulig <martin@ximian.com>
7220 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7222 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7225 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7226 for non-CAS & merge permission sets properly.
7228 2005-01-11 Raja R Harinath <rharinath@novell.com>
7230 Improve standard-compliance of simple name and member access
7231 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7232 * ecore.cs (FullNamedExpression): New abstract base class
7233 for Namespaces and TypeExpressions.
7234 (ResolveFlags.SimpleName): Remove.
7235 (SimpleName): Remove support for dotted names.
7236 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7237 DeclSpace.FindType and DeclSpace.LookupType.
7238 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7239 (Expression.ExprClassName): Make member function.
7240 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7241 a namespace. Remove creation of dotted "SimpleName"s.
7242 (MemberAccess.DoResolve): Likewise.
7243 * decl.cs (DeclSpace.Cache): Make private.
7244 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7245 (DeclSpace.FindType): Update.
7246 (DeclSpace.LookupType): Move here from RootContext. Return a
7247 FullNamedExpression.
7248 * namespace.cs (Namespace): Derive from FullNamedExpression
7249 so that it can be part of expression resolution.
7250 (Namespace.Lookup): Return an FullNamedExpression.
7251 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7253 * rootcontext.cs (NamespaceLookup): Remove.
7254 (LookupType): Move to DeclSpace.
7255 * attribute.cs (CheckAttributeType): Update.
7256 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7257 (FindDocumentedTypeNonArray): Likewise.
7259 2005-01-11 Raja R Harinath <rharinath@novell.com>
7261 Fix cs0509.cs, cs1632.cs.
7262 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7263 is the same as IsInterface.
7264 (TypeContainer.GetClassBases): Likewise.
7265 * statement.cs (LabeledStatement.ig): New field.
7266 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7268 (LabeledStatement.DoEmit): Check that the label was created with
7269 the same ILGenerator.
7271 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7274 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7275 accessors to its properties.
7277 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7278 from accessors to property.
7280 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7283 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7286 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7288 * attribute.cs: Check for null and empty strings.
7290 I have lost another battle to Paolo.
7292 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7295 * class.cs (PropertyMethod): Set Parent field in ctors.
7296 (SetMethod.InternalParameters): Add unsafe switch hack.
7297 Override MarkForDuplicationCheck where it is appropriate.
7299 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7300 It says whether container allows members with the same name.
7302 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7303 Removed is_method parameter.
7305 2005-01-06 Duncan Mak <duncan@ximian.com>
7307 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7308 because the previous change led to incorrect reporting of CS1032
7309 ("Cannot define/undefine preprocessor symbols after first token in
7310 file"). Instead of using `tokens_seen' as the only flag that
7311 triggers CS1040, introduce `comments_seen'. This new flag is used
7312 to signify having seen comments on the current line, so it is
7313 unset after a newline.
7315 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7317 * doc.cs : When searching for a type, find nested type too.
7318 This fixes bug #71040.
7320 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7323 - Warn missing member comment on those classes which also does not
7324 have doc comments. Fixed bug #71041.
7325 - Don't warn missing doc comment on default constructor.
7328 2005-01-06 Duncan Mak <duncan@ximian.com>
7330 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7331 comments, set `tokens_seen' to true. This allows us to detect
7332 misplaced preprocessor directives (i.e. not at the beginning of
7333 the a line, nor after whitespaces). In that case, report error
7334 CS1040. This fixes bug #56460.
7336 * cs-parser.jay (interface_member_declaration): Add checks for
7337 IsExplicitImpl, and report CS0541 error if an interface member is
7338 defined as an explicit interface declaration.
7340 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7343 * class.cs (PropertyMethod): Set Parent field in ctors.
7344 (SetMethod.InternalParameters): Add unsafe switch hack.
7346 * decl.cs (MemberCore.Parent): Cannot be readonly.
7348 2005-01-06 Raja R Harinath <rharinath@novell.com>
7350 * decl.cs (DeclSpace.ResolveType): Remove.
7351 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7352 Merge in code from ...
7353 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7354 * class.cs, enum.cs: Update to changes.
7356 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7358 * anonymous.cs: Ensure that we init the scope of our parent if it
7359 has not been initialized yet.
7361 2004-12-30 Duncan Mak <duncan@ximian.com>
7363 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7364 if field.FieldBuilder is null. Fixes #70758.
7366 * convert.cs: Fixed some typos and updated some of the comments.
7367 (ImplicitStandardConversionExists):
7368 (TryImplicitIntConversion): If `target_type' is an interface and
7369 the type of `ic' implements this interface, return true or a new
7370 BoxedCast instead of null. This fixes #70468.
7372 2004-12-29 Duncan Mak <duncan@ximian.com>
7374 * expression.cs (Argument.Emit): Check that Expr is
7375 IMemoryLocation before casting to it, and report CS1510 otherwise.
7379 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7381 * statement.cs (Block.ThisVariable): remove the recursion here, to
7382 make the --profile more sane.
7384 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7386 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7387 assembly, by JB Evain.
7389 2004-12-17 Raja R Harinath <rharinath@novell.com>
7391 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7392 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7393 "parent" refers to enclosing type/class. "base" refers to superclass.
7395 2004-12-17 Raja R Harinath <rharinath@novell.com>
7397 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7398 Ensure that we only have GlobalAttributes.
7399 * attribute.cs (Attribute.Emit): Make non-virtual.
7400 (GlobalAttribute.Emit): Remove.
7401 (Attribute.Resolve): Make virtual.
7402 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7403 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7404 the argument. Don't create one.
7405 (Attribute.GetObsoleteAttribute): Likewise.
7406 (Attribute.GetClsCompliantAttributeValue): Likewise.
7407 * class.cs, decl.cs: Update to changes.
7409 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7411 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7413 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7415 * statement.cs (Foreach.Resolve): Add error 186 report.
7417 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7419 * expression.cs (Conditional.DoResolve): Add warning 429.
7421 * statement.cs (If.Resolve): Add warning 665.
7423 2004-12-16 Raja R Harinath <rharinath@novell.com>
7425 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7426 except when in the parser, and in GlobalAttribute.
7427 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7428 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7429 RootContext.Tree.Types.NamespaceEntry once work is done.
7430 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7431 and resets RootContext.Tree.Types.NamespaceEntry.
7433 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7435 * cs-parser.jay: Don't create a block for every variable.
7437 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7439 * location.cs: Provide extra information.
7441 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7442 variables from the captured environment, it is the ldarg_0.
7444 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7446 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7449 * class.cs: Changed warning level for 169 to avoid developer
7450 displeasure from warning flooding. It will be changed back when they
7451 fix most of current BCL warnings.
7453 * RootContext.cs: Pushed default WarningLevel to 3.
7455 * statement.cs: Removed unused variable.
7457 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7459 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7460 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7461 Add error 502 report.
7462 (StaticClass.DefineType): Add error 441 report.
7463 (Class.AllowedModifiersProp): New virtual property as temporary
7464 extension to AllowedModifiers.
7465 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7466 to share implementation with StaticClass and don't call virtual
7469 * driver.cs (MainDriver): Add error 1558 test.
7471 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7472 report. Moved error 36 test here.
7474 * statement.cs (Throw.Resolve): Add error 724 report.
7476 * typemanager.cs: Add out_attribute_type core type.
7478 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7480 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7482 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7484 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7487 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7489 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7490 Add error 3023 report.
7491 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7493 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7496 2004-12-12 John Luke <john.luke@gmail.com>
7498 * driver.cs (AddArgs): take -- into account when
7499 adding arguments, fixes bug 65710
7501 2004-12-12 Martin Baulig <martin@ximian.com>
7503 * expression.cs (Unary.TryReduceNegative): Added support for
7504 SByteConstant and ByteConstant.
7505 (Unary.Reduce): Check error values from TryReduceNegative().
7507 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7509 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7510 and report exception as error 182.
7512 2004-12-10 Raja R Harinath <rharinath@novell.com>
7514 * driver.cs (Main): Fix message when there are warnings.
7516 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7518 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7520 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7522 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7523 Reduced number of warnings.
7525 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7527 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7529 * driver.cs: Removed message.
7531 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7533 2004-12-08 <vargaz@freemail.hu>
7535 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7537 2004-12-08 Martin Baulig <martin@ximian.com>
7539 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7540 instead of a CS3002 for properties and indexer.
7542 2004-12-08 Martin Baulig <martin@ximian.com>
7544 * decl.cs (MemberName.ToString): Make this work again.
7546 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7548 * attribute.cs (Resolve): Add error 591 detection.
7550 * class.cs (FieldMember.Define): Add error 1547 detection.
7551 (Indexer.Define): Add error 620 detection.
7552 (Operator.Define): Add error 590 detection.
7554 * ecore.cs: Missing argument for error 79.
7556 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7559 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7562 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7565 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7567 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7568 Some operator comments were suppressed.
7569 * doc.cs : Implicit/explicit operator name in doc comments are like
7570 "op_Explicit(type)~returnType", so added suffix handling.
7572 2005-01-21 Alp Toker <alp@atoker.com>
7574 * cs-parser.jay: destructor_declaration's container is PartialContainer
7575 not Class when partial types are used, so use Kind prop instead of 'is'.
7577 2004-12-12 Martin Baulig <martin@ximian.com>
7579 * expression.cs (Unary.TryReduceNegative): Added support for
7580 SByteConstant and ByteConstant.
7581 (Unary.Reduce): Check error values from TryReduceNegative().
7583 2004-12-11 Martin Baulig <martin@ximian.com>
7585 * support.cs (ReflectionParameters.ParameterName): If we have a
7586 `gpd', call `ParameterName' on it.
7588 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7590 * pending.cs (PendingImplementation.DefineProxy): Call
7591 DefineParameter() for all of the MethodBuilder's arguments.
7593 2004-12-09 Martin Baulig <martin@ximian.com>
7595 * doc.cs (DocUtil): Make this a static class.
7597 2004-12-09 Martin Baulig <martin@ximian.com>
7599 * expression.cs (Invocation.InferType): Moved the type inference
7600 implementation into TypeManager.
7602 * generics.cs (TypeManager): Moved the type inference
7603 implementation here.
7605 2004-12-09 Martin Baulig <martin@ximian.com>
7607 * typemanager.cs (TypeManager): Make this a partial class.
7610 (TypeManager): Move the generics part of `TypeManager' here.
7612 2004-12-08 Martin Baulig <martin@ximian.com>
7614 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7615 instead of a CS3002 for properties and indexer. Added CS3024
7616 check for generic interfaces.
7618 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
7619 instances are not CLS-compliant.
7621 2004-12-08 Martin Baulig <martin@ximian.com>
7624 (void_pointer_expression): New rule for `void*', `void**' etc.
7625 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
7627 2004-12-08 Martin Baulig <martin@ximian.com>
7629 * expression.cs (Invocation.InferType): Removed the hack for
7630 MethodCore.MayUnify().
7632 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
7635 * class.cs (MethodCore.MayUnify): Use
7636 TypeManager.MayBecomeEqualGenericTypes().
7638 2004-12-08 Martin Baulig <martin@ximian.com>
7640 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
7641 parameter, box it. Fixes #69233.
7643 2004-12-08 Martin Baulig <martin@ximian.com>
7645 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
7646 have the ctor constraint. Fixes #68326.
7648 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7650 * cs-parser.jay : interface comment was not consumed because of
7651 extra opt_semicolon before doc handling.
7653 2004-12-03 Raja R Harinath <rharinath@novell.com>
7655 Fix test-327.cs, test-328.cs, and put in early infrastructure
7656 for eventually fixing #52697.
7657 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
7658 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
7660 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
7661 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
7662 (VerifyUsing, error246): Update.
7663 * rootcontext.cs (RootContext.NamespaceLookup): Just use
7664 'NamespaceEntry.LookupNamespaceOrType'.
7666 2004-12-07 Martin Baulig <martin@ximian.com>
7668 * driver.cs: Call it "BETA SOFTWARE" :-)
7670 2004-12-06 Raja R Harinath <rharinath@novell.com>
7672 Fix crash on cs0657-17.cs.
7673 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7674 Use RootContext.Tree.Types, not 'new RootTypes ()'.
7675 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
7676 the case where the NamespaceEntry gets overwritten.
7678 2004-12-06 Marek Safar <marek.safar@seznam.cz>
7680 Fixed #69195, #56821
7681 * ecore.cs (ResolveBoolean): Tiny refactoring.
7683 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
7684 of right expression resolving when left is false constant and
7685 operator is LogicalAnd OR true constant and operator is LogicalOr.
7687 * statement.cs (ResolveUnreachable): Always reports warning.
7689 2004-12-05 Miguel de Icaza <miguel@ximian.com>
7691 * class.cs: Distinguish between 1721 and 1722 (just a little help
7692 for the programmer).
7694 2004-12-03 Miguel de Icaza <miguel@ximian.com>
7696 * delegate.cs: Only allow this on new versions of the language.
7698 2004-12-02 Duncan Mak <duncan@ximian.com>
7700 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
7702 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
7703 here as a static method. Take an additional bool out parameter
7704 `must_do_cs1540_check' for signaling to InstanceResolve.
7705 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
7706 member field from PropertyExpr class and made it an argument of
7708 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
7709 check for MarshalByRefObject, and report CS0122 instead of CS1540.
7710 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
7711 and `remove_accessor' as well as InstanceResolve: report CS0122
7716 2004-12-07 Martin Baulig <martin@ximian.com>
7718 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
7719 and CS0692 where appropriate.
7721 2004-12-06 Martin Baulig <martin@ximian.com>
7723 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
7724 IsDuplicateImplementation() and improved it.
7726 * expression.cs (Invocation.InferTypeArguments): Added
7727 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
7728 and removed the "ref" modifier from `infered_types'.
7730 * decl.cs (MemberName.ToString): Removed the exception.
7732 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
7734 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
7735 comments are allowed.
7737 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7739 * delegate.cs: Add checks for subtypes in paramaters and return values
7740 in VerifyMethod () to add support for Covariance/Contravariance
7743 2004-12-02 Miguel de Icaza <miguel@ximian.com>
7745 * report.cs: Remove extra closing parenthesis.
7747 * convert.cs (Error_CannotImplicitConversion): If the name of the
7748 types are the same, provide some extra information.
7750 2004-12-02 Marek Safar <marek.safar@seznam.cz>
7753 * attribute.cs (Resolve): Improved implementation of params
7754 attribute arguments.
7756 * support.cs (ParameterData): Add HasParams to be faster.
7758 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
7760 all things are for /doc support:
7762 * doc.cs: new file that supports XML documentation generation.
7763 * mcs.exe.sources: added doc.cs.
7765 Handle /doc command line option.
7766 Report error 2006 instead of 5 for missing file name for /doc.
7767 Generate XML documentation when required, after type resolution.
7769 Added support for picking up documentation (/// and /** ... */),
7770 including a new XmlCommentState enumeration.
7772 Added lines to fill Documentation element for field, constant,
7773 property, indexer, method, constructor, destructor, operator, event
7774 and class, struct, interface, delegate, enum.
7775 Added lines to warn incorrect comment.
7777 Added Documentation field (passed only when /doc was specified).
7779 Added DocComment, DocCommentHeader, GenerateDocComment() and
7780 OnGenerateDocComment() and some supporting private members for
7781 /doc feature to MemberCore.
7783 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
7785 Added overriden DocCommentHeader.
7787 Added overriden DocCommentHeader and GenerateDocComment().
7789 2004-12-01 Miguel de Icaza <miguel@ximian.com>
7791 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
7792 unwrapping the enumeration values, chain to
7793 DoConstantNumericPromotions again, so we can promote things to the
7794 fundamental types (takes care of enums that are bytes, sbytes).
7798 2004-12-01 Raja R Harinath <rharinath@novell.com>
7800 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
7801 Fix long-standing bug in type-lookup. Use FindType instead of
7802 LookupType when ec.ResolvingTypeTree.
7803 (Attribute.ResolveType, Attribute.Resolve)
7804 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
7806 (Attributes.Search): Remove internal version. Update.
7807 (Attributes.SearchMulti): Update.
7808 (Attributes.GetClsCompliantAttribute): Remove.
7809 (Attributes.GetIndexerNameAttribute): Remove.
7810 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
7811 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
7812 * class.cs (Indexer.Define): Likewise.
7814 2004-12-01 Marek Safar <marek.safar@seznam.cz>
7817 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
7818 MarshallByReference members access.
7820 * expression.cs: Use CheckMarshallByRefAccess;
7821 Better error CS0197 message.
7823 * report.cs: Print whole related error message.
7825 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7827 * class (GetClassBases): Better error 60 report.
7828 (EventProperty): Disabled warning 67 detection.
7830 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7833 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
7835 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
7838 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7841 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
7843 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
7845 2004-11-26 Miguel de Icaza <miguel@ximian.com>
7847 * attribute.cs (Attribute.Resolve): Refine error reporting and
7848 report a cs0117 if the identifier does not exist, to distinguish
7849 from 0617 which is a miss-use of the actual identifier.
7851 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
7852 between cs0070 and cs0079.
7854 * class.cs (MemberBase.DoDefine): When reporting a wrong
7855 accessibility level, we use MethodCore to compare instead of
7856 Method (this was a regression in some refactoring effort).
7858 So now we correctly report cs0056 again.
7860 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
7861 testing the target_type (which was known to be object_type) and
7862 not the source type (which is anonymous_method).
7864 Fixed reporting of error cs1660.
7866 * expression.cs (UserCast.Source): Expose the underlying cast.
7868 * statement.cs (Switch.SwitchGoverningType): Sort the list of
7869 allowed types to find a match to int32 first (most common).
7871 In addition, it ignores any ImplicitUserConversions that did an
7872 internal implicit conversion (as the switch statement allows only
7873 one integral conversion to exist).
7875 * class.cs (PartialContainer.Create): rename `name' to
7876 `member_name' for clarity. Then replace the string calls with a
7877 call to MemberName.GetPartialName, as now using
7878 MemberName.ToString is an error (this is due to the side effects
7879 it had, that were fixed in the past).
7881 This will restore the error reporting on a number of partial class
7882 errors that were missusing this (and getting an exception as a
7883 results, which is now just a plain textual warning, because
7884 yyparse debug output would crash otherwise).
7886 2004-11-26 Raja R Harinath <rharinath@novell.com>
7888 * Makefile (PROGRAM_INSTALL_DIR): Remove.
7890 2004-11-25 Ben Maurer <bmaurer@ximian.com>
7892 * rootcontext.cs (LookupType): Make sure to cache lookups that
7893 don't give us a negative result. This saves about 5% of corlib
7896 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7898 * report.cs (AbstractMessage.Print): messages are sent to stderr
7900 * class.cs (TypeContainer.GetClassBases): It is an error to have a
7901 non-interface in the list of interfaces (at this point, either
7902 parent was properly set, or a base class is being listed in the
7903 interfaces section).
7905 This flags error 1722, and resolves the crash from bug 69259.
7907 2004-11-25 Ben Maurer <bmaurer@ximian.com>
7909 * statement.cs (Using.EmitExpressionFinally): make this work right
7910 for valuetypes. Fixes 69926.
7912 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7914 * const.cs (Const.ChangeType): Cope with the "0 literal can be
7915 converted to an enum" here, before we try to change the underlying
7916 type. This code exists, but it is a different code path than the
7917 one used while encoding constants.
7919 (ImplicitReferenceConversionExists): In addition, resynchronized
7920 the code here, so it matches the same code in
7921 ImplicitReferenceConversionExists for the `from any class-type S
7922 to any interface-type T'.
7924 2004-11-25 Marek Safar <marek.safar@seznam.cz>
7926 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
7928 2004-11-24 Miguel de Icaza <miguel@ximian.com>
7930 * cs-parser.jay: Use verbosity accordingly.
7932 2004-11-24 Marek Safar <marek.safar@seznam.cz>
7934 * expression.cs (Unary.ResolveOperator): Do not report warning;
7935 AddressOf reads from variable.
7937 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
7939 2004-11-24 Marek Safar <marek.safar@seznam.cz>
7943 * attribute.cs (Attributable): Removed CheckTargets.
7944 (Attributes.Emit): Explicit attribute targets are tested here.
7946 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
7947 not enabled for interfaces.
7949 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
7950 (GetAssemblyName): Ouch next bug there.
7952 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7954 * expression.cs: Error 275 added.
7956 2004-11-23 Marek Safar <marek.safar@seznam.cz>
7958 Fix bug #69177 (Implemented decimal constant support)
7960 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
7961 (BinaryFold): Add DecimalConstant.
7963 * const.cs (Define): Decimal constant
7965 (ChangeType): Add decimal type handling.
7966 (LookupConstantValue): Don't set value for decimal type but
7967 emit DecimalConstantAttribute. Needed for constant optimization.
7969 * constant.cs (ToDecimal): New method.
7970 (ConvertToDecimal): New method.
7971 (IntConstant): Implemented ConvertToDecimal.
7972 (DecimalConstant.Emit): Emit optimized version for decimals in
7975 * expression.cs (ResolveOperator): Changed order of constant
7976 reduction to work correctly with native types which have
7977 overloaded operators.
7978 (ResolveMemberAccess): Extract constant value from attribute
7981 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
7983 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
7984 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
7985 (ChangeType): Decimal is special.
7986 (TypeToCoreType): Add decimal type.
7988 2004-11-22 Marek Safar <marek.safar@seznam.cz>
7990 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
7993 2004-11-22 Marek Safar <marek.safar@seznam.cz>
7995 * class.cs (EventField.ApplyAttributeBuilder): Fix error
7998 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8000 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8002 * pending.cs (PendingImplementation): Grab only interfaces.
8004 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8006 * statement.cs (ForeachHelperMethods): Add location member and
8007 error 202 detection.
8009 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8011 * expression.cs (DoResolveBase): Fixed wrong warning for out
8014 2004-12-04 Martin Baulig <martin@ximian.com>
8016 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8017 to check whether the conversion is ok.
8019 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8020 `Type.EmptyTypes' if we're not a generic TypeContainer.
8022 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8024 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8025 old bug: when converting from the null literal to a pointer,
8026 return an EmptyCast, not the NullLiteral.
8028 This fixes #69921, the recent null_type changes probably made this
8031 2004-12-03 Martin Baulig <martin@ximian.com>
8033 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8034 method as our child, call AnonymousMethod.Compatible() on it.
8036 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8038 * class.cs (FieldBase): Use an unused bit field from the field to
8039 encode the `has_offset' property from the FieldMember. This saves
8040 a couple of Ks on bootstrap compilation.
8042 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8043 method as our child, return the AnonymousMethod resolved
8046 * expression.cs (New.DoResolve): Allow return values from
8047 NewDelegate to also include AnonymousMethods.
8051 2004-11-29 Raja R Harinath <rharinath@novell.com>
8053 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8055 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8056 System.Runtime.InteropServices._Exception, since it's a base
8057 interface of the core type System.Exception in the net_2_0 profile.
8059 2004-11-27 Martin Baulig <martin@ximian.com>
8061 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8063 2004-11-26 Raja R Harinath <rharinath@novell.com>
8065 * Makefile: Convert to use executable.make.
8066 * gmcs.exe.sources: New.
8068 2004-11-25 Martin Baulig <martin@ximian.com>
8070 * expression.cs (Invocation.InferType): Added support for byref types.
8072 2004-11-25 Martin Baulig <martin@ximian.com>
8074 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8075 in TypeManager.TypeToCoreType().
8077 2004-11-25 Martin Baulig <martin@ximian.com>
8079 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8080 "Dispose" method from the `current_type'.
8081 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8082 DoDefineMembers() instead of using the MethodBuilder; this is
8083 required for generic iterators.
8085 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8087 2004-11-24 Martin Baulig <martin@ximian.com>
8089 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8091 2004-11-20 Martin Baulig <martin@ximian.com>
8093 * expression.cs (Invocation.InferType): Correctly infer generic
8094 instances; see gen-103.cs.
8095 (Invocation.InferTypeArguments): If a generic method doesn't have
8096 any unbound type parameters, we don't need to infer anything.
8098 2004-11-19 Raja R Harinath <rharinath@novell.com>
8100 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8102 2004-11-17 Raja R Harinath <rharinath@novell.com>
8104 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8105 (TypeHandle.GetMemberCache): New.
8106 (TypeHandle.TypeHandle): Update.
8107 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8108 (TypeManager.LookupParentInterfacesCache):
8109 Rename from LookupInterfaceCache. Optimize slightly.
8110 (TypeManager.MemberLookup_FindMembers): Update.
8111 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8113 (AddCacheContents): Rename from AddHashtable.
8114 * class.cs (TypeContainer.parent_container): Remove.
8115 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8116 (TypeContainer.DoDefineMembers): Don't initialize it.
8117 Update to name changes.
8119 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8121 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8122 that factors the code to check access modifiers on override.
8124 (PropertyBase): Use the code here.
8126 Patch from Lluis S'anchez, fixes bug #69361.
8128 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8130 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8131 routine that is used to report the use of a captured variable
8132 whose address has been taken.
8134 There are two checks: one when variables are being captured and
8135 the other check is when the address of a variable is taken.
8137 (because an anonymous methods might be resolved before *or* after
8138 the address has been taken) and
8140 * expression.cs (Conditional.DoResolve): Remove the special
8141 casing that Martin added to trueExpr and falseExpr being both
8142 NullLiteral. We get the right behavior now just by introducing
8143 the null_type into the compiler.
8145 * convert.cs (ExplicitConversion): Change the code to use
8146 null_type instead of testing `expr is NullLiteral'.
8147 (ImplicitConversionStandard): use null_type too.
8148 (ImplicitReferenceConversionExists): use null_type too.
8149 (ImplicitReferenceConversion): use null_type too.
8151 * literal.cs: The type of `NullLiteral' is now null_type instead
8153 (Resolve): Set the type here.
8155 * typemanager.cs: Introduce null_type.
8157 2004-11-18 Martin Baulig <martin@ximian.com>
8160 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8162 2004-11-18 Martin Baulig <martin@ximian.com>
8164 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8166 2004-11-18 Martin Baulig <martin@ximian.com>
8168 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8169 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8170 call ResolveConstructedType() on it to resolve it without checking
8172 (Constraints.ResolveTypes): Check them here.
8173 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8174 but don't check constraints.
8175 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8176 check constraints here.
8177 (ConstructedType.ResolveConstructedType): New public method. This
8178 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8179 resolve ourselves without checking constraints.
8181 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8183 2004-11-18 Martin Baulig <martin@ximian.com>
8186 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8188 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8190 2004-11-18 Martin Baulig <martin@ximian.com>
8192 * ecore.cs (TypeExpr.ResolveType): Removed.
8193 (Expression.ResolveAsTypeTerminal): We always return a fully
8194 resolved `TypeExpr', so we can just access its `Type'.
8196 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8198 2004-11-17 Martin Baulig <martin@ximian.com>
8200 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8201 sure we don't return any unresolved TypeExpr's.
8202 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8204 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8206 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8207 unresolved `ConstructedType's.
8209 2004-11-17 Martin Baulig <martin@ximian.com>
8211 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8213 2004-11-17 Martin Baulig <martin@ximian.com>
8216 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8218 * decl.cs (DeclSpace.ResolveType): Removed.
8219 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8221 2004-11-17 Martin Baulig <martin@ximian.com>
8223 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8224 direction, like FindMembers() does. Fixes #69546, testcase is in
8227 2004-11-16 Martin Baulig <martin@ximian.com>
8229 This is based on a patch from Marek Safar, see bug #69082.
8230 Fixes bugs #63705 and #67130.
8232 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8233 method; create a MemberCache for an interface type and cache the
8236 * decl.cs (IMemberContainer.ParentContainer): Removed.
8237 (IMemberContainer.ParentCache): New property.
8238 (MemberCache.SetupCacheForInterface): Removed.
8239 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8240 to create a cache for an interface's "parent".
8242 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8245 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8247 * statement.cs: Avoid adding bools to a hashtable.
8249 2004-11-15 Martin Baulig <martin@ximian.com>
8251 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8253 2004-11-11 Martin Baulig <martin@ximian.com>
8255 * typemanager.cs (TypeManager.GetMethodName): New method.
8257 * class.cs (MethodData.Define): Include the generic arity in the
8258 name of an explicit interface; also add it to the method name.
8260 * pending.cs (PendingImplementation.InterfaceMethod): The method
8261 name now includes the generic arity.
8263 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8265 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8266 calling an unsafe method from a safe location.
8268 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8271 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8273 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8275 * namespace.cs (VerifyUsing): use GetPartialName instead of
8278 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8280 * statement.cs (Return.Resolve): Fix regression in typo: if
8281 `in_exc', we have to request a NeedReturnLabel, this was a typo
8282 introduced in the anonymous method check-in. Fixes #69131.
8284 * Indexers were using the ShortName when defining themselves,
8285 causing a regression in the compiler bootstrap when applying the
8286 patch from 2004-11-02 (first part), now they use their full name
8287 and the bug is gone.
8289 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8291 * driver.cs: Strip the path from the names of embedded resources. Fixes
8294 2004-11-04 Raja R Harinath <rharinath@novell.com>
8296 Fix error message regression: cs0104-2.cs.
8297 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8298 (AliasEntry.Resolve): Update.
8299 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8301 (RootContext.LookupType): Update.
8303 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8305 * cs-parser.jay: Add support for handling accessor modifiers
8306 * class: Add support port accessor modifiers and error checking,
8307 define PropertyMethod.Define as virtual (not abstract anymore)
8308 * ecore.cs: Add checking for proeprties access with access modifiers
8309 * iterators.cs: Modify Accessor constructor call based in the modified
8311 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8313 * expression.cs (StringConcat): Handle being called twice,
8314 as when we have a concat in a field init with more than two
8317 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8319 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8320 special case explicit implementations, we should always produce
8321 the .property or .event declaration.
8323 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8324 since it will not return correct data if people use this
8325 unresolved in the presence of using statements (see test-313).
8327 * class.cs (MethodData.Define): If we are an explicit interface
8328 implementation, set the method name to the full name of the
8329 interface plus the name of the method.
8331 Notice that using the method.MethodName.GetFullName() does not
8332 work, as it will only contain the name as declared on the source
8333 file (it can be a shorthand in the presence of using statements)
8334 and not the fully qualifed type name, for example:
8338 class D : ICloneable {
8339 object ICloneable.Clone () {
8343 Would produce a method called `ICloneable.Clone' instead of
8344 `System.ICloneable.Clone'.
8346 * namespace.cs (Alias.Resolve): Use GetPartialName.
8348 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8350 * cs-parser.jay: Add error 1055 report.
8352 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8354 * assign.cs (Assign.DoResolve): Only do the transform of
8355 assignment into a New if the types are compatible, if not, fall
8356 through and let the implicit code deal with the errors and with
8357 the necessary conversions.
8359 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8361 * cs-parser.jay: Add error 1031 report.
8363 * cs-tokenizer.cs: Add location for error 1038.
8365 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8367 * cs-parser.jay: Add error 1016 report.
8369 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8371 * cs-parser.jay: Add errors 1575,1611 report.
8373 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8375 * cs-parser.jay: Add error 1001 report.
8377 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8380 * attribute.cs (GetMarshal): Add method argument for
8381 caller identification.
8383 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8384 agument for GetMarshal and RuntimeMissingSupport.
8386 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8388 * attribute.cs (ExtractSecurityPermissionSet): Removed
8389 TypeManager.code_access_permission_type.
8391 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8393 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8395 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8396 for obsolete use of a variable here. Fixes regression on errors
8397 cs0619-25 and cs0619-26.
8399 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8401 Fix #62358, implemented security attribute encoding.
8403 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8404 Tests permitted SecurityAction for assembly or other types.
8405 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8406 data from SecurityPermissionAttribute to PermisionSet class.
8408 * class.cs (ApplyAttributeBuilder): Added special handling
8409 for System.Security.Permissions.SecurityAttribute based types.
8411 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8412 special handling for System.Security.Permissions.SecurityAttribute
8415 * enum.cs (ApplyAttributeBuilder): Added special handling
8416 for System.Security.Permissions.SecurityAttribute based types.
8418 * parameter.cs (ApplyAttributeBuilder): Added special handling
8419 for System.Security.Permissions.SecurityAttribute based types.
8421 * rootcontext.cs: Next 2 core types.
8423 * typemanager.cs (TypeManager.security_permission_attr_type):
8424 Built in type for the SecurityPermission Attribute.
8425 (code_access_permission_type): Build in type.
8427 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8429 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8430 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8431 all of this information into
8432 EmitContext.EmitCapturedVariableInstance.
8434 * codegen.cs (EmitCapturedVariableInstance): move here the
8435 funcionality of emitting an ldarg.0 in the presence of a
8436 remapping. This centralizes the instance emit code.
8438 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8439 then emit a load of this: it means that we have reached the
8440 topmost ScopeInfo: the one that contains the pointer to the
8441 instance of the class hosting the anonymous method.
8443 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8444 captures to the topmost CaptureContext.
8446 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8448 * expression.cs (LocalVariableReference): Move the knowledge about
8449 the iterators into codegen's EmitCapturedVariableInstance.
8451 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8453 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8454 all code paths return a value from an anonymous method (it is the
8455 same as the 161 error, but for anonymous methods).
8457 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8459 The introduction of anonymous methods in the compiler changed
8460 various ways of doing things in the compiler. The most
8461 significant one is the hard split between the resolution phase
8462 and the emission phases of the compiler.
8464 For instance, routines that referenced local variables no
8465 longer can safely create temporary variables during the
8466 resolution phase: they must do so from the emission phase,
8467 since the variable might have been "captured", hence access to
8468 it can not be done with the local-variable operations from the runtime.
8472 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8473 is a toplevel block.
8475 (ToplevelBlock): A new kind of Block, these are the blocks that
8476 are created by the parser for all toplevel method bodies. These
8477 include methods, accessors and anonymous methods.
8479 These contain some extra information not found in regular blocks:
8480 A pointer to an optional CaptureContext (for tracking captured
8481 local variables and parameters). A pointer to the parent
8484 (Return.Resolve): Catch missmatches when returning a value from an
8485 anonymous method (error 1662).
8486 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8489 (Break.Resolve): ditto.
8491 (SwitchLabel): instead of defining the labels during the
8492 resolution phase, we now turned the public ILLabel and ILLabelCode
8493 labels into methods called GetILLabelCode() and GetILLabel() that
8494 only define the label during the Emit phase.
8496 (GotoCase): Track the SwitchLabel instead of the computed label
8497 (its contained therein). Emit the code by using
8498 SwitchLabel.GetILLabelCode ().
8500 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8501 whether the Local has been captured or not.
8503 (LocalInfo.IsCaptured): New property, used to tell whether the
8504 local has been captured.
8506 * anonymous.cs: Vastly updated to contain the anonymous method
8509 The main classes here are: CaptureContext which tracks any
8510 captured information for a toplevel block and ScopeInfo used to
8511 track the activation frames for various local variables.
8513 Each toplevel block has an optional capture context associated
8514 with it. When a method contains an anonymous method both the
8515 toplevel method and the anonymous method will create a capture
8516 context. When variables or parameters are captured, they are
8517 recorded on the CaptureContext that owns them, for example:
8521 MyDelegate d = delegate {
8526 Here `a' will be recorded as captured on the toplevel
8527 CapturedContext, the inner captured context will not have anything
8528 (it will only have data if local variables or parameters from it
8529 are captured in a nested anonymous method.
8531 The ScopeInfo is used to track the activation frames for local
8532 variables, for example:
8534 for (int i = 0; i < 10; i++)
8535 for (int j = 0; j < 10; j++){
8536 MyDelegate d = delegate {
8541 At runtime this captures a single captured variable `i', but it
8542 captures 10 different versions of the variable `j'. The variable
8543 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8544 recorded on a child.
8546 The toplevel ScopeInfo will also track information like the `this'
8547 pointer if instance variables were referenced (this is necessary
8548 as the anonymous method lives inside a nested class in the host
8549 type of the method).
8551 (AnonymousMethod): Expanded to track the Toplevel, implement
8552 `AnonymousMethod.Compatible' to tell whether an anonymous method
8553 can be converted to a target delegate type.
8555 The routine now also produces the anonymous method content
8557 (AnonymousDelegate): A helper class that derives from
8558 DelegateCreation, this is used to generate the code necessary to
8559 produce the delegate for the anonymous method that was created.
8561 * assign.cs: API adjustments for new changes in
8562 Convert.ImplicitStandardConversionExists.
8564 * class.cs: Adjustments to cope with the fact that now toplevel
8565 blocks are of type `ToplevelBlock'.
8567 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8568 insteda of standard blocks.
8570 Flag errors if params arguments are passed to anonymous methods.
8572 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8573 `CurrentAnonymousMethod' which points to the current Anonymous
8574 Method. The variable points to the AnonymousMethod class that
8575 holds the code being compiled. It is set in the new EmitContext
8576 created for the anonymous method.
8578 (EmitContext.Phase): Introduce a variable and an enumeration to
8579 assist in enforcing some rules about when and where we are allowed
8580 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8581 only one that enfonces this right now).
8583 (EmitContext.HaveCaptureInfo): new helper method that returns
8584 whether we have a CapturedContext initialized.
8586 (EmitContext.CaptureVariable): New method used to register that a
8587 LocalInfo must be flagged for capturing.
8589 (EmitContext.CapturedParameter): New method used to register that a
8590 parameters must be flagged for capturing.
8592 (EmitContext.CapturedField): New method used to register that a
8593 field must be flagged for capturing.
8595 (EmitContext.HaveCapturedVariables,
8596 EmitContext.HaveCapturedFields): Return whether there are captured
8597 variables or fields.
8599 (EmitContext.EmitMethodHostInstance): This is used to emit the
8600 instance for the anonymous method. The instance might be null
8601 (static methods), this (for anonymous methods that capture nothing
8602 and happen to live side-by-side with the current method body) or a
8603 more complicated expression if the method has a CaptureContext.
8605 (EmitContext.EmitTopBlock): Routine that drives the emission of
8606 code: it will first resolve the top block, then emit any metadata
8607 and then emit the code. The split is done so that we can extract
8608 any anonymous methods and flag any captured variables/parameters.
8610 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
8611 during this phase, the ILGenerator should not be used as labels
8612 and local variables declared here might not be accessible to any
8613 code that is part of an anonymous method.
8615 Exceptions to this include the temporary variables that are
8616 created by some statements internally for holding temporary
8619 (EmitContext.EmitMeta): New routine, in charge of emitting all the
8622 (EmitContext.TemporaryReturn): This method is typically called
8623 from the Emit phase, and its the only place where we allow the
8624 ReturnLabel to be defined other than the EmitMeta. The reason is
8625 that otherwise we would have to duplicate a lot of logic in the
8626 Resolve phases of various methods that today is on the Emit
8629 (EmitContext.NeedReturnLabel): This no longer creates the label,
8630 as the ILGenerator is not valid during the resolve phase.
8632 (EmitContext.EmitThis): Extended the knowledge in this class to
8633 work in anonymous methods in addition to iterators.
8635 (EmitContext.EmitCapturedVariableInstance): This emits whatever
8636 code is necessary on the stack to access the instance to a local
8637 variable (the variable will be accessed as a field).
8639 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
8640 EmitContext.EmitAddressOfParameter): Routines to support
8641 parameters (not completed at this point).
8643 Removals: Removed RemapLocal and RemapLocalLValue. We probably
8644 will also remove the parameters.
8646 * convert.cs (Convert): Define a `ConstantEC' which points to a
8647 null. This is just to prefity some code that uses
8648 ImplicitStandardConversion code and do not have an EmitContext
8651 The idea is to flag explicitly that at that point in time, it is
8652 known that the conversion will not trigger the delegate checking
8653 code in implicit conversions (which requires a valid
8656 Everywhere: pass new EmitContext parameter since
8657 ImplicitStandardConversionExists now requires it to check for
8658 anonymous method conversions.
8660 (Convert.ImplicitStandardConversionExists): If the type of an
8661 expression is the anonymous_method_type, and the type is a
8662 delegate, we invoke the AnonymousMethod.Compatible method to check
8663 whether an implicit conversion is possible.
8665 (Convert.ImplicitConversionStandard): Only do implicit method
8666 group conversions if the language level is not ISO_1.
8668 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
8669 MethodInfo for the Invoke method. used by Delegate and
8672 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
8673 method conversions if the target type is a delegate.
8675 Removed extra debugging nops.
8677 (LocalVariableReference): Turn the `local_info' into a public
8680 Add `prepared' field, the same hack used for FieldExprs to cope
8681 with composed assignments, as Local variables do not necessarily
8682 operate purely on the stack as they used to: they can be captured
8685 Add `temp' for a temporary result, like fields.
8687 Refactor DoResolve and DoResolveLValue into DoResolveBase.
8689 It now copes with Local variables that are captured and emits the
8690 proper instance variable to load it from a field in the captured
8693 (ParameterReference.DoResolveBase): During the resolve phase,
8694 capture parameters if we are in an anonymous method.
8696 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
8697 anonymous method, use the EmitContext helper routines to emit the
8698 parameter reference.
8700 * iterators.cs: Set RemapToProxy to true/false during the
8703 * parameters.cs (GetParameterByName): New helper method.
8705 * typemanager.cs (anonymous_method_type) a new type that
8706 represents an anonyous method. This is always an internal type,
8707 used as a fencepost to test against the anonymous-methodness of an
8710 2004-10-20 Marek Safar <marek.safar@seznam.cz>
8712 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
8714 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
8716 2004-11-10 Martin Baulig <martin@ximian.com>
8718 * expression.cs (Invocation.BetterFunction): If two methods have
8719 equal parameter types, but only one of them is generic, the
8720 non-generic one wins.
8721 (New.DoResolve): Don't set `is_struct' to false if we're a generic
8722 instance; just use `Type.IsValueType' to determine whether
8723 something is a struct or not.
8724 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
8725 so we can be called multiple times.
8727 2004-11-10 Martin Baulig <martin@ximian.com>
8729 * generic.cs (TypeParameter.DefineConstraints): New public method.
8730 (TypeParameter.CheckAccessLevel): Override this and return true.
8731 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
8732 override ResolveType() anymore.
8733 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
8735 2004-11-10 Martin Baulig <martin@ximian.com>
8737 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
8738 call DeclSpace.ResolveNestedType() on it.
8740 2004-11-10 Martin Baulig <martin@ximian.com>
8742 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
8743 non-null, call ParameterModifier() on it.
8745 2004-11-10 Martin Baulig <martin@ximian.com>
8748 (Iterators): Added `current_type' and `this_type' fields.
8749 (Iterators.DefineIterator): Create a new EmitContext and store it
8750 in `ec'; compute `this_type'.
8752 2004-11-10 Martin Baulig <martin@ximian.com>
8755 (TypeManager.IsPrivateAccessible): New public method.
8756 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
8758 2004-11-10 Martin Baulig <martin@ximian.com>
8760 * class.cs (TypeContainer.DefineType): Call
8761 TypeBuilder.DefineGenericParameters() before resolving the type
8763 (MethodData.parent_method): New protected field.
8764 (MethodData..ctor): Added `MethodInfo parent_method' argument.
8765 (MethodData.Define): Compute `parent_method'.
8768 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
8769 (MemberCore.GetClsCompliantAttributeValue): Likewise.
8770 (DeclSpace.ec): New protected field; store the EmitContext here.
8771 (DeclSpace.EmitContext): New public property.
8772 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
8773 (DeclSpace.ResolveNestedType): New public method.
8774 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
8775 (DeclSpace.NestedAccessible): Added `Type tb' argument.
8776 (DeclSpace.FamilyAccessible): Likewise.
8777 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
8778 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
8781 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
8784 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
8785 (Enum.Emit): Don't create a new EmitContext.
8787 2004-10-18 Martin Baulig <martin@ximian.com>
8789 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
8790 `Type' directly, but call ResolveType() on it.
8791 (Catch.Resolve): Likewise.
8792 (Foreach.Resolve): Likewise.
8794 2004-10-18 Martin Baulig <martin@ximian.com>
8796 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
8797 `Type' directly, but call ResolveType() on it.
8798 (Probe.DoResolve): Likewise.
8799 (ArrayCreation.LookupType): Likewise.
8800 (TypeOf.DoResolve): Likewise.
8801 (SizeOf.DoResolve): Likewise.
8803 2004-10-18 Raja R Harinath <rharinath@novell.com>
8805 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
8808 2004-10-17 John Luke <john.luke@gmail.com>
8810 * class.cs (Operator.GetSignatureForError): use CSharpName
8812 * parameter.cs (Parameter.GetSignatureForError): Returns
8813 correct name even if was not defined.
8815 2004-10-13 Raja R Harinath <rharinath@novell.com>
8818 * class.cs (TypeContainer.EmitContext): New property.
8819 (DefineNestedTypes): Create an emitcontext for each part.
8820 (MethodCore.DoDefineParameters): Use container's emitcontext.
8821 Pass type array to InternalParameters.
8822 (MemberBase.DoDefine): Use container's emitcontext.
8823 (FieldMember.Define): Likewise.
8824 (Event.Define): Likewise.
8825 (SetMethod.GetParameterInfo): Change argument to EmitContext.
8826 Pass type array to InternalParameters.
8827 (SetIndexerMethod.GetParameterInfo): Likewise.
8828 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
8829 * delegate.cs (Define): Pass emitcontext to
8830 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
8831 array to InternalParameters.
8832 * expression.cs (ParameterReference.DoResolveBase): Pass
8833 emitcontext to GetParameterInfo.
8834 (ComposedCast.DoResolveAsTypeStep): Remove check on
8835 ec.ResolvingTypeTree.
8836 * parameter.cs (Parameter.Resolve): Change argument to
8837 EmitContext. Use ResolveAsTypeTerminal.
8838 (Parameter.GetSignature): Change argument to EmitContext.
8839 (Parameters.ComputeSignature): Likewise.
8840 (Parameters.ComputeParameterTypes): Likewise.
8841 (Parameters.GetParameterInfo): Likewise.
8842 (Parameters.ComputeAndDefineParameterTypes): Likewise.
8843 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
8844 * support.cs (InternalParameters..ctor): Remove variant that takes
8846 * typemanager.cs (system_intptr_expr): New.
8847 (InitExpressionTypes): Initialize it.
8849 2004-10-12 Chris Toshok <toshok@ximian.com>
8851 * cs-parser.jay: fix location for try_statement and catch_clause.
8853 2004-10-18 Martin Baulig <martin@ximian.com>
8855 * class.cs (FieldMember.Define): Don't access the TypeExpr's
8856 `Type' directly, but call ResolveType() on it.
8857 (MemberBase.DoDefine): Likewise.
8859 * expression.cs (New.DoResolve): Don't access the TypeExpr's
8860 `Type' directly, but call ResolveType() on it.
8861 (ComposedCast.DoResolveAsTypeStep): Likewise.
8863 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
8864 `Type' directly, but call ResolveType() on it.
8866 2004-10-17 John Luke <john.luke@gmail.com>
8868 * class.cs (Operator.GetSignatureForError): use CSharpName
8870 * parameter.cs (Parameter.GetSignatureForError): Returns
8871 correct name even if was not defined.
8873 2004-10-13 Raja R Harinath <rharinath@novell.com>
8876 * class.cs (TypeContainer.EmitContext): New property.
8877 (DefineNestedTypes): Create an emitcontext for each part.
8878 (MethodCore.DoDefineParameters): Use container's emitcontext.
8879 Pass type array to InternalParameters.
8880 (MemberBase.DoDefine): Use container's emitcontext.
8881 (FieldMember.Define): Likewise.
8882 (Event.Define): Likewise.
8883 (SetMethod.GetParameterInfo): Change argument to EmitContext.
8884 Pass type array to InternalParameters.
8885 (SetIndexerMethod.GetParameterInfo): Likewise.
8886 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
8887 * delegate.cs (Define): Pass emitcontext to
8888 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
8889 array to InternalParameters.
8890 * expression.cs (ParameterReference.DoResolveBase): Pass
8891 emitcontext to GetParameterInfo.
8892 (ComposedCast.DoResolveAsTypeStep): Remove check on
8893 ec.ResolvingTypeTree.
8894 * parameter.cs (Parameter.Resolve): Change argument to
8895 EmitContext. Use ResolveAsTypeTerminal.
8896 (Parameter.GetSignature): Change argument to EmitContext.
8897 (Parameters.ComputeSignature): Likewise.
8898 (Parameters.ComputeParameterTypes): Likewise.
8899 (Parameters.GetParameterInfo): Likewise.
8900 (Parameters.ComputeAndDefineParameterTypes): Likewise.
8901 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
8902 * support.cs (InternalParameters..ctor): Remove variant that takes
8904 * typemanager.cs (system_intptr_expr): New.
8905 (InitExpressionTypes): Initialize it.
8907 2004-10-12 Chris Toshok <toshok@ximian.com>
8909 * cs-parser.jay: fix location for try_statement and catch_clause.
8911 2004-10-07 Raja R Harinath <rharinath@novell.com>
8913 More DeclSpace.ResolveType avoidance.
8914 * decl.cs (MemberCore.InUnsafe): New property.
8915 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
8916 with newly created EmitContext.
8917 (FieldMember.Define): Likewise.
8918 * delegate.cs (Delegate.Define): Likewise.
8919 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
8920 only if normal name-lookup fails.
8921 (TypeExpr.DoResolve): Enable error-checking.
8922 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
8923 (SizeOf.DoResolve): Likewise.
8924 (ComposedCast.DoResolveAsTypeStep): Likewise.
8925 (StackAlloc.DoResolve): Likewise.
8926 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
8927 (Block.Unsafe): New property.
8928 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
8929 (Unsafe): Set 'unsafe' flag of contained block.
8930 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
8931 (Fixed.Resolve): Likewise.
8932 (Catch.Resolve): Likewise.
8933 (Using.ResolveLocalVariableDecls): Likewise.
8934 (Foreach.Resolve): Likewise.
8936 2004-10-05 John Luke <john.luke@gmail.com>
8938 * cs-parser.jay: add location to error CS0175
8940 2004-10-04 Miguel de Icaza <miguel@ximian.com>
8942 * ecore.cs (Expression.Constantity): Add support for turning null
8945 * const.cs (Const.Define): Allow constants to be reference types
8946 as long as the value is Null.
8948 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
8950 * namespace.cs (NamespaceEntry.Using): No matter which warning
8951 level is set, check if this namespace name has already been added.
8953 2004-10-03 Ben Maurer <bmaurer@ximian.com>
8955 * expression.cs: reftype [!=]= null should always use br[true,false].
8958 2004-10-03 Marek Safar <marek.safar@seznam.cz>
8961 * attribute.cs: Enum conversion moved to
8962 GetAttributeArgumentExpression to be applied to the all
8965 2004-10-01 Raja R Harinath <rharinath@novell.com>
8967 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
8968 * class.c (TypeContainer.DefineType): Flag error if
8969 base types aren't accessible due to access permissions.
8970 * decl.cs (DeclSpace.ResolveType): Move logic to
8971 Expression.ResolveAsTypeTerminal.
8972 (DeclSpace.ResolveTypeExpr): Thin layer over
8973 Expression.ResolveAsTypeTerminal.
8974 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
8975 Refactor code into NestedAccess. Use it.
8976 (DeclSpace.NestedAccess): New.
8977 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
8978 argument to silence errors. Check access permissions.
8979 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
8980 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
8981 (Cast.DoResolve): Likewise.
8982 (New.DoResolve): Likewise.
8983 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
8984 (TypeOf.DoResolve): Likewise.
8986 * expression.cs (Invocation.BetterConversion): Return the Type of
8987 the better conversion. Implement section 14.4.2.3 more faithfully.
8988 (Invocation.BetterFunction): Make boolean. Make correspondence to
8989 section 14.4.2.2 explicit.
8990 (Invocation.OverloadResolve): Update.
8991 (Invocation): Remove is_base field.
8992 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
8993 (Invocation.Emit): Likewise.
8995 2004-09-24 Marek Safar <marek.safar@seznam.cz>
8997 * cs-parser.jay: Reverted 642 warning fix.
8999 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9002 * decl.cs (FindMemberWithSameName): Indexer can have more than
9005 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9007 * expression.cs (LocalVariableReference.DoResolveLValue):
9008 Do not report warning 219 for out values.
9009 (EmptyExpression.Null): New member to avoid extra allocations.
9011 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9013 * cs-parser.jay: Fix wrong warning 642 report.
9015 * cs-tokenizer.cs (CheckNextToken): New helper;
9016 Inspect next character if is same as expected.
9018 2004-09-23 Martin Baulig <martin@ximian.com>
9020 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9021 (Convert.ImplicitReferenceConversionExists): Likewise.
9023 2004-11-09 Raja R Harinath <rharinath@novell.com>
9025 * Makefile (DISTFILES): Comment out a few missing files.
9027 2004-10-29 Raja R Harinath <rharinath@novell.com>
9029 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9030 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9031 (gmcs.exe): Invoke bootstrap-libs.
9032 (clean-local): Clean the net_2_0_bootstrap profile too.
9033 (PROGRAM_INSTALL_DIR): New.
9034 (install-local): Use it.
9036 2004-10-13 Martin Baulig <martin@ximian.com>
9038 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9039 (TypeParameter.DefineType): If we're a method type parameter and
9040 that method is overriding something, "inflate" its constraints.
9042 2004-10-12 Martin Baulig <martin@ximian.com>
9044 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9045 and have type arguments, create and resolve a ConstructedType.
9047 2004-10-12 Martin Baulig <martin@ximian.com>
9049 * decl.cs (MemberCache.FindMemberToOverride): Use
9050 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9051 to compare the invocationType.
9053 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9054 When comparing two type parameters, only do the signature-only
9055 comparision for method type parameters.
9057 2004-10-11 Martin Baulig <martin@ximian.com>
9059 * report.cs: Don't make --fatal abort on warnings, we have
9060 -warnaserror for that.
9062 2004-10-11 Martin Baulig <martin@ximian.com>
9065 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9066 (TypeManager.IsEqual): Call ourself recursively instead of using
9069 2004-10-11 Martin Baulig <martin@ximian.com>
9071 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9072 on our own type parameters, not on the ones we inherit from a containing
9075 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9078 * generic.cs (TypeParameter.Define): We may only be called once.
9080 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9081 instead of TypeManager.IsEqual().
9083 2004-09-28 Martin Baulig <martin@ximian.com>
9086 (GenericConstraints.EffectiveBaseClass): New public property.
9087 (TypeParameter.GenericConstraints): New public property.
9088 (ConstructedType.CheckConstraints): Improved.
9090 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9091 (Convert.TypeParameterConversion): New private method; use this in
9092 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9093 for all conversions related to type parameters.
9095 2004-09-24 Martin Baulig <martin@ximian.com>
9097 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9098 type parameter conversions for type parameters which are known to
9101 2004-09-24 Martin Baulig <martin@ximian.com>
9103 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9104 `IsValueType' properties.
9106 * support.cs (ReflectionConstraints): Use
9107 Type.GetGenericParameterConstraints() instead of the old hack.
9109 2004-09-24 Martin Baulig <martin@ximian.com>
9111 * generic.cs (GenericConstraints): Moved here and made it an
9114 * support.cs (GenericConstraints): Moved to generic.cs.
9116 2004-09-24 Martin Baulig <martin@ximian.com>
9119 (ReflectionConstraints): Un-nested this class and made it public.
9122 (TypeManager.GetTypeParameterConstraints): New public method.
9123 (TypeManager.HasConstructorConstraint): Use the attributes.
9125 2004-09-24 Martin Baulig <martin@ximian.com>
9127 * support.cs (GenericConstraints): Replaced `HasConstructor',
9128 `IsReferenceType' and `IsValueType' with `Attributes'.
9129 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9130 method and made the .ctor public.
9132 * generic.cs (Constraints.Attributes): New public property.
9133 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9134 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9135 `IsValueType' -> `HasValueTypeConstraint'.
9137 2004-09-23 Martin Baulig <martin@ximian.com>
9139 * generic.cs (Constraints): Reflect latest runtime changes.
9141 2004-09-23 Martin Baulig <martin@ximian.com>
9143 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9144 (Convert.ImplicitReferenceConversionExists): Likewise.
9146 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9148 * class.cs (Operator.Define): Add error 448 and 559 report.
9150 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9152 * class.cs (MemberBase.IsTypePermitted): New protected
9153 method for checking error CS0610.
9155 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9157 * class.cs (TypeContainer.HasExplicitLayout): New property
9158 Returns whether container has StructLayout attribute set Explicit.
9159 (FieldMember): New abstract class for consts and fields.
9160 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9161 (Field): Reuse FieldMember.
9163 * const.cs (Const): Reuse FieldMember.
9165 * rootcontext.cs: EmitConstants call moved to class.
9167 2004-09-22 Martin Baulig <martin@ximian.com>
9169 Marek and me just fixed one of our oldest bugs: #28562 :-)
9171 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9173 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9174 we're an EnumConstant, just return that.
9175 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9176 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9177 to get the value which'll actually be written into the attribute.
9178 However, we have to use GetValue() to access the attribute's value
9181 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9183 * constant.cs (Constant.IsNegative): New abstract property
9186 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9187 (StackAlloc.DoResolve): Reused IsNegative.
9189 2004-09-22 Martin Baulig <martin@ximian.com>
9191 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9192 public method; like LookupTypeContainer, but also works for
9195 * report.cs (Report.SymbolRelatedToPreviousError): Use
9196 TypeManager.LookupGenericTypeContainer().
9198 2004-09-22 Martin Baulig <martin@ximian.com>
9200 Thanks to Peter Sestoft for this bug report.
9202 * expression.cs (Conditional): If both the `trueExpr' and the
9203 `falseExpr' is a NullLiteral, return a NullLiteral.
9205 2004-09-22 Martin Baulig <martin@ximian.com>
9207 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9208 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9209 for the "get_Current" call.
9211 2004-09-21 Martin Baulig <martin@ximian.com>
9213 * convert.cs (Convert.ImplicitReferenceConversion): When
9214 converting to an interface type, first check whether we're
9215 converting from a reference type.
9217 2004-09-14 Martin Baulig <martin@ximian.com>
9219 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9221 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9224 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9225 called and is obsolete then this member suppress message
9226 when call is inside next [Obsolete] method or type.
9228 * expression.cs: Use TestObsoleteMethodUsage member.
9230 2004-09-14 Martin Baulig <martin@ximian.com>
9232 * genericparser.cs: Removed.
9234 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9236 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9238 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9240 * attribute.cs (Attribute.Resolve): Add error 653 report.
9242 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9244 (Method.ApplyAttributeBuilder): Add error 685 report.
9245 (Operator.Define): Add error 564 report.
9247 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9249 * expression.cs (Invocation.DoResolve): Add error
9252 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9255 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9257 * class.cs (ConstructorInitializer.Resolve):
9258 Wrong error number (515->516).
9260 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9262 * class.cs (Indexer.Define): Add error 631 report.
9264 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9266 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9268 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9270 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9272 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9274 * cs-parser.jay: Added error CS0241 report.
9276 2004-09-10 Raja R Harinath <rharinath@novell.com>
9278 * cs-parser.jay (fixed_statement): Introduce a scope for the
9279 declaration in the 'fixed' statement.
9281 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9283 * cs-parser.jay: Added CS0230 error report.
9285 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9287 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9289 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9291 * expression.cs (Argument.Resolve): Added error CS0192 and
9294 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9296 C# 2.0 #pragma warning feature
9298 * cs-tokenizer.cs (PreProcessPragma): New method;
9299 Handles #pragma directive.
9301 * report.cs (WarningRegions): New class; Support
9302 class for #pragma warning directive. It tests whether
9303 warning is enabled for a given line.
9305 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9307 * const.cs: Add more descriptive error report, tahnks to
9310 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9312 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9314 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9316 * expression.cs: Apply patch from Ben: Remove dead code from
9317 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9318 as that code just threw an exception anwyays.
9320 * const.cs: Remove the call to the turnintoconstant, for details
9323 * literal.cs: The type of the null-literal is the null type; So
9324 we use a placeholder type (literal.cs:System.Null, defined here)
9327 * expression.cs (Conditional.DoResolve): Remove some old code that
9328 is no longer needed, conversions have been fixed.
9330 (ArrayCreationExpression.DoResolve): Return false if we fail to
9331 resolve the inner expression.
9333 2004-09-07 Raja R Harinath <rharinath@novell.com>
9336 * cs-parser.jay (delegate_declaration): Record a delegate
9337 declaration as a type declaration.
9338 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9340 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9342 * parameter.cs: Do not crash if the type can not be resolved.
9344 * expression.cs: Report errors with unsafe pointers, fixes #64896
9346 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9348 * expression.cs: Pointer arith always needs to do a conv.i
9349 if the operand is a long. fix 65320
9351 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9353 Fixed cs0619-37.cs, cs0619-38.cs
9355 * enum.cs (GetObsoleteAttribute): Removed.
9357 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9358 on Enum member is double staged. The first is tested member
9361 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9363 Fixed #56986, #63631, #65231
9365 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9366 adds member to name container.
9367 (TypeContainer.AddToTypeContainer): New method, adds type to
9369 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9370 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9371 AddOperator): Simplified by reusing AddToMemberContainer.
9372 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9374 (Method.CheckForDuplications): Fixed implementation to test all
9376 (MemberBase): Detection whether member is explicit interface
9377 implementation is now in constructor.
9378 (MemberBase.UpdateMemberName): Handles IndexerName.
9379 (Accessor): Changed to keep also location information.
9380 (AbstractPropertyEventMethod): Is derived from MemberCore.
9381 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9382 will be emited or not.
9383 (PropertyBase.AreAccessorsDuplicateImplementation):
9384 Tests whether accessors are not in collision with some method.
9385 (Operator): Is derived from MethodCore to simplify common
9388 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9390 (DeclSpace.AddToContainer): Adds the member to defined_names
9391 table. It tests for duplications and enclosing name conflicts.
9393 * enum.cs (EnumMember): Clean up to reuse the base structures
9395 2004-09-03 Martin Baulig <martin@ximian.com>
9397 Merged latest changes into gmcs. Please keep this comment in
9398 here, it makes it easier for me to see what changed in MCS since
9399 the last time I merged.
9401 2004-09-03 Martin Baulig <martin@ximian.com>
9403 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9404 into TypeContainer, to make partial classes work again.
9406 2004-09-03 Martin Baulig <martin@ximian.com>
9408 * rootcontext.cs (RootContext.V2): Removed.
9410 2004-03-23 Martin Baulig <martin@ximian.com>
9412 * expression.cs (Invocation.OverloadResolve): Added `bool
9413 may_fail' argument and use it instead of the Location.IsNull() hack.
9415 2004-09-09 Martin Baulig <martin@ximian.com>
9417 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9419 2004-09-09 Martin Baulig <martin@ximian.com>
9421 * generic.cs (TypeParameter.DefineType): Added support for
9422 explicit interface methods.
9424 2004-09-09 Martin Baulig <martin@ximian.com>
9426 * README.Changes: New document. Started to list important changes
9427 between MCS and GMCS here.
9429 2004-09-08 Martin Baulig <martin@ximian.com>
9432 (TypeContainer.CheckRecursiveDefinition): New protected method.
9433 (TypeContainer.DefineType): Move the CS0146 check into
9434 CheckRecursiveDefinition().
9436 2004-09-06 Martin Baulig <martin@ximian.com>
9438 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9439 types for the constructor constraint.
9441 2004-09-03 Martin Baulig <martin@ximian.com>
9443 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9444 into TypeContainer, to make partial classes work again.
9446 2004-09-03 Martin Baulig <martin@ximian.com>
9448 * rootcontext.cs (RootContext.V2): Removed.
9450 2004-03-23 Martin Baulig <martin@ximian.com>
9452 * expression.cs (Invocation.OverloadResolve): Added `bool
9453 may_fail' argument and use it instead of the Location.IsNull() hack.
9455 2004-09-03 Martin Baulig <martin@ximian.com>
9457 Merged latest changes into gmcs. Please keep this comment in
9458 here, it makes it easier for me to see what changed in MCS since
9459 the last time I merged.
9461 2004-09-03 Raja R Harinath <rharinath@novell.com>
9464 * expression.cs (BetterConversion): Don't allow either conversion
9465 to be null. Remove redundant implicit conversion test when 'q ==
9466 null' -- when this function is invoked, we already know that the
9467 implicit conversion exists.
9468 (BetterFunction): Assume that 'best' is non-null. Remove
9469 redundant reimplementation of IsApplicable when 'best' is null.
9470 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9471 number of arguments.
9472 (IsAncestralType): Extract from OverloadResolve.
9473 (OverloadResolve): Make robust to the MethodGroupExpr being
9474 unsorted. Implement all the logic of Section 14.5.5.1, and
9475 support overloading of methods from multiple applicable types.
9476 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9478 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9479 (RealError, Warning): Append type of report to related symbol.
9481 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9483 * enum.cs: Fixed CLS-Compliance checks for enum members.
9484 Error tests cs3008-8.cs, cs3014-8.cs
9486 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9488 Fixed bug #62342, #63102
9489 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9490 like ImplementMethod.
9492 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9494 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9497 2004-09-02 Martin Baulig <martin@ximian.com>
9499 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9500 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9503 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9505 C# 2.0 Static classes implemented
9507 * class.cs (TypeContainer): instance_constructors,
9508 initialized_fields, initialized_static_fields,
9509 default_constructor, base_inteface_types are protected to be
9510 accessible from StaticClass.
9511 (TypeContainer.DefineDefaultConstructor): New virtual method
9512 for custom default constructor generating
9513 (StaticClass): New class to handle "Static classes" feature.
9515 * cs-parser.jay: Handle static keyword on class like instance
9518 * driver.cs: Added "/langversion" command line switch with two
9519 options (iso-1, default).
9521 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9523 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9525 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9527 * delegate.cs: Style.
9529 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9531 * delegate.cs: Add seperate instance expr field for miguel.
9533 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9535 * PointerArithmetic (Resolve): make sure we are not doing
9536 pointer arith on void*. Also, make sure we are resolved
9537 by not setting eclass until resolve.
9539 All callers: Make sure that PointerArithmetic gets resolved.
9541 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9543 * ArrayCreation (LookupType): If the type does not resolve
9544 to an array, give an error.
9546 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9548 * statement.cs (Try.Resolve): Fixed bug #64222
9550 2004-08-27 Martin Baulig <martin@ximian.com>
9553 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9556 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9558 * ecore.cs (Constantify): Get underlying type via
9559 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9560 Windows in special cases.
9562 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9564 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9565 for obtaining also private methods.
9566 (GetRemoveMethod): Used GetRemoveMethod (true)
9567 for obtaining also private methods.
9569 2004-09-02 Martin Baulig <martin@ximian.com>
9571 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9572 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9575 2004-08-27 Martin Baulig <martin@ximian.com>
9578 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9581 2004-08-25 Martin Baulig <martin@ximian.com>
9583 * support.cs (ReflectionParameters..ctor): If this is a generic
9584 method, retrieve and store its type parameters.
9585 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9586 (ReflectionParameters.GenericConstraints): The argument specifies
9587 the type parameter, not the method parameter.
9588 (InternalParameters.GenericConstraints): Likewise.
9590 * generic.cs (TypeParameter.DefineType): Correctly handle
9591 constraints wrt. generic methods in interfaces and their
9594 2004-08-24 Martin Baulig <martin@ximian.com>
9596 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9597 (Constraints.IsSubclassOf): New internal method.
9599 * typemanager.cs (TypeManager.FindMembers): Added special support
9600 for GenericTypeParameterBuilder's.
9601 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
9604 2004-08-24 Martin Baulig <martin@ximian.com>
9607 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
9608 this for accessibility checks.
9609 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
9610 IsNestedFamilyAccessible.
9611 (TypeManager.IsSubclassOf): New method, do what the name actually
9614 2004-08-24 Martin Baulig <martin@ximian.com>
9616 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
9617 as a SimpleName, include the generic arity.
9619 2004-08-24 Martin Baulig <martin@ximian.com>
9621 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
9622 MethodAttributes.HideBySig for operators.
9624 2004-08-23 Martin Baulig <martin@ximian.com>
9626 Back to the old error reporting system :-)
9628 * report.cs (Message): Removed.
9629 (Report.MessageData, ErrorData, WarningData): Removed.
9630 (Report.Error, Warning): Back to the old system.
9632 2004-08-23 Martin Baulig <martin@ximian.com>
9634 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
9636 * class.cs (TypeContainer.ParentContainer): New public virtual
9637 method; replaces the explicit interface implementation.
9638 (ClassPart.ParentContainer): Override.
9640 2004-08-23 Martin Baulig <martin@ximian.com>
9642 * statement.cs (Switch): Added support for constant switches; see
9643 #59428 or test-285.cs.
9645 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9648 * statement.cs (GetEnumeratorFilter): Removed useless
9649 logic because C# specs is strict. GetEnumerator must be
9652 2004-08-22 Martin Baulig <martin@ximian.com>
9654 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9655 a switch and may break, reset the barrier. Fixes #59867.
9657 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9659 CLS-Compliance speed up (~5% for corlib)
9661 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
9662 New method. Tests container for CLS-Compliant names
9664 * class.cs (TypeContainer.VerifyClsName): New method.
9665 Checks whether container name is CLS Compliant.
9666 (Constructor): Implements IMethodData.
9668 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
9669 low-case table for CLS Compliance test.
9670 (MemberCache.VerifyClsParameterConflict): New method.
9671 Checks method parameters for CS3006 error.
9673 * enum.cs (EnumMember): Is derived from MemberCore.
9674 (Enum.VerifyClsName): Optimized for better performance.
9676 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9678 * report.cs: Renamed Error_T to Error and changed all
9681 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9683 * class.cs (TypeContainer.IndexerArrayList): New inner class
9684 container for indexers.
9685 (TypeContainer.DefaultIndexerName): New constant for default
9686 indexer name. Replaced all "Item" with this constant.
9687 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
9689 * typemanager.cs (TypeManager.default_member_ctor): Cache here
9690 DefaultMemberAttribute constructor.
9692 2004-08-05 Martin Baulig <martin@ximian.com>
9694 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9697 2004-08-05 Marek Safar <marek.safar@seznam.cz>
9699 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
9700 multi platforms problem.
9702 * compiler.csproj: Included shared files.
9704 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9706 Fix bug 60333, 55971 in the more general way
9707 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9708 Added arg_type argument for constant conversion.
9709 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
9711 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9714 * class.cs (TypeContainer ): New inner classes MethodArrayList,
9715 OperatorArrayList, MethodCoreArrayList for typecontainer
9716 containers. Changed class member types to these new types.
9717 (MethodArrayList.DefineMembers): Added test for CS0659.
9719 2004-08-04 Miguel de Icaza <miguel@ximian.com>
9721 * cfold.cs: Synchronize the folding with the code in expression.cs
9722 Binary.DoNumericPromotions for uint operands.
9724 * attribute.cs: Revert patch from Raja, it introduced a regression
9725 while building Blam-1.2.1 (hard to isolate a test case).
9727 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9731 (TypeContainer.Define): Renamed to DefineContainerMembers because of
9733 (MethodCore.parent_method): New member. The method we're overriding
9734 if this is an override method.
9735 (MethodCore.CheckBase): Moved from Method class and made common.
9736 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
9738 (MethodCore.CheckForDuplications): New abstract method. For custom
9739 member duplication search in a container
9740 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
9741 method and its return type.
9742 (Event.conflict_symbol): New member. Symbol with same name in the
9746 (MemberCache.FindMemberWithSameName): New method. The method
9747 is looking for conflict with inherited symbols.
9749 2004-08-04 Martin Baulig <martin@ximian.com>
9751 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9753 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9755 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9757 * report.cs (Message): New enum for better error, warning reference in
9759 (MessageData): New inner abstract class. It generally handles printing of
9760 error and warning messages.
9761 Removed unused Error, Warning, Message methods.
9763 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9765 Fix for cs0592-8.cs test
9767 (Attributable.ValidAttributeTargets): Made public.
9768 (Attribute.ExplicitTarget): New member for explicit target value.
9769 (Attribute.CheckTargets): Now we translate explicit attribute
9770 target to Target here.
9772 2004-08-03 Ben Maurer <bmaurer@ximian.com>
9774 * ecore.cs (MethodGroupExpr): new IsBase property.
9776 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
9778 * delegate.cs (DelegateCreation): store a MethodGroupExpr
9779 rather than an instance expr.
9781 (DelegateCreation.Emit): Use the method group rather than
9782 the instance expression. Also, if you have base.Foo as the
9783 method for a delegate, make sure to emit ldftn, not ldftnvirt.
9785 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
9787 (NewDelegate.DoResolve): Only check for the existance of Invoke
9788 if the method is going to be needed. Use MethodGroupExpr.
9790 (NewDelegate.Emit): Remove, DelegateCreation implements this.
9792 * expression.cs: For pointer arith., make sure to use
9793 the size of the type, not the size of the pointer to
9796 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9799 * class.cs (Class): Added error CS0502 test.
9801 2004-08-03 John Luke <jluke@cfl.rr.com>
9802 Raja R Harinath <rharinath@novell.com>
9805 * attribute.cs (Attribute.complained_before): New flag.
9806 (Attribute.ResolveType, Attribute.Resolve),
9807 (Attribute.DefinePInvokeMethod): Set it.
9808 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
9810 2004-08-03 Martin Baulig <martin@ximian.com>
9812 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
9813 use a user-defined operator; we still need to do numeric
9814 promotions in case one argument is a builtin type and the other
9815 one has an implicit conversion to that type. Fixes #62322.
9817 2004-08-18 Martin Baulig <martin@ximian.com>
9819 * class.cs (Method.Define): Use the correct method name when
9820 creating the MethodBuilder for a generic method.
9822 2004-08-17 Martin Baulig <martin@ximian.com>
9824 * generic.cs (Constraints): Support type parameter constraints.
9826 2004-08-16 Martin Baulig <martin@ximian.com>
9828 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
9829 (Token.GENERIC_DIMENSION): New token; this is returned if we
9830 encounter an unbound generic type in a typeof() expression.
9832 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
9833 this token is only generated while parsing a typeof() expression.
9834 (typeof_expression): Removed the old unbound_type hack.
9836 * generic.cs (TypeArguments.IsUnbound): New public property.
9838 * decl.cs (MemberName): Added support for unbound types.
9840 2004-08-14 Martin Baulig <martin@ximian.com>
9843 (TypeManager.IsEqualGenericInstance): New static method.
9844 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
9845 just used to check accessibility, so follow the rules of 26.1.6.
9847 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
9848 ConstructedType instead of a TypeExpression if we have type arguments.
9850 * cs-parser.jay (typeof_expression): Support unbound generic types.
9852 * ecore.cs (UnboundTypeExpression): New public class.
9854 2004-08-12 Martin Baulig <martin@ximian.com>
9856 * typemanager.cs (TypeManager.IsNestedChildOf): Use
9857 TypeManager.IsEqual() rather than `=='.
9859 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
9860 generic instances as well.
9862 2004-08-12 Martin Baulig <martin@ximian.com>
9864 * expression.cs (Invocation.InferType): We can only infer method
9865 type parameters. Fixes #62647.
9867 2004-08-11 Martin Baulig <martin@ximian.com>
9869 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
9870 before resolving the base classes.
9872 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9874 * Makefile: install .mdb file too.
9876 2004-08-05 Martin Baulig <martin@ximian.com>
9878 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
9879 initializer, the current type is just the TypeBuilder, not the
9880 instantiated generic type.
9881 (FieldExpr.IsFieldInitializer): New public property.
9883 2004-08-04 Martin Baulig <martin@ximian.com>
9885 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9887 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9889 2004-08-03 Martin Baulig <martin@ximian.com>
9891 * class.cs (MethodData.Define): If we're an explicit
9892 implementation, remove the generic arity from the type name.
9894 2004-08-03 Martin Baulig <martin@ximian.com>
9896 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
9897 use a user-defined operator; we still need to do numeric
9898 promotions in case one argument is a builtin type and the other
9899 one has an implicit conversion to that type. Fixes #62322.
9901 2004-08-02 Martin Baulig <martin@ximian.com>
9903 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
9905 (TypeContainer.GetClassBases): Return the unexpanded list of
9906 interfaces; we expand them later.
9907 (TypeContainer.DefineType): After creating the TypeBuilder, call
9908 TypeManager.ExpandInterfaces() to get an expanded and resolved
9911 * ecore.cs (TypeExpr.GetInterfaces): Removed
9913 * generics.cs (Constraints.InterfaceConstraints): Remove.
9914 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
9915 register the interface constraints.
9918 (TypeManager.AddUserType): Removed the `ifaces' argument.
9919 (TypeManager.AddTypeParameter): Likewise.
9920 (TypeManager.AddUserInterface): Removed, was unused.
9921 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
9922 `TypeExpr[]' array for the interfaces.
9923 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
9924 has been defined, returns a list of the resolved interfaces types.
9925 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
9926 (TypeManager.GetExplicitInterfaces): Likewise.
9928 2004-08-02 Martin Baulig <martin@ximian.com>
9930 * expression.cs (Invocation.EmitCall): If we're invoking a method
9931 on a type parameter, use the new `Constrained' prefix opcode.
9933 2004-08-02 Martin Baulig <martin@ximian.com>
9935 * statement.cs (LocalInfo.Flags): Added `IsThis'.
9936 (LocalInfo.IsThis): New public property.
9937 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
9939 2004-08-01 Martin Baulig <martin@ximian.com>
9941 * class.cs (TypeContainer.GetClassBases): Don't set the default
9942 here since we may get called from GetPartialBases().
9943 (TypeContainer.DefineType): If GetClassBases() didn't return a
9944 parent, use the default one.
9946 2004-07-30 Martin Baulig <martin@ximian.com>
9948 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
9950 * class.cs (SourceMethod): New public class, derive from the
9951 symbol writer's ISourceMethod.
9952 (Method): Use the new symbol writer API.
9954 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
9955 as argument and use the new symbol writer.
9958 (SourceFile): Implement the symbol writer's ISourceFile.
9959 (Location.SymbolDocument): Removed.
9960 (Location.SourceFile): New public property.
9962 * symbolwriter.cs: Use the new symbol writer API.
9964 2004-07-30 Raja R Harinath <rharinath@novell.com>
9966 * Makefile (install-local): Remove. Functionality moved to
9969 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
9971 * Makefile: Install mcs.exe.config file together with mcs.exe.
9972 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
9973 correct runtime version.
9975 2004-07-25 Martin Baulig <martin@ximian.com>
9978 (TypeContainer.RegisterOrder): Removed, this was unused.
9979 (TypeContainer, interface_order): Removed.
9980 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
9981 TypeContainer as argument since we can also be called with a
9982 `PartialContainer' for a partial class/struct/interface.
9983 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
9984 of checking whether we're an `Interface' - we could be a
9986 (PartialContainer.Register): Override; call
9987 AddClass()/AddStruct()/AddInterface() on our parent.
9989 * cs-parser.jay (interface_member_declaration): Add things to the
9990 `current_container', not the `current_class'.
9992 * rootcontext.cs (RegisterOrder): The overloaded version which
9993 takes an `Interface' was unused, removed.
9995 * typemanager.cs (TypeManager.LookupInterface): Return a
9996 `TypeContainer', not an `Interface'.
9997 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
9998 contain a `PartialContainer' for an interface, so check it's
9999 `Kind' to figure out what it is.
10001 2004-07-25 Martin Baulig <martin@ximian.com>
10003 * class.cs (Class.DefaultTypeAttributes): New public constant.
10004 (Struct.DefaultTypeAttributes): Likewise.
10005 (Interface.DefaultTypeAttributes): Likewise.
10006 (PartialContainer.TypeAttr): Override this and add the
10007 DefaultTypeAttributes.
10009 2004-07-25 Martin Baulig <martin@ximian.com>
10011 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10012 we can just use the `Parent' field instead.
10014 2004-07-25 Martin Baulig <martin@ximian.com>
10016 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10018 2004-07-25 Martin Baulig <martin@ximian.com>
10020 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10021 our parts before defining any methods.
10022 (TypeContainer.VerifyImplements): Make this virtual.
10023 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10024 on our PartialContainer.
10026 2004-07-25 Martin Baulig <martin@ximian.com>
10028 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10030 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10031 argument, we can just use the `Parent' field instead.
10034 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10035 (MemberBase.DoDefine): Likewise.
10037 2004-07-24 Martin Baulig <martin@ximian.com>
10039 * decl.cs (MemberCore.Parent): New public field.
10040 (DeclSpace.Parent): Moved to MemberCore.
10042 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10043 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10045 (FieldBase, Field, Operator): Likewise.
10046 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10047 (EventField, Event): Likewise.
10049 2004-07-23 Martin Baulig <martin@ximian.com>
10051 * class.cs (PartialContainer): New public class.
10052 (ClassPart): New public class.
10053 (TypeContainer): Added support for partial classes.
10054 (TypeContainer.GetClassBases): Splitted some of the functionality
10055 out into GetNormalBases() and GetPartialBases().
10057 * cs-tokenizer.cs (Token.PARTIAL): New token.
10058 (Tokenizer.consume_identifier): Added some hacks to recognize
10059 `partial', but only if it's immediately followed by `class',
10060 `struct' or `interface'.
10062 * cs-parser.jay: Added support for partial clases.
10064 2004-07-23 Martin Baulig <martin@ximian.com>
10066 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10067 a `DeclSpace' and also made it readonly.
10068 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10069 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10070 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10072 * cs-parser.jay: Pass the `current_class', not the
10073 `current_container' (at the moment, this is still the same thing)
10074 to a new Method, Property, Event, Indexer or Constructor.
10076 2004-07-23 Martin Baulig <martin@ximian.com>
10078 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10079 and removed the `current_interface' one.
10080 (struct_declaration, class_declaration, interface_declaration):
10081 Set `current_class' to the newly created class/struct/interface;
10082 set their `Bases' and call Register() before parsing their body.
10084 2004-07-23 Martin Baulig <martin@ximian.com>
10086 * class.cs (Kind): New public enum.
10087 (TypeContainer): Made this class abstract.
10088 (TypeContainer.Kind): New public readonly field.
10089 (TypeContainer.CheckDef): New public method; moved here from
10091 (TypeContainer.Register): New public abstract method.
10092 (TypeContainer.GetPendingImplementations): New public abstract
10094 (TypeContainer.GetClassBases): Removed the `is_class' and
10095 `is_iface' parameters.
10096 (TypeContainer.DefineNestedTypes): Formerly known as
10098 (ClassOrStruct): Made this class abstract.
10100 * tree.cs (RootTypes): New public type.
10102 2004-07-20 Martin Baulig <martin@ximian.com>
10104 * tree.cs (Tree.RecordNamespace): Removed.
10105 (Tree.Namespaces): Removed.
10107 * rootcontext.cs (RootContext.IsNamespace): Removed.
10109 * cs-parser.jay (namespace_declaration): Just create a new
10110 NamespaceEntry here.
10112 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10114 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10115 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10116 entry to make sure it runs in the correct runtime version.
10118 2004-07-18 Martin Baulig <martin@ximian.com>
10120 * generic.cs (ConstructedType.CheckConstraints): Improved
10121 constraints checking.
10123 2004-07-18 Martin Baulig <martin@ximian.com>
10125 * expression.cs (Invocation.BetterMethod): Call
10126 TypeManager.TypeToCoreType() on all types and removed my previous
10127 hack; we're already doig the right thing here.
10129 2004-07-17 Martin Baulig <martin@ximian.com>
10131 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10133 2004-07-16 Martin Baulig <martin@ximian.com>
10135 * iterators.cs: Added generics support.
10137 2004-07-16 Martin Baulig <martin@ximian.com>
10139 * iterators.cs: Rewrote this. We're now using one single Proxy
10140 class for both the IEnumerable and the IEnumerator interface and
10141 `Iterator' derives from Class so we can use the high-level API.
10143 * class.cs (TypeContainer.AddIterator): New method.
10144 (TypeContainer.DoDefineType): New protected virtual method, which
10145 is called from DefineType().
10146 (TypeContainer.DoDefineMembers): Call DefineType() and
10147 DefineMembers() on all our iterators.
10148 (TypeContainer.Emit): Call Emit() on all our iterators.
10149 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10151 * codegen.cs (EmitContext.CurrentIterator): New public field.
10153 2004-07-15 Martin Baulig <martin@ximian.com>
10156 (TypeManager.not_supported_exception_type): New type.
10158 2004-07-14 Martin Baulig <martin@ximian.com>
10161 (TypeManager.generic_ienumerable_type): New type.
10162 (TypeManager.generic_ienumerator_type): New type.
10165 (RootContext.interfaces_first_stage): Added
10166 "System.Collections.Generic.IEnumerator`1" and
10167 "System.Collections.Generic.IEnumerable`1".
10169 2004-07-14 Martin Baulig <martin@ximian.com>
10171 * iterators.cs: Use real error numbers.
10173 2004-07-14 Martin Baulig <martin@ximian.com>
10175 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10176 requires this to be a System.Collection.IEnumerable and not a
10177 class implementing that interface.
10178 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10180 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10182 * class.cs: Fixed previous fix, it broke some error tests.
10184 2004-07-12 Martin Baulig <martin@ximian.com>
10186 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10189 2004-07-14 Martin Baulig <martin@ximian.com>
10191 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10192 an exclamation mark (!) for the generic arity to reflect the
10193 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10195 2004-07-13 Martin Baulig <martin@ximian.com>
10197 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10198 specifiers being part of a type argument.
10200 2004-07-13 Martin Baulig <martin@ximian.com>
10202 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10203 name for generic types.
10205 2004-07-13 Martin Baulig <martin@ximian.com>
10207 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10210 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10212 * assign.cs (LocalTemporary): Add new argument: is_address,If
10213 `is_address' is true, then the value that we store is the address
10214 to the real value, and not the value itself.
10216 * ecore.cs (PropertyExpr): use the new local temporary
10217 stuff to allow us to handle X.Y += z (where X is a struct)
10219 2004-07-08 Martin Baulig <martin@ximian.com>
10221 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10222 not always return, just like we're doing in Using.Resolve().
10224 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10226 * cs-parser.jay (fixed_statement): flag this as Pinned.
10228 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10230 * typemanager.cs (TypeManager): Removed MakePinned method, this
10231 mechanism is replaced with the .NET 2.x compatible mechanism of
10232 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10234 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10235 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10236 `IsFixed' property which has a different meaning.
10238 2004-07-02 Raja R Harinath <rharinath@novell.com>
10240 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10241 visible from inside a nested class, not just the names of the
10242 immediately enclosing class.
10243 Fix for bug #60730.
10245 2004-06-24 Raja R Harinath <rharinath@novell.com>
10247 * expression.cs (BetterConversion): Remove buggy special-case
10248 handling of "implicit constant expression conversions". At this
10249 point, we already know that the conversion is possible -- we're
10250 only checking to see which is better.
10252 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10254 * cs-parser.jay: Added error CS0210 test.
10256 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10258 * cs-parser.jay: Added error CS0134 test.
10260 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10263 * cs-parser.jay: Added error CS0145 test.
10265 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10267 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10269 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10271 * expression.cs (StackAlloc.Resolve): The argument may not
10272 be a constant; deal with this case.
10274 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10276 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10277 GetIndexerAttributeValue.
10278 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10280 * class.cs (Indexer.Define): Added error tests for CS0415,
10283 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10285 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10288 2004-06-23 Martin Baulig <martin@ximian.com>
10290 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10291 neither return nor throw, reset the barrier as well. Fixes #60457.
10293 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10295 * class.cs : EventAttributes is now set to None by default.
10296 This fixes bug #60459.
10298 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10301 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10302 Don't throw exception but return null (it's sufficient now).
10304 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10306 * typemanager.cs (GetArgumentTypes): Faster implementation.
10308 2004-06-18 Martin Baulig <martin@ximian.com>
10310 * attribute.cs (Attribute.Resolve): Check whether we're an
10311 EmptyCast which a Constant child. Fixes #60333.
10313 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10315 * statement.cs (EmitCollectionForeach): Account for the fact that
10316 not all valuetypes are in areas which we can take the address of.
10317 For these variables, we store to a temporary variable. Also, make
10318 sure that we dont emit a `callvirt' on a valuetype method.
10320 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10322 * expression.cs (StackAlloc.DoReSolve): Added test for
10323 negative parameter (CS0247).
10325 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10328 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10330 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10333 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10336 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10338 Fix bug #58254 & cs1555.cs, cs1556.cs
10339 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10341 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10343 * cs-parser.jay: Added error CS1669 test for indexers.
10345 2004-06-18 Martin Baulig <martin@ximian.com>
10347 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10348 argument. Fixes #60441.
10350 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10351 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10352 The name needs to have the actual name of the method in order
10353 for other tests (such as the one in OverloadResolve for Invoke
10354 on a delegate) to work. As well, it does not really help
10355 error reporting because the method group had multiple methods.
10356 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10357 Make profiling work.
10359 2004-06-13 Martin Baulig <martin@ximian.com>
10361 * cs-parser.jay: Don't allow generic attributes.
10363 2004-06-13 Martin Baulig <martin@ximian.com>
10365 * class.cs (MemberBase.DoDefineBase): New protected method.
10366 (MemberBase.DoDefine): Compute the `flags' in the new
10367 DoDefineBase() which must be called first.
10368 (Method.Define): Call DoDefineBase() first so we have the flags
10369 when defining the generic method.
10371 * cs-parser.jay (interface_method_declaration): Support generic methods.
10373 2004-06-13 Martin Baulig <martin@ximian.com>
10375 * decl.cs (TypeName): Removed.
10376 (MemberName): Removed TypeName and MemberNow; now we just have
10379 * cs-parser.jay: Don't distinguish between type arguments and type
10380 parameters in the grammar and simplified the rules a bit. The
10381 reduce/reduce conflicts are now gone (except the one we inherited
10384 2004-06-11 Martin Baulig <martin@ximian.com>
10386 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10387 call this twice: for params and varargs methods.
10389 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10392 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10394 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10396 * attribute.cs (Attribute.GetValidTargets): Made public.
10399 (AbstractPropertyEventMethod): New class for better code sharing.
10400 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10402 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10404 2004-06-09 Martin Baulig <martin@ximian.com>
10406 * cs-parser.jay: Removed a reduce/reduce conflict.
10408 2004-06-03 Martin Baulig <martin@ximian.com>
10410 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10411 GetSimpleName() and return a SimpleName.
10413 * ecore.cs (SimpleName.Arguments): New public field.
10414 (SimpleName): Added overloaded ctor which takes an additional
10415 TypeArguments argument.
10416 (SimpleName.SimpleNameResolve): Added support for generic methods.
10417 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10418 formerly in MemberAccess.DoResolve(), but we also need it in
10419 SimpleNameResolve().
10421 * expression.cs (MemberAccess.DoResolve): Use the new
10422 MethodGroupExpr.ResolveGeneric().
10424 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10426 * decl.cs: If possible, use lookuptypedirect here. We can only do
10427 this if there is no `.' after the namespace. Avoids using
10428 LookupType, which does lots of slow processing.
10429 (FindNestedType) New method, does what it says :-).
10430 * namespace.cs: use LookupTypeDirect.
10431 * rootcontext.cs: use membercache, if possible.
10432 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10434 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10437 According to the spec,
10439 In a member access of the form E.I, if E is a single identifier,
10440 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10441 field, property, localvariable, or parameter with the same type as
10442 the meaning of E as a type-name (§3.8), then both possible
10443 meanings of E are permitted.
10445 We did not check that E as a simple-name had the same type as E as
10448 This trivial check gives us 5-7% on bootstrap time.
10450 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10452 * expression.cs (Invocation.OverloadResolve): Avoid the
10453 use of hashtables and boxing here by allocating on demand.
10455 2004-05-30 Martin Baulig <martin@ximian.com>
10457 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10458 we're doing a silent lookup. Don't try to lookup nested types in
10459 TypeManager.object_type (thanks to Ben Maurer).
10461 2004-05-30 Martin Baulig <martin@ximian.com>
10463 Committing a patch from Ben Maurer.
10465 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10467 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10469 * convert.cs: add a trivial cache for overload operator resolution.
10471 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10474 (AttributeTester.GetObsoleteAttribute): Returns instance of
10475 ObsoleteAttribute when type is obsolete.
10478 (TypeContainer.VerifyObsoleteAttribute): Override.
10479 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10480 (MethodCode.VerifyObsoleteAttribute): Override.
10481 (MemberBase.VerifyObsoleteAttribute): Override.
10484 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10485 and report proper error.
10488 (Delegate.VerifyObsoleteAttribute): Override.
10491 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10492 and report proper error.
10493 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10496 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10500 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10501 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10502 Added test for ObsoleteAttribute.
10505 (Catch): Derived from Statement.
10507 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10509 * decl.cs: If possible, use lookuptypedirect here. We can only do
10510 this if there is no `.' after the namespace. Avoids using
10511 LookupType, which does lots of slow processing.
10512 (FindNestedType) New method, does what it says :-).
10513 * namespace.cs: use LookupTypeDirect.
10514 * rootcontext.cs: use membercache, if possible.
10515 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10517 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10520 According to the spec,
10522 In a member access of the form E.I, if E is a single identifier,
10523 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10524 field, property, localvariable, or parameter with the same type as
10525 the meaning of E as a type-name (§3.8), then both possible
10526 meanings of E are permitted.
10528 We did not check that E as a simple-name had the same type as E as
10531 This trivial check gives us 5-7% on bootstrap time.
10533 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10535 Fixed bug #59071 & cs0160.cs
10536 * statement.cs (Try.Resolve): Check here whether order of catch
10537 clauses matches their dependencies.
10539 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10542 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10545 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10547 * expression.cs (Invocation.OverloadResolve): Avoid the
10548 use of hashtables and boxing here by allocating on demand.
10550 2004-05-30 Martin Baulig <martin@ximian.com>
10552 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10553 we're doing a silent lookup. Don't try to lookup nested types in
10554 TypeManager.object_type (thanks to Ben Maurer).
10556 2004-05-30 Martin Baulig <martin@ximian.com>
10558 Committing a patch from Ben Maurer.
10560 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10562 2004-05-29 Martin Baulig <martin@ximian.com>
10564 * class.cs (IMethodData.ShouldIgnore): New method.
10566 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10567 `Location' argument, we don't need it anywhere. Use
10568 `IMethodData.ShouldIgnore ()' instead of
10569 `MethodData.GetMethodFlags ()'.
10570 (TypeManager.AddMethod): Removed.
10571 (TypeManager.AddMethod2): Renamed to AddMethod.
10573 2004-05-29 Martin Baulig <martin@ximian.com>
10575 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10577 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10578 converting from a class type S to an interface type and we already
10579 have an object on the stack, don't box it again. Fixes #52578.
10581 2004-05-29 Martin Baulig <martin@ximian.com>
10583 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10584 Added support for `params' parameters. Fixes #59267.
10586 2004-05-29 Martin Baulig <martin@ximian.com>
10588 * literal.cs (NullPointer): Provide a private .ctor which sets
10589 `type' to TypeManager.object_type. Fixes #59048.
10591 2004-05-29 Martin Baulig <martin@ximian.com>
10593 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10594 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10596 * ecore.cs (EventExpr.instance_expr): Make the field private.
10598 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10600 Fixed bug #50080 & cs0214-2.cs
10601 * expression.cs (Cast.DoResolve): Check unsafe context here.
10603 * statement.cs (Resolve.DoResolve): Likewise.
10605 2004-05-26 Martin Baulig <martin@ximian.com>
10607 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
10609 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
10610 (RootContext.LookupType): Pass down the `silent' flag.
10612 2004-05-25 Martin Baulig <martin@ximian.com>
10615 (MethodGroupExpr.IdenticalTypeName): New public property.
10616 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
10617 expression actually refers to a type.
10619 2004-05-25 Martin Baulig <martin@ximian.com>
10621 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
10622 for #56176 and made it actually work.
10624 2004-05-25 Martin Baulig <martin@ximian.com>
10626 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
10627 (FieldExpr, PropertyExpr): Override and implement
10628 CacheTemporaries. Fixes #52279.
10630 2004-05-25 Miguel de Icaza <miguel@ximian.com>
10632 * location.cs: In the new compiler listing a file twice is a
10633 warning, not an error.
10635 2004-05-24 Martin Baulig <martin@ximian.com>
10637 * enum.cs (Enum.DefineType): For the `BaseType' to be a
10638 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
10640 2004-05-24 Martin Baulig <martin@ximian.com>
10642 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
10643 walking the `using' list. Fixes #53921.
10645 2004-05-24 Martin Baulig <martin@ximian.com>
10647 * const.cs (Const.LookupConstantValue): Added support for
10648 EmptyCast's; fixes #55251.
10650 2004-05-24 Martin Baulig <martin@ximian.com>
10652 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
10653 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
10654 which does the CS0135 check. The reason is that we first need to
10655 check whether the variable actually exists.
10657 2004-05-24 Martin Baulig <martin@ximian.com>
10659 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
10660 than RootContext.LookupType() to find the explicit interface
10661 type. Fixes #58584.
10663 2004-05-24 Raja R Harinath <rharinath@novell.com>
10665 * Makefile: Simplify. Use executable.make.
10666 * mcs.exe.sources: New file. List of sources of mcs.exe.
10668 2004-05-24 Anders Carlsson <andersca@gnome.org>
10672 Use the invariant culture when doing String.Compare for CLS case
10675 2004-05-23 Martin Baulig <martin@ximian.com>
10677 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
10678 don't have any dots. Fixes #52622, added cs0246-8.cs.
10680 * namespace.cs (NamespaceEntry.Lookup): Likewise.
10682 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10684 * class.cs (MemberBase.Define): Reuse MemberType member for
10685 resolved type. Other methods can use it too.
10687 2004-05-23 Martin Baulig <martin@ximian.com>
10689 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
10690 the variable also exists in the current block (otherwise, we need
10691 to report a CS0103). Fixes #58670.
10693 2004-05-23 Martin Baulig <martin@ximian.com>
10695 * flowanalysis.cs (Reachability.Reachable): Compute this
10696 on-the-fly rather than storing it as a field.
10698 2004-05-23 Martin Baulig <martin@ximian.com>
10700 * flowanalysis.cs (Reachability.And): Manually compute the
10701 resulting `barrier' from the reachability.
10703 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10706 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
10707 instance of ObsoleteAttribute when symbol is obsolete.
10710 (IMethodData): Extended interface for ObsoleteAttribute support.
10712 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10714 * attribute.cs: Fix bug #55970
10716 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10720 (GetObsoleteAttribute): New method. Creates the instance of
10722 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
10723 ObsoleteAttribute when member is obsolete.
10724 (AttributeTester.Report_ObsoleteMessage): Common method for
10725 Obsolete error/warning reporting.
10728 (TypeContainer.base_classs_type): New member for storing parent type.
10731 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
10732 for this MemberCore.
10734 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10736 * attribute.cs, const.cs: Fix bug #58590
10738 2004-05-21 Martin Baulig <martin@ximian.com>
10740 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
10741 out parameters if the end of the method is unreachable. Fixes
10744 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10746 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
10747 Hari was right, why extra method.
10749 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10751 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
10753 2004-05-20 Martin Baulig <martin@ximian.com>
10755 * delegate.cs: Convert this file to Unix mode - like the original
10758 2004-05-20 Martin Baulig <martin@ximian.com>
10760 * attribute.cs: Convert this file to Unix mode - like the original
10763 2004-05-19 Marek Safar <marek.safar@seznam.cz>
10765 Fix bug #58688 (MCS does not report error when the same attribute
10768 * attribute.cs (Attribute.Emit): Distinction between null and default.
10770 2004-05-19 Raja R Harinath <rharinath@novell.com>
10772 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
10773 of a top-level attribute without an attribute target.
10774 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
10776 (Attribute.Conditional_GetConditionName),
10777 (Attribute.Obsolete_GetObsoleteMessage): Update.
10778 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
10779 part of ScanForIndexerName.
10780 (Attribute.CanIgnoreInvalidAttribute): New function.
10781 (Attribute.ScanForIndexerName): Move to ...
10782 (Attributes.ScanForIndexerName): ... here.
10783 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
10784 (Attributes.Search): New internal variant that can choose not to
10785 complain if types aren't resolved. The original signature now
10787 (Attributes.GetClsCompliantAttribute): Use internal variant, with
10788 complaints suppressed.
10789 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
10790 only if it not useful.
10791 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
10792 top-level for attributes that are shared between the assembly
10793 and a top-level class.
10794 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
10795 * class.cs: Update to reflect changes.
10796 (DefineIndexers): Fuse loops.
10797 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
10798 a couple more variants of attribute names.
10800 2004-05-18 Marek Safar <marek.safar@seznam.cz>
10802 Fix bug #52585 (Implemented explicit attribute declaration)
10805 (Attributable.ValidAttributeTargets): New abstract method. It gets
10806 list of valid attribute targets for explicit target declaration.
10807 (Attribute.Target): It holds target itself.
10808 (AttributeSection): Removed.
10809 (Attribute.CheckTargets): New method. It checks whether attribute
10810 target is valid for the current element.
10813 (EventProperty): New class. For events that are declared like
10814 property (with add and remove accessors).
10815 (EventField): New class. For events that are declared like field.
10818 * cs-parser.jay: Implemented explicit attribute target declaration.
10820 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
10821 Override ValidAttributeTargets.
10824 (ReturnParameter): Class for applying custom attributes on
10826 (ParameterAtribute): New class. Class for applying custom
10827 attributes on the parameter type.
10829 2004-05-17 Miguel de Icaza <miguel@ximian.com>
10831 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
10834 (Method): Allow UNSAFE here.
10836 * modifiers.cs: Support unsafe reporting.
10838 2004-05-17 Marek Safar <marek.safar@seznam.cz>
10840 * decl.cs: Fix bug #58478.
10842 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10844 * statement.cs: When checking for unreachable code on an EmptyStatement,
10845 set the location. Fixes bug #58488.
10847 2004-05-13 Miguel de Icaza <miguel@ximian.com>
10849 * driver.cs: Add -pkg handling.
10851 From Gonzalo: UseShelLExecute=false
10853 2004-05-12 Marek Safar <marek.safar@seznam.cz>
10856 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
10858 (Attribute.IsClsCompliaceRequired): Moved to base for better
10860 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
10861 when attribute is AttributeUsageAttribute.
10862 (Attribute.GetValidTargets): Simplified.
10863 (Attribute.GetAttributeUsage): New method returns AttributeUsage
10864 attribute for this type.
10865 (Attribute.ApplyAttributes): Method renamed to Emit and make
10867 (GlobalAttributeSection): New class for special handling of global
10868 attributes (assembly, module).
10869 (AttributeSection.Emit): New method.
10871 * class.cs: Implemented Attributable abstract methods.
10872 (MethodCore.LabelParameters): Moved to Parameter class.
10873 (Accessor): Is back simple class.
10874 (PropertyMethod): Implemented Attributable abstract class.
10875 (DelegateMethod): Implemented Attributable abstract class.
10876 (Event): New constructor for disctintion between normal Event
10877 and Event with accessors.
10879 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
10881 * codegen.cs, const.cs, decl.cs, delegate.cs:
10882 (CommonAssemblyModulClass): Implemented Attributable abstract class
10885 * enum.cs: Implement IAttributeSupport interface.
10886 (EnumMember): New class for emum members. Implemented Attributable
10890 (ParameterBase): Is abstract.
10891 (ReturnParameter): New class for easier [return:] attribute handling.
10893 * typemanager.cs: Removed builder_to_attr.
10895 2004-05-11 Raja R Harinath <rharinath@novell.com>
10898 * attribute.cs (Attribute.GetPositionalValue): New function.
10899 * class.cs (TypeContainer.VerifyMembers): New function.
10900 (TypeContainer.Emit): Use it.
10901 (ClassOrStruct): New base class for Class and Struct.
10902 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
10903 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
10905 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
10906 then each non-static field should have a FieldOffset attribute.
10907 Otherwise, none of the fields should have a FieldOffset attribute.
10908 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
10909 and FieldOffset attributes.
10910 * typemanager.cs (TypeManager.struct_layout_attribute_type)
10911 (TypeManager.field_offset_attribute_type): New core types.
10912 (TypeManager.InitCoreTypes): Initialize them.
10914 2004-05-11 Michal Moskal <malekith@pld-linux.org>
10916 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
10917 Return correct type.
10920 2004-05-09 Miguel de Icaza <miguel@ximian.com>
10922 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
10923 be implicitly converted to ulong.
10925 * expression.cs: The logic for allowing operator &, | and ^ worked
10926 was wrong, it worked before because we did not report an error in
10927 an else branch. Fixes 57895.
10929 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
10930 allow volatile fields to be reference types.
10932 2004-05-07 Miguel de Icaza <miguel@ximian.com>
10934 * driver.cs: Add support for /debug-
10936 2004-05-07 Raja R Harinath <rharinath@novell.com>
10938 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
10939 Add a 'complain' parameter to silence errors.
10940 (Attribute.Resolve): Update to changes. Put in sanity check to catch
10941 silently overlooked type-resolutions.
10942 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
10943 to reflect changes.
10944 (Attributes.Search): New function.
10945 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
10946 (Attributes.GetAttributeFullName): Remove hack.
10947 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
10948 Update to reflect changes.
10949 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10950 Use Attributes.Search instead of nested loops.
10952 2004-05-07 Marek Safar <marek.safar@seznam.cz>
10955 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
10956 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
10957 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
10959 * report.cs: (Report.Warning): Renamed to Warning_T because of
10960 parameter collision.
10962 2004-05-05 Raja R Harinath <rharinath@novell.com>
10964 * expression.cs (MemberAccess.ResolveMemberAccess):
10965 Exit with non-zero status after Report.Error.
10966 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
10968 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
10970 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
10972 * support.cs: Don't hang when the file is empty.
10974 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
10976 * support.cs: In SeekableStreamReader, compute the preamble size of the
10977 underlying stream. Position changes should take into account that initial
10980 2004-05-03 Todd Berman <tberman@sevenl.net>
10982 * driver.cs: remove unused GetSysVersion function.
10984 2004-05-03 Todd Berman <tberman@sevenl.net>
10986 * driver.cs: Remove the hack from saturday, as well as the hack
10987 from jackson (LoadAssemblyFromGac), also adds the CWD to the
10988 link_paths to get that bit proper.
10990 2004-05-01 Todd Berman <tberman@sevenl.net>
10992 * driver.cs: Try a LoadFrom before a Load, this checks the current
10993 path. This is currently a bug in mono that is be fixed, however, this
10994 provides a workaround for now. This will be removed when the bug
10997 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
10999 * CryptoConvert.cs: Updated to latest version. Fix issue with
11000 incomplete key pairs (#57941).
11002 2004-05-01 Todd Berman <tberman@sevenl.net>
11004 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11007 2004-04-30 Jackson Harper <jackson@ximian.com>
11009 * codegen.cs: Open keys readonly.
11011 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11013 * typemanager.cs: don't report cyclic struct layout when a struct
11014 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11015 which has 2 Pango.Rectangle fields.
11017 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11019 * expression.cs: Handle IntPtr comparisons with IL code
11020 rather than a method call.
11022 2004-04-29 Martin Baulig <martin@ximian.com>
11024 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11025 the list of PropertyInfo's in class hierarchy and find the
11026 accessor. Fixes #56013.
11028 2004-04-29 Martin Baulig <martin@ximian.com>
11030 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11032 2004-04-29 Martin Baulig <martin@ximian.com>
11034 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11036 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11038 2004-04-29 Martin Baulig <martin@ximian.com>
11040 * class.cs (ConstructorInitializer.Resolve): Check whether the
11041 parent .ctor is accessible. Fixes #52146.
11043 2004-04-29 Martin Baulig <martin@ximian.com>
11045 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11047 * statement.cs (Using.EmitLocalVariableDecls): Use
11048 TypeManager.idisposable_type, not typeof (IDisposable).
11049 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11051 2004-04-29 Martin Baulig <martin@ximian.com>
11053 * class.cs (Event.Define): Don't emit the field and don't set
11054 RTSpecialName and SpecialName for events on interfaces. Fixes
11057 2004-04-29 Raja R Harinath <rharinath@novell.com>
11059 Refactor Attribute.ApplyAttributes.
11060 * attribute.cs (Attributable): New base class for objects that can
11061 have Attributes applied on them.
11062 (Attribute): Make AttributeUsage fields public.
11063 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11064 (Attribute.IsInternalCall): New property.
11065 (Attribute.UsageAttr): Convert to a public read-only property.
11066 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11067 (Attribute.ResolveType, Attribute.Resolve)
11068 (Attribute.ScanForIndexerName): Update to reflect changes.
11069 (Attribute.CheckAttributeTarget): Re-format.
11070 (Attribute.ApplyAttributes): Refactor, to various
11071 Attributable.ApplyAttributeBuilder methods.
11072 * decl.cs (MemberCore): Make Attributable.
11073 * class.cs (Accessor): Make Attributable.
11074 (MethodData.ApplyAttributes): Use proper attribute types, not
11076 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11077 (TypeContainer.ApplyAttributeBuilder)
11078 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11079 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11080 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11081 (Operator.ApplyAttributeBuilder): New factored-out methods.
11082 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11083 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11084 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11085 * parameter.cs (ParameterBase): New Attributable base class
11086 that can also represent Return types.
11087 (Parameter): Update to the changes.
11089 2004-04-29 Jackson Harper <jackson@ximian.com>
11091 * driver.cs: Prefer the corlib system version when looking for
11092 assemblies in the GAC. This is still a hack, but its a better hack
11095 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11097 * decl.cs, enum.cs: Improved error 3005 reporting.
11099 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11100 (related_symbols): New private member for list of symbols
11101 related to reported error/warning.
11103 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11105 2004-04-29 Martin Baulig <martin@ximian.com>
11107 * ecore.cs (Expression.Constantify): If we're an enum and
11108 TypeManager.TypeToCoreType() doesn't give us another type, use
11109 t.UnderlyingSystemType. Fixes #56178.
11111 2004-04-29 Martin Baulig <martin@ximian.com>
11113 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11114 interfaces and for each interface, only add members directly
11115 declared in that interface. Fixes #53255.
11117 2004-04-28 Martin Baulig <martin@ximian.com>
11119 * expression.cs (ConditionalLogicalOperator): Use a temporary
11120 variable for `left' to avoid that we evaluate it more than once;
11123 2004-04-28 Martin Baulig <martin@ximian.com>
11125 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11128 2004-04-28 Martin Baulig <martin@ximian.com>
11130 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11133 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11134 whether the type is not void (CS1547).
11136 2004-04-28 Martin Baulig <martin@ximian.com>
11138 * expression.cs (Unary.DoResolveLValue): Override this and report
11139 CS0131 for anything but Operator.Indirection.
11141 2004-04-28 Martin Baulig <martin@ximian.com>
11143 Committing a patch from Ben Maurer; see bug #50820.
11145 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11148 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11151 2004-04-28 Martin Baulig <martin@ximian.com>
11153 Committing a patch from Ben Maurer; see bug #50820.
11155 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11158 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11161 2004-04-28 Martin Baulig <martin@ximian.com>
11163 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11164 (Block.AddLabel): Call DoLookupLabel() to only search in the
11167 2004-04-28 Martin Baulig <martin@ximian.com>
11169 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11170 comparing StringConstants and NullLiterals in Equality and Inequality.
11172 2004-04-28 Jackson Harper <jackson@ximian.com>
11174 * driver.cs: Attempt to load referenced assemblies from the
11175 GAC. This is the quick and dirty version of this method that
11176 doesnt take into account versions and just takes the first
11177 canidate found. Will be good enough for now as we will not have more
11178 then one version installed into the GAC until I update this method.
11180 2004-04-28 Martin Baulig <martin@ximian.com>
11182 * typemanager.cs (TypeManager.CheckStructCycles): New public
11183 static method to check for cycles in the struct layout.
11185 * rootcontext.cs (RootContext.PopulateTypes): Call
11186 TypeManager.CheckStructCycles() for each TypeContainer.
11187 [Note: We only need to visit each type once.]
11189 2004-04-28 Martin Baulig <martin@ximian.com>
11191 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11193 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11194 success and added `out object value'. Use a `bool resolved' field
11195 to check whether we've already been called rather than
11196 `ConstantValue != null' since this breaks for NullLiterals.
11198 2004-04-28 Raja R Harinath <rharinath@novell.com>
11200 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11201 setting of this flag, since the 'set' method may be non-public.
11203 2004-04-28 Raja R Harinath <rharinath@novell.com>
11205 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11206 check on current_vector.Block.
11208 2004-04-27 Martin Baulig <martin@ximian.com>
11210 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11211 a field initializer. Fixes #56459.
11213 2004-04-27 Martin Baulig <martin@ximian.com>
11215 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11216 we're not attempting to use an indexer. Fixes #52154.
11218 2004-04-27 Martin Baulig <martin@ximian.com>
11220 * statement.cs (Return): Don't create a return label if we don't
11221 need it; reverts my change from January 20th. Thanks to Ben
11224 2004-04-27 Martin Baulig <martin@ximian.com>
11226 According to the spec, `goto' can only leave a nested scope, but
11229 * statement.cs (Block.LookupLabel): Only lookup in the current
11230 block, don't recurse into parent or child blocks.
11231 (Block.AddLabel): Check in parent and child blocks, report
11232 CS0140/CS0158 if we find a duplicate.
11233 (Block): Removed this indexer for label lookups.
11234 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11235 this already does the error reporting for us.
11238 (FlowBranching.UsageVector.Block): New public variable; may be null.
11239 (FlowBranching.CreateSibling): Added `Block' argument.
11240 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11241 label for the target of a `goto' and check whether we're not
11242 leaving a `finally'.
11244 2004-04-27 Martin Baulig <martin@ximian.com>
11246 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11247 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11250 2004-04-27 Martin Baulig <martin@ximian.com>
11252 * statement.cs (Block.AddLabel): Also check for implicit blocks
11253 and added a CS0158 check.
11255 2004-04-27 Martin Baulig <martin@ximian.com>
11257 * flowanalysis.cs (FlowBranchingLoop): New class.
11258 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11259 UsageVector's instead of an ArrayList.
11260 (FlowBranching.Label): Likewise.
11261 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11262 (FlowBranching.AddBreakVector): New method.
11264 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11266 * attribute.cs: Small regression fix: only convert the type if we
11267 the type is different, fixes System.Drawing build.
11269 2004-04-27 Martin Baulig <martin@ximian.com>
11271 * attribute.cs (Attribute.Resolve): If we have a constant value
11272 for a named field or property, implicity convert it to the correct
11275 2004-04-27 Raja R Harinath <rharinath@novell.com>
11277 * statement.cs (Block.Block): Implicit blocks share
11278 'child_variable_names' fields with parent blocks.
11279 (Block.AddChildVariableNames): Remove.
11280 (Block.AddVariable): Mark variable as "used by a child block" in
11281 every surrounding block.
11282 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11283 been used in a child block, complain about violation of "Invariant
11284 meaning in blocks" rule.
11285 * cs-parser.jay (declare_local_variables): Don't use
11286 AddChildVariableNames.
11287 (foreach_statement): Don't create an implicit block: 'foreach'
11288 introduces a scope.
11290 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11292 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11293 converting from 0L to ulong. Fixes 57522.
11295 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11297 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11298 derived class hides via 'new' keyword field from base class (test-242.cs).
11299 TODO: Handle this in the more general way.
11301 * class.cs (CheckBase): Ditto.
11303 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11305 * decl.cs (caching_flags): New member for storing cached values
11307 (MemberCore.Flags): New enum where bit flags for caching_flags
11309 (MemberCore.cls_compliance): Moved to caching_flags.
11310 (DeclSpace.Created): Moved to caching_flags.
11312 * class.cs: Use caching_flags instead of DeclSpace.Created
11314 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11316 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11317 if we are only a derived class, not a nested class.
11319 * typemanager.cs: Same as above, but do this at the MemberLookup
11320 level (used by field and methods, properties are handled in
11321 PropertyExpr). Allow for the qualified access if we are a nested
11324 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11326 * class.cs: Refactoring.
11327 (IMethodData): New inteface; Holds links to parent members
11328 to avoid member duplication (reduced memory allocation).
11329 (Method): Implemented IMethodData interface.
11330 (PropertyBase): New inner classes for get/set methods.
11331 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11332 (Event): New inner classes for add/remove methods.
11333 (Event.DelegateMethod): Implemented IMethodData interface.
11335 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11336 EmitContext (related to class.cs refactoring).
11338 2004-04-21 Raja R Harinath <rharinath@novell.com>
11340 * delegate.cs (Delegate.VerifyApplicability): If the number of
11341 arguments are the same as the number of parameters, first try to
11342 verify applicability ignoring any 'params' modifier on the last
11346 2004-04-08 Martin Baulig <martin@ximian.com>
11348 Merged latest changes into gmcs. Please keep this comment in
11349 here, it makes it easier for me to see what changed in MCS since
11350 the last time I merged.
11352 2004-04-16 Raja R Harinath <rharinath@novell.com>
11354 * class.cs (TypeContainer.AddIndexer): Use
11355 'ExplicitInterfaceName' to determine if interface name was
11356 explicitly specified. 'InterfaceType' is not initialized at this time.
11357 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11358 Indexers array is already in the required order. Initialize
11359 'IndexerName' only if there are normal indexers.
11360 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11361 (TypeContainer.Emit): Emit DefaultMember attribute only if
11362 IndexerName is initialized.
11365 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11367 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11370 2004-04-15 Raja R Harinath <rharinath@novell.com>
11372 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11376 * attribute.cs (Attribute.Resolve): Check for duplicate named
11380 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11382 * iterators.cs (MarkYield): track whether we are in an exception,
11383 and generate code accordingly. Use a temporary value to store the
11384 result for our state.
11386 I had ignored a bit the interaction of try/catch with iterators
11387 since their behavior was not entirely obvious, but now it is
11388 possible to verify that our behavior is the same as MS .NET 2.0
11392 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11394 * iterators.cs: Avoid creating temporaries if there is no work to
11397 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11398 Enumerations, use TypeManager.EnumToUnderlying and call
11401 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11404 (This.Emit): Use EmitContext.EmitThis to emit our
11407 (This.EmitAssign): Ditto.
11409 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11410 codepaths, we will move all the functionality into
11413 (FieldExpr.EmitAssign): Ditto.
11415 This fixes several hidden bugs that I uncovered while doing a code
11416 review of this today.
11418 * codegen.cs (EmitThis): reworked so the semantics are more clear
11419 and also support value types "this" instances.
11421 * iterators.cs: Changed so that for iterators in value types, we
11422 do not pass the value type as a parameter.
11424 Initialization of the enumerator helpers is now done in the caller
11425 instead of passing the parameters to the constructors and having
11426 the constructor set the fields.
11428 The fields have now `assembly' visibility instead of private.
11430 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11432 * expression.cs (Argument.Resolve): Check if fields passed as ref
11433 or out are contained in a MarshalByRefObject.
11435 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11436 another compiler type.
11438 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11440 * class.cs (Indexer.Define): use the new name checking method.
11441 Also, return false on an error.
11442 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11443 (is_identifier_[start/part]_character): make static.
11445 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11447 * expression.cs (Binary.ResolveOperator): Do no append strings
11448 twice: since we can be invoked more than once (array evaluation)
11449 on the same concatenation, take care of this here. Based on a fix
11450 from Ben (bug #56454)
11452 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11454 * codegen.cs: Fix another case where CS1548 must be reported (when
11455 delay-sign isn't specified and no private is available #56564). Fix
11456 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11457 error when MCS is used on the MS runtime and we need to delay-sign
11458 (which seems unsupported by AssemblyBuilder - see #56621).
11460 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11462 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11463 (TypeManager.ComputeNamespaces): Faster implementation for
11466 * compiler.csproj: Updated AssemblyName to mcs.
11468 2004-05-11 Jackson Harper <jackson@ximian.com>
11470 * Makefile: Preserve MONO_PATH
11472 2004-05-11 Jackson Harper <jackson@ximian.com>
11474 * Makefile: Use mono and mcs to build gmcs
11476 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11478 * codegen.cs: Add patch from Robert Shade
11479 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11482 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11484 * CryptoConvert.cs: Updated to latest version. Fix issue with
11485 incomplete key pairs (#57941).
11487 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11489 * codegen.cs: Fix another case where CS1548 must be reported (when
11490 delay-sign isn't specified and no private is available #56564). Fix
11491 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11492 error when MCS is used on the MS runtime and we need to delay-sign
11493 (which seems unsupported by AssemblyBuilder - see #56621).
11495 2004-04-29 Jackson Harper <jackson@ximian.com>
11497 * Makefile: Set MONO_PATH to use the bootstrap corlib
11498 * driver.cs: Check the GAC for referenced assemblies.
11500 2004-04-29 Martin Baulig <martin@ximian.com>
11502 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11504 2004-04-07 Martin Baulig <martin@ximian.com>
11506 * expression.cs (Binary.ResolveOperator): Added special case for
11507 Equality/Inequality between a type parameter and a null literal.
11509 2004-04-07 Martin Baulig <martin@ximian.com>
11511 * convert.cs: Check null literal -> type parameter conversions.
11513 2004-04-07 Martin Baulig <martin@ximian.com>
11515 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11516 `class' and `struct' constraints.
11518 2004-04-07 Martin Baulig <martin@ximian.com>
11520 * generic.cs (SpecialConstraint): New public enum.
11521 (Constraints.Resolve): Added support for the `class' and `struct'
11524 * cs-parser.jay (type_parameter_constraint): Added support for the
11525 `class' and `struct' constraints.
11527 2004-04-07 Martin Baulig <martin@ximian.com>
11529 * support.cs (GenericConstraints): Replaced `Types' by
11530 `ClassConstraint' and `InterfaceConstraints'; added
11531 `HasClassConstraint'.
11533 2004-04-07 Martin Baulig <martin@ximian.com>
11536 (Constraints.InterfaceConstraints): New public property.
11537 (Constraints.Types): Make this property public
11538 (TypeParameter): Implement IMemberContainer.
11539 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11540 instead of a TypeBuilder/MethodBuilder; pass the interface
11541 constraints to TypeManager.AddTypeParameter().
11542 (TypeParameter.DefineType): Just take an EmitContext and no
11543 TypeBuilder/MethodBuilder. Use the new public API.
11545 * typemanager.cs (TypeManager.AddTypeParameter): Added
11546 `TypeExpr[]' argument; add the interfaces to the
11547 `builder_to_ifaces' hash.
11548 (TypeManager.LookupMemberContainer): For
11549 GenericTypeParameterBuilders, get the TypeParameter from the
11550 `builder_to_type_param'.
11551 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11552 the TypeParameter and call FindMembers on it.
11554 2004-04-07 Martin Baulig <martin@ximian.com>
11557 (MethodCore.GenericMethod): Moved this field here from Method.
11558 (MethodCore.IsDuplicateImplementation): Take the number of type
11559 parameters into account if we're a generic method.
11561 * expression.cs (Invocation.InferTypeArguments): Don't return true
11562 if `arguments' is null; we still need to check whether we actually
11563 don't need to infer anything in this case.
11564 (MemberAccess): Merged the functionality from GenericMemberAccess
11567 * generic.cs (GenericMemberAccess): Removed.
11569 2004-04-05 Martin Baulig <martin@ximian.com>
11571 * decl.cs (MemberCore): For generic classes, interfaces and
11572 structs, `Name' now includes the number of type parameters
11573 ("Stack!1.Node!1").
11574 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11575 encode the number of type arguments in the type name.
11577 * expression.cs (Expression.MemberLookup): Removed the
11578 `num_type_args' argument; we now encode the number of type
11579 arguments in the type name.
11581 * ecore.cs (SimpleName): Encode the number of type arguments in
11582 the type name itself.
11584 * generic.cs (ConstructedType): Likewise.
11586 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11587 `MemberName'; we now include the number of type parameters in the
11590 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11591 (TypeManager.MemberLookup): Removed the
11592 `num_type_args' argument; we now encode the number of type
11593 arguments in the type name.
11595 2004-04-03 Martin Baulig <martin@ximian.com>
11597 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11598 (MemberCore.MemberName): Moved here from MemberBase.
11599 (DeclSpace.SetParameterInfo): Just take the constraints as an
11600 ArrayList; we already have the type parameters in our
11601 `MemberName'; also do the CS0080 reporting here.
11603 * cs-parser.jay (struct_declaration): Use `member_name' instead of
11604 `IDENTIFIER opt_type_parameter_list'; when constructing our
11605 `MemberName', it'll already include our type parameters.
11606 (class_declaration, interface_declaration): Likewise.
11607 (delegate_declaration): Likewise.
11608 (MakeName): Take a MemberName and return a MemberName.
11609 The following two changes are required to avoid shift/reduce conflicts:
11610 (member_name): Don't include a TypeName anymore; ie. this is now
11611 just 'IDENTIFIER opt_type_parameter_list'.
11612 (property_declaration, event_declaration): Use a
11613 `namespace_or_type_name' instead of a `member_name'.
11615 2004-04-03 Martin Baulig <martin@ximian.com>
11617 * decl.cs (MemberName): Renamed to `TypeName' and created a new
11618 `MemberName' class.
11619 (TypeName): Formerly known as MemberName.
11621 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
11622 instead of a `MemberName'.
11624 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
11625 (member_name): New rule; create a MemberName.
11627 2004-04-02 Martin Baulig <martin@ximian.com>
11629 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
11630 (CS0305 and CS0308).
11632 2004-04-02 Martin Baulig <martin@ximian.com>
11634 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
11635 support for nested types.
11637 2004-04-02 Martin Baulig <martin@ximian.com>
11639 * ecore.cs (IAlias): New public interface.
11640 (TypeExpr, TypeExpression): Implement IAlias.
11641 (TypeAliasExpression): New public class.
11643 * namespace.cs (Namespace): Implement IAlias.
11644 (Namespace.Lookup): Return an IAlias instead on an object.
11645 (Namespace.DefineName): Take an IAlias instead of an object.
11646 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
11648 (NamespaceEntry.UsingAlias): Take a Membername instead of an
11650 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
11652 (NamespaceEntry.Lookup): Likewise.
11654 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
11657 * decl.cs (DeclSpace): Implement IAlias.
11658 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
11660 * generic.cs (ConstructedType): Improved error checking.
11662 2004-04-02 Martin Baulig <martin@ximian.com>
11664 * convert.cs: Added type parameter conversions.
11667 (UnboxCast.Emit): Emit an `unbox.any' for type params.
11668 (ClassCast.Emit): If the source type is a type parameter, box it.
11669 If the target type is a type parameter, emit an `unbox.any'
11670 instead of a `classcast'.1
11672 2004-04-01 Martin Baulig <martin@ximian.com>
11674 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
11676 2004-04-01 Martin Baulig <martin@ximian.com>
11678 * generic.cs (ConstructedType.CheckConstraints): Use
11679 Convert.ImplicitStandardConversionExists(); user-defined implicit
11680 conversions are not allowed according to the spec.
11682 2004-03-30 Martin Baulig <martin@ximian.com>
11684 * expression.cs (New): Added support for type parameters.
11687 (TypeManager.activator_type): New public static field.
11688 (TypeManager.activator_create_instance): Likewise.
11690 2004-03-30 Martin Baulig <martin@ximian.com>
11692 * typemanager.cs (TypeManager.HasConstructorConstraint): New
11695 2004-03-30 Martin Baulig <martin@ximian.com>
11697 * generic.cs (ConstructedType.CheckConstraints): Actually follow
11698 the spec here: the argument type must be convertible to the
11701 2004-03-30 Martin Baulig <martin@ximian.com>
11704 (TypeParameter.Define, TypeParameter.DefineMethod): Call
11705 TypeManager.AddTypeParameter().
11706 (ConstructedType.CheckConstraints): Re-enable this and actually
11707 check whether we have a constructor constraint.
11710 (TypeManager.builder_to_type_param): New static field.
11711 (TypeManager.AddTypeParameter): New static method.
11712 (TypeManager.LookupTypeParameter): New public method.
11714 2004-03-30 Martin Baulig <martin@ximian.com>
11716 * generic.cs (TypeParameter.DefineType): Return a boolean and use
11717 the new API to actually define the constructor constraint.
11720 (TypeManager.new_constraint_attr_type): New static field.
11721 (TypeManager.InitCoreTypes): Initialize it.
11723 2004-03-30 Martin Baulig <martin@ximian.com>
11725 * generic.cs (Constraints): Completed error checking, use correct
11728 2004-03-29 Martin Baulig <martin@ximian.com>
11730 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
11732 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11733 public version which takes a `ParameterData pd' instead of an
11736 2004-03-29 Martin Baulig <martin@ximian.com>
11738 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
11741 2004-03-29 Martin Baulig <martin@ximian.com>
11743 * expression.cs (Argument.ResolveMethodGroup): If we're a
11744 ConstructedType, call GetMemberAccess() on it.
11746 2004-03-29 Martin Baulig <martin@ximian.com>
11748 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
11749 (MethodCore.CheckGenericOverride): When overriding a generic
11750 method, check whether the constraints match.
11752 * support.cs (GenericConstraints): New public interface.
11753 (ParameterData.GenericConstraints): New public method.
11755 * parameter.cs (Parameter.Resolve): Check whether we're a generic
11756 method parameter and compute our constraints if appropriate.
11757 (Parameter.GenericConstraints): New public property.
11759 * generic.cs (Constraints): Implement GenericConstraints.
11761 2004-03-29 Martin Baulig <martin@ximian.com>
11763 * decl.cs (MemberCache.FindMemberToOverride): Use
11764 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
11766 2004-03-29 Martin Baulig <martin@ximian.com>
11768 * generic.cs (GenericMethod.Define): Resolve our type parameters.
11770 2004-03-29 Martin Baulig <martin@ximian.com>
11772 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
11773 not allowed on non-generic declarations").
11775 2004-03-29 Martin Baulig <martin@ximian.com>
11777 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11778 public version of this method.
11780 * class.cs (MethodCore.IsDuplicateImplementation): Use
11781 Invocation.InferTypeArguments() to check this.
11783 2004-03-29 Martin Baulig <martin@ximian.com>
11785 * convert.cs: Use TypeManager.IsDelegateType() instead of
11786 comparing types correctly.
11788 2004-03-29 Martin Baulig <martin@ximian.com>
11790 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
11791 types directly to make it work for generic instances.
11793 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
11795 2004-03-29 Martin Baulig <martin@ximian.com>
11797 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
11798 support for arrays.
11800 2004-03-24 Martin Baulig <martin@ximian.com>
11802 * decl.cs (DeclSpace.FindType): Also use
11803 TypeManager.CheckGeneric() for types from the using clauses.
11805 2004-03-23 Martin Baulig <martin@ximian.com>
11807 * expression.cs (Invocation.OverloadResolve): Added `bool
11808 may_fail' argument and use it instead of the Location.IsNull() hack.
11810 2004-03-23 Martin Baulig <martin@ximian.com>
11812 * expression.cs (Invocation.InferType): Use correct type inference
11815 2004-03-23 Martin Baulig <martin@ximian.com>
11817 * ecore.cs (MethodGroupExpr.Name): Use
11818 TypeManager.CSharpSignature() instead of just the name.
11820 * expression.cs (Invocation.OverloadResolve): Provide better error
11822 (Invocation.DoResolve): OverloadResolve() never returns null
11823 without reporting an error, so removed the error -6 reporting here.
11825 2004-03-23 Martin Baulig <martin@ximian.com>
11827 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
11830 * cs-parser.jay (delegate_declaration): Support generic delegates.
11832 * delegate.cs: Support generic delegates.
11834 2004-03-22 Martin Baulig <martin@ximian.com>
11836 * expression.cs (Invocation.InferParamsTypeArguments): New static
11837 method; does type inference for params arguments.
11839 2004-03-21 Martin Baulig <martin@ximian.com>
11841 * typemanager.cs (TypeManager.IsGenericMethod): New public static
11842 method; checks whether a method is a generic method.
11844 * expression.cs (Invocation.InferTypeArguments): New static method;
11845 infer type arguments for generic method invocation.
11847 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
11848 property; we set this to true if we're resolving a generic method
11849 invocation and the user specified type arguments, ie. we're not
11850 doing type inference.
11852 2004-03-20 Martin Baulig <martin@ximian.com>
11854 * class.cs (MethodData.DeclaringType): New public property.
11855 (MethodData.Define): Set DeclaringType here.
11856 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
11857 instead of OperatorMethodBuilder.DeclaringType.
11859 2004-03-20 Martin Baulig <martin@ximian.com>
11861 * cs-tokenizer.cs (xtoken): Return a special
11862 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
11864 * cs-parser.jay (default_value_expression): Switch to the new
11867 2004-03-19 Martin Baulig <martin@ximian.com>
11869 * decl.cs (MemberName): New class. We use this to "construct"
11870 namespace_or_type_name's.
11872 * generics.cs (TypeArguments.GetDeclarations): New public method;
11873 returns the type arguments as a string[] and reports a CS0081 if
11874 one of them is not an identifier.
11876 * class.cs (MemberBase): The .ctor now takes the name as a
11877 MemberName instead of a string.
11878 (MemberBase.ExplicitInterfaceName): Changed type from string to
11880 (MemberBase.DoDefine): If we're an explicit implementation, the
11881 InterfaceType may be a generic instance.
11883 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
11884 (namespace_name): Call MemberName.GetName () to transform the
11885 MemberName into a string and ensure we don't have any type
11887 (type_name): Call MemberName.GetTypeExpression() to transfrom the
11888 MemberName into an expression.
11889 (method_header): Use namespace_or_type_name instead of member_name.
11891 2004-04-07 Miguel de Icaza <miguel@ximian.com>
11893 * rootcontext.cs: Add new types to the boot resolution.
11895 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
11896 MulticastDelegate is not allowed.
11898 * typemanager.cs: Add new types to lookup: System.TypedReference
11901 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
11902 check for TypedReference or ArgIterator, they are not allowed.
11904 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
11905 makes us properly catch 1510 in some conditions (see bug 56016 for
11908 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
11910 * CryptoConvert.cs: update from corlib version
11913 2004-04-05 Miguel de Icaza <miguel@ximian.com>
11915 * class.cs (Indexer.Define): Check indexername declaration
11917 2004-04-05 Marek Safar <marek.safar@seznam.cz>
11919 * attribute.cs (IsClsCompliant): Fixed problem with handling
11920 all three states (compliant, not-compliant, undetected).
11922 2004-03-30 Marek Safar <marek.safar@seznam.cz>
11924 * attribute.cs (Attribute): Location is now public.
11925 (Resolve): Store resolved arguments (pos_values) in attribute class.
11926 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
11927 (GetClsCompliantAttributeValue): New method that gets
11928 CLSCompliantAttribute value.
11929 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
11930 if exists else null.
11931 (AttributeTester): New class for CLS-Compliant verification routines.
11933 * class.cs (Emit): Add CLS-Compliant verification.
11934 (Method.GetSignatureForError): Implemented.
11935 (Constructor.GetSignatureForError): Implemented
11936 (Constructor.HasCompliantArgs): Returns if constructor has
11937 CLS-Compliant arguments.
11938 (Constructor.Emit): Override.
11939 (Construcor.IsIdentifierClsCompliant): New method; For constructors
11940 is needed to test only parameters.
11941 (FieldBase.GetSignatureForError): Implemented.
11942 (TypeContainer): New member for storing base interfaces.
11943 (TypeContainer.FindMembers): Search in base interfaces too.
11945 * codegen.cs (GetClsComplianceAttribute): New method that gets
11946 assembly or module CLSCompliantAttribute value.
11947 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
11949 (ModuleClass.Emit): Add error 3012 test.
11951 * const.cs (Emit): Override and call base for CLS-Compliant tests.
11953 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
11954 state for all decl types.
11955 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
11956 if CLS-Compliant tests are required.
11957 (IsClsCompliaceRequired): New method. Analyze whether code
11958 must be CLS-Compliant.
11959 (IsExposedFromAssembly): New method. Returns true when MemberCore
11960 is exposed from assembly.
11961 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
11962 value or gets cached value.
11963 (HasClsCompliantAttribute): New method. Returns true if MemberCore
11964 is explicitly marked with CLSCompliantAttribute.
11965 (IsIdentifierClsCompliant): New abstract method. This method is
11966 used to testing error 3005.
11967 (IsIdentifierAndParamClsCompliant): New method. Common helper method
11968 for identifier and parameters CLS-Compliant testing.
11969 (VerifyClsCompliance): New method. The main virtual method for
11970 CLS-Compliant verifications.
11971 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
11972 null. I don't know why is null (too many public members !).
11973 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
11974 and get value of first CLSCompliantAttribute that found.
11976 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
11977 (VerifyClsCompliance): Override and add extra tests.
11979 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
11980 clscheck- disable CLS-Compliant verification event if assembly is has
11981 CLSCompliantAttribute(true).
11983 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
11984 ApllyAttribute is now called in emit section as in the other cases.
11985 Possible future Emit integration.
11986 (IsIdentifierClsCompliant): New override.
11987 (VerifyClsCompliance): New override.
11988 (GetEnumeratorName): Returns full enum name.
11990 * parameter.cs (GetSignatureForError): Implemented.
11992 * report.cs (WarningData): New struct for Warning message information.
11993 (LocationOfPreviousError): New method.
11994 (Warning): New method. Reports warning based on the warning table.
11995 (Error_T): New method. Reports error based on the error table.
11997 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
11998 verifications are done here.
12000 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12002 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12003 CLSCompliantAttribute.
12004 (all_imported_types): New member holds all imported types from other
12006 (LoadAllImportedTypes): New method fills static table with exported types
12007 from all referenced assemblies.
12008 (Modules): New property returns all assembly modules.
12010 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12012 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12013 throwing a parser error.
12015 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12016 which removes the hardcoded get_/set_ prefixes for properties, as
12017 IL allows for the properties to be named something else.
12021 * expression.cs: Do not override operand before we know if it is
12022 non-null. Fix 56207
12024 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12026 * typemanager.cs: support for pinned variables.
12028 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12030 * decl.cs, typemanager.cs: Avoid using an arraylist
12031 as a buffer if there is only one result set.
12033 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12035 * expression.cs: Make sure you cant call a static method
12036 with an instance expression, bug #56174.
12038 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12040 * class.cs (IsDuplicateImplementation): Improve error reporting to
12041 flag 663 (method only differs in parameter modifier).
12043 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12044 in preprocessor directives.
12046 * location.cs (LookupFile): Allow for the empty path.
12048 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12049 better approach for some of that patch, but its failing with the
12050 CharSet enumeration. For now try/catch will do.
12052 * typemanager.cs: Do not crash if a struct does not have fields.
12055 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12057 * expression.cs: cs0213, cant fix a fixed expression.
12060 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12062 * cs-parser.jay: detect invalid embeded statements gracefully.
12065 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12067 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12070 the invocation type may not be a subclass of the tye of the item/
12071 The type of the item must be a subclass of the invocation item.
12076 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12078 * attribute.cs: Added methods to get a string and a bool from an
12079 attribute. Required to information from AssemblyKeyFileAttribute,
12080 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12081 * codegen.cs: Modified AssemblyName creation to include support for
12082 strongnames. Catch additional exceptions to report them as CS1548.
12083 * compiler.csproj: Updated include CryptoConvert.cs.
12084 * compiler.csproj.user: Removed file - user specific configuration.
12085 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12086 Mono.Security assembly. The original class is maintained and tested in
12087 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12088 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12089 like CSC 8.0 (C# v2) supports.
12090 * Makefile: Added CryptoConvert.cs to mcs sources.
12091 * rootcontext.cs: Added new options for strongnames.
12093 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12095 * driver.cs: For --expect-error, report error code `2'
12096 if the program compiled with no errors, error code `1' if
12097 it compiled with an error other than the one expected.
12099 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12101 * compiler.csproj: Updated for Visual Studio .NET 2003.
12102 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12103 * compiler.sln: Updated for Visual Studio .NET 2003.
12105 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12107 * expression.cs: Fix bug #47234. We basically need to apply the
12108 rule that we prefer the conversion of null to a reference type
12109 when faced with a conversion to 'object' (csc behaviour).
12111 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12113 * statement.cs: Shorter form for foreach, eliminates
12114 a local variable. r=Martin.
12116 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12118 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12119 checks if we can use brtrue/brfalse to test for 0.
12120 * expression.cs: use the above in the test for using brtrue/brfalse.
12121 cleanup code a bit.
12123 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12125 * expression.cs: Rewrite string concat stuff. Benefits:
12127 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12128 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12129 rather than a concat chain.
12131 * typemanager.cs: Add lookups for more concat overloads.
12133 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12135 * expression.cs: Emit shorter il code for array init.
12152 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12154 * statement.cs: Before, two switch blocks would be merged if the
12155 total size of the blocks (end_item - begin_item + 1) was less than
12156 two times the combined sizes of the blocks.
12158 Now, it will only merge if after the merge at least half of the
12163 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12165 * class.cs : csc build fix for GetMethods(). See bug #52503.
12167 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12169 * expression.cs: Make sure fp comparisons work with NaN.
12170 This fixes bug #54303. Mig approved this patch a long
12171 time ago, but we were not able to test b/c the runtime
12174 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12176 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12178 2004-03-19 Martin Baulig <martin@ximian.com>
12180 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12181 two overloads may unify for some type parameter substitutions and
12182 report a CS0408 if appropriate.
12184 2004-03-19 Martin Baulig <martin@ximian.com>
12186 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12187 error here and not in our caller.
12189 2004-03-19 Martin Baulig <martin@ximian.com>
12191 * interface.cs: Completely killed this file.
12192 (Interface): We're now a TypeContainer and live in class.cs.
12194 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12195 argument; we're now also called for interfaces.
12196 (TypeContainer.DefineMembers): Allow this method being called
12198 (TypeContainer.GetMethods): New public method; formerly known as
12199 Interface.GetMethod(). This is used by PendingImplementation.
12200 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12201 it's now private and non-static.
12202 (Interface): Moved this here; it's now implemented similar to
12204 (Method, Property, Event, Indexer): Added `bool is_interface'
12205 argument to their .ctor's.
12206 (MemberBase.IsInterface): New public field.
12208 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12209 instances instead of InterfaceMethod, InterfaceProperty, etc.
12210 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12211 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12213 2004-03-19 Martin Baulig <martin@ximian.com>
12215 * class.cs (MethodCore.IsDuplicateImplementation): New private
12216 method which does the CS0111 checking.
12217 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12218 Use IsDuplicateImplementation().
12220 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12222 * decl.cs (FindMemberToOverride): New method to find the correct
12223 method or property to override in the base class.
12225 - Make Method/Property use the above method to find the
12226 version in the base class.
12227 - Remove the InheritableMemberSignatureCompare as it is now
12230 This patch makes large code bases much faster to compile, as it is
12231 O(n) rather than O(n^2) to do this validation.
12233 Also, it fixes bug 52458 which is that nested classes are not
12234 taken into account when finding the base class member.
12236 Reviewed/Approved by Martin.
12238 2004-03-17 Martin Baulig <martin@ximian.com>
12240 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12241 of type arguments into account; use the `real_num_type_args'
12242 approach like in DoResolveAsTypeStep().
12244 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12247 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12249 * interface.cs: In all interface classes removed redundant
12250 member initialization.
12252 2004-03-16 Martin Baulig <martin@ximian.com>
12254 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12256 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12258 * decl.cs (DefineTypeAndParents): New helper method to define a
12259 type's containers before the type itself is defined; This is a
12260 bug exposed by the recent changes to Windows.Forms when an
12261 implemented interface was defined inside a class that had not been
12264 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12266 (Check): Loop correctly to report errors modifiers
12267 (UNSAFE was not in the loop, since it was the same as TOP).
12269 * interface.cs: Every interface member now takes a ModFlags,
12270 instead of a "is_new" bool, which we set on the base MemberCore.
12272 Every place where we called "UnsafeOk" in the interface, now we
12273 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12274 the unsafe settings from the member declaration instead of the
12275 container interface.
12277 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12279 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12280 `set_indexer_name' to the pending bits (one per type).
12282 We fixed a bug today that was picking the wrong method to
12283 override, since for properties the existing InterfaceMethod code
12284 basically ignored the method name. Now we make sure that the
12285 method name is one of the valid indexer names.
12287 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12289 * support.cs (SeekableStreamReader): Keep track of stream byte
12290 positions and don't mix them with character offsets to the buffer.
12292 Patch from Gustavo Giráldez
12294 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12296 * interface.cs (InterfaceSetGetBase): Removed double member
12297 initialization, base class does it as well.
12299 2004-03-13 Martin Baulig <martin@ximian.com>
12301 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12302 when compiling corlib.
12304 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12306 * convert.cs (ExplicitConversion): We were reporting an error on
12307 certain conversions (object_type source to a value type, when the
12308 expression was `null') before we had a chance to pass it through
12309 the user defined conversions.
12311 * driver.cs: Replace / and \ in resource specifications to dots.
12314 * class.cs: Add check for duplicate operators. Fixes 52477
12316 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12318 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12319 that are in the middle of the statements, not only at the end.
12322 * class.cs (TypeContainer.AddField): No longer set the
12323 `HaveStaticConstructor' flag, now we call it
12324 `UserDefineStaticConstructor' to diferentiate the slightly
12325 semantic difference.
12327 The situation is that we were not adding BeforeFieldInit (from
12328 Modifiers.TypeAttr) to classes that could have it.
12329 BeforeFieldInit should be set to classes that have no static
12334 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12336 And most importantly Zoltan's comment:
12338 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12340 "I think beforefieldinit means 'it's ok to initialize the type sometime
12341 before its static fields are used', i.e. initialization does not need
12342 to be triggered by the first access to the type. Setting this flag
12343 helps the JIT to compile better code, since it can run the static
12344 constructor at JIT time, and does not need to generate code to call it
12345 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12346 this flag for lots of classes like String.
12348 csc sets this flag if the type does not have an explicit static
12349 constructor. The reasoning seems to be that if there are only static
12350 initalizers for a type, and no static constructor, then the programmer
12351 does not care when this initialization happens, so beforefieldinit
12354 This bug prevents the AOT compiler from being usable, since it
12355 generates so many calls to mono_runtime_class_init that the AOT code
12356 is much slower than the JITted code. The JITted code is faster,
12357 because it does not generate these calls if the vtable is type is
12358 already initialized, which is true in the majority of cases. But the
12359 AOT compiler can't do this."
12361 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12363 * class.cs (MethodData.Emit): Refactor the code so symbolic
12364 information is generated for destructors; For some reasons we
12365 were taking a code path that did not generate symbolic information
12368 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12370 * class.cs: Create a Constructor.CheckBase method that
12371 takes care of all validation type code. The method
12372 contains some code that was moved from Define.
12374 It also includes new code that checks for duplicate ctors.
12375 This fixes bug #55148.
12377 2004-03-09 Joshua Tauberer <tauberer@for.net>
12379 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12380 a { ... }-style array creation invokes EmitStaticInitializers
12381 which is not good for reference-type arrays. String, decimal
12382 and now null constants (NullCast) are not counted toward
12383 static initializers.
12385 2004-03-05 Martin Baulig <martin@ximian.com>
12387 * location.cs (SourceFile.HasLineDirective): New public field;
12388 specifies whether the file contains or is referenced by a "#line"
12390 (Location.DefineSymbolDocuments): Ignore source files which
12391 either contain or are referenced by a "#line" directive.
12393 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12395 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12396 direct access to our parent, so check the method inline there.
12398 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12400 * expression.cs (Invocation.EmitCall): Miguel's last commit
12401 caused a regression. If you had:
12406 In Foo the implict this would be null.
12408 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12410 * expression.cs (Invocation.EmitCall): If the method is not
12411 virtual, do not emit a CallVirt to it, use Call.
12413 * typemanager.cs (GetFullNameSignature): Improve the method to
12414 cope with ".ctor" and replace it with the type name.
12416 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12417 as an argument the ConstructorBuilder where it is being defined,
12418 to catch the recursive constructor invocations.
12420 2004-03-16 Martin Baulig <martin@ximian.com>
12422 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12423 ConstructedType, call ResolveType() on it to get the type rather
12424 than just using `expr.Type'.
12426 2004-03-16 Martin Baulig <martin@ximian.com>
12428 * generics.cs (ConstructedType.GetMemberAccess): Take the
12429 EmitContext instead on the TypeExpr and use
12430 ec.TypeContainer.CurrentType/ec.ContainerType.
12432 2004-03-16 Martin Baulig <martin@ximian.com>
12434 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12435 parameters before aliases.
12437 2004-03-16 Martin Baulig <martin@ximian.com>
12439 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12440 New oublic function; checks whether two generic instances may become
12441 equal under some instantiations (26.3.1).
12443 * class.cs (TypeContainer.Define): Call
12444 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12447 2004-03-16 Martin Baulig <martin@ximian.com>
12449 * class.cs (TypeContainer.GetClassBases): Moved
12450 Error_TypeParameterAsBase() here and also check whether the base
12451 class is not an attribute.
12453 2004-03-16 Martin Baulig <martin@ximian.com>
12455 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12457 2004-03-16 Martin Baulig <martin@ximian.com>
12459 * class.cs (Error_TypeParameterAsBase): Use correct error number
12462 2004-03-16 Martin Baulig <martin@ximian.com>
12464 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12467 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12470 2004-03-15 Martin Baulig <martin@ximian.com>
12472 * typemanager.cs (TypeManager.GetFullName): New public method.
12473 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12474 argument; only return members with the correct number of type
12476 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12477 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12478 whether the number of type arguments matches.
12480 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12481 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12483 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12484 field; it's set by the protected .ctor when we're actually a
12485 GenericMemberAccess.
12486 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12487 arguments and pass it to MemberLookupFinal ().
12489 * ecore.cs (Expression.MemberLookup): Added `int
12490 num_type_arguments' argument; only return members with the correct
12491 number of type arguments.
12492 (Expression.MemberLookupFailed): Check whether the MemberLookup
12493 failed because we did not have the correct number of type
12494 arguments; report CS0305 in this case.
12496 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12497 `e.ResolveAsTypeTerminal()' already did so.
12499 2004-03-15 Martin Baulig <martin@ximian.com>
12501 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12502 we're a ConstructedType; in this case, the caller must report an
12503 error (for instance CS0131).
12505 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12506 (TypeArguments.Resolve): Actually report errors here.
12508 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12510 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12511 `set_indexer_name' to the pending bits (one per type).
12513 We fixed a bug today that was picking the wrong method to
12514 override, since for properties the existing InterfaceMethod code
12515 basically ignored the method name. Now we make sure that the
12516 method name is one of the valid indexer names.
12518 2004-03-15 Martin Baulig <martin@ximian.com>
12520 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12521 for generic instances.
12523 2004-03-13 Martin Baulig <martin@ximian.com>
12525 * class.cs (TypeContainer.DefineType): Call
12526 TypeManager.AddUserType() immediately after creating the
12527 TypeBuilder; pass all type parameters when creating the
12530 * decl.cs (DeclSpace.FindNestedType): New public method.
12531 (DeclSpace.FindType): Added `int num_type_args' argument; only
12532 return types with the correct number of type parameters.
12533 (DeclSpace.CountTypeParams): New public property.
12535 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12536 the number of type parameters; defaults to zero.
12538 * generic.cs (TypeArguments.Count): New public property.
12539 (ConstructedType.DoResolveAsTypeStep): First call
12540 ds.FindNestedType() to find out whether we're nested in the
12541 current generic type; in this case, we inherit all type parameters
12542 from the current class.
12544 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12545 num_type_args' argument.
12546 (RootContext.LookupType): Added overloaded version which takes the
12547 number of type arguments; only return types with the correct
12548 number of type arguments.
12550 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12551 checks whether `Type t' has `int num_type_args'.
12553 2004-03-13 Martin Baulig <martin@ximian.com>
12555 * generic.cs (GenericMethod.DefineType): New method; calls
12556 DefineType() on all the type parameters.
12558 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12559 (MethodData.Define): If we're a generic method, call
12560 GenericMethod.DefineType() to define the type parameters.
12562 2004-03-10 Martin Baulig <martin@ximian.com>
12564 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12565 instead of IsAssignableFrom.
12567 2004-03-10 Martin Baulig <martin@ximian.com>
12569 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12571 * support.cs (ParameterData.HasArrayParameter): New property.
12572 (ReflectionParameters.ctor): Take a MethodBase instead of a
12573 ParameterInfo[]. If we have any type parameters, get the generic
12574 method definition and ask it whether we have variable arguments.
12576 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12578 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12579 routines to check if a type is an enumerable/enumerator allow
12580 classes that implement the IEnumerable or IEnumerator interfaces.
12582 * class.cs (Property, Operator): Implement IIteratorContainer, and
12583 implement SetYields.
12585 (Property.Define): Do the block swapping for get_methods in the
12586 context of iterators. We need to check if Properties also
12587 include indexers or not.
12589 (Operator): Assign the Block before invoking the
12590 OperatorMethod.Define, so we can trigger the Iterator code
12593 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12594 Property and Operator classes are not created when we parse the
12595 declarator but until we have the block completed, so we use a
12596 singleton SimpleIteratorContainer.Simple to flag whether the
12597 SetYields has been invoked.
12599 We propagate this setting then to the Property or the Operator to
12600 allow the `yield' to function.
12602 2004-02-25 Marek Safar <marek.safar@seznam.cz>
12604 * codegen.cs: Implemented attribute support for modules.
12605 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
12606 Assembly/Module functionality.
12608 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
12609 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
12610 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
12612 2004-02-16 Marek Safar <marek.safar@seznam.cz>
12614 * interface.cs (FindMembers): The operation is performed on all base
12615 interfaces and not only on the first. It is required for future CLS Compliance patch.
12617 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
12619 * statement.cs, codegen.cs:
12620 This patch deals with patterns such as:
12622 public class List : IEnumerable {
12624 public MyEnumerator GetEnumerator () {
12625 return new MyEnumerator(this);
12628 IEnumerator IEnumerable.GetEnumerator () {
12632 public struct MyEnumerator : IEnumerator {
12637 Before, there were a few things we did wrong:
12638 1) we would emit callvirt on a struct, which is illegal
12639 2) we emited ldarg when we needed to emit ldarga
12640 3) we would mistakenly call the interface methods on an enumerator
12641 type that derived from IEnumerator and was in another assembly. For example:
12643 public class MyEnumerator : IEnumerator
12645 Would have the interface methods called, even if there were public impls of the
12646 method. In a struct, this lead to invalid IL code.
12648 2004-02-11 Marek Safar <marek.safar@seznam.cz>
12650 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
12653 * delegate.cs (Define): Fixed crash when delegate type is undefined.
12655 2004-02-11 Miguel de Icaza <miguel@ximian.com>
12657 * cs-parser.jay: Fix small regression: we were not testing V2
12658 compiler features correctly.
12660 * interface.cs: If the emit context is null, then create one
12662 2004-02-09 Marek Safar <marek.safar@seznam.cz>
12664 * decl.cs (GetSignatureForError): New virtual method to get full name
12665 for error messages.
12667 * attribute.cs (IAttributeSupport): New interface for attribute setting.
12668 Now it is possible to rewrite ApplyAttributes method to be less if/else.
12670 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
12671 Duplicated members and code in these classes has been removed.
12672 Better encapsulation in these classes.
12674 2004-02-07 Miguel de Icaza <miguel@ximian.com>
12676 * assign.cs (Assign.DoResolve): When dealing with compound
12677 assignments, there is a new rule in ECMA C# 2.4 (might have been
12678 there before, but it is documented here) that states that in:
12682 If b is of type int, and the `op' is a shift-operator, then the
12683 above is evaluated as:
12687 * expression.cs (Binary.ResolveOperator): Instead of testing for
12688 int/uint/long/ulong, try to implicitly convert to any of those
12689 types and use that in pointer arithmetic.
12691 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
12692 method to print information for from the type, not from the
12693 null-method we were given.
12695 2004-02-01 Duncan Mak <duncan@ximian.com>
12697 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
12698 parsing for cmd, fixes bug #53694.
12700 2004-02-04 Marek Safar <marek.safar@seznam.cz>
12702 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
12703 in the member name duplication tests. Property and operator name duplication
12704 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
12706 2004-02-03 Marek Safar <marek.safar@seznam.cz>
12708 * interface.cs (PopulateMethod): Fixed crash when interface method
12709 returns not existing type (error test cs0246-3.cs).
12711 2004-02-02 Ravi Pratap M <ravi@ximian.com>
12713 * cs-parser.jay (interface_accessors): Re-write actions to also
12714 store attributes attached to get and set methods. Fix spelling
12717 (inteface_property_declaration): Modify accordingly.
12719 (InterfaceAccessorInfo): New helper class to store information to pass
12720 around between rules that use interface_accessors.
12722 * interface.cs (Emit): Apply attributes on the get and set
12723 accessors of properties and indexers too.
12725 * attribute.cs (ApplyAttributes): Modify accordingly to use the
12726 right MethodBuilder when applying attributes to the get and set accessors.
12728 2004-01-31 Miguel de Icaza <miguel@ximian.com>
12730 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
12732 2004-01-26 Miguel de Icaza <miguel@ximian.com>
12734 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
12736 2004-01-25 Miguel de Icaza <miguel@ximian.com>
12738 * cs-parser.jay: Remove YIELD token, instead use the new grammar
12739 changes that treat `yield' specially when present before `break'
12740 or `return' tokens.
12742 * cs-tokenizer.cs: yield is no longer a keyword.
12744 2004-01-23 Marek Safar <marek.safar@seznam.cz>
12746 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
12747 setting for default constructors.
12748 For default constructors are almost every time set wrong Modifier. The
12749 generated IL code has been alright. But inside mcs this values was
12750 wrong and this was reason why several of my CLS Compliance tests
12753 2004-02-27 Martin Baulig <martin@ximian.com>
12755 * generics.cs (ConstructedType.ResolveType): Make the nested type
12756 stuff actually work.
12758 2004-02-25 Martin Baulig <martin@ximian.com>
12760 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
12761 property; returns the type parameters just from the current type,
12762 ie. with the ones from outer classes.
12763 (DeclSpace.LookupGeneric): First search in the current class, then
12765 (DeclSpace.initialize_type_params): When hiding a type parameter
12766 from an outer class, put it into the `type_param_list' anyways.
12768 * expression.cs (MemberAccess.expr): Made this field protected.
12770 * class.cs (TypeContainer.Define): The `CurrentType' just contains
12771 the type parameters from the current class.
12773 * generic.cs (ConstructedType.ResolveType): Support nested generic
12774 types by taking the type parameters which we inherit from outer
12775 classes into account.
12776 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
12777 support for nested generic types.
12779 2004-02-23 Martin Baulig <martin@ximian.com>
12781 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
12782 field and check whether we're nested inside a generic type.
12783 (DeclSpace.ResolveType): If we're resolving to a generic type
12784 definition, create a ConstructedType and return its resolved type.
12785 (DeclSpace.initialize_type_params): New private method;
12786 initializes the `type_param_list' field from the type parameters
12787 from this and all enclosing classes.
12788 (DeclSpace.TypeParameters): Call initialize_type_params() unless
12789 we're already initialized.
12791 2004-02-23 Martin Baulig <martin@ximian.com>
12793 * class.cs (Method.Define): Create the generic method before
12794 calling DoDefine().
12795 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
12796 the TypeContainer one); we use this for generic methods.
12798 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
12799 parent's TypeBuilder.
12801 2004-02-18 Martin Baulig <martin@ximian.com>
12803 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
12804 to check for equality.
12806 2004-02-05 Martin Baulig <martin@ximian.com>
12808 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
12809 `ec.TypeContainer.CurrentType', use it instead of
12810 `ec.ContainerType' to check whether we're in the type's ctor.
12812 2004-01-29 Martin Baulig <martin@ximian.com>
12814 * expression.cs (Invocation.DoResolve): If we're a
12815 `ConstructedType', then we're actually a generic method, so
12816 rewrite the expr as a GenericMemberAccess.
12818 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
12819 here; manually parse it into a string.
12821 2004-01-28 Martin Baulig <martin@ximian.com>
12823 * typemanager.cs (TypeManager.IsEqual): New static method.
12824 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
12825 check for equality instead of using `=='.
12827 2004-01-26 Martin Baulig <martin@ximian.com>
12829 * decl.cs (DeclSpace.CurrentType): New public field.
12831 * expression.cs (This.ResolveBase): If we have an
12832 `ec.TypeContainer.CurrentType', use it instead of
12833 `ec.ContainerType'.
12835 * class.cs (TypeContainer.DefineType): If we're a generic type,
12836 create the `CurrentType' (unresolved).
12837 (TypeContainer.GenericType): New private field.
12838 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
12839 it and store it in `GenericType' before creating the MemberCache.
12840 (TypeContainer.GetMembers): If we have a `GenericType', call
12841 TypeManager.FindMembers() on it.
12843 * interface.cs (Interface.GenericType): New private field.
12844 (Interface.DefineType): If we're a generic type, create the
12845 `CurrentType' (unresolved).
12846 (Interface.DefineMembers): If we have a `CurrentType', resolve it
12847 and store it in `GenericType' before creating the MemberCache.
12848 (Interface.GetMembers): If we have a `GenericType', call
12849 TypeManager.FindMembers() on it.
12851 2004-01-22 Martin Baulig <martin@ximian.com>
12853 * cs-parser.jay (namespace_or_type_name): Return an Expression,
12854 not a QualifiedIdentifier. This is what `type_name_expression'
12855 was previously doing.
12856 (type_name_expression): Removed; the code is now in
12857 `namespace_or_type_name'.
12858 (qualified_identifier): Removed, use `namespace_or_type_name'
12860 (QualifiedIdentifier): Removed this class.
12862 2004-01-22 Martin Baulig <martin@ximian.com>
12864 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
12865 not a string as alias name.
12867 2004-01-21 Miguel de Icaza <miguel@ximian.com>
12869 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
12870 #52730 bug, and instead compute correctly the need to use a
12871 temporary variable when requesting an address based on the
12872 static/instace modified of the field and the constructor.
12874 2004-01-21 Martin Baulig <martin@ximian.com>
12876 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
12877 class and namespace before looking up aliases. Fixes #52517.
12879 2004-01-21 Martin Baulig <martin@ximian.com>
12881 * flowanalysis.cs (UsageVector.Merge): Allow variables being
12882 assinged in a 'try'; fixes exception4.cs.
12884 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12885 * class.cs : Implemented parameter-less constructor for TypeContainer
12887 * decl.cs: Attributes are now stored here. New property OptAttributes
12889 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
12891 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
12893 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12895 * typemanager.cs (CSharpSignature): Now reports also inner class name.
12896 (CSharpSignature): New method for indexer and property signature.
12898 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12900 * pending.cs (IsVirtualFilter): Faster implementation.
12902 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12904 * typemanager.cs: Avoid inclusion of same assembly more than once.
12906 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12908 * cs-parser.jay: Fixed problem where the last assembly attribute
12909 has been applied also to following declaration (class, struct, etc.)
12911 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12913 * class.cs: Added error CS0538, CS0539 reporting.
12914 Fixed crash on Microsoft runtime when field type is void.
12916 * cs-parser.jay: Added error CS0537 reporting.
12918 * pending.cs: Added error CS0535 reporting.
12919 Improved error report for errors CS0536, CS0534.
12921 2004-01-20 Miguel de Icaza <miguel@ximian.com>
12923 Merge a few bits from the Anonymous Method MCS tree.
12925 * statement.cs (ToplevelBlock): New class for toplevel methods,
12926 will hold anonymous methods, lifted variables.
12928 * cs-parser.jay: Create toplevel blocks for delegates and for
12929 regular blocks of code.
12931 2004-01-20 Martin Baulig <martin@ximian.com>
12933 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
12934 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
12935 and `NeedExplicitReturn'; added `IsLastStatement'.
12936 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
12937 have a `ReturnLabel' or we're not unreachable.
12939 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
12940 child's reachability; don't just override ours with it. Fixes
12941 #58058 (lluis's example).
12942 (FlowBranching): Added public InTryOrCatch(), InCatch(),
12943 InFinally(), InLoop(), InSwitch() and
12944 BreakCrossesTryCatchBoundary() methods.
12946 * statement.cs (Return): Do all error checking in Resolve().
12947 Unless we are the last statement in a top-level block, always
12948 create a return label and jump to it.
12949 (Break, Continue): Do all error checking in Resolve(); also make
12950 sure we aren't leaving a `finally'.
12951 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
12952 statement in a top-level block.
12953 (Block.Flags): Added `IsDestructor'.
12954 (Block.IsDestructor): New public property.
12956 2004-01-20 Martin Baulig <martin@ximian.com>
12958 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
12960 2004-01-20 Martin Baulig <martin@ximian.com>
12962 * statement.cs (Statement.ResolveUnreachable): New public method.
12963 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
12964 (Block.Resolve): Resolve unreachable statements.
12966 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
12968 * expression.cs: We need to fix the case where we do
12969 not have a temp variable here.
12971 * assign.cs: Only expression compound assignments need
12972 temporary variables.
12974 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
12976 * flowanalysis.cs: Reduce memory allocation in a few ways:
12977 - A block with no variables should not allocate a bit
12979 - A method with no out parameters does not need any tracking
12980 for assignment of the parameters, so we need not allocate
12983 public readonly Type[] VariableTypes;
12984 public readonly string[] VariableNames;
12985 Are redundant. The data is already stored in the variable
12986 map, so we need not allocate another array for it.
12987 - We need to add alot of checks for if (params | locals) == null
12988 due to the first two changes.
12990 2004-01-18 Miguel de Icaza <miguel@ximian.com>
12992 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
12993 implement IMemoryLocation, we store a copy on a local variable and
12994 take the address of it. Patch from Benjamin Jemlich
12996 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
12997 to use a special "type_name_expression" rule which reduces the
12998 number of "QualifiedIdentifier" classes created, and instead
12999 directly creates MemberAccess expressions.
13001 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13003 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13004 that fixes #52853. Null literal assignment to ValueType
13006 * class.cs (MethodData.Emit): Instead of checking the name of the
13007 method to determine if its a destructor, create a new derived
13008 class from Method called Destructor, and test for that.
13010 * cs-parser.jay: Create a Destructor object instead of a Method.
13012 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13016 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13018 * expression.cs (Binary.ResolveOperator): Perform an implicit
13019 conversion from MethodGroups to their delegate types on the
13020 Addition operation.
13022 * delegate.cs: Introduce a new class DelegateCreation that is the
13023 base class for `NewDelegate' and `ImplicitDelegateCreation',
13024 factor some code in here.
13026 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13027 conversion from MethodGroups to compatible delegate types.
13029 * ecore.cs (Expression.Resolve): Do not flag error 654
13030 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13031 we allow conversions from MethodGroups to delegate types now.
13033 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13034 assignments in v2 either.
13036 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13038 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13039 static read-only fields in ctors.
13041 Applied patch from Benjamin Jemlich
13043 * expression.cs (UnaryMutator): Avoid leaking local variables.
13045 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13047 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13048 here to return true, as they can be used like this:
13050 (XXX) int.MEMBER ()
13052 Fixed 49836 and all the other dups
13054 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13056 * driver.cs: Implement /win32res and /win32icon.
13058 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13060 * cs-parser.jay: Add a rule to improve error handling for the
13061 common mistake of placing modifiers after the type.
13063 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13065 * cs-parser.jay (interface_event_declaration): Catch
13066 initialization of events on interfaces, and report cs0068
13068 * cs-parser.jay (interface_event_declaration): Catch
13069 initialization of events.
13071 * ecore.cs: Better report missing constructors.
13073 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13074 the error reporting done in the wrong place. Fix.
13076 * expression.cs (Binary.ResolveOperator): Catch the
13077 operator + (E x, E y) error earlier, and later allow for implicit
13078 conversions in operator +/- (E e, U x) from U to the underlying
13081 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13082 52596, if the container class is abstract, the default constructor
13083 is protected otherwise its public (before, we were always public).
13085 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13088 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13089 Jemlich that fixes bug #52597, MCS was generating invalid code for
13090 idisposable structs. Thanks to Ben for following up with this
13093 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13095 * driver.cs: Allow assemblies without code to be generated, fixes
13098 2004-01-07 Nick Drochak <ndrochak@gol.com>
13100 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13102 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13104 * cs-parser.jay: Add rules to improve error reporting if fields or
13105 methods are declared at the namespace level (error 116)
13107 * Add rules to catch event add/remove
13109 2004-01-04 David Sheldon <dave-mono@earth.li>
13111 * expression.cs: Added matching ")" to error message for
13114 2004-01-03 Todd Berman <tberman@gentoo.org>
13116 * ecore.cs, attribute.cs:
13117 Applying fix from #52429.
13119 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13121 * ecore.cs, expression.cs, statement.cs:
13122 Total rewrite of how we handle branching. We
13123 now handle complex boolean expressions with fewer
13124 jumps. As well if (x == 0) no longer emits a ceq.
13126 if (x is Foo) is much faster now, because we generate
13129 Overall, we get a pretty big improvement on our benchmark
13130 tests. The code we generate is smaller and more readable.
13132 I did a full two-stage bootstrap. The patch was reviewed
13133 by Martin and Miguel.
13135 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13137 * cs-parser.jay: Make primary_expression not take a QI.
13138 we dont need this because the member_access rule covers
13139 us here. So we replace the rule with just IDENTIFIER.
13141 This has two good effects. First, we remove a s/r conflict.
13142 Second, we allocate many fewer QualifiedIdentifier objects.
13144 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13146 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13147 set the correct information via SRE. This prevents
13148 hanging on the MS runtime. Fixes #29374.
13150 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13152 * convert.cs: correctly handle conversions to value types
13153 from Enum and ValueType as unboxing conversions.
13155 Fixes bug #52569. Patch by Benjamin Jemlich.
13157 2004-01-02 Ravi Pratap <ravi@ximian.com>
13159 * expression.cs (BetterConversion): Prefer int -> uint
13160 over int -> ulong (csc's behaviour). This fixed bug #52046.
13162 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13164 * decl.cs (MemberCache.FindMembers): now returns a
13167 * typemanager.cs: In general, go with with ^^.
13168 (CopyNewMethods): take an IList.
13169 (RealMemberLookup): Only allocate an arraylist
13170 if we copy from two sets of methods.
13172 This change basically does two things:
13173 1) Fewer array lists allocated due to CopyNewMethods.
13174 2) the explicit cast in MemberList costed ALOT.
13176 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13178 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13179 a hashtable to avoid needless string allocations when an identifier is
13180 used more than once (the common case).
13182 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13184 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13185 is broken, it will not return anything. So, we
13186 have to use the information we have in mcs to
13189 * typemanager.cs: Add a cache for GetInterfaces,
13190 since this will now be used more often (due to ^^)
13192 (GetExplicitInterfaces) New method that gets the
13193 declared, not effective, interfaces on a type
13194 builder (eg, if you have interface IFoo, interface
13195 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13198 This patch makes MCS able to bootstrap itself on
13201 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13203 * expression.cs: Remove the Nop's that Miguel put
13206 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13208 * report.cs, codegen.cs: Give the real stack trace to
13209 the error when an exception is thrown.
13211 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13213 * decl.cs: only allocate hashtables for ifaces if
13216 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13218 * expression.cs: fix the error from cs0121-2.cs
13219 (a parent interface has two child interfaces that
13220 have a function with the same name and 0 params
13221 and the function is called through the parent).
13223 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13225 * class.cs, rootcontext.cs, typmanager.cs: do not
13228 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13230 * codegen.cs: remove stack for the ec flow branching.
13231 It is already a linked list, so no need.
13233 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13235 * Makefile: Allow custom profiler here.
13237 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13239 * typemanager.cs (LookupType):
13240 - Use a static char [], because split takes
13241 a param array for args, so it was allocating
13243 - Do not store true in a hashtable, it boxes.
13245 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13247 * flowanalysis.cs: bytify common enums.
13249 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13251 * modifiers.cs: Add a new set of flags for the
13252 flags allowed on explicit interface impls.
13253 * cs-parser.jay: catch the use of modifiers in
13254 interfaces correctly.
13255 * class.cs: catch private void IFoo.Blah ().
13257 All related to bug #50572.
13259 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13261 * decl.cs: Rewrite the consistant accessability checking.
13262 Accessability is not linear, it must be implemented in
13263 a tableish way. Fixes #49704.
13265 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13267 * expression.cs: Handle negation in a checked context.
13268 We must use subtraction from zero. Fixes #38674.
13270 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13272 * class.cs: Ignore static void main in DLLs.
13273 * rootcontext.cs: Handle the target type here,
13274 since we are have to access it from class.cs
13275 * driver.cs: account for the above.
13277 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13279 * report.cs: Give line numbers and files if available.
13281 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13283 * driver.cs: Implement /addmodule.
13285 * typemanager.cs: Change 'modules' field so it now contains Modules not
13288 2003-12-20 Martin Baulig <martin@ximian.com>
13290 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13291 (FieldBase.IsAssigned): Removed this field.
13292 (FieldBase.SetAssigned): New public method.
13293 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13295 2003-12-20 Martin Baulig <martin@ximian.com>
13297 * expression.cs (LocalVariableReference.DoResolve): Don't set
13298 `vi.Used' if we're called from DoResolveLValue().
13300 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13301 returns the usage vector it just merged into the current one -
13302 pass this one to UsageWarning().
13303 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13304 of the `EmitContext', don't call this recursively on our children.
13306 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13308 * driver.cs: Implement /target:module.
13310 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13312 * support.cs (CharArrayHashtable): New helper class.
13314 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13315 char arrays, not strings, so we can avoid creating a string in
13316 consume_identifier if the identifier is a keyword.
13318 2003-12-16 Martin Baulig <martin@ximian.com>
13320 * statement.cs (LocalInfo.Assigned): Removed this property.
13321 (LocalInfo.Flags): Removed `Assigned'.
13322 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13323 and uses flow analysis.
13324 (Block.UsageWarning): Made this method private.
13325 (Block.Resolve): Call UsageWarning() if appropriate.
13327 * expression.cs (LocalVariableReference.DoResolve): Always set
13328 LocalInfo.Used here.
13330 2003-12-13 Martin Baulig <martin@ximian.com>
13332 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13333 any value here; we're now using flow analysis to figure out
13334 whether a statement/block returns a value.
13336 2003-12-13 Martin Baulig <martin@ximian.com>
13338 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13340 (FlowBranching.MergeFinally): Don't call
13341 `branching.CheckOutParameters()' here, this is called in
13343 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13344 when adding the `finally' vector.
13346 2003-12-13 Martin Baulig <martin@ximian.com>
13349 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13350 actually work and also fix #48962.
13352 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13354 * decl.cs: Do not check System.Object for nested types,
13355 since we know it does not have any. Big bang for buck:
13358 Run 1: 8.35 seconds
13359 Run 2: 8.32 seconds
13360 corlib: 17.99 seconds
13362 Run 1: 8.17 seconds
13363 Run 2: 8.17 seconds
13364 corlib: 17.39 seconds
13366 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13368 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13369 time we are returning 0 members, so we save alot here.
13371 2003-12-11 Martin Baulig <martin@ximian.com>
13373 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13374 `MergeChild()', also just take the `FlowBranching' as argument;
13375 call Merge() on it and return the result.
13376 (FlowBranching.Merge): We don't need to do anything if we just
13379 2003-12-11 Martin Baulig <martin@ximian.com>
13381 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13382 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13383 Maurer for this idea.
13385 2003-12-11 Martin Baulig <martin@ximian.com>
13387 * flowanalysis.cs (MergeResult): This class is now gone; we now
13388 use the `UsageVector' for this. The reason for this is that if a
13389 branching just has one sibling, we don't need to "merge" them at
13390 all - that's the next step to do.
13391 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13394 2003-12-11 Martin Baulig <martin@ximian.com>
13396 Reworked flow analyis and made it more precise and bug-free. The
13397 most important change is that we're now using a special `Reachability'
13398 class instead of having "magic" meanings of `FlowReturns'. I'll
13399 do some more cleanups and optimizations and also add some more
13400 documentation this week.
13402 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13403 largely reworked this class.
13404 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13405 the new `Reachability' class instead of having "magic" values here.
13406 (FlowBranching): We're now using an instance of `Reachability'
13407 instead of having separate `Returns', `Breaks' etc. fields.
13409 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13410 based on flow analysis; ignore the return value of block.Emit ().
13412 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13414 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13415 if they are private.
13417 2003-12-09 Martin Baulig <martin@ximian.com>
13419 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13420 call them directly on the UsageVector.
13422 2003-12-09 Martin Baulig <martin@ximian.com>
13424 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13425 Changed return type from `FlowReturns' to `Reachability'.
13427 2003-12-09 Martin Baulig <martin@ximian.com>
13429 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13430 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13431 `Reachable' fields with a single `Reachability' one.
13433 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13435 * class.cs (FindMembers): Remove foreach's.
13440 Run 1: 8.74 seconds
13441 Run 2: 8.71 seconds
13444 Run 1: 8.64 seconds
13445 Run 2: 8.58 seconds
13448 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13453 This patch does a few things:
13454 1. EmptyStatement is now a singleton, so it is never reallocated.
13455 2. All blah is EmptyStatement constructs have been changed to
13456 blah == EmptyStatement.Value, which is much faster and valid
13457 now that EmptyStatement is a singleton.
13458 3. When resolving a block, rather than allocating a new array for
13459 the non-empty statements, empty statements are replaced with
13460 EmptyStatement.Value
13461 4. Some recursive functions have been made non-recursive.
13462 Mainly the performance impact is from (3), however (1) and (2) are needed for
13463 this to work. (4) does not make a big difference in normal situations, however
13464 it makes the profile look saner.
13469 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13470 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13471 Total memory allocated: 56397 KB
13474 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13475 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13476 Total memory allocated: 55666 KB
13478 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13480 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13481 than the hashtable in a hashtable version
13483 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13484 we always end up concating a string. This results in a huge perf
13485 loss, because many strings have to be tracked by the GC. In this
13486 patch, we first use a hashtable that works with two keys, so that
13487 the strings do not need to be concat'ed.
13491 Run 1: 8.74 seconds
13492 Run 2: 8.71 seconds
13495 Run 1: 8.65 seconds
13496 Run 2: 8.56 seconds
13498 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13500 * Makefile: Add a new target `do-time' that does a quick and simple
13501 profile, leaving easy to parse output.
13503 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13505 * codegen.cs (Init): Create the dynamic assembly with
13506 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13508 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13510 * support.cs: Make the PtrHashtable use only one
13511 instance of its comparer.
13513 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13515 * typemanager.cs: Fix lookup of GetNamespaces.
13517 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13519 * expression.cs: Removed redundant line.
13521 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13522 ArrayLists, use for loops with bounds.
13524 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13527 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13528 arraylists, use for loop with bounds.
13530 The above three changes give us a 0.071 second performance
13531 improvement out of 3.294 seconds down to 3.223. On my machine
13532 the above changes reduced the memory usage by 1,387 KB during
13533 compiler bootstrap.
13535 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13536 QualifiedIdentifiers. Before we created a new string through
13537 concatenation, and mostly later on, the result would be
13538 manipulated by DecomposeQI through string manipulation.
13540 This reduced the compiler memory usage for bootstrapping from
13541 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13542 compile times in 0.05 seconds.
13544 2003-11-28 Dick Porter <dick@ximian.com>
13546 * support.cs: Do string compares with the Invariant culture.
13554 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13555 the comparison is done with the Invariant culture.
13557 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13559 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13560 GetEnumerator method.
13562 (ProbeCollectionType): Iterate starting at the most specific type
13563 upwards looking for a GetEnumerator
13565 * expression.cs: Shift count can be up to 31 for int/uint and 63
13568 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13570 * statement.cs (Block.LookupLabel): Also look for the label on the
13571 children blocks. Use a hash table to keep track of visited
13574 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13575 we actually did transform the other operand, otherwise fall back
13576 to the common codepath that casts to long.
13578 * cs-tokenizer.cs: Use the same code pattern as the int case.
13579 Maybe I should do the parsing myself, and avoid depending on the
13580 Parse routines to get this done.
13582 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13584 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13585 which fixes bug 51347. This time test it.
13587 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13588 attributes for example can not tell the difference between these.
13589 The difference was only a syntax feature of the language.
13591 * attribute.cs: Apply attributes to delegates.
13593 * delegate.cs: Call the apply attributes method.
13595 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13597 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13598 comparing 0 vs Byte.MinValue, not the value
13600 (ImplicitConversionRequired): When reporting a conversion error,
13601 use error 31 to print out the constant error instead of the
13604 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13605 which fixes bug 51347.
13607 2003-11-22 Miguel de Icaza <miguel@ximian.com>
13609 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
13610 which fixes the -warnaserror command line option.
13612 2003-11-21 Miguel de Icaza <miguel@ximian.com>
13614 * cfold.cs (DoNumericPromotions): During constant folding of
13615 additions on UIntConstant, special case intconstants with
13616 IntConstants like we do on the expression binary operator.
13618 2003-11-12 Miguel de Icaza <miguel@ximian.com>
13620 * convert.cs (ImplicitReferenceConversion): We were missing a case
13621 (System.Enum are not value types or class types, so we need to
13622 classify them separatedly).
13624 * driver.cs: We do not support error 2007.
13626 2003-11-12 Jackson Harper <jackson@ximian.com>
13628 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
13629 system directory. Also use the full file name so users can
13630 libraries names mscorlib-o-tron.dll in a non system dir.
13632 2004-01-04 David Sheldon <dave-mono@earth.li>
13634 * expression.cs: Added matching ")" to error message for CS0077.
13636 2003-12-19 Martin Baulig <martin@ximian.com>
13638 * typemanager.cs (TypeManager.IsEqualGenericType): New public
13639 static method; see documentation in the method.
13640 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
13642 * convert.cs (Convert.ImplicitReferenceConversion,
13643 Convert.ImplicitReferenceConversionExists): Add support for
13644 generic type declarations; see gen-36.cs.
13646 2003-12-19 Martin Baulig <martin@ximian.com>
13648 * pending.cs (Pending.InterfaceMethod): Use
13649 `Type.IsAssignableFrom()' instead of `=='.
13651 2003-12-18 Martin Baulig <martin@ximian.com>
13653 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
13656 * convert.cs (Convert.ImplicitStandardConversionExists): Use
13657 `expr_type.Equals (target_type)' instead of `=='.
13659 2003-12-08 Martin Baulig <martin@ximian.com>
13661 * generics.cs (Constraints.Types): Removed.
13662 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
13664 (Constraints.ResolveTypes): New public method; resolves the
13665 TypeExpr's to Type's.
13666 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
13667 longer takes the constraints.
13668 (TypeParameter.DefineMethod): Likewise.
13669 (TypeParameter.DefineType): New public method. Calls
13670 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
13673 2003-12-08 Martin Baulig <martin@ximian.com>
13675 * convert.cs (Convert.ImplicitConversionStandard): Use
13676 `expr_type.Equals (target_type)' instead of `=='.
13678 2003-12-08 Martin Baulig <martin@ximian.com>
13680 * typemanager.cs (TypeManager.GetReferenceType): Call
13681 `Type.MakeByRefType ()'.
13683 2003-12-08 Martin Baulig <martin@ximian.com>
13685 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
13686 just has some special meaning in some situations. For instance,
13687 it is allowed to use `where' as the name of a variable etc.
13689 2003-12-04 Martin Baulig <martin@ximian.com>
13691 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13692 `Type.MakeArrayType()' for array types.
13694 2003-11-18 Miguel de Icaza <miguel@ximian.com>
13696 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
13699 (SizeOf.DoResolve): assign the `type_queried' field. This gets
13702 2003-11-16 Martin Baulig <martin@ximian.com>
13704 * codegen.cs (EmitContext.IsGeneric): Removed.
13706 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
13707 ResolveGeneric() on the DeclSpace.
13709 2003-11-16 Martin Baulig <martin@ximian.com>
13711 * generic.cs (TypeArguments.Resolve):
13712 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
13713 `ResolveType()' on it to get the Type.
13715 2003-11-15 Martin Baulig <martin@ximian.com>
13717 * generic.cs (ConstructedType.GetInterfaces): Override this.
13719 2003-11-14 Martin Baulig <martin@ximian.com>
13721 * interface.cs (Interface.DefineType): Define all type parameters
13722 before adding the interfaces we inherit.
13724 2003-11-11 Martin Baulig <martin@ximian.com>
13726 * generic.cs (ConstructedType.ResolveType): Always call
13727 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
13729 2003-11-10 Martin Baulig <martin@ximian.com>
13731 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
13732 (TypeManager.InitCoreTypes): Initialize them here, but instead of
13733 calling `ResolveType()' on them, directly assign their `Type'.
13735 2003-11-08 Martin Baulig <martin@ximian.com>
13737 * generic.cs (ConstructedType): Override `IsClass' etc.
13739 2003-11-08 Martin Baulig <martin@ximian.com>
13741 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
13742 return value and the `out parent' parameter.
13743 (TypeContainer.DefineType): Moved the CS0644 check into
13744 GetClassBases(). Don't pass the interface types to the
13745 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
13746 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
13748 * ecore.cs (TypeExpr.IsAttribute): New property.
13749 (TypeExpr.GetInterfaces): New method.
13751 * interface.cs (Interface.GetInterfaceTypeByName): Return a
13752 TypeExpr instead of a Type.
13753 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
13754 (Interface.DefineType): Don't pass the interface types to the
13755 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
13756 them later and then call `TypeBulider.AddInterfaceImplementation()'.
13758 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
13759 instead of a `Type[]'.
13760 (TypeManager.RegisterBuilder): Likewise.
13761 (TypeManager.AddUserInterface): Likewise.
13762 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
13763 `Type[]' and also return a `TypeExpr[]'.
13764 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
13766 2003-11-08 Martin Baulig <martin@ximian.com>
13768 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
13771 2003-11-08 Martin Baulig <martin@ximian.com>
13773 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
13774 TypeManager.ResolveExpressionTypes().
13776 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
13777 instead of an Expression.
13778 (TypeExpr): This is now an abstract base class for `TypeExpression'.
13779 (TypeExpression): New public class; formerly known as `TypeExpr'.
13781 * expression.cs (ComposedCast): Derive from TypeExpr.
13783 * typemanager.cs (TypeManager.system_*_expr): These are now
13784 TypExpr's instead of Expression's.
13785 (TypeManager.ResolveExpressionTypes): New public static function;
13786 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
13789 2003-11-06 Miguel de Icaza <miguel@ximian.com>
13791 * expression.cs (New.DoResolve): Do not dereference value that
13792 might be a null return.
13794 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
13795 sure that the constant value has the right type. Fixes an
13796 unreported bug, similar to 50425.
13798 * const.cs (Const.LookupConstantValue): Call
13799 ImplicitStandardConversionExists before doing a conversion to
13800 avoid havng the TypeManager.ChangeType do conversions.
13802 Reduced the number of casts used
13804 (Const.ChangeType): New routine to enable reuse of the constant
13805 type changing code from statement.
13807 * typemanager.cs (ChangeType): Move common initialization to
13808 static global variables.
13812 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
13813 every value type to go through, even if it was void. Fix that.
13815 * cs-tokenizer.cs: Use is_identifier_start_character on the start
13816 character of the define, and the is_identifier_part_character for
13817 the rest of the string.
13819 2003-11-05 Miguel de Icaza <miguel@ximian.com>
13821 * expression.cs (UnaryMutator.EmitCode): When I updated
13822 LocalVariableReference.DoResolve, I overdid it, and dropped an
13823 optimization done on local variable references.
13825 2003-11-04 Miguel de Icaza <miguel@ximian.com>
13827 * ecore.cs: Convert the return from Ldlen into an int.
13829 2003-10-20 Miguel de Icaza <miguel@ximian.com>
13831 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
13832 the accessibility, this is a special case for toplevel non-public
13833 classes (internal for instance).
13835 2003-10-20 Nick Drochak <ndrochak@gol.com>
13837 * ecore.cs: Fix typo and build. Needed another right paren.
13839 2003-10-19 Miguel de Icaza <miguel@ximian.com>
13841 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
13842 `internal' case regular and protected, but not allowing protected
13843 to be evaluated later. Bug 49840
13845 2003-10-15 Miguel de Icaza <miguel@ximian.com>
13847 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
13848 to kb.Nlast, and not the kb.nFirst to isolate the switch
13851 Extract the underlying type, so enumerations of long/ulong are
13852 treated like long/ulong.
13854 2003-10-14 Miguel de Icaza <miguel@ximian.com>
13856 * expression.cs (New): Overload the meaning of RequestedType to
13857 track the possible creation of the NewDelegate type, since
13858 DoResolve is invoked more than once for new constructors on field
13861 See bugs: #48800 and #37014
13863 * cs-parser.jay (declare_local_constants): Take an arraylist
13864 instead of a single constant.
13866 (local_constant_declaration): It should take a
13867 constant_declarators, not a constant_declarator. Fixes 49487
13869 * convert.cs: Fix error report.
13871 2003-10-13 Jackson Harper <jackson@ximian.com>
13873 * typemanager.cs (TypeToCoreType): Add float and double this fixes
13876 2003-11-03 Martin Baulig <martin@ximian.com>
13878 * expression.cs (ArrayAccess.GetStoreOpcode): Added
13879 `out bool has_type_arg'; if set, we need to pass the type to
13881 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
13882 Stelem_Any/Ldelem_Any for generic parameters.
13884 2003-11-02 Martin Baulig <martin@ximian.com>
13886 * expression.cs (Invocation.EmitCall): Use
13887 `TypeManager.IsValueType()' to check whether it's a value type.
13888 Don't set `struct_call' when calling a method on a type parameter.
13890 2003-11-02 Martin Baulig <martin@ximian.com>
13892 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
13893 and removed the TypeBuilder argument.
13895 * typemanager.cs (TypeManager.IsValueType): Return
13896 `t.IsGenericParameter || t.IsValueType'.
13898 2003-10-25 Martin Baulig <martin@ximian.com>
13900 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
13901 call ConstructedType.Resolve() on it.
13903 * generic.cs (ConstructedType.Resolve): Set `type' on success.
13905 2003-10-25 Martin Baulig <martin@ximian.com>
13907 * class.cs (TypeContainer.GetClassBases): Changed
13908 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
13909 CS8214 reporting here.
13910 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
13911 instead of a `Type' for our parent. In case of a recursive
13912 declaration (see tests/gen-23.cs for an example), our parent is a
13913 ConstructedType and it doesn't have its type set. So, first
13914 create our own TypeBuilder, then call constructed.Resolve() to get
13915 the parent's type and finally TypeBuilder.SetParent() it.
13917 * ecore.cs (TypeExpr.Name): New public virtual property.
13920 (ConstructedType): We're now a TypeExpr and not just an Expression.
13921 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
13922 arguments here; this is done later.
13923 (ConstructedType.Resolve): New public method to resolve the type
13924 arguments and bind them.
13926 2003-10-21 Martin Baulig <martin@ximian.com>
13928 * convert.cs: Use `TypeManager.IsValueType' instead of
13929 'type.IsValueType' everywhere.
13931 * typemanager.cs (TypeManager.IsValueType): Return true for type
13932 parameters. The reason for this is that we need to box a type
13933 parameter when converting it to a reference type.
13935 * cs-parser.jay: Added support for default value expressions.
13937 * generics.cs (DefaultValueExpression): New public class.
13939 2003-10-17 Martin Baulig <martin@ximian.com>
13941 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
13942 TypeContainer so we can also use this for Interfaces.
13943 (TypeParameter.Resolve): Likewise.
13945 * interface.cs (Interface.DefineType): Added support for generic
13948 * cs-parser.jay: Added support for generic structs and interfaces.
13950 2003-10-17 Martin Baulig <martin@ximian.com>
13952 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
13953 call generic methods :-)
13955 2003-10-16 Martin Baulig <martin@ximian.com>
13957 * cs-parser.jay (namespace_or_type_name): Only create a
13958 GenericMemberAccess if we actually have type arguments.
13960 2003-10-13 Martin Baulig <martin@ximian.com>
13962 * class.cs (Method.Define): If we're a generic method, call
13963 TypeBuilder.DefineGenericMethod () before resolving
13965 (MethodData): Added .ctor which takes an additional MethodBuilder
13966 argument; this is used for generic methods.
13967 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
13968 we already have a MethodBuilder.
13970 2003-10-10 Martin Baulig <martin@ximian.com>
13972 * class.cs (Method): Added .ctor which takes a `GenericMethod'
13973 instead of a `DeclSpace'. This is used for generic methods.
13975 * cs-parser.jay (method_header): Added support for generic
13976 methods; create a `GenericMethod' instance and pass it to the
13977 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
13978 parameters and locals.
13980 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
13981 since we already have the location. Check whether we're a generic
13982 type declaration or a generic method and create the correct type
13985 * generic.cs (TypeParameter.DefineMethod): New public method.
13986 (GenericMethod): New public class; derives from DeclSpace and is
13987 used for generic methods.
13989 2003-10-09 Martin Baulig <martin@ximian.com>
13991 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
13993 (MethodCore.DoDefineParameters): Removed the TypeContainer
13994 argument; use the DeclSpace which was passed to the .ctor instead.
13995 (MethodCore.CheckParameter): Take a DeclSpace instead of a
13996 TypeContainer; we only need a DeclSpace here.
13998 2003-10-09 Martin Baulig <martin@ximian.com>
14000 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14002 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14003 EmitContext's .ctor.
14005 2003-10-09 Martin Baulig <martin@ximian.com>
14007 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14008 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14009 AsAccessible(), moved them as well.
14011 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14013 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14015 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14016 generation for >=, as spotted by Paolo, bug 48679.
14017 Patch from David Waite.
14019 * cs-tokenizer.cs: Add handling for #pragma.
14021 * cs-parser.jay: Allow for both yield and yield return in the
14022 syntax. The anti-cobolization of C# fight will go on!
14024 * class.cs (TypeBuilder.DefineType): Catch error condition here
14025 (Parent.DefineType erroring out and returning null).
14027 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14028 coping with enumerations variables, we were mistakenly processing
14029 them as a regular value type instead of built-in types. Fixes the
14032 * typemanager.cs (IsBuiltinOrEnum): New method.
14034 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14036 * cs-parser.jay: Upgrade: yield now needs the return clause.
14038 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14040 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14042 2003-09-29 Martin Baulig <martin@ximian.com>
14044 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14045 inflated generic methods.
14047 * generics.cs (ConstructedType): Distinguish between open and
14048 closed constructed types; correctly resolve the arguments.
14050 2003-09-22 Martin Baulig <martin@ximian.com>
14052 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14053 all type arguments meet their constraints.
14055 2003-09-19 Martin Baulig <martin@ximian.com>
14057 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14058 `MemberCache parent' argument. Normally, an interface doesn't
14059 have a parent type except System.Object, but we use this in gmcs
14060 for generic type parameters.
14062 2003-09-18 Martin Baulig <martin@ximian.com>
14064 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14065 on `type.IsInterface'; don't check whether the type has a parent
14066 to determine whether it's an interface.
14068 2003-09-17 Martin Baulig <martin@ximian.com>
14070 * generic.cs (ConstructedType.ToString): Always use `name' as the
14073 2003-09-15 Martin Baulig <martin@ximian.com>
14075 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14077 * generic.cs (Constraints.Resolve): New public method; this is
14078 called to resolve the constraint types and to check whether all
14079 the constraints are correct.
14080 (Constraints.Types): New public property.
14081 (TypeParameter.Resolve): New public method; resolves all the
14082 type's constraints.
14084 * class.cs (TypeContainer.DefineType): Call
14085 TypeParameter.Resolve() before actually defining the type.
14087 2003-09-15 Martin Baulig <martin@ximian.com>
14089 * class.cs (TypeContainer.DefineType): Added an error flag to
14090 avoid reporting duplicate CS0146's ("class definition is
14093 * driver.cs (Driver.MainDriver): Abort if
14094 RootContext.ResolveTree() reported any errors.
14096 2003-09-07 Martin Baulig <martin@ximian.com>
14098 * report.cs (Error, Warning): Added overloaded versions which take
14099 a `params object[] args' and call String.Format().
14101 2003-09-07 Martin Baulig <martin@ximian.com>
14103 * decl.cs (DeclSpace..ctor): Don't call
14104 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14105 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14106 (DeclSpace.RecordDecl): New method.
14108 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14110 2003-09-02 Ravi Pratap <ravi@ximian.com>
14112 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14113 value attributes to be applied to ParameterBuilders.
14115 * class.cs (MethodCore.LabelParameters): Make static and more
14116 generic so that it can be used from other places - like interface
14117 methods, for instance.
14119 * interface.cs (Interface.Emit): Call LabelParameters before
14120 emitting attributes on the InterfaceMethod.
14122 2003-09-07 Martin Baulig <martin@ximian.com>
14124 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14125 if the number of type parameters doesn't match.
14127 2003-09-04 Martin Baulig <martin@ximian.com>
14129 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14130 for arrays of generic type params (ie. `!0[]').
14132 2003-09-04 Martin Baulig <martin@ximian.com>
14134 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14137 2003-09-04 Martin Baulig <martin@ximian.com>
14139 * decl.cs (DeclSpace.LookupGeneric): New method.
14140 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14143 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14144 argument, not just a string.
14145 (TypeParameter.Define): New public method; this is called to
14146 actually define the generic parameter; after this, you can use the
14147 new `Type' property to get the type.
14149 2003-09-04 Martin Baulig <martin@ximian.com>
14151 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14152 is now an ArrayList; initialize the result of the `TypeParameters'
14154 (DeclSpace.GetGenericData): Removed.
14155 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14156 implement this in a different way.
14157 (DeclSpace.GetTypeParameters): Removed; there's now a
14158 `TypeParameters' property.
14159 (DeclSpace.TypeParameters): New public property.
14161 * generic.cs (Constraints): Make this class public.
14162 (TypeParameter): New public class.
14164 2003-09-04 Martin Baulig <martin@ximian.com>
14166 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14167 generic parameters.
14169 * class.cs (TypeContainer.DefineType): Call
14170 TypeBuilder.DefineGenericParameter () on all generic parameters if
14171 this is a generic type.
14173 2003-08-28 Martin Baulig <martin@ximian.com>
14175 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14178 * sample-hello.cs: Compile this with gmcs: "gmcs
14179 /r:sample-stack.dll sample-hello.cs".
14181 2003-08-28 Martin Baulig <martin@ximian.com>
14183 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14184 the parameters to the generic type.
14186 2003-08-28 Martin Baulig <martin@ximian.com>
14188 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14190 2003-08-28 Martin Baulig <martin@ximian.com>
14192 * cs-parser.jay (opt_type_argument_list): Use
14193 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14194 (primary_expression): Replace `qualified_identifier' with `type_name'.
14195 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14197 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14198 parser to check whether it is syntactically a type parameter list;
14199 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14202 2003-08-26 Martin Baulig <martin@ximian.com>
14204 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14205 resolving aliases; fixes #47927.
14207 2003-08-26 Martin Baulig <martin@ximian.com>
14209 * statement.cs (Using.DoResolve): This is internally emitting a
14210 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14211 do not always return. Fixes #47681.
14213 2003-08-26 Martin Baulig <martin@ximian.com>
14215 * decl.cs (MemberCore): Moved WarningNotHiding(),
14216 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14218 (AdditionResult): Make this nested in DeclSpace.
14219 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14220 argument; call NamespaceEntry.Define() unless we're nested in a
14223 * namespace.cs (Namespace.DefineName): New public function. This
14224 is called from DeclSpace's .ctor to add
14225 (Namespace.Lookup): Include DeclSpaces in the lookup.
14227 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14229 * const.cs (Const): Derive from MemberBase, not MemberCore.
14231 2003-08-25 Martin Baulig <martin@ximian.com>
14233 * convert.cs (Convert.ExplicitReferenceConversion): When
14234 converting from an interface type to a class, unbox if the target
14235 type is a struct type. Fixes #47822.
14237 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14239 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14242 2003-08-22 Martin Baulig <martin@ximian.com>
14244 * class.cs (TypeManager.DefineType): When defining a nested type,
14245 call DefineType() on our parent; fixes #47801.
14247 2003-08-22 Martin Baulig <martin@ximian.com>
14249 * class.cs (MethodData.Define): While checking if a method is an
14250 interface implementation, improve the test a bit more to fix #47654.
14252 2003-08-22 Martin Baulig <martin@ximian.com>
14254 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14255 correctly; fixes #47722.
14257 2003-08-22 Martin Baulig <martin@ximian.com>
14259 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14260 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14262 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14264 2003-08-22 Martin Baulig <martin@ximian.com>
14266 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14267 can only be assigned in static constructors. Fixes #47161.
14269 2003-08-22 Martin Baulig <martin@ximian.com>
14271 Rewrote and improved the flow analysis code.
14273 * flowbranching.cs (FlowBranching): Make this class abstract.
14274 (FlowBranching.CreateBranching): New static function to create a
14275 new flow branching.
14276 (FlowBranchingBlock, FlowBranchingException): New classes.
14277 (FlowBranching.UsageVector.Type): New public readonly field.
14278 (FlowBranching.UsageVector.Breaks): Removed the setter.
14279 (FlowBranching.UsageVector.Returns): Removed the setter.
14280 (FlowBranching.UsageVector): Added Break(), Return(),
14281 NeverReachable() and Throw() methods to modify the reachability.
14282 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14283 done by FlowBranching.Merge().
14284 (FlowBranching.UsageVector.MergeChild): New method; merges the
14285 merge result into the current vector.
14286 (FlowBranching.Merge): New abstract method to merge a branching.
14288 2003-08-12 Martin Baulig <martin@ximian.com>
14290 * expression.cs (Indirection.CacheTemporaries): Create the
14291 LocalTemporary with the pointer type, not its element type.
14293 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14295 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14296 token was a keyword or not.
14298 Add `error' options where an IDENTIFIER was expected; Provide
14299 CheckToken and CheckIdentifierToken convenience error reporting
14302 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14304 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14305 NameSpaceEntry NameSpaceEntry.
14307 (LookupInterfaceOrClass): Avoid creating a full qualified name
14308 from namespace and name: avoid doing lookups when we know the
14309 namespace is non-existant. Use new Tree.LookupByNamespace which
14310 looks up DeclSpaces based on their namespace, name pair.
14312 * driver.cs: Provide a new `parser verbose' to display the
14313 exception thrown during parsing. This is turned off by default
14314 now, so the output of a failure from mcs is more graceful.
14316 * namespace.cs: Track all the namespaces defined in a hashtable
14319 (IsNamespace): New method
14321 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14323 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14324 we know that we need to concatenate (full typename can never be
14329 * statement.cs: Use a bitfield; Do not initialize to null things
14330 which are done by the constructor by default.
14332 * cs-parser.jay: bug fix, parameter was 4, not 3.
14334 * expression.cs: Just use the property;
14336 * statement.cs: No need for GetVariableInfo method.
14338 2003-08-08 Martin Baulig <martin@ximian.com>
14340 * flowanalysis.cs (FlowReturns): This is now nested in the
14341 `FlowBranching' class.
14342 (MyBitVector): Moved this here from statement.cs.
14343 (FlowBranching.SiblingType): New enum type.
14344 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14346 2003-08-07 Martin Baulig <martin@ximian.com>
14348 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14349 `FlowBranching' class and called `BranchingType'.
14351 2003-08-07 Martin Baulig <martin@ximian.com>
14353 * flowanalysis.cs: Moved all the control flow analysis code into
14356 2003-08-07 Martin Baulig <martin@ximian.com>
14358 * assign.cs (Assign.DoResolve): `target' must either be an
14359 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14362 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14364 * expression.cs (BinaryMethod): This kind of expression is created by the
14365 Binary class if it determines that the operator has to be handled
14368 (BinaryDelegate): This kind of expression is created if we are
14369 dealing with a + or - operator on delegates.
14371 (Binary): remove method, argumetns, and DelegateOperator: when
14372 dealing with methods,
14374 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14376 * statement.cs (Block): use bitfields for the three extra booleans
14377 we had in use. Remove unused topblock parameter.
14379 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14381 * assign.cs: Drop extra unneeded tests.
14383 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14385 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14387 * statement.cs (Foreach): Use VariableStorage instead of
14390 * codegen.cs (VariableStorage): New class used by clients that
14391 require a variable stored: locals or fields for variables that
14392 need to live across yield.
14394 Maybe provide a convenience api for EmitThis+EmitLoad?
14396 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14399 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14401 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14402 RemapParameterLValue): New methods that are used to turn a
14403 precomputed FieldInfo into an expression like this:
14407 The idea is to use this instead of making LocalVariableReference
14408 have more than one meaning.
14410 * cs-parser.jay: Add error production to BASE.
14412 * ecore.cs: Deal with TypeManager.GetField returning null, which
14413 is now a valid return value.
14415 (FieldExprNoAddress): New expression for Fields whose address can
14418 * expression.cs (LocalVariableReference): During the resolve
14419 phases, create new expressions if we are in a remapping context.
14420 Remove code that dealt with remapping here.
14422 (ParameterReference): same.
14424 (ProxyInstance): New expression, like the `This' expression, but
14425 it is born fully resolved. We know what we are doing, so remove
14426 the errors that are targeted to user-provided uses of `this'.
14428 * statement.cs (Foreach): our variable is now stored as an
14429 Expression; During resolution, follow the protocol, dont just
14430 assume it will return this.
14432 2003-08-06 Martin Baulig <martin@ximian.com>
14434 * support.cs (SeekableStreamReader.cs): New public class.
14436 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14437 SeekableStreamReader instead of the normal StreamReader.
14439 2003-08-04 Martin Baulig <martin@ximian.com>
14441 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14442 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14443 deambiguate casts and delegate invocations.
14444 (parenthesized_expression): Use the new tokens to ensure this is
14445 not a cast of method invocation.
14447 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14448 when reading a `)' and Deambiguate_CloseParens () was previously
14451 * expression.cs (ParenthesizedExpression): New class. This is
14452 just used for the CS0075 test.
14453 (Binary.DoResolve): Check for CS0075.
14455 2003-07-29 Ravi Pratap <ravi@ximian.com>
14457 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14458 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14459 reference comparison.
14461 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14462 examine the ReturnType for equality - this is necessary in the
14463 cases of implicit and explicit operators whose signature also
14464 includes the return type.
14466 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14468 * namespace.cs: Cache the result of the namespace computation,
14469 instead of computing it every time.
14471 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14473 * decl.cs: Use a global arraylist that we reuse over invocations
14474 to avoid excesive memory consumption. Reduces memory usage on an
14475 mcs compile by one meg (45 average).
14477 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14478 private, work around that.
14480 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14482 * literal.cs (IntLiteral): Define Zero and One static literals.
14484 * cs-parser.jay (integer_literal): use static literals to reduce
14485 memory usage for the most used literals (0, 1 and -1). 211kb
14486 reduced in memory usage.
14488 Replace all calls to `new ArrayList' with `new
14489 ArrayList(4)' which is a good average number for most allocations,
14490 and also requires only 16 bytes of memory for its buffer by
14493 This reduced MCS memory usage in seven megabytes for the RSS after
14496 2003-07-28 Ravi Pratap <ravi@ximian.com>
14498 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14499 handle params methods the correct way by forming only one
14500 applicable set with params and normal methods in them. Earlier we
14501 were looking at params methods only if we found no normal methods
14502 which was not the correct thing to do.
14504 (Invocation.BetterFunction): Take separate arguments indicating
14505 when candidate and the best method are params methods in their
14508 This fixes bugs #43367 and #46199.
14510 * attribute.cs: Documentation updates.
14512 (CheckAttribute): Rename to CheckAttributeTarget.
14513 (GetValidPlaces): Rename to GetValidTargets.
14515 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14516 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14520 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14522 * codegen.cs: Compute IsGeneric correctly.
14524 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14527 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14528 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14529 regressions, and I was chasing more bugs than I required.
14531 * interface.cs: Use expressions for base type names (like classes
14532 and structs have been doing for a while now), and resolve that.
14533 This patch should probably go into head as well.
14535 This makes it one less user of FindType.
14537 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14539 This compiler can not self host currently. Need to fix that.
14541 * Makefile: compile to `gmcs.exe'
14543 * driver.cs: Turn on v2 by default on gmcs.
14545 * generic.cs (ConstructedType): Does no longer take a container
14546 type argument; That will be taken care of later.
14548 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14549 Use SimpleName to resolve for now, so we can continue the work on
14550 the parser, until we get Type.GetType that understands generics.
14552 (ConstructedType.ToString): Implement
14554 (TypeArguments.Resolve): Resolve the child expressions as types.
14556 * cs-parser.jay: Rename interface_constraints to
14557 type_parameter_constraints
14559 (namespace_or_type_name): Only use constructed types for the basic
14560 construction, we will deal with identifier<...> later.
14562 (type/type_name): No longer call DecomposeQI, as
14563 namespace_or_type_name is always decoded now.
14565 2003-07-22 Ravi Pratap <ravi@ximian.com>
14567 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14568 closely: we eliminate methods in base types when we have an
14569 applicable method in a top-level type.
14571 Please see section 14.5.5.1 for an exact description of what goes
14574 This fixes bug #45127 and a host of other related to corlib compilation.
14576 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14577 array is the method corresponding to the top-level type (this is
14578 because of the changes made to icall.c) so we change this
14581 (MethodGroupExpr.Name): This too.
14583 * typemanager.cs (GetElementType): New method which does the right
14584 thing when compiling corlib.
14586 * everywhere: Make use of the above in the relevant places.
14588 2003-07-22 Martin Baulig <martin@ximian.com>
14590 * cs-parser.jay (invocation_expression): Moved
14591 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14592 `cast_expression', but create a InvocationOrCast which later
14593 resolves to either an Invocation or a Cast.
14595 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14596 method; call this before EmitStatement() to make sure that this
14597 expression can be used as a statement.
14599 * expression.cs (InvocationOrCast): New class; resolves to either
14600 an Invocation or a Cast.
14602 * statement.cs (StatementExpression): Call ResolveStatement() on
14603 the ExpressionStatement before emitting it.
14605 2003-07-21 Martin Baulig <martin@ximian.com>
14607 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
14608 `ref' and `out' attributes match; fixes #46220.
14609 (MemberAccess.ResolveMemberAccess): You can't reference a type
14610 through an expression; fixes #33180.
14611 (Indexers.GetIndexersForType): Don't return the indexers from
14612 interfaces the class implements; fixes #46502.
14614 2003-07-21 Martin Baulig <martin@ximian.com>
14616 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
14617 CS0661 checks; fixes bug #30442.
14619 2003-07-21 Martin Baulig <martin@ximian.com>
14621 * decl.cs (AdditionResult): Added `Error'.
14623 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
14625 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
14626 cs0031.cs actually work.
14628 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14630 * cs-parser.jay (namespace_name): do not use
14631 namespace_or_type_name, use qualified_identifier, because
14632 namespace_or_type_name will soon return a composed expression
14633 instead of a string.
14635 (namespace_or_type_name): Instead of returning a string, now this
14636 production returns an expression.
14638 * codegen.cs (EmitContext): Setup IsGeneric property based on
14639 whether our DeclSpace is generic, our the method is generic.
14641 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
14642 the method is generic.
14644 * cs-parser.jay (type_arguments, opt_type_argument_list,
14645 type_parameters, type_parameter_list, opt_type_parameter_list,
14646 type_parameter,, opt_type_parameter_constraints_clauses,
14647 type_parameter_constraints_clauses,
14648 type_parameter_constraint_clause, type_parameter_constraint,
14649 interface_constraints): Add new production
14651 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
14652 DeclSpace is generic or not.
14654 (DeclSpace.SetParameterInfo): New routine, used to set the
14655 parameter info for a type.
14657 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
14658 returns a GenericTypeExpr
14660 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
14661 generic, lookup the generic argument.
14663 * attribute.cs: Do not allow TypeParameterExpressions in
14666 * class.cs: Do not allow the Main method to be defined in a
14669 * expression.cs (SizeOf): Do not allow generic types to be used as
14670 arguments to sizeof.
14672 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
14673 it: whether a type is generic or not. Only works for types we are
14674 currently building for now.
14676 2003-07-20 Martin Baulig <martin@ximian.com>
14678 * namespace.cs: Fixed that bug which caused a crash when compiling
14679 the debugger's GUI.
14681 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14683 * typemanager.cs (LookupTypeReflection): Never expose types which
14684 are NotPublic, NestedPrivate, NestedAssembly, or
14685 NestedFamANDAssem. We used to return these, and later do a check
14686 that would report a meaningful error, but the problem is that we
14687 would not get the real match, if there was a name override.
14689 2003-07-18 Miguel de Icaza <miguel@ximian.com>
14691 * namespace.cs (Namespace, Name): Do not compute the namespace
14692 name dynamically, compute it in the constructor. This reduced
14693 memory usage by 1697 KB.
14695 * driver.cs: Use --pause to pause at the end.
14697 2003-07-17 Peter Williams <peter@newton.cx>
14699 * Makefile: Change the name of the test target so that it doesn't
14700 conflict with the recursive test target.
14702 2003-07-17 Miguel de Icaza <miguel@ximian.com>
14704 * expression.cs (LocalVariableReference.Emit, EmitAssign,
14705 AddressOf): Do not use EmitThis, that was wrong, use the actual
14708 2003-07-15 Miguel de Icaza <miguel@ximian.com>
14710 * class.cs (MethodData.Define): While checking if a method is an
14711 interface implementation, improve the test: If we are not public
14712 (use new test here: use the computed MethodAttributes directly,
14713 instead of the parsed modifier flags) check if the `implementing'
14714 method comes from an interface or not.
14716 * pending.cs (VerifyPendingMethods): Slightly better error
14719 * makefile: add test target that does the mcs bootstrap.
14721 2003-07-16 Ravi Pratap <ravi@ximian.com>
14723 * interface.cs (Define): Do nothing here since there are no
14724 members to populate etc. Move the attribute emission out of here
14725 since this was just totally the wrong place to put it. Attribute
14726 application happens during the 'Emit' phase, not in the 'Define'
14729 (Emit): Add this method and move the attribute emission here
14731 * rootcontext.cs (EmitCode): Call the Emit method on interface
14734 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14736 * expression.cs (OverloadResolve): Report error only if Location
14737 is not 'Null' which means that there was a probe going on.
14739 2003-07-14 Martin Baulig <martin@ximian.com>
14741 * expression.cs (ConditionalLogicalOperator): New public class to
14742 implement user defined conditional logical operators.
14743 This is section 14.11.2 in the spec and bug #40505.
14745 2003-07-14 Martin Baulig <martin@ximian.com>
14747 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
14749 2003-07-14 Martin Baulig <martin@ximian.com>
14751 * codegen.cs (EmitContext.InFixedInitializer): New public field.
14753 * ecore.cs (IVariable.VerifyFixed): New interface method.
14755 * expression.cs (Unary.ResolveOperator): When resolving the `&'
14756 operator, check whether the variable is actually fixed. Fixes bug
14757 #36055. Set a variable definitely assigned when taking its
14758 address as required by the spec.
14760 * statement.cs (LocalInfo.IsFixed): New field.
14761 (LocalInfo.MakePinned): Set `IsFixed' to true.
14763 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14765 * attribute.cs (Attribute.Resolve): While doing a Member lookup
14766 for .ctors, ensure that we only ask for members declared in the
14767 attribute type (BindingFlags.DeclaredOnly).
14771 * expression.cs (Error_WrongNumArguments): Report error 1501
14772 correctly the way CSC does.
14774 2003-07-13 Martin Baulig <martin@ximian.com>
14776 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
14777 lookup on the fully qualified name, to make things like "X.X" work
14778 where "X.X" is a fully qualified type name, but we also have a
14779 namespace "X" in the using list. Fixes #41975.
14781 2003-07-13 Martin Baulig <martin@ximian.com>
14783 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
14784 function. If we're a CompoundAssign, we need to create an embedded
14785 CompoundAssign, not an embedded Assign.
14786 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
14789 2003-07-13 Martin Baulig <martin@ximian.com>
14791 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
14792 work to fix bug #46088.
14794 2003-07-13 Ravi Pratap <ravi@ximian.com>
14796 * class.cs (Operator.Emit): Do not emit attributes here - it is
14797 taken care of by the Method class that we delegate too. This takes
14798 care of bug #45876.
14800 2003-07-10 Martin Baulig <martin@ximian.com>
14802 * expression.cs (TypeOfVoid): New class.
14803 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
14805 2003-07-10 Martin Baulig <martin@ximian.com>
14807 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
14810 2003-07-10 Martin Baulig <martin@ximian.com>
14812 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
14813 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
14815 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
14817 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
14819 2003-07-10 Martin Baulig <martin@ximian.com>
14821 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
14822 of decimal. Fixes #42850.
14824 NOTE: I also fixed the created byte blob, but this doesn't work on
14825 the MS runtime and csc never produces any byte blobs for decimal
14828 2003-07-10 Martin Baulig <martin@ximian.com>
14830 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
14831 structs; fixes #32068.
14832 (Block.AddChildVariableNames): Fixed #44302.
14834 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14836 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
14838 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14840 * attribute.cs: And this test is onger needed.
14842 2003-07-08 Martin Baulig <martin@ximian.com>
14844 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
14845 inaccessible types. Fixes #36313.
14847 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
14849 * namespace.cs (NamespaceEntry): Create implicit entries for all
14850 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
14851 implicit entries for N1.N2 and N1.
14853 2003-07-08 Martin Baulig <martin@ximian.com>
14855 Rewrote the handling of namespaces to fix a lot of the issues
14856 wrt. `using' aliases etc.
14858 * namespace.cs (Namespace): Splitted this class into a
14859 per-assembly `Namespace' and a per-file `NamespaceEntry'.
14861 * typemanager.cs (TypeManager.IsNamespace): Removed.
14862 (TypeManager.ComputeNamespaces): Only compute namespaces from
14863 loaded assemblies here, not the namespaces from the assembly we're
14864 currently compiling.
14866 2003-07-08 Martin Baulig <martin@ximian.com>
14868 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
14870 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14872 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
14875 I thought about the memory savings here, but LookupTypeReflection
14876 is used under already very constrained scenarios. Compiling
14877 corlib or mcs only exposes one hit, so it would not really reduce
14878 any memory consumption.
14880 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14882 * typemanager.cs: fixes bug #45889 by only adding public types from
14883 other assemblies to the list of known types.
14885 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14887 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
14888 on the type we resolved.
14890 2003-07-05 Martin Baulig <martin@ximian.com>
14892 * pending.cs (PendingImplementation.ParentImplements): Don't
14893 create the proxy if the parent is abstract.
14895 * class.cs (TypeContainer.DefineIndexers): Process explicit
14896 interface implementations first. Fixes #37714.
14898 2003-07-04 Miguel de Icaza <miguel@ximian.com>
14900 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
14901 defined recursively; but since we modify the input parameters
14902 (left is set to `this' temporarily), we reset this value if the
14903 left_is_explicit is false, which gives the original semantics to
14906 * literal.cs (NullPointer): new class used to represent a null
14907 literal in a pointer context.
14909 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
14910 type is a pointer, use a NullPointer object instead of a
14911 NullLiteral. Closes 43687
14913 (ExplicitConversion): Convert pointer values using
14914 the conv opcode to the proper type.
14916 * ecore.cs (New): change ValueTypeVariable property into a method,
14917 that returns whether the valuetype is suitable for being used.
14919 * expression.cs (Binary.DoNumericPromotions): Only return if we
14920 the int constant was a valid uint, and we can return both left and
14921 right as uints. If not, we continue processing, to trigger the
14922 type conversion. This fixes 39018.
14924 * statement.cs (Block.EmitMeta): During constant resolution, set
14925 the CurrentBlock property on the emitcontext, so that we resolve
14926 constants propertly.
14928 2003-07-02 Martin Baulig <martin@ximian.com>
14930 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
14931 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
14933 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
14934 than emitting it here.
14936 * statement.cs: Fixed some more flow analysis bugs.
14938 2003-07-02 Martin Baulig <martin@ximian.com>
14940 * class.cs (MethodData.Define): When implementing interface
14941 methods, set Final unless we're Virtual.
14943 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
14944 check work for interface methods.
14946 2003-07-01 Martin Baulig <martin@ximian.com>
14948 * ecore.cs (EmitContext.This): Replaced this property with a
14949 GetThis() method which takes a Location argument. This ensures
14950 that we get the correct error location for a CS0188.
14952 2003-07-01 Miguel de Icaza <miguel@ximian.com>
14954 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
14955 ImplicitStandardConversion.
14957 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
14959 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
14961 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
14964 2003-06-30 Miguel de Icaza <miguel@ximian.com>
14966 * class.cs (Constructor.Define): Turn off initlocals for unsafe
14969 (MethodData.Define): Turn off initlocals for unsafe methods.
14971 2003-06-29 Miguel de Icaza <miguel@ximian.com>
14973 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
14974 complete; Fixes #37521.
14976 * delegate.cs: Use Modifiers.TypeAttr to compute the
14977 TypeAttributes, instead of rolling our own. This makes the flags
14978 correct for the delegates.
14980 2003-06-28 Miguel de Icaza <miguel@ximian.com>
14982 * class.cs (Constructor.Define): Set the private flag for static
14983 constructors as well.
14985 * cs-parser.jay (statement_expression): Set the return value to
14986 null, to avoid a crash when we catch an error.
14988 2003-06-24 Miguel de Icaza <miguel@ximian.com>
14990 * cs-parser.jay: Applied patch from Jackson that adds support for
14991 extern and unsafe modifiers to destructor declarations.
14993 * expression.cs: Report error 21 if the user is trying to index a
14996 * driver.cs: Add an error message, suggested by the bug report.
14998 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
14999 if we do not have a ": this ()" constructor initializer. Fixes 45149
15001 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15003 * namespace.cs: Add some information to reduce FAQs.
15005 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15007 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15008 underlying enumeration types. Fixes #43915.
15010 * expression.cs: Treat ushort/short as legal values to be used in
15011 bitwise operations.
15013 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15015 * delegate.cs: transfer custom attributes for paramenters from
15016 the delegate declaration to Invoke and BeginInvoke.
15018 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15020 * attribute.cs: handle custom marshalers and emit marshal info
15023 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15025 * makefile.gnu: Added anonymous.cs to the compiler sources.
15027 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15029 * iterators.cs: Change the name of the proxy class to include two
15032 * cs-parser.jay: Update grammar to include anonymous methods.
15034 * anonymous.cs: new file.
15036 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15038 * class.cs (Field.Define): Add missing test for pointers and
15041 2003-05-27 Ravi Pratap <ravi@ximian.com>
15043 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15044 we use the stobj opcode.
15046 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15047 since it wasn't the correct fix.
15049 It still is puzzling that we are required to use stobj for IntPtr
15050 which seems to be a ValueType.
15052 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15054 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15055 during regular simple name resolution. Now, the trick is that
15056 instead of returning for processing the simplename, we do a
15057 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15058 contextual lookup type). If a match is found, return that, if
15059 not, return for further composition.
15061 This fixes long-standing 30485.
15063 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15064 using the address to initialize an object, do an Stobj instead of
15065 using the regular Stelem.
15067 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15068 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15069 Because if we are a BaseIndexerAccess that value will be true.
15072 * statement.cs (GotoCase.Resolve): Return after reporting an
15073 error, do not attempt to continue.
15075 * expression.cs (PointerArithmetic.Emit): If our operand is a
15076 long, convert our constants to match the operand before
15077 multiplying. Convert to I type before adding. Fixes 43670.
15079 2003-05-14 Ravi Pratap <ravi@ximian.com>
15081 * enum.cs (ImplicitConversionExists) : Rename to
15082 ImplicitEnumConversionExists to remove ambiguity.
15084 * ecore.cs (NullCast): New type of cast expression class which
15085 basically is very similar to EmptyCast with the difference being
15086 it still is a constant since it is used only to cast a null to
15088 (eg. (string) null)
15090 * convert.cs (ImplicitReferenceConversion): When casting a null
15091 literal, we return a NullCast.
15093 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15094 should be around anymore.
15096 The renaming (reported was slightly wrong). Corrections:
15098 ConvertImplicitStandard -> ImplicitConversionStandard
15099 ConvertExplicitStandard -> ExplicitConversionStandard
15101 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15102 before passing them in !
15104 * convert.cs (ImplicitConversionStandard): When comparing for
15105 equal expr and target types, ensure that expr is not a
15108 In general, we must not be checking (expr_type ==
15109 target_type) in the top level conversion methods
15110 (ImplicitConversion, ExplicitConversion etc). This checking is
15111 done in the methods that they delegate to.
15113 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15115 * convert.cs: Move Error_CannotConvertType,
15116 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15117 ImplicitNumericConversion, ImplicitConversionExists,
15118 ImplicitUserConversionExists, StandardConversionExists,
15119 FindMostEncompassedType, FindMostSpecificSource,
15120 FindMostSpecificTarget, ImplicitUserConversion,
15121 ExplicitUserConversion, GetConversionOperators,
15122 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15123 TryImplicitIntConversion, Error_CannotConvertImplicit,
15124 ConvertImplicitRequired, ConvertNumericExplicit,
15125 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15126 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15129 Perform the following renames:
15131 StandardConversionExists -> ImplicitStandardConversionExists
15132 ConvertImplicit -> ImplicitConversion
15133 ConvertImplicitStandard -> ImplicitStandardConversion
15134 TryImplicitIntConversion -> ImplicitIntConversion
15135 ConvertImplicitRequired -> ImplicitConversionRequired
15136 ConvertNumericExplicit -> ExplicitNumericConversion
15137 ConvertReferenceExplicit -> ExplicitReferenceConversion
15138 ConvertExplicit -> ExplicitConversion
15139 ConvertExplicitStandard -> ExplicitStandardConversion
15141 2003-05-19 Martin Baulig <martin@ximian.com>
15143 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15144 (TypeInfo): Added support for structs having structs as fields.
15146 * ecore.cs (FieldExpr): Implement IVariable.
15147 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15148 VariableInfo for the field.
15150 2003-05-18 Martin Baulig <martin@ximian.com>
15152 * expression.cs (This.DoResolve): Report a CS0027 if we're
15153 emitting a field initializer.
15155 2003-05-18 Martin Baulig <martin@ximian.com>
15157 * expression.cs (This.ResolveBase): New public function.
15158 (This.DoResolve): Check for CS0188.
15160 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15163 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15164 `instance_expression' to null if we don't have any non-static
15167 2003-05-18 Martin Baulig <martin@ximian.com>
15169 Reworked the way how local variables and parameters are handled by
15170 the flow analysis code.
15172 * statement.cs (TypeInfo, VariableMap): New public classes.
15173 (VariableInfo): New public class. This is now responsible for
15174 checking whether a variable has been assigned. It is used for
15175 parameters and local variables.
15176 (Block.EmitMeta): Take the InternalParameters as argument; compute
15177 the layout of the flow vectors here.
15178 (Block.LocalMap, Block.ParameterMap): New public properties.
15179 (FlowBranching): The .ctor doesn't get the InternalParameters
15180 anymore since Block.EmitMeta() now computes the layout of the flow
15182 (MyStructInfo): This class is now known as `StructInfo' and nested
15183 in `TypeInfo'; we don't access this directly anymore.
15185 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15186 property and removed IsAssigned(), IsFieldAssigned(),
15187 SetAssigned() and SetFieldAssigned(); we now call them on the
15188 VariableInfo so we don't need to duplicate this code everywhere.
15190 * expression.cs (ParameterReference): Added `Block block' argument
15192 (LocalVariableReference, ParameterReference, This): The new
15193 VariableInfo class is now responsible for all the definite
15196 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15197 IsParameterAssigned, SetParameterAssigned): Removed.
15199 2003-05-18 Martin Baulig <martin@ximian.com>
15201 * typemanager.cs (InitCoreTypes): Try calling
15202 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15203 the 3-args-version. Corlib now also needs our `void_type'.
15204 (GetMethod): Added overloaded version which takes an optional
15205 `bool report_errors' to allow lookups of optional methods.
15207 2003-05-12 Martin Baulig <martin@ximian.com>
15209 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15210 only used for locals and not for parameters.
15212 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15214 * support.cs (InternalParameters.ParameterType): Return the
15215 ExternalType of the parameter.
15217 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15220 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15222 * class.cs (MethodData.Define): Do not set the `newslot' on
15223 interface members, if they are also flagged as "override".
15225 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15226 better code for ++i and i++. This only works for static fields
15227 and local variables.
15229 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15230 want to pull the DeclSpace out of the builder_to_declspace instead
15231 of the TypeBuilder (like in TypeContainer.FindMembers).
15233 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15234 instead of LookupTypeContainer. Fixes the crash on .NET for
15235 looking up interface members.
15237 * const.cs: Create our own emit context during the Definition
15238 stage, so that constants are evaluated in the proper context, when
15239 a recursive definition happens.
15241 2003-05-11 Martin Baulig <martin@ximian.com>
15243 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15244 new block for a switch section.
15245 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15246 the adding/lookup in the switch block. Fixes #39828.
15248 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15250 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15251 functionality: I needed to convert the data after I had performed
15252 the add/sub operation into the operands type size.
15254 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15255 pass the type for the box operation, otherwise the resulting
15256 object would have been of type object.
15258 (BoxedCast): Add constructor to specify the type to box as.
15260 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15262 * iterators.cs: I was reusing the `count' variable inadvertently,
15263 take steps to not allow this to happen.
15265 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15267 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15268 by creating an array at the point where the params starts and
15269 putting all those arguments there, then adjusting the size of the
15272 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15274 * expression.cs (New.AddressOf): Implement interface
15275 IMemoryLocation. This is used when the `new' operator is used in
15276 the context of an invocation to a method on a value type.
15278 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15281 * namespace.cs: Also check the using aliases here.
15283 * driver.cs: Move the test for using validity after the types have
15284 been entered, so we do a single pass that also includes the using
15287 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15288 in the regular case. CreateSiblingForFinally is doing extra
15291 * attribute.cs (GetAttributeArgumentExpression): Store the result
15292 on an out value, and use the return value to indicate failure
15293 instead of using null (which is a valid return for Constant.GetValue).
15295 * statement.cs: Perform the analysis flow for the increment
15296 portion after the statement, because this will be the real flow of
15297 execution. Fixes #42385
15299 * codegen.cs (EmitContext.EmitArgument,
15300 EmitContext.EmitStoreArgument): New helper functions when the
15301 RemapToProxy flag is set.
15303 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15306 Add support for remapping parameters.
15308 * iterators.cs: Propagate parameter values; Store parameter
15309 values in the proxy classes.
15311 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15313 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15314 need a proxy reference; I do not know what I was thinking
15316 * cs-parser.jay (constructor_initializer): catch another error,
15317 and display nice message.
15319 (field_declaration): catch void field declaration
15320 to flag a better error.
15322 * class.cs (MemberBase.CheckBase): Report an error instead of a
15323 warning if a new protected member is declared in a struct.
15324 (Field.Define): catch the error of readonly/volatile.
15326 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15328 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15329 volatile variable is taken
15331 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15333 * statement.cs (Fixed.Resolve): Report an error if we are not in
15336 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15338 * typemanager.cs: reuse the code that handles type clashes for
15339 delegates and enumerations.
15341 * class.cs (Report28): Always report.
15343 * expression.cs (EncodeAsAttribute): Allow nulls here.
15345 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15347 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15348 the functionality for testing whether an expression is valid for
15349 an attribute here. Also handle the case of arrays of elements
15352 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15353 encoding a linear array into an array of objects that are suitable
15354 to be passed to an CustomAttributeBuilder.
15356 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15358 * ecore.cs: (FieldExpr): Handle field remapping here.
15360 * iteratators.cs: Pass the instance variable (if the method is an
15361 instance method) to the constructors, so we can access the field
15362 variables on the class.
15364 TODO: Test this with structs. I think the THIS variable on
15365 structs might have to be a pointer, and not a refenrece
15367 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15369 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15370 local variables to fields in a proxy class.
15372 * iterators.cs (PopulateProxy): Rename our internal fields to
15374 Create a <THIS> field if we are an instance method, so we can
15375 reference our parent container variables.
15376 (MapVariable): Called back from the EmitContext code to enter a
15377 new variable to field mapping into the proxy class (we just create
15381 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15382 for using the remapped locals to fields.
15384 I placed the code here, because that gives the same semantics to
15385 local variables, and only changes the Emit code.
15387 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15388 statements inside iterators.
15389 (VariableInfo): Add a FieldBuilder for the cases when we are
15390 remapping local variables to fields in a proxy class
15392 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15393 current_block != null.
15395 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15396 not cope with strings, as it has been moved to the
15397 TableSwitchEmit. Fixed bug in switch generation.
15399 * expression.cs (New.DoResolve): Provide more context for the user
15400 when reporting an error.
15402 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15405 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15406 check the permissions for it. Note than in a type-resolution
15407 context the check was already present in DeclSpace.ResolveType,
15408 but was missing from the MemberAccess.
15410 (ArrayCreation.CheckIndices): warn if the user has
15411 more nested levels of expressions, but there are no more
15412 dimensions specified. Avoids crash on bug 41906.
15414 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15416 * statement.cs (Block): replace Implicit bool, for a generic
15418 New flag: `Unchecked'. This is used during the EmitMeta phase
15419 (which is out-of-line with the regular Resolve/Emit process for a
15420 statement, as this is done ahead of time, but still gets a chance
15421 to call constant resolve).
15423 (Block.Flags): new enum for adding a new flag.
15425 (Block.EmitMeta): track the state of unchecked.
15427 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15428 to enable constant resolution to work there as well.
15430 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15432 * typemanager.cs (ienumerable_type): Also look up
15433 System.Collections.IEnumerable.
15435 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15437 TODO: Test more than one conditional per method.
15439 * class.cs (Indexer.Define): Report the location where the user is
15440 referencing the unsupported feature.
15442 (MethodData): Overload the use of `conditionals' to
15443 minimize the creation of needless ArrayLists. This saves roughly
15444 212kb on my machine.
15446 (Method): Implement the new IIteratorContainer interface.
15447 (Method.SetYields): Implement the method by setting the ModFlags
15448 to contain METHOD_YIELDS.
15450 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15451 which just got set to null.
15453 * iterators.cs: New file.
15455 (Yield, YieldBreak): New statements.
15457 * statement.cs (Return.Resolve): Flag an error if we are used in
15458 an iterator method.
15460 * codegen.cs (InIterator): New flag set if the code is being
15461 compiled in an iterator method.
15463 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15464 internal modifier, and we just use it to avoid adding extra
15465 fields, as this is seldom used.
15467 * cs-parser.jay: Add yield_statement (yield and yield break).
15469 * driver.cs: New flag -v2 to turn on version 2 features.
15471 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15472 hashtable when v2 is enabled.
15474 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15476 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15477 there is already a namespace defined with this name.
15479 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15480 people upgraded their corlibs.
15482 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15483 always use fully qualified types, no need to use the compiler
15486 (TypeManager.IsNamespace): Use binarysearch.
15488 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15489 AddDelegate): I did not quite use the new IsValid API properly: I
15490 have to pass the short-name and the fullname. I was passing only
15491 the basename instead of the fullname sometimes.
15493 (TypeContainer.DefineType): call NamespaceClash.
15495 * interface.cs (Interface.DefineType): use NamespaceClash before
15498 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15501 * enum.cs: (Enum.DefineType): use NamespaceClash before
15504 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15505 speed increase. First, use the negative_hits cache when we get a
15506 negative. Second, add the type with its full original name
15507 instead of the new . and + encoded name (reflection uses + to
15508 separate type from a nested type). Use LookupTypeReflection
15509 directly which bypasses the type->name hashtable (that we already
15510 know does not contain the type.
15512 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15513 location/container type.
15515 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15517 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15519 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15521 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15522 method is being referenced in the method group from a static
15523 context, and report error 120 if so.
15525 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15528 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15529 is created, we create the A namespace).
15531 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15534 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15536 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15537 invocation to ModuleBuilder.GetType with the same values will
15538 return a new type instance, so we need to cache its return
15541 * expression.cs (Binary.ResolveOperator): Only allow the compare
15542 operators on enums if they are of the same type.
15544 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15545 types of ValueType on their own case. Before we were giving them
15546 the same treatment as objects.
15548 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15549 fullname. Short name is used to compare against container name.
15550 Fullname is used to check against defined namespace names.
15552 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15553 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15555 (Method.CheckBase): Call parent.
15556 (MemberBase.CheckBase): Check for protected members on sealed
15558 (PropertyBase.CheckBase): Call parent.
15559 (Field.Define): Call parent.
15561 * report.cs: Negative error codes are now mapped to 8000 - code,
15562 so that the display is render more nicely.
15564 * typemanager.cs: Do not use try/catch, instead report a regular
15567 (GetPointerType, GetReferenceType): These methods provide
15568 mechanisms to obtain the T* and T& from a T. We had the code
15569 previously scattered around the code base, and it also used
15570 TypeManager.LookupType that would go through plenty of caches.
15571 This one goes directly to the type source.
15573 In some places we did the Type.GetType followed by
15574 ModuleBuilder.GetType, but not in others, so this unifies the
15575 processing as well.
15577 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15578 statements now that we have namespace information.
15580 * typemanager.cs (IsNamespace): New method, returns whether the
15581 string presented is a namespace or not.
15583 (ComputeNamespaces): New public entry point, computes the list of
15584 available namespaces, using the GetNamespaces API call in Mono, or
15585 the slower version in MS.NET.
15587 Now before we start the semantic analysis phase, we have a
15588 complete list of namespaces including everything that the user has
15591 Deleted old code to cache namespaces in .nsc files.
15593 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15595 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15596 class/struct location definition Location for the implicit
15597 constructor location.
15599 (Operator.Define): Use the location of the operator for the
15600 implicit Method definition.
15602 (Constructor.Emit): use the constructor location for the implicit
15603 base initializer constructor.
15605 * ecore.cs: Remove ITypeExpression. This interface is now gone,
15606 and the Expression class now contains two new methods:
15608 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
15609 isolate type lookup from the rest of the resolution process.
15611 Since we use Expressions to hold type definitions due to the way
15612 we parse the input we have historically overloaded Resolve to
15613 perform the Type lookups if a special flag is passed. Now this is
15614 eliminated and two methods take their place.
15616 The differences in the two methods between xStep and xTerminal is
15617 that xStep is involved in our current lookup system that uses
15618 SimpleNames to compose a name, while xTerminal is used just to
15619 catch the case where the simplename lookup failed.
15621 2003-04-16 Miguel de Icaza <miguel@ximian.com>
15623 * expression.cs (ResolveMemberAccess): Remove redundant code.
15624 TypeExpr expressions are always born fully resolved.
15626 * interface.cs (PopulateMethod): Do not lookup the types twice.
15627 We were doing it once during SemanticAnalysis and once during
15630 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
15631 in local variable type definitions, were being returned as a
15632 SimpleName (we decomposed everything into a string), that is
15633 because primary_expression was being used instead of a type in the
15634 grammar (reduce/reduce conflicts).
15636 The part that was wrong is that we converted the expression into a
15637 string (an oversimplification in one hand, compounded with primary
15638 expressions doing string concatenation).
15644 Would return "A.B.C[]" as a SimpleName. This stopped things like
15645 using clauses from working on this particular context. And a type
15646 was being matched directly against "A.B.C[]".
15648 We now use the correct approach, and allow for ComposedCast to be
15649 part of the unary expression. So the "A.B.C []" become a composed
15650 cast of "A.B.C" (as a nested group of MemberAccess with a
15651 SimpleName at the end) plus the rank composition "[]".
15655 2003-04-10 Miguel de Icaza <miguel@ximian.com>
15657 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
15658 for the access level checking.
15660 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
15661 `TypeContainer container', because I kept getting confused when I
15662 was debugging this code.
15664 * expression.cs (Indexers): Instead of tracking getters/setters,
15665 we now track them in parallel. We create one arraylist less, but
15666 most importantly it is possible now for the LValue code to find a
15667 matching get for a set.
15669 (IndexerAccess.DoResolveLValue): Update the code.
15670 GetIndexersForType has been modified already to extract all the
15671 indexers from a type. The code assumed it did not.
15673 Also make the code set the correct return type for the indexer.
15674 This was fixed a long time ago for properties, but was missing for
15675 indexers. It used to be void_type.
15677 (Binary.Emit): Test first for doubles instead of
15678 floats, as they are more common.
15680 (Binary.EmitBranchable): Use the .un version of the branch opcodes
15681 when dealing with floats and the <=, >= operators. This fixes bug
15684 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
15685 to load the array value by emitting a load on the foreach variable
15686 type. This was incorrect.
15688 We now emit the code to load an element using the the array
15689 variable type, and then we emit the conversion operator.
15693 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
15695 * attribute.cs: Avoid allocation of ArrayLists in the common case.
15697 2003-04-09 Miguel de Icaza <miguel@ximian.com>
15699 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
15700 test for protection before we test for signatures.
15702 (MethodSignature.ToString): implement.
15704 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
15705 to the case where we reduced into a LongConstant.
15707 * decl.cs (CheckAccessLevel): If the type is an array, we can not
15708 depend on whether the information is acurrate, because the
15709 Microsoft runtime will always claim that the array type is public,
15710 regardless of the real state.
15712 If the type is a pointer, another problem happens: the type is
15713 reported as non-public in Microsoft.
15715 In both cases we have to call CheckAccessLevel recursively with
15716 the underlying type as the argument to be tested.
15718 2003-04-08 Miguel de Icaza <miguel@ximian.com>
15720 * assign.cs (Assign.Emit): If we are dealing with a compound
15721 assignment expression, we should use the code path that stores the
15722 intermediate result in a temporary value. This fixes #40903.
15724 *expression.cs (Indirection.ToString): Provide ToString method for
15727 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
15729 * class.cs: Null out fields holding references to Block objects so
15730 they can be garbage collected.
15732 * expression.cs (OverloadResolve): Remove unused local.
15734 2003-04-07 Martin Baulig <martin@ximian.com>
15736 * codegen.cs (EmitContext.CurrentFile): New public field.
15737 (EmitContext.Mark): Use the CurrentFile to check whether the
15738 location is in the correct file.
15739 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
15741 2003-04-07 Martin Baulig <martin@ximian.com>
15743 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
15745 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
15746 location. [FIXME: The location argument which gets passed to this
15747 method is sometimes wrong!]
15749 2003-04-07 Nick Drochak <ndrochak@gol.com>
15751 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
15753 2003-04-07 Miguel de Icaza <miguel@ximian.com>
15755 * expression.cs (Indirection.EmitAssign): We were using the
15756 temporary, but returning immediately instead of continuing the
15759 2003-04-06 Martin Baulig <martin@ximian.com>
15761 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
15762 if it's a nested child, but also deriving from the outer class.
15765 * typemanager.cs (IsNestedChildOf): Make this work if it's a
15766 nested child, but also deriving from the outer class. See
15768 (FilterWithClosure): We may access private members of the outer
15769 class if we're a nested child and deriving from the outer class.
15770 (RealMemberLookup): Only set `closure_private_ok' if the
15771 `original_bf' contained BindingFlags.NonPublic.
15773 2003-04-05 Martin Baulig <martin@ximian.com>
15775 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
15776 probe if its a type parameter, and if so, flag an error.
15778 * decl.cs: Move here the SetParameterInfo code from class.cs.
15779 Handle IsGeneric here.
15781 Handle a variety of errors in the parameter info definition.
15783 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
15784 type parameters here.
15786 * cs-parser.jay (class_declaration): report errors for parameters
15789 2003-01-21 Miguel de Icaza <miguel@ximian.com>
15791 * generic.cs: New file, contains support code for generics.
15793 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
15794 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
15796 Update parser for the above removals.
15798 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
15799 now taken care of in the parser.
15801 2003-04-02 Miguel de Icaza <miguel@ximian.com>
15803 * class.cs (Event.Define): Do not allow abstract events to have
15806 2003-04-01 Miguel de Icaza <miguel@ximian.com>
15808 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
15809 block in event declarations.
15811 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
15812 value type, get its address.
15814 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
15815 leaving a class on the stack instead of a boolean value (int
15816 0/1). Change the code so we compare against null, and then the
15817 result against zero.
15819 * class.cs (TypeContainer.GetClassBases): We were checking for the
15820 parent class being sealed too late.
15822 * expression.cs (Binary.Emit): For <= and >= when dealing with
15823 floating point values, use cgt.un and clt.un instead of cgt and
15826 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
15828 * statement.cs: Apply the same optimization as MS: skip the
15829 GetEnumerator returning an IEnumerator, and use the one returning a
15830 CharEnumerator instead. This allows us to avoid the try-finally block
15833 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
15835 * cs-parser.jay: Attributes cannot be applied to
15836 namespaces. Fixes #40473
15838 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15841 (Add*): check if the name is valid using the full name for constants,
15842 fields, properties and events.
15844 2003-03-28 Miguel de Icaza <miguel@ximian.com>
15846 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
15847 char constants to be part of the enumeration.
15849 * expression.cs (Conditional.DoResolve): Add support for operator
15850 true. Implements the missing functionality from 14.12
15852 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
15853 operator true/false as required by the spec.
15855 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
15856 implicit conversion to boolean.
15858 * statement.cs (Statement.ResolveBoolean): A boolean expression is
15859 also one where the type implements `operator true'.
15861 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
15862 get an expression that will invoke operator true based on an
15865 (GetConversionOperators): Removed the hack that called op_True
15868 (Expression.ResolveBoolean): Move this from Statement.
15870 2003-03-17 Miguel de Icaza <miguel@ximian.com>
15872 * ecore.cs (FieldExpr): do not allow initialization of initonly
15873 fields on derived classes
15875 2003-03-13 Martin Baulig <martin@ximian.com>
15877 * statement.cs (Block.Emit): Call ig.BeginScope() and
15878 ig.EndScope() when compiling with debugging info; call
15879 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
15881 2003-03-08 Miguel de Icaza <miguel@ximian.com>
15883 * expression.cs (Indexers): Do not construct immediately, allow
15884 for new members to be appended as we go. Fixes 38143
15886 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15888 * expression.cs: save/restore context when resolving an unchecked
15891 2003-03-05 Miguel de Icaza <miguel@ximian.com>
15893 * cfold.cs: Catch division by zero in modulus operator during
15896 2003-03-03 Miguel de Icaza <miguel@ximian.com>
15898 * interface.cs (Interface.DefineMembers): Avoid defining members
15901 2003-02-27 Miguel de Icaza <miguel@ximian.com>
15903 * driver.cs: handle the +/- options for -noconfig
15905 * statement.cs (Unckeched.Resolve): Also track the state of
15906 unchecked in the Resolve phase.
15908 2003-02-27 Martin Baulig <martin@ximian.com>
15910 * ecore.cs (Expression.MemberLookup): Don't create a
15911 MethodGroupExpr for something which is not a method. Fixes #38291.
15913 2003-02-25 Miguel de Icaza <miguel@ximian.com>
15915 * class.cs (MemberBase.CheckParameters): Also check that the type
15916 is unmanaged if it is a pointer.
15918 * expression.cs (SizeOf.Resolve): Add location information.
15920 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
15921 a managed type is declared.
15923 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
15924 parameter modifiers as well. Fixes bug 38606
15926 * class.cs: Very sad. Am backing out the speed up changes
15927 introduced by the ArrayList -> Array in the TypeContainer, as they
15928 were not actually that much faster, and introduced a bug (no error
15929 reports on duplicated methods).
15931 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
15932 source first, this will guarantee that we have a valid expression
15933 before calling in lower levels functions that will require a
15934 resolved object. Then use this original_source in the
15935 target.ResolveLValue instead of the original source that was
15938 Another change. Use target.Resolve instead of LValueResolve.
15939 Although we are resolving for LValues, we will let the Assign code
15940 take care of that (it will be called again from Resolve). This
15941 basically allows code like this:
15943 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
15944 class Y { void A (X x) { x [0] += o; }
15946 The problem was that the indexer was trying to resolve for
15947 set_Item (idx, object o) and never finding one. The real set_Item
15948 was set_Item (idx, X). By delaying the process we get the right
15953 2003-02-23 Martin Baulig <martin@ximian.com>
15955 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
15956 while calling DoEmit ().
15958 * codegen.cs (EmitContext.Mark): Don't mark locations in other
15959 source files; if you use the #line directive inside a method, the
15960 compiler stops emitting line numbers for the debugger until it
15961 reaches the end of the method or another #line directive which
15962 restores the original file.
15964 2003-02-23 Martin Baulig <martin@ximian.com>
15966 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
15968 2003-02-23 Martin Baulig <martin@ximian.com>
15970 * statement.cs (Block.AddChildVariableNames): We need to call this
15971 recursively, not just for our immediate children.
15973 2003-02-23 Martin Baulig <martin@ximian.com>
15975 * class.cs (Event.Define): Always make the field private, like csc does.
15977 * typemanager.cs (TypeManager.RealMemberLookup): Make events
15978 actually work, fixes bug #37521.
15980 2003-02-23 Miguel de Icaza <miguel@ximian.com>
15982 * delegate.cs: When creating the various temporary "Parameters"
15983 classes, make sure that we call the ComputeAndDefineParameterTypes
15984 on those new parameters (just like we do with the formal ones), to
15985 allow them to be resolved in the context of the DeclSpace.
15987 This fixes the bug that Dick observed in Bugzilla #38530.
15989 2003-02-22 Miguel de Icaza <miguel@ximian.com>
15991 * expression.cs (ResolveMemberAccess): When resolving a constant,
15992 do not attempt to pull a constant if the value was not able to
15993 generate a valid constant.
15995 * const.cs (LookupConstantValue): Do not report more errors than required.
15997 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15999 * expression.cs: fixes bug #38328.
16001 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16003 * class.cs: Changed all the various members that can be part of a
16004 class from being an ArrayList to be an Array of the right type.
16005 During the DefineType type_list, interface_list, delegate_list and
16006 enum_list are turned into types, interfaces, delegates and enums
16009 And during the member population, indexer_list, event_list,
16010 constant_list, field_list, instance_constructor_list, method_list,
16011 operator_list and property_list are turned into their real arrays.
16013 Although we could probably perform this operation earlier, for
16014 good error reporting we need to keep the lists and remove the
16015 lists for longer than required.
16017 This optimization was triggered by Paolo profiling the compiler
16018 speed on the output of `gen-sample-program.pl' perl script.
16020 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16021 not crash in methods like MemberLookupFailed that use this field.
16023 This problem arises when the compiler fails to resolve a type
16024 during interface type definition for example.
16026 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16028 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16029 inherit from System.Object, so we have to stop at null, not only
16030 when reaching System.Object.
16032 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16034 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16035 DeclaredOnly because the parent indexer might have had a different
16036 name, but did not loop until the top of the hierarchy was reached.
16038 The problem this one fixes is 35492: when a class implemented an
16039 indexer from an interface, we were getting the interface method
16040 (which was abstract) and we were flagging an error (can not invoke
16043 This also keeps bug 33089 functioning, and test-148 functioning.
16045 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16046 out if a method is special is to see if it is declared in a
16047 property or event, or whether it is one of the predefined operator
16048 names. This should fix correctly #36804.
16050 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16052 The goal here is to remove the dependency on EmptyCast.Peel ().
16053 Killing it completely.
16055 The problem is that currently in a number of places where
16056 constants are expected, we have to "probe" for an EmptyCast, and
16057 Peel, which is not the correct thing to do, as this will be
16058 repetitive and will likely lead to errors.
16060 The idea is to remove any EmptyCasts that are used in casts that
16061 can be reduced to constants, so we only have to cope with
16064 This bug hunt was triggered by Bug 37363 and the desire to remove
16065 the duplicate pattern where we were "peeling" emptycasts to check
16066 whether they were constants. Now constants will always be
16069 * ecore.cs: Use an enumconstant here instead of wrapping with
16072 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16073 throwing me off. By handling this we can get rid of a few hacks.
16075 * statement.cs (Switch): Removed Peel() code.
16077 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16079 * class.cs: Location information for error 508
16081 * expression.cs (New.DoResolve): Add a guard against double
16082 resolution of an expression.
16084 The New DoResolve might be called twice when initializing field
16085 expressions (see EmitFieldInitializers, the call to
16086 GetInitializerExpression will perform a resolve on the expression,
16087 and later the assign will trigger another resolution
16089 This leads to bugs (#37014)
16091 * delegate.cs: The signature for EndInvoke should contain any ref
16092 or out parameters as well. We were not doing this in the past.
16094 * class.cs (Field.Define): Do not overwrite the type definition
16095 inside the `volatile' group. Turns out that volatile enumerations
16096 were changing the type here to perform a validity test, which
16099 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16101 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16102 and structs, we do not want to load the instance variable
16104 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16105 enum_type has to be handled like an object reference (implicit
16106 conversions exists from this to object), but the regular IsClass
16107 and IsValueType tests will never return true for this one.
16109 Also we use TypeManager.IsValueType instead of type.IsValueType,
16110 just for consistency with the rest of the code (this is only
16111 needed if we ever use the construct exposed by test-180.cs inside
16112 corlib, which we dont today).
16114 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16116 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16119 2003-02-09 Martin Baulig <martin@ximian.com>
16121 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16122 (Namespace.DefineNamespaces): New static public method; this is
16123 called when we're compiling with debugging to add all namespaces
16124 to the symbol file.
16126 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16127 pass it to the Namespace's .ctor.
16129 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16130 and MethodBase arguments; pass the namespace ID to the symwriter;
16131 pass the MethodBase instead of the token to the symwriter.
16132 (SymbolWriter.DefineNamespace): New method to add a namespace to
16135 2003-02-09 Martin Baulig <martin@ximian.com>
16137 * symbolwriter.cs: New file. This is a wrapper around
16138 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16139 methods here in near future.
16141 2003-02-09 Martin Baulig <martin@ximian.com>
16143 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16144 ILGenerator.MarkSequencePoint() which are actually used by the
16147 2003-02-09 Martin Baulig <martin@ximian.com>
16149 * location.cs (SourceFile): New public sealed class. This
16150 contains the name and an index which is used in the location's token.
16151 (Location): Reserve an appropriate number of bits in the token for
16152 the source file instead of walking over that list, this gives us a
16153 really huge performance improvement when compiling with debugging.
16155 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16156 `SourceFile' argument instead of a string.
16157 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16158 but don't parse/tokenize here, we need to generate the list of all
16159 source files before we do that.
16160 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16163 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16164 instead of a string.
16166 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16169 2003-02-09 Martin Baulig <martin@ximian.com>
16171 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16172 filename on `#line default'.
16174 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16176 * statement.cs: don't clear the pinned var when the fixed statement
16177 returns from the method (fixes bug#37752).
16179 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16181 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16184 2003-02-07 Martin Baulig <martin@ximian.com>
16186 * driver.cs: Removed the `--debug-args' command line argument.
16188 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16189 automatically by the AsssemblyBuilder.
16190 (CodeGen.InitializeSymbolWriter): We don't need to call any
16191 initialization function on the symbol writer anymore. This method
16192 doesn't take any arguments.
16194 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16196 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16197 from referenced assemblies as well.
16199 2003-02-02 Martin Baulig <martin@ximian.com>
16201 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16203 2003-02-02 Martin Baulig <martin@ximian.com>
16205 * class.cs (Constructor.Emit): Open the symbol writer before
16206 emitting the constructor initializer.
16207 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16208 single-stepping through constructor initializers.
16210 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16212 * class.cs: Handle error 549: do not allow virtual methods in
16215 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16217 * decl.cs: Check access levels when resolving types
16219 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16221 * statement.cs: Add parameters and locals set in catch blocks that might
16222 return to set vector
16224 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16226 * class.cs (Operator): Set the SpecialName flags for operators.
16228 * expression.cs (Invocation.DoResolve): Only block calls to
16229 accessors and operators on SpecialName methods.
16231 (Cast.TryReduce): Handle conversions from char constants.
16234 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16236 * statement.cs: small memory and time optimization in FlowBranching.
16238 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16240 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16241 problem that the last fix but in the other sid (Set).
16243 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16244 access when there is no indexer in the hierarchy.
16246 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16248 * class.cs: Combine some if statements.
16250 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16252 * driver.cs: fixed bug #37187.
16254 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16256 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16257 any indexer, it's needed to build a list with all the indexers in the
16258 hierarchy (AllGetters), else we have problems. Fixes #35653.
16260 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16262 * class.cs (MethodData.Define): It is wrong for an interface
16263 implementation to be static in both cases: explicit and implicit.
16264 We were only handling this in one case.
16266 Improve the if situation there to not have negations.
16268 * class.cs (Field.Define): Turns out that we do not need to check
16269 the unsafe bit on field definition, only on usage. Remove the test.
16271 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16273 * driver.cs: use assembly.Location instead of Codebase (the latest
16274 patch made mcs fail when using MS assemblies).
16276 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16278 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16279 get the path to *corlib.dll.
16281 2003-01-21 Nick Drochak <ndrochak@gol.com>
16285 * typemanager.cs: Remove compiler warnings
16287 2003-01-20 Duncan Mak <duncan@ximian.com>
16289 * AssemblyInfo.cs: Bump the version number to 0.19.
16291 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16293 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16295 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16297 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16299 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16301 * cs-parser.jay: Small fix: we were not comparing the constructor
16302 name correctly. Thanks to Zoltan for the initial pointer.
16304 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16306 * cs-tokenizer.cs: Set file name when specified with #line
16308 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16310 * cs-parser.jay: Only perform the constructor checks here if we
16311 are named like the class; This will help provider a better
16312 error. The constructor path is taken when a type definition is
16313 not found, but most likely the user forgot to add the type, so
16314 report that rather than the constructor error.
16316 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16318 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16321 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16323 * cs-parser.jay: Add cleanup call.
16325 2003-01-13 Duncan Mak <duncan@ximian.com>
16327 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16328 consistent with other methods.
16330 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16332 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16334 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16336 * attribute.cs: only set GuidAttr to true when we have a
16339 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16343 * typemanager.cs: fixes to allow mcs compile corlib with the new
16344 Type.IsSubclassOf fix.
16346 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16348 * expression.cs (LocalVariableReference.DoResolve): Classify a
16349 constant as a value, not as a variable. Also, set the type for
16352 * cs-parser.jay (fixed_statement): take a type instead of a
16353 pointer_type, so we can produce a better error message later.
16355 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16358 (For.DoEmit): Make inifinite loops have a
16359 non-conditional branch back.
16361 (Fixed.DoEmit): First populate the pinned variables, then emit the
16362 statement, then clear the variables. Before I was emitting the
16363 code once for each fixed piece.
16366 2003-01-08 Martin Baulig <martin@ximian.com>
16368 * statement.cs (FlowBranching.MergeChild): A break in a
16369 SWITCH_SECTION does not leave a loop. Fixes #36155.
16371 2003-01-08 Martin Baulig <martin@ximian.com>
16373 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16374 lives in the same number space than `param_map'. Fixes #36154.
16376 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16378 * cs-parser.jay (constructor_declaration): Set the
16379 Constructor.ModFlags before probing for it. This makes the
16380 compiler report 514, 515 and 132 (the code was there, but got
16383 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16384 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16385 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16387 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16389 * enum.cs: create the enum static fields using the enum type.
16391 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16393 * class.cs: don't try to create the ParamBuilder for the return
16394 type if it's not needed (and handle it breaking for the ms runtime
16397 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16399 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16401 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16403 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16404 the command. This showed up while compiling the JANET source
16405 code, which used \r as its only newline separator.
16407 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16409 * class.cs (Method.Define): If we are an operator (because it
16410 reuses our code), then set the SpecialName and HideBySig. #36128
16412 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16414 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16415 exception, report error 120 `object reference required'.
16417 * driver.cs: Add --pause option, used during to measure the size
16418 of the process as it goes with --timestamp.
16420 * expression.cs (Invocation.DoResolve): Do not allow methods with
16421 SpecialName to be invoked.
16423 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16425 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16426 number before adding it.
16428 2002-12-21 Ravi Pratap <ravi@ximian.com>
16430 * ecore.cs (StandardImplicitConversion): When in an unsafe
16431 context, we allow conversion between void * to any other pointer
16432 type. This fixes bug #35973.
16434 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16436 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16437 is not thrown when extensionless outputs are used
16439 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16441 * rootcontext.cs: fixed compilation of corlib.
16443 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16445 * attribute.cs (Attributes.Contains): Add new method.
16447 * class.cs (MethodCore.LabelParameters): if the parameter is an
16448 `out' parameter, check that no attribute `[In]' has been passed.
16450 * enum.cs: Handle the `value__' name in an enumeration.
16452 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16454 * decl.cs: Added special case to allow overrides on "protected
16457 2002-12-18 Ravi Pratap <ravi@ximian.com>
16459 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16460 since it makes much more sense.
16462 (Attributes.ctor): Don't require a Location parameter.
16464 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16466 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16467 since we already have that information per attribute.
16469 * everywhere : make appropriate changes.
16471 * class.cs (LabelParameters): Write the code which actually
16472 applies attributes to the return type. We can't do this on the MS
16473 .NET runtime so we flag a warning in the case an exception is
16476 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16478 * const.cs: Handle implicit null conversions here too.
16480 2002-12-17 Ravi Pratap <ravi@ximian.com>
16482 * class.cs (MethodCore.LabelParameters): Remove the extra
16483 Type [] parameter since it is completely unnecessary. Instead
16484 pass in the method's attributes so that we can extract
16485 the "return" attribute.
16487 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16489 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16490 of ignoring it and letting the compile continue.
16492 * typemanager.cs (ChangeType): use an extra argument to return an
16493 error condition instead of throwing an exception.
16495 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16497 * expression.cs (Unary.TryReduce): mimic the code for the regular
16498 code path. Perform an implicit cast in the cases where we can
16499 implicitly convert to one of the integral types, and then reduce
16500 based on that constant. This fixes bug #35483.
16502 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16504 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16506 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16508 * namespace.cs: fixed bug #35489.
16510 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16512 * class.cs: Remove some dead code.
16514 * cs-parser.jay: Estimate the number of methods needed
16515 (RootContext.MethodCount);
16517 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16518 numbers instead of StringBuilders.
16520 * support.cs (PtrHashtable): Add constructor with initial size;
16521 We can now reduce reallocations of the method table.
16523 2002-12-10 Ravi Pratap <ravi@ximian.com>
16525 * attribute.cs (ApplyAttributes): Keep track of the emitted
16526 attributes on a per-target basis. This fixes bug #35413.
16528 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16530 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16531 default to the Windows 1252 encoding.
16533 (UnixParseOption): Support version, thanks to Alp for the missing
16536 * AssemblyInfo.cs: Add nice assembly information.
16538 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16541 * cs-parser.jay: Allow a trailing comma before the close bracked
16542 in the attribute_section production.
16544 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16545 address of the instance was being taken, I will take this out,
16546 because we take the address of the object immediately here.
16548 2002-12-09 Ravi Pratap <ravi@ximian.com>
16550 * typemanager.cs (AreMultipleAllowed): Take care of the most
16551 obvious case where attribute type is not in the current assembly -
16554 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16556 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16557 definitions, instead of doing that afterwards.
16559 Also we use a nice little hack, depending on the constructor, we
16560 know if we are a "composed" name or a simple name. Hence, we
16561 avoid the IndexOf test, and we avoid
16563 * codegen.cs: Add code to assist in a bug reporter to track down
16564 the source of a compiler crash.
16566 2002-12-07 Ravi Pratap <ravi@ximian.com>
16568 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16569 types have been emitted for a given element and flag an error
16570 if something which does not have AllowMultiple set is used more
16573 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16574 attribute types and their corresponding AllowMultiple properties
16576 (AreMultipleAllowed): Check the property for a given type.
16578 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16579 property in the case we have a TypeContainer.
16581 (Attributes.AddAttribute): Detect duplicates and just skip on
16582 adding them. This trivial fix catches a pretty gross error in our
16583 attribute emission - global attributes were being emitted twice!
16585 Bugzilla bug #33187 is now fixed.
16587 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16589 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16590 instead of pp_and).
16592 * expression.cs (Binary.ResolveOperator): I can only use the
16593 Concat (string, string, string) and Concat (string, string,
16594 string, string) if the child is actually a concatenation of
16597 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16599 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16600 context where we need a 2-character lookahead.
16602 * pending.cs (PendingImplementation): Rework so we can keep track
16603 of interface types all the time, and flag those which were
16604 implemented by parents as optional.
16606 2002-12-03 Miguel de Icaza <miguel@ximian.com>
16608 * expression.cs (Binary.ResolveOperator): Use
16609 String.Concat(string,string,string) or
16610 String.Concat(string,string,string,string) when possible.
16612 * typemanager: More helper methods.
16615 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
16617 * pending.cs: remove the bogus return from GetMissingInterfaces()
16618 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
16620 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16622 * namespace.cs: avoid duplicated 'using xxx' being added to
16623 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
16624 when we get more than one 'using' statement for the same namespace.
16625 Report a CS0105 warning for it.
16627 2002-11-30 Miguel de Icaza <miguel@ximian.com>
16629 * cs-tokenizer.cs (consume_identifier): use read directly, instead
16630 of calling getChar/putback, uses internal knowledge of it.
16632 (xtoken): Reorder tokenizer so most common patterns are checked
16633 first. This reduces the compilation time in another 5% (from 8.11s
16634 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
16636 The parsing time is 22% of the compilation in mcs, and from that
16637 64% is spent on the tokenization process.
16639 I tried using a binary search for keywords, but this is slower
16640 than the hashtable. Another option would be to do a couple of
16643 * Not use a StringBuilder, instead use an array of chars,
16644 with a set value. Notice that this way we could catch
16645 the 645 error without having to do it *afterwards*.
16647 * We could write a hand-parser to avoid the hashtable
16648 compares altogether.
16650 The identifier consumption process takes 37% of the tokenization
16651 time. Another 15% is spent on is_number. 56% of the time spent
16652 on is_number is spent on Int64.Parse:
16654 * We could probably choose based on the string length to
16655 use Int32.Parse or Int64.Parse and avoid all the 64-bit
16658 Another 3% is spend on wrapping `xtoken' in the `token' function.
16660 Handle 0xa0 as whitespace (#34752)
16662 2002-11-26 Miguel de Icaza <miguel@ximian.com>
16664 * typemanager.cs (IsCLRType): New routine to tell whether a type
16665 is one of the builtin types.
16667 Maybe it needs to use TypeCodes to be faster. Maybe we could use
16668 typecode in more places instead of doing pointer comparissions.
16669 We could leverage some knowledge about the way the typecodes are
16672 New code to cache namespaces in assemblies, it is currently not
16673 invoked, to be used soon.
16675 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
16677 * expression.cs (Binary.ResolveOperator): specially handle
16678 strings, and do not perform user-defined operator overloading for
16681 2002-11-24 Miguel de Icaza <miguel@ximian.com>
16683 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
16684 internalcall as it is a pretty simple operation; Avoid whenever
16685 possible to call Char.IsLetter.
16687 (consume_identifier): Cut by half the number of
16688 hashtable calls by merging the is_keyword and GetKeyword behavior.
16690 Do not short-circuit, because if we do, we
16691 report errors (ie, #if false && true would produce an invalid
16695 2002-11-24 Martin Baulig <martin@ximian.com>
16697 * expression.cs (Cast.TryReduce): If we're in checked syntax,
16698 check constant ranges and report a CS0221. Fixes #33186.
16700 2002-11-24 Martin Baulig <martin@ximian.com>
16702 * cs-parser.jay: Make this work for uninitialized variable
16703 declarations in the `for' initializer. Fixes #32416.
16705 2002-11-24 Martin Baulig <martin@ximian.com>
16707 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
16708 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
16710 2002-11-24 Martin Baulig <martin@ximian.com>
16712 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
16713 argument; if true, we also check for user-defined conversions.
16714 This is only needed if both arguments are of a user-defined type.
16715 Fixes #30443, added test-175.cs.
16716 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
16718 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
16720 2002-11-24 Martin Baulig <martin@ximian.com>
16722 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
16723 function to get the store opcode.
16724 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
16725 only emit the Ldelema if the store opcode is Stobj. You must run
16726 both test-34 and test-167 to test this. Fixes #34529.
16728 2002-11-23 Martin Baulig <martin@ximian.com>
16730 * ecore.cs (Expression.MemberLookup): Added additional
16731 `qualifier_type' argument which is used when we're being called
16732 from MemberAccess.DoResolve() and null if we're called from a
16734 (Expression.MemberLookupFailed): New method to report errors; this
16735 does the CS1540 check and reports the correct error message.
16737 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
16738 argument for the CS1540 check and redone the way how we're dealing
16739 with private members. See the comment in the source code for details.
16740 (FilterWithClosure): Reverted this back to revision 1.197; renamed
16741 `closure_start_type' to `closure_qualifier_type' and check whether
16742 it's not null. It was not this filter being broken, it was just
16743 being called with the wrong arguments.
16745 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
16746 and pass it the correct `qualifier_type'; this also does the error
16749 2002-11-22 Miguel de Icaza <miguel@ximian.com>
16751 * expression.cs (Invocation.EmitParams): If the we are dealing
16752 with a non-built-in value type, load its address as well.
16754 (ArrayCreation): Use a a pretty constant instead
16755 of the hardcoded value 2. Use 6 instead of 2 for the number of
16756 static initializers.
16758 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
16759 because they are not really value types, just glorified integers.
16761 * driver.cs: Do not append .exe, the CSC compiler does not do it.
16763 * ecore.cs: Remove redundant code for enumerations, make them use
16764 the same code path as everything else, fixes the casting issue
16765 with enumerations in Windows.Forms.
16767 * attribute.cs: Do only cast to string if it is a string, the
16768 validation happens later.
16770 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
16771 people upgrade their corlibs.
16773 * ecore.cs: Oops, enumerations were not following the entire code path
16775 2002-11-21 Miguel de Icaza <miguel@ximian.com>
16777 * typemanager.cs (FilterWithClosure): Commented out the test for
16778 1540 in typemanager.cs, as it has problems when accessing
16779 protected methods from a parent class (see test-174.cs).
16781 * attribute.cs (Attribute.ValidateGuid): new method.
16782 (Attribute.Resolve): Use above.
16784 2002-11-19 Miguel de Icaza <miguel@ximian.com>
16786 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
16788 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
16789 handling for enumerations, as we only needed the TypeContainer
16790 functionality to begin with (this is required for the fix below to
16791 work for enums that reference constants in a container class for
16794 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
16796 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
16797 a valid TypeBuilder to perform lookups on.o
16799 * class.cs (InheritableMemberSignatureCompare): Use true in the
16800 call to GetGetMethod and GetSetMethod, because we are comparing
16801 the signature, and we need to get the methods *even* if they are
16804 (PropertyBase.CheckBase): ditto.
16806 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
16807 GotoCase.Resolve): Use Peel on EmpytCasts.
16809 * ecore.cs (EmptyCast): drop child, add Peel method.
16811 2002-11-17 Martin Baulig <martin@ximian.com>
16813 * ecore.cs (EmptyCast.Child): New public property.
16815 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
16816 label resolved to an EmptyCast. Fixes #34162.
16817 (GotoCase.Resolve): Likewise.
16818 (Block.EmitMeta): Likewise.
16820 2002-11-17 Martin Baulig <martin@ximian.com>
16822 * expression.cs (Invocation.BetterConversion): Prefer int over
16823 uint; short over ushort; long over ulong for integer literals.
16824 Use ImplicitConversionExists instead of StandardConversionExists
16825 since we also need to check for user-defined implicit conversions.
16826 Fixes #34165. Added test-173.cs.
16828 2002-11-16 Martin Baulig <martin@ximian.com>
16830 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
16831 with the `true' and `false' literals. Fixes #33151.
16833 2002-11-16 Martin Baulig <martin@ximian.com>
16835 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
16836 October 22nd; don't do the cs1540 check for static members.
16838 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
16839 now using our own filter here and doing the cs1540 check again.
16841 2002-11-16 Martin Baulig <martin@ximian.com>
16843 * support.cs (InternalParameters): Don't crash if we don't have
16844 any fixed parameters. Fixes #33532.
16846 2002-11-16 Martin Baulig <martin@ximian.com>
16848 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
16849 when looking up static methods to make this work on Windows.
16852 2002-11-16 Martin Baulig <martin@ximian.com>
16854 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
16855 a setter rather than using PropertyInfo.CanWrite.
16857 2002-11-15 Nick Drochak <ndrochak@gol.com>
16859 * class.cs: Allow acces to block member by subclasses. Fixes build
16862 2002-11-14 Martin Baulig <martin@ximian.com>
16864 * class.cs (Constructor.Emit): Added the extern/block check.
16867 2002-11-14 Martin Baulig <martin@ximian.com>
16869 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
16870 iteration while looking for indexers, this is needed because the
16871 indexer may have a different name in our base classes. Fixed the
16872 error reporting (no indexers at all, not get accessor, no
16873 overloaded match). Fixes bug #33089.
16874 (IndexerAccess.DoResolveLValue): Likewise.
16876 2002-11-14 Martin Baulig <martin@ximian.com>
16878 * class.cs (PropertyBase.CheckBase): Make this work for multiple
16879 indexers. Fixes the first part of bug #33089.
16880 (MethodSignature.InheritableMemberSignatureCompare): Added support
16883 2002-11-13 Ravi Pratap <ravi@ximian.com>
16885 * attribute.cs (Attribute.Resolve): Catch the
16886 NullReferenceException and report it since it isn't supposed to
16889 2002-11-12 Miguel de Icaza <miguel@ximian.com>
16891 * expression.cs (Binary.EmitBranchable): Also handle the cases for
16892 LogicalOr and LogicalAnd that can benefit from recursively
16893 handling EmitBranchable. The code now should be nice for Paolo.
16895 2002-11-08 Miguel de Icaza <miguel@ximian.com>
16897 * typemanager.cs (LookupType): Added a negative-hit hashtable for
16898 the Type lookups, as we perform quite a number of lookups on
16899 non-Types. This can be removed once we can deterministically tell
16900 whether we have a type or a namespace in advance.
16902 But this might require special hacks from our corlib.
16906 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
16907 and double which avoids a conversion from an integer to a double.
16909 * expression.cs: tiny optimization, avoid calling IsConstant,
16910 because it effectively performs the lookup twice.
16912 2002-11-06 Miguel de Icaza <miguel@ximian.com>
16914 But a bogus return here to keep the semantics of the old code
16915 until the Mono runtime is fixed.
16917 * pending.cs (GetMissingInterfaces): New method used to remove all
16918 the interfaces that are already implemented by our parent
16919 classes from the list of pending methods.
16921 * interface.cs: Add checks for calls after ResolveTypeExpr.
16923 2002-11-05 Miguel de Icaza <miguel@ximian.com>
16925 * class.cs (Class.Emit): Report warning 67: event not used if the
16926 warning level is beyond 3.
16928 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
16929 being a NullLiteral.
16931 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
16934 * class.cs (TypeContainer.GetClassBases): Cover a missing code
16935 path that might fail if a type can not be resolved.
16937 * expression.cs (Binary.Emit): Emit unsigned versions of the
16940 * driver.cs: use error 5.
16942 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
16944 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
16946 2002-11-01 Miguel de Icaza <miguel@ximian.com>
16948 * cs-parser.jay (switch_section): A beautiful patch from Martin
16949 Baulig that fixed 33094.
16951 2002-10-31 Miguel de Icaza <miguel@ximian.com>
16953 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
16954 Check whether the base is abstract and report an error if so.
16956 * expression.cs (IndexerAccess.DoResolveLValue,
16957 IndexerAccess.DoResolve): ditto.
16959 (Invocation.DoResolve): ditto.
16961 (Invocation.FullMethodDesc): Improve the report string.
16963 * statement.cs (Block): Eliminate IsVariableDefined as it is
16964 basically just a wrapper for GetVariableInfo.
16966 * ecore.cs (SimpleName): Use new
16968 * support.cs (ReflectionParamter.ParameterType): We unwrap the
16969 type, as we return the actual parameter ref/unref state on a
16972 2002-10-30 Miguel de Icaza <miguel@ximian.com>
16974 * support.cs: Return proper flags REF/OUT fixing the previous
16977 * expression.cs: Reverted last patch, that was wrong. Is_ref is
16978 not used to mean `ref' but `ref or out' in ParameterReference
16980 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
16981 full type signature instead of calling TypeManger.CSharpName
16984 * support.cs (InternalParameters.ParameterDesc): Do not compare
16985 directly to the modflags, because REF/OUT will actually be bitsets
16988 * delegate.cs (VerifyMethod): Check also the modifiers.
16990 * cs-tokenizer.cs: Fix bug where floating point values with an
16991 exponent where a sign was missing was ignored.
16993 * driver.cs: Allow multiple assemblies to be specified in a single
16996 2002-10-28 Miguel de Icaza <miguel@ximian.com>
16998 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
16999 because identifiers after a parenthesis would end up in this kind
17000 of production, and we needed to desamiguate it for having casts
17003 (UserDefinedType *) xxx
17005 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17007 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17008 we should set on the Bindingflags.NonPublic, but not turn on
17009 private_ok. private_ok controls whether a Private member is
17010 returned (this is chekced on the filter routine), while the
17011 BindingFlags.NonPublic just controls whether private/protected
17012 will be allowed. This fixes the problem part of the problem of
17013 private properties being allowed to be used in derived classes.
17015 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17016 so we can call the children DoResolveLValue method (this will
17017 properly signal errors on lvalue assignments to base properties)
17019 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17020 getter are null, and we have a property info, we know that this
17021 happened because the lookup failed, so we report an error 122 for
17022 protection level violation.
17024 We also silently return if setter and getter are null in the
17025 resolve functions, this condition only happens if we have flagged
17026 the error before. This is the other half of the problem.
17028 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17029 not have accessibility information, that is why we were returning
17030 true in the filter function in typemanager.cs.
17032 To properly report 122 (property is inaccessible because of its
17033 protection level) correctly, we report this error in ResolveAccess
17034 by failing if both the setter and the getter are lacking (ie, the
17037 DoResolve and DoLResolve have been modified to check for both
17038 setter/getter being null and returning silently, the reason being
17039 that I did not want to put the knowledge about this error in upper
17042 int old = Report.Errors;
17043 x = new PropertyExpr (...);
17044 if (old != Report.Errors)
17049 So the property expr is returned, but it is invalid, so the error
17050 will be flagged during the resolve process.
17052 * class.cs: Remove InheritablePropertySignatureCompare from the
17053 class, as we no longer depend on the property signature to compute
17054 whether it is possible to implement a method or not.
17056 The reason is that calling PropertyInfo.GetGetMethod will return
17057 null (in .NET, in Mono it works, and we should change this), in
17058 cases where the Get Method does not exist in that particular
17063 class X { public virtual int A { get { return 1; } } }
17065 class Z : Y { public override int A { get { return 2; } } }
17067 Would fail in Z because the parent (Y) would not have the property
17068 defined. So we avoid this completely now (because the alternative
17069 fix was ugly and slow), and we now depend exclusively on the
17072 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17073 reference method, instead of using the property.
17075 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17076 routines are gone now.
17078 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17079 names, they were incorrectly named.
17081 * cs-tokenizer.cs: Return are more gentle token on failure.
17083 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17084 had an out-of-sync index variable, which caused it to remove from
17085 the list of pending methods the wrong method sometimes.
17087 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17089 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17090 CanWrite, because those refer to this particular instance of the
17091 property, and do not take into account the fact that we can
17092 override single members of a property.
17094 Constructor requires an EmitContext. The resolution process does
17095 not happen here, but we need to compute the accessors before,
17096 because the resolution does not always happen for properties.
17098 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17099 subclass, before we did not update this flag, but we did update
17102 (GetAccessors): Drop this routine, as it did not work in the
17103 presence of partially overwritten set/get methods.
17105 Notice that this broke the cs1540 detection, but that will require
17108 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17112 * driver.cs: issue a warning instead of an error if we don't support
17113 debugging for the platform. Also ignore a couple of errors that may
17114 arise when trying to write the symbols. Undo my previous patch.
17116 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17118 * driver.cs: ignore /debug switch except for Unix platforms.
17120 2002-10-23 Nick Drochak <ndrochak@gol.com>
17122 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17124 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17126 * driver.cs: Do not make mcs-debug conditional, so we do not break
17127 builds that use it.
17129 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17130 review this patch. But basically after all the children variables
17131 have been merged, the value of "Breaks" was not being set to
17132 new_breaks for Switch blocks. I think that it should be set after
17133 it has executed. Currently I set this to the value of new_breaks,
17134 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17135 conservative, but I do not understand this code very well.
17137 I did not break anything in the build, so that is good ;-)
17139 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17141 2002-10-20 Mark Crichton <crichton@gimp.org>
17143 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17145 2002-10-20 Nick Drochak <ndrochak@gol.com>
17147 * cfold.cs: Fixed compile blocker.
17149 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17151 * driver.cs: I was chekcing the key, not the file.
17153 2002-10-19 Ravi Pratap <ravi@ximian.com>
17155 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17156 message that we were generating - we just need to silently return
17159 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17161 * class.cs (Event.Define): Change my previous commit, as this
17162 breaks the debugger. This is a temporary hack, as it seems like
17163 the compiler is generating events incorrectly to begin with.
17165 * expression.cs (Binary.ResolveOperator): Added support for
17166 "U operator - (E x, E y)"
17168 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17171 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17172 init-only variables, but this path did not take into account that
17173 there might be also instance readonly variables. Correct this
17176 This fixes bug 32253
17178 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17181 * driver.cs: Change the extension for modules to `netmodule'
17183 * cs-parser.jay: Improved slightly the location tracking for
17184 the debugger symbols.
17186 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17187 modifiers that were specified instead of the hardcoded value
17188 (FamAndAssem). This was basically ignoring the static modifier,
17189 and others. Fixes 32429.
17191 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17192 fixed a bug in the process (32476)
17194 * expression.cs (ArrayAccess.EmitAssign): Patch from
17195 hwang_rob@yahoo.ca that fixes bug 31834.3
17197 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17199 * driver.cs: Make the module extension .netmodule.
17201 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17203 * driver.cs: Report an error if the resource file is not found
17204 instead of crashing.
17206 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17207 false, like Emit does.
17209 2002-10-16 Nick Drochak <ndrochak@gol.com>
17211 * typemanager.cs: Remove unused private member. Also reported mcs
17212 bug to report this as a warning like csc.
17214 2002-10-15 Martin Baulig <martin@gnome.org>
17216 * statement.cs (Statement.Emit): Made this a virtual method; emits
17217 the line number info and calls DoEmit().
17218 (Statement.DoEmit): New protected abstract method, formerly knows
17219 as Statement.Emit().
17221 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17223 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17225 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17226 have fixed a remaining problem: not every AddXXXX was adding a
17227 fully qualified name.
17229 Now everyone registers a fully qualified name in the DeclSpace as
17230 being defined instead of the partial name.
17232 Downsides: we are slower than we need to be due to the excess
17233 copies and the names being registered this way.
17235 The reason for this is that we currently depend (on the corlib
17236 bootstrap for instance) that types are fully qualified, because
17237 we dump all the types in the namespace, and we should really have
17238 types inserted into the proper namespace, so we can only store the
17239 basenames in the defined_names array.
17241 2002-10-10 Martin Baulig <martin@gnome.org>
17243 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17244 from bug #31834, see the bug report for a testcase which is
17247 2002-10-10 Martin Baulig <martin@gnome.org>
17249 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17250 flow analysis code for this.
17252 * statement.cs (Do, While, For): Tell the flow analysis code about
17254 (FlowBranching.UsageVector): Added support for infinite loops.
17255 (Block.Resolve): Moved the dead code elimination here and use flow
17258 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17260 * class.cs (Field.Define): Catch cycles on struct type
17263 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17264 fields if the fields are static. We only need to check instance
17267 * expression.cs (As.DoResolve): Test for reference type.
17269 * statement.cs (Using.ResolveExpression): Use
17270 ConvertImplicitRequired, not ConvertImplicit which reports an
17272 (Using.ResolveLocalVariableDecls): ditto.
17274 * expression.cs (Binary.ResolveOperator): Report errors in a few
17275 places where we had to.
17277 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17279 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17281 * expression.cs: Use StoreFromPtr instead of extracting the type
17282 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17284 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17285 an enumeration value to a System.Enum, but System.Enum is not a
17286 value type, but an class type, so we need to box.
17288 (Expression.ConvertExplicit): One codepath could return
17289 errors but not flag them. Fix this. Fixes #31853
17291 * parameter.cs (Resolve): Do not allow void as a parameter type.
17293 2002-10-06 Martin Baulig <martin@gnome.org>
17295 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17296 if it's a class type and not a struct. Fixes #31815.
17298 2002-10-06 Martin Baulig <martin@gnome.org>
17300 * statement.cs: Reworked the flow analysis code a bit to make it
17301 usable for dead code elimination.
17303 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17305 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17307 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17309 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17310 to fix the test 165, will investigate deeper.
17312 2002-10-04 Martin Baulig <martin@gnome.org>
17314 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17315 finally blocks actually work.
17316 (Try.Resolve): We don't need to create a sibling for `finally' if
17317 there is no finally block.
17319 2002-10-04 Martin Baulig <martin@gnome.org>
17321 * class.cs (Constructor.Define): The default accessibility for a
17322 non-default constructor is private, not public.
17324 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17326 * class.cs (Constructor): Make AllowedModifiers public, add
17329 * cs-parser.jay: Perform the modifiers test here, as the
17330 constructor for the Constructor class usually receives a zero
17331 because of the way we create it (first we create, later we
17332 customize, and we were never checking the modifiers).
17334 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17335 is a version of LookupTypeReflection that includes the type-name
17336 cache. This can be used as a fast path for functions that know
17337 the fully qualified name and are only calling into *.GetType() to
17338 obtain a composed type.
17340 This is also used by TypeManager.LookupType during its type
17343 (LookupType): We now also track the real type name, as sometimes
17344 we can get a quey for the real type name from things like
17345 ComposedCast. This fixes bug 31422.
17347 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17348 complete type fullname, it does not have to go through the type
17349 resolution system to obtain the composed version of the type (for
17350 obtaining arrays or pointers).
17352 (Conditional.Emit): Use the EmitBoolExpression to
17353 generate nicer code, as requested by Paolo.
17355 (ArrayCreation.CheckIndices): Use the patch from
17356 hwang_rob@yahoo.ca to validate the array initializers.
17358 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17360 * class.cs (ConstructorInitializer.Emit): simplify code by using
17361 Invocation.EmitCall, and at the same time, fix the bugs in calling
17362 parent constructors that took variable arguments.
17364 * ecore.cs (Expression.ConvertNumericExplicit,
17365 Expression.ImplicitNumericConversion): Remove the code that
17366 manually wrapped decimal (InternalTypeConstructor call is now gone
17369 * expression.cs (Cast.TryReduce): Also handle decimal types when
17370 trying to perform a constant fold on the type.
17372 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17374 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17375 that only turned off an error report, and did nothing else.
17377 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17379 * driver.cs: Handle and ignore /fullpaths
17381 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17383 * expression.cs (Binary.ResolveOperator): Catch the case where
17384 DoNumericPromotions returns true,
17386 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17388 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17390 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17393 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17395 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17396 conversion exists, but it is also required that the conversion be
17397 performed. This manifested in "(Type64Enum) 2".
17399 * class.cs (TypeManager.AddMethod): The fix is not to change
17400 AddEnum, because that one was using a fully qualified name (every
17401 DeclSpace derivative does), but to change the AddMethod routine
17402 that was using an un-namespaced name. This now correctly reports
17403 the duplicated name.
17405 Revert patch until I can properly fix it. The issue
17406 is that we have a shared Type space across all namespaces
17407 currently, which is wrong.
17409 Options include making the Namespace a DeclSpace, and merge
17410 current_namespace/current_container in the parser.
17412 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17414 * cs-parser.jay: Improve error reporting when we get a different
17415 kind of expression in local_variable_type and
17416 local_variable_pointer_type.
17418 Propagate this to avoid missleading errors being reported.
17420 * ecore.cs (ImplicitReferenceConversion): treat
17421 TypeManager.value_type as a target just like object_type. As
17426 Is valid, and needs to result in the int 1 being boxed before it
17427 is assigned to the value type v.
17429 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17430 to validate the enumeration name.
17432 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17433 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17434 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17436 * ecore.cs (TryImplicitIntConversion): When doing an
17437 implicit-enumeration-conversion, check if the type is 64-bits and
17438 perform a conversion before passing to EnumConstant.
17440 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17442 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17443 report ambiguous type references. Unlike the MS version, we
17444 report what the ambiguity is. Innovation at work ;-)
17446 (DeclSpace.FindType): Require a location argument to
17447 display when we display an ambiguous error.
17449 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17451 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17453 * expression.cs (EmitDynamicInitializers): Apply patch from
17454 hwang_rob@yahoo.ca that fixes the order in which we emit our
17457 2002-09-21 Martin Baulig <martin@gnome.org>
17459 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17460 delegate takes no arguments.
17462 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17464 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17467 * expression.cs: Extract the underlying type.
17469 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17471 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17473 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17475 * class.cs (TypeContainer.DefineType): We can not use the nice
17476 PackingSize with the size set to 1 DefineType method, because it
17477 will not allow us to define the interfaces that the struct
17480 This completes the fixing of bug 27287
17482 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17483 means also structs. This fixes part of the problem.
17484 (Expresion.ImplicitReferenceConversionExists): ditto.
17486 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17487 error if there were no errors reported during the type lookup
17488 process, to avoid duplicates or redundant errors. Without this
17489 you would get an ambiguous errors plus a type not found. We have
17490 beaten the user enough with the first error.
17492 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17495 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17496 during the resolution process, stop the lookup, this avoids
17497 repeated error reports (same error twice).
17499 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17501 * typemanager.cs (LookupType): Redo the type lookup code to match
17502 the needs of System.Reflection.
17504 The issue is that System.Reflection requires references to nested
17505 types to begin with a "+" sign instead of a dot. So toplevel
17506 types look like: "NameSpace.TopLevelClass", and nested ones look
17507 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17510 2002-09-19 Martin Baulig <martin@gnome.org>
17512 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17513 says that a method always returns or always throws an exception,
17514 don't report the CS0161.
17516 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17517 set `Returns = new_returns'.
17519 2002-09-19 Martin Baulig <martin@gnome.org>
17521 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17522 to an enum constant, check for a CS0176.
17524 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17526 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17527 for operators that must be in pairs and report errors.
17529 * ecore.cs (SimpleName.DoResolveType): During the initial type
17530 resolution process, when we define types recursively, we must
17531 check first for types in our current scope before we perform
17532 lookups in the enclosing scopes.
17534 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17536 (Invocation.VerifyArgumentsCompat): Call
17537 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17538 I thought we were supposed to always call this, but there are a
17539 few places in the code where we dont do it.
17541 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17543 * driver.cs: Add support in -linkres and -resource to specify the
17544 name of the identifier.
17546 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17548 * ecore.cs (StandardConversionExists): Sync with the conversion
17549 code: allow anything-* to void* conversions.
17551 (FindMostSpecificSource): Use an Expression argument
17552 instead of a Type, because we might be handed over a Literal which
17553 gets a few more implicit conversions that plain types do not. So
17554 this information was being lost.
17556 Also, we drop the temporary type-holder expression when not
17559 2002-09-17 Martin Baulig <martin@gnome.org>
17561 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17562 this is an explicit interface implementation.
17564 2002-09-17 Martin Baulig <martin@gnome.org>
17566 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17567 different `IndexerName' attributes.
17569 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17570 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17571 virtual CommonResolve().
17573 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17575 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17576 and convert that to the UnderlyingType.
17578 * statement.cs (Foreach.Resolve): Indexers are just like variables
17579 or PropertyAccesses.
17581 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17582 inside quoted strings, we were not doing this before.
17584 2002-09-16 Martin Baulig <martin@gnome.org>
17586 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17587 resolve it. This is needed for the definite assignment check of the
17588 instance expression, fixes bug #29846.
17589 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17591 2002-09-16 Nick Drochak <ndrochak@gol.com>
17593 * parameter.cs: Fix compile error. Cannot reference static member
17594 from an instance object. Is this an mcs bug?
17596 2002-09-14 Martin Baulig <martin@gnome.org>
17598 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17599 multiple times. Fixes bug #30295, added test-166.cs.
17601 2002-09-14 Martin Baulig <martin@gnome.org>
17603 * statement.cs (Block.Emit): Don't emit unreachable code.
17604 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
17605 `break' statements.
17606 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
17608 2002-09-14 Martin Baulig <martin@gnome.org>
17610 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
17613 2002-09-14 Martin Baulig <martin@gnome.org>
17615 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
17616 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
17617 be false on the ms runtime.
17619 2002-09-13 Martin Baulig <martin@gnome.org>
17621 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
17622 the CS0038 error message.
17624 2002-09-12 Miguel de Icaza <miguel@ximian.com>
17626 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
17627 constant inside, return it.
17629 2002-09-12 Martin Baulig <martin@gnome.org>
17631 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
17632 implicit conversion can be done between enum types.
17634 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
17635 check whether an implicit conversion to the current enum's UnderlyingType
17636 exists and report an error if not.
17638 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
17639 without debugging support.
17641 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
17642 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
17644 2002-09-12 Martin Baulig <martin@gnome.org>
17646 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
17648 * ecore.cs (IMemberExpr.DeclaringType): New property.
17649 (SimpleName.SimpleNameResolve): Check whether we're accessing a
17650 nonstatic member of an outer type (CS0038).
17652 2002-09-11 Miguel de Icaza <miguel@ximian.com>
17654 * driver.cs: Activate the using-error detector at warning level
17655 4 (at least for MS-compatible APIs).
17657 * namespace.cs (VerifyUsing): Small buglett fix.
17659 * pending.cs (PendingImplementation): pass the container pointer.
17661 * interface.cs (GetMethods): Allow for recursive definition. Long
17662 term, I would like to move every type to support recursive
17663 definitions, not the current ordering mechanism that we have right
17666 The situation is this: Attributes are handled before interfaces,
17667 so we can apply attributes to interfaces. But some attributes
17668 implement interfaces, we will now handle the simple cases
17669 (recursive definitions will just get an error).
17671 * parameter.cs: Only invalidate types at the end if we fail to
17674 2002-09-09 Martin Baulig <martin@gnome.org>
17676 * ecore.cs (PropertyExpr.Emit): Also check for
17677 TypeManager.system_int_array_get_length so this'll also work when
17678 compiling corlib. Fixes #30003.
17680 2002-09-09 Martin Baulig <martin@gnome.org>
17682 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
17683 and throw an exception if we can't get the type's size. Fixed #30040,
17686 2002-09-09 Martin Baulig <martin@gnome.org>
17688 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
17690 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
17691 context. Fixes bug #30027.
17693 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
17694 virtual functions. Fixes bug #30043, added test-164.cs.
17696 2002-09-08 Ravi Pratap <ravi@ximian.com>
17698 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
17700 2002-09-08 Nick Drochak <ndrochak@gol.com>
17702 * driver.cs: Use an object to get the windows codepage since it's not a
17705 2002-09-08 Miguel de Icaza <miguel@ximian.com>
17707 * statement.cs (For.Emit): for infinite loops (test == null)
17708 return whether there is a break inside, not always "true".
17710 * namespace.cs (UsingEntry): New struct to hold the name of the
17711 using definition, the location where it is defined, and whether it
17712 has been used in a successful type lookup.
17714 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
17719 2002-09-06 Ravi Pratap <ravi@ximian.com>
17721 * attribute.cs : Fix incorrect code which relied on catching
17722 a NullReferenceException to detect a null being passed in
17723 where an object was expected.
17725 2002-09-06 Miguel de Icaza <miguel@ximian.com>
17727 * statement.cs (Try): flag the catch variable as assigned
17729 * expression.cs (Cast): Simplified by using ResolveType instead of
17730 manually resolving.
17732 * statement.cs (Catch): Fix bug by using ResolveType.
17734 2002-09-06 Ravi Pratap <ravi@ximian.com>
17736 * expression.cs (BetterConversion): Special case for when we have
17737 a NullLiteral as the argument and we have to choose between string
17738 and object types - we choose string the way csc does.
17740 * attribute.cs (Attribute.Resolve): Catch the
17741 NullReferenceException and report error #182 since the Mono
17742 runtime no more has the bug and having this exception raised means
17743 we tried to select a constructor which takes an object and is
17746 2002-09-05 Ravi Pratap <ravi@ximian.com>
17748 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
17749 message (1502, 1503) when we can't locate a method after overload
17750 resolution. This is much more informative and closes the bug
17753 * interface.cs (PopulateMethod): Return if there are no argument
17754 types. Fixes a NullReferenceException bug.
17756 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
17757 expressions too. Previously we were checking only in one place for
17758 positional arguments leaving out named arguments.
17760 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
17761 type to the enum type is not allowed. Remove code corresponding to
17764 (ConvertNumericExplicit): Allow explicit conversions from
17765 the underlying type to enum type. This precisely follows the spec
17766 and closes a bug filed by Gonzalo.
17768 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17771 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
17773 2002-09-03 Miguel de Icaza <miguel@ximian.com>
17775 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
17776 it was important that we stored the right value after the
17777 reduction in `converted'.
17779 2002-09-04 Martin Baulig <martin@gnome.org>
17781 * location.cs (Location.SymbolDocument): Use full pathnames for the
17784 2002-08-30 Miguel de Icaza <miguel@ximian.com>
17786 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
17787 of the expression resolve mechanism, because that will catch the
17788 SimpleName error failures.
17790 (Conditional): If we can not resolve the
17791 expression, return, do not crash.
17793 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17796 (location): display token name instead of its number.
17798 2002-08-28 Martin Baulig <martin@gnome.org>
17800 * expression.cs (Binary.ResolveOperator): Don't silently return
17801 but return an error if an operator cannot be applied between two
17804 2002-08-28 Martin Baulig <martin@gnome.org>
17806 * class.cs (Constructor.Define): Set the permission attributes
17807 correctly instead of making all constructors public.
17809 2002-08-28 Martin Baulig <martin@gnome.org>
17811 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
17812 for private members before reporting a CS0103; if we find anything,
17815 2002-08-28 Martin Baulig <martin@gnome.org>
17817 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
17818 to check whether `closure_start_type == closure_invocation_type',
17819 we also need to check whether `m.DeclaringType == closure_invocation_type'
17820 before bypassing the permission checks. We might be accessing
17821 protected/private members from the base class.
17822 (TypeManager.RealMemberLookup): Only set private_ok if private
17823 members were requested via BindingFlags.NonPublic.
17825 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
17827 * expression.cs (MemberAccess.ResolveMemberAccess): Set
17828 MethodGroupExpr.IsExplicitImpl if appropriate.
17829 (Invocation.DoResolve): Don't report the CS0120 for explicit
17830 interface implementations.
17832 2002-08-27 Martin Baulig <martin@gnome.org>
17834 * expression.cs (Invocation.DoResolve): If this is a static
17835 method and we don't have an InstanceExpression, we must report
17838 2002-08-25 Martin Baulig <martin@gnome.org>
17840 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
17841 `==' between a valuetype and an object.
17843 2002-08-25 Miguel de Icaza <miguel@ximian.com>
17845 * ecore.cs (TypeExpr): Provide a ToString method.
17847 2002-08-24 Martin Baulig <martin@gnome.org>
17849 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
17850 now called proggie.dbg and it's a binary file.
17852 2002-08-23 Martin Baulig <martin@gnome.org>
17854 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
17856 2002-08-23 Martin Baulig <martin@gnome.org>
17858 * struct.cs (MyStructInfo.ctor): Make this work with empty
17859 structs; it's not allowed to use foreach() on null.
17861 2002-08-23 Martin Baulig <martin@gnome.org>
17863 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
17864 writer the full pathname of the generated assembly.
17866 2002-08-23 Martin Baulig <martin@gnome.org>
17868 * statements.cs (FlowBranching.UsageVector.MergeChildren):
17869 A `finally' block never returns or breaks; improved handling of
17872 2002-08-23 Martin Baulig <martin@gnome.org>
17874 * statement.cs (Throw.Resolve): Allow `throw null'.
17876 2002-08-23 Martin Baulig <martin@gnome.org>
17878 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
17879 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
17880 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
17881 MemberLookup would return a wrong event if this is an explicit
17882 interface implementation and the class has an event with the same
17885 2002-08-23 Martin Baulig <martin@gnome.org>
17887 * statement.cs (Block.AddChildVariableNames): New public method.
17888 (Block.AddChildVariableName): Likewise.
17889 (Block.IsVariableNameUsedInChildBlock): Likewise.
17890 (Block.AddVariable): Check whether a variable name has already
17891 been used in a child block.
17893 * cs-parser.jay (declare_local_variables): Mark all variable names
17894 from the current block as being used in a child block in the
17897 2002-08-23 Martin Baulig <martin@gnome.org>
17899 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
17900 find the symbol writer.
17902 * driver.cs: csc also allows the arguments to /define being
17903 separated by commas, not only by semicolons.
17905 2002-08-23 Martin Baulig <martin@gnome.org>
17907 * interface.cs (Interface.GetMembers): Added static check for events.
17909 2002-08-15 Martin Baulig <martin@gnome.org>
17911 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
17912 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
17914 * ecore.cs (Expression.MemberLookup): Added documentation and explained
17915 why the MethodData.EmitDestructor() change was necessary.
17917 2002-08-20 Martin Baulig <martin@gnome.org>
17919 * class.cs (TypeContainer.FindMembers): Added static check for events.
17921 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
17923 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
17924 use Type.GetEvents(), not Type.FindMembers().
17926 2002-08-20 Martin Baulig <martin@gnome.org>
17928 * decl.cs (MemberCache): Added a special method cache which will
17929 be used for method-only searched. This ensures that a method
17930 search will return a MethodInfo with the correct ReflectedType for
17933 2002-08-20 Martin Baulig <martin@gnome.org>
17935 * decl.cs (DeclSpace.FindMembers): Made this public.
17937 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17939 * delegate.cs: fixed build on windows.
17940 [FIXME: Filed as bug #29150: MCS must report these errors.]
17942 2002-08-19 Ravi Pratap <ravi@ximian.com>
17944 * ecore.cs (StandardConversionExists): Return a false
17945 if we are trying to convert the void type to anything else
17946 since that is not allowed.
17948 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
17949 we flag error 70 in the event an event is trying to be accessed
17950 directly from outside the declaring type.
17952 2002-08-20 Martin Baulig <martin@gnome.org>
17954 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
17955 MemberCache from typemanager.cs to decl.cs.
17957 2002-08-19 Martin Baulig <martin@gnome.org>
17959 * class.cs (TypeContainer): Implement IMemberContainer.
17960 (TypeContainer.DefineMembers): Create the MemberCache.
17961 (TypeContainer.FindMembers): Do better BindingFlags checking; only
17962 return public members if BindingFlags.Public was given, check
17963 whether members are static.
17965 2002-08-16 Martin Baulig <martin@gnome.org>
17967 * decl.cs (DeclSpace.Define): Splitted this in Define and
17968 DefineMembers. DefineMembers is called first and initializes the
17971 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
17972 DefineMembers() on all our DeclSpaces.
17974 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
17975 but call DefineMembers() on all nested interfaces. We call their
17976 Define() in our new Define() function.
17978 * interface.cs (Interface): Implement IMemberContainer.
17979 (Interface.Define): Moved all code except the attribute stuf to
17981 (Interface.DefineMembers): Initialize the member cache.
17983 * typemanager.cs (IMemberFinder): Removed this interface, we don't
17984 need this anymore since we can use MemberCache.FindMembers directly.
17986 2002-08-19 Martin Baulig <martin@gnome.org>
17988 * typemanager.cs (MemberCache): When creating the cache for an
17989 interface type, add all inherited members.
17990 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
17991 to `out bool used_cache' and documented it.
17992 (TypeManager.MemberLookup): If we already used the cache in the first
17993 iteration, we don't need to do the interfaces check.
17995 2002-08-19 Martin Baulig <martin@gnome.org>
17997 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
17998 here from IMemberFinder and don't implement this interface anymore.
17999 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18001 * typemanager.cs (IMemberFinder): This interface is now only used by
18002 classes which actually support the member cache.
18003 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18004 since we only put DeclSpaces into this Hashtable.
18005 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18006 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18008 2002-08-16 Martin Baulig <martin@gnome.org>
18010 * typemanager.cs (ICachingMemberFinder): Removed.
18011 (IMemberFinder.MemberCache): New property.
18012 (TypeManager.FindMembers): Merged this with RealFindMembers().
18013 This function will never be called from TypeManager.MemberLookup()
18014 so we can't use the cache here, just the IMemberFinder.
18015 (TypeManager.MemberLookup_FindMembers): Check whether the
18016 IMemberFinder has a MemberCache and call the cache's FindMembers
18018 (MemberCache): Rewrote larger parts of this yet another time and
18019 cleaned it up a bit.
18021 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18023 * driver.cs (LoadArgs): Support quoting.
18025 (Usage): Show the CSC-like command line arguments.
18027 Improved a few error messages.
18029 2002-08-15 Martin Baulig <martin@gnome.org>
18031 * typemanager.cs (IMemberContainer.Type): New property.
18032 (IMemberContainer.IsInterface): New property.
18034 The following changes are conditional to BROKEN_RUNTIME, which is
18035 defined at the top of the file.
18037 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18038 class'es members, but add all members from TypeHandle.ObjectType
18039 if we're an interface.
18040 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18041 is the current type.
18042 (MemberCache.CacheEntry.Container): Removed this field.
18043 (TypeHandle.GetMembers): Include inherited members.
18045 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18047 * typemanager.cs: fixed compilation and added a comment on a field that
18050 2002-08-15 Martin Baulig <martin@gnome.org>
18052 * class.cs (ConstructorInitializer.Resolve): In the
18053 Expression.MemberLookup call, use the queried_type as
18056 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18057 declared' attribute, it's always true.
18058 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18059 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18060 temporary wrapper for FindMembers which tells MemberLookup whether
18061 members from the base classes are included in the return value.
18062 This will go away soon.
18063 (TypeManager.MemberLookup): Use this temporary hack here; once the
18064 new MemberCache is completed, we don't need to do the DeclaredOnly
18065 looping here anymore since the MemberCache will take care of this.
18066 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18067 (MemberCache): When creating the MemberCache for a class, get
18068 members from the current class and all its base classes.
18069 (MemberCache.CacheEntry.Container): New field. This is a
18070 temporary hack until the Mono runtime is fixed to distinguish
18071 between ReflectedType and DeclaringType. It allows us to use MCS
18072 with both the MS runtime and the unfixed Mono runtime without
18073 problems and without accecting performance.
18074 (MemberCache.SearchMembers): The DeclaredOnly looping from
18075 TypeManager.MemberLookup is now done here.
18077 2002-08-14 Martin Baulig <martin@gnome.org>
18079 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18080 Type.GetFields on dynamic types but get the fields from the
18081 corresponding TypeContainer.
18082 (MyStructInfo.GetStructInfo): Added check for enum types.
18084 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18085 (MemberList.SyncRoot): Implemented.
18086 (TypeManager.FilterWithClosure): No need to check permissions if
18087 closure_start_type == closure_invocation_type, don't crash if
18088 closure_invocation_type is null.
18090 2002-08-13 Martin Baulig <martin@gnome.org>
18092 Rewrote TypeContainer.FindMembers to use a member cache. This
18093 gives us a speed increase of about 35% for the self-hosting MCS
18094 build and of about 15-20% for the class libs (both on GNU/Linux).
18096 * report.cs (Timer): New class to get enhanced profiling. This
18097 whole class is "TIMER" conditional since it remarkably slows down
18100 * class.cs (MemberList): New class. This is an IList wrapper
18101 which we're now using instead of passing MemberInfo[]'s around to
18102 avoid copying this array unnecessarily.
18103 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18104 (ICachingMemberFinder, IMemberContainer): New interface.
18105 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18106 has already been checked, otherwise use it for the name comparision.
18107 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18108 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18109 if possible. Returns a MemberList, not a MemberInfo [].
18110 (TypeHandle): New class, implements IMemberContainer. We create
18111 one instance of this class per type, it contains a MemberCache
18112 which is used to do the member lookups.
18113 (MemberCache): New class. Each instance of this class contains
18114 all members of a type and a name-based hash table.
18115 (MemberCache.FindMembers): This is our new member lookup
18116 function. First, it looks up all members of the requested name in
18117 the hash table. Then, it walks this list and sorts out all
18118 applicable members and returns them.
18120 2002-08-13 Martin Baulig <martin@gnome.org>
18122 In addition to a nice code cleanup, this gives us a performance
18123 increase of about 1.4% on GNU/Linux - not much, but it's already
18124 half a second for the self-hosting MCS compilation.
18126 * typemanager.cs (IMemberFinder): New interface. It is used by
18127 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18128 Enum, Delegate or Interface.
18129 (TypeManager.finder_to_member_finder): New PtrHashtable.
18130 (TypeManager.finder_to_container): Removed.
18131 (TypeManager.finder_to_delegate): Removed.
18132 (TypeManager.finder_to_interface): Removed.
18133 (TypeManager.finder_to_enum): Removed.
18135 * interface.cs (Interface): Implement IMemberFinder.
18137 * delegate.cs (Delegate): Implement IMemberFinder.
18139 * enum.cs (Enum): Implement IMemberFinder.
18141 * class.cs (TypeContainer): Implement IMemberFinder.
18143 2002-08-12 Martin Baulig <martin@gnome.org>
18145 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18147 2002-08-12 Martin Baulig <martin@gnome.org>
18149 * ecore.cs (ITypeExpression): New interface for expressions which
18151 (TypeExpression): Renamed to TypeLookupExpression.
18152 (Expression.DoResolve): If we're doing a types-only lookup, the
18153 expression must implement the ITypeExpression interface and we
18154 call DoResolveType() on it.
18155 (SimpleName): Implement the new ITypeExpression interface.
18156 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18157 hack, the situation that we're only looking up types can't happen
18158 anymore when this method is called. Moved the type lookup code to
18159 DoResolveType() and call it.
18160 (SimpleName.DoResolveType): This ITypeExpression interface method
18161 is now doing the types-only lookup.
18162 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18163 (ResolveFlags): Added MaskExprClass.
18165 * expression.cs (MemberAccess): Implement the ITypeExpression
18167 (MemberAccess.DoResolve): Added support for a types-only lookup
18168 when we're called via ITypeExpression.DoResolveType().
18169 (ComposedCast): Implement the ITypeExpression interface.
18171 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18172 Expression.Resolve() with ResolveFlags.Type instead.
18174 2002-08-12 Martin Baulig <martin@gnome.org>
18176 * interface.cs (Interface.Define): Apply attributes.
18178 * attribute.cs (Attribute.ApplyAttributes): Added support for
18179 interface attributes.
18181 2002-08-11 Martin Baulig <martin@gnome.org>
18183 * statement.cs (Block.Emit): Only check the "this" variable if we
18184 do not always throw an exception.
18186 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18187 whether the property has a set accessor.
18189 2002-08-11 Martin Baulig <martin@gnome.org>
18191 Added control flow analysis support for structs.
18193 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18194 with control flow analysis turned off.
18195 (IVariable): New interface.
18196 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18197 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18198 (FieldExpr.DoResolve): Resolve the instance expression with flow
18199 analysis turned off and do the definite assignment check after the
18200 resolving when we know what the expression will resolve to.
18202 * expression.cs (LocalVariableReference, ParameterReference):
18203 Implement the new IVariable interface, only call the flow analysis
18204 code if ec.DoFlowAnalysis is true.
18205 (This): Added constructor which takes a Block argument. Implement
18206 the new IVariable interface.
18207 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18208 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18209 This does the definite assignment checks for struct members.
18211 * class.cs (Constructor.Emit): If this is a non-static `struct'
18212 constructor which doesn't have any initializer, call
18213 Block.AddThisVariable() to tell the flow analysis code that all
18214 struct elements must be initialized before control returns from
18217 * statement.cs (MyStructInfo): New public class.
18218 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18219 argument to this indexer. If non-zero, check an individual struct
18220 member, not the whole struct.
18221 (FlowBranching.CheckOutParameters): Check struct members.
18222 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18223 overloaded versions of these methods which take an additional
18224 `int field_idx' argument to check struct members.
18225 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18226 overloaded versions of these methods which take an additional
18227 `string field_name' argument to check struct member.s
18228 (VariableInfo): Implement the IVariable interface.
18229 (VariableInfo.StructInfo): New public property. Returns the
18230 MyStructInfo instance of the variable if it's a struct or null.
18231 (Block.AddThisVariable): New public method. This is called from
18232 Constructor.Emit() for non-static `struct' constructor which do
18233 not have any initializer. It creates a special variable for the
18234 "this" instance variable which will be checked by the flow
18235 analysis code to ensure that all of the struct's fields are
18236 initialized before control returns from the constructor.
18237 (UsageVector): Added support for struct members. If a
18238 variable/parameter is a struct with N members, we reserve a slot
18239 in the usage vector for each member. A struct is considered fully
18240 initialized if either the struct itself (slot 0) or all its
18241 members are initialized.
18243 2002-08-08 Martin Baulig <martin@gnome.org>
18245 * driver.cs (Driver.MainDriver): Only report an error CS5001
18246 if there were no compilation errors.
18248 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18249 `UnsafeContext' property to determine whether the parent is in
18250 unsafe context rather than checking the parent's ModFlags:
18251 classes nested in an unsafe class are unsafe as well.
18253 2002-08-08 Martin Baulig <martin@gnome.org>
18255 * statement.cs (UsageVector.MergeChildren): Distinguish between
18256 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18257 we return. Added test17() and test18() to test-154.cs.
18259 2002-08-08 Martin Baulig <martin@gnome.org>
18261 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18262 Family access, make sure the invoking type isn't a subclass of the
18263 queried type (that'd be a CS1540).
18265 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18266 this method which takes an additional `Type invocation_type'.
18268 * expression.cs (BaseAccess.DoResolve): Use the base type as
18269 invocation and query type.
18270 (MemberAccess.DoResolve): If the lookup failed and we're about to
18271 report a CS0122, try a lookup with the ec.ContainerType - if this
18272 succeeds, we must report a CS1540.
18274 2002-08-08 Martin Baulig <martin@gnome.org>
18276 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18277 (MethodGroupExpr): Implement the IMemberExpr interface.
18279 * expression (MemberAccess.ResolveMemberAccess): No need to have
18280 any special code for MethodGroupExprs anymore, they're now
18283 2002-08-08 Martin Baulig <martin@gnome.org>
18285 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18286 Family, FamANDAssem and FamORAssem permissions.
18287 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18289 2002-08-08 Martin Baulig <martin@gnome.org>
18291 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18292 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18295 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18297 * driver.cs: implemented /resource option to embed managed resources.
18299 2002-08-07 Martin Baulig <martin@gnome.org>
18301 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18302 (FieldBase.HasFieldInitializer): New public property.
18303 (FieldBase.GetInitializerExpression): New public method. Resolves and
18304 returns the field initializer and makes sure it is only resolved once.
18305 (TypeContainer.EmitFieldInitializers): Call
18306 FieldBase.GetInitializerExpression to get the initializer, this ensures
18307 that it isn't resolved multiple times.
18309 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18310 the resolving process (SimpleName/MemberLookup) that we're currently
18311 emitting a field initializer (which must not access any instance members,
18312 this is an error CS0236).
18314 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18315 argument, if the `IsFieldInitializer' flag is set, we must report and
18316 error CS0236 and not an error CS0120.
18318 2002-08-07 Martin Baulig <martin@gnome.org>
18320 * ecore.cs (IMemberExpr): New public interface.
18321 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18322 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18323 if the expression is an IMemberExpr.
18325 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18326 to be null, implicitly default to `this' if we're non-static in
18327 this case. Simplified the code a lot by using the new IMemberExpr
18328 interface. Also fixed bug #28176 here.
18330 2002-08-06 Martin Baulig <martin@gnome.org>
18332 * cs-parser.jay (SimpleLookup): Removed. We need to create
18333 ParameterReferences during semantic analysis so that we can do a
18334 type-only search when resolving Cast, TypeOf and SizeOf.
18335 (block): Pass the `current_local_parameters' to the Block's
18338 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18339 argument to the constructor.
18340 (ConstructorInitializer.Resolve): Create a temporary implicit
18341 block with the parameters.
18343 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18344 references here if we aren't doing a type-only search.
18346 * statement.cs (Block): Added constructor which takes a
18347 `Parameters parameters' argument.
18348 (Block.Parameters): New public property.
18350 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18351 to `Parameters' and made it public readonly.
18353 2002-08-06 Martin Baulig <martin@gnome.org>
18355 * ecore.cs (Expression.Warning): Made this public as well.
18357 * report.cs (Report.Debug): Print the contents of collections.
18359 2002-08-06 Martin Baulig <martin@gnome.org>
18361 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18362 used to tell Resolve() which kinds of expressions it may return.
18363 (Expression.Resolve): Added overloaded version of this method which
18364 takes a `ResolveFlags flags' argument. This can be used to tell
18365 Resolve() which kinds of expressions it may return. Reports a
18367 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18368 ResolveFlags.SimpleName.
18369 (Expression.Error118): Added overloaded version of this method which
18370 takes a `ResolveFlags flags' argument. It uses the flags to determine
18371 which kinds of expressions are allowed.
18373 * expression.cs (Argument.ResolveMethodGroup): New public method.
18374 Resolves an argument, but allows a MethodGroup to be returned.
18375 This is used when invoking a delegate.
18377 * TODO: Updated a bit.
18379 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18381 Fixed compilation with csc.
18383 * ecore.cs: Expression.Error made public. Is this correct? Should
18384 Warning be made public too?
18386 * expression.cs: use ea.Location instead of ea.loc.
18387 [FIXME: Filed as bug #28607: MCS must report these errors.]
18389 2002-08-06 Martin Baulig <martin@gnome.org>
18391 * ecore.cs (Expression.loc): Moved the location here instead of
18392 duplicating it in all derived classes.
18393 (Expression.Location): New public property.
18394 (Expression.Error, Expression.Warning): Made them non-static and
18395 removed the location argument.
18396 (Expression.Warning): Added overloaded version which takes an
18397 `int level' argument.
18398 (Expression.Error118): Make this non-static and removed the
18399 expression and location arguments.
18400 (TypeExpr): Added location argument to the constructor.
18402 * expression.cs (StaticCallExpr): Added location argument to
18404 (Indirection, PointerArithmetic): Likewise.
18405 (CheckedExpr, UnCheckedExpr): Likewise.
18406 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18407 (StringPtr): Likewise.
18410 2002-08-05 Martin Baulig <martin@gnome.org>
18412 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18414 * assign.cs (Assign.DoResolve): Check whether the source
18415 expression is a value or variable.
18417 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18418 while resolving the corresponding blocks.
18420 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18421 an error, don't silently return null.
18423 * statement.cs (Block.AddVariable): Do the error reporting here
18424 and distinguish between CS0128 and CS0136.
18425 (Block.DoResolve): Report all unused labels (warning CS0164).
18426 (LabeledStatement): Pass the location to the constructor.
18427 (LabeledStatement.HasBeenReferenced): New property.
18428 (LabeledStatement.Resolve): Set it to true here.
18430 * statement.cs (Return.Emit): Return success even after reporting
18431 a type mismatch error (CS0126 or CS0127), this is what csc does and
18432 it avoids confusing the users with any consecutive errors.
18434 2002-08-05 Martin Baulig <martin@gnome.org>
18436 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18438 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18440 * expression.cs (MemberAccess.DoResolve): Silently return if an
18441 error has already been reported.
18443 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18444 error has already been reported.
18446 2002-08-05 Martin Baulig <martin@gnome.org>
18448 * statement.cs (UsageVector): Only initialize the `parameters'
18449 vector if we actually have any "out" parameters.
18451 2002-08-05 Martin Baulig <martin@gnome.org>
18453 * expression.cs (Binary.ResolveOperator): When combining delegates,
18454 they must have the same type.
18456 2002-08-05 Martin Baulig <martin@gnome.org>
18458 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18459 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18460 work with the ms runtime and we also don't need it: if we're a
18461 PropertyBuilder and not in the `indexer_arguments' hash, then we
18462 are a property and not an indexer.
18464 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18465 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18466 since the latter one doesn't work with the ms runtime.
18468 2002-08-03 Martin Baulig <martin@gnome.org>
18470 Fixed bugs #27998 and #22735.
18472 * class.cs (Method.IsOperator): New public field.
18473 (Method.CheckBase): Report CS0111 if there's already a method
18474 with the same parameters in the current class. Report CS0508 when
18475 attempting to change the return type of an inherited method.
18476 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18477 and it's not marked abstract or extern.
18478 (PropertyBase): New abstract base class for Property and Indexer.
18479 (PropertyBase.CheckBase): Moved here from Property and made it work
18481 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18482 the same so we can reuse it there.
18483 (Property, Indexer): Derive from PropertyBase.
18484 (MethodSignature.inheritable_property_signature_filter): New delegate
18485 to find properties and indexers.
18487 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18488 argument and improved error reporting.
18490 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18491 EmptyReadOnlyParameters and made it a property.
18493 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18494 version of this method which takes a `PropertyInfo indexer'.
18495 (TypeManager.RegisterIndexer): New method.
18497 * class.cs: Added myself as author of this file :-)
18499 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18501 * class.cs: fixed compilation on windoze.
18503 2002-08-03 Martin Baulig <martin@gnome.org>
18505 * interface.cs (Interface.GetInterfaceBases): Check whether all
18506 base interfaces are at least as accessible than the current one.
18508 * class.cs (TypeContainer.GetClassBases): Check whether base types
18509 are at least as accessible than the current type.
18510 (TypeContainer.AsAccessible): Implemented and made non-static.
18511 (MemberBase.CheckParameters): Report errors if the accessibility
18514 * delegate.cs (Delegate.Delegate): The default visibility is
18515 internal for top-level types and private for nested types.
18516 (Delegate.Define): Report errors if the accessibility checks fail.
18518 * enum.cs (Enum.Enum): The default visibility is internal for
18519 top-level types and private for nested types.
18520 (Enum.DefineType): Compute the correct visibility.
18522 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18523 function which takes a `bool is_toplevel' instead of a TypeContainer.
18525 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18528 2002-08-02 Martin Baulig <martin@gnome.org>
18530 * expression.cs (LocalVariableReferenc): Added constructor which
18531 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18532 (LocalVariableReference.IsReadOnly): New property.
18533 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18534 variable is readonly, use our own readonly flag to do this; you can
18535 use the new constructor to get a writable reference to a read-only
18538 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18539 reference to the local variable.
18541 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18543 * rootcontext.cs (ResolveCore): Also include System.Exception
18545 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18546 we reach an EmptyStatement.
18548 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18551 * expression.cs (Binary.ResolveOperator): Check error result in
18554 use brtrue/brfalse directly and avoid compares to null.
18556 2002-08-02 Martin Baulig <martin@gnome.org>
18558 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18559 Fixes bug #28407, added test-155.cs.
18561 2002-08-01 Martin Baulig <martin@gnome.org>
18563 * class.cs (Event.EmitDefaultMethod): Make this work with static
18564 events. Fixes #28311, added verify-3.cs.
18566 2002-08-01 Martin Baulig <martin@gnome.org>
18568 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18569 `is_disposable' fields.
18570 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18571 `hm.is_disposable' if we're using the collection pattern.
18572 (Foreach.EmitCollectionForeach): Use the correct type for the
18573 enumerator's local variable, only emit the try/finally block if
18574 necessary (fixes #27713).
18576 2002-08-01 Martin Baulig <martin@gnome.org>
18578 * ecore.cs (Expression.report118): Renamed to Error118 and made
18581 * statement.cs (Throw.Resolve): Check whether the expression is of
18582 the correct type (CS0118) and whether the type derives from
18583 System.Exception (CS0155).
18584 (Catch.Resolve): New method. Do the type lookup here and check
18585 whether it derives from System.Exception (CS0155).
18586 (Catch.CatchType, Catch.IsGeneral): New public properties.
18588 * typemanager.cs (TypeManager.exception_type): Added.
18590 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18592 * driver.cs: Updated About function.
18594 2002-07-31 Martin Baulig <martin@gnome.org>
18596 Implemented Control Flow Analysis.
18598 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18599 (EmitContext.CurrentBranching): Added.
18600 (EmitContext.StartFlowBranching): Added.
18601 (EmitContext.EndFlowBranching): Added.
18602 (EmitContext.KillFlowBranching): Added.
18603 (EmitContext.IsVariableAssigned): Added.
18604 (EmitContext.SetVariableAssigned): Added.
18605 (EmitContext.IsParameterAssigned): Added.
18606 (EmitContext.SetParameterAssigned): Added.
18607 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
18608 Added control flow analysis stuff here.
18610 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
18611 resolve the expression as lvalue.
18612 (LocalVariableReference.DoResolve): Check whether the variable has
18613 already been assigned.
18614 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
18615 the parameter as assigned here.
18616 (ParameterReference.DoResolve): Check whether the parameter has already
18618 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
18619 expression as lvalue.
18621 * statement.cs (FlowBranching): New class for the flow analysis code.
18622 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
18623 (LabeledStatement.IsDefined): New public property.
18624 (LabeledStatement.AddUsageVector): New public method to tell flow
18625 analyis that the label may be reached via a forward jump.
18626 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
18628 (VariableInfo.Number): New public field. This is used by flow analysis
18629 to number all locals of a block.
18630 (Block.CountVariables): New public property. This is the number of
18631 local variables in this block (including the locals from all parent
18633 (Block.EmitMeta): Number all the variables.
18635 * statement.cs: Added flow analysis support to all classes.
18637 2002-07-31 Martin Baulig <martin@gnome.org>
18639 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
18640 To get debugging messages, compile mcs with /define:MCS_DEBUG and
18641 then use this argument.
18643 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
18645 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
18646 use this to specify /define options.
18648 2002-07-29 Martin Baulig <martin@gnome.org>
18650 * statement.cs (Fixed): Moved all code that does variable lookups
18651 and resolvings from Emit to Resolve.
18653 * statement.cs (For): Moved all code that does variable lookups
18654 and resolvings from Emit to Resolve.
18656 * statement.cs (Using): Moved all code that does variable lookups
18657 and resolvings from Emit to Resolve.
18659 2002-07-29 Martin Baulig <martin@gnome.org>
18661 * attribute.cs (Attribute.Resolve): Explicitly catch a
18662 System.NullReferenceException when creating the
18663 CustromAttributeBuilder and report a different warning message.
18665 2002-07-29 Martin Baulig <martin@gnome.org>
18667 * support.cs (ParameterData.ParameterName): Added method to
18668 get the name of a parameter.
18670 * typemanager.cs (TypeManager.IsValueType): New public method.
18672 2002-07-29 Martin Baulig <martin@gnome.org>
18674 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
18675 is a flag which specifies that it's either ref or out.
18676 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
18677 the out parameter to `out Parameter.Modifier mod', also set the
18678 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
18680 * support.cs (InternalParameters.ParameterModifier): Distinguish
18681 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18682 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18684 * expression.cs (Argument.GetParameterModifier): Distinguish
18685 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18686 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18688 2002-07-29 Martin Baulig <martin@gnome.org>
18690 * expression.cs (ParameterReference.ParameterReference): Added
18691 `Location loc' argument to the constructor.
18693 * cs-parser.jay: Pass location to ParameterReference.
18695 2002-07-28 Miguel de Icaza <miguel@ximian.com>
18697 * statement.cs (Try): Initialize the location.
18699 * cs-parser.jay: pass location to Try.
18701 * expression.cs (Unary.Reduce): Change the prototype to return
18702 whether a constant fold could be performed or not. The result is
18703 returned in an out parameters. In the case of Indirection and
18704 AddressOf, we want to perform the full tests.
18706 2002-07-26 Miguel de Icaza <miguel@ximian.com>
18708 * statement.cs (Statement.Emit): Flag dead code.
18710 2002-07-27 Andrew Birkett <andy@nobugs.org>
18712 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
18714 2002-07-27 Martin Baulig <martin@gnome.org>
18716 * class.cs (MethodData.Define): Put back call to
18717 TypeManager.AddMethod(), accidentally commented this out.
18719 * report.cs (Debug): New public method to print debugging information,
18720 this is `[Conditional ("DEBUG")]'.
18722 2002-07-26 Martin Baulig <martin@gnome.org>
18724 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
18725 (switch_statement): Push the current_block to the switch_stack and
18726 pop it again when we're done with the switch.
18727 (switch_section): The new block is a child of the current_block.
18728 Fixes bug #24007, added test-152.cs.
18730 2002-07-27 Martin Baulig <martin@gnome.org>
18732 * expression.cs (Invocation.EmitArguments): When calling a varargs
18733 function with only its fixed arguments, we need to pass an empty
18736 2002-07-27 Martin Baulig <martin@gnome.org>
18738 Mono 0.13 has been released.
18740 2002-07-25 Miguel de Icaza <miguel@ximian.com>
18742 * driver.cs: Rename --resource to --linkres, because that is what
18743 we do currently, we dont support --resource yet.
18745 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
18747 2002-07-25 Martin Baulig <martin@gnome.org>
18749 * class.cs (MethodData): New public class. This is a `method builder'
18750 class for a method or one accessor of a Property/Indexer/Event.
18751 (MethodData.GetMethodFlags): Moved here from MemberBase.
18752 (MethodData.ApplyAttributes): Likewise.
18753 (MethodData.ApplyObsoleteAttribute): Likewise.
18754 (MethodData.ApplyConditionalAttribute): Likewise.
18755 (MethodData.ApplyDllImportAttribute): Likewise.
18756 (MethodData.CheckAbstractAndExternal): Likewise.
18757 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
18758 (MethodData.Emit): Formerly known as Method.Emit().
18759 (MemberBase): Moved everything which was specific to a single
18760 accessor/method to MethodData.
18761 (Method): Create a new MethodData and call Define() and Emit() on it.
18762 (Property, Indexer, Event): Create a new MethodData objects for each
18763 accessor and call Define() and Emit() on them.
18765 2002-07-25 Martin Baulig <martin@gnome.org>
18767 Made MethodCore derive from MemberBase to reuse the code from there.
18768 MemberBase now also checks for attributes.
18770 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
18771 (MemberBase.GetMethodFlags): Moved here from class Method and marked
18773 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
18774 `CallingConventions cc' and `Attributes opt_attrs' arguments.
18775 (MemberBase.ApplyAttributes): New virtual method; applies the
18776 attributes to a method or accessor.
18777 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
18778 (MemberBase.ApplyConditionalAttribute): Likewise.
18779 (MemberBase.ApplyDllImportAttribute): Likewise.
18780 (MemberBase.CheckAbstractAndExternal): Likewise.
18781 (MethodCore.ParameterTypes): This is now a property instead of a
18782 method, it's initialized from DoDefineParameters().
18783 (MethodCore.ParameterInfo): Removed the set accessor.
18784 (MethodCore.DoDefineParameters): New protected virtual method to
18785 initialize ParameterTypes and ParameterInfo.
18786 (Method.GetReturnType): We can now simply return the MemberType.
18787 (Method.GetMethodFlags): Override the MemberBase version and add
18788 the conditional flags.
18789 (Method.CheckBase): Moved some code from Define() here, call
18790 DoDefineParameters() here.
18791 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
18792 here to avoid some larger code duplication.
18793 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
18794 ensure that abstract and external accessors don't declare a body.
18796 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
18797 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
18798 lookup in the attribute's parent classes, so we need to abort as soon
18799 as we found the first match.
18800 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
18801 the attribute has no arguments.
18803 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
18806 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18808 * cs-parser.jay: reverted previous patch.
18810 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18812 * cs-parser.jay: fixed bug #22119.
18814 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18816 * attribute.cs: fixed compilation. The error was:
18817 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
18818 be assigned to before control leaves the current method."
18819 [FIXME: Filed as bug #28186: MCS must report this error.]
18821 2002-07-25 Martin Baulig <martin@gnome.org>
18823 * attribute.cs (Attribute.Conditional_GetConditionName): New static
18824 method to pull the condition name ouf of a Conditional attribute.
18825 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
18826 the obsolete message and error flag out of an Obsolete attribute.
18828 * class.cs (Method.GetMethodFlags): New public method to get the
18829 TypeManager.MethodFlags for this method.
18830 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
18832 (Method.Define): Get and apply the Obsolete and Conditional attributes;
18833 if we're overriding a virtual function, set the new private variable
18834 `parent_method'; call the new TypeManager.AddMethod().
18836 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
18837 the MethodBuilder and the Method in a PtrHashtable.
18838 (TypeManager.builder_to_method): Added for this purpose.
18839 (TypeManager.MethodFlags): Added IsObsoleteError.
18840 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
18841 Obsolete and Conditional arguments in MethodBuilders. If we discover
18842 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
18843 the message from the attribute.
18845 2002-07-24 Martin Baulig <martin@gnome.org>
18847 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
18848 preprocessor directives, ensure that the argument to #define/#undef is
18849 exactly one identifier and that it's actually an identifier.
18851 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
18854 2002-07-24 Martin Baulig <martin@gnome.org>
18856 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
18857 initialize it to TypeManager.object_type in the constructor.
18858 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
18859 of the `hm.get_current' method if we're using the collection pattern.
18860 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
18861 for the explicit conversion to make it work when we're using the collection
18862 pattern and the `Current' property has a different return type than `object'.
18865 2002-07-24 Martin Baulig <martin@gnome.org>
18867 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
18868 does not match, but don't report any errors. This method is called in
18869 order for all methods in a MethodGroupExpr until a matching method is
18870 found, so we don't want to bail out if the first method doesn't match.
18871 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
18872 matches, report the 123. Fixes #28070.
18874 2002-07-24 Martin Baulig <martin@gnome.org>
18876 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
18877 TypeManager.TypeToCoreType() to the top of the method so the
18878 following equality checks will work. Fixes #28107.
18880 2002-07-24 Martin Baulig <martin@gnome.org>
18882 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
18883 operand is of type uint, and the other operand is of type sbyte,
18884 short or int, the operands are converted to type long." -
18885 Actually do what this comment already told us. Fixes bug #28106,
18888 2002-07-24 Martin Baulig <martin@gnome.org>
18890 * class.cs (MethodBase): New abstract class. This is now a base
18891 class for Property, Indexer and Event to avoid some code duplication
18892 in their Define() and DefineMethods() methods.
18893 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
18894 generic methods for Define() and DefineMethods().
18895 (FieldBase): Derive from MemberBase, not MemberCore.
18896 (Property): Derive from MemberBase, not MemberCore.
18897 (Property.DefineMethod): Moved all the code from this method to the
18898 new MethodBase.DefineAccessor(), just call it with appropriate
18900 (Property.Define): Call the new Property.DoDefine(), this does some
18901 sanity checks and we don't need to duplicate the code everywhere.
18902 (Event): Derive from MemberBase, not MemberCore.
18903 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
18904 accessors, this will also make them work with interface events.
18905 (Indexer): Derive from MemberBase, not MemberCore.
18906 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
18907 (Indexer.Define): Use the new MethodBase functions.
18909 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
18910 argument to the constructor.
18911 (Interface.FindMembers): Added support for interface events.
18912 (Interface.PopluateEvent): Implemented.
18914 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
18916 2002-07-22 Miguel de Icaza <miguel@ximian.com>
18918 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
18919 but this is required to check for a method name being the same as
18920 the containing class.
18924 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18926 * interface.cs: initialize variable.
18928 2002-07-23 Martin Baulig <martin@gnome.org>
18930 Implemented the IndexerName attribute in interfaces.
18932 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
18933 name if this is an explicit interface implementation.
18934 (Indexer.InterfaceIndexerName): New public variable. If we're
18935 implementing an interface indexer, this is the IndexerName in that
18936 interface. Otherwise, it's the IndexerName.
18937 (Indexer.DefineMethod): If we're implementing interface indexer,
18938 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
18939 and Pending.ImplementIndexer methods.
18940 (Indexer.Define): Also define the PropertyBuilder if we're
18941 implementing an interface indexer and this is neither an explicit
18942 interface implementation nor do the IndexerName match the one in
18945 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
18946 If a method is defined here, then we always need to create a proxy
18947 for it. This is used when implementing interface indexers.
18948 (Pending.IsInterfaceIndexer): New public method.
18949 (Pending.ImplementIndexer): New public method.
18950 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
18951 This is used when implementing interface indexers to define a proxy
18953 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
18954 define a proxy if necessary.
18956 * interface.cs (Interface.IndexerName): New public variable.
18957 (Interface.PopulateIndexer): Set the IndexerName.
18958 (Interface.DefineIndexers): New private method. Populate all the
18959 indexers and make sure their IndexerNames match.
18961 * typemanager.cs (IndexerPropertyName): Added support for interface
18964 2002-07-22 Martin Baulig <martin@gnome.org>
18966 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
18967 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
18968 ret if HasReturnLabel.
18969 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
18972 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
18973 and set the ec.LoopBeginTryCatchLevel.
18974 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
18975 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
18976 the current ec.TryCatchLevel, the branch goes out of an exception
18977 block. In this case, we need to use Leave and not Br.
18979 2002-07-22 Martin Baulig <martin@gnome.org>
18981 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
18982 block unless the block does not always return or it is contained in
18983 another try { ... } catch { ... } block. Fixes bug #26506.
18984 Added verify-1.cs to the test suite.
18986 2002-07-22 Martin Baulig <martin@gnome.org>
18988 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
18989 then we do not always return. Fixes bug #24985.
18991 2002-07-22 Martin Baulig <martin@gnome.org>
18993 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
18994 lookup on a per-class level; ie. walk up the class hierarchy until we
18995 found at least one applicable method, then choose the best among them.
18996 Fixes bug #24463 and test-29.cs.
18998 2002-07-22 Martin Baulig <martin@gnome.org>
19000 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19001 return types of the methods. The return type is not part of the
19002 signature and we must not check it to make the `new' modifier work.
19003 Fixes bug #27999, also added test-147.cs.
19004 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19006 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19007 on the method's return type.
19009 2002-07-21 Martin Baulig <martin@gnome.org>
19011 * assign.cs: Make this work if the rightmost source is a constant and
19012 we need to do an implicit type conversion. Also adding a few more tests
19013 to test-38.cs which should have caught this.
19015 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19016 target in the makefile for this. The makefile.gnu is primarily intended
19017 for end-users who don't want to debug the compiler.
19019 2002-07-21 Martin Baulig <martin@gnome.org>
19021 * assign.cs: Improved the Assign class so it can now handle embedded
19022 assignments (X = Y = Z = something). As a side-effect this'll now also
19023 consume less local variables. test-38.cs now passes with MCS, added
19024 a few new test cases to that test.
19026 2002-07-20 Martin Baulig <martin@gnome.org>
19028 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19029 instructions. Fixes bug #27977, also added test-146.cs.
19031 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19033 * cs-tokenizer.cs: fixed getHex ().
19035 2002-07-19 Martin Baulig <martin@gnome.org>
19037 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19038 not Type.GetType() to lookup the array type. This is needed when
19039 we're constructing an array of a user-defined type.
19040 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19041 single-dimensional arrays, but also for single-dimensial arrays of
19044 2002-07-19 Martin Baulig <martin@gnome.org>
19046 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19047 this function is called, it's not allowed to share LocalBuilders
19048 among ILGenerators.
19050 2002-07-19 Martin Baulig <martin@gnome.org>
19052 * expression.cs (Argument.Resolve): Report an error 118 when trying
19053 to pass a type as argument.
19055 2002-07-18 Martin Baulig <martin@gnome.org>
19057 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19058 Conv_R_Un for the signed `long' type.
19060 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19062 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19063 `expr' for the temporary result, as that will fail if we do
19064 multiple resolves on the same expression.
19066 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19068 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19069 ec.TypeContainer for looking up aliases.
19071 * class.cs (TypeContainer): Remove LookupAlias from here.
19073 * decl.cs (DeclSpace); Move here.
19075 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19077 * class.cs (FindMembers): Only call filter if the constructor
19078 bulider is not null.
19080 Also handle delegates in `NestedTypes' now. Now we will perform
19081 type lookups using the standard resolution process. This also
19084 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19085 This uses Expressions (the limited kind that can be parsed by the
19086 tree) instead of strings.
19088 * expression.cs (ComposedCast.ToString): Implement, used to flag
19089 errors since now we have to render expressions.
19091 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19094 * ecore.cs (SimpleName.ToString): ditto.
19096 * cs-parser.jay: Instead of using strings to assemble types, use
19097 Expressions to assemble the type (using SimpleName, ComposedCast,
19098 MemberAccess). This should fix the type lookups in declarations,
19099 because we were using a different code path for this.
19101 * statement.cs (Block.Resolve): Continue processing statements
19102 even when there is an error.
19104 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19106 * class.cs (Event.Define): Also remove the `remove' method from
19107 the list of pending items.
19109 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19110 generate more compact code.
19112 2002-07-17 Martin Baulig <martin@gnome.org>
19114 * const.cs (Const.LookupConstantValue): Add support for constant
19115 `unchecked' and `checked' expressions.
19116 Also adding test case test-140.cs for this.
19118 2002-07-17 Martin Baulig <martin@gnome.org>
19120 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19121 check whether mi.ReturnType implements the IEnumerator interface; the
19122 `==' and the IsAssignableFrom() will fail in this situation.
19124 2002-07-16 Ravi Pratap <ravi@ximian.com>
19126 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19129 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19131 * expression.cs: fixed bug #27811.
19133 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19135 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19136 Molaro: when we are a ref, the value already contains a pointer
19137 value, do not take the address of it.
19139 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19140 * removed mb-parser.jay and mb-tokenizer.cs
19142 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19144 * expression.cs: check against the building corlib void type.
19146 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19148 * ecore.cs: fix for valuetype static readonly fields: when
19149 initializing them, we need their address, not the address of a copy.
19151 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19153 * typemanager.cs: register also enum_type in corlib.
19155 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19157 * class.cs: allow calling this (but not base) initializers in structs.
19159 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19161 * ecore.cs: make sure we compare against the building base types
19164 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19166 * typemanager.cs: fix TypeToCoreType() to handle void and object
19167 (corlib gets no more typerefs after this change).
19169 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19171 * expression.cs (ArrayCreation.EmitArrayArguments): use
19172 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19174 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19175 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19176 array indexes, the runtime actually forbids them.
19178 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19179 for array arguments here.
19181 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19182 instead of the default for ValueTypes.
19184 (New.DoEmit): Use IsValueType instead of
19185 IsSubclassOf (value_type)
19186 (New.DoResolve): ditto.
19187 (Invocation.EmitCall): ditto.
19189 * assign.cs (Assign): ditto.
19191 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19192 Statements *are* currently doing part of their resolution during
19195 Expressions do always resolve during resolve, but statements are
19196 only required to propagate resolution to their children.
19198 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19200 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19202 (LoadAssembly): Do not add the dll if it is already specified
19204 (MainDriver): Add the System directory to the link path at the end,
19205 after all the other -L arguments.
19207 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19208 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19209 ldelem.u1) and using the opposite for sbytes.
19211 This fixes Digger, and we can finally run it.
19213 * driver.cs (UnixParseOption): Move the option parsing here.
19214 (CSCParseOption): Implement CSC-like parsing of options.
19216 We now support both modes of operation, the old Unix way, and the
19217 new CSC-like way. This should help those who wanted to make cross
19218 platform makefiles.
19220 The only thing broken is that /r:, /reference: and /lib: are not
19221 implemented, because I want to make those have the same semantics
19222 as the CSC compiler has, and kill once and for all the confussion
19223 around this. Will be doing this tomorrow.
19225 * statement.cs (Unsafe.Resolve): The state is checked during
19226 resolve, not emit, so we have to set the flags for IsUnsfe here.
19228 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19230 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19231 not catch the Error_ObjectRefRequired in SimpleName (as it is
19232 possible to have a class/instance variable name that later gets
19233 deambiguated), we have to check this here.
19235 2002-07-10 Ravi Pratap <ravi@ximian.com>
19237 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19238 make static and put into Expression.
19240 (Event.Define): Register the private field of the event with the
19241 TypeManager so that GetFieldFromEvent can get at it.
19243 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19244 keep track of the private field associated with an event which
19247 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19250 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19252 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19254 * expression.cs (Binary.EmitBranchable): this routine emits the
19255 Binary expression in a branchable context. This basically means:
19256 we need to branch somewhere, not just get the value on the stack.
19258 This works together with Statement.EmitBoolExpression.
19260 * statement.cs (Statement.EmitBoolExpression): Use
19263 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19265 * statement.cs (For): Reduce the number of jumps in loops.
19267 (For): Implement loop inversion for the For statement.
19269 (Break): We can be breaking out of a Try/Catch controlled section
19270 (foreach might have an implicit try/catch clause), so we need to
19271 use Leave instead of Br.
19273 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19274 now). If the instace expression supports IMemoryLocation, we use
19275 the AddressOf method from the IMemoryLocation to extract the
19276 address instead of emitting the instance.
19278 This showed up with `This', as we were emitting the instance
19279 always (Emit) instead of the Address of This. Particularly
19280 interesting when This is a value type, as we dont want the Emit
19281 effect (which was to load the object).
19283 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19285 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19287 * statement.cs (Checked): Set the CheckedState during the resolve
19288 process too, as the ConvCast operations track the checked state on
19289 the resolve process, and not emit.
19291 * cs-parser.jay (namespace_member_declaration): Flag that we have
19292 found a declaration when we do. This is used to flag error 1529
19294 * driver.cs: Report ok when we display the help only.
19296 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19298 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19300 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19302 * cs-tokenizer.cs (define): We also have to track locally the
19303 defines. AllDefines is just used for the Conditional Attribute,
19304 but we also need the local defines for the current source code.
19306 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19308 * statement.cs (While, For, Do): These loops can exit through a
19309 Break statement, use this information to tell whether the
19310 statement is the last piece of code.
19312 (Break): Flag that we break.
19314 * codegen.cs (EmitContexts): New `Breaks' state variable.
19316 2002-07-03 Martin Baulig <martin@gnome.org>
19318 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19319 modifiers in method declarations in structs. Otherwise, you won't
19320 be able to override things like Object.Equals().
19322 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19324 * class.cs (Method, Property, Indexer): Do not allow the public
19325 modifier to be used in explicit interface implementations.
19327 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19328 override modifiers in method declarations in structs
19330 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19332 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19333 integer or real overflow, report an error
19335 2002-07-02 Martin Baulig <martin@gnome.org>
19337 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19338 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19339 to tell the runtime about our newly created System.Object and
19340 System.ValueType types.
19342 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19344 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19345 struct instead of Ldarg/Starg.
19347 2002-07-02 Martin Baulig <martin@gnome.org>
19349 * expression.cs (Indirection.Indirection): Call
19350 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19352 2002-07-02 Martin Baulig <martin@gnome.org>
19354 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19355 ValueType, call TypeManager.TypeToCoreType() on it.
19356 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19357 the OpCodes.Newarr argument.
19359 2002-07-02 Martin Baulig <martin@gnome.org>
19361 * expression.cs (Invocation.EmitCall): When compiling corlib,
19362 replace all calls to the system's System.Array type to calls to
19363 the newly created one.
19365 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19366 System.Array methods.
19367 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19368 from the system's System.Array type which must be replaced.
19370 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19372 * typemanager.cs: load unverifiable_code_ctor so we can build
19373 corlib using the correct type. Avoid using GetTypeCode() with
19375 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19376 TypeManager.object_type to allow building corlib.
19378 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19380 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19382 2002-07-01 Martin Baulig <martin@gnome.org>
19384 * class.cs: Make the last change actually work, we need to check
19385 whether `ifaces != null' to avoid a crash.
19387 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19389 * class.cs: when we build structs without fields that implement
19390 interfaces, we need to add the interfaces separately, since there is
19391 no API to both set the size and add the interfaces at type creation
19394 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19396 * expression.cs: the dimension arguments to the array constructors
19397 need to be converted if they are a long.
19399 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19401 * class.cs: don't emit ldarg.0 if there is no parent constructor
19402 (fixes showstopper for corlib).
19404 2002-06-29 Martin Baulig <martin@gnome.org>
19406 MCS now compiles corlib on GNU/Linux :-)
19408 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19409 ie. check for MethodImplOptions.InternalCall.
19411 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19412 and TypeManager.attribute_type are null, so we must explicitly check
19413 whether parent is not null to find out whether it's an attribute type.
19414 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19415 and SetBuilder, not only if the property is neither abstract nor external.
19416 This is necessary to set the MethodImplOptions on the accessor methods.
19417 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19418 SetBuilder, see Property.Emit().
19420 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19421 populate "System.Object", "System.ValueType" and "System.Attribute" since
19422 they've already been populated from BootCorlib_PopulateCoreTypes().
19424 2002-06-29 Martin Baulig <martin@gnome.org>
19426 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19427 is the NullLiteral, we also need to make sure that target_type is not
19430 2002-06-29 Martin Baulig <martin@gnome.org>
19432 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19433 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19434 before calling BootstrapCorlib_ResolveDelegate ().
19436 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19438 * statement.cs: fixed build-breaker. All tests passed ok.
19440 2002-06-27 Martin Baulig <martin@gnome.org>
19442 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19443 for System.Decimal when compiling corlib.
19445 2002-06-27 Martin Baulig <martin@gnome.org>
19447 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19448 switch blocks which contain nothing but a default clause.
19450 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19452 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19454 2002-06-27 Martin Baulig <martin@gnome.org>
19456 * ecore.cs (PropertyExpr.PropertyExpr): Call
19457 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19459 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19460 is already a TypeBuilder.
19462 2002-06-27 Martin Baulig <martin@gnome.org>
19464 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19465 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19466 the "from an array-type to System.Array" case. This makes it work
19467 when compiling corlib.
19469 2002-06-27 Martin Baulig <martin@gnome.org>
19471 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19472 non-static PropertyExpr, set its InstanceExpression. This makes
19473 the `ICollection.Count' property work in System/Array.cs.
19475 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19477 * driver.cs: Made error handling more consistent. Errors now
19478 tracked by Report class, so many methods which used to return int
19479 now return void. Main() now prints success/failure and
19480 errors/warnings message.
19482 Renamed '--probe' compiler argument to '--expect-error'. Removed
19483 the magic number return values (123 and 124). Now, if the
19484 expected error occurs, the compiler exits with success (exit value
19485 0). If the compilation completes without seeing that particular
19486 error, the compiler exits with failure (exit value 1). The
19487 makefile in mcs/errors has been changed to handle the new behaviour.
19489 * report.cs: Made 'expected error' number a property and renamed
19490 it from 'Probe' to 'ExpectedError'.
19492 * genericparser.cs: Removed error handling support, since it is
19493 now all done by Report class.
19495 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19496 class, so parse() no longer returns an int.
19498 * namespace.cs: Use Report.Error instead of GenericParser.error
19500 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19502 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19503 TypeContainer.AddOperator): At the front of the list put the
19504 explicit implementations, so they get resolved/defined first.
19506 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19508 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19509 interface type is implemented by this TypeContainer. Used during
19510 explicit interface implementation.
19512 (Property.Define, Indexer.Define, Method.Define): Validate that
19513 the given interface in the explicit implementation is one of the
19514 base classes for the containing type.
19516 Also if we are explicitly implementing an interface, but there is
19517 no match in the pending implementation table, report an error.
19519 (Property.Define): Only define the property if we are
19520 not explicitly implementing a property from an interface. Use the
19521 correct name also for those properties (the same CSC uses,
19522 although that is really not needed).
19524 (Property.Emit): Do not emit attributes for explicitly implemented
19525 properties, as there is no TypeBuilder.
19527 (Indexer.Emit): ditto.
19529 Hiding then means that we do not really *implement* a pending
19530 implementation, which makes code fail.
19532 2002-06-22 Martin Baulig <martin@gnome.org>
19534 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19535 the return value of Object.GetType(). [FIXME: we need to do this whenever
19536 we get a type back from the reflection library].
19538 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19540 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19542 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19544 * attribute.cs: Return null if we can not look up the type.
19546 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19547 the interface types found.
19549 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19550 interface types found.
19552 * typemanager.cs (GetInterfaces): Make this routine returns alll
19553 the interfaces and work around the lame differences between
19554 System.Type and System.Reflection.Emit.TypeBuilder in the results
19555 result for GetInterfaces.
19557 (ExpandInterfaces): Given an array of interface types, expand and
19558 eliminate repeated ocurrences of an interface. This expands in
19559 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19562 2002-06-21 Martin Baulig <martin@gnome.org>
19564 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19567 2002-06-21 Martin Baulig <martin@gnome.org>
19569 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19570 and called with one of the core types, return the corresponding typebuilder for
19573 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19576 2002-06-21 Martin Baulig <martin@gnome.org>
19578 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19579 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19580 (Expression.ConvertReferenceExplicit): Likewise.
19582 * expression.cs (ElementAccess.DoResolve): Likewise.
19583 (ElementAccess.DoResolveLValue): Likewise.
19585 2002-06-10 Martin Baulig <martin@gnome.org>
19587 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19588 add the "value" parameter to the parameter list.
19590 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19593 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19595 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19596 the argument to an int, uint, long or ulong, per the spec. Also
19597 catch negative constants in array creation.
19599 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
19601 * class.cs: do not allow the same interface to appear twice in
19602 the definition list.
19604 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
19606 * ecore.cs: don't use ldlen with System.Array.
19608 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
19610 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
19612 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
19614 * modifiers.cs: produce correct field attributes for protected
19615 internal. Easy fix so miguel can work on ther harder stuff:-)
19617 2002-06-18 Miguel de Icaza <miguel@ximian.com>
19619 * pending.cs: New file. Move the code from class.cs here.
19620 Support clearning the pending flag for all methods (when not doing
19621 explicit interface implementation).
19623 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
19625 * rootcontext.cs: added a couple more types needed to bootstrap.
19627 2002-06-17 Miguel de Icaza <miguel@ximian.com>
19629 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
19630 constructor in the type, instead of any constructor in the type
19631 hierarchy. Thanks to Paolo for finding this bug (it showed up as
19632 a bug in the Mono runtime when applying the params attribute).
19634 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19635 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
19637 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
19639 * expression.cs (Unary.ResolveOperator): Use TypeManager
19640 to resolve the type.
19642 2002-06-13 Ravi Pratap <ravi@ximian.com>
19644 * cs-parser.jay (enum_member_declaration): Pass in the attributes
19647 * enum.cs (AddEnumMember): Add support to store the attributes associated
19648 with each member too.
19650 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
19651 field builders too - this takes care of the enum member case.
19653 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
19655 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
19656 address-of operator on both value types and pointers.
19658 2002-06-10 Martin Baulig <martin@gnome.org>
19660 * interface.cs (Interface.PopulateIndexer): Add the indexer's
19661 PropertyBuilder to the `property_builders' list.
19663 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
19664 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
19665 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
19666 find any indexers which are inherited from an interface.
19668 2002-06-09 Martin Baulig <martin@gnome.org>
19670 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
19671 the same type as the constant if necessary. There's also a test-130.cs
19674 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
19676 * typemanager.cs (TypeManager.ChangeType): Previously known as
19677 Enum.ChangeEnumType().
19679 2002-06-09 Martin Baulig <martin@gnome.org>
19681 * expression.cs (Cast.TryReduce): Added support for consts.
19683 2002-06-08 Ravi Pratap <ravi@ximian.com>
19685 * class.cs (Accessor): Hold attributes information so we can pass
19688 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
19689 Modify to pass in attributes attached to the methods.
19691 (add_accessor_declaration, remove_accessor_declaration): Ditto.
19693 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
19694 to handle the Accessor kind :-)
19696 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
19698 2002-06-08 Martin Baulig <martin@gnome.org>
19700 * expression.cs (Unary.TryReduceNegative): Added support for
19703 2002-06-08 Martin Baulig <martin@gnome.org>
19705 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
19706 name can't be found in the `defined_names' - the caller will do a
19707 MemberLookup in this case and thus find methods in System.Enum
19708 such as Enum.IsDefined().
19710 2002-06-08 Martin Baulig <martin@gnome.org>
19712 * enum.cs (Enum.ChangeEnumType): This is a custom version of
19713 Convert.ChangeType() which works with TypeBuilder created types.
19714 (Enum.LookupEnumValue, Enum.Define): Use it here.
19716 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
19717 `TypeBuilder.BaseType != null' check.
19718 (TypeContainer.FindMembers): Only lookup parent members if we
19719 actually have a parent.
19720 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
19721 (ConstructorInitializer.Resolve): Likewise.
19723 * interface.cs (Interface.FindMembers): Added
19724 `TypeBuilder.BaseType != null' check.
19726 * rootcontext.cs (RootContext.ResolveCore): Added
19727 "System.Runtime.CompilerServices.IndexerNameAttribute" to
19728 classes_second_stage.
19730 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
19731 debug_type and trace_type when compiling with --nostdlib.
19733 2002-06-07 Martin Baulig <martin@gnome.org>
19735 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
19736 (AddField): Set it to true when adding a non-static field.
19737 (DefineType): Use `have_nonstatic_fields' to find out whether we
19738 have non-static fields, not `Fields != null'.
19740 2002-06-02 Miguel de Icaza <miguel@ximian.com>
19742 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
19743 dereferencing a null on the static-field code path)
19745 2002-05-30 Martin Baulig <martin@gnome.org>
19747 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
19748 to take command line arguments. Use reflection to call the new
19749 custom `Initialize' function on the symbol writer and pass it the
19750 command line arguments.
19752 * driver.cs (--debug-args): New command line argument to pass command
19753 line arguments to the symbol writer.
19755 2002-05-28 Miguel de Icaza <miguel@ximian.com>
19757 * assign.cs (DoResolve): Forgot to do the implicit conversion to
19758 the target type for indexers and properties. Thanks to Joe for
19761 2002-05-27 Miguel de Icaza <miguel@ximian.com>
19763 * typemanager.cs (MethodFlags): returns the method flags
19764 (Obsolete/ShouldIgnore) that control warning emission and whether
19765 the invocation should be made, or ignored.
19767 * expression.cs (Invocation.Emit): Remove previous hack, we should
19768 not do this on matching a base type, we should do this based on an attribute
19770 Only emit calls to System.Diagnostics.Debug and
19771 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
19772 on the command line.
19774 * rootcontext.cs: Global settings for tracing and debugging.
19776 * cs-tokenizer.cs (define): New utility function to track
19777 defines. Set the global settings for TRACE and DEBUG if found.
19779 2002-05-25 Ravi Pratap <ravi@ximian.com>
19781 * interface.cs (Populate*): Pass in the TypeContainer as well as
19782 the DeclSpace as parameters so that we can create EmitContexts and
19783 then use that to apply attributes etc.
19785 (PopulateMethod, PopulateEvent, PopulateProperty)
19786 (PopulateIndexer): Apply attributes everywhere.
19788 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
19791 (ApplyAttributes): Update accordingly.
19793 We now apply interface attributes for all members too.
19795 2002-05-26 Miguel de Icaza <miguel@ximian.com>
19797 * class.cs (Indexer.Define); Correctly check if we are explicit
19798 implementation (instead of checking the Name for a ".", we
19799 directly look up if the InterfaceType was specified).
19801 Delay the creation of the PropertyBuilder.
19803 Only create the PropertyBuilder if we are not an explicit
19804 interface implementation. This means that explicit interface
19805 implementation members do not participate in regular function
19806 lookups, and hence fixes another major ambiguity problem in
19807 overload resolution (that was the visible effect).
19809 (DefineMethod): Return whether we are doing an interface
19812 * typemanager.cs: Temporary hack until we get attributes in
19813 interfaces (Ravi is working on that) and we get IndexerName
19814 support in interfaces.
19816 * interface.cs: Register the indexers as properties.
19818 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
19819 warning, I have verified that this is a bug in the .NET runtime
19820 (JavaScript suffers of the same problem).
19822 * typemanager.cs (MemberLookup): When looking up members for
19823 interfaces, the parent of an interface is the implicit
19824 System.Object (so we succeed in searches of Object methods in an
19825 interface method invocation. Example: IEnumerable x; x.ToString
19828 2002-05-25 Miguel de Icaza <miguel@ximian.com>
19830 * class.cs (Event): Events should also register if they do
19831 implement the methods that an interface requires.
19833 * typemanager.cs (MemberLookup); use the new GetInterfaces
19836 (GetInterfaces): The code used to lookup interfaces for a type is
19837 used in more than one place, factor it here.
19839 * driver.cs: Track the errors at the bottom of the file, we kept
19842 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
19843 instance if the method we are calling is static!
19845 2002-05-24 Miguel de Icaza <miguel@ximian.com>
19847 * attribute.cs (ApplyAttributes): Make this function filter out
19848 the IndexerName attribute (as that attribute in reality is never
19849 applied) and return the string constant for the IndexerName
19852 * class.cs (TypeContainer.Emit): Validate that all the indexers
19853 have the same IndexerName attribute, and if so, set the
19854 DefaultName attribute on the class.
19856 * typemanager.cs: The return value might contain other stuff (not
19857 only methods). For instance, consider a method with an "Item"
19858 property and an Item method.
19860 * class.cs: If there is a problem with the parameter types,
19863 2002-05-24 Ravi Pratap <ravi@ximian.com>
19865 * ecore.cs (ImplicitConversionExists): Wrapper function which also
19866 looks at user defined conversion after making a call to
19867 StandardConversionExists - we need this for overload resolution.
19869 * expression.cs : Update accordingly the various method calls.
19871 This fixes 2 bugs filed against implicit user defined conversions
19873 2002-05-22 Miguel de Icaza <miguel@ximian.com>
19875 * statement.cs: Track the result of the assignment.
19877 2002-05-21 Miguel de Icaza <miguel@ximian.com>
19879 * expression.cs (MemberAccess): Improved error reporting for
19880 inaccessible members.
19882 2002-05-22 Martin Baulig <martin@gnome.org>
19884 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
19885 itself with debugging support.
19887 2002-05-22 Martin Baulig <martin@gnome.org>
19889 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
19890 Removed, this isn't needed anymore.
19892 2002-05-20 Martin Baulig <martin@gnome.org>
19894 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
19895 be underlying type for an enum.
19897 2002-05-20 Miguel de Icaza <miguel@ximian.com>
19899 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
19900 that splits out the loading of just the core types.
19902 * rootcontext.cs (ResolveCore): Split the struct resolution in
19903 two, so we can load the enumeration underlying types before any
19906 * expression.cs (Is): Bandaid until we fix properly Switch (see
19907 bug #24985 for details).
19909 * typemanager.cs (ImplementsInterface): The hashtable will contain
19910 a null if there are no interfaces implemented.
19912 2002-05-18 Miguel de Icaza <miguel@ximian.com>
19914 * cs-parser.jay (indexer_declarator): It is fine to have array
19917 2002-05-17 Miguel de Icaza <miguel@ximian.com>
19919 * typemanager.cs: (RegisterBuilder): New function used to register
19920 TypeBuilders that implement interfaces. Since
19921 TypeBuilder.GetInterfaces (as usual) does not work with lame
19923 (AddUserType): register interfaces.
19925 (ImplementsInterface): Use the builder_to_ifaces hash if we are
19926 dealing with TypeBuilder. Also, arrays are showing up as
19927 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
19928 methods can not be invoked on them!
19930 * ecore.cs (ExplicitReferenceConversionExists): Made public.
19931 (ImplicitReferenceConversionExists): Split out from
19932 StandardConversionExists.
19934 * expression.cs (As): We were only implementing one of the three
19935 cases for the as operator. We now implement them all.
19936 (Is): Implement the various other cases for Is as well.
19938 * typemanager.cs (CACHE): New define used to control if we want or
19939 not the FindMembers cache. Seems to have a negative impact on
19940 performance currently
19942 (MemberLookup): Nested types have full acess to
19943 enclosing type members
19945 Remove code that coped with instance/static returns for events, we
19946 now catch this in RealFindMembers.
19948 (RealFindMembers): only perform static lookup if the instance
19949 lookup did not return a type or an event.
19951 2002-05-17 Miguel de Icaza <miguel@ximian.com>
19953 * assign.cs (CompoundAssign): We pass more semantic information
19954 now to Compound Assignments than we did before: now we have all
19955 the information at hand, and now we resolve the target *before* we
19956 do the expression expansion, which allows the "CacheValue" method
19957 to have the effect we intended (before, a [x] += 1 would generate
19958 two differen ArrayAccess expressions from the ElementAccess,
19959 during the resolution process).
19961 (CompoundAssign.DoResolve): Resolve target and original_source here.
19963 2002-05-16 Miguel de Icaza <miguel@ximian.com>
19965 * expression.cs (ArrayAccess): dropped debugging information.
19967 * typemanager.cs: Small bug fix: I was always returning i_members,
19968 instead of one of i_members or s_members (depending on which had
19971 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
19972 method is invoked before any code generation takes place, and it
19973 is a mechanism to inform that the expression will be invoked more
19974 than once, and that the method should use temporary values to
19975 avoid having side effects
19977 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
19979 * ecore.cs (Expression.CacheTemporaries): Provide empty default
19982 * expression.cs (Indirection, ArrayAccess): Add support for
19983 CacheTemporaries in these two bad boys.
19985 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
19986 ldobj or ldind_ref.
19987 (StoreFromPtr): Handle stobj as well.
19989 * expression.cs (UnaryMutator): Share more code.
19991 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
19992 down: I was not tracking the Filter function as well, which
19993 was affecting the results of the cache.
19995 2002-05-15 Miguel de Icaza <miguel@ximian.com>
19997 * attribute.cs: Remove the hack to handle the CharSet property on
20000 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20002 * attribute.cs (DoResolve): More uglyness, we now only try to
20003 resolve the attribute partially, to extract the CharSet
20004 information (only if we are a StructLayout attribute). Otherwise
20006 (GetExtraTypeInfo): Add some code to conditionally kill in the
20007 future this. I am more and more convinced that the .NET
20008 framework has special code to handle the attribute setting on
20011 * expression.cs (IsParamsMethodApplicable): Revert my previous
20012 foreach change here, it was wrong.
20014 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20016 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20017 (pp_expr): do not abort on unknown input, just return.
20018 (eval): abort if there are pending chars.
20020 * attribute.cs (Attribute.Resolve): Positional parameters are
20021 optional. Deal with that case.
20023 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20024 the Ansi/Unicode/Auto information for the type.
20026 (TypeContainer.DefineType): instantiate the EmitContext here, as
20027 we will be using it during the type definition (to resolve
20028 attributes) and during the emit phase.
20030 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20031 to pull type information out of the attributes
20033 (Attribute.Resolve): track the constructor builder, and allow for
20034 multiple invocations (structs and classes will use this).
20036 * ecore.cs (MemberLookupFinal): new version with all the
20037 parameters customizable.
20039 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20040 constructors. Return if the result value is null (as the error
20041 would have been flagged already by MemberLookupFinal)
20043 Do not allow instances of abstract classes or interfaces to be
20046 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20047 We have to compare the assembly property here when dealing with
20048 FamANDAssem and Assembly access modifiers, because we might be
20049 creating an assembly from *modules* (that means that we are not
20050 getting TypeBuilders for types defined in other modules that are
20051 part of this assembly).
20053 (Method.Emit): If the method is marked abstract and has a body,
20056 (TypeContainer.DefineMembers): If both the defined member and the
20057 parent name match are methods, then do not emit any warnings: let
20058 the Method.Define routine take care of flagging warnings. But if
20059 there is a mismatch (method overrides something else, or method is
20060 overriwritten by something, then emit warning).
20062 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20063 set to null, this means `do not check for the return type on the
20066 (Method.Define): set the return type for the method signature to
20067 null, so that we get methods with the same name and parameters and
20068 different return types. This is used to flag warning 114 (you are
20069 hiding a method, and you probably want to use the new/override
20072 * typemanager.cs (MemberLookup): Implemented proper access
20073 control, closing a long standing set of bug reports. The problem
20074 was that the Framework only has two bits: Public and NonPublic,
20075 and NonPublic includes private and protected methods, but we need
20076 to enforce the FamANDAssem, FamOrAssem and Family.
20078 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20080 * statement.cs (GotoCase): Return true: Ammounts to giving up
20081 knowledge on whether we return or not, and letting the other case
20082 be responsible for it.
20084 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20086 * driver.cs: Do not load directories for each file processed, only
20087 do it if there is a pattern.
20089 * ecore.cs: Report readonly assigns here as well, as we might have
20090 been resolved only by MemberAccess.
20092 (SimpleName.SimpleNameResolve): Also be useful for LValue
20093 resolution. We need this to propagate assign to local readonly variables
20095 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20096 do not want to reuse potential criteria memory.
20098 * class.cs (MyEventBuilder): Set reflected_type;
20100 * ecore.cs (Constantify): Added support for constifying bools.
20102 (RootContext.LookupType): Added a cache for values looked up in
20103 the declaration space.
20105 * typemanager.cs (FindMembers): Now is a front-end to
20106 RealFindMembers, and provides a two-level hashtable-based cache to
20109 15% performance improvement: from 22.5 to 19.2 seconds.
20111 * expression.cs (IsParamsMethodApplicable): use foreach.
20112 (Invocation.DoResolve): ditto.
20113 (New.DoResolve): ditto.
20114 (ArrayCreation.DoResolve): ditto.
20116 * ecore.cs (FindMostEncompassingType): use foreach.
20118 * delegate.cs (NewDelegate.DoResolve): Use foreach
20120 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20121 (RemoveMethods): use foreach.
20123 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20124 nested foreach statements instead of for, and also break out of
20125 the inner loop once a match is found.
20127 (Invocation.OverloadResolve): Use foreach, simplify the code.
20129 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20131 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20132 we actually unwrap the expression to allow for extra information
20135 * expression.cs: Use Shr_Un on unsigned operations.
20137 2002-05-08 Ravi Pratap <ravi@ximian.com>
20139 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20140 applicable operators was not being considered correctly. This closes
20141 the bug Miguel reported.
20143 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20145 * attribute.cs: check that the type derives from System.Attribute
20146 and report the correct error in that case (moved the duplicate code to
20147 its own method, too).
20149 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20151 * attribute.cs: lookup attribute type name as the spec says: first the
20152 bare attribute name and then name + "Attribute" (nant compiles with
20153 mcs after this fix).
20155 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20157 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20158 Because of the way we parse things, we should try to see if a
20159 UIntConstant can fit in an integer.
20161 2002-05-07 Ravi Pratap <ravi@ximian.com>
20163 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20164 when we are in an explicit context.
20166 (ConvertReferenceExplicit): When converting from Iface type S to Class
20167 T make sure the rules are implemented as an OR.
20169 * parameter.cs (ParameterType): Make it a property for now although the
20170 purpose really isn't anything immediate.
20172 * expression.cs (Is*Applicable): Do better checking on the parameter type
20173 of a ref/out parameter. The ones from the system assemblies are already
20174 marked with the correct type so we don't need to do any correction.
20176 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20177 the object type is standard too so include that.
20179 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20181 * ecore.cs (StandardConversionExists): Augment with missing code:
20182 deal with IntConstant, LongConstants and Enumerations.
20184 * assign.cs: Report the error, instead of failing silently
20186 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20187 typecontainer that they are declared, because the
20188 typecontainer/namespace will have the list of using clauses that
20189 need to be applied.
20191 Assembly Attributes were escaping the normal registration
20194 (EmitCode): Apply attributes within an EmitContext that represents
20195 the container they were declared on.
20197 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20199 2002-05-06 Ravi Pratap <ravi@ximian.com>
20201 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20202 Revamp completely - make much cleaner as we now operate only
20205 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20206 to implement the logic detailed in the spec more correctly.
20208 (UserDefinedConversion): Update accordingly.
20210 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20212 * statement.cs: Return flow analysis information up.
20214 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20217 (token): Do not consume an extra character before calling
20220 2002-05-06 Piers Haken <piersh@friskit.com>
20222 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20224 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20226 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20227 EmitContext during the instance constructor initializer
20228 resolution, to stop access to instance variables.
20230 This is mandated by the spec, last paragraph of the `constructor
20231 initializers' section.
20233 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20235 * cs-parser.jay, class.cs (Accessor): new class used to represent
20236 an accessor (get or set). In the past we used `null' to represent
20237 a missing accessor. But this is ambiguous because there was no
20238 way to tell in abstract indexers/properties if one of them was
20241 Now there is a way of addressing that.
20243 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20244 instead of FindMembers.
20246 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20247 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20249 * attribute.cs: Treat indexers and properties as the same in terms
20250 of applying attributes
20252 * ecore.cs (FindMostEncompassedType): Use statically initialized
20253 EmptyExpressions()s like we do elsewhere to avoid creating useless
20254 objects (and we take this out of the tight loop).
20256 (GetConversionOperators): Move the code to extract the actual
20257 operators to a separate routine to clean things up.
20259 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20261 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20262 events are always registered FieldBuilders.
20264 * class.cs (FieldBase): New class shared by Fields
20266 * delegate.cs: If we are a toplevel delegate, use our full name.
20267 If we are a nested delegate, then only use our tail name.
20269 2002-05-02 Ravi Pratap <ravi@ximian.com>
20271 * expression.cs (IsApplicable): Ensure that we add the "&" to
20272 ref/out types before comparing it with the type of the argument.
20274 (IsParamsMethodApplicable): Ditto.
20276 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20279 * delegate.cs : Handle the case when we have more than one applicable
20280 method. Flag an error only when we finish checking all.
20282 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20284 * expression.cs: Add support for boolean static initializers.
20286 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20288 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20290 * parameter.cs (ComputeParameterTypes,
20291 ComputeAndDefineParameterTypes): Better error handling: now we
20292 clear the `types' cache if we fail during any of the type lookups.
20293 We also return the status code correctly to our caller
20295 * delegate.cs: If we fail to define a delegate, abort the extra
20298 * expression.cs (Binary.ResolveOperator): for
20299 operator==(object,object) and operator !=(object, object) we also
20300 have to verify that there is an implicit conversion from one to
20303 (ArrayAccess.DoResolve): Array Access can operate on
20306 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20308 * assign.cs (CompoundAssign): A new class used as a "flag" that
20309 the assignment actually is happening as part of a compound
20310 assignment operator.
20312 During compound assignment, a few new rules exist to enable things
20319 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20320 to the type of x) if y is implicitly convertible to the type of x,
20321 and the operator is a builtin operator and the return type of the
20322 operator is explicitly convertible to the type of x.
20324 * rootcontext.cs: Reset warning level to 2. 4 catches various
20325 "interesting" features in mcs, we must clean this up at some
20326 point, but currently am trying to kill other bugs ;-)
20328 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20329 in container classes as well.
20331 * expression.cs (Binary.ResolveOperator): Handle string case
20332 before anything else (as operator overloading does emit an error
20333 before doing anything else).
20335 This code could go away when we move to a table driven model, but
20336 i could not come up with a good plan last night.
20338 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20340 * typemanager.cs (CSharpName): reimplementation using regex.
20341 * class.cs: added null check for fields in Emit
20342 * rootcontext.cs: set warninglevel to 4
20344 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20346 * typemanager.cs (CSharpName): reimplemented with Lupus
20349 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20351 * statement.cs (If): correclty implement Resolve, because we were
20352 not catching sem errors in there. The same process is needed
20354 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20357 (Statement.Warning_DeadCodeFound): Factorize code.
20358 (While): Report dead code here too.
20360 (Statement): Added Resolve virtual method to allow
20361 for resolution split from the emit code.
20363 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20365 * statement.cs (EmitBoolExpression): No longer try to resolve the
20367 (MakeBoolean): New utility function that resolve, implicitly
20368 converts to boolean and tags the expression.
20371 (If, Do): Implement dead code elimination.
20372 (While): Implement loop inversion
20374 (Do, While, For, If): Resolve the expression prior to calling our
20377 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20380 - added method Report28 (warning: program has more than one entry point)
20381 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20382 - modified method Method.Define, the part at the end of the method
20384 * rootcontext.cs: added static public Location EntryPointLocation;
20386 * ../errors/cs0028.cs : Add test case for the above warning.
20389 - modified method CSharpName to allow arrays of primitive type to
20390 be printed nicely (e.g. instead of System.Int32[][] it now prints
20392 - added method CSharpSignature: returns the signature of a method
20393 in string format to be used in reporting errors, warnings, etc.
20395 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20398 2002-04-26 Ravi Pratap <ravi@ximian.com>
20400 * delegate.cs (Define): Fix extremely silly bug where I was
20401 setting the type of the 'object' parameter of the BeginInvoke
20402 method to System.IAsyncResult instead of System.Object ;-)
20404 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20406 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20409 (Constructor.Emit): return if we fail to initialize the
20410 constructor. Another door closed!
20412 * expression.cs (New.DoResolve): Improve error message (from -6 to
20413 1501). Use DeclaredOnly lookup to find the exact constructor.
20415 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20416 loop. This is useful.
20418 * cs-parser.jay: Adjust the default parameters so that destructors
20419 have the proper signature.
20421 2002-04-26 Martin Baulig <martin@gnome.org>
20423 * driver.cs (LoadAssembly): If `assembly' contains any characters
20424 which are only valid in path names and not in assembly names
20425 (currently slash, backslash and point), use Assembly.LoadFrom ()
20426 instead of Assembly.Load () on the `assembly' (before iteration
20427 over the link_paths).
20429 2002-04-26 Martin Baulig <martin@gnome.org>
20431 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20433 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20435 * class.cs (Property): use the new typemanager.MemberLookup
20437 (TypeContainer.MemberLookup): Implement using the
20438 TypeManager.MemberLookup now.
20440 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20441 and return MemberInfos, so that these can be used without an
20442 EmitContext (what we had before).
20444 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20446 * expression.cs: Fix the case where the argument to params if the
20447 type of the params. I omitted handling this before. Fixed
20449 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20451 * driver.cs: Call BootCorlib_PopulateCoreType
20453 * class.cs (Property.CheckBase): Check for properties only, not
20456 * interface.cs: Temporary hack: try/catch around the
20457 CustomAttributeBuilder, because I am getting an exception that I
20460 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20461 types whose definitions are required to be there (attributes are
20462 defined before standard types).
20464 Compute definitions as we boot the various types, as they are used
20465 immediately (value_type class will need object_type, but if we do
20466 not initialize object_type, we will pass a null, which will let
20467 the runtime pick the System.Object from the existing corlib, which
20468 is not what we want).
20470 2002-04-22 Patrik Torstensson <totte@labs2.com>
20472 * cs-tokenizer.cs: fixed a number of trim() issues.
20474 2002-04-22 Ravi Pratap <ravi@ximian.com>
20476 * expression.cs (Argument.Type): Ensure that we return the correct
20477 type when we have out or ref parameters [in which case we
20480 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20482 * class.cs (Property, Indexer): Allow extern modifier in there.
20484 * typemanager.cs (InitBaseTypes): Initializes object_type and
20485 value_type, since those will be used early on during the bootstrap
20486 process to compile corlib.
20488 (InitCoreTypes): Move code from here to InitBaseTypes.
20490 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20492 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20493 single-dimension arrays as using the ldlen opcode.
20495 Daniel Lewis discovered this optimization.
20497 * typemanager.cs: Add signature for System.Array::get_Length
20499 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20501 * statement.cs: report the error when the foreach does not apply to an
20502 array nor a collection.
20504 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20506 * expression.cs: Add implicit conversions to the operator ~.
20508 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20510 * typemanager.cs: Locate the decimal constructor.
20512 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20514 * attribute.cs: use the new property of TypeOf.
20515 * expression.cs: added 'get' property around typearg.
20517 These changes fix a build breaker reported by NickD. Is this the
20518 correct way to fix? If not, please, revert my changes and make it
20521 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20523 * attribute.cs: Add support for typeof in attribute invocations.
20524 I am not sure that this is right though.
20526 2002-04-14 Duncan Mak <duncan@ximian.com>
20528 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20529 Binary.Operator.Division case.
20531 2002-04-13 Ravi Pratap <ravi@ximian.com>
20533 * class.cs (DefineType): Ensure that we do a proper check on
20534 attribute types and also register it with the TypeManager.
20536 (TypeContainer.Targets): The default for attribute types is
20537 AttributeTargets.All.
20539 * attribute.cs (ApplyAttributes): Registering the attribute type
20540 is done elsewhere, not when we discover we have a Usage attribute.
20542 2002-04-12 Ravi Pratap <ravi@ximian.com>
20544 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20545 and get rid of is_delegate parameter.
20547 * everywhere : update.
20549 2002-04-12 Ravi Pratap <ravi@ximian.com>
20551 * cs-parser.jay (compilation_unit): Revamp completely to use
20552 some new ideas that I got from Rhys' grammar to solve the problems
20553 with assembly level attributes.
20555 (outer_declaration): New grammar production.
20557 (attribute_sections): Add.
20559 (opt_attributes): Base on attribute_sections
20561 (namespace_declaration): Allow opt_attributes to tackle the case
20562 when we have assembly level attributes - we are clever in this
20565 * attribute.cs (ApplyAttributes): Do not worry about assembly
20566 attributes in the non-global context.
20568 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20569 instead of SetGlobalAttributes.
20571 * class.cs, rootcontext.cs : Ensure we define and generate
20572 attribute types before anything else.
20574 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20575 and flag the new error -20 for the case when the attribute type
20576 does not have valid targets specified. csc does not catch this.
20578 * ../errors/errors.txt : update for error # -20
20580 2002-04-11 Ravi Pratap <ravi@ximian.com>
20582 * support.cs (InternalParameters.ParameterModifier): Do some null
20583 checking and return sane values.
20585 * class.cs (Method.Define): If we are a PInvoke method, ensure
20586 that we are static and extern. Report error # 601
20588 * ../errors/cs0601.cs : Add test case for the above error.
20590 2002-04-07 Ravi Pratap <ravi@ximian.com>
20592 * rootcontext.cs (attribute_types): We need to keep type of
20593 all attribute types separately and emit code for them first.
20595 (RegisterAttribute) : Implement.
20597 * class.cs (DefineType): Check if the current Type is a custom
20598 attribute type and register it accordingly.
20600 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
20601 adding the first attribute twice and rename to
20603 (SetGlobalAttributes): this.
20605 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
20608 * attribute.cs (ApplyAttributes): Take an additional argument telling us
20609 if we are processing global arguments. Hmm, I am unsure of this.
20611 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20613 * expression.cs: added static array of strings to avoid calling
20614 Enum.ToString () for Operator in Binary. Significant recover of
20617 2002-04-10 Miguel de Icaza <miguel@ximian.com>
20619 * class.cs (FindMembers): Allow the Builders of the various
20620 members to be null. If they are skip them. This only happens
20621 during the PInvoke declaration.
20623 2002-04-09 Miguel de Icaza <miguel@ximian.com>
20625 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
20626 failure, so we do not keep going afterwards.
20628 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
20629 wanted to pass `false' as the `is_delegate' argument. If this is
20630 the case, why not use delegate_type == null to mean `is_delegate =
20631 false' and anything else as is_delegate = true.
20633 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
20635 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
20636 code for the section, not the beginning of the tests.
20638 2002-04-08 Miguel de Icaza <miguel@ximian.com>
20640 * cfold.cs: Handle operator + (Enum x, Underlying x)
20642 * expression.cs (Binary): same. Warn about errors where we have
20643 Enum/Enum in operator + as well.
20645 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
20648 - added support for switch(bool)
20649 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
20650 - add TableSwitchEmit() to handle table-based switch statements
20652 2002-04-05 Ravi Pratap <ravi@ximian.com>
20654 * expression.cs (Invocation.OverloadResolve): Factor out code which
20655 does parameter compatibility checking with arguments so that we can
20656 re-use the code even from Delegate.VerifyApplicability
20658 (VerifyArgumentsCompat): Move above code here.
20660 * delegate.cs (VerifyApplicability): Get rid of duplicate code
20661 and instead make a call to the above method.
20663 2002-03-31 Ravi Pratap <ravi@ximian.com>
20665 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
20666 We use it to keep track of classes which are attribute types.
20668 2002-04-02 Miguel de Icaza <miguel@ximian.com>
20670 * delegate.cs (Delegate.Define): Correctly define the types in the
20671 presence of fixed and array parameters.
20673 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
20676 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
20677 include NonPublic after the first iteration.
20679 * class.cs (Indexer.CheckBase): Only check if both parents are
20682 * cs-parser.jay (accessor_body): If empty, set to null.
20684 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
20685 same code path here to resolve constants names that we did have in
20686 MemberAccess.DoResolve. There is too much code duplicated here.
20688 2002-04-01 Miguel de Icaza <miguel@ximian.com>
20690 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
20692 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
20695 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
20696 tokens, numbers and strings.
20698 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
20701 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
20702 asyncronous parameters and the regular parameters.
20704 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
20705 specify the target directory.
20707 * expression.cs: (This.DoResolve): Simplify
20708 (As.Emit): Optimize, do not generate IsInst if the expression is
20709 always of the given type.
20711 (Is.DoResolve): Bug fix, we were reporting both always/never for
20714 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
20715 creating too many unnecessary arrays.
20717 2002-03-31 Miguel de Icaza <miguel@ximian.com>
20719 * class.cs (EmitFieldInitializer): Use Assign expression to assign
20720 fields instead of rolling our own initializer. Takes care of all
20721 implicit conversions, and drops unnecessary static checks/argument.
20723 2002-03-31 Dick Porter <dick@ximian.com>
20725 * driver.cs: use the GetDirectories() return values properly, and
20726 use "/" as path separator.
20728 2002-03-30 Miguel de Icaza <miguel@ximian.com>
20730 * expression.cs (Unary): Optimize - - expr into expr.
20731 (Binary): Optimize a + (-b) into a -b.
20733 * codegen.cs (CodeGen): Made all methods static.
20735 2002-03-29 Miguel de Icaza <miguel@ximian.com>
20739 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
20740 TypeBuilder property.
20742 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
20745 * tree.cs: Removed the various RecordXXXX, and replaced with a
20746 single RecordDecl. Removed all the accessor methods, and just
20747 left a single access point Type
20749 * enum.cs: Rename DefineEnum to DefineType.
20751 * decl.cs: New abstract method `DefineType' used to unify the
20752 Defines for Enumerations, Interfaces, TypeContainers and
20755 (FindType): Moved LookupInterfaceOrClass here. Moved the
20756 LookupBaseClasses method that used to live in class.cs and
20757 interface.cs here, and renamed to FindType.
20759 * delegate.cs: Implement DefineType. Take advantage of the
20760 refactored pattern for locating the parent builder without taking
20761 the parent_builder argument (which we know does not work if we are
20762 nested, and triggering a toplevel definition).
20764 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20766 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
20767 accessibility of a member has changed during override and report
20770 * class.cs (Method.Define, Property.Define): Only complain on
20771 overrides if the method is private, any other accessibility is
20772 fine (and since we just checked the permission is the same, we are
20775 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
20776 and elif are processed always. The other pre-processing
20777 directives are only processed if we are "taking" the path
20779 2002-03-29 Martin Baulig <martin@gnome.org>
20781 * class.cs (Method.Emit): Only emit symbolic debugging info if the
20782 current location is not Null.
20784 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
20785 a separate method so we can profile it.
20787 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
20788 `span.Seconds' are just seconds, but no minutes or hours.
20789 (MainDriver): Profile the CodeGen.SaveSymbols calls.
20791 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20793 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
20794 Remove the gratuitous set of Final:
20796 // If an interface implementation, then we can set Final.
20797 if (((flags & MethodAttributes.Abstract) == 0) &&
20798 implementing.DeclaringType.IsInterface)
20799 flags |= MethodAttributes.Final;
20801 I do not know what I was smoking when I used that.
20804 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
20805 step into fixing the name resolution issues for delegates and
20806 unifying the toplevel name resolution.
20808 2002-03-28 Martin Baulig <martin@gnome.org>
20810 * class.cs (Method.Emit): If we have a symbol writer, call its
20811 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
20812 tell it about the current method.
20814 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
20815 writer that we're going to emit the first byte of IL code for a new
20816 statement (a new source line).
20817 (EmitContext.EmitTopBlock): If we have a symbol writer, call
20818 EmitContext.Mark() before emitting any code.
20820 * location.cs (SymbolDocument): Return null when we're Null.
20822 * statement.cs (Statement): Moved the `Location loc' variable here.
20823 (Statement.EmitBoolExpression): If we have a symbol writer, call
20824 ec.Mark() before emitting any code to tell it that we're at the
20825 beginning of a new statement.
20826 (StatementExpression): Added `Location' argument to the constructor.
20827 (Block): Added public readonly variable `StartLocation' and public
20828 variable `EndLocation'. The latter is to be set using SetEndLocation().
20829 (Block): Added constructor which takes a start and end location.
20830 (Block.SetEndLocation): New method. This sets the end location.
20831 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
20832 local variables we create.
20833 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
20834 each statement and do also mark the begin and end of the block.
20836 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
20837 tell it the current lexer.Location, use Location.Null for the end of the
20839 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
20840 current block, set its end location using SetEndLocation().
20841 (statement_expression): StatementExpression constructor now takes the
20842 lexer.Location as additional argument.
20843 (for_statement, declare_local_variables): Likewise.
20844 (declare_local_variables): When creating a new implicit block, use the
20845 new Block constructor and pass it the lexer.Location.
20847 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20849 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
20850 members also on the parent interfaces recursively.
20852 2002-03-27 Miguel de Icaza <miguel@ximian.com>
20854 * report.cs: Use new formats, since Gonzalo finished the missing
20857 * expression.cs (Binary.ResolveOperator): added missing operator|
20858 operator& and operator^ for bool/bool.
20860 * cs-parser.jay: CheckDef now takes a Location argument that is
20861 used to report errors more precisly (instead of reporting the end
20862 of a definition, we try to track something which is a lot closer
20863 to the source of the problem).
20865 * cs-tokenizer.cs: Track global token use, so we can properly flag
20866 the use of #define/#undef after the first token has been seen.
20868 Also, rename the reportXXXX to Error_DescriptiveName
20870 * decl.cs (DeclSpace.IsTopLevel): Move property here from
20871 TypeContainer, so that Enum and Interface can use this too.
20873 * class.cs (TypeContainer.LookupInterfaceOrClass,
20874 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
20875 `builder' argument. Typically this was used to pass the parent
20876 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
20879 The problem is that a nested class could trigger the definition of
20880 a toplevel class, and the builder would be obviously wrong in that
20883 So we drop this argument, and we compute dynamically the
20884 TypeBuilder/ModuleBuilder (the correct information was available
20885 to us anyways from DeclSpace.Parent)
20887 * interface.cs (Interface.DefineInterface): Drop builder
20888 parameter cleanup like class.cs
20890 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
20893 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
20896 (Try.Emit): Propagate the returns value from the statement.
20898 (Return.Emit): Even if we are leavning
20900 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
20902 * modifiers.cs: Fix the computation of MethodAttributes flags.
20904 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
20906 * driver.cs: allow compilation of files that start with '/'.
20907 Add a default case when checking the argument of --target.
20909 2002-03-25 Miguel de Icaza <miguel@ximian.com>
20911 * interface.cs: Implement the same search algorithm for types in
20912 the interface code.
20914 * delegate.cs: Do not allow multiple definition.
20916 * Recovered ChangeLog that got accidentally amputated
20918 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
20920 * rootcontext.cs: Load manually enum to allow core classes to
20921 contain enumerations.
20923 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
20924 Update to new static methods in TypeManager.
20926 * typemanager.cs (GetMethod, GetConstructor): Use our
20927 implementation of FindMembers to find the members, since during
20928 corlib compilation, the types are TypeBuilders and GetMethod and
20929 GetConstructor do not work.
20931 Make all methods in TypeManager static.
20933 (InitCodeHelpers): Split the functionality from
20934 the InitCodeTypes function.
20936 * driver.cs: Call InitCodeHelpers after we have populated the
20939 * cs-parser.jay (delegate_declaration): we did not used to compute
20940 the delegate name correctly for void delegates.
20942 2002-03-24 Miguel de Icaza <miguel@ximian.com>
20944 * rootcontext.cs (RootContext): Init the interface_resolve_order
20945 and type_container_resolve_order always.
20947 (ResolveCore, BootstrapCorlib_ResolveClass,
20948 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
20949 compiler when compiling with --nostdlib
20951 * class.cs (TypeContainer.DefineType): Check that our parent is
20952 not null. This test is most important when we are bootstraping
20955 * codegen.cs: Split out the symbol writing code.
20957 2002-03-25 Martin Baulig <martin@gnome.org>
20959 * driver.cs (-g): Made -g an alias for --debug.
20961 2002-03-24 Martin Baulig <martin@gnome.org>
20963 * codegen.cs (SymbolWriter): New public variable. Returns the
20964 current symbol writer.
20965 (CodeGen): Added `bool want_debugging_support' argument to the
20966 constructor. If true, tell the ModuleBuild that we want debugging
20967 support and ask it for the ISymbolWriter.
20968 (Save): If we have a symbol writer, call it's Close() method after
20969 saving the assembly.
20971 * driver.c (--debug): New command line argument to create a
20972 debugger information file.
20974 * location.cs (SymbolDocument): New public property. Returns an
20975 ISymbolDocumentWriter object for the current source file or null
20976 if we don't have a symbol writer.
20978 2002-03-21 Miguel de Icaza <miguel@ximian.com>
20980 * driver.cs (LoadAssembly): Correctly return when all the paths
20981 have been tried and not before.
20983 * statement.cs (Switch.Emit): return the actual coverage for this
20984 statement (returns/not-returns)
20986 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
20987 switch of the statement if we are the last switch section. That
20988 kills two problems: try/catch problems (we used to emit an empty
20989 nop at the end) and switch statements where all branches would
20992 2002-03-19 Miguel de Icaza <miguel@ximian.com>
20994 * driver.cs: Add default assemblies (the equivalent to the
20995 Microsoft CSC.RSP file)
20997 * cs-tokenizer.cs: When updating `cols and setting it to zero,
20998 also update tokens_seen and set it to false.
21000 * driver.cs: Implement --recurse for Mike.
21002 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21003 correctly splitting out the paths.
21005 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21007 * interface.cs (Interface.PopulateProperty): Instead of using
21008 `parent' as the declaration space for the set parameters, use
21011 * support.cs (InternalParameters): InternalParameters constructor
21012 takes a DeclSpace instead of a TypeContainer.
21014 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21015 types are being initialized, load the address of it before calling
21018 (New): Provide a mechanism to disable the generation of local
21019 value type temporaries when the caller will be providing us with
21020 an address to store it.
21022 (ArrayCreation.EmitDynamicInitializers): Use it.
21024 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21026 * expression.cs (Invocation.EmitArguments): Only probe for array
21027 property if there is more than one argument. Sorry about that.
21029 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21030 empty param arrays.
21032 * class.cs (Method.LabelParameters): Fix incorrect code path that
21033 prevented the `ParamArrayAttribute' from being applied to the
21036 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21038 * support.cs (ReflectionParameters): Correctly compute whether the
21039 last argument is a params array. Fixes the problem with
21042 * typemanager.cs: Make the assemblies array always be non-null
21043 (empty, but non-null)
21045 * tree.cs (RecordDecl): New function that abstracts the recording
21046 of names. This reports error 101, and provides a pointer to the
21047 previous declaration. Fixes a crash in the compiler.
21049 * cs-parser.jay (constructor_declaration): Update to new grammar,
21050 and provide a constructor_body that can be empty.
21052 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21054 * driver.cs: Add support for --resources.
21056 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21057 Make all types for the various array helper methods be integer.
21059 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21060 CheckState to ConvCast.
21062 (ConvCast): Now it takes a `checked' state argument, to avoid
21063 depending on the emit context for the conversion, and just using
21064 the resolve time setting.
21066 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21067 instead of Invocation.EmitArguments. We do not emit the original
21068 arguments, instead we emit those which have been converted to
21069 unsigned int expressions.
21071 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21073 * codegen.cs: ditto.
21075 * expression.cs (LocalVariableReference): Drop the use of the
21076 Store function that depended on the variable index.
21078 * statement.cs (VariableInfo): Drop the `Idx' property from this
21079 class, as this is not taking into account the indexes for
21080 temporaries tat we generate during the execution, getting the
21083 * class.cs: First emit class initializers, then call the parent
21086 * expression.cs (Binary): Fix opcode emision.
21087 (UnaryMutator.EmitCode): Support checked code generation
21089 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21090 matches for events for both the Static and Instance scans,
21091 pointing to the same element. Fix that.
21093 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21095 * rootcontext.cs (ResolveTree): Always set the
21096 interface_resolve_order, because nested interfaces will be calling
21099 * class.cs (GetInterfaceOrClass): Track the same resolution
21100 process used by TypeManager.LookupType. This fixes the nested
21101 type lookups in class declarations (separate path from
21104 (TypeContainer.DefineType): Also define nested interfaces.
21105 (TypeContainer.RegisterOrder): New public function used to
21106 register the order in which child interfaces need to be closed.
21108 Nested interfaces need to be closed after their parents have been
21111 * interface.cs (InterfaceAttr): Put all the logic for computing
21112 the interface attribute here.
21114 (DefineInterface): Register our interface order with the
21115 RootContext or with the TypeContainer depending on the case.
21117 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21119 * cs-parser.jay: rework foreach statement to work with the new
21120 changes to the policy on SimpleNames.
21122 * report.cs: support Stacktrace on warnings as well.
21124 * makefile: drop --unsafe and /unsafe from the compile.
21126 2002-03-13 Ravi Pratap <ravi@ximian.com>
21128 * ecore.cs (StandardConversionExists): Modify to take an Expression
21129 as the first parameter. Ensure we do null -> reference type conversion
21132 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21133 temporary Expression objects.
21135 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21137 * interface.cs: workaround bug in method overloading resolution
21138 (there is already a bugzilla bug for it).
21140 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21142 We could also solve this problem by having a separate path for
21143 performing type lookups, instead of DoResolve, we could have a
21144 ResolveType entry point, and only participating pieces of the
21145 production (simplename, deref, array) would implement this.
21147 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21148 signal SimpleName to only resolve type names and not attempt to
21149 resolve anything else.
21151 * expression.cs (Cast): Set the flag.
21153 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21155 * class.cs: Only report 108 if there is no `new' modifier.
21157 * cs-parser.jay: rework foreach statement to work with the new
21158 changes to the policy on SimpleNames.
21160 * report.cs: support Stacktrace on warnings as well.
21162 * makefile: drop --unsafe and /unsafe from the compile.
21164 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21166 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21167 lookups here, instead of doing that at parse time. This means
21168 that our grammar will not introduce `LocalVariableReferences' as
21169 expressions at this point. That solves the problem of code like
21173 static void Main ()
21177 This is only half the fix. The full fix requires parameters to
21178 also be handled in this way.
21180 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21181 makes the use more obvious of the DeclSpace. The
21182 ec.TypeContainer.TypeBuilder is now only used to pull the
21183 TypeBuilder for it.
21185 My theory is that I can get rid of the TypeBuilder completely from
21186 the EmitContext, and have typecasts where it is used (from
21187 DeclSpace to where it matters).
21189 The only pending problem is that the code that implements Aliases
21190 is on TypeContainer, and probably should go in DeclSpace.
21192 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21193 lookups here, instead of doing that at parse time. This means
21194 that our grammar will not introduce `LocalVariableReferences' as
21195 expressions at this point. That solves the problem of code like
21199 static void Main ()
21203 This is only half the fix. The full fix requires parameters to
21204 also be handled in this way.
21206 * class.cs (Property.DefineMethod): When implementing an interface
21207 method, set newslot, when implementing an abstract method, do not
21208 set the flag (before we tried never setting it, or always setting
21209 it, which is the difference).
21210 (Indexer.DefineMethod): same.
21211 (Method.DefineMethod): same.
21213 * ecore.cs: Only set the status used flag if we get back a Field.
21215 * attribute.cs: Temporary hack, so Paolo can keep working.
21217 2002-03-08 Ravi Pratap <ravi@ximian.com>
21219 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21220 the unmanaged type in the case we have a MarshalAs attribute.
21222 (Resolve): Handle the case when we are parsing the special MarshalAs
21223 attribute [we need to store the unmanaged type to use later]
21225 * typemanager.cs (marshal_as_attr_type): Built in type for the
21226 MarshalAs Attribute.
21228 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21229 on parameters and accordingly set the marshalling info.
21231 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21233 * class.cs: Optimizing slightly by removing redundant code after
21234 we switched to the `NoTypes' return value.
21235 (Property.DefineMethod): use NoTypes here too.
21237 This fixes the bug I introduced in my last batch of changes.
21239 2002-03-05 Ravi Pratap <ravi@ximian.com>
21241 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21243 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21244 Enums since those are types too.
21246 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21248 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21249 thanks to a call during the lookup process.
21251 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21253 * statement.cs (Foreach): Lots of work to accomodate a particular
21254 kind of foreach statement that I had not kept in mind. It is
21255 possible to have foreachs on classes that provide a GetEnumerator
21256 method that return objects that implement the "pattern" for using
21257 a foreach, there is no need to support GetEnumerator
21260 This is needed to compile nant.
21262 * decl.cs: Only report 114 if the member is not `Finalize' and if
21263 the warning level is at least 2.
21265 * class.cs: Moved the compare function from Method to
21268 (MethodSignature.InheritableMemberSignatureCompare): Add new
21269 filter function that is used to extract inheritable methods from a
21272 (Method.Define): Use the new `inheritable_method_signature_filter'
21275 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21278 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21280 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21282 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21284 * expression.cs: Pass location information to
21285 ConvertImplicitStandard.
21287 * class.cs: Added debugging code to track return values from
21290 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21292 * expression.cs (Is.DoResolve): If either side of the `is' is an
21293 interface, do not flag the warning.
21295 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21298 * report.cs: Allow for --fatal to be used with --probe.
21300 * typemanager.cs (NoTypes): Move the definition for the empty Type
21303 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21305 (TypeContainer.DefineProxy): New function used to proxy to parent
21306 implementations when implementing interfaces.
21307 (TypeContainer.ParentImplements): used to lookup if our parent
21308 implements a public function that is required by an interface.
21309 (TypeContainer.VerifyPendingMethods): Hook this up.
21311 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21312 `modules' and `assemblies' arraylists into arrays. We only grow
21313 these are the very early start up of the program, so this improves
21314 the speedof LookupType (nicely measured).
21316 * expression.cs (MakeByteBlob): Replaced unsafe code with
21317 BitConverter, as suggested by Paolo.
21319 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21320 folding of string concatenation, but if either side is a string,
21321 and the other is not, then return null, and let the runtime use
21322 the concatenation on the string plus the object (using
21323 `Object.ToString').
21325 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21327 Constant Folding has been implemented now.
21329 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21330 the error instead on types that are not supported in one's
21333 * constant.cs (Constant and all children): New set of functions to
21334 perform implict and explicit conversions.
21336 * ecore.cs (EnumConstant): Implement the new functions to perform
21337 conversion by proxying to the child expression.
21339 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21340 own separate setting that can not be turned off from the command
21341 line using --unchecked or --checked and is only controlled using
21342 the checked/unchecked statements and expressions. This setting is
21343 used by the constant folder to flag errors.
21345 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21346 ConstantCheckState as well.
21348 During Resolve, they also have to flag the state, because the
21349 constant folder runs completely in the Resolve phase.
21351 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21354 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21356 * cfold.cs: New file, this file contains the constant folder.
21358 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21359 argument to track whether we are using the resulting address to
21360 load or store a value and provide better error messages.
21362 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21363 new AddressOf arguments.
21365 * statement.cs (Foreach.EmitCollectionForeach): Update
21367 * expression.cs (Argument.Emit): Call AddressOf with proper
21368 arguments to track usage.
21370 (New.DoEmit): Call AddressOf with new arguments.
21372 (Unary.Emit): Adjust AddressOf call.
21374 2002-03-01 Ravi Pratap <ravi@ximian.com>
21376 * cs-parser.jay (member_access): Change the case for pre-defined types
21377 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21380 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21383 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21384 essentially like methods and apply attributes like MethodImplOptions to them too.
21386 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21389 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21390 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21393 * Update code everywhere accordingly.
21395 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21397 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21399 2002-02-28 Ravi Pratap <ravi@ximian.com>
21401 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21402 try performing lookups against those instead of jumping straight into using
21403 the 'using' clauses.
21405 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21407 (LookupType): Perform lookups in implicit parents too.
21409 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21410 sequence as RootContext.LookupType.
21412 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21413 the various cases of namespace lookups into this method.
21415 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21417 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21418 in positional arguments)
21420 * class.cs (Operator): Update the AllowedModifiers to contain
21423 * cs-parser.jay: Update operator declaration to allow for the
21424 operator body to be empty.
21426 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21429 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21431 * class.cs (Method.Emit): Label parameters.
21433 * driver.cs: Return 1 or 0 as the program exit code.
21435 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21437 * expression.cs: Special case the `null' object when trying to
21438 auto-compute the type, as anything can be explicitly converted to
21441 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21442 spotting this Paolo.
21444 (Expression.ImplicitNumericConversion): Perform comparissions of
21445 the type using the underlying type in the case of an enumeration
21446 rather than using the enumeration type for the compare.
21448 Cope with the underlying == type case, which is not possible to
21451 (Expression.ConvertNumericExplicit): Perform comparissions of
21452 the type using the underlying type in the case of an enumeration
21453 rather than using the enumeration type for the compare.
21455 * driver.cs: If the user does not supply an extension, assume .exe
21457 * cs-parser.jay (if_statement): Rewrote so that we can track the
21458 location for the if statement.
21460 * expression.cs (Binary.ConstantFold): Only concat strings when
21461 the operation is "+", not everything ;-)
21463 * statement.cs (Statement.EmitBoolExpression): Take a location
21465 (If, While, Do): Track location.
21467 * expression.cs (Binary.ResolveOperator): In the object + string
21468 case, I was missing a call to ConvertImplicit
21470 2002-02-25 Ravi Pratap <ravi@ximian.com>
21472 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21473 Location arguments. Ensure we use RootContext.LookupType to do our work
21474 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21476 * interface.cs (PopulateMethod): Handle the type of the parameter being
21479 * expression.cs (Invocation.BetterFunction): Handle the case when we
21480 have a params method with no fixed arguments and a call is made with no
21483 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21485 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21486 the verbatim-string-literal
21488 * support.cs (InternalParameters.ParameterModifier): handle null
21490 (InternalParameters.ParameterType): ditto.
21492 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21493 duplicating the name of the variable parameter.
21494 (GetParameterByName): Fix bug where we were not looking up array
21495 paramters if they were the only present (thanks Paolo!).
21496 (GetParameterInfo): We only have an empty set of types if both
21497 fixed and array are set to null.
21498 (GetParameterInfo-idx): Handle FixedParameter == null
21500 * cs-parser.jay: Handle the case where there is no catch
21501 statements (missing null test).
21503 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21505 * driver.cs (MainDriver): Be conservative on our command line
21508 Catch DirectoryNotFoundException when calling GetFiles.
21510 (SplitPathAndPattern): Used to split the input specification into
21511 a path and a pattern that we can feed to Directory.GetFiles.
21513 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21515 * statement.cs (Fixed): Implement the last case of the Fixed
21516 statement (string handling).
21518 * expression.cs (StringPtr): New class used to return a char * to
21519 a string; Used by the Fixed statement.
21521 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21523 * expression.cs (Binary.ResolveOperator): Remove redundant
21524 MemberLookup pn parent type.
21525 Optimize union call, we do not need a union if the types are the same.
21526 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21529 Specialize the use of MemberLookup everywhere, instead of using
21530 the default settings.
21532 (StackAlloc): Implement stackalloc keyword.
21534 * cs-parser.jay: Add rule to parse stackalloc.
21536 * driver.cs: Handle /h, /help, /?
21538 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21539 before we supported unsafe code.
21541 * makefile: add --unsafe to the self compilation of mcs.
21543 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21545 * expression.cs (PointerArithmetic): New class that is used to
21546 perform pointer arithmetic.
21547 (Binary.Resolve): Handle pointer arithmetic
21548 Handle pointer comparission.
21549 (ArrayPtr): Utility expression class that is used to take the
21550 address of an array.
21552 (ElementAccess): Implement array access for pointers
21554 * statement.cs (Fixed): Implement fixed statement for arrays, we
21555 are missing one more case before we are done.
21557 * expression.cs (Indirection): Implement EmitAssign and set the
21558 ExprClass to Variable. This allows pointer dereferences to be
21559 treated as variables, and to have values assigned to them.
21561 * ecore.cs (Expression.StoreFromPtr): New utility function to
21562 store values dereferencing.
21564 2002-02-20 Ravi Pratap <ravi@ximian.com>
21566 * expression.cs (Binary.ResolveOperator): Ensure that we are
21567 not trying to operate on a void type - this fixes the reported
21570 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21571 the parent implementation is sealed.
21573 * ../errors/cs0239.cs : Add.
21575 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21577 * typemanager.cs (unverifiable_code_type): Corresponds to
21578 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21579 which have unsafe code in them.
21581 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21584 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21586 * cs-tokenizer.cs: Add support for @"litreal strings"
21588 Make tokenizer accept pre-processor directives
21589 on any column (remove the old C-like limitation).
21591 * rootcontext.cs (EmitCode): Emit any global attributes.
21592 (AddGlobalAttributes): Used to keep track of assembly attributes.
21594 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21596 * cs-parser.jay: Add support for global attributes.
21598 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21600 * expression.cs (Indirection): New helper class. Unary will
21601 create Indirection classes to be able to implement the
21602 IMemoryLocation interface on it.
21604 2002-02-16 Miguel de Icaza <miguel@ximian.com>
21606 * cs-parser.jay (fixed_statement): reference the right statement.
21608 * statement.cs (Fixed.Emit): Finish implementing the fixed
21609 statement for the &x case.
21611 2002-02-14 Miguel de Icaza <miguel@ximian.com>
21613 * class.cs (Property.Define, Method.Define): Remove newslot when
21616 * modifiers.cs: My use of NewSlot when `Abstract' was set was
21617 wrong. NewSlot should only be used if the `new' keyword is present.
21619 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
21620 locating our system dir. Sorry about this.
21622 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21624 * driver.cs (GetSystemDir): Compute correctly the location of our
21625 system assemblies. I was using the compiler directory instead of
21626 the library directory.
21628 2002-02-13 Ravi Pratap <ravi@ximian.com>
21630 * expression.cs (BetterFunction): Put back in what Miguel commented out
21631 since it is the correct fix. The problem is elsewhere ;-)
21633 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
21634 parameters of the parms method are themselves compatible or not !
21636 (StandardConversionExists): Fix very dangerous bug where we were forgetting
21637 to check that a class implements an interface before saying that an implicit
21638 conversion was allowed. Use ImplementsInterface to do the checking.
21640 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21642 * class.cs (Method.Define): Track whether we are an explicit
21643 implementation or not. And only call DefineMethodOverride if we
21644 are an explicit implementation.
21646 (Property.DefineMethod): Ditto.
21648 2002-02-11 Ravi Pratap <ravi@ximian.com>
21650 * expression.cs (BetterFunction): Catch hideous bug which was
21651 preventing us from detecting ambiguous calls due to implicit casts i.e
21654 2002-01-29 Miguel de Icaza <miguel@ximian.com>
21656 * support.cs (Pair): Remove un-needed method. I figured why I was
21657 getting the error in cs-parser.jay, the variable in a foreach loop
21658 is readonly, and the compiler does not really treat this as a variable.
21660 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
21661 instead of EQUALS in grammar.
21663 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
21665 * expression.cs (Unary.DoResolve): Check whether the argument is
21668 2002-01-28 Miguel de Icaza <miguel@ximian.com>
21670 * support.cs: Api for Pair to set a value. Despite the fact that
21671 the variables are public the MS C# compiler refuses to compile
21672 code that accesses the field if the variable is part of a foreach
21675 * statement.cs (Fixed): Begin implementation of the fixed
21678 (Block.AddVariable): Return the VariableInfo on success and null
21679 on failure instead of true/false.
21681 * cs-parser.jay (foreach): Catch errors on variables already
21682 defined (we were ignoring this value before) and properly unwind
21683 the block hierarchy
21685 (fixed_statement): grammar for the fixed statement.
21687 2002-01-25 Miguel de Icaza <miguel@ximian.com>
21689 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
21690 pointer types to be incretemented.
21692 (SizeOf): Implement.
21694 * cs-parser.jay (pointer_member_access): Implement
21695 expr->IDENTIFIER production.
21697 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
21698 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
21701 (Unary): Implement indirection.
21703 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
21704 use in non-unsafe context).
21706 (SimpleName.DoResolve): Check for pointers in field access on safe
21709 (Expression.LoadFromPtr): Factor the load-indirect code in this
21710 function. This was duplicated in UnboxCast and ParameterReference
21712 2002-01-24 Miguel de Icaza <miguel@ximian.com>
21714 * expression.cs (ComposedCast): report an error if a pointer cast
21715 is used in a safe region.
21717 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
21718 pointer type casts in unsafe context.
21720 * codegen.cs (EmitContext): Set up IsUnsafe.
21722 * cs-parser.jay (non_expression_type): Add productions for pointer
21725 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
21726 code. We should not use force into static mode if the method is
21727 not virtual. Fixes bug in MIS
21729 * statement.cs (Do.Emit, While.Emit, For.Emit,
21730 Statement.EmitBoolExpression): Add support to Do and While to
21731 propagate infinite loop as `I do return' semantics.
21733 Improve the For case to also test for boolean constants.
21735 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
21736 to the list of attributes we can add.
21738 Remove `EmitContext' argument.
21740 * class.cs (Method.Define): Apply parameter attributes.
21741 (Constructor.Define): Apply parameter attributes.
21742 (MethodCore.LabelParameters): Move here the core of labeling
21745 * support.cs (ReflectionParameters.ParameterModifier,
21746 InternalParameters.ParameterModifier): Use IsByRef on the type and
21747 only return the OUT bit for these parameters instead of in/out/ref
21750 This is because I miss-understood things. The ParameterInfo.IsIn
21751 and IsOut represent whether the parameter has the [In] and [Out]
21754 2002-01-22 Miguel de Icaza <miguel@ximian.com>
21756 * ecore.cs (FieldExpr.Emit): Release temporaries.
21758 * assign.cs (LocalTemporary.Release): new function.
21760 * codegen.cs (EmitContext.GetTemporaryStorage,
21761 EmitContext.FreeTemporaryStorage): Rework the way we deal with
21762 temporary storage. Now we can "put back" localbuilders when we
21765 2002-01-21 Miguel de Icaza <miguel@ximian.com>
21767 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
21768 need to make a copy of the variable to generate verifiable code.
21770 2002-01-19 Miguel de Icaza <miguel@ximian.com>
21772 * driver.cs: Compute dynamically the system directory.
21774 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
21775 Slower, but more generally useful. Used by the abstract
21776 registering implementation.
21778 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
21779 the rules for the special rule on Type/instances. First check if
21780 we have the same name, and if so, try that special static path
21781 rather than the instance path.
21783 2002-01-18 Miguel de Icaza <miguel@ximian.com>
21785 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
21788 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
21789 Enum, ValueType, Delegate or Array for non-corlib compiles.
21791 * cs-tokenizer.cs: Catch long identifiers (645)
21793 * typemanager.cs (IndexerPropetyName): Ravi never tested this
21796 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
21797 fix, we were returning too early, so we were not registering
21798 pending methods from abstract classes.
21800 Do not register pending methods if the class is abstract.
21802 * expression.cs (Conditional.DoResolve): Report circular implicit
21803 conversions when we neecd to compute it for conditional
21806 (Is.DoResolve): If the expression is always of the provided type,
21807 flag warning 183. If the expression can not ever be of the
21808 provided type flag warning 184.
21810 * class.cs: Catch 169 as well.
21812 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
21815 2002-01-18 Nick Drochak <ndrochak@gol.com>
21817 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
21819 2002-01-17 Miguel de Icaza <miguel@ximian.com>
21821 * interface.cs: (PopulateMethod): Check for pointers being defined
21822 only if the unsafe context is active.
21823 (PopulateProperty): ditto.
21824 (PopulateIndexer): ditto.
21826 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
21827 specified. If pointers are present, make sure that they are
21828 present in an unsafe context.
21829 (Constructor, Constructor.Define): ditto.
21830 (Field, Field.Define): ditto.
21831 (Property, Property.Define): ditto.
21832 (Event, Event.Define): ditto.
21834 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
21835 hashtable if there are classes or structs defined.
21837 * expression.cs (LocalVariableReference.DoResolve): Simplify this
21838 code, as the constant resolution moved.
21840 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
21841 the metadata, so we can flag error 133.
21843 * decl.cs (MemberCore.UnsafeOK): New function to test that a
21844 pointer is being declared in an unsafe context.
21846 2002-01-16 Miguel de Icaza <miguel@ximian.com>
21848 * modifiers.cs (Modifiers.Check): Require a Location argument.
21849 Report error 227 for Unsafe use.
21851 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
21853 * statement.cs (For.Emit): If the test is null, then report that
21854 we do `return', as we wont reach anything afterwards.
21856 (Switch.SwitchGoverningType): Track the expression that matched
21859 * driver.cs: Allow negative numbers as an error code to flag.
21861 * cs-parser.jay: Handle 1551.
21863 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
21865 2002-01-15 Miguel de Icaza <miguel@ximian.com>
21867 * cs-parser.jay: Report 1518 (type declaration can only contain
21868 class, struct, interface, enum or delegate)
21870 (switch_label): Report 1523 (keywords `case' or `default' must
21873 (opt_switch_sections): Report 1522 (empty switch)
21875 * driver.cs: Report 1515 (response file specified multiple times)
21876 Report 1516 (Source file specified multiple times).
21878 * expression.cs (Argument.Resolve): Signal 1510
21880 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
21881 access not allowed in static code)
21883 2002-01-11 Ravi Pratap <ravi@ximian.com>
21885 * typemanager.cs (IsPointerType): Utility method which we are going
21888 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
21889 the object type, so we take care of that.
21891 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
21893 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
21894 added to non-params parameters :-)
21896 * typemanager.cs (CSharpName): Include 'void' type too.
21898 (void_ptr_type): Include in the set of core types.
21900 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
21903 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
21906 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
21907 completely forgotten about it.
21909 2002-01-10 Ravi Pratap <ravi@ximian.com>
21911 * cs-parser.jay (pointer_type): Add. This begins our implementation
21912 of parsing rules for unsafe code.
21914 (unsafe_statement): Implement.
21916 (embedded_statement): Modify to include the above.
21918 * statement.cs (Unsafe): Implement new class for unsafe blocks.
21920 * codegen.cs (EmitContext.InUnsafe): Add. This determines
21921 if the current context is an unsafe one.
21923 * cs-parser.jay (local_variable_pointer_type): Since local variable types
21924 are handled differently, we need separate rules for them.
21926 (local_variable_declaration): Update to use local_variable_pointer_type
21927 to allow variable declarations of unmanaged pointer types.
21929 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
21930 in unsafe contexts.
21932 * ../errors/cs0214.cs : Add.
21934 2002-01-16 Nick Drochak <ndrochak@gol.com>
21936 * makefile: remove 'response' file when cleaning.
21938 2002-01-15 Miguel de Icaza <miguel@ximian.com>
21940 * cs-parser.jay: Report 1524.
21942 2002-01-14 Miguel de Icaza <miguel@ximian.com>
21944 * typemanager.cs (RegisterMethod): drop checking if we have
21945 registered this from here
21947 2002-01-12 Miguel de Icaza <miguel@ximian.com>
21949 * class.cs (Method.EmitDestructor): Implement calling our base
21952 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
21953 value of InFinally.
21955 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
21956 this routine and will wrap the call in a try/catch block. Deal
21959 2002-01-11 Miguel de Icaza <miguel@ximian.com>
21961 * ecore.cs (Expression.MemberLookup): instead of taking a
21962 parameter `same_type' that was used to tell whether we could
21963 access private members we compute our containing type from the
21966 (FieldExpr): Added partial support for volatile fields. This does
21967 not work for volatile fields exposed from assemblies, as I can not
21968 figure out how to extract the modreq from it.
21970 Updated all the source files to use this.
21972 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
21973 because it is referenced by MemberLookup very often.
21975 2002-01-09 Ravi Pratap <ravi@ximian.com>
21977 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
21978 TypeBuilder.GetCustomAttributes to retrieve what we need.
21980 Get rid of redundant default_member_attr_type as this is the same as
21981 default_member_type which already exists.
21983 * interface.cs, attribute.cs : Update accordingly.
21985 2002-01-08 Miguel de Icaza <miguel@ximian.com>
21987 * typemanager.cs: Enable IndexerPropertyName again. It does not
21988 work for TYpeBuilders though. Ravi, can you please fix this?
21990 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
21992 * expression.cs (Argument.Emit): Handle the case of ref objects
21993 being passed to ref functions;
21995 (ParameterReference.EmitLoad): Loads the content of the pointer
21996 without dereferencing.
21998 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22000 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22002 2002-01-08 Ravi Pratap <ravi@ximian.com>
22004 * class.cs (Indexer.DefineMethod): Incorporate the interface
22005 type in the name of the method if we are doing explicit interface
22008 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22010 (BetterConversion): Fix extremely trivial bug where we were referring to
22011 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22014 * ../errors/bug16.cs : Add although we have fixed it.
22016 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22018 * expression.cs (BaseIndexer): Begin implementation.
22020 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22022 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22023 production directly to remove a shift/reduce, and implement
22024 explicit interface implementation.
22026 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22027 after a floating point suffix.
22029 * expression.cs (DoNumericPromotions): Improved the conversion for
22030 uint/uint. If we have a constant, we avoid doing a typecast to a
22033 * class.cs (Indexer): Implement explicit interface implementation
22036 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22038 * class.cs: make the default instance constructor public and hidebysig.
22040 2001-01-03 Ravi Pratap <ravi@ximian.com>
22042 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22043 so we can call it from elsewhere.
22045 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22046 we emit it internally if the class has a defined indexer; otherwise the user
22047 emits it by decorating the class definition with the DefaultMemberAttribute.
22049 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22050 attribute is not used on a type which defines an indexer.
22052 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22053 character when we skip whitespace.
22055 * ../errors/cs0646.cs : Add.
22057 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22059 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22062 * makefile: Add practical target `mcs3.exe' which builds the third
22063 generation compiler.
22065 * expression.cs (New): Fix structures constructor calling.
22067 * class.cs (Property, Method, Indexer): Emit Final flag on the
22068 method if we are an interface implementation and we are not
22071 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22072 whether this property is referencing a `base' method.
22074 * expression.cs (Invocation.EmitCall): take an extra argument:
22075 is_base, this is used to determine whether the `call' or
22076 `callvirt' opcode should be used.
22079 * delegate.cs: update EmitCall.
22081 * class.cs (Method.Define): Set NewSlot for the cases where we are
22082 not implementing an interface method.
22084 (Property.Define): ditto.
22086 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22088 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22089 'r'. Allows mcs to parse itself fully.
22091 2002-01-02 Ravi Pratap <ravi@ximian.com>
22093 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22094 of the number of initializers that require the InitializeArray method.
22096 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22097 update the above field where necessary.
22099 (MakeByteBlob): Update accordingly.
22101 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22104 (EmitDynamicInitializers): Update in accordance with the new optimization.
22106 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22107 same OpCode applies.
22109 * cs-parser.jay : Fix some glaring errors I introduced.
22111 2002-01-01 Ravi Pratap <ravi@ximian.com>
22113 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22114 so that we can check for name clashes there too.
22116 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22117 for interface indexers.
22119 * interfaces.cs (Define): Emit the default member attribute.
22121 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22122 variable was being referred to while setting the value ;-)
22124 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22126 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22127 byte-by-byte information when we know the data is zero.
22129 Make the block always a multiple of 4, because
22130 DefineInitializedData has a bug.
22132 * assign.cs: Fix, we should assign from the temporary, not from
22135 * expression.cs (MakeByteBlob): Fix my incorrect code.
22137 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22139 * typemanager.cs (EnumToUnderlying): This function is used to get
22140 the underlying type from an enumeration, because it does not
22143 * constant.cs: Use the I4_S form for values between -128 and 127.
22145 * statement.cs (Block.LookupLabel): Looks up a label.
22146 (Block): Drop support for labeled blocks.
22148 (LabeledStatement): New kind of statement that represents a label
22151 (Goto): Finally implement this bad boy.
22153 * cs-parser.jay: Update to reflect new mechanism to implement
22156 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22158 * codegen.cs (EmitContext.This): a codegen property that keeps the
22159 a single instance of this instead of creating many different this
22162 * delegate.cs (Delegate.DoResolve): Update to use the property;
22164 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22166 * expression.cs (BaseAccess.DoResolve): Ditto.
22168 2001-12-29 Ravi Pratap <ravi@ximian.com>
22170 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22171 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22173 (InitCoreTypes): Update accordingly.
22175 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22176 so we can quickly store the state.
22178 (ApplyAttributes): Set the correct implementation flags
22179 for InternalCall methods.
22181 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22183 * expression.cs (EmitCall): if a method is not virtual, then do
22184 not use callvirt on it.
22186 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22187 user defined stuff) requires the use of stobj, which takes an
22188 address on the stack instead of an array and an index. So emit
22189 the Ldelema operation for it.
22191 (EmitStoreOpcode): Use stobj for valuetypes.
22193 (UnaryMutator.EmitCode): Use the right 1 value depending on
22194 whether we are dealing with int64/uint64, float or doubles.
22196 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22197 constructors that I implemented last night.
22199 (Constructor.IsDefault): Fix to work properly for static
22202 * cs-parser.jay (CheckDef): report method signature errors.
22203 Update error number 103 to be 132.
22205 * decl.cs: New AdditionResult enumeration value: MethodExists.
22206 Although we do this check for methods later on in the semantic
22207 analysis, catching repeated default constructors is so easy that
22208 we catch these here.
22210 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22213 (ParameterReference.EmitAssign, Emit): handle
22216 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22217 (ArrayAccess.EmitStoreOpcode): ditto.
22219 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22221 * expression.cs (MakeByteBlob): Complete all the missing types
22222 (uint, short, ushort, byte, sbyte)
22224 * class.cs: Only init instance field initializers on instance
22227 Rename `constructors' to instance_constructors.
22229 (TypeContainer.AddConstructor): Only add constructors to the list
22230 if it is not static.
22232 Make sure that we handle default_static_constructor independently
22233 everywhere where we handle instance_constructors
22235 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22237 * class.cs: Do not lookup or create a base initializer for a
22238 static constructor.
22240 (ConstructorInitializer.Resolve): use the proper type to lookup
22243 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22245 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22248 * decl.cs: CloseType is now an virtual method, the default
22249 implementation just closes this type.
22251 2001-12-28 Ravi Pratap <ravi@ximian.com>
22253 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22254 to PreserveSig by default. Also emit HideBySig on such methods.
22256 Basically, set the defaults to standard values.
22258 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22259 argument, if candidate is better, it can't be worse than the best !
22261 (Invocation): Re-write bits to differentiate between methods being
22262 applicable in their expanded form and their normal form - for params
22265 Get rid of use_standard everywhere as only standard conversions are allowed
22266 in overload resolution.
22268 More spec conformance.
22270 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22272 * driver.cs: Add --timestamp, to see where the compiler spends
22275 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22276 `this' in static code.
22278 (SimpleName.DoResolve): Implement in terms of a helper function
22279 that allows static-references to be passed upstream to
22282 (Expression.ResolveWithSimpleName): Resolve specially simple
22283 names when called by MemberAccess to implement the special
22286 (Expression.ImplicitReferenceConversion): Handle conversions from
22287 Null to reference types before others, as Null's type is
22290 * expression.cs (Invocation.EmitCall): Handle the special case of
22291 calling methods declared on a reference type from a ValueType
22292 (Base classes System.Object and System.Enum)
22294 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22295 the left hand side is a TypeExpr, not on every enumeration.
22297 (Binary.Resolve): If types are reference types, then do a cast to
22298 object on operators != and == of both arguments.
22300 * typemanager.cs (FindMembers): Extract instance and static
22301 members if requested.
22303 * interface.cs (PopulateProperty): Use void_type instead of null
22304 as the return type for the setter method.
22306 (PopulateIndexer): ditto.
22308 2001-12-27 Ravi Pratap <ravi@ximian.com>
22310 * support.cs (ReflectionParameters): Fix minor bug where we
22311 were examining the wrong parameter for the ParamArray attribute.
22313 Cope with requests for the type of the parameter at position
22314 greater than the params parameter's. We now return the element
22315 type of the params array as that makes more sense.
22317 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22318 accordingly as we no longer have to extract the element type
22321 (Invocation.OverloadResolve): Update.
22323 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22325 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22326 against IEnumerator, test whether the return value is a descendant
22327 of the IEnumerator interface.
22329 * class.cs (Indexer.Define): Use an auxiliary method to implement
22330 the other bits of the method definition. Begin support for
22331 explicit interface implementation.
22333 (Property.DefineMethod): Use TypeManager.void_type instead of null
22334 for an empty return value.
22336 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22338 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22339 dealing with a FieldExpr which is composed of a FieldBuilder, in
22340 the code path we did extract the constant, but we should have
22341 obtained the underlying value to be able to cast it (otherwise we
22342 end up in an infinite loop, this is what Ravi was running into).
22344 (ArrayCreation.UpdateIndices): Arrays might be empty.
22346 (MemberAccess.ResolveMemberAccess): Add support for section
22347 14.5.4.1 that deals with the special case of E.I when E is a type
22348 and something else, that I can be a reference to a static member.
22350 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22351 handle a particular array type to create byte blobs, it is just
22352 something we dont generate byteblobs for.
22354 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22357 * location.cs (Push): remove the key from the hashtable that we
22358 are about to add. This happens for empty files.
22360 * driver.cs: Dispose files after we have parsed them.
22362 (tokenize): new function that only runs the tokenizer on its
22363 input, for speed testing.
22365 2001-12-26 Ravi Pratap <ravi@ximian.com>
22367 * class.cs (Event.Define): Define the private field only if there
22368 are no accessors defined.
22370 * expression.cs (ResolveMemberAccess): If there is no associated
22371 field with the event, that means we have an event defined with its
22372 own accessors and we should flag error cs0070 since transforming
22373 ourselves into a field is not valid in that case.
22375 * ecore.cs (SimpleName.DoResolve): Same as above.
22377 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22378 and charset to sane values.
22380 2001-12-25 Ravi Pratap <ravi@ximian.com>
22382 * assign.cs (DoResolve): Perform check on events only if they
22383 are being accessed outside the declaring type.
22385 * cs-parser.jay (event_declarations): Update rules to correctly
22386 set the type of the implicit parameter etc.
22388 (add_accessor, remove_accessor): Set current local parameters.
22390 * expression.cs (Binary): For delegate addition and subtraction,
22391 cast the return value from the method into the appropriate delegate
22394 2001-12-24 Ravi Pratap <ravi@ximian.com>
22396 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22397 of these as the workaround is unnecessary.
22399 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22400 delegate data - none of that is needed at all.
22402 Re-write bits to extract the instance expression and the delegate method
22405 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22408 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22409 of attaching attributes instead of duplicating code everywhere.
22411 * everywhere : Update code to do attribute emission using the above method.
22413 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22415 * expression.cs (IsParamsMethodApplicable): if there are not
22416 parameters, return immediately.
22418 * ecore.cs: The 0 literal can be implicity converted to an enum
22421 (SimpleName.DoResolve): First lookup the type, then lookup the
22424 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22425 want to get its address. If the InstanceExpression is not
22426 addressable, store the result in a temporary variable, then get
22429 * codegen.cs: Only display 219 errors on warning level or above.
22431 * expression.cs (ArrayAccess): Make it implement the
22432 IMemoryLocation interface.
22434 (Binary.DoResolve): handle the operator == (object a, object b)
22435 and operator != (object a, object b) without incurring into a
22436 BoxedCast (because 5 != o should never be performed).
22438 Handle binary enumerator operators.
22440 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22441 value type, otherwise use Ldelem_ref.
22443 Use precomputed names;
22445 (AddressOf): Implement address of
22447 * cs-parser.jay (labeled_statement): Fix recursive block
22448 addition by reworking the production.
22450 * expression.cs (New.DoEmit): New has a special case:
22452 If we are dealing with a ValueType, we have a few
22453 situations to deal with:
22455 * The target of New is a ValueType variable, that is
22456 easy, we just pass this as the variable reference
22458 * The target of New is being passed as an argument,
22459 to a boxing operation or a function that takes a
22462 In this case, we need to create a temporary variable
22463 that is the argument of New.
22466 2001-12-23 Ravi Pratap <ravi@ximian.com>
22468 * rootcontext.cs (LookupType): Check that current_type is not null before
22469 going about looking at nested types.
22471 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22472 not implement the IAssignMethod interface any more.
22474 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22475 where we tranform them into FieldExprs if they are being resolved from within
22476 the declaring type.
22478 * ecore.cs (SimpleName.DoResolve): Do the same here.
22480 * assign.cs (DoResolve, Emit): Clean up code considerably.
22482 * ../errors/bug10.cs : Add.
22484 * ../errors/cs0070.cs : Add.
22486 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22488 * assign.cs : Get rid of EventIsLocal everywhere.
22490 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22492 * ecore.cs (ConvertIntLiteral): finished the implementation.
22494 * statement.cs (SwitchLabel): Convert the value we are using as a
22495 key before looking up the table.
22497 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22499 * codegen.cs (EmitTopBlock): Require a Location argument now.
22501 * cs-parser.jay (constructor_declarator): We need to setup
22502 current_local_parameters before we parse the
22503 opt_constructor_initializer, to allow the variables to be bound
22504 to the constructor arguments.
22506 * rootcontext.cs (LookupType): First lookup nested classes in our
22507 class and our parents before we go looking outside our class.
22509 * expression.cs (ConstantFold): Extract/debox the values at the
22512 * rootcontext.cs (EmitCode): Resolve the constants first before we
22513 resolve the types. This is not really needed, but it helps debugging.
22515 * statement.cs: report location.
22517 * cs-parser.jay: pass location to throw statement.
22519 * driver.cs: Small bug fix.
22521 * report.cs: Updated format to be 4-zero filled digits.
22523 2001-12-22 Ravi Pratap <ravi@ximian.com>
22525 * expression.cs (CheckIndices): Fix minor bug where the wrong
22526 variable was being referred to ;-)
22528 (DoEmit): Do not call EmitStaticInitializers when the
22529 underlying type is System.Object.
22531 2001-12-21 Ravi Pratap <ravi@ximian.com>
22533 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22534 and do the usual workaround for SRE.
22536 * class.cs (MyEventBuilder.EventType): New member to get at the type
22537 of the event, quickly.
22539 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22541 * assign.cs (Assign.DoResolve): Handle the case when the target
22542 is an EventExpr and perform the necessary checks.
22544 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22547 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22549 (EventExpr): Set the type in the constructor itself since we
22550 are meant to be born fully resolved.
22552 (EventExpr.Define): Revert code I wrote earlier.
22554 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22555 instance expression is null. The instance expression is a This in that case
22556 or a null, depending on whether it is a static method or not.
22558 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22559 refers to more than one method.
22561 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22562 and accordingly flag errors.
22564 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22566 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22568 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22570 * location.cs (ToString): Provide useful rutine.
22572 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22574 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22575 objects, return the actual integral boxed.
22577 * statement.cs (SwitchLabel): define an ILLabel for each
22580 (Switch.CheckSwitch): If the value is a Literal, extract
22581 the underlying literal.
22583 Also in the unused hashtable we had, add the SwitchLabel so we can
22584 quickly look this value up.
22586 * constant.cs: Implement a bunch of new constants. Rewrite
22587 Literal based on this. Made changes everywhere to adapt to this.
22589 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22590 dereferencing array only once, and also copes with enumrations.
22592 bytes are two bytes wide, not one.
22594 (Cast): Perform constant conversions.
22596 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22597 wrappers to the literals here.
22599 * expression.cs (DoNumericPromotions): long literals can converted
22600 to ulong implicity (this is taken care of elsewhere, but I was
22601 missing this spot).
22603 * ecore.cs (Expression.Literalize): Make the return type Literal,
22604 to improve type checking.
22606 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
22608 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22610 * literal.cs: Revert code from ravi that checked the bounds. The
22611 bounds are sane by the definition of the type itself.
22613 * typemanager.cs: Fix implementation of ImplementsInterface. We
22614 need to actually look up in our parent hierarchy for interfaces
22617 * const.cs: Use the underlying type for enumerations
22619 * delegate.cs: Compute the basename for the delegate creation,
22620 that should fix the delegate test case, and restore the correct
22621 Type Lookup semantics in rootcontext
22623 * rootcontext.cs: Revert Ravi's last patch. The correct way of
22624 referencing a nested type with the Reflection API is using the "+"
22627 * cs-parser.jay: Do not require EOF token at the end.
22629 2001-12-20 Ravi Pratap <ravi@ximian.com>
22631 * rootcontext.cs (LookupType): Concatenate type names with
22632 a '.' instead of a '+' The test suite passes again.
22634 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
22635 field of the enumeration.
22637 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
22638 the case when the member is an EventExpr.
22640 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
22641 static has an associated instance expression.
22643 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
22645 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
22647 * class.cs (Event.Define): Register event and perform appropriate checks
22650 We define the Add and Remove methods even if the use provides none because
22651 in that case, we provide default implementations ourselves.
22653 Define a private field of the type of the event. This is done by the CSC compiler
22654 and we should be doing it too ;-)
22656 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
22657 More methods we use in code we generate.
22659 (multicast_delegate_type, delegate_type): Two separate types since the distinction
22662 (InitCoreTypes): Update accordingly for the above.
22664 * class.cs (Event.Emit): Generate code for default accessors that we provide
22666 (EmitDefaultMethod): Do the job in the above.
22668 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
22671 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22673 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
22674 builders even if we were missing one.
22676 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
22677 pass the Basename as our class name instead of the Name. The
22678 basename will be correctly composed for us.
22680 * parameter.cs (Paramters): Now takes a Location argument.
22682 * decl.cs (DeclSpace.LookupType): Removed convenience function and
22683 make all the code call directly LookupType in RootContext and take
22684 this chance to pass the Location information everywhere.
22686 * Everywhere: pass Location information.
22688 2001-12-19 Miguel de Icaza <miguel@ximian.com>
22690 * class.cs (Constructor.Define): Updated way of detecting the
22691 length of the parameters.
22693 (TypeContainer.DefineType): Use basename as the type name for
22696 (TypeContainer.Define): Do not recursively define types here, as
22697 definition is taken care in order by the RootContext.
22699 * tree.cs: Keep track of namespaces in a per-file basis.
22701 * parameter.cs (Parameter.ComputeSignature): Update to use
22704 (Parameters.GetSignature): ditto.
22706 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
22707 instead of a TypeContainer.
22709 (Interface.SemanticAnalysis): Use `this' instead of our parent to
22710 resolve names. Because we need to be resolve in our context, not
22713 * driver.cs: Implement response files.
22715 * class.cs (TypeContainer.DefineType): If we are defined, do not
22716 redefine ourselves.
22718 (Event.Emit): Emit the code for add/remove handlers.
22719 (Event.Define): Save the MethodBuilders for add/remove.
22721 * typemanager.cs: Use pair here too.
22723 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
22724 DictionaryEntry requires the first argument to be non-null.
22726 (enum_declaration): Compute full name for registering the
22729 (delegate_declaration): Instead of using
22730 formal_parameter_list, use opt_formal_parameter_list as the list
22733 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
22734 (EventParsing): New property that controls whether `add' and
22735 `remove' are returned as tokens or identifiers (for events);
22737 2001-12-19 Ravi Pratap <ravi@ximian.com>
22739 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
22740 use MyEventBuilder only and let it wrap the real builder for us.
22742 (MyEventBuilder): Revamp constructor etc.
22744 Implement all operations that we perform on EventBuilder in precisely the same
22747 (FindMembers): Update to use the EventBuilder member.
22749 (Event.Emit): Update accordingly.
22751 2001-12-18 Ravi Pratap <ravi@ximian.com>
22753 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
22754 by calling the appropriate methods.
22756 (GetCustomAttributes): Make stubs as they cannot possibly do anything
22759 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
22761 2001-12-17 Ravi Pratap <ravi@ximian.com>
22763 * delegate.cs (Delegate.Populate): Check that the return type
22764 and various parameters types are indeed accessible.
22766 * class.cs (Constructor.Define): Same here.
22768 (Field.Define): Ditto.
22770 (Event.Define): Ditto.
22772 (Operator.Define): Check that the underlying Method defined itself
22773 correctly - so it's MethodBuilder should not be null.
22775 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
22776 expression happens to be null.
22778 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
22779 members but as of now we don't seem to be able to do anything really useful with it.
22781 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
22782 not the EventBuilder.
22784 2001-12-18 Miguel de Icaza <miguel@ximian.com>
22786 * cs-tokenizer.cs: Add support for defines.
22787 Add support for #if, #elif, #else, #endif
22789 (eval_var): evaluates a variable.
22790 (eval): stubbed for evaluating functions.
22792 * cs-parser.jay: Pass the defines information
22794 * driver.cs: Add --define command line option.
22796 * decl.cs: Move MemberCore here.
22798 Make it the base class for DeclSpace. This allows us to catch and
22799 report 108 and 109 for everything now.
22801 * class.cs (TypeContainer.Define): Extract all the members
22802 before populating and emit the warning 108 (new keyword required
22803 to override) instead of having each member implement this.
22805 (MemberCore.Define): New abstract method, we will be using this in
22806 the warning reporting engine in Populate.
22808 (Operator.Define): Adjust to new MemberCore protocol.
22810 * const.cs (Const): This does not derive from Expression, it is a
22811 temporary object we use to create fields, it is a MemberCore.
22813 * class.cs (Method.Define): Allow the entry point to be in a
22816 * driver.cs: Rewrite the argument handler to clean it up a bit.
22818 * rootcontext.cs: Made it just an auxiliary namespace feature by
22819 making everything static.
22821 * driver.cs: Adapt code to use RootContext type name instead of
22824 * delegate.cs: Remove RootContext argument.
22826 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
22829 * class.cs (Event.Define): The lookup can fail.
22831 * cs-tokenizer.cs: Begin implementation of pre-procesor.
22833 * expression.cs: Resolve the this instance before invoking the code.
22835 2001-12-17 Miguel de Icaza <miguel@ximian.com>
22837 * cs-parser.jay: Add a production in element_access that allows
22838 the thing to become a "type" reference. This way we can parse
22839 things like "(string [])" as a type.
22841 Note that this still does not handle the more complex rules of
22845 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
22847 * ecore.cs: (CopyNewMethods): new utility function used to
22848 assemble the list of methods from running FindMembers.
22850 (MemberLookup): Rework FindMembers so that
22852 2001-12-16 Miguel de Icaza <miguel@ximian.com>
22854 * class.cs (TypeContainer): Remove Delegates who fail to be
22857 * delegate.cs (Populate): Verify that we dont get null return
22858 values. TODO: Check for AsAccessible.
22860 * cs-parser.jay: Use basename to emit error 574 (destructor should
22861 have the same name as container class), not the full name.
22863 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
22864 possible representation.
22866 Also implements integer type suffixes U and L.
22868 2001-12-15 Miguel de Icaza <miguel@ximian.com>
22870 * expression.cs (ArrayCreation.DoResolve): We need to do the
22871 argument resolution *always*.
22873 * decl.cs: Make this hold the namespace. Hold the root context as
22875 (LookupType): Move here.
22877 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
22879 * location.cs (Row, Name): Fixed the code, it was always returning
22880 references to the first file.
22882 * interface.cs: Register properties defined through interfaces.
22884 * driver.cs: Add support for globbing on the command line
22886 * class.cs (Field): Make it derive from MemberCore as well.
22889 2001-12-15 Ravi Pratap <ravi@ximian.com>
22891 * class.cs (Event::Define): Check that the type of the event is a delegate
22892 type else flag error #66.
22894 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
22897 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
22898 values of EntryPoint, CharSet etc etc.
22900 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
22902 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
22903 be null and we should ignore this. I am not sure if this is really clean. Apparently,
22904 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
22905 which needs this to do its work.
22907 * ../errors/cs0066.cs : Add.
22909 2001-12-14 Miguel de Icaza <miguel@ximian.com>
22911 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
22914 * class.cs: (MethodSignature.MethodSignature): Removed hack that
22915 clears out the parameters field.
22916 (MemberSignatureCompare): Cleanup
22918 (MemberCore): New base class used to share code between MethodCore
22921 (RegisterRequiredImplementations) BindingFlags.Public requires
22922 either BindingFlags.Instace or Static. Use instance here.
22924 (Property): Refactored code to cope better with the full spec.
22926 * parameter.cs (GetParameterInfo): Return an empty array instead
22929 * class.cs (Property): Abstract or extern properties have no bodies.
22931 * parameter.cs (GetParameterInfo): return a zero-sized array.
22933 * class.cs (TypeContainer.MethodModifiersValid): Move all the
22934 method modifier validation to the typecontainer so we can reuse
22935 this on properties.
22937 (MethodCore.ParameterTypes): return an empty sized array of types.
22939 (Property.Define): Test property modifier validity.
22941 Add tests for sealed/override too.
22943 (Method.Emit): abstract or extern methods have no bodies.
22945 2001-12-14 Ravi Pratap <ravi@ximian.com>
22947 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
22950 (Method::Define, ::Emit): Modify accordingly.
22952 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
22954 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
22956 * makefile: Pass in /unsafe.
22958 2001-12-13 Miguel de Icaza <miguel@ximian.com>
22960 * class.cs (MakeKey): Kill routine.
22962 * class.cs (TypeContainer.Define): Correctly define explicit
22963 method implementations (they require the full interface name plus
22966 * typemanager.cs: Deply the PtrHashtable here and stop using the
22967 lame keys. Things work so much better.
22969 This of course broke everyone who depended on `RegisterMethod' to
22970 do the `test for existance' test. This has to be done elsewhere.
22972 * support.cs (PtrHashtable): A hashtable that avoid comparing with
22973 the object stupid Equals method (because, that like fails all over
22974 the place). We still do not use it.
22976 * class.cs (TypeContainer.SetRequiredInterface,
22977 TypeContainer.RequireMethods): Killed these two routines and moved
22978 all the functionality to RegisterRequiredImplementations.
22980 (TypeContainer.RegisterRequiredImplementations): This routine now
22981 registers all the implementations required in an array for the
22982 interfaces and abstract methods. We use an array of structures
22983 which can be computed ahead of time to reduce memory usage and we
22984 also assume that lookups are cheap as most classes will not
22985 implement too many interfaces.
22987 We also avoid creating too many MethodSignatures.
22989 (TypeContainer.IsInterfaceMethod): Update and optionally does not
22990 clear the "pending" bit if we find that there are problems with
22993 (TypeContainer.VerifyPendingMethods): Update to report errors of
22994 methods that look like implementations but are not.
22996 (TypeContainer.Define): Add support for explicit interface method
22999 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23001 * typemanager.cs: Keep track of the parameters here instead of
23002 being a feature of the TypeContainer.
23004 * class.cs: Drop the registration of parameters here, as
23005 InterfaceMethods are also interface declarations.
23007 * delegate.cs: Register methods with the TypeManager not only with
23008 the TypeContainer. This code was buggy.
23010 * interface.cs: Full registation here.
23012 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23014 * expression.cs: Remove reducer for binary expressions, it can not
23017 * const.cs: Put here the code that used to go into constant.cs
23019 * constant.cs: Put here the code for constants, this is a new base
23020 class for Literals.
23022 * literal.cs: Make Literal derive from Constant.
23024 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23026 * statement.cs (Return.Emit): Report error 157 if the user
23027 attempts to return from a finally block.
23029 (Return.Emit): Instead of emitting a return, jump to the end of
23032 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23033 LocalBuilder to store the result of the function. ReturnLabel is
23034 the target where we jump.
23037 2001-12-09 Radek Doulik <rodo@ximian.com>
23039 * cs-parser.jay: remember alias in current namespace
23041 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23044 * class.cs (LookupAlias): lookup alias in my_namespace
23046 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23048 (LookupAlias): lookup alias in this and if needed in parent
23051 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23055 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23056 making things static. I need this to avoid passing the
23057 TypeContainer when calling ParameterType.
23059 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23060 that did string manipulation to compute the type and then call
23061 GetType. Use Parameter.ParameterType instead.
23063 * cs-tokenizer.cs: Consume the suffix for floating values.
23065 * expression.cs (ParameterReference): figure out whether this is a
23066 reference parameter or not. Kill an extra variable by computing
23067 the arg_idx during emission.
23069 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23070 function that returns whether a parameter is an out/ref value or not.
23072 (Parameter.ParameterType): The type of the parameter (base,
23073 without ref/out applied).
23075 (Parameter.Resolve): Perform resolution here.
23076 (Parameter.ExternalType): The full type (with ref/out applied).
23078 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23079 support for expressions on the using statement.
23081 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23083 * statement.cs (Using.EmitLocalVariableDecls): Split the
23084 localvariable handling of the using statement.
23086 (Block.EmitMeta): Keep track of variable count across blocks. We
23087 were reusing slots on separate branches of blocks.
23089 (Try.Emit): Emit the general code block, we were not emitting it.
23091 Check the type of the declaration to be an IDisposable or
23092 something that can be implicity converted to it.
23094 Emit conversions if required.
23096 * ecore.cs (EmptyExpression): New utility class.
23097 (Expression.ImplicitConversionExists): New utility function.
23099 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23101 * statement.cs (Using): Implement.
23103 * expression.cs (LocalVariableReference): Support read only variables.
23105 * statement.cs: Remove the explicit emit for the Leave opcode.
23106 (VariableInfo): Add a readonly field.
23108 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23110 * ecore.cs (ConvCast): new class used to encapsulate the various
23111 explicit integer conversions that works in both checked and
23112 unchecked contexts.
23114 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23115 properly generate the overflow opcodes.
23117 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23119 * statement.cs: The correct type for the EmptyExpression is the
23120 element_type, not the variable type. Ravi pointed this out.
23122 2001-12-04 Ravi Pratap <ravi@ximian.com>
23124 * class.cs (Method::Define): Handle PInvoke methods specially
23125 by using DefinePInvokeMethod instead of the usual one.
23127 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23128 above to do the task of extracting information and defining the method.
23130 2001-12-04 Ravi Pratap <ravi@ximian.com>
23132 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23133 of the condition for string type.
23135 (Emit): Move that here.
23137 (ArrayCreation::CheckIndices): Keep string literals in their expression
23140 (EmitDynamicInitializers): Handle strings appropriately.
23142 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23144 * codegen.cs (EmitContext): Replace multiple variables with a
23145 single pointer to the current Switch statement.
23147 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23150 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23154 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23157 (Foreach.Emit): Foreach on arrays was not setting
23158 up the loop variables (for break/continue).
23160 (GotoCase): Semi-implented.
23162 2001-12-03 Ravi Pratap <ravi@ximian.com>
23164 * attribute.cs (CheckAttribute): Handle system attributes by using
23165 Attribute.GetAttributes to examine information we need.
23167 (GetValidPlaces): Same here.
23169 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23171 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23173 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23175 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23177 (Method::Emit): Handle the case when we are a PInvoke method.
23179 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23181 * expression.cs: Use ResolveWithSimpleName on compound names.
23183 2001-12-02 Ravi Pratap <ravi@ximian.com>
23185 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23186 before trying to reduce it.
23188 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23190 * constant.cs (LookupConstantValue): Implement.
23192 (EmitConstant): Use the above in emitting the constant.
23194 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23195 that are user-defined by doing a LookupConstantValue on them.
23197 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23200 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23202 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23204 (BaseAccess.DoResolve): Implement.
23206 (MemberAccess.DoResolve): Split this routine into a
23207 ResolveMemberAccess routine that can be used independently
23209 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23211 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23212 As that share bits of the implementation. Is returns a boolean,
23213 while As returns the Type that is being probed.
23215 2001-12-01 Ravi Pratap <ravi@ximian.com>
23217 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23218 instead of a Literal - much easier.
23220 (EnumInTransit): Remove - utterly useless :-)
23222 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23224 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23226 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23227 chain when we have no associated expression.
23229 2001-11-30 Ravi Pratap <ravi@ximian.com>
23231 * constant.cs (Define): Use Location while reporting the errror.
23233 Also emit a warning when 'new' is used and there is no inherited
23236 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23239 (LookupEnumValue): Implement to lookup an enum member's value and define it
23242 (Populate): Re-write accordingly to use the above routine.
23244 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23246 * expression.cs (This): Fix prototype for DoResolveLValue to
23247 override the base class DoResolveLValue.
23249 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23252 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23253 (we need to load the address of the field here). This fixes
23256 (FieldExpr.DoResolveLValue): Call the DoResolve
23257 function to initialize the Instance expression.
23259 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23260 correctly the GetEnumerator operation on a value type.
23262 * cs-parser.jay: Add more simple parsing error catches.
23264 * statement.cs (Switch): Add support for string switches.
23265 Handle null specially.
23267 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23269 2001-11-28 Ravi Pratap <ravi@ximian.com>
23271 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23273 (declare_local_constant): New helper function.
23275 * statement.cs (AddConstant): Keep a separate record of constants
23277 (IsConstant): Implement to determine if a variable is a constant.
23279 (GetConstantExpression): Implement.
23281 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23283 * statement.cs (IsVariableDefined): Re-write.
23285 2001-11-27 Ravi Pratap <ravi@ximian.com>
23287 * class.cs (TypeContainer::FindMembers): Look for constants
23288 in the case when we are looking for MemberTypes.Field
23290 * expression.cs (MemberAccess::DoResolve): Check that in the
23291 case we are a FieldExpr and a Literal, we are not being accessed
23292 by an instance reference.
23294 * cs-parser.jay (local_constant_declaration): Implement.
23296 (declaration_statement): Implement for constant declarations.
23298 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23300 * statement.cs (Switch): Catch double defaults.
23302 (Switch): More work on the switch() statement
23303 implementation. It works for integral values now, need to finish
23307 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23309 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23310 integer literals into other integer literals. To be used by
23313 2001-11-24 Ravi Pratap <ravi@ximian.com>
23315 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23318 (EmitDynamicInitializers): Cope with the above since we extract data
23319 directly from ArrayData now.
23321 (ExpectInitializers): Keep track of whether initializers are mandatory
23324 (Bounds): Make it a hashtable to prevent the same dimension being
23325 recorded for every element in that dimension.
23327 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23330 Also fix bug which was causing the indices to be emitted in the reverse
23333 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23335 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23336 unfinished. They do not work, because the underlying code is
23339 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23341 * cs-parser.jay: Remove bogus fixme.
23343 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23344 on Switch statement.
23346 2001-11-23 Ravi Pratap <ravi@ximian.com>
23348 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23351 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23352 parameter. Apparently, any expression is allowed.
23354 (ValidateInitializers): Update accordingly.
23356 (CheckIndices): Fix some tricky bugs thanks to recursion.
23358 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23359 I was being completely brain-dead.
23361 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23362 and re-write acordingly.
23364 (DelegateInvocation): Re-write accordingly.
23366 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23368 (MakeByteBlob): Handle types more correctly.
23370 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23371 initialization from expressions but it is incomplete because I am a complete
23374 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23376 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23377 on If. Basically, we have to return `true' (ie, we do return to
23378 our caller) only if both branches of the if return.
23380 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23381 short-circuit operators, handle them as short circuit operators.
23383 (Cast.DoResolve): Resolve type.
23384 (Cast.Cast): Take an expression as the target type.
23386 * cs-parser.jay (cast_expression): Remove old hack that only
23387 allowed a limited set of types to be handled. Now we take a
23388 unary_expression and we resolve to a type during semantic
23391 Use the grammar productions from Rhys to handle casts (this is
23392 not complete like Rhys syntax yet, we fail to handle that corner
23393 case that C# has regarding (-x), but we will get there.
23395 2001-11-22 Ravi Pratap <ravi@ximian.com>
23397 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23398 field which is an array type.
23400 * cs-parser.jay (declare_local_variables): Support array initialization too.
23402 * typemanager.cs (MakeKey): Implement.
23404 (everywhere): Use the above appropriately.
23406 * cs-parser.jay (for_statement): Update for array initialization while
23407 declaring variables.
23409 * ecore.cs : The error message was correct, it's the variable's names that
23410 were misleading ;-) Make the code more readable.
23412 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23413 the correct type etc.
23415 (ConvertExplicit): Handle Enum types by examining the underlying type.
23417 2001-11-21 Ravi Pratap <ravi@ximian.com>
23419 * parameter.cs (GetCallingConvention): Always return
23420 CallingConventions.Standard for now.
23422 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23424 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23425 and `r' after calling DoNumericPromotions.
23427 * ecore.cs: Fix error message (the types were in the wrong order).
23429 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23430 BindingFlags.Instance as well
23432 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23433 implicit int literal conversion in an empty cast so that we
23434 propagate the right type upstream.
23436 (UnboxCast): new class used to unbox value types.
23437 (Expression.ConvertExplicit): Add explicit type conversions done
23440 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23441 the target type before applying the implicit LongLiterals to ULong
23444 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23446 * cs-parser.jay (for_statement): Reworked the way For works: now
23447 we declare manually any variables that are introduced in
23448 for_initializer to solve the problem of having out-of-band code
23449 emition (that is what got for broken).
23451 (declaration_statement): Perform the actual variable declaration
23452 that used to be done in local_variable_declaration here.
23454 (local_variable_declaration): Do not declare anything, just pass
23455 the information on a DictionaryEntry
23457 2001-11-20 Ravi Pratap <ravi@ximian.com>
23459 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23460 re-write of the logic to now make it recursive.
23462 (UpdateIndices): Re-write accordingly.
23464 Store element data in a separate ArrayData list in the above methods.
23466 (MakeByteBlob): Implement to dump the array data into a byte array.
23468 2001-11-19 Ravi Pratap <ravi@ximian.com>
23470 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23473 * constant.cs (Define): Implement.
23475 (EmitConstant): Re-write fully.
23477 Pass in location info.
23479 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23482 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23483 DictionaryEntry since we need location info too.
23485 (constant_declaration): Update accordingly.
23487 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23488 code into another method : UpdateIndices.
23490 2001-11-18 Ravi Pratap <ravi@ximian.com>
23492 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23493 some type checking etc.
23495 2001-11-17 Ravi Pratap <ravi@ximian.com>
23497 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23498 bits to provide dimension info if the user skips doing that.
23500 Update second constructor to store the rank correctly.
23502 2001-11-16 Ravi Pratap <ravi@ximian.com>
23504 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23505 and try to implement.
23507 * ../errors/cs0150.cs : Add.
23509 * ../errors/cs0178.cs : Add.
23511 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23513 * statement.cs: Implement foreach on multi-dimensional arrays.
23515 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23516 name of the params argument.
23518 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23519 initializing the array.
23521 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23522 we can use this elsewhere.
23524 * statement.cs: Finish implementation of foreach for single
23527 * cs-parser.jay: Use an out-of-band stack to pass information
23528 around, I wonder why I need this.
23530 foreach_block: Make the new foreach_block the current_block.
23532 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23533 function used to return a static Parameters structure. Used for
23534 empty parameters, as those are created very frequently.
23536 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23538 2001-11-15 Ravi Pratap <ravi@ximian.com>
23540 * interface.cs : Default modifier is private, not public. The
23541 make verify test passes again.
23543 2001-11-15 Ravi Pratap <ravi@ximian.com>
23545 * support.cs (ReflectionParameters): Fix logic to determine
23546 whether the last parameter is a params one. Test 9 passes again.
23548 * delegate.cs (Populate): Register the builders we define with
23549 RegisterParameterForBuilder. Test 19 passes again.
23551 * cs-parser.jay (property_declaration): Reference $6 instead
23552 of $$ to get at the location.
23554 (indexer_declaration): Similar stuff.
23556 (attribute): Ditto.
23558 * class.cs (Property): Register parameters for the Get and Set methods
23559 if they exist. Test 23 passes again.
23561 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23562 call to EmitArguments as we are sure there aren't any params arguments.
23563 Test 32 passes again.
23565 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23566 IndexOutOfRangeException.
23568 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23569 Test 33 now passes again.
23571 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23573 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23574 broke a bunch of things. Will have to come up with a better way
23575 of tracking locations.
23577 * statement.cs: Implemented foreach for single dimension arrays.
23579 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23581 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23582 an error. This removes the lookup from the critical path.
23584 * cs-parser.jay: Removed use of temporary_loc, which is completely
23587 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23589 * support.cs (ReflectionParameters.ParameterModifier): Report
23590 whether the argument is a PARAMS argument or not.
23592 * class.cs: Set the attribute `ParamArrayAttribute' on the
23593 parameter argument.
23595 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23596 and cons_param_array_attribute (ConstructorInfo for
23597 ParamArrayAttribute).,
23599 * codegen.cs: Emit the return using the `Return' statement, that
23600 way we can report the error correctly for missing return values.
23602 * class.cs (Method.Emit): Clean up.
23604 * expression.cs (Argument.Resolve): Take another argument: the
23605 location where this argument is used. Notice that this is not
23606 part of the "Argument" class as to reduce the size of the
23607 structure (we know the approximate location anyways).
23609 Test if the argument is a variable-reference, if not, then
23610 complain with a 206.
23612 (Argument.Emit): Emit addresses of variables.
23614 (Argument.FullDesc): Simplify.
23616 (Invocation.DoResolve): Update for Argument.Resolve.
23618 (ElementAccess.DoResolve): ditto.
23620 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
23621 method should be virtual, as this method is always virtual.
23623 (NewDelegate.DoResolve): Update for Argument.Resolve.
23625 * class.cs (ConstructorInitializer.DoResolve): ditto.
23627 * attribute.cs (Attribute.Resolve): ditto.
23629 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23631 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
23633 * expression.cs (ParameterReference): Drop IStackStorage and implement
23634 IAssignMethod instead.
23636 (LocalVariableReference): ditto.
23638 * ecore.cs (FieldExpr): Drop IStackStorage and implement
23639 IAssignMethod instead.
23641 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23643 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
23644 enumerations that are used in heavily used structures derive from
23645 byte in a laughable and pathetic attempt to reduce memory usage.
23646 This is the kind of pre-optimzations that you should not do at
23647 home without adult supervision.
23649 * expression.cs (UnaryMutator): New class, used to handle ++ and
23650 -- separatedly from the other unary operators. Cleans up the
23651 code, and kills the ExpressionStatement dependency in Unary.
23653 (Unary): Removed `method' and `Arguments' from this class, making
23654 it smaller, and moving it all to SimpleCall, so I can reuse this
23655 code in other locations and avoid creating a lot of transient data
23656 strucutres when not required.
23658 * cs-parser.jay: Adjust for new changes.
23660 2001-11-11 Miguel de Icaza <miguel@ximian.com>
23662 * enum.cs (Enum.Populate): If there is a failure during
23665 * cs-parser.jay (opt_enum_base): we used to catch type errors
23666 here, but this is really incorrect. The type error should be
23667 catched during semantic analysis.
23669 2001-12-11 Ravi Pratap <ravi@ximian.com>
23671 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
23672 current_local_parameters as expected since I, in my stupidity, had forgotten
23675 * attribute.cs (GetValidPlaces): Fix stupid bug.
23677 * class.cs (Method::Emit): Perform check on applicability of attributes.
23679 (Constructor::Emit): Ditto.
23681 (Field::Emit): Ditto.
23683 (Field.Location): Store location information.
23685 (Property, Event, Indexer, Operator): Ditto.
23687 * cs-parser.jay (field_declaration): Pass in location for each field.
23689 * ../errors/cs0592.cs : Add.
23691 2001-11-12 Ravi Pratap <ravi@ximian.com>
23693 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
23695 (InitCoreTypes): Update accordingly.
23697 (RegisterAttrType, LookupAttr): Implement.
23699 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
23700 info about the same.
23702 (Resolve): Update to populate the above as necessary.
23704 (Error592): Helper.
23706 (GetValidPlaces): Helper to the above.
23708 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
23710 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
23712 2001-11-12 Ravi Pratap <ravi@ximian.com>
23714 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
23716 * ../errors/cs0617.cs : Add.
23718 2001-11-11 Ravi Pratap <ravi@ximian.com>
23720 * enum.cs (Emit): Rename to Populate to be more consistent with what
23721 we expect it to do and when exactly it is called.
23723 * class.cs, rootcontext.cs : Update accordingly.
23725 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
23726 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
23728 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
23730 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
23731 of a fieldinfo using the above, when dealing with a FieldBuilder.
23733 2001-11-10 Ravi Pratap <ravi@ximian.com>
23735 * ../errors/cs0031.cs : Add.
23737 * ../errors/cs1008.cs : Add.
23739 * ../errrors/cs0543.cs : Add.
23741 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
23744 (FindMembers): Implement.
23746 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
23747 enums and delegates too.
23749 (enum_types): Rename to builder_to_enum.
23751 (delegate_types): Rename to builder_to_delegate.
23753 * delegate.cs (FindMembers): Implement.
23755 2001-11-09 Ravi Pratap <ravi@ximian.com>
23757 * typemanager.cs (IsEnumType): Implement.
23759 * enum.cs (Emit): Re-write parts to account for the underlying type
23760 better and perform checking etc.
23762 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
23763 of the underlying type.
23765 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
23768 * enum.cs (error31): Helper to report error #31.
23770 * cs-parser.jay (enum_declaration): Store location of each member too.
23772 * enum.cs (member_to_location): New hashtable.
23774 (AddEnumMember): Update location hashtable.
23776 (Emit): Use the location of each member while reporting errors.
23778 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23780 * cs-parser.jay: A for_initializer if is a
23781 local_variable_declaration really ammount to have an implicit
23782 block with the variable declaration and no initializer for for.
23784 * statement.cs (For.Emit): Cope with null initializers.
23786 This fixes the infinite loop on for initializers.
23788 2001-11-08 Miguel de Icaza <miguel@ximian.com>
23790 * enum.cs: More cleanup.
23792 * ecore.cs: Remove dead code.
23794 * class.cs (Property.Emit): More simplification.
23795 (Event.Emit): ditto.
23797 Reworked to have less levels of indentation.
23799 2001-11-08 Ravi Pratap <ravi@ximian.com>
23801 * class.cs (Property): Emit attributes.
23811 * enum.cs (Emit): Ditto.
23813 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
23816 * class.cs (Field, Event, etc.): Move attribute generation into the
23817 Emit method everywhere.
23819 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
23820 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
23821 as we had no way of defining nested enums !
23823 * rootcontext.cs : Adjust code accordingly.
23825 * typemanager.cs (AddEnumType): To keep track of enum types separately.
23827 2001-11-07 Ravi Pratap <ravi@ximian.com>
23829 * expression.cs (EvalConstantExpression): Move into ecore.cs
23831 * enum.cs (Enum): Rename some members and make them public and readonly
23832 according to our convention.
23834 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
23837 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
23839 (Enum::Emit): Write a simple version for now which doesn't try to compute
23840 expressions. I shall modify this to be more robust in just a while.
23842 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
23844 (TypeContainer::CloseType): Create the Enum types too.
23846 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
23848 * expression.cs (EvalConstantExpression): Get rid of completely.
23850 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
23851 user-defined values and other cases.
23853 (IsValidEnumLiteral): Helper function.
23855 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
23856 out there in the case we had a literal FieldExpr.
23858 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
23860 (Literalize): Revamp a bit to take two arguments.
23862 (EnumLiteral): New class which derives from Literal to wrap enum literals.
23864 2001-11-06 Ravi Pratap <ravi@ximian.com>
23866 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
23868 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
23870 (Resolve): Use the above to ensure we have proper initializers.
23872 2001-11-05 Ravi Pratap <ravi@ximian.com>
23874 * expression.cs (Expression::EvalConstantExpression): New method to
23875 evaluate constant expressions.
23877 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
23879 2001-11-07 Miguel de Icaza <miguel@ximian.com>
23881 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
23884 (Binary.ResolveOperator): Handle operator != (object a, object b)
23885 and operator == (object a, object b);
23887 (Binary.DoNumericPromotions): Indicate whether the numeric
23888 promotion was possible.
23890 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
23893 Made the ArrayAccess implement interface IAssignMethod instead of
23894 IStackStore as the order in which arguments are passed reflects
23897 * assign.cs: Instead of using expr.ExprClass to select the way of
23898 assinging, probe for the IStackStore/IAssignMethod interfaces.
23900 * typemanager.cs: Load InitializeArray definition.
23902 * rootcontext.cs (RootContext.MakeStaticData): Used to define
23903 static data that can be used to initialize arrays.
23905 2001-11-05 Miguel de Icaza <miguel@ximian.com>
23907 * expression.cs: Handle operator== and operator!= for booleans.
23909 (Conditioal.Reduce): Implement reducer for the ?: operator.
23911 (Conditional.Resolve): Implement dead code elimination.
23913 (Binary.Resolve): Catch string literals and return a new
23914 concatenated string.
23916 (Unary.Reduce): Implement reduction of unary expressions.
23918 * ecore.cs: Split out the expression core handling here.
23920 (Expression.Reduce): New method used to perform constant folding
23921 and CSE. This is needed to support constant-expressions.
23923 * statement.cs (Statement.EmitBoolExpression): Pass true and false
23924 targets, and optimize for !x.
23926 2001-11-04 Ravi Pratap <ravi@ximian.com>
23928 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
23929 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
23930 set custom atttributes.
23932 * literal.cs (Literal::GetValue): New abstract method to return the actual
23933 value of the literal, cast as an object.
23935 (*Literal): Implement GetValue method.
23937 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
23938 expressions to the arraylist but objects of type Argument.
23940 * class.cs (TypeContainer::Emit): Emit our attributes too.
23942 (Method::Emit, Constructor::Emit): Ditto.
23944 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
23945 to be ignoring earlier.
23947 2001-11-03 Ravi Pratap <ravi@ximian.com>
23949 * attribute.cs (AttributeSection::Define): Implement to do the business
23950 of constructing a CustomAttributeBuilder.
23952 (Attribute): New trivial class. Increases readability of code.
23954 * cs-parser.jay : Update accordingly.
23956 (positional_argument_list, named_argument_list, named_argument): New rules
23958 (attribute_arguments): Use the above so that we are more correct.
23960 2001-11-02 Ravi Pratap <ravi@ximian.com>
23962 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
23963 to perform all checks for a method with a params parameter.
23965 (Invocation::OverloadResolve): Update to use the above method and therefore
23966 cope correctly with params method invocations.
23968 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
23971 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
23972 constructors in our parent too because we can't afford to miss out on
23975 * attribute.cs (AttributeSection): New name for the class Attribute
23977 Other trivial changes to improve readability.
23979 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
23980 use the new class names.
23982 2001-11-01 Ravi Pratap <ravi@ximian.com>
23984 * class.cs (Method::Define): Complete definition for params types too
23986 (Indexer::Define): Ditto.
23988 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
23989 Cope everywhere with a request for info about the array parameter.
23991 2001-11-01 Ravi Pratap <ravi@ximian.com>
23993 * tree.cs (RecordNamespace): Fix up to check for the correct key.
23995 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
23996 local_variable_type to extract the string corresponding to the type.
23998 (local_variable_type): Fixup the action to use the new helper method.
24000 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24003 * expression.cs : Clean out code which uses the above.
24005 2001-10-31 Ravi Pratap <ravi@ximian.com>
24007 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24008 and bale out if necessary by returning a false.
24010 (RegisterProperty): Ditto.
24012 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24013 and print out appropriate error messages.
24015 * interface.cs (everywhere): Ditto.
24017 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24018 location to constructor.
24020 * class.cs (Property, Event, Indexer): Update accordingly.
24022 * ../errors/cs111.cs : Added.
24024 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24025 of a method, as laid down by the spec.
24027 (Invocation::OverloadResolve): Use the above method.
24029 2001-10-31 Ravi Pratap <ravi@ximian.com>
24031 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24032 now take a TypeContainer and a Parameters object.
24034 (ParameterData): Modify return type of ParameterModifier method to be
24035 Parameter.Modifier and not a string.
24037 (ReflectionParameters, InternalParameters): Update accordingly.
24039 * expression.cs (Argument::GetParameterModifier): Same here.
24041 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24042 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24043 symbol in it at all so maybe this is only for now.
24045 2001-10-30 Ravi Pratap <ravi@ximian.com>
24047 * support.cs (InternalParameters): Constructor now takes an extra argument
24048 which is the actual Parameters class.
24050 (ParameterDesc): Update to provide info on ref/out modifiers.
24052 * class.cs (everywhere): Update call to InternalParameters to pass in
24053 the second argument too.
24055 * support.cs (ParameterData): Add ParameterModifier, which is a method
24056 to return the modifier info [ref/out etc]
24058 (InternalParameters, ReflectionParameters): Implement the above.
24060 * expression.cs (Argument::ParameterModifier): Similar function to return
24061 info about the argument's modifiers.
24063 (Invocation::OverloadResolve): Update to take into account matching modifiers
24066 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24067 a new SetFormalParameters object which we pass to InternalParameters.
24069 2001-10-30 Ravi Pratap <ravi@ximian.com>
24071 * expression.cs (NewArray): Merge into the ArrayCreation class.
24073 2001-10-29 Ravi Pratap <ravi@ximian.com>
24075 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24076 NewUserdefinedArray into one as there wasn't much of a use in having
24079 * expression.cs (Argument): Change field's name to ArgType from Type.
24081 (Type): New readonly property which returns the proper type, taking into
24082 account ref/out modifiers.
24084 (everywhere): Adjust code accordingly for the above.
24086 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24087 whether we are emitting for a ref or out parameter.
24089 * expression.cs (Argument::Emit): Use the above field to set the state.
24091 (LocalVariableReference::Emit): Update to honour the flag and emit the
24094 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24096 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24098 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24100 (ReflectionParameters, InternalParameters): Implement the above method.
24102 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24105 (Invocation::FullMethodDesc): Ditto.
24107 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24109 * cs-parser.jay: Add extra production for the second form of array
24112 * expression.cs (ArrayCreation): Update to reflect the above
24115 * Small changes to prepare for Array initialization.
24117 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24119 * typemanager.cs (ImplementsInterface): interface might be null;
24120 Deal with this problem;
24122 Also, we do store negative hits on the cache (null values), so use
24123 this instead of calling t.GetInterfaces on the type everytime.
24125 2001-10-28 Ravi Pratap <ravi@ximian.com>
24127 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24129 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24130 split functionality out into different classes.
24132 (New::FormArrayType): Move into NewBuiltinArray.
24134 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24137 (NewBuiltinArray): New class to handle creation of built-in arrays.
24139 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24140 account creation of one-dimensional arrays.
24142 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24144 (NewUserdefinedArray::DoResolve): Implement.
24146 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24148 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24149 we maintain inside the TypeManager. This is necessary to perform lookups on the
24152 (LookupType): Update to perform GetType on the module builders too.
24154 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24156 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24158 2001-10-23 Ravi Pratap <ravi@ximian.com>
24160 * expression.cs (New::DoResolve): Implement guts of array creation.
24162 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24164 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24166 * expression.cs: Fix bug I introduced lsat night that broke
24169 (Expression.Resolve): Report a 246 error (can not resolve name)
24170 if we find a SimpleName in the stream.
24172 (Expression.ResolveLValue): Ditto.
24174 (Expression.ResolveWithSimpleName): This function is a variant of
24175 ResolveName, this one allows SimpleNames to be returned without a
24176 warning. The only consumer of SimpleNames is MemberAccess
24178 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24180 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24181 might arrive here. I have my doubts that this is correct.
24183 * statement.cs (Lock): Implement lock statement.
24185 * cs-parser.jay: Small fixes to support `lock' and `using'
24187 * cs-tokenizer.cs: Remove extra space
24189 * driver.cs: New flag --checked, allows to turn on integer math
24192 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24193 Threading.Monitor.Exit
24195 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24197 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24198 Expression Class to be IndexerAccess.
24200 Notice that Indexer::DoResolve sets the eclass to Value.
24202 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24204 * class.cs (TypeContainer::Emit): Emit code for indexers.
24206 * assign.cs (IAssignMethod): New interface implemented by Indexers
24207 and Properties for handling assignment.
24209 (Assign::Emit): Simplify and reuse code.
24211 * expression.cs (IndexerAccess, PropertyExpr): Implement
24212 IAssignMethod, clean up old code.
24214 2001-10-22 Ravi Pratap <ravi@ximian.com>
24216 * typemanager.cs (ImplementsInterface): New method to determine if a type
24217 implements a given interface. Provides a nice cache too.
24219 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24222 (ConvertReferenceExplicit): Ditto.
24224 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24225 various methods, with correct names etc.
24227 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24228 Operator.UnaryNegation.
24230 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24231 we have a unary plus or minus operator.
24233 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24236 * everywhere : update accordingly.
24238 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24241 * class.cs (Method::Define): For the case where we are implementing a method
24242 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24243 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24245 2001-10-21 Ravi Pratap <ravi@ximian.com>
24247 * interface.cs (FindMembers): Implement to work around S.R.E
24250 * typemanager.cs (IsInterfaceType): Implement.
24252 (FindMembers): Update to handle interface types too.
24254 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24255 use IsAssignableFrom as that is not correct - it doesn't work.
24257 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24258 and accordingly override EmitStatement.
24260 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24261 using the correct logic :-)
24263 2001-10-19 Ravi Pratap <ravi@ximian.com>
24265 * ../errors/cs-11.cs : Add to demonstrate error -11
24267 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24269 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24270 then pass this as a hint to ResolveLValue.
24272 * expression.cs (FieldExpr): Add Location information
24274 (FieldExpr::LValueResolve): Report assignment to readonly
24277 (Expression::ExprClassFromMemberInfo): Pass location information.
24279 (Expression::ResolveLValue): Add new method that resolves an
24282 (Expression::DoResolveLValue): Default invocation calls
24285 (Indexers): New class used to keep track of indexers in a given
24288 (IStackStore): Renamed from LValue, as it did not really describe
24289 what this did. Also ResolveLValue is gone from this interface and
24290 now is part of Expression.
24292 (ElementAccess): Depending on the element access type
24294 * typemanager.cs: Add `indexer_name_type' as a Core type
24295 (System.Runtime.CompilerServices.IndexerNameAttribute)
24297 * statement.cs (Goto): Take a location.
24299 2001-10-18 Ravi Pratap <ravi@ximian.com>
24301 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24302 if two delegates are compatible.
24304 (NewDelegate::DoResolve): Update to take care of the case when
24305 we instantiate a delegate from another delegate.
24307 * typemanager.cs (FindMembers): Don't even try to look up members
24308 of Delegate types for now.
24310 2001-10-18 Ravi Pratap <ravi@ximian.com>
24312 * delegate.cs (NewDelegate): New class to take care of delegate
24315 * expression.cs (New): Split the delegate related code out into
24316 the NewDelegate class.
24318 * delegate.cs (DelegateInvocation): New class to handle delegate
24321 * expression.cs (Invocation): Split out delegate related code into
24322 the DelegateInvocation class.
24324 2001-10-17 Ravi Pratap <ravi@ximian.com>
24326 * expression.cs (New::DoResolve): Implement delegate creation fully
24327 and according to the spec.
24329 (New::DoEmit): Update to handle delegates differently.
24331 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24332 because of which we were printing out arguments in reverse order !
24334 * delegate.cs (VerifyMethod): Implement to check if the given method
24335 matches the delegate.
24337 (FullDelegateDesc): Implement.
24339 (VerifyApplicability): Implement.
24341 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24342 delegate invocations too.
24344 (Invocation::Emit): Ditto.
24346 * ../errors/cs1593.cs : Added.
24348 * ../errors/cs1594.cs : Added.
24350 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24352 2001-10-16 Ravi Pratap <ravi@ximian.com>
24354 * typemanager.cs (intptr_type): Core type for System.IntPtr
24356 (InitCoreTypes): Update for the same.
24358 (iasyncresult_type, asynccallback_type): Ditto.
24360 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24363 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24366 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24367 the builders for the 4 members of a delegate type :-)
24369 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24372 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24374 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24376 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24378 * statement.cs (Break::Emit): Implement.
24379 (Continue::Emit): Implement.
24381 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24382 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24383 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24384 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24387 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24388 properties that track the label for the current loop (begin of the
24389 loop and end of the loop).
24391 2001-10-15 Ravi Pratap <ravi@ximian.com>
24393 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24394 use of emitting anything at all.
24396 * class.cs, rootcontext.cs : Get rid of calls to the same.
24398 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24400 (Populate): Define the constructor correctly and set the implementation
24403 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24406 (AddDelegateType): Implement.
24408 (IsDelegateType): Implement helper method.
24410 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24412 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24413 and accordingly handle it.
24415 * delegate.cs (Populate): Take TypeContainer argument.
24416 Implement bits to define the Invoke method. However, I still haven't figured out
24417 how to take care of the native int bit :-(
24419 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24420 Qualify the name of the delegate, not its return type !
24422 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24425 (StandardConversionExists): Checking for array types turns out to be recursive.
24427 (ConvertReferenceExplicit): Implement array conversion.
24429 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24431 2001-10-12 Ravi Pratap <ravi@ximian.com>
24433 * cs-parser.jay (delegate_declaration): Store the fully qualified
24434 name as it is a type declaration.
24436 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24439 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24440 as TypeContainer::DefineType.
24442 (Populate): Method in which all the definition of the various methods (Invoke)
24445 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24448 (CloseDelegate): Finally creates the delegate.
24450 * class.cs (TypeContainer::DefineType): Update to define delegates.
24451 (Populate, Emit and CloseType): Do the same thing here too.
24453 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24454 delegates in all these operations.
24456 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24458 * expression.cs: LocalTemporary: a new expression used to
24459 reference a temporary that has been created.
24461 * assign.cs: Handle PropertyAccess back here, so that we can
24462 provide the proper semantic access to properties.
24464 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24465 a few more explicit conversions.
24467 * modifiers.cs: `NEW' modifier maps to HideBySig.
24469 * expression.cs (PropertyExpr): Make this into an
24470 ExpressionStatement, and support the EmitStatement code path.
24472 Perform get/set error checking, clean up the interface.
24474 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24475 them into toplevel access objects.
24477 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24479 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24482 * typemanager.cs: Keep track here of our PropertyBuilders again to
24483 work around lameness in SRE.
24485 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24487 * expression.cs (LValue::LValueResolve): New method in the
24488 interface, used to perform a second resolution pass for LValues.
24490 (This::DoResolve): Catch the use of this in static methods.
24492 (This::LValueResolve): Implement.
24494 (This::Store): Remove warning, assigning to `this' in structures
24497 (Invocation::Emit): Deal with invocation of
24498 methods on value types. We need to pass the address to structure
24499 methods rather than the object itself. (The equivalent code to
24500 emit "this" for structures leaves the entire structure on the
24501 stack instead of a pointer to it).
24503 (ParameterReference::DoResolve): Compute the real index for the
24504 argument based on whether the method takes or not a `this' pointer
24505 (ie, the method is static).
24507 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24508 value types returned from functions when we need to invoke a
24509 method on the sturcture.
24512 2001-10-11 Ravi Pratap <ravi@ximian.com>
24514 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24515 defining the type in the Modulebuilder or Typebuilder. This is to take
24516 care of nested types which need to be defined on the TypeBuilder using
24517 DefineNestedMethod.
24519 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24520 methods in RootContext, only ported to be part of TypeContainer.
24522 (TypeContainer::GetInterfaceOrClass): Ditto.
24524 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24526 * interface.cs (Interface::DefineInterface): New method. Does exactly
24527 what RootContext.CreateInterface did earlier, only it takes care of nested types
24530 (Interface::GetInterfaces): Move from RootContext here and port.
24532 (Interface::GetInterfaceByName): Same here.
24534 * rootcontext.cs (ResolveTree): Re-write.
24536 (PopulateTypes): Re-write.
24538 * class.cs (TypeContainer::Populate): Populate nested types too.
24539 (TypeContainer::Emit): Emit nested members too.
24541 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24542 instead just use the name argument passed in as it is already fully
24545 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24546 to TypeContainer mapping to see if a type is user-defined.
24548 * class.cs (TypeContainer::CloseType): Implement.
24550 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24551 the default constructor.
24553 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24556 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24558 * interface.cs (CloseType): Create the type here.
24560 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24563 Remove all the methods which are now in TypeContainer.
24565 2001-10-10 Ravi Pratap <ravi@ximian.com>
24567 * delegate.cs (Define): Re-write bits to define the delegate
24570 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24572 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24574 * expression.cs (ImplicitReferenceConversion): handle null as well
24575 as a source to convert to any reference type.
24577 * statement.cs (Return): Perform any implicit conversions to
24578 expected return type.
24580 Validate use of return statement.
24582 * codegen.cs (EmitContext): Pass the expected return type here.
24584 * class.cs (Method, Constructor, Property): Pass expected return
24585 type to EmitContext.
24587 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24589 * expression.cs: Make DoResolve take an EmitContext instead of a
24592 Replaced `l' and `location' for `loc', for consistency.
24594 (Error, Warning): Remove unneeded Tc argument.
24596 * assign.cs, literal.cs, constant.cs: Update to new calling
24599 * codegen.cs: EmitContext now contains a flag indicating whether
24600 code is being generated in a static method or not.
24602 * cs-parser.jay: DecomposeQI, new function that replaces the old
24603 QualifiedIdentifier. Now we always decompose the assembled
24604 strings from qualified_identifier productions into a group of
24607 2001-10-08 Miguel de Icaza <miguel@ximian.com>
24609 * rootcontext.cs: Deal with field-less struct types correctly now
24610 by passing the size option to Define Type.
24612 * class.cs: Removed hack that created one static field.
24614 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24616 * statement.cs: Moved most of the code generation here.
24618 2001-10-09 Ravi Pratap <ravi@ximian.com>
24620 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
24623 (ElementAccess): Remove useless bits for now - keep checks as the spec
24626 2001-10-08 Ravi Pratap <ravi@ximian.com>
24628 * expression.cs (ElementAccess::DoResolve): Remove my crap code
24629 and start performing checks according to the spec.
24631 2001-10-07 Ravi Pratap <ravi@ximian.com>
24633 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
24634 rank_specifiers instead.
24636 (rank_specifiers): Change the order in which the rank specifiers are stored
24638 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
24640 * expression.cs (ElementAccess): Implement the LValue interface too.
24642 2001-10-06 Ravi Pratap <ravi@ximian.com>
24644 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
24645 except that user defined conversions are not included.
24647 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
24648 perform the conversion of the return type, if necessary.
24650 (New::DoResolve): Check whether we are creating an array or an object
24651 and accordingly do the needful.
24653 (New::Emit): Same here.
24655 (New::DoResolve): Implement guts of array creation.
24657 (New::FormLookupType): Helper function.
24659 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24661 * codegen.cs: Removed most of the code generation here, and move the
24662 corresponding code generation bits to the statement classes.
24664 Added support for try/catch/finalize and throw.
24666 * cs-parser.jay: Added support for try/catch/finalize.
24668 * class.cs: Catch static methods having the flags override,
24669 virtual or abstract.
24671 * expression.cs (UserCast): This user cast was not really doing
24672 what it was supposed to do. Which is to be born in fully resolved
24673 state. Parts of the resolution were being performed at Emit time!
24677 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24679 * expression.cs: Implicity convert the result from UserCast.
24681 2001-10-05 Ravi Pratap <ravi@ximian.com>
24683 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
24684 prevented it from working correctly.
24686 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
24687 merely ConvertImplicit.
24689 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24691 * typemanager.cs: Make the LookupTypeContainer function static,
24692 and not per-instance.
24694 * class.cs: Make static FindMembers (the one that takes a Type
24697 * codegen.cs: Add EmitForeach here.
24699 * cs-parser.jay: Make foreach a toplevel object instead of the
24700 inline expansion, as we need to perform semantic analysis on it.
24702 2001-10-05 Ravi Pratap <ravi@ximian.com>
24704 * expression.cs (Expression::ImplicitUserConversion): Rename to
24705 UserDefinedConversion.
24707 (Expression::UserDefinedConversion): Take an extra argument specifying
24708 whether we look for explicit user conversions too.
24710 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
24712 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
24714 (ExplicitUserConversion): Make it a call to UserDefinedConversion
24715 with the appropriate arguments.
24717 * cs-parser.jay (cast_expression): Record location too.
24719 * expression.cs (Cast): Record location info.
24721 (Expression::ConvertExplicit): Take location argument.
24723 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
24724 to determine if we are doing explicit conversions.
24726 (UserCast::Emit): Update accordingly.
24728 (Expression::ConvertExplicit): Report an error if everything fails.
24730 * ../errors/cs0030.cs : Add.
24732 2001-10-04 Miguel de Icaza <miguel@ximian.com>
24734 * modifiers.cs: If the ABSTRACT keyword is present, also set the
24735 virtual and newslot bits.
24737 * class.cs (TypeContainer::RegisterRequiredImplementations):
24738 Record methods we need.
24740 (TypeContainer::MakeKey): Helper function to make keys for
24741 MethodBases, since the Methodbase key is useless.
24743 (TypeContainer::Populate): Call RegisterRequiredImplementations
24744 before defining the methods.
24746 Create a mapping for method_builders_to_methods ahead of time
24747 instead of inside a tight loop.
24749 (::RequireMethods): Accept an object as the data to set into the
24750 hashtable so we can report interface vs abstract method mismatch.
24752 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24754 * report.cs: Make all of it static.
24756 * rootcontext.cs: Drop object_type and value_type computations, as
24757 we have those in the TypeManager anyways.
24759 Drop report instance variable too, now it is a global.
24761 * driver.cs: Use try/catch on command line handling.
24763 Add --probe option to debug the error reporting system with a test
24766 * report.cs: Add support for exiting program when a probe
24767 condition is reached.
24769 2001-10-03 Ravi Pratap <ravi@ximian.com>
24771 * expression.cs (Binary::DoNumericPromotions): Fix the case when
24772 we do a forcible conversion regardless of type, to check if
24773 ForceConversion returns a null.
24775 (Binary::error19): Use location to report error.
24777 (Unary::error23): Use location here too.
24779 * ../errors/cs0019.cs : Check in.
24781 * ../errors/cs0023.cs : Check in.
24783 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
24784 case of a non-null MethodInfo object with a length of 0 !
24786 (Binary::ResolveOperator): Flag error if overload resolution fails to find
24787 an applicable member - according to the spec :-)
24788 Also fix logic to find members in base types.
24790 (Unary::ResolveOperator): Same here.
24792 (Unary::report23): Change name to error23 and make first argument a TypeContainer
24793 as I was getting thoroughly confused between this and error19 :-)
24795 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
24796 (::FindMostEncompassedType): Implement.
24797 (::FindMostEncompassingType): Implement.
24798 (::StandardConversionExists): Implement.
24800 (UserImplicitCast): Re-vamp. We now need info about most specific
24801 source and target types so that we can do the necessary conversions.
24803 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
24804 mathematical union with no duplicates.
24806 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24808 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
24809 in order from base classes to child classes, so that we can in
24810 child classes look up in our parent for method names and
24811 attributes (required for handling abstract, virtual, new, override
24812 constructs: we need to instrospect our base class, and if we dont
24813 populate the classes in order, the introspection might be
24814 incorrect. For example, a method could query its parent before
24815 the parent has any methods and would determine that the parent has
24816 no abstract methods (while it could have had them)).
24818 (RootContext::CreateType): Record the order in which we define the
24821 2001-10-02 Miguel de Icaza <miguel@ximian.com>
24823 * class.cs (TypeContainer::Populate): Also method definitions can
24824 fail now, keep track of this.
24826 (TypeContainer::FindMembers): Implement support for
24827 DeclaredOnly/noDeclaredOnly flag.
24829 (Constructor::Emit) Return the ConstructorBuilder.
24831 (Method::Emit) Return the MethodBuilder.
24832 Check for abstract or virtual methods to be public.
24834 * rootcontext.cs (RootContext::CreateType): Register all the
24835 abstract methods required for the class to be complete and the
24836 interface methods that must be implemented.
24838 * cs-parser.jay: Report error 501 (method requires body if it is
24839 not marked abstract or extern).
24841 * expression.cs (TypeOf::Emit): Implement.
24843 * typemanager.cs: runtime_handle_type, new global type.
24845 * class.cs (Property::Emit): Generate code for properties.
24847 2001-10-02 Ravi Pratap <ravi@ximian.com>
24849 * expression.cs (Unary::ResolveOperator): Find operators on base type
24850 too - we now conform exactly to the spec.
24852 (Binary::ResolveOperator): Same here.
24854 * class.cs (Operator::Define): Fix minor quirk in the tests.
24856 * ../errors/cs0215.cs : Added.
24858 * ../errors/cs0556.cs : Added.
24860 * ../errors/cs0555.cs : Added.
24862 2001-10-01 Miguel de Icaza <miguel@ximian.com>
24864 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
24865 single integer which is really efficient
24867 2001-10-01 Ravi Pratap <ravi@ximian.com>
24869 * expression.cs (Expression::ImplicitUserConversion): Use location
24870 even in the case when we are examining True operators.
24872 * class.cs (Operator::Define): Perform extensive checks to conform
24873 with the rules for operator overloading in the spec.
24875 * expression.cs (Expression::ImplicitReferenceConversion): Implement
24876 some of the other conversions mentioned in the spec.
24878 * typemanager.cs (array_type): New static member for the System.Array built-in
24881 (cloneable_interface): For System.ICloneable interface.
24883 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
24884 we start resolving the tree and populating types.
24886 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
24888 2001-10-01 Miguel de Icaza <miguel@ximian.com>
24890 * expression.cs (Expression::ExprClassFromMemberInfo,
24891 Expression::Literalize): Create literal expressions from
24892 FieldInfos which are literals.
24894 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
24895 type casts, because they were wrong. The test suite in tests
24898 (ImplicitNumericConversion): ushort to ulong requires a widening
24901 Int32 constant to long requires widening cast as well.
24903 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
24904 for integers because the type on the stack is not i4.
24906 2001-09-30 Miguel de Icaza <miguel@ximian.com>
24908 * expression.cs (report118): require location argument.
24910 * parameter.cs: Do not dereference potential null value.
24912 * class.cs: Catch methods that lack the `new' keyword when
24913 overriding a name. Report warnings when `new' is used without
24914 anything being there to override.
24916 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
24918 * class.cs: Only add constructor to hashtable if it is non-null
24919 (as now constructors can fail on define).
24921 (TypeManager, Class, Struct): Take location arguments.
24923 Catch field instance initialization in structs as errors.
24925 accepting_filter: a new filter for FindMembers that is static so
24926 that we dont create an instance per invocation.
24928 (Constructor::Define): Catch errors where a struct constructor is
24931 * cs-parser.jay: Pass location information for various new
24934 * delegate.cs (Delegate): take a location argument.
24936 * driver.cs: Do not call EmitCode if there were problesm in the
24937 Definition of the types, as many Builders wont be there.
24939 * decl.cs (Decl::Decl): Require a location argument.
24941 * cs-tokenizer.cs: Handle properly hex constants that can not fit
24942 into integers, and find the most appropiate integer for it.
24944 * literal.cs: Implement ULongLiteral.
24946 * rootcontext.cs: Provide better information about the location of
24947 failure when CreateType fails.
24949 2001-09-29 Miguel de Icaza <miguel@ximian.com>
24951 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
24954 * expression.cs (Binary::CheckShiftArguments): Add missing type
24956 (Binary::ResolveOperator): Add type to the logical and and logical
24957 or, Bitwise And/Or and Exclusive Or code paths, it was missing
24960 (Binary::DoNumericPromotions): In the case where either argument
24961 is ulong (and most signed types combined with ulong cause an
24962 error) perform implicit integer constant conversions as well.
24964 2001-09-28 Miguel de Icaza <miguel@ximian.com>
24966 * expression.cs (UserImplicitCast): Method should always be
24968 (Invocation::BetterConversion): Simplified test for IntLiteral.
24970 (Expression::ImplicitNumericConversion): Split this routine out.
24971 Put the code that performs implicit constant integer conversions
24974 (Expression::Resolve): Become a wrapper around DoResolve so we can
24975 check eclass and type being set after resolve.
24977 (Invocation::Badness): Remove this dead function
24979 (Binary::ResolveOperator): Do not compute the expensive argumnets
24980 unless we have a union for it.
24982 (Probe::Emit): Is needs to do an isinst and then
24983 compare against null.
24985 (::CanConvert): Added Location argument. If the Location argument
24986 is null (Location.Null), then we do not report errors. This is
24987 used by the `probe' mechanism of the Explicit conversion. We do
24988 not want to generate an error for something that the user
24989 explicitly requested to be casted. But the pipeline for an
24990 explicit cast first tests for potential implicit casts.
24992 So for now, if the Location is null, it means `Probe only' to
24993 avoid adding another argument. Might have to revise this
24996 (ClassCast): New class used to type cast objects into arbitrary
24997 classes (used in Explicit Reference Conversions).
24999 Implement `as' as well.
25001 Reverted all the patches from Ravi below: they were broken:
25003 * The use of `level' as a mechanism to stop recursive
25004 invocations is wrong. That was there just to catch the
25005 bug with a strack trace but not as a way of addressing
25008 To fix the problem we have to *understand* what is going
25009 on and the interactions and come up with a plan, not
25010 just get things going.
25012 * The use of the type conversion cache that I proposed
25013 last night had an open topic: How does this work across
25014 protection domains. A user defined conversion might not
25015 be public in the location where we are applying the
25016 conversion, a different conversion might be selected
25017 (ie, private A->B (better) but public B->A (worse),
25018 inside A, A->B applies, but outside it, B->A will
25021 * On top of that (ie, even if the above is solved),
25022 conversions in a cache need to be abstract. Ie, `To
25023 convert from an Int to a Short use an OpcodeCast', not
25024 `To convert from an Int to a Short use the OpcodeCast on
25025 the variable 5' (which is what this patch was doing).
25027 2001-09-28 Ravi Pratap <ravi@ximian.com>
25029 * expression.cs (Invocation::ConversionExists): Re-write to use
25030 the conversion cache
25032 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25033 cache all conversions done, not just user-defined ones.
25035 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25036 to determine if a conversion exists instead of acutually trying to
25037 perform the conversion. It's faster too.
25039 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25040 and only then attempt the implicit conversion.
25042 2001-09-28 Ravi Pratap <ravi@ximian.com>
25044 * expression.cs (ConvertImplicit): Use a cache for conversions
25045 already found. Check level of recursion and bail out if necessary.
25047 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25049 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25050 Export standard methods that we expect for string operations.
25052 * statement.cs (Block::UsageWarning): Track usage of variables and
25053 report the errors for not used variables.
25055 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25058 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25060 * codegen.cs: remove unnneded code
25062 * expression.cs: Removed BuiltinTypeAccess class
25064 Fix the order in which implicit conversions are
25067 The previous fixed dropped support for boxed conversions (adding a
25068 test to the test suite now)
25070 (UserImplicitCast::CanConvert): Remove test for source being null,
25071 that code is broken. We should not feed a null to begin with, if
25072 we do, then we should track the bug where the problem originates
25073 and not try to cover it up here.
25075 Return a resolved expression of type UserImplicitCast on success
25076 rather than true/false. Ravi: this is what I was talking about,
25077 the pattern is to use a static method as a "constructor" for
25080 Also, do not create arguments until the very last minute,
25081 otherwise we always create the arguments even for lookups that
25082 will never be performed.
25084 (UserImplicitCast::Resolve): Eliminate, objects of type
25085 UserImplicitCast are born in a fully resolved state.
25087 * typemanager.cs (InitCoreTypes): Init also value_type
25088 (System.ValueType).
25090 * expression.cs (Cast::Resolve): First resolve the child expression.
25092 (LValue): Add new method AddressOf to be used by
25095 Change the argument of Store to take an EmitContext instead of an
25096 ILGenerator, because things like FieldExpr need to be able to call
25097 their children expression to generate the instance code.
25099 (Expression::Error, Expression::Warning): Sugar functions for
25102 (Expression::MemberLookup): Accept a TypeContainer instead of a
25103 Report as the first argument.
25105 (Expression::ResolvePrimary): Killed. I still want to improve
25106 this as currently the code is just not right.
25108 (Expression::ResolveMemberAccess): Simplify, but it is still
25111 (Unary::Resolve): Catch errors in AddressOf operators.
25113 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25114 index to a byte for the short-version, or the compiler will choose
25115 the wrong Emit call, which generates the wrong data.
25117 (ParameterReference::Emit, ::Store): same.
25119 (FieldExpr::AddressOf): Implement.
25121 * typemanager.cs: TypeManager: made public variable instead of
25124 * driver.cs: document --fatal.
25126 * report.cs (ErrorMessage, WarningMessage): new names for the old
25127 Error and Warning classes.
25129 * cs-parser.jay (member_access): Turn built-in access to types
25130 into a normal simplename
25132 2001-09-27 Ravi Pratap <ravi@ximian.com>
25134 * expression.cs (Invocation::BetterConversion): Fix to cope
25135 with q being null, since this was introducing a bug.
25137 * expression.cs (ConvertImplicit): Do built-in conversions first.
25139 2001-09-27 Ravi Pratap <ravi@ximian.com>
25141 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25143 2001-09-27 Ravi Pratap <ravi@ximian.com>
25145 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25146 I had introduced long ago (what's new ?).
25148 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25149 the work of all the checking.
25150 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25151 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25153 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25154 that is the right way.
25156 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25157 overloading resolution. Use everywhere instead of cutting and pasting code.
25159 (Binary::ResolveOperator): Use MakeUnionSet.
25161 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25162 we have to convert to bool types. Not complete yet.
25164 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25166 * typemanager.cs (TypeManager::CSharpName): support ushort.
25168 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25169 to provide an expression that performsn an implicit constant int
25170 conversion (section 6.1.6).
25171 (Expression::ConvertImplicitRequired): Reworked to include
25172 implicit constant expression conversions.
25174 (Expression::ConvertNumericExplicit): Finished.
25176 (Invocation::Emit): If InstanceExpression is null, then it means
25177 that we perform a call on this.
25179 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25181 * expression.cs (Unary::Emit): Remove some dead code.
25182 (Probe): Implement Resolve and Emit for `is'.
25183 (Expression::ConvertImplicitRequired): Attempt to do constant
25184 expression conversions here. Maybe should be moved to
25185 ConvertImplicit, but I am not sure.
25186 (Expression::ImplicitLongConstantConversionPossible,
25187 Expression::ImplicitIntConstantConversionPossible): New functions
25188 that tell whether is it possible to apply an implicit constant
25189 expression conversion.
25191 (ConvertNumericExplicit): Started work on explicit numeric
25194 * cs-parser.jay: Update operator constants.
25196 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25197 (Parameters::GetSignature): Hook up VerifyArgs here.
25198 (Parameters::VerifyArgs): Verifies that no two arguments have the
25201 * class.cs (Operator): Update the operator names to reflect the
25202 ones that the spec expects (as we are just stringizing the
25205 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25206 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25207 previous usage did only work for our methods.
25208 (Expression::ConvertImplicit): Handle decimal implicit numeric
25209 conversions as well.
25210 (Expression::InternalTypeConstructor): Used to invoke constructors
25211 on internal types for default promotions.
25213 (Unary::Emit): Implement special handling for the pre/post
25214 increment/decrement for overloaded operators, as they need to have
25215 the same semantics as the other operators.
25217 (Binary::ResolveOperator): ditto.
25218 (Invocation::ConversionExists): ditto.
25219 (UserImplicitCast::Resolve): ditto.
25221 2001-09-26 Ravi Pratap <ravi@ximian.com>
25223 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25224 operator, return after emitting body. Regression tests pass again !
25226 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25227 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25228 (Invocation::OverloadResolve): Ditto.
25229 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25231 * everywhere : update calls to the above methods accordingly.
25233 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25235 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25237 * expression.cs (ExpressionStatement): New base class used for
25238 expressions that can appear in statements, so that we can provide
25239 an alternate path to generate expression that do not leave a value
25242 (Expression::Emit, and all the derivatives): We no longer return
25243 whether a value is left on the stack or not. Every expression
25244 after being emitted leaves a single value on the stack.
25246 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25247 facilties of ExpressionStatement if possible.
25249 * cs-parser.jay: Update statement_expression.
25251 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25253 * driver.cs: Change the wording of message
25255 2001-09-25 Ravi Pratap <ravi@ximian.com>
25257 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25258 the type of the expression to the return type of the method if
25259 we have an overloaded operator match ! The regression tests pass again !
25260 (Unary::ResolveOperator): Ditto.
25262 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25263 to find "op_Implicit", not "implicit" ;-)
25264 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25265 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25267 * everywhere : Correct calls to the above accordingly.
25269 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25270 (ConvertImplicit): Do user-defined conversion if it exists.
25272 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25274 * assign.cs: track location.
25275 (Resolve): Use implicit conversions on assignment.
25277 * literal.cs: Oops. Not good, Emit of short access values should
25278 pass (Bytes) or the wrong argument will be selected.
25280 * expression.cs (Unary::Emit): Emit code for -expr.
25282 (Unary::ResolveOperator): Handle `Substract' for non-constants
25283 (substract from zero from the non-constants).
25284 Deal with Doubles as well.
25286 (Expression::ConvertImplicitRequired): New routine that reports an
25287 error if no implicit conversion exists.
25289 (Invocation::OverloadResolve): Store the converted implicit
25290 expressions if we make them
25292 2001-09-24 Ravi Pratap <ravi@ximian.com>
25294 * class.cs (ConstructorInitializer): Take a Location argument.
25295 (ConstructorBaseInitializer): Same here.
25296 (ConstructorThisInitializer): Same here.
25298 * cs-parser.jay : Update all calls accordingly.
25300 * expression.cs (Unary, Binary, New): Take location argument.
25301 Update accordingly everywhere.
25303 * cs-parser.jay : Update all calls to the above to take a location
25306 * class.cs : Ditto.
25308 2001-09-24 Ravi Pratap <ravi@ximian.com>
25310 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25311 (Invocation::BetterConversion): Same here
25312 (Invocation::ConversionExists): Ditto.
25314 (Invocation::ConversionExists): Implement.
25316 2001-09-22 Ravi Pratap <ravi@ximian.com>
25318 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25319 Also take an additional TypeContainer argument.
25321 * All over : Pass in TypeContainer as argument to OverloadResolve.
25323 * typemanager.cs (CSharpName): Update to check for the string type and return
25326 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25329 2001-09-21 Ravi Pratap <ravi@ximian.com>
25331 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25332 (Invocation::BetterFunction): Implement.
25333 (Invocation::BetterConversion): Implement.
25334 (Invocation::ConversionExists): Skeleton, no implementation yet.
25336 Okay, things work fine !
25338 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25340 * typemanager.cs: declare and load enum_type, delegate_type and
25343 * expression.cs (Expression::Emit): Now emit returns a value that
25344 tells whether a value is left on the stack or not. This strategy
25345 might be reveted tomorrow with a mechanism that would address
25346 multiple assignments.
25347 (Expression::report118): Utility routine to report mismatches on
25350 (Unary::Report23): Report impossible type/operator combination
25353 (Unary::IsIncrementableNumber): Whether the type can be
25354 incremented or decremented with add.
25355 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25357 (Unary::ResolveOperator): Implement ++, !, ~,
25359 (Invocation::Emit): Deal with new Emit convetion.
25361 * All Expression derivatives: Updated their Emit method to return
25362 whether they leave values on the stack or not.
25364 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25365 stack for expressions that are statements.
25367 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25369 * expression.cs (LValue): New interface. Must be implemented by
25371 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25374 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25375 interface for generating code, simplifies the code.
25377 2001-09-20 Ravi Pratap <ravi@ximian.com>
25379 * expression.cs (everywhere): Comment out return statements in ::Resolve
25380 methods to avoid the warnings.
25382 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25384 * driver.cs (parse): Report error 2001 if we can not open the
25387 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25390 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25393 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25394 otherwise nested blocks end up with the same index.
25396 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25398 * expression.cs: Instead of having FIXMEs in the Resolve
25399 functions, throw exceptions so it is obvious that we are facing a
25402 * cs-parser.jay (invocation_expression): Pass Location information.
25404 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25405 Use a basename for those routines because .NET does not like paths
25408 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25411 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25413 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25414 are loading the correct data types (throws an exception if not).
25415 (TypeManager::InitCoreTypes): Use CoreLookupType
25417 * expression.cs (Unary::ResolveOperator): return the child
25418 expression for expressions which are just +expr.
25419 (Unary::ResolveOperator): Return negative literals for -LITERAL
25420 expressions (otherwise they are Unary {Literal}).
25421 (Invocation::Badness): Take into account `Implicit constant
25422 expression conversions'.
25424 * literal.cs (LongLiteral): Implement long literal class.
25425 (IntLiteral): export the `Value' of the intliteral.
25427 2001-09-19 Ravi Pratap <ravi@ximian.com>
25429 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25431 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25432 instead of 'Operator'
25434 * expression.cs (Binary::ResolveOperator): Update accordingly.
25435 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25438 * cs-parser.jay (unary_expression): Update to use the new names.
25440 * gen-treedump.cs (GetUnary): Same here.
25442 * expression.cs (Unary::Resolve): Implement.
25443 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25444 operators are found instead of making noise ;-)
25445 (Unary::ResolveOperator): New method to do precisely the same thing which
25446 Binary::ResolveOperator does for Binary expressions.
25447 (Unary.method, .Arguments): Add.
25448 (Unary::OperName): Implement.
25449 (Unary::ForceConversion): Copy and Paste !
25451 * class.cs (Operator::Define): Fix a small bug for the case when we have
25454 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25455 for the inbuilt operators. Only overloading works for now ;-)
25457 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25459 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25460 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25462 * expression.cs (This::Emit): Implement.
25463 (This::Resolve): Implement.
25464 (TypeOf:Resolve): Implement.
25465 (Expression::ResolveSimpleName): Add an implicit this to instance
25467 (MemberAccess::Resolve): Deal with Parameters and Fields.
25468 Bind instance variable to Field expressions.
25469 (FieldExpr::Instance): New field used to track the expression that
25470 represents the object instance.
25471 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25473 (FieldExpr::Emit): Implement.
25475 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25476 the last instruction contains a return opcode to avoid generating
25477 the last `ret' instruction (this generates correct code, and it is
25478 nice to pass the peverify output).
25480 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25481 initializer for static and instance variables.
25482 (Constructor::Emit): Allow initializer to be null in the case of
25483 static constructors. Only emit initializer for instance
25486 (TypeContainer::FindMembers): Return a null array if there are no
25489 Also fix the code for the MemberTypes.Method branch, as it was not
25490 scanning that for operators (or tried to access null variables before).
25492 * assign.cs (Assign::Emit): Handle instance and static fields.
25496 * driver.cs: Stop compilation if there are parse errors.
25498 * cs-parser.jay (constructor_declaration): Provide default base
25499 initializer for non-static constructors.
25500 (constructor_declarator): Do not provide a default base
25501 initializers if none was specified.
25502 Catch the fact that constructors should not have parameters.
25504 * class.cs: Do not emit parent class initializers for static
25505 constructors, that should be flagged as an error.
25507 2001-09-18 Ravi Pratap <ravi@ximian.com>
25509 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25510 Move back code into TypeContainer::Populate.
25512 2001-09-18 Ravi Pratap <ravi@ximian.com>
25514 * class.cs (TypeContainer::AddConstructor): Fix the check to
25515 compare against Name, not Basename.
25516 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25518 * cs-parser.jay : Update accordingly.
25520 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25521 for methods, don't forget to look into the operators too.
25522 (RegisterMethodBuilder): Helper method to take care of this for
25523 methods, constructors and operators.
25524 (Operator::Define): Completely revamp.
25525 (Operator.OperatorMethod, MethodName): New fields.
25526 (TypeContainer::Populate): Move the registering of builders into
25527 RegisterMethodBuilder.
25528 (Operator::Emit): Re-write.
25530 * expression.cs (Binary::Emit): Comment out code path to emit method
25531 invocation stuff for the case when we have a user defined operator. I am
25532 just not able to get it right !
25534 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25536 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25539 (Expression::MemberLookup): Provide a version that allows to
25540 specify the MemberTypes and BindingFlags.
25542 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25543 so it was not fetching variable information from outer blocks.
25545 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25546 Beforefieldinit as it was buggy.
25548 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25549 that Ravi put here.
25551 * class.cs (Constructor::Emit): Only emit if block is not null.
25552 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25553 deal with this by semantically definining it as if the user had
25556 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25557 constructors as we now "emit" them at a higher level.
25559 (TypeContainer::DefineDefaultConstructor): Used to define the
25560 default constructors if none was provided.
25562 (ConstructorInitializer): Add methods Resolve and Emit.
25564 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25566 2001-09-17 Ravi Pratap <ravi@ximian.com>
25568 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25569 the default constructor builder with our hashtable for methodbuilders
25572 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25573 and argument_count is 0 in which case we have a match.
25574 (Binary::ResolveOperator): More null checking and miscellaneous coding
25577 2001-09-17 Ravi Pratap <ravi@ximian.com>
25579 * rootcontext.cs (IsNameSpace): Compare against null.
25581 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25583 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25584 and Unary::Operator.
25586 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25589 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25590 we have overloaded operators.
25591 (Binary::ResolveOperator): Implement the part which does the operator overload
25594 * class.cs (Operator::Emit): Implement.
25595 (TypeContainer::Emit): Emit the operators we have too.
25597 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25598 the case when we have a user-defined operator.
25600 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25602 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
25604 2001-09-16 Ravi Pratap <ravi@ximian.com>
25606 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
25607 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
25608 (Constructor::Emit): Implement.
25609 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
25610 if we have no work to do.
25611 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
25614 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
25615 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
25617 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
25620 2001-09-15 Ravi Pratap <ravi@ximian.com>
25622 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
25624 (Tree::RecordNamespace): Method to do what the name says ;-)
25625 (Tree::Namespaces): Property to get at the namespaces hashtable.
25627 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
25630 * rootcontext.cs (IsNamespace): Fixed it :-)
25632 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25634 * class.cs (TypeContainer::FindMembers): Add support for
25636 (MethodCore): New class that encapsulates both the shared aspects
25637 of a Constructor and a Method.
25638 (Method, Constructor): Factored pieces into MethodCore.
25640 * driver.cs: Added --fatal which makes errors throw exceptions.
25641 Load System assembly as well as part of the standard library.
25643 * report.cs: Allow throwing exceptions on errors for debugging.
25645 * modifiers.cs: Do not use `parent', instead use the real type
25646 container to evaluate permission settings.
25648 * class.cs: Put Ravi's patch back in. He is right, and we will
25649 have to cope with the
25651 2001-09-14 Ravi Pratap <ravi@ximian.com>
25653 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
25654 FamORAssem, not FamANDAssem.
25656 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25658 * driver.cs: Added --parse option that only parses its input files
25661 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
25662 incorrect. IsTopLevel is not used to tell whether an object is
25663 root_types or not (that can be achieved by testing this ==
25664 root_types). But to see if this is a top-level *class* (not
25665 necessarly our "toplevel" container).
25667 2001-09-14 Ravi Pratap <ravi@ximian.com>
25669 * enum.cs (Enum::Define): Modify to call the Lookup method on the
25670 parent instead of a direct call to GetType.
25672 2001-09-14 Ravi Pratap <ravi@ximian.com>
25674 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
25675 Modifiers.TypeAttr. This should just be a call to that method.
25677 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
25678 object so that we can determine if we are top-level or not.
25680 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
25683 * enum.cs (Enum::Define): Ditto.
25685 * modifiers.cs (FieldAttr): Re-write.
25687 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
25688 (TypeContainer::HaveStaticConstructor): New property to provide access
25689 to precisely that info.
25691 * modifiers.cs (MethodAttr): Re-write.
25692 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
25694 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
25695 of top-level types as claimed.
25697 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25699 * expression.cs (MemberLookup): Fruitless attempt to lookup
25700 constructors. Maybe I need to emit default constructors? That
25701 might be it (currently .NET emits this for me automatically).
25702 (Invocation::OverloadResolve): Cope with Arguments == null.
25703 (Invocation::EmitArguments): new function, shared by the new
25704 constructor and us.
25705 (Invocation::Emit): Handle static and instance methods. Emit
25706 proper call instruction for virtual or non-virtual invocations.
25707 (New::Emit): Implement.
25708 (New::Resolve): Implement.
25709 (MemberAccess:Resolve): Implement.
25710 (MethodGroupExpr::InstanceExpression): used conforming to the spec
25711 to track instances.
25712 (FieldExpr::Resolve): Set type.
25714 * support.cs: Handle empty arguments.
25716 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
25717 SimpleLookup): Auxiliary routines to help parse a qualifier
25720 Update qualifier_identifier rule.
25722 * codegen.cs: Removed debugging messages.
25724 * class.cs: Make this a global thing, this acts just as a "key" to
25725 objects that we might have around.
25727 (Populate): Only initialize method_builders_to_methods once.
25729 * expression.cs (PropertyExpr): Initialize type from the
25732 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
25733 Resolve pattern. Attempt to implicitly convert value to boolean.
25736 * expression.cs: Set the type for the int32/int32 argument case.
25737 (Binary::ResolveOperator): Set the return type to boolean for
25738 comparission operators
25740 * typemanager.cs: Remove debugging print code.
25742 (Invocation::Resolve): resolve type.
25744 * class.cs: Allocate a MemberInfo of the correct size, as the code
25745 elsewhere depends on the test to reflect the correct contents.
25747 (Method::) Keep track of parameters, due to System.Reflection holes
25749 (TypeContainer::Populate): Keep track of MethodBuilders to Method
25752 (TypeContainer::FindMembers): Use ArrayList and then copy an array
25753 of the exact size and return that.
25755 (Class::LookupMethodByBuilder): New function that maps
25756 MethodBuilders to its methods. Required to locate the information
25757 on methods because System.Reflection bit us again.
25759 * support.cs: New file, contains an interface ParameterData and
25760 two implementations: ReflectionParameters and InternalParameters
25761 used to access Parameter information. We will need to grow this
25764 * expression.cs (Invocation::GetParameterData): implement a cache
25765 and a wrapper around the ParameterData creation for methods.
25766 (Invocation::OverloadResolve): Use new code.
25768 2001-09-13 Ravi Pratap <ravi@ximian.com>
25770 * class.cs (TypeContainer::EmitField): Remove and move into
25771 (Field::Define): here and modify accordingly.
25772 (Field.FieldBuilder): New member.
25773 (TypeContainer::Populate): Update accordingly.
25774 (TypeContainer::FindMembers): Implement.
25776 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25778 * statement.cs: (VariableInfo::VariableType): New field to be
25779 initialized with the full type once it is resolved.
25781 2001-09-12 Miguel de Icaza <miguel@ximian.com>
25783 * parameter.cs (GetParameterInfo): Use a type cache to compute
25784 things only once, and to reuse this information
25786 * expression.cs (LocalVariableReference::Emit): Implement.
25787 (OpcodeCast::Emit): fix.
25789 (ParameterReference::Resolve): Implement.
25790 (ParameterReference::Emit): Implement.
25792 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
25793 that are expressions need to stay as Expressions.
25795 * typemanager.cs (CSharpName): Returns the C# name of a type if
25798 * expression.cs (Expression::ConvertImplicit): New function that
25799 implements implicit type conversions.
25801 (Expression::ImplicitReferenceConversion): Implements implicit
25802 reference conversions.
25804 (EmptyCast): New type for transparent casts.
25806 (OpcodeCast): New type for casts of types that are performed with
25807 a sequence of bytecodes.
25809 (BoxedCast): New type used for casting value types into reference
25810 types. Emits a box opcode.
25812 (Binary::DoNumericPromotions): Implements numeric promotions of
25813 and computation of the Binary::Type.
25815 (Binary::EmitBranchable): Optimization.
25817 (Binary::Emit): Implement code emission for expressions.
25819 * typemanager.cs (TypeManager): Added two new core types: sbyte
25822 2001-09-12 Ravi Pratap <ravi@ximian.com>
25824 * class.cs (TypeContainer::FindMembers): Method which does exactly
25825 what Type.FindMembers does, only we don't have to use reflection. No
25826 implementation yet.
25828 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
25829 typecontainer objects as we need to get at them.
25830 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
25832 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
25833 typecontainer object.
25835 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
25836 of just a Report object.
25838 2001-09-11 Ravi Pratap <ravi@ximian.com>
25840 * class.cs (Event::Define): Go back to using the prefixes "add_" and
25842 (TypeContainer::Populate): Now define the delegates of the type too.
25843 (TypeContainer.Delegates): Property to access the list of delegates defined
25846 * delegates.cs (Delegate::Define): Implement partially.
25848 * modifiers.cs (TypeAttr): Handle more flags.
25850 2001-09-11 Ravi Pratap <ravi@ximian.com>
25852 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
25854 (Operator::Define): Re-write logic to get types by using the LookupType method
25855 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
25856 (Indexer::Define): Ditto.
25857 (Event::Define): Ditto.
25858 (Property::Define): Ditto.
25860 2001-09-10 Ravi Pratap <ravi@ximian.com>
25862 * class.cs (TypeContainer::Populate): Now define operators too.
25863 (TypeContainer.Operators): New property to access the list of operators
25865 (Operator.OperatorMethodBuilder): New member to hold the method builder
25866 for the operator we are defining.
25867 (Operator::Define): Implement.
25869 2001-09-10 Ravi Pratap <ravi@ximian.com>
25871 * class.cs (Event::Define): Make the prefixes of the accessor methods
25872 addOn_ and removeOn_
25874 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
25875 of the location being passed in too. Ideally, this should go later since all
25876 error reporting should be done through the Report object.
25878 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
25879 (Populate): Iterate thru the indexers we have and define them too.
25880 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
25881 for the get and set accessors.
25882 (Indexer::Define): Implement.
25884 2001-09-09 Miguel de Icaza <miguel@ximian.com>
25886 * expression.cs (Binary::Resolve): Beginning of it. I scratched
25887 my previous implementation, did not work.
25889 * typemanager.cs: Add a couple of missing types (the longs).
25891 * literal.cs: Use TypeManager.bool_type instead of getting it.
25893 * expression.cs (EventExpr): New kind of expressions.
25894 (Expressio::ExprClassFromMemberInfo): finish
25896 2001-09-08 Miguel de Icaza <miguel@ximian.com>
25898 * assign.cs: Emit stores to static fields differently.
25900 2001-09-08 Ravi Pratap <ravi@ximian.com>
25902 * Merge in changes and adjust code to tackle conflicts. Backed out my
25903 code in Assign::Resolve ;-)
25905 2001-09-08 Ravi Pratap <ravi@ximian.com>
25907 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
25908 instead Report.Error and also pass in the location.
25909 (CSharpParser::Lexer): New readonly property to return the reference
25910 to the Tokenizer object.
25911 (declare_local_variables): Use Report.Error with location instead of plain
25915 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
25916 (Operator.CheckBinaryOperator): Ditto.
25918 * cs-parser.jay (operator_declarator): Update accordingly.
25920 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
25921 (CheckBinaryOperator): Same here.
25923 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
25924 on the name without any prefixes of namespace names etc. This is because we
25925 already might have something already fully qualified like
25926 'System.Console.WriteLine'
25928 * assign.cs (Resolve): Begin implementation. Stuck ;-)
25930 2001-09-07 Ravi Pratap <ravi@ximian.com>
25932 * cs-tokenizer.cs (location): Return a string which also contains
25935 * expression.cs (ElementAccess): New class for expressions of the
25936 type 'element access.'
25937 (BaseAccess): New class for expressions of the type 'base access.'
25938 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
25941 * cs-parser.jay (element_access): Implement action.
25942 (base_access): Implement actions.
25943 (checked_expression, unchecked_expression): Implement.
25945 * cs-parser.jay (local_variable_type): Correct and implement.
25946 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
25948 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
25950 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
25951 name and the specifiers.
25953 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
25955 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
25956 making them all public ;-)
25958 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
25961 2001-09-07 Miguel de Icaza <miguel@ximian.com>
25963 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
25965 (FieldExpr, PropertyExprs): New resolved expressions.
25966 (SimpleName::MemberStaticCheck): Perform static checks for access
25967 to non-static fields on static methods. Maybe this should be
25968 generalized for MemberAccesses.
25969 (SimpleName::ResolveSimpleName): More work on simple name
25972 * cs-parser.jay (primary_expression/qualified_identifier): track
25973 the parameter index.
25975 * codegen.cs (CodeGen::Save): Catch save exception, report error.
25976 (EmitContext::EmitBoolExpression): Chain to expression generation
25977 instead of temporary hack.
25978 (::EmitStatementExpression): Put generic expression code generation.
25980 * assign.cs (Assign::Emit): Implement variable assignments to
25981 local variables, parameters and fields.
25983 2001-09-06 Miguel de Icaza <miguel@ximian.com>
25985 * statement.cs (Block::GetVariableInfo): New method, returns the
25986 VariableInfo for a variable name in a block.
25987 (Block::GetVariableType): Implement in terms of GetVariableInfo
25989 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
25990 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
25992 2001-09-06 Ravi Pratap <ravi@ximian.com>
25994 * cs-parser.jay (operator_declaration): Continue on my quest : update
25995 to take attributes argument.
25996 (event_declaration): Ditto.
25997 (enum_declaration): Ditto.
25998 (indexer_declaration): Ditto.
26000 * class.cs (Operator::Operator): Update constructor accordingly.
26001 (Event::Event): Ditto.
26003 * delegate.cs (Delegate::Delegate): Same here.
26005 * enum.cs (Enum::Enum): Same here.
26007 2001-09-05 Ravi Pratap <ravi@ximian.com>
26009 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26011 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26013 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26014 being passed around as an arraylist.
26015 (Attributes::AddAttribute): Method to add attribute sections.
26017 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26018 (struct_declaration): Update accordingly.
26019 (constant_declaration): Update.
26020 (field_declaration): Update.
26021 (method_header): Update.
26022 (fixed_parameter): Update.
26023 (parameter_array): Ditto.
26024 (property_declaration): Ditto.
26025 (destructor_declaration): Ditto.
26027 * class.cs (Struct::Struct): Update constructors accordingly.
26028 (Class::Class): Ditto.
26029 (Field::Field): Ditto.
26030 (Method::Method): Ditto.
26031 (Property::Property): Ditto.
26032 (TypeContainer::OptAttribute): update property's return type.
26034 * interface.cs (Interface.opt_attributes): New member.
26035 (Interface::Interface): Update to take the extra Attributes argument.
26037 * parameter.cs (Parameter::Parameter): Ditto.
26039 * constant.cs (Constant::Constant): Ditto.
26041 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26042 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26043 the attributes as a parameter.
26044 (InterfaceProperty): Update constructor call.
26045 (InterfaceEvent): Ditto.
26046 (InterfaceMethod): Ditto.
26047 (InterfaceIndexer): Ditto.
26049 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26050 pass the attributes too.
26051 (interface_event_declaration): Ditto.
26052 (interface_property_declaration): Ditto.
26053 (interface_method_declaration): Ditto.
26054 (interface_declaration): Ditto.
26056 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26058 * class.cs (Method::Define): Track the "static Main" definition to
26059 create an entry point.
26061 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26062 EntryPoint if we find it.
26064 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26065 (EmitContext::ig): Make this variable public.
26067 * driver.cs: Make the default output file be the first file name
26068 with the .exe extension.
26070 Detect empty compilations
26072 Handle various kinds of output targets. Handle --target and
26073 rename -t to --dumper.
26075 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26076 methods inherited from Expression return now an Expression. This
26077 will is used during the tree rewriting as we resolve them during
26080 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26081 the spec. Missing entirely is the information about
26082 accessability of elements of it.
26084 (Expression::ExprClassFromMemberInfo): New constructor for
26085 Expressions that creates a fully initialized Expression based on
26086 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26089 (Invocation::Resolve): Begin implementing resolution of invocations.
26091 * literal.cs (StringLiteral): Implement Emit.
26093 2001-09-05 Ravi Pratap <ravi@ximian.com>
26095 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26098 2001-09-04 Ravi Pratap <ravi@ximian.com>
26100 * cs-parser.jay (attribute_arguments): Implement actions.
26101 (attribute): Fix bug in production. Implement action.
26102 (attribute_list): Implement.
26103 (attribute_target): Implement.
26104 (attribute_target_specifier, opt_target_specifier): Implement
26105 (CheckAttributeTarget): New method to check if the attribute target
26107 (attribute_section): Implement.
26108 (opt_attributes): Implement.
26110 * attribute.cs : New file to handle attributes.
26111 (Attribute): Class to hold attribute info.
26113 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26114 (attribute_section): Modify production to use 2 different rules to
26115 achieve the same thing. 1 s/r conflict down !
26116 Clean out commented, useless, non-reducing dimension_separator rules.
26118 * class.cs (TypeContainer.attributes): New member to hold list
26119 of attributes for a type.
26120 (Struct::Struct): Modify to take one more argument, the attribute list.
26121 (Class::Class): Ditto.
26122 (Field::Field): Ditto.
26123 (Method::Method): Ditto.
26124 (Property::Property): Ditto.
26126 * cs-parser.jay (struct_declaration): Update constructor call to
26127 pass in the attributes too.
26128 (class_declaration): Ditto.
26129 (constant_declaration): Ditto.
26130 (field_declaration): Ditto.
26131 (method_header): Ditto.
26132 (fixed_parameter): Ditto.
26133 (parameter_array): Ditto.
26134 (property_declaration): Ditto.
26136 * constant.cs (Constant::Constant): Update constructor similarly.
26137 Use System.Collections.
26139 * parameter.cs (Parameter::Parameter): Update as above.
26141 2001-09-02 Ravi Pratap <ravi@ximian.com>
26143 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26144 (TypeContainer.delegates): New member to hold list of delegates.
26146 * cs-parser.jay (delegate_declaration): Implement the action correctly
26147 this time as I seem to be on crack ;-)
26149 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26151 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26152 tell whether an identifier represents a namespace.
26154 * expression.cs (NamespaceExpr): A namespace expression, used only
26155 temporarly during expression resolution.
26156 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26157 utility functions to resolve names on expressions.
26159 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26161 * codegen.cs: Add hook for StatementExpressions.
26163 * class.cs: Fix inverted test for static flag in methods.
26165 2001-09-02 Ravi Pratap <ravi@ximian.com>
26167 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26168 to make it coincide with MS' number.
26169 (Operator::CheckBinaryOperator): Ditto.
26171 * ../errors/errors.txt : Remove error numbers added earlier.
26173 * ../errors/cs1019.cs : Test case for error # 1019
26175 * ../errros/cs1020.cs : Test case for error # 1020
26177 * cs-parser.jay : Clean out commented cruft.
26178 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26179 used anywhere - non-reducing rule.
26180 (namespace_declarations): Non-reducing rule - comment out.
26182 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26183 with TypeContainer::AddEnum.
26185 * delegate.cs : New file for delegate handling classes.
26186 (Delegate): Class for declaring delegates.
26188 * makefile : Update.
26190 * cs-parser.jay (delegate_declaration): Implement.
26192 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26194 * class.cs (Event::Define): Implement.
26195 (Event.EventBuilder): New member.
26197 * class.cs (TypeContainer::Populate): Update to define all enums and events
26199 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26200 readonly fields for all these cases ?
26202 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26204 * class.cs (Property): Revamp to use the convention of making fields readonly.
26205 Accordingly modify code elsewhere.
26207 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26208 the Define method of the Property class.
26210 * class.cs : Clean up applied patch and update references to variables etc. Fix
26212 (TypeContainer::Populate): Update to define all the properties we have. Also
26213 define all enumerations.
26215 * enum.cs (Define): Implement.
26217 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26219 * cs-parser.jay (overloadable_operator): The semantic value is an
26220 enum of the Operator class.
26221 (operator_declarator): Implement actions.
26222 (operator_declaration): Implement.
26224 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26225 validity of definitions.
26226 (Operator::CheckBinaryOperator): Static method to check for binary operators
26227 (TypeContainer::AddOperator): New method to add an operator to a type.
26229 * cs-parser.jay (indexer_declaration): Added line to actually call the
26230 AddIndexer method so it gets added ;-)
26232 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26233 already taken care of by the MS compiler ?
26235 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26237 * class.cs (Operator): New class for operator declarations.
26238 (Operator::OpType): Enum for the various operators.
26240 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26242 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26243 ostensibly handle this in semantic analysis.
26245 * cs-parser.jay (general_catch_clause): Comment out
26246 (specific_catch_clauses, specific_catch_clause): Ditto.
26247 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26248 (catch_args, opt_catch_args): New productions.
26249 (catch_clause): Rewrite to use the new productions above
26250 (catch_clauses): Modify accordingly.
26251 (opt_catch_clauses): New production to use in try_statement
26252 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26253 and re-write the code in the actions to extract the specific and
26254 general catch clauses by being a little smart ;-)
26256 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26257 Hooray, try and catch statements parse fine !
26259 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26261 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26262 string from the hashtable of variables.
26264 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26265 I end up making that mistake ;-)
26266 (catch_clauses): Fixed gross error which made Key and Value of the
26267 DictionaryEntry the same : $1 !!
26269 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26271 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26273 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26274 when the add and remove accessors are specified.
26276 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26278 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26279 information about indexer_declarator.
26280 (indexer_declarator): Implement actions.
26281 (parsing_indexer): New local boolean used to keep track of whether
26282 we are parsing indexers or properties. This is necessary because
26283 implicit_parameters come into picture even for the get accessor in the
26284 case of an indexer.
26285 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26287 * class.cs (Indexer): New class for indexer declarations.
26288 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26289 (TypeContainer::indexers): New member to hold list of indexers for the
26292 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26294 * cs-parser.jay (add_accessor_declaration): Implement action.
26295 (remove_accessor_declaration): Implement action.
26296 (event_accessors_declaration): Implement
26297 (variable_declarators): swap statements for first rule - trivial.
26299 * class.cs (Event): New class to hold information about event
26301 (TypeContainer::AddEvent): New method to add an event to a type
26302 (TypeContainer::events): New member to hold list of events.
26304 * cs-parser.jay (event_declaration): Implement actions.
26306 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26308 * cs-parser.jay (dim_separators): Implement. Make it a string
26309 concatenating all the commas together, just as they appear.
26310 (opt_dim_separators): Modify accordingly
26311 (rank_specifiers): Update accordingly. Basically do the same
26312 thing - instead, collect the brackets here.
26313 (opt_rank_sepcifiers): Modify accordingly.
26314 (array_type): Modify to actually return the complete type string
26315 instead of ignoring the rank_specifiers.
26316 (expression_list): Implement to collect the expressions
26317 (variable_initializer): Implement. We make it a list of expressions
26318 essentially so that we can handle the array_initializer case neatly too.
26319 (variable_initializer_list): Implement.
26320 (array_initializer): Make it a list of variable_initializers
26321 (opt_array_initializer): Modify accordingly.
26323 * expression.cs (New::NType): Add enumeration to help us
26324 keep track of whether we have an object/delegate creation
26325 or an array creation.
26326 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26327 members to hold data about array creation.
26328 (New:New): Modify to update NewType
26329 (New:New): New Overloaded contructor for the array creation
26332 * cs-parser.jay (array_creation_expression): Implement to call
26333 the overloaded New constructor.
26335 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26337 * class.cs (TypeContainer::Constructors): Return member
26338 constructors instead of returning null.
26340 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26342 * typemanager.cs (InitCoreTypes): Initialize the various core
26343 types after we have populated the type manager with the user
26344 defined types (this distinction will be important later while
26345 compiling corlib.dll)
26347 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26348 on Expression Classification. Now all expressions have a method
26349 `Resolve' and a method `Emit'.
26351 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26352 generation from working. Also add some temporary debugging
26355 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26357 * codegen.cs: Lots of code generation pieces. This is only the
26358 beginning, will continue tomorrow with more touches of polish. We
26359 handle the fundamentals of if, while, do, for, return. Others are
26360 trickier and I need to start working on invocations soon.
26362 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26365 * codegen.cs (EmitContext): New struct, used during code
26366 emission to keep a context. Most of the code generation will be
26369 * cs-parser.jay: Add embedded blocks to the list of statements of
26370 this block. So code generation proceeds in a top down fashion.
26372 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26374 * statement.cs: Add support for multiple child blocks.
26376 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26378 * codegen.cs (EmitCode): New function, will emit the code for a
26379 Block of code given a TypeContainer and its ILGenerator.
26381 * statement.cs (Block): Standard public readonly optimization.
26382 (Block::Block constructors): Link children.
26383 (Block::Child): Child Linker.
26384 (Block::EmitVariables): Emits IL variable declarations.
26386 * class.cs: Drop support for MethodGroups here, delay until
26388 (Method::): Applied the same simplification that I did before, and
26389 move from Properties to public readonly fields.
26390 (Method::ParameterTypes): Returns the parameter types for the
26391 function, and implements a cache that will be useful later when I
26392 do error checking and the semantic analysis on the methods is
26394 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26395 and made a method, optional argument tells whether this is a class
26396 or a structure to apply the `has-this' bit.
26397 (Method::GetCallingConvention): Implement, returns the calling
26399 (Method::Define): Defines the type, a second pass is performed
26400 later to populate the methods.
26402 (Constructor::ParameterTypes): implement a cache similar to the
26403 one on Method::ParameterTypes, useful later when we do semantic
26406 (TypeContainer::EmitMethod): New method. Emits methods.
26408 * expression.cs: Removed MethodGroup class from here.
26410 * parameter.cs (Parameters::GetCallingConvention): new method.
26412 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26414 * class.cs (TypeContainer::Populate): Drop RootContext from the
26417 (Constructor::CallingConvention): Returns the calling convention.
26418 (Constructor::ParameterTypes): Returns the constructor parameter
26421 (TypeContainer::AddConstructor): Keep track of default constructor
26422 and the default static constructor.
26424 (Constructor::) Another class that starts using `public readonly'
26425 instead of properties.
26427 (Constructor::IsDefault): Whether this is a default constructor.
26429 (Field::) use readonly public fields instead of properties also.
26431 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26432 track of static constructors; If none is used, turn on
26433 BeforeFieldInit in the TypeAttributes.
26435 * cs-parser.jay (opt_argument_list): now the return can be null
26436 for the cases where there are no arguments.
26438 (constructor_declarator): If there is no implicit `base' or
26439 `this', then invoke the default parent constructor.
26441 * modifiers.cs (MethodAttr): New static function maps a set of
26442 modifiers flags into a MethodAttributes enum
26443 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26444 MethodAttr, TypeAttr to represent the various mappings where the
26445 modifiers are used.
26446 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26448 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26450 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26453 * interface.cs (PopulateIndexer): Implemented the code generator
26454 for interface indexers.
26456 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26458 * interface.cs (InterfaceMemberBase): Now we track the new status
26461 (PopulateProperty): Implement property population. Woohoo! Got
26462 Methods and Properties going today.
26464 Removed all the properties for interfaces, and replaced them with
26465 `public readonly' fields.
26467 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26469 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26470 initialize their hashtables/arraylists only when they are needed
26471 instead of doing this always.
26473 * parameter.cs: Handle refs and out parameters.
26475 * cs-parser.jay: Use an ArrayList to construct the arguments
26476 instead of the ParameterCollection, and then cast that to a
26479 * parameter.cs: Drop the use of ParameterCollection and use
26480 instead arrays of Parameters.
26482 (GetParameterInfo): Use the Type, not the Name when resolving
26485 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26487 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26488 and instead use public readonly fields.
26490 * class.cs: Put back walking code for type containers.
26492 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26494 * class.cs (MakeConstant): Code to define constants.
26496 * rootcontext.cs (LookupType): New function. Used to locate types
26499 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26501 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26502 this System.Reflection code is. Kudos to Microsoft
26504 * typemanager.cs: Implement a type cache and avoid loading all
26505 types at boot time. Wrap in LookupType the internals. This made
26506 the compiler so much faster. Wow. I rule!
26508 * driver.cs: Make sure we always load mscorlib first (for
26509 debugging purposes, nothing really important).
26511 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26512 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26514 * rootcontext.cs: Lookup types on their namespace; Lookup types
26515 on namespaces that have been imported using the `using' keyword.
26517 * class.cs (TypeContainer::TypeAttr): Virtualize.
26518 (Class::TypeAttr): Return attributes suitable for this bad boy.
26519 (Struct::TypeAttr): ditto.
26520 Handle nested classes.
26521 (TypeContainer::) Remove all the type visiting code, it is now
26522 replaced with the rootcontext.cs code
26524 * rootcontext.cs (GetClassBases): Added support for structs.
26526 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26528 * interface.cs, statement.cs, class.cs, parameter.cs,
26529 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26530 Drop use of TypeRefs, and use strings instead.
26532 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26536 * class.cs (Struct::Struct): set the SEALED flags after
26537 checking the modifiers.
26538 (TypeContainer::TypeAttr): new property, returns the
26539 TypeAttributes for a class.
26541 * cs-parser.jay (type_list): Oops, list production was creating a
26542 new list of base types.
26544 * rootcontext.cs (StdLib): New property.
26545 (GetInterfaceTypeByName): returns an interface by type name, and
26546 encapsulates error handling here.
26547 (GetInterfaces): simplified.
26548 (ResolveTree): Encapsulated all the tree resolution here.
26549 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26552 * driver.cs: Add support for --nostdlib, to avoid loading the
26553 default assemblies.
26554 (Main): Do not put tree resolution here.
26556 * rootcontext.cs: Beginning of the class resolution.
26558 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26560 * rootcontext.cs: Provide better error reporting.
26562 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26564 * rootcontext.cs (CreateInterface): Handle the case where there
26565 are no parent interfaces.
26567 (CloseTypes): Routine to flush types at the end.
26568 (CreateInterface): Track types.
26569 (GetInterfaces): Returns an array of Types from the list of
26570 defined interfaces.
26572 * typemanager.c (AddUserType): Mechanism to track user types (puts
26573 the type on the global type hash, and allows us to close it at the
26576 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26578 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26579 RecordInterface instead.
26581 * cs-parser.jay: Updated to reflect changes above.
26583 * decl.cs (Definition): Keep track of the TypeBuilder type that
26584 represents this type here. Not sure we will use it in the long
26585 run, but wont hurt for now.
26587 * driver.cs: Smaller changes to accomodate the new code.
26589 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26592 * rootcontext.cs (CreateInterface): New method, used to create
26593 the System.TypeBuilder type for interfaces.
26594 (ResolveInterfaces): new entry point to resolve the interface
26596 (CodeGen): Property, used to keep track of the code generator.
26598 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26600 * cs-parser.jay: Add a second production for delegate_declaration
26603 (enum_body): Put an opt_comma here instead of putting it on
26604 enum_body or enum_member_declarations so we can handle trailing
26605 commas on enumeration members. Gets rid of a shift/reduce.
26607 (type_list): Need a COMMA in the middle.
26609 (indexer_declaration): Tell tokenizer to recognize get/set
26611 * Remove old targets.
26613 * Re-add the parser target.
26615 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26617 * cs-parser.jay: Add precendence rules for a number of operators
26618 ot reduce the number of shift/reduce conflicts in the grammar.
26620 2001-07-17 Miguel de Icaza <miguel@ximian.com>
26622 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
26625 Get rid of old crufty code.
26627 * rootcontext.cs: Use this to keep track of the parsed
26628 representation and the defined types available to the program.
26630 * gen-treedump.cs: adjust for new convention.
26632 * type.cs: Split out the type manager, and the assembly builder
26635 * typemanager.cs: the type manager will live here now.
26637 * cil-codegen.cs: And the code generator here.
26639 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
26641 * makefile: Fixed up for easy making.
26643 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26645 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
26648 (unary_expression): Expand pre_increment_expression and
26649 post_decrement_expression to reduce a shift/reduce.
26651 2001-07-11 Simon Cozens
26653 * cs-tokenizer.cs: Hex numbers should begin with a 0.
26655 Improve allow_keyword_as_indent name.
26657 2001-06-19 Miguel de Icaza <miguel@ximian.com>
26659 * Adjustments for Beta2.
26661 2001-06-13 Miguel de Icaza <miguel@ximian.com>
26663 * decl.cs: Added `Define' abstract method.
26664 (InTransit): new property, used to catch recursive definitions.
26666 * interface.cs: Implement `Define'.
26668 * modifiers.cs: Map Modifiers.constants to
26669 System.Reflection.TypeAttribute flags.
26671 * class.cs: Keep track of types and user-defined types.
26672 (BuilderInit): New method for creating an assembly
26673 (ResolveType): New function to launch the resolution process, only
26674 used by interfaces for now.
26676 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
26677 that are inserted into the name space.
26679 2001-06-08 Miguel de Icaza <miguel@ximian.com>
26681 * ARGH. I have screwed up my tree so many times due to the use of
26682 rsync rather than using CVS. Going to fix this at once.
26684 * driver.cs: Objetify driver. Load assemblies, use assemblies to
26687 2001-06-07 Miguel de Icaza <miguel@ximian.com>
26689 * Experiment successful: Use System.Type rather that our own
26692 2001-05-25 Miguel de Icaza <miguel@ximian.com>
26694 * cs-parser.jay: Removed nsAliases from here.
26696 Use new namespaces, handle `using XXX;'
26698 * namespace.cs: Reimplemented namespace handling, use a recursive
26699 definition of the class. Now we can keep track of using clauses
26700 and catch invalid using clauses.
26702 2001-05-24 Miguel de Icaza <miguel@ximian.com>
26704 * gen-treedump.cs: Adapted for all the renaming.
26706 * expression.cs (Expression): this class now has a Type property
26707 which returns an expression Type.
26709 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
26710 `Type', as this has a different meaning now in the base
26712 2001-05-22 Miguel de Icaza <miguel@ximian.com>
26714 * interface.cs, class.cs: Removed from all the sources the
26715 references to signature computation, as we can not do method
26716 signature computation during the parsing time, as we are not
26717 trying to solve at that point distinguishing:
26721 void a (NS.Blah x) {}
26724 Which depending on the context might be valid or not, as we do not
26725 know if Blah is the same thing as NS.Blah at that point.
26727 * Redid everything so the code uses TypeRefs now instead of
26728 Types. TypeRefs are just temporary type placeholders, that need
26729 to be resolved. They initially have a pointer to a string and the
26730 current scope in which they are used. This is used later by the
26731 compiler to resolve the reference to an actual Type.
26733 * DeclSpace is no longer a CIR.Type, and neither are
26734 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
26735 are all DeclSpaces, but no Types.
26737 * type.cs (TypeRefManager): This implements the TypeRef manager,
26738 which keeps track of all the types that need to be resolved after
26739 the parsing has finished.
26741 2001-05-13 Miguel de Icaza <miguel@ximian.com>
26743 * ARGH. We are going to have to store `foreach' as a class rather
26744 than resolving it, as we need to verify error 1579 after name
26745 resolution. *OR* we could keep a flag that says `This request to
26746 IEnumerator comes from a foreach statement' which we can then use
26747 to generate the error.
26749 2001-05-10 Miguel de Icaza <miguel@ximian.com>
26751 * class.cs (TypeContainer.AddMethod): we now add methods to the
26752 MethodGroup instead of the method hashtable.
26754 * expression.cs: Add MethodGroup abstraction, which gets us one
26755 step closer to the specification in the way we handle method
26758 * cs-parser.jay (primary_expression): qualified_identifier now
26759 tried to match up an identifier to a local variable reference or
26760 to a parameter reference.
26762 current_local_parameters is now a parser global variable that
26763 points to the current parameters for the block, used during name
26766 (property_declaration): Now creates an implicit `value' argument to
26769 2001-05-09 Miguel de Icaza <miguel@ximian.com>
26771 * parameter.cs: Do not use `param' arguments as part of the
26772 signature, per the spec.
26774 2001-05-08 Miguel de Icaza <miguel@ximian.com>
26776 * decl.cs: Base class for classes, structs and interfaces. This
26777 is the "Declaration Space"
26779 * cs-parser.jay: Use CheckDef for checking declaration errors
26780 instead of having one on each function.
26782 * class.cs: Factor out some code for handling error handling in
26783 accordance to the "Declarations" section in the "Basic Concepts"
26784 chapter in the ECMA C# spec.
26786 * interface.cs: Make all interface member classes derive from
26787 InterfaceMemberBase.
26789 2001-05-07 Miguel de Icaza <miguel@ximian.com>
26791 * Many things: all interfaces are parsed and generated in
26792 gen-treedump. Support for member variables, constructors,
26793 destructors, properties, constants is there.
26795 Beginning of the IL backend, but very little done, just there for
26798 2001-04-29 Miguel de Icaza <miguel@ximian.com>
26800 * cs-parser.jay: Fix labeled statement.
26802 * cs-tokenizer.cs (escape): Escape " and ' always.
26803 ref_line, ref_name: keep track of the line/filename as instructed
26804 by #line by the compiler.
26807 2001-04-27 Miguel de Icaza <miguel@ximian.com>
26809 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
26810 to match the values in System.CodeDOM.
26812 Divid renamed to Divide.
26814 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
26816 (Statements.set): remove.
26818 * System.CodeDOM/CodeCatchClause.cs: always have a valid
26821 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
26822 falseStatements always have valid values.
26824 * cs-parser.jay: Use System.CodeDOM now.