1 2004-12-04 Martin Baulig <martin@ximian.com>
3 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
4 to check whether the conversion is ok.
6 * typemanager.cs (TypeManager.GetTypeArguments): Just return
7 `Type.EmptyTypes' if we're not a generic TypeContainer.
9 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
12 old bug: when converting from the null literal to a pointer,
13 return an EmptyCast, not the NullLiteral.
15 This fixes #69921, the recent null_type changes probably made this
18 2004-12-03 Martin Baulig <martin@ximian.com>
20 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
21 method as our child, call AnonymousMethod.Compatible() on it.
23 2004-12-02 Miguel de Icaza <miguel@ximian.com>
25 * class.cs (FieldBase): Use an unused bit field from the field to
26 encode the `has_offset' property from the FieldMember. This saves
27 a couple of Ks on bootstrap compilation.
29 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
30 method as our child, return the AnonymousMethod resolved
33 * expression.cs (New.DoResolve): Allow return values from
34 NewDelegate to also include AnonymousMethods.
38 2004-11-29 Raja R Harinath <rharinath@novell.com>
40 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
42 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
43 System.Runtime.InteropServices._Exception, since it's a base
44 interface of the core type System.Exception in the net_2_0 profile.
46 2004-11-27 Martin Baulig <martin@ximian.com>
48 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
50 2004-11-26 Raja R Harinath <rharinath@novell.com>
52 * Makefile: Convert to use executable.make.
53 * gmcs.exe.sources: New.
55 2004-11-25 Martin Baulig <martin@ximian.com>
57 * expression.cs (Invocation.InferType): Added support for byref types.
59 2004-11-25 Martin Baulig <martin@ximian.com>
61 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
62 in TypeManager.TypeToCoreType().
64 2004-11-25 Martin Baulig <martin@ximian.com>
66 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
67 "Dispose" method from the `current_type'.
68 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
69 DoDefineMembers() instead of using the MethodBuilder; this is
70 required for generic iterators.
72 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
74 2004-11-24 Martin Baulig <martin@ximian.com>
76 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
78 2004-11-20 Martin Baulig <martin@ximian.com>
80 * expression.cs (Invocation.InferType): Correctly infer generic
81 instances; see gen-103.cs.
82 (Invocation.InferTypeArguments): If a generic method doesn't have
83 any unbound type parameters, we don't need to infer anything.
85 2004-11-19 Raja R Harinath <rharinath@novell.com>
87 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
89 2004-11-17 Raja R Harinath <rharinath@novell.com>
91 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
92 (TypeHandle.GetMemberCache): New.
93 (TypeHandle.TypeHandle): Update.
94 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
95 (TypeManager.LookupParentInterfacesCache):
96 Rename from LookupInterfaceCache. Optimize slightly.
97 (TypeManager.MemberLookup_FindMembers): Update.
98 * decl.cs (MemberCache.MemberCache): Set Container to null in the
100 (AddCacheContents): Rename from AddHashtable.
101 * class.cs (TypeContainer.parent_container): Remove.
102 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
103 (TypeContainer.DoDefineMembers): Don't initialize it.
104 Update to name changes.
106 2004-11-17 Miguel de Icaza <miguel@ximian.com>
108 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
109 that factors the code to check access modifiers on override.
111 (PropertyBase): Use the code here.
113 Patch from Lluis S'anchez, fixes bug #69361.
115 2004-11-15 Miguel de Icaza <miguel@ximian.com>
117 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
118 routine that is used to report the use of a captured variable
119 whose address has been taken.
121 There are two checks: one when variables are being captured and
122 the other check is when the address of a variable is taken.
124 (because an anonymous methods might be resolved before *or* after
125 the address has been taken) and
127 * expression.cs (Conditional.DoResolve): Remove the special
128 casing that Martin added to trueExpr and falseExpr being both
129 NullLiteral. We get the right behavior now just by introducing
130 the null_type into the compiler.
132 * convert.cs (ExplicitConversion): Change the code to use
133 null_type instead of testing `expr is NullLiteral'.
134 (ImplicitConversionStandard): use null_type too.
135 (ImplicitReferenceConversionExists): use null_type too.
136 (ImplicitReferenceConversion): use null_type too.
138 * literal.cs: The type of `NullLiteral' is now null_type instead
140 (Resolve): Set the type here.
142 * typemanager.cs: Introduce null_type.
144 2004-11-18 Martin Baulig <martin@ximian.com>
147 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
149 2004-11-18 Martin Baulig <martin@ximian.com>
151 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
153 2004-11-18 Martin Baulig <martin@ximian.com>
155 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
156 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
157 call ResolveConstructedType() on it to resolve it without checking
159 (Constraints.ResolveTypes): Check them here.
160 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
161 but don't check constraints.
162 (ConstructedType.ResolveAsTypeTerminal): Override this and also
163 check constraints here.
164 (ConstructedType.ResolveConstructedType): New public method. This
165 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
166 resolve ourselves without checking constraints.
168 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
170 2004-11-18 Martin Baulig <martin@ximian.com>
173 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
175 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
177 2004-11-18 Martin Baulig <martin@ximian.com>
179 * ecore.cs (TypeExpr.ResolveType): Removed.
180 (Expression.ResolveAsTypeTerminal): We always return a fully
181 resolved `TypeExpr', so we can just access its `Type'.
183 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
185 2004-11-17 Martin Baulig <martin@ximian.com>
187 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
188 sure we don't return any unresolved TypeExpr's.
189 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
191 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
193 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
194 unresolved `ConstructedType's.
196 2004-11-17 Martin Baulig <martin@ximian.com>
198 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
200 2004-11-17 Martin Baulig <martin@ximian.com>
203 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
205 * decl.cs (DeclSpace.ResolveType): Removed.
206 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
208 2004-11-17 Martin Baulig <martin@ximian.com>
210 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
211 direction, like FindMembers() does. Fixes #69546, testcase is in
214 2004-11-16 Martin Baulig <martin@ximian.com>
216 This is based on a patch from Marek Safar, see bug #69082.
217 Fixes bugs #63705 and #67130.
219 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
220 method; create a MemberCache for an interface type and cache the
223 * decl.cs (IMemberContainer.ParentContainer): Removed.
224 (IMemberContainer.ParentCache): New property.
225 (MemberCache.SetupCacheForInterface): Removed.
226 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
227 to create a cache for an interface's "parent".
229 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
232 2004-11-14 Ben Maurer <bmaurer@ximian.com>
234 * statement.cs: Avoid adding bools to a hashtable.
236 2004-11-15 Martin Baulig <martin@ximian.com>
238 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
240 2004-11-11 Martin Baulig <martin@ximian.com>
242 * typemanager.cs (TypeManager.GetMethodName): New method.
244 * class.cs (MethodData.Define): Include the generic arity in the
245 name of an explicit interface; also add it to the method name.
247 * pending.cs (PendingImplementation.InterfaceMethod): The method
248 name now includes the generic arity.
250 2004-11-07 Miguel de Icaza <miguel@ximian.com>
252 * expression.cs (Invocation.OverloadResolve): Flag error if we are
253 calling an unsafe method from a safe location.
255 2004-11-06 Marek Safar <marek.safar@seznam.cz>
258 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
260 2004-11-06 Miguel de Icaza <miguel@ximian.com>
262 * namespace.cs (VerifyUsing): use GetPartialName instead of
265 2004-11-05 Miguel de Icaza <miguel@ximian.com>
267 * statement.cs (Return.Resolve): Fix regression in typo: if
268 `in_exc', we have to request a NeedReturnLabel, this was a typo
269 introduced in the anonymous method check-in. Fixes #69131.
271 * Indexers were using the ShortName when defining themselves,
272 causing a regression in the compiler bootstrap when applying the
273 patch from 2004-11-02 (first part), now they use their full name
276 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
278 * driver.cs: Strip the path from the names of embedded resources. Fixes
281 2004-11-04 Raja R Harinath <rharinath@novell.com>
283 Fix error message regression: cs0104-2.cs.
284 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
285 (AliasEntry.Resolve): Update.
286 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
288 (RootContext.LookupType): Update.
290 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
292 * cs-parser.jay: Add support for handling accessor modifiers
293 * class: Add support port accessor modifiers and error checking,
294 define PropertyMethod.Define as virtual (not abstract anymore)
295 * ecore.cs: Add checking for proeprties access with access modifiers
296 * iterators.cs: Modify Accessor constructor call based in the modified
298 2004-11-02 Ben Maurer <bmaurer@ximian.com>
300 * expression.cs (StringConcat): Handle being called twice,
301 as when we have a concat in a field init with more than two
304 2004-11-02 Miguel de Icaza <miguel@ximian.com>
306 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
307 special case explicit implementations, we should always produce
308 the .property or .event declaration.
310 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
311 since it will not return correct data if people use this
312 unresolved in the presence of using statements (see test-313).
314 * class.cs (MethodData.Define): If we are an explicit interface
315 implementation, set the method name to the full name of the
316 interface plus the name of the method.
318 Notice that using the method.MethodName.GetFullName() does not
319 work, as it will only contain the name as declared on the source
320 file (it can be a shorthand in the presence of using statements)
321 and not the fully qualifed type name, for example:
325 class D : ICloneable {
326 object ICloneable.Clone () {
330 Would produce a method called `ICloneable.Clone' instead of
331 `System.ICloneable.Clone'.
333 * namespace.cs (Alias.Resolve): Use GetPartialName.
335 2004-11-01 Marek Safar <marek.safar@seznam.cz>
337 * cs-parser.jay: Add error 1055 report.
339 2004-11-01 Miguel de Icaza <miguel@ximian.com>
341 * assign.cs (Assign.DoResolve): Only do the transform of
342 assignment into a New if the types are compatible, if not, fall
343 through and let the implicit code deal with the errors and with
344 the necessary conversions.
346 2004-11-01 Marek Safar <marek.safar@seznam.cz>
348 * cs-parser.jay: Add error 1031 report.
350 * cs-tokenizer.cs: Add location for error 1038.
352 2004-10-31 Marek Safar <marek.safar@seznam.cz>
354 * cs-parser.jay: Add error 1016 report.
356 2004-10-31 Marek Safar <marek.safar@seznam.cz>
358 * cs-parser.jay: Add errors 1575,1611 report.
360 2004-10-31 Marek Safar <marek.safar@seznam.cz>
362 * cs-parser.jay: Add error 1001 report.
364 2004-10-31 Marek Safar <marek.safar@seznam.cz>
367 * attribute.cs (GetMarshal): Add method argument for
368 caller identification.
370 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
371 agument for GetMarshal and RuntimeMissingSupport.
373 2004-10-31 Marek Safar <marek.safar@seznam.cz>
375 * attribute.cs (ExtractSecurityPermissionSet): Removed
376 TypeManager.code_access_permission_type.
378 * typemanager.cs: Removed TypeManager.code_access_permission_type.
380 2004-10-27 Miguel de Icaza <miguel@ximian.com>
382 * expression.cs (LocalVariableReference.DoResolveLValue): Check
383 for obsolete use of a variable here. Fixes regression on errors
384 cs0619-25 and cs0619-26.
386 2004-10-27 Marek Safar <marek.safar@seznam.cz>
388 Fix #62358, implemented security attribute encoding.
390 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
391 Tests permitted SecurityAction for assembly or other types.
392 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
393 data from SecurityPermissionAttribute to PermisionSet class.
395 * class.cs (ApplyAttributeBuilder): Added special handling
396 for System.Security.Permissions.SecurityAttribute based types.
398 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
399 special handling for System.Security.Permissions.SecurityAttribute
402 * enum.cs (ApplyAttributeBuilder): Added special handling
403 for System.Security.Permissions.SecurityAttribute based types.
405 * parameter.cs (ApplyAttributeBuilder): Added special handling
406 for System.Security.Permissions.SecurityAttribute based types.
408 * rootcontext.cs: Next 2 core types.
410 * typemanager.cs (TypeManager.security_permission_attr_type):
411 Built in type for the SecurityPermission Attribute.
412 (code_access_permission_type): Build in type.
414 2004-10-17 Miguel de Icaza <miguel@ximian.com>
416 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
417 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
418 all of this information into
419 EmitContext.EmitCapturedVariableInstance.
421 * codegen.cs (EmitCapturedVariableInstance): move here the
422 funcionality of emitting an ldarg.0 in the presence of a
423 remapping. This centralizes the instance emit code.
425 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
426 then emit a load of this: it means that we have reached the
427 topmost ScopeInfo: the one that contains the pointer to the
428 instance of the class hosting the anonymous method.
430 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
431 captures to the topmost CaptureContext.
433 2004-10-12 Miguel de Icaza <miguel@ximian.com>
435 * expression.cs (LocalVariableReference): Move the knowledge about
436 the iterators into codegen's EmitCapturedVariableInstance.
438 2004-10-11 Miguel de Icaza <miguel@ximian.com>
440 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
441 all code paths return a value from an anonymous method (it is the
442 same as the 161 error, but for anonymous methods).
444 2004-10-08 Miguel de Icaza <miguel@ximian.com>
446 The introduction of anonymous methods in the compiler changed
447 various ways of doing things in the compiler. The most
448 significant one is the hard split between the resolution phase
449 and the emission phases of the compiler.
451 For instance, routines that referenced local variables no
452 longer can safely create temporary variables during the
453 resolution phase: they must do so from the emission phase,
454 since the variable might have been "captured", hence access to
455 it can not be done with the local-variable operations from the runtime.
459 (Block.Flags): New flag `IsTopLevel' to indicate that this block
462 (ToplevelBlock): A new kind of Block, these are the blocks that
463 are created by the parser for all toplevel method bodies. These
464 include methods, accessors and anonymous methods.
466 These contain some extra information not found in regular blocks:
467 A pointer to an optional CaptureContext (for tracking captured
468 local variables and parameters). A pointer to the parent
471 (Return.Resolve): Catch missmatches when returning a value from an
472 anonymous method (error 1662).
473 Invoke NeedReturnLabel from the Resolve phase instead of the emit
476 (Break.Resolve): ditto.
478 (SwitchLabel): instead of defining the labels during the
479 resolution phase, we now turned the public ILLabel and ILLabelCode
480 labels into methods called GetILLabelCode() and GetILLabel() that
481 only define the label during the Emit phase.
483 (GotoCase): Track the SwitchLabel instead of the computed label
484 (its contained therein). Emit the code by using
485 SwitchLabel.GetILLabelCode ().
487 (LocalInfo.Flags.Captured): A new flag has been introduce to track
488 whether the Local has been captured or not.
490 (LocalInfo.IsCaptured): New property, used to tell whether the
491 local has been captured.
493 * anonymous.cs: Vastly updated to contain the anonymous method
496 The main classes here are: CaptureContext which tracks any
497 captured information for a toplevel block and ScopeInfo used to
498 track the activation frames for various local variables.
500 Each toplevel block has an optional capture context associated
501 with it. When a method contains an anonymous method both the
502 toplevel method and the anonymous method will create a capture
503 context. When variables or parameters are captured, they are
504 recorded on the CaptureContext that owns them, for example:
508 MyDelegate d = delegate {
513 Here `a' will be recorded as captured on the toplevel
514 CapturedContext, the inner captured context will not have anything
515 (it will only have data if local variables or parameters from it
516 are captured in a nested anonymous method.
518 The ScopeInfo is used to track the activation frames for local
519 variables, for example:
521 for (int i = 0; i < 10; i++)
522 for (int j = 0; j < 10; j++){
523 MyDelegate d = delegate {
528 At runtime this captures a single captured variable `i', but it
529 captures 10 different versions of the variable `j'. The variable
530 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
533 The toplevel ScopeInfo will also track information like the `this'
534 pointer if instance variables were referenced (this is necessary
535 as the anonymous method lives inside a nested class in the host
538 (AnonymousMethod): Expanded to track the Toplevel, implement
539 `AnonymousMethod.Compatible' to tell whether an anonymous method
540 can be converted to a target delegate type.
542 The routine now also produces the anonymous method content
544 (AnonymousDelegate): A helper class that derives from
545 DelegateCreation, this is used to generate the code necessary to
546 produce the delegate for the anonymous method that was created.
548 * assign.cs: API adjustments for new changes in
549 Convert.ImplicitStandardConversionExists.
551 * class.cs: Adjustments to cope with the fact that now toplevel
552 blocks are of type `ToplevelBlock'.
554 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
555 insteda of standard blocks.
557 Flag errors if params arguments are passed to anonymous methods.
559 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
560 `CurrentAnonymousMethod' which points to the current Anonymous
561 Method. The variable points to the AnonymousMethod class that
562 holds the code being compiled. It is set in the new EmitContext
563 created for the anonymous method.
565 (EmitContext.Phase): Introduce a variable and an enumeration to
566 assist in enforcing some rules about when and where we are allowed
567 to invoke certain methods (EmitContext.NeedsReturnLabel is the
568 only one that enfonces this right now).
570 (EmitContext.HaveCaptureInfo): new helper method that returns
571 whether we have a CapturedContext initialized.
573 (EmitContext.CaptureVariable): New method used to register that a
574 LocalInfo must be flagged for capturing.
576 (EmitContext.CapturedParameter): New method used to register that a
577 parameters must be flagged for capturing.
579 (EmitContext.CapturedField): New method used to register that a
580 field must be flagged for capturing.
582 (EmitContext.HaveCapturedVariables,
583 EmitContext.HaveCapturedFields): Return whether there are captured
586 (EmitContext.EmitMethodHostInstance): This is used to emit the
587 instance for the anonymous method. The instance might be null
588 (static methods), this (for anonymous methods that capture nothing
589 and happen to live side-by-side with the current method body) or a
590 more complicated expression if the method has a CaptureContext.
592 (EmitContext.EmitTopBlock): Routine that drives the emission of
593 code: it will first resolve the top block, then emit any metadata
594 and then emit the code. The split is done so that we can extract
595 any anonymous methods and flag any captured variables/parameters.
597 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
598 during this phase, the ILGenerator should not be used as labels
599 and local variables declared here might not be accessible to any
600 code that is part of an anonymous method.
602 Exceptions to this include the temporary variables that are
603 created by some statements internally for holding temporary
606 (EmitContext.EmitMeta): New routine, in charge of emitting all the
609 (EmitContext.TemporaryReturn): This method is typically called
610 from the Emit phase, and its the only place where we allow the
611 ReturnLabel to be defined other than the EmitMeta. The reason is
612 that otherwise we would have to duplicate a lot of logic in the
613 Resolve phases of various methods that today is on the Emit
616 (EmitContext.NeedReturnLabel): This no longer creates the label,
617 as the ILGenerator is not valid during the resolve phase.
619 (EmitContext.EmitThis): Extended the knowledge in this class to
620 work in anonymous methods in addition to iterators.
622 (EmitContext.EmitCapturedVariableInstance): This emits whatever
623 code is necessary on the stack to access the instance to a local
624 variable (the variable will be accessed as a field).
626 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
627 EmitContext.EmitAddressOfParameter): Routines to support
628 parameters (not completed at this point).
630 Removals: Removed RemapLocal and RemapLocalLValue. We probably
631 will also remove the parameters.
633 * convert.cs (Convert): Define a `ConstantEC' which points to a
634 null. This is just to prefity some code that uses
635 ImplicitStandardConversion code and do not have an EmitContext
638 The idea is to flag explicitly that at that point in time, it is
639 known that the conversion will not trigger the delegate checking
640 code in implicit conversions (which requires a valid
643 Everywhere: pass new EmitContext parameter since
644 ImplicitStandardConversionExists now requires it to check for
645 anonymous method conversions.
647 (Convert.ImplicitStandardConversionExists): If the type of an
648 expression is the anonymous_method_type, and the type is a
649 delegate, we invoke the AnonymousMethod.Compatible method to check
650 whether an implicit conversion is possible.
652 (Convert.ImplicitConversionStandard): Only do implicit method
653 group conversions if the language level is not ISO_1.
655 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
656 MethodInfo for the Invoke method. used by Delegate and
659 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
660 method conversions if the target type is a delegate.
662 Removed extra debugging nops.
664 (LocalVariableReference): Turn the `local_info' into a public
667 Add `prepared' field, the same hack used for FieldExprs to cope
668 with composed assignments, as Local variables do not necessarily
669 operate purely on the stack as they used to: they can be captured
672 Add `temp' for a temporary result, like fields.
674 Refactor DoResolve and DoResolveLValue into DoResolveBase.
676 It now copes with Local variables that are captured and emits the
677 proper instance variable to load it from a field in the captured
680 (ParameterReference.DoResolveBase): During the resolve phase,
681 capture parameters if we are in an anonymous method.
683 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
684 anonymous method, use the EmitContext helper routines to emit the
687 * iterators.cs: Set RemapToProxy to true/false during the
690 * parameters.cs (GetParameterByName): New helper method.
692 * typemanager.cs (anonymous_method_type) a new type that
693 represents an anonyous method. This is always an internal type,
694 used as a fencepost to test against the anonymous-methodness of an
697 2004-10-20 Marek Safar <marek.safar@seznam.cz>
699 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
701 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
703 2004-11-10 Martin Baulig <martin@ximian.com>
705 * expression.cs (Invocation.BetterFunction): If two methods have
706 equal parameter types, but only one of them is generic, the
707 non-generic one wins.
708 (New.DoResolve): Don't set `is_struct' to false if we're a generic
709 instance; just use `Type.IsValueType' to determine whether
710 something is a struct or not.
711 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
712 so we can be called multiple times.
714 2004-11-10 Martin Baulig <martin@ximian.com>
716 * generic.cs (TypeParameter.DefineConstraints): New public method.
717 (TypeParameter.CheckAccessLevel): Override this and return true.
718 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
719 override ResolveType() anymore.
720 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
722 2004-11-10 Martin Baulig <martin@ximian.com>
724 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
725 call DeclSpace.ResolveNestedType() on it.
727 2004-11-10 Martin Baulig <martin@ximian.com>
729 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
730 non-null, call ParameterModifier() on it.
732 2004-11-10 Martin Baulig <martin@ximian.com>
735 (Iterators): Added `current_type' and `this_type' fields.
736 (Iterators.DefineIterator): Create a new EmitContext and store it
737 in `ec'; compute `this_type'.
739 2004-11-10 Martin Baulig <martin@ximian.com>
742 (TypeManager.IsPrivateAccessible): New public method.
743 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
745 2004-11-10 Martin Baulig <martin@ximian.com>
747 * class.cs (TypeContainer.DefineType): Call
748 TypeBuilder.DefineGenericParameters() before resolving the type
750 (MethodData.parent_method): New protected field.
751 (MethodData..ctor): Added `MethodInfo parent_method' argument.
752 (MethodData.Define): Compute `parent_method'.
755 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
756 (MemberCore.GetClsCompliantAttributeValue): Likewise.
757 (DeclSpace.ec): New protected field; store the EmitContext here.
758 (DeclSpace.EmitContext): New public property.
759 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
760 (DeclSpace.ResolveNestedType): New public method.
761 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
762 (DeclSpace.NestedAccessible): Added `Type tb' argument.
763 (DeclSpace.FamilyAccessible): Likewise.
764 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
765 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
768 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
771 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
772 (Enum.Emit): Don't create a new EmitContext.
774 2004-10-18 Martin Baulig <martin@ximian.com>
776 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
777 `Type' directly, but call ResolveType() on it.
778 (Catch.Resolve): Likewise.
779 (Foreach.Resolve): Likewise.
781 2004-10-18 Martin Baulig <martin@ximian.com>
783 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
784 `Type' directly, but call ResolveType() on it.
785 (Probe.DoResolve): Likewise.
786 (ArrayCreation.LookupType): Likewise.
787 (TypeOf.DoResolve): Likewise.
788 (SizeOf.DoResolve): Likewise.
790 2004-10-18 Raja R Harinath <rharinath@novell.com>
792 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
795 2004-10-17 John Luke <john.luke@gmail.com>
797 * class.cs (Operator.GetSignatureForError): use CSharpName
799 * parameter.cs (Parameter.GetSignatureForError): Returns
800 correct name even if was not defined.
802 2004-10-13 Raja R Harinath <rharinath@novell.com>
805 * class.cs (TypeContainer.EmitContext): New property.
806 (DefineNestedTypes): Create an emitcontext for each part.
807 (MethodCore.DoDefineParameters): Use container's emitcontext.
808 Pass type array to InternalParameters.
809 (MemberBase.DoDefine): Use container's emitcontext.
810 (FieldMember.Define): Likewise.
811 (Event.Define): Likewise.
812 (SetMethod.GetParameterInfo): Change argument to EmitContext.
813 Pass type array to InternalParameters.
814 (SetIndexerMethod.GetParameterInfo): Likewise.
815 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
816 * delegate.cs (Define): Pass emitcontext to
817 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
818 array to InternalParameters.
819 * expression.cs (ParameterReference.DoResolveBase): Pass
820 emitcontext to GetParameterInfo.
821 (ComposedCast.DoResolveAsTypeStep): Remove check on
822 ec.ResolvingTypeTree.
823 * parameter.cs (Parameter.Resolve): Change argument to
824 EmitContext. Use ResolveAsTypeTerminal.
825 (Parameter.GetSignature): Change argument to EmitContext.
826 (Parameters.ComputeSignature): Likewise.
827 (Parameters.ComputeParameterTypes): Likewise.
828 (Parameters.GetParameterInfo): Likewise.
829 (Parameters.ComputeAndDefineParameterTypes): Likewise.
830 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
831 * support.cs (InternalParameters..ctor): Remove variant that takes
833 * typemanager.cs (system_intptr_expr): New.
834 (InitExpressionTypes): Initialize it.
836 2004-10-12 Chris Toshok <toshok@ximian.com>
838 * cs-parser.jay: fix location for try_statement and catch_clause.
840 2004-10-18 Martin Baulig <martin@ximian.com>
842 * class.cs (FieldMember.Define): Don't access the TypeExpr's
843 `Type' directly, but call ResolveType() on it.
844 (MemberBase.DoDefine): Likewise.
846 * expression.cs (New.DoResolve): Don't access the TypeExpr's
847 `Type' directly, but call ResolveType() on it.
848 (ComposedCast.DoResolveAsTypeStep): Likewise.
850 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
851 `Type' directly, but call ResolveType() on it.
853 2004-10-17 John Luke <john.luke@gmail.com>
855 * class.cs (Operator.GetSignatureForError): use CSharpName
857 * parameter.cs (Parameter.GetSignatureForError): Returns
858 correct name even if was not defined.
860 2004-10-13 Raja R Harinath <rharinath@novell.com>
863 * class.cs (TypeContainer.EmitContext): New property.
864 (DefineNestedTypes): Create an emitcontext for each part.
865 (MethodCore.DoDefineParameters): Use container's emitcontext.
866 Pass type array to InternalParameters.
867 (MemberBase.DoDefine): Use container's emitcontext.
868 (FieldMember.Define): Likewise.
869 (Event.Define): Likewise.
870 (SetMethod.GetParameterInfo): Change argument to EmitContext.
871 Pass type array to InternalParameters.
872 (SetIndexerMethod.GetParameterInfo): Likewise.
873 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
874 * delegate.cs (Define): Pass emitcontext to
875 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
876 array to InternalParameters.
877 * expression.cs (ParameterReference.DoResolveBase): Pass
878 emitcontext to GetParameterInfo.
879 (ComposedCast.DoResolveAsTypeStep): Remove check on
880 ec.ResolvingTypeTree.
881 * parameter.cs (Parameter.Resolve): Change argument to
882 EmitContext. Use ResolveAsTypeTerminal.
883 (Parameter.GetSignature): Change argument to EmitContext.
884 (Parameters.ComputeSignature): Likewise.
885 (Parameters.ComputeParameterTypes): Likewise.
886 (Parameters.GetParameterInfo): Likewise.
887 (Parameters.ComputeAndDefineParameterTypes): Likewise.
888 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
889 * support.cs (InternalParameters..ctor): Remove variant that takes
891 * typemanager.cs (system_intptr_expr): New.
892 (InitExpressionTypes): Initialize it.
894 2004-10-12 Chris Toshok <toshok@ximian.com>
896 * cs-parser.jay: fix location for try_statement and catch_clause.
898 2004-10-07 Raja R Harinath <rharinath@novell.com>
900 More DeclSpace.ResolveType avoidance.
901 * decl.cs (MemberCore.InUnsafe): New property.
902 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
903 with newly created EmitContext.
904 (FieldMember.Define): Likewise.
905 * delegate.cs (Delegate.Define): Likewise.
906 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
907 only if normal name-lookup fails.
908 (TypeExpr.DoResolve): Enable error-checking.
909 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
910 (SizeOf.DoResolve): Likewise.
911 (ComposedCast.DoResolveAsTypeStep): Likewise.
912 (StackAlloc.DoResolve): Likewise.
913 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
914 (Block.Unsafe): New property.
915 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
916 (Unsafe): Set 'unsafe' flag of contained block.
917 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
918 (Fixed.Resolve): Likewise.
919 (Catch.Resolve): Likewise.
920 (Using.ResolveLocalVariableDecls): Likewise.
921 (Foreach.Resolve): Likewise.
923 2004-10-05 John Luke <john.luke@gmail.com>
925 * cs-parser.jay: add location to error CS0175
927 2004-10-04 Miguel de Icaza <miguel@ximian.com>
929 * ecore.cs (Expression.Constantity): Add support for turning null
932 * const.cs (Const.Define): Allow constants to be reference types
933 as long as the value is Null.
935 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
937 * namespace.cs (NamespaceEntry.Using): No matter which warning
938 level is set, check if this namespace name has already been added.
940 2004-10-03 Ben Maurer <bmaurer@ximian.com>
942 * expression.cs: reftype [!=]= null should always use br[true,false].
945 2004-10-03 Marek Safar <marek.safar@seznam.cz>
948 * attribute.cs: Enum conversion moved to
949 GetAttributeArgumentExpression to be applied to the all
952 2004-10-01 Raja R Harinath <rharinath@novell.com>
954 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
955 * class.c (TypeContainer.DefineType): Flag error if
956 base types aren't accessible due to access permissions.
957 * decl.cs (DeclSpace.ResolveType): Move logic to
958 Expression.ResolveAsTypeTerminal.
959 (DeclSpace.ResolveTypeExpr): Thin layer over
960 Expression.ResolveAsTypeTerminal.
961 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
962 Refactor code into NestedAccess. Use it.
963 (DeclSpace.NestedAccess): New.
964 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
965 argument to silence errors. Check access permissions.
966 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
967 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
968 (Cast.DoResolve): Likewise.
969 (New.DoResolve): Likewise.
970 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
971 (TypeOf.DoResolve): Likewise.
973 * expression.cs (Invocation.BetterConversion): Return the Type of
974 the better conversion. Implement section 14.4.2.3 more faithfully.
975 (Invocation.BetterFunction): Make boolean. Make correspondence to
976 section 14.4.2.2 explicit.
977 (Invocation.OverloadResolve): Update.
978 (Invocation): Remove is_base field.
979 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
980 (Invocation.Emit): Likewise.
982 2004-09-24 Marek Safar <marek.safar@seznam.cz>
984 * cs-parser.jay: Reverted 642 warning fix.
986 2004-09-23 Marek Safar <marek.safar@seznam.cz>
989 * decl.cs (FindMemberWithSameName): Indexer can have more than
992 2004-09-23 Marek Safar <marek.safar@seznam.cz>
994 * expression.cs (LocalVariableReference.DoResolveLValue):
995 Do not report warning 219 for out values.
996 (EmptyExpression.Null): New member to avoid extra allocations.
998 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1000 * cs-parser.jay: Fix wrong warning 642 report.
1002 * cs-tokenizer.cs (CheckNextToken): New helper;
1003 Inspect next character if is same as expected.
1005 2004-09-23 Martin Baulig <martin@ximian.com>
1007 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1008 (Convert.ImplicitReferenceConversionExists): Likewise.
1010 2004-11-09 Raja R Harinath <rharinath@novell.com>
1012 * Makefile (DISTFILES): Comment out a few missing files.
1014 2004-10-29 Raja R Harinath <rharinath@novell.com>
1016 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
1017 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
1018 (gmcs.exe): Invoke bootstrap-libs.
1019 (clean-local): Clean the net_2_0_bootstrap profile too.
1020 (PROGRAM_INSTALL_DIR): New.
1021 (install-local): Use it.
1023 2004-10-13 Martin Baulig <martin@ximian.com>
1025 * generic.cs (TypeManager.InflatedConstraints): New nested class.
1026 (TypeParameter.DefineType): If we're a method type parameter and
1027 that method is overriding something, "inflate" its constraints.
1029 2004-10-12 Martin Baulig <martin@ximian.com>
1031 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
1032 and have type arguments, create and resolve a ConstructedType.
1034 2004-10-12 Martin Baulig <martin@ximian.com>
1036 * decl.cs (MemberCache.FindMemberToOverride): Use
1037 TypeManager.IsEqual() to compare the parameters and Type.Equals()
1038 to compare the invocationType.
1040 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
1041 When comparing two type parameters, only do the signature-only
1042 comparision for method type parameters.
1044 2004-10-11 Martin Baulig <martin@ximian.com>
1046 * report.cs: Don't make --fatal abort on warnings, we have
1047 -warnaserror for that.
1049 2004-10-11 Martin Baulig <martin@ximian.com>
1052 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
1053 (TypeManager.IsEqual): Call ourself recursively instead of using
1056 2004-10-11 Martin Baulig <martin@ximian.com>
1058 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
1059 on our own type parameters, not on the ones we inherit from a containing
1062 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
1065 * generic.cs (TypeParameter.Define): We may only be called once.
1067 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
1068 instead of TypeManager.IsEqual().
1070 2004-09-28 Martin Baulig <martin@ximian.com>
1073 (GenericConstraints.EffectiveBaseClass): New public property.
1074 (TypeParameter.GenericConstraints): New public property.
1075 (ConstructedType.CheckConstraints): Improved.
1077 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
1078 (Convert.TypeParameterConversion): New private method; use this in
1079 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
1080 for all conversions related to type parameters.
1082 2004-09-24 Martin Baulig <martin@ximian.com>
1084 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
1085 type parameter conversions for type parameters which are known to
1088 2004-09-24 Martin Baulig <martin@ximian.com>
1090 * generic.cs (GenericConstraints): Added `IsReferenceType' and
1091 `IsValueType' properties.
1093 * support.cs (ReflectionConstraints): Use
1094 Type.GetGenericParameterConstraints() instead of the old hack.
1096 2004-09-24 Martin Baulig <martin@ximian.com>
1098 * generic.cs (GenericConstraints): Moved here and made it an
1101 * support.cs (GenericConstraints): Moved to generic.cs.
1103 2004-09-24 Martin Baulig <martin@ximian.com>
1106 (ReflectionConstraints): Un-nested this class and made it public.
1109 (TypeManager.GetTypeParameterConstraints): New public method.
1110 (TypeManager.HasConstructorConstraint): Use the attributes.
1112 2004-09-24 Martin Baulig <martin@ximian.com>
1114 * support.cs (GenericConstraints): Replaced `HasConstructor',
1115 `IsReferenceType' and `IsValueType' with `Attributes'.
1116 (ReflectionParameters.ReflectionConstraints): Removed the Create()
1117 method and made the .ctor public.
1119 * generic.cs (Constraints.Attributes): New public property.
1120 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
1121 `IsReferenceType' -> `HasReferenceTypeConstraint' and
1122 `IsValueType' -> `HasValueTypeConstraint'.
1124 2004-09-23 Martin Baulig <martin@ximian.com>
1126 * generic.cs (Constraints): Reflect latest runtime changes.
1128 2004-09-23 Martin Baulig <martin@ximian.com>
1130 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1131 (Convert.ImplicitReferenceConversionExists): Likewise.
1133 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1135 * class.cs (Operator.Define): Add error 448 and 559 report.
1137 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1139 * class.cs (MemberBase.IsTypePermitted): New protected
1140 method for checking error CS0610.
1142 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1144 * class.cs (TypeContainer.HasExplicitLayout): New property
1145 Returns whether container has StructLayout attribute set Explicit.
1146 (FieldMember): New abstract class for consts and fields.
1147 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1148 (Field): Reuse FieldMember.
1150 * const.cs (Const): Reuse FieldMember.
1152 * rootcontext.cs: EmitConstants call moved to class.
1154 2004-09-22 Martin Baulig <martin@ximian.com>
1156 Marek and me just fixed one of our oldest bugs: #28562 :-)
1158 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1160 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1161 we're an EnumConstant, just return that.
1162 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1163 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1164 to get the value which'll actually be written into the attribute.
1165 However, we have to use GetValue() to access the attribute's value
1168 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1170 * constant.cs (Constant.IsNegative): New abstract property
1173 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1174 (StackAlloc.DoResolve): Reused IsNegative.
1176 2004-09-22 Martin Baulig <martin@ximian.com>
1178 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
1179 public method; like LookupTypeContainer, but also works for
1182 * report.cs (Report.SymbolRelatedToPreviousError): Use
1183 TypeManager.LookupGenericTypeContainer().
1185 2004-09-22 Martin Baulig <martin@ximian.com>
1187 Thanks to Peter Sestoft for this bug report.
1189 * expression.cs (Conditional): If both the `trueExpr' and the
1190 `falseExpr' is a NullLiteral, return a NullLiteral.
1192 2004-09-22 Martin Baulig <martin@ximian.com>
1194 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1195 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1196 for the "get_Current" call.
1198 2004-09-21 Martin Baulig <martin@ximian.com>
1200 * convert.cs (Convert.ImplicitReferenceConversion): When
1201 converting to an interface type, first check whether we're
1202 converting from a reference type.
1204 2004-09-14 Martin Baulig <martin@ximian.com>
1206 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1208 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1211 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1212 called and is obsolete then this member suppress message
1213 when call is inside next [Obsolete] method or type.
1215 * expression.cs: Use TestObsoleteMethodUsage member.
1217 2004-09-14 Martin Baulig <martin@ximian.com>
1219 * genericparser.cs: Removed.
1221 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1223 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1225 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1227 * attribute.cs (Attribute.Resolve): Add error 653 report.
1229 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1231 (Method.ApplyAttributeBuilder): Add error 685 report.
1232 (Operator.Define): Add error 564 report.
1234 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1236 * expression.cs (Invocation.DoResolve): Add error
1239 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1242 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1244 * class.cs (ConstructorInitializer.Resolve):
1245 Wrong error number (515->516).
1247 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1249 * class.cs (Indexer.Define): Add error 631 report.
1251 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1253 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1255 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1257 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1259 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1261 * cs-parser.jay: Added error CS0241 report.
1263 2004-09-10 Raja R Harinath <rharinath@novell.com>
1265 * cs-parser.jay (fixed_statement): Introduce a scope for the
1266 declaration in the 'fixed' statement.
1268 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1270 * cs-parser.jay: Added CS0230 error report.
1272 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1274 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1276 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1278 * expression.cs (Argument.Resolve): Added error CS0192 and
1281 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1283 C# 2.0 #pragma warning feature
1285 * cs-tokenizer.cs (PreProcessPragma): New method;
1286 Handles #pragma directive.
1288 * report.cs (WarningRegions): New class; Support
1289 class for #pragma warning directive. It tests whether
1290 warning is enabled for a given line.
1292 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1294 * const.cs: Add more descriptive error report, tahnks to
1297 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1299 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1301 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1303 * expression.cs: Apply patch from Ben: Remove dead code from
1304 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1305 as that code just threw an exception anwyays.
1307 * const.cs: Remove the call to the turnintoconstant, for details
1310 * literal.cs: The type of the null-literal is the null type; So
1311 we use a placeholder type (literal.cs:System.Null, defined here)
1314 * expression.cs (Conditional.DoResolve): Remove some old code that
1315 is no longer needed, conversions have been fixed.
1317 (ArrayCreationExpression.DoResolve): Return false if we fail to
1318 resolve the inner expression.
1320 2004-09-07 Raja R Harinath <rharinath@novell.com>
1323 * cs-parser.jay (delegate_declaration): Record a delegate
1324 declaration as a type declaration.
1325 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1327 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1329 * parameter.cs: Do not crash if the type can not be resolved.
1331 * expression.cs: Report errors with unsafe pointers, fixes #64896
1333 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1335 * expression.cs: Pointer arith always needs to do a conv.i
1336 if the operand is a long. fix 65320
1338 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1340 Fixed cs0619-37.cs, cs0619-38.cs
1342 * enum.cs (GetObsoleteAttribute): Removed.
1344 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1345 on Enum member is double staged. The first is tested member
1348 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1350 Fixed #56986, #63631, #65231
1352 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1353 adds member to name container.
1354 (TypeContainer.AddToTypeContainer): New method, adds type to
1356 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1357 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1358 AddOperator): Simplified by reusing AddToMemberContainer.
1359 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1361 (Method.CheckForDuplications): Fixed implementation to test all
1363 (MemberBase): Detection whether member is explicit interface
1364 implementation is now in constructor.
1365 (MemberBase.UpdateMemberName): Handles IndexerName.
1366 (Accessor): Changed to keep also location information.
1367 (AbstractPropertyEventMethod): Is derived from MemberCore.
1368 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1369 will be emited or not.
1370 (PropertyBase.AreAccessorsDuplicateImplementation):
1371 Tests whether accessors are not in collision with some method.
1372 (Operator): Is derived from MethodCore to simplify common
1375 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1377 (DeclSpace.AddToContainer): Adds the member to defined_names
1378 table. It tests for duplications and enclosing name conflicts.
1380 * enum.cs (EnumMember): Clean up to reuse the base structures
1382 2004-09-03 Martin Baulig <martin@ximian.com>
1384 Merged latest changes into gmcs. Please keep this comment in
1385 here, it makes it easier for me to see what changed in MCS since
1386 the last time I merged.
1388 2004-09-03 Martin Baulig <martin@ximian.com>
1390 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1391 into TypeContainer, to make partial classes work again.
1393 2004-09-03 Martin Baulig <martin@ximian.com>
1395 * rootcontext.cs (RootContext.V2): Removed.
1397 2004-03-23 Martin Baulig <martin@ximian.com>
1399 * expression.cs (Invocation.OverloadResolve): Added `bool
1400 may_fail' argument and use it instead of the Location.IsNull() hack.
1402 2004-09-09 Martin Baulig <martin@ximian.com>
1404 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
1406 2004-09-09 Martin Baulig <martin@ximian.com>
1408 * generic.cs (TypeParameter.DefineType): Added support for
1409 explicit interface methods.
1411 2004-09-09 Martin Baulig <martin@ximian.com>
1413 * README.Changes: New document. Started to list important changes
1414 between MCS and GMCS here.
1416 2004-09-08 Martin Baulig <martin@ximian.com>
1419 (TypeContainer.CheckRecursiveDefinition): New protected method.
1420 (TypeContainer.DefineType): Move the CS0146 check into
1421 CheckRecursiveDefinition().
1423 2004-09-06 Martin Baulig <martin@ximian.com>
1425 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
1426 types for the constructor constraint.
1428 2004-09-03 Martin Baulig <martin@ximian.com>
1430 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1431 into TypeContainer, to make partial classes work again.
1433 2004-09-03 Martin Baulig <martin@ximian.com>
1435 * rootcontext.cs (RootContext.V2): Removed.
1437 2004-03-23 Martin Baulig <martin@ximian.com>
1439 * expression.cs (Invocation.OverloadResolve): Added `bool
1440 may_fail' argument and use it instead of the Location.IsNull() hack.
1442 2004-09-03 Martin Baulig <martin@ximian.com>
1444 Merged latest changes into gmcs. Please keep this comment in
1445 here, it makes it easier for me to see what changed in MCS since
1446 the last time I merged.
1448 2004-09-03 Raja R Harinath <rharinath@novell.com>
1451 * expression.cs (BetterConversion): Don't allow either conversion
1452 to be null. Remove redundant implicit conversion test when 'q ==
1453 null' -- when this function is invoked, we already know that the
1454 implicit conversion exists.
1455 (BetterFunction): Assume that 'best' is non-null. Remove
1456 redundant reimplementation of IsApplicable when 'best' is null.
1457 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1458 number of arguments.
1459 (IsAncestralType): Extract from OverloadResolve.
1460 (OverloadResolve): Make robust to the MethodGroupExpr being
1461 unsorted. Implement all the logic of Section 14.5.5.1, and
1462 support overloading of methods from multiple applicable types.
1463 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1465 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1466 (RealError, Warning): Append type of report to related symbol.
1468 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1470 * enum.cs: Fixed CLS-Compliance checks for enum members.
1471 Error tests cs3008-8.cs, cs3014-8.cs
1473 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1475 Fixed bug #62342, #63102
1476 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1477 like ImplementMethod.
1479 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1481 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1484 2004-09-02 Martin Baulig <martin@ximian.com>
1486 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1487 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1490 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1492 C# 2.0 Static classes implemented
1494 * class.cs (TypeContainer): instance_constructors,
1495 initialized_fields, initialized_static_fields,
1496 default_constructor, base_inteface_types are protected to be
1497 accessible from StaticClass.
1498 (TypeContainer.DefineDefaultConstructor): New virtual method
1499 for custom default constructor generating
1500 (StaticClass): New class to handle "Static classes" feature.
1502 * cs-parser.jay: Handle static keyword on class like instance
1505 * driver.cs: Added "/langversion" command line switch with two
1506 options (iso-1, default).
1508 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1510 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1512 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1514 * delegate.cs: Style.
1516 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1518 * delegate.cs: Add seperate instance expr field for miguel.
1520 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1522 * PointerArithmetic (Resolve): make sure we are not doing
1523 pointer arith on void*. Also, make sure we are resolved
1524 by not setting eclass until resolve.
1526 All callers: Make sure that PointerArithmetic gets resolved.
1528 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1530 * ArrayCreation (LookupType): If the type does not resolve
1531 to an array, give an error.
1533 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1535 * statement.cs (Try.Resolve): Fixed bug #64222
1537 2004-08-27 Martin Baulig <martin@ximian.com>
1540 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1543 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1545 * ecore.cs (Constantify): Get underlying type via
1546 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1547 Windows in special cases.
1549 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1551 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1552 for obtaining also private methods.
1553 (GetRemoveMethod): Used GetRemoveMethod (true)
1554 for obtaining also private methods.
1556 2004-09-02 Martin Baulig <martin@ximian.com>
1558 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1559 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1562 2004-08-27 Martin Baulig <martin@ximian.com>
1565 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1568 2004-08-25 Martin Baulig <martin@ximian.com>
1570 * support.cs (ReflectionParameters..ctor): If this is a generic
1571 method, retrieve and store its type parameters.
1572 (InternalParameters..ctor): Added `TypeParameter[]' argument.
1573 (ReflectionParameters.GenericConstraints): The argument specifies
1574 the type parameter, not the method parameter.
1575 (InternalParameters.GenericConstraints): Likewise.
1577 * generic.cs (TypeParameter.DefineType): Correctly handle
1578 constraints wrt. generic methods in interfaces and their
1581 2004-08-24 Martin Baulig <martin@ximian.com>
1583 * generic.cs (TypeParameter.IsSubclassOf): New public method.
1584 (Constraints.IsSubclassOf): New internal method.
1586 * typemanager.cs (TypeManager.FindMembers): Added special support
1587 for GenericTypeParameterBuilder's.
1588 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
1591 2004-08-24 Martin Baulig <martin@ximian.com>
1594 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
1595 this for accessibility checks.
1596 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
1597 IsNestedFamilyAccessible.
1598 (TypeManager.IsSubclassOf): New method, do what the name actually
1601 2004-08-24 Martin Baulig <martin@ximian.com>
1603 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
1604 as a SimpleName, include the generic arity.
1606 2004-08-24 Martin Baulig <martin@ximian.com>
1608 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1609 MethodAttributes.HideBySig for operators.
1611 2004-08-23 Martin Baulig <martin@ximian.com>
1613 Back to the old error reporting system :-)
1615 * report.cs (Message): Removed.
1616 (Report.MessageData, ErrorData, WarningData): Removed.
1617 (Report.Error, Warning): Back to the old system.
1619 2004-08-23 Martin Baulig <martin@ximian.com>
1621 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1623 * class.cs (TypeContainer.ParentContainer): New public virtual
1624 method; replaces the explicit interface implementation.
1625 (ClassPart.ParentContainer): Override.
1627 2004-08-23 Martin Baulig <martin@ximian.com>
1629 * statement.cs (Switch): Added support for constant switches; see
1630 #59428 or test-285.cs.
1632 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1635 * statement.cs (GetEnumeratorFilter): Removed useless
1636 logic because C# specs is strict. GetEnumerator must be
1639 2004-08-22 Martin Baulig <martin@ximian.com>
1641 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1642 a switch and may break, reset the barrier. Fixes #59867.
1644 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1646 CLS-Compliance speed up (~5% for corlib)
1648 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1649 New method. Tests container for CLS-Compliant names
1651 * class.cs (TypeContainer.VerifyClsName): New method.
1652 Checks whether container name is CLS Compliant.
1653 (Constructor): Implements IMethodData.
1655 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1656 low-case table for CLS Compliance test.
1657 (MemberCache.VerifyClsParameterConflict): New method.
1658 Checks method parameters for CS3006 error.
1660 * enum.cs (EnumMember): Is derived from MemberCore.
1661 (Enum.VerifyClsName): Optimized for better performance.
1663 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1665 * report.cs: Renamed Error_T to Error and changed all
1668 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1670 * class.cs (TypeContainer.IndexerArrayList): New inner class
1671 container for indexers.
1672 (TypeContainer.DefaultIndexerName): New constant for default
1673 indexer name. Replaced all "Item" with this constant.
1674 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1676 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1677 DefaultMemberAttribute constructor.
1679 2004-08-05 Martin Baulig <martin@ximian.com>
1681 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1684 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1686 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1687 multi platforms problem.
1689 * compiler.csproj: Included shared files.
1691 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1693 Fix bug 60333, 55971 in the more general way
1694 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1695 Added arg_type argument for constant conversion.
1696 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1698 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1701 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1702 OperatorArrayList, MethodCoreArrayList for typecontainer
1703 containers. Changed class member types to these new types.
1704 (MethodArrayList.DefineMembers): Added test for CS0659.
1706 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1708 * cfold.cs: Synchronize the folding with the code in expression.cs
1709 Binary.DoNumericPromotions for uint operands.
1711 * attribute.cs: Revert patch from Raja, it introduced a regression
1712 while building Blam-1.2.1 (hard to isolate a test case).
1714 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1718 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1720 (MethodCore.parent_method): New member. The method we're overriding
1721 if this is an override method.
1722 (MethodCore.CheckBase): Moved from Method class and made common.
1723 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1725 (MethodCore.CheckForDuplications): New abstract method. For custom
1726 member duplication search in a container
1727 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1728 method and its return type.
1729 (Event.conflict_symbol): New member. Symbol with same name in the
1733 (MemberCache.FindMemberWithSameName): New method. The method
1734 is looking for conflict with inherited symbols.
1736 2004-08-04 Martin Baulig <martin@ximian.com>
1738 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1740 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1742 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1744 * report.cs (Message): New enum for better error, warning reference in
1746 (MessageData): New inner abstract class. It generally handles printing of
1747 error and warning messages.
1748 Removed unused Error, Warning, Message methods.
1750 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1752 Fix for cs0592-8.cs test
1754 (Attributable.ValidAttributeTargets): Made public.
1755 (Attribute.ExplicitTarget): New member for explicit target value.
1756 (Attribute.CheckTargets): Now we translate explicit attribute
1757 target to Target here.
1759 2004-08-03 Ben Maurer <bmaurer@ximian.com>
1761 * ecore.cs (MethodGroupExpr): new IsBase property.
1763 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
1765 * delegate.cs (DelegateCreation): store a MethodGroupExpr
1766 rather than an instance expr.
1768 (DelegateCreation.Emit): Use the method group rather than
1769 the instance expression. Also, if you have base.Foo as the
1770 method for a delegate, make sure to emit ldftn, not ldftnvirt.
1772 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
1774 (NewDelegate.DoResolve): Only check for the existance of Invoke
1775 if the method is going to be needed. Use MethodGroupExpr.
1777 (NewDelegate.Emit): Remove, DelegateCreation implements this.
1779 * expression.cs: For pointer arith., make sure to use
1780 the size of the type, not the size of the pointer to
1783 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1786 * class.cs (Class): Added error CS0502 test.
1788 2004-08-03 John Luke <jluke@cfl.rr.com>
1789 Raja R Harinath <rharinath@novell.com>
1792 * attribute.cs (Attribute.complained_before): New flag.
1793 (Attribute.ResolveType, Attribute.Resolve),
1794 (Attribute.DefinePInvokeMethod): Set it.
1795 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1797 2004-08-03 Martin Baulig <martin@ximian.com>
1799 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1800 use a user-defined operator; we still need to do numeric
1801 promotions in case one argument is a builtin type and the other
1802 one has an implicit conversion to that type. Fixes #62322.
1804 2004-08-18 Martin Baulig <martin@ximian.com>
1806 * class.cs (Method.Define): Use the correct method name when
1807 creating the MethodBuilder for a generic method.
1809 2004-08-17 Martin Baulig <martin@ximian.com>
1811 * generic.cs (Constraints): Support type parameter constraints.
1813 2004-08-16 Martin Baulig <martin@ximian.com>
1815 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
1816 (Token.GENERIC_DIMENSION): New token; this is returned if we
1817 encounter an unbound generic type in a typeof() expression.
1819 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
1820 this token is only generated while parsing a typeof() expression.
1821 (typeof_expression): Removed the old unbound_type hack.
1823 * generic.cs (TypeArguments.IsUnbound): New public property.
1825 * decl.cs (MemberName): Added support for unbound types.
1827 2004-08-14 Martin Baulig <martin@ximian.com>
1830 (TypeManager.IsEqualGenericInstance): New static method.
1831 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
1832 just used to check accessibility, so follow the rules of 26.1.6.
1834 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
1835 ConstructedType instead of a TypeExpression if we have type arguments.
1837 * cs-parser.jay (typeof_expression): Support unbound generic types.
1839 * ecore.cs (UnboundTypeExpression): New public class.
1841 2004-08-12 Martin Baulig <martin@ximian.com>
1843 * typemanager.cs (TypeManager.IsNestedChildOf): Use
1844 TypeManager.IsEqual() rather than `=='.
1846 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
1847 generic instances as well.
1849 2004-08-12 Martin Baulig <martin@ximian.com>
1851 * expression.cs (Invocation.InferType): We can only infer method
1852 type parameters. Fixes #62647.
1854 2004-08-11 Martin Baulig <martin@ximian.com>
1856 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
1857 before resolving the base classes.
1859 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1861 * Makefile: install .mdb file too.
1863 2004-08-05 Martin Baulig <martin@ximian.com>
1865 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
1866 initializer, the current type is just the TypeBuilder, not the
1867 instantiated generic type.
1868 (FieldExpr.IsFieldInitializer): New public property.
1870 2004-08-04 Martin Baulig <martin@ximian.com>
1872 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1874 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1876 2004-08-03 Martin Baulig <martin@ximian.com>
1878 * class.cs (MethodData.Define): If we're an explicit
1879 implementation, remove the generic arity from the type name.
1881 2004-08-03 Martin Baulig <martin@ximian.com>
1883 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1884 use a user-defined operator; we still need to do numeric
1885 promotions in case one argument is a builtin type and the other
1886 one has an implicit conversion to that type. Fixes #62322.
1888 2004-08-02 Martin Baulig <martin@ximian.com>
1890 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
1892 (TypeContainer.GetClassBases): Return the unexpanded list of
1893 interfaces; we expand them later.
1894 (TypeContainer.DefineType): After creating the TypeBuilder, call
1895 TypeManager.ExpandInterfaces() to get an expanded and resolved
1898 * ecore.cs (TypeExpr.GetInterfaces): Removed
1900 * generics.cs (Constraints.InterfaceConstraints): Remove.
1901 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
1902 register the interface constraints.
1905 (TypeManager.AddUserType): Removed the `ifaces' argument.
1906 (TypeManager.AddTypeParameter): Likewise.
1907 (TypeManager.AddUserInterface): Removed, was unused.
1908 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
1909 `TypeExpr[]' array for the interfaces.
1910 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
1911 has been defined, returns a list of the resolved interfaces types.
1912 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
1913 (TypeManager.GetExplicitInterfaces): Likewise.
1915 2004-08-02 Martin Baulig <martin@ximian.com>
1917 * expression.cs (Invocation.EmitCall): If we're invoking a method
1918 on a type parameter, use the new `Constrained' prefix opcode.
1920 2004-08-02 Martin Baulig <martin@ximian.com>
1922 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1923 (LocalInfo.IsThis): New public property.
1924 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1926 2004-08-01 Martin Baulig <martin@ximian.com>
1928 * class.cs (TypeContainer.GetClassBases): Don't set the default
1929 here since we may get called from GetPartialBases().
1930 (TypeContainer.DefineType): If GetClassBases() didn't return a
1931 parent, use the default one.
1933 2004-07-30 Martin Baulig <martin@ximian.com>
1935 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1937 * class.cs (SourceMethod): New public class, derive from the
1938 symbol writer's ISourceMethod.
1939 (Method): Use the new symbol writer API.
1941 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1942 as argument and use the new symbol writer.
1945 (SourceFile): Implement the symbol writer's ISourceFile.
1946 (Location.SymbolDocument): Removed.
1947 (Location.SourceFile): New public property.
1949 * symbolwriter.cs: Use the new symbol writer API.
1951 2004-07-30 Raja R Harinath <rharinath@novell.com>
1953 * Makefile (install-local): Remove. Functionality moved to
1956 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1958 * Makefile: Install mcs.exe.config file together with mcs.exe.
1959 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1960 correct runtime version.
1962 2004-07-25 Martin Baulig <martin@ximian.com>
1965 (TypeContainer.RegisterOrder): Removed, this was unused.
1966 (TypeContainer, interface_order): Removed.
1967 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1968 TypeContainer as argument since we can also be called with a
1969 `PartialContainer' for a partial class/struct/interface.
1970 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
1971 of checking whether we're an `Interface' - we could be a
1973 (PartialContainer.Register): Override; call
1974 AddClass()/AddStruct()/AddInterface() on our parent.
1976 * cs-parser.jay (interface_member_declaration): Add things to the
1977 `current_container', not the `current_class'.
1979 * rootcontext.cs (RegisterOrder): The overloaded version which
1980 takes an `Interface' was unused, removed.
1982 * typemanager.cs (TypeManager.LookupInterface): Return a
1983 `TypeContainer', not an `Interface'.
1984 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
1985 contain a `PartialContainer' for an interface, so check it's
1986 `Kind' to figure out what it is.
1988 2004-07-25 Martin Baulig <martin@ximian.com>
1990 * class.cs (Class.DefaultTypeAttributes): New public constant.
1991 (Struct.DefaultTypeAttributes): Likewise.
1992 (Interface.DefaultTypeAttributes): Likewise.
1993 (PartialContainer.TypeAttr): Override this and add the
1994 DefaultTypeAttributes.
1996 2004-07-25 Martin Baulig <martin@ximian.com>
1998 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
1999 we can just use the `Parent' field instead.
2001 2004-07-25 Martin Baulig <martin@ximian.com>
2003 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2005 2004-07-25 Martin Baulig <martin@ximian.com>
2007 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2008 our parts before defining any methods.
2009 (TypeContainer.VerifyImplements): Make this virtual.
2010 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2011 on our PartialContainer.
2013 2004-07-25 Martin Baulig <martin@ximian.com>
2015 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2017 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2018 argument, we can just use the `Parent' field instead.
2021 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2022 (MemberBase.DoDefine): Likewise.
2024 2004-07-24 Martin Baulig <martin@ximian.com>
2026 * decl.cs (MemberCore.Parent): New public field.
2027 (DeclSpace.Parent): Moved to MemberCore.
2029 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2030 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2032 (FieldBase, Field, Operator): Likewise.
2033 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2034 (EventField, Event): Likewise.
2036 2004-07-23 Martin Baulig <martin@ximian.com>
2038 * class.cs (PartialContainer): New public class.
2039 (ClassPart): New public class.
2040 (TypeContainer): Added support for partial classes.
2041 (TypeContainer.GetClassBases): Splitted some of the functionality
2042 out into GetNormalBases() and GetPartialBases().
2044 * cs-tokenizer.cs (Token.PARTIAL): New token.
2045 (Tokenizer.consume_identifier): Added some hacks to recognize
2046 `partial', but only if it's immediately followed by `class',
2047 `struct' or `interface'.
2049 * cs-parser.jay: Added support for partial clases.
2051 2004-07-23 Martin Baulig <martin@ximian.com>
2053 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2054 a `DeclSpace' and also made it readonly.
2055 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2056 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2057 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2059 * cs-parser.jay: Pass the `current_class', not the
2060 `current_container' (at the moment, this is still the same thing)
2061 to a new Method, Property, Event, Indexer or Constructor.
2063 2004-07-23 Martin Baulig <martin@ximian.com>
2065 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2066 and removed the `current_interface' one.
2067 (struct_declaration, class_declaration, interface_declaration):
2068 Set `current_class' to the newly created class/struct/interface;
2069 set their `Bases' and call Register() before parsing their body.
2071 2004-07-23 Martin Baulig <martin@ximian.com>
2073 * class.cs (Kind): New public enum.
2074 (TypeContainer): Made this class abstract.
2075 (TypeContainer.Kind): New public readonly field.
2076 (TypeContainer.CheckDef): New public method; moved here from
2078 (TypeContainer.Register): New public abstract method.
2079 (TypeContainer.GetPendingImplementations): New public abstract
2081 (TypeContainer.GetClassBases): Removed the `is_class' and
2082 `is_iface' parameters.
2083 (TypeContainer.DefineNestedTypes): Formerly known as
2085 (ClassOrStruct): Made this class abstract.
2087 * tree.cs (RootTypes): New public type.
2089 2004-07-20 Martin Baulig <martin@ximian.com>
2091 * tree.cs (Tree.RecordNamespace): Removed.
2092 (Tree.Namespaces): Removed.
2094 * rootcontext.cs (RootContext.IsNamespace): Removed.
2096 * cs-parser.jay (namespace_declaration): Just create a new
2097 NamespaceEntry here.
2099 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
2101 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
2102 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
2103 entry to make sure it runs in the correct runtime version.
2105 2004-07-18 Martin Baulig <martin@ximian.com>
2107 * generic.cs (ConstructedType.CheckConstraints): Improved
2108 constraints checking.
2110 2004-07-18 Martin Baulig <martin@ximian.com>
2112 * expression.cs (Invocation.BetterMethod): Call
2113 TypeManager.TypeToCoreType() on all types and removed my previous
2114 hack; we're already doig the right thing here.
2116 2004-07-17 Martin Baulig <martin@ximian.com>
2118 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
2120 2004-07-16 Martin Baulig <martin@ximian.com>
2122 * iterators.cs: Added generics support.
2124 2004-07-16 Martin Baulig <martin@ximian.com>
2126 * iterators.cs: Rewrote this. We're now using one single Proxy
2127 class for both the IEnumerable and the IEnumerator interface and
2128 `Iterator' derives from Class so we can use the high-level API.
2130 * class.cs (TypeContainer.AddIterator): New method.
2131 (TypeContainer.DoDefineType): New protected virtual method, which
2132 is called from DefineType().
2133 (TypeContainer.DoDefineMembers): Call DefineType() and
2134 DefineMembers() on all our iterators.
2135 (TypeContainer.Emit): Call Emit() on all our iterators.
2136 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2138 * codegen.cs (EmitContext.CurrentIterator): New public field.
2140 2004-07-15 Martin Baulig <martin@ximian.com>
2143 (TypeManager.not_supported_exception_type): New type.
2145 2004-07-14 Martin Baulig <martin@ximian.com>
2148 (TypeManager.generic_ienumerable_type): New type.
2149 (TypeManager.generic_ienumerator_type): New type.
2152 (RootContext.interfaces_first_stage): Added
2153 "System.Collections.Generic.IEnumerator`1" and
2154 "System.Collections.Generic.IEnumerable`1".
2156 2004-07-14 Martin Baulig <martin@ximian.com>
2158 * iterators.cs: Use real error numbers.
2160 2004-07-14 Martin Baulig <martin@ximian.com>
2162 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2163 requires this to be a System.Collection.IEnumerable and not a
2164 class implementing that interface.
2165 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2167 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2169 * class.cs: Fixed previous fix, it broke some error tests.
2171 2004-07-12 Martin Baulig <martin@ximian.com>
2173 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2176 2004-07-14 Martin Baulig <martin@ximian.com>
2178 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
2179 an exclamation mark (!) for the generic arity to reflect the
2180 latest spec changes; ie. use "System.Collections.Generic.IList`1".
2182 2004-07-13 Martin Baulig <martin@ximian.com>
2184 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
2185 specifiers being part of a type argument.
2187 2004-07-13 Martin Baulig <martin@ximian.com>
2189 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
2190 name for generic types.
2192 2004-07-13 Martin Baulig <martin@ximian.com>
2194 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
2197 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2199 * assign.cs (LocalTemporary): Add new argument: is_address,If
2200 `is_address' is true, then the value that we store is the address
2201 to the real value, and not the value itself.
2203 * ecore.cs (PropertyExpr): use the new local temporary
2204 stuff to allow us to handle X.Y += z (where X is a struct)
2206 2004-07-08 Martin Baulig <martin@ximian.com>
2208 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2209 not always return, just like we're doing in Using.Resolve().
2211 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2213 * cs-parser.jay (fixed_statement): flag this as Pinned.
2215 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2217 * typemanager.cs (TypeManager): Removed MakePinned method, this
2218 mechanism is replaced with the .NET 2.x compatible mechanism of
2219 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2221 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2222 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2223 `IsFixed' property which has a different meaning.
2225 2004-07-02 Raja R Harinath <rharinath@novell.com>
2227 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2228 visible from inside a nested class, not just the names of the
2229 immediately enclosing class.
2232 2004-06-24 Raja R Harinath <rharinath@novell.com>
2234 * expression.cs (BetterConversion): Remove buggy special-case
2235 handling of "implicit constant expression conversions". At this
2236 point, we already know that the conversion is possible -- we're
2237 only checking to see which is better.
2239 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2241 * cs-parser.jay: Added error CS0210 test.
2243 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2245 * cs-parser.jay: Added error CS0134 test.
2247 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2250 * cs-parser.jay: Added error CS0145 test.
2252 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2254 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2256 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2258 * expression.cs (StackAlloc.Resolve): The argument may not
2259 be a constant; deal with this case.
2261 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2263 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2264 GetIndexerAttributeValue.
2265 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2267 * class.cs (Indexer.Define): Added error tests for CS0415,
2270 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2272 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2275 2004-06-23 Martin Baulig <martin@ximian.com>
2277 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2278 neither return nor throw, reset the barrier as well. Fixes #60457.
2280 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2282 * class.cs : EventAttributes is now set to None by default.
2283 This fixes bug #60459.
2285 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2288 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2289 Don't throw exception but return null (it's sufficient now).
2291 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2293 * typemanager.cs (GetArgumentTypes): Faster implementation.
2295 2004-06-18 Martin Baulig <martin@ximian.com>
2297 * attribute.cs (Attribute.Resolve): Check whether we're an
2298 EmptyCast which a Constant child. Fixes #60333.
2300 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2302 * statement.cs (EmitCollectionForeach): Account for the fact that
2303 not all valuetypes are in areas which we can take the address of.
2304 For these variables, we store to a temporary variable. Also, make
2305 sure that we dont emit a `callvirt' on a valuetype method.
2307 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2309 * expression.cs (StackAlloc.DoReSolve): Added test for
2310 negative parameter (CS0247).
2312 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2315 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2317 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2320 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2323 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2325 Fix bug #58254 & cs1555.cs, cs1556.cs
2326 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2328 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2330 * cs-parser.jay: Added error CS1669 test for indexers.
2332 2004-06-18 Martin Baulig <martin@ximian.com>
2334 * generics.cs (GenericMethod.ctor): Don't take an Attributes
2335 argument. Fixes #60441.
2337 2004-06-16 Ben Maurer <bmaurer@ximian.com>
2338 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
2339 The name needs to have the actual name of the method in order
2340 for other tests (such as the one in OverloadResolve for Invoke
2341 on a delegate) to work. As well, it does not really help
2342 error reporting because the method group had multiple methods.
2343 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
2344 Make profiling work.
2346 2004-06-13 Martin Baulig <martin@ximian.com>
2348 * cs-parser.jay: Don't allow generic attributes.
2350 2004-06-13 Martin Baulig <martin@ximian.com>
2352 * class.cs (MemberBase.DoDefineBase): New protected method.
2353 (MemberBase.DoDefine): Compute the `flags' in the new
2354 DoDefineBase() which must be called first.
2355 (Method.Define): Call DoDefineBase() first so we have the flags
2356 when defining the generic method.
2358 * cs-parser.jay (interface_method_declaration): Support generic methods.
2360 2004-06-13 Martin Baulig <martin@ximian.com>
2362 * decl.cs (TypeName): Removed.
2363 (MemberName): Removed TypeName and MemberNow; now we just have
2366 * cs-parser.jay: Don't distinguish between type arguments and type
2367 parameters in the grammar and simplified the rules a bit. The
2368 reduce/reduce conflicts are now gone (except the one we inherited
2371 2004-06-11 Martin Baulig <martin@ximian.com>
2373 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2374 call this twice: for params and varargs methods.
2376 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2379 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2381 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2383 * attribute.cs (Attribute.GetValidTargets): Made public.
2386 (AbstractPropertyEventMethod): New class for better code sharing.
2387 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2389 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2391 2004-06-09 Martin Baulig <martin@ximian.com>
2393 * cs-parser.jay: Removed a reduce/reduce conflict.
2395 2004-06-03 Martin Baulig <martin@ximian.com>
2397 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
2398 GetSimpleName() and return a SimpleName.
2400 * ecore.cs (SimpleName.Arguments): New public field.
2401 (SimpleName): Added overloaded ctor which takes an additional
2402 TypeArguments argument.
2403 (SimpleName.SimpleNameResolve): Added support for generic methods.
2404 (MethodGroupExpr.ResolveGeneric): New public method. The code was
2405 formerly in MemberAccess.DoResolve(), but we also need it in
2406 SimpleNameResolve().
2408 * expression.cs (MemberAccess.DoResolve): Use the new
2409 MethodGroupExpr.ResolveGeneric().
2411 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2413 * decl.cs: If possible, use lookuptypedirect here. We can only do
2414 this if there is no `.' after the namespace. Avoids using
2415 LookupType, which does lots of slow processing.
2416 (FindNestedType) New method, does what it says :-).
2417 * namespace.cs: use LookupTypeDirect.
2418 * rootcontext.cs: use membercache, if possible.
2419 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2421 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2424 According to the spec,
2426 In a member access of the form E.I, if E is a single identifier,
2427 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2428 field, property, localvariable, or parameter with the same type as
2429 the meaning of E as a type-name (§3.8), then both possible
2430 meanings of E are permitted.
2432 We did not check that E as a simple-name had the same type as E as
2435 This trivial check gives us 5-7% on bootstrap time.
2437 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2439 * expression.cs (Invocation.OverloadResolve): Avoid the
2440 use of hashtables and boxing here by allocating on demand.
2442 2004-05-30 Martin Baulig <martin@ximian.com>
2444 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2445 we're doing a silent lookup. Don't try to lookup nested types in
2446 TypeManager.object_type (thanks to Ben Maurer).
2448 2004-05-30 Martin Baulig <martin@ximian.com>
2450 Committing a patch from Ben Maurer.
2452 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2454 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2456 * convert.cs: add a trivial cache for overload operator resolution.
2458 2004-05-31 Marek Safar <marek.safar@seznam.cz>
2461 (AttributeTester.GetObsoleteAttribute): Returns instance of
2462 ObsoleteAttribute when type is obsolete.
2465 (TypeContainer.VerifyObsoleteAttribute): Override.
2466 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2467 (MethodCode.VerifyObsoleteAttribute): Override.
2468 (MemberBase.VerifyObsoleteAttribute): Override.
2471 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2472 and report proper error.
2475 (Delegate.VerifyObsoleteAttribute): Override.
2478 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2479 and report proper error.
2480 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2483 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2487 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2488 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2489 Added test for ObsoleteAttribute.
2492 (Catch): Derived from Statement.
2494 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2496 * decl.cs: If possible, use lookuptypedirect here. We can only do
2497 this if there is no `.' after the namespace. Avoids using
2498 LookupType, which does lots of slow processing.
2499 (FindNestedType) New method, does what it says :-).
2500 * namespace.cs: use LookupTypeDirect.
2501 * rootcontext.cs: use membercache, if possible.
2502 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2504 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2507 According to the spec,
2509 In a member access of the form E.I, if E is a single identifier,
2510 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2511 field, property, localvariable, or parameter with the same type as
2512 the meaning of E as a type-name (§3.8), then both possible
2513 meanings of E are permitted.
2515 We did not check that E as a simple-name had the same type as E as
2518 This trivial check gives us 5-7% on bootstrap time.
2520 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2522 Fixed bug #59071 & cs0160.cs
2523 * statement.cs (Try.Resolve): Check here whether order of catch
2524 clauses matches their dependencies.
2526 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2529 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
2532 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2534 * expression.cs (Invocation.OverloadResolve): Avoid the
2535 use of hashtables and boxing here by allocating on demand.
2537 2004-05-30 Martin Baulig <martin@ximian.com>
2539 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2540 we're doing a silent lookup. Don't try to lookup nested types in
2541 TypeManager.object_type (thanks to Ben Maurer).
2543 2004-05-30 Martin Baulig <martin@ximian.com>
2545 Committing a patch from Ben Maurer.
2547 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2549 2004-05-29 Martin Baulig <martin@ximian.com>
2551 * class.cs (IMethodData.ShouldIgnore): New method.
2553 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2554 `Location' argument, we don't need it anywhere. Use
2555 `IMethodData.ShouldIgnore ()' instead of
2556 `MethodData.GetMethodFlags ()'.
2557 (TypeManager.AddMethod): Removed.
2558 (TypeManager.AddMethod2): Renamed to AddMethod.
2560 2004-05-29 Martin Baulig <martin@ximian.com>
2562 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2564 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2565 converting from a class type S to an interface type and we already
2566 have an object on the stack, don't box it again. Fixes #52578.
2568 2004-05-29 Martin Baulig <martin@ximian.com>
2570 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2571 Added support for `params' parameters. Fixes #59267.
2573 2004-05-29 Martin Baulig <martin@ximian.com>
2575 * literal.cs (NullPointer): Provide a private .ctor which sets
2576 `type' to TypeManager.object_type. Fixes #59048.
2578 2004-05-29 Martin Baulig <martin@ximian.com>
2580 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2581 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2583 * ecore.cs (EventExpr.instance_expr): Make the field private.
2585 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2587 Fixed bug #50080 & cs0214-2.cs
2588 * expression.cs (Cast.DoResolve): Check unsafe context here.
2590 * statement.cs (Resolve.DoResolve): Likewise.
2592 2004-05-26 Martin Baulig <martin@ximian.com>
2594 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2596 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2597 (RootContext.LookupType): Pass down the `silent' flag.
2599 2004-05-25 Martin Baulig <martin@ximian.com>
2602 (MethodGroupExpr.IdenticalTypeName): New public property.
2603 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2604 expression actually refers to a type.
2606 2004-05-25 Martin Baulig <martin@ximian.com>
2608 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2609 for #56176 and made it actually work.
2611 2004-05-25 Martin Baulig <martin@ximian.com>
2613 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2614 (FieldExpr, PropertyExpr): Override and implement
2615 CacheTemporaries. Fixes #52279.
2617 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2619 * location.cs: In the new compiler listing a file twice is a
2620 warning, not an error.
2622 2004-05-24 Martin Baulig <martin@ximian.com>
2624 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2625 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2627 2004-05-24 Martin Baulig <martin@ximian.com>
2629 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2630 walking the `using' list. Fixes #53921.
2632 2004-05-24 Martin Baulig <martin@ximian.com>
2634 * const.cs (Const.LookupConstantValue): Added support for
2635 EmptyCast's; fixes #55251.
2637 2004-05-24 Martin Baulig <martin@ximian.com>
2639 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2640 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2641 which does the CS0135 check. The reason is that we first need to
2642 check whether the variable actually exists.
2644 2004-05-24 Martin Baulig <martin@ximian.com>
2646 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2647 than RootContext.LookupType() to find the explicit interface
2650 2004-05-24 Raja R Harinath <rharinath@novell.com>
2652 * Makefile: Simplify. Use executable.make.
2653 * mcs.exe.sources: New file. List of sources of mcs.exe.
2655 2004-05-24 Anders Carlsson <andersca@gnome.org>
2659 Use the invariant culture when doing String.Compare for CLS case
2662 2004-05-23 Martin Baulig <martin@ximian.com>
2664 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2665 don't have any dots. Fixes #52622, added cs0246-8.cs.
2667 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2669 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2671 * class.cs (MemberBase.Define): Reuse MemberType member for
2672 resolved type. Other methods can use it too.
2674 2004-05-23 Martin Baulig <martin@ximian.com>
2676 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2677 the variable also exists in the current block (otherwise, we need
2678 to report a CS0103). Fixes #58670.
2680 2004-05-23 Martin Baulig <martin@ximian.com>
2682 * flowanalysis.cs (Reachability.Reachable): Compute this
2683 on-the-fly rather than storing it as a field.
2685 2004-05-23 Martin Baulig <martin@ximian.com>
2687 * flowanalysis.cs (Reachability.And): Manually compute the
2688 resulting `barrier' from the reachability.
2690 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2693 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2694 instance of ObsoleteAttribute when symbol is obsolete.
2697 (IMethodData): Extended interface for ObsoleteAttribute support.
2699 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2701 * attribute.cs: Fix bug #55970
2703 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2707 (GetObsoleteAttribute): New method. Creates the instance of
2709 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2710 ObsoleteAttribute when member is obsolete.
2711 (AttributeTester.Report_ObsoleteMessage): Common method for
2712 Obsolete error/warning reporting.
2715 (TypeContainer.base_classs_type): New member for storing parent type.
2718 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2719 for this MemberCore.
2721 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2723 * attribute.cs, const.cs: Fix bug #58590
2725 2004-05-21 Martin Baulig <martin@ximian.com>
2727 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2728 out parameters if the end of the method is unreachable. Fixes
2731 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2733 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2734 Hari was right, why extra method.
2736 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2738 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2740 2004-05-20 Martin Baulig <martin@ximian.com>
2742 * delegate.cs: Convert this file to Unix mode - like the original
2745 2004-05-20 Martin Baulig <martin@ximian.com>
2747 * attribute.cs: Convert this file to Unix mode - like the original
2750 2004-05-19 Marek Safar <marek.safar@seznam.cz>
2752 Fix bug #58688 (MCS does not report error when the same attribute
2755 * attribute.cs (Attribute.Emit): Distinction between null and default.
2757 2004-05-19 Raja R Harinath <rharinath@novell.com>
2759 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
2760 of a top-level attribute without an attribute target.
2761 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
2763 (Attribute.Conditional_GetConditionName),
2764 (Attribute.Obsolete_GetObsoleteMessage): Update.
2765 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
2766 part of ScanForIndexerName.
2767 (Attribute.CanIgnoreInvalidAttribute): New function.
2768 (Attribute.ScanForIndexerName): Move to ...
2769 (Attributes.ScanForIndexerName): ... here.
2770 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
2771 (Attributes.Search): New internal variant that can choose not to
2772 complain if types aren't resolved. The original signature now
2774 (Attributes.GetClsCompliantAttribute): Use internal variant, with
2775 complaints suppressed.
2776 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
2777 only if it not useful.
2778 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
2779 top-level for attributes that are shared between the assembly
2780 and a top-level class.
2781 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
2782 * class.cs: Update to reflect changes.
2783 (DefineIndexers): Fuse loops.
2784 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2785 a couple more variants of attribute names.
2787 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2789 Fix bug #52585 (Implemented explicit attribute declaration)
2792 (Attributable.ValidAttributeTargets): New abstract method. It gets
2793 list of valid attribute targets for explicit target declaration.
2794 (Attribute.Target): It holds target itself.
2795 (AttributeSection): Removed.
2796 (Attribute.CheckTargets): New method. It checks whether attribute
2797 target is valid for the current element.
2800 (EventProperty): New class. For events that are declared like
2801 property (with add and remove accessors).
2802 (EventField): New class. For events that are declared like field.
2805 * cs-parser.jay: Implemented explicit attribute target declaration.
2807 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2808 Override ValidAttributeTargets.
2811 (ReturnParameter): Class for applying custom attributes on
2813 (ParameterAtribute): New class. Class for applying custom
2814 attributes on the parameter type.
2816 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2818 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
2821 (Method): Allow UNSAFE here.
2823 * modifiers.cs: Support unsafe reporting.
2825 2004-05-17 Marek Safar <marek.safar@seznam.cz>
2827 * decl.cs: Fix bug #58478.
2829 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2831 * statement.cs: When checking for unreachable code on an EmptyStatement,
2832 set the location. Fixes bug #58488.
2834 2004-05-13 Miguel de Icaza <miguel@ximian.com>
2836 * driver.cs: Add -pkg handling.
2838 From Gonzalo: UseShelLExecute=false
2840 2004-05-12 Marek Safar <marek.safar@seznam.cz>
2843 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
2845 (Attribute.IsClsCompliaceRequired): Moved to base for better
2847 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2848 when attribute is AttributeUsageAttribute.
2849 (Attribute.GetValidTargets): Simplified.
2850 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2851 attribute for this type.
2852 (Attribute.ApplyAttributes): Method renamed to Emit and make
2854 (GlobalAttributeSection): New class for special handling of global
2855 attributes (assembly, module).
2856 (AttributeSection.Emit): New method.
2858 * class.cs: Implemented Attributable abstract methods.
2859 (MethodCore.LabelParameters): Moved to Parameter class.
2860 (Accessor): Is back simple class.
2861 (PropertyMethod): Implemented Attributable abstract class.
2862 (DelegateMethod): Implemented Attributable abstract class.
2863 (Event): New constructor for disctintion between normal Event
2864 and Event with accessors.
2866 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
2868 * codegen.cs, const.cs, decl.cs, delegate.cs:
2869 (CommonAssemblyModulClass): Implemented Attributable abstract class
2872 * enum.cs: Implement IAttributeSupport interface.
2873 (EnumMember): New class for emum members. Implemented Attributable
2877 (ParameterBase): Is abstract.
2878 (ReturnParameter): New class for easier [return:] attribute handling.
2880 * typemanager.cs: Removed builder_to_attr.
2882 2004-05-11 Raja R Harinath <rharinath@novell.com>
2885 * attribute.cs (Attribute.GetPositionalValue): New function.
2886 * class.cs (TypeContainer.VerifyMembers): New function.
2887 (TypeContainer.Emit): Use it.
2888 (ClassOrStruct): New base class for Class and Struct.
2889 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
2890 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
2892 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
2893 then each non-static field should have a FieldOffset attribute.
2894 Otherwise, none of the fields should have a FieldOffset attribute.
2895 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
2896 and FieldOffset attributes.
2897 * typemanager.cs (TypeManager.struct_layout_attribute_type)
2898 (TypeManager.field_offset_attribute_type): New core types.
2899 (TypeManager.InitCoreTypes): Initialize them.
2901 2004-05-11 Michal Moskal <malekith@pld-linux.org>
2903 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
2904 Return correct type.
2907 2004-05-09 Miguel de Icaza <miguel@ximian.com>
2909 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
2910 be implicitly converted to ulong.
2912 * expression.cs: The logic for allowing operator &, | and ^ worked
2913 was wrong, it worked before because we did not report an error in
2914 an else branch. Fixes 57895.
2916 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
2917 allow volatile fields to be reference types.
2919 2004-05-07 Miguel de Icaza <miguel@ximian.com>
2921 * driver.cs: Add support for /debug-
2923 2004-05-07 Raja R Harinath <rharinath@novell.com>
2925 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
2926 Add a 'complain' parameter to silence errors.
2927 (Attribute.Resolve): Update to changes. Put in sanity check to catch
2928 silently overlooked type-resolutions.
2929 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
2931 (Attributes.Search): New function.
2932 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
2933 (Attributes.GetAttributeFullName): Remove hack.
2934 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
2935 Update to reflect changes.
2936 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
2937 Use Attributes.Search instead of nested loops.
2939 2004-05-07 Marek Safar <marek.safar@seznam.cz>
2942 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
2943 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
2944 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
2946 * report.cs: (Report.Warning): Renamed to Warning_T because of
2947 parameter collision.
2949 2004-05-05 Raja R Harinath <rharinath@novell.com>
2951 * expression.cs (MemberAccess.ResolveMemberAccess):
2952 Exit with non-zero status after Report.Error.
2953 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
2955 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
2957 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2959 * support.cs: Don't hang when the file is empty.
2961 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2963 * support.cs: In SeekableStreamReader, compute the preamble size of the
2964 underlying stream. Position changes should take into account that initial
2967 2004-05-03 Todd Berman <tberman@sevenl.net>
2969 * driver.cs: remove unused GetSysVersion function.
2971 2004-05-03 Todd Berman <tberman@sevenl.net>
2973 * driver.cs: Remove the hack from saturday, as well as the hack
2974 from jackson (LoadAssemblyFromGac), also adds the CWD to the
2975 link_paths to get that bit proper.
2977 2004-05-01 Todd Berman <tberman@sevenl.net>
2979 * driver.cs: Try a LoadFrom before a Load, this checks the current
2980 path. This is currently a bug in mono that is be fixed, however, this
2981 provides a workaround for now. This will be removed when the bug
2984 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
2986 * CryptoConvert.cs: Updated to latest version. Fix issue with
2987 incomplete key pairs (#57941).
2989 2004-05-01 Todd Berman <tberman@sevenl.net>
2991 * driver.cs: Remove '.' from path_chars, now System.* loads properly
2994 2004-04-30 Jackson Harper <jackson@ximian.com>
2996 * codegen.cs: Open keys readonly.
2998 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3000 * typemanager.cs: don't report cyclic struct layout when a struct
3001 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3002 which has 2 Pango.Rectangle fields.
3004 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3006 * expression.cs: Handle IntPtr comparisons with IL code
3007 rather than a method call.
3009 2004-04-29 Martin Baulig <martin@ximian.com>
3011 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3012 the list of PropertyInfo's in class hierarchy and find the
3013 accessor. Fixes #56013.
3015 2004-04-29 Martin Baulig <martin@ximian.com>
3017 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3019 2004-04-29 Martin Baulig <martin@ximian.com>
3021 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3023 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3025 2004-04-29 Martin Baulig <martin@ximian.com>
3027 * class.cs (ConstructorInitializer.Resolve): Check whether the
3028 parent .ctor is accessible. Fixes #52146.
3030 2004-04-29 Martin Baulig <martin@ximian.com>
3032 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3034 * statement.cs (Using.EmitLocalVariableDecls): Use
3035 TypeManager.idisposable_type, not typeof (IDisposable).
3036 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3038 2004-04-29 Martin Baulig <martin@ximian.com>
3040 * class.cs (Event.Define): Don't emit the field and don't set
3041 RTSpecialName and SpecialName for events on interfaces. Fixes
3044 2004-04-29 Raja R Harinath <rharinath@novell.com>
3046 Refactor Attribute.ApplyAttributes.
3047 * attribute.cs (Attributable): New base class for objects that can
3048 have Attributes applied on them.
3049 (Attribute): Make AttributeUsage fields public.
3050 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3051 (Attribute.IsInternalCall): New property.
3052 (Attribute.UsageAttr): Convert to a public read-only property.
3053 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3054 (Attribute.ResolveType, Attribute.Resolve)
3055 (Attribute.ScanForIndexerName): Update to reflect changes.
3056 (Attribute.CheckAttributeTarget): Re-format.
3057 (Attribute.ApplyAttributes): Refactor, to various
3058 Attributable.ApplyAttributeBuilder methods.
3059 * decl.cs (MemberCore): Make Attributable.
3060 * class.cs (Accessor): Make Attributable.
3061 (MethodData.ApplyAttributes): Use proper attribute types, not
3063 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3064 (TypeContainer.ApplyAttributeBuilder)
3065 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3066 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3067 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3068 (Operator.ApplyAttributeBuilder): New factored-out methods.
3069 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3070 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3071 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3072 * parameter.cs (ParameterBase): New Attributable base class
3073 that can also represent Return types.
3074 (Parameter): Update to the changes.
3076 2004-04-29 Jackson Harper <jackson@ximian.com>
3078 * driver.cs: Prefer the corlib system version when looking for
3079 assemblies in the GAC. This is still a hack, but its a better hack
3082 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3084 * decl.cs, enum.cs: Improved error 3005 reporting.
3086 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3087 (related_symbols): New private member for list of symbols
3088 related to reported error/warning.
3090 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3092 2004-04-29 Martin Baulig <martin@ximian.com>
3094 * ecore.cs (Expression.Constantify): If we're an enum and
3095 TypeManager.TypeToCoreType() doesn't give us another type, use
3096 t.UnderlyingSystemType. Fixes #56178.
3098 2004-04-29 Martin Baulig <martin@ximian.com>
3100 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3101 interfaces and for each interface, only add members directly
3102 declared in that interface. Fixes #53255.
3104 2004-04-28 Martin Baulig <martin@ximian.com>
3106 * expression.cs (ConditionalLogicalOperator): Use a temporary
3107 variable for `left' to avoid that we evaluate it more than once;
3110 2004-04-28 Martin Baulig <martin@ximian.com>
3112 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3115 2004-04-28 Martin Baulig <martin@ximian.com>
3117 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3120 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3121 whether the type is not void (CS1547).
3123 2004-04-28 Martin Baulig <martin@ximian.com>
3125 * expression.cs (Unary.DoResolveLValue): Override this and report
3126 CS0131 for anything but Operator.Indirection.
3128 2004-04-28 Martin Baulig <martin@ximian.com>
3130 Committing a patch from Ben Maurer; see bug #50820.
3132 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3135 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3138 2004-04-28 Martin Baulig <martin@ximian.com>
3140 Committing a patch from Ben Maurer; see bug #50820.
3142 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3145 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3148 2004-04-28 Martin Baulig <martin@ximian.com>
3150 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3151 (Block.AddLabel): Call DoLookupLabel() to only search in the
3154 2004-04-28 Martin Baulig <martin@ximian.com>
3156 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3157 comparing StringConstants and NullLiterals in Equality and Inequality.
3159 2004-04-28 Jackson Harper <jackson@ximian.com>
3161 * driver.cs: Attempt to load referenced assemblies from the
3162 GAC. This is the quick and dirty version of this method that
3163 doesnt take into account versions and just takes the first
3164 canidate found. Will be good enough for now as we will not have more
3165 then one version installed into the GAC until I update this method.
3167 2004-04-28 Martin Baulig <martin@ximian.com>
3169 * typemanager.cs (TypeManager.CheckStructCycles): New public
3170 static method to check for cycles in the struct layout.
3172 * rootcontext.cs (RootContext.PopulateTypes): Call
3173 TypeManager.CheckStructCycles() for each TypeContainer.
3174 [Note: We only need to visit each type once.]
3176 2004-04-28 Martin Baulig <martin@ximian.com>
3178 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3180 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3181 success and added `out object value'. Use a `bool resolved' field
3182 to check whether we've already been called rather than
3183 `ConstantValue != null' since this breaks for NullLiterals.
3185 2004-04-28 Raja R Harinath <rharinath@novell.com>
3187 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3188 setting of this flag, since the 'set' method may be non-public.
3190 2004-04-28 Raja R Harinath <rharinath@novell.com>
3192 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3193 check on current_vector.Block.
3195 2004-04-27 Martin Baulig <martin@ximian.com>
3197 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3198 a field initializer. Fixes #56459.
3200 2004-04-27 Martin Baulig <martin@ximian.com>
3202 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3203 we're not attempting to use an indexer. Fixes #52154.
3205 2004-04-27 Martin Baulig <martin@ximian.com>
3207 * statement.cs (Return): Don't create a return label if we don't
3208 need it; reverts my change from January 20th. Thanks to Ben
3211 2004-04-27 Martin Baulig <martin@ximian.com>
3213 According to the spec, `goto' can only leave a nested scope, but
3216 * statement.cs (Block.LookupLabel): Only lookup in the current
3217 block, don't recurse into parent or child blocks.
3218 (Block.AddLabel): Check in parent and child blocks, report
3219 CS0140/CS0158 if we find a duplicate.
3220 (Block): Removed this indexer for label lookups.
3221 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3222 this already does the error reporting for us.
3225 (FlowBranching.UsageVector.Block): New public variable; may be null.
3226 (FlowBranching.CreateSibling): Added `Block' argument.
3227 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3228 label for the target of a `goto' and check whether we're not
3229 leaving a `finally'.
3231 2004-04-27 Martin Baulig <martin@ximian.com>
3233 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3234 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3237 2004-04-27 Martin Baulig <martin@ximian.com>
3239 * statement.cs (Block.AddLabel): Also check for implicit blocks
3240 and added a CS0158 check.
3242 2004-04-27 Martin Baulig <martin@ximian.com>
3244 * flowanalysis.cs (FlowBranchingLoop): New class.
3245 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3246 UsageVector's instead of an ArrayList.
3247 (FlowBranching.Label): Likewise.
3248 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3249 (FlowBranching.AddBreakVector): New method.
3251 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3253 * attribute.cs: Small regression fix: only convert the type if we
3254 the type is different, fixes System.Drawing build.
3256 2004-04-27 Martin Baulig <martin@ximian.com>
3258 * attribute.cs (Attribute.Resolve): If we have a constant value
3259 for a named field or property, implicity convert it to the correct
3262 2004-04-27 Raja R Harinath <rharinath@novell.com>
3264 * statement.cs (Block.Block): Implicit blocks share
3265 'child_variable_names' fields with parent blocks.
3266 (Block.AddChildVariableNames): Remove.
3267 (Block.AddVariable): Mark variable as "used by a child block" in
3268 every surrounding block.
3269 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3270 been used in a child block, complain about violation of "Invariant
3271 meaning in blocks" rule.
3272 * cs-parser.jay (declare_local_variables): Don't use
3273 AddChildVariableNames.
3274 (foreach_statement): Don't create an implicit block: 'foreach'
3277 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3279 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3280 converting from 0L to ulong. Fixes 57522.
3282 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3284 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3285 derived class hides via 'new' keyword field from base class (test-242.cs).
3286 TODO: Handle this in the more general way.
3288 * class.cs (CheckBase): Ditto.
3290 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3292 * decl.cs (caching_flags): New member for storing cached values
3294 (MemberCore.Flags): New enum where bit flags for caching_flags
3296 (MemberCore.cls_compliance): Moved to caching_flags.
3297 (DeclSpace.Created): Moved to caching_flags.
3299 * class.cs: Use caching_flags instead of DeclSpace.Created
3301 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3303 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3304 if we are only a derived class, not a nested class.
3306 * typemanager.cs: Same as above, but do this at the MemberLookup
3307 level (used by field and methods, properties are handled in
3308 PropertyExpr). Allow for the qualified access if we are a nested
3311 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3313 * class.cs: Refactoring.
3314 (IMethodData): New inteface; Holds links to parent members
3315 to avoid member duplication (reduced memory allocation).
3316 (Method): Implemented IMethodData interface.
3317 (PropertyBase): New inner classes for get/set methods.
3318 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3319 (Event): New inner classes for add/remove methods.
3320 (Event.DelegateMethod): Implemented IMethodData interface.
3322 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3323 EmitContext (related to class.cs refactoring).
3325 2004-04-21 Raja R Harinath <rharinath@novell.com>
3327 * delegate.cs (Delegate.VerifyApplicability): If the number of
3328 arguments are the same as the number of parameters, first try to
3329 verify applicability ignoring any 'params' modifier on the last
3333 2004-04-08 Martin Baulig <martin@ximian.com>
3335 Merged latest changes into gmcs. Please keep this comment in
3336 here, it makes it easier for me to see what changed in MCS since
3337 the last time I merged.
3339 2004-04-16 Raja R Harinath <rharinath@novell.com>
3341 * class.cs (TypeContainer.AddIndexer): Use
3342 'ExplicitInterfaceName' to determine if interface name was
3343 explicitly specified. 'InterfaceType' is not initialized at this time.
3344 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3345 Indexers array is already in the required order. Initialize
3346 'IndexerName' only if there are normal indexers.
3347 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3348 (TypeContainer.Emit): Emit DefaultMember attribute only if
3349 IndexerName is initialized.
3352 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3354 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3357 2004-04-15 Raja R Harinath <rharinath@novell.com>
3359 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3363 * attribute.cs (Attribute.Resolve): Check for duplicate named
3367 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3369 * iterators.cs (MarkYield): track whether we are in an exception,
3370 and generate code accordingly. Use a temporary value to store the
3371 result for our state.
3373 I had ignored a bit the interaction of try/catch with iterators
3374 since their behavior was not entirely obvious, but now it is
3375 possible to verify that our behavior is the same as MS .NET 2.0
3379 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3381 * iterators.cs: Avoid creating temporaries if there is no work to
3384 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3385 Enumerations, use TypeManager.EnumToUnderlying and call
3388 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3391 (This.Emit): Use EmitContext.EmitThis to emit our
3394 (This.EmitAssign): Ditto.
3396 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3397 codepaths, we will move all the functionality into
3400 (FieldExpr.EmitAssign): Ditto.
3402 This fixes several hidden bugs that I uncovered while doing a code
3403 review of this today.
3405 * codegen.cs (EmitThis): reworked so the semantics are more clear
3406 and also support value types "this" instances.
3408 * iterators.cs: Changed so that for iterators in value types, we
3409 do not pass the value type as a parameter.
3411 Initialization of the enumerator helpers is now done in the caller
3412 instead of passing the parameters to the constructors and having
3413 the constructor set the fields.
3415 The fields have now `assembly' visibility instead of private.
3417 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3419 * expression.cs (Argument.Resolve): Check if fields passed as ref
3420 or out are contained in a MarshalByRefObject.
3422 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3423 another compiler type.
3425 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3427 * class.cs (Indexer.Define): use the new name checking method.
3428 Also, return false on an error.
3429 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3430 (is_identifier_[start/part]_character): make static.
3432 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3434 * expression.cs (Binary.ResolveOperator): Do no append strings
3435 twice: since we can be invoked more than once (array evaluation)
3436 on the same concatenation, take care of this here. Based on a fix
3437 from Ben (bug #56454)
3439 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3441 * codegen.cs: Fix another case where CS1548 must be reported (when
3442 delay-sign isn't specified and no private is available #56564). Fix
3443 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3444 error when MCS is used on the MS runtime and we need to delay-sign
3445 (which seems unsupported by AssemblyBuilder - see #56621).
3447 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3449 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3450 (TypeManager.ComputeNamespaces): Faster implementation for
3453 * compiler.csproj: Updated AssemblyName to mcs.
3455 2004-05-11 Jackson Harper <jackson@ximian.com>
3457 * Makefile: Preserve MONO_PATH
3459 2004-05-11 Jackson Harper <jackson@ximian.com>
3461 * Makefile: Use mono and mcs to build gmcs
3463 2004-05-03 Miguel de Icaza <miguel@ximian.com>
3465 * codegen.cs: Add patch from Robert Shade
3466 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
3469 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
3471 * CryptoConvert.cs: Updated to latest version. Fix issue with
3472 incomplete key pairs (#57941).
3474 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3476 * codegen.cs: Fix another case where CS1548 must be reported (when
3477 delay-sign isn't specified and no private is available #56564). Fix
3478 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3479 error when MCS is used on the MS runtime and we need to delay-sign
3480 (which seems unsupported by AssemblyBuilder - see #56621).
3482 2004-04-29 Jackson Harper <jackson@ximian.com>
3484 * Makefile: Set MONO_PATH to use the bootstrap corlib
3485 * driver.cs: Check the GAC for referenced assemblies.
3487 2004-04-29 Martin Baulig <martin@ximian.com>
3489 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
3491 2004-04-07 Martin Baulig <martin@ximian.com>
3493 * expression.cs (Binary.ResolveOperator): Added special case for
3494 Equality/Inequality between a type parameter and a null literal.
3496 2004-04-07 Martin Baulig <martin@ximian.com>
3498 * convert.cs: Check null literal -> type parameter conversions.
3500 2004-04-07 Martin Baulig <martin@ximian.com>
3502 * generic.cs (ConstructedType.CheckConstraints): Enforce the
3503 `class' and `struct' constraints.
3505 2004-04-07 Martin Baulig <martin@ximian.com>
3507 * generic.cs (SpecialConstraint): New public enum.
3508 (Constraints.Resolve): Added support for the `class' and `struct'
3511 * cs-parser.jay (type_parameter_constraint): Added support for the
3512 `class' and `struct' constraints.
3514 2004-04-07 Martin Baulig <martin@ximian.com>
3516 * support.cs (GenericConstraints): Replaced `Types' by
3517 `ClassConstraint' and `InterfaceConstraints'; added
3518 `HasClassConstraint'.
3520 2004-04-07 Martin Baulig <martin@ximian.com>
3523 (Constraints.InterfaceConstraints): New public property.
3524 (Constraints.Types): Make this property public
3525 (TypeParameter): Implement IMemberContainer.
3526 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
3527 instead of a TypeBuilder/MethodBuilder; pass the interface
3528 constraints to TypeManager.AddTypeParameter().
3529 (TypeParameter.DefineType): Just take an EmitContext and no
3530 TypeBuilder/MethodBuilder. Use the new public API.
3532 * typemanager.cs (TypeManager.AddTypeParameter): Added
3533 `TypeExpr[]' argument; add the interfaces to the
3534 `builder_to_ifaces' hash.
3535 (TypeManager.LookupMemberContainer): For
3536 GenericTypeParameterBuilders, get the TypeParameter from the
3537 `builder_to_type_param'.
3538 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
3539 the TypeParameter and call FindMembers on it.
3541 2004-04-07 Martin Baulig <martin@ximian.com>
3544 (MethodCore.GenericMethod): Moved this field here from Method.
3545 (MethodCore.IsDuplicateImplementation): Take the number of type
3546 parameters into account if we're a generic method.
3548 * expression.cs (Invocation.InferTypeArguments): Don't return true
3549 if `arguments' is null; we still need to check whether we actually
3550 don't need to infer anything in this case.
3551 (MemberAccess): Merged the functionality from GenericMemberAccess
3554 * generic.cs (GenericMemberAccess): Removed.
3556 2004-04-05 Martin Baulig <martin@ximian.com>
3558 * decl.cs (MemberCore): For generic classes, interfaces and
3559 structs, `Name' now includes the number of type parameters
3561 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
3562 encode the number of type arguments in the type name.
3564 * expression.cs (Expression.MemberLookup): Removed the
3565 `num_type_args' argument; we now encode the number of type
3566 arguments in the type name.
3568 * ecore.cs (SimpleName): Encode the number of type arguments in
3569 the type name itself.
3571 * generic.cs (ConstructedType): Likewise.
3573 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
3574 `MemberName'; we now include the number of type parameters in the
3577 * typemanager.cs (TypeManager.CheckGeneric): Removed.
3578 (TypeManager.MemberLookup): Removed the
3579 `num_type_args' argument; we now encode the number of type
3580 arguments in the type name.
3582 2004-04-03 Martin Baulig <martin@ximian.com>
3584 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
3585 (MemberCore.MemberName): Moved here from MemberBase.
3586 (DeclSpace.SetParameterInfo): Just take the constraints as an
3587 ArrayList; we already have the type parameters in our
3588 `MemberName'; also do the CS0080 reporting here.
3590 * cs-parser.jay (struct_declaration): Use `member_name' instead of
3591 `IDENTIFIER opt_type_parameter_list'; when constructing our
3592 `MemberName', it'll already include our type parameters.
3593 (class_declaration, interface_declaration): Likewise.
3594 (delegate_declaration): Likewise.
3595 (MakeName): Take a MemberName and return a MemberName.
3596 The following two changes are required to avoid shift/reduce conflicts:
3597 (member_name): Don't include a TypeName anymore; ie. this is now
3598 just 'IDENTIFIER opt_type_parameter_list'.
3599 (property_declaration, event_declaration): Use a
3600 `namespace_or_type_name' instead of a `member_name'.
3602 2004-04-03 Martin Baulig <martin@ximian.com>
3604 * decl.cs (MemberName): Renamed to `TypeName' and created a new
3606 (TypeName): Formerly known as MemberName.
3608 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
3609 instead of a `MemberName'.
3611 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
3612 (member_name): New rule; create a MemberName.
3614 2004-04-02 Martin Baulig <martin@ximian.com>
3616 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
3617 (CS0305 and CS0308).
3619 2004-04-02 Martin Baulig <martin@ximian.com>
3621 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
3622 support for nested types.
3624 2004-04-02 Martin Baulig <martin@ximian.com>
3626 * ecore.cs (IAlias): New public interface.
3627 (TypeExpr, TypeExpression): Implement IAlias.
3628 (TypeAliasExpression): New public class.
3630 * namespace.cs (Namespace): Implement IAlias.
3631 (Namespace.Lookup): Return an IAlias instead on an object.
3632 (Namespace.DefineName): Take an IAlias instead of an object.
3633 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
3635 (NamespaceEntry.UsingAlias): Take a Membername instead of an
3637 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
3639 (NamespaceEntry.Lookup): Likewise.
3641 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
3644 * decl.cs (DeclSpace): Implement IAlias.
3645 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
3647 * generic.cs (ConstructedType): Improved error checking.
3649 2004-04-02 Martin Baulig <martin@ximian.com>
3651 * convert.cs: Added type parameter conversions.
3654 (UnboxCast.Emit): Emit an `unbox.any' for type params.
3655 (ClassCast.Emit): If the source type is a type parameter, box it.
3656 If the target type is a type parameter, emit an `unbox.any'
3657 instead of a `classcast'.1
3659 2004-04-01 Martin Baulig <martin@ximian.com>
3661 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
3663 2004-04-01 Martin Baulig <martin@ximian.com>
3665 * generic.cs (ConstructedType.CheckConstraints): Use
3666 Convert.ImplicitStandardConversionExists(); user-defined implicit
3667 conversions are not allowed according to the spec.
3669 2004-03-30 Martin Baulig <martin@ximian.com>
3671 * expression.cs (New): Added support for type parameters.
3674 (TypeManager.activator_type): New public static field.
3675 (TypeManager.activator_create_instance): Likewise.
3677 2004-03-30 Martin Baulig <martin@ximian.com>
3679 * typemanager.cs (TypeManager.HasConstructorConstraint): New
3682 2004-03-30 Martin Baulig <martin@ximian.com>
3684 * generic.cs (ConstructedType.CheckConstraints): Actually follow
3685 the spec here: the argument type must be convertible to the
3688 2004-03-30 Martin Baulig <martin@ximian.com>
3691 (TypeParameter.Define, TypeParameter.DefineMethod): Call
3692 TypeManager.AddTypeParameter().
3693 (ConstructedType.CheckConstraints): Re-enable this and actually
3694 check whether we have a constructor constraint.
3697 (TypeManager.builder_to_type_param): New static field.
3698 (TypeManager.AddTypeParameter): New static method.
3699 (TypeManager.LookupTypeParameter): New public method.
3701 2004-03-30 Martin Baulig <martin@ximian.com>
3703 * generic.cs (TypeParameter.DefineType): Return a boolean and use
3704 the new API to actually define the constructor constraint.
3707 (TypeManager.new_constraint_attr_type): New static field.
3708 (TypeManager.InitCoreTypes): Initialize it.
3710 2004-03-30 Martin Baulig <martin@ximian.com>
3712 * generic.cs (Constraints): Completed error checking, use correct
3715 2004-03-29 Martin Baulig <martin@ximian.com>
3717 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
3719 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3720 public version which takes a `ParameterData pd' instead of an
3723 2004-03-29 Martin Baulig <martin@ximian.com>
3725 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
3728 2004-03-29 Martin Baulig <martin@ximian.com>
3730 * expression.cs (Argument.ResolveMethodGroup): If we're a
3731 ConstructedType, call GetMemberAccess() on it.
3733 2004-03-29 Martin Baulig <martin@ximian.com>
3735 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
3736 (MethodCore.CheckGenericOverride): When overriding a generic
3737 method, check whether the constraints match.
3739 * support.cs (GenericConstraints): New public interface.
3740 (ParameterData.GenericConstraints): New public method.
3742 * parameter.cs (Parameter.Resolve): Check whether we're a generic
3743 method parameter and compute our constraints if appropriate.
3744 (Parameter.GenericConstraints): New public property.
3746 * generic.cs (Constraints): Implement GenericConstraints.
3748 2004-03-29 Martin Baulig <martin@ximian.com>
3750 * decl.cs (MemberCache.FindMemberToOverride): Use
3751 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
3753 2004-03-29 Martin Baulig <martin@ximian.com>
3755 * generic.cs (GenericMethod.Define): Resolve our type parameters.
3757 2004-03-29 Martin Baulig <martin@ximian.com>
3759 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
3760 not allowed on non-generic declarations").
3762 2004-03-29 Martin Baulig <martin@ximian.com>
3764 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3765 public version of this method.
3767 * class.cs (MethodCore.IsDuplicateImplementation): Use
3768 Invocation.InferTypeArguments() to check this.
3770 2004-03-29 Martin Baulig <martin@ximian.com>
3772 * convert.cs: Use TypeManager.IsDelegateType() instead of
3773 comparing types correctly.
3775 2004-03-29 Martin Baulig <martin@ximian.com>
3777 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
3778 types directly to make it work for generic instances.
3780 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
3782 2004-03-29 Martin Baulig <martin@ximian.com>
3784 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
3787 2004-03-24 Martin Baulig <martin@ximian.com>
3789 * decl.cs (DeclSpace.FindType): Also use
3790 TypeManager.CheckGeneric() for types from the using clauses.
3792 2004-03-23 Martin Baulig <martin@ximian.com>
3794 * expression.cs (Invocation.OverloadResolve): Added `bool
3795 may_fail' argument and use it instead of the Location.IsNull() hack.
3797 2004-03-23 Martin Baulig <martin@ximian.com>
3799 * expression.cs (Invocation.InferType): Use correct type inference
3802 2004-03-23 Martin Baulig <martin@ximian.com>
3804 * ecore.cs (MethodGroupExpr.Name): Use
3805 TypeManager.CSharpSignature() instead of just the name.
3807 * expression.cs (Invocation.OverloadResolve): Provide better error
3809 (Invocation.DoResolve): OverloadResolve() never returns null
3810 without reporting an error, so removed the error -6 reporting here.
3812 2004-03-23 Martin Baulig <martin@ximian.com>
3814 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
3817 * cs-parser.jay (delegate_declaration): Support generic delegates.
3819 * delegate.cs: Support generic delegates.
3821 2004-03-22 Martin Baulig <martin@ximian.com>
3823 * expression.cs (Invocation.InferParamsTypeArguments): New static
3824 method; does type inference for params arguments.
3826 2004-03-21 Martin Baulig <martin@ximian.com>
3828 * typemanager.cs (TypeManager.IsGenericMethod): New public static
3829 method; checks whether a method is a generic method.
3831 * expression.cs (Invocation.InferTypeArguments): New static method;
3832 infer type arguments for generic method invocation.
3834 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
3835 property; we set this to true if we're resolving a generic method
3836 invocation and the user specified type arguments, ie. we're not
3837 doing type inference.
3839 2004-03-20 Martin Baulig <martin@ximian.com>
3841 * class.cs (MethodData.DeclaringType): New public property.
3842 (MethodData.Define): Set DeclaringType here.
3843 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
3844 instead of OperatorMethodBuilder.DeclaringType.
3846 2004-03-20 Martin Baulig <martin@ximian.com>
3848 * cs-tokenizer.cs (xtoken): Return a special
3849 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
3851 * cs-parser.jay (default_value_expression): Switch to the new
3854 2004-03-19 Martin Baulig <martin@ximian.com>
3856 * decl.cs (MemberName): New class. We use this to "construct"
3857 namespace_or_type_name's.
3859 * generics.cs (TypeArguments.GetDeclarations): New public method;
3860 returns the type arguments as a string[] and reports a CS0081 if
3861 one of them is not an identifier.
3863 * class.cs (MemberBase): The .ctor now takes the name as a
3864 MemberName instead of a string.
3865 (MemberBase.ExplicitInterfaceName): Changed type from string to
3867 (MemberBase.DoDefine): If we're an explicit implementation, the
3868 InterfaceType may be a generic instance.
3870 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
3871 (namespace_name): Call MemberName.GetName () to transform the
3872 MemberName into a string and ensure we don't have any type
3874 (type_name): Call MemberName.GetTypeExpression() to transfrom the
3875 MemberName into an expression.
3876 (method_header): Use namespace_or_type_name instead of member_name.
3878 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3880 * rootcontext.cs: Add new types to the boot resolution.
3882 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3883 MulticastDelegate is not allowed.
3885 * typemanager.cs: Add new types to lookup: System.TypedReference
3888 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3889 check for TypedReference or ArgIterator, they are not allowed.
3891 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3892 makes us properly catch 1510 in some conditions (see bug 56016 for
3895 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3897 * CryptoConvert.cs: update from corlib version
3900 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3902 * class.cs (Indexer.Define): Check indexername declaration
3904 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3906 * attribute.cs (IsClsCompliant): Fixed problem with handling
3907 all three states (compliant, not-compliant, undetected).
3909 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3911 * attribute.cs (Attribute): Location is now public.
3912 (Resolve): Store resolved arguments (pos_values) in attribute class.
3913 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3914 (GetClsCompliantAttributeValue): New method that gets
3915 CLSCompliantAttribute value.
3916 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3917 if exists else null.
3918 (AttributeTester): New class for CLS-Compliant verification routines.
3920 * class.cs (Emit): Add CLS-Compliant verification.
3921 (Method.GetSignatureForError): Implemented.
3922 (Constructor.GetSignatureForError): Implemented
3923 (Constructor.HasCompliantArgs): Returns if constructor has
3924 CLS-Compliant arguments.
3925 (Constructor.Emit): Override.
3926 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3927 is needed to test only parameters.
3928 (FieldBase.GetSignatureForError): Implemented.
3929 (TypeContainer): New member for storing base interfaces.
3930 (TypeContainer.FindMembers): Search in base interfaces too.
3932 * codegen.cs (GetClsComplianceAttribute): New method that gets
3933 assembly or module CLSCompliantAttribute value.
3934 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3936 (ModuleClass.Emit): Add error 3012 test.
3938 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3940 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3941 state for all decl types.
3942 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3943 if CLS-Compliant tests are required.
3944 (IsClsCompliaceRequired): New method. Analyze whether code
3945 must be CLS-Compliant.
3946 (IsExposedFromAssembly): New method. Returns true when MemberCore
3947 is exposed from assembly.
3948 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3949 value or gets cached value.
3950 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3951 is explicitly marked with CLSCompliantAttribute.
3952 (IsIdentifierClsCompliant): New abstract method. This method is
3953 used to testing error 3005.
3954 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3955 for identifier and parameters CLS-Compliant testing.
3956 (VerifyClsCompliance): New method. The main virtual method for
3957 CLS-Compliant verifications.
3958 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3959 null. I don't know why is null (too many public members !).
3960 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3961 and get value of first CLSCompliantAttribute that found.
3963 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3964 (VerifyClsCompliance): Override and add extra tests.
3966 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3967 clscheck- disable CLS-Compliant verification event if assembly is has
3968 CLSCompliantAttribute(true).
3970 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3971 ApllyAttribute is now called in emit section as in the other cases.
3972 Possible future Emit integration.
3973 (IsIdentifierClsCompliant): New override.
3974 (VerifyClsCompliance): New override.
3975 (GetEnumeratorName): Returns full enum name.
3977 * parameter.cs (GetSignatureForError): Implemented.
3979 * report.cs (WarningData): New struct for Warning message information.
3980 (LocationOfPreviousError): New method.
3981 (Warning): New method. Reports warning based on the warning table.
3982 (Error_T): New method. Reports error based on the error table.
3984 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3985 verifications are done here.
3987 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3989 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3990 CLSCompliantAttribute.
3991 (all_imported_types): New member holds all imported types from other
3993 (LoadAllImportedTypes): New method fills static table with exported types
3994 from all referenced assemblies.
3995 (Modules): New property returns all assembly modules.
3997 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3999 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
4000 throwing a parser error.
4002 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
4003 which removes the hardcoded get_/set_ prefixes for properties, as
4004 IL allows for the properties to be named something else.
4008 * expression.cs: Do not override operand before we know if it is
4011 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4013 * typemanager.cs: support for pinned variables.
4015 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4017 * decl.cs, typemanager.cs: Avoid using an arraylist
4018 as a buffer if there is only one result set.
4020 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4022 * expression.cs: Make sure you cant call a static method
4023 with an instance expression, bug #56174.
4025 2004-03-29 Miguel de Icaza <miguel@ximian.com>
4027 * class.cs (IsDuplicateImplementation): Improve error reporting to
4028 flag 663 (method only differs in parameter modifier).
4030 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
4031 in preprocessor directives.
4033 * location.cs (LookupFile): Allow for the empty path.
4035 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
4036 better approach for some of that patch, but its failing with the
4037 CharSet enumeration. For now try/catch will do.
4039 * typemanager.cs: Do not crash if a struct does not have fields.
4042 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4044 * expression.cs: cs0213, cant fix a fixed expression.
4047 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4049 * cs-parser.jay: detect invalid embeded statements gracefully.
4052 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4054 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
4057 the invocation type may not be a subclass of the tye of the item/
4058 The type of the item must be a subclass of the invocation item.
4063 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
4065 * attribute.cs: Added methods to get a string and a bool from an
4066 attribute. Required to information from AssemblyKeyFileAttribute,
4067 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
4068 * codegen.cs: Modified AssemblyName creation to include support for
4069 strongnames. Catch additional exceptions to report them as CS1548.
4070 * compiler.csproj: Updated include CryptoConvert.cs.
4071 * compiler.csproj.user: Removed file - user specific configuration.
4072 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
4073 Mono.Security assembly. The original class is maintained and tested in
4074 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
4075 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
4076 like CSC 8.0 (C# v2) supports.
4077 * Makefile: Added CryptoConvert.cs to mcs sources.
4078 * rootcontext.cs: Added new options for strongnames.
4080 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4082 * driver.cs: For --expect-error, report error code `2'
4083 if the program compiled with no errors, error code `1' if
4084 it compiled with an error other than the one expected.
4086 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4088 * compiler.csproj: Updated for Visual Studio .NET 2003.
4089 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4090 * compiler.sln: Updated for Visual Studio .NET 2003.
4092 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4094 * expression.cs: Fix bug #47234. We basically need to apply the
4095 rule that we prefer the conversion of null to a reference type
4096 when faced with a conversion to 'object' (csc behaviour).
4098 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4100 * statement.cs: Shorter form for foreach, eliminates
4101 a local variable. r=Martin.
4103 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4105 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4106 checks if we can use brtrue/brfalse to test for 0.
4107 * expression.cs: use the above in the test for using brtrue/brfalse.
4110 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4112 * expression.cs: Rewrite string concat stuff. Benefits:
4114 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4115 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4116 rather than a concat chain.
4118 * typemanager.cs: Add lookups for more concat overloads.
4120 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4122 * expression.cs: Emit shorter il code for array init.
4139 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4141 * statement.cs: Before, two switch blocks would be merged if the
4142 total size of the blocks (end_item - begin_item + 1) was less than
4143 two times the combined sizes of the blocks.
4145 Now, it will only merge if after the merge at least half of the
4150 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4152 * class.cs : csc build fix for GetMethods(). See bug #52503.
4154 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4156 * expression.cs: Make sure fp comparisons work with NaN.
4157 This fixes bug #54303. Mig approved this patch a long
4158 time ago, but we were not able to test b/c the runtime
4161 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4163 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4165 2004-03-19 Martin Baulig <martin@ximian.com>
4167 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
4168 two overloads may unify for some type parameter substitutions and
4169 report a CS0408 if appropriate.
4171 2004-03-19 Martin Baulig <martin@ximian.com>
4173 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4174 error here and not in our caller.
4176 2004-03-19 Martin Baulig <martin@ximian.com>
4178 * interface.cs: Completely killed this file.
4179 (Interface): We're now a TypeContainer and live in class.cs.
4181 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4182 argument; we're now also called for interfaces.
4183 (TypeContainer.DefineMembers): Allow this method being called
4185 (TypeContainer.GetMethods): New public method; formerly known as
4186 Interface.GetMethod(). This is used by PendingImplementation.
4187 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4188 it's now private and non-static.
4189 (Interface): Moved this here; it's now implemented similar to
4191 (Method, Property, Event, Indexer): Added `bool is_interface'
4192 argument to their .ctor's.
4193 (MemberBase.IsInterface): New public field.
4195 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4196 instances instead of InterfaceMethod, InterfaceProperty, etc.
4197 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4198 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4200 2004-03-19 Martin Baulig <martin@ximian.com>
4202 * class.cs (MethodCore.IsDuplicateImplementation): New private
4203 method which does the CS0111 checking.
4204 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4205 Use IsDuplicateImplementation().
4207 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4209 * decl.cs (FindMemberToOverride): New method to find the correct
4210 method or property to override in the base class.
4212 - Make Method/Property use the above method to find the
4213 version in the base class.
4214 - Remove the InheritableMemberSignatureCompare as it is now
4217 This patch makes large code bases much faster to compile, as it is
4218 O(n) rather than O(n^2) to do this validation.
4220 Also, it fixes bug 52458 which is that nested classes are not
4221 taken into account when finding the base class member.
4223 Reviewed/Approved by Martin.
4225 2004-03-17 Martin Baulig <martin@ximian.com>
4227 * expression.cs (MemberAccess.DoResolve): Take the parent's number
4228 of type arguments into account; use the `real_num_type_args'
4229 approach like in DoResolveAsTypeStep().
4231 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
4234 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4236 * interface.cs: In all interface classes removed redundant
4237 member initialization.
4239 2004-03-16 Martin Baulig <martin@ximian.com>
4241 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4243 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4245 * decl.cs (DefineTypeAndParents): New helper method to define a
4246 type's containers before the type itself is defined; This is a
4247 bug exposed by the recent changes to Windows.Forms when an
4248 implemented interface was defined inside a class that had not been
4251 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4253 (Check): Loop correctly to report errors modifiers
4254 (UNSAFE was not in the loop, since it was the same as TOP).
4256 * interface.cs: Every interface member now takes a ModFlags,
4257 instead of a "is_new" bool, which we set on the base MemberCore.
4259 Every place where we called "UnsafeOk" in the interface, now we
4260 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4261 the unsafe settings from the member declaration instead of the
4262 container interface.
4264 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4266 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4267 `set_indexer_name' to the pending bits (one per type).
4269 We fixed a bug today that was picking the wrong method to
4270 override, since for properties the existing InterfaceMethod code
4271 basically ignored the method name. Now we make sure that the
4272 method name is one of the valid indexer names.
4274 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4276 * support.cs (SeekableStreamReader): Keep track of stream byte
4277 positions and don't mix them with character offsets to the buffer.
4279 Patch from Gustavo Giráldez
4281 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4283 * interface.cs (InterfaceSetGetBase): Removed double member
4284 initialization, base class does it as well.
4286 2004-03-13 Martin Baulig <martin@ximian.com>
4288 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4289 when compiling corlib.
4291 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4293 * convert.cs (ExplicitConversion): We were reporting an error on
4294 certain conversions (object_type source to a value type, when the
4295 expression was `null') before we had a chance to pass it through
4296 the user defined conversions.
4298 * driver.cs: Replace / and \ in resource specifications to dots.
4301 * class.cs: Add check for duplicate operators. Fixes 52477
4303 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4305 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4306 that are in the middle of the statements, not only at the end.
4309 * class.cs (TypeContainer.AddField): No longer set the
4310 `HaveStaticConstructor' flag, now we call it
4311 `UserDefineStaticConstructor' to diferentiate the slightly
4312 semantic difference.
4314 The situation is that we were not adding BeforeFieldInit (from
4315 Modifiers.TypeAttr) to classes that could have it.
4316 BeforeFieldInit should be set to classes that have no static
4321 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4323 And most importantly Zoltan's comment:
4325 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4327 "I think beforefieldinit means 'it's ok to initialize the type sometime
4328 before its static fields are used', i.e. initialization does not need
4329 to be triggered by the first access to the type. Setting this flag
4330 helps the JIT to compile better code, since it can run the static
4331 constructor at JIT time, and does not need to generate code to call it
4332 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4333 this flag for lots of classes like String.
4335 csc sets this flag if the type does not have an explicit static
4336 constructor. The reasoning seems to be that if there are only static
4337 initalizers for a type, and no static constructor, then the programmer
4338 does not care when this initialization happens, so beforefieldinit
4341 This bug prevents the AOT compiler from being usable, since it
4342 generates so many calls to mono_runtime_class_init that the AOT code
4343 is much slower than the JITted code. The JITted code is faster,
4344 because it does not generate these calls if the vtable is type is
4345 already initialized, which is true in the majority of cases. But the
4346 AOT compiler can't do this."
4348 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4350 * class.cs (MethodData.Emit): Refactor the code so symbolic
4351 information is generated for destructors; For some reasons we
4352 were taking a code path that did not generate symbolic information
4355 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4357 * class.cs: Create a Constructor.CheckBase method that
4358 takes care of all validation type code. The method
4359 contains some code that was moved from Define.
4361 It also includes new code that checks for duplicate ctors.
4362 This fixes bug #55148.
4364 2004-03-09 Joshua Tauberer <tauberer@for.net>
4366 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4367 a { ... }-style array creation invokes EmitStaticInitializers
4368 which is not good for reference-type arrays. String, decimal
4369 and now null constants (NullCast) are not counted toward
4370 static initializers.
4372 2004-03-05 Martin Baulig <martin@ximian.com>
4374 * location.cs (SourceFile.HasLineDirective): New public field;
4375 specifies whether the file contains or is referenced by a "#line"
4377 (Location.DefineSymbolDocuments): Ignore source files which
4378 either contain or are referenced by a "#line" directive.
4380 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4382 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4383 direct access to our parent, so check the method inline there.
4385 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4387 * expression.cs (Invocation.EmitCall): Miguel's last commit
4388 caused a regression. If you had:
4393 In Foo the implict this would be null.
4395 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4397 * expression.cs (Invocation.EmitCall): If the method is not
4398 virtual, do not emit a CallVirt to it, use Call.
4400 * typemanager.cs (GetFullNameSignature): Improve the method to
4401 cope with ".ctor" and replace it with the type name.
4403 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4404 as an argument the ConstructorBuilder where it is being defined,
4405 to catch the recursive constructor invocations.
4407 2004-03-16 Martin Baulig <martin@ximian.com>
4409 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
4410 ConstructedType, call ResolveType() on it to get the type rather
4411 than just using `expr.Type'.
4413 2004-03-16 Martin Baulig <martin@ximian.com>
4415 * generics.cs (ConstructedType.GetMemberAccess): Take the
4416 EmitContext instead on the TypeExpr and use
4417 ec.TypeContainer.CurrentType/ec.ContainerType.
4419 2004-03-16 Martin Baulig <martin@ximian.com>
4421 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
4422 parameters before aliases.
4424 2004-03-16 Martin Baulig <martin@ximian.com>
4426 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
4427 New oublic function; checks whether two generic instances may become
4428 equal under some instantiations (26.3.1).
4430 * class.cs (TypeContainer.Define): Call
4431 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
4434 2004-03-16 Martin Baulig <martin@ximian.com>
4436 * class.cs (TypeContainer.GetClassBases): Moved
4437 Error_TypeParameterAsBase() here and also check whether the base
4438 class is not an attribute.
4440 2004-03-16 Martin Baulig <martin@ximian.com>
4442 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4444 2004-03-16 Martin Baulig <martin@ximian.com>
4446 * class.cs (Error_TypeParameterAsBase): Use correct error number
4449 2004-03-16 Martin Baulig <martin@ximian.com>
4451 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
4454 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
4457 2004-03-15 Martin Baulig <martin@ximian.com>
4459 * typemanager.cs (TypeManager.GetFullName): New public method.
4460 (TypeManager.MemberLookup): Added `int_num_type_arguments'
4461 argument; only return members with the correct number of type
4463 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
4464 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
4465 whether the number of type arguments matches.
4467 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
4468 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
4470 * expression.cs (MemberAccess): Added public `NumTypeArguments'
4471 field; it's set by the protected .ctor when we're actually a
4472 GenericMemberAccess.
4473 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
4474 arguments and pass it to MemberLookupFinal ().
4476 * ecore.cs (Expression.MemberLookup): Added `int
4477 num_type_arguments' argument; only return members with the correct
4478 number of type arguments.
4479 (Expression.MemberLookupFailed): Check whether the MemberLookup
4480 failed because we did not have the correct number of type
4481 arguments; report CS0305 in this case.
4483 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
4484 `e.ResolveAsTypeTerminal()' already did so.
4486 2004-03-15 Martin Baulig <martin@ximian.com>
4488 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
4489 we're a ConstructedType; in this case, the caller must report an
4490 error (for instance CS0131).
4492 * generic.cs (TypeArguments): Added Location argument to the .ctor.
4493 (TypeArguments.Resolve): Actually report errors here.
4495 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4497 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4498 `set_indexer_name' to the pending bits (one per type).
4500 We fixed a bug today that was picking the wrong method to
4501 override, since for properties the existing InterfaceMethod code
4502 basically ignored the method name. Now we make sure that the
4503 method name is one of the valid indexer names.
4505 2004-03-15 Martin Baulig <martin@ximian.com>
4507 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
4508 for generic instances.
4510 2004-03-13 Martin Baulig <martin@ximian.com>
4512 * class.cs (TypeContainer.DefineType): Call
4513 TypeManager.AddUserType() immediately after creating the
4514 TypeBuilder; pass all type parameters when creating the
4517 * decl.cs (DeclSpace.FindNestedType): New public method.
4518 (DeclSpace.FindType): Added `int num_type_args' argument; only
4519 return types with the correct number of type parameters.
4520 (DeclSpace.CountTypeParams): New public property.
4522 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
4523 the number of type parameters; defaults to zero.
4525 * generic.cs (TypeArguments.Count): New public property.
4526 (ConstructedType.DoResolveAsTypeStep): First call
4527 ds.FindNestedType() to find out whether we're nested in the
4528 current generic type; in this case, we inherit all type parameters
4529 from the current class.
4531 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
4532 num_type_args' argument.
4533 (RootContext.LookupType): Added overloaded version which takes the
4534 number of type arguments; only return types with the correct
4535 number of type arguments.
4537 * typemanager.cs (TypeManager.CheckGeneric): New public function;
4538 checks whether `Type t' has `int num_type_args'.
4540 2004-03-13 Martin Baulig <martin@ximian.com>
4542 * generic.cs (GenericMethod.DefineType): New method; calls
4543 DefineType() on all the type parameters.
4545 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
4546 (MethodData.Define): If we're a generic method, call
4547 GenericMethod.DefineType() to define the type parameters.
4549 2004-03-10 Martin Baulig <martin@ximian.com>
4551 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
4552 instead of IsAssignableFrom.
4554 2004-03-10 Martin Baulig <martin@ximian.com>
4556 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
4558 * support.cs (ParameterData.HasArrayParameter): New property.
4559 (ReflectionParameters.ctor): Take a MethodBase instead of a
4560 ParameterInfo[]. If we have any type parameters, get the generic
4561 method definition and ask it whether we have variable arguments.
4563 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4565 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4566 routines to check if a type is an enumerable/enumerator allow
4567 classes that implement the IEnumerable or IEnumerator interfaces.
4569 * class.cs (Property, Operator): Implement IIteratorContainer, and
4570 implement SetYields.
4572 (Property.Define): Do the block swapping for get_methods in the
4573 context of iterators. We need to check if Properties also
4574 include indexers or not.
4576 (Operator): Assign the Block before invoking the
4577 OperatorMethod.Define, so we can trigger the Iterator code
4580 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4581 Property and Operator classes are not created when we parse the
4582 declarator but until we have the block completed, so we use a
4583 singleton SimpleIteratorContainer.Simple to flag whether the
4584 SetYields has been invoked.
4586 We propagate this setting then to the Property or the Operator to
4587 allow the `yield' to function.
4589 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4591 * codegen.cs: Implemented attribute support for modules.
4592 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4593 Assembly/Module functionality.
4595 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4596 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4597 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4599 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4601 * interface.cs (FindMembers): The operation is performed on all base
4602 interfaces and not only on the first. It is required for future CLS Compliance patch.
4604 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4606 * statement.cs, codegen.cs:
4607 This patch deals with patterns such as:
4609 public class List : IEnumerable {
4611 public MyEnumerator GetEnumerator () {
4612 return new MyEnumerator(this);
4615 IEnumerator IEnumerable.GetEnumerator () {
4619 public struct MyEnumerator : IEnumerator {
4624 Before, there were a few things we did wrong:
4625 1) we would emit callvirt on a struct, which is illegal
4626 2) we emited ldarg when we needed to emit ldarga
4627 3) we would mistakenly call the interface methods on an enumerator
4628 type that derived from IEnumerator and was in another assembly. For example:
4630 public class MyEnumerator : IEnumerator
4632 Would have the interface methods called, even if there were public impls of the
4633 method. In a struct, this lead to invalid IL code.
4635 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4637 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4640 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4642 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4644 * cs-parser.jay: Fix small regression: we were not testing V2
4645 compiler features correctly.
4647 * interface.cs: If the emit context is null, then create one
4649 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4651 * decl.cs (GetSignatureForError): New virtual method to get full name
4654 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4655 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4657 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4658 Duplicated members and code in these classes has been removed.
4659 Better encapsulation in these classes.
4661 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4663 * assign.cs (Assign.DoResolve): When dealing with compound
4664 assignments, there is a new rule in ECMA C# 2.4 (might have been
4665 there before, but it is documented here) that states that in:
4669 If b is of type int, and the `op' is a shift-operator, then the
4670 above is evaluated as:
4674 * expression.cs (Binary.ResolveOperator): Instead of testing for
4675 int/uint/long/ulong, try to implicitly convert to any of those
4676 types and use that in pointer arithmetic.
4678 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4679 method to print information for from the type, not from the
4680 null-method we were given.
4682 2004-02-01 Duncan Mak <duncan@ximian.com>
4684 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4685 parsing for cmd, fixes bug #53694.
4687 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4689 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4690 in the member name duplication tests. Property and operator name duplication
4691 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4693 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4695 * interface.cs (PopulateMethod): Fixed crash when interface method
4696 returns not existing type (error test cs0246-3.cs).
4698 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4700 * cs-parser.jay (interface_accessors): Re-write actions to also
4701 store attributes attached to get and set methods. Fix spelling
4704 (inteface_property_declaration): Modify accordingly.
4706 (InterfaceAccessorInfo): New helper class to store information to pass
4707 around between rules that use interface_accessors.
4709 * interface.cs (Emit): Apply attributes on the get and set
4710 accessors of properties and indexers too.
4712 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4713 right MethodBuilder when applying attributes to the get and set accessors.
4715 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4717 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4719 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4721 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4723 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4725 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4726 changes that treat `yield' specially when present before `break'
4729 * cs-tokenizer.cs: yield is no longer a keyword.
4731 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4733 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4734 setting for default constructors.
4735 For default constructors are almost every time set wrong Modifier. The
4736 generated IL code has been alright. But inside mcs this values was
4737 wrong and this was reason why several of my CLS Compliance tests
4740 2004-02-27 Martin Baulig <martin@ximian.com>
4742 * generics.cs (ConstructedType.ResolveType): Make the nested type
4743 stuff actually work.
4745 2004-02-25 Martin Baulig <martin@ximian.com>
4747 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
4748 property; returns the type parameters just from the current type,
4749 ie. with the ones from outer classes.
4750 (DeclSpace.LookupGeneric): First search in the current class, then
4752 (DeclSpace.initialize_type_params): When hiding a type parameter
4753 from an outer class, put it into the `type_param_list' anyways.
4755 * expression.cs (MemberAccess.expr): Made this field protected.
4757 * class.cs (TypeContainer.Define): The `CurrentType' just contains
4758 the type parameters from the current class.
4760 * generic.cs (ConstructedType.ResolveType): Support nested generic
4761 types by taking the type parameters which we inherit from outer
4762 classes into account.
4763 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
4764 support for nested generic types.
4766 2004-02-23 Martin Baulig <martin@ximian.com>
4768 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
4769 field and check whether we're nested inside a generic type.
4770 (DeclSpace.ResolveType): If we're resolving to a generic type
4771 definition, create a ConstructedType and return its resolved type.
4772 (DeclSpace.initialize_type_params): New private method;
4773 initializes the `type_param_list' field from the type parameters
4774 from this and all enclosing classes.
4775 (DeclSpace.TypeParameters): Call initialize_type_params() unless
4776 we're already initialized.
4778 2004-02-23 Martin Baulig <martin@ximian.com>
4780 * class.cs (Method.Define): Create the generic method before
4782 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
4783 the TypeContainer one); we use this for generic methods.
4785 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
4786 parent's TypeBuilder.
4788 2004-02-18 Martin Baulig <martin@ximian.com>
4790 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
4791 to check for equality.
4793 2004-02-05 Martin Baulig <martin@ximian.com>
4795 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
4796 `ec.TypeContainer.CurrentType', use it instead of
4797 `ec.ContainerType' to check whether we're in the type's ctor.
4799 2004-01-29 Martin Baulig <martin@ximian.com>
4801 * expression.cs (Invocation.DoResolve): If we're a
4802 `ConstructedType', then we're actually a generic method, so
4803 rewrite the expr as a GenericMemberAccess.
4805 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
4806 here; manually parse it into a string.
4808 2004-01-28 Martin Baulig <martin@ximian.com>
4810 * typemanager.cs (TypeManager.IsEqual): New static method.
4811 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
4812 check for equality instead of using `=='.
4814 2004-01-26 Martin Baulig <martin@ximian.com>
4816 * decl.cs (DeclSpace.CurrentType): New public field.
4818 * expression.cs (This.ResolveBase): If we have an
4819 `ec.TypeContainer.CurrentType', use it instead of
4822 * class.cs (TypeContainer.DefineType): If we're a generic type,
4823 create the `CurrentType' (unresolved).
4824 (TypeContainer.GenericType): New private field.
4825 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
4826 it and store it in `GenericType' before creating the MemberCache.
4827 (TypeContainer.GetMembers): If we have a `GenericType', call
4828 TypeManager.FindMembers() on it.
4830 * interface.cs (Interface.GenericType): New private field.
4831 (Interface.DefineType): If we're a generic type, create the
4832 `CurrentType' (unresolved).
4833 (Interface.DefineMembers): If we have a `CurrentType', resolve it
4834 and store it in `GenericType' before creating the MemberCache.
4835 (Interface.GetMembers): If we have a `GenericType', call
4836 TypeManager.FindMembers() on it.
4838 2004-01-22 Martin Baulig <martin@ximian.com>
4840 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4841 not a QualifiedIdentifier. This is what `type_name_expression'
4842 was previously doing.
4843 (type_name_expression): Removed; the code is now in
4844 `namespace_or_type_name'.
4845 (qualified_identifier): Removed, use `namespace_or_type_name'
4847 (QualifiedIdentifier): Removed this class.
4849 2004-01-22 Martin Baulig <martin@ximian.com>
4851 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4852 not a string as alias name.
4854 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4856 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4857 #52730 bug, and instead compute correctly the need to use a
4858 temporary variable when requesting an address based on the
4859 static/instace modified of the field and the constructor.
4861 2004-01-21 Martin Baulig <martin@ximian.com>
4863 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4864 class and namespace before looking up aliases. Fixes #52517.
4866 2004-01-21 Martin Baulig <martin@ximian.com>
4868 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4869 assinged in a 'try'; fixes exception4.cs.
4871 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4872 * class.cs : Implemented parameter-less constructor for TypeContainer
4874 * decl.cs: Attributes are now stored here. New property OptAttributes
4876 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4878 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4880 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4882 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4883 (CSharpSignature): New method for indexer and property signature.
4885 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4887 * pending.cs (IsVirtualFilter): Faster implementation.
4889 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4891 * typemanager.cs: Avoid inclusion of same assembly more than once.
4893 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4895 * cs-parser.jay: Fixed problem where the last assembly attribute
4896 has been applied also to following declaration (class, struct, etc.)
4898 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4900 * class.cs: Added error CS0538, CS0539 reporting.
4901 Fixed crash on Microsoft runtime when field type is void.
4903 * cs-parser.jay: Added error CS0537 reporting.
4905 * pending.cs: Added error CS0535 reporting.
4906 Improved error report for errors CS0536, CS0534.
4908 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4910 Merge a few bits from the Anonymous Method MCS tree.
4912 * statement.cs (ToplevelBlock): New class for toplevel methods,
4913 will hold anonymous methods, lifted variables.
4915 * cs-parser.jay: Create toplevel blocks for delegates and for
4916 regular blocks of code.
4918 2004-01-20 Martin Baulig <martin@ximian.com>
4920 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4921 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4922 and `NeedExplicitReturn'; added `IsLastStatement'.
4923 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4924 have a `ReturnLabel' or we're not unreachable.
4926 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4927 child's reachability; don't just override ours with it. Fixes
4928 #58058 (lluis's example).
4929 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4930 InFinally(), InLoop(), InSwitch() and
4931 BreakCrossesTryCatchBoundary() methods.
4933 * statement.cs (Return): Do all error checking in Resolve().
4934 Unless we are the last statement in a top-level block, always
4935 create a return label and jump to it.
4936 (Break, Continue): Do all error checking in Resolve(); also make
4937 sure we aren't leaving a `finally'.
4938 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4939 statement in a top-level block.
4940 (Block.Flags): Added `IsDestructor'.
4941 (Block.IsDestructor): New public property.
4943 2004-01-20 Martin Baulig <martin@ximian.com>
4945 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4947 2004-01-20 Martin Baulig <martin@ximian.com>
4949 * statement.cs (Statement.ResolveUnreachable): New public method.
4950 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4951 (Block.Resolve): Resolve unreachable statements.
4953 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4955 * expression.cs: We need to fix the case where we do
4956 not have a temp variable here.
4958 * assign.cs: Only expression compound assignments need
4959 temporary variables.
4961 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4963 * flowanalysis.cs: Reduce memory allocation in a few ways:
4964 - A block with no variables should not allocate a bit
4966 - A method with no out parameters does not need any tracking
4967 for assignment of the parameters, so we need not allocate
4970 public readonly Type[] VariableTypes;
4971 public readonly string[] VariableNames;
4972 Are redundant. The data is already stored in the variable
4973 map, so we need not allocate another array for it.
4974 - We need to add alot of checks for if (params | locals) == null
4975 due to the first two changes.
4977 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4979 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4980 implement IMemoryLocation, we store a copy on a local variable and
4981 take the address of it. Patch from Benjamin Jemlich
4983 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4984 to use a special "type_name_expression" rule which reduces the
4985 number of "QualifiedIdentifier" classes created, and instead
4986 directly creates MemberAccess expressions.
4988 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4990 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4991 that fixes #52853. Null literal assignment to ValueType
4993 * class.cs (MethodData.Emit): Instead of checking the name of the
4994 method to determine if its a destructor, create a new derived
4995 class from Method called Destructor, and test for that.
4997 * cs-parser.jay: Create a Destructor object instead of a Method.
4999 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
5003 2004-01-16 Miguel de Icaza <miguel@ximian.com>
5005 * expression.cs (Binary.ResolveOperator): Perform an implicit
5006 conversion from MethodGroups to their delegate types on the
5009 * delegate.cs: Introduce a new class DelegateCreation that is the
5010 base class for `NewDelegate' and `ImplicitDelegateCreation',
5011 factor some code in here.
5013 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
5014 conversion from MethodGroups to compatible delegate types.
5016 * ecore.cs (Expression.Resolve): Do not flag error 654
5017 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
5018 we allow conversions from MethodGroups to delegate types now.
5020 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
5021 assignments in v2 either.
5023 2004-01-10 Miguel de Icaza <miguel@ximian.com>
5025 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
5026 static read-only fields in ctors.
5028 Applied patch from Benjamin Jemlich
5030 * expression.cs (UnaryMutator): Avoid leaking local variables.
5032 2004-01-09 Miguel de Icaza <miguel@ximian.com>
5034 * cs-tokenizer.cs (IsCastToken): Allow the various native types
5035 here to return true, as they can be used like this:
5039 Fixed 49836 and all the other dups
5041 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
5043 * driver.cs: Implement /win32res and /win32icon.
5045 2004-01-08 Miguel de Icaza <miguel@ximian.com>
5047 * cs-parser.jay: Add a rule to improve error handling for the
5048 common mistake of placing modifiers after the type.
5050 2004-01-07 Miguel de Icaza <miguel@ximian.com>
5052 * cs-parser.jay (interface_event_declaration): Catch
5053 initialization of events on interfaces, and report cs0068
5055 * cs-parser.jay (interface_event_declaration): Catch
5056 initialization of events.
5058 * ecore.cs: Better report missing constructors.
5060 * expression.cs (Binary.ResolveOperator): My previous bug fix had
5061 the error reporting done in the wrong place. Fix.
5063 * expression.cs (Binary.ResolveOperator): Catch the
5064 operator + (E x, E y) error earlier, and later allow for implicit
5065 conversions in operator +/- (E e, U x) from U to the underlying
5068 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
5069 52596, if the container class is abstract, the default constructor
5070 is protected otherwise its public (before, we were always public).
5072 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
5075 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
5076 Jemlich that fixes bug #52597, MCS was generating invalid code for
5077 idisposable structs. Thanks to Ben for following up with this
5080 2004-01-06 Miguel de Icaza <miguel@ximian.com>
5082 * driver.cs: Allow assemblies without code to be generated, fixes
5085 2004-01-07 Nick Drochak <ndrochak@gol.com>
5087 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
5089 2004-01-05 Miguel de Icaza <miguel@ximian.com>
5091 * cs-parser.jay: Add rules to improve error reporting if fields or
5092 methods are declared at the namespace level (error 116)
5094 * Add rules to catch event add/remove
5096 2004-01-04 David Sheldon <dave-mono@earth.li>
5098 * expression.cs: Added matching ")" to error message for
5101 2004-01-03 Todd Berman <tberman@gentoo.org>
5103 * ecore.cs, attribute.cs:
5104 Applying fix from #52429.
5106 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5108 * ecore.cs, expression.cs, statement.cs:
5109 Total rewrite of how we handle branching. We
5110 now handle complex boolean expressions with fewer
5111 jumps. As well if (x == 0) no longer emits a ceq.
5113 if (x is Foo) is much faster now, because we generate
5116 Overall, we get a pretty big improvement on our benchmark
5117 tests. The code we generate is smaller and more readable.
5119 I did a full two-stage bootstrap. The patch was reviewed
5120 by Martin and Miguel.
5122 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5124 * cs-parser.jay: Make primary_expression not take a QI.
5125 we dont need this because the member_access rule covers
5126 us here. So we replace the rule with just IDENTIFIER.
5128 This has two good effects. First, we remove a s/r conflict.
5129 Second, we allocate many fewer QualifiedIdentifier objects.
5131 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5133 * attribute.cs: Handle MarshalAs attributes as pseudo, and
5134 set the correct information via SRE. This prevents
5135 hanging on the MS runtime. Fixes #29374.
5137 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5139 * convert.cs: correctly handle conversions to value types
5140 from Enum and ValueType as unboxing conversions.
5142 Fixes bug #52569. Patch by Benjamin Jemlich.
5144 2004-01-02 Ravi Pratap <ravi@ximian.com>
5146 * expression.cs (BetterConversion): Prefer int -> uint
5147 over int -> ulong (csc's behaviour). This fixed bug #52046.
5149 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
5151 * decl.cs (MemberCache.FindMembers): now returns a
5154 * typemanager.cs: In general, go with with ^^.
5155 (CopyNewMethods): take an IList.
5156 (RealMemberLookup): Only allocate an arraylist
5157 if we copy from two sets of methods.
5159 This change basically does two things:
5160 1) Fewer array lists allocated due to CopyNewMethods.
5161 2) the explicit cast in MemberList costed ALOT.
5163 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
5165 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
5166 a hashtable to avoid needless string allocations when an identifier is
5167 used more than once (the common case).
5169 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5171 * pending.cs: MS's TypeBuilder.GetInterfaces ()
5172 is broken, it will not return anything. So, we
5173 have to use the information we have in mcs to
5176 * typemanager.cs: Add a cache for GetInterfaces,
5177 since this will now be used more often (due to ^^)
5179 (GetExplicitInterfaces) New method that gets the
5180 declared, not effective, interfaces on a type
5181 builder (eg, if you have interface IFoo, interface
5182 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
5185 This patch makes MCS able to bootstrap itself on
5188 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5190 * expression.cs: Remove the Nop's that Miguel put
5193 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5195 * report.cs, codegen.cs: Give the real stack trace to
5196 the error when an exception is thrown.
5198 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5200 * decl.cs: only allocate hashtables for ifaces if
5203 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5205 * expression.cs: fix the error from cs0121-2.cs
5206 (a parent interface has two child interfaces that
5207 have a function with the same name and 0 params
5208 and the function is called through the parent).
5210 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
5212 * class.cs, rootcontext.cs, typmanager.cs: do not
5215 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
5217 * codegen.cs: remove stack for the ec flow branching.
5218 It is already a linked list, so no need.
5220 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
5222 * Makefile: Allow custom profiler here.
5224 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5226 * typemanager.cs (LookupType):
5227 - Use a static char [], because split takes
5228 a param array for args, so it was allocating
5230 - Do not store true in a hashtable, it boxes.
5232 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5234 * flowanalysis.cs: bytify common enums.
5236 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5238 * modifiers.cs: Add a new set of flags for the
5239 flags allowed on explicit interface impls.
5240 * cs-parser.jay: catch the use of modifiers in
5241 interfaces correctly.
5242 * class.cs: catch private void IFoo.Blah ().
5244 All related to bug #50572.
5246 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5248 * decl.cs: Rewrite the consistant accessability checking.
5249 Accessability is not linear, it must be implemented in
5250 a tableish way. Fixes #49704.
5252 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5254 * expression.cs: Handle negation in a checked context.
5255 We must use subtraction from zero. Fixes #38674.
5257 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5259 * class.cs: Ignore static void main in DLLs.
5260 * rootcontext.cs: Handle the target type here,
5261 since we are have to access it from class.cs
5262 * driver.cs: account for the above.
5264 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5266 * report.cs: Give line numbers and files if available.
5268 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5270 * driver.cs: Implement /addmodule.
5272 * typemanager.cs: Change 'modules' field so it now contains Modules not
5275 2003-12-20 Martin Baulig <martin@ximian.com>
5277 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5278 (FieldBase.IsAssigned): Removed this field.
5279 (FieldBase.SetAssigned): New public method.
5280 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5282 2003-12-20 Martin Baulig <martin@ximian.com>
5284 * expression.cs (LocalVariableReference.DoResolve): Don't set
5285 `vi.Used' if we're called from DoResolveLValue().
5287 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5288 returns the usage vector it just merged into the current one -
5289 pass this one to UsageWarning().
5290 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5291 of the `EmitContext', don't call this recursively on our children.
5293 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5295 * driver.cs: Implement /target:module.
5297 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5299 * support.cs (CharArrayHashtable): New helper class.
5301 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5302 char arrays, not strings, so we can avoid creating a string in
5303 consume_identifier if the identifier is a keyword.
5305 2003-12-16 Martin Baulig <martin@ximian.com>
5307 * statement.cs (LocalInfo.Assigned): Removed this property.
5308 (LocalInfo.Flags): Removed `Assigned'.
5309 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5310 and uses flow analysis.
5311 (Block.UsageWarning): Made this method private.
5312 (Block.Resolve): Call UsageWarning() if appropriate.
5314 * expression.cs (LocalVariableReference.DoResolve): Always set
5315 LocalInfo.Used here.
5317 2003-12-13 Martin Baulig <martin@ximian.com>
5319 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5320 any value here; we're now using flow analysis to figure out
5321 whether a statement/block returns a value.
5323 2003-12-13 Martin Baulig <martin@ximian.com>
5325 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5327 (FlowBranching.MergeFinally): Don't call
5328 `branching.CheckOutParameters()' here, this is called in
5330 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5331 when adding the `finally' vector.
5333 2003-12-13 Martin Baulig <martin@ximian.com>
5336 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5337 actually work and also fix #48962.
5339 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5341 * decl.cs: Do not check System.Object for nested types,
5342 since we know it does not have any. Big bang for buck:
5347 corlib: 17.99 seconds
5351 corlib: 17.39 seconds
5353 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5355 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5356 time we are returning 0 members, so we save alot here.
5358 2003-12-11 Martin Baulig <martin@ximian.com>
5360 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5361 `MergeChild()', also just take the `FlowBranching' as argument;
5362 call Merge() on it and return the result.
5363 (FlowBranching.Merge): We don't need to do anything if we just
5366 2003-12-11 Martin Baulig <martin@ximian.com>
5368 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5369 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5370 Maurer for this idea.
5372 2003-12-11 Martin Baulig <martin@ximian.com>
5374 * flowanalysis.cs (MergeResult): This class is now gone; we now
5375 use the `UsageVector' for this. The reason for this is that if a
5376 branching just has one sibling, we don't need to "merge" them at
5377 all - that's the next step to do.
5378 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5381 2003-12-11 Martin Baulig <martin@ximian.com>
5383 Reworked flow analyis and made it more precise and bug-free. The
5384 most important change is that we're now using a special `Reachability'
5385 class instead of having "magic" meanings of `FlowReturns'. I'll
5386 do some more cleanups and optimizations and also add some more
5387 documentation this week.
5389 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5390 largely reworked this class.
5391 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5392 the new `Reachability' class instead of having "magic" values here.
5393 (FlowBranching): We're now using an instance of `Reachability'
5394 instead of having separate `Returns', `Breaks' etc. fields.
5396 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5397 based on flow analysis; ignore the return value of block.Emit ().
5399 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5401 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5402 if they are private.
5404 2003-12-09 Martin Baulig <martin@ximian.com>
5406 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5407 call them directly on the UsageVector.
5409 2003-12-09 Martin Baulig <martin@ximian.com>
5411 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5412 Changed return type from `FlowReturns' to `Reachability'.
5414 2003-12-09 Martin Baulig <martin@ximian.com>
5416 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5417 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5418 `Reachable' fields with a single `Reachability' one.
5420 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5422 * class.cs (FindMembers): Remove foreach's.
5435 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5440 This patch does a few things:
5441 1. EmptyStatement is now a singleton, so it is never reallocated.
5442 2. All blah is EmptyStatement constructs have been changed to
5443 blah == EmptyStatement.Value, which is much faster and valid
5444 now that EmptyStatement is a singleton.
5445 3. When resolving a block, rather than allocating a new array for
5446 the non-empty statements, empty statements are replaced with
5447 EmptyStatement.Value
5448 4. Some recursive functions have been made non-recursive.
5449 Mainly the performance impact is from (3), however (1) and (2) are needed for
5450 this to work. (4) does not make a big difference in normal situations, however
5451 it makes the profile look saner.
5456 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5457 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5458 Total memory allocated: 56397 KB
5461 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5462 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5463 Total memory allocated: 55666 KB
5465 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5467 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5468 than the hashtable in a hashtable version
5470 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5471 we always end up concating a string. This results in a huge perf
5472 loss, because many strings have to be tracked by the GC. In this
5473 patch, we first use a hashtable that works with two keys, so that
5474 the strings do not need to be concat'ed.
5485 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5487 * Makefile: Add a new target `do-time' that does a quick and simple
5488 profile, leaving easy to parse output.
5490 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5492 * codegen.cs (Init): Create the dynamic assembly with
5493 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5495 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5497 * support.cs: Make the PtrHashtable use only one
5498 instance of its comparer.
5500 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5502 * typemanager.cs: Fix lookup of GetNamespaces.
5504 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5506 * expression.cs: Removed redundant line.
5508 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5509 ArrayLists, use for loops with bounds.
5511 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5514 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5515 arraylists, use for loop with bounds.
5517 The above three changes give us a 0.071 second performance
5518 improvement out of 3.294 seconds down to 3.223. On my machine
5519 the above changes reduced the memory usage by 1,387 KB during
5522 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5523 QualifiedIdentifiers. Before we created a new string through
5524 concatenation, and mostly later on, the result would be
5525 manipulated by DecomposeQI through string manipulation.
5527 This reduced the compiler memory usage for bootstrapping from
5528 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5529 compile times in 0.05 seconds.
5531 2003-11-28 Dick Porter <dick@ximian.com>
5533 * support.cs: Do string compares with the Invariant culture.
5541 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5542 the comparison is done with the Invariant culture.
5544 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5546 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5547 GetEnumerator method.
5549 (ProbeCollectionType): Iterate starting at the most specific type
5550 upwards looking for a GetEnumerator
5552 * expression.cs: Shift count can be up to 31 for int/uint and 63
5555 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5557 * statement.cs (Block.LookupLabel): Also look for the label on the
5558 children blocks. Use a hash table to keep track of visited
5561 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5562 we actually did transform the other operand, otherwise fall back
5563 to the common codepath that casts to long.
5565 * cs-tokenizer.cs: Use the same code pattern as the int case.
5566 Maybe I should do the parsing myself, and avoid depending on the
5567 Parse routines to get this done.
5569 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5571 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5572 which fixes bug 51347. This time test it.
5574 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5575 attributes for example can not tell the difference between these.
5576 The difference was only a syntax feature of the language.
5578 * attribute.cs: Apply attributes to delegates.
5580 * delegate.cs: Call the apply attributes method.
5582 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5584 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5585 comparing 0 vs Byte.MinValue, not the value
5587 (ImplicitConversionRequired): When reporting a conversion error,
5588 use error 31 to print out the constant error instead of the
5591 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5592 which fixes bug 51347.
5594 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5596 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5597 which fixes the -warnaserror command line option.
5599 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5601 * cfold.cs (DoNumericPromotions): During constant folding of
5602 additions on UIntConstant, special case intconstants with
5603 IntConstants like we do on the expression binary operator.
5605 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5607 * convert.cs (ImplicitReferenceConversion): We were missing a case
5608 (System.Enum are not value types or class types, so we need to
5609 classify them separatedly).
5611 * driver.cs: We do not support error 2007.
5613 2003-11-12 Jackson Harper <jackson@ximian.com>
5615 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5616 system directory. Also use the full file name so users can
5617 libraries names mscorlib-o-tron.dll in a non system dir.
5619 2004-01-04 David Sheldon <dave-mono@earth.li>
5621 * expression.cs: Added matching ")" to error message for CS0077.
5623 2003-12-19 Martin Baulig <martin@ximian.com>
5625 * typemanager.cs (TypeManager.IsEqualGenericType): New public
5626 static method; see documentation in the method.
5627 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
5629 * convert.cs (Convert.ImplicitReferenceConversion,
5630 Convert.ImplicitReferenceConversionExists): Add support for
5631 generic type declarations; see gen-36.cs.
5633 2003-12-19 Martin Baulig <martin@ximian.com>
5635 * pending.cs (Pending.InterfaceMethod): Use
5636 `Type.IsAssignableFrom()' instead of `=='.
5638 2003-12-18 Martin Baulig <martin@ximian.com>
5640 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
5643 * convert.cs (Convert.ImplicitStandardConversionExists): Use
5644 `expr_type.Equals (target_type)' instead of `=='.
5646 2003-12-08 Martin Baulig <martin@ximian.com>
5648 * generics.cs (Constraints.Types): Removed.
5649 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
5651 (Constraints.ResolveTypes): New public method; resolves the
5652 TypeExpr's to Type's.
5653 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
5654 longer takes the constraints.
5655 (TypeParameter.DefineMethod): Likewise.
5656 (TypeParameter.DefineType): New public method. Calls
5657 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
5660 2003-12-08 Martin Baulig <martin@ximian.com>
5662 * convert.cs (Convert.ImplicitConversionStandard): Use
5663 `expr_type.Equals (target_type)' instead of `=='.
5665 2003-12-08 Martin Baulig <martin@ximian.com>
5667 * typemanager.cs (TypeManager.GetReferenceType): Call
5668 `Type.MakeByRefType ()'.
5670 2003-12-08 Martin Baulig <martin@ximian.com>
5672 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
5673 just has some special meaning in some situations. For instance,
5674 it is allowed to use `where' as the name of a variable etc.
5676 2003-12-04 Martin Baulig <martin@ximian.com>
5678 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
5679 `Type.MakeArrayType()' for array types.
5681 2003-11-18 Miguel de Icaza <miguel@ximian.com>
5683 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
5686 (SizeOf.DoResolve): assign the `type_queried' field. This gets
5689 2003-11-16 Martin Baulig <martin@ximian.com>
5691 * codegen.cs (EmitContext.IsGeneric): Removed.
5693 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
5694 ResolveGeneric() on the DeclSpace.
5696 2003-11-16 Martin Baulig <martin@ximian.com>
5698 * generic.cs (TypeArguments.Resolve):
5699 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
5700 `ResolveType()' on it to get the Type.
5702 2003-11-15 Martin Baulig <martin@ximian.com>
5704 * generic.cs (ConstructedType.GetInterfaces): Override this.
5706 2003-11-14 Martin Baulig <martin@ximian.com>
5708 * interface.cs (Interface.DefineType): Define all type parameters
5709 before adding the interfaces we inherit.
5711 2003-11-11 Martin Baulig <martin@ximian.com>
5713 * generic.cs (ConstructedType.ResolveType): Always call
5714 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
5716 2003-11-10 Martin Baulig <martin@ximian.com>
5718 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5719 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5720 calling `ResolveType()' on them, directly assign their `Type'.
5722 2003-11-08 Martin Baulig <martin@ximian.com>
5724 * generic.cs (ConstructedType): Override `IsClass' etc.
5726 2003-11-08 Martin Baulig <martin@ximian.com>
5728 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5729 return value and the `out parent' parameter.
5730 (TypeContainer.DefineType): Moved the CS0644 check into
5731 GetClassBases(). Don't pass the interface types to the
5732 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5733 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5735 * ecore.cs (TypeExpr.IsAttribute): New property.
5736 (TypeExpr.GetInterfaces): New method.
5738 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5739 TypeExpr instead of a Type.
5740 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5741 (Interface.DefineType): Don't pass the interface types to the
5742 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5743 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5745 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5746 instead of a `Type[]'.
5747 (TypeManager.RegisterBuilder): Likewise.
5748 (TypeManager.AddUserInterface): Likewise.
5749 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5750 `Type[]' and also return a `TypeExpr[]'.
5751 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5753 2003-11-08 Martin Baulig <martin@ximian.com>
5755 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5758 2003-11-08 Martin Baulig <martin@ximian.com>
5760 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5761 TypeManager.ResolveExpressionTypes().
5763 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5764 instead of an Expression.
5765 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5766 (TypeExpression): New public class; formerly known as `TypeExpr'.
5768 * expression.cs (ComposedCast): Derive from TypeExpr.
5770 * typemanager.cs (TypeManager.system_*_expr): These are now
5771 TypExpr's instead of Expression's.
5772 (TypeManager.ResolveExpressionTypes): New public static function;
5773 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5776 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5778 * expression.cs (New.DoResolve): Do not dereference value that
5779 might be a null return.
5781 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5782 sure that the constant value has the right type. Fixes an
5783 unreported bug, similar to 50425.
5785 * const.cs (Const.LookupConstantValue): Call
5786 ImplicitStandardConversionExists before doing a conversion to
5787 avoid havng the TypeManager.ChangeType do conversions.
5789 Reduced the number of casts used
5791 (Const.ChangeType): New routine to enable reuse of the constant
5792 type changing code from statement.
5794 * typemanager.cs (ChangeType): Move common initialization to
5795 static global variables.
5799 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5800 every value type to go through, even if it was void. Fix that.
5802 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5803 character of the define, and the is_identifier_part_character for
5804 the rest of the string.
5806 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5808 * expression.cs (UnaryMutator.EmitCode): When I updated
5809 LocalVariableReference.DoResolve, I overdid it, and dropped an
5810 optimization done on local variable references.
5812 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5814 * ecore.cs: Convert the return from Ldlen into an int.
5816 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5818 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5819 the accessibility, this is a special case for toplevel non-public
5820 classes (internal for instance).
5822 2003-10-20 Nick Drochak <ndrochak@gol.com>
5824 * ecore.cs: Fix typo and build. Needed another right paren.
5826 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5828 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5829 `internal' case regular and protected, but not allowing protected
5830 to be evaluated later. Bug 49840
5832 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5834 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5835 to kb.Nlast, and not the kb.nFirst to isolate the switch
5838 Extract the underlying type, so enumerations of long/ulong are
5839 treated like long/ulong.
5841 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5843 * expression.cs (New): Overload the meaning of RequestedType to
5844 track the possible creation of the NewDelegate type, since
5845 DoResolve is invoked more than once for new constructors on field
5848 See bugs: #48800 and #37014
5850 * cs-parser.jay (declare_local_constants): Take an arraylist
5851 instead of a single constant.
5853 (local_constant_declaration): It should take a
5854 constant_declarators, not a constant_declarator. Fixes 49487
5856 * convert.cs: Fix error report.
5858 2003-10-13 Jackson Harper <jackson@ximian.com>
5860 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5863 2003-11-03 Martin Baulig <martin@ximian.com>
5865 * expression.cs (ArrayAccess.GetStoreOpcode): Added
5866 `out bool has_type_arg'; if set, we need to pass the type to
5868 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
5869 Stelem_Any/Ldelem_Any for generic parameters.
5871 2003-11-02 Martin Baulig <martin@ximian.com>
5873 * expression.cs (Invocation.EmitCall): Use
5874 `TypeManager.IsValueType()' to check whether it's a value type.
5875 Don't set `struct_call' when calling a method on a type parameter.
5877 2003-11-02 Martin Baulig <martin@ximian.com>
5879 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
5880 and removed the TypeBuilder argument.
5882 * typemanager.cs (TypeManager.IsValueType): Return
5883 `t.IsGenericParameter || t.IsValueType'.
5885 2003-10-25 Martin Baulig <martin@ximian.com>
5887 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
5888 call ConstructedType.Resolve() on it.
5890 * generic.cs (ConstructedType.Resolve): Set `type' on success.
5892 2003-10-25 Martin Baulig <martin@ximian.com>
5894 * class.cs (TypeContainer.GetClassBases): Changed
5895 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
5896 CS8214 reporting here.
5897 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
5898 instead of a `Type' for our parent. In case of a recursive
5899 declaration (see tests/gen-23.cs for an example), our parent is a
5900 ConstructedType and it doesn't have its type set. So, first
5901 create our own TypeBuilder, then call constructed.Resolve() to get
5902 the parent's type and finally TypeBuilder.SetParent() it.
5904 * ecore.cs (TypeExpr.Name): New public virtual property.
5907 (ConstructedType): We're now a TypeExpr and not just an Expression.
5908 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
5909 arguments here; this is done later.
5910 (ConstructedType.Resolve): New public method to resolve the type
5911 arguments and bind them.
5913 2003-10-21 Martin Baulig <martin@ximian.com>
5915 * convert.cs: Use `TypeManager.IsValueType' instead of
5916 'type.IsValueType' everywhere.
5918 * typemanager.cs (TypeManager.IsValueType): Return true for type
5919 parameters. The reason for this is that we need to box a type
5920 parameter when converting it to a reference type.
5922 * cs-parser.jay: Added support for default value expressions.
5924 * generics.cs (DefaultValueExpression): New public class.
5926 2003-10-17 Martin Baulig <martin@ximian.com>
5928 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
5929 TypeContainer so we can also use this for Interfaces.
5930 (TypeParameter.Resolve): Likewise.
5932 * interface.cs (Interface.DefineType): Added support for generic
5935 * cs-parser.jay: Added support for generic structs and interfaces.
5937 2003-10-17 Martin Baulig <martin@ximian.com>
5939 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
5940 call generic methods :-)
5942 2003-10-16 Martin Baulig <martin@ximian.com>
5944 * cs-parser.jay (namespace_or_type_name): Only create a
5945 GenericMemberAccess if we actually have type arguments.
5947 2003-10-13 Martin Baulig <martin@ximian.com>
5949 * class.cs (Method.Define): If we're a generic method, call
5950 TypeBuilder.DefineGenericMethod () before resolving
5952 (MethodData): Added .ctor which takes an additional MethodBuilder
5953 argument; this is used for generic methods.
5954 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
5955 we already have a MethodBuilder.
5957 2003-10-10 Martin Baulig <martin@ximian.com>
5959 * class.cs (Method): Added .ctor which takes a `GenericMethod'
5960 instead of a `DeclSpace'. This is used for generic methods.
5962 * cs-parser.jay (method_header): Added support for generic
5963 methods; create a `GenericMethod' instance and pass it to the
5964 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
5965 parameters and locals.
5967 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
5968 since we already have the location. Check whether we're a generic
5969 type declaration or a generic method and create the correct type
5972 * generic.cs (TypeParameter.DefineMethod): New public method.
5973 (GenericMethod): New public class; derives from DeclSpace and is
5974 used for generic methods.
5976 2003-10-09 Martin Baulig <martin@ximian.com>
5978 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5980 (MethodCore.DoDefineParameters): Removed the TypeContainer
5981 argument; use the DeclSpace which was passed to the .ctor instead.
5982 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5983 TypeContainer; we only need a DeclSpace here.
5985 2003-10-09 Martin Baulig <martin@ximian.com>
5987 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5989 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5990 EmitContext's .ctor.
5992 2003-10-09 Martin Baulig <martin@ximian.com>
5994 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5995 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5996 AsAccessible(), moved them as well.
5998 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
6000 2003-10-07 Miguel de Icaza <miguel@ximian.com>
6002 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
6003 generation for >=, as spotted by Paolo, bug 48679.
6004 Patch from David Waite.
6006 * cs-tokenizer.cs: Add handling for #pragma.
6008 * cs-parser.jay: Allow for both yield and yield return in the
6009 syntax. The anti-cobolization of C# fight will go on!
6011 * class.cs (TypeBuilder.DefineType): Catch error condition here
6012 (Parent.DefineType erroring out and returning null).
6014 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6015 coping with enumerations variables, we were mistakenly processing
6016 them as a regular value type instead of built-in types. Fixes the
6019 * typemanager.cs (IsBuiltinOrEnum): New method.
6021 2003-09-30 Miguel de Icaza <miguel@ximian.com>
6023 * cs-parser.jay: Upgrade: yield now needs the return clause.
6025 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
6027 * cs-parser.jay : Renamed yyName to yyNames related to jay.
6029 2003-09-29 Martin Baulig <martin@ximian.com>
6031 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
6032 inflated generic methods.
6034 * generics.cs (ConstructedType): Distinguish between open and
6035 closed constructed types; correctly resolve the arguments.
6037 2003-09-22 Martin Baulig <martin@ximian.com>
6039 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
6040 all type arguments meet their constraints.
6042 2003-09-19 Martin Baulig <martin@ximian.com>
6044 * decl.cs (MemberCache.SetupCacheForInterface): Take a
6045 `MemberCache parent' argument. Normally, an interface doesn't
6046 have a parent type except System.Object, but we use this in gmcs
6047 for generic type parameters.
6049 2003-09-18 Martin Baulig <martin@ximian.com>
6051 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
6052 on `type.IsInterface'; don't check whether the type has a parent
6053 to determine whether it's an interface.
6055 2003-09-17 Martin Baulig <martin@ximian.com>
6057 * generic.cs (ConstructedType.ToString): Always use `name' as the
6060 2003-09-15 Martin Baulig <martin@ximian.com>
6062 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
6064 * generic.cs (Constraints.Resolve): New public method; this is
6065 called to resolve the constraint types and to check whether all
6066 the constraints are correct.
6067 (Constraints.Types): New public property.
6068 (TypeParameter.Resolve): New public method; resolves all the
6071 * class.cs (TypeContainer.DefineType): Call
6072 TypeParameter.Resolve() before actually defining the type.
6074 2003-09-15 Martin Baulig <martin@ximian.com>
6076 * class.cs (TypeContainer.DefineType): Added an error flag to
6077 avoid reporting duplicate CS0146's ("class definition is
6080 * driver.cs (Driver.MainDriver): Abort if
6081 RootContext.ResolveTree() reported any errors.
6083 2003-09-07 Martin Baulig <martin@ximian.com>
6085 * report.cs (Error, Warning): Added overloaded versions which take
6086 a `params object[] args' and call String.Format().
6088 2003-09-07 Martin Baulig <martin@ximian.com>
6090 * decl.cs (DeclSpace..ctor): Don't call
6091 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
6092 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
6093 (DeclSpace.RecordDecl): New method.
6095 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
6097 2003-09-02 Ravi Pratap <ravi@ximian.com>
6099 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
6100 value attributes to be applied to ParameterBuilders.
6102 * class.cs (MethodCore.LabelParameters): Make static and more
6103 generic so that it can be used from other places - like interface
6104 methods, for instance.
6106 * interface.cs (Interface.Emit): Call LabelParameters before
6107 emitting attributes on the InterfaceMethod.
6109 2003-09-07 Martin Baulig <martin@ximian.com>
6111 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
6112 if the number of type parameters doesn't match.
6114 2003-09-04 Martin Baulig <martin@ximian.com>
6116 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
6117 for arrays of generic type params (ie. `!0[]').
6119 2003-09-04 Martin Baulig <martin@ximian.com>
6121 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
6124 2003-09-04 Martin Baulig <martin@ximian.com>
6126 * decl.cs (DeclSpace.LookupGeneric): New method.
6127 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
6130 * generic.cs (TypeParameterExpr): Take a TypeParameter as
6131 argument, not just a string.
6132 (TypeParameter.Define): New public method; this is called to
6133 actually define the generic parameter; after this, you can use the
6134 new `Type' property to get the type.
6136 2003-09-04 Martin Baulig <martin@ximian.com>
6138 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
6139 is now an ArrayList; initialize the result of the `TypeParameters'
6141 (DeclSpace.GetGenericData): Removed.
6142 (DeclSpace.LookupGeneric): Temporarily removed; we need to
6143 implement this in a different way.
6144 (DeclSpace.GetTypeParameters): Removed; there's now a
6145 `TypeParameters' property.
6146 (DeclSpace.TypeParameters): New public property.
6148 * generic.cs (Constraints): Make this class public.
6149 (TypeParameter): New public class.
6151 2003-09-04 Martin Baulig <martin@ximian.com>
6153 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
6156 * class.cs (TypeContainer.DefineType): Call
6157 TypeBuilder.DefineGenericParameter () on all generic parameters if
6158 this is a generic type.
6160 2003-08-28 Martin Baulig <martin@ximian.com>
6162 * sample-stack.il: Compile this with ilasm: "ilasm /dll
6165 * sample-hello.cs: Compile this with gmcs: "gmcs
6166 /r:sample-stack.dll sample-hello.cs".
6168 2003-08-28 Martin Baulig <martin@ximian.com>
6170 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
6171 the parameters to the generic type.
6173 2003-08-28 Martin Baulig <martin@ximian.com>
6175 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
6177 2003-08-28 Martin Baulig <martin@ximian.com>
6179 * cs-parser.jay (opt_type_argument_list): Use
6180 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
6181 (primary_expression): Replace `qualified_identifier' with `type_name'.
6182 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
6184 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
6185 parser to check whether it is syntactically a type parameter list;
6186 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
6189 2003-08-26 Martin Baulig <martin@ximian.com>
6191 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
6192 resolving aliases; fixes #47927.
6194 2003-08-26 Martin Baulig <martin@ximian.com>
6196 * statement.cs (Using.DoResolve): This is internally emitting a
6197 try/finally clause, so we need to set ec.NeedExplicitReturn if we
6198 do not always return. Fixes #47681.
6200 2003-08-26 Martin Baulig <martin@ximian.com>
6202 * decl.cs (MemberCore): Moved WarningNotHiding(),
6203 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
6205 (AdditionResult): Make this nested in DeclSpace.
6206 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
6207 argument; call NamespaceEntry.Define() unless we're nested in a
6210 * namespace.cs (Namespace.DefineName): New public function. This
6211 is called from DeclSpace's .ctor to add
6212 (Namespace.Lookup): Include DeclSpaces in the lookup.
6214 * class.cs (Operator): Derive from MemberBase, not MemberCore.
6216 * const.cs (Const): Derive from MemberBase, not MemberCore.
6218 2003-08-25 Martin Baulig <martin@ximian.com>
6220 * convert.cs (Convert.ExplicitReferenceConversion): When
6221 converting from an interface type to a class, unbox if the target
6222 type is a struct type. Fixes #47822.
6224 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6226 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
6229 2003-08-22 Martin Baulig <martin@ximian.com>
6231 * class.cs (TypeManager.DefineType): When defining a nested type,
6232 call DefineType() on our parent; fixes #47801.
6234 2003-08-22 Martin Baulig <martin@ximian.com>
6236 * class.cs (MethodData.Define): While checking if a method is an
6237 interface implementation, improve the test a bit more to fix #47654.
6239 2003-08-22 Martin Baulig <martin@ximian.com>
6241 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
6242 correctly; fixes #47722.
6244 2003-08-22 Martin Baulig <martin@ximian.com>
6246 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
6247 LocalVariableReference, ensure it's not read-only. Fixes #47536.
6249 * statement.cs (Fixed.DoResolve): Make all variables read-only.
6251 2003-08-22 Martin Baulig <martin@ximian.com>
6253 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
6254 can only be assigned in static constructors. Fixes #47161.
6256 2003-08-22 Martin Baulig <martin@ximian.com>
6258 Rewrote and improved the flow analysis code.
6260 * flowbranching.cs (FlowBranching): Make this class abstract.
6261 (FlowBranching.CreateBranching): New static function to create a
6263 (FlowBranchingBlock, FlowBranchingException): New classes.
6264 (FlowBranching.UsageVector.Type): New public readonly field.
6265 (FlowBranching.UsageVector.Breaks): Removed the setter.
6266 (FlowBranching.UsageVector.Returns): Removed the setter.
6267 (FlowBranching.UsageVector): Added Break(), Return(),
6268 NeverReachable() and Throw() methods to modify the reachability.
6269 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
6270 done by FlowBranching.Merge().
6271 (FlowBranching.UsageVector.MergeChild): New method; merges the
6272 merge result into the current vector.
6273 (FlowBranching.Merge): New abstract method to merge a branching.
6275 2003-08-12 Martin Baulig <martin@ximian.com>
6277 * expression.cs (Indirection.CacheTemporaries): Create the
6278 LocalTemporary with the pointer type, not its element type.
6280 2003-08-10 Miguel de Icaza <miguel@ximian.com>
6282 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
6283 token was a keyword or not.
6285 Add `error' options where an IDENTIFIER was expected; Provide
6286 CheckToken and CheckIdentifierToken convenience error reporting
6289 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
6291 * decl.cs: Rename `NamespaceEntry Namespace' public field into
6292 NameSpaceEntry NameSpaceEntry.
6294 (LookupInterfaceOrClass): Avoid creating a full qualified name
6295 from namespace and name: avoid doing lookups when we know the
6296 namespace is non-existant. Use new Tree.LookupByNamespace which
6297 looks up DeclSpaces based on their namespace, name pair.
6299 * driver.cs: Provide a new `parser verbose' to display the
6300 exception thrown during parsing. This is turned off by default
6301 now, so the output of a failure from mcs is more graceful.
6303 * namespace.cs: Track all the namespaces defined in a hashtable
6306 (IsNamespace): New method
6308 2003-08-09 Miguel de Icaza <miguel@ximian.com>
6310 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
6311 we know that we need to concatenate (full typename can never be
6316 * statement.cs: Use a bitfield; Do not initialize to null things
6317 which are done by the constructor by default.
6319 * cs-parser.jay: bug fix, parameter was 4, not 3.
6321 * expression.cs: Just use the property;
6323 * statement.cs: No need for GetVariableInfo method.
6325 2003-08-08 Martin Baulig <martin@ximian.com>
6327 * flowanalysis.cs (FlowReturns): This is now nested in the
6328 `FlowBranching' class.
6329 (MyBitVector): Moved this here from statement.cs.
6330 (FlowBranching.SiblingType): New enum type.
6331 (FlowBranching.CreateSibling): Added `SiblingType' argument.
6333 2003-08-07 Martin Baulig <martin@ximian.com>
6335 * flowanalysis.cs (FlowBranchingType): This is now nested in the
6336 `FlowBranching' class and called `BranchingType'.
6338 2003-08-07 Martin Baulig <martin@ximian.com>
6340 * flowanalysis.cs: Moved all the control flow analysis code into
6343 2003-08-07 Martin Baulig <martin@ximian.com>
6345 * assign.cs (Assign.DoResolve): `target' must either be an
6346 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
6349 2003-08-07 Miguel de Icaza <miguel@ximian.com>
6351 * expression.cs (BinaryMethod): This kind of expression is created by the
6352 Binary class if it determines that the operator has to be handled
6355 (BinaryDelegate): This kind of expression is created if we are
6356 dealing with a + or - operator on delegates.
6358 (Binary): remove method, argumetns, and DelegateOperator: when
6359 dealing with methods,
6361 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
6363 * statement.cs (Block): use bitfields for the three extra booleans
6364 we had in use. Remove unused topblock parameter.
6366 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
6368 * assign.cs: Drop extra unneeded tests.
6370 2003-08-06 Miguel de Icaza <miguel@ximian.com>
6372 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
6374 * statement.cs (Foreach): Use VariableStorage instead of
6377 * codegen.cs (VariableStorage): New class used by clients that
6378 require a variable stored: locals or fields for variables that
6379 need to live across yield.
6381 Maybe provide a convenience api for EmitThis+EmitLoad?
6383 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
6386 2003-08-05 Miguel de Icaza <miguel@ximian.com>
6388 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
6389 RemapParameterLValue): New methods that are used to turn a
6390 precomputed FieldInfo into an expression like this:
6394 The idea is to use this instead of making LocalVariableReference
6395 have more than one meaning.
6397 * cs-parser.jay: Add error production to BASE.
6399 * ecore.cs: Deal with TypeManager.GetField returning null, which
6400 is now a valid return value.
6402 (FieldExprNoAddress): New expression for Fields whose address can
6405 * expression.cs (LocalVariableReference): During the resolve
6406 phases, create new expressions if we are in a remapping context.
6407 Remove code that dealt with remapping here.
6409 (ParameterReference): same.
6411 (ProxyInstance): New expression, like the `This' expression, but
6412 it is born fully resolved. We know what we are doing, so remove
6413 the errors that are targeted to user-provided uses of `this'.
6415 * statement.cs (Foreach): our variable is now stored as an
6416 Expression; During resolution, follow the protocol, dont just
6417 assume it will return this.
6419 2003-08-06 Martin Baulig <martin@ximian.com>
6421 * support.cs (SeekableStreamReader.cs): New public class.
6423 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
6424 SeekableStreamReader instead of the normal StreamReader.
6426 2003-08-04 Martin Baulig <martin@ximian.com>
6428 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
6429 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
6430 deambiguate casts and delegate invocations.
6431 (parenthesized_expression): Use the new tokens to ensure this is
6432 not a cast of method invocation.
6434 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
6435 when reading a `)' and Deambiguate_CloseParens () was previously
6438 * expression.cs (ParenthesizedExpression): New class. This is
6439 just used for the CS0075 test.
6440 (Binary.DoResolve): Check for CS0075.
6442 2003-07-29 Ravi Pratap <ravi@ximian.com>
6444 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
6445 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
6446 reference comparison.
6448 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
6449 examine the ReturnType for equality - this is necessary in the
6450 cases of implicit and explicit operators whose signature also
6451 includes the return type.
6453 2003-07-26 Miguel de Icaza <miguel@ximian.com>
6455 * namespace.cs: Cache the result of the namespace computation,
6456 instead of computing it every time.
6458 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6460 * decl.cs: Use a global arraylist that we reuse over invocations
6461 to avoid excesive memory consumption. Reduces memory usage on an
6462 mcs compile by one meg (45 average).
6464 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6465 private, work around that.
6467 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6469 * literal.cs (IntLiteral): Define Zero and One static literals.
6471 * cs-parser.jay (integer_literal): use static literals to reduce
6472 memory usage for the most used literals (0, 1 and -1). 211kb
6473 reduced in memory usage.
6475 Replace all calls to `new ArrayList' with `new
6476 ArrayList(4)' which is a good average number for most allocations,
6477 and also requires only 16 bytes of memory for its buffer by
6480 This reduced MCS memory usage in seven megabytes for the RSS after
6483 2003-07-28 Ravi Pratap <ravi@ximian.com>
6485 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6486 handle params methods the correct way by forming only one
6487 applicable set with params and normal methods in them. Earlier we
6488 were looking at params methods only if we found no normal methods
6489 which was not the correct thing to do.
6491 (Invocation.BetterFunction): Take separate arguments indicating
6492 when candidate and the best method are params methods in their
6495 This fixes bugs #43367 and #46199.
6497 * attribute.cs: Documentation updates.
6499 (CheckAttribute): Rename to CheckAttributeTarget.
6500 (GetValidPlaces): Rename to GetValidTargets.
6502 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6503 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6507 2003-07-28 Miguel de Icaza <miguel@ximian.com>
6509 * codegen.cs: Compute IsGeneric correctly.
6511 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
6514 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
6515 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
6516 regressions, and I was chasing more bugs than I required.
6518 * interface.cs: Use expressions for base type names (like classes
6519 and structs have been doing for a while now), and resolve that.
6520 This patch should probably go into head as well.
6522 This makes it one less user of FindType.
6524 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6526 This compiler can not self host currently. Need to fix that.
6528 * Makefile: compile to `gmcs.exe'
6530 * driver.cs: Turn on v2 by default on gmcs.
6532 * generic.cs (ConstructedType): Does no longer take a container
6533 type argument; That will be taken care of later.
6535 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
6536 Use SimpleName to resolve for now, so we can continue the work on
6537 the parser, until we get Type.GetType that understands generics.
6539 (ConstructedType.ToString): Implement
6541 (TypeArguments.Resolve): Resolve the child expressions as types.
6543 * cs-parser.jay: Rename interface_constraints to
6544 type_parameter_constraints
6546 (namespace_or_type_name): Only use constructed types for the basic
6547 construction, we will deal with identifier<...> later.
6549 (type/type_name): No longer call DecomposeQI, as
6550 namespace_or_type_name is always decoded now.
6552 2003-07-22 Ravi Pratap <ravi@ximian.com>
6554 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6555 closely: we eliminate methods in base types when we have an
6556 applicable method in a top-level type.
6558 Please see section 14.5.5.1 for an exact description of what goes
6561 This fixes bug #45127 and a host of other related to corlib compilation.
6563 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6564 array is the method corresponding to the top-level type (this is
6565 because of the changes made to icall.c) so we change this
6568 (MethodGroupExpr.Name): This too.
6570 * typemanager.cs (GetElementType): New method which does the right
6571 thing when compiling corlib.
6573 * everywhere: Make use of the above in the relevant places.
6575 2003-07-22 Martin Baulig <martin@ximian.com>
6577 * cs-parser.jay (invocation_expression): Moved
6578 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6579 `cast_expression', but create a InvocationOrCast which later
6580 resolves to either an Invocation or a Cast.
6582 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6583 method; call this before EmitStatement() to make sure that this
6584 expression can be used as a statement.
6586 * expression.cs (InvocationOrCast): New class; resolves to either
6587 an Invocation or a Cast.
6589 * statement.cs (StatementExpression): Call ResolveStatement() on
6590 the ExpressionStatement before emitting it.
6592 2003-07-21 Martin Baulig <martin@ximian.com>
6594 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6595 `ref' and `out' attributes match; fixes #46220.
6596 (MemberAccess.ResolveMemberAccess): You can't reference a type
6597 through an expression; fixes #33180.
6598 (Indexers.GetIndexersForType): Don't return the indexers from
6599 interfaces the class implements; fixes #46502.
6601 2003-07-21 Martin Baulig <martin@ximian.com>
6603 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6604 CS0661 checks; fixes bug #30442.
6606 2003-07-21 Martin Baulig <martin@ximian.com>
6608 * decl.cs (AdditionResult): Added `Error'.
6610 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6612 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
6613 cs0031.cs actually work.
6615 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6617 * cs-parser.jay (namespace_name): do not use
6618 namespace_or_type_name, use qualified_identifier, because
6619 namespace_or_type_name will soon return a composed expression
6620 instead of a string.
6622 (namespace_or_type_name): Instead of returning a string, now this
6623 production returns an expression.
6625 * codegen.cs (EmitContext): Setup IsGeneric property based on
6626 whether our DeclSpace is generic, our the method is generic.
6628 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
6629 the method is generic.
6631 * cs-parser.jay (type_arguments, opt_type_argument_list,
6632 type_parameters, type_parameter_list, opt_type_parameter_list,
6633 type_parameter,, opt_type_parameter_constraints_clauses,
6634 type_parameter_constraints_clauses,
6635 type_parameter_constraint_clause, type_parameter_constraint,
6636 interface_constraints): Add new production
6638 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
6639 DeclSpace is generic or not.
6641 (DeclSpace.SetParameterInfo): New routine, used to set the
6642 parameter info for a type.
6644 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
6645 returns a GenericTypeExpr
6647 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
6648 generic, lookup the generic argument.
6650 * attribute.cs: Do not allow TypeParameterExpressions in
6653 * class.cs: Do not allow the Main method to be defined in a
6656 * expression.cs (SizeOf): Do not allow generic types to be used as
6657 arguments to sizeof.
6659 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
6660 it: whether a type is generic or not. Only works for types we are
6661 currently building for now.
6663 2003-07-20 Martin Baulig <martin@ximian.com>
6665 * namespace.cs: Fixed that bug which caused a crash when compiling
6668 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6670 * typemanager.cs (LookupTypeReflection): Never expose types which
6671 are NotPublic, NestedPrivate, NestedAssembly, or
6672 NestedFamANDAssem. We used to return these, and later do a check
6673 that would report a meaningful error, but the problem is that we
6674 would not get the real match, if there was a name override.
6676 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6678 * namespace.cs (Namespace, Name): Do not compute the namespace
6679 name dynamically, compute it in the constructor. This reduced
6680 memory usage by 1697 KB.
6682 * driver.cs: Use --pause to pause at the end.
6684 2003-07-17 Peter Williams <peter@newton.cx>
6686 * Makefile: Change the name of the test target so that it doesn't
6687 conflict with the recursive test target.
6689 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6691 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6692 AddressOf): Do not use EmitThis, that was wrong, use the actual
6695 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6697 * class.cs (MethodData.Define): While checking if a method is an
6698 interface implementation, improve the test: If we are not public
6699 (use new test here: use the computed MethodAttributes directly,
6700 instead of the parsed modifier flags) check if the `implementing'
6701 method comes from an interface or not.
6703 * pending.cs (VerifyPendingMethods): Slightly better error
6706 * makefile: add test target that does the mcs bootstrap.
6708 2003-07-16 Ravi Pratap <ravi@ximian.com>
6710 * interface.cs (Define): Do nothing here since there are no
6711 members to populate etc. Move the attribute emission out of here
6712 since this was just totally the wrong place to put it. Attribute
6713 application happens during the 'Emit' phase, not in the 'Define'
6716 (Emit): Add this method and move the attribute emission here
6718 * rootcontext.cs (EmitCode): Call the Emit method on interface
6721 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6723 * expression.cs (OverloadResolve): Report error only if Location
6724 is not 'Null' which means that there was a probe going on.
6726 2003-07-14 Martin Baulig <martin@ximian.com>
6728 * expression.cs (ConditionalLogicalOperator): New public class to
6729 implement user defined conditional logical operators.
6730 This is section 14.11.2 in the spec and bug #40505.
6732 2003-07-14 Martin Baulig <martin@ximian.com>
6734 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6736 2003-07-14 Martin Baulig <martin@ximian.com>
6738 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6740 * ecore.cs (IVariable.VerifyFixed): New interface method.
6742 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6743 operator, check whether the variable is actually fixed. Fixes bug
6744 #36055. Set a variable definitely assigned when taking its
6745 address as required by the spec.
6747 * statement.cs (LocalInfo.IsFixed): New field.
6748 (LocalInfo.MakePinned): Set `IsFixed' to true.
6750 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6752 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6753 for .ctors, ensure that we only ask for members declared in the
6754 attribute type (BindingFlags.DeclaredOnly).
6758 * expression.cs (Error_WrongNumArguments): Report error 1501
6759 correctly the way CSC does.
6761 2003-07-13 Martin Baulig <martin@ximian.com>
6763 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6764 lookup on the fully qualified name, to make things like "X.X" work
6765 where "X.X" is a fully qualified type name, but we also have a
6766 namespace "X" in the using list. Fixes #41975.
6768 2003-07-13 Martin Baulig <martin@ximian.com>
6770 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6771 function. If we're a CompoundAssign, we need to create an embedded
6772 CompoundAssign, not an embedded Assign.
6773 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6776 2003-07-13 Martin Baulig <martin@ximian.com>
6778 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6779 work to fix bug #46088.
6781 2003-07-13 Ravi Pratap <ravi@ximian.com>
6783 * class.cs (Operator.Emit): Do not emit attributes here - it is
6784 taken care of by the Method class that we delegate too. This takes
6787 2003-07-10 Martin Baulig <martin@ximian.com>
6789 * expression.cs (TypeOfVoid): New class.
6790 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6792 2003-07-10 Martin Baulig <martin@ximian.com>
6794 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6797 2003-07-10 Martin Baulig <martin@ximian.com>
6799 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6800 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6802 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6804 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6806 2003-07-10 Martin Baulig <martin@ximian.com>
6808 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6809 of decimal. Fixes #42850.
6811 NOTE: I also fixed the created byte blob, but this doesn't work on
6812 the MS runtime and csc never produces any byte blobs for decimal
6815 2003-07-10 Martin Baulig <martin@ximian.com>
6817 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6818 structs; fixes #32068.
6819 (Block.AddChildVariableNames): Fixed #44302.
6821 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6823 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6825 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6827 * attribute.cs: And this test is onger needed.
6829 2003-07-08 Martin Baulig <martin@ximian.com>
6831 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6832 inaccessible types. Fixes #36313.
6834 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6836 * namespace.cs (NamespaceEntry): Create implicit entries for all
6837 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6838 implicit entries for N1.N2 and N1.
6840 2003-07-08 Martin Baulig <martin@ximian.com>
6842 Rewrote the handling of namespaces to fix a lot of the issues
6843 wrt. `using' aliases etc.
6845 * namespace.cs (Namespace): Splitted this class into a
6846 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6848 * typemanager.cs (TypeManager.IsNamespace): Removed.
6849 (TypeManager.ComputeNamespaces): Only compute namespaces from
6850 loaded assemblies here, not the namespaces from the assembly we're
6851 currently compiling.
6853 2003-07-08 Martin Baulig <martin@ximian.com>
6855 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6857 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6859 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6862 I thought about the memory savings here, but LookupTypeReflection
6863 is used under already very constrained scenarios. Compiling
6864 corlib or mcs only exposes one hit, so it would not really reduce
6865 any memory consumption.
6867 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6869 * typemanager.cs: fixes bug #45889 by only adding public types from
6870 other assemblies to the list of known types.
6872 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6874 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6875 on the type we resolved.
6877 2003-07-05 Martin Baulig <martin@ximian.com>
6879 * pending.cs (PendingImplementation.ParentImplements): Don't
6880 create the proxy if the parent is abstract.
6882 * class.cs (TypeContainer.DefineIndexers): Process explicit
6883 interface implementations first. Fixes #37714.
6885 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6887 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6888 defined recursively; but since we modify the input parameters
6889 (left is set to `this' temporarily), we reset this value if the
6890 left_is_explicit is false, which gives the original semantics to
6893 * literal.cs (NullPointer): new class used to represent a null
6894 literal in a pointer context.
6896 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6897 type is a pointer, use a NullPointer object instead of a
6898 NullLiteral. Closes 43687
6900 (ExplicitConversion): Convert pointer values using
6901 the conv opcode to the proper type.
6903 * ecore.cs (New): change ValueTypeVariable property into a method,
6904 that returns whether the valuetype is suitable for being used.
6906 * expression.cs (Binary.DoNumericPromotions): Only return if we
6907 the int constant was a valid uint, and we can return both left and
6908 right as uints. If not, we continue processing, to trigger the
6909 type conversion. This fixes 39018.
6911 * statement.cs (Block.EmitMeta): During constant resolution, set
6912 the CurrentBlock property on the emitcontext, so that we resolve
6913 constants propertly.
6915 2003-07-02 Martin Baulig <martin@ximian.com>
6917 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6918 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6920 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6921 than emitting it here.
6923 * statement.cs: Fixed some more flow analysis bugs.
6925 2003-07-02 Martin Baulig <martin@ximian.com>
6927 * class.cs (MethodData.Define): When implementing interface
6928 methods, set Final unless we're Virtual.
6930 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6931 check work for interface methods.
6933 2003-07-01 Martin Baulig <martin@ximian.com>
6935 * ecore.cs (EmitContext.This): Replaced this property with a
6936 GetThis() method which takes a Location argument. This ensures
6937 that we get the correct error location for a CS0188.
6939 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6941 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6942 ImplicitStandardConversion.
6944 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6946 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6948 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6951 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6953 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6956 (MethodData.Define): Turn off initlocals for unsafe methods.
6958 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6960 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6961 complete; Fixes #37521.
6963 * delegate.cs: Use Modifiers.TypeAttr to compute the
6964 TypeAttributes, instead of rolling our own. This makes the flags
6965 correct for the delegates.
6967 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6969 * class.cs (Constructor.Define): Set the private flag for static
6970 constructors as well.
6972 * cs-parser.jay (statement_expression): Set the return value to
6973 null, to avoid a crash when we catch an error.
6975 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6977 * cs-parser.jay: Applied patch from Jackson that adds support for
6978 extern and unsafe modifiers to destructor declarations.
6980 * expression.cs: Report error 21 if the user is trying to index a
6983 * driver.cs: Add an error message, suggested by the bug report.
6985 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6986 if we do not have a ": this ()" constructor initializer. Fixes 45149
6988 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6990 * namespace.cs: Add some information to reduce FAQs.
6992 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6994 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6995 underlying enumeration types. Fixes #43915.
6997 * expression.cs: Treat ushort/short as legal values to be used in
7000 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
7002 * delegate.cs: transfer custom attributes for paramenters from
7003 the delegate declaration to Invoke and BeginInvoke.
7005 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
7007 * attribute.cs: handle custom marshalers and emit marshal info
7010 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
7012 * makefile.gnu: Added anonymous.cs to the compiler sources.
7014 2003-05-28 Miguel de Icaza <miguel@ximian.com>
7016 * iterators.cs: Change the name of the proxy class to include two
7019 * cs-parser.jay: Update grammar to include anonymous methods.
7021 * anonymous.cs: new file.
7023 2003-05-27 Miguel de Icaza <miguel@ximian.com>
7025 * class.cs (Field.Define): Add missing test for pointers and
7028 2003-05-27 Ravi Pratap <ravi@ximian.com>
7030 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
7031 we use the stobj opcode.
7033 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
7034 since it wasn't the correct fix.
7036 It still is puzzling that we are required to use stobj for IntPtr
7037 which seems to be a ValueType.
7039 2003-05-26 Miguel de Icaza <miguel@ximian.com>
7041 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
7042 during regular simple name resolution. Now, the trick is that
7043 instead of returning for processing the simplename, we do a
7044 TypeManager.LookupType (ie, a rooted lookup as opposed to a
7045 contextual lookup type). If a match is found, return that, if
7046 not, return for further composition.
7048 This fixes long-standing 30485.
7050 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
7051 using the address to initialize an object, do an Stobj instead of
7052 using the regular Stelem.
7054 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
7055 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
7056 Because if we are a BaseIndexerAccess that value will be true.
7059 * statement.cs (GotoCase.Resolve): Return after reporting an
7060 error, do not attempt to continue.
7062 * expression.cs (PointerArithmetic.Emit): If our operand is a
7063 long, convert our constants to match the operand before
7064 multiplying. Convert to I type before adding. Fixes 43670.
7066 2003-05-14 Ravi Pratap <ravi@ximian.com>
7068 * enum.cs (ImplicitConversionExists) : Rename to
7069 ImplicitEnumConversionExists to remove ambiguity.
7071 * ecore.cs (NullCast): New type of cast expression class which
7072 basically is very similar to EmptyCast with the difference being
7073 it still is a constant since it is used only to cast a null to
7077 * convert.cs (ImplicitReferenceConversion): When casting a null
7078 literal, we return a NullCast.
7080 * literal.cs (NullLiteralTyped): Remove - I don't see why this
7081 should be around anymore.
7083 The renaming (reported was slightly wrong). Corrections:
7085 ConvertImplicitStandard -> ImplicitConversionStandard
7086 ConvertExplicitStandard -> ExplicitConversionStandard
7088 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
7089 before passing them in !
7091 * convert.cs (ImplicitConversionStandard): When comparing for
7092 equal expr and target types, ensure that expr is not a
7095 In general, we must not be checking (expr_type ==
7096 target_type) in the top level conversion methods
7097 (ImplicitConversion, ExplicitConversion etc). This checking is
7098 done in the methods that they delegate to.
7100 2003-05-20 Miguel de Icaza <miguel@ximian.com>
7102 * convert.cs: Move Error_CannotConvertType,
7103 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
7104 ImplicitNumericConversion, ImplicitConversionExists,
7105 ImplicitUserConversionExists, StandardConversionExists,
7106 FindMostEncompassedType, FindMostSpecificSource,
7107 FindMostSpecificTarget, ImplicitUserConversion,
7108 ExplicitUserConversion, GetConversionOperators,
7109 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
7110 TryImplicitIntConversion, Error_CannotConvertImplicit,
7111 ConvertImplicitRequired, ConvertNumericExplicit,
7112 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
7113 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
7116 Perform the following renames:
7118 StandardConversionExists -> ImplicitStandardConversionExists
7119 ConvertImplicit -> ImplicitConversion
7120 ConvertImplicitStandard -> ImplicitStandardConversion
7121 TryImplicitIntConversion -> ImplicitIntConversion
7122 ConvertImplicitRequired -> ImplicitConversionRequired
7123 ConvertNumericExplicit -> ExplicitNumericConversion
7124 ConvertReferenceExplicit -> ExplicitReferenceConversion
7125 ConvertExplicit -> ExplicitConversion
7126 ConvertExplicitStandard -> ExplicitStandardConversion
7128 2003-05-19 Martin Baulig <martin@ximian.com>
7130 * statement.cs (TypeInfo.StructInfo): Made this type protected.
7131 (TypeInfo): Added support for structs having structs as fields.
7133 * ecore.cs (FieldExpr): Implement IVariable.
7134 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
7135 VariableInfo for the field.
7137 2003-05-18 Martin Baulig <martin@ximian.com>
7139 * expression.cs (This.DoResolve): Report a CS0027 if we're
7140 emitting a field initializer.
7142 2003-05-18 Martin Baulig <martin@ximian.com>
7144 * expression.cs (This.ResolveBase): New public function.
7145 (This.DoResolve): Check for CS0188.
7147 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
7150 * ecore.cs (MethodGroupExpr.DoResolve): Set the
7151 `instance_expression' to null if we don't have any non-static
7154 2003-05-18 Martin Baulig <martin@ximian.com>
7156 Reworked the way how local variables and parameters are handled by
7157 the flow analysis code.
7159 * statement.cs (TypeInfo, VariableMap): New public classes.
7160 (VariableInfo): New public class. This is now responsible for
7161 checking whether a variable has been assigned. It is used for
7162 parameters and local variables.
7163 (Block.EmitMeta): Take the InternalParameters as argument; compute
7164 the layout of the flow vectors here.
7165 (Block.LocalMap, Block.ParameterMap): New public properties.
7166 (FlowBranching): The .ctor doesn't get the InternalParameters
7167 anymore since Block.EmitMeta() now computes the layout of the flow
7169 (MyStructInfo): This class is now known as `StructInfo' and nested
7170 in `TypeInfo'; we don't access this directly anymore.
7172 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
7173 property and removed IsAssigned(), IsFieldAssigned(),
7174 SetAssigned() and SetFieldAssigned(); we now call them on the
7175 VariableInfo so we don't need to duplicate this code everywhere.
7177 * expression.cs (ParameterReference): Added `Block block' argument
7179 (LocalVariableReference, ParameterReference, This): The new
7180 VariableInfo class is now responsible for all the definite
7183 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
7184 IsParameterAssigned, SetParameterAssigned): Removed.
7186 2003-05-18 Martin Baulig <martin@ximian.com>
7188 * typemanager.cs (InitCoreTypes): Try calling
7189 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
7190 the 3-args-version. Corlib now also needs our `void_type'.
7191 (GetMethod): Added overloaded version which takes an optional
7192 `bool report_errors' to allow lookups of optional methods.
7194 2003-05-12 Martin Baulig <martin@ximian.com>
7196 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
7197 only used for locals and not for parameters.
7199 2003-05-12 Miguel de Icaza <miguel@ximian.com>
7201 * support.cs (InternalParameters.ParameterType): Return the
7202 ExternalType of the parameter.
7204 * parameter.cs (Parameter.ExternalType): drop the two arguments,
7207 2003-05-11 Miguel de Icaza <miguel@ximian.com>
7209 * class.cs (MethodData.Define): Do not set the `newslot' on
7210 interface members, if they are also flagged as "override".
7212 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
7213 better code for ++i and i++. This only works for static fields
7214 and local variables.
7216 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
7217 want to pull the DeclSpace out of the builder_to_declspace instead
7218 of the TypeBuilder (like in TypeContainer.FindMembers).
7220 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
7221 instead of LookupTypeContainer. Fixes the crash on .NET for
7222 looking up interface members.
7224 * const.cs: Create our own emit context during the Definition
7225 stage, so that constants are evaluated in the proper context, when
7226 a recursive definition happens.
7228 2003-05-11 Martin Baulig <martin@ximian.com>
7230 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
7231 new block for a switch section.
7232 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
7233 the adding/lookup in the switch block. Fixes #39828.
7235 2003-05-09 Miguel de Icaza <miguel@ximian.com>
7237 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
7238 functionality: I needed to convert the data after I had performed
7239 the add/sub operation into the operands type size.
7241 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
7242 pass the type for the box operation, otherwise the resulting
7243 object would have been of type object.
7245 (BoxedCast): Add constructor to specify the type to box as.
7247 2003-05-07 Miguel de Icaza <miguel@ximian.com>
7249 * iterators.cs: I was reusing the `count' variable inadvertently,
7250 take steps to not allow this to happen.
7252 2003-05-06 Miguel de Icaza <miguel@ximian.com>
7254 * attribute.cs (Attribute.Resolve): Params attributes are encoded
7255 by creating an array at the point where the params starts and
7256 putting all those arguments there, then adjusting the size of the
7259 2003-05-05 Miguel de Icaza <miguel@ximian.com>
7261 * expression.cs (New.AddressOf): Implement interface
7262 IMemoryLocation. This is used when the `new' operator is used in
7263 the context of an invocation to a method on a value type.
7265 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
7268 * namespace.cs: Also check the using aliases here.
7270 * driver.cs: Move the test for using validity after the types have
7271 been entered, so we do a single pass that also includes the using
7274 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
7275 in the regular case. CreateSiblingForFinally is doing extra
7278 * attribute.cs (GetAttributeArgumentExpression): Store the result
7279 on an out value, and use the return value to indicate failure
7280 instead of using null (which is a valid return for Constant.GetValue).
7282 * statement.cs: Perform the analysis flow for the increment
7283 portion after the statement, because this will be the real flow of
7284 execution. Fixes #42385
7286 * codegen.cs (EmitContext.EmitArgument,
7287 EmitContext.EmitStoreArgument): New helper functions when the
7288 RemapToProxy flag is set.
7290 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
7293 Add support for remapping parameters.
7295 * iterators.cs: Propagate parameter values; Store parameter
7296 values in the proxy classes.
7298 2003-05-04 Miguel de Icaza <miguel@ximian.com>
7300 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
7301 need a proxy reference; I do not know what I was thinking
7303 * cs-parser.jay (constructor_initializer): catch another error,
7304 and display nice message.
7306 (field_declaration): catch void field declaration
7307 to flag a better error.
7309 * class.cs (MemberBase.CheckBase): Report an error instead of a
7310 warning if a new protected member is declared in a struct.
7311 (Field.Define): catch the error of readonly/volatile.
7313 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
7315 (FieldExpr.AddressOf): ditto. Catch error where the address of a
7316 volatile variable is taken
7318 2003-05-02 Miguel de Icaza <miguel@ximian.com>
7320 * statement.cs (Fixed.Resolve): Report an error if we are not in
7323 2003-05-01 Miguel de Icaza <miguel@ximian.com>
7325 * typemanager.cs: reuse the code that handles type clashes for
7326 delegates and enumerations.
7328 * class.cs (Report28): Always report.
7330 * expression.cs (EncodeAsAttribute): Allow nulls here.
7332 2003-04-28 Miguel de Icaza <miguel@ximian.com>
7334 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
7335 the functionality for testing whether an expression is valid for
7336 an attribute here. Also handle the case of arrays of elements
7339 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
7340 encoding a linear array into an array of objects that are suitable
7341 to be passed to an CustomAttributeBuilder.
7343 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
7345 * ecore.cs: (FieldExpr): Handle field remapping here.
7347 * iteratators.cs: Pass the instance variable (if the method is an
7348 instance method) to the constructors, so we can access the field
7349 variables on the class.
7351 TODO: Test this with structs. I think the THIS variable on
7352 structs might have to be a pointer, and not a refenrece
7354 2003-04-27 Miguel de Icaza <miguel@ximian.com>
7356 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
7357 local variables to fields in a proxy class.
7359 * iterators.cs (PopulateProxy): Rename our internal fields to
7361 Create a <THIS> field if we are an instance method, so we can
7362 reference our parent container variables.
7363 (MapVariable): Called back from the EmitContext code to enter a
7364 new variable to field mapping into the proxy class (we just create
7368 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
7369 for using the remapped locals to fields.
7371 I placed the code here, because that gives the same semantics to
7372 local variables, and only changes the Emit code.
7374 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
7375 statements inside iterators.
7376 (VariableInfo): Add a FieldBuilder for the cases when we are
7377 remapping local variables to fields in a proxy class
7379 * ecore.cs (SimpleNameResolve): Avoid testing two times for
7380 current_block != null.
7382 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
7383 not cope with strings, as it has been moved to the
7384 TableSwitchEmit. Fixed bug in switch generation.
7386 * expression.cs (New.DoResolve): Provide more context for the user
7387 when reporting an error.
7389 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
7392 * expression.cs (MemberAccess.DoResolve): When we get a type back,
7393 check the permissions for it. Note than in a type-resolution
7394 context the check was already present in DeclSpace.ResolveType,
7395 but was missing from the MemberAccess.
7397 (ArrayCreation.CheckIndices): warn if the user has
7398 more nested levels of expressions, but there are no more
7399 dimensions specified. Avoids crash on bug 41906.
7401 2003-04-26 Miguel de Icaza <miguel@ximian.com>
7403 * statement.cs (Block): replace Implicit bool, for a generic
7405 New flag: `Unchecked'. This is used during the EmitMeta phase
7406 (which is out-of-line with the regular Resolve/Emit process for a
7407 statement, as this is done ahead of time, but still gets a chance
7408 to call constant resolve).
7410 (Block.Flags): new enum for adding a new flag.
7412 (Block.EmitMeta): track the state of unchecked.
7414 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
7415 to enable constant resolution to work there as well.
7417 2003-04-22 Miguel de Icaza <miguel@ximian.com>
7419 * typemanager.cs (ienumerable_type): Also look up
7420 System.Collections.IEnumerable.
7422 2003-04-21 Miguel de Icaza <miguel@ximian.com>
7424 TODO: Test more than one conditional per method.
7426 * class.cs (Indexer.Define): Report the location where the user is
7427 referencing the unsupported feature.
7429 (MethodData): Overload the use of `conditionals' to
7430 minimize the creation of needless ArrayLists. This saves roughly
7431 212kb on my machine.
7433 (Method): Implement the new IIteratorContainer interface.
7434 (Method.SetYields): Implement the method by setting the ModFlags
7435 to contain METHOD_YIELDS.
7437 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
7438 which just got set to null.
7440 * iterators.cs: New file.
7442 (Yield, YieldBreak): New statements.
7444 * statement.cs (Return.Resolve): Flag an error if we are used in
7447 * codegen.cs (InIterator): New flag set if the code is being
7448 compiled in an iterator method.
7450 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
7451 internal modifier, and we just use it to avoid adding extra
7452 fields, as this is seldom used.
7454 * cs-parser.jay: Add yield_statement (yield and yield break).
7456 * driver.cs: New flag -v2 to turn on version 2 features.
7458 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
7459 hashtable when v2 is enabled.
7461 2003-04-20 Miguel de Icaza <miguel@ximian.com>
7463 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
7464 there is already a namespace defined with this name.
7466 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
7467 people upgraded their corlibs.
7469 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7470 always use fully qualified types, no need to use the compiler
7473 (TypeManager.IsNamespace): Use binarysearch.
7475 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7476 AddDelegate): I did not quite use the new IsValid API properly: I
7477 have to pass the short-name and the fullname. I was passing only
7478 the basename instead of the fullname sometimes.
7480 (TypeContainer.DefineType): call NamespaceClash.
7482 * interface.cs (Interface.DefineType): use NamespaceClash before
7485 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7488 * enum.cs: (Enum.DefineType): use NamespaceClash before
7491 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7492 speed increase. First, use the negative_hits cache when we get a
7493 negative. Second, add the type with its full original name
7494 instead of the new . and + encoded name (reflection uses + to
7495 separate type from a nested type). Use LookupTypeReflection
7496 directly which bypasses the type->name hashtable (that we already
7497 know does not contain the type.
7499 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7500 location/container type.
7502 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7504 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7506 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7508 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7509 method is being referenced in the method group from a static
7510 context, and report error 120 if so.
7512 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7515 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7516 is created, we create the A namespace).
7518 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7521 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7523 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7524 invocation to ModuleBuilder.GetType with the same values will
7525 return a new type instance, so we need to cache its return
7528 * expression.cs (Binary.ResolveOperator): Only allow the compare
7529 operators on enums if they are of the same type.
7531 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7532 types of ValueType on their own case. Before we were giving them
7533 the same treatment as objects.
7535 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7536 fullname. Short name is used to compare against container name.
7537 Fullname is used to check against defined namespace names.
7539 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7540 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7542 (Method.CheckBase): Call parent.
7543 (MemberBase.CheckBase): Check for protected members on sealed
7545 (PropertyBase.CheckBase): Call parent.
7546 (Field.Define): Call parent.
7548 * report.cs: Negative error codes are now mapped to 8000 - code,
7549 so that the display is render more nicely.
7551 * typemanager.cs: Do not use try/catch, instead report a regular
7554 (GetPointerType, GetReferenceType): These methods provide
7555 mechanisms to obtain the T* and T& from a T. We had the code
7556 previously scattered around the code base, and it also used
7557 TypeManager.LookupType that would go through plenty of caches.
7558 This one goes directly to the type source.
7560 In some places we did the Type.GetType followed by
7561 ModuleBuilder.GetType, but not in others, so this unifies the
7564 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7565 statements now that we have namespace information.
7567 * typemanager.cs (IsNamespace): New method, returns whether the
7568 string presented is a namespace or not.
7570 (ComputeNamespaces): New public entry point, computes the list of
7571 available namespaces, using the GetNamespaces API call in Mono, or
7572 the slower version in MS.NET.
7574 Now before we start the semantic analysis phase, we have a
7575 complete list of namespaces including everything that the user has
7578 Deleted old code to cache namespaces in .nsc files.
7580 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7582 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7583 class/struct location definition Location for the implicit
7584 constructor location.
7586 (Operator.Define): Use the location of the operator for the
7587 implicit Method definition.
7589 (Constructor.Emit): use the constructor location for the implicit
7590 base initializer constructor.
7592 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7593 and the Expression class now contains two new methods:
7595 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7596 isolate type lookup from the rest of the resolution process.
7598 Since we use Expressions to hold type definitions due to the way
7599 we parse the input we have historically overloaded Resolve to
7600 perform the Type lookups if a special flag is passed. Now this is
7601 eliminated and two methods take their place.
7603 The differences in the two methods between xStep and xTerminal is
7604 that xStep is involved in our current lookup system that uses
7605 SimpleNames to compose a name, while xTerminal is used just to
7606 catch the case where the simplename lookup failed.
7608 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7610 * expression.cs (ResolveMemberAccess): Remove redundant code.
7611 TypeExpr expressions are always born fully resolved.
7613 * interface.cs (PopulateMethod): Do not lookup the types twice.
7614 We were doing it once during SemanticAnalysis and once during
7617 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7618 in local variable type definitions, were being returned as a
7619 SimpleName (we decomposed everything into a string), that is
7620 because primary_expression was being used instead of a type in the
7621 grammar (reduce/reduce conflicts).
7623 The part that was wrong is that we converted the expression into a
7624 string (an oversimplification in one hand, compounded with primary
7625 expressions doing string concatenation).
7631 Would return "A.B.C[]" as a SimpleName. This stopped things like
7632 using clauses from working on this particular context. And a type
7633 was being matched directly against "A.B.C[]".
7635 We now use the correct approach, and allow for ComposedCast to be
7636 part of the unary expression. So the "A.B.C []" become a composed
7637 cast of "A.B.C" (as a nested group of MemberAccess with a
7638 SimpleName at the end) plus the rank composition "[]".
7642 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7644 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7645 for the access level checking.
7647 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7648 `TypeContainer container', because I kept getting confused when I
7649 was debugging this code.
7651 * expression.cs (Indexers): Instead of tracking getters/setters,
7652 we now track them in parallel. We create one arraylist less, but
7653 most importantly it is possible now for the LValue code to find a
7654 matching get for a set.
7656 (IndexerAccess.DoResolveLValue): Update the code.
7657 GetIndexersForType has been modified already to extract all the
7658 indexers from a type. The code assumed it did not.
7660 Also make the code set the correct return type for the indexer.
7661 This was fixed a long time ago for properties, but was missing for
7662 indexers. It used to be void_type.
7664 (Binary.Emit): Test first for doubles instead of
7665 floats, as they are more common.
7667 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7668 when dealing with floats and the <=, >= operators. This fixes bug
7671 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7672 to load the array value by emitting a load on the foreach variable
7673 type. This was incorrect.
7675 We now emit the code to load an element using the the array
7676 variable type, and then we emit the conversion operator.
7680 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7682 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7684 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7686 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7687 test for protection before we test for signatures.
7689 (MethodSignature.ToString): implement.
7691 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7692 to the case where we reduced into a LongConstant.
7694 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7695 depend on whether the information is acurrate, because the
7696 Microsoft runtime will always claim that the array type is public,
7697 regardless of the real state.
7699 If the type is a pointer, another problem happens: the type is
7700 reported as non-public in Microsoft.
7702 In both cases we have to call CheckAccessLevel recursively with
7703 the underlying type as the argument to be tested.
7705 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7707 * assign.cs (Assign.Emit): If we are dealing with a compound
7708 assignment expression, we should use the code path that stores the
7709 intermediate result in a temporary value. This fixes #40903.
7711 *expression.cs (Indirection.ToString): Provide ToString method for
7714 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7716 * class.cs: Null out fields holding references to Block objects so
7717 they can be garbage collected.
7719 * expression.cs (OverloadResolve): Remove unused local.
7721 2003-04-07 Martin Baulig <martin@ximian.com>
7723 * codegen.cs (EmitContext.CurrentFile): New public field.
7724 (EmitContext.Mark): Use the CurrentFile to check whether the
7725 location is in the correct file.
7726 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7728 2003-04-07 Martin Baulig <martin@ximian.com>
7730 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7732 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7733 location. [FIXME: The location argument which gets passed to this
7734 method is sometimes wrong!]
7736 2003-04-07 Nick Drochak <ndrochak@gol.com>
7738 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7740 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7742 * expression.cs (Indirection.EmitAssign): We were using the
7743 temporary, but returning immediately instead of continuing the
7746 2003-04-06 Martin Baulig <martin@ximian.com>
7748 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7749 if it's a nested child, but also deriving from the outer class.
7752 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7753 nested child, but also deriving from the outer class. See
7755 (FilterWithClosure): We may access private members of the outer
7756 class if we're a nested child and deriving from the outer class.
7757 (RealMemberLookup): Only set `closure_private_ok' if the
7758 `original_bf' contained BindingFlags.NonPublic.
7760 2003-04-05 Martin Baulig <martin@ximian.com>
7762 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
7763 probe if its a type parameter, and if so, flag an error.
7765 * decl.cs: Move here the SetParameterInfo code from class.cs.
7766 Handle IsGeneric here.
7768 Handle a variety of errors in the parameter info definition.
7770 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
7771 type parameters here.
7773 * cs-parser.jay (class_declaration): report errors for parameters
7776 2003-01-21 Miguel de Icaza <miguel@ximian.com>
7778 * generic.cs: New file, contains support code for generics.
7780 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
7781 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
7783 Update parser for the above removals.
7785 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
7786 now taken care of in the parser.
7788 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7790 * class.cs (Event.Define): Do not allow abstract events to have
7793 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7795 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7796 block in event declarations.
7798 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7799 value type, get its address.
7801 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7802 leaving a class on the stack instead of a boolean value (int
7803 0/1). Change the code so we compare against null, and then the
7804 result against zero.
7806 * class.cs (TypeContainer.GetClassBases): We were checking for the
7807 parent class being sealed too late.
7809 * expression.cs (Binary.Emit): For <= and >= when dealing with
7810 floating point values, use cgt.un and clt.un instead of cgt and
7813 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7815 * statement.cs: Apply the same optimization as MS: skip the
7816 GetEnumerator returning an IEnumerator, and use the one returning a
7817 CharEnumerator instead. This allows us to avoid the try-finally block
7820 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7822 * cs-parser.jay: Attributes cannot be applied to
7823 namespaces. Fixes #40473
7825 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7828 (Add*): check if the name is valid using the full name for constants,
7829 fields, properties and events.
7831 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7833 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7834 char constants to be part of the enumeration.
7836 * expression.cs (Conditional.DoResolve): Add support for operator
7837 true. Implements the missing functionality from 14.12
7839 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7840 operator true/false as required by the spec.
7842 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7843 implicit conversion to boolean.
7845 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7846 also one where the type implements `operator true'.
7848 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7849 get an expression that will invoke operator true based on an
7852 (GetConversionOperators): Removed the hack that called op_True
7855 (Expression.ResolveBoolean): Move this from Statement.
7857 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7859 * ecore.cs (FieldExpr): do not allow initialization of initonly
7860 fields on derived classes
7862 2003-03-13 Martin Baulig <martin@ximian.com>
7864 * statement.cs (Block.Emit): Call ig.BeginScope() and
7865 ig.EndScope() when compiling with debugging info; call
7866 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7868 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7870 * expression.cs (Indexers): Do not construct immediately, allow
7871 for new members to be appended as we go. Fixes 38143
7873 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7875 * expression.cs: save/restore context when resolving an unchecked
7878 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7880 * cfold.cs: Catch division by zero in modulus operator during
7883 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7885 * interface.cs (Interface.DefineMembers): Avoid defining members
7888 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7890 * driver.cs: handle the +/- options for -noconfig
7892 * statement.cs (Unckeched.Resolve): Also track the state of
7893 unchecked in the Resolve phase.
7895 2003-02-27 Martin Baulig <martin@ximian.com>
7897 * ecore.cs (Expression.MemberLookup): Don't create a
7898 MethodGroupExpr for something which is not a method. Fixes #38291.
7900 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7902 * class.cs (MemberBase.CheckParameters): Also check that the type
7903 is unmanaged if it is a pointer.
7905 * expression.cs (SizeOf.Resolve): Add location information.
7907 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7908 a managed type is declared.
7910 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7911 parameter modifiers as well. Fixes bug 38606
7913 * class.cs: Very sad. Am backing out the speed up changes
7914 introduced by the ArrayList -> Array in the TypeContainer, as they
7915 were not actually that much faster, and introduced a bug (no error
7916 reports on duplicated methods).
7918 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7919 source first, this will guarantee that we have a valid expression
7920 before calling in lower levels functions that will require a
7921 resolved object. Then use this original_source in the
7922 target.ResolveLValue instead of the original source that was
7925 Another change. Use target.Resolve instead of LValueResolve.
7926 Although we are resolving for LValues, we will let the Assign code
7927 take care of that (it will be called again from Resolve). This
7928 basically allows code like this:
7930 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7931 class Y { void A (X x) { x [0] += o; }
7933 The problem was that the indexer was trying to resolve for
7934 set_Item (idx, object o) and never finding one. The real set_Item
7935 was set_Item (idx, X). By delaying the process we get the right
7940 2003-02-23 Martin Baulig <martin@ximian.com>
7942 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7943 while calling DoEmit ().
7945 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7946 source files; if you use the #line directive inside a method, the
7947 compiler stops emitting line numbers for the debugger until it
7948 reaches the end of the method or another #line directive which
7949 restores the original file.
7951 2003-02-23 Martin Baulig <martin@ximian.com>
7953 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7955 2003-02-23 Martin Baulig <martin@ximian.com>
7957 * statement.cs (Block.AddChildVariableNames): We need to call this
7958 recursively, not just for our immediate children.
7960 2003-02-23 Martin Baulig <martin@ximian.com>
7962 * class.cs (Event.Define): Always make the field private, like csc does.
7964 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7965 actually work, fixes bug #37521.
7967 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7969 * delegate.cs: When creating the various temporary "Parameters"
7970 classes, make sure that we call the ComputeAndDefineParameterTypes
7971 on those new parameters (just like we do with the formal ones), to
7972 allow them to be resolved in the context of the DeclSpace.
7974 This fixes the bug that Dick observed in Bugzilla #38530.
7976 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7978 * expression.cs (ResolveMemberAccess): When resolving a constant,
7979 do not attempt to pull a constant if the value was not able to
7980 generate a valid constant.
7982 * const.cs (LookupConstantValue): Do not report more errors than required.
7984 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7986 * expression.cs: fixes bug #38328.
7988 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7990 * class.cs: Changed all the various members that can be part of a
7991 class from being an ArrayList to be an Array of the right type.
7992 During the DefineType type_list, interface_list, delegate_list and
7993 enum_list are turned into types, interfaces, delegates and enums
7996 And during the member population, indexer_list, event_list,
7997 constant_list, field_list, instance_constructor_list, method_list,
7998 operator_list and property_list are turned into their real arrays.
8000 Although we could probably perform this operation earlier, for
8001 good error reporting we need to keep the lists and remove the
8002 lists for longer than required.
8004 This optimization was triggered by Paolo profiling the compiler
8005 speed on the output of `gen-sample-program.pl' perl script.
8007 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
8008 not crash in methods like MemberLookupFailed that use this field.
8010 This problem arises when the compiler fails to resolve a type
8011 during interface type definition for example.
8013 2003-02-18 Miguel de Icaza <miguel@ximian.com>
8015 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
8016 inherit from System.Object, so we have to stop at null, not only
8017 when reaching System.Object.
8019 2003-02-17 Miguel de Icaza <miguel@ximian.com>
8021 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
8022 DeclaredOnly because the parent indexer might have had a different
8023 name, but did not loop until the top of the hierarchy was reached.
8025 The problem this one fixes is 35492: when a class implemented an
8026 indexer from an interface, we were getting the interface method
8027 (which was abstract) and we were flagging an error (can not invoke
8030 This also keeps bug 33089 functioning, and test-148 functioning.
8032 * typemanager.cs (IsSpecialMethod): The correct way of figuring
8033 out if a method is special is to see if it is declared in a
8034 property or event, or whether it is one of the predefined operator
8035 names. This should fix correctly #36804.
8037 2003-02-15 Miguel de Icaza <miguel@ximian.com>
8039 The goal here is to remove the dependency on EmptyCast.Peel ().
8040 Killing it completely.
8042 The problem is that currently in a number of places where
8043 constants are expected, we have to "probe" for an EmptyCast, and
8044 Peel, which is not the correct thing to do, as this will be
8045 repetitive and will likely lead to errors.
8047 The idea is to remove any EmptyCasts that are used in casts that
8048 can be reduced to constants, so we only have to cope with
8051 This bug hunt was triggered by Bug 37363 and the desire to remove
8052 the duplicate pattern where we were "peeling" emptycasts to check
8053 whether they were constants. Now constants will always be
8056 * ecore.cs: Use an enumconstant here instead of wrapping with
8059 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
8060 throwing me off. By handling this we can get rid of a few hacks.
8062 * statement.cs (Switch): Removed Peel() code.
8064 2003-02-14 Miguel de Icaza <miguel@ximian.com>
8066 * class.cs: Location information for error 508
8068 * expression.cs (New.DoResolve): Add a guard against double
8069 resolution of an expression.
8071 The New DoResolve might be called twice when initializing field
8072 expressions (see EmitFieldInitializers, the call to
8073 GetInitializerExpression will perform a resolve on the expression,
8074 and later the assign will trigger another resolution
8076 This leads to bugs (#37014)
8078 * delegate.cs: The signature for EndInvoke should contain any ref
8079 or out parameters as well. We were not doing this in the past.
8081 * class.cs (Field.Define): Do not overwrite the type definition
8082 inside the `volatile' group. Turns out that volatile enumerations
8083 were changing the type here to perform a validity test, which
8086 2003-02-12 Miguel de Icaza <miguel@ximian.com>
8088 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
8089 and structs, we do not want to load the instance variable
8091 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
8092 enum_type has to be handled like an object reference (implicit
8093 conversions exists from this to object), but the regular IsClass
8094 and IsValueType tests will never return true for this one.
8096 Also we use TypeManager.IsValueType instead of type.IsValueType,
8097 just for consistency with the rest of the code (this is only
8098 needed if we ever use the construct exposed by test-180.cs inside
8099 corlib, which we dont today).
8101 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
8103 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
8106 2003-02-09 Martin Baulig <martin@ximian.com>
8108 * namespace.cs (Namespace..ctor): Added SourceFile argument.
8109 (Namespace.DefineNamespaces): New static public method; this is
8110 called when we're compiling with debugging to add all namespaces
8113 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
8114 pass it to the Namespace's .ctor.
8116 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
8117 and MethodBase arguments; pass the namespace ID to the symwriter;
8118 pass the MethodBase instead of the token to the symwriter.
8119 (SymbolWriter.DefineNamespace): New method to add a namespace to
8122 2003-02-09 Martin Baulig <martin@ximian.com>
8124 * symbolwriter.cs: New file. This is a wrapper around
8125 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
8126 methods here in near future.
8128 2003-02-09 Martin Baulig <martin@ximian.com>
8130 * codegen.cs (EmitContext.Mark): Just pass the arguments to
8131 ILGenerator.MarkSequencePoint() which are actually used by the
8134 2003-02-09 Martin Baulig <martin@ximian.com>
8136 * location.cs (SourceFile): New public sealed class. This
8137 contains the name and an index which is used in the location's token.
8138 (Location): Reserve an appropriate number of bits in the token for
8139 the source file instead of walking over that list, this gives us a
8140 really huge performance improvement when compiling with debugging.
8142 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
8143 `SourceFile' argument instead of a string.
8144 (Driver.ProcessFile): Add all the files via Location.AddFile(),
8145 but don't parse/tokenize here, we need to generate the list of all
8146 source files before we do that.
8147 (Driver.ProcessFiles): New static function. Parses/tokenizes all
8150 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
8151 instead of a string.
8153 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
8156 2003-02-09 Martin Baulig <martin@ximian.com>
8158 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
8159 filename on `#line default'.
8161 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
8163 * statement.cs: don't clear the pinned var when the fixed statement
8164 returns from the method (fixes bug#37752).
8166 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
8168 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
8171 2003-02-07 Martin Baulig <martin@ximian.com>
8173 * driver.cs: Removed the `--debug-args' command line argument.
8175 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
8176 automatically by the AsssemblyBuilder.
8177 (CodeGen.InitializeSymbolWriter): We don't need to call any
8178 initialization function on the symbol writer anymore. This method
8179 doesn't take any arguments.
8181 2003-02-03 Miguel de Icaza <miguel@ximian.com>
8183 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
8184 from referenced assemblies as well.
8186 2003-02-02 Martin Baulig <martin@ximian.com>
8188 * class.cs (MethodData.Emit): Generate debugging info for external methods.
8190 2003-02-02 Martin Baulig <martin@ximian.com>
8192 * class.cs (Constructor.Emit): Open the symbol writer before
8193 emitting the constructor initializer.
8194 (ConstructorInitializer.Emit): Call ec.Mark() to allow
8195 single-stepping through constructor initializers.
8197 2003-01-30 Miguel de Icaza <miguel@ximian.com>
8199 * class.cs: Handle error 549: do not allow virtual methods in
8202 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
8204 * decl.cs: Check access levels when resolving types
8206 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
8208 * statement.cs: Add parameters and locals set in catch blocks that might
8209 return to set vector
8211 2003-01-29 Miguel de Icaza <miguel@ximian.com>
8213 * class.cs (Operator): Set the SpecialName flags for operators.
8215 * expression.cs (Invocation.DoResolve): Only block calls to
8216 accessors and operators on SpecialName methods.
8218 (Cast.TryReduce): Handle conversions from char constants.
8221 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
8223 * statement.cs: small memory and time optimization in FlowBranching.
8225 2003-01-28 Pedro Mart <yoros@wanadoo.es>
8227 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
8228 problem that the last fix but in the other sid (Set).
8230 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
8231 access when there is no indexer in the hierarchy.
8233 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
8235 * class.cs: Combine some if statements.
8237 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8239 * driver.cs: fixed bug #37187.
8241 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
8243 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
8244 any indexer, it's needed to build a list with all the indexers in the
8245 hierarchy (AllGetters), else we have problems. Fixes #35653.
8247 2003-01-23 Miguel de Icaza <miguel@ximian.com>
8249 * class.cs (MethodData.Define): It is wrong for an interface
8250 implementation to be static in both cases: explicit and implicit.
8251 We were only handling this in one case.
8253 Improve the if situation there to not have negations.
8255 * class.cs (Field.Define): Turns out that we do not need to check
8256 the unsafe bit on field definition, only on usage. Remove the test.
8258 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8260 * driver.cs: use assembly.Location instead of Codebase (the latest
8261 patch made mcs fail when using MS assemblies).
8263 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
8265 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
8266 get the path to *corlib.dll.
8268 2003-01-21 Nick Drochak <ndrochak@gol.com>
8272 * typemanager.cs: Remove compiler warnings
8274 2003-01-20 Duncan Mak <duncan@ximian.com>
8276 * AssemblyInfo.cs: Bump the version number to 0.19.
8278 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8280 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
8282 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
8284 * class.cs (Constructor::Emit): Emit debugging info for constructors.
8286 2003-01-17 Miguel de Icaza <miguel@ximian.com>
8288 * cs-parser.jay: Small fix: we were not comparing the constructor
8289 name correctly. Thanks to Zoltan for the initial pointer.
8291 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
8293 * cs-tokenizer.cs: Set file name when specified with #line
8295 2003-01-15 Miguel de Icaza <miguel@ximian.com>
8297 * cs-parser.jay: Only perform the constructor checks here if we
8298 are named like the class; This will help provider a better
8299 error. The constructor path is taken when a type definition is
8300 not found, but most likely the user forgot to add the type, so
8301 report that rather than the constructor error.
8303 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
8305 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
8308 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8310 * cs-parser.jay: Add cleanup call.
8312 2003-01-13 Duncan Mak <duncan@ximian.com>
8314 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
8315 consistent with other methods.
8317 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8319 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
8321 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
8323 * attribute.cs: only set GuidAttr to true when we have a
8326 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8330 * typemanager.cs: fixes to allow mcs compile corlib with the new
8331 Type.IsSubclassOf fix.
8333 2003-01-08 Miguel de Icaza <miguel@ximian.com>
8335 * expression.cs (LocalVariableReference.DoResolve): Classify a
8336 constant as a value, not as a variable. Also, set the type for
8339 * cs-parser.jay (fixed_statement): take a type instead of a
8340 pointer_type, so we can produce a better error message later.
8342 * statement.cs (Fixed.Resolve): Flag types that are not pointers
8345 (For.DoEmit): Make inifinite loops have a
8346 non-conditional branch back.
8348 (Fixed.DoEmit): First populate the pinned variables, then emit the
8349 statement, then clear the variables. Before I was emitting the
8350 code once for each fixed piece.
8353 2003-01-08 Martin Baulig <martin@ximian.com>
8355 * statement.cs (FlowBranching.MergeChild): A break in a
8356 SWITCH_SECTION does not leave a loop. Fixes #36155.
8358 2003-01-08 Martin Baulig <martin@ximian.com>
8360 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
8361 lives in the same number space than `param_map'. Fixes #36154.
8363 2003-01-07 Miguel de Icaza <miguel@ximian.com>
8365 * cs-parser.jay (constructor_declaration): Set the
8366 Constructor.ModFlags before probing for it. This makes the
8367 compiler report 514, 515 and 132 (the code was there, but got
8370 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
8371 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
8372 (GotoCase.Resolve): Set `Returns' to ALWAYS.
8374 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
8376 * enum.cs: create the enum static fields using the enum type.
8378 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
8380 * class.cs: don't try to create the ParamBuilder for the return
8381 type if it's not needed (and handle it breaking for the ms runtime
8384 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
8386 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
8388 2002-12-29 Miguel de Icaza <miguel@ximian.com>
8390 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
8391 the command. This showed up while compiling the JANET source
8392 code, which used \r as its only newline separator.
8394 2002-12-28 Miguel de Icaza <miguel@ximian.com>
8396 * class.cs (Method.Define): If we are an operator (because it
8397 reuses our code), then set the SpecialName and HideBySig. #36128
8399 2002-12-22 Miguel de Icaza <miguel@ximian.com>
8401 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
8402 exception, report error 120 `object reference required'.
8404 * driver.cs: Add --pause option, used during to measure the size
8405 of the process as it goes with --timestamp.
8407 * expression.cs (Invocation.DoResolve): Do not allow methods with
8408 SpecialName to be invoked.
8410 2002-12-21 Miguel de Icaza <miguel@ximian.com>
8412 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
8413 number before adding it.
8415 2002-12-21 Ravi Pratap <ravi@ximian.com>
8417 * ecore.cs (StandardImplicitConversion): When in an unsafe
8418 context, we allow conversion between void * to any other pointer
8419 type. This fixes bug #35973.
8421 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
8423 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
8424 is not thrown when extensionless outputs are used
8426 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8428 * rootcontext.cs: fixed compilation of corlib.
8430 2002-12-19 Miguel de Icaza <miguel@ximian.com>
8432 * attribute.cs (Attributes.Contains): Add new method.
8434 * class.cs (MethodCore.LabelParameters): if the parameter is an
8435 `out' parameter, check that no attribute `[In]' has been passed.
8437 * enum.cs: Handle the `value__' name in an enumeration.
8439 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
8441 * decl.cs: Added special case to allow overrides on "protected
8444 2002-12-18 Ravi Pratap <ravi@ximian.com>
8446 * attribute.cs (Attributes.AddAttributeSection): Rename to this
8447 since it makes much more sense.
8449 (Attributes.ctor): Don't require a Location parameter.
8451 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
8453 * attribute.cs (ApplyAttributes): Remove extra Location parameters
8454 since we already have that information per attribute.
8456 * everywhere : make appropriate changes.
8458 * class.cs (LabelParameters): Write the code which actually
8459 applies attributes to the return type. We can't do this on the MS
8460 .NET runtime so we flag a warning in the case an exception is
8463 2002-12-18 Miguel de Icaza <miguel@ximian.com>
8465 * const.cs: Handle implicit null conversions here too.
8467 2002-12-17 Ravi Pratap <ravi@ximian.com>
8469 * class.cs (MethodCore.LabelParameters): Remove the extra
8470 Type [] parameter since it is completely unnecessary. Instead
8471 pass in the method's attributes so that we can extract
8472 the "return" attribute.
8474 2002-12-17 Miguel de Icaza <miguel@ximian.com>
8476 * cs-parser.jay (parse): Use Report.Error to flag errors instead
8477 of ignoring it and letting the compile continue.
8479 * typemanager.cs (ChangeType): use an extra argument to return an
8480 error condition instead of throwing an exception.
8482 2002-12-15 Miguel de Icaza <miguel@ximian.com>
8484 * expression.cs (Unary.TryReduce): mimic the code for the regular
8485 code path. Perform an implicit cast in the cases where we can
8486 implicitly convert to one of the integral types, and then reduce
8487 based on that constant. This fixes bug #35483.
8489 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8491 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
8493 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8495 * namespace.cs: fixed bug #35489.
8497 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8499 * class.cs: Remove some dead code.
8501 * cs-parser.jay: Estimate the number of methods needed
8502 (RootContext.MethodCount);
8504 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8505 numbers instead of StringBuilders.
8507 * support.cs (PtrHashtable): Add constructor with initial size;
8508 We can now reduce reallocations of the method table.
8510 2002-12-10 Ravi Pratap <ravi@ximian.com>
8512 * attribute.cs (ApplyAttributes): Keep track of the emitted
8513 attributes on a per-target basis. This fixes bug #35413.
8515 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8517 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8518 default to the Windows 1252 encoding.
8520 (UnixParseOption): Support version, thanks to Alp for the missing
8523 * AssemblyInfo.cs: Add nice assembly information.
8525 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8528 * cs-parser.jay: Allow a trailing comma before the close bracked
8529 in the attribute_section production.
8531 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8532 address of the instance was being taken, I will take this out,
8533 because we take the address of the object immediately here.
8535 2002-12-09 Ravi Pratap <ravi@ximian.com>
8537 * typemanager.cs (AreMultipleAllowed): Take care of the most
8538 obvious case where attribute type is not in the current assembly -
8541 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8543 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8544 definitions, instead of doing that afterwards.
8546 Also we use a nice little hack, depending on the constructor, we
8547 know if we are a "composed" name or a simple name. Hence, we
8548 avoid the IndexOf test, and we avoid
8550 * codegen.cs: Add code to assist in a bug reporter to track down
8551 the source of a compiler crash.
8553 2002-12-07 Ravi Pratap <ravi@ximian.com>
8555 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8556 types have been emitted for a given element and flag an error
8557 if something which does not have AllowMultiple set is used more
8560 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8561 attribute types and their corresponding AllowMultiple properties
8563 (AreMultipleAllowed): Check the property for a given type.
8565 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8566 property in the case we have a TypeContainer.
8568 (Attributes.AddAttribute): Detect duplicates and just skip on
8569 adding them. This trivial fix catches a pretty gross error in our
8570 attribute emission - global attributes were being emitted twice!
8572 Bugzilla bug #33187 is now fixed.
8574 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8576 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8579 * expression.cs (Binary.ResolveOperator): I can only use the
8580 Concat (string, string, string) and Concat (string, string,
8581 string, string) if the child is actually a concatenation of
8584 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8586 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8587 context where we need a 2-character lookahead.
8589 * pending.cs (PendingImplementation): Rework so we can keep track
8590 of interface types all the time, and flag those which were
8591 implemented by parents as optional.
8593 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8595 * expression.cs (Binary.ResolveOperator): Use
8596 String.Concat(string,string,string) or
8597 String.Concat(string,string,string,string) when possible.
8599 * typemanager: More helper methods.
8602 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8604 * pending.cs: remove the bogus return from GetMissingInterfaces()
8605 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8607 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8609 * namespace.cs: avoid duplicated 'using xxx' being added to
8610 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8611 when we get more than one 'using' statement for the same namespace.
8612 Report a CS0105 warning for it.
8614 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8616 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8617 of calling getChar/putback, uses internal knowledge of it.
8619 (xtoken): Reorder tokenizer so most common patterns are checked
8620 first. This reduces the compilation time in another 5% (from 8.11s
8621 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8623 The parsing time is 22% of the compilation in mcs, and from that
8624 64% is spent on the tokenization process.
8626 I tried using a binary search for keywords, but this is slower
8627 than the hashtable. Another option would be to do a couple of
8630 * Not use a StringBuilder, instead use an array of chars,
8631 with a set value. Notice that this way we could catch
8632 the 645 error without having to do it *afterwards*.
8634 * We could write a hand-parser to avoid the hashtable
8635 compares altogether.
8637 The identifier consumption process takes 37% of the tokenization
8638 time. Another 15% is spent on is_number. 56% of the time spent
8639 on is_number is spent on Int64.Parse:
8641 * We could probably choose based on the string length to
8642 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8645 Another 3% is spend on wrapping `xtoken' in the `token' function.
8647 Handle 0xa0 as whitespace (#34752)
8649 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8651 * typemanager.cs (IsCLRType): New routine to tell whether a type
8652 is one of the builtin types.
8654 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8655 typecode in more places instead of doing pointer comparissions.
8656 We could leverage some knowledge about the way the typecodes are
8659 New code to cache namespaces in assemblies, it is currently not
8660 invoked, to be used soon.
8662 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8664 * expression.cs (Binary.ResolveOperator): specially handle
8665 strings, and do not perform user-defined operator overloading for
8668 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8670 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8671 internalcall as it is a pretty simple operation; Avoid whenever
8672 possible to call Char.IsLetter.
8674 (consume_identifier): Cut by half the number of
8675 hashtable calls by merging the is_keyword and GetKeyword behavior.
8677 Do not short-circuit, because if we do, we
8678 report errors (ie, #if false && true would produce an invalid
8682 2002-11-24 Martin Baulig <martin@ximian.com>
8684 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8685 check constant ranges and report a CS0221. Fixes #33186.
8687 2002-11-24 Martin Baulig <martin@ximian.com>
8689 * cs-parser.jay: Make this work for uninitialized variable
8690 declarations in the `for' initializer. Fixes #32416.
8692 2002-11-24 Martin Baulig <martin@ximian.com>
8694 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8695 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8697 2002-11-24 Martin Baulig <martin@ximian.com>
8699 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8700 argument; if true, we also check for user-defined conversions.
8701 This is only needed if both arguments are of a user-defined type.
8702 Fixes #30443, added test-175.cs.
8703 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8705 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8707 2002-11-24 Martin Baulig <martin@ximian.com>
8709 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8710 function to get the store opcode.
8711 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8712 only emit the Ldelema if the store opcode is Stobj. You must run
8713 both test-34 and test-167 to test this. Fixes #34529.
8715 2002-11-23 Martin Baulig <martin@ximian.com>
8717 * ecore.cs (Expression.MemberLookup): Added additional
8718 `qualifier_type' argument which is used when we're being called
8719 from MemberAccess.DoResolve() and null if we're called from a
8721 (Expression.MemberLookupFailed): New method to report errors; this
8722 does the CS1540 check and reports the correct error message.
8724 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8725 argument for the CS1540 check and redone the way how we're dealing
8726 with private members. See the comment in the source code for details.
8727 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8728 `closure_start_type' to `closure_qualifier_type' and check whether
8729 it's not null. It was not this filter being broken, it was just
8730 being called with the wrong arguments.
8732 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8733 and pass it the correct `qualifier_type'; this also does the error
8736 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8738 * expression.cs (Invocation.EmitParams): If the we are dealing
8739 with a non-built-in value type, load its address as well.
8741 (ArrayCreation): Use a a pretty constant instead
8742 of the hardcoded value 2. Use 6 instead of 2 for the number of
8743 static initializers.
8745 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8746 because they are not really value types, just glorified integers.
8748 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8750 * ecore.cs: Remove redundant code for enumerations, make them use
8751 the same code path as everything else, fixes the casting issue
8752 with enumerations in Windows.Forms.
8754 * attribute.cs: Do only cast to string if it is a string, the
8755 validation happens later.
8757 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8758 people upgrade their corlibs.
8760 * ecore.cs: Oops, enumerations were not following the entire code path
8762 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8764 * typemanager.cs (FilterWithClosure): Commented out the test for
8765 1540 in typemanager.cs, as it has problems when accessing
8766 protected methods from a parent class (see test-174.cs).
8768 * attribute.cs (Attribute.ValidateGuid): new method.
8769 (Attribute.Resolve): Use above.
8771 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8773 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8775 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8776 handling for enumerations, as we only needed the TypeContainer
8777 functionality to begin with (this is required for the fix below to
8778 work for enums that reference constants in a container class for
8781 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8783 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8784 a valid TypeBuilder to perform lookups on.o
8786 * class.cs (InheritableMemberSignatureCompare): Use true in the
8787 call to GetGetMethod and GetSetMethod, because we are comparing
8788 the signature, and we need to get the methods *even* if they are
8791 (PropertyBase.CheckBase): ditto.
8793 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8794 GotoCase.Resolve): Use Peel on EmpytCasts.
8796 * ecore.cs (EmptyCast): drop child, add Peel method.
8798 2002-11-17 Martin Baulig <martin@ximian.com>
8800 * ecore.cs (EmptyCast.Child): New public property.
8802 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8803 label resolved to an EmptyCast. Fixes #34162.
8804 (GotoCase.Resolve): Likewise.
8805 (Block.EmitMeta): Likewise.
8807 2002-11-17 Martin Baulig <martin@ximian.com>
8809 * expression.cs (Invocation.BetterConversion): Prefer int over
8810 uint; short over ushort; long over ulong for integer literals.
8811 Use ImplicitConversionExists instead of StandardConversionExists
8812 since we also need to check for user-defined implicit conversions.
8813 Fixes #34165. Added test-173.cs.
8815 2002-11-16 Martin Baulig <martin@ximian.com>
8817 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8818 with the `true' and `false' literals. Fixes #33151.
8820 2002-11-16 Martin Baulig <martin@ximian.com>
8822 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8823 October 22nd; don't do the cs1540 check for static members.
8825 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8826 now using our own filter here and doing the cs1540 check again.
8828 2002-11-16 Martin Baulig <martin@ximian.com>
8830 * support.cs (InternalParameters): Don't crash if we don't have
8831 any fixed parameters. Fixes #33532.
8833 2002-11-16 Martin Baulig <martin@ximian.com>
8835 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8836 when looking up static methods to make this work on Windows.
8839 2002-11-16 Martin Baulig <martin@ximian.com>
8841 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8842 a setter rather than using PropertyInfo.CanWrite.
8844 2002-11-15 Nick Drochak <ndrochak@gol.com>
8846 * class.cs: Allow acces to block member by subclasses. Fixes build
8849 2002-11-14 Martin Baulig <martin@ximian.com>
8851 * class.cs (Constructor.Emit): Added the extern/block check.
8854 2002-11-14 Martin Baulig <martin@ximian.com>
8856 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8857 iteration while looking for indexers, this is needed because the
8858 indexer may have a different name in our base classes. Fixed the
8859 error reporting (no indexers at all, not get accessor, no
8860 overloaded match). Fixes bug #33089.
8861 (IndexerAccess.DoResolveLValue): Likewise.
8863 2002-11-14 Martin Baulig <martin@ximian.com>
8865 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8866 indexers. Fixes the first part of bug #33089.
8867 (MethodSignature.InheritableMemberSignatureCompare): Added support
8870 2002-11-13 Ravi Pratap <ravi@ximian.com>
8872 * attribute.cs (Attribute.Resolve): Catch the
8873 NullReferenceException and report it since it isn't supposed to
8876 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8878 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8879 LogicalOr and LogicalAnd that can benefit from recursively
8880 handling EmitBranchable. The code now should be nice for Paolo.
8882 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8884 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8885 the Type lookups, as we perform quite a number of lookups on
8886 non-Types. This can be removed once we can deterministically tell
8887 whether we have a type or a namespace in advance.
8889 But this might require special hacks from our corlib.
8893 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8894 and double which avoids a conversion from an integer to a double.
8896 * expression.cs: tiny optimization, avoid calling IsConstant,
8897 because it effectively performs the lookup twice.
8899 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8901 But a bogus return here to keep the semantics of the old code
8902 until the Mono runtime is fixed.
8904 * pending.cs (GetMissingInterfaces): New method used to remove all
8905 the interfaces that are already implemented by our parent
8906 classes from the list of pending methods.
8908 * interface.cs: Add checks for calls after ResolveTypeExpr.
8910 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8912 * class.cs (Class.Emit): Report warning 67: event not used if the
8913 warning level is beyond 3.
8915 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8916 being a NullLiteral.
8918 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8921 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8922 path that might fail if a type can not be resolved.
8924 * expression.cs (Binary.Emit): Emit unsigned versions of the
8927 * driver.cs: use error 5.
8929 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8931 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8933 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8935 * cs-parser.jay (switch_section): A beautiful patch from Martin
8936 Baulig that fixed 33094.
8938 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8940 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8941 Check whether the base is abstract and report an error if so.
8943 * expression.cs (IndexerAccess.DoResolveLValue,
8944 IndexerAccess.DoResolve): ditto.
8946 (Invocation.DoResolve): ditto.
8948 (Invocation.FullMethodDesc): Improve the report string.
8950 * statement.cs (Block): Eliminate IsVariableDefined as it is
8951 basically just a wrapper for GetVariableInfo.
8953 * ecore.cs (SimpleName): Use new
8955 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8956 type, as we return the actual parameter ref/unref state on a
8959 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8961 * support.cs: Return proper flags REF/OUT fixing the previous
8964 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8965 not used to mean `ref' but `ref or out' in ParameterReference
8967 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8968 full type signature instead of calling TypeManger.CSharpName
8971 * support.cs (InternalParameters.ParameterDesc): Do not compare
8972 directly to the modflags, because REF/OUT will actually be bitsets
8975 * delegate.cs (VerifyMethod): Check also the modifiers.
8977 * cs-tokenizer.cs: Fix bug where floating point values with an
8978 exponent where a sign was missing was ignored.
8980 * driver.cs: Allow multiple assemblies to be specified in a single
8983 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8985 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8986 because identifiers after a parenthesis would end up in this kind
8987 of production, and we needed to desamiguate it for having casts
8990 (UserDefinedType *) xxx
8992 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8994 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8995 we should set on the Bindingflags.NonPublic, but not turn on
8996 private_ok. private_ok controls whether a Private member is
8997 returned (this is chekced on the filter routine), while the
8998 BindingFlags.NonPublic just controls whether private/protected
8999 will be allowed. This fixes the problem part of the problem of
9000 private properties being allowed to be used in derived classes.
9002 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
9003 so we can call the children DoResolveLValue method (this will
9004 properly signal errors on lvalue assignments to base properties)
9006 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
9007 getter are null, and we have a property info, we know that this
9008 happened because the lookup failed, so we report an error 122 for
9009 protection level violation.
9011 We also silently return if setter and getter are null in the
9012 resolve functions, this condition only happens if we have flagged
9013 the error before. This is the other half of the problem.
9015 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
9016 not have accessibility information, that is why we were returning
9017 true in the filter function in typemanager.cs.
9019 To properly report 122 (property is inaccessible because of its
9020 protection level) correctly, we report this error in ResolveAccess
9021 by failing if both the setter and the getter are lacking (ie, the
9024 DoResolve and DoLResolve have been modified to check for both
9025 setter/getter being null and returning silently, the reason being
9026 that I did not want to put the knowledge about this error in upper
9029 int old = Report.Errors;
9030 x = new PropertyExpr (...);
9031 if (old != Report.Errors)
9036 So the property expr is returned, but it is invalid, so the error
9037 will be flagged during the resolve process.
9039 * class.cs: Remove InheritablePropertySignatureCompare from the
9040 class, as we no longer depend on the property signature to compute
9041 whether it is possible to implement a method or not.
9043 The reason is that calling PropertyInfo.GetGetMethod will return
9044 null (in .NET, in Mono it works, and we should change this), in
9045 cases where the Get Method does not exist in that particular
9050 class X { public virtual int A { get { return 1; } } }
9052 class Z : Y { public override int A { get { return 2; } } }
9054 Would fail in Z because the parent (Y) would not have the property
9055 defined. So we avoid this completely now (because the alternative
9056 fix was ugly and slow), and we now depend exclusively on the
9059 (PropertyBase.CheckBase): Use a method-base mechanism to find our
9060 reference method, instead of using the property.
9062 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
9063 routines are gone now.
9065 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
9066 names, they were incorrectly named.
9068 * cs-tokenizer.cs: Return are more gentle token on failure.
9070 * pending.cs (PendingImplementation.InterfaceMethod): This routine
9071 had an out-of-sync index variable, which caused it to remove from
9072 the list of pending methods the wrong method sometimes.
9074 2002-10-22 Miguel de Icaza <miguel@ximian.com>
9076 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
9077 CanWrite, because those refer to this particular instance of the
9078 property, and do not take into account the fact that we can
9079 override single members of a property.
9081 Constructor requires an EmitContext. The resolution process does
9082 not happen here, but we need to compute the accessors before,
9083 because the resolution does not always happen for properties.
9085 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
9086 subclass, before we did not update this flag, but we did update
9089 (GetAccessors): Drop this routine, as it did not work in the
9090 presence of partially overwritten set/get methods.
9092 Notice that this broke the cs1540 detection, but that will require
9095 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9099 * driver.cs: issue a warning instead of an error if we don't support
9100 debugging for the platform. Also ignore a couple of errors that may
9101 arise when trying to write the symbols. Undo my previous patch.
9103 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9105 * driver.cs: ignore /debug switch except for Unix platforms.
9107 2002-10-23 Nick Drochak <ndrochak@gol.com>
9109 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
9111 2002-10-21 Miguel de Icaza <miguel@ximian.com>
9113 * driver.cs: Do not make mcs-debug conditional, so we do not break
9116 * statement.cs (UsageVector.MergeChildren): I would like Martin to
9117 review this patch. But basically after all the children variables
9118 have been merged, the value of "Breaks" was not being set to
9119 new_breaks for Switch blocks. I think that it should be set after
9120 it has executed. Currently I set this to the value of new_breaks,
9121 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
9122 conservative, but I do not understand this code very well.
9124 I did not break anything in the build, so that is good ;-)
9126 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
9128 2002-10-20 Mark Crichton <crichton@gimp.org>
9130 * cfold.cs: Fixed compile blocker. Really fixed it this time.
9132 2002-10-20 Nick Drochak <ndrochak@gol.com>
9134 * cfold.cs: Fixed compile blocker.
9136 2002-10-20 Miguel de Icaza <miguel@ximian.com>
9138 * driver.cs: I was chekcing the key, not the file.
9140 2002-10-19 Ravi Pratap <ravi@ximian.com>
9142 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
9143 message that we were generating - we just need to silently return
9146 2002-10-19 Miguel de Icaza <miguel@ximian.com>
9148 * class.cs (Event.Define): Change my previous commit, as this
9149 breaks the debugger. This is a temporary hack, as it seems like
9150 the compiler is generating events incorrectly to begin with.
9152 * expression.cs (Binary.ResolveOperator): Added support for
9153 "U operator - (E x, E y)"
9155 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
9158 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
9159 init-only variables, but this path did not take into account that
9160 there might be also instance readonly variables. Correct this
9163 This fixes bug 32253
9165 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
9168 * driver.cs: Change the extension for modules to `netmodule'
9170 * cs-parser.jay: Improved slightly the location tracking for
9171 the debugger symbols.
9173 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
9174 modifiers that were specified instead of the hardcoded value
9175 (FamAndAssem). This was basically ignoring the static modifier,
9176 and others. Fixes 32429.
9178 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
9179 fixed a bug in the process (32476)
9181 * expression.cs (ArrayAccess.EmitAssign): Patch from
9182 hwang_rob@yahoo.ca that fixes bug 31834.3
9184 2002-10-18 Miguel de Icaza <miguel@ximian.com>
9186 * driver.cs: Make the module extension .netmodule.
9188 2002-10-16 Miguel de Icaza <miguel@ximian.com>
9190 * driver.cs: Report an error if the resource file is not found
9191 instead of crashing.
9193 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
9194 false, like Emit does.
9196 2002-10-16 Nick Drochak <ndrochak@gol.com>
9198 * typemanager.cs: Remove unused private member. Also reported mcs
9199 bug to report this as a warning like csc.
9201 2002-10-15 Martin Baulig <martin@gnome.org>
9203 * statement.cs (Statement.Emit): Made this a virtual method; emits
9204 the line number info and calls DoEmit().
9205 (Statement.DoEmit): New protected abstract method, formerly knows
9206 as Statement.Emit().
9208 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
9210 2002-10-11 Miguel de Icaza <miguel@ximian.com>
9212 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
9213 have fixed a remaining problem: not every AddXXXX was adding a
9214 fully qualified name.
9216 Now everyone registers a fully qualified name in the DeclSpace as
9217 being defined instead of the partial name.
9219 Downsides: we are slower than we need to be due to the excess
9220 copies and the names being registered this way.
9222 The reason for this is that we currently depend (on the corlib
9223 bootstrap for instance) that types are fully qualified, because
9224 we dump all the types in the namespace, and we should really have
9225 types inserted into the proper namespace, so we can only store the
9226 basenames in the defined_names array.
9228 2002-10-10 Martin Baulig <martin@gnome.org>
9230 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
9231 from bug #31834, see the bug report for a testcase which is
9234 2002-10-10 Martin Baulig <martin@gnome.org>
9236 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
9237 flow analysis code for this.
9239 * statement.cs (Do, While, For): Tell the flow analysis code about
9241 (FlowBranching.UsageVector): Added support for infinite loops.
9242 (Block.Resolve): Moved the dead code elimination here and use flow
9245 2002-10-09 Miguel de Icaza <miguel@ximian.com>
9247 * class.cs (Field.Define): Catch cycles on struct type
9250 * typemanager.cs (IsUnmanagedtype): Do not recursively check
9251 fields if the fields are static. We only need to check instance
9254 * expression.cs (As.DoResolve): Test for reference type.
9256 * statement.cs (Using.ResolveExpression): Use
9257 ConvertImplicitRequired, not ConvertImplicit which reports an
9259 (Using.ResolveLocalVariableDecls): ditto.
9261 * expression.cs (Binary.ResolveOperator): Report errors in a few
9262 places where we had to.
9264 * typemanager.cs (IsUnmanagedtype): Finish implementation.
9266 2002-10-08 Miguel de Icaza <miguel@ximian.com>
9268 * expression.cs: Use StoreFromPtr instead of extracting the type
9269 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
9271 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
9272 an enumeration value to a System.Enum, but System.Enum is not a
9273 value type, but an class type, so we need to box.
9275 (Expression.ConvertExplicit): One codepath could return
9276 errors but not flag them. Fix this. Fixes #31853
9278 * parameter.cs (Resolve): Do not allow void as a parameter type.
9280 2002-10-06 Martin Baulig <martin@gnome.org>
9282 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
9283 if it's a class type and not a struct. Fixes #31815.
9285 2002-10-06 Martin Baulig <martin@gnome.org>
9287 * statement.cs: Reworked the flow analysis code a bit to make it
9288 usable for dead code elimination.
9290 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9292 * cs-parser.jay: allow empty source files. Fixes bug #31781.
9294 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9296 * expression.cs (ComposedCast.DoResolveType): A quick workaround
9297 to fix the test 165, will investigate deeper.
9299 2002-10-04 Martin Baulig <martin@gnome.org>
9301 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
9302 finally blocks actually work.
9303 (Try.Resolve): We don't need to create a sibling for `finally' if
9304 there is no finally block.
9306 2002-10-04 Martin Baulig <martin@gnome.org>
9308 * class.cs (Constructor.Define): The default accessibility for a
9309 non-default constructor is private, not public.
9311 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9313 * class.cs (Constructor): Make AllowedModifiers public, add
9316 * cs-parser.jay: Perform the modifiers test here, as the
9317 constructor for the Constructor class usually receives a zero
9318 because of the way we create it (first we create, later we
9319 customize, and we were never checking the modifiers).
9321 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
9322 is a version of LookupTypeReflection that includes the type-name
9323 cache. This can be used as a fast path for functions that know
9324 the fully qualified name and are only calling into *.GetType() to
9325 obtain a composed type.
9327 This is also used by TypeManager.LookupType during its type
9330 (LookupType): We now also track the real type name, as sometimes
9331 we can get a quey for the real type name from things like
9332 ComposedCast. This fixes bug 31422.
9334 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
9335 complete type fullname, it does not have to go through the type
9336 resolution system to obtain the composed version of the type (for
9337 obtaining arrays or pointers).
9339 (Conditional.Emit): Use the EmitBoolExpression to
9340 generate nicer code, as requested by Paolo.
9342 (ArrayCreation.CheckIndices): Use the patch from
9343 hwang_rob@yahoo.ca to validate the array initializers.
9345 2002-10-03 Miguel de Icaza <miguel@ximian.com>
9347 * class.cs (ConstructorInitializer.Emit): simplify code by using
9348 Invocation.EmitCall, and at the same time, fix the bugs in calling
9349 parent constructors that took variable arguments.
9351 * ecore.cs (Expression.ConvertNumericExplicit,
9352 Expression.ImplicitNumericConversion): Remove the code that
9353 manually wrapped decimal (InternalTypeConstructor call is now gone
9356 * expression.cs (Cast.TryReduce): Also handle decimal types when
9357 trying to perform a constant fold on the type.
9359 * typemanager.cs (IsUnmanagedtype): Partially implemented.
9361 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
9362 that only turned off an error report, and did nothing else.
9364 2002-10-02 Miguel de Icaza <miguel@ximian.com>
9366 * driver.cs: Handle and ignore /fullpaths
9368 2002-10-01 Miguel de Icaza <miguel@ximian.com>
9370 * expression.cs (Binary.ResolveOperator): Catch the case where
9371 DoNumericPromotions returns true,
9373 (Binary.DoNumericPromotions): Simplify the code, and the tests.
9375 2002-09-27 Miguel de Icaza <miguel@ximian.com>
9377 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
9380 2002-09-26 Miguel de Icaza <miguel@ximian.com>
9382 * ecore.cs (ConvertNumericExplicit): It is not enough that the
9383 conversion exists, but it is also required that the conversion be
9384 performed. This manifested in "(Type64Enum) 2".
9386 * class.cs (TypeManager.AddMethod): The fix is not to change
9387 AddEnum, because that one was using a fully qualified name (every
9388 DeclSpace derivative does), but to change the AddMethod routine
9389 that was using an un-namespaced name. This now correctly reports
9390 the duplicated name.
9392 Revert patch until I can properly fix it. The issue
9393 is that we have a shared Type space across all namespaces
9394 currently, which is wrong.
9396 Options include making the Namespace a DeclSpace, and merge
9397 current_namespace/current_container in the parser.
9399 2002-09-25 Miguel de Icaza <miguel@ximian.com>
9401 * cs-parser.jay: Improve error reporting when we get a different
9402 kind of expression in local_variable_type and
9403 local_variable_pointer_type.
9405 Propagate this to avoid missleading errors being reported.
9407 * ecore.cs (ImplicitReferenceConversion): treat
9408 TypeManager.value_type as a target just like object_type. As
9413 Is valid, and needs to result in the int 1 being boxed before it
9414 is assigned to the value type v.
9416 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
9417 to validate the enumeration name.
9419 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
9420 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
9421 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
9423 * ecore.cs (TryImplicitIntConversion): When doing an
9424 implicit-enumeration-conversion, check if the type is 64-bits and
9425 perform a conversion before passing to EnumConstant.
9427 2002-09-23 Miguel de Icaza <miguel@ximian.com>
9429 * decl.cs (Error_AmbiguousTypeReference); New routine used to
9430 report ambiguous type references. Unlike the MS version, we
9431 report what the ambiguity is. Innovation at work ;-)
9433 (DeclSpace.FindType): Require a location argument to
9434 display when we display an ambiguous error.
9436 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
9438 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
9440 * expression.cs (EmitDynamicInitializers): Apply patch from
9441 hwang_rob@yahoo.ca that fixes the order in which we emit our
9444 2002-09-21 Martin Baulig <martin@gnome.org>
9446 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
9447 delegate takes no arguments.
9449 2002-09-20 Miguel de Icaza <miguel@ximian.com>
9451 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
9454 * expression.cs: Extract the underlying type.
9456 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
9458 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
9460 2002-09-19 Miguel de Icaza <miguel@ximian.com>
9462 * class.cs (TypeContainer.DefineType): We can not use the nice
9463 PackingSize with the size set to 1 DefineType method, because it
9464 will not allow us to define the interfaces that the struct
9467 This completes the fixing of bug 27287
9469 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
9470 means also structs. This fixes part of the problem.
9471 (Expresion.ImplicitReferenceConversionExists): ditto.
9473 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
9474 error if there were no errors reported during the type lookup
9475 process, to avoid duplicates or redundant errors. Without this
9476 you would get an ambiguous errors plus a type not found. We have
9477 beaten the user enough with the first error.
9479 (DeclSparce.FindType): Emit a warning if we have an ambiguous
9482 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
9483 during the resolution process, stop the lookup, this avoids
9484 repeated error reports (same error twice).
9486 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
9488 * typemanager.cs (LookupType): Redo the type lookup code to match
9489 the needs of System.Reflection.
9491 The issue is that System.Reflection requires references to nested
9492 types to begin with a "+" sign instead of a dot. So toplevel
9493 types look like: "NameSpace.TopLevelClass", and nested ones look
9494 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9497 2002-09-19 Martin Baulig <martin@gnome.org>
9499 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9500 says that a method always returns or always throws an exception,
9501 don't report the CS0161.
9503 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9504 set `Returns = new_returns'.
9506 2002-09-19 Martin Baulig <martin@gnome.org>
9508 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9509 to an enum constant, check for a CS0176.
9511 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9513 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9514 for operators that must be in pairs and report errors.
9516 * ecore.cs (SimpleName.DoResolveType): During the initial type
9517 resolution process, when we define types recursively, we must
9518 check first for types in our current scope before we perform
9519 lookups in the enclosing scopes.
9521 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9523 (Invocation.VerifyArgumentsCompat): Call
9524 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9525 I thought we were supposed to always call this, but there are a
9526 few places in the code where we dont do it.
9528 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9530 * driver.cs: Add support in -linkres and -resource to specify the
9531 name of the identifier.
9533 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9535 * ecore.cs (StandardConversionExists): Sync with the conversion
9536 code: allow anything-* to void* conversions.
9538 (FindMostSpecificSource): Use an Expression argument
9539 instead of a Type, because we might be handed over a Literal which
9540 gets a few more implicit conversions that plain types do not. So
9541 this information was being lost.
9543 Also, we drop the temporary type-holder expression when not
9546 2002-09-17 Martin Baulig <martin@gnome.org>
9548 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9549 this is an explicit interface implementation.
9551 2002-09-17 Martin Baulig <martin@gnome.org>
9553 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9554 different `IndexerName' attributes.
9556 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9557 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9558 virtual CommonResolve().
9560 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9562 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9563 and convert that to the UnderlyingType.
9565 * statement.cs (Foreach.Resolve): Indexers are just like variables
9566 or PropertyAccesses.
9568 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9569 inside quoted strings, we were not doing this before.
9571 2002-09-16 Martin Baulig <martin@gnome.org>
9573 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9574 resolve it. This is needed for the definite assignment check of the
9575 instance expression, fixes bug #29846.
9576 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9578 2002-09-16 Nick Drochak <ndrochak@gol.com>
9580 * parameter.cs: Fix compile error. Cannot reference static member
9581 from an instance object. Is this an mcs bug?
9583 2002-09-14 Martin Baulig <martin@gnome.org>
9585 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9586 multiple times. Fixes bug #30295, added test-166.cs.
9588 2002-09-14 Martin Baulig <martin@gnome.org>
9590 * statement.cs (Block.Emit): Don't emit unreachable code.
9591 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9593 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9595 2002-09-14 Martin Baulig <martin@gnome.org>
9597 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9600 2002-09-14 Martin Baulig <martin@gnome.org>
9602 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9603 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9604 be false on the ms runtime.
9606 2002-09-13 Martin Baulig <martin@gnome.org>
9608 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9609 the CS0038 error message.
9611 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9613 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9614 constant inside, return it.
9616 2002-09-12 Martin Baulig <martin@gnome.org>
9618 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9619 implicit conversion can be done between enum types.
9621 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9622 check whether an implicit conversion to the current enum's UnderlyingType
9623 exists and report an error if not.
9625 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9626 without debugging support.
9628 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9629 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9631 2002-09-12 Martin Baulig <martin@gnome.org>
9633 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9635 * ecore.cs (IMemberExpr.DeclaringType): New property.
9636 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9637 nonstatic member of an outer type (CS0038).
9639 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9641 * driver.cs: Activate the using-error detector at warning level
9642 4 (at least for MS-compatible APIs).
9644 * namespace.cs (VerifyUsing): Small buglett fix.
9646 * pending.cs (PendingImplementation): pass the container pointer.
9648 * interface.cs (GetMethods): Allow for recursive definition. Long
9649 term, I would like to move every type to support recursive
9650 definitions, not the current ordering mechanism that we have right
9653 The situation is this: Attributes are handled before interfaces,
9654 so we can apply attributes to interfaces. But some attributes
9655 implement interfaces, we will now handle the simple cases
9656 (recursive definitions will just get an error).
9658 * parameter.cs: Only invalidate types at the end if we fail to
9661 2002-09-09 Martin Baulig <martin@gnome.org>
9663 * ecore.cs (PropertyExpr.Emit): Also check for
9664 TypeManager.system_int_array_get_length so this'll also work when
9665 compiling corlib. Fixes #30003.
9667 2002-09-09 Martin Baulig <martin@gnome.org>
9669 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9670 and throw an exception if we can't get the type's size. Fixed #30040,
9673 2002-09-09 Martin Baulig <martin@gnome.org>
9675 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9677 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9678 context. Fixes bug #30027.
9680 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9681 virtual functions. Fixes bug #30043, added test-164.cs.
9683 2002-09-08 Ravi Pratap <ravi@ximian.com>
9685 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9687 2002-09-08 Nick Drochak <ndrochak@gol.com>
9689 * driver.cs: Use an object to get the windows codepage since it's not a
9692 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9694 * statement.cs (For.Emit): for infinite loops (test == null)
9695 return whether there is a break inside, not always "true".
9697 * namespace.cs (UsingEntry): New struct to hold the name of the
9698 using definition, the location where it is defined, and whether it
9699 has been used in a successful type lookup.
9701 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9706 2002-09-06 Ravi Pratap <ravi@ximian.com>
9708 * attribute.cs : Fix incorrect code which relied on catching
9709 a NullReferenceException to detect a null being passed in
9710 where an object was expected.
9712 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9714 * statement.cs (Try): flag the catch variable as assigned
9716 * expression.cs (Cast): Simplified by using ResolveType instead of
9719 * statement.cs (Catch): Fix bug by using ResolveType.
9721 2002-09-06 Ravi Pratap <ravi@ximian.com>
9723 * expression.cs (BetterConversion): Special case for when we have
9724 a NullLiteral as the argument and we have to choose between string
9725 and object types - we choose string the way csc does.
9727 * attribute.cs (Attribute.Resolve): Catch the
9728 NullReferenceException and report error #182 since the Mono
9729 runtime no more has the bug and having this exception raised means
9730 we tried to select a constructor which takes an object and is
9733 2002-09-05 Ravi Pratap <ravi@ximian.com>
9735 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9736 message (1502, 1503) when we can't locate a method after overload
9737 resolution. This is much more informative and closes the bug
9740 * interface.cs (PopulateMethod): Return if there are no argument
9741 types. Fixes a NullReferenceException bug.
9743 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9744 expressions too. Previously we were checking only in one place for
9745 positional arguments leaving out named arguments.
9747 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9748 type to the enum type is not allowed. Remove code corresponding to
9751 (ConvertNumericExplicit): Allow explicit conversions from
9752 the underlying type to enum type. This precisely follows the spec
9753 and closes a bug filed by Gonzalo.
9755 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9758 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9760 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9762 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9763 it was important that we stored the right value after the
9764 reduction in `converted'.
9766 2002-09-04 Martin Baulig <martin@gnome.org>
9768 * location.cs (Location.SymbolDocument): Use full pathnames for the
9771 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9773 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9774 of the expression resolve mechanism, because that will catch the
9775 SimpleName error failures.
9777 (Conditional): If we can not resolve the
9778 expression, return, do not crash.
9780 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9783 (location): display token name instead of its number.
9785 2002-08-28 Martin Baulig <martin@gnome.org>
9787 * expression.cs (Binary.ResolveOperator): Don't silently return
9788 but return an error if an operator cannot be applied between two
9791 2002-08-28 Martin Baulig <martin@gnome.org>
9793 * class.cs (Constructor.Define): Set the permission attributes
9794 correctly instead of making all constructors public.
9796 2002-08-28 Martin Baulig <martin@gnome.org>
9798 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9799 for private members before reporting a CS0103; if we find anything,
9802 2002-08-28 Martin Baulig <martin@gnome.org>
9804 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9805 to check whether `closure_start_type == closure_invocation_type',
9806 we also need to check whether `m.DeclaringType == closure_invocation_type'
9807 before bypassing the permission checks. We might be accessing
9808 protected/private members from the base class.
9809 (TypeManager.RealMemberLookup): Only set private_ok if private
9810 members were requested via BindingFlags.NonPublic.
9812 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9814 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9815 MethodGroupExpr.IsExplicitImpl if appropriate.
9816 (Invocation.DoResolve): Don't report the CS0120 for explicit
9817 interface implementations.
9819 2002-08-27 Martin Baulig <martin@gnome.org>
9821 * expression.cs (Invocation.DoResolve): If this is a static
9822 method and we don't have an InstanceExpression, we must report
9825 2002-08-25 Martin Baulig <martin@gnome.org>
9827 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9828 `==' between a valuetype and an object.
9830 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9832 * ecore.cs (TypeExpr): Provide a ToString method.
9834 2002-08-24 Martin Baulig <martin@gnome.org>
9836 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9837 now called proggie.dbg and it's a binary file.
9839 2002-08-23 Martin Baulig <martin@gnome.org>
9841 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9843 2002-08-23 Martin Baulig <martin@gnome.org>
9845 * struct.cs (MyStructInfo.ctor): Make this work with empty
9846 structs; it's not allowed to use foreach() on null.
9848 2002-08-23 Martin Baulig <martin@gnome.org>
9850 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9851 writer the full pathname of the generated assembly.
9853 2002-08-23 Martin Baulig <martin@gnome.org>
9855 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9856 A `finally' block never returns or breaks; improved handling of
9859 2002-08-23 Martin Baulig <martin@gnome.org>
9861 * statement.cs (Throw.Resolve): Allow `throw null'.
9863 2002-08-23 Martin Baulig <martin@gnome.org>
9865 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9866 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9867 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9868 MemberLookup would return a wrong event if this is an explicit
9869 interface implementation and the class has an event with the same
9872 2002-08-23 Martin Baulig <martin@gnome.org>
9874 * statement.cs (Block.AddChildVariableNames): New public method.
9875 (Block.AddChildVariableName): Likewise.
9876 (Block.IsVariableNameUsedInChildBlock): Likewise.
9877 (Block.AddVariable): Check whether a variable name has already
9878 been used in a child block.
9880 * cs-parser.jay (declare_local_variables): Mark all variable names
9881 from the current block as being used in a child block in the
9884 2002-08-23 Martin Baulig <martin@gnome.org>
9886 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9887 find the symbol writer.
9889 * driver.cs: csc also allows the arguments to /define being
9890 separated by commas, not only by semicolons.
9892 2002-08-23 Martin Baulig <martin@gnome.org>
9894 * interface.cs (Interface.GetMembers): Added static check for events.
9896 2002-08-15 Martin Baulig <martin@gnome.org>
9898 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9899 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9901 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9902 why the MethodData.EmitDestructor() change was necessary.
9904 2002-08-20 Martin Baulig <martin@gnome.org>
9906 * class.cs (TypeContainer.FindMembers): Added static check for events.
9908 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9910 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9911 use Type.GetEvents(), not Type.FindMembers().
9913 2002-08-20 Martin Baulig <martin@gnome.org>
9915 * decl.cs (MemberCache): Added a special method cache which will
9916 be used for method-only searched. This ensures that a method
9917 search will return a MethodInfo with the correct ReflectedType for
9920 2002-08-20 Martin Baulig <martin@gnome.org>
9922 * decl.cs (DeclSpace.FindMembers): Made this public.
9924 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9926 * delegate.cs: fixed build on windows.
9927 [FIXME: Filed as bug #29150: MCS must report these errors.]
9929 2002-08-19 Ravi Pratap <ravi@ximian.com>
9931 * ecore.cs (StandardConversionExists): Return a false
9932 if we are trying to convert the void type to anything else
9933 since that is not allowed.
9935 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9936 we flag error 70 in the event an event is trying to be accessed
9937 directly from outside the declaring type.
9939 2002-08-20 Martin Baulig <martin@gnome.org>
9941 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9942 MemberCache from typemanager.cs to decl.cs.
9944 2002-08-19 Martin Baulig <martin@gnome.org>
9946 * class.cs (TypeContainer): Implement IMemberContainer.
9947 (TypeContainer.DefineMembers): Create the MemberCache.
9948 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9949 return public members if BindingFlags.Public was given, check
9950 whether members are static.
9952 2002-08-16 Martin Baulig <martin@gnome.org>
9954 * decl.cs (DeclSpace.Define): Splitted this in Define and
9955 DefineMembers. DefineMembers is called first and initializes the
9958 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9959 DefineMembers() on all our DeclSpaces.
9961 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9962 but call DefineMembers() on all nested interfaces. We call their
9963 Define() in our new Define() function.
9965 * interface.cs (Interface): Implement IMemberContainer.
9966 (Interface.Define): Moved all code except the attribute stuf to
9968 (Interface.DefineMembers): Initialize the member cache.
9970 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9971 need this anymore since we can use MemberCache.FindMembers directly.
9973 2002-08-19 Martin Baulig <martin@gnome.org>
9975 * typemanager.cs (MemberCache): When creating the cache for an
9976 interface type, add all inherited members.
9977 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9978 to `out bool used_cache' and documented it.
9979 (TypeManager.MemberLookup): If we already used the cache in the first
9980 iteration, we don't need to do the interfaces check.
9982 2002-08-19 Martin Baulig <martin@gnome.org>
9984 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9985 here from IMemberFinder and don't implement this interface anymore.
9986 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9988 * typemanager.cs (IMemberFinder): This interface is now only used by
9989 classes which actually support the member cache.
9990 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9991 since we only put DeclSpaces into this Hashtable.
9992 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9993 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9995 2002-08-16 Martin Baulig <martin@gnome.org>
9997 * typemanager.cs (ICachingMemberFinder): Removed.
9998 (IMemberFinder.MemberCache): New property.
9999 (TypeManager.FindMembers): Merged this with RealFindMembers().
10000 This function will never be called from TypeManager.MemberLookup()
10001 so we can't use the cache here, just the IMemberFinder.
10002 (TypeManager.MemberLookup_FindMembers): Check whether the
10003 IMemberFinder has a MemberCache and call the cache's FindMembers
10005 (MemberCache): Rewrote larger parts of this yet another time and
10006 cleaned it up a bit.
10008 2002-08-15 Miguel de Icaza <miguel@ximian.com>
10010 * driver.cs (LoadArgs): Support quoting.
10012 (Usage): Show the CSC-like command line arguments.
10014 Improved a few error messages.
10016 2002-08-15 Martin Baulig <martin@gnome.org>
10018 * typemanager.cs (IMemberContainer.Type): New property.
10019 (IMemberContainer.IsInterface): New property.
10021 The following changes are conditional to BROKEN_RUNTIME, which is
10022 defined at the top of the file.
10024 * typemanager.cs (MemberCache.MemberCache): Don't add the base
10025 class'es members, but add all members from TypeHandle.ObjectType
10026 if we're an interface.
10027 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
10028 is the current type.
10029 (MemberCache.CacheEntry.Container): Removed this field.
10030 (TypeHandle.GetMembers): Include inherited members.
10032 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10034 * typemanager.cs: fixed compilation and added a comment on a field that
10037 2002-08-15 Martin Baulig <martin@gnome.org>
10039 * class.cs (ConstructorInitializer.Resolve): In the
10040 Expression.MemberLookup call, use the queried_type as
10043 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
10044 declared' attribute, it's always true.
10045 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
10046 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
10047 temporary wrapper for FindMembers which tells MemberLookup whether
10048 members from the base classes are included in the return value.
10049 This will go away soon.
10050 (TypeManager.MemberLookup): Use this temporary hack here; once the
10051 new MemberCache is completed, we don't need to do the DeclaredOnly
10052 looping here anymore since the MemberCache will take care of this.
10053 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
10054 (MemberCache): When creating the MemberCache for a class, get
10055 members from the current class and all its base classes.
10056 (MemberCache.CacheEntry.Container): New field. This is a
10057 temporary hack until the Mono runtime is fixed to distinguish
10058 between ReflectedType and DeclaringType. It allows us to use MCS
10059 with both the MS runtime and the unfixed Mono runtime without
10060 problems and without accecting performance.
10061 (MemberCache.SearchMembers): The DeclaredOnly looping from
10062 TypeManager.MemberLookup is now done here.
10064 2002-08-14 Martin Baulig <martin@gnome.org>
10066 * statement.cs (MyStructInfo.MyStructInfo): Don't call
10067 Type.GetFields on dynamic types but get the fields from the
10068 corresponding TypeContainer.
10069 (MyStructInfo.GetStructInfo): Added check for enum types.
10071 * typemanager.cs (MemberList.IsSynchronized): Implemented.
10072 (MemberList.SyncRoot): Implemented.
10073 (TypeManager.FilterWithClosure): No need to check permissions if
10074 closure_start_type == closure_invocation_type, don't crash if
10075 closure_invocation_type is null.
10077 2002-08-13 Martin Baulig <martin@gnome.org>
10079 Rewrote TypeContainer.FindMembers to use a member cache. This
10080 gives us a speed increase of about 35% for the self-hosting MCS
10081 build and of about 15-20% for the class libs (both on GNU/Linux).
10083 * report.cs (Timer): New class to get enhanced profiling. This
10084 whole class is "TIMER" conditional since it remarkably slows down
10087 * class.cs (MemberList): New class. This is an IList wrapper
10088 which we're now using instead of passing MemberInfo[]'s around to
10089 avoid copying this array unnecessarily.
10090 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
10091 (ICachingMemberFinder, IMemberContainer): New interface.
10092 (TypeManager.FilterWithClosure): If `criteria' is null, the name
10093 has already been checked, otherwise use it for the name comparision.
10094 (TypeManager.FindMembers): Renamed to RealMemberFinder and
10095 provided wrapper which tries to use ICachingMemberFinder.FindMembers
10096 if possible. Returns a MemberList, not a MemberInfo [].
10097 (TypeHandle): New class, implements IMemberContainer. We create
10098 one instance of this class per type, it contains a MemberCache
10099 which is used to do the member lookups.
10100 (MemberCache): New class. Each instance of this class contains
10101 all members of a type and a name-based hash table.
10102 (MemberCache.FindMembers): This is our new member lookup
10103 function. First, it looks up all members of the requested name in
10104 the hash table. Then, it walks this list and sorts out all
10105 applicable members and returns them.
10107 2002-08-13 Martin Baulig <martin@gnome.org>
10109 In addition to a nice code cleanup, this gives us a performance
10110 increase of about 1.4% on GNU/Linux - not much, but it's already
10111 half a second for the self-hosting MCS compilation.
10113 * typemanager.cs (IMemberFinder): New interface. It is used by
10114 TypeManager.FindMembers to call FindMembers on a TypeContainer,
10115 Enum, Delegate or Interface.
10116 (TypeManager.finder_to_member_finder): New PtrHashtable.
10117 (TypeManager.finder_to_container): Removed.
10118 (TypeManager.finder_to_delegate): Removed.
10119 (TypeManager.finder_to_interface): Removed.
10120 (TypeManager.finder_to_enum): Removed.
10122 * interface.cs (Interface): Implement IMemberFinder.
10124 * delegate.cs (Delegate): Implement IMemberFinder.
10126 * enum.cs (Enum): Implement IMemberFinder.
10128 * class.cs (TypeContainer): Implement IMemberFinder.
10130 2002-08-12 Martin Baulig <martin@gnome.org>
10132 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
10134 2002-08-12 Martin Baulig <martin@gnome.org>
10136 * ecore.cs (ITypeExpression): New interface for expressions which
10138 (TypeExpression): Renamed to TypeLookupExpression.
10139 (Expression.DoResolve): If we're doing a types-only lookup, the
10140 expression must implement the ITypeExpression interface and we
10141 call DoResolveType() on it.
10142 (SimpleName): Implement the new ITypeExpression interface.
10143 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
10144 hack, the situation that we're only looking up types can't happen
10145 anymore when this method is called. Moved the type lookup code to
10146 DoResolveType() and call it.
10147 (SimpleName.DoResolveType): This ITypeExpression interface method
10148 is now doing the types-only lookup.
10149 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
10150 (ResolveFlags): Added MaskExprClass.
10152 * expression.cs (MemberAccess): Implement the ITypeExpression
10154 (MemberAccess.DoResolve): Added support for a types-only lookup
10155 when we're called via ITypeExpression.DoResolveType().
10156 (ComposedCast): Implement the ITypeExpression interface.
10158 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
10159 Expression.Resolve() with ResolveFlags.Type instead.
10161 2002-08-12 Martin Baulig <martin@gnome.org>
10163 * interface.cs (Interface.Define): Apply attributes.
10165 * attribute.cs (Attribute.ApplyAttributes): Added support for
10166 interface attributes.
10168 2002-08-11 Martin Baulig <martin@gnome.org>
10170 * statement.cs (Block.Emit): Only check the "this" variable if we
10171 do not always throw an exception.
10173 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
10174 whether the property has a set accessor.
10176 2002-08-11 Martin Baulig <martin@gnome.org>
10178 Added control flow analysis support for structs.
10180 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
10181 with control flow analysis turned off.
10182 (IVariable): New interface.
10183 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
10184 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
10185 (FieldExpr.DoResolve): Resolve the instance expression with flow
10186 analysis turned off and do the definite assignment check after the
10187 resolving when we know what the expression will resolve to.
10189 * expression.cs (LocalVariableReference, ParameterReference):
10190 Implement the new IVariable interface, only call the flow analysis
10191 code if ec.DoFlowAnalysis is true.
10192 (This): Added constructor which takes a Block argument. Implement
10193 the new IVariable interface.
10194 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
10195 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
10196 This does the definite assignment checks for struct members.
10198 * class.cs (Constructor.Emit): If this is a non-static `struct'
10199 constructor which doesn't have any initializer, call
10200 Block.AddThisVariable() to tell the flow analysis code that all
10201 struct elements must be initialized before control returns from
10204 * statement.cs (MyStructInfo): New public class.
10205 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
10206 argument to this indexer. If non-zero, check an individual struct
10207 member, not the whole struct.
10208 (FlowBranching.CheckOutParameters): Check struct members.
10209 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
10210 overloaded versions of these methods which take an additional
10211 `int field_idx' argument to check struct members.
10212 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
10213 overloaded versions of these methods which take an additional
10214 `string field_name' argument to check struct member.s
10215 (VariableInfo): Implement the IVariable interface.
10216 (VariableInfo.StructInfo): New public property. Returns the
10217 MyStructInfo instance of the variable if it's a struct or null.
10218 (Block.AddThisVariable): New public method. This is called from
10219 Constructor.Emit() for non-static `struct' constructor which do
10220 not have any initializer. It creates a special variable for the
10221 "this" instance variable which will be checked by the flow
10222 analysis code to ensure that all of the struct's fields are
10223 initialized before control returns from the constructor.
10224 (UsageVector): Added support for struct members. If a
10225 variable/parameter is a struct with N members, we reserve a slot
10226 in the usage vector for each member. A struct is considered fully
10227 initialized if either the struct itself (slot 0) or all its
10228 members are initialized.
10230 2002-08-08 Martin Baulig <martin@gnome.org>
10232 * driver.cs (Driver.MainDriver): Only report an error CS5001
10233 if there were no compilation errors.
10235 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
10236 `UnsafeContext' property to determine whether the parent is in
10237 unsafe context rather than checking the parent's ModFlags:
10238 classes nested in an unsafe class are unsafe as well.
10240 2002-08-08 Martin Baulig <martin@gnome.org>
10242 * statement.cs (UsageVector.MergeChildren): Distinguish between
10243 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
10244 we return. Added test17() and test18() to test-154.cs.
10246 2002-08-08 Martin Baulig <martin@gnome.org>
10248 * typemanager.cs (TypeManager.FilterWithClosure): If we have
10249 Family access, make sure the invoking type isn't a subclass of the
10250 queried type (that'd be a CS1540).
10252 * ecore.cs (Expression.MemberLookup): Added overloaded version of
10253 this method which takes an additional `Type invocation_type'.
10255 * expression.cs (BaseAccess.DoResolve): Use the base type as
10256 invocation and query type.
10257 (MemberAccess.DoResolve): If the lookup failed and we're about to
10258 report a CS0122, try a lookup with the ec.ContainerType - if this
10259 succeeds, we must report a CS1540.
10261 2002-08-08 Martin Baulig <martin@gnome.org>
10263 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
10264 (MethodGroupExpr): Implement the IMemberExpr interface.
10266 * expression (MemberAccess.ResolveMemberAccess): No need to have
10267 any special code for MethodGroupExprs anymore, they're now
10270 2002-08-08 Martin Baulig <martin@gnome.org>
10272 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
10273 Family, FamANDAssem and FamORAssem permissions.
10274 (TypeManager.IsSubclassOrNestedChildOf): New public method.
10276 2002-08-08 Martin Baulig <martin@gnome.org>
10278 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
10279 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
10282 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
10284 * driver.cs: implemented /resource option to embed managed resources.
10286 2002-08-07 Martin Baulig <martin@gnome.org>
10288 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
10289 (FieldBase.HasFieldInitializer): New public property.
10290 (FieldBase.GetInitializerExpression): New public method. Resolves and
10291 returns the field initializer and makes sure it is only resolved once.
10292 (TypeContainer.EmitFieldInitializers): Call
10293 FieldBase.GetInitializerExpression to get the initializer, this ensures
10294 that it isn't resolved multiple times.
10296 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
10297 the resolving process (SimpleName/MemberLookup) that we're currently
10298 emitting a field initializer (which must not access any instance members,
10299 this is an error CS0236).
10301 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
10302 argument, if the `IsFieldInitializer' flag is set, we must report and
10303 error CS0236 and not an error CS0120.
10305 2002-08-07 Martin Baulig <martin@gnome.org>
10307 * ecore.cs (IMemberExpr): New public interface.
10308 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
10309 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
10310 if the expression is an IMemberExpr.
10312 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
10313 to be null, implicitly default to `this' if we're non-static in
10314 this case. Simplified the code a lot by using the new IMemberExpr
10315 interface. Also fixed bug #28176 here.
10317 2002-08-06 Martin Baulig <martin@gnome.org>
10319 * cs-parser.jay (SimpleLookup): Removed. We need to create
10320 ParameterReferences during semantic analysis so that we can do a
10321 type-only search when resolving Cast, TypeOf and SizeOf.
10322 (block): Pass the `current_local_parameters' to the Block's
10325 * class.cs (ConstructorInitializer): Added `Parameters parameters'
10326 argument to the constructor.
10327 (ConstructorInitializer.Resolve): Create a temporary implicit
10328 block with the parameters.
10330 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
10331 references here if we aren't doing a type-only search.
10333 * statement.cs (Block): Added constructor which takes a
10334 `Parameters parameters' argument.
10335 (Block.Parameters): New public property.
10337 * support.cs (InternalParameters.Parameters): Renamed `parameters'
10338 to `Parameters' and made it public readonly.
10340 2002-08-06 Martin Baulig <martin@gnome.org>
10342 * ecore.cs (Expression.Warning): Made this public as well.
10344 * report.cs (Report.Debug): Print the contents of collections.
10346 2002-08-06 Martin Baulig <martin@gnome.org>
10348 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
10349 used to tell Resolve() which kinds of expressions it may return.
10350 (Expression.Resolve): Added overloaded version of this method which
10351 takes a `ResolveFlags flags' argument. This can be used to tell
10352 Resolve() which kinds of expressions it may return. Reports a
10354 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
10355 ResolveFlags.SimpleName.
10356 (Expression.Error118): Added overloaded version of this method which
10357 takes a `ResolveFlags flags' argument. It uses the flags to determine
10358 which kinds of expressions are allowed.
10360 * expression.cs (Argument.ResolveMethodGroup): New public method.
10361 Resolves an argument, but allows a MethodGroup to be returned.
10362 This is used when invoking a delegate.
10364 * TODO: Updated a bit.
10366 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10368 Fixed compilation with csc.
10370 * ecore.cs: Expression.Error made public. Is this correct? Should
10371 Warning be made public too?
10373 * expression.cs: use ea.Location instead of ea.loc.
10374 [FIXME: Filed as bug #28607: MCS must report these errors.]
10376 2002-08-06 Martin Baulig <martin@gnome.org>
10378 * ecore.cs (Expression.loc): Moved the location here instead of
10379 duplicating it in all derived classes.
10380 (Expression.Location): New public property.
10381 (Expression.Error, Expression.Warning): Made them non-static and
10382 removed the location argument.
10383 (Expression.Warning): Added overloaded version which takes an
10384 `int level' argument.
10385 (Expression.Error118): Make this non-static and removed the
10386 expression and location arguments.
10387 (TypeExpr): Added location argument to the constructor.
10389 * expression.cs (StaticCallExpr): Added location argument to
10391 (Indirection, PointerArithmetic): Likewise.
10392 (CheckedExpr, UnCheckedExpr): Likewise.
10393 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
10394 (StringPtr): Likewise.
10397 2002-08-05 Martin Baulig <martin@gnome.org>
10399 * expression.cs (BaseAccess.DoResolve): Actually report errors.
10401 * assign.cs (Assign.DoResolve): Check whether the source
10402 expression is a value or variable.
10404 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
10405 while resolving the corresponding blocks.
10407 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
10408 an error, don't silently return null.
10410 * statement.cs (Block.AddVariable): Do the error reporting here
10411 and distinguish between CS0128 and CS0136.
10412 (Block.DoResolve): Report all unused labels (warning CS0164).
10413 (LabeledStatement): Pass the location to the constructor.
10414 (LabeledStatement.HasBeenReferenced): New property.
10415 (LabeledStatement.Resolve): Set it to true here.
10417 * statement.cs (Return.Emit): Return success even after reporting
10418 a type mismatch error (CS0126 or CS0127), this is what csc does and
10419 it avoids confusing the users with any consecutive errors.
10421 2002-08-05 Martin Baulig <martin@gnome.org>
10423 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
10425 * const.cs (Const.LookupConstantValue): Catch circular definitions.
10427 * expression.cs (MemberAccess.DoResolve): Silently return if an
10428 error has already been reported.
10430 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
10431 error has already been reported.
10433 2002-08-05 Martin Baulig <martin@gnome.org>
10435 * statement.cs (UsageVector): Only initialize the `parameters'
10436 vector if we actually have any "out" parameters.
10438 2002-08-05 Martin Baulig <martin@gnome.org>
10440 * expression.cs (Binary.ResolveOperator): When combining delegates,
10441 they must have the same type.
10443 2002-08-05 Martin Baulig <martin@gnome.org>
10445 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
10446 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
10447 work with the ms runtime and we also don't need it: if we're a
10448 PropertyBuilder and not in the `indexer_arguments' hash, then we
10449 are a property and not an indexer.
10451 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
10452 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
10453 since the latter one doesn't work with the ms runtime.
10455 2002-08-03 Martin Baulig <martin@gnome.org>
10457 Fixed bugs #27998 and #22735.
10459 * class.cs (Method.IsOperator): New public field.
10460 (Method.CheckBase): Report CS0111 if there's already a method
10461 with the same parameters in the current class. Report CS0508 when
10462 attempting to change the return type of an inherited method.
10463 (MethodData.Emit): Report CS0179 if a method doesn't have a body
10464 and it's not marked abstract or extern.
10465 (PropertyBase): New abstract base class for Property and Indexer.
10466 (PropertyBase.CheckBase): Moved here from Property and made it work
10468 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
10469 the same so we can reuse it there.
10470 (Property, Indexer): Derive from PropertyBase.
10471 (MethodSignature.inheritable_property_signature_filter): New delegate
10472 to find properties and indexers.
10474 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
10475 argument and improved error reporting.
10477 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
10478 EmptyReadOnlyParameters and made it a property.
10480 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
10481 version of this method which takes a `PropertyInfo indexer'.
10482 (TypeManager.RegisterIndexer): New method.
10484 * class.cs: Added myself as author of this file :-)
10486 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10488 * class.cs: fixed compilation on windoze.
10490 2002-08-03 Martin Baulig <martin@gnome.org>
10492 * interface.cs (Interface.GetInterfaceBases): Check whether all
10493 base interfaces are at least as accessible than the current one.
10495 * class.cs (TypeContainer.GetClassBases): Check whether base types
10496 are at least as accessible than the current type.
10497 (TypeContainer.AsAccessible): Implemented and made non-static.
10498 (MemberBase.CheckParameters): Report errors if the accessibility
10501 * delegate.cs (Delegate.Delegate): The default visibility is
10502 internal for top-level types and private for nested types.
10503 (Delegate.Define): Report errors if the accessibility checks fail.
10505 * enum.cs (Enum.Enum): The default visibility is internal for
10506 top-level types and private for nested types.
10507 (Enum.DefineType): Compute the correct visibility.
10509 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10510 function which takes a `bool is_toplevel' instead of a TypeContainer.
10512 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10515 2002-08-02 Martin Baulig <martin@gnome.org>
10517 * expression.cs (LocalVariableReferenc): Added constructor which
10518 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10519 (LocalVariableReference.IsReadOnly): New property.
10520 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10521 variable is readonly, use our own readonly flag to do this; you can
10522 use the new constructor to get a writable reference to a read-only
10525 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10526 reference to the local variable.
10528 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10530 * rootcontext.cs (ResolveCore): Also include System.Exception
10532 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10533 we reach an EmptyStatement.
10535 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10538 * expression.cs (Binary.ResolveOperator): Check error result in
10541 use brtrue/brfalse directly and avoid compares to null.
10543 2002-08-02 Martin Baulig <martin@gnome.org>
10545 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10546 Fixes bug #28407, added test-155.cs.
10548 2002-08-01 Martin Baulig <martin@gnome.org>
10550 * class.cs (Event.EmitDefaultMethod): Make this work with static
10551 events. Fixes #28311, added verify-3.cs.
10553 2002-08-01 Martin Baulig <martin@gnome.org>
10555 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10556 `is_disposable' fields.
10557 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10558 `hm.is_disposable' if we're using the collection pattern.
10559 (Foreach.EmitCollectionForeach): Use the correct type for the
10560 enumerator's local variable, only emit the try/finally block if
10561 necessary (fixes #27713).
10563 2002-08-01 Martin Baulig <martin@gnome.org>
10565 * ecore.cs (Expression.report118): Renamed to Error118 and made
10568 * statement.cs (Throw.Resolve): Check whether the expression is of
10569 the correct type (CS0118) and whether the type derives from
10570 System.Exception (CS0155).
10571 (Catch.Resolve): New method. Do the type lookup here and check
10572 whether it derives from System.Exception (CS0155).
10573 (Catch.CatchType, Catch.IsGeneral): New public properties.
10575 * typemanager.cs (TypeManager.exception_type): Added.
10577 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10579 * driver.cs: Updated About function.
10581 2002-07-31 Martin Baulig <martin@gnome.org>
10583 Implemented Control Flow Analysis.
10585 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10586 (EmitContext.CurrentBranching): Added.
10587 (EmitContext.StartFlowBranching): Added.
10588 (EmitContext.EndFlowBranching): Added.
10589 (EmitContext.KillFlowBranching): Added.
10590 (EmitContext.IsVariableAssigned): Added.
10591 (EmitContext.SetVariableAssigned): Added.
10592 (EmitContext.IsParameterAssigned): Added.
10593 (EmitContext.SetParameterAssigned): Added.
10594 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10595 Added control flow analysis stuff here.
10597 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10598 resolve the expression as lvalue.
10599 (LocalVariableReference.DoResolve): Check whether the variable has
10600 already been assigned.
10601 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10602 the parameter as assigned here.
10603 (ParameterReference.DoResolve): Check whether the parameter has already
10605 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10606 expression as lvalue.
10608 * statement.cs (FlowBranching): New class for the flow analysis code.
10609 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10610 (LabeledStatement.IsDefined): New public property.
10611 (LabeledStatement.AddUsageVector): New public method to tell flow
10612 analyis that the label may be reached via a forward jump.
10613 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10615 (VariableInfo.Number): New public field. This is used by flow analysis
10616 to number all locals of a block.
10617 (Block.CountVariables): New public property. This is the number of
10618 local variables in this block (including the locals from all parent
10620 (Block.EmitMeta): Number all the variables.
10622 * statement.cs: Added flow analysis support to all classes.
10624 2002-07-31 Martin Baulig <martin@gnome.org>
10626 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10627 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10628 then use this argument.
10630 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10632 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10633 use this to specify /define options.
10635 2002-07-29 Martin Baulig <martin@gnome.org>
10637 * statement.cs (Fixed): Moved all code that does variable lookups
10638 and resolvings from Emit to Resolve.
10640 * statement.cs (For): Moved all code that does variable lookups
10641 and resolvings from Emit to Resolve.
10643 * statement.cs (Using): Moved all code that does variable lookups
10644 and resolvings from Emit to Resolve.
10646 2002-07-29 Martin Baulig <martin@gnome.org>
10648 * attribute.cs (Attribute.Resolve): Explicitly catch a
10649 System.NullReferenceException when creating the
10650 CustromAttributeBuilder and report a different warning message.
10652 2002-07-29 Martin Baulig <martin@gnome.org>
10654 * support.cs (ParameterData.ParameterName): Added method to
10655 get the name of a parameter.
10657 * typemanager.cs (TypeManager.IsValueType): New public method.
10659 2002-07-29 Martin Baulig <martin@gnome.org>
10661 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10662 is a flag which specifies that it's either ref or out.
10663 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10664 the out parameter to `out Parameter.Modifier mod', also set the
10665 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10667 * support.cs (InternalParameters.ParameterModifier): Distinguish
10668 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10669 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10671 * expression.cs (Argument.GetParameterModifier): Distinguish
10672 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10673 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10675 2002-07-29 Martin Baulig <martin@gnome.org>
10677 * expression.cs (ParameterReference.ParameterReference): Added
10678 `Location loc' argument to the constructor.
10680 * cs-parser.jay: Pass location to ParameterReference.
10682 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10684 * statement.cs (Try): Initialize the location.
10686 * cs-parser.jay: pass location to Try.
10688 * expression.cs (Unary.Reduce): Change the prototype to return
10689 whether a constant fold could be performed or not. The result is
10690 returned in an out parameters. In the case of Indirection and
10691 AddressOf, we want to perform the full tests.
10693 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10695 * statement.cs (Statement.Emit): Flag dead code.
10697 2002-07-27 Andrew Birkett <andy@nobugs.org>
10699 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10701 2002-07-27 Martin Baulig <martin@gnome.org>
10703 * class.cs (MethodData.Define): Put back call to
10704 TypeManager.AddMethod(), accidentally commented this out.
10706 * report.cs (Debug): New public method to print debugging information,
10707 this is `[Conditional ("DEBUG")]'.
10709 2002-07-26 Martin Baulig <martin@gnome.org>
10711 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10712 (switch_statement): Push the current_block to the switch_stack and
10713 pop it again when we're done with the switch.
10714 (switch_section): The new block is a child of the current_block.
10715 Fixes bug #24007, added test-152.cs.
10717 2002-07-27 Martin Baulig <martin@gnome.org>
10719 * expression.cs (Invocation.EmitArguments): When calling a varargs
10720 function with only its fixed arguments, we need to pass an empty
10723 2002-07-27 Martin Baulig <martin@gnome.org>
10725 Mono 0.13 has been released.
10727 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10729 * driver.cs: Rename --resource to --linkres, because that is what
10730 we do currently, we dont support --resource yet.
10732 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10734 2002-07-25 Martin Baulig <martin@gnome.org>
10736 * class.cs (MethodData): New public class. This is a `method builder'
10737 class for a method or one accessor of a Property/Indexer/Event.
10738 (MethodData.GetMethodFlags): Moved here from MemberBase.
10739 (MethodData.ApplyAttributes): Likewise.
10740 (MethodData.ApplyObsoleteAttribute): Likewise.
10741 (MethodData.ApplyConditionalAttribute): Likewise.
10742 (MethodData.ApplyDllImportAttribute): Likewise.
10743 (MethodData.CheckAbstractAndExternal): Likewise.
10744 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10745 (MethodData.Emit): Formerly known as Method.Emit().
10746 (MemberBase): Moved everything which was specific to a single
10747 accessor/method to MethodData.
10748 (Method): Create a new MethodData and call Define() and Emit() on it.
10749 (Property, Indexer, Event): Create a new MethodData objects for each
10750 accessor and call Define() and Emit() on them.
10752 2002-07-25 Martin Baulig <martin@gnome.org>
10754 Made MethodCore derive from MemberBase to reuse the code from there.
10755 MemberBase now also checks for attributes.
10757 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10758 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10760 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10761 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10762 (MemberBase.ApplyAttributes): New virtual method; applies the
10763 attributes to a method or accessor.
10764 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10765 (MemberBase.ApplyConditionalAttribute): Likewise.
10766 (MemberBase.ApplyDllImportAttribute): Likewise.
10767 (MemberBase.CheckAbstractAndExternal): Likewise.
10768 (MethodCore.ParameterTypes): This is now a property instead of a
10769 method, it's initialized from DoDefineParameters().
10770 (MethodCore.ParameterInfo): Removed the set accessor.
10771 (MethodCore.DoDefineParameters): New protected virtual method to
10772 initialize ParameterTypes and ParameterInfo.
10773 (Method.GetReturnType): We can now simply return the MemberType.
10774 (Method.GetMethodFlags): Override the MemberBase version and add
10775 the conditional flags.
10776 (Method.CheckBase): Moved some code from Define() here, call
10777 DoDefineParameters() here.
10778 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10779 here to avoid some larger code duplication.
10780 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10781 ensure that abstract and external accessors don't declare a body.
10783 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10784 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10785 lookup in the attribute's parent classes, so we need to abort as soon
10786 as we found the first match.
10787 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10788 the attribute has no arguments.
10790 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10793 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10795 * cs-parser.jay: reverted previous patch.
10797 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10799 * cs-parser.jay: fixed bug #22119.
10801 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10803 * attribute.cs: fixed compilation. The error was:
10804 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10805 be assigned to before control leaves the current method."
10806 [FIXME: Filed as bug #28186: MCS must report this error.]
10808 2002-07-25 Martin Baulig <martin@gnome.org>
10810 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10811 method to pull the condition name ouf of a Conditional attribute.
10812 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10813 the obsolete message and error flag out of an Obsolete attribute.
10815 * class.cs (Method.GetMethodFlags): New public method to get the
10816 TypeManager.MethodFlags for this method.
10817 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10819 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10820 if we're overriding a virtual function, set the new private variable
10821 `parent_method'; call the new TypeManager.AddMethod().
10823 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10824 the MethodBuilder and the Method in a PtrHashtable.
10825 (TypeManager.builder_to_method): Added for this purpose.
10826 (TypeManager.MethodFlags): Added IsObsoleteError.
10827 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10828 Obsolete and Conditional arguments in MethodBuilders. If we discover
10829 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10830 the message from the attribute.
10832 2002-07-24 Martin Baulig <martin@gnome.org>
10834 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10835 preprocessor directives, ensure that the argument to #define/#undef is
10836 exactly one identifier and that it's actually an identifier.
10838 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10841 2002-07-24 Martin Baulig <martin@gnome.org>
10843 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10844 initialize it to TypeManager.object_type in the constructor.
10845 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10846 of the `hm.get_current' method if we're using the collection pattern.
10847 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10848 for the explicit conversion to make it work when we're using the collection
10849 pattern and the `Current' property has a different return type than `object'.
10852 2002-07-24 Martin Baulig <martin@gnome.org>
10854 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10855 does not match, but don't report any errors. This method is called in
10856 order for all methods in a MethodGroupExpr until a matching method is
10857 found, so we don't want to bail out if the first method doesn't match.
10858 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10859 matches, report the 123. Fixes #28070.
10861 2002-07-24 Martin Baulig <martin@gnome.org>
10863 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10864 TypeManager.TypeToCoreType() to the top of the method so the
10865 following equality checks will work. Fixes #28107.
10867 2002-07-24 Martin Baulig <martin@gnome.org>
10869 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10870 operand is of type uint, and the other operand is of type sbyte,
10871 short or int, the operands are converted to type long." -
10872 Actually do what this comment already told us. Fixes bug #28106,
10875 2002-07-24 Martin Baulig <martin@gnome.org>
10877 * class.cs (MethodBase): New abstract class. This is now a base
10878 class for Property, Indexer and Event to avoid some code duplication
10879 in their Define() and DefineMethods() methods.
10880 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10881 generic methods for Define() and DefineMethods().
10882 (FieldBase): Derive from MemberBase, not MemberCore.
10883 (Property): Derive from MemberBase, not MemberCore.
10884 (Property.DefineMethod): Moved all the code from this method to the
10885 new MethodBase.DefineAccessor(), just call it with appropriate
10887 (Property.Define): Call the new Property.DoDefine(), this does some
10888 sanity checks and we don't need to duplicate the code everywhere.
10889 (Event): Derive from MemberBase, not MemberCore.
10890 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10891 accessors, this will also make them work with interface events.
10892 (Indexer): Derive from MemberBase, not MemberCore.
10893 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10894 (Indexer.Define): Use the new MethodBase functions.
10896 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10897 argument to the constructor.
10898 (Interface.FindMembers): Added support for interface events.
10899 (Interface.PopluateEvent): Implemented.
10901 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10903 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10905 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10906 but this is required to check for a method name being the same as
10907 the containing class.
10911 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10913 * interface.cs: initialize variable.
10915 2002-07-23 Martin Baulig <martin@gnome.org>
10917 Implemented the IndexerName attribute in interfaces.
10919 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10920 name if this is an explicit interface implementation.
10921 (Indexer.InterfaceIndexerName): New public variable. If we're
10922 implementing an interface indexer, this is the IndexerName in that
10923 interface. Otherwise, it's the IndexerName.
10924 (Indexer.DefineMethod): If we're implementing interface indexer,
10925 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10926 and Pending.ImplementIndexer methods.
10927 (Indexer.Define): Also define the PropertyBuilder if we're
10928 implementing an interface indexer and this is neither an explicit
10929 interface implementation nor do the IndexerName match the one in
10932 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10933 If a method is defined here, then we always need to create a proxy
10934 for it. This is used when implementing interface indexers.
10935 (Pending.IsInterfaceIndexer): New public method.
10936 (Pending.ImplementIndexer): New public method.
10937 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10938 This is used when implementing interface indexers to define a proxy
10940 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10941 define a proxy if necessary.
10943 * interface.cs (Interface.IndexerName): New public variable.
10944 (Interface.PopulateIndexer): Set the IndexerName.
10945 (Interface.DefineIndexers): New private method. Populate all the
10946 indexers and make sure their IndexerNames match.
10948 * typemanager.cs (IndexerPropertyName): Added support for interface
10951 2002-07-22 Martin Baulig <martin@gnome.org>
10953 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10954 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10955 ret if HasReturnLabel.
10956 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10959 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10960 and set the ec.LoopBeginTryCatchLevel.
10961 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10962 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10963 the current ec.TryCatchLevel, the branch goes out of an exception
10964 block. In this case, we need to use Leave and not Br.
10966 2002-07-22 Martin Baulig <martin@gnome.org>
10968 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10969 block unless the block does not always return or it is contained in
10970 another try { ... } catch { ... } block. Fixes bug #26506.
10971 Added verify-1.cs to the test suite.
10973 2002-07-22 Martin Baulig <martin@gnome.org>
10975 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10976 then we do not always return. Fixes bug #24985.
10978 2002-07-22 Martin Baulig <martin@gnome.org>
10980 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10981 lookup on a per-class level; ie. walk up the class hierarchy until we
10982 found at least one applicable method, then choose the best among them.
10983 Fixes bug #24463 and test-29.cs.
10985 2002-07-22 Martin Baulig <martin@gnome.org>
10987 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10988 return types of the methods. The return type is not part of the
10989 signature and we must not check it to make the `new' modifier work.
10990 Fixes bug #27999, also added test-147.cs.
10991 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10993 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10994 on the method's return type.
10996 2002-07-21 Martin Baulig <martin@gnome.org>
10998 * assign.cs: Make this work if the rightmost source is a constant and
10999 we need to do an implicit type conversion. Also adding a few more tests
11000 to test-38.cs which should have caught this.
11002 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
11003 target in the makefile for this. The makefile.gnu is primarily intended
11004 for end-users who don't want to debug the compiler.
11006 2002-07-21 Martin Baulig <martin@gnome.org>
11008 * assign.cs: Improved the Assign class so it can now handle embedded
11009 assignments (X = Y = Z = something). As a side-effect this'll now also
11010 consume less local variables. test-38.cs now passes with MCS, added
11011 a few new test cases to that test.
11013 2002-07-20 Martin Baulig <martin@gnome.org>
11015 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
11016 instructions. Fixes bug #27977, also added test-146.cs.
11018 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11020 * cs-tokenizer.cs: fixed getHex ().
11022 2002-07-19 Martin Baulig <martin@gnome.org>
11024 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
11025 not Type.GetType() to lookup the array type. This is needed when
11026 we're constructing an array of a user-defined type.
11027 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
11028 single-dimensional arrays, but also for single-dimensial arrays of
11031 2002-07-19 Martin Baulig <martin@gnome.org>
11033 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
11034 this function is called, it's not allowed to share LocalBuilders
11035 among ILGenerators.
11037 2002-07-19 Martin Baulig <martin@gnome.org>
11039 * expression.cs (Argument.Resolve): Report an error 118 when trying
11040 to pass a type as argument.
11042 2002-07-18 Martin Baulig <martin@gnome.org>
11044 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
11045 Conv_R_Un for the signed `long' type.
11047 2002-07-15 Miguel de Icaza <miguel@ximian.com>
11049 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
11050 `expr' for the temporary result, as that will fail if we do
11051 multiple resolves on the same expression.
11053 2002-07-05 Miguel de Icaza <miguel@ximian.com>
11055 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
11056 ec.TypeContainer for looking up aliases.
11058 * class.cs (TypeContainer): Remove LookupAlias from here.
11060 * decl.cs (DeclSpace); Move here.
11062 2002-07-01 Miguel de Icaza <miguel@ximian.com>
11064 * class.cs (FindMembers): Only call filter if the constructor
11065 bulider is not null.
11067 Also handle delegates in `NestedTypes' now. Now we will perform
11068 type lookups using the standard resolution process. This also
11071 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
11072 This uses Expressions (the limited kind that can be parsed by the
11073 tree) instead of strings.
11075 * expression.cs (ComposedCast.ToString): Implement, used to flag
11076 errors since now we have to render expressions.
11078 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
11081 * ecore.cs (SimpleName.ToString): ditto.
11083 * cs-parser.jay: Instead of using strings to assemble types, use
11084 Expressions to assemble the type (using SimpleName, ComposedCast,
11085 MemberAccess). This should fix the type lookups in declarations,
11086 because we were using a different code path for this.
11088 * statement.cs (Block.Resolve): Continue processing statements
11089 even when there is an error.
11091 2002-07-17 Miguel de Icaza <miguel@ximian.com>
11093 * class.cs (Event.Define): Also remove the `remove' method from
11094 the list of pending items.
11096 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
11097 generate more compact code.
11099 2002-07-17 Martin Baulig <martin@gnome.org>
11101 * const.cs (Const.LookupConstantValue): Add support for constant
11102 `unchecked' and `checked' expressions.
11103 Also adding test case test-140.cs for this.
11105 2002-07-17 Martin Baulig <martin@gnome.org>
11107 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
11108 check whether mi.ReturnType implements the IEnumerator interface; the
11109 `==' and the IsAssignableFrom() will fail in this situation.
11111 2002-07-16 Ravi Pratap <ravi@ximian.com>
11113 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
11116 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11118 * expression.cs: fixed bug #27811.
11120 2002-07-14 Miguel de Icaza <miguel@ximian.com>
11122 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
11123 Molaro: when we are a ref, the value already contains a pointer
11124 value, do not take the address of it.
11126 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11127 * removed mb-parser.jay and mb-tokenizer.cs
11129 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11131 * expression.cs: check against the building corlib void type.
11133 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
11135 * ecore.cs: fix for valuetype static readonly fields: when
11136 initializing them, we need their address, not the address of a copy.
11138 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
11140 * typemanager.cs: register also enum_type in corlib.
11142 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11144 * class.cs: allow calling this (but not base) initializers in structs.
11146 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
11148 * ecore.cs: make sure we compare against the building base types
11151 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
11153 * typemanager.cs: fix TypeToCoreType() to handle void and object
11154 (corlib gets no more typerefs after this change).
11156 2002-07-12 Miguel de Icaza <miguel@ximian.com>
11158 * expression.cs (ArrayCreation.EmitArrayArguments): use
11159 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
11161 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
11162 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
11163 array indexes, the runtime actually forbids them.
11165 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
11166 for array arguments here.
11168 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
11169 instead of the default for ValueTypes.
11171 (New.DoEmit): Use IsValueType instead of
11172 IsSubclassOf (value_type)
11173 (New.DoResolve): ditto.
11174 (Invocation.EmitCall): ditto.
11176 * assign.cs (Assign): ditto.
11178 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
11179 Statements *are* currently doing part of their resolution during
11182 Expressions do always resolve during resolve, but statements are
11183 only required to propagate resolution to their children.
11185 2002-07-11 Miguel de Icaza <miguel@ximian.com>
11187 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
11189 (LoadAssembly): Do not add the dll if it is already specified
11191 (MainDriver): Add the System directory to the link path at the end,
11192 after all the other -L arguments.
11194 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
11195 wrong opcode for loading bytes and bools (ldelem.i1 instead of
11196 ldelem.u1) and using the opposite for sbytes.
11198 This fixes Digger, and we can finally run it.
11200 * driver.cs (UnixParseOption): Move the option parsing here.
11201 (CSCParseOption): Implement CSC-like parsing of options.
11203 We now support both modes of operation, the old Unix way, and the
11204 new CSC-like way. This should help those who wanted to make cross
11205 platform makefiles.
11207 The only thing broken is that /r:, /reference: and /lib: are not
11208 implemented, because I want to make those have the same semantics
11209 as the CSC compiler has, and kill once and for all the confussion
11210 around this. Will be doing this tomorrow.
11212 * statement.cs (Unsafe.Resolve): The state is checked during
11213 resolve, not emit, so we have to set the flags for IsUnsfe here.
11215 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11217 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
11218 not catch the Error_ObjectRefRequired in SimpleName (as it is
11219 possible to have a class/instance variable name that later gets
11220 deambiguated), we have to check this here.
11222 2002-07-10 Ravi Pratap <ravi@ximian.com>
11224 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
11225 make static and put into Expression.
11227 (Event.Define): Register the private field of the event with the
11228 TypeManager so that GetFieldFromEvent can get at it.
11230 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
11231 keep track of the private field associated with an event which
11234 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
11237 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
11239 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11241 * expression.cs (Binary.EmitBranchable): this routine emits the
11242 Binary expression in a branchable context. This basically means:
11243 we need to branch somewhere, not just get the value on the stack.
11245 This works together with Statement.EmitBoolExpression.
11247 * statement.cs (Statement.EmitBoolExpression): Use
11250 2002-07-09 Miguel de Icaza <miguel@ximian.com>
11252 * statement.cs (For): Reduce the number of jumps in loops.
11254 (For): Implement loop inversion for the For statement.
11256 (Break): We can be breaking out of a Try/Catch controlled section
11257 (foreach might have an implicit try/catch clause), so we need to
11258 use Leave instead of Br.
11260 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
11261 now). If the instace expression supports IMemoryLocation, we use
11262 the AddressOf method from the IMemoryLocation to extract the
11263 address instead of emitting the instance.
11265 This showed up with `This', as we were emitting the instance
11266 always (Emit) instead of the Address of This. Particularly
11267 interesting when This is a value type, as we dont want the Emit
11268 effect (which was to load the object).
11270 2002-07-08 Miguel de Icaza <miguel@ximian.com>
11272 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
11274 * statement.cs (Checked): Set the CheckedState during the resolve
11275 process too, as the ConvCast operations track the checked state on
11276 the resolve process, and not emit.
11278 * cs-parser.jay (namespace_member_declaration): Flag that we have
11279 found a declaration when we do. This is used to flag error 1529
11281 * driver.cs: Report ok when we display the help only.
11283 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
11285 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
11287 2002-07-04 Miguel de Icaza <miguel@ximian.com>
11289 * cs-tokenizer.cs (define): We also have to track locally the
11290 defines. AllDefines is just used for the Conditional Attribute,
11291 but we also need the local defines for the current source code.
11293 2002-07-03 Miguel de Icaza <miguel@ximian.com>
11295 * statement.cs (While, For, Do): These loops can exit through a
11296 Break statement, use this information to tell whether the
11297 statement is the last piece of code.
11299 (Break): Flag that we break.
11301 * codegen.cs (EmitContexts): New `Breaks' state variable.
11303 2002-07-03 Martin Baulig <martin@gnome.org>
11305 * class.cs (TypeContainer.MethodModifiersValid): Allow override
11306 modifiers in method declarations in structs. Otherwise, you won't
11307 be able to override things like Object.Equals().
11309 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11311 * class.cs (Method, Property, Indexer): Do not allow the public
11312 modifier to be used in explicit interface implementations.
11314 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
11315 override modifiers in method declarations in structs
11317 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
11319 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
11320 integer or real overflow, report an error
11322 2002-07-02 Martin Baulig <martin@gnome.org>
11324 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
11325 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
11326 to tell the runtime about our newly created System.Object and
11327 System.ValueType types.
11329 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11331 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
11332 struct instead of Ldarg/Starg.
11334 2002-07-02 Martin Baulig <martin@gnome.org>
11336 * expression.cs (Indirection.Indirection): Call
11337 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
11339 2002-07-02 Martin Baulig <martin@gnome.org>
11341 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
11342 ValueType, call TypeManager.TypeToCoreType() on it.
11343 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
11344 the OpCodes.Newarr argument.
11346 2002-07-02 Martin Baulig <martin@gnome.org>
11348 * expression.cs (Invocation.EmitCall): When compiling corlib,
11349 replace all calls to the system's System.Array type to calls to
11350 the newly created one.
11352 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
11353 System.Array methods.
11354 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
11355 from the system's System.Array type which must be replaced.
11357 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
11359 * typemanager.cs: load unverifiable_code_ctor so we can build
11360 corlib using the correct type. Avoid using GetTypeCode() with
11362 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
11363 TypeManager.object_type to allow building corlib.
11365 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
11367 * ecore.cs: handle System.Enum separately in LoadFromPtr().
11369 2002-07-01 Martin Baulig <martin@gnome.org>
11371 * class.cs: Make the last change actually work, we need to check
11372 whether `ifaces != null' to avoid a crash.
11374 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11376 * class.cs: when we build structs without fields that implement
11377 interfaces, we need to add the interfaces separately, since there is
11378 no API to both set the size and add the interfaces at type creation
11381 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11383 * expression.cs: the dimension arguments to the array constructors
11384 need to be converted if they are a long.
11386 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
11388 * class.cs: don't emit ldarg.0 if there is no parent constructor
11389 (fixes showstopper for corlib).
11391 2002-06-29 Martin Baulig <martin@gnome.org>
11393 MCS now compiles corlib on GNU/Linux :-)
11395 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
11396 ie. check for MethodImplOptions.InternalCall.
11398 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
11399 and TypeManager.attribute_type are null, so we must explicitly check
11400 whether parent is not null to find out whether it's an attribute type.
11401 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
11402 and SetBuilder, not only if the property is neither abstract nor external.
11403 This is necessary to set the MethodImplOptions on the accessor methods.
11404 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
11405 SetBuilder, see Property.Emit().
11407 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
11408 populate "System.Object", "System.ValueType" and "System.Attribute" since
11409 they've already been populated from BootCorlib_PopulateCoreTypes().
11411 2002-06-29 Martin Baulig <martin@gnome.org>
11413 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
11414 is the NullLiteral, we also need to make sure that target_type is not
11417 2002-06-29 Martin Baulig <martin@gnome.org>
11419 * rootcontext.cs (RootContext.ResolveCore): We must initialize
11420 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
11421 before calling BootstrapCorlib_ResolveDelegate ().
11423 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11425 * statement.cs: fixed build-breaker. All tests passed ok.
11427 2002-06-27 Martin Baulig <martin@gnome.org>
11429 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
11430 for System.Decimal when compiling corlib.
11432 2002-06-27 Martin Baulig <martin@gnome.org>
11434 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
11435 switch blocks which contain nothing but a default clause.
11437 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
11439 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
11441 2002-06-27 Martin Baulig <martin@gnome.org>
11443 * ecore.cs (PropertyExpr.PropertyExpr): Call
11444 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
11446 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
11447 is already a TypeBuilder.
11449 2002-06-27 Martin Baulig <martin@gnome.org>
11451 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
11452 `target_type == TypeManager.array_type', not IsAssignableFrom() in
11453 the "from an array-type to System.Array" case. This makes it work
11454 when compiling corlib.
11456 2002-06-27 Martin Baulig <martin@gnome.org>
11458 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
11459 non-static PropertyExpr, set its InstanceExpression. This makes
11460 the `ICollection.Count' property work in System/Array.cs.
11462 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
11464 * driver.cs: Made error handling more consistent. Errors now
11465 tracked by Report class, so many methods which used to return int
11466 now return void. Main() now prints success/failure and
11467 errors/warnings message.
11469 Renamed '--probe' compiler argument to '--expect-error'. Removed
11470 the magic number return values (123 and 124). Now, if the
11471 expected error occurs, the compiler exits with success (exit value
11472 0). If the compilation completes without seeing that particular
11473 error, the compiler exits with failure (exit value 1). The
11474 makefile in mcs/errors has been changed to handle the new behaviour.
11476 * report.cs: Made 'expected error' number a property and renamed
11477 it from 'Probe' to 'ExpectedError'.
11479 * genericparser.cs: Removed error handling support, since it is
11480 now all done by Report class.
11482 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
11483 class, so parse() no longer returns an int.
11485 * namespace.cs: Use Report.Error instead of GenericParser.error
11487 2002-06-22 Miguel de Icaza <miguel@ximian.com>
11489 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
11490 TypeContainer.AddOperator): At the front of the list put the
11491 explicit implementations, so they get resolved/defined first.
11493 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11495 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11496 interface type is implemented by this TypeContainer. Used during
11497 explicit interface implementation.
11499 (Property.Define, Indexer.Define, Method.Define): Validate that
11500 the given interface in the explicit implementation is one of the
11501 base classes for the containing type.
11503 Also if we are explicitly implementing an interface, but there is
11504 no match in the pending implementation table, report an error.
11506 (Property.Define): Only define the property if we are
11507 not explicitly implementing a property from an interface. Use the
11508 correct name also for those properties (the same CSC uses,
11509 although that is really not needed).
11511 (Property.Emit): Do not emit attributes for explicitly implemented
11512 properties, as there is no TypeBuilder.
11514 (Indexer.Emit): ditto.
11516 Hiding then means that we do not really *implement* a pending
11517 implementation, which makes code fail.
11519 2002-06-22 Martin Baulig <martin@gnome.org>
11521 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11522 the return value of Object.GetType(). [FIXME: we need to do this whenever
11523 we get a type back from the reflection library].
11525 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11527 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11529 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11531 * attribute.cs: Return null if we can not look up the type.
11533 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11534 the interface types found.
11536 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11537 interface types found.
11539 * typemanager.cs (GetInterfaces): Make this routine returns alll
11540 the interfaces and work around the lame differences between
11541 System.Type and System.Reflection.Emit.TypeBuilder in the results
11542 result for GetInterfaces.
11544 (ExpandInterfaces): Given an array of interface types, expand and
11545 eliminate repeated ocurrences of an interface. This expands in
11546 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11549 2002-06-21 Martin Baulig <martin@gnome.org>
11551 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11554 2002-06-21 Martin Baulig <martin@gnome.org>
11556 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11557 and called with one of the core types, return the corresponding typebuilder for
11560 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11563 2002-06-21 Martin Baulig <martin@gnome.org>
11565 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11566 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11567 (Expression.ConvertReferenceExplicit): Likewise.
11569 * expression.cs (ElementAccess.DoResolve): Likewise.
11570 (ElementAccess.DoResolveLValue): Likewise.
11572 2002-06-10 Martin Baulig <martin@gnome.org>
11574 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11575 add the "value" parameter to the parameter list.
11577 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11580 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11582 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11583 the argument to an int, uint, long or ulong, per the spec. Also
11584 catch negative constants in array creation.
11586 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11588 * class.cs: do not allow the same interface to appear twice in
11589 the definition list.
11591 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11593 * ecore.cs: don't use ldlen with System.Array.
11595 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11597 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11599 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11601 * modifiers.cs: produce correct field attributes for protected
11602 internal. Easy fix so miguel can work on ther harder stuff:-)
11604 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11606 * pending.cs: New file. Move the code from class.cs here.
11607 Support clearning the pending flag for all methods (when not doing
11608 explicit interface implementation).
11610 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11612 * rootcontext.cs: added a couple more types needed to bootstrap.
11614 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11616 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11617 constructor in the type, instead of any constructor in the type
11618 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11619 a bug in the Mono runtime when applying the params attribute).
11621 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11622 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11624 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11626 * expression.cs (Unary.ResolveOperator): Use TypeManager
11627 to resolve the type.
11629 2002-06-13 Ravi Pratap <ravi@ximian.com>
11631 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11634 * enum.cs (AddEnumMember): Add support to store the attributes associated
11635 with each member too.
11637 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11638 field builders too - this takes care of the enum member case.
11640 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11642 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11643 address-of operator on both value types and pointers.
11645 2002-06-10 Martin Baulig <martin@gnome.org>
11647 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11648 PropertyBuilder to the `property_builders' list.
11650 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11651 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11652 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11653 find any indexers which are inherited from an interface.
11655 2002-06-09 Martin Baulig <martin@gnome.org>
11657 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11658 the same type as the constant if necessary. There's also a test-130.cs
11661 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11663 * typemanager.cs (TypeManager.ChangeType): Previously known as
11664 Enum.ChangeEnumType().
11666 2002-06-09 Martin Baulig <martin@gnome.org>
11668 * expression.cs (Cast.TryReduce): Added support for consts.
11670 2002-06-08 Ravi Pratap <ravi@ximian.com>
11672 * class.cs (Accessor): Hold attributes information so we can pass
11675 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11676 Modify to pass in attributes attached to the methods.
11678 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11680 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11681 to handle the Accessor kind :-)
11683 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11685 2002-06-08 Martin Baulig <martin@gnome.org>
11687 * expression.cs (Unary.TryReduceNegative): Added support for
11690 2002-06-08 Martin Baulig <martin@gnome.org>
11692 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11693 name can't be found in the `defined_names' - the caller will do a
11694 MemberLookup in this case and thus find methods in System.Enum
11695 such as Enum.IsDefined().
11697 2002-06-08 Martin Baulig <martin@gnome.org>
11699 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11700 Convert.ChangeType() which works with TypeBuilder created types.
11701 (Enum.LookupEnumValue, Enum.Define): Use it here.
11703 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11704 `TypeBuilder.BaseType != null' check.
11705 (TypeContainer.FindMembers): Only lookup parent members if we
11706 actually have a parent.
11707 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11708 (ConstructorInitializer.Resolve): Likewise.
11710 * interface.cs (Interface.FindMembers): Added
11711 `TypeBuilder.BaseType != null' check.
11713 * rootcontext.cs (RootContext.ResolveCore): Added
11714 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11715 classes_second_stage.
11717 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11718 debug_type and trace_type when compiling with --nostdlib.
11720 2002-06-07 Martin Baulig <martin@gnome.org>
11722 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11723 (AddField): Set it to true when adding a non-static field.
11724 (DefineType): Use `have_nonstatic_fields' to find out whether we
11725 have non-static fields, not `Fields != null'.
11727 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11729 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11730 dereferencing a null on the static-field code path)
11732 2002-05-30 Martin Baulig <martin@gnome.org>
11734 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11735 to take command line arguments. Use reflection to call the new
11736 custom `Initialize' function on the symbol writer and pass it the
11737 command line arguments.
11739 * driver.cs (--debug-args): New command line argument to pass command
11740 line arguments to the symbol writer.
11742 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11744 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11745 the target type for indexers and properties. Thanks to Joe for
11748 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11750 * typemanager.cs (MethodFlags): returns the method flags
11751 (Obsolete/ShouldIgnore) that control warning emission and whether
11752 the invocation should be made, or ignored.
11754 * expression.cs (Invocation.Emit): Remove previous hack, we should
11755 not do this on matching a base type, we should do this based on an attribute
11757 Only emit calls to System.Diagnostics.Debug and
11758 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11759 on the command line.
11761 * rootcontext.cs: Global settings for tracing and debugging.
11763 * cs-tokenizer.cs (define): New utility function to track
11764 defines. Set the global settings for TRACE and DEBUG if found.
11766 2002-05-25 Ravi Pratap <ravi@ximian.com>
11768 * interface.cs (Populate*): Pass in the TypeContainer as well as
11769 the DeclSpace as parameters so that we can create EmitContexts and
11770 then use that to apply attributes etc.
11772 (PopulateMethod, PopulateEvent, PopulateProperty)
11773 (PopulateIndexer): Apply attributes everywhere.
11775 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11778 (ApplyAttributes): Update accordingly.
11780 We now apply interface attributes for all members too.
11782 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11784 * class.cs (Indexer.Define); Correctly check if we are explicit
11785 implementation (instead of checking the Name for a ".", we
11786 directly look up if the InterfaceType was specified).
11788 Delay the creation of the PropertyBuilder.
11790 Only create the PropertyBuilder if we are not an explicit
11791 interface implementation. This means that explicit interface
11792 implementation members do not participate in regular function
11793 lookups, and hence fixes another major ambiguity problem in
11794 overload resolution (that was the visible effect).
11796 (DefineMethod): Return whether we are doing an interface
11799 * typemanager.cs: Temporary hack until we get attributes in
11800 interfaces (Ravi is working on that) and we get IndexerName
11801 support in interfaces.
11803 * interface.cs: Register the indexers as properties.
11805 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11806 warning, I have verified that this is a bug in the .NET runtime
11807 (JavaScript suffers of the same problem).
11809 * typemanager.cs (MemberLookup): When looking up members for
11810 interfaces, the parent of an interface is the implicit
11811 System.Object (so we succeed in searches of Object methods in an
11812 interface method invocation. Example: IEnumerable x; x.ToString
11815 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11817 * class.cs (Event): Events should also register if they do
11818 implement the methods that an interface requires.
11820 * typemanager.cs (MemberLookup); use the new GetInterfaces
11823 (GetInterfaces): The code used to lookup interfaces for a type is
11824 used in more than one place, factor it here.
11826 * driver.cs: Track the errors at the bottom of the file, we kept
11829 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11830 instance if the method we are calling is static!
11832 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11834 * attribute.cs (ApplyAttributes): Make this function filter out
11835 the IndexerName attribute (as that attribute in reality is never
11836 applied) and return the string constant for the IndexerName
11839 * class.cs (TypeContainer.Emit): Validate that all the indexers
11840 have the same IndexerName attribute, and if so, set the
11841 DefaultName attribute on the class.
11843 * typemanager.cs: The return value might contain other stuff (not
11844 only methods). For instance, consider a method with an "Item"
11845 property and an Item method.
11847 * class.cs: If there is a problem with the parameter types,
11850 2002-05-24 Ravi Pratap <ravi@ximian.com>
11852 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11853 looks at user defined conversion after making a call to
11854 StandardConversionExists - we need this for overload resolution.
11856 * expression.cs : Update accordingly the various method calls.
11858 This fixes 2 bugs filed against implicit user defined conversions
11860 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11862 * statement.cs: Track the result of the assignment.
11864 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11866 * expression.cs (MemberAccess): Improved error reporting for
11867 inaccessible members.
11869 2002-05-22 Martin Baulig <martin@gnome.org>
11871 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11872 itself with debugging support.
11874 2002-05-22 Martin Baulig <martin@gnome.org>
11876 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11877 Removed, this isn't needed anymore.
11879 2002-05-20 Martin Baulig <martin@gnome.org>
11881 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11882 be underlying type for an enum.
11884 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11886 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11887 that splits out the loading of just the core types.
11889 * rootcontext.cs (ResolveCore): Split the struct resolution in
11890 two, so we can load the enumeration underlying types before any
11893 * expression.cs (Is): Bandaid until we fix properly Switch (see
11894 bug #24985 for details).
11896 * typemanager.cs (ImplementsInterface): The hashtable will contain
11897 a null if there are no interfaces implemented.
11899 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11901 * cs-parser.jay (indexer_declarator): It is fine to have array
11904 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11906 * typemanager.cs: (RegisterBuilder): New function used to register
11907 TypeBuilders that implement interfaces. Since
11908 TypeBuilder.GetInterfaces (as usual) does not work with lame
11910 (AddUserType): register interfaces.
11912 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11913 dealing with TypeBuilder. Also, arrays are showing up as
11914 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11915 methods can not be invoked on them!
11917 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11918 (ImplicitReferenceConversionExists): Split out from
11919 StandardConversionExists.
11921 * expression.cs (As): We were only implementing one of the three
11922 cases for the as operator. We now implement them all.
11923 (Is): Implement the various other cases for Is as well.
11925 * typemanager.cs (CACHE): New define used to control if we want or
11926 not the FindMembers cache. Seems to have a negative impact on
11927 performance currently
11929 (MemberLookup): Nested types have full acess to
11930 enclosing type members
11932 Remove code that coped with instance/static returns for events, we
11933 now catch this in RealFindMembers.
11935 (RealFindMembers): only perform static lookup if the instance
11936 lookup did not return a type or an event.
11938 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11940 * assign.cs (CompoundAssign): We pass more semantic information
11941 now to Compound Assignments than we did before: now we have all
11942 the information at hand, and now we resolve the target *before* we
11943 do the expression expansion, which allows the "CacheValue" method
11944 to have the effect we intended (before, a [x] += 1 would generate
11945 two differen ArrayAccess expressions from the ElementAccess,
11946 during the resolution process).
11948 (CompoundAssign.DoResolve): Resolve target and original_source here.
11950 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11952 * expression.cs (ArrayAccess): dropped debugging information.
11954 * typemanager.cs: Small bug fix: I was always returning i_members,
11955 instead of one of i_members or s_members (depending on which had
11958 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11959 method is invoked before any code generation takes place, and it
11960 is a mechanism to inform that the expression will be invoked more
11961 than once, and that the method should use temporary values to
11962 avoid having side effects
11964 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11966 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11969 * expression.cs (Indirection, ArrayAccess): Add support for
11970 CacheTemporaries in these two bad boys.
11972 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11973 ldobj or ldind_ref.
11974 (StoreFromPtr): Handle stobj as well.
11976 * expression.cs (UnaryMutator): Share more code.
11978 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11979 down: I was not tracking the Filter function as well, which
11980 was affecting the results of the cache.
11982 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11984 * attribute.cs: Remove the hack to handle the CharSet property on
11987 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11989 * attribute.cs (DoResolve): More uglyness, we now only try to
11990 resolve the attribute partially, to extract the CharSet
11991 information (only if we are a StructLayout attribute). Otherwise
11993 (GetExtraTypeInfo): Add some code to conditionally kill in the
11994 future this. I am more and more convinced that the .NET
11995 framework has special code to handle the attribute setting on
11998 * expression.cs (IsParamsMethodApplicable): Revert my previous
11999 foreach change here, it was wrong.
12001 2002-05-13 Miguel de Icaza <miguel@ximian.com>
12003 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
12004 (pp_expr): do not abort on unknown input, just return.
12005 (eval): abort if there are pending chars.
12007 * attribute.cs (Attribute.Resolve): Positional parameters are
12008 optional. Deal with that case.
12010 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
12011 the Ansi/Unicode/Auto information for the type.
12013 (TypeContainer.DefineType): instantiate the EmitContext here, as
12014 we will be using it during the type definition (to resolve
12015 attributes) and during the emit phase.
12017 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
12018 to pull type information out of the attributes
12020 (Attribute.Resolve): track the constructor builder, and allow for
12021 multiple invocations (structs and classes will use this).
12023 * ecore.cs (MemberLookupFinal): new version with all the
12024 parameters customizable.
12026 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
12027 constructors. Return if the result value is null (as the error
12028 would have been flagged already by MemberLookupFinal)
12030 Do not allow instances of abstract classes or interfaces to be
12033 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
12034 We have to compare the assembly property here when dealing with
12035 FamANDAssem and Assembly access modifiers, because we might be
12036 creating an assembly from *modules* (that means that we are not
12037 getting TypeBuilders for types defined in other modules that are
12038 part of this assembly).
12040 (Method.Emit): If the method is marked abstract and has a body,
12043 (TypeContainer.DefineMembers): If both the defined member and the
12044 parent name match are methods, then do not emit any warnings: let
12045 the Method.Define routine take care of flagging warnings. But if
12046 there is a mismatch (method overrides something else, or method is
12047 overriwritten by something, then emit warning).
12049 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
12050 set to null, this means `do not check for the return type on the
12053 (Method.Define): set the return type for the method signature to
12054 null, so that we get methods with the same name and parameters and
12055 different return types. This is used to flag warning 114 (you are
12056 hiding a method, and you probably want to use the new/override
12059 * typemanager.cs (MemberLookup): Implemented proper access
12060 control, closing a long standing set of bug reports. The problem
12061 was that the Framework only has two bits: Public and NonPublic,
12062 and NonPublic includes private and protected methods, but we need
12063 to enforce the FamANDAssem, FamOrAssem and Family.
12065 2002-05-11 Miguel de Icaza <miguel@ximian.com>
12067 * statement.cs (GotoCase): Return true: Ammounts to giving up
12068 knowledge on whether we return or not, and letting the other case
12069 be responsible for it.
12071 2002-05-10 Miguel de Icaza <miguel@ximian.com>
12073 * driver.cs: Do not load directories for each file processed, only
12074 do it if there is a pattern.
12076 * ecore.cs: Report readonly assigns here as well, as we might have
12077 been resolved only by MemberAccess.
12079 (SimpleName.SimpleNameResolve): Also be useful for LValue
12080 resolution. We need this to propagate assign to local readonly variables
12082 * typemanager.cs: Use a ptrhashtable for the criteria, because we
12083 do not want to reuse potential criteria memory.
12085 * class.cs (MyEventBuilder): Set reflected_type;
12087 * ecore.cs (Constantify): Added support for constifying bools.
12089 (RootContext.LookupType): Added a cache for values looked up in
12090 the declaration space.
12092 * typemanager.cs (FindMembers): Now is a front-end to
12093 RealFindMembers, and provides a two-level hashtable-based cache to
12096 15% performance improvement: from 22.5 to 19.2 seconds.
12098 * expression.cs (IsParamsMethodApplicable): use foreach.
12099 (Invocation.DoResolve): ditto.
12100 (New.DoResolve): ditto.
12101 (ArrayCreation.DoResolve): ditto.
12103 * ecore.cs (FindMostEncompassingType): use foreach.
12105 * delegate.cs (NewDelegate.DoResolve): Use foreach
12107 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
12108 (RemoveMethods): use foreach.
12110 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
12111 nested foreach statements instead of for, and also break out of
12112 the inner loop once a match is found.
12114 (Invocation.OverloadResolve): Use foreach, simplify the code.
12116 2002-05-08 Miguel de Icaza <miguel@ximian.com>
12118 * cfold.cs (BinaryFold): During an enumeration evaluation context,
12119 we actually unwrap the expression to allow for extra information
12122 * expression.cs: Use Shr_Un on unsigned operations.
12124 2002-05-08 Ravi Pratap <ravi@ximian.com>
12126 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
12127 applicable operators was not being considered correctly. This closes
12128 the bug Miguel reported.
12130 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
12132 * attribute.cs: check that the type derives from System.Attribute
12133 and report the correct error in that case (moved the duplicate code to
12134 its own method, too).
12136 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
12138 * attribute.cs: lookup attribute type name as the spec says: first the
12139 bare attribute name and then name + "Attribute" (nant compiles with
12140 mcs after this fix).
12142 2002-05-07 Miguel de Icaza <miguel@ximian.com>
12144 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
12145 Because of the way we parse things, we should try to see if a
12146 UIntConstant can fit in an integer.
12148 2002-05-07 Ravi Pratap <ravi@ximian.com>
12150 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
12151 when we are in an explicit context.
12153 (ConvertReferenceExplicit): When converting from Iface type S to Class
12154 T make sure the rules are implemented as an OR.
12156 * parameter.cs (ParameterType): Make it a property for now although the
12157 purpose really isn't anything immediate.
12159 * expression.cs (Is*Applicable): Do better checking on the parameter type
12160 of a ref/out parameter. The ones from the system assemblies are already
12161 marked with the correct type so we don't need to do any correction.
12163 * ecore.cs (StandardConversionExists): Conversion from Interface types to
12164 the object type is standard too so include that.
12166 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12168 * ecore.cs (StandardConversionExists): Augment with missing code:
12169 deal with IntConstant, LongConstants and Enumerations.
12171 * assign.cs: Report the error, instead of failing silently
12173 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
12174 typecontainer that they are declared, because the
12175 typecontainer/namespace will have the list of using clauses that
12176 need to be applied.
12178 Assembly Attributes were escaping the normal registration
12181 (EmitCode): Apply attributes within an EmitContext that represents
12182 the container they were declared on.
12184 * cs-parser.jay: Track bases for structs. How did I get this wrong?
12186 2002-05-06 Ravi Pratap <ravi@ximian.com>
12188 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
12189 Revamp completely - make much cleaner as we now operate only
12192 (FindMostSpecificSource, FindMostSpecificTarget): New methods
12193 to implement the logic detailed in the spec more correctly.
12195 (UserDefinedConversion): Update accordingly.
12197 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12199 * statement.cs: Return flow analysis information up.
12201 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
12204 (token): Do not consume an extra character before calling
12207 2002-05-06 Piers Haken <piersh@friskit.com>
12209 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
12211 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12213 * class.cs (Constructor.Emit): Set the IsStatic flag in the
12214 EmitContext during the instance constructor initializer
12215 resolution, to stop access to instance variables.
12217 This is mandated by the spec, last paragraph of the `constructor
12218 initializers' section.
12220 2002-05-05 Miguel de Icaza <miguel@ximian.com>
12222 * cs-parser.jay, class.cs (Accessor): new class used to represent
12223 an accessor (get or set). In the past we used `null' to represent
12224 a missing accessor. But this is ambiguous because there was no
12225 way to tell in abstract indexers/properties if one of them was
12228 Now there is a way of addressing that.
12230 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
12231 instead of FindMembers.
12233 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
12234 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
12236 * attribute.cs: Treat indexers and properties as the same in terms
12237 of applying attributes
12239 * ecore.cs (FindMostEncompassedType): Use statically initialized
12240 EmptyExpressions()s like we do elsewhere to avoid creating useless
12241 objects (and we take this out of the tight loop).
12243 (GetConversionOperators): Move the code to extract the actual
12244 operators to a separate routine to clean things up.
12246 2002-05-04 Miguel de Icaza <miguel@ximian.com>
12248 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
12249 events are always registered FieldBuilders.
12251 * class.cs (FieldBase): New class shared by Fields
12253 * delegate.cs: If we are a toplevel delegate, use our full name.
12254 If we are a nested delegate, then only use our tail name.
12256 2002-05-02 Ravi Pratap <ravi@ximian.com>
12258 * expression.cs (IsApplicable): Ensure that we add the "&" to
12259 ref/out types before comparing it with the type of the argument.
12261 (IsParamsMethodApplicable): Ditto.
12263 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
12266 * delegate.cs : Handle the case when we have more than one applicable
12267 method. Flag an error only when we finish checking all.
12269 2002-05-02 Miguel de Icaza <miguel@ximian.com>
12271 * expression.cs: Add support for boolean static initializers.
12273 2002-05-01 Miguel de Icaza <miguel@ximian.com>
12275 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
12277 * parameter.cs (ComputeParameterTypes,
12278 ComputeAndDefineParameterTypes): Better error handling: now we
12279 clear the `types' cache if we fail during any of the type lookups.
12280 We also return the status code correctly to our caller
12282 * delegate.cs: If we fail to define a delegate, abort the extra
12285 * expression.cs (Binary.ResolveOperator): for
12286 operator==(object,object) and operator !=(object, object) we also
12287 have to verify that there is an implicit conversion from one to
12290 (ArrayAccess.DoResolve): Array Access can operate on
12293 2002-04-30 Miguel de Icaza <miguel@ximian.com>
12295 * assign.cs (CompoundAssign): A new class used as a "flag" that
12296 the assignment actually is happening as part of a compound
12297 assignment operator.
12299 During compound assignment, a few new rules exist to enable things
12306 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
12307 to the type of x) if y is implicitly convertible to the type of x,
12308 and the operator is a builtin operator and the return type of the
12309 operator is explicitly convertible to the type of x.
12311 * rootcontext.cs: Reset warning level to 2. 4 catches various
12312 "interesting" features in mcs, we must clean this up at some
12313 point, but currently am trying to kill other bugs ;-)
12315 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
12316 in container classes as well.
12318 * expression.cs (Binary.ResolveOperator): Handle string case
12319 before anything else (as operator overloading does emit an error
12320 before doing anything else).
12322 This code could go away when we move to a table driven model, but
12323 i could not come up with a good plan last night.
12325 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
12327 * typemanager.cs (CSharpName): reimplementation using regex.
12328 * class.cs: added null check for fields in Emit
12329 * rootcontext.cs: set warninglevel to 4
12331 2002-04-29 Miguel de Icaza <miguel@ximian.com>
12333 * typemanager.cs (CSharpName): reimplemented with Lupus
12336 2002-04-28 Miguel de Icaza <miguel@ximian.com>
12338 * statement.cs (If): correclty implement Resolve, because we were
12339 not catching sem errors in there. The same process is needed
12341 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
12344 (Statement.Warning_DeadCodeFound): Factorize code.
12345 (While): Report dead code here too.
12347 (Statement): Added Resolve virtual method to allow
12348 for resolution split from the emit code.
12350 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12352 * statement.cs (EmitBoolExpression): No longer try to resolve the
12354 (MakeBoolean): New utility function that resolve, implicitly
12355 converts to boolean and tags the expression.
12358 (If, Do): Implement dead code elimination.
12359 (While): Implement loop inversion
12361 (Do, While, For, If): Resolve the expression prior to calling our
12364 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
12367 - added method Report28 (warning: program has more than one entry point)
12368 - added method IsEntryPoint, implements paragraph 10.1 of the spec
12369 - modified method Method.Define, the part at the end of the method
12371 * rootcontext.cs: added static public Location EntryPointLocation;
12373 * ../errors/cs0028.cs : Add test case for the above warning.
12376 - modified method CSharpName to allow arrays of primitive type to
12377 be printed nicely (e.g. instead of System.Int32[][] it now prints
12379 - added method CSharpSignature: returns the signature of a method
12380 in string format to be used in reporting errors, warnings, etc.
12382 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
12385 2002-04-26 Ravi Pratap <ravi@ximian.com>
12387 * delegate.cs (Define): Fix extremely silly bug where I was
12388 setting the type of the 'object' parameter of the BeginInvoke
12389 method to System.IAsyncResult instead of System.Object ;-)
12391 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12393 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
12396 (Constructor.Emit): return if we fail to initialize the
12397 constructor. Another door closed!
12399 * expression.cs (New.DoResolve): Improve error message (from -6 to
12400 1501). Use DeclaredOnly lookup to find the exact constructor.
12402 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
12403 loop. This is useful.
12405 * cs-parser.jay: Adjust the default parameters so that destructors
12406 have the proper signature.
12408 2002-04-26 Martin Baulig <martin@gnome.org>
12410 * driver.cs (LoadAssembly): If `assembly' contains any characters
12411 which are only valid in path names and not in assembly names
12412 (currently slash, backslash and point), use Assembly.LoadFrom ()
12413 instead of Assembly.Load () on the `assembly' (before iteration
12414 over the link_paths).
12416 2002-04-26 Martin Baulig <martin@gnome.org>
12418 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
12420 2002-04-25 Miguel de Icaza <miguel@ximian.com>
12422 * class.cs (Property): use the new typemanager.MemberLookup
12424 (TypeContainer.MemberLookup): Implement using the
12425 TypeManager.MemberLookup now.
12427 * typemanager.cs: Make MemberLookup a function of the TypeManager,
12428 and return MemberInfos, so that these can be used without an
12429 EmitContext (what we had before).
12431 2002-04-24 Miguel de Icaza <miguel@ximian.com>
12433 * expression.cs: Fix the case where the argument to params if the
12434 type of the params. I omitted handling this before. Fixed
12436 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12438 * driver.cs: Call BootCorlib_PopulateCoreType
12440 * class.cs (Property.CheckBase): Check for properties only, not
12443 * interface.cs: Temporary hack: try/catch around the
12444 CustomAttributeBuilder, because I am getting an exception that I
12447 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
12448 types whose definitions are required to be there (attributes are
12449 defined before standard types).
12451 Compute definitions as we boot the various types, as they are used
12452 immediately (value_type class will need object_type, but if we do
12453 not initialize object_type, we will pass a null, which will let
12454 the runtime pick the System.Object from the existing corlib, which
12455 is not what we want).
12457 2002-04-22 Patrik Torstensson <totte@labs2.com>
12459 * cs-tokenizer.cs: fixed a number of trim() issues.
12461 2002-04-22 Ravi Pratap <ravi@ximian.com>
12463 * expression.cs (Argument.Type): Ensure that we return the correct
12464 type when we have out or ref parameters [in which case we
12467 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12469 * class.cs (Property, Indexer): Allow extern modifier in there.
12471 * typemanager.cs (InitBaseTypes): Initializes object_type and
12472 value_type, since those will be used early on during the bootstrap
12473 process to compile corlib.
12475 (InitCoreTypes): Move code from here to InitBaseTypes.
12477 2002-04-21 Miguel de Icaza <miguel@ximian.com>
12479 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
12480 single-dimension arrays as using the ldlen opcode.
12482 Daniel Lewis discovered this optimization.
12484 * typemanager.cs: Add signature for System.Array::get_Length
12486 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12488 * statement.cs: report the error when the foreach does not apply to an
12489 array nor a collection.
12491 2002-04-19 Miguel de Icaza <miguel@ximian.com>
12493 * expression.cs: Add implicit conversions to the operator ~.
12495 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12497 * typemanager.cs: Locate the decimal constructor.
12499 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12501 * attribute.cs: use the new property of TypeOf.
12502 * expression.cs: added 'get' property around typearg.
12504 These changes fix a build breaker reported by NickD. Is this the
12505 correct way to fix? If not, please, revert my changes and make it
12508 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12510 * attribute.cs: Add support for typeof in attribute invocations.
12511 I am not sure that this is right though.
12513 2002-04-14 Duncan Mak <duncan@ximian.com>
12515 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12516 Binary.Operator.Division case.
12518 2002-04-13 Ravi Pratap <ravi@ximian.com>
12520 * class.cs (DefineType): Ensure that we do a proper check on
12521 attribute types and also register it with the TypeManager.
12523 (TypeContainer.Targets): The default for attribute types is
12524 AttributeTargets.All.
12526 * attribute.cs (ApplyAttributes): Registering the attribute type
12527 is done elsewhere, not when we discover we have a Usage attribute.
12529 2002-04-12 Ravi Pratap <ravi@ximian.com>
12531 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12532 and get rid of is_delegate parameter.
12534 * everywhere : update.
12536 2002-04-12 Ravi Pratap <ravi@ximian.com>
12538 * cs-parser.jay (compilation_unit): Revamp completely to use
12539 some new ideas that I got from Rhys' grammar to solve the problems
12540 with assembly level attributes.
12542 (outer_declaration): New grammar production.
12544 (attribute_sections): Add.
12546 (opt_attributes): Base on attribute_sections
12548 (namespace_declaration): Allow opt_attributes to tackle the case
12549 when we have assembly level attributes - we are clever in this
12552 * attribute.cs (ApplyAttributes): Do not worry about assembly
12553 attributes in the non-global context.
12555 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12556 instead of SetGlobalAttributes.
12558 * class.cs, rootcontext.cs : Ensure we define and generate
12559 attribute types before anything else.
12561 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12562 and flag the new error -20 for the case when the attribute type
12563 does not have valid targets specified. csc does not catch this.
12565 * ../errors/errors.txt : update for error # -20
12567 2002-04-11 Ravi Pratap <ravi@ximian.com>
12569 * support.cs (InternalParameters.ParameterModifier): Do some null
12570 checking and return sane values.
12572 * class.cs (Method.Define): If we are a PInvoke method, ensure
12573 that we are static and extern. Report error # 601
12575 * ../errors/cs0601.cs : Add test case for the above error.
12577 2002-04-07 Ravi Pratap <ravi@ximian.com>
12579 * rootcontext.cs (attribute_types): We need to keep type of
12580 all attribute types separately and emit code for them first.
12582 (RegisterAttribute) : Implement.
12584 * class.cs (DefineType): Check if the current Type is a custom
12585 attribute type and register it accordingly.
12587 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12588 adding the first attribute twice and rename to
12590 (SetGlobalAttributes): this.
12592 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12595 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12596 if we are processing global arguments. Hmm, I am unsure of this.
12598 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12600 * expression.cs: added static array of strings to avoid calling
12601 Enum.ToString () for Operator in Binary. Significant recover of
12604 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12606 * class.cs (FindMembers): Allow the Builders of the various
12607 members to be null. If they are skip them. This only happens
12608 during the PInvoke declaration.
12610 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12612 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12613 failure, so we do not keep going afterwards.
12615 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12616 wanted to pass `false' as the `is_delegate' argument. If this is
12617 the case, why not use delegate_type == null to mean `is_delegate =
12618 false' and anything else as is_delegate = true.
12620 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12622 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12623 code for the section, not the beginning of the tests.
12625 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12627 * cfold.cs: Handle operator + (Enum x, Underlying x)
12629 * expression.cs (Binary): same. Warn about errors where we have
12630 Enum/Enum in operator + as well.
12632 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12635 - added support for switch(bool)
12636 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12637 - add TableSwitchEmit() to handle table-based switch statements
12639 2002-04-05 Ravi Pratap <ravi@ximian.com>
12641 * expression.cs (Invocation.OverloadResolve): Factor out code which
12642 does parameter compatibility checking with arguments so that we can
12643 re-use the code even from Delegate.VerifyApplicability
12645 (VerifyArgumentsCompat): Move above code here.
12647 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12648 and instead make a call to the above method.
12650 2002-03-31 Ravi Pratap <ravi@ximian.com>
12652 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12653 We use it to keep track of classes which are attribute types.
12655 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12657 * delegate.cs (Delegate.Define): Correctly define the types in the
12658 presence of fixed and array parameters.
12660 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12663 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12664 include NonPublic after the first iteration.
12666 * class.cs (Indexer.CheckBase): Only check if both parents are
12669 * cs-parser.jay (accessor_body): If empty, set to null.
12671 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12672 same code path here to resolve constants names that we did have in
12673 MemberAccess.DoResolve. There is too much code duplicated here.
12675 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12677 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12679 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12682 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12683 tokens, numbers and strings.
12685 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12688 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12689 asyncronous parameters and the regular parameters.
12691 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12692 specify the target directory.
12694 * expression.cs: (This.DoResolve): Simplify
12695 (As.Emit): Optimize, do not generate IsInst if the expression is
12696 always of the given type.
12698 (Is.DoResolve): Bug fix, we were reporting both always/never for
12701 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12702 creating too many unnecessary arrays.
12704 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12706 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12707 fields instead of rolling our own initializer. Takes care of all
12708 implicit conversions, and drops unnecessary static checks/argument.
12710 2002-03-31 Dick Porter <dick@ximian.com>
12712 * driver.cs: use the GetDirectories() return values properly, and
12713 use "/" as path separator.
12715 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12717 * expression.cs (Unary): Optimize - - expr into expr.
12718 (Binary): Optimize a + (-b) into a -b.
12720 * codegen.cs (CodeGen): Made all methods static.
12722 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12726 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12727 TypeBuilder property.
12729 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12732 * tree.cs: Removed the various RecordXXXX, and replaced with a
12733 single RecordDecl. Removed all the accessor methods, and just
12734 left a single access point Type
12736 * enum.cs: Rename DefineEnum to DefineType.
12738 * decl.cs: New abstract method `DefineType' used to unify the
12739 Defines for Enumerations, Interfaces, TypeContainers and
12742 (FindType): Moved LookupInterfaceOrClass here. Moved the
12743 LookupBaseClasses method that used to live in class.cs and
12744 interface.cs here, and renamed to FindType.
12746 * delegate.cs: Implement DefineType. Take advantage of the
12747 refactored pattern for locating the parent builder without taking
12748 the parent_builder argument (which we know does not work if we are
12749 nested, and triggering a toplevel definition).
12751 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12753 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12754 accessibility of a member has changed during override and report
12757 * class.cs (Method.Define, Property.Define): Only complain on
12758 overrides if the method is private, any other accessibility is
12759 fine (and since we just checked the permission is the same, we are
12762 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12763 and elif are processed always. The other pre-processing
12764 directives are only processed if we are "taking" the path
12766 2002-03-29 Martin Baulig <martin@gnome.org>
12768 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12769 current location is not Null.
12771 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12772 a separate method so we can profile it.
12774 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12775 `span.Seconds' are just seconds, but no minutes or hours.
12776 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12778 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12780 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12781 Remove the gratuitous set of Final:
12783 // If an interface implementation, then we can set Final.
12784 if (((flags & MethodAttributes.Abstract) == 0) &&
12785 implementing.DeclaringType.IsInterface)
12786 flags |= MethodAttributes.Final;
12788 I do not know what I was smoking when I used that.
12791 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12792 step into fixing the name resolution issues for delegates and
12793 unifying the toplevel name resolution.
12795 2002-03-28 Martin Baulig <martin@gnome.org>
12797 * class.cs (Method.Emit): If we have a symbol writer, call its
12798 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12799 tell it about the current method.
12801 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12802 writer that we're going to emit the first byte of IL code for a new
12803 statement (a new source line).
12804 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12805 EmitContext.Mark() before emitting any code.
12807 * location.cs (SymbolDocument): Return null when we're Null.
12809 * statement.cs (Statement): Moved the `Location loc' variable here.
12810 (Statement.EmitBoolExpression): If we have a symbol writer, call
12811 ec.Mark() before emitting any code to tell it that we're at the
12812 beginning of a new statement.
12813 (StatementExpression): Added `Location' argument to the constructor.
12814 (Block): Added public readonly variable `StartLocation' and public
12815 variable `EndLocation'. The latter is to be set using SetEndLocation().
12816 (Block): Added constructor which takes a start and end location.
12817 (Block.SetEndLocation): New method. This sets the end location.
12818 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12819 local variables we create.
12820 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12821 each statement and do also mark the begin and end of the block.
12823 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12824 tell it the current lexer.Location, use Location.Null for the end of the
12826 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12827 current block, set its end location using SetEndLocation().
12828 (statement_expression): StatementExpression constructor now takes the
12829 lexer.Location as additional argument.
12830 (for_statement, declare_local_variables): Likewise.
12831 (declare_local_variables): When creating a new implicit block, use the
12832 new Block constructor and pass it the lexer.Location.
12834 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12836 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12837 members also on the parent interfaces recursively.
12839 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12841 * report.cs: Use new formats, since Gonzalo finished the missing
12844 * expression.cs (Binary.ResolveOperator): added missing operator|
12845 operator& and operator^ for bool/bool.
12847 * cs-parser.jay: CheckDef now takes a Location argument that is
12848 used to report errors more precisly (instead of reporting the end
12849 of a definition, we try to track something which is a lot closer
12850 to the source of the problem).
12852 * cs-tokenizer.cs: Track global token use, so we can properly flag
12853 the use of #define/#undef after the first token has been seen.
12855 Also, rename the reportXXXX to Error_DescriptiveName
12857 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12858 TypeContainer, so that Enum and Interface can use this too.
12860 * class.cs (TypeContainer.LookupInterfaceOrClass,
12861 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12862 `builder' argument. Typically this was used to pass the parent
12863 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12866 The problem is that a nested class could trigger the definition of
12867 a toplevel class, and the builder would be obviously wrong in that
12870 So we drop this argument, and we compute dynamically the
12871 TypeBuilder/ModuleBuilder (the correct information was available
12872 to us anyways from DeclSpace.Parent)
12874 * interface.cs (Interface.DefineInterface): Drop builder
12875 parameter cleanup like class.cs
12877 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12880 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12883 (Try.Emit): Propagate the returns value from the statement.
12885 (Return.Emit): Even if we are leavning
12887 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12889 * modifiers.cs: Fix the computation of MethodAttributes flags.
12891 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12893 * driver.cs: allow compilation of files that start with '/'.
12894 Add a default case when checking the argument of --target.
12896 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12898 * interface.cs: Implement the same search algorithm for types in
12899 the interface code.
12901 * delegate.cs: Do not allow multiple definition.
12903 * Recovered ChangeLog that got accidentally amputated
12905 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12907 * rootcontext.cs: Load manually enum to allow core classes to
12908 contain enumerations.
12910 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12911 Update to new static methods in TypeManager.
12913 * typemanager.cs (GetMethod, GetConstructor): Use our
12914 implementation of FindMembers to find the members, since during
12915 corlib compilation, the types are TypeBuilders and GetMethod and
12916 GetConstructor do not work.
12918 Make all methods in TypeManager static.
12920 (InitCodeHelpers): Split the functionality from
12921 the InitCodeTypes function.
12923 * driver.cs: Call InitCodeHelpers after we have populated the
12926 * cs-parser.jay (delegate_declaration): we did not used to compute
12927 the delegate name correctly for void delegates.
12929 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12931 * rootcontext.cs (RootContext): Init the interface_resolve_order
12932 and type_container_resolve_order always.
12934 (ResolveCore, BootstrapCorlib_ResolveClass,
12935 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12936 compiler when compiling with --nostdlib
12938 * class.cs (TypeContainer.DefineType): Check that our parent is
12939 not null. This test is most important when we are bootstraping
12942 * codegen.cs: Split out the symbol writing code.
12944 2002-03-25 Martin Baulig <martin@gnome.org>
12946 * driver.cs (-g): Made -g an alias for --debug.
12948 2002-03-24 Martin Baulig <martin@gnome.org>
12950 * codegen.cs (SymbolWriter): New public variable. Returns the
12951 current symbol writer.
12952 (CodeGen): Added `bool want_debugging_support' argument to the
12953 constructor. If true, tell the ModuleBuild that we want debugging
12954 support and ask it for the ISymbolWriter.
12955 (Save): If we have a symbol writer, call it's Close() method after
12956 saving the assembly.
12958 * driver.c (--debug): New command line argument to create a
12959 debugger information file.
12961 * location.cs (SymbolDocument): New public property. Returns an
12962 ISymbolDocumentWriter object for the current source file or null
12963 if we don't have a symbol writer.
12965 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12967 * driver.cs (LoadAssembly): Correctly return when all the paths
12968 have been tried and not before.
12970 * statement.cs (Switch.Emit): return the actual coverage for this
12971 statement (returns/not-returns)
12973 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12974 switch of the statement if we are the last switch section. That
12975 kills two problems: try/catch problems (we used to emit an empty
12976 nop at the end) and switch statements where all branches would
12979 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12981 * driver.cs: Add default assemblies (the equivalent to the
12982 Microsoft CSC.RSP file)
12984 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12985 also update tokens_seen and set it to false.
12987 * driver.cs: Implement --recurse for Mike.
12989 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12990 correctly splitting out the paths.
12992 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12994 * interface.cs (Interface.PopulateProperty): Instead of using
12995 `parent' as the declaration space for the set parameters, use
12998 * support.cs (InternalParameters): InternalParameters constructor
12999 takes a DeclSpace instead of a TypeContainer.
13001 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
13002 types are being initialized, load the address of it before calling
13005 (New): Provide a mechanism to disable the generation of local
13006 value type temporaries when the caller will be providing us with
13007 an address to store it.
13009 (ArrayCreation.EmitDynamicInitializers): Use it.
13011 2002-03-17 Miguel de Icaza <miguel@ximian.com>
13013 * expression.cs (Invocation.EmitArguments): Only probe for array
13014 property if there is more than one argument. Sorry about that.
13016 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
13017 empty param arrays.
13019 * class.cs (Method.LabelParameters): Fix incorrect code path that
13020 prevented the `ParamArrayAttribute' from being applied to the
13023 2002-03-16 Miguel de Icaza <miguel@ximian.com>
13025 * support.cs (ReflectionParameters): Correctly compute whether the
13026 last argument is a params array. Fixes the problem with
13029 * typemanager.cs: Make the assemblies array always be non-null
13030 (empty, but non-null)
13032 * tree.cs (RecordDecl): New function that abstracts the recording
13033 of names. This reports error 101, and provides a pointer to the
13034 previous declaration. Fixes a crash in the compiler.
13036 * cs-parser.jay (constructor_declaration): Update to new grammar,
13037 and provide a constructor_body that can be empty.
13039 2002-03-15 Miguel de Icaza <miguel@ximian.com>
13041 * driver.cs: Add support for --resources.
13043 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
13044 Make all types for the various array helper methods be integer.
13046 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
13047 CheckState to ConvCast.
13049 (ConvCast): Now it takes a `checked' state argument, to avoid
13050 depending on the emit context for the conversion, and just using
13051 the resolve time setting.
13053 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
13054 instead of Invocation.EmitArguments. We do not emit the original
13055 arguments, instead we emit those which have been converted to
13056 unsigned int expressions.
13058 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
13060 * codegen.cs: ditto.
13062 * expression.cs (LocalVariableReference): Drop the use of the
13063 Store function that depended on the variable index.
13065 * statement.cs (VariableInfo): Drop the `Idx' property from this
13066 class, as this is not taking into account the indexes for
13067 temporaries tat we generate during the execution, getting the
13070 * class.cs: First emit class initializers, then call the parent
13073 * expression.cs (Binary): Fix opcode emision.
13074 (UnaryMutator.EmitCode): Support checked code generation
13076 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
13077 matches for events for both the Static and Instance scans,
13078 pointing to the same element. Fix that.
13080 2002-03-14 Miguel de Icaza <miguel@ximian.com>
13082 * rootcontext.cs (ResolveTree): Always set the
13083 interface_resolve_order, because nested interfaces will be calling
13086 * class.cs (GetInterfaceOrClass): Track the same resolution
13087 process used by TypeManager.LookupType. This fixes the nested
13088 type lookups in class declarations (separate path from
13091 (TypeContainer.DefineType): Also define nested interfaces.
13092 (TypeContainer.RegisterOrder): New public function used to
13093 register the order in which child interfaces need to be closed.
13095 Nested interfaces need to be closed after their parents have been
13098 * interface.cs (InterfaceAttr): Put all the logic for computing
13099 the interface attribute here.
13101 (DefineInterface): Register our interface order with the
13102 RootContext or with the TypeContainer depending on the case.
13104 2002-03-12 Miguel de Icaza <miguel@ximian.com>
13106 * cs-parser.jay: rework foreach statement to work with the new
13107 changes to the policy on SimpleNames.
13109 * report.cs: support Stacktrace on warnings as well.
13111 * makefile: drop --unsafe and /unsafe from the compile.
13113 2002-03-13 Ravi Pratap <ravi@ximian.com>
13115 * ecore.cs (StandardConversionExists): Modify to take an Expression
13116 as the first parameter. Ensure we do null -> reference type conversion
13119 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
13120 temporary Expression objects.
13122 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
13124 * interface.cs: workaround bug in method overloading resolution
13125 (there is already a bugzilla bug for it).
13127 2002-03-12 Miguel de Icaza <miguel@ximian.com>
13129 We could also solve this problem by having a separate path for
13130 performing type lookups, instead of DoResolve, we could have a
13131 ResolveType entry point, and only participating pieces of the
13132 production (simplename, deref, array) would implement this.
13134 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
13135 signal SimpleName to only resolve type names and not attempt to
13136 resolve anything else.
13138 * expression.cs (Cast): Set the flag.
13140 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
13142 * class.cs: Only report 108 if there is no `new' modifier.
13144 * cs-parser.jay: rework foreach statement to work with the new
13145 changes to the policy on SimpleNames.
13147 * report.cs: support Stacktrace on warnings as well.
13149 * makefile: drop --unsafe and /unsafe from the compile.
13151 2002-03-11 Miguel de Icaza <miguel@ximian.com>
13153 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
13154 lookups here, instead of doing that at parse time. This means
13155 that our grammar will not introduce `LocalVariableReferences' as
13156 expressions at this point. That solves the problem of code like
13160 static void Main ()
13164 This is only half the fix. The full fix requires parameters to
13165 also be handled in this way.
13167 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
13168 makes the use more obvious of the DeclSpace. The
13169 ec.TypeContainer.TypeBuilder is now only used to pull the
13170 TypeBuilder for it.
13172 My theory is that I can get rid of the TypeBuilder completely from
13173 the EmitContext, and have typecasts where it is used (from
13174 DeclSpace to where it matters).
13176 The only pending problem is that the code that implements Aliases
13177 is on TypeContainer, and probably should go in DeclSpace.
13179 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
13180 lookups here, instead of doing that at parse time. This means
13181 that our grammar will not introduce `LocalVariableReferences' as
13182 expressions at this point. That solves the problem of code like
13186 static void Main ()
13190 This is only half the fix. The full fix requires parameters to
13191 also be handled in this way.
13193 * class.cs (Property.DefineMethod): When implementing an interface
13194 method, set newslot, when implementing an abstract method, do not
13195 set the flag (before we tried never setting it, or always setting
13196 it, which is the difference).
13197 (Indexer.DefineMethod): same.
13198 (Method.DefineMethod): same.
13200 * ecore.cs: Only set the status used flag if we get back a Field.
13202 * attribute.cs: Temporary hack, so Paolo can keep working.
13204 2002-03-08 Ravi Pratap <ravi@ximian.com>
13206 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
13207 the unmanaged type in the case we have a MarshalAs attribute.
13209 (Resolve): Handle the case when we are parsing the special MarshalAs
13210 attribute [we need to store the unmanaged type to use later]
13212 * typemanager.cs (marshal_as_attr_type): Built in type for the
13213 MarshalAs Attribute.
13215 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
13216 on parameters and accordingly set the marshalling info.
13218 2002-03-09 Miguel de Icaza <miguel@ximian.com>
13220 * class.cs: Optimizing slightly by removing redundant code after
13221 we switched to the `NoTypes' return value.
13222 (Property.DefineMethod): use NoTypes here too.
13224 This fixes the bug I introduced in my last batch of changes.
13226 2002-03-05 Ravi Pratap <ravi@ximian.com>
13228 * tree.cs (RecordEnum): Add. We now keep track of enums too.
13230 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
13231 Enums since those are types too.
13233 * cs-parser.jay (enum_declaration): Record enums as we parse them.
13235 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
13236 thanks to a call during the lookup process.
13238 2002-03-07 Miguel de Icaza <miguel@ximian.com>
13240 * statement.cs (Foreach): Lots of work to accomodate a particular
13241 kind of foreach statement that I had not kept in mind. It is
13242 possible to have foreachs on classes that provide a GetEnumerator
13243 method that return objects that implement the "pattern" for using
13244 a foreach, there is no need to support GetEnumerator
13247 This is needed to compile nant.
13249 * decl.cs: Only report 114 if the member is not `Finalize' and if
13250 the warning level is at least 2.
13252 * class.cs: Moved the compare function from Method to
13255 (MethodSignature.InheritableMemberSignatureCompare): Add new
13256 filter function that is used to extract inheritable methods from a
13259 (Method.Define): Use the new `inheritable_method_signature_filter'
13262 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
13265 2002-03-06 Miguel de Icaza <miguel@ximian.com>
13267 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
13269 * cs-parser.jay: Add opt_semicolon to the interface declaration.
13271 * expression.cs: Pass location information to
13272 ConvertImplicitStandard.
13274 * class.cs: Added debugging code to track return values from
13277 2002-03-05 Miguel de Icaza <miguel@ximian.com>
13279 * expression.cs (Is.DoResolve): If either side of the `is' is an
13280 interface, do not flag the warning.
13282 * ecore.cs (ImplicitReferenceConversion): We need a separate test
13285 * report.cs: Allow for --fatal to be used with --probe.
13287 * typemanager.cs (NoTypes): Move the definition for the empty Type
13290 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
13292 (TypeContainer.DefineProxy): New function used to proxy to parent
13293 implementations when implementing interfaces.
13294 (TypeContainer.ParentImplements): used to lookup if our parent
13295 implements a public function that is required by an interface.
13296 (TypeContainer.VerifyPendingMethods): Hook this up.
13298 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
13299 `modules' and `assemblies' arraylists into arrays. We only grow
13300 these are the very early start up of the program, so this improves
13301 the speedof LookupType (nicely measured).
13303 * expression.cs (MakeByteBlob): Replaced unsafe code with
13304 BitConverter, as suggested by Paolo.
13306 * cfold.cs (ConstantFold.Binary): Special case: perform constant
13307 folding of string concatenation, but if either side is a string,
13308 and the other is not, then return null, and let the runtime use
13309 the concatenation on the string plus the object (using
13310 `Object.ToString').
13312 2002-03-04 Miguel de Icaza <miguel@ximian.com>
13314 Constant Folding has been implemented now.
13316 * expression.cs (Unary.Reduce): Do not throw an exception, catch
13317 the error instead on types that are not supported in one's
13320 * constant.cs (Constant and all children): New set of functions to
13321 perform implict and explicit conversions.
13323 * ecore.cs (EnumConstant): Implement the new functions to perform
13324 conversion by proxying to the child expression.
13326 * codegen.cs: (ConstantCheckState): Constant evaluation has its
13327 own separate setting that can not be turned off from the command
13328 line using --unchecked or --checked and is only controlled using
13329 the checked/unchecked statements and expressions. This setting is
13330 used by the constant folder to flag errors.
13332 * expression.cs (CheckedExpr, UncheckedExpr): Set the
13333 ConstantCheckState as well.
13335 During Resolve, they also have to flag the state, because the
13336 constant folder runs completely in the Resolve phase.
13338 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
13341 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13343 * cfold.cs: New file, this file contains the constant folder.
13345 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
13346 argument to track whether we are using the resulting address to
13347 load or store a value and provide better error messages.
13349 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
13350 new AddressOf arguments.
13352 * statement.cs (Foreach.EmitCollectionForeach): Update
13354 * expression.cs (Argument.Emit): Call AddressOf with proper
13355 arguments to track usage.
13357 (New.DoEmit): Call AddressOf with new arguments.
13359 (Unary.Emit): Adjust AddressOf call.
13361 2002-03-01 Ravi Pratap <ravi@ximian.com>
13363 * cs-parser.jay (member_access): Change the case for pre-defined types
13364 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
13367 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
13370 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
13371 essentially like methods and apply attributes like MethodImplOptions to them too.
13373 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
13376 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
13377 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
13380 * Update code everywhere accordingly.
13382 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
13384 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
13386 2002-02-28 Ravi Pratap <ravi@ximian.com>
13388 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
13389 try performing lookups against those instead of jumping straight into using
13390 the 'using' clauses.
13392 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
13394 (LookupType): Perform lookups in implicit parents too.
13396 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
13397 sequence as RootContext.LookupType.
13399 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
13400 the various cases of namespace lookups into this method.
13402 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13404 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
13405 in positional arguments)
13407 * class.cs (Operator): Update the AllowedModifiers to contain
13410 * cs-parser.jay: Update operator declaration to allow for the
13411 operator body to be empty.
13413 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
13416 2002-02-27 Miguel de Icaza <miguel@ximian.com>
13418 * class.cs (Method.Emit): Label parameters.
13420 * driver.cs: Return 1 or 0 as the program exit code.
13422 2002-02-26 Miguel de Icaza <miguel@ximian.com>
13424 * expression.cs: Special case the `null' object when trying to
13425 auto-compute the type, as anything can be explicitly converted to
13428 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
13429 spotting this Paolo.
13431 (Expression.ImplicitNumericConversion): Perform comparissions of
13432 the type using the underlying type in the case of an enumeration
13433 rather than using the enumeration type for the compare.
13435 Cope with the underlying == type case, which is not possible to
13438 (Expression.ConvertNumericExplicit): Perform comparissions of
13439 the type using the underlying type in the case of an enumeration
13440 rather than using the enumeration type for the compare.
13442 * driver.cs: If the user does not supply an extension, assume .exe
13444 * cs-parser.jay (if_statement): Rewrote so that we can track the
13445 location for the if statement.
13447 * expression.cs (Binary.ConstantFold): Only concat strings when
13448 the operation is "+", not everything ;-)
13450 * statement.cs (Statement.EmitBoolExpression): Take a location
13452 (If, While, Do): Track location.
13454 * expression.cs (Binary.ResolveOperator): In the object + string
13455 case, I was missing a call to ConvertImplicit
13457 2002-02-25 Ravi Pratap <ravi@ximian.com>
13459 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
13460 Location arguments. Ensure we use RootContext.LookupType to do our work
13461 and not try to do a direct Type.GetType and ModuleBuilder.GetType
13463 * interface.cs (PopulateMethod): Handle the type of the parameter being
13466 * expression.cs (Invocation.BetterFunction): Handle the case when we
13467 have a params method with no fixed arguments and a call is made with no
13470 2002-02-25 Miguel de Icaza <miguel@ximian.com>
13472 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
13473 the verbatim-string-literal
13475 * support.cs (InternalParameters.ParameterModifier): handle null
13477 (InternalParameters.ParameterType): ditto.
13479 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
13480 duplicating the name of the variable parameter.
13481 (GetParameterByName): Fix bug where we were not looking up array
13482 paramters if they were the only present (thanks Paolo!).
13483 (GetParameterInfo): We only have an empty set of types if both
13484 fixed and array are set to null.
13485 (GetParameterInfo-idx): Handle FixedParameter == null
13487 * cs-parser.jay: Handle the case where there is no catch
13488 statements (missing null test).
13490 2002-02-22 Miguel de Icaza <miguel@ximian.com>
13492 * driver.cs (MainDriver): Be conservative on our command line
13495 Catch DirectoryNotFoundException when calling GetFiles.
13497 (SplitPathAndPattern): Used to split the input specification into
13498 a path and a pattern that we can feed to Directory.GetFiles.
13500 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13502 * statement.cs (Fixed): Implement the last case of the Fixed
13503 statement (string handling).
13505 * expression.cs (StringPtr): New class used to return a char * to
13506 a string; Used by the Fixed statement.
13508 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13510 * expression.cs (Binary.ResolveOperator): Remove redundant
13511 MemberLookup pn parent type.
13512 Optimize union call, we do not need a union if the types are the same.
13513 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13516 Specialize the use of MemberLookup everywhere, instead of using
13517 the default settings.
13519 (StackAlloc): Implement stackalloc keyword.
13521 * cs-parser.jay: Add rule to parse stackalloc.
13523 * driver.cs: Handle /h, /help, /?
13525 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13526 before we supported unsafe code.
13528 * makefile: add --unsafe to the self compilation of mcs.
13530 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13532 * expression.cs (PointerArithmetic): New class that is used to
13533 perform pointer arithmetic.
13534 (Binary.Resolve): Handle pointer arithmetic
13535 Handle pointer comparission.
13536 (ArrayPtr): Utility expression class that is used to take the
13537 address of an array.
13539 (ElementAccess): Implement array access for pointers
13541 * statement.cs (Fixed): Implement fixed statement for arrays, we
13542 are missing one more case before we are done.
13544 * expression.cs (Indirection): Implement EmitAssign and set the
13545 ExprClass to Variable. This allows pointer dereferences to be
13546 treated as variables, and to have values assigned to them.
13548 * ecore.cs (Expression.StoreFromPtr): New utility function to
13549 store values dereferencing.
13551 2002-02-20 Ravi Pratap <ravi@ximian.com>
13553 * expression.cs (Binary.ResolveOperator): Ensure that we are
13554 not trying to operate on a void type - this fixes the reported
13557 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13558 the parent implementation is sealed.
13560 * ../errors/cs0239.cs : Add.
13562 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13564 * typemanager.cs (unverifiable_code_type): Corresponds to
13565 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13566 which have unsafe code in them.
13568 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13571 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13573 * cs-tokenizer.cs: Add support for @"litreal strings"
13575 Make tokenizer accept pre-processor directives
13576 on any column (remove the old C-like limitation).
13578 * rootcontext.cs (EmitCode): Emit any global attributes.
13579 (AddGlobalAttributes): Used to keep track of assembly attributes.
13581 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13583 * cs-parser.jay: Add support for global attributes.
13585 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13587 * expression.cs (Indirection): New helper class. Unary will
13588 create Indirection classes to be able to implement the
13589 IMemoryLocation interface on it.
13591 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13593 * cs-parser.jay (fixed_statement): reference the right statement.
13595 * statement.cs (Fixed.Emit): Finish implementing the fixed
13596 statement for the &x case.
13598 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13600 * class.cs (Property.Define, Method.Define): Remove newslot when
13603 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13604 wrong. NewSlot should only be used if the `new' keyword is present.
13606 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13607 locating our system dir. Sorry about this.
13609 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13611 * driver.cs (GetSystemDir): Compute correctly the location of our
13612 system assemblies. I was using the compiler directory instead of
13613 the library directory.
13615 2002-02-13 Ravi Pratap <ravi@ximian.com>
13617 * expression.cs (BetterFunction): Put back in what Miguel commented out
13618 since it is the correct fix. The problem is elsewhere ;-)
13620 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13621 parameters of the parms method are themselves compatible or not !
13623 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13624 to check that a class implements an interface before saying that an implicit
13625 conversion was allowed. Use ImplementsInterface to do the checking.
13627 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13629 * class.cs (Method.Define): Track whether we are an explicit
13630 implementation or not. And only call DefineMethodOverride if we
13631 are an explicit implementation.
13633 (Property.DefineMethod): Ditto.
13635 2002-02-11 Ravi Pratap <ravi@ximian.com>
13637 * expression.cs (BetterFunction): Catch hideous bug which was
13638 preventing us from detecting ambiguous calls due to implicit casts i.e
13641 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13643 * support.cs (Pair): Remove un-needed method. I figured why I was
13644 getting the error in cs-parser.jay, the variable in a foreach loop
13645 is readonly, and the compiler does not really treat this as a variable.
13647 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13648 instead of EQUALS in grammar.
13650 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13652 * expression.cs (Unary.DoResolve): Check whether the argument is
13655 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13657 * support.cs: Api for Pair to set a value. Despite the fact that
13658 the variables are public the MS C# compiler refuses to compile
13659 code that accesses the field if the variable is part of a foreach
13662 * statement.cs (Fixed): Begin implementation of the fixed
13665 (Block.AddVariable): Return the VariableInfo on success and null
13666 on failure instead of true/false.
13668 * cs-parser.jay (foreach): Catch errors on variables already
13669 defined (we were ignoring this value before) and properly unwind
13670 the block hierarchy
13672 (fixed_statement): grammar for the fixed statement.
13674 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13676 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13677 pointer types to be incretemented.
13679 (SizeOf): Implement.
13681 * cs-parser.jay (pointer_member_access): Implement
13682 expr->IDENTIFIER production.
13684 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13685 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13688 (Unary): Implement indirection.
13690 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13691 use in non-unsafe context).
13693 (SimpleName.DoResolve): Check for pointers in field access on safe
13696 (Expression.LoadFromPtr): Factor the load-indirect code in this
13697 function. This was duplicated in UnboxCast and ParameterReference
13699 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13701 * expression.cs (ComposedCast): report an error if a pointer cast
13702 is used in a safe region.
13704 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13705 pointer type casts in unsafe context.
13707 * codegen.cs (EmitContext): Set up IsUnsafe.
13709 * cs-parser.jay (non_expression_type): Add productions for pointer
13712 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13713 code. We should not use force into static mode if the method is
13714 not virtual. Fixes bug in MIS
13716 * statement.cs (Do.Emit, While.Emit, For.Emit,
13717 Statement.EmitBoolExpression): Add support to Do and While to
13718 propagate infinite loop as `I do return' semantics.
13720 Improve the For case to also test for boolean constants.
13722 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13723 to the list of attributes we can add.
13725 Remove `EmitContext' argument.
13727 * class.cs (Method.Define): Apply parameter attributes.
13728 (Constructor.Define): Apply parameter attributes.
13729 (MethodCore.LabelParameters): Move here the core of labeling
13732 * support.cs (ReflectionParameters.ParameterModifier,
13733 InternalParameters.ParameterModifier): Use IsByRef on the type and
13734 only return the OUT bit for these parameters instead of in/out/ref
13737 This is because I miss-understood things. The ParameterInfo.IsIn
13738 and IsOut represent whether the parameter has the [In] and [Out]
13741 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13743 * ecore.cs (FieldExpr.Emit): Release temporaries.
13745 * assign.cs (LocalTemporary.Release): new function.
13747 * codegen.cs (EmitContext.GetTemporaryStorage,
13748 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13749 temporary storage. Now we can "put back" localbuilders when we
13752 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13754 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13755 need to make a copy of the variable to generate verifiable code.
13757 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13759 * driver.cs: Compute dynamically the system directory.
13761 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13762 Slower, but more generally useful. Used by the abstract
13763 registering implementation.
13765 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13766 the rules for the special rule on Type/instances. First check if
13767 we have the same name, and if so, try that special static path
13768 rather than the instance path.
13770 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13772 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13775 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13776 Enum, ValueType, Delegate or Array for non-corlib compiles.
13778 * cs-tokenizer.cs: Catch long identifiers (645)
13780 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13783 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13784 fix, we were returning too early, so we were not registering
13785 pending methods from abstract classes.
13787 Do not register pending methods if the class is abstract.
13789 * expression.cs (Conditional.DoResolve): Report circular implicit
13790 conversions when we neecd to compute it for conditional
13793 (Is.DoResolve): If the expression is always of the provided type,
13794 flag warning 183. If the expression can not ever be of the
13795 provided type flag warning 184.
13797 * class.cs: Catch 169 as well.
13799 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13802 2002-01-18 Nick Drochak <ndrochak@gol.com>
13804 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13806 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13808 * interface.cs: (PopulateMethod): Check for pointers being defined
13809 only if the unsafe context is active.
13810 (PopulateProperty): ditto.
13811 (PopulateIndexer): ditto.
13813 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13814 specified. If pointers are present, make sure that they are
13815 present in an unsafe context.
13816 (Constructor, Constructor.Define): ditto.
13817 (Field, Field.Define): ditto.
13818 (Property, Property.Define): ditto.
13819 (Event, Event.Define): ditto.
13821 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13822 hashtable if there are classes or structs defined.
13824 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13825 code, as the constant resolution moved.
13827 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13828 the metadata, so we can flag error 133.
13830 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13831 pointer is being declared in an unsafe context.
13833 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13835 * modifiers.cs (Modifiers.Check): Require a Location argument.
13836 Report error 227 for Unsafe use.
13838 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13840 * statement.cs (For.Emit): If the test is null, then report that
13841 we do `return', as we wont reach anything afterwards.
13843 (Switch.SwitchGoverningType): Track the expression that matched
13846 * driver.cs: Allow negative numbers as an error code to flag.
13848 * cs-parser.jay: Handle 1551.
13850 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13852 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13854 * cs-parser.jay: Report 1518 (type declaration can only contain
13855 class, struct, interface, enum or delegate)
13857 (switch_label): Report 1523 (keywords `case' or `default' must
13860 (opt_switch_sections): Report 1522 (empty switch)
13862 * driver.cs: Report 1515 (response file specified multiple times)
13863 Report 1516 (Source file specified multiple times).
13865 * expression.cs (Argument.Resolve): Signal 1510
13867 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13868 access not allowed in static code)
13870 2002-01-11 Ravi Pratap <ravi@ximian.com>
13872 * typemanager.cs (IsPointerType): Utility method which we are going
13875 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13876 the object type, so we take care of that.
13878 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13880 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13881 added to non-params parameters :-)
13883 * typemanager.cs (CSharpName): Include 'void' type too.
13885 (void_ptr_type): Include in the set of core types.
13887 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13890 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13893 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13894 completely forgotten about it.
13896 2002-01-10 Ravi Pratap <ravi@ximian.com>
13898 * cs-parser.jay (pointer_type): Add. This begins our implementation
13899 of parsing rules for unsafe code.
13901 (unsafe_statement): Implement.
13903 (embedded_statement): Modify to include the above.
13905 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13907 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13908 if the current context is an unsafe one.
13910 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13911 are handled differently, we need separate rules for them.
13913 (local_variable_declaration): Update to use local_variable_pointer_type
13914 to allow variable declarations of unmanaged pointer types.
13916 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13917 in unsafe contexts.
13919 * ../errors/cs0214.cs : Add.
13921 2002-01-16 Nick Drochak <ndrochak@gol.com>
13923 * makefile: remove 'response' file when cleaning.
13925 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13927 * cs-parser.jay: Report 1524.
13929 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13931 * typemanager.cs (RegisterMethod): drop checking if we have
13932 registered this from here
13934 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13936 * class.cs (Method.EmitDestructor): Implement calling our base
13939 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13940 value of InFinally.
13942 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13943 this routine and will wrap the call in a try/catch block. Deal
13946 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13948 * ecore.cs (Expression.MemberLookup): instead of taking a
13949 parameter `same_type' that was used to tell whether we could
13950 access private members we compute our containing type from the
13953 (FieldExpr): Added partial support for volatile fields. This does
13954 not work for volatile fields exposed from assemblies, as I can not
13955 figure out how to extract the modreq from it.
13957 Updated all the source files to use this.
13959 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13960 because it is referenced by MemberLookup very often.
13962 2002-01-09 Ravi Pratap <ravi@ximian.com>
13964 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13965 TypeBuilder.GetCustomAttributes to retrieve what we need.
13967 Get rid of redundant default_member_attr_type as this is the same as
13968 default_member_type which already exists.
13970 * interface.cs, attribute.cs : Update accordingly.
13972 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13974 * typemanager.cs: Enable IndexerPropertyName again. It does not
13975 work for TYpeBuilders though. Ravi, can you please fix this?
13977 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13979 * expression.cs (Argument.Emit): Handle the case of ref objects
13980 being passed to ref functions;
13982 (ParameterReference.EmitLoad): Loads the content of the pointer
13983 without dereferencing.
13985 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13987 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13989 2002-01-08 Ravi Pratap <ravi@ximian.com>
13991 * class.cs (Indexer.DefineMethod): Incorporate the interface
13992 type in the name of the method if we are doing explicit interface
13995 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13997 (BetterConversion): Fix extremely trivial bug where we were referring to
13998 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
14001 * ../errors/bug16.cs : Add although we have fixed it.
14003 2002-01-07 Miguel de Icaza <miguel@ximian.com>
14005 * expression.cs (BaseIndexer): Begin implementation.
14007 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
14009 * cs-parser.jay (indexer_declarator): Use qualified_identifier
14010 production directly to remove a shift/reduce, and implement
14011 explicit interface implementation.
14013 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
14014 after a floating point suffix.
14016 * expression.cs (DoNumericPromotions): Improved the conversion for
14017 uint/uint. If we have a constant, we avoid doing a typecast to a
14020 * class.cs (Indexer): Implement explicit interface implementation
14023 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
14025 * class.cs: make the default instance constructor public and hidebysig.
14027 2001-01-03 Ravi Pratap <ravi@ximian.com>
14029 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
14030 so we can call it from elsewhere.
14032 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
14033 we emit it internally if the class has a defined indexer; otherwise the user
14034 emits it by decorating the class definition with the DefaultMemberAttribute.
14036 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
14037 attribute is not used on a type which defines an indexer.
14039 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
14040 character when we skip whitespace.
14042 * ../errors/cs0646.cs : Add.
14044 2002-01-03 Miguel de Icaza <miguel@ximian.com>
14046 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
14049 * makefile: Add practical target `mcs3.exe' which builds the third
14050 generation compiler.
14052 * expression.cs (New): Fix structures constructor calling.
14054 * class.cs (Property, Method, Indexer): Emit Final flag on the
14055 method if we are an interface implementation and we are not
14058 * ecore.cs (PropertyExpr): New public field `IsBase', tells
14059 whether this property is referencing a `base' method.
14061 * expression.cs (Invocation.EmitCall): take an extra argument:
14062 is_base, this is used to determine whether the `call' or
14063 `callvirt' opcode should be used.
14066 * delegate.cs: update EmitCall.
14068 * class.cs (Method.Define): Set NewSlot for the cases where we are
14069 not implementing an interface method.
14071 (Property.Define): ditto.
14073 2002-01-02 Miguel de Icaza <miguel@ximian.com>
14075 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
14076 'r'. Allows mcs to parse itself fully.
14078 2002-01-02 Ravi Pratap <ravi@ximian.com>
14080 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
14081 of the number of initializers that require the InitializeArray method.
14083 (CheckIndices): Store the Expression in all cases - not the plain value. Also
14084 update the above field where necessary.
14086 (MakeByteBlob): Update accordingly.
14088 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
14091 (EmitDynamicInitializers): Update in accordance with the new optimization.
14093 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
14094 same OpCode applies.
14096 * cs-parser.jay : Fix some glaring errors I introduced.
14098 2002-01-01 Ravi Pratap <ravi@ximian.com>
14100 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
14101 so that we can check for name clashes there too.
14103 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
14104 for interface indexers.
14106 * interfaces.cs (Define): Emit the default member attribute.
14108 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
14109 variable was being referred to while setting the value ;-)
14111 2002-01-01 Miguel de Icaza <miguel@ximian.com>
14113 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
14114 byte-by-byte information when we know the data is zero.
14116 Make the block always a multiple of 4, because
14117 DefineInitializedData has a bug.
14119 * assign.cs: Fix, we should assign from the temporary, not from
14122 * expression.cs (MakeByteBlob): Fix my incorrect code.
14124 2001-12-31 Miguel de Icaza <miguel@ximian.com>
14126 * typemanager.cs (EnumToUnderlying): This function is used to get
14127 the underlying type from an enumeration, because it does not
14130 * constant.cs: Use the I4_S form for values between -128 and 127.
14132 * statement.cs (Block.LookupLabel): Looks up a label.
14133 (Block): Drop support for labeled blocks.
14135 (LabeledStatement): New kind of statement that represents a label
14138 (Goto): Finally implement this bad boy.
14140 * cs-parser.jay: Update to reflect new mechanism to implement
14143 2001-12-30 Miguel de Icaza <miguel@ximian.com>
14145 * codegen.cs (EmitContext.This): a codegen property that keeps the
14146 a single instance of this instead of creating many different this
14149 * delegate.cs (Delegate.DoResolve): Update to use the property;
14151 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
14153 * expression.cs (BaseAccess.DoResolve): Ditto.
14155 2001-12-29 Ravi Pratap <ravi@ximian.com>
14157 * typemanager.cs (methodimpl_attr_type): Add to hold the type
14158 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
14160 (InitCoreTypes): Update accordingly.
14162 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
14163 so we can quickly store the state.
14165 (ApplyAttributes): Set the correct implementation flags
14166 for InternalCall methods.
14168 2001-12-29 Miguel de Icaza <miguel@ximian.com>
14170 * expression.cs (EmitCall): if a method is not virtual, then do
14171 not use callvirt on it.
14173 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
14174 user defined stuff) requires the use of stobj, which takes an
14175 address on the stack instead of an array and an index. So emit
14176 the Ldelema operation for it.
14178 (EmitStoreOpcode): Use stobj for valuetypes.
14180 (UnaryMutator.EmitCode): Use the right 1 value depending on
14181 whether we are dealing with int64/uint64, float or doubles.
14183 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
14184 constructors that I implemented last night.
14186 (Constructor.IsDefault): Fix to work properly for static
14189 * cs-parser.jay (CheckDef): report method signature errors.
14190 Update error number 103 to be 132.
14192 * decl.cs: New AdditionResult enumeration value: MethodExists.
14193 Although we do this check for methods later on in the semantic
14194 analysis, catching repeated default constructors is so easy that
14195 we catch these here.
14197 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
14200 (ParameterReference.EmitAssign, Emit): handle
14203 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
14204 (ArrayAccess.EmitStoreOpcode): ditto.
14206 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
14208 * expression.cs (MakeByteBlob): Complete all the missing types
14209 (uint, short, ushort, byte, sbyte)
14211 * class.cs: Only init instance field initializers on instance
14214 Rename `constructors' to instance_constructors.
14216 (TypeContainer.AddConstructor): Only add constructors to the list
14217 if it is not static.
14219 Make sure that we handle default_static_constructor independently
14220 everywhere where we handle instance_constructors
14222 2001-12-28 Miguel de Icaza <miguel@ximian.com>
14224 * class.cs: Do not lookup or create a base initializer for a
14225 static constructor.
14227 (ConstructorInitializer.Resolve): use the proper type to lookup
14230 * cs-parser.jay: Report error 1585 (modifiers between type and name).
14232 * enum.cs, interface.cs: Remove CloseType, this is taken care by
14235 * decl.cs: CloseType is now an virtual method, the default
14236 implementation just closes this type.
14238 2001-12-28 Ravi Pratap <ravi@ximian.com>
14240 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
14241 to PreserveSig by default. Also emit HideBySig on such methods.
14243 Basically, set the defaults to standard values.
14245 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
14246 argument, if candidate is better, it can't be worse than the best !
14248 (Invocation): Re-write bits to differentiate between methods being
14249 applicable in their expanded form and their normal form - for params
14252 Get rid of use_standard everywhere as only standard conversions are allowed
14253 in overload resolution.
14255 More spec conformance.
14257 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14259 * driver.cs: Add --timestamp, to see where the compiler spends
14262 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
14263 `this' in static code.
14265 (SimpleName.DoResolve): Implement in terms of a helper function
14266 that allows static-references to be passed upstream to
14269 (Expression.ResolveWithSimpleName): Resolve specially simple
14270 names when called by MemberAccess to implement the special
14273 (Expression.ImplicitReferenceConversion): Handle conversions from
14274 Null to reference types before others, as Null's type is
14277 * expression.cs (Invocation.EmitCall): Handle the special case of
14278 calling methods declared on a reference type from a ValueType
14279 (Base classes System.Object and System.Enum)
14281 (MemberAccess.Resolve): Only perform lookups on Enumerations if
14282 the left hand side is a TypeExpr, not on every enumeration.
14284 (Binary.Resolve): If types are reference types, then do a cast to
14285 object on operators != and == of both arguments.
14287 * typemanager.cs (FindMembers): Extract instance and static
14288 members if requested.
14290 * interface.cs (PopulateProperty): Use void_type instead of null
14291 as the return type for the setter method.
14293 (PopulateIndexer): ditto.
14295 2001-12-27 Ravi Pratap <ravi@ximian.com>
14297 * support.cs (ReflectionParameters): Fix minor bug where we
14298 were examining the wrong parameter for the ParamArray attribute.
14300 Cope with requests for the type of the parameter at position
14301 greater than the params parameter's. We now return the element
14302 type of the params array as that makes more sense.
14304 * expression.cs (Invocation.IsParamsMethodApplicable): Update
14305 accordingly as we no longer have to extract the element type
14308 (Invocation.OverloadResolve): Update.
14310 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14312 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
14313 against IEnumerator, test whether the return value is a descendant
14314 of the IEnumerator interface.
14316 * class.cs (Indexer.Define): Use an auxiliary method to implement
14317 the other bits of the method definition. Begin support for
14318 explicit interface implementation.
14320 (Property.DefineMethod): Use TypeManager.void_type instead of null
14321 for an empty return value.
14323 2001-12-26 Miguel de Icaza <miguel@ximian.com>
14325 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
14326 dealing with a FieldExpr which is composed of a FieldBuilder, in
14327 the code path we did extract the constant, but we should have
14328 obtained the underlying value to be able to cast it (otherwise we
14329 end up in an infinite loop, this is what Ravi was running into).
14331 (ArrayCreation.UpdateIndices): Arrays might be empty.
14333 (MemberAccess.ResolveMemberAccess): Add support for section
14334 14.5.4.1 that deals with the special case of E.I when E is a type
14335 and something else, that I can be a reference to a static member.
14337 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
14338 handle a particular array type to create byte blobs, it is just
14339 something we dont generate byteblobs for.
14341 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
14344 * location.cs (Push): remove the key from the hashtable that we
14345 are about to add. This happens for empty files.
14347 * driver.cs: Dispose files after we have parsed them.
14349 (tokenize): new function that only runs the tokenizer on its
14350 input, for speed testing.
14352 2001-12-26 Ravi Pratap <ravi@ximian.com>
14354 * class.cs (Event.Define): Define the private field only if there
14355 are no accessors defined.
14357 * expression.cs (ResolveMemberAccess): If there is no associated
14358 field with the event, that means we have an event defined with its
14359 own accessors and we should flag error cs0070 since transforming
14360 ourselves into a field is not valid in that case.
14362 * ecore.cs (SimpleName.DoResolve): Same as above.
14364 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
14365 and charset to sane values.
14367 2001-12-25 Ravi Pratap <ravi@ximian.com>
14369 * assign.cs (DoResolve): Perform check on events only if they
14370 are being accessed outside the declaring type.
14372 * cs-parser.jay (event_declarations): Update rules to correctly
14373 set the type of the implicit parameter etc.
14375 (add_accessor, remove_accessor): Set current local parameters.
14377 * expression.cs (Binary): For delegate addition and subtraction,
14378 cast the return value from the method into the appropriate delegate
14381 2001-12-24 Ravi Pratap <ravi@ximian.com>
14383 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
14384 of these as the workaround is unnecessary.
14386 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
14387 delegate data - none of that is needed at all.
14389 Re-write bits to extract the instance expression and the delegate method
14392 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
14395 * attribute.cs (ApplyAttributes): New method to take care of common tasks
14396 of attaching attributes instead of duplicating code everywhere.
14398 * everywhere : Update code to do attribute emission using the above method.
14400 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14402 * expression.cs (IsParamsMethodApplicable): if there are not
14403 parameters, return immediately.
14405 * ecore.cs: The 0 literal can be implicity converted to an enum
14408 (SimpleName.DoResolve): First lookup the type, then lookup the
14411 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
14412 want to get its address. If the InstanceExpression is not
14413 addressable, store the result in a temporary variable, then get
14416 * codegen.cs: Only display 219 errors on warning level or above.
14418 * expression.cs (ArrayAccess): Make it implement the
14419 IMemoryLocation interface.
14421 (Binary.DoResolve): handle the operator == (object a, object b)
14422 and operator != (object a, object b) without incurring into a
14423 BoxedCast (because 5 != o should never be performed).
14425 Handle binary enumerator operators.
14427 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
14428 value type, otherwise use Ldelem_ref.
14430 Use precomputed names;
14432 (AddressOf): Implement address of
14434 * cs-parser.jay (labeled_statement): Fix recursive block
14435 addition by reworking the production.
14437 * expression.cs (New.DoEmit): New has a special case:
14439 If we are dealing with a ValueType, we have a few
14440 situations to deal with:
14442 * The target of New is a ValueType variable, that is
14443 easy, we just pass this as the variable reference
14445 * The target of New is being passed as an argument,
14446 to a boxing operation or a function that takes a
14449 In this case, we need to create a temporary variable
14450 that is the argument of New.
14453 2001-12-23 Ravi Pratap <ravi@ximian.com>
14455 * rootcontext.cs (LookupType): Check that current_type is not null before
14456 going about looking at nested types.
14458 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
14459 not implement the IAssignMethod interface any more.
14461 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
14462 where we tranform them into FieldExprs if they are being resolved from within
14463 the declaring type.
14465 * ecore.cs (SimpleName.DoResolve): Do the same here.
14467 * assign.cs (DoResolve, Emit): Clean up code considerably.
14469 * ../errors/bug10.cs : Add.
14471 * ../errors/cs0070.cs : Add.
14473 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
14475 * assign.cs : Get rid of EventIsLocal everywhere.
14477 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14479 * ecore.cs (ConvertIntLiteral): finished the implementation.
14481 * statement.cs (SwitchLabel): Convert the value we are using as a
14482 key before looking up the table.
14484 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14486 * codegen.cs (EmitTopBlock): Require a Location argument now.
14488 * cs-parser.jay (constructor_declarator): We need to setup
14489 current_local_parameters before we parse the
14490 opt_constructor_initializer, to allow the variables to be bound
14491 to the constructor arguments.
14493 * rootcontext.cs (LookupType): First lookup nested classes in our
14494 class and our parents before we go looking outside our class.
14496 * expression.cs (ConstantFold): Extract/debox the values at the
14499 * rootcontext.cs (EmitCode): Resolve the constants first before we
14500 resolve the types. This is not really needed, but it helps debugging.
14502 * statement.cs: report location.
14504 * cs-parser.jay: pass location to throw statement.
14506 * driver.cs: Small bug fix.
14508 * report.cs: Updated format to be 4-zero filled digits.
14510 2001-12-22 Ravi Pratap <ravi@ximian.com>
14512 * expression.cs (CheckIndices): Fix minor bug where the wrong
14513 variable was being referred to ;-)
14515 (DoEmit): Do not call EmitStaticInitializers when the
14516 underlying type is System.Object.
14518 2001-12-21 Ravi Pratap <ravi@ximian.com>
14520 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14521 and do the usual workaround for SRE.
14523 * class.cs (MyEventBuilder.EventType): New member to get at the type
14524 of the event, quickly.
14526 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14528 * assign.cs (Assign.DoResolve): Handle the case when the target
14529 is an EventExpr and perform the necessary checks.
14531 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14534 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14536 (EventExpr): Set the type in the constructor itself since we
14537 are meant to be born fully resolved.
14539 (EventExpr.Define): Revert code I wrote earlier.
14541 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14542 instance expression is null. The instance expression is a This in that case
14543 or a null, depending on whether it is a static method or not.
14545 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14546 refers to more than one method.
14548 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14549 and accordingly flag errors.
14551 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14553 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14555 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14557 * location.cs (ToString): Provide useful rutine.
14559 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14561 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14562 objects, return the actual integral boxed.
14564 * statement.cs (SwitchLabel): define an ILLabel for each
14567 (Switch.CheckSwitch): If the value is a Literal, extract
14568 the underlying literal.
14570 Also in the unused hashtable we had, add the SwitchLabel so we can
14571 quickly look this value up.
14573 * constant.cs: Implement a bunch of new constants. Rewrite
14574 Literal based on this. Made changes everywhere to adapt to this.
14576 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14577 dereferencing array only once, and also copes with enumrations.
14579 bytes are two bytes wide, not one.
14581 (Cast): Perform constant conversions.
14583 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14584 wrappers to the literals here.
14586 * expression.cs (DoNumericPromotions): long literals can converted
14587 to ulong implicity (this is taken care of elsewhere, but I was
14588 missing this spot).
14590 * ecore.cs (Expression.Literalize): Make the return type Literal,
14591 to improve type checking.
14593 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14595 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14597 * literal.cs: Revert code from ravi that checked the bounds. The
14598 bounds are sane by the definition of the type itself.
14600 * typemanager.cs: Fix implementation of ImplementsInterface. We
14601 need to actually look up in our parent hierarchy for interfaces
14604 * const.cs: Use the underlying type for enumerations
14606 * delegate.cs: Compute the basename for the delegate creation,
14607 that should fix the delegate test case, and restore the correct
14608 Type Lookup semantics in rootcontext
14610 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14611 referencing a nested type with the Reflection API is using the "+"
14614 * cs-parser.jay: Do not require EOF token at the end.
14616 2001-12-20 Ravi Pratap <ravi@ximian.com>
14618 * rootcontext.cs (LookupType): Concatenate type names with
14619 a '.' instead of a '+' The test suite passes again.
14621 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14622 field of the enumeration.
14624 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14625 the case when the member is an EventExpr.
14627 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14628 static has an associated instance expression.
14630 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14632 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14634 * class.cs (Event.Define): Register event and perform appropriate checks
14637 We define the Add and Remove methods even if the use provides none because
14638 in that case, we provide default implementations ourselves.
14640 Define a private field of the type of the event. This is done by the CSC compiler
14641 and we should be doing it too ;-)
14643 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14644 More methods we use in code we generate.
14646 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14649 (InitCoreTypes): Update accordingly for the above.
14651 * class.cs (Event.Emit): Generate code for default accessors that we provide
14653 (EmitDefaultMethod): Do the job in the above.
14655 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14658 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14660 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14661 builders even if we were missing one.
14663 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14664 pass the Basename as our class name instead of the Name. The
14665 basename will be correctly composed for us.
14667 * parameter.cs (Paramters): Now takes a Location argument.
14669 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14670 make all the code call directly LookupType in RootContext and take
14671 this chance to pass the Location information everywhere.
14673 * Everywhere: pass Location information.
14675 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14677 * class.cs (Constructor.Define): Updated way of detecting the
14678 length of the parameters.
14680 (TypeContainer.DefineType): Use basename as the type name for
14683 (TypeContainer.Define): Do not recursively define types here, as
14684 definition is taken care in order by the RootContext.
14686 * tree.cs: Keep track of namespaces in a per-file basis.
14688 * parameter.cs (Parameter.ComputeSignature): Update to use
14691 (Parameters.GetSignature): ditto.
14693 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14694 instead of a TypeContainer.
14696 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14697 resolve names. Because we need to be resolve in our context, not
14700 * driver.cs: Implement response files.
14702 * class.cs (TypeContainer.DefineType): If we are defined, do not
14703 redefine ourselves.
14705 (Event.Emit): Emit the code for add/remove handlers.
14706 (Event.Define): Save the MethodBuilders for add/remove.
14708 * typemanager.cs: Use pair here too.
14710 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14711 DictionaryEntry requires the first argument to be non-null.
14713 (enum_declaration): Compute full name for registering the
14716 (delegate_declaration): Instead of using
14717 formal_parameter_list, use opt_formal_parameter_list as the list
14720 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14721 (EventParsing): New property that controls whether `add' and
14722 `remove' are returned as tokens or identifiers (for events);
14724 2001-12-19 Ravi Pratap <ravi@ximian.com>
14726 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14727 use MyEventBuilder only and let it wrap the real builder for us.
14729 (MyEventBuilder): Revamp constructor etc.
14731 Implement all operations that we perform on EventBuilder in precisely the same
14734 (FindMembers): Update to use the EventBuilder member.
14736 (Event.Emit): Update accordingly.
14738 2001-12-18 Ravi Pratap <ravi@ximian.com>
14740 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14741 by calling the appropriate methods.
14743 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14746 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14748 2001-12-17 Ravi Pratap <ravi@ximian.com>
14750 * delegate.cs (Delegate.Populate): Check that the return type
14751 and various parameters types are indeed accessible.
14753 * class.cs (Constructor.Define): Same here.
14755 (Field.Define): Ditto.
14757 (Event.Define): Ditto.
14759 (Operator.Define): Check that the underlying Method defined itself
14760 correctly - so it's MethodBuilder should not be null.
14762 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14763 expression happens to be null.
14765 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14766 members but as of now we don't seem to be able to do anything really useful with it.
14768 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14769 not the EventBuilder.
14771 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14773 * cs-tokenizer.cs: Add support for defines.
14774 Add support for #if, #elif, #else, #endif
14776 (eval_var): evaluates a variable.
14777 (eval): stubbed for evaluating functions.
14779 * cs-parser.jay: Pass the defines information
14781 * driver.cs: Add --define command line option.
14783 * decl.cs: Move MemberCore here.
14785 Make it the base class for DeclSpace. This allows us to catch and
14786 report 108 and 109 for everything now.
14788 * class.cs (TypeContainer.Define): Extract all the members
14789 before populating and emit the warning 108 (new keyword required
14790 to override) instead of having each member implement this.
14792 (MemberCore.Define): New abstract method, we will be using this in
14793 the warning reporting engine in Populate.
14795 (Operator.Define): Adjust to new MemberCore protocol.
14797 * const.cs (Const): This does not derive from Expression, it is a
14798 temporary object we use to create fields, it is a MemberCore.
14800 * class.cs (Method.Define): Allow the entry point to be in a
14803 * driver.cs: Rewrite the argument handler to clean it up a bit.
14805 * rootcontext.cs: Made it just an auxiliary namespace feature by
14806 making everything static.
14808 * driver.cs: Adapt code to use RootContext type name instead of
14811 * delegate.cs: Remove RootContext argument.
14813 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14816 * class.cs (Event.Define): The lookup can fail.
14818 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14820 * expression.cs: Resolve the this instance before invoking the code.
14822 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14824 * cs-parser.jay: Add a production in element_access that allows
14825 the thing to become a "type" reference. This way we can parse
14826 things like "(string [])" as a type.
14828 Note that this still does not handle the more complex rules of
14832 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14834 * ecore.cs: (CopyNewMethods): new utility function used to
14835 assemble the list of methods from running FindMembers.
14837 (MemberLookup): Rework FindMembers so that
14839 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14841 * class.cs (TypeContainer): Remove Delegates who fail to be
14844 * delegate.cs (Populate): Verify that we dont get null return
14845 values. TODO: Check for AsAccessible.
14847 * cs-parser.jay: Use basename to emit error 574 (destructor should
14848 have the same name as container class), not the full name.
14850 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14851 possible representation.
14853 Also implements integer type suffixes U and L.
14855 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14857 * expression.cs (ArrayCreation.DoResolve): We need to do the
14858 argument resolution *always*.
14860 * decl.cs: Make this hold the namespace. Hold the root context as
14862 (LookupType): Move here.
14864 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14866 * location.cs (Row, Name): Fixed the code, it was always returning
14867 references to the first file.
14869 * interface.cs: Register properties defined through interfaces.
14871 * driver.cs: Add support for globbing on the command line
14873 * class.cs (Field): Make it derive from MemberCore as well.
14876 2001-12-15 Ravi Pratap <ravi@ximian.com>
14878 * class.cs (Event::Define): Check that the type of the event is a delegate
14879 type else flag error #66.
14881 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14884 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14885 values of EntryPoint, CharSet etc etc.
14887 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14889 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14890 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14891 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14892 which needs this to do its work.
14894 * ../errors/cs0066.cs : Add.
14896 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14898 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14901 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14902 clears out the parameters field.
14903 (MemberSignatureCompare): Cleanup
14905 (MemberCore): New base class used to share code between MethodCore
14908 (RegisterRequiredImplementations) BindingFlags.Public requires
14909 either BindingFlags.Instace or Static. Use instance here.
14911 (Property): Refactored code to cope better with the full spec.
14913 * parameter.cs (GetParameterInfo): Return an empty array instead
14916 * class.cs (Property): Abstract or extern properties have no bodies.
14918 * parameter.cs (GetParameterInfo): return a zero-sized array.
14920 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14921 method modifier validation to the typecontainer so we can reuse
14922 this on properties.
14924 (MethodCore.ParameterTypes): return an empty sized array of types.
14926 (Property.Define): Test property modifier validity.
14928 Add tests for sealed/override too.
14930 (Method.Emit): abstract or extern methods have no bodies.
14932 2001-12-14 Ravi Pratap <ravi@ximian.com>
14934 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14937 (Method::Define, ::Emit): Modify accordingly.
14939 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14941 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14943 * makefile: Pass in /unsafe.
14945 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14947 * class.cs (MakeKey): Kill routine.
14949 * class.cs (TypeContainer.Define): Correctly define explicit
14950 method implementations (they require the full interface name plus
14953 * typemanager.cs: Deply the PtrHashtable here and stop using the
14954 lame keys. Things work so much better.
14956 This of course broke everyone who depended on `RegisterMethod' to
14957 do the `test for existance' test. This has to be done elsewhere.
14959 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14960 the object stupid Equals method (because, that like fails all over
14961 the place). We still do not use it.
14963 * class.cs (TypeContainer.SetRequiredInterface,
14964 TypeContainer.RequireMethods): Killed these two routines and moved
14965 all the functionality to RegisterRequiredImplementations.
14967 (TypeContainer.RegisterRequiredImplementations): This routine now
14968 registers all the implementations required in an array for the
14969 interfaces and abstract methods. We use an array of structures
14970 which can be computed ahead of time to reduce memory usage and we
14971 also assume that lookups are cheap as most classes will not
14972 implement too many interfaces.
14974 We also avoid creating too many MethodSignatures.
14976 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14977 clear the "pending" bit if we find that there are problems with
14980 (TypeContainer.VerifyPendingMethods): Update to report errors of
14981 methods that look like implementations but are not.
14983 (TypeContainer.Define): Add support for explicit interface method
14986 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14988 * typemanager.cs: Keep track of the parameters here instead of
14989 being a feature of the TypeContainer.
14991 * class.cs: Drop the registration of parameters here, as
14992 InterfaceMethods are also interface declarations.
14994 * delegate.cs: Register methods with the TypeManager not only with
14995 the TypeContainer. This code was buggy.
14997 * interface.cs: Full registation here.
14999 2001-12-11 Miguel de Icaza <miguel@ximian.com>
15001 * expression.cs: Remove reducer for binary expressions, it can not
15004 * const.cs: Put here the code that used to go into constant.cs
15006 * constant.cs: Put here the code for constants, this is a new base
15007 class for Literals.
15009 * literal.cs: Make Literal derive from Constant.
15011 2001-12-09 Miguel de Icaza <miguel@ximian.com>
15013 * statement.cs (Return.Emit): Report error 157 if the user
15014 attempts to return from a finally block.
15016 (Return.Emit): Instead of emitting a return, jump to the end of
15019 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
15020 LocalBuilder to store the result of the function. ReturnLabel is
15021 the target where we jump.
15024 2001-12-09 Radek Doulik <rodo@ximian.com>
15026 * cs-parser.jay: remember alias in current namespace
15028 * ecore.cs (SimpleName::DoResolve): use aliases for types or
15031 * class.cs (LookupAlias): lookup alias in my_namespace
15033 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
15035 (LookupAlias): lookup alias in this and if needed in parent
15038 2001-12-08 Miguel de Icaza <miguel@ximian.com>
15042 * rootcontext.cs: (ModuleBuilder) Made static, first step into
15043 making things static. I need this to avoid passing the
15044 TypeContainer when calling ParameterType.
15046 * support.cs (InternalParameters.ParameterType): Remove ugly hack
15047 that did string manipulation to compute the type and then call
15048 GetType. Use Parameter.ParameterType instead.
15050 * cs-tokenizer.cs: Consume the suffix for floating values.
15052 * expression.cs (ParameterReference): figure out whether this is a
15053 reference parameter or not. Kill an extra variable by computing
15054 the arg_idx during emission.
15056 * parameter.cs (Parameters.GetParameterInfo): New overloaded
15057 function that returns whether a parameter is an out/ref value or not.
15059 (Parameter.ParameterType): The type of the parameter (base,
15060 without ref/out applied).
15062 (Parameter.Resolve): Perform resolution here.
15063 (Parameter.ExternalType): The full type (with ref/out applied).
15065 * statement.cs (Using.Emit, Using.EmitExpression): Implement
15066 support for expressions on the using statement.
15068 2001-12-07 Miguel de Icaza <miguel@ximian.com>
15070 * statement.cs (Using.EmitLocalVariableDecls): Split the
15071 localvariable handling of the using statement.
15073 (Block.EmitMeta): Keep track of variable count across blocks. We
15074 were reusing slots on separate branches of blocks.
15076 (Try.Emit): Emit the general code block, we were not emitting it.
15078 Check the type of the declaration to be an IDisposable or
15079 something that can be implicity converted to it.
15081 Emit conversions if required.
15083 * ecore.cs (EmptyExpression): New utility class.
15084 (Expression.ImplicitConversionExists): New utility function.
15086 2001-12-06 Miguel de Icaza <miguel@ximian.com>
15088 * statement.cs (Using): Implement.
15090 * expression.cs (LocalVariableReference): Support read only variables.
15092 * statement.cs: Remove the explicit emit for the Leave opcode.
15093 (VariableInfo): Add a readonly field.
15095 2001-12-05 Miguel de Icaza <miguel@ximian.com>
15097 * ecore.cs (ConvCast): new class used to encapsulate the various
15098 explicit integer conversions that works in both checked and
15099 unchecked contexts.
15101 (Expression.ConvertNumericExplicit): Use new ConvCast class to
15102 properly generate the overflow opcodes.
15104 2001-12-04 Miguel de Icaza <miguel@ximian.com>
15106 * statement.cs: The correct type for the EmptyExpression is the
15107 element_type, not the variable type. Ravi pointed this out.
15109 2001-12-04 Ravi Pratap <ravi@ximian.com>
15111 * class.cs (Method::Define): Handle PInvoke methods specially
15112 by using DefinePInvokeMethod instead of the usual one.
15114 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
15115 above to do the task of extracting information and defining the method.
15117 2001-12-04 Ravi Pratap <ravi@ximian.com>
15119 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
15120 of the condition for string type.
15122 (Emit): Move that here.
15124 (ArrayCreation::CheckIndices): Keep string literals in their expression
15127 (EmitDynamicInitializers): Handle strings appropriately.
15129 2001-12-04 Miguel de Icaza <miguel@ximian.com>
15131 * codegen.cs (EmitContext): Replace multiple variables with a
15132 single pointer to the current Switch statement.
15134 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
15137 2001-12-03 Miguel de Icaza <miguel@ximian.com>
15141 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
15144 (Foreach.Emit): Foreach on arrays was not setting
15145 up the loop variables (for break/continue).
15147 (GotoCase): Semi-implented.
15149 2001-12-03 Ravi Pratap <ravi@ximian.com>
15151 * attribute.cs (CheckAttribute): Handle system attributes by using
15152 Attribute.GetAttributes to examine information we need.
15154 (GetValidPlaces): Same here.
15156 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
15158 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
15160 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
15162 (Method::Define): Set appropriate flags if we have a DllImport attribute.
15164 (Method::Emit): Handle the case when we are a PInvoke method.
15166 2001-12-03 Miguel de Icaza <miguel@ximian.com>
15168 * expression.cs: Use ResolveWithSimpleName on compound names.
15170 2001-12-02 Ravi Pratap <ravi@ximian.com>
15172 * constant.cs (EmitConstant): Make sure we resolve the associated expression
15173 before trying to reduce it.
15175 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
15177 * constant.cs (LookupConstantValue): Implement.
15179 (EmitConstant): Use the above in emitting the constant.
15181 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
15182 that are user-defined by doing a LookupConstantValue on them.
15184 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
15187 2001-11-29 Miguel de Icaza <miguel@ximian.com>
15189 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
15191 (BaseAccess.DoResolve): Implement.
15193 (MemberAccess.DoResolve): Split this routine into a
15194 ResolveMemberAccess routine that can be used independently
15196 2001-11-28 Miguel de Icaza <miguel@ximian.com>
15198 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
15199 As that share bits of the implementation. Is returns a boolean,
15200 while As returns the Type that is being probed.
15202 2001-12-01 Ravi Pratap <ravi@ximian.com>
15204 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
15205 instead of a Literal - much easier.
15207 (EnumInTransit): Remove - utterly useless :-)
15209 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
15211 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
15213 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
15214 chain when we have no associated expression.
15216 2001-11-30 Ravi Pratap <ravi@ximian.com>
15218 * constant.cs (Define): Use Location while reporting the errror.
15220 Also emit a warning when 'new' is used and there is no inherited
15223 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
15226 (LookupEnumValue): Implement to lookup an enum member's value and define it
15229 (Populate): Re-write accordingly to use the above routine.
15231 2001-11-27 Miguel de Icaza <miguel@ximian.com>
15233 * expression.cs (This): Fix prototype for DoResolveLValue to
15234 override the base class DoResolveLValue.
15236 * cs-parser.cs: Report errors cs574 and cs575 (destructor
15239 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
15240 (we need to load the address of the field here). This fixes
15243 (FieldExpr.DoResolveLValue): Call the DoResolve
15244 function to initialize the Instance expression.
15246 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
15247 correctly the GetEnumerator operation on a value type.
15249 * cs-parser.jay: Add more simple parsing error catches.
15251 * statement.cs (Switch): Add support for string switches.
15252 Handle null specially.
15254 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
15256 2001-11-28 Ravi Pratap <ravi@ximian.com>
15258 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
15260 (declare_local_constant): New helper function.
15262 * statement.cs (AddConstant): Keep a separate record of constants
15264 (IsConstant): Implement to determine if a variable is a constant.
15266 (GetConstantExpression): Implement.
15268 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
15270 * statement.cs (IsVariableDefined): Re-write.
15272 2001-11-27 Ravi Pratap <ravi@ximian.com>
15274 * class.cs (TypeContainer::FindMembers): Look for constants
15275 in the case when we are looking for MemberTypes.Field
15277 * expression.cs (MemberAccess::DoResolve): Check that in the
15278 case we are a FieldExpr and a Literal, we are not being accessed
15279 by an instance reference.
15281 * cs-parser.jay (local_constant_declaration): Implement.
15283 (declaration_statement): Implement for constant declarations.
15285 2001-11-26 Miguel de Icaza <miguel@ximian.com>
15287 * statement.cs (Switch): Catch double defaults.
15289 (Switch): More work on the switch() statement
15290 implementation. It works for integral values now, need to finish
15294 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15296 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
15297 integer literals into other integer literals. To be used by
15300 2001-11-24 Ravi Pratap <ravi@ximian.com>
15302 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
15305 (EmitDynamicInitializers): Cope with the above since we extract data
15306 directly from ArrayData now.
15308 (ExpectInitializers): Keep track of whether initializers are mandatory
15311 (Bounds): Make it a hashtable to prevent the same dimension being
15312 recorded for every element in that dimension.
15314 (EmitDynamicInitializers): Fix bug which prevented the Set array method
15317 Also fix bug which was causing the indices to be emitted in the reverse
15320 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15322 * expression.cs (ArrayCreation): Implement the bits that Ravi left
15323 unfinished. They do not work, because the underlying code is
15326 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15328 * cs-parser.jay: Remove bogus fixme.
15330 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
15331 on Switch statement.
15333 2001-11-23 Ravi Pratap <ravi@ximian.com>
15335 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
15338 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
15339 parameter. Apparently, any expression is allowed.
15341 (ValidateInitializers): Update accordingly.
15343 (CheckIndices): Fix some tricky bugs thanks to recursion.
15345 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
15346 I was being completely brain-dead.
15348 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
15349 and re-write acordingly.
15351 (DelegateInvocation): Re-write accordingly.
15353 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
15355 (MakeByteBlob): Handle types more correctly.
15357 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
15358 initialization from expressions but it is incomplete because I am a complete
15361 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15363 * statement.cs (If.Emit): Fix a bug that generated incorrect code
15364 on If. Basically, we have to return `true' (ie, we do return to
15365 our caller) only if both branches of the if return.
15367 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
15368 short-circuit operators, handle them as short circuit operators.
15370 (Cast.DoResolve): Resolve type.
15371 (Cast.Cast): Take an expression as the target type.
15373 * cs-parser.jay (cast_expression): Remove old hack that only
15374 allowed a limited set of types to be handled. Now we take a
15375 unary_expression and we resolve to a type during semantic
15378 Use the grammar productions from Rhys to handle casts (this is
15379 not complete like Rhys syntax yet, we fail to handle that corner
15380 case that C# has regarding (-x), but we will get there.
15382 2001-11-22 Ravi Pratap <ravi@ximian.com>
15384 * class.cs (EmitFieldInitializer): Take care of the case when we have a
15385 field which is an array type.
15387 * cs-parser.jay (declare_local_variables): Support array initialization too.
15389 * typemanager.cs (MakeKey): Implement.
15391 (everywhere): Use the above appropriately.
15393 * cs-parser.jay (for_statement): Update for array initialization while
15394 declaring variables.
15396 * ecore.cs : The error message was correct, it's the variable's names that
15397 were misleading ;-) Make the code more readable.
15399 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
15400 the correct type etc.
15402 (ConvertExplicit): Handle Enum types by examining the underlying type.
15404 2001-11-21 Ravi Pratap <ravi@ximian.com>
15406 * parameter.cs (GetCallingConvention): Always return
15407 CallingConventions.Standard for now.
15409 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15411 * expression.cs (Binary.ResolveOperator): Update the values of `l'
15412 and `r' after calling DoNumericPromotions.
15414 * ecore.cs: Fix error message (the types were in the wrong order).
15416 * statement.cs (Foreach.ProbeCollectionType): Need to pass
15417 BindingFlags.Instance as well
15419 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
15420 implicit int literal conversion in an empty cast so that we
15421 propagate the right type upstream.
15423 (UnboxCast): new class used to unbox value types.
15424 (Expression.ConvertExplicit): Add explicit type conversions done
15427 (Expression.ImplicitNumericConversion): Oops, forgot to test for
15428 the target type before applying the implicit LongLiterals to ULong
15431 2001-11-21 Miguel de Icaza <miguel@ximian.com>
15433 * cs-parser.jay (for_statement): Reworked the way For works: now
15434 we declare manually any variables that are introduced in
15435 for_initializer to solve the problem of having out-of-band code
15436 emition (that is what got for broken).
15438 (declaration_statement): Perform the actual variable declaration
15439 that used to be done in local_variable_declaration here.
15441 (local_variable_declaration): Do not declare anything, just pass
15442 the information on a DictionaryEntry
15444 2001-11-20 Ravi Pratap <ravi@ximian.com>
15446 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
15447 re-write of the logic to now make it recursive.
15449 (UpdateIndices): Re-write accordingly.
15451 Store element data in a separate ArrayData list in the above methods.
15453 (MakeByteBlob): Implement to dump the array data into a byte array.
15455 2001-11-19 Ravi Pratap <ravi@ximian.com>
15457 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
15460 * constant.cs (Define): Implement.
15462 (EmitConstant): Re-write fully.
15464 Pass in location info.
15466 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
15469 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
15470 DictionaryEntry since we need location info too.
15472 (constant_declaration): Update accordingly.
15474 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
15475 code into another method : UpdateIndices.
15477 2001-11-18 Ravi Pratap <ravi@ximian.com>
15479 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
15480 some type checking etc.
15482 2001-11-17 Ravi Pratap <ravi@ximian.com>
15484 * expression.cs (ArrayCreation::ValidateInitializers): Implement
15485 bits to provide dimension info if the user skips doing that.
15487 Update second constructor to store the rank correctly.
15489 2001-11-16 Ravi Pratap <ravi@ximian.com>
15491 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
15492 and try to implement.
15494 * ../errors/cs0150.cs : Add.
15496 * ../errors/cs0178.cs : Add.
15498 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15500 * statement.cs: Implement foreach on multi-dimensional arrays.
15502 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15503 name of the params argument.
15505 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15506 initializing the array.
15508 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15509 we can use this elsewhere.
15511 * statement.cs: Finish implementation of foreach for single
15514 * cs-parser.jay: Use an out-of-band stack to pass information
15515 around, I wonder why I need this.
15517 foreach_block: Make the new foreach_block the current_block.
15519 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15520 function used to return a static Parameters structure. Used for
15521 empty parameters, as those are created very frequently.
15523 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15525 2001-11-15 Ravi Pratap <ravi@ximian.com>
15527 * interface.cs : Default modifier is private, not public. The
15528 make verify test passes again.
15530 2001-11-15 Ravi Pratap <ravi@ximian.com>
15532 * support.cs (ReflectionParameters): Fix logic to determine
15533 whether the last parameter is a params one. Test 9 passes again.
15535 * delegate.cs (Populate): Register the builders we define with
15536 RegisterParameterForBuilder. Test 19 passes again.
15538 * cs-parser.jay (property_declaration): Reference $6 instead
15539 of $$ to get at the location.
15541 (indexer_declaration): Similar stuff.
15543 (attribute): Ditto.
15545 * class.cs (Property): Register parameters for the Get and Set methods
15546 if they exist. Test 23 passes again.
15548 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15549 call to EmitArguments as we are sure there aren't any params arguments.
15550 Test 32 passes again.
15552 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15553 IndexOutOfRangeException.
15555 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15556 Test 33 now passes again.
15558 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15560 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15561 broke a bunch of things. Will have to come up with a better way
15562 of tracking locations.
15564 * statement.cs: Implemented foreach for single dimension arrays.
15566 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15568 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15569 an error. This removes the lookup from the critical path.
15571 * cs-parser.jay: Removed use of temporary_loc, which is completely
15574 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15576 * support.cs (ReflectionParameters.ParameterModifier): Report
15577 whether the argument is a PARAMS argument or not.
15579 * class.cs: Set the attribute `ParamArrayAttribute' on the
15580 parameter argument.
15582 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15583 and cons_param_array_attribute (ConstructorInfo for
15584 ParamArrayAttribute).,
15586 * codegen.cs: Emit the return using the `Return' statement, that
15587 way we can report the error correctly for missing return values.
15589 * class.cs (Method.Emit): Clean up.
15591 * expression.cs (Argument.Resolve): Take another argument: the
15592 location where this argument is used. Notice that this is not
15593 part of the "Argument" class as to reduce the size of the
15594 structure (we know the approximate location anyways).
15596 Test if the argument is a variable-reference, if not, then
15597 complain with a 206.
15599 (Argument.Emit): Emit addresses of variables.
15601 (Argument.FullDesc): Simplify.
15603 (Invocation.DoResolve): Update for Argument.Resolve.
15605 (ElementAccess.DoResolve): ditto.
15607 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15608 method should be virtual, as this method is always virtual.
15610 (NewDelegate.DoResolve): Update for Argument.Resolve.
15612 * class.cs (ConstructorInitializer.DoResolve): ditto.
15614 * attribute.cs (Attribute.Resolve): ditto.
15616 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15618 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15620 * expression.cs (ParameterReference): Drop IStackStorage and implement
15621 IAssignMethod instead.
15623 (LocalVariableReference): ditto.
15625 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15626 IAssignMethod instead.
15628 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15630 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15631 enumerations that are used in heavily used structures derive from
15632 byte in a laughable and pathetic attempt to reduce memory usage.
15633 This is the kind of pre-optimzations that you should not do at
15634 home without adult supervision.
15636 * expression.cs (UnaryMutator): New class, used to handle ++ and
15637 -- separatedly from the other unary operators. Cleans up the
15638 code, and kills the ExpressionStatement dependency in Unary.
15640 (Unary): Removed `method' and `Arguments' from this class, making
15641 it smaller, and moving it all to SimpleCall, so I can reuse this
15642 code in other locations and avoid creating a lot of transient data
15643 strucutres when not required.
15645 * cs-parser.jay: Adjust for new changes.
15647 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15649 * enum.cs (Enum.Populate): If there is a failure during
15652 * cs-parser.jay (opt_enum_base): we used to catch type errors
15653 here, but this is really incorrect. The type error should be
15654 catched during semantic analysis.
15656 2001-12-11 Ravi Pratap <ravi@ximian.com>
15658 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15659 current_local_parameters as expected since I, in my stupidity, had forgotten
15662 * attribute.cs (GetValidPlaces): Fix stupid bug.
15664 * class.cs (Method::Emit): Perform check on applicability of attributes.
15666 (Constructor::Emit): Ditto.
15668 (Field::Emit): Ditto.
15670 (Field.Location): Store location information.
15672 (Property, Event, Indexer, Operator): Ditto.
15674 * cs-parser.jay (field_declaration): Pass in location for each field.
15676 * ../errors/cs0592.cs : Add.
15678 2001-11-12 Ravi Pratap <ravi@ximian.com>
15680 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15682 (InitCoreTypes): Update accordingly.
15684 (RegisterAttrType, LookupAttr): Implement.
15686 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15687 info about the same.
15689 (Resolve): Update to populate the above as necessary.
15691 (Error592): Helper.
15693 (GetValidPlaces): Helper to the above.
15695 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15697 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15699 2001-11-12 Ravi Pratap <ravi@ximian.com>
15701 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15703 * ../errors/cs0617.cs : Add.
15705 2001-11-11 Ravi Pratap <ravi@ximian.com>
15707 * enum.cs (Emit): Rename to Populate to be more consistent with what
15708 we expect it to do and when exactly it is called.
15710 * class.cs, rootcontext.cs : Update accordingly.
15712 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15713 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15715 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15717 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15718 of a fieldinfo using the above, when dealing with a FieldBuilder.
15720 2001-11-10 Ravi Pratap <ravi@ximian.com>
15722 * ../errors/cs0031.cs : Add.
15724 * ../errors/cs1008.cs : Add.
15726 * ../errrors/cs0543.cs : Add.
15728 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15731 (FindMembers): Implement.
15733 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15734 enums and delegates too.
15736 (enum_types): Rename to builder_to_enum.
15738 (delegate_types): Rename to builder_to_delegate.
15740 * delegate.cs (FindMembers): Implement.
15742 2001-11-09 Ravi Pratap <ravi@ximian.com>
15744 * typemanager.cs (IsEnumType): Implement.
15746 * enum.cs (Emit): Re-write parts to account for the underlying type
15747 better and perform checking etc.
15749 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15750 of the underlying type.
15752 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15755 * enum.cs (error31): Helper to report error #31.
15757 * cs-parser.jay (enum_declaration): Store location of each member too.
15759 * enum.cs (member_to_location): New hashtable.
15761 (AddEnumMember): Update location hashtable.
15763 (Emit): Use the location of each member while reporting errors.
15765 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15767 * cs-parser.jay: A for_initializer if is a
15768 local_variable_declaration really ammount to have an implicit
15769 block with the variable declaration and no initializer for for.
15771 * statement.cs (For.Emit): Cope with null initializers.
15773 This fixes the infinite loop on for initializers.
15775 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15777 * enum.cs: More cleanup.
15779 * ecore.cs: Remove dead code.
15781 * class.cs (Property.Emit): More simplification.
15782 (Event.Emit): ditto.
15784 Reworked to have less levels of indentation.
15786 2001-11-08 Ravi Pratap <ravi@ximian.com>
15788 * class.cs (Property): Emit attributes.
15798 * enum.cs (Emit): Ditto.
15800 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15803 * class.cs (Field, Event, etc.): Move attribute generation into the
15804 Emit method everywhere.
15806 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15807 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15808 as we had no way of defining nested enums !
15810 * rootcontext.cs : Adjust code accordingly.
15812 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15814 2001-11-07 Ravi Pratap <ravi@ximian.com>
15816 * expression.cs (EvalConstantExpression): Move into ecore.cs
15818 * enum.cs (Enum): Rename some members and make them public and readonly
15819 according to our convention.
15821 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15824 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15826 (Enum::Emit): Write a simple version for now which doesn't try to compute
15827 expressions. I shall modify this to be more robust in just a while.
15829 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15831 (TypeContainer::CloseType): Create the Enum types too.
15833 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15835 * expression.cs (EvalConstantExpression): Get rid of completely.
15837 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15838 user-defined values and other cases.
15840 (IsValidEnumLiteral): Helper function.
15842 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15843 out there in the case we had a literal FieldExpr.
15845 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15847 (Literalize): Revamp a bit to take two arguments.
15849 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15851 2001-11-06 Ravi Pratap <ravi@ximian.com>
15853 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15855 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15857 (Resolve): Use the above to ensure we have proper initializers.
15859 2001-11-05 Ravi Pratap <ravi@ximian.com>
15861 * expression.cs (Expression::EvalConstantExpression): New method to
15862 evaluate constant expressions.
15864 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15866 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15868 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15871 (Binary.ResolveOperator): Handle operator != (object a, object b)
15872 and operator == (object a, object b);
15874 (Binary.DoNumericPromotions): Indicate whether the numeric
15875 promotion was possible.
15877 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15880 Made the ArrayAccess implement interface IAssignMethod instead of
15881 IStackStore as the order in which arguments are passed reflects
15884 * assign.cs: Instead of using expr.ExprClass to select the way of
15885 assinging, probe for the IStackStore/IAssignMethod interfaces.
15887 * typemanager.cs: Load InitializeArray definition.
15889 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15890 static data that can be used to initialize arrays.
15892 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15894 * expression.cs: Handle operator== and operator!= for booleans.
15896 (Conditioal.Reduce): Implement reducer for the ?: operator.
15898 (Conditional.Resolve): Implement dead code elimination.
15900 (Binary.Resolve): Catch string literals and return a new
15901 concatenated string.
15903 (Unary.Reduce): Implement reduction of unary expressions.
15905 * ecore.cs: Split out the expression core handling here.
15907 (Expression.Reduce): New method used to perform constant folding
15908 and CSE. This is needed to support constant-expressions.
15910 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15911 targets, and optimize for !x.
15913 2001-11-04 Ravi Pratap <ravi@ximian.com>
15915 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15916 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15917 set custom atttributes.
15919 * literal.cs (Literal::GetValue): New abstract method to return the actual
15920 value of the literal, cast as an object.
15922 (*Literal): Implement GetValue method.
15924 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15925 expressions to the arraylist but objects of type Argument.
15927 * class.cs (TypeContainer::Emit): Emit our attributes too.
15929 (Method::Emit, Constructor::Emit): Ditto.
15931 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15932 to be ignoring earlier.
15934 2001-11-03 Ravi Pratap <ravi@ximian.com>
15936 * attribute.cs (AttributeSection::Define): Implement to do the business
15937 of constructing a CustomAttributeBuilder.
15939 (Attribute): New trivial class. Increases readability of code.
15941 * cs-parser.jay : Update accordingly.
15943 (positional_argument_list, named_argument_list, named_argument): New rules
15945 (attribute_arguments): Use the above so that we are more correct.
15947 2001-11-02 Ravi Pratap <ravi@ximian.com>
15949 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15950 to perform all checks for a method with a params parameter.
15952 (Invocation::OverloadResolve): Update to use the above method and therefore
15953 cope correctly with params method invocations.
15955 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15958 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15959 constructors in our parent too because we can't afford to miss out on
15962 * attribute.cs (AttributeSection): New name for the class Attribute
15964 Other trivial changes to improve readability.
15966 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15967 use the new class names.
15969 2001-11-01 Ravi Pratap <ravi@ximian.com>
15971 * class.cs (Method::Define): Complete definition for params types too
15973 (Indexer::Define): Ditto.
15975 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15976 Cope everywhere with a request for info about the array parameter.
15978 2001-11-01 Ravi Pratap <ravi@ximian.com>
15980 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15982 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15983 local_variable_type to extract the string corresponding to the type.
15985 (local_variable_type): Fixup the action to use the new helper method.
15987 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15990 * expression.cs : Clean out code which uses the above.
15992 2001-10-31 Ravi Pratap <ravi@ximian.com>
15994 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15995 and bale out if necessary by returning a false.
15997 (RegisterProperty): Ditto.
15999 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
16000 and print out appropriate error messages.
16002 * interface.cs (everywhere): Ditto.
16004 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
16005 location to constructor.
16007 * class.cs (Property, Event, Indexer): Update accordingly.
16009 * ../errors/cs111.cs : Added.
16011 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
16012 of a method, as laid down by the spec.
16014 (Invocation::OverloadResolve): Use the above method.
16016 2001-10-31 Ravi Pratap <ravi@ximian.com>
16018 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
16019 now take a TypeContainer and a Parameters object.
16021 (ParameterData): Modify return type of ParameterModifier method to be
16022 Parameter.Modifier and not a string.
16024 (ReflectionParameters, InternalParameters): Update accordingly.
16026 * expression.cs (Argument::GetParameterModifier): Same here.
16028 * support.cs (InternalParameters::ParameterType): Find a better way of determining
16029 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
16030 symbol in it at all so maybe this is only for now.
16032 2001-10-30 Ravi Pratap <ravi@ximian.com>
16034 * support.cs (InternalParameters): Constructor now takes an extra argument
16035 which is the actual Parameters class.
16037 (ParameterDesc): Update to provide info on ref/out modifiers.
16039 * class.cs (everywhere): Update call to InternalParameters to pass in
16040 the second argument too.
16042 * support.cs (ParameterData): Add ParameterModifier, which is a method
16043 to return the modifier info [ref/out etc]
16045 (InternalParameters, ReflectionParameters): Implement the above.
16047 * expression.cs (Argument::ParameterModifier): Similar function to return
16048 info about the argument's modifiers.
16050 (Invocation::OverloadResolve): Update to take into account matching modifiers
16053 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
16054 a new SetFormalParameters object which we pass to InternalParameters.
16056 2001-10-30 Ravi Pratap <ravi@ximian.com>
16058 * expression.cs (NewArray): Merge into the ArrayCreation class.
16060 2001-10-29 Ravi Pratap <ravi@ximian.com>
16062 * expression.cs (NewArray): Merge classes NewBuiltinArray and
16063 NewUserdefinedArray into one as there wasn't much of a use in having
16066 * expression.cs (Argument): Change field's name to ArgType from Type.
16068 (Type): New readonly property which returns the proper type, taking into
16069 account ref/out modifiers.
16071 (everywhere): Adjust code accordingly for the above.
16073 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
16074 whether we are emitting for a ref or out parameter.
16076 * expression.cs (Argument::Emit): Use the above field to set the state.
16078 (LocalVariableReference::Emit): Update to honour the flag and emit the
16081 * parameter.cs (Attributes): Set the correct flags for ref parameters.
16083 * expression.cs (Argument::FullDesc): New function to provide a full desc.
16085 * support.cs (ParameterData): Add method ParameterDesc to the interface.
16087 (ReflectionParameters, InternalParameters): Implement the above method.
16089 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
16092 (Invocation::FullMethodDesc): Ditto.
16094 2001-10-29 Miguel de Icaza <miguel@ximian.com>
16096 * cs-parser.jay: Add extra production for the second form of array
16099 * expression.cs (ArrayCreation): Update to reflect the above
16102 * Small changes to prepare for Array initialization.
16104 2001-10-28 Miguel de Icaza <miguel@ximian.com>
16106 * typemanager.cs (ImplementsInterface): interface might be null;
16107 Deal with this problem;
16109 Also, we do store negative hits on the cache (null values), so use
16110 this instead of calling t.GetInterfaces on the type everytime.
16112 2001-10-28 Ravi Pratap <ravi@ximian.com>
16114 * typemanager.cs (IsBuiltinType): New method to help determine the same.
16116 * expression.cs (New::DoResolve): Get rid of array creation code and instead
16117 split functionality out into different classes.
16119 (New::FormArrayType): Move into NewBuiltinArray.
16121 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
16124 (NewBuiltinArray): New class to handle creation of built-in arrays.
16126 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
16127 account creation of one-dimensional arrays.
16129 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
16131 (NewUserdefinedArray::DoResolve): Implement.
16133 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
16135 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
16136 we maintain inside the TypeManager. This is necessary to perform lookups on the
16139 (LookupType): Update to perform GetType on the module builders too.
16141 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
16143 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
16145 2001-10-23 Ravi Pratap <ravi@ximian.com>
16147 * expression.cs (New::DoResolve): Implement guts of array creation.
16149 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
16151 2001-10-27 Miguel de Icaza <miguel@ximian.com>
16153 * expression.cs: Fix bug I introduced lsat night that broke
16156 (Expression.Resolve): Report a 246 error (can not resolve name)
16157 if we find a SimpleName in the stream.
16159 (Expression.ResolveLValue): Ditto.
16161 (Expression.ResolveWithSimpleName): This function is a variant of
16162 ResolveName, this one allows SimpleNames to be returned without a
16163 warning. The only consumer of SimpleNames is MemberAccess
16165 2001-10-26 Miguel de Icaza <miguel@ximian.com>
16167 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
16168 might arrive here. I have my doubts that this is correct.
16170 * statement.cs (Lock): Implement lock statement.
16172 * cs-parser.jay: Small fixes to support `lock' and `using'
16174 * cs-tokenizer.cs: Remove extra space
16176 * driver.cs: New flag --checked, allows to turn on integer math
16179 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
16180 Threading.Monitor.Exit
16182 2001-10-23 Miguel de Icaza <miguel@ximian.com>
16184 * expression.cs (IndexerAccess::DoResolveLValue): Set the
16185 Expression Class to be IndexerAccess.
16187 Notice that Indexer::DoResolve sets the eclass to Value.
16189 2001-10-22 Miguel de Icaza <miguel@ximian.com>
16191 * class.cs (TypeContainer::Emit): Emit code for indexers.
16193 * assign.cs (IAssignMethod): New interface implemented by Indexers
16194 and Properties for handling assignment.
16196 (Assign::Emit): Simplify and reuse code.
16198 * expression.cs (IndexerAccess, PropertyExpr): Implement
16199 IAssignMethod, clean up old code.
16201 2001-10-22 Ravi Pratap <ravi@ximian.com>
16203 * typemanager.cs (ImplementsInterface): New method to determine if a type
16204 implements a given interface. Provides a nice cache too.
16206 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
16209 (ConvertReferenceExplicit): Ditto.
16211 * delegate.cs (Delegate::Populate): Update to define the parameters on the
16212 various methods, with correct names etc.
16214 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
16215 Operator.UnaryNegation.
16217 * cs-parser.jay (operator_declarator): Be a little clever in the case where
16218 we have a unary plus or minus operator.
16220 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
16223 * everywhere : update accordingly.
16225 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
16228 * class.cs (Method::Define): For the case where we are implementing a method
16229 inherited from an interface, we need to set the MethodAttributes.Final flag too.
16230 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
16232 2001-10-21 Ravi Pratap <ravi@ximian.com>
16234 * interface.cs (FindMembers): Implement to work around S.R.E
16237 * typemanager.cs (IsInterfaceType): Implement.
16239 (FindMembers): Update to handle interface types too.
16241 * expression.cs (ImplicitReferenceConversion): Re-write bits which
16242 use IsAssignableFrom as that is not correct - it doesn't work.
16244 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
16245 and accordingly override EmitStatement.
16247 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
16248 using the correct logic :-)
16250 2001-10-19 Ravi Pratap <ravi@ximian.com>
16252 * ../errors/cs-11.cs : Add to demonstrate error -11
16254 2001-10-17 Miguel de Icaza <miguel@ximian.com>
16256 * assign.cs (Assign::Resolve): Resolve right hand side first, and
16257 then pass this as a hint to ResolveLValue.
16259 * expression.cs (FieldExpr): Add Location information
16261 (FieldExpr::LValueResolve): Report assignment to readonly
16264 (Expression::ExprClassFromMemberInfo): Pass location information.
16266 (Expression::ResolveLValue): Add new method that resolves an
16269 (Expression::DoResolveLValue): Default invocation calls
16272 (Indexers): New class used to keep track of indexers in a given
16275 (IStackStore): Renamed from LValue, as it did not really describe
16276 what this did. Also ResolveLValue is gone from this interface and
16277 now is part of Expression.
16279 (ElementAccess): Depending on the element access type
16281 * typemanager.cs: Add `indexer_name_type' as a Core type
16282 (System.Runtime.CompilerServices.IndexerNameAttribute)
16284 * statement.cs (Goto): Take a location.
16286 2001-10-18 Ravi Pratap <ravi@ximian.com>
16288 * delegate.cs (Delegate::VerifyDelegate): New method to verify
16289 if two delegates are compatible.
16291 (NewDelegate::DoResolve): Update to take care of the case when
16292 we instantiate a delegate from another delegate.
16294 * typemanager.cs (FindMembers): Don't even try to look up members
16295 of Delegate types for now.
16297 2001-10-18 Ravi Pratap <ravi@ximian.com>
16299 * delegate.cs (NewDelegate): New class to take care of delegate
16302 * expression.cs (New): Split the delegate related code out into
16303 the NewDelegate class.
16305 * delegate.cs (DelegateInvocation): New class to handle delegate
16308 * expression.cs (Invocation): Split out delegate related code into
16309 the DelegateInvocation class.
16311 2001-10-17 Ravi Pratap <ravi@ximian.com>
16313 * expression.cs (New::DoResolve): Implement delegate creation fully
16314 and according to the spec.
16316 (New::DoEmit): Update to handle delegates differently.
16318 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
16319 because of which we were printing out arguments in reverse order !
16321 * delegate.cs (VerifyMethod): Implement to check if the given method
16322 matches the delegate.
16324 (FullDelegateDesc): Implement.
16326 (VerifyApplicability): Implement.
16328 * expression.cs (Invocation::DoResolve): Update to accordingly handle
16329 delegate invocations too.
16331 (Invocation::Emit): Ditto.
16333 * ../errors/cs1593.cs : Added.
16335 * ../errors/cs1594.cs : Added.
16337 * delegate.cs (InstanceExpression, TargetMethod): New properties.
16339 2001-10-16 Ravi Pratap <ravi@ximian.com>
16341 * typemanager.cs (intptr_type): Core type for System.IntPtr
16343 (InitCoreTypes): Update for the same.
16345 (iasyncresult_type, asynccallback_type): Ditto.
16347 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
16350 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
16353 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
16354 the builders for the 4 members of a delegate type :-)
16356 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
16359 * expression.cs (New::DoResolve): Implement guts for delegate creation.
16361 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
16363 2001-10-15 Miguel de Icaza <miguel@ximian.com>
16365 * statement.cs (Break::Emit): Implement.
16366 (Continue::Emit): Implement.
16368 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
16369 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
16370 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
16371 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
16374 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
16375 properties that track the label for the current loop (begin of the
16376 loop and end of the loop).
16378 2001-10-15 Ravi Pratap <ravi@ximian.com>
16380 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
16381 use of emitting anything at all.
16383 * class.cs, rootcontext.cs : Get rid of calls to the same.
16385 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
16387 (Populate): Define the constructor correctly and set the implementation
16390 * typemanager.cs (delegate_types): New hashtable to hold delegates that
16393 (AddDelegateType): Implement.
16395 (IsDelegateType): Implement helper method.
16397 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
16399 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
16400 and accordingly handle it.
16402 * delegate.cs (Populate): Take TypeContainer argument.
16403 Implement bits to define the Invoke method. However, I still haven't figured out
16404 how to take care of the native int bit :-(
16406 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
16407 Qualify the name of the delegate, not its return type !
16409 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
16412 (StandardConversionExists): Checking for array types turns out to be recursive.
16414 (ConvertReferenceExplicit): Implement array conversion.
16416 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
16418 2001-10-12 Ravi Pratap <ravi@ximian.com>
16420 * cs-parser.jay (delegate_declaration): Store the fully qualified
16421 name as it is a type declaration.
16423 * delegate.cs (ReturnType, Name): Rename members to these. Make them
16426 (DefineDelegate): Renamed from Define. Does the same thing essentially,
16427 as TypeContainer::DefineType.
16429 (Populate): Method in which all the definition of the various methods (Invoke)
16432 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
16435 (CloseDelegate): Finally creates the delegate.
16437 * class.cs (TypeContainer::DefineType): Update to define delegates.
16438 (Populate, Emit and CloseType): Do the same thing here too.
16440 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
16441 delegates in all these operations.
16443 2001-10-14 Miguel de Icaza <miguel@ximian.com>
16445 * expression.cs: LocalTemporary: a new expression used to
16446 reference a temporary that has been created.
16448 * assign.cs: Handle PropertyAccess back here, so that we can
16449 provide the proper semantic access to properties.
16451 * expression.cs (Expression::ConvertReferenceExplicit): Implement
16452 a few more explicit conversions.
16454 * modifiers.cs: `NEW' modifier maps to HideBySig.
16456 * expression.cs (PropertyExpr): Make this into an
16457 ExpressionStatement, and support the EmitStatement code path.
16459 Perform get/set error checking, clean up the interface.
16461 * assign.cs: recognize PropertyExprs as targets, and if so, turn
16462 them into toplevel access objects.
16464 2001-10-12 Miguel de Icaza <miguel@ximian.com>
16466 * expression.cs: PropertyExpr::PropertyExpr: use work around the
16469 * typemanager.cs: Keep track here of our PropertyBuilders again to
16470 work around lameness in SRE.
16472 2001-10-11 Miguel de Icaza <miguel@ximian.com>
16474 * expression.cs (LValue::LValueResolve): New method in the
16475 interface, used to perform a second resolution pass for LValues.
16477 (This::DoResolve): Catch the use of this in static methods.
16479 (This::LValueResolve): Implement.
16481 (This::Store): Remove warning, assigning to `this' in structures
16484 (Invocation::Emit): Deal with invocation of
16485 methods on value types. We need to pass the address to structure
16486 methods rather than the object itself. (The equivalent code to
16487 emit "this" for structures leaves the entire structure on the
16488 stack instead of a pointer to it).
16490 (ParameterReference::DoResolve): Compute the real index for the
16491 argument based on whether the method takes or not a `this' pointer
16492 (ie, the method is static).
16494 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16495 value types returned from functions when we need to invoke a
16496 method on the sturcture.
16499 2001-10-11 Ravi Pratap <ravi@ximian.com>
16501 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16502 defining the type in the Modulebuilder or Typebuilder. This is to take
16503 care of nested types which need to be defined on the TypeBuilder using
16504 DefineNestedMethod.
16506 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16507 methods in RootContext, only ported to be part of TypeContainer.
16509 (TypeContainer::GetInterfaceOrClass): Ditto.
16511 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16513 * interface.cs (Interface::DefineInterface): New method. Does exactly
16514 what RootContext.CreateInterface did earlier, only it takes care of nested types
16517 (Interface::GetInterfaces): Move from RootContext here and port.
16519 (Interface::GetInterfaceByName): Same here.
16521 * rootcontext.cs (ResolveTree): Re-write.
16523 (PopulateTypes): Re-write.
16525 * class.cs (TypeContainer::Populate): Populate nested types too.
16526 (TypeContainer::Emit): Emit nested members too.
16528 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16529 instead just use the name argument passed in as it is already fully
16532 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16533 to TypeContainer mapping to see if a type is user-defined.
16535 * class.cs (TypeContainer::CloseType): Implement.
16537 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16538 the default constructor.
16540 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16543 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16545 * interface.cs (CloseType): Create the type here.
16547 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16550 Remove all the methods which are now in TypeContainer.
16552 2001-10-10 Ravi Pratap <ravi@ximian.com>
16554 * delegate.cs (Define): Re-write bits to define the delegate
16557 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16559 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16561 * expression.cs (ImplicitReferenceConversion): handle null as well
16562 as a source to convert to any reference type.
16564 * statement.cs (Return): Perform any implicit conversions to
16565 expected return type.
16567 Validate use of return statement.
16569 * codegen.cs (EmitContext): Pass the expected return type here.
16571 * class.cs (Method, Constructor, Property): Pass expected return
16572 type to EmitContext.
16574 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16576 * expression.cs: Make DoResolve take an EmitContext instead of a
16579 Replaced `l' and `location' for `loc', for consistency.
16581 (Error, Warning): Remove unneeded Tc argument.
16583 * assign.cs, literal.cs, constant.cs: Update to new calling
16586 * codegen.cs: EmitContext now contains a flag indicating whether
16587 code is being generated in a static method or not.
16589 * cs-parser.jay: DecomposeQI, new function that replaces the old
16590 QualifiedIdentifier. Now we always decompose the assembled
16591 strings from qualified_identifier productions into a group of
16594 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16596 * rootcontext.cs: Deal with field-less struct types correctly now
16597 by passing the size option to Define Type.
16599 * class.cs: Removed hack that created one static field.
16601 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16603 * statement.cs: Moved most of the code generation here.
16605 2001-10-09 Ravi Pratap <ravi@ximian.com>
16607 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16610 (ElementAccess): Remove useless bits for now - keep checks as the spec
16613 2001-10-08 Ravi Pratap <ravi@ximian.com>
16615 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16616 and start performing checks according to the spec.
16618 2001-10-07 Ravi Pratap <ravi@ximian.com>
16620 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16621 rank_specifiers instead.
16623 (rank_specifiers): Change the order in which the rank specifiers are stored
16625 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16627 * expression.cs (ElementAccess): Implement the LValue interface too.
16629 2001-10-06 Ravi Pratap <ravi@ximian.com>
16631 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16632 except that user defined conversions are not included.
16634 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16635 perform the conversion of the return type, if necessary.
16637 (New::DoResolve): Check whether we are creating an array or an object
16638 and accordingly do the needful.
16640 (New::Emit): Same here.
16642 (New::DoResolve): Implement guts of array creation.
16644 (New::FormLookupType): Helper function.
16646 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16648 * codegen.cs: Removed most of the code generation here, and move the
16649 corresponding code generation bits to the statement classes.
16651 Added support for try/catch/finalize and throw.
16653 * cs-parser.jay: Added support for try/catch/finalize.
16655 * class.cs: Catch static methods having the flags override,
16656 virtual or abstract.
16658 * expression.cs (UserCast): This user cast was not really doing
16659 what it was supposed to do. Which is to be born in fully resolved
16660 state. Parts of the resolution were being performed at Emit time!
16664 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16666 * expression.cs: Implicity convert the result from UserCast.
16668 2001-10-05 Ravi Pratap <ravi@ximian.com>
16670 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16671 prevented it from working correctly.
16673 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16674 merely ConvertImplicit.
16676 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16678 * typemanager.cs: Make the LookupTypeContainer function static,
16679 and not per-instance.
16681 * class.cs: Make static FindMembers (the one that takes a Type
16684 * codegen.cs: Add EmitForeach here.
16686 * cs-parser.jay: Make foreach a toplevel object instead of the
16687 inline expansion, as we need to perform semantic analysis on it.
16689 2001-10-05 Ravi Pratap <ravi@ximian.com>
16691 * expression.cs (Expression::ImplicitUserConversion): Rename to
16692 UserDefinedConversion.
16694 (Expression::UserDefinedConversion): Take an extra argument specifying
16695 whether we look for explicit user conversions too.
16697 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16699 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16701 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16702 with the appropriate arguments.
16704 * cs-parser.jay (cast_expression): Record location too.
16706 * expression.cs (Cast): Record location info.
16708 (Expression::ConvertExplicit): Take location argument.
16710 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16711 to determine if we are doing explicit conversions.
16713 (UserCast::Emit): Update accordingly.
16715 (Expression::ConvertExplicit): Report an error if everything fails.
16717 * ../errors/cs0030.cs : Add.
16719 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16721 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16722 virtual and newslot bits.
16724 * class.cs (TypeContainer::RegisterRequiredImplementations):
16725 Record methods we need.
16727 (TypeContainer::MakeKey): Helper function to make keys for
16728 MethodBases, since the Methodbase key is useless.
16730 (TypeContainer::Populate): Call RegisterRequiredImplementations
16731 before defining the methods.
16733 Create a mapping for method_builders_to_methods ahead of time
16734 instead of inside a tight loop.
16736 (::RequireMethods): Accept an object as the data to set into the
16737 hashtable so we can report interface vs abstract method mismatch.
16739 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16741 * report.cs: Make all of it static.
16743 * rootcontext.cs: Drop object_type and value_type computations, as
16744 we have those in the TypeManager anyways.
16746 Drop report instance variable too, now it is a global.
16748 * driver.cs: Use try/catch on command line handling.
16750 Add --probe option to debug the error reporting system with a test
16753 * report.cs: Add support for exiting program when a probe
16754 condition is reached.
16756 2001-10-03 Ravi Pratap <ravi@ximian.com>
16758 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16759 we do a forcible conversion regardless of type, to check if
16760 ForceConversion returns a null.
16762 (Binary::error19): Use location to report error.
16764 (Unary::error23): Use location here too.
16766 * ../errors/cs0019.cs : Check in.
16768 * ../errors/cs0023.cs : Check in.
16770 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16771 case of a non-null MethodInfo object with a length of 0 !
16773 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16774 an applicable member - according to the spec :-)
16775 Also fix logic to find members in base types.
16777 (Unary::ResolveOperator): Same here.
16779 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16780 as I was getting thoroughly confused between this and error19 :-)
16782 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16783 (::FindMostEncompassedType): Implement.
16784 (::FindMostEncompassingType): Implement.
16785 (::StandardConversionExists): Implement.
16787 (UserImplicitCast): Re-vamp. We now need info about most specific
16788 source and target types so that we can do the necessary conversions.
16790 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16791 mathematical union with no duplicates.
16793 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16795 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16796 in order from base classes to child classes, so that we can in
16797 child classes look up in our parent for method names and
16798 attributes (required for handling abstract, virtual, new, override
16799 constructs: we need to instrospect our base class, and if we dont
16800 populate the classes in order, the introspection might be
16801 incorrect. For example, a method could query its parent before
16802 the parent has any methods and would determine that the parent has
16803 no abstract methods (while it could have had them)).
16805 (RootContext::CreateType): Record the order in which we define the
16808 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16810 * class.cs (TypeContainer::Populate): Also method definitions can
16811 fail now, keep track of this.
16813 (TypeContainer::FindMembers): Implement support for
16814 DeclaredOnly/noDeclaredOnly flag.
16816 (Constructor::Emit) Return the ConstructorBuilder.
16818 (Method::Emit) Return the MethodBuilder.
16819 Check for abstract or virtual methods to be public.
16821 * rootcontext.cs (RootContext::CreateType): Register all the
16822 abstract methods required for the class to be complete and the
16823 interface methods that must be implemented.
16825 * cs-parser.jay: Report error 501 (method requires body if it is
16826 not marked abstract or extern).
16828 * expression.cs (TypeOf::Emit): Implement.
16830 * typemanager.cs: runtime_handle_type, new global type.
16832 * class.cs (Property::Emit): Generate code for properties.
16834 2001-10-02 Ravi Pratap <ravi@ximian.com>
16836 * expression.cs (Unary::ResolveOperator): Find operators on base type
16837 too - we now conform exactly to the spec.
16839 (Binary::ResolveOperator): Same here.
16841 * class.cs (Operator::Define): Fix minor quirk in the tests.
16843 * ../errors/cs0215.cs : Added.
16845 * ../errors/cs0556.cs : Added.
16847 * ../errors/cs0555.cs : Added.
16849 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16851 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16852 single integer which is really efficient
16854 2001-10-01 Ravi Pratap <ravi@ximian.com>
16856 * expression.cs (Expression::ImplicitUserConversion): Use location
16857 even in the case when we are examining True operators.
16859 * class.cs (Operator::Define): Perform extensive checks to conform
16860 with the rules for operator overloading in the spec.
16862 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16863 some of the other conversions mentioned in the spec.
16865 * typemanager.cs (array_type): New static member for the System.Array built-in
16868 (cloneable_interface): For System.ICloneable interface.
16870 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16871 we start resolving the tree and populating types.
16873 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16875 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16877 * expression.cs (Expression::ExprClassFromMemberInfo,
16878 Expression::Literalize): Create literal expressions from
16879 FieldInfos which are literals.
16881 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16882 type casts, because they were wrong. The test suite in tests
16885 (ImplicitNumericConversion): ushort to ulong requires a widening
16888 Int32 constant to long requires widening cast as well.
16890 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16891 for integers because the type on the stack is not i4.
16893 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16895 * expression.cs (report118): require location argument.
16897 * parameter.cs: Do not dereference potential null value.
16899 * class.cs: Catch methods that lack the `new' keyword when
16900 overriding a name. Report warnings when `new' is used without
16901 anything being there to override.
16903 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16905 * class.cs: Only add constructor to hashtable if it is non-null
16906 (as now constructors can fail on define).
16908 (TypeManager, Class, Struct): Take location arguments.
16910 Catch field instance initialization in structs as errors.
16912 accepting_filter: a new filter for FindMembers that is static so
16913 that we dont create an instance per invocation.
16915 (Constructor::Define): Catch errors where a struct constructor is
16918 * cs-parser.jay: Pass location information for various new
16921 * delegate.cs (Delegate): take a location argument.
16923 * driver.cs: Do not call EmitCode if there were problesm in the
16924 Definition of the types, as many Builders wont be there.
16926 * decl.cs (Decl::Decl): Require a location argument.
16928 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16929 into integers, and find the most appropiate integer for it.
16931 * literal.cs: Implement ULongLiteral.
16933 * rootcontext.cs: Provide better information about the location of
16934 failure when CreateType fails.
16936 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16938 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16941 * expression.cs (Binary::CheckShiftArguments): Add missing type
16943 (Binary::ResolveOperator): Add type to the logical and and logical
16944 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16947 (Binary::DoNumericPromotions): In the case where either argument
16948 is ulong (and most signed types combined with ulong cause an
16949 error) perform implicit integer constant conversions as well.
16951 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16953 * expression.cs (UserImplicitCast): Method should always be
16955 (Invocation::BetterConversion): Simplified test for IntLiteral.
16957 (Expression::ImplicitNumericConversion): Split this routine out.
16958 Put the code that performs implicit constant integer conversions
16961 (Expression::Resolve): Become a wrapper around DoResolve so we can
16962 check eclass and type being set after resolve.
16964 (Invocation::Badness): Remove this dead function
16966 (Binary::ResolveOperator): Do not compute the expensive argumnets
16967 unless we have a union for it.
16969 (Probe::Emit): Is needs to do an isinst and then
16970 compare against null.
16972 (::CanConvert): Added Location argument. If the Location argument
16973 is null (Location.Null), then we do not report errors. This is
16974 used by the `probe' mechanism of the Explicit conversion. We do
16975 not want to generate an error for something that the user
16976 explicitly requested to be casted. But the pipeline for an
16977 explicit cast first tests for potential implicit casts.
16979 So for now, if the Location is null, it means `Probe only' to
16980 avoid adding another argument. Might have to revise this
16983 (ClassCast): New class used to type cast objects into arbitrary
16984 classes (used in Explicit Reference Conversions).
16986 Implement `as' as well.
16988 Reverted all the patches from Ravi below: they were broken:
16990 * The use of `level' as a mechanism to stop recursive
16991 invocations is wrong. That was there just to catch the
16992 bug with a strack trace but not as a way of addressing
16995 To fix the problem we have to *understand* what is going
16996 on and the interactions and come up with a plan, not
16997 just get things going.
16999 * The use of the type conversion cache that I proposed
17000 last night had an open topic: How does this work across
17001 protection domains. A user defined conversion might not
17002 be public in the location where we are applying the
17003 conversion, a different conversion might be selected
17004 (ie, private A->B (better) but public B->A (worse),
17005 inside A, A->B applies, but outside it, B->A will
17008 * On top of that (ie, even if the above is solved),
17009 conversions in a cache need to be abstract. Ie, `To
17010 convert from an Int to a Short use an OpcodeCast', not
17011 `To convert from an Int to a Short use the OpcodeCast on
17012 the variable 5' (which is what this patch was doing).
17014 2001-09-28 Ravi Pratap <ravi@ximian.com>
17016 * expression.cs (Invocation::ConversionExists): Re-write to use
17017 the conversion cache
17019 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
17020 cache all conversions done, not just user-defined ones.
17022 (Invocation::BetterConversion): The real culprit. Use ConversionExists
17023 to determine if a conversion exists instead of acutually trying to
17024 perform the conversion. It's faster too.
17026 (Expression::ConvertExplicit): Modify to use ConversionExists to check
17027 and only then attempt the implicit conversion.
17029 2001-09-28 Ravi Pratap <ravi@ximian.com>
17031 * expression.cs (ConvertImplicit): Use a cache for conversions
17032 already found. Check level of recursion and bail out if necessary.
17034 2001-09-28 Miguel de Icaza <miguel@ximian.com>
17036 * typemanager.cs (string_concat_string_string, string_concat_object_object):
17037 Export standard methods that we expect for string operations.
17039 * statement.cs (Block::UsageWarning): Track usage of variables and
17040 report the errors for not used variables.
17042 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
17045 2001-09-27 Miguel de Icaza <miguel@ximian.com>
17047 * codegen.cs: remove unnneded code
17049 * expression.cs: Removed BuiltinTypeAccess class
17051 Fix the order in which implicit conversions are
17054 The previous fixed dropped support for boxed conversions (adding a
17055 test to the test suite now)
17057 (UserImplicitCast::CanConvert): Remove test for source being null,
17058 that code is broken. We should not feed a null to begin with, if
17059 we do, then we should track the bug where the problem originates
17060 and not try to cover it up here.
17062 Return a resolved expression of type UserImplicitCast on success
17063 rather than true/false. Ravi: this is what I was talking about,
17064 the pattern is to use a static method as a "constructor" for
17067 Also, do not create arguments until the very last minute,
17068 otherwise we always create the arguments even for lookups that
17069 will never be performed.
17071 (UserImplicitCast::Resolve): Eliminate, objects of type
17072 UserImplicitCast are born in a fully resolved state.
17074 * typemanager.cs (InitCoreTypes): Init also value_type
17075 (System.ValueType).
17077 * expression.cs (Cast::Resolve): First resolve the child expression.
17079 (LValue): Add new method AddressOf to be used by
17082 Change the argument of Store to take an EmitContext instead of an
17083 ILGenerator, because things like FieldExpr need to be able to call
17084 their children expression to generate the instance code.
17086 (Expression::Error, Expression::Warning): Sugar functions for
17089 (Expression::MemberLookup): Accept a TypeContainer instead of a
17090 Report as the first argument.
17092 (Expression::ResolvePrimary): Killed. I still want to improve
17093 this as currently the code is just not right.
17095 (Expression::ResolveMemberAccess): Simplify, but it is still
17098 (Unary::Resolve): Catch errors in AddressOf operators.
17100 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
17101 index to a byte for the short-version, or the compiler will choose
17102 the wrong Emit call, which generates the wrong data.
17104 (ParameterReference::Emit, ::Store): same.
17106 (FieldExpr::AddressOf): Implement.
17108 * typemanager.cs: TypeManager: made public variable instead of
17111 * driver.cs: document --fatal.
17113 * report.cs (ErrorMessage, WarningMessage): new names for the old
17114 Error and Warning classes.
17116 * cs-parser.jay (member_access): Turn built-in access to types
17117 into a normal simplename
17119 2001-09-27 Ravi Pratap <ravi@ximian.com>
17121 * expression.cs (Invocation::BetterConversion): Fix to cope
17122 with q being null, since this was introducing a bug.
17124 * expression.cs (ConvertImplicit): Do built-in conversions first.
17126 2001-09-27 Ravi Pratap <ravi@ximian.com>
17128 * expression.cs (UserImplicitCast::Resolve): Fix bug.
17130 2001-09-27 Ravi Pratap <ravi@ximian.com>
17132 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
17133 I had introduced long ago (what's new ?).
17135 * expression.cs (UserImplicitCast::CanConvert): Static method to do
17136 the work of all the checking.
17137 (ConvertImplicit): Call CanConvert and only then create object if necessary.
17138 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
17140 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
17141 that is the right way.
17143 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
17144 overloading resolution. Use everywhere instead of cutting and pasting code.
17146 (Binary::ResolveOperator): Use MakeUnionSet.
17148 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
17149 we have to convert to bool types. Not complete yet.
17151 2001-09-27 Miguel de Icaza <miguel@ximian.com>
17153 * typemanager.cs (TypeManager::CSharpName): support ushort.
17155 * expression.cs (Expression::TryImplicitIntConversion): Attempts
17156 to provide an expression that performsn an implicit constant int
17157 conversion (section 6.1.6).
17158 (Expression::ConvertImplicitRequired): Reworked to include
17159 implicit constant expression conversions.
17161 (Expression::ConvertNumericExplicit): Finished.
17163 (Invocation::Emit): If InstanceExpression is null, then it means
17164 that we perform a call on this.
17166 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17168 * expression.cs (Unary::Emit): Remove some dead code.
17169 (Probe): Implement Resolve and Emit for `is'.
17170 (Expression::ConvertImplicitRequired): Attempt to do constant
17171 expression conversions here. Maybe should be moved to
17172 ConvertImplicit, but I am not sure.
17173 (Expression::ImplicitLongConstantConversionPossible,
17174 Expression::ImplicitIntConstantConversionPossible): New functions
17175 that tell whether is it possible to apply an implicit constant
17176 expression conversion.
17178 (ConvertNumericExplicit): Started work on explicit numeric
17181 * cs-parser.jay: Update operator constants.
17183 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
17184 (Parameters::GetSignature): Hook up VerifyArgs here.
17185 (Parameters::VerifyArgs): Verifies that no two arguments have the
17188 * class.cs (Operator): Update the operator names to reflect the
17189 ones that the spec expects (as we are just stringizing the
17192 * expression.cs (Unary::ResolveOperator): Fix bug: Use
17193 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
17194 previous usage did only work for our methods.
17195 (Expression::ConvertImplicit): Handle decimal implicit numeric
17196 conversions as well.
17197 (Expression::InternalTypeConstructor): Used to invoke constructors
17198 on internal types for default promotions.
17200 (Unary::Emit): Implement special handling for the pre/post
17201 increment/decrement for overloaded operators, as they need to have
17202 the same semantics as the other operators.
17204 (Binary::ResolveOperator): ditto.
17205 (Invocation::ConversionExists): ditto.
17206 (UserImplicitCast::Resolve): ditto.
17208 2001-09-26 Ravi Pratap <ravi@ximian.com>
17210 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
17211 operator, return after emitting body. Regression tests pass again !
17213 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
17214 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
17215 (Invocation::OverloadResolve): Ditto.
17216 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
17218 * everywhere : update calls to the above methods accordingly.
17220 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17222 * assign.cs (Assign): Make it inherit from ExpressionStatement.
17224 * expression.cs (ExpressionStatement): New base class used for
17225 expressions that can appear in statements, so that we can provide
17226 an alternate path to generate expression that do not leave a value
17229 (Expression::Emit, and all the derivatives): We no longer return
17230 whether a value is left on the stack or not. Every expression
17231 after being emitted leaves a single value on the stack.
17233 * codegen.cs (EmitContext::EmitStatementExpression): Use the
17234 facilties of ExpressionStatement if possible.
17236 * cs-parser.jay: Update statement_expression.
17238 2001-09-25 Miguel de Icaza <miguel@ximian.com>
17240 * driver.cs: Change the wording of message
17242 2001-09-25 Ravi Pratap <ravi@ximian.com>
17244 * expression.cs (Binary::ResolveOperator): Had forgottten to set
17245 the type of the expression to the return type of the method if
17246 we have an overloaded operator match ! The regression tests pass again !
17247 (Unary::ResolveOperator): Ditto.
17249 * expression.cs (Invocation::ConversionExists): Correct the member lookup
17250 to find "op_Implicit", not "implicit" ;-)
17251 (UserImplicitCast): New class to take care of user-defined implicit conversions.
17252 (ConvertImplicit, ForceConversion): Take TypeContainer argument
17254 * everywhere : Correct calls to the above accordingly.
17256 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
17257 (ConvertImplicit): Do user-defined conversion if it exists.
17259 2001-09-24 Miguel de Icaza <miguel@ximian.com>
17261 * assign.cs: track location.
17262 (Resolve): Use implicit conversions on assignment.
17264 * literal.cs: Oops. Not good, Emit of short access values should
17265 pass (Bytes) or the wrong argument will be selected.
17267 * expression.cs (Unary::Emit): Emit code for -expr.
17269 (Unary::ResolveOperator): Handle `Substract' for non-constants
17270 (substract from zero from the non-constants).
17271 Deal with Doubles as well.
17273 (Expression::ConvertImplicitRequired): New routine that reports an
17274 error if no implicit conversion exists.
17276 (Invocation::OverloadResolve): Store the converted implicit
17277 expressions if we make them
17279 2001-09-24 Ravi Pratap <ravi@ximian.com>
17281 * class.cs (ConstructorInitializer): Take a Location argument.
17282 (ConstructorBaseInitializer): Same here.
17283 (ConstructorThisInitializer): Same here.
17285 * cs-parser.jay : Update all calls accordingly.
17287 * expression.cs (Unary, Binary, New): Take location argument.
17288 Update accordingly everywhere.
17290 * cs-parser.jay : Update all calls to the above to take a location
17293 * class.cs : Ditto.
17295 2001-09-24 Ravi Pratap <ravi@ximian.com>
17297 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
17298 (Invocation::BetterConversion): Same here
17299 (Invocation::ConversionExists): Ditto.
17301 (Invocation::ConversionExists): Implement.
17303 2001-09-22 Ravi Pratap <ravi@ximian.com>
17305 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
17306 Also take an additional TypeContainer argument.
17308 * All over : Pass in TypeContainer as argument to OverloadResolve.
17310 * typemanager.cs (CSharpName): Update to check for the string type and return
17313 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
17316 2001-09-21 Ravi Pratap <ravi@ximian.com>
17318 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
17319 (Invocation::BetterFunction): Implement.
17320 (Invocation::BetterConversion): Implement.
17321 (Invocation::ConversionExists): Skeleton, no implementation yet.
17323 Okay, things work fine !
17325 2001-09-21 Miguel de Icaza <miguel@ximian.com>
17327 * typemanager.cs: declare and load enum_type, delegate_type and
17330 * expression.cs (Expression::Emit): Now emit returns a value that
17331 tells whether a value is left on the stack or not. This strategy
17332 might be reveted tomorrow with a mechanism that would address
17333 multiple assignments.
17334 (Expression::report118): Utility routine to report mismatches on
17337 (Unary::Report23): Report impossible type/operator combination
17340 (Unary::IsIncrementableNumber): Whether the type can be
17341 incremented or decremented with add.
17342 (Unary::ResolveOperator): Also allow enumerations to be bitwise
17344 (Unary::ResolveOperator): Implement ++, !, ~,
17346 (Invocation::Emit): Deal with new Emit convetion.
17348 * All Expression derivatives: Updated their Emit method to return
17349 whether they leave values on the stack or not.
17351 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
17352 stack for expressions that are statements.
17354 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17356 * expression.cs (LValue): New interface. Must be implemented by
17358 (LocalVariableReference, ParameterReference, FieldExpr): Implement
17361 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
17362 interface for generating code, simplifies the code.
17364 2001-09-20 Ravi Pratap <ravi@ximian.com>
17366 * expression.cs (everywhere): Comment out return statements in ::Resolve
17367 methods to avoid the warnings.
17369 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17371 * driver.cs (parse): Report error 2001 if we can not open the
17374 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
17377 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
17380 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
17381 otherwise nested blocks end up with the same index.
17383 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
17385 * expression.cs: Instead of having FIXMEs in the Resolve
17386 functions, throw exceptions so it is obvious that we are facing a
17389 * cs-parser.jay (invocation_expression): Pass Location information.
17391 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
17392 Use a basename for those routines because .NET does not like paths
17395 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
17398 2001-09-19 Miguel de Icaza <miguel@ximian.com>
17400 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
17401 are loading the correct data types (throws an exception if not).
17402 (TypeManager::InitCoreTypes): Use CoreLookupType
17404 * expression.cs (Unary::ResolveOperator): return the child
17405 expression for expressions which are just +expr.
17406 (Unary::ResolveOperator): Return negative literals for -LITERAL
17407 expressions (otherwise they are Unary {Literal}).
17408 (Invocation::Badness): Take into account `Implicit constant
17409 expression conversions'.
17411 * literal.cs (LongLiteral): Implement long literal class.
17412 (IntLiteral): export the `Value' of the intliteral.
17414 2001-09-19 Ravi Pratap <ravi@ximian.com>
17416 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
17418 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
17419 instead of 'Operator'
17421 * expression.cs (Binary::ResolveOperator): Update accordingly.
17422 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
17425 * cs-parser.jay (unary_expression): Update to use the new names.
17427 * gen-treedump.cs (GetUnary): Same here.
17429 * expression.cs (Unary::Resolve): Implement.
17430 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
17431 operators are found instead of making noise ;-)
17432 (Unary::ResolveOperator): New method to do precisely the same thing which
17433 Binary::ResolveOperator does for Binary expressions.
17434 (Unary.method, .Arguments): Add.
17435 (Unary::OperName): Implement.
17436 (Unary::ForceConversion): Copy and Paste !
17438 * class.cs (Operator::Define): Fix a small bug for the case when we have
17441 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
17442 for the inbuilt operators. Only overloading works for now ;-)
17444 2001-09-18 Miguel de Icaza <miguel@ximian.com>
17446 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
17447 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
17449 * expression.cs (This::Emit): Implement.
17450 (This::Resolve): Implement.
17451 (TypeOf:Resolve): Implement.
17452 (Expression::ResolveSimpleName): Add an implicit this to instance
17454 (MemberAccess::Resolve): Deal with Parameters and Fields.
17455 Bind instance variable to Field expressions.
17456 (FieldExpr::Instance): New field used to track the expression that
17457 represents the object instance.
17458 (FieldExpr::Resolve): Track potential errors from MemberLookup not
17460 (FieldExpr::Emit): Implement.
17462 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
17463 the last instruction contains a return opcode to avoid generating
17464 the last `ret' instruction (this generates correct code, and it is
17465 nice to pass the peverify output).
17467 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
17468 initializer for static and instance variables.
17469 (Constructor::Emit): Allow initializer to be null in the case of
17470 static constructors. Only emit initializer for instance
17473 (TypeContainer::FindMembers): Return a null array if there are no
17476 Also fix the code for the MemberTypes.Method branch, as it was not
17477 scanning that for operators (or tried to access null variables before).
17479 * assign.cs (Assign::Emit): Handle instance and static fields.
17483 * driver.cs: Stop compilation if there are parse errors.
17485 * cs-parser.jay (constructor_declaration): Provide default base
17486 initializer for non-static constructors.
17487 (constructor_declarator): Do not provide a default base
17488 initializers if none was specified.
17489 Catch the fact that constructors should not have parameters.
17491 * class.cs: Do not emit parent class initializers for static
17492 constructors, that should be flagged as an error.
17494 2001-09-18 Ravi Pratap <ravi@ximian.com>
17496 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17497 Move back code into TypeContainer::Populate.
17499 2001-09-18 Ravi Pratap <ravi@ximian.com>
17501 * class.cs (TypeContainer::AddConstructor): Fix the check to
17502 compare against Name, not Basename.
17503 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17505 * cs-parser.jay : Update accordingly.
17507 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17508 for methods, don't forget to look into the operators too.
17509 (RegisterMethodBuilder): Helper method to take care of this for
17510 methods, constructors and operators.
17511 (Operator::Define): Completely revamp.
17512 (Operator.OperatorMethod, MethodName): New fields.
17513 (TypeContainer::Populate): Move the registering of builders into
17514 RegisterMethodBuilder.
17515 (Operator::Emit): Re-write.
17517 * expression.cs (Binary::Emit): Comment out code path to emit method
17518 invocation stuff for the case when we have a user defined operator. I am
17519 just not able to get it right !
17521 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17523 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17526 (Expression::MemberLookup): Provide a version that allows to
17527 specify the MemberTypes and BindingFlags.
17529 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17530 so it was not fetching variable information from outer blocks.
17532 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17533 Beforefieldinit as it was buggy.
17535 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17536 that Ravi put here.
17538 * class.cs (Constructor::Emit): Only emit if block is not null.
17539 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17540 deal with this by semantically definining it as if the user had
17543 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17544 constructors as we now "emit" them at a higher level.
17546 (TypeContainer::DefineDefaultConstructor): Used to define the
17547 default constructors if none was provided.
17549 (ConstructorInitializer): Add methods Resolve and Emit.
17551 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17553 2001-09-17 Ravi Pratap <ravi@ximian.com>
17555 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17556 the default constructor builder with our hashtable for methodbuilders
17559 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17560 and argument_count is 0 in which case we have a match.
17561 (Binary::ResolveOperator): More null checking and miscellaneous coding
17564 2001-09-17 Ravi Pratap <ravi@ximian.com>
17566 * rootcontext.cs (IsNameSpace): Compare against null.
17568 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17570 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17571 and Unary::Operator.
17573 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17576 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17577 we have overloaded operators.
17578 (Binary::ResolveOperator): Implement the part which does the operator overload
17581 * class.cs (Operator::Emit): Implement.
17582 (TypeContainer::Emit): Emit the operators we have too.
17584 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17585 the case when we have a user-defined operator.
17587 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17589 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17591 2001-09-16 Ravi Pratap <ravi@ximian.com>
17593 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17594 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17595 (Constructor::Emit): Implement.
17596 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17597 if we have no work to do.
17598 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17601 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17602 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17604 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17607 2001-09-15 Ravi Pratap <ravi@ximian.com>
17609 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17611 (Tree::RecordNamespace): Method to do what the name says ;-)
17612 (Tree::Namespaces): Property to get at the namespaces hashtable.
17614 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17617 * rootcontext.cs (IsNamespace): Fixed it :-)
17619 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17621 * class.cs (TypeContainer::FindMembers): Add support for
17623 (MethodCore): New class that encapsulates both the shared aspects
17624 of a Constructor and a Method.
17625 (Method, Constructor): Factored pieces into MethodCore.
17627 * driver.cs: Added --fatal which makes errors throw exceptions.
17628 Load System assembly as well as part of the standard library.
17630 * report.cs: Allow throwing exceptions on errors for debugging.
17632 * modifiers.cs: Do not use `parent', instead use the real type
17633 container to evaluate permission settings.
17635 * class.cs: Put Ravi's patch back in. He is right, and we will
17636 have to cope with the
17638 2001-09-14 Ravi Pratap <ravi@ximian.com>
17640 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17641 FamORAssem, not FamANDAssem.
17643 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17645 * driver.cs: Added --parse option that only parses its input files
17648 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17649 incorrect. IsTopLevel is not used to tell whether an object is
17650 root_types or not (that can be achieved by testing this ==
17651 root_types). But to see if this is a top-level *class* (not
17652 necessarly our "toplevel" container).
17654 2001-09-14 Ravi Pratap <ravi@ximian.com>
17656 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17657 parent instead of a direct call to GetType.
17659 2001-09-14 Ravi Pratap <ravi@ximian.com>
17661 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17662 Modifiers.TypeAttr. This should just be a call to that method.
17664 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17665 object so that we can determine if we are top-level or not.
17667 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17670 * enum.cs (Enum::Define): Ditto.
17672 * modifiers.cs (FieldAttr): Re-write.
17674 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17675 (TypeContainer::HaveStaticConstructor): New property to provide access
17676 to precisely that info.
17678 * modifiers.cs (MethodAttr): Re-write.
17679 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17681 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17682 of top-level types as claimed.
17684 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17686 * expression.cs (MemberLookup): Fruitless attempt to lookup
17687 constructors. Maybe I need to emit default constructors? That
17688 might be it (currently .NET emits this for me automatically).
17689 (Invocation::OverloadResolve): Cope with Arguments == null.
17690 (Invocation::EmitArguments): new function, shared by the new
17691 constructor and us.
17692 (Invocation::Emit): Handle static and instance methods. Emit
17693 proper call instruction for virtual or non-virtual invocations.
17694 (New::Emit): Implement.
17695 (New::Resolve): Implement.
17696 (MemberAccess:Resolve): Implement.
17697 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17698 to track instances.
17699 (FieldExpr::Resolve): Set type.
17701 * support.cs: Handle empty arguments.
17703 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17704 SimpleLookup): Auxiliary routines to help parse a qualifier
17707 Update qualifier_identifier rule.
17709 * codegen.cs: Removed debugging messages.
17711 * class.cs: Make this a global thing, this acts just as a "key" to
17712 objects that we might have around.
17714 (Populate): Only initialize method_builders_to_methods once.
17716 * expression.cs (PropertyExpr): Initialize type from the
17719 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17720 Resolve pattern. Attempt to implicitly convert value to boolean.
17723 * expression.cs: Set the type for the int32/int32 argument case.
17724 (Binary::ResolveOperator): Set the return type to boolean for
17725 comparission operators
17727 * typemanager.cs: Remove debugging print code.
17729 (Invocation::Resolve): resolve type.
17731 * class.cs: Allocate a MemberInfo of the correct size, as the code
17732 elsewhere depends on the test to reflect the correct contents.
17734 (Method::) Keep track of parameters, due to System.Reflection holes
17736 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17739 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17740 of the exact size and return that.
17742 (Class::LookupMethodByBuilder): New function that maps
17743 MethodBuilders to its methods. Required to locate the information
17744 on methods because System.Reflection bit us again.
17746 * support.cs: New file, contains an interface ParameterData and
17747 two implementations: ReflectionParameters and InternalParameters
17748 used to access Parameter information. We will need to grow this
17751 * expression.cs (Invocation::GetParameterData): implement a cache
17752 and a wrapper around the ParameterData creation for methods.
17753 (Invocation::OverloadResolve): Use new code.
17755 2001-09-13 Ravi Pratap <ravi@ximian.com>
17757 * class.cs (TypeContainer::EmitField): Remove and move into
17758 (Field::Define): here and modify accordingly.
17759 (Field.FieldBuilder): New member.
17760 (TypeContainer::Populate): Update accordingly.
17761 (TypeContainer::FindMembers): Implement.
17763 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17765 * statement.cs: (VariableInfo::VariableType): New field to be
17766 initialized with the full type once it is resolved.
17768 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17770 * parameter.cs (GetParameterInfo): Use a type cache to compute
17771 things only once, and to reuse this information
17773 * expression.cs (LocalVariableReference::Emit): Implement.
17774 (OpcodeCast::Emit): fix.
17776 (ParameterReference::Resolve): Implement.
17777 (ParameterReference::Emit): Implement.
17779 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17780 that are expressions need to stay as Expressions.
17782 * typemanager.cs (CSharpName): Returns the C# name of a type if
17785 * expression.cs (Expression::ConvertImplicit): New function that
17786 implements implicit type conversions.
17788 (Expression::ImplicitReferenceConversion): Implements implicit
17789 reference conversions.
17791 (EmptyCast): New type for transparent casts.
17793 (OpcodeCast): New type for casts of types that are performed with
17794 a sequence of bytecodes.
17796 (BoxedCast): New type used for casting value types into reference
17797 types. Emits a box opcode.
17799 (Binary::DoNumericPromotions): Implements numeric promotions of
17800 and computation of the Binary::Type.
17802 (Binary::EmitBranchable): Optimization.
17804 (Binary::Emit): Implement code emission for expressions.
17806 * typemanager.cs (TypeManager): Added two new core types: sbyte
17809 2001-09-12 Ravi Pratap <ravi@ximian.com>
17811 * class.cs (TypeContainer::FindMembers): Method which does exactly
17812 what Type.FindMembers does, only we don't have to use reflection. No
17813 implementation yet.
17815 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17816 typecontainer objects as we need to get at them.
17817 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17819 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17820 typecontainer object.
17822 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17823 of just a Report object.
17825 2001-09-11 Ravi Pratap <ravi@ximian.com>
17827 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17829 (TypeContainer::Populate): Now define the delegates of the type too.
17830 (TypeContainer.Delegates): Property to access the list of delegates defined
17833 * delegates.cs (Delegate::Define): Implement partially.
17835 * modifiers.cs (TypeAttr): Handle more flags.
17837 2001-09-11 Ravi Pratap <ravi@ximian.com>
17839 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17841 (Operator::Define): Re-write logic to get types by using the LookupType method
17842 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17843 (Indexer::Define): Ditto.
17844 (Event::Define): Ditto.
17845 (Property::Define): Ditto.
17847 2001-09-10 Ravi Pratap <ravi@ximian.com>
17849 * class.cs (TypeContainer::Populate): Now define operators too.
17850 (TypeContainer.Operators): New property to access the list of operators
17852 (Operator.OperatorMethodBuilder): New member to hold the method builder
17853 for the operator we are defining.
17854 (Operator::Define): Implement.
17856 2001-09-10 Ravi Pratap <ravi@ximian.com>
17858 * class.cs (Event::Define): Make the prefixes of the accessor methods
17859 addOn_ and removeOn_
17861 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17862 of the location being passed in too. Ideally, this should go later since all
17863 error reporting should be done through the Report object.
17865 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17866 (Populate): Iterate thru the indexers we have and define them too.
17867 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17868 for the get and set accessors.
17869 (Indexer::Define): Implement.
17871 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17873 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17874 my previous implementation, did not work.
17876 * typemanager.cs: Add a couple of missing types (the longs).
17878 * literal.cs: Use TypeManager.bool_type instead of getting it.
17880 * expression.cs (EventExpr): New kind of expressions.
17881 (Expressio::ExprClassFromMemberInfo): finish
17883 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17885 * assign.cs: Emit stores to static fields differently.
17887 2001-09-08 Ravi Pratap <ravi@ximian.com>
17889 * Merge in changes and adjust code to tackle conflicts. Backed out my
17890 code in Assign::Resolve ;-)
17892 2001-09-08 Ravi Pratap <ravi@ximian.com>
17894 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17895 instead Report.Error and also pass in the location.
17896 (CSharpParser::Lexer): New readonly property to return the reference
17897 to the Tokenizer object.
17898 (declare_local_variables): Use Report.Error with location instead of plain
17902 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17903 (Operator.CheckBinaryOperator): Ditto.
17905 * cs-parser.jay (operator_declarator): Update accordingly.
17907 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17908 (CheckBinaryOperator): Same here.
17910 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17911 on the name without any prefixes of namespace names etc. This is because we
17912 already might have something already fully qualified like
17913 'System.Console.WriteLine'
17915 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17917 2001-09-07 Ravi Pratap <ravi@ximian.com>
17919 * cs-tokenizer.cs (location): Return a string which also contains
17922 * expression.cs (ElementAccess): New class for expressions of the
17923 type 'element access.'
17924 (BaseAccess): New class for expressions of the type 'base access.'
17925 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17928 * cs-parser.jay (element_access): Implement action.
17929 (base_access): Implement actions.
17930 (checked_expression, unchecked_expression): Implement.
17932 * cs-parser.jay (local_variable_type): Correct and implement.
17933 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17935 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17937 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17938 name and the specifiers.
17940 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17942 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17943 making them all public ;-)
17945 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17948 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17950 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17952 (FieldExpr, PropertyExprs): New resolved expressions.
17953 (SimpleName::MemberStaticCheck): Perform static checks for access
17954 to non-static fields on static methods. Maybe this should be
17955 generalized for MemberAccesses.
17956 (SimpleName::ResolveSimpleName): More work on simple name
17959 * cs-parser.jay (primary_expression/qualified_identifier): track
17960 the parameter index.
17962 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17963 (EmitContext::EmitBoolExpression): Chain to expression generation
17964 instead of temporary hack.
17965 (::EmitStatementExpression): Put generic expression code generation.
17967 * assign.cs (Assign::Emit): Implement variable assignments to
17968 local variables, parameters and fields.
17970 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17972 * statement.cs (Block::GetVariableInfo): New method, returns the
17973 VariableInfo for a variable name in a block.
17974 (Block::GetVariableType): Implement in terms of GetVariableInfo
17976 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17977 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17979 2001-09-06 Ravi Pratap <ravi@ximian.com>
17981 * cs-parser.jay (operator_declaration): Continue on my quest : update
17982 to take attributes argument.
17983 (event_declaration): Ditto.
17984 (enum_declaration): Ditto.
17985 (indexer_declaration): Ditto.
17987 * class.cs (Operator::Operator): Update constructor accordingly.
17988 (Event::Event): Ditto.
17990 * delegate.cs (Delegate::Delegate): Same here.
17992 * enum.cs (Enum::Enum): Same here.
17994 2001-09-05 Ravi Pratap <ravi@ximian.com>
17996 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17998 * ../tests/cs0658.cs : New file to demonstrate error 0658.
18000 * attribute.cs (Attributes): New class to encapsulate all attributes which were
18001 being passed around as an arraylist.
18002 (Attributes::AddAttribute): Method to add attribute sections.
18004 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
18005 (struct_declaration): Update accordingly.
18006 (constant_declaration): Update.
18007 (field_declaration): Update.
18008 (method_header): Update.
18009 (fixed_parameter): Update.
18010 (parameter_array): Ditto.
18011 (property_declaration): Ditto.
18012 (destructor_declaration): Ditto.
18014 * class.cs (Struct::Struct): Update constructors accordingly.
18015 (Class::Class): Ditto.
18016 (Field::Field): Ditto.
18017 (Method::Method): Ditto.
18018 (Property::Property): Ditto.
18019 (TypeContainer::OptAttribute): update property's return type.
18021 * interface.cs (Interface.opt_attributes): New member.
18022 (Interface::Interface): Update to take the extra Attributes argument.
18024 * parameter.cs (Parameter::Parameter): Ditto.
18026 * constant.cs (Constant::Constant): Ditto.
18028 * interface.cs (InterfaceMemberBase): New OptAttributes field.
18029 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
18030 the attributes as a parameter.
18031 (InterfaceProperty): Update constructor call.
18032 (InterfaceEvent): Ditto.
18033 (InterfaceMethod): Ditto.
18034 (InterfaceIndexer): Ditto.
18036 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
18037 pass the attributes too.
18038 (interface_event_declaration): Ditto.
18039 (interface_property_declaration): Ditto.
18040 (interface_method_declaration): Ditto.
18041 (interface_declaration): Ditto.
18043 2001-09-05 Miguel de Icaza <miguel@ximian.com>
18045 * class.cs (Method::Define): Track the "static Main" definition to
18046 create an entry point.
18048 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
18049 EntryPoint if we find it.
18051 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
18052 (EmitContext::ig): Make this variable public.
18054 * driver.cs: Make the default output file be the first file name
18055 with the .exe extension.
18057 Detect empty compilations
18059 Handle various kinds of output targets. Handle --target and
18060 rename -t to --dumper.
18062 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
18063 methods inherited from Expression return now an Expression. This
18064 will is used during the tree rewriting as we resolve them during
18067 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
18068 the spec. Missing entirely is the information about
18069 accessability of elements of it.
18071 (Expression::ExprClassFromMemberInfo): New constructor for
18072 Expressions that creates a fully initialized Expression based on
18073 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
18076 (Invocation::Resolve): Begin implementing resolution of invocations.
18078 * literal.cs (StringLiteral): Implement Emit.
18080 2001-09-05 Ravi Pratap <ravi@ximian.com>
18082 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
18085 2001-09-04 Ravi Pratap <ravi@ximian.com>
18087 * cs-parser.jay (attribute_arguments): Implement actions.
18088 (attribute): Fix bug in production. Implement action.
18089 (attribute_list): Implement.
18090 (attribute_target): Implement.
18091 (attribute_target_specifier, opt_target_specifier): Implement
18092 (CheckAttributeTarget): New method to check if the attribute target
18094 (attribute_section): Implement.
18095 (opt_attributes): Implement.
18097 * attribute.cs : New file to handle attributes.
18098 (Attribute): Class to hold attribute info.
18100 * cs-parser.jay (opt_attribute_target_specifier): Remove production
18101 (attribute_section): Modify production to use 2 different rules to
18102 achieve the same thing. 1 s/r conflict down !
18103 Clean out commented, useless, non-reducing dimension_separator rules.
18105 * class.cs (TypeContainer.attributes): New member to hold list
18106 of attributes for a type.
18107 (Struct::Struct): Modify to take one more argument, the attribute list.
18108 (Class::Class): Ditto.
18109 (Field::Field): Ditto.
18110 (Method::Method): Ditto.
18111 (Property::Property): Ditto.
18113 * cs-parser.jay (struct_declaration): Update constructor call to
18114 pass in the attributes too.
18115 (class_declaration): Ditto.
18116 (constant_declaration): Ditto.
18117 (field_declaration): Ditto.
18118 (method_header): Ditto.
18119 (fixed_parameter): Ditto.
18120 (parameter_array): Ditto.
18121 (property_declaration): Ditto.
18123 * constant.cs (Constant::Constant): Update constructor similarly.
18124 Use System.Collections.
18126 * parameter.cs (Parameter::Parameter): Update as above.
18128 2001-09-02 Ravi Pratap <ravi@ximian.com>
18130 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
18131 (TypeContainer.delegates): New member to hold list of delegates.
18133 * cs-parser.jay (delegate_declaration): Implement the action correctly
18134 this time as I seem to be on crack ;-)
18136 2001-09-02 Miguel de Icaza <miguel@ximian.com>
18138 * rootcontext.cs (RootContext::IsNamespace): new function, used to
18139 tell whether an identifier represents a namespace.
18141 * expression.cs (NamespaceExpr): A namespace expression, used only
18142 temporarly during expression resolution.
18143 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
18144 utility functions to resolve names on expressions.
18146 2001-09-01 Miguel de Icaza <miguel@ximian.com>
18148 * codegen.cs: Add hook for StatementExpressions.
18150 * class.cs: Fix inverted test for static flag in methods.
18152 2001-09-02 Ravi Pratap <ravi@ximian.com>
18154 * class.cs (Operator::CheckUnaryOperator): Correct error number used
18155 to make it coincide with MS' number.
18156 (Operator::CheckBinaryOperator): Ditto.
18158 * ../errors/errors.txt : Remove error numbers added earlier.
18160 * ../errors/cs1019.cs : Test case for error # 1019
18162 * ../errros/cs1020.cs : Test case for error # 1020
18164 * cs-parser.jay : Clean out commented cruft.
18165 (dimension_separators, dimension_separator): Comment out. Ostensibly not
18166 used anywhere - non-reducing rule.
18167 (namespace_declarations): Non-reducing rule - comment out.
18169 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
18170 with TypeContainer::AddEnum.
18172 * delegate.cs : New file for delegate handling classes.
18173 (Delegate): Class for declaring delegates.
18175 * makefile : Update.
18177 * cs-parser.jay (delegate_declaration): Implement.
18179 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
18181 * class.cs (Event::Define): Implement.
18182 (Event.EventBuilder): New member.
18184 * class.cs (TypeContainer::Populate): Update to define all enums and events
18186 (Events): New property for the events arraylist we hold. Shouldn't we move to using
18187 readonly fields for all these cases ?
18189 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18191 * class.cs (Property): Revamp to use the convention of making fields readonly.
18192 Accordingly modify code elsewhere.
18194 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
18195 the Define method of the Property class.
18197 * class.cs : Clean up applied patch and update references to variables etc. Fix
18199 (TypeContainer::Populate): Update to define all the properties we have. Also
18200 define all enumerations.
18202 * enum.cs (Define): Implement.
18204 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18206 * cs-parser.jay (overloadable_operator): The semantic value is an
18207 enum of the Operator class.
18208 (operator_declarator): Implement actions.
18209 (operator_declaration): Implement.
18211 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
18212 validity of definitions.
18213 (Operator::CheckBinaryOperator): Static method to check for binary operators
18214 (TypeContainer::AddOperator): New method to add an operator to a type.
18216 * cs-parser.jay (indexer_declaration): Added line to actually call the
18217 AddIndexer method so it gets added ;-)
18219 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
18220 already taken care of by the MS compiler ?
18222 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18224 * class.cs (Operator): New class for operator declarations.
18225 (Operator::OpType): Enum for the various operators.
18227 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18229 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
18230 ostensibly handle this in semantic analysis.
18232 * cs-parser.jay (general_catch_clause): Comment out
18233 (specific_catch_clauses, specific_catch_clause): Ditto.
18234 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
18235 (catch_args, opt_catch_args): New productions.
18236 (catch_clause): Rewrite to use the new productions above
18237 (catch_clauses): Modify accordingly.
18238 (opt_catch_clauses): New production to use in try_statement
18239 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
18240 and re-write the code in the actions to extract the specific and
18241 general catch clauses by being a little smart ;-)
18243 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
18244 Hooray, try and catch statements parse fine !
18246 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18248 * statement.cs (Block::GetVariableType): Fix logic to extract the type
18249 string from the hashtable of variables.
18251 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
18252 I end up making that mistake ;-)
18253 (catch_clauses): Fixed gross error which made Key and Value of the
18254 DictionaryEntry the same : $1 !!
18256 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18258 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
18260 * cs-parser.jay (event_declaration): Correct to remove the semicolon
18261 when the add and remove accessors are specified.
18263 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18265 * cs-parser.jay (IndexerDeclaration): New helper class to hold
18266 information about indexer_declarator.
18267 (indexer_declarator): Implement actions.
18268 (parsing_indexer): New local boolean used to keep track of whether
18269 we are parsing indexers or properties. This is necessary because
18270 implicit_parameters come into picture even for the get accessor in the
18271 case of an indexer.
18272 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
18274 * class.cs (Indexer): New class for indexer declarations.
18275 (TypeContainer::AddIndexer): New method to add an indexer to a type.
18276 (TypeContainer::indexers): New member to hold list of indexers for the
18279 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18281 * cs-parser.jay (add_accessor_declaration): Implement action.
18282 (remove_accessor_declaration): Implement action.
18283 (event_accessors_declaration): Implement
18284 (variable_declarators): swap statements for first rule - trivial.
18286 * class.cs (Event): New class to hold information about event
18288 (TypeContainer::AddEvent): New method to add an event to a type
18289 (TypeContainer::events): New member to hold list of events.
18291 * cs-parser.jay (event_declaration): Implement actions.
18293 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18295 * cs-parser.jay (dim_separators): Implement. Make it a string
18296 concatenating all the commas together, just as they appear.
18297 (opt_dim_separators): Modify accordingly
18298 (rank_specifiers): Update accordingly. Basically do the same
18299 thing - instead, collect the brackets here.
18300 (opt_rank_sepcifiers): Modify accordingly.
18301 (array_type): Modify to actually return the complete type string
18302 instead of ignoring the rank_specifiers.
18303 (expression_list): Implement to collect the expressions
18304 (variable_initializer): Implement. We make it a list of expressions
18305 essentially so that we can handle the array_initializer case neatly too.
18306 (variable_initializer_list): Implement.
18307 (array_initializer): Make it a list of variable_initializers
18308 (opt_array_initializer): Modify accordingly.
18310 * expression.cs (New::NType): Add enumeration to help us
18311 keep track of whether we have an object/delegate creation
18312 or an array creation.
18313 (New:NewType, New::Rank, New::Indices, New::Initializers): New
18314 members to hold data about array creation.
18315 (New:New): Modify to update NewType
18316 (New:New): New Overloaded contructor for the array creation
18319 * cs-parser.jay (array_creation_expression): Implement to call
18320 the overloaded New constructor.
18322 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
18324 * class.cs (TypeContainer::Constructors): Return member
18325 constructors instead of returning null.
18327 2001-08-26 Miguel de Icaza <miguel@ximian.com>
18329 * typemanager.cs (InitCoreTypes): Initialize the various core
18330 types after we have populated the type manager with the user
18331 defined types (this distinction will be important later while
18332 compiling corlib.dll)
18334 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
18335 on Expression Classification. Now all expressions have a method
18336 `Resolve' and a method `Emit'.
18338 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
18339 generation from working. Also add some temporary debugging
18342 2001-08-24 Miguel de Icaza <miguel@ximian.com>
18344 * codegen.cs: Lots of code generation pieces. This is only the
18345 beginning, will continue tomorrow with more touches of polish. We
18346 handle the fundamentals of if, while, do, for, return. Others are
18347 trickier and I need to start working on invocations soon.
18349 * gen-treedump.cs: Bug fix, use s.Increment here instead of
18352 * codegen.cs (EmitContext): New struct, used during code
18353 emission to keep a context. Most of the code generation will be
18356 * cs-parser.jay: Add embedded blocks to the list of statements of
18357 this block. So code generation proceeds in a top down fashion.
18359 2001-08-23 Miguel de Icaza <miguel@ximian.com>
18361 * statement.cs: Add support for multiple child blocks.
18363 2001-08-22 Miguel de Icaza <miguel@ximian.com>
18365 * codegen.cs (EmitCode): New function, will emit the code for a
18366 Block of code given a TypeContainer and its ILGenerator.
18368 * statement.cs (Block): Standard public readonly optimization.
18369 (Block::Block constructors): Link children.
18370 (Block::Child): Child Linker.
18371 (Block::EmitVariables): Emits IL variable declarations.
18373 * class.cs: Drop support for MethodGroups here, delay until
18375 (Method::): Applied the same simplification that I did before, and
18376 move from Properties to public readonly fields.
18377 (Method::ParameterTypes): Returns the parameter types for the
18378 function, and implements a cache that will be useful later when I
18379 do error checking and the semantic analysis on the methods is
18381 (Constructor::GetCallingConvention): Renamed from CallingConvetion
18382 and made a method, optional argument tells whether this is a class
18383 or a structure to apply the `has-this' bit.
18384 (Method::GetCallingConvention): Implement, returns the calling
18386 (Method::Define): Defines the type, a second pass is performed
18387 later to populate the methods.
18389 (Constructor::ParameterTypes): implement a cache similar to the
18390 one on Method::ParameterTypes, useful later when we do semantic
18393 (TypeContainer::EmitMethod): New method. Emits methods.
18395 * expression.cs: Removed MethodGroup class from here.
18397 * parameter.cs (Parameters::GetCallingConvention): new method.
18399 2001-08-21 Miguel de Icaza <miguel@ximian.com>
18401 * class.cs (TypeContainer::Populate): Drop RootContext from the
18404 (Constructor::CallingConvention): Returns the calling convention.
18405 (Constructor::ParameterTypes): Returns the constructor parameter
18408 (TypeContainer::AddConstructor): Keep track of default constructor
18409 and the default static constructor.
18411 (Constructor::) Another class that starts using `public readonly'
18412 instead of properties.
18414 (Constructor::IsDefault): Whether this is a default constructor.
18416 (Field::) use readonly public fields instead of properties also.
18418 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
18419 track of static constructors; If none is used, turn on
18420 BeforeFieldInit in the TypeAttributes.
18422 * cs-parser.jay (opt_argument_list): now the return can be null
18423 for the cases where there are no arguments.
18425 (constructor_declarator): If there is no implicit `base' or
18426 `this', then invoke the default parent constructor.
18428 * modifiers.cs (MethodAttr): New static function maps a set of
18429 modifiers flags into a MethodAttributes enum
18430 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
18431 MethodAttr, TypeAttr to represent the various mappings where the
18432 modifiers are used.
18433 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
18435 2001-08-19 Miguel de Icaza <miguel@ximian.com>
18437 * parameter.cs (GetParameterInfo): Fix bug where there would be no
18440 * interface.cs (PopulateIndexer): Implemented the code generator
18441 for interface indexers.
18443 2001-08-17 Miguel de Icaza <miguel@ximian.com>
18445 * interface.cs (InterfaceMemberBase): Now we track the new status
18448 (PopulateProperty): Implement property population. Woohoo! Got
18449 Methods and Properties going today.
18451 Removed all the properties for interfaces, and replaced them with
18452 `public readonly' fields.
18454 2001-08-16 Miguel de Icaza <miguel@ximian.com>
18456 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
18457 initialize their hashtables/arraylists only when they are needed
18458 instead of doing this always.
18460 * parameter.cs: Handle refs and out parameters.
18462 * cs-parser.jay: Use an ArrayList to construct the arguments
18463 instead of the ParameterCollection, and then cast that to a
18466 * parameter.cs: Drop the use of ParameterCollection and use
18467 instead arrays of Parameters.
18469 (GetParameterInfo): Use the Type, not the Name when resolving
18472 2001-08-13 Miguel de Icaza <miguel@ximian.com>
18474 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
18475 and instead use public readonly fields.
18477 * class.cs: Put back walking code for type containers.
18479 2001-08-11 Miguel de Icaza <miguel@ximian.com>
18481 * class.cs (MakeConstant): Code to define constants.
18483 * rootcontext.cs (LookupType): New function. Used to locate types
18486 2001-08-08 Miguel de Icaza <miguel@ximian.com>
18488 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
18489 this System.Reflection code is. Kudos to Microsoft
18491 * typemanager.cs: Implement a type cache and avoid loading all
18492 types at boot time. Wrap in LookupType the internals. This made
18493 the compiler so much faster. Wow. I rule!
18495 * driver.cs: Make sure we always load mscorlib first (for
18496 debugging purposes, nothing really important).
18498 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18499 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18501 * rootcontext.cs: Lookup types on their namespace; Lookup types
18502 on namespaces that have been imported using the `using' keyword.
18504 * class.cs (TypeContainer::TypeAttr): Virtualize.
18505 (Class::TypeAttr): Return attributes suitable for this bad boy.
18506 (Struct::TypeAttr): ditto.
18507 Handle nested classes.
18508 (TypeContainer::) Remove all the type visiting code, it is now
18509 replaced with the rootcontext.cs code
18511 * rootcontext.cs (GetClassBases): Added support for structs.
18513 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18515 * interface.cs, statement.cs, class.cs, parameter.cs,
18516 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18517 Drop use of TypeRefs, and use strings instead.
18519 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18523 * class.cs (Struct::Struct): set the SEALED flags after
18524 checking the modifiers.
18525 (TypeContainer::TypeAttr): new property, returns the
18526 TypeAttributes for a class.
18528 * cs-parser.jay (type_list): Oops, list production was creating a
18529 new list of base types.
18531 * rootcontext.cs (StdLib): New property.
18532 (GetInterfaceTypeByName): returns an interface by type name, and
18533 encapsulates error handling here.
18534 (GetInterfaces): simplified.
18535 (ResolveTree): Encapsulated all the tree resolution here.
18536 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18539 * driver.cs: Add support for --nostdlib, to avoid loading the
18540 default assemblies.
18541 (Main): Do not put tree resolution here.
18543 * rootcontext.cs: Beginning of the class resolution.
18545 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18547 * rootcontext.cs: Provide better error reporting.
18549 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18551 * rootcontext.cs (CreateInterface): Handle the case where there
18552 are no parent interfaces.
18554 (CloseTypes): Routine to flush types at the end.
18555 (CreateInterface): Track types.
18556 (GetInterfaces): Returns an array of Types from the list of
18557 defined interfaces.
18559 * typemanager.c (AddUserType): Mechanism to track user types (puts
18560 the type on the global type hash, and allows us to close it at the
18563 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18565 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18566 RecordInterface instead.
18568 * cs-parser.jay: Updated to reflect changes above.
18570 * decl.cs (Definition): Keep track of the TypeBuilder type that
18571 represents this type here. Not sure we will use it in the long
18572 run, but wont hurt for now.
18574 * driver.cs: Smaller changes to accomodate the new code.
18576 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18579 * rootcontext.cs (CreateInterface): New method, used to create
18580 the System.TypeBuilder type for interfaces.
18581 (ResolveInterfaces): new entry point to resolve the interface
18583 (CodeGen): Property, used to keep track of the code generator.
18585 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18587 * cs-parser.jay: Add a second production for delegate_declaration
18590 (enum_body): Put an opt_comma here instead of putting it on
18591 enum_body or enum_member_declarations so we can handle trailing
18592 commas on enumeration members. Gets rid of a shift/reduce.
18594 (type_list): Need a COMMA in the middle.
18596 (indexer_declaration): Tell tokenizer to recognize get/set
18598 * Remove old targets.
18600 * Re-add the parser target.
18602 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18604 * cs-parser.jay: Add precendence rules for a number of operators
18605 ot reduce the number of shift/reduce conflicts in the grammar.
18607 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18609 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18612 Get rid of old crufty code.
18614 * rootcontext.cs: Use this to keep track of the parsed
18615 representation and the defined types available to the program.
18617 * gen-treedump.cs: adjust for new convention.
18619 * type.cs: Split out the type manager, and the assembly builder
18622 * typemanager.cs: the type manager will live here now.
18624 * cil-codegen.cs: And the code generator here.
18626 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18628 * makefile: Fixed up for easy making.
18630 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18632 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18635 (unary_expression): Expand pre_increment_expression and
18636 post_decrement_expression to reduce a shift/reduce.
18638 2001-07-11 Simon Cozens
18640 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18642 Improve allow_keyword_as_indent name.
18644 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18646 * Adjustments for Beta2.
18648 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18650 * decl.cs: Added `Define' abstract method.
18651 (InTransit): new property, used to catch recursive definitions.
18653 * interface.cs: Implement `Define'.
18655 * modifiers.cs: Map Modifiers.constants to
18656 System.Reflection.TypeAttribute flags.
18658 * class.cs: Keep track of types and user-defined types.
18659 (BuilderInit): New method for creating an assembly
18660 (ResolveType): New function to launch the resolution process, only
18661 used by interfaces for now.
18663 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18664 that are inserted into the name space.
18666 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18668 * ARGH. I have screwed up my tree so many times due to the use of
18669 rsync rather than using CVS. Going to fix this at once.
18671 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18674 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18676 * Experiment successful: Use System.Type rather that our own
18679 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18681 * cs-parser.jay: Removed nsAliases from here.
18683 Use new namespaces, handle `using XXX;'
18685 * namespace.cs: Reimplemented namespace handling, use a recursive
18686 definition of the class. Now we can keep track of using clauses
18687 and catch invalid using clauses.
18689 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18691 * gen-treedump.cs: Adapted for all the renaming.
18693 * expression.cs (Expression): this class now has a Type property
18694 which returns an expression Type.
18696 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18697 `Type', as this has a different meaning now in the base
18699 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18701 * interface.cs, class.cs: Removed from all the sources the
18702 references to signature computation, as we can not do method
18703 signature computation during the parsing time, as we are not
18704 trying to solve at that point distinguishing:
18708 void a (NS.Blah x) {}
18711 Which depending on the context might be valid or not, as we do not
18712 know if Blah is the same thing as NS.Blah at that point.
18714 * Redid everything so the code uses TypeRefs now instead of
18715 Types. TypeRefs are just temporary type placeholders, that need
18716 to be resolved. They initially have a pointer to a string and the
18717 current scope in which they are used. This is used later by the
18718 compiler to resolve the reference to an actual Type.
18720 * DeclSpace is no longer a CIR.Type, and neither are
18721 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18722 are all DeclSpaces, but no Types.
18724 * type.cs (TypeRefManager): This implements the TypeRef manager,
18725 which keeps track of all the types that need to be resolved after
18726 the parsing has finished.
18728 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18730 * ARGH. We are going to have to store `foreach' as a class rather
18731 than resolving it, as we need to verify error 1579 after name
18732 resolution. *OR* we could keep a flag that says `This request to
18733 IEnumerator comes from a foreach statement' which we can then use
18734 to generate the error.
18736 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18738 * class.cs (TypeContainer.AddMethod): we now add methods to the
18739 MethodGroup instead of the method hashtable.
18741 * expression.cs: Add MethodGroup abstraction, which gets us one
18742 step closer to the specification in the way we handle method
18745 * cs-parser.jay (primary_expression): qualified_identifier now
18746 tried to match up an identifier to a local variable reference or
18747 to a parameter reference.
18749 current_local_parameters is now a parser global variable that
18750 points to the current parameters for the block, used during name
18753 (property_declaration): Now creates an implicit `value' argument to
18756 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18758 * parameter.cs: Do not use `param' arguments as part of the
18759 signature, per the spec.
18761 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18763 * decl.cs: Base class for classes, structs and interfaces. This
18764 is the "Declaration Space"
18766 * cs-parser.jay: Use CheckDef for checking declaration errors
18767 instead of having one on each function.
18769 * class.cs: Factor out some code for handling error handling in
18770 accordance to the "Declarations" section in the "Basic Concepts"
18771 chapter in the ECMA C# spec.
18773 * interface.cs: Make all interface member classes derive from
18774 InterfaceMemberBase.
18776 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18778 * Many things: all interfaces are parsed and generated in
18779 gen-treedump. Support for member variables, constructors,
18780 destructors, properties, constants is there.
18782 Beginning of the IL backend, but very little done, just there for
18785 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18787 * cs-parser.jay: Fix labeled statement.
18789 * cs-tokenizer.cs (escape): Escape " and ' always.
18790 ref_line, ref_name: keep track of the line/filename as instructed
18791 by #line by the compiler.
18794 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18796 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18797 to match the values in System.CodeDOM.
18799 Divid renamed to Divide.
18801 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18803 (Statements.set): remove.
18805 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18808 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18809 falseStatements always have valid values.
18811 * cs-parser.jay: Use System.CodeDOM now.