1 2007-04-08 Marek Safar <marek.safar@gmail.com>
3 * cs-parser.jay, linq.cs: First select implementation (hacky).
5 * generic.cs (InferTypeArguments): Simplified.
7 2007-03-31 Marek Safar <marek.safar@gmail.com>
9 * generic.cs (InferTypeArguments): Restored validation check.
10 (InferTypeArguments): Move all logic to Compatible method for re-usability.
12 2007-03-25 Marek Safar <marek.safar@gmail.com>
14 * generic.cs (InferTypeArguments): Infer arguments before they are used
15 for compatibility check.
17 2007-03-15 Marek Safar <marek.safar@gmail.com>
19 * generic.cs (InflatedConstraints): Fixed the check order.
20 (TypeArguments.Resolve): Small optimization for generic parameters.
21 (InferTypeArguments): Add infering support for anonymous methods.
23 2007-03-15 Martin Baulig <martin@ximian.com>
28 (TypeParameter.HasConstructorConstraint): Removed.
29 (ConstraintChecker.HasDefaultConstructor): Removed the
30 `TypeBuilder' argument here; correctly check for the ctor
31 constraint on type parameters.
33 2007-03-15 Martin Baulig <martin@ximian.com>
38 (TypeParameter): Create a `MemberCache' here as well. Note that
39 we need to create this on-demand when it's actually used.
41 2007-03-10 Marek Safar <marek.safar@gmail.com>
43 * generic.cs (TypeArguments.Resolve): Avoid redundant checks.
45 2007-03-09 Raja R Harinath <rharinath@novell.com>
47 * cs-parser.jay (WHERE): Move before QUERY_FIRST_TOKEN. 'where'
48 is a valid keyword outside a linq expression too.
50 2007-03-03 Marek Safar <marek.safar@gmail.com>
52 * cs-parser.jay: Implemented basic linq grammar.
54 * linq.cs: New file for hosting query specific classes.
56 2007-02-26 Marek Safar <marek.safar@gmail.com>
58 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
60 2007-02-20 Marek Safar <marek.safar@gmail.com>
63 * cs-parser.jay: Anonymous container starts at constructor declaration
64 and not at block beginning because it has to be usable in constructor
67 2007-02-18 Marek Safar <marek.safar@gmail.com>
69 A fix for bug #80493 by Atsushi Enomoto
70 * cs-parser.jay: Ignore invalid attribute target.
72 2007-02-15 Miguel de Icaza <miguel@novell.com>
74 * Remove the call to SetExpression for lambda expressions, we do
77 Remove expression tracking code as its not needed.
79 2007-02-11 Miguel de Icaza <miguel@novell.com>
81 * cs-parser.jay (lambda_expression_body): when the body is an
82 expression add a statement of the form:
84 contextual-return expression.
86 Where `contextual-return' is similar to `return', the difference
87 being that if the delegate that the lambda will be converted to
88 has a void return type, it will check that the result is a
89 ExpressionStatement and the result is a plain ret (no return
90 values on the stack). If the return type of the delegate is of a
91 given type, this turns into a return with a value and does the
92 regular checking to check that the computed value can be
93 implicitly converted to the delegate return.
95 2007-01-30 Miguel de Icaza <miguel@novell.com>
97 * cs-parser.jay (anonymous_method_expression): move the
98 before/after productions to the start_anonymous and end_anonymous
99 methods so the code can be reused for lambda functions.
101 (lambda_expression_body): wrap expressions implicitly into a
104 (block): factor out the setup/teardown of parsing a block so we
105 can reuse that in lambda_expression_body
107 (lambda_expression): use new anonymous method helper methods.
109 2007-01-29 Miguel de Icaza <miguel@novell.com>
111 * cs-parser.jay: oob_stack make it static (am guessing that is why
112 we no longer initialize it anymore) and reuse it across
115 2007-01-28 Miguel de Icaza <miguel@novell.com>
117 * cs-parser.jay (open_parens): Introduce new non-terminal that
118 abstracts OPEN_PARENS and OPEN_PARENS_LAMBDA as the later can now
119 be returned in places where types are followed by identifiers
120 (this is expected in declaration, fixed, using, foreach and catch
123 Use open_parens in those places, keep OPEN_PARENS in the
126 cs-parser.jay: New grammar bits for parsing lambda expressions.
128 2007-01-28 Raja R Harinath <rharinath@novell.com>
130 Fix #80534, gtest-309.cs
131 * generic.cs (UnifyType): Rename from InferType. Make unification
132 of generic insts simpler and don't insist on inferring all generic
133 parameters in a single generic inst unification.
135 (InferGenericInstance): Remove.
136 Analysis and initial patch by David Mitchell <dmitchell@logos.com>.
138 2007-01-20 Marek Safar <marek.safar@gmail.com>
140 * cs-parser.jay: Better parameter error handling.
142 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
143 Raja R Harinath <rharinath@novell.com>
145 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
146 Note the order in which accessors are declared in the source.
148 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
150 * generic.cs (TypeParameter.FindMembers): Use the generic
151 constraints, not the constraints to check for methods (first fix
154 2006-12-30 Marek Safar <marek.safar@gmail.com>
156 * cs-parser.jay: Better syntax errors handling.
158 2006-11-21 Marek Safar <marek.safar@gmail.com>
160 * cs-parser.jay: Tiny change to work with mcs tokenizer.
162 * cs-tokenizer.cs: Remove after unification with mcs.
164 2006-10-28 Marek Safar <marek.safar@gmail.com>
167 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
170 2006-10-26 Marek Safar <marek.safar@gmail.com>
173 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
175 2006-10-25 Brian Crowell <brian@fluggo.com>
178 * generic.cs (CheckConstraints): Allow generic parameters with
179 inheritance constraints to satisfy reference type constraints.
181 2006-10-09 Martin Baulig <martin@ximian.com>
184 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
186 2006-09-25 Martin Baulig <martin@ximian.com>
188 * class.cs: Remove after unification with mcs source.
190 2006-09-24 Raja R Harinath <harinath@gmail.com>
192 * convert.cs: Remove after unification with mcs source.
194 2006-09-24 Marek Safar <marek.safar@seznam.cz>
196 * class.cs (MemberBase.VerifyClsCompliance): When method has type
197 parameters verify them as well.
199 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
200 the type parameter constraints.
201 (Generics.VerifyClsCompliance): Ditto.
203 2006-09-24 Marek Safar <marek.safar@seznam.cz>
205 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
206 for anonymous block with out argument.
208 2006-09-24 Marek Safar <marek.safar@seznam.cz>
210 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
211 not used private events only.
213 2006-09-23 Marek Safar <marek.safar@seznam.cz>
215 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
217 * cs-parser.jay: Parse correctly cast of default (T).
219 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
220 Store original type via EmptyConstantCast.
222 2006-09-22 Martin Baulig <martin@ximian.com>
224 * delegate.cs: Removed; this file is now shared with mcs.
226 * attribute.cs: Removed; this file is now shared with mcs.
228 2006-09-22 Martin Baulig <martin@ximian.com>
230 * ecore.cs: Removed; this file is now shared with mcs.
232 2006-09-21 Marek Safar <marek.safar@seznam.cz>
234 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
236 * ecore.cs (NullCast): Derives from NullConstant.
238 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
241 2006-09-21 Martin Baulig <martin@ximian.com>
243 * decl.cs: Removed; this file is now shared with mcs.
245 2006-09-21 Raja R Harinath <rharinath@novell.com>
247 * rootcontext.cs: Remove after unification with mcs source.
249 * report.cs: Remove after unification with mcs source.
250 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
252 (InitGenerics, CleanUpGenerics): Remove.
254 * support.cs: Remove after unification with mcs source.
256 2006-09-20 Raja R Harinath <rharinath@novell.com>
258 * codegen.cs: Remove after unification with mcs source.
260 2006-09-19 Martin Baulig <martin@ximian.com>
262 * expression.cs: Removed; this file is now shared with mcs.
264 2006-09-19 Martin Baulig <martin@ximian.com>
267 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
268 (TypeManager.DropGenericTypeArguments): Likewise.
269 (TypeManager.DropGenericMethodArguments): Likewise.
270 (TypeManager.GetTypeArguments): Likewise.
271 (TypeManager.HasGenericArguments): Likewise.
273 2006-09-19 Martin Baulig <martin@ximian.com>
275 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
277 2006-09-19 Martin Baulig <martin@ximian.com>
279 * typemanager.cs: Removed; this file is now shared with mcs.
281 2006-09-16 Raja R Harinath <rharinath@novell.com>
283 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
284 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
286 2006-09-16 Marek Safar <marek.safar@seznam.cz>
289 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
290 only if parent type is class.
291 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
294 2006-09-15 Marek Safar <marek.safar@seznam.cz>
297 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
299 * typemanager.cs(CSharpName): Converts NullType to null.
301 2006-09-15 Martin Baulig <martin@ximian.com>
303 * pending.cs: Removed; this file is now shared with mcs.
305 2006-09-15 Martin Baulig <martin@ximian.com>
307 * statement.cs: Removed; this file is now shared with mcs.
309 2006-09-15 Martin Baulig <martin@ximian.com>
311 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
313 * driver.cs: Removed the `--broken-cycles' argument.
315 2006-09-15 Martin Baulig <martin@ximian.com>
317 * namespace.cs: Removed; this file is now shared with mcs.
319 2006-09-15 Martin Baulig <martin@ximian.com>
321 * decl.cs (MemberName): Minor code cleanups.
323 2006-09-15 Martin Baulig <martin@ximian.com>
325 * parameter.cs: Removed; this file is now shared with mcs.
327 2006-09-15 Martin Baulig <martin@ximian.com>
329 * enum.cs: Removed; this file is now shared with mcs.
331 2006-09-15 Martin Baulig <martin@ximian.com>
333 * Makefile: Define `GMCS_SOURCE'.
335 * flowanalysis.cs: Removed; this file is now shared with mcs.
337 2006-09-15 Martin Baulig <martin@ximian.com>
339 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
340 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
341 doc.cs - they are now shared with mcs.
343 * gmcs.exe.sources: Include these files from ../mcs/.
345 2006-09-15 Martin Baulig <martin@ximian.com>
347 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
348 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
350 2006-09-14 Marek Safar <marek.safar@seznam.cz>
352 * assign.cs, ecore.cs, expression.cs: Share error message text.
353 * class.cs (FieldMember.Define): Check for variable of static type.
354 * decl.cs (check_type_parameter): Report correct type name.
355 * driver.cs (LoadAssembly): Uses error output for errors.
356 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
357 (TypeArguments.Resolve): Static class cannot be used as an argument.
358 * statement.cs (ResolveMeta): Constants cannot be generic types.
360 2006-09-12 Martin Baulig <martin@ximian.com>
362 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
364 * convert.cs (Convert.Array_To_IList): Moved here and correctly
365 implement it; fixes #79345.
367 2006-09-08 Marek Safar <marek.safar@seznam.cz>
369 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
371 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
373 * generic.cs: Improved error messages.
374 * typemanager.cs (RemoveGenericArity): Made public.
376 2006-09-08 Martin Baulig <martin@ximian.com>
378 * typemanager.cs (TypeManager.interlocked_type): New public field.
379 (TypeManager.int_interlocked_compare-exchange): New public field.
380 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
381 enumerator types here and call InitGenericCoreTypes().
382 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
383 after calling InitEnumUnderlyingTypes().
386 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
387 `classes_second_stage'.
389 2006-09-07 Marek Safar <marek.safar@seznam.cz>
391 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
393 * statement.cs (Block.Variables): Made public.
395 2006-09-07 Martin Baulig <martin@ximian.com>
398 (MainDriver): Revert r62663 from Marek; see #70506 for details.
400 2006-09-01 Martin Baulig <martin@ximian.com>
403 (TypeManager.IsIList): Also handle base classes and interfaces.
405 2006-09-01 Raja R Harinath <rharinath@novell.com>
408 * expression.cs (Invocation.MoreSpecific): Check for reference
411 2006-08-29 Miguel de Icaza <miguel@novell.com>
413 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
415 2006-08-17 Miguel de Icaza <miguel@novell.com>
417 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
418 #52019 and #79064, the use of the \uXXXX sequence in source code
419 to represent unicode characters.
421 2006-08-15 Marek Safar <marek.safar@seznam.cz>
423 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
425 * class.cs, ecore.cs, statement.cs: Merged to one error message.
427 2006-08-14 Raja R Harinath <rharinath@novell.com>
430 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
431 parameter too. This only avoids a parse error -- the semantic
432 error is caught elsewhere.
434 2006-08-13 Miguel de Icaza <miguel@novell.com>
436 * assign.cs: Catch attempts to assign to a method groups in += and
439 2006-08-13 Marek Safar <marek.safar@seznam.cz>
442 * cs-parser.jay: Don't destroy current array type by typeof of array's.
444 2006-08-12 Marek Safar <marek.safar@seznam.cz>
446 * cs-parser.jay: Check whether a constraint clause has already been
447 specified for type parameter.
448 * generic.cs (Constraints): Exposed location.
450 2006-08-12 Marek Safar <marek.safar@seznam.cz>
452 * class.cs (Method.Define): Issue a warning when generic method looks like
454 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
456 * report.cs: New warning number.
458 2006-08-09 Marek Safar <marek.safar@seznam.cz>
460 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
462 * decl.cs (MemberCache.FindMembers): When container is interface we need to
463 search all base interfaces as a member can be ambiguous.
464 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
465 Constructor member type filter.
466 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
467 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
468 reporting for returned memberinfos.
469 * report.cs: Updated.
470 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
471 version to work on all runtimes.
472 (TypeManager.RealMemberLookup): Removed members filtering.
474 2006-08-08 Raja R Harinath <rharinath@novell.com>
476 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
477 (PropertyExpr.EmitAssign): Likewise.
478 * expression.cs (Indirection.EmitAssign): Likewise.
479 (LocalVariableReference.EmitAssign): Likewise.
480 (ParameterReference.EmitAssign): Likewise.
481 (Invocation.EmitArguments): Likewise.
482 (ArrayAccess.EmitAssign): Likewise.
483 (IndexerAccess.EmitAssign): Likewise.
484 (This.EmitAssign): Likewise.
485 (ConditionalLogicalOperator.Emit): Likewise.
488 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
489 instead of ArrayList. If the hashtable has a LocalBuilder, don't
490 leave it in after returning it.
491 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
493 2006-08-06 Marek Safar <marek.safar@seznam.cz>
495 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
498 2006-08-05 Marek Safar <marek.safar@seznam.cz>
500 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
501 with different type names.
502 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
504 2006-08-03 Raja R Harinath <rharinath@novell.com>
506 Fix cs0146-3.cs and cs0146-4.cs.
507 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
508 enclosing types don't depend on the current type.
510 2006-08-02 Raja R Harinath <rharinath@novell.com>
513 * class.cs (TypeContainer.DoDefineMembers): Use
514 FindBaseMemberWithSameName on Parent, since we're interested in
515 whether we hide inherited members or not.
516 (FindBaseMemberWithSameName): Make slightly more robust.
519 * codegen.cs (IResolveContext.GenericDeclContainer): New.
520 (EmitContext): Implement new interface requirement.
521 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
522 * decl.cs (MemberCore): Likewise.
523 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
524 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
525 ec.GenericDeclContainer to check for generic parameters.
526 (SimpleName.DoSimpleNameResolve): Likewise.
527 * generic.cs (TypeParameter.DeclContainer): Remove override.
529 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
530 declspaces for doppelgangers too.
531 (UsingEntry): Implement IResolveContext.
532 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
533 'this' as the resolve context.
534 (LocalAliasEntry): Likewise.
536 Implement parts of #77403
537 * roottypes.cs (RootDeclSpace): New. Used to represent the
538 toplevel declaration space. Each namespace declaration introduces
539 a "partial" root declaretion space.
540 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
541 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
542 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
543 from 'current_namespace.SlaveDeclSpace'.
544 (namespace_declaration): Likewise.
545 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
546 check. It can't happen now.
547 * decl.cs (DeclSpace.LookupType): Likewise.
548 * driver.cs (MainDriver): Sanity check.
550 2006-08-01 Raja R Harinath <rharinath@novell.com>
552 * decl.cs (DeclSpace.FindNestedType): Remove.
553 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
554 LookupTypeContainer to get the container of the nested type.
555 * class.cs (TypeContainer.FindNestedType): Make non-override.
557 2006-07-31 Raja R Harinath <rharinath@novell.com>
559 * decl.cs (DeclSpace.PartialContainer): Move field from ...
560 * class.cs (TypeContainer.PartialContainer): ... here.
561 (TypeContainer.AddBasesForPart): New helper.
562 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
564 * cs-parser.jay (current_class): Convert to DeclSpace.
565 (struct_declaration, interface_declaration, class_declaration):
566 Use AddBasesForPart instead of .Bases directly.
567 * const.cs, iterators.cs: Update to changes.
569 2006-07-28 Raja R Harinath <rharinath@novell.com>
571 * class.cs (TypeContainer.AddMemberType): Rename from
573 (TypeContainer.AddMember): Rename from AddToMemberContainer.
574 (AddTypeContainer): New. Combine AddClassOrStruct and
576 (AddPartial): Update. Add 'is_partial' argument.
577 * roottypes.cs: Update to changes.
578 * cs-parser.jay (push_current_class): New helper for handling
579 current_container and current_class.
580 (struct_declaration, interface_declaration, class_declaration):
583 2006-07-26 Raja R Harinath <rharinath@novell.com>
585 * roottypes.cs: Rename from tree.cs.
587 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
588 * tree.cs (Tree, ITreeDump): Remove types.
589 * rootcontext.cs (tree, Tree): Remove fields.
590 (root, ToplevelTypes): New.
591 * *.cs: Update to rename.
593 * tree.cs (Tree.RecordDecl): Remove.
594 (RootTypes.AddToTypeContainer): Record the toplevel type in its
596 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
598 2006-07-23 Raja R Harinath <harinath@gmail.com>
600 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
601 DoFlowAnalysis and OmitStructFlowAnalysis here.
602 (ec.With): Rename from WithUnsafe and generalize.
603 (ec.WithCheckState): Remove. All users can be handled by 'With'.
604 (ec.WithFlowAnalyis): New.
605 * ecore.cs, expression.cs, statement.cs: Update.
607 2006-07-22 Raja R Harinath <harinath@gmail.com>
609 * statement.cs (Block.ResolveMeta): Simplify slightly.
611 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
612 multiple boolean fields. Convert InUnsafe, constant_check_state,
613 check_state to flags.
614 (CheckState, ConstantCheckState): Update.
615 (InUnsafe): New read-only property.
616 (FlagsHandle): Rename from CheckStateHandle and convert to handle
618 (WithUnsafe): New helper similar to WithCheckState.
619 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
620 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
622 2006-07-21 Raja R Harinath <rharinath@novell.com>
624 Make comparisons use the same IL irrespective of whether they're
625 in a 'checked' or 'unchecked' context: one of the issues in #78899
626 * codegen.cs (EmitContext.CheckState): Make read-only property.
627 (EmitContext.ConstantCheckState): Likewise.
628 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
629 helper that implement a save/restore stack for CheckState
630 values. This is the only way to change check-state.
631 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
632 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
633 (CheckedExpr.EmitBranchable): New forwarding method.
634 (UnCheckedExpr): Likewise.
635 * statement.cs (Block.ResolveMeta): Use WithCheckState.
636 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
637 (Checked.Resolve, checked.DoEmit): Likewise.
639 2006-07-21 Martin Baulig <martin@ximian.com>
641 * generic.cs (TypeManager.InferType): When inferring an array
642 type, also allow IList<T> and ICollection<T>. Fixes #78900.
644 2006-07-21 Martin Baulig <martin@ximian.com>
646 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
647 and allow IList`1 and all its base interfaces.
649 * convert.cs (Convert.ImplicitReferenceConversion): Allow
650 converting from an array-type of T to IList<T>.
652 2006-07-21 Martin Baulig <martin@ximian.com>
654 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
656 2006-07-20 Miguel de Icaza <miguel@novell.com>
658 * anonymous.cs: Cache the resolved anonymous delegate, and return
659 this so that the ResolveTopBlock is only triggered once, not
662 Currently we trigger ResolvetopBlock twice due to a first pass of
663 argument check compatibility, and a second pass that does the
666 2006-07-15 Marek Safar <marek.safar@seznam.cz>
668 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
670 * rootcontext.cs (Reset): Add helper_classes.
672 2006-07-15 Marek Safar <marek.safar@seznam.cz>
675 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
678 2006-07-13 Miguel de Icaza <miguel@novell.com>
680 * statement.cs (Lock): Handle expressions of type
681 TypeManager.null_type specially. Fixes #78770
683 2006-07-08 Marek Safar <marek.safar@seznam.cz>
685 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
688 2006-07-08 Marek Safar <marek.safar@seznam.cz>
690 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
691 for accessors as well.
692 * ecore.cs (EventExpr): Add AccessorTable.
694 2006-07-03 Martin Baulig <martin@ximian.com>
696 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
697 instances of value types.
699 * convert.cs (Convert.ExplicitConversion): Correctly handle
700 object->nullable conversions.
702 2006-07-01 Marek Safar <marek.safar@seznam.cz>
705 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
706 for CS0122 where appropriate.
707 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
709 (Filter): Assembly can be null in the case of top level attributes.
711 2006-06-28 Raja R Harinath <rharinath@novell.com>
714 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
715 no arguments, return 'false': nothing can be inferred.
717 2006-06-25 Marek Safar <marek.safar@seznam.cz>
721 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
722 is done at global level.
724 2006-06-24 Marek Safar <marek.safar@seznam.cz>
726 A fix for #77002, Implemented TypeForwarder support.
728 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
729 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
731 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
732 * typemanager.cs (): Add type_forwarder_attr_type.
734 2006-06-24 Marek Safar <marek.safar@seznam.cz>
736 * report.cs: Add CS0469 warning.
738 2006-06-22 Martin Baulig <martin@ximian.com>
741 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
742 for interfaces; fixes #78686, which is a modification of #78380
743 with interfaces instead of classes.
745 2006-06-21 Martin Baulig <martin@ximian.com>
747 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
748 the `try'-block, so we also report CS0016 etc. there.
750 2006-06-21 Martin Baulig <martin@ximian.com>
752 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
753 handle SetAssigned() and SetMemberIsUsed() for generic types;
756 2006-06-21 Martin Baulig <martin@ximian.com>
759 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
761 2006-06-21 Martin Baulig <martin@ximian.com>
763 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
764 also report CS1686 for parameters.
766 2006-06-21 Martin Baulig <martin@ximian.com>
768 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
769 instead of an error if the value is not implicitly convertible to
770 the switch types; fixes #77964.
772 2006-06-21 Raja R Harinath <rharinath@novell.com>
775 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
776 FieldBuilder is null.
779 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
780 'left' and 'right' before error-checking.
782 2006-06-19 Martin Baulig <martin@ximian.com>
785 (Convert.ImplicitConversionStandard): Cleanup and correctly
786 implement nullable conversions.
787 (Convert.ImplicitStandardConversionExists): Likewise.
788 (Convert.ExplicitConversion): Likewise.
790 2006-06-19 Martin Baulig <martin@ximian.com>
793 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
794 methods; make the ctors protected.
796 2006-06-19 Martin Baulig <martin@ximian.com>
798 Fixed #78380; added gtest-273.cs.
801 (Expression.ResolveAsBaseTerminal): Move the constraint checking
802 into ResolveAsTypeTerminal().
805 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
806 TypeManager.FindMembers() to check for the default ctor.
808 2006-06-18 Marek Safar <marek.safar@seznam.cz>
810 * generic.cs: Fixed NullableInfo accessibility.
812 2006-06-16 Martin Baulig <martin@ximian.com>
815 (Constraints.InflatedConstraints.inflate): Correctly inflate
816 generic types; fixes #78400.
818 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
820 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
822 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
823 (FieldExpr.DoResolve): likewise.
824 (PropertyExpr.InstanceResolve): likewise.
825 (EventExpr.InstanceResolve): likewise.
827 2006-06-15 Martin Baulig <martin@ximian.com>
830 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
831 argument; always allow a `null' label if true.
832 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
833 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
834 we have a `null' label and mark the new `null_target' label;
835 default to the `default' label.
836 (Switch.Resolve): Add support for nullable types. Fixes #78630.
838 2006-06-15 Martin Baulig <martin@ximian.com>
840 * class.cs (Operator.Define): Allow an implicit/explicit operator
841 to convert to/from a nullable value of the enclosing type.
843 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
844 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
847 (Convert.ImplicitStandardConversionExists): Add support for lifted
848 implicit/explicit conversions.
849 (Convert.ImplicitConversionStandard): Likewise.
851 2006-06-13 Martin Baulig <martin@ximian.com>
853 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
854 type arguments and create a ConstructedType if necessary. Fixes #78400.
856 2006-06-04 Marek Safar <marek.safar@seznam.cz>
858 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
859 attribute applicable tests for attribute argument.
861 2006-06-02 Raja R Harinath <rharinath@novell.com>
864 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
865 (Binary.OverloadResolve_PredefinedIntegral): New.
866 (Binary.OverloadResolve_PredefinedFloating): New.
867 (Binary.OverloadResolve_PredefinedString): New.
868 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
869 Follow the standard more closely, and treat numeric promotions in
870 terms of overload resolution.
871 (Binary.CheckShiftArguments): Simplify.
873 2006-06-01 Raja R Harinath <rharinath@novell.com>
875 * flowanalysis.cs (MyBitVector): Simplify representation.
876 (MyBitVector.Clone): Avoid allocating BitArray.
877 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
878 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
879 (*): Update. Change all references to MyBitVector.And and
880 MyBitVector.Or to &= and |=.
882 2006-05-31 Raja R Harinath <rharinath@novell.com>
884 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
885 Use bne.un instead of ceq+brfalse.
888 * typemanager.cs (IsUnmanagedType): Disallow generic types and
891 2006-05-29 Raja R Harinath <rharinath@novell.com>
894 * cs-parser.jay (formal_parameter_list): Extend the pattern below
895 to param arguments too.
897 2006-05-26 Miguel de Icaza <miguel@novell.com>
899 * cs-parser.jay: Catch another parsing form for arglist being
900 followed by other arguments. Fixes #78313.
902 2006-05-25 Raja R Harinath <rharinath@novell.com>
905 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
906 also when one of the operands is a null literal.
907 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
908 to improve clarity, and generate slightly better code.
910 2006-05-24 Raja R Harinath <rharinath@novell.com>
912 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
913 checking of out parameters to ...
914 (FlowBranchingToplevel.Merge): ... here.
915 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
916 set, propagate the origin upward, and only complain if there was
918 (FlowBranchingException.AddContinueOrigin): Likewise.
919 (FlowBranchingException.AddReturnOrigin): Likewise.
920 (FlowBranchingException.AddGotoOrigin): Likewise.
922 2006-05-23 Raja R Harinath <rharinath@novell.com>
924 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
925 unreachable, skip it.
926 (FlowBranchingException.Merge): Always propagate jumps, even if
927 the finally block renders subsequent code unreachable.
929 2006-05-18 Raja R Harinath <rharinath@novell.com>
932 * statement.cs (Goto.Resolve): Move responsibility for resolving
933 'goto' to FlowBranching.AddGotoOrigin.
934 (Goto.SetResolvedTarget): New. Callback to set the
935 LabeledStatement that's the target of the goto.
936 (Goto.DoEmit): Use Leave instead of Br when crossing an
937 unwind-protect boundary.
938 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
939 LookupLabel and adjust to new semantics.
940 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
941 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
942 Goto.SetResolvedTarget to update target.
943 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
944 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
945 AddBreakOrigin & co. Delay propagation until ...
946 (FlowBranchingException.Merge): ... this.
948 * statement.cs (Block.Resolve): Always depend on flow-branching to
949 determine unreachability. Kill workaround that originally emitted
950 only one statement after an "unreachable" label (see infloop in
953 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
954 This is still "wrong", but anything better would probably need a
955 multi-pass algorithm.
956 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
957 usage vector. Force current usage vector to be reachable, to
958 optimistically signify backward jumps.
959 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
961 (FlowBranchingLabeled.Merge): New. If no backward jump was
962 detected, return the original salted-away usage vector instead,
963 updated with appropriate changes. Print unreachable warning if
965 * statement.cs (Block.Resolve): Don't print unreachable warning on
968 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
970 * driver.cs: Pass filename without path to AssemblyBuilder's
971 AddResourceFile. Fixes bug #78407.
973 2006-05-17 Raja R Harinath <rharinath@novell.com>
975 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
976 * flowanalysis.cs (FlowBranchingLabeled): ... here.
977 (FlowBranching.MergeChild): Overwrite
978 reachability information from Labeled branchings too.
980 2006-05-16 Raja R Harinath <rharinath@novell.com>
982 * statement.cs (Goto.Resolve): Merge jump origins here ...
983 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
985 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
986 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
987 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
988 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
990 * statement.cs (Goto.Resolve): ... not here.
991 (Goto.Emit): Remove CS1632 check.
993 2006-05-14 Marek Safar <marek.safar@seznam.cz>
995 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
998 2006-05-11 Raja R Harinath <rharinath@novell.com>
1000 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
1001 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
1002 (FlowBranchingException.Label): Likewise.
1004 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
1006 (MyBitVector.Or): Use it to avoid losing information (Count).
1007 (FlowBranching.MergeOrigins): Likewise.
1009 * flowanalysis.cs (UsageVector.IsDirty): Remove.
1010 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
1011 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
1012 (UsageVector.ToString): Simplify.
1013 (UsageVector.MergeSiblings): Move here from ...
1014 (FlowBranching.Merge): ... here.
1015 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
1018 2006-05-10 Raja R Harinath <rharinath@novell.com>
1020 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
1021 null bitvector is treated as all-true.
1023 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
1024 (MyBitVector): Rationalize invariants. 'vector != null' implies
1025 that we have our own copy of the bitvector. Otherwise,
1026 'InheritsFrom == null' implies all inherited bits are true.
1028 2006-05-09 Marek Safar <marek.safar@seznam.cz>
1030 * statement.cs (LocalInfo): Add IsConstant.
1031 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
1032 local variable for constants.
1034 2006-05-09 Raja R Harinath <rharinath@novell.com>
1036 * flowanalysis.cs (MyBitVector.Empty): New.
1037 (MyBitVector): Don't allow InheritedFrom to be null.
1038 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
1039 (UsageVector, FlowBranching): Update to changes.
1041 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
1042 recursion. The 'Parent == null' condition isn't sufficient for
1044 (FlowBranching.AddBreakOrigin): Likewise.
1045 (FlowBranching.AddContinueOrigin): Likewise.
1046 (FlowBranching.AddReturnOrigin): Likewise.
1047 (FlowBranching.StealFinallyClauses): Likewise.
1048 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
1049 (FlowBranching.CheckOutParameters): Likewise.
1050 (FlowBranchingToplevel): Terminate all the above recursions here.
1051 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
1052 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
1054 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
1056 (FlowBranchingToplevel): New. Empty for now.
1057 (FlowBranching.MergeTopBlock): Update.
1058 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
1059 branching for the anonymous delegate.
1060 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
1062 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
1063 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
1064 information at the start of the merge. Reorganize.
1066 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1068 * class.cs (MethodData.Define): Method cannot implement interface accessor.
1070 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1072 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
1073 to newly introduced ctor.
1075 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
1076 message to one place.
1077 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
1080 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1082 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
1084 * ecore.cs (Expression.ResolveAsConstant): Updated.
1086 * statement.cs (ResolveMeta): Updated.
1088 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1090 * cs-parser.jay: __arglist cannot be used in initializer.
1092 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1095 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
1098 2006-05-05 Raja R Harinath <rharinath@novell.com>
1100 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
1101 (LabeledStatement): Add 'name' parameter.
1102 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
1103 (Block.AddLabel): Update to changes.
1104 * cs-parser.jay (labeled_statement): Likewise.
1106 * flowanalysis.cs (BranchingType.Labeled): New.
1107 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
1108 (FlowBranchingLabeled): New. Does nothing for now, but will
1109 eventually handle 'goto' flows.
1110 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
1111 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
1112 that's terminated ...
1113 (Block.Resolve): ... here.
1115 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
1116 (UsageVector.MergeFinallyOrigins): Likewise.
1117 (FlowBranching.InTryOrCatch): Likewise.
1118 (FlowBranching.AddFinallyVector): Likewise.
1119 (FlowBranchingException): Update to changes.
1122 * statement.cs (Return.Resolve): Move error checking to ...
1123 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
1124 (FlowBranchingException): Handle return origins like break and
1126 (FlowBranching.UsageVector.CheckOutParameters): Remove.
1128 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1131 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
1134 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1137 * class.cs (MethodData.Define): Do public accessor check only when method
1138 implements an interface.
1140 2006-05-04 Raja R Harinath <rharinath@novell.com>
1142 Remove special handling of 'break'
1143 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
1144 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
1145 (UsageVector.Break): Remove.
1146 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
1148 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
1150 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
1151 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1153 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1156 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1157 be the interface member.
1159 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1162 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1163 for emitting small (int) values.
1165 2006-05-03 Raja R Harinath <rharinath@novell.com>
1168 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1169 control-flow passes through the 'finally' after merging-in all the
1170 control-flows from 'try' and the 'catch' clauses.
1172 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1173 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1174 always true at the only non-recursive entry point.
1175 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1176 FlowBranchingBreakable.
1177 (FlowBranchingLoop): Remove.
1178 * statement.cs (Return.DoResolve): Update to changes.
1181 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1182 (FlowBranching.CreateBranching): Handle it: create a
1183 FlowBranchingContinuable.
1184 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1185 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1186 except that it handles the 'continue' command.
1187 (FlowBranching.UsageVector.MergeOrigins): Rename from
1189 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1190 except that it overrides AddContinueOrigin.
1191 (FlowBranchingException): Override AddContinueOrigin, similar to
1193 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1194 Create a new branching around the embedded statement.
1195 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1196 control flow after the embedded statement.
1197 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1199 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1200 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1201 FlowBranchingBreakable.
1202 (FlowBranchingSwitch): Remove.
1205 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1206 error reporting to ...
1207 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1208 Rename from 'AddBreakVector'. Add new location argument. Return
1209 a bool indicating whether the 'break' crosses an unwind-protect.
1210 (FlowBranchingException.AddBreakOrigin): Add.
1211 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1212 flowbranching after updating with the effects of the 'finally'
1214 (FlowBranchingBreakable): New common base class for
1215 FlowBranchingLoop and FlowBranchingSwitch.
1217 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1219 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1221 2006-05-02 Raja R Harinath <rharinath@novell.com>
1223 * statement.cs (Do.Resolve): If the loop is infinite, set the
1225 (While.Resolve, For.Resolve): Set a barrier after the embedded
1226 statement. There's no direct control flow that goes from the end
1227 of the embedded statement to the end of the loop.
1228 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1229 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1230 above ensure that the reachability is correctly computed.
1232 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1233 (UsageVector.MergeBreakOrigins): If the current path is
1234 unreachable, treat it as if all parameters/locals are initialized.
1235 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1236 infinite loops before merging-in break origins.
1238 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1239 (Reachability.Reachable): Split part into ...
1240 (Reachability.Unreachable): ... this. Simplify.
1241 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1243 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1244 (Reachability.SetThrowsSometimes): Likewise.
1245 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1246 TriState.Always, use corresponding property.
1247 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1248 (Block.Resolve): Likewise. Remove some redundant checks.
1250 2006-05-02 Raja R Harinath <harinath@gmail.com>
1252 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1253 (Reachability.Meet): Don't bother checking AlwaysThrows --
1254 barrier is always set.
1255 (FlowBranchingBlock.Merge): Likewise.
1257 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1259 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1260 defined, so it's references should also compile only for NET_2_0
1261 (as occurs in mcs version)
1263 2006-05-01 Raja R Harinath <harinath@gmail.com>
1265 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1266 checks for unreachable.
1268 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1271 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1273 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1274 whether field is really assigned.
1276 2006-04-30 Raja R Harinath <harinath@gmail.com>
1278 * flowanalysis.cs (Reachability): Make 4-argument constructor
1280 (Reachability.Meet): Rename from 'And'. Remove static variant.
1281 (Reachability.Always): Rename from the highly misleading
1282 'Reachability.Never'.
1283 (FlowBranching.Merge): Update to changes. Mark an impossible
1284 situation with a 'throw'.
1285 (*): Update to changes.
1287 2006-04-29 Raja R Harinath <harinath@gmail.com>
1289 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1291 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1292 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1293 (*): Update to changes.
1294 * statement.cs: Update to changes.
1296 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1299 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1301 2006-04-28 Raja R Harinath <harinath@gmail.com>
1303 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1306 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1307 argument to two arguments: an usage-vector and a bool. Move call
1308 to FlowBranching.Merge () ...
1309 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1311 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1312 handling of loop and switch reachability to ...
1313 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1315 2006-04-27 Raja R Harinath <harinath@gmail.com>
1317 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1318 handling to FlowBranchingLoop.InLoop.
1319 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1321 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1324 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1325 anonymous method is allowed from AnonymousContainer here.
1327 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1329 2006-04-24 Raja R Harinath <rharinath@novell.com>
1332 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1334 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1337 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1338 (DoubleConstant.Reduce): Ditto.
1340 2006-04-23 Raja R Harinath <rharinath@novell.com>
1342 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1343 Remove 'lvalue_right_side' argument. Move parts to ...
1344 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1345 (LocalVariable.DoResolveLValue): ... these.
1347 2006-04-21 Raja R Harinath <rharinath@novell.com>
1350 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1351 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1352 (LocalVariableReference.DoResolveBase): Use it to implement new
1354 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1355 (Argument.Resolve): Simplify. Move CS1510 check ...
1356 * ecore.cs (Expression.ResolveLValue): ... here.
1357 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1358 (PropertyExpr.DoResolveLValue): Likewise.
1359 (FieldExpr.Report_AssignToReadonly): Likewise.
1360 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1361 LValueMemberAccess or LValueMemberOutAccess on instance depending
1363 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1364 DoResolve as appropriate.
1366 2006-04-20 Raja R Harinath <rharinath@novell.com>
1369 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1370 implicit conversions on 'out' and 'ref' arguments.
1372 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1373 improve clarity. Remove dead code.
1376 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1377 (Catch.Resolve): Resolve VarBlock if it exists.
1379 2006-04-19 Miguel de Icaza <miguel@novell.com>
1381 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1382 twice, this was some residual code, the enumerator was emitted
1383 properly in the two branche of if later.
1387 Thanks to Martin for finding the source of the problem
1389 2006-04-19 Raja R Harinath <rharinath@novell.com>
1391 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1392 cast is never an lvalue.
1393 (Cast.DoResolve, Cast.ResolveRest): Combine.
1394 (Argument.Emit): Simplify slightly. Move 'Expr is
1395 IMemoryLocation' check ...
1396 (Argument.Resolve): ... here.
1397 (Argument.Error_LValueRequired): Remove. Inline into only user.
1399 Simplifications. Fix cs0191-2.cs
1400 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1401 CS1649 and CS1651 to ...
1402 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1403 the actual selection of the error code and message to a lookup
1404 table. Add a dummy return value to simplify callsites.
1405 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1406 readonly fields of other instances of the same type. Move CS0197
1408 * expression.cs (Argument.Resolve): ... here. Simplify code.
1409 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1410 resolution of an out or ref argument. The code simplification
1411 above uses this invariant.
1413 2006-04-18 Raja R Harinath <rharinath@novell.com>
1415 Possibly fix #77752. Fix cs1690-[4-7].cs.
1416 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1417 CheckMarshallByRefAccess. Drop parameter.
1418 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1420 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1422 * report.cs (AllWarnings): Add CS1690.
1423 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1425 (LocalVariableReference.DoResolveBase): Update.
1427 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1429 * class.cs (MethodOrOperator): Moved common parts from method class.
1430 detect obsolete attributes.
1431 (Method.Define): Simplified as it reuses code from base.
1432 (Constructor.ValidAttributeTargets): Fixed issue found during
1434 (Destructor.ValidAttributeTargets): Fixed issue found during
1436 (Operator): Finished refactoring set off by #78020. Operator class is now
1437 ordinary method class.
1439 * anonymous.cs: Updated.
1441 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1443 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1445 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1447 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1448 detect obsolete attributes.
1449 (Method.CreateEmitContext): Moved to MethodOrOperator.
1451 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1454 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1455 customized exception to make crash detection easier.
1456 (MethodOrOperator): Started to work on new base class for methods and
1458 (Method): Derives from MethodOrOperator.
1459 (Constructor.Emit): Emits its own attributes.
1460 (AbstractPropertyEventMethod.Emit): Ditto.
1461 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1463 (Operator.Emit): It's temporary more tricky than should be.
1465 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1467 * report.cs (InternalErrorException): Add ctor with inner exception.
1469 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1472 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1475 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1478 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1481 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1483 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1484 attribute is present and Guid not.
1485 (Interface.ApplyAttributeBuilder): Ditto.
1487 * attribute.cs: Add error message.
1489 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1493 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1494 sources (it's composite) so hold them in extra array as they are used in
1495 Emit phase only. It worked in the previous versions by mistake.
1496 (Attribute.Emit): Emit attribute for more owners when exist.
1498 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1499 it has now different behaviour.
1501 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1503 * constant.cs (Constant.IsDefaultInitializer): New method.
1505 * class.cs: Updated.
1507 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1508 re-initialize default values. It saves KBs almost for every assembly.
1509 Thanks Zoltan for the idea.
1510 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1511 (ArrayCreation.DoResolve): Resolve only once.
1512 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1513 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1515 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1517 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1520 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1522 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1523 in an embedded statement too.
1525 2006-04-01 Raja R Harinath <rharinath@novell.com>
1528 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1532 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1535 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1536 arguments before checking whether a type is reflected or not.
1539 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1540 definition doesn't take part in overload resolution.
1541 (Invocation.IsParamsMethodApplicable): Likewise.
1542 (Invocation.OverloadResolve): When replacing a reflected override
1543 method with its base definition, ensure that type arguments are
1546 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1550 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1553 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1555 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1557 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1560 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1561 LocalTemporary change.
1563 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1565 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1566 initializers optimization.
1567 (ClassOrStruct.TypeAttr): Moved from modifiers.
1568 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1569 (FieldBase.ResolveInitializer): Resolves initializer.
1570 (FieldBase.HasDefaultInitializer): New property.
1572 * cs-parser.jay: Removed message.
1574 * expression.cs (CompilerGeneratedThis): New specialization.
1576 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1578 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1580 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1582 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1584 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1585 be now EnumConstants only.
1587 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1589 * attribute.cs, driver.cs: Reset more caches.
1591 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1593 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1595 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1597 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1598 for easier reuse. Updated all overrides.
1599 (IntegralConstant): New base class for all integral constants.
1600 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1601 of the constant range, report custom error.
1602 (UIntConstant.Reduce): Fixed uint conversion.
1604 * ecore.cs, literal.cs: Reduce updates.
1606 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1610 * class.cs (Constructor.Define): Removed extra if for default ctors.
1611 A patch from Atsushi Enomoto.
1613 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1615 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1616 GetAttributableValue.
1618 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1621 * convert.cs (ImplicitConversionRequired): Error message moved to
1624 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1625 automatic implicit conversion of an output value.
1626 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1628 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1630 (TypeOf.GetAttributableValue): Add extra handling for object type.
1632 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1633 special error message.
1635 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1637 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1639 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1640 compatible with MS runtime.
1642 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1644 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1645 attribute arguments here.
1647 * class.cs (Indexer.Define): The check was moved to attribute class.
1649 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1651 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1653 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1655 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1657 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1660 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1662 * doc-bootstrap.cs : fix build.
1664 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1666 * expression.cs (StringConcat.Append): Issue a warning when empty string
1669 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1671 * assign.cs (CompoundAssign.ResolveSource): Removed.
1673 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1676 * class.cs (TypeContainer.FindMethods): Removed.
1677 (TypeContainer.CheckMemberUsage): Made static.
1679 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1681 * constant.cs (CheckRange): Removed unused type argument.
1682 (CheckUnsigned): Removed unused type argument.
1684 * cs-parser.jay: Updated after MemberAccess clean up.
1685 Uses Length for empty string test.
1687 * cs-tokenizer.cs: Uses Length for empty string test.
1688 (IsCastToken): Made static.
1689 (is_hex): Made static.
1690 (real_type_suffix): Made static.
1692 * decl.cs (SetupCache): Made static.
1693 (OnGenerateDocComment): Removed unused ds argument.
1695 * delegate.cs (VerifyDelegate): Removed unused argument.
1697 * doc.cs: Uses Length for empty string test.
1699 * driver.cs: Uses Length for empty string test.
1701 * enum.cs (IsValidEnumType): Made static
1703 * expression.cs (EnumLiftUp): Removed unused argument.
1704 (ResolveMethodGroup): Ditto.
1705 (BetterConversion): Ditto.
1706 (GetVarargsTypes): Ditto.
1707 (UpdateIndices): Ditto.
1708 (ValidateInitializers): Ditto.
1709 (MemberAccess.ctor): Ditto.
1710 (GetIndexersForType): Ditto.
1712 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1714 * iterators.cs: Updated after MemberAccess clean up.
1716 * location.cs: Uses Length for empty string test.
1718 * namespace.cs: Uses Length for empty string test.
1720 * report.cs (CheckWarningCode): Made static.
1722 * statement.cs (LabeledStatement): Removed unused argument.
1724 * typemanager.cs (FilterNone): Removed.
1726 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1728 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1731 * class.cs: Updated.
1733 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1735 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1737 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1741 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1743 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1744 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1745 Add more error reporting; Fixed issue with params.
1747 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1749 * cs-parser.jay: AnonymousMethod requires host container.
1751 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1753 2006-03-18 Raja R Harinath <harinath@gmail.com>
1755 * class.cs: Change 'TypeContainer ds' constructor argument to
1756 'DeclSpace parent'. Some classes were missed below due to
1757 different naming convention.
1759 * class.cs (MemberCore.Parent): Delete. This makes the
1760 ParentContainer changes below enforceable by the compiler.
1762 Treat pointers to enclosing declaration space as 'DeclSpace', not
1764 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
1765 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
1767 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
1769 (Block.AddThisVariable): Likewise.
1770 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
1771 (AbstractPropertyEventMethod.Emit): Likewise.
1772 (AbstractPropertyEventMethod.EmitMethod): Likewise.
1773 (GetMethod.Define, SetMethod.Define): Likewise.
1774 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
1775 (DelegateMethod.EmitMethod): Likewise.
1777 Fix regression test-partial-13.cs.
1778 Rationalize use of PartialContainer. Ensure that the partial
1779 class semantics can be tied to type-correctness, i.e., any
1780 violation will cause a compile error.
1781 * class.cs, const.cs: Access all fields that belong to class
1782 TypeContainer via ParentContainer. Arguments of EmitContexts and
1783 Resolve()-like functions still use 'Parent'.
1785 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
1786 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
1787 (PropertyMethod.CheckModifiers): Remove unused argument.
1788 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
1791 2006-03-28 Raja R Harinath <rharinath@novell.com>
1793 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
1795 2006-03-17 Raja R Harinath <harinath@gmail.com>
1797 Make semantics of PartialContainer simpler.
1798 * decl.cs (DeclSpace.IsPartial): Remove.
1799 * class.cs (TypeContainer.IsPartial): Likewise.
1800 (TypeContainer..ctor): Set PartialContainer to point to self.
1801 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
1802 (TypeContainer.FindNestedType): Likewise.
1803 (MemberCore.ParentContainer): Simplify. Remove deprecation.
1805 2006-03-17 Marek Safar <marek.safar@seznam.cz>
1807 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
1809 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1811 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
1814 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1816 * class.cs (Operator.Define): An error for base conversion was not
1819 2006-03-13 Marek Safar <marek.safar@seznam.cz>
1821 A fix for #77593, #77574.
1823 * class.cs (MethodCore.CheckBase): Another if for operator.
1825 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1829 * expression.cs (VerifyArgumentsCompat): Reverted to double error
1830 reporting, it's more tricky than I thought.
1832 2006-03-09 Marek Safar <marek.safar@seznam.cz>
1834 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
1837 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
1838 (DelegateCreation.ImplicitStandardConversionExists): New method for just
1841 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
1844 2006-03-04 Marek Safar <marek.safar@seznam.cz>
1848 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
1849 (Event.Define): ditto
1850 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
1852 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
1853 Removed redundant code and set NewSlot for Invoke method too.
1855 * parameter.cs (Parameters.ctor): Add custom, type ctor.
1856 (Parameters.MergeGenerated): New method. Use this method when you merge
1857 compiler generated argument with user arguments.
1859 2006-03-03 Marek Safar <marek.safar@seznam.cz>
1861 * attribute.cs (ResolveAsTypeTerminal): Removed.
1863 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
1864 specialization for predefined types; 30% speed up.
1865 Finally placed obsolete check to right place.
1866 (Expression.ResolveType): Removed.
1868 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
1869 Updated after ResolveType was removed.
1871 * expression.cs (Cast.ctor): Check void cast.
1872 (Binary.ResolveAsTypeTerminal): Is never type.
1873 (Conditional.ResolveAsTypeTerminal): Is never type.
1875 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
1877 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1879 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
1881 2006-03-23 Martin Baulig <martin@ximian.com>
1883 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
1884 type check if either of the types is an open generic type.
1886 2006-03-23 Martin Baulig <martin@ximian.com>
1889 (Convert.ExplicitTypeParameterConversion): New method; implement
1890 explicit type parameter conversions.
1892 2006-03-23 Martin Baulig <martin@ximian.com>
1894 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
1895 blindly allow all conversions if we do not have any constraints.
1897 2006-02-27 Marek Safar <marek.safar@seznam.cz>
1899 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
1900 these two separated members to simplify the code.
1901 (Attribute.Resolve): Refactored to use new fields and methods.
1902 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
1903 implemented obsolete attribute checking.
1904 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
1905 implemented obsolete checking again. It look line never ending quest ;-)
1906 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
1908 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
1910 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
1912 *class.cs (Property.Define): Add RegisterProperty call.
1914 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
1915 argument groups (only 2).
1917 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
1918 encoding expression to arguments.
1919 (Expression.ExprClassToResolveFlags): Just turned to property.
1921 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
1922 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
1923 optimized as well as implemented support for zero-length attributes.
1925 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
1926 Add caching of PropertyInfo's.
1928 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1930 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
1931 error multiple times.
1933 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1935 New partial class implementation.
1936 A fix for #77027, #77029, #77403
1938 * attribute.cs (Attributable): Made attributes protected.
1940 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
1941 the replacements of ClassPart and PartialContainer.
1942 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
1943 (TypeContainer.AddInterface): Ditto.
1944 (TypeContainer.AddPartial): The main method for partial classes. It checks
1945 for errors and merges ModFlags and attributes. At the end class is added to
1947 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
1949 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
1950 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
1951 from the rest of partial classes.
1952 (TypeContainer.GetClassBases): Simplified.
1953 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
1955 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
1956 (TypeContainer.HasExplicitLayout): Uses Flags now.
1957 (PartialContainer): Removed.
1958 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
1959 (StaticClass): Was merged with Class.
1960 (Class.GetClassBases): class and static class bases are verified here.
1961 (Class.TypeAttr): Added static attributes when class is static.
1962 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
1963 (MemberBase): In some cases we need to call parent container for partial
1964 class. It should be eliminated but it's not easy now.
1966 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
1968 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
1969 partial classed to accumulate class comments.
1970 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
1972 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
1974 * driver.cs (MainDriver): Tree.GetDecl was removed.
1976 * modifiers.cs (Modifiers): Add partial modifier.
1978 * tree.cs (Tree.decl): Removed.
1979 (RootTypes): Started to use this class more often for root types
1982 2006-03-23 Raja R Harinath <rharinath@novell.com>
1984 * generic.cs (TypeParameter.UpdateConstraints): Update
1985 'constraints' if null.
1987 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1991 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
1992 external interface does not have an attribute.
1994 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1996 Another prerequisites for new partial classs implementation.
1998 * attribute.cs (Attribute.Equal): Implemented.
1999 (Attribute.Emit): Changed as attributes can be applied more than twice.
2000 (Attributes.Emit): Check for duplicate attributes here.
2002 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
2003 as a parameter, clean-up.
2005 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2009 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
2010 contains obsolete attribute check which can in some cases look for base
2011 type of current class which is not initialized yet.
2012 (TypeContainer.BaseType): Replacement of ptype.
2014 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
2016 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2018 First of prerequisites for new partial classs implemention.
2020 * attribute.cs (Attributable): Extended by ResolveContext;
2021 Attributes finally have correct context for resolving in all cases.
2022 (AttachTo): Attribute owner is assigned here.
2024 * codegen.cs (IResolveContext): Introduce new interface to hold
2025 all information needed in resolving phase.
2026 (EmitContext): Implements IResolveContext; more clean-up needed here.
2028 * decl.cs (MemberCore): Implemented IResolveContext.
2030 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
2031 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
2032 parameter.cs, statement.cs, tree.cs, typemanager.cs:
2033 Refactored to use new IResolveContext instead of EmitContext; cleanup
2035 2006-03-22 Raja R Harinath <rharinath@novell.com>
2037 Support ParameterDefaultValueAttribute in gmcs. Also applied to
2038 mcs to keep code differences small.
2039 * attribute.cs (Attribute.GetParameterDefaultValue): New.
2040 * typemanager.cs (parameter_default_value_attribute_type): New.
2041 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
2044 2006-03-22 Martin Baulig <martin@ximian.com>
2047 (Nullable.NullableLiteral): Derive from `NullLiteral'.
2050 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
2051 instead of the normal `NullLiteral'.
2053 2006-03-21 Martin Baulig <martin@ximian.com>
2056 * generic.cs (TypeManager.InferType): If `pt' is a generic
2057 parameter, don't check whether `pt == at'.
2059 2006-03-20 Raja R Harinath <rharinath@novell.com>
2062 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
2063 (TypeParameter.Resolve): Update to change.
2064 (ConstraintChecker.CheckConstraints): Resolve type-argument
2065 constraints before use.
2067 2006-03-16 Martin Baulig <martin@ximian.com>
2070 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
2071 and don't have any instance constructors, also lookup in the base class.
2072 (TypeManager.IsNullableValueType): New public method.
2074 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
2075 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
2076 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
2078 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
2079 instead of just TypeManager.IsNullableType() to determine whether
2080 a lifted operator exists.
2081 (UnaryMutator.DoResolve): Likewise.
2082 (Conditional.DoResolve): Likewise.
2083 (Binary.DoResolve): A lifted operator only exists if both operands
2084 are valuetypes and at least one of them is a nullable type.
2086 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
2088 * iterator.cs : yield break is allowed in try statement which has
2089 catch clauses. Fixed bug #77767.
2091 2006-03-12 Martin Baulig <martin@ximian.com>
2093 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
2094 private IsSignatureEqual() to compare types; see the comment in
2095 that method; fixes #77674.
2097 2006-03-10 Raja R Harinath <rharinath@novell.com>
2099 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
2100 (Expression.ResolveAsTypeTerminal): Likewise.
2101 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
2102 * expression.cs, generic.cs, iterators.cs: Likewise.
2103 * parameter.cs, statement.cs, typemanager.cs: Likewise.
2105 2006-03-09 Martin Baulig <martin@ximian.com>
2107 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
2108 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
2110 2006-03-09 Martin Baulig <martin@ximian.com>
2112 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
2113 `prepared' flag is set.
2115 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
2116 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
2117 issues; see gtest-254.cs.
2119 2006-03-07 Martin Baulig <martin@ximian.com>
2121 * generic.cs (TypeManager.InferType): Allow infering
2122 `IEnumerable<T>' with an array of T; see gtest-251.cs.
2124 2006-03-06 Martin Baulig <martin@ximian.com>
2127 (TypeManager.InferType): Fix gtest-250.cs.
2130 (TypeManager.IsSubclassOf): Also check the base class.
2133 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
2136 2006-03-01 Raja R Harinath <rharinath@novell.com>
2139 * expression.cs (ParameterReference.DoResolveBase): Change return
2141 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
2145 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
2148 * typemanager.cs (GetFullNameSignature): Don't nullref on
2149 protected accessors.
2151 2006-02-16 Martin Baulig <martin@ximian.com>
2154 (TypeManager.GetGenericFieldDefinition): New public method; use it
2155 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2157 2006-02-14 Martin Baulig <martin@ximian.com>
2159 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2161 2006-02-14 Martin Baulig <martin@ximian.com>
2164 (TypeManager.DropGenericMethodArguments): New public method; don't
2165 use GetGenericMethodDefinition() on something which is not a
2168 2006-02-14 Martin Baulig <martin@ximian.com>
2171 (ConstraintChecker.CheckConstraints): If a type parameter has the
2172 `struct' constraint, the type must be a non-nullable valuetype.
2174 2006-02-10 Martin Baulig <martin@ximian.com>
2177 (TypeManager.IsOverride): Make this work for instantiated methods
2178 in a generic class; fixes #77509.
2179 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2180 rather than calling it directly; fixes #77488.
2182 2006-02-08 Martin Baulig <martin@ximian.com>
2184 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2185 reporting into CheckConstraint() so we can use the correctly
2188 2006-02-08 Martin Baulig <martin@ximian.com>
2190 * expression.cs (BaseAccess): Add support for generic methods.
2192 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2193 the new MethodGroupExpr.
2195 2006-02-07 Martin Baulig <martin@ximian.com>
2197 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2198 also reference types; fixes #77483.
2200 2006-02-07 Martin Baulig <martin@ximian.com>
2203 (TypeManager.IsGenericMethod): We now return whether something is
2204 an instantiated generic method (and not a generic method def).
2205 (TypeManager.IsGenericMethodDefinition): New public method.
2208 (TypeManager.CSharpSignature): Only include type arguments for
2209 "real" generic methods, not for any instantiated method.
2210 (TypeManager.GetMethodName): Likewise, but also allow generic
2211 method definitions here.
2213 2006-02-06 Miguel de Icaza <miguel@novell.com>
2215 * codegen.cs (EmitScopeInitFromBlock): check here the
2216 capture_context, there is no need to make two calls to the
2219 * anonymous.cs: Add some debugging messages that might help me
2220 track other instances of this problem in the future (the
2221 regression of test 467).
2223 * cs-parser.jay: track the variable block, as we need to initalize
2224 any captured variables declared in this block for the "catch"
2225 portion of the "Try" statement.
2227 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2228 scope initialization for captured variables.
2230 Also, move the emit for the variables after the block location has
2233 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2235 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2237 2006-02-06 Martin Baulig <martin@ximian.com>
2239 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2240 `TypeManager.value_type' as parent type to
2241 ModuleBuilder.DefineType(). Fixes #77358.
2243 2006-02-02 Miguel de Icaza <miguel@novell.com>
2245 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2246 commit yesterday, the initialization for the roots is necessary.
2247 What is not necessary is the scope activation.
2249 2006-02-02 Raja R Harinath <rharinath@novell.com>
2251 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2252 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2254 (Argument.Resolve): Remove CS0206 checks.
2256 2006-02-01 Miguel de Icaza <miguel@novell.com>
2258 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2259 scopes for all the roots, the scopes will now be emitted when the
2260 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2262 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2263 code. This reduces a lot of existing cruft.
2265 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2266 that the ScopeInfo is generated as we enter the scope, not at the
2267 time of use, which is what we used to do before.
2269 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2270 every time a Block is about to be emitted if we have a
2273 2006-02-01 Raja R Harinath <rharinath@novell.com>
2275 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2276 attribute for mscorlib too.
2278 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2280 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2282 * typemanager.cs (cons_param_array_attribute): Make private.
2283 (Reset): Set it to null.
2284 (InitCoreHelpers): Don't initialize it.
2285 (ConsParamArrayAttribute): New. Initialize it as needed.
2286 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2288 2006-01-31 Miguel de Icaza <miguel@novell.com>
2290 * expression.cs: There might be errors reported during the
2291 selection of applicable methods. If there are errors, do not
2292 continue execution as it will lead the compiler to crash.
2294 2006-01-30 Miguel de Icaza <miguel@novell.com>
2296 * expression.cs: Member access is not allowed on anonymous
2297 methods. Fixes #77402.
2299 2006-01-30 Raja R Harinath <rharinath@novell.com>
2302 * cs-parser.jay (VariableDeclaration): Don't set
2303 current_array_type to null.
2304 (field_declaration, event_declaration, declaration_statement):
2305 Set it to null here.
2307 2006-01-29 Raja R Harinath <harinath@gmail.com>
2310 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2312 2006-01-28 Raja R Harinath <harinath@gmail.com>
2314 * typemanager.cs (GenericParameterPosition): New.
2317 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2319 * doc.cs : To process "include" elements, first we should create
2320 another list than XmlNodeList, because it could result in node
2321 removal, which could result in that the XmlNodeList gives up
2324 2006-01-25 Miguel de Icaza <miguel@novell.com>
2326 * expression.cs: Introduce an error report that we were not
2327 catching before. Gonzalo ran into it.
2329 2006-01-23 Miguel de Icaza <miguel@novell.com>
2331 A fix for bug: #76957
2333 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2334 ComputeMethodHost before creating the method, this is a new
2337 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2338 that this method references (RegisterScope). The actual scope
2339 where the method is hosted is computed with the ComputeMethodHost
2340 before we create the method.
2342 Moved the Deepest routine here.
2344 (AnonymousContainer.ComputeMethodHost): New routine used to
2345 compute the proper ScopeInfo that will host the anonymous method.
2347 (ScopeInfo): Deal with multiple roots. The problem was that we
2348 did not have a unique root where all ScopeInfos could be hanged
2349 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2352 Remove AdjustMethodScope which is now computed at the end. Remove
2353 LinkScope which did a partial link, instead link all ScopeInfos
2354 before code generation from the new "LinkScopes" routine.
2356 Simplify all the Add* routines as they no longer need to maintain
2357 the tree, they just need to record that they are using variables
2360 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2361 routines to produce the forest of ScopeInfo trees.
2363 * class.cs (TypeContainer.AppendMethod): This is just like
2364 AddMethod, but ensures that an interface implementation method
2365 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2366 methods, but at the end.
2368 We use this functionality to ensure that the generated MoveNext
2369 method in the iterator class is resolved/emitted before the
2370 enumerator methods created.
2372 This is required because the MoveNext method computes the right
2373 ScopeInfo for the method. And the other methods will eventually
2374 need to resolve and fetch information computed from the anonymous
2378 2006-01-23 Raja R Harinath <rharinath@novell.com>
2380 Improve implementation of section 14.4.2.2 (Better function member).
2381 * expression.cs (Invocation.MoreSpecific): Compare all type
2382 arguments before deciding if one type is more specific than
2383 another. Handle array types too. Return the more specific type.
2384 (Invocation.BetterFunction): Add more tie-breaking rules from
2385 section 14.4.2.2. Perform "more specific" check after
2386 other tie-breaking rules. Compare all parameter types before
2387 choosing the "more specific" method.
2389 2006-01-21 Raja R Harinath <harinath@gmail.com>
2390 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2393 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2395 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2396 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2398 2006-01-18 Martin Baulig <martin@ximian.com>
2400 * class.cs (TypeContainer.AddToMemberContainer): Use
2401 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2404 2006-01-18 Martin Baulig <martin@ximian.com>
2406 Fix #76417: a generic class may now have methods which may unify
2407 for some type parameter substitutions.
2409 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2410 for methods which may unify anymore.
2412 * expression.cs (Invocation.MoreSpecific): New private static
2413 method; checks whether one method is more specific than another
2414 according to 14.4.2.2 of the spec.
2415 (Invocation.BetterFunction): Implement the tie-breaking rules from
2416 14.4.2.2 of the spec: if two methods unify for some type parameter
2417 substitution, we need to pick the more specific one.
2419 2006-01-18 Raja R Harinath <rharinath@novell.com>
2421 Fix #76656, cs0231-2.cs.
2422 * cs-parser.jay (formal_parameter_list): Make error case catch
2424 (parenthesized_expression_0): Add CS1026 check.
2425 (invocation_expression): Remove unused { $$ = lexer.Location }.
2427 2006-01-17 Raja R Harinath <rharinath@novell.com>
2430 * cs-parser.jay (statement_expression): Don't list out the
2431 individual statement-expressions. Convert syntax error into
2434 2006-01-16 Raja R Harinath <rharinath@novell.com>
2437 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2438 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2439 CheckIntermediateModification.
2440 (FieldExpr.DoResolve): Add new two-argument version that
2441 allows us to resolve the InstanceExpression as an lvalue.
2442 The one-argument variant is now just a wrapper.
2443 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2444 Resolve the lhs as an lvalue if the it has a value type.
2445 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2446 from Assign.DoResolve.
2447 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2448 resolved as an lvalue.
2449 (PropertyExpr.DoResolve): Update.
2450 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2451 has a value type. Move CS1612 check here from
2452 CheckIntermediateModification.
2453 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2454 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2455 'right_side' of a ResolveLValue on an 'out' argument.
2456 (EmptyExpression.LValueMemberAccess): New. Used as the
2457 'right_side' of a propagated ResolveLValue on a value type.
2458 (LocalVariableReference.DoResolveBase): Recognize
2459 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2461 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2462 EmptyExpression.Null.
2464 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2466 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2467 Type.IsGenericParameter(). Fixed bug #77183.
2468 * doc.cs : it is now identical to doc.cs in mcs.
2470 2006-01-16 Martin Baulig <martin@ximian.com>
2472 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2474 2006-01-16 Martin Baulig <martin@ximian.com>
2476 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2477 ctors; fixes #77250.
2479 2006-01-12 Miguel de Icaza <miguel@novell.com>
2481 This fixes the problem where we used ldfld instead of ldflda to
2482 load the "THIS" pointer on captured parameters, when THIS is a
2483 value type. See bug #77205.
2485 * iterators.cs (CapturedThisReference.Emit): Pass false to
2486 EmitThis (we do not need the address).
2488 * codegen.cs (EmitThis): it needs to know whether we need the
2489 address of `this' or not. This is used by value types.
2491 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2492 every other call passes false.
2494 2006-01-12 Raja R Harinath <rharinath@novell.com>
2497 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2499 * expression.cs (Invocation.OverloadResolve): Update.
2500 (Invocation.DoResolve): Avoid double resolution of invocation.
2502 2006-01-11 Raja R Harinath <rharinath@novell.com>
2505 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2506 unary negation of floating point types as 0-expr; negation cannot
2507 overflow in floating point types.
2510 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2511 on operands of 'void' type.
2514 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2515 and ExclusiveOr for boolean constants too.
2517 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2519 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2521 2006-01-12 Miguel de Icaza <miguel@novell.com>
2523 * cs-tokenizer.cs (Position): New class used to save and restore
2524 the position state in the tokenizer. Before this patch the save
2525 and restore was not complete enough so the line and columns would
2526 start to drift and the debugger and stack traces will get the
2529 2006-01-10 Martin Baulig <martin@ximian.com>
2532 (TypeParameter.InflateConstraints): New public method.
2534 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2535 constraints; fixes #77042.
2537 2006-01-10 Martin Baulig <martin@ximian.com>
2539 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2540 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2543 2006-01-09 Raja R Harinath <rharinath@novell.com>
2546 * expression.cs (Invocation.OverloadResolve): Replace reflected
2547 override methods with their base virtual methods, rather than
2549 * typemanager.cs (TypeManager.GetOverride): New.
2551 2005-12-21 Miguel de Icaza <miguel@novell.com>
2553 * driver.cs: Report the case of no source files and no -out:
2556 2005-12-20 Raja R Harinath <rharinath@novell.com>
2559 * expression.cs (ComposedCast.GetSignatureForError): Define.
2561 2006-01-05 Jb Evain <jbevain@gmail.com>
2563 * class.cs (Property.Define, Indexer.Define): do not tag the
2564 properties as SpecialName | RTSpecialName.
2566 2006-01-04 Miguel de Icaza <miguel@novell.com>
2568 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2569 doing a low-level comparission of parameter types. It was lacking
2570 a check for __argslist.
2572 2005-12-30 Miguel de Icaza <miguel@novell.com>
2574 * expression.cs (ParameterReference.DoResolveBase): Allow
2575 reference parameters if they are local to this block.
2577 This allows the ref and out parameters of a delegate to be used in
2578 an anonymous method, for example:
2580 delegate void set (out int x);
2582 set s = delegate (out int x){
2586 This is used by functionality introduced late in the C# language.
2588 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2589 method that take ref and out parameters.
2591 Fixes #77119 which was a late change in the spec.
2593 2005-12-23 Miguel de Icaza <miguel@novell.com>
2595 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2596 parent if its the same scope. Fixes #77060.
2598 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2600 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2602 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2604 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2605 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2606 that doesn't contain the full public key. This is a update of the
2607 friend assemblies in .Net 2.0 release.
2609 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2613 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2614 ListDictionary, to contain the ExternAliasEntry entries (in
2615 addition to the NamespaceEntry.aliases hashtable). This field is
2616 shared between the original entry and its doppelganger (bodyless
2618 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2619 extern_aliases field.
2620 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2621 lookup in extern_aliases.
2623 2005-12-16 Raja R Harinath <rharinath@novell.com>
2626 * class.cs (TypeContainer.Mark_HasEquals): New.
2627 (TypeContainer.Mark_HasGetHashCode): New.
2628 (ClassPart): Override them.
2629 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2631 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2632 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2636 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2637 'parent' argument to the base constructor.
2639 Remove all mention of TypeContainer from decl.cs.
2640 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2641 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2642 (DeclSpace.DeclSpace): Likewise.
2643 (DeclSpace.DefineMembers): Remove unused argument.
2644 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2645 debugging check -- we don't care if the debug code throws an
2646 InvalidCastException instead of an InternalErrorException.
2647 * class.cs (TypeContainer.DefineMembers): Update to changes.
2648 (TypeContainer.DoDefineMembers): Likewise.
2649 (TypeContainer.GetMethods): Likewise.
2650 (PropertyMember.Define): Likewise.
2651 (MemberBase.Parent): New property that forwards to
2652 MemberCore.Parent, but ensures that we get a TypeContainer.
2653 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2654 (RootContext.PopulateTypes): Likewise. Remove special case code
2655 for !RootContext.StdLib: DefineMembers is idempotent.
2657 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2659 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2661 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2663 * doc.cs : The search for referenced namespace was insufficient to
2664 get global one as it used to do. Fixed bug #76965.
2666 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2668 * doc.cs : check name in cref in the last phase that whether it is
2671 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2673 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2676 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2678 * doc.cs : so it turned out that we cannot skip override check for
2679 interface members. Fixed bug #76954.
2681 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2683 * cs-tokenizer.cs : fixed bug #75984:
2684 - #warning and #error should not be handled when the source line
2686 - #line is not checked strictly when the source line is disabled.
2687 - #define and #undef is on the other hand checked strictly at any
2690 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2692 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2695 2005-12-15 Raja R Harinath <rharinath@novell.com>
2697 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2699 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2702 2005-12-14 Martin Baulig <martin@ximian.com>
2704 * typemanager.cs (TypeManager.GetFullName): Make this public;
2705 `Type.Fullname' now never returns null.
2707 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2708 explicit interface implementations; we're now using the same
2709 naming convention than csc does.
2711 2005-12-14 Miguel de Icaza <miguel@novell.com>
2713 * convert.cs (ExplicitConversionCore): Check the return value from
2714 ExplicitConversionCore which can return null on failure. Fixes #76914
2716 2005-12-09 Raja R Harinath <rharinath@novell.com>
2718 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2719 instead of IsGenericInstance.
2720 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2721 code that's now covered by the more general test.
2722 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2724 * generic.cs (DropGenericTypeArguments): New. Captures the common
2725 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2726 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2727 * generic.cs, report.cs, typemanager.cs: Likewise.
2729 2005-12-08 Martin Baulig <martin@ximian.com>
2731 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2733 * typemanager.cs (TypeManager.CSharpSignature): Include type
2734 arguments in the signature of a generic method.
2736 2005-12-07 Martin Baulig <martin@ximian.com>
2738 Add support for custom attributes on type parameters.
2740 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2742 * generic.cs (TypeParameterName): New public class; we use this
2743 instead of a `string' to store the name of a type parameter, so we
2744 can also have `Attributes'.
2745 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2746 array instead of a `string[]' array.
2747 (TypeParameter.ctor): We now also take an `Attributes' argument.
2748 (TypeParameter.EmitAttributes): New public method; emit our
2749 `OptAttributes' here.
2750 (GenericMethod.EmitAttributes): New public method; emit the custom
2751 attributes on all our type parameters.
2753 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2754 our type parameters.
2755 (MethodData.Define): If we're a generic method, call
2756 EmitAttributes() on it.
2758 2005-12-07 Martin Baulig <martin@ximian.com>
2761 (ConstraintChecker): New public abstract class; move the
2762 constraint checking here from `ConstructedType' and also do
2763 constraint checking for generic methods here.
2765 * expression.cs (Invocation.OverloadResolve): Use
2766 ConstraintChecker.CheckConstraints() if we resolved to a generic
2769 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2771 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
2773 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
2775 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
2776 (FieldBase.Initializer): Initializer is now optional.
2777 (EventField.Define): Only event field can have initializer.
2779 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
2781 * const.cs (Const): Reuse initializer.
2783 * cs-parser.jay: Updated after FieldBase changes.
2784 Added current_array_type to simplify array initializers.
2786 * ecore.cs (NullCast.IsDefaultValue): Implemented.
2788 * expression.cs, iterators.cs: Updated.
2790 * namespace.cs (NamespaceEntry): Made UsingFound private.
2792 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2794 * parameterCollection.cs: Obsolete, removed.
2795 * parser.cs: Obsolete, removed.
2797 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2800 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
2802 * enum.cs (Enum.Define): Set obsolete context here.
2804 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2807 - FindDocumentedMember() now expects 1) paramList as null
2808 when "we don't have to check the number of parameters" and
2809 2) Type.EmptyTypes when "there is no arguments".
2810 - Introduced FoundMember struct to hold the exact type which was
2811 used to find the documented member (the above change broke
2812 test-xml-044; it might be better just to use DeclaringType than
2813 what MS does, like this change does, but it depends on usage.)
2815 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2817 * doc.cs : documented member might be from DeclaringType for nested
2818 types. Fixed bug #76782.
2820 2005-12-03 Ben Maurer <bmaurer@ximian.com>
2822 * anonymous.cs: Have the param code handle leaving copies on the
2823 stack etc. Allows anonymous params to take part in the assignment
2824 code (++, +=, etc). Fixes bug #76550
2826 * expression.cs: Handle the prepare_for_load/leave_copy by passing
2827 it down to the anon code.
2829 * iterators.cs: Use dummy var here
2831 * codegen.cs: Handle new vars
2833 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2836 * class.cs (MethodData.Define): Set proper Obsolete context.
2838 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
2840 (FieldExpr.DoResolve): Ditto.
2842 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2845 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
2846 parent is not obsolete.
2848 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
2850 * doc.cs : (FindDocumentedMember) find parameterless members first
2851 and get CS0419 in the early stage. Fixed first case of bug #76727.
2853 2005-11-30 Marek Safar <marek.safar@seznam.cz>
2856 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
2857 no error was reported.
2859 *expression.cs (Binary.DoResolve): left can be null.
2861 2005-12-06 Raja R Harinath <rharinath@novell.com>
2863 * class.cs (MethodCore.CheckGenericOverride): Delete unused
2864 abstract method and all overrides.
2865 * support.cs (ParameterData.GenericConstraints): Delete.
2866 (ReflectionParameters.type_params): Delete.
2867 (ReflectionParameters.ReflectionParameters): Make private.
2868 (ReflectionParameters.GetConstaints): New factory method.
2869 * generic.cs (TypeParameterDefineType): Use it.
2870 (TypeManager.GetTypeParameterConstraints): Likewise.
2872 2005-11-22 Marek Safar <marek.safar@seznam.cz>
2875 * class.cs (MethodData.Emit): Parameters should be labeled first.
2877 2005-11-21 Marek Safar <marek.safar@seznam.cz>
2880 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
2882 2005-11-18 Marek Safar <marek.safar@seznam.cz>
2884 * attribute.cs (AreParametersCompliant): Moved to Parameter.
2886 * class.cs (MethodCore): Parameter clean up.
2887 (IMethodData): Added ParameterInfo.
2888 (MethodData): Parameter clean up.
2889 (Indexer.Define): Parameter clean up.
2901 * typemanager.cs: Parameter clean up.
2903 * delegate.cs (Define): Get rid of duplicated code.
2905 * expression.cs (ParameterReference): Removed useless parameters
2907 (Invocation): Ditto.
2909 * parameter.cs (ParamsParameter): New class, params specialization.
2910 (ArglistParameter): Attemp to separate arglist.
2911 (Parameter): Refactored to be reusable and faster.
2912 (Parameter.Modifier): Made understandable.
2913 (Parameters): Changed to be used as a class for `this' assembly
2914 parameters. Refactored to use new specialized classes.
2916 * support.cs (ParameterData): Added Types property.
2917 (InternalParameters): Deleted.
2919 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2921 * doc.cs : the previous patch does not actually fix the bug.
2922 PropertyInfo override check is now implemented and really fixed it.
2923 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
2925 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2927 * doc.cs : apply "override filter" also to properties.
2930 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2932 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
2933 no need to check overrides. For classes, omit those results from
2934 interfaces since they must exist in the class. Fixed bug #76726.
2936 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2938 * typemanager.cs : (GetFullNameSignature) differentiate indexers
2939 with different parameters. Fixed the second problem in #76685.
2941 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2943 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
2944 get expected 'protected' access in CheckValidFamilyAccess()).
2947 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2949 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
2950 Fixed bug #76705. CS1569 was incorrectly commented out.
2952 2005-11-23 Martin Baulig <martin@ximian.com>
2954 * generic.cs (Constraints.Define): Removed.
2955 (TypeParameter.DefineConstraints): Removed.
2956 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
2957 on the GenericTypeParameterBuilder here.
2959 2005-11-23 Martin Baulig <martin@ximian.com>
2961 * typemanager.cs (TypeManager.GetProperty): Make this public.
2963 * generic.cs (Nullable.NullableInfo.ctor): Use
2964 TypeManager.GetProperty() rather than using reflection directly.
2966 2005-11-17 Martin Baulig <martin@ximian.com>
2968 * expression.cs (Indexers.GetIndexersForType): Added support for
2969 generic parameters; fixes #76587.
2971 2005-11-17 Martin Baulig <martin@ximian.com>
2974 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
2975 inherit the scope from our parent. Fixes #76653.
2977 2005-11-15 Martin Baulig <martin@ximian.com>
2979 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
2980 instead of `ScopeTypeBuilder' to refer to the "current" type.
2981 (AnonymousMethod.CreateScopeType): Correctly create the helper
2982 class if we're inside a generic type definition.
2984 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2986 * doc.cs : use Invocation.IsOverride() to do real override check.
2987 * expression.cs : made Invocation.IsOverride() internal.
2989 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2991 * doc.cs : use TypeManager.FindMembers() instead of (possible)
2992 TypeBuilder.FindMembers() and filter overriden base members out.
2995 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2997 * doc.cs : ref/out parameters are represented as '@' (instead of
2998 '&' in type FullName). Fixed bug #76630 (additionally crefs).
3000 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3002 * doc.cs : when there was no '.' in cref to methods in doc comment,
3003 then parameters were missing in the output. Fixed bug #76691.
3005 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3007 * driver.cs : don't output docs when there is an error.
3010 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3013 Now it should detect indexers. Fixed primary concern in bug #76685.
3014 Fixed CS0419 message to not show the identical member signature in
3017 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3019 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
3020 instead of Type.FindMembers() since it does not handle events.
3023 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
3025 * codegen.cs: Fixed typo (speficied -> specified).
3027 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3030 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
3032 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3034 * attribute.cs: Changed error message.
3036 * cs-tokenizer.cs: One more check.
3038 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3040 * statement.cs (Block.Resolve): Ignore empty statement.
3042 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3044 * report.cs: Made error/warning methods more strict to avoid
3047 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
3048 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
3049 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
3050 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
3052 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3054 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
3055 Use the more explicit AssemblyName.FullName instead of
3056 AssemblyName.Name to report errors.
3058 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3060 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
3063 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3073 * report.cs: Fixed error reporting and typos.
3075 * generic.cs (TypeParameter.GetSignatureForError): New method.
3076 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
3078 * typemanager.cs (GetFullName): Refactored.
3080 2005-11-08 Marek Safar <marek.safar@seznam.cz>
3082 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
3083 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
3085 * class.cs (TypeContainer.IsComImport): New property.
3086 (Constructor.Define): Create proper ctor for ComImport types.
3088 * expression.cs (New.CheckComImport): Fixed.
3090 2005-11-07 Miguel de Icaza <miguel@novell.com>
3092 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
3093 that a parameter has been captured does not mean that we do not
3094 have to do the rest of the processing. This fixes the second part
3095 of #76592. If there was another anonymous method capturing
3096 values in the past, the Scope would never be set for the second
3097 method that captured the same parameter.
3099 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
3100 properly manipulate the stack. Second part of fix for #76592.
3102 * expression.cs (New): Add support for invoking "new" on
3103 interfaces that have been flagged with the ComImport attribute and
3104 the CoClass. Fixes #76637
3106 * statement.cs (Try.DoEmit): When a variable is captured, do not
3107 try to emit the vi.LocalBuilder variable as it has been captured.
3108 Create a temporary variable and store the results on the
3109 FieldBuilder. Fixes #76642
3111 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3113 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
3115 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
3117 * expression.cs (Binary.DoResolve): Added && optimalization.
3119 * typemanager.cs (AddUserType): Removed useless argument.
3121 2005-11-04 Marek Safar <marek.safar@seznam.cz>
3123 * statement.cs (Block.variables): Uses ListDictionary.
3125 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3128 * class.cs (PartialContainer.EmitType): Customized to emit
3129 security attributes.
3130 (ClassPart.ApplyAttributeBuilder): Transform security attribute
3131 for partial classes.
3133 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3136 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
3137 access has to be fixed.
3139 * typemanager.cs (IsUnmanagedType): Wrong common field type.
3141 2005-11-01 Marek Safar <marek.safar@seznam.cz>
3144 * ecore.cs (NullCast.Reduce): Implemented.
3146 * expression.cs (ArrayCreation.CheckIndices): Correcly check
3149 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
3151 (Foreach.Resolve): Catch null properly.
3153 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3155 * cs-tokenizer.cs: Warning text fix.
3157 * driver.cs: AllWarningNumbers exposed on public interface.
3159 * report.cs (): Reviewed warning numbers.
3160 (IsValidWarning): Use binary search.
3162 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3164 * driver.cs: Implemeted resource visibility.
3165 (Resources): New class for code sharing between /res: and
3168 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3170 decl.cs (CurrentTypeParameters): Fixed to be public.
3172 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3174 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3176 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3178 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3180 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3182 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3184 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3186 Add friend assembly access support.
3187 * typemanager.cs: assembly_internals_vis_attrs
3188 cache for friend assembly access.
3189 (TypeManager.IsFriendAssembly): New method for
3190 checking friend assembly access.
3191 (TypeManager.Error_FriendAccessNameNotMatching): New
3193 (TypeManager.CompareKeyTokens): Likewise.
3194 (TypeManager.Filter): Handle friend accessible
3197 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3198 friend accessible types.
3200 * ecore.cs (Expression.IsAccessorAccessible): Handle
3201 friend accessible properties.
3203 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3206 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3209 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3212 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3215 * ecore.cs (NullCast): Child is contant only.
3217 * literal.cs (NullLiteral.Reduce): null can be converted to any
3220 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3222 * driver.cs: Use Encoding.Default as default code page instead
3225 2005-10-27 Raja R Harinath <rharinath@novell.com>
3228 * expression.cs (Invocation.Error_InvalidArguments): Handle
3229 __arglist parameters.
3230 (Invocation.VerifyArgumentsCompat): Likewise.
3231 * support.cs (ReflectionParameters.GetSignatureForError): Print
3232 __arglist parameters.
3233 (InternalParamters.GetSignatureForError): Likewise.
3234 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3236 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3238 * attribute.cs (GetPropertyValue): Made public.
3240 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3242 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3244 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3247 * driver.cs: Reflect method name change.
3249 * statement.cs (Try.Resolve): Warn when try has both general
3252 * typemanager.cs: runtime_compatibility_attr_type new predefined
3255 2005-10-26 Raja R Harinath <harinath@gmail.com>
3258 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3259 treat it as an empty parameter list.
3261 2005-10-26 Raja R Harinath <rharinath@novell.com>
3264 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3265 ResolveAsTypeStep silent.
3266 * statement.cs (Block.AddConstant): Mark block as used.
3267 (Block.ResolveMeta): Avoid piling on error messages
3268 if a constant initializer resolution fails.
3270 2005-10-25 Raja R Harinath <rharinath@novell.com>
3272 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3274 (NamespaceEntry.VerifyAllUsing): New.
3275 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3276 behaviour. Delegates actual resolution of alias to ...
3277 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3278 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3280 * driver.cs (Driver.MainDriver): Update.
3282 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3283 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3285 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3287 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3288 RootNamespace.DefineNamespacesForAll.
3290 2005-10-24 Raja R Harinath <harinath@gmail.com>
3292 * typemanager.cs (assemblies, external_aliases, modules)
3293 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3294 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3295 overhead. Move resposibility ...
3296 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3297 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3299 2005-10-23 Raja R Harinath <harinath@gmail.com>
3301 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3302 cached_namespaces. Improve usage.
3303 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3304 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3305 Move from GlobalRootNamespace and simplify.
3306 (RootNamespace.Global): Make instance variable.
3307 (RootNamespace.RootNamespace): Add "alias name" parameter.
3308 (GlobalRootNamespace): Simplify drastically.
3309 (Namespace.Lookup): Don't use GetNamespace.
3310 * typemanager.cs (GetRootNamespace): Rename from
3311 ComputeNamespaceForAlias.
3312 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3314 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3316 * anonymous.cs (AnonymousContainer): Don't crash when container
3319 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3321 * expression.cs (Binary.DoResolve): Warn when comparing same
3324 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3327 * expression.cs (Binary.DoResolve): It looks like there are no
3328 convetsion rules in enum context.
3330 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3332 Add support for extern alias qualifiers.
3333 * typemanager.cs: Move some LookupTypeReflection code
3334 to namespace.cs, to have cleaner code. Added some methods
3335 to help us keep track of the extern aliased references.
3336 * driver.cs: Add suport for extern alias assemblies on command
3337 line and check for their warnings/errors. Also keep track of the
3338 extern aliased assemblies.
3339 * namespace.cs: Move the global functionality of Namespace
3340 to GlobalRootNamespace/RootNamespace. Now the global namespace
3341 is GlobalRootNamespace.Globa. Also the code moved from
3342 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3343 Finally added LocalAliasEntry (AliasEntry before) and
3344 ExternAliasEntry, to handle alias statements.
3345 * cs-parser.jay: Add support in the grammar for extern alias
3347 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3348 Update callings to Namespace (now in GlobalRootNamespace).
3350 2005-10-25 Martin Baulig <martin@ximian.com>
3352 * convert.cs (ImplicitTypeParameterConversion): Make base
3353 interfaces actually work; fixes #76557.
3355 2005-10-25 Martin Baulig <martin@ximian.com>
3358 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3359 all the type parameters; fixes #76551.
3361 2005-10-25 Martin Baulig <martin@ximian.com>
3366 (GenericMethod.ctor): Added `Expression return_type' and
3367 `Parameters parameters' arguments.
3368 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3369 parameter and return types to check their constraints if they're
3372 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3375 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3376 constraints of a generic type if `ec.ResolvingGenericMethod'.
3378 * class.cs (MethodCore.DoDefineParameters): Set
3379 `ec.ResolvingGenericMethod' if we're a generic method.
3380 (MemberBase.MemberType): Likewise.
3382 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3384 * typemanager.cs (TypeManager): Added
3385 TypeManager.internals_visible_attr_type to cache
3386 S.R.CompilerServices.InternalsVisibleToAttribute.
3388 * codegen.cs (AssemblyClass): Added checks for
3389 InternalsVisibleToAttribute in new method
3390 CheckInternalsVisibleAttribute () and also cache the
3391 AssemblyName in AssemblyClass.Name.
3393 2005-10-24 Martin Baulig <martin@ximian.com>
3396 (TypeManager.ExpandInterfaces): Added overloaded version which
3397 just takes a `Type[]' array.
3400 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3401 just use the interfaces which were explicitly specified and not
3402 the interfaces they inherit. Fixes #76482.
3403 (TypeParameter.FindMembers): Expand the interfaces here.
3405 2005-10-21 Martin Baulig <martin@ximian.com>
3408 (Constraints.Resolve): Also resolve the actual types here.
3409 (Constraints.ResolveTypes): Just check the constraints here.
3410 Fixes #76363; see gtest-218.cs.
3412 2005-10-21 Martin Baulig <martin@ximian.com>
3415 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3416 instead of a `BoxedCast'; fixes gtest-217.cs.
3418 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3420 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3421 1) "new()" is specified as generic parameter constraint and 2) the
3422 type is TypeBuilder and 3) the type is abstract even if it has a
3423 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3425 2005-10-20 Martin Baulig <martin@ximian.com>
3428 (GenericConstraints.TypeParameter): New public property.
3429 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3430 (TypeParameter.DeclSpace): New public property.
3431 (TypeParameter.DefineType): Inflate the constraints if our
3432 `DeclSpace' is an `Iterator'.
3434 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3436 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3437 GenericMethod argument to compare methods' generic type arguments.
3440 2005-10-19 Martin Baulig <martin@ximian.com>
3442 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3443 not ResolveType() when resolving the base type, so we're not
3444 checking the constraints here.
3445 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3448 2005-10-19 Martin Baulig <martin@ximian.com>
3450 * generic.cs (ConstructedType.CheckConstraints): Committing
3451 untested fix for #76441.
3453 2005-10-18 Raja R Harinath <rharinath@novell.com>
3456 * class.cs (TypeContainer.DefineType): Move updating of
3457 topological sort earlier in the code.
3458 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3460 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3463 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3465 * constant.cs (Constant.TryReduce): Moved from Cast class.
3466 (Reduce): Made little bit more OO and fixed missing conversions.
3468 * ecore.cs (Reduce): Implemented.
3469 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3471 * literal.cs (Reduce): Implemented.
3473 * class.cs: Reverted Miguel's wrong commit.
3475 2005-10-14 Miguel de Icaza <miguel@novell.com>
3477 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3479 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3481 * cs-parser.jay, expression.cs : CS0214 was missing error location
3482 for constants. Fixed bug #76404.
3484 2005-10-10 Raja R Harinath <rharinath@novell.com>
3486 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3488 (PropertyExpr.EmitCall): Likewise.
3489 * expression.cs (Invocation.EmitArguments): Handle case where
3491 (Invocation.EmitCall): Avoid allocating temporary variable if
3492 there are no arguments.
3494 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3497 * convert.cs (ExplicitConversionCore): Fixed object->enum
3500 2005-10-07 Raja R Harinath <rharinath@novell.com>
3503 * convert.cs (ImplicitConversionStandard): Move conversion of
3504 void* to arbitrary pointer types ...
3505 (ExplicitConversionStandard): .. here.
3506 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3507 error to always print typenames.
3509 2005-10-07 Raja R Harinath <rharinath@novell.com>
3511 * convert.cs (GetConversionOperator): Rename from
3512 GetConversionOperators. Move operator selection code from ...
3513 (UserDefinedConversion): ... here.
3515 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3517 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3520 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3522 * assign.cs (Assign.DoResolve): Error method changed.
3524 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3526 * const.cs (ResolveValue): Reset in_transit immediately.
3528 * constant.cs: Error method changed.
3530 * convert.cs: Removed useless location parameter.
3531 (ExplicitNumericConversion): Don't do double enum check.
3532 (ExplicitConversionCore): Renamed from ExplicitConversion.
3533 (ExplicitUnsafe): Extracted from ExplicitConversion.
3534 (ExplicitConversion): Uses for error reporting.
3536 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3538 (ResolveBoolean): Uses common error method.
3539 (CastToDecimal): Get rid of ec.
3540 (CastFromDecimal): Optimized.
3541 (ConvCast): Get rid of ec.
3543 * enum.cs (ResolveValue): Reset in_transit immediately.
3544 (Emit): Return after first error.
3546 * expression.cs: Convert changes.
3548 * literal.cs: Error method changed.
3550 * statement.cs: Error method changed.
3552 2005-10-06 Raja R Harinath <rharinath@novell.com>
3554 Fix gtest-131.cs and gtest-211.cs.
3555 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3556 Only emit code for a label if it is used. Unreachable code can
3557 violate ECMA evaluation stack invariants.
3559 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3561 * anonymous.cs: Implemented ExprClassName.
3563 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3566 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3569 * class.cs (StaticClass.DefineContainerMembers): Report protected
3572 * codegen.cs: if(ed) PRODUCTION.
3574 * convert.cs (Error_CannotImplicitConversion): Better error
3577 * cs-parser.jay: More error checks.
3579 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3581 * driver.cs (CSCParseOption): Enabled wrong option check.
3583 * ecore.cs (Expression.ExprClassName): Turned to property.
3584 (MemberExpr.CheckIntermediateModification): For checking boxed
3585 value types modification.
3587 * statement.cs (Fixed.Resolve): Expression type must be
3588 convertible to fixed type.
3589 (CollectionForeach.GetEnumeratorFilter,TryType):
3590 Small refactoring for easier error checking.
3592 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3594 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3597 * class.cs (GeneratedBaseInitializer): New class for customization
3598 compiler generated initializers.
3599 (MemberBase.DoDefine): Check Obsolete attribute here.
3600 (FieldMember.DoDefine): Ditto.
3602 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3605 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3606 (MemberCore.GetObsoleteAttribute): Removed argument.
3607 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3608 (MemberCore.CheckObsoleteType): New helper.
3612 * statement.cs: Updates after MemberCore changes.
3614 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3615 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3617 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3618 obsolete attribute for compiler construct.
3619 (As.DoResolve): Cache result.
3621 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3623 2005-10-01 Miguel de Icaza <miguel@novell.com>
3625 * expression.cs (Probe): instead of having a "Type probe_type"
3626 keep the extra information as a TypeExpr probe_type_expr since the
3627 "As" operator needs to perform some type checks.
3629 * (As.DoResolve): If the type is a type parameter, ensure that it
3630 is constrained by a class.
3632 2005-09-22 Miguel de Icaza <miguel@novell.com>
3634 * statement.cs (Lock): Use the TemporaryVariable class instead of
3635 manually using local variables as those do not work when variables
3638 * ecore.cs: Moved the TemporaryVariable class from being a nested
3639 class inside Foreach to be a public class that can be employed in
3642 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3644 * cs-parser.jay: interface_accessors replaced by
3645 accessor_declarations.
3647 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3650 * statement.cs (GotoCase.Resolve): Convert null constant to
3652 (SwitchLabel.ResolveAndReduce): Ditto.
3653 (SwitchLabel.NullStringCase): Custom null stamp.
3654 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3656 typemanager.cs (CSharpSignature): Don't skip first argument
3659 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3661 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3662 expression.cs, iterators.cs, literal.cs: Store constants and
3665 * class.cs (MemberBase.ShortName): Pass location.
3667 * cs-parser.jay: Some location fixes.
3669 * ecore.cs (Expression.Location): Made virtual.
3671 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3674 * const.cs (Const.ResolveValue): Check for assigning non-null
3675 value to reference type.
3677 2005-09-26 Raja R Harinath <rharinath@novell.com>
3680 * expression.cs (This.VerifyFixed): In a value type T, the type of
3681 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3682 value type R, 'this' is treated as a value parameter.
3684 2005-09-05 Miguel de Icaza <miguel@novell.com>
3686 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3687 if the underlying types are the same, otherwise we need to produce
3688 code that will do the proper cast.
3690 This was exposed by Marek's constant rewrite which produced
3691 invalid code for the call site:
3694 void Method (X v) {}
3698 This fixes test-49.cs
3700 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3702 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3703 Type/Object should be allowed as well. Fixed bug #75968.
3705 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3707 * expression.cs : (Binary.DoResolve): when one is enum constant and
3708 another is constant 0, then return enum one *as enum type*.
3711 2005-10-04 Martin Baulig <martin@ximian.com>
3713 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3714 `SetMemberIsUsed()' work for generics, too.
3716 2005-10-04 Martin Baulig <martin@ximian.com>
3718 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3719 for corlib. Fixes #75691.
3721 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3724 * driver.cs: Fix compilation files with full root path.
3726 2005-09-25 Miguel de Icaza <miguel@novell.com>
3728 * report.cs (SymbolRelatedToPreviousError): Format the output so
3729 it does not use an open parenthesis that is never closed.
3731 * driver.cs: Follow coding guidelines
3733 2005-09-18 Miguel de Icaza <miguel@novell.com>
3735 * driver.cs: Set InEmacs based on the environment variable EMACS.
3737 * location.cs (InEmacs): in this mode, do not report column
3738 location as it confuses Emacs.
3740 2005-10-03 Raja R Harinath <rharinath@novell.com>
3742 * support.cs (SeekableStreamReader.Position): Don't error out when
3743 the requested position is just beyond the end of the current
3746 2005-09-28 Raja R Harinath <rharinath@novell.com>
3748 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3749 try to keep in sync with the byte count of the underlying Stream.
3750 However, this limits us to a window size of 2048 characters: i.e.,
3751 the maximum lookahead of our lexer/parser can be 2048 characters.
3753 2005-09-22 Martin Baulig <martin@ximian.com>
3755 * driver.cs: Removed a debugging FIXME.
3757 2005-09-21 Raja R Harinath <rharinath@novell.com>
3759 * cs-parser.jay (type_arguments): Add CS1644 check.
3760 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3762 2005-09-15 Raja R Harinath <rharinath@novell.com>
3764 * Makefile (PROGRAM): Make profile specific.
3765 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
3766 the current directory.
3769 * expression.cs (Invocation.EmitCall): Remove optimization on
3770 this_call since it doesn't handle 'this' being a value type.
3772 2005-09-05 Geoff Norton <gnorton@customerdna.com>
3774 * driver.cs: Ensure file handles are closed after parsing
3776 2005-09-05 Miguel de Icaza <miguel@novell.com>
3778 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3779 if the underlying types are the same, otherwise we need to produce
3780 code that will do the proper cast.
3782 This was exposed by Marek's constant rewrite which produced
3783 invalid code for the call site:
3786 void Method (X v) {}
3790 This fixes test-49.cs
3792 2005-09-05 Martin Baulig <martin@ximian.com>
3794 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
3795 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
3797 * cs-parser.jay (delegate_declaration): Small fix for #75852.
3799 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3801 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
3802 to be a pointer type due to the spec 25.2, so check if declaring
3803 type is generic type definition. Fixed bug #75772.
3805 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3808 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
3809 both types are not defined by methods.
3810 * expression.cs : (Invocation.IsApplicable): it should work when
3811 the argument type is equal to the parameter type, not only when
3812 ImplicitConversionExists() returns true.
3814 2005-09-02 Raja R Harinath <rharinath@novell.com>
3816 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
3820 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
3821 flow-branching for LocalVariableReferences in case we were invoked
3822 from a MemberAccess.
3823 * expression.cs (LocalVariableReference.VerifyAssigned): New.
3825 (LocalVariableReference.DoResolveBase): ... this.
3826 (MemberAccess.Resolve): Do the check that was disabled during
3829 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3832 (PartialContainer.Create): check abstract/sealed/static strictly
3833 but abstract/sealed can exist only at one side. Fixed bug #75883.
3835 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
3838 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
3839 specified, don't default to UnmanagedType.I4.
3841 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3843 * expression.cs : conditional operator should check possibly
3844 incorrect assign expression. Fixed bug #75946.
3846 2005-08-30 Raja R Harinath <rharinath@novell.com>
3849 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
3850 (ScopeInfo.EmitScopeType): Use it to construct field names from
3851 names of captured locals.
3854 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
3855 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
3856 Pass 'target_type' to BoxedCast. Don't default to 'object'.
3857 (ExplicitConversion): Remove enum cases already handled by
3858 implicit conversion. Move implicit conversion check to the beginning.
3859 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
3860 * expression.cs (ArrayCreation.EmitDynamicInitializers):
3861 Don't treat System.Enum as a struct.
3863 2005-08-30 Jb Evain <jbevain@gmail.com>
3865 * attribute.cs: handles as expression in parameters.
3867 2005-08-30 Raja R Harinath <rharinath@novell.com>
3870 * class.cs (TypeContainer.VerifyClsName): Don't use a
3871 PartialContainer when verifying CLS compliance.
3872 (AbstractPropertyEventMethod): Set Parent here, ...
3873 (PropertyMethod): ... not here.
3875 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
3877 * attribute.cs : escaped attribute name should not be allowed to be
3878 resolved (e.g. @class as classAttribute). Fixed bug #75930.
3880 2005-08-29 Raja R Harinath <rharinath@novell.com>
3883 * convert.cs (ImplicitStandardConversionExists): Allow zero also
3884 when converting a long constant to unsigned long.
3885 * expression.cs (Invocation.OverloadResolve): Add sanity check to
3886 detect where IsApplicable and VerifyArgumentsCompat disagree.
3888 2005-08-29 Raja R Harinath <rharinath@novell.com>
3889 and Carlos Alberto Cortez <carlos@unixmexico.org>
3892 * class.cs (TypeContainer.CanElideInitializer): New helper.
3893 (TypeContainer.EmitFieldInitializers): Use it to determine if we
3894 can safely emitting the initializer of a field.
3896 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3898 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
3899 allowed inside a switch (without loop). Fixed bug #75433.
3901 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
3903 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
3904 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
3906 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3908 * driver.cs : kinda reverting the default encoding changes (not exact
3909 revert since I noticed that "codepage:reset" might not work fine).
3911 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3913 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
3914 Location. Now getter and setter store location correctly.
3915 (errors/cs0111-12.cs now reports the expected location.)
3917 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3919 * driver.cs : Use default encoding on the environment.
3920 Removed (now that) extra parameter for SeekableStreamReader.
3921 * support.cs : (SeekableStreamReader) third .ctor() argument for
3922 StreamReader is not required (always true). preamble size could
3923 be acquired in simpler and safe way.
3925 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
3927 * cs-parser.jay: report CS0642 at warning level 3
3928 and report CS0642 for an if else statement also
3929 fixes bug #74745. Patch by John Luke (and a bit
3931 Removed extra CS0642 warning check for "while",
3933 * statement.cs: In Block.Resolve(), CS0642 check
3934 is reimplemented to check a sequence of an empty
3935 statement and a block.
3937 Both fix bug #66777.
3939 2005-08-24 Marek Safar <marek.safar@seznam.cz>
3941 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
3942 detection until I fix it.
3944 * cs-tokenizer.cs: Changed error message.
3946 * cs-parser.jay: Fixed 2 error locations.
3948 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
3949 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
3952 * enum.cs (GetSignatureForError): Fixed.
3954 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
3958 * typemanager.cs (RegisterProperty): Removed.
3960 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
3962 2005-08-24 Raja R Harinath <rharinath@novell.com>
3965 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
3966 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
3968 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3970 * expression.cs : tiny fix is required for not warning positive ulong.
3973 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3975 * expression.cs : add CS0652 check for constant and integral
3976 expression. Fixed bug #53974.
3978 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3980 * expression.cs : in DoNumericPromotions(), check if there is implicit
3981 conversion overload for string (to check CS0034). Fixed bug #52492.
3983 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3985 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
3987 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3989 * ecore.cs : report location when it is *not* Null.
3991 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3997 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
3998 correctly. Fixed bug #75721.
4000 2005-08-23 Raja R Harinath <rharinath@novell.com>
4002 * support.cs (SeekableStreamReader.Position): Avoid an expensive
4003 loop that performs 'min (pos, char_count)'.
4006 * expression.cs (Unary.ResolveOperator): Don't discard implicit
4007 converted value in Operator.OnesComplement.
4009 2005-08-22 Ben Maurer <bmaurer@ximian.com>
4011 * anonymous.cs: If the anon method is pulled into a helper class,
4012 it needs to be `internal' not `private'. Fixes runtime behavior on
4015 2005-08-17 Marek Safar <marek.safar@seznam.cz>
4018 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
4021 2005-08-16 Marek Safar <marek.safar@seznam.cz>
4023 The big constants rewrite
4024 Fix #75746, #75685 and more
4025 As a side effect saved 1MB for MWF ;-)
4027 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
4028 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
4029 enum based for corlib compilation.
4031 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
4034 * class.cs (FixedField.Define): Use ResolveAsConstant.
4036 * const.cs (IConstant): Interface constants and enums.
4037 (Const.ResolveValue): New method for constant resolvning.
4038 (ExternalConstant): Constants from imported assemblies.
4040 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
4041 conversion; like enums.
4042 (Constant.ToType): Converts this constant to different type.
4043 (Constant.Increment): Adds 1.
4045 * convert.cs (ImplicitConversionRequired): Simplified.
4047 * cs-parser.jay: Create EnumMember directly.
4049 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
4051 * doc.cs (GenerateEnumDocComment): Removed.
4053 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
4054 (ConvertIntLiteral): Removed.
4055 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
4057 * enum.cs (EnumMember): Implement IConstant.
4058 (Enum.IsValidEnumConstant): Removed.
4059 (Enum.GetNextDefaultValue): Removed.
4060 (Enum.FindMembers): Updated.
4061 (Enum.GenerateDocComment): Iterate enum members.
4063 * expression.cs (Cast.TryReduce): Handle enums correctly.
4064 (New.Constantify): Made public.
4065 (MemberAccess.DoResolve): Removed contant specific if(s).
4067 * literal.cs (NullLiteral): Implement new abstract methods.
4069 * statement.cs (GotoCase.Resolve): Use new constant methods.
4070 (SwitchLabel.ResolveAndReduce): Use new constant methods.
4072 * typemanager.cs (LookupEnum): Removed.
4073 (IsEnumType): Fixed to work with corlib.
4074 (RegisterConstant): Removed.
4075 (LookupConstant): Removed.
4076 (GetConstant): Changed to work with IConstant.
4078 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
4080 * location.cs : Fixed overflown (>255) column number.
4082 2005-08-03 Raja R Harinath <rharinath@novell.com>
4084 First cut of the qualified-alias-member feature.
4085 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
4087 * cs-parser.jay (DOUBLE_COLON): New token.
4088 (namespace_or_type_name): Add rule for recognizing
4089 qualified-alias-members.
4090 (primary_expression): Likewise.
4091 (element_access): Allow QualifiedAliasMember as a possible
4092 type-bearing expression.
4093 (local_variable_type, local_variable_pointer_type): Likewise.
4094 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
4095 aliases in the current and enclosing namespace declarations.
4096 (NamespaceEntry.UsingAlias): Add CS0440 warning.
4097 * decl.cs (MemberName.is_double_colon): New.
4098 (MemberName.MemberName): Add new constructor for alias-member.
4099 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
4100 * expression.cs (QualifiedAliasMember): New expression type.
4102 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4104 * location.cs : it borked when no argument was specified.
4106 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4108 * location.cs : tiny ToString() format fix.
4110 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4112 * statement.cs : oops, it was missing.
4114 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4116 A set of fixes for precise line/column location.
4119 "token" field now holds a file/line "delta", a line number offset
4120 from the segment, and a column number. See also:
4121 http://lists.ximian.com/pipermail/mono-devel-list/2004-
4122 December/009508.html
4123 Removed static IsNull. Use instance IsNull property instead.
4125 For some tokens it stores Location. For Identifier it stores
4126 LocatedToken which is a pair of string name and location.
4127 Column numbers are adjusted only at getChar().
4129 Use Location.ToString() for reporting (it now contains column).
4131 Largely modified to use LocatedToken instead of
4132 string (IDENTIFIER), and to acquire Location from some tokens.
4133 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
4134 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
4136 Now MemberName holds Location. DeclSpace.ctor() receives Location
4137 as a parameter. Removed extra parameters to all derived classes.
4138 Replaced Location.IsNull() with instance property.
4139 * assign.cs, expression.cs :
4140 Added .ctor() overload that omits Location.
4142 Added "nameEscaped" flag that indicates the identifier was escaped
4143 in the source file. This fixes bug #57047.
4145 2005-09-02 Martin Baulig <martin@ximian.com>
4147 * class.cs: Make CS3005 a warning, not an error.
4149 2005-08-02 Marek Safar <marek.safar@seznam.cz>
4151 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
4152 New method, looking for lo-case imported cls type.
4154 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4157 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4159 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4161 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4163 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4165 Optimized to save 3.5 MB for SWF compilation.
4167 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4169 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4170 (PartialContainer.Create): Moved logic AddToContainer.
4171 (PartialContainer.MarkForDuplicationCheck): Shares name.
4173 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4176 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4178 (Namespace.GetSignatureForError): New method.
4180 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4181 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4183 2005-08-01 Raja R Harinath <rharinath@novell.com>
4186 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4187 member lookup rather than qualifier_type, since qualifier_type can
4190 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4192 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4195 2005-07-31 Miguel de Icaza <miguel@novell.com>
4197 * statement.cs: Copy the local exception into the exception
4198 captured local. Fixes 75674
4200 2005-07-31 Raja R Harinath <harinath@gmail.com>
4203 * expression.cs (Invocation.OverloadResolve): Don't report error
4204 CS1501 if error CS1502 has been reported.
4205 (New.DoResolve): Delegate CS1501 reporting to
4206 Invocation.OverloadResolve.
4209 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4210 invariant-meaning-in-block property in an enclosing block if
4213 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4215 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4216 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4217 (Switch.CheckSwitch): Just save 50kb for SWF.
4219 2005-07-27 Martin Baulig <martin@ximian.com>
4221 * anonymous.cs (CaptureContext.AddField): Added
4222 `AnonymousContainer am' argument; compute its toplevel scope if
4223 it's not already computed. Fixes #75649.
4225 2005-07-26 Raja R Harinath <rharinath@novell.com>
4228 * class.cs (Constructor.Emit): Reset block to null if the block
4231 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4233 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4235 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4237 * class.cs (MethodData.Define): Check whether accessor implementing
4238 interface is public.
4240 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4242 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4245 * namespace.cs (LookupType): Moved same type check to...
4247 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4250 2005-07-21 Raja R Harinath <rharinath@novell.com>
4252 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4253 already found a typebuilder.
4254 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4255 MemberNames, not strings.
4257 * const.cs (Error_ExpressionMustBeConst):
4258 Rename from Error_EpressionMustBeConst.
4259 * const.cs, class.cs, statement.cd: Update.
4261 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4265 * const.cs (Const.LookupConstantValue): Report missing contant expression
4267 (Error_EpressionMustBeConstant): Only one error method.
4269 * class.cs, statement.c: Updated.
4271 2005-07-20 Raja R Harinath <rharinath@novell.com>
4273 * statement.cs (Block.Flags): Add back HasVarargs.
4274 (Block.flags): Make protected.
4275 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4277 * typemanager.cs (types, typecontainers, user_types): Remove.
4278 (UserTypes, TypeContainers): Likewise.
4279 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4280 (CleanUp, Reset): Update.
4281 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4282 (GetNestedType): Use Type.GetNestedType.
4283 (CoreLookupType): Take two arguments, the namespace and the
4284 basename of the type. Update to use the Namespace.Lookup
4286 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4287 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4288 string concatenation and substring matches.
4289 * class.cs, enum.cs, delegate.cs: Update to changes.
4291 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4293 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4294 Expression and made virtual.
4296 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4297 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4299 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4301 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4304 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4307 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4310 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4311 AssemblyCultureAttribute is not used on executable.
4314 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4316 2005-07-16 Raja R Harinath <rharinath@novell.com>
4319 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4320 New. Reports CS0252/CS0253.
4321 Mostly taken from preliminary patch by Duncak Mak.
4322 (Binary.DoResolveOperator): Store results of operator lookup.
4323 Use them to detect if we need to warn about unintended reference
4326 2005-07-15 Raja R Harinath <rharinath@novell.com>
4329 * namespace.cs (Namespace.Lookup): Add back location parameter.
4330 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4331 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4333 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4334 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4335 (Namespace.LookupType): ... this.
4336 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4338 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4339 purported to handle pointers.
4340 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4343 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4345 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4348 2005-07-15 Raja R Harinath <rharinath@novell.com>
4350 * namespace.cs (Namespace.Lookup): Drop location parameter.
4351 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4352 (NamespaceEntry.Lookup): ... this.
4353 (NamespaceEntry.Error_AmbiguousTypeReference):
4354 Move here from DeclSpace.
4355 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4357 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4358 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4359 Move to NamespaceEntry.
4360 * delegate.cs, expression.cs: Update to changes.
4362 2005-08-31 Martin Baulig <martin@ximian.com>
4364 Committing a patch from Atsushi Enomoto for #75850.
4366 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4367 Prefer a generic enumerator over a non-generic one.
4369 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4371 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4372 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4374 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4376 * driver.cs : reverting default encoding change as well as mcs.
4378 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4380 * driver.cs, support.cs : merged r48826.
4382 > could you integrate your mcs changes to gmcs otherwise
4383 > gmcs cannot compile some files.
4385 2005-08-20 Martin Baulig <martin@ximian.com>
4387 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4388 scope if we don't already have it.
4390 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4391 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4394 2005-07-31 Miguel de Icaza <miguel@novell.com>
4396 * statement.cs: Copy the local exception into the exception
4397 captured local. Fixes 75674
4399 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4401 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4404 2005-08-12 Martin Baulig <martin@ximian.com>
4406 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4407 for nested types here to avoid hitting the cache too early.
4409 2005-08-09 Miguel de Icaza <miguel@novell.com>
4411 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4414 2005-08-03 Martin Baulig <martin@ximian.com>
4416 Make iterators in generic methods work; see gtest-191.cs.
4419 (Constraints.Resolve): Protect against being called twice.
4422 (TypeContainer.GetClassBases): Make this `protected virtual'.
4424 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4425 (Iterator.GetClassBases): Override this and compute the base
4427 (Iterator.DefineNestedTypes): If we're a generic method, all our
4428 method type parameters become class type parameters on the proxy
4432 (ToplevelBlock.Parameters): Make this a property, not a field.
4433 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4435 2005-08-03 Martin Baulig <martin@ximian.com>
4437 * typemanager.cs (TypeManager.IsSubclassOf): Use
4438 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4439 (TypeManager.GetFullName_recursed): Improved.
4441 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4444 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4445 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4446 invocation_type == mi.DeclaringType, since the first one also checks
4447 other condition used by generic instances.
4449 2005-07-27 Martin Baulig <martin@ximian.com>
4451 * anonymous.cs (CaptureContext.AddField): Added
4452 `AnonymousContainer am' argument; compute its toplevel scope if
4453 it's not already computed. Fixes #75649.
4455 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4457 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4458 CheckAttributeType and refactored.
4459 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4460 ResolveAsTypeTerminal error handling.
4461 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4463 (GetSignatureForError): Print errors in same way.
4466 * codegen.cs: Reflect attribute GetSignatureForError change.
4469 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4471 * namespace.cs (UsingEntry): Refactored to make fields private.
4474 statement.cs: Error_UnexpectedKind has extra parameter.
4476 2005-07-14 Raja R Harinath <rharinath@novell.com>
4478 * ecore.cs (IAlias): Remove.
4479 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4480 that implement the interface.
4481 * namespace.cs (Namespace): Likewise.
4482 (Namespace.declspaces): Renamed from 'defined_names'.
4483 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4484 DeclSpace instead of an IAlias.
4485 * tree.cs (Tree.AddDecl): Update.
4487 2005-07-12 Raja R Harinath <rharinath@novell.com>
4489 * statement.cs (Block.Flags); Remove HasVarargs.
4490 (Block.HasVarargs): Move to ToplevelBlock.
4491 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4492 (Block.Variables): Make protected. Initialize variable hashtable
4494 (Block.AddVariable): Update.
4495 (Block.Resolve): Update to changes.
4496 (ToplevelBlock.HasVarargs): New boolean.
4497 (ToplevelBlock.ThisVariable): Move here from Block.
4498 (ToplevelBlock.AddThisVariable): Likewise.
4499 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4500 * expression.cs (This.ResolveBase): Update to changes.
4501 (ArglistAccess.DoResolve): Likewise.
4503 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4506 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4508 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4509 not used and not used & assigned.
4510 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4512 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4515 * expression.cs (Is.DoResolve): null is never provided type.
4517 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4520 * cs-parser.jay: Less strict event error rule to catch more errors.
4522 2005-07-11 Martin Baulig <martin@ximian.com>
4524 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4525 for the constructor constraint: we do not only have to check
4526 whether the class has a public constructor, but also ensure that
4527 it's parameterless. Fixes #75492.
4529 2005-07-11 Martin Baulig <martin@ximian.com>
4531 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4532 between type parameters if they either have the reference type
4533 constraint or the class constraint.
4535 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4537 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4539 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4542 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4543 (ExtractSecurityPermissionSet): Cope with self referencing security
4544 attributes properly.
4546 * driver.cs (SetOutputFile): Made public property OutputFile.
4548 2005-07-07 Raja R Harinath <rharinath@novell.com>
4551 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4552 has_nonstatic_fields. Make into a FieldBase pointer.
4553 (TypeContainer.AddField): Add CS0282 check.
4554 (TypeContainer.EmitType): Update.
4556 2005-07-06 Miguel de Icaza <miguel@novell.com>
4558 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4559 compare if they start with __.
4561 2005-07-06 Raja R Harinath <rharinath@novell.com>
4563 * statement.cs (Switch.SwitchGoverningType): Only look at
4564 UserCasts that don't need implicit standard conversions to one of
4565 the allowed switch types (Fixes test-322.cs).
4566 (LocalInfo.Resolve): Re-enable sanity-test.
4568 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4570 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4572 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4574 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4576 2005-07-06 Raja R Harinath <rharinath@novell.com>
4579 * ecore.cs (SimpleName.GetSignatureForError): Add.
4580 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4581 (MemberAccess.GetSignatureForError): Add.
4583 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4585 The big error and warning messages review.
4615 * typemanager.cs: Updated.
4617 * class.cs: (MethodCore.SetYields): Moved here to share.
4618 (PropertyMethod.Define): Moved iterator setup here.
4620 * iterators.cs: Add orig_method to have full access to parent
4623 2005-07-05 Raja R Harinath <rharinath@novell.com>
4625 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4626 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4627 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4628 variable of struct type.
4629 * expression.cs (Unary.ResolveOperator): Update to change.
4630 (Indirection.VerifyFixed): Likewise.
4631 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4632 (ParameterReference.VerifyFixed): Value parameters are fixed.
4633 (This.VerifyFixed): Treat 'this' as a value parameter.
4634 * statement.cs (LocalInfo.IsFixed): Remove.
4636 2005-07-01 Martin Baulig <martin@ximian.com>
4638 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4639 `ec.EmitThis ()' to get the correct scope.
4641 2005-07-01 Martin Baulig <martin@ximian.com>
4643 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4644 instance is a ParameterReference; fixes #75299.
4646 2005-06-30 Raja R Harinath <rharinath@novell.com>
4649 * expression.cs (Indexers.map): Remove.
4650 (Indexers.Append): Filter out inaccessible setters and getters.
4651 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4654 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4656 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4657 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4658 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4659 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4661 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4664 * class.cs (FieldBase.GetInitializerExpression): One more field
4667 2005-06-28 Miguel de Icaza <miguel@novell.com>
4669 * pending.cs: Do not define a proxy if the base method is virtual,
4670 it will be picked up by the runtime (bug 75270).
4672 2005-07-08 Martin Baulig <martin@ximian.com>
4674 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4675 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4677 2005-07-07 Martin Baulig <martin@ximian.com>
4679 * generic.cs (ConstructedType.CheckConstraint): Use
4680 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4681 called recursively; fixes #75329.
4683 2005-07-06 Martin Baulig <martin@ximian.com>
4685 * generic.cs (TypeManager.InferTypeArguments): Added support for
4686 anonymous methods; fixes #75461.
4688 2005-07-01 Martin Baulig <martin@ximian.com>
4690 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4691 `ec.EmitThis ()' to get the correct scope.
4693 2005-07-01 Martin Baulig <martin@ximian.com>
4695 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4696 instance is `This'; fixes #75299.
4698 2005-06-30 Martin Baulig <martin@ximian.com>
4700 * class.cs (Indexer): Implement IIteratorContainer; added support
4701 for iterators in indexers.
4704 (EmitContext.CurrentIterator): Make this a property, not a field.
4706 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4708 2005-06-28 Miguel de Icaza <miguel@novell.com>
4710 * pending.cs: Do not define a proxy if the base method is virtual,
4711 it will be picked up by the runtime (bug 75270).
4713 2005-06-28 Martin Baulig <martin@ximian.com>
4715 * cs-parser.jay (interface_method_declaration): Avoid a
4716 reduce/reduce conflict by moving some of the code into a separate
4717 `interface_method_declaration_body' rule; fixes #75368.
4719 2005-06-28 Martin Baulig <martin@ximian.com>
4721 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4722 array check after the check for TypeBuilder's.
4724 2005-06-21 Raja R Harinath <rharinath@novell.com>
4726 * convert.cs (FindMostEncompassedType): Add two trivial special
4727 cases (number_of_types == 0 || number_of_types == 1).
4728 (FindMostEncompasingType): Likewise.
4730 2005-06-17 Raja R Harinath <rharinath@novell.com>
4732 Some cleanups preparing for the fix of #75283.
4733 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4735 (EventExpr.InstanceResolve): Likewise.
4736 (EventExpr.DoResolve): Remove redundant checks.
4738 2005-06-08 Miguel de Icaza <miguel@novell.com>
4740 * class.cs: Small fix.
4742 2005-06-08 Raja R Harinath <rharinath@novell.com>
4745 * class.cs (GetPartialBases): Fix return value check of
4748 2005-06-07 Raja R Harinath <rharinath@novell.com>
4750 Ensure that partial classes are registered in their enclosing
4751 namespace. Initial part of fix of #75160.
4752 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4753 Register declspace with namespace here, not in
4754 DeclSpace.RecordDecl.
4755 * cs-parser.jay: Pass namespace to RecordDecl.
4756 * class.cs (PartialContainer.Create): Likewise.
4757 (ClassPart.DefineType): New sanity-check. Throws an exception if
4759 * decl.cs (Declspace.RecordDecl): Remove.
4760 * namespace.cs (NamespaceEntry.DefineName): Remove.
4762 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4764 * rootcontext.cs: Reset TargetExt as well.
4766 2005-06-03 Raja R Harinath <rharinath@novell.com>
4768 * ecore.cs (Expression.Resolve): Emit CS0654 error when
4771 2005-06-02 Raja R Harinath <rharinath@novell.com>
4773 Fix #75080, cs0119.cs.
4774 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
4776 (Expression.Resolve): ... this. Use it. Remove bogus code
4777 allowing ExprClass.Type and ExprClass.Namespace for
4778 ResolveFlags.VariableOrValue.
4779 (Expression.Resolve) [1-argument variant]: Change default resolve
4780 flags based on language version.
4781 (Expression.Error_UnexpectedKind): Use a simple string array
4782 rather than an ArrayList.
4783 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
4785 (TypeOfVoid.DoResolve): Likewise.
4786 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
4787 flags argument -- it always has the same value.
4789 2005-05-31 Raja R Harinath <rharinath@novell.com>
4792 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
4793 Use it in the error message.
4794 * assign.cs, expression.cs, statement.cs: Update.
4796 2005-05-30 Raja R Harinath <rharinath@novell.com>
4799 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
4800 the "almostMatchedMember" case too.
4801 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
4802 that failed the accessibility checks to 'almost_match'.
4804 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
4806 * attribute.cs: Use internal MethodBuilder methods to set
4807 ExactSpelling and SetLastError on PInvoke methods, instead
4808 of passing them via charset. Fixes #75060.
4810 2005-05-27 Raja R Harinath <rharinath@novell.com>
4812 * parameter.cs (Parameter): Remove TODO comment.
4813 (Parameter.DefineParameter): Remove Location parameter.
4814 (Parameters.LabelParameters): Likewise.
4815 * class.cs (Constructor.Emit): Update to change.
4816 (MethodData.Emit): Likewise.
4817 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
4818 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
4820 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
4823 Removed Parameters.Location and added Parameter.Location instead.
4824 Removed Location parameter from Emit() and GetSignature().
4831 Modified all related calls.
4833 2005-06-21 Martin Baulig <martin@ximian.com>
4835 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
4836 left-hand side is not a nullable type; fixes #75328.
4838 2005-06-21 Martin Baulig <martin@ximian.com>
4841 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
4842 (TypeManager.GetFullNameSignature): Likewise.
4844 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
4845 `source.FullName' and `target.FullName' to check whether there are
4846 two conflicting definitions.
4848 2005-06-21 Martin Baulig <martin@ximian.com>
4850 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
4851 a BoxedCast - also for reference types - to be compatible with csc.
4853 2005-06-21 Martin Baulig <martin@ximian.com>
4855 * expression.cs (MemberAccess.DoResolve): Add support for nested
4856 types in a generic instance; fixes #75320.
4858 2005-06-20 Martin Baulig <martin@ximian.com>
4860 * generic.cs (TypeManager.InferType): Also walk the class
4861 hierarchy for generic instances; fixes #75261.
4863 2005-06-17 Martin Baulig <martin@ximian.com>
4865 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
4866 to make things work for corlib.
4868 2005-06-15 Martin Baulig <martin@ximian.com>
4870 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
4871 obsolete `SecurityAction' values.
4873 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4875 * rootcontext.cs: Reset TargetExt as well.
4877 2005-06-09 Martin Baulig <martin@ximian.com>
4879 * delegate.cs (Delegate.VerifyMethod): Added
4880 `MethodGroupExpr old_mg' argument; inherit its
4881 `HasTypeParameters'; fix #75085.
4883 2005-06-09 Martin Baulig <martin@ximian.com>
4885 * expression.cs (Invocation.OverloadResolve): Correctly handle
4886 generic methods for the SetMemberIsUsed(); fix #75064.
4888 2005-06-09 Martin Baulig <martin@ximian.com>
4890 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
4893 2005-06-08 Martin Baulig <martin@ximian.com>
4895 * cs-parser.jay (nullable_type_or_conditional): If we put the
4896 nullable back and our `type' is a `ComposedCast', remove the
4897 nullable from it. Fixes #75156.
4899 * expression.cs (ComposedCast.RemoveNullable): New public method.
4901 2005-06-08 Martin Baulig <martin@ximian.com>
4903 The big Iterators rewrite :-)
4905 * iterators.cs: Rewrite this to use the anonymous methods framework.
4907 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
4908 before the TypeContainers; see 2test-21.cs.
4911 (TypeContainer.DefineType): Don't create a new EmitContext if we
4912 already have one (this only happens if we're an Iterator).
4913 (TypeContainer.Define): Also call Define() on all our iterators.
4914 (Method.CreateEmitContext): Added support for iterators.
4917 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
4918 (AnonymousContainer.CreateMethodHost): Moved here from
4919 AnonymousMethod and made abstract.
4920 (AnonymousContainer.CreateScopeType): New abstract method.
4921 (AnonymousContainer.IsIterator): New public property.
4922 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
4923 get the ScopeTypeBuilder rather than manually defining it here.
4924 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
4927 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
4928 before RootContext.DefineTypes().
4930 * codegen.cs (EmitContext.RemapToProxy): Removed.
4931 (EmitContext.CurrentAnonymousMethod): Changed type from
4932 AnonymousMethod -> AnonymousContainer.
4933 (EmitContext.ResolveTopBlock): Protect from being called twice.
4934 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
4935 (EmitContext.EmitThis): Removed the iterators hacks; use the
4936 anonymous methods framework for that.
4939 (ToplevelBlock.Container): Make this a property, not a field.
4940 (ToplevelBlock.ReParent): New public method; move the
4941 ToplevelBlock into a new container.
4942 (Foreach.TemporaryVariable): Simplify.
4944 2005-06-05 Martin Baulig <martin@ximian.com>
4946 * statement.cs (LocalInfo.CompilerGenerated): New flag.
4947 (Block.AddTemporaryVariable): New public method; creates a new
4948 `LocalInfo' for a temporary variable.
4949 (Block.EmitMeta): Create the LocalBuilders for all the temporary
4951 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
4952 non-iterator variables.
4954 2005-06-05 Martin Baulig <martin@ximian.com>
4956 * statement.cs (Foreach.TemporaryVariable): Create the
4957 LocalBuilder in the Emit phase and not in Resolve since in some
4958 situations, we don't have an ILGenerator during Resolve; see
4959 2test-19.cs for an example.
4961 2005-06-04 Martin Baulig <martin@ximian.com>
4963 The big Foreach rewrite - Part II.
4965 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
4966 with `PropertyInfo ienumerator_getcurrent'.
4968 * codegen.cs (VariableStorage): Removed.
4971 (Foreach): Derive from Statement, not ExceptionStatement.
4972 (Foreach.CollectionForeach): New nested class. Moved all the code
4973 dealing with collection foreach here.
4974 (Foreach.ForeachHelperMethods): Removed.
4975 (Foreach.TemporaryVariable): Implement IMemoryLocation.
4977 2005-05-23 Martin Baulig <martin@ximian.com>
4979 * statement.cs (Try.DoResolve): Don't create a `finally' if we
4980 don't need to. Fix #75014.
4982 2005-05-26 Raja R Harinath <rharinath@novell.com>
4984 Improve user-defined conversion handling.
4985 * convert.cs (GetConversionOperators): Rewrite. Return only the
4986 applicable operators.
4987 (AddConversionOperators): New. Helper for GetConversionOperators.
4988 (FindMostEncompassedType, FindMostEncompassingType): Verify that
4989 there is only one most encompassed/encompassing type.
4990 (FindMostSpecificSource, FindMostSpecificTarget): Remove
4991 "applicable operator" handling.
4992 (UserConversion): Move cache here from GetConversionOperators.
4993 Directly cache the chosen operator, rather than the whole
4995 (ExplicitNumericConversion): Fix buggy implementation of Decimal
4996 case. Allow conversion of decimal to sbyte and byte too.
4997 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
4998 New static methods. Used to avoid allocating EmptyExpressions in
5001 2005-05-24 Duncan Mak <duncan@novell.com>
5003 * ecore.cs (CastFromDecimal): New class for casting a decimal to
5004 another class, used in Convert.ExplicitNumericConversion.
5005 (CastToDecimal): New class, similar to above, but casts to
5006 System.Decimal, used in Convert.ImplicitNumericConversion and also
5007 in explicit convesion from double/float to decimal.
5009 * convert.cs (ImplicitNumericConversion): Handle implicit
5010 conversions to System.Decimal.
5011 (ExplicitNumericConversion): handle explicit conversions to
5016 2005-05-20 Miguel de Icaza <miguel@novell.com>
5018 * typemanager.cs: Do not throw an exception in the TypeBuilder
5019 case, we take care of it on the TypeCode.
5021 2005-05-17 Marek Safar <marek.safar@seznam.cz>
5023 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
5026 * cs-parser.jay: Catch more lexical errors.
5028 * report.cs: Add one more Error method.
5031 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
5033 2005-05-20 Martin Baulig <martin@ximian.com>
5035 * class.cs (TypeContainer.CircularDepException): Removed.
5036 (TypeContainer.DefineType): Removed the `InTransit' stuff.
5037 (TypeContainer.CheckRecursiveDefinition): Check for circular class
5038 (CS0146) and interface (CS0529) dependencies here.
5040 2005-05-20 Martin Baulig <martin@ximian.com>
5042 * expression.cs (New.DoResolve): Move the CS0712 check above the
5043 CS0144 check; otherwise it can never be reached.
5045 2005-05-20 Martin Baulig <martin@ximian.com>
5047 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
5049 2005-05-20 Martin Baulig <martin@ximian.com>
5051 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
5053 * typemanager.cs (TypeManager.IsAttributeType): New public method.
5055 2005-05-19 Martin Baulig <martin@ximian.com>
5058 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
5059 to disable error reporting.
5061 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
5062 here since we don't want to report an error; see the new test-336.cs.
5064 2005-05-19 Raja R Harinath <rharinath@novell.com>
5066 * statement.cs (ToplevelBlock.GetParameterReference)
5067 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
5068 Move here from class Block.
5069 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
5070 * expression.cs (ParameterReference.DoResolveBase): Likewise.
5072 2005-05-18 Martin Baulig <martin@ximian.com>
5077 (FlowBranching.Reachability): Add non-static public And() and Or()
5079 (FlowBranchingSwitch): New class; do the `break_origins' thing
5080 like in FlowBranchingLoop.
5081 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
5082 reachability, not just locals and parameters.
5083 (FlowBranching.MergeChild): Remove some of the hacks for loop and
5084 switch; MergeBreakOrigins() now takes care of that.
5086 2005-05-18 Martin Baulig <martin@ximian.com>
5088 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
5089 a loop and may leave it, reset the barrier; fixes #74974.
5091 2005-05-16 Raja R Harinath <rharinath@novell.com>
5093 Fix test-382.cs. Emit values of decimal constants.
5094 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
5096 (TypeContainer.AddField): ... this.
5097 (TypeContainer.EmitFieldInitializers): Allow the list of fields
5098 with initializers to include 'Const's.
5099 (ClassPart.RegisterFieldForInitialization): Forward to
5101 * const.cs (Const.Const): Pass initializer to base class.
5102 (Const.Define): In case of decimal constants, register them for
5103 initialization in a static constructor.
5105 2005-05-14 Martin Baulig <martin@ximian.com>
5107 * statement.cs (Block.Resolve): Correctly handle unreachable code;
5108 do not call ResolveUnreachable() on unreachable statements in
5109 here, see the comment in the source code.
5111 2005-05-13 Raja R Harinath <rharinath@novell.com>
5114 * expression.cs (BinaryResolveOperator): If one of the operands of
5115 an equality comparison is 'null' and the other is a pointer type,
5116 convert the null to a NullPointer.
5117 * convert.cs (ImplicitReferenceConversion): If the expression is a
5118 NullLiteral and the target type is a pointer type, return a
5119 NullPointer instead.
5120 (ImplicitConversionStandard): Likewise.
5122 2005-05-13 Marek Safar <marek.safar@seznam.cz>
5124 * cs-parser.jay: Set readonly context based on special constructs.
5126 * expression.cs (LocalVariableReference.DoResolveBase): Improved
5127 readonly variable error handling.
5129 * rootcontext.cs (EmitCode): Don't verify members when error
5132 * statement.cs (LocalInfo): Add reaodnly context information.
5133 (SetReadOnlyContext, GetReadOnlyContext): New methods.
5135 2005-05-17 Martin Baulig <martin@ximian.com>
5137 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
5140 2005-05-13 Martin Baulig <martin@ximian.com>
5142 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
5143 handle unreachable blocks.
5145 2005-05-13 Martin Baulig <martin@ximian.com>
5148 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
5149 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
5152 2005-05-13 Martin Baulig <martin@ximian.com>
5154 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5155 instance variable, not a local. Fix #74873.
5156 (Block.ResolveUnreachable): Set it to true here.
5158 2005-05-12 Martin Baulig <martin@ximian.com>
5160 * cs-parser.jay (property_declaration): Pass the `current_class',
5161 not the `current_container' to Property's .ctor. Fixes #74912.
5163 2005-05-11 Martin Baulig <martin@ximian.com>
5165 * typemanager.cs (Closure): Copy this from MCS and merge all the
5166 GMCS-specific changes into it.
5168 2005-05-12 Raja R Harinath <harinath@gmail.com>
5171 * typemanager.cs (unmanaged_enclosing_types): New.
5172 (IsUnmanagedType): Avoid infloops by using
5173 'unmanaged_enclosing_types' to talk with recursive invocations.
5175 2005-05-11 Duncan Mak <duncan@novell.com>
5177 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5178 continuing to process for 'arg'.
5179 (handle_preprocessing_directive): Check the argument of the #endif
5180 directive and report error CS1025 if there are any trailing
5183 According to the C# spec, having even whitespace after the #endif
5184 directive is illegal; however, because we call arg.TrimEnd ()
5185 beforehand, we have the same behavior as csc, allowing whitespace
5186 after the directive.
5190 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5194 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5195 (Constructor.GetObsoleteAttribute): Implemented correctly.
5197 2005-05-10 Martin Baulig <martin@ximian.com>
5199 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5200 resolve the type; fixes #74864.
5201 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5202 in DoResolve(); fixes #74862.
5204 2005-05-10 Martin Baulig <martin@ximian.com>
5206 * support.cs (ReflectionParameters.ParameterModifier): Use
5207 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5208 and `ParameterAttributes.In'. Fixes #74884.
5210 2005-05-10 Martin Baulig <martin@ximian.com>
5212 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5213 the cache if we're just looking for `MemberTypes.NestedType' in a
5216 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5217 constraints if we're still resolving the type tree.
5218 (Expression.MemberLookup): If we're resolving the type tree, only
5219 look for `MemberTypes.NestedType' since we're only interested in
5222 * class.cs (TypeContainer.DefineType): Don't resolve the type
5223 parameters here; do this later in ResolveType() after the type
5224 tree has been resolved.
5225 (TypeContainer.ResolveType): New public method; this is called
5226 after the type tree is resolved and before the types are being
5227 populated. We resolve the generic constraints here.
5228 (TypeContainer.DoDefineMember): Check the constraints on our base
5229 class and interfaces.
5231 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5232 set the `ResolvingTypeTree' flag on the EmitContext.
5234 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5236 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5238 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5240 * expression.cs (Argument.GetParameterModifier): Turned to property.
5241 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5243 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5246 2005-05-09 Raja R Harinath <rharinath@novell.com>
5249 * decl.cs (MemberCache.AddMethods): Register override methods,
5250 rather than non-override methods.
5251 * typemanager.cs (RegisterOverride): New.
5252 (IsOverride): Update.
5254 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5256 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5258 2005-05-06 Martin Baulig <martin@ximian.com>
5261 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5262 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5264 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5268 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5269 recursive declaration.
5271 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5273 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5275 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5277 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5279 2005-05-05 Raja R Harinath <rharinath@novell.com>
5282 * decl.cs (DeclSpace.FamilyAccessible):
5283 Use TypeManager.IsNestedFamilyAccessible.
5285 Fix reopened #64812.
5286 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5289 2005-05-04 Raja R Harinath <rharinath@novell.com>
5290 Abin Thomas <projectmonokochi@rediffmail.com>
5291 Anoob V E <projectmonokochi@rediffmail.com>
5292 Harilal P R <projectmonokochi@rediffmail.com>
5295 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5296 allow access to all static members.
5298 2005-05-04 Martin Baulig <martin@ximian.com>
5300 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5302 2005-05-04 Martin Baulig <martin@ximian.com>
5306 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5307 section at the end; make things work if `default' is not the last
5310 2005-05-04 Martin Baulig <martin@ximian.com>
5314 * statement.cs (Switch): Replaced the `got_default' field with a
5315 `default_section' one.
5316 (Switch.CheckSwitch): Set `default_section' here.
5317 (Switch.Resolve): If we're a constant switch and the constant is
5318 not found, use the default section.
5320 2005-05-03 Martin Baulig <martin@ximian.com>
5322 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5324 * statement.cs (Foreach.ArrayForeach): New nested class.
5325 (Foreach.TemporaryVariable): New nested class.
5326 (Foreach.EmitArrayForeach): Removed; this is now in the new
5329 2005-05-03 Raja R Harinath <rharinath@novell.com>
5331 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5333 (VerifyPendingMethods): Revert change below.
5335 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5336 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5337 that used to trigger warning -28. Remove warning -28.
5338 * expression.cs (Invocation.OverloadResolve): Use
5339 TypeManager.IsOverride to distinguish override methods.
5342 * pending.cs (VerifyPendingMethods): If a base type implements the
5343 requested interface, don't bother checking individual methods of
5344 the base type. As a side-effect, this prevents the creation of
5345 unnecessary proxies.
5347 2005-05-02 Martin Baulig <martin@ximian.com>
5351 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5352 Also `And' the locals if the old vector is null.
5353 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5354 null; in this case we basically reset all the variables.
5356 2005-05-02 Martin Baulig <martin@ximian.com>
5360 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5361 Added `FlowBranching branching' argument; always `and' the
5362 variables instead of `or'ing them unless we're an infinite loop.
5364 * statement.cs (While.Resolve): Create a new sibling unless we're
5367 2005-05-02 Martin Baulig <martin@ximian.com>
5371 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5372 arguments; use it instead of creating a new TopLevelBlock.
5373 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5374 our ConstructorInitializer.
5377 (TopLevelBlock.TopLevelBranching): New public property.
5378 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5379 and create our `TopLevelBranching'.
5381 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5382 anonymous method host, use `block.TopLevelBranching' rather than
5383 creating a new branching.
5385 2005-04-20 Miguel de Icaza <miguel@novell.com>
5387 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5388 a ScopeInfo, if any of the current children is a child of the new
5389 entry, move those children there.
5391 2005-04-30 Martin Baulig <martin@ximian.com>
5393 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5394 at the beginning of a SwitchSection. Fix #73335.
5396 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5399 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5401 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5402 (FieldExpr.DoResolve): Obsolete members are ignored for field
5405 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5407 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5408 of arrays detection.
5410 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5412 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5414 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5417 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5419 * cs-parser.jay: Use the prefered version of -unsafe in error
5422 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5424 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5427 2005-04-20 John Luke <john.luke@gmail.com>
5429 * driver.cs: fix typo in error message, --outout to --output
5431 2005-04-30 Martin Baulig <martin@ximian.com>
5433 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5434 handle the .NET 2.x security attributes.
5436 2005-04-30 Martin Baulig <martin@ximian.com>
5439 (TypeManager.ExpandInterfaces): Don't add things twice.
5442 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5444 2005-04-29 Martin Baulig <martin@ximian.com>
5446 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5448 * anonymous.cs: Added support for anonymous generic methods.
5450 2005-04-29 Martin Baulig <martin@ximian.com>
5452 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5455 2005-04-29 Martin Baulig <martin@ximian.com>
5457 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5459 * expression.cs (New.DoResolve): Fix the CS0304 check.
5461 2005-04-29 Martin Baulig <martin@ximian.com>
5463 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5466 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5467 explicit interface implementation, compare the interface types.
5468 (MethodData.Define): Use the new naming scheme from the latest
5470 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5472 * decl.cs (MemberName.GetMemberName): Removed.
5473 (MemberName.MethodName, FullName): New properties.
5475 2005-04-25 Raja R Harinath <rharinath@novell.com>
5477 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5479 2005-04-22 Martin Baulig <martin@ximian.com>
5481 * generic.cs (GenericMethod): Create the EmitContext in the
5482 `Define()'; in `Define(MethodBuilder)', create the type parameters
5483 before calling `Define()'. Fixes #73933.
5485 2005-04-22 Martin Baulig <martin@ximian.com>
5488 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5489 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5491 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5492 ConstructedType, check its constraints.
5494 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5496 * codegen.cs (InRefOutArgumentResolving): New field.
5498 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5499 fields outside contructor.
5501 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5503 2005-04-19 Miguel de Icaza <miguel@novell.com>
5505 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5506 parameter code was not completed ever, so it was not as up-to-date
5507 as local variables. Must finish it.
5509 The bug fix was to compare the Toplevel of the block, not the
5510 current block. Thanks for Ben for pointing this out.
5512 2005-04-19 Raja R Harinath <rharinath@novell.com>
5514 * decl.cs (AddMethods): Use the declaring type of the problem
5515 method to determine if we want to squash a warning.
5517 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5519 * attribute.cs: Removed debug output.
5521 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5523 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5526 2005-04-18 Raja R Harinath <rharinath@novell.com>
5529 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5530 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5531 all null comparisons against reference types.
5533 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5536 * class.cs (TypeContainer.CircularDepException) New nested
5538 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5539 (TypeContainer.DefineType): Removed error, reset InTransit before
5541 (Class.DefineType): Throw exception when is in Transit.
5542 Catch exception and report error.
5543 (Struct.DefineType): Throw exception when is in Transit.
5544 Catch exception and report error.
5545 (Interface.DefineType): Throw exception when is in Transit.
5546 Catch exception and report error.
5548 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5549 handle nested exception handlers.
5551 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5554 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5555 InFinally and InCatch storage.
5557 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5558 (Catch.Resolve): Set and Restore ec.InCatch.
5559 (Try.Resolve): Set and Restore ec.InFinally.
5560 (Try.HasCatch): True when try has catch.
5562 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5564 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5565 for the same event member, so exclude such cases from warning 419.
5568 2005-04-16 Miguel de Icaza <miguel@novell.com>
5570 * expression.cs (Binary.ResolveOperator): Apply patch from John
5571 Luke to fix bug 59864: operators &, | and ^ on enumerations
5572 require that the same enum type on both sides.
5574 * driver.cs: Add warnings to old flag usage, this is to assist
5575 people who produce Makefiles and hope that the Makefiles will be
5578 * class.cs (TypeContainer.EmitType): Moved the definition of the
5579 special $PRIVATE$ field from the resolve phase to the Emit phase.
5580 During resolve we do not know if we are a struct with
5581 HasExplicitLayout, we know this only after the attributes for the
5584 Set the FieldOffset to zero on the dummy field that we create for
5585 the class. Fixes 74590.
5587 2005-04-16 Raja R Harinath <rharinath@novell.com>
5590 * ecore.cs (PropertyExpr.resolved): New.
5591 (DoResolve): Use it to handle a case of double resolution here.
5592 Handle a case of identical-name-and-type-name.
5593 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5594 resolution by storing the results of expression resolution back
5595 into the "probes" array.
5597 2005-04-15 Raja R Harinath <rharinath@novell.com>
5599 Fix cs0208-7.cs and cs0208-8.cs.
5600 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5601 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5602 error reporting to point out the reason a struct is not unmanaged.
5604 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5606 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5607 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5609 2005-04-13 Raja R Harinath <rharinath@novell.com>
5612 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5613 IdenticalNameAndTypeName here.
5614 (EventExpr.InstanceResolve): Likewise.
5616 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5618 C# 2.0 DefaultCharSetAttribute implementation
5620 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5621 which allows us to set GlobalNamespace for every resolve.
5622 (Attribute.ResolveArguments): Cut from Resolve.
5623 (Attribute.GetCharSetValue): Returns CharSet named argument.
5624 (Attribute.DefinePInvokeMethod): Gets default charset from
5626 (GlobalAttribute.ResolveAsTypeStep): Override.
5627 (GlobalAttribute.ResolveArguments): Override.
5629 * class.cs (TypeAttr): Is protected.
5631 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5632 (ModuleClass.DefaultCharSetType): New memeber.
5633 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5635 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5636 charset from module.
5638 * delegate.cs (TypeAttr): Override.
5639 (Delegate.DefineType): Use this TypeAttr.
5641 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5642 at very early stage (before types are defined) to resolve model
5643 module attributes. It will probably not work with corlib but it
5646 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5647 charset from module.
5649 * typemanager.cs (default_charset_type): New type.
5651 2005-04-13 Raja R Harinath <rharinath@novell.com>
5653 * decl.cs (MemberCache.AddMethods): Don't warn if
5654 System.Object.Finalize has buggy MethodAttributes.
5656 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5659 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5661 * doc.cs : detect ambiguous reference to overloaded members.
5662 Fixed bug #71603. MS 1.1 csc does not detect it.
5664 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5666 * doc.cs : delegates must not be referenced with parameters.
5669 2005-04-12 Miguel de Icaza <miguel@novell.com>
5671 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5673 2005-04-10 Miguel de Icaza <miguel@novell.com>
5675 * driver.cs (MainDriver): Stop processing if the CLS stage found
5678 (CompilerCallableEntryPoint.InvokeCompiler): Always
5679 reset after execution; Take a TextWriter argument for the
5682 * report.cs: Use the error stream instead of hardcoding stderr.
5684 2005-04-09 Miguel de Icaza <miguel@novell.com>
5686 * class.cs: Reduce code paths to test, too small of an
5687 optimization to make it worth the extra testing. Always perform
5690 2005-04-08 Raja R Harinath <rharinath@novell.com>
5693 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5694 operators that had errors reported on them.
5696 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5698 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5700 (Attribute.Resolve): Add named argument type checking.
5702 * class.cs (FixedField.Define): Use IsPrimitiveType
5704 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5706 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5707 unsafe parameter types.
5709 * statement.cs (Using.ResolveExpression): Add better error description.
5711 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5713 2005-04-08 Raja R Harinath <rharinath@novell.com>
5716 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5717 AttributeUsageAttribute in the emitcontext of the attribute class,
5718 not in the emitcontext of the attributable entity it was attached to.
5719 * cs-parser.jay: Use 'current_class', not 'current_container',
5720 when creating a GlobalAttribute.
5722 2005-04-08 Alp Toker <alp@atoker.com>
5724 * pending.cs: The fix to #58413 failed to compile methods implementing
5725 interfaces with/without params modifiers and vice versa, even though
5726 params modifiers aren't part of the signature. Make the modifier check
5727 less strict as in csc.
5729 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5730 Anoob V E <projectmonokochi@rediffmail.com>
5731 Harilal P R <projectmonokochi@rediffmail.com>
5734 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5735 modifiers of pending methods.
5736 (PendingImplementation.PendingImplementation): Initialize it.
5737 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5738 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5739 with ParameterData. Add check for modifiers.
5740 * class.cs (MethodData.Define): Update to changes.
5742 2005-04-07 Raja R Harinath <rharinath@novell.com>
5744 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5746 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5748 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5751 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5754 * typemanager.cs: Registered RequiredAttributeAttribute.
5756 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5758 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5759 Warning CS0169 is back at level 3.
5760 (IMethodData.SetMemberIsUsed): New method.
5762 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5763 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
5765 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
5767 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
5769 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
5772 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
5775 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
5776 to avoid the problems with nested types.
5778 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
5779 Anoob V.E <projectmonokochi@rediffmail.com>
5780 Harilal P.R <projectmonokochi@rediffmail.com>
5781 Raja R Harinath <rharinath@novell.com>
5784 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
5786 * typemanager (GetConstructor): Make public.
5788 2005-04-05 John Luke <john.luke@gmail.com>
5789 Raja R Harinath <rharinath@novell.com>
5792 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
5793 struct too. Return false quicker in a few cases.
5794 (VerifyUnManaged): Use it.
5796 2005-04-05 Raja R Harinath <rharinath@novell.com>
5799 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
5800 not 'unreachable_seen'.
5802 2005-04-04 Marek Safar <marek.safar@seznam.cz>
5804 * attribute.cs (Attribute.GetValue): Removed unused.
5806 * codegen.cs (CodeGen.TrimExt): Removed unused.
5808 * cs-parser.jay (output): Removed unused.
5810 * cs-tokenizer.cs (hex_digits): Removed unused.
5812 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
5814 * expression.cs (Indirection.LoadExprValue): Removed unused.
5815 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
5817 * iterators.cs (Iterator.param_types): Removed unused.
5819 * statement.cs (Goto.block): Removed unused.
5820 (ToplevelBlock.did): Removed unused.
5821 (Switch.ResolveConstantSwitch): Removed unused.
5823 2005-04-01 Ben Maurer <bmaurer@ximian.com>
5825 * rootcontext.cs: Allow mcs to bootstrap with the compilation
5828 2005-04-19 Martin Baulig <martin@ximian.com>
5830 Merged r42462 from MCS and made it work for GMCS.
5832 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
5834 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
5836 2005-04-01 Raja R Harinath <rharinath@novell.com>
5838 Fix #74232 and cs0208-3.cs.
5839 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
5840 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
5841 unmanaged type. Don't use FieldBuilders when 't' is a
5842 TypeBuilder. Use ModFlags and MemberType fields.
5843 * class.cs (MemberBase.member_type): Rename from MemberType.
5844 (MemberBase.MemberType): New property. Determines member_type on
5846 (MemberBase.DoDefine): Don't initialize MemberType here.
5847 (FieldMember.Define): Likewise.
5849 2005-04-01 Marek Safar <marek.safar@seznam.cz>
5852 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
5853 Attributes are emitted there.
5855 2005-04-01 Raja R Harinath <rharinath@novell.com>
5857 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
5858 keyword in 'partial enum' too.
5859 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
5861 Report from Kamil Skalski <nazgul@omega.pl>.
5864 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
5865 have partial containers too.
5867 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
5868 in block' checks to Block.CheckInvariantMeaningInBlock.
5869 * statement.cs (Block.GetKnownVariableInfo): Make private.
5870 (Block.IsVariableUsedInChildBlock): Remove.
5871 (Block.IsVariableUsedInBlock): Likewise.
5872 (Block.CheckInvariantMeaningInBlock): New. Show location of
5873 conflicting declaration.
5874 (Block.AddVariable): Make error messages less long-winded and more
5875 specific. Show location of conflicting declaration.
5876 * parameter.cs (Parameters.Location): New readonly property.
5878 2005-03-31 Raja R Harinath <rharinath@novell.com>
5880 Clean up semantics of invoking ResolveMemberAccess.
5881 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
5882 can have an instance, ensure that we pass in a non-TypeExpression
5883 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
5884 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
5885 argument. Update to changes and simplify.
5886 (FieldExpr.Emitinstance): Remove CS0120 check.
5887 (PropertyExpr.EmitInstance): Likewise.
5888 * expression.cs (Argument.Resolve): Likewise.
5889 (Invocation.DoResolve): Update to changes in semantics of
5892 2005-03-31 Marek Safar <marek.safar@seznam.cz>
5895 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
5898 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
5900 2005-03-31 Raja R Harinath <rharinath@novell.com>
5902 Fix difference in behaviour with commandline invocation.
5903 * driver.cs (Driver.Reset): New.
5904 (CompilerCallableEntryPoint): Call it.
5906 * statement.cs (If.Resolve): Avoid spurious "uninitialized
5907 variable" warnings if the boolean expression failed to resolve.
5909 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
5911 * attribute.cs: Fix the union of several permissions when some of them
5912 are unrestricted (so the result isn't an unrestricted permission set).
5915 2005-03-30 Raja R Harinath <rharinath@novell.com>
5917 * ecore.cs (MemberExpr): New class. Convert from interface
5919 (MemberExpr.ResolveMemberAccess): Refactor and move here from
5920 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
5922 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
5923 (MethodGroupExpr.IsExplicitImpl): Remove.
5924 (Expression.GetFieldFromEvent): Remove.
5925 (SimpleName.MemberStaticCheck): Remove.
5926 (SimpleName.DoSimpleNameResolve): Update to changes.
5927 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
5928 (MemberAccess.IdenticalNameAndTypeName): Remove.
5929 (MemberAccess.error176): Move to MemberExpr.
5930 (MemberAccess.DoResolve): Update to changes.
5931 (BaseAccess.DoResolve): Likewise.
5933 2005-03-30 Marek Safar <marek.safar@seznam.cz>
5935 C# 2.0 Conditional attribute class implementation
5937 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
5938 Analyzes class whether it has attribute which has ConditionalAttribute
5939 and its condition is not defined.
5941 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
5942 (Class.IsExcluded): New method. Search for at least one defined
5943 condition in ConditionalAttribute of attribute class.
5945 2005-03-30 Raja R Harinath <rharinath@novell.com>
5947 * ecore.cs (PropertyExpr): Derive from Expression, not
5948 ExpressionStatement.
5949 (PropertyExpr.EmitStatement): Remove.
5951 2005-03-29 Raja R Harinath <rharinath@novell.com>
5954 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
5955 internal field "value__" of an enum be private. The examples for
5956 "value__" that I found on MSDN all used FieldAttributes.Private.
5958 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
5959 Don't mention IL method attribute names.
5961 Fix #47991. Remove a TODO.
5962 * statement.cs (Block.Toplevel): Make into a field.
5963 (Block.Parameters): Move into ToplevelBlock.
5964 (Block.known_variables): Rename from child_variable_names.
5965 (Block.Block): Remove variants that take Parameters. Initialize
5966 'Toplevel' with the immediately surrounding toplevel block.
5967 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
5968 LocalInfo parameter.
5969 (Block.GetKnownVariableInfo): New.
5970 (Block.IsVariableNameUsedInChildBlock): Update.
5971 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
5972 the block, even though it may not be in scope.
5973 (Block.AddVariable): Remove Parameters parameter. Use
5974 Toplevel.Parameters instead.
5975 (Block.AddConstant): Remove Parameters parameter.
5976 (Block.GetParameterReference): Update to use Toplevel.Parameters.
5977 (Block.IsParamaterReference): Likewise.
5978 (Block.IsLocalParameter): Likewise. Simplify a lot.
5979 (ToplevelBlock.Parameters): New. Moved from Block.
5980 (ToplevelBlock.ToplevelBlock): Update to changes. Always
5981 initialize Parameters to a non-null value.
5982 * cs-parser.jay: Update to changes.
5983 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
5984 simple names that mean different things in the same block. Use
5985 Block.IsVariableNameUsedInBlock.
5987 2005-03-28 Raja R Harinath <rharinath@novell.com>
5989 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
5991 2005-03-26 Raja R Harinath <harinath@acm.org>
5994 * assign.cs (Assign.DoResolve): When the RHS of an assignment
5995 fails to resolve, ensure that the LHS is still resolved as an
5998 2005-03-25 Raja R Harinath <harinath@acm.org>
6000 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
6002 (Enum.current_ec): Remove.
6003 (Enum.LookupEnumValue): Remove EmitContext argument.
6004 Just uses the one created during DefineType.
6005 (Enum.FindMembers): Update.
6006 * expression.cs (MemberAccess.DoResolve): Update.
6008 2005-03-22 Marek Safar <marek.safar@seznam.cz>
6010 * assign.cs (Assign.DoResolve): Check for CS1717 when
6011 source and target are same (uses Equals).
6013 * expression.cs (LocalVariableReference, ParameterReference,
6014 This): Implemented Equals, GetHashCode.
6016 * statement.cs (Block.GetParameterReference): Removed useless
6019 2005-03-22 Raja R Harinath <rharinath@novell.com>
6022 * statement.cs (Block.AddVariable): Ensure that we skip implicit
6023 blocks before deciding whether the error is cs0136 or cs0128.
6025 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
6026 (using_alias_directive, using_namespace_directive): Pass
6027 MemberName, not an expression to Namespace.UsingAlias and
6029 (MakeName): Use the MemberName of the namespace.
6030 * namespace.cs (Namespace.MemberName): New.
6031 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
6032 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
6034 * decl.cs (MemberName.Name): Make readonly.
6035 (MemberName.FromDotted): New "constructor".
6036 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
6037 (MemberCore.Name): Compute from MemberName on demand.
6038 (MemberCore.SetMemberName): Provide a way to change the
6040 (MemberCore.AddToContainer): Don't take a fullname parameter.
6041 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
6042 fully qualified name of the container to the member name.
6043 (TypeContainer.AddToTypeContainer): Use a fully qualified name
6044 only if the type is a member of the root container.
6045 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
6046 MemberName.Left rather than searching for an embedded ".".
6047 (PartialContainer.CreatePart): Update to changes in RootContext.
6048 (MemberBase.ShortName): Turn into a property. Use
6049 MemberCore.SetMemberName.
6050 (MemberBase.ExplicitInterfaceName): Remove.
6051 (MemberBase.UpdateMemberName): Remove.
6052 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
6053 (PropertyBase.SetMemberName): New override.
6054 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
6055 (Tree.GetDecl): New.
6056 (Tree.AllDecls): Rename from Decls.
6057 * attribute.cs, enum.cs, report.cs: Update to changes.
6058 * driver.cs (MainDriver): Use MemberName.FromDotted on
6059 RootContext.MainClass.
6061 2005-03-21 Marek Safar <marek.safar@seznam.cz>
6063 * class.cs (FixedField.Define): Check for CS1664 and more sanity
6066 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
6068 2005-03-18 Marek Safar <marek.safar@seznam.cz>
6070 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
6071 property accessor modifiers.
6073 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
6074 fixed buffer attribute (CS1716).
6075 (PropertyMethod.HasCustomAccessModifier): When property accessor
6076 has custom modifier.
6078 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
6080 (PropertyExpr.DoResolveLValue): Add CS0272.
6082 2005-03-17 Miguel de Icaza <miguel@novell.com>
6084 * convert.cs: When converting to a pointer, use the proper Conv.U
6085 or Conv.I depending on the source data type.
6087 * cs-tokenizer.cs: Make the size for large decimal constants,
6090 2005-03-17 Martin Baulig <martin@ximian.com>
6092 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6093 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6095 2005-03-17 Martin Baulig <martin@ximian.com>
6097 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6098 to bool so we can return an error condition.
6099 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6102 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
6104 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
6107 2005-03-16 Raja R Harinath <rharinath@novell.com>
6109 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
6110 Refactor to avoid traversing the list of assemblies, and to avoid
6111 string concatenation.
6112 * typemanager.cs (guid_attr_type): Remove.
6113 (negative_hits, pointers, references): Remove hashes.
6115 (GetConstructedType): New. Uses type_hash to handle constructed
6116 types (arrays, references, pointers).
6117 (GetReferenceType, GetPointerType): Use it.
6118 (GetNestedType): New. Uses type_hash to handle nested types of
6120 (LookupType, LookupTypeDirect): Remove.
6121 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
6122 'types' hash and LookupTypeReflection directly.
6123 (params_string, params_object): Use GetConstructedType.
6124 * namespace.cs (Namespace.cached_types): New. Cache of reflected
6126 (Namespace.Lookup): Use cached_types.
6127 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
6128 provided by old TypeManager.LookupType.
6129 * rootcontext.cs (MakeFQN): Remove.
6130 * decl.cs (DeclSpace.MakeFQN): Likewise.
6131 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
6132 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6133 TypeManager.GetConstructedType.
6134 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
6136 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
6138 * cs-parser.jay: Fix build.
6140 2005-03-15 Marek Safar <marek.safar@seznam.cz>
6142 * class.cs (TypeContainer.CircularDepException) New nested
6143 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
6145 * cs-parser.jay: Reports CS1527 for any namespace element.
6147 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
6150 * expression.cs (ParameterReference.IsAssigned): Changed error to
6152 (Error_WrongNumArguments): Moved CS0245 detection here.
6154 * statement.cs (Return.Resolve): Add CS1622 report.
6156 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6158 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6160 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6162 * attribute.cs expression.cs: Get rid of some allocations.
6164 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6166 * doc.cs : just eliminate the latest change.
6168 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6170 * doc.cs : commented out the latest change. It breaks xml-030.cs
6172 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6174 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6175 fail. So invoke CreateType() in FindDocumentedType().
6177 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6179 * cs-tokenizer.cs : added IsKeyword().
6180 * doc.cs : Detect keyword incorrectly used as identifier.
6181 Allow identifiers prefixed by @.
6183 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6185 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6186 It caused exception in namespace resolving (again!).
6188 * class.cs (Class.ctor): Removed exit.
6189 (PropertyMethod.ctor): ditto.
6191 * codegen.cs (Codegen.Reset): Reset static data.
6192 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6194 * cs-tokenizer.cs (Cleanup): Removed.
6196 * driver.cs (GetSystemDir): Rewrote to one line command.
6197 It caused problem with unloaded dynamic modules.
6198 (UnixParseOption): Removed Exit.
6199 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6200 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6201 Now can be mcs used as library.
6203 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6206 * location.cs (Reset): Reset static data.
6208 * namespace.cs (Reset): Reset static data.
6210 * report.cs (Report.Reset): Reset static data.
6212 * rootcontext.cs (RootContext.Reset): Reset static data.
6214 * tree.cs (RootTypes.ctor): Use Location.Null
6216 * typemanager.cs (TypeManager.Reset): Reset static data.
6217 (CoreLookupType): Removed Exit.
6218 (TypeHandle.Reset): Reset static data.
6220 2005-03-10 Raja R Harinath <rharinath@novell.com>
6223 * typemanager.cs (ComputeNamespaces): Import namespaces from
6224 referenced modules too.
6226 2005-03-09 Raja R Harinath <rharinath@novell.com>
6228 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6231 2005-03-09 Raja R Harinath <rharinath@novell.com>
6233 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6234 enclosing DeclSpace. This ensures that a name-lookup populates
6235 more caches and there are fewer 'TypeExpression's. Carve out
6236 nested type lookup into ...
6237 (LookupNestedTypeInHierarchy): ... this.
6239 2005-04-15 Martin Baulig <martin@ximian.com>
6241 Merged r41590 from MCS and make it work in the generics land.
6243 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6246 * class.cs (PartialContainer.UpdateConstraints): Removed.
6247 (PartialContainer.CheckConstraints): Removed.
6248 (PartialContainer.SetParameterInfo): Store the constraints here.
6249 (PartialContainer.DefineTypeParameters): New public method;
6250 resolve the type parameter's constraints here. Note that the
6251 PartialContainer doesn't have an EmitContext anymore, so we must
6252 do this in the ClassPart.
6254 2005-03-09 Raja R Harinath <rharinath@novell.com>
6256 Clean up a few partial-class semantics.
6257 Fixes test-357.cs and cs1618-2.cs.
6258 * cs-parser.jay (struct_declaration): Use 'current_class' as
6259 parent of newly-created struct. Remove call to Register ().
6260 Use 'pop_current_class' to complete handing the current struct.
6261 (interface_declaration): Likewise.
6262 (class_declaration): Likewise.
6263 (enum_declaration): Use 'current_class' as parent of newly created
6265 (delegate_declaration): Likewise.
6266 (pop_current_class): New function. This is used to handle closing
6267 up the 'current_class' and 'current_container', and pointing them
6268 to the enclosing class/container.
6269 (CSharpParser): Initialize 'current_class' too.
6270 * decl.cs (MemberCore): Add check for invariant: a partial
6271 container is not a parsed entity, and thus does not enclose any
6273 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6274 (DeclSpace.BaseTypeExpr): Use it.
6275 (DeclSpace.LookupType): Add check for invariant.
6276 * class.cs (TypeContainer): Add check for invariant: a nested
6277 class should have the same NamespaceEntry as its enclosing class.
6278 (TypeContainer.EmitFieldInitializers): Make virtual.
6279 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6281 (TypeContainer.Register): Remove.
6282 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6283 null. Use TypeResolveEmitContext for resolving base types and
6284 interfaces. Move initialization of Parts.TypeBuilder here from
6286 (TypeContainer.DefineNestedTypes): ... here.
6287 (PartialContainer): Take a Namespace not a NamespaceEntry.
6288 (PartialContainer.Create): Don't use Register. Call the
6289 appropriate Add... function directly.
6290 (ClassPart): Take both the PartialContainer and the enclosing
6291 class as constructor arguments.
6292 (ClassPart.EmitFieldInitializers): Override.
6293 (ClassPart.PartFindNestedTypes): Remove.
6294 (FieldBase.GetInitializerExpression): Resolve the initializer
6295 expression in the emit context of the enclosing class.
6296 * tree.cs (RootTypes): Remove Register ().
6298 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6300 * cs-parser.jay: Removed CS0134.
6302 * driver.cs: Removed CS1901.
6304 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6305 for predefined types.
6307 2005-03-07 Duncan Mak <duncan@novell.com>
6309 * codegen.cs (Save): Catch UnauthorizedAccessException as
6310 well. Fixes bug #73454.
6312 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6314 * cs-tokenizer.cs (xtoken): Add CS1035.
6316 * class.cs (MethodData.Define): Add CS0683.
6317 (FieldMember.ctor): Add CS0681.
6319 2005-03-07 Raja R Harinath <rharinath@novell.com>
6321 * ecore.cs (SimpleName.DoResolve): Rename from
6322 SimpleName.DoResolveAllowStatic.
6323 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6324 Pass 'intermediate' flag to MemberStaticCheck.
6325 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6326 of "intermediate" lookups via MemberAccess.
6327 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6328 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6330 2005-03-07 Raja R Harinath <rharinath@novell.com>
6333 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6334 slipped in because of variable names that are identical to a
6335 builtin type's BCL equivalent ('string String;', 'int Int32;').
6336 (PropertyExpr.EmitInstance): Likewise.
6338 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6340 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6342 * report.cs (warning_ignore_table): Made public.
6344 2005-03-04 Raja R Harinath <rharinath@novell.com>
6347 * class.cs (MethodData.Emit): Pass 'container' to
6348 container.GetObsoleteAttribute instead of 'container.Parent'.
6350 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6352 * cs-parser.jay: Add 1534 error test.
6354 * iterators.cs (Yield.CheckContext): Add error 1629.
6355 (Iterator.ctor): Save unsafe modifier.
6356 (MoveNextMethod.DoEmit): Restore unsafe context.
6358 * namespace.cs (UsingAlias): Better error message.
6360 2005-03-03 Dan Winship <danw@novell.com>
6362 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6363 the warning message [#73219]
6365 2005-03-03 Raja R Harinath <rharinath@novell.com>
6367 Fix compile with MCS 1.0.0.0.
6368 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6369 w_restore to not depend on string constant folding.
6371 2005-03-03 Raja R Harinath <rharinath@novell.com>
6373 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6374 CS0246 check to users who passed 'silent = false'.
6375 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6377 (SimpleName.SimpleNameResolve): Update.
6378 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6379 (MemberAccess.IdenticalNameAndTypeName): Update.
6380 * doc.cs (FindDocumentedTypeNonArray): Update.
6382 2005-03-03 Raja R Harinath <rharinath@novell.com>
6384 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6385 * parameters.cs (ComputeAndDefineParameters): Remove.
6386 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6387 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6388 Use GetParameterInfo.
6390 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6392 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6394 2005-03-02 Raja R Harinath <rharinath@novell.com>
6396 Unify DeclSpace.LookupType and DeclSpace.FindType.
6397 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6398 is in charge of defining nested types on demand.
6399 (DeclSpace.LookupType): Use it when the current_type is a
6400 TypeBuilder. Use LookupTypeDirect for reflected types.
6401 (DeclSpace.FindType): Remove.
6402 (DeclSpace.LookupInterfaceOrClass): Likewise.
6403 (DeclSpace.DefineTypeAndParents): Likewise.
6404 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6405 DeclSpace.LookupType.
6406 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6407 * typemanager.cs (LookupType): Simplify.
6408 (AddUserType): Remove type from negative_hits.
6409 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6410 * class.cs (TypeContainer.FindMembers): Move handling of nested
6412 (TypeContainer.FindMembers_NestedTypes): ... here.
6413 (TypeContainer.FindNestedType): Implement override.
6414 (ClassPart.FindNestedType): Delegate to PartialContainer.
6415 (ClassPart.PartFindNestedType): Looks up the nested types of the
6418 2005-04-14 Martin Baulig <martin@ximian.com>
6420 * generic.cs (ConstructedType): Moved all the type lookup and
6421 nested class logic into SimpleName.
6422 (ConstructedType.ResolveConstructedType): Our underlying type is
6423 already fully resolved; all the type lookup stuff is in
6426 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6427 constructed types here instead of in ConstructedType.
6429 * decl.cs (MemberName.GetTypeExpression): Always create a
6430 SimpleName, not a ConstructedType.
6431 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6433 2005-03-02 Martin Baulig <martin@ximian.com>
6435 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6436 static constructor in static classes.
6438 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6440 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6441 sizeParamIndex is not specified.
6443 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6446 * report.cs (WarningMessage.IsEnabled): Missing null check.
6448 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6450 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6451 in the fields and not in the properties.
6453 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6455 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6458 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6460 * attribute.cs: Small refactoring (improved robustness).
6461 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6462 (ValidateGuid): Removed.
6463 (Resolve): Removed referenced to above mentioned.
6464 (GetAttributeUsage): Made private and changed to work without
6466 (GetIndexerAttributeValue): Don't crash.
6467 (GetConditionalAttributeValue): Ditto.
6468 (GetClsCompliantAttributeValue): Ditto.
6469 (ExtractSecurityPermissionSet): All attributes exceptions are
6471 (GetPropertyValue): New helper.
6472 (GetMethodImplOptions): New method.
6473 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6474 some missing properties.
6476 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6477 (Method.ApplyAttributeBuilder): Updated.
6479 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6482 2005-02-28 Raja R Harinath <rharinath@novell.com>
6485 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6486 non-simple types (array, pointer, reference).
6488 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6490 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6492 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6494 (Method.CheckBase): Catch wrong destructor here.
6495 (MethodData.Define): Add errors 550, 668.
6497 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6499 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6501 * pending.cs (VerifyPendingMethods): Add error 551.
6503 * typemanager.cs (CSharpName): Next error report helper.
6505 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6507 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6508 attributes. Removed useless attribute double check.
6509 It saves almost 2MBs for corlib.
6511 2005-02-25 Raja R Harinath <rharinath@novell.com>
6514 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6515 called twice in case of error.
6517 2005-02-23 Chris Toshok <toshok@ximian.com>
6519 Fix compiler portions of #72827.
6520 * statement.cs (Block.Emit): call Begin/EndScope on the
6521 EmitContext instead of the ILGenerator.
6523 * codegen.cs (EmitContext.BeginScope): new method, call
6524 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6526 (EmitContext.BeginScope): same, but EndScope and CloseScope
6528 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6529 offset and call the superclass's OpenScope(int) with it.
6530 (SymbolWriter.CloseScope): get the current il
6531 offset and call superclass's CloseScope(int) with it.
6533 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6535 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6536 CS1677 for out and ref as well.
6538 * class.cs (Method.Define): Add error CS1599 detection.
6540 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6542 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6544 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6546 * support.cs.cs (ModifierDesc): New helper method.
6548 2005-02-23 Raja R Harinath <rharinath@novell.com>
6549 Abin Thomas <projectmonokochi@rediffmail.com>
6550 Anoob V E <projectmonokochi@rediffmail.com>
6551 Harilal P R <projectmonokochi@rediffmail.com>
6554 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6555 MemberLookup (used for error reporting) actually returns a result.
6556 Fix error report number (122, not 112).
6558 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6559 Anoob V E <projectmonokochi@rediffmail.com>
6560 Harilal P R <projectmonokochi@rediffmail.com>
6563 * pending.cs (PendingImplementation.GetAbstractMethods):
6564 Find NonPublic members too.
6566 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6568 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6571 * class.cs (MethodCore.CheckMethodAgainstBase):
6572 Add error 239 report.
6574 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6576 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6578 * class.cs (Operator.Define): Add error 217 report.
6580 2005-02-21 Raja R Harinath <rharinath@novell.com>
6583 * expression.cs (Invocation.IsApplicable): Make public.
6584 (Invocation.IsParamsMethodApplicable): Likewise.
6585 * delegate.cs (Delegate.VerifyApplicability): Don't use
6586 Invocation.VerifyArgumentCompat for parameter applicability
6587 testing. Use Invocation.IsApplicable and
6588 Invocation.IsParamsMethodApplicable.
6590 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6592 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6594 * class.cs (Operator.Define): Add error 217 report.
6596 2005-02-21 Raja R Harinath <rharinath@novell.com>
6598 * namespace.cs (UsingEntry.Resolve): Undo change below.
6600 2005-02-21 Raja R Harinath <rharinath@novell.com>
6603 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6604 disable the error message when the extended MemberLookup also
6606 (Expression.MemberLookupFinal): Update.
6607 (SimpleName.DoSimpleNameResolve): Update.
6608 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6609 Don't use MemberLookupFinal.
6610 (New.DoResolve): Update.
6611 (BaseAccess.CommonResolve): Update.
6613 2005-02-21 Raja R Harinath <rharinath@novell.com>
6616 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6617 occured previously, don't resolve again.
6619 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6622 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6623 argument. Call ResolveAttributeUsage for unresolved.
6624 when types doesn't match ctor arguments.
6626 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6627 for nested attribute classes.
6628 (Class.attribute_usage): Removed.
6629 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6630 for attribute class.
6632 * ecore.cs (IsAttribute): Removed.
6634 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6636 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6638 (attribute_types): Removed.
6639 (EmitCode): Global attributes are emited as the latest.
6641 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6643 * class.cs (EmitFieldInitializers): Don't emit field initializer
6644 for default values when optimilization is on.
6646 * constant.cs (Constant.IsDefaultValue): New property.
6648 * driver.cs: Add /optimize handling.
6652 * literal.cs: Implement new IsDefaultValue property.
6654 * rootcontext.cs (Optimize): New field, holds /optimize option.
6656 2005-02-18 Raja R Harinath <rharinath@novell.com>
6658 Fix crasher in re-opened #72347.
6659 * namespace.cs (Namespace.Lookup): Return null if
6660 DeclSpace.DefineType returns null.
6663 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6665 2005-02-18 Raja R Harinath <rharinath@novell.com>
6667 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6668 now returns null if it cannot resolve to an lvalue.
6669 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6670 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6671 returned null. Remove check for SimpleName.
6672 (EventExpr.DoResolveLValue): New.
6673 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6674 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6676 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6678 (Unary.ResolveOperator): Move CS0211 check ...
6679 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6681 (Unary.DoResolveLValue): Simplify.
6682 (AddressOf.DoResolveLValue): New.
6683 (ArrayAccess.DoResolveLValue): New.
6685 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6687 * attribute.cs (Attribute.Resolve): Add arguments casting for
6688 when types doesn't match ctor arguments.
6690 2005-02-16 Raja R Harinath <rharinath@novell.com>
6692 Fix parts of #63202.
6693 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6694 lookup of operator in base type. Ensure that all checks happen
6695 when the operator resolves to an "op_..." method.
6697 2005-02-15 Raja R Harinath <rharinath@novell.com>
6700 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6701 'ignore_cs0104' parameter. Pass it to ...
6702 (NamespaceEntry.Lookup): ... this.
6703 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6704 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6705 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6706 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6707 Update. Request that cs0104 errors be ignored.
6708 (ComposedCast.ResolveAsTypeStep): Update.
6710 2005-02-14 Raja R Harinath <rharinath@novell.com>
6713 * expression.cs (Invocation.BetterFunction): Remove support for
6714 comparing virtual functions and their overrides.
6715 (Invocation.IsOverride): New.
6716 (Invocation.OverloadResolve): Don't consider 'override' functions
6717 during candidate selection. Store them in a lookaside list.
6718 If the selected method is a 'virtual' function, use the list to
6719 find any overrides that are closer to the LHS type.
6721 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6723 * expression.cs (New.DoResolve): Add complex core type reduction.
6724 (New.Constantify): Converts complex core type syntax like 'new int ()'
6727 2005-02-14 Raja R Harinath <rharinath@novell.com>
6729 * decl.cs (EntryType.EntryType): New constructor to create an
6730 updated copy of a cache entry.
6731 (MemberCache.AddMethods): Use it.
6732 (MemberCache.ClearDeclaredOnly): Remove.
6733 (MemberCache.MemberCache): Update.
6735 2005-02-11 Miguel de Icaza <miguel@novell.com>
6737 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6738 variable. This one is represents the actual low-level declaration
6739 of the method, as opposed to the semantic level `IsStatic'.
6741 An anonymous method which is hosted into a static method might be
6742 actually an instance method. IsStatic would reflect the
6743 container, while MethodIsStatic represents the actual code
6746 * expression.cs (ParameterReference): Use the new MethodIsStatic
6747 instead of IsStatic.
6749 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6750 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6751 set on the current EmitContext.
6753 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6754 resolve our casted expression as an LValue. This triggers the
6755 proper LValue processing that is later required by Assign.
6759 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6761 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6763 C# 2.0 Fixed buffer implementation
6765 * anonymous.cs: Update after RegisterHelperClass renaming.
6767 * attribute.cs (AttributeTester.fixed_buffer_cache):
6768 Cache of external fixed buffers.
6769 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
6770 implementation if field is fixed buffer else null.
6773 (TypeContainer.AddField): Accept FieldMember instead of Field.
6774 (FieldBase.IsFieldClsCompliant): Extracted code from
6775 VerifyClsCompliance descendant customization.
6776 (FixedField): New class handles fixed buffer fields.
6777 (FixedFieldExternal): Keeps information about imported fixed
6779 (IFixedField): Make access to internal or external fixed buffer
6782 * cs-parser.jay: Add fixed buffer parsing.
6784 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
6787 * expression.cs (Indirection): Extended implementation to accept
6789 (PointerArithmetic.Emit): Get element from fixed buffer as well.
6790 (ElementAccess.MakePointerAccess): Get type as parameter.
6791 (DoResolve): Add fixed buffer field expression conversion.
6792 (DoResolveLValue): Ditto.
6793 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
6794 (ArrayPtr): Derives from FixedBufferPtr.
6795 (ArrayPtr.Emit): Add extra emit for array elements.
6797 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
6799 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
6800 for compiler generated types.
6801 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
6803 * statement.cs (Fixed): Refactored to be easier add fixed buffer
6804 and consume less memory.
6805 (Fixed.Resolve): Add fixed buffer case.
6807 * typemanager.cs (compiler_generated_attr_ctor,
6808 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
6809 (HasElementType): Add our own implementation to work on every
6812 2005-02-11 Miguel de Icaza <miguel@novell.com>
6814 * anonymous.cs (CaptureContext): Track whether `this' has been
6817 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
6818 only captured `this' if it was implicitly done (instance
6819 methods/variables were used).
6821 * codegen.cs (EmitContext.CaptureThis): New method to flag that
6822 `this' must be captured.
6824 2005-01-30 Miguel de Icaza <miguel@novell.com>
6826 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
6827 is null it means that there has been no need to capture anything,
6828 so we just create a sibling.
6830 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
6832 Just a partial fix. The other half is fairly elusive.
6834 2005-02-10 Raja R Harinath <rharinath@novell.com>
6836 Fix #52586, cs0121-4.cs.
6837 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
6838 and return a hashtable.
6839 (MemberCache.ClearDeclaredOnly): New.
6840 (MemberCache.MemberCache): Update to change. Make a deep copy of
6841 the method_hash of a base type too.
6842 (MemberCache.AddMethods): Adapt to having a deep copy of the base
6843 type methods. Overwrite entries with the same MethodHandle so
6844 that the ReflectedType is correct. The process leaves in base
6845 virtual functions and their overrides as distinct entries.
6846 (CacheEntry): Now a class instead of a struct. It shouldn't alter
6847 matters since it was boxed in a ArrayList before.
6848 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
6850 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
6851 case of a virtual function and its override (choose the overload
6853 (Invocation.OverloadResolve): Avoid 'override' members during
6854 'applicable_type' calculation.
6856 2005-03-28 Raja R Harinath <rharinath@novell.com>
6858 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
6859 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
6860 GetTypeHandle. It is possible for a reflected type to derive from
6861 a TypeBuilder (e.g., int[] derives from the TypeBuilder
6862 System.Array during mscorlib compilation).
6863 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
6864 contain a method_hash, don't create one either. Don't create a
6865 deep copy of the base cache's method_hash.
6866 (MemberCache.SetupCache): Rename back from DeepCopy.
6867 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
6868 already initialized. If we see an override function, add its
6869 underlying base virtual function to the member_hash too.
6871 2005-02-09 Raja R Harinath <rharinath@novell.com>
6873 Combine two near-redundant caches.
6874 * typemanager.cs (method_params): Rename from method_internal_params.
6875 (TypeManager.GetParameterData): New. Replace
6876 Invocation.GetParameterData.
6877 (TypeManager.LookupParametersByBuilder): Remove.
6878 * expression.cs (Invocation.method_parameter_cache): Remove.
6879 (Invocation.GetParameterData): Remove.
6881 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
6884 2005-02-08 Raja R Harinath <rharinath@novell.com>
6887 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
6888 TypeManager.multicast_delegate_type is null, resolve it by looking
6889 up "System.MulticastDelegate".
6890 * rootcontext.cs (RootContext.ResolveCore): Simplify.
6892 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
6893 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
6894 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
6897 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
6898 (LabeledStatement.AddReference): New. Set 'referenced'.
6899 (Goto.Resolve): Use it.
6901 2005-02-05 John Luke <john.luke@gmail.com>
6903 * driver.cs: remove duplicate -doc line in Usage ()
6905 2005-02-04 Raja R Harinath <rharinath@novell.com>
6907 * location.cs (Location.AddFile): Fix CS2002 error report.
6909 2005-02-02 Martin Baulig <martin@ximian.com>
6911 * delegate.cs (Delegate.DefineType): Report an internal error if
6912 TypeManager.multicast_delegate_type is null. See bug #72015 for
6915 2005-02-02 Raja R Harinath <rharinath@novell.com>
6917 Fix a crasher in a variant of #31984.
6918 * const.cs (Constant.CheckBase): New override that defers the
6919 new-or-override check in case the base type hasn't been populated
6921 (Constant.Define): Ensure the new-or-override check is performed.
6923 2005-02-01 Duncan Mak <duncan@ximian.com>
6925 * const.cs (LookupConstantValue): Check that `ce' is not null
6926 before calling GetValue ().
6928 2005-02-01 Raja R Harinath <rharinath@novell.com>
6930 Fix test-334.cs (#69519).
6931 * cs-parser.jay (using_alias_directive): Pass in an expression to
6932 NamespaceEntry.UsingAlias.
6933 (using_namespace_directive): Pass in an expression to
6934 NamespaceEntry.Using.
6935 (namespace_name): Don't flatten to a string.
6936 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
6937 (NamespaceEntry.AliasEntry.Resolve): Lookup using
6939 (NamespaceEntry.UsingEntry): Likewise.
6940 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
6942 (NamespaceEntry.LookupForUsing): Remove.
6943 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
6945 (NamespaceEntry.Lookup): Remove support for dotted names.
6947 2005-02-01 Raja R Harinath <rharinath@novell.com>
6949 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
6951 (NamespaceEntry.ImplicitParent): Compute on demand.
6952 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
6953 parallels the current.
6954 (NamespaceEntry.LookupForUsing): Use it.
6955 (NamespaceEntry.Lookup): If the current namespace-entry is
6956 implicit, don't search aliases and using tables.
6958 2005-02-01 Raja R Harinath <rharinath@novell.com>
6961 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
6963 (TypeContainer.BaseCache): Compute on demand.
6964 (TypeContainer.FindMembers): Define constants and types if they're
6965 not already created.
6966 (FieldMember.Define): Move resetting of ec.InUnsafe before error
6968 * const.cs (Constant.Define): Make idempotent.
6970 2005-01-29 Miguel de Icaza <miguel@novell.com>
6972 * pending.cs: Produce better code (no nops produced by using Ldarg
6975 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
6976 i - 1' it should be arg + 1.
6980 2005-01-28 Raja R Harinath <rharinath@novell.com>
6982 * attribute.cs (Attribute.CheckAttributeType): Make private
6984 (Attribute.ResolveType): Make virtual.
6985 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
6986 handling of RootContext.Tree.Types.
6988 2005-01-27 Raja R Harinath <rharinath@novell.com>
6990 Update attribute-handling to use the SimpleName/MemberAccess
6992 * cs-parser.jay (attribute): Pass in an expression to the
6993 constructors of Attribute and GlobalAttribute.
6994 * attribute.cs (Attribute): Take an expression for the name.
6995 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
6996 passed in attribute name expression.
6997 (Attribute.CheckAttributeType): Use it.
6998 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
6999 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
7000 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
7001 argument to prevent error messages if the lookup fails.
7003 2005-01-27 Marek Safar <marek.safar@seznam.cz>
7005 * expression.cs (Indirection): Implemented IVariable interface
7006 to support indirection in AddressOf operator.
7007 (PointerArithmetic.Emit): Add optimalization for case where
7008 result can be precomputed.
7010 2005-01-26 Martin Baulig <martin@ximian.com>
7012 * class.cs (TypeContainer.AttributeTargets): Return the correct
7013 AttributeTargets depending on our `Kind' instead of throwing an
7014 exception; fixes #71632.
7016 2005-01-26 Marek Safar <marek.safar@seznam.cz>
7019 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
7022 2005-03-17 Martin Baulig <martin@ximian.com>
7024 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
7025 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
7027 2005-03-17 Martin Baulig <martin@ximian.com>
7029 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
7030 to bool so we can return an error condition.
7031 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
7034 2005-03-17 Martin Baulig <martin@ximian.com>
7036 * generic.cs (TypeMananager.IsIEnumerable): New public method.
7038 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
7039 converting from an array-type of T to `IEnumerable<T>'.
7041 2005-03-16 Martin Baulig <martin@ximian.com>
7043 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
7044 (Nullable.LiftedUnaryMutator): New public class.
7046 * expression.cs (UnaryMutator.DoResolve): Added support for
7049 2005-03-14 Martin Baulig <martin@ximian.com>
7051 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
7053 2005-03-14 Martin Baulig <martin@ximian.com>
7055 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
7056 the comparision operators `<', `>', `<=' and `>='.
7058 2005-03-13 Martin Baulig <martin@ximian.com>
7061 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
7062 avoid confusion with the `NullLiteral'.
7063 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
7065 2005-03-13 Martin Baulig <martin@ximian.com>
7067 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
7068 comparing arbitrary types with the null literal.
7070 2005-03-13 Martin Baulig <martin@ximian.com>
7072 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
7073 boolean operators '&&', '||', '&' and '|'.
7074 (Nullable.OperatorTrueOrFalse): New public class.
7076 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
7077 instead of a `StaticCallExpr'; added support for nullables.
7079 2005-03-10 Martin Baulig <martin@ximian.com>
7082 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
7083 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
7085 2005-03-07 Martin Baulig <martin@ximian.com>
7087 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
7088 it work if `expr' is not an IMemoryLocation.
7089 (Nullable.Lifted): Implement IMemoryLocation.
7090 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
7093 2005-03-05 Martin Baulig <martin@ximian.com>
7095 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
7096 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
7097 (Nullable): Added support for lifted unary and binary operators.
7099 * expression.cs (Unary.DoResolve): Added support for nullable types.
7100 (Binary.DoResolve): Likewise.
7101 (Conditional.DoResolve): Likewise.
7103 2005-03-02 Martin Baulig <martin@ximian.com>
7105 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
7107 * class.cs (ClassPart.SetParameterInfo): Override this.
7108 (PartialContainer.SetParameterInfo): Override this.
7109 (TypeContainer.CheckConstraints): New protected method.
7110 (PartialContainer.CheckConstraints): Override this and check
7111 whether the same contraints were specified in all parts of a
7112 partial generic type definition.
7113 (PartialContainer.UpdateConstraints): New public method.
7115 * generic.cs (TypeParameter.UpdateConstraints): New public method.
7117 2005-03-02 Martin Baulig <martin@ximian.com>
7119 Committing a patch from Carlos Alberto Cortez to fix #72887.
7121 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
7122 casts from `T []' to `int []'.
7124 2005-03-02 Martin Baulig <martin@ximian.com>
7126 * generic.cs (TypeManager.IsEqual): Make this symmetric.
7128 * expression.cs (Binary.ResolveOperator): When resolving a
7129 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
7130 `=='. Fixes #71866. See gen-127.cs.
7132 2005-03-02 Martin Baulig <martin@ximian.com>
7134 * class.cs (TypeContainer.DoDefineMembers): We also need a default
7135 static constructor in static classes.
7137 2005-03-02 Martin Baulig <martin@ximian.com>
7140 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
7141 (Nullable.LiftedConversion): Added support for user-defined
7144 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
7146 * cs-parser.jay: Use ComposedCast everywhere instead of
7147 NullableType, so we don't need to check for NullableType
7149 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
7150 case where we'll be resolved into a `parenthesized_expression_0'
7154 (Convert.UserDefinedConversion): Added nullable conversions.
7156 2005-02-28 Martin Baulig <martin@ximian.com>
7158 * generic.cs (TypeManager.IsNullableType): New static method.
7159 (Nullable): New abstract class.
7160 (Nullable.NullLiteral): New public class.
7161 (Nullable.LiftedConversion): New public class.
7163 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7164 `builtin_types opt_nullable'.
7167 (Convert.ImplicitConversionStandard): Added nullable conversions.
7168 (Convert.ExplicitConversionStandard): Likewise.
7169 (Convert.ExplicitConversion): Likewise.
7171 2005-02-26 Martin Baulig <martin@ximian.com>
7173 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7174 begin with a "?", for instance "?[]". Don't do a type lookup if
7177 2005-02-25 Martin Baulig <martin@ximian.com>
7179 The first part of Nullable Types :-)
7181 * generic.cs (NullableType): New public class.
7182 (NullCoalescingOperator): New public class.
7183 (TypeArguments.Resolve): Add a CS0306 check.
7185 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7186 (opt_nullable): New rule.
7187 (type): Added `opt_nullable' to `namespace_or_type_name',
7188 `builtin_types' and `pointer_type'.
7189 (array_type): Added `opt_nullable'.
7190 (opt_rank_specifier_or_nullable): New rule; this is the
7191 combination of `opt_rank_specifier' and `opt_nullable'.
7192 (opt_error): New rule; catch errors here.
7193 (nullable_type_or_conditional): New rule; we use this to check for
7194 nullable and still detect the conditional operator.
7195 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7196 instead `opt_rank_specifier'.
7198 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7201 2005-02-24 Martin Baulig <martin@ximian.com>
7203 * README, README.Changes: Removed; they're old and obsolete.
7205 2005-02-22 Martin Baulig <martin@ximian.com>
7207 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7208 returned an error, set `constraints' to null to avoid a crash
7210 (TypeParameter.ResolveType): Likewise.
7212 2005-02-22 Martin Baulig <martin@ximian.com>
7215 (Constraints.ResolveTypes): Protect against being called twice.
7216 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7217 (TypeParameter.ResolveType): New public method; calls
7218 constraints.ResolveTypes().
7219 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7220 into the new ResolveType().
7221 (GenericMethod.Define): Call ResolveType() on all our
7224 2005-02-21 Martin Baulig <martin@ximian.com>
7227 (TypeManager.generic_nullable_type): New static public field.
7228 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7231 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7233 2005-02-15 Martin Baulig <martin@ximian.com>
7235 * generic.cs (ConstructedType.Constraints): Correctly check
7236 constraints if the argument type is a type parameter; fixes
7239 2005-02-02 Martin Baulig <martin@ximian.com>
7241 * delegate.cs (Delegate.DefineType): Report an internal error if
7242 TypeManager.multicast_delegate_type is null. See bug #72015 for
7245 2005-01-29 Miguel de Icaza <miguel@novell.com>
7247 * pending.cs: Produce better code (no nops produced by using Ldarg
7250 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7251 i - 1' it should be arg + 1.
7255 2005-01-26 Martin Baulig <martin@ximian.com>
7257 * cs-parser.jay (indexer_declarator): Don't report an error if we
7258 have type parameters since we can be an explicit interface
7259 implementation; fixes #71449.
7261 2005-01-26 Martin Baulig <martin@ximian.com>
7263 * class.cs (TypeContainer.AttributeTargets): Return the correct
7264 AttributeTargets depending on our `Kind' instead of throwing an
7265 exception; fixes #71632.
7267 2005-01-26 Martin Baulig <martin@ximian.com>
7269 * delegate.cs (Delegate.DefineType): Correctly define our type
7270 parameters. Fixes #71483.
7272 2005-01-25 Raja R Harinath <rharinath@novell.com>
7275 * expression.cs (MemberAccess.DoResolve): Don't complain with
7276 cs0572 when the LHS of a member access has identical name and type
7279 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7282 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7284 Create custom PermissionSet only for PermissionSetAttribute.
7286 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7289 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7290 delegates in static class.
7292 2005-01-24 Martin Baulig <martin@ximian.com>
7294 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7295 merging an implicit block, just use its reachability.
7297 * statement.cs (Block.Resolve): Make the unreachable code check
7298 work wrt. implicit blocks; see test-337 from #63842.
7300 2005-01-21 Alp Toker <alp@atoker.com>
7302 * cs-parser.jay: destructor_declaration's container is PartialContainer
7303 not Class when partial types are used, so use Kind prop instead of
7306 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7308 * cs-parser.jay: Improve error reporting when an interface
7311 2005-01-20 Dick Porter <dick@ximian.com>
7313 * support.cs: SeekableStreamReader fix from Sandor Dobos
7314 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7315 chars are read. Fixes bug 70369.
7317 2005-01-20 Raja R Harinath <rharinath@novell.com>
7319 * cs-parser.jay (catch_clause): Simplify current_block handling
7322 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7324 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7325 code with ImplicitStandardConversion to handle the implicit
7326 conversion of method groups into valid delegate invocations.
7328 The problem is that in parameter handling we were using this code
7329 path. Fixes bug #64698
7331 2005-01-19 Raja R Harinath <rharinath@novell.com>
7333 * cs-parser.jay: Fix several infelicities.
7334 - Avoid assigning to the parser value stack. Code like
7335 '$3 = null' is unclean. Synthesize a value for the code block
7337 - Avoid using oob_stack for storing location information. Use ...
7338 (_mark_): ... this. New (empty) rule. Saves the current location
7340 (foreach_statement): Avoid using oob_stack for current_block
7341 handling. Use technique used in for_statement and
7342 using_statement. Synthesize a value for the code block to store
7343 additional intermediate information.
7345 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7347 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7348 of a different type is only allowed to private fields of a
7349 containing type, not on fields of a base class.
7351 See test-174.cs and error cs0122-9.cs
7353 2005-01-13 Raja R Harinath <rharinath@novell.com>
7355 Fix test-335.cs (bug #58126).
7356 * cs-parser.jay (argument): Split out non-expression parts of the
7357 rule into 'non_simple_argument'.
7358 (invocation_expression): Support parenthesized invocations with
7359 multiple arguments, and with single non-simple arguments.
7361 2005-01-13 Raja R Harinath <rharinath@novell.com>
7363 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7366 2005-01-12 Raja R Harinath <rharinath@novell.com>
7368 Fix cs0038-1.cs, cs1640-6.cs.
7369 * ecore.cs (Expression.Resolve): Remove special-case for
7370 SimpleName in error-handling.
7371 (Expression.almostMatchedMembers): Relax access permission to
7373 (Expression.MemberLookupFailed): Handle duplicates in
7374 almostMatchedMembers list.
7375 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7376 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7377 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7378 overload if the passed in MemberInfo is a MethodBase.
7380 2005-01-25 Martin Baulig <martin@ximian.com>
7383 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7385 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7388 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7389 for non-CAS & merge permission sets properly.
7391 2005-01-11 Raja R Harinath <rharinath@novell.com>
7393 Improve standard-compliance of simple name and member access
7394 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7395 * ecore.cs (FullNamedExpression): New abstract base class
7396 for Namespaces and TypeExpressions.
7397 (ResolveFlags.SimpleName): Remove.
7398 (SimpleName): Remove support for dotted names.
7399 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7400 DeclSpace.FindType and DeclSpace.LookupType.
7401 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7402 (Expression.ExprClassName): Make member function.
7403 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7404 a namespace. Remove creation of dotted "SimpleName"s.
7405 (MemberAccess.DoResolve): Likewise.
7406 * decl.cs (DeclSpace.Cache): Make private.
7407 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7408 (DeclSpace.FindType): Update.
7409 (DeclSpace.LookupType): Move here from RootContext. Return a
7410 FullNamedExpression.
7411 * namespace.cs (Namespace): Derive from FullNamedExpression
7412 so that it can be part of expression resolution.
7413 (Namespace.Lookup): Return an FullNamedExpression.
7414 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7416 * rootcontext.cs (NamespaceLookup): Remove.
7417 (LookupType): Move to DeclSpace.
7418 * attribute.cs (CheckAttributeType): Update.
7419 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7420 (FindDocumentedTypeNonArray): Likewise.
7422 2005-01-11 Raja R Harinath <rharinath@novell.com>
7424 Fix cs0509.cs, cs1632.cs.
7425 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7426 is the same as IsInterface.
7427 (TypeContainer.GetClassBases): Likewise.
7428 * statement.cs (LabeledStatement.ig): New field.
7429 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7431 (LabeledStatement.DoEmit): Check that the label was created with
7432 the same ILGenerator.
7434 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7437 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7438 accessors to its properties.
7440 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7441 from accessors to property.
7443 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7446 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7449 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7451 * attribute.cs: Check for null and empty strings.
7453 I have lost another battle to Paolo.
7455 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7458 * class.cs (PropertyMethod): Set Parent field in ctors.
7459 (SetMethod.InternalParameters): Add unsafe switch hack.
7460 Override MarkForDuplicationCheck where it is appropriate.
7462 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7463 It says whether container allows members with the same name.
7465 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7466 Removed is_method parameter.
7468 2005-01-06 Duncan Mak <duncan@ximian.com>
7470 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7471 because the previous change led to incorrect reporting of CS1032
7472 ("Cannot define/undefine preprocessor symbols after first token in
7473 file"). Instead of using `tokens_seen' as the only flag that
7474 triggers CS1040, introduce `comments_seen'. This new flag is used
7475 to signify having seen comments on the current line, so it is
7476 unset after a newline.
7478 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7480 * doc.cs : When searching for a type, find nested type too.
7481 This fixes bug #71040.
7483 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7486 - Warn missing member comment on those classes which also does not
7487 have doc comments. Fixed bug #71041.
7488 - Don't warn missing doc comment on default constructor.
7491 2005-01-06 Duncan Mak <duncan@ximian.com>
7493 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7494 comments, set `tokens_seen' to true. This allows us to detect
7495 misplaced preprocessor directives (i.e. not at the beginning of
7496 the a line, nor after whitespaces). In that case, report error
7497 CS1040. This fixes bug #56460.
7499 * cs-parser.jay (interface_member_declaration): Add checks for
7500 IsExplicitImpl, and report CS0541 error if an interface member is
7501 defined as an explicit interface declaration.
7503 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7506 * class.cs (PropertyMethod): Set Parent field in ctors.
7507 (SetMethod.InternalParameters): Add unsafe switch hack.
7509 * decl.cs (MemberCore.Parent): Cannot be readonly.
7511 2005-01-06 Raja R Harinath <rharinath@novell.com>
7513 * decl.cs (DeclSpace.ResolveType): Remove.
7514 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7515 Merge in code from ...
7516 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7517 * class.cs, enum.cs: Update to changes.
7519 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7521 * anonymous.cs: Ensure that we init the scope of our parent if it
7522 has not been initialized yet.
7524 2004-12-30 Duncan Mak <duncan@ximian.com>
7526 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7527 if field.FieldBuilder is null. Fixes #70758.
7529 * convert.cs: Fixed some typos and updated some of the comments.
7530 (ImplicitStandardConversionExists):
7531 (TryImplicitIntConversion): If `target_type' is an interface and
7532 the type of `ic' implements this interface, return true or a new
7533 BoxedCast instead of null. This fixes #70468.
7535 2004-12-29 Duncan Mak <duncan@ximian.com>
7537 * expression.cs (Argument.Emit): Check that Expr is
7538 IMemoryLocation before casting to it, and report CS1510 otherwise.
7542 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7544 * statement.cs (Block.ThisVariable): remove the recursion here, to
7545 make the --profile more sane.
7547 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7549 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7550 assembly, by JB Evain.
7552 2004-12-17 Raja R Harinath <rharinath@novell.com>
7554 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7555 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7556 "parent" refers to enclosing type/class. "base" refers to superclass.
7558 2004-12-17 Raja R Harinath <rharinath@novell.com>
7560 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7561 Ensure that we only have GlobalAttributes.
7562 * attribute.cs (Attribute.Emit): Make non-virtual.
7563 (GlobalAttribute.Emit): Remove.
7564 (Attribute.Resolve): Make virtual.
7565 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7566 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7567 the argument. Don't create one.
7568 (Attribute.GetObsoleteAttribute): Likewise.
7569 (Attribute.GetClsCompliantAttributeValue): Likewise.
7570 * class.cs, decl.cs: Update to changes.
7572 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7574 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7576 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7578 * statement.cs (Foreach.Resolve): Add error 186 report.
7580 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7582 * expression.cs (Conditional.DoResolve): Add warning 429.
7584 * statement.cs (If.Resolve): Add warning 665.
7586 2004-12-16 Raja R Harinath <rharinath@novell.com>
7588 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7589 except when in the parser, and in GlobalAttribute.
7590 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7591 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7592 RootContext.Tree.Types.NamespaceEntry once work is done.
7593 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7594 and resets RootContext.Tree.Types.NamespaceEntry.
7596 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7598 * cs-parser.jay: Don't create a block for every variable.
7600 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7602 * location.cs: Provide extra information.
7604 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7605 variables from the captured environment, it is the ldarg_0.
7607 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7609 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7612 * class.cs: Changed warning level for 169 to avoid developer
7613 displeasure from warning flooding. It will be changed back when they
7614 fix most of current BCL warnings.
7616 * RootContext.cs: Pushed default WarningLevel to 3.
7618 * statement.cs: Removed unused variable.
7620 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7622 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7623 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7624 Add error 502 report.
7625 (StaticClass.DefineType): Add error 441 report.
7626 (Class.AllowedModifiersProp): New virtual property as temporary
7627 extension to AllowedModifiers.
7628 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7629 to share implementation with StaticClass and don't call virtual
7632 * driver.cs (MainDriver): Add error 1558 test.
7634 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7635 report. Moved error 36 test here.
7637 * statement.cs (Throw.Resolve): Add error 724 report.
7639 * typemanager.cs: Add out_attribute_type core type.
7641 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7643 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7645 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7647 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7650 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7652 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7653 Add error 3023 report.
7654 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7656 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7659 2004-12-12 John Luke <john.luke@gmail.com>
7661 * driver.cs (AddArgs): take -- into account when
7662 adding arguments, fixes bug 65710
7664 2004-12-12 Martin Baulig <martin@ximian.com>
7666 * expression.cs (Unary.TryReduceNegative): Added support for
7667 SByteConstant and ByteConstant.
7668 (Unary.Reduce): Check error values from TryReduceNegative().
7670 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7672 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7673 and report exception as error 182.
7675 2004-12-10 Raja R Harinath <rharinath@novell.com>
7677 * driver.cs (Main): Fix message when there are warnings.
7679 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7681 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7683 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7685 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7686 Reduced number of warnings.
7688 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7690 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7692 * driver.cs: Removed message.
7694 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7696 2004-12-08 <vargaz@freemail.hu>
7698 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7700 2004-12-08 Martin Baulig <martin@ximian.com>
7702 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7703 instead of a CS3002 for properties and indexer.
7705 2004-12-08 Martin Baulig <martin@ximian.com>
7707 * decl.cs (MemberName.ToString): Make this work again.
7709 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7711 * attribute.cs (Resolve): Add error 591 detection.
7713 * class.cs (FieldMember.Define): Add error 1547 detection.
7714 (Indexer.Define): Add error 620 detection.
7715 (Operator.Define): Add error 590 detection.
7717 * ecore.cs: Missing argument for error 79.
7719 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7722 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7725 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7728 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7730 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7731 Some operator comments were suppressed.
7732 * doc.cs : Implicit/explicit operator name in doc comments are like
7733 "op_Explicit(type)~returnType", so added suffix handling.
7735 2005-01-21 Alp Toker <alp@atoker.com>
7737 * cs-parser.jay: destructor_declaration's container is PartialContainer
7738 not Class when partial types are used, so use Kind prop instead of 'is'.
7740 2004-12-12 Martin Baulig <martin@ximian.com>
7742 * expression.cs (Unary.TryReduceNegative): Added support for
7743 SByteConstant and ByteConstant.
7744 (Unary.Reduce): Check error values from TryReduceNegative().
7746 2004-12-11 Martin Baulig <martin@ximian.com>
7748 * support.cs (ReflectionParameters.ParameterName): If we have a
7749 `gpd', call `ParameterName' on it.
7751 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7753 * pending.cs (PendingImplementation.DefineProxy): Call
7754 DefineParameter() for all of the MethodBuilder's arguments.
7756 2004-12-09 Martin Baulig <martin@ximian.com>
7758 * doc.cs (DocUtil): Make this a static class.
7760 2004-12-09 Martin Baulig <martin@ximian.com>
7762 * expression.cs (Invocation.InferType): Moved the type inference
7763 implementation into TypeManager.
7765 * generics.cs (TypeManager): Moved the type inference
7766 implementation here.
7768 2004-12-09 Martin Baulig <martin@ximian.com>
7770 * typemanager.cs (TypeManager): Make this a partial class.
7773 (TypeManager): Move the generics part of `TypeManager' here.
7775 2004-12-08 Martin Baulig <martin@ximian.com>
7777 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7778 instead of a CS3002 for properties and indexer. Added CS3024
7779 check for generic interfaces.
7781 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
7782 instances are not CLS-compliant.
7784 2004-12-08 Martin Baulig <martin@ximian.com>
7787 (void_pointer_expression): New rule for `void*', `void**' etc.
7788 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
7790 2004-12-08 Martin Baulig <martin@ximian.com>
7792 * expression.cs (Invocation.InferType): Removed the hack for
7793 MethodCore.MayUnify().
7795 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
7798 * class.cs (MethodCore.MayUnify): Use
7799 TypeManager.MayBecomeEqualGenericTypes().
7801 2004-12-08 Martin Baulig <martin@ximian.com>
7803 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
7804 parameter, box it. Fixes #69233.
7806 2004-12-08 Martin Baulig <martin@ximian.com>
7808 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
7809 have the ctor constraint. Fixes #68326.
7811 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7813 * cs-parser.jay : interface comment was not consumed because of
7814 extra opt_semicolon before doc handling.
7816 2004-12-03 Raja R Harinath <rharinath@novell.com>
7818 Fix test-327.cs, test-328.cs, and put in early infrastructure
7819 for eventually fixing #52697.
7820 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
7821 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
7823 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
7824 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
7825 (VerifyUsing, error246): Update.
7826 * rootcontext.cs (RootContext.NamespaceLookup): Just use
7827 'NamespaceEntry.LookupNamespaceOrType'.
7829 2004-12-07 Martin Baulig <martin@ximian.com>
7831 * driver.cs: Call it "BETA SOFTWARE" :-)
7833 2004-12-06 Raja R Harinath <rharinath@novell.com>
7835 Fix crash on cs0657-17.cs.
7836 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7837 Use RootContext.Tree.Types, not 'new RootTypes ()'.
7838 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
7839 the case where the NamespaceEntry gets overwritten.
7841 2004-12-06 Marek Safar <marek.safar@seznam.cz>
7843 Fixed #69195, #56821
7844 * ecore.cs (ResolveBoolean): Tiny refactoring.
7846 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
7847 of right expression resolving when left is false constant and
7848 operator is LogicalAnd OR true constant and operator is LogicalOr.
7850 * statement.cs (ResolveUnreachable): Always reports warning.
7852 2004-12-05 Miguel de Icaza <miguel@ximian.com>
7854 * class.cs: Distinguish between 1721 and 1722 (just a little help
7855 for the programmer).
7857 2004-12-03 Miguel de Icaza <miguel@ximian.com>
7859 * delegate.cs: Only allow this on new versions of the language.
7861 2004-12-02 Duncan Mak <duncan@ximian.com>
7863 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
7865 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
7866 here as a static method. Take an additional bool out parameter
7867 `must_do_cs1540_check' for signaling to InstanceResolve.
7868 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
7869 member field from PropertyExpr class and made it an argument of
7871 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
7872 check for MarshalByRefObject, and report CS0122 instead of CS1540.
7873 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
7874 and `remove_accessor' as well as InstanceResolve: report CS0122
7879 2004-12-07 Martin Baulig <martin@ximian.com>
7881 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
7882 and CS0692 where appropriate.
7884 2004-12-06 Martin Baulig <martin@ximian.com>
7886 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
7887 IsDuplicateImplementation() and improved it.
7889 * expression.cs (Invocation.InferTypeArguments): Added
7890 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
7891 and removed the "ref" modifier from `infered_types'.
7893 * decl.cs (MemberName.ToString): Removed the exception.
7895 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
7897 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
7898 comments are allowed.
7900 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7902 * delegate.cs: Add checks for subtypes in paramaters and return values
7903 in VerifyMethod () to add support for Covariance/Contravariance
7906 2004-12-02 Miguel de Icaza <miguel@ximian.com>
7908 * report.cs: Remove extra closing parenthesis.
7910 * convert.cs (Error_CannotImplicitConversion): If the name of the
7911 types are the same, provide some extra information.
7913 2004-12-02 Marek Safar <marek.safar@seznam.cz>
7916 * attribute.cs (Resolve): Improved implementation of params
7917 attribute arguments.
7919 * support.cs (ParameterData): Add HasParams to be faster.
7921 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
7923 all things are for /doc support:
7925 * doc.cs: new file that supports XML documentation generation.
7926 * mcs.exe.sources: added doc.cs.
7928 Handle /doc command line option.
7929 Report error 2006 instead of 5 for missing file name for /doc.
7930 Generate XML documentation when required, after type resolution.
7932 Added support for picking up documentation (/// and /** ... */),
7933 including a new XmlCommentState enumeration.
7935 Added lines to fill Documentation element for field, constant,
7936 property, indexer, method, constructor, destructor, operator, event
7937 and class, struct, interface, delegate, enum.
7938 Added lines to warn incorrect comment.
7940 Added Documentation field (passed only when /doc was specified).
7942 Added DocComment, DocCommentHeader, GenerateDocComment() and
7943 OnGenerateDocComment() and some supporting private members for
7944 /doc feature to MemberCore.
7946 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
7948 Added overriden DocCommentHeader.
7950 Added overriden DocCommentHeader and GenerateDocComment().
7952 2004-12-01 Miguel de Icaza <miguel@ximian.com>
7954 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
7955 unwrapping the enumeration values, chain to
7956 DoConstantNumericPromotions again, so we can promote things to the
7957 fundamental types (takes care of enums that are bytes, sbytes).
7961 2004-12-01 Raja R Harinath <rharinath@novell.com>
7963 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
7964 Fix long-standing bug in type-lookup. Use FindType instead of
7965 LookupType when ec.ResolvingTypeTree.
7966 (Attribute.ResolveType, Attribute.Resolve)
7967 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
7969 (Attributes.Search): Remove internal version. Update.
7970 (Attributes.SearchMulti): Update.
7971 (Attributes.GetClsCompliantAttribute): Remove.
7972 (Attributes.GetIndexerNameAttribute): Remove.
7973 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
7974 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
7975 * class.cs (Indexer.Define): Likewise.
7977 2004-12-01 Marek Safar <marek.safar@seznam.cz>
7980 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
7981 MarshallByReference members access.
7983 * expression.cs: Use CheckMarshallByRefAccess;
7984 Better error CS0197 message.
7986 * report.cs: Print whole related error message.
7988 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7990 * class (GetClassBases): Better error 60 report.
7991 (EventProperty): Disabled warning 67 detection.
7993 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7996 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
7998 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
8001 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8004 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
8006 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
8008 2004-11-26 Miguel de Icaza <miguel@ximian.com>
8010 * attribute.cs (Attribute.Resolve): Refine error reporting and
8011 report a cs0117 if the identifier does not exist, to distinguish
8012 from 0617 which is a miss-use of the actual identifier.
8014 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
8015 between cs0070 and cs0079.
8017 * class.cs (MemberBase.DoDefine): When reporting a wrong
8018 accessibility level, we use MethodCore to compare instead of
8019 Method (this was a regression in some refactoring effort).
8021 So now we correctly report cs0056 again.
8023 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
8024 testing the target_type (which was known to be object_type) and
8025 not the source type (which is anonymous_method).
8027 Fixed reporting of error cs1660.
8029 * expression.cs (UserCast.Source): Expose the underlying cast.
8031 * statement.cs (Switch.SwitchGoverningType): Sort the list of
8032 allowed types to find a match to int32 first (most common).
8034 In addition, it ignores any ImplicitUserConversions that did an
8035 internal implicit conversion (as the switch statement allows only
8036 one integral conversion to exist).
8038 * class.cs (PartialContainer.Create): rename `name' to
8039 `member_name' for clarity. Then replace the string calls with a
8040 call to MemberName.GetPartialName, as now using
8041 MemberName.ToString is an error (this is due to the side effects
8042 it had, that were fixed in the past).
8044 This will restore the error reporting on a number of partial class
8045 errors that were missusing this (and getting an exception as a
8046 results, which is now just a plain textual warning, because
8047 yyparse debug output would crash otherwise).
8049 2004-11-26 Raja R Harinath <rharinath@novell.com>
8051 * Makefile (PROGRAM_INSTALL_DIR): Remove.
8053 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8055 * rootcontext.cs (LookupType): Make sure to cache lookups that
8056 don't give us a negative result. This saves about 5% of corlib
8059 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8061 * report.cs (AbstractMessage.Print): messages are sent to stderr
8063 * class.cs (TypeContainer.GetClassBases): It is an error to have a
8064 non-interface in the list of interfaces (at this point, either
8065 parent was properly set, or a base class is being listed in the
8066 interfaces section).
8068 This flags error 1722, and resolves the crash from bug 69259.
8070 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8072 * statement.cs (Using.EmitExpressionFinally): make this work right
8073 for valuetypes. Fixes 69926.
8075 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8077 * const.cs (Const.ChangeType): Cope with the "0 literal can be
8078 converted to an enum" here, before we try to change the underlying
8079 type. This code exists, but it is a different code path than the
8080 one used while encoding constants.
8082 (ImplicitReferenceConversionExists): In addition, resynchronized
8083 the code here, so it matches the same code in
8084 ImplicitReferenceConversionExists for the `from any class-type S
8085 to any interface-type T'.
8087 2004-11-25 Marek Safar <marek.safar@seznam.cz>
8089 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
8091 2004-11-24 Miguel de Icaza <miguel@ximian.com>
8093 * cs-parser.jay: Use verbosity accordingly.
8095 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8097 * expression.cs (Unary.ResolveOperator): Do not report warning;
8098 AddressOf reads from variable.
8100 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
8102 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8106 * attribute.cs (Attributable): Removed CheckTargets.
8107 (Attributes.Emit): Explicit attribute targets are tested here.
8109 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
8110 not enabled for interfaces.
8112 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
8113 (GetAssemblyName): Ouch next bug there.
8115 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8117 * expression.cs: Error 275 added.
8119 2004-11-23 Marek Safar <marek.safar@seznam.cz>
8121 Fix bug #69177 (Implemented decimal constant support)
8123 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
8124 (BinaryFold): Add DecimalConstant.
8126 * const.cs (Define): Decimal constant
8128 (ChangeType): Add decimal type handling.
8129 (LookupConstantValue): Don't set value for decimal type but
8130 emit DecimalConstantAttribute. Needed for constant optimization.
8132 * constant.cs (ToDecimal): New method.
8133 (ConvertToDecimal): New method.
8134 (IntConstant): Implemented ConvertToDecimal.
8135 (DecimalConstant.Emit): Emit optimized version for decimals in
8138 * expression.cs (ResolveOperator): Changed order of constant
8139 reduction to work correctly with native types which have
8140 overloaded operators.
8141 (ResolveMemberAccess): Extract constant value from attribute
8144 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
8146 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
8147 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
8148 (ChangeType): Decimal is special.
8149 (TypeToCoreType): Add decimal type.
8151 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8153 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8156 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8158 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8161 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8163 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8165 * pending.cs (PendingImplementation): Grab only interfaces.
8167 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8169 * statement.cs (ForeachHelperMethods): Add location member and
8170 error 202 detection.
8172 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8174 * expression.cs (DoResolveBase): Fixed wrong warning for out
8177 2004-12-04 Martin Baulig <martin@ximian.com>
8179 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8180 to check whether the conversion is ok.
8182 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8183 `Type.EmptyTypes' if we're not a generic TypeContainer.
8185 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8187 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8188 old bug: when converting from the null literal to a pointer,
8189 return an EmptyCast, not the NullLiteral.
8191 This fixes #69921, the recent null_type changes probably made this
8194 2004-12-03 Martin Baulig <martin@ximian.com>
8196 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8197 method as our child, call AnonymousMethod.Compatible() on it.
8199 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8201 * class.cs (FieldBase): Use an unused bit field from the field to
8202 encode the `has_offset' property from the FieldMember. This saves
8203 a couple of Ks on bootstrap compilation.
8205 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8206 method as our child, return the AnonymousMethod resolved
8209 * expression.cs (New.DoResolve): Allow return values from
8210 NewDelegate to also include AnonymousMethods.
8214 2004-11-29 Raja R Harinath <rharinath@novell.com>
8216 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8218 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8219 System.Runtime.InteropServices._Exception, since it's a base
8220 interface of the core type System.Exception in the net_2_0 profile.
8222 2004-11-27 Martin Baulig <martin@ximian.com>
8224 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8226 2004-11-26 Raja R Harinath <rharinath@novell.com>
8228 * Makefile: Convert to use executable.make.
8229 * gmcs.exe.sources: New.
8231 2004-11-25 Martin Baulig <martin@ximian.com>
8233 * expression.cs (Invocation.InferType): Added support for byref types.
8235 2004-11-25 Martin Baulig <martin@ximian.com>
8237 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8238 in TypeManager.TypeToCoreType().
8240 2004-11-25 Martin Baulig <martin@ximian.com>
8242 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8243 "Dispose" method from the `current_type'.
8244 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8245 DoDefineMembers() instead of using the MethodBuilder; this is
8246 required for generic iterators.
8248 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8250 2004-11-24 Martin Baulig <martin@ximian.com>
8252 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8254 2004-11-20 Martin Baulig <martin@ximian.com>
8256 * expression.cs (Invocation.InferType): Correctly infer generic
8257 instances; see gen-103.cs.
8258 (Invocation.InferTypeArguments): If a generic method doesn't have
8259 any unbound type parameters, we don't need to infer anything.
8261 2004-11-19 Raja R Harinath <rharinath@novell.com>
8263 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8265 2004-11-17 Raja R Harinath <rharinath@novell.com>
8267 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8268 (TypeHandle.GetMemberCache): New.
8269 (TypeHandle.TypeHandle): Update.
8270 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8271 (TypeManager.LookupParentInterfacesCache):
8272 Rename from LookupInterfaceCache. Optimize slightly.
8273 (TypeManager.MemberLookup_FindMembers): Update.
8274 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8276 (AddCacheContents): Rename from AddHashtable.
8277 * class.cs (TypeContainer.parent_container): Remove.
8278 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8279 (TypeContainer.DoDefineMembers): Don't initialize it.
8280 Update to name changes.
8282 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8284 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8285 that factors the code to check access modifiers on override.
8287 (PropertyBase): Use the code here.
8289 Patch from Lluis S'anchez, fixes bug #69361.
8291 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8293 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8294 routine that is used to report the use of a captured variable
8295 whose address has been taken.
8297 There are two checks: one when variables are being captured and
8298 the other check is when the address of a variable is taken.
8300 (because an anonymous methods might be resolved before *or* after
8301 the address has been taken) and
8303 * expression.cs (Conditional.DoResolve): Remove the special
8304 casing that Martin added to trueExpr and falseExpr being both
8305 NullLiteral. We get the right behavior now just by introducing
8306 the null_type into the compiler.
8308 * convert.cs (ExplicitConversion): Change the code to use
8309 null_type instead of testing `expr is NullLiteral'.
8310 (ImplicitConversionStandard): use null_type too.
8311 (ImplicitReferenceConversionExists): use null_type too.
8312 (ImplicitReferenceConversion): use null_type too.
8314 * literal.cs: The type of `NullLiteral' is now null_type instead
8316 (Resolve): Set the type here.
8318 * typemanager.cs: Introduce null_type.
8320 2004-11-18 Martin Baulig <martin@ximian.com>
8323 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8325 2004-11-18 Martin Baulig <martin@ximian.com>
8327 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8329 2004-11-18 Martin Baulig <martin@ximian.com>
8331 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8332 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8333 call ResolveConstructedType() on it to resolve it without checking
8335 (Constraints.ResolveTypes): Check them here.
8336 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8337 but don't check constraints.
8338 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8339 check constraints here.
8340 (ConstructedType.ResolveConstructedType): New public method. This
8341 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8342 resolve ourselves without checking constraints.
8344 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8346 2004-11-18 Martin Baulig <martin@ximian.com>
8349 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8351 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8353 2004-11-18 Martin Baulig <martin@ximian.com>
8355 * ecore.cs (TypeExpr.ResolveType): Removed.
8356 (Expression.ResolveAsTypeTerminal): We always return a fully
8357 resolved `TypeExpr', so we can just access its `Type'.
8359 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8361 2004-11-17 Martin Baulig <martin@ximian.com>
8363 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8364 sure we don't return any unresolved TypeExpr's.
8365 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8367 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8369 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8370 unresolved `ConstructedType's.
8372 2004-11-17 Martin Baulig <martin@ximian.com>
8374 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8376 2004-11-17 Martin Baulig <martin@ximian.com>
8379 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8381 * decl.cs (DeclSpace.ResolveType): Removed.
8382 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8384 2004-11-17 Martin Baulig <martin@ximian.com>
8386 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8387 direction, like FindMembers() does. Fixes #69546, testcase is in
8390 2004-11-16 Martin Baulig <martin@ximian.com>
8392 This is based on a patch from Marek Safar, see bug #69082.
8393 Fixes bugs #63705 and #67130.
8395 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8396 method; create a MemberCache for an interface type and cache the
8399 * decl.cs (IMemberContainer.ParentContainer): Removed.
8400 (IMemberContainer.ParentCache): New property.
8401 (MemberCache.SetupCacheForInterface): Removed.
8402 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8403 to create a cache for an interface's "parent".
8405 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8408 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8410 * statement.cs: Avoid adding bools to a hashtable.
8412 2004-11-15 Martin Baulig <martin@ximian.com>
8414 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8416 2004-11-11 Martin Baulig <martin@ximian.com>
8418 * typemanager.cs (TypeManager.GetMethodName): New method.
8420 * class.cs (MethodData.Define): Include the generic arity in the
8421 name of an explicit interface; also add it to the method name.
8423 * pending.cs (PendingImplementation.InterfaceMethod): The method
8424 name now includes the generic arity.
8426 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8428 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8429 calling an unsafe method from a safe location.
8431 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8434 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8436 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8438 * namespace.cs (VerifyUsing): use GetPartialName instead of
8441 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8443 * statement.cs (Return.Resolve): Fix regression in typo: if
8444 `in_exc', we have to request a NeedReturnLabel, this was a typo
8445 introduced in the anonymous method check-in. Fixes #69131.
8447 * Indexers were using the ShortName when defining themselves,
8448 causing a regression in the compiler bootstrap when applying the
8449 patch from 2004-11-02 (first part), now they use their full name
8450 and the bug is gone.
8452 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8454 * driver.cs: Strip the path from the names of embedded resources. Fixes
8457 2004-11-04 Raja R Harinath <rharinath@novell.com>
8459 Fix error message regression: cs0104-2.cs.
8460 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8461 (AliasEntry.Resolve): Update.
8462 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8464 (RootContext.LookupType): Update.
8466 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8468 * cs-parser.jay: Add support for handling accessor modifiers
8469 * class: Add support port accessor modifiers and error checking,
8470 define PropertyMethod.Define as virtual (not abstract anymore)
8471 * ecore.cs: Add checking for proeprties access with access modifiers
8472 * iterators.cs: Modify Accessor constructor call based in the modified
8474 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8476 * expression.cs (StringConcat): Handle being called twice,
8477 as when we have a concat in a field init with more than two
8480 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8482 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8483 special case explicit implementations, we should always produce
8484 the .property or .event declaration.
8486 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8487 since it will not return correct data if people use this
8488 unresolved in the presence of using statements (see test-313).
8490 * class.cs (MethodData.Define): If we are an explicit interface
8491 implementation, set the method name to the full name of the
8492 interface plus the name of the method.
8494 Notice that using the method.MethodName.GetFullName() does not
8495 work, as it will only contain the name as declared on the source
8496 file (it can be a shorthand in the presence of using statements)
8497 and not the fully qualifed type name, for example:
8501 class D : ICloneable {
8502 object ICloneable.Clone () {
8506 Would produce a method called `ICloneable.Clone' instead of
8507 `System.ICloneable.Clone'.
8509 * namespace.cs (Alias.Resolve): Use GetPartialName.
8511 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8513 * cs-parser.jay: Add error 1055 report.
8515 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8517 * assign.cs (Assign.DoResolve): Only do the transform of
8518 assignment into a New if the types are compatible, if not, fall
8519 through and let the implicit code deal with the errors and with
8520 the necessary conversions.
8522 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8524 * cs-parser.jay: Add error 1031 report.
8526 * cs-tokenizer.cs: Add location for error 1038.
8528 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8530 * cs-parser.jay: Add error 1016 report.
8532 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8534 * cs-parser.jay: Add errors 1575,1611 report.
8536 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8538 * cs-parser.jay: Add error 1001 report.
8540 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8543 * attribute.cs (GetMarshal): Add method argument for
8544 caller identification.
8546 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8547 agument for GetMarshal and RuntimeMissingSupport.
8549 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8551 * attribute.cs (ExtractSecurityPermissionSet): Removed
8552 TypeManager.code_access_permission_type.
8554 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8556 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8558 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8559 for obsolete use of a variable here. Fixes regression on errors
8560 cs0619-25 and cs0619-26.
8562 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8564 Fix #62358, implemented security attribute encoding.
8566 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8567 Tests permitted SecurityAction for assembly or other types.
8568 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8569 data from SecurityPermissionAttribute to PermisionSet class.
8571 * class.cs (ApplyAttributeBuilder): Added special handling
8572 for System.Security.Permissions.SecurityAttribute based types.
8574 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8575 special handling for System.Security.Permissions.SecurityAttribute
8578 * enum.cs (ApplyAttributeBuilder): Added special handling
8579 for System.Security.Permissions.SecurityAttribute based types.
8581 * parameter.cs (ApplyAttributeBuilder): Added special handling
8582 for System.Security.Permissions.SecurityAttribute based types.
8584 * rootcontext.cs: Next 2 core types.
8586 * typemanager.cs (TypeManager.security_permission_attr_type):
8587 Built in type for the SecurityPermission Attribute.
8588 (code_access_permission_type): Build in type.
8590 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8592 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8593 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8594 all of this information into
8595 EmitContext.EmitCapturedVariableInstance.
8597 * codegen.cs (EmitCapturedVariableInstance): move here the
8598 funcionality of emitting an ldarg.0 in the presence of a
8599 remapping. This centralizes the instance emit code.
8601 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8602 then emit a load of this: it means that we have reached the
8603 topmost ScopeInfo: the one that contains the pointer to the
8604 instance of the class hosting the anonymous method.
8606 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8607 captures to the topmost CaptureContext.
8609 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8611 * expression.cs (LocalVariableReference): Move the knowledge about
8612 the iterators into codegen's EmitCapturedVariableInstance.
8614 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8616 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8617 all code paths return a value from an anonymous method (it is the
8618 same as the 161 error, but for anonymous methods).
8620 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8622 The introduction of anonymous methods in the compiler changed
8623 various ways of doing things in the compiler. The most
8624 significant one is the hard split between the resolution phase
8625 and the emission phases of the compiler.
8627 For instance, routines that referenced local variables no
8628 longer can safely create temporary variables during the
8629 resolution phase: they must do so from the emission phase,
8630 since the variable might have been "captured", hence access to
8631 it can not be done with the local-variable operations from the runtime.
8635 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8636 is a toplevel block.
8638 (ToplevelBlock): A new kind of Block, these are the blocks that
8639 are created by the parser for all toplevel method bodies. These
8640 include methods, accessors and anonymous methods.
8642 These contain some extra information not found in regular blocks:
8643 A pointer to an optional CaptureContext (for tracking captured
8644 local variables and parameters). A pointer to the parent
8647 (Return.Resolve): Catch missmatches when returning a value from an
8648 anonymous method (error 1662).
8649 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8652 (Break.Resolve): ditto.
8654 (SwitchLabel): instead of defining the labels during the
8655 resolution phase, we now turned the public ILLabel and ILLabelCode
8656 labels into methods called GetILLabelCode() and GetILLabel() that
8657 only define the label during the Emit phase.
8659 (GotoCase): Track the SwitchLabel instead of the computed label
8660 (its contained therein). Emit the code by using
8661 SwitchLabel.GetILLabelCode ().
8663 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8664 whether the Local has been captured or not.
8666 (LocalInfo.IsCaptured): New property, used to tell whether the
8667 local has been captured.
8669 * anonymous.cs: Vastly updated to contain the anonymous method
8672 The main classes here are: CaptureContext which tracks any
8673 captured information for a toplevel block and ScopeInfo used to
8674 track the activation frames for various local variables.
8676 Each toplevel block has an optional capture context associated
8677 with it. When a method contains an anonymous method both the
8678 toplevel method and the anonymous method will create a capture
8679 context. When variables or parameters are captured, they are
8680 recorded on the CaptureContext that owns them, for example:
8684 MyDelegate d = delegate {
8689 Here `a' will be recorded as captured on the toplevel
8690 CapturedContext, the inner captured context will not have anything
8691 (it will only have data if local variables or parameters from it
8692 are captured in a nested anonymous method.
8694 The ScopeInfo is used to track the activation frames for local
8695 variables, for example:
8697 for (int i = 0; i < 10; i++)
8698 for (int j = 0; j < 10; j++){
8699 MyDelegate d = delegate {
8704 At runtime this captures a single captured variable `i', but it
8705 captures 10 different versions of the variable `j'. The variable
8706 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8707 recorded on a child.
8709 The toplevel ScopeInfo will also track information like the `this'
8710 pointer if instance variables were referenced (this is necessary
8711 as the anonymous method lives inside a nested class in the host
8712 type of the method).
8714 (AnonymousMethod): Expanded to track the Toplevel, implement
8715 `AnonymousMethod.Compatible' to tell whether an anonymous method
8716 can be converted to a target delegate type.
8718 The routine now also produces the anonymous method content
8720 (AnonymousDelegate): A helper class that derives from
8721 DelegateCreation, this is used to generate the code necessary to
8722 produce the delegate for the anonymous method that was created.
8724 * assign.cs: API adjustments for new changes in
8725 Convert.ImplicitStandardConversionExists.
8727 * class.cs: Adjustments to cope with the fact that now toplevel
8728 blocks are of type `ToplevelBlock'.
8730 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8731 insteda of standard blocks.
8733 Flag errors if params arguments are passed to anonymous methods.
8735 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8736 `CurrentAnonymousMethod' which points to the current Anonymous
8737 Method. The variable points to the AnonymousMethod class that
8738 holds the code being compiled. It is set in the new EmitContext
8739 created for the anonymous method.
8741 (EmitContext.Phase): Introduce a variable and an enumeration to
8742 assist in enforcing some rules about when and where we are allowed
8743 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8744 only one that enfonces this right now).
8746 (EmitContext.HaveCaptureInfo): new helper method that returns
8747 whether we have a CapturedContext initialized.
8749 (EmitContext.CaptureVariable): New method used to register that a
8750 LocalInfo must be flagged for capturing.
8752 (EmitContext.CapturedParameter): New method used to register that a
8753 parameters must be flagged for capturing.
8755 (EmitContext.CapturedField): New method used to register that a
8756 field must be flagged for capturing.
8758 (EmitContext.HaveCapturedVariables,
8759 EmitContext.HaveCapturedFields): Return whether there are captured
8760 variables or fields.
8762 (EmitContext.EmitMethodHostInstance): This is used to emit the
8763 instance for the anonymous method. The instance might be null
8764 (static methods), this (for anonymous methods that capture nothing
8765 and happen to live side-by-side with the current method body) or a
8766 more complicated expression if the method has a CaptureContext.
8768 (EmitContext.EmitTopBlock): Routine that drives the emission of
8769 code: it will first resolve the top block, then emit any metadata
8770 and then emit the code. The split is done so that we can extract
8771 any anonymous methods and flag any captured variables/parameters.
8773 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
8774 during this phase, the ILGenerator should not be used as labels
8775 and local variables declared here might not be accessible to any
8776 code that is part of an anonymous method.
8778 Exceptions to this include the temporary variables that are
8779 created by some statements internally for holding temporary
8782 (EmitContext.EmitMeta): New routine, in charge of emitting all the
8785 (EmitContext.TemporaryReturn): This method is typically called
8786 from the Emit phase, and its the only place where we allow the
8787 ReturnLabel to be defined other than the EmitMeta. The reason is
8788 that otherwise we would have to duplicate a lot of logic in the
8789 Resolve phases of various methods that today is on the Emit
8792 (EmitContext.NeedReturnLabel): This no longer creates the label,
8793 as the ILGenerator is not valid during the resolve phase.
8795 (EmitContext.EmitThis): Extended the knowledge in this class to
8796 work in anonymous methods in addition to iterators.
8798 (EmitContext.EmitCapturedVariableInstance): This emits whatever
8799 code is necessary on the stack to access the instance to a local
8800 variable (the variable will be accessed as a field).
8802 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
8803 EmitContext.EmitAddressOfParameter): Routines to support
8804 parameters (not completed at this point).
8806 Removals: Removed RemapLocal and RemapLocalLValue. We probably
8807 will also remove the parameters.
8809 * convert.cs (Convert): Define a `ConstantEC' which points to a
8810 null. This is just to prefity some code that uses
8811 ImplicitStandardConversion code and do not have an EmitContext
8814 The idea is to flag explicitly that at that point in time, it is
8815 known that the conversion will not trigger the delegate checking
8816 code in implicit conversions (which requires a valid
8819 Everywhere: pass new EmitContext parameter since
8820 ImplicitStandardConversionExists now requires it to check for
8821 anonymous method conversions.
8823 (Convert.ImplicitStandardConversionExists): If the type of an
8824 expression is the anonymous_method_type, and the type is a
8825 delegate, we invoke the AnonymousMethod.Compatible method to check
8826 whether an implicit conversion is possible.
8828 (Convert.ImplicitConversionStandard): Only do implicit method
8829 group conversions if the language level is not ISO_1.
8831 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
8832 MethodInfo for the Invoke method. used by Delegate and
8835 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
8836 method conversions if the target type is a delegate.
8838 Removed extra debugging nops.
8840 (LocalVariableReference): Turn the `local_info' into a public
8843 Add `prepared' field, the same hack used for FieldExprs to cope
8844 with composed assignments, as Local variables do not necessarily
8845 operate purely on the stack as they used to: they can be captured
8848 Add `temp' for a temporary result, like fields.
8850 Refactor DoResolve and DoResolveLValue into DoResolveBase.
8852 It now copes with Local variables that are captured and emits the
8853 proper instance variable to load it from a field in the captured
8856 (ParameterReference.DoResolveBase): During the resolve phase,
8857 capture parameters if we are in an anonymous method.
8859 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
8860 anonymous method, use the EmitContext helper routines to emit the
8861 parameter reference.
8863 * iterators.cs: Set RemapToProxy to true/false during the
8866 * parameters.cs (GetParameterByName): New helper method.
8868 * typemanager.cs (anonymous_method_type) a new type that
8869 represents an anonyous method. This is always an internal type,
8870 used as a fencepost to test against the anonymous-methodness of an
8873 2004-10-20 Marek Safar <marek.safar@seznam.cz>
8875 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
8877 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
8879 2004-11-10 Martin Baulig <martin@ximian.com>
8881 * expression.cs (Invocation.BetterFunction): If two methods have
8882 equal parameter types, but only one of them is generic, the
8883 non-generic one wins.
8884 (New.DoResolve): Don't set `is_struct' to false if we're a generic
8885 instance; just use `Type.IsValueType' to determine whether
8886 something is a struct or not.
8887 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
8888 so we can be called multiple times.
8890 2004-11-10 Martin Baulig <martin@ximian.com>
8892 * generic.cs (TypeParameter.DefineConstraints): New public method.
8893 (TypeParameter.CheckAccessLevel): Override this and return true.
8894 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
8895 override ResolveType() anymore.
8896 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
8898 2004-11-10 Martin Baulig <martin@ximian.com>
8900 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
8901 call DeclSpace.ResolveNestedType() on it.
8903 2004-11-10 Martin Baulig <martin@ximian.com>
8905 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
8906 non-null, call ParameterModifier() on it.
8908 2004-11-10 Martin Baulig <martin@ximian.com>
8911 (Iterators): Added `current_type' and `this_type' fields.
8912 (Iterators.DefineIterator): Create a new EmitContext and store it
8913 in `ec'; compute `this_type'.
8915 2004-11-10 Martin Baulig <martin@ximian.com>
8918 (TypeManager.IsPrivateAccessible): New public method.
8919 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
8921 2004-11-10 Martin Baulig <martin@ximian.com>
8923 * class.cs (TypeContainer.DefineType): Call
8924 TypeBuilder.DefineGenericParameters() before resolving the type
8926 (MethodData.parent_method): New protected field.
8927 (MethodData..ctor): Added `MethodInfo parent_method' argument.
8928 (MethodData.Define): Compute `parent_method'.
8931 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
8932 (MemberCore.GetClsCompliantAttributeValue): Likewise.
8933 (DeclSpace.ec): New protected field; store the EmitContext here.
8934 (DeclSpace.EmitContext): New public property.
8935 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
8936 (DeclSpace.ResolveNestedType): New public method.
8937 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
8938 (DeclSpace.NestedAccessible): Added `Type tb' argument.
8939 (DeclSpace.FamilyAccessible): Likewise.
8940 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
8941 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
8944 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
8947 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
8948 (Enum.Emit): Don't create a new EmitContext.
8950 2004-10-18 Martin Baulig <martin@ximian.com>
8952 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
8953 `Type' directly, but call ResolveType() on it.
8954 (Catch.Resolve): Likewise.
8955 (Foreach.Resolve): Likewise.
8957 2004-10-18 Martin Baulig <martin@ximian.com>
8959 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
8960 `Type' directly, but call ResolveType() on it.
8961 (Probe.DoResolve): Likewise.
8962 (ArrayCreation.LookupType): Likewise.
8963 (TypeOf.DoResolve): Likewise.
8964 (SizeOf.DoResolve): Likewise.
8966 2004-10-18 Raja R Harinath <rharinath@novell.com>
8968 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
8971 2004-10-17 John Luke <john.luke@gmail.com>
8973 * class.cs (Operator.GetSignatureForError): use CSharpName
8975 * parameter.cs (Parameter.GetSignatureForError): Returns
8976 correct name even if was not defined.
8978 2004-10-13 Raja R Harinath <rharinath@novell.com>
8981 * class.cs (TypeContainer.EmitContext): New property.
8982 (DefineNestedTypes): Create an emitcontext for each part.
8983 (MethodCore.DoDefineParameters): Use container's emitcontext.
8984 Pass type array to InternalParameters.
8985 (MemberBase.DoDefine): Use container's emitcontext.
8986 (FieldMember.Define): Likewise.
8987 (Event.Define): Likewise.
8988 (SetMethod.GetParameterInfo): Change argument to EmitContext.
8989 Pass type array to InternalParameters.
8990 (SetIndexerMethod.GetParameterInfo): Likewise.
8991 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
8992 * delegate.cs (Define): Pass emitcontext to
8993 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
8994 array to InternalParameters.
8995 * expression.cs (ParameterReference.DoResolveBase): Pass
8996 emitcontext to GetParameterInfo.
8997 (ComposedCast.DoResolveAsTypeStep): Remove check on
8998 ec.ResolvingTypeTree.
8999 * parameter.cs (Parameter.Resolve): Change argument to
9000 EmitContext. Use ResolveAsTypeTerminal.
9001 (Parameter.GetSignature): Change argument to EmitContext.
9002 (Parameters.ComputeSignature): Likewise.
9003 (Parameters.ComputeParameterTypes): Likewise.
9004 (Parameters.GetParameterInfo): Likewise.
9005 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9006 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9007 * support.cs (InternalParameters..ctor): Remove variant that takes
9009 * typemanager.cs (system_intptr_expr): New.
9010 (InitExpressionTypes): Initialize it.
9012 2004-10-12 Chris Toshok <toshok@ximian.com>
9014 * cs-parser.jay: fix location for try_statement and catch_clause.
9016 2004-10-18 Martin Baulig <martin@ximian.com>
9018 * class.cs (FieldMember.Define): Don't access the TypeExpr's
9019 `Type' directly, but call ResolveType() on it.
9020 (MemberBase.DoDefine): Likewise.
9022 * expression.cs (New.DoResolve): Don't access the TypeExpr's
9023 `Type' directly, but call ResolveType() on it.
9024 (ComposedCast.DoResolveAsTypeStep): Likewise.
9026 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
9027 `Type' directly, but call ResolveType() on it.
9029 2004-10-17 John Luke <john.luke@gmail.com>
9031 * class.cs (Operator.GetSignatureForError): use CSharpName
9033 * parameter.cs (Parameter.GetSignatureForError): Returns
9034 correct name even if was not defined.
9036 2004-10-13 Raja R Harinath <rharinath@novell.com>
9039 * class.cs (TypeContainer.EmitContext): New property.
9040 (DefineNestedTypes): Create an emitcontext for each part.
9041 (MethodCore.DoDefineParameters): Use container's emitcontext.
9042 Pass type array to InternalParameters.
9043 (MemberBase.DoDefine): Use container's emitcontext.
9044 (FieldMember.Define): Likewise.
9045 (Event.Define): Likewise.
9046 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9047 Pass type array to InternalParameters.
9048 (SetIndexerMethod.GetParameterInfo): Likewise.
9049 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9050 * delegate.cs (Define): Pass emitcontext to
9051 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9052 array to InternalParameters.
9053 * expression.cs (ParameterReference.DoResolveBase): Pass
9054 emitcontext to GetParameterInfo.
9055 (ComposedCast.DoResolveAsTypeStep): Remove check on
9056 ec.ResolvingTypeTree.
9057 * parameter.cs (Parameter.Resolve): Change argument to
9058 EmitContext. Use ResolveAsTypeTerminal.
9059 (Parameter.GetSignature): Change argument to EmitContext.
9060 (Parameters.ComputeSignature): Likewise.
9061 (Parameters.ComputeParameterTypes): Likewise.
9062 (Parameters.GetParameterInfo): Likewise.
9063 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9064 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9065 * support.cs (InternalParameters..ctor): Remove variant that takes
9067 * typemanager.cs (system_intptr_expr): New.
9068 (InitExpressionTypes): Initialize it.
9070 2004-10-12 Chris Toshok <toshok@ximian.com>
9072 * cs-parser.jay: fix location for try_statement and catch_clause.
9074 2004-10-07 Raja R Harinath <rharinath@novell.com>
9076 More DeclSpace.ResolveType avoidance.
9077 * decl.cs (MemberCore.InUnsafe): New property.
9078 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
9079 with newly created EmitContext.
9080 (FieldMember.Define): Likewise.
9081 * delegate.cs (Delegate.Define): Likewise.
9082 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
9083 only if normal name-lookup fails.
9084 (TypeExpr.DoResolve): Enable error-checking.
9085 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
9086 (SizeOf.DoResolve): Likewise.
9087 (ComposedCast.DoResolveAsTypeStep): Likewise.
9088 (StackAlloc.DoResolve): Likewise.
9089 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
9090 (Block.Unsafe): New property.
9091 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
9092 (Unsafe): Set 'unsafe' flag of contained block.
9093 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
9094 (Fixed.Resolve): Likewise.
9095 (Catch.Resolve): Likewise.
9096 (Using.ResolveLocalVariableDecls): Likewise.
9097 (Foreach.Resolve): Likewise.
9099 2004-10-05 John Luke <john.luke@gmail.com>
9101 * cs-parser.jay: add location to error CS0175
9103 2004-10-04 Miguel de Icaza <miguel@ximian.com>
9105 * ecore.cs (Expression.Constantity): Add support for turning null
9108 * const.cs (Const.Define): Allow constants to be reference types
9109 as long as the value is Null.
9111 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
9113 * namespace.cs (NamespaceEntry.Using): No matter which warning
9114 level is set, check if this namespace name has already been added.
9116 2004-10-03 Ben Maurer <bmaurer@ximian.com>
9118 * expression.cs: reftype [!=]= null should always use br[true,false].
9121 2004-10-03 Marek Safar <marek.safar@seznam.cz>
9124 * attribute.cs: Enum conversion moved to
9125 GetAttributeArgumentExpression to be applied to the all
9128 2004-10-01 Raja R Harinath <rharinath@novell.com>
9130 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
9131 * class.c (TypeContainer.DefineType): Flag error if
9132 base types aren't accessible due to access permissions.
9133 * decl.cs (DeclSpace.ResolveType): Move logic to
9134 Expression.ResolveAsTypeTerminal.
9135 (DeclSpace.ResolveTypeExpr): Thin layer over
9136 Expression.ResolveAsTypeTerminal.
9137 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
9138 Refactor code into NestedAccess. Use it.
9139 (DeclSpace.NestedAccess): New.
9140 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
9141 argument to silence errors. Check access permissions.
9142 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
9143 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
9144 (Cast.DoResolve): Likewise.
9145 (New.DoResolve): Likewise.
9146 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
9147 (TypeOf.DoResolve): Likewise.
9149 * expression.cs (Invocation.BetterConversion): Return the Type of
9150 the better conversion. Implement section 14.4.2.3 more faithfully.
9151 (Invocation.BetterFunction): Make boolean. Make correspondence to
9152 section 14.4.2.2 explicit.
9153 (Invocation.OverloadResolve): Update.
9154 (Invocation): Remove is_base field.
9155 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9156 (Invocation.Emit): Likewise.
9158 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9160 * cs-parser.jay: Reverted 642 warning fix.
9162 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9165 * decl.cs (FindMemberWithSameName): Indexer can have more than
9168 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9170 * expression.cs (LocalVariableReference.DoResolveLValue):
9171 Do not report warning 219 for out values.
9172 (EmptyExpression.Null): New member to avoid extra allocations.
9174 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9176 * cs-parser.jay: Fix wrong warning 642 report.
9178 * cs-tokenizer.cs (CheckNextToken): New helper;
9179 Inspect next character if is same as expected.
9181 2004-09-23 Martin Baulig <martin@ximian.com>
9183 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9184 (Convert.ImplicitReferenceConversionExists): Likewise.
9186 2004-11-09 Raja R Harinath <rharinath@novell.com>
9188 * Makefile (DISTFILES): Comment out a few missing files.
9190 2004-10-29 Raja R Harinath <rharinath@novell.com>
9192 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9193 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9194 (gmcs.exe): Invoke bootstrap-libs.
9195 (clean-local): Clean the net_2_0_bootstrap profile too.
9196 (PROGRAM_INSTALL_DIR): New.
9197 (install-local): Use it.
9199 2004-10-13 Martin Baulig <martin@ximian.com>
9201 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9202 (TypeParameter.DefineType): If we're a method type parameter and
9203 that method is overriding something, "inflate" its constraints.
9205 2004-10-12 Martin Baulig <martin@ximian.com>
9207 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9208 and have type arguments, create and resolve a ConstructedType.
9210 2004-10-12 Martin Baulig <martin@ximian.com>
9212 * decl.cs (MemberCache.FindMemberToOverride): Use
9213 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9214 to compare the invocationType.
9216 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9217 When comparing two type parameters, only do the signature-only
9218 comparision for method type parameters.
9220 2004-10-11 Martin Baulig <martin@ximian.com>
9222 * report.cs: Don't make --fatal abort on warnings, we have
9223 -warnaserror for that.
9225 2004-10-11 Martin Baulig <martin@ximian.com>
9228 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9229 (TypeManager.IsEqual): Call ourself recursively instead of using
9232 2004-10-11 Martin Baulig <martin@ximian.com>
9234 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9235 on our own type parameters, not on the ones we inherit from a containing
9238 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9241 * generic.cs (TypeParameter.Define): We may only be called once.
9243 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9244 instead of TypeManager.IsEqual().
9246 2004-09-28 Martin Baulig <martin@ximian.com>
9249 (GenericConstraints.EffectiveBaseClass): New public property.
9250 (TypeParameter.GenericConstraints): New public property.
9251 (ConstructedType.CheckConstraints): Improved.
9253 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9254 (Convert.TypeParameterConversion): New private method; use this in
9255 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9256 for all conversions related to type parameters.
9258 2004-09-24 Martin Baulig <martin@ximian.com>
9260 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9261 type parameter conversions for type parameters which are known to
9264 2004-09-24 Martin Baulig <martin@ximian.com>
9266 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9267 `IsValueType' properties.
9269 * support.cs (ReflectionConstraints): Use
9270 Type.GetGenericParameterConstraints() instead of the old hack.
9272 2004-09-24 Martin Baulig <martin@ximian.com>
9274 * generic.cs (GenericConstraints): Moved here and made it an
9277 * support.cs (GenericConstraints): Moved to generic.cs.
9279 2004-09-24 Martin Baulig <martin@ximian.com>
9282 (ReflectionConstraints): Un-nested this class and made it public.
9285 (TypeManager.GetTypeParameterConstraints): New public method.
9286 (TypeManager.HasConstructorConstraint): Use the attributes.
9288 2004-09-24 Martin Baulig <martin@ximian.com>
9290 * support.cs (GenericConstraints): Replaced `HasConstructor',
9291 `IsReferenceType' and `IsValueType' with `Attributes'.
9292 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9293 method and made the .ctor public.
9295 * generic.cs (Constraints.Attributes): New public property.
9296 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9297 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9298 `IsValueType' -> `HasValueTypeConstraint'.
9300 2004-09-23 Martin Baulig <martin@ximian.com>
9302 * generic.cs (Constraints): Reflect latest runtime changes.
9304 2004-09-23 Martin Baulig <martin@ximian.com>
9306 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9307 (Convert.ImplicitReferenceConversionExists): Likewise.
9309 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9311 * class.cs (Operator.Define): Add error 448 and 559 report.
9313 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9315 * class.cs (MemberBase.IsTypePermitted): New protected
9316 method for checking error CS0610.
9318 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9320 * class.cs (TypeContainer.HasExplicitLayout): New property
9321 Returns whether container has StructLayout attribute set Explicit.
9322 (FieldMember): New abstract class for consts and fields.
9323 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9324 (Field): Reuse FieldMember.
9326 * const.cs (Const): Reuse FieldMember.
9328 * rootcontext.cs: EmitConstants call moved to class.
9330 2004-09-22 Martin Baulig <martin@ximian.com>
9332 Marek and me just fixed one of our oldest bugs: #28562 :-)
9334 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9336 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9337 we're an EnumConstant, just return that.
9338 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9339 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9340 to get the value which'll actually be written into the attribute.
9341 However, we have to use GetValue() to access the attribute's value
9344 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9346 * constant.cs (Constant.IsNegative): New abstract property
9349 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9350 (StackAlloc.DoResolve): Reused IsNegative.
9352 2004-09-22 Martin Baulig <martin@ximian.com>
9354 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9355 public method; like LookupTypeContainer, but also works for
9358 * report.cs (Report.SymbolRelatedToPreviousError): Use
9359 TypeManager.LookupGenericTypeContainer().
9361 2004-09-22 Martin Baulig <martin@ximian.com>
9363 Thanks to Peter Sestoft for this bug report.
9365 * expression.cs (Conditional): If both the `trueExpr' and the
9366 `falseExpr' is a NullLiteral, return a NullLiteral.
9368 2004-09-22 Martin Baulig <martin@ximian.com>
9370 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9371 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9372 for the "get_Current" call.
9374 2004-09-21 Martin Baulig <martin@ximian.com>
9376 * convert.cs (Convert.ImplicitReferenceConversion): When
9377 converting to an interface type, first check whether we're
9378 converting from a reference type.
9380 2004-09-14 Martin Baulig <martin@ximian.com>
9382 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9384 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9387 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9388 called and is obsolete then this member suppress message
9389 when call is inside next [Obsolete] method or type.
9391 * expression.cs: Use TestObsoleteMethodUsage member.
9393 2004-09-14 Martin Baulig <martin@ximian.com>
9395 * genericparser.cs: Removed.
9397 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9399 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9401 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9403 * attribute.cs (Attribute.Resolve): Add error 653 report.
9405 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9407 (Method.ApplyAttributeBuilder): Add error 685 report.
9408 (Operator.Define): Add error 564 report.
9410 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9412 * expression.cs (Invocation.DoResolve): Add error
9415 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9418 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9420 * class.cs (ConstructorInitializer.Resolve):
9421 Wrong error number (515->516).
9423 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9425 * class.cs (Indexer.Define): Add error 631 report.
9427 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9429 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9431 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9433 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9435 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9437 * cs-parser.jay: Added error CS0241 report.
9439 2004-09-10 Raja R Harinath <rharinath@novell.com>
9441 * cs-parser.jay (fixed_statement): Introduce a scope for the
9442 declaration in the 'fixed' statement.
9444 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9446 * cs-parser.jay: Added CS0230 error report.
9448 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9450 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9452 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9454 * expression.cs (Argument.Resolve): Added error CS0192 and
9457 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9459 C# 2.0 #pragma warning feature
9461 * cs-tokenizer.cs (PreProcessPragma): New method;
9462 Handles #pragma directive.
9464 * report.cs (WarningRegions): New class; Support
9465 class for #pragma warning directive. It tests whether
9466 warning is enabled for a given line.
9468 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9470 * const.cs: Add more descriptive error report, tahnks to
9473 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9475 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9477 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9479 * expression.cs: Apply patch from Ben: Remove dead code from
9480 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9481 as that code just threw an exception anwyays.
9483 * const.cs: Remove the call to the turnintoconstant, for details
9486 * literal.cs: The type of the null-literal is the null type; So
9487 we use a placeholder type (literal.cs:System.Null, defined here)
9490 * expression.cs (Conditional.DoResolve): Remove some old code that
9491 is no longer needed, conversions have been fixed.
9493 (ArrayCreationExpression.DoResolve): Return false if we fail to
9494 resolve the inner expression.
9496 2004-09-07 Raja R Harinath <rharinath@novell.com>
9499 * cs-parser.jay (delegate_declaration): Record a delegate
9500 declaration as a type declaration.
9501 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9503 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9505 * parameter.cs: Do not crash if the type can not be resolved.
9507 * expression.cs: Report errors with unsafe pointers, fixes #64896
9509 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9511 * expression.cs: Pointer arith always needs to do a conv.i
9512 if the operand is a long. fix 65320
9514 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9516 Fixed cs0619-37.cs, cs0619-38.cs
9518 * enum.cs (GetObsoleteAttribute): Removed.
9520 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9521 on Enum member is double staged. The first is tested member
9524 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9526 Fixed #56986, #63631, #65231
9528 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9529 adds member to name container.
9530 (TypeContainer.AddToTypeContainer): New method, adds type to
9532 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9533 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9534 AddOperator): Simplified by reusing AddToMemberContainer.
9535 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9537 (Method.CheckForDuplications): Fixed implementation to test all
9539 (MemberBase): Detection whether member is explicit interface
9540 implementation is now in constructor.
9541 (MemberBase.UpdateMemberName): Handles IndexerName.
9542 (Accessor): Changed to keep also location information.
9543 (AbstractPropertyEventMethod): Is derived from MemberCore.
9544 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9545 will be emited or not.
9546 (PropertyBase.AreAccessorsDuplicateImplementation):
9547 Tests whether accessors are not in collision with some method.
9548 (Operator): Is derived from MethodCore to simplify common
9551 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9553 (DeclSpace.AddToContainer): Adds the member to defined_names
9554 table. It tests for duplications and enclosing name conflicts.
9556 * enum.cs (EnumMember): Clean up to reuse the base structures
9558 2004-09-03 Martin Baulig <martin@ximian.com>
9560 Merged latest changes into gmcs. Please keep this comment in
9561 here, it makes it easier for me to see what changed in MCS since
9562 the last time I merged.
9564 2004-09-03 Martin Baulig <martin@ximian.com>
9566 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9567 into TypeContainer, to make partial classes work again.
9569 2004-09-03 Martin Baulig <martin@ximian.com>
9571 * rootcontext.cs (RootContext.V2): Removed.
9573 2004-03-23 Martin Baulig <martin@ximian.com>
9575 * expression.cs (Invocation.OverloadResolve): Added `bool
9576 may_fail' argument and use it instead of the Location.IsNull() hack.
9578 2004-09-09 Martin Baulig <martin@ximian.com>
9580 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9582 2004-09-09 Martin Baulig <martin@ximian.com>
9584 * generic.cs (TypeParameter.DefineType): Added support for
9585 explicit interface methods.
9587 2004-09-09 Martin Baulig <martin@ximian.com>
9589 * README.Changes: New document. Started to list important changes
9590 between MCS and GMCS here.
9592 2004-09-08 Martin Baulig <martin@ximian.com>
9595 (TypeContainer.CheckRecursiveDefinition): New protected method.
9596 (TypeContainer.DefineType): Move the CS0146 check into
9597 CheckRecursiveDefinition().
9599 2004-09-06 Martin Baulig <martin@ximian.com>
9601 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9602 types for the constructor constraint.
9604 2004-09-03 Martin Baulig <martin@ximian.com>
9606 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9607 into TypeContainer, to make partial classes work again.
9609 2004-09-03 Martin Baulig <martin@ximian.com>
9611 * rootcontext.cs (RootContext.V2): Removed.
9613 2004-03-23 Martin Baulig <martin@ximian.com>
9615 * expression.cs (Invocation.OverloadResolve): Added `bool
9616 may_fail' argument and use it instead of the Location.IsNull() hack.
9618 2004-09-03 Martin Baulig <martin@ximian.com>
9620 Merged latest changes into gmcs. Please keep this comment in
9621 here, it makes it easier for me to see what changed in MCS since
9622 the last time I merged.
9624 2004-09-03 Raja R Harinath <rharinath@novell.com>
9627 * expression.cs (BetterConversion): Don't allow either conversion
9628 to be null. Remove redundant implicit conversion test when 'q ==
9629 null' -- when this function is invoked, we already know that the
9630 implicit conversion exists.
9631 (BetterFunction): Assume that 'best' is non-null. Remove
9632 redundant reimplementation of IsApplicable when 'best' is null.
9633 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9634 number of arguments.
9635 (IsAncestralType): Extract from OverloadResolve.
9636 (OverloadResolve): Make robust to the MethodGroupExpr being
9637 unsorted. Implement all the logic of Section 14.5.5.1, and
9638 support overloading of methods from multiple applicable types.
9639 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9641 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9642 (RealError, Warning): Append type of report to related symbol.
9644 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9646 * enum.cs: Fixed CLS-Compliance checks for enum members.
9647 Error tests cs3008-8.cs, cs3014-8.cs
9649 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9651 Fixed bug #62342, #63102
9652 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9653 like ImplementMethod.
9655 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9657 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9660 2004-09-02 Martin Baulig <martin@ximian.com>
9662 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9663 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9666 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9668 C# 2.0 Static classes implemented
9670 * class.cs (TypeContainer): instance_constructors,
9671 initialized_fields, initialized_static_fields,
9672 default_constructor, base_inteface_types are protected to be
9673 accessible from StaticClass.
9674 (TypeContainer.DefineDefaultConstructor): New virtual method
9675 for custom default constructor generating
9676 (StaticClass): New class to handle "Static classes" feature.
9678 * cs-parser.jay: Handle static keyword on class like instance
9681 * driver.cs: Added "/langversion" command line switch with two
9682 options (iso-1, default).
9684 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9686 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9688 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9690 * delegate.cs: Style.
9692 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9694 * delegate.cs: Add seperate instance expr field for miguel.
9696 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9698 * PointerArithmetic (Resolve): make sure we are not doing
9699 pointer arith on void*. Also, make sure we are resolved
9700 by not setting eclass until resolve.
9702 All callers: Make sure that PointerArithmetic gets resolved.
9704 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9706 * ArrayCreation (LookupType): If the type does not resolve
9707 to an array, give an error.
9709 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9711 * statement.cs (Try.Resolve): Fixed bug #64222
9713 2004-08-27 Martin Baulig <martin@ximian.com>
9716 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9719 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9721 * ecore.cs (Constantify): Get underlying type via
9722 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9723 Windows in special cases.
9725 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9727 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9728 for obtaining also private methods.
9729 (GetRemoveMethod): Used GetRemoveMethod (true)
9730 for obtaining also private methods.
9732 2004-09-02 Martin Baulig <martin@ximian.com>
9734 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9735 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9738 2004-08-27 Martin Baulig <martin@ximian.com>
9741 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9744 2004-08-25 Martin Baulig <martin@ximian.com>
9746 * support.cs (ReflectionParameters..ctor): If this is a generic
9747 method, retrieve and store its type parameters.
9748 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9749 (ReflectionParameters.GenericConstraints): The argument specifies
9750 the type parameter, not the method parameter.
9751 (InternalParameters.GenericConstraints): Likewise.
9753 * generic.cs (TypeParameter.DefineType): Correctly handle
9754 constraints wrt. generic methods in interfaces and their
9757 2004-08-24 Martin Baulig <martin@ximian.com>
9759 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9760 (Constraints.IsSubclassOf): New internal method.
9762 * typemanager.cs (TypeManager.FindMembers): Added special support
9763 for GenericTypeParameterBuilder's.
9764 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
9767 2004-08-24 Martin Baulig <martin@ximian.com>
9770 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
9771 this for accessibility checks.
9772 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
9773 IsNestedFamilyAccessible.
9774 (TypeManager.IsSubclassOf): New method, do what the name actually
9777 2004-08-24 Martin Baulig <martin@ximian.com>
9779 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
9780 as a SimpleName, include the generic arity.
9782 2004-08-24 Martin Baulig <martin@ximian.com>
9784 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
9785 MethodAttributes.HideBySig for operators.
9787 2004-08-23 Martin Baulig <martin@ximian.com>
9789 Back to the old error reporting system :-)
9791 * report.cs (Message): Removed.
9792 (Report.MessageData, ErrorData, WarningData): Removed.
9793 (Report.Error, Warning): Back to the old system.
9795 2004-08-23 Martin Baulig <martin@ximian.com>
9797 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
9799 * class.cs (TypeContainer.ParentContainer): New public virtual
9800 method; replaces the explicit interface implementation.
9801 (ClassPart.ParentContainer): Override.
9803 2004-08-23 Martin Baulig <martin@ximian.com>
9805 * statement.cs (Switch): Added support for constant switches; see
9806 #59428 or test-285.cs.
9808 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9811 * statement.cs (GetEnumeratorFilter): Removed useless
9812 logic because C# specs is strict. GetEnumerator must be
9815 2004-08-22 Martin Baulig <martin@ximian.com>
9817 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9818 a switch and may break, reset the barrier. Fixes #59867.
9820 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9822 CLS-Compliance speed up (~5% for corlib)
9824 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
9825 New method. Tests container for CLS-Compliant names
9827 * class.cs (TypeContainer.VerifyClsName): New method.
9828 Checks whether container name is CLS Compliant.
9829 (Constructor): Implements IMethodData.
9831 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
9832 low-case table for CLS Compliance test.
9833 (MemberCache.VerifyClsParameterConflict): New method.
9834 Checks method parameters for CS3006 error.
9836 * enum.cs (EnumMember): Is derived from MemberCore.
9837 (Enum.VerifyClsName): Optimized for better performance.
9839 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9841 * report.cs: Renamed Error_T to Error and changed all
9844 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9846 * class.cs (TypeContainer.IndexerArrayList): New inner class
9847 container for indexers.
9848 (TypeContainer.DefaultIndexerName): New constant for default
9849 indexer name. Replaced all "Item" with this constant.
9850 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
9852 * typemanager.cs (TypeManager.default_member_ctor): Cache here
9853 DefaultMemberAttribute constructor.
9855 2004-08-05 Martin Baulig <martin@ximian.com>
9857 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9860 2004-08-05 Marek Safar <marek.safar@seznam.cz>
9862 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
9863 multi platforms problem.
9865 * compiler.csproj: Included shared files.
9867 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9869 Fix bug 60333, 55971 in the more general way
9870 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9871 Added arg_type argument for constant conversion.
9872 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
9874 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9877 * class.cs (TypeContainer ): New inner classes MethodArrayList,
9878 OperatorArrayList, MethodCoreArrayList for typecontainer
9879 containers. Changed class member types to these new types.
9880 (MethodArrayList.DefineMembers): Added test for CS0659.
9882 2004-08-04 Miguel de Icaza <miguel@ximian.com>
9884 * cfold.cs: Synchronize the folding with the code in expression.cs
9885 Binary.DoNumericPromotions for uint operands.
9887 * attribute.cs: Revert patch from Raja, it introduced a regression
9888 while building Blam-1.2.1 (hard to isolate a test case).
9890 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9894 (TypeContainer.Define): Renamed to DefineContainerMembers because of
9896 (MethodCore.parent_method): New member. The method we're overriding
9897 if this is an override method.
9898 (MethodCore.CheckBase): Moved from Method class and made common.
9899 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
9901 (MethodCore.CheckForDuplications): New abstract method. For custom
9902 member duplication search in a container
9903 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
9904 method and its return type.
9905 (Event.conflict_symbol): New member. Symbol with same name in the
9909 (MemberCache.FindMemberWithSameName): New method. The method
9910 is looking for conflict with inherited symbols.
9912 2004-08-04 Martin Baulig <martin@ximian.com>
9914 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9916 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9918 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9920 * report.cs (Message): New enum for better error, warning reference in
9922 (MessageData): New inner abstract class. It generally handles printing of
9923 error and warning messages.
9924 Removed unused Error, Warning, Message methods.
9926 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9928 Fix for cs0592-8.cs test
9930 (Attributable.ValidAttributeTargets): Made public.
9931 (Attribute.ExplicitTarget): New member for explicit target value.
9932 (Attribute.CheckTargets): Now we translate explicit attribute
9933 target to Target here.
9935 2004-08-03 Ben Maurer <bmaurer@ximian.com>
9937 * ecore.cs (MethodGroupExpr): new IsBase property.
9939 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
9941 * delegate.cs (DelegateCreation): store a MethodGroupExpr
9942 rather than an instance expr.
9944 (DelegateCreation.Emit): Use the method group rather than
9945 the instance expression. Also, if you have base.Foo as the
9946 method for a delegate, make sure to emit ldftn, not ldftnvirt.
9948 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
9950 (NewDelegate.DoResolve): Only check for the existance of Invoke
9951 if the method is going to be needed. Use MethodGroupExpr.
9953 (NewDelegate.Emit): Remove, DelegateCreation implements this.
9955 * expression.cs: For pointer arith., make sure to use
9956 the size of the type, not the size of the pointer to
9959 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9962 * class.cs (Class): Added error CS0502 test.
9964 2004-08-03 John Luke <jluke@cfl.rr.com>
9965 Raja R Harinath <rharinath@novell.com>
9968 * attribute.cs (Attribute.complained_before): New flag.
9969 (Attribute.ResolveType, Attribute.Resolve),
9970 (Attribute.DefinePInvokeMethod): Set it.
9971 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
9973 2004-08-03 Martin Baulig <martin@ximian.com>
9975 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
9976 use a user-defined operator; we still need to do numeric
9977 promotions in case one argument is a builtin type and the other
9978 one has an implicit conversion to that type. Fixes #62322.
9980 2004-08-18 Martin Baulig <martin@ximian.com>
9982 * class.cs (Method.Define): Use the correct method name when
9983 creating the MethodBuilder for a generic method.
9985 2004-08-17 Martin Baulig <martin@ximian.com>
9987 * generic.cs (Constraints): Support type parameter constraints.
9989 2004-08-16 Martin Baulig <martin@ximian.com>
9991 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
9992 (Token.GENERIC_DIMENSION): New token; this is returned if we
9993 encounter an unbound generic type in a typeof() expression.
9995 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
9996 this token is only generated while parsing a typeof() expression.
9997 (typeof_expression): Removed the old unbound_type hack.
9999 * generic.cs (TypeArguments.IsUnbound): New public property.
10001 * decl.cs (MemberName): Added support for unbound types.
10003 2004-08-14 Martin Baulig <martin@ximian.com>
10006 (TypeManager.IsEqualGenericInstance): New static method.
10007 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
10008 just used to check accessibility, so follow the rules of 26.1.6.
10010 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
10011 ConstructedType instead of a TypeExpression if we have type arguments.
10013 * cs-parser.jay (typeof_expression): Support unbound generic types.
10015 * ecore.cs (UnboundTypeExpression): New public class.
10017 2004-08-12 Martin Baulig <martin@ximian.com>
10019 * typemanager.cs (TypeManager.IsNestedChildOf): Use
10020 TypeManager.IsEqual() rather than `=='.
10022 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
10023 generic instances as well.
10025 2004-08-12 Martin Baulig <martin@ximian.com>
10027 * expression.cs (Invocation.InferType): We can only infer method
10028 type parameters. Fixes #62647.
10030 2004-08-11 Martin Baulig <martin@ximian.com>
10032 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
10033 before resolving the base classes.
10035 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10037 * Makefile: install .mdb file too.
10039 2004-08-05 Martin Baulig <martin@ximian.com>
10041 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
10042 initializer, the current type is just the TypeBuilder, not the
10043 instantiated generic type.
10044 (FieldExpr.IsFieldInitializer): New public property.
10046 2004-08-04 Martin Baulig <martin@ximian.com>
10048 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10050 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10052 2004-08-03 Martin Baulig <martin@ximian.com>
10054 * class.cs (MethodData.Define): If we're an explicit
10055 implementation, remove the generic arity from the type name.
10057 2004-08-03 Martin Baulig <martin@ximian.com>
10059 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10060 use a user-defined operator; we still need to do numeric
10061 promotions in case one argument is a builtin type and the other
10062 one has an implicit conversion to that type. Fixes #62322.
10064 2004-08-02 Martin Baulig <martin@ximian.com>
10066 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
10067 `TypeExpr[]' array.
10068 (TypeContainer.GetClassBases): Return the unexpanded list of
10069 interfaces; we expand them later.
10070 (TypeContainer.DefineType): After creating the TypeBuilder, call
10071 TypeManager.ExpandInterfaces() to get an expanded and resolved
10072 list of interfaces.
10074 * ecore.cs (TypeExpr.GetInterfaces): Removed
10076 * generics.cs (Constraints.InterfaceConstraints): Remove.
10077 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
10078 register the interface constraints.
10081 (TypeManager.AddUserType): Removed the `ifaces' argument.
10082 (TypeManager.AddTypeParameter): Likewise.
10083 (TypeManager.AddUserInterface): Removed, was unused.
10084 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
10085 `TypeExpr[]' array for the interfaces.
10086 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
10087 has been defined, returns a list of the resolved interfaces types.
10088 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
10089 (TypeManager.GetExplicitInterfaces): Likewise.
10091 2004-08-02 Martin Baulig <martin@ximian.com>
10093 * expression.cs (Invocation.EmitCall): If we're invoking a method
10094 on a type parameter, use the new `Constrained' prefix opcode.
10096 2004-08-02 Martin Baulig <martin@ximian.com>
10098 * statement.cs (LocalInfo.Flags): Added `IsThis'.
10099 (LocalInfo.IsThis): New public property.
10100 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
10102 2004-08-01 Martin Baulig <martin@ximian.com>
10104 * class.cs (TypeContainer.GetClassBases): Don't set the default
10105 here since we may get called from GetPartialBases().
10106 (TypeContainer.DefineType): If GetClassBases() didn't return a
10107 parent, use the default one.
10109 2004-07-30 Martin Baulig <martin@ximian.com>
10111 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
10113 * class.cs (SourceMethod): New public class, derive from the
10114 symbol writer's ISourceMethod.
10115 (Method): Use the new symbol writer API.
10117 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
10118 as argument and use the new symbol writer.
10121 (SourceFile): Implement the symbol writer's ISourceFile.
10122 (Location.SymbolDocument): Removed.
10123 (Location.SourceFile): New public property.
10125 * symbolwriter.cs: Use the new symbol writer API.
10127 2004-07-30 Raja R Harinath <rharinath@novell.com>
10129 * Makefile (install-local): Remove. Functionality moved to
10132 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
10134 * Makefile: Install mcs.exe.config file together with mcs.exe.
10135 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
10136 correct runtime version.
10138 2004-07-25 Martin Baulig <martin@ximian.com>
10141 (TypeContainer.RegisterOrder): Removed, this was unused.
10142 (TypeContainer, interface_order): Removed.
10143 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
10144 TypeContainer as argument since we can also be called with a
10145 `PartialContainer' for a partial class/struct/interface.
10146 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
10147 of checking whether we're an `Interface' - we could be a
10148 `PartialContainer'.
10149 (PartialContainer.Register): Override; call
10150 AddClass()/AddStruct()/AddInterface() on our parent.
10152 * cs-parser.jay (interface_member_declaration): Add things to the
10153 `current_container', not the `current_class'.
10155 * rootcontext.cs (RegisterOrder): The overloaded version which
10156 takes an `Interface' was unused, removed.
10158 * typemanager.cs (TypeManager.LookupInterface): Return a
10159 `TypeContainer', not an `Interface'.
10160 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10161 contain a `PartialContainer' for an interface, so check it's
10162 `Kind' to figure out what it is.
10164 2004-07-25 Martin Baulig <martin@ximian.com>
10166 * class.cs (Class.DefaultTypeAttributes): New public constant.
10167 (Struct.DefaultTypeAttributes): Likewise.
10168 (Interface.DefaultTypeAttributes): Likewise.
10169 (PartialContainer.TypeAttr): Override this and add the
10170 DefaultTypeAttributes.
10172 2004-07-25 Martin Baulig <martin@ximian.com>
10174 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10175 we can just use the `Parent' field instead.
10177 2004-07-25 Martin Baulig <martin@ximian.com>
10179 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10181 2004-07-25 Martin Baulig <martin@ximian.com>
10183 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10184 our parts before defining any methods.
10185 (TypeContainer.VerifyImplements): Make this virtual.
10186 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10187 on our PartialContainer.
10189 2004-07-25 Martin Baulig <martin@ximian.com>
10191 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10193 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10194 argument, we can just use the `Parent' field instead.
10197 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10198 (MemberBase.DoDefine): Likewise.
10200 2004-07-24 Martin Baulig <martin@ximian.com>
10202 * decl.cs (MemberCore.Parent): New public field.
10203 (DeclSpace.Parent): Moved to MemberCore.
10205 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10206 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10208 (FieldBase, Field, Operator): Likewise.
10209 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10210 (EventField, Event): Likewise.
10212 2004-07-23 Martin Baulig <martin@ximian.com>
10214 * class.cs (PartialContainer): New public class.
10215 (ClassPart): New public class.
10216 (TypeContainer): Added support for partial classes.
10217 (TypeContainer.GetClassBases): Splitted some of the functionality
10218 out into GetNormalBases() and GetPartialBases().
10220 * cs-tokenizer.cs (Token.PARTIAL): New token.
10221 (Tokenizer.consume_identifier): Added some hacks to recognize
10222 `partial', but only if it's immediately followed by `class',
10223 `struct' or `interface'.
10225 * cs-parser.jay: Added support for partial clases.
10227 2004-07-23 Martin Baulig <martin@ximian.com>
10229 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10230 a `DeclSpace' and also made it readonly.
10231 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10232 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10233 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10235 * cs-parser.jay: Pass the `current_class', not the
10236 `current_container' (at the moment, this is still the same thing)
10237 to a new Method, Property, Event, Indexer or Constructor.
10239 2004-07-23 Martin Baulig <martin@ximian.com>
10241 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10242 and removed the `current_interface' one.
10243 (struct_declaration, class_declaration, interface_declaration):
10244 Set `current_class' to the newly created class/struct/interface;
10245 set their `Bases' and call Register() before parsing their body.
10247 2004-07-23 Martin Baulig <martin@ximian.com>
10249 * class.cs (Kind): New public enum.
10250 (TypeContainer): Made this class abstract.
10251 (TypeContainer.Kind): New public readonly field.
10252 (TypeContainer.CheckDef): New public method; moved here from
10254 (TypeContainer.Register): New public abstract method.
10255 (TypeContainer.GetPendingImplementations): New public abstract
10257 (TypeContainer.GetClassBases): Removed the `is_class' and
10258 `is_iface' parameters.
10259 (TypeContainer.DefineNestedTypes): Formerly known as
10261 (ClassOrStruct): Made this class abstract.
10263 * tree.cs (RootTypes): New public type.
10265 2004-07-20 Martin Baulig <martin@ximian.com>
10267 * tree.cs (Tree.RecordNamespace): Removed.
10268 (Tree.Namespaces): Removed.
10270 * rootcontext.cs (RootContext.IsNamespace): Removed.
10272 * cs-parser.jay (namespace_declaration): Just create a new
10273 NamespaceEntry here.
10275 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10277 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10278 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10279 entry to make sure it runs in the correct runtime version.
10281 2004-07-18 Martin Baulig <martin@ximian.com>
10283 * generic.cs (ConstructedType.CheckConstraints): Improved
10284 constraints checking.
10286 2004-07-18 Martin Baulig <martin@ximian.com>
10288 * expression.cs (Invocation.BetterMethod): Call
10289 TypeManager.TypeToCoreType() on all types and removed my previous
10290 hack; we're already doig the right thing here.
10292 2004-07-17 Martin Baulig <martin@ximian.com>
10294 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10296 2004-07-16 Martin Baulig <martin@ximian.com>
10298 * iterators.cs: Added generics support.
10300 2004-07-16 Martin Baulig <martin@ximian.com>
10302 * iterators.cs: Rewrote this. We're now using one single Proxy
10303 class for both the IEnumerable and the IEnumerator interface and
10304 `Iterator' derives from Class so we can use the high-level API.
10306 * class.cs (TypeContainer.AddIterator): New method.
10307 (TypeContainer.DoDefineType): New protected virtual method, which
10308 is called from DefineType().
10309 (TypeContainer.DoDefineMembers): Call DefineType() and
10310 DefineMembers() on all our iterators.
10311 (TypeContainer.Emit): Call Emit() on all our iterators.
10312 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10314 * codegen.cs (EmitContext.CurrentIterator): New public field.
10316 2004-07-15 Martin Baulig <martin@ximian.com>
10319 (TypeManager.not_supported_exception_type): New type.
10321 2004-07-14 Martin Baulig <martin@ximian.com>
10324 (TypeManager.generic_ienumerable_type): New type.
10325 (TypeManager.generic_ienumerator_type): New type.
10328 (RootContext.interfaces_first_stage): Added
10329 "System.Collections.Generic.IEnumerator`1" and
10330 "System.Collections.Generic.IEnumerable`1".
10332 2004-07-14 Martin Baulig <martin@ximian.com>
10334 * iterators.cs: Use real error numbers.
10336 2004-07-14 Martin Baulig <martin@ximian.com>
10338 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10339 requires this to be a System.Collection.IEnumerable and not a
10340 class implementing that interface.
10341 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10343 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10345 * class.cs: Fixed previous fix, it broke some error tests.
10347 2004-07-12 Martin Baulig <martin@ximian.com>
10349 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10352 2004-07-14 Martin Baulig <martin@ximian.com>
10354 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10355 an exclamation mark (!) for the generic arity to reflect the
10356 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10358 2004-07-13 Martin Baulig <martin@ximian.com>
10360 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10361 specifiers being part of a type argument.
10363 2004-07-13 Martin Baulig <martin@ximian.com>
10365 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10366 name for generic types.
10368 2004-07-13 Martin Baulig <martin@ximian.com>
10370 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10373 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10375 * assign.cs (LocalTemporary): Add new argument: is_address,If
10376 `is_address' is true, then the value that we store is the address
10377 to the real value, and not the value itself.
10379 * ecore.cs (PropertyExpr): use the new local temporary
10380 stuff to allow us to handle X.Y += z (where X is a struct)
10382 2004-07-08 Martin Baulig <martin@ximian.com>
10384 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10385 not always return, just like we're doing in Using.Resolve().
10387 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10389 * cs-parser.jay (fixed_statement): flag this as Pinned.
10391 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10393 * typemanager.cs (TypeManager): Removed MakePinned method, this
10394 mechanism is replaced with the .NET 2.x compatible mechanism of
10395 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10397 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10398 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10399 `IsFixed' property which has a different meaning.
10401 2004-07-02 Raja R Harinath <rharinath@novell.com>
10403 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10404 visible from inside a nested class, not just the names of the
10405 immediately enclosing class.
10406 Fix for bug #60730.
10408 2004-06-24 Raja R Harinath <rharinath@novell.com>
10410 * expression.cs (BetterConversion): Remove buggy special-case
10411 handling of "implicit constant expression conversions". At this
10412 point, we already know that the conversion is possible -- we're
10413 only checking to see which is better.
10415 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10417 * cs-parser.jay: Added error CS0210 test.
10419 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10421 * cs-parser.jay: Added error CS0134 test.
10423 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10426 * cs-parser.jay: Added error CS0145 test.
10428 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10430 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10432 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10434 * expression.cs (StackAlloc.Resolve): The argument may not
10435 be a constant; deal with this case.
10437 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10439 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10440 GetIndexerAttributeValue.
10441 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10443 * class.cs (Indexer.Define): Added error tests for CS0415,
10446 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10448 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10451 2004-06-23 Martin Baulig <martin@ximian.com>
10453 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10454 neither return nor throw, reset the barrier as well. Fixes #60457.
10456 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10458 * class.cs : EventAttributes is now set to None by default.
10459 This fixes bug #60459.
10461 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10464 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10465 Don't throw exception but return null (it's sufficient now).
10467 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10469 * typemanager.cs (GetArgumentTypes): Faster implementation.
10471 2004-06-18 Martin Baulig <martin@ximian.com>
10473 * attribute.cs (Attribute.Resolve): Check whether we're an
10474 EmptyCast which a Constant child. Fixes #60333.
10476 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10478 * statement.cs (EmitCollectionForeach): Account for the fact that
10479 not all valuetypes are in areas which we can take the address of.
10480 For these variables, we store to a temporary variable. Also, make
10481 sure that we dont emit a `callvirt' on a valuetype method.
10483 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10485 * expression.cs (StackAlloc.DoReSolve): Added test for
10486 negative parameter (CS0247).
10488 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10491 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10493 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10496 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10499 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10501 Fix bug #58254 & cs1555.cs, cs1556.cs
10502 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10504 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10506 * cs-parser.jay: Added error CS1669 test for indexers.
10508 2004-06-18 Martin Baulig <martin@ximian.com>
10510 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10511 argument. Fixes #60441.
10513 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10514 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10515 The name needs to have the actual name of the method in order
10516 for other tests (such as the one in OverloadResolve for Invoke
10517 on a delegate) to work. As well, it does not really help
10518 error reporting because the method group had multiple methods.
10519 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10520 Make profiling work.
10522 2004-06-13 Martin Baulig <martin@ximian.com>
10524 * cs-parser.jay: Don't allow generic attributes.
10526 2004-06-13 Martin Baulig <martin@ximian.com>
10528 * class.cs (MemberBase.DoDefineBase): New protected method.
10529 (MemberBase.DoDefine): Compute the `flags' in the new
10530 DoDefineBase() which must be called first.
10531 (Method.Define): Call DoDefineBase() first so we have the flags
10532 when defining the generic method.
10534 * cs-parser.jay (interface_method_declaration): Support generic methods.
10536 2004-06-13 Martin Baulig <martin@ximian.com>
10538 * decl.cs (TypeName): Removed.
10539 (MemberName): Removed TypeName and MemberNow; now we just have
10542 * cs-parser.jay: Don't distinguish between type arguments and type
10543 parameters in the grammar and simplified the rules a bit. The
10544 reduce/reduce conflicts are now gone (except the one we inherited
10547 2004-06-11 Martin Baulig <martin@ximian.com>
10549 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10550 call this twice: for params and varargs methods.
10552 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10555 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10557 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10559 * attribute.cs (Attribute.GetValidTargets): Made public.
10562 (AbstractPropertyEventMethod): New class for better code sharing.
10563 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10565 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10567 2004-06-09 Martin Baulig <martin@ximian.com>
10569 * cs-parser.jay: Removed a reduce/reduce conflict.
10571 2004-06-03 Martin Baulig <martin@ximian.com>
10573 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10574 GetSimpleName() and return a SimpleName.
10576 * ecore.cs (SimpleName.Arguments): New public field.
10577 (SimpleName): Added overloaded ctor which takes an additional
10578 TypeArguments argument.
10579 (SimpleName.SimpleNameResolve): Added support for generic methods.
10580 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10581 formerly in MemberAccess.DoResolve(), but we also need it in
10582 SimpleNameResolve().
10584 * expression.cs (MemberAccess.DoResolve): Use the new
10585 MethodGroupExpr.ResolveGeneric().
10587 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10589 * decl.cs: If possible, use lookuptypedirect here. We can only do
10590 this if there is no `.' after the namespace. Avoids using
10591 LookupType, which does lots of slow processing.
10592 (FindNestedType) New method, does what it says :-).
10593 * namespace.cs: use LookupTypeDirect.
10594 * rootcontext.cs: use membercache, if possible.
10595 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10597 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10600 According to the spec,
10602 In a member access of the form E.I, if E is a single identifier,
10603 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10604 field, property, localvariable, or parameter with the same type as
10605 the meaning of E as a type-name (§3.8), then both possible
10606 meanings of E are permitted.
10608 We did not check that E as a simple-name had the same type as E as
10611 This trivial check gives us 5-7% on bootstrap time.
10613 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10615 * expression.cs (Invocation.OverloadResolve): Avoid the
10616 use of hashtables and boxing here by allocating on demand.
10618 2004-05-30 Martin Baulig <martin@ximian.com>
10620 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10621 we're doing a silent lookup. Don't try to lookup nested types in
10622 TypeManager.object_type (thanks to Ben Maurer).
10624 2004-05-30 Martin Baulig <martin@ximian.com>
10626 Committing a patch from Ben Maurer.
10628 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10630 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10632 * convert.cs: add a trivial cache for overload operator resolution.
10634 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10637 (AttributeTester.GetObsoleteAttribute): Returns instance of
10638 ObsoleteAttribute when type is obsolete.
10641 (TypeContainer.VerifyObsoleteAttribute): Override.
10642 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10643 (MethodCode.VerifyObsoleteAttribute): Override.
10644 (MemberBase.VerifyObsoleteAttribute): Override.
10647 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10648 and report proper error.
10651 (Delegate.VerifyObsoleteAttribute): Override.
10654 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10655 and report proper error.
10656 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10659 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10663 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10664 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10665 Added test for ObsoleteAttribute.
10668 (Catch): Derived from Statement.
10670 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10672 * decl.cs: If possible, use lookuptypedirect here. We can only do
10673 this if there is no `.' after the namespace. Avoids using
10674 LookupType, which does lots of slow processing.
10675 (FindNestedType) New method, does what it says :-).
10676 * namespace.cs: use LookupTypeDirect.
10677 * rootcontext.cs: use membercache, if possible.
10678 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10680 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10683 According to the spec,
10685 In a member access of the form E.I, if E is a single identifier,
10686 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10687 field, property, localvariable, or parameter with the same type as
10688 the meaning of E as a type-name (§3.8), then both possible
10689 meanings of E are permitted.
10691 We did not check that E as a simple-name had the same type as E as
10694 This trivial check gives us 5-7% on bootstrap time.
10696 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10698 Fixed bug #59071 & cs0160.cs
10699 * statement.cs (Try.Resolve): Check here whether order of catch
10700 clauses matches their dependencies.
10702 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10705 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10708 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10710 * expression.cs (Invocation.OverloadResolve): Avoid the
10711 use of hashtables and boxing here by allocating on demand.
10713 2004-05-30 Martin Baulig <martin@ximian.com>
10715 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10716 we're doing a silent lookup. Don't try to lookup nested types in
10717 TypeManager.object_type (thanks to Ben Maurer).
10719 2004-05-30 Martin Baulig <martin@ximian.com>
10721 Committing a patch from Ben Maurer.
10723 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10725 2004-05-29 Martin Baulig <martin@ximian.com>
10727 * class.cs (IMethodData.ShouldIgnore): New method.
10729 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10730 `Location' argument, we don't need it anywhere. Use
10731 `IMethodData.ShouldIgnore ()' instead of
10732 `MethodData.GetMethodFlags ()'.
10733 (TypeManager.AddMethod): Removed.
10734 (TypeManager.AddMethod2): Renamed to AddMethod.
10736 2004-05-29 Martin Baulig <martin@ximian.com>
10738 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10740 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10741 converting from a class type S to an interface type and we already
10742 have an object on the stack, don't box it again. Fixes #52578.
10744 2004-05-29 Martin Baulig <martin@ximian.com>
10746 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10747 Added support for `params' parameters. Fixes #59267.
10749 2004-05-29 Martin Baulig <martin@ximian.com>
10751 * literal.cs (NullPointer): Provide a private .ctor which sets
10752 `type' to TypeManager.object_type. Fixes #59048.
10754 2004-05-29 Martin Baulig <martin@ximian.com>
10756 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10757 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10759 * ecore.cs (EventExpr.instance_expr): Make the field private.
10761 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10763 Fixed bug #50080 & cs0214-2.cs
10764 * expression.cs (Cast.DoResolve): Check unsafe context here.
10766 * statement.cs (Resolve.DoResolve): Likewise.
10768 2004-05-26 Martin Baulig <martin@ximian.com>
10770 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
10772 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
10773 (RootContext.LookupType): Pass down the `silent' flag.
10775 2004-05-25 Martin Baulig <martin@ximian.com>
10778 (MethodGroupExpr.IdenticalTypeName): New public property.
10779 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
10780 expression actually refers to a type.
10782 2004-05-25 Martin Baulig <martin@ximian.com>
10784 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
10785 for #56176 and made it actually work.
10787 2004-05-25 Martin Baulig <martin@ximian.com>
10789 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
10790 (FieldExpr, PropertyExpr): Override and implement
10791 CacheTemporaries. Fixes #52279.
10793 2004-05-25 Miguel de Icaza <miguel@ximian.com>
10795 * location.cs: In the new compiler listing a file twice is a
10796 warning, not an error.
10798 2004-05-24 Martin Baulig <martin@ximian.com>
10800 * enum.cs (Enum.DefineType): For the `BaseType' to be a
10801 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
10803 2004-05-24 Martin Baulig <martin@ximian.com>
10805 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
10806 walking the `using' list. Fixes #53921.
10808 2004-05-24 Martin Baulig <martin@ximian.com>
10810 * const.cs (Const.LookupConstantValue): Added support for
10811 EmptyCast's; fixes #55251.
10813 2004-05-24 Martin Baulig <martin@ximian.com>
10815 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
10816 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
10817 which does the CS0135 check. The reason is that we first need to
10818 check whether the variable actually exists.
10820 2004-05-24 Martin Baulig <martin@ximian.com>
10822 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
10823 than RootContext.LookupType() to find the explicit interface
10824 type. Fixes #58584.
10826 2004-05-24 Raja R Harinath <rharinath@novell.com>
10828 * Makefile: Simplify. Use executable.make.
10829 * mcs.exe.sources: New file. List of sources of mcs.exe.
10831 2004-05-24 Anders Carlsson <andersca@gnome.org>
10835 Use the invariant culture when doing String.Compare for CLS case
10838 2004-05-23 Martin Baulig <martin@ximian.com>
10840 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
10841 don't have any dots. Fixes #52622, added cs0246-8.cs.
10843 * namespace.cs (NamespaceEntry.Lookup): Likewise.
10845 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10847 * class.cs (MemberBase.Define): Reuse MemberType member for
10848 resolved type. Other methods can use it too.
10850 2004-05-23 Martin Baulig <martin@ximian.com>
10852 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
10853 the variable also exists in the current block (otherwise, we need
10854 to report a CS0103). Fixes #58670.
10856 2004-05-23 Martin Baulig <martin@ximian.com>
10858 * flowanalysis.cs (Reachability.Reachable): Compute this
10859 on-the-fly rather than storing it as a field.
10861 2004-05-23 Martin Baulig <martin@ximian.com>
10863 * flowanalysis.cs (Reachability.And): Manually compute the
10864 resulting `barrier' from the reachability.
10866 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10869 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
10870 instance of ObsoleteAttribute when symbol is obsolete.
10873 (IMethodData): Extended interface for ObsoleteAttribute support.
10875 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10877 * attribute.cs: Fix bug #55970
10879 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10883 (GetObsoleteAttribute): New method. Creates the instance of
10885 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
10886 ObsoleteAttribute when member is obsolete.
10887 (AttributeTester.Report_ObsoleteMessage): Common method for
10888 Obsolete error/warning reporting.
10891 (TypeContainer.base_classs_type): New member for storing parent type.
10894 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
10895 for this MemberCore.
10897 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10899 * attribute.cs, const.cs: Fix bug #58590
10901 2004-05-21 Martin Baulig <martin@ximian.com>
10903 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
10904 out parameters if the end of the method is unreachable. Fixes
10907 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10909 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
10910 Hari was right, why extra method.
10912 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10914 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
10916 2004-05-20 Martin Baulig <martin@ximian.com>
10918 * delegate.cs: Convert this file to Unix mode - like the original
10921 2004-05-20 Martin Baulig <martin@ximian.com>
10923 * attribute.cs: Convert this file to Unix mode - like the original
10926 2004-05-19 Marek Safar <marek.safar@seznam.cz>
10928 Fix bug #58688 (MCS does not report error when the same attribute
10931 * attribute.cs (Attribute.Emit): Distinction between null and default.
10933 2004-05-19 Raja R Harinath <rharinath@novell.com>
10935 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
10936 of a top-level attribute without an attribute target.
10937 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
10939 (Attribute.Conditional_GetConditionName),
10940 (Attribute.Obsolete_GetObsoleteMessage): Update.
10941 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
10942 part of ScanForIndexerName.
10943 (Attribute.CanIgnoreInvalidAttribute): New function.
10944 (Attribute.ScanForIndexerName): Move to ...
10945 (Attributes.ScanForIndexerName): ... here.
10946 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
10947 (Attributes.Search): New internal variant that can choose not to
10948 complain if types aren't resolved. The original signature now
10950 (Attributes.GetClsCompliantAttribute): Use internal variant, with
10951 complaints suppressed.
10952 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
10953 only if it not useful.
10954 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
10955 top-level for attributes that are shared between the assembly
10956 and a top-level class.
10957 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
10958 * class.cs: Update to reflect changes.
10959 (DefineIndexers): Fuse loops.
10960 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
10961 a couple more variants of attribute names.
10963 2004-05-18 Marek Safar <marek.safar@seznam.cz>
10965 Fix bug #52585 (Implemented explicit attribute declaration)
10968 (Attributable.ValidAttributeTargets): New abstract method. It gets
10969 list of valid attribute targets for explicit target declaration.
10970 (Attribute.Target): It holds target itself.
10971 (AttributeSection): Removed.
10972 (Attribute.CheckTargets): New method. It checks whether attribute
10973 target is valid for the current element.
10976 (EventProperty): New class. For events that are declared like
10977 property (with add and remove accessors).
10978 (EventField): New class. For events that are declared like field.
10981 * cs-parser.jay: Implemented explicit attribute target declaration.
10983 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
10984 Override ValidAttributeTargets.
10987 (ReturnParameter): Class for applying custom attributes on
10989 (ParameterAtribute): New class. Class for applying custom
10990 attributes on the parameter type.
10992 2004-05-17 Miguel de Icaza <miguel@ximian.com>
10994 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
10997 (Method): Allow UNSAFE here.
10999 * modifiers.cs: Support unsafe reporting.
11001 2004-05-17 Marek Safar <marek.safar@seznam.cz>
11003 * decl.cs: Fix bug #58478.
11005 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11007 * statement.cs: When checking for unreachable code on an EmptyStatement,
11008 set the location. Fixes bug #58488.
11010 2004-05-13 Miguel de Icaza <miguel@ximian.com>
11012 * driver.cs: Add -pkg handling.
11014 From Gonzalo: UseShelLExecute=false
11016 2004-05-12 Marek Safar <marek.safar@seznam.cz>
11019 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
11021 (Attribute.IsClsCompliaceRequired): Moved to base for better
11023 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
11024 when attribute is AttributeUsageAttribute.
11025 (Attribute.GetValidTargets): Simplified.
11026 (Attribute.GetAttributeUsage): New method returns AttributeUsage
11027 attribute for this type.
11028 (Attribute.ApplyAttributes): Method renamed to Emit and make
11030 (GlobalAttributeSection): New class for special handling of global
11031 attributes (assembly, module).
11032 (AttributeSection.Emit): New method.
11034 * class.cs: Implemented Attributable abstract methods.
11035 (MethodCore.LabelParameters): Moved to Parameter class.
11036 (Accessor): Is back simple class.
11037 (PropertyMethod): Implemented Attributable abstract class.
11038 (DelegateMethod): Implemented Attributable abstract class.
11039 (Event): New constructor for disctintion between normal Event
11040 and Event with accessors.
11042 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
11044 * codegen.cs, const.cs, decl.cs, delegate.cs:
11045 (CommonAssemblyModulClass): Implemented Attributable abstract class
11048 * enum.cs: Implement IAttributeSupport interface.
11049 (EnumMember): New class for emum members. Implemented Attributable
11053 (ParameterBase): Is abstract.
11054 (ReturnParameter): New class for easier [return:] attribute handling.
11056 * typemanager.cs: Removed builder_to_attr.
11058 2004-05-11 Raja R Harinath <rharinath@novell.com>
11061 * attribute.cs (Attribute.GetPositionalValue): New function.
11062 * class.cs (TypeContainer.VerifyMembers): New function.
11063 (TypeContainer.Emit): Use it.
11064 (ClassOrStruct): New base class for Class and Struct.
11065 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
11066 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
11068 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
11069 then each non-static field should have a FieldOffset attribute.
11070 Otherwise, none of the fields should have a FieldOffset attribute.
11071 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
11072 and FieldOffset attributes.
11073 * typemanager.cs (TypeManager.struct_layout_attribute_type)
11074 (TypeManager.field_offset_attribute_type): New core types.
11075 (TypeManager.InitCoreTypes): Initialize them.
11077 2004-05-11 Michal Moskal <malekith@pld-linux.org>
11079 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
11080 Return correct type.
11083 2004-05-09 Miguel de Icaza <miguel@ximian.com>
11085 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
11086 be implicitly converted to ulong.
11088 * expression.cs: The logic for allowing operator &, | and ^ worked
11089 was wrong, it worked before because we did not report an error in
11090 an else branch. Fixes 57895.
11092 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
11093 allow volatile fields to be reference types.
11095 2004-05-07 Miguel de Icaza <miguel@ximian.com>
11097 * driver.cs: Add support for /debug-
11099 2004-05-07 Raja R Harinath <rharinath@novell.com>
11101 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
11102 Add a 'complain' parameter to silence errors.
11103 (Attribute.Resolve): Update to changes. Put in sanity check to catch
11104 silently overlooked type-resolutions.
11105 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
11106 to reflect changes.
11107 (Attributes.Search): New function.
11108 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
11109 (Attributes.GetAttributeFullName): Remove hack.
11110 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
11111 Update to reflect changes.
11112 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11113 Use Attributes.Search instead of nested loops.
11115 2004-05-07 Marek Safar <marek.safar@seznam.cz>
11118 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
11119 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
11120 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
11122 * report.cs: (Report.Warning): Renamed to Warning_T because of
11123 parameter collision.
11125 2004-05-05 Raja R Harinath <rharinath@novell.com>
11127 * expression.cs (MemberAccess.ResolveMemberAccess):
11128 Exit with non-zero status after Report.Error.
11129 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
11131 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
11133 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11135 * support.cs: Don't hang when the file is empty.
11137 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11139 * support.cs: In SeekableStreamReader, compute the preamble size of the
11140 underlying stream. Position changes should take into account that initial
11143 2004-05-03 Todd Berman <tberman@sevenl.net>
11145 * driver.cs: remove unused GetSysVersion function.
11147 2004-05-03 Todd Berman <tberman@sevenl.net>
11149 * driver.cs: Remove the hack from saturday, as well as the hack
11150 from jackson (LoadAssemblyFromGac), also adds the CWD to the
11151 link_paths to get that bit proper.
11153 2004-05-01 Todd Berman <tberman@sevenl.net>
11155 * driver.cs: Try a LoadFrom before a Load, this checks the current
11156 path. This is currently a bug in mono that is be fixed, however, this
11157 provides a workaround for now. This will be removed when the bug
11160 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11162 * CryptoConvert.cs: Updated to latest version. Fix issue with
11163 incomplete key pairs (#57941).
11165 2004-05-01 Todd Berman <tberman@sevenl.net>
11167 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11170 2004-04-30 Jackson Harper <jackson@ximian.com>
11172 * codegen.cs: Open keys readonly.
11174 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11176 * typemanager.cs: don't report cyclic struct layout when a struct
11177 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11178 which has 2 Pango.Rectangle fields.
11180 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11182 * expression.cs: Handle IntPtr comparisons with IL code
11183 rather than a method call.
11185 2004-04-29 Martin Baulig <martin@ximian.com>
11187 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11188 the list of PropertyInfo's in class hierarchy and find the
11189 accessor. Fixes #56013.
11191 2004-04-29 Martin Baulig <martin@ximian.com>
11193 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11195 2004-04-29 Martin Baulig <martin@ximian.com>
11197 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11199 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11201 2004-04-29 Martin Baulig <martin@ximian.com>
11203 * class.cs (ConstructorInitializer.Resolve): Check whether the
11204 parent .ctor is accessible. Fixes #52146.
11206 2004-04-29 Martin Baulig <martin@ximian.com>
11208 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11210 * statement.cs (Using.EmitLocalVariableDecls): Use
11211 TypeManager.idisposable_type, not typeof (IDisposable).
11212 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11214 2004-04-29 Martin Baulig <martin@ximian.com>
11216 * class.cs (Event.Define): Don't emit the field and don't set
11217 RTSpecialName and SpecialName for events on interfaces. Fixes
11220 2004-04-29 Raja R Harinath <rharinath@novell.com>
11222 Refactor Attribute.ApplyAttributes.
11223 * attribute.cs (Attributable): New base class for objects that can
11224 have Attributes applied on them.
11225 (Attribute): Make AttributeUsage fields public.
11226 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11227 (Attribute.IsInternalCall): New property.
11228 (Attribute.UsageAttr): Convert to a public read-only property.
11229 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11230 (Attribute.ResolveType, Attribute.Resolve)
11231 (Attribute.ScanForIndexerName): Update to reflect changes.
11232 (Attribute.CheckAttributeTarget): Re-format.
11233 (Attribute.ApplyAttributes): Refactor, to various
11234 Attributable.ApplyAttributeBuilder methods.
11235 * decl.cs (MemberCore): Make Attributable.
11236 * class.cs (Accessor): Make Attributable.
11237 (MethodData.ApplyAttributes): Use proper attribute types, not
11239 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11240 (TypeContainer.ApplyAttributeBuilder)
11241 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11242 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11243 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11244 (Operator.ApplyAttributeBuilder): New factored-out methods.
11245 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11246 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11247 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11248 * parameter.cs (ParameterBase): New Attributable base class
11249 that can also represent Return types.
11250 (Parameter): Update to the changes.
11252 2004-04-29 Jackson Harper <jackson@ximian.com>
11254 * driver.cs: Prefer the corlib system version when looking for
11255 assemblies in the GAC. This is still a hack, but its a better hack
11258 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11260 * decl.cs, enum.cs: Improved error 3005 reporting.
11262 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11263 (related_symbols): New private member for list of symbols
11264 related to reported error/warning.
11266 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11268 2004-04-29 Martin Baulig <martin@ximian.com>
11270 * ecore.cs (Expression.Constantify): If we're an enum and
11271 TypeManager.TypeToCoreType() doesn't give us another type, use
11272 t.UnderlyingSystemType. Fixes #56178.
11274 2004-04-29 Martin Baulig <martin@ximian.com>
11276 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11277 interfaces and for each interface, only add members directly
11278 declared in that interface. Fixes #53255.
11280 2004-04-28 Martin Baulig <martin@ximian.com>
11282 * expression.cs (ConditionalLogicalOperator): Use a temporary
11283 variable for `left' to avoid that we evaluate it more than once;
11286 2004-04-28 Martin Baulig <martin@ximian.com>
11288 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11291 2004-04-28 Martin Baulig <martin@ximian.com>
11293 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11296 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11297 whether the type is not void (CS1547).
11299 2004-04-28 Martin Baulig <martin@ximian.com>
11301 * expression.cs (Unary.DoResolveLValue): Override this and report
11302 CS0131 for anything but Operator.Indirection.
11304 2004-04-28 Martin Baulig <martin@ximian.com>
11306 Committing a patch from Ben Maurer; see bug #50820.
11308 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11311 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11314 2004-04-28 Martin Baulig <martin@ximian.com>
11316 Committing a patch from Ben Maurer; see bug #50820.
11318 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11321 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11324 2004-04-28 Martin Baulig <martin@ximian.com>
11326 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11327 (Block.AddLabel): Call DoLookupLabel() to only search in the
11330 2004-04-28 Martin Baulig <martin@ximian.com>
11332 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11333 comparing StringConstants and NullLiterals in Equality and Inequality.
11335 2004-04-28 Jackson Harper <jackson@ximian.com>
11337 * driver.cs: Attempt to load referenced assemblies from the
11338 GAC. This is the quick and dirty version of this method that
11339 doesnt take into account versions and just takes the first
11340 canidate found. Will be good enough for now as we will not have more
11341 then one version installed into the GAC until I update this method.
11343 2004-04-28 Martin Baulig <martin@ximian.com>
11345 * typemanager.cs (TypeManager.CheckStructCycles): New public
11346 static method to check for cycles in the struct layout.
11348 * rootcontext.cs (RootContext.PopulateTypes): Call
11349 TypeManager.CheckStructCycles() for each TypeContainer.
11350 [Note: We only need to visit each type once.]
11352 2004-04-28 Martin Baulig <martin@ximian.com>
11354 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11356 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11357 success and added `out object value'. Use a `bool resolved' field
11358 to check whether we've already been called rather than
11359 `ConstantValue != null' since this breaks for NullLiterals.
11361 2004-04-28 Raja R Harinath <rharinath@novell.com>
11363 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11364 setting of this flag, since the 'set' method may be non-public.
11366 2004-04-28 Raja R Harinath <rharinath@novell.com>
11368 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11369 check on current_vector.Block.
11371 2004-04-27 Martin Baulig <martin@ximian.com>
11373 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11374 a field initializer. Fixes #56459.
11376 2004-04-27 Martin Baulig <martin@ximian.com>
11378 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11379 we're not attempting to use an indexer. Fixes #52154.
11381 2004-04-27 Martin Baulig <martin@ximian.com>
11383 * statement.cs (Return): Don't create a return label if we don't
11384 need it; reverts my change from January 20th. Thanks to Ben
11387 2004-04-27 Martin Baulig <martin@ximian.com>
11389 According to the spec, `goto' can only leave a nested scope, but
11392 * statement.cs (Block.LookupLabel): Only lookup in the current
11393 block, don't recurse into parent or child blocks.
11394 (Block.AddLabel): Check in parent and child blocks, report
11395 CS0140/CS0158 if we find a duplicate.
11396 (Block): Removed this indexer for label lookups.
11397 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11398 this already does the error reporting for us.
11401 (FlowBranching.UsageVector.Block): New public variable; may be null.
11402 (FlowBranching.CreateSibling): Added `Block' argument.
11403 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11404 label for the target of a `goto' and check whether we're not
11405 leaving a `finally'.
11407 2004-04-27 Martin Baulig <martin@ximian.com>
11409 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11410 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11413 2004-04-27 Martin Baulig <martin@ximian.com>
11415 * statement.cs (Block.AddLabel): Also check for implicit blocks
11416 and added a CS0158 check.
11418 2004-04-27 Martin Baulig <martin@ximian.com>
11420 * flowanalysis.cs (FlowBranchingLoop): New class.
11421 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11422 UsageVector's instead of an ArrayList.
11423 (FlowBranching.Label): Likewise.
11424 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11425 (FlowBranching.AddBreakVector): New method.
11427 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11429 * attribute.cs: Small regression fix: only convert the type if we
11430 the type is different, fixes System.Drawing build.
11432 2004-04-27 Martin Baulig <martin@ximian.com>
11434 * attribute.cs (Attribute.Resolve): If we have a constant value
11435 for a named field or property, implicity convert it to the correct
11438 2004-04-27 Raja R Harinath <rharinath@novell.com>
11440 * statement.cs (Block.Block): Implicit blocks share
11441 'child_variable_names' fields with parent blocks.
11442 (Block.AddChildVariableNames): Remove.
11443 (Block.AddVariable): Mark variable as "used by a child block" in
11444 every surrounding block.
11445 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11446 been used in a child block, complain about violation of "Invariant
11447 meaning in blocks" rule.
11448 * cs-parser.jay (declare_local_variables): Don't use
11449 AddChildVariableNames.
11450 (foreach_statement): Don't create an implicit block: 'foreach'
11451 introduces a scope.
11453 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11455 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11456 converting from 0L to ulong. Fixes 57522.
11458 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11460 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11461 derived class hides via 'new' keyword field from base class (test-242.cs).
11462 TODO: Handle this in the more general way.
11464 * class.cs (CheckBase): Ditto.
11466 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11468 * decl.cs (caching_flags): New member for storing cached values
11470 (MemberCore.Flags): New enum where bit flags for caching_flags
11472 (MemberCore.cls_compliance): Moved to caching_flags.
11473 (DeclSpace.Created): Moved to caching_flags.
11475 * class.cs: Use caching_flags instead of DeclSpace.Created
11477 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11479 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11480 if we are only a derived class, not a nested class.
11482 * typemanager.cs: Same as above, but do this at the MemberLookup
11483 level (used by field and methods, properties are handled in
11484 PropertyExpr). Allow for the qualified access if we are a nested
11487 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11489 * class.cs: Refactoring.
11490 (IMethodData): New inteface; Holds links to parent members
11491 to avoid member duplication (reduced memory allocation).
11492 (Method): Implemented IMethodData interface.
11493 (PropertyBase): New inner classes for get/set methods.
11494 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11495 (Event): New inner classes for add/remove methods.
11496 (Event.DelegateMethod): Implemented IMethodData interface.
11498 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11499 EmitContext (related to class.cs refactoring).
11501 2004-04-21 Raja R Harinath <rharinath@novell.com>
11503 * delegate.cs (Delegate.VerifyApplicability): If the number of
11504 arguments are the same as the number of parameters, first try to
11505 verify applicability ignoring any 'params' modifier on the last
11509 2004-04-08 Martin Baulig <martin@ximian.com>
11511 Merged latest changes into gmcs. Please keep this comment in
11512 here, it makes it easier for me to see what changed in MCS since
11513 the last time I merged.
11515 2004-04-16 Raja R Harinath <rharinath@novell.com>
11517 * class.cs (TypeContainer.AddIndexer): Use
11518 'ExplicitInterfaceName' to determine if interface name was
11519 explicitly specified. 'InterfaceType' is not initialized at this time.
11520 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11521 Indexers array is already in the required order. Initialize
11522 'IndexerName' only if there are normal indexers.
11523 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11524 (TypeContainer.Emit): Emit DefaultMember attribute only if
11525 IndexerName is initialized.
11528 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11530 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11533 2004-04-15 Raja R Harinath <rharinath@novell.com>
11535 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11539 * attribute.cs (Attribute.Resolve): Check for duplicate named
11543 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11545 * iterators.cs (MarkYield): track whether we are in an exception,
11546 and generate code accordingly. Use a temporary value to store the
11547 result for our state.
11549 I had ignored a bit the interaction of try/catch with iterators
11550 since their behavior was not entirely obvious, but now it is
11551 possible to verify that our behavior is the same as MS .NET 2.0
11555 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11557 * iterators.cs: Avoid creating temporaries if there is no work to
11560 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11561 Enumerations, use TypeManager.EnumToUnderlying and call
11564 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11567 (This.Emit): Use EmitContext.EmitThis to emit our
11570 (This.EmitAssign): Ditto.
11572 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11573 codepaths, we will move all the functionality into
11576 (FieldExpr.EmitAssign): Ditto.
11578 This fixes several hidden bugs that I uncovered while doing a code
11579 review of this today.
11581 * codegen.cs (EmitThis): reworked so the semantics are more clear
11582 and also support value types "this" instances.
11584 * iterators.cs: Changed so that for iterators in value types, we
11585 do not pass the value type as a parameter.
11587 Initialization of the enumerator helpers is now done in the caller
11588 instead of passing the parameters to the constructors and having
11589 the constructor set the fields.
11591 The fields have now `assembly' visibility instead of private.
11593 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11595 * expression.cs (Argument.Resolve): Check if fields passed as ref
11596 or out are contained in a MarshalByRefObject.
11598 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11599 another compiler type.
11601 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11603 * class.cs (Indexer.Define): use the new name checking method.
11604 Also, return false on an error.
11605 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11606 (is_identifier_[start/part]_character): make static.
11608 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11610 * expression.cs (Binary.ResolveOperator): Do no append strings
11611 twice: since we can be invoked more than once (array evaluation)
11612 on the same concatenation, take care of this here. Based on a fix
11613 from Ben (bug #56454)
11615 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11617 * codegen.cs: Fix another case where CS1548 must be reported (when
11618 delay-sign isn't specified and no private is available #56564). Fix
11619 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11620 error when MCS is used on the MS runtime and we need to delay-sign
11621 (which seems unsupported by AssemblyBuilder - see #56621).
11623 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11625 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11626 (TypeManager.ComputeNamespaces): Faster implementation for
11629 * compiler.csproj: Updated AssemblyName to mcs.
11631 2004-05-11 Jackson Harper <jackson@ximian.com>
11633 * Makefile: Preserve MONO_PATH
11635 2004-05-11 Jackson Harper <jackson@ximian.com>
11637 * Makefile: Use mono and mcs to build gmcs
11639 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11641 * codegen.cs: Add patch from Robert Shade
11642 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11645 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11647 * CryptoConvert.cs: Updated to latest version. Fix issue with
11648 incomplete key pairs (#57941).
11650 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11652 * codegen.cs: Fix another case where CS1548 must be reported (when
11653 delay-sign isn't specified and no private is available #56564). Fix
11654 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11655 error when MCS is used on the MS runtime and we need to delay-sign
11656 (which seems unsupported by AssemblyBuilder - see #56621).
11658 2004-04-29 Jackson Harper <jackson@ximian.com>
11660 * Makefile: Set MONO_PATH to use the bootstrap corlib
11661 * driver.cs: Check the GAC for referenced assemblies.
11663 2004-04-29 Martin Baulig <martin@ximian.com>
11665 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11667 2004-04-07 Martin Baulig <martin@ximian.com>
11669 * expression.cs (Binary.ResolveOperator): Added special case for
11670 Equality/Inequality between a type parameter and a null literal.
11672 2004-04-07 Martin Baulig <martin@ximian.com>
11674 * convert.cs: Check null literal -> type parameter conversions.
11676 2004-04-07 Martin Baulig <martin@ximian.com>
11678 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11679 `class' and `struct' constraints.
11681 2004-04-07 Martin Baulig <martin@ximian.com>
11683 * generic.cs (SpecialConstraint): New public enum.
11684 (Constraints.Resolve): Added support for the `class' and `struct'
11687 * cs-parser.jay (type_parameter_constraint): Added support for the
11688 `class' and `struct' constraints.
11690 2004-04-07 Martin Baulig <martin@ximian.com>
11692 * support.cs (GenericConstraints): Replaced `Types' by
11693 `ClassConstraint' and `InterfaceConstraints'; added
11694 `HasClassConstraint'.
11696 2004-04-07 Martin Baulig <martin@ximian.com>
11699 (Constraints.InterfaceConstraints): New public property.
11700 (Constraints.Types): Make this property public
11701 (TypeParameter): Implement IMemberContainer.
11702 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11703 instead of a TypeBuilder/MethodBuilder; pass the interface
11704 constraints to TypeManager.AddTypeParameter().
11705 (TypeParameter.DefineType): Just take an EmitContext and no
11706 TypeBuilder/MethodBuilder. Use the new public API.
11708 * typemanager.cs (TypeManager.AddTypeParameter): Added
11709 `TypeExpr[]' argument; add the interfaces to the
11710 `builder_to_ifaces' hash.
11711 (TypeManager.LookupMemberContainer): For
11712 GenericTypeParameterBuilders, get the TypeParameter from the
11713 `builder_to_type_param'.
11714 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11715 the TypeParameter and call FindMembers on it.
11717 2004-04-07 Martin Baulig <martin@ximian.com>
11720 (MethodCore.GenericMethod): Moved this field here from Method.
11721 (MethodCore.IsDuplicateImplementation): Take the number of type
11722 parameters into account if we're a generic method.
11724 * expression.cs (Invocation.InferTypeArguments): Don't return true
11725 if `arguments' is null; we still need to check whether we actually
11726 don't need to infer anything in this case.
11727 (MemberAccess): Merged the functionality from GenericMemberAccess
11730 * generic.cs (GenericMemberAccess): Removed.
11732 2004-04-05 Martin Baulig <martin@ximian.com>
11734 * decl.cs (MemberCore): For generic classes, interfaces and
11735 structs, `Name' now includes the number of type parameters
11736 ("Stack!1.Node!1").
11737 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11738 encode the number of type arguments in the type name.
11740 * expression.cs (Expression.MemberLookup): Removed the
11741 `num_type_args' argument; we now encode the number of type
11742 arguments in the type name.
11744 * ecore.cs (SimpleName): Encode the number of type arguments in
11745 the type name itself.
11747 * generic.cs (ConstructedType): Likewise.
11749 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11750 `MemberName'; we now include the number of type parameters in the
11753 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11754 (TypeManager.MemberLookup): Removed the
11755 `num_type_args' argument; we now encode the number of type
11756 arguments in the type name.
11758 2004-04-03 Martin Baulig <martin@ximian.com>
11760 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11761 (MemberCore.MemberName): Moved here from MemberBase.
11762 (DeclSpace.SetParameterInfo): Just take the constraints as an
11763 ArrayList; we already have the type parameters in our
11764 `MemberName'; also do the CS0080 reporting here.
11766 * cs-parser.jay (struct_declaration): Use `member_name' instead of
11767 `IDENTIFIER opt_type_parameter_list'; when constructing our
11768 `MemberName', it'll already include our type parameters.
11769 (class_declaration, interface_declaration): Likewise.
11770 (delegate_declaration): Likewise.
11771 (MakeName): Take a MemberName and return a MemberName.
11772 The following two changes are required to avoid shift/reduce conflicts:
11773 (member_name): Don't include a TypeName anymore; ie. this is now
11774 just 'IDENTIFIER opt_type_parameter_list'.
11775 (property_declaration, event_declaration): Use a
11776 `namespace_or_type_name' instead of a `member_name'.
11778 2004-04-03 Martin Baulig <martin@ximian.com>
11780 * decl.cs (MemberName): Renamed to `TypeName' and created a new
11781 `MemberName' class.
11782 (TypeName): Formerly known as MemberName.
11784 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
11785 instead of a `MemberName'.
11787 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
11788 (member_name): New rule; create a MemberName.
11790 2004-04-02 Martin Baulig <martin@ximian.com>
11792 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
11793 (CS0305 and CS0308).
11795 2004-04-02 Martin Baulig <martin@ximian.com>
11797 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
11798 support for nested types.
11800 2004-04-02 Martin Baulig <martin@ximian.com>
11802 * ecore.cs (IAlias): New public interface.
11803 (TypeExpr, TypeExpression): Implement IAlias.
11804 (TypeAliasExpression): New public class.
11806 * namespace.cs (Namespace): Implement IAlias.
11807 (Namespace.Lookup): Return an IAlias instead on an object.
11808 (Namespace.DefineName): Take an IAlias instead of an object.
11809 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
11811 (NamespaceEntry.UsingAlias): Take a Membername instead of an
11813 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
11815 (NamespaceEntry.Lookup): Likewise.
11817 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
11820 * decl.cs (DeclSpace): Implement IAlias.
11821 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
11823 * generic.cs (ConstructedType): Improved error checking.
11825 2004-04-02 Martin Baulig <martin@ximian.com>
11827 * convert.cs: Added type parameter conversions.
11830 (UnboxCast.Emit): Emit an `unbox.any' for type params.
11831 (ClassCast.Emit): If the source type is a type parameter, box it.
11832 If the target type is a type parameter, emit an `unbox.any'
11833 instead of a `classcast'.1
11835 2004-04-01 Martin Baulig <martin@ximian.com>
11837 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
11839 2004-04-01 Martin Baulig <martin@ximian.com>
11841 * generic.cs (ConstructedType.CheckConstraints): Use
11842 Convert.ImplicitStandardConversionExists(); user-defined implicit
11843 conversions are not allowed according to the spec.
11845 2004-03-30 Martin Baulig <martin@ximian.com>
11847 * expression.cs (New): Added support for type parameters.
11850 (TypeManager.activator_type): New public static field.
11851 (TypeManager.activator_create_instance): Likewise.
11853 2004-03-30 Martin Baulig <martin@ximian.com>
11855 * typemanager.cs (TypeManager.HasConstructorConstraint): New
11858 2004-03-30 Martin Baulig <martin@ximian.com>
11860 * generic.cs (ConstructedType.CheckConstraints): Actually follow
11861 the spec here: the argument type must be convertible to the
11864 2004-03-30 Martin Baulig <martin@ximian.com>
11867 (TypeParameter.Define, TypeParameter.DefineMethod): Call
11868 TypeManager.AddTypeParameter().
11869 (ConstructedType.CheckConstraints): Re-enable this and actually
11870 check whether we have a constructor constraint.
11873 (TypeManager.builder_to_type_param): New static field.
11874 (TypeManager.AddTypeParameter): New static method.
11875 (TypeManager.LookupTypeParameter): New public method.
11877 2004-03-30 Martin Baulig <martin@ximian.com>
11879 * generic.cs (TypeParameter.DefineType): Return a boolean and use
11880 the new API to actually define the constructor constraint.
11883 (TypeManager.new_constraint_attr_type): New static field.
11884 (TypeManager.InitCoreTypes): Initialize it.
11886 2004-03-30 Martin Baulig <martin@ximian.com>
11888 * generic.cs (Constraints): Completed error checking, use correct
11891 2004-03-29 Martin Baulig <martin@ximian.com>
11893 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
11895 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11896 public version which takes a `ParameterData pd' instead of an
11899 2004-03-29 Martin Baulig <martin@ximian.com>
11901 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
11904 2004-03-29 Martin Baulig <martin@ximian.com>
11906 * expression.cs (Argument.ResolveMethodGroup): If we're a
11907 ConstructedType, call GetMemberAccess() on it.
11909 2004-03-29 Martin Baulig <martin@ximian.com>
11911 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
11912 (MethodCore.CheckGenericOverride): When overriding a generic
11913 method, check whether the constraints match.
11915 * support.cs (GenericConstraints): New public interface.
11916 (ParameterData.GenericConstraints): New public method.
11918 * parameter.cs (Parameter.Resolve): Check whether we're a generic
11919 method parameter and compute our constraints if appropriate.
11920 (Parameter.GenericConstraints): New public property.
11922 * generic.cs (Constraints): Implement GenericConstraints.
11924 2004-03-29 Martin Baulig <martin@ximian.com>
11926 * decl.cs (MemberCache.FindMemberToOverride): Use
11927 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
11929 2004-03-29 Martin Baulig <martin@ximian.com>
11931 * generic.cs (GenericMethod.Define): Resolve our type parameters.
11933 2004-03-29 Martin Baulig <martin@ximian.com>
11935 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
11936 not allowed on non-generic declarations").
11938 2004-03-29 Martin Baulig <martin@ximian.com>
11940 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11941 public version of this method.
11943 * class.cs (MethodCore.IsDuplicateImplementation): Use
11944 Invocation.InferTypeArguments() to check this.
11946 2004-03-29 Martin Baulig <martin@ximian.com>
11948 * convert.cs: Use TypeManager.IsDelegateType() instead of
11949 comparing types correctly.
11951 2004-03-29 Martin Baulig <martin@ximian.com>
11953 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
11954 types directly to make it work for generic instances.
11956 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
11958 2004-03-29 Martin Baulig <martin@ximian.com>
11960 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
11961 support for arrays.
11963 2004-03-24 Martin Baulig <martin@ximian.com>
11965 * decl.cs (DeclSpace.FindType): Also use
11966 TypeManager.CheckGeneric() for types from the using clauses.
11968 2004-03-23 Martin Baulig <martin@ximian.com>
11970 * expression.cs (Invocation.OverloadResolve): Added `bool
11971 may_fail' argument and use it instead of the Location.IsNull() hack.
11973 2004-03-23 Martin Baulig <martin@ximian.com>
11975 * expression.cs (Invocation.InferType): Use correct type inference
11978 2004-03-23 Martin Baulig <martin@ximian.com>
11980 * ecore.cs (MethodGroupExpr.Name): Use
11981 TypeManager.CSharpSignature() instead of just the name.
11983 * expression.cs (Invocation.OverloadResolve): Provide better error
11985 (Invocation.DoResolve): OverloadResolve() never returns null
11986 without reporting an error, so removed the error -6 reporting here.
11988 2004-03-23 Martin Baulig <martin@ximian.com>
11990 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
11993 * cs-parser.jay (delegate_declaration): Support generic delegates.
11995 * delegate.cs: Support generic delegates.
11997 2004-03-22 Martin Baulig <martin@ximian.com>
11999 * expression.cs (Invocation.InferParamsTypeArguments): New static
12000 method; does type inference for params arguments.
12002 2004-03-21 Martin Baulig <martin@ximian.com>
12004 * typemanager.cs (TypeManager.IsGenericMethod): New public static
12005 method; checks whether a method is a generic method.
12007 * expression.cs (Invocation.InferTypeArguments): New static method;
12008 infer type arguments for generic method invocation.
12010 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
12011 property; we set this to true if we're resolving a generic method
12012 invocation and the user specified type arguments, ie. we're not
12013 doing type inference.
12015 2004-03-20 Martin Baulig <martin@ximian.com>
12017 * class.cs (MethodData.DeclaringType): New public property.
12018 (MethodData.Define): Set DeclaringType here.
12019 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
12020 instead of OperatorMethodBuilder.DeclaringType.
12022 2004-03-20 Martin Baulig <martin@ximian.com>
12024 * cs-tokenizer.cs (xtoken): Return a special
12025 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
12027 * cs-parser.jay (default_value_expression): Switch to the new
12030 2004-03-19 Martin Baulig <martin@ximian.com>
12032 * decl.cs (MemberName): New class. We use this to "construct"
12033 namespace_or_type_name's.
12035 * generics.cs (TypeArguments.GetDeclarations): New public method;
12036 returns the type arguments as a string[] and reports a CS0081 if
12037 one of them is not an identifier.
12039 * class.cs (MemberBase): The .ctor now takes the name as a
12040 MemberName instead of a string.
12041 (MemberBase.ExplicitInterfaceName): Changed type from string to
12043 (MemberBase.DoDefine): If we're an explicit implementation, the
12044 InterfaceType may be a generic instance.
12046 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
12047 (namespace_name): Call MemberName.GetName () to transform the
12048 MemberName into a string and ensure we don't have any type
12050 (type_name): Call MemberName.GetTypeExpression() to transfrom the
12051 MemberName into an expression.
12052 (method_header): Use namespace_or_type_name instead of member_name.
12054 2004-04-07 Miguel de Icaza <miguel@ximian.com>
12056 * rootcontext.cs: Add new types to the boot resolution.
12058 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
12059 MulticastDelegate is not allowed.
12061 * typemanager.cs: Add new types to lookup: System.TypedReference
12064 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
12065 check for TypedReference or ArgIterator, they are not allowed.
12067 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
12068 makes us properly catch 1510 in some conditions (see bug 56016 for
12071 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
12073 * CryptoConvert.cs: update from corlib version
12076 2004-04-05 Miguel de Icaza <miguel@ximian.com>
12078 * class.cs (Indexer.Define): Check indexername declaration
12080 2004-04-05 Marek Safar <marek.safar@seznam.cz>
12082 * attribute.cs (IsClsCompliant): Fixed problem with handling
12083 all three states (compliant, not-compliant, undetected).
12085 2004-03-30 Marek Safar <marek.safar@seznam.cz>
12087 * attribute.cs (Attribute): Location is now public.
12088 (Resolve): Store resolved arguments (pos_values) in attribute class.
12089 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
12090 (GetClsCompliantAttributeValue): New method that gets
12091 CLSCompliantAttribute value.
12092 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
12093 if exists else null.
12094 (AttributeTester): New class for CLS-Compliant verification routines.
12096 * class.cs (Emit): Add CLS-Compliant verification.
12097 (Method.GetSignatureForError): Implemented.
12098 (Constructor.GetSignatureForError): Implemented
12099 (Constructor.HasCompliantArgs): Returns if constructor has
12100 CLS-Compliant arguments.
12101 (Constructor.Emit): Override.
12102 (Construcor.IsIdentifierClsCompliant): New method; For constructors
12103 is needed to test only parameters.
12104 (FieldBase.GetSignatureForError): Implemented.
12105 (TypeContainer): New member for storing base interfaces.
12106 (TypeContainer.FindMembers): Search in base interfaces too.
12108 * codegen.cs (GetClsComplianceAttribute): New method that gets
12109 assembly or module CLSCompliantAttribute value.
12110 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
12112 (ModuleClass.Emit): Add error 3012 test.
12114 * const.cs (Emit): Override and call base for CLS-Compliant tests.
12116 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
12117 state for all decl types.
12118 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
12119 if CLS-Compliant tests are required.
12120 (IsClsCompliaceRequired): New method. Analyze whether code
12121 must be CLS-Compliant.
12122 (IsExposedFromAssembly): New method. Returns true when MemberCore
12123 is exposed from assembly.
12124 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
12125 value or gets cached value.
12126 (HasClsCompliantAttribute): New method. Returns true if MemberCore
12127 is explicitly marked with CLSCompliantAttribute.
12128 (IsIdentifierClsCompliant): New abstract method. This method is
12129 used to testing error 3005.
12130 (IsIdentifierAndParamClsCompliant): New method. Common helper method
12131 for identifier and parameters CLS-Compliant testing.
12132 (VerifyClsCompliance): New method. The main virtual method for
12133 CLS-Compliant verifications.
12134 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
12135 null. I don't know why is null (too many public members !).
12136 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
12137 and get value of first CLSCompliantAttribute that found.
12139 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
12140 (VerifyClsCompliance): Override and add extra tests.
12142 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
12143 clscheck- disable CLS-Compliant verification event if assembly is has
12144 CLSCompliantAttribute(true).
12146 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
12147 ApllyAttribute is now called in emit section as in the other cases.
12148 Possible future Emit integration.
12149 (IsIdentifierClsCompliant): New override.
12150 (VerifyClsCompliance): New override.
12151 (GetEnumeratorName): Returns full enum name.
12153 * parameter.cs (GetSignatureForError): Implemented.
12155 * report.cs (WarningData): New struct for Warning message information.
12156 (LocationOfPreviousError): New method.
12157 (Warning): New method. Reports warning based on the warning table.
12158 (Error_T): New method. Reports error based on the error table.
12160 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12161 verifications are done here.
12163 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12165 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12166 CLSCompliantAttribute.
12167 (all_imported_types): New member holds all imported types from other
12169 (LoadAllImportedTypes): New method fills static table with exported types
12170 from all referenced assemblies.
12171 (Modules): New property returns all assembly modules.
12173 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12175 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12176 throwing a parser error.
12178 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12179 which removes the hardcoded get_/set_ prefixes for properties, as
12180 IL allows for the properties to be named something else.
12184 * expression.cs: Do not override operand before we know if it is
12185 non-null. Fix 56207
12187 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12189 * typemanager.cs: support for pinned variables.
12191 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12193 * decl.cs, typemanager.cs: Avoid using an arraylist
12194 as a buffer if there is only one result set.
12196 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12198 * expression.cs: Make sure you cant call a static method
12199 with an instance expression, bug #56174.
12201 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12203 * class.cs (IsDuplicateImplementation): Improve error reporting to
12204 flag 663 (method only differs in parameter modifier).
12206 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12207 in preprocessor directives.
12209 * location.cs (LookupFile): Allow for the empty path.
12211 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12212 better approach for some of that patch, but its failing with the
12213 CharSet enumeration. For now try/catch will do.
12215 * typemanager.cs: Do not crash if a struct does not have fields.
12218 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12220 * expression.cs: cs0213, cant fix a fixed expression.
12223 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12225 * cs-parser.jay: detect invalid embeded statements gracefully.
12228 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12230 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12233 the invocation type may not be a subclass of the tye of the item/
12234 The type of the item must be a subclass of the invocation item.
12239 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12241 * attribute.cs: Added methods to get a string and a bool from an
12242 attribute. Required to information from AssemblyKeyFileAttribute,
12243 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12244 * codegen.cs: Modified AssemblyName creation to include support for
12245 strongnames. Catch additional exceptions to report them as CS1548.
12246 * compiler.csproj: Updated include CryptoConvert.cs.
12247 * compiler.csproj.user: Removed file - user specific configuration.
12248 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12249 Mono.Security assembly. The original class is maintained and tested in
12250 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12251 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12252 like CSC 8.0 (C# v2) supports.
12253 * Makefile: Added CryptoConvert.cs to mcs sources.
12254 * rootcontext.cs: Added new options for strongnames.
12256 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12258 * driver.cs: For --expect-error, report error code `2'
12259 if the program compiled with no errors, error code `1' if
12260 it compiled with an error other than the one expected.
12262 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12264 * compiler.csproj: Updated for Visual Studio .NET 2003.
12265 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12266 * compiler.sln: Updated for Visual Studio .NET 2003.
12268 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12270 * expression.cs: Fix bug #47234. We basically need to apply the
12271 rule that we prefer the conversion of null to a reference type
12272 when faced with a conversion to 'object' (csc behaviour).
12274 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12276 * statement.cs: Shorter form for foreach, eliminates
12277 a local variable. r=Martin.
12279 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12281 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12282 checks if we can use brtrue/brfalse to test for 0.
12283 * expression.cs: use the above in the test for using brtrue/brfalse.
12284 cleanup code a bit.
12286 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12288 * expression.cs: Rewrite string concat stuff. Benefits:
12290 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12291 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12292 rather than a concat chain.
12294 * typemanager.cs: Add lookups for more concat overloads.
12296 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12298 * expression.cs: Emit shorter il code for array init.
12315 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12317 * statement.cs: Before, two switch blocks would be merged if the
12318 total size of the blocks (end_item - begin_item + 1) was less than
12319 two times the combined sizes of the blocks.
12321 Now, it will only merge if after the merge at least half of the
12326 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12328 * class.cs : csc build fix for GetMethods(). See bug #52503.
12330 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12332 * expression.cs: Make sure fp comparisons work with NaN.
12333 This fixes bug #54303. Mig approved this patch a long
12334 time ago, but we were not able to test b/c the runtime
12337 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12339 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12341 2004-03-19 Martin Baulig <martin@ximian.com>
12343 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12344 two overloads may unify for some type parameter substitutions and
12345 report a CS0408 if appropriate.
12347 2004-03-19 Martin Baulig <martin@ximian.com>
12349 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12350 error here and not in our caller.
12352 2004-03-19 Martin Baulig <martin@ximian.com>
12354 * interface.cs: Completely killed this file.
12355 (Interface): We're now a TypeContainer and live in class.cs.
12357 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12358 argument; we're now also called for interfaces.
12359 (TypeContainer.DefineMembers): Allow this method being called
12361 (TypeContainer.GetMethods): New public method; formerly known as
12362 Interface.GetMethod(). This is used by PendingImplementation.
12363 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12364 it's now private and non-static.
12365 (Interface): Moved this here; it's now implemented similar to
12367 (Method, Property, Event, Indexer): Added `bool is_interface'
12368 argument to their .ctor's.
12369 (MemberBase.IsInterface): New public field.
12371 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12372 instances instead of InterfaceMethod, InterfaceProperty, etc.
12373 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12374 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12376 2004-03-19 Martin Baulig <martin@ximian.com>
12378 * class.cs (MethodCore.IsDuplicateImplementation): New private
12379 method which does the CS0111 checking.
12380 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12381 Use IsDuplicateImplementation().
12383 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12385 * decl.cs (FindMemberToOverride): New method to find the correct
12386 method or property to override in the base class.
12388 - Make Method/Property use the above method to find the
12389 version in the base class.
12390 - Remove the InheritableMemberSignatureCompare as it is now
12393 This patch makes large code bases much faster to compile, as it is
12394 O(n) rather than O(n^2) to do this validation.
12396 Also, it fixes bug 52458 which is that nested classes are not
12397 taken into account when finding the base class member.
12399 Reviewed/Approved by Martin.
12401 2004-03-17 Martin Baulig <martin@ximian.com>
12403 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12404 of type arguments into account; use the `real_num_type_args'
12405 approach like in DoResolveAsTypeStep().
12407 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12410 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12412 * interface.cs: In all interface classes removed redundant
12413 member initialization.
12415 2004-03-16 Martin Baulig <martin@ximian.com>
12417 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12419 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12421 * decl.cs (DefineTypeAndParents): New helper method to define a
12422 type's containers before the type itself is defined; This is a
12423 bug exposed by the recent changes to Windows.Forms when an
12424 implemented interface was defined inside a class that had not been
12427 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12429 (Check): Loop correctly to report errors modifiers
12430 (UNSAFE was not in the loop, since it was the same as TOP).
12432 * interface.cs: Every interface member now takes a ModFlags,
12433 instead of a "is_new" bool, which we set on the base MemberCore.
12435 Every place where we called "UnsafeOk" in the interface, now we
12436 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12437 the unsafe settings from the member declaration instead of the
12438 container interface.
12440 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12442 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12443 `set_indexer_name' to the pending bits (one per type).
12445 We fixed a bug today that was picking the wrong method to
12446 override, since for properties the existing InterfaceMethod code
12447 basically ignored the method name. Now we make sure that the
12448 method name is one of the valid indexer names.
12450 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12452 * support.cs (SeekableStreamReader): Keep track of stream byte
12453 positions and don't mix them with character offsets to the buffer.
12455 Patch from Gustavo Giráldez
12457 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12459 * interface.cs (InterfaceSetGetBase): Removed double member
12460 initialization, base class does it as well.
12462 2004-03-13 Martin Baulig <martin@ximian.com>
12464 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12465 when compiling corlib.
12467 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12469 * convert.cs (ExplicitConversion): We were reporting an error on
12470 certain conversions (object_type source to a value type, when the
12471 expression was `null') before we had a chance to pass it through
12472 the user defined conversions.
12474 * driver.cs: Replace / and \ in resource specifications to dots.
12477 * class.cs: Add check for duplicate operators. Fixes 52477
12479 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12481 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12482 that are in the middle of the statements, not only at the end.
12485 * class.cs (TypeContainer.AddField): No longer set the
12486 `HaveStaticConstructor' flag, now we call it
12487 `UserDefineStaticConstructor' to diferentiate the slightly
12488 semantic difference.
12490 The situation is that we were not adding BeforeFieldInit (from
12491 Modifiers.TypeAttr) to classes that could have it.
12492 BeforeFieldInit should be set to classes that have no static
12497 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12499 And most importantly Zoltan's comment:
12501 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12503 "I think beforefieldinit means 'it's ok to initialize the type sometime
12504 before its static fields are used', i.e. initialization does not need
12505 to be triggered by the first access to the type. Setting this flag
12506 helps the JIT to compile better code, since it can run the static
12507 constructor at JIT time, and does not need to generate code to call it
12508 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12509 this flag for lots of classes like String.
12511 csc sets this flag if the type does not have an explicit static
12512 constructor. The reasoning seems to be that if there are only static
12513 initalizers for a type, and no static constructor, then the programmer
12514 does not care when this initialization happens, so beforefieldinit
12517 This bug prevents the AOT compiler from being usable, since it
12518 generates so many calls to mono_runtime_class_init that the AOT code
12519 is much slower than the JITted code. The JITted code is faster,
12520 because it does not generate these calls if the vtable is type is
12521 already initialized, which is true in the majority of cases. But the
12522 AOT compiler can't do this."
12524 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12526 * class.cs (MethodData.Emit): Refactor the code so symbolic
12527 information is generated for destructors; For some reasons we
12528 were taking a code path that did not generate symbolic information
12531 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12533 * class.cs: Create a Constructor.CheckBase method that
12534 takes care of all validation type code. The method
12535 contains some code that was moved from Define.
12537 It also includes new code that checks for duplicate ctors.
12538 This fixes bug #55148.
12540 2004-03-09 Joshua Tauberer <tauberer@for.net>
12542 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12543 a { ... }-style array creation invokes EmitStaticInitializers
12544 which is not good for reference-type arrays. String, decimal
12545 and now null constants (NullCast) are not counted toward
12546 static initializers.
12548 2004-03-05 Martin Baulig <martin@ximian.com>
12550 * location.cs (SourceFile.HasLineDirective): New public field;
12551 specifies whether the file contains or is referenced by a "#line"
12553 (Location.DefineSymbolDocuments): Ignore source files which
12554 either contain or are referenced by a "#line" directive.
12556 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12558 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12559 direct access to our parent, so check the method inline there.
12561 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12563 * expression.cs (Invocation.EmitCall): Miguel's last commit
12564 caused a regression. If you had:
12569 In Foo the implict this would be null.
12571 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12573 * expression.cs (Invocation.EmitCall): If the method is not
12574 virtual, do not emit a CallVirt to it, use Call.
12576 * typemanager.cs (GetFullNameSignature): Improve the method to
12577 cope with ".ctor" and replace it with the type name.
12579 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12580 as an argument the ConstructorBuilder where it is being defined,
12581 to catch the recursive constructor invocations.
12583 2004-03-16 Martin Baulig <martin@ximian.com>
12585 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12586 ConstructedType, call ResolveType() on it to get the type rather
12587 than just using `expr.Type'.
12589 2004-03-16 Martin Baulig <martin@ximian.com>
12591 * generics.cs (ConstructedType.GetMemberAccess): Take the
12592 EmitContext instead on the TypeExpr and use
12593 ec.TypeContainer.CurrentType/ec.ContainerType.
12595 2004-03-16 Martin Baulig <martin@ximian.com>
12597 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12598 parameters before aliases.
12600 2004-03-16 Martin Baulig <martin@ximian.com>
12602 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12603 New oublic function; checks whether two generic instances may become
12604 equal under some instantiations (26.3.1).
12606 * class.cs (TypeContainer.Define): Call
12607 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12610 2004-03-16 Martin Baulig <martin@ximian.com>
12612 * class.cs (TypeContainer.GetClassBases): Moved
12613 Error_TypeParameterAsBase() here and also check whether the base
12614 class is not an attribute.
12616 2004-03-16 Martin Baulig <martin@ximian.com>
12618 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12620 2004-03-16 Martin Baulig <martin@ximian.com>
12622 * class.cs (Error_TypeParameterAsBase): Use correct error number
12625 2004-03-16 Martin Baulig <martin@ximian.com>
12627 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12630 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12633 2004-03-15 Martin Baulig <martin@ximian.com>
12635 * typemanager.cs (TypeManager.GetFullName): New public method.
12636 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12637 argument; only return members with the correct number of type
12639 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12640 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12641 whether the number of type arguments matches.
12643 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12644 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12646 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12647 field; it's set by the protected .ctor when we're actually a
12648 GenericMemberAccess.
12649 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12650 arguments and pass it to MemberLookupFinal ().
12652 * ecore.cs (Expression.MemberLookup): Added `int
12653 num_type_arguments' argument; only return members with the correct
12654 number of type arguments.
12655 (Expression.MemberLookupFailed): Check whether the MemberLookup
12656 failed because we did not have the correct number of type
12657 arguments; report CS0305 in this case.
12659 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12660 `e.ResolveAsTypeTerminal()' already did so.
12662 2004-03-15 Martin Baulig <martin@ximian.com>
12664 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12665 we're a ConstructedType; in this case, the caller must report an
12666 error (for instance CS0131).
12668 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12669 (TypeArguments.Resolve): Actually report errors here.
12671 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12673 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12674 `set_indexer_name' to the pending bits (one per type).
12676 We fixed a bug today that was picking the wrong method to
12677 override, since for properties the existing InterfaceMethod code
12678 basically ignored the method name. Now we make sure that the
12679 method name is one of the valid indexer names.
12681 2004-03-15 Martin Baulig <martin@ximian.com>
12683 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12684 for generic instances.
12686 2004-03-13 Martin Baulig <martin@ximian.com>
12688 * class.cs (TypeContainer.DefineType): Call
12689 TypeManager.AddUserType() immediately after creating the
12690 TypeBuilder; pass all type parameters when creating the
12693 * decl.cs (DeclSpace.FindNestedType): New public method.
12694 (DeclSpace.FindType): Added `int num_type_args' argument; only
12695 return types with the correct number of type parameters.
12696 (DeclSpace.CountTypeParams): New public property.
12698 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12699 the number of type parameters; defaults to zero.
12701 * generic.cs (TypeArguments.Count): New public property.
12702 (ConstructedType.DoResolveAsTypeStep): First call
12703 ds.FindNestedType() to find out whether we're nested in the
12704 current generic type; in this case, we inherit all type parameters
12705 from the current class.
12707 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12708 num_type_args' argument.
12709 (RootContext.LookupType): Added overloaded version which takes the
12710 number of type arguments; only return types with the correct
12711 number of type arguments.
12713 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12714 checks whether `Type t' has `int num_type_args'.
12716 2004-03-13 Martin Baulig <martin@ximian.com>
12718 * generic.cs (GenericMethod.DefineType): New method; calls
12719 DefineType() on all the type parameters.
12721 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12722 (MethodData.Define): If we're a generic method, call
12723 GenericMethod.DefineType() to define the type parameters.
12725 2004-03-10 Martin Baulig <martin@ximian.com>
12727 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12728 instead of IsAssignableFrom.
12730 2004-03-10 Martin Baulig <martin@ximian.com>
12732 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12734 * support.cs (ParameterData.HasArrayParameter): New property.
12735 (ReflectionParameters.ctor): Take a MethodBase instead of a
12736 ParameterInfo[]. If we have any type parameters, get the generic
12737 method definition and ask it whether we have variable arguments.
12739 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12741 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12742 routines to check if a type is an enumerable/enumerator allow
12743 classes that implement the IEnumerable or IEnumerator interfaces.
12745 * class.cs (Property, Operator): Implement IIteratorContainer, and
12746 implement SetYields.
12748 (Property.Define): Do the block swapping for get_methods in the
12749 context of iterators. We need to check if Properties also
12750 include indexers or not.
12752 (Operator): Assign the Block before invoking the
12753 OperatorMethod.Define, so we can trigger the Iterator code
12756 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12757 Property and Operator classes are not created when we parse the
12758 declarator but until we have the block completed, so we use a
12759 singleton SimpleIteratorContainer.Simple to flag whether the
12760 SetYields has been invoked.
12762 We propagate this setting then to the Property or the Operator to
12763 allow the `yield' to function.
12765 2004-02-25 Marek Safar <marek.safar@seznam.cz>
12767 * codegen.cs: Implemented attribute support for modules.
12768 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
12769 Assembly/Module functionality.
12771 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
12772 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
12773 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
12775 2004-02-16 Marek Safar <marek.safar@seznam.cz>
12777 * interface.cs (FindMembers): The operation is performed on all base
12778 interfaces and not only on the first. It is required for future CLS Compliance patch.
12780 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
12782 * statement.cs, codegen.cs:
12783 This patch deals with patterns such as:
12785 public class List : IEnumerable {
12787 public MyEnumerator GetEnumerator () {
12788 return new MyEnumerator(this);
12791 IEnumerator IEnumerable.GetEnumerator () {
12795 public struct MyEnumerator : IEnumerator {
12800 Before, there were a few things we did wrong:
12801 1) we would emit callvirt on a struct, which is illegal
12802 2) we emited ldarg when we needed to emit ldarga
12803 3) we would mistakenly call the interface methods on an enumerator
12804 type that derived from IEnumerator and was in another assembly. For example:
12806 public class MyEnumerator : IEnumerator
12808 Would have the interface methods called, even if there were public impls of the
12809 method. In a struct, this lead to invalid IL code.
12811 2004-02-11 Marek Safar <marek.safar@seznam.cz>
12813 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
12816 * delegate.cs (Define): Fixed crash when delegate type is undefined.
12818 2004-02-11 Miguel de Icaza <miguel@ximian.com>
12820 * cs-parser.jay: Fix small regression: we were not testing V2
12821 compiler features correctly.
12823 * interface.cs: If the emit context is null, then create one
12825 2004-02-09 Marek Safar <marek.safar@seznam.cz>
12827 * decl.cs (GetSignatureForError): New virtual method to get full name
12828 for error messages.
12830 * attribute.cs (IAttributeSupport): New interface for attribute setting.
12831 Now it is possible to rewrite ApplyAttributes method to be less if/else.
12833 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
12834 Duplicated members and code in these classes has been removed.
12835 Better encapsulation in these classes.
12837 2004-02-07 Miguel de Icaza <miguel@ximian.com>
12839 * assign.cs (Assign.DoResolve): When dealing with compound
12840 assignments, there is a new rule in ECMA C# 2.4 (might have been
12841 there before, but it is documented here) that states that in:
12845 If b is of type int, and the `op' is a shift-operator, then the
12846 above is evaluated as:
12850 * expression.cs (Binary.ResolveOperator): Instead of testing for
12851 int/uint/long/ulong, try to implicitly convert to any of those
12852 types and use that in pointer arithmetic.
12854 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
12855 method to print information for from the type, not from the
12856 null-method we were given.
12858 2004-02-01 Duncan Mak <duncan@ximian.com>
12860 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
12861 parsing for cmd, fixes bug #53694.
12863 2004-02-04 Marek Safar <marek.safar@seznam.cz>
12865 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
12866 in the member name duplication tests. Property and operator name duplication
12867 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
12869 2004-02-03 Marek Safar <marek.safar@seznam.cz>
12871 * interface.cs (PopulateMethod): Fixed crash when interface method
12872 returns not existing type (error test cs0246-3.cs).
12874 2004-02-02 Ravi Pratap M <ravi@ximian.com>
12876 * cs-parser.jay (interface_accessors): Re-write actions to also
12877 store attributes attached to get and set methods. Fix spelling
12880 (inteface_property_declaration): Modify accordingly.
12882 (InterfaceAccessorInfo): New helper class to store information to pass
12883 around between rules that use interface_accessors.
12885 * interface.cs (Emit): Apply attributes on the get and set
12886 accessors of properties and indexers too.
12888 * attribute.cs (ApplyAttributes): Modify accordingly to use the
12889 right MethodBuilder when applying attributes to the get and set accessors.
12891 2004-01-31 Miguel de Icaza <miguel@ximian.com>
12893 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
12895 2004-01-26 Miguel de Icaza <miguel@ximian.com>
12897 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
12899 2004-01-25 Miguel de Icaza <miguel@ximian.com>
12901 * cs-parser.jay: Remove YIELD token, instead use the new grammar
12902 changes that treat `yield' specially when present before `break'
12903 or `return' tokens.
12905 * cs-tokenizer.cs: yield is no longer a keyword.
12907 2004-01-23 Marek Safar <marek.safar@seznam.cz>
12909 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
12910 setting for default constructors.
12911 For default constructors are almost every time set wrong Modifier. The
12912 generated IL code has been alright. But inside mcs this values was
12913 wrong and this was reason why several of my CLS Compliance tests
12916 2004-02-27 Martin Baulig <martin@ximian.com>
12918 * generics.cs (ConstructedType.ResolveType): Make the nested type
12919 stuff actually work.
12921 2004-02-25 Martin Baulig <martin@ximian.com>
12923 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
12924 property; returns the type parameters just from the current type,
12925 ie. with the ones from outer classes.
12926 (DeclSpace.LookupGeneric): First search in the current class, then
12928 (DeclSpace.initialize_type_params): When hiding a type parameter
12929 from an outer class, put it into the `type_param_list' anyways.
12931 * expression.cs (MemberAccess.expr): Made this field protected.
12933 * class.cs (TypeContainer.Define): The `CurrentType' just contains
12934 the type parameters from the current class.
12936 * generic.cs (ConstructedType.ResolveType): Support nested generic
12937 types by taking the type parameters which we inherit from outer
12938 classes into account.
12939 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
12940 support for nested generic types.
12942 2004-02-23 Martin Baulig <martin@ximian.com>
12944 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
12945 field and check whether we're nested inside a generic type.
12946 (DeclSpace.ResolveType): If we're resolving to a generic type
12947 definition, create a ConstructedType and return its resolved type.
12948 (DeclSpace.initialize_type_params): New private method;
12949 initializes the `type_param_list' field from the type parameters
12950 from this and all enclosing classes.
12951 (DeclSpace.TypeParameters): Call initialize_type_params() unless
12952 we're already initialized.
12954 2004-02-23 Martin Baulig <martin@ximian.com>
12956 * class.cs (Method.Define): Create the generic method before
12957 calling DoDefine().
12958 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
12959 the TypeContainer one); we use this for generic methods.
12961 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
12962 parent's TypeBuilder.
12964 2004-02-18 Martin Baulig <martin@ximian.com>
12966 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
12967 to check for equality.
12969 2004-02-05 Martin Baulig <martin@ximian.com>
12971 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
12972 `ec.TypeContainer.CurrentType', use it instead of
12973 `ec.ContainerType' to check whether we're in the type's ctor.
12975 2004-01-29 Martin Baulig <martin@ximian.com>
12977 * expression.cs (Invocation.DoResolve): If we're a
12978 `ConstructedType', then we're actually a generic method, so
12979 rewrite the expr as a GenericMemberAccess.
12981 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
12982 here; manually parse it into a string.
12984 2004-01-28 Martin Baulig <martin@ximian.com>
12986 * typemanager.cs (TypeManager.IsEqual): New static method.
12987 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
12988 check for equality instead of using `=='.
12990 2004-01-26 Martin Baulig <martin@ximian.com>
12992 * decl.cs (DeclSpace.CurrentType): New public field.
12994 * expression.cs (This.ResolveBase): If we have an
12995 `ec.TypeContainer.CurrentType', use it instead of
12996 `ec.ContainerType'.
12998 * class.cs (TypeContainer.DefineType): If we're a generic type,
12999 create the `CurrentType' (unresolved).
13000 (TypeContainer.GenericType): New private field.
13001 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
13002 it and store it in `GenericType' before creating the MemberCache.
13003 (TypeContainer.GetMembers): If we have a `GenericType', call
13004 TypeManager.FindMembers() on it.
13006 * interface.cs (Interface.GenericType): New private field.
13007 (Interface.DefineType): If we're a generic type, create the
13008 `CurrentType' (unresolved).
13009 (Interface.DefineMembers): If we have a `CurrentType', resolve it
13010 and store it in `GenericType' before creating the MemberCache.
13011 (Interface.GetMembers): If we have a `GenericType', call
13012 TypeManager.FindMembers() on it.
13014 2004-01-22 Martin Baulig <martin@ximian.com>
13016 * cs-parser.jay (namespace_or_type_name): Return an Expression,
13017 not a QualifiedIdentifier. This is what `type_name_expression'
13018 was previously doing.
13019 (type_name_expression): Removed; the code is now in
13020 `namespace_or_type_name'.
13021 (qualified_identifier): Removed, use `namespace_or_type_name'
13023 (QualifiedIdentifier): Removed this class.
13025 2004-01-22 Martin Baulig <martin@ximian.com>
13027 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
13028 not a string as alias name.
13030 2004-01-21 Miguel de Icaza <miguel@ximian.com>
13032 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
13033 #52730 bug, and instead compute correctly the need to use a
13034 temporary variable when requesting an address based on the
13035 static/instace modified of the field and the constructor.
13037 2004-01-21 Martin Baulig <martin@ximian.com>
13039 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
13040 class and namespace before looking up aliases. Fixes #52517.
13042 2004-01-21 Martin Baulig <martin@ximian.com>
13044 * flowanalysis.cs (UsageVector.Merge): Allow variables being
13045 assinged in a 'try'; fixes exception4.cs.
13047 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13048 * class.cs : Implemented parameter-less constructor for TypeContainer
13050 * decl.cs: Attributes are now stored here. New property OptAttributes
13052 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
13054 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
13056 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13058 * typemanager.cs (CSharpSignature): Now reports also inner class name.
13059 (CSharpSignature): New method for indexer and property signature.
13061 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13063 * pending.cs (IsVirtualFilter): Faster implementation.
13065 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13067 * typemanager.cs: Avoid inclusion of same assembly more than once.
13069 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13071 * cs-parser.jay: Fixed problem where the last assembly attribute
13072 has been applied also to following declaration (class, struct, etc.)
13074 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13076 * class.cs: Added error CS0538, CS0539 reporting.
13077 Fixed crash on Microsoft runtime when field type is void.
13079 * cs-parser.jay: Added error CS0537 reporting.
13081 * pending.cs: Added error CS0535 reporting.
13082 Improved error report for errors CS0536, CS0534.
13084 2004-01-20 Miguel de Icaza <miguel@ximian.com>
13086 Merge a few bits from the Anonymous Method MCS tree.
13088 * statement.cs (ToplevelBlock): New class for toplevel methods,
13089 will hold anonymous methods, lifted variables.
13091 * cs-parser.jay: Create toplevel blocks for delegates and for
13092 regular blocks of code.
13094 2004-01-20 Martin Baulig <martin@ximian.com>
13096 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
13097 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
13098 and `NeedExplicitReturn'; added `IsLastStatement'.
13099 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
13100 have a `ReturnLabel' or we're not unreachable.
13102 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
13103 child's reachability; don't just override ours with it. Fixes
13104 #58058 (lluis's example).
13105 (FlowBranching): Added public InTryOrCatch(), InCatch(),
13106 InFinally(), InLoop(), InSwitch() and
13107 BreakCrossesTryCatchBoundary() methods.
13109 * statement.cs (Return): Do all error checking in Resolve().
13110 Unless we are the last statement in a top-level block, always
13111 create a return label and jump to it.
13112 (Break, Continue): Do all error checking in Resolve(); also make
13113 sure we aren't leaving a `finally'.
13114 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
13115 statement in a top-level block.
13116 (Block.Flags): Added `IsDestructor'.
13117 (Block.IsDestructor): New public property.
13119 2004-01-20 Martin Baulig <martin@ximian.com>
13121 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
13123 2004-01-20 Martin Baulig <martin@ximian.com>
13125 * statement.cs (Statement.ResolveUnreachable): New public method.
13126 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
13127 (Block.Resolve): Resolve unreachable statements.
13129 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13131 * expression.cs: We need to fix the case where we do
13132 not have a temp variable here.
13134 * assign.cs: Only expression compound assignments need
13135 temporary variables.
13137 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13139 * flowanalysis.cs: Reduce memory allocation in a few ways:
13140 - A block with no variables should not allocate a bit
13142 - A method with no out parameters does not need any tracking
13143 for assignment of the parameters, so we need not allocate
13146 public readonly Type[] VariableTypes;
13147 public readonly string[] VariableNames;
13148 Are redundant. The data is already stored in the variable
13149 map, so we need not allocate another array for it.
13150 - We need to add alot of checks for if (params | locals) == null
13151 due to the first two changes.
13153 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13155 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13156 implement IMemoryLocation, we store a copy on a local variable and
13157 take the address of it. Patch from Benjamin Jemlich
13159 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13160 to use a special "type_name_expression" rule which reduces the
13161 number of "QualifiedIdentifier" classes created, and instead
13162 directly creates MemberAccess expressions.
13164 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13166 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13167 that fixes #52853. Null literal assignment to ValueType
13169 * class.cs (MethodData.Emit): Instead of checking the name of the
13170 method to determine if its a destructor, create a new derived
13171 class from Method called Destructor, and test for that.
13173 * cs-parser.jay: Create a Destructor object instead of a Method.
13175 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13179 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13181 * expression.cs (Binary.ResolveOperator): Perform an implicit
13182 conversion from MethodGroups to their delegate types on the
13183 Addition operation.
13185 * delegate.cs: Introduce a new class DelegateCreation that is the
13186 base class for `NewDelegate' and `ImplicitDelegateCreation',
13187 factor some code in here.
13189 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13190 conversion from MethodGroups to compatible delegate types.
13192 * ecore.cs (Expression.Resolve): Do not flag error 654
13193 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13194 we allow conversions from MethodGroups to delegate types now.
13196 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13197 assignments in v2 either.
13199 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13201 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13202 static read-only fields in ctors.
13204 Applied patch from Benjamin Jemlich
13206 * expression.cs (UnaryMutator): Avoid leaking local variables.
13208 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13210 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13211 here to return true, as they can be used like this:
13213 (XXX) int.MEMBER ()
13215 Fixed 49836 and all the other dups
13217 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13219 * driver.cs: Implement /win32res and /win32icon.
13221 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13223 * cs-parser.jay: Add a rule to improve error handling for the
13224 common mistake of placing modifiers after the type.
13226 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13228 * cs-parser.jay (interface_event_declaration): Catch
13229 initialization of events on interfaces, and report cs0068
13231 * cs-parser.jay (interface_event_declaration): Catch
13232 initialization of events.
13234 * ecore.cs: Better report missing constructors.
13236 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13237 the error reporting done in the wrong place. Fix.
13239 * expression.cs (Binary.ResolveOperator): Catch the
13240 operator + (E x, E y) error earlier, and later allow for implicit
13241 conversions in operator +/- (E e, U x) from U to the underlying
13244 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13245 52596, if the container class is abstract, the default constructor
13246 is protected otherwise its public (before, we were always public).
13248 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13251 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13252 Jemlich that fixes bug #52597, MCS was generating invalid code for
13253 idisposable structs. Thanks to Ben for following up with this
13256 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13258 * driver.cs: Allow assemblies without code to be generated, fixes
13261 2004-01-07 Nick Drochak <ndrochak@gol.com>
13263 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13265 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13267 * cs-parser.jay: Add rules to improve error reporting if fields or
13268 methods are declared at the namespace level (error 116)
13270 * Add rules to catch event add/remove
13272 2004-01-04 David Sheldon <dave-mono@earth.li>
13274 * expression.cs: Added matching ")" to error message for
13277 2004-01-03 Todd Berman <tberman@gentoo.org>
13279 * ecore.cs, attribute.cs:
13280 Applying fix from #52429.
13282 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13284 * ecore.cs, expression.cs, statement.cs:
13285 Total rewrite of how we handle branching. We
13286 now handle complex boolean expressions with fewer
13287 jumps. As well if (x == 0) no longer emits a ceq.
13289 if (x is Foo) is much faster now, because we generate
13292 Overall, we get a pretty big improvement on our benchmark
13293 tests. The code we generate is smaller and more readable.
13295 I did a full two-stage bootstrap. The patch was reviewed
13296 by Martin and Miguel.
13298 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13300 * cs-parser.jay: Make primary_expression not take a QI.
13301 we dont need this because the member_access rule covers
13302 us here. So we replace the rule with just IDENTIFIER.
13304 This has two good effects. First, we remove a s/r conflict.
13305 Second, we allocate many fewer QualifiedIdentifier objects.
13307 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13309 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13310 set the correct information via SRE. This prevents
13311 hanging on the MS runtime. Fixes #29374.
13313 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13315 * convert.cs: correctly handle conversions to value types
13316 from Enum and ValueType as unboxing conversions.
13318 Fixes bug #52569. Patch by Benjamin Jemlich.
13320 2004-01-02 Ravi Pratap <ravi@ximian.com>
13322 * expression.cs (BetterConversion): Prefer int -> uint
13323 over int -> ulong (csc's behaviour). This fixed bug #52046.
13325 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13327 * decl.cs (MemberCache.FindMembers): now returns a
13330 * typemanager.cs: In general, go with with ^^.
13331 (CopyNewMethods): take an IList.
13332 (RealMemberLookup): Only allocate an arraylist
13333 if we copy from two sets of methods.
13335 This change basically does two things:
13336 1) Fewer array lists allocated due to CopyNewMethods.
13337 2) the explicit cast in MemberList costed ALOT.
13339 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13341 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13342 a hashtable to avoid needless string allocations when an identifier is
13343 used more than once (the common case).
13345 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13347 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13348 is broken, it will not return anything. So, we
13349 have to use the information we have in mcs to
13352 * typemanager.cs: Add a cache for GetInterfaces,
13353 since this will now be used more often (due to ^^)
13355 (GetExplicitInterfaces) New method that gets the
13356 declared, not effective, interfaces on a type
13357 builder (eg, if you have interface IFoo, interface
13358 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13361 This patch makes MCS able to bootstrap itself on
13364 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13366 * expression.cs: Remove the Nop's that Miguel put
13369 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13371 * report.cs, codegen.cs: Give the real stack trace to
13372 the error when an exception is thrown.
13374 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13376 * decl.cs: only allocate hashtables for ifaces if
13379 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13381 * expression.cs: fix the error from cs0121-2.cs
13382 (a parent interface has two child interfaces that
13383 have a function with the same name and 0 params
13384 and the function is called through the parent).
13386 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13388 * class.cs, rootcontext.cs, typmanager.cs: do not
13391 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13393 * codegen.cs: remove stack for the ec flow branching.
13394 It is already a linked list, so no need.
13396 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13398 * Makefile: Allow custom profiler here.
13400 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13402 * typemanager.cs (LookupType):
13403 - Use a static char [], because split takes
13404 a param array for args, so it was allocating
13406 - Do not store true in a hashtable, it boxes.
13408 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13410 * flowanalysis.cs: bytify common enums.
13412 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13414 * modifiers.cs: Add a new set of flags for the
13415 flags allowed on explicit interface impls.
13416 * cs-parser.jay: catch the use of modifiers in
13417 interfaces correctly.
13418 * class.cs: catch private void IFoo.Blah ().
13420 All related to bug #50572.
13422 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13424 * decl.cs: Rewrite the consistant accessability checking.
13425 Accessability is not linear, it must be implemented in
13426 a tableish way. Fixes #49704.
13428 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13430 * expression.cs: Handle negation in a checked context.
13431 We must use subtraction from zero. Fixes #38674.
13433 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13435 * class.cs: Ignore static void main in DLLs.
13436 * rootcontext.cs: Handle the target type here,
13437 since we are have to access it from class.cs
13438 * driver.cs: account for the above.
13440 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13442 * report.cs: Give line numbers and files if available.
13444 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13446 * driver.cs: Implement /addmodule.
13448 * typemanager.cs: Change 'modules' field so it now contains Modules not
13451 2003-12-20 Martin Baulig <martin@ximian.com>
13453 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13454 (FieldBase.IsAssigned): Removed this field.
13455 (FieldBase.SetAssigned): New public method.
13456 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13458 2003-12-20 Martin Baulig <martin@ximian.com>
13460 * expression.cs (LocalVariableReference.DoResolve): Don't set
13461 `vi.Used' if we're called from DoResolveLValue().
13463 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13464 returns the usage vector it just merged into the current one -
13465 pass this one to UsageWarning().
13466 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13467 of the `EmitContext', don't call this recursively on our children.
13469 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13471 * driver.cs: Implement /target:module.
13473 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13475 * support.cs (CharArrayHashtable): New helper class.
13477 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13478 char arrays, not strings, so we can avoid creating a string in
13479 consume_identifier if the identifier is a keyword.
13481 2003-12-16 Martin Baulig <martin@ximian.com>
13483 * statement.cs (LocalInfo.Assigned): Removed this property.
13484 (LocalInfo.Flags): Removed `Assigned'.
13485 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13486 and uses flow analysis.
13487 (Block.UsageWarning): Made this method private.
13488 (Block.Resolve): Call UsageWarning() if appropriate.
13490 * expression.cs (LocalVariableReference.DoResolve): Always set
13491 LocalInfo.Used here.
13493 2003-12-13 Martin Baulig <martin@ximian.com>
13495 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13496 any value here; we're now using flow analysis to figure out
13497 whether a statement/block returns a value.
13499 2003-12-13 Martin Baulig <martin@ximian.com>
13501 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13503 (FlowBranching.MergeFinally): Don't call
13504 `branching.CheckOutParameters()' here, this is called in
13506 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13507 when adding the `finally' vector.
13509 2003-12-13 Martin Baulig <martin@ximian.com>
13512 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13513 actually work and also fix #48962.
13515 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13517 * decl.cs: Do not check System.Object for nested types,
13518 since we know it does not have any. Big bang for buck:
13521 Run 1: 8.35 seconds
13522 Run 2: 8.32 seconds
13523 corlib: 17.99 seconds
13525 Run 1: 8.17 seconds
13526 Run 2: 8.17 seconds
13527 corlib: 17.39 seconds
13529 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13531 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13532 time we are returning 0 members, so we save alot here.
13534 2003-12-11 Martin Baulig <martin@ximian.com>
13536 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13537 `MergeChild()', also just take the `FlowBranching' as argument;
13538 call Merge() on it and return the result.
13539 (FlowBranching.Merge): We don't need to do anything if we just
13542 2003-12-11 Martin Baulig <martin@ximian.com>
13544 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13545 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13546 Maurer for this idea.
13548 2003-12-11 Martin Baulig <martin@ximian.com>
13550 * flowanalysis.cs (MergeResult): This class is now gone; we now
13551 use the `UsageVector' for this. The reason for this is that if a
13552 branching just has one sibling, we don't need to "merge" them at
13553 all - that's the next step to do.
13554 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13557 2003-12-11 Martin Baulig <martin@ximian.com>
13559 Reworked flow analyis and made it more precise and bug-free. The
13560 most important change is that we're now using a special `Reachability'
13561 class instead of having "magic" meanings of `FlowReturns'. I'll
13562 do some more cleanups and optimizations and also add some more
13563 documentation this week.
13565 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13566 largely reworked this class.
13567 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13568 the new `Reachability' class instead of having "magic" values here.
13569 (FlowBranching): We're now using an instance of `Reachability'
13570 instead of having separate `Returns', `Breaks' etc. fields.
13572 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13573 based on flow analysis; ignore the return value of block.Emit ().
13575 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13577 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13578 if they are private.
13580 2003-12-09 Martin Baulig <martin@ximian.com>
13582 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13583 call them directly on the UsageVector.
13585 2003-12-09 Martin Baulig <martin@ximian.com>
13587 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13588 Changed return type from `FlowReturns' to `Reachability'.
13590 2003-12-09 Martin Baulig <martin@ximian.com>
13592 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13593 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13594 `Reachable' fields with a single `Reachability' one.
13596 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13598 * class.cs (FindMembers): Remove foreach's.
13603 Run 1: 8.74 seconds
13604 Run 2: 8.71 seconds
13607 Run 1: 8.64 seconds
13608 Run 2: 8.58 seconds
13611 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13616 This patch does a few things:
13617 1. EmptyStatement is now a singleton, so it is never reallocated.
13618 2. All blah is EmptyStatement constructs have been changed to
13619 blah == EmptyStatement.Value, which is much faster and valid
13620 now that EmptyStatement is a singleton.
13621 3. When resolving a block, rather than allocating a new array for
13622 the non-empty statements, empty statements are replaced with
13623 EmptyStatement.Value
13624 4. Some recursive functions have been made non-recursive.
13625 Mainly the performance impact is from (3), however (1) and (2) are needed for
13626 this to work. (4) does not make a big difference in normal situations, however
13627 it makes the profile look saner.
13632 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13633 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13634 Total memory allocated: 56397 KB
13637 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13638 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13639 Total memory allocated: 55666 KB
13641 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13643 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13644 than the hashtable in a hashtable version
13646 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13647 we always end up concating a string. This results in a huge perf
13648 loss, because many strings have to be tracked by the GC. In this
13649 patch, we first use a hashtable that works with two keys, so that
13650 the strings do not need to be concat'ed.
13654 Run 1: 8.74 seconds
13655 Run 2: 8.71 seconds
13658 Run 1: 8.65 seconds
13659 Run 2: 8.56 seconds
13661 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13663 * Makefile: Add a new target `do-time' that does a quick and simple
13664 profile, leaving easy to parse output.
13666 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13668 * codegen.cs (Init): Create the dynamic assembly with
13669 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13671 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13673 * support.cs: Make the PtrHashtable use only one
13674 instance of its comparer.
13676 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13678 * typemanager.cs: Fix lookup of GetNamespaces.
13680 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13682 * expression.cs: Removed redundant line.
13684 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13685 ArrayLists, use for loops with bounds.
13687 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13690 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13691 arraylists, use for loop with bounds.
13693 The above three changes give us a 0.071 second performance
13694 improvement out of 3.294 seconds down to 3.223. On my machine
13695 the above changes reduced the memory usage by 1,387 KB during
13696 compiler bootstrap.
13698 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13699 QualifiedIdentifiers. Before we created a new string through
13700 concatenation, and mostly later on, the result would be
13701 manipulated by DecomposeQI through string manipulation.
13703 This reduced the compiler memory usage for bootstrapping from
13704 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13705 compile times in 0.05 seconds.
13707 2003-11-28 Dick Porter <dick@ximian.com>
13709 * support.cs: Do string compares with the Invariant culture.
13717 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13718 the comparison is done with the Invariant culture.
13720 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13722 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13723 GetEnumerator method.
13725 (ProbeCollectionType): Iterate starting at the most specific type
13726 upwards looking for a GetEnumerator
13728 * expression.cs: Shift count can be up to 31 for int/uint and 63
13731 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13733 * statement.cs (Block.LookupLabel): Also look for the label on the
13734 children blocks. Use a hash table to keep track of visited
13737 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13738 we actually did transform the other operand, otherwise fall back
13739 to the common codepath that casts to long.
13741 * cs-tokenizer.cs: Use the same code pattern as the int case.
13742 Maybe I should do the parsing myself, and avoid depending on the
13743 Parse routines to get this done.
13745 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13747 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13748 which fixes bug 51347. This time test it.
13750 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13751 attributes for example can not tell the difference between these.
13752 The difference was only a syntax feature of the language.
13754 * attribute.cs: Apply attributes to delegates.
13756 * delegate.cs: Call the apply attributes method.
13758 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13760 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13761 comparing 0 vs Byte.MinValue, not the value
13763 (ImplicitConversionRequired): When reporting a conversion error,
13764 use error 31 to print out the constant error instead of the
13767 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13768 which fixes bug 51347.
13770 2003-11-22 Miguel de Icaza <miguel@ximian.com>
13772 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
13773 which fixes the -warnaserror command line option.
13775 2003-11-21 Miguel de Icaza <miguel@ximian.com>
13777 * cfold.cs (DoNumericPromotions): During constant folding of
13778 additions on UIntConstant, special case intconstants with
13779 IntConstants like we do on the expression binary operator.
13781 2003-11-12 Miguel de Icaza <miguel@ximian.com>
13783 * convert.cs (ImplicitReferenceConversion): We were missing a case
13784 (System.Enum are not value types or class types, so we need to
13785 classify them separatedly).
13787 * driver.cs: We do not support error 2007.
13789 2003-11-12 Jackson Harper <jackson@ximian.com>
13791 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
13792 system directory. Also use the full file name so users can
13793 libraries names mscorlib-o-tron.dll in a non system dir.
13795 2004-01-04 David Sheldon <dave-mono@earth.li>
13797 * expression.cs: Added matching ")" to error message for CS0077.
13799 2003-12-19 Martin Baulig <martin@ximian.com>
13801 * typemanager.cs (TypeManager.IsEqualGenericType): New public
13802 static method; see documentation in the method.
13803 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
13805 * convert.cs (Convert.ImplicitReferenceConversion,
13806 Convert.ImplicitReferenceConversionExists): Add support for
13807 generic type declarations; see gen-36.cs.
13809 2003-12-19 Martin Baulig <martin@ximian.com>
13811 * pending.cs (Pending.InterfaceMethod): Use
13812 `Type.IsAssignableFrom()' instead of `=='.
13814 2003-12-18 Martin Baulig <martin@ximian.com>
13816 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
13819 * convert.cs (Convert.ImplicitStandardConversionExists): Use
13820 `expr_type.Equals (target_type)' instead of `=='.
13822 2003-12-08 Martin Baulig <martin@ximian.com>
13824 * generics.cs (Constraints.Types): Removed.
13825 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
13827 (Constraints.ResolveTypes): New public method; resolves the
13828 TypeExpr's to Type's.
13829 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
13830 longer takes the constraints.
13831 (TypeParameter.DefineMethod): Likewise.
13832 (TypeParameter.DefineType): New public method. Calls
13833 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
13836 2003-12-08 Martin Baulig <martin@ximian.com>
13838 * convert.cs (Convert.ImplicitConversionStandard): Use
13839 `expr_type.Equals (target_type)' instead of `=='.
13841 2003-12-08 Martin Baulig <martin@ximian.com>
13843 * typemanager.cs (TypeManager.GetReferenceType): Call
13844 `Type.MakeByRefType ()'.
13846 2003-12-08 Martin Baulig <martin@ximian.com>
13848 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
13849 just has some special meaning in some situations. For instance,
13850 it is allowed to use `where' as the name of a variable etc.
13852 2003-12-04 Martin Baulig <martin@ximian.com>
13854 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13855 `Type.MakeArrayType()' for array types.
13857 2003-11-18 Miguel de Icaza <miguel@ximian.com>
13859 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
13862 (SizeOf.DoResolve): assign the `type_queried' field. This gets
13865 2003-11-16 Martin Baulig <martin@ximian.com>
13867 * codegen.cs (EmitContext.IsGeneric): Removed.
13869 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
13870 ResolveGeneric() on the DeclSpace.
13872 2003-11-16 Martin Baulig <martin@ximian.com>
13874 * generic.cs (TypeArguments.Resolve):
13875 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
13876 `ResolveType()' on it to get the Type.
13878 2003-11-15 Martin Baulig <martin@ximian.com>
13880 * generic.cs (ConstructedType.GetInterfaces): Override this.
13882 2003-11-14 Martin Baulig <martin@ximian.com>
13884 * interface.cs (Interface.DefineType): Define all type parameters
13885 before adding the interfaces we inherit.
13887 2003-11-11 Martin Baulig <martin@ximian.com>
13889 * generic.cs (ConstructedType.ResolveType): Always call
13890 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
13892 2003-11-10 Martin Baulig <martin@ximian.com>
13894 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
13895 (TypeManager.InitCoreTypes): Initialize them here, but instead of
13896 calling `ResolveType()' on them, directly assign their `Type'.
13898 2003-11-08 Martin Baulig <martin@ximian.com>
13900 * generic.cs (ConstructedType): Override `IsClass' etc.
13902 2003-11-08 Martin Baulig <martin@ximian.com>
13904 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
13905 return value and the `out parent' parameter.
13906 (TypeContainer.DefineType): Moved the CS0644 check into
13907 GetClassBases(). Don't pass the interface types to the
13908 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
13909 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
13911 * ecore.cs (TypeExpr.IsAttribute): New property.
13912 (TypeExpr.GetInterfaces): New method.
13914 * interface.cs (Interface.GetInterfaceTypeByName): Return a
13915 TypeExpr instead of a Type.
13916 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
13917 (Interface.DefineType): Don't pass the interface types to the
13918 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
13919 them later and then call `TypeBulider.AddInterfaceImplementation()'.
13921 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
13922 instead of a `Type[]'.
13923 (TypeManager.RegisterBuilder): Likewise.
13924 (TypeManager.AddUserInterface): Likewise.
13925 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
13926 `Type[]' and also return a `TypeExpr[]'.
13927 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
13929 2003-11-08 Martin Baulig <martin@ximian.com>
13931 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
13934 2003-11-08 Martin Baulig <martin@ximian.com>
13936 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
13937 TypeManager.ResolveExpressionTypes().
13939 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
13940 instead of an Expression.
13941 (TypeExpr): This is now an abstract base class for `TypeExpression'.
13942 (TypeExpression): New public class; formerly known as `TypeExpr'.
13944 * expression.cs (ComposedCast): Derive from TypeExpr.
13946 * typemanager.cs (TypeManager.system_*_expr): These are now
13947 TypExpr's instead of Expression's.
13948 (TypeManager.ResolveExpressionTypes): New public static function;
13949 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
13952 2003-11-06 Miguel de Icaza <miguel@ximian.com>
13954 * expression.cs (New.DoResolve): Do not dereference value that
13955 might be a null return.
13957 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
13958 sure that the constant value has the right type. Fixes an
13959 unreported bug, similar to 50425.
13961 * const.cs (Const.LookupConstantValue): Call
13962 ImplicitStandardConversionExists before doing a conversion to
13963 avoid havng the TypeManager.ChangeType do conversions.
13965 Reduced the number of casts used
13967 (Const.ChangeType): New routine to enable reuse of the constant
13968 type changing code from statement.
13970 * typemanager.cs (ChangeType): Move common initialization to
13971 static global variables.
13975 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
13976 every value type to go through, even if it was void. Fix that.
13978 * cs-tokenizer.cs: Use is_identifier_start_character on the start
13979 character of the define, and the is_identifier_part_character for
13980 the rest of the string.
13982 2003-11-05 Miguel de Icaza <miguel@ximian.com>
13984 * expression.cs (UnaryMutator.EmitCode): When I updated
13985 LocalVariableReference.DoResolve, I overdid it, and dropped an
13986 optimization done on local variable references.
13988 2003-11-04 Miguel de Icaza <miguel@ximian.com>
13990 * ecore.cs: Convert the return from Ldlen into an int.
13992 2003-10-20 Miguel de Icaza <miguel@ximian.com>
13994 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
13995 the accessibility, this is a special case for toplevel non-public
13996 classes (internal for instance).
13998 2003-10-20 Nick Drochak <ndrochak@gol.com>
14000 * ecore.cs: Fix typo and build. Needed another right paren.
14002 2003-10-19 Miguel de Icaza <miguel@ximian.com>
14004 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
14005 `internal' case regular and protected, but not allowing protected
14006 to be evaluated later. Bug 49840
14008 2003-10-15 Miguel de Icaza <miguel@ximian.com>
14010 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
14011 to kb.Nlast, and not the kb.nFirst to isolate the switch
14014 Extract the underlying type, so enumerations of long/ulong are
14015 treated like long/ulong.
14017 2003-10-14 Miguel de Icaza <miguel@ximian.com>
14019 * expression.cs (New): Overload the meaning of RequestedType to
14020 track the possible creation of the NewDelegate type, since
14021 DoResolve is invoked more than once for new constructors on field
14024 See bugs: #48800 and #37014
14026 * cs-parser.jay (declare_local_constants): Take an arraylist
14027 instead of a single constant.
14029 (local_constant_declaration): It should take a
14030 constant_declarators, not a constant_declarator. Fixes 49487
14032 * convert.cs: Fix error report.
14034 2003-10-13 Jackson Harper <jackson@ximian.com>
14036 * typemanager.cs (TypeToCoreType): Add float and double this fixes
14039 2003-11-03 Martin Baulig <martin@ximian.com>
14041 * expression.cs (ArrayAccess.GetStoreOpcode): Added
14042 `out bool has_type_arg'; if set, we need to pass the type to
14044 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
14045 Stelem_Any/Ldelem_Any for generic parameters.
14047 2003-11-02 Martin Baulig <martin@ximian.com>
14049 * expression.cs (Invocation.EmitCall): Use
14050 `TypeManager.IsValueType()' to check whether it's a value type.
14051 Don't set `struct_call' when calling a method on a type parameter.
14053 2003-11-02 Martin Baulig <martin@ximian.com>
14055 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
14056 and removed the TypeBuilder argument.
14058 * typemanager.cs (TypeManager.IsValueType): Return
14059 `t.IsGenericParameter || t.IsValueType'.
14061 2003-10-25 Martin Baulig <martin@ximian.com>
14063 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
14064 call ConstructedType.Resolve() on it.
14066 * generic.cs (ConstructedType.Resolve): Set `type' on success.
14068 2003-10-25 Martin Baulig <martin@ximian.com>
14070 * class.cs (TypeContainer.GetClassBases): Changed
14071 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
14072 CS8214 reporting here.
14073 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
14074 instead of a `Type' for our parent. In case of a recursive
14075 declaration (see tests/gen-23.cs for an example), our parent is a
14076 ConstructedType and it doesn't have its type set. So, first
14077 create our own TypeBuilder, then call constructed.Resolve() to get
14078 the parent's type and finally TypeBuilder.SetParent() it.
14080 * ecore.cs (TypeExpr.Name): New public virtual property.
14083 (ConstructedType): We're now a TypeExpr and not just an Expression.
14084 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
14085 arguments here; this is done later.
14086 (ConstructedType.Resolve): New public method to resolve the type
14087 arguments and bind them.
14089 2003-10-21 Martin Baulig <martin@ximian.com>
14091 * convert.cs: Use `TypeManager.IsValueType' instead of
14092 'type.IsValueType' everywhere.
14094 * typemanager.cs (TypeManager.IsValueType): Return true for type
14095 parameters. The reason for this is that we need to box a type
14096 parameter when converting it to a reference type.
14098 * cs-parser.jay: Added support for default value expressions.
14100 * generics.cs (DefaultValueExpression): New public class.
14102 2003-10-17 Martin Baulig <martin@ximian.com>
14104 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
14105 TypeContainer so we can also use this for Interfaces.
14106 (TypeParameter.Resolve): Likewise.
14108 * interface.cs (Interface.DefineType): Added support for generic
14111 * cs-parser.jay: Added support for generic structs and interfaces.
14113 2003-10-17 Martin Baulig <martin@ximian.com>
14115 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
14116 call generic methods :-)
14118 2003-10-16 Martin Baulig <martin@ximian.com>
14120 * cs-parser.jay (namespace_or_type_name): Only create a
14121 GenericMemberAccess if we actually have type arguments.
14123 2003-10-13 Martin Baulig <martin@ximian.com>
14125 * class.cs (Method.Define): If we're a generic method, call
14126 TypeBuilder.DefineGenericMethod () before resolving
14128 (MethodData): Added .ctor which takes an additional MethodBuilder
14129 argument; this is used for generic methods.
14130 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
14131 we already have a MethodBuilder.
14133 2003-10-10 Martin Baulig <martin@ximian.com>
14135 * class.cs (Method): Added .ctor which takes a `GenericMethod'
14136 instead of a `DeclSpace'. This is used for generic methods.
14138 * cs-parser.jay (method_header): Added support for generic
14139 methods; create a `GenericMethod' instance and pass it to the
14140 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
14141 parameters and locals.
14143 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
14144 since we already have the location. Check whether we're a generic
14145 type declaration or a generic method and create the correct type
14148 * generic.cs (TypeParameter.DefineMethod): New public method.
14149 (GenericMethod): New public class; derives from DeclSpace and is
14150 used for generic methods.
14152 2003-10-09 Martin Baulig <martin@ximian.com>
14154 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14156 (MethodCore.DoDefineParameters): Removed the TypeContainer
14157 argument; use the DeclSpace which was passed to the .ctor instead.
14158 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14159 TypeContainer; we only need a DeclSpace here.
14161 2003-10-09 Martin Baulig <martin@ximian.com>
14163 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14165 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14166 EmitContext's .ctor.
14168 2003-10-09 Martin Baulig <martin@ximian.com>
14170 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14171 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14172 AsAccessible(), moved them as well.
14174 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14176 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14178 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14179 generation for >=, as spotted by Paolo, bug 48679.
14180 Patch from David Waite.
14182 * cs-tokenizer.cs: Add handling for #pragma.
14184 * cs-parser.jay: Allow for both yield and yield return in the
14185 syntax. The anti-cobolization of C# fight will go on!
14187 * class.cs (TypeBuilder.DefineType): Catch error condition here
14188 (Parent.DefineType erroring out and returning null).
14190 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14191 coping with enumerations variables, we were mistakenly processing
14192 them as a regular value type instead of built-in types. Fixes the
14195 * typemanager.cs (IsBuiltinOrEnum): New method.
14197 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14199 * cs-parser.jay: Upgrade: yield now needs the return clause.
14201 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14203 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14205 2003-09-29 Martin Baulig <martin@ximian.com>
14207 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14208 inflated generic methods.
14210 * generics.cs (ConstructedType): Distinguish between open and
14211 closed constructed types; correctly resolve the arguments.
14213 2003-09-22 Martin Baulig <martin@ximian.com>
14215 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14216 all type arguments meet their constraints.
14218 2003-09-19 Martin Baulig <martin@ximian.com>
14220 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14221 `MemberCache parent' argument. Normally, an interface doesn't
14222 have a parent type except System.Object, but we use this in gmcs
14223 for generic type parameters.
14225 2003-09-18 Martin Baulig <martin@ximian.com>
14227 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14228 on `type.IsInterface'; don't check whether the type has a parent
14229 to determine whether it's an interface.
14231 2003-09-17 Martin Baulig <martin@ximian.com>
14233 * generic.cs (ConstructedType.ToString): Always use `name' as the
14236 2003-09-15 Martin Baulig <martin@ximian.com>
14238 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14240 * generic.cs (Constraints.Resolve): New public method; this is
14241 called to resolve the constraint types and to check whether all
14242 the constraints are correct.
14243 (Constraints.Types): New public property.
14244 (TypeParameter.Resolve): New public method; resolves all the
14245 type's constraints.
14247 * class.cs (TypeContainer.DefineType): Call
14248 TypeParameter.Resolve() before actually defining the type.
14250 2003-09-15 Martin Baulig <martin@ximian.com>
14252 * class.cs (TypeContainer.DefineType): Added an error flag to
14253 avoid reporting duplicate CS0146's ("class definition is
14256 * driver.cs (Driver.MainDriver): Abort if
14257 RootContext.ResolveTree() reported any errors.
14259 2003-09-07 Martin Baulig <martin@ximian.com>
14261 * report.cs (Error, Warning): Added overloaded versions which take
14262 a `params object[] args' and call String.Format().
14264 2003-09-07 Martin Baulig <martin@ximian.com>
14266 * decl.cs (DeclSpace..ctor): Don't call
14267 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14268 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14269 (DeclSpace.RecordDecl): New method.
14271 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14273 2003-09-02 Ravi Pratap <ravi@ximian.com>
14275 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14276 value attributes to be applied to ParameterBuilders.
14278 * class.cs (MethodCore.LabelParameters): Make static and more
14279 generic so that it can be used from other places - like interface
14280 methods, for instance.
14282 * interface.cs (Interface.Emit): Call LabelParameters before
14283 emitting attributes on the InterfaceMethod.
14285 2003-09-07 Martin Baulig <martin@ximian.com>
14287 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14288 if the number of type parameters doesn't match.
14290 2003-09-04 Martin Baulig <martin@ximian.com>
14292 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14293 for arrays of generic type params (ie. `!0[]').
14295 2003-09-04 Martin Baulig <martin@ximian.com>
14297 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14300 2003-09-04 Martin Baulig <martin@ximian.com>
14302 * decl.cs (DeclSpace.LookupGeneric): New method.
14303 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14306 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14307 argument, not just a string.
14308 (TypeParameter.Define): New public method; this is called to
14309 actually define the generic parameter; after this, you can use the
14310 new `Type' property to get the type.
14312 2003-09-04 Martin Baulig <martin@ximian.com>
14314 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14315 is now an ArrayList; initialize the result of the `TypeParameters'
14317 (DeclSpace.GetGenericData): Removed.
14318 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14319 implement this in a different way.
14320 (DeclSpace.GetTypeParameters): Removed; there's now a
14321 `TypeParameters' property.
14322 (DeclSpace.TypeParameters): New public property.
14324 * generic.cs (Constraints): Make this class public.
14325 (TypeParameter): New public class.
14327 2003-09-04 Martin Baulig <martin@ximian.com>
14329 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14330 generic parameters.
14332 * class.cs (TypeContainer.DefineType): Call
14333 TypeBuilder.DefineGenericParameter () on all generic parameters if
14334 this is a generic type.
14336 2003-08-28 Martin Baulig <martin@ximian.com>
14338 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14341 * sample-hello.cs: Compile this with gmcs: "gmcs
14342 /r:sample-stack.dll sample-hello.cs".
14344 2003-08-28 Martin Baulig <martin@ximian.com>
14346 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14347 the parameters to the generic type.
14349 2003-08-28 Martin Baulig <martin@ximian.com>
14351 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14353 2003-08-28 Martin Baulig <martin@ximian.com>
14355 * cs-parser.jay (opt_type_argument_list): Use
14356 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14357 (primary_expression): Replace `qualified_identifier' with `type_name'.
14358 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14360 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14361 parser to check whether it is syntactically a type parameter list;
14362 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14365 2003-08-26 Martin Baulig <martin@ximian.com>
14367 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14368 resolving aliases; fixes #47927.
14370 2003-08-26 Martin Baulig <martin@ximian.com>
14372 * statement.cs (Using.DoResolve): This is internally emitting a
14373 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14374 do not always return. Fixes #47681.
14376 2003-08-26 Martin Baulig <martin@ximian.com>
14378 * decl.cs (MemberCore): Moved WarningNotHiding(),
14379 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14381 (AdditionResult): Make this nested in DeclSpace.
14382 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14383 argument; call NamespaceEntry.Define() unless we're nested in a
14386 * namespace.cs (Namespace.DefineName): New public function. This
14387 is called from DeclSpace's .ctor to add
14388 (Namespace.Lookup): Include DeclSpaces in the lookup.
14390 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14392 * const.cs (Const): Derive from MemberBase, not MemberCore.
14394 2003-08-25 Martin Baulig <martin@ximian.com>
14396 * convert.cs (Convert.ExplicitReferenceConversion): When
14397 converting from an interface type to a class, unbox if the target
14398 type is a struct type. Fixes #47822.
14400 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14402 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14405 2003-08-22 Martin Baulig <martin@ximian.com>
14407 * class.cs (TypeManager.DefineType): When defining a nested type,
14408 call DefineType() on our parent; fixes #47801.
14410 2003-08-22 Martin Baulig <martin@ximian.com>
14412 * class.cs (MethodData.Define): While checking if a method is an
14413 interface implementation, improve the test a bit more to fix #47654.
14415 2003-08-22 Martin Baulig <martin@ximian.com>
14417 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14418 correctly; fixes #47722.
14420 2003-08-22 Martin Baulig <martin@ximian.com>
14422 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14423 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14425 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14427 2003-08-22 Martin Baulig <martin@ximian.com>
14429 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14430 can only be assigned in static constructors. Fixes #47161.
14432 2003-08-22 Martin Baulig <martin@ximian.com>
14434 Rewrote and improved the flow analysis code.
14436 * flowbranching.cs (FlowBranching): Make this class abstract.
14437 (FlowBranching.CreateBranching): New static function to create a
14438 new flow branching.
14439 (FlowBranchingBlock, FlowBranchingException): New classes.
14440 (FlowBranching.UsageVector.Type): New public readonly field.
14441 (FlowBranching.UsageVector.Breaks): Removed the setter.
14442 (FlowBranching.UsageVector.Returns): Removed the setter.
14443 (FlowBranching.UsageVector): Added Break(), Return(),
14444 NeverReachable() and Throw() methods to modify the reachability.
14445 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14446 done by FlowBranching.Merge().
14447 (FlowBranching.UsageVector.MergeChild): New method; merges the
14448 merge result into the current vector.
14449 (FlowBranching.Merge): New abstract method to merge a branching.
14451 2003-08-12 Martin Baulig <martin@ximian.com>
14453 * expression.cs (Indirection.CacheTemporaries): Create the
14454 LocalTemporary with the pointer type, not its element type.
14456 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14458 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14459 token was a keyword or not.
14461 Add `error' options where an IDENTIFIER was expected; Provide
14462 CheckToken and CheckIdentifierToken convenience error reporting
14465 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14467 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14468 NameSpaceEntry NameSpaceEntry.
14470 (LookupInterfaceOrClass): Avoid creating a full qualified name
14471 from namespace and name: avoid doing lookups when we know the
14472 namespace is non-existant. Use new Tree.LookupByNamespace which
14473 looks up DeclSpaces based on their namespace, name pair.
14475 * driver.cs: Provide a new `parser verbose' to display the
14476 exception thrown during parsing. This is turned off by default
14477 now, so the output of a failure from mcs is more graceful.
14479 * namespace.cs: Track all the namespaces defined in a hashtable
14482 (IsNamespace): New method
14484 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14486 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14487 we know that we need to concatenate (full typename can never be
14492 * statement.cs: Use a bitfield; Do not initialize to null things
14493 which are done by the constructor by default.
14495 * cs-parser.jay: bug fix, parameter was 4, not 3.
14497 * expression.cs: Just use the property;
14499 * statement.cs: No need for GetVariableInfo method.
14501 2003-08-08 Martin Baulig <martin@ximian.com>
14503 * flowanalysis.cs (FlowReturns): This is now nested in the
14504 `FlowBranching' class.
14505 (MyBitVector): Moved this here from statement.cs.
14506 (FlowBranching.SiblingType): New enum type.
14507 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14509 2003-08-07 Martin Baulig <martin@ximian.com>
14511 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14512 `FlowBranching' class and called `BranchingType'.
14514 2003-08-07 Martin Baulig <martin@ximian.com>
14516 * flowanalysis.cs: Moved all the control flow analysis code into
14519 2003-08-07 Martin Baulig <martin@ximian.com>
14521 * assign.cs (Assign.DoResolve): `target' must either be an
14522 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14525 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14527 * expression.cs (BinaryMethod): This kind of expression is created by the
14528 Binary class if it determines that the operator has to be handled
14531 (BinaryDelegate): This kind of expression is created if we are
14532 dealing with a + or - operator on delegates.
14534 (Binary): remove method, argumetns, and DelegateOperator: when
14535 dealing with methods,
14537 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14539 * statement.cs (Block): use bitfields for the three extra booleans
14540 we had in use. Remove unused topblock parameter.
14542 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14544 * assign.cs: Drop extra unneeded tests.
14546 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14548 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14550 * statement.cs (Foreach): Use VariableStorage instead of
14553 * codegen.cs (VariableStorage): New class used by clients that
14554 require a variable stored: locals or fields for variables that
14555 need to live across yield.
14557 Maybe provide a convenience api for EmitThis+EmitLoad?
14559 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14562 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14564 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14565 RemapParameterLValue): New methods that are used to turn a
14566 precomputed FieldInfo into an expression like this:
14570 The idea is to use this instead of making LocalVariableReference
14571 have more than one meaning.
14573 * cs-parser.jay: Add error production to BASE.
14575 * ecore.cs: Deal with TypeManager.GetField returning null, which
14576 is now a valid return value.
14578 (FieldExprNoAddress): New expression for Fields whose address can
14581 * expression.cs (LocalVariableReference): During the resolve
14582 phases, create new expressions if we are in a remapping context.
14583 Remove code that dealt with remapping here.
14585 (ParameterReference): same.
14587 (ProxyInstance): New expression, like the `This' expression, but
14588 it is born fully resolved. We know what we are doing, so remove
14589 the errors that are targeted to user-provided uses of `this'.
14591 * statement.cs (Foreach): our variable is now stored as an
14592 Expression; During resolution, follow the protocol, dont just
14593 assume it will return this.
14595 2003-08-06 Martin Baulig <martin@ximian.com>
14597 * support.cs (SeekableStreamReader.cs): New public class.
14599 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14600 SeekableStreamReader instead of the normal StreamReader.
14602 2003-08-04 Martin Baulig <martin@ximian.com>
14604 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14605 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14606 deambiguate casts and delegate invocations.
14607 (parenthesized_expression): Use the new tokens to ensure this is
14608 not a cast of method invocation.
14610 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14611 when reading a `)' and Deambiguate_CloseParens () was previously
14614 * expression.cs (ParenthesizedExpression): New class. This is
14615 just used for the CS0075 test.
14616 (Binary.DoResolve): Check for CS0075.
14618 2003-07-29 Ravi Pratap <ravi@ximian.com>
14620 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14621 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14622 reference comparison.
14624 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14625 examine the ReturnType for equality - this is necessary in the
14626 cases of implicit and explicit operators whose signature also
14627 includes the return type.
14629 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14631 * namespace.cs: Cache the result of the namespace computation,
14632 instead of computing it every time.
14634 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14636 * decl.cs: Use a global arraylist that we reuse over invocations
14637 to avoid excesive memory consumption. Reduces memory usage on an
14638 mcs compile by one meg (45 average).
14640 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14641 private, work around that.
14643 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14645 * literal.cs (IntLiteral): Define Zero and One static literals.
14647 * cs-parser.jay (integer_literal): use static literals to reduce
14648 memory usage for the most used literals (0, 1 and -1). 211kb
14649 reduced in memory usage.
14651 Replace all calls to `new ArrayList' with `new
14652 ArrayList(4)' which is a good average number for most allocations,
14653 and also requires only 16 bytes of memory for its buffer by
14656 This reduced MCS memory usage in seven megabytes for the RSS after
14659 2003-07-28 Ravi Pratap <ravi@ximian.com>
14661 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14662 handle params methods the correct way by forming only one
14663 applicable set with params and normal methods in them. Earlier we
14664 were looking at params methods only if we found no normal methods
14665 which was not the correct thing to do.
14667 (Invocation.BetterFunction): Take separate arguments indicating
14668 when candidate and the best method are params methods in their
14671 This fixes bugs #43367 and #46199.
14673 * attribute.cs: Documentation updates.
14675 (CheckAttribute): Rename to CheckAttributeTarget.
14676 (GetValidPlaces): Rename to GetValidTargets.
14678 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14679 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14683 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14685 * codegen.cs: Compute IsGeneric correctly.
14687 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14690 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14691 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14692 regressions, and I was chasing more bugs than I required.
14694 * interface.cs: Use expressions for base type names (like classes
14695 and structs have been doing for a while now), and resolve that.
14696 This patch should probably go into head as well.
14698 This makes it one less user of FindType.
14700 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14702 This compiler can not self host currently. Need to fix that.
14704 * Makefile: compile to `gmcs.exe'
14706 * driver.cs: Turn on v2 by default on gmcs.
14708 * generic.cs (ConstructedType): Does no longer take a container
14709 type argument; That will be taken care of later.
14711 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14712 Use SimpleName to resolve for now, so we can continue the work on
14713 the parser, until we get Type.GetType that understands generics.
14715 (ConstructedType.ToString): Implement
14717 (TypeArguments.Resolve): Resolve the child expressions as types.
14719 * cs-parser.jay: Rename interface_constraints to
14720 type_parameter_constraints
14722 (namespace_or_type_name): Only use constructed types for the basic
14723 construction, we will deal with identifier<...> later.
14725 (type/type_name): No longer call DecomposeQI, as
14726 namespace_or_type_name is always decoded now.
14728 2003-07-22 Ravi Pratap <ravi@ximian.com>
14730 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14731 closely: we eliminate methods in base types when we have an
14732 applicable method in a top-level type.
14734 Please see section 14.5.5.1 for an exact description of what goes
14737 This fixes bug #45127 and a host of other related to corlib compilation.
14739 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14740 array is the method corresponding to the top-level type (this is
14741 because of the changes made to icall.c) so we change this
14744 (MethodGroupExpr.Name): This too.
14746 * typemanager.cs (GetElementType): New method which does the right
14747 thing when compiling corlib.
14749 * everywhere: Make use of the above in the relevant places.
14751 2003-07-22 Martin Baulig <martin@ximian.com>
14753 * cs-parser.jay (invocation_expression): Moved
14754 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14755 `cast_expression', but create a InvocationOrCast which later
14756 resolves to either an Invocation or a Cast.
14758 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14759 method; call this before EmitStatement() to make sure that this
14760 expression can be used as a statement.
14762 * expression.cs (InvocationOrCast): New class; resolves to either
14763 an Invocation or a Cast.
14765 * statement.cs (StatementExpression): Call ResolveStatement() on
14766 the ExpressionStatement before emitting it.
14768 2003-07-21 Martin Baulig <martin@ximian.com>
14770 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
14771 `ref' and `out' attributes match; fixes #46220.
14772 (MemberAccess.ResolveMemberAccess): You can't reference a type
14773 through an expression; fixes #33180.
14774 (Indexers.GetIndexersForType): Don't return the indexers from
14775 interfaces the class implements; fixes #46502.
14777 2003-07-21 Martin Baulig <martin@ximian.com>
14779 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
14780 CS0661 checks; fixes bug #30442.
14782 2003-07-21 Martin Baulig <martin@ximian.com>
14784 * decl.cs (AdditionResult): Added `Error'.
14786 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
14788 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
14789 cs0031.cs actually work.
14791 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14793 * cs-parser.jay (namespace_name): do not use
14794 namespace_or_type_name, use qualified_identifier, because
14795 namespace_or_type_name will soon return a composed expression
14796 instead of a string.
14798 (namespace_or_type_name): Instead of returning a string, now this
14799 production returns an expression.
14801 * codegen.cs (EmitContext): Setup IsGeneric property based on
14802 whether our DeclSpace is generic, our the method is generic.
14804 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
14805 the method is generic.
14807 * cs-parser.jay (type_arguments, opt_type_argument_list,
14808 type_parameters, type_parameter_list, opt_type_parameter_list,
14809 type_parameter,, opt_type_parameter_constraints_clauses,
14810 type_parameter_constraints_clauses,
14811 type_parameter_constraint_clause, type_parameter_constraint,
14812 interface_constraints): Add new production
14814 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
14815 DeclSpace is generic or not.
14817 (DeclSpace.SetParameterInfo): New routine, used to set the
14818 parameter info for a type.
14820 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
14821 returns a GenericTypeExpr
14823 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
14824 generic, lookup the generic argument.
14826 * attribute.cs: Do not allow TypeParameterExpressions in
14829 * class.cs: Do not allow the Main method to be defined in a
14832 * expression.cs (SizeOf): Do not allow generic types to be used as
14833 arguments to sizeof.
14835 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
14836 it: whether a type is generic or not. Only works for types we are
14837 currently building for now.
14839 2003-07-20 Martin Baulig <martin@ximian.com>
14841 * namespace.cs: Fixed that bug which caused a crash when compiling
14842 the debugger's GUI.
14844 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14846 * typemanager.cs (LookupTypeReflection): Never expose types which
14847 are NotPublic, NestedPrivate, NestedAssembly, or
14848 NestedFamANDAssem. We used to return these, and later do a check
14849 that would report a meaningful error, but the problem is that we
14850 would not get the real match, if there was a name override.
14852 2003-07-18 Miguel de Icaza <miguel@ximian.com>
14854 * namespace.cs (Namespace, Name): Do not compute the namespace
14855 name dynamically, compute it in the constructor. This reduced
14856 memory usage by 1697 KB.
14858 * driver.cs: Use --pause to pause at the end.
14860 2003-07-17 Peter Williams <peter@newton.cx>
14862 * Makefile: Change the name of the test target so that it doesn't
14863 conflict with the recursive test target.
14865 2003-07-17 Miguel de Icaza <miguel@ximian.com>
14867 * expression.cs (LocalVariableReference.Emit, EmitAssign,
14868 AddressOf): Do not use EmitThis, that was wrong, use the actual
14871 2003-07-15 Miguel de Icaza <miguel@ximian.com>
14873 * class.cs (MethodData.Define): While checking if a method is an
14874 interface implementation, improve the test: If we are not public
14875 (use new test here: use the computed MethodAttributes directly,
14876 instead of the parsed modifier flags) check if the `implementing'
14877 method comes from an interface or not.
14879 * pending.cs (VerifyPendingMethods): Slightly better error
14882 * makefile: add test target that does the mcs bootstrap.
14884 2003-07-16 Ravi Pratap <ravi@ximian.com>
14886 * interface.cs (Define): Do nothing here since there are no
14887 members to populate etc. Move the attribute emission out of here
14888 since this was just totally the wrong place to put it. Attribute
14889 application happens during the 'Emit' phase, not in the 'Define'
14892 (Emit): Add this method and move the attribute emission here
14894 * rootcontext.cs (EmitCode): Call the Emit method on interface
14897 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14899 * expression.cs (OverloadResolve): Report error only if Location
14900 is not 'Null' which means that there was a probe going on.
14902 2003-07-14 Martin Baulig <martin@ximian.com>
14904 * expression.cs (ConditionalLogicalOperator): New public class to
14905 implement user defined conditional logical operators.
14906 This is section 14.11.2 in the spec and bug #40505.
14908 2003-07-14 Martin Baulig <martin@ximian.com>
14910 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
14912 2003-07-14 Martin Baulig <martin@ximian.com>
14914 * codegen.cs (EmitContext.InFixedInitializer): New public field.
14916 * ecore.cs (IVariable.VerifyFixed): New interface method.
14918 * expression.cs (Unary.ResolveOperator): When resolving the `&'
14919 operator, check whether the variable is actually fixed. Fixes bug
14920 #36055. Set a variable definitely assigned when taking its
14921 address as required by the spec.
14923 * statement.cs (LocalInfo.IsFixed): New field.
14924 (LocalInfo.MakePinned): Set `IsFixed' to true.
14926 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14928 * attribute.cs (Attribute.Resolve): While doing a Member lookup
14929 for .ctors, ensure that we only ask for members declared in the
14930 attribute type (BindingFlags.DeclaredOnly).
14934 * expression.cs (Error_WrongNumArguments): Report error 1501
14935 correctly the way CSC does.
14937 2003-07-13 Martin Baulig <martin@ximian.com>
14939 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
14940 lookup on the fully qualified name, to make things like "X.X" work
14941 where "X.X" is a fully qualified type name, but we also have a
14942 namespace "X" in the using list. Fixes #41975.
14944 2003-07-13 Martin Baulig <martin@ximian.com>
14946 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
14947 function. If we're a CompoundAssign, we need to create an embedded
14948 CompoundAssign, not an embedded Assign.
14949 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
14952 2003-07-13 Martin Baulig <martin@ximian.com>
14954 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
14955 work to fix bug #46088.
14957 2003-07-13 Ravi Pratap <ravi@ximian.com>
14959 * class.cs (Operator.Emit): Do not emit attributes here - it is
14960 taken care of by the Method class that we delegate too. This takes
14961 care of bug #45876.
14963 2003-07-10 Martin Baulig <martin@ximian.com>
14965 * expression.cs (TypeOfVoid): New class.
14966 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
14968 2003-07-10 Martin Baulig <martin@ximian.com>
14970 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
14973 2003-07-10 Martin Baulig <martin@ximian.com>
14975 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
14976 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
14978 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
14980 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
14982 2003-07-10 Martin Baulig <martin@ximian.com>
14984 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
14985 of decimal. Fixes #42850.
14987 NOTE: I also fixed the created byte blob, but this doesn't work on
14988 the MS runtime and csc never produces any byte blobs for decimal
14991 2003-07-10 Martin Baulig <martin@ximian.com>
14993 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
14994 structs; fixes #32068.
14995 (Block.AddChildVariableNames): Fixed #44302.
14997 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14999 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
15001 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15003 * attribute.cs: And this test is onger needed.
15005 2003-07-08 Martin Baulig <martin@ximian.com>
15007 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
15008 inaccessible types. Fixes #36313.
15010 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
15012 * namespace.cs (NamespaceEntry): Create implicit entries for all
15013 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
15014 implicit entries for N1.N2 and N1.
15016 2003-07-08 Martin Baulig <martin@ximian.com>
15018 Rewrote the handling of namespaces to fix a lot of the issues
15019 wrt. `using' aliases etc.
15021 * namespace.cs (Namespace): Splitted this class into a
15022 per-assembly `Namespace' and a per-file `NamespaceEntry'.
15024 * typemanager.cs (TypeManager.IsNamespace): Removed.
15025 (TypeManager.ComputeNamespaces): Only compute namespaces from
15026 loaded assemblies here, not the namespaces from the assembly we're
15027 currently compiling.
15029 2003-07-08 Martin Baulig <martin@ximian.com>
15031 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
15033 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15035 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
15038 I thought about the memory savings here, but LookupTypeReflection
15039 is used under already very constrained scenarios. Compiling
15040 corlib or mcs only exposes one hit, so it would not really reduce
15041 any memory consumption.
15043 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15045 * typemanager.cs: fixes bug #45889 by only adding public types from
15046 other assemblies to the list of known types.
15048 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15050 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
15051 on the type we resolved.
15053 2003-07-05 Martin Baulig <martin@ximian.com>
15055 * pending.cs (PendingImplementation.ParentImplements): Don't
15056 create the proxy if the parent is abstract.
15058 * class.cs (TypeContainer.DefineIndexers): Process explicit
15059 interface implementations first. Fixes #37714.
15061 2003-07-04 Miguel de Icaza <miguel@ximian.com>
15063 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
15064 defined recursively; but since we modify the input parameters
15065 (left is set to `this' temporarily), we reset this value if the
15066 left_is_explicit is false, which gives the original semantics to
15069 * literal.cs (NullPointer): new class used to represent a null
15070 literal in a pointer context.
15072 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
15073 type is a pointer, use a NullPointer object instead of a
15074 NullLiteral. Closes 43687
15076 (ExplicitConversion): Convert pointer values using
15077 the conv opcode to the proper type.
15079 * ecore.cs (New): change ValueTypeVariable property into a method,
15080 that returns whether the valuetype is suitable for being used.
15082 * expression.cs (Binary.DoNumericPromotions): Only return if we
15083 the int constant was a valid uint, and we can return both left and
15084 right as uints. If not, we continue processing, to trigger the
15085 type conversion. This fixes 39018.
15087 * statement.cs (Block.EmitMeta): During constant resolution, set
15088 the CurrentBlock property on the emitcontext, so that we resolve
15089 constants propertly.
15091 2003-07-02 Martin Baulig <martin@ximian.com>
15093 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
15094 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
15096 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
15097 than emitting it here.
15099 * statement.cs: Fixed some more flow analysis bugs.
15101 2003-07-02 Martin Baulig <martin@ximian.com>
15103 * class.cs (MethodData.Define): When implementing interface
15104 methods, set Final unless we're Virtual.
15106 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
15107 check work for interface methods.
15109 2003-07-01 Martin Baulig <martin@ximian.com>
15111 * ecore.cs (EmitContext.This): Replaced this property with a
15112 GetThis() method which takes a Location argument. This ensures
15113 that we get the correct error location for a CS0188.
15115 2003-07-01 Miguel de Icaza <miguel@ximian.com>
15117 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
15118 ImplicitStandardConversion.
15120 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
15122 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
15124 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
15127 2003-06-30 Miguel de Icaza <miguel@ximian.com>
15129 * class.cs (Constructor.Define): Turn off initlocals for unsafe
15132 (MethodData.Define): Turn off initlocals for unsafe methods.
15134 2003-06-29 Miguel de Icaza <miguel@ximian.com>
15136 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
15137 complete; Fixes #37521.
15139 * delegate.cs: Use Modifiers.TypeAttr to compute the
15140 TypeAttributes, instead of rolling our own. This makes the flags
15141 correct for the delegates.
15143 2003-06-28 Miguel de Icaza <miguel@ximian.com>
15145 * class.cs (Constructor.Define): Set the private flag for static
15146 constructors as well.
15148 * cs-parser.jay (statement_expression): Set the return value to
15149 null, to avoid a crash when we catch an error.
15151 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15153 * cs-parser.jay: Applied patch from Jackson that adds support for
15154 extern and unsafe modifiers to destructor declarations.
15156 * expression.cs: Report error 21 if the user is trying to index a
15159 * driver.cs: Add an error message, suggested by the bug report.
15161 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15162 if we do not have a ": this ()" constructor initializer. Fixes 45149
15164 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15166 * namespace.cs: Add some information to reduce FAQs.
15168 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15170 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15171 underlying enumeration types. Fixes #43915.
15173 * expression.cs: Treat ushort/short as legal values to be used in
15174 bitwise operations.
15176 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15178 * delegate.cs: transfer custom attributes for paramenters from
15179 the delegate declaration to Invoke and BeginInvoke.
15181 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15183 * attribute.cs: handle custom marshalers and emit marshal info
15186 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15188 * makefile.gnu: Added anonymous.cs to the compiler sources.
15190 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15192 * iterators.cs: Change the name of the proxy class to include two
15195 * cs-parser.jay: Update grammar to include anonymous methods.
15197 * anonymous.cs: new file.
15199 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15201 * class.cs (Field.Define): Add missing test for pointers and
15204 2003-05-27 Ravi Pratap <ravi@ximian.com>
15206 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15207 we use the stobj opcode.
15209 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15210 since it wasn't the correct fix.
15212 It still is puzzling that we are required to use stobj for IntPtr
15213 which seems to be a ValueType.
15215 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15217 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15218 during regular simple name resolution. Now, the trick is that
15219 instead of returning for processing the simplename, we do a
15220 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15221 contextual lookup type). If a match is found, return that, if
15222 not, return for further composition.
15224 This fixes long-standing 30485.
15226 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15227 using the address to initialize an object, do an Stobj instead of
15228 using the regular Stelem.
15230 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15231 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15232 Because if we are a BaseIndexerAccess that value will be true.
15235 * statement.cs (GotoCase.Resolve): Return after reporting an
15236 error, do not attempt to continue.
15238 * expression.cs (PointerArithmetic.Emit): If our operand is a
15239 long, convert our constants to match the operand before
15240 multiplying. Convert to I type before adding. Fixes 43670.
15242 2003-05-14 Ravi Pratap <ravi@ximian.com>
15244 * enum.cs (ImplicitConversionExists) : Rename to
15245 ImplicitEnumConversionExists to remove ambiguity.
15247 * ecore.cs (NullCast): New type of cast expression class which
15248 basically is very similar to EmptyCast with the difference being
15249 it still is a constant since it is used only to cast a null to
15251 (eg. (string) null)
15253 * convert.cs (ImplicitReferenceConversion): When casting a null
15254 literal, we return a NullCast.
15256 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15257 should be around anymore.
15259 The renaming (reported was slightly wrong). Corrections:
15261 ConvertImplicitStandard -> ImplicitConversionStandard
15262 ConvertExplicitStandard -> ExplicitConversionStandard
15264 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15265 before passing them in !
15267 * convert.cs (ImplicitConversionStandard): When comparing for
15268 equal expr and target types, ensure that expr is not a
15271 In general, we must not be checking (expr_type ==
15272 target_type) in the top level conversion methods
15273 (ImplicitConversion, ExplicitConversion etc). This checking is
15274 done in the methods that they delegate to.
15276 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15278 * convert.cs: Move Error_CannotConvertType,
15279 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15280 ImplicitNumericConversion, ImplicitConversionExists,
15281 ImplicitUserConversionExists, StandardConversionExists,
15282 FindMostEncompassedType, FindMostSpecificSource,
15283 FindMostSpecificTarget, ImplicitUserConversion,
15284 ExplicitUserConversion, GetConversionOperators,
15285 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15286 TryImplicitIntConversion, Error_CannotConvertImplicit,
15287 ConvertImplicitRequired, ConvertNumericExplicit,
15288 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15289 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15292 Perform the following renames:
15294 StandardConversionExists -> ImplicitStandardConversionExists
15295 ConvertImplicit -> ImplicitConversion
15296 ConvertImplicitStandard -> ImplicitStandardConversion
15297 TryImplicitIntConversion -> ImplicitIntConversion
15298 ConvertImplicitRequired -> ImplicitConversionRequired
15299 ConvertNumericExplicit -> ExplicitNumericConversion
15300 ConvertReferenceExplicit -> ExplicitReferenceConversion
15301 ConvertExplicit -> ExplicitConversion
15302 ConvertExplicitStandard -> ExplicitStandardConversion
15304 2003-05-19 Martin Baulig <martin@ximian.com>
15306 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15307 (TypeInfo): Added support for structs having structs as fields.
15309 * ecore.cs (FieldExpr): Implement IVariable.
15310 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15311 VariableInfo for the field.
15313 2003-05-18 Martin Baulig <martin@ximian.com>
15315 * expression.cs (This.DoResolve): Report a CS0027 if we're
15316 emitting a field initializer.
15318 2003-05-18 Martin Baulig <martin@ximian.com>
15320 * expression.cs (This.ResolveBase): New public function.
15321 (This.DoResolve): Check for CS0188.
15323 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15326 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15327 `instance_expression' to null if we don't have any non-static
15330 2003-05-18 Martin Baulig <martin@ximian.com>
15332 Reworked the way how local variables and parameters are handled by
15333 the flow analysis code.
15335 * statement.cs (TypeInfo, VariableMap): New public classes.
15336 (VariableInfo): New public class. This is now responsible for
15337 checking whether a variable has been assigned. It is used for
15338 parameters and local variables.
15339 (Block.EmitMeta): Take the InternalParameters as argument; compute
15340 the layout of the flow vectors here.
15341 (Block.LocalMap, Block.ParameterMap): New public properties.
15342 (FlowBranching): The .ctor doesn't get the InternalParameters
15343 anymore since Block.EmitMeta() now computes the layout of the flow
15345 (MyStructInfo): This class is now known as `StructInfo' and nested
15346 in `TypeInfo'; we don't access this directly anymore.
15348 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15349 property and removed IsAssigned(), IsFieldAssigned(),
15350 SetAssigned() and SetFieldAssigned(); we now call them on the
15351 VariableInfo so we don't need to duplicate this code everywhere.
15353 * expression.cs (ParameterReference): Added `Block block' argument
15355 (LocalVariableReference, ParameterReference, This): The new
15356 VariableInfo class is now responsible for all the definite
15359 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15360 IsParameterAssigned, SetParameterAssigned): Removed.
15362 2003-05-18 Martin Baulig <martin@ximian.com>
15364 * typemanager.cs (InitCoreTypes): Try calling
15365 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15366 the 3-args-version. Corlib now also needs our `void_type'.
15367 (GetMethod): Added overloaded version which takes an optional
15368 `bool report_errors' to allow lookups of optional methods.
15370 2003-05-12 Martin Baulig <martin@ximian.com>
15372 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15373 only used for locals and not for parameters.
15375 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15377 * support.cs (InternalParameters.ParameterType): Return the
15378 ExternalType of the parameter.
15380 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15383 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15385 * class.cs (MethodData.Define): Do not set the `newslot' on
15386 interface members, if they are also flagged as "override".
15388 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15389 better code for ++i and i++. This only works for static fields
15390 and local variables.
15392 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15393 want to pull the DeclSpace out of the builder_to_declspace instead
15394 of the TypeBuilder (like in TypeContainer.FindMembers).
15396 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15397 instead of LookupTypeContainer. Fixes the crash on .NET for
15398 looking up interface members.
15400 * const.cs: Create our own emit context during the Definition
15401 stage, so that constants are evaluated in the proper context, when
15402 a recursive definition happens.
15404 2003-05-11 Martin Baulig <martin@ximian.com>
15406 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15407 new block for a switch section.
15408 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15409 the adding/lookup in the switch block. Fixes #39828.
15411 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15413 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15414 functionality: I needed to convert the data after I had performed
15415 the add/sub operation into the operands type size.
15417 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15418 pass the type for the box operation, otherwise the resulting
15419 object would have been of type object.
15421 (BoxedCast): Add constructor to specify the type to box as.
15423 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15425 * iterators.cs: I was reusing the `count' variable inadvertently,
15426 take steps to not allow this to happen.
15428 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15430 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15431 by creating an array at the point where the params starts and
15432 putting all those arguments there, then adjusting the size of the
15435 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15437 * expression.cs (New.AddressOf): Implement interface
15438 IMemoryLocation. This is used when the `new' operator is used in
15439 the context of an invocation to a method on a value type.
15441 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15444 * namespace.cs: Also check the using aliases here.
15446 * driver.cs: Move the test for using validity after the types have
15447 been entered, so we do a single pass that also includes the using
15450 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15451 in the regular case. CreateSiblingForFinally is doing extra
15454 * attribute.cs (GetAttributeArgumentExpression): Store the result
15455 on an out value, and use the return value to indicate failure
15456 instead of using null (which is a valid return for Constant.GetValue).
15458 * statement.cs: Perform the analysis flow for the increment
15459 portion after the statement, because this will be the real flow of
15460 execution. Fixes #42385
15462 * codegen.cs (EmitContext.EmitArgument,
15463 EmitContext.EmitStoreArgument): New helper functions when the
15464 RemapToProxy flag is set.
15466 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15469 Add support for remapping parameters.
15471 * iterators.cs: Propagate parameter values; Store parameter
15472 values in the proxy classes.
15474 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15476 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15477 need a proxy reference; I do not know what I was thinking
15479 * cs-parser.jay (constructor_initializer): catch another error,
15480 and display nice message.
15482 (field_declaration): catch void field declaration
15483 to flag a better error.
15485 * class.cs (MemberBase.CheckBase): Report an error instead of a
15486 warning if a new protected member is declared in a struct.
15487 (Field.Define): catch the error of readonly/volatile.
15489 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15491 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15492 volatile variable is taken
15494 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15496 * statement.cs (Fixed.Resolve): Report an error if we are not in
15499 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15501 * typemanager.cs: reuse the code that handles type clashes for
15502 delegates and enumerations.
15504 * class.cs (Report28): Always report.
15506 * expression.cs (EncodeAsAttribute): Allow nulls here.
15508 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15510 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15511 the functionality for testing whether an expression is valid for
15512 an attribute here. Also handle the case of arrays of elements
15515 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15516 encoding a linear array into an array of objects that are suitable
15517 to be passed to an CustomAttributeBuilder.
15519 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15521 * ecore.cs: (FieldExpr): Handle field remapping here.
15523 * iteratators.cs: Pass the instance variable (if the method is an
15524 instance method) to the constructors, so we can access the field
15525 variables on the class.
15527 TODO: Test this with structs. I think the THIS variable on
15528 structs might have to be a pointer, and not a refenrece
15530 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15532 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15533 local variables to fields in a proxy class.
15535 * iterators.cs (PopulateProxy): Rename our internal fields to
15537 Create a <THIS> field if we are an instance method, so we can
15538 reference our parent container variables.
15539 (MapVariable): Called back from the EmitContext code to enter a
15540 new variable to field mapping into the proxy class (we just create
15544 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15545 for using the remapped locals to fields.
15547 I placed the code here, because that gives the same semantics to
15548 local variables, and only changes the Emit code.
15550 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15551 statements inside iterators.
15552 (VariableInfo): Add a FieldBuilder for the cases when we are
15553 remapping local variables to fields in a proxy class
15555 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15556 current_block != null.
15558 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15559 not cope with strings, as it has been moved to the
15560 TableSwitchEmit. Fixed bug in switch generation.
15562 * expression.cs (New.DoResolve): Provide more context for the user
15563 when reporting an error.
15565 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15568 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15569 check the permissions for it. Note than in a type-resolution
15570 context the check was already present in DeclSpace.ResolveType,
15571 but was missing from the MemberAccess.
15573 (ArrayCreation.CheckIndices): warn if the user has
15574 more nested levels of expressions, but there are no more
15575 dimensions specified. Avoids crash on bug 41906.
15577 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15579 * statement.cs (Block): replace Implicit bool, for a generic
15581 New flag: `Unchecked'. This is used during the EmitMeta phase
15582 (which is out-of-line with the regular Resolve/Emit process for a
15583 statement, as this is done ahead of time, but still gets a chance
15584 to call constant resolve).
15586 (Block.Flags): new enum for adding a new flag.
15588 (Block.EmitMeta): track the state of unchecked.
15590 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15591 to enable constant resolution to work there as well.
15593 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15595 * typemanager.cs (ienumerable_type): Also look up
15596 System.Collections.IEnumerable.
15598 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15600 TODO: Test more than one conditional per method.
15602 * class.cs (Indexer.Define): Report the location where the user is
15603 referencing the unsupported feature.
15605 (MethodData): Overload the use of `conditionals' to
15606 minimize the creation of needless ArrayLists. This saves roughly
15607 212kb on my machine.
15609 (Method): Implement the new IIteratorContainer interface.
15610 (Method.SetYields): Implement the method by setting the ModFlags
15611 to contain METHOD_YIELDS.
15613 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15614 which just got set to null.
15616 * iterators.cs: New file.
15618 (Yield, YieldBreak): New statements.
15620 * statement.cs (Return.Resolve): Flag an error if we are used in
15621 an iterator method.
15623 * codegen.cs (InIterator): New flag set if the code is being
15624 compiled in an iterator method.
15626 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15627 internal modifier, and we just use it to avoid adding extra
15628 fields, as this is seldom used.
15630 * cs-parser.jay: Add yield_statement (yield and yield break).
15632 * driver.cs: New flag -v2 to turn on version 2 features.
15634 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15635 hashtable when v2 is enabled.
15637 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15639 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15640 there is already a namespace defined with this name.
15642 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15643 people upgraded their corlibs.
15645 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15646 always use fully qualified types, no need to use the compiler
15649 (TypeManager.IsNamespace): Use binarysearch.
15651 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15652 AddDelegate): I did not quite use the new IsValid API properly: I
15653 have to pass the short-name and the fullname. I was passing only
15654 the basename instead of the fullname sometimes.
15656 (TypeContainer.DefineType): call NamespaceClash.
15658 * interface.cs (Interface.DefineType): use NamespaceClash before
15661 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15664 * enum.cs: (Enum.DefineType): use NamespaceClash before
15667 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15668 speed increase. First, use the negative_hits cache when we get a
15669 negative. Second, add the type with its full original name
15670 instead of the new . and + encoded name (reflection uses + to
15671 separate type from a nested type). Use LookupTypeReflection
15672 directly which bypasses the type->name hashtable (that we already
15673 know does not contain the type.
15675 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15676 location/container type.
15678 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15680 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15682 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15684 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15685 method is being referenced in the method group from a static
15686 context, and report error 120 if so.
15688 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15691 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15692 is created, we create the A namespace).
15694 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15697 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15699 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15700 invocation to ModuleBuilder.GetType with the same values will
15701 return a new type instance, so we need to cache its return
15704 * expression.cs (Binary.ResolveOperator): Only allow the compare
15705 operators on enums if they are of the same type.
15707 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15708 types of ValueType on their own case. Before we were giving them
15709 the same treatment as objects.
15711 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15712 fullname. Short name is used to compare against container name.
15713 Fullname is used to check against defined namespace names.
15715 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15716 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15718 (Method.CheckBase): Call parent.
15719 (MemberBase.CheckBase): Check for protected members on sealed
15721 (PropertyBase.CheckBase): Call parent.
15722 (Field.Define): Call parent.
15724 * report.cs: Negative error codes are now mapped to 8000 - code,
15725 so that the display is render more nicely.
15727 * typemanager.cs: Do not use try/catch, instead report a regular
15730 (GetPointerType, GetReferenceType): These methods provide
15731 mechanisms to obtain the T* and T& from a T. We had the code
15732 previously scattered around the code base, and it also used
15733 TypeManager.LookupType that would go through plenty of caches.
15734 This one goes directly to the type source.
15736 In some places we did the Type.GetType followed by
15737 ModuleBuilder.GetType, but not in others, so this unifies the
15738 processing as well.
15740 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15741 statements now that we have namespace information.
15743 * typemanager.cs (IsNamespace): New method, returns whether the
15744 string presented is a namespace or not.
15746 (ComputeNamespaces): New public entry point, computes the list of
15747 available namespaces, using the GetNamespaces API call in Mono, or
15748 the slower version in MS.NET.
15750 Now before we start the semantic analysis phase, we have a
15751 complete list of namespaces including everything that the user has
15754 Deleted old code to cache namespaces in .nsc files.
15756 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15758 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15759 class/struct location definition Location for the implicit
15760 constructor location.
15762 (Operator.Define): Use the location of the operator for the
15763 implicit Method definition.
15765 (Constructor.Emit): use the constructor location for the implicit
15766 base initializer constructor.
15768 * ecore.cs: Remove ITypeExpression. This interface is now gone,
15769 and the Expression class now contains two new methods:
15771 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
15772 isolate type lookup from the rest of the resolution process.
15774 Since we use Expressions to hold type definitions due to the way
15775 we parse the input we have historically overloaded Resolve to
15776 perform the Type lookups if a special flag is passed. Now this is
15777 eliminated and two methods take their place.
15779 The differences in the two methods between xStep and xTerminal is
15780 that xStep is involved in our current lookup system that uses
15781 SimpleNames to compose a name, while xTerminal is used just to
15782 catch the case where the simplename lookup failed.
15784 2003-04-16 Miguel de Icaza <miguel@ximian.com>
15786 * expression.cs (ResolveMemberAccess): Remove redundant code.
15787 TypeExpr expressions are always born fully resolved.
15789 * interface.cs (PopulateMethod): Do not lookup the types twice.
15790 We were doing it once during SemanticAnalysis and once during
15793 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
15794 in local variable type definitions, were being returned as a
15795 SimpleName (we decomposed everything into a string), that is
15796 because primary_expression was being used instead of a type in the
15797 grammar (reduce/reduce conflicts).
15799 The part that was wrong is that we converted the expression into a
15800 string (an oversimplification in one hand, compounded with primary
15801 expressions doing string concatenation).
15807 Would return "A.B.C[]" as a SimpleName. This stopped things like
15808 using clauses from working on this particular context. And a type
15809 was being matched directly against "A.B.C[]".
15811 We now use the correct approach, and allow for ComposedCast to be
15812 part of the unary expression. So the "A.B.C []" become a composed
15813 cast of "A.B.C" (as a nested group of MemberAccess with a
15814 SimpleName at the end) plus the rank composition "[]".
15818 2003-04-10 Miguel de Icaza <miguel@ximian.com>
15820 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
15821 for the access level checking.
15823 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
15824 `TypeContainer container', because I kept getting confused when I
15825 was debugging this code.
15827 * expression.cs (Indexers): Instead of tracking getters/setters,
15828 we now track them in parallel. We create one arraylist less, but
15829 most importantly it is possible now for the LValue code to find a
15830 matching get for a set.
15832 (IndexerAccess.DoResolveLValue): Update the code.
15833 GetIndexersForType has been modified already to extract all the
15834 indexers from a type. The code assumed it did not.
15836 Also make the code set the correct return type for the indexer.
15837 This was fixed a long time ago for properties, but was missing for
15838 indexers. It used to be void_type.
15840 (Binary.Emit): Test first for doubles instead of
15841 floats, as they are more common.
15843 (Binary.EmitBranchable): Use the .un version of the branch opcodes
15844 when dealing with floats and the <=, >= operators. This fixes bug
15847 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
15848 to load the array value by emitting a load on the foreach variable
15849 type. This was incorrect.
15851 We now emit the code to load an element using the the array
15852 variable type, and then we emit the conversion operator.
15856 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
15858 * attribute.cs: Avoid allocation of ArrayLists in the common case.
15860 2003-04-09 Miguel de Icaza <miguel@ximian.com>
15862 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
15863 test for protection before we test for signatures.
15865 (MethodSignature.ToString): implement.
15867 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
15868 to the case where we reduced into a LongConstant.
15870 * decl.cs (CheckAccessLevel): If the type is an array, we can not
15871 depend on whether the information is acurrate, because the
15872 Microsoft runtime will always claim that the array type is public,
15873 regardless of the real state.
15875 If the type is a pointer, another problem happens: the type is
15876 reported as non-public in Microsoft.
15878 In both cases we have to call CheckAccessLevel recursively with
15879 the underlying type as the argument to be tested.
15881 2003-04-08 Miguel de Icaza <miguel@ximian.com>
15883 * assign.cs (Assign.Emit): If we are dealing with a compound
15884 assignment expression, we should use the code path that stores the
15885 intermediate result in a temporary value. This fixes #40903.
15887 *expression.cs (Indirection.ToString): Provide ToString method for
15890 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
15892 * class.cs: Null out fields holding references to Block objects so
15893 they can be garbage collected.
15895 * expression.cs (OverloadResolve): Remove unused local.
15897 2003-04-07 Martin Baulig <martin@ximian.com>
15899 * codegen.cs (EmitContext.CurrentFile): New public field.
15900 (EmitContext.Mark): Use the CurrentFile to check whether the
15901 location is in the correct file.
15902 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
15904 2003-04-07 Martin Baulig <martin@ximian.com>
15906 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
15908 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
15909 location. [FIXME: The location argument which gets passed to this
15910 method is sometimes wrong!]
15912 2003-04-07 Nick Drochak <ndrochak@gol.com>
15914 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
15916 2003-04-07 Miguel de Icaza <miguel@ximian.com>
15918 * expression.cs (Indirection.EmitAssign): We were using the
15919 temporary, but returning immediately instead of continuing the
15922 2003-04-06 Martin Baulig <martin@ximian.com>
15924 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
15925 if it's a nested child, but also deriving from the outer class.
15928 * typemanager.cs (IsNestedChildOf): Make this work if it's a
15929 nested child, but also deriving from the outer class. See
15931 (FilterWithClosure): We may access private members of the outer
15932 class if we're a nested child and deriving from the outer class.
15933 (RealMemberLookup): Only set `closure_private_ok' if the
15934 `original_bf' contained BindingFlags.NonPublic.
15936 2003-04-05 Martin Baulig <martin@ximian.com>
15938 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
15939 probe if its a type parameter, and if so, flag an error.
15941 * decl.cs: Move here the SetParameterInfo code from class.cs.
15942 Handle IsGeneric here.
15944 Handle a variety of errors in the parameter info definition.
15946 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
15947 type parameters here.
15949 * cs-parser.jay (class_declaration): report errors for parameters
15952 2003-01-21 Miguel de Icaza <miguel@ximian.com>
15954 * generic.cs: New file, contains support code for generics.
15956 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
15957 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
15959 Update parser for the above removals.
15961 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
15962 now taken care of in the parser.
15964 2003-04-02 Miguel de Icaza <miguel@ximian.com>
15966 * class.cs (Event.Define): Do not allow abstract events to have
15969 2003-04-01 Miguel de Icaza <miguel@ximian.com>
15971 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
15972 block in event declarations.
15974 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
15975 value type, get its address.
15977 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
15978 leaving a class on the stack instead of a boolean value (int
15979 0/1). Change the code so we compare against null, and then the
15980 result against zero.
15982 * class.cs (TypeContainer.GetClassBases): We were checking for the
15983 parent class being sealed too late.
15985 * expression.cs (Binary.Emit): For <= and >= when dealing with
15986 floating point values, use cgt.un and clt.un instead of cgt and
15989 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
15991 * statement.cs: Apply the same optimization as MS: skip the
15992 GetEnumerator returning an IEnumerator, and use the one returning a
15993 CharEnumerator instead. This allows us to avoid the try-finally block
15996 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
15998 * cs-parser.jay: Attributes cannot be applied to
15999 namespaces. Fixes #40473
16001 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16004 (Add*): check if the name is valid using the full name for constants,
16005 fields, properties and events.
16007 2003-03-28 Miguel de Icaza <miguel@ximian.com>
16009 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
16010 char constants to be part of the enumeration.
16012 * expression.cs (Conditional.DoResolve): Add support for operator
16013 true. Implements the missing functionality from 14.12
16015 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
16016 operator true/false as required by the spec.
16018 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
16019 implicit conversion to boolean.
16021 * statement.cs (Statement.ResolveBoolean): A boolean expression is
16022 also one where the type implements `operator true'.
16024 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
16025 get an expression that will invoke operator true based on an
16028 (GetConversionOperators): Removed the hack that called op_True
16031 (Expression.ResolveBoolean): Move this from Statement.
16033 2003-03-17 Miguel de Icaza <miguel@ximian.com>
16035 * ecore.cs (FieldExpr): do not allow initialization of initonly
16036 fields on derived classes
16038 2003-03-13 Martin Baulig <martin@ximian.com>
16040 * statement.cs (Block.Emit): Call ig.BeginScope() and
16041 ig.EndScope() when compiling with debugging info; call
16042 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
16044 2003-03-08 Miguel de Icaza <miguel@ximian.com>
16046 * expression.cs (Indexers): Do not construct immediately, allow
16047 for new members to be appended as we go. Fixes 38143
16049 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16051 * expression.cs: save/restore context when resolving an unchecked
16054 2003-03-05 Miguel de Icaza <miguel@ximian.com>
16056 * cfold.cs: Catch division by zero in modulus operator during
16059 2003-03-03 Miguel de Icaza <miguel@ximian.com>
16061 * interface.cs (Interface.DefineMembers): Avoid defining members
16064 2003-02-27 Miguel de Icaza <miguel@ximian.com>
16066 * driver.cs: handle the +/- options for -noconfig
16068 * statement.cs (Unckeched.Resolve): Also track the state of
16069 unchecked in the Resolve phase.
16071 2003-02-27 Martin Baulig <martin@ximian.com>
16073 * ecore.cs (Expression.MemberLookup): Don't create a
16074 MethodGroupExpr for something which is not a method. Fixes #38291.
16076 2003-02-25 Miguel de Icaza <miguel@ximian.com>
16078 * class.cs (MemberBase.CheckParameters): Also check that the type
16079 is unmanaged if it is a pointer.
16081 * expression.cs (SizeOf.Resolve): Add location information.
16083 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
16084 a managed type is declared.
16086 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
16087 parameter modifiers as well. Fixes bug 38606
16089 * class.cs: Very sad. Am backing out the speed up changes
16090 introduced by the ArrayList -> Array in the TypeContainer, as they
16091 were not actually that much faster, and introduced a bug (no error
16092 reports on duplicated methods).
16094 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
16095 source first, this will guarantee that we have a valid expression
16096 before calling in lower levels functions that will require a
16097 resolved object. Then use this original_source in the
16098 target.ResolveLValue instead of the original source that was
16101 Another change. Use target.Resolve instead of LValueResolve.
16102 Although we are resolving for LValues, we will let the Assign code
16103 take care of that (it will be called again from Resolve). This
16104 basically allows code like this:
16106 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
16107 class Y { void A (X x) { x [0] += o; }
16109 The problem was that the indexer was trying to resolve for
16110 set_Item (idx, object o) and never finding one. The real set_Item
16111 was set_Item (idx, X). By delaying the process we get the right
16116 2003-02-23 Martin Baulig <martin@ximian.com>
16118 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
16119 while calling DoEmit ().
16121 * codegen.cs (EmitContext.Mark): Don't mark locations in other
16122 source files; if you use the #line directive inside a method, the
16123 compiler stops emitting line numbers for the debugger until it
16124 reaches the end of the method or another #line directive which
16125 restores the original file.
16127 2003-02-23 Martin Baulig <martin@ximian.com>
16129 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
16131 2003-02-23 Martin Baulig <martin@ximian.com>
16133 * statement.cs (Block.AddChildVariableNames): We need to call this
16134 recursively, not just for our immediate children.
16136 2003-02-23 Martin Baulig <martin@ximian.com>
16138 * class.cs (Event.Define): Always make the field private, like csc does.
16140 * typemanager.cs (TypeManager.RealMemberLookup): Make events
16141 actually work, fixes bug #37521.
16143 2003-02-23 Miguel de Icaza <miguel@ximian.com>
16145 * delegate.cs: When creating the various temporary "Parameters"
16146 classes, make sure that we call the ComputeAndDefineParameterTypes
16147 on those new parameters (just like we do with the formal ones), to
16148 allow them to be resolved in the context of the DeclSpace.
16150 This fixes the bug that Dick observed in Bugzilla #38530.
16152 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16154 * expression.cs (ResolveMemberAccess): When resolving a constant,
16155 do not attempt to pull a constant if the value was not able to
16156 generate a valid constant.
16158 * const.cs (LookupConstantValue): Do not report more errors than required.
16160 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16162 * expression.cs: fixes bug #38328.
16164 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16166 * class.cs: Changed all the various members that can be part of a
16167 class from being an ArrayList to be an Array of the right type.
16168 During the DefineType type_list, interface_list, delegate_list and
16169 enum_list are turned into types, interfaces, delegates and enums
16172 And during the member population, indexer_list, event_list,
16173 constant_list, field_list, instance_constructor_list, method_list,
16174 operator_list and property_list are turned into their real arrays.
16176 Although we could probably perform this operation earlier, for
16177 good error reporting we need to keep the lists and remove the
16178 lists for longer than required.
16180 This optimization was triggered by Paolo profiling the compiler
16181 speed on the output of `gen-sample-program.pl' perl script.
16183 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16184 not crash in methods like MemberLookupFailed that use this field.
16186 This problem arises when the compiler fails to resolve a type
16187 during interface type definition for example.
16189 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16191 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16192 inherit from System.Object, so we have to stop at null, not only
16193 when reaching System.Object.
16195 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16197 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16198 DeclaredOnly because the parent indexer might have had a different
16199 name, but did not loop until the top of the hierarchy was reached.
16201 The problem this one fixes is 35492: when a class implemented an
16202 indexer from an interface, we were getting the interface method
16203 (which was abstract) and we were flagging an error (can not invoke
16206 This also keeps bug 33089 functioning, and test-148 functioning.
16208 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16209 out if a method is special is to see if it is declared in a
16210 property or event, or whether it is one of the predefined operator
16211 names. This should fix correctly #36804.
16213 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16215 The goal here is to remove the dependency on EmptyCast.Peel ().
16216 Killing it completely.
16218 The problem is that currently in a number of places where
16219 constants are expected, we have to "probe" for an EmptyCast, and
16220 Peel, which is not the correct thing to do, as this will be
16221 repetitive and will likely lead to errors.
16223 The idea is to remove any EmptyCasts that are used in casts that
16224 can be reduced to constants, so we only have to cope with
16227 This bug hunt was triggered by Bug 37363 and the desire to remove
16228 the duplicate pattern where we were "peeling" emptycasts to check
16229 whether they were constants. Now constants will always be
16232 * ecore.cs: Use an enumconstant here instead of wrapping with
16235 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16236 throwing me off. By handling this we can get rid of a few hacks.
16238 * statement.cs (Switch): Removed Peel() code.
16240 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16242 * class.cs: Location information for error 508
16244 * expression.cs (New.DoResolve): Add a guard against double
16245 resolution of an expression.
16247 The New DoResolve might be called twice when initializing field
16248 expressions (see EmitFieldInitializers, the call to
16249 GetInitializerExpression will perform a resolve on the expression,
16250 and later the assign will trigger another resolution
16252 This leads to bugs (#37014)
16254 * delegate.cs: The signature for EndInvoke should contain any ref
16255 or out parameters as well. We were not doing this in the past.
16257 * class.cs (Field.Define): Do not overwrite the type definition
16258 inside the `volatile' group. Turns out that volatile enumerations
16259 were changing the type here to perform a validity test, which
16262 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16264 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16265 and structs, we do not want to load the instance variable
16267 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16268 enum_type has to be handled like an object reference (implicit
16269 conversions exists from this to object), but the regular IsClass
16270 and IsValueType tests will never return true for this one.
16272 Also we use TypeManager.IsValueType instead of type.IsValueType,
16273 just for consistency with the rest of the code (this is only
16274 needed if we ever use the construct exposed by test-180.cs inside
16275 corlib, which we dont today).
16277 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16279 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16282 2003-02-09 Martin Baulig <martin@ximian.com>
16284 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16285 (Namespace.DefineNamespaces): New static public method; this is
16286 called when we're compiling with debugging to add all namespaces
16287 to the symbol file.
16289 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16290 pass it to the Namespace's .ctor.
16292 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16293 and MethodBase arguments; pass the namespace ID to the symwriter;
16294 pass the MethodBase instead of the token to the symwriter.
16295 (SymbolWriter.DefineNamespace): New method to add a namespace to
16298 2003-02-09 Martin Baulig <martin@ximian.com>
16300 * symbolwriter.cs: New file. This is a wrapper around
16301 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16302 methods here in near future.
16304 2003-02-09 Martin Baulig <martin@ximian.com>
16306 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16307 ILGenerator.MarkSequencePoint() which are actually used by the
16310 2003-02-09 Martin Baulig <martin@ximian.com>
16312 * location.cs (SourceFile): New public sealed class. This
16313 contains the name and an index which is used in the location's token.
16314 (Location): Reserve an appropriate number of bits in the token for
16315 the source file instead of walking over that list, this gives us a
16316 really huge performance improvement when compiling with debugging.
16318 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16319 `SourceFile' argument instead of a string.
16320 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16321 but don't parse/tokenize here, we need to generate the list of all
16322 source files before we do that.
16323 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16326 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16327 instead of a string.
16329 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16332 2003-02-09 Martin Baulig <martin@ximian.com>
16334 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16335 filename on `#line default'.
16337 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16339 * statement.cs: don't clear the pinned var when the fixed statement
16340 returns from the method (fixes bug#37752).
16342 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16344 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16347 2003-02-07 Martin Baulig <martin@ximian.com>
16349 * driver.cs: Removed the `--debug-args' command line argument.
16351 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16352 automatically by the AsssemblyBuilder.
16353 (CodeGen.InitializeSymbolWriter): We don't need to call any
16354 initialization function on the symbol writer anymore. This method
16355 doesn't take any arguments.
16357 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16359 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16360 from referenced assemblies as well.
16362 2003-02-02 Martin Baulig <martin@ximian.com>
16364 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16366 2003-02-02 Martin Baulig <martin@ximian.com>
16368 * class.cs (Constructor.Emit): Open the symbol writer before
16369 emitting the constructor initializer.
16370 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16371 single-stepping through constructor initializers.
16373 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16375 * class.cs: Handle error 549: do not allow virtual methods in
16378 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16380 * decl.cs: Check access levels when resolving types
16382 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16384 * statement.cs: Add parameters and locals set in catch blocks that might
16385 return to set vector
16387 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16389 * class.cs (Operator): Set the SpecialName flags for operators.
16391 * expression.cs (Invocation.DoResolve): Only block calls to
16392 accessors and operators on SpecialName methods.
16394 (Cast.TryReduce): Handle conversions from char constants.
16397 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16399 * statement.cs: small memory and time optimization in FlowBranching.
16401 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16403 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16404 problem that the last fix but in the other sid (Set).
16406 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16407 access when there is no indexer in the hierarchy.
16409 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16411 * class.cs: Combine some if statements.
16413 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16415 * driver.cs: fixed bug #37187.
16417 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16419 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16420 any indexer, it's needed to build a list with all the indexers in the
16421 hierarchy (AllGetters), else we have problems. Fixes #35653.
16423 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16425 * class.cs (MethodData.Define): It is wrong for an interface
16426 implementation to be static in both cases: explicit and implicit.
16427 We were only handling this in one case.
16429 Improve the if situation there to not have negations.
16431 * class.cs (Field.Define): Turns out that we do not need to check
16432 the unsafe bit on field definition, only on usage. Remove the test.
16434 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16436 * driver.cs: use assembly.Location instead of Codebase (the latest
16437 patch made mcs fail when using MS assemblies).
16439 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16441 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16442 get the path to *corlib.dll.
16444 2003-01-21 Nick Drochak <ndrochak@gol.com>
16448 * typemanager.cs: Remove compiler warnings
16450 2003-01-20 Duncan Mak <duncan@ximian.com>
16452 * AssemblyInfo.cs: Bump the version number to 0.19.
16454 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16456 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16458 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16460 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16462 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16464 * cs-parser.jay: Small fix: we were not comparing the constructor
16465 name correctly. Thanks to Zoltan for the initial pointer.
16467 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16469 * cs-tokenizer.cs: Set file name when specified with #line
16471 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16473 * cs-parser.jay: Only perform the constructor checks here if we
16474 are named like the class; This will help provider a better
16475 error. The constructor path is taken when a type definition is
16476 not found, but most likely the user forgot to add the type, so
16477 report that rather than the constructor error.
16479 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16481 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16484 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16486 * cs-parser.jay: Add cleanup call.
16488 2003-01-13 Duncan Mak <duncan@ximian.com>
16490 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16491 consistent with other methods.
16493 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16495 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16497 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16499 * attribute.cs: only set GuidAttr to true when we have a
16502 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16506 * typemanager.cs: fixes to allow mcs compile corlib with the new
16507 Type.IsSubclassOf fix.
16509 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16511 * expression.cs (LocalVariableReference.DoResolve): Classify a
16512 constant as a value, not as a variable. Also, set the type for
16515 * cs-parser.jay (fixed_statement): take a type instead of a
16516 pointer_type, so we can produce a better error message later.
16518 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16521 (For.DoEmit): Make inifinite loops have a
16522 non-conditional branch back.
16524 (Fixed.DoEmit): First populate the pinned variables, then emit the
16525 statement, then clear the variables. Before I was emitting the
16526 code once for each fixed piece.
16529 2003-01-08 Martin Baulig <martin@ximian.com>
16531 * statement.cs (FlowBranching.MergeChild): A break in a
16532 SWITCH_SECTION does not leave a loop. Fixes #36155.
16534 2003-01-08 Martin Baulig <martin@ximian.com>
16536 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16537 lives in the same number space than `param_map'. Fixes #36154.
16539 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16541 * cs-parser.jay (constructor_declaration): Set the
16542 Constructor.ModFlags before probing for it. This makes the
16543 compiler report 514, 515 and 132 (the code was there, but got
16546 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16547 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16548 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16550 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16552 * enum.cs: create the enum static fields using the enum type.
16554 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16556 * class.cs: don't try to create the ParamBuilder for the return
16557 type if it's not needed (and handle it breaking for the ms runtime
16560 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16562 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16564 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16566 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16567 the command. This showed up while compiling the JANET source
16568 code, which used \r as its only newline separator.
16570 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16572 * class.cs (Method.Define): If we are an operator (because it
16573 reuses our code), then set the SpecialName and HideBySig. #36128
16575 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16577 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16578 exception, report error 120 `object reference required'.
16580 * driver.cs: Add --pause option, used during to measure the size
16581 of the process as it goes with --timestamp.
16583 * expression.cs (Invocation.DoResolve): Do not allow methods with
16584 SpecialName to be invoked.
16586 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16588 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16589 number before adding it.
16591 2002-12-21 Ravi Pratap <ravi@ximian.com>
16593 * ecore.cs (StandardImplicitConversion): When in an unsafe
16594 context, we allow conversion between void * to any other pointer
16595 type. This fixes bug #35973.
16597 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16599 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16600 is not thrown when extensionless outputs are used
16602 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16604 * rootcontext.cs: fixed compilation of corlib.
16606 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16608 * attribute.cs (Attributes.Contains): Add new method.
16610 * class.cs (MethodCore.LabelParameters): if the parameter is an
16611 `out' parameter, check that no attribute `[In]' has been passed.
16613 * enum.cs: Handle the `value__' name in an enumeration.
16615 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16617 * decl.cs: Added special case to allow overrides on "protected
16620 2002-12-18 Ravi Pratap <ravi@ximian.com>
16622 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16623 since it makes much more sense.
16625 (Attributes.ctor): Don't require a Location parameter.
16627 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16629 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16630 since we already have that information per attribute.
16632 * everywhere : make appropriate changes.
16634 * class.cs (LabelParameters): Write the code which actually
16635 applies attributes to the return type. We can't do this on the MS
16636 .NET runtime so we flag a warning in the case an exception is
16639 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16641 * const.cs: Handle implicit null conversions here too.
16643 2002-12-17 Ravi Pratap <ravi@ximian.com>
16645 * class.cs (MethodCore.LabelParameters): Remove the extra
16646 Type [] parameter since it is completely unnecessary. Instead
16647 pass in the method's attributes so that we can extract
16648 the "return" attribute.
16650 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16652 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16653 of ignoring it and letting the compile continue.
16655 * typemanager.cs (ChangeType): use an extra argument to return an
16656 error condition instead of throwing an exception.
16658 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16660 * expression.cs (Unary.TryReduce): mimic the code for the regular
16661 code path. Perform an implicit cast in the cases where we can
16662 implicitly convert to one of the integral types, and then reduce
16663 based on that constant. This fixes bug #35483.
16665 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16667 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16669 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16671 * namespace.cs: fixed bug #35489.
16673 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16675 * class.cs: Remove some dead code.
16677 * cs-parser.jay: Estimate the number of methods needed
16678 (RootContext.MethodCount);
16680 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16681 numbers instead of StringBuilders.
16683 * support.cs (PtrHashtable): Add constructor with initial size;
16684 We can now reduce reallocations of the method table.
16686 2002-12-10 Ravi Pratap <ravi@ximian.com>
16688 * attribute.cs (ApplyAttributes): Keep track of the emitted
16689 attributes on a per-target basis. This fixes bug #35413.
16691 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16693 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16694 default to the Windows 1252 encoding.
16696 (UnixParseOption): Support version, thanks to Alp for the missing
16699 * AssemblyInfo.cs: Add nice assembly information.
16701 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16704 * cs-parser.jay: Allow a trailing comma before the close bracked
16705 in the attribute_section production.
16707 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16708 address of the instance was being taken, I will take this out,
16709 because we take the address of the object immediately here.
16711 2002-12-09 Ravi Pratap <ravi@ximian.com>
16713 * typemanager.cs (AreMultipleAllowed): Take care of the most
16714 obvious case where attribute type is not in the current assembly -
16717 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16719 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16720 definitions, instead of doing that afterwards.
16722 Also we use a nice little hack, depending on the constructor, we
16723 know if we are a "composed" name or a simple name. Hence, we
16724 avoid the IndexOf test, and we avoid
16726 * codegen.cs: Add code to assist in a bug reporter to track down
16727 the source of a compiler crash.
16729 2002-12-07 Ravi Pratap <ravi@ximian.com>
16731 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16732 types have been emitted for a given element and flag an error
16733 if something which does not have AllowMultiple set is used more
16736 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16737 attribute types and their corresponding AllowMultiple properties
16739 (AreMultipleAllowed): Check the property for a given type.
16741 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16742 property in the case we have a TypeContainer.
16744 (Attributes.AddAttribute): Detect duplicates and just skip on
16745 adding them. This trivial fix catches a pretty gross error in our
16746 attribute emission - global attributes were being emitted twice!
16748 Bugzilla bug #33187 is now fixed.
16750 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16752 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16753 instead of pp_and).
16755 * expression.cs (Binary.ResolveOperator): I can only use the
16756 Concat (string, string, string) and Concat (string, string,
16757 string, string) if the child is actually a concatenation of
16760 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16762 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16763 context where we need a 2-character lookahead.
16765 * pending.cs (PendingImplementation): Rework so we can keep track
16766 of interface types all the time, and flag those which were
16767 implemented by parents as optional.
16769 2002-12-03 Miguel de Icaza <miguel@ximian.com>
16771 * expression.cs (Binary.ResolveOperator): Use
16772 String.Concat(string,string,string) or
16773 String.Concat(string,string,string,string) when possible.
16775 * typemanager: More helper methods.
16778 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
16780 * pending.cs: remove the bogus return from GetMissingInterfaces()
16781 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
16783 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16785 * namespace.cs: avoid duplicated 'using xxx' being added to
16786 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
16787 when we get more than one 'using' statement for the same namespace.
16788 Report a CS0105 warning for it.
16790 2002-11-30 Miguel de Icaza <miguel@ximian.com>
16792 * cs-tokenizer.cs (consume_identifier): use read directly, instead
16793 of calling getChar/putback, uses internal knowledge of it.
16795 (xtoken): Reorder tokenizer so most common patterns are checked
16796 first. This reduces the compilation time in another 5% (from 8.11s
16797 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
16799 The parsing time is 22% of the compilation in mcs, and from that
16800 64% is spent on the tokenization process.
16802 I tried using a binary search for keywords, but this is slower
16803 than the hashtable. Another option would be to do a couple of
16806 * Not use a StringBuilder, instead use an array of chars,
16807 with a set value. Notice that this way we could catch
16808 the 645 error without having to do it *afterwards*.
16810 * We could write a hand-parser to avoid the hashtable
16811 compares altogether.
16813 The identifier consumption process takes 37% of the tokenization
16814 time. Another 15% is spent on is_number. 56% of the time spent
16815 on is_number is spent on Int64.Parse:
16817 * We could probably choose based on the string length to
16818 use Int32.Parse or Int64.Parse and avoid all the 64-bit
16821 Another 3% is spend on wrapping `xtoken' in the `token' function.
16823 Handle 0xa0 as whitespace (#34752)
16825 2002-11-26 Miguel de Icaza <miguel@ximian.com>
16827 * typemanager.cs (IsCLRType): New routine to tell whether a type
16828 is one of the builtin types.
16830 Maybe it needs to use TypeCodes to be faster. Maybe we could use
16831 typecode in more places instead of doing pointer comparissions.
16832 We could leverage some knowledge about the way the typecodes are
16835 New code to cache namespaces in assemblies, it is currently not
16836 invoked, to be used soon.
16838 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
16840 * expression.cs (Binary.ResolveOperator): specially handle
16841 strings, and do not perform user-defined operator overloading for
16844 2002-11-24 Miguel de Icaza <miguel@ximian.com>
16846 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
16847 internalcall as it is a pretty simple operation; Avoid whenever
16848 possible to call Char.IsLetter.
16850 (consume_identifier): Cut by half the number of
16851 hashtable calls by merging the is_keyword and GetKeyword behavior.
16853 Do not short-circuit, because if we do, we
16854 report errors (ie, #if false && true would produce an invalid
16858 2002-11-24 Martin Baulig <martin@ximian.com>
16860 * expression.cs (Cast.TryReduce): If we're in checked syntax,
16861 check constant ranges and report a CS0221. Fixes #33186.
16863 2002-11-24 Martin Baulig <martin@ximian.com>
16865 * cs-parser.jay: Make this work for uninitialized variable
16866 declarations in the `for' initializer. Fixes #32416.
16868 2002-11-24 Martin Baulig <martin@ximian.com>
16870 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
16871 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
16873 2002-11-24 Martin Baulig <martin@ximian.com>
16875 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
16876 argument; if true, we also check for user-defined conversions.
16877 This is only needed if both arguments are of a user-defined type.
16878 Fixes #30443, added test-175.cs.
16879 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
16881 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
16883 2002-11-24 Martin Baulig <martin@ximian.com>
16885 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
16886 function to get the store opcode.
16887 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
16888 only emit the Ldelema if the store opcode is Stobj. You must run
16889 both test-34 and test-167 to test this. Fixes #34529.
16891 2002-11-23 Martin Baulig <martin@ximian.com>
16893 * ecore.cs (Expression.MemberLookup): Added additional
16894 `qualifier_type' argument which is used when we're being called
16895 from MemberAccess.DoResolve() and null if we're called from a
16897 (Expression.MemberLookupFailed): New method to report errors; this
16898 does the CS1540 check and reports the correct error message.
16900 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
16901 argument for the CS1540 check and redone the way how we're dealing
16902 with private members. See the comment in the source code for details.
16903 (FilterWithClosure): Reverted this back to revision 1.197; renamed
16904 `closure_start_type' to `closure_qualifier_type' and check whether
16905 it's not null. It was not this filter being broken, it was just
16906 being called with the wrong arguments.
16908 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
16909 and pass it the correct `qualifier_type'; this also does the error
16912 2002-11-22 Miguel de Icaza <miguel@ximian.com>
16914 * expression.cs (Invocation.EmitParams): If the we are dealing
16915 with a non-built-in value type, load its address as well.
16917 (ArrayCreation): Use a a pretty constant instead
16918 of the hardcoded value 2. Use 6 instead of 2 for the number of
16919 static initializers.
16921 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
16922 because they are not really value types, just glorified integers.
16924 * driver.cs: Do not append .exe, the CSC compiler does not do it.
16926 * ecore.cs: Remove redundant code for enumerations, make them use
16927 the same code path as everything else, fixes the casting issue
16928 with enumerations in Windows.Forms.
16930 * attribute.cs: Do only cast to string if it is a string, the
16931 validation happens later.
16933 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
16934 people upgrade their corlibs.
16936 * ecore.cs: Oops, enumerations were not following the entire code path
16938 2002-11-21 Miguel de Icaza <miguel@ximian.com>
16940 * typemanager.cs (FilterWithClosure): Commented out the test for
16941 1540 in typemanager.cs, as it has problems when accessing
16942 protected methods from a parent class (see test-174.cs).
16944 * attribute.cs (Attribute.ValidateGuid): new method.
16945 (Attribute.Resolve): Use above.
16947 2002-11-19 Miguel de Icaza <miguel@ximian.com>
16949 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
16951 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
16952 handling for enumerations, as we only needed the TypeContainer
16953 functionality to begin with (this is required for the fix below to
16954 work for enums that reference constants in a container class for
16957 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
16959 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
16960 a valid TypeBuilder to perform lookups on.o
16962 * class.cs (InheritableMemberSignatureCompare): Use true in the
16963 call to GetGetMethod and GetSetMethod, because we are comparing
16964 the signature, and we need to get the methods *even* if they are
16967 (PropertyBase.CheckBase): ditto.
16969 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
16970 GotoCase.Resolve): Use Peel on EmpytCasts.
16972 * ecore.cs (EmptyCast): drop child, add Peel method.
16974 2002-11-17 Martin Baulig <martin@ximian.com>
16976 * ecore.cs (EmptyCast.Child): New public property.
16978 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
16979 label resolved to an EmptyCast. Fixes #34162.
16980 (GotoCase.Resolve): Likewise.
16981 (Block.EmitMeta): Likewise.
16983 2002-11-17 Martin Baulig <martin@ximian.com>
16985 * expression.cs (Invocation.BetterConversion): Prefer int over
16986 uint; short over ushort; long over ulong for integer literals.
16987 Use ImplicitConversionExists instead of StandardConversionExists
16988 since we also need to check for user-defined implicit conversions.
16989 Fixes #34165. Added test-173.cs.
16991 2002-11-16 Martin Baulig <martin@ximian.com>
16993 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
16994 with the `true' and `false' literals. Fixes #33151.
16996 2002-11-16 Martin Baulig <martin@ximian.com>
16998 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
16999 October 22nd; don't do the cs1540 check for static members.
17001 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
17002 now using our own filter here and doing the cs1540 check again.
17004 2002-11-16 Martin Baulig <martin@ximian.com>
17006 * support.cs (InternalParameters): Don't crash if we don't have
17007 any fixed parameters. Fixes #33532.
17009 2002-11-16 Martin Baulig <martin@ximian.com>
17011 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
17012 when looking up static methods to make this work on Windows.
17015 2002-11-16 Martin Baulig <martin@ximian.com>
17017 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
17018 a setter rather than using PropertyInfo.CanWrite.
17020 2002-11-15 Nick Drochak <ndrochak@gol.com>
17022 * class.cs: Allow acces to block member by subclasses. Fixes build
17025 2002-11-14 Martin Baulig <martin@ximian.com>
17027 * class.cs (Constructor.Emit): Added the extern/block check.
17030 2002-11-14 Martin Baulig <martin@ximian.com>
17032 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
17033 iteration while looking for indexers, this is needed because the
17034 indexer may have a different name in our base classes. Fixed the
17035 error reporting (no indexers at all, not get accessor, no
17036 overloaded match). Fixes bug #33089.
17037 (IndexerAccess.DoResolveLValue): Likewise.
17039 2002-11-14 Martin Baulig <martin@ximian.com>
17041 * class.cs (PropertyBase.CheckBase): Make this work for multiple
17042 indexers. Fixes the first part of bug #33089.
17043 (MethodSignature.InheritableMemberSignatureCompare): Added support
17046 2002-11-13 Ravi Pratap <ravi@ximian.com>
17048 * attribute.cs (Attribute.Resolve): Catch the
17049 NullReferenceException and report it since it isn't supposed to
17052 2002-11-12 Miguel de Icaza <miguel@ximian.com>
17054 * expression.cs (Binary.EmitBranchable): Also handle the cases for
17055 LogicalOr and LogicalAnd that can benefit from recursively
17056 handling EmitBranchable. The code now should be nice for Paolo.
17058 2002-11-08 Miguel de Icaza <miguel@ximian.com>
17060 * typemanager.cs (LookupType): Added a negative-hit hashtable for
17061 the Type lookups, as we perform quite a number of lookups on
17062 non-Types. This can be removed once we can deterministically tell
17063 whether we have a type or a namespace in advance.
17065 But this might require special hacks from our corlib.
17069 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
17070 and double which avoids a conversion from an integer to a double.
17072 * expression.cs: tiny optimization, avoid calling IsConstant,
17073 because it effectively performs the lookup twice.
17075 2002-11-06 Miguel de Icaza <miguel@ximian.com>
17077 But a bogus return here to keep the semantics of the old code
17078 until the Mono runtime is fixed.
17080 * pending.cs (GetMissingInterfaces): New method used to remove all
17081 the interfaces that are already implemented by our parent
17082 classes from the list of pending methods.
17084 * interface.cs: Add checks for calls after ResolveTypeExpr.
17086 2002-11-05 Miguel de Icaza <miguel@ximian.com>
17088 * class.cs (Class.Emit): Report warning 67: event not used if the
17089 warning level is beyond 3.
17091 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
17092 being a NullLiteral.
17094 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
17097 * class.cs (TypeContainer.GetClassBases): Cover a missing code
17098 path that might fail if a type can not be resolved.
17100 * expression.cs (Binary.Emit): Emit unsigned versions of the
17103 * driver.cs: use error 5.
17105 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
17107 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
17109 2002-11-01 Miguel de Icaza <miguel@ximian.com>
17111 * cs-parser.jay (switch_section): A beautiful patch from Martin
17112 Baulig that fixed 33094.
17114 2002-10-31 Miguel de Icaza <miguel@ximian.com>
17116 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
17117 Check whether the base is abstract and report an error if so.
17119 * expression.cs (IndexerAccess.DoResolveLValue,
17120 IndexerAccess.DoResolve): ditto.
17122 (Invocation.DoResolve): ditto.
17124 (Invocation.FullMethodDesc): Improve the report string.
17126 * statement.cs (Block): Eliminate IsVariableDefined as it is
17127 basically just a wrapper for GetVariableInfo.
17129 * ecore.cs (SimpleName): Use new
17131 * support.cs (ReflectionParamter.ParameterType): We unwrap the
17132 type, as we return the actual parameter ref/unref state on a
17135 2002-10-30 Miguel de Icaza <miguel@ximian.com>
17137 * support.cs: Return proper flags REF/OUT fixing the previous
17140 * expression.cs: Reverted last patch, that was wrong. Is_ref is
17141 not used to mean `ref' but `ref or out' in ParameterReference
17143 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
17144 full type signature instead of calling TypeManger.CSharpName
17147 * support.cs (InternalParameters.ParameterDesc): Do not compare
17148 directly to the modflags, because REF/OUT will actually be bitsets
17151 * delegate.cs (VerifyMethod): Check also the modifiers.
17153 * cs-tokenizer.cs: Fix bug where floating point values with an
17154 exponent where a sign was missing was ignored.
17156 * driver.cs: Allow multiple assemblies to be specified in a single
17159 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17161 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17162 because identifiers after a parenthesis would end up in this kind
17163 of production, and we needed to desamiguate it for having casts
17166 (UserDefinedType *) xxx
17168 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17170 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17171 we should set on the Bindingflags.NonPublic, but not turn on
17172 private_ok. private_ok controls whether a Private member is
17173 returned (this is chekced on the filter routine), while the
17174 BindingFlags.NonPublic just controls whether private/protected
17175 will be allowed. This fixes the problem part of the problem of
17176 private properties being allowed to be used in derived classes.
17178 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17179 so we can call the children DoResolveLValue method (this will
17180 properly signal errors on lvalue assignments to base properties)
17182 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17183 getter are null, and we have a property info, we know that this
17184 happened because the lookup failed, so we report an error 122 for
17185 protection level violation.
17187 We also silently return if setter and getter are null in the
17188 resolve functions, this condition only happens if we have flagged
17189 the error before. This is the other half of the problem.
17191 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17192 not have accessibility information, that is why we were returning
17193 true in the filter function in typemanager.cs.
17195 To properly report 122 (property is inaccessible because of its
17196 protection level) correctly, we report this error in ResolveAccess
17197 by failing if both the setter and the getter are lacking (ie, the
17200 DoResolve and DoLResolve have been modified to check for both
17201 setter/getter being null and returning silently, the reason being
17202 that I did not want to put the knowledge about this error in upper
17205 int old = Report.Errors;
17206 x = new PropertyExpr (...);
17207 if (old != Report.Errors)
17212 So the property expr is returned, but it is invalid, so the error
17213 will be flagged during the resolve process.
17215 * class.cs: Remove InheritablePropertySignatureCompare from the
17216 class, as we no longer depend on the property signature to compute
17217 whether it is possible to implement a method or not.
17219 The reason is that calling PropertyInfo.GetGetMethod will return
17220 null (in .NET, in Mono it works, and we should change this), in
17221 cases where the Get Method does not exist in that particular
17226 class X { public virtual int A { get { return 1; } } }
17228 class Z : Y { public override int A { get { return 2; } } }
17230 Would fail in Z because the parent (Y) would not have the property
17231 defined. So we avoid this completely now (because the alternative
17232 fix was ugly and slow), and we now depend exclusively on the
17235 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17236 reference method, instead of using the property.
17238 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17239 routines are gone now.
17241 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17242 names, they were incorrectly named.
17244 * cs-tokenizer.cs: Return are more gentle token on failure.
17246 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17247 had an out-of-sync index variable, which caused it to remove from
17248 the list of pending methods the wrong method sometimes.
17250 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17252 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17253 CanWrite, because those refer to this particular instance of the
17254 property, and do not take into account the fact that we can
17255 override single members of a property.
17257 Constructor requires an EmitContext. The resolution process does
17258 not happen here, but we need to compute the accessors before,
17259 because the resolution does not always happen for properties.
17261 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17262 subclass, before we did not update this flag, but we did update
17265 (GetAccessors): Drop this routine, as it did not work in the
17266 presence of partially overwritten set/get methods.
17268 Notice that this broke the cs1540 detection, but that will require
17271 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17275 * driver.cs: issue a warning instead of an error if we don't support
17276 debugging for the platform. Also ignore a couple of errors that may
17277 arise when trying to write the symbols. Undo my previous patch.
17279 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17281 * driver.cs: ignore /debug switch except for Unix platforms.
17283 2002-10-23 Nick Drochak <ndrochak@gol.com>
17285 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17287 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17289 * driver.cs: Do not make mcs-debug conditional, so we do not break
17290 builds that use it.
17292 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17293 review this patch. But basically after all the children variables
17294 have been merged, the value of "Breaks" was not being set to
17295 new_breaks for Switch blocks. I think that it should be set after
17296 it has executed. Currently I set this to the value of new_breaks,
17297 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17298 conservative, but I do not understand this code very well.
17300 I did not break anything in the build, so that is good ;-)
17302 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17304 2002-10-20 Mark Crichton <crichton@gimp.org>
17306 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17308 2002-10-20 Nick Drochak <ndrochak@gol.com>
17310 * cfold.cs: Fixed compile blocker.
17312 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17314 * driver.cs: I was chekcing the key, not the file.
17316 2002-10-19 Ravi Pratap <ravi@ximian.com>
17318 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17319 message that we were generating - we just need to silently return
17322 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17324 * class.cs (Event.Define): Change my previous commit, as this
17325 breaks the debugger. This is a temporary hack, as it seems like
17326 the compiler is generating events incorrectly to begin with.
17328 * expression.cs (Binary.ResolveOperator): Added support for
17329 "U operator - (E x, E y)"
17331 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17334 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17335 init-only variables, but this path did not take into account that
17336 there might be also instance readonly variables. Correct this
17339 This fixes bug 32253
17341 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17344 * driver.cs: Change the extension for modules to `netmodule'
17346 * cs-parser.jay: Improved slightly the location tracking for
17347 the debugger symbols.
17349 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17350 modifiers that were specified instead of the hardcoded value
17351 (FamAndAssem). This was basically ignoring the static modifier,
17352 and others. Fixes 32429.
17354 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17355 fixed a bug in the process (32476)
17357 * expression.cs (ArrayAccess.EmitAssign): Patch from
17358 hwang_rob@yahoo.ca that fixes bug 31834.3
17360 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17362 * driver.cs: Make the module extension .netmodule.
17364 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17366 * driver.cs: Report an error if the resource file is not found
17367 instead of crashing.
17369 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17370 false, like Emit does.
17372 2002-10-16 Nick Drochak <ndrochak@gol.com>
17374 * typemanager.cs: Remove unused private member. Also reported mcs
17375 bug to report this as a warning like csc.
17377 2002-10-15 Martin Baulig <martin@gnome.org>
17379 * statement.cs (Statement.Emit): Made this a virtual method; emits
17380 the line number info and calls DoEmit().
17381 (Statement.DoEmit): New protected abstract method, formerly knows
17382 as Statement.Emit().
17384 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17386 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17388 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17389 have fixed a remaining problem: not every AddXXXX was adding a
17390 fully qualified name.
17392 Now everyone registers a fully qualified name in the DeclSpace as
17393 being defined instead of the partial name.
17395 Downsides: we are slower than we need to be due to the excess
17396 copies and the names being registered this way.
17398 The reason for this is that we currently depend (on the corlib
17399 bootstrap for instance) that types are fully qualified, because
17400 we dump all the types in the namespace, and we should really have
17401 types inserted into the proper namespace, so we can only store the
17402 basenames in the defined_names array.
17404 2002-10-10 Martin Baulig <martin@gnome.org>
17406 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17407 from bug #31834, see the bug report for a testcase which is
17410 2002-10-10 Martin Baulig <martin@gnome.org>
17412 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17413 flow analysis code for this.
17415 * statement.cs (Do, While, For): Tell the flow analysis code about
17417 (FlowBranching.UsageVector): Added support for infinite loops.
17418 (Block.Resolve): Moved the dead code elimination here and use flow
17421 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17423 * class.cs (Field.Define): Catch cycles on struct type
17426 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17427 fields if the fields are static. We only need to check instance
17430 * expression.cs (As.DoResolve): Test for reference type.
17432 * statement.cs (Using.ResolveExpression): Use
17433 ConvertImplicitRequired, not ConvertImplicit which reports an
17435 (Using.ResolveLocalVariableDecls): ditto.
17437 * expression.cs (Binary.ResolveOperator): Report errors in a few
17438 places where we had to.
17440 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17442 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17444 * expression.cs: Use StoreFromPtr instead of extracting the type
17445 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17447 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17448 an enumeration value to a System.Enum, but System.Enum is not a
17449 value type, but an class type, so we need to box.
17451 (Expression.ConvertExplicit): One codepath could return
17452 errors but not flag them. Fix this. Fixes #31853
17454 * parameter.cs (Resolve): Do not allow void as a parameter type.
17456 2002-10-06 Martin Baulig <martin@gnome.org>
17458 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17459 if it's a class type and not a struct. Fixes #31815.
17461 2002-10-06 Martin Baulig <martin@gnome.org>
17463 * statement.cs: Reworked the flow analysis code a bit to make it
17464 usable for dead code elimination.
17466 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17468 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17470 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17472 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17473 to fix the test 165, will investigate deeper.
17475 2002-10-04 Martin Baulig <martin@gnome.org>
17477 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17478 finally blocks actually work.
17479 (Try.Resolve): We don't need to create a sibling for `finally' if
17480 there is no finally block.
17482 2002-10-04 Martin Baulig <martin@gnome.org>
17484 * class.cs (Constructor.Define): The default accessibility for a
17485 non-default constructor is private, not public.
17487 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17489 * class.cs (Constructor): Make AllowedModifiers public, add
17492 * cs-parser.jay: Perform the modifiers test here, as the
17493 constructor for the Constructor class usually receives a zero
17494 because of the way we create it (first we create, later we
17495 customize, and we were never checking the modifiers).
17497 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17498 is a version of LookupTypeReflection that includes the type-name
17499 cache. This can be used as a fast path for functions that know
17500 the fully qualified name and are only calling into *.GetType() to
17501 obtain a composed type.
17503 This is also used by TypeManager.LookupType during its type
17506 (LookupType): We now also track the real type name, as sometimes
17507 we can get a quey for the real type name from things like
17508 ComposedCast. This fixes bug 31422.
17510 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17511 complete type fullname, it does not have to go through the type
17512 resolution system to obtain the composed version of the type (for
17513 obtaining arrays or pointers).
17515 (Conditional.Emit): Use the EmitBoolExpression to
17516 generate nicer code, as requested by Paolo.
17518 (ArrayCreation.CheckIndices): Use the patch from
17519 hwang_rob@yahoo.ca to validate the array initializers.
17521 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17523 * class.cs (ConstructorInitializer.Emit): simplify code by using
17524 Invocation.EmitCall, and at the same time, fix the bugs in calling
17525 parent constructors that took variable arguments.
17527 * ecore.cs (Expression.ConvertNumericExplicit,
17528 Expression.ImplicitNumericConversion): Remove the code that
17529 manually wrapped decimal (InternalTypeConstructor call is now gone
17532 * expression.cs (Cast.TryReduce): Also handle decimal types when
17533 trying to perform a constant fold on the type.
17535 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17537 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17538 that only turned off an error report, and did nothing else.
17540 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17542 * driver.cs: Handle and ignore /fullpaths
17544 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17546 * expression.cs (Binary.ResolveOperator): Catch the case where
17547 DoNumericPromotions returns true,
17549 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17551 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17553 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17556 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17558 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17559 conversion exists, but it is also required that the conversion be
17560 performed. This manifested in "(Type64Enum) 2".
17562 * class.cs (TypeManager.AddMethod): The fix is not to change
17563 AddEnum, because that one was using a fully qualified name (every
17564 DeclSpace derivative does), but to change the AddMethod routine
17565 that was using an un-namespaced name. This now correctly reports
17566 the duplicated name.
17568 Revert patch until I can properly fix it. The issue
17569 is that we have a shared Type space across all namespaces
17570 currently, which is wrong.
17572 Options include making the Namespace a DeclSpace, and merge
17573 current_namespace/current_container in the parser.
17575 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17577 * cs-parser.jay: Improve error reporting when we get a different
17578 kind of expression in local_variable_type and
17579 local_variable_pointer_type.
17581 Propagate this to avoid missleading errors being reported.
17583 * ecore.cs (ImplicitReferenceConversion): treat
17584 TypeManager.value_type as a target just like object_type. As
17589 Is valid, and needs to result in the int 1 being boxed before it
17590 is assigned to the value type v.
17592 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17593 to validate the enumeration name.
17595 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17596 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17597 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17599 * ecore.cs (TryImplicitIntConversion): When doing an
17600 implicit-enumeration-conversion, check if the type is 64-bits and
17601 perform a conversion before passing to EnumConstant.
17603 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17605 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17606 report ambiguous type references. Unlike the MS version, we
17607 report what the ambiguity is. Innovation at work ;-)
17609 (DeclSpace.FindType): Require a location argument to
17610 display when we display an ambiguous error.
17612 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17614 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17616 * expression.cs (EmitDynamicInitializers): Apply patch from
17617 hwang_rob@yahoo.ca that fixes the order in which we emit our
17620 2002-09-21 Martin Baulig <martin@gnome.org>
17622 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17623 delegate takes no arguments.
17625 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17627 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17630 * expression.cs: Extract the underlying type.
17632 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17634 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17636 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17638 * class.cs (TypeContainer.DefineType): We can not use the nice
17639 PackingSize with the size set to 1 DefineType method, because it
17640 will not allow us to define the interfaces that the struct
17643 This completes the fixing of bug 27287
17645 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17646 means also structs. This fixes part of the problem.
17647 (Expresion.ImplicitReferenceConversionExists): ditto.
17649 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17650 error if there were no errors reported during the type lookup
17651 process, to avoid duplicates or redundant errors. Without this
17652 you would get an ambiguous errors plus a type not found. We have
17653 beaten the user enough with the first error.
17655 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17658 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17659 during the resolution process, stop the lookup, this avoids
17660 repeated error reports (same error twice).
17662 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17664 * typemanager.cs (LookupType): Redo the type lookup code to match
17665 the needs of System.Reflection.
17667 The issue is that System.Reflection requires references to nested
17668 types to begin with a "+" sign instead of a dot. So toplevel
17669 types look like: "NameSpace.TopLevelClass", and nested ones look
17670 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17673 2002-09-19 Martin Baulig <martin@gnome.org>
17675 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17676 says that a method always returns or always throws an exception,
17677 don't report the CS0161.
17679 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17680 set `Returns = new_returns'.
17682 2002-09-19 Martin Baulig <martin@gnome.org>
17684 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17685 to an enum constant, check for a CS0176.
17687 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17689 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17690 for operators that must be in pairs and report errors.
17692 * ecore.cs (SimpleName.DoResolveType): During the initial type
17693 resolution process, when we define types recursively, we must
17694 check first for types in our current scope before we perform
17695 lookups in the enclosing scopes.
17697 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17699 (Invocation.VerifyArgumentsCompat): Call
17700 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17701 I thought we were supposed to always call this, but there are a
17702 few places in the code where we dont do it.
17704 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17706 * driver.cs: Add support in -linkres and -resource to specify the
17707 name of the identifier.
17709 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17711 * ecore.cs (StandardConversionExists): Sync with the conversion
17712 code: allow anything-* to void* conversions.
17714 (FindMostSpecificSource): Use an Expression argument
17715 instead of a Type, because we might be handed over a Literal which
17716 gets a few more implicit conversions that plain types do not. So
17717 this information was being lost.
17719 Also, we drop the temporary type-holder expression when not
17722 2002-09-17 Martin Baulig <martin@gnome.org>
17724 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17725 this is an explicit interface implementation.
17727 2002-09-17 Martin Baulig <martin@gnome.org>
17729 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17730 different `IndexerName' attributes.
17732 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17733 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17734 virtual CommonResolve().
17736 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17738 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17739 and convert that to the UnderlyingType.
17741 * statement.cs (Foreach.Resolve): Indexers are just like variables
17742 or PropertyAccesses.
17744 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17745 inside quoted strings, we were not doing this before.
17747 2002-09-16 Martin Baulig <martin@gnome.org>
17749 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17750 resolve it. This is needed for the definite assignment check of the
17751 instance expression, fixes bug #29846.
17752 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17754 2002-09-16 Nick Drochak <ndrochak@gol.com>
17756 * parameter.cs: Fix compile error. Cannot reference static member
17757 from an instance object. Is this an mcs bug?
17759 2002-09-14 Martin Baulig <martin@gnome.org>
17761 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17762 multiple times. Fixes bug #30295, added test-166.cs.
17764 2002-09-14 Martin Baulig <martin@gnome.org>
17766 * statement.cs (Block.Emit): Don't emit unreachable code.
17767 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
17768 `break' statements.
17769 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
17771 2002-09-14 Martin Baulig <martin@gnome.org>
17773 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
17776 2002-09-14 Martin Baulig <martin@gnome.org>
17778 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
17779 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
17780 be false on the ms runtime.
17782 2002-09-13 Martin Baulig <martin@gnome.org>
17784 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
17785 the CS0038 error message.
17787 2002-09-12 Miguel de Icaza <miguel@ximian.com>
17789 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
17790 constant inside, return it.
17792 2002-09-12 Martin Baulig <martin@gnome.org>
17794 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
17795 implicit conversion can be done between enum types.
17797 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
17798 check whether an implicit conversion to the current enum's UnderlyingType
17799 exists and report an error if not.
17801 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
17802 without debugging support.
17804 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
17805 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
17807 2002-09-12 Martin Baulig <martin@gnome.org>
17809 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
17811 * ecore.cs (IMemberExpr.DeclaringType): New property.
17812 (SimpleName.SimpleNameResolve): Check whether we're accessing a
17813 nonstatic member of an outer type (CS0038).
17815 2002-09-11 Miguel de Icaza <miguel@ximian.com>
17817 * driver.cs: Activate the using-error detector at warning level
17818 4 (at least for MS-compatible APIs).
17820 * namespace.cs (VerifyUsing): Small buglett fix.
17822 * pending.cs (PendingImplementation): pass the container pointer.
17824 * interface.cs (GetMethods): Allow for recursive definition. Long
17825 term, I would like to move every type to support recursive
17826 definitions, not the current ordering mechanism that we have right
17829 The situation is this: Attributes are handled before interfaces,
17830 so we can apply attributes to interfaces. But some attributes
17831 implement interfaces, we will now handle the simple cases
17832 (recursive definitions will just get an error).
17834 * parameter.cs: Only invalidate types at the end if we fail to
17837 2002-09-09 Martin Baulig <martin@gnome.org>
17839 * ecore.cs (PropertyExpr.Emit): Also check for
17840 TypeManager.system_int_array_get_length so this'll also work when
17841 compiling corlib. Fixes #30003.
17843 2002-09-09 Martin Baulig <martin@gnome.org>
17845 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
17846 and throw an exception if we can't get the type's size. Fixed #30040,
17849 2002-09-09 Martin Baulig <martin@gnome.org>
17851 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
17853 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
17854 context. Fixes bug #30027.
17856 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
17857 virtual functions. Fixes bug #30043, added test-164.cs.
17859 2002-09-08 Ravi Pratap <ravi@ximian.com>
17861 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
17863 2002-09-08 Nick Drochak <ndrochak@gol.com>
17865 * driver.cs: Use an object to get the windows codepage since it's not a
17868 2002-09-08 Miguel de Icaza <miguel@ximian.com>
17870 * statement.cs (For.Emit): for infinite loops (test == null)
17871 return whether there is a break inside, not always "true".
17873 * namespace.cs (UsingEntry): New struct to hold the name of the
17874 using definition, the location where it is defined, and whether it
17875 has been used in a successful type lookup.
17877 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
17882 2002-09-06 Ravi Pratap <ravi@ximian.com>
17884 * attribute.cs : Fix incorrect code which relied on catching
17885 a NullReferenceException to detect a null being passed in
17886 where an object was expected.
17888 2002-09-06 Miguel de Icaza <miguel@ximian.com>
17890 * statement.cs (Try): flag the catch variable as assigned
17892 * expression.cs (Cast): Simplified by using ResolveType instead of
17893 manually resolving.
17895 * statement.cs (Catch): Fix bug by using ResolveType.
17897 2002-09-06 Ravi Pratap <ravi@ximian.com>
17899 * expression.cs (BetterConversion): Special case for when we have
17900 a NullLiteral as the argument and we have to choose between string
17901 and object types - we choose string the way csc does.
17903 * attribute.cs (Attribute.Resolve): Catch the
17904 NullReferenceException and report error #182 since the Mono
17905 runtime no more has the bug and having this exception raised means
17906 we tried to select a constructor which takes an object and is
17909 2002-09-05 Ravi Pratap <ravi@ximian.com>
17911 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
17912 message (1502, 1503) when we can't locate a method after overload
17913 resolution. This is much more informative and closes the bug
17916 * interface.cs (PopulateMethod): Return if there are no argument
17917 types. Fixes a NullReferenceException bug.
17919 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
17920 expressions too. Previously we were checking only in one place for
17921 positional arguments leaving out named arguments.
17923 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
17924 type to the enum type is not allowed. Remove code corresponding to
17927 (ConvertNumericExplicit): Allow explicit conversions from
17928 the underlying type to enum type. This precisely follows the spec
17929 and closes a bug filed by Gonzalo.
17931 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17934 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
17936 2002-09-03 Miguel de Icaza <miguel@ximian.com>
17938 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
17939 it was important that we stored the right value after the
17940 reduction in `converted'.
17942 2002-09-04 Martin Baulig <martin@gnome.org>
17944 * location.cs (Location.SymbolDocument): Use full pathnames for the
17947 2002-08-30 Miguel de Icaza <miguel@ximian.com>
17949 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
17950 of the expression resolve mechanism, because that will catch the
17951 SimpleName error failures.
17953 (Conditional): If we can not resolve the
17954 expression, return, do not crash.
17956 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17959 (location): display token name instead of its number.
17961 2002-08-28 Martin Baulig <martin@gnome.org>
17963 * expression.cs (Binary.ResolveOperator): Don't silently return
17964 but return an error if an operator cannot be applied between two
17967 2002-08-28 Martin Baulig <martin@gnome.org>
17969 * class.cs (Constructor.Define): Set the permission attributes
17970 correctly instead of making all constructors public.
17972 2002-08-28 Martin Baulig <martin@gnome.org>
17974 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
17975 for private members before reporting a CS0103; if we find anything,
17978 2002-08-28 Martin Baulig <martin@gnome.org>
17980 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
17981 to check whether `closure_start_type == closure_invocation_type',
17982 we also need to check whether `m.DeclaringType == closure_invocation_type'
17983 before bypassing the permission checks. We might be accessing
17984 protected/private members from the base class.
17985 (TypeManager.RealMemberLookup): Only set private_ok if private
17986 members were requested via BindingFlags.NonPublic.
17988 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
17990 * expression.cs (MemberAccess.ResolveMemberAccess): Set
17991 MethodGroupExpr.IsExplicitImpl if appropriate.
17992 (Invocation.DoResolve): Don't report the CS0120 for explicit
17993 interface implementations.
17995 2002-08-27 Martin Baulig <martin@gnome.org>
17997 * expression.cs (Invocation.DoResolve): If this is a static
17998 method and we don't have an InstanceExpression, we must report
18001 2002-08-25 Martin Baulig <martin@gnome.org>
18003 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
18004 `==' between a valuetype and an object.
18006 2002-08-25 Miguel de Icaza <miguel@ximian.com>
18008 * ecore.cs (TypeExpr): Provide a ToString method.
18010 2002-08-24 Martin Baulig <martin@gnome.org>
18012 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
18013 now called proggie.dbg and it's a binary file.
18015 2002-08-23 Martin Baulig <martin@gnome.org>
18017 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
18019 2002-08-23 Martin Baulig <martin@gnome.org>
18021 * struct.cs (MyStructInfo.ctor): Make this work with empty
18022 structs; it's not allowed to use foreach() on null.
18024 2002-08-23 Martin Baulig <martin@gnome.org>
18026 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
18027 writer the full pathname of the generated assembly.
18029 2002-08-23 Martin Baulig <martin@gnome.org>
18031 * statements.cs (FlowBranching.UsageVector.MergeChildren):
18032 A `finally' block never returns or breaks; improved handling of
18035 2002-08-23 Martin Baulig <martin@gnome.org>
18037 * statement.cs (Throw.Resolve): Allow `throw null'.
18039 2002-08-23 Martin Baulig <martin@gnome.org>
18041 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
18042 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
18043 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
18044 MemberLookup would return a wrong event if this is an explicit
18045 interface implementation and the class has an event with the same
18048 2002-08-23 Martin Baulig <martin@gnome.org>
18050 * statement.cs (Block.AddChildVariableNames): New public method.
18051 (Block.AddChildVariableName): Likewise.
18052 (Block.IsVariableNameUsedInChildBlock): Likewise.
18053 (Block.AddVariable): Check whether a variable name has already
18054 been used in a child block.
18056 * cs-parser.jay (declare_local_variables): Mark all variable names
18057 from the current block as being used in a child block in the
18060 2002-08-23 Martin Baulig <martin@gnome.org>
18062 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
18063 find the symbol writer.
18065 * driver.cs: csc also allows the arguments to /define being
18066 separated by commas, not only by semicolons.
18068 2002-08-23 Martin Baulig <martin@gnome.org>
18070 * interface.cs (Interface.GetMembers): Added static check for events.
18072 2002-08-15 Martin Baulig <martin@gnome.org>
18074 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
18075 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
18077 * ecore.cs (Expression.MemberLookup): Added documentation and explained
18078 why the MethodData.EmitDestructor() change was necessary.
18080 2002-08-20 Martin Baulig <martin@gnome.org>
18082 * class.cs (TypeContainer.FindMembers): Added static check for events.
18084 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
18086 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
18087 use Type.GetEvents(), not Type.FindMembers().
18089 2002-08-20 Martin Baulig <martin@gnome.org>
18091 * decl.cs (MemberCache): Added a special method cache which will
18092 be used for method-only searched. This ensures that a method
18093 search will return a MethodInfo with the correct ReflectedType for
18096 2002-08-20 Martin Baulig <martin@gnome.org>
18098 * decl.cs (DeclSpace.FindMembers): Made this public.
18100 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18102 * delegate.cs: fixed build on windows.
18103 [FIXME: Filed as bug #29150: MCS must report these errors.]
18105 2002-08-19 Ravi Pratap <ravi@ximian.com>
18107 * ecore.cs (StandardConversionExists): Return a false
18108 if we are trying to convert the void type to anything else
18109 since that is not allowed.
18111 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
18112 we flag error 70 in the event an event is trying to be accessed
18113 directly from outside the declaring type.
18115 2002-08-20 Martin Baulig <martin@gnome.org>
18117 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
18118 MemberCache from typemanager.cs to decl.cs.
18120 2002-08-19 Martin Baulig <martin@gnome.org>
18122 * class.cs (TypeContainer): Implement IMemberContainer.
18123 (TypeContainer.DefineMembers): Create the MemberCache.
18124 (TypeContainer.FindMembers): Do better BindingFlags checking; only
18125 return public members if BindingFlags.Public was given, check
18126 whether members are static.
18128 2002-08-16 Martin Baulig <martin@gnome.org>
18130 * decl.cs (DeclSpace.Define): Splitted this in Define and
18131 DefineMembers. DefineMembers is called first and initializes the
18134 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
18135 DefineMembers() on all our DeclSpaces.
18137 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
18138 but call DefineMembers() on all nested interfaces. We call their
18139 Define() in our new Define() function.
18141 * interface.cs (Interface): Implement IMemberContainer.
18142 (Interface.Define): Moved all code except the attribute stuf to
18144 (Interface.DefineMembers): Initialize the member cache.
18146 * typemanager.cs (IMemberFinder): Removed this interface, we don't
18147 need this anymore since we can use MemberCache.FindMembers directly.
18149 2002-08-19 Martin Baulig <martin@gnome.org>
18151 * typemanager.cs (MemberCache): When creating the cache for an
18152 interface type, add all inherited members.
18153 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18154 to `out bool used_cache' and documented it.
18155 (TypeManager.MemberLookup): If we already used the cache in the first
18156 iteration, we don't need to do the interfaces check.
18158 2002-08-19 Martin Baulig <martin@gnome.org>
18160 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18161 here from IMemberFinder and don't implement this interface anymore.
18162 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18164 * typemanager.cs (IMemberFinder): This interface is now only used by
18165 classes which actually support the member cache.
18166 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18167 since we only put DeclSpaces into this Hashtable.
18168 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18169 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18171 2002-08-16 Martin Baulig <martin@gnome.org>
18173 * typemanager.cs (ICachingMemberFinder): Removed.
18174 (IMemberFinder.MemberCache): New property.
18175 (TypeManager.FindMembers): Merged this with RealFindMembers().
18176 This function will never be called from TypeManager.MemberLookup()
18177 so we can't use the cache here, just the IMemberFinder.
18178 (TypeManager.MemberLookup_FindMembers): Check whether the
18179 IMemberFinder has a MemberCache and call the cache's FindMembers
18181 (MemberCache): Rewrote larger parts of this yet another time and
18182 cleaned it up a bit.
18184 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18186 * driver.cs (LoadArgs): Support quoting.
18188 (Usage): Show the CSC-like command line arguments.
18190 Improved a few error messages.
18192 2002-08-15 Martin Baulig <martin@gnome.org>
18194 * typemanager.cs (IMemberContainer.Type): New property.
18195 (IMemberContainer.IsInterface): New property.
18197 The following changes are conditional to BROKEN_RUNTIME, which is
18198 defined at the top of the file.
18200 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18201 class'es members, but add all members from TypeHandle.ObjectType
18202 if we're an interface.
18203 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18204 is the current type.
18205 (MemberCache.CacheEntry.Container): Removed this field.
18206 (TypeHandle.GetMembers): Include inherited members.
18208 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18210 * typemanager.cs: fixed compilation and added a comment on a field that
18213 2002-08-15 Martin Baulig <martin@gnome.org>
18215 * class.cs (ConstructorInitializer.Resolve): In the
18216 Expression.MemberLookup call, use the queried_type as
18219 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18220 declared' attribute, it's always true.
18221 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18222 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18223 temporary wrapper for FindMembers which tells MemberLookup whether
18224 members from the base classes are included in the return value.
18225 This will go away soon.
18226 (TypeManager.MemberLookup): Use this temporary hack here; once the
18227 new MemberCache is completed, we don't need to do the DeclaredOnly
18228 looping here anymore since the MemberCache will take care of this.
18229 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18230 (MemberCache): When creating the MemberCache for a class, get
18231 members from the current class and all its base classes.
18232 (MemberCache.CacheEntry.Container): New field. This is a
18233 temporary hack until the Mono runtime is fixed to distinguish
18234 between ReflectedType and DeclaringType. It allows us to use MCS
18235 with both the MS runtime and the unfixed Mono runtime without
18236 problems and without accecting performance.
18237 (MemberCache.SearchMembers): The DeclaredOnly looping from
18238 TypeManager.MemberLookup is now done here.
18240 2002-08-14 Martin Baulig <martin@gnome.org>
18242 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18243 Type.GetFields on dynamic types but get the fields from the
18244 corresponding TypeContainer.
18245 (MyStructInfo.GetStructInfo): Added check for enum types.
18247 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18248 (MemberList.SyncRoot): Implemented.
18249 (TypeManager.FilterWithClosure): No need to check permissions if
18250 closure_start_type == closure_invocation_type, don't crash if
18251 closure_invocation_type is null.
18253 2002-08-13 Martin Baulig <martin@gnome.org>
18255 Rewrote TypeContainer.FindMembers to use a member cache. This
18256 gives us a speed increase of about 35% for the self-hosting MCS
18257 build and of about 15-20% for the class libs (both on GNU/Linux).
18259 * report.cs (Timer): New class to get enhanced profiling. This
18260 whole class is "TIMER" conditional since it remarkably slows down
18263 * class.cs (MemberList): New class. This is an IList wrapper
18264 which we're now using instead of passing MemberInfo[]'s around to
18265 avoid copying this array unnecessarily.
18266 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18267 (ICachingMemberFinder, IMemberContainer): New interface.
18268 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18269 has already been checked, otherwise use it for the name comparision.
18270 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18271 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18272 if possible. Returns a MemberList, not a MemberInfo [].
18273 (TypeHandle): New class, implements IMemberContainer. We create
18274 one instance of this class per type, it contains a MemberCache
18275 which is used to do the member lookups.
18276 (MemberCache): New class. Each instance of this class contains
18277 all members of a type and a name-based hash table.
18278 (MemberCache.FindMembers): This is our new member lookup
18279 function. First, it looks up all members of the requested name in
18280 the hash table. Then, it walks this list and sorts out all
18281 applicable members and returns them.
18283 2002-08-13 Martin Baulig <martin@gnome.org>
18285 In addition to a nice code cleanup, this gives us a performance
18286 increase of about 1.4% on GNU/Linux - not much, but it's already
18287 half a second for the self-hosting MCS compilation.
18289 * typemanager.cs (IMemberFinder): New interface. It is used by
18290 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18291 Enum, Delegate or Interface.
18292 (TypeManager.finder_to_member_finder): New PtrHashtable.
18293 (TypeManager.finder_to_container): Removed.
18294 (TypeManager.finder_to_delegate): Removed.
18295 (TypeManager.finder_to_interface): Removed.
18296 (TypeManager.finder_to_enum): Removed.
18298 * interface.cs (Interface): Implement IMemberFinder.
18300 * delegate.cs (Delegate): Implement IMemberFinder.
18302 * enum.cs (Enum): Implement IMemberFinder.
18304 * class.cs (TypeContainer): Implement IMemberFinder.
18306 2002-08-12 Martin Baulig <martin@gnome.org>
18308 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18310 2002-08-12 Martin Baulig <martin@gnome.org>
18312 * ecore.cs (ITypeExpression): New interface for expressions which
18314 (TypeExpression): Renamed to TypeLookupExpression.
18315 (Expression.DoResolve): If we're doing a types-only lookup, the
18316 expression must implement the ITypeExpression interface and we
18317 call DoResolveType() on it.
18318 (SimpleName): Implement the new ITypeExpression interface.
18319 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18320 hack, the situation that we're only looking up types can't happen
18321 anymore when this method is called. Moved the type lookup code to
18322 DoResolveType() and call it.
18323 (SimpleName.DoResolveType): This ITypeExpression interface method
18324 is now doing the types-only lookup.
18325 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18326 (ResolveFlags): Added MaskExprClass.
18328 * expression.cs (MemberAccess): Implement the ITypeExpression
18330 (MemberAccess.DoResolve): Added support for a types-only lookup
18331 when we're called via ITypeExpression.DoResolveType().
18332 (ComposedCast): Implement the ITypeExpression interface.
18334 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18335 Expression.Resolve() with ResolveFlags.Type instead.
18337 2002-08-12 Martin Baulig <martin@gnome.org>
18339 * interface.cs (Interface.Define): Apply attributes.
18341 * attribute.cs (Attribute.ApplyAttributes): Added support for
18342 interface attributes.
18344 2002-08-11 Martin Baulig <martin@gnome.org>
18346 * statement.cs (Block.Emit): Only check the "this" variable if we
18347 do not always throw an exception.
18349 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18350 whether the property has a set accessor.
18352 2002-08-11 Martin Baulig <martin@gnome.org>
18354 Added control flow analysis support for structs.
18356 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18357 with control flow analysis turned off.
18358 (IVariable): New interface.
18359 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18360 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18361 (FieldExpr.DoResolve): Resolve the instance expression with flow
18362 analysis turned off and do the definite assignment check after the
18363 resolving when we know what the expression will resolve to.
18365 * expression.cs (LocalVariableReference, ParameterReference):
18366 Implement the new IVariable interface, only call the flow analysis
18367 code if ec.DoFlowAnalysis is true.
18368 (This): Added constructor which takes a Block argument. Implement
18369 the new IVariable interface.
18370 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18371 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18372 This does the definite assignment checks for struct members.
18374 * class.cs (Constructor.Emit): If this is a non-static `struct'
18375 constructor which doesn't have any initializer, call
18376 Block.AddThisVariable() to tell the flow analysis code that all
18377 struct elements must be initialized before control returns from
18380 * statement.cs (MyStructInfo): New public class.
18381 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18382 argument to this indexer. If non-zero, check an individual struct
18383 member, not the whole struct.
18384 (FlowBranching.CheckOutParameters): Check struct members.
18385 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18386 overloaded versions of these methods which take an additional
18387 `int field_idx' argument to check struct members.
18388 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18389 overloaded versions of these methods which take an additional
18390 `string field_name' argument to check struct member.s
18391 (VariableInfo): Implement the IVariable interface.
18392 (VariableInfo.StructInfo): New public property. Returns the
18393 MyStructInfo instance of the variable if it's a struct or null.
18394 (Block.AddThisVariable): New public method. This is called from
18395 Constructor.Emit() for non-static `struct' constructor which do
18396 not have any initializer. It creates a special variable for the
18397 "this" instance variable which will be checked by the flow
18398 analysis code to ensure that all of the struct's fields are
18399 initialized before control returns from the constructor.
18400 (UsageVector): Added support for struct members. If a
18401 variable/parameter is a struct with N members, we reserve a slot
18402 in the usage vector for each member. A struct is considered fully
18403 initialized if either the struct itself (slot 0) or all its
18404 members are initialized.
18406 2002-08-08 Martin Baulig <martin@gnome.org>
18408 * driver.cs (Driver.MainDriver): Only report an error CS5001
18409 if there were no compilation errors.
18411 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18412 `UnsafeContext' property to determine whether the parent is in
18413 unsafe context rather than checking the parent's ModFlags:
18414 classes nested in an unsafe class are unsafe as well.
18416 2002-08-08 Martin Baulig <martin@gnome.org>
18418 * statement.cs (UsageVector.MergeChildren): Distinguish between
18419 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18420 we return. Added test17() and test18() to test-154.cs.
18422 2002-08-08 Martin Baulig <martin@gnome.org>
18424 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18425 Family access, make sure the invoking type isn't a subclass of the
18426 queried type (that'd be a CS1540).
18428 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18429 this method which takes an additional `Type invocation_type'.
18431 * expression.cs (BaseAccess.DoResolve): Use the base type as
18432 invocation and query type.
18433 (MemberAccess.DoResolve): If the lookup failed and we're about to
18434 report a CS0122, try a lookup with the ec.ContainerType - if this
18435 succeeds, we must report a CS1540.
18437 2002-08-08 Martin Baulig <martin@gnome.org>
18439 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18440 (MethodGroupExpr): Implement the IMemberExpr interface.
18442 * expression (MemberAccess.ResolveMemberAccess): No need to have
18443 any special code for MethodGroupExprs anymore, they're now
18446 2002-08-08 Martin Baulig <martin@gnome.org>
18448 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18449 Family, FamANDAssem and FamORAssem permissions.
18450 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18452 2002-08-08 Martin Baulig <martin@gnome.org>
18454 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18455 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18458 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18460 * driver.cs: implemented /resource option to embed managed resources.
18462 2002-08-07 Martin Baulig <martin@gnome.org>
18464 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18465 (FieldBase.HasFieldInitializer): New public property.
18466 (FieldBase.GetInitializerExpression): New public method. Resolves and
18467 returns the field initializer and makes sure it is only resolved once.
18468 (TypeContainer.EmitFieldInitializers): Call
18469 FieldBase.GetInitializerExpression to get the initializer, this ensures
18470 that it isn't resolved multiple times.
18472 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18473 the resolving process (SimpleName/MemberLookup) that we're currently
18474 emitting a field initializer (which must not access any instance members,
18475 this is an error CS0236).
18477 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18478 argument, if the `IsFieldInitializer' flag is set, we must report and
18479 error CS0236 and not an error CS0120.
18481 2002-08-07 Martin Baulig <martin@gnome.org>
18483 * ecore.cs (IMemberExpr): New public interface.
18484 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18485 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18486 if the expression is an IMemberExpr.
18488 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18489 to be null, implicitly default to `this' if we're non-static in
18490 this case. Simplified the code a lot by using the new IMemberExpr
18491 interface. Also fixed bug #28176 here.
18493 2002-08-06 Martin Baulig <martin@gnome.org>
18495 * cs-parser.jay (SimpleLookup): Removed. We need to create
18496 ParameterReferences during semantic analysis so that we can do a
18497 type-only search when resolving Cast, TypeOf and SizeOf.
18498 (block): Pass the `current_local_parameters' to the Block's
18501 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18502 argument to the constructor.
18503 (ConstructorInitializer.Resolve): Create a temporary implicit
18504 block with the parameters.
18506 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18507 references here if we aren't doing a type-only search.
18509 * statement.cs (Block): Added constructor which takes a
18510 `Parameters parameters' argument.
18511 (Block.Parameters): New public property.
18513 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18514 to `Parameters' and made it public readonly.
18516 2002-08-06 Martin Baulig <martin@gnome.org>
18518 * ecore.cs (Expression.Warning): Made this public as well.
18520 * report.cs (Report.Debug): Print the contents of collections.
18522 2002-08-06 Martin Baulig <martin@gnome.org>
18524 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18525 used to tell Resolve() which kinds of expressions it may return.
18526 (Expression.Resolve): Added overloaded version of this method which
18527 takes a `ResolveFlags flags' argument. This can be used to tell
18528 Resolve() which kinds of expressions it may return. Reports a
18530 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18531 ResolveFlags.SimpleName.
18532 (Expression.Error118): Added overloaded version of this method which
18533 takes a `ResolveFlags flags' argument. It uses the flags to determine
18534 which kinds of expressions are allowed.
18536 * expression.cs (Argument.ResolveMethodGroup): New public method.
18537 Resolves an argument, but allows a MethodGroup to be returned.
18538 This is used when invoking a delegate.
18540 * TODO: Updated a bit.
18542 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18544 Fixed compilation with csc.
18546 * ecore.cs: Expression.Error made public. Is this correct? Should
18547 Warning be made public too?
18549 * expression.cs: use ea.Location instead of ea.loc.
18550 [FIXME: Filed as bug #28607: MCS must report these errors.]
18552 2002-08-06 Martin Baulig <martin@gnome.org>
18554 * ecore.cs (Expression.loc): Moved the location here instead of
18555 duplicating it in all derived classes.
18556 (Expression.Location): New public property.
18557 (Expression.Error, Expression.Warning): Made them non-static and
18558 removed the location argument.
18559 (Expression.Warning): Added overloaded version which takes an
18560 `int level' argument.
18561 (Expression.Error118): Make this non-static and removed the
18562 expression and location arguments.
18563 (TypeExpr): Added location argument to the constructor.
18565 * expression.cs (StaticCallExpr): Added location argument to
18567 (Indirection, PointerArithmetic): Likewise.
18568 (CheckedExpr, UnCheckedExpr): Likewise.
18569 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18570 (StringPtr): Likewise.
18573 2002-08-05 Martin Baulig <martin@gnome.org>
18575 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18577 * assign.cs (Assign.DoResolve): Check whether the source
18578 expression is a value or variable.
18580 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18581 while resolving the corresponding blocks.
18583 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18584 an error, don't silently return null.
18586 * statement.cs (Block.AddVariable): Do the error reporting here
18587 and distinguish between CS0128 and CS0136.
18588 (Block.DoResolve): Report all unused labels (warning CS0164).
18589 (LabeledStatement): Pass the location to the constructor.
18590 (LabeledStatement.HasBeenReferenced): New property.
18591 (LabeledStatement.Resolve): Set it to true here.
18593 * statement.cs (Return.Emit): Return success even after reporting
18594 a type mismatch error (CS0126 or CS0127), this is what csc does and
18595 it avoids confusing the users with any consecutive errors.
18597 2002-08-05 Martin Baulig <martin@gnome.org>
18599 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18601 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18603 * expression.cs (MemberAccess.DoResolve): Silently return if an
18604 error has already been reported.
18606 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18607 error has already been reported.
18609 2002-08-05 Martin Baulig <martin@gnome.org>
18611 * statement.cs (UsageVector): Only initialize the `parameters'
18612 vector if we actually have any "out" parameters.
18614 2002-08-05 Martin Baulig <martin@gnome.org>
18616 * expression.cs (Binary.ResolveOperator): When combining delegates,
18617 they must have the same type.
18619 2002-08-05 Martin Baulig <martin@gnome.org>
18621 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18622 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18623 work with the ms runtime and we also don't need it: if we're a
18624 PropertyBuilder and not in the `indexer_arguments' hash, then we
18625 are a property and not an indexer.
18627 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18628 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18629 since the latter one doesn't work with the ms runtime.
18631 2002-08-03 Martin Baulig <martin@gnome.org>
18633 Fixed bugs #27998 and #22735.
18635 * class.cs (Method.IsOperator): New public field.
18636 (Method.CheckBase): Report CS0111 if there's already a method
18637 with the same parameters in the current class. Report CS0508 when
18638 attempting to change the return type of an inherited method.
18639 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18640 and it's not marked abstract or extern.
18641 (PropertyBase): New abstract base class for Property and Indexer.
18642 (PropertyBase.CheckBase): Moved here from Property and made it work
18644 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18645 the same so we can reuse it there.
18646 (Property, Indexer): Derive from PropertyBase.
18647 (MethodSignature.inheritable_property_signature_filter): New delegate
18648 to find properties and indexers.
18650 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18651 argument and improved error reporting.
18653 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18654 EmptyReadOnlyParameters and made it a property.
18656 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18657 version of this method which takes a `PropertyInfo indexer'.
18658 (TypeManager.RegisterIndexer): New method.
18660 * class.cs: Added myself as author of this file :-)
18662 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18664 * class.cs: fixed compilation on windoze.
18666 2002-08-03 Martin Baulig <martin@gnome.org>
18668 * interface.cs (Interface.GetInterfaceBases): Check whether all
18669 base interfaces are at least as accessible than the current one.
18671 * class.cs (TypeContainer.GetClassBases): Check whether base types
18672 are at least as accessible than the current type.
18673 (TypeContainer.AsAccessible): Implemented and made non-static.
18674 (MemberBase.CheckParameters): Report errors if the accessibility
18677 * delegate.cs (Delegate.Delegate): The default visibility is
18678 internal for top-level types and private for nested types.
18679 (Delegate.Define): Report errors if the accessibility checks fail.
18681 * enum.cs (Enum.Enum): The default visibility is internal for
18682 top-level types and private for nested types.
18683 (Enum.DefineType): Compute the correct visibility.
18685 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18686 function which takes a `bool is_toplevel' instead of a TypeContainer.
18688 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18691 2002-08-02 Martin Baulig <martin@gnome.org>
18693 * expression.cs (LocalVariableReferenc): Added constructor which
18694 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18695 (LocalVariableReference.IsReadOnly): New property.
18696 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18697 variable is readonly, use our own readonly flag to do this; you can
18698 use the new constructor to get a writable reference to a read-only
18701 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18702 reference to the local variable.
18704 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18706 * rootcontext.cs (ResolveCore): Also include System.Exception
18708 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18709 we reach an EmptyStatement.
18711 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18714 * expression.cs (Binary.ResolveOperator): Check error result in
18717 use brtrue/brfalse directly and avoid compares to null.
18719 2002-08-02 Martin Baulig <martin@gnome.org>
18721 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18722 Fixes bug #28407, added test-155.cs.
18724 2002-08-01 Martin Baulig <martin@gnome.org>
18726 * class.cs (Event.EmitDefaultMethod): Make this work with static
18727 events. Fixes #28311, added verify-3.cs.
18729 2002-08-01 Martin Baulig <martin@gnome.org>
18731 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18732 `is_disposable' fields.
18733 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18734 `hm.is_disposable' if we're using the collection pattern.
18735 (Foreach.EmitCollectionForeach): Use the correct type for the
18736 enumerator's local variable, only emit the try/finally block if
18737 necessary (fixes #27713).
18739 2002-08-01 Martin Baulig <martin@gnome.org>
18741 * ecore.cs (Expression.report118): Renamed to Error118 and made
18744 * statement.cs (Throw.Resolve): Check whether the expression is of
18745 the correct type (CS0118) and whether the type derives from
18746 System.Exception (CS0155).
18747 (Catch.Resolve): New method. Do the type lookup here and check
18748 whether it derives from System.Exception (CS0155).
18749 (Catch.CatchType, Catch.IsGeneral): New public properties.
18751 * typemanager.cs (TypeManager.exception_type): Added.
18753 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18755 * driver.cs: Updated About function.
18757 2002-07-31 Martin Baulig <martin@gnome.org>
18759 Implemented Control Flow Analysis.
18761 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18762 (EmitContext.CurrentBranching): Added.
18763 (EmitContext.StartFlowBranching): Added.
18764 (EmitContext.EndFlowBranching): Added.
18765 (EmitContext.KillFlowBranching): Added.
18766 (EmitContext.IsVariableAssigned): Added.
18767 (EmitContext.SetVariableAssigned): Added.
18768 (EmitContext.IsParameterAssigned): Added.
18769 (EmitContext.SetParameterAssigned): Added.
18770 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
18771 Added control flow analysis stuff here.
18773 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
18774 resolve the expression as lvalue.
18775 (LocalVariableReference.DoResolve): Check whether the variable has
18776 already been assigned.
18777 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
18778 the parameter as assigned here.
18779 (ParameterReference.DoResolve): Check whether the parameter has already
18781 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
18782 expression as lvalue.
18784 * statement.cs (FlowBranching): New class for the flow analysis code.
18785 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
18786 (LabeledStatement.IsDefined): New public property.
18787 (LabeledStatement.AddUsageVector): New public method to tell flow
18788 analyis that the label may be reached via a forward jump.
18789 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
18791 (VariableInfo.Number): New public field. This is used by flow analysis
18792 to number all locals of a block.
18793 (Block.CountVariables): New public property. This is the number of
18794 local variables in this block (including the locals from all parent
18796 (Block.EmitMeta): Number all the variables.
18798 * statement.cs: Added flow analysis support to all classes.
18800 2002-07-31 Martin Baulig <martin@gnome.org>
18802 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
18803 To get debugging messages, compile mcs with /define:MCS_DEBUG and
18804 then use this argument.
18806 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
18808 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
18809 use this to specify /define options.
18811 2002-07-29 Martin Baulig <martin@gnome.org>
18813 * statement.cs (Fixed): Moved all code that does variable lookups
18814 and resolvings from Emit to Resolve.
18816 * statement.cs (For): Moved all code that does variable lookups
18817 and resolvings from Emit to Resolve.
18819 * statement.cs (Using): Moved all code that does variable lookups
18820 and resolvings from Emit to Resolve.
18822 2002-07-29 Martin Baulig <martin@gnome.org>
18824 * attribute.cs (Attribute.Resolve): Explicitly catch a
18825 System.NullReferenceException when creating the
18826 CustromAttributeBuilder and report a different warning message.
18828 2002-07-29 Martin Baulig <martin@gnome.org>
18830 * support.cs (ParameterData.ParameterName): Added method to
18831 get the name of a parameter.
18833 * typemanager.cs (TypeManager.IsValueType): New public method.
18835 2002-07-29 Martin Baulig <martin@gnome.org>
18837 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
18838 is a flag which specifies that it's either ref or out.
18839 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
18840 the out parameter to `out Parameter.Modifier mod', also set the
18841 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
18843 * support.cs (InternalParameters.ParameterModifier): Distinguish
18844 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18845 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18847 * expression.cs (Argument.GetParameterModifier): Distinguish
18848 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18849 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18851 2002-07-29 Martin Baulig <martin@gnome.org>
18853 * expression.cs (ParameterReference.ParameterReference): Added
18854 `Location loc' argument to the constructor.
18856 * cs-parser.jay: Pass location to ParameterReference.
18858 2002-07-28 Miguel de Icaza <miguel@ximian.com>
18860 * statement.cs (Try): Initialize the location.
18862 * cs-parser.jay: pass location to Try.
18864 * expression.cs (Unary.Reduce): Change the prototype to return
18865 whether a constant fold could be performed or not. The result is
18866 returned in an out parameters. In the case of Indirection and
18867 AddressOf, we want to perform the full tests.
18869 2002-07-26 Miguel de Icaza <miguel@ximian.com>
18871 * statement.cs (Statement.Emit): Flag dead code.
18873 2002-07-27 Andrew Birkett <andy@nobugs.org>
18875 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
18877 2002-07-27 Martin Baulig <martin@gnome.org>
18879 * class.cs (MethodData.Define): Put back call to
18880 TypeManager.AddMethod(), accidentally commented this out.
18882 * report.cs (Debug): New public method to print debugging information,
18883 this is `[Conditional ("DEBUG")]'.
18885 2002-07-26 Martin Baulig <martin@gnome.org>
18887 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
18888 (switch_statement): Push the current_block to the switch_stack and
18889 pop it again when we're done with the switch.
18890 (switch_section): The new block is a child of the current_block.
18891 Fixes bug #24007, added test-152.cs.
18893 2002-07-27 Martin Baulig <martin@gnome.org>
18895 * expression.cs (Invocation.EmitArguments): When calling a varargs
18896 function with only its fixed arguments, we need to pass an empty
18899 2002-07-27 Martin Baulig <martin@gnome.org>
18901 Mono 0.13 has been released.
18903 2002-07-25 Miguel de Icaza <miguel@ximian.com>
18905 * driver.cs: Rename --resource to --linkres, because that is what
18906 we do currently, we dont support --resource yet.
18908 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
18910 2002-07-25 Martin Baulig <martin@gnome.org>
18912 * class.cs (MethodData): New public class. This is a `method builder'
18913 class for a method or one accessor of a Property/Indexer/Event.
18914 (MethodData.GetMethodFlags): Moved here from MemberBase.
18915 (MethodData.ApplyAttributes): Likewise.
18916 (MethodData.ApplyObsoleteAttribute): Likewise.
18917 (MethodData.ApplyConditionalAttribute): Likewise.
18918 (MethodData.ApplyDllImportAttribute): Likewise.
18919 (MethodData.CheckAbstractAndExternal): Likewise.
18920 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
18921 (MethodData.Emit): Formerly known as Method.Emit().
18922 (MemberBase): Moved everything which was specific to a single
18923 accessor/method to MethodData.
18924 (Method): Create a new MethodData and call Define() and Emit() on it.
18925 (Property, Indexer, Event): Create a new MethodData objects for each
18926 accessor and call Define() and Emit() on them.
18928 2002-07-25 Martin Baulig <martin@gnome.org>
18930 Made MethodCore derive from MemberBase to reuse the code from there.
18931 MemberBase now also checks for attributes.
18933 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
18934 (MemberBase.GetMethodFlags): Moved here from class Method and marked
18936 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
18937 `CallingConventions cc' and `Attributes opt_attrs' arguments.
18938 (MemberBase.ApplyAttributes): New virtual method; applies the
18939 attributes to a method or accessor.
18940 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
18941 (MemberBase.ApplyConditionalAttribute): Likewise.
18942 (MemberBase.ApplyDllImportAttribute): Likewise.
18943 (MemberBase.CheckAbstractAndExternal): Likewise.
18944 (MethodCore.ParameterTypes): This is now a property instead of a
18945 method, it's initialized from DoDefineParameters().
18946 (MethodCore.ParameterInfo): Removed the set accessor.
18947 (MethodCore.DoDefineParameters): New protected virtual method to
18948 initialize ParameterTypes and ParameterInfo.
18949 (Method.GetReturnType): We can now simply return the MemberType.
18950 (Method.GetMethodFlags): Override the MemberBase version and add
18951 the conditional flags.
18952 (Method.CheckBase): Moved some code from Define() here, call
18953 DoDefineParameters() here.
18954 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
18955 here to avoid some larger code duplication.
18956 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
18957 ensure that abstract and external accessors don't declare a body.
18959 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
18960 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
18961 lookup in the attribute's parent classes, so we need to abort as soon
18962 as we found the first match.
18963 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
18964 the attribute has no arguments.
18966 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
18969 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18971 * cs-parser.jay: reverted previous patch.
18973 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18975 * cs-parser.jay: fixed bug #22119.
18977 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18979 * attribute.cs: fixed compilation. The error was:
18980 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
18981 be assigned to before control leaves the current method."
18982 [FIXME: Filed as bug #28186: MCS must report this error.]
18984 2002-07-25 Martin Baulig <martin@gnome.org>
18986 * attribute.cs (Attribute.Conditional_GetConditionName): New static
18987 method to pull the condition name ouf of a Conditional attribute.
18988 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
18989 the obsolete message and error flag out of an Obsolete attribute.
18991 * class.cs (Method.GetMethodFlags): New public method to get the
18992 TypeManager.MethodFlags for this method.
18993 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
18995 (Method.Define): Get and apply the Obsolete and Conditional attributes;
18996 if we're overriding a virtual function, set the new private variable
18997 `parent_method'; call the new TypeManager.AddMethod().
18999 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19000 the MethodBuilder and the Method in a PtrHashtable.
19001 (TypeManager.builder_to_method): Added for this purpose.
19002 (TypeManager.MethodFlags): Added IsObsoleteError.
19003 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
19004 Obsolete and Conditional arguments in MethodBuilders. If we discover
19005 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
19006 the message from the attribute.
19008 2002-07-24 Martin Baulig <martin@gnome.org>
19010 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
19011 preprocessor directives, ensure that the argument to #define/#undef is
19012 exactly one identifier and that it's actually an identifier.
19014 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
19017 2002-07-24 Martin Baulig <martin@gnome.org>
19019 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
19020 initialize it to TypeManager.object_type in the constructor.
19021 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
19022 of the `hm.get_current' method if we're using the collection pattern.
19023 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
19024 for the explicit conversion to make it work when we're using the collection
19025 pattern and the `Current' property has a different return type than `object'.
19028 2002-07-24 Martin Baulig <martin@gnome.org>
19030 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
19031 does not match, but don't report any errors. This method is called in
19032 order for all methods in a MethodGroupExpr until a matching method is
19033 found, so we don't want to bail out if the first method doesn't match.
19034 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
19035 matches, report the 123. Fixes #28070.
19037 2002-07-24 Martin Baulig <martin@gnome.org>
19039 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
19040 TypeManager.TypeToCoreType() to the top of the method so the
19041 following equality checks will work. Fixes #28107.
19043 2002-07-24 Martin Baulig <martin@gnome.org>
19045 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
19046 operand is of type uint, and the other operand is of type sbyte,
19047 short or int, the operands are converted to type long." -
19048 Actually do what this comment already told us. Fixes bug #28106,
19051 2002-07-24 Martin Baulig <martin@gnome.org>
19053 * class.cs (MethodBase): New abstract class. This is now a base
19054 class for Property, Indexer and Event to avoid some code duplication
19055 in their Define() and DefineMethods() methods.
19056 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
19057 generic methods for Define() and DefineMethods().
19058 (FieldBase): Derive from MemberBase, not MemberCore.
19059 (Property): Derive from MemberBase, not MemberCore.
19060 (Property.DefineMethod): Moved all the code from this method to the
19061 new MethodBase.DefineAccessor(), just call it with appropriate
19063 (Property.Define): Call the new Property.DoDefine(), this does some
19064 sanity checks and we don't need to duplicate the code everywhere.
19065 (Event): Derive from MemberBase, not MemberCore.
19066 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
19067 accessors, this will also make them work with interface events.
19068 (Indexer): Derive from MemberBase, not MemberCore.
19069 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
19070 (Indexer.Define): Use the new MethodBase functions.
19072 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
19073 argument to the constructor.
19074 (Interface.FindMembers): Added support for interface events.
19075 (Interface.PopluateEvent): Implemented.
19077 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
19079 2002-07-22 Miguel de Icaza <miguel@ximian.com>
19081 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
19082 but this is required to check for a method name being the same as
19083 the containing class.
19087 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19089 * interface.cs: initialize variable.
19091 2002-07-23 Martin Baulig <martin@gnome.org>
19093 Implemented the IndexerName attribute in interfaces.
19095 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
19096 name if this is an explicit interface implementation.
19097 (Indexer.InterfaceIndexerName): New public variable. If we're
19098 implementing an interface indexer, this is the IndexerName in that
19099 interface. Otherwise, it's the IndexerName.
19100 (Indexer.DefineMethod): If we're implementing interface indexer,
19101 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
19102 and Pending.ImplementIndexer methods.
19103 (Indexer.Define): Also define the PropertyBuilder if we're
19104 implementing an interface indexer and this is neither an explicit
19105 interface implementation nor do the IndexerName match the one in
19108 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
19109 If a method is defined here, then we always need to create a proxy
19110 for it. This is used when implementing interface indexers.
19111 (Pending.IsInterfaceIndexer): New public method.
19112 (Pending.ImplementIndexer): New public method.
19113 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
19114 This is used when implementing interface indexers to define a proxy
19116 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
19117 define a proxy if necessary.
19119 * interface.cs (Interface.IndexerName): New public variable.
19120 (Interface.PopulateIndexer): Set the IndexerName.
19121 (Interface.DefineIndexers): New private method. Populate all the
19122 indexers and make sure their IndexerNames match.
19124 * typemanager.cs (IndexerPropertyName): Added support for interface
19127 2002-07-22 Martin Baulig <martin@gnome.org>
19129 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
19130 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
19131 ret if HasReturnLabel.
19132 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
19135 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
19136 and set the ec.LoopBeginTryCatchLevel.
19137 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
19138 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
19139 the current ec.TryCatchLevel, the branch goes out of an exception
19140 block. In this case, we need to use Leave and not Br.
19142 2002-07-22 Martin Baulig <martin@gnome.org>
19144 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
19145 block unless the block does not always return or it is contained in
19146 another try { ... } catch { ... } block. Fixes bug #26506.
19147 Added verify-1.cs to the test suite.
19149 2002-07-22 Martin Baulig <martin@gnome.org>
19151 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
19152 then we do not always return. Fixes bug #24985.
19154 2002-07-22 Martin Baulig <martin@gnome.org>
19156 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19157 lookup on a per-class level; ie. walk up the class hierarchy until we
19158 found at least one applicable method, then choose the best among them.
19159 Fixes bug #24463 and test-29.cs.
19161 2002-07-22 Martin Baulig <martin@gnome.org>
19163 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19164 return types of the methods. The return type is not part of the
19165 signature and we must not check it to make the `new' modifier work.
19166 Fixes bug #27999, also added test-147.cs.
19167 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19169 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19170 on the method's return type.
19172 2002-07-21 Martin Baulig <martin@gnome.org>
19174 * assign.cs: Make this work if the rightmost source is a constant and
19175 we need to do an implicit type conversion. Also adding a few more tests
19176 to test-38.cs which should have caught this.
19178 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19179 target in the makefile for this. The makefile.gnu is primarily intended
19180 for end-users who don't want to debug the compiler.
19182 2002-07-21 Martin Baulig <martin@gnome.org>
19184 * assign.cs: Improved the Assign class so it can now handle embedded
19185 assignments (X = Y = Z = something). As a side-effect this'll now also
19186 consume less local variables. test-38.cs now passes with MCS, added
19187 a few new test cases to that test.
19189 2002-07-20 Martin Baulig <martin@gnome.org>
19191 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19192 instructions. Fixes bug #27977, also added test-146.cs.
19194 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19196 * cs-tokenizer.cs: fixed getHex ().
19198 2002-07-19 Martin Baulig <martin@gnome.org>
19200 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19201 not Type.GetType() to lookup the array type. This is needed when
19202 we're constructing an array of a user-defined type.
19203 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19204 single-dimensional arrays, but also for single-dimensial arrays of
19207 2002-07-19 Martin Baulig <martin@gnome.org>
19209 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19210 this function is called, it's not allowed to share LocalBuilders
19211 among ILGenerators.
19213 2002-07-19 Martin Baulig <martin@gnome.org>
19215 * expression.cs (Argument.Resolve): Report an error 118 when trying
19216 to pass a type as argument.
19218 2002-07-18 Martin Baulig <martin@gnome.org>
19220 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19221 Conv_R_Un for the signed `long' type.
19223 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19225 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19226 `expr' for the temporary result, as that will fail if we do
19227 multiple resolves on the same expression.
19229 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19231 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19232 ec.TypeContainer for looking up aliases.
19234 * class.cs (TypeContainer): Remove LookupAlias from here.
19236 * decl.cs (DeclSpace); Move here.
19238 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19240 * class.cs (FindMembers): Only call filter if the constructor
19241 bulider is not null.
19243 Also handle delegates in `NestedTypes' now. Now we will perform
19244 type lookups using the standard resolution process. This also
19247 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19248 This uses Expressions (the limited kind that can be parsed by the
19249 tree) instead of strings.
19251 * expression.cs (ComposedCast.ToString): Implement, used to flag
19252 errors since now we have to render expressions.
19254 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19257 * ecore.cs (SimpleName.ToString): ditto.
19259 * cs-parser.jay: Instead of using strings to assemble types, use
19260 Expressions to assemble the type (using SimpleName, ComposedCast,
19261 MemberAccess). This should fix the type lookups in declarations,
19262 because we were using a different code path for this.
19264 * statement.cs (Block.Resolve): Continue processing statements
19265 even when there is an error.
19267 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19269 * class.cs (Event.Define): Also remove the `remove' method from
19270 the list of pending items.
19272 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19273 generate more compact code.
19275 2002-07-17 Martin Baulig <martin@gnome.org>
19277 * const.cs (Const.LookupConstantValue): Add support for constant
19278 `unchecked' and `checked' expressions.
19279 Also adding test case test-140.cs for this.
19281 2002-07-17 Martin Baulig <martin@gnome.org>
19283 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19284 check whether mi.ReturnType implements the IEnumerator interface; the
19285 `==' and the IsAssignableFrom() will fail in this situation.
19287 2002-07-16 Ravi Pratap <ravi@ximian.com>
19289 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19292 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19294 * expression.cs: fixed bug #27811.
19296 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19298 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19299 Molaro: when we are a ref, the value already contains a pointer
19300 value, do not take the address of it.
19302 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19303 * removed mb-parser.jay and mb-tokenizer.cs
19305 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19307 * expression.cs: check against the building corlib void type.
19309 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19311 * ecore.cs: fix for valuetype static readonly fields: when
19312 initializing them, we need their address, not the address of a copy.
19314 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19316 * typemanager.cs: register also enum_type in corlib.
19318 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19320 * class.cs: allow calling this (but not base) initializers in structs.
19322 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19324 * ecore.cs: make sure we compare against the building base types
19327 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19329 * typemanager.cs: fix TypeToCoreType() to handle void and object
19330 (corlib gets no more typerefs after this change).
19332 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19334 * expression.cs (ArrayCreation.EmitArrayArguments): use
19335 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19337 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19338 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19339 array indexes, the runtime actually forbids them.
19341 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19342 for array arguments here.
19344 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19345 instead of the default for ValueTypes.
19347 (New.DoEmit): Use IsValueType instead of
19348 IsSubclassOf (value_type)
19349 (New.DoResolve): ditto.
19350 (Invocation.EmitCall): ditto.
19352 * assign.cs (Assign): ditto.
19354 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19355 Statements *are* currently doing part of their resolution during
19358 Expressions do always resolve during resolve, but statements are
19359 only required to propagate resolution to their children.
19361 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19363 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19365 (LoadAssembly): Do not add the dll if it is already specified
19367 (MainDriver): Add the System directory to the link path at the end,
19368 after all the other -L arguments.
19370 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19371 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19372 ldelem.u1) and using the opposite for sbytes.
19374 This fixes Digger, and we can finally run it.
19376 * driver.cs (UnixParseOption): Move the option parsing here.
19377 (CSCParseOption): Implement CSC-like parsing of options.
19379 We now support both modes of operation, the old Unix way, and the
19380 new CSC-like way. This should help those who wanted to make cross
19381 platform makefiles.
19383 The only thing broken is that /r:, /reference: and /lib: are not
19384 implemented, because I want to make those have the same semantics
19385 as the CSC compiler has, and kill once and for all the confussion
19386 around this. Will be doing this tomorrow.
19388 * statement.cs (Unsafe.Resolve): The state is checked during
19389 resolve, not emit, so we have to set the flags for IsUnsfe here.
19391 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19393 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19394 not catch the Error_ObjectRefRequired in SimpleName (as it is
19395 possible to have a class/instance variable name that later gets
19396 deambiguated), we have to check this here.
19398 2002-07-10 Ravi Pratap <ravi@ximian.com>
19400 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19401 make static and put into Expression.
19403 (Event.Define): Register the private field of the event with the
19404 TypeManager so that GetFieldFromEvent can get at it.
19406 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19407 keep track of the private field associated with an event which
19410 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19413 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19415 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19417 * expression.cs (Binary.EmitBranchable): this routine emits the
19418 Binary expression in a branchable context. This basically means:
19419 we need to branch somewhere, not just get the value on the stack.
19421 This works together with Statement.EmitBoolExpression.
19423 * statement.cs (Statement.EmitBoolExpression): Use
19426 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19428 * statement.cs (For): Reduce the number of jumps in loops.
19430 (For): Implement loop inversion for the For statement.
19432 (Break): We can be breaking out of a Try/Catch controlled section
19433 (foreach might have an implicit try/catch clause), so we need to
19434 use Leave instead of Br.
19436 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19437 now). If the instace expression supports IMemoryLocation, we use
19438 the AddressOf method from the IMemoryLocation to extract the
19439 address instead of emitting the instance.
19441 This showed up with `This', as we were emitting the instance
19442 always (Emit) instead of the Address of This. Particularly
19443 interesting when This is a value type, as we dont want the Emit
19444 effect (which was to load the object).
19446 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19448 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19450 * statement.cs (Checked): Set the CheckedState during the resolve
19451 process too, as the ConvCast operations track the checked state on
19452 the resolve process, and not emit.
19454 * cs-parser.jay (namespace_member_declaration): Flag that we have
19455 found a declaration when we do. This is used to flag error 1529
19457 * driver.cs: Report ok when we display the help only.
19459 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19461 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19463 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19465 * cs-tokenizer.cs (define): We also have to track locally the
19466 defines. AllDefines is just used for the Conditional Attribute,
19467 but we also need the local defines for the current source code.
19469 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19471 * statement.cs (While, For, Do): These loops can exit through a
19472 Break statement, use this information to tell whether the
19473 statement is the last piece of code.
19475 (Break): Flag that we break.
19477 * codegen.cs (EmitContexts): New `Breaks' state variable.
19479 2002-07-03 Martin Baulig <martin@gnome.org>
19481 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19482 modifiers in method declarations in structs. Otherwise, you won't
19483 be able to override things like Object.Equals().
19485 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19487 * class.cs (Method, Property, Indexer): Do not allow the public
19488 modifier to be used in explicit interface implementations.
19490 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19491 override modifiers in method declarations in structs
19493 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19495 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19496 integer or real overflow, report an error
19498 2002-07-02 Martin Baulig <martin@gnome.org>
19500 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19501 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19502 to tell the runtime about our newly created System.Object and
19503 System.ValueType types.
19505 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19507 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19508 struct instead of Ldarg/Starg.
19510 2002-07-02 Martin Baulig <martin@gnome.org>
19512 * expression.cs (Indirection.Indirection): Call
19513 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19515 2002-07-02 Martin Baulig <martin@gnome.org>
19517 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19518 ValueType, call TypeManager.TypeToCoreType() on it.
19519 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19520 the OpCodes.Newarr argument.
19522 2002-07-02 Martin Baulig <martin@gnome.org>
19524 * expression.cs (Invocation.EmitCall): When compiling corlib,
19525 replace all calls to the system's System.Array type to calls to
19526 the newly created one.
19528 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19529 System.Array methods.
19530 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19531 from the system's System.Array type which must be replaced.
19533 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19535 * typemanager.cs: load unverifiable_code_ctor so we can build
19536 corlib using the correct type. Avoid using GetTypeCode() with
19538 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19539 TypeManager.object_type to allow building corlib.
19541 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19543 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19545 2002-07-01 Martin Baulig <martin@gnome.org>
19547 * class.cs: Make the last change actually work, we need to check
19548 whether `ifaces != null' to avoid a crash.
19550 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19552 * class.cs: when we build structs without fields that implement
19553 interfaces, we need to add the interfaces separately, since there is
19554 no API to both set the size and add the interfaces at type creation
19557 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19559 * expression.cs: the dimension arguments to the array constructors
19560 need to be converted if they are a long.
19562 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19564 * class.cs: don't emit ldarg.0 if there is no parent constructor
19565 (fixes showstopper for corlib).
19567 2002-06-29 Martin Baulig <martin@gnome.org>
19569 MCS now compiles corlib on GNU/Linux :-)
19571 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19572 ie. check for MethodImplOptions.InternalCall.
19574 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19575 and TypeManager.attribute_type are null, so we must explicitly check
19576 whether parent is not null to find out whether it's an attribute type.
19577 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19578 and SetBuilder, not only if the property is neither abstract nor external.
19579 This is necessary to set the MethodImplOptions on the accessor methods.
19580 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19581 SetBuilder, see Property.Emit().
19583 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19584 populate "System.Object", "System.ValueType" and "System.Attribute" since
19585 they've already been populated from BootCorlib_PopulateCoreTypes().
19587 2002-06-29 Martin Baulig <martin@gnome.org>
19589 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19590 is the NullLiteral, we also need to make sure that target_type is not
19593 2002-06-29 Martin Baulig <martin@gnome.org>
19595 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19596 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19597 before calling BootstrapCorlib_ResolveDelegate ().
19599 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19601 * statement.cs: fixed build-breaker. All tests passed ok.
19603 2002-06-27 Martin Baulig <martin@gnome.org>
19605 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19606 for System.Decimal when compiling corlib.
19608 2002-06-27 Martin Baulig <martin@gnome.org>
19610 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19611 switch blocks which contain nothing but a default clause.
19613 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19615 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19617 2002-06-27 Martin Baulig <martin@gnome.org>
19619 * ecore.cs (PropertyExpr.PropertyExpr): Call
19620 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19622 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19623 is already a TypeBuilder.
19625 2002-06-27 Martin Baulig <martin@gnome.org>
19627 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19628 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19629 the "from an array-type to System.Array" case. This makes it work
19630 when compiling corlib.
19632 2002-06-27 Martin Baulig <martin@gnome.org>
19634 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19635 non-static PropertyExpr, set its InstanceExpression. This makes
19636 the `ICollection.Count' property work in System/Array.cs.
19638 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19640 * driver.cs: Made error handling more consistent. Errors now
19641 tracked by Report class, so many methods which used to return int
19642 now return void. Main() now prints success/failure and
19643 errors/warnings message.
19645 Renamed '--probe' compiler argument to '--expect-error'. Removed
19646 the magic number return values (123 and 124). Now, if the
19647 expected error occurs, the compiler exits with success (exit value
19648 0). If the compilation completes without seeing that particular
19649 error, the compiler exits with failure (exit value 1). The
19650 makefile in mcs/errors has been changed to handle the new behaviour.
19652 * report.cs: Made 'expected error' number a property and renamed
19653 it from 'Probe' to 'ExpectedError'.
19655 * genericparser.cs: Removed error handling support, since it is
19656 now all done by Report class.
19658 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19659 class, so parse() no longer returns an int.
19661 * namespace.cs: Use Report.Error instead of GenericParser.error
19663 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19665 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19666 TypeContainer.AddOperator): At the front of the list put the
19667 explicit implementations, so they get resolved/defined first.
19669 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19671 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19672 interface type is implemented by this TypeContainer. Used during
19673 explicit interface implementation.
19675 (Property.Define, Indexer.Define, Method.Define): Validate that
19676 the given interface in the explicit implementation is one of the
19677 base classes for the containing type.
19679 Also if we are explicitly implementing an interface, but there is
19680 no match in the pending implementation table, report an error.
19682 (Property.Define): Only define the property if we are
19683 not explicitly implementing a property from an interface. Use the
19684 correct name also for those properties (the same CSC uses,
19685 although that is really not needed).
19687 (Property.Emit): Do not emit attributes for explicitly implemented
19688 properties, as there is no TypeBuilder.
19690 (Indexer.Emit): ditto.
19692 Hiding then means that we do not really *implement* a pending
19693 implementation, which makes code fail.
19695 2002-06-22 Martin Baulig <martin@gnome.org>
19697 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19698 the return value of Object.GetType(). [FIXME: we need to do this whenever
19699 we get a type back from the reflection library].
19701 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19703 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19705 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19707 * attribute.cs: Return null if we can not look up the type.
19709 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19710 the interface types found.
19712 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19713 interface types found.
19715 * typemanager.cs (GetInterfaces): Make this routine returns alll
19716 the interfaces and work around the lame differences between
19717 System.Type and System.Reflection.Emit.TypeBuilder in the results
19718 result for GetInterfaces.
19720 (ExpandInterfaces): Given an array of interface types, expand and
19721 eliminate repeated ocurrences of an interface. This expands in
19722 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19725 2002-06-21 Martin Baulig <martin@gnome.org>
19727 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19730 2002-06-21 Martin Baulig <martin@gnome.org>
19732 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19733 and called with one of the core types, return the corresponding typebuilder for
19736 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19739 2002-06-21 Martin Baulig <martin@gnome.org>
19741 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19742 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19743 (Expression.ConvertReferenceExplicit): Likewise.
19745 * expression.cs (ElementAccess.DoResolve): Likewise.
19746 (ElementAccess.DoResolveLValue): Likewise.
19748 2002-06-10 Martin Baulig <martin@gnome.org>
19750 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19751 add the "value" parameter to the parameter list.
19753 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19756 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19758 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19759 the argument to an int, uint, long or ulong, per the spec. Also
19760 catch negative constants in array creation.
19762 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
19764 * class.cs: do not allow the same interface to appear twice in
19765 the definition list.
19767 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
19769 * ecore.cs: don't use ldlen with System.Array.
19771 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
19773 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
19775 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
19777 * modifiers.cs: produce correct field attributes for protected
19778 internal. Easy fix so miguel can work on ther harder stuff:-)
19780 2002-06-18 Miguel de Icaza <miguel@ximian.com>
19782 * pending.cs: New file. Move the code from class.cs here.
19783 Support clearning the pending flag for all methods (when not doing
19784 explicit interface implementation).
19786 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
19788 * rootcontext.cs: added a couple more types needed to bootstrap.
19790 2002-06-17 Miguel de Icaza <miguel@ximian.com>
19792 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
19793 constructor in the type, instead of any constructor in the type
19794 hierarchy. Thanks to Paolo for finding this bug (it showed up as
19795 a bug in the Mono runtime when applying the params attribute).
19797 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19798 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
19800 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
19802 * expression.cs (Unary.ResolveOperator): Use TypeManager
19803 to resolve the type.
19805 2002-06-13 Ravi Pratap <ravi@ximian.com>
19807 * cs-parser.jay (enum_member_declaration): Pass in the attributes
19810 * enum.cs (AddEnumMember): Add support to store the attributes associated
19811 with each member too.
19813 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
19814 field builders too - this takes care of the enum member case.
19816 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
19818 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
19819 address-of operator on both value types and pointers.
19821 2002-06-10 Martin Baulig <martin@gnome.org>
19823 * interface.cs (Interface.PopulateIndexer): Add the indexer's
19824 PropertyBuilder to the `property_builders' list.
19826 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
19827 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
19828 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
19829 find any indexers which are inherited from an interface.
19831 2002-06-09 Martin Baulig <martin@gnome.org>
19833 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
19834 the same type as the constant if necessary. There's also a test-130.cs
19837 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
19839 * typemanager.cs (TypeManager.ChangeType): Previously known as
19840 Enum.ChangeEnumType().
19842 2002-06-09 Martin Baulig <martin@gnome.org>
19844 * expression.cs (Cast.TryReduce): Added support for consts.
19846 2002-06-08 Ravi Pratap <ravi@ximian.com>
19848 * class.cs (Accessor): Hold attributes information so we can pass
19851 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
19852 Modify to pass in attributes attached to the methods.
19854 (add_accessor_declaration, remove_accessor_declaration): Ditto.
19856 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
19857 to handle the Accessor kind :-)
19859 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
19861 2002-06-08 Martin Baulig <martin@gnome.org>
19863 * expression.cs (Unary.TryReduceNegative): Added support for
19866 2002-06-08 Martin Baulig <martin@gnome.org>
19868 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
19869 name can't be found in the `defined_names' - the caller will do a
19870 MemberLookup in this case and thus find methods in System.Enum
19871 such as Enum.IsDefined().
19873 2002-06-08 Martin Baulig <martin@gnome.org>
19875 * enum.cs (Enum.ChangeEnumType): This is a custom version of
19876 Convert.ChangeType() which works with TypeBuilder created types.
19877 (Enum.LookupEnumValue, Enum.Define): Use it here.
19879 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
19880 `TypeBuilder.BaseType != null' check.
19881 (TypeContainer.FindMembers): Only lookup parent members if we
19882 actually have a parent.
19883 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
19884 (ConstructorInitializer.Resolve): Likewise.
19886 * interface.cs (Interface.FindMembers): Added
19887 `TypeBuilder.BaseType != null' check.
19889 * rootcontext.cs (RootContext.ResolveCore): Added
19890 "System.Runtime.CompilerServices.IndexerNameAttribute" to
19891 classes_second_stage.
19893 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
19894 debug_type and trace_type when compiling with --nostdlib.
19896 2002-06-07 Martin Baulig <martin@gnome.org>
19898 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
19899 (AddField): Set it to true when adding a non-static field.
19900 (DefineType): Use `have_nonstatic_fields' to find out whether we
19901 have non-static fields, not `Fields != null'.
19903 2002-06-02 Miguel de Icaza <miguel@ximian.com>
19905 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
19906 dereferencing a null on the static-field code path)
19908 2002-05-30 Martin Baulig <martin@gnome.org>
19910 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
19911 to take command line arguments. Use reflection to call the new
19912 custom `Initialize' function on the symbol writer and pass it the
19913 command line arguments.
19915 * driver.cs (--debug-args): New command line argument to pass command
19916 line arguments to the symbol writer.
19918 2002-05-28 Miguel de Icaza <miguel@ximian.com>
19920 * assign.cs (DoResolve): Forgot to do the implicit conversion to
19921 the target type for indexers and properties. Thanks to Joe for
19924 2002-05-27 Miguel de Icaza <miguel@ximian.com>
19926 * typemanager.cs (MethodFlags): returns the method flags
19927 (Obsolete/ShouldIgnore) that control warning emission and whether
19928 the invocation should be made, or ignored.
19930 * expression.cs (Invocation.Emit): Remove previous hack, we should
19931 not do this on matching a base type, we should do this based on an attribute
19933 Only emit calls to System.Diagnostics.Debug and
19934 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
19935 on the command line.
19937 * rootcontext.cs: Global settings for tracing and debugging.
19939 * cs-tokenizer.cs (define): New utility function to track
19940 defines. Set the global settings for TRACE and DEBUG if found.
19942 2002-05-25 Ravi Pratap <ravi@ximian.com>
19944 * interface.cs (Populate*): Pass in the TypeContainer as well as
19945 the DeclSpace as parameters so that we can create EmitContexts and
19946 then use that to apply attributes etc.
19948 (PopulateMethod, PopulateEvent, PopulateProperty)
19949 (PopulateIndexer): Apply attributes everywhere.
19951 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
19954 (ApplyAttributes): Update accordingly.
19956 We now apply interface attributes for all members too.
19958 2002-05-26 Miguel de Icaza <miguel@ximian.com>
19960 * class.cs (Indexer.Define); Correctly check if we are explicit
19961 implementation (instead of checking the Name for a ".", we
19962 directly look up if the InterfaceType was specified).
19964 Delay the creation of the PropertyBuilder.
19966 Only create the PropertyBuilder if we are not an explicit
19967 interface implementation. This means that explicit interface
19968 implementation members do not participate in regular function
19969 lookups, and hence fixes another major ambiguity problem in
19970 overload resolution (that was the visible effect).
19972 (DefineMethod): Return whether we are doing an interface
19975 * typemanager.cs: Temporary hack until we get attributes in
19976 interfaces (Ravi is working on that) and we get IndexerName
19977 support in interfaces.
19979 * interface.cs: Register the indexers as properties.
19981 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
19982 warning, I have verified that this is a bug in the .NET runtime
19983 (JavaScript suffers of the same problem).
19985 * typemanager.cs (MemberLookup): When looking up members for
19986 interfaces, the parent of an interface is the implicit
19987 System.Object (so we succeed in searches of Object methods in an
19988 interface method invocation. Example: IEnumerable x; x.ToString
19991 2002-05-25 Miguel de Icaza <miguel@ximian.com>
19993 * class.cs (Event): Events should also register if they do
19994 implement the methods that an interface requires.
19996 * typemanager.cs (MemberLookup); use the new GetInterfaces
19999 (GetInterfaces): The code used to lookup interfaces for a type is
20000 used in more than one place, factor it here.
20002 * driver.cs: Track the errors at the bottom of the file, we kept
20005 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
20006 instance if the method we are calling is static!
20008 2002-05-24 Miguel de Icaza <miguel@ximian.com>
20010 * attribute.cs (ApplyAttributes): Make this function filter out
20011 the IndexerName attribute (as that attribute in reality is never
20012 applied) and return the string constant for the IndexerName
20015 * class.cs (TypeContainer.Emit): Validate that all the indexers
20016 have the same IndexerName attribute, and if so, set the
20017 DefaultName attribute on the class.
20019 * typemanager.cs: The return value might contain other stuff (not
20020 only methods). For instance, consider a method with an "Item"
20021 property and an Item method.
20023 * class.cs: If there is a problem with the parameter types,
20026 2002-05-24 Ravi Pratap <ravi@ximian.com>
20028 * ecore.cs (ImplicitConversionExists): Wrapper function which also
20029 looks at user defined conversion after making a call to
20030 StandardConversionExists - we need this for overload resolution.
20032 * expression.cs : Update accordingly the various method calls.
20034 This fixes 2 bugs filed against implicit user defined conversions
20036 2002-05-22 Miguel de Icaza <miguel@ximian.com>
20038 * statement.cs: Track the result of the assignment.
20040 2002-05-21 Miguel de Icaza <miguel@ximian.com>
20042 * expression.cs (MemberAccess): Improved error reporting for
20043 inaccessible members.
20045 2002-05-22 Martin Baulig <martin@gnome.org>
20047 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
20048 itself with debugging support.
20050 2002-05-22 Martin Baulig <martin@gnome.org>
20052 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
20053 Removed, this isn't needed anymore.
20055 2002-05-20 Martin Baulig <martin@gnome.org>
20057 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
20058 be underlying type for an enum.
20060 2002-05-20 Miguel de Icaza <miguel@ximian.com>
20062 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
20063 that splits out the loading of just the core types.
20065 * rootcontext.cs (ResolveCore): Split the struct resolution in
20066 two, so we can load the enumeration underlying types before any
20069 * expression.cs (Is): Bandaid until we fix properly Switch (see
20070 bug #24985 for details).
20072 * typemanager.cs (ImplementsInterface): The hashtable will contain
20073 a null if there are no interfaces implemented.
20075 2002-05-18 Miguel de Icaza <miguel@ximian.com>
20077 * cs-parser.jay (indexer_declarator): It is fine to have array
20080 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20082 * typemanager.cs: (RegisterBuilder): New function used to register
20083 TypeBuilders that implement interfaces. Since
20084 TypeBuilder.GetInterfaces (as usual) does not work with lame
20086 (AddUserType): register interfaces.
20088 (ImplementsInterface): Use the builder_to_ifaces hash if we are
20089 dealing with TypeBuilder. Also, arrays are showing up as
20090 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
20091 methods can not be invoked on them!
20093 * ecore.cs (ExplicitReferenceConversionExists): Made public.
20094 (ImplicitReferenceConversionExists): Split out from
20095 StandardConversionExists.
20097 * expression.cs (As): We were only implementing one of the three
20098 cases for the as operator. We now implement them all.
20099 (Is): Implement the various other cases for Is as well.
20101 * typemanager.cs (CACHE): New define used to control if we want or
20102 not the FindMembers cache. Seems to have a negative impact on
20103 performance currently
20105 (MemberLookup): Nested types have full acess to
20106 enclosing type members
20108 Remove code that coped with instance/static returns for events, we
20109 now catch this in RealFindMembers.
20111 (RealFindMembers): only perform static lookup if the instance
20112 lookup did not return a type or an event.
20114 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20116 * assign.cs (CompoundAssign): We pass more semantic information
20117 now to Compound Assignments than we did before: now we have all
20118 the information at hand, and now we resolve the target *before* we
20119 do the expression expansion, which allows the "CacheValue" method
20120 to have the effect we intended (before, a [x] += 1 would generate
20121 two differen ArrayAccess expressions from the ElementAccess,
20122 during the resolution process).
20124 (CompoundAssign.DoResolve): Resolve target and original_source here.
20126 2002-05-16 Miguel de Icaza <miguel@ximian.com>
20128 * expression.cs (ArrayAccess): dropped debugging information.
20130 * typemanager.cs: Small bug fix: I was always returning i_members,
20131 instead of one of i_members or s_members (depending on which had
20134 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
20135 method is invoked before any code generation takes place, and it
20136 is a mechanism to inform that the expression will be invoked more
20137 than once, and that the method should use temporary values to
20138 avoid having side effects
20140 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
20142 * ecore.cs (Expression.CacheTemporaries): Provide empty default
20145 * expression.cs (Indirection, ArrayAccess): Add support for
20146 CacheTemporaries in these two bad boys.
20148 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
20149 ldobj or ldind_ref.
20150 (StoreFromPtr): Handle stobj as well.
20152 * expression.cs (UnaryMutator): Share more code.
20154 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20155 down: I was not tracking the Filter function as well, which
20156 was affecting the results of the cache.
20158 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20160 * attribute.cs: Remove the hack to handle the CharSet property on
20163 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20165 * attribute.cs (DoResolve): More uglyness, we now only try to
20166 resolve the attribute partially, to extract the CharSet
20167 information (only if we are a StructLayout attribute). Otherwise
20169 (GetExtraTypeInfo): Add some code to conditionally kill in the
20170 future this. I am more and more convinced that the .NET
20171 framework has special code to handle the attribute setting on
20174 * expression.cs (IsParamsMethodApplicable): Revert my previous
20175 foreach change here, it was wrong.
20177 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20179 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20180 (pp_expr): do not abort on unknown input, just return.
20181 (eval): abort if there are pending chars.
20183 * attribute.cs (Attribute.Resolve): Positional parameters are
20184 optional. Deal with that case.
20186 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20187 the Ansi/Unicode/Auto information for the type.
20189 (TypeContainer.DefineType): instantiate the EmitContext here, as
20190 we will be using it during the type definition (to resolve
20191 attributes) and during the emit phase.
20193 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20194 to pull type information out of the attributes
20196 (Attribute.Resolve): track the constructor builder, and allow for
20197 multiple invocations (structs and classes will use this).
20199 * ecore.cs (MemberLookupFinal): new version with all the
20200 parameters customizable.
20202 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20203 constructors. Return if the result value is null (as the error
20204 would have been flagged already by MemberLookupFinal)
20206 Do not allow instances of abstract classes or interfaces to be
20209 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20210 We have to compare the assembly property here when dealing with
20211 FamANDAssem and Assembly access modifiers, because we might be
20212 creating an assembly from *modules* (that means that we are not
20213 getting TypeBuilders for types defined in other modules that are
20214 part of this assembly).
20216 (Method.Emit): If the method is marked abstract and has a body,
20219 (TypeContainer.DefineMembers): If both the defined member and the
20220 parent name match are methods, then do not emit any warnings: let
20221 the Method.Define routine take care of flagging warnings. But if
20222 there is a mismatch (method overrides something else, or method is
20223 overriwritten by something, then emit warning).
20225 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20226 set to null, this means `do not check for the return type on the
20229 (Method.Define): set the return type for the method signature to
20230 null, so that we get methods with the same name and parameters and
20231 different return types. This is used to flag warning 114 (you are
20232 hiding a method, and you probably want to use the new/override
20235 * typemanager.cs (MemberLookup): Implemented proper access
20236 control, closing a long standing set of bug reports. The problem
20237 was that the Framework only has two bits: Public and NonPublic,
20238 and NonPublic includes private and protected methods, but we need
20239 to enforce the FamANDAssem, FamOrAssem and Family.
20241 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20243 * statement.cs (GotoCase): Return true: Ammounts to giving up
20244 knowledge on whether we return or not, and letting the other case
20245 be responsible for it.
20247 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20249 * driver.cs: Do not load directories for each file processed, only
20250 do it if there is a pattern.
20252 * ecore.cs: Report readonly assigns here as well, as we might have
20253 been resolved only by MemberAccess.
20255 (SimpleName.SimpleNameResolve): Also be useful for LValue
20256 resolution. We need this to propagate assign to local readonly variables
20258 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20259 do not want to reuse potential criteria memory.
20261 * class.cs (MyEventBuilder): Set reflected_type;
20263 * ecore.cs (Constantify): Added support for constifying bools.
20265 (RootContext.LookupType): Added a cache for values looked up in
20266 the declaration space.
20268 * typemanager.cs (FindMembers): Now is a front-end to
20269 RealFindMembers, and provides a two-level hashtable-based cache to
20272 15% performance improvement: from 22.5 to 19.2 seconds.
20274 * expression.cs (IsParamsMethodApplicable): use foreach.
20275 (Invocation.DoResolve): ditto.
20276 (New.DoResolve): ditto.
20277 (ArrayCreation.DoResolve): ditto.
20279 * ecore.cs (FindMostEncompassingType): use foreach.
20281 * delegate.cs (NewDelegate.DoResolve): Use foreach
20283 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20284 (RemoveMethods): use foreach.
20286 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20287 nested foreach statements instead of for, and also break out of
20288 the inner loop once a match is found.
20290 (Invocation.OverloadResolve): Use foreach, simplify the code.
20292 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20294 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20295 we actually unwrap the expression to allow for extra information
20298 * expression.cs: Use Shr_Un on unsigned operations.
20300 2002-05-08 Ravi Pratap <ravi@ximian.com>
20302 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20303 applicable operators was not being considered correctly. This closes
20304 the bug Miguel reported.
20306 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20308 * attribute.cs: check that the type derives from System.Attribute
20309 and report the correct error in that case (moved the duplicate code to
20310 its own method, too).
20312 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20314 * attribute.cs: lookup attribute type name as the spec says: first the
20315 bare attribute name and then name + "Attribute" (nant compiles with
20316 mcs after this fix).
20318 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20320 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20321 Because of the way we parse things, we should try to see if a
20322 UIntConstant can fit in an integer.
20324 2002-05-07 Ravi Pratap <ravi@ximian.com>
20326 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20327 when we are in an explicit context.
20329 (ConvertReferenceExplicit): When converting from Iface type S to Class
20330 T make sure the rules are implemented as an OR.
20332 * parameter.cs (ParameterType): Make it a property for now although the
20333 purpose really isn't anything immediate.
20335 * expression.cs (Is*Applicable): Do better checking on the parameter type
20336 of a ref/out parameter. The ones from the system assemblies are already
20337 marked with the correct type so we don't need to do any correction.
20339 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20340 the object type is standard too so include that.
20342 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20344 * ecore.cs (StandardConversionExists): Augment with missing code:
20345 deal with IntConstant, LongConstants and Enumerations.
20347 * assign.cs: Report the error, instead of failing silently
20349 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20350 typecontainer that they are declared, because the
20351 typecontainer/namespace will have the list of using clauses that
20352 need to be applied.
20354 Assembly Attributes were escaping the normal registration
20357 (EmitCode): Apply attributes within an EmitContext that represents
20358 the container they were declared on.
20360 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20362 2002-05-06 Ravi Pratap <ravi@ximian.com>
20364 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20365 Revamp completely - make much cleaner as we now operate only
20368 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20369 to implement the logic detailed in the spec more correctly.
20371 (UserDefinedConversion): Update accordingly.
20373 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20375 * statement.cs: Return flow analysis information up.
20377 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20380 (token): Do not consume an extra character before calling
20383 2002-05-06 Piers Haken <piersh@friskit.com>
20385 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20387 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20389 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20390 EmitContext during the instance constructor initializer
20391 resolution, to stop access to instance variables.
20393 This is mandated by the spec, last paragraph of the `constructor
20394 initializers' section.
20396 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20398 * cs-parser.jay, class.cs (Accessor): new class used to represent
20399 an accessor (get or set). In the past we used `null' to represent
20400 a missing accessor. But this is ambiguous because there was no
20401 way to tell in abstract indexers/properties if one of them was
20404 Now there is a way of addressing that.
20406 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20407 instead of FindMembers.
20409 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20410 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20412 * attribute.cs: Treat indexers and properties as the same in terms
20413 of applying attributes
20415 * ecore.cs (FindMostEncompassedType): Use statically initialized
20416 EmptyExpressions()s like we do elsewhere to avoid creating useless
20417 objects (and we take this out of the tight loop).
20419 (GetConversionOperators): Move the code to extract the actual
20420 operators to a separate routine to clean things up.
20422 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20424 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20425 events are always registered FieldBuilders.
20427 * class.cs (FieldBase): New class shared by Fields
20429 * delegate.cs: If we are a toplevel delegate, use our full name.
20430 If we are a nested delegate, then only use our tail name.
20432 2002-05-02 Ravi Pratap <ravi@ximian.com>
20434 * expression.cs (IsApplicable): Ensure that we add the "&" to
20435 ref/out types before comparing it with the type of the argument.
20437 (IsParamsMethodApplicable): Ditto.
20439 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20442 * delegate.cs : Handle the case when we have more than one applicable
20443 method. Flag an error only when we finish checking all.
20445 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20447 * expression.cs: Add support for boolean static initializers.
20449 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20451 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20453 * parameter.cs (ComputeParameterTypes,
20454 ComputeAndDefineParameterTypes): Better error handling: now we
20455 clear the `types' cache if we fail during any of the type lookups.
20456 We also return the status code correctly to our caller
20458 * delegate.cs: If we fail to define a delegate, abort the extra
20461 * expression.cs (Binary.ResolveOperator): for
20462 operator==(object,object) and operator !=(object, object) we also
20463 have to verify that there is an implicit conversion from one to
20466 (ArrayAccess.DoResolve): Array Access can operate on
20469 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20471 * assign.cs (CompoundAssign): A new class used as a "flag" that
20472 the assignment actually is happening as part of a compound
20473 assignment operator.
20475 During compound assignment, a few new rules exist to enable things
20482 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20483 to the type of x) if y is implicitly convertible to the type of x,
20484 and the operator is a builtin operator and the return type of the
20485 operator is explicitly convertible to the type of x.
20487 * rootcontext.cs: Reset warning level to 2. 4 catches various
20488 "interesting" features in mcs, we must clean this up at some
20489 point, but currently am trying to kill other bugs ;-)
20491 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20492 in container classes as well.
20494 * expression.cs (Binary.ResolveOperator): Handle string case
20495 before anything else (as operator overloading does emit an error
20496 before doing anything else).
20498 This code could go away when we move to a table driven model, but
20499 i could not come up with a good plan last night.
20501 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20503 * typemanager.cs (CSharpName): reimplementation using regex.
20504 * class.cs: added null check for fields in Emit
20505 * rootcontext.cs: set warninglevel to 4
20507 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20509 * typemanager.cs (CSharpName): reimplemented with Lupus
20512 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20514 * statement.cs (If): correclty implement Resolve, because we were
20515 not catching sem errors in there. The same process is needed
20517 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20520 (Statement.Warning_DeadCodeFound): Factorize code.
20521 (While): Report dead code here too.
20523 (Statement): Added Resolve virtual method to allow
20524 for resolution split from the emit code.
20526 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20528 * statement.cs (EmitBoolExpression): No longer try to resolve the
20530 (MakeBoolean): New utility function that resolve, implicitly
20531 converts to boolean and tags the expression.
20534 (If, Do): Implement dead code elimination.
20535 (While): Implement loop inversion
20537 (Do, While, For, If): Resolve the expression prior to calling our
20540 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20543 - added method Report28 (warning: program has more than one entry point)
20544 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20545 - modified method Method.Define, the part at the end of the method
20547 * rootcontext.cs: added static public Location EntryPointLocation;
20549 * ../errors/cs0028.cs : Add test case for the above warning.
20552 - modified method CSharpName to allow arrays of primitive type to
20553 be printed nicely (e.g. instead of System.Int32[][] it now prints
20555 - added method CSharpSignature: returns the signature of a method
20556 in string format to be used in reporting errors, warnings, etc.
20558 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20561 2002-04-26 Ravi Pratap <ravi@ximian.com>
20563 * delegate.cs (Define): Fix extremely silly bug where I was
20564 setting the type of the 'object' parameter of the BeginInvoke
20565 method to System.IAsyncResult instead of System.Object ;-)
20567 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20569 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20572 (Constructor.Emit): return if we fail to initialize the
20573 constructor. Another door closed!
20575 * expression.cs (New.DoResolve): Improve error message (from -6 to
20576 1501). Use DeclaredOnly lookup to find the exact constructor.
20578 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20579 loop. This is useful.
20581 * cs-parser.jay: Adjust the default parameters so that destructors
20582 have the proper signature.
20584 2002-04-26 Martin Baulig <martin@gnome.org>
20586 * driver.cs (LoadAssembly): If `assembly' contains any characters
20587 which are only valid in path names and not in assembly names
20588 (currently slash, backslash and point), use Assembly.LoadFrom ()
20589 instead of Assembly.Load () on the `assembly' (before iteration
20590 over the link_paths).
20592 2002-04-26 Martin Baulig <martin@gnome.org>
20594 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20596 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20598 * class.cs (Property): use the new typemanager.MemberLookup
20600 (TypeContainer.MemberLookup): Implement using the
20601 TypeManager.MemberLookup now.
20603 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20604 and return MemberInfos, so that these can be used without an
20605 EmitContext (what we had before).
20607 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20609 * expression.cs: Fix the case where the argument to params if the
20610 type of the params. I omitted handling this before. Fixed
20612 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20614 * driver.cs: Call BootCorlib_PopulateCoreType
20616 * class.cs (Property.CheckBase): Check for properties only, not
20619 * interface.cs: Temporary hack: try/catch around the
20620 CustomAttributeBuilder, because I am getting an exception that I
20623 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20624 types whose definitions are required to be there (attributes are
20625 defined before standard types).
20627 Compute definitions as we boot the various types, as they are used
20628 immediately (value_type class will need object_type, but if we do
20629 not initialize object_type, we will pass a null, which will let
20630 the runtime pick the System.Object from the existing corlib, which
20631 is not what we want).
20633 2002-04-22 Patrik Torstensson <totte@labs2.com>
20635 * cs-tokenizer.cs: fixed a number of trim() issues.
20637 2002-04-22 Ravi Pratap <ravi@ximian.com>
20639 * expression.cs (Argument.Type): Ensure that we return the correct
20640 type when we have out or ref parameters [in which case we
20643 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20645 * class.cs (Property, Indexer): Allow extern modifier in there.
20647 * typemanager.cs (InitBaseTypes): Initializes object_type and
20648 value_type, since those will be used early on during the bootstrap
20649 process to compile corlib.
20651 (InitCoreTypes): Move code from here to InitBaseTypes.
20653 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20655 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20656 single-dimension arrays as using the ldlen opcode.
20658 Daniel Lewis discovered this optimization.
20660 * typemanager.cs: Add signature for System.Array::get_Length
20662 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20664 * statement.cs: report the error when the foreach does not apply to an
20665 array nor a collection.
20667 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20669 * expression.cs: Add implicit conversions to the operator ~.
20671 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20673 * typemanager.cs: Locate the decimal constructor.
20675 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20677 * attribute.cs: use the new property of TypeOf.
20678 * expression.cs: added 'get' property around typearg.
20680 These changes fix a build breaker reported by NickD. Is this the
20681 correct way to fix? If not, please, revert my changes and make it
20684 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20686 * attribute.cs: Add support for typeof in attribute invocations.
20687 I am not sure that this is right though.
20689 2002-04-14 Duncan Mak <duncan@ximian.com>
20691 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20692 Binary.Operator.Division case.
20694 2002-04-13 Ravi Pratap <ravi@ximian.com>
20696 * class.cs (DefineType): Ensure that we do a proper check on
20697 attribute types and also register it with the TypeManager.
20699 (TypeContainer.Targets): The default for attribute types is
20700 AttributeTargets.All.
20702 * attribute.cs (ApplyAttributes): Registering the attribute type
20703 is done elsewhere, not when we discover we have a Usage attribute.
20705 2002-04-12 Ravi Pratap <ravi@ximian.com>
20707 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20708 and get rid of is_delegate parameter.
20710 * everywhere : update.
20712 2002-04-12 Ravi Pratap <ravi@ximian.com>
20714 * cs-parser.jay (compilation_unit): Revamp completely to use
20715 some new ideas that I got from Rhys' grammar to solve the problems
20716 with assembly level attributes.
20718 (outer_declaration): New grammar production.
20720 (attribute_sections): Add.
20722 (opt_attributes): Base on attribute_sections
20724 (namespace_declaration): Allow opt_attributes to tackle the case
20725 when we have assembly level attributes - we are clever in this
20728 * attribute.cs (ApplyAttributes): Do not worry about assembly
20729 attributes in the non-global context.
20731 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20732 instead of SetGlobalAttributes.
20734 * class.cs, rootcontext.cs : Ensure we define and generate
20735 attribute types before anything else.
20737 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20738 and flag the new error -20 for the case when the attribute type
20739 does not have valid targets specified. csc does not catch this.
20741 * ../errors/errors.txt : update for error # -20
20743 2002-04-11 Ravi Pratap <ravi@ximian.com>
20745 * support.cs (InternalParameters.ParameterModifier): Do some null
20746 checking and return sane values.
20748 * class.cs (Method.Define): If we are a PInvoke method, ensure
20749 that we are static and extern. Report error # 601
20751 * ../errors/cs0601.cs : Add test case for the above error.
20753 2002-04-07 Ravi Pratap <ravi@ximian.com>
20755 * rootcontext.cs (attribute_types): We need to keep type of
20756 all attribute types separately and emit code for them first.
20758 (RegisterAttribute) : Implement.
20760 * class.cs (DefineType): Check if the current Type is a custom
20761 attribute type and register it accordingly.
20763 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
20764 adding the first attribute twice and rename to
20766 (SetGlobalAttributes): this.
20768 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
20771 * attribute.cs (ApplyAttributes): Take an additional argument telling us
20772 if we are processing global arguments. Hmm, I am unsure of this.
20774 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20776 * expression.cs: added static array of strings to avoid calling
20777 Enum.ToString () for Operator in Binary. Significant recover of
20780 2002-04-10 Miguel de Icaza <miguel@ximian.com>
20782 * class.cs (FindMembers): Allow the Builders of the various
20783 members to be null. If they are skip them. This only happens
20784 during the PInvoke declaration.
20786 2002-04-09 Miguel de Icaza <miguel@ximian.com>
20788 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
20789 failure, so we do not keep going afterwards.
20791 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
20792 wanted to pass `false' as the `is_delegate' argument. If this is
20793 the case, why not use delegate_type == null to mean `is_delegate =
20794 false' and anything else as is_delegate = true.
20796 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
20798 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
20799 code for the section, not the beginning of the tests.
20801 2002-04-08 Miguel de Icaza <miguel@ximian.com>
20803 * cfold.cs: Handle operator + (Enum x, Underlying x)
20805 * expression.cs (Binary): same. Warn about errors where we have
20806 Enum/Enum in operator + as well.
20808 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
20811 - added support for switch(bool)
20812 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
20813 - add TableSwitchEmit() to handle table-based switch statements
20815 2002-04-05 Ravi Pratap <ravi@ximian.com>
20817 * expression.cs (Invocation.OverloadResolve): Factor out code which
20818 does parameter compatibility checking with arguments so that we can
20819 re-use the code even from Delegate.VerifyApplicability
20821 (VerifyArgumentsCompat): Move above code here.
20823 * delegate.cs (VerifyApplicability): Get rid of duplicate code
20824 and instead make a call to the above method.
20826 2002-03-31 Ravi Pratap <ravi@ximian.com>
20828 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
20829 We use it to keep track of classes which are attribute types.
20831 2002-04-02 Miguel de Icaza <miguel@ximian.com>
20833 * delegate.cs (Delegate.Define): Correctly define the types in the
20834 presence of fixed and array parameters.
20836 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
20839 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
20840 include NonPublic after the first iteration.
20842 * class.cs (Indexer.CheckBase): Only check if both parents are
20845 * cs-parser.jay (accessor_body): If empty, set to null.
20847 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
20848 same code path here to resolve constants names that we did have in
20849 MemberAccess.DoResolve. There is too much code duplicated here.
20851 2002-04-01 Miguel de Icaza <miguel@ximian.com>
20853 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
20855 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
20858 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
20859 tokens, numbers and strings.
20861 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
20864 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
20865 asyncronous parameters and the regular parameters.
20867 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
20868 specify the target directory.
20870 * expression.cs: (This.DoResolve): Simplify
20871 (As.Emit): Optimize, do not generate IsInst if the expression is
20872 always of the given type.
20874 (Is.DoResolve): Bug fix, we were reporting both always/never for
20877 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
20878 creating too many unnecessary arrays.
20880 2002-03-31 Miguel de Icaza <miguel@ximian.com>
20882 * class.cs (EmitFieldInitializer): Use Assign expression to assign
20883 fields instead of rolling our own initializer. Takes care of all
20884 implicit conversions, and drops unnecessary static checks/argument.
20886 2002-03-31 Dick Porter <dick@ximian.com>
20888 * driver.cs: use the GetDirectories() return values properly, and
20889 use "/" as path separator.
20891 2002-03-30 Miguel de Icaza <miguel@ximian.com>
20893 * expression.cs (Unary): Optimize - - expr into expr.
20894 (Binary): Optimize a + (-b) into a -b.
20896 * codegen.cs (CodeGen): Made all methods static.
20898 2002-03-29 Miguel de Icaza <miguel@ximian.com>
20902 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
20903 TypeBuilder property.
20905 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
20908 * tree.cs: Removed the various RecordXXXX, and replaced with a
20909 single RecordDecl. Removed all the accessor methods, and just
20910 left a single access point Type
20912 * enum.cs: Rename DefineEnum to DefineType.
20914 * decl.cs: New abstract method `DefineType' used to unify the
20915 Defines for Enumerations, Interfaces, TypeContainers and
20918 (FindType): Moved LookupInterfaceOrClass here. Moved the
20919 LookupBaseClasses method that used to live in class.cs and
20920 interface.cs here, and renamed to FindType.
20922 * delegate.cs: Implement DefineType. Take advantage of the
20923 refactored pattern for locating the parent builder without taking
20924 the parent_builder argument (which we know does not work if we are
20925 nested, and triggering a toplevel definition).
20927 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20929 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
20930 accessibility of a member has changed during override and report
20933 * class.cs (Method.Define, Property.Define): Only complain on
20934 overrides if the method is private, any other accessibility is
20935 fine (and since we just checked the permission is the same, we are
20938 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
20939 and elif are processed always. The other pre-processing
20940 directives are only processed if we are "taking" the path
20942 2002-03-29 Martin Baulig <martin@gnome.org>
20944 * class.cs (Method.Emit): Only emit symbolic debugging info if the
20945 current location is not Null.
20947 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
20948 a separate method so we can profile it.
20950 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
20951 `span.Seconds' are just seconds, but no minutes or hours.
20952 (MainDriver): Profile the CodeGen.SaveSymbols calls.
20954 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20956 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
20957 Remove the gratuitous set of Final:
20959 // If an interface implementation, then we can set Final.
20960 if (((flags & MethodAttributes.Abstract) == 0) &&
20961 implementing.DeclaringType.IsInterface)
20962 flags |= MethodAttributes.Final;
20964 I do not know what I was smoking when I used that.
20967 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
20968 step into fixing the name resolution issues for delegates and
20969 unifying the toplevel name resolution.
20971 2002-03-28 Martin Baulig <martin@gnome.org>
20973 * class.cs (Method.Emit): If we have a symbol writer, call its
20974 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
20975 tell it about the current method.
20977 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
20978 writer that we're going to emit the first byte of IL code for a new
20979 statement (a new source line).
20980 (EmitContext.EmitTopBlock): If we have a symbol writer, call
20981 EmitContext.Mark() before emitting any code.
20983 * location.cs (SymbolDocument): Return null when we're Null.
20985 * statement.cs (Statement): Moved the `Location loc' variable here.
20986 (Statement.EmitBoolExpression): If we have a symbol writer, call
20987 ec.Mark() before emitting any code to tell it that we're at the
20988 beginning of a new statement.
20989 (StatementExpression): Added `Location' argument to the constructor.
20990 (Block): Added public readonly variable `StartLocation' and public
20991 variable `EndLocation'. The latter is to be set using SetEndLocation().
20992 (Block): Added constructor which takes a start and end location.
20993 (Block.SetEndLocation): New method. This sets the end location.
20994 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
20995 local variables we create.
20996 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
20997 each statement and do also mark the begin and end of the block.
20999 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21000 tell it the current lexer.Location, use Location.Null for the end of the
21002 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
21003 current block, set its end location using SetEndLocation().
21004 (statement_expression): StatementExpression constructor now takes the
21005 lexer.Location as additional argument.
21006 (for_statement, declare_local_variables): Likewise.
21007 (declare_local_variables): When creating a new implicit block, use the
21008 new Block constructor and pass it the lexer.Location.
21010 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21012 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
21013 members also on the parent interfaces recursively.
21015 2002-03-27 Miguel de Icaza <miguel@ximian.com>
21017 * report.cs: Use new formats, since Gonzalo finished the missing
21020 * expression.cs (Binary.ResolveOperator): added missing operator|
21021 operator& and operator^ for bool/bool.
21023 * cs-parser.jay: CheckDef now takes a Location argument that is
21024 used to report errors more precisly (instead of reporting the end
21025 of a definition, we try to track something which is a lot closer
21026 to the source of the problem).
21028 * cs-tokenizer.cs: Track global token use, so we can properly flag
21029 the use of #define/#undef after the first token has been seen.
21031 Also, rename the reportXXXX to Error_DescriptiveName
21033 * decl.cs (DeclSpace.IsTopLevel): Move property here from
21034 TypeContainer, so that Enum and Interface can use this too.
21036 * class.cs (TypeContainer.LookupInterfaceOrClass,
21037 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
21038 `builder' argument. Typically this was used to pass the parent
21039 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
21042 The problem is that a nested class could trigger the definition of
21043 a toplevel class, and the builder would be obviously wrong in that
21046 So we drop this argument, and we compute dynamically the
21047 TypeBuilder/ModuleBuilder (the correct information was available
21048 to us anyways from DeclSpace.Parent)
21050 * interface.cs (Interface.DefineInterface): Drop builder
21051 parameter cleanup like class.cs
21053 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
21056 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
21059 (Try.Emit): Propagate the returns value from the statement.
21061 (Return.Emit): Even if we are leavning
21063 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
21065 * modifiers.cs: Fix the computation of MethodAttributes flags.
21067 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
21069 * driver.cs: allow compilation of files that start with '/'.
21070 Add a default case when checking the argument of --target.
21072 2002-03-25 Miguel de Icaza <miguel@ximian.com>
21074 * interface.cs: Implement the same search algorithm for types in
21075 the interface code.
21077 * delegate.cs: Do not allow multiple definition.
21079 * Recovered ChangeLog that got accidentally amputated
21081 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
21083 * rootcontext.cs: Load manually enum to allow core classes to
21084 contain enumerations.
21086 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
21087 Update to new static methods in TypeManager.
21089 * typemanager.cs (GetMethod, GetConstructor): Use our
21090 implementation of FindMembers to find the members, since during
21091 corlib compilation, the types are TypeBuilders and GetMethod and
21092 GetConstructor do not work.
21094 Make all methods in TypeManager static.
21096 (InitCodeHelpers): Split the functionality from
21097 the InitCodeTypes function.
21099 * driver.cs: Call InitCodeHelpers after we have populated the
21102 * cs-parser.jay (delegate_declaration): we did not used to compute
21103 the delegate name correctly for void delegates.
21105 2002-03-24 Miguel de Icaza <miguel@ximian.com>
21107 * rootcontext.cs (RootContext): Init the interface_resolve_order
21108 and type_container_resolve_order always.
21110 (ResolveCore, BootstrapCorlib_ResolveClass,
21111 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
21112 compiler when compiling with --nostdlib
21114 * class.cs (TypeContainer.DefineType): Check that our parent is
21115 not null. This test is most important when we are bootstraping
21118 * codegen.cs: Split out the symbol writing code.
21120 2002-03-25 Martin Baulig <martin@gnome.org>
21122 * driver.cs (-g): Made -g an alias for --debug.
21124 2002-03-24 Martin Baulig <martin@gnome.org>
21126 * codegen.cs (SymbolWriter): New public variable. Returns the
21127 current symbol writer.
21128 (CodeGen): Added `bool want_debugging_support' argument to the
21129 constructor. If true, tell the ModuleBuild that we want debugging
21130 support and ask it for the ISymbolWriter.
21131 (Save): If we have a symbol writer, call it's Close() method after
21132 saving the assembly.
21134 * driver.c (--debug): New command line argument to create a
21135 debugger information file.
21137 * location.cs (SymbolDocument): New public property. Returns an
21138 ISymbolDocumentWriter object for the current source file or null
21139 if we don't have a symbol writer.
21141 2002-03-21 Miguel de Icaza <miguel@ximian.com>
21143 * driver.cs (LoadAssembly): Correctly return when all the paths
21144 have been tried and not before.
21146 * statement.cs (Switch.Emit): return the actual coverage for this
21147 statement (returns/not-returns)
21149 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
21150 switch of the statement if we are the last switch section. That
21151 kills two problems: try/catch problems (we used to emit an empty
21152 nop at the end) and switch statements where all branches would
21155 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21157 * driver.cs: Add default assemblies (the equivalent to the
21158 Microsoft CSC.RSP file)
21160 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21161 also update tokens_seen and set it to false.
21163 * driver.cs: Implement --recurse for Mike.
21165 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21166 correctly splitting out the paths.
21168 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21170 * interface.cs (Interface.PopulateProperty): Instead of using
21171 `parent' as the declaration space for the set parameters, use
21174 * support.cs (InternalParameters): InternalParameters constructor
21175 takes a DeclSpace instead of a TypeContainer.
21177 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21178 types are being initialized, load the address of it before calling
21181 (New): Provide a mechanism to disable the generation of local
21182 value type temporaries when the caller will be providing us with
21183 an address to store it.
21185 (ArrayCreation.EmitDynamicInitializers): Use it.
21187 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21189 * expression.cs (Invocation.EmitArguments): Only probe for array
21190 property if there is more than one argument. Sorry about that.
21192 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21193 empty param arrays.
21195 * class.cs (Method.LabelParameters): Fix incorrect code path that
21196 prevented the `ParamArrayAttribute' from being applied to the
21199 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21201 * support.cs (ReflectionParameters): Correctly compute whether the
21202 last argument is a params array. Fixes the problem with
21205 * typemanager.cs: Make the assemblies array always be non-null
21206 (empty, but non-null)
21208 * tree.cs (RecordDecl): New function that abstracts the recording
21209 of names. This reports error 101, and provides a pointer to the
21210 previous declaration. Fixes a crash in the compiler.
21212 * cs-parser.jay (constructor_declaration): Update to new grammar,
21213 and provide a constructor_body that can be empty.
21215 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21217 * driver.cs: Add support for --resources.
21219 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21220 Make all types for the various array helper methods be integer.
21222 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21223 CheckState to ConvCast.
21225 (ConvCast): Now it takes a `checked' state argument, to avoid
21226 depending on the emit context for the conversion, and just using
21227 the resolve time setting.
21229 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21230 instead of Invocation.EmitArguments. We do not emit the original
21231 arguments, instead we emit those which have been converted to
21232 unsigned int expressions.
21234 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21236 * codegen.cs: ditto.
21238 * expression.cs (LocalVariableReference): Drop the use of the
21239 Store function that depended on the variable index.
21241 * statement.cs (VariableInfo): Drop the `Idx' property from this
21242 class, as this is not taking into account the indexes for
21243 temporaries tat we generate during the execution, getting the
21246 * class.cs: First emit class initializers, then call the parent
21249 * expression.cs (Binary): Fix opcode emision.
21250 (UnaryMutator.EmitCode): Support checked code generation
21252 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21253 matches for events for both the Static and Instance scans,
21254 pointing to the same element. Fix that.
21256 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21258 * rootcontext.cs (ResolveTree): Always set the
21259 interface_resolve_order, because nested interfaces will be calling
21262 * class.cs (GetInterfaceOrClass): Track the same resolution
21263 process used by TypeManager.LookupType. This fixes the nested
21264 type lookups in class declarations (separate path from
21267 (TypeContainer.DefineType): Also define nested interfaces.
21268 (TypeContainer.RegisterOrder): New public function used to
21269 register the order in which child interfaces need to be closed.
21271 Nested interfaces need to be closed after their parents have been
21274 * interface.cs (InterfaceAttr): Put all the logic for computing
21275 the interface attribute here.
21277 (DefineInterface): Register our interface order with the
21278 RootContext or with the TypeContainer depending on the case.
21280 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21282 * cs-parser.jay: rework foreach statement to work with the new
21283 changes to the policy on SimpleNames.
21285 * report.cs: support Stacktrace on warnings as well.
21287 * makefile: drop --unsafe and /unsafe from the compile.
21289 2002-03-13 Ravi Pratap <ravi@ximian.com>
21291 * ecore.cs (StandardConversionExists): Modify to take an Expression
21292 as the first parameter. Ensure we do null -> reference type conversion
21295 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21296 temporary Expression objects.
21298 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21300 * interface.cs: workaround bug in method overloading resolution
21301 (there is already a bugzilla bug for it).
21303 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21305 We could also solve this problem by having a separate path for
21306 performing type lookups, instead of DoResolve, we could have a
21307 ResolveType entry point, and only participating pieces of the
21308 production (simplename, deref, array) would implement this.
21310 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21311 signal SimpleName to only resolve type names and not attempt to
21312 resolve anything else.
21314 * expression.cs (Cast): Set the flag.
21316 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21318 * class.cs: Only report 108 if there is no `new' modifier.
21320 * cs-parser.jay: rework foreach statement to work with the new
21321 changes to the policy on SimpleNames.
21323 * report.cs: support Stacktrace on warnings as well.
21325 * makefile: drop --unsafe and /unsafe from the compile.
21327 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21329 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21330 lookups here, instead of doing that at parse time. This means
21331 that our grammar will not introduce `LocalVariableReferences' as
21332 expressions at this point. That solves the problem of code like
21336 static void Main ()
21340 This is only half the fix. The full fix requires parameters to
21341 also be handled in this way.
21343 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21344 makes the use more obvious of the DeclSpace. The
21345 ec.TypeContainer.TypeBuilder is now only used to pull the
21346 TypeBuilder for it.
21348 My theory is that I can get rid of the TypeBuilder completely from
21349 the EmitContext, and have typecasts where it is used (from
21350 DeclSpace to where it matters).
21352 The only pending problem is that the code that implements Aliases
21353 is on TypeContainer, and probably should go in DeclSpace.
21355 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21356 lookups here, instead of doing that at parse time. This means
21357 that our grammar will not introduce `LocalVariableReferences' as
21358 expressions at this point. That solves the problem of code like
21362 static void Main ()
21366 This is only half the fix. The full fix requires parameters to
21367 also be handled in this way.
21369 * class.cs (Property.DefineMethod): When implementing an interface
21370 method, set newslot, when implementing an abstract method, do not
21371 set the flag (before we tried never setting it, or always setting
21372 it, which is the difference).
21373 (Indexer.DefineMethod): same.
21374 (Method.DefineMethod): same.
21376 * ecore.cs: Only set the status used flag if we get back a Field.
21378 * attribute.cs: Temporary hack, so Paolo can keep working.
21380 2002-03-08 Ravi Pratap <ravi@ximian.com>
21382 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21383 the unmanaged type in the case we have a MarshalAs attribute.
21385 (Resolve): Handle the case when we are parsing the special MarshalAs
21386 attribute [we need to store the unmanaged type to use later]
21388 * typemanager.cs (marshal_as_attr_type): Built in type for the
21389 MarshalAs Attribute.
21391 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21392 on parameters and accordingly set the marshalling info.
21394 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21396 * class.cs: Optimizing slightly by removing redundant code after
21397 we switched to the `NoTypes' return value.
21398 (Property.DefineMethod): use NoTypes here too.
21400 This fixes the bug I introduced in my last batch of changes.
21402 2002-03-05 Ravi Pratap <ravi@ximian.com>
21404 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21406 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21407 Enums since those are types too.
21409 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21411 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21412 thanks to a call during the lookup process.
21414 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21416 * statement.cs (Foreach): Lots of work to accomodate a particular
21417 kind of foreach statement that I had not kept in mind. It is
21418 possible to have foreachs on classes that provide a GetEnumerator
21419 method that return objects that implement the "pattern" for using
21420 a foreach, there is no need to support GetEnumerator
21423 This is needed to compile nant.
21425 * decl.cs: Only report 114 if the member is not `Finalize' and if
21426 the warning level is at least 2.
21428 * class.cs: Moved the compare function from Method to
21431 (MethodSignature.InheritableMemberSignatureCompare): Add new
21432 filter function that is used to extract inheritable methods from a
21435 (Method.Define): Use the new `inheritable_method_signature_filter'
21438 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21441 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21443 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21445 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21447 * expression.cs: Pass location information to
21448 ConvertImplicitStandard.
21450 * class.cs: Added debugging code to track return values from
21453 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21455 * expression.cs (Is.DoResolve): If either side of the `is' is an
21456 interface, do not flag the warning.
21458 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21461 * report.cs: Allow for --fatal to be used with --probe.
21463 * typemanager.cs (NoTypes): Move the definition for the empty Type
21466 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21468 (TypeContainer.DefineProxy): New function used to proxy to parent
21469 implementations when implementing interfaces.
21470 (TypeContainer.ParentImplements): used to lookup if our parent
21471 implements a public function that is required by an interface.
21472 (TypeContainer.VerifyPendingMethods): Hook this up.
21474 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21475 `modules' and `assemblies' arraylists into arrays. We only grow
21476 these are the very early start up of the program, so this improves
21477 the speedof LookupType (nicely measured).
21479 * expression.cs (MakeByteBlob): Replaced unsafe code with
21480 BitConverter, as suggested by Paolo.
21482 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21483 folding of string concatenation, but if either side is a string,
21484 and the other is not, then return null, and let the runtime use
21485 the concatenation on the string plus the object (using
21486 `Object.ToString').
21488 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21490 Constant Folding has been implemented now.
21492 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21493 the error instead on types that are not supported in one's
21496 * constant.cs (Constant and all children): New set of functions to
21497 perform implict and explicit conversions.
21499 * ecore.cs (EnumConstant): Implement the new functions to perform
21500 conversion by proxying to the child expression.
21502 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21503 own separate setting that can not be turned off from the command
21504 line using --unchecked or --checked and is only controlled using
21505 the checked/unchecked statements and expressions. This setting is
21506 used by the constant folder to flag errors.
21508 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21509 ConstantCheckState as well.
21511 During Resolve, they also have to flag the state, because the
21512 constant folder runs completely in the Resolve phase.
21514 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21517 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21519 * cfold.cs: New file, this file contains the constant folder.
21521 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21522 argument to track whether we are using the resulting address to
21523 load or store a value and provide better error messages.
21525 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21526 new AddressOf arguments.
21528 * statement.cs (Foreach.EmitCollectionForeach): Update
21530 * expression.cs (Argument.Emit): Call AddressOf with proper
21531 arguments to track usage.
21533 (New.DoEmit): Call AddressOf with new arguments.
21535 (Unary.Emit): Adjust AddressOf call.
21537 2002-03-01 Ravi Pratap <ravi@ximian.com>
21539 * cs-parser.jay (member_access): Change the case for pre-defined types
21540 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21543 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21546 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21547 essentially like methods and apply attributes like MethodImplOptions to them too.
21549 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21552 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21553 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21556 * Update code everywhere accordingly.
21558 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21560 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21562 2002-02-28 Ravi Pratap <ravi@ximian.com>
21564 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21565 try performing lookups against those instead of jumping straight into using
21566 the 'using' clauses.
21568 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21570 (LookupType): Perform lookups in implicit parents too.
21572 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21573 sequence as RootContext.LookupType.
21575 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21576 the various cases of namespace lookups into this method.
21578 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21580 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21581 in positional arguments)
21583 * class.cs (Operator): Update the AllowedModifiers to contain
21586 * cs-parser.jay: Update operator declaration to allow for the
21587 operator body to be empty.
21589 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21592 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21594 * class.cs (Method.Emit): Label parameters.
21596 * driver.cs: Return 1 or 0 as the program exit code.
21598 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21600 * expression.cs: Special case the `null' object when trying to
21601 auto-compute the type, as anything can be explicitly converted to
21604 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21605 spotting this Paolo.
21607 (Expression.ImplicitNumericConversion): Perform comparissions of
21608 the type using the underlying type in the case of an enumeration
21609 rather than using the enumeration type for the compare.
21611 Cope with the underlying == type case, which is not possible to
21614 (Expression.ConvertNumericExplicit): Perform comparissions of
21615 the type using the underlying type in the case of an enumeration
21616 rather than using the enumeration type for the compare.
21618 * driver.cs: If the user does not supply an extension, assume .exe
21620 * cs-parser.jay (if_statement): Rewrote so that we can track the
21621 location for the if statement.
21623 * expression.cs (Binary.ConstantFold): Only concat strings when
21624 the operation is "+", not everything ;-)
21626 * statement.cs (Statement.EmitBoolExpression): Take a location
21628 (If, While, Do): Track location.
21630 * expression.cs (Binary.ResolveOperator): In the object + string
21631 case, I was missing a call to ConvertImplicit
21633 2002-02-25 Ravi Pratap <ravi@ximian.com>
21635 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21636 Location arguments. Ensure we use RootContext.LookupType to do our work
21637 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21639 * interface.cs (PopulateMethod): Handle the type of the parameter being
21642 * expression.cs (Invocation.BetterFunction): Handle the case when we
21643 have a params method with no fixed arguments and a call is made with no
21646 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21648 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21649 the verbatim-string-literal
21651 * support.cs (InternalParameters.ParameterModifier): handle null
21653 (InternalParameters.ParameterType): ditto.
21655 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21656 duplicating the name of the variable parameter.
21657 (GetParameterByName): Fix bug where we were not looking up array
21658 paramters if they were the only present (thanks Paolo!).
21659 (GetParameterInfo): We only have an empty set of types if both
21660 fixed and array are set to null.
21661 (GetParameterInfo-idx): Handle FixedParameter == null
21663 * cs-parser.jay: Handle the case where there is no catch
21664 statements (missing null test).
21666 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21668 * driver.cs (MainDriver): Be conservative on our command line
21671 Catch DirectoryNotFoundException when calling GetFiles.
21673 (SplitPathAndPattern): Used to split the input specification into
21674 a path and a pattern that we can feed to Directory.GetFiles.
21676 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21678 * statement.cs (Fixed): Implement the last case of the Fixed
21679 statement (string handling).
21681 * expression.cs (StringPtr): New class used to return a char * to
21682 a string; Used by the Fixed statement.
21684 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21686 * expression.cs (Binary.ResolveOperator): Remove redundant
21687 MemberLookup pn parent type.
21688 Optimize union call, we do not need a union if the types are the same.
21689 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21692 Specialize the use of MemberLookup everywhere, instead of using
21693 the default settings.
21695 (StackAlloc): Implement stackalloc keyword.
21697 * cs-parser.jay: Add rule to parse stackalloc.
21699 * driver.cs: Handle /h, /help, /?
21701 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21702 before we supported unsafe code.
21704 * makefile: add --unsafe to the self compilation of mcs.
21706 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21708 * expression.cs (PointerArithmetic): New class that is used to
21709 perform pointer arithmetic.
21710 (Binary.Resolve): Handle pointer arithmetic
21711 Handle pointer comparission.
21712 (ArrayPtr): Utility expression class that is used to take the
21713 address of an array.
21715 (ElementAccess): Implement array access for pointers
21717 * statement.cs (Fixed): Implement fixed statement for arrays, we
21718 are missing one more case before we are done.
21720 * expression.cs (Indirection): Implement EmitAssign and set the
21721 ExprClass to Variable. This allows pointer dereferences to be
21722 treated as variables, and to have values assigned to them.
21724 * ecore.cs (Expression.StoreFromPtr): New utility function to
21725 store values dereferencing.
21727 2002-02-20 Ravi Pratap <ravi@ximian.com>
21729 * expression.cs (Binary.ResolveOperator): Ensure that we are
21730 not trying to operate on a void type - this fixes the reported
21733 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21734 the parent implementation is sealed.
21736 * ../errors/cs0239.cs : Add.
21738 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21740 * typemanager.cs (unverifiable_code_type): Corresponds to
21741 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21742 which have unsafe code in them.
21744 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21747 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21749 * cs-tokenizer.cs: Add support for @"litreal strings"
21751 Make tokenizer accept pre-processor directives
21752 on any column (remove the old C-like limitation).
21754 * rootcontext.cs (EmitCode): Emit any global attributes.
21755 (AddGlobalAttributes): Used to keep track of assembly attributes.
21757 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21759 * cs-parser.jay: Add support for global attributes.
21761 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21763 * expression.cs (Indirection): New helper class. Unary will
21764 create Indirection classes to be able to implement the
21765 IMemoryLocation interface on it.
21767 2002-02-16 Miguel de Icaza <miguel@ximian.com>
21769 * cs-parser.jay (fixed_statement): reference the right statement.
21771 * statement.cs (Fixed.Emit): Finish implementing the fixed
21772 statement for the &x case.
21774 2002-02-14 Miguel de Icaza <miguel@ximian.com>
21776 * class.cs (Property.Define, Method.Define): Remove newslot when
21779 * modifiers.cs: My use of NewSlot when `Abstract' was set was
21780 wrong. NewSlot should only be used if the `new' keyword is present.
21782 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
21783 locating our system dir. Sorry about this.
21785 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21787 * driver.cs (GetSystemDir): Compute correctly the location of our
21788 system assemblies. I was using the compiler directory instead of
21789 the library directory.
21791 2002-02-13 Ravi Pratap <ravi@ximian.com>
21793 * expression.cs (BetterFunction): Put back in what Miguel commented out
21794 since it is the correct fix. The problem is elsewhere ;-)
21796 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
21797 parameters of the parms method are themselves compatible or not !
21799 (StandardConversionExists): Fix very dangerous bug where we were forgetting
21800 to check that a class implements an interface before saying that an implicit
21801 conversion was allowed. Use ImplementsInterface to do the checking.
21803 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21805 * class.cs (Method.Define): Track whether we are an explicit
21806 implementation or not. And only call DefineMethodOverride if we
21807 are an explicit implementation.
21809 (Property.DefineMethod): Ditto.
21811 2002-02-11 Ravi Pratap <ravi@ximian.com>
21813 * expression.cs (BetterFunction): Catch hideous bug which was
21814 preventing us from detecting ambiguous calls due to implicit casts i.e
21817 2002-01-29 Miguel de Icaza <miguel@ximian.com>
21819 * support.cs (Pair): Remove un-needed method. I figured why I was
21820 getting the error in cs-parser.jay, the variable in a foreach loop
21821 is readonly, and the compiler does not really treat this as a variable.
21823 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
21824 instead of EQUALS in grammar.
21826 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
21828 * expression.cs (Unary.DoResolve): Check whether the argument is
21831 2002-01-28 Miguel de Icaza <miguel@ximian.com>
21833 * support.cs: Api for Pair to set a value. Despite the fact that
21834 the variables are public the MS C# compiler refuses to compile
21835 code that accesses the field if the variable is part of a foreach
21838 * statement.cs (Fixed): Begin implementation of the fixed
21841 (Block.AddVariable): Return the VariableInfo on success and null
21842 on failure instead of true/false.
21844 * cs-parser.jay (foreach): Catch errors on variables already
21845 defined (we were ignoring this value before) and properly unwind
21846 the block hierarchy
21848 (fixed_statement): grammar for the fixed statement.
21850 2002-01-25 Miguel de Icaza <miguel@ximian.com>
21852 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
21853 pointer types to be incretemented.
21855 (SizeOf): Implement.
21857 * cs-parser.jay (pointer_member_access): Implement
21858 expr->IDENTIFIER production.
21860 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
21861 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
21864 (Unary): Implement indirection.
21866 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
21867 use in non-unsafe context).
21869 (SimpleName.DoResolve): Check for pointers in field access on safe
21872 (Expression.LoadFromPtr): Factor the load-indirect code in this
21873 function. This was duplicated in UnboxCast and ParameterReference
21875 2002-01-24 Miguel de Icaza <miguel@ximian.com>
21877 * expression.cs (ComposedCast): report an error if a pointer cast
21878 is used in a safe region.
21880 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
21881 pointer type casts in unsafe context.
21883 * codegen.cs (EmitContext): Set up IsUnsafe.
21885 * cs-parser.jay (non_expression_type): Add productions for pointer
21888 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
21889 code. We should not use force into static mode if the method is
21890 not virtual. Fixes bug in MIS
21892 * statement.cs (Do.Emit, While.Emit, For.Emit,
21893 Statement.EmitBoolExpression): Add support to Do and While to
21894 propagate infinite loop as `I do return' semantics.
21896 Improve the For case to also test for boolean constants.
21898 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
21899 to the list of attributes we can add.
21901 Remove `EmitContext' argument.
21903 * class.cs (Method.Define): Apply parameter attributes.
21904 (Constructor.Define): Apply parameter attributes.
21905 (MethodCore.LabelParameters): Move here the core of labeling
21908 * support.cs (ReflectionParameters.ParameterModifier,
21909 InternalParameters.ParameterModifier): Use IsByRef on the type and
21910 only return the OUT bit for these parameters instead of in/out/ref
21913 This is because I miss-understood things. The ParameterInfo.IsIn
21914 and IsOut represent whether the parameter has the [In] and [Out]
21917 2002-01-22 Miguel de Icaza <miguel@ximian.com>
21919 * ecore.cs (FieldExpr.Emit): Release temporaries.
21921 * assign.cs (LocalTemporary.Release): new function.
21923 * codegen.cs (EmitContext.GetTemporaryStorage,
21924 EmitContext.FreeTemporaryStorage): Rework the way we deal with
21925 temporary storage. Now we can "put back" localbuilders when we
21928 2002-01-21 Miguel de Icaza <miguel@ximian.com>
21930 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
21931 need to make a copy of the variable to generate verifiable code.
21933 2002-01-19 Miguel de Icaza <miguel@ximian.com>
21935 * driver.cs: Compute dynamically the system directory.
21937 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
21938 Slower, but more generally useful. Used by the abstract
21939 registering implementation.
21941 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
21942 the rules for the special rule on Type/instances. First check if
21943 we have the same name, and if so, try that special static path
21944 rather than the instance path.
21946 2002-01-18 Miguel de Icaza <miguel@ximian.com>
21948 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
21951 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
21952 Enum, ValueType, Delegate or Array for non-corlib compiles.
21954 * cs-tokenizer.cs: Catch long identifiers (645)
21956 * typemanager.cs (IndexerPropetyName): Ravi never tested this
21959 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
21960 fix, we were returning too early, so we were not registering
21961 pending methods from abstract classes.
21963 Do not register pending methods if the class is abstract.
21965 * expression.cs (Conditional.DoResolve): Report circular implicit
21966 conversions when we neecd to compute it for conditional
21969 (Is.DoResolve): If the expression is always of the provided type,
21970 flag warning 183. If the expression can not ever be of the
21971 provided type flag warning 184.
21973 * class.cs: Catch 169 as well.
21975 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
21978 2002-01-18 Nick Drochak <ndrochak@gol.com>
21980 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
21982 2002-01-17 Miguel de Icaza <miguel@ximian.com>
21984 * interface.cs: (PopulateMethod): Check for pointers being defined
21985 only if the unsafe context is active.
21986 (PopulateProperty): ditto.
21987 (PopulateIndexer): ditto.
21989 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
21990 specified. If pointers are present, make sure that they are
21991 present in an unsafe context.
21992 (Constructor, Constructor.Define): ditto.
21993 (Field, Field.Define): ditto.
21994 (Property, Property.Define): ditto.
21995 (Event, Event.Define): ditto.
21997 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
21998 hashtable if there are classes or structs defined.
22000 * expression.cs (LocalVariableReference.DoResolve): Simplify this
22001 code, as the constant resolution moved.
22003 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
22004 the metadata, so we can flag error 133.
22006 * decl.cs (MemberCore.UnsafeOK): New function to test that a
22007 pointer is being declared in an unsafe context.
22009 2002-01-16 Miguel de Icaza <miguel@ximian.com>
22011 * modifiers.cs (Modifiers.Check): Require a Location argument.
22012 Report error 227 for Unsafe use.
22014 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
22016 * statement.cs (For.Emit): If the test is null, then report that
22017 we do `return', as we wont reach anything afterwards.
22019 (Switch.SwitchGoverningType): Track the expression that matched
22022 * driver.cs: Allow negative numbers as an error code to flag.
22024 * cs-parser.jay: Handle 1551.
22026 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
22028 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22030 * cs-parser.jay: Report 1518 (type declaration can only contain
22031 class, struct, interface, enum or delegate)
22033 (switch_label): Report 1523 (keywords `case' or `default' must
22036 (opt_switch_sections): Report 1522 (empty switch)
22038 * driver.cs: Report 1515 (response file specified multiple times)
22039 Report 1516 (Source file specified multiple times).
22041 * expression.cs (Argument.Resolve): Signal 1510
22043 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
22044 access not allowed in static code)
22046 2002-01-11 Ravi Pratap <ravi@ximian.com>
22048 * typemanager.cs (IsPointerType): Utility method which we are going
22051 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
22052 the object type, so we take care of that.
22054 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
22056 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
22057 added to non-params parameters :-)
22059 * typemanager.cs (CSharpName): Include 'void' type too.
22061 (void_ptr_type): Include in the set of core types.
22063 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
22066 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
22069 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
22070 completely forgotten about it.
22072 2002-01-10 Ravi Pratap <ravi@ximian.com>
22074 * cs-parser.jay (pointer_type): Add. This begins our implementation
22075 of parsing rules for unsafe code.
22077 (unsafe_statement): Implement.
22079 (embedded_statement): Modify to include the above.
22081 * statement.cs (Unsafe): Implement new class for unsafe blocks.
22083 * codegen.cs (EmitContext.InUnsafe): Add. This determines
22084 if the current context is an unsafe one.
22086 * cs-parser.jay (local_variable_pointer_type): Since local variable types
22087 are handled differently, we need separate rules for them.
22089 (local_variable_declaration): Update to use local_variable_pointer_type
22090 to allow variable declarations of unmanaged pointer types.
22092 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
22093 in unsafe contexts.
22095 * ../errors/cs0214.cs : Add.
22097 2002-01-16 Nick Drochak <ndrochak@gol.com>
22099 * makefile: remove 'response' file when cleaning.
22101 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22103 * cs-parser.jay: Report 1524.
22105 2002-01-14 Miguel de Icaza <miguel@ximian.com>
22107 * typemanager.cs (RegisterMethod): drop checking if we have
22108 registered this from here
22110 2002-01-12 Miguel de Icaza <miguel@ximian.com>
22112 * class.cs (Method.EmitDestructor): Implement calling our base
22115 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
22116 value of InFinally.
22118 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
22119 this routine and will wrap the call in a try/catch block. Deal
22122 2002-01-11 Miguel de Icaza <miguel@ximian.com>
22124 * ecore.cs (Expression.MemberLookup): instead of taking a
22125 parameter `same_type' that was used to tell whether we could
22126 access private members we compute our containing type from the
22129 (FieldExpr): Added partial support for volatile fields. This does
22130 not work for volatile fields exposed from assemblies, as I can not
22131 figure out how to extract the modreq from it.
22133 Updated all the source files to use this.
22135 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
22136 because it is referenced by MemberLookup very often.
22138 2002-01-09 Ravi Pratap <ravi@ximian.com>
22140 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
22141 TypeBuilder.GetCustomAttributes to retrieve what we need.
22143 Get rid of redundant default_member_attr_type as this is the same as
22144 default_member_type which already exists.
22146 * interface.cs, attribute.cs : Update accordingly.
22148 2002-01-08 Miguel de Icaza <miguel@ximian.com>
22150 * typemanager.cs: Enable IndexerPropertyName again. It does not
22151 work for TYpeBuilders though. Ravi, can you please fix this?
22153 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22155 * expression.cs (Argument.Emit): Handle the case of ref objects
22156 being passed to ref functions;
22158 (ParameterReference.EmitLoad): Loads the content of the pointer
22159 without dereferencing.
22161 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22163 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22165 2002-01-08 Ravi Pratap <ravi@ximian.com>
22167 * class.cs (Indexer.DefineMethod): Incorporate the interface
22168 type in the name of the method if we are doing explicit interface
22171 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22173 (BetterConversion): Fix extremely trivial bug where we were referring to
22174 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22177 * ../errors/bug16.cs : Add although we have fixed it.
22179 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22181 * expression.cs (BaseIndexer): Begin implementation.
22183 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22185 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22186 production directly to remove a shift/reduce, and implement
22187 explicit interface implementation.
22189 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22190 after a floating point suffix.
22192 * expression.cs (DoNumericPromotions): Improved the conversion for
22193 uint/uint. If we have a constant, we avoid doing a typecast to a
22196 * class.cs (Indexer): Implement explicit interface implementation
22199 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22201 * class.cs: make the default instance constructor public and hidebysig.
22203 2001-01-03 Ravi Pratap <ravi@ximian.com>
22205 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22206 so we can call it from elsewhere.
22208 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22209 we emit it internally if the class has a defined indexer; otherwise the user
22210 emits it by decorating the class definition with the DefaultMemberAttribute.
22212 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22213 attribute is not used on a type which defines an indexer.
22215 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22216 character when we skip whitespace.
22218 * ../errors/cs0646.cs : Add.
22220 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22222 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22225 * makefile: Add practical target `mcs3.exe' which builds the third
22226 generation compiler.
22228 * expression.cs (New): Fix structures constructor calling.
22230 * class.cs (Property, Method, Indexer): Emit Final flag on the
22231 method if we are an interface implementation and we are not
22234 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22235 whether this property is referencing a `base' method.
22237 * expression.cs (Invocation.EmitCall): take an extra argument:
22238 is_base, this is used to determine whether the `call' or
22239 `callvirt' opcode should be used.
22242 * delegate.cs: update EmitCall.
22244 * class.cs (Method.Define): Set NewSlot for the cases where we are
22245 not implementing an interface method.
22247 (Property.Define): ditto.
22249 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22251 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22252 'r'. Allows mcs to parse itself fully.
22254 2002-01-02 Ravi Pratap <ravi@ximian.com>
22256 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22257 of the number of initializers that require the InitializeArray method.
22259 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22260 update the above field where necessary.
22262 (MakeByteBlob): Update accordingly.
22264 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22267 (EmitDynamicInitializers): Update in accordance with the new optimization.
22269 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22270 same OpCode applies.
22272 * cs-parser.jay : Fix some glaring errors I introduced.
22274 2002-01-01 Ravi Pratap <ravi@ximian.com>
22276 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22277 so that we can check for name clashes there too.
22279 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22280 for interface indexers.
22282 * interfaces.cs (Define): Emit the default member attribute.
22284 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22285 variable was being referred to while setting the value ;-)
22287 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22289 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22290 byte-by-byte information when we know the data is zero.
22292 Make the block always a multiple of 4, because
22293 DefineInitializedData has a bug.
22295 * assign.cs: Fix, we should assign from the temporary, not from
22298 * expression.cs (MakeByteBlob): Fix my incorrect code.
22300 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22302 * typemanager.cs (EnumToUnderlying): This function is used to get
22303 the underlying type from an enumeration, because it does not
22306 * constant.cs: Use the I4_S form for values between -128 and 127.
22308 * statement.cs (Block.LookupLabel): Looks up a label.
22309 (Block): Drop support for labeled blocks.
22311 (LabeledStatement): New kind of statement that represents a label
22314 (Goto): Finally implement this bad boy.
22316 * cs-parser.jay: Update to reflect new mechanism to implement
22319 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22321 * codegen.cs (EmitContext.This): a codegen property that keeps the
22322 a single instance of this instead of creating many different this
22325 * delegate.cs (Delegate.DoResolve): Update to use the property;
22327 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22329 * expression.cs (BaseAccess.DoResolve): Ditto.
22331 2001-12-29 Ravi Pratap <ravi@ximian.com>
22333 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22334 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22336 (InitCoreTypes): Update accordingly.
22338 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22339 so we can quickly store the state.
22341 (ApplyAttributes): Set the correct implementation flags
22342 for InternalCall methods.
22344 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22346 * expression.cs (EmitCall): if a method is not virtual, then do
22347 not use callvirt on it.
22349 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22350 user defined stuff) requires the use of stobj, which takes an
22351 address on the stack instead of an array and an index. So emit
22352 the Ldelema operation for it.
22354 (EmitStoreOpcode): Use stobj for valuetypes.
22356 (UnaryMutator.EmitCode): Use the right 1 value depending on
22357 whether we are dealing with int64/uint64, float or doubles.
22359 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22360 constructors that I implemented last night.
22362 (Constructor.IsDefault): Fix to work properly for static
22365 * cs-parser.jay (CheckDef): report method signature errors.
22366 Update error number 103 to be 132.
22368 * decl.cs: New AdditionResult enumeration value: MethodExists.
22369 Although we do this check for methods later on in the semantic
22370 analysis, catching repeated default constructors is so easy that
22371 we catch these here.
22373 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22376 (ParameterReference.EmitAssign, Emit): handle
22379 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22380 (ArrayAccess.EmitStoreOpcode): ditto.
22382 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22384 * expression.cs (MakeByteBlob): Complete all the missing types
22385 (uint, short, ushort, byte, sbyte)
22387 * class.cs: Only init instance field initializers on instance
22390 Rename `constructors' to instance_constructors.
22392 (TypeContainer.AddConstructor): Only add constructors to the list
22393 if it is not static.
22395 Make sure that we handle default_static_constructor independently
22396 everywhere where we handle instance_constructors
22398 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22400 * class.cs: Do not lookup or create a base initializer for a
22401 static constructor.
22403 (ConstructorInitializer.Resolve): use the proper type to lookup
22406 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22408 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22411 * decl.cs: CloseType is now an virtual method, the default
22412 implementation just closes this type.
22414 2001-12-28 Ravi Pratap <ravi@ximian.com>
22416 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22417 to PreserveSig by default. Also emit HideBySig on such methods.
22419 Basically, set the defaults to standard values.
22421 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22422 argument, if candidate is better, it can't be worse than the best !
22424 (Invocation): Re-write bits to differentiate between methods being
22425 applicable in their expanded form and their normal form - for params
22428 Get rid of use_standard everywhere as only standard conversions are allowed
22429 in overload resolution.
22431 More spec conformance.
22433 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22435 * driver.cs: Add --timestamp, to see where the compiler spends
22438 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22439 `this' in static code.
22441 (SimpleName.DoResolve): Implement in terms of a helper function
22442 that allows static-references to be passed upstream to
22445 (Expression.ResolveWithSimpleName): Resolve specially simple
22446 names when called by MemberAccess to implement the special
22449 (Expression.ImplicitReferenceConversion): Handle conversions from
22450 Null to reference types before others, as Null's type is
22453 * expression.cs (Invocation.EmitCall): Handle the special case of
22454 calling methods declared on a reference type from a ValueType
22455 (Base classes System.Object and System.Enum)
22457 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22458 the left hand side is a TypeExpr, not on every enumeration.
22460 (Binary.Resolve): If types are reference types, then do a cast to
22461 object on operators != and == of both arguments.
22463 * typemanager.cs (FindMembers): Extract instance and static
22464 members if requested.
22466 * interface.cs (PopulateProperty): Use void_type instead of null
22467 as the return type for the setter method.
22469 (PopulateIndexer): ditto.
22471 2001-12-27 Ravi Pratap <ravi@ximian.com>
22473 * support.cs (ReflectionParameters): Fix minor bug where we
22474 were examining the wrong parameter for the ParamArray attribute.
22476 Cope with requests for the type of the parameter at position
22477 greater than the params parameter's. We now return the element
22478 type of the params array as that makes more sense.
22480 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22481 accordingly as we no longer have to extract the element type
22484 (Invocation.OverloadResolve): Update.
22486 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22488 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22489 against IEnumerator, test whether the return value is a descendant
22490 of the IEnumerator interface.
22492 * class.cs (Indexer.Define): Use an auxiliary method to implement
22493 the other bits of the method definition. Begin support for
22494 explicit interface implementation.
22496 (Property.DefineMethod): Use TypeManager.void_type instead of null
22497 for an empty return value.
22499 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22501 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22502 dealing with a FieldExpr which is composed of a FieldBuilder, in
22503 the code path we did extract the constant, but we should have
22504 obtained the underlying value to be able to cast it (otherwise we
22505 end up in an infinite loop, this is what Ravi was running into).
22507 (ArrayCreation.UpdateIndices): Arrays might be empty.
22509 (MemberAccess.ResolveMemberAccess): Add support for section
22510 14.5.4.1 that deals with the special case of E.I when E is a type
22511 and something else, that I can be a reference to a static member.
22513 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22514 handle a particular array type to create byte blobs, it is just
22515 something we dont generate byteblobs for.
22517 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22520 * location.cs (Push): remove the key from the hashtable that we
22521 are about to add. This happens for empty files.
22523 * driver.cs: Dispose files after we have parsed them.
22525 (tokenize): new function that only runs the tokenizer on its
22526 input, for speed testing.
22528 2001-12-26 Ravi Pratap <ravi@ximian.com>
22530 * class.cs (Event.Define): Define the private field only if there
22531 are no accessors defined.
22533 * expression.cs (ResolveMemberAccess): If there is no associated
22534 field with the event, that means we have an event defined with its
22535 own accessors and we should flag error cs0070 since transforming
22536 ourselves into a field is not valid in that case.
22538 * ecore.cs (SimpleName.DoResolve): Same as above.
22540 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22541 and charset to sane values.
22543 2001-12-25 Ravi Pratap <ravi@ximian.com>
22545 * assign.cs (DoResolve): Perform check on events only if they
22546 are being accessed outside the declaring type.
22548 * cs-parser.jay (event_declarations): Update rules to correctly
22549 set the type of the implicit parameter etc.
22551 (add_accessor, remove_accessor): Set current local parameters.
22553 * expression.cs (Binary): For delegate addition and subtraction,
22554 cast the return value from the method into the appropriate delegate
22557 2001-12-24 Ravi Pratap <ravi@ximian.com>
22559 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22560 of these as the workaround is unnecessary.
22562 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22563 delegate data - none of that is needed at all.
22565 Re-write bits to extract the instance expression and the delegate method
22568 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22571 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22572 of attaching attributes instead of duplicating code everywhere.
22574 * everywhere : Update code to do attribute emission using the above method.
22576 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22578 * expression.cs (IsParamsMethodApplicable): if there are not
22579 parameters, return immediately.
22581 * ecore.cs: The 0 literal can be implicity converted to an enum
22584 (SimpleName.DoResolve): First lookup the type, then lookup the
22587 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22588 want to get its address. If the InstanceExpression is not
22589 addressable, store the result in a temporary variable, then get
22592 * codegen.cs: Only display 219 errors on warning level or above.
22594 * expression.cs (ArrayAccess): Make it implement the
22595 IMemoryLocation interface.
22597 (Binary.DoResolve): handle the operator == (object a, object b)
22598 and operator != (object a, object b) without incurring into a
22599 BoxedCast (because 5 != o should never be performed).
22601 Handle binary enumerator operators.
22603 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22604 value type, otherwise use Ldelem_ref.
22606 Use precomputed names;
22608 (AddressOf): Implement address of
22610 * cs-parser.jay (labeled_statement): Fix recursive block
22611 addition by reworking the production.
22613 * expression.cs (New.DoEmit): New has a special case:
22615 If we are dealing with a ValueType, we have a few
22616 situations to deal with:
22618 * The target of New is a ValueType variable, that is
22619 easy, we just pass this as the variable reference
22621 * The target of New is being passed as an argument,
22622 to a boxing operation or a function that takes a
22625 In this case, we need to create a temporary variable
22626 that is the argument of New.
22629 2001-12-23 Ravi Pratap <ravi@ximian.com>
22631 * rootcontext.cs (LookupType): Check that current_type is not null before
22632 going about looking at nested types.
22634 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22635 not implement the IAssignMethod interface any more.
22637 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22638 where we tranform them into FieldExprs if they are being resolved from within
22639 the declaring type.
22641 * ecore.cs (SimpleName.DoResolve): Do the same here.
22643 * assign.cs (DoResolve, Emit): Clean up code considerably.
22645 * ../errors/bug10.cs : Add.
22647 * ../errors/cs0070.cs : Add.
22649 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22651 * assign.cs : Get rid of EventIsLocal everywhere.
22653 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22655 * ecore.cs (ConvertIntLiteral): finished the implementation.
22657 * statement.cs (SwitchLabel): Convert the value we are using as a
22658 key before looking up the table.
22660 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22662 * codegen.cs (EmitTopBlock): Require a Location argument now.
22664 * cs-parser.jay (constructor_declarator): We need to setup
22665 current_local_parameters before we parse the
22666 opt_constructor_initializer, to allow the variables to be bound
22667 to the constructor arguments.
22669 * rootcontext.cs (LookupType): First lookup nested classes in our
22670 class and our parents before we go looking outside our class.
22672 * expression.cs (ConstantFold): Extract/debox the values at the
22675 * rootcontext.cs (EmitCode): Resolve the constants first before we
22676 resolve the types. This is not really needed, but it helps debugging.
22678 * statement.cs: report location.
22680 * cs-parser.jay: pass location to throw statement.
22682 * driver.cs: Small bug fix.
22684 * report.cs: Updated format to be 4-zero filled digits.
22686 2001-12-22 Ravi Pratap <ravi@ximian.com>
22688 * expression.cs (CheckIndices): Fix minor bug where the wrong
22689 variable was being referred to ;-)
22691 (DoEmit): Do not call EmitStaticInitializers when the
22692 underlying type is System.Object.
22694 2001-12-21 Ravi Pratap <ravi@ximian.com>
22696 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22697 and do the usual workaround for SRE.
22699 * class.cs (MyEventBuilder.EventType): New member to get at the type
22700 of the event, quickly.
22702 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22704 * assign.cs (Assign.DoResolve): Handle the case when the target
22705 is an EventExpr and perform the necessary checks.
22707 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22710 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22712 (EventExpr): Set the type in the constructor itself since we
22713 are meant to be born fully resolved.
22715 (EventExpr.Define): Revert code I wrote earlier.
22717 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22718 instance expression is null. The instance expression is a This in that case
22719 or a null, depending on whether it is a static method or not.
22721 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22722 refers to more than one method.
22724 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22725 and accordingly flag errors.
22727 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22729 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22731 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22733 * location.cs (ToString): Provide useful rutine.
22735 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22737 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22738 objects, return the actual integral boxed.
22740 * statement.cs (SwitchLabel): define an ILLabel for each
22743 (Switch.CheckSwitch): If the value is a Literal, extract
22744 the underlying literal.
22746 Also in the unused hashtable we had, add the SwitchLabel so we can
22747 quickly look this value up.
22749 * constant.cs: Implement a bunch of new constants. Rewrite
22750 Literal based on this. Made changes everywhere to adapt to this.
22752 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22753 dereferencing array only once, and also copes with enumrations.
22755 bytes are two bytes wide, not one.
22757 (Cast): Perform constant conversions.
22759 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22760 wrappers to the literals here.
22762 * expression.cs (DoNumericPromotions): long literals can converted
22763 to ulong implicity (this is taken care of elsewhere, but I was
22764 missing this spot).
22766 * ecore.cs (Expression.Literalize): Make the return type Literal,
22767 to improve type checking.
22769 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
22771 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22773 * literal.cs: Revert code from ravi that checked the bounds. The
22774 bounds are sane by the definition of the type itself.
22776 * typemanager.cs: Fix implementation of ImplementsInterface. We
22777 need to actually look up in our parent hierarchy for interfaces
22780 * const.cs: Use the underlying type for enumerations
22782 * delegate.cs: Compute the basename for the delegate creation,
22783 that should fix the delegate test case, and restore the correct
22784 Type Lookup semantics in rootcontext
22786 * rootcontext.cs: Revert Ravi's last patch. The correct way of
22787 referencing a nested type with the Reflection API is using the "+"
22790 * cs-parser.jay: Do not require EOF token at the end.
22792 2001-12-20 Ravi Pratap <ravi@ximian.com>
22794 * rootcontext.cs (LookupType): Concatenate type names with
22795 a '.' instead of a '+' The test suite passes again.
22797 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
22798 field of the enumeration.
22800 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
22801 the case when the member is an EventExpr.
22803 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
22804 static has an associated instance expression.
22806 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
22808 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
22810 * class.cs (Event.Define): Register event and perform appropriate checks
22813 We define the Add and Remove methods even if the use provides none because
22814 in that case, we provide default implementations ourselves.
22816 Define a private field of the type of the event. This is done by the CSC compiler
22817 and we should be doing it too ;-)
22819 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
22820 More methods we use in code we generate.
22822 (multicast_delegate_type, delegate_type): Two separate types since the distinction
22825 (InitCoreTypes): Update accordingly for the above.
22827 * class.cs (Event.Emit): Generate code for default accessors that we provide
22829 (EmitDefaultMethod): Do the job in the above.
22831 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
22834 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22836 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
22837 builders even if we were missing one.
22839 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
22840 pass the Basename as our class name instead of the Name. The
22841 basename will be correctly composed for us.
22843 * parameter.cs (Paramters): Now takes a Location argument.
22845 * decl.cs (DeclSpace.LookupType): Removed convenience function and
22846 make all the code call directly LookupType in RootContext and take
22847 this chance to pass the Location information everywhere.
22849 * Everywhere: pass Location information.
22851 2001-12-19 Miguel de Icaza <miguel@ximian.com>
22853 * class.cs (Constructor.Define): Updated way of detecting the
22854 length of the parameters.
22856 (TypeContainer.DefineType): Use basename as the type name for
22859 (TypeContainer.Define): Do not recursively define types here, as
22860 definition is taken care in order by the RootContext.
22862 * tree.cs: Keep track of namespaces in a per-file basis.
22864 * parameter.cs (Parameter.ComputeSignature): Update to use
22867 (Parameters.GetSignature): ditto.
22869 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
22870 instead of a TypeContainer.
22872 (Interface.SemanticAnalysis): Use `this' instead of our parent to
22873 resolve names. Because we need to be resolve in our context, not
22876 * driver.cs: Implement response files.
22878 * class.cs (TypeContainer.DefineType): If we are defined, do not
22879 redefine ourselves.
22881 (Event.Emit): Emit the code for add/remove handlers.
22882 (Event.Define): Save the MethodBuilders for add/remove.
22884 * typemanager.cs: Use pair here too.
22886 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
22887 DictionaryEntry requires the first argument to be non-null.
22889 (enum_declaration): Compute full name for registering the
22892 (delegate_declaration): Instead of using
22893 formal_parameter_list, use opt_formal_parameter_list as the list
22896 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
22897 (EventParsing): New property that controls whether `add' and
22898 `remove' are returned as tokens or identifiers (for events);
22900 2001-12-19 Ravi Pratap <ravi@ximian.com>
22902 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
22903 use MyEventBuilder only and let it wrap the real builder for us.
22905 (MyEventBuilder): Revamp constructor etc.
22907 Implement all operations that we perform on EventBuilder in precisely the same
22910 (FindMembers): Update to use the EventBuilder member.
22912 (Event.Emit): Update accordingly.
22914 2001-12-18 Ravi Pratap <ravi@ximian.com>
22916 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
22917 by calling the appropriate methods.
22919 (GetCustomAttributes): Make stubs as they cannot possibly do anything
22922 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
22924 2001-12-17 Ravi Pratap <ravi@ximian.com>
22926 * delegate.cs (Delegate.Populate): Check that the return type
22927 and various parameters types are indeed accessible.
22929 * class.cs (Constructor.Define): Same here.
22931 (Field.Define): Ditto.
22933 (Event.Define): Ditto.
22935 (Operator.Define): Check that the underlying Method defined itself
22936 correctly - so it's MethodBuilder should not be null.
22938 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
22939 expression happens to be null.
22941 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
22942 members but as of now we don't seem to be able to do anything really useful with it.
22944 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
22945 not the EventBuilder.
22947 2001-12-18 Miguel de Icaza <miguel@ximian.com>
22949 * cs-tokenizer.cs: Add support for defines.
22950 Add support for #if, #elif, #else, #endif
22952 (eval_var): evaluates a variable.
22953 (eval): stubbed for evaluating functions.
22955 * cs-parser.jay: Pass the defines information
22957 * driver.cs: Add --define command line option.
22959 * decl.cs: Move MemberCore here.
22961 Make it the base class for DeclSpace. This allows us to catch and
22962 report 108 and 109 for everything now.
22964 * class.cs (TypeContainer.Define): Extract all the members
22965 before populating and emit the warning 108 (new keyword required
22966 to override) instead of having each member implement this.
22968 (MemberCore.Define): New abstract method, we will be using this in
22969 the warning reporting engine in Populate.
22971 (Operator.Define): Adjust to new MemberCore protocol.
22973 * const.cs (Const): This does not derive from Expression, it is a
22974 temporary object we use to create fields, it is a MemberCore.
22976 * class.cs (Method.Define): Allow the entry point to be in a
22979 * driver.cs: Rewrite the argument handler to clean it up a bit.
22981 * rootcontext.cs: Made it just an auxiliary namespace feature by
22982 making everything static.
22984 * driver.cs: Adapt code to use RootContext type name instead of
22987 * delegate.cs: Remove RootContext argument.
22989 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
22992 * class.cs (Event.Define): The lookup can fail.
22994 * cs-tokenizer.cs: Begin implementation of pre-procesor.
22996 * expression.cs: Resolve the this instance before invoking the code.
22998 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23000 * cs-parser.jay: Add a production in element_access that allows
23001 the thing to become a "type" reference. This way we can parse
23002 things like "(string [])" as a type.
23004 Note that this still does not handle the more complex rules of
23008 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
23010 * ecore.cs: (CopyNewMethods): new utility function used to
23011 assemble the list of methods from running FindMembers.
23013 (MemberLookup): Rework FindMembers so that
23015 2001-12-16 Miguel de Icaza <miguel@ximian.com>
23017 * class.cs (TypeContainer): Remove Delegates who fail to be
23020 * delegate.cs (Populate): Verify that we dont get null return
23021 values. TODO: Check for AsAccessible.
23023 * cs-parser.jay: Use basename to emit error 574 (destructor should
23024 have the same name as container class), not the full name.
23026 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
23027 possible representation.
23029 Also implements integer type suffixes U and L.
23031 2001-12-15 Miguel de Icaza <miguel@ximian.com>
23033 * expression.cs (ArrayCreation.DoResolve): We need to do the
23034 argument resolution *always*.
23036 * decl.cs: Make this hold the namespace. Hold the root context as
23038 (LookupType): Move here.
23040 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
23042 * location.cs (Row, Name): Fixed the code, it was always returning
23043 references to the first file.
23045 * interface.cs: Register properties defined through interfaces.
23047 * driver.cs: Add support for globbing on the command line
23049 * class.cs (Field): Make it derive from MemberCore as well.
23052 2001-12-15 Ravi Pratap <ravi@ximian.com>
23054 * class.cs (Event::Define): Check that the type of the event is a delegate
23055 type else flag error #66.
23057 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
23060 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
23061 values of EntryPoint, CharSet etc etc.
23063 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
23065 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
23066 be null and we should ignore this. I am not sure if this is really clean. Apparently,
23067 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
23068 which needs this to do its work.
23070 * ../errors/cs0066.cs : Add.
23072 2001-12-14 Miguel de Icaza <miguel@ximian.com>
23074 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
23077 * class.cs: (MethodSignature.MethodSignature): Removed hack that
23078 clears out the parameters field.
23079 (MemberSignatureCompare): Cleanup
23081 (MemberCore): New base class used to share code between MethodCore
23084 (RegisterRequiredImplementations) BindingFlags.Public requires
23085 either BindingFlags.Instace or Static. Use instance here.
23087 (Property): Refactored code to cope better with the full spec.
23089 * parameter.cs (GetParameterInfo): Return an empty array instead
23092 * class.cs (Property): Abstract or extern properties have no bodies.
23094 * parameter.cs (GetParameterInfo): return a zero-sized array.
23096 * class.cs (TypeContainer.MethodModifiersValid): Move all the
23097 method modifier validation to the typecontainer so we can reuse
23098 this on properties.
23100 (MethodCore.ParameterTypes): return an empty sized array of types.
23102 (Property.Define): Test property modifier validity.
23104 Add tests for sealed/override too.
23106 (Method.Emit): abstract or extern methods have no bodies.
23108 2001-12-14 Ravi Pratap <ravi@ximian.com>
23110 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
23113 (Method::Define, ::Emit): Modify accordingly.
23115 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
23117 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
23119 * makefile: Pass in /unsafe.
23121 2001-12-13 Miguel de Icaza <miguel@ximian.com>
23123 * class.cs (MakeKey): Kill routine.
23125 * class.cs (TypeContainer.Define): Correctly define explicit
23126 method implementations (they require the full interface name plus
23129 * typemanager.cs: Deply the PtrHashtable here and stop using the
23130 lame keys. Things work so much better.
23132 This of course broke everyone who depended on `RegisterMethod' to
23133 do the `test for existance' test. This has to be done elsewhere.
23135 * support.cs (PtrHashtable): A hashtable that avoid comparing with
23136 the object stupid Equals method (because, that like fails all over
23137 the place). We still do not use it.
23139 * class.cs (TypeContainer.SetRequiredInterface,
23140 TypeContainer.RequireMethods): Killed these two routines and moved
23141 all the functionality to RegisterRequiredImplementations.
23143 (TypeContainer.RegisterRequiredImplementations): This routine now
23144 registers all the implementations required in an array for the
23145 interfaces and abstract methods. We use an array of structures
23146 which can be computed ahead of time to reduce memory usage and we
23147 also assume that lookups are cheap as most classes will not
23148 implement too many interfaces.
23150 We also avoid creating too many MethodSignatures.
23152 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23153 clear the "pending" bit if we find that there are problems with
23156 (TypeContainer.VerifyPendingMethods): Update to report errors of
23157 methods that look like implementations but are not.
23159 (TypeContainer.Define): Add support for explicit interface method
23162 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23164 * typemanager.cs: Keep track of the parameters here instead of
23165 being a feature of the TypeContainer.
23167 * class.cs: Drop the registration of parameters here, as
23168 InterfaceMethods are also interface declarations.
23170 * delegate.cs: Register methods with the TypeManager not only with
23171 the TypeContainer. This code was buggy.
23173 * interface.cs: Full registation here.
23175 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23177 * expression.cs: Remove reducer for binary expressions, it can not
23180 * const.cs: Put here the code that used to go into constant.cs
23182 * constant.cs: Put here the code for constants, this is a new base
23183 class for Literals.
23185 * literal.cs: Make Literal derive from Constant.
23187 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23189 * statement.cs (Return.Emit): Report error 157 if the user
23190 attempts to return from a finally block.
23192 (Return.Emit): Instead of emitting a return, jump to the end of
23195 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23196 LocalBuilder to store the result of the function. ReturnLabel is
23197 the target where we jump.
23200 2001-12-09 Radek Doulik <rodo@ximian.com>
23202 * cs-parser.jay: remember alias in current namespace
23204 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23207 * class.cs (LookupAlias): lookup alias in my_namespace
23209 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23211 (LookupAlias): lookup alias in this and if needed in parent
23214 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23218 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23219 making things static. I need this to avoid passing the
23220 TypeContainer when calling ParameterType.
23222 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23223 that did string manipulation to compute the type and then call
23224 GetType. Use Parameter.ParameterType instead.
23226 * cs-tokenizer.cs: Consume the suffix for floating values.
23228 * expression.cs (ParameterReference): figure out whether this is a
23229 reference parameter or not. Kill an extra variable by computing
23230 the arg_idx during emission.
23232 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23233 function that returns whether a parameter is an out/ref value or not.
23235 (Parameter.ParameterType): The type of the parameter (base,
23236 without ref/out applied).
23238 (Parameter.Resolve): Perform resolution here.
23239 (Parameter.ExternalType): The full type (with ref/out applied).
23241 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23242 support for expressions on the using statement.
23244 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23246 * statement.cs (Using.EmitLocalVariableDecls): Split the
23247 localvariable handling of the using statement.
23249 (Block.EmitMeta): Keep track of variable count across blocks. We
23250 were reusing slots on separate branches of blocks.
23252 (Try.Emit): Emit the general code block, we were not emitting it.
23254 Check the type of the declaration to be an IDisposable or
23255 something that can be implicity converted to it.
23257 Emit conversions if required.
23259 * ecore.cs (EmptyExpression): New utility class.
23260 (Expression.ImplicitConversionExists): New utility function.
23262 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23264 * statement.cs (Using): Implement.
23266 * expression.cs (LocalVariableReference): Support read only variables.
23268 * statement.cs: Remove the explicit emit for the Leave opcode.
23269 (VariableInfo): Add a readonly field.
23271 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23273 * ecore.cs (ConvCast): new class used to encapsulate the various
23274 explicit integer conversions that works in both checked and
23275 unchecked contexts.
23277 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23278 properly generate the overflow opcodes.
23280 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23282 * statement.cs: The correct type for the EmptyExpression is the
23283 element_type, not the variable type. Ravi pointed this out.
23285 2001-12-04 Ravi Pratap <ravi@ximian.com>
23287 * class.cs (Method::Define): Handle PInvoke methods specially
23288 by using DefinePInvokeMethod instead of the usual one.
23290 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23291 above to do the task of extracting information and defining the method.
23293 2001-12-04 Ravi Pratap <ravi@ximian.com>
23295 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23296 of the condition for string type.
23298 (Emit): Move that here.
23300 (ArrayCreation::CheckIndices): Keep string literals in their expression
23303 (EmitDynamicInitializers): Handle strings appropriately.
23305 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23307 * codegen.cs (EmitContext): Replace multiple variables with a
23308 single pointer to the current Switch statement.
23310 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23313 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23317 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23320 (Foreach.Emit): Foreach on arrays was not setting
23321 up the loop variables (for break/continue).
23323 (GotoCase): Semi-implented.
23325 2001-12-03 Ravi Pratap <ravi@ximian.com>
23327 * attribute.cs (CheckAttribute): Handle system attributes by using
23328 Attribute.GetAttributes to examine information we need.
23330 (GetValidPlaces): Same here.
23332 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23334 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23336 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23338 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23340 (Method::Emit): Handle the case when we are a PInvoke method.
23342 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23344 * expression.cs: Use ResolveWithSimpleName on compound names.
23346 2001-12-02 Ravi Pratap <ravi@ximian.com>
23348 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23349 before trying to reduce it.
23351 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23353 * constant.cs (LookupConstantValue): Implement.
23355 (EmitConstant): Use the above in emitting the constant.
23357 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23358 that are user-defined by doing a LookupConstantValue on them.
23360 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23363 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23365 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23367 (BaseAccess.DoResolve): Implement.
23369 (MemberAccess.DoResolve): Split this routine into a
23370 ResolveMemberAccess routine that can be used independently
23372 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23374 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23375 As that share bits of the implementation. Is returns a boolean,
23376 while As returns the Type that is being probed.
23378 2001-12-01 Ravi Pratap <ravi@ximian.com>
23380 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23381 instead of a Literal - much easier.
23383 (EnumInTransit): Remove - utterly useless :-)
23385 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23387 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23389 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23390 chain when we have no associated expression.
23392 2001-11-30 Ravi Pratap <ravi@ximian.com>
23394 * constant.cs (Define): Use Location while reporting the errror.
23396 Also emit a warning when 'new' is used and there is no inherited
23399 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23402 (LookupEnumValue): Implement to lookup an enum member's value and define it
23405 (Populate): Re-write accordingly to use the above routine.
23407 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23409 * expression.cs (This): Fix prototype for DoResolveLValue to
23410 override the base class DoResolveLValue.
23412 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23415 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23416 (we need to load the address of the field here). This fixes
23419 (FieldExpr.DoResolveLValue): Call the DoResolve
23420 function to initialize the Instance expression.
23422 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23423 correctly the GetEnumerator operation on a value type.
23425 * cs-parser.jay: Add more simple parsing error catches.
23427 * statement.cs (Switch): Add support for string switches.
23428 Handle null specially.
23430 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23432 2001-11-28 Ravi Pratap <ravi@ximian.com>
23434 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23436 (declare_local_constant): New helper function.
23438 * statement.cs (AddConstant): Keep a separate record of constants
23440 (IsConstant): Implement to determine if a variable is a constant.
23442 (GetConstantExpression): Implement.
23444 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23446 * statement.cs (IsVariableDefined): Re-write.
23448 2001-11-27 Ravi Pratap <ravi@ximian.com>
23450 * class.cs (TypeContainer::FindMembers): Look for constants
23451 in the case when we are looking for MemberTypes.Field
23453 * expression.cs (MemberAccess::DoResolve): Check that in the
23454 case we are a FieldExpr and a Literal, we are not being accessed
23455 by an instance reference.
23457 * cs-parser.jay (local_constant_declaration): Implement.
23459 (declaration_statement): Implement for constant declarations.
23461 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23463 * statement.cs (Switch): Catch double defaults.
23465 (Switch): More work on the switch() statement
23466 implementation. It works for integral values now, need to finish
23470 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23472 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23473 integer literals into other integer literals. To be used by
23476 2001-11-24 Ravi Pratap <ravi@ximian.com>
23478 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23481 (EmitDynamicInitializers): Cope with the above since we extract data
23482 directly from ArrayData now.
23484 (ExpectInitializers): Keep track of whether initializers are mandatory
23487 (Bounds): Make it a hashtable to prevent the same dimension being
23488 recorded for every element in that dimension.
23490 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23493 Also fix bug which was causing the indices to be emitted in the reverse
23496 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23498 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23499 unfinished. They do not work, because the underlying code is
23502 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23504 * cs-parser.jay: Remove bogus fixme.
23506 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23507 on Switch statement.
23509 2001-11-23 Ravi Pratap <ravi@ximian.com>
23511 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23514 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23515 parameter. Apparently, any expression is allowed.
23517 (ValidateInitializers): Update accordingly.
23519 (CheckIndices): Fix some tricky bugs thanks to recursion.
23521 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23522 I was being completely brain-dead.
23524 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23525 and re-write acordingly.
23527 (DelegateInvocation): Re-write accordingly.
23529 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23531 (MakeByteBlob): Handle types more correctly.
23533 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23534 initialization from expressions but it is incomplete because I am a complete
23537 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23539 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23540 on If. Basically, we have to return `true' (ie, we do return to
23541 our caller) only if both branches of the if return.
23543 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23544 short-circuit operators, handle them as short circuit operators.
23546 (Cast.DoResolve): Resolve type.
23547 (Cast.Cast): Take an expression as the target type.
23549 * cs-parser.jay (cast_expression): Remove old hack that only
23550 allowed a limited set of types to be handled. Now we take a
23551 unary_expression and we resolve to a type during semantic
23554 Use the grammar productions from Rhys to handle casts (this is
23555 not complete like Rhys syntax yet, we fail to handle that corner
23556 case that C# has regarding (-x), but we will get there.
23558 2001-11-22 Ravi Pratap <ravi@ximian.com>
23560 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23561 field which is an array type.
23563 * cs-parser.jay (declare_local_variables): Support array initialization too.
23565 * typemanager.cs (MakeKey): Implement.
23567 (everywhere): Use the above appropriately.
23569 * cs-parser.jay (for_statement): Update for array initialization while
23570 declaring variables.
23572 * ecore.cs : The error message was correct, it's the variable's names that
23573 were misleading ;-) Make the code more readable.
23575 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23576 the correct type etc.
23578 (ConvertExplicit): Handle Enum types by examining the underlying type.
23580 2001-11-21 Ravi Pratap <ravi@ximian.com>
23582 * parameter.cs (GetCallingConvention): Always return
23583 CallingConventions.Standard for now.
23585 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23587 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23588 and `r' after calling DoNumericPromotions.
23590 * ecore.cs: Fix error message (the types were in the wrong order).
23592 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23593 BindingFlags.Instance as well
23595 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23596 implicit int literal conversion in an empty cast so that we
23597 propagate the right type upstream.
23599 (UnboxCast): new class used to unbox value types.
23600 (Expression.ConvertExplicit): Add explicit type conversions done
23603 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23604 the target type before applying the implicit LongLiterals to ULong
23607 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23609 * cs-parser.jay (for_statement): Reworked the way For works: now
23610 we declare manually any variables that are introduced in
23611 for_initializer to solve the problem of having out-of-band code
23612 emition (that is what got for broken).
23614 (declaration_statement): Perform the actual variable declaration
23615 that used to be done in local_variable_declaration here.
23617 (local_variable_declaration): Do not declare anything, just pass
23618 the information on a DictionaryEntry
23620 2001-11-20 Ravi Pratap <ravi@ximian.com>
23622 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23623 re-write of the logic to now make it recursive.
23625 (UpdateIndices): Re-write accordingly.
23627 Store element data in a separate ArrayData list in the above methods.
23629 (MakeByteBlob): Implement to dump the array data into a byte array.
23631 2001-11-19 Ravi Pratap <ravi@ximian.com>
23633 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23636 * constant.cs (Define): Implement.
23638 (EmitConstant): Re-write fully.
23640 Pass in location info.
23642 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23645 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23646 DictionaryEntry since we need location info too.
23648 (constant_declaration): Update accordingly.
23650 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23651 code into another method : UpdateIndices.
23653 2001-11-18 Ravi Pratap <ravi@ximian.com>
23655 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23656 some type checking etc.
23658 2001-11-17 Ravi Pratap <ravi@ximian.com>
23660 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23661 bits to provide dimension info if the user skips doing that.
23663 Update second constructor to store the rank correctly.
23665 2001-11-16 Ravi Pratap <ravi@ximian.com>
23667 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23668 and try to implement.
23670 * ../errors/cs0150.cs : Add.
23672 * ../errors/cs0178.cs : Add.
23674 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23676 * statement.cs: Implement foreach on multi-dimensional arrays.
23678 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23679 name of the params argument.
23681 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23682 initializing the array.
23684 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23685 we can use this elsewhere.
23687 * statement.cs: Finish implementation of foreach for single
23690 * cs-parser.jay: Use an out-of-band stack to pass information
23691 around, I wonder why I need this.
23693 foreach_block: Make the new foreach_block the current_block.
23695 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23696 function used to return a static Parameters structure. Used for
23697 empty parameters, as those are created very frequently.
23699 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23701 2001-11-15 Ravi Pratap <ravi@ximian.com>
23703 * interface.cs : Default modifier is private, not public. The
23704 make verify test passes again.
23706 2001-11-15 Ravi Pratap <ravi@ximian.com>
23708 * support.cs (ReflectionParameters): Fix logic to determine
23709 whether the last parameter is a params one. Test 9 passes again.
23711 * delegate.cs (Populate): Register the builders we define with
23712 RegisterParameterForBuilder. Test 19 passes again.
23714 * cs-parser.jay (property_declaration): Reference $6 instead
23715 of $$ to get at the location.
23717 (indexer_declaration): Similar stuff.
23719 (attribute): Ditto.
23721 * class.cs (Property): Register parameters for the Get and Set methods
23722 if they exist. Test 23 passes again.
23724 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23725 call to EmitArguments as we are sure there aren't any params arguments.
23726 Test 32 passes again.
23728 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23729 IndexOutOfRangeException.
23731 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23732 Test 33 now passes again.
23734 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23736 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23737 broke a bunch of things. Will have to come up with a better way
23738 of tracking locations.
23740 * statement.cs: Implemented foreach for single dimension arrays.
23742 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23744 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23745 an error. This removes the lookup from the critical path.
23747 * cs-parser.jay: Removed use of temporary_loc, which is completely
23750 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23752 * support.cs (ReflectionParameters.ParameterModifier): Report
23753 whether the argument is a PARAMS argument or not.
23755 * class.cs: Set the attribute `ParamArrayAttribute' on the
23756 parameter argument.
23758 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23759 and cons_param_array_attribute (ConstructorInfo for
23760 ParamArrayAttribute).,
23762 * codegen.cs: Emit the return using the `Return' statement, that
23763 way we can report the error correctly for missing return values.
23765 * class.cs (Method.Emit): Clean up.
23767 * expression.cs (Argument.Resolve): Take another argument: the
23768 location where this argument is used. Notice that this is not
23769 part of the "Argument" class as to reduce the size of the
23770 structure (we know the approximate location anyways).
23772 Test if the argument is a variable-reference, if not, then
23773 complain with a 206.
23775 (Argument.Emit): Emit addresses of variables.
23777 (Argument.FullDesc): Simplify.
23779 (Invocation.DoResolve): Update for Argument.Resolve.
23781 (ElementAccess.DoResolve): ditto.
23783 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
23784 method should be virtual, as this method is always virtual.
23786 (NewDelegate.DoResolve): Update for Argument.Resolve.
23788 * class.cs (ConstructorInitializer.DoResolve): ditto.
23790 * attribute.cs (Attribute.Resolve): ditto.
23792 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23794 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
23796 * expression.cs (ParameterReference): Drop IStackStorage and implement
23797 IAssignMethod instead.
23799 (LocalVariableReference): ditto.
23801 * ecore.cs (FieldExpr): Drop IStackStorage and implement
23802 IAssignMethod instead.
23804 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23806 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
23807 enumerations that are used in heavily used structures derive from
23808 byte in a laughable and pathetic attempt to reduce memory usage.
23809 This is the kind of pre-optimzations that you should not do at
23810 home without adult supervision.
23812 * expression.cs (UnaryMutator): New class, used to handle ++ and
23813 -- separatedly from the other unary operators. Cleans up the
23814 code, and kills the ExpressionStatement dependency in Unary.
23816 (Unary): Removed `method' and `Arguments' from this class, making
23817 it smaller, and moving it all to SimpleCall, so I can reuse this
23818 code in other locations and avoid creating a lot of transient data
23819 strucutres when not required.
23821 * cs-parser.jay: Adjust for new changes.
23823 2001-11-11 Miguel de Icaza <miguel@ximian.com>
23825 * enum.cs (Enum.Populate): If there is a failure during
23828 * cs-parser.jay (opt_enum_base): we used to catch type errors
23829 here, but this is really incorrect. The type error should be
23830 catched during semantic analysis.
23832 2001-12-11 Ravi Pratap <ravi@ximian.com>
23834 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
23835 current_local_parameters as expected since I, in my stupidity, had forgotten
23838 * attribute.cs (GetValidPlaces): Fix stupid bug.
23840 * class.cs (Method::Emit): Perform check on applicability of attributes.
23842 (Constructor::Emit): Ditto.
23844 (Field::Emit): Ditto.
23846 (Field.Location): Store location information.
23848 (Property, Event, Indexer, Operator): Ditto.
23850 * cs-parser.jay (field_declaration): Pass in location for each field.
23852 * ../errors/cs0592.cs : Add.
23854 2001-11-12 Ravi Pratap <ravi@ximian.com>
23856 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
23858 (InitCoreTypes): Update accordingly.
23860 (RegisterAttrType, LookupAttr): Implement.
23862 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
23863 info about the same.
23865 (Resolve): Update to populate the above as necessary.
23867 (Error592): Helper.
23869 (GetValidPlaces): Helper to the above.
23871 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
23873 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
23875 2001-11-12 Ravi Pratap <ravi@ximian.com>
23877 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
23879 * ../errors/cs0617.cs : Add.
23881 2001-11-11 Ravi Pratap <ravi@ximian.com>
23883 * enum.cs (Emit): Rename to Populate to be more consistent with what
23884 we expect it to do and when exactly it is called.
23886 * class.cs, rootcontext.cs : Update accordingly.
23888 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
23889 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
23891 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
23893 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
23894 of a fieldinfo using the above, when dealing with a FieldBuilder.
23896 2001-11-10 Ravi Pratap <ravi@ximian.com>
23898 * ../errors/cs0031.cs : Add.
23900 * ../errors/cs1008.cs : Add.
23902 * ../errrors/cs0543.cs : Add.
23904 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
23907 (FindMembers): Implement.
23909 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
23910 enums and delegates too.
23912 (enum_types): Rename to builder_to_enum.
23914 (delegate_types): Rename to builder_to_delegate.
23916 * delegate.cs (FindMembers): Implement.
23918 2001-11-09 Ravi Pratap <ravi@ximian.com>
23920 * typemanager.cs (IsEnumType): Implement.
23922 * enum.cs (Emit): Re-write parts to account for the underlying type
23923 better and perform checking etc.
23925 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
23926 of the underlying type.
23928 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
23931 * enum.cs (error31): Helper to report error #31.
23933 * cs-parser.jay (enum_declaration): Store location of each member too.
23935 * enum.cs (member_to_location): New hashtable.
23937 (AddEnumMember): Update location hashtable.
23939 (Emit): Use the location of each member while reporting errors.
23941 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23943 * cs-parser.jay: A for_initializer if is a
23944 local_variable_declaration really ammount to have an implicit
23945 block with the variable declaration and no initializer for for.
23947 * statement.cs (For.Emit): Cope with null initializers.
23949 This fixes the infinite loop on for initializers.
23951 2001-11-08 Miguel de Icaza <miguel@ximian.com>
23953 * enum.cs: More cleanup.
23955 * ecore.cs: Remove dead code.
23957 * class.cs (Property.Emit): More simplification.
23958 (Event.Emit): ditto.
23960 Reworked to have less levels of indentation.
23962 2001-11-08 Ravi Pratap <ravi@ximian.com>
23964 * class.cs (Property): Emit attributes.
23974 * enum.cs (Emit): Ditto.
23976 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
23979 * class.cs (Field, Event, etc.): Move attribute generation into the
23980 Emit method everywhere.
23982 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
23983 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
23984 as we had no way of defining nested enums !
23986 * rootcontext.cs : Adjust code accordingly.
23988 * typemanager.cs (AddEnumType): To keep track of enum types separately.
23990 2001-11-07 Ravi Pratap <ravi@ximian.com>
23992 * expression.cs (EvalConstantExpression): Move into ecore.cs
23994 * enum.cs (Enum): Rename some members and make them public and readonly
23995 according to our convention.
23997 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24000 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
24002 (Enum::Emit): Write a simple version for now which doesn't try to compute
24003 expressions. I shall modify this to be more robust in just a while.
24005 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
24007 (TypeContainer::CloseType): Create the Enum types too.
24009 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
24011 * expression.cs (EvalConstantExpression): Get rid of completely.
24013 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
24014 user-defined values and other cases.
24016 (IsValidEnumLiteral): Helper function.
24018 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
24019 out there in the case we had a literal FieldExpr.
24021 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
24023 (Literalize): Revamp a bit to take two arguments.
24025 (EnumLiteral): New class which derives from Literal to wrap enum literals.
24027 2001-11-06 Ravi Pratap <ravi@ximian.com>
24029 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
24031 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
24033 (Resolve): Use the above to ensure we have proper initializers.
24035 2001-11-05 Ravi Pratap <ravi@ximian.com>
24037 * expression.cs (Expression::EvalConstantExpression): New method to
24038 evaluate constant expressions.
24040 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
24042 2001-11-07 Miguel de Icaza <miguel@ximian.com>
24044 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
24047 (Binary.ResolveOperator): Handle operator != (object a, object b)
24048 and operator == (object a, object b);
24050 (Binary.DoNumericPromotions): Indicate whether the numeric
24051 promotion was possible.
24053 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
24056 Made the ArrayAccess implement interface IAssignMethod instead of
24057 IStackStore as the order in which arguments are passed reflects
24060 * assign.cs: Instead of using expr.ExprClass to select the way of
24061 assinging, probe for the IStackStore/IAssignMethod interfaces.
24063 * typemanager.cs: Load InitializeArray definition.
24065 * rootcontext.cs (RootContext.MakeStaticData): Used to define
24066 static data that can be used to initialize arrays.
24068 2001-11-05 Miguel de Icaza <miguel@ximian.com>
24070 * expression.cs: Handle operator== and operator!= for booleans.
24072 (Conditioal.Reduce): Implement reducer for the ?: operator.
24074 (Conditional.Resolve): Implement dead code elimination.
24076 (Binary.Resolve): Catch string literals and return a new
24077 concatenated string.
24079 (Unary.Reduce): Implement reduction of unary expressions.
24081 * ecore.cs: Split out the expression core handling here.
24083 (Expression.Reduce): New method used to perform constant folding
24084 and CSE. This is needed to support constant-expressions.
24086 * statement.cs (Statement.EmitBoolExpression): Pass true and false
24087 targets, and optimize for !x.
24089 2001-11-04 Ravi Pratap <ravi@ximian.com>
24091 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
24092 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
24093 set custom atttributes.
24095 * literal.cs (Literal::GetValue): New abstract method to return the actual
24096 value of the literal, cast as an object.
24098 (*Literal): Implement GetValue method.
24100 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
24101 expressions to the arraylist but objects of type Argument.
24103 * class.cs (TypeContainer::Emit): Emit our attributes too.
24105 (Method::Emit, Constructor::Emit): Ditto.
24107 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
24108 to be ignoring earlier.
24110 2001-11-03 Ravi Pratap <ravi@ximian.com>
24112 * attribute.cs (AttributeSection::Define): Implement to do the business
24113 of constructing a CustomAttributeBuilder.
24115 (Attribute): New trivial class. Increases readability of code.
24117 * cs-parser.jay : Update accordingly.
24119 (positional_argument_list, named_argument_list, named_argument): New rules
24121 (attribute_arguments): Use the above so that we are more correct.
24123 2001-11-02 Ravi Pratap <ravi@ximian.com>
24125 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
24126 to perform all checks for a method with a params parameter.
24128 (Invocation::OverloadResolve): Update to use the above method and therefore
24129 cope correctly with params method invocations.
24131 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
24134 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
24135 constructors in our parent too because we can't afford to miss out on
24138 * attribute.cs (AttributeSection): New name for the class Attribute
24140 Other trivial changes to improve readability.
24142 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
24143 use the new class names.
24145 2001-11-01 Ravi Pratap <ravi@ximian.com>
24147 * class.cs (Method::Define): Complete definition for params types too
24149 (Indexer::Define): Ditto.
24151 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
24152 Cope everywhere with a request for info about the array parameter.
24154 2001-11-01 Ravi Pratap <ravi@ximian.com>
24156 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24158 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24159 local_variable_type to extract the string corresponding to the type.
24161 (local_variable_type): Fixup the action to use the new helper method.
24163 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24166 * expression.cs : Clean out code which uses the above.
24168 2001-10-31 Ravi Pratap <ravi@ximian.com>
24170 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24171 and bale out if necessary by returning a false.
24173 (RegisterProperty): Ditto.
24175 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24176 and print out appropriate error messages.
24178 * interface.cs (everywhere): Ditto.
24180 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24181 location to constructor.
24183 * class.cs (Property, Event, Indexer): Update accordingly.
24185 * ../errors/cs111.cs : Added.
24187 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24188 of a method, as laid down by the spec.
24190 (Invocation::OverloadResolve): Use the above method.
24192 2001-10-31 Ravi Pratap <ravi@ximian.com>
24194 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24195 now take a TypeContainer and a Parameters object.
24197 (ParameterData): Modify return type of ParameterModifier method to be
24198 Parameter.Modifier and not a string.
24200 (ReflectionParameters, InternalParameters): Update accordingly.
24202 * expression.cs (Argument::GetParameterModifier): Same here.
24204 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24205 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24206 symbol in it at all so maybe this is only for now.
24208 2001-10-30 Ravi Pratap <ravi@ximian.com>
24210 * support.cs (InternalParameters): Constructor now takes an extra argument
24211 which is the actual Parameters class.
24213 (ParameterDesc): Update to provide info on ref/out modifiers.
24215 * class.cs (everywhere): Update call to InternalParameters to pass in
24216 the second argument too.
24218 * support.cs (ParameterData): Add ParameterModifier, which is a method
24219 to return the modifier info [ref/out etc]
24221 (InternalParameters, ReflectionParameters): Implement the above.
24223 * expression.cs (Argument::ParameterModifier): Similar function to return
24224 info about the argument's modifiers.
24226 (Invocation::OverloadResolve): Update to take into account matching modifiers
24229 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24230 a new SetFormalParameters object which we pass to InternalParameters.
24232 2001-10-30 Ravi Pratap <ravi@ximian.com>
24234 * expression.cs (NewArray): Merge into the ArrayCreation class.
24236 2001-10-29 Ravi Pratap <ravi@ximian.com>
24238 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24239 NewUserdefinedArray into one as there wasn't much of a use in having
24242 * expression.cs (Argument): Change field's name to ArgType from Type.
24244 (Type): New readonly property which returns the proper type, taking into
24245 account ref/out modifiers.
24247 (everywhere): Adjust code accordingly for the above.
24249 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24250 whether we are emitting for a ref or out parameter.
24252 * expression.cs (Argument::Emit): Use the above field to set the state.
24254 (LocalVariableReference::Emit): Update to honour the flag and emit the
24257 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24259 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24261 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24263 (ReflectionParameters, InternalParameters): Implement the above method.
24265 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24268 (Invocation::FullMethodDesc): Ditto.
24270 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24272 * cs-parser.jay: Add extra production for the second form of array
24275 * expression.cs (ArrayCreation): Update to reflect the above
24278 * Small changes to prepare for Array initialization.
24280 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24282 * typemanager.cs (ImplementsInterface): interface might be null;
24283 Deal with this problem;
24285 Also, we do store negative hits on the cache (null values), so use
24286 this instead of calling t.GetInterfaces on the type everytime.
24288 2001-10-28 Ravi Pratap <ravi@ximian.com>
24290 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24292 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24293 split functionality out into different classes.
24295 (New::FormArrayType): Move into NewBuiltinArray.
24297 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24300 (NewBuiltinArray): New class to handle creation of built-in arrays.
24302 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24303 account creation of one-dimensional arrays.
24305 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24307 (NewUserdefinedArray::DoResolve): Implement.
24309 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24311 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24312 we maintain inside the TypeManager. This is necessary to perform lookups on the
24315 (LookupType): Update to perform GetType on the module builders too.
24317 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24319 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24321 2001-10-23 Ravi Pratap <ravi@ximian.com>
24323 * expression.cs (New::DoResolve): Implement guts of array creation.
24325 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24327 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24329 * expression.cs: Fix bug I introduced lsat night that broke
24332 (Expression.Resolve): Report a 246 error (can not resolve name)
24333 if we find a SimpleName in the stream.
24335 (Expression.ResolveLValue): Ditto.
24337 (Expression.ResolveWithSimpleName): This function is a variant of
24338 ResolveName, this one allows SimpleNames to be returned without a
24339 warning. The only consumer of SimpleNames is MemberAccess
24341 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24343 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24344 might arrive here. I have my doubts that this is correct.
24346 * statement.cs (Lock): Implement lock statement.
24348 * cs-parser.jay: Small fixes to support `lock' and `using'
24350 * cs-tokenizer.cs: Remove extra space
24352 * driver.cs: New flag --checked, allows to turn on integer math
24355 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24356 Threading.Monitor.Exit
24358 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24360 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24361 Expression Class to be IndexerAccess.
24363 Notice that Indexer::DoResolve sets the eclass to Value.
24365 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24367 * class.cs (TypeContainer::Emit): Emit code for indexers.
24369 * assign.cs (IAssignMethod): New interface implemented by Indexers
24370 and Properties for handling assignment.
24372 (Assign::Emit): Simplify and reuse code.
24374 * expression.cs (IndexerAccess, PropertyExpr): Implement
24375 IAssignMethod, clean up old code.
24377 2001-10-22 Ravi Pratap <ravi@ximian.com>
24379 * typemanager.cs (ImplementsInterface): New method to determine if a type
24380 implements a given interface. Provides a nice cache too.
24382 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24385 (ConvertReferenceExplicit): Ditto.
24387 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24388 various methods, with correct names etc.
24390 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24391 Operator.UnaryNegation.
24393 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24394 we have a unary plus or minus operator.
24396 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24399 * everywhere : update accordingly.
24401 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24404 * class.cs (Method::Define): For the case where we are implementing a method
24405 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24406 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24408 2001-10-21 Ravi Pratap <ravi@ximian.com>
24410 * interface.cs (FindMembers): Implement to work around S.R.E
24413 * typemanager.cs (IsInterfaceType): Implement.
24415 (FindMembers): Update to handle interface types too.
24417 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24418 use IsAssignableFrom as that is not correct - it doesn't work.
24420 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24421 and accordingly override EmitStatement.
24423 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24424 using the correct logic :-)
24426 2001-10-19 Ravi Pratap <ravi@ximian.com>
24428 * ../errors/cs-11.cs : Add to demonstrate error -11
24430 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24432 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24433 then pass this as a hint to ResolveLValue.
24435 * expression.cs (FieldExpr): Add Location information
24437 (FieldExpr::LValueResolve): Report assignment to readonly
24440 (Expression::ExprClassFromMemberInfo): Pass location information.
24442 (Expression::ResolveLValue): Add new method that resolves an
24445 (Expression::DoResolveLValue): Default invocation calls
24448 (Indexers): New class used to keep track of indexers in a given
24451 (IStackStore): Renamed from LValue, as it did not really describe
24452 what this did. Also ResolveLValue is gone from this interface and
24453 now is part of Expression.
24455 (ElementAccess): Depending on the element access type
24457 * typemanager.cs: Add `indexer_name_type' as a Core type
24458 (System.Runtime.CompilerServices.IndexerNameAttribute)
24460 * statement.cs (Goto): Take a location.
24462 2001-10-18 Ravi Pratap <ravi@ximian.com>
24464 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24465 if two delegates are compatible.
24467 (NewDelegate::DoResolve): Update to take care of the case when
24468 we instantiate a delegate from another delegate.
24470 * typemanager.cs (FindMembers): Don't even try to look up members
24471 of Delegate types for now.
24473 2001-10-18 Ravi Pratap <ravi@ximian.com>
24475 * delegate.cs (NewDelegate): New class to take care of delegate
24478 * expression.cs (New): Split the delegate related code out into
24479 the NewDelegate class.
24481 * delegate.cs (DelegateInvocation): New class to handle delegate
24484 * expression.cs (Invocation): Split out delegate related code into
24485 the DelegateInvocation class.
24487 2001-10-17 Ravi Pratap <ravi@ximian.com>
24489 * expression.cs (New::DoResolve): Implement delegate creation fully
24490 and according to the spec.
24492 (New::DoEmit): Update to handle delegates differently.
24494 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24495 because of which we were printing out arguments in reverse order !
24497 * delegate.cs (VerifyMethod): Implement to check if the given method
24498 matches the delegate.
24500 (FullDelegateDesc): Implement.
24502 (VerifyApplicability): Implement.
24504 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24505 delegate invocations too.
24507 (Invocation::Emit): Ditto.
24509 * ../errors/cs1593.cs : Added.
24511 * ../errors/cs1594.cs : Added.
24513 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24515 2001-10-16 Ravi Pratap <ravi@ximian.com>
24517 * typemanager.cs (intptr_type): Core type for System.IntPtr
24519 (InitCoreTypes): Update for the same.
24521 (iasyncresult_type, asynccallback_type): Ditto.
24523 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24526 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24529 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24530 the builders for the 4 members of a delegate type :-)
24532 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24535 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24537 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24539 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24541 * statement.cs (Break::Emit): Implement.
24542 (Continue::Emit): Implement.
24544 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24545 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24546 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24547 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24550 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24551 properties that track the label for the current loop (begin of the
24552 loop and end of the loop).
24554 2001-10-15 Ravi Pratap <ravi@ximian.com>
24556 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24557 use of emitting anything at all.
24559 * class.cs, rootcontext.cs : Get rid of calls to the same.
24561 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24563 (Populate): Define the constructor correctly and set the implementation
24566 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24569 (AddDelegateType): Implement.
24571 (IsDelegateType): Implement helper method.
24573 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24575 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24576 and accordingly handle it.
24578 * delegate.cs (Populate): Take TypeContainer argument.
24579 Implement bits to define the Invoke method. However, I still haven't figured out
24580 how to take care of the native int bit :-(
24582 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24583 Qualify the name of the delegate, not its return type !
24585 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24588 (StandardConversionExists): Checking for array types turns out to be recursive.
24590 (ConvertReferenceExplicit): Implement array conversion.
24592 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24594 2001-10-12 Ravi Pratap <ravi@ximian.com>
24596 * cs-parser.jay (delegate_declaration): Store the fully qualified
24597 name as it is a type declaration.
24599 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24602 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24603 as TypeContainer::DefineType.
24605 (Populate): Method in which all the definition of the various methods (Invoke)
24608 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24611 (CloseDelegate): Finally creates the delegate.
24613 * class.cs (TypeContainer::DefineType): Update to define delegates.
24614 (Populate, Emit and CloseType): Do the same thing here too.
24616 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24617 delegates in all these operations.
24619 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24621 * expression.cs: LocalTemporary: a new expression used to
24622 reference a temporary that has been created.
24624 * assign.cs: Handle PropertyAccess back here, so that we can
24625 provide the proper semantic access to properties.
24627 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24628 a few more explicit conversions.
24630 * modifiers.cs: `NEW' modifier maps to HideBySig.
24632 * expression.cs (PropertyExpr): Make this into an
24633 ExpressionStatement, and support the EmitStatement code path.
24635 Perform get/set error checking, clean up the interface.
24637 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24638 them into toplevel access objects.
24640 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24642 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24645 * typemanager.cs: Keep track here of our PropertyBuilders again to
24646 work around lameness in SRE.
24648 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24650 * expression.cs (LValue::LValueResolve): New method in the
24651 interface, used to perform a second resolution pass for LValues.
24653 (This::DoResolve): Catch the use of this in static methods.
24655 (This::LValueResolve): Implement.
24657 (This::Store): Remove warning, assigning to `this' in structures
24660 (Invocation::Emit): Deal with invocation of
24661 methods on value types. We need to pass the address to structure
24662 methods rather than the object itself. (The equivalent code to
24663 emit "this" for structures leaves the entire structure on the
24664 stack instead of a pointer to it).
24666 (ParameterReference::DoResolve): Compute the real index for the
24667 argument based on whether the method takes or not a `this' pointer
24668 (ie, the method is static).
24670 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24671 value types returned from functions when we need to invoke a
24672 method on the sturcture.
24675 2001-10-11 Ravi Pratap <ravi@ximian.com>
24677 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24678 defining the type in the Modulebuilder or Typebuilder. This is to take
24679 care of nested types which need to be defined on the TypeBuilder using
24680 DefineNestedMethod.
24682 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24683 methods in RootContext, only ported to be part of TypeContainer.
24685 (TypeContainer::GetInterfaceOrClass): Ditto.
24687 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24689 * interface.cs (Interface::DefineInterface): New method. Does exactly
24690 what RootContext.CreateInterface did earlier, only it takes care of nested types
24693 (Interface::GetInterfaces): Move from RootContext here and port.
24695 (Interface::GetInterfaceByName): Same here.
24697 * rootcontext.cs (ResolveTree): Re-write.
24699 (PopulateTypes): Re-write.
24701 * class.cs (TypeContainer::Populate): Populate nested types too.
24702 (TypeContainer::Emit): Emit nested members too.
24704 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24705 instead just use the name argument passed in as it is already fully
24708 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24709 to TypeContainer mapping to see if a type is user-defined.
24711 * class.cs (TypeContainer::CloseType): Implement.
24713 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24714 the default constructor.
24716 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24719 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24721 * interface.cs (CloseType): Create the type here.
24723 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24726 Remove all the methods which are now in TypeContainer.
24728 2001-10-10 Ravi Pratap <ravi@ximian.com>
24730 * delegate.cs (Define): Re-write bits to define the delegate
24733 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24735 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24737 * expression.cs (ImplicitReferenceConversion): handle null as well
24738 as a source to convert to any reference type.
24740 * statement.cs (Return): Perform any implicit conversions to
24741 expected return type.
24743 Validate use of return statement.
24745 * codegen.cs (EmitContext): Pass the expected return type here.
24747 * class.cs (Method, Constructor, Property): Pass expected return
24748 type to EmitContext.
24750 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24752 * expression.cs: Make DoResolve take an EmitContext instead of a
24755 Replaced `l' and `location' for `loc', for consistency.
24757 (Error, Warning): Remove unneeded Tc argument.
24759 * assign.cs, literal.cs, constant.cs: Update to new calling
24762 * codegen.cs: EmitContext now contains a flag indicating whether
24763 code is being generated in a static method or not.
24765 * cs-parser.jay: DecomposeQI, new function that replaces the old
24766 QualifiedIdentifier. Now we always decompose the assembled
24767 strings from qualified_identifier productions into a group of
24770 2001-10-08 Miguel de Icaza <miguel@ximian.com>
24772 * rootcontext.cs: Deal with field-less struct types correctly now
24773 by passing the size option to Define Type.
24775 * class.cs: Removed hack that created one static field.
24777 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24779 * statement.cs: Moved most of the code generation here.
24781 2001-10-09 Ravi Pratap <ravi@ximian.com>
24783 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
24786 (ElementAccess): Remove useless bits for now - keep checks as the spec
24789 2001-10-08 Ravi Pratap <ravi@ximian.com>
24791 * expression.cs (ElementAccess::DoResolve): Remove my crap code
24792 and start performing checks according to the spec.
24794 2001-10-07 Ravi Pratap <ravi@ximian.com>
24796 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
24797 rank_specifiers instead.
24799 (rank_specifiers): Change the order in which the rank specifiers are stored
24801 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
24803 * expression.cs (ElementAccess): Implement the LValue interface too.
24805 2001-10-06 Ravi Pratap <ravi@ximian.com>
24807 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
24808 except that user defined conversions are not included.
24810 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
24811 perform the conversion of the return type, if necessary.
24813 (New::DoResolve): Check whether we are creating an array or an object
24814 and accordingly do the needful.
24816 (New::Emit): Same here.
24818 (New::DoResolve): Implement guts of array creation.
24820 (New::FormLookupType): Helper function.
24822 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24824 * codegen.cs: Removed most of the code generation here, and move the
24825 corresponding code generation bits to the statement classes.
24827 Added support for try/catch/finalize and throw.
24829 * cs-parser.jay: Added support for try/catch/finalize.
24831 * class.cs: Catch static methods having the flags override,
24832 virtual or abstract.
24834 * expression.cs (UserCast): This user cast was not really doing
24835 what it was supposed to do. Which is to be born in fully resolved
24836 state. Parts of the resolution were being performed at Emit time!
24840 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24842 * expression.cs: Implicity convert the result from UserCast.
24844 2001-10-05 Ravi Pratap <ravi@ximian.com>
24846 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
24847 prevented it from working correctly.
24849 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
24850 merely ConvertImplicit.
24852 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24854 * typemanager.cs: Make the LookupTypeContainer function static,
24855 and not per-instance.
24857 * class.cs: Make static FindMembers (the one that takes a Type
24860 * codegen.cs: Add EmitForeach here.
24862 * cs-parser.jay: Make foreach a toplevel object instead of the
24863 inline expansion, as we need to perform semantic analysis on it.
24865 2001-10-05 Ravi Pratap <ravi@ximian.com>
24867 * expression.cs (Expression::ImplicitUserConversion): Rename to
24868 UserDefinedConversion.
24870 (Expression::UserDefinedConversion): Take an extra argument specifying
24871 whether we look for explicit user conversions too.
24873 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
24875 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
24877 (ExplicitUserConversion): Make it a call to UserDefinedConversion
24878 with the appropriate arguments.
24880 * cs-parser.jay (cast_expression): Record location too.
24882 * expression.cs (Cast): Record location info.
24884 (Expression::ConvertExplicit): Take location argument.
24886 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
24887 to determine if we are doing explicit conversions.
24889 (UserCast::Emit): Update accordingly.
24891 (Expression::ConvertExplicit): Report an error if everything fails.
24893 * ../errors/cs0030.cs : Add.
24895 2001-10-04 Miguel de Icaza <miguel@ximian.com>
24897 * modifiers.cs: If the ABSTRACT keyword is present, also set the
24898 virtual and newslot bits.
24900 * class.cs (TypeContainer::RegisterRequiredImplementations):
24901 Record methods we need.
24903 (TypeContainer::MakeKey): Helper function to make keys for
24904 MethodBases, since the Methodbase key is useless.
24906 (TypeContainer::Populate): Call RegisterRequiredImplementations
24907 before defining the methods.
24909 Create a mapping for method_builders_to_methods ahead of time
24910 instead of inside a tight loop.
24912 (::RequireMethods): Accept an object as the data to set into the
24913 hashtable so we can report interface vs abstract method mismatch.
24915 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24917 * report.cs: Make all of it static.
24919 * rootcontext.cs: Drop object_type and value_type computations, as
24920 we have those in the TypeManager anyways.
24922 Drop report instance variable too, now it is a global.
24924 * driver.cs: Use try/catch on command line handling.
24926 Add --probe option to debug the error reporting system with a test
24929 * report.cs: Add support for exiting program when a probe
24930 condition is reached.
24932 2001-10-03 Ravi Pratap <ravi@ximian.com>
24934 * expression.cs (Binary::DoNumericPromotions): Fix the case when
24935 we do a forcible conversion regardless of type, to check if
24936 ForceConversion returns a null.
24938 (Binary::error19): Use location to report error.
24940 (Unary::error23): Use location here too.
24942 * ../errors/cs0019.cs : Check in.
24944 * ../errors/cs0023.cs : Check in.
24946 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
24947 case of a non-null MethodInfo object with a length of 0 !
24949 (Binary::ResolveOperator): Flag error if overload resolution fails to find
24950 an applicable member - according to the spec :-)
24951 Also fix logic to find members in base types.
24953 (Unary::ResolveOperator): Same here.
24955 (Unary::report23): Change name to error23 and make first argument a TypeContainer
24956 as I was getting thoroughly confused between this and error19 :-)
24958 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
24959 (::FindMostEncompassedType): Implement.
24960 (::FindMostEncompassingType): Implement.
24961 (::StandardConversionExists): Implement.
24963 (UserImplicitCast): Re-vamp. We now need info about most specific
24964 source and target types so that we can do the necessary conversions.
24966 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
24967 mathematical union with no duplicates.
24969 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24971 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
24972 in order from base classes to child classes, so that we can in
24973 child classes look up in our parent for method names and
24974 attributes (required for handling abstract, virtual, new, override
24975 constructs: we need to instrospect our base class, and if we dont
24976 populate the classes in order, the introspection might be
24977 incorrect. For example, a method could query its parent before
24978 the parent has any methods and would determine that the parent has
24979 no abstract methods (while it could have had them)).
24981 (RootContext::CreateType): Record the order in which we define the
24984 2001-10-02 Miguel de Icaza <miguel@ximian.com>
24986 * class.cs (TypeContainer::Populate): Also method definitions can
24987 fail now, keep track of this.
24989 (TypeContainer::FindMembers): Implement support for
24990 DeclaredOnly/noDeclaredOnly flag.
24992 (Constructor::Emit) Return the ConstructorBuilder.
24994 (Method::Emit) Return the MethodBuilder.
24995 Check for abstract or virtual methods to be public.
24997 * rootcontext.cs (RootContext::CreateType): Register all the
24998 abstract methods required for the class to be complete and the
24999 interface methods that must be implemented.
25001 * cs-parser.jay: Report error 501 (method requires body if it is
25002 not marked abstract or extern).
25004 * expression.cs (TypeOf::Emit): Implement.
25006 * typemanager.cs: runtime_handle_type, new global type.
25008 * class.cs (Property::Emit): Generate code for properties.
25010 2001-10-02 Ravi Pratap <ravi@ximian.com>
25012 * expression.cs (Unary::ResolveOperator): Find operators on base type
25013 too - we now conform exactly to the spec.
25015 (Binary::ResolveOperator): Same here.
25017 * class.cs (Operator::Define): Fix minor quirk in the tests.
25019 * ../errors/cs0215.cs : Added.
25021 * ../errors/cs0556.cs : Added.
25023 * ../errors/cs0555.cs : Added.
25025 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25027 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
25028 single integer which is really efficient
25030 2001-10-01 Ravi Pratap <ravi@ximian.com>
25032 * expression.cs (Expression::ImplicitUserConversion): Use location
25033 even in the case when we are examining True operators.
25035 * class.cs (Operator::Define): Perform extensive checks to conform
25036 with the rules for operator overloading in the spec.
25038 * expression.cs (Expression::ImplicitReferenceConversion): Implement
25039 some of the other conversions mentioned in the spec.
25041 * typemanager.cs (array_type): New static member for the System.Array built-in
25044 (cloneable_interface): For System.ICloneable interface.
25046 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
25047 we start resolving the tree and populating types.
25049 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
25051 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25053 * expression.cs (Expression::ExprClassFromMemberInfo,
25054 Expression::Literalize): Create literal expressions from
25055 FieldInfos which are literals.
25057 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
25058 type casts, because they were wrong. The test suite in tests
25061 (ImplicitNumericConversion): ushort to ulong requires a widening
25064 Int32 constant to long requires widening cast as well.
25066 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
25067 for integers because the type on the stack is not i4.
25069 2001-09-30 Miguel de Icaza <miguel@ximian.com>
25071 * expression.cs (report118): require location argument.
25073 * parameter.cs: Do not dereference potential null value.
25075 * class.cs: Catch methods that lack the `new' keyword when
25076 overriding a name. Report warnings when `new' is used without
25077 anything being there to override.
25079 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
25081 * class.cs: Only add constructor to hashtable if it is non-null
25082 (as now constructors can fail on define).
25084 (TypeManager, Class, Struct): Take location arguments.
25086 Catch field instance initialization in structs as errors.
25088 accepting_filter: a new filter for FindMembers that is static so
25089 that we dont create an instance per invocation.
25091 (Constructor::Define): Catch errors where a struct constructor is
25094 * cs-parser.jay: Pass location information for various new
25097 * delegate.cs (Delegate): take a location argument.
25099 * driver.cs: Do not call EmitCode if there were problesm in the
25100 Definition of the types, as many Builders wont be there.
25102 * decl.cs (Decl::Decl): Require a location argument.
25104 * cs-tokenizer.cs: Handle properly hex constants that can not fit
25105 into integers, and find the most appropiate integer for it.
25107 * literal.cs: Implement ULongLiteral.
25109 * rootcontext.cs: Provide better information about the location of
25110 failure when CreateType fails.
25112 2001-09-29 Miguel de Icaza <miguel@ximian.com>
25114 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
25117 * expression.cs (Binary::CheckShiftArguments): Add missing type
25119 (Binary::ResolveOperator): Add type to the logical and and logical
25120 or, Bitwise And/Or and Exclusive Or code paths, it was missing
25123 (Binary::DoNumericPromotions): In the case where either argument
25124 is ulong (and most signed types combined with ulong cause an
25125 error) perform implicit integer constant conversions as well.
25127 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25129 * expression.cs (UserImplicitCast): Method should always be
25131 (Invocation::BetterConversion): Simplified test for IntLiteral.
25133 (Expression::ImplicitNumericConversion): Split this routine out.
25134 Put the code that performs implicit constant integer conversions
25137 (Expression::Resolve): Become a wrapper around DoResolve so we can
25138 check eclass and type being set after resolve.
25140 (Invocation::Badness): Remove this dead function
25142 (Binary::ResolveOperator): Do not compute the expensive argumnets
25143 unless we have a union for it.
25145 (Probe::Emit): Is needs to do an isinst and then
25146 compare against null.
25148 (::CanConvert): Added Location argument. If the Location argument
25149 is null (Location.Null), then we do not report errors. This is
25150 used by the `probe' mechanism of the Explicit conversion. We do
25151 not want to generate an error for something that the user
25152 explicitly requested to be casted. But the pipeline for an
25153 explicit cast first tests for potential implicit casts.
25155 So for now, if the Location is null, it means `Probe only' to
25156 avoid adding another argument. Might have to revise this
25159 (ClassCast): New class used to type cast objects into arbitrary
25160 classes (used in Explicit Reference Conversions).
25162 Implement `as' as well.
25164 Reverted all the patches from Ravi below: they were broken:
25166 * The use of `level' as a mechanism to stop recursive
25167 invocations is wrong. That was there just to catch the
25168 bug with a strack trace but not as a way of addressing
25171 To fix the problem we have to *understand* what is going
25172 on and the interactions and come up with a plan, not
25173 just get things going.
25175 * The use of the type conversion cache that I proposed
25176 last night had an open topic: How does this work across
25177 protection domains. A user defined conversion might not
25178 be public in the location where we are applying the
25179 conversion, a different conversion might be selected
25180 (ie, private A->B (better) but public B->A (worse),
25181 inside A, A->B applies, but outside it, B->A will
25184 * On top of that (ie, even if the above is solved),
25185 conversions in a cache need to be abstract. Ie, `To
25186 convert from an Int to a Short use an OpcodeCast', not
25187 `To convert from an Int to a Short use the OpcodeCast on
25188 the variable 5' (which is what this patch was doing).
25190 2001-09-28 Ravi Pratap <ravi@ximian.com>
25192 * expression.cs (Invocation::ConversionExists): Re-write to use
25193 the conversion cache
25195 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25196 cache all conversions done, not just user-defined ones.
25198 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25199 to determine if a conversion exists instead of acutually trying to
25200 perform the conversion. It's faster too.
25202 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25203 and only then attempt the implicit conversion.
25205 2001-09-28 Ravi Pratap <ravi@ximian.com>
25207 * expression.cs (ConvertImplicit): Use a cache for conversions
25208 already found. Check level of recursion and bail out if necessary.
25210 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25212 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25213 Export standard methods that we expect for string operations.
25215 * statement.cs (Block::UsageWarning): Track usage of variables and
25216 report the errors for not used variables.
25218 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25221 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25223 * codegen.cs: remove unnneded code
25225 * expression.cs: Removed BuiltinTypeAccess class
25227 Fix the order in which implicit conversions are
25230 The previous fixed dropped support for boxed conversions (adding a
25231 test to the test suite now)
25233 (UserImplicitCast::CanConvert): Remove test for source being null,
25234 that code is broken. We should not feed a null to begin with, if
25235 we do, then we should track the bug where the problem originates
25236 and not try to cover it up here.
25238 Return a resolved expression of type UserImplicitCast on success
25239 rather than true/false. Ravi: this is what I was talking about,
25240 the pattern is to use a static method as a "constructor" for
25243 Also, do not create arguments until the very last minute,
25244 otherwise we always create the arguments even for lookups that
25245 will never be performed.
25247 (UserImplicitCast::Resolve): Eliminate, objects of type
25248 UserImplicitCast are born in a fully resolved state.
25250 * typemanager.cs (InitCoreTypes): Init also value_type
25251 (System.ValueType).
25253 * expression.cs (Cast::Resolve): First resolve the child expression.
25255 (LValue): Add new method AddressOf to be used by
25258 Change the argument of Store to take an EmitContext instead of an
25259 ILGenerator, because things like FieldExpr need to be able to call
25260 their children expression to generate the instance code.
25262 (Expression::Error, Expression::Warning): Sugar functions for
25265 (Expression::MemberLookup): Accept a TypeContainer instead of a
25266 Report as the first argument.
25268 (Expression::ResolvePrimary): Killed. I still want to improve
25269 this as currently the code is just not right.
25271 (Expression::ResolveMemberAccess): Simplify, but it is still
25274 (Unary::Resolve): Catch errors in AddressOf operators.
25276 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25277 index to a byte for the short-version, or the compiler will choose
25278 the wrong Emit call, which generates the wrong data.
25280 (ParameterReference::Emit, ::Store): same.
25282 (FieldExpr::AddressOf): Implement.
25284 * typemanager.cs: TypeManager: made public variable instead of
25287 * driver.cs: document --fatal.
25289 * report.cs (ErrorMessage, WarningMessage): new names for the old
25290 Error and Warning classes.
25292 * cs-parser.jay (member_access): Turn built-in access to types
25293 into a normal simplename
25295 2001-09-27 Ravi Pratap <ravi@ximian.com>
25297 * expression.cs (Invocation::BetterConversion): Fix to cope
25298 with q being null, since this was introducing a bug.
25300 * expression.cs (ConvertImplicit): Do built-in conversions first.
25302 2001-09-27 Ravi Pratap <ravi@ximian.com>
25304 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25306 2001-09-27 Ravi Pratap <ravi@ximian.com>
25308 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25309 I had introduced long ago (what's new ?).
25311 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25312 the work of all the checking.
25313 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25314 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25316 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25317 that is the right way.
25319 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25320 overloading resolution. Use everywhere instead of cutting and pasting code.
25322 (Binary::ResolveOperator): Use MakeUnionSet.
25324 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25325 we have to convert to bool types. Not complete yet.
25327 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25329 * typemanager.cs (TypeManager::CSharpName): support ushort.
25331 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25332 to provide an expression that performsn an implicit constant int
25333 conversion (section 6.1.6).
25334 (Expression::ConvertImplicitRequired): Reworked to include
25335 implicit constant expression conversions.
25337 (Expression::ConvertNumericExplicit): Finished.
25339 (Invocation::Emit): If InstanceExpression is null, then it means
25340 that we perform a call on this.
25342 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25344 * expression.cs (Unary::Emit): Remove some dead code.
25345 (Probe): Implement Resolve and Emit for `is'.
25346 (Expression::ConvertImplicitRequired): Attempt to do constant
25347 expression conversions here. Maybe should be moved to
25348 ConvertImplicit, but I am not sure.
25349 (Expression::ImplicitLongConstantConversionPossible,
25350 Expression::ImplicitIntConstantConversionPossible): New functions
25351 that tell whether is it possible to apply an implicit constant
25352 expression conversion.
25354 (ConvertNumericExplicit): Started work on explicit numeric
25357 * cs-parser.jay: Update operator constants.
25359 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25360 (Parameters::GetSignature): Hook up VerifyArgs here.
25361 (Parameters::VerifyArgs): Verifies that no two arguments have the
25364 * class.cs (Operator): Update the operator names to reflect the
25365 ones that the spec expects (as we are just stringizing the
25368 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25369 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25370 previous usage did only work for our methods.
25371 (Expression::ConvertImplicit): Handle decimal implicit numeric
25372 conversions as well.
25373 (Expression::InternalTypeConstructor): Used to invoke constructors
25374 on internal types for default promotions.
25376 (Unary::Emit): Implement special handling for the pre/post
25377 increment/decrement for overloaded operators, as they need to have
25378 the same semantics as the other operators.
25380 (Binary::ResolveOperator): ditto.
25381 (Invocation::ConversionExists): ditto.
25382 (UserImplicitCast::Resolve): ditto.
25384 2001-09-26 Ravi Pratap <ravi@ximian.com>
25386 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25387 operator, return after emitting body. Regression tests pass again !
25389 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25390 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25391 (Invocation::OverloadResolve): Ditto.
25392 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25394 * everywhere : update calls to the above methods accordingly.
25396 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25398 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25400 * expression.cs (ExpressionStatement): New base class used for
25401 expressions that can appear in statements, so that we can provide
25402 an alternate path to generate expression that do not leave a value
25405 (Expression::Emit, and all the derivatives): We no longer return
25406 whether a value is left on the stack or not. Every expression
25407 after being emitted leaves a single value on the stack.
25409 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25410 facilties of ExpressionStatement if possible.
25412 * cs-parser.jay: Update statement_expression.
25414 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25416 * driver.cs: Change the wording of message
25418 2001-09-25 Ravi Pratap <ravi@ximian.com>
25420 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25421 the type of the expression to the return type of the method if
25422 we have an overloaded operator match ! The regression tests pass again !
25423 (Unary::ResolveOperator): Ditto.
25425 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25426 to find "op_Implicit", not "implicit" ;-)
25427 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25428 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25430 * everywhere : Correct calls to the above accordingly.
25432 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25433 (ConvertImplicit): Do user-defined conversion if it exists.
25435 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25437 * assign.cs: track location.
25438 (Resolve): Use implicit conversions on assignment.
25440 * literal.cs: Oops. Not good, Emit of short access values should
25441 pass (Bytes) or the wrong argument will be selected.
25443 * expression.cs (Unary::Emit): Emit code for -expr.
25445 (Unary::ResolveOperator): Handle `Substract' for non-constants
25446 (substract from zero from the non-constants).
25447 Deal with Doubles as well.
25449 (Expression::ConvertImplicitRequired): New routine that reports an
25450 error if no implicit conversion exists.
25452 (Invocation::OverloadResolve): Store the converted implicit
25453 expressions if we make them
25455 2001-09-24 Ravi Pratap <ravi@ximian.com>
25457 * class.cs (ConstructorInitializer): Take a Location argument.
25458 (ConstructorBaseInitializer): Same here.
25459 (ConstructorThisInitializer): Same here.
25461 * cs-parser.jay : Update all calls accordingly.
25463 * expression.cs (Unary, Binary, New): Take location argument.
25464 Update accordingly everywhere.
25466 * cs-parser.jay : Update all calls to the above to take a location
25469 * class.cs : Ditto.
25471 2001-09-24 Ravi Pratap <ravi@ximian.com>
25473 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25474 (Invocation::BetterConversion): Same here
25475 (Invocation::ConversionExists): Ditto.
25477 (Invocation::ConversionExists): Implement.
25479 2001-09-22 Ravi Pratap <ravi@ximian.com>
25481 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25482 Also take an additional TypeContainer argument.
25484 * All over : Pass in TypeContainer as argument to OverloadResolve.
25486 * typemanager.cs (CSharpName): Update to check for the string type and return
25489 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25492 2001-09-21 Ravi Pratap <ravi@ximian.com>
25494 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25495 (Invocation::BetterFunction): Implement.
25496 (Invocation::BetterConversion): Implement.
25497 (Invocation::ConversionExists): Skeleton, no implementation yet.
25499 Okay, things work fine !
25501 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25503 * typemanager.cs: declare and load enum_type, delegate_type and
25506 * expression.cs (Expression::Emit): Now emit returns a value that
25507 tells whether a value is left on the stack or not. This strategy
25508 might be reveted tomorrow with a mechanism that would address
25509 multiple assignments.
25510 (Expression::report118): Utility routine to report mismatches on
25513 (Unary::Report23): Report impossible type/operator combination
25516 (Unary::IsIncrementableNumber): Whether the type can be
25517 incremented or decremented with add.
25518 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25520 (Unary::ResolveOperator): Implement ++, !, ~,
25522 (Invocation::Emit): Deal with new Emit convetion.
25524 * All Expression derivatives: Updated their Emit method to return
25525 whether they leave values on the stack or not.
25527 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25528 stack for expressions that are statements.
25530 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25532 * expression.cs (LValue): New interface. Must be implemented by
25534 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25537 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25538 interface for generating code, simplifies the code.
25540 2001-09-20 Ravi Pratap <ravi@ximian.com>
25542 * expression.cs (everywhere): Comment out return statements in ::Resolve
25543 methods to avoid the warnings.
25545 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25547 * driver.cs (parse): Report error 2001 if we can not open the
25550 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25553 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25556 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25557 otherwise nested blocks end up with the same index.
25559 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25561 * expression.cs: Instead of having FIXMEs in the Resolve
25562 functions, throw exceptions so it is obvious that we are facing a
25565 * cs-parser.jay (invocation_expression): Pass Location information.
25567 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25568 Use a basename for those routines because .NET does not like paths
25571 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25574 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25576 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25577 are loading the correct data types (throws an exception if not).
25578 (TypeManager::InitCoreTypes): Use CoreLookupType
25580 * expression.cs (Unary::ResolveOperator): return the child
25581 expression for expressions which are just +expr.
25582 (Unary::ResolveOperator): Return negative literals for -LITERAL
25583 expressions (otherwise they are Unary {Literal}).
25584 (Invocation::Badness): Take into account `Implicit constant
25585 expression conversions'.
25587 * literal.cs (LongLiteral): Implement long literal class.
25588 (IntLiteral): export the `Value' of the intliteral.
25590 2001-09-19 Ravi Pratap <ravi@ximian.com>
25592 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25594 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25595 instead of 'Operator'
25597 * expression.cs (Binary::ResolveOperator): Update accordingly.
25598 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25601 * cs-parser.jay (unary_expression): Update to use the new names.
25603 * gen-treedump.cs (GetUnary): Same here.
25605 * expression.cs (Unary::Resolve): Implement.
25606 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25607 operators are found instead of making noise ;-)
25608 (Unary::ResolveOperator): New method to do precisely the same thing which
25609 Binary::ResolveOperator does for Binary expressions.
25610 (Unary.method, .Arguments): Add.
25611 (Unary::OperName): Implement.
25612 (Unary::ForceConversion): Copy and Paste !
25614 * class.cs (Operator::Define): Fix a small bug for the case when we have
25617 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25618 for the inbuilt operators. Only overloading works for now ;-)
25620 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25622 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25623 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25625 * expression.cs (This::Emit): Implement.
25626 (This::Resolve): Implement.
25627 (TypeOf:Resolve): Implement.
25628 (Expression::ResolveSimpleName): Add an implicit this to instance
25630 (MemberAccess::Resolve): Deal with Parameters and Fields.
25631 Bind instance variable to Field expressions.
25632 (FieldExpr::Instance): New field used to track the expression that
25633 represents the object instance.
25634 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25636 (FieldExpr::Emit): Implement.
25638 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25639 the last instruction contains a return opcode to avoid generating
25640 the last `ret' instruction (this generates correct code, and it is
25641 nice to pass the peverify output).
25643 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25644 initializer for static and instance variables.
25645 (Constructor::Emit): Allow initializer to be null in the case of
25646 static constructors. Only emit initializer for instance
25649 (TypeContainer::FindMembers): Return a null array if there are no
25652 Also fix the code for the MemberTypes.Method branch, as it was not
25653 scanning that for operators (or tried to access null variables before).
25655 * assign.cs (Assign::Emit): Handle instance and static fields.
25659 * driver.cs: Stop compilation if there are parse errors.
25661 * cs-parser.jay (constructor_declaration): Provide default base
25662 initializer for non-static constructors.
25663 (constructor_declarator): Do not provide a default base
25664 initializers if none was specified.
25665 Catch the fact that constructors should not have parameters.
25667 * class.cs: Do not emit parent class initializers for static
25668 constructors, that should be flagged as an error.
25670 2001-09-18 Ravi Pratap <ravi@ximian.com>
25672 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25673 Move back code into TypeContainer::Populate.
25675 2001-09-18 Ravi Pratap <ravi@ximian.com>
25677 * class.cs (TypeContainer::AddConstructor): Fix the check to
25678 compare against Name, not Basename.
25679 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25681 * cs-parser.jay : Update accordingly.
25683 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25684 for methods, don't forget to look into the operators too.
25685 (RegisterMethodBuilder): Helper method to take care of this for
25686 methods, constructors and operators.
25687 (Operator::Define): Completely revamp.
25688 (Operator.OperatorMethod, MethodName): New fields.
25689 (TypeContainer::Populate): Move the registering of builders into
25690 RegisterMethodBuilder.
25691 (Operator::Emit): Re-write.
25693 * expression.cs (Binary::Emit): Comment out code path to emit method
25694 invocation stuff for the case when we have a user defined operator. I am
25695 just not able to get it right !
25697 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25699 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25702 (Expression::MemberLookup): Provide a version that allows to
25703 specify the MemberTypes and BindingFlags.
25705 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25706 so it was not fetching variable information from outer blocks.
25708 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25709 Beforefieldinit as it was buggy.
25711 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25712 that Ravi put here.
25714 * class.cs (Constructor::Emit): Only emit if block is not null.
25715 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25716 deal with this by semantically definining it as if the user had
25719 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25720 constructors as we now "emit" them at a higher level.
25722 (TypeContainer::DefineDefaultConstructor): Used to define the
25723 default constructors if none was provided.
25725 (ConstructorInitializer): Add methods Resolve and Emit.
25727 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25729 2001-09-17 Ravi Pratap <ravi@ximian.com>
25731 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25732 the default constructor builder with our hashtable for methodbuilders
25735 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25736 and argument_count is 0 in which case we have a match.
25737 (Binary::ResolveOperator): More null checking and miscellaneous coding
25740 2001-09-17 Ravi Pratap <ravi@ximian.com>
25742 * rootcontext.cs (IsNameSpace): Compare against null.
25744 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25746 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25747 and Unary::Operator.
25749 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25752 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25753 we have overloaded operators.
25754 (Binary::ResolveOperator): Implement the part which does the operator overload
25757 * class.cs (Operator::Emit): Implement.
25758 (TypeContainer::Emit): Emit the operators we have too.
25760 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25761 the case when we have a user-defined operator.
25763 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25765 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
25767 2001-09-16 Ravi Pratap <ravi@ximian.com>
25769 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
25770 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
25771 (Constructor::Emit): Implement.
25772 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
25773 if we have no work to do.
25774 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
25777 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
25778 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
25780 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
25783 2001-09-15 Ravi Pratap <ravi@ximian.com>
25785 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
25787 (Tree::RecordNamespace): Method to do what the name says ;-)
25788 (Tree::Namespaces): Property to get at the namespaces hashtable.
25790 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
25793 * rootcontext.cs (IsNamespace): Fixed it :-)
25795 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25797 * class.cs (TypeContainer::FindMembers): Add support for
25799 (MethodCore): New class that encapsulates both the shared aspects
25800 of a Constructor and a Method.
25801 (Method, Constructor): Factored pieces into MethodCore.
25803 * driver.cs: Added --fatal which makes errors throw exceptions.
25804 Load System assembly as well as part of the standard library.
25806 * report.cs: Allow throwing exceptions on errors for debugging.
25808 * modifiers.cs: Do not use `parent', instead use the real type
25809 container to evaluate permission settings.
25811 * class.cs: Put Ravi's patch back in. He is right, and we will
25812 have to cope with the
25814 2001-09-14 Ravi Pratap <ravi@ximian.com>
25816 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
25817 FamORAssem, not FamANDAssem.
25819 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25821 * driver.cs: Added --parse option that only parses its input files
25824 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
25825 incorrect. IsTopLevel is not used to tell whether an object is
25826 root_types or not (that can be achieved by testing this ==
25827 root_types). But to see if this is a top-level *class* (not
25828 necessarly our "toplevel" container).
25830 2001-09-14 Ravi Pratap <ravi@ximian.com>
25832 * enum.cs (Enum::Define): Modify to call the Lookup method on the
25833 parent instead of a direct call to GetType.
25835 2001-09-14 Ravi Pratap <ravi@ximian.com>
25837 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
25838 Modifiers.TypeAttr. This should just be a call to that method.
25840 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
25841 object so that we can determine if we are top-level or not.
25843 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
25846 * enum.cs (Enum::Define): Ditto.
25848 * modifiers.cs (FieldAttr): Re-write.
25850 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
25851 (TypeContainer::HaveStaticConstructor): New property to provide access
25852 to precisely that info.
25854 * modifiers.cs (MethodAttr): Re-write.
25855 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
25857 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
25858 of top-level types as claimed.
25860 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25862 * expression.cs (MemberLookup): Fruitless attempt to lookup
25863 constructors. Maybe I need to emit default constructors? That
25864 might be it (currently .NET emits this for me automatically).
25865 (Invocation::OverloadResolve): Cope with Arguments == null.
25866 (Invocation::EmitArguments): new function, shared by the new
25867 constructor and us.
25868 (Invocation::Emit): Handle static and instance methods. Emit
25869 proper call instruction for virtual or non-virtual invocations.
25870 (New::Emit): Implement.
25871 (New::Resolve): Implement.
25872 (MemberAccess:Resolve): Implement.
25873 (MethodGroupExpr::InstanceExpression): used conforming to the spec
25874 to track instances.
25875 (FieldExpr::Resolve): Set type.
25877 * support.cs: Handle empty arguments.
25879 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
25880 SimpleLookup): Auxiliary routines to help parse a qualifier
25883 Update qualifier_identifier rule.
25885 * codegen.cs: Removed debugging messages.
25887 * class.cs: Make this a global thing, this acts just as a "key" to
25888 objects that we might have around.
25890 (Populate): Only initialize method_builders_to_methods once.
25892 * expression.cs (PropertyExpr): Initialize type from the
25895 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
25896 Resolve pattern. Attempt to implicitly convert value to boolean.
25899 * expression.cs: Set the type for the int32/int32 argument case.
25900 (Binary::ResolveOperator): Set the return type to boolean for
25901 comparission operators
25903 * typemanager.cs: Remove debugging print code.
25905 (Invocation::Resolve): resolve type.
25907 * class.cs: Allocate a MemberInfo of the correct size, as the code
25908 elsewhere depends on the test to reflect the correct contents.
25910 (Method::) Keep track of parameters, due to System.Reflection holes
25912 (TypeContainer::Populate): Keep track of MethodBuilders to Method
25915 (TypeContainer::FindMembers): Use ArrayList and then copy an array
25916 of the exact size and return that.
25918 (Class::LookupMethodByBuilder): New function that maps
25919 MethodBuilders to its methods. Required to locate the information
25920 on methods because System.Reflection bit us again.
25922 * support.cs: New file, contains an interface ParameterData and
25923 two implementations: ReflectionParameters and InternalParameters
25924 used to access Parameter information. We will need to grow this
25927 * expression.cs (Invocation::GetParameterData): implement a cache
25928 and a wrapper around the ParameterData creation for methods.
25929 (Invocation::OverloadResolve): Use new code.
25931 2001-09-13 Ravi Pratap <ravi@ximian.com>
25933 * class.cs (TypeContainer::EmitField): Remove and move into
25934 (Field::Define): here and modify accordingly.
25935 (Field.FieldBuilder): New member.
25936 (TypeContainer::Populate): Update accordingly.
25937 (TypeContainer::FindMembers): Implement.
25939 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25941 * statement.cs: (VariableInfo::VariableType): New field to be
25942 initialized with the full type once it is resolved.
25944 2001-09-12 Miguel de Icaza <miguel@ximian.com>
25946 * parameter.cs (GetParameterInfo): Use a type cache to compute
25947 things only once, and to reuse this information
25949 * expression.cs (LocalVariableReference::Emit): Implement.
25950 (OpcodeCast::Emit): fix.
25952 (ParameterReference::Resolve): Implement.
25953 (ParameterReference::Emit): Implement.
25955 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
25956 that are expressions need to stay as Expressions.
25958 * typemanager.cs (CSharpName): Returns the C# name of a type if
25961 * expression.cs (Expression::ConvertImplicit): New function that
25962 implements implicit type conversions.
25964 (Expression::ImplicitReferenceConversion): Implements implicit
25965 reference conversions.
25967 (EmptyCast): New type for transparent casts.
25969 (OpcodeCast): New type for casts of types that are performed with
25970 a sequence of bytecodes.
25972 (BoxedCast): New type used for casting value types into reference
25973 types. Emits a box opcode.
25975 (Binary::DoNumericPromotions): Implements numeric promotions of
25976 and computation of the Binary::Type.
25978 (Binary::EmitBranchable): Optimization.
25980 (Binary::Emit): Implement code emission for expressions.
25982 * typemanager.cs (TypeManager): Added two new core types: sbyte
25985 2001-09-12 Ravi Pratap <ravi@ximian.com>
25987 * class.cs (TypeContainer::FindMembers): Method which does exactly
25988 what Type.FindMembers does, only we don't have to use reflection. No
25989 implementation yet.
25991 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
25992 typecontainer objects as we need to get at them.
25993 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
25995 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
25996 typecontainer object.
25998 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
25999 of just a Report object.
26001 2001-09-11 Ravi Pratap <ravi@ximian.com>
26003 * class.cs (Event::Define): Go back to using the prefixes "add_" and
26005 (TypeContainer::Populate): Now define the delegates of the type too.
26006 (TypeContainer.Delegates): Property to access the list of delegates defined
26009 * delegates.cs (Delegate::Define): Implement partially.
26011 * modifiers.cs (TypeAttr): Handle more flags.
26013 2001-09-11 Ravi Pratap <ravi@ximian.com>
26015 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
26017 (Operator::Define): Re-write logic to get types by using the LookupType method
26018 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
26019 (Indexer::Define): Ditto.
26020 (Event::Define): Ditto.
26021 (Property::Define): Ditto.
26023 2001-09-10 Ravi Pratap <ravi@ximian.com>
26025 * class.cs (TypeContainer::Populate): Now define operators too.
26026 (TypeContainer.Operators): New property to access the list of operators
26028 (Operator.OperatorMethodBuilder): New member to hold the method builder
26029 for the operator we are defining.
26030 (Operator::Define): Implement.
26032 2001-09-10 Ravi Pratap <ravi@ximian.com>
26034 * class.cs (Event::Define): Make the prefixes of the accessor methods
26035 addOn_ and removeOn_
26037 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
26038 of the location being passed in too. Ideally, this should go later since all
26039 error reporting should be done through the Report object.
26041 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
26042 (Populate): Iterate thru the indexers we have and define them too.
26043 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
26044 for the get and set accessors.
26045 (Indexer::Define): Implement.
26047 2001-09-09 Miguel de Icaza <miguel@ximian.com>
26049 * expression.cs (Binary::Resolve): Beginning of it. I scratched
26050 my previous implementation, did not work.
26052 * typemanager.cs: Add a couple of missing types (the longs).
26054 * literal.cs: Use TypeManager.bool_type instead of getting it.
26056 * expression.cs (EventExpr): New kind of expressions.
26057 (Expressio::ExprClassFromMemberInfo): finish
26059 2001-09-08 Miguel de Icaza <miguel@ximian.com>
26061 * assign.cs: Emit stores to static fields differently.
26063 2001-09-08 Ravi Pratap <ravi@ximian.com>
26065 * Merge in changes and adjust code to tackle conflicts. Backed out my
26066 code in Assign::Resolve ;-)
26068 2001-09-08 Ravi Pratap <ravi@ximian.com>
26070 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
26071 instead Report.Error and also pass in the location.
26072 (CSharpParser::Lexer): New readonly property to return the reference
26073 to the Tokenizer object.
26074 (declare_local_variables): Use Report.Error with location instead of plain
26078 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
26079 (Operator.CheckBinaryOperator): Ditto.
26081 * cs-parser.jay (operator_declarator): Update accordingly.
26083 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
26084 (CheckBinaryOperator): Same here.
26086 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
26087 on the name without any prefixes of namespace names etc. This is because we
26088 already might have something already fully qualified like
26089 'System.Console.WriteLine'
26091 * assign.cs (Resolve): Begin implementation. Stuck ;-)
26093 2001-09-07 Ravi Pratap <ravi@ximian.com>
26095 * cs-tokenizer.cs (location): Return a string which also contains
26098 * expression.cs (ElementAccess): New class for expressions of the
26099 type 'element access.'
26100 (BaseAccess): New class for expressions of the type 'base access.'
26101 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
26104 * cs-parser.jay (element_access): Implement action.
26105 (base_access): Implement actions.
26106 (checked_expression, unchecked_expression): Implement.
26108 * cs-parser.jay (local_variable_type): Correct and implement.
26109 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
26111 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
26113 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
26114 name and the specifiers.
26116 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
26118 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
26119 making them all public ;-)
26121 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
26124 2001-09-07 Miguel de Icaza <miguel@ximian.com>
26126 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
26128 (FieldExpr, PropertyExprs): New resolved expressions.
26129 (SimpleName::MemberStaticCheck): Perform static checks for access
26130 to non-static fields on static methods. Maybe this should be
26131 generalized for MemberAccesses.
26132 (SimpleName::ResolveSimpleName): More work on simple name
26135 * cs-parser.jay (primary_expression/qualified_identifier): track
26136 the parameter index.
26138 * codegen.cs (CodeGen::Save): Catch save exception, report error.
26139 (EmitContext::EmitBoolExpression): Chain to expression generation
26140 instead of temporary hack.
26141 (::EmitStatementExpression): Put generic expression code generation.
26143 * assign.cs (Assign::Emit): Implement variable assignments to
26144 local variables, parameters and fields.
26146 2001-09-06 Miguel de Icaza <miguel@ximian.com>
26148 * statement.cs (Block::GetVariableInfo): New method, returns the
26149 VariableInfo for a variable name in a block.
26150 (Block::GetVariableType): Implement in terms of GetVariableInfo
26152 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26153 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26155 2001-09-06 Ravi Pratap <ravi@ximian.com>
26157 * cs-parser.jay (operator_declaration): Continue on my quest : update
26158 to take attributes argument.
26159 (event_declaration): Ditto.
26160 (enum_declaration): Ditto.
26161 (indexer_declaration): Ditto.
26163 * class.cs (Operator::Operator): Update constructor accordingly.
26164 (Event::Event): Ditto.
26166 * delegate.cs (Delegate::Delegate): Same here.
26168 * enum.cs (Enum::Enum): Same here.
26170 2001-09-05 Ravi Pratap <ravi@ximian.com>
26172 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26174 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26176 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26177 being passed around as an arraylist.
26178 (Attributes::AddAttribute): Method to add attribute sections.
26180 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26181 (struct_declaration): Update accordingly.
26182 (constant_declaration): Update.
26183 (field_declaration): Update.
26184 (method_header): Update.
26185 (fixed_parameter): Update.
26186 (parameter_array): Ditto.
26187 (property_declaration): Ditto.
26188 (destructor_declaration): Ditto.
26190 * class.cs (Struct::Struct): Update constructors accordingly.
26191 (Class::Class): Ditto.
26192 (Field::Field): Ditto.
26193 (Method::Method): Ditto.
26194 (Property::Property): Ditto.
26195 (TypeContainer::OptAttribute): update property's return type.
26197 * interface.cs (Interface.opt_attributes): New member.
26198 (Interface::Interface): Update to take the extra Attributes argument.
26200 * parameter.cs (Parameter::Parameter): Ditto.
26202 * constant.cs (Constant::Constant): Ditto.
26204 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26205 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26206 the attributes as a parameter.
26207 (InterfaceProperty): Update constructor call.
26208 (InterfaceEvent): Ditto.
26209 (InterfaceMethod): Ditto.
26210 (InterfaceIndexer): Ditto.
26212 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26213 pass the attributes too.
26214 (interface_event_declaration): Ditto.
26215 (interface_property_declaration): Ditto.
26216 (interface_method_declaration): Ditto.
26217 (interface_declaration): Ditto.
26219 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26221 * class.cs (Method::Define): Track the "static Main" definition to
26222 create an entry point.
26224 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26225 EntryPoint if we find it.
26227 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26228 (EmitContext::ig): Make this variable public.
26230 * driver.cs: Make the default output file be the first file name
26231 with the .exe extension.
26233 Detect empty compilations
26235 Handle various kinds of output targets. Handle --target and
26236 rename -t to --dumper.
26238 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26239 methods inherited from Expression return now an Expression. This
26240 will is used during the tree rewriting as we resolve them during
26243 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26244 the spec. Missing entirely is the information about
26245 accessability of elements of it.
26247 (Expression::ExprClassFromMemberInfo): New constructor for
26248 Expressions that creates a fully initialized Expression based on
26249 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26252 (Invocation::Resolve): Begin implementing resolution of invocations.
26254 * literal.cs (StringLiteral): Implement Emit.
26256 2001-09-05 Ravi Pratap <ravi@ximian.com>
26258 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26261 2001-09-04 Ravi Pratap <ravi@ximian.com>
26263 * cs-parser.jay (attribute_arguments): Implement actions.
26264 (attribute): Fix bug in production. Implement action.
26265 (attribute_list): Implement.
26266 (attribute_target): Implement.
26267 (attribute_target_specifier, opt_target_specifier): Implement
26268 (CheckAttributeTarget): New method to check if the attribute target
26270 (attribute_section): Implement.
26271 (opt_attributes): Implement.
26273 * attribute.cs : New file to handle attributes.
26274 (Attribute): Class to hold attribute info.
26276 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26277 (attribute_section): Modify production to use 2 different rules to
26278 achieve the same thing. 1 s/r conflict down !
26279 Clean out commented, useless, non-reducing dimension_separator rules.
26281 * class.cs (TypeContainer.attributes): New member to hold list
26282 of attributes for a type.
26283 (Struct::Struct): Modify to take one more argument, the attribute list.
26284 (Class::Class): Ditto.
26285 (Field::Field): Ditto.
26286 (Method::Method): Ditto.
26287 (Property::Property): Ditto.
26289 * cs-parser.jay (struct_declaration): Update constructor call to
26290 pass in the attributes too.
26291 (class_declaration): Ditto.
26292 (constant_declaration): Ditto.
26293 (field_declaration): Ditto.
26294 (method_header): Ditto.
26295 (fixed_parameter): Ditto.
26296 (parameter_array): Ditto.
26297 (property_declaration): Ditto.
26299 * constant.cs (Constant::Constant): Update constructor similarly.
26300 Use System.Collections.
26302 * parameter.cs (Parameter::Parameter): Update as above.
26304 2001-09-02 Ravi Pratap <ravi@ximian.com>
26306 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26307 (TypeContainer.delegates): New member to hold list of delegates.
26309 * cs-parser.jay (delegate_declaration): Implement the action correctly
26310 this time as I seem to be on crack ;-)
26312 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26314 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26315 tell whether an identifier represents a namespace.
26317 * expression.cs (NamespaceExpr): A namespace expression, used only
26318 temporarly during expression resolution.
26319 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26320 utility functions to resolve names on expressions.
26322 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26324 * codegen.cs: Add hook for StatementExpressions.
26326 * class.cs: Fix inverted test for static flag in methods.
26328 2001-09-02 Ravi Pratap <ravi@ximian.com>
26330 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26331 to make it coincide with MS' number.
26332 (Operator::CheckBinaryOperator): Ditto.
26334 * ../errors/errors.txt : Remove error numbers added earlier.
26336 * ../errors/cs1019.cs : Test case for error # 1019
26338 * ../errros/cs1020.cs : Test case for error # 1020
26340 * cs-parser.jay : Clean out commented cruft.
26341 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26342 used anywhere - non-reducing rule.
26343 (namespace_declarations): Non-reducing rule - comment out.
26345 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26346 with TypeContainer::AddEnum.
26348 * delegate.cs : New file for delegate handling classes.
26349 (Delegate): Class for declaring delegates.
26351 * makefile : Update.
26353 * cs-parser.jay (delegate_declaration): Implement.
26355 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26357 * class.cs (Event::Define): Implement.
26358 (Event.EventBuilder): New member.
26360 * class.cs (TypeContainer::Populate): Update to define all enums and events
26362 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26363 readonly fields for all these cases ?
26365 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26367 * class.cs (Property): Revamp to use the convention of making fields readonly.
26368 Accordingly modify code elsewhere.
26370 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26371 the Define method of the Property class.
26373 * class.cs : Clean up applied patch and update references to variables etc. Fix
26375 (TypeContainer::Populate): Update to define all the properties we have. Also
26376 define all enumerations.
26378 * enum.cs (Define): Implement.
26380 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26382 * cs-parser.jay (overloadable_operator): The semantic value is an
26383 enum of the Operator class.
26384 (operator_declarator): Implement actions.
26385 (operator_declaration): Implement.
26387 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26388 validity of definitions.
26389 (Operator::CheckBinaryOperator): Static method to check for binary operators
26390 (TypeContainer::AddOperator): New method to add an operator to a type.
26392 * cs-parser.jay (indexer_declaration): Added line to actually call the
26393 AddIndexer method so it gets added ;-)
26395 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26396 already taken care of by the MS compiler ?
26398 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26400 * class.cs (Operator): New class for operator declarations.
26401 (Operator::OpType): Enum for the various operators.
26403 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26405 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26406 ostensibly handle this in semantic analysis.
26408 * cs-parser.jay (general_catch_clause): Comment out
26409 (specific_catch_clauses, specific_catch_clause): Ditto.
26410 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26411 (catch_args, opt_catch_args): New productions.
26412 (catch_clause): Rewrite to use the new productions above
26413 (catch_clauses): Modify accordingly.
26414 (opt_catch_clauses): New production to use in try_statement
26415 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26416 and re-write the code in the actions to extract the specific and
26417 general catch clauses by being a little smart ;-)
26419 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26420 Hooray, try and catch statements parse fine !
26422 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26424 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26425 string from the hashtable of variables.
26427 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26428 I end up making that mistake ;-)
26429 (catch_clauses): Fixed gross error which made Key and Value of the
26430 DictionaryEntry the same : $1 !!
26432 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26434 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26436 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26437 when the add and remove accessors are specified.
26439 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26441 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26442 information about indexer_declarator.
26443 (indexer_declarator): Implement actions.
26444 (parsing_indexer): New local boolean used to keep track of whether
26445 we are parsing indexers or properties. This is necessary because
26446 implicit_parameters come into picture even for the get accessor in the
26447 case of an indexer.
26448 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26450 * class.cs (Indexer): New class for indexer declarations.
26451 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26452 (TypeContainer::indexers): New member to hold list of indexers for the
26455 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26457 * cs-parser.jay (add_accessor_declaration): Implement action.
26458 (remove_accessor_declaration): Implement action.
26459 (event_accessors_declaration): Implement
26460 (variable_declarators): swap statements for first rule - trivial.
26462 * class.cs (Event): New class to hold information about event
26464 (TypeContainer::AddEvent): New method to add an event to a type
26465 (TypeContainer::events): New member to hold list of events.
26467 * cs-parser.jay (event_declaration): Implement actions.
26469 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26471 * cs-parser.jay (dim_separators): Implement. Make it a string
26472 concatenating all the commas together, just as they appear.
26473 (opt_dim_separators): Modify accordingly
26474 (rank_specifiers): Update accordingly. Basically do the same
26475 thing - instead, collect the brackets here.
26476 (opt_rank_sepcifiers): Modify accordingly.
26477 (array_type): Modify to actually return the complete type string
26478 instead of ignoring the rank_specifiers.
26479 (expression_list): Implement to collect the expressions
26480 (variable_initializer): Implement. We make it a list of expressions
26481 essentially so that we can handle the array_initializer case neatly too.
26482 (variable_initializer_list): Implement.
26483 (array_initializer): Make it a list of variable_initializers
26484 (opt_array_initializer): Modify accordingly.
26486 * expression.cs (New::NType): Add enumeration to help us
26487 keep track of whether we have an object/delegate creation
26488 or an array creation.
26489 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26490 members to hold data about array creation.
26491 (New:New): Modify to update NewType
26492 (New:New): New Overloaded contructor for the array creation
26495 * cs-parser.jay (array_creation_expression): Implement to call
26496 the overloaded New constructor.
26498 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26500 * class.cs (TypeContainer::Constructors): Return member
26501 constructors instead of returning null.
26503 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26505 * typemanager.cs (InitCoreTypes): Initialize the various core
26506 types after we have populated the type manager with the user
26507 defined types (this distinction will be important later while
26508 compiling corlib.dll)
26510 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26511 on Expression Classification. Now all expressions have a method
26512 `Resolve' and a method `Emit'.
26514 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26515 generation from working. Also add some temporary debugging
26518 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26520 * codegen.cs: Lots of code generation pieces. This is only the
26521 beginning, will continue tomorrow with more touches of polish. We
26522 handle the fundamentals of if, while, do, for, return. Others are
26523 trickier and I need to start working on invocations soon.
26525 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26528 * codegen.cs (EmitContext): New struct, used during code
26529 emission to keep a context. Most of the code generation will be
26532 * cs-parser.jay: Add embedded blocks to the list of statements of
26533 this block. So code generation proceeds in a top down fashion.
26535 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26537 * statement.cs: Add support for multiple child blocks.
26539 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26541 * codegen.cs (EmitCode): New function, will emit the code for a
26542 Block of code given a TypeContainer and its ILGenerator.
26544 * statement.cs (Block): Standard public readonly optimization.
26545 (Block::Block constructors): Link children.
26546 (Block::Child): Child Linker.
26547 (Block::EmitVariables): Emits IL variable declarations.
26549 * class.cs: Drop support for MethodGroups here, delay until
26551 (Method::): Applied the same simplification that I did before, and
26552 move from Properties to public readonly fields.
26553 (Method::ParameterTypes): Returns the parameter types for the
26554 function, and implements a cache that will be useful later when I
26555 do error checking and the semantic analysis on the methods is
26557 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26558 and made a method, optional argument tells whether this is a class
26559 or a structure to apply the `has-this' bit.
26560 (Method::GetCallingConvention): Implement, returns the calling
26562 (Method::Define): Defines the type, a second pass is performed
26563 later to populate the methods.
26565 (Constructor::ParameterTypes): implement a cache similar to the
26566 one on Method::ParameterTypes, useful later when we do semantic
26569 (TypeContainer::EmitMethod): New method. Emits methods.
26571 * expression.cs: Removed MethodGroup class from here.
26573 * parameter.cs (Parameters::GetCallingConvention): new method.
26575 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26577 * class.cs (TypeContainer::Populate): Drop RootContext from the
26580 (Constructor::CallingConvention): Returns the calling convention.
26581 (Constructor::ParameterTypes): Returns the constructor parameter
26584 (TypeContainer::AddConstructor): Keep track of default constructor
26585 and the default static constructor.
26587 (Constructor::) Another class that starts using `public readonly'
26588 instead of properties.
26590 (Constructor::IsDefault): Whether this is a default constructor.
26592 (Field::) use readonly public fields instead of properties also.
26594 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26595 track of static constructors; If none is used, turn on
26596 BeforeFieldInit in the TypeAttributes.
26598 * cs-parser.jay (opt_argument_list): now the return can be null
26599 for the cases where there are no arguments.
26601 (constructor_declarator): If there is no implicit `base' or
26602 `this', then invoke the default parent constructor.
26604 * modifiers.cs (MethodAttr): New static function maps a set of
26605 modifiers flags into a MethodAttributes enum
26606 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26607 MethodAttr, TypeAttr to represent the various mappings where the
26608 modifiers are used.
26609 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26611 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26613 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26616 * interface.cs (PopulateIndexer): Implemented the code generator
26617 for interface indexers.
26619 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26621 * interface.cs (InterfaceMemberBase): Now we track the new status
26624 (PopulateProperty): Implement property population. Woohoo! Got
26625 Methods and Properties going today.
26627 Removed all the properties for interfaces, and replaced them with
26628 `public readonly' fields.
26630 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26632 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26633 initialize their hashtables/arraylists only when they are needed
26634 instead of doing this always.
26636 * parameter.cs: Handle refs and out parameters.
26638 * cs-parser.jay: Use an ArrayList to construct the arguments
26639 instead of the ParameterCollection, and then cast that to a
26642 * parameter.cs: Drop the use of ParameterCollection and use
26643 instead arrays of Parameters.
26645 (GetParameterInfo): Use the Type, not the Name when resolving
26648 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26650 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26651 and instead use public readonly fields.
26653 * class.cs: Put back walking code for type containers.
26655 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26657 * class.cs (MakeConstant): Code to define constants.
26659 * rootcontext.cs (LookupType): New function. Used to locate types
26662 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26664 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26665 this System.Reflection code is. Kudos to Microsoft
26667 * typemanager.cs: Implement a type cache and avoid loading all
26668 types at boot time. Wrap in LookupType the internals. This made
26669 the compiler so much faster. Wow. I rule!
26671 * driver.cs: Make sure we always load mscorlib first (for
26672 debugging purposes, nothing really important).
26674 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26675 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26677 * rootcontext.cs: Lookup types on their namespace; Lookup types
26678 on namespaces that have been imported using the `using' keyword.
26680 * class.cs (TypeContainer::TypeAttr): Virtualize.
26681 (Class::TypeAttr): Return attributes suitable for this bad boy.
26682 (Struct::TypeAttr): ditto.
26683 Handle nested classes.
26684 (TypeContainer::) Remove all the type visiting code, it is now
26685 replaced with the rootcontext.cs code
26687 * rootcontext.cs (GetClassBases): Added support for structs.
26689 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26691 * interface.cs, statement.cs, class.cs, parameter.cs,
26692 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26693 Drop use of TypeRefs, and use strings instead.
26695 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26699 * class.cs (Struct::Struct): set the SEALED flags after
26700 checking the modifiers.
26701 (TypeContainer::TypeAttr): new property, returns the
26702 TypeAttributes for a class.
26704 * cs-parser.jay (type_list): Oops, list production was creating a
26705 new list of base types.
26707 * rootcontext.cs (StdLib): New property.
26708 (GetInterfaceTypeByName): returns an interface by type name, and
26709 encapsulates error handling here.
26710 (GetInterfaces): simplified.
26711 (ResolveTree): Encapsulated all the tree resolution here.
26712 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26715 * driver.cs: Add support for --nostdlib, to avoid loading the
26716 default assemblies.
26717 (Main): Do not put tree resolution here.
26719 * rootcontext.cs: Beginning of the class resolution.
26721 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26723 * rootcontext.cs: Provide better error reporting.
26725 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26727 * rootcontext.cs (CreateInterface): Handle the case where there
26728 are no parent interfaces.
26730 (CloseTypes): Routine to flush types at the end.
26731 (CreateInterface): Track types.
26732 (GetInterfaces): Returns an array of Types from the list of
26733 defined interfaces.
26735 * typemanager.c (AddUserType): Mechanism to track user types (puts
26736 the type on the global type hash, and allows us to close it at the
26739 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26741 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26742 RecordInterface instead.
26744 * cs-parser.jay: Updated to reflect changes above.
26746 * decl.cs (Definition): Keep track of the TypeBuilder type that
26747 represents this type here. Not sure we will use it in the long
26748 run, but wont hurt for now.
26750 * driver.cs: Smaller changes to accomodate the new code.
26752 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26755 * rootcontext.cs (CreateInterface): New method, used to create
26756 the System.TypeBuilder type for interfaces.
26757 (ResolveInterfaces): new entry point to resolve the interface
26759 (CodeGen): Property, used to keep track of the code generator.
26761 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26763 * cs-parser.jay: Add a second production for delegate_declaration
26766 (enum_body): Put an opt_comma here instead of putting it on
26767 enum_body or enum_member_declarations so we can handle trailing
26768 commas on enumeration members. Gets rid of a shift/reduce.
26770 (type_list): Need a COMMA in the middle.
26772 (indexer_declaration): Tell tokenizer to recognize get/set
26774 * Remove old targets.
26776 * Re-add the parser target.
26778 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26780 * cs-parser.jay: Add precendence rules for a number of operators
26781 ot reduce the number of shift/reduce conflicts in the grammar.
26783 2001-07-17 Miguel de Icaza <miguel@ximian.com>
26785 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
26788 Get rid of old crufty code.
26790 * rootcontext.cs: Use this to keep track of the parsed
26791 representation and the defined types available to the program.
26793 * gen-treedump.cs: adjust for new convention.
26795 * type.cs: Split out the type manager, and the assembly builder
26798 * typemanager.cs: the type manager will live here now.
26800 * cil-codegen.cs: And the code generator here.
26802 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
26804 * makefile: Fixed up for easy making.
26806 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26808 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
26811 (unary_expression): Expand pre_increment_expression and
26812 post_decrement_expression to reduce a shift/reduce.
26814 2001-07-11 Simon Cozens
26816 * cs-tokenizer.cs: Hex numbers should begin with a 0.
26818 Improve allow_keyword_as_indent name.
26820 2001-06-19 Miguel de Icaza <miguel@ximian.com>
26822 * Adjustments for Beta2.
26824 2001-06-13 Miguel de Icaza <miguel@ximian.com>
26826 * decl.cs: Added `Define' abstract method.
26827 (InTransit): new property, used to catch recursive definitions.
26829 * interface.cs: Implement `Define'.
26831 * modifiers.cs: Map Modifiers.constants to
26832 System.Reflection.TypeAttribute flags.
26834 * class.cs: Keep track of types and user-defined types.
26835 (BuilderInit): New method for creating an assembly
26836 (ResolveType): New function to launch the resolution process, only
26837 used by interfaces for now.
26839 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
26840 that are inserted into the name space.
26842 2001-06-08 Miguel de Icaza <miguel@ximian.com>
26844 * ARGH. I have screwed up my tree so many times due to the use of
26845 rsync rather than using CVS. Going to fix this at once.
26847 * driver.cs: Objetify driver. Load assemblies, use assemblies to
26850 2001-06-07 Miguel de Icaza <miguel@ximian.com>
26852 * Experiment successful: Use System.Type rather that our own
26855 2001-05-25 Miguel de Icaza <miguel@ximian.com>
26857 * cs-parser.jay: Removed nsAliases from here.
26859 Use new namespaces, handle `using XXX;'
26861 * namespace.cs: Reimplemented namespace handling, use a recursive
26862 definition of the class. Now we can keep track of using clauses
26863 and catch invalid using clauses.
26865 2001-05-24 Miguel de Icaza <miguel@ximian.com>
26867 * gen-treedump.cs: Adapted for all the renaming.
26869 * expression.cs (Expression): this class now has a Type property
26870 which returns an expression Type.
26872 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
26873 `Type', as this has a different meaning now in the base
26875 2001-05-22 Miguel de Icaza <miguel@ximian.com>
26877 * interface.cs, class.cs: Removed from all the sources the
26878 references to signature computation, as we can not do method
26879 signature computation during the parsing time, as we are not
26880 trying to solve at that point distinguishing:
26884 void a (NS.Blah x) {}
26887 Which depending on the context might be valid or not, as we do not
26888 know if Blah is the same thing as NS.Blah at that point.
26890 * Redid everything so the code uses TypeRefs now instead of
26891 Types. TypeRefs are just temporary type placeholders, that need
26892 to be resolved. They initially have a pointer to a string and the
26893 current scope in which they are used. This is used later by the
26894 compiler to resolve the reference to an actual Type.
26896 * DeclSpace is no longer a CIR.Type, and neither are
26897 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
26898 are all DeclSpaces, but no Types.
26900 * type.cs (TypeRefManager): This implements the TypeRef manager,
26901 which keeps track of all the types that need to be resolved after
26902 the parsing has finished.
26904 2001-05-13 Miguel de Icaza <miguel@ximian.com>
26906 * ARGH. We are going to have to store `foreach' as a class rather
26907 than resolving it, as we need to verify error 1579 after name
26908 resolution. *OR* we could keep a flag that says `This request to
26909 IEnumerator comes from a foreach statement' which we can then use
26910 to generate the error.
26912 2001-05-10 Miguel de Icaza <miguel@ximian.com>
26914 * class.cs (TypeContainer.AddMethod): we now add methods to the
26915 MethodGroup instead of the method hashtable.
26917 * expression.cs: Add MethodGroup abstraction, which gets us one
26918 step closer to the specification in the way we handle method
26921 * cs-parser.jay (primary_expression): qualified_identifier now
26922 tried to match up an identifier to a local variable reference or
26923 to a parameter reference.
26925 current_local_parameters is now a parser global variable that
26926 points to the current parameters for the block, used during name
26929 (property_declaration): Now creates an implicit `value' argument to
26932 2001-05-09 Miguel de Icaza <miguel@ximian.com>
26934 * parameter.cs: Do not use `param' arguments as part of the
26935 signature, per the spec.
26937 2001-05-08 Miguel de Icaza <miguel@ximian.com>
26939 * decl.cs: Base class for classes, structs and interfaces. This
26940 is the "Declaration Space"
26942 * cs-parser.jay: Use CheckDef for checking declaration errors
26943 instead of having one on each function.
26945 * class.cs: Factor out some code for handling error handling in
26946 accordance to the "Declarations" section in the "Basic Concepts"
26947 chapter in the ECMA C# spec.
26949 * interface.cs: Make all interface member classes derive from
26950 InterfaceMemberBase.
26952 2001-05-07 Miguel de Icaza <miguel@ximian.com>
26954 * Many things: all interfaces are parsed and generated in
26955 gen-treedump. Support for member variables, constructors,
26956 destructors, properties, constants is there.
26958 Beginning of the IL backend, but very little done, just there for
26961 2001-04-29 Miguel de Icaza <miguel@ximian.com>
26963 * cs-parser.jay: Fix labeled statement.
26965 * cs-tokenizer.cs (escape): Escape " and ' always.
26966 ref_line, ref_name: keep track of the line/filename as instructed
26967 by #line by the compiler.
26970 2001-04-27 Miguel de Icaza <miguel@ximian.com>
26972 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
26973 to match the values in System.CodeDOM.
26975 Divid renamed to Divide.
26977 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
26979 (Statements.set): remove.
26981 * System.CodeDOM/CodeCatchClause.cs: always have a valid
26984 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
26985 falseStatements always have valid values.
26987 * cs-parser.jay: Use System.CodeDOM now.