1 2007-09-25 Marek Safar <marek.safar@gmail.com>
3 * cs-parser.jay: Use only one block per query expression.
5 * generics.cs (GenericMethod.Define): Moved local variables collision
8 * linq.cs: Introduced QueryBlock and removed all blocks from query
11 2007-09-23 Marek Safar <marek.safar@gmail.com>
13 * generics.cs: Fixed lower-bound type inference issue for constructed
16 * linq.cs: Implemented nested queries.
18 2007-09-21 Marek Safar <marek.safar@gmail.com>
20 * cs-parser.jay: Query expression block are not related to each other.
22 2007-09-19 Marek Safar <marek.safar@gmail.com>
24 * generic.cs: Fixed type inference for generic delegate arguments whose
25 return types are generic delegates.
27 * linq.cs: Replaced ec.DeclContainer with ec.TypeContainer.
29 2007-09-17 Marek Safar <marek.safar@gmail.com>
31 * cs-parser.jay, linq.cs: Implemented query continuation.
33 2007-09-12 Marek Safar <marek.safar@gmail.com>
35 * cs-parser.jay: GroupJoin clause connected.
37 * generic.cs (TypeInferenceContext.InflateGenericArgument): Uses
38 inferred types to inflate delegate type argument.
40 * linq.cs: Fixed couple of typos.
41 (GroupJoin): Implemented group join clause.
43 2007-09-11 Marek Safar <marek.safar@gmail.com>
45 * cs-parser.jay: Single join clause connected.
47 * linq.cs: Moved argument creation into CreateSelector and renamed to
48 CreateSelectorArguments.
49 (ARangeVariableQueryClause.BuildQueryClause): Consider all lambda
50 arguments to be implicit.
51 (Join): Implemented single join clause.
53 2007-09-10 Marek Safar <marek.safar@gmail.com>
55 * cs-parser.jay: Create QueryStartClause for the first implicit from.
57 * generic.cs (TypeInterferenceContext.LowerBoundInference): Fixed crash
58 both U and V are not generic.
60 * linq.cs: Use standard method overload resolution for all methods.
62 2007-09-05 Marek Safar <marek.safar@gmail.com>
64 * cs-parser.jay: Plug into let clause.
66 * linq.cs: Implemented let clause, parameters refactoring.
68 2007-08-31 Marek Safar <marek.safar@gmail.com>
70 * generic.cs (TypeParameter): Uses common Emit.
71 (.IsClsComplianceRequired): Is never required.
73 2007-08-31 Marek Safar <marek.safar@gmail.com>
75 * cs-parser.jay: Terminates query block correctly. Fixed orderby
78 * generic.cs (TypeInferenceContext): Better error resistance.
80 * linq.cs: Implemented range variables, transparent identifiers and
83 2007-08-28 Marek Safar <marek.safar@gmail.com>
85 * cs-parser.jay: Anonymous type arguments can be simple name, syntax error
88 2007-08-23 Marek Safar <marek.safar@gmail.com>
90 * generic.cs (TypeInferenceV3.DoSecondPhase): Handle nested delegate
92 (IsTypeNonDependent, RemoveDependentTypes): Handle nested delegate
95 2007-08-21 Marek Safar <marek.safar@gmail.com>
97 * cs-parser.jay, linq.cs: Implemented orderby clause.
99 2007-08-20 Marek Safar <marek.safar@gmail.com>
101 * linq.cs: Switch to lambda expressions.
103 2007-08-20 Marek Safar <marek.safar@gmail.com>
105 * cs-parser.jay: An anonymous type can be empty.
107 2007-08-17 Marek Safar <marek.safar@gmail.com>
109 * linq.cs: MethodGroupExpr update.
111 2007-08-14 Marek Safar <marek.safar@gmail.com>
113 ** C# 3.0 Object and collection initializers
115 * cs-parser.jay: Grammar update.
117 2007-08-11 Marek Safar <marek.safar@gmail.com>
120 * generics.cs (TypeInferenceContext.LowerBoundInference): Don't
121 terminate type inference when an array is not paired.
123 2007-08-10 Miguel de Icaza <miguel@novell.com>
125 * generic.cs (DefaultValueExpression): Add CloneTo support to this
128 2007-08-09 Marek Safar <marek.safar@gmail.com>
130 ** C# 3.0 Anonymous Types (update to the latest standard)
132 * cs-parser.jay: Updated parameters and type names.
134 2007-08-03 Raja R Harinath <harinath@gmail.com>
136 * cs-parser.jay (class_declaration): Update to changes in class.cs.
137 Move calling of 'AddBasesForPart' to ...
138 (class_bases): ... here.
139 (struct_declaration, interface_declaration): Update to changes.
141 2007-08-02 Raja R Harinath <harinath@gmail.com>
143 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
144 * cs-parser.jay: Some whitespace cleanups.
145 (method_header): Refer to the correct symbol for parameters.
147 2007-08-01 Marek Safar <marek.safar@gmail.com>
150 * cs-parser.jay: Ignore partial keyword inside block expression.
152 2007-08-01 Marek Safar <marek.safar@gmail.com>
154 ** C# 3.0 Type Inference (major bits are working)
156 * generic.cs: Introduced new abstract class as an entry point to type
157 inference. Old type inference moved to TypeInferenceV2. Implemented C# 3.0
158 type inference as descibed in the standard in TypeInferenceV2 class.
160 * linq.cs (ALinqExpression): Disabled caching because it's wrong.
162 2007-07-25 Jb Evain <jbevain@novell.com>
164 * Makefile: don't install on net_2_1.
166 2007-07-18 Marek Safar <marek.safar@gmail.com>
168 * cs-parser.jay: Use ImplicitLambdaParameter everywhere.
170 2007-07-17 Marek Safar <marek.safar@gmail.com>
172 * cs-parser.jay: Correct placeholder for implicit linq parameter.
174 * linq: Add ImplicitArgument.
176 2007-07-03 Marek Safar <marek.safar@gmail.com>
178 * cs-parser.jay: Switch to ImplicitLambdaParameter.
180 2007-07-03 Marek Safar <marek.safar@gmail.com>
182 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
185 * linq.cs (QueryExpression.DoResolve): Resolve implicitly typed query
188 2007-06-20 Marek Safar <marek.safar@gmail.com>
190 * cs-parser.jay: Reworked var keyword handling. We cannot handle var as
191 static keyword because var becomes keyword only if no type with the var
192 name exists in the scope of variable which uses var declaration.
194 2007-06-18 Marek Safar <marek.safar@gmail.com>
196 * cs-parser.jay: Add implicitly typed local variable checks.
198 2007-06-15 Marek Safar <marek.safar@gmail.com>
200 * cs-parser.jay: Correctly split generic arguments and generic
201 parameters. Correctly implemented typeof of generic unbound types.
203 2007-06-14 Marek Safar <marek.safar@gmail.com>
205 * cs-parser.jay: Assembly and module attributes must precede all other
206 elements except using clauses and extern alias declarations.
208 2007-06-08 Marek Safar <marek.safar@gmail.com>
210 * cs-parser.jay: Uses newly defined GroupBy class.
212 * linq.cs (GroupBy): Implemented.
213 (AQueryClause.BuildQueryClause): Refactored to allow customize query
216 2007-06-08 Marek Safar <marek.safar@gmail.com>
218 * generics.cs (InferTypeArguments): Uses AnonymousMethodExpression
221 2007-06-06 Marek Safar <marek.safar@gmail.com>
223 * generics.cs (TypeArguments): New contructor fow known number of
226 2007-06-04 Raja R Harinath <rharinath@novell.com>
228 * linq.cs (Select.DoResolve): Pass the created parameters to the
231 2007-05-29 Raja R Harinath <rharinath@novell.com>
233 * cs-parser.jay: Update to changes in ToplevelBlock.
234 (top_current_block): Remove.
236 2007-05-27 Raja R Harinath <harinath@gmail.com>
238 * cs-parser.jay: Update to new ExplicitBlock invariant.
240 * cs-parser.jay: Update to changes introduced in Block and
243 2007-05-25 Raja R Harinath <rharinath@novell.com>
245 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
246 modifying current_block directly.
248 2007-05-22 Scott Peterson <lunchtimemama@gmail.com>
250 * cs-parser.jay: Implemented automatic properties (C# 3.0)
252 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
254 * cs-parser.jay: Improved grammar for object and collection
257 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
259 This code is contributed under the MIT X11 license
261 * cs-parser.jay: Added support for C# 3.0 language features:
262 Variable type inference (the "var" keyword)
265 Object initialization
266 Collection initialization
268 2007-05-06 Marek Safar <marek.safar@gmail.com>
271 * cs-parser.jay: Add special handling for coalescing operator.
273 2007-05-02 Raja R Harinath <rharinath@novell.com>
275 Fix regression in cs0631-3.cs
276 * cs-parser.jay (operator_declarator): Add opt_attributes to error
277 fallback. Make error fallback catch more cases.
279 2007-05-01 Miguel de Icaza <miguel@novell.com>
281 * cs-parser.jay: Allow parameters in operator declarations to have
284 2007-04-27 Miguel de Icaza <miguel@novell.com>
286 * generic.cs (TypeManager.LambdaInfer): now this routine will
287 make only one inference from the list of lambda expression that
288 have not participated in inferring a type.
290 (TypeManager.InferTypeArguments): The logic that drives the type
291 inference in lambda expressions is now driven here.
293 2007-04-23 Miguel de Icaza <miguel@novell.com>
295 * generic.cs: Large update to LambdaInfer, this is merely an
296 update to start the lambda type inference. It is by no means
297 complete. It is currently merely able to build a sample program
298 (with no iteration for the type parameters).
300 2007-04-12 Duncan Mak <duncan@a-chinaman.com>
302 * cs-parser.jay (interface_method_declaration_body): Fixed typo.
304 2007-04-08 Marek Safar <marek.safar@gmail.com>
306 * cs-parser.jay, linq.cs: First select implementation (hacky).
308 * generic.cs (InferTypeArguments): Simplified.
310 2007-03-31 Marek Safar <marek.safar@gmail.com>
312 * generic.cs (InferTypeArguments): Restored validation check.
313 (InferTypeArguments): Move all logic to Compatible method for re-usability.
315 2007-03-25 Marek Safar <marek.safar@gmail.com>
317 * generic.cs (InferTypeArguments): Infer arguments before they are used
318 for compatibility check.
320 2007-03-15 Marek Safar <marek.safar@gmail.com>
322 * generic.cs (InflatedConstraints): Fixed the check order.
323 (TypeArguments.Resolve): Small optimization for generic parameters.
324 (InferTypeArguments): Add infering support for anonymous methods.
326 2007-03-15 Martin Baulig <martin@ximian.com>
331 (TypeParameter.HasConstructorConstraint): Removed.
332 (ConstraintChecker.HasDefaultConstructor): Removed the
333 `TypeBuilder' argument here; correctly check for the ctor
334 constraint on type parameters.
336 2007-03-15 Martin Baulig <martin@ximian.com>
341 (TypeParameter): Create a `MemberCache' here as well. Note that
342 we need to create this on-demand when it's actually used.
344 2007-03-10 Marek Safar <marek.safar@gmail.com>
346 * generic.cs (TypeArguments.Resolve): Avoid redundant checks.
348 2007-03-09 Raja R Harinath <rharinath@novell.com>
350 * cs-parser.jay (WHERE): Move before QUERY_FIRST_TOKEN. 'where'
351 is a valid keyword outside a linq expression too.
353 2007-03-03 Marek Safar <marek.safar@gmail.com>
355 * cs-parser.jay: Implemented basic linq grammar.
357 * linq.cs: New file for hosting query specific classes.
359 2007-02-26 Marek Safar <marek.safar@gmail.com>
361 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
363 2007-02-20 Marek Safar <marek.safar@gmail.com>
366 * cs-parser.jay: Anonymous container starts at constructor declaration
367 and not at block beginning because it has to be usable in constructor
370 2007-02-18 Marek Safar <marek.safar@gmail.com>
372 A fix for bug #80493 by Atsushi Enomoto
373 * cs-parser.jay: Ignore invalid attribute target.
375 2007-02-15 Miguel de Icaza <miguel@novell.com>
377 * Remove the call to SetExpression for lambda expressions, we do
378 not actually need it.
380 Remove expression tracking code as its not needed.
382 2007-02-11 Miguel de Icaza <miguel@novell.com>
384 * cs-parser.jay (lambda_expression_body): when the body is an
385 expression add a statement of the form:
387 contextual-return expression.
389 Where `contextual-return' is similar to `return', the difference
390 being that if the delegate that the lambda will be converted to
391 has a void return type, it will check that the result is a
392 ExpressionStatement and the result is a plain ret (no return
393 values on the stack). If the return type of the delegate is of a
394 given type, this turns into a return with a value and does the
395 regular checking to check that the computed value can be
396 implicitly converted to the delegate return.
398 2007-01-30 Miguel de Icaza <miguel@novell.com>
400 * cs-parser.jay (anonymous_method_expression): move the
401 before/after productions to the start_anonymous and end_anonymous
402 methods so the code can be reused for lambda functions.
404 (lambda_expression_body): wrap expressions implicitly into a
407 (block): factor out the setup/teardown of parsing a block so we
408 can reuse that in lambda_expression_body
410 (lambda_expression): use new anonymous method helper methods.
412 2007-01-29 Miguel de Icaza <miguel@novell.com>
414 * cs-parser.jay: oob_stack make it static (am guessing that is why
415 we no longer initialize it anymore) and reuse it across
418 2007-01-28 Miguel de Icaza <miguel@novell.com>
420 * cs-parser.jay (open_parens): Introduce new non-terminal that
421 abstracts OPEN_PARENS and OPEN_PARENS_LAMBDA as the later can now
422 be returned in places where types are followed by identifiers
423 (this is expected in declaration, fixed, using, foreach and catch
426 Use open_parens in those places, keep OPEN_PARENS in the
429 cs-parser.jay: New grammar bits for parsing lambda expressions.
431 2007-01-28 Raja R Harinath <rharinath@novell.com>
433 Fix #80534, gtest-309.cs
434 * generic.cs (UnifyType): Rename from InferType. Make unification
435 of generic insts simpler and don't insist on inferring all generic
436 parameters in a single generic inst unification.
438 (InferGenericInstance): Remove.
439 Analysis and initial patch by David Mitchell <dmitchell@logos.com>.
441 2007-01-20 Marek Safar <marek.safar@gmail.com>
443 * cs-parser.jay: Better parameter error handling.
445 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
446 Raja R Harinath <rharinath@novell.com>
448 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
449 Note the order in which accessors are declared in the source.
451 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
453 * generic.cs (TypeParameter.FindMembers): Use the generic
454 constraints, not the constraints to check for methods (first fix
457 2006-12-30 Marek Safar <marek.safar@gmail.com>
459 * cs-parser.jay: Better syntax errors handling.
461 2006-11-21 Marek Safar <marek.safar@gmail.com>
463 * cs-parser.jay: Tiny change to work with mcs tokenizer.
465 * cs-tokenizer.cs: Remove after unification with mcs.
467 2006-10-28 Marek Safar <marek.safar@gmail.com>
470 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
473 2006-10-26 Marek Safar <marek.safar@gmail.com>
476 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
478 2006-10-25 Brian Crowell <brian@fluggo.com>
481 * generic.cs (CheckConstraints): Allow generic parameters with
482 inheritance constraints to satisfy reference type constraints.
484 2006-10-09 Martin Baulig <martin@ximian.com>
487 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
489 2006-09-25 Martin Baulig <martin@ximian.com>
491 * class.cs: Remove after unification with mcs source.
493 2006-09-24 Raja R Harinath <harinath@gmail.com>
495 * convert.cs: Remove after unification with mcs source.
497 2006-09-24 Marek Safar <marek.safar@seznam.cz>
499 * class.cs (MemberBase.VerifyClsCompliance): When method has type
500 parameters verify them as well.
502 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
503 the type parameter constraints.
504 (Generics.VerifyClsCompliance): Ditto.
506 2006-09-24 Marek Safar <marek.safar@seznam.cz>
508 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
509 for anonymous block with out argument.
511 2006-09-24 Marek Safar <marek.safar@seznam.cz>
513 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
514 not used private events only.
516 2006-09-23 Marek Safar <marek.safar@seznam.cz>
518 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
520 * cs-parser.jay: Parse correctly cast of default (T).
522 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
523 Store original type via EmptyConstantCast.
525 2006-09-22 Martin Baulig <martin@ximian.com>
527 * delegate.cs: Removed; this file is now shared with mcs.
529 * attribute.cs: Removed; this file is now shared with mcs.
531 2006-09-22 Martin Baulig <martin@ximian.com>
533 * ecore.cs: Removed; this file is now shared with mcs.
535 2006-09-21 Marek Safar <marek.safar@seznam.cz>
537 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
539 * ecore.cs (NullCast): Derives from NullConstant.
541 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
544 2006-09-21 Martin Baulig <martin@ximian.com>
546 * decl.cs: Removed; this file is now shared with mcs.
548 2006-09-21 Raja R Harinath <rharinath@novell.com>
550 * rootcontext.cs: Remove after unification with mcs source.
552 * report.cs: Remove after unification with mcs source.
553 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
555 (InitGenerics, CleanUpGenerics): Remove.
557 * support.cs: Remove after unification with mcs source.
559 2006-09-20 Raja R Harinath <rharinath@novell.com>
561 * codegen.cs: Remove after unification with mcs source.
563 2006-09-19 Martin Baulig <martin@ximian.com>
565 * expression.cs: Removed; this file is now shared with mcs.
567 2006-09-19 Martin Baulig <martin@ximian.com>
570 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
571 (TypeManager.DropGenericTypeArguments): Likewise.
572 (TypeManager.DropGenericMethodArguments): Likewise.
573 (TypeManager.GetTypeArguments): Likewise.
574 (TypeManager.HasGenericArguments): Likewise.
576 2006-09-19 Martin Baulig <martin@ximian.com>
578 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
580 2006-09-19 Martin Baulig <martin@ximian.com>
582 * typemanager.cs: Removed; this file is now shared with mcs.
584 2006-09-16 Raja R Harinath <rharinath@novell.com>
586 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
587 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
589 2006-09-16 Marek Safar <marek.safar@seznam.cz>
592 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
593 only if parent type is class.
594 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
597 2006-09-15 Marek Safar <marek.safar@seznam.cz>
600 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
602 * typemanager.cs(CSharpName): Converts NullType to null.
604 2006-09-15 Martin Baulig <martin@ximian.com>
606 * pending.cs: Removed; this file is now shared with mcs.
608 2006-09-15 Martin Baulig <martin@ximian.com>
610 * statement.cs: Removed; this file is now shared with mcs.
612 2006-09-15 Martin Baulig <martin@ximian.com>
614 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
616 * driver.cs: Removed the `--broken-cycles' argument.
618 2006-09-15 Martin Baulig <martin@ximian.com>
620 * namespace.cs: Removed; this file is now shared with mcs.
622 2006-09-15 Martin Baulig <martin@ximian.com>
624 * decl.cs (MemberName): Minor code cleanups.
626 2006-09-15 Martin Baulig <martin@ximian.com>
628 * parameter.cs: Removed; this file is now shared with mcs.
630 2006-09-15 Martin Baulig <martin@ximian.com>
632 * enum.cs: Removed; this file is now shared with mcs.
634 2006-09-15 Martin Baulig <martin@ximian.com>
636 * Makefile: Define `GMCS_SOURCE'.
638 * flowanalysis.cs: Removed; this file is now shared with mcs.
640 2006-09-15 Martin Baulig <martin@ximian.com>
642 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
643 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
644 doc.cs - they are now shared with mcs.
646 * gmcs.exe.sources: Include these files from ../mcs/.
648 2006-09-15 Martin Baulig <martin@ximian.com>
650 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
651 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
653 2006-09-14 Marek Safar <marek.safar@seznam.cz>
655 * assign.cs, ecore.cs, expression.cs: Share error message text.
656 * class.cs (FieldMember.Define): Check for variable of static type.
657 * decl.cs (check_type_parameter): Report correct type name.
658 * driver.cs (LoadAssembly): Uses error output for errors.
659 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
660 (TypeArguments.Resolve): Static class cannot be used as an argument.
661 * statement.cs (ResolveMeta): Constants cannot be generic types.
663 2006-09-12 Martin Baulig <martin@ximian.com>
665 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
667 * convert.cs (Convert.Array_To_IList): Moved here and correctly
668 implement it; fixes #79345.
670 2006-09-08 Marek Safar <marek.safar@seznam.cz>
672 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
674 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
676 * generic.cs: Improved error messages.
677 * typemanager.cs (RemoveGenericArity): Made public.
679 2006-09-08 Martin Baulig <martin@ximian.com>
681 * typemanager.cs (TypeManager.interlocked_type): New public field.
682 (TypeManager.int_interlocked_compare-exchange): New public field.
683 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
684 enumerator types here and call InitGenericCoreTypes().
685 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
686 after calling InitEnumUnderlyingTypes().
689 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
690 `classes_second_stage'.
692 2006-09-07 Marek Safar <marek.safar@seznam.cz>
694 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
696 * statement.cs (Block.Variables): Made public.
698 2006-09-07 Martin Baulig <martin@ximian.com>
701 (MainDriver): Revert r62663 from Marek; see #70506 for details.
703 2006-09-01 Martin Baulig <martin@ximian.com>
706 (TypeManager.IsIList): Also handle base classes and interfaces.
708 2006-09-01 Raja R Harinath <rharinath@novell.com>
711 * expression.cs (Invocation.MoreSpecific): Check for reference
714 2006-08-29 Miguel de Icaza <miguel@novell.com>
716 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
718 2006-08-17 Miguel de Icaza <miguel@novell.com>
720 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
721 #52019 and #79064, the use of the \uXXXX sequence in source code
722 to represent unicode characters.
724 2006-08-15 Marek Safar <marek.safar@seznam.cz>
726 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
728 * class.cs, ecore.cs, statement.cs: Merged to one error message.
730 2006-08-14 Raja R Harinath <rharinath@novell.com>
733 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
734 parameter too. This only avoids a parse error -- the semantic
735 error is caught elsewhere.
737 2006-08-13 Miguel de Icaza <miguel@novell.com>
739 * assign.cs: Catch attempts to assign to a method groups in += and
742 2006-08-13 Marek Safar <marek.safar@seznam.cz>
745 * cs-parser.jay: Don't destroy current array type by typeof of array's.
747 2006-08-12 Marek Safar <marek.safar@seznam.cz>
749 * cs-parser.jay: Check whether a constraint clause has already been
750 specified for type parameter.
751 * generic.cs (Constraints): Exposed location.
753 2006-08-12 Marek Safar <marek.safar@seznam.cz>
755 * class.cs (Method.Define): Issue a warning when generic method looks like
757 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
759 * report.cs: New warning number.
761 2006-08-09 Marek Safar <marek.safar@seznam.cz>
763 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
765 * decl.cs (MemberCache.FindMembers): When container is interface we need to
766 search all base interfaces as a member can be ambiguous.
767 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
768 Constructor member type filter.
769 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
770 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
771 reporting for returned memberinfos.
772 * report.cs: Updated.
773 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
774 version to work on all runtimes.
775 (TypeManager.RealMemberLookup): Removed members filtering.
777 2006-08-08 Raja R Harinath <rharinath@novell.com>
779 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
780 (PropertyExpr.EmitAssign): Likewise.
781 * expression.cs (Indirection.EmitAssign): Likewise.
782 (LocalVariableReference.EmitAssign): Likewise.
783 (ParameterReference.EmitAssign): Likewise.
784 (Invocation.EmitArguments): Likewise.
785 (ArrayAccess.EmitAssign): Likewise.
786 (IndexerAccess.EmitAssign): Likewise.
787 (This.EmitAssign): Likewise.
788 (ConditionalLogicalOperator.Emit): Likewise.
791 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
792 instead of ArrayList. If the hashtable has a LocalBuilder, don't
793 leave it in after returning it.
794 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
796 2006-08-06 Marek Safar <marek.safar@seznam.cz>
798 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
801 2006-08-05 Marek Safar <marek.safar@seznam.cz>
803 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
804 with different type names.
805 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
807 2006-08-03 Raja R Harinath <rharinath@novell.com>
809 Fix cs0146-3.cs and cs0146-4.cs.
810 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
811 enclosing types don't depend on the current type.
813 2006-08-02 Raja R Harinath <rharinath@novell.com>
816 * class.cs (TypeContainer.DoDefineMembers): Use
817 FindBaseMemberWithSameName on Parent, since we're interested in
818 whether we hide inherited members or not.
819 (FindBaseMemberWithSameName): Make slightly more robust.
822 * codegen.cs (IResolveContext.GenericDeclContainer): New.
823 (EmitContext): Implement new interface requirement.
824 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
825 * decl.cs (MemberCore): Likewise.
826 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
827 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
828 ec.GenericDeclContainer to check for generic parameters.
829 (SimpleName.DoSimpleNameResolve): Likewise.
830 * generic.cs (TypeParameter.DeclContainer): Remove override.
832 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
833 declspaces for doppelgangers too.
834 (UsingEntry): Implement IResolveContext.
835 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
836 'this' as the resolve context.
837 (LocalAliasEntry): Likewise.
839 Implement parts of #77403
840 * roottypes.cs (RootDeclSpace): New. Used to represent the
841 toplevel declaration space. Each namespace declaration introduces
842 a "partial" root declaretion space.
843 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
844 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
845 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
846 from 'current_namespace.SlaveDeclSpace'.
847 (namespace_declaration): Likewise.
848 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
849 check. It can't happen now.
850 * decl.cs (DeclSpace.LookupType): Likewise.
851 * driver.cs (MainDriver): Sanity check.
853 2006-08-01 Raja R Harinath <rharinath@novell.com>
855 * decl.cs (DeclSpace.FindNestedType): Remove.
856 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
857 LookupTypeContainer to get the container of the nested type.
858 * class.cs (TypeContainer.FindNestedType): Make non-override.
860 2006-07-31 Raja R Harinath <rharinath@novell.com>
862 * decl.cs (DeclSpace.PartialContainer): Move field from ...
863 * class.cs (TypeContainer.PartialContainer): ... here.
864 (TypeContainer.AddBasesForPart): New helper.
865 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
867 * cs-parser.jay (current_class): Convert to DeclSpace.
868 (struct_declaration, interface_declaration, class_declaration):
869 Use AddBasesForPart instead of .Bases directly.
870 * const.cs, iterators.cs: Update to changes.
872 2006-07-28 Raja R Harinath <rharinath@novell.com>
874 * class.cs (TypeContainer.AddMemberType): Rename from
876 (TypeContainer.AddMember): Rename from AddToMemberContainer.
877 (AddTypeContainer): New. Combine AddClassOrStruct and
879 (AddPartial): Update. Add 'is_partial' argument.
880 * roottypes.cs: Update to changes.
881 * cs-parser.jay (push_current_class): New helper for handling
882 current_container and current_class.
883 (struct_declaration, interface_declaration, class_declaration):
886 2006-07-26 Raja R Harinath <rharinath@novell.com>
888 * roottypes.cs: Rename from tree.cs.
890 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
891 * tree.cs (Tree, ITreeDump): Remove types.
892 * rootcontext.cs (tree, Tree): Remove fields.
893 (root, ToplevelTypes): New.
894 * *.cs: Update to rename.
896 * tree.cs (Tree.RecordDecl): Remove.
897 (RootTypes.AddToTypeContainer): Record the toplevel type in its
899 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
901 2006-07-23 Raja R Harinath <harinath@gmail.com>
903 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
904 DoFlowAnalysis and OmitStructFlowAnalysis here.
905 (ec.With): Rename from WithUnsafe and generalize.
906 (ec.WithCheckState): Remove. All users can be handled by 'With'.
907 (ec.WithFlowAnalyis): New.
908 * ecore.cs, expression.cs, statement.cs: Update.
910 2006-07-22 Raja R Harinath <harinath@gmail.com>
912 * statement.cs (Block.ResolveMeta): Simplify slightly.
914 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
915 multiple boolean fields. Convert InUnsafe, constant_check_state,
916 check_state to flags.
917 (CheckState, ConstantCheckState): Update.
918 (InUnsafe): New read-only property.
919 (FlagsHandle): Rename from CheckStateHandle and convert to handle
921 (WithUnsafe): New helper similar to WithCheckState.
922 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
923 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
925 2006-07-21 Raja R Harinath <rharinath@novell.com>
927 Make comparisons use the same IL irrespective of whether they're
928 in a 'checked' or 'unchecked' context: one of the issues in #78899
929 * codegen.cs (EmitContext.CheckState): Make read-only property.
930 (EmitContext.ConstantCheckState): Likewise.
931 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
932 helper that implement a save/restore stack for CheckState
933 values. This is the only way to change check-state.
934 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
935 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
936 (CheckedExpr.EmitBranchable): New forwarding method.
937 (UnCheckedExpr): Likewise.
938 * statement.cs (Block.ResolveMeta): Use WithCheckState.
939 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
940 (Checked.Resolve, checked.DoEmit): Likewise.
942 2006-07-21 Martin Baulig <martin@ximian.com>
944 * generic.cs (TypeManager.InferType): When inferring an array
945 type, also allow IList<T> and ICollection<T>. Fixes #78900.
947 2006-07-21 Martin Baulig <martin@ximian.com>
949 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
950 and allow IList`1 and all its base interfaces.
952 * convert.cs (Convert.ImplicitReferenceConversion): Allow
953 converting from an array-type of T to IList<T>.
955 2006-07-21 Martin Baulig <martin@ximian.com>
957 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
959 2006-07-20 Miguel de Icaza <miguel@novell.com>
961 * anonymous.cs: Cache the resolved anonymous delegate, and return
962 this so that the ResolveTopBlock is only triggered once, not
965 Currently we trigger ResolvetopBlock twice due to a first pass of
966 argument check compatibility, and a second pass that does the
969 2006-07-15 Marek Safar <marek.safar@seznam.cz>
971 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
973 * rootcontext.cs (Reset): Add helper_classes.
975 2006-07-15 Marek Safar <marek.safar@seznam.cz>
978 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
981 2006-07-13 Miguel de Icaza <miguel@novell.com>
983 * statement.cs (Lock): Handle expressions of type
984 TypeManager.null_type specially. Fixes #78770
986 2006-07-08 Marek Safar <marek.safar@seznam.cz>
988 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
991 2006-07-08 Marek Safar <marek.safar@seznam.cz>
993 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
994 for accessors as well.
995 * ecore.cs (EventExpr): Add AccessorTable.
997 2006-07-03 Martin Baulig <martin@ximian.com>
999 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
1000 instances of value types.
1002 * convert.cs (Convert.ExplicitConversion): Correctly handle
1003 object->nullable conversions.
1005 2006-07-01 Marek Safar <marek.safar@seznam.cz>
1008 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
1009 for CS0122 where appropriate.
1010 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
1012 (Filter): Assembly can be null in the case of top level attributes.
1014 2006-06-28 Raja R Harinath <rharinath@novell.com>
1017 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
1018 no arguments, return 'false': nothing can be inferred.
1020 2006-06-25 Marek Safar <marek.safar@seznam.cz>
1024 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
1025 is done at global level.
1027 2006-06-24 Marek Safar <marek.safar@seznam.cz>
1029 A fix for #77002, Implemented TypeForwarder support.
1031 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
1032 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
1034 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
1035 * typemanager.cs (): Add type_forwarder_attr_type.
1037 2006-06-24 Marek Safar <marek.safar@seznam.cz>
1039 * report.cs: Add CS0469 warning.
1041 2006-06-22 Martin Baulig <martin@ximian.com>
1044 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
1045 for interfaces; fixes #78686, which is a modification of #78380
1046 with interfaces instead of classes.
1048 2006-06-21 Martin Baulig <martin@ximian.com>
1050 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
1051 the `try'-block, so we also report CS0016 etc. there.
1053 2006-06-21 Martin Baulig <martin@ximian.com>
1055 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
1056 handle SetAssigned() and SetMemberIsUsed() for generic types;
1059 2006-06-21 Martin Baulig <martin@ximian.com>
1062 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
1064 2006-06-21 Martin Baulig <martin@ximian.com>
1066 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
1067 also report CS1686 for parameters.
1069 2006-06-21 Martin Baulig <martin@ximian.com>
1071 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
1072 instead of an error if the value is not implicitly convertible to
1073 the switch types; fixes #77964.
1075 2006-06-21 Raja R Harinath <rharinath@novell.com>
1078 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
1079 FieldBuilder is null.
1082 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
1083 'left' and 'right' before error-checking.
1085 2006-06-19 Martin Baulig <martin@ximian.com>
1088 (Convert.ImplicitConversionStandard): Cleanup and correctly
1089 implement nullable conversions.
1090 (Convert.ImplicitStandardConversionExists): Likewise.
1091 (Convert.ExplicitConversion): Likewise.
1093 2006-06-19 Martin Baulig <martin@ximian.com>
1096 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
1097 methods; make the ctors protected.
1099 2006-06-19 Martin Baulig <martin@ximian.com>
1101 Fixed #78380; added gtest-273.cs.
1104 (Expression.ResolveAsBaseTerminal): Move the constraint checking
1105 into ResolveAsTypeTerminal().
1108 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
1109 TypeManager.FindMembers() to check for the default ctor.
1111 2006-06-18 Marek Safar <marek.safar@seznam.cz>
1113 * generic.cs: Fixed NullableInfo accessibility.
1115 2006-06-16 Martin Baulig <martin@ximian.com>
1118 (Constraints.InflatedConstraints.inflate): Correctly inflate
1119 generic types; fixes #78400.
1121 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
1123 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
1125 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
1126 (FieldExpr.DoResolve): likewise.
1127 (PropertyExpr.InstanceResolve): likewise.
1128 (EventExpr.InstanceResolve): likewise.
1130 2006-06-15 Martin Baulig <martin@ximian.com>
1133 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
1134 argument; always allow a `null' label if true.
1135 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
1136 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
1137 we have a `null' label and mark the new `null_target' label;
1138 default to the `default' label.
1139 (Switch.Resolve): Add support for nullable types. Fixes #78630.
1141 2006-06-15 Martin Baulig <martin@ximian.com>
1143 * class.cs (Operator.Define): Allow an implicit/explicit operator
1144 to convert to/from a nullable value of the enclosing type.
1146 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
1147 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
1150 (Convert.ImplicitStandardConversionExists): Add support for lifted
1151 implicit/explicit conversions.
1152 (Convert.ImplicitConversionStandard): Likewise.
1154 2006-06-13 Martin Baulig <martin@ximian.com>
1156 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
1157 type arguments and create a ConstructedType if necessary. Fixes #78400.
1159 2006-06-04 Marek Safar <marek.safar@seznam.cz>
1161 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
1162 attribute applicable tests for attribute argument.
1164 2006-06-02 Raja R Harinath <rharinath@novell.com>
1167 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
1168 (Binary.OverloadResolve_PredefinedIntegral): New.
1169 (Binary.OverloadResolve_PredefinedFloating): New.
1170 (Binary.OverloadResolve_PredefinedString): New.
1171 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
1172 Follow the standard more closely, and treat numeric promotions in
1173 terms of overload resolution.
1174 (Binary.CheckShiftArguments): Simplify.
1176 2006-06-01 Raja R Harinath <rharinath@novell.com>
1178 * flowanalysis.cs (MyBitVector): Simplify representation.
1179 (MyBitVector.Clone): Avoid allocating BitArray.
1180 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
1181 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
1182 (*): Update. Change all references to MyBitVector.And and
1183 MyBitVector.Or to &= and |=.
1185 2006-05-31 Raja R Harinath <rharinath@novell.com>
1187 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
1188 Use bne.un instead of ceq+brfalse.
1191 * typemanager.cs (IsUnmanagedType): Disallow generic types and
1194 2006-05-29 Raja R Harinath <rharinath@novell.com>
1197 * cs-parser.jay (formal_parameter_list): Extend the pattern below
1198 to param arguments too.
1200 2006-05-26 Miguel de Icaza <miguel@novell.com>
1202 * cs-parser.jay: Catch another parsing form for arglist being
1203 followed by other arguments. Fixes #78313.
1205 2006-05-25 Raja R Harinath <rharinath@novell.com>
1208 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
1209 also when one of the operands is a null literal.
1210 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
1211 to improve clarity, and generate slightly better code.
1213 2006-05-24 Raja R Harinath <rharinath@novell.com>
1215 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
1216 checking of out parameters to ...
1217 (FlowBranchingToplevel.Merge): ... here.
1218 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
1219 set, propagate the origin upward, and only complain if there was
1221 (FlowBranchingException.AddContinueOrigin): Likewise.
1222 (FlowBranchingException.AddReturnOrigin): Likewise.
1223 (FlowBranchingException.AddGotoOrigin): Likewise.
1225 2006-05-23 Raja R Harinath <rharinath@novell.com>
1227 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
1228 unreachable, skip it.
1229 (FlowBranchingException.Merge): Always propagate jumps, even if
1230 the finally block renders subsequent code unreachable.
1232 2006-05-18 Raja R Harinath <rharinath@novell.com>
1235 * statement.cs (Goto.Resolve): Move responsibility for resolving
1236 'goto' to FlowBranching.AddGotoOrigin.
1237 (Goto.SetResolvedTarget): New. Callback to set the
1238 LabeledStatement that's the target of the goto.
1239 (Goto.DoEmit): Use Leave instead of Br when crossing an
1240 unwind-protect boundary.
1241 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
1242 LookupLabel and adjust to new semantics.
1243 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
1244 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
1245 Goto.SetResolvedTarget to update target.
1246 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
1247 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
1248 AddBreakOrigin & co. Delay propagation until ...
1249 (FlowBranchingException.Merge): ... this.
1251 * statement.cs (Block.Resolve): Always depend on flow-branching to
1252 determine unreachability. Kill workaround that originally emitted
1253 only one statement after an "unreachable" label (see infloop in
1256 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
1257 This is still "wrong", but anything better would probably need a
1258 multi-pass algorithm.
1259 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
1260 usage vector. Force current usage vector to be reachable, to
1261 optimistically signify backward jumps.
1262 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
1264 (FlowBranchingLabeled.Merge): New. If no backward jump was
1265 detected, return the original salted-away usage vector instead,
1266 updated with appropriate changes. Print unreachable warning if
1268 * statement.cs (Block.Resolve): Don't print unreachable warning on
1269 a labeled statement.
1271 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
1273 * driver.cs: Pass filename without path to AssemblyBuilder's
1274 AddResourceFile. Fixes bug #78407.
1276 2006-05-17 Raja R Harinath <rharinath@novell.com>
1278 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
1279 * flowanalysis.cs (FlowBranchingLabeled): ... here.
1280 (FlowBranching.MergeChild): Overwrite
1281 reachability information from Labeled branchings too.
1283 2006-05-16 Raja R Harinath <rharinath@novell.com>
1285 * statement.cs (Goto.Resolve): Merge jump origins here ...
1286 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
1288 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
1289 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
1290 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
1291 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
1293 * statement.cs (Goto.Resolve): ... not here.
1294 (Goto.Emit): Remove CS1632 check.
1296 2006-05-14 Marek Safar <marek.safar@seznam.cz>
1298 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
1301 2006-05-11 Raja R Harinath <rharinath@novell.com>
1303 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
1304 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
1305 (FlowBranchingException.Label): Likewise.
1307 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
1309 (MyBitVector.Or): Use it to avoid losing information (Count).
1310 (FlowBranching.MergeOrigins): Likewise.
1312 * flowanalysis.cs (UsageVector.IsDirty): Remove.
1313 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
1314 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
1315 (UsageVector.ToString): Simplify.
1316 (UsageVector.MergeSiblings): Move here from ...
1317 (FlowBranching.Merge): ... here.
1318 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
1321 2006-05-10 Raja R Harinath <rharinath@novell.com>
1323 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
1324 null bitvector is treated as all-true.
1326 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
1327 (MyBitVector): Rationalize invariants. 'vector != null' implies
1328 that we have our own copy of the bitvector. Otherwise,
1329 'InheritsFrom == null' implies all inherited bits are true.
1331 2006-05-09 Marek Safar <marek.safar@seznam.cz>
1333 * statement.cs (LocalInfo): Add IsConstant.
1334 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
1335 local variable for constants.
1337 2006-05-09 Raja R Harinath <rharinath@novell.com>
1339 * flowanalysis.cs (MyBitVector.Empty): New.
1340 (MyBitVector): Don't allow InheritedFrom to be null.
1341 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
1342 (UsageVector, FlowBranching): Update to changes.
1344 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
1345 recursion. The 'Parent == null' condition isn't sufficient for
1347 (FlowBranching.AddBreakOrigin): Likewise.
1348 (FlowBranching.AddContinueOrigin): Likewise.
1349 (FlowBranching.AddReturnOrigin): Likewise.
1350 (FlowBranching.StealFinallyClauses): Likewise.
1351 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
1352 (FlowBranching.CheckOutParameters): Likewise.
1353 (FlowBranchingToplevel): Terminate all the above recursions here.
1354 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
1355 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
1357 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
1359 (FlowBranchingToplevel): New. Empty for now.
1360 (FlowBranching.MergeTopBlock): Update.
1361 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
1362 branching for the anonymous delegate.
1363 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
1365 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
1366 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
1367 information at the start of the merge. Reorganize.
1369 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1371 * class.cs (MethodData.Define): Method cannot implement interface accessor.
1373 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1375 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
1376 to newly introduced ctor.
1378 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
1379 message to one place.
1380 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
1383 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1385 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
1387 * ecore.cs (Expression.ResolveAsConstant): Updated.
1389 * statement.cs (ResolveMeta): Updated.
1391 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1393 * cs-parser.jay: __arglist cannot be used in initializer.
1395 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1398 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
1401 2006-05-05 Raja R Harinath <rharinath@novell.com>
1403 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
1404 (LabeledStatement): Add 'name' parameter.
1405 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
1406 (Block.AddLabel): Update to changes.
1407 * cs-parser.jay (labeled_statement): Likewise.
1409 * flowanalysis.cs (BranchingType.Labeled): New.
1410 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
1411 (FlowBranchingLabeled): New. Does nothing for now, but will
1412 eventually handle 'goto' flows.
1413 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
1414 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
1415 that's terminated ...
1416 (Block.Resolve): ... here.
1418 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
1419 (UsageVector.MergeFinallyOrigins): Likewise.
1420 (FlowBranching.InTryOrCatch): Likewise.
1421 (FlowBranching.AddFinallyVector): Likewise.
1422 (FlowBranchingException): Update to changes.
1425 * statement.cs (Return.Resolve): Move error checking to ...
1426 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
1427 (FlowBranchingException): Handle return origins like break and
1429 (FlowBranching.UsageVector.CheckOutParameters): Remove.
1431 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1434 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
1437 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1440 * class.cs (MethodData.Define): Do public accessor check only when method
1441 implements an interface.
1443 2006-05-04 Raja R Harinath <rharinath@novell.com>
1445 Remove special handling of 'break'
1446 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
1447 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
1448 (UsageVector.Break): Remove.
1449 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
1451 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
1453 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
1454 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1456 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1459 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1460 be the interface member.
1462 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1465 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1466 for emitting small (int) values.
1468 2006-05-03 Raja R Harinath <rharinath@novell.com>
1471 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1472 control-flow passes through the 'finally' after merging-in all the
1473 control-flows from 'try' and the 'catch' clauses.
1475 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1476 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1477 always true at the only non-recursive entry point.
1478 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1479 FlowBranchingBreakable.
1480 (FlowBranchingLoop): Remove.
1481 * statement.cs (Return.DoResolve): Update to changes.
1484 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1485 (FlowBranching.CreateBranching): Handle it: create a
1486 FlowBranchingContinuable.
1487 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1488 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1489 except that it handles the 'continue' command.
1490 (FlowBranching.UsageVector.MergeOrigins): Rename from
1492 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1493 except that it overrides AddContinueOrigin.
1494 (FlowBranchingException): Override AddContinueOrigin, similar to
1496 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1497 Create a new branching around the embedded statement.
1498 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1499 control flow after the embedded statement.
1500 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1502 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1503 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1504 FlowBranchingBreakable.
1505 (FlowBranchingSwitch): Remove.
1508 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1509 error reporting to ...
1510 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1511 Rename from 'AddBreakVector'. Add new location argument. Return
1512 a bool indicating whether the 'break' crosses an unwind-protect.
1513 (FlowBranchingException.AddBreakOrigin): Add.
1514 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1515 flowbranching after updating with the effects of the 'finally'
1517 (FlowBranchingBreakable): New common base class for
1518 FlowBranchingLoop and FlowBranchingSwitch.
1520 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1522 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1524 2006-05-02 Raja R Harinath <rharinath@novell.com>
1526 * statement.cs (Do.Resolve): If the loop is infinite, set the
1528 (While.Resolve, For.Resolve): Set a barrier after the embedded
1529 statement. There's no direct control flow that goes from the end
1530 of the embedded statement to the end of the loop.
1531 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1532 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1533 above ensure that the reachability is correctly computed.
1535 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1536 (UsageVector.MergeBreakOrigins): If the current path is
1537 unreachable, treat it as if all parameters/locals are initialized.
1538 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1539 infinite loops before merging-in break origins.
1541 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1542 (Reachability.Reachable): Split part into ...
1543 (Reachability.Unreachable): ... this. Simplify.
1544 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1546 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1547 (Reachability.SetThrowsSometimes): Likewise.
1548 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1549 TriState.Always, use corresponding property.
1550 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1551 (Block.Resolve): Likewise. Remove some redundant checks.
1553 2006-05-02 Raja R Harinath <harinath@gmail.com>
1555 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1556 (Reachability.Meet): Don't bother checking AlwaysThrows --
1557 barrier is always set.
1558 (FlowBranchingBlock.Merge): Likewise.
1560 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1562 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1563 defined, so it's references should also compile only for NET_2_0
1564 (as occurs in mcs version)
1566 2006-05-01 Raja R Harinath <harinath@gmail.com>
1568 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1569 checks for unreachable.
1571 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1574 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1576 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1577 whether field is really assigned.
1579 2006-04-30 Raja R Harinath <harinath@gmail.com>
1581 * flowanalysis.cs (Reachability): Make 4-argument constructor
1583 (Reachability.Meet): Rename from 'And'. Remove static variant.
1584 (Reachability.Always): Rename from the highly misleading
1585 'Reachability.Never'.
1586 (FlowBranching.Merge): Update to changes. Mark an impossible
1587 situation with a 'throw'.
1588 (*): Update to changes.
1590 2006-04-29 Raja R Harinath <harinath@gmail.com>
1592 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1594 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1595 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1596 (*): Update to changes.
1597 * statement.cs: Update to changes.
1599 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1602 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1604 2006-04-28 Raja R Harinath <harinath@gmail.com>
1606 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1609 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1610 argument to two arguments: an usage-vector and a bool. Move call
1611 to FlowBranching.Merge () ...
1612 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1614 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1615 handling of loop and switch reachability to ...
1616 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1618 2006-04-27 Raja R Harinath <harinath@gmail.com>
1620 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1621 handling to FlowBranchingLoop.InLoop.
1622 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1624 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1627 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1628 anonymous method is allowed from AnonymousContainer here.
1630 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1632 2006-04-24 Raja R Harinath <rharinath@novell.com>
1635 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1637 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1640 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1641 (DoubleConstant.Reduce): Ditto.
1643 2006-04-23 Raja R Harinath <rharinath@novell.com>
1645 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1646 Remove 'lvalue_right_side' argument. Move parts to ...
1647 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1648 (LocalVariable.DoResolveLValue): ... these.
1650 2006-04-21 Raja R Harinath <rharinath@novell.com>
1653 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1654 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1655 (LocalVariableReference.DoResolveBase): Use it to implement new
1657 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1658 (Argument.Resolve): Simplify. Move CS1510 check ...
1659 * ecore.cs (Expression.ResolveLValue): ... here.
1660 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1661 (PropertyExpr.DoResolveLValue): Likewise.
1662 (FieldExpr.Report_AssignToReadonly): Likewise.
1663 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1664 LValueMemberAccess or LValueMemberOutAccess on instance depending
1666 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1667 DoResolve as appropriate.
1669 2006-04-20 Raja R Harinath <rharinath@novell.com>
1672 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1673 implicit conversions on 'out' and 'ref' arguments.
1675 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1676 improve clarity. Remove dead code.
1679 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1680 (Catch.Resolve): Resolve VarBlock if it exists.
1682 2006-04-19 Miguel de Icaza <miguel@novell.com>
1684 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1685 twice, this was some residual code, the enumerator was emitted
1686 properly in the two branche of if later.
1690 Thanks to Martin for finding the source of the problem
1692 2006-04-19 Raja R Harinath <rharinath@novell.com>
1694 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1695 cast is never an lvalue.
1696 (Cast.DoResolve, Cast.ResolveRest): Combine.
1697 (Argument.Emit): Simplify slightly. Move 'Expr is
1698 IMemoryLocation' check ...
1699 (Argument.Resolve): ... here.
1700 (Argument.Error_LValueRequired): Remove. Inline into only user.
1702 Simplifications. Fix cs0191-2.cs
1703 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1704 CS1649 and CS1651 to ...
1705 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1706 the actual selection of the error code and message to a lookup
1707 table. Add a dummy return value to simplify callsites.
1708 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1709 readonly fields of other instances of the same type. Move CS0197
1711 * expression.cs (Argument.Resolve): ... here. Simplify code.
1712 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1713 resolution of an out or ref argument. The code simplification
1714 above uses this invariant.
1716 2006-04-18 Raja R Harinath <rharinath@novell.com>
1718 Possibly fix #77752. Fix cs1690-[4-7].cs.
1719 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1720 CheckMarshallByRefAccess. Drop parameter.
1721 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1723 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1725 * report.cs (AllWarnings): Add CS1690.
1726 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1728 (LocalVariableReference.DoResolveBase): Update.
1730 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1732 * class.cs (MethodOrOperator): Moved common parts from method class.
1733 detect obsolete attributes.
1734 (Method.Define): Simplified as it reuses code from base.
1735 (Constructor.ValidAttributeTargets): Fixed issue found during
1737 (Destructor.ValidAttributeTargets): Fixed issue found during
1739 (Operator): Finished refactoring set off by #78020. Operator class is now
1740 ordinary method class.
1742 * anonymous.cs: Updated.
1744 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1746 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1748 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1750 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1751 detect obsolete attributes.
1752 (Method.CreateEmitContext): Moved to MethodOrOperator.
1754 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1757 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1758 customized exception to make crash detection easier.
1759 (MethodOrOperator): Started to work on new base class for methods and
1761 (Method): Derives from MethodOrOperator.
1762 (Constructor.Emit): Emits its own attributes.
1763 (AbstractPropertyEventMethod.Emit): Ditto.
1764 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1766 (Operator.Emit): It's temporary more tricky than should be.
1768 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1770 * report.cs (InternalErrorException): Add ctor with inner exception.
1772 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1775 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1778 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1781 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1784 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1786 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1787 attribute is present and Guid not.
1788 (Interface.ApplyAttributeBuilder): Ditto.
1790 * attribute.cs: Add error message.
1792 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1796 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1797 sources (it's composite) so hold them in extra array as they are used in
1798 Emit phase only. It worked in the previous versions by mistake.
1799 (Attribute.Emit): Emit attribute for more owners when exist.
1801 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1802 it has now different behaviour.
1804 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1806 * constant.cs (Constant.IsDefaultInitializer): New method.
1808 * class.cs: Updated.
1810 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1811 re-initialize default values. It saves KBs almost for every assembly.
1812 Thanks Zoltan for the idea.
1813 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1814 (ArrayCreation.DoResolve): Resolve only once.
1815 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1816 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1818 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1820 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1823 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1825 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1826 in an embedded statement too.
1828 2006-04-01 Raja R Harinath <rharinath@novell.com>
1831 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1835 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1838 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1839 arguments before checking whether a type is reflected or not.
1842 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1843 definition doesn't take part in overload resolution.
1844 (Invocation.IsParamsMethodApplicable): Likewise.
1845 (Invocation.OverloadResolve): When replacing a reflected override
1846 method with its base definition, ensure that type arguments are
1849 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1853 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1856 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1858 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1860 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1863 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1864 LocalTemporary change.
1866 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1868 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1869 initializers optimization.
1870 (ClassOrStruct.TypeAttr): Moved from modifiers.
1871 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1872 (FieldBase.ResolveInitializer): Resolves initializer.
1873 (FieldBase.HasDefaultInitializer): New property.
1875 * cs-parser.jay: Removed message.
1877 * expression.cs (CompilerGeneratedThis): New specialization.
1879 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1881 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1883 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1885 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1887 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1888 be now EnumConstants only.
1890 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1892 * attribute.cs, driver.cs: Reset more caches.
1894 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1896 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1898 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1900 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1901 for easier reuse. Updated all overrides.
1902 (IntegralConstant): New base class for all integral constants.
1903 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1904 of the constant range, report custom error.
1905 (UIntConstant.Reduce): Fixed uint conversion.
1907 * ecore.cs, literal.cs: Reduce updates.
1909 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1913 * class.cs (Constructor.Define): Removed extra if for default ctors.
1914 A patch from Atsushi Enomoto.
1916 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1918 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1919 GetAttributableValue.
1921 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1924 * convert.cs (ImplicitConversionRequired): Error message moved to
1927 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1928 automatic implicit conversion of an output value.
1929 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1931 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1933 (TypeOf.GetAttributableValue): Add extra handling for object type.
1935 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1936 special error message.
1938 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1940 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1942 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1943 compatible with MS runtime.
1945 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1947 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1948 attribute arguments here.
1950 * class.cs (Indexer.Define): The check was moved to attribute class.
1952 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1954 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1956 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1958 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1960 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1963 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1965 * doc-bootstrap.cs : fix build.
1967 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1969 * expression.cs (StringConcat.Append): Issue a warning when empty string
1972 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1974 * assign.cs (CompoundAssign.ResolveSource): Removed.
1976 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1979 * class.cs (TypeContainer.FindMethods): Removed.
1980 (TypeContainer.CheckMemberUsage): Made static.
1982 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1984 * constant.cs (CheckRange): Removed unused type argument.
1985 (CheckUnsigned): Removed unused type argument.
1987 * cs-parser.jay: Updated after MemberAccess clean up.
1988 Uses Length for empty string test.
1990 * cs-tokenizer.cs: Uses Length for empty string test.
1991 (IsCastToken): Made static.
1992 (is_hex): Made static.
1993 (real_type_suffix): Made static.
1995 * decl.cs (SetupCache): Made static.
1996 (OnGenerateDocComment): Removed unused ds argument.
1998 * delegate.cs (VerifyDelegate): Removed unused argument.
2000 * doc.cs: Uses Length for empty string test.
2002 * driver.cs: Uses Length for empty string test.
2004 * enum.cs (IsValidEnumType): Made static
2006 * expression.cs (EnumLiftUp): Removed unused argument.
2007 (ResolveMethodGroup): Ditto.
2008 (BetterConversion): Ditto.
2009 (GetVarargsTypes): Ditto.
2010 (UpdateIndices): Ditto.
2011 (ValidateInitializers): Ditto.
2012 (MemberAccess.ctor): Ditto.
2013 (GetIndexersForType): Ditto.
2015 * flowanalysis.cs: (MergeFinally): Removed unused argument.
2017 * iterators.cs: Updated after MemberAccess clean up.
2019 * location.cs: Uses Length for empty string test.
2021 * namespace.cs: Uses Length for empty string test.
2023 * report.cs (CheckWarningCode): Made static.
2025 * statement.cs (LabeledStatement): Removed unused argument.
2027 * typemanager.cs (FilterNone): Removed.
2029 2006-03-18 Marek Safar <marek.safar@seznam.cz>
2031 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
2034 * class.cs: Updated.
2036 2006-03-18 Marek Safar <marek.safar@seznam.cz>
2038 * cs-parser.jay.cs: __arglist is not allowed for delegates.
2040 2006-03-18 Marek Safar <marek.safar@seznam.cz>
2044 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
2046 (AnonymousMethod.ImplicitStandardConversionExists): New method.
2047 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
2048 Add more error reporting; Fixed issue with params.
2050 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
2052 * cs-parser.jay: AnonymousMethod requires host container.
2054 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
2056 2006-03-18 Raja R Harinath <harinath@gmail.com>
2058 * class.cs: Change 'TypeContainer ds' constructor argument to
2059 'DeclSpace parent'. Some classes were missed below due to
2060 different naming convention.
2062 * class.cs (MemberCore.Parent): Delete. This makes the
2063 ParentContainer changes below enforceable by the compiler.
2065 Treat pointers to enclosing declaration space as 'DeclSpace', not
2067 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
2068 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
2070 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
2072 (Block.AddThisVariable): Likewise.
2073 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
2074 (AbstractPropertyEventMethod.Emit): Likewise.
2075 (AbstractPropertyEventMethod.EmitMethod): Likewise.
2076 (GetMethod.Define, SetMethod.Define): Likewise.
2077 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
2078 (DelegateMethod.EmitMethod): Likewise.
2080 Fix regression test-partial-13.cs.
2081 Rationalize use of PartialContainer. Ensure that the partial
2082 class semantics can be tied to type-correctness, i.e., any
2083 violation will cause a compile error.
2084 * class.cs, const.cs: Access all fields that belong to class
2085 TypeContainer via ParentContainer. Arguments of EmitContexts and
2086 Resolve()-like functions still use 'Parent'.
2088 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
2089 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
2090 (PropertyMethod.CheckModifiers): Remove unused argument.
2091 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
2094 2006-03-28 Raja R Harinath <rharinath@novell.com>
2096 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
2098 2006-03-17 Raja R Harinath <harinath@gmail.com>
2100 Make semantics of PartialContainer simpler.
2101 * decl.cs (DeclSpace.IsPartial): Remove.
2102 * class.cs (TypeContainer.IsPartial): Likewise.
2103 (TypeContainer..ctor): Set PartialContainer to point to self.
2104 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
2105 (TypeContainer.FindNestedType): Likewise.
2106 (MemberCore.ParentContainer): Simplify. Remove deprecation.
2108 2006-03-17 Marek Safar <marek.safar@seznam.cz>
2110 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
2112 2006-03-15 Marek Safar <marek.safar@seznam.cz>
2114 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
2117 2006-03-15 Marek Safar <marek.safar@seznam.cz>
2119 * class.cs (Operator.Define): An error for base conversion was not
2122 2006-03-13 Marek Safar <marek.safar@seznam.cz>
2124 A fix for #77593, #77574.
2126 * class.cs (MethodCore.CheckBase): Another if for operator.
2128 2006-03-18 Marek Safar <marek.safar@seznam.cz>
2132 * expression.cs (VerifyArgumentsCompat): Reverted to double error
2133 reporting, it's more tricky than I thought.
2135 2006-03-09 Marek Safar <marek.safar@seznam.cz>
2137 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
2140 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
2141 (DelegateCreation.ImplicitStandardConversionExists): New method for just
2144 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
2147 2006-03-04 Marek Safar <marek.safar@seznam.cz>
2151 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
2152 (Event.Define): ditto
2153 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
2155 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
2156 Removed redundant code and set NewSlot for Invoke method too.
2158 * parameter.cs (Parameters.ctor): Add custom, type ctor.
2159 (Parameters.MergeGenerated): New method. Use this method when you merge
2160 compiler generated argument with user arguments.
2162 2006-03-03 Marek Safar <marek.safar@seznam.cz>
2164 * attribute.cs (ResolveAsTypeTerminal): Removed.
2166 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
2167 specialization for predefined types; 30% speed up.
2168 Finally placed obsolete check to right place.
2169 (Expression.ResolveType): Removed.
2171 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
2172 Updated after ResolveType was removed.
2174 * expression.cs (Cast.ctor): Check void cast.
2175 (Binary.ResolveAsTypeTerminal): Is never type.
2176 (Conditional.ResolveAsTypeTerminal): Is never type.
2178 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
2180 2006-03-26 Marek Safar <marek.safar@seznam.cz>
2182 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
2184 2006-03-23 Martin Baulig <martin@ximian.com>
2186 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
2187 type check if either of the types is an open generic type.
2189 2006-03-23 Martin Baulig <martin@ximian.com>
2192 (Convert.ExplicitTypeParameterConversion): New method; implement
2193 explicit type parameter conversions.
2195 2006-03-23 Martin Baulig <martin@ximian.com>
2197 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
2198 blindly allow all conversions if we do not have any constraints.
2200 2006-02-27 Marek Safar <marek.safar@seznam.cz>
2202 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
2203 these two separated members to simplify the code.
2204 (Attribute.Resolve): Refactored to use new fields and methods.
2205 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
2206 implemented obsolete attribute checking.
2207 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
2208 implemented obsolete checking again. It look line never ending quest ;-)
2209 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
2211 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
2213 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
2215 *class.cs (Property.Define): Add RegisterProperty call.
2217 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
2218 argument groups (only 2).
2220 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
2221 encoding expression to arguments.
2222 (Expression.ExprClassToResolveFlags): Just turned to property.
2224 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
2225 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
2226 optimized as well as implemented support for zero-length attributes.
2228 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
2229 Add caching of PropertyInfo's.
2231 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2233 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
2234 error multiple times.
2236 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2238 New partial class implementation.
2239 A fix for #77027, #77029, #77403
2241 * attribute.cs (Attributable): Made attributes protected.
2243 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
2244 the replacements of ClassPart and PartialContainer.
2245 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
2246 (TypeContainer.AddInterface): Ditto.
2247 (TypeContainer.AddPartial): The main method for partial classes. It checks
2248 for errors and merges ModFlags and attributes. At the end class is added to
2250 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
2252 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
2253 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
2254 from the rest of partial classes.
2255 (TypeContainer.GetClassBases): Simplified.
2256 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
2258 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
2259 (TypeContainer.HasExplicitLayout): Uses Flags now.
2260 (PartialContainer): Removed.
2261 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
2262 (StaticClass): Was merged with Class.
2263 (Class.GetClassBases): class and static class bases are verified here.
2264 (Class.TypeAttr): Added static attributes when class is static.
2265 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
2266 (MemberBase): In some cases we need to call parent container for partial
2267 class. It should be eliminated but it's not easy now.
2269 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
2271 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
2272 partial classed to accumulate class comments.
2273 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
2275 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
2277 * driver.cs (MainDriver): Tree.GetDecl was removed.
2279 * modifiers.cs (Modifiers): Add partial modifier.
2281 * tree.cs (Tree.decl): Removed.
2282 (RootTypes): Started to use this class more often for root types
2285 2006-03-23 Raja R Harinath <rharinath@novell.com>
2287 * generic.cs (TypeParameter.UpdateConstraints): Update
2288 'constraints' if null.
2290 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2294 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
2295 external interface does not have an attribute.
2297 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2299 Another prerequisites for new partial classs implementation.
2301 * attribute.cs (Attribute.Equal): Implemented.
2302 (Attribute.Emit): Changed as attributes can be applied more than twice.
2303 (Attributes.Emit): Check for duplicate attributes here.
2305 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
2306 as a parameter, clean-up.
2308 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2312 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
2313 contains obsolete attribute check which can in some cases look for base
2314 type of current class which is not initialized yet.
2315 (TypeContainer.BaseType): Replacement of ptype.
2317 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
2319 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2321 First of prerequisites for new partial classs implemention.
2323 * attribute.cs (Attributable): Extended by ResolveContext;
2324 Attributes finally have correct context for resolving in all cases.
2325 (AttachTo): Attribute owner is assigned here.
2327 * codegen.cs (IResolveContext): Introduce new interface to hold
2328 all information needed in resolving phase.
2329 (EmitContext): Implements IResolveContext; more clean-up needed here.
2331 * decl.cs (MemberCore): Implemented IResolveContext.
2333 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
2334 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
2335 parameter.cs, statement.cs, tree.cs, typemanager.cs:
2336 Refactored to use new IResolveContext instead of EmitContext; cleanup
2338 2006-03-22 Raja R Harinath <rharinath@novell.com>
2340 Support ParameterDefaultValueAttribute in gmcs. Also applied to
2341 mcs to keep code differences small.
2342 * attribute.cs (Attribute.GetParameterDefaultValue): New.
2343 * typemanager.cs (parameter_default_value_attribute_type): New.
2344 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
2347 2006-03-22 Martin Baulig <martin@ximian.com>
2350 (Nullable.NullableLiteral): Derive from `NullLiteral'.
2353 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
2354 instead of the normal `NullLiteral'.
2356 2006-03-21 Martin Baulig <martin@ximian.com>
2359 * generic.cs (TypeManager.InferType): If `pt' is a generic
2360 parameter, don't check whether `pt == at'.
2362 2006-03-20 Raja R Harinath <rharinath@novell.com>
2365 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
2366 (TypeParameter.Resolve): Update to change.
2367 (ConstraintChecker.CheckConstraints): Resolve type-argument
2368 constraints before use.
2370 2006-03-16 Martin Baulig <martin@ximian.com>
2373 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
2374 and don't have any instance constructors, also lookup in the base class.
2375 (TypeManager.IsNullableValueType): New public method.
2377 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
2378 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
2379 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
2381 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
2382 instead of just TypeManager.IsNullableType() to determine whether
2383 a lifted operator exists.
2384 (UnaryMutator.DoResolve): Likewise.
2385 (Conditional.DoResolve): Likewise.
2386 (Binary.DoResolve): A lifted operator only exists if both operands
2387 are valuetypes and at least one of them is a nullable type.
2389 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
2391 * iterator.cs : yield break is allowed in try statement which has
2392 catch clauses. Fixed bug #77767.
2394 2006-03-12 Martin Baulig <martin@ximian.com>
2396 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
2397 private IsSignatureEqual() to compare types; see the comment in
2398 that method; fixes #77674.
2400 2006-03-10 Raja R Harinath <rharinath@novell.com>
2402 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
2403 (Expression.ResolveAsTypeTerminal): Likewise.
2404 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
2405 * expression.cs, generic.cs, iterators.cs: Likewise.
2406 * parameter.cs, statement.cs, typemanager.cs: Likewise.
2408 2006-03-09 Martin Baulig <martin@ximian.com>
2410 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
2411 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
2413 2006-03-09 Martin Baulig <martin@ximian.com>
2415 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
2416 `prepared' flag is set.
2418 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
2419 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
2420 issues; see gtest-254.cs.
2422 2006-03-07 Martin Baulig <martin@ximian.com>
2424 * generic.cs (TypeManager.InferType): Allow infering
2425 `IEnumerable<T>' with an array of T; see gtest-251.cs.
2427 2006-03-06 Martin Baulig <martin@ximian.com>
2430 (TypeManager.InferType): Fix gtest-250.cs.
2433 (TypeManager.IsSubclassOf): Also check the base class.
2436 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
2439 2006-03-01 Raja R Harinath <rharinath@novell.com>
2442 * expression.cs (ParameterReference.DoResolveBase): Change return
2444 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
2448 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
2451 * typemanager.cs (GetFullNameSignature): Don't nullref on
2452 protected accessors.
2454 2006-02-16 Martin Baulig <martin@ximian.com>
2457 (TypeManager.GetGenericFieldDefinition): New public method; use it
2458 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2460 2006-02-14 Martin Baulig <martin@ximian.com>
2462 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2464 2006-02-14 Martin Baulig <martin@ximian.com>
2467 (TypeManager.DropGenericMethodArguments): New public method; don't
2468 use GetGenericMethodDefinition() on something which is not a
2471 2006-02-14 Martin Baulig <martin@ximian.com>
2474 (ConstraintChecker.CheckConstraints): If a type parameter has the
2475 `struct' constraint, the type must be a non-nullable valuetype.
2477 2006-02-10 Martin Baulig <martin@ximian.com>
2480 (TypeManager.IsOverride): Make this work for instantiated methods
2481 in a generic class; fixes #77509.
2482 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2483 rather than calling it directly; fixes #77488.
2485 2006-02-08 Martin Baulig <martin@ximian.com>
2487 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2488 reporting into CheckConstraint() so we can use the correctly
2491 2006-02-08 Martin Baulig <martin@ximian.com>
2493 * expression.cs (BaseAccess): Add support for generic methods.
2495 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2496 the new MethodGroupExpr.
2498 2006-02-07 Martin Baulig <martin@ximian.com>
2500 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2501 also reference types; fixes #77483.
2503 2006-02-07 Martin Baulig <martin@ximian.com>
2506 (TypeManager.IsGenericMethod): We now return whether something is
2507 an instantiated generic method (and not a generic method def).
2508 (TypeManager.IsGenericMethodDefinition): New public method.
2511 (TypeManager.CSharpSignature): Only include type arguments for
2512 "real" generic methods, not for any instantiated method.
2513 (TypeManager.GetMethodName): Likewise, but also allow generic
2514 method definitions here.
2516 2006-02-06 Miguel de Icaza <miguel@novell.com>
2518 * codegen.cs (EmitScopeInitFromBlock): check here the
2519 capture_context, there is no need to make two calls to the
2522 * anonymous.cs: Add some debugging messages that might help me
2523 track other instances of this problem in the future (the
2524 regression of test 467).
2526 * cs-parser.jay: track the variable block, as we need to initalize
2527 any captured variables declared in this block for the "catch"
2528 portion of the "Try" statement.
2530 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2531 scope initialization for captured variables.
2533 Also, move the emit for the variables after the block location has
2536 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2538 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2540 2006-02-06 Martin Baulig <martin@ximian.com>
2542 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2543 `TypeManager.value_type' as parent type to
2544 ModuleBuilder.DefineType(). Fixes #77358.
2546 2006-02-02 Miguel de Icaza <miguel@novell.com>
2548 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2549 commit yesterday, the initialization for the roots is necessary.
2550 What is not necessary is the scope activation.
2552 2006-02-02 Raja R Harinath <rharinath@novell.com>
2554 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2555 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2557 (Argument.Resolve): Remove CS0206 checks.
2559 2006-02-01 Miguel de Icaza <miguel@novell.com>
2561 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2562 scopes for all the roots, the scopes will now be emitted when the
2563 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2565 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2566 code. This reduces a lot of existing cruft.
2568 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2569 that the ScopeInfo is generated as we enter the scope, not at the
2570 time of use, which is what we used to do before.
2572 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2573 every time a Block is about to be emitted if we have a
2576 2006-02-01 Raja R Harinath <rharinath@novell.com>
2578 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2579 attribute for mscorlib too.
2581 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2583 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2585 * typemanager.cs (cons_param_array_attribute): Make private.
2586 (Reset): Set it to null.
2587 (InitCoreHelpers): Don't initialize it.
2588 (ConsParamArrayAttribute): New. Initialize it as needed.
2589 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2591 2006-01-31 Miguel de Icaza <miguel@novell.com>
2593 * expression.cs: There might be errors reported during the
2594 selection of applicable methods. If there are errors, do not
2595 continue execution as it will lead the compiler to crash.
2597 2006-01-30 Miguel de Icaza <miguel@novell.com>
2599 * expression.cs: Member access is not allowed on anonymous
2600 methods. Fixes #77402.
2602 2006-01-30 Raja R Harinath <rharinath@novell.com>
2605 * cs-parser.jay (VariableDeclaration): Don't set
2606 current_array_type to null.
2607 (field_declaration, event_declaration, declaration_statement):
2608 Set it to null here.
2610 2006-01-29 Raja R Harinath <harinath@gmail.com>
2613 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2615 2006-01-28 Raja R Harinath <harinath@gmail.com>
2617 * typemanager.cs (GenericParameterPosition): New.
2620 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2622 * doc.cs : To process "include" elements, first we should create
2623 another list than XmlNodeList, because it could result in node
2624 removal, which could result in that the XmlNodeList gives up
2627 2006-01-25 Miguel de Icaza <miguel@novell.com>
2629 * expression.cs: Introduce an error report that we were not
2630 catching before. Gonzalo ran into it.
2632 2006-01-23 Miguel de Icaza <miguel@novell.com>
2634 A fix for bug: #76957
2636 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2637 ComputeMethodHost before creating the method, this is a new
2640 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2641 that this method references (RegisterScope). The actual scope
2642 where the method is hosted is computed with the ComputeMethodHost
2643 before we create the method.
2645 Moved the Deepest routine here.
2647 (AnonymousContainer.ComputeMethodHost): New routine used to
2648 compute the proper ScopeInfo that will host the anonymous method.
2650 (ScopeInfo): Deal with multiple roots. The problem was that we
2651 did not have a unique root where all ScopeInfos could be hanged
2652 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2655 Remove AdjustMethodScope which is now computed at the end. Remove
2656 LinkScope which did a partial link, instead link all ScopeInfos
2657 before code generation from the new "LinkScopes" routine.
2659 Simplify all the Add* routines as they no longer need to maintain
2660 the tree, they just need to record that they are using variables
2663 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2664 routines to produce the forest of ScopeInfo trees.
2666 * class.cs (TypeContainer.AppendMethod): This is just like
2667 AddMethod, but ensures that an interface implementation method
2668 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2669 methods, but at the end.
2671 We use this functionality to ensure that the generated MoveNext
2672 method in the iterator class is resolved/emitted before the
2673 enumerator methods created.
2675 This is required because the MoveNext method computes the right
2676 ScopeInfo for the method. And the other methods will eventually
2677 need to resolve and fetch information computed from the anonymous
2681 2006-01-23 Raja R Harinath <rharinath@novell.com>
2683 Improve implementation of section 14.4.2.2 (Better function member).
2684 * expression.cs (Invocation.MoreSpecific): Compare all type
2685 arguments before deciding if one type is more specific than
2686 another. Handle array types too. Return the more specific type.
2687 (Invocation.BetterFunction): Add more tie-breaking rules from
2688 section 14.4.2.2. Perform "more specific" check after
2689 other tie-breaking rules. Compare all parameter types before
2690 choosing the "more specific" method.
2692 2006-01-21 Raja R Harinath <harinath@gmail.com>
2693 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2696 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2698 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2699 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2701 2006-01-18 Martin Baulig <martin@ximian.com>
2703 * class.cs (TypeContainer.AddToMemberContainer): Use
2704 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2707 2006-01-18 Martin Baulig <martin@ximian.com>
2709 Fix #76417: a generic class may now have methods which may unify
2710 for some type parameter substitutions.
2712 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2713 for methods which may unify anymore.
2715 * expression.cs (Invocation.MoreSpecific): New private static
2716 method; checks whether one method is more specific than another
2717 according to 14.4.2.2 of the spec.
2718 (Invocation.BetterFunction): Implement the tie-breaking rules from
2719 14.4.2.2 of the spec: if two methods unify for some type parameter
2720 substitution, we need to pick the more specific one.
2722 2006-01-18 Raja R Harinath <rharinath@novell.com>
2724 Fix #76656, cs0231-2.cs.
2725 * cs-parser.jay (formal_parameter_list): Make error case catch
2727 (parenthesized_expression_0): Add CS1026 check.
2728 (invocation_expression): Remove unused { $$ = lexer.Location }.
2730 2006-01-17 Raja R Harinath <rharinath@novell.com>
2733 * cs-parser.jay (statement_expression): Don't list out the
2734 individual statement-expressions. Convert syntax error into
2737 2006-01-16 Raja R Harinath <rharinath@novell.com>
2740 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2741 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2742 CheckIntermediateModification.
2743 (FieldExpr.DoResolve): Add new two-argument version that
2744 allows us to resolve the InstanceExpression as an lvalue.
2745 The one-argument variant is now just a wrapper.
2746 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2747 Resolve the lhs as an lvalue if the it has a value type.
2748 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2749 from Assign.DoResolve.
2750 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2751 resolved as an lvalue.
2752 (PropertyExpr.DoResolve): Update.
2753 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2754 has a value type. Move CS1612 check here from
2755 CheckIntermediateModification.
2756 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2757 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2758 'right_side' of a ResolveLValue on an 'out' argument.
2759 (EmptyExpression.LValueMemberAccess): New. Used as the
2760 'right_side' of a propagated ResolveLValue on a value type.
2761 (LocalVariableReference.DoResolveBase): Recognize
2762 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2764 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2765 EmptyExpression.Null.
2767 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2769 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2770 Type.IsGenericParameter(). Fixed bug #77183.
2771 * doc.cs : it is now identical to doc.cs in mcs.
2773 2006-01-16 Martin Baulig <martin@ximian.com>
2775 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2777 2006-01-16 Martin Baulig <martin@ximian.com>
2779 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2780 ctors; fixes #77250.
2782 2006-01-12 Miguel de Icaza <miguel@novell.com>
2784 This fixes the problem where we used ldfld instead of ldflda to
2785 load the "THIS" pointer on captured parameters, when THIS is a
2786 value type. See bug #77205.
2788 * iterators.cs (CapturedThisReference.Emit): Pass false to
2789 EmitThis (we do not need the address).
2791 * codegen.cs (EmitThis): it needs to know whether we need the
2792 address of `this' or not. This is used by value types.
2794 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2795 every other call passes false.
2797 2006-01-12 Raja R Harinath <rharinath@novell.com>
2800 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2802 * expression.cs (Invocation.OverloadResolve): Update.
2803 (Invocation.DoResolve): Avoid double resolution of invocation.
2805 2006-01-11 Raja R Harinath <rharinath@novell.com>
2808 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2809 unary negation of floating point types as 0-expr; negation cannot
2810 overflow in floating point types.
2813 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2814 on operands of 'void' type.
2817 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2818 and ExclusiveOr for boolean constants too.
2820 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2822 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2824 2006-01-12 Miguel de Icaza <miguel@novell.com>
2826 * cs-tokenizer.cs (Position): New class used to save and restore
2827 the position state in the tokenizer. Before this patch the save
2828 and restore was not complete enough so the line and columns would
2829 start to drift and the debugger and stack traces will get the
2832 2006-01-10 Martin Baulig <martin@ximian.com>
2835 (TypeParameter.InflateConstraints): New public method.
2837 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2838 constraints; fixes #77042.
2840 2006-01-10 Martin Baulig <martin@ximian.com>
2842 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2843 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2846 2006-01-09 Raja R Harinath <rharinath@novell.com>
2849 * expression.cs (Invocation.OverloadResolve): Replace reflected
2850 override methods with their base virtual methods, rather than
2852 * typemanager.cs (TypeManager.GetOverride): New.
2854 2005-12-21 Miguel de Icaza <miguel@novell.com>
2856 * driver.cs: Report the case of no source files and no -out:
2859 2005-12-20 Raja R Harinath <rharinath@novell.com>
2862 * expression.cs (ComposedCast.GetSignatureForError): Define.
2864 2006-01-05 Jb Evain <jbevain@gmail.com>
2866 * class.cs (Property.Define, Indexer.Define): do not tag the
2867 properties as SpecialName | RTSpecialName.
2869 2006-01-04 Miguel de Icaza <miguel@novell.com>
2871 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2872 doing a low-level comparission of parameter types. It was lacking
2873 a check for __argslist.
2875 2005-12-30 Miguel de Icaza <miguel@novell.com>
2877 * expression.cs (ParameterReference.DoResolveBase): Allow
2878 reference parameters if they are local to this block.
2880 This allows the ref and out parameters of a delegate to be used in
2881 an anonymous method, for example:
2883 delegate void set (out int x);
2885 set s = delegate (out int x){
2889 This is used by functionality introduced late in the C# language.
2891 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2892 method that take ref and out parameters.
2894 Fixes #77119 which was a late change in the spec.
2896 2005-12-23 Miguel de Icaza <miguel@novell.com>
2898 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2899 parent if its the same scope. Fixes #77060.
2901 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2903 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2905 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2907 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2908 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2909 that doesn't contain the full public key. This is a update of the
2910 friend assemblies in .Net 2.0 release.
2912 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2916 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2917 ListDictionary, to contain the ExternAliasEntry entries (in
2918 addition to the NamespaceEntry.aliases hashtable). This field is
2919 shared between the original entry and its doppelganger (bodyless
2921 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2922 extern_aliases field.
2923 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2924 lookup in extern_aliases.
2926 2005-12-16 Raja R Harinath <rharinath@novell.com>
2929 * class.cs (TypeContainer.Mark_HasEquals): New.
2930 (TypeContainer.Mark_HasGetHashCode): New.
2931 (ClassPart): Override them.
2932 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2934 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2935 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2939 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2940 'parent' argument to the base constructor.
2942 Remove all mention of TypeContainer from decl.cs.
2943 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2944 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2945 (DeclSpace.DeclSpace): Likewise.
2946 (DeclSpace.DefineMembers): Remove unused argument.
2947 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2948 debugging check -- we don't care if the debug code throws an
2949 InvalidCastException instead of an InternalErrorException.
2950 * class.cs (TypeContainer.DefineMembers): Update to changes.
2951 (TypeContainer.DoDefineMembers): Likewise.
2952 (TypeContainer.GetMethods): Likewise.
2953 (PropertyMember.Define): Likewise.
2954 (MemberBase.Parent): New property that forwards to
2955 MemberCore.Parent, but ensures that we get a TypeContainer.
2956 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2957 (RootContext.PopulateTypes): Likewise. Remove special case code
2958 for !RootContext.StdLib: DefineMembers is idempotent.
2960 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2962 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2964 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2966 * doc.cs : The search for referenced namespace was insufficient to
2967 get global one as it used to do. Fixed bug #76965.
2969 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2971 * doc.cs : check name in cref in the last phase that whether it is
2974 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2976 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2979 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2981 * doc.cs : so it turned out that we cannot skip override check for
2982 interface members. Fixed bug #76954.
2984 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2986 * cs-tokenizer.cs : fixed bug #75984:
2987 - #warning and #error should not be handled when the source line
2989 - #line is not checked strictly when the source line is disabled.
2990 - #define and #undef is on the other hand checked strictly at any
2993 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2995 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2998 2005-12-15 Raja R Harinath <rharinath@novell.com>
3000 * generic.cs (TypeManager.IsGeneric): Remove unused method.
3002 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
3005 2005-12-14 Martin Baulig <martin@ximian.com>
3007 * typemanager.cs (TypeManager.GetFullName): Make this public;
3008 `Type.Fullname' now never returns null.
3010 * class.cs (Method.Define): Use TypeManager.GetFullName() for
3011 explicit interface implementations; we're now using the same
3012 naming convention than csc does.
3014 2005-12-14 Miguel de Icaza <miguel@novell.com>
3016 * convert.cs (ExplicitConversionCore): Check the return value from
3017 ExplicitConversionCore which can return null on failure. Fixes #76914
3019 2005-12-09 Raja R Harinath <rharinath@novell.com>
3021 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
3022 instead of IsGenericInstance.
3023 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
3024 code that's now covered by the more general test.
3025 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
3027 * generic.cs (DropGenericTypeArguments): New. Captures the common
3028 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
3029 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
3030 * generic.cs, report.cs, typemanager.cs: Likewise.
3032 2005-12-08 Martin Baulig <martin@ximian.com>
3034 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
3036 * typemanager.cs (TypeManager.CSharpSignature): Include type
3037 arguments in the signature of a generic method.
3039 2005-12-07 Martin Baulig <martin@ximian.com>
3041 Add support for custom attributes on type parameters.
3043 * cs-parser.jay (type_arguments): Added `opt_attributes'.
3045 * generic.cs (TypeParameterName): New public class; we use this
3046 instead of a `string' to store the name of a type parameter, so we
3047 can also have `Attributes'.
3048 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
3049 array instead of a `string[]' array.
3050 (TypeParameter.ctor): We now also take an `Attributes' argument.
3051 (TypeParameter.EmitAttributes): New public method; emit our
3052 `OptAttributes' here.
3053 (GenericMethod.EmitAttributes): New public method; emit the custom
3054 attributes on all our type parameters.
3056 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
3057 our type parameters.
3058 (MethodData.Define): If we're a generic method, call
3059 EmitAttributes() on it.
3061 2005-12-07 Martin Baulig <martin@ximian.com>
3064 (ConstraintChecker): New public abstract class; move the
3065 constraint checking here from `ConstructedType' and also do
3066 constraint checking for generic methods here.
3068 * expression.cs (Invocation.OverloadResolve): Use
3069 ConstraintChecker.CheckConstraints() if we resolved to a generic
3072 2005-12-05 Marek Safar <marek.safar@seznam.cz>
3074 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
3076 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
3078 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
3079 (FieldBase.Initializer): Initializer is now optional.
3080 (EventField.Define): Only event field can have initializer.
3082 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
3084 * const.cs (Const): Reuse initializer.
3086 * cs-parser.jay: Updated after FieldBase changes.
3087 Added current_array_type to simplify array initializers.
3089 * ecore.cs (NullCast.IsDefaultValue): Implemented.
3091 * expression.cs, iterators.cs: Updated.
3093 * namespace.cs (NamespaceEntry): Made UsingFound private.
3095 2005-12-05 Marek Safar <marek.safar@seznam.cz>
3097 * parameterCollection.cs: Obsolete, removed.
3098 * parser.cs: Obsolete, removed.
3100 2005-12-05 Marek Safar <marek.safar@seznam.cz>
3103 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
3105 * enum.cs (Enum.Define): Set obsolete context here.
3107 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
3110 - FindDocumentedMember() now expects 1) paramList as null
3111 when "we don't have to check the number of parameters" and
3112 2) Type.EmptyTypes when "there is no arguments".
3113 - Introduced FoundMember struct to hold the exact type which was
3114 used to find the documented member (the above change broke
3115 test-xml-044; it might be better just to use DeclaringType than
3116 what MS does, like this change does, but it depends on usage.)
3118 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
3120 * doc.cs : documented member might be from DeclaringType for nested
3121 types. Fixed bug #76782.
3123 2005-12-03 Ben Maurer <bmaurer@ximian.com>
3125 * anonymous.cs: Have the param code handle leaving copies on the
3126 stack etc. Allows anonymous params to take part in the assignment
3127 code (++, +=, etc). Fixes bug #76550
3129 * expression.cs: Handle the prepare_for_load/leave_copy by passing
3130 it down to the anon code.
3132 * iterators.cs: Use dummy var here
3134 * codegen.cs: Handle new vars
3136 2005-12-01 Marek Safar <marek.safar@seznam.cz>
3139 * class.cs (MethodData.Define): Set proper Obsolete context.
3141 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
3143 (FieldExpr.DoResolve): Ditto.
3145 2005-12-01 Marek Safar <marek.safar@seznam.cz>
3148 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
3149 parent is not obsolete.
3151 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
3153 * doc.cs : (FindDocumentedMember) find parameterless members first
3154 and get CS0419 in the early stage. Fixed first case of bug #76727.
3156 2005-11-30 Marek Safar <marek.safar@seznam.cz>
3159 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
3160 no error was reported.
3162 *expression.cs (Binary.DoResolve): left can be null.
3164 2005-12-06 Raja R Harinath <rharinath@novell.com>
3166 * class.cs (MethodCore.CheckGenericOverride): Delete unused
3167 abstract method and all overrides.
3168 * support.cs (ParameterData.GenericConstraints): Delete.
3169 (ReflectionParameters.type_params): Delete.
3170 (ReflectionParameters.ReflectionParameters): Make private.
3171 (ReflectionParameters.GetConstaints): New factory method.
3172 * generic.cs (TypeParameterDefineType): Use it.
3173 (TypeManager.GetTypeParameterConstraints): Likewise.
3175 2005-11-22 Marek Safar <marek.safar@seznam.cz>
3178 * class.cs (MethodData.Emit): Parameters should be labeled first.
3180 2005-11-21 Marek Safar <marek.safar@seznam.cz>
3183 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
3185 2005-11-18 Marek Safar <marek.safar@seznam.cz>
3187 * attribute.cs (AreParametersCompliant): Moved to Parameter.
3189 * class.cs (MethodCore): Parameter clean up.
3190 (IMethodData): Added ParameterInfo.
3191 (MethodData): Parameter clean up.
3192 (Indexer.Define): Parameter clean up.
3204 * typemanager.cs: Parameter clean up.
3206 * delegate.cs (Define): Get rid of duplicated code.
3208 * expression.cs (ParameterReference): Removed useless parameters
3210 (Invocation): Ditto.
3212 * parameter.cs (ParamsParameter): New class, params specialization.
3213 (ArglistParameter): Attemp to separate arglist.
3214 (Parameter): Refactored to be reusable and faster.
3215 (Parameter.Modifier): Made understandable.
3216 (Parameters): Changed to be used as a class for `this' assembly
3217 parameters. Refactored to use new specialized classes.
3219 * support.cs (ParameterData): Added Types property.
3220 (InternalParameters): Deleted.
3222 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3224 * doc.cs : the previous patch does not actually fix the bug.
3225 PropertyInfo override check is now implemented and really fixed it.
3226 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
3228 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3230 * doc.cs : apply "override filter" also to properties.
3233 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3235 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
3236 no need to check overrides. For classes, omit those results from
3237 interfaces since they must exist in the class. Fixed bug #76726.
3239 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3241 * typemanager.cs : (GetFullNameSignature) differentiate indexers
3242 with different parameters. Fixed the second problem in #76685.
3244 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3246 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
3247 get expected 'protected' access in CheckValidFamilyAccess()).
3250 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3252 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
3253 Fixed bug #76705. CS1569 was incorrectly commented out.
3255 2005-11-23 Martin Baulig <martin@ximian.com>
3257 * generic.cs (Constraints.Define): Removed.
3258 (TypeParameter.DefineConstraints): Removed.
3259 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
3260 on the GenericTypeParameterBuilder here.
3262 2005-11-23 Martin Baulig <martin@ximian.com>
3264 * typemanager.cs (TypeManager.GetProperty): Make this public.
3266 * generic.cs (Nullable.NullableInfo.ctor): Use
3267 TypeManager.GetProperty() rather than using reflection directly.
3269 2005-11-17 Martin Baulig <martin@ximian.com>
3271 * expression.cs (Indexers.GetIndexersForType): Added support for
3272 generic parameters; fixes #76587.
3274 2005-11-17 Martin Baulig <martin@ximian.com>
3277 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
3278 inherit the scope from our parent. Fixes #76653.
3280 2005-11-15 Martin Baulig <martin@ximian.com>
3282 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
3283 instead of `ScopeTypeBuilder' to refer to the "current" type.
3284 (AnonymousMethod.CreateScopeType): Correctly create the helper
3285 class if we're inside a generic type definition.
3287 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3289 * doc.cs : use Invocation.IsOverride() to do real override check.
3290 * expression.cs : made Invocation.IsOverride() internal.
3292 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3294 * doc.cs : use TypeManager.FindMembers() instead of (possible)
3295 TypeBuilder.FindMembers() and filter overriden base members out.
3298 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3300 * doc.cs : ref/out parameters are represented as '@' (instead of
3301 '&' in type FullName). Fixed bug #76630 (additionally crefs).
3303 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3305 * doc.cs : when there was no '.' in cref to methods in doc comment,
3306 then parameters were missing in the output. Fixed bug #76691.
3308 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3310 * driver.cs : don't output docs when there is an error.
3313 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3316 Now it should detect indexers. Fixed primary concern in bug #76685.
3317 Fixed CS0419 message to not show the identical member signature in
3320 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3322 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
3323 instead of Type.FindMembers() since it does not handle events.
3326 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
3328 * codegen.cs: Fixed typo (speficied -> specified).
3330 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3333 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
3335 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3337 * attribute.cs: Changed error message.
3339 * cs-tokenizer.cs: One more check.
3341 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3343 * statement.cs (Block.Resolve): Ignore empty statement.
3345 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3347 * report.cs: Made error/warning methods more strict to avoid
3350 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
3351 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
3352 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
3353 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
3355 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3357 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
3358 Use the more explicit AssemblyName.FullName instead of
3359 AssemblyName.Name to report errors.
3361 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3363 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
3366 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3376 * report.cs: Fixed error reporting and typos.
3378 * generic.cs (TypeParameter.GetSignatureForError): New method.
3379 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
3381 * typemanager.cs (GetFullName): Refactored.
3383 2005-11-08 Marek Safar <marek.safar@seznam.cz>
3385 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
3386 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
3388 * class.cs (TypeContainer.IsComImport): New property.
3389 (Constructor.Define): Create proper ctor for ComImport types.
3391 * expression.cs (New.CheckComImport): Fixed.
3393 2005-11-07 Miguel de Icaza <miguel@novell.com>
3395 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
3396 that a parameter has been captured does not mean that we do not
3397 have to do the rest of the processing. This fixes the second part
3398 of #76592. If there was another anonymous method capturing
3399 values in the past, the Scope would never be set for the second
3400 method that captured the same parameter.
3402 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
3403 properly manipulate the stack. Second part of fix for #76592.
3405 * expression.cs (New): Add support for invoking "new" on
3406 interfaces that have been flagged with the ComImport attribute and
3407 the CoClass. Fixes #76637
3409 * statement.cs (Try.DoEmit): When a variable is captured, do not
3410 try to emit the vi.LocalBuilder variable as it has been captured.
3411 Create a temporary variable and store the results on the
3412 FieldBuilder. Fixes #76642
3414 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3416 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
3418 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
3420 * expression.cs (Binary.DoResolve): Added && optimalization.
3422 * typemanager.cs (AddUserType): Removed useless argument.
3424 2005-11-04 Marek Safar <marek.safar@seznam.cz>
3426 * statement.cs (Block.variables): Uses ListDictionary.
3428 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3431 * class.cs (PartialContainer.EmitType): Customized to emit
3432 security attributes.
3433 (ClassPart.ApplyAttributeBuilder): Transform security attribute
3434 for partial classes.
3436 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3439 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
3440 access has to be fixed.
3442 * typemanager.cs (IsUnmanagedType): Wrong common field type.
3444 2005-11-01 Marek Safar <marek.safar@seznam.cz>
3447 * ecore.cs (NullCast.Reduce): Implemented.
3449 * expression.cs (ArrayCreation.CheckIndices): Correcly check
3452 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
3454 (Foreach.Resolve): Catch null properly.
3456 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3458 * cs-tokenizer.cs: Warning text fix.
3460 * driver.cs: AllWarningNumbers exposed on public interface.
3462 * report.cs (): Reviewed warning numbers.
3463 (IsValidWarning): Use binary search.
3465 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3467 * driver.cs: Implemeted resource visibility.
3468 (Resources): New class for code sharing between /res: and
3471 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3473 decl.cs (CurrentTypeParameters): Fixed to be public.
3475 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3477 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3479 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3481 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3483 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3485 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3487 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3489 Add friend assembly access support.
3490 * typemanager.cs: assembly_internals_vis_attrs
3491 cache for friend assembly access.
3492 (TypeManager.IsFriendAssembly): New method for
3493 checking friend assembly access.
3494 (TypeManager.Error_FriendAccessNameNotMatching): New
3496 (TypeManager.CompareKeyTokens): Likewise.
3497 (TypeManager.Filter): Handle friend accessible
3500 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3501 friend accessible types.
3503 * ecore.cs (Expression.IsAccessorAccessible): Handle
3504 friend accessible properties.
3506 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3509 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3512 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3515 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3518 * ecore.cs (NullCast): Child is contant only.
3520 * literal.cs (NullLiteral.Reduce): null can be converted to any
3523 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3525 * driver.cs: Use Encoding.Default as default code page instead
3528 2005-10-27 Raja R Harinath <rharinath@novell.com>
3531 * expression.cs (Invocation.Error_InvalidArguments): Handle
3532 __arglist parameters.
3533 (Invocation.VerifyArgumentsCompat): Likewise.
3534 * support.cs (ReflectionParameters.GetSignatureForError): Print
3535 __arglist parameters.
3536 (InternalParamters.GetSignatureForError): Likewise.
3537 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3539 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3541 * attribute.cs (GetPropertyValue): Made public.
3543 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3545 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3547 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3550 * driver.cs: Reflect method name change.
3552 * statement.cs (Try.Resolve): Warn when try has both general
3555 * typemanager.cs: runtime_compatibility_attr_type new predefined
3558 2005-10-26 Raja R Harinath <harinath@gmail.com>
3561 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3562 treat it as an empty parameter list.
3564 2005-10-26 Raja R Harinath <rharinath@novell.com>
3567 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3568 ResolveAsTypeStep silent.
3569 * statement.cs (Block.AddConstant): Mark block as used.
3570 (Block.ResolveMeta): Avoid piling on error messages
3571 if a constant initializer resolution fails.
3573 2005-10-25 Raja R Harinath <rharinath@novell.com>
3575 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3577 (NamespaceEntry.VerifyAllUsing): New.
3578 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3579 behaviour. Delegates actual resolution of alias to ...
3580 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3581 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3583 * driver.cs (Driver.MainDriver): Update.
3585 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3586 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3588 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3590 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3591 RootNamespace.DefineNamespacesForAll.
3593 2005-10-24 Raja R Harinath <harinath@gmail.com>
3595 * typemanager.cs (assemblies, external_aliases, modules)
3596 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3597 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3598 overhead. Move resposibility ...
3599 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3600 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3602 2005-10-23 Raja R Harinath <harinath@gmail.com>
3604 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3605 cached_namespaces. Improve usage.
3606 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3607 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3608 Move from GlobalRootNamespace and simplify.
3609 (RootNamespace.Global): Make instance variable.
3610 (RootNamespace.RootNamespace): Add "alias name" parameter.
3611 (GlobalRootNamespace): Simplify drastically.
3612 (Namespace.Lookup): Don't use GetNamespace.
3613 * typemanager.cs (GetRootNamespace): Rename from
3614 ComputeNamespaceForAlias.
3615 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3617 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3619 * anonymous.cs (AnonymousContainer): Don't crash when container
3622 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3624 * expression.cs (Binary.DoResolve): Warn when comparing same
3627 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3630 * expression.cs (Binary.DoResolve): It looks like there are no
3631 convetsion rules in enum context.
3633 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3635 Add support for extern alias qualifiers.
3636 * typemanager.cs: Move some LookupTypeReflection code
3637 to namespace.cs, to have cleaner code. Added some methods
3638 to help us keep track of the extern aliased references.
3639 * driver.cs: Add suport for extern alias assemblies on command
3640 line and check for their warnings/errors. Also keep track of the
3641 extern aliased assemblies.
3642 * namespace.cs: Move the global functionality of Namespace
3643 to GlobalRootNamespace/RootNamespace. Now the global namespace
3644 is GlobalRootNamespace.Globa. Also the code moved from
3645 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3646 Finally added LocalAliasEntry (AliasEntry before) and
3647 ExternAliasEntry, to handle alias statements.
3648 * cs-parser.jay: Add support in the grammar for extern alias
3650 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3651 Update callings to Namespace (now in GlobalRootNamespace).
3653 2005-10-25 Martin Baulig <martin@ximian.com>
3655 * convert.cs (ImplicitTypeParameterConversion): Make base
3656 interfaces actually work; fixes #76557.
3658 2005-10-25 Martin Baulig <martin@ximian.com>
3661 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3662 all the type parameters; fixes #76551.
3664 2005-10-25 Martin Baulig <martin@ximian.com>
3669 (GenericMethod.ctor): Added `Expression return_type' and
3670 `Parameters parameters' arguments.
3671 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3672 parameter and return types to check their constraints if they're
3675 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3678 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3679 constraints of a generic type if `ec.ResolvingGenericMethod'.
3681 * class.cs (MethodCore.DoDefineParameters): Set
3682 `ec.ResolvingGenericMethod' if we're a generic method.
3683 (MemberBase.MemberType): Likewise.
3685 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3687 * typemanager.cs (TypeManager): Added
3688 TypeManager.internals_visible_attr_type to cache
3689 S.R.CompilerServices.InternalsVisibleToAttribute.
3691 * codegen.cs (AssemblyClass): Added checks for
3692 InternalsVisibleToAttribute in new method
3693 CheckInternalsVisibleAttribute () and also cache the
3694 AssemblyName in AssemblyClass.Name.
3696 2005-10-24 Martin Baulig <martin@ximian.com>
3699 (TypeManager.ExpandInterfaces): Added overloaded version which
3700 just takes a `Type[]' array.
3703 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3704 just use the interfaces which were explicitly specified and not
3705 the interfaces they inherit. Fixes #76482.
3706 (TypeParameter.FindMembers): Expand the interfaces here.
3708 2005-10-21 Martin Baulig <martin@ximian.com>
3711 (Constraints.Resolve): Also resolve the actual types here.
3712 (Constraints.ResolveTypes): Just check the constraints here.
3713 Fixes #76363; see gtest-218.cs.
3715 2005-10-21 Martin Baulig <martin@ximian.com>
3718 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3719 instead of a `BoxedCast'; fixes gtest-217.cs.
3721 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3723 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3724 1) "new()" is specified as generic parameter constraint and 2) the
3725 type is TypeBuilder and 3) the type is abstract even if it has a
3726 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3728 2005-10-20 Martin Baulig <martin@ximian.com>
3731 (GenericConstraints.TypeParameter): New public property.
3732 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3733 (TypeParameter.DeclSpace): New public property.
3734 (TypeParameter.DefineType): Inflate the constraints if our
3735 `DeclSpace' is an `Iterator'.
3737 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3739 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3740 GenericMethod argument to compare methods' generic type arguments.
3743 2005-10-19 Martin Baulig <martin@ximian.com>
3745 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3746 not ResolveType() when resolving the base type, so we're not
3747 checking the constraints here.
3748 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3751 2005-10-19 Martin Baulig <martin@ximian.com>
3753 * generic.cs (ConstructedType.CheckConstraints): Committing
3754 untested fix for #76441.
3756 2005-10-18 Raja R Harinath <rharinath@novell.com>
3759 * class.cs (TypeContainer.DefineType): Move updating of
3760 topological sort earlier in the code.
3761 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3763 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3766 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3768 * constant.cs (Constant.TryReduce): Moved from Cast class.
3769 (Reduce): Made little bit more OO and fixed missing conversions.
3771 * ecore.cs (Reduce): Implemented.
3772 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3774 * literal.cs (Reduce): Implemented.
3776 * class.cs: Reverted Miguel's wrong commit.
3778 2005-10-14 Miguel de Icaza <miguel@novell.com>
3780 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3782 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3784 * cs-parser.jay, expression.cs : CS0214 was missing error location
3785 for constants. Fixed bug #76404.
3787 2005-10-10 Raja R Harinath <rharinath@novell.com>
3789 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3791 (PropertyExpr.EmitCall): Likewise.
3792 * expression.cs (Invocation.EmitArguments): Handle case where
3794 (Invocation.EmitCall): Avoid allocating temporary variable if
3795 there are no arguments.
3797 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3800 * convert.cs (ExplicitConversionCore): Fixed object->enum
3803 2005-10-07 Raja R Harinath <rharinath@novell.com>
3806 * convert.cs (ImplicitConversionStandard): Move conversion of
3807 void* to arbitrary pointer types ...
3808 (ExplicitConversionStandard): .. here.
3809 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3810 error to always print typenames.
3812 2005-10-07 Raja R Harinath <rharinath@novell.com>
3814 * convert.cs (GetConversionOperator): Rename from
3815 GetConversionOperators. Move operator selection code from ...
3816 (UserDefinedConversion): ... here.
3818 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3820 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3823 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3825 * assign.cs (Assign.DoResolve): Error method changed.
3827 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3829 * const.cs (ResolveValue): Reset in_transit immediately.
3831 * constant.cs: Error method changed.
3833 * convert.cs: Removed useless location parameter.
3834 (ExplicitNumericConversion): Don't do double enum check.
3835 (ExplicitConversionCore): Renamed from ExplicitConversion.
3836 (ExplicitUnsafe): Extracted from ExplicitConversion.
3837 (ExplicitConversion): Uses for error reporting.
3839 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3841 (ResolveBoolean): Uses common error method.
3842 (CastToDecimal): Get rid of ec.
3843 (CastFromDecimal): Optimized.
3844 (ConvCast): Get rid of ec.
3846 * enum.cs (ResolveValue): Reset in_transit immediately.
3847 (Emit): Return after first error.
3849 * expression.cs: Convert changes.
3851 * literal.cs: Error method changed.
3853 * statement.cs: Error method changed.
3855 2005-10-06 Raja R Harinath <rharinath@novell.com>
3857 Fix gtest-131.cs and gtest-211.cs.
3858 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3859 Only emit code for a label if it is used. Unreachable code can
3860 violate ECMA evaluation stack invariants.
3862 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3864 * anonymous.cs: Implemented ExprClassName.
3866 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3869 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3872 * class.cs (StaticClass.DefineContainerMembers): Report protected
3875 * codegen.cs: if(ed) PRODUCTION.
3877 * convert.cs (Error_CannotImplicitConversion): Better error
3880 * cs-parser.jay: More error checks.
3882 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3884 * driver.cs (CSCParseOption): Enabled wrong option check.
3886 * ecore.cs (Expression.ExprClassName): Turned to property.
3887 (MemberExpr.CheckIntermediateModification): For checking boxed
3888 value types modification.
3890 * statement.cs (Fixed.Resolve): Expression type must be
3891 convertible to fixed type.
3892 (CollectionForeach.GetEnumeratorFilter,TryType):
3893 Small refactoring for easier error checking.
3895 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3897 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3900 * class.cs (GeneratedBaseInitializer): New class for customization
3901 compiler generated initializers.
3902 (MemberBase.DoDefine): Check Obsolete attribute here.
3903 (FieldMember.DoDefine): Ditto.
3905 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3908 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3909 (MemberCore.GetObsoleteAttribute): Removed argument.
3910 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3911 (MemberCore.CheckObsoleteType): New helper.
3915 * statement.cs: Updates after MemberCore changes.
3917 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3918 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3920 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3921 obsolete attribute for compiler construct.
3922 (As.DoResolve): Cache result.
3924 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3926 2005-10-01 Miguel de Icaza <miguel@novell.com>
3928 * expression.cs (Probe): instead of having a "Type probe_type"
3929 keep the extra information as a TypeExpr probe_type_expr since the
3930 "As" operator needs to perform some type checks.
3932 * (As.DoResolve): If the type is a type parameter, ensure that it
3933 is constrained by a class.
3935 2005-09-22 Miguel de Icaza <miguel@novell.com>
3937 * statement.cs (Lock): Use the TemporaryVariable class instead of
3938 manually using local variables as those do not work when variables
3941 * ecore.cs: Moved the TemporaryVariable class from being a nested
3942 class inside Foreach to be a public class that can be employed in
3945 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3947 * cs-parser.jay: interface_accessors replaced by
3948 accessor_declarations.
3950 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3953 * statement.cs (GotoCase.Resolve): Convert null constant to
3955 (SwitchLabel.ResolveAndReduce): Ditto.
3956 (SwitchLabel.NullStringCase): Custom null stamp.
3957 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3959 typemanager.cs (CSharpSignature): Don't skip first argument
3962 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3964 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3965 expression.cs, iterators.cs, literal.cs: Store constants and
3968 * class.cs (MemberBase.ShortName): Pass location.
3970 * cs-parser.jay: Some location fixes.
3972 * ecore.cs (Expression.Location): Made virtual.
3974 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3977 * const.cs (Const.ResolveValue): Check for assigning non-null
3978 value to reference type.
3980 2005-09-26 Raja R Harinath <rharinath@novell.com>
3983 * expression.cs (This.VerifyFixed): In a value type T, the type of
3984 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3985 value type R, 'this' is treated as a value parameter.
3987 2005-09-05 Miguel de Icaza <miguel@novell.com>
3989 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3990 if the underlying types are the same, otherwise we need to produce
3991 code that will do the proper cast.
3993 This was exposed by Marek's constant rewrite which produced
3994 invalid code for the call site:
3997 void Method (X v) {}
4001 This fixes test-49.cs
4003 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4005 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
4006 Type/Object should be allowed as well. Fixed bug #75968.
4008 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4010 * expression.cs : (Binary.DoResolve): when one is enum constant and
4011 another is constant 0, then return enum one *as enum type*.
4014 2005-10-04 Martin Baulig <martin@ximian.com>
4016 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
4017 `SetMemberIsUsed()' work for generics, too.
4019 2005-10-04 Martin Baulig <martin@ximian.com>
4021 * expression.cs (DelegateInvocation.EmitStatement): Make this work
4022 for corlib. Fixes #75691.
4024 2005-09-28 Marek Safar <marek.safar@seznam.cz>
4027 * driver.cs: Fix compilation files with full root path.
4029 2005-09-25 Miguel de Icaza <miguel@novell.com>
4031 * report.cs (SymbolRelatedToPreviousError): Format the output so
4032 it does not use an open parenthesis that is never closed.
4034 * driver.cs: Follow coding guidelines
4036 2005-09-18 Miguel de Icaza <miguel@novell.com>
4038 * driver.cs: Set InEmacs based on the environment variable EMACS.
4040 * location.cs (InEmacs): in this mode, do not report column
4041 location as it confuses Emacs.
4043 2005-10-03 Raja R Harinath <rharinath@novell.com>
4045 * support.cs (SeekableStreamReader.Position): Don't error out when
4046 the requested position is just beyond the end of the current
4049 2005-09-28 Raja R Harinath <rharinath@novell.com>
4051 * support.cs (SeekableStreamReader): Simplify drastically. Don't
4052 try to keep in sync with the byte count of the underlying Stream.
4053 However, this limits us to a window size of 2048 characters: i.e.,
4054 the maximum lookahead of our lexer/parser can be 2048 characters.
4056 2005-09-22 Martin Baulig <martin@ximian.com>
4058 * driver.cs: Removed a debugging FIXME.
4060 2005-09-21 Raja R Harinath <rharinath@novell.com>
4062 * cs-parser.jay (type_arguments): Add CS1644 check.
4063 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
4065 2005-09-15 Raja R Harinath <rharinath@novell.com>
4067 * Makefile (PROGRAM): Make profile specific.
4068 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
4069 the current directory.
4072 * expression.cs (Invocation.EmitCall): Remove optimization on
4073 this_call since it doesn't handle 'this' being a value type.
4075 2005-09-05 Geoff Norton <gnorton@customerdna.com>
4077 * driver.cs: Ensure file handles are closed after parsing
4079 2005-09-05 Miguel de Icaza <miguel@novell.com>
4081 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
4082 if the underlying types are the same, otherwise we need to produce
4083 code that will do the proper cast.
4085 This was exposed by Marek's constant rewrite which produced
4086 invalid code for the call site:
4089 void Method (X v) {}
4093 This fixes test-49.cs
4095 2005-09-05 Martin Baulig <martin@ximian.com>
4097 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
4098 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
4100 * cs-parser.jay (delegate_declaration): Small fix for #75852.
4102 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4104 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
4105 to be a pointer type due to the spec 25.2, so check if declaring
4106 type is generic type definition. Fixed bug #75772.
4108 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4111 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
4112 both types are not defined by methods.
4113 * expression.cs : (Invocation.IsApplicable): it should work when
4114 the argument type is equal to the parameter type, not only when
4115 ImplicitConversionExists() returns true.
4117 2005-09-02 Raja R Harinath <rharinath@novell.com>
4119 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
4123 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
4124 flow-branching for LocalVariableReferences in case we were invoked
4125 from a MemberAccess.
4126 * expression.cs (LocalVariableReference.VerifyAssigned): New.
4128 (LocalVariableReference.DoResolveBase): ... this.
4129 (MemberAccess.Resolve): Do the check that was disabled during
4132 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
4135 (PartialContainer.Create): check abstract/sealed/static strictly
4136 but abstract/sealed can exist only at one side. Fixed bug #75883.
4138 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
4141 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
4142 specified, don't default to UnmanagedType.I4.
4144 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
4146 * expression.cs : conditional operator should check possibly
4147 incorrect assign expression. Fixed bug #75946.
4149 2005-08-30 Raja R Harinath <rharinath@novell.com>
4152 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
4153 (ScopeInfo.EmitScopeType): Use it to construct field names from
4154 names of captured locals.
4157 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
4158 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
4159 Pass 'target_type' to BoxedCast. Don't default to 'object'.
4160 (ExplicitConversion): Remove enum cases already handled by
4161 implicit conversion. Move implicit conversion check to the beginning.
4162 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
4163 * expression.cs (ArrayCreation.EmitDynamicInitializers):
4164 Don't treat System.Enum as a struct.
4166 2005-08-30 Jb Evain <jbevain@gmail.com>
4168 * attribute.cs: handles as expression in parameters.
4170 2005-08-30 Raja R Harinath <rharinath@novell.com>
4173 * class.cs (TypeContainer.VerifyClsName): Don't use a
4174 PartialContainer when verifying CLS compliance.
4175 (AbstractPropertyEventMethod): Set Parent here, ...
4176 (PropertyMethod): ... not here.
4178 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
4180 * attribute.cs : escaped attribute name should not be allowed to be
4181 resolved (e.g. @class as classAttribute). Fixed bug #75930.
4183 2005-08-29 Raja R Harinath <rharinath@novell.com>
4186 * convert.cs (ImplicitStandardConversionExists): Allow zero also
4187 when converting a long constant to unsigned long.
4188 * expression.cs (Invocation.OverloadResolve): Add sanity check to
4189 detect where IsApplicable and VerifyArgumentsCompat disagree.
4191 2005-08-29 Raja R Harinath <rharinath@novell.com>
4192 and Carlos Alberto Cortez <carlos@unixmexico.org>
4195 * class.cs (TypeContainer.CanElideInitializer): New helper.
4196 (TypeContainer.EmitFieldInitializers): Use it to determine if we
4197 can safely emitting the initializer of a field.
4199 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4201 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
4202 allowed inside a switch (without loop). Fixed bug #75433.
4204 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4206 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4207 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4209 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4211 * driver.cs : kinda reverting the default encoding changes (not exact
4212 revert since I noticed that "codepage:reset" might not work fine).
4214 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4216 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
4217 Location. Now getter and setter store location correctly.
4218 (errors/cs0111-12.cs now reports the expected location.)
4220 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4222 * driver.cs : Use default encoding on the environment.
4223 Removed (now that) extra parameter for SeekableStreamReader.
4224 * support.cs : (SeekableStreamReader) third .ctor() argument for
4225 StreamReader is not required (always true). preamble size could
4226 be acquired in simpler and safe way.
4228 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
4230 * cs-parser.jay: report CS0642 at warning level 3
4231 and report CS0642 for an if else statement also
4232 fixes bug #74745. Patch by John Luke (and a bit
4234 Removed extra CS0642 warning check for "while",
4236 * statement.cs: In Block.Resolve(), CS0642 check
4237 is reimplemented to check a sequence of an empty
4238 statement and a block.
4240 Both fix bug #66777.
4242 2005-08-24 Marek Safar <marek.safar@seznam.cz>
4244 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
4245 detection until I fix it.
4247 * cs-tokenizer.cs: Changed error message.
4249 * cs-parser.jay: Fixed 2 error locations.
4251 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
4252 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
4255 * enum.cs (GetSignatureForError): Fixed.
4257 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
4261 * typemanager.cs (RegisterProperty): Removed.
4263 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
4265 2005-08-24 Raja R Harinath <rharinath@novell.com>
4268 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
4269 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
4271 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4273 * expression.cs : tiny fix is required for not warning positive ulong.
4276 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4278 * expression.cs : add CS0652 check for constant and integral
4279 expression. Fixed bug #53974.
4281 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4283 * expression.cs : in DoNumericPromotions(), check if there is implicit
4284 conversion overload for string (to check CS0034). Fixed bug #52492.
4286 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4288 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
4290 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4292 * ecore.cs : report location when it is *not* Null.
4294 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4300 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
4301 correctly. Fixed bug #75721.
4303 2005-08-23 Raja R Harinath <rharinath@novell.com>
4305 * support.cs (SeekableStreamReader.Position): Avoid an expensive
4306 loop that performs 'min (pos, char_count)'.
4309 * expression.cs (Unary.ResolveOperator): Don't discard implicit
4310 converted value in Operator.OnesComplement.
4312 2005-08-22 Ben Maurer <bmaurer@ximian.com>
4314 * anonymous.cs: If the anon method is pulled into a helper class,
4315 it needs to be `internal' not `private'. Fixes runtime behavior on
4318 2005-08-17 Marek Safar <marek.safar@seznam.cz>
4321 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
4324 2005-08-16 Marek Safar <marek.safar@seznam.cz>
4326 The big constants rewrite
4327 Fix #75746, #75685 and more
4328 As a side effect saved 1MB for MWF ;-)
4330 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
4331 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
4332 enum based for corlib compilation.
4334 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
4337 * class.cs (FixedField.Define): Use ResolveAsConstant.
4339 * const.cs (IConstant): Interface constants and enums.
4340 (Const.ResolveValue): New method for constant resolvning.
4341 (ExternalConstant): Constants from imported assemblies.
4343 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
4344 conversion; like enums.
4345 (Constant.ToType): Converts this constant to different type.
4346 (Constant.Increment): Adds 1.
4348 * convert.cs (ImplicitConversionRequired): Simplified.
4350 * cs-parser.jay: Create EnumMember directly.
4352 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
4354 * doc.cs (GenerateEnumDocComment): Removed.
4356 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
4357 (ConvertIntLiteral): Removed.
4358 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
4360 * enum.cs (EnumMember): Implement IConstant.
4361 (Enum.IsValidEnumConstant): Removed.
4362 (Enum.GetNextDefaultValue): Removed.
4363 (Enum.FindMembers): Updated.
4364 (Enum.GenerateDocComment): Iterate enum members.
4366 * expression.cs (Cast.TryReduce): Handle enums correctly.
4367 (New.Constantify): Made public.
4368 (MemberAccess.DoResolve): Removed contant specific if(s).
4370 * literal.cs (NullLiteral): Implement new abstract methods.
4372 * statement.cs (GotoCase.Resolve): Use new constant methods.
4373 (SwitchLabel.ResolveAndReduce): Use new constant methods.
4375 * typemanager.cs (LookupEnum): Removed.
4376 (IsEnumType): Fixed to work with corlib.
4377 (RegisterConstant): Removed.
4378 (LookupConstant): Removed.
4379 (GetConstant): Changed to work with IConstant.
4381 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
4383 * location.cs : Fixed overflown (>255) column number.
4385 2005-08-03 Raja R Harinath <rharinath@novell.com>
4387 First cut of the qualified-alias-member feature.
4388 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
4390 * cs-parser.jay (DOUBLE_COLON): New token.
4391 (namespace_or_type_name): Add rule for recognizing
4392 qualified-alias-members.
4393 (primary_expression): Likewise.
4394 (element_access): Allow QualifiedAliasMember as a possible
4395 type-bearing expression.
4396 (local_variable_type, local_variable_pointer_type): Likewise.
4397 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
4398 aliases in the current and enclosing namespace declarations.
4399 (NamespaceEntry.UsingAlias): Add CS0440 warning.
4400 * decl.cs (MemberName.is_double_colon): New.
4401 (MemberName.MemberName): Add new constructor for alias-member.
4402 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
4403 * expression.cs (QualifiedAliasMember): New expression type.
4405 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4407 * location.cs : it borked when no argument was specified.
4409 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4411 * location.cs : tiny ToString() format fix.
4413 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4415 * statement.cs : oops, it was missing.
4417 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4419 A set of fixes for precise line/column location.
4422 "token" field now holds a file/line "delta", a line number offset
4423 from the segment, and a column number. See also:
4424 http://lists.ximian.com/pipermail/mono-devel-list/2004-
4425 December/009508.html
4426 Removed static IsNull. Use instance IsNull property instead.
4428 For some tokens it stores Location. For Identifier it stores
4429 LocatedToken which is a pair of string name and location.
4430 Column numbers are adjusted only at getChar().
4432 Use Location.ToString() for reporting (it now contains column).
4434 Largely modified to use LocatedToken instead of
4435 string (IDENTIFIER), and to acquire Location from some tokens.
4436 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
4437 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
4439 Now MemberName holds Location. DeclSpace.ctor() receives Location
4440 as a parameter. Removed extra parameters to all derived classes.
4441 Replaced Location.IsNull() with instance property.
4442 * assign.cs, expression.cs :
4443 Added .ctor() overload that omits Location.
4445 Added "nameEscaped" flag that indicates the identifier was escaped
4446 in the source file. This fixes bug #57047.
4448 2005-09-02 Martin Baulig <martin@ximian.com>
4450 * class.cs: Make CS3005 a warning, not an error.
4452 2005-08-02 Marek Safar <marek.safar@seznam.cz>
4454 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
4455 New method, looking for lo-case imported cls type.
4457 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4460 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4462 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4464 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4466 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4468 Optimized to save 3.5 MB for SWF compilation.
4470 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4472 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4473 (PartialContainer.Create): Moved logic AddToContainer.
4474 (PartialContainer.MarkForDuplicationCheck): Shares name.
4476 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4479 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4481 (Namespace.GetSignatureForError): New method.
4483 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4484 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4486 2005-08-01 Raja R Harinath <rharinath@novell.com>
4489 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4490 member lookup rather than qualifier_type, since qualifier_type can
4493 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4495 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4498 2005-07-31 Miguel de Icaza <miguel@novell.com>
4500 * statement.cs: Copy the local exception into the exception
4501 captured local. Fixes 75674
4503 2005-07-31 Raja R Harinath <harinath@gmail.com>
4506 * expression.cs (Invocation.OverloadResolve): Don't report error
4507 CS1501 if error CS1502 has been reported.
4508 (New.DoResolve): Delegate CS1501 reporting to
4509 Invocation.OverloadResolve.
4512 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4513 invariant-meaning-in-block property in an enclosing block if
4516 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4518 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4519 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4520 (Switch.CheckSwitch): Just save 50kb for SWF.
4522 2005-07-27 Martin Baulig <martin@ximian.com>
4524 * anonymous.cs (CaptureContext.AddField): Added
4525 `AnonymousContainer am' argument; compute its toplevel scope if
4526 it's not already computed. Fixes #75649.
4528 2005-07-26 Raja R Harinath <rharinath@novell.com>
4531 * class.cs (Constructor.Emit): Reset block to null if the block
4534 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4536 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4538 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4540 * class.cs (MethodData.Define): Check whether accessor implementing
4541 interface is public.
4543 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4545 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4548 * namespace.cs (LookupType): Moved same type check to...
4550 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4553 2005-07-21 Raja R Harinath <rharinath@novell.com>
4555 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4556 already found a typebuilder.
4557 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4558 MemberNames, not strings.
4560 * const.cs (Error_ExpressionMustBeConst):
4561 Rename from Error_EpressionMustBeConst.
4562 * const.cs, class.cs, statement.cd: Update.
4564 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4568 * const.cs (Const.LookupConstantValue): Report missing contant expression
4570 (Error_EpressionMustBeConstant): Only one error method.
4572 * class.cs, statement.c: Updated.
4574 2005-07-20 Raja R Harinath <rharinath@novell.com>
4576 * statement.cs (Block.Flags): Add back HasVarargs.
4577 (Block.flags): Make protected.
4578 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4580 * typemanager.cs (types, typecontainers, user_types): Remove.
4581 (UserTypes, TypeContainers): Likewise.
4582 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4583 (CleanUp, Reset): Update.
4584 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4585 (GetNestedType): Use Type.GetNestedType.
4586 (CoreLookupType): Take two arguments, the namespace and the
4587 basename of the type. Update to use the Namespace.Lookup
4589 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4590 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4591 string concatenation and substring matches.
4592 * class.cs, enum.cs, delegate.cs: Update to changes.
4594 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4596 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4597 Expression and made virtual.
4599 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4600 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4602 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4604 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4607 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4610 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4613 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4614 AssemblyCultureAttribute is not used on executable.
4617 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4619 2005-07-16 Raja R Harinath <rharinath@novell.com>
4622 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4623 New. Reports CS0252/CS0253.
4624 Mostly taken from preliminary patch by Duncak Mak.
4625 (Binary.DoResolveOperator): Store results of operator lookup.
4626 Use them to detect if we need to warn about unintended reference
4629 2005-07-15 Raja R Harinath <rharinath@novell.com>
4632 * namespace.cs (Namespace.Lookup): Add back location parameter.
4633 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4634 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4636 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4637 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4638 (Namespace.LookupType): ... this.
4639 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4641 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4642 purported to handle pointers.
4643 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4646 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4648 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4651 2005-07-15 Raja R Harinath <rharinath@novell.com>
4653 * namespace.cs (Namespace.Lookup): Drop location parameter.
4654 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4655 (NamespaceEntry.Lookup): ... this.
4656 (NamespaceEntry.Error_AmbiguousTypeReference):
4657 Move here from DeclSpace.
4658 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4660 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4661 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4662 Move to NamespaceEntry.
4663 * delegate.cs, expression.cs: Update to changes.
4665 2005-08-31 Martin Baulig <martin@ximian.com>
4667 Committing a patch from Atsushi Enomoto for #75850.
4669 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4670 Prefer a generic enumerator over a non-generic one.
4672 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4674 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4675 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4677 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4679 * driver.cs : reverting default encoding change as well as mcs.
4681 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4683 * driver.cs, support.cs : merged r48826.
4685 > could you integrate your mcs changes to gmcs otherwise
4686 > gmcs cannot compile some files.
4688 2005-08-20 Martin Baulig <martin@ximian.com>
4690 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4691 scope if we don't already have it.
4693 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4694 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4697 2005-07-31 Miguel de Icaza <miguel@novell.com>
4699 * statement.cs: Copy the local exception into the exception
4700 captured local. Fixes 75674
4702 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4704 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4707 2005-08-12 Martin Baulig <martin@ximian.com>
4709 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4710 for nested types here to avoid hitting the cache too early.
4712 2005-08-09 Miguel de Icaza <miguel@novell.com>
4714 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4717 2005-08-03 Martin Baulig <martin@ximian.com>
4719 Make iterators in generic methods work; see gtest-191.cs.
4722 (Constraints.Resolve): Protect against being called twice.
4725 (TypeContainer.GetClassBases): Make this `protected virtual'.
4727 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4728 (Iterator.GetClassBases): Override this and compute the base
4730 (Iterator.DefineNestedTypes): If we're a generic method, all our
4731 method type parameters become class type parameters on the proxy
4735 (ToplevelBlock.Parameters): Make this a property, not a field.
4736 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4738 2005-08-03 Martin Baulig <martin@ximian.com>
4740 * typemanager.cs (TypeManager.IsSubclassOf): Use
4741 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4742 (TypeManager.GetFullName_recursed): Improved.
4744 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4747 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4748 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4749 invocation_type == mi.DeclaringType, since the first one also checks
4750 other condition used by generic instances.
4752 2005-07-27 Martin Baulig <martin@ximian.com>
4754 * anonymous.cs (CaptureContext.AddField): Added
4755 `AnonymousContainer am' argument; compute its toplevel scope if
4756 it's not already computed. Fixes #75649.
4758 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4760 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4761 CheckAttributeType and refactored.
4762 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4763 ResolveAsTypeTerminal error handling.
4764 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4766 (GetSignatureForError): Print errors in same way.
4769 * codegen.cs: Reflect attribute GetSignatureForError change.
4772 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4774 * namespace.cs (UsingEntry): Refactored to make fields private.
4777 statement.cs: Error_UnexpectedKind has extra parameter.
4779 2005-07-14 Raja R Harinath <rharinath@novell.com>
4781 * ecore.cs (IAlias): Remove.
4782 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4783 that implement the interface.
4784 * namespace.cs (Namespace): Likewise.
4785 (Namespace.declspaces): Renamed from 'defined_names'.
4786 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4787 DeclSpace instead of an IAlias.
4788 * tree.cs (Tree.AddDecl): Update.
4790 2005-07-12 Raja R Harinath <rharinath@novell.com>
4792 * statement.cs (Block.Flags); Remove HasVarargs.
4793 (Block.HasVarargs): Move to ToplevelBlock.
4794 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4795 (Block.Variables): Make protected. Initialize variable hashtable
4797 (Block.AddVariable): Update.
4798 (Block.Resolve): Update to changes.
4799 (ToplevelBlock.HasVarargs): New boolean.
4800 (ToplevelBlock.ThisVariable): Move here from Block.
4801 (ToplevelBlock.AddThisVariable): Likewise.
4802 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4803 * expression.cs (This.ResolveBase): Update to changes.
4804 (ArglistAccess.DoResolve): Likewise.
4806 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4809 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4811 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4812 not used and not used & assigned.
4813 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4815 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4818 * expression.cs (Is.DoResolve): null is never provided type.
4820 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4823 * cs-parser.jay: Less strict event error rule to catch more errors.
4825 2005-07-11 Martin Baulig <martin@ximian.com>
4827 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4828 for the constructor constraint: we do not only have to check
4829 whether the class has a public constructor, but also ensure that
4830 it's parameterless. Fixes #75492.
4832 2005-07-11 Martin Baulig <martin@ximian.com>
4834 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4835 between type parameters if they either have the reference type
4836 constraint or the class constraint.
4838 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4840 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4842 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4845 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4846 (ExtractSecurityPermissionSet): Cope with self referencing security
4847 attributes properly.
4849 * driver.cs (SetOutputFile): Made public property OutputFile.
4851 2005-07-07 Raja R Harinath <rharinath@novell.com>
4854 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4855 has_nonstatic_fields. Make into a FieldBase pointer.
4856 (TypeContainer.AddField): Add CS0282 check.
4857 (TypeContainer.EmitType): Update.
4859 2005-07-06 Miguel de Icaza <miguel@novell.com>
4861 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4862 compare if they start with __.
4864 2005-07-06 Raja R Harinath <rharinath@novell.com>
4866 * statement.cs (Switch.SwitchGoverningType): Only look at
4867 UserCasts that don't need implicit standard conversions to one of
4868 the allowed switch types (Fixes test-322.cs).
4869 (LocalInfo.Resolve): Re-enable sanity-test.
4871 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4873 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4875 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4877 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4879 2005-07-06 Raja R Harinath <rharinath@novell.com>
4882 * ecore.cs (SimpleName.GetSignatureForError): Add.
4883 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4884 (MemberAccess.GetSignatureForError): Add.
4886 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4888 The big error and warning messages review.
4918 * typemanager.cs: Updated.
4920 * class.cs: (MethodCore.SetYields): Moved here to share.
4921 (PropertyMethod.Define): Moved iterator setup here.
4923 * iterators.cs: Add orig_method to have full access to parent
4926 2005-07-05 Raja R Harinath <rharinath@novell.com>
4928 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4929 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4930 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4931 variable of struct type.
4932 * expression.cs (Unary.ResolveOperator): Update to change.
4933 (Indirection.VerifyFixed): Likewise.
4934 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4935 (ParameterReference.VerifyFixed): Value parameters are fixed.
4936 (This.VerifyFixed): Treat 'this' as a value parameter.
4937 * statement.cs (LocalInfo.IsFixed): Remove.
4939 2005-07-01 Martin Baulig <martin@ximian.com>
4941 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4942 `ec.EmitThis ()' to get the correct scope.
4944 2005-07-01 Martin Baulig <martin@ximian.com>
4946 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4947 instance is a ParameterReference; fixes #75299.
4949 2005-06-30 Raja R Harinath <rharinath@novell.com>
4952 * expression.cs (Indexers.map): Remove.
4953 (Indexers.Append): Filter out inaccessible setters and getters.
4954 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4957 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4959 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4960 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4961 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4962 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4964 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4967 * class.cs (FieldBase.GetInitializerExpression): One more field
4970 2005-06-28 Miguel de Icaza <miguel@novell.com>
4972 * pending.cs: Do not define a proxy if the base method is virtual,
4973 it will be picked up by the runtime (bug 75270).
4975 2005-07-08 Martin Baulig <martin@ximian.com>
4977 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4978 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4980 2005-07-07 Martin Baulig <martin@ximian.com>
4982 * generic.cs (ConstructedType.CheckConstraint): Use
4983 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4984 called recursively; fixes #75329.
4986 2005-07-06 Martin Baulig <martin@ximian.com>
4988 * generic.cs (TypeManager.InferTypeArguments): Added support for
4989 anonymous methods; fixes #75461.
4991 2005-07-01 Martin Baulig <martin@ximian.com>
4993 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4994 `ec.EmitThis ()' to get the correct scope.
4996 2005-07-01 Martin Baulig <martin@ximian.com>
4998 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4999 instance is `This'; fixes #75299.
5001 2005-06-30 Martin Baulig <martin@ximian.com>
5003 * class.cs (Indexer): Implement IIteratorContainer; added support
5004 for iterators in indexers.
5007 (EmitContext.CurrentIterator): Make this a property, not a field.
5009 * anonymous.cs (AnonymousContainer.Iterator): New public property.
5011 2005-06-28 Miguel de Icaza <miguel@novell.com>
5013 * pending.cs: Do not define a proxy if the base method is virtual,
5014 it will be picked up by the runtime (bug 75270).
5016 2005-06-28 Martin Baulig <martin@ximian.com>
5018 * cs-parser.jay (interface_method_declaration): Avoid a
5019 reduce/reduce conflict by moving some of the code into a separate
5020 `interface_method_declaration_body' rule; fixes #75368.
5022 2005-06-28 Martin Baulig <martin@ximian.com>
5024 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
5025 array check after the check for TypeBuilder's.
5027 2005-06-21 Raja R Harinath <rharinath@novell.com>
5029 * convert.cs (FindMostEncompassedType): Add two trivial special
5030 cases (number_of_types == 0 || number_of_types == 1).
5031 (FindMostEncompasingType): Likewise.
5033 2005-06-17 Raja R Harinath <rharinath@novell.com>
5035 Some cleanups preparing for the fix of #75283.
5036 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
5038 (EventExpr.InstanceResolve): Likewise.
5039 (EventExpr.DoResolve): Remove redundant checks.
5041 2005-06-08 Miguel de Icaza <miguel@novell.com>
5043 * class.cs: Small fix.
5045 2005-06-08 Raja R Harinath <rharinath@novell.com>
5048 * class.cs (GetPartialBases): Fix return value check of
5051 2005-06-07 Raja R Harinath <rharinath@novell.com>
5053 Ensure that partial classes are registered in their enclosing
5054 namespace. Initial part of fix of #75160.
5055 * tree.cs (Tree.RecordDecl): Add new namespace argument.
5056 Register declspace with namespace here, not in
5057 DeclSpace.RecordDecl.
5058 * cs-parser.jay: Pass namespace to RecordDecl.
5059 * class.cs (PartialContainer.Create): Likewise.
5060 (ClassPart.DefineType): New sanity-check. Throws an exception if
5062 * decl.cs (Declspace.RecordDecl): Remove.
5063 * namespace.cs (NamespaceEntry.DefineName): Remove.
5065 2005-06-06 Marek Safar <marek.safar@seznam.cz>
5067 * rootcontext.cs: Reset TargetExt as well.
5069 2005-06-03 Raja R Harinath <rharinath@novell.com>
5071 * ecore.cs (Expression.Resolve): Emit CS0654 error when
5074 2005-06-02 Raja R Harinath <rharinath@novell.com>
5076 Fix #75080, cs0119.cs.
5077 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
5079 (Expression.Resolve): ... this. Use it. Remove bogus code
5080 allowing ExprClass.Type and ExprClass.Namespace for
5081 ResolveFlags.VariableOrValue.
5082 (Expression.Resolve) [1-argument variant]: Change default resolve
5083 flags based on language version.
5084 (Expression.Error_UnexpectedKind): Use a simple string array
5085 rather than an ArrayList.
5086 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
5088 (TypeOfVoid.DoResolve): Likewise.
5089 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
5090 flags argument -- it always has the same value.
5092 2005-05-31 Raja R Harinath <rharinath@novell.com>
5095 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
5096 Use it in the error message.
5097 * assign.cs, expression.cs, statement.cs: Update.
5099 2005-05-30 Raja R Harinath <rharinath@novell.com>
5102 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
5103 the "almostMatchedMember" case too.
5104 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
5105 that failed the accessibility checks to 'almost_match'.
5107 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
5109 * attribute.cs: Use internal MethodBuilder methods to set
5110 ExactSpelling and SetLastError on PInvoke methods, instead
5111 of passing them via charset. Fixes #75060.
5113 2005-05-27 Raja R Harinath <rharinath@novell.com>
5115 * parameter.cs (Parameter): Remove TODO comment.
5116 (Parameter.DefineParameter): Remove Location parameter.
5117 (Parameters.LabelParameters): Likewise.
5118 * class.cs (Constructor.Emit): Update to change.
5119 (MethodData.Emit): Likewise.
5120 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
5121 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
5123 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
5126 Removed Parameters.Location and added Parameter.Location instead.
5127 Removed Location parameter from Emit() and GetSignature().
5134 Modified all related calls.
5136 2005-06-21 Martin Baulig <martin@ximian.com>
5138 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
5139 left-hand side is not a nullable type; fixes #75328.
5141 2005-06-21 Martin Baulig <martin@ximian.com>
5144 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
5145 (TypeManager.GetFullNameSignature): Likewise.
5147 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
5148 `source.FullName' and `target.FullName' to check whether there are
5149 two conflicting definitions.
5151 2005-06-21 Martin Baulig <martin@ximian.com>
5153 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
5154 a BoxedCast - also for reference types - to be compatible with csc.
5156 2005-06-21 Martin Baulig <martin@ximian.com>
5158 * expression.cs (MemberAccess.DoResolve): Add support for nested
5159 types in a generic instance; fixes #75320.
5161 2005-06-20 Martin Baulig <martin@ximian.com>
5163 * generic.cs (TypeManager.InferType): Also walk the class
5164 hierarchy for generic instances; fixes #75261.
5166 2005-06-17 Martin Baulig <martin@ximian.com>
5168 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
5169 to make things work for corlib.
5171 2005-06-15 Martin Baulig <martin@ximian.com>
5173 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
5174 obsolete `SecurityAction' values.
5176 2005-06-06 Marek Safar <marek.safar@seznam.cz>
5178 * rootcontext.cs: Reset TargetExt as well.
5180 2005-06-09 Martin Baulig <martin@ximian.com>
5182 * delegate.cs (Delegate.VerifyMethod): Added
5183 `MethodGroupExpr old_mg' argument; inherit its
5184 `HasTypeParameters'; fix #75085.
5186 2005-06-09 Martin Baulig <martin@ximian.com>
5188 * expression.cs (Invocation.OverloadResolve): Correctly handle
5189 generic methods for the SetMemberIsUsed(); fix #75064.
5191 2005-06-09 Martin Baulig <martin@ximian.com>
5193 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
5196 2005-06-08 Martin Baulig <martin@ximian.com>
5198 * cs-parser.jay (nullable_type_or_conditional): If we put the
5199 nullable back and our `type' is a `ComposedCast', remove the
5200 nullable from it. Fixes #75156.
5202 * expression.cs (ComposedCast.RemoveNullable): New public method.
5204 2005-06-08 Martin Baulig <martin@ximian.com>
5206 The big Iterators rewrite :-)
5208 * iterators.cs: Rewrite this to use the anonymous methods framework.
5210 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
5211 before the TypeContainers; see 2test-21.cs.
5214 (TypeContainer.DefineType): Don't create a new EmitContext if we
5215 already have one (this only happens if we're an Iterator).
5216 (TypeContainer.Define): Also call Define() on all our iterators.
5217 (Method.CreateEmitContext): Added support for iterators.
5220 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
5221 (AnonymousContainer.CreateMethodHost): Moved here from
5222 AnonymousMethod and made abstract.
5223 (AnonymousContainer.CreateScopeType): New abstract method.
5224 (AnonymousContainer.IsIterator): New public property.
5225 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
5226 get the ScopeTypeBuilder rather than manually defining it here.
5227 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
5230 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
5231 before RootContext.DefineTypes().
5233 * codegen.cs (EmitContext.RemapToProxy): Removed.
5234 (EmitContext.CurrentAnonymousMethod): Changed type from
5235 AnonymousMethod -> AnonymousContainer.
5236 (EmitContext.ResolveTopBlock): Protect from being called twice.
5237 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
5238 (EmitContext.EmitThis): Removed the iterators hacks; use the
5239 anonymous methods framework for that.
5242 (ToplevelBlock.Container): Make this a property, not a field.
5243 (ToplevelBlock.ReParent): New public method; move the
5244 ToplevelBlock into a new container.
5245 (Foreach.TemporaryVariable): Simplify.
5247 2005-06-05 Martin Baulig <martin@ximian.com>
5249 * statement.cs (LocalInfo.CompilerGenerated): New flag.
5250 (Block.AddTemporaryVariable): New public method; creates a new
5251 `LocalInfo' for a temporary variable.
5252 (Block.EmitMeta): Create the LocalBuilders for all the temporary
5254 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
5255 non-iterator variables.
5257 2005-06-05 Martin Baulig <martin@ximian.com>
5259 * statement.cs (Foreach.TemporaryVariable): Create the
5260 LocalBuilder in the Emit phase and not in Resolve since in some
5261 situations, we don't have an ILGenerator during Resolve; see
5262 2test-19.cs for an example.
5264 2005-06-04 Martin Baulig <martin@ximian.com>
5266 The big Foreach rewrite - Part II.
5268 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
5269 with `PropertyInfo ienumerator_getcurrent'.
5271 * codegen.cs (VariableStorage): Removed.
5274 (Foreach): Derive from Statement, not ExceptionStatement.
5275 (Foreach.CollectionForeach): New nested class. Moved all the code
5276 dealing with collection foreach here.
5277 (Foreach.ForeachHelperMethods): Removed.
5278 (Foreach.TemporaryVariable): Implement IMemoryLocation.
5280 2005-05-23 Martin Baulig <martin@ximian.com>
5282 * statement.cs (Try.DoResolve): Don't create a `finally' if we
5283 don't need to. Fix #75014.
5285 2005-05-26 Raja R Harinath <rharinath@novell.com>
5287 Improve user-defined conversion handling.
5288 * convert.cs (GetConversionOperators): Rewrite. Return only the
5289 applicable operators.
5290 (AddConversionOperators): New. Helper for GetConversionOperators.
5291 (FindMostEncompassedType, FindMostEncompassingType): Verify that
5292 there is only one most encompassed/encompassing type.
5293 (FindMostSpecificSource, FindMostSpecificTarget): Remove
5294 "applicable operator" handling.
5295 (UserConversion): Move cache here from GetConversionOperators.
5296 Directly cache the chosen operator, rather than the whole
5298 (ExplicitNumericConversion): Fix buggy implementation of Decimal
5299 case. Allow conversion of decimal to sbyte and byte too.
5300 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5301 New static methods. Used to avoid allocating EmptyExpressions in
5304 2005-05-24 Duncan Mak <duncan@novell.com>
5306 * ecore.cs (CastFromDecimal): New class for casting a decimal to
5307 another class, used in Convert.ExplicitNumericConversion.
5308 (CastToDecimal): New class, similar to above, but casts to
5309 System.Decimal, used in Convert.ImplicitNumericConversion and also
5310 in explicit convesion from double/float to decimal.
5312 * convert.cs (ImplicitNumericConversion): Handle implicit
5313 conversions to System.Decimal.
5314 (ExplicitNumericConversion): handle explicit conversions to
5319 2005-05-20 Miguel de Icaza <miguel@novell.com>
5321 * typemanager.cs: Do not throw an exception in the TypeBuilder
5322 case, we take care of it on the TypeCode.
5324 2005-05-17 Marek Safar <marek.safar@seznam.cz>
5326 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
5329 * cs-parser.jay: Catch more lexical errors.
5331 * report.cs: Add one more Error method.
5334 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
5336 2005-05-20 Martin Baulig <martin@ximian.com>
5338 * class.cs (TypeContainer.CircularDepException): Removed.
5339 (TypeContainer.DefineType): Removed the `InTransit' stuff.
5340 (TypeContainer.CheckRecursiveDefinition): Check for circular class
5341 (CS0146) and interface (CS0529) dependencies here.
5343 2005-05-20 Martin Baulig <martin@ximian.com>
5345 * expression.cs (New.DoResolve): Move the CS0712 check above the
5346 CS0144 check; otherwise it can never be reached.
5348 2005-05-20 Martin Baulig <martin@ximian.com>
5350 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
5352 2005-05-20 Martin Baulig <martin@ximian.com>
5354 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
5356 * typemanager.cs (TypeManager.IsAttributeType): New public method.
5358 2005-05-19 Martin Baulig <martin@ximian.com>
5361 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
5362 to disable error reporting.
5364 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
5365 here since we don't want to report an error; see the new test-336.cs.
5367 2005-05-19 Raja R Harinath <rharinath@novell.com>
5369 * statement.cs (ToplevelBlock.GetParameterReference)
5370 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
5371 Move here from class Block.
5372 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
5373 * expression.cs (ParameterReference.DoResolveBase): Likewise.
5375 2005-05-18 Martin Baulig <martin@ximian.com>
5380 (FlowBranching.Reachability): Add non-static public And() and Or()
5382 (FlowBranchingSwitch): New class; do the `break_origins' thing
5383 like in FlowBranchingLoop.
5384 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
5385 reachability, not just locals and parameters.
5386 (FlowBranching.MergeChild): Remove some of the hacks for loop and
5387 switch; MergeBreakOrigins() now takes care of that.
5389 2005-05-18 Martin Baulig <martin@ximian.com>
5391 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
5392 a loop and may leave it, reset the barrier; fixes #74974.
5394 2005-05-16 Raja R Harinath <rharinath@novell.com>
5396 Fix test-382.cs. Emit values of decimal constants.
5397 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
5399 (TypeContainer.AddField): ... this.
5400 (TypeContainer.EmitFieldInitializers): Allow the list of fields
5401 with initializers to include 'Const's.
5402 (ClassPart.RegisterFieldForInitialization): Forward to
5404 * const.cs (Const.Const): Pass initializer to base class.
5405 (Const.Define): In case of decimal constants, register them for
5406 initialization in a static constructor.
5408 2005-05-14 Martin Baulig <martin@ximian.com>
5410 * statement.cs (Block.Resolve): Correctly handle unreachable code;
5411 do not call ResolveUnreachable() on unreachable statements in
5412 here, see the comment in the source code.
5414 2005-05-13 Raja R Harinath <rharinath@novell.com>
5417 * expression.cs (BinaryResolveOperator): If one of the operands of
5418 an equality comparison is 'null' and the other is a pointer type,
5419 convert the null to a NullPointer.
5420 * convert.cs (ImplicitReferenceConversion): If the expression is a
5421 NullLiteral and the target type is a pointer type, return a
5422 NullPointer instead.
5423 (ImplicitConversionStandard): Likewise.
5425 2005-05-13 Marek Safar <marek.safar@seznam.cz>
5427 * cs-parser.jay: Set readonly context based on special constructs.
5429 * expression.cs (LocalVariableReference.DoResolveBase): Improved
5430 readonly variable error handling.
5432 * rootcontext.cs (EmitCode): Don't verify members when error
5435 * statement.cs (LocalInfo): Add reaodnly context information.
5436 (SetReadOnlyContext, GetReadOnlyContext): New methods.
5438 2005-05-17 Martin Baulig <martin@ximian.com>
5440 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
5443 2005-05-13 Martin Baulig <martin@ximian.com>
5445 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
5446 handle unreachable blocks.
5448 2005-05-13 Martin Baulig <martin@ximian.com>
5451 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
5452 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
5455 2005-05-13 Martin Baulig <martin@ximian.com>
5457 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5458 instance variable, not a local. Fix #74873.
5459 (Block.ResolveUnreachable): Set it to true here.
5461 2005-05-12 Martin Baulig <martin@ximian.com>
5463 * cs-parser.jay (property_declaration): Pass the `current_class',
5464 not the `current_container' to Property's .ctor. Fixes #74912.
5466 2005-05-11 Martin Baulig <martin@ximian.com>
5468 * typemanager.cs (Closure): Copy this from MCS and merge all the
5469 GMCS-specific changes into it.
5471 2005-05-12 Raja R Harinath <harinath@gmail.com>
5474 * typemanager.cs (unmanaged_enclosing_types): New.
5475 (IsUnmanagedType): Avoid infloops by using
5476 'unmanaged_enclosing_types' to talk with recursive invocations.
5478 2005-05-11 Duncan Mak <duncan@novell.com>
5480 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5481 continuing to process for 'arg'.
5482 (handle_preprocessing_directive): Check the argument of the #endif
5483 directive and report error CS1025 if there are any trailing
5486 According to the C# spec, having even whitespace after the #endif
5487 directive is illegal; however, because we call arg.TrimEnd ()
5488 beforehand, we have the same behavior as csc, allowing whitespace
5489 after the directive.
5493 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5497 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5498 (Constructor.GetObsoleteAttribute): Implemented correctly.
5500 2005-05-10 Martin Baulig <martin@ximian.com>
5502 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5503 resolve the type; fixes #74864.
5504 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5505 in DoResolve(); fixes #74862.
5507 2005-05-10 Martin Baulig <martin@ximian.com>
5509 * support.cs (ReflectionParameters.ParameterModifier): Use
5510 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5511 and `ParameterAttributes.In'. Fixes #74884.
5513 2005-05-10 Martin Baulig <martin@ximian.com>
5515 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5516 the cache if we're just looking for `MemberTypes.NestedType' in a
5519 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5520 constraints if we're still resolving the type tree.
5521 (Expression.MemberLookup): If we're resolving the type tree, only
5522 look for `MemberTypes.NestedType' since we're only interested in
5525 * class.cs (TypeContainer.DefineType): Don't resolve the type
5526 parameters here; do this later in ResolveType() after the type
5527 tree has been resolved.
5528 (TypeContainer.ResolveType): New public method; this is called
5529 after the type tree is resolved and before the types are being
5530 populated. We resolve the generic constraints here.
5531 (TypeContainer.DoDefineMember): Check the constraints on our base
5532 class and interfaces.
5534 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5535 set the `ResolvingTypeTree' flag on the EmitContext.
5537 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5539 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5541 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5543 * expression.cs (Argument.GetParameterModifier): Turned to property.
5544 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5546 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5549 2005-05-09 Raja R Harinath <rharinath@novell.com>
5552 * decl.cs (MemberCache.AddMethods): Register override methods,
5553 rather than non-override methods.
5554 * typemanager.cs (RegisterOverride): New.
5555 (IsOverride): Update.
5557 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5559 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5561 2005-05-06 Martin Baulig <martin@ximian.com>
5564 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5565 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5567 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5571 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5572 recursive declaration.
5574 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5576 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5578 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5580 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5582 2005-05-05 Raja R Harinath <rharinath@novell.com>
5585 * decl.cs (DeclSpace.FamilyAccessible):
5586 Use TypeManager.IsNestedFamilyAccessible.
5588 Fix reopened #64812.
5589 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5592 2005-05-04 Raja R Harinath <rharinath@novell.com>
5593 Abin Thomas <projectmonokochi@rediffmail.com>
5594 Anoob V E <projectmonokochi@rediffmail.com>
5595 Harilal P R <projectmonokochi@rediffmail.com>
5598 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5599 allow access to all static members.
5601 2005-05-04 Martin Baulig <martin@ximian.com>
5603 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5605 2005-05-04 Martin Baulig <martin@ximian.com>
5609 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5610 section at the end; make things work if `default' is not the last
5613 2005-05-04 Martin Baulig <martin@ximian.com>
5617 * statement.cs (Switch): Replaced the `got_default' field with a
5618 `default_section' one.
5619 (Switch.CheckSwitch): Set `default_section' here.
5620 (Switch.Resolve): If we're a constant switch and the constant is
5621 not found, use the default section.
5623 2005-05-03 Martin Baulig <martin@ximian.com>
5625 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5627 * statement.cs (Foreach.ArrayForeach): New nested class.
5628 (Foreach.TemporaryVariable): New nested class.
5629 (Foreach.EmitArrayForeach): Removed; this is now in the new
5632 2005-05-03 Raja R Harinath <rharinath@novell.com>
5634 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5636 (VerifyPendingMethods): Revert change below.
5638 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5639 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5640 that used to trigger warning -28. Remove warning -28.
5641 * expression.cs (Invocation.OverloadResolve): Use
5642 TypeManager.IsOverride to distinguish override methods.
5645 * pending.cs (VerifyPendingMethods): If a base type implements the
5646 requested interface, don't bother checking individual methods of
5647 the base type. As a side-effect, this prevents the creation of
5648 unnecessary proxies.
5650 2005-05-02 Martin Baulig <martin@ximian.com>
5654 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5655 Also `And' the locals if the old vector is null.
5656 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5657 null; in this case we basically reset all the variables.
5659 2005-05-02 Martin Baulig <martin@ximian.com>
5663 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5664 Added `FlowBranching branching' argument; always `and' the
5665 variables instead of `or'ing them unless we're an infinite loop.
5667 * statement.cs (While.Resolve): Create a new sibling unless we're
5670 2005-05-02 Martin Baulig <martin@ximian.com>
5674 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5675 arguments; use it instead of creating a new TopLevelBlock.
5676 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5677 our ConstructorInitializer.
5680 (TopLevelBlock.TopLevelBranching): New public property.
5681 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5682 and create our `TopLevelBranching'.
5684 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5685 anonymous method host, use `block.TopLevelBranching' rather than
5686 creating a new branching.
5688 2005-04-20 Miguel de Icaza <miguel@novell.com>
5690 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5691 a ScopeInfo, if any of the current children is a child of the new
5692 entry, move those children there.
5694 2005-04-30 Martin Baulig <martin@ximian.com>
5696 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5697 at the beginning of a SwitchSection. Fix #73335.
5699 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5702 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5704 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5705 (FieldExpr.DoResolve): Obsolete members are ignored for field
5708 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5710 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5711 of arrays detection.
5713 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5715 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5717 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5720 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5722 * cs-parser.jay: Use the prefered version of -unsafe in error
5725 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5727 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5730 2005-04-20 John Luke <john.luke@gmail.com>
5732 * driver.cs: fix typo in error message, --outout to --output
5734 2005-04-30 Martin Baulig <martin@ximian.com>
5736 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5737 handle the .NET 2.x security attributes.
5739 2005-04-30 Martin Baulig <martin@ximian.com>
5742 (TypeManager.ExpandInterfaces): Don't add things twice.
5745 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5747 2005-04-29 Martin Baulig <martin@ximian.com>
5749 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5751 * anonymous.cs: Added support for anonymous generic methods.
5753 2005-04-29 Martin Baulig <martin@ximian.com>
5755 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5758 2005-04-29 Martin Baulig <martin@ximian.com>
5760 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5762 * expression.cs (New.DoResolve): Fix the CS0304 check.
5764 2005-04-29 Martin Baulig <martin@ximian.com>
5766 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5769 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5770 explicit interface implementation, compare the interface types.
5771 (MethodData.Define): Use the new naming scheme from the latest
5773 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5775 * decl.cs (MemberName.GetMemberName): Removed.
5776 (MemberName.MethodName, FullName): New properties.
5778 2005-04-25 Raja R Harinath <rharinath@novell.com>
5780 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5782 2005-04-22 Martin Baulig <martin@ximian.com>
5784 * generic.cs (GenericMethod): Create the EmitContext in the
5785 `Define()'; in `Define(MethodBuilder)', create the type parameters
5786 before calling `Define()'. Fixes #73933.
5788 2005-04-22 Martin Baulig <martin@ximian.com>
5791 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5792 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5794 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5795 ConstructedType, check its constraints.
5797 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5799 * codegen.cs (InRefOutArgumentResolving): New field.
5801 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5802 fields outside contructor.
5804 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5806 2005-04-19 Miguel de Icaza <miguel@novell.com>
5808 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5809 parameter code was not completed ever, so it was not as up-to-date
5810 as local variables. Must finish it.
5812 The bug fix was to compare the Toplevel of the block, not the
5813 current block. Thanks for Ben for pointing this out.
5815 2005-04-19 Raja R Harinath <rharinath@novell.com>
5817 * decl.cs (AddMethods): Use the declaring type of the problem
5818 method to determine if we want to squash a warning.
5820 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5822 * attribute.cs: Removed debug output.
5824 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5826 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5829 2005-04-18 Raja R Harinath <rharinath@novell.com>
5832 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5833 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5834 all null comparisons against reference types.
5836 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5839 * class.cs (TypeContainer.CircularDepException) New nested
5841 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5842 (TypeContainer.DefineType): Removed error, reset InTransit before
5844 (Class.DefineType): Throw exception when is in Transit.
5845 Catch exception and report error.
5846 (Struct.DefineType): Throw exception when is in Transit.
5847 Catch exception and report error.
5848 (Interface.DefineType): Throw exception when is in Transit.
5849 Catch exception and report error.
5851 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5852 handle nested exception handlers.
5854 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5857 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5858 InFinally and InCatch storage.
5860 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5861 (Catch.Resolve): Set and Restore ec.InCatch.
5862 (Try.Resolve): Set and Restore ec.InFinally.
5863 (Try.HasCatch): True when try has catch.
5865 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5867 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5868 for the same event member, so exclude such cases from warning 419.
5871 2005-04-16 Miguel de Icaza <miguel@novell.com>
5873 * expression.cs (Binary.ResolveOperator): Apply patch from John
5874 Luke to fix bug 59864: operators &, | and ^ on enumerations
5875 require that the same enum type on both sides.
5877 * driver.cs: Add warnings to old flag usage, this is to assist
5878 people who produce Makefiles and hope that the Makefiles will be
5881 * class.cs (TypeContainer.EmitType): Moved the definition of the
5882 special $PRIVATE$ field from the resolve phase to the Emit phase.
5883 During resolve we do not know if we are a struct with
5884 HasExplicitLayout, we know this only after the attributes for the
5887 Set the FieldOffset to zero on the dummy field that we create for
5888 the class. Fixes 74590.
5890 2005-04-16 Raja R Harinath <rharinath@novell.com>
5893 * ecore.cs (PropertyExpr.resolved): New.
5894 (DoResolve): Use it to handle a case of double resolution here.
5895 Handle a case of identical-name-and-type-name.
5896 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5897 resolution by storing the results of expression resolution back
5898 into the "probes" array.
5900 2005-04-15 Raja R Harinath <rharinath@novell.com>
5902 Fix cs0208-7.cs and cs0208-8.cs.
5903 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5904 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5905 error reporting to point out the reason a struct is not unmanaged.
5907 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5909 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5910 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5912 2005-04-13 Raja R Harinath <rharinath@novell.com>
5915 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5916 IdenticalNameAndTypeName here.
5917 (EventExpr.InstanceResolve): Likewise.
5919 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5921 C# 2.0 DefaultCharSetAttribute implementation
5923 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5924 which allows us to set GlobalNamespace for every resolve.
5925 (Attribute.ResolveArguments): Cut from Resolve.
5926 (Attribute.GetCharSetValue): Returns CharSet named argument.
5927 (Attribute.DefinePInvokeMethod): Gets default charset from
5929 (GlobalAttribute.ResolveAsTypeStep): Override.
5930 (GlobalAttribute.ResolveArguments): Override.
5932 * class.cs (TypeAttr): Is protected.
5934 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5935 (ModuleClass.DefaultCharSetType): New memeber.
5936 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5938 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5939 charset from module.
5941 * delegate.cs (TypeAttr): Override.
5942 (Delegate.DefineType): Use this TypeAttr.
5944 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5945 at very early stage (before types are defined) to resolve model
5946 module attributes. It will probably not work with corlib but it
5949 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5950 charset from module.
5952 * typemanager.cs (default_charset_type): New type.
5954 2005-04-13 Raja R Harinath <rharinath@novell.com>
5956 * decl.cs (MemberCache.AddMethods): Don't warn if
5957 System.Object.Finalize has buggy MethodAttributes.
5959 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5962 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5964 * doc.cs : detect ambiguous reference to overloaded members.
5965 Fixed bug #71603. MS 1.1 csc does not detect it.
5967 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5969 * doc.cs : delegates must not be referenced with parameters.
5972 2005-04-12 Miguel de Icaza <miguel@novell.com>
5974 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5976 2005-04-10 Miguel de Icaza <miguel@novell.com>
5978 * driver.cs (MainDriver): Stop processing if the CLS stage found
5981 (CompilerCallableEntryPoint.InvokeCompiler): Always
5982 reset after execution; Take a TextWriter argument for the
5985 * report.cs: Use the error stream instead of hardcoding stderr.
5987 2005-04-09 Miguel de Icaza <miguel@novell.com>
5989 * class.cs: Reduce code paths to test, too small of an
5990 optimization to make it worth the extra testing. Always perform
5993 2005-04-08 Raja R Harinath <rharinath@novell.com>
5996 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5997 operators that had errors reported on them.
5999 2005-04-08 Marek Safar <marek.safar@seznam.cz>
6001 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
6003 (Attribute.Resolve): Add named argument type checking.
6005 * class.cs (FixedField.Define): Use IsPrimitiveType
6007 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
6009 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
6010 unsafe parameter types.
6012 * statement.cs (Using.ResolveExpression): Add better error description.
6014 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
6016 2005-04-08 Raja R Harinath <rharinath@novell.com>
6019 * attribute.cs (Attribute.GetAttributeUsage): Resolve
6020 AttributeUsageAttribute in the emitcontext of the attribute class,
6021 not in the emitcontext of the attributable entity it was attached to.
6022 * cs-parser.jay: Use 'current_class', not 'current_container',
6023 when creating a GlobalAttribute.
6025 2005-04-08 Alp Toker <alp@atoker.com>
6027 * pending.cs: The fix to #58413 failed to compile methods implementing
6028 interfaces with/without params modifiers and vice versa, even though
6029 params modifiers aren't part of the signature. Make the modifier check
6030 less strict as in csc.
6032 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
6033 Anoob V E <projectmonokochi@rediffmail.com>
6034 Harilal P R <projectmonokochi@rediffmail.com>
6037 * pending.cs (TypeAndMethods.mods): New. Store the parameter
6038 modifiers of pending methods.
6039 (PendingImplementation.PendingImplementation): Initialize it.
6040 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
6041 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
6042 with ParameterData. Add check for modifiers.
6043 * class.cs (MethodData.Define): Update to changes.
6045 2005-04-07 Raja R Harinath <rharinath@novell.com>
6047 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
6049 2005-04-07 Marek Safar <marek.safar@seznam.cz>
6051 * class.cs (PropertyMethod.Define): Check private accessor in abstract
6054 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
6057 * typemanager.cs: Registered RequiredAttributeAttribute.
6059 2005-04-06 Marek Safar <marek.safar@seznam.cz>
6061 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
6062 Warning CS0169 is back at level 3.
6063 (IMethodData.SetMemberIsUsed): New method.
6065 * decl.cs (IsUsed): New value; moved from FieldBase.Status
6066 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
6068 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
6070 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
6072 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
6075 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
6078 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
6079 to avoid the problems with nested types.
6081 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
6082 Anoob V.E <projectmonokochi@rediffmail.com>
6083 Harilal P.R <projectmonokochi@rediffmail.com>
6084 Raja R Harinath <rharinath@novell.com>
6087 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
6089 * typemanager (GetConstructor): Make public.
6091 2005-04-05 John Luke <john.luke@gmail.com>
6092 Raja R Harinath <rharinath@novell.com>
6095 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
6096 struct too. Return false quicker in a few cases.
6097 (VerifyUnManaged): Use it.
6099 2005-04-05 Raja R Harinath <rharinath@novell.com>
6102 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
6103 not 'unreachable_seen'.
6105 2005-04-04 Marek Safar <marek.safar@seznam.cz>
6107 * attribute.cs (Attribute.GetValue): Removed unused.
6109 * codegen.cs (CodeGen.TrimExt): Removed unused.
6111 * cs-parser.jay (output): Removed unused.
6113 * cs-tokenizer.cs (hex_digits): Removed unused.
6115 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
6117 * expression.cs (Indirection.LoadExprValue): Removed unused.
6118 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
6120 * iterators.cs (Iterator.param_types): Removed unused.
6122 * statement.cs (Goto.block): Removed unused.
6123 (ToplevelBlock.did): Removed unused.
6124 (Switch.ResolveConstantSwitch): Removed unused.
6126 2005-04-01 Ben Maurer <bmaurer@ximian.com>
6128 * rootcontext.cs: Allow mcs to bootstrap with the compilation
6131 2005-04-19 Martin Baulig <martin@ximian.com>
6133 Merged r42462 from MCS and made it work for GMCS.
6135 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
6137 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
6139 2005-04-01 Raja R Harinath <rharinath@novell.com>
6141 Fix #74232 and cs0208-3.cs.
6142 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
6143 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
6144 unmanaged type. Don't use FieldBuilders when 't' is a
6145 TypeBuilder. Use ModFlags and MemberType fields.
6146 * class.cs (MemberBase.member_type): Rename from MemberType.
6147 (MemberBase.MemberType): New property. Determines member_type on
6149 (MemberBase.DoDefine): Don't initialize MemberType here.
6150 (FieldMember.Define): Likewise.
6152 2005-04-01 Marek Safar <marek.safar@seznam.cz>
6155 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
6156 Attributes are emitted there.
6158 2005-04-01 Raja R Harinath <rharinath@novell.com>
6160 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
6161 keyword in 'partial enum' too.
6162 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
6164 Report from Kamil Skalski <nazgul@omega.pl>.
6167 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
6168 have partial containers too.
6170 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
6171 in block' checks to Block.CheckInvariantMeaningInBlock.
6172 * statement.cs (Block.GetKnownVariableInfo): Make private.
6173 (Block.IsVariableUsedInChildBlock): Remove.
6174 (Block.IsVariableUsedInBlock): Likewise.
6175 (Block.CheckInvariantMeaningInBlock): New. Show location of
6176 conflicting declaration.
6177 (Block.AddVariable): Make error messages less long-winded and more
6178 specific. Show location of conflicting declaration.
6179 * parameter.cs (Parameters.Location): New readonly property.
6181 2005-03-31 Raja R Harinath <rharinath@novell.com>
6183 Clean up semantics of invoking ResolveMemberAccess.
6184 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
6185 can have an instance, ensure that we pass in a non-TypeExpression
6186 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
6187 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
6188 argument. Update to changes and simplify.
6189 (FieldExpr.Emitinstance): Remove CS0120 check.
6190 (PropertyExpr.EmitInstance): Likewise.
6191 * expression.cs (Argument.Resolve): Likewise.
6192 (Invocation.DoResolve): Update to changes in semantics of
6195 2005-03-31 Marek Safar <marek.safar@seznam.cz>
6198 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
6201 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
6203 2005-03-31 Raja R Harinath <rharinath@novell.com>
6205 Fix difference in behaviour with commandline invocation.
6206 * driver.cs (Driver.Reset): New.
6207 (CompilerCallableEntryPoint): Call it.
6209 * statement.cs (If.Resolve): Avoid spurious "uninitialized
6210 variable" warnings if the boolean expression failed to resolve.
6212 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
6214 * attribute.cs: Fix the union of several permissions when some of them
6215 are unrestricted (so the result isn't an unrestricted permission set).
6218 2005-03-30 Raja R Harinath <rharinath@novell.com>
6220 * ecore.cs (MemberExpr): New class. Convert from interface
6222 (MemberExpr.ResolveMemberAccess): Refactor and move here from
6223 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
6225 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
6226 (MethodGroupExpr.IsExplicitImpl): Remove.
6227 (Expression.GetFieldFromEvent): Remove.
6228 (SimpleName.MemberStaticCheck): Remove.
6229 (SimpleName.DoSimpleNameResolve): Update to changes.
6230 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
6231 (MemberAccess.IdenticalNameAndTypeName): Remove.
6232 (MemberAccess.error176): Move to MemberExpr.
6233 (MemberAccess.DoResolve): Update to changes.
6234 (BaseAccess.DoResolve): Likewise.
6236 2005-03-30 Marek Safar <marek.safar@seznam.cz>
6238 C# 2.0 Conditional attribute class implementation
6240 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
6241 Analyzes class whether it has attribute which has ConditionalAttribute
6242 and its condition is not defined.
6244 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
6245 (Class.IsExcluded): New method. Search for at least one defined
6246 condition in ConditionalAttribute of attribute class.
6248 2005-03-30 Raja R Harinath <rharinath@novell.com>
6250 * ecore.cs (PropertyExpr): Derive from Expression, not
6251 ExpressionStatement.
6252 (PropertyExpr.EmitStatement): Remove.
6254 2005-03-29 Raja R Harinath <rharinath@novell.com>
6257 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
6258 internal field "value__" of an enum be private. The examples for
6259 "value__" that I found on MSDN all used FieldAttributes.Private.
6261 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
6262 Don't mention IL method attribute names.
6264 Fix #47991. Remove a TODO.
6265 * statement.cs (Block.Toplevel): Make into a field.
6266 (Block.Parameters): Move into ToplevelBlock.
6267 (Block.known_variables): Rename from child_variable_names.
6268 (Block.Block): Remove variants that take Parameters. Initialize
6269 'Toplevel' with the immediately surrounding toplevel block.
6270 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
6271 LocalInfo parameter.
6272 (Block.GetKnownVariableInfo): New.
6273 (Block.IsVariableNameUsedInChildBlock): Update.
6274 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
6275 the block, even though it may not be in scope.
6276 (Block.AddVariable): Remove Parameters parameter. Use
6277 Toplevel.Parameters instead.
6278 (Block.AddConstant): Remove Parameters parameter.
6279 (Block.GetParameterReference): Update to use Toplevel.Parameters.
6280 (Block.IsParamaterReference): Likewise.
6281 (Block.IsLocalParameter): Likewise. Simplify a lot.
6282 (ToplevelBlock.Parameters): New. Moved from Block.
6283 (ToplevelBlock.ToplevelBlock): Update to changes. Always
6284 initialize Parameters to a non-null value.
6285 * cs-parser.jay: Update to changes.
6286 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
6287 simple names that mean different things in the same block. Use
6288 Block.IsVariableNameUsedInBlock.
6290 2005-03-28 Raja R Harinath <rharinath@novell.com>
6292 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
6294 2005-03-26 Raja R Harinath <harinath@acm.org>
6297 * assign.cs (Assign.DoResolve): When the RHS of an assignment
6298 fails to resolve, ensure that the LHS is still resolved as an
6301 2005-03-25 Raja R Harinath <harinath@acm.org>
6303 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
6305 (Enum.current_ec): Remove.
6306 (Enum.LookupEnumValue): Remove EmitContext argument.
6307 Just uses the one created during DefineType.
6308 (Enum.FindMembers): Update.
6309 * expression.cs (MemberAccess.DoResolve): Update.
6311 2005-03-22 Marek Safar <marek.safar@seznam.cz>
6313 * assign.cs (Assign.DoResolve): Check for CS1717 when
6314 source and target are same (uses Equals).
6316 * expression.cs (LocalVariableReference, ParameterReference,
6317 This): Implemented Equals, GetHashCode.
6319 * statement.cs (Block.GetParameterReference): Removed useless
6322 2005-03-22 Raja R Harinath <rharinath@novell.com>
6325 * statement.cs (Block.AddVariable): Ensure that we skip implicit
6326 blocks before deciding whether the error is cs0136 or cs0128.
6328 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
6329 (using_alias_directive, using_namespace_directive): Pass
6330 MemberName, not an expression to Namespace.UsingAlias and
6332 (MakeName): Use the MemberName of the namespace.
6333 * namespace.cs (Namespace.MemberName): New.
6334 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
6335 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
6337 * decl.cs (MemberName.Name): Make readonly.
6338 (MemberName.FromDotted): New "constructor".
6339 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
6340 (MemberCore.Name): Compute from MemberName on demand.
6341 (MemberCore.SetMemberName): Provide a way to change the
6343 (MemberCore.AddToContainer): Don't take a fullname parameter.
6344 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
6345 fully qualified name of the container to the member name.
6346 (TypeContainer.AddToTypeContainer): Use a fully qualified name
6347 only if the type is a member of the root container.
6348 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
6349 MemberName.Left rather than searching for an embedded ".".
6350 (PartialContainer.CreatePart): Update to changes in RootContext.
6351 (MemberBase.ShortName): Turn into a property. Use
6352 MemberCore.SetMemberName.
6353 (MemberBase.ExplicitInterfaceName): Remove.
6354 (MemberBase.UpdateMemberName): Remove.
6355 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
6356 (PropertyBase.SetMemberName): New override.
6357 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
6358 (Tree.GetDecl): New.
6359 (Tree.AllDecls): Rename from Decls.
6360 * attribute.cs, enum.cs, report.cs: Update to changes.
6361 * driver.cs (MainDriver): Use MemberName.FromDotted on
6362 RootContext.MainClass.
6364 2005-03-21 Marek Safar <marek.safar@seznam.cz>
6366 * class.cs (FixedField.Define): Check for CS1664 and more sanity
6369 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
6371 2005-03-18 Marek Safar <marek.safar@seznam.cz>
6373 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
6374 property accessor modifiers.
6376 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
6377 fixed buffer attribute (CS1716).
6378 (PropertyMethod.HasCustomAccessModifier): When property accessor
6379 has custom modifier.
6381 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
6383 (PropertyExpr.DoResolveLValue): Add CS0272.
6385 2005-03-17 Miguel de Icaza <miguel@novell.com>
6387 * convert.cs: When converting to a pointer, use the proper Conv.U
6388 or Conv.I depending on the source data type.
6390 * cs-tokenizer.cs: Make the size for large decimal constants,
6393 2005-03-17 Martin Baulig <martin@ximian.com>
6395 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6396 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6398 2005-03-17 Martin Baulig <martin@ximian.com>
6400 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6401 to bool so we can return an error condition.
6402 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6405 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
6407 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
6410 2005-03-16 Raja R Harinath <rharinath@novell.com>
6412 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
6413 Refactor to avoid traversing the list of assemblies, and to avoid
6414 string concatenation.
6415 * typemanager.cs (guid_attr_type): Remove.
6416 (negative_hits, pointers, references): Remove hashes.
6418 (GetConstructedType): New. Uses type_hash to handle constructed
6419 types (arrays, references, pointers).
6420 (GetReferenceType, GetPointerType): Use it.
6421 (GetNestedType): New. Uses type_hash to handle nested types of
6423 (LookupType, LookupTypeDirect): Remove.
6424 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
6425 'types' hash and LookupTypeReflection directly.
6426 (params_string, params_object): Use GetConstructedType.
6427 * namespace.cs (Namespace.cached_types): New. Cache of reflected
6429 (Namespace.Lookup): Use cached_types.
6430 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
6431 provided by old TypeManager.LookupType.
6432 * rootcontext.cs (MakeFQN): Remove.
6433 * decl.cs (DeclSpace.MakeFQN): Likewise.
6434 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
6435 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6436 TypeManager.GetConstructedType.
6437 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
6439 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
6441 * cs-parser.jay: Fix build.
6443 2005-03-15 Marek Safar <marek.safar@seznam.cz>
6445 * class.cs (TypeContainer.CircularDepException) New nested
6446 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
6448 * cs-parser.jay: Reports CS1527 for any namespace element.
6450 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
6453 * expression.cs (ParameterReference.IsAssigned): Changed error to
6455 (Error_WrongNumArguments): Moved CS0245 detection here.
6457 * statement.cs (Return.Resolve): Add CS1622 report.
6459 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6461 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6463 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6465 * attribute.cs expression.cs: Get rid of some allocations.
6467 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6469 * doc.cs : just eliminate the latest change.
6471 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6473 * doc.cs : commented out the latest change. It breaks xml-030.cs
6475 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6477 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6478 fail. So invoke CreateType() in FindDocumentedType().
6480 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6482 * cs-tokenizer.cs : added IsKeyword().
6483 * doc.cs : Detect keyword incorrectly used as identifier.
6484 Allow identifiers prefixed by @.
6486 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6488 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6489 It caused exception in namespace resolving (again!).
6491 * class.cs (Class.ctor): Removed exit.
6492 (PropertyMethod.ctor): ditto.
6494 * codegen.cs (Codegen.Reset): Reset static data.
6495 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6497 * cs-tokenizer.cs (Cleanup): Removed.
6499 * driver.cs (GetSystemDir): Rewrote to one line command.
6500 It caused problem with unloaded dynamic modules.
6501 (UnixParseOption): Removed Exit.
6502 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6503 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6504 Now can be mcs used as library.
6506 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6509 * location.cs (Reset): Reset static data.
6511 * namespace.cs (Reset): Reset static data.
6513 * report.cs (Report.Reset): Reset static data.
6515 * rootcontext.cs (RootContext.Reset): Reset static data.
6517 * tree.cs (RootTypes.ctor): Use Location.Null
6519 * typemanager.cs (TypeManager.Reset): Reset static data.
6520 (CoreLookupType): Removed Exit.
6521 (TypeHandle.Reset): Reset static data.
6523 2005-03-10 Raja R Harinath <rharinath@novell.com>
6526 * typemanager.cs (ComputeNamespaces): Import namespaces from
6527 referenced modules too.
6529 2005-03-09 Raja R Harinath <rharinath@novell.com>
6531 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6534 2005-03-09 Raja R Harinath <rharinath@novell.com>
6536 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6537 enclosing DeclSpace. This ensures that a name-lookup populates
6538 more caches and there are fewer 'TypeExpression's. Carve out
6539 nested type lookup into ...
6540 (LookupNestedTypeInHierarchy): ... this.
6542 2005-04-15 Martin Baulig <martin@ximian.com>
6544 Merged r41590 from MCS and make it work in the generics land.
6546 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6549 * class.cs (PartialContainer.UpdateConstraints): Removed.
6550 (PartialContainer.CheckConstraints): Removed.
6551 (PartialContainer.SetParameterInfo): Store the constraints here.
6552 (PartialContainer.DefineTypeParameters): New public method;
6553 resolve the type parameter's constraints here. Note that the
6554 PartialContainer doesn't have an EmitContext anymore, so we must
6555 do this in the ClassPart.
6557 2005-03-09 Raja R Harinath <rharinath@novell.com>
6559 Clean up a few partial-class semantics.
6560 Fixes test-357.cs and cs1618-2.cs.
6561 * cs-parser.jay (struct_declaration): Use 'current_class' as
6562 parent of newly-created struct. Remove call to Register ().
6563 Use 'pop_current_class' to complete handing the current struct.
6564 (interface_declaration): Likewise.
6565 (class_declaration): Likewise.
6566 (enum_declaration): Use 'current_class' as parent of newly created
6568 (delegate_declaration): Likewise.
6569 (pop_current_class): New function. This is used to handle closing
6570 up the 'current_class' and 'current_container', and pointing them
6571 to the enclosing class/container.
6572 (CSharpParser): Initialize 'current_class' too.
6573 * decl.cs (MemberCore): Add check for invariant: a partial
6574 container is not a parsed entity, and thus does not enclose any
6576 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6577 (DeclSpace.BaseTypeExpr): Use it.
6578 (DeclSpace.LookupType): Add check for invariant.
6579 * class.cs (TypeContainer): Add check for invariant: a nested
6580 class should have the same NamespaceEntry as its enclosing class.
6581 (TypeContainer.EmitFieldInitializers): Make virtual.
6582 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6584 (TypeContainer.Register): Remove.
6585 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6586 null. Use TypeResolveEmitContext for resolving base types and
6587 interfaces. Move initialization of Parts.TypeBuilder here from
6589 (TypeContainer.DefineNestedTypes): ... here.
6590 (PartialContainer): Take a Namespace not a NamespaceEntry.
6591 (PartialContainer.Create): Don't use Register. Call the
6592 appropriate Add... function directly.
6593 (ClassPart): Take both the PartialContainer and the enclosing
6594 class as constructor arguments.
6595 (ClassPart.EmitFieldInitializers): Override.
6596 (ClassPart.PartFindNestedTypes): Remove.
6597 (FieldBase.GetInitializerExpression): Resolve the initializer
6598 expression in the emit context of the enclosing class.
6599 * tree.cs (RootTypes): Remove Register ().
6601 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6603 * cs-parser.jay: Removed CS0134.
6605 * driver.cs: Removed CS1901.
6607 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6608 for predefined types.
6610 2005-03-07 Duncan Mak <duncan@novell.com>
6612 * codegen.cs (Save): Catch UnauthorizedAccessException as
6613 well. Fixes bug #73454.
6615 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6617 * cs-tokenizer.cs (xtoken): Add CS1035.
6619 * class.cs (MethodData.Define): Add CS0683.
6620 (FieldMember.ctor): Add CS0681.
6622 2005-03-07 Raja R Harinath <rharinath@novell.com>
6624 * ecore.cs (SimpleName.DoResolve): Rename from
6625 SimpleName.DoResolveAllowStatic.
6626 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6627 Pass 'intermediate' flag to MemberStaticCheck.
6628 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6629 of "intermediate" lookups via MemberAccess.
6630 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6631 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6633 2005-03-07 Raja R Harinath <rharinath@novell.com>
6636 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6637 slipped in because of variable names that are identical to a
6638 builtin type's BCL equivalent ('string String;', 'int Int32;').
6639 (PropertyExpr.EmitInstance): Likewise.
6641 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6643 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6645 * report.cs (warning_ignore_table): Made public.
6647 2005-03-04 Raja R Harinath <rharinath@novell.com>
6650 * class.cs (MethodData.Emit): Pass 'container' to
6651 container.GetObsoleteAttribute instead of 'container.Parent'.
6653 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6655 * cs-parser.jay: Add 1534 error test.
6657 * iterators.cs (Yield.CheckContext): Add error 1629.
6658 (Iterator.ctor): Save unsafe modifier.
6659 (MoveNextMethod.DoEmit): Restore unsafe context.
6661 * namespace.cs (UsingAlias): Better error message.
6663 2005-03-03 Dan Winship <danw@novell.com>
6665 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6666 the warning message [#73219]
6668 2005-03-03 Raja R Harinath <rharinath@novell.com>
6670 Fix compile with MCS 1.0.0.0.
6671 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6672 w_restore to not depend on string constant folding.
6674 2005-03-03 Raja R Harinath <rharinath@novell.com>
6676 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6677 CS0246 check to users who passed 'silent = false'.
6678 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6680 (SimpleName.SimpleNameResolve): Update.
6681 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6682 (MemberAccess.IdenticalNameAndTypeName): Update.
6683 * doc.cs (FindDocumentedTypeNonArray): Update.
6685 2005-03-03 Raja R Harinath <rharinath@novell.com>
6687 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6688 * parameters.cs (ComputeAndDefineParameters): Remove.
6689 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6690 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6691 Use GetParameterInfo.
6693 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6695 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6697 2005-03-02 Raja R Harinath <rharinath@novell.com>
6699 Unify DeclSpace.LookupType and DeclSpace.FindType.
6700 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6701 is in charge of defining nested types on demand.
6702 (DeclSpace.LookupType): Use it when the current_type is a
6703 TypeBuilder. Use LookupTypeDirect for reflected types.
6704 (DeclSpace.FindType): Remove.
6705 (DeclSpace.LookupInterfaceOrClass): Likewise.
6706 (DeclSpace.DefineTypeAndParents): Likewise.
6707 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6708 DeclSpace.LookupType.
6709 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6710 * typemanager.cs (LookupType): Simplify.
6711 (AddUserType): Remove type from negative_hits.
6712 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6713 * class.cs (TypeContainer.FindMembers): Move handling of nested
6715 (TypeContainer.FindMembers_NestedTypes): ... here.
6716 (TypeContainer.FindNestedType): Implement override.
6717 (ClassPart.FindNestedType): Delegate to PartialContainer.
6718 (ClassPart.PartFindNestedType): Looks up the nested types of the
6721 2005-04-14 Martin Baulig <martin@ximian.com>
6723 * generic.cs (ConstructedType): Moved all the type lookup and
6724 nested class logic into SimpleName.
6725 (ConstructedType.ResolveConstructedType): Our underlying type is
6726 already fully resolved; all the type lookup stuff is in
6729 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6730 constructed types here instead of in ConstructedType.
6732 * decl.cs (MemberName.GetTypeExpression): Always create a
6733 SimpleName, not a ConstructedType.
6734 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6736 2005-03-02 Martin Baulig <martin@ximian.com>
6738 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6739 static constructor in static classes.
6741 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6743 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6744 sizeParamIndex is not specified.
6746 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6749 * report.cs (WarningMessage.IsEnabled): Missing null check.
6751 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6753 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6754 in the fields and not in the properties.
6756 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6758 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6761 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6763 * attribute.cs: Small refactoring (improved robustness).
6764 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6765 (ValidateGuid): Removed.
6766 (Resolve): Removed referenced to above mentioned.
6767 (GetAttributeUsage): Made private and changed to work without
6769 (GetIndexerAttributeValue): Don't crash.
6770 (GetConditionalAttributeValue): Ditto.
6771 (GetClsCompliantAttributeValue): Ditto.
6772 (ExtractSecurityPermissionSet): All attributes exceptions are
6774 (GetPropertyValue): New helper.
6775 (GetMethodImplOptions): New method.
6776 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6777 some missing properties.
6779 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6780 (Method.ApplyAttributeBuilder): Updated.
6782 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6785 2005-02-28 Raja R Harinath <rharinath@novell.com>
6788 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6789 non-simple types (array, pointer, reference).
6791 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6793 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6795 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6797 (Method.CheckBase): Catch wrong destructor here.
6798 (MethodData.Define): Add errors 550, 668.
6800 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6802 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6804 * pending.cs (VerifyPendingMethods): Add error 551.
6806 * typemanager.cs (CSharpName): Next error report helper.
6808 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6810 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6811 attributes. Removed useless attribute double check.
6812 It saves almost 2MBs for corlib.
6814 2005-02-25 Raja R Harinath <rharinath@novell.com>
6817 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6818 called twice in case of error.
6820 2005-02-23 Chris Toshok <toshok@ximian.com>
6822 Fix compiler portions of #72827.
6823 * statement.cs (Block.Emit): call Begin/EndScope on the
6824 EmitContext instead of the ILGenerator.
6826 * codegen.cs (EmitContext.BeginScope): new method, call
6827 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6829 (EmitContext.BeginScope): same, but EndScope and CloseScope
6831 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6832 offset and call the superclass's OpenScope(int) with it.
6833 (SymbolWriter.CloseScope): get the current il
6834 offset and call superclass's CloseScope(int) with it.
6836 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6838 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6839 CS1677 for out and ref as well.
6841 * class.cs (Method.Define): Add error CS1599 detection.
6843 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6845 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6847 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6849 * support.cs.cs (ModifierDesc): New helper method.
6851 2005-02-23 Raja R Harinath <rharinath@novell.com>
6852 Abin Thomas <projectmonokochi@rediffmail.com>
6853 Anoob V E <projectmonokochi@rediffmail.com>
6854 Harilal P R <projectmonokochi@rediffmail.com>
6857 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6858 MemberLookup (used for error reporting) actually returns a result.
6859 Fix error report number (122, not 112).
6861 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6862 Anoob V E <projectmonokochi@rediffmail.com>
6863 Harilal P R <projectmonokochi@rediffmail.com>
6866 * pending.cs (PendingImplementation.GetAbstractMethods):
6867 Find NonPublic members too.
6869 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6871 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6874 * class.cs (MethodCore.CheckMethodAgainstBase):
6875 Add error 239 report.
6877 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6879 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6881 * class.cs (Operator.Define): Add error 217 report.
6883 2005-02-21 Raja R Harinath <rharinath@novell.com>
6886 * expression.cs (Invocation.IsApplicable): Make public.
6887 (Invocation.IsParamsMethodApplicable): Likewise.
6888 * delegate.cs (Delegate.VerifyApplicability): Don't use
6889 Invocation.VerifyArgumentCompat for parameter applicability
6890 testing. Use Invocation.IsApplicable and
6891 Invocation.IsParamsMethodApplicable.
6893 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6895 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6897 * class.cs (Operator.Define): Add error 217 report.
6899 2005-02-21 Raja R Harinath <rharinath@novell.com>
6901 * namespace.cs (UsingEntry.Resolve): Undo change below.
6903 2005-02-21 Raja R Harinath <rharinath@novell.com>
6906 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6907 disable the error message when the extended MemberLookup also
6909 (Expression.MemberLookupFinal): Update.
6910 (SimpleName.DoSimpleNameResolve): Update.
6911 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6912 Don't use MemberLookupFinal.
6913 (New.DoResolve): Update.
6914 (BaseAccess.CommonResolve): Update.
6916 2005-02-21 Raja R Harinath <rharinath@novell.com>
6919 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6920 occured previously, don't resolve again.
6922 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6925 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6926 argument. Call ResolveAttributeUsage for unresolved.
6927 when types doesn't match ctor arguments.
6929 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6930 for nested attribute classes.
6931 (Class.attribute_usage): Removed.
6932 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6933 for attribute class.
6935 * ecore.cs (IsAttribute): Removed.
6937 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6939 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6941 (attribute_types): Removed.
6942 (EmitCode): Global attributes are emited as the latest.
6944 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6946 * class.cs (EmitFieldInitializers): Don't emit field initializer
6947 for default values when optimilization is on.
6949 * constant.cs (Constant.IsDefaultValue): New property.
6951 * driver.cs: Add /optimize handling.
6955 * literal.cs: Implement new IsDefaultValue property.
6957 * rootcontext.cs (Optimize): New field, holds /optimize option.
6959 2005-02-18 Raja R Harinath <rharinath@novell.com>
6961 Fix crasher in re-opened #72347.
6962 * namespace.cs (Namespace.Lookup): Return null if
6963 DeclSpace.DefineType returns null.
6966 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6968 2005-02-18 Raja R Harinath <rharinath@novell.com>
6970 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6971 now returns null if it cannot resolve to an lvalue.
6972 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6973 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6974 returned null. Remove check for SimpleName.
6975 (EventExpr.DoResolveLValue): New.
6976 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6977 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6979 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6981 (Unary.ResolveOperator): Move CS0211 check ...
6982 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6984 (Unary.DoResolveLValue): Simplify.
6985 (AddressOf.DoResolveLValue): New.
6986 (ArrayAccess.DoResolveLValue): New.
6988 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6990 * attribute.cs (Attribute.Resolve): Add arguments casting for
6991 when types doesn't match ctor arguments.
6993 2005-02-16 Raja R Harinath <rharinath@novell.com>
6995 Fix parts of #63202.
6996 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6997 lookup of operator in base type. Ensure that all checks happen
6998 when the operator resolves to an "op_..." method.
7000 2005-02-15 Raja R Harinath <rharinath@novell.com>
7003 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
7004 'ignore_cs0104' parameter. Pass it to ...
7005 (NamespaceEntry.Lookup): ... this.
7006 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
7007 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
7008 (TypeLookupExpression.DoResolveAsTypeStep): Update.
7009 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
7010 Update. Request that cs0104 errors be ignored.
7011 (ComposedCast.ResolveAsTypeStep): Update.
7013 2005-02-14 Raja R Harinath <rharinath@novell.com>
7016 * expression.cs (Invocation.BetterFunction): Remove support for
7017 comparing virtual functions and their overrides.
7018 (Invocation.IsOverride): New.
7019 (Invocation.OverloadResolve): Don't consider 'override' functions
7020 during candidate selection. Store them in a lookaside list.
7021 If the selected method is a 'virtual' function, use the list to
7022 find any overrides that are closer to the LHS type.
7024 2005-02-14 Marek Safar <marek.safar@seznam.cz>
7026 * expression.cs (New.DoResolve): Add complex core type reduction.
7027 (New.Constantify): Converts complex core type syntax like 'new int ()'
7030 2005-02-14 Raja R Harinath <rharinath@novell.com>
7032 * decl.cs (EntryType.EntryType): New constructor to create an
7033 updated copy of a cache entry.
7034 (MemberCache.AddMethods): Use it.
7035 (MemberCache.ClearDeclaredOnly): Remove.
7036 (MemberCache.MemberCache): Update.
7038 2005-02-11 Miguel de Icaza <miguel@novell.com>
7040 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
7041 variable. This one is represents the actual low-level declaration
7042 of the method, as opposed to the semantic level `IsStatic'.
7044 An anonymous method which is hosted into a static method might be
7045 actually an instance method. IsStatic would reflect the
7046 container, while MethodIsStatic represents the actual code
7049 * expression.cs (ParameterReference): Use the new MethodIsStatic
7050 instead of IsStatic.
7052 * anonymous.cs (AnonymousMethod.Compatible): Pass the
7053 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
7054 set on the current EmitContext.
7056 * expression.cs (Cast): Overload DoResolveLValue so we can pass
7057 resolve our casted expression as an LValue. This triggers the
7058 proper LValue processing that is later required by Assign.
7062 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
7064 2005-02-11 Marek Safar <marek.safar@seznam.cz>
7066 C# 2.0 Fixed buffer implementation
7068 * anonymous.cs: Update after RegisterHelperClass renaming.
7070 * attribute.cs (AttributeTester.fixed_buffer_cache):
7071 Cache of external fixed buffers.
7072 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
7073 implementation if field is fixed buffer else null.
7076 (TypeContainer.AddField): Accept FieldMember instead of Field.
7077 (FieldBase.IsFieldClsCompliant): Extracted code from
7078 VerifyClsCompliance descendant customization.
7079 (FixedField): New class handles fixed buffer fields.
7080 (FixedFieldExternal): Keeps information about imported fixed
7082 (IFixedField): Make access to internal or external fixed buffer
7085 * cs-parser.jay: Add fixed buffer parsing.
7087 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
7090 * expression.cs (Indirection): Extended implementation to accept
7092 (PointerArithmetic.Emit): Get element from fixed buffer as well.
7093 (ElementAccess.MakePointerAccess): Get type as parameter.
7094 (DoResolve): Add fixed buffer field expression conversion.
7095 (DoResolveLValue): Ditto.
7096 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
7097 (ArrayPtr): Derives from FixedBufferPtr.
7098 (ArrayPtr.Emit): Add extra emit for array elements.
7100 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
7102 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
7103 for compiler generated types.
7104 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
7106 * statement.cs (Fixed): Refactored to be easier add fixed buffer
7107 and consume less memory.
7108 (Fixed.Resolve): Add fixed buffer case.
7110 * typemanager.cs (compiler_generated_attr_ctor,
7111 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
7112 (HasElementType): Add our own implementation to work on every
7115 2005-02-11 Miguel de Icaza <miguel@novell.com>
7117 * anonymous.cs (CaptureContext): Track whether `this' has been
7120 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
7121 only captured `this' if it was implicitly done (instance
7122 methods/variables were used).
7124 * codegen.cs (EmitContext.CaptureThis): New method to flag that
7125 `this' must be captured.
7127 2005-01-30 Miguel de Icaza <miguel@novell.com>
7129 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
7130 is null it means that there has been no need to capture anything,
7131 so we just create a sibling.
7133 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
7135 Just a partial fix. The other half is fairly elusive.
7137 2005-02-10 Raja R Harinath <rharinath@novell.com>
7139 Fix #52586, cs0121-4.cs.
7140 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
7141 and return a hashtable.
7142 (MemberCache.ClearDeclaredOnly): New.
7143 (MemberCache.MemberCache): Update to change. Make a deep copy of
7144 the method_hash of a base type too.
7145 (MemberCache.AddMethods): Adapt to having a deep copy of the base
7146 type methods. Overwrite entries with the same MethodHandle so
7147 that the ReflectedType is correct. The process leaves in base
7148 virtual functions and their overrides as distinct entries.
7149 (CacheEntry): Now a class instead of a struct. It shouldn't alter
7150 matters since it was boxed in a ArrayList before.
7151 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
7153 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
7154 case of a virtual function and its override (choose the overload
7156 (Invocation.OverloadResolve): Avoid 'override' members during
7157 'applicable_type' calculation.
7159 2005-03-28 Raja R Harinath <rharinath@novell.com>
7161 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
7162 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
7163 GetTypeHandle. It is possible for a reflected type to derive from
7164 a TypeBuilder (e.g., int[] derives from the TypeBuilder
7165 System.Array during mscorlib compilation).
7166 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
7167 contain a method_hash, don't create one either. Don't create a
7168 deep copy of the base cache's method_hash.
7169 (MemberCache.SetupCache): Rename back from DeepCopy.
7170 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
7171 already initialized. If we see an override function, add its
7172 underlying base virtual function to the member_hash too.
7174 2005-02-09 Raja R Harinath <rharinath@novell.com>
7176 Combine two near-redundant caches.
7177 * typemanager.cs (method_params): Rename from method_internal_params.
7178 (TypeManager.GetParameterData): New. Replace
7179 Invocation.GetParameterData.
7180 (TypeManager.LookupParametersByBuilder): Remove.
7181 * expression.cs (Invocation.method_parameter_cache): Remove.
7182 (Invocation.GetParameterData): Remove.
7184 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
7187 2005-02-08 Raja R Harinath <rharinath@novell.com>
7190 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
7191 TypeManager.multicast_delegate_type is null, resolve it by looking
7192 up "System.MulticastDelegate".
7193 * rootcontext.cs (RootContext.ResolveCore): Simplify.
7195 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
7196 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
7197 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
7200 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
7201 (LabeledStatement.AddReference): New. Set 'referenced'.
7202 (Goto.Resolve): Use it.
7204 2005-02-05 John Luke <john.luke@gmail.com>
7206 * driver.cs: remove duplicate -doc line in Usage ()
7208 2005-02-04 Raja R Harinath <rharinath@novell.com>
7210 * location.cs (Location.AddFile): Fix CS2002 error report.
7212 2005-02-02 Martin Baulig <martin@ximian.com>
7214 * delegate.cs (Delegate.DefineType): Report an internal error if
7215 TypeManager.multicast_delegate_type is null. See bug #72015 for
7218 2005-02-02 Raja R Harinath <rharinath@novell.com>
7220 Fix a crasher in a variant of #31984.
7221 * const.cs (Constant.CheckBase): New override that defers the
7222 new-or-override check in case the base type hasn't been populated
7224 (Constant.Define): Ensure the new-or-override check is performed.
7226 2005-02-01 Duncan Mak <duncan@ximian.com>
7228 * const.cs (LookupConstantValue): Check that `ce' is not null
7229 before calling GetValue ().
7231 2005-02-01 Raja R Harinath <rharinath@novell.com>
7233 Fix test-334.cs (#69519).
7234 * cs-parser.jay (using_alias_directive): Pass in an expression to
7235 NamespaceEntry.UsingAlias.
7236 (using_namespace_directive): Pass in an expression to
7237 NamespaceEntry.Using.
7238 (namespace_name): Don't flatten to a string.
7239 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
7240 (NamespaceEntry.AliasEntry.Resolve): Lookup using
7242 (NamespaceEntry.UsingEntry): Likewise.
7243 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
7245 (NamespaceEntry.LookupForUsing): Remove.
7246 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
7248 (NamespaceEntry.Lookup): Remove support for dotted names.
7250 2005-02-01 Raja R Harinath <rharinath@novell.com>
7252 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
7254 (NamespaceEntry.ImplicitParent): Compute on demand.
7255 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
7256 parallels the current.
7257 (NamespaceEntry.LookupForUsing): Use it.
7258 (NamespaceEntry.Lookup): If the current namespace-entry is
7259 implicit, don't search aliases and using tables.
7261 2005-02-01 Raja R Harinath <rharinath@novell.com>
7264 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
7266 (TypeContainer.BaseCache): Compute on demand.
7267 (TypeContainer.FindMembers): Define constants and types if they're
7268 not already created.
7269 (FieldMember.Define): Move resetting of ec.InUnsafe before error
7271 * const.cs (Constant.Define): Make idempotent.
7273 2005-01-29 Miguel de Icaza <miguel@novell.com>
7275 * pending.cs: Produce better code (no nops produced by using Ldarg
7278 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7279 i - 1' it should be arg + 1.
7283 2005-01-28 Raja R Harinath <rharinath@novell.com>
7285 * attribute.cs (Attribute.CheckAttributeType): Make private
7287 (Attribute.ResolveType): Make virtual.
7288 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
7289 handling of RootContext.Tree.Types.
7291 2005-01-27 Raja R Harinath <rharinath@novell.com>
7293 Update attribute-handling to use the SimpleName/MemberAccess
7295 * cs-parser.jay (attribute): Pass in an expression to the
7296 constructors of Attribute and GlobalAttribute.
7297 * attribute.cs (Attribute): Take an expression for the name.
7298 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
7299 passed in attribute name expression.
7300 (Attribute.CheckAttributeType): Use it.
7301 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
7302 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
7303 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
7304 argument to prevent error messages if the lookup fails.
7306 2005-01-27 Marek Safar <marek.safar@seznam.cz>
7308 * expression.cs (Indirection): Implemented IVariable interface
7309 to support indirection in AddressOf operator.
7310 (PointerArithmetic.Emit): Add optimalization for case where
7311 result can be precomputed.
7313 2005-01-26 Martin Baulig <martin@ximian.com>
7315 * class.cs (TypeContainer.AttributeTargets): Return the correct
7316 AttributeTargets depending on our `Kind' instead of throwing an
7317 exception; fixes #71632.
7319 2005-01-26 Marek Safar <marek.safar@seznam.cz>
7322 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
7325 2005-03-17 Martin Baulig <martin@ximian.com>
7327 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
7328 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
7330 2005-03-17 Martin Baulig <martin@ximian.com>
7332 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
7333 to bool so we can return an error condition.
7334 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
7337 2005-03-17 Martin Baulig <martin@ximian.com>
7339 * generic.cs (TypeMananager.IsIEnumerable): New public method.
7341 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
7342 converting from an array-type of T to `IEnumerable<T>'.
7344 2005-03-16 Martin Baulig <martin@ximian.com>
7346 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
7347 (Nullable.LiftedUnaryMutator): New public class.
7349 * expression.cs (UnaryMutator.DoResolve): Added support for
7352 2005-03-14 Martin Baulig <martin@ximian.com>
7354 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
7356 2005-03-14 Martin Baulig <martin@ximian.com>
7358 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
7359 the comparision operators `<', `>', `<=' and `>='.
7361 2005-03-13 Martin Baulig <martin@ximian.com>
7364 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
7365 avoid confusion with the `NullLiteral'.
7366 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
7368 2005-03-13 Martin Baulig <martin@ximian.com>
7370 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
7371 comparing arbitrary types with the null literal.
7373 2005-03-13 Martin Baulig <martin@ximian.com>
7375 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
7376 boolean operators '&&', '||', '&' and '|'.
7377 (Nullable.OperatorTrueOrFalse): New public class.
7379 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
7380 instead of a `StaticCallExpr'; added support for nullables.
7382 2005-03-10 Martin Baulig <martin@ximian.com>
7385 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
7386 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
7388 2005-03-07 Martin Baulig <martin@ximian.com>
7390 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
7391 it work if `expr' is not an IMemoryLocation.
7392 (Nullable.Lifted): Implement IMemoryLocation.
7393 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
7396 2005-03-05 Martin Baulig <martin@ximian.com>
7398 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
7399 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
7400 (Nullable): Added support for lifted unary and binary operators.
7402 * expression.cs (Unary.DoResolve): Added support for nullable types.
7403 (Binary.DoResolve): Likewise.
7404 (Conditional.DoResolve): Likewise.
7406 2005-03-02 Martin Baulig <martin@ximian.com>
7408 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
7410 * class.cs (ClassPart.SetParameterInfo): Override this.
7411 (PartialContainer.SetParameterInfo): Override this.
7412 (TypeContainer.CheckConstraints): New protected method.
7413 (PartialContainer.CheckConstraints): Override this and check
7414 whether the same contraints were specified in all parts of a
7415 partial generic type definition.
7416 (PartialContainer.UpdateConstraints): New public method.
7418 * generic.cs (TypeParameter.UpdateConstraints): New public method.
7420 2005-03-02 Martin Baulig <martin@ximian.com>
7422 Committing a patch from Carlos Alberto Cortez to fix #72887.
7424 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
7425 casts from `T []' to `int []'.
7427 2005-03-02 Martin Baulig <martin@ximian.com>
7429 * generic.cs (TypeManager.IsEqual): Make this symmetric.
7431 * expression.cs (Binary.ResolveOperator): When resolving a
7432 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
7433 `=='. Fixes #71866. See gen-127.cs.
7435 2005-03-02 Martin Baulig <martin@ximian.com>
7437 * class.cs (TypeContainer.DoDefineMembers): We also need a default
7438 static constructor in static classes.
7440 2005-03-02 Martin Baulig <martin@ximian.com>
7443 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
7444 (Nullable.LiftedConversion): Added support for user-defined
7447 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
7449 * cs-parser.jay: Use ComposedCast everywhere instead of
7450 NullableType, so we don't need to check for NullableType
7452 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
7453 case where we'll be resolved into a `parenthesized_expression_0'
7457 (Convert.UserDefinedConversion): Added nullable conversions.
7459 2005-02-28 Martin Baulig <martin@ximian.com>
7461 * generic.cs (TypeManager.IsNullableType): New static method.
7462 (Nullable): New abstract class.
7463 (Nullable.NullLiteral): New public class.
7464 (Nullable.LiftedConversion): New public class.
7466 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7467 `builtin_types opt_nullable'.
7470 (Convert.ImplicitConversionStandard): Added nullable conversions.
7471 (Convert.ExplicitConversionStandard): Likewise.
7472 (Convert.ExplicitConversion): Likewise.
7474 2005-02-26 Martin Baulig <martin@ximian.com>
7476 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7477 begin with a "?", for instance "?[]". Don't do a type lookup if
7480 2005-02-25 Martin Baulig <martin@ximian.com>
7482 The first part of Nullable Types :-)
7484 * generic.cs (NullableType): New public class.
7485 (NullCoalescingOperator): New public class.
7486 (TypeArguments.Resolve): Add a CS0306 check.
7488 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7489 (opt_nullable): New rule.
7490 (type): Added `opt_nullable' to `namespace_or_type_name',
7491 `builtin_types' and `pointer_type'.
7492 (array_type): Added `opt_nullable'.
7493 (opt_rank_specifier_or_nullable): New rule; this is the
7494 combination of `opt_rank_specifier' and `opt_nullable'.
7495 (opt_error): New rule; catch errors here.
7496 (nullable_type_or_conditional): New rule; we use this to check for
7497 nullable and still detect the conditional operator.
7498 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7499 instead `opt_rank_specifier'.
7501 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7504 2005-02-24 Martin Baulig <martin@ximian.com>
7506 * README, README.Changes: Removed; they're old and obsolete.
7508 2005-02-22 Martin Baulig <martin@ximian.com>
7510 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7511 returned an error, set `constraints' to null to avoid a crash
7513 (TypeParameter.ResolveType): Likewise.
7515 2005-02-22 Martin Baulig <martin@ximian.com>
7518 (Constraints.ResolveTypes): Protect against being called twice.
7519 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7520 (TypeParameter.ResolveType): New public method; calls
7521 constraints.ResolveTypes().
7522 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7523 into the new ResolveType().
7524 (GenericMethod.Define): Call ResolveType() on all our
7527 2005-02-21 Martin Baulig <martin@ximian.com>
7530 (TypeManager.generic_nullable_type): New static public field.
7531 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7534 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7536 2005-02-15 Martin Baulig <martin@ximian.com>
7538 * generic.cs (ConstructedType.Constraints): Correctly check
7539 constraints if the argument type is a type parameter; fixes
7542 2005-02-02 Martin Baulig <martin@ximian.com>
7544 * delegate.cs (Delegate.DefineType): Report an internal error if
7545 TypeManager.multicast_delegate_type is null. See bug #72015 for
7548 2005-01-29 Miguel de Icaza <miguel@novell.com>
7550 * pending.cs: Produce better code (no nops produced by using Ldarg
7553 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7554 i - 1' it should be arg + 1.
7558 2005-01-26 Martin Baulig <martin@ximian.com>
7560 * cs-parser.jay (indexer_declarator): Don't report an error if we
7561 have type parameters since we can be an explicit interface
7562 implementation; fixes #71449.
7564 2005-01-26 Martin Baulig <martin@ximian.com>
7566 * class.cs (TypeContainer.AttributeTargets): Return the correct
7567 AttributeTargets depending on our `Kind' instead of throwing an
7568 exception; fixes #71632.
7570 2005-01-26 Martin Baulig <martin@ximian.com>
7572 * delegate.cs (Delegate.DefineType): Correctly define our type
7573 parameters. Fixes #71483.
7575 2005-01-25 Raja R Harinath <rharinath@novell.com>
7578 * expression.cs (MemberAccess.DoResolve): Don't complain with
7579 cs0572 when the LHS of a member access has identical name and type
7582 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7585 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7587 Create custom PermissionSet only for PermissionSetAttribute.
7589 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7592 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7593 delegates in static class.
7595 2005-01-24 Martin Baulig <martin@ximian.com>
7597 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7598 merging an implicit block, just use its reachability.
7600 * statement.cs (Block.Resolve): Make the unreachable code check
7601 work wrt. implicit blocks; see test-337 from #63842.
7603 2005-01-21 Alp Toker <alp@atoker.com>
7605 * cs-parser.jay: destructor_declaration's container is PartialContainer
7606 not Class when partial types are used, so use Kind prop instead of
7609 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7611 * cs-parser.jay: Improve error reporting when an interface
7614 2005-01-20 Dick Porter <dick@ximian.com>
7616 * support.cs: SeekableStreamReader fix from Sandor Dobos
7617 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7618 chars are read. Fixes bug 70369.
7620 2005-01-20 Raja R Harinath <rharinath@novell.com>
7622 * cs-parser.jay (catch_clause): Simplify current_block handling
7625 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7627 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7628 code with ImplicitStandardConversion to handle the implicit
7629 conversion of method groups into valid delegate invocations.
7631 The problem is that in parameter handling we were using this code
7632 path. Fixes bug #64698
7634 2005-01-19 Raja R Harinath <rharinath@novell.com>
7636 * cs-parser.jay: Fix several infelicities.
7637 - Avoid assigning to the parser value stack. Code like
7638 '$3 = null' is unclean. Synthesize a value for the code block
7640 - Avoid using oob_stack for storing location information. Use ...
7641 (_mark_): ... this. New (empty) rule. Saves the current location
7643 (foreach_statement): Avoid using oob_stack for current_block
7644 handling. Use technique used in for_statement and
7645 using_statement. Synthesize a value for the code block to store
7646 additional intermediate information.
7648 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7650 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7651 of a different type is only allowed to private fields of a
7652 containing type, not on fields of a base class.
7654 See test-174.cs and error cs0122-9.cs
7656 2005-01-13 Raja R Harinath <rharinath@novell.com>
7658 Fix test-335.cs (bug #58126).
7659 * cs-parser.jay (argument): Split out non-expression parts of the
7660 rule into 'non_simple_argument'.
7661 (invocation_expression): Support parenthesized invocations with
7662 multiple arguments, and with single non-simple arguments.
7664 2005-01-13 Raja R Harinath <rharinath@novell.com>
7666 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7669 2005-01-12 Raja R Harinath <rharinath@novell.com>
7671 Fix cs0038-1.cs, cs1640-6.cs.
7672 * ecore.cs (Expression.Resolve): Remove special-case for
7673 SimpleName in error-handling.
7674 (Expression.almostMatchedMembers): Relax access permission to
7676 (Expression.MemberLookupFailed): Handle duplicates in
7677 almostMatchedMembers list.
7678 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7679 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7680 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7681 overload if the passed in MemberInfo is a MethodBase.
7683 2005-01-25 Martin Baulig <martin@ximian.com>
7686 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7688 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7691 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7692 for non-CAS & merge permission sets properly.
7694 2005-01-11 Raja R Harinath <rharinath@novell.com>
7696 Improve standard-compliance of simple name and member access
7697 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7698 * ecore.cs (FullNamedExpression): New abstract base class
7699 for Namespaces and TypeExpressions.
7700 (ResolveFlags.SimpleName): Remove.
7701 (SimpleName): Remove support for dotted names.
7702 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7703 DeclSpace.FindType and DeclSpace.LookupType.
7704 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7705 (Expression.ExprClassName): Make member function.
7706 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7707 a namespace. Remove creation of dotted "SimpleName"s.
7708 (MemberAccess.DoResolve): Likewise.
7709 * decl.cs (DeclSpace.Cache): Make private.
7710 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7711 (DeclSpace.FindType): Update.
7712 (DeclSpace.LookupType): Move here from RootContext. Return a
7713 FullNamedExpression.
7714 * namespace.cs (Namespace): Derive from FullNamedExpression
7715 so that it can be part of expression resolution.
7716 (Namespace.Lookup): Return an FullNamedExpression.
7717 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7719 * rootcontext.cs (NamespaceLookup): Remove.
7720 (LookupType): Move to DeclSpace.
7721 * attribute.cs (CheckAttributeType): Update.
7722 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7723 (FindDocumentedTypeNonArray): Likewise.
7725 2005-01-11 Raja R Harinath <rharinath@novell.com>
7727 Fix cs0509.cs, cs1632.cs.
7728 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7729 is the same as IsInterface.
7730 (TypeContainer.GetClassBases): Likewise.
7731 * statement.cs (LabeledStatement.ig): New field.
7732 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7734 (LabeledStatement.DoEmit): Check that the label was created with
7735 the same ILGenerator.
7737 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7740 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7741 accessors to its properties.
7743 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7744 from accessors to property.
7746 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7749 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7752 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7754 * attribute.cs: Check for null and empty strings.
7756 I have lost another battle to Paolo.
7758 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7761 * class.cs (PropertyMethod): Set Parent field in ctors.
7762 (SetMethod.InternalParameters): Add unsafe switch hack.
7763 Override MarkForDuplicationCheck where it is appropriate.
7765 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7766 It says whether container allows members with the same name.
7768 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7769 Removed is_method parameter.
7771 2005-01-06 Duncan Mak <duncan@ximian.com>
7773 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7774 because the previous change led to incorrect reporting of CS1032
7775 ("Cannot define/undefine preprocessor symbols after first token in
7776 file"). Instead of using `tokens_seen' as the only flag that
7777 triggers CS1040, introduce `comments_seen'. This new flag is used
7778 to signify having seen comments on the current line, so it is
7779 unset after a newline.
7781 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7783 * doc.cs : When searching for a type, find nested type too.
7784 This fixes bug #71040.
7786 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7789 - Warn missing member comment on those classes which also does not
7790 have doc comments. Fixed bug #71041.
7791 - Don't warn missing doc comment on default constructor.
7794 2005-01-06 Duncan Mak <duncan@ximian.com>
7796 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7797 comments, set `tokens_seen' to true. This allows us to detect
7798 misplaced preprocessor directives (i.e. not at the beginning of
7799 the a line, nor after whitespaces). In that case, report error
7800 CS1040. This fixes bug #56460.
7802 * cs-parser.jay (interface_member_declaration): Add checks for
7803 IsExplicitImpl, and report CS0541 error if an interface member is
7804 defined as an explicit interface declaration.
7806 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7809 * class.cs (PropertyMethod): Set Parent field in ctors.
7810 (SetMethod.InternalParameters): Add unsafe switch hack.
7812 * decl.cs (MemberCore.Parent): Cannot be readonly.
7814 2005-01-06 Raja R Harinath <rharinath@novell.com>
7816 * decl.cs (DeclSpace.ResolveType): Remove.
7817 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7818 Merge in code from ...
7819 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7820 * class.cs, enum.cs: Update to changes.
7822 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7824 * anonymous.cs: Ensure that we init the scope of our parent if it
7825 has not been initialized yet.
7827 2004-12-30 Duncan Mak <duncan@ximian.com>
7829 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7830 if field.FieldBuilder is null. Fixes #70758.
7832 * convert.cs: Fixed some typos and updated some of the comments.
7833 (ImplicitStandardConversionExists):
7834 (TryImplicitIntConversion): If `target_type' is an interface and
7835 the type of `ic' implements this interface, return true or a new
7836 BoxedCast instead of null. This fixes #70468.
7838 2004-12-29 Duncan Mak <duncan@ximian.com>
7840 * expression.cs (Argument.Emit): Check that Expr is
7841 IMemoryLocation before casting to it, and report CS1510 otherwise.
7845 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7847 * statement.cs (Block.ThisVariable): remove the recursion here, to
7848 make the --profile more sane.
7850 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7852 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7853 assembly, by JB Evain.
7855 2004-12-17 Raja R Harinath <rharinath@novell.com>
7857 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7858 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7859 "parent" refers to enclosing type/class. "base" refers to superclass.
7861 2004-12-17 Raja R Harinath <rharinath@novell.com>
7863 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7864 Ensure that we only have GlobalAttributes.
7865 * attribute.cs (Attribute.Emit): Make non-virtual.
7866 (GlobalAttribute.Emit): Remove.
7867 (Attribute.Resolve): Make virtual.
7868 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7869 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7870 the argument. Don't create one.
7871 (Attribute.GetObsoleteAttribute): Likewise.
7872 (Attribute.GetClsCompliantAttributeValue): Likewise.
7873 * class.cs, decl.cs: Update to changes.
7875 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7877 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7879 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7881 * statement.cs (Foreach.Resolve): Add error 186 report.
7883 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7885 * expression.cs (Conditional.DoResolve): Add warning 429.
7887 * statement.cs (If.Resolve): Add warning 665.
7889 2004-12-16 Raja R Harinath <rharinath@novell.com>
7891 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7892 except when in the parser, and in GlobalAttribute.
7893 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7894 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7895 RootContext.Tree.Types.NamespaceEntry once work is done.
7896 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7897 and resets RootContext.Tree.Types.NamespaceEntry.
7899 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7901 * cs-parser.jay: Don't create a block for every variable.
7903 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7905 * location.cs: Provide extra information.
7907 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7908 variables from the captured environment, it is the ldarg_0.
7910 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7912 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7915 * class.cs: Changed warning level for 169 to avoid developer
7916 displeasure from warning flooding. It will be changed back when they
7917 fix most of current BCL warnings.
7919 * RootContext.cs: Pushed default WarningLevel to 3.
7921 * statement.cs: Removed unused variable.
7923 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7925 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7926 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7927 Add error 502 report.
7928 (StaticClass.DefineType): Add error 441 report.
7929 (Class.AllowedModifiersProp): New virtual property as temporary
7930 extension to AllowedModifiers.
7931 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7932 to share implementation with StaticClass and don't call virtual
7935 * driver.cs (MainDriver): Add error 1558 test.
7937 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7938 report. Moved error 36 test here.
7940 * statement.cs (Throw.Resolve): Add error 724 report.
7942 * typemanager.cs: Add out_attribute_type core type.
7944 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7946 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7948 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7950 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7953 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7955 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7956 Add error 3023 report.
7957 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7959 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7962 2004-12-12 John Luke <john.luke@gmail.com>
7964 * driver.cs (AddArgs): take -- into account when
7965 adding arguments, fixes bug 65710
7967 2004-12-12 Martin Baulig <martin@ximian.com>
7969 * expression.cs (Unary.TryReduceNegative): Added support for
7970 SByteConstant and ByteConstant.
7971 (Unary.Reduce): Check error values from TryReduceNegative().
7973 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7975 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7976 and report exception as error 182.
7978 2004-12-10 Raja R Harinath <rharinath@novell.com>
7980 * driver.cs (Main): Fix message when there are warnings.
7982 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7984 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7986 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7988 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7989 Reduced number of warnings.
7991 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7993 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7995 * driver.cs: Removed message.
7997 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7999 2004-12-08 <vargaz@freemail.hu>
8001 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
8003 2004-12-08 Martin Baulig <martin@ximian.com>
8005 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
8006 instead of a CS3002 for properties and indexer.
8008 2004-12-08 Martin Baulig <martin@ximian.com>
8010 * decl.cs (MemberName.ToString): Make this work again.
8012 2004-12-08 Marek Safar <marek.safar@seznam.cz>
8014 * attribute.cs (Resolve): Add error 591 detection.
8016 * class.cs (FieldMember.Define): Add error 1547 detection.
8017 (Indexer.Define): Add error 620 detection.
8018 (Operator.Define): Add error 590 detection.
8020 * ecore.cs: Missing argument for error 79.
8022 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
8025 2004-12-07 Marek Safar <marek.safar@seznam.cz>
8028 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
8031 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
8033 * cs-parser.jay : handle doc comments on implicit/explicit operators.
8034 Some operator comments were suppressed.
8035 * doc.cs : Implicit/explicit operator name in doc comments are like
8036 "op_Explicit(type)~returnType", so added suffix handling.
8038 2005-01-21 Alp Toker <alp@atoker.com>
8040 * cs-parser.jay: destructor_declaration's container is PartialContainer
8041 not Class when partial types are used, so use Kind prop instead of 'is'.
8043 2004-12-12 Martin Baulig <martin@ximian.com>
8045 * expression.cs (Unary.TryReduceNegative): Added support for
8046 SByteConstant and ByteConstant.
8047 (Unary.Reduce): Check error values from TryReduceNegative().
8049 2004-12-11 Martin Baulig <martin@ximian.com>
8051 * support.cs (ReflectionParameters.ParameterName): If we have a
8052 `gpd', call `ParameterName' on it.
8054 * parameter.cs (Parameter.GetParameterAttributes): New static method.
8056 * pending.cs (PendingImplementation.DefineProxy): Call
8057 DefineParameter() for all of the MethodBuilder's arguments.
8059 2004-12-09 Martin Baulig <martin@ximian.com>
8061 * doc.cs (DocUtil): Make this a static class.
8063 2004-12-09 Martin Baulig <martin@ximian.com>
8065 * expression.cs (Invocation.InferType): Moved the type inference
8066 implementation into TypeManager.
8068 * generics.cs (TypeManager): Moved the type inference
8069 implementation here.
8071 2004-12-09 Martin Baulig <martin@ximian.com>
8073 * typemanager.cs (TypeManager): Make this a partial class.
8076 (TypeManager): Move the generics part of `TypeManager' here.
8078 2004-12-08 Martin Baulig <martin@ximian.com>
8080 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
8081 instead of a CS3002 for properties and indexer. Added CS3024
8082 check for generic interfaces.
8084 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
8085 instances are not CLS-compliant.
8087 2004-12-08 Martin Baulig <martin@ximian.com>
8090 (void_pointer_expression): New rule for `void*', `void**' etc.
8091 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
8093 2004-12-08 Martin Baulig <martin@ximian.com>
8095 * expression.cs (Invocation.InferType): Removed the hack for
8096 MethodCore.MayUnify().
8098 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
8101 * class.cs (MethodCore.MayUnify): Use
8102 TypeManager.MayBecomeEqualGenericTypes().
8104 2004-12-08 Martin Baulig <martin@ximian.com>
8106 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
8107 parameter, box it. Fixes #69233.
8109 2004-12-08 Martin Baulig <martin@ximian.com>
8111 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
8112 have the ctor constraint. Fixes #68326.
8114 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
8116 * cs-parser.jay : interface comment was not consumed because of
8117 extra opt_semicolon before doc handling.
8119 2004-12-03 Raja R Harinath <rharinath@novell.com>
8121 Fix test-327.cs, test-328.cs, and put in early infrastructure
8122 for eventually fixing #52697.
8123 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
8124 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
8126 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
8127 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
8128 (VerifyUsing, error246): Update.
8129 * rootcontext.cs (RootContext.NamespaceLookup): Just use
8130 'NamespaceEntry.LookupNamespaceOrType'.
8132 2004-12-07 Martin Baulig <martin@ximian.com>
8134 * driver.cs: Call it "BETA SOFTWARE" :-)
8136 2004-12-06 Raja R Harinath <rharinath@novell.com>
8138 Fix crash on cs0657-17.cs.
8139 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
8140 Use RootContext.Tree.Types, not 'new RootTypes ()'.
8141 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
8142 the case where the NamespaceEntry gets overwritten.
8144 2004-12-06 Marek Safar <marek.safar@seznam.cz>
8146 Fixed #69195, #56821
8147 * ecore.cs (ResolveBoolean): Tiny refactoring.
8149 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
8150 of right expression resolving when left is false constant and
8151 operator is LogicalAnd OR true constant and operator is LogicalOr.
8153 * statement.cs (ResolveUnreachable): Always reports warning.
8155 2004-12-05 Miguel de Icaza <miguel@ximian.com>
8157 * class.cs: Distinguish between 1721 and 1722 (just a little help
8158 for the programmer).
8160 2004-12-03 Miguel de Icaza <miguel@ximian.com>
8162 * delegate.cs: Only allow this on new versions of the language.
8164 2004-12-02 Duncan Mak <duncan@ximian.com>
8166 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
8168 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
8169 here as a static method. Take an additional bool out parameter
8170 `must_do_cs1540_check' for signaling to InstanceResolve.
8171 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
8172 member field from PropertyExpr class and made it an argument of
8174 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
8175 check for MarshalByRefObject, and report CS0122 instead of CS1540.
8176 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
8177 and `remove_accessor' as well as InstanceResolve: report CS0122
8182 2004-12-07 Martin Baulig <martin@ximian.com>
8184 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
8185 and CS0692 where appropriate.
8187 2004-12-06 Martin Baulig <martin@ximian.com>
8189 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
8190 IsDuplicateImplementation() and improved it.
8192 * expression.cs (Invocation.InferTypeArguments): Added
8193 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
8194 and removed the "ref" modifier from `infered_types'.
8196 * decl.cs (MemberName.ToString): Removed the exception.
8198 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
8200 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
8201 comments are allowed.
8203 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8205 * delegate.cs: Add checks for subtypes in paramaters and return values
8206 in VerifyMethod () to add support for Covariance/Contravariance
8209 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8211 * report.cs: Remove extra closing parenthesis.
8213 * convert.cs (Error_CannotImplicitConversion): If the name of the
8214 types are the same, provide some extra information.
8216 2004-12-02 Marek Safar <marek.safar@seznam.cz>
8219 * attribute.cs (Resolve): Improved implementation of params
8220 attribute arguments.
8222 * support.cs (ParameterData): Add HasParams to be faster.
8224 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
8226 all things are for /doc support:
8228 * doc.cs: new file that supports XML documentation generation.
8229 * mcs.exe.sources: added doc.cs.
8231 Handle /doc command line option.
8232 Report error 2006 instead of 5 for missing file name for /doc.
8233 Generate XML documentation when required, after type resolution.
8235 Added support for picking up documentation (/// and /** ... */),
8236 including a new XmlCommentState enumeration.
8238 Added lines to fill Documentation element for field, constant,
8239 property, indexer, method, constructor, destructor, operator, event
8240 and class, struct, interface, delegate, enum.
8241 Added lines to warn incorrect comment.
8243 Added Documentation field (passed only when /doc was specified).
8245 Added DocComment, DocCommentHeader, GenerateDocComment() and
8246 OnGenerateDocComment() and some supporting private members for
8247 /doc feature to MemberCore.
8249 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
8251 Added overriden DocCommentHeader.
8253 Added overriden DocCommentHeader and GenerateDocComment().
8255 2004-12-01 Miguel de Icaza <miguel@ximian.com>
8257 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
8258 unwrapping the enumeration values, chain to
8259 DoConstantNumericPromotions again, so we can promote things to the
8260 fundamental types (takes care of enums that are bytes, sbytes).
8264 2004-12-01 Raja R Harinath <rharinath@novell.com>
8266 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
8267 Fix long-standing bug in type-lookup. Use FindType instead of
8268 LookupType when ec.ResolvingTypeTree.
8269 (Attribute.ResolveType, Attribute.Resolve)
8270 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
8272 (Attributes.Search): Remove internal version. Update.
8273 (Attributes.SearchMulti): Update.
8274 (Attributes.GetClsCompliantAttribute): Remove.
8275 (Attributes.GetIndexerNameAttribute): Remove.
8276 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
8277 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
8278 * class.cs (Indexer.Define): Likewise.
8280 2004-12-01 Marek Safar <marek.safar@seznam.cz>
8283 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
8284 MarshallByReference members access.
8286 * expression.cs: Use CheckMarshallByRefAccess;
8287 Better error CS0197 message.
8289 * report.cs: Print whole related error message.
8291 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8293 * class (GetClassBases): Better error 60 report.
8294 (EventProperty): Disabled warning 67 detection.
8296 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8299 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
8301 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
8304 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8307 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
8309 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
8311 2004-11-26 Miguel de Icaza <miguel@ximian.com>
8313 * attribute.cs (Attribute.Resolve): Refine error reporting and
8314 report a cs0117 if the identifier does not exist, to distinguish
8315 from 0617 which is a miss-use of the actual identifier.
8317 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
8318 between cs0070 and cs0079.
8320 * class.cs (MemberBase.DoDefine): When reporting a wrong
8321 accessibility level, we use MethodCore to compare instead of
8322 Method (this was a regression in some refactoring effort).
8324 So now we correctly report cs0056 again.
8326 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
8327 testing the target_type (which was known to be object_type) and
8328 not the source type (which is anonymous_method).
8330 Fixed reporting of error cs1660.
8332 * expression.cs (UserCast.Source): Expose the underlying cast.
8334 * statement.cs (Switch.SwitchGoverningType): Sort the list of
8335 allowed types to find a match to int32 first (most common).
8337 In addition, it ignores any ImplicitUserConversions that did an
8338 internal implicit conversion (as the switch statement allows only
8339 one integral conversion to exist).
8341 * class.cs (PartialContainer.Create): rename `name' to
8342 `member_name' for clarity. Then replace the string calls with a
8343 call to MemberName.GetPartialName, as now using
8344 MemberName.ToString is an error (this is due to the side effects
8345 it had, that were fixed in the past).
8347 This will restore the error reporting on a number of partial class
8348 errors that were missusing this (and getting an exception as a
8349 results, which is now just a plain textual warning, because
8350 yyparse debug output would crash otherwise).
8352 2004-11-26 Raja R Harinath <rharinath@novell.com>
8354 * Makefile (PROGRAM_INSTALL_DIR): Remove.
8356 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8358 * rootcontext.cs (LookupType): Make sure to cache lookups that
8359 don't give us a negative result. This saves about 5% of corlib
8362 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8364 * report.cs (AbstractMessage.Print): messages are sent to stderr
8366 * class.cs (TypeContainer.GetClassBases): It is an error to have a
8367 non-interface in the list of interfaces (at this point, either
8368 parent was properly set, or a base class is being listed in the
8369 interfaces section).
8371 This flags error 1722, and resolves the crash from bug 69259.
8373 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8375 * statement.cs (Using.EmitExpressionFinally): make this work right
8376 for valuetypes. Fixes 69926.
8378 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8380 * const.cs (Const.ChangeType): Cope with the "0 literal can be
8381 converted to an enum" here, before we try to change the underlying
8382 type. This code exists, but it is a different code path than the
8383 one used while encoding constants.
8385 (ImplicitReferenceConversionExists): In addition, resynchronized
8386 the code here, so it matches the same code in
8387 ImplicitReferenceConversionExists for the `from any class-type S
8388 to any interface-type T'.
8390 2004-11-25 Marek Safar <marek.safar@seznam.cz>
8392 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
8394 2004-11-24 Miguel de Icaza <miguel@ximian.com>
8396 * cs-parser.jay: Use verbosity accordingly.
8398 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8400 * expression.cs (Unary.ResolveOperator): Do not report warning;
8401 AddressOf reads from variable.
8403 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
8405 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8409 * attribute.cs (Attributable): Removed CheckTargets.
8410 (Attributes.Emit): Explicit attribute targets are tested here.
8412 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
8413 not enabled for interfaces.
8415 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
8416 (GetAssemblyName): Ouch next bug there.
8418 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8420 * expression.cs: Error 275 added.
8422 2004-11-23 Marek Safar <marek.safar@seznam.cz>
8424 Fix bug #69177 (Implemented decimal constant support)
8426 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
8427 (BinaryFold): Add DecimalConstant.
8429 * const.cs (Define): Decimal constant
8431 (ChangeType): Add decimal type handling.
8432 (LookupConstantValue): Don't set value for decimal type but
8433 emit DecimalConstantAttribute. Needed for constant optimization.
8435 * constant.cs (ToDecimal): New method.
8436 (ConvertToDecimal): New method.
8437 (IntConstant): Implemented ConvertToDecimal.
8438 (DecimalConstant.Emit): Emit optimized version for decimals in
8441 * expression.cs (ResolveOperator): Changed order of constant
8442 reduction to work correctly with native types which have
8443 overloaded operators.
8444 (ResolveMemberAccess): Extract constant value from attribute
8447 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
8449 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
8450 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
8451 (ChangeType): Decimal is special.
8452 (TypeToCoreType): Add decimal type.
8454 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8456 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8459 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8461 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8464 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8466 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8468 * pending.cs (PendingImplementation): Grab only interfaces.
8470 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8472 * statement.cs (ForeachHelperMethods): Add location member and
8473 error 202 detection.
8475 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8477 * expression.cs (DoResolveBase): Fixed wrong warning for out
8480 2004-12-04 Martin Baulig <martin@ximian.com>
8482 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8483 to check whether the conversion is ok.
8485 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8486 `Type.EmptyTypes' if we're not a generic TypeContainer.
8488 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8490 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8491 old bug: when converting from the null literal to a pointer,
8492 return an EmptyCast, not the NullLiteral.
8494 This fixes #69921, the recent null_type changes probably made this
8497 2004-12-03 Martin Baulig <martin@ximian.com>
8499 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8500 method as our child, call AnonymousMethod.Compatible() on it.
8502 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8504 * class.cs (FieldBase): Use an unused bit field from the field to
8505 encode the `has_offset' property from the FieldMember. This saves
8506 a couple of Ks on bootstrap compilation.
8508 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8509 method as our child, return the AnonymousMethod resolved
8512 * expression.cs (New.DoResolve): Allow return values from
8513 NewDelegate to also include AnonymousMethods.
8517 2004-11-29 Raja R Harinath <rharinath@novell.com>
8519 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8521 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8522 System.Runtime.InteropServices._Exception, since it's a base
8523 interface of the core type System.Exception in the net_2_0 profile.
8525 2004-11-27 Martin Baulig <martin@ximian.com>
8527 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8529 2004-11-26 Raja R Harinath <rharinath@novell.com>
8531 * Makefile: Convert to use executable.make.
8532 * gmcs.exe.sources: New.
8534 2004-11-25 Martin Baulig <martin@ximian.com>
8536 * expression.cs (Invocation.InferType): Added support for byref types.
8538 2004-11-25 Martin Baulig <martin@ximian.com>
8540 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8541 in TypeManager.TypeToCoreType().
8543 2004-11-25 Martin Baulig <martin@ximian.com>
8545 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8546 "Dispose" method from the `current_type'.
8547 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8548 DoDefineMembers() instead of using the MethodBuilder; this is
8549 required for generic iterators.
8551 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8553 2004-11-24 Martin Baulig <martin@ximian.com>
8555 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8557 2004-11-20 Martin Baulig <martin@ximian.com>
8559 * expression.cs (Invocation.InferType): Correctly infer generic
8560 instances; see gen-103.cs.
8561 (Invocation.InferTypeArguments): If a generic method doesn't have
8562 any unbound type parameters, we don't need to infer anything.
8564 2004-11-19 Raja R Harinath <rharinath@novell.com>
8566 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8568 2004-11-17 Raja R Harinath <rharinath@novell.com>
8570 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8571 (TypeHandle.GetMemberCache): New.
8572 (TypeHandle.TypeHandle): Update.
8573 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8574 (TypeManager.LookupParentInterfacesCache):
8575 Rename from LookupInterfaceCache. Optimize slightly.
8576 (TypeManager.MemberLookup_FindMembers): Update.
8577 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8579 (AddCacheContents): Rename from AddHashtable.
8580 * class.cs (TypeContainer.parent_container): Remove.
8581 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8582 (TypeContainer.DoDefineMembers): Don't initialize it.
8583 Update to name changes.
8585 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8587 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8588 that factors the code to check access modifiers on override.
8590 (PropertyBase): Use the code here.
8592 Patch from Lluis S'anchez, fixes bug #69361.
8594 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8596 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8597 routine that is used to report the use of a captured variable
8598 whose address has been taken.
8600 There are two checks: one when variables are being captured and
8601 the other check is when the address of a variable is taken.
8603 (because an anonymous methods might be resolved before *or* after
8604 the address has been taken) and
8606 * expression.cs (Conditional.DoResolve): Remove the special
8607 casing that Martin added to trueExpr and falseExpr being both
8608 NullLiteral. We get the right behavior now just by introducing
8609 the null_type into the compiler.
8611 * convert.cs (ExplicitConversion): Change the code to use
8612 null_type instead of testing `expr is NullLiteral'.
8613 (ImplicitConversionStandard): use null_type too.
8614 (ImplicitReferenceConversionExists): use null_type too.
8615 (ImplicitReferenceConversion): use null_type too.
8617 * literal.cs: The type of `NullLiteral' is now null_type instead
8619 (Resolve): Set the type here.
8621 * typemanager.cs: Introduce null_type.
8623 2004-11-18 Martin Baulig <martin@ximian.com>
8626 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8628 2004-11-18 Martin Baulig <martin@ximian.com>
8630 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8632 2004-11-18 Martin Baulig <martin@ximian.com>
8634 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8635 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8636 call ResolveConstructedType() on it to resolve it without checking
8638 (Constraints.ResolveTypes): Check them here.
8639 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8640 but don't check constraints.
8641 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8642 check constraints here.
8643 (ConstructedType.ResolveConstructedType): New public method. This
8644 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8645 resolve ourselves without checking constraints.
8647 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8649 2004-11-18 Martin Baulig <martin@ximian.com>
8652 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8654 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8656 2004-11-18 Martin Baulig <martin@ximian.com>
8658 * ecore.cs (TypeExpr.ResolveType): Removed.
8659 (Expression.ResolveAsTypeTerminal): We always return a fully
8660 resolved `TypeExpr', so we can just access its `Type'.
8662 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8664 2004-11-17 Martin Baulig <martin@ximian.com>
8666 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8667 sure we don't return any unresolved TypeExpr's.
8668 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8670 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8672 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8673 unresolved `ConstructedType's.
8675 2004-11-17 Martin Baulig <martin@ximian.com>
8677 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8679 2004-11-17 Martin Baulig <martin@ximian.com>
8682 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8684 * decl.cs (DeclSpace.ResolveType): Removed.
8685 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8687 2004-11-17 Martin Baulig <martin@ximian.com>
8689 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8690 direction, like FindMembers() does. Fixes #69546, testcase is in
8693 2004-11-16 Martin Baulig <martin@ximian.com>
8695 This is based on a patch from Marek Safar, see bug #69082.
8696 Fixes bugs #63705 and #67130.
8698 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8699 method; create a MemberCache for an interface type and cache the
8702 * decl.cs (IMemberContainer.ParentContainer): Removed.
8703 (IMemberContainer.ParentCache): New property.
8704 (MemberCache.SetupCacheForInterface): Removed.
8705 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8706 to create a cache for an interface's "parent".
8708 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8711 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8713 * statement.cs: Avoid adding bools to a hashtable.
8715 2004-11-15 Martin Baulig <martin@ximian.com>
8717 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8719 2004-11-11 Martin Baulig <martin@ximian.com>
8721 * typemanager.cs (TypeManager.GetMethodName): New method.
8723 * class.cs (MethodData.Define): Include the generic arity in the
8724 name of an explicit interface; also add it to the method name.
8726 * pending.cs (PendingImplementation.InterfaceMethod): The method
8727 name now includes the generic arity.
8729 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8731 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8732 calling an unsafe method from a safe location.
8734 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8737 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8739 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8741 * namespace.cs (VerifyUsing): use GetPartialName instead of
8744 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8746 * statement.cs (Return.Resolve): Fix regression in typo: if
8747 `in_exc', we have to request a NeedReturnLabel, this was a typo
8748 introduced in the anonymous method check-in. Fixes #69131.
8750 * Indexers were using the ShortName when defining themselves,
8751 causing a regression in the compiler bootstrap when applying the
8752 patch from 2004-11-02 (first part), now they use their full name
8753 and the bug is gone.
8755 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8757 * driver.cs: Strip the path from the names of embedded resources. Fixes
8760 2004-11-04 Raja R Harinath <rharinath@novell.com>
8762 Fix error message regression: cs0104-2.cs.
8763 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8764 (AliasEntry.Resolve): Update.
8765 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8767 (RootContext.LookupType): Update.
8769 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8771 * cs-parser.jay: Add support for handling accessor modifiers
8772 * class: Add support port accessor modifiers and error checking,
8773 define PropertyMethod.Define as virtual (not abstract anymore)
8774 * ecore.cs: Add checking for proeprties access with access modifiers
8775 * iterators.cs: Modify Accessor constructor call based in the modified
8777 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8779 * expression.cs (StringConcat): Handle being called twice,
8780 as when we have a concat in a field init with more than two
8783 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8785 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8786 special case explicit implementations, we should always produce
8787 the .property or .event declaration.
8789 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8790 since it will not return correct data if people use this
8791 unresolved in the presence of using statements (see test-313).
8793 * class.cs (MethodData.Define): If we are an explicit interface
8794 implementation, set the method name to the full name of the
8795 interface plus the name of the method.
8797 Notice that using the method.MethodName.GetFullName() does not
8798 work, as it will only contain the name as declared on the source
8799 file (it can be a shorthand in the presence of using statements)
8800 and not the fully qualifed type name, for example:
8804 class D : ICloneable {
8805 object ICloneable.Clone () {
8809 Would produce a method called `ICloneable.Clone' instead of
8810 `System.ICloneable.Clone'.
8812 * namespace.cs (Alias.Resolve): Use GetPartialName.
8814 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8816 * cs-parser.jay: Add error 1055 report.
8818 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8820 * assign.cs (Assign.DoResolve): Only do the transform of
8821 assignment into a New if the types are compatible, if not, fall
8822 through and let the implicit code deal with the errors and with
8823 the necessary conversions.
8825 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8827 * cs-parser.jay: Add error 1031 report.
8829 * cs-tokenizer.cs: Add location for error 1038.
8831 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8833 * cs-parser.jay: Add error 1016 report.
8835 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8837 * cs-parser.jay: Add errors 1575,1611 report.
8839 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8841 * cs-parser.jay: Add error 1001 report.
8843 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8846 * attribute.cs (GetMarshal): Add method argument for
8847 caller identification.
8849 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8850 agument for GetMarshal and RuntimeMissingSupport.
8852 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8854 * attribute.cs (ExtractSecurityPermissionSet): Removed
8855 TypeManager.code_access_permission_type.
8857 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8859 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8861 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8862 for obsolete use of a variable here. Fixes regression on errors
8863 cs0619-25 and cs0619-26.
8865 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8867 Fix #62358, implemented security attribute encoding.
8869 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8870 Tests permitted SecurityAction for assembly or other types.
8871 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8872 data from SecurityPermissionAttribute to PermisionSet class.
8874 * class.cs (ApplyAttributeBuilder): Added special handling
8875 for System.Security.Permissions.SecurityAttribute based types.
8877 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8878 special handling for System.Security.Permissions.SecurityAttribute
8881 * enum.cs (ApplyAttributeBuilder): Added special handling
8882 for System.Security.Permissions.SecurityAttribute based types.
8884 * parameter.cs (ApplyAttributeBuilder): Added special handling
8885 for System.Security.Permissions.SecurityAttribute based types.
8887 * rootcontext.cs: Next 2 core types.
8889 * typemanager.cs (TypeManager.security_permission_attr_type):
8890 Built in type for the SecurityPermission Attribute.
8891 (code_access_permission_type): Build in type.
8893 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8895 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8896 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8897 all of this information into
8898 EmitContext.EmitCapturedVariableInstance.
8900 * codegen.cs (EmitCapturedVariableInstance): move here the
8901 funcionality of emitting an ldarg.0 in the presence of a
8902 remapping. This centralizes the instance emit code.
8904 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8905 then emit a load of this: it means that we have reached the
8906 topmost ScopeInfo: the one that contains the pointer to the
8907 instance of the class hosting the anonymous method.
8909 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8910 captures to the topmost CaptureContext.
8912 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8914 * expression.cs (LocalVariableReference): Move the knowledge about
8915 the iterators into codegen's EmitCapturedVariableInstance.
8917 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8919 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8920 all code paths return a value from an anonymous method (it is the
8921 same as the 161 error, but for anonymous methods).
8923 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8925 The introduction of anonymous methods in the compiler changed
8926 various ways of doing things in the compiler. The most
8927 significant one is the hard split between the resolution phase
8928 and the emission phases of the compiler.
8930 For instance, routines that referenced local variables no
8931 longer can safely create temporary variables during the
8932 resolution phase: they must do so from the emission phase,
8933 since the variable might have been "captured", hence access to
8934 it can not be done with the local-variable operations from the runtime.
8938 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8939 is a toplevel block.
8941 (ToplevelBlock): A new kind of Block, these are the blocks that
8942 are created by the parser for all toplevel method bodies. These
8943 include methods, accessors and anonymous methods.
8945 These contain some extra information not found in regular blocks:
8946 A pointer to an optional CaptureContext (for tracking captured
8947 local variables and parameters). A pointer to the parent
8950 (Return.Resolve): Catch missmatches when returning a value from an
8951 anonymous method (error 1662).
8952 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8955 (Break.Resolve): ditto.
8957 (SwitchLabel): instead of defining the labels during the
8958 resolution phase, we now turned the public ILLabel and ILLabelCode
8959 labels into methods called GetILLabelCode() and GetILLabel() that
8960 only define the label during the Emit phase.
8962 (GotoCase): Track the SwitchLabel instead of the computed label
8963 (its contained therein). Emit the code by using
8964 SwitchLabel.GetILLabelCode ().
8966 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8967 whether the Local has been captured or not.
8969 (LocalInfo.IsCaptured): New property, used to tell whether the
8970 local has been captured.
8972 * anonymous.cs: Vastly updated to contain the anonymous method
8975 The main classes here are: CaptureContext which tracks any
8976 captured information for a toplevel block and ScopeInfo used to
8977 track the activation frames for various local variables.
8979 Each toplevel block has an optional capture context associated
8980 with it. When a method contains an anonymous method both the
8981 toplevel method and the anonymous method will create a capture
8982 context. When variables or parameters are captured, they are
8983 recorded on the CaptureContext that owns them, for example:
8987 MyDelegate d = delegate {
8992 Here `a' will be recorded as captured on the toplevel
8993 CapturedContext, the inner captured context will not have anything
8994 (it will only have data if local variables or parameters from it
8995 are captured in a nested anonymous method.
8997 The ScopeInfo is used to track the activation frames for local
8998 variables, for example:
9000 for (int i = 0; i < 10; i++)
9001 for (int j = 0; j < 10; j++){
9002 MyDelegate d = delegate {
9007 At runtime this captures a single captured variable `i', but it
9008 captures 10 different versions of the variable `j'. The variable
9009 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
9010 recorded on a child.
9012 The toplevel ScopeInfo will also track information like the `this'
9013 pointer if instance variables were referenced (this is necessary
9014 as the anonymous method lives inside a nested class in the host
9015 type of the method).
9017 (AnonymousMethod): Expanded to track the Toplevel, implement
9018 `AnonymousMethod.Compatible' to tell whether an anonymous method
9019 can be converted to a target delegate type.
9021 The routine now also produces the anonymous method content
9023 (AnonymousDelegate): A helper class that derives from
9024 DelegateCreation, this is used to generate the code necessary to
9025 produce the delegate for the anonymous method that was created.
9027 * assign.cs: API adjustments for new changes in
9028 Convert.ImplicitStandardConversionExists.
9030 * class.cs: Adjustments to cope with the fact that now toplevel
9031 blocks are of type `ToplevelBlock'.
9033 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
9034 insteda of standard blocks.
9036 Flag errors if params arguments are passed to anonymous methods.
9038 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
9039 `CurrentAnonymousMethod' which points to the current Anonymous
9040 Method. The variable points to the AnonymousMethod class that
9041 holds the code being compiled. It is set in the new EmitContext
9042 created for the anonymous method.
9044 (EmitContext.Phase): Introduce a variable and an enumeration to
9045 assist in enforcing some rules about when and where we are allowed
9046 to invoke certain methods (EmitContext.NeedsReturnLabel is the
9047 only one that enfonces this right now).
9049 (EmitContext.HaveCaptureInfo): new helper method that returns
9050 whether we have a CapturedContext initialized.
9052 (EmitContext.CaptureVariable): New method used to register that a
9053 LocalInfo must be flagged for capturing.
9055 (EmitContext.CapturedParameter): New method used to register that a
9056 parameters must be flagged for capturing.
9058 (EmitContext.CapturedField): New method used to register that a
9059 field must be flagged for capturing.
9061 (EmitContext.HaveCapturedVariables,
9062 EmitContext.HaveCapturedFields): Return whether there are captured
9063 variables or fields.
9065 (EmitContext.EmitMethodHostInstance): This is used to emit the
9066 instance for the anonymous method. The instance might be null
9067 (static methods), this (for anonymous methods that capture nothing
9068 and happen to live side-by-side with the current method body) or a
9069 more complicated expression if the method has a CaptureContext.
9071 (EmitContext.EmitTopBlock): Routine that drives the emission of
9072 code: it will first resolve the top block, then emit any metadata
9073 and then emit the code. The split is done so that we can extract
9074 any anonymous methods and flag any captured variables/parameters.
9076 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
9077 during this phase, the ILGenerator should not be used as labels
9078 and local variables declared here might not be accessible to any
9079 code that is part of an anonymous method.
9081 Exceptions to this include the temporary variables that are
9082 created by some statements internally for holding temporary
9085 (EmitContext.EmitMeta): New routine, in charge of emitting all the
9088 (EmitContext.TemporaryReturn): This method is typically called
9089 from the Emit phase, and its the only place where we allow the
9090 ReturnLabel to be defined other than the EmitMeta. The reason is
9091 that otherwise we would have to duplicate a lot of logic in the
9092 Resolve phases of various methods that today is on the Emit
9095 (EmitContext.NeedReturnLabel): This no longer creates the label,
9096 as the ILGenerator is not valid during the resolve phase.
9098 (EmitContext.EmitThis): Extended the knowledge in this class to
9099 work in anonymous methods in addition to iterators.
9101 (EmitContext.EmitCapturedVariableInstance): This emits whatever
9102 code is necessary on the stack to access the instance to a local
9103 variable (the variable will be accessed as a field).
9105 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
9106 EmitContext.EmitAddressOfParameter): Routines to support
9107 parameters (not completed at this point).
9109 Removals: Removed RemapLocal and RemapLocalLValue. We probably
9110 will also remove the parameters.
9112 * convert.cs (Convert): Define a `ConstantEC' which points to a
9113 null. This is just to prefity some code that uses
9114 ImplicitStandardConversion code and do not have an EmitContext
9117 The idea is to flag explicitly that at that point in time, it is
9118 known that the conversion will not trigger the delegate checking
9119 code in implicit conversions (which requires a valid
9122 Everywhere: pass new EmitContext parameter since
9123 ImplicitStandardConversionExists now requires it to check for
9124 anonymous method conversions.
9126 (Convert.ImplicitStandardConversionExists): If the type of an
9127 expression is the anonymous_method_type, and the type is a
9128 delegate, we invoke the AnonymousMethod.Compatible method to check
9129 whether an implicit conversion is possible.
9131 (Convert.ImplicitConversionStandard): Only do implicit method
9132 group conversions if the language level is not ISO_1.
9134 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
9135 MethodInfo for the Invoke method. used by Delegate and
9138 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
9139 method conversions if the target type is a delegate.
9141 Removed extra debugging nops.
9143 (LocalVariableReference): Turn the `local_info' into a public
9146 Add `prepared' field, the same hack used for FieldExprs to cope
9147 with composed assignments, as Local variables do not necessarily
9148 operate purely on the stack as they used to: they can be captured
9151 Add `temp' for a temporary result, like fields.
9153 Refactor DoResolve and DoResolveLValue into DoResolveBase.
9155 It now copes with Local variables that are captured and emits the
9156 proper instance variable to load it from a field in the captured
9159 (ParameterReference.DoResolveBase): During the resolve phase,
9160 capture parameters if we are in an anonymous method.
9162 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
9163 anonymous method, use the EmitContext helper routines to emit the
9164 parameter reference.
9166 * iterators.cs: Set RemapToProxy to true/false during the
9169 * parameters.cs (GetParameterByName): New helper method.
9171 * typemanager.cs (anonymous_method_type) a new type that
9172 represents an anonyous method. This is always an internal type,
9173 used as a fencepost to test against the anonymous-methodness of an
9176 2004-10-20 Marek Safar <marek.safar@seznam.cz>
9178 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
9180 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
9182 2004-11-10 Martin Baulig <martin@ximian.com>
9184 * expression.cs (Invocation.BetterFunction): If two methods have
9185 equal parameter types, but only one of them is generic, the
9186 non-generic one wins.
9187 (New.DoResolve): Don't set `is_struct' to false if we're a generic
9188 instance; just use `Type.IsValueType' to determine whether
9189 something is a struct or not.
9190 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
9191 so we can be called multiple times.
9193 2004-11-10 Martin Baulig <martin@ximian.com>
9195 * generic.cs (TypeParameter.DefineConstraints): New public method.
9196 (TypeParameter.CheckAccessLevel): Override this and return true.
9197 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
9198 override ResolveType() anymore.
9199 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
9201 2004-11-10 Martin Baulig <martin@ximian.com>
9203 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
9204 call DeclSpace.ResolveNestedType() on it.
9206 2004-11-10 Martin Baulig <martin@ximian.com>
9208 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
9209 non-null, call ParameterModifier() on it.
9211 2004-11-10 Martin Baulig <martin@ximian.com>
9214 (Iterators): Added `current_type' and `this_type' fields.
9215 (Iterators.DefineIterator): Create a new EmitContext and store it
9216 in `ec'; compute `this_type'.
9218 2004-11-10 Martin Baulig <martin@ximian.com>
9221 (TypeManager.IsPrivateAccessible): New public method.
9222 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
9224 2004-11-10 Martin Baulig <martin@ximian.com>
9226 * class.cs (TypeContainer.DefineType): Call
9227 TypeBuilder.DefineGenericParameters() before resolving the type
9229 (MethodData.parent_method): New protected field.
9230 (MethodData..ctor): Added `MethodInfo parent_method' argument.
9231 (MethodData.Define): Compute `parent_method'.
9234 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
9235 (MemberCore.GetClsCompliantAttributeValue): Likewise.
9236 (DeclSpace.ec): New protected field; store the EmitContext here.
9237 (DeclSpace.EmitContext): New public property.
9238 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
9239 (DeclSpace.ResolveNestedType): New public method.
9240 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
9241 (DeclSpace.NestedAccessible): Added `Type tb' argument.
9242 (DeclSpace.FamilyAccessible): Likewise.
9243 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
9244 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
9247 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
9250 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
9251 (Enum.Emit): Don't create a new EmitContext.
9253 2004-10-18 Martin Baulig <martin@ximian.com>
9255 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
9256 `Type' directly, but call ResolveType() on it.
9257 (Catch.Resolve): Likewise.
9258 (Foreach.Resolve): Likewise.
9260 2004-10-18 Martin Baulig <martin@ximian.com>
9262 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
9263 `Type' directly, but call ResolveType() on it.
9264 (Probe.DoResolve): Likewise.
9265 (ArrayCreation.LookupType): Likewise.
9266 (TypeOf.DoResolve): Likewise.
9267 (SizeOf.DoResolve): Likewise.
9269 2004-10-18 Raja R Harinath <rharinath@novell.com>
9271 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
9274 2004-10-17 John Luke <john.luke@gmail.com>
9276 * class.cs (Operator.GetSignatureForError): use CSharpName
9278 * parameter.cs (Parameter.GetSignatureForError): Returns
9279 correct name even if was not defined.
9281 2004-10-13 Raja R Harinath <rharinath@novell.com>
9284 * class.cs (TypeContainer.EmitContext): New property.
9285 (DefineNestedTypes): Create an emitcontext for each part.
9286 (MethodCore.DoDefineParameters): Use container's emitcontext.
9287 Pass type array to InternalParameters.
9288 (MemberBase.DoDefine): Use container's emitcontext.
9289 (FieldMember.Define): Likewise.
9290 (Event.Define): Likewise.
9291 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9292 Pass type array to InternalParameters.
9293 (SetIndexerMethod.GetParameterInfo): Likewise.
9294 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9295 * delegate.cs (Define): Pass emitcontext to
9296 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9297 array to InternalParameters.
9298 * expression.cs (ParameterReference.DoResolveBase): Pass
9299 emitcontext to GetParameterInfo.
9300 (ComposedCast.DoResolveAsTypeStep): Remove check on
9301 ec.ResolvingTypeTree.
9302 * parameter.cs (Parameter.Resolve): Change argument to
9303 EmitContext. Use ResolveAsTypeTerminal.
9304 (Parameter.GetSignature): Change argument to EmitContext.
9305 (Parameters.ComputeSignature): Likewise.
9306 (Parameters.ComputeParameterTypes): Likewise.
9307 (Parameters.GetParameterInfo): Likewise.
9308 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9309 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9310 * support.cs (InternalParameters..ctor): Remove variant that takes
9312 * typemanager.cs (system_intptr_expr): New.
9313 (InitExpressionTypes): Initialize it.
9315 2004-10-12 Chris Toshok <toshok@ximian.com>
9317 * cs-parser.jay: fix location for try_statement and catch_clause.
9319 2004-10-18 Martin Baulig <martin@ximian.com>
9321 * class.cs (FieldMember.Define): Don't access the TypeExpr's
9322 `Type' directly, but call ResolveType() on it.
9323 (MemberBase.DoDefine): Likewise.
9325 * expression.cs (New.DoResolve): Don't access the TypeExpr's
9326 `Type' directly, but call ResolveType() on it.
9327 (ComposedCast.DoResolveAsTypeStep): Likewise.
9329 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
9330 `Type' directly, but call ResolveType() on it.
9332 2004-10-17 John Luke <john.luke@gmail.com>
9334 * class.cs (Operator.GetSignatureForError): use CSharpName
9336 * parameter.cs (Parameter.GetSignatureForError): Returns
9337 correct name even if was not defined.
9339 2004-10-13 Raja R Harinath <rharinath@novell.com>
9342 * class.cs (TypeContainer.EmitContext): New property.
9343 (DefineNestedTypes): Create an emitcontext for each part.
9344 (MethodCore.DoDefineParameters): Use container's emitcontext.
9345 Pass type array to InternalParameters.
9346 (MemberBase.DoDefine): Use container's emitcontext.
9347 (FieldMember.Define): Likewise.
9348 (Event.Define): Likewise.
9349 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9350 Pass type array to InternalParameters.
9351 (SetIndexerMethod.GetParameterInfo): Likewise.
9352 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9353 * delegate.cs (Define): Pass emitcontext to
9354 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9355 array to InternalParameters.
9356 * expression.cs (ParameterReference.DoResolveBase): Pass
9357 emitcontext to GetParameterInfo.
9358 (ComposedCast.DoResolveAsTypeStep): Remove check on
9359 ec.ResolvingTypeTree.
9360 * parameter.cs (Parameter.Resolve): Change argument to
9361 EmitContext. Use ResolveAsTypeTerminal.
9362 (Parameter.GetSignature): Change argument to EmitContext.
9363 (Parameters.ComputeSignature): Likewise.
9364 (Parameters.ComputeParameterTypes): Likewise.
9365 (Parameters.GetParameterInfo): Likewise.
9366 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9367 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9368 * support.cs (InternalParameters..ctor): Remove variant that takes
9370 * typemanager.cs (system_intptr_expr): New.
9371 (InitExpressionTypes): Initialize it.
9373 2004-10-12 Chris Toshok <toshok@ximian.com>
9375 * cs-parser.jay: fix location for try_statement and catch_clause.
9377 2004-10-07 Raja R Harinath <rharinath@novell.com>
9379 More DeclSpace.ResolveType avoidance.
9380 * decl.cs (MemberCore.InUnsafe): New property.
9381 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
9382 with newly created EmitContext.
9383 (FieldMember.Define): Likewise.
9384 * delegate.cs (Delegate.Define): Likewise.
9385 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
9386 only if normal name-lookup fails.
9387 (TypeExpr.DoResolve): Enable error-checking.
9388 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
9389 (SizeOf.DoResolve): Likewise.
9390 (ComposedCast.DoResolveAsTypeStep): Likewise.
9391 (StackAlloc.DoResolve): Likewise.
9392 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
9393 (Block.Unsafe): New property.
9394 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
9395 (Unsafe): Set 'unsafe' flag of contained block.
9396 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
9397 (Fixed.Resolve): Likewise.
9398 (Catch.Resolve): Likewise.
9399 (Using.ResolveLocalVariableDecls): Likewise.
9400 (Foreach.Resolve): Likewise.
9402 2004-10-05 John Luke <john.luke@gmail.com>
9404 * cs-parser.jay: add location to error CS0175
9406 2004-10-04 Miguel de Icaza <miguel@ximian.com>
9408 * ecore.cs (Expression.Constantity): Add support for turning null
9411 * const.cs (Const.Define): Allow constants to be reference types
9412 as long as the value is Null.
9414 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
9416 * namespace.cs (NamespaceEntry.Using): No matter which warning
9417 level is set, check if this namespace name has already been added.
9419 2004-10-03 Ben Maurer <bmaurer@ximian.com>
9421 * expression.cs: reftype [!=]= null should always use br[true,false].
9424 2004-10-03 Marek Safar <marek.safar@seznam.cz>
9427 * attribute.cs: Enum conversion moved to
9428 GetAttributeArgumentExpression to be applied to the all
9431 2004-10-01 Raja R Harinath <rharinath@novell.com>
9433 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
9434 * class.c (TypeContainer.DefineType): Flag error if
9435 base types aren't accessible due to access permissions.
9436 * decl.cs (DeclSpace.ResolveType): Move logic to
9437 Expression.ResolveAsTypeTerminal.
9438 (DeclSpace.ResolveTypeExpr): Thin layer over
9439 Expression.ResolveAsTypeTerminal.
9440 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
9441 Refactor code into NestedAccess. Use it.
9442 (DeclSpace.NestedAccess): New.
9443 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
9444 argument to silence errors. Check access permissions.
9445 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
9446 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
9447 (Cast.DoResolve): Likewise.
9448 (New.DoResolve): Likewise.
9449 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
9450 (TypeOf.DoResolve): Likewise.
9452 * expression.cs (Invocation.BetterConversion): Return the Type of
9453 the better conversion. Implement section 14.4.2.3 more faithfully.
9454 (Invocation.BetterFunction): Make boolean. Make correspondence to
9455 section 14.4.2.2 explicit.
9456 (Invocation.OverloadResolve): Update.
9457 (Invocation): Remove is_base field.
9458 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9459 (Invocation.Emit): Likewise.
9461 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9463 * cs-parser.jay: Reverted 642 warning fix.
9465 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9468 * decl.cs (FindMemberWithSameName): Indexer can have more than
9471 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9473 * expression.cs (LocalVariableReference.DoResolveLValue):
9474 Do not report warning 219 for out values.
9475 (EmptyExpression.Null): New member to avoid extra allocations.
9477 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9479 * cs-parser.jay: Fix wrong warning 642 report.
9481 * cs-tokenizer.cs (CheckNextToken): New helper;
9482 Inspect next character if is same as expected.
9484 2004-09-23 Martin Baulig <martin@ximian.com>
9486 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9487 (Convert.ImplicitReferenceConversionExists): Likewise.
9489 2004-11-09 Raja R Harinath <rharinath@novell.com>
9491 * Makefile (DISTFILES): Comment out a few missing files.
9493 2004-10-29 Raja R Harinath <rharinath@novell.com>
9495 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9496 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9497 (gmcs.exe): Invoke bootstrap-libs.
9498 (clean-local): Clean the net_2_0_bootstrap profile too.
9499 (PROGRAM_INSTALL_DIR): New.
9500 (install-local): Use it.
9502 2004-10-13 Martin Baulig <martin@ximian.com>
9504 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9505 (TypeParameter.DefineType): If we're a method type parameter and
9506 that method is overriding something, "inflate" its constraints.
9508 2004-10-12 Martin Baulig <martin@ximian.com>
9510 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9511 and have type arguments, create and resolve a ConstructedType.
9513 2004-10-12 Martin Baulig <martin@ximian.com>
9515 * decl.cs (MemberCache.FindMemberToOverride): Use
9516 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9517 to compare the invocationType.
9519 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9520 When comparing two type parameters, only do the signature-only
9521 comparision for method type parameters.
9523 2004-10-11 Martin Baulig <martin@ximian.com>
9525 * report.cs: Don't make --fatal abort on warnings, we have
9526 -warnaserror for that.
9528 2004-10-11 Martin Baulig <martin@ximian.com>
9531 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9532 (TypeManager.IsEqual): Call ourself recursively instead of using
9535 2004-10-11 Martin Baulig <martin@ximian.com>
9537 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9538 on our own type parameters, not on the ones we inherit from a containing
9541 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9544 * generic.cs (TypeParameter.Define): We may only be called once.
9546 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9547 instead of TypeManager.IsEqual().
9549 2004-09-28 Martin Baulig <martin@ximian.com>
9552 (GenericConstraints.EffectiveBaseClass): New public property.
9553 (TypeParameter.GenericConstraints): New public property.
9554 (ConstructedType.CheckConstraints): Improved.
9556 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9557 (Convert.TypeParameterConversion): New private method; use this in
9558 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9559 for all conversions related to type parameters.
9561 2004-09-24 Martin Baulig <martin@ximian.com>
9563 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9564 type parameter conversions for type parameters which are known to
9567 2004-09-24 Martin Baulig <martin@ximian.com>
9569 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9570 `IsValueType' properties.
9572 * support.cs (ReflectionConstraints): Use
9573 Type.GetGenericParameterConstraints() instead of the old hack.
9575 2004-09-24 Martin Baulig <martin@ximian.com>
9577 * generic.cs (GenericConstraints): Moved here and made it an
9580 * support.cs (GenericConstraints): Moved to generic.cs.
9582 2004-09-24 Martin Baulig <martin@ximian.com>
9585 (ReflectionConstraints): Un-nested this class and made it public.
9588 (TypeManager.GetTypeParameterConstraints): New public method.
9589 (TypeManager.HasConstructorConstraint): Use the attributes.
9591 2004-09-24 Martin Baulig <martin@ximian.com>
9593 * support.cs (GenericConstraints): Replaced `HasConstructor',
9594 `IsReferenceType' and `IsValueType' with `Attributes'.
9595 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9596 method and made the .ctor public.
9598 * generic.cs (Constraints.Attributes): New public property.
9599 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9600 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9601 `IsValueType' -> `HasValueTypeConstraint'.
9603 2004-09-23 Martin Baulig <martin@ximian.com>
9605 * generic.cs (Constraints): Reflect latest runtime changes.
9607 2004-09-23 Martin Baulig <martin@ximian.com>
9609 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9610 (Convert.ImplicitReferenceConversionExists): Likewise.
9612 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9614 * class.cs (Operator.Define): Add error 448 and 559 report.
9616 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9618 * class.cs (MemberBase.IsTypePermitted): New protected
9619 method for checking error CS0610.
9621 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9623 * class.cs (TypeContainer.HasExplicitLayout): New property
9624 Returns whether container has StructLayout attribute set Explicit.
9625 (FieldMember): New abstract class for consts and fields.
9626 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9627 (Field): Reuse FieldMember.
9629 * const.cs (Const): Reuse FieldMember.
9631 * rootcontext.cs: EmitConstants call moved to class.
9633 2004-09-22 Martin Baulig <martin@ximian.com>
9635 Marek and me just fixed one of our oldest bugs: #28562 :-)
9637 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9639 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9640 we're an EnumConstant, just return that.
9641 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9642 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9643 to get the value which'll actually be written into the attribute.
9644 However, we have to use GetValue() to access the attribute's value
9647 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9649 * constant.cs (Constant.IsNegative): New abstract property
9652 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9653 (StackAlloc.DoResolve): Reused IsNegative.
9655 2004-09-22 Martin Baulig <martin@ximian.com>
9657 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9658 public method; like LookupTypeContainer, but also works for
9661 * report.cs (Report.SymbolRelatedToPreviousError): Use
9662 TypeManager.LookupGenericTypeContainer().
9664 2004-09-22 Martin Baulig <martin@ximian.com>
9666 Thanks to Peter Sestoft for this bug report.
9668 * expression.cs (Conditional): If both the `trueExpr' and the
9669 `falseExpr' is a NullLiteral, return a NullLiteral.
9671 2004-09-22 Martin Baulig <martin@ximian.com>
9673 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9674 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9675 for the "get_Current" call.
9677 2004-09-21 Martin Baulig <martin@ximian.com>
9679 * convert.cs (Convert.ImplicitReferenceConversion): When
9680 converting to an interface type, first check whether we're
9681 converting from a reference type.
9683 2004-09-14 Martin Baulig <martin@ximian.com>
9685 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9687 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9690 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9691 called and is obsolete then this member suppress message
9692 when call is inside next [Obsolete] method or type.
9694 * expression.cs: Use TestObsoleteMethodUsage member.
9696 2004-09-14 Martin Baulig <martin@ximian.com>
9698 * genericparser.cs: Removed.
9700 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9702 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9704 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9706 * attribute.cs (Attribute.Resolve): Add error 653 report.
9708 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9710 (Method.ApplyAttributeBuilder): Add error 685 report.
9711 (Operator.Define): Add error 564 report.
9713 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9715 * expression.cs (Invocation.DoResolve): Add error
9718 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9721 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9723 * class.cs (ConstructorInitializer.Resolve):
9724 Wrong error number (515->516).
9726 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9728 * class.cs (Indexer.Define): Add error 631 report.
9730 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9732 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9734 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9736 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9738 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9740 * cs-parser.jay: Added error CS0241 report.
9742 2004-09-10 Raja R Harinath <rharinath@novell.com>
9744 * cs-parser.jay (fixed_statement): Introduce a scope for the
9745 declaration in the 'fixed' statement.
9747 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9749 * cs-parser.jay: Added CS0230 error report.
9751 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9753 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9755 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9757 * expression.cs (Argument.Resolve): Added error CS0192 and
9760 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9762 C# 2.0 #pragma warning feature
9764 * cs-tokenizer.cs (PreProcessPragma): New method;
9765 Handles #pragma directive.
9767 * report.cs (WarningRegions): New class; Support
9768 class for #pragma warning directive. It tests whether
9769 warning is enabled for a given line.
9771 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9773 * const.cs: Add more descriptive error report, tahnks to
9776 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9778 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9780 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9782 * expression.cs: Apply patch from Ben: Remove dead code from
9783 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9784 as that code just threw an exception anwyays.
9786 * const.cs: Remove the call to the turnintoconstant, for details
9789 * literal.cs: The type of the null-literal is the null type; So
9790 we use a placeholder type (literal.cs:System.Null, defined here)
9793 * expression.cs (Conditional.DoResolve): Remove some old code that
9794 is no longer needed, conversions have been fixed.
9796 (ArrayCreationExpression.DoResolve): Return false if we fail to
9797 resolve the inner expression.
9799 2004-09-07 Raja R Harinath <rharinath@novell.com>
9802 * cs-parser.jay (delegate_declaration): Record a delegate
9803 declaration as a type declaration.
9804 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9806 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9808 * parameter.cs: Do not crash if the type can not be resolved.
9810 * expression.cs: Report errors with unsafe pointers, fixes #64896
9812 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9814 * expression.cs: Pointer arith always needs to do a conv.i
9815 if the operand is a long. fix 65320
9817 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9819 Fixed cs0619-37.cs, cs0619-38.cs
9821 * enum.cs (GetObsoleteAttribute): Removed.
9823 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9824 on Enum member is double staged. The first is tested member
9827 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9829 Fixed #56986, #63631, #65231
9831 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9832 adds member to name container.
9833 (TypeContainer.AddToTypeContainer): New method, adds type to
9835 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9836 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9837 AddOperator): Simplified by reusing AddToMemberContainer.
9838 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9840 (Method.CheckForDuplications): Fixed implementation to test all
9842 (MemberBase): Detection whether member is explicit interface
9843 implementation is now in constructor.
9844 (MemberBase.UpdateMemberName): Handles IndexerName.
9845 (Accessor): Changed to keep also location information.
9846 (AbstractPropertyEventMethod): Is derived from MemberCore.
9847 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9848 will be emited or not.
9849 (PropertyBase.AreAccessorsDuplicateImplementation):
9850 Tests whether accessors are not in collision with some method.
9851 (Operator): Is derived from MethodCore to simplify common
9854 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9856 (DeclSpace.AddToContainer): Adds the member to defined_names
9857 table. It tests for duplications and enclosing name conflicts.
9859 * enum.cs (EnumMember): Clean up to reuse the base structures
9861 2004-09-03 Martin Baulig <martin@ximian.com>
9863 Merged latest changes into gmcs. Please keep this comment in
9864 here, it makes it easier for me to see what changed in MCS since
9865 the last time I merged.
9867 2004-09-03 Martin Baulig <martin@ximian.com>
9869 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9870 into TypeContainer, to make partial classes work again.
9872 2004-09-03 Martin Baulig <martin@ximian.com>
9874 * rootcontext.cs (RootContext.V2): Removed.
9876 2004-03-23 Martin Baulig <martin@ximian.com>
9878 * expression.cs (Invocation.OverloadResolve): Added `bool
9879 may_fail' argument and use it instead of the Location.IsNull() hack.
9881 2004-09-09 Martin Baulig <martin@ximian.com>
9883 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9885 2004-09-09 Martin Baulig <martin@ximian.com>
9887 * generic.cs (TypeParameter.DefineType): Added support for
9888 explicit interface methods.
9890 2004-09-09 Martin Baulig <martin@ximian.com>
9892 * README.Changes: New document. Started to list important changes
9893 between MCS and GMCS here.
9895 2004-09-08 Martin Baulig <martin@ximian.com>
9898 (TypeContainer.CheckRecursiveDefinition): New protected method.
9899 (TypeContainer.DefineType): Move the CS0146 check into
9900 CheckRecursiveDefinition().
9902 2004-09-06 Martin Baulig <martin@ximian.com>
9904 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9905 types for the constructor constraint.
9907 2004-09-03 Martin Baulig <martin@ximian.com>
9909 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9910 into TypeContainer, to make partial classes work again.
9912 2004-09-03 Martin Baulig <martin@ximian.com>
9914 * rootcontext.cs (RootContext.V2): Removed.
9916 2004-03-23 Martin Baulig <martin@ximian.com>
9918 * expression.cs (Invocation.OverloadResolve): Added `bool
9919 may_fail' argument and use it instead of the Location.IsNull() hack.
9921 2004-09-03 Martin Baulig <martin@ximian.com>
9923 Merged latest changes into gmcs. Please keep this comment in
9924 here, it makes it easier for me to see what changed in MCS since
9925 the last time I merged.
9927 2004-09-03 Raja R Harinath <rharinath@novell.com>
9930 * expression.cs (BetterConversion): Don't allow either conversion
9931 to be null. Remove redundant implicit conversion test when 'q ==
9932 null' -- when this function is invoked, we already know that the
9933 implicit conversion exists.
9934 (BetterFunction): Assume that 'best' is non-null. Remove
9935 redundant reimplementation of IsApplicable when 'best' is null.
9936 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9937 number of arguments.
9938 (IsAncestralType): Extract from OverloadResolve.
9939 (OverloadResolve): Make robust to the MethodGroupExpr being
9940 unsorted. Implement all the logic of Section 14.5.5.1, and
9941 support overloading of methods from multiple applicable types.
9942 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9944 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9945 (RealError, Warning): Append type of report to related symbol.
9947 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9949 * enum.cs: Fixed CLS-Compliance checks for enum members.
9950 Error tests cs3008-8.cs, cs3014-8.cs
9952 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9954 Fixed bug #62342, #63102
9955 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9956 like ImplementMethod.
9958 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9960 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9963 2004-09-02 Martin Baulig <martin@ximian.com>
9965 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9966 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9969 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9971 C# 2.0 Static classes implemented
9973 * class.cs (TypeContainer): instance_constructors,
9974 initialized_fields, initialized_static_fields,
9975 default_constructor, base_inteface_types are protected to be
9976 accessible from StaticClass.
9977 (TypeContainer.DefineDefaultConstructor): New virtual method
9978 for custom default constructor generating
9979 (StaticClass): New class to handle "Static classes" feature.
9981 * cs-parser.jay: Handle static keyword on class like instance
9984 * driver.cs: Added "/langversion" command line switch with two
9985 options (iso-1, default).
9987 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9989 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9991 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9993 * delegate.cs: Style.
9995 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9997 * delegate.cs: Add seperate instance expr field for miguel.
9999 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
10001 * PointerArithmetic (Resolve): make sure we are not doing
10002 pointer arith on void*. Also, make sure we are resolved
10003 by not setting eclass until resolve.
10005 All callers: Make sure that PointerArithmetic gets resolved.
10007 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
10009 * ArrayCreation (LookupType): If the type does not resolve
10010 to an array, give an error.
10012 2004-08-27 Marek Safar <marek.safar@seznam.cz>
10014 * statement.cs (Try.Resolve): Fixed bug #64222
10016 2004-08-27 Martin Baulig <martin@ximian.com>
10019 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
10022 2004-08-26 Marek Safar <marek.safar@seznam.cz>
10024 * ecore.cs (Constantify): Get underlying type via
10025 System.Enum.GetUnderlyingType to avoid StackOverflow on the
10026 Windows in special cases.
10028 2004-08-26 Marek Safar <marek.safar@seznam.cz>
10030 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
10031 for obtaining also private methods.
10032 (GetRemoveMethod): Used GetRemoveMethod (true)
10033 for obtaining also private methods.
10035 2004-09-02 Martin Baulig <martin@ximian.com>
10037 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
10038 TypeManager.GetArgumentTypes() rather than calling GetParameters()
10041 2004-08-27 Martin Baulig <martin@ximian.com>
10044 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
10047 2004-08-25 Martin Baulig <martin@ximian.com>
10049 * support.cs (ReflectionParameters..ctor): If this is a generic
10050 method, retrieve and store its type parameters.
10051 (InternalParameters..ctor): Added `TypeParameter[]' argument.
10052 (ReflectionParameters.GenericConstraints): The argument specifies
10053 the type parameter, not the method parameter.
10054 (InternalParameters.GenericConstraints): Likewise.
10056 * generic.cs (TypeParameter.DefineType): Correctly handle
10057 constraints wrt. generic methods in interfaces and their
10060 2004-08-24 Martin Baulig <martin@ximian.com>
10062 * generic.cs (TypeParameter.IsSubclassOf): New public method.
10063 (Constraints.IsSubclassOf): New internal method.
10065 * typemanager.cs (TypeManager.FindMembers): Added special support
10066 for GenericTypeParameterBuilder's.
10067 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
10070 2004-08-24 Martin Baulig <martin@ximian.com>
10073 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
10074 this for accessibility checks.
10075 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
10076 IsNestedFamilyAccessible.
10077 (TypeManager.IsSubclassOf): New method, do what the name actually
10080 2004-08-24 Martin Baulig <martin@ximian.com>
10082 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
10083 as a SimpleName, include the generic arity.
10085 2004-08-24 Martin Baulig <martin@ximian.com>
10087 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
10088 MethodAttributes.HideBySig for operators.
10090 2004-08-23 Martin Baulig <martin@ximian.com>
10092 Back to the old error reporting system :-)
10094 * report.cs (Message): Removed.
10095 (Report.MessageData, ErrorData, WarningData): Removed.
10096 (Report.Error, Warning): Back to the old system.
10098 2004-08-23 Martin Baulig <martin@ximian.com>
10100 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
10102 * class.cs (TypeContainer.ParentContainer): New public virtual
10103 method; replaces the explicit interface implementation.
10104 (ClassPart.ParentContainer): Override.
10106 2004-08-23 Martin Baulig <martin@ximian.com>
10108 * statement.cs (Switch): Added support for constant switches; see
10109 #59428 or test-285.cs.
10111 2004-08-22 Marek Safar <marek.safar@seznam.cz>
10114 * statement.cs (GetEnumeratorFilter): Removed useless
10115 logic because C# specs is strict. GetEnumerator must be
10118 2004-08-22 Martin Baulig <martin@ximian.com>
10120 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10121 a switch and may break, reset the barrier. Fixes #59867.
10123 2004-08-22 Marek Safar <marek.safar@seznam.cz>
10125 CLS-Compliance speed up (~5% for corlib)
10127 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
10128 New method. Tests container for CLS-Compliant names
10130 * class.cs (TypeContainer.VerifyClsName): New method.
10131 Checks whether container name is CLS Compliant.
10132 (Constructor): Implements IMethodData.
10134 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
10135 low-case table for CLS Compliance test.
10136 (MemberCache.VerifyClsParameterConflict): New method.
10137 Checks method parameters for CS3006 error.
10139 * enum.cs (EnumMember): Is derived from MemberCore.
10140 (Enum.VerifyClsName): Optimized for better performance.
10142 2004-08-06 Marek Safar <marek.safar@seznam.cz>
10144 * report.cs: Renamed Error_T to Error and changed all
10147 2004-08-06 Marek Safar <marek.safar@seznam.cz>
10149 * class.cs (TypeContainer.IndexerArrayList): New inner class
10150 container for indexers.
10151 (TypeContainer.DefaultIndexerName): New constant for default
10152 indexer name. Replaced all "Item" with this constant.
10153 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
10155 * typemanager.cs (TypeManager.default_member_ctor): Cache here
10156 DefaultMemberAttribute constructor.
10158 2004-08-05 Martin Baulig <martin@ximian.com>
10160 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
10163 2004-08-05 Marek Safar <marek.safar@seznam.cz>
10165 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
10166 multi platforms problem.
10168 * compiler.csproj: Included shared files.
10170 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10172 Fix bug 60333, 55971 in the more general way
10173 * attribute.cs (Attribute.GetAttributeArgumentExpression):
10174 Added arg_type argument for constant conversion.
10175 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
10177 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10180 * class.cs (TypeContainer ): New inner classes MethodArrayList,
10181 OperatorArrayList, MethodCoreArrayList for typecontainer
10182 containers. Changed class member types to these new types.
10183 (MethodArrayList.DefineMembers): Added test for CS0659.
10185 2004-08-04 Miguel de Icaza <miguel@ximian.com>
10187 * cfold.cs: Synchronize the folding with the code in expression.cs
10188 Binary.DoNumericPromotions for uint operands.
10190 * attribute.cs: Revert patch from Raja, it introduced a regression
10191 while building Blam-1.2.1 (hard to isolate a test case).
10193 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10197 (TypeContainer.Define): Renamed to DefineContainerMembers because of
10199 (MethodCore.parent_method): New member. The method we're overriding
10200 if this is an override method.
10201 (MethodCore.CheckBase): Moved from Method class and made common.
10202 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
10204 (MethodCore.CheckForDuplications): New abstract method. For custom
10205 member duplication search in a container
10206 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
10207 method and its return type.
10208 (Event.conflict_symbol): New member. Symbol with same name in the
10212 (MemberCache.FindMemberWithSameName): New method. The method
10213 is looking for conflict with inherited symbols.
10215 2004-08-04 Martin Baulig <martin@ximian.com>
10217 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10219 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10221 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10223 * report.cs (Message): New enum for better error, warning reference in
10225 (MessageData): New inner abstract class. It generally handles printing of
10226 error and warning messages.
10227 Removed unused Error, Warning, Message methods.
10229 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10231 Fix for cs0592-8.cs test
10233 (Attributable.ValidAttributeTargets): Made public.
10234 (Attribute.ExplicitTarget): New member for explicit target value.
10235 (Attribute.CheckTargets): Now we translate explicit attribute
10236 target to Target here.
10238 2004-08-03 Ben Maurer <bmaurer@ximian.com>
10240 * ecore.cs (MethodGroupExpr): new IsBase property.
10242 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
10244 * delegate.cs (DelegateCreation): store a MethodGroupExpr
10245 rather than an instance expr.
10247 (DelegateCreation.Emit): Use the method group rather than
10248 the instance expression. Also, if you have base.Foo as the
10249 method for a delegate, make sure to emit ldftn, not ldftnvirt.
10251 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
10253 (NewDelegate.DoResolve): Only check for the existance of Invoke
10254 if the method is going to be needed. Use MethodGroupExpr.
10256 (NewDelegate.Emit): Remove, DelegateCreation implements this.
10258 * expression.cs: For pointer arith., make sure to use
10259 the size of the type, not the size of the pointer to
10262 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10265 * class.cs (Class): Added error CS0502 test.
10267 2004-08-03 John Luke <jluke@cfl.rr.com>
10268 Raja R Harinath <rharinath@novell.com>
10271 * attribute.cs (Attribute.complained_before): New flag.
10272 (Attribute.ResolveType, Attribute.Resolve),
10273 (Attribute.DefinePInvokeMethod): Set it.
10274 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
10276 2004-08-03 Martin Baulig <martin@ximian.com>
10278 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10279 use a user-defined operator; we still need to do numeric
10280 promotions in case one argument is a builtin type and the other
10281 one has an implicit conversion to that type. Fixes #62322.
10283 2004-08-18 Martin Baulig <martin@ximian.com>
10285 * class.cs (Method.Define): Use the correct method name when
10286 creating the MethodBuilder for a generic method.
10288 2004-08-17 Martin Baulig <martin@ximian.com>
10290 * generic.cs (Constraints): Support type parameter constraints.
10292 2004-08-16 Martin Baulig <martin@ximian.com>
10294 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
10295 (Token.GENERIC_DIMENSION): New token; this is returned if we
10296 encounter an unbound generic type in a typeof() expression.
10298 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
10299 this token is only generated while parsing a typeof() expression.
10300 (typeof_expression): Removed the old unbound_type hack.
10302 * generic.cs (TypeArguments.IsUnbound): New public property.
10304 * decl.cs (MemberName): Added support for unbound types.
10306 2004-08-14 Martin Baulig <martin@ximian.com>
10309 (TypeManager.IsEqualGenericInstance): New static method.
10310 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
10311 just used to check accessibility, so follow the rules of 26.1.6.
10313 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
10314 ConstructedType instead of a TypeExpression if we have type arguments.
10316 * cs-parser.jay (typeof_expression): Support unbound generic types.
10318 * ecore.cs (UnboundTypeExpression): New public class.
10320 2004-08-12 Martin Baulig <martin@ximian.com>
10322 * typemanager.cs (TypeManager.IsNestedChildOf): Use
10323 TypeManager.IsEqual() rather than `=='.
10325 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
10326 generic instances as well.
10328 2004-08-12 Martin Baulig <martin@ximian.com>
10330 * expression.cs (Invocation.InferType): We can only infer method
10331 type parameters. Fixes #62647.
10333 2004-08-11 Martin Baulig <martin@ximian.com>
10335 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
10336 before resolving the base classes.
10338 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10340 * Makefile: install .mdb file too.
10342 2004-08-05 Martin Baulig <martin@ximian.com>
10344 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
10345 initializer, the current type is just the TypeBuilder, not the
10346 instantiated generic type.
10347 (FieldExpr.IsFieldInitializer): New public property.
10349 2004-08-04 Martin Baulig <martin@ximian.com>
10351 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10353 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10355 2004-08-03 Martin Baulig <martin@ximian.com>
10357 * class.cs (MethodData.Define): If we're an explicit
10358 implementation, remove the generic arity from the type name.
10360 2004-08-03 Martin Baulig <martin@ximian.com>
10362 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10363 use a user-defined operator; we still need to do numeric
10364 promotions in case one argument is a builtin type and the other
10365 one has an implicit conversion to that type. Fixes #62322.
10367 2004-08-02 Martin Baulig <martin@ximian.com>
10369 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
10370 `TypeExpr[]' array.
10371 (TypeContainer.GetClassBases): Return the unexpanded list of
10372 interfaces; we expand them later.
10373 (TypeContainer.DefineType): After creating the TypeBuilder, call
10374 TypeManager.ExpandInterfaces() to get an expanded and resolved
10375 list of interfaces.
10377 * ecore.cs (TypeExpr.GetInterfaces): Removed
10379 * generics.cs (Constraints.InterfaceConstraints): Remove.
10380 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
10381 register the interface constraints.
10384 (TypeManager.AddUserType): Removed the `ifaces' argument.
10385 (TypeManager.AddTypeParameter): Likewise.
10386 (TypeManager.AddUserInterface): Removed, was unused.
10387 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
10388 `TypeExpr[]' array for the interfaces.
10389 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
10390 has been defined, returns a list of the resolved interfaces types.
10391 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
10392 (TypeManager.GetExplicitInterfaces): Likewise.
10394 2004-08-02 Martin Baulig <martin@ximian.com>
10396 * expression.cs (Invocation.EmitCall): If we're invoking a method
10397 on a type parameter, use the new `Constrained' prefix opcode.
10399 2004-08-02 Martin Baulig <martin@ximian.com>
10401 * statement.cs (LocalInfo.Flags): Added `IsThis'.
10402 (LocalInfo.IsThis): New public property.
10403 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
10405 2004-08-01 Martin Baulig <martin@ximian.com>
10407 * class.cs (TypeContainer.GetClassBases): Don't set the default
10408 here since we may get called from GetPartialBases().
10409 (TypeContainer.DefineType): If GetClassBases() didn't return a
10410 parent, use the default one.
10412 2004-07-30 Martin Baulig <martin@ximian.com>
10414 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
10416 * class.cs (SourceMethod): New public class, derive from the
10417 symbol writer's ISourceMethod.
10418 (Method): Use the new symbol writer API.
10420 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
10421 as argument and use the new symbol writer.
10424 (SourceFile): Implement the symbol writer's ISourceFile.
10425 (Location.SymbolDocument): Removed.
10426 (Location.SourceFile): New public property.
10428 * symbolwriter.cs: Use the new symbol writer API.
10430 2004-07-30 Raja R Harinath <rharinath@novell.com>
10432 * Makefile (install-local): Remove. Functionality moved to
10435 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
10437 * Makefile: Install mcs.exe.config file together with mcs.exe.
10438 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
10439 correct runtime version.
10441 2004-07-25 Martin Baulig <martin@ximian.com>
10444 (TypeContainer.RegisterOrder): Removed, this was unused.
10445 (TypeContainer, interface_order): Removed.
10446 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
10447 TypeContainer as argument since we can also be called with a
10448 `PartialContainer' for a partial class/struct/interface.
10449 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
10450 of checking whether we're an `Interface' - we could be a
10451 `PartialContainer'.
10452 (PartialContainer.Register): Override; call
10453 AddClass()/AddStruct()/AddInterface() on our parent.
10455 * cs-parser.jay (interface_member_declaration): Add things to the
10456 `current_container', not the `current_class'.
10458 * rootcontext.cs (RegisterOrder): The overloaded version which
10459 takes an `Interface' was unused, removed.
10461 * typemanager.cs (TypeManager.LookupInterface): Return a
10462 `TypeContainer', not an `Interface'.
10463 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10464 contain a `PartialContainer' for an interface, so check it's
10465 `Kind' to figure out what it is.
10467 2004-07-25 Martin Baulig <martin@ximian.com>
10469 * class.cs (Class.DefaultTypeAttributes): New public constant.
10470 (Struct.DefaultTypeAttributes): Likewise.
10471 (Interface.DefaultTypeAttributes): Likewise.
10472 (PartialContainer.TypeAttr): Override this and add the
10473 DefaultTypeAttributes.
10475 2004-07-25 Martin Baulig <martin@ximian.com>
10477 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10478 we can just use the `Parent' field instead.
10480 2004-07-25 Martin Baulig <martin@ximian.com>
10482 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10484 2004-07-25 Martin Baulig <martin@ximian.com>
10486 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10487 our parts before defining any methods.
10488 (TypeContainer.VerifyImplements): Make this virtual.
10489 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10490 on our PartialContainer.
10492 2004-07-25 Martin Baulig <martin@ximian.com>
10494 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10496 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10497 argument, we can just use the `Parent' field instead.
10500 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10501 (MemberBase.DoDefine): Likewise.
10503 2004-07-24 Martin Baulig <martin@ximian.com>
10505 * decl.cs (MemberCore.Parent): New public field.
10506 (DeclSpace.Parent): Moved to MemberCore.
10508 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10509 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10511 (FieldBase, Field, Operator): Likewise.
10512 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10513 (EventField, Event): Likewise.
10515 2004-07-23 Martin Baulig <martin@ximian.com>
10517 * class.cs (PartialContainer): New public class.
10518 (ClassPart): New public class.
10519 (TypeContainer): Added support for partial classes.
10520 (TypeContainer.GetClassBases): Splitted some of the functionality
10521 out into GetNormalBases() and GetPartialBases().
10523 * cs-tokenizer.cs (Token.PARTIAL): New token.
10524 (Tokenizer.consume_identifier): Added some hacks to recognize
10525 `partial', but only if it's immediately followed by `class',
10526 `struct' or `interface'.
10528 * cs-parser.jay: Added support for partial clases.
10530 2004-07-23 Martin Baulig <martin@ximian.com>
10532 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10533 a `DeclSpace' and also made it readonly.
10534 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10535 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10536 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10538 * cs-parser.jay: Pass the `current_class', not the
10539 `current_container' (at the moment, this is still the same thing)
10540 to a new Method, Property, Event, Indexer or Constructor.
10542 2004-07-23 Martin Baulig <martin@ximian.com>
10544 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10545 and removed the `current_interface' one.
10546 (struct_declaration, class_declaration, interface_declaration):
10547 Set `current_class' to the newly created class/struct/interface;
10548 set their `Bases' and call Register() before parsing their body.
10550 2004-07-23 Martin Baulig <martin@ximian.com>
10552 * class.cs (Kind): New public enum.
10553 (TypeContainer): Made this class abstract.
10554 (TypeContainer.Kind): New public readonly field.
10555 (TypeContainer.CheckDef): New public method; moved here from
10557 (TypeContainer.Register): New public abstract method.
10558 (TypeContainer.GetPendingImplementations): New public abstract
10560 (TypeContainer.GetClassBases): Removed the `is_class' and
10561 `is_iface' parameters.
10562 (TypeContainer.DefineNestedTypes): Formerly known as
10564 (ClassOrStruct): Made this class abstract.
10566 * tree.cs (RootTypes): New public type.
10568 2004-07-20 Martin Baulig <martin@ximian.com>
10570 * tree.cs (Tree.RecordNamespace): Removed.
10571 (Tree.Namespaces): Removed.
10573 * rootcontext.cs (RootContext.IsNamespace): Removed.
10575 * cs-parser.jay (namespace_declaration): Just create a new
10576 NamespaceEntry here.
10578 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10580 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10581 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10582 entry to make sure it runs in the correct runtime version.
10584 2004-07-18 Martin Baulig <martin@ximian.com>
10586 * generic.cs (ConstructedType.CheckConstraints): Improved
10587 constraints checking.
10589 2004-07-18 Martin Baulig <martin@ximian.com>
10591 * expression.cs (Invocation.BetterMethod): Call
10592 TypeManager.TypeToCoreType() on all types and removed my previous
10593 hack; we're already doig the right thing here.
10595 2004-07-17 Martin Baulig <martin@ximian.com>
10597 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10599 2004-07-16 Martin Baulig <martin@ximian.com>
10601 * iterators.cs: Added generics support.
10603 2004-07-16 Martin Baulig <martin@ximian.com>
10605 * iterators.cs: Rewrote this. We're now using one single Proxy
10606 class for both the IEnumerable and the IEnumerator interface and
10607 `Iterator' derives from Class so we can use the high-level API.
10609 * class.cs (TypeContainer.AddIterator): New method.
10610 (TypeContainer.DoDefineType): New protected virtual method, which
10611 is called from DefineType().
10612 (TypeContainer.DoDefineMembers): Call DefineType() and
10613 DefineMembers() on all our iterators.
10614 (TypeContainer.Emit): Call Emit() on all our iterators.
10615 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10617 * codegen.cs (EmitContext.CurrentIterator): New public field.
10619 2004-07-15 Martin Baulig <martin@ximian.com>
10622 (TypeManager.not_supported_exception_type): New type.
10624 2004-07-14 Martin Baulig <martin@ximian.com>
10627 (TypeManager.generic_ienumerable_type): New type.
10628 (TypeManager.generic_ienumerator_type): New type.
10631 (RootContext.interfaces_first_stage): Added
10632 "System.Collections.Generic.IEnumerator`1" and
10633 "System.Collections.Generic.IEnumerable`1".
10635 2004-07-14 Martin Baulig <martin@ximian.com>
10637 * iterators.cs: Use real error numbers.
10639 2004-07-14 Martin Baulig <martin@ximian.com>
10641 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10642 requires this to be a System.Collection.IEnumerable and not a
10643 class implementing that interface.
10644 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10646 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10648 * class.cs: Fixed previous fix, it broke some error tests.
10650 2004-07-12 Martin Baulig <martin@ximian.com>
10652 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10655 2004-07-14 Martin Baulig <martin@ximian.com>
10657 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10658 an exclamation mark (!) for the generic arity to reflect the
10659 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10661 2004-07-13 Martin Baulig <martin@ximian.com>
10663 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10664 specifiers being part of a type argument.
10666 2004-07-13 Martin Baulig <martin@ximian.com>
10668 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10669 name for generic types.
10671 2004-07-13 Martin Baulig <martin@ximian.com>
10673 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10676 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10678 * assign.cs (LocalTemporary): Add new argument: is_address,If
10679 `is_address' is true, then the value that we store is the address
10680 to the real value, and not the value itself.
10682 * ecore.cs (PropertyExpr): use the new local temporary
10683 stuff to allow us to handle X.Y += z (where X is a struct)
10685 2004-07-08 Martin Baulig <martin@ximian.com>
10687 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10688 not always return, just like we're doing in Using.Resolve().
10690 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10692 * cs-parser.jay (fixed_statement): flag this as Pinned.
10694 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10696 * typemanager.cs (TypeManager): Removed MakePinned method, this
10697 mechanism is replaced with the .NET 2.x compatible mechanism of
10698 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10700 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10701 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10702 `IsFixed' property which has a different meaning.
10704 2004-07-02 Raja R Harinath <rharinath@novell.com>
10706 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10707 visible from inside a nested class, not just the names of the
10708 immediately enclosing class.
10709 Fix for bug #60730.
10711 2004-06-24 Raja R Harinath <rharinath@novell.com>
10713 * expression.cs (BetterConversion): Remove buggy special-case
10714 handling of "implicit constant expression conversions". At this
10715 point, we already know that the conversion is possible -- we're
10716 only checking to see which is better.
10718 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10720 * cs-parser.jay: Added error CS0210 test.
10722 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10724 * cs-parser.jay: Added error CS0134 test.
10726 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10729 * cs-parser.jay: Added error CS0145 test.
10731 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10733 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10735 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10737 * expression.cs (StackAlloc.Resolve): The argument may not
10738 be a constant; deal with this case.
10740 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10742 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10743 GetIndexerAttributeValue.
10744 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10746 * class.cs (Indexer.Define): Added error tests for CS0415,
10749 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10751 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10754 2004-06-23 Martin Baulig <martin@ximian.com>
10756 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10757 neither return nor throw, reset the barrier as well. Fixes #60457.
10759 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10761 * class.cs : EventAttributes is now set to None by default.
10762 This fixes bug #60459.
10764 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10767 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10768 Don't throw exception but return null (it's sufficient now).
10770 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10772 * typemanager.cs (GetArgumentTypes): Faster implementation.
10774 2004-06-18 Martin Baulig <martin@ximian.com>
10776 * attribute.cs (Attribute.Resolve): Check whether we're an
10777 EmptyCast which a Constant child. Fixes #60333.
10779 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10781 * statement.cs (EmitCollectionForeach): Account for the fact that
10782 not all valuetypes are in areas which we can take the address of.
10783 For these variables, we store to a temporary variable. Also, make
10784 sure that we dont emit a `callvirt' on a valuetype method.
10786 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10788 * expression.cs (StackAlloc.DoReSolve): Added test for
10789 negative parameter (CS0247).
10791 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10794 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10796 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10799 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10802 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10804 Fix bug #58254 & cs1555.cs, cs1556.cs
10805 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10807 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10809 * cs-parser.jay: Added error CS1669 test for indexers.
10811 2004-06-18 Martin Baulig <martin@ximian.com>
10813 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10814 argument. Fixes #60441.
10816 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10817 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10818 The name needs to have the actual name of the method in order
10819 for other tests (such as the one in OverloadResolve for Invoke
10820 on a delegate) to work. As well, it does not really help
10821 error reporting because the method group had multiple methods.
10822 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10823 Make profiling work.
10825 2004-06-13 Martin Baulig <martin@ximian.com>
10827 * cs-parser.jay: Don't allow generic attributes.
10829 2004-06-13 Martin Baulig <martin@ximian.com>
10831 * class.cs (MemberBase.DoDefineBase): New protected method.
10832 (MemberBase.DoDefine): Compute the `flags' in the new
10833 DoDefineBase() which must be called first.
10834 (Method.Define): Call DoDefineBase() first so we have the flags
10835 when defining the generic method.
10837 * cs-parser.jay (interface_method_declaration): Support generic methods.
10839 2004-06-13 Martin Baulig <martin@ximian.com>
10841 * decl.cs (TypeName): Removed.
10842 (MemberName): Removed TypeName and MemberNow; now we just have
10845 * cs-parser.jay: Don't distinguish between type arguments and type
10846 parameters in the grammar and simplified the rules a bit. The
10847 reduce/reduce conflicts are now gone (except the one we inherited
10850 2004-06-11 Martin Baulig <martin@ximian.com>
10852 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10853 call this twice: for params and varargs methods.
10855 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10858 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10860 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10862 * attribute.cs (Attribute.GetValidTargets): Made public.
10865 (AbstractPropertyEventMethod): New class for better code sharing.
10866 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10868 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10870 2004-06-09 Martin Baulig <martin@ximian.com>
10872 * cs-parser.jay: Removed a reduce/reduce conflict.
10874 2004-06-03 Martin Baulig <martin@ximian.com>
10876 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10877 GetSimpleName() and return a SimpleName.
10879 * ecore.cs (SimpleName.Arguments): New public field.
10880 (SimpleName): Added overloaded ctor which takes an additional
10881 TypeArguments argument.
10882 (SimpleName.SimpleNameResolve): Added support for generic methods.
10883 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10884 formerly in MemberAccess.DoResolve(), but we also need it in
10885 SimpleNameResolve().
10887 * expression.cs (MemberAccess.DoResolve): Use the new
10888 MethodGroupExpr.ResolveGeneric().
10890 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10892 * decl.cs: If possible, use lookuptypedirect here. We can only do
10893 this if there is no `.' after the namespace. Avoids using
10894 LookupType, which does lots of slow processing.
10895 (FindNestedType) New method, does what it says :-).
10896 * namespace.cs: use LookupTypeDirect.
10897 * rootcontext.cs: use membercache, if possible.
10898 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10900 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10903 According to the spec,
10905 In a member access of the form E.I, if E is a single identifier,
10906 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10907 field, property, localvariable, or parameter with the same type as
10908 the meaning of E as a type-name (§3.8), then both possible
10909 meanings of E are permitted.
10911 We did not check that E as a simple-name had the same type as E as
10914 This trivial check gives us 5-7% on bootstrap time.
10916 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10918 * expression.cs (Invocation.OverloadResolve): Avoid the
10919 use of hashtables and boxing here by allocating on demand.
10921 2004-05-30 Martin Baulig <martin@ximian.com>
10923 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10924 we're doing a silent lookup. Don't try to lookup nested types in
10925 TypeManager.object_type (thanks to Ben Maurer).
10927 2004-05-30 Martin Baulig <martin@ximian.com>
10929 Committing a patch from Ben Maurer.
10931 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10933 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10935 * convert.cs: add a trivial cache for overload operator resolution.
10937 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10940 (AttributeTester.GetObsoleteAttribute): Returns instance of
10941 ObsoleteAttribute when type is obsolete.
10944 (TypeContainer.VerifyObsoleteAttribute): Override.
10945 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10946 (MethodCode.VerifyObsoleteAttribute): Override.
10947 (MemberBase.VerifyObsoleteAttribute): Override.
10950 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10951 and report proper error.
10954 (Delegate.VerifyObsoleteAttribute): Override.
10957 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10958 and report proper error.
10959 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10962 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10966 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10967 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10968 Added test for ObsoleteAttribute.
10971 (Catch): Derived from Statement.
10973 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10975 * decl.cs: If possible, use lookuptypedirect here. We can only do
10976 this if there is no `.' after the namespace. Avoids using
10977 LookupType, which does lots of slow processing.
10978 (FindNestedType) New method, does what it says :-).
10979 * namespace.cs: use LookupTypeDirect.
10980 * rootcontext.cs: use membercache, if possible.
10981 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10983 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10986 According to the spec,
10988 In a member access of the form E.I, if E is a single identifier,
10989 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10990 field, property, localvariable, or parameter with the same type as
10991 the meaning of E as a type-name (§3.8), then both possible
10992 meanings of E are permitted.
10994 We did not check that E as a simple-name had the same type as E as
10997 This trivial check gives us 5-7% on bootstrap time.
10999 2004-05-30 Marek Safar <marek.safar@seznam.cz>
11001 Fixed bug #59071 & cs0160.cs
11002 * statement.cs (Try.Resolve): Check here whether order of catch
11003 clauses matches their dependencies.
11005 2004-05-30 Marek Safar <marek.safar@seznam.cz>
11008 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
11011 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
11013 * expression.cs (Invocation.OverloadResolve): Avoid the
11014 use of hashtables and boxing here by allocating on demand.
11016 2004-05-30 Martin Baulig <martin@ximian.com>
11018 * rootcontext.cs (RootContext.LookupType): Don't cache things if
11019 we're doing a silent lookup. Don't try to lookup nested types in
11020 TypeManager.object_type (thanks to Ben Maurer).
11022 2004-05-30 Martin Baulig <martin@ximian.com>
11024 Committing a patch from Ben Maurer.
11026 * rootcontext.cs (RootContext.LookupType): Cache negative results.
11028 2004-05-29 Martin Baulig <martin@ximian.com>
11030 * class.cs (IMethodData.ShouldIgnore): New method.
11032 * typemanager.cs (TypeManager.MethodFlags): Don't take a
11033 `Location' argument, we don't need it anywhere. Use
11034 `IMethodData.ShouldIgnore ()' instead of
11035 `MethodData.GetMethodFlags ()'.
11036 (TypeManager.AddMethod): Removed.
11037 (TypeManager.AddMethod2): Renamed to AddMethod.
11039 2004-05-29 Martin Baulig <martin@ximian.com>
11041 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
11043 * convert.cs (Convert.ImplicitReferenceConversion): If we're
11044 converting from a class type S to an interface type and we already
11045 have an object on the stack, don't box it again. Fixes #52578.
11047 2004-05-29 Martin Baulig <martin@ximian.com>
11049 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
11050 Added support for `params' parameters. Fixes #59267.
11052 2004-05-29 Martin Baulig <martin@ximian.com>
11054 * literal.cs (NullPointer): Provide a private .ctor which sets
11055 `type' to TypeManager.object_type. Fixes #59048.
11057 2004-05-29 Martin Baulig <martin@ximian.com>
11059 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
11060 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
11062 * ecore.cs (EventExpr.instance_expr): Make the field private.
11064 2004-05-26 Marek Safar <marek.safar@seznam.cz>
11066 Fixed bug #50080 & cs0214-2.cs
11067 * expression.cs (Cast.DoResolve): Check unsafe context here.
11069 * statement.cs (Resolve.DoResolve): Likewise.
11071 2004-05-26 Martin Baulig <martin@ximian.com>
11073 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
11075 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
11076 (RootContext.LookupType): Pass down the `silent' flag.
11078 2004-05-25 Martin Baulig <martin@ximian.com>
11081 (MethodGroupExpr.IdenticalTypeName): New public property.
11082 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
11083 expression actually refers to a type.
11085 2004-05-25 Martin Baulig <martin@ximian.com>
11087 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
11088 for #56176 and made it actually work.
11090 2004-05-25 Martin Baulig <martin@ximian.com>
11092 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
11093 (FieldExpr, PropertyExpr): Override and implement
11094 CacheTemporaries. Fixes #52279.
11096 2004-05-25 Miguel de Icaza <miguel@ximian.com>
11098 * location.cs: In the new compiler listing a file twice is a
11099 warning, not an error.
11101 2004-05-24 Martin Baulig <martin@ximian.com>
11103 * enum.cs (Enum.DefineType): For the `BaseType' to be a
11104 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
11106 2004-05-24 Martin Baulig <martin@ximian.com>
11108 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
11109 walking the `using' list. Fixes #53921.
11111 2004-05-24 Martin Baulig <martin@ximian.com>
11113 * const.cs (Const.LookupConstantValue): Added support for
11114 EmptyCast's; fixes #55251.
11116 2004-05-24 Martin Baulig <martin@ximian.com>
11118 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
11119 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
11120 which does the CS0135 check. The reason is that we first need to
11121 check whether the variable actually exists.
11123 2004-05-24 Martin Baulig <martin@ximian.com>
11125 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
11126 than RootContext.LookupType() to find the explicit interface
11127 type. Fixes #58584.
11129 2004-05-24 Raja R Harinath <rharinath@novell.com>
11131 * Makefile: Simplify. Use executable.make.
11132 * mcs.exe.sources: New file. List of sources of mcs.exe.
11134 2004-05-24 Anders Carlsson <andersca@gnome.org>
11138 Use the invariant culture when doing String.Compare for CLS case
11141 2004-05-23 Martin Baulig <martin@ximian.com>
11143 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
11144 don't have any dots. Fixes #52622, added cs0246-8.cs.
11146 * namespace.cs (NamespaceEntry.Lookup): Likewise.
11148 2004-05-23 Marek Safar <marek.safar@seznam.cz>
11150 * class.cs (MemberBase.Define): Reuse MemberType member for
11151 resolved type. Other methods can use it too.
11153 2004-05-23 Martin Baulig <martin@ximian.com>
11155 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
11156 the variable also exists in the current block (otherwise, we need
11157 to report a CS0103). Fixes #58670.
11159 2004-05-23 Martin Baulig <martin@ximian.com>
11161 * flowanalysis.cs (Reachability.Reachable): Compute this
11162 on-the-fly rather than storing it as a field.
11164 2004-05-23 Martin Baulig <martin@ximian.com>
11166 * flowanalysis.cs (Reachability.And): Manually compute the
11167 resulting `barrier' from the reachability.
11169 2004-05-23 Marek Safar <marek.safar@seznam.cz>
11172 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
11173 instance of ObsoleteAttribute when symbol is obsolete.
11176 (IMethodData): Extended interface for ObsoleteAttribute support.
11178 2004-05-22 Marek Safar <marek.safar@seznam.cz>
11180 * attribute.cs: Fix bug #55970
11182 2004-05-22 Marek Safar <marek.safar@seznam.cz>
11186 (GetObsoleteAttribute): New method. Creates the instance of
11188 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
11189 ObsoleteAttribute when member is obsolete.
11190 (AttributeTester.Report_ObsoleteMessage): Common method for
11191 Obsolete error/warning reporting.
11194 (TypeContainer.base_classs_type): New member for storing parent type.
11197 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
11198 for this MemberCore.
11200 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11202 * attribute.cs, const.cs: Fix bug #58590
11204 2004-05-21 Martin Baulig <martin@ximian.com>
11206 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
11207 out parameters if the end of the method is unreachable. Fixes
11210 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11212 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
11213 Hari was right, why extra method.
11215 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11217 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
11219 2004-05-20 Martin Baulig <martin@ximian.com>
11221 * delegate.cs: Convert this file to Unix mode - like the original
11224 2004-05-20 Martin Baulig <martin@ximian.com>
11226 * attribute.cs: Convert this file to Unix mode - like the original
11229 2004-05-19 Marek Safar <marek.safar@seznam.cz>
11231 Fix bug #58688 (MCS does not report error when the same attribute
11234 * attribute.cs (Attribute.Emit): Distinction between null and default.
11236 2004-05-19 Raja R Harinath <rharinath@novell.com>
11238 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
11239 of a top-level attribute without an attribute target.
11240 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
11242 (Attribute.Conditional_GetConditionName),
11243 (Attribute.Obsolete_GetObsoleteMessage): Update.
11244 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
11245 part of ScanForIndexerName.
11246 (Attribute.CanIgnoreInvalidAttribute): New function.
11247 (Attribute.ScanForIndexerName): Move to ...
11248 (Attributes.ScanForIndexerName): ... here.
11249 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
11250 (Attributes.Search): New internal variant that can choose not to
11251 complain if types aren't resolved. The original signature now
11253 (Attributes.GetClsCompliantAttribute): Use internal variant, with
11254 complaints suppressed.
11255 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
11256 only if it not useful.
11257 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
11258 top-level for attributes that are shared between the assembly
11259 and a top-level class.
11260 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
11261 * class.cs: Update to reflect changes.
11262 (DefineIndexers): Fuse loops.
11263 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
11264 a couple more variants of attribute names.
11266 2004-05-18 Marek Safar <marek.safar@seznam.cz>
11268 Fix bug #52585 (Implemented explicit attribute declaration)
11271 (Attributable.ValidAttributeTargets): New abstract method. It gets
11272 list of valid attribute targets for explicit target declaration.
11273 (Attribute.Target): It holds target itself.
11274 (AttributeSection): Removed.
11275 (Attribute.CheckTargets): New method. It checks whether attribute
11276 target is valid for the current element.
11279 (EventProperty): New class. For events that are declared like
11280 property (with add and remove accessors).
11281 (EventField): New class. For events that are declared like field.
11284 * cs-parser.jay: Implemented explicit attribute target declaration.
11286 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
11287 Override ValidAttributeTargets.
11290 (ReturnParameter): Class for applying custom attributes on
11292 (ParameterAtribute): New class. Class for applying custom
11293 attributes on the parameter type.
11295 2004-05-17 Miguel de Icaza <miguel@ximian.com>
11297 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
11300 (Method): Allow UNSAFE here.
11302 * modifiers.cs: Support unsafe reporting.
11304 2004-05-17 Marek Safar <marek.safar@seznam.cz>
11306 * decl.cs: Fix bug #58478.
11308 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11310 * statement.cs: When checking for unreachable code on an EmptyStatement,
11311 set the location. Fixes bug #58488.
11313 2004-05-13 Miguel de Icaza <miguel@ximian.com>
11315 * driver.cs: Add -pkg handling.
11317 From Gonzalo: UseShelLExecute=false
11319 2004-05-12 Marek Safar <marek.safar@seznam.cz>
11322 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
11324 (Attribute.IsClsCompliaceRequired): Moved to base for better
11326 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
11327 when attribute is AttributeUsageAttribute.
11328 (Attribute.GetValidTargets): Simplified.
11329 (Attribute.GetAttributeUsage): New method returns AttributeUsage
11330 attribute for this type.
11331 (Attribute.ApplyAttributes): Method renamed to Emit and make
11333 (GlobalAttributeSection): New class for special handling of global
11334 attributes (assembly, module).
11335 (AttributeSection.Emit): New method.
11337 * class.cs: Implemented Attributable abstract methods.
11338 (MethodCore.LabelParameters): Moved to Parameter class.
11339 (Accessor): Is back simple class.
11340 (PropertyMethod): Implemented Attributable abstract class.
11341 (DelegateMethod): Implemented Attributable abstract class.
11342 (Event): New constructor for disctintion between normal Event
11343 and Event with accessors.
11345 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
11347 * codegen.cs, const.cs, decl.cs, delegate.cs:
11348 (CommonAssemblyModulClass): Implemented Attributable abstract class
11351 * enum.cs: Implement IAttributeSupport interface.
11352 (EnumMember): New class for emum members. Implemented Attributable
11356 (ParameterBase): Is abstract.
11357 (ReturnParameter): New class for easier [return:] attribute handling.
11359 * typemanager.cs: Removed builder_to_attr.
11361 2004-05-11 Raja R Harinath <rharinath@novell.com>
11364 * attribute.cs (Attribute.GetPositionalValue): New function.
11365 * class.cs (TypeContainer.VerifyMembers): New function.
11366 (TypeContainer.Emit): Use it.
11367 (ClassOrStruct): New base class for Class and Struct.
11368 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
11369 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
11371 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
11372 then each non-static field should have a FieldOffset attribute.
11373 Otherwise, none of the fields should have a FieldOffset attribute.
11374 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
11375 and FieldOffset attributes.
11376 * typemanager.cs (TypeManager.struct_layout_attribute_type)
11377 (TypeManager.field_offset_attribute_type): New core types.
11378 (TypeManager.InitCoreTypes): Initialize them.
11380 2004-05-11 Michal Moskal <malekith@pld-linux.org>
11382 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
11383 Return correct type.
11386 2004-05-09 Miguel de Icaza <miguel@ximian.com>
11388 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
11389 be implicitly converted to ulong.
11391 * expression.cs: The logic for allowing operator &, | and ^ worked
11392 was wrong, it worked before because we did not report an error in
11393 an else branch. Fixes 57895.
11395 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
11396 allow volatile fields to be reference types.
11398 2004-05-07 Miguel de Icaza <miguel@ximian.com>
11400 * driver.cs: Add support for /debug-
11402 2004-05-07 Raja R Harinath <rharinath@novell.com>
11404 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
11405 Add a 'complain' parameter to silence errors.
11406 (Attribute.Resolve): Update to changes. Put in sanity check to catch
11407 silently overlooked type-resolutions.
11408 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
11409 to reflect changes.
11410 (Attributes.Search): New function.
11411 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
11412 (Attributes.GetAttributeFullName): Remove hack.
11413 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
11414 Update to reflect changes.
11415 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11416 Use Attributes.Search instead of nested loops.
11418 2004-05-07 Marek Safar <marek.safar@seznam.cz>
11421 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
11422 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
11423 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
11425 * report.cs: (Report.Warning): Renamed to Warning_T because of
11426 parameter collision.
11428 2004-05-05 Raja R Harinath <rharinath@novell.com>
11430 * expression.cs (MemberAccess.ResolveMemberAccess):
11431 Exit with non-zero status after Report.Error.
11432 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
11434 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
11436 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11438 * support.cs: Don't hang when the file is empty.
11440 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11442 * support.cs: In SeekableStreamReader, compute the preamble size of the
11443 underlying stream. Position changes should take into account that initial
11446 2004-05-03 Todd Berman <tberman@sevenl.net>
11448 * driver.cs: remove unused GetSysVersion function.
11450 2004-05-03 Todd Berman <tberman@sevenl.net>
11452 * driver.cs: Remove the hack from saturday, as well as the hack
11453 from jackson (LoadAssemblyFromGac), also adds the CWD to the
11454 link_paths to get that bit proper.
11456 2004-05-01 Todd Berman <tberman@sevenl.net>
11458 * driver.cs: Try a LoadFrom before a Load, this checks the current
11459 path. This is currently a bug in mono that is be fixed, however, this
11460 provides a workaround for now. This will be removed when the bug
11463 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11465 * CryptoConvert.cs: Updated to latest version. Fix issue with
11466 incomplete key pairs (#57941).
11468 2004-05-01 Todd Berman <tberman@sevenl.net>
11470 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11473 2004-04-30 Jackson Harper <jackson@ximian.com>
11475 * codegen.cs: Open keys readonly.
11477 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11479 * typemanager.cs: don't report cyclic struct layout when a struct
11480 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11481 which has 2 Pango.Rectangle fields.
11483 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11485 * expression.cs: Handle IntPtr comparisons with IL code
11486 rather than a method call.
11488 2004-04-29 Martin Baulig <martin@ximian.com>
11490 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11491 the list of PropertyInfo's in class hierarchy and find the
11492 accessor. Fixes #56013.
11494 2004-04-29 Martin Baulig <martin@ximian.com>
11496 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11498 2004-04-29 Martin Baulig <martin@ximian.com>
11500 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11502 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11504 2004-04-29 Martin Baulig <martin@ximian.com>
11506 * class.cs (ConstructorInitializer.Resolve): Check whether the
11507 parent .ctor is accessible. Fixes #52146.
11509 2004-04-29 Martin Baulig <martin@ximian.com>
11511 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11513 * statement.cs (Using.EmitLocalVariableDecls): Use
11514 TypeManager.idisposable_type, not typeof (IDisposable).
11515 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11517 2004-04-29 Martin Baulig <martin@ximian.com>
11519 * class.cs (Event.Define): Don't emit the field and don't set
11520 RTSpecialName and SpecialName for events on interfaces. Fixes
11523 2004-04-29 Raja R Harinath <rharinath@novell.com>
11525 Refactor Attribute.ApplyAttributes.
11526 * attribute.cs (Attributable): New base class for objects that can
11527 have Attributes applied on them.
11528 (Attribute): Make AttributeUsage fields public.
11529 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11530 (Attribute.IsInternalCall): New property.
11531 (Attribute.UsageAttr): Convert to a public read-only property.
11532 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11533 (Attribute.ResolveType, Attribute.Resolve)
11534 (Attribute.ScanForIndexerName): Update to reflect changes.
11535 (Attribute.CheckAttributeTarget): Re-format.
11536 (Attribute.ApplyAttributes): Refactor, to various
11537 Attributable.ApplyAttributeBuilder methods.
11538 * decl.cs (MemberCore): Make Attributable.
11539 * class.cs (Accessor): Make Attributable.
11540 (MethodData.ApplyAttributes): Use proper attribute types, not
11542 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11543 (TypeContainer.ApplyAttributeBuilder)
11544 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11545 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11546 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11547 (Operator.ApplyAttributeBuilder): New factored-out methods.
11548 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11549 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11550 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11551 * parameter.cs (ParameterBase): New Attributable base class
11552 that can also represent Return types.
11553 (Parameter): Update to the changes.
11555 2004-04-29 Jackson Harper <jackson@ximian.com>
11557 * driver.cs: Prefer the corlib system version when looking for
11558 assemblies in the GAC. This is still a hack, but its a better hack
11561 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11563 * decl.cs, enum.cs: Improved error 3005 reporting.
11565 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11566 (related_symbols): New private member for list of symbols
11567 related to reported error/warning.
11569 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11571 2004-04-29 Martin Baulig <martin@ximian.com>
11573 * ecore.cs (Expression.Constantify): If we're an enum and
11574 TypeManager.TypeToCoreType() doesn't give us another type, use
11575 t.UnderlyingSystemType. Fixes #56178.
11577 2004-04-29 Martin Baulig <martin@ximian.com>
11579 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11580 interfaces and for each interface, only add members directly
11581 declared in that interface. Fixes #53255.
11583 2004-04-28 Martin Baulig <martin@ximian.com>
11585 * expression.cs (ConditionalLogicalOperator): Use a temporary
11586 variable for `left' to avoid that we evaluate it more than once;
11589 2004-04-28 Martin Baulig <martin@ximian.com>
11591 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11594 2004-04-28 Martin Baulig <martin@ximian.com>
11596 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11599 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11600 whether the type is not void (CS1547).
11602 2004-04-28 Martin Baulig <martin@ximian.com>
11604 * expression.cs (Unary.DoResolveLValue): Override this and report
11605 CS0131 for anything but Operator.Indirection.
11607 2004-04-28 Martin Baulig <martin@ximian.com>
11609 Committing a patch from Ben Maurer; see bug #50820.
11611 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11614 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11617 2004-04-28 Martin Baulig <martin@ximian.com>
11619 Committing a patch from Ben Maurer; see bug #50820.
11621 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11624 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11627 2004-04-28 Martin Baulig <martin@ximian.com>
11629 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11630 (Block.AddLabel): Call DoLookupLabel() to only search in the
11633 2004-04-28 Martin Baulig <martin@ximian.com>
11635 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11636 comparing StringConstants and NullLiterals in Equality and Inequality.
11638 2004-04-28 Jackson Harper <jackson@ximian.com>
11640 * driver.cs: Attempt to load referenced assemblies from the
11641 GAC. This is the quick and dirty version of this method that
11642 doesnt take into account versions and just takes the first
11643 canidate found. Will be good enough for now as we will not have more
11644 then one version installed into the GAC until I update this method.
11646 2004-04-28 Martin Baulig <martin@ximian.com>
11648 * typemanager.cs (TypeManager.CheckStructCycles): New public
11649 static method to check for cycles in the struct layout.
11651 * rootcontext.cs (RootContext.PopulateTypes): Call
11652 TypeManager.CheckStructCycles() for each TypeContainer.
11653 [Note: We only need to visit each type once.]
11655 2004-04-28 Martin Baulig <martin@ximian.com>
11657 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11659 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11660 success and added `out object value'. Use a `bool resolved' field
11661 to check whether we've already been called rather than
11662 `ConstantValue != null' since this breaks for NullLiterals.
11664 2004-04-28 Raja R Harinath <rharinath@novell.com>
11666 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11667 setting of this flag, since the 'set' method may be non-public.
11669 2004-04-28 Raja R Harinath <rharinath@novell.com>
11671 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11672 check on current_vector.Block.
11674 2004-04-27 Martin Baulig <martin@ximian.com>
11676 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11677 a field initializer. Fixes #56459.
11679 2004-04-27 Martin Baulig <martin@ximian.com>
11681 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11682 we're not attempting to use an indexer. Fixes #52154.
11684 2004-04-27 Martin Baulig <martin@ximian.com>
11686 * statement.cs (Return): Don't create a return label if we don't
11687 need it; reverts my change from January 20th. Thanks to Ben
11690 2004-04-27 Martin Baulig <martin@ximian.com>
11692 According to the spec, `goto' can only leave a nested scope, but
11695 * statement.cs (Block.LookupLabel): Only lookup in the current
11696 block, don't recurse into parent or child blocks.
11697 (Block.AddLabel): Check in parent and child blocks, report
11698 CS0140/CS0158 if we find a duplicate.
11699 (Block): Removed this indexer for label lookups.
11700 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11701 this already does the error reporting for us.
11704 (FlowBranching.UsageVector.Block): New public variable; may be null.
11705 (FlowBranching.CreateSibling): Added `Block' argument.
11706 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11707 label for the target of a `goto' and check whether we're not
11708 leaving a `finally'.
11710 2004-04-27 Martin Baulig <martin@ximian.com>
11712 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11713 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11716 2004-04-27 Martin Baulig <martin@ximian.com>
11718 * statement.cs (Block.AddLabel): Also check for implicit blocks
11719 and added a CS0158 check.
11721 2004-04-27 Martin Baulig <martin@ximian.com>
11723 * flowanalysis.cs (FlowBranchingLoop): New class.
11724 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11725 UsageVector's instead of an ArrayList.
11726 (FlowBranching.Label): Likewise.
11727 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11728 (FlowBranching.AddBreakVector): New method.
11730 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11732 * attribute.cs: Small regression fix: only convert the type if we
11733 the type is different, fixes System.Drawing build.
11735 2004-04-27 Martin Baulig <martin@ximian.com>
11737 * attribute.cs (Attribute.Resolve): If we have a constant value
11738 for a named field or property, implicity convert it to the correct
11741 2004-04-27 Raja R Harinath <rharinath@novell.com>
11743 * statement.cs (Block.Block): Implicit blocks share
11744 'child_variable_names' fields with parent blocks.
11745 (Block.AddChildVariableNames): Remove.
11746 (Block.AddVariable): Mark variable as "used by a child block" in
11747 every surrounding block.
11748 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11749 been used in a child block, complain about violation of "Invariant
11750 meaning in blocks" rule.
11751 * cs-parser.jay (declare_local_variables): Don't use
11752 AddChildVariableNames.
11753 (foreach_statement): Don't create an implicit block: 'foreach'
11754 introduces a scope.
11756 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11758 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11759 converting from 0L to ulong. Fixes 57522.
11761 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11763 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11764 derived class hides via 'new' keyword field from base class (test-242.cs).
11765 TODO: Handle this in the more general way.
11767 * class.cs (CheckBase): Ditto.
11769 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11771 * decl.cs (caching_flags): New member for storing cached values
11773 (MemberCore.Flags): New enum where bit flags for caching_flags
11775 (MemberCore.cls_compliance): Moved to caching_flags.
11776 (DeclSpace.Created): Moved to caching_flags.
11778 * class.cs: Use caching_flags instead of DeclSpace.Created
11780 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11782 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11783 if we are only a derived class, not a nested class.
11785 * typemanager.cs: Same as above, but do this at the MemberLookup
11786 level (used by field and methods, properties are handled in
11787 PropertyExpr). Allow for the qualified access if we are a nested
11790 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11792 * class.cs: Refactoring.
11793 (IMethodData): New inteface; Holds links to parent members
11794 to avoid member duplication (reduced memory allocation).
11795 (Method): Implemented IMethodData interface.
11796 (PropertyBase): New inner classes for get/set methods.
11797 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11798 (Event): New inner classes for add/remove methods.
11799 (Event.DelegateMethod): Implemented IMethodData interface.
11801 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11802 EmitContext (related to class.cs refactoring).
11804 2004-04-21 Raja R Harinath <rharinath@novell.com>
11806 * delegate.cs (Delegate.VerifyApplicability): If the number of
11807 arguments are the same as the number of parameters, first try to
11808 verify applicability ignoring any 'params' modifier on the last
11812 2004-04-08 Martin Baulig <martin@ximian.com>
11814 Merged latest changes into gmcs. Please keep this comment in
11815 here, it makes it easier for me to see what changed in MCS since
11816 the last time I merged.
11818 2004-04-16 Raja R Harinath <rharinath@novell.com>
11820 * class.cs (TypeContainer.AddIndexer): Use
11821 'ExplicitInterfaceName' to determine if interface name was
11822 explicitly specified. 'InterfaceType' is not initialized at this time.
11823 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11824 Indexers array is already in the required order. Initialize
11825 'IndexerName' only if there are normal indexers.
11826 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11827 (TypeContainer.Emit): Emit DefaultMember attribute only if
11828 IndexerName is initialized.
11831 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11833 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11836 2004-04-15 Raja R Harinath <rharinath@novell.com>
11838 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11842 * attribute.cs (Attribute.Resolve): Check for duplicate named
11846 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11848 * iterators.cs (MarkYield): track whether we are in an exception,
11849 and generate code accordingly. Use a temporary value to store the
11850 result for our state.
11852 I had ignored a bit the interaction of try/catch with iterators
11853 since their behavior was not entirely obvious, but now it is
11854 possible to verify that our behavior is the same as MS .NET 2.0
11858 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11860 * iterators.cs: Avoid creating temporaries if there is no work to
11863 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11864 Enumerations, use TypeManager.EnumToUnderlying and call
11867 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11870 (This.Emit): Use EmitContext.EmitThis to emit our
11873 (This.EmitAssign): Ditto.
11875 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11876 codepaths, we will move all the functionality into
11879 (FieldExpr.EmitAssign): Ditto.
11881 This fixes several hidden bugs that I uncovered while doing a code
11882 review of this today.
11884 * codegen.cs (EmitThis): reworked so the semantics are more clear
11885 and also support value types "this" instances.
11887 * iterators.cs: Changed so that for iterators in value types, we
11888 do not pass the value type as a parameter.
11890 Initialization of the enumerator helpers is now done in the caller
11891 instead of passing the parameters to the constructors and having
11892 the constructor set the fields.
11894 The fields have now `assembly' visibility instead of private.
11896 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11898 * expression.cs (Argument.Resolve): Check if fields passed as ref
11899 or out are contained in a MarshalByRefObject.
11901 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11902 another compiler type.
11904 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11906 * class.cs (Indexer.Define): use the new name checking method.
11907 Also, return false on an error.
11908 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11909 (is_identifier_[start/part]_character): make static.
11911 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11913 * expression.cs (Binary.ResolveOperator): Do no append strings
11914 twice: since we can be invoked more than once (array evaluation)
11915 on the same concatenation, take care of this here. Based on a fix
11916 from Ben (bug #56454)
11918 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11920 * codegen.cs: Fix another case where CS1548 must be reported (when
11921 delay-sign isn't specified and no private is available #56564). Fix
11922 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11923 error when MCS is used on the MS runtime and we need to delay-sign
11924 (which seems unsupported by AssemblyBuilder - see #56621).
11926 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11928 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11929 (TypeManager.ComputeNamespaces): Faster implementation for
11932 * compiler.csproj: Updated AssemblyName to mcs.
11934 2004-05-11 Jackson Harper <jackson@ximian.com>
11936 * Makefile: Preserve MONO_PATH
11938 2004-05-11 Jackson Harper <jackson@ximian.com>
11940 * Makefile: Use mono and mcs to build gmcs
11942 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11944 * codegen.cs: Add patch from Robert Shade
11945 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11948 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11950 * CryptoConvert.cs: Updated to latest version. Fix issue with
11951 incomplete key pairs (#57941).
11953 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11955 * codegen.cs: Fix another case where CS1548 must be reported (when
11956 delay-sign isn't specified and no private is available #56564). Fix
11957 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11958 error when MCS is used on the MS runtime and we need to delay-sign
11959 (which seems unsupported by AssemblyBuilder - see #56621).
11961 2004-04-29 Jackson Harper <jackson@ximian.com>
11963 * Makefile: Set MONO_PATH to use the bootstrap corlib
11964 * driver.cs: Check the GAC for referenced assemblies.
11966 2004-04-29 Martin Baulig <martin@ximian.com>
11968 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11970 2004-04-07 Martin Baulig <martin@ximian.com>
11972 * expression.cs (Binary.ResolveOperator): Added special case for
11973 Equality/Inequality between a type parameter and a null literal.
11975 2004-04-07 Martin Baulig <martin@ximian.com>
11977 * convert.cs: Check null literal -> type parameter conversions.
11979 2004-04-07 Martin Baulig <martin@ximian.com>
11981 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11982 `class' and `struct' constraints.
11984 2004-04-07 Martin Baulig <martin@ximian.com>
11986 * generic.cs (SpecialConstraint): New public enum.
11987 (Constraints.Resolve): Added support for the `class' and `struct'
11990 * cs-parser.jay (type_parameter_constraint): Added support for the
11991 `class' and `struct' constraints.
11993 2004-04-07 Martin Baulig <martin@ximian.com>
11995 * support.cs (GenericConstraints): Replaced `Types' by
11996 `ClassConstraint' and `InterfaceConstraints'; added
11997 `HasClassConstraint'.
11999 2004-04-07 Martin Baulig <martin@ximian.com>
12002 (Constraints.InterfaceConstraints): New public property.
12003 (Constraints.Types): Make this property public
12004 (TypeParameter): Implement IMemberContainer.
12005 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
12006 instead of a TypeBuilder/MethodBuilder; pass the interface
12007 constraints to TypeManager.AddTypeParameter().
12008 (TypeParameter.DefineType): Just take an EmitContext and no
12009 TypeBuilder/MethodBuilder. Use the new public API.
12011 * typemanager.cs (TypeManager.AddTypeParameter): Added
12012 `TypeExpr[]' argument; add the interfaces to the
12013 `builder_to_ifaces' hash.
12014 (TypeManager.LookupMemberContainer): For
12015 GenericTypeParameterBuilders, get the TypeParameter from the
12016 `builder_to_type_param'.
12017 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
12018 the TypeParameter and call FindMembers on it.
12020 2004-04-07 Martin Baulig <martin@ximian.com>
12023 (MethodCore.GenericMethod): Moved this field here from Method.
12024 (MethodCore.IsDuplicateImplementation): Take the number of type
12025 parameters into account if we're a generic method.
12027 * expression.cs (Invocation.InferTypeArguments): Don't return true
12028 if `arguments' is null; we still need to check whether we actually
12029 don't need to infer anything in this case.
12030 (MemberAccess): Merged the functionality from GenericMemberAccess
12033 * generic.cs (GenericMemberAccess): Removed.
12035 2004-04-05 Martin Baulig <martin@ximian.com>
12037 * decl.cs (MemberCore): For generic classes, interfaces and
12038 structs, `Name' now includes the number of type parameters
12039 ("Stack!1.Node!1").
12040 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
12041 encode the number of type arguments in the type name.
12043 * expression.cs (Expression.MemberLookup): Removed the
12044 `num_type_args' argument; we now encode the number of type
12045 arguments in the type name.
12047 * ecore.cs (SimpleName): Encode the number of type arguments in
12048 the type name itself.
12050 * generic.cs (ConstructedType): Likewise.
12052 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
12053 `MemberName'; we now include the number of type parameters in the
12056 * typemanager.cs (TypeManager.CheckGeneric): Removed.
12057 (TypeManager.MemberLookup): Removed the
12058 `num_type_args' argument; we now encode the number of type
12059 arguments in the type name.
12061 2004-04-03 Martin Baulig <martin@ximian.com>
12063 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
12064 (MemberCore.MemberName): Moved here from MemberBase.
12065 (DeclSpace.SetParameterInfo): Just take the constraints as an
12066 ArrayList; we already have the type parameters in our
12067 `MemberName'; also do the CS0080 reporting here.
12069 * cs-parser.jay (struct_declaration): Use `member_name' instead of
12070 `IDENTIFIER opt_type_parameter_list'; when constructing our
12071 `MemberName', it'll already include our type parameters.
12072 (class_declaration, interface_declaration): Likewise.
12073 (delegate_declaration): Likewise.
12074 (MakeName): Take a MemberName and return a MemberName.
12075 The following two changes are required to avoid shift/reduce conflicts:
12076 (member_name): Don't include a TypeName anymore; ie. this is now
12077 just 'IDENTIFIER opt_type_parameter_list'.
12078 (property_declaration, event_declaration): Use a
12079 `namespace_or_type_name' instead of a `member_name'.
12081 2004-04-03 Martin Baulig <martin@ximian.com>
12083 * decl.cs (MemberName): Renamed to `TypeName' and created a new
12084 `MemberName' class.
12085 (TypeName): Formerly known as MemberName.
12087 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
12088 instead of a `MemberName'.
12090 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
12091 (member_name): New rule; create a MemberName.
12093 2004-04-02 Martin Baulig <martin@ximian.com>
12095 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
12096 (CS0305 and CS0308).
12098 2004-04-02 Martin Baulig <martin@ximian.com>
12100 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
12101 support for nested types.
12103 2004-04-02 Martin Baulig <martin@ximian.com>
12105 * ecore.cs (IAlias): New public interface.
12106 (TypeExpr, TypeExpression): Implement IAlias.
12107 (TypeAliasExpression): New public class.
12109 * namespace.cs (Namespace): Implement IAlias.
12110 (Namespace.Lookup): Return an IAlias instead on an object.
12111 (Namespace.DefineName): Take an IAlias instead of an object.
12112 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
12114 (NamespaceEntry.UsingAlias): Take a Membername instead of an
12116 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
12118 (NamespaceEntry.Lookup): Likewise.
12120 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
12123 * decl.cs (DeclSpace): Implement IAlias.
12124 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
12126 * generic.cs (ConstructedType): Improved error checking.
12128 2004-04-02 Martin Baulig <martin@ximian.com>
12130 * convert.cs: Added type parameter conversions.
12133 (UnboxCast.Emit): Emit an `unbox.any' for type params.
12134 (ClassCast.Emit): If the source type is a type parameter, box it.
12135 If the target type is a type parameter, emit an `unbox.any'
12136 instead of a `classcast'.1
12138 2004-04-01 Martin Baulig <martin@ximian.com>
12140 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
12142 2004-04-01 Martin Baulig <martin@ximian.com>
12144 * generic.cs (ConstructedType.CheckConstraints): Use
12145 Convert.ImplicitStandardConversionExists(); user-defined implicit
12146 conversions are not allowed according to the spec.
12148 2004-03-30 Martin Baulig <martin@ximian.com>
12150 * expression.cs (New): Added support for type parameters.
12153 (TypeManager.activator_type): New public static field.
12154 (TypeManager.activator_create_instance): Likewise.
12156 2004-03-30 Martin Baulig <martin@ximian.com>
12158 * typemanager.cs (TypeManager.HasConstructorConstraint): New
12161 2004-03-30 Martin Baulig <martin@ximian.com>
12163 * generic.cs (ConstructedType.CheckConstraints): Actually follow
12164 the spec here: the argument type must be convertible to the
12167 2004-03-30 Martin Baulig <martin@ximian.com>
12170 (TypeParameter.Define, TypeParameter.DefineMethod): Call
12171 TypeManager.AddTypeParameter().
12172 (ConstructedType.CheckConstraints): Re-enable this and actually
12173 check whether we have a constructor constraint.
12176 (TypeManager.builder_to_type_param): New static field.
12177 (TypeManager.AddTypeParameter): New static method.
12178 (TypeManager.LookupTypeParameter): New public method.
12180 2004-03-30 Martin Baulig <martin@ximian.com>
12182 * generic.cs (TypeParameter.DefineType): Return a boolean and use
12183 the new API to actually define the constructor constraint.
12186 (TypeManager.new_constraint_attr_type): New static field.
12187 (TypeManager.InitCoreTypes): Initialize it.
12189 2004-03-30 Martin Baulig <martin@ximian.com>
12191 * generic.cs (Constraints): Completed error checking, use correct
12194 2004-03-29 Martin Baulig <martin@ximian.com>
12196 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
12198 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12199 public version which takes a `ParameterData pd' instead of an
12202 2004-03-29 Martin Baulig <martin@ximian.com>
12204 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
12207 2004-03-29 Martin Baulig <martin@ximian.com>
12209 * expression.cs (Argument.ResolveMethodGroup): If we're a
12210 ConstructedType, call GetMemberAccess() on it.
12212 2004-03-29 Martin Baulig <martin@ximian.com>
12214 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
12215 (MethodCore.CheckGenericOverride): When overriding a generic
12216 method, check whether the constraints match.
12218 * support.cs (GenericConstraints): New public interface.
12219 (ParameterData.GenericConstraints): New public method.
12221 * parameter.cs (Parameter.Resolve): Check whether we're a generic
12222 method parameter and compute our constraints if appropriate.
12223 (Parameter.GenericConstraints): New public property.
12225 * generic.cs (Constraints): Implement GenericConstraints.
12227 2004-03-29 Martin Baulig <martin@ximian.com>
12229 * decl.cs (MemberCache.FindMemberToOverride): Use
12230 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
12232 2004-03-29 Martin Baulig <martin@ximian.com>
12234 * generic.cs (GenericMethod.Define): Resolve our type parameters.
12236 2004-03-29 Martin Baulig <martin@ximian.com>
12238 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
12239 not allowed on non-generic declarations").
12241 2004-03-29 Martin Baulig <martin@ximian.com>
12243 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12244 public version of this method.
12246 * class.cs (MethodCore.IsDuplicateImplementation): Use
12247 Invocation.InferTypeArguments() to check this.
12249 2004-03-29 Martin Baulig <martin@ximian.com>
12251 * convert.cs: Use TypeManager.IsDelegateType() instead of
12252 comparing types correctly.
12254 2004-03-29 Martin Baulig <martin@ximian.com>
12256 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
12257 types directly to make it work for generic instances.
12259 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
12261 2004-03-29 Martin Baulig <martin@ximian.com>
12263 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
12264 support for arrays.
12266 2004-03-24 Martin Baulig <martin@ximian.com>
12268 * decl.cs (DeclSpace.FindType): Also use
12269 TypeManager.CheckGeneric() for types from the using clauses.
12271 2004-03-23 Martin Baulig <martin@ximian.com>
12273 * expression.cs (Invocation.OverloadResolve): Added `bool
12274 may_fail' argument and use it instead of the Location.IsNull() hack.
12276 2004-03-23 Martin Baulig <martin@ximian.com>
12278 * expression.cs (Invocation.InferType): Use correct type inference
12281 2004-03-23 Martin Baulig <martin@ximian.com>
12283 * ecore.cs (MethodGroupExpr.Name): Use
12284 TypeManager.CSharpSignature() instead of just the name.
12286 * expression.cs (Invocation.OverloadResolve): Provide better error
12288 (Invocation.DoResolve): OverloadResolve() never returns null
12289 without reporting an error, so removed the error -6 reporting here.
12291 2004-03-23 Martin Baulig <martin@ximian.com>
12293 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
12296 * cs-parser.jay (delegate_declaration): Support generic delegates.
12298 * delegate.cs: Support generic delegates.
12300 2004-03-22 Martin Baulig <martin@ximian.com>
12302 * expression.cs (Invocation.InferParamsTypeArguments): New static
12303 method; does type inference for params arguments.
12305 2004-03-21 Martin Baulig <martin@ximian.com>
12307 * typemanager.cs (TypeManager.IsGenericMethod): New public static
12308 method; checks whether a method is a generic method.
12310 * expression.cs (Invocation.InferTypeArguments): New static method;
12311 infer type arguments for generic method invocation.
12313 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
12314 property; we set this to true if we're resolving a generic method
12315 invocation and the user specified type arguments, ie. we're not
12316 doing type inference.
12318 2004-03-20 Martin Baulig <martin@ximian.com>
12320 * class.cs (MethodData.DeclaringType): New public property.
12321 (MethodData.Define): Set DeclaringType here.
12322 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
12323 instead of OperatorMethodBuilder.DeclaringType.
12325 2004-03-20 Martin Baulig <martin@ximian.com>
12327 * cs-tokenizer.cs (xtoken): Return a special
12328 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
12330 * cs-parser.jay (default_value_expression): Switch to the new
12333 2004-03-19 Martin Baulig <martin@ximian.com>
12335 * decl.cs (MemberName): New class. We use this to "construct"
12336 namespace_or_type_name's.
12338 * generics.cs (TypeArguments.GetDeclarations): New public method;
12339 returns the type arguments as a string[] and reports a CS0081 if
12340 one of them is not an identifier.
12342 * class.cs (MemberBase): The .ctor now takes the name as a
12343 MemberName instead of a string.
12344 (MemberBase.ExplicitInterfaceName): Changed type from string to
12346 (MemberBase.DoDefine): If we're an explicit implementation, the
12347 InterfaceType may be a generic instance.
12349 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
12350 (namespace_name): Call MemberName.GetName () to transform the
12351 MemberName into a string and ensure we don't have any type
12353 (type_name): Call MemberName.GetTypeExpression() to transfrom the
12354 MemberName into an expression.
12355 (method_header): Use namespace_or_type_name instead of member_name.
12357 2004-04-07 Miguel de Icaza <miguel@ximian.com>
12359 * rootcontext.cs: Add new types to the boot resolution.
12361 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
12362 MulticastDelegate is not allowed.
12364 * typemanager.cs: Add new types to lookup: System.TypedReference
12367 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
12368 check for TypedReference or ArgIterator, they are not allowed.
12370 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
12371 makes us properly catch 1510 in some conditions (see bug 56016 for
12374 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
12376 * CryptoConvert.cs: update from corlib version
12379 2004-04-05 Miguel de Icaza <miguel@ximian.com>
12381 * class.cs (Indexer.Define): Check indexername declaration
12383 2004-04-05 Marek Safar <marek.safar@seznam.cz>
12385 * attribute.cs (IsClsCompliant): Fixed problem with handling
12386 all three states (compliant, not-compliant, undetected).
12388 2004-03-30 Marek Safar <marek.safar@seznam.cz>
12390 * attribute.cs (Attribute): Location is now public.
12391 (Resolve): Store resolved arguments (pos_values) in attribute class.
12392 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
12393 (GetClsCompliantAttributeValue): New method that gets
12394 CLSCompliantAttribute value.
12395 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
12396 if exists else null.
12397 (AttributeTester): New class for CLS-Compliant verification routines.
12399 * class.cs (Emit): Add CLS-Compliant verification.
12400 (Method.GetSignatureForError): Implemented.
12401 (Constructor.GetSignatureForError): Implemented
12402 (Constructor.HasCompliantArgs): Returns if constructor has
12403 CLS-Compliant arguments.
12404 (Constructor.Emit): Override.
12405 (Construcor.IsIdentifierClsCompliant): New method; For constructors
12406 is needed to test only parameters.
12407 (FieldBase.GetSignatureForError): Implemented.
12408 (TypeContainer): New member for storing base interfaces.
12409 (TypeContainer.FindMembers): Search in base interfaces too.
12411 * codegen.cs (GetClsComplianceAttribute): New method that gets
12412 assembly or module CLSCompliantAttribute value.
12413 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
12415 (ModuleClass.Emit): Add error 3012 test.
12417 * const.cs (Emit): Override and call base for CLS-Compliant tests.
12419 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
12420 state for all decl types.
12421 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
12422 if CLS-Compliant tests are required.
12423 (IsClsCompliaceRequired): New method. Analyze whether code
12424 must be CLS-Compliant.
12425 (IsExposedFromAssembly): New method. Returns true when MemberCore
12426 is exposed from assembly.
12427 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
12428 value or gets cached value.
12429 (HasClsCompliantAttribute): New method. Returns true if MemberCore
12430 is explicitly marked with CLSCompliantAttribute.
12431 (IsIdentifierClsCompliant): New abstract method. This method is
12432 used to testing error 3005.
12433 (IsIdentifierAndParamClsCompliant): New method. Common helper method
12434 for identifier and parameters CLS-Compliant testing.
12435 (VerifyClsCompliance): New method. The main virtual method for
12436 CLS-Compliant verifications.
12437 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
12438 null. I don't know why is null (too many public members !).
12439 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
12440 and get value of first CLSCompliantAttribute that found.
12442 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
12443 (VerifyClsCompliance): Override and add extra tests.
12445 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
12446 clscheck- disable CLS-Compliant verification event if assembly is has
12447 CLSCompliantAttribute(true).
12449 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
12450 ApllyAttribute is now called in emit section as in the other cases.
12451 Possible future Emit integration.
12452 (IsIdentifierClsCompliant): New override.
12453 (VerifyClsCompliance): New override.
12454 (GetEnumeratorName): Returns full enum name.
12456 * parameter.cs (GetSignatureForError): Implemented.
12458 * report.cs (WarningData): New struct for Warning message information.
12459 (LocationOfPreviousError): New method.
12460 (Warning): New method. Reports warning based on the warning table.
12461 (Error_T): New method. Reports error based on the error table.
12463 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12464 verifications are done here.
12466 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12468 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12469 CLSCompliantAttribute.
12470 (all_imported_types): New member holds all imported types from other
12472 (LoadAllImportedTypes): New method fills static table with exported types
12473 from all referenced assemblies.
12474 (Modules): New property returns all assembly modules.
12476 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12478 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12479 throwing a parser error.
12481 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12482 which removes the hardcoded get_/set_ prefixes for properties, as
12483 IL allows for the properties to be named something else.
12487 * expression.cs: Do not override operand before we know if it is
12488 non-null. Fix 56207
12490 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12492 * typemanager.cs: support for pinned variables.
12494 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12496 * decl.cs, typemanager.cs: Avoid using an arraylist
12497 as a buffer if there is only one result set.
12499 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12501 * expression.cs: Make sure you cant call a static method
12502 with an instance expression, bug #56174.
12504 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12506 * class.cs (IsDuplicateImplementation): Improve error reporting to
12507 flag 663 (method only differs in parameter modifier).
12509 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12510 in preprocessor directives.
12512 * location.cs (LookupFile): Allow for the empty path.
12514 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12515 better approach for some of that patch, but its failing with the
12516 CharSet enumeration. For now try/catch will do.
12518 * typemanager.cs: Do not crash if a struct does not have fields.
12521 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12523 * expression.cs: cs0213, cant fix a fixed expression.
12526 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12528 * cs-parser.jay: detect invalid embeded statements gracefully.
12531 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12533 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12536 the invocation type may not be a subclass of the tye of the item/
12537 The type of the item must be a subclass of the invocation item.
12542 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12544 * attribute.cs: Added methods to get a string and a bool from an
12545 attribute. Required to information from AssemblyKeyFileAttribute,
12546 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12547 * codegen.cs: Modified AssemblyName creation to include support for
12548 strongnames. Catch additional exceptions to report them as CS1548.
12549 * compiler.csproj: Updated include CryptoConvert.cs.
12550 * compiler.csproj.user: Removed file - user specific configuration.
12551 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12552 Mono.Security assembly. The original class is maintained and tested in
12553 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12554 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12555 like CSC 8.0 (C# v2) supports.
12556 * Makefile: Added CryptoConvert.cs to mcs sources.
12557 * rootcontext.cs: Added new options for strongnames.
12559 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12561 * driver.cs: For --expect-error, report error code `2'
12562 if the program compiled with no errors, error code `1' if
12563 it compiled with an error other than the one expected.
12565 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12567 * compiler.csproj: Updated for Visual Studio .NET 2003.
12568 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12569 * compiler.sln: Updated for Visual Studio .NET 2003.
12571 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12573 * expression.cs: Fix bug #47234. We basically need to apply the
12574 rule that we prefer the conversion of null to a reference type
12575 when faced with a conversion to 'object' (csc behaviour).
12577 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12579 * statement.cs: Shorter form for foreach, eliminates
12580 a local variable. r=Martin.
12582 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12584 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12585 checks if we can use brtrue/brfalse to test for 0.
12586 * expression.cs: use the above in the test for using brtrue/brfalse.
12587 cleanup code a bit.
12589 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12591 * expression.cs: Rewrite string concat stuff. Benefits:
12593 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12594 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12595 rather than a concat chain.
12597 * typemanager.cs: Add lookups for more concat overloads.
12599 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12601 * expression.cs: Emit shorter il code for array init.
12618 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12620 * statement.cs: Before, two switch blocks would be merged if the
12621 total size of the blocks (end_item - begin_item + 1) was less than
12622 two times the combined sizes of the blocks.
12624 Now, it will only merge if after the merge at least half of the
12629 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12631 * class.cs : csc build fix for GetMethods(). See bug #52503.
12633 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12635 * expression.cs: Make sure fp comparisons work with NaN.
12636 This fixes bug #54303. Mig approved this patch a long
12637 time ago, but we were not able to test b/c the runtime
12640 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12642 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12644 2004-03-19 Martin Baulig <martin@ximian.com>
12646 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12647 two overloads may unify for some type parameter substitutions and
12648 report a CS0408 if appropriate.
12650 2004-03-19 Martin Baulig <martin@ximian.com>
12652 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12653 error here and not in our caller.
12655 2004-03-19 Martin Baulig <martin@ximian.com>
12657 * interface.cs: Completely killed this file.
12658 (Interface): We're now a TypeContainer and live in class.cs.
12660 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12661 argument; we're now also called for interfaces.
12662 (TypeContainer.DefineMembers): Allow this method being called
12664 (TypeContainer.GetMethods): New public method; formerly known as
12665 Interface.GetMethod(). This is used by PendingImplementation.
12666 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12667 it's now private and non-static.
12668 (Interface): Moved this here; it's now implemented similar to
12670 (Method, Property, Event, Indexer): Added `bool is_interface'
12671 argument to their .ctor's.
12672 (MemberBase.IsInterface): New public field.
12674 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12675 instances instead of InterfaceMethod, InterfaceProperty, etc.
12676 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12677 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12679 2004-03-19 Martin Baulig <martin@ximian.com>
12681 * class.cs (MethodCore.IsDuplicateImplementation): New private
12682 method which does the CS0111 checking.
12683 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12684 Use IsDuplicateImplementation().
12686 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12688 * decl.cs (FindMemberToOverride): New method to find the correct
12689 method or property to override in the base class.
12691 - Make Method/Property use the above method to find the
12692 version in the base class.
12693 - Remove the InheritableMemberSignatureCompare as it is now
12696 This patch makes large code bases much faster to compile, as it is
12697 O(n) rather than O(n^2) to do this validation.
12699 Also, it fixes bug 52458 which is that nested classes are not
12700 taken into account when finding the base class member.
12702 Reviewed/Approved by Martin.
12704 2004-03-17 Martin Baulig <martin@ximian.com>
12706 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12707 of type arguments into account; use the `real_num_type_args'
12708 approach like in DoResolveAsTypeStep().
12710 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12713 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12715 * interface.cs: In all interface classes removed redundant
12716 member initialization.
12718 2004-03-16 Martin Baulig <martin@ximian.com>
12720 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12722 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12724 * decl.cs (DefineTypeAndParents): New helper method to define a
12725 type's containers before the type itself is defined; This is a
12726 bug exposed by the recent changes to Windows.Forms when an
12727 implemented interface was defined inside a class that had not been
12730 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12732 (Check): Loop correctly to report errors modifiers
12733 (UNSAFE was not in the loop, since it was the same as TOP).
12735 * interface.cs: Every interface member now takes a ModFlags,
12736 instead of a "is_new" bool, which we set on the base MemberCore.
12738 Every place where we called "UnsafeOk" in the interface, now we
12739 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12740 the unsafe settings from the member declaration instead of the
12741 container interface.
12743 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12745 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12746 `set_indexer_name' to the pending bits (one per type).
12748 We fixed a bug today that was picking the wrong method to
12749 override, since for properties the existing InterfaceMethod code
12750 basically ignored the method name. Now we make sure that the
12751 method name is one of the valid indexer names.
12753 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12755 * support.cs (SeekableStreamReader): Keep track of stream byte
12756 positions and don't mix them with character offsets to the buffer.
12758 Patch from Gustavo Giráldez
12760 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12762 * interface.cs (InterfaceSetGetBase): Removed double member
12763 initialization, base class does it as well.
12765 2004-03-13 Martin Baulig <martin@ximian.com>
12767 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12768 when compiling corlib.
12770 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12772 * convert.cs (ExplicitConversion): We were reporting an error on
12773 certain conversions (object_type source to a value type, when the
12774 expression was `null') before we had a chance to pass it through
12775 the user defined conversions.
12777 * driver.cs: Replace / and \ in resource specifications to dots.
12780 * class.cs: Add check for duplicate operators. Fixes 52477
12782 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12784 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12785 that are in the middle of the statements, not only at the end.
12788 * class.cs (TypeContainer.AddField): No longer set the
12789 `HaveStaticConstructor' flag, now we call it
12790 `UserDefineStaticConstructor' to diferentiate the slightly
12791 semantic difference.
12793 The situation is that we were not adding BeforeFieldInit (from
12794 Modifiers.TypeAttr) to classes that could have it.
12795 BeforeFieldInit should be set to classes that have no static
12800 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12802 And most importantly Zoltan's comment:
12804 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12806 "I think beforefieldinit means 'it's ok to initialize the type sometime
12807 before its static fields are used', i.e. initialization does not need
12808 to be triggered by the first access to the type. Setting this flag
12809 helps the JIT to compile better code, since it can run the static
12810 constructor at JIT time, and does not need to generate code to call it
12811 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12812 this flag for lots of classes like String.
12814 csc sets this flag if the type does not have an explicit static
12815 constructor. The reasoning seems to be that if there are only static
12816 initalizers for a type, and no static constructor, then the programmer
12817 does not care when this initialization happens, so beforefieldinit
12820 This bug prevents the AOT compiler from being usable, since it
12821 generates so many calls to mono_runtime_class_init that the AOT code
12822 is much slower than the JITted code. The JITted code is faster,
12823 because it does not generate these calls if the vtable is type is
12824 already initialized, which is true in the majority of cases. But the
12825 AOT compiler can't do this."
12827 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12829 * class.cs (MethodData.Emit): Refactor the code so symbolic
12830 information is generated for destructors; For some reasons we
12831 were taking a code path that did not generate symbolic information
12834 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12836 * class.cs: Create a Constructor.CheckBase method that
12837 takes care of all validation type code. The method
12838 contains some code that was moved from Define.
12840 It also includes new code that checks for duplicate ctors.
12841 This fixes bug #55148.
12843 2004-03-09 Joshua Tauberer <tauberer@for.net>
12845 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12846 a { ... }-style array creation invokes EmitStaticInitializers
12847 which is not good for reference-type arrays. String, decimal
12848 and now null constants (NullCast) are not counted toward
12849 static initializers.
12851 2004-03-05 Martin Baulig <martin@ximian.com>
12853 * location.cs (SourceFile.HasLineDirective): New public field;
12854 specifies whether the file contains or is referenced by a "#line"
12856 (Location.DefineSymbolDocuments): Ignore source files which
12857 either contain or are referenced by a "#line" directive.
12859 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12861 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12862 direct access to our parent, so check the method inline there.
12864 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12866 * expression.cs (Invocation.EmitCall): Miguel's last commit
12867 caused a regression. If you had:
12872 In Foo the implict this would be null.
12874 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12876 * expression.cs (Invocation.EmitCall): If the method is not
12877 virtual, do not emit a CallVirt to it, use Call.
12879 * typemanager.cs (GetFullNameSignature): Improve the method to
12880 cope with ".ctor" and replace it with the type name.
12882 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12883 as an argument the ConstructorBuilder where it is being defined,
12884 to catch the recursive constructor invocations.
12886 2004-03-16 Martin Baulig <martin@ximian.com>
12888 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12889 ConstructedType, call ResolveType() on it to get the type rather
12890 than just using `expr.Type'.
12892 2004-03-16 Martin Baulig <martin@ximian.com>
12894 * generics.cs (ConstructedType.GetMemberAccess): Take the
12895 EmitContext instead on the TypeExpr and use
12896 ec.TypeContainer.CurrentType/ec.ContainerType.
12898 2004-03-16 Martin Baulig <martin@ximian.com>
12900 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12901 parameters before aliases.
12903 2004-03-16 Martin Baulig <martin@ximian.com>
12905 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12906 New oublic function; checks whether two generic instances may become
12907 equal under some instantiations (26.3.1).
12909 * class.cs (TypeContainer.Define): Call
12910 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12913 2004-03-16 Martin Baulig <martin@ximian.com>
12915 * class.cs (TypeContainer.GetClassBases): Moved
12916 Error_TypeParameterAsBase() here and also check whether the base
12917 class is not an attribute.
12919 2004-03-16 Martin Baulig <martin@ximian.com>
12921 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12923 2004-03-16 Martin Baulig <martin@ximian.com>
12925 * class.cs (Error_TypeParameterAsBase): Use correct error number
12928 2004-03-16 Martin Baulig <martin@ximian.com>
12930 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12933 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12936 2004-03-15 Martin Baulig <martin@ximian.com>
12938 * typemanager.cs (TypeManager.GetFullName): New public method.
12939 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12940 argument; only return members with the correct number of type
12942 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12943 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12944 whether the number of type arguments matches.
12946 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12947 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12949 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12950 field; it's set by the protected .ctor when we're actually a
12951 GenericMemberAccess.
12952 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12953 arguments and pass it to MemberLookupFinal ().
12955 * ecore.cs (Expression.MemberLookup): Added `int
12956 num_type_arguments' argument; only return members with the correct
12957 number of type arguments.
12958 (Expression.MemberLookupFailed): Check whether the MemberLookup
12959 failed because we did not have the correct number of type
12960 arguments; report CS0305 in this case.
12962 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12963 `e.ResolveAsTypeTerminal()' already did so.
12965 2004-03-15 Martin Baulig <martin@ximian.com>
12967 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12968 we're a ConstructedType; in this case, the caller must report an
12969 error (for instance CS0131).
12971 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12972 (TypeArguments.Resolve): Actually report errors here.
12974 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12976 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12977 `set_indexer_name' to the pending bits (one per type).
12979 We fixed a bug today that was picking the wrong method to
12980 override, since for properties the existing InterfaceMethod code
12981 basically ignored the method name. Now we make sure that the
12982 method name is one of the valid indexer names.
12984 2004-03-15 Martin Baulig <martin@ximian.com>
12986 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12987 for generic instances.
12989 2004-03-13 Martin Baulig <martin@ximian.com>
12991 * class.cs (TypeContainer.DefineType): Call
12992 TypeManager.AddUserType() immediately after creating the
12993 TypeBuilder; pass all type parameters when creating the
12996 * decl.cs (DeclSpace.FindNestedType): New public method.
12997 (DeclSpace.FindType): Added `int num_type_args' argument; only
12998 return types with the correct number of type parameters.
12999 (DeclSpace.CountTypeParams): New public property.
13001 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
13002 the number of type parameters; defaults to zero.
13004 * generic.cs (TypeArguments.Count): New public property.
13005 (ConstructedType.DoResolveAsTypeStep): First call
13006 ds.FindNestedType() to find out whether we're nested in the
13007 current generic type; in this case, we inherit all type parameters
13008 from the current class.
13010 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
13011 num_type_args' argument.
13012 (RootContext.LookupType): Added overloaded version which takes the
13013 number of type arguments; only return types with the correct
13014 number of type arguments.
13016 * typemanager.cs (TypeManager.CheckGeneric): New public function;
13017 checks whether `Type t' has `int num_type_args'.
13019 2004-03-13 Martin Baulig <martin@ximian.com>
13021 * generic.cs (GenericMethod.DefineType): New method; calls
13022 DefineType() on all the type parameters.
13024 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
13025 (MethodData.Define): If we're a generic method, call
13026 GenericMethod.DefineType() to define the type parameters.
13028 2004-03-10 Martin Baulig <martin@ximian.com>
13030 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
13031 instead of IsAssignableFrom.
13033 2004-03-10 Martin Baulig <martin@ximian.com>
13035 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
13037 * support.cs (ParameterData.HasArrayParameter): New property.
13038 (ReflectionParameters.ctor): Take a MethodBase instead of a
13039 ParameterInfo[]. If we have any type parameters, get the generic
13040 method definition and ask it whether we have variable arguments.
13042 2004-02-26 Miguel de Icaza <miguel@ximian.com>
13044 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
13045 routines to check if a type is an enumerable/enumerator allow
13046 classes that implement the IEnumerable or IEnumerator interfaces.
13048 * class.cs (Property, Operator): Implement IIteratorContainer, and
13049 implement SetYields.
13051 (Property.Define): Do the block swapping for get_methods in the
13052 context of iterators. We need to check if Properties also
13053 include indexers or not.
13055 (Operator): Assign the Block before invoking the
13056 OperatorMethod.Define, so we can trigger the Iterator code
13059 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
13060 Property and Operator classes are not created when we parse the
13061 declarator but until we have the block completed, so we use a
13062 singleton SimpleIteratorContainer.Simple to flag whether the
13063 SetYields has been invoked.
13065 We propagate this setting then to the Property or the Operator to
13066 allow the `yield' to function.
13068 2004-02-25 Marek Safar <marek.safar@seznam.cz>
13070 * codegen.cs: Implemented attribute support for modules.
13071 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
13072 Assembly/Module functionality.
13074 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
13075 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
13076 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
13078 2004-02-16 Marek Safar <marek.safar@seznam.cz>
13080 * interface.cs (FindMembers): The operation is performed on all base
13081 interfaces and not only on the first. It is required for future CLS Compliance patch.
13083 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
13085 * statement.cs, codegen.cs:
13086 This patch deals with patterns such as:
13088 public class List : IEnumerable {
13090 public MyEnumerator GetEnumerator () {
13091 return new MyEnumerator(this);
13094 IEnumerator IEnumerable.GetEnumerator () {
13098 public struct MyEnumerator : IEnumerator {
13103 Before, there were a few things we did wrong:
13104 1) we would emit callvirt on a struct, which is illegal
13105 2) we emited ldarg when we needed to emit ldarga
13106 3) we would mistakenly call the interface methods on an enumerator
13107 type that derived from IEnumerator and was in another assembly. For example:
13109 public class MyEnumerator : IEnumerator
13111 Would have the interface methods called, even if there were public impls of the
13112 method. In a struct, this lead to invalid IL code.
13114 2004-02-11 Marek Safar <marek.safar@seznam.cz>
13116 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
13119 * delegate.cs (Define): Fixed crash when delegate type is undefined.
13121 2004-02-11 Miguel de Icaza <miguel@ximian.com>
13123 * cs-parser.jay: Fix small regression: we were not testing V2
13124 compiler features correctly.
13126 * interface.cs: If the emit context is null, then create one
13128 2004-02-09 Marek Safar <marek.safar@seznam.cz>
13130 * decl.cs (GetSignatureForError): New virtual method to get full name
13131 for error messages.
13133 * attribute.cs (IAttributeSupport): New interface for attribute setting.
13134 Now it is possible to rewrite ApplyAttributes method to be less if/else.
13136 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
13137 Duplicated members and code in these classes has been removed.
13138 Better encapsulation in these classes.
13140 2004-02-07 Miguel de Icaza <miguel@ximian.com>
13142 * assign.cs (Assign.DoResolve): When dealing with compound
13143 assignments, there is a new rule in ECMA C# 2.4 (might have been
13144 there before, but it is documented here) that states that in:
13148 If b is of type int, and the `op' is a shift-operator, then the
13149 above is evaluated as:
13153 * expression.cs (Binary.ResolveOperator): Instead of testing for
13154 int/uint/long/ulong, try to implicitly convert to any of those
13155 types and use that in pointer arithmetic.
13157 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
13158 method to print information for from the type, not from the
13159 null-method we were given.
13161 2004-02-01 Duncan Mak <duncan@ximian.com>
13163 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
13164 parsing for cmd, fixes bug #53694.
13166 2004-02-04 Marek Safar <marek.safar@seznam.cz>
13168 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
13169 in the member name duplication tests. Property and operator name duplication
13170 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
13172 2004-02-03 Marek Safar <marek.safar@seznam.cz>
13174 * interface.cs (PopulateMethod): Fixed crash when interface method
13175 returns not existing type (error test cs0246-3.cs).
13177 2004-02-02 Ravi Pratap M <ravi@ximian.com>
13179 * cs-parser.jay (interface_accessors): Re-write actions to also
13180 store attributes attached to get and set methods. Fix spelling
13183 (inteface_property_declaration): Modify accordingly.
13185 (InterfaceAccessorInfo): New helper class to store information to pass
13186 around between rules that use interface_accessors.
13188 * interface.cs (Emit): Apply attributes on the get and set
13189 accessors of properties and indexers too.
13191 * attribute.cs (ApplyAttributes): Modify accordingly to use the
13192 right MethodBuilder when applying attributes to the get and set accessors.
13194 2004-01-31 Miguel de Icaza <miguel@ximian.com>
13196 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
13198 2004-01-26 Miguel de Icaza <miguel@ximian.com>
13200 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
13202 2004-01-25 Miguel de Icaza <miguel@ximian.com>
13204 * cs-parser.jay: Remove YIELD token, instead use the new grammar
13205 changes that treat `yield' specially when present before `break'
13206 or `return' tokens.
13208 * cs-tokenizer.cs: yield is no longer a keyword.
13210 2004-01-23 Marek Safar <marek.safar@seznam.cz>
13212 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
13213 setting for default constructors.
13214 For default constructors are almost every time set wrong Modifier. The
13215 generated IL code has been alright. But inside mcs this values was
13216 wrong and this was reason why several of my CLS Compliance tests
13219 2004-02-27 Martin Baulig <martin@ximian.com>
13221 * generics.cs (ConstructedType.ResolveType): Make the nested type
13222 stuff actually work.
13224 2004-02-25 Martin Baulig <martin@ximian.com>
13226 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
13227 property; returns the type parameters just from the current type,
13228 ie. with the ones from outer classes.
13229 (DeclSpace.LookupGeneric): First search in the current class, then
13231 (DeclSpace.initialize_type_params): When hiding a type parameter
13232 from an outer class, put it into the `type_param_list' anyways.
13234 * expression.cs (MemberAccess.expr): Made this field protected.
13236 * class.cs (TypeContainer.Define): The `CurrentType' just contains
13237 the type parameters from the current class.
13239 * generic.cs (ConstructedType.ResolveType): Support nested generic
13240 types by taking the type parameters which we inherit from outer
13241 classes into account.
13242 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
13243 support for nested generic types.
13245 2004-02-23 Martin Baulig <martin@ximian.com>
13247 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
13248 field and check whether we're nested inside a generic type.
13249 (DeclSpace.ResolveType): If we're resolving to a generic type
13250 definition, create a ConstructedType and return its resolved type.
13251 (DeclSpace.initialize_type_params): New private method;
13252 initializes the `type_param_list' field from the type parameters
13253 from this and all enclosing classes.
13254 (DeclSpace.TypeParameters): Call initialize_type_params() unless
13255 we're already initialized.
13257 2004-02-23 Martin Baulig <martin@ximian.com>
13259 * class.cs (Method.Define): Create the generic method before
13260 calling DoDefine().
13261 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
13262 the TypeContainer one); we use this for generic methods.
13264 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
13265 parent's TypeBuilder.
13267 2004-02-18 Martin Baulig <martin@ximian.com>
13269 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
13270 to check for equality.
13272 2004-02-05 Martin Baulig <martin@ximian.com>
13274 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
13275 `ec.TypeContainer.CurrentType', use it instead of
13276 `ec.ContainerType' to check whether we're in the type's ctor.
13278 2004-01-29 Martin Baulig <martin@ximian.com>
13280 * expression.cs (Invocation.DoResolve): If we're a
13281 `ConstructedType', then we're actually a generic method, so
13282 rewrite the expr as a GenericMemberAccess.
13284 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
13285 here; manually parse it into a string.
13287 2004-01-28 Martin Baulig <martin@ximian.com>
13289 * typemanager.cs (TypeManager.IsEqual): New static method.
13290 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
13291 check for equality instead of using `=='.
13293 2004-01-26 Martin Baulig <martin@ximian.com>
13295 * decl.cs (DeclSpace.CurrentType): New public field.
13297 * expression.cs (This.ResolveBase): If we have an
13298 `ec.TypeContainer.CurrentType', use it instead of
13299 `ec.ContainerType'.
13301 * class.cs (TypeContainer.DefineType): If we're a generic type,
13302 create the `CurrentType' (unresolved).
13303 (TypeContainer.GenericType): New private field.
13304 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
13305 it and store it in `GenericType' before creating the MemberCache.
13306 (TypeContainer.GetMembers): If we have a `GenericType', call
13307 TypeManager.FindMembers() on it.
13309 * interface.cs (Interface.GenericType): New private field.
13310 (Interface.DefineType): If we're a generic type, create the
13311 `CurrentType' (unresolved).
13312 (Interface.DefineMembers): If we have a `CurrentType', resolve it
13313 and store it in `GenericType' before creating the MemberCache.
13314 (Interface.GetMembers): If we have a `GenericType', call
13315 TypeManager.FindMembers() on it.
13317 2004-01-22 Martin Baulig <martin@ximian.com>
13319 * cs-parser.jay (namespace_or_type_name): Return an Expression,
13320 not a QualifiedIdentifier. This is what `type_name_expression'
13321 was previously doing.
13322 (type_name_expression): Removed; the code is now in
13323 `namespace_or_type_name'.
13324 (qualified_identifier): Removed, use `namespace_or_type_name'
13326 (QualifiedIdentifier): Removed this class.
13328 2004-01-22 Martin Baulig <martin@ximian.com>
13330 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
13331 not a string as alias name.
13333 2004-01-21 Miguel de Icaza <miguel@ximian.com>
13335 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
13336 #52730 bug, and instead compute correctly the need to use a
13337 temporary variable when requesting an address based on the
13338 static/instace modified of the field and the constructor.
13340 2004-01-21 Martin Baulig <martin@ximian.com>
13342 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
13343 class and namespace before looking up aliases. Fixes #52517.
13345 2004-01-21 Martin Baulig <martin@ximian.com>
13347 * flowanalysis.cs (UsageVector.Merge): Allow variables being
13348 assinged in a 'try'; fixes exception4.cs.
13350 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13351 * class.cs : Implemented parameter-less constructor for TypeContainer
13353 * decl.cs: Attributes are now stored here. New property OptAttributes
13355 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
13357 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
13359 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13361 * typemanager.cs (CSharpSignature): Now reports also inner class name.
13362 (CSharpSignature): New method for indexer and property signature.
13364 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13366 * pending.cs (IsVirtualFilter): Faster implementation.
13368 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13370 * typemanager.cs: Avoid inclusion of same assembly more than once.
13372 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13374 * cs-parser.jay: Fixed problem where the last assembly attribute
13375 has been applied also to following declaration (class, struct, etc.)
13377 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13379 * class.cs: Added error CS0538, CS0539 reporting.
13380 Fixed crash on Microsoft runtime when field type is void.
13382 * cs-parser.jay: Added error CS0537 reporting.
13384 * pending.cs: Added error CS0535 reporting.
13385 Improved error report for errors CS0536, CS0534.
13387 2004-01-20 Miguel de Icaza <miguel@ximian.com>
13389 Merge a few bits from the Anonymous Method MCS tree.
13391 * statement.cs (ToplevelBlock): New class for toplevel methods,
13392 will hold anonymous methods, lifted variables.
13394 * cs-parser.jay: Create toplevel blocks for delegates and for
13395 regular blocks of code.
13397 2004-01-20 Martin Baulig <martin@ximian.com>
13399 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
13400 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
13401 and `NeedExplicitReturn'; added `IsLastStatement'.
13402 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
13403 have a `ReturnLabel' or we're not unreachable.
13405 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
13406 child's reachability; don't just override ours with it. Fixes
13407 #58058 (lluis's example).
13408 (FlowBranching): Added public InTryOrCatch(), InCatch(),
13409 InFinally(), InLoop(), InSwitch() and
13410 BreakCrossesTryCatchBoundary() methods.
13412 * statement.cs (Return): Do all error checking in Resolve().
13413 Unless we are the last statement in a top-level block, always
13414 create a return label and jump to it.
13415 (Break, Continue): Do all error checking in Resolve(); also make
13416 sure we aren't leaving a `finally'.
13417 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
13418 statement in a top-level block.
13419 (Block.Flags): Added `IsDestructor'.
13420 (Block.IsDestructor): New public property.
13422 2004-01-20 Martin Baulig <martin@ximian.com>
13424 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
13426 2004-01-20 Martin Baulig <martin@ximian.com>
13428 * statement.cs (Statement.ResolveUnreachable): New public method.
13429 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
13430 (Block.Resolve): Resolve unreachable statements.
13432 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13434 * expression.cs: We need to fix the case where we do
13435 not have a temp variable here.
13437 * assign.cs: Only expression compound assignments need
13438 temporary variables.
13440 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13442 * flowanalysis.cs: Reduce memory allocation in a few ways:
13443 - A block with no variables should not allocate a bit
13445 - A method with no out parameters does not need any tracking
13446 for assignment of the parameters, so we need not allocate
13449 public readonly Type[] VariableTypes;
13450 public readonly string[] VariableNames;
13451 Are redundant. The data is already stored in the variable
13452 map, so we need not allocate another array for it.
13453 - We need to add alot of checks for if (params | locals) == null
13454 due to the first two changes.
13456 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13458 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13459 implement IMemoryLocation, we store a copy on a local variable and
13460 take the address of it. Patch from Benjamin Jemlich
13462 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13463 to use a special "type_name_expression" rule which reduces the
13464 number of "QualifiedIdentifier" classes created, and instead
13465 directly creates MemberAccess expressions.
13467 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13469 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13470 that fixes #52853. Null literal assignment to ValueType
13472 * class.cs (MethodData.Emit): Instead of checking the name of the
13473 method to determine if its a destructor, create a new derived
13474 class from Method called Destructor, and test for that.
13476 * cs-parser.jay: Create a Destructor object instead of a Method.
13478 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13482 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13484 * expression.cs (Binary.ResolveOperator): Perform an implicit
13485 conversion from MethodGroups to their delegate types on the
13486 Addition operation.
13488 * delegate.cs: Introduce a new class DelegateCreation that is the
13489 base class for `NewDelegate' and `ImplicitDelegateCreation',
13490 factor some code in here.
13492 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13493 conversion from MethodGroups to compatible delegate types.
13495 * ecore.cs (Expression.Resolve): Do not flag error 654
13496 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13497 we allow conversions from MethodGroups to delegate types now.
13499 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13500 assignments in v2 either.
13502 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13504 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13505 static read-only fields in ctors.
13507 Applied patch from Benjamin Jemlich
13509 * expression.cs (UnaryMutator): Avoid leaking local variables.
13511 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13513 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13514 here to return true, as they can be used like this:
13516 (XXX) int.MEMBER ()
13518 Fixed 49836 and all the other dups
13520 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13522 * driver.cs: Implement /win32res and /win32icon.
13524 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13526 * cs-parser.jay: Add a rule to improve error handling for the
13527 common mistake of placing modifiers after the type.
13529 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13531 * cs-parser.jay (interface_event_declaration): Catch
13532 initialization of events on interfaces, and report cs0068
13534 * cs-parser.jay (interface_event_declaration): Catch
13535 initialization of events.
13537 * ecore.cs: Better report missing constructors.
13539 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13540 the error reporting done in the wrong place. Fix.
13542 * expression.cs (Binary.ResolveOperator): Catch the
13543 operator + (E x, E y) error earlier, and later allow for implicit
13544 conversions in operator +/- (E e, U x) from U to the underlying
13547 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13548 52596, if the container class is abstract, the default constructor
13549 is protected otherwise its public (before, we were always public).
13551 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13554 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13555 Jemlich that fixes bug #52597, MCS was generating invalid code for
13556 idisposable structs. Thanks to Ben for following up with this
13559 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13561 * driver.cs: Allow assemblies without code to be generated, fixes
13564 2004-01-07 Nick Drochak <ndrochak@gol.com>
13566 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13568 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13570 * cs-parser.jay: Add rules to improve error reporting if fields or
13571 methods are declared at the namespace level (error 116)
13573 * Add rules to catch event add/remove
13575 2004-01-04 David Sheldon <dave-mono@earth.li>
13577 * expression.cs: Added matching ")" to error message for
13580 2004-01-03 Todd Berman <tberman@gentoo.org>
13582 * ecore.cs, attribute.cs:
13583 Applying fix from #52429.
13585 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13587 * ecore.cs, expression.cs, statement.cs:
13588 Total rewrite of how we handle branching. We
13589 now handle complex boolean expressions with fewer
13590 jumps. As well if (x == 0) no longer emits a ceq.
13592 if (x is Foo) is much faster now, because we generate
13595 Overall, we get a pretty big improvement on our benchmark
13596 tests. The code we generate is smaller and more readable.
13598 I did a full two-stage bootstrap. The patch was reviewed
13599 by Martin and Miguel.
13601 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13603 * cs-parser.jay: Make primary_expression not take a QI.
13604 we dont need this because the member_access rule covers
13605 us here. So we replace the rule with just IDENTIFIER.
13607 This has two good effects. First, we remove a s/r conflict.
13608 Second, we allocate many fewer QualifiedIdentifier objects.
13610 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13612 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13613 set the correct information via SRE. This prevents
13614 hanging on the MS runtime. Fixes #29374.
13616 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13618 * convert.cs: correctly handle conversions to value types
13619 from Enum and ValueType as unboxing conversions.
13621 Fixes bug #52569. Patch by Benjamin Jemlich.
13623 2004-01-02 Ravi Pratap <ravi@ximian.com>
13625 * expression.cs (BetterConversion): Prefer int -> uint
13626 over int -> ulong (csc's behaviour). This fixed bug #52046.
13628 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13630 * decl.cs (MemberCache.FindMembers): now returns a
13633 * typemanager.cs: In general, go with with ^^.
13634 (CopyNewMethods): take an IList.
13635 (RealMemberLookup): Only allocate an arraylist
13636 if we copy from two sets of methods.
13638 This change basically does two things:
13639 1) Fewer array lists allocated due to CopyNewMethods.
13640 2) the explicit cast in MemberList costed ALOT.
13642 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13644 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13645 a hashtable to avoid needless string allocations when an identifier is
13646 used more than once (the common case).
13648 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13650 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13651 is broken, it will not return anything. So, we
13652 have to use the information we have in mcs to
13655 * typemanager.cs: Add a cache for GetInterfaces,
13656 since this will now be used more often (due to ^^)
13658 (GetExplicitInterfaces) New method that gets the
13659 declared, not effective, interfaces on a type
13660 builder (eg, if you have interface IFoo, interface
13661 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13664 This patch makes MCS able to bootstrap itself on
13667 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13669 * expression.cs: Remove the Nop's that Miguel put
13672 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13674 * report.cs, codegen.cs: Give the real stack trace to
13675 the error when an exception is thrown.
13677 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13679 * decl.cs: only allocate hashtables for ifaces if
13682 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13684 * expression.cs: fix the error from cs0121-2.cs
13685 (a parent interface has two child interfaces that
13686 have a function with the same name and 0 params
13687 and the function is called through the parent).
13689 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13691 * class.cs, rootcontext.cs, typmanager.cs: do not
13694 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13696 * codegen.cs: remove stack for the ec flow branching.
13697 It is already a linked list, so no need.
13699 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13701 * Makefile: Allow custom profiler here.
13703 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13705 * typemanager.cs (LookupType):
13706 - Use a static char [], because split takes
13707 a param array for args, so it was allocating
13709 - Do not store true in a hashtable, it boxes.
13711 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13713 * flowanalysis.cs: bytify common enums.
13715 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13717 * modifiers.cs: Add a new set of flags for the
13718 flags allowed on explicit interface impls.
13719 * cs-parser.jay: catch the use of modifiers in
13720 interfaces correctly.
13721 * class.cs: catch private void IFoo.Blah ().
13723 All related to bug #50572.
13725 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13727 * decl.cs: Rewrite the consistant accessability checking.
13728 Accessability is not linear, it must be implemented in
13729 a tableish way. Fixes #49704.
13731 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13733 * expression.cs: Handle negation in a checked context.
13734 We must use subtraction from zero. Fixes #38674.
13736 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13738 * class.cs: Ignore static void main in DLLs.
13739 * rootcontext.cs: Handle the target type here,
13740 since we are have to access it from class.cs
13741 * driver.cs: account for the above.
13743 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13745 * report.cs: Give line numbers and files if available.
13747 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13749 * driver.cs: Implement /addmodule.
13751 * typemanager.cs: Change 'modules' field so it now contains Modules not
13754 2003-12-20 Martin Baulig <martin@ximian.com>
13756 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13757 (FieldBase.IsAssigned): Removed this field.
13758 (FieldBase.SetAssigned): New public method.
13759 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13761 2003-12-20 Martin Baulig <martin@ximian.com>
13763 * expression.cs (LocalVariableReference.DoResolve): Don't set
13764 `vi.Used' if we're called from DoResolveLValue().
13766 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13767 returns the usage vector it just merged into the current one -
13768 pass this one to UsageWarning().
13769 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13770 of the `EmitContext', don't call this recursively on our children.
13772 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13774 * driver.cs: Implement /target:module.
13776 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13778 * support.cs (CharArrayHashtable): New helper class.
13780 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13781 char arrays, not strings, so we can avoid creating a string in
13782 consume_identifier if the identifier is a keyword.
13784 2003-12-16 Martin Baulig <martin@ximian.com>
13786 * statement.cs (LocalInfo.Assigned): Removed this property.
13787 (LocalInfo.Flags): Removed `Assigned'.
13788 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13789 and uses flow analysis.
13790 (Block.UsageWarning): Made this method private.
13791 (Block.Resolve): Call UsageWarning() if appropriate.
13793 * expression.cs (LocalVariableReference.DoResolve): Always set
13794 LocalInfo.Used here.
13796 2003-12-13 Martin Baulig <martin@ximian.com>
13798 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13799 any value here; we're now using flow analysis to figure out
13800 whether a statement/block returns a value.
13802 2003-12-13 Martin Baulig <martin@ximian.com>
13804 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13806 (FlowBranching.MergeFinally): Don't call
13807 `branching.CheckOutParameters()' here, this is called in
13809 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13810 when adding the `finally' vector.
13812 2003-12-13 Martin Baulig <martin@ximian.com>
13815 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13816 actually work and also fix #48962.
13818 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13820 * decl.cs: Do not check System.Object for nested types,
13821 since we know it does not have any. Big bang for buck:
13824 Run 1: 8.35 seconds
13825 Run 2: 8.32 seconds
13826 corlib: 17.99 seconds
13828 Run 1: 8.17 seconds
13829 Run 2: 8.17 seconds
13830 corlib: 17.39 seconds
13832 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13834 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13835 time we are returning 0 members, so we save alot here.
13837 2003-12-11 Martin Baulig <martin@ximian.com>
13839 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13840 `MergeChild()', also just take the `FlowBranching' as argument;
13841 call Merge() on it and return the result.
13842 (FlowBranching.Merge): We don't need to do anything if we just
13845 2003-12-11 Martin Baulig <martin@ximian.com>
13847 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13848 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13849 Maurer for this idea.
13851 2003-12-11 Martin Baulig <martin@ximian.com>
13853 * flowanalysis.cs (MergeResult): This class is now gone; we now
13854 use the `UsageVector' for this. The reason for this is that if a
13855 branching just has one sibling, we don't need to "merge" them at
13856 all - that's the next step to do.
13857 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13860 2003-12-11 Martin Baulig <martin@ximian.com>
13862 Reworked flow analyis and made it more precise and bug-free. The
13863 most important change is that we're now using a special `Reachability'
13864 class instead of having "magic" meanings of `FlowReturns'. I'll
13865 do some more cleanups and optimizations and also add some more
13866 documentation this week.
13868 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13869 largely reworked this class.
13870 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13871 the new `Reachability' class instead of having "magic" values here.
13872 (FlowBranching): We're now using an instance of `Reachability'
13873 instead of having separate `Returns', `Breaks' etc. fields.
13875 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13876 based on flow analysis; ignore the return value of block.Emit ().
13878 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13880 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13881 if they are private.
13883 2003-12-09 Martin Baulig <martin@ximian.com>
13885 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13886 call them directly on the UsageVector.
13888 2003-12-09 Martin Baulig <martin@ximian.com>
13890 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13891 Changed return type from `FlowReturns' to `Reachability'.
13893 2003-12-09 Martin Baulig <martin@ximian.com>
13895 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13896 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13897 `Reachable' fields with a single `Reachability' one.
13899 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13901 * class.cs (FindMembers): Remove foreach's.
13906 Run 1: 8.74 seconds
13907 Run 2: 8.71 seconds
13910 Run 1: 8.64 seconds
13911 Run 2: 8.58 seconds
13914 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13919 This patch does a few things:
13920 1. EmptyStatement is now a singleton, so it is never reallocated.
13921 2. All blah is EmptyStatement constructs have been changed to
13922 blah == EmptyStatement.Value, which is much faster and valid
13923 now that EmptyStatement is a singleton.
13924 3. When resolving a block, rather than allocating a new array for
13925 the non-empty statements, empty statements are replaced with
13926 EmptyStatement.Value
13927 4. Some recursive functions have been made non-recursive.
13928 Mainly the performance impact is from (3), however (1) and (2) are needed for
13929 this to work. (4) does not make a big difference in normal situations, however
13930 it makes the profile look saner.
13935 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13936 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13937 Total memory allocated: 56397 KB
13940 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13941 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13942 Total memory allocated: 55666 KB
13944 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13946 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13947 than the hashtable in a hashtable version
13949 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13950 we always end up concating a string. This results in a huge perf
13951 loss, because many strings have to be tracked by the GC. In this
13952 patch, we first use a hashtable that works with two keys, so that
13953 the strings do not need to be concat'ed.
13957 Run 1: 8.74 seconds
13958 Run 2: 8.71 seconds
13961 Run 1: 8.65 seconds
13962 Run 2: 8.56 seconds
13964 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13966 * Makefile: Add a new target `do-time' that does a quick and simple
13967 profile, leaving easy to parse output.
13969 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13971 * codegen.cs (Init): Create the dynamic assembly with
13972 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13974 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13976 * support.cs: Make the PtrHashtable use only one
13977 instance of its comparer.
13979 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13981 * typemanager.cs: Fix lookup of GetNamespaces.
13983 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13985 * expression.cs: Removed redundant line.
13987 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13988 ArrayLists, use for loops with bounds.
13990 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13993 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13994 arraylists, use for loop with bounds.
13996 The above three changes give us a 0.071 second performance
13997 improvement out of 3.294 seconds down to 3.223. On my machine
13998 the above changes reduced the memory usage by 1,387 KB during
13999 compiler bootstrap.
14001 * cs-parser.jay (QualifiedIdentifier): New class used to represent
14002 QualifiedIdentifiers. Before we created a new string through
14003 concatenation, and mostly later on, the result would be
14004 manipulated by DecomposeQI through string manipulation.
14006 This reduced the compiler memory usage for bootstrapping from
14007 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
14008 compile times in 0.05 seconds.
14010 2003-11-28 Dick Porter <dick@ximian.com>
14012 * support.cs: Do string compares with the Invariant culture.
14020 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
14021 the comparison is done with the Invariant culture.
14023 2003-11-27 Miguel de Icaza <miguel@ximian.com>
14025 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
14026 GetEnumerator method.
14028 (ProbeCollectionType): Iterate starting at the most specific type
14029 upwards looking for a GetEnumerator
14031 * expression.cs: Shift count can be up to 31 for int/uint and 63
14034 2003-11-26 Miguel de Icaza <miguel@ximian.com>
14036 * statement.cs (Block.LookupLabel): Also look for the label on the
14037 children blocks. Use a hash table to keep track of visited
14040 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
14041 we actually did transform the other operand, otherwise fall back
14042 to the common codepath that casts to long.
14044 * cs-tokenizer.cs: Use the same code pattern as the int case.
14045 Maybe I should do the parsing myself, and avoid depending on the
14046 Parse routines to get this done.
14048 2003-11-25 Miguel de Icaza <miguel@ximian.com>
14050 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
14051 which fixes bug 51347. This time test it.
14053 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
14054 attributes for example can not tell the difference between these.
14055 The difference was only a syntax feature of the language.
14057 * attribute.cs: Apply attributes to delegates.
14059 * delegate.cs: Call the apply attributes method.
14061 2003-11-24 Miguel de Icaza <miguel@ximian.com>
14063 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
14064 comparing 0 vs Byte.MinValue, not the value
14066 (ImplicitConversionRequired): When reporting a conversion error,
14067 use error 31 to print out the constant error instead of the
14070 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
14071 which fixes bug 51347.
14073 2003-11-22 Miguel de Icaza <miguel@ximian.com>
14075 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
14076 which fixes the -warnaserror command line option.
14078 2003-11-21 Miguel de Icaza <miguel@ximian.com>
14080 * cfold.cs (DoNumericPromotions): During constant folding of
14081 additions on UIntConstant, special case intconstants with
14082 IntConstants like we do on the expression binary operator.
14084 2003-11-12 Miguel de Icaza <miguel@ximian.com>
14086 * convert.cs (ImplicitReferenceConversion): We were missing a case
14087 (System.Enum are not value types or class types, so we need to
14088 classify them separatedly).
14090 * driver.cs: We do not support error 2007.
14092 2003-11-12 Jackson Harper <jackson@ximian.com>
14094 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
14095 system directory. Also use the full file name so users can
14096 libraries names mscorlib-o-tron.dll in a non system dir.
14098 2004-01-04 David Sheldon <dave-mono@earth.li>
14100 * expression.cs: Added matching ")" to error message for CS0077.
14102 2003-12-19 Martin Baulig <martin@ximian.com>
14104 * typemanager.cs (TypeManager.IsEqualGenericType): New public
14105 static method; see documentation in the method.
14106 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
14108 * convert.cs (Convert.ImplicitReferenceConversion,
14109 Convert.ImplicitReferenceConversionExists): Add support for
14110 generic type declarations; see gen-36.cs.
14112 2003-12-19 Martin Baulig <martin@ximian.com>
14114 * pending.cs (Pending.InterfaceMethod): Use
14115 `Type.IsAssignableFrom()' instead of `=='.
14117 2003-12-18 Martin Baulig <martin@ximian.com>
14119 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
14122 * convert.cs (Convert.ImplicitStandardConversionExists): Use
14123 `expr_type.Equals (target_type)' instead of `=='.
14125 2003-12-08 Martin Baulig <martin@ximian.com>
14127 * generics.cs (Constraints.Types): Removed.
14128 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
14130 (Constraints.ResolveTypes): New public method; resolves the
14131 TypeExpr's to Type's.
14132 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
14133 longer takes the constraints.
14134 (TypeParameter.DefineMethod): Likewise.
14135 (TypeParameter.DefineType): New public method. Calls
14136 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
14139 2003-12-08 Martin Baulig <martin@ximian.com>
14141 * convert.cs (Convert.ImplicitConversionStandard): Use
14142 `expr_type.Equals (target_type)' instead of `=='.
14144 2003-12-08 Martin Baulig <martin@ximian.com>
14146 * typemanager.cs (TypeManager.GetReferenceType): Call
14147 `Type.MakeByRefType ()'.
14149 2003-12-08 Martin Baulig <martin@ximian.com>
14151 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
14152 just has some special meaning in some situations. For instance,
14153 it is allowed to use `where' as the name of a variable etc.
14155 2003-12-04 Martin Baulig <martin@ximian.com>
14157 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14158 `Type.MakeArrayType()' for array types.
14160 2003-11-18 Miguel de Icaza <miguel@ximian.com>
14162 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
14165 (SizeOf.DoResolve): assign the `type_queried' field. This gets
14168 2003-11-16 Martin Baulig <martin@ximian.com>
14170 * codegen.cs (EmitContext.IsGeneric): Removed.
14172 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
14173 ResolveGeneric() on the DeclSpace.
14175 2003-11-16 Martin Baulig <martin@ximian.com>
14177 * generic.cs (TypeArguments.Resolve):
14178 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
14179 `ResolveType()' on it to get the Type.
14181 2003-11-15 Martin Baulig <martin@ximian.com>
14183 * generic.cs (ConstructedType.GetInterfaces): Override this.
14185 2003-11-14 Martin Baulig <martin@ximian.com>
14187 * interface.cs (Interface.DefineType): Define all type parameters
14188 before adding the interfaces we inherit.
14190 2003-11-11 Martin Baulig <martin@ximian.com>
14192 * generic.cs (ConstructedType.ResolveType): Always call
14193 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
14195 2003-11-10 Martin Baulig <martin@ximian.com>
14197 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
14198 (TypeManager.InitCoreTypes): Initialize them here, but instead of
14199 calling `ResolveType()' on them, directly assign their `Type'.
14201 2003-11-08 Martin Baulig <martin@ximian.com>
14203 * generic.cs (ConstructedType): Override `IsClass' etc.
14205 2003-11-08 Martin Baulig <martin@ximian.com>
14207 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
14208 return value and the `out parent' parameter.
14209 (TypeContainer.DefineType): Moved the CS0644 check into
14210 GetClassBases(). Don't pass the interface types to the
14211 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
14212 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
14214 * ecore.cs (TypeExpr.IsAttribute): New property.
14215 (TypeExpr.GetInterfaces): New method.
14217 * interface.cs (Interface.GetInterfaceTypeByName): Return a
14218 TypeExpr instead of a Type.
14219 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
14220 (Interface.DefineType): Don't pass the interface types to the
14221 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
14222 them later and then call `TypeBulider.AddInterfaceImplementation()'.
14224 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
14225 instead of a `Type[]'.
14226 (TypeManager.RegisterBuilder): Likewise.
14227 (TypeManager.AddUserInterface): Likewise.
14228 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
14229 `Type[]' and also return a `TypeExpr[]'.
14230 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
14232 2003-11-08 Martin Baulig <martin@ximian.com>
14234 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
14237 2003-11-08 Martin Baulig <martin@ximian.com>
14239 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
14240 TypeManager.ResolveExpressionTypes().
14242 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
14243 instead of an Expression.
14244 (TypeExpr): This is now an abstract base class for `TypeExpression'.
14245 (TypeExpression): New public class; formerly known as `TypeExpr'.
14247 * expression.cs (ComposedCast): Derive from TypeExpr.
14249 * typemanager.cs (TypeManager.system_*_expr): These are now
14250 TypExpr's instead of Expression's.
14251 (TypeManager.ResolveExpressionTypes): New public static function;
14252 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
14255 2003-11-06 Miguel de Icaza <miguel@ximian.com>
14257 * expression.cs (New.DoResolve): Do not dereference value that
14258 might be a null return.
14260 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
14261 sure that the constant value has the right type. Fixes an
14262 unreported bug, similar to 50425.
14264 * const.cs (Const.LookupConstantValue): Call
14265 ImplicitStandardConversionExists before doing a conversion to
14266 avoid havng the TypeManager.ChangeType do conversions.
14268 Reduced the number of casts used
14270 (Const.ChangeType): New routine to enable reuse of the constant
14271 type changing code from statement.
14273 * typemanager.cs (ChangeType): Move common initialization to
14274 static global variables.
14278 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
14279 every value type to go through, even if it was void. Fix that.
14281 * cs-tokenizer.cs: Use is_identifier_start_character on the start
14282 character of the define, and the is_identifier_part_character for
14283 the rest of the string.
14285 2003-11-05 Miguel de Icaza <miguel@ximian.com>
14287 * expression.cs (UnaryMutator.EmitCode): When I updated
14288 LocalVariableReference.DoResolve, I overdid it, and dropped an
14289 optimization done on local variable references.
14291 2003-11-04 Miguel de Icaza <miguel@ximian.com>
14293 * ecore.cs: Convert the return from Ldlen into an int.
14295 2003-10-20 Miguel de Icaza <miguel@ximian.com>
14297 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
14298 the accessibility, this is a special case for toplevel non-public
14299 classes (internal for instance).
14301 2003-10-20 Nick Drochak <ndrochak@gol.com>
14303 * ecore.cs: Fix typo and build. Needed another right paren.
14305 2003-10-19 Miguel de Icaza <miguel@ximian.com>
14307 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
14308 `internal' case regular and protected, but not allowing protected
14309 to be evaluated later. Bug 49840
14311 2003-10-15 Miguel de Icaza <miguel@ximian.com>
14313 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
14314 to kb.Nlast, and not the kb.nFirst to isolate the switch
14317 Extract the underlying type, so enumerations of long/ulong are
14318 treated like long/ulong.
14320 2003-10-14 Miguel de Icaza <miguel@ximian.com>
14322 * expression.cs (New): Overload the meaning of RequestedType to
14323 track the possible creation of the NewDelegate type, since
14324 DoResolve is invoked more than once for new constructors on field
14327 See bugs: #48800 and #37014
14329 * cs-parser.jay (declare_local_constants): Take an arraylist
14330 instead of a single constant.
14332 (local_constant_declaration): It should take a
14333 constant_declarators, not a constant_declarator. Fixes 49487
14335 * convert.cs: Fix error report.
14337 2003-10-13 Jackson Harper <jackson@ximian.com>
14339 * typemanager.cs (TypeToCoreType): Add float and double this fixes
14342 2003-11-03 Martin Baulig <martin@ximian.com>
14344 * expression.cs (ArrayAccess.GetStoreOpcode): Added
14345 `out bool has_type_arg'; if set, we need to pass the type to
14347 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
14348 Stelem_Any/Ldelem_Any for generic parameters.
14350 2003-11-02 Martin Baulig <martin@ximian.com>
14352 * expression.cs (Invocation.EmitCall): Use
14353 `TypeManager.IsValueType()' to check whether it's a value type.
14354 Don't set `struct_call' when calling a method on a type parameter.
14356 2003-11-02 Martin Baulig <martin@ximian.com>
14358 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
14359 and removed the TypeBuilder argument.
14361 * typemanager.cs (TypeManager.IsValueType): Return
14362 `t.IsGenericParameter || t.IsValueType'.
14364 2003-10-25 Martin Baulig <martin@ximian.com>
14366 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
14367 call ConstructedType.Resolve() on it.
14369 * generic.cs (ConstructedType.Resolve): Set `type' on success.
14371 2003-10-25 Martin Baulig <martin@ximian.com>
14373 * class.cs (TypeContainer.GetClassBases): Changed
14374 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
14375 CS8214 reporting here.
14376 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
14377 instead of a `Type' for our parent. In case of a recursive
14378 declaration (see tests/gen-23.cs for an example), our parent is a
14379 ConstructedType and it doesn't have its type set. So, first
14380 create our own TypeBuilder, then call constructed.Resolve() to get
14381 the parent's type and finally TypeBuilder.SetParent() it.
14383 * ecore.cs (TypeExpr.Name): New public virtual property.
14386 (ConstructedType): We're now a TypeExpr and not just an Expression.
14387 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
14388 arguments here; this is done later.
14389 (ConstructedType.Resolve): New public method to resolve the type
14390 arguments and bind them.
14392 2003-10-21 Martin Baulig <martin@ximian.com>
14394 * convert.cs: Use `TypeManager.IsValueType' instead of
14395 'type.IsValueType' everywhere.
14397 * typemanager.cs (TypeManager.IsValueType): Return true for type
14398 parameters. The reason for this is that we need to box a type
14399 parameter when converting it to a reference type.
14401 * cs-parser.jay: Added support for default value expressions.
14403 * generics.cs (DefaultValueExpression): New public class.
14405 2003-10-17 Martin Baulig <martin@ximian.com>
14407 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
14408 TypeContainer so we can also use this for Interfaces.
14409 (TypeParameter.Resolve): Likewise.
14411 * interface.cs (Interface.DefineType): Added support for generic
14414 * cs-parser.jay: Added support for generic structs and interfaces.
14416 2003-10-17 Martin Baulig <martin@ximian.com>
14418 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
14419 call generic methods :-)
14421 2003-10-16 Martin Baulig <martin@ximian.com>
14423 * cs-parser.jay (namespace_or_type_name): Only create a
14424 GenericMemberAccess if we actually have type arguments.
14426 2003-10-13 Martin Baulig <martin@ximian.com>
14428 * class.cs (Method.Define): If we're a generic method, call
14429 TypeBuilder.DefineGenericMethod () before resolving
14431 (MethodData): Added .ctor which takes an additional MethodBuilder
14432 argument; this is used for generic methods.
14433 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
14434 we already have a MethodBuilder.
14436 2003-10-10 Martin Baulig <martin@ximian.com>
14438 * class.cs (Method): Added .ctor which takes a `GenericMethod'
14439 instead of a `DeclSpace'. This is used for generic methods.
14441 * cs-parser.jay (method_header): Added support for generic
14442 methods; create a `GenericMethod' instance and pass it to the
14443 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
14444 parameters and locals.
14446 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
14447 since we already have the location. Check whether we're a generic
14448 type declaration or a generic method and create the correct type
14451 * generic.cs (TypeParameter.DefineMethod): New public method.
14452 (GenericMethod): New public class; derives from DeclSpace and is
14453 used for generic methods.
14455 2003-10-09 Martin Baulig <martin@ximian.com>
14457 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14459 (MethodCore.DoDefineParameters): Removed the TypeContainer
14460 argument; use the DeclSpace which was passed to the .ctor instead.
14461 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14462 TypeContainer; we only need a DeclSpace here.
14464 2003-10-09 Martin Baulig <martin@ximian.com>
14466 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14468 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14469 EmitContext's .ctor.
14471 2003-10-09 Martin Baulig <martin@ximian.com>
14473 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14474 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14475 AsAccessible(), moved them as well.
14477 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14479 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14481 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14482 generation for >=, as spotted by Paolo, bug 48679.
14483 Patch from David Waite.
14485 * cs-tokenizer.cs: Add handling for #pragma.
14487 * cs-parser.jay: Allow for both yield and yield return in the
14488 syntax. The anti-cobolization of C# fight will go on!
14490 * class.cs (TypeBuilder.DefineType): Catch error condition here
14491 (Parent.DefineType erroring out and returning null).
14493 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14494 coping with enumerations variables, we were mistakenly processing
14495 them as a regular value type instead of built-in types. Fixes the
14498 * typemanager.cs (IsBuiltinOrEnum): New method.
14500 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14502 * cs-parser.jay: Upgrade: yield now needs the return clause.
14504 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14506 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14508 2003-09-29 Martin Baulig <martin@ximian.com>
14510 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14511 inflated generic methods.
14513 * generics.cs (ConstructedType): Distinguish between open and
14514 closed constructed types; correctly resolve the arguments.
14516 2003-09-22 Martin Baulig <martin@ximian.com>
14518 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14519 all type arguments meet their constraints.
14521 2003-09-19 Martin Baulig <martin@ximian.com>
14523 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14524 `MemberCache parent' argument. Normally, an interface doesn't
14525 have a parent type except System.Object, but we use this in gmcs
14526 for generic type parameters.
14528 2003-09-18 Martin Baulig <martin@ximian.com>
14530 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14531 on `type.IsInterface'; don't check whether the type has a parent
14532 to determine whether it's an interface.
14534 2003-09-17 Martin Baulig <martin@ximian.com>
14536 * generic.cs (ConstructedType.ToString): Always use `name' as the
14539 2003-09-15 Martin Baulig <martin@ximian.com>
14541 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14543 * generic.cs (Constraints.Resolve): New public method; this is
14544 called to resolve the constraint types and to check whether all
14545 the constraints are correct.
14546 (Constraints.Types): New public property.
14547 (TypeParameter.Resolve): New public method; resolves all the
14548 type's constraints.
14550 * class.cs (TypeContainer.DefineType): Call
14551 TypeParameter.Resolve() before actually defining the type.
14553 2003-09-15 Martin Baulig <martin@ximian.com>
14555 * class.cs (TypeContainer.DefineType): Added an error flag to
14556 avoid reporting duplicate CS0146's ("class definition is
14559 * driver.cs (Driver.MainDriver): Abort if
14560 RootContext.ResolveTree() reported any errors.
14562 2003-09-07 Martin Baulig <martin@ximian.com>
14564 * report.cs (Error, Warning): Added overloaded versions which take
14565 a `params object[] args' and call String.Format().
14567 2003-09-07 Martin Baulig <martin@ximian.com>
14569 * decl.cs (DeclSpace..ctor): Don't call
14570 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14571 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14572 (DeclSpace.RecordDecl): New method.
14574 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14576 2003-09-02 Ravi Pratap <ravi@ximian.com>
14578 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14579 value attributes to be applied to ParameterBuilders.
14581 * class.cs (MethodCore.LabelParameters): Make static and more
14582 generic so that it can be used from other places - like interface
14583 methods, for instance.
14585 * interface.cs (Interface.Emit): Call LabelParameters before
14586 emitting attributes on the InterfaceMethod.
14588 2003-09-07 Martin Baulig <martin@ximian.com>
14590 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14591 if the number of type parameters doesn't match.
14593 2003-09-04 Martin Baulig <martin@ximian.com>
14595 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14596 for arrays of generic type params (ie. `!0[]').
14598 2003-09-04 Martin Baulig <martin@ximian.com>
14600 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14603 2003-09-04 Martin Baulig <martin@ximian.com>
14605 * decl.cs (DeclSpace.LookupGeneric): New method.
14606 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14609 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14610 argument, not just a string.
14611 (TypeParameter.Define): New public method; this is called to
14612 actually define the generic parameter; after this, you can use the
14613 new `Type' property to get the type.
14615 2003-09-04 Martin Baulig <martin@ximian.com>
14617 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14618 is now an ArrayList; initialize the result of the `TypeParameters'
14620 (DeclSpace.GetGenericData): Removed.
14621 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14622 implement this in a different way.
14623 (DeclSpace.GetTypeParameters): Removed; there's now a
14624 `TypeParameters' property.
14625 (DeclSpace.TypeParameters): New public property.
14627 * generic.cs (Constraints): Make this class public.
14628 (TypeParameter): New public class.
14630 2003-09-04 Martin Baulig <martin@ximian.com>
14632 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14633 generic parameters.
14635 * class.cs (TypeContainer.DefineType): Call
14636 TypeBuilder.DefineGenericParameter () on all generic parameters if
14637 this is a generic type.
14639 2003-08-28 Martin Baulig <martin@ximian.com>
14641 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14644 * sample-hello.cs: Compile this with gmcs: "gmcs
14645 /r:sample-stack.dll sample-hello.cs".
14647 2003-08-28 Martin Baulig <martin@ximian.com>
14649 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14650 the parameters to the generic type.
14652 2003-08-28 Martin Baulig <martin@ximian.com>
14654 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14656 2003-08-28 Martin Baulig <martin@ximian.com>
14658 * cs-parser.jay (opt_type_argument_list): Use
14659 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14660 (primary_expression): Replace `qualified_identifier' with `type_name'.
14661 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14663 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14664 parser to check whether it is syntactically a type parameter list;
14665 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14668 2003-08-26 Martin Baulig <martin@ximian.com>
14670 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14671 resolving aliases; fixes #47927.
14673 2003-08-26 Martin Baulig <martin@ximian.com>
14675 * statement.cs (Using.DoResolve): This is internally emitting a
14676 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14677 do not always return. Fixes #47681.
14679 2003-08-26 Martin Baulig <martin@ximian.com>
14681 * decl.cs (MemberCore): Moved WarningNotHiding(),
14682 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14684 (AdditionResult): Make this nested in DeclSpace.
14685 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14686 argument; call NamespaceEntry.Define() unless we're nested in a
14689 * namespace.cs (Namespace.DefineName): New public function. This
14690 is called from DeclSpace's .ctor to add
14691 (Namespace.Lookup): Include DeclSpaces in the lookup.
14693 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14695 * const.cs (Const): Derive from MemberBase, not MemberCore.
14697 2003-08-25 Martin Baulig <martin@ximian.com>
14699 * convert.cs (Convert.ExplicitReferenceConversion): When
14700 converting from an interface type to a class, unbox if the target
14701 type is a struct type. Fixes #47822.
14703 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14705 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14708 2003-08-22 Martin Baulig <martin@ximian.com>
14710 * class.cs (TypeManager.DefineType): When defining a nested type,
14711 call DefineType() on our parent; fixes #47801.
14713 2003-08-22 Martin Baulig <martin@ximian.com>
14715 * class.cs (MethodData.Define): While checking if a method is an
14716 interface implementation, improve the test a bit more to fix #47654.
14718 2003-08-22 Martin Baulig <martin@ximian.com>
14720 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14721 correctly; fixes #47722.
14723 2003-08-22 Martin Baulig <martin@ximian.com>
14725 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14726 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14728 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14730 2003-08-22 Martin Baulig <martin@ximian.com>
14732 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14733 can only be assigned in static constructors. Fixes #47161.
14735 2003-08-22 Martin Baulig <martin@ximian.com>
14737 Rewrote and improved the flow analysis code.
14739 * flowbranching.cs (FlowBranching): Make this class abstract.
14740 (FlowBranching.CreateBranching): New static function to create a
14741 new flow branching.
14742 (FlowBranchingBlock, FlowBranchingException): New classes.
14743 (FlowBranching.UsageVector.Type): New public readonly field.
14744 (FlowBranching.UsageVector.Breaks): Removed the setter.
14745 (FlowBranching.UsageVector.Returns): Removed the setter.
14746 (FlowBranching.UsageVector): Added Break(), Return(),
14747 NeverReachable() and Throw() methods to modify the reachability.
14748 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14749 done by FlowBranching.Merge().
14750 (FlowBranching.UsageVector.MergeChild): New method; merges the
14751 merge result into the current vector.
14752 (FlowBranching.Merge): New abstract method to merge a branching.
14754 2003-08-12 Martin Baulig <martin@ximian.com>
14756 * expression.cs (Indirection.CacheTemporaries): Create the
14757 LocalTemporary with the pointer type, not its element type.
14759 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14761 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14762 token was a keyword or not.
14764 Add `error' options where an IDENTIFIER was expected; Provide
14765 CheckToken and CheckIdentifierToken convenience error reporting
14768 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14770 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14771 NameSpaceEntry NameSpaceEntry.
14773 (LookupInterfaceOrClass): Avoid creating a full qualified name
14774 from namespace and name: avoid doing lookups when we know the
14775 namespace is non-existant. Use new Tree.LookupByNamespace which
14776 looks up DeclSpaces based on their namespace, name pair.
14778 * driver.cs: Provide a new `parser verbose' to display the
14779 exception thrown during parsing. This is turned off by default
14780 now, so the output of a failure from mcs is more graceful.
14782 * namespace.cs: Track all the namespaces defined in a hashtable
14785 (IsNamespace): New method
14787 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14789 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14790 we know that we need to concatenate (full typename can never be
14795 * statement.cs: Use a bitfield; Do not initialize to null things
14796 which are done by the constructor by default.
14798 * cs-parser.jay: bug fix, parameter was 4, not 3.
14800 * expression.cs: Just use the property;
14802 * statement.cs: No need for GetVariableInfo method.
14804 2003-08-08 Martin Baulig <martin@ximian.com>
14806 * flowanalysis.cs (FlowReturns): This is now nested in the
14807 `FlowBranching' class.
14808 (MyBitVector): Moved this here from statement.cs.
14809 (FlowBranching.SiblingType): New enum type.
14810 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14812 2003-08-07 Martin Baulig <martin@ximian.com>
14814 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14815 `FlowBranching' class and called `BranchingType'.
14817 2003-08-07 Martin Baulig <martin@ximian.com>
14819 * flowanalysis.cs: Moved all the control flow analysis code into
14822 2003-08-07 Martin Baulig <martin@ximian.com>
14824 * assign.cs (Assign.DoResolve): `target' must either be an
14825 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14828 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14830 * expression.cs (BinaryMethod): This kind of expression is created by the
14831 Binary class if it determines that the operator has to be handled
14834 (BinaryDelegate): This kind of expression is created if we are
14835 dealing with a + or - operator on delegates.
14837 (Binary): remove method, argumetns, and DelegateOperator: when
14838 dealing with methods,
14840 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14842 * statement.cs (Block): use bitfields for the three extra booleans
14843 we had in use. Remove unused topblock parameter.
14845 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14847 * assign.cs: Drop extra unneeded tests.
14849 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14851 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14853 * statement.cs (Foreach): Use VariableStorage instead of
14856 * codegen.cs (VariableStorage): New class used by clients that
14857 require a variable stored: locals or fields for variables that
14858 need to live across yield.
14860 Maybe provide a convenience api for EmitThis+EmitLoad?
14862 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14865 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14867 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14868 RemapParameterLValue): New methods that are used to turn a
14869 precomputed FieldInfo into an expression like this:
14873 The idea is to use this instead of making LocalVariableReference
14874 have more than one meaning.
14876 * cs-parser.jay: Add error production to BASE.
14878 * ecore.cs: Deal with TypeManager.GetField returning null, which
14879 is now a valid return value.
14881 (FieldExprNoAddress): New expression for Fields whose address can
14884 * expression.cs (LocalVariableReference): During the resolve
14885 phases, create new expressions if we are in a remapping context.
14886 Remove code that dealt with remapping here.
14888 (ParameterReference): same.
14890 (ProxyInstance): New expression, like the `This' expression, but
14891 it is born fully resolved. We know what we are doing, so remove
14892 the errors that are targeted to user-provided uses of `this'.
14894 * statement.cs (Foreach): our variable is now stored as an
14895 Expression; During resolution, follow the protocol, dont just
14896 assume it will return this.
14898 2003-08-06 Martin Baulig <martin@ximian.com>
14900 * support.cs (SeekableStreamReader.cs): New public class.
14902 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14903 SeekableStreamReader instead of the normal StreamReader.
14905 2003-08-04 Martin Baulig <martin@ximian.com>
14907 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14908 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14909 deambiguate casts and delegate invocations.
14910 (parenthesized_expression): Use the new tokens to ensure this is
14911 not a cast of method invocation.
14913 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14914 when reading a `)' and Deambiguate_CloseParens () was previously
14917 * expression.cs (ParenthesizedExpression): New class. This is
14918 just used for the CS0075 test.
14919 (Binary.DoResolve): Check for CS0075.
14921 2003-07-29 Ravi Pratap <ravi@ximian.com>
14923 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14924 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14925 reference comparison.
14927 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14928 examine the ReturnType for equality - this is necessary in the
14929 cases of implicit and explicit operators whose signature also
14930 includes the return type.
14932 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14934 * namespace.cs: Cache the result of the namespace computation,
14935 instead of computing it every time.
14937 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14939 * decl.cs: Use a global arraylist that we reuse over invocations
14940 to avoid excesive memory consumption. Reduces memory usage on an
14941 mcs compile by one meg (45 average).
14943 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14944 private, work around that.
14946 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14948 * literal.cs (IntLiteral): Define Zero and One static literals.
14950 * cs-parser.jay (integer_literal): use static literals to reduce
14951 memory usage for the most used literals (0, 1 and -1). 211kb
14952 reduced in memory usage.
14954 Replace all calls to `new ArrayList' with `new
14955 ArrayList(4)' which is a good average number for most allocations,
14956 and also requires only 16 bytes of memory for its buffer by
14959 This reduced MCS memory usage in seven megabytes for the RSS after
14962 2003-07-28 Ravi Pratap <ravi@ximian.com>
14964 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14965 handle params methods the correct way by forming only one
14966 applicable set with params and normal methods in them. Earlier we
14967 were looking at params methods only if we found no normal methods
14968 which was not the correct thing to do.
14970 (Invocation.BetterFunction): Take separate arguments indicating
14971 when candidate and the best method are params methods in their
14974 This fixes bugs #43367 and #46199.
14976 * attribute.cs: Documentation updates.
14978 (CheckAttribute): Rename to CheckAttributeTarget.
14979 (GetValidPlaces): Rename to GetValidTargets.
14981 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14982 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14986 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14988 * codegen.cs: Compute IsGeneric correctly.
14990 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14993 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14994 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14995 regressions, and I was chasing more bugs than I required.
14997 * interface.cs: Use expressions for base type names (like classes
14998 and structs have been doing for a while now), and resolve that.
14999 This patch should probably go into head as well.
15001 This makes it one less user of FindType.
15003 2003-07-24 Miguel de Icaza <miguel@ximian.com>
15005 This compiler can not self host currently. Need to fix that.
15007 * Makefile: compile to `gmcs.exe'
15009 * driver.cs: Turn on v2 by default on gmcs.
15011 * generic.cs (ConstructedType): Does no longer take a container
15012 type argument; That will be taken care of later.
15014 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
15015 Use SimpleName to resolve for now, so we can continue the work on
15016 the parser, until we get Type.GetType that understands generics.
15018 (ConstructedType.ToString): Implement
15020 (TypeArguments.Resolve): Resolve the child expressions as types.
15022 * cs-parser.jay: Rename interface_constraints to
15023 type_parameter_constraints
15025 (namespace_or_type_name): Only use constructed types for the basic
15026 construction, we will deal with identifier<...> later.
15028 (type/type_name): No longer call DecomposeQI, as
15029 namespace_or_type_name is always decoded now.
15031 2003-07-22 Ravi Pratap <ravi@ximian.com>
15033 * expression.cs (Invocation.OverloadResolve): Follow the spec more
15034 closely: we eliminate methods in base types when we have an
15035 applicable method in a top-level type.
15037 Please see section 14.5.5.1 for an exact description of what goes
15040 This fixes bug #45127 and a host of other related to corlib compilation.
15042 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
15043 array is the method corresponding to the top-level type (this is
15044 because of the changes made to icall.c) so we change this
15047 (MethodGroupExpr.Name): This too.
15049 * typemanager.cs (GetElementType): New method which does the right
15050 thing when compiling corlib.
15052 * everywhere: Make use of the above in the relevant places.
15054 2003-07-22 Martin Baulig <martin@ximian.com>
15056 * cs-parser.jay (invocation_expression): Moved
15057 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
15058 `cast_expression', but create a InvocationOrCast which later
15059 resolves to either an Invocation or a Cast.
15061 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
15062 method; call this before EmitStatement() to make sure that this
15063 expression can be used as a statement.
15065 * expression.cs (InvocationOrCast): New class; resolves to either
15066 an Invocation or a Cast.
15068 * statement.cs (StatementExpression): Call ResolveStatement() on
15069 the ExpressionStatement before emitting it.
15071 2003-07-21 Martin Baulig <martin@ximian.com>
15073 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
15074 `ref' and `out' attributes match; fixes #46220.
15075 (MemberAccess.ResolveMemberAccess): You can't reference a type
15076 through an expression; fixes #33180.
15077 (Indexers.GetIndexersForType): Don't return the indexers from
15078 interfaces the class implements; fixes #46502.
15080 2003-07-21 Martin Baulig <martin@ximian.com>
15082 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
15083 CS0661 checks; fixes bug #30442.
15085 2003-07-21 Martin Baulig <martin@ximian.com>
15087 * decl.cs (AdditionResult): Added `Error'.
15089 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
15091 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
15092 cs0031.cs actually work.
15094 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15096 * cs-parser.jay (namespace_name): do not use
15097 namespace_or_type_name, use qualified_identifier, because
15098 namespace_or_type_name will soon return a composed expression
15099 instead of a string.
15101 (namespace_or_type_name): Instead of returning a string, now this
15102 production returns an expression.
15104 * codegen.cs (EmitContext): Setup IsGeneric property based on
15105 whether our DeclSpace is generic, our the method is generic.
15107 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
15108 the method is generic.
15110 * cs-parser.jay (type_arguments, opt_type_argument_list,
15111 type_parameters, type_parameter_list, opt_type_parameter_list,
15112 type_parameter,, opt_type_parameter_constraints_clauses,
15113 type_parameter_constraints_clauses,
15114 type_parameter_constraint_clause, type_parameter_constraint,
15115 interface_constraints): Add new production
15117 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
15118 DeclSpace is generic or not.
15120 (DeclSpace.SetParameterInfo): New routine, used to set the
15121 parameter info for a type.
15123 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
15124 returns a GenericTypeExpr
15126 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
15127 generic, lookup the generic argument.
15129 * attribute.cs: Do not allow TypeParameterExpressions in
15132 * class.cs: Do not allow the Main method to be defined in a
15135 * expression.cs (SizeOf): Do not allow generic types to be used as
15136 arguments to sizeof.
15138 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
15139 it: whether a type is generic or not. Only works for types we are
15140 currently building for now.
15142 2003-07-20 Martin Baulig <martin@ximian.com>
15144 * namespace.cs: Fixed that bug which caused a crash when compiling
15145 the debugger's GUI.
15147 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15149 * typemanager.cs (LookupTypeReflection): Never expose types which
15150 are NotPublic, NestedPrivate, NestedAssembly, or
15151 NestedFamANDAssem. We used to return these, and later do a check
15152 that would report a meaningful error, but the problem is that we
15153 would not get the real match, if there was a name override.
15155 2003-07-18 Miguel de Icaza <miguel@ximian.com>
15157 * namespace.cs (Namespace, Name): Do not compute the namespace
15158 name dynamically, compute it in the constructor. This reduced
15159 memory usage by 1697 KB.
15161 * driver.cs: Use --pause to pause at the end.
15163 2003-07-17 Peter Williams <peter@newton.cx>
15165 * Makefile: Change the name of the test target so that it doesn't
15166 conflict with the recursive test target.
15168 2003-07-17 Miguel de Icaza <miguel@ximian.com>
15170 * expression.cs (LocalVariableReference.Emit, EmitAssign,
15171 AddressOf): Do not use EmitThis, that was wrong, use the actual
15174 2003-07-15 Miguel de Icaza <miguel@ximian.com>
15176 * class.cs (MethodData.Define): While checking if a method is an
15177 interface implementation, improve the test: If we are not public
15178 (use new test here: use the computed MethodAttributes directly,
15179 instead of the parsed modifier flags) check if the `implementing'
15180 method comes from an interface or not.
15182 * pending.cs (VerifyPendingMethods): Slightly better error
15185 * makefile: add test target that does the mcs bootstrap.
15187 2003-07-16 Ravi Pratap <ravi@ximian.com>
15189 * interface.cs (Define): Do nothing here since there are no
15190 members to populate etc. Move the attribute emission out of here
15191 since this was just totally the wrong place to put it. Attribute
15192 application happens during the 'Emit' phase, not in the 'Define'
15195 (Emit): Add this method and move the attribute emission here
15197 * rootcontext.cs (EmitCode): Call the Emit method on interface
15200 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15202 * expression.cs (OverloadResolve): Report error only if Location
15203 is not 'Null' which means that there was a probe going on.
15205 2003-07-14 Martin Baulig <martin@ximian.com>
15207 * expression.cs (ConditionalLogicalOperator): New public class to
15208 implement user defined conditional logical operators.
15209 This is section 14.11.2 in the spec and bug #40505.
15211 2003-07-14 Martin Baulig <martin@ximian.com>
15213 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
15215 2003-07-14 Martin Baulig <martin@ximian.com>
15217 * codegen.cs (EmitContext.InFixedInitializer): New public field.
15219 * ecore.cs (IVariable.VerifyFixed): New interface method.
15221 * expression.cs (Unary.ResolveOperator): When resolving the `&'
15222 operator, check whether the variable is actually fixed. Fixes bug
15223 #36055. Set a variable definitely assigned when taking its
15224 address as required by the spec.
15226 * statement.cs (LocalInfo.IsFixed): New field.
15227 (LocalInfo.MakePinned): Set `IsFixed' to true.
15229 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15231 * attribute.cs (Attribute.Resolve): While doing a Member lookup
15232 for .ctors, ensure that we only ask for members declared in the
15233 attribute type (BindingFlags.DeclaredOnly).
15237 * expression.cs (Error_WrongNumArguments): Report error 1501
15238 correctly the way CSC does.
15240 2003-07-13 Martin Baulig <martin@ximian.com>
15242 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
15243 lookup on the fully qualified name, to make things like "X.X" work
15244 where "X.X" is a fully qualified type name, but we also have a
15245 namespace "X" in the using list. Fixes #41975.
15247 2003-07-13 Martin Baulig <martin@ximian.com>
15249 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
15250 function. If we're a CompoundAssign, we need to create an embedded
15251 CompoundAssign, not an embedded Assign.
15252 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
15255 2003-07-13 Martin Baulig <martin@ximian.com>
15257 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
15258 work to fix bug #46088.
15260 2003-07-13 Ravi Pratap <ravi@ximian.com>
15262 * class.cs (Operator.Emit): Do not emit attributes here - it is
15263 taken care of by the Method class that we delegate too. This takes
15264 care of bug #45876.
15266 2003-07-10 Martin Baulig <martin@ximian.com>
15268 * expression.cs (TypeOfVoid): New class.
15269 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
15271 2003-07-10 Martin Baulig <martin@ximian.com>
15273 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
15276 2003-07-10 Martin Baulig <martin@ximian.com>
15278 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
15279 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
15281 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
15283 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
15285 2003-07-10 Martin Baulig <martin@ximian.com>
15287 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
15288 of decimal. Fixes #42850.
15290 NOTE: I also fixed the created byte blob, but this doesn't work on
15291 the MS runtime and csc never produces any byte blobs for decimal
15294 2003-07-10 Martin Baulig <martin@ximian.com>
15296 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
15297 structs; fixes #32068.
15298 (Block.AddChildVariableNames): Fixed #44302.
15300 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15302 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
15304 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15306 * attribute.cs: And this test is onger needed.
15308 2003-07-08 Martin Baulig <martin@ximian.com>
15310 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
15311 inaccessible types. Fixes #36313.
15313 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
15315 * namespace.cs (NamespaceEntry): Create implicit entries for all
15316 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
15317 implicit entries for N1.N2 and N1.
15319 2003-07-08 Martin Baulig <martin@ximian.com>
15321 Rewrote the handling of namespaces to fix a lot of the issues
15322 wrt. `using' aliases etc.
15324 * namespace.cs (Namespace): Splitted this class into a
15325 per-assembly `Namespace' and a per-file `NamespaceEntry'.
15327 * typemanager.cs (TypeManager.IsNamespace): Removed.
15328 (TypeManager.ComputeNamespaces): Only compute namespaces from
15329 loaded assemblies here, not the namespaces from the assembly we're
15330 currently compiling.
15332 2003-07-08 Martin Baulig <martin@ximian.com>
15334 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
15336 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15338 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
15341 I thought about the memory savings here, but LookupTypeReflection
15342 is used under already very constrained scenarios. Compiling
15343 corlib or mcs only exposes one hit, so it would not really reduce
15344 any memory consumption.
15346 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15348 * typemanager.cs: fixes bug #45889 by only adding public types from
15349 other assemblies to the list of known types.
15351 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15353 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
15354 on the type we resolved.
15356 2003-07-05 Martin Baulig <martin@ximian.com>
15358 * pending.cs (PendingImplementation.ParentImplements): Don't
15359 create the proxy if the parent is abstract.
15361 * class.cs (TypeContainer.DefineIndexers): Process explicit
15362 interface implementations first. Fixes #37714.
15364 2003-07-04 Miguel de Icaza <miguel@ximian.com>
15366 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
15367 defined recursively; but since we modify the input parameters
15368 (left is set to `this' temporarily), we reset this value if the
15369 left_is_explicit is false, which gives the original semantics to
15372 * literal.cs (NullPointer): new class used to represent a null
15373 literal in a pointer context.
15375 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
15376 type is a pointer, use a NullPointer object instead of a
15377 NullLiteral. Closes 43687
15379 (ExplicitConversion): Convert pointer values using
15380 the conv opcode to the proper type.
15382 * ecore.cs (New): change ValueTypeVariable property into a method,
15383 that returns whether the valuetype is suitable for being used.
15385 * expression.cs (Binary.DoNumericPromotions): Only return if we
15386 the int constant was a valid uint, and we can return both left and
15387 right as uints. If not, we continue processing, to trigger the
15388 type conversion. This fixes 39018.
15390 * statement.cs (Block.EmitMeta): During constant resolution, set
15391 the CurrentBlock property on the emitcontext, so that we resolve
15392 constants propertly.
15394 2003-07-02 Martin Baulig <martin@ximian.com>
15396 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
15397 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
15399 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
15400 than emitting it here.
15402 * statement.cs: Fixed some more flow analysis bugs.
15404 2003-07-02 Martin Baulig <martin@ximian.com>
15406 * class.cs (MethodData.Define): When implementing interface
15407 methods, set Final unless we're Virtual.
15409 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
15410 check work for interface methods.
15412 2003-07-01 Martin Baulig <martin@ximian.com>
15414 * ecore.cs (EmitContext.This): Replaced this property with a
15415 GetThis() method which takes a Location argument. This ensures
15416 that we get the correct error location for a CS0188.
15418 2003-07-01 Miguel de Icaza <miguel@ximian.com>
15420 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
15421 ImplicitStandardConversion.
15423 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
15425 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
15427 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
15430 2003-06-30 Miguel de Icaza <miguel@ximian.com>
15432 * class.cs (Constructor.Define): Turn off initlocals for unsafe
15435 (MethodData.Define): Turn off initlocals for unsafe methods.
15437 2003-06-29 Miguel de Icaza <miguel@ximian.com>
15439 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
15440 complete; Fixes #37521.
15442 * delegate.cs: Use Modifiers.TypeAttr to compute the
15443 TypeAttributes, instead of rolling our own. This makes the flags
15444 correct for the delegates.
15446 2003-06-28 Miguel de Icaza <miguel@ximian.com>
15448 * class.cs (Constructor.Define): Set the private flag for static
15449 constructors as well.
15451 * cs-parser.jay (statement_expression): Set the return value to
15452 null, to avoid a crash when we catch an error.
15454 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15456 * cs-parser.jay: Applied patch from Jackson that adds support for
15457 extern and unsafe modifiers to destructor declarations.
15459 * expression.cs: Report error 21 if the user is trying to index a
15462 * driver.cs: Add an error message, suggested by the bug report.
15464 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15465 if we do not have a ": this ()" constructor initializer. Fixes 45149
15467 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15469 * namespace.cs: Add some information to reduce FAQs.
15471 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15473 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15474 underlying enumeration types. Fixes #43915.
15476 * expression.cs: Treat ushort/short as legal values to be used in
15477 bitwise operations.
15479 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15481 * delegate.cs: transfer custom attributes for paramenters from
15482 the delegate declaration to Invoke and BeginInvoke.
15484 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15486 * attribute.cs: handle custom marshalers and emit marshal info
15489 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15491 * makefile.gnu: Added anonymous.cs to the compiler sources.
15493 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15495 * iterators.cs: Change the name of the proxy class to include two
15498 * cs-parser.jay: Update grammar to include anonymous methods.
15500 * anonymous.cs: new file.
15502 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15504 * class.cs (Field.Define): Add missing test for pointers and
15507 2003-05-27 Ravi Pratap <ravi@ximian.com>
15509 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15510 we use the stobj opcode.
15512 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15513 since it wasn't the correct fix.
15515 It still is puzzling that we are required to use stobj for IntPtr
15516 which seems to be a ValueType.
15518 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15520 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15521 during regular simple name resolution. Now, the trick is that
15522 instead of returning for processing the simplename, we do a
15523 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15524 contextual lookup type). If a match is found, return that, if
15525 not, return for further composition.
15527 This fixes long-standing 30485.
15529 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15530 using the address to initialize an object, do an Stobj instead of
15531 using the regular Stelem.
15533 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15534 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15535 Because if we are a BaseIndexerAccess that value will be true.
15538 * statement.cs (GotoCase.Resolve): Return after reporting an
15539 error, do not attempt to continue.
15541 * expression.cs (PointerArithmetic.Emit): If our operand is a
15542 long, convert our constants to match the operand before
15543 multiplying. Convert to I type before adding. Fixes 43670.
15545 2003-05-14 Ravi Pratap <ravi@ximian.com>
15547 * enum.cs (ImplicitConversionExists) : Rename to
15548 ImplicitEnumConversionExists to remove ambiguity.
15550 * ecore.cs (NullCast): New type of cast expression class which
15551 basically is very similar to EmptyCast with the difference being
15552 it still is a constant since it is used only to cast a null to
15554 (eg. (string) null)
15556 * convert.cs (ImplicitReferenceConversion): When casting a null
15557 literal, we return a NullCast.
15559 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15560 should be around anymore.
15562 The renaming (reported was slightly wrong). Corrections:
15564 ConvertImplicitStandard -> ImplicitConversionStandard
15565 ConvertExplicitStandard -> ExplicitConversionStandard
15567 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15568 before passing them in !
15570 * convert.cs (ImplicitConversionStandard): When comparing for
15571 equal expr and target types, ensure that expr is not a
15574 In general, we must not be checking (expr_type ==
15575 target_type) in the top level conversion methods
15576 (ImplicitConversion, ExplicitConversion etc). This checking is
15577 done in the methods that they delegate to.
15579 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15581 * convert.cs: Move Error_CannotConvertType,
15582 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15583 ImplicitNumericConversion, ImplicitConversionExists,
15584 ImplicitUserConversionExists, StandardConversionExists,
15585 FindMostEncompassedType, FindMostSpecificSource,
15586 FindMostSpecificTarget, ImplicitUserConversion,
15587 ExplicitUserConversion, GetConversionOperators,
15588 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15589 TryImplicitIntConversion, Error_CannotConvertImplicit,
15590 ConvertImplicitRequired, ConvertNumericExplicit,
15591 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15592 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15595 Perform the following renames:
15597 StandardConversionExists -> ImplicitStandardConversionExists
15598 ConvertImplicit -> ImplicitConversion
15599 ConvertImplicitStandard -> ImplicitStandardConversion
15600 TryImplicitIntConversion -> ImplicitIntConversion
15601 ConvertImplicitRequired -> ImplicitConversionRequired
15602 ConvertNumericExplicit -> ExplicitNumericConversion
15603 ConvertReferenceExplicit -> ExplicitReferenceConversion
15604 ConvertExplicit -> ExplicitConversion
15605 ConvertExplicitStandard -> ExplicitStandardConversion
15607 2003-05-19 Martin Baulig <martin@ximian.com>
15609 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15610 (TypeInfo): Added support for structs having structs as fields.
15612 * ecore.cs (FieldExpr): Implement IVariable.
15613 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15614 VariableInfo for the field.
15616 2003-05-18 Martin Baulig <martin@ximian.com>
15618 * expression.cs (This.DoResolve): Report a CS0027 if we're
15619 emitting a field initializer.
15621 2003-05-18 Martin Baulig <martin@ximian.com>
15623 * expression.cs (This.ResolveBase): New public function.
15624 (This.DoResolve): Check for CS0188.
15626 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15629 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15630 `instance_expression' to null if we don't have any non-static
15633 2003-05-18 Martin Baulig <martin@ximian.com>
15635 Reworked the way how local variables and parameters are handled by
15636 the flow analysis code.
15638 * statement.cs (TypeInfo, VariableMap): New public classes.
15639 (VariableInfo): New public class. This is now responsible for
15640 checking whether a variable has been assigned. It is used for
15641 parameters and local variables.
15642 (Block.EmitMeta): Take the InternalParameters as argument; compute
15643 the layout of the flow vectors here.
15644 (Block.LocalMap, Block.ParameterMap): New public properties.
15645 (FlowBranching): The .ctor doesn't get the InternalParameters
15646 anymore since Block.EmitMeta() now computes the layout of the flow
15648 (MyStructInfo): This class is now known as `StructInfo' and nested
15649 in `TypeInfo'; we don't access this directly anymore.
15651 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15652 property and removed IsAssigned(), IsFieldAssigned(),
15653 SetAssigned() and SetFieldAssigned(); we now call them on the
15654 VariableInfo so we don't need to duplicate this code everywhere.
15656 * expression.cs (ParameterReference): Added `Block block' argument
15658 (LocalVariableReference, ParameterReference, This): The new
15659 VariableInfo class is now responsible for all the definite
15662 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15663 IsParameterAssigned, SetParameterAssigned): Removed.
15665 2003-05-18 Martin Baulig <martin@ximian.com>
15667 * typemanager.cs (InitCoreTypes): Try calling
15668 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15669 the 3-args-version. Corlib now also needs our `void_type'.
15670 (GetMethod): Added overloaded version which takes an optional
15671 `bool report_errors' to allow lookups of optional methods.
15673 2003-05-12 Martin Baulig <martin@ximian.com>
15675 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15676 only used for locals and not for parameters.
15678 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15680 * support.cs (InternalParameters.ParameterType): Return the
15681 ExternalType of the parameter.
15683 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15686 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15688 * class.cs (MethodData.Define): Do not set the `newslot' on
15689 interface members, if they are also flagged as "override".
15691 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15692 better code for ++i and i++. This only works for static fields
15693 and local variables.
15695 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15696 want to pull the DeclSpace out of the builder_to_declspace instead
15697 of the TypeBuilder (like in TypeContainer.FindMembers).
15699 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15700 instead of LookupTypeContainer. Fixes the crash on .NET for
15701 looking up interface members.
15703 * const.cs: Create our own emit context during the Definition
15704 stage, so that constants are evaluated in the proper context, when
15705 a recursive definition happens.
15707 2003-05-11 Martin Baulig <martin@ximian.com>
15709 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15710 new block for a switch section.
15711 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15712 the adding/lookup in the switch block. Fixes #39828.
15714 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15716 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15717 functionality: I needed to convert the data after I had performed
15718 the add/sub operation into the operands type size.
15720 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15721 pass the type for the box operation, otherwise the resulting
15722 object would have been of type object.
15724 (BoxedCast): Add constructor to specify the type to box as.
15726 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15728 * iterators.cs: I was reusing the `count' variable inadvertently,
15729 take steps to not allow this to happen.
15731 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15733 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15734 by creating an array at the point where the params starts and
15735 putting all those arguments there, then adjusting the size of the
15738 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15740 * expression.cs (New.AddressOf): Implement interface
15741 IMemoryLocation. This is used when the `new' operator is used in
15742 the context of an invocation to a method on a value type.
15744 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15747 * namespace.cs: Also check the using aliases here.
15749 * driver.cs: Move the test for using validity after the types have
15750 been entered, so we do a single pass that also includes the using
15753 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15754 in the regular case. CreateSiblingForFinally is doing extra
15757 * attribute.cs (GetAttributeArgumentExpression): Store the result
15758 on an out value, and use the return value to indicate failure
15759 instead of using null (which is a valid return for Constant.GetValue).
15761 * statement.cs: Perform the analysis flow for the increment
15762 portion after the statement, because this will be the real flow of
15763 execution. Fixes #42385
15765 * codegen.cs (EmitContext.EmitArgument,
15766 EmitContext.EmitStoreArgument): New helper functions when the
15767 RemapToProxy flag is set.
15769 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15772 Add support for remapping parameters.
15774 * iterators.cs: Propagate parameter values; Store parameter
15775 values in the proxy classes.
15777 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15779 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15780 need a proxy reference; I do not know what I was thinking
15782 * cs-parser.jay (constructor_initializer): catch another error,
15783 and display nice message.
15785 (field_declaration): catch void field declaration
15786 to flag a better error.
15788 * class.cs (MemberBase.CheckBase): Report an error instead of a
15789 warning if a new protected member is declared in a struct.
15790 (Field.Define): catch the error of readonly/volatile.
15792 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15794 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15795 volatile variable is taken
15797 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15799 * statement.cs (Fixed.Resolve): Report an error if we are not in
15802 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15804 * typemanager.cs: reuse the code that handles type clashes for
15805 delegates and enumerations.
15807 * class.cs (Report28): Always report.
15809 * expression.cs (EncodeAsAttribute): Allow nulls here.
15811 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15813 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15814 the functionality for testing whether an expression is valid for
15815 an attribute here. Also handle the case of arrays of elements
15818 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15819 encoding a linear array into an array of objects that are suitable
15820 to be passed to an CustomAttributeBuilder.
15822 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15824 * ecore.cs: (FieldExpr): Handle field remapping here.
15826 * iteratators.cs: Pass the instance variable (if the method is an
15827 instance method) to the constructors, so we can access the field
15828 variables on the class.
15830 TODO: Test this with structs. I think the THIS variable on
15831 structs might have to be a pointer, and not a refenrece
15833 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15835 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15836 local variables to fields in a proxy class.
15838 * iterators.cs (PopulateProxy): Rename our internal fields to
15840 Create a <THIS> field if we are an instance method, so we can
15841 reference our parent container variables.
15842 (MapVariable): Called back from the EmitContext code to enter a
15843 new variable to field mapping into the proxy class (we just create
15847 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15848 for using the remapped locals to fields.
15850 I placed the code here, because that gives the same semantics to
15851 local variables, and only changes the Emit code.
15853 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15854 statements inside iterators.
15855 (VariableInfo): Add a FieldBuilder for the cases when we are
15856 remapping local variables to fields in a proxy class
15858 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15859 current_block != null.
15861 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15862 not cope with strings, as it has been moved to the
15863 TableSwitchEmit. Fixed bug in switch generation.
15865 * expression.cs (New.DoResolve): Provide more context for the user
15866 when reporting an error.
15868 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15871 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15872 check the permissions for it. Note than in a type-resolution
15873 context the check was already present in DeclSpace.ResolveType,
15874 but was missing from the MemberAccess.
15876 (ArrayCreation.CheckIndices): warn if the user has
15877 more nested levels of expressions, but there are no more
15878 dimensions specified. Avoids crash on bug 41906.
15880 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15882 * statement.cs (Block): replace Implicit bool, for a generic
15884 New flag: `Unchecked'. This is used during the EmitMeta phase
15885 (which is out-of-line with the regular Resolve/Emit process for a
15886 statement, as this is done ahead of time, but still gets a chance
15887 to call constant resolve).
15889 (Block.Flags): new enum for adding a new flag.
15891 (Block.EmitMeta): track the state of unchecked.
15893 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15894 to enable constant resolution to work there as well.
15896 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15898 * typemanager.cs (ienumerable_type): Also look up
15899 System.Collections.IEnumerable.
15901 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15903 TODO: Test more than one conditional per method.
15905 * class.cs (Indexer.Define): Report the location where the user is
15906 referencing the unsupported feature.
15908 (MethodData): Overload the use of `conditionals' to
15909 minimize the creation of needless ArrayLists. This saves roughly
15910 212kb on my machine.
15912 (Method): Implement the new IIteratorContainer interface.
15913 (Method.SetYields): Implement the method by setting the ModFlags
15914 to contain METHOD_YIELDS.
15916 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15917 which just got set to null.
15919 * iterators.cs: New file.
15921 (Yield, YieldBreak): New statements.
15923 * statement.cs (Return.Resolve): Flag an error if we are used in
15924 an iterator method.
15926 * codegen.cs (InIterator): New flag set if the code is being
15927 compiled in an iterator method.
15929 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15930 internal modifier, and we just use it to avoid adding extra
15931 fields, as this is seldom used.
15933 * cs-parser.jay: Add yield_statement (yield and yield break).
15935 * driver.cs: New flag -v2 to turn on version 2 features.
15937 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15938 hashtable when v2 is enabled.
15940 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15942 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15943 there is already a namespace defined with this name.
15945 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15946 people upgraded their corlibs.
15948 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15949 always use fully qualified types, no need to use the compiler
15952 (TypeManager.IsNamespace): Use binarysearch.
15954 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15955 AddDelegate): I did not quite use the new IsValid API properly: I
15956 have to pass the short-name and the fullname. I was passing only
15957 the basename instead of the fullname sometimes.
15959 (TypeContainer.DefineType): call NamespaceClash.
15961 * interface.cs (Interface.DefineType): use NamespaceClash before
15964 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15967 * enum.cs: (Enum.DefineType): use NamespaceClash before
15970 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15971 speed increase. First, use the negative_hits cache when we get a
15972 negative. Second, add the type with its full original name
15973 instead of the new . and + encoded name (reflection uses + to
15974 separate type from a nested type). Use LookupTypeReflection
15975 directly which bypasses the type->name hashtable (that we already
15976 know does not contain the type.
15978 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15979 location/container type.
15981 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15983 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15985 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15987 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15988 method is being referenced in the method group from a static
15989 context, and report error 120 if so.
15991 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15994 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15995 is created, we create the A namespace).
15997 * cs-parser.jay: A namespace also introduces a DeclarationFound.
16000 2003-04-18 Miguel de Icaza <miguel@ximian.com>
16002 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
16003 invocation to ModuleBuilder.GetType with the same values will
16004 return a new type instance, so we need to cache its return
16007 * expression.cs (Binary.ResolveOperator): Only allow the compare
16008 operators on enums if they are of the same type.
16010 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
16011 types of ValueType on their own case. Before we were giving them
16012 the same treatment as objects.
16014 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
16015 fullname. Short name is used to compare against container name.
16016 Fullname is used to check against defined namespace names.
16018 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
16019 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
16021 (Method.CheckBase): Call parent.
16022 (MemberBase.CheckBase): Check for protected members on sealed
16024 (PropertyBase.CheckBase): Call parent.
16025 (Field.Define): Call parent.
16027 * report.cs: Negative error codes are now mapped to 8000 - code,
16028 so that the display is render more nicely.
16030 * typemanager.cs: Do not use try/catch, instead report a regular
16033 (GetPointerType, GetReferenceType): These methods provide
16034 mechanisms to obtain the T* and T& from a T. We had the code
16035 previously scattered around the code base, and it also used
16036 TypeManager.LookupType that would go through plenty of caches.
16037 This one goes directly to the type source.
16039 In some places we did the Type.GetType followed by
16040 ModuleBuilder.GetType, but not in others, so this unifies the
16041 processing as well.
16043 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
16044 statements now that we have namespace information.
16046 * typemanager.cs (IsNamespace): New method, returns whether the
16047 string presented is a namespace or not.
16049 (ComputeNamespaces): New public entry point, computes the list of
16050 available namespaces, using the GetNamespaces API call in Mono, or
16051 the slower version in MS.NET.
16053 Now before we start the semantic analysis phase, we have a
16054 complete list of namespaces including everything that the user has
16057 Deleted old code to cache namespaces in .nsc files.
16059 2003-04-17 Miguel de Icaza <miguel@ximian.com>
16061 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
16062 class/struct location definition Location for the implicit
16063 constructor location.
16065 (Operator.Define): Use the location of the operator for the
16066 implicit Method definition.
16068 (Constructor.Emit): use the constructor location for the implicit
16069 base initializer constructor.
16071 * ecore.cs: Remove ITypeExpression. This interface is now gone,
16072 and the Expression class now contains two new methods:
16074 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
16075 isolate type lookup from the rest of the resolution process.
16077 Since we use Expressions to hold type definitions due to the way
16078 we parse the input we have historically overloaded Resolve to
16079 perform the Type lookups if a special flag is passed. Now this is
16080 eliminated and two methods take their place.
16082 The differences in the two methods between xStep and xTerminal is
16083 that xStep is involved in our current lookup system that uses
16084 SimpleNames to compose a name, while xTerminal is used just to
16085 catch the case where the simplename lookup failed.
16087 2003-04-16 Miguel de Icaza <miguel@ximian.com>
16089 * expression.cs (ResolveMemberAccess): Remove redundant code.
16090 TypeExpr expressions are always born fully resolved.
16092 * interface.cs (PopulateMethod): Do not lookup the types twice.
16093 We were doing it once during SemanticAnalysis and once during
16096 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
16097 in local variable type definitions, were being returned as a
16098 SimpleName (we decomposed everything into a string), that is
16099 because primary_expression was being used instead of a type in the
16100 grammar (reduce/reduce conflicts).
16102 The part that was wrong is that we converted the expression into a
16103 string (an oversimplification in one hand, compounded with primary
16104 expressions doing string concatenation).
16110 Would return "A.B.C[]" as a SimpleName. This stopped things like
16111 using clauses from working on this particular context. And a type
16112 was being matched directly against "A.B.C[]".
16114 We now use the correct approach, and allow for ComposedCast to be
16115 part of the unary expression. So the "A.B.C []" become a composed
16116 cast of "A.B.C" (as a nested group of MemberAccess with a
16117 SimpleName at the end) plus the rank composition "[]".
16121 2003-04-10 Miguel de Icaza <miguel@ximian.com>
16123 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
16124 for the access level checking.
16126 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
16127 `TypeContainer container', because I kept getting confused when I
16128 was debugging this code.
16130 * expression.cs (Indexers): Instead of tracking getters/setters,
16131 we now track them in parallel. We create one arraylist less, but
16132 most importantly it is possible now for the LValue code to find a
16133 matching get for a set.
16135 (IndexerAccess.DoResolveLValue): Update the code.
16136 GetIndexersForType has been modified already to extract all the
16137 indexers from a type. The code assumed it did not.
16139 Also make the code set the correct return type for the indexer.
16140 This was fixed a long time ago for properties, but was missing for
16141 indexers. It used to be void_type.
16143 (Binary.Emit): Test first for doubles instead of
16144 floats, as they are more common.
16146 (Binary.EmitBranchable): Use the .un version of the branch opcodes
16147 when dealing with floats and the <=, >= operators. This fixes bug
16150 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
16151 to load the array value by emitting a load on the foreach variable
16152 type. This was incorrect.
16154 We now emit the code to load an element using the the array
16155 variable type, and then we emit the conversion operator.
16159 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
16161 * attribute.cs: Avoid allocation of ArrayLists in the common case.
16163 2003-04-09 Miguel de Icaza <miguel@ximian.com>
16165 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
16166 test for protection before we test for signatures.
16168 (MethodSignature.ToString): implement.
16170 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
16171 to the case where we reduced into a LongConstant.
16173 * decl.cs (CheckAccessLevel): If the type is an array, we can not
16174 depend on whether the information is acurrate, because the
16175 Microsoft runtime will always claim that the array type is public,
16176 regardless of the real state.
16178 If the type is a pointer, another problem happens: the type is
16179 reported as non-public in Microsoft.
16181 In both cases we have to call CheckAccessLevel recursively with
16182 the underlying type as the argument to be tested.
16184 2003-04-08 Miguel de Icaza <miguel@ximian.com>
16186 * assign.cs (Assign.Emit): If we are dealing with a compound
16187 assignment expression, we should use the code path that stores the
16188 intermediate result in a temporary value. This fixes #40903.
16190 *expression.cs (Indirection.ToString): Provide ToString method for
16193 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
16195 * class.cs: Null out fields holding references to Block objects so
16196 they can be garbage collected.
16198 * expression.cs (OverloadResolve): Remove unused local.
16200 2003-04-07 Martin Baulig <martin@ximian.com>
16202 * codegen.cs (EmitContext.CurrentFile): New public field.
16203 (EmitContext.Mark): Use the CurrentFile to check whether the
16204 location is in the correct file.
16205 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
16207 2003-04-07 Martin Baulig <martin@ximian.com>
16209 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
16211 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
16212 location. [FIXME: The location argument which gets passed to this
16213 method is sometimes wrong!]
16215 2003-04-07 Nick Drochak <ndrochak@gol.com>
16217 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
16219 2003-04-07 Miguel de Icaza <miguel@ximian.com>
16221 * expression.cs (Indirection.EmitAssign): We were using the
16222 temporary, but returning immediately instead of continuing the
16225 2003-04-06 Martin Baulig <martin@ximian.com>
16227 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
16228 if it's a nested child, but also deriving from the outer class.
16231 * typemanager.cs (IsNestedChildOf): Make this work if it's a
16232 nested child, but also deriving from the outer class. See
16234 (FilterWithClosure): We may access private members of the outer
16235 class if we're a nested child and deriving from the outer class.
16236 (RealMemberLookup): Only set `closure_private_ok' if the
16237 `original_bf' contained BindingFlags.NonPublic.
16239 2003-04-05 Martin Baulig <martin@ximian.com>
16241 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
16242 probe if its a type parameter, and if so, flag an error.
16244 * decl.cs: Move here the SetParameterInfo code from class.cs.
16245 Handle IsGeneric here.
16247 Handle a variety of errors in the parameter info definition.
16249 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
16250 type parameters here.
16252 * cs-parser.jay (class_declaration): report errors for parameters
16255 2003-01-21 Miguel de Icaza <miguel@ximian.com>
16257 * generic.cs: New file, contains support code for generics.
16259 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
16260 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
16262 Update parser for the above removals.
16264 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
16265 now taken care of in the parser.
16267 2003-04-02 Miguel de Icaza <miguel@ximian.com>
16269 * class.cs (Event.Define): Do not allow abstract events to have
16272 2003-04-01 Miguel de Icaza <miguel@ximian.com>
16274 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
16275 block in event declarations.
16277 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
16278 value type, get its address.
16280 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
16281 leaving a class on the stack instead of a boolean value (int
16282 0/1). Change the code so we compare against null, and then the
16283 result against zero.
16285 * class.cs (TypeContainer.GetClassBases): We were checking for the
16286 parent class being sealed too late.
16288 * expression.cs (Binary.Emit): For <= and >= when dealing with
16289 floating point values, use cgt.un and clt.un instead of cgt and
16292 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
16294 * statement.cs: Apply the same optimization as MS: skip the
16295 GetEnumerator returning an IEnumerator, and use the one returning a
16296 CharEnumerator instead. This allows us to avoid the try-finally block
16299 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
16301 * cs-parser.jay: Attributes cannot be applied to
16302 namespaces. Fixes #40473
16304 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16307 (Add*): check if the name is valid using the full name for constants,
16308 fields, properties and events.
16310 2003-03-28 Miguel de Icaza <miguel@ximian.com>
16312 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
16313 char constants to be part of the enumeration.
16315 * expression.cs (Conditional.DoResolve): Add support for operator
16316 true. Implements the missing functionality from 14.12
16318 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
16319 operator true/false as required by the spec.
16321 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
16322 implicit conversion to boolean.
16324 * statement.cs (Statement.ResolveBoolean): A boolean expression is
16325 also one where the type implements `operator true'.
16327 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
16328 get an expression that will invoke operator true based on an
16331 (GetConversionOperators): Removed the hack that called op_True
16334 (Expression.ResolveBoolean): Move this from Statement.
16336 2003-03-17 Miguel de Icaza <miguel@ximian.com>
16338 * ecore.cs (FieldExpr): do not allow initialization of initonly
16339 fields on derived classes
16341 2003-03-13 Martin Baulig <martin@ximian.com>
16343 * statement.cs (Block.Emit): Call ig.BeginScope() and
16344 ig.EndScope() when compiling with debugging info; call
16345 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
16347 2003-03-08 Miguel de Icaza <miguel@ximian.com>
16349 * expression.cs (Indexers): Do not construct immediately, allow
16350 for new members to be appended as we go. Fixes 38143
16352 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16354 * expression.cs: save/restore context when resolving an unchecked
16357 2003-03-05 Miguel de Icaza <miguel@ximian.com>
16359 * cfold.cs: Catch division by zero in modulus operator during
16362 2003-03-03 Miguel de Icaza <miguel@ximian.com>
16364 * interface.cs (Interface.DefineMembers): Avoid defining members
16367 2003-02-27 Miguel de Icaza <miguel@ximian.com>
16369 * driver.cs: handle the +/- options for -noconfig
16371 * statement.cs (Unckeched.Resolve): Also track the state of
16372 unchecked in the Resolve phase.
16374 2003-02-27 Martin Baulig <martin@ximian.com>
16376 * ecore.cs (Expression.MemberLookup): Don't create a
16377 MethodGroupExpr for something which is not a method. Fixes #38291.
16379 2003-02-25 Miguel de Icaza <miguel@ximian.com>
16381 * class.cs (MemberBase.CheckParameters): Also check that the type
16382 is unmanaged if it is a pointer.
16384 * expression.cs (SizeOf.Resolve): Add location information.
16386 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
16387 a managed type is declared.
16389 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
16390 parameter modifiers as well. Fixes bug 38606
16392 * class.cs: Very sad. Am backing out the speed up changes
16393 introduced by the ArrayList -> Array in the TypeContainer, as they
16394 were not actually that much faster, and introduced a bug (no error
16395 reports on duplicated methods).
16397 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
16398 source first, this will guarantee that we have a valid expression
16399 before calling in lower levels functions that will require a
16400 resolved object. Then use this original_source in the
16401 target.ResolveLValue instead of the original source that was
16404 Another change. Use target.Resolve instead of LValueResolve.
16405 Although we are resolving for LValues, we will let the Assign code
16406 take care of that (it will be called again from Resolve). This
16407 basically allows code like this:
16409 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
16410 class Y { void A (X x) { x [0] += o; }
16412 The problem was that the indexer was trying to resolve for
16413 set_Item (idx, object o) and never finding one. The real set_Item
16414 was set_Item (idx, X). By delaying the process we get the right
16419 2003-02-23 Martin Baulig <martin@ximian.com>
16421 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
16422 while calling DoEmit ().
16424 * codegen.cs (EmitContext.Mark): Don't mark locations in other
16425 source files; if you use the #line directive inside a method, the
16426 compiler stops emitting line numbers for the debugger until it
16427 reaches the end of the method or another #line directive which
16428 restores the original file.
16430 2003-02-23 Martin Baulig <martin@ximian.com>
16432 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
16434 2003-02-23 Martin Baulig <martin@ximian.com>
16436 * statement.cs (Block.AddChildVariableNames): We need to call this
16437 recursively, not just for our immediate children.
16439 2003-02-23 Martin Baulig <martin@ximian.com>
16441 * class.cs (Event.Define): Always make the field private, like csc does.
16443 * typemanager.cs (TypeManager.RealMemberLookup): Make events
16444 actually work, fixes bug #37521.
16446 2003-02-23 Miguel de Icaza <miguel@ximian.com>
16448 * delegate.cs: When creating the various temporary "Parameters"
16449 classes, make sure that we call the ComputeAndDefineParameterTypes
16450 on those new parameters (just like we do with the formal ones), to
16451 allow them to be resolved in the context of the DeclSpace.
16453 This fixes the bug that Dick observed in Bugzilla #38530.
16455 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16457 * expression.cs (ResolveMemberAccess): When resolving a constant,
16458 do not attempt to pull a constant if the value was not able to
16459 generate a valid constant.
16461 * const.cs (LookupConstantValue): Do not report more errors than required.
16463 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16465 * expression.cs: fixes bug #38328.
16467 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16469 * class.cs: Changed all the various members that can be part of a
16470 class from being an ArrayList to be an Array of the right type.
16471 During the DefineType type_list, interface_list, delegate_list and
16472 enum_list are turned into types, interfaces, delegates and enums
16475 And during the member population, indexer_list, event_list,
16476 constant_list, field_list, instance_constructor_list, method_list,
16477 operator_list and property_list are turned into their real arrays.
16479 Although we could probably perform this operation earlier, for
16480 good error reporting we need to keep the lists and remove the
16481 lists for longer than required.
16483 This optimization was triggered by Paolo profiling the compiler
16484 speed on the output of `gen-sample-program.pl' perl script.
16486 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16487 not crash in methods like MemberLookupFailed that use this field.
16489 This problem arises when the compiler fails to resolve a type
16490 during interface type definition for example.
16492 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16494 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16495 inherit from System.Object, so we have to stop at null, not only
16496 when reaching System.Object.
16498 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16500 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16501 DeclaredOnly because the parent indexer might have had a different
16502 name, but did not loop until the top of the hierarchy was reached.
16504 The problem this one fixes is 35492: when a class implemented an
16505 indexer from an interface, we were getting the interface method
16506 (which was abstract) and we were flagging an error (can not invoke
16509 This also keeps bug 33089 functioning, and test-148 functioning.
16511 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16512 out if a method is special is to see if it is declared in a
16513 property or event, or whether it is one of the predefined operator
16514 names. This should fix correctly #36804.
16516 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16518 The goal here is to remove the dependency on EmptyCast.Peel ().
16519 Killing it completely.
16521 The problem is that currently in a number of places where
16522 constants are expected, we have to "probe" for an EmptyCast, and
16523 Peel, which is not the correct thing to do, as this will be
16524 repetitive and will likely lead to errors.
16526 The idea is to remove any EmptyCasts that are used in casts that
16527 can be reduced to constants, so we only have to cope with
16530 This bug hunt was triggered by Bug 37363 and the desire to remove
16531 the duplicate pattern where we were "peeling" emptycasts to check
16532 whether they were constants. Now constants will always be
16535 * ecore.cs: Use an enumconstant here instead of wrapping with
16538 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16539 throwing me off. By handling this we can get rid of a few hacks.
16541 * statement.cs (Switch): Removed Peel() code.
16543 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16545 * class.cs: Location information for error 508
16547 * expression.cs (New.DoResolve): Add a guard against double
16548 resolution of an expression.
16550 The New DoResolve might be called twice when initializing field
16551 expressions (see EmitFieldInitializers, the call to
16552 GetInitializerExpression will perform a resolve on the expression,
16553 and later the assign will trigger another resolution
16555 This leads to bugs (#37014)
16557 * delegate.cs: The signature for EndInvoke should contain any ref
16558 or out parameters as well. We were not doing this in the past.
16560 * class.cs (Field.Define): Do not overwrite the type definition
16561 inside the `volatile' group. Turns out that volatile enumerations
16562 were changing the type here to perform a validity test, which
16565 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16567 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16568 and structs, we do not want to load the instance variable
16570 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16571 enum_type has to be handled like an object reference (implicit
16572 conversions exists from this to object), but the regular IsClass
16573 and IsValueType tests will never return true for this one.
16575 Also we use TypeManager.IsValueType instead of type.IsValueType,
16576 just for consistency with the rest of the code (this is only
16577 needed if we ever use the construct exposed by test-180.cs inside
16578 corlib, which we dont today).
16580 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16582 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16585 2003-02-09 Martin Baulig <martin@ximian.com>
16587 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16588 (Namespace.DefineNamespaces): New static public method; this is
16589 called when we're compiling with debugging to add all namespaces
16590 to the symbol file.
16592 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16593 pass it to the Namespace's .ctor.
16595 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16596 and MethodBase arguments; pass the namespace ID to the symwriter;
16597 pass the MethodBase instead of the token to the symwriter.
16598 (SymbolWriter.DefineNamespace): New method to add a namespace to
16601 2003-02-09 Martin Baulig <martin@ximian.com>
16603 * symbolwriter.cs: New file. This is a wrapper around
16604 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16605 methods here in near future.
16607 2003-02-09 Martin Baulig <martin@ximian.com>
16609 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16610 ILGenerator.MarkSequencePoint() which are actually used by the
16613 2003-02-09 Martin Baulig <martin@ximian.com>
16615 * location.cs (SourceFile): New public sealed class. This
16616 contains the name and an index which is used in the location's token.
16617 (Location): Reserve an appropriate number of bits in the token for
16618 the source file instead of walking over that list, this gives us a
16619 really huge performance improvement when compiling with debugging.
16621 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16622 `SourceFile' argument instead of a string.
16623 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16624 but don't parse/tokenize here, we need to generate the list of all
16625 source files before we do that.
16626 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16629 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16630 instead of a string.
16632 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16635 2003-02-09 Martin Baulig <martin@ximian.com>
16637 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16638 filename on `#line default'.
16640 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16642 * statement.cs: don't clear the pinned var when the fixed statement
16643 returns from the method (fixes bug#37752).
16645 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16647 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16650 2003-02-07 Martin Baulig <martin@ximian.com>
16652 * driver.cs: Removed the `--debug-args' command line argument.
16654 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16655 automatically by the AsssemblyBuilder.
16656 (CodeGen.InitializeSymbolWriter): We don't need to call any
16657 initialization function on the symbol writer anymore. This method
16658 doesn't take any arguments.
16660 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16662 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16663 from referenced assemblies as well.
16665 2003-02-02 Martin Baulig <martin@ximian.com>
16667 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16669 2003-02-02 Martin Baulig <martin@ximian.com>
16671 * class.cs (Constructor.Emit): Open the symbol writer before
16672 emitting the constructor initializer.
16673 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16674 single-stepping through constructor initializers.
16676 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16678 * class.cs: Handle error 549: do not allow virtual methods in
16681 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16683 * decl.cs: Check access levels when resolving types
16685 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16687 * statement.cs: Add parameters and locals set in catch blocks that might
16688 return to set vector
16690 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16692 * class.cs (Operator): Set the SpecialName flags for operators.
16694 * expression.cs (Invocation.DoResolve): Only block calls to
16695 accessors and operators on SpecialName methods.
16697 (Cast.TryReduce): Handle conversions from char constants.
16700 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16702 * statement.cs: small memory and time optimization in FlowBranching.
16704 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16706 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16707 problem that the last fix but in the other sid (Set).
16709 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16710 access when there is no indexer in the hierarchy.
16712 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16714 * class.cs: Combine some if statements.
16716 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16718 * driver.cs: fixed bug #37187.
16720 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16722 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16723 any indexer, it's needed to build a list with all the indexers in the
16724 hierarchy (AllGetters), else we have problems. Fixes #35653.
16726 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16728 * class.cs (MethodData.Define): It is wrong for an interface
16729 implementation to be static in both cases: explicit and implicit.
16730 We were only handling this in one case.
16732 Improve the if situation there to not have negations.
16734 * class.cs (Field.Define): Turns out that we do not need to check
16735 the unsafe bit on field definition, only on usage. Remove the test.
16737 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16739 * driver.cs: use assembly.Location instead of Codebase (the latest
16740 patch made mcs fail when using MS assemblies).
16742 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16744 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16745 get the path to *corlib.dll.
16747 2003-01-21 Nick Drochak <ndrochak@gol.com>
16751 * typemanager.cs: Remove compiler warnings
16753 2003-01-20 Duncan Mak <duncan@ximian.com>
16755 * AssemblyInfo.cs: Bump the version number to 0.19.
16757 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16759 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16761 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16763 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16765 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16767 * cs-parser.jay: Small fix: we were not comparing the constructor
16768 name correctly. Thanks to Zoltan for the initial pointer.
16770 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16772 * cs-tokenizer.cs: Set file name when specified with #line
16774 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16776 * cs-parser.jay: Only perform the constructor checks here if we
16777 are named like the class; This will help provider a better
16778 error. The constructor path is taken when a type definition is
16779 not found, but most likely the user forgot to add the type, so
16780 report that rather than the constructor error.
16782 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16784 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16787 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16789 * cs-parser.jay: Add cleanup call.
16791 2003-01-13 Duncan Mak <duncan@ximian.com>
16793 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16794 consistent with other methods.
16796 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16798 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16800 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16802 * attribute.cs: only set GuidAttr to true when we have a
16805 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16809 * typemanager.cs: fixes to allow mcs compile corlib with the new
16810 Type.IsSubclassOf fix.
16812 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16814 * expression.cs (LocalVariableReference.DoResolve): Classify a
16815 constant as a value, not as a variable. Also, set the type for
16818 * cs-parser.jay (fixed_statement): take a type instead of a
16819 pointer_type, so we can produce a better error message later.
16821 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16824 (For.DoEmit): Make inifinite loops have a
16825 non-conditional branch back.
16827 (Fixed.DoEmit): First populate the pinned variables, then emit the
16828 statement, then clear the variables. Before I was emitting the
16829 code once for each fixed piece.
16832 2003-01-08 Martin Baulig <martin@ximian.com>
16834 * statement.cs (FlowBranching.MergeChild): A break in a
16835 SWITCH_SECTION does not leave a loop. Fixes #36155.
16837 2003-01-08 Martin Baulig <martin@ximian.com>
16839 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16840 lives in the same number space than `param_map'. Fixes #36154.
16842 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16844 * cs-parser.jay (constructor_declaration): Set the
16845 Constructor.ModFlags before probing for it. This makes the
16846 compiler report 514, 515 and 132 (the code was there, but got
16849 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16850 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16851 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16853 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16855 * enum.cs: create the enum static fields using the enum type.
16857 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16859 * class.cs: don't try to create the ParamBuilder for the return
16860 type if it's not needed (and handle it breaking for the ms runtime
16863 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16865 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16867 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16869 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16870 the command. This showed up while compiling the JANET source
16871 code, which used \r as its only newline separator.
16873 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16875 * class.cs (Method.Define): If we are an operator (because it
16876 reuses our code), then set the SpecialName and HideBySig. #36128
16878 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16880 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16881 exception, report error 120 `object reference required'.
16883 * driver.cs: Add --pause option, used during to measure the size
16884 of the process as it goes with --timestamp.
16886 * expression.cs (Invocation.DoResolve): Do not allow methods with
16887 SpecialName to be invoked.
16889 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16891 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16892 number before adding it.
16894 2002-12-21 Ravi Pratap <ravi@ximian.com>
16896 * ecore.cs (StandardImplicitConversion): When in an unsafe
16897 context, we allow conversion between void * to any other pointer
16898 type. This fixes bug #35973.
16900 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16902 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16903 is not thrown when extensionless outputs are used
16905 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16907 * rootcontext.cs: fixed compilation of corlib.
16909 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16911 * attribute.cs (Attributes.Contains): Add new method.
16913 * class.cs (MethodCore.LabelParameters): if the parameter is an
16914 `out' parameter, check that no attribute `[In]' has been passed.
16916 * enum.cs: Handle the `value__' name in an enumeration.
16918 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16920 * decl.cs: Added special case to allow overrides on "protected
16923 2002-12-18 Ravi Pratap <ravi@ximian.com>
16925 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16926 since it makes much more sense.
16928 (Attributes.ctor): Don't require a Location parameter.
16930 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16932 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16933 since we already have that information per attribute.
16935 * everywhere : make appropriate changes.
16937 * class.cs (LabelParameters): Write the code which actually
16938 applies attributes to the return type. We can't do this on the MS
16939 .NET runtime so we flag a warning in the case an exception is
16942 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16944 * const.cs: Handle implicit null conversions here too.
16946 2002-12-17 Ravi Pratap <ravi@ximian.com>
16948 * class.cs (MethodCore.LabelParameters): Remove the extra
16949 Type [] parameter since it is completely unnecessary. Instead
16950 pass in the method's attributes so that we can extract
16951 the "return" attribute.
16953 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16955 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16956 of ignoring it and letting the compile continue.
16958 * typemanager.cs (ChangeType): use an extra argument to return an
16959 error condition instead of throwing an exception.
16961 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16963 * expression.cs (Unary.TryReduce): mimic the code for the regular
16964 code path. Perform an implicit cast in the cases where we can
16965 implicitly convert to one of the integral types, and then reduce
16966 based on that constant. This fixes bug #35483.
16968 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16970 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16972 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16974 * namespace.cs: fixed bug #35489.
16976 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16978 * class.cs: Remove some dead code.
16980 * cs-parser.jay: Estimate the number of methods needed
16981 (RootContext.MethodCount);
16983 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16984 numbers instead of StringBuilders.
16986 * support.cs (PtrHashtable): Add constructor with initial size;
16987 We can now reduce reallocations of the method table.
16989 2002-12-10 Ravi Pratap <ravi@ximian.com>
16991 * attribute.cs (ApplyAttributes): Keep track of the emitted
16992 attributes on a per-target basis. This fixes bug #35413.
16994 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16996 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16997 default to the Windows 1252 encoding.
16999 (UnixParseOption): Support version, thanks to Alp for the missing
17002 * AssemblyInfo.cs: Add nice assembly information.
17004 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
17007 * cs-parser.jay: Allow a trailing comma before the close bracked
17008 in the attribute_section production.
17010 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
17011 address of the instance was being taken, I will take this out,
17012 because we take the address of the object immediately here.
17014 2002-12-09 Ravi Pratap <ravi@ximian.com>
17016 * typemanager.cs (AreMultipleAllowed): Take care of the most
17017 obvious case where attribute type is not in the current assembly -
17020 2002-12-08 Miguel de Icaza <miguel@ximian.com>
17022 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
17023 definitions, instead of doing that afterwards.
17025 Also we use a nice little hack, depending on the constructor, we
17026 know if we are a "composed" name or a simple name. Hence, we
17027 avoid the IndexOf test, and we avoid
17029 * codegen.cs: Add code to assist in a bug reporter to track down
17030 the source of a compiler crash.
17032 2002-12-07 Ravi Pratap <ravi@ximian.com>
17034 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
17035 types have been emitted for a given element and flag an error
17036 if something which does not have AllowMultiple set is used more
17039 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
17040 attribute types and their corresponding AllowMultiple properties
17042 (AreMultipleAllowed): Check the property for a given type.
17044 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
17045 property in the case we have a TypeContainer.
17047 (Attributes.AddAttribute): Detect duplicates and just skip on
17048 adding them. This trivial fix catches a pretty gross error in our
17049 attribute emission - global attributes were being emitted twice!
17051 Bugzilla bug #33187 is now fixed.
17053 2002-12-06 Miguel de Icaza <miguel@ximian.com>
17055 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
17056 instead of pp_and).
17058 * expression.cs (Binary.ResolveOperator): I can only use the
17059 Concat (string, string, string) and Concat (string, string,
17060 string, string) if the child is actually a concatenation of
17063 2002-12-04 Miguel de Icaza <miguel@ximian.com>
17065 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
17066 context where we need a 2-character lookahead.
17068 * pending.cs (PendingImplementation): Rework so we can keep track
17069 of interface types all the time, and flag those which were
17070 implemented by parents as optional.
17072 2002-12-03 Miguel de Icaza <miguel@ximian.com>
17074 * expression.cs (Binary.ResolveOperator): Use
17075 String.Concat(string,string,string) or
17076 String.Concat(string,string,string,string) when possible.
17078 * typemanager: More helper methods.
17081 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
17083 * pending.cs: remove the bogus return from GetMissingInterfaces()
17084 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
17086 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17088 * namespace.cs: avoid duplicated 'using xxx' being added to
17089 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
17090 when we get more than one 'using' statement for the same namespace.
17091 Report a CS0105 warning for it.
17093 2002-11-30 Miguel de Icaza <miguel@ximian.com>
17095 * cs-tokenizer.cs (consume_identifier): use read directly, instead
17096 of calling getChar/putback, uses internal knowledge of it.
17098 (xtoken): Reorder tokenizer so most common patterns are checked
17099 first. This reduces the compilation time in another 5% (from 8.11s
17100 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
17102 The parsing time is 22% of the compilation in mcs, and from that
17103 64% is spent on the tokenization process.
17105 I tried using a binary search for keywords, but this is slower
17106 than the hashtable. Another option would be to do a couple of
17109 * Not use a StringBuilder, instead use an array of chars,
17110 with a set value. Notice that this way we could catch
17111 the 645 error without having to do it *afterwards*.
17113 * We could write a hand-parser to avoid the hashtable
17114 compares altogether.
17116 The identifier consumption process takes 37% of the tokenization
17117 time. Another 15% is spent on is_number. 56% of the time spent
17118 on is_number is spent on Int64.Parse:
17120 * We could probably choose based on the string length to
17121 use Int32.Parse or Int64.Parse and avoid all the 64-bit
17124 Another 3% is spend on wrapping `xtoken' in the `token' function.
17126 Handle 0xa0 as whitespace (#34752)
17128 2002-11-26 Miguel de Icaza <miguel@ximian.com>
17130 * typemanager.cs (IsCLRType): New routine to tell whether a type
17131 is one of the builtin types.
17133 Maybe it needs to use TypeCodes to be faster. Maybe we could use
17134 typecode in more places instead of doing pointer comparissions.
17135 We could leverage some knowledge about the way the typecodes are
17138 New code to cache namespaces in assemblies, it is currently not
17139 invoked, to be used soon.
17141 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
17143 * expression.cs (Binary.ResolveOperator): specially handle
17144 strings, and do not perform user-defined operator overloading for
17147 2002-11-24 Miguel de Icaza <miguel@ximian.com>
17149 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
17150 internalcall as it is a pretty simple operation; Avoid whenever
17151 possible to call Char.IsLetter.
17153 (consume_identifier): Cut by half the number of
17154 hashtable calls by merging the is_keyword and GetKeyword behavior.
17156 Do not short-circuit, because if we do, we
17157 report errors (ie, #if false && true would produce an invalid
17161 2002-11-24 Martin Baulig <martin@ximian.com>
17163 * expression.cs (Cast.TryReduce): If we're in checked syntax,
17164 check constant ranges and report a CS0221. Fixes #33186.
17166 2002-11-24 Martin Baulig <martin@ximian.com>
17168 * cs-parser.jay: Make this work for uninitialized variable
17169 declarations in the `for' initializer. Fixes #32416.
17171 2002-11-24 Martin Baulig <martin@ximian.com>
17173 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
17174 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
17176 2002-11-24 Martin Baulig <martin@ximian.com>
17178 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
17179 argument; if true, we also check for user-defined conversions.
17180 This is only needed if both arguments are of a user-defined type.
17181 Fixes #30443, added test-175.cs.
17182 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
17184 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
17186 2002-11-24 Martin Baulig <martin@ximian.com>
17188 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
17189 function to get the store opcode.
17190 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
17191 only emit the Ldelema if the store opcode is Stobj. You must run
17192 both test-34 and test-167 to test this. Fixes #34529.
17194 2002-11-23 Martin Baulig <martin@ximian.com>
17196 * ecore.cs (Expression.MemberLookup): Added additional
17197 `qualifier_type' argument which is used when we're being called
17198 from MemberAccess.DoResolve() and null if we're called from a
17200 (Expression.MemberLookupFailed): New method to report errors; this
17201 does the CS1540 check and reports the correct error message.
17203 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
17204 argument for the CS1540 check and redone the way how we're dealing
17205 with private members. See the comment in the source code for details.
17206 (FilterWithClosure): Reverted this back to revision 1.197; renamed
17207 `closure_start_type' to `closure_qualifier_type' and check whether
17208 it's not null. It was not this filter being broken, it was just
17209 being called with the wrong arguments.
17211 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
17212 and pass it the correct `qualifier_type'; this also does the error
17215 2002-11-22 Miguel de Icaza <miguel@ximian.com>
17217 * expression.cs (Invocation.EmitParams): If the we are dealing
17218 with a non-built-in value type, load its address as well.
17220 (ArrayCreation): Use a a pretty constant instead
17221 of the hardcoded value 2. Use 6 instead of 2 for the number of
17222 static initializers.
17224 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
17225 because they are not really value types, just glorified integers.
17227 * driver.cs: Do not append .exe, the CSC compiler does not do it.
17229 * ecore.cs: Remove redundant code for enumerations, make them use
17230 the same code path as everything else, fixes the casting issue
17231 with enumerations in Windows.Forms.
17233 * attribute.cs: Do only cast to string if it is a string, the
17234 validation happens later.
17236 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
17237 people upgrade their corlibs.
17239 * ecore.cs: Oops, enumerations were not following the entire code path
17241 2002-11-21 Miguel de Icaza <miguel@ximian.com>
17243 * typemanager.cs (FilterWithClosure): Commented out the test for
17244 1540 in typemanager.cs, as it has problems when accessing
17245 protected methods from a parent class (see test-174.cs).
17247 * attribute.cs (Attribute.ValidateGuid): new method.
17248 (Attribute.Resolve): Use above.
17250 2002-11-19 Miguel de Icaza <miguel@ximian.com>
17252 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
17254 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
17255 handling for enumerations, as we only needed the TypeContainer
17256 functionality to begin with (this is required for the fix below to
17257 work for enums that reference constants in a container class for
17260 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
17262 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
17263 a valid TypeBuilder to perform lookups on.o
17265 * class.cs (InheritableMemberSignatureCompare): Use true in the
17266 call to GetGetMethod and GetSetMethod, because we are comparing
17267 the signature, and we need to get the methods *even* if they are
17270 (PropertyBase.CheckBase): ditto.
17272 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
17273 GotoCase.Resolve): Use Peel on EmpytCasts.
17275 * ecore.cs (EmptyCast): drop child, add Peel method.
17277 2002-11-17 Martin Baulig <martin@ximian.com>
17279 * ecore.cs (EmptyCast.Child): New public property.
17281 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
17282 label resolved to an EmptyCast. Fixes #34162.
17283 (GotoCase.Resolve): Likewise.
17284 (Block.EmitMeta): Likewise.
17286 2002-11-17 Martin Baulig <martin@ximian.com>
17288 * expression.cs (Invocation.BetterConversion): Prefer int over
17289 uint; short over ushort; long over ulong for integer literals.
17290 Use ImplicitConversionExists instead of StandardConversionExists
17291 since we also need to check for user-defined implicit conversions.
17292 Fixes #34165. Added test-173.cs.
17294 2002-11-16 Martin Baulig <martin@ximian.com>
17296 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
17297 with the `true' and `false' literals. Fixes #33151.
17299 2002-11-16 Martin Baulig <martin@ximian.com>
17301 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
17302 October 22nd; don't do the cs1540 check for static members.
17304 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
17305 now using our own filter here and doing the cs1540 check again.
17307 2002-11-16 Martin Baulig <martin@ximian.com>
17309 * support.cs (InternalParameters): Don't crash if we don't have
17310 any fixed parameters. Fixes #33532.
17312 2002-11-16 Martin Baulig <martin@ximian.com>
17314 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
17315 when looking up static methods to make this work on Windows.
17318 2002-11-16 Martin Baulig <martin@ximian.com>
17320 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
17321 a setter rather than using PropertyInfo.CanWrite.
17323 2002-11-15 Nick Drochak <ndrochak@gol.com>
17325 * class.cs: Allow acces to block member by subclasses. Fixes build
17328 2002-11-14 Martin Baulig <martin@ximian.com>
17330 * class.cs (Constructor.Emit): Added the extern/block check.
17333 2002-11-14 Martin Baulig <martin@ximian.com>
17335 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
17336 iteration while looking for indexers, this is needed because the
17337 indexer may have a different name in our base classes. Fixed the
17338 error reporting (no indexers at all, not get accessor, no
17339 overloaded match). Fixes bug #33089.
17340 (IndexerAccess.DoResolveLValue): Likewise.
17342 2002-11-14 Martin Baulig <martin@ximian.com>
17344 * class.cs (PropertyBase.CheckBase): Make this work for multiple
17345 indexers. Fixes the first part of bug #33089.
17346 (MethodSignature.InheritableMemberSignatureCompare): Added support
17349 2002-11-13 Ravi Pratap <ravi@ximian.com>
17351 * attribute.cs (Attribute.Resolve): Catch the
17352 NullReferenceException and report it since it isn't supposed to
17355 2002-11-12 Miguel de Icaza <miguel@ximian.com>
17357 * expression.cs (Binary.EmitBranchable): Also handle the cases for
17358 LogicalOr and LogicalAnd that can benefit from recursively
17359 handling EmitBranchable. The code now should be nice for Paolo.
17361 2002-11-08 Miguel de Icaza <miguel@ximian.com>
17363 * typemanager.cs (LookupType): Added a negative-hit hashtable for
17364 the Type lookups, as we perform quite a number of lookups on
17365 non-Types. This can be removed once we can deterministically tell
17366 whether we have a type or a namespace in advance.
17368 But this might require special hacks from our corlib.
17372 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
17373 and double which avoids a conversion from an integer to a double.
17375 * expression.cs: tiny optimization, avoid calling IsConstant,
17376 because it effectively performs the lookup twice.
17378 2002-11-06 Miguel de Icaza <miguel@ximian.com>
17380 But a bogus return here to keep the semantics of the old code
17381 until the Mono runtime is fixed.
17383 * pending.cs (GetMissingInterfaces): New method used to remove all
17384 the interfaces that are already implemented by our parent
17385 classes from the list of pending methods.
17387 * interface.cs: Add checks for calls after ResolveTypeExpr.
17389 2002-11-05 Miguel de Icaza <miguel@ximian.com>
17391 * class.cs (Class.Emit): Report warning 67: event not used if the
17392 warning level is beyond 3.
17394 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
17395 being a NullLiteral.
17397 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
17400 * class.cs (TypeContainer.GetClassBases): Cover a missing code
17401 path that might fail if a type can not be resolved.
17403 * expression.cs (Binary.Emit): Emit unsigned versions of the
17406 * driver.cs: use error 5.
17408 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
17410 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
17412 2002-11-01 Miguel de Icaza <miguel@ximian.com>
17414 * cs-parser.jay (switch_section): A beautiful patch from Martin
17415 Baulig that fixed 33094.
17417 2002-10-31 Miguel de Icaza <miguel@ximian.com>
17419 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
17420 Check whether the base is abstract and report an error if so.
17422 * expression.cs (IndexerAccess.DoResolveLValue,
17423 IndexerAccess.DoResolve): ditto.
17425 (Invocation.DoResolve): ditto.
17427 (Invocation.FullMethodDesc): Improve the report string.
17429 * statement.cs (Block): Eliminate IsVariableDefined as it is
17430 basically just a wrapper for GetVariableInfo.
17432 * ecore.cs (SimpleName): Use new
17434 * support.cs (ReflectionParamter.ParameterType): We unwrap the
17435 type, as we return the actual parameter ref/unref state on a
17438 2002-10-30 Miguel de Icaza <miguel@ximian.com>
17440 * support.cs: Return proper flags REF/OUT fixing the previous
17443 * expression.cs: Reverted last patch, that was wrong. Is_ref is
17444 not used to mean `ref' but `ref or out' in ParameterReference
17446 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
17447 full type signature instead of calling TypeManger.CSharpName
17450 * support.cs (InternalParameters.ParameterDesc): Do not compare
17451 directly to the modflags, because REF/OUT will actually be bitsets
17454 * delegate.cs (VerifyMethod): Check also the modifiers.
17456 * cs-tokenizer.cs: Fix bug where floating point values with an
17457 exponent where a sign was missing was ignored.
17459 * driver.cs: Allow multiple assemblies to be specified in a single
17462 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17464 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17465 because identifiers after a parenthesis would end up in this kind
17466 of production, and we needed to desamiguate it for having casts
17469 (UserDefinedType *) xxx
17471 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17473 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17474 we should set on the Bindingflags.NonPublic, but not turn on
17475 private_ok. private_ok controls whether a Private member is
17476 returned (this is chekced on the filter routine), while the
17477 BindingFlags.NonPublic just controls whether private/protected
17478 will be allowed. This fixes the problem part of the problem of
17479 private properties being allowed to be used in derived classes.
17481 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17482 so we can call the children DoResolveLValue method (this will
17483 properly signal errors on lvalue assignments to base properties)
17485 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17486 getter are null, and we have a property info, we know that this
17487 happened because the lookup failed, so we report an error 122 for
17488 protection level violation.
17490 We also silently return if setter and getter are null in the
17491 resolve functions, this condition only happens if we have flagged
17492 the error before. This is the other half of the problem.
17494 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17495 not have accessibility information, that is why we were returning
17496 true in the filter function in typemanager.cs.
17498 To properly report 122 (property is inaccessible because of its
17499 protection level) correctly, we report this error in ResolveAccess
17500 by failing if both the setter and the getter are lacking (ie, the
17503 DoResolve and DoLResolve have been modified to check for both
17504 setter/getter being null and returning silently, the reason being
17505 that I did not want to put the knowledge about this error in upper
17508 int old = Report.Errors;
17509 x = new PropertyExpr (...);
17510 if (old != Report.Errors)
17515 So the property expr is returned, but it is invalid, so the error
17516 will be flagged during the resolve process.
17518 * class.cs: Remove InheritablePropertySignatureCompare from the
17519 class, as we no longer depend on the property signature to compute
17520 whether it is possible to implement a method or not.
17522 The reason is that calling PropertyInfo.GetGetMethod will return
17523 null (in .NET, in Mono it works, and we should change this), in
17524 cases where the Get Method does not exist in that particular
17529 class X { public virtual int A { get { return 1; } } }
17531 class Z : Y { public override int A { get { return 2; } } }
17533 Would fail in Z because the parent (Y) would not have the property
17534 defined. So we avoid this completely now (because the alternative
17535 fix was ugly and slow), and we now depend exclusively on the
17538 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17539 reference method, instead of using the property.
17541 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17542 routines are gone now.
17544 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17545 names, they were incorrectly named.
17547 * cs-tokenizer.cs: Return are more gentle token on failure.
17549 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17550 had an out-of-sync index variable, which caused it to remove from
17551 the list of pending methods the wrong method sometimes.
17553 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17555 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17556 CanWrite, because those refer to this particular instance of the
17557 property, and do not take into account the fact that we can
17558 override single members of a property.
17560 Constructor requires an EmitContext. The resolution process does
17561 not happen here, but we need to compute the accessors before,
17562 because the resolution does not always happen for properties.
17564 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17565 subclass, before we did not update this flag, but we did update
17568 (GetAccessors): Drop this routine, as it did not work in the
17569 presence of partially overwritten set/get methods.
17571 Notice that this broke the cs1540 detection, but that will require
17574 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17578 * driver.cs: issue a warning instead of an error if we don't support
17579 debugging for the platform. Also ignore a couple of errors that may
17580 arise when trying to write the symbols. Undo my previous patch.
17582 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17584 * driver.cs: ignore /debug switch except for Unix platforms.
17586 2002-10-23 Nick Drochak <ndrochak@gol.com>
17588 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17590 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17592 * driver.cs: Do not make mcs-debug conditional, so we do not break
17593 builds that use it.
17595 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17596 review this patch. But basically after all the children variables
17597 have been merged, the value of "Breaks" was not being set to
17598 new_breaks for Switch blocks. I think that it should be set after
17599 it has executed. Currently I set this to the value of new_breaks,
17600 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17601 conservative, but I do not understand this code very well.
17603 I did not break anything in the build, so that is good ;-)
17605 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17607 2002-10-20 Mark Crichton <crichton@gimp.org>
17609 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17611 2002-10-20 Nick Drochak <ndrochak@gol.com>
17613 * cfold.cs: Fixed compile blocker.
17615 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17617 * driver.cs: I was chekcing the key, not the file.
17619 2002-10-19 Ravi Pratap <ravi@ximian.com>
17621 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17622 message that we were generating - we just need to silently return
17625 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17627 * class.cs (Event.Define): Change my previous commit, as this
17628 breaks the debugger. This is a temporary hack, as it seems like
17629 the compiler is generating events incorrectly to begin with.
17631 * expression.cs (Binary.ResolveOperator): Added support for
17632 "U operator - (E x, E y)"
17634 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17637 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17638 init-only variables, but this path did not take into account that
17639 there might be also instance readonly variables. Correct this
17642 This fixes bug 32253
17644 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17647 * driver.cs: Change the extension for modules to `netmodule'
17649 * cs-parser.jay: Improved slightly the location tracking for
17650 the debugger symbols.
17652 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17653 modifiers that were specified instead of the hardcoded value
17654 (FamAndAssem). This was basically ignoring the static modifier,
17655 and others. Fixes 32429.
17657 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17658 fixed a bug in the process (32476)
17660 * expression.cs (ArrayAccess.EmitAssign): Patch from
17661 hwang_rob@yahoo.ca that fixes bug 31834.3
17663 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17665 * driver.cs: Make the module extension .netmodule.
17667 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17669 * driver.cs: Report an error if the resource file is not found
17670 instead of crashing.
17672 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17673 false, like Emit does.
17675 2002-10-16 Nick Drochak <ndrochak@gol.com>
17677 * typemanager.cs: Remove unused private member. Also reported mcs
17678 bug to report this as a warning like csc.
17680 2002-10-15 Martin Baulig <martin@gnome.org>
17682 * statement.cs (Statement.Emit): Made this a virtual method; emits
17683 the line number info and calls DoEmit().
17684 (Statement.DoEmit): New protected abstract method, formerly knows
17685 as Statement.Emit().
17687 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17689 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17691 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17692 have fixed a remaining problem: not every AddXXXX was adding a
17693 fully qualified name.
17695 Now everyone registers a fully qualified name in the DeclSpace as
17696 being defined instead of the partial name.
17698 Downsides: we are slower than we need to be due to the excess
17699 copies and the names being registered this way.
17701 The reason for this is that we currently depend (on the corlib
17702 bootstrap for instance) that types are fully qualified, because
17703 we dump all the types in the namespace, and we should really have
17704 types inserted into the proper namespace, so we can only store the
17705 basenames in the defined_names array.
17707 2002-10-10 Martin Baulig <martin@gnome.org>
17709 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17710 from bug #31834, see the bug report for a testcase which is
17713 2002-10-10 Martin Baulig <martin@gnome.org>
17715 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17716 flow analysis code for this.
17718 * statement.cs (Do, While, For): Tell the flow analysis code about
17720 (FlowBranching.UsageVector): Added support for infinite loops.
17721 (Block.Resolve): Moved the dead code elimination here and use flow
17724 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17726 * class.cs (Field.Define): Catch cycles on struct type
17729 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17730 fields if the fields are static. We only need to check instance
17733 * expression.cs (As.DoResolve): Test for reference type.
17735 * statement.cs (Using.ResolveExpression): Use
17736 ConvertImplicitRequired, not ConvertImplicit which reports an
17738 (Using.ResolveLocalVariableDecls): ditto.
17740 * expression.cs (Binary.ResolveOperator): Report errors in a few
17741 places where we had to.
17743 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17745 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17747 * expression.cs: Use StoreFromPtr instead of extracting the type
17748 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17750 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17751 an enumeration value to a System.Enum, but System.Enum is not a
17752 value type, but an class type, so we need to box.
17754 (Expression.ConvertExplicit): One codepath could return
17755 errors but not flag them. Fix this. Fixes #31853
17757 * parameter.cs (Resolve): Do not allow void as a parameter type.
17759 2002-10-06 Martin Baulig <martin@gnome.org>
17761 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17762 if it's a class type and not a struct. Fixes #31815.
17764 2002-10-06 Martin Baulig <martin@gnome.org>
17766 * statement.cs: Reworked the flow analysis code a bit to make it
17767 usable for dead code elimination.
17769 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17771 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17773 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17775 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17776 to fix the test 165, will investigate deeper.
17778 2002-10-04 Martin Baulig <martin@gnome.org>
17780 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17781 finally blocks actually work.
17782 (Try.Resolve): We don't need to create a sibling for `finally' if
17783 there is no finally block.
17785 2002-10-04 Martin Baulig <martin@gnome.org>
17787 * class.cs (Constructor.Define): The default accessibility for a
17788 non-default constructor is private, not public.
17790 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17792 * class.cs (Constructor): Make AllowedModifiers public, add
17795 * cs-parser.jay: Perform the modifiers test here, as the
17796 constructor for the Constructor class usually receives a zero
17797 because of the way we create it (first we create, later we
17798 customize, and we were never checking the modifiers).
17800 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17801 is a version of LookupTypeReflection that includes the type-name
17802 cache. This can be used as a fast path for functions that know
17803 the fully qualified name and are only calling into *.GetType() to
17804 obtain a composed type.
17806 This is also used by TypeManager.LookupType during its type
17809 (LookupType): We now also track the real type name, as sometimes
17810 we can get a quey for the real type name from things like
17811 ComposedCast. This fixes bug 31422.
17813 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17814 complete type fullname, it does not have to go through the type
17815 resolution system to obtain the composed version of the type (for
17816 obtaining arrays or pointers).
17818 (Conditional.Emit): Use the EmitBoolExpression to
17819 generate nicer code, as requested by Paolo.
17821 (ArrayCreation.CheckIndices): Use the patch from
17822 hwang_rob@yahoo.ca to validate the array initializers.
17824 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17826 * class.cs (ConstructorInitializer.Emit): simplify code by using
17827 Invocation.EmitCall, and at the same time, fix the bugs in calling
17828 parent constructors that took variable arguments.
17830 * ecore.cs (Expression.ConvertNumericExplicit,
17831 Expression.ImplicitNumericConversion): Remove the code that
17832 manually wrapped decimal (InternalTypeConstructor call is now gone
17835 * expression.cs (Cast.TryReduce): Also handle decimal types when
17836 trying to perform a constant fold on the type.
17838 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17840 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17841 that only turned off an error report, and did nothing else.
17843 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17845 * driver.cs: Handle and ignore /fullpaths
17847 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17849 * expression.cs (Binary.ResolveOperator): Catch the case where
17850 DoNumericPromotions returns true,
17852 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17854 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17856 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17859 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17861 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17862 conversion exists, but it is also required that the conversion be
17863 performed. This manifested in "(Type64Enum) 2".
17865 * class.cs (TypeManager.AddMethod): The fix is not to change
17866 AddEnum, because that one was using a fully qualified name (every
17867 DeclSpace derivative does), but to change the AddMethod routine
17868 that was using an un-namespaced name. This now correctly reports
17869 the duplicated name.
17871 Revert patch until I can properly fix it. The issue
17872 is that we have a shared Type space across all namespaces
17873 currently, which is wrong.
17875 Options include making the Namespace a DeclSpace, and merge
17876 current_namespace/current_container in the parser.
17878 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17880 * cs-parser.jay: Improve error reporting when we get a different
17881 kind of expression in local_variable_type and
17882 local_variable_pointer_type.
17884 Propagate this to avoid missleading errors being reported.
17886 * ecore.cs (ImplicitReferenceConversion): treat
17887 TypeManager.value_type as a target just like object_type. As
17892 Is valid, and needs to result in the int 1 being boxed before it
17893 is assigned to the value type v.
17895 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17896 to validate the enumeration name.
17898 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17899 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17900 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17902 * ecore.cs (TryImplicitIntConversion): When doing an
17903 implicit-enumeration-conversion, check if the type is 64-bits and
17904 perform a conversion before passing to EnumConstant.
17906 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17908 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17909 report ambiguous type references. Unlike the MS version, we
17910 report what the ambiguity is. Innovation at work ;-)
17912 (DeclSpace.FindType): Require a location argument to
17913 display when we display an ambiguous error.
17915 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17917 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17919 * expression.cs (EmitDynamicInitializers): Apply patch from
17920 hwang_rob@yahoo.ca that fixes the order in which we emit our
17923 2002-09-21 Martin Baulig <martin@gnome.org>
17925 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17926 delegate takes no arguments.
17928 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17930 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17933 * expression.cs: Extract the underlying type.
17935 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17937 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17939 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17941 * class.cs (TypeContainer.DefineType): We can not use the nice
17942 PackingSize with the size set to 1 DefineType method, because it
17943 will not allow us to define the interfaces that the struct
17946 This completes the fixing of bug 27287
17948 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17949 means also structs. This fixes part of the problem.
17950 (Expresion.ImplicitReferenceConversionExists): ditto.
17952 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17953 error if there were no errors reported during the type lookup
17954 process, to avoid duplicates or redundant errors. Without this
17955 you would get an ambiguous errors plus a type not found. We have
17956 beaten the user enough with the first error.
17958 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17961 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17962 during the resolution process, stop the lookup, this avoids
17963 repeated error reports (same error twice).
17965 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17967 * typemanager.cs (LookupType): Redo the type lookup code to match
17968 the needs of System.Reflection.
17970 The issue is that System.Reflection requires references to nested
17971 types to begin with a "+" sign instead of a dot. So toplevel
17972 types look like: "NameSpace.TopLevelClass", and nested ones look
17973 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17976 2002-09-19 Martin Baulig <martin@gnome.org>
17978 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17979 says that a method always returns or always throws an exception,
17980 don't report the CS0161.
17982 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17983 set `Returns = new_returns'.
17985 2002-09-19 Martin Baulig <martin@gnome.org>
17987 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17988 to an enum constant, check for a CS0176.
17990 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17992 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17993 for operators that must be in pairs and report errors.
17995 * ecore.cs (SimpleName.DoResolveType): During the initial type
17996 resolution process, when we define types recursively, we must
17997 check first for types in our current scope before we perform
17998 lookups in the enclosing scopes.
18000 * expression.cs (MakeByteBlob): Handle Decimal blobs.
18002 (Invocation.VerifyArgumentsCompat): Call
18003 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
18004 I thought we were supposed to always call this, but there are a
18005 few places in the code where we dont do it.
18007 2002-09-17 Miguel de Icaza <miguel@ximian.com>
18009 * driver.cs: Add support in -linkres and -resource to specify the
18010 name of the identifier.
18012 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18014 * ecore.cs (StandardConversionExists): Sync with the conversion
18015 code: allow anything-* to void* conversions.
18017 (FindMostSpecificSource): Use an Expression argument
18018 instead of a Type, because we might be handed over a Literal which
18019 gets a few more implicit conversions that plain types do not. So
18020 this information was being lost.
18022 Also, we drop the temporary type-holder expression when not
18025 2002-09-17 Martin Baulig <martin@gnome.org>
18027 * class.cs (PropertyBase.CheckBase): Don't check the base class if
18028 this is an explicit interface implementation.
18030 2002-09-17 Martin Baulig <martin@gnome.org>
18032 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
18033 different `IndexerName' attributes.
18035 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
18036 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
18037 virtual CommonResolve().
18039 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18041 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
18042 and convert that to the UnderlyingType.
18044 * statement.cs (Foreach.Resolve): Indexers are just like variables
18045 or PropertyAccesses.
18047 * cs-tokenizer.cs (consume_string): Track line numbers and columns
18048 inside quoted strings, we were not doing this before.
18050 2002-09-16 Martin Baulig <martin@gnome.org>
18052 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
18053 resolve it. This is needed for the definite assignment check of the
18054 instance expression, fixes bug #29846.
18055 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
18057 2002-09-16 Nick Drochak <ndrochak@gol.com>
18059 * parameter.cs: Fix compile error. Cannot reference static member
18060 from an instance object. Is this an mcs bug?
18062 2002-09-14 Martin Baulig <martin@gnome.org>
18064 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
18065 multiple times. Fixes bug #30295, added test-166.cs.
18067 2002-09-14 Martin Baulig <martin@gnome.org>
18069 * statement.cs (Block.Emit): Don't emit unreachable code.
18070 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
18071 `break' statements.
18072 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
18074 2002-09-14 Martin Baulig <martin@gnome.org>
18076 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
18079 2002-09-14 Martin Baulig <martin@gnome.org>
18081 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
18082 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
18083 be false on the ms runtime.
18085 2002-09-13 Martin Baulig <martin@gnome.org>
18087 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
18088 the CS0038 error message.
18090 2002-09-12 Miguel de Icaza <miguel@ximian.com>
18092 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
18093 constant inside, return it.
18095 2002-09-12 Martin Baulig <martin@gnome.org>
18097 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
18098 implicit conversion can be done between enum types.
18100 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
18101 check whether an implicit conversion to the current enum's UnderlyingType
18102 exists and report an error if not.
18104 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
18105 without debugging support.
18107 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
18108 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
18110 2002-09-12 Martin Baulig <martin@gnome.org>
18112 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
18114 * ecore.cs (IMemberExpr.DeclaringType): New property.
18115 (SimpleName.SimpleNameResolve): Check whether we're accessing a
18116 nonstatic member of an outer type (CS0038).
18118 2002-09-11 Miguel de Icaza <miguel@ximian.com>
18120 * driver.cs: Activate the using-error detector at warning level
18121 4 (at least for MS-compatible APIs).
18123 * namespace.cs (VerifyUsing): Small buglett fix.
18125 * pending.cs (PendingImplementation): pass the container pointer.
18127 * interface.cs (GetMethods): Allow for recursive definition. Long
18128 term, I would like to move every type to support recursive
18129 definitions, not the current ordering mechanism that we have right
18132 The situation is this: Attributes are handled before interfaces,
18133 so we can apply attributes to interfaces. But some attributes
18134 implement interfaces, we will now handle the simple cases
18135 (recursive definitions will just get an error).
18137 * parameter.cs: Only invalidate types at the end if we fail to
18140 2002-09-09 Martin Baulig <martin@gnome.org>
18142 * ecore.cs (PropertyExpr.Emit): Also check for
18143 TypeManager.system_int_array_get_length so this'll also work when
18144 compiling corlib. Fixes #30003.
18146 2002-09-09 Martin Baulig <martin@gnome.org>
18148 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
18149 and throw an exception if we can't get the type's size. Fixed #30040,
18152 2002-09-09 Martin Baulig <martin@gnome.org>
18154 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
18156 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
18157 context. Fixes bug #30027.
18159 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
18160 virtual functions. Fixes bug #30043, added test-164.cs.
18162 2002-09-08 Ravi Pratap <ravi@ximian.com>
18164 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
18166 2002-09-08 Nick Drochak <ndrochak@gol.com>
18168 * driver.cs: Use an object to get the windows codepage since it's not a
18171 2002-09-08 Miguel de Icaza <miguel@ximian.com>
18173 * statement.cs (For.Emit): for infinite loops (test == null)
18174 return whether there is a break inside, not always "true".
18176 * namespace.cs (UsingEntry): New struct to hold the name of the
18177 using definition, the location where it is defined, and whether it
18178 has been used in a successful type lookup.
18180 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
18185 2002-09-06 Ravi Pratap <ravi@ximian.com>
18187 * attribute.cs : Fix incorrect code which relied on catching
18188 a NullReferenceException to detect a null being passed in
18189 where an object was expected.
18191 2002-09-06 Miguel de Icaza <miguel@ximian.com>
18193 * statement.cs (Try): flag the catch variable as assigned
18195 * expression.cs (Cast): Simplified by using ResolveType instead of
18196 manually resolving.
18198 * statement.cs (Catch): Fix bug by using ResolveType.
18200 2002-09-06 Ravi Pratap <ravi@ximian.com>
18202 * expression.cs (BetterConversion): Special case for when we have
18203 a NullLiteral as the argument and we have to choose between string
18204 and object types - we choose string the way csc does.
18206 * attribute.cs (Attribute.Resolve): Catch the
18207 NullReferenceException and report error #182 since the Mono
18208 runtime no more has the bug and having this exception raised means
18209 we tried to select a constructor which takes an object and is
18212 2002-09-05 Ravi Pratap <ravi@ximian.com>
18214 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
18215 message (1502, 1503) when we can't locate a method after overload
18216 resolution. This is much more informative and closes the bug
18219 * interface.cs (PopulateMethod): Return if there are no argument
18220 types. Fixes a NullReferenceException bug.
18222 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
18223 expressions too. Previously we were checking only in one place for
18224 positional arguments leaving out named arguments.
18226 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
18227 type to the enum type is not allowed. Remove code corresponding to
18230 (ConvertNumericExplicit): Allow explicit conversions from
18231 the underlying type to enum type. This precisely follows the spec
18232 and closes a bug filed by Gonzalo.
18234 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18237 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
18239 2002-09-03 Miguel de Icaza <miguel@ximian.com>
18241 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
18242 it was important that we stored the right value after the
18243 reduction in `converted'.
18245 2002-09-04 Martin Baulig <martin@gnome.org>
18247 * location.cs (Location.SymbolDocument): Use full pathnames for the
18250 2002-08-30 Miguel de Icaza <miguel@ximian.com>
18252 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
18253 of the expression resolve mechanism, because that will catch the
18254 SimpleName error failures.
18256 (Conditional): If we can not resolve the
18257 expression, return, do not crash.
18259 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18262 (location): display token name instead of its number.
18264 2002-08-28 Martin Baulig <martin@gnome.org>
18266 * expression.cs (Binary.ResolveOperator): Don't silently return
18267 but return an error if an operator cannot be applied between two
18270 2002-08-28 Martin Baulig <martin@gnome.org>
18272 * class.cs (Constructor.Define): Set the permission attributes
18273 correctly instead of making all constructors public.
18275 2002-08-28 Martin Baulig <martin@gnome.org>
18277 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
18278 for private members before reporting a CS0103; if we find anything,
18281 2002-08-28 Martin Baulig <martin@gnome.org>
18283 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
18284 to check whether `closure_start_type == closure_invocation_type',
18285 we also need to check whether `m.DeclaringType == closure_invocation_type'
18286 before bypassing the permission checks. We might be accessing
18287 protected/private members from the base class.
18288 (TypeManager.RealMemberLookup): Only set private_ok if private
18289 members were requested via BindingFlags.NonPublic.
18291 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
18293 * expression.cs (MemberAccess.ResolveMemberAccess): Set
18294 MethodGroupExpr.IsExplicitImpl if appropriate.
18295 (Invocation.DoResolve): Don't report the CS0120 for explicit
18296 interface implementations.
18298 2002-08-27 Martin Baulig <martin@gnome.org>
18300 * expression.cs (Invocation.DoResolve): If this is a static
18301 method and we don't have an InstanceExpression, we must report
18304 2002-08-25 Martin Baulig <martin@gnome.org>
18306 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
18307 `==' between a valuetype and an object.
18309 2002-08-25 Miguel de Icaza <miguel@ximian.com>
18311 * ecore.cs (TypeExpr): Provide a ToString method.
18313 2002-08-24 Martin Baulig <martin@gnome.org>
18315 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
18316 now called proggie.dbg and it's a binary file.
18318 2002-08-23 Martin Baulig <martin@gnome.org>
18320 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
18322 2002-08-23 Martin Baulig <martin@gnome.org>
18324 * struct.cs (MyStructInfo.ctor): Make this work with empty
18325 structs; it's not allowed to use foreach() on null.
18327 2002-08-23 Martin Baulig <martin@gnome.org>
18329 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
18330 writer the full pathname of the generated assembly.
18332 2002-08-23 Martin Baulig <martin@gnome.org>
18334 * statements.cs (FlowBranching.UsageVector.MergeChildren):
18335 A `finally' block never returns or breaks; improved handling of
18338 2002-08-23 Martin Baulig <martin@gnome.org>
18340 * statement.cs (Throw.Resolve): Allow `throw null'.
18342 2002-08-23 Martin Baulig <martin@gnome.org>
18344 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
18345 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
18346 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
18347 MemberLookup would return a wrong event if this is an explicit
18348 interface implementation and the class has an event with the same
18351 2002-08-23 Martin Baulig <martin@gnome.org>
18353 * statement.cs (Block.AddChildVariableNames): New public method.
18354 (Block.AddChildVariableName): Likewise.
18355 (Block.IsVariableNameUsedInChildBlock): Likewise.
18356 (Block.AddVariable): Check whether a variable name has already
18357 been used in a child block.
18359 * cs-parser.jay (declare_local_variables): Mark all variable names
18360 from the current block as being used in a child block in the
18363 2002-08-23 Martin Baulig <martin@gnome.org>
18365 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
18366 find the symbol writer.
18368 * driver.cs: csc also allows the arguments to /define being
18369 separated by commas, not only by semicolons.
18371 2002-08-23 Martin Baulig <martin@gnome.org>
18373 * interface.cs (Interface.GetMembers): Added static check for events.
18375 2002-08-15 Martin Baulig <martin@gnome.org>
18377 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
18378 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
18380 * ecore.cs (Expression.MemberLookup): Added documentation and explained
18381 why the MethodData.EmitDestructor() change was necessary.
18383 2002-08-20 Martin Baulig <martin@gnome.org>
18385 * class.cs (TypeContainer.FindMembers): Added static check for events.
18387 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
18389 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
18390 use Type.GetEvents(), not Type.FindMembers().
18392 2002-08-20 Martin Baulig <martin@gnome.org>
18394 * decl.cs (MemberCache): Added a special method cache which will
18395 be used for method-only searched. This ensures that a method
18396 search will return a MethodInfo with the correct ReflectedType for
18399 2002-08-20 Martin Baulig <martin@gnome.org>
18401 * decl.cs (DeclSpace.FindMembers): Made this public.
18403 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18405 * delegate.cs: fixed build on windows.
18406 [FIXME: Filed as bug #29150: MCS must report these errors.]
18408 2002-08-19 Ravi Pratap <ravi@ximian.com>
18410 * ecore.cs (StandardConversionExists): Return a false
18411 if we are trying to convert the void type to anything else
18412 since that is not allowed.
18414 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
18415 we flag error 70 in the event an event is trying to be accessed
18416 directly from outside the declaring type.
18418 2002-08-20 Martin Baulig <martin@gnome.org>
18420 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
18421 MemberCache from typemanager.cs to decl.cs.
18423 2002-08-19 Martin Baulig <martin@gnome.org>
18425 * class.cs (TypeContainer): Implement IMemberContainer.
18426 (TypeContainer.DefineMembers): Create the MemberCache.
18427 (TypeContainer.FindMembers): Do better BindingFlags checking; only
18428 return public members if BindingFlags.Public was given, check
18429 whether members are static.
18431 2002-08-16 Martin Baulig <martin@gnome.org>
18433 * decl.cs (DeclSpace.Define): Splitted this in Define and
18434 DefineMembers. DefineMembers is called first and initializes the
18437 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
18438 DefineMembers() on all our DeclSpaces.
18440 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
18441 but call DefineMembers() on all nested interfaces. We call their
18442 Define() in our new Define() function.
18444 * interface.cs (Interface): Implement IMemberContainer.
18445 (Interface.Define): Moved all code except the attribute stuf to
18447 (Interface.DefineMembers): Initialize the member cache.
18449 * typemanager.cs (IMemberFinder): Removed this interface, we don't
18450 need this anymore since we can use MemberCache.FindMembers directly.
18452 2002-08-19 Martin Baulig <martin@gnome.org>
18454 * typemanager.cs (MemberCache): When creating the cache for an
18455 interface type, add all inherited members.
18456 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18457 to `out bool used_cache' and documented it.
18458 (TypeManager.MemberLookup): If we already used the cache in the first
18459 iteration, we don't need to do the interfaces check.
18461 2002-08-19 Martin Baulig <martin@gnome.org>
18463 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18464 here from IMemberFinder and don't implement this interface anymore.
18465 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18467 * typemanager.cs (IMemberFinder): This interface is now only used by
18468 classes which actually support the member cache.
18469 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18470 since we only put DeclSpaces into this Hashtable.
18471 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18472 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18474 2002-08-16 Martin Baulig <martin@gnome.org>
18476 * typemanager.cs (ICachingMemberFinder): Removed.
18477 (IMemberFinder.MemberCache): New property.
18478 (TypeManager.FindMembers): Merged this with RealFindMembers().
18479 This function will never be called from TypeManager.MemberLookup()
18480 so we can't use the cache here, just the IMemberFinder.
18481 (TypeManager.MemberLookup_FindMembers): Check whether the
18482 IMemberFinder has a MemberCache and call the cache's FindMembers
18484 (MemberCache): Rewrote larger parts of this yet another time and
18485 cleaned it up a bit.
18487 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18489 * driver.cs (LoadArgs): Support quoting.
18491 (Usage): Show the CSC-like command line arguments.
18493 Improved a few error messages.
18495 2002-08-15 Martin Baulig <martin@gnome.org>
18497 * typemanager.cs (IMemberContainer.Type): New property.
18498 (IMemberContainer.IsInterface): New property.
18500 The following changes are conditional to BROKEN_RUNTIME, which is
18501 defined at the top of the file.
18503 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18504 class'es members, but add all members from TypeHandle.ObjectType
18505 if we're an interface.
18506 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18507 is the current type.
18508 (MemberCache.CacheEntry.Container): Removed this field.
18509 (TypeHandle.GetMembers): Include inherited members.
18511 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18513 * typemanager.cs: fixed compilation and added a comment on a field that
18516 2002-08-15 Martin Baulig <martin@gnome.org>
18518 * class.cs (ConstructorInitializer.Resolve): In the
18519 Expression.MemberLookup call, use the queried_type as
18522 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18523 declared' attribute, it's always true.
18524 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18525 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18526 temporary wrapper for FindMembers which tells MemberLookup whether
18527 members from the base classes are included in the return value.
18528 This will go away soon.
18529 (TypeManager.MemberLookup): Use this temporary hack here; once the
18530 new MemberCache is completed, we don't need to do the DeclaredOnly
18531 looping here anymore since the MemberCache will take care of this.
18532 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18533 (MemberCache): When creating the MemberCache for a class, get
18534 members from the current class and all its base classes.
18535 (MemberCache.CacheEntry.Container): New field. This is a
18536 temporary hack until the Mono runtime is fixed to distinguish
18537 between ReflectedType and DeclaringType. It allows us to use MCS
18538 with both the MS runtime and the unfixed Mono runtime without
18539 problems and without accecting performance.
18540 (MemberCache.SearchMembers): The DeclaredOnly looping from
18541 TypeManager.MemberLookup is now done here.
18543 2002-08-14 Martin Baulig <martin@gnome.org>
18545 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18546 Type.GetFields on dynamic types but get the fields from the
18547 corresponding TypeContainer.
18548 (MyStructInfo.GetStructInfo): Added check for enum types.
18550 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18551 (MemberList.SyncRoot): Implemented.
18552 (TypeManager.FilterWithClosure): No need to check permissions if
18553 closure_start_type == closure_invocation_type, don't crash if
18554 closure_invocation_type is null.
18556 2002-08-13 Martin Baulig <martin@gnome.org>
18558 Rewrote TypeContainer.FindMembers to use a member cache. This
18559 gives us a speed increase of about 35% for the self-hosting MCS
18560 build and of about 15-20% for the class libs (both on GNU/Linux).
18562 * report.cs (Timer): New class to get enhanced profiling. This
18563 whole class is "TIMER" conditional since it remarkably slows down
18566 * class.cs (MemberList): New class. This is an IList wrapper
18567 which we're now using instead of passing MemberInfo[]'s around to
18568 avoid copying this array unnecessarily.
18569 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18570 (ICachingMemberFinder, IMemberContainer): New interface.
18571 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18572 has already been checked, otherwise use it for the name comparision.
18573 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18574 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18575 if possible. Returns a MemberList, not a MemberInfo [].
18576 (TypeHandle): New class, implements IMemberContainer. We create
18577 one instance of this class per type, it contains a MemberCache
18578 which is used to do the member lookups.
18579 (MemberCache): New class. Each instance of this class contains
18580 all members of a type and a name-based hash table.
18581 (MemberCache.FindMembers): This is our new member lookup
18582 function. First, it looks up all members of the requested name in
18583 the hash table. Then, it walks this list and sorts out all
18584 applicable members and returns them.
18586 2002-08-13 Martin Baulig <martin@gnome.org>
18588 In addition to a nice code cleanup, this gives us a performance
18589 increase of about 1.4% on GNU/Linux - not much, but it's already
18590 half a second for the self-hosting MCS compilation.
18592 * typemanager.cs (IMemberFinder): New interface. It is used by
18593 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18594 Enum, Delegate or Interface.
18595 (TypeManager.finder_to_member_finder): New PtrHashtable.
18596 (TypeManager.finder_to_container): Removed.
18597 (TypeManager.finder_to_delegate): Removed.
18598 (TypeManager.finder_to_interface): Removed.
18599 (TypeManager.finder_to_enum): Removed.
18601 * interface.cs (Interface): Implement IMemberFinder.
18603 * delegate.cs (Delegate): Implement IMemberFinder.
18605 * enum.cs (Enum): Implement IMemberFinder.
18607 * class.cs (TypeContainer): Implement IMemberFinder.
18609 2002-08-12 Martin Baulig <martin@gnome.org>
18611 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18613 2002-08-12 Martin Baulig <martin@gnome.org>
18615 * ecore.cs (ITypeExpression): New interface for expressions which
18617 (TypeExpression): Renamed to TypeLookupExpression.
18618 (Expression.DoResolve): If we're doing a types-only lookup, the
18619 expression must implement the ITypeExpression interface and we
18620 call DoResolveType() on it.
18621 (SimpleName): Implement the new ITypeExpression interface.
18622 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18623 hack, the situation that we're only looking up types can't happen
18624 anymore when this method is called. Moved the type lookup code to
18625 DoResolveType() and call it.
18626 (SimpleName.DoResolveType): This ITypeExpression interface method
18627 is now doing the types-only lookup.
18628 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18629 (ResolveFlags): Added MaskExprClass.
18631 * expression.cs (MemberAccess): Implement the ITypeExpression
18633 (MemberAccess.DoResolve): Added support for a types-only lookup
18634 when we're called via ITypeExpression.DoResolveType().
18635 (ComposedCast): Implement the ITypeExpression interface.
18637 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18638 Expression.Resolve() with ResolveFlags.Type instead.
18640 2002-08-12 Martin Baulig <martin@gnome.org>
18642 * interface.cs (Interface.Define): Apply attributes.
18644 * attribute.cs (Attribute.ApplyAttributes): Added support for
18645 interface attributes.
18647 2002-08-11 Martin Baulig <martin@gnome.org>
18649 * statement.cs (Block.Emit): Only check the "this" variable if we
18650 do not always throw an exception.
18652 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18653 whether the property has a set accessor.
18655 2002-08-11 Martin Baulig <martin@gnome.org>
18657 Added control flow analysis support for structs.
18659 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18660 with control flow analysis turned off.
18661 (IVariable): New interface.
18662 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18663 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18664 (FieldExpr.DoResolve): Resolve the instance expression with flow
18665 analysis turned off and do the definite assignment check after the
18666 resolving when we know what the expression will resolve to.
18668 * expression.cs (LocalVariableReference, ParameterReference):
18669 Implement the new IVariable interface, only call the flow analysis
18670 code if ec.DoFlowAnalysis is true.
18671 (This): Added constructor which takes a Block argument. Implement
18672 the new IVariable interface.
18673 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18674 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18675 This does the definite assignment checks for struct members.
18677 * class.cs (Constructor.Emit): If this is a non-static `struct'
18678 constructor which doesn't have any initializer, call
18679 Block.AddThisVariable() to tell the flow analysis code that all
18680 struct elements must be initialized before control returns from
18683 * statement.cs (MyStructInfo): New public class.
18684 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18685 argument to this indexer. If non-zero, check an individual struct
18686 member, not the whole struct.
18687 (FlowBranching.CheckOutParameters): Check struct members.
18688 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18689 overloaded versions of these methods which take an additional
18690 `int field_idx' argument to check struct members.
18691 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18692 overloaded versions of these methods which take an additional
18693 `string field_name' argument to check struct member.s
18694 (VariableInfo): Implement the IVariable interface.
18695 (VariableInfo.StructInfo): New public property. Returns the
18696 MyStructInfo instance of the variable if it's a struct or null.
18697 (Block.AddThisVariable): New public method. This is called from
18698 Constructor.Emit() for non-static `struct' constructor which do
18699 not have any initializer. It creates a special variable for the
18700 "this" instance variable which will be checked by the flow
18701 analysis code to ensure that all of the struct's fields are
18702 initialized before control returns from the constructor.
18703 (UsageVector): Added support for struct members. If a
18704 variable/parameter is a struct with N members, we reserve a slot
18705 in the usage vector for each member. A struct is considered fully
18706 initialized if either the struct itself (slot 0) or all its
18707 members are initialized.
18709 2002-08-08 Martin Baulig <martin@gnome.org>
18711 * driver.cs (Driver.MainDriver): Only report an error CS5001
18712 if there were no compilation errors.
18714 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18715 `UnsafeContext' property to determine whether the parent is in
18716 unsafe context rather than checking the parent's ModFlags:
18717 classes nested in an unsafe class are unsafe as well.
18719 2002-08-08 Martin Baulig <martin@gnome.org>
18721 * statement.cs (UsageVector.MergeChildren): Distinguish between
18722 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18723 we return. Added test17() and test18() to test-154.cs.
18725 2002-08-08 Martin Baulig <martin@gnome.org>
18727 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18728 Family access, make sure the invoking type isn't a subclass of the
18729 queried type (that'd be a CS1540).
18731 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18732 this method which takes an additional `Type invocation_type'.
18734 * expression.cs (BaseAccess.DoResolve): Use the base type as
18735 invocation and query type.
18736 (MemberAccess.DoResolve): If the lookup failed and we're about to
18737 report a CS0122, try a lookup with the ec.ContainerType - if this
18738 succeeds, we must report a CS1540.
18740 2002-08-08 Martin Baulig <martin@gnome.org>
18742 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18743 (MethodGroupExpr): Implement the IMemberExpr interface.
18745 * expression (MemberAccess.ResolveMemberAccess): No need to have
18746 any special code for MethodGroupExprs anymore, they're now
18749 2002-08-08 Martin Baulig <martin@gnome.org>
18751 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18752 Family, FamANDAssem and FamORAssem permissions.
18753 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18755 2002-08-08 Martin Baulig <martin@gnome.org>
18757 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18758 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18761 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18763 * driver.cs: implemented /resource option to embed managed resources.
18765 2002-08-07 Martin Baulig <martin@gnome.org>
18767 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18768 (FieldBase.HasFieldInitializer): New public property.
18769 (FieldBase.GetInitializerExpression): New public method. Resolves and
18770 returns the field initializer and makes sure it is only resolved once.
18771 (TypeContainer.EmitFieldInitializers): Call
18772 FieldBase.GetInitializerExpression to get the initializer, this ensures
18773 that it isn't resolved multiple times.
18775 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18776 the resolving process (SimpleName/MemberLookup) that we're currently
18777 emitting a field initializer (which must not access any instance members,
18778 this is an error CS0236).
18780 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18781 argument, if the `IsFieldInitializer' flag is set, we must report and
18782 error CS0236 and not an error CS0120.
18784 2002-08-07 Martin Baulig <martin@gnome.org>
18786 * ecore.cs (IMemberExpr): New public interface.
18787 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18788 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18789 if the expression is an IMemberExpr.
18791 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18792 to be null, implicitly default to `this' if we're non-static in
18793 this case. Simplified the code a lot by using the new IMemberExpr
18794 interface. Also fixed bug #28176 here.
18796 2002-08-06 Martin Baulig <martin@gnome.org>
18798 * cs-parser.jay (SimpleLookup): Removed. We need to create
18799 ParameterReferences during semantic analysis so that we can do a
18800 type-only search when resolving Cast, TypeOf and SizeOf.
18801 (block): Pass the `current_local_parameters' to the Block's
18804 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18805 argument to the constructor.
18806 (ConstructorInitializer.Resolve): Create a temporary implicit
18807 block with the parameters.
18809 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18810 references here if we aren't doing a type-only search.
18812 * statement.cs (Block): Added constructor which takes a
18813 `Parameters parameters' argument.
18814 (Block.Parameters): New public property.
18816 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18817 to `Parameters' and made it public readonly.
18819 2002-08-06 Martin Baulig <martin@gnome.org>
18821 * ecore.cs (Expression.Warning): Made this public as well.
18823 * report.cs (Report.Debug): Print the contents of collections.
18825 2002-08-06 Martin Baulig <martin@gnome.org>
18827 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18828 used to tell Resolve() which kinds of expressions it may return.
18829 (Expression.Resolve): Added overloaded version of this method which
18830 takes a `ResolveFlags flags' argument. This can be used to tell
18831 Resolve() which kinds of expressions it may return. Reports a
18833 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18834 ResolveFlags.SimpleName.
18835 (Expression.Error118): Added overloaded version of this method which
18836 takes a `ResolveFlags flags' argument. It uses the flags to determine
18837 which kinds of expressions are allowed.
18839 * expression.cs (Argument.ResolveMethodGroup): New public method.
18840 Resolves an argument, but allows a MethodGroup to be returned.
18841 This is used when invoking a delegate.
18843 * TODO: Updated a bit.
18845 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18847 Fixed compilation with csc.
18849 * ecore.cs: Expression.Error made public. Is this correct? Should
18850 Warning be made public too?
18852 * expression.cs: use ea.Location instead of ea.loc.
18853 [FIXME: Filed as bug #28607: MCS must report these errors.]
18855 2002-08-06 Martin Baulig <martin@gnome.org>
18857 * ecore.cs (Expression.loc): Moved the location here instead of
18858 duplicating it in all derived classes.
18859 (Expression.Location): New public property.
18860 (Expression.Error, Expression.Warning): Made them non-static and
18861 removed the location argument.
18862 (Expression.Warning): Added overloaded version which takes an
18863 `int level' argument.
18864 (Expression.Error118): Make this non-static and removed the
18865 expression and location arguments.
18866 (TypeExpr): Added location argument to the constructor.
18868 * expression.cs (StaticCallExpr): Added location argument to
18870 (Indirection, PointerArithmetic): Likewise.
18871 (CheckedExpr, UnCheckedExpr): Likewise.
18872 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18873 (StringPtr): Likewise.
18876 2002-08-05 Martin Baulig <martin@gnome.org>
18878 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18880 * assign.cs (Assign.DoResolve): Check whether the source
18881 expression is a value or variable.
18883 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18884 while resolving the corresponding blocks.
18886 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18887 an error, don't silently return null.
18889 * statement.cs (Block.AddVariable): Do the error reporting here
18890 and distinguish between CS0128 and CS0136.
18891 (Block.DoResolve): Report all unused labels (warning CS0164).
18892 (LabeledStatement): Pass the location to the constructor.
18893 (LabeledStatement.HasBeenReferenced): New property.
18894 (LabeledStatement.Resolve): Set it to true here.
18896 * statement.cs (Return.Emit): Return success even after reporting
18897 a type mismatch error (CS0126 or CS0127), this is what csc does and
18898 it avoids confusing the users with any consecutive errors.
18900 2002-08-05 Martin Baulig <martin@gnome.org>
18902 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18904 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18906 * expression.cs (MemberAccess.DoResolve): Silently return if an
18907 error has already been reported.
18909 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18910 error has already been reported.
18912 2002-08-05 Martin Baulig <martin@gnome.org>
18914 * statement.cs (UsageVector): Only initialize the `parameters'
18915 vector if we actually have any "out" parameters.
18917 2002-08-05 Martin Baulig <martin@gnome.org>
18919 * expression.cs (Binary.ResolveOperator): When combining delegates,
18920 they must have the same type.
18922 2002-08-05 Martin Baulig <martin@gnome.org>
18924 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18925 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18926 work with the ms runtime and we also don't need it: if we're a
18927 PropertyBuilder and not in the `indexer_arguments' hash, then we
18928 are a property and not an indexer.
18930 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18931 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18932 since the latter one doesn't work with the ms runtime.
18934 2002-08-03 Martin Baulig <martin@gnome.org>
18936 Fixed bugs #27998 and #22735.
18938 * class.cs (Method.IsOperator): New public field.
18939 (Method.CheckBase): Report CS0111 if there's already a method
18940 with the same parameters in the current class. Report CS0508 when
18941 attempting to change the return type of an inherited method.
18942 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18943 and it's not marked abstract or extern.
18944 (PropertyBase): New abstract base class for Property and Indexer.
18945 (PropertyBase.CheckBase): Moved here from Property and made it work
18947 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18948 the same so we can reuse it there.
18949 (Property, Indexer): Derive from PropertyBase.
18950 (MethodSignature.inheritable_property_signature_filter): New delegate
18951 to find properties and indexers.
18953 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18954 argument and improved error reporting.
18956 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18957 EmptyReadOnlyParameters and made it a property.
18959 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18960 version of this method which takes a `PropertyInfo indexer'.
18961 (TypeManager.RegisterIndexer): New method.
18963 * class.cs: Added myself as author of this file :-)
18965 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18967 * class.cs: fixed compilation on windoze.
18969 2002-08-03 Martin Baulig <martin@gnome.org>
18971 * interface.cs (Interface.GetInterfaceBases): Check whether all
18972 base interfaces are at least as accessible than the current one.
18974 * class.cs (TypeContainer.GetClassBases): Check whether base types
18975 are at least as accessible than the current type.
18976 (TypeContainer.AsAccessible): Implemented and made non-static.
18977 (MemberBase.CheckParameters): Report errors if the accessibility
18980 * delegate.cs (Delegate.Delegate): The default visibility is
18981 internal for top-level types and private for nested types.
18982 (Delegate.Define): Report errors if the accessibility checks fail.
18984 * enum.cs (Enum.Enum): The default visibility is internal for
18985 top-level types and private for nested types.
18986 (Enum.DefineType): Compute the correct visibility.
18988 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18989 function which takes a `bool is_toplevel' instead of a TypeContainer.
18991 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18994 2002-08-02 Martin Baulig <martin@gnome.org>
18996 * expression.cs (LocalVariableReferenc): Added constructor which
18997 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18998 (LocalVariableReference.IsReadOnly): New property.
18999 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
19000 variable is readonly, use our own readonly flag to do this; you can
19001 use the new constructor to get a writable reference to a read-only
19004 * cs-parser.jay (foreach_statement, using_statement): Get a writable
19005 reference to the local variable.
19007 2002-08-01 Miguel de Icaza <miguel@ximian.com>
19009 * rootcontext.cs (ResolveCore): Also include System.Exception
19011 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
19012 we reach an EmptyStatement.
19014 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
19017 * expression.cs (Binary.ResolveOperator): Check error result in
19020 use brtrue/brfalse directly and avoid compares to null.
19022 2002-08-02 Martin Baulig <martin@gnome.org>
19024 * class.cs (TypeContainer.Define): Define all nested interfaces here.
19025 Fixes bug #28407, added test-155.cs.
19027 2002-08-01 Martin Baulig <martin@gnome.org>
19029 * class.cs (Event.EmitDefaultMethod): Make this work with static
19030 events. Fixes #28311, added verify-3.cs.
19032 2002-08-01 Martin Baulig <martin@gnome.org>
19034 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
19035 `is_disposable' fields.
19036 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
19037 `hm.is_disposable' if we're using the collection pattern.
19038 (Foreach.EmitCollectionForeach): Use the correct type for the
19039 enumerator's local variable, only emit the try/finally block if
19040 necessary (fixes #27713).
19042 2002-08-01 Martin Baulig <martin@gnome.org>
19044 * ecore.cs (Expression.report118): Renamed to Error118 and made
19047 * statement.cs (Throw.Resolve): Check whether the expression is of
19048 the correct type (CS0118) and whether the type derives from
19049 System.Exception (CS0155).
19050 (Catch.Resolve): New method. Do the type lookup here and check
19051 whether it derives from System.Exception (CS0155).
19052 (Catch.CatchType, Catch.IsGeneral): New public properties.
19054 * typemanager.cs (TypeManager.exception_type): Added.
19056 2002-07-31 Miguel de Icaza <miguel@ximian.com>
19058 * driver.cs: Updated About function.
19060 2002-07-31 Martin Baulig <martin@gnome.org>
19062 Implemented Control Flow Analysis.
19064 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
19065 (EmitContext.CurrentBranching): Added.
19066 (EmitContext.StartFlowBranching): Added.
19067 (EmitContext.EndFlowBranching): Added.
19068 (EmitContext.KillFlowBranching): Added.
19069 (EmitContext.IsVariableAssigned): Added.
19070 (EmitContext.SetVariableAssigned): Added.
19071 (EmitContext.IsParameterAssigned): Added.
19072 (EmitContext.SetParameterAssigned): Added.
19073 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
19074 Added control flow analysis stuff here.
19076 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
19077 resolve the expression as lvalue.
19078 (LocalVariableReference.DoResolve): Check whether the variable has
19079 already been assigned.
19080 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
19081 the parameter as assigned here.
19082 (ParameterReference.DoResolve): Check whether the parameter has already
19084 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
19085 expression as lvalue.
19087 * statement.cs (FlowBranching): New class for the flow analysis code.
19088 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
19089 (LabeledStatement.IsDefined): New public property.
19090 (LabeledStatement.AddUsageVector): New public method to tell flow
19091 analyis that the label may be reached via a forward jump.
19092 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
19094 (VariableInfo.Number): New public field. This is used by flow analysis
19095 to number all locals of a block.
19096 (Block.CountVariables): New public property. This is the number of
19097 local variables in this block (including the locals from all parent
19099 (Block.EmitMeta): Number all the variables.
19101 * statement.cs: Added flow analysis support to all classes.
19103 2002-07-31 Martin Baulig <martin@gnome.org>
19105 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
19106 To get debugging messages, compile mcs with /define:MCS_DEBUG and
19107 then use this argument.
19109 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
19111 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
19112 use this to specify /define options.
19114 2002-07-29 Martin Baulig <martin@gnome.org>
19116 * statement.cs (Fixed): Moved all code that does variable lookups
19117 and resolvings from Emit to Resolve.
19119 * statement.cs (For): Moved all code that does variable lookups
19120 and resolvings from Emit to Resolve.
19122 * statement.cs (Using): Moved all code that does variable lookups
19123 and resolvings from Emit to Resolve.
19125 2002-07-29 Martin Baulig <martin@gnome.org>
19127 * attribute.cs (Attribute.Resolve): Explicitly catch a
19128 System.NullReferenceException when creating the
19129 CustromAttributeBuilder and report a different warning message.
19131 2002-07-29 Martin Baulig <martin@gnome.org>
19133 * support.cs (ParameterData.ParameterName): Added method to
19134 get the name of a parameter.
19136 * typemanager.cs (TypeManager.IsValueType): New public method.
19138 2002-07-29 Martin Baulig <martin@gnome.org>
19140 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
19141 is a flag which specifies that it's either ref or out.
19142 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
19143 the out parameter to `out Parameter.Modifier mod', also set the
19144 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
19146 * support.cs (InternalParameters.ParameterModifier): Distinguish
19147 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19148 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19150 * expression.cs (Argument.GetParameterModifier): Distinguish
19151 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19152 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19154 2002-07-29 Martin Baulig <martin@gnome.org>
19156 * expression.cs (ParameterReference.ParameterReference): Added
19157 `Location loc' argument to the constructor.
19159 * cs-parser.jay: Pass location to ParameterReference.
19161 2002-07-28 Miguel de Icaza <miguel@ximian.com>
19163 * statement.cs (Try): Initialize the location.
19165 * cs-parser.jay: pass location to Try.
19167 * expression.cs (Unary.Reduce): Change the prototype to return
19168 whether a constant fold could be performed or not. The result is
19169 returned in an out parameters. In the case of Indirection and
19170 AddressOf, we want to perform the full tests.
19172 2002-07-26 Miguel de Icaza <miguel@ximian.com>
19174 * statement.cs (Statement.Emit): Flag dead code.
19176 2002-07-27 Andrew Birkett <andy@nobugs.org>
19178 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
19180 2002-07-27 Martin Baulig <martin@gnome.org>
19182 * class.cs (MethodData.Define): Put back call to
19183 TypeManager.AddMethod(), accidentally commented this out.
19185 * report.cs (Debug): New public method to print debugging information,
19186 this is `[Conditional ("DEBUG")]'.
19188 2002-07-26 Martin Baulig <martin@gnome.org>
19190 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
19191 (switch_statement): Push the current_block to the switch_stack and
19192 pop it again when we're done with the switch.
19193 (switch_section): The new block is a child of the current_block.
19194 Fixes bug #24007, added test-152.cs.
19196 2002-07-27 Martin Baulig <martin@gnome.org>
19198 * expression.cs (Invocation.EmitArguments): When calling a varargs
19199 function with only its fixed arguments, we need to pass an empty
19202 2002-07-27 Martin Baulig <martin@gnome.org>
19204 Mono 0.13 has been released.
19206 2002-07-25 Miguel de Icaza <miguel@ximian.com>
19208 * driver.cs: Rename --resource to --linkres, because that is what
19209 we do currently, we dont support --resource yet.
19211 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
19213 2002-07-25 Martin Baulig <martin@gnome.org>
19215 * class.cs (MethodData): New public class. This is a `method builder'
19216 class for a method or one accessor of a Property/Indexer/Event.
19217 (MethodData.GetMethodFlags): Moved here from MemberBase.
19218 (MethodData.ApplyAttributes): Likewise.
19219 (MethodData.ApplyObsoleteAttribute): Likewise.
19220 (MethodData.ApplyConditionalAttribute): Likewise.
19221 (MethodData.ApplyDllImportAttribute): Likewise.
19222 (MethodData.CheckAbstractAndExternal): Likewise.
19223 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
19224 (MethodData.Emit): Formerly known as Method.Emit().
19225 (MemberBase): Moved everything which was specific to a single
19226 accessor/method to MethodData.
19227 (Method): Create a new MethodData and call Define() and Emit() on it.
19228 (Property, Indexer, Event): Create a new MethodData objects for each
19229 accessor and call Define() and Emit() on them.
19231 2002-07-25 Martin Baulig <martin@gnome.org>
19233 Made MethodCore derive from MemberBase to reuse the code from there.
19234 MemberBase now also checks for attributes.
19236 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
19237 (MemberBase.GetMethodFlags): Moved here from class Method and marked
19239 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
19240 `CallingConventions cc' and `Attributes opt_attrs' arguments.
19241 (MemberBase.ApplyAttributes): New virtual method; applies the
19242 attributes to a method or accessor.
19243 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
19244 (MemberBase.ApplyConditionalAttribute): Likewise.
19245 (MemberBase.ApplyDllImportAttribute): Likewise.
19246 (MemberBase.CheckAbstractAndExternal): Likewise.
19247 (MethodCore.ParameterTypes): This is now a property instead of a
19248 method, it's initialized from DoDefineParameters().
19249 (MethodCore.ParameterInfo): Removed the set accessor.
19250 (MethodCore.DoDefineParameters): New protected virtual method to
19251 initialize ParameterTypes and ParameterInfo.
19252 (Method.GetReturnType): We can now simply return the MemberType.
19253 (Method.GetMethodFlags): Override the MemberBase version and add
19254 the conditional flags.
19255 (Method.CheckBase): Moved some code from Define() here, call
19256 DoDefineParameters() here.
19257 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
19258 here to avoid some larger code duplication.
19259 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
19260 ensure that abstract and external accessors don't declare a body.
19262 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
19263 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
19264 lookup in the attribute's parent classes, so we need to abort as soon
19265 as we found the first match.
19266 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
19267 the attribute has no arguments.
19269 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
19272 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19274 * cs-parser.jay: reverted previous patch.
19276 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19278 * cs-parser.jay: fixed bug #22119.
19280 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19282 * attribute.cs: fixed compilation. The error was:
19283 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
19284 be assigned to before control leaves the current method."
19285 [FIXME: Filed as bug #28186: MCS must report this error.]
19287 2002-07-25 Martin Baulig <martin@gnome.org>
19289 * attribute.cs (Attribute.Conditional_GetConditionName): New static
19290 method to pull the condition name ouf of a Conditional attribute.
19291 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
19292 the obsolete message and error flag out of an Obsolete attribute.
19294 * class.cs (Method.GetMethodFlags): New public method to get the
19295 TypeManager.MethodFlags for this method.
19296 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
19298 (Method.Define): Get and apply the Obsolete and Conditional attributes;
19299 if we're overriding a virtual function, set the new private variable
19300 `parent_method'; call the new TypeManager.AddMethod().
19302 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19303 the MethodBuilder and the Method in a PtrHashtable.
19304 (TypeManager.builder_to_method): Added for this purpose.
19305 (TypeManager.MethodFlags): Added IsObsoleteError.
19306 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
19307 Obsolete and Conditional arguments in MethodBuilders. If we discover
19308 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
19309 the message from the attribute.
19311 2002-07-24 Martin Baulig <martin@gnome.org>
19313 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
19314 preprocessor directives, ensure that the argument to #define/#undef is
19315 exactly one identifier and that it's actually an identifier.
19317 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
19320 2002-07-24 Martin Baulig <martin@gnome.org>
19322 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
19323 initialize it to TypeManager.object_type in the constructor.
19324 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
19325 of the `hm.get_current' method if we're using the collection pattern.
19326 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
19327 for the explicit conversion to make it work when we're using the collection
19328 pattern and the `Current' property has a different return type than `object'.
19331 2002-07-24 Martin Baulig <martin@gnome.org>
19333 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
19334 does not match, but don't report any errors. This method is called in
19335 order for all methods in a MethodGroupExpr until a matching method is
19336 found, so we don't want to bail out if the first method doesn't match.
19337 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
19338 matches, report the 123. Fixes #28070.
19340 2002-07-24 Martin Baulig <martin@gnome.org>
19342 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
19343 TypeManager.TypeToCoreType() to the top of the method so the
19344 following equality checks will work. Fixes #28107.
19346 2002-07-24 Martin Baulig <martin@gnome.org>
19348 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
19349 operand is of type uint, and the other operand is of type sbyte,
19350 short or int, the operands are converted to type long." -
19351 Actually do what this comment already told us. Fixes bug #28106,
19354 2002-07-24 Martin Baulig <martin@gnome.org>
19356 * class.cs (MethodBase): New abstract class. This is now a base
19357 class for Property, Indexer and Event to avoid some code duplication
19358 in their Define() and DefineMethods() methods.
19359 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
19360 generic methods for Define() and DefineMethods().
19361 (FieldBase): Derive from MemberBase, not MemberCore.
19362 (Property): Derive from MemberBase, not MemberCore.
19363 (Property.DefineMethod): Moved all the code from this method to the
19364 new MethodBase.DefineAccessor(), just call it with appropriate
19366 (Property.Define): Call the new Property.DoDefine(), this does some
19367 sanity checks and we don't need to duplicate the code everywhere.
19368 (Event): Derive from MemberBase, not MemberCore.
19369 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
19370 accessors, this will also make them work with interface events.
19371 (Indexer): Derive from MemberBase, not MemberCore.
19372 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
19373 (Indexer.Define): Use the new MethodBase functions.
19375 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
19376 argument to the constructor.
19377 (Interface.FindMembers): Added support for interface events.
19378 (Interface.PopluateEvent): Implemented.
19380 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
19382 2002-07-22 Miguel de Icaza <miguel@ximian.com>
19384 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
19385 but this is required to check for a method name being the same as
19386 the containing class.
19390 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19392 * interface.cs: initialize variable.
19394 2002-07-23 Martin Baulig <martin@gnome.org>
19396 Implemented the IndexerName attribute in interfaces.
19398 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
19399 name if this is an explicit interface implementation.
19400 (Indexer.InterfaceIndexerName): New public variable. If we're
19401 implementing an interface indexer, this is the IndexerName in that
19402 interface. Otherwise, it's the IndexerName.
19403 (Indexer.DefineMethod): If we're implementing interface indexer,
19404 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
19405 and Pending.ImplementIndexer methods.
19406 (Indexer.Define): Also define the PropertyBuilder if we're
19407 implementing an interface indexer and this is neither an explicit
19408 interface implementation nor do the IndexerName match the one in
19411 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
19412 If a method is defined here, then we always need to create a proxy
19413 for it. This is used when implementing interface indexers.
19414 (Pending.IsInterfaceIndexer): New public method.
19415 (Pending.ImplementIndexer): New public method.
19416 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
19417 This is used when implementing interface indexers to define a proxy
19419 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
19420 define a proxy if necessary.
19422 * interface.cs (Interface.IndexerName): New public variable.
19423 (Interface.PopulateIndexer): Set the IndexerName.
19424 (Interface.DefineIndexers): New private method. Populate all the
19425 indexers and make sure their IndexerNames match.
19427 * typemanager.cs (IndexerPropertyName): Added support for interface
19430 2002-07-22 Martin Baulig <martin@gnome.org>
19432 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
19433 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
19434 ret if HasReturnLabel.
19435 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
19438 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
19439 and set the ec.LoopBeginTryCatchLevel.
19440 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
19441 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
19442 the current ec.TryCatchLevel, the branch goes out of an exception
19443 block. In this case, we need to use Leave and not Br.
19445 2002-07-22 Martin Baulig <martin@gnome.org>
19447 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
19448 block unless the block does not always return or it is contained in
19449 another try { ... } catch { ... } block. Fixes bug #26506.
19450 Added verify-1.cs to the test suite.
19452 2002-07-22 Martin Baulig <martin@gnome.org>
19454 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
19455 then we do not always return. Fixes bug #24985.
19457 2002-07-22 Martin Baulig <martin@gnome.org>
19459 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19460 lookup on a per-class level; ie. walk up the class hierarchy until we
19461 found at least one applicable method, then choose the best among them.
19462 Fixes bug #24463 and test-29.cs.
19464 2002-07-22 Martin Baulig <martin@gnome.org>
19466 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19467 return types of the methods. The return type is not part of the
19468 signature and we must not check it to make the `new' modifier work.
19469 Fixes bug #27999, also added test-147.cs.
19470 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19472 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19473 on the method's return type.
19475 2002-07-21 Martin Baulig <martin@gnome.org>
19477 * assign.cs: Make this work if the rightmost source is a constant and
19478 we need to do an implicit type conversion. Also adding a few more tests
19479 to test-38.cs which should have caught this.
19481 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19482 target in the makefile for this. The makefile.gnu is primarily intended
19483 for end-users who don't want to debug the compiler.
19485 2002-07-21 Martin Baulig <martin@gnome.org>
19487 * assign.cs: Improved the Assign class so it can now handle embedded
19488 assignments (X = Y = Z = something). As a side-effect this'll now also
19489 consume less local variables. test-38.cs now passes with MCS, added
19490 a few new test cases to that test.
19492 2002-07-20 Martin Baulig <martin@gnome.org>
19494 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19495 instructions. Fixes bug #27977, also added test-146.cs.
19497 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19499 * cs-tokenizer.cs: fixed getHex ().
19501 2002-07-19 Martin Baulig <martin@gnome.org>
19503 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19504 not Type.GetType() to lookup the array type. This is needed when
19505 we're constructing an array of a user-defined type.
19506 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19507 single-dimensional arrays, but also for single-dimensial arrays of
19510 2002-07-19 Martin Baulig <martin@gnome.org>
19512 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19513 this function is called, it's not allowed to share LocalBuilders
19514 among ILGenerators.
19516 2002-07-19 Martin Baulig <martin@gnome.org>
19518 * expression.cs (Argument.Resolve): Report an error 118 when trying
19519 to pass a type as argument.
19521 2002-07-18 Martin Baulig <martin@gnome.org>
19523 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19524 Conv_R_Un for the signed `long' type.
19526 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19528 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19529 `expr' for the temporary result, as that will fail if we do
19530 multiple resolves on the same expression.
19532 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19534 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19535 ec.TypeContainer for looking up aliases.
19537 * class.cs (TypeContainer): Remove LookupAlias from here.
19539 * decl.cs (DeclSpace); Move here.
19541 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19543 * class.cs (FindMembers): Only call filter if the constructor
19544 bulider is not null.
19546 Also handle delegates in `NestedTypes' now. Now we will perform
19547 type lookups using the standard resolution process. This also
19550 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19551 This uses Expressions (the limited kind that can be parsed by the
19552 tree) instead of strings.
19554 * expression.cs (ComposedCast.ToString): Implement, used to flag
19555 errors since now we have to render expressions.
19557 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19560 * ecore.cs (SimpleName.ToString): ditto.
19562 * cs-parser.jay: Instead of using strings to assemble types, use
19563 Expressions to assemble the type (using SimpleName, ComposedCast,
19564 MemberAccess). This should fix the type lookups in declarations,
19565 because we were using a different code path for this.
19567 * statement.cs (Block.Resolve): Continue processing statements
19568 even when there is an error.
19570 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19572 * class.cs (Event.Define): Also remove the `remove' method from
19573 the list of pending items.
19575 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19576 generate more compact code.
19578 2002-07-17 Martin Baulig <martin@gnome.org>
19580 * const.cs (Const.LookupConstantValue): Add support for constant
19581 `unchecked' and `checked' expressions.
19582 Also adding test case test-140.cs for this.
19584 2002-07-17 Martin Baulig <martin@gnome.org>
19586 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19587 check whether mi.ReturnType implements the IEnumerator interface; the
19588 `==' and the IsAssignableFrom() will fail in this situation.
19590 2002-07-16 Ravi Pratap <ravi@ximian.com>
19592 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19595 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19597 * expression.cs: fixed bug #27811.
19599 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19601 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19602 Molaro: when we are a ref, the value already contains a pointer
19603 value, do not take the address of it.
19605 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19606 * removed mb-parser.jay and mb-tokenizer.cs
19608 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19610 * expression.cs: check against the building corlib void type.
19612 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19614 * ecore.cs: fix for valuetype static readonly fields: when
19615 initializing them, we need their address, not the address of a copy.
19617 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19619 * typemanager.cs: register also enum_type in corlib.
19621 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19623 * class.cs: allow calling this (but not base) initializers in structs.
19625 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19627 * ecore.cs: make sure we compare against the building base types
19630 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19632 * typemanager.cs: fix TypeToCoreType() to handle void and object
19633 (corlib gets no more typerefs after this change).
19635 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19637 * expression.cs (ArrayCreation.EmitArrayArguments): use
19638 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19640 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19641 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19642 array indexes, the runtime actually forbids them.
19644 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19645 for array arguments here.
19647 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19648 instead of the default for ValueTypes.
19650 (New.DoEmit): Use IsValueType instead of
19651 IsSubclassOf (value_type)
19652 (New.DoResolve): ditto.
19653 (Invocation.EmitCall): ditto.
19655 * assign.cs (Assign): ditto.
19657 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19658 Statements *are* currently doing part of their resolution during
19661 Expressions do always resolve during resolve, but statements are
19662 only required to propagate resolution to their children.
19664 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19666 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19668 (LoadAssembly): Do not add the dll if it is already specified
19670 (MainDriver): Add the System directory to the link path at the end,
19671 after all the other -L arguments.
19673 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19674 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19675 ldelem.u1) and using the opposite for sbytes.
19677 This fixes Digger, and we can finally run it.
19679 * driver.cs (UnixParseOption): Move the option parsing here.
19680 (CSCParseOption): Implement CSC-like parsing of options.
19682 We now support both modes of operation, the old Unix way, and the
19683 new CSC-like way. This should help those who wanted to make cross
19684 platform makefiles.
19686 The only thing broken is that /r:, /reference: and /lib: are not
19687 implemented, because I want to make those have the same semantics
19688 as the CSC compiler has, and kill once and for all the confussion
19689 around this. Will be doing this tomorrow.
19691 * statement.cs (Unsafe.Resolve): The state is checked during
19692 resolve, not emit, so we have to set the flags for IsUnsfe here.
19694 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19696 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19697 not catch the Error_ObjectRefRequired in SimpleName (as it is
19698 possible to have a class/instance variable name that later gets
19699 deambiguated), we have to check this here.
19701 2002-07-10 Ravi Pratap <ravi@ximian.com>
19703 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19704 make static and put into Expression.
19706 (Event.Define): Register the private field of the event with the
19707 TypeManager so that GetFieldFromEvent can get at it.
19709 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19710 keep track of the private field associated with an event which
19713 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19716 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19718 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19720 * expression.cs (Binary.EmitBranchable): this routine emits the
19721 Binary expression in a branchable context. This basically means:
19722 we need to branch somewhere, not just get the value on the stack.
19724 This works together with Statement.EmitBoolExpression.
19726 * statement.cs (Statement.EmitBoolExpression): Use
19729 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19731 * statement.cs (For): Reduce the number of jumps in loops.
19733 (For): Implement loop inversion for the For statement.
19735 (Break): We can be breaking out of a Try/Catch controlled section
19736 (foreach might have an implicit try/catch clause), so we need to
19737 use Leave instead of Br.
19739 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19740 now). If the instace expression supports IMemoryLocation, we use
19741 the AddressOf method from the IMemoryLocation to extract the
19742 address instead of emitting the instance.
19744 This showed up with `This', as we were emitting the instance
19745 always (Emit) instead of the Address of This. Particularly
19746 interesting when This is a value type, as we dont want the Emit
19747 effect (which was to load the object).
19749 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19751 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19753 * statement.cs (Checked): Set the CheckedState during the resolve
19754 process too, as the ConvCast operations track the checked state on
19755 the resolve process, and not emit.
19757 * cs-parser.jay (namespace_member_declaration): Flag that we have
19758 found a declaration when we do. This is used to flag error 1529
19760 * driver.cs: Report ok when we display the help only.
19762 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19764 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19766 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19768 * cs-tokenizer.cs (define): We also have to track locally the
19769 defines. AllDefines is just used for the Conditional Attribute,
19770 but we also need the local defines for the current source code.
19772 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19774 * statement.cs (While, For, Do): These loops can exit through a
19775 Break statement, use this information to tell whether the
19776 statement is the last piece of code.
19778 (Break): Flag that we break.
19780 * codegen.cs (EmitContexts): New `Breaks' state variable.
19782 2002-07-03 Martin Baulig <martin@gnome.org>
19784 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19785 modifiers in method declarations in structs. Otherwise, you won't
19786 be able to override things like Object.Equals().
19788 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19790 * class.cs (Method, Property, Indexer): Do not allow the public
19791 modifier to be used in explicit interface implementations.
19793 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19794 override modifiers in method declarations in structs
19796 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19798 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19799 integer or real overflow, report an error
19801 2002-07-02 Martin Baulig <martin@gnome.org>
19803 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19804 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19805 to tell the runtime about our newly created System.Object and
19806 System.ValueType types.
19808 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19810 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19811 struct instead of Ldarg/Starg.
19813 2002-07-02 Martin Baulig <martin@gnome.org>
19815 * expression.cs (Indirection.Indirection): Call
19816 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19818 2002-07-02 Martin Baulig <martin@gnome.org>
19820 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19821 ValueType, call TypeManager.TypeToCoreType() on it.
19822 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19823 the OpCodes.Newarr argument.
19825 2002-07-02 Martin Baulig <martin@gnome.org>
19827 * expression.cs (Invocation.EmitCall): When compiling corlib,
19828 replace all calls to the system's System.Array type to calls to
19829 the newly created one.
19831 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19832 System.Array methods.
19833 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19834 from the system's System.Array type which must be replaced.
19836 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19838 * typemanager.cs: load unverifiable_code_ctor so we can build
19839 corlib using the correct type. Avoid using GetTypeCode() with
19841 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19842 TypeManager.object_type to allow building corlib.
19844 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19846 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19848 2002-07-01 Martin Baulig <martin@gnome.org>
19850 * class.cs: Make the last change actually work, we need to check
19851 whether `ifaces != null' to avoid a crash.
19853 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19855 * class.cs: when we build structs without fields that implement
19856 interfaces, we need to add the interfaces separately, since there is
19857 no API to both set the size and add the interfaces at type creation
19860 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19862 * expression.cs: the dimension arguments to the array constructors
19863 need to be converted if they are a long.
19865 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19867 * class.cs: don't emit ldarg.0 if there is no parent constructor
19868 (fixes showstopper for corlib).
19870 2002-06-29 Martin Baulig <martin@gnome.org>
19872 MCS now compiles corlib on GNU/Linux :-)
19874 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19875 ie. check for MethodImplOptions.InternalCall.
19877 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19878 and TypeManager.attribute_type are null, so we must explicitly check
19879 whether parent is not null to find out whether it's an attribute type.
19880 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19881 and SetBuilder, not only if the property is neither abstract nor external.
19882 This is necessary to set the MethodImplOptions on the accessor methods.
19883 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19884 SetBuilder, see Property.Emit().
19886 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19887 populate "System.Object", "System.ValueType" and "System.Attribute" since
19888 they've already been populated from BootCorlib_PopulateCoreTypes().
19890 2002-06-29 Martin Baulig <martin@gnome.org>
19892 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19893 is the NullLiteral, we also need to make sure that target_type is not
19896 2002-06-29 Martin Baulig <martin@gnome.org>
19898 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19899 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19900 before calling BootstrapCorlib_ResolveDelegate ().
19902 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19904 * statement.cs: fixed build-breaker. All tests passed ok.
19906 2002-06-27 Martin Baulig <martin@gnome.org>
19908 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19909 for System.Decimal when compiling corlib.
19911 2002-06-27 Martin Baulig <martin@gnome.org>
19913 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19914 switch blocks which contain nothing but a default clause.
19916 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19918 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19920 2002-06-27 Martin Baulig <martin@gnome.org>
19922 * ecore.cs (PropertyExpr.PropertyExpr): Call
19923 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19925 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19926 is already a TypeBuilder.
19928 2002-06-27 Martin Baulig <martin@gnome.org>
19930 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19931 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19932 the "from an array-type to System.Array" case. This makes it work
19933 when compiling corlib.
19935 2002-06-27 Martin Baulig <martin@gnome.org>
19937 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19938 non-static PropertyExpr, set its InstanceExpression. This makes
19939 the `ICollection.Count' property work in System/Array.cs.
19941 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19943 * driver.cs: Made error handling more consistent. Errors now
19944 tracked by Report class, so many methods which used to return int
19945 now return void. Main() now prints success/failure and
19946 errors/warnings message.
19948 Renamed '--probe' compiler argument to '--expect-error'. Removed
19949 the magic number return values (123 and 124). Now, if the
19950 expected error occurs, the compiler exits with success (exit value
19951 0). If the compilation completes without seeing that particular
19952 error, the compiler exits with failure (exit value 1). The
19953 makefile in mcs/errors has been changed to handle the new behaviour.
19955 * report.cs: Made 'expected error' number a property and renamed
19956 it from 'Probe' to 'ExpectedError'.
19958 * genericparser.cs: Removed error handling support, since it is
19959 now all done by Report class.
19961 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19962 class, so parse() no longer returns an int.
19964 * namespace.cs: Use Report.Error instead of GenericParser.error
19966 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19968 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19969 TypeContainer.AddOperator): At the front of the list put the
19970 explicit implementations, so they get resolved/defined first.
19972 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19974 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19975 interface type is implemented by this TypeContainer. Used during
19976 explicit interface implementation.
19978 (Property.Define, Indexer.Define, Method.Define): Validate that
19979 the given interface in the explicit implementation is one of the
19980 base classes for the containing type.
19982 Also if we are explicitly implementing an interface, but there is
19983 no match in the pending implementation table, report an error.
19985 (Property.Define): Only define the property if we are
19986 not explicitly implementing a property from an interface. Use the
19987 correct name also for those properties (the same CSC uses,
19988 although that is really not needed).
19990 (Property.Emit): Do not emit attributes for explicitly implemented
19991 properties, as there is no TypeBuilder.
19993 (Indexer.Emit): ditto.
19995 Hiding then means that we do not really *implement* a pending
19996 implementation, which makes code fail.
19998 2002-06-22 Martin Baulig <martin@gnome.org>
20000 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
20001 the return value of Object.GetType(). [FIXME: we need to do this whenever
20002 we get a type back from the reflection library].
20004 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
20006 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
20008 2002-06-20 Miguel de Icaza <miguel@ximian.com>
20010 * attribute.cs: Return null if we can not look up the type.
20012 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
20013 the interface types found.
20015 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
20016 interface types found.
20018 * typemanager.cs (GetInterfaces): Make this routine returns alll
20019 the interfaces and work around the lame differences between
20020 System.Type and System.Reflection.Emit.TypeBuilder in the results
20021 result for GetInterfaces.
20023 (ExpandInterfaces): Given an array of interface types, expand and
20024 eliminate repeated ocurrences of an interface. This expands in
20025 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
20028 2002-06-21 Martin Baulig <martin@gnome.org>
20030 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
20033 2002-06-21 Martin Baulig <martin@gnome.org>
20035 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
20036 and called with one of the core types, return the corresponding typebuilder for
20039 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
20042 2002-06-21 Martin Baulig <martin@gnome.org>
20044 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
20045 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
20046 (Expression.ConvertReferenceExplicit): Likewise.
20048 * expression.cs (ElementAccess.DoResolve): Likewise.
20049 (ElementAccess.DoResolveLValue): Likewise.
20051 2002-06-10 Martin Baulig <martin@gnome.org>
20053 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
20054 add the "value" parameter to the parameter list.
20056 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
20059 2002-06-19 Miguel de Icaza <miguel@ximian.com>
20061 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
20062 the argument to an int, uint, long or ulong, per the spec. Also
20063 catch negative constants in array creation.
20065 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
20067 * class.cs: do not allow the same interface to appear twice in
20068 the definition list.
20070 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
20072 * ecore.cs: don't use ldlen with System.Array.
20074 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
20076 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
20078 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
20080 * modifiers.cs: produce correct field attributes for protected
20081 internal. Easy fix so miguel can work on ther harder stuff:-)
20083 2002-06-18 Miguel de Icaza <miguel@ximian.com>
20085 * pending.cs: New file. Move the code from class.cs here.
20086 Support clearning the pending flag for all methods (when not doing
20087 explicit interface implementation).
20089 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
20091 * rootcontext.cs: added a couple more types needed to bootstrap.
20093 2002-06-17 Miguel de Icaza <miguel@ximian.com>
20095 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
20096 constructor in the type, instead of any constructor in the type
20097 hierarchy. Thanks to Paolo for finding this bug (it showed up as
20098 a bug in the Mono runtime when applying the params attribute).
20100 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20101 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
20103 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
20105 * expression.cs (Unary.ResolveOperator): Use TypeManager
20106 to resolve the type.
20108 2002-06-13 Ravi Pratap <ravi@ximian.com>
20110 * cs-parser.jay (enum_member_declaration): Pass in the attributes
20113 * enum.cs (AddEnumMember): Add support to store the attributes associated
20114 with each member too.
20116 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
20117 field builders too - this takes care of the enum member case.
20119 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
20121 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
20122 address-of operator on both value types and pointers.
20124 2002-06-10 Martin Baulig <martin@gnome.org>
20126 * interface.cs (Interface.PopulateIndexer): Add the indexer's
20127 PropertyBuilder to the `property_builders' list.
20129 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
20130 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
20131 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
20132 find any indexers which are inherited from an interface.
20134 2002-06-09 Martin Baulig <martin@gnome.org>
20136 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
20137 the same type as the constant if necessary. There's also a test-130.cs
20140 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
20142 * typemanager.cs (TypeManager.ChangeType): Previously known as
20143 Enum.ChangeEnumType().
20145 2002-06-09 Martin Baulig <martin@gnome.org>
20147 * expression.cs (Cast.TryReduce): Added support for consts.
20149 2002-06-08 Ravi Pratap <ravi@ximian.com>
20151 * class.cs (Accessor): Hold attributes information so we can pass
20154 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
20155 Modify to pass in attributes attached to the methods.
20157 (add_accessor_declaration, remove_accessor_declaration): Ditto.
20159 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
20160 to handle the Accessor kind :-)
20162 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
20164 2002-06-08 Martin Baulig <martin@gnome.org>
20166 * expression.cs (Unary.TryReduceNegative): Added support for
20169 2002-06-08 Martin Baulig <martin@gnome.org>
20171 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
20172 name can't be found in the `defined_names' - the caller will do a
20173 MemberLookup in this case and thus find methods in System.Enum
20174 such as Enum.IsDefined().
20176 2002-06-08 Martin Baulig <martin@gnome.org>
20178 * enum.cs (Enum.ChangeEnumType): This is a custom version of
20179 Convert.ChangeType() which works with TypeBuilder created types.
20180 (Enum.LookupEnumValue, Enum.Define): Use it here.
20182 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
20183 `TypeBuilder.BaseType != null' check.
20184 (TypeContainer.FindMembers): Only lookup parent members if we
20185 actually have a parent.
20186 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
20187 (ConstructorInitializer.Resolve): Likewise.
20189 * interface.cs (Interface.FindMembers): Added
20190 `TypeBuilder.BaseType != null' check.
20192 * rootcontext.cs (RootContext.ResolveCore): Added
20193 "System.Runtime.CompilerServices.IndexerNameAttribute" to
20194 classes_second_stage.
20196 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20197 debug_type and trace_type when compiling with --nostdlib.
20199 2002-06-07 Martin Baulig <martin@gnome.org>
20201 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
20202 (AddField): Set it to true when adding a non-static field.
20203 (DefineType): Use `have_nonstatic_fields' to find out whether we
20204 have non-static fields, not `Fields != null'.
20206 2002-06-02 Miguel de Icaza <miguel@ximian.com>
20208 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
20209 dereferencing a null on the static-field code path)
20211 2002-05-30 Martin Baulig <martin@gnome.org>
20213 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
20214 to take command line arguments. Use reflection to call the new
20215 custom `Initialize' function on the symbol writer and pass it the
20216 command line arguments.
20218 * driver.cs (--debug-args): New command line argument to pass command
20219 line arguments to the symbol writer.
20221 2002-05-28 Miguel de Icaza <miguel@ximian.com>
20223 * assign.cs (DoResolve): Forgot to do the implicit conversion to
20224 the target type for indexers and properties. Thanks to Joe for
20227 2002-05-27 Miguel de Icaza <miguel@ximian.com>
20229 * typemanager.cs (MethodFlags): returns the method flags
20230 (Obsolete/ShouldIgnore) that control warning emission and whether
20231 the invocation should be made, or ignored.
20233 * expression.cs (Invocation.Emit): Remove previous hack, we should
20234 not do this on matching a base type, we should do this based on an attribute
20236 Only emit calls to System.Diagnostics.Debug and
20237 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
20238 on the command line.
20240 * rootcontext.cs: Global settings for tracing and debugging.
20242 * cs-tokenizer.cs (define): New utility function to track
20243 defines. Set the global settings for TRACE and DEBUG if found.
20245 2002-05-25 Ravi Pratap <ravi@ximian.com>
20247 * interface.cs (Populate*): Pass in the TypeContainer as well as
20248 the DeclSpace as parameters so that we can create EmitContexts and
20249 then use that to apply attributes etc.
20251 (PopulateMethod, PopulateEvent, PopulateProperty)
20252 (PopulateIndexer): Apply attributes everywhere.
20254 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
20257 (ApplyAttributes): Update accordingly.
20259 We now apply interface attributes for all members too.
20261 2002-05-26 Miguel de Icaza <miguel@ximian.com>
20263 * class.cs (Indexer.Define); Correctly check if we are explicit
20264 implementation (instead of checking the Name for a ".", we
20265 directly look up if the InterfaceType was specified).
20267 Delay the creation of the PropertyBuilder.
20269 Only create the PropertyBuilder if we are not an explicit
20270 interface implementation. This means that explicit interface
20271 implementation members do not participate in regular function
20272 lookups, and hence fixes another major ambiguity problem in
20273 overload resolution (that was the visible effect).
20275 (DefineMethod): Return whether we are doing an interface
20278 * typemanager.cs: Temporary hack until we get attributes in
20279 interfaces (Ravi is working on that) and we get IndexerName
20280 support in interfaces.
20282 * interface.cs: Register the indexers as properties.
20284 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
20285 warning, I have verified that this is a bug in the .NET runtime
20286 (JavaScript suffers of the same problem).
20288 * typemanager.cs (MemberLookup): When looking up members for
20289 interfaces, the parent of an interface is the implicit
20290 System.Object (so we succeed in searches of Object methods in an
20291 interface method invocation. Example: IEnumerable x; x.ToString
20294 2002-05-25 Miguel de Icaza <miguel@ximian.com>
20296 * class.cs (Event): Events should also register if they do
20297 implement the methods that an interface requires.
20299 * typemanager.cs (MemberLookup); use the new GetInterfaces
20302 (GetInterfaces): The code used to lookup interfaces for a type is
20303 used in more than one place, factor it here.
20305 * driver.cs: Track the errors at the bottom of the file, we kept
20308 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
20309 instance if the method we are calling is static!
20311 2002-05-24 Miguel de Icaza <miguel@ximian.com>
20313 * attribute.cs (ApplyAttributes): Make this function filter out
20314 the IndexerName attribute (as that attribute in reality is never
20315 applied) and return the string constant for the IndexerName
20318 * class.cs (TypeContainer.Emit): Validate that all the indexers
20319 have the same IndexerName attribute, and if so, set the
20320 DefaultName attribute on the class.
20322 * typemanager.cs: The return value might contain other stuff (not
20323 only methods). For instance, consider a method with an "Item"
20324 property and an Item method.
20326 * class.cs: If there is a problem with the parameter types,
20329 2002-05-24 Ravi Pratap <ravi@ximian.com>
20331 * ecore.cs (ImplicitConversionExists): Wrapper function which also
20332 looks at user defined conversion after making a call to
20333 StandardConversionExists - we need this for overload resolution.
20335 * expression.cs : Update accordingly the various method calls.
20337 This fixes 2 bugs filed against implicit user defined conversions
20339 2002-05-22 Miguel de Icaza <miguel@ximian.com>
20341 * statement.cs: Track the result of the assignment.
20343 2002-05-21 Miguel de Icaza <miguel@ximian.com>
20345 * expression.cs (MemberAccess): Improved error reporting for
20346 inaccessible members.
20348 2002-05-22 Martin Baulig <martin@gnome.org>
20350 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
20351 itself with debugging support.
20353 2002-05-22 Martin Baulig <martin@gnome.org>
20355 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
20356 Removed, this isn't needed anymore.
20358 2002-05-20 Martin Baulig <martin@gnome.org>
20360 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
20361 be underlying type for an enum.
20363 2002-05-20 Miguel de Icaza <miguel@ximian.com>
20365 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
20366 that splits out the loading of just the core types.
20368 * rootcontext.cs (ResolveCore): Split the struct resolution in
20369 two, so we can load the enumeration underlying types before any
20372 * expression.cs (Is): Bandaid until we fix properly Switch (see
20373 bug #24985 for details).
20375 * typemanager.cs (ImplementsInterface): The hashtable will contain
20376 a null if there are no interfaces implemented.
20378 2002-05-18 Miguel de Icaza <miguel@ximian.com>
20380 * cs-parser.jay (indexer_declarator): It is fine to have array
20383 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20385 * typemanager.cs: (RegisterBuilder): New function used to register
20386 TypeBuilders that implement interfaces. Since
20387 TypeBuilder.GetInterfaces (as usual) does not work with lame
20389 (AddUserType): register interfaces.
20391 (ImplementsInterface): Use the builder_to_ifaces hash if we are
20392 dealing with TypeBuilder. Also, arrays are showing up as
20393 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
20394 methods can not be invoked on them!
20396 * ecore.cs (ExplicitReferenceConversionExists): Made public.
20397 (ImplicitReferenceConversionExists): Split out from
20398 StandardConversionExists.
20400 * expression.cs (As): We were only implementing one of the three
20401 cases for the as operator. We now implement them all.
20402 (Is): Implement the various other cases for Is as well.
20404 * typemanager.cs (CACHE): New define used to control if we want or
20405 not the FindMembers cache. Seems to have a negative impact on
20406 performance currently
20408 (MemberLookup): Nested types have full acess to
20409 enclosing type members
20411 Remove code that coped with instance/static returns for events, we
20412 now catch this in RealFindMembers.
20414 (RealFindMembers): only perform static lookup if the instance
20415 lookup did not return a type or an event.
20417 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20419 * assign.cs (CompoundAssign): We pass more semantic information
20420 now to Compound Assignments than we did before: now we have all
20421 the information at hand, and now we resolve the target *before* we
20422 do the expression expansion, which allows the "CacheValue" method
20423 to have the effect we intended (before, a [x] += 1 would generate
20424 two differen ArrayAccess expressions from the ElementAccess,
20425 during the resolution process).
20427 (CompoundAssign.DoResolve): Resolve target and original_source here.
20429 2002-05-16 Miguel de Icaza <miguel@ximian.com>
20431 * expression.cs (ArrayAccess): dropped debugging information.
20433 * typemanager.cs: Small bug fix: I was always returning i_members,
20434 instead of one of i_members or s_members (depending on which had
20437 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
20438 method is invoked before any code generation takes place, and it
20439 is a mechanism to inform that the expression will be invoked more
20440 than once, and that the method should use temporary values to
20441 avoid having side effects
20443 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
20445 * ecore.cs (Expression.CacheTemporaries): Provide empty default
20448 * expression.cs (Indirection, ArrayAccess): Add support for
20449 CacheTemporaries in these two bad boys.
20451 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
20452 ldobj or ldind_ref.
20453 (StoreFromPtr): Handle stobj as well.
20455 * expression.cs (UnaryMutator): Share more code.
20457 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20458 down: I was not tracking the Filter function as well, which
20459 was affecting the results of the cache.
20461 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20463 * attribute.cs: Remove the hack to handle the CharSet property on
20466 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20468 * attribute.cs (DoResolve): More uglyness, we now only try to
20469 resolve the attribute partially, to extract the CharSet
20470 information (only if we are a StructLayout attribute). Otherwise
20472 (GetExtraTypeInfo): Add some code to conditionally kill in the
20473 future this. I am more and more convinced that the .NET
20474 framework has special code to handle the attribute setting on
20477 * expression.cs (IsParamsMethodApplicable): Revert my previous
20478 foreach change here, it was wrong.
20480 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20482 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20483 (pp_expr): do not abort on unknown input, just return.
20484 (eval): abort if there are pending chars.
20486 * attribute.cs (Attribute.Resolve): Positional parameters are
20487 optional. Deal with that case.
20489 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20490 the Ansi/Unicode/Auto information for the type.
20492 (TypeContainer.DefineType): instantiate the EmitContext here, as
20493 we will be using it during the type definition (to resolve
20494 attributes) and during the emit phase.
20496 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20497 to pull type information out of the attributes
20499 (Attribute.Resolve): track the constructor builder, and allow for
20500 multiple invocations (structs and classes will use this).
20502 * ecore.cs (MemberLookupFinal): new version with all the
20503 parameters customizable.
20505 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20506 constructors. Return if the result value is null (as the error
20507 would have been flagged already by MemberLookupFinal)
20509 Do not allow instances of abstract classes or interfaces to be
20512 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20513 We have to compare the assembly property here when dealing with
20514 FamANDAssem and Assembly access modifiers, because we might be
20515 creating an assembly from *modules* (that means that we are not
20516 getting TypeBuilders for types defined in other modules that are
20517 part of this assembly).
20519 (Method.Emit): If the method is marked abstract and has a body,
20522 (TypeContainer.DefineMembers): If both the defined member and the
20523 parent name match are methods, then do not emit any warnings: let
20524 the Method.Define routine take care of flagging warnings. But if
20525 there is a mismatch (method overrides something else, or method is
20526 overriwritten by something, then emit warning).
20528 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20529 set to null, this means `do not check for the return type on the
20532 (Method.Define): set the return type for the method signature to
20533 null, so that we get methods with the same name and parameters and
20534 different return types. This is used to flag warning 114 (you are
20535 hiding a method, and you probably want to use the new/override
20538 * typemanager.cs (MemberLookup): Implemented proper access
20539 control, closing a long standing set of bug reports. The problem
20540 was that the Framework only has two bits: Public and NonPublic,
20541 and NonPublic includes private and protected methods, but we need
20542 to enforce the FamANDAssem, FamOrAssem and Family.
20544 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20546 * statement.cs (GotoCase): Return true: Ammounts to giving up
20547 knowledge on whether we return or not, and letting the other case
20548 be responsible for it.
20550 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20552 * driver.cs: Do not load directories for each file processed, only
20553 do it if there is a pattern.
20555 * ecore.cs: Report readonly assigns here as well, as we might have
20556 been resolved only by MemberAccess.
20558 (SimpleName.SimpleNameResolve): Also be useful for LValue
20559 resolution. We need this to propagate assign to local readonly variables
20561 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20562 do not want to reuse potential criteria memory.
20564 * class.cs (MyEventBuilder): Set reflected_type;
20566 * ecore.cs (Constantify): Added support for constifying bools.
20568 (RootContext.LookupType): Added a cache for values looked up in
20569 the declaration space.
20571 * typemanager.cs (FindMembers): Now is a front-end to
20572 RealFindMembers, and provides a two-level hashtable-based cache to
20575 15% performance improvement: from 22.5 to 19.2 seconds.
20577 * expression.cs (IsParamsMethodApplicable): use foreach.
20578 (Invocation.DoResolve): ditto.
20579 (New.DoResolve): ditto.
20580 (ArrayCreation.DoResolve): ditto.
20582 * ecore.cs (FindMostEncompassingType): use foreach.
20584 * delegate.cs (NewDelegate.DoResolve): Use foreach
20586 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20587 (RemoveMethods): use foreach.
20589 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20590 nested foreach statements instead of for, and also break out of
20591 the inner loop once a match is found.
20593 (Invocation.OverloadResolve): Use foreach, simplify the code.
20595 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20597 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20598 we actually unwrap the expression to allow for extra information
20601 * expression.cs: Use Shr_Un on unsigned operations.
20603 2002-05-08 Ravi Pratap <ravi@ximian.com>
20605 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20606 applicable operators was not being considered correctly. This closes
20607 the bug Miguel reported.
20609 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20611 * attribute.cs: check that the type derives from System.Attribute
20612 and report the correct error in that case (moved the duplicate code to
20613 its own method, too).
20615 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20617 * attribute.cs: lookup attribute type name as the spec says: first the
20618 bare attribute name and then name + "Attribute" (nant compiles with
20619 mcs after this fix).
20621 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20623 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20624 Because of the way we parse things, we should try to see if a
20625 UIntConstant can fit in an integer.
20627 2002-05-07 Ravi Pratap <ravi@ximian.com>
20629 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20630 when we are in an explicit context.
20632 (ConvertReferenceExplicit): When converting from Iface type S to Class
20633 T make sure the rules are implemented as an OR.
20635 * parameter.cs (ParameterType): Make it a property for now although the
20636 purpose really isn't anything immediate.
20638 * expression.cs (Is*Applicable): Do better checking on the parameter type
20639 of a ref/out parameter. The ones from the system assemblies are already
20640 marked with the correct type so we don't need to do any correction.
20642 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20643 the object type is standard too so include that.
20645 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20647 * ecore.cs (StandardConversionExists): Augment with missing code:
20648 deal with IntConstant, LongConstants and Enumerations.
20650 * assign.cs: Report the error, instead of failing silently
20652 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20653 typecontainer that they are declared, because the
20654 typecontainer/namespace will have the list of using clauses that
20655 need to be applied.
20657 Assembly Attributes were escaping the normal registration
20660 (EmitCode): Apply attributes within an EmitContext that represents
20661 the container they were declared on.
20663 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20665 2002-05-06 Ravi Pratap <ravi@ximian.com>
20667 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20668 Revamp completely - make much cleaner as we now operate only
20671 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20672 to implement the logic detailed in the spec more correctly.
20674 (UserDefinedConversion): Update accordingly.
20676 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20678 * statement.cs: Return flow analysis information up.
20680 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20683 (token): Do not consume an extra character before calling
20686 2002-05-06 Piers Haken <piersh@friskit.com>
20688 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20690 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20692 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20693 EmitContext during the instance constructor initializer
20694 resolution, to stop access to instance variables.
20696 This is mandated by the spec, last paragraph of the `constructor
20697 initializers' section.
20699 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20701 * cs-parser.jay, class.cs (Accessor): new class used to represent
20702 an accessor (get or set). In the past we used `null' to represent
20703 a missing accessor. But this is ambiguous because there was no
20704 way to tell in abstract indexers/properties if one of them was
20707 Now there is a way of addressing that.
20709 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20710 instead of FindMembers.
20712 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20713 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20715 * attribute.cs: Treat indexers and properties as the same in terms
20716 of applying attributes
20718 * ecore.cs (FindMostEncompassedType): Use statically initialized
20719 EmptyExpressions()s like we do elsewhere to avoid creating useless
20720 objects (and we take this out of the tight loop).
20722 (GetConversionOperators): Move the code to extract the actual
20723 operators to a separate routine to clean things up.
20725 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20727 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20728 events are always registered FieldBuilders.
20730 * class.cs (FieldBase): New class shared by Fields
20732 * delegate.cs: If we are a toplevel delegate, use our full name.
20733 If we are a nested delegate, then only use our tail name.
20735 2002-05-02 Ravi Pratap <ravi@ximian.com>
20737 * expression.cs (IsApplicable): Ensure that we add the "&" to
20738 ref/out types before comparing it with the type of the argument.
20740 (IsParamsMethodApplicable): Ditto.
20742 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20745 * delegate.cs : Handle the case when we have more than one applicable
20746 method. Flag an error only when we finish checking all.
20748 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20750 * expression.cs: Add support for boolean static initializers.
20752 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20754 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20756 * parameter.cs (ComputeParameterTypes,
20757 ComputeAndDefineParameterTypes): Better error handling: now we
20758 clear the `types' cache if we fail during any of the type lookups.
20759 We also return the status code correctly to our caller
20761 * delegate.cs: If we fail to define a delegate, abort the extra
20764 * expression.cs (Binary.ResolveOperator): for
20765 operator==(object,object) and operator !=(object, object) we also
20766 have to verify that there is an implicit conversion from one to
20769 (ArrayAccess.DoResolve): Array Access can operate on
20772 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20774 * assign.cs (CompoundAssign): A new class used as a "flag" that
20775 the assignment actually is happening as part of a compound
20776 assignment operator.
20778 During compound assignment, a few new rules exist to enable things
20785 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20786 to the type of x) if y is implicitly convertible to the type of x,
20787 and the operator is a builtin operator and the return type of the
20788 operator is explicitly convertible to the type of x.
20790 * rootcontext.cs: Reset warning level to 2. 4 catches various
20791 "interesting" features in mcs, we must clean this up at some
20792 point, but currently am trying to kill other bugs ;-)
20794 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20795 in container classes as well.
20797 * expression.cs (Binary.ResolveOperator): Handle string case
20798 before anything else (as operator overloading does emit an error
20799 before doing anything else).
20801 This code could go away when we move to a table driven model, but
20802 i could not come up with a good plan last night.
20804 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20806 * typemanager.cs (CSharpName): reimplementation using regex.
20807 * class.cs: added null check for fields in Emit
20808 * rootcontext.cs: set warninglevel to 4
20810 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20812 * typemanager.cs (CSharpName): reimplemented with Lupus
20815 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20817 * statement.cs (If): correclty implement Resolve, because we were
20818 not catching sem errors in there. The same process is needed
20820 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20823 (Statement.Warning_DeadCodeFound): Factorize code.
20824 (While): Report dead code here too.
20826 (Statement): Added Resolve virtual method to allow
20827 for resolution split from the emit code.
20829 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20831 * statement.cs (EmitBoolExpression): No longer try to resolve the
20833 (MakeBoolean): New utility function that resolve, implicitly
20834 converts to boolean and tags the expression.
20837 (If, Do): Implement dead code elimination.
20838 (While): Implement loop inversion
20840 (Do, While, For, If): Resolve the expression prior to calling our
20843 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20846 - added method Report28 (warning: program has more than one entry point)
20847 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20848 - modified method Method.Define, the part at the end of the method
20850 * rootcontext.cs: added static public Location EntryPointLocation;
20852 * ../errors/cs0028.cs : Add test case for the above warning.
20855 - modified method CSharpName to allow arrays of primitive type to
20856 be printed nicely (e.g. instead of System.Int32[][] it now prints
20858 - added method CSharpSignature: returns the signature of a method
20859 in string format to be used in reporting errors, warnings, etc.
20861 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20864 2002-04-26 Ravi Pratap <ravi@ximian.com>
20866 * delegate.cs (Define): Fix extremely silly bug where I was
20867 setting the type of the 'object' parameter of the BeginInvoke
20868 method to System.IAsyncResult instead of System.Object ;-)
20870 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20872 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20875 (Constructor.Emit): return if we fail to initialize the
20876 constructor. Another door closed!
20878 * expression.cs (New.DoResolve): Improve error message (from -6 to
20879 1501). Use DeclaredOnly lookup to find the exact constructor.
20881 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20882 loop. This is useful.
20884 * cs-parser.jay: Adjust the default parameters so that destructors
20885 have the proper signature.
20887 2002-04-26 Martin Baulig <martin@gnome.org>
20889 * driver.cs (LoadAssembly): If `assembly' contains any characters
20890 which are only valid in path names and not in assembly names
20891 (currently slash, backslash and point), use Assembly.LoadFrom ()
20892 instead of Assembly.Load () on the `assembly' (before iteration
20893 over the link_paths).
20895 2002-04-26 Martin Baulig <martin@gnome.org>
20897 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20899 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20901 * class.cs (Property): use the new typemanager.MemberLookup
20903 (TypeContainer.MemberLookup): Implement using the
20904 TypeManager.MemberLookup now.
20906 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20907 and return MemberInfos, so that these can be used without an
20908 EmitContext (what we had before).
20910 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20912 * expression.cs: Fix the case where the argument to params if the
20913 type of the params. I omitted handling this before. Fixed
20915 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20917 * driver.cs: Call BootCorlib_PopulateCoreType
20919 * class.cs (Property.CheckBase): Check for properties only, not
20922 * interface.cs: Temporary hack: try/catch around the
20923 CustomAttributeBuilder, because I am getting an exception that I
20926 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20927 types whose definitions are required to be there (attributes are
20928 defined before standard types).
20930 Compute definitions as we boot the various types, as they are used
20931 immediately (value_type class will need object_type, but if we do
20932 not initialize object_type, we will pass a null, which will let
20933 the runtime pick the System.Object from the existing corlib, which
20934 is not what we want).
20936 2002-04-22 Patrik Torstensson <totte@labs2.com>
20938 * cs-tokenizer.cs: fixed a number of trim() issues.
20940 2002-04-22 Ravi Pratap <ravi@ximian.com>
20942 * expression.cs (Argument.Type): Ensure that we return the correct
20943 type when we have out or ref parameters [in which case we
20946 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20948 * class.cs (Property, Indexer): Allow extern modifier in there.
20950 * typemanager.cs (InitBaseTypes): Initializes object_type and
20951 value_type, since those will be used early on during the bootstrap
20952 process to compile corlib.
20954 (InitCoreTypes): Move code from here to InitBaseTypes.
20956 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20958 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20959 single-dimension arrays as using the ldlen opcode.
20961 Daniel Lewis discovered this optimization.
20963 * typemanager.cs: Add signature for System.Array::get_Length
20965 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20967 * statement.cs: report the error when the foreach does not apply to an
20968 array nor a collection.
20970 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20972 * expression.cs: Add implicit conversions to the operator ~.
20974 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20976 * typemanager.cs: Locate the decimal constructor.
20978 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20980 * attribute.cs: use the new property of TypeOf.
20981 * expression.cs: added 'get' property around typearg.
20983 These changes fix a build breaker reported by NickD. Is this the
20984 correct way to fix? If not, please, revert my changes and make it
20987 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20989 * attribute.cs: Add support for typeof in attribute invocations.
20990 I am not sure that this is right though.
20992 2002-04-14 Duncan Mak <duncan@ximian.com>
20994 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20995 Binary.Operator.Division case.
20997 2002-04-13 Ravi Pratap <ravi@ximian.com>
20999 * class.cs (DefineType): Ensure that we do a proper check on
21000 attribute types and also register it with the TypeManager.
21002 (TypeContainer.Targets): The default for attribute types is
21003 AttributeTargets.All.
21005 * attribute.cs (ApplyAttributes): Registering the attribute type
21006 is done elsewhere, not when we discover we have a Usage attribute.
21008 2002-04-12 Ravi Pratap <ravi@ximian.com>
21010 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
21011 and get rid of is_delegate parameter.
21013 * everywhere : update.
21015 2002-04-12 Ravi Pratap <ravi@ximian.com>
21017 * cs-parser.jay (compilation_unit): Revamp completely to use
21018 some new ideas that I got from Rhys' grammar to solve the problems
21019 with assembly level attributes.
21021 (outer_declaration): New grammar production.
21023 (attribute_sections): Add.
21025 (opt_attributes): Base on attribute_sections
21027 (namespace_declaration): Allow opt_attributes to tackle the case
21028 when we have assembly level attributes - we are clever in this
21031 * attribute.cs (ApplyAttributes): Do not worry about assembly
21032 attributes in the non-global context.
21034 * rootcontext.cs (AddGlobalAttributes): Go back to using this
21035 instead of SetGlobalAttributes.
21037 * class.cs, rootcontext.cs : Ensure we define and generate
21038 attribute types before anything else.
21040 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
21041 and flag the new error -20 for the case when the attribute type
21042 does not have valid targets specified. csc does not catch this.
21044 * ../errors/errors.txt : update for error # -20
21046 2002-04-11 Ravi Pratap <ravi@ximian.com>
21048 * support.cs (InternalParameters.ParameterModifier): Do some null
21049 checking and return sane values.
21051 * class.cs (Method.Define): If we are a PInvoke method, ensure
21052 that we are static and extern. Report error # 601
21054 * ../errors/cs0601.cs : Add test case for the above error.
21056 2002-04-07 Ravi Pratap <ravi@ximian.com>
21058 * rootcontext.cs (attribute_types): We need to keep type of
21059 all attribute types separately and emit code for them first.
21061 (RegisterAttribute) : Implement.
21063 * class.cs (DefineType): Check if the current Type is a custom
21064 attribute type and register it accordingly.
21066 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
21067 adding the first attribute twice and rename to
21069 (SetGlobalAttributes): this.
21071 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
21074 * attribute.cs (ApplyAttributes): Take an additional argument telling us
21075 if we are processing global arguments. Hmm, I am unsure of this.
21077 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21079 * expression.cs: added static array of strings to avoid calling
21080 Enum.ToString () for Operator in Binary. Significant recover of
21083 2002-04-10 Miguel de Icaza <miguel@ximian.com>
21085 * class.cs (FindMembers): Allow the Builders of the various
21086 members to be null. If they are skip them. This only happens
21087 during the PInvoke declaration.
21089 2002-04-09 Miguel de Icaza <miguel@ximian.com>
21091 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
21092 failure, so we do not keep going afterwards.
21094 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
21095 wanted to pass `false' as the `is_delegate' argument. If this is
21096 the case, why not use delegate_type == null to mean `is_delegate =
21097 false' and anything else as is_delegate = true.
21099 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
21101 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
21102 code for the section, not the beginning of the tests.
21104 2002-04-08 Miguel de Icaza <miguel@ximian.com>
21106 * cfold.cs: Handle operator + (Enum x, Underlying x)
21108 * expression.cs (Binary): same. Warn about errors where we have
21109 Enum/Enum in operator + as well.
21111 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
21114 - added support for switch(bool)
21115 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
21116 - add TableSwitchEmit() to handle table-based switch statements
21118 2002-04-05 Ravi Pratap <ravi@ximian.com>
21120 * expression.cs (Invocation.OverloadResolve): Factor out code which
21121 does parameter compatibility checking with arguments so that we can
21122 re-use the code even from Delegate.VerifyApplicability
21124 (VerifyArgumentsCompat): Move above code here.
21126 * delegate.cs (VerifyApplicability): Get rid of duplicate code
21127 and instead make a call to the above method.
21129 2002-03-31 Ravi Pratap <ravi@ximian.com>
21131 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
21132 We use it to keep track of classes which are attribute types.
21134 2002-04-02 Miguel de Icaza <miguel@ximian.com>
21136 * delegate.cs (Delegate.Define): Correctly define the types in the
21137 presence of fixed and array parameters.
21139 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
21142 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
21143 include NonPublic after the first iteration.
21145 * class.cs (Indexer.CheckBase): Only check if both parents are
21148 * cs-parser.jay (accessor_body): If empty, set to null.
21150 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
21151 same code path here to resolve constants names that we did have in
21152 MemberAccess.DoResolve. There is too much code duplicated here.
21154 2002-04-01 Miguel de Icaza <miguel@ximian.com>
21156 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
21158 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
21161 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
21162 tokens, numbers and strings.
21164 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
21167 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
21168 asyncronous parameters and the regular parameters.
21170 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
21171 specify the target directory.
21173 * expression.cs: (This.DoResolve): Simplify
21174 (As.Emit): Optimize, do not generate IsInst if the expression is
21175 always of the given type.
21177 (Is.DoResolve): Bug fix, we were reporting both always/never for
21180 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
21181 creating too many unnecessary arrays.
21183 2002-03-31 Miguel de Icaza <miguel@ximian.com>
21185 * class.cs (EmitFieldInitializer): Use Assign expression to assign
21186 fields instead of rolling our own initializer. Takes care of all
21187 implicit conversions, and drops unnecessary static checks/argument.
21189 2002-03-31 Dick Porter <dick@ximian.com>
21191 * driver.cs: use the GetDirectories() return values properly, and
21192 use "/" as path separator.
21194 2002-03-30 Miguel de Icaza <miguel@ximian.com>
21196 * expression.cs (Unary): Optimize - - expr into expr.
21197 (Binary): Optimize a + (-b) into a -b.
21199 * codegen.cs (CodeGen): Made all methods static.
21201 2002-03-29 Miguel de Icaza <miguel@ximian.com>
21205 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
21206 TypeBuilder property.
21208 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
21211 * tree.cs: Removed the various RecordXXXX, and replaced with a
21212 single RecordDecl. Removed all the accessor methods, and just
21213 left a single access point Type
21215 * enum.cs: Rename DefineEnum to DefineType.
21217 * decl.cs: New abstract method `DefineType' used to unify the
21218 Defines for Enumerations, Interfaces, TypeContainers and
21221 (FindType): Moved LookupInterfaceOrClass here. Moved the
21222 LookupBaseClasses method that used to live in class.cs and
21223 interface.cs here, and renamed to FindType.
21225 * delegate.cs: Implement DefineType. Take advantage of the
21226 refactored pattern for locating the parent builder without taking
21227 the parent_builder argument (which we know does not work if we are
21228 nested, and triggering a toplevel definition).
21230 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21232 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21233 accessibility of a member has changed during override and report
21236 * class.cs (Method.Define, Property.Define): Only complain on
21237 overrides if the method is private, any other accessibility is
21238 fine (and since we just checked the permission is the same, we are
21241 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
21242 and elif are processed always. The other pre-processing
21243 directives are only processed if we are "taking" the path
21245 2002-03-29 Martin Baulig <martin@gnome.org>
21247 * class.cs (Method.Emit): Only emit symbolic debugging info if the
21248 current location is not Null.
21250 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
21251 a separate method so we can profile it.
21253 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
21254 `span.Seconds' are just seconds, but no minutes or hours.
21255 (MainDriver): Profile the CodeGen.SaveSymbols calls.
21257 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21259 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
21260 Remove the gratuitous set of Final:
21262 // If an interface implementation, then we can set Final.
21263 if (((flags & MethodAttributes.Abstract) == 0) &&
21264 implementing.DeclaringType.IsInterface)
21265 flags |= MethodAttributes.Final;
21267 I do not know what I was smoking when I used that.
21270 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
21271 step into fixing the name resolution issues for delegates and
21272 unifying the toplevel name resolution.
21274 2002-03-28 Martin Baulig <martin@gnome.org>
21276 * class.cs (Method.Emit): If we have a symbol writer, call its
21277 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
21278 tell it about the current method.
21280 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
21281 writer that we're going to emit the first byte of IL code for a new
21282 statement (a new source line).
21283 (EmitContext.EmitTopBlock): If we have a symbol writer, call
21284 EmitContext.Mark() before emitting any code.
21286 * location.cs (SymbolDocument): Return null when we're Null.
21288 * statement.cs (Statement): Moved the `Location loc' variable here.
21289 (Statement.EmitBoolExpression): If we have a symbol writer, call
21290 ec.Mark() before emitting any code to tell it that we're at the
21291 beginning of a new statement.
21292 (StatementExpression): Added `Location' argument to the constructor.
21293 (Block): Added public readonly variable `StartLocation' and public
21294 variable `EndLocation'. The latter is to be set using SetEndLocation().
21295 (Block): Added constructor which takes a start and end location.
21296 (Block.SetEndLocation): New method. This sets the end location.
21297 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
21298 local variables we create.
21299 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
21300 each statement and do also mark the begin and end of the block.
21302 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21303 tell it the current lexer.Location, use Location.Null for the end of the
21305 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
21306 current block, set its end location using SetEndLocation().
21307 (statement_expression): StatementExpression constructor now takes the
21308 lexer.Location as additional argument.
21309 (for_statement, declare_local_variables): Likewise.
21310 (declare_local_variables): When creating a new implicit block, use the
21311 new Block constructor and pass it the lexer.Location.
21313 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21315 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
21316 members also on the parent interfaces recursively.
21318 2002-03-27 Miguel de Icaza <miguel@ximian.com>
21320 * report.cs: Use new formats, since Gonzalo finished the missing
21323 * expression.cs (Binary.ResolveOperator): added missing operator|
21324 operator& and operator^ for bool/bool.
21326 * cs-parser.jay: CheckDef now takes a Location argument that is
21327 used to report errors more precisly (instead of reporting the end
21328 of a definition, we try to track something which is a lot closer
21329 to the source of the problem).
21331 * cs-tokenizer.cs: Track global token use, so we can properly flag
21332 the use of #define/#undef after the first token has been seen.
21334 Also, rename the reportXXXX to Error_DescriptiveName
21336 * decl.cs (DeclSpace.IsTopLevel): Move property here from
21337 TypeContainer, so that Enum and Interface can use this too.
21339 * class.cs (TypeContainer.LookupInterfaceOrClass,
21340 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
21341 `builder' argument. Typically this was used to pass the parent
21342 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
21345 The problem is that a nested class could trigger the definition of
21346 a toplevel class, and the builder would be obviously wrong in that
21349 So we drop this argument, and we compute dynamically the
21350 TypeBuilder/ModuleBuilder (the correct information was available
21351 to us anyways from DeclSpace.Parent)
21353 * interface.cs (Interface.DefineInterface): Drop builder
21354 parameter cleanup like class.cs
21356 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
21359 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
21362 (Try.Emit): Propagate the returns value from the statement.
21364 (Return.Emit): Even if we are leavning
21366 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
21368 * modifiers.cs: Fix the computation of MethodAttributes flags.
21370 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
21372 * driver.cs: allow compilation of files that start with '/'.
21373 Add a default case when checking the argument of --target.
21375 2002-03-25 Miguel de Icaza <miguel@ximian.com>
21377 * interface.cs: Implement the same search algorithm for types in
21378 the interface code.
21380 * delegate.cs: Do not allow multiple definition.
21382 * Recovered ChangeLog that got accidentally amputated
21384 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
21386 * rootcontext.cs: Load manually enum to allow core classes to
21387 contain enumerations.
21389 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
21390 Update to new static methods in TypeManager.
21392 * typemanager.cs (GetMethod, GetConstructor): Use our
21393 implementation of FindMembers to find the members, since during
21394 corlib compilation, the types are TypeBuilders and GetMethod and
21395 GetConstructor do not work.
21397 Make all methods in TypeManager static.
21399 (InitCodeHelpers): Split the functionality from
21400 the InitCodeTypes function.
21402 * driver.cs: Call InitCodeHelpers after we have populated the
21405 * cs-parser.jay (delegate_declaration): we did not used to compute
21406 the delegate name correctly for void delegates.
21408 2002-03-24 Miguel de Icaza <miguel@ximian.com>
21410 * rootcontext.cs (RootContext): Init the interface_resolve_order
21411 and type_container_resolve_order always.
21413 (ResolveCore, BootstrapCorlib_ResolveClass,
21414 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
21415 compiler when compiling with --nostdlib
21417 * class.cs (TypeContainer.DefineType): Check that our parent is
21418 not null. This test is most important when we are bootstraping
21421 * codegen.cs: Split out the symbol writing code.
21423 2002-03-25 Martin Baulig <martin@gnome.org>
21425 * driver.cs (-g): Made -g an alias for --debug.
21427 2002-03-24 Martin Baulig <martin@gnome.org>
21429 * codegen.cs (SymbolWriter): New public variable. Returns the
21430 current symbol writer.
21431 (CodeGen): Added `bool want_debugging_support' argument to the
21432 constructor. If true, tell the ModuleBuild that we want debugging
21433 support and ask it for the ISymbolWriter.
21434 (Save): If we have a symbol writer, call it's Close() method after
21435 saving the assembly.
21437 * driver.c (--debug): New command line argument to create a
21438 debugger information file.
21440 * location.cs (SymbolDocument): New public property. Returns an
21441 ISymbolDocumentWriter object for the current source file or null
21442 if we don't have a symbol writer.
21444 2002-03-21 Miguel de Icaza <miguel@ximian.com>
21446 * driver.cs (LoadAssembly): Correctly return when all the paths
21447 have been tried and not before.
21449 * statement.cs (Switch.Emit): return the actual coverage for this
21450 statement (returns/not-returns)
21452 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
21453 switch of the statement if we are the last switch section. That
21454 kills two problems: try/catch problems (we used to emit an empty
21455 nop at the end) and switch statements where all branches would
21458 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21460 * driver.cs: Add default assemblies (the equivalent to the
21461 Microsoft CSC.RSP file)
21463 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21464 also update tokens_seen and set it to false.
21466 * driver.cs: Implement --recurse for Mike.
21468 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21469 correctly splitting out the paths.
21471 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21473 * interface.cs (Interface.PopulateProperty): Instead of using
21474 `parent' as the declaration space for the set parameters, use
21477 * support.cs (InternalParameters): InternalParameters constructor
21478 takes a DeclSpace instead of a TypeContainer.
21480 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21481 types are being initialized, load the address of it before calling
21484 (New): Provide a mechanism to disable the generation of local
21485 value type temporaries when the caller will be providing us with
21486 an address to store it.
21488 (ArrayCreation.EmitDynamicInitializers): Use it.
21490 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21492 * expression.cs (Invocation.EmitArguments): Only probe for array
21493 property if there is more than one argument. Sorry about that.
21495 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21496 empty param arrays.
21498 * class.cs (Method.LabelParameters): Fix incorrect code path that
21499 prevented the `ParamArrayAttribute' from being applied to the
21502 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21504 * support.cs (ReflectionParameters): Correctly compute whether the
21505 last argument is a params array. Fixes the problem with
21508 * typemanager.cs: Make the assemblies array always be non-null
21509 (empty, but non-null)
21511 * tree.cs (RecordDecl): New function that abstracts the recording
21512 of names. This reports error 101, and provides a pointer to the
21513 previous declaration. Fixes a crash in the compiler.
21515 * cs-parser.jay (constructor_declaration): Update to new grammar,
21516 and provide a constructor_body that can be empty.
21518 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21520 * driver.cs: Add support for --resources.
21522 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21523 Make all types for the various array helper methods be integer.
21525 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21526 CheckState to ConvCast.
21528 (ConvCast): Now it takes a `checked' state argument, to avoid
21529 depending on the emit context for the conversion, and just using
21530 the resolve time setting.
21532 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21533 instead of Invocation.EmitArguments. We do not emit the original
21534 arguments, instead we emit those which have been converted to
21535 unsigned int expressions.
21537 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21539 * codegen.cs: ditto.
21541 * expression.cs (LocalVariableReference): Drop the use of the
21542 Store function that depended on the variable index.
21544 * statement.cs (VariableInfo): Drop the `Idx' property from this
21545 class, as this is not taking into account the indexes for
21546 temporaries tat we generate during the execution, getting the
21549 * class.cs: First emit class initializers, then call the parent
21552 * expression.cs (Binary): Fix opcode emision.
21553 (UnaryMutator.EmitCode): Support checked code generation
21555 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21556 matches for events for both the Static and Instance scans,
21557 pointing to the same element. Fix that.
21559 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21561 * rootcontext.cs (ResolveTree): Always set the
21562 interface_resolve_order, because nested interfaces will be calling
21565 * class.cs (GetInterfaceOrClass): Track the same resolution
21566 process used by TypeManager.LookupType. This fixes the nested
21567 type lookups in class declarations (separate path from
21570 (TypeContainer.DefineType): Also define nested interfaces.
21571 (TypeContainer.RegisterOrder): New public function used to
21572 register the order in which child interfaces need to be closed.
21574 Nested interfaces need to be closed after their parents have been
21577 * interface.cs (InterfaceAttr): Put all the logic for computing
21578 the interface attribute here.
21580 (DefineInterface): Register our interface order with the
21581 RootContext or with the TypeContainer depending on the case.
21583 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21585 * cs-parser.jay: rework foreach statement to work with the new
21586 changes to the policy on SimpleNames.
21588 * report.cs: support Stacktrace on warnings as well.
21590 * makefile: drop --unsafe and /unsafe from the compile.
21592 2002-03-13 Ravi Pratap <ravi@ximian.com>
21594 * ecore.cs (StandardConversionExists): Modify to take an Expression
21595 as the first parameter. Ensure we do null -> reference type conversion
21598 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21599 temporary Expression objects.
21601 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21603 * interface.cs: workaround bug in method overloading resolution
21604 (there is already a bugzilla bug for it).
21606 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21608 We could also solve this problem by having a separate path for
21609 performing type lookups, instead of DoResolve, we could have a
21610 ResolveType entry point, and only participating pieces of the
21611 production (simplename, deref, array) would implement this.
21613 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21614 signal SimpleName to only resolve type names and not attempt to
21615 resolve anything else.
21617 * expression.cs (Cast): Set the flag.
21619 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21621 * class.cs: Only report 108 if there is no `new' modifier.
21623 * cs-parser.jay: rework foreach statement to work with the new
21624 changes to the policy on SimpleNames.
21626 * report.cs: support Stacktrace on warnings as well.
21628 * makefile: drop --unsafe and /unsafe from the compile.
21630 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21632 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21633 lookups here, instead of doing that at parse time. This means
21634 that our grammar will not introduce `LocalVariableReferences' as
21635 expressions at this point. That solves the problem of code like
21639 static void Main ()
21643 This is only half the fix. The full fix requires parameters to
21644 also be handled in this way.
21646 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21647 makes the use more obvious of the DeclSpace. The
21648 ec.TypeContainer.TypeBuilder is now only used to pull the
21649 TypeBuilder for it.
21651 My theory is that I can get rid of the TypeBuilder completely from
21652 the EmitContext, and have typecasts where it is used (from
21653 DeclSpace to where it matters).
21655 The only pending problem is that the code that implements Aliases
21656 is on TypeContainer, and probably should go in DeclSpace.
21658 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21659 lookups here, instead of doing that at parse time. This means
21660 that our grammar will not introduce `LocalVariableReferences' as
21661 expressions at this point. That solves the problem of code like
21665 static void Main ()
21669 This is only half the fix. The full fix requires parameters to
21670 also be handled in this way.
21672 * class.cs (Property.DefineMethod): When implementing an interface
21673 method, set newslot, when implementing an abstract method, do not
21674 set the flag (before we tried never setting it, or always setting
21675 it, which is the difference).
21676 (Indexer.DefineMethod): same.
21677 (Method.DefineMethod): same.
21679 * ecore.cs: Only set the status used flag if we get back a Field.
21681 * attribute.cs: Temporary hack, so Paolo can keep working.
21683 2002-03-08 Ravi Pratap <ravi@ximian.com>
21685 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21686 the unmanaged type in the case we have a MarshalAs attribute.
21688 (Resolve): Handle the case when we are parsing the special MarshalAs
21689 attribute [we need to store the unmanaged type to use later]
21691 * typemanager.cs (marshal_as_attr_type): Built in type for the
21692 MarshalAs Attribute.
21694 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21695 on parameters and accordingly set the marshalling info.
21697 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21699 * class.cs: Optimizing slightly by removing redundant code after
21700 we switched to the `NoTypes' return value.
21701 (Property.DefineMethod): use NoTypes here too.
21703 This fixes the bug I introduced in my last batch of changes.
21705 2002-03-05 Ravi Pratap <ravi@ximian.com>
21707 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21709 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21710 Enums since those are types too.
21712 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21714 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21715 thanks to a call during the lookup process.
21717 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21719 * statement.cs (Foreach): Lots of work to accomodate a particular
21720 kind of foreach statement that I had not kept in mind. It is
21721 possible to have foreachs on classes that provide a GetEnumerator
21722 method that return objects that implement the "pattern" for using
21723 a foreach, there is no need to support GetEnumerator
21726 This is needed to compile nant.
21728 * decl.cs: Only report 114 if the member is not `Finalize' and if
21729 the warning level is at least 2.
21731 * class.cs: Moved the compare function from Method to
21734 (MethodSignature.InheritableMemberSignatureCompare): Add new
21735 filter function that is used to extract inheritable methods from a
21738 (Method.Define): Use the new `inheritable_method_signature_filter'
21741 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21744 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21746 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21748 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21750 * expression.cs: Pass location information to
21751 ConvertImplicitStandard.
21753 * class.cs: Added debugging code to track return values from
21756 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21758 * expression.cs (Is.DoResolve): If either side of the `is' is an
21759 interface, do not flag the warning.
21761 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21764 * report.cs: Allow for --fatal to be used with --probe.
21766 * typemanager.cs (NoTypes): Move the definition for the empty Type
21769 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21771 (TypeContainer.DefineProxy): New function used to proxy to parent
21772 implementations when implementing interfaces.
21773 (TypeContainer.ParentImplements): used to lookup if our parent
21774 implements a public function that is required by an interface.
21775 (TypeContainer.VerifyPendingMethods): Hook this up.
21777 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21778 `modules' and `assemblies' arraylists into arrays. We only grow
21779 these are the very early start up of the program, so this improves
21780 the speedof LookupType (nicely measured).
21782 * expression.cs (MakeByteBlob): Replaced unsafe code with
21783 BitConverter, as suggested by Paolo.
21785 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21786 folding of string concatenation, but if either side is a string,
21787 and the other is not, then return null, and let the runtime use
21788 the concatenation on the string plus the object (using
21789 `Object.ToString').
21791 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21793 Constant Folding has been implemented now.
21795 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21796 the error instead on types that are not supported in one's
21799 * constant.cs (Constant and all children): New set of functions to
21800 perform implict and explicit conversions.
21802 * ecore.cs (EnumConstant): Implement the new functions to perform
21803 conversion by proxying to the child expression.
21805 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21806 own separate setting that can not be turned off from the command
21807 line using --unchecked or --checked and is only controlled using
21808 the checked/unchecked statements and expressions. This setting is
21809 used by the constant folder to flag errors.
21811 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21812 ConstantCheckState as well.
21814 During Resolve, they also have to flag the state, because the
21815 constant folder runs completely in the Resolve phase.
21817 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21820 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21822 * cfold.cs: New file, this file contains the constant folder.
21824 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21825 argument to track whether we are using the resulting address to
21826 load or store a value and provide better error messages.
21828 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21829 new AddressOf arguments.
21831 * statement.cs (Foreach.EmitCollectionForeach): Update
21833 * expression.cs (Argument.Emit): Call AddressOf with proper
21834 arguments to track usage.
21836 (New.DoEmit): Call AddressOf with new arguments.
21838 (Unary.Emit): Adjust AddressOf call.
21840 2002-03-01 Ravi Pratap <ravi@ximian.com>
21842 * cs-parser.jay (member_access): Change the case for pre-defined types
21843 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21846 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21849 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21850 essentially like methods and apply attributes like MethodImplOptions to them too.
21852 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21855 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21856 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21859 * Update code everywhere accordingly.
21861 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21863 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21865 2002-02-28 Ravi Pratap <ravi@ximian.com>
21867 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21868 try performing lookups against those instead of jumping straight into using
21869 the 'using' clauses.
21871 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21873 (LookupType): Perform lookups in implicit parents too.
21875 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21876 sequence as RootContext.LookupType.
21878 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21879 the various cases of namespace lookups into this method.
21881 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21883 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21884 in positional arguments)
21886 * class.cs (Operator): Update the AllowedModifiers to contain
21889 * cs-parser.jay: Update operator declaration to allow for the
21890 operator body to be empty.
21892 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21895 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21897 * class.cs (Method.Emit): Label parameters.
21899 * driver.cs: Return 1 or 0 as the program exit code.
21901 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21903 * expression.cs: Special case the `null' object when trying to
21904 auto-compute the type, as anything can be explicitly converted to
21907 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21908 spotting this Paolo.
21910 (Expression.ImplicitNumericConversion): Perform comparissions of
21911 the type using the underlying type in the case of an enumeration
21912 rather than using the enumeration type for the compare.
21914 Cope with the underlying == type case, which is not possible to
21917 (Expression.ConvertNumericExplicit): Perform comparissions of
21918 the type using the underlying type in the case of an enumeration
21919 rather than using the enumeration type for the compare.
21921 * driver.cs: If the user does not supply an extension, assume .exe
21923 * cs-parser.jay (if_statement): Rewrote so that we can track the
21924 location for the if statement.
21926 * expression.cs (Binary.ConstantFold): Only concat strings when
21927 the operation is "+", not everything ;-)
21929 * statement.cs (Statement.EmitBoolExpression): Take a location
21931 (If, While, Do): Track location.
21933 * expression.cs (Binary.ResolveOperator): In the object + string
21934 case, I was missing a call to ConvertImplicit
21936 2002-02-25 Ravi Pratap <ravi@ximian.com>
21938 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21939 Location arguments. Ensure we use RootContext.LookupType to do our work
21940 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21942 * interface.cs (PopulateMethod): Handle the type of the parameter being
21945 * expression.cs (Invocation.BetterFunction): Handle the case when we
21946 have a params method with no fixed arguments and a call is made with no
21949 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21951 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21952 the verbatim-string-literal
21954 * support.cs (InternalParameters.ParameterModifier): handle null
21956 (InternalParameters.ParameterType): ditto.
21958 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21959 duplicating the name of the variable parameter.
21960 (GetParameterByName): Fix bug where we were not looking up array
21961 paramters if they were the only present (thanks Paolo!).
21962 (GetParameterInfo): We only have an empty set of types if both
21963 fixed and array are set to null.
21964 (GetParameterInfo-idx): Handle FixedParameter == null
21966 * cs-parser.jay: Handle the case where there is no catch
21967 statements (missing null test).
21969 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21971 * driver.cs (MainDriver): Be conservative on our command line
21974 Catch DirectoryNotFoundException when calling GetFiles.
21976 (SplitPathAndPattern): Used to split the input specification into
21977 a path and a pattern that we can feed to Directory.GetFiles.
21979 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21981 * statement.cs (Fixed): Implement the last case of the Fixed
21982 statement (string handling).
21984 * expression.cs (StringPtr): New class used to return a char * to
21985 a string; Used by the Fixed statement.
21987 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21989 * expression.cs (Binary.ResolveOperator): Remove redundant
21990 MemberLookup pn parent type.
21991 Optimize union call, we do not need a union if the types are the same.
21992 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21995 Specialize the use of MemberLookup everywhere, instead of using
21996 the default settings.
21998 (StackAlloc): Implement stackalloc keyword.
22000 * cs-parser.jay: Add rule to parse stackalloc.
22002 * driver.cs: Handle /h, /help, /?
22004 * expression.cs (MakeByteBlob): Removed the hacks we had in place
22005 before we supported unsafe code.
22007 * makefile: add --unsafe to the self compilation of mcs.
22009 2002-02-20 Miguel de Icaza <miguel@ximian.com>
22011 * expression.cs (PointerArithmetic): New class that is used to
22012 perform pointer arithmetic.
22013 (Binary.Resolve): Handle pointer arithmetic
22014 Handle pointer comparission.
22015 (ArrayPtr): Utility expression class that is used to take the
22016 address of an array.
22018 (ElementAccess): Implement array access for pointers
22020 * statement.cs (Fixed): Implement fixed statement for arrays, we
22021 are missing one more case before we are done.
22023 * expression.cs (Indirection): Implement EmitAssign and set the
22024 ExprClass to Variable. This allows pointer dereferences to be
22025 treated as variables, and to have values assigned to them.
22027 * ecore.cs (Expression.StoreFromPtr): New utility function to
22028 store values dereferencing.
22030 2002-02-20 Ravi Pratap <ravi@ximian.com>
22032 * expression.cs (Binary.ResolveOperator): Ensure that we are
22033 not trying to operate on a void type - this fixes the reported
22036 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
22037 the parent implementation is sealed.
22039 * ../errors/cs0239.cs : Add.
22041 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
22043 * typemanager.cs (unverifiable_code_type): Corresponds to
22044 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
22045 which have unsafe code in them.
22047 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
22050 2002-02-19 Miguel de Icaza <miguel@ximian.com>
22052 * cs-tokenizer.cs: Add support for @"litreal strings"
22054 Make tokenizer accept pre-processor directives
22055 on any column (remove the old C-like limitation).
22057 * rootcontext.cs (EmitCode): Emit any global attributes.
22058 (AddGlobalAttributes): Used to keep track of assembly attributes.
22060 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
22062 * cs-parser.jay: Add support for global attributes.
22064 2002-02-17 Miguel de Icaza <miguel@ximian.com>
22066 * expression.cs (Indirection): New helper class. Unary will
22067 create Indirection classes to be able to implement the
22068 IMemoryLocation interface on it.
22070 2002-02-16 Miguel de Icaza <miguel@ximian.com>
22072 * cs-parser.jay (fixed_statement): reference the right statement.
22074 * statement.cs (Fixed.Emit): Finish implementing the fixed
22075 statement for the &x case.
22077 2002-02-14 Miguel de Icaza <miguel@ximian.com>
22079 * class.cs (Property.Define, Method.Define): Remove newslot when
22082 * modifiers.cs: My use of NewSlot when `Abstract' was set was
22083 wrong. NewSlot should only be used if the `new' keyword is present.
22085 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
22086 locating our system dir. Sorry about this.
22088 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22090 * driver.cs (GetSystemDir): Compute correctly the location of our
22091 system assemblies. I was using the compiler directory instead of
22092 the library directory.
22094 2002-02-13 Ravi Pratap <ravi@ximian.com>
22096 * expression.cs (BetterFunction): Put back in what Miguel commented out
22097 since it is the correct fix. The problem is elsewhere ;-)
22099 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
22100 parameters of the parms method are themselves compatible or not !
22102 (StandardConversionExists): Fix very dangerous bug where we were forgetting
22103 to check that a class implements an interface before saying that an implicit
22104 conversion was allowed. Use ImplementsInterface to do the checking.
22106 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22108 * class.cs (Method.Define): Track whether we are an explicit
22109 implementation or not. And only call DefineMethodOverride if we
22110 are an explicit implementation.
22112 (Property.DefineMethod): Ditto.
22114 2002-02-11 Ravi Pratap <ravi@ximian.com>
22116 * expression.cs (BetterFunction): Catch hideous bug which was
22117 preventing us from detecting ambiguous calls due to implicit casts i.e
22120 2002-01-29 Miguel de Icaza <miguel@ximian.com>
22122 * support.cs (Pair): Remove un-needed method. I figured why I was
22123 getting the error in cs-parser.jay, the variable in a foreach loop
22124 is readonly, and the compiler does not really treat this as a variable.
22126 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
22127 instead of EQUALS in grammar.
22129 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
22131 * expression.cs (Unary.DoResolve): Check whether the argument is
22134 2002-01-28 Miguel de Icaza <miguel@ximian.com>
22136 * support.cs: Api for Pair to set a value. Despite the fact that
22137 the variables are public the MS C# compiler refuses to compile
22138 code that accesses the field if the variable is part of a foreach
22141 * statement.cs (Fixed): Begin implementation of the fixed
22144 (Block.AddVariable): Return the VariableInfo on success and null
22145 on failure instead of true/false.
22147 * cs-parser.jay (foreach): Catch errors on variables already
22148 defined (we were ignoring this value before) and properly unwind
22149 the block hierarchy
22151 (fixed_statement): grammar for the fixed statement.
22153 2002-01-25 Miguel de Icaza <miguel@ximian.com>
22155 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
22156 pointer types to be incretemented.
22158 (SizeOf): Implement.
22160 * cs-parser.jay (pointer_member_access): Implement
22161 expr->IDENTIFIER production.
22163 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
22164 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
22167 (Unary): Implement indirection.
22169 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
22170 use in non-unsafe context).
22172 (SimpleName.DoResolve): Check for pointers in field access on safe
22175 (Expression.LoadFromPtr): Factor the load-indirect code in this
22176 function. This was duplicated in UnboxCast and ParameterReference
22178 2002-01-24 Miguel de Icaza <miguel@ximian.com>
22180 * expression.cs (ComposedCast): report an error if a pointer cast
22181 is used in a safe region.
22183 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
22184 pointer type casts in unsafe context.
22186 * codegen.cs (EmitContext): Set up IsUnsafe.
22188 * cs-parser.jay (non_expression_type): Add productions for pointer
22191 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
22192 code. We should not use force into static mode if the method is
22193 not virtual. Fixes bug in MIS
22195 * statement.cs (Do.Emit, While.Emit, For.Emit,
22196 Statement.EmitBoolExpression): Add support to Do and While to
22197 propagate infinite loop as `I do return' semantics.
22199 Improve the For case to also test for boolean constants.
22201 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
22202 to the list of attributes we can add.
22204 Remove `EmitContext' argument.
22206 * class.cs (Method.Define): Apply parameter attributes.
22207 (Constructor.Define): Apply parameter attributes.
22208 (MethodCore.LabelParameters): Move here the core of labeling
22211 * support.cs (ReflectionParameters.ParameterModifier,
22212 InternalParameters.ParameterModifier): Use IsByRef on the type and
22213 only return the OUT bit for these parameters instead of in/out/ref
22216 This is because I miss-understood things. The ParameterInfo.IsIn
22217 and IsOut represent whether the parameter has the [In] and [Out]
22220 2002-01-22 Miguel de Icaza <miguel@ximian.com>
22222 * ecore.cs (FieldExpr.Emit): Release temporaries.
22224 * assign.cs (LocalTemporary.Release): new function.
22226 * codegen.cs (EmitContext.GetTemporaryStorage,
22227 EmitContext.FreeTemporaryStorage): Rework the way we deal with
22228 temporary storage. Now we can "put back" localbuilders when we
22231 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22233 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22234 need to make a copy of the variable to generate verifiable code.
22236 2002-01-19 Miguel de Icaza <miguel@ximian.com>
22238 * driver.cs: Compute dynamically the system directory.
22240 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
22241 Slower, but more generally useful. Used by the abstract
22242 registering implementation.
22244 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
22245 the rules for the special rule on Type/instances. First check if
22246 we have the same name, and if so, try that special static path
22247 rather than the instance path.
22249 2002-01-18 Miguel de Icaza <miguel@ximian.com>
22251 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
22254 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
22255 Enum, ValueType, Delegate or Array for non-corlib compiles.
22257 * cs-tokenizer.cs: Catch long identifiers (645)
22259 * typemanager.cs (IndexerPropetyName): Ravi never tested this
22262 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
22263 fix, we were returning too early, so we were not registering
22264 pending methods from abstract classes.
22266 Do not register pending methods if the class is abstract.
22268 * expression.cs (Conditional.DoResolve): Report circular implicit
22269 conversions when we neecd to compute it for conditional
22272 (Is.DoResolve): If the expression is always of the provided type,
22273 flag warning 183. If the expression can not ever be of the
22274 provided type flag warning 184.
22276 * class.cs: Catch 169 as well.
22278 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
22281 2002-01-18 Nick Drochak <ndrochak@gol.com>
22283 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
22285 2002-01-17 Miguel de Icaza <miguel@ximian.com>
22287 * interface.cs: (PopulateMethod): Check for pointers being defined
22288 only if the unsafe context is active.
22289 (PopulateProperty): ditto.
22290 (PopulateIndexer): ditto.
22292 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
22293 specified. If pointers are present, make sure that they are
22294 present in an unsafe context.
22295 (Constructor, Constructor.Define): ditto.
22296 (Field, Field.Define): ditto.
22297 (Property, Property.Define): ditto.
22298 (Event, Event.Define): ditto.
22300 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
22301 hashtable if there are classes or structs defined.
22303 * expression.cs (LocalVariableReference.DoResolve): Simplify this
22304 code, as the constant resolution moved.
22306 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
22307 the metadata, so we can flag error 133.
22309 * decl.cs (MemberCore.UnsafeOK): New function to test that a
22310 pointer is being declared in an unsafe context.
22312 2002-01-16 Miguel de Icaza <miguel@ximian.com>
22314 * modifiers.cs (Modifiers.Check): Require a Location argument.
22315 Report error 227 for Unsafe use.
22317 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
22319 * statement.cs (For.Emit): If the test is null, then report that
22320 we do `return', as we wont reach anything afterwards.
22322 (Switch.SwitchGoverningType): Track the expression that matched
22325 * driver.cs: Allow negative numbers as an error code to flag.
22327 * cs-parser.jay: Handle 1551.
22329 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
22331 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22333 * cs-parser.jay: Report 1518 (type declaration can only contain
22334 class, struct, interface, enum or delegate)
22336 (switch_label): Report 1523 (keywords `case' or `default' must
22339 (opt_switch_sections): Report 1522 (empty switch)
22341 * driver.cs: Report 1515 (response file specified multiple times)
22342 Report 1516 (Source file specified multiple times).
22344 * expression.cs (Argument.Resolve): Signal 1510
22346 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
22347 access not allowed in static code)
22349 2002-01-11 Ravi Pratap <ravi@ximian.com>
22351 * typemanager.cs (IsPointerType): Utility method which we are going
22354 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
22355 the object type, so we take care of that.
22357 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
22359 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
22360 added to non-params parameters :-)
22362 * typemanager.cs (CSharpName): Include 'void' type too.
22364 (void_ptr_type): Include in the set of core types.
22366 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
22369 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
22372 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
22373 completely forgotten about it.
22375 2002-01-10 Ravi Pratap <ravi@ximian.com>
22377 * cs-parser.jay (pointer_type): Add. This begins our implementation
22378 of parsing rules for unsafe code.
22380 (unsafe_statement): Implement.
22382 (embedded_statement): Modify to include the above.
22384 * statement.cs (Unsafe): Implement new class for unsafe blocks.
22386 * codegen.cs (EmitContext.InUnsafe): Add. This determines
22387 if the current context is an unsafe one.
22389 * cs-parser.jay (local_variable_pointer_type): Since local variable types
22390 are handled differently, we need separate rules for them.
22392 (local_variable_declaration): Update to use local_variable_pointer_type
22393 to allow variable declarations of unmanaged pointer types.
22395 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
22396 in unsafe contexts.
22398 * ../errors/cs0214.cs : Add.
22400 2002-01-16 Nick Drochak <ndrochak@gol.com>
22402 * makefile: remove 'response' file when cleaning.
22404 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22406 * cs-parser.jay: Report 1524.
22408 2002-01-14 Miguel de Icaza <miguel@ximian.com>
22410 * typemanager.cs (RegisterMethod): drop checking if we have
22411 registered this from here
22413 2002-01-12 Miguel de Icaza <miguel@ximian.com>
22415 * class.cs (Method.EmitDestructor): Implement calling our base
22418 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
22419 value of InFinally.
22421 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
22422 this routine and will wrap the call in a try/catch block. Deal
22425 2002-01-11 Miguel de Icaza <miguel@ximian.com>
22427 * ecore.cs (Expression.MemberLookup): instead of taking a
22428 parameter `same_type' that was used to tell whether we could
22429 access private members we compute our containing type from the
22432 (FieldExpr): Added partial support for volatile fields. This does
22433 not work for volatile fields exposed from assemblies, as I can not
22434 figure out how to extract the modreq from it.
22436 Updated all the source files to use this.
22438 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
22439 because it is referenced by MemberLookup very often.
22441 2002-01-09 Ravi Pratap <ravi@ximian.com>
22443 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
22444 TypeBuilder.GetCustomAttributes to retrieve what we need.
22446 Get rid of redundant default_member_attr_type as this is the same as
22447 default_member_type which already exists.
22449 * interface.cs, attribute.cs : Update accordingly.
22451 2002-01-08 Miguel de Icaza <miguel@ximian.com>
22453 * typemanager.cs: Enable IndexerPropertyName again. It does not
22454 work for TYpeBuilders though. Ravi, can you please fix this?
22456 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22458 * expression.cs (Argument.Emit): Handle the case of ref objects
22459 being passed to ref functions;
22461 (ParameterReference.EmitLoad): Loads the content of the pointer
22462 without dereferencing.
22464 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22466 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22468 2002-01-08 Ravi Pratap <ravi@ximian.com>
22470 * class.cs (Indexer.DefineMethod): Incorporate the interface
22471 type in the name of the method if we are doing explicit interface
22474 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22476 (BetterConversion): Fix extremely trivial bug where we were referring to
22477 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22480 * ../errors/bug16.cs : Add although we have fixed it.
22482 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22484 * expression.cs (BaseIndexer): Begin implementation.
22486 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22488 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22489 production directly to remove a shift/reduce, and implement
22490 explicit interface implementation.
22492 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22493 after a floating point suffix.
22495 * expression.cs (DoNumericPromotions): Improved the conversion for
22496 uint/uint. If we have a constant, we avoid doing a typecast to a
22499 * class.cs (Indexer): Implement explicit interface implementation
22502 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22504 * class.cs: make the default instance constructor public and hidebysig.
22506 2001-01-03 Ravi Pratap <ravi@ximian.com>
22508 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22509 so we can call it from elsewhere.
22511 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22512 we emit it internally if the class has a defined indexer; otherwise the user
22513 emits it by decorating the class definition with the DefaultMemberAttribute.
22515 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22516 attribute is not used on a type which defines an indexer.
22518 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22519 character when we skip whitespace.
22521 * ../errors/cs0646.cs : Add.
22523 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22525 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22528 * makefile: Add practical target `mcs3.exe' which builds the third
22529 generation compiler.
22531 * expression.cs (New): Fix structures constructor calling.
22533 * class.cs (Property, Method, Indexer): Emit Final flag on the
22534 method if we are an interface implementation and we are not
22537 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22538 whether this property is referencing a `base' method.
22540 * expression.cs (Invocation.EmitCall): take an extra argument:
22541 is_base, this is used to determine whether the `call' or
22542 `callvirt' opcode should be used.
22545 * delegate.cs: update EmitCall.
22547 * class.cs (Method.Define): Set NewSlot for the cases where we are
22548 not implementing an interface method.
22550 (Property.Define): ditto.
22552 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22554 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22555 'r'. Allows mcs to parse itself fully.
22557 2002-01-02 Ravi Pratap <ravi@ximian.com>
22559 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22560 of the number of initializers that require the InitializeArray method.
22562 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22563 update the above field where necessary.
22565 (MakeByteBlob): Update accordingly.
22567 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22570 (EmitDynamicInitializers): Update in accordance with the new optimization.
22572 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22573 same OpCode applies.
22575 * cs-parser.jay : Fix some glaring errors I introduced.
22577 2002-01-01 Ravi Pratap <ravi@ximian.com>
22579 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22580 so that we can check for name clashes there too.
22582 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22583 for interface indexers.
22585 * interfaces.cs (Define): Emit the default member attribute.
22587 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22588 variable was being referred to while setting the value ;-)
22590 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22592 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22593 byte-by-byte information when we know the data is zero.
22595 Make the block always a multiple of 4, because
22596 DefineInitializedData has a bug.
22598 * assign.cs: Fix, we should assign from the temporary, not from
22601 * expression.cs (MakeByteBlob): Fix my incorrect code.
22603 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22605 * typemanager.cs (EnumToUnderlying): This function is used to get
22606 the underlying type from an enumeration, because it does not
22609 * constant.cs: Use the I4_S form for values between -128 and 127.
22611 * statement.cs (Block.LookupLabel): Looks up a label.
22612 (Block): Drop support for labeled blocks.
22614 (LabeledStatement): New kind of statement that represents a label
22617 (Goto): Finally implement this bad boy.
22619 * cs-parser.jay: Update to reflect new mechanism to implement
22622 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22624 * codegen.cs (EmitContext.This): a codegen property that keeps the
22625 a single instance of this instead of creating many different this
22628 * delegate.cs (Delegate.DoResolve): Update to use the property;
22630 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22632 * expression.cs (BaseAccess.DoResolve): Ditto.
22634 2001-12-29 Ravi Pratap <ravi@ximian.com>
22636 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22637 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22639 (InitCoreTypes): Update accordingly.
22641 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22642 so we can quickly store the state.
22644 (ApplyAttributes): Set the correct implementation flags
22645 for InternalCall methods.
22647 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22649 * expression.cs (EmitCall): if a method is not virtual, then do
22650 not use callvirt on it.
22652 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22653 user defined stuff) requires the use of stobj, which takes an
22654 address on the stack instead of an array and an index. So emit
22655 the Ldelema operation for it.
22657 (EmitStoreOpcode): Use stobj for valuetypes.
22659 (UnaryMutator.EmitCode): Use the right 1 value depending on
22660 whether we are dealing with int64/uint64, float or doubles.
22662 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22663 constructors that I implemented last night.
22665 (Constructor.IsDefault): Fix to work properly for static
22668 * cs-parser.jay (CheckDef): report method signature errors.
22669 Update error number 103 to be 132.
22671 * decl.cs: New AdditionResult enumeration value: MethodExists.
22672 Although we do this check for methods later on in the semantic
22673 analysis, catching repeated default constructors is so easy that
22674 we catch these here.
22676 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22679 (ParameterReference.EmitAssign, Emit): handle
22682 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22683 (ArrayAccess.EmitStoreOpcode): ditto.
22685 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22687 * expression.cs (MakeByteBlob): Complete all the missing types
22688 (uint, short, ushort, byte, sbyte)
22690 * class.cs: Only init instance field initializers on instance
22693 Rename `constructors' to instance_constructors.
22695 (TypeContainer.AddConstructor): Only add constructors to the list
22696 if it is not static.
22698 Make sure that we handle default_static_constructor independently
22699 everywhere where we handle instance_constructors
22701 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22703 * class.cs: Do not lookup or create a base initializer for a
22704 static constructor.
22706 (ConstructorInitializer.Resolve): use the proper type to lookup
22709 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22711 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22714 * decl.cs: CloseType is now an virtual method, the default
22715 implementation just closes this type.
22717 2001-12-28 Ravi Pratap <ravi@ximian.com>
22719 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22720 to PreserveSig by default. Also emit HideBySig on such methods.
22722 Basically, set the defaults to standard values.
22724 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22725 argument, if candidate is better, it can't be worse than the best !
22727 (Invocation): Re-write bits to differentiate between methods being
22728 applicable in their expanded form and their normal form - for params
22731 Get rid of use_standard everywhere as only standard conversions are allowed
22732 in overload resolution.
22734 More spec conformance.
22736 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22738 * driver.cs: Add --timestamp, to see where the compiler spends
22741 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22742 `this' in static code.
22744 (SimpleName.DoResolve): Implement in terms of a helper function
22745 that allows static-references to be passed upstream to
22748 (Expression.ResolveWithSimpleName): Resolve specially simple
22749 names when called by MemberAccess to implement the special
22752 (Expression.ImplicitReferenceConversion): Handle conversions from
22753 Null to reference types before others, as Null's type is
22756 * expression.cs (Invocation.EmitCall): Handle the special case of
22757 calling methods declared on a reference type from a ValueType
22758 (Base classes System.Object and System.Enum)
22760 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22761 the left hand side is a TypeExpr, not on every enumeration.
22763 (Binary.Resolve): If types are reference types, then do a cast to
22764 object on operators != and == of both arguments.
22766 * typemanager.cs (FindMembers): Extract instance and static
22767 members if requested.
22769 * interface.cs (PopulateProperty): Use void_type instead of null
22770 as the return type for the setter method.
22772 (PopulateIndexer): ditto.
22774 2001-12-27 Ravi Pratap <ravi@ximian.com>
22776 * support.cs (ReflectionParameters): Fix minor bug where we
22777 were examining the wrong parameter for the ParamArray attribute.
22779 Cope with requests for the type of the parameter at position
22780 greater than the params parameter's. We now return the element
22781 type of the params array as that makes more sense.
22783 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22784 accordingly as we no longer have to extract the element type
22787 (Invocation.OverloadResolve): Update.
22789 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22791 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22792 against IEnumerator, test whether the return value is a descendant
22793 of the IEnumerator interface.
22795 * class.cs (Indexer.Define): Use an auxiliary method to implement
22796 the other bits of the method definition. Begin support for
22797 explicit interface implementation.
22799 (Property.DefineMethod): Use TypeManager.void_type instead of null
22800 for an empty return value.
22802 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22804 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22805 dealing with a FieldExpr which is composed of a FieldBuilder, in
22806 the code path we did extract the constant, but we should have
22807 obtained the underlying value to be able to cast it (otherwise we
22808 end up in an infinite loop, this is what Ravi was running into).
22810 (ArrayCreation.UpdateIndices): Arrays might be empty.
22812 (MemberAccess.ResolveMemberAccess): Add support for section
22813 14.5.4.1 that deals with the special case of E.I when E is a type
22814 and something else, that I can be a reference to a static member.
22816 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22817 handle a particular array type to create byte blobs, it is just
22818 something we dont generate byteblobs for.
22820 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22823 * location.cs (Push): remove the key from the hashtable that we
22824 are about to add. This happens for empty files.
22826 * driver.cs: Dispose files after we have parsed them.
22828 (tokenize): new function that only runs the tokenizer on its
22829 input, for speed testing.
22831 2001-12-26 Ravi Pratap <ravi@ximian.com>
22833 * class.cs (Event.Define): Define the private field only if there
22834 are no accessors defined.
22836 * expression.cs (ResolveMemberAccess): If there is no associated
22837 field with the event, that means we have an event defined with its
22838 own accessors and we should flag error cs0070 since transforming
22839 ourselves into a field is not valid in that case.
22841 * ecore.cs (SimpleName.DoResolve): Same as above.
22843 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22844 and charset to sane values.
22846 2001-12-25 Ravi Pratap <ravi@ximian.com>
22848 * assign.cs (DoResolve): Perform check on events only if they
22849 are being accessed outside the declaring type.
22851 * cs-parser.jay (event_declarations): Update rules to correctly
22852 set the type of the implicit parameter etc.
22854 (add_accessor, remove_accessor): Set current local parameters.
22856 * expression.cs (Binary): For delegate addition and subtraction,
22857 cast the return value from the method into the appropriate delegate
22860 2001-12-24 Ravi Pratap <ravi@ximian.com>
22862 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22863 of these as the workaround is unnecessary.
22865 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22866 delegate data - none of that is needed at all.
22868 Re-write bits to extract the instance expression and the delegate method
22871 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22874 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22875 of attaching attributes instead of duplicating code everywhere.
22877 * everywhere : Update code to do attribute emission using the above method.
22879 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22881 * expression.cs (IsParamsMethodApplicable): if there are not
22882 parameters, return immediately.
22884 * ecore.cs: The 0 literal can be implicity converted to an enum
22887 (SimpleName.DoResolve): First lookup the type, then lookup the
22890 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22891 want to get its address. If the InstanceExpression is not
22892 addressable, store the result in a temporary variable, then get
22895 * codegen.cs: Only display 219 errors on warning level or above.
22897 * expression.cs (ArrayAccess): Make it implement the
22898 IMemoryLocation interface.
22900 (Binary.DoResolve): handle the operator == (object a, object b)
22901 and operator != (object a, object b) without incurring into a
22902 BoxedCast (because 5 != o should never be performed).
22904 Handle binary enumerator operators.
22906 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22907 value type, otherwise use Ldelem_ref.
22909 Use precomputed names;
22911 (AddressOf): Implement address of
22913 * cs-parser.jay (labeled_statement): Fix recursive block
22914 addition by reworking the production.
22916 * expression.cs (New.DoEmit): New has a special case:
22918 If we are dealing with a ValueType, we have a few
22919 situations to deal with:
22921 * The target of New is a ValueType variable, that is
22922 easy, we just pass this as the variable reference
22924 * The target of New is being passed as an argument,
22925 to a boxing operation or a function that takes a
22928 In this case, we need to create a temporary variable
22929 that is the argument of New.
22932 2001-12-23 Ravi Pratap <ravi@ximian.com>
22934 * rootcontext.cs (LookupType): Check that current_type is not null before
22935 going about looking at nested types.
22937 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22938 not implement the IAssignMethod interface any more.
22940 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22941 where we tranform them into FieldExprs if they are being resolved from within
22942 the declaring type.
22944 * ecore.cs (SimpleName.DoResolve): Do the same here.
22946 * assign.cs (DoResolve, Emit): Clean up code considerably.
22948 * ../errors/bug10.cs : Add.
22950 * ../errors/cs0070.cs : Add.
22952 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22954 * assign.cs : Get rid of EventIsLocal everywhere.
22956 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22958 * ecore.cs (ConvertIntLiteral): finished the implementation.
22960 * statement.cs (SwitchLabel): Convert the value we are using as a
22961 key before looking up the table.
22963 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22965 * codegen.cs (EmitTopBlock): Require a Location argument now.
22967 * cs-parser.jay (constructor_declarator): We need to setup
22968 current_local_parameters before we parse the
22969 opt_constructor_initializer, to allow the variables to be bound
22970 to the constructor arguments.
22972 * rootcontext.cs (LookupType): First lookup nested classes in our
22973 class and our parents before we go looking outside our class.
22975 * expression.cs (ConstantFold): Extract/debox the values at the
22978 * rootcontext.cs (EmitCode): Resolve the constants first before we
22979 resolve the types. This is not really needed, but it helps debugging.
22981 * statement.cs: report location.
22983 * cs-parser.jay: pass location to throw statement.
22985 * driver.cs: Small bug fix.
22987 * report.cs: Updated format to be 4-zero filled digits.
22989 2001-12-22 Ravi Pratap <ravi@ximian.com>
22991 * expression.cs (CheckIndices): Fix minor bug where the wrong
22992 variable was being referred to ;-)
22994 (DoEmit): Do not call EmitStaticInitializers when the
22995 underlying type is System.Object.
22997 2001-12-21 Ravi Pratap <ravi@ximian.com>
22999 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
23000 and do the usual workaround for SRE.
23002 * class.cs (MyEventBuilder.EventType): New member to get at the type
23003 of the event, quickly.
23005 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
23007 * assign.cs (Assign.DoResolve): Handle the case when the target
23008 is an EventExpr and perform the necessary checks.
23010 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
23013 (SimpleName.MemberStaticCheck): Include check for EventExpr.
23015 (EventExpr): Set the type in the constructor itself since we
23016 are meant to be born fully resolved.
23018 (EventExpr.Define): Revert code I wrote earlier.
23020 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
23021 instance expression is null. The instance expression is a This in that case
23022 or a null, depending on whether it is a static method or not.
23024 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
23025 refers to more than one method.
23027 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
23028 and accordingly flag errors.
23030 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23032 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
23034 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23036 * location.cs (ToString): Provide useful rutine.
23038 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23040 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
23041 objects, return the actual integral boxed.
23043 * statement.cs (SwitchLabel): define an ILLabel for each
23046 (Switch.CheckSwitch): If the value is a Literal, extract
23047 the underlying literal.
23049 Also in the unused hashtable we had, add the SwitchLabel so we can
23050 quickly look this value up.
23052 * constant.cs: Implement a bunch of new constants. Rewrite
23053 Literal based on this. Made changes everywhere to adapt to this.
23055 * expression.cs (Expression.MakeByteBlob): Optimize routine by
23056 dereferencing array only once, and also copes with enumrations.
23058 bytes are two bytes wide, not one.
23060 (Cast): Perform constant conversions.
23062 * ecore.cs (TryImplicitIntConversion): Return literals instead of
23063 wrappers to the literals here.
23065 * expression.cs (DoNumericPromotions): long literals can converted
23066 to ulong implicity (this is taken care of elsewhere, but I was
23067 missing this spot).
23069 * ecore.cs (Expression.Literalize): Make the return type Literal,
23070 to improve type checking.
23072 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
23074 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23076 * literal.cs: Revert code from ravi that checked the bounds. The
23077 bounds are sane by the definition of the type itself.
23079 * typemanager.cs: Fix implementation of ImplementsInterface. We
23080 need to actually look up in our parent hierarchy for interfaces
23083 * const.cs: Use the underlying type for enumerations
23085 * delegate.cs: Compute the basename for the delegate creation,
23086 that should fix the delegate test case, and restore the correct
23087 Type Lookup semantics in rootcontext
23089 * rootcontext.cs: Revert Ravi's last patch. The correct way of
23090 referencing a nested type with the Reflection API is using the "+"
23093 * cs-parser.jay: Do not require EOF token at the end.
23095 2001-12-20 Ravi Pratap <ravi@ximian.com>
23097 * rootcontext.cs (LookupType): Concatenate type names with
23098 a '.' instead of a '+' The test suite passes again.
23100 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
23101 field of the enumeration.
23103 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
23104 the case when the member is an EventExpr.
23106 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
23107 static has an associated instance expression.
23109 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
23111 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
23113 * class.cs (Event.Define): Register event and perform appropriate checks
23116 We define the Add and Remove methods even if the use provides none because
23117 in that case, we provide default implementations ourselves.
23119 Define a private field of the type of the event. This is done by the CSC compiler
23120 and we should be doing it too ;-)
23122 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
23123 More methods we use in code we generate.
23125 (multicast_delegate_type, delegate_type): Two separate types since the distinction
23128 (InitCoreTypes): Update accordingly for the above.
23130 * class.cs (Event.Emit): Generate code for default accessors that we provide
23132 (EmitDefaultMethod): Do the job in the above.
23134 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
23137 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23139 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
23140 builders even if we were missing one.
23142 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
23143 pass the Basename as our class name instead of the Name. The
23144 basename will be correctly composed for us.
23146 * parameter.cs (Paramters): Now takes a Location argument.
23148 * decl.cs (DeclSpace.LookupType): Removed convenience function and
23149 make all the code call directly LookupType in RootContext and take
23150 this chance to pass the Location information everywhere.
23152 * Everywhere: pass Location information.
23154 2001-12-19 Miguel de Icaza <miguel@ximian.com>
23156 * class.cs (Constructor.Define): Updated way of detecting the
23157 length of the parameters.
23159 (TypeContainer.DefineType): Use basename as the type name for
23162 (TypeContainer.Define): Do not recursively define types here, as
23163 definition is taken care in order by the RootContext.
23165 * tree.cs: Keep track of namespaces in a per-file basis.
23167 * parameter.cs (Parameter.ComputeSignature): Update to use
23170 (Parameters.GetSignature): ditto.
23172 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
23173 instead of a TypeContainer.
23175 (Interface.SemanticAnalysis): Use `this' instead of our parent to
23176 resolve names. Because we need to be resolve in our context, not
23179 * driver.cs: Implement response files.
23181 * class.cs (TypeContainer.DefineType): If we are defined, do not
23182 redefine ourselves.
23184 (Event.Emit): Emit the code for add/remove handlers.
23185 (Event.Define): Save the MethodBuilders for add/remove.
23187 * typemanager.cs: Use pair here too.
23189 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
23190 DictionaryEntry requires the first argument to be non-null.
23192 (enum_declaration): Compute full name for registering the
23195 (delegate_declaration): Instead of using
23196 formal_parameter_list, use opt_formal_parameter_list as the list
23199 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
23200 (EventParsing): New property that controls whether `add' and
23201 `remove' are returned as tokens or identifiers (for events);
23203 2001-12-19 Ravi Pratap <ravi@ximian.com>
23205 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
23206 use MyEventBuilder only and let it wrap the real builder for us.
23208 (MyEventBuilder): Revamp constructor etc.
23210 Implement all operations that we perform on EventBuilder in precisely the same
23213 (FindMembers): Update to use the EventBuilder member.
23215 (Event.Emit): Update accordingly.
23217 2001-12-18 Ravi Pratap <ravi@ximian.com>
23219 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
23220 by calling the appropriate methods.
23222 (GetCustomAttributes): Make stubs as they cannot possibly do anything
23225 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
23227 2001-12-17 Ravi Pratap <ravi@ximian.com>
23229 * delegate.cs (Delegate.Populate): Check that the return type
23230 and various parameters types are indeed accessible.
23232 * class.cs (Constructor.Define): Same here.
23234 (Field.Define): Ditto.
23236 (Event.Define): Ditto.
23238 (Operator.Define): Check that the underlying Method defined itself
23239 correctly - so it's MethodBuilder should not be null.
23241 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
23242 expression happens to be null.
23244 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
23245 members but as of now we don't seem to be able to do anything really useful with it.
23247 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
23248 not the EventBuilder.
23250 2001-12-18 Miguel de Icaza <miguel@ximian.com>
23252 * cs-tokenizer.cs: Add support for defines.
23253 Add support for #if, #elif, #else, #endif
23255 (eval_var): evaluates a variable.
23256 (eval): stubbed for evaluating functions.
23258 * cs-parser.jay: Pass the defines information
23260 * driver.cs: Add --define command line option.
23262 * decl.cs: Move MemberCore here.
23264 Make it the base class for DeclSpace. This allows us to catch and
23265 report 108 and 109 for everything now.
23267 * class.cs (TypeContainer.Define): Extract all the members
23268 before populating and emit the warning 108 (new keyword required
23269 to override) instead of having each member implement this.
23271 (MemberCore.Define): New abstract method, we will be using this in
23272 the warning reporting engine in Populate.
23274 (Operator.Define): Adjust to new MemberCore protocol.
23276 * const.cs (Const): This does not derive from Expression, it is a
23277 temporary object we use to create fields, it is a MemberCore.
23279 * class.cs (Method.Define): Allow the entry point to be in a
23282 * driver.cs: Rewrite the argument handler to clean it up a bit.
23284 * rootcontext.cs: Made it just an auxiliary namespace feature by
23285 making everything static.
23287 * driver.cs: Adapt code to use RootContext type name instead of
23290 * delegate.cs: Remove RootContext argument.
23292 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
23295 * class.cs (Event.Define): The lookup can fail.
23297 * cs-tokenizer.cs: Begin implementation of pre-procesor.
23299 * expression.cs: Resolve the this instance before invoking the code.
23301 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23303 * cs-parser.jay: Add a production in element_access that allows
23304 the thing to become a "type" reference. This way we can parse
23305 things like "(string [])" as a type.
23307 Note that this still does not handle the more complex rules of
23311 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
23313 * ecore.cs: (CopyNewMethods): new utility function used to
23314 assemble the list of methods from running FindMembers.
23316 (MemberLookup): Rework FindMembers so that
23318 2001-12-16 Miguel de Icaza <miguel@ximian.com>
23320 * class.cs (TypeContainer): Remove Delegates who fail to be
23323 * delegate.cs (Populate): Verify that we dont get null return
23324 values. TODO: Check for AsAccessible.
23326 * cs-parser.jay: Use basename to emit error 574 (destructor should
23327 have the same name as container class), not the full name.
23329 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
23330 possible representation.
23332 Also implements integer type suffixes U and L.
23334 2001-12-15 Miguel de Icaza <miguel@ximian.com>
23336 * expression.cs (ArrayCreation.DoResolve): We need to do the
23337 argument resolution *always*.
23339 * decl.cs: Make this hold the namespace. Hold the root context as
23341 (LookupType): Move here.
23343 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
23345 * location.cs (Row, Name): Fixed the code, it was always returning
23346 references to the first file.
23348 * interface.cs: Register properties defined through interfaces.
23350 * driver.cs: Add support for globbing on the command line
23352 * class.cs (Field): Make it derive from MemberCore as well.
23355 2001-12-15 Ravi Pratap <ravi@ximian.com>
23357 * class.cs (Event::Define): Check that the type of the event is a delegate
23358 type else flag error #66.
23360 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
23363 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
23364 values of EntryPoint, CharSet etc etc.
23366 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
23368 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
23369 be null and we should ignore this. I am not sure if this is really clean. Apparently,
23370 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
23371 which needs this to do its work.
23373 * ../errors/cs0066.cs : Add.
23375 2001-12-14 Miguel de Icaza <miguel@ximian.com>
23377 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
23380 * class.cs: (MethodSignature.MethodSignature): Removed hack that
23381 clears out the parameters field.
23382 (MemberSignatureCompare): Cleanup
23384 (MemberCore): New base class used to share code between MethodCore
23387 (RegisterRequiredImplementations) BindingFlags.Public requires
23388 either BindingFlags.Instace or Static. Use instance here.
23390 (Property): Refactored code to cope better with the full spec.
23392 * parameter.cs (GetParameterInfo): Return an empty array instead
23395 * class.cs (Property): Abstract or extern properties have no bodies.
23397 * parameter.cs (GetParameterInfo): return a zero-sized array.
23399 * class.cs (TypeContainer.MethodModifiersValid): Move all the
23400 method modifier validation to the typecontainer so we can reuse
23401 this on properties.
23403 (MethodCore.ParameterTypes): return an empty sized array of types.
23405 (Property.Define): Test property modifier validity.
23407 Add tests for sealed/override too.
23409 (Method.Emit): abstract or extern methods have no bodies.
23411 2001-12-14 Ravi Pratap <ravi@ximian.com>
23413 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
23416 (Method::Define, ::Emit): Modify accordingly.
23418 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
23420 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
23422 * makefile: Pass in /unsafe.
23424 2001-12-13 Miguel de Icaza <miguel@ximian.com>
23426 * class.cs (MakeKey): Kill routine.
23428 * class.cs (TypeContainer.Define): Correctly define explicit
23429 method implementations (they require the full interface name plus
23432 * typemanager.cs: Deply the PtrHashtable here and stop using the
23433 lame keys. Things work so much better.
23435 This of course broke everyone who depended on `RegisterMethod' to
23436 do the `test for existance' test. This has to be done elsewhere.
23438 * support.cs (PtrHashtable): A hashtable that avoid comparing with
23439 the object stupid Equals method (because, that like fails all over
23440 the place). We still do not use it.
23442 * class.cs (TypeContainer.SetRequiredInterface,
23443 TypeContainer.RequireMethods): Killed these two routines and moved
23444 all the functionality to RegisterRequiredImplementations.
23446 (TypeContainer.RegisterRequiredImplementations): This routine now
23447 registers all the implementations required in an array for the
23448 interfaces and abstract methods. We use an array of structures
23449 which can be computed ahead of time to reduce memory usage and we
23450 also assume that lookups are cheap as most classes will not
23451 implement too many interfaces.
23453 We also avoid creating too many MethodSignatures.
23455 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23456 clear the "pending" bit if we find that there are problems with
23459 (TypeContainer.VerifyPendingMethods): Update to report errors of
23460 methods that look like implementations but are not.
23462 (TypeContainer.Define): Add support for explicit interface method
23465 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23467 * typemanager.cs: Keep track of the parameters here instead of
23468 being a feature of the TypeContainer.
23470 * class.cs: Drop the registration of parameters here, as
23471 InterfaceMethods are also interface declarations.
23473 * delegate.cs: Register methods with the TypeManager not only with
23474 the TypeContainer. This code was buggy.
23476 * interface.cs: Full registation here.
23478 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23480 * expression.cs: Remove reducer for binary expressions, it can not
23483 * const.cs: Put here the code that used to go into constant.cs
23485 * constant.cs: Put here the code for constants, this is a new base
23486 class for Literals.
23488 * literal.cs: Make Literal derive from Constant.
23490 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23492 * statement.cs (Return.Emit): Report error 157 if the user
23493 attempts to return from a finally block.
23495 (Return.Emit): Instead of emitting a return, jump to the end of
23498 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23499 LocalBuilder to store the result of the function. ReturnLabel is
23500 the target where we jump.
23503 2001-12-09 Radek Doulik <rodo@ximian.com>
23505 * cs-parser.jay: remember alias in current namespace
23507 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23510 * class.cs (LookupAlias): lookup alias in my_namespace
23512 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23514 (LookupAlias): lookup alias in this and if needed in parent
23517 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23521 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23522 making things static. I need this to avoid passing the
23523 TypeContainer when calling ParameterType.
23525 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23526 that did string manipulation to compute the type and then call
23527 GetType. Use Parameter.ParameterType instead.
23529 * cs-tokenizer.cs: Consume the suffix for floating values.
23531 * expression.cs (ParameterReference): figure out whether this is a
23532 reference parameter or not. Kill an extra variable by computing
23533 the arg_idx during emission.
23535 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23536 function that returns whether a parameter is an out/ref value or not.
23538 (Parameter.ParameterType): The type of the parameter (base,
23539 without ref/out applied).
23541 (Parameter.Resolve): Perform resolution here.
23542 (Parameter.ExternalType): The full type (with ref/out applied).
23544 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23545 support for expressions on the using statement.
23547 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23549 * statement.cs (Using.EmitLocalVariableDecls): Split the
23550 localvariable handling of the using statement.
23552 (Block.EmitMeta): Keep track of variable count across blocks. We
23553 were reusing slots on separate branches of blocks.
23555 (Try.Emit): Emit the general code block, we were not emitting it.
23557 Check the type of the declaration to be an IDisposable or
23558 something that can be implicity converted to it.
23560 Emit conversions if required.
23562 * ecore.cs (EmptyExpression): New utility class.
23563 (Expression.ImplicitConversionExists): New utility function.
23565 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23567 * statement.cs (Using): Implement.
23569 * expression.cs (LocalVariableReference): Support read only variables.
23571 * statement.cs: Remove the explicit emit for the Leave opcode.
23572 (VariableInfo): Add a readonly field.
23574 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23576 * ecore.cs (ConvCast): new class used to encapsulate the various
23577 explicit integer conversions that works in both checked and
23578 unchecked contexts.
23580 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23581 properly generate the overflow opcodes.
23583 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23585 * statement.cs: The correct type for the EmptyExpression is the
23586 element_type, not the variable type. Ravi pointed this out.
23588 2001-12-04 Ravi Pratap <ravi@ximian.com>
23590 * class.cs (Method::Define): Handle PInvoke methods specially
23591 by using DefinePInvokeMethod instead of the usual one.
23593 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23594 above to do the task of extracting information and defining the method.
23596 2001-12-04 Ravi Pratap <ravi@ximian.com>
23598 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23599 of the condition for string type.
23601 (Emit): Move that here.
23603 (ArrayCreation::CheckIndices): Keep string literals in their expression
23606 (EmitDynamicInitializers): Handle strings appropriately.
23608 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23610 * codegen.cs (EmitContext): Replace multiple variables with a
23611 single pointer to the current Switch statement.
23613 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23616 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23620 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23623 (Foreach.Emit): Foreach on arrays was not setting
23624 up the loop variables (for break/continue).
23626 (GotoCase): Semi-implented.
23628 2001-12-03 Ravi Pratap <ravi@ximian.com>
23630 * attribute.cs (CheckAttribute): Handle system attributes by using
23631 Attribute.GetAttributes to examine information we need.
23633 (GetValidPlaces): Same here.
23635 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23637 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23639 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23641 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23643 (Method::Emit): Handle the case when we are a PInvoke method.
23645 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23647 * expression.cs: Use ResolveWithSimpleName on compound names.
23649 2001-12-02 Ravi Pratap <ravi@ximian.com>
23651 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23652 before trying to reduce it.
23654 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23656 * constant.cs (LookupConstantValue): Implement.
23658 (EmitConstant): Use the above in emitting the constant.
23660 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23661 that are user-defined by doing a LookupConstantValue on them.
23663 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23666 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23668 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23670 (BaseAccess.DoResolve): Implement.
23672 (MemberAccess.DoResolve): Split this routine into a
23673 ResolveMemberAccess routine that can be used independently
23675 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23677 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23678 As that share bits of the implementation. Is returns a boolean,
23679 while As returns the Type that is being probed.
23681 2001-12-01 Ravi Pratap <ravi@ximian.com>
23683 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23684 instead of a Literal - much easier.
23686 (EnumInTransit): Remove - utterly useless :-)
23688 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23690 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23692 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23693 chain when we have no associated expression.
23695 2001-11-30 Ravi Pratap <ravi@ximian.com>
23697 * constant.cs (Define): Use Location while reporting the errror.
23699 Also emit a warning when 'new' is used and there is no inherited
23702 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23705 (LookupEnumValue): Implement to lookup an enum member's value and define it
23708 (Populate): Re-write accordingly to use the above routine.
23710 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23712 * expression.cs (This): Fix prototype for DoResolveLValue to
23713 override the base class DoResolveLValue.
23715 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23718 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23719 (we need to load the address of the field here). This fixes
23722 (FieldExpr.DoResolveLValue): Call the DoResolve
23723 function to initialize the Instance expression.
23725 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23726 correctly the GetEnumerator operation on a value type.
23728 * cs-parser.jay: Add more simple parsing error catches.
23730 * statement.cs (Switch): Add support for string switches.
23731 Handle null specially.
23733 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23735 2001-11-28 Ravi Pratap <ravi@ximian.com>
23737 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23739 (declare_local_constant): New helper function.
23741 * statement.cs (AddConstant): Keep a separate record of constants
23743 (IsConstant): Implement to determine if a variable is a constant.
23745 (GetConstantExpression): Implement.
23747 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23749 * statement.cs (IsVariableDefined): Re-write.
23751 2001-11-27 Ravi Pratap <ravi@ximian.com>
23753 * class.cs (TypeContainer::FindMembers): Look for constants
23754 in the case when we are looking for MemberTypes.Field
23756 * expression.cs (MemberAccess::DoResolve): Check that in the
23757 case we are a FieldExpr and a Literal, we are not being accessed
23758 by an instance reference.
23760 * cs-parser.jay (local_constant_declaration): Implement.
23762 (declaration_statement): Implement for constant declarations.
23764 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23766 * statement.cs (Switch): Catch double defaults.
23768 (Switch): More work on the switch() statement
23769 implementation. It works for integral values now, need to finish
23773 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23775 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23776 integer literals into other integer literals. To be used by
23779 2001-11-24 Ravi Pratap <ravi@ximian.com>
23781 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23784 (EmitDynamicInitializers): Cope with the above since we extract data
23785 directly from ArrayData now.
23787 (ExpectInitializers): Keep track of whether initializers are mandatory
23790 (Bounds): Make it a hashtable to prevent the same dimension being
23791 recorded for every element in that dimension.
23793 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23796 Also fix bug which was causing the indices to be emitted in the reverse
23799 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23801 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23802 unfinished. They do not work, because the underlying code is
23805 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23807 * cs-parser.jay: Remove bogus fixme.
23809 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23810 on Switch statement.
23812 2001-11-23 Ravi Pratap <ravi@ximian.com>
23814 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23817 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23818 parameter. Apparently, any expression is allowed.
23820 (ValidateInitializers): Update accordingly.
23822 (CheckIndices): Fix some tricky bugs thanks to recursion.
23824 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23825 I was being completely brain-dead.
23827 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23828 and re-write acordingly.
23830 (DelegateInvocation): Re-write accordingly.
23832 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23834 (MakeByteBlob): Handle types more correctly.
23836 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23837 initialization from expressions but it is incomplete because I am a complete
23840 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23842 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23843 on If. Basically, we have to return `true' (ie, we do return to
23844 our caller) only if both branches of the if return.
23846 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23847 short-circuit operators, handle them as short circuit operators.
23849 (Cast.DoResolve): Resolve type.
23850 (Cast.Cast): Take an expression as the target type.
23852 * cs-parser.jay (cast_expression): Remove old hack that only
23853 allowed a limited set of types to be handled. Now we take a
23854 unary_expression and we resolve to a type during semantic
23857 Use the grammar productions from Rhys to handle casts (this is
23858 not complete like Rhys syntax yet, we fail to handle that corner
23859 case that C# has regarding (-x), but we will get there.
23861 2001-11-22 Ravi Pratap <ravi@ximian.com>
23863 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23864 field which is an array type.
23866 * cs-parser.jay (declare_local_variables): Support array initialization too.
23868 * typemanager.cs (MakeKey): Implement.
23870 (everywhere): Use the above appropriately.
23872 * cs-parser.jay (for_statement): Update for array initialization while
23873 declaring variables.
23875 * ecore.cs : The error message was correct, it's the variable's names that
23876 were misleading ;-) Make the code more readable.
23878 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23879 the correct type etc.
23881 (ConvertExplicit): Handle Enum types by examining the underlying type.
23883 2001-11-21 Ravi Pratap <ravi@ximian.com>
23885 * parameter.cs (GetCallingConvention): Always return
23886 CallingConventions.Standard for now.
23888 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23890 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23891 and `r' after calling DoNumericPromotions.
23893 * ecore.cs: Fix error message (the types were in the wrong order).
23895 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23896 BindingFlags.Instance as well
23898 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23899 implicit int literal conversion in an empty cast so that we
23900 propagate the right type upstream.
23902 (UnboxCast): new class used to unbox value types.
23903 (Expression.ConvertExplicit): Add explicit type conversions done
23906 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23907 the target type before applying the implicit LongLiterals to ULong
23910 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23912 * cs-parser.jay (for_statement): Reworked the way For works: now
23913 we declare manually any variables that are introduced in
23914 for_initializer to solve the problem of having out-of-band code
23915 emition (that is what got for broken).
23917 (declaration_statement): Perform the actual variable declaration
23918 that used to be done in local_variable_declaration here.
23920 (local_variable_declaration): Do not declare anything, just pass
23921 the information on a DictionaryEntry
23923 2001-11-20 Ravi Pratap <ravi@ximian.com>
23925 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23926 re-write of the logic to now make it recursive.
23928 (UpdateIndices): Re-write accordingly.
23930 Store element data in a separate ArrayData list in the above methods.
23932 (MakeByteBlob): Implement to dump the array data into a byte array.
23934 2001-11-19 Ravi Pratap <ravi@ximian.com>
23936 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23939 * constant.cs (Define): Implement.
23941 (EmitConstant): Re-write fully.
23943 Pass in location info.
23945 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23948 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23949 DictionaryEntry since we need location info too.
23951 (constant_declaration): Update accordingly.
23953 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23954 code into another method : UpdateIndices.
23956 2001-11-18 Ravi Pratap <ravi@ximian.com>
23958 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23959 some type checking etc.
23961 2001-11-17 Ravi Pratap <ravi@ximian.com>
23963 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23964 bits to provide dimension info if the user skips doing that.
23966 Update second constructor to store the rank correctly.
23968 2001-11-16 Ravi Pratap <ravi@ximian.com>
23970 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23971 and try to implement.
23973 * ../errors/cs0150.cs : Add.
23975 * ../errors/cs0178.cs : Add.
23977 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23979 * statement.cs: Implement foreach on multi-dimensional arrays.
23981 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23982 name of the params argument.
23984 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23985 initializing the array.
23987 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23988 we can use this elsewhere.
23990 * statement.cs: Finish implementation of foreach for single
23993 * cs-parser.jay: Use an out-of-band stack to pass information
23994 around, I wonder why I need this.
23996 foreach_block: Make the new foreach_block the current_block.
23998 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23999 function used to return a static Parameters structure. Used for
24000 empty parameters, as those are created very frequently.
24002 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
24004 2001-11-15 Ravi Pratap <ravi@ximian.com>
24006 * interface.cs : Default modifier is private, not public. The
24007 make verify test passes again.
24009 2001-11-15 Ravi Pratap <ravi@ximian.com>
24011 * support.cs (ReflectionParameters): Fix logic to determine
24012 whether the last parameter is a params one. Test 9 passes again.
24014 * delegate.cs (Populate): Register the builders we define with
24015 RegisterParameterForBuilder. Test 19 passes again.
24017 * cs-parser.jay (property_declaration): Reference $6 instead
24018 of $$ to get at the location.
24020 (indexer_declaration): Similar stuff.
24022 (attribute): Ditto.
24024 * class.cs (Property): Register parameters for the Get and Set methods
24025 if they exist. Test 23 passes again.
24027 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
24028 call to EmitArguments as we are sure there aren't any params arguments.
24029 Test 32 passes again.
24031 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
24032 IndexOutOfRangeException.
24034 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
24035 Test 33 now passes again.
24037 2001-11-15 Miguel de Icaza <miguel@ximian.com>
24039 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
24040 broke a bunch of things. Will have to come up with a better way
24041 of tracking locations.
24043 * statement.cs: Implemented foreach for single dimension arrays.
24045 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24047 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
24048 an error. This removes the lookup from the critical path.
24050 * cs-parser.jay: Removed use of temporary_loc, which is completely
24053 2001-11-14 Miguel de Icaza <miguel@ximian.com>
24055 * support.cs (ReflectionParameters.ParameterModifier): Report
24056 whether the argument is a PARAMS argument or not.
24058 * class.cs: Set the attribute `ParamArrayAttribute' on the
24059 parameter argument.
24061 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
24062 and cons_param_array_attribute (ConstructorInfo for
24063 ParamArrayAttribute).,
24065 * codegen.cs: Emit the return using the `Return' statement, that
24066 way we can report the error correctly for missing return values.
24068 * class.cs (Method.Emit): Clean up.
24070 * expression.cs (Argument.Resolve): Take another argument: the
24071 location where this argument is used. Notice that this is not
24072 part of the "Argument" class as to reduce the size of the
24073 structure (we know the approximate location anyways).
24075 Test if the argument is a variable-reference, if not, then
24076 complain with a 206.
24078 (Argument.Emit): Emit addresses of variables.
24080 (Argument.FullDesc): Simplify.
24082 (Invocation.DoResolve): Update for Argument.Resolve.
24084 (ElementAccess.DoResolve): ditto.
24086 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
24087 method should be virtual, as this method is always virtual.
24089 (NewDelegate.DoResolve): Update for Argument.Resolve.
24091 * class.cs (ConstructorInitializer.DoResolve): ditto.
24093 * attribute.cs (Attribute.Resolve): ditto.
24095 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24097 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
24099 * expression.cs (ParameterReference): Drop IStackStorage and implement
24100 IAssignMethod instead.
24102 (LocalVariableReference): ditto.
24104 * ecore.cs (FieldExpr): Drop IStackStorage and implement
24105 IAssignMethod instead.
24107 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24109 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
24110 enumerations that are used in heavily used structures derive from
24111 byte in a laughable and pathetic attempt to reduce memory usage.
24112 This is the kind of pre-optimzations that you should not do at
24113 home without adult supervision.
24115 * expression.cs (UnaryMutator): New class, used to handle ++ and
24116 -- separatedly from the other unary operators. Cleans up the
24117 code, and kills the ExpressionStatement dependency in Unary.
24119 (Unary): Removed `method' and `Arguments' from this class, making
24120 it smaller, and moving it all to SimpleCall, so I can reuse this
24121 code in other locations and avoid creating a lot of transient data
24122 strucutres when not required.
24124 * cs-parser.jay: Adjust for new changes.
24126 2001-11-11 Miguel de Icaza <miguel@ximian.com>
24128 * enum.cs (Enum.Populate): If there is a failure during
24131 * cs-parser.jay (opt_enum_base): we used to catch type errors
24132 here, but this is really incorrect. The type error should be
24133 catched during semantic analysis.
24135 2001-12-11 Ravi Pratap <ravi@ximian.com>
24137 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
24138 current_local_parameters as expected since I, in my stupidity, had forgotten
24141 * attribute.cs (GetValidPlaces): Fix stupid bug.
24143 * class.cs (Method::Emit): Perform check on applicability of attributes.
24145 (Constructor::Emit): Ditto.
24147 (Field::Emit): Ditto.
24149 (Field.Location): Store location information.
24151 (Property, Event, Indexer, Operator): Ditto.
24153 * cs-parser.jay (field_declaration): Pass in location for each field.
24155 * ../errors/cs0592.cs : Add.
24157 2001-11-12 Ravi Pratap <ravi@ximian.com>
24159 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
24161 (InitCoreTypes): Update accordingly.
24163 (RegisterAttrType, LookupAttr): Implement.
24165 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
24166 info about the same.
24168 (Resolve): Update to populate the above as necessary.
24170 (Error592): Helper.
24172 (GetValidPlaces): Helper to the above.
24174 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
24176 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
24178 2001-11-12 Ravi Pratap <ravi@ximian.com>
24180 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
24182 * ../errors/cs0617.cs : Add.
24184 2001-11-11 Ravi Pratap <ravi@ximian.com>
24186 * enum.cs (Emit): Rename to Populate to be more consistent with what
24187 we expect it to do and when exactly it is called.
24189 * class.cs, rootcontext.cs : Update accordingly.
24191 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
24192 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
24194 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
24196 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24197 of a fieldinfo using the above, when dealing with a FieldBuilder.
24199 2001-11-10 Ravi Pratap <ravi@ximian.com>
24201 * ../errors/cs0031.cs : Add.
24203 * ../errors/cs1008.cs : Add.
24205 * ../errrors/cs0543.cs : Add.
24207 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
24210 (FindMembers): Implement.
24212 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
24213 enums and delegates too.
24215 (enum_types): Rename to builder_to_enum.
24217 (delegate_types): Rename to builder_to_delegate.
24219 * delegate.cs (FindMembers): Implement.
24221 2001-11-09 Ravi Pratap <ravi@ximian.com>
24223 * typemanager.cs (IsEnumType): Implement.
24225 * enum.cs (Emit): Re-write parts to account for the underlying type
24226 better and perform checking etc.
24228 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
24229 of the underlying type.
24231 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24234 * enum.cs (error31): Helper to report error #31.
24236 * cs-parser.jay (enum_declaration): Store location of each member too.
24238 * enum.cs (member_to_location): New hashtable.
24240 (AddEnumMember): Update location hashtable.
24242 (Emit): Use the location of each member while reporting errors.
24244 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24246 * cs-parser.jay: A for_initializer if is a
24247 local_variable_declaration really ammount to have an implicit
24248 block with the variable declaration and no initializer for for.
24250 * statement.cs (For.Emit): Cope with null initializers.
24252 This fixes the infinite loop on for initializers.
24254 2001-11-08 Miguel de Icaza <miguel@ximian.com>
24256 * enum.cs: More cleanup.
24258 * ecore.cs: Remove dead code.
24260 * class.cs (Property.Emit): More simplification.
24261 (Event.Emit): ditto.
24263 Reworked to have less levels of indentation.
24265 2001-11-08 Ravi Pratap <ravi@ximian.com>
24267 * class.cs (Property): Emit attributes.
24277 * enum.cs (Emit): Ditto.
24279 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
24282 * class.cs (Field, Event, etc.): Move attribute generation into the
24283 Emit method everywhere.
24285 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
24286 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
24287 as we had no way of defining nested enums !
24289 * rootcontext.cs : Adjust code accordingly.
24291 * typemanager.cs (AddEnumType): To keep track of enum types separately.
24293 2001-11-07 Ravi Pratap <ravi@ximian.com>
24295 * expression.cs (EvalConstantExpression): Move into ecore.cs
24297 * enum.cs (Enum): Rename some members and make them public and readonly
24298 according to our convention.
24300 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24303 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
24305 (Enum::Emit): Write a simple version for now which doesn't try to compute
24306 expressions. I shall modify this to be more robust in just a while.
24308 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
24310 (TypeContainer::CloseType): Create the Enum types too.
24312 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
24314 * expression.cs (EvalConstantExpression): Get rid of completely.
24316 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
24317 user-defined values and other cases.
24319 (IsValidEnumLiteral): Helper function.
24321 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
24322 out there in the case we had a literal FieldExpr.
24324 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
24326 (Literalize): Revamp a bit to take two arguments.
24328 (EnumLiteral): New class which derives from Literal to wrap enum literals.
24330 2001-11-06 Ravi Pratap <ravi@ximian.com>
24332 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
24334 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
24336 (Resolve): Use the above to ensure we have proper initializers.
24338 2001-11-05 Ravi Pratap <ravi@ximian.com>
24340 * expression.cs (Expression::EvalConstantExpression): New method to
24341 evaluate constant expressions.
24343 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
24345 2001-11-07 Miguel de Icaza <miguel@ximian.com>
24347 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
24350 (Binary.ResolveOperator): Handle operator != (object a, object b)
24351 and operator == (object a, object b);
24353 (Binary.DoNumericPromotions): Indicate whether the numeric
24354 promotion was possible.
24356 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
24359 Made the ArrayAccess implement interface IAssignMethod instead of
24360 IStackStore as the order in which arguments are passed reflects
24363 * assign.cs: Instead of using expr.ExprClass to select the way of
24364 assinging, probe for the IStackStore/IAssignMethod interfaces.
24366 * typemanager.cs: Load InitializeArray definition.
24368 * rootcontext.cs (RootContext.MakeStaticData): Used to define
24369 static data that can be used to initialize arrays.
24371 2001-11-05 Miguel de Icaza <miguel@ximian.com>
24373 * expression.cs: Handle operator== and operator!= for booleans.
24375 (Conditioal.Reduce): Implement reducer for the ?: operator.
24377 (Conditional.Resolve): Implement dead code elimination.
24379 (Binary.Resolve): Catch string literals and return a new
24380 concatenated string.
24382 (Unary.Reduce): Implement reduction of unary expressions.
24384 * ecore.cs: Split out the expression core handling here.
24386 (Expression.Reduce): New method used to perform constant folding
24387 and CSE. This is needed to support constant-expressions.
24389 * statement.cs (Statement.EmitBoolExpression): Pass true and false
24390 targets, and optimize for !x.
24392 2001-11-04 Ravi Pratap <ravi@ximian.com>
24394 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
24395 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
24396 set custom atttributes.
24398 * literal.cs (Literal::GetValue): New abstract method to return the actual
24399 value of the literal, cast as an object.
24401 (*Literal): Implement GetValue method.
24403 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
24404 expressions to the arraylist but objects of type Argument.
24406 * class.cs (TypeContainer::Emit): Emit our attributes too.
24408 (Method::Emit, Constructor::Emit): Ditto.
24410 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
24411 to be ignoring earlier.
24413 2001-11-03 Ravi Pratap <ravi@ximian.com>
24415 * attribute.cs (AttributeSection::Define): Implement to do the business
24416 of constructing a CustomAttributeBuilder.
24418 (Attribute): New trivial class. Increases readability of code.
24420 * cs-parser.jay : Update accordingly.
24422 (positional_argument_list, named_argument_list, named_argument): New rules
24424 (attribute_arguments): Use the above so that we are more correct.
24426 2001-11-02 Ravi Pratap <ravi@ximian.com>
24428 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
24429 to perform all checks for a method with a params parameter.
24431 (Invocation::OverloadResolve): Update to use the above method and therefore
24432 cope correctly with params method invocations.
24434 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
24437 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
24438 constructors in our parent too because we can't afford to miss out on
24441 * attribute.cs (AttributeSection): New name for the class Attribute
24443 Other trivial changes to improve readability.
24445 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
24446 use the new class names.
24448 2001-11-01 Ravi Pratap <ravi@ximian.com>
24450 * class.cs (Method::Define): Complete definition for params types too
24452 (Indexer::Define): Ditto.
24454 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
24455 Cope everywhere with a request for info about the array parameter.
24457 2001-11-01 Ravi Pratap <ravi@ximian.com>
24459 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24461 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24462 local_variable_type to extract the string corresponding to the type.
24464 (local_variable_type): Fixup the action to use the new helper method.
24466 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24469 * expression.cs : Clean out code which uses the above.
24471 2001-10-31 Ravi Pratap <ravi@ximian.com>
24473 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24474 and bale out if necessary by returning a false.
24476 (RegisterProperty): Ditto.
24478 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24479 and print out appropriate error messages.
24481 * interface.cs (everywhere): Ditto.
24483 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24484 location to constructor.
24486 * class.cs (Property, Event, Indexer): Update accordingly.
24488 * ../errors/cs111.cs : Added.
24490 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24491 of a method, as laid down by the spec.
24493 (Invocation::OverloadResolve): Use the above method.
24495 2001-10-31 Ravi Pratap <ravi@ximian.com>
24497 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24498 now take a TypeContainer and a Parameters object.
24500 (ParameterData): Modify return type of ParameterModifier method to be
24501 Parameter.Modifier and not a string.
24503 (ReflectionParameters, InternalParameters): Update accordingly.
24505 * expression.cs (Argument::GetParameterModifier): Same here.
24507 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24508 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24509 symbol in it at all so maybe this is only for now.
24511 2001-10-30 Ravi Pratap <ravi@ximian.com>
24513 * support.cs (InternalParameters): Constructor now takes an extra argument
24514 which is the actual Parameters class.
24516 (ParameterDesc): Update to provide info on ref/out modifiers.
24518 * class.cs (everywhere): Update call to InternalParameters to pass in
24519 the second argument too.
24521 * support.cs (ParameterData): Add ParameterModifier, which is a method
24522 to return the modifier info [ref/out etc]
24524 (InternalParameters, ReflectionParameters): Implement the above.
24526 * expression.cs (Argument::ParameterModifier): Similar function to return
24527 info about the argument's modifiers.
24529 (Invocation::OverloadResolve): Update to take into account matching modifiers
24532 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24533 a new SetFormalParameters object which we pass to InternalParameters.
24535 2001-10-30 Ravi Pratap <ravi@ximian.com>
24537 * expression.cs (NewArray): Merge into the ArrayCreation class.
24539 2001-10-29 Ravi Pratap <ravi@ximian.com>
24541 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24542 NewUserdefinedArray into one as there wasn't much of a use in having
24545 * expression.cs (Argument): Change field's name to ArgType from Type.
24547 (Type): New readonly property which returns the proper type, taking into
24548 account ref/out modifiers.
24550 (everywhere): Adjust code accordingly for the above.
24552 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24553 whether we are emitting for a ref or out parameter.
24555 * expression.cs (Argument::Emit): Use the above field to set the state.
24557 (LocalVariableReference::Emit): Update to honour the flag and emit the
24560 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24562 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24564 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24566 (ReflectionParameters, InternalParameters): Implement the above method.
24568 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24571 (Invocation::FullMethodDesc): Ditto.
24573 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24575 * cs-parser.jay: Add extra production for the second form of array
24578 * expression.cs (ArrayCreation): Update to reflect the above
24581 * Small changes to prepare for Array initialization.
24583 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24585 * typemanager.cs (ImplementsInterface): interface might be null;
24586 Deal with this problem;
24588 Also, we do store negative hits on the cache (null values), so use
24589 this instead of calling t.GetInterfaces on the type everytime.
24591 2001-10-28 Ravi Pratap <ravi@ximian.com>
24593 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24595 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24596 split functionality out into different classes.
24598 (New::FormArrayType): Move into NewBuiltinArray.
24600 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24603 (NewBuiltinArray): New class to handle creation of built-in arrays.
24605 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24606 account creation of one-dimensional arrays.
24608 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24610 (NewUserdefinedArray::DoResolve): Implement.
24612 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24614 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24615 we maintain inside the TypeManager. This is necessary to perform lookups on the
24618 (LookupType): Update to perform GetType on the module builders too.
24620 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24622 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24624 2001-10-23 Ravi Pratap <ravi@ximian.com>
24626 * expression.cs (New::DoResolve): Implement guts of array creation.
24628 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24630 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24632 * expression.cs: Fix bug I introduced lsat night that broke
24635 (Expression.Resolve): Report a 246 error (can not resolve name)
24636 if we find a SimpleName in the stream.
24638 (Expression.ResolveLValue): Ditto.
24640 (Expression.ResolveWithSimpleName): This function is a variant of
24641 ResolveName, this one allows SimpleNames to be returned without a
24642 warning. The only consumer of SimpleNames is MemberAccess
24644 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24646 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24647 might arrive here. I have my doubts that this is correct.
24649 * statement.cs (Lock): Implement lock statement.
24651 * cs-parser.jay: Small fixes to support `lock' and `using'
24653 * cs-tokenizer.cs: Remove extra space
24655 * driver.cs: New flag --checked, allows to turn on integer math
24658 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24659 Threading.Monitor.Exit
24661 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24663 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24664 Expression Class to be IndexerAccess.
24666 Notice that Indexer::DoResolve sets the eclass to Value.
24668 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24670 * class.cs (TypeContainer::Emit): Emit code for indexers.
24672 * assign.cs (IAssignMethod): New interface implemented by Indexers
24673 and Properties for handling assignment.
24675 (Assign::Emit): Simplify and reuse code.
24677 * expression.cs (IndexerAccess, PropertyExpr): Implement
24678 IAssignMethod, clean up old code.
24680 2001-10-22 Ravi Pratap <ravi@ximian.com>
24682 * typemanager.cs (ImplementsInterface): New method to determine if a type
24683 implements a given interface. Provides a nice cache too.
24685 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24688 (ConvertReferenceExplicit): Ditto.
24690 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24691 various methods, with correct names etc.
24693 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24694 Operator.UnaryNegation.
24696 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24697 we have a unary plus or minus operator.
24699 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24702 * everywhere : update accordingly.
24704 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24707 * class.cs (Method::Define): For the case where we are implementing a method
24708 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24709 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24711 2001-10-21 Ravi Pratap <ravi@ximian.com>
24713 * interface.cs (FindMembers): Implement to work around S.R.E
24716 * typemanager.cs (IsInterfaceType): Implement.
24718 (FindMembers): Update to handle interface types too.
24720 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24721 use IsAssignableFrom as that is not correct - it doesn't work.
24723 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24724 and accordingly override EmitStatement.
24726 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24727 using the correct logic :-)
24729 2001-10-19 Ravi Pratap <ravi@ximian.com>
24731 * ../errors/cs-11.cs : Add to demonstrate error -11
24733 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24735 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24736 then pass this as a hint to ResolveLValue.
24738 * expression.cs (FieldExpr): Add Location information
24740 (FieldExpr::LValueResolve): Report assignment to readonly
24743 (Expression::ExprClassFromMemberInfo): Pass location information.
24745 (Expression::ResolveLValue): Add new method that resolves an
24748 (Expression::DoResolveLValue): Default invocation calls
24751 (Indexers): New class used to keep track of indexers in a given
24754 (IStackStore): Renamed from LValue, as it did not really describe
24755 what this did. Also ResolveLValue is gone from this interface and
24756 now is part of Expression.
24758 (ElementAccess): Depending on the element access type
24760 * typemanager.cs: Add `indexer_name_type' as a Core type
24761 (System.Runtime.CompilerServices.IndexerNameAttribute)
24763 * statement.cs (Goto): Take a location.
24765 2001-10-18 Ravi Pratap <ravi@ximian.com>
24767 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24768 if two delegates are compatible.
24770 (NewDelegate::DoResolve): Update to take care of the case when
24771 we instantiate a delegate from another delegate.
24773 * typemanager.cs (FindMembers): Don't even try to look up members
24774 of Delegate types for now.
24776 2001-10-18 Ravi Pratap <ravi@ximian.com>
24778 * delegate.cs (NewDelegate): New class to take care of delegate
24781 * expression.cs (New): Split the delegate related code out into
24782 the NewDelegate class.
24784 * delegate.cs (DelegateInvocation): New class to handle delegate
24787 * expression.cs (Invocation): Split out delegate related code into
24788 the DelegateInvocation class.
24790 2001-10-17 Ravi Pratap <ravi@ximian.com>
24792 * expression.cs (New::DoResolve): Implement delegate creation fully
24793 and according to the spec.
24795 (New::DoEmit): Update to handle delegates differently.
24797 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24798 because of which we were printing out arguments in reverse order !
24800 * delegate.cs (VerifyMethod): Implement to check if the given method
24801 matches the delegate.
24803 (FullDelegateDesc): Implement.
24805 (VerifyApplicability): Implement.
24807 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24808 delegate invocations too.
24810 (Invocation::Emit): Ditto.
24812 * ../errors/cs1593.cs : Added.
24814 * ../errors/cs1594.cs : Added.
24816 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24818 2001-10-16 Ravi Pratap <ravi@ximian.com>
24820 * typemanager.cs (intptr_type): Core type for System.IntPtr
24822 (InitCoreTypes): Update for the same.
24824 (iasyncresult_type, asynccallback_type): Ditto.
24826 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24829 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24832 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24833 the builders for the 4 members of a delegate type :-)
24835 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24838 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24840 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24842 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24844 * statement.cs (Break::Emit): Implement.
24845 (Continue::Emit): Implement.
24847 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24848 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24849 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24850 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24853 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24854 properties that track the label for the current loop (begin of the
24855 loop and end of the loop).
24857 2001-10-15 Ravi Pratap <ravi@ximian.com>
24859 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24860 use of emitting anything at all.
24862 * class.cs, rootcontext.cs : Get rid of calls to the same.
24864 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24866 (Populate): Define the constructor correctly and set the implementation
24869 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24872 (AddDelegateType): Implement.
24874 (IsDelegateType): Implement helper method.
24876 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24878 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24879 and accordingly handle it.
24881 * delegate.cs (Populate): Take TypeContainer argument.
24882 Implement bits to define the Invoke method. However, I still haven't figured out
24883 how to take care of the native int bit :-(
24885 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24886 Qualify the name of the delegate, not its return type !
24888 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24891 (StandardConversionExists): Checking for array types turns out to be recursive.
24893 (ConvertReferenceExplicit): Implement array conversion.
24895 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24897 2001-10-12 Ravi Pratap <ravi@ximian.com>
24899 * cs-parser.jay (delegate_declaration): Store the fully qualified
24900 name as it is a type declaration.
24902 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24905 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24906 as TypeContainer::DefineType.
24908 (Populate): Method in which all the definition of the various methods (Invoke)
24911 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24914 (CloseDelegate): Finally creates the delegate.
24916 * class.cs (TypeContainer::DefineType): Update to define delegates.
24917 (Populate, Emit and CloseType): Do the same thing here too.
24919 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24920 delegates in all these operations.
24922 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24924 * expression.cs: LocalTemporary: a new expression used to
24925 reference a temporary that has been created.
24927 * assign.cs: Handle PropertyAccess back here, so that we can
24928 provide the proper semantic access to properties.
24930 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24931 a few more explicit conversions.
24933 * modifiers.cs: `NEW' modifier maps to HideBySig.
24935 * expression.cs (PropertyExpr): Make this into an
24936 ExpressionStatement, and support the EmitStatement code path.
24938 Perform get/set error checking, clean up the interface.
24940 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24941 them into toplevel access objects.
24943 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24945 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24948 * typemanager.cs: Keep track here of our PropertyBuilders again to
24949 work around lameness in SRE.
24951 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24953 * expression.cs (LValue::LValueResolve): New method in the
24954 interface, used to perform a second resolution pass for LValues.
24956 (This::DoResolve): Catch the use of this in static methods.
24958 (This::LValueResolve): Implement.
24960 (This::Store): Remove warning, assigning to `this' in structures
24963 (Invocation::Emit): Deal with invocation of
24964 methods on value types. We need to pass the address to structure
24965 methods rather than the object itself. (The equivalent code to
24966 emit "this" for structures leaves the entire structure on the
24967 stack instead of a pointer to it).
24969 (ParameterReference::DoResolve): Compute the real index for the
24970 argument based on whether the method takes or not a `this' pointer
24971 (ie, the method is static).
24973 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24974 value types returned from functions when we need to invoke a
24975 method on the sturcture.
24978 2001-10-11 Ravi Pratap <ravi@ximian.com>
24980 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24981 defining the type in the Modulebuilder or Typebuilder. This is to take
24982 care of nested types which need to be defined on the TypeBuilder using
24983 DefineNestedMethod.
24985 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24986 methods in RootContext, only ported to be part of TypeContainer.
24988 (TypeContainer::GetInterfaceOrClass): Ditto.
24990 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24992 * interface.cs (Interface::DefineInterface): New method. Does exactly
24993 what RootContext.CreateInterface did earlier, only it takes care of nested types
24996 (Interface::GetInterfaces): Move from RootContext here and port.
24998 (Interface::GetInterfaceByName): Same here.
25000 * rootcontext.cs (ResolveTree): Re-write.
25002 (PopulateTypes): Re-write.
25004 * class.cs (TypeContainer::Populate): Populate nested types too.
25005 (TypeContainer::Emit): Emit nested members too.
25007 * typemanager.cs (AddUserType): Do not make use of the FullName property,
25008 instead just use the name argument passed in as it is already fully
25011 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
25012 to TypeContainer mapping to see if a type is user-defined.
25014 * class.cs (TypeContainer::CloseType): Implement.
25016 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
25017 the default constructor.
25019 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
25022 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
25024 * interface.cs (CloseType): Create the type here.
25026 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
25029 Remove all the methods which are now in TypeContainer.
25031 2001-10-10 Ravi Pratap <ravi@ximian.com>
25033 * delegate.cs (Define): Re-write bits to define the delegate
25036 2001-10-10 Miguel de Icaza <miguel@ximian.com>
25038 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
25040 * expression.cs (ImplicitReferenceConversion): handle null as well
25041 as a source to convert to any reference type.
25043 * statement.cs (Return): Perform any implicit conversions to
25044 expected return type.
25046 Validate use of return statement.
25048 * codegen.cs (EmitContext): Pass the expected return type here.
25050 * class.cs (Method, Constructor, Property): Pass expected return
25051 type to EmitContext.
25053 2001-10-09 Miguel de Icaza <miguel@ximian.com>
25055 * expression.cs: Make DoResolve take an EmitContext instead of a
25058 Replaced `l' and `location' for `loc', for consistency.
25060 (Error, Warning): Remove unneeded Tc argument.
25062 * assign.cs, literal.cs, constant.cs: Update to new calling
25065 * codegen.cs: EmitContext now contains a flag indicating whether
25066 code is being generated in a static method or not.
25068 * cs-parser.jay: DecomposeQI, new function that replaces the old
25069 QualifiedIdentifier. Now we always decompose the assembled
25070 strings from qualified_identifier productions into a group of
25073 2001-10-08 Miguel de Icaza <miguel@ximian.com>
25075 * rootcontext.cs: Deal with field-less struct types correctly now
25076 by passing the size option to Define Type.
25078 * class.cs: Removed hack that created one static field.
25080 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25082 * statement.cs: Moved most of the code generation here.
25084 2001-10-09 Ravi Pratap <ravi@ximian.com>
25086 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
25089 (ElementAccess): Remove useless bits for now - keep checks as the spec
25092 2001-10-08 Ravi Pratap <ravi@ximian.com>
25094 * expression.cs (ElementAccess::DoResolve): Remove my crap code
25095 and start performing checks according to the spec.
25097 2001-10-07 Ravi Pratap <ravi@ximian.com>
25099 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
25100 rank_specifiers instead.
25102 (rank_specifiers): Change the order in which the rank specifiers are stored
25104 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
25106 * expression.cs (ElementAccess): Implement the LValue interface too.
25108 2001-10-06 Ravi Pratap <ravi@ximian.com>
25110 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
25111 except that user defined conversions are not included.
25113 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
25114 perform the conversion of the return type, if necessary.
25116 (New::DoResolve): Check whether we are creating an array or an object
25117 and accordingly do the needful.
25119 (New::Emit): Same here.
25121 (New::DoResolve): Implement guts of array creation.
25123 (New::FormLookupType): Helper function.
25125 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25127 * codegen.cs: Removed most of the code generation here, and move the
25128 corresponding code generation bits to the statement classes.
25130 Added support for try/catch/finalize and throw.
25132 * cs-parser.jay: Added support for try/catch/finalize.
25134 * class.cs: Catch static methods having the flags override,
25135 virtual or abstract.
25137 * expression.cs (UserCast): This user cast was not really doing
25138 what it was supposed to do. Which is to be born in fully resolved
25139 state. Parts of the resolution were being performed at Emit time!
25143 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25145 * expression.cs: Implicity convert the result from UserCast.
25147 2001-10-05 Ravi Pratap <ravi@ximian.com>
25149 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
25150 prevented it from working correctly.
25152 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
25153 merely ConvertImplicit.
25155 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25157 * typemanager.cs: Make the LookupTypeContainer function static,
25158 and not per-instance.
25160 * class.cs: Make static FindMembers (the one that takes a Type
25163 * codegen.cs: Add EmitForeach here.
25165 * cs-parser.jay: Make foreach a toplevel object instead of the
25166 inline expansion, as we need to perform semantic analysis on it.
25168 2001-10-05 Ravi Pratap <ravi@ximian.com>
25170 * expression.cs (Expression::ImplicitUserConversion): Rename to
25171 UserDefinedConversion.
25173 (Expression::UserDefinedConversion): Take an extra argument specifying
25174 whether we look for explicit user conversions too.
25176 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
25178 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
25180 (ExplicitUserConversion): Make it a call to UserDefinedConversion
25181 with the appropriate arguments.
25183 * cs-parser.jay (cast_expression): Record location too.
25185 * expression.cs (Cast): Record location info.
25187 (Expression::ConvertExplicit): Take location argument.
25189 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
25190 to determine if we are doing explicit conversions.
25192 (UserCast::Emit): Update accordingly.
25194 (Expression::ConvertExplicit): Report an error if everything fails.
25196 * ../errors/cs0030.cs : Add.
25198 2001-10-04 Miguel de Icaza <miguel@ximian.com>
25200 * modifiers.cs: If the ABSTRACT keyword is present, also set the
25201 virtual and newslot bits.
25203 * class.cs (TypeContainer::RegisterRequiredImplementations):
25204 Record methods we need.
25206 (TypeContainer::MakeKey): Helper function to make keys for
25207 MethodBases, since the Methodbase key is useless.
25209 (TypeContainer::Populate): Call RegisterRequiredImplementations
25210 before defining the methods.
25212 Create a mapping for method_builders_to_methods ahead of time
25213 instead of inside a tight loop.
25215 (::RequireMethods): Accept an object as the data to set into the
25216 hashtable so we can report interface vs abstract method mismatch.
25218 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25220 * report.cs: Make all of it static.
25222 * rootcontext.cs: Drop object_type and value_type computations, as
25223 we have those in the TypeManager anyways.
25225 Drop report instance variable too, now it is a global.
25227 * driver.cs: Use try/catch on command line handling.
25229 Add --probe option to debug the error reporting system with a test
25232 * report.cs: Add support for exiting program when a probe
25233 condition is reached.
25235 2001-10-03 Ravi Pratap <ravi@ximian.com>
25237 * expression.cs (Binary::DoNumericPromotions): Fix the case when
25238 we do a forcible conversion regardless of type, to check if
25239 ForceConversion returns a null.
25241 (Binary::error19): Use location to report error.
25243 (Unary::error23): Use location here too.
25245 * ../errors/cs0019.cs : Check in.
25247 * ../errors/cs0023.cs : Check in.
25249 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
25250 case of a non-null MethodInfo object with a length of 0 !
25252 (Binary::ResolveOperator): Flag error if overload resolution fails to find
25253 an applicable member - according to the spec :-)
25254 Also fix logic to find members in base types.
25256 (Unary::ResolveOperator): Same here.
25258 (Unary::report23): Change name to error23 and make first argument a TypeContainer
25259 as I was getting thoroughly confused between this and error19 :-)
25261 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
25262 (::FindMostEncompassedType): Implement.
25263 (::FindMostEncompassingType): Implement.
25264 (::StandardConversionExists): Implement.
25266 (UserImplicitCast): Re-vamp. We now need info about most specific
25267 source and target types so that we can do the necessary conversions.
25269 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
25270 mathematical union with no duplicates.
25272 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25274 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
25275 in order from base classes to child classes, so that we can in
25276 child classes look up in our parent for method names and
25277 attributes (required for handling abstract, virtual, new, override
25278 constructs: we need to instrospect our base class, and if we dont
25279 populate the classes in order, the introspection might be
25280 incorrect. For example, a method could query its parent before
25281 the parent has any methods and would determine that the parent has
25282 no abstract methods (while it could have had them)).
25284 (RootContext::CreateType): Record the order in which we define the
25287 2001-10-02 Miguel de Icaza <miguel@ximian.com>
25289 * class.cs (TypeContainer::Populate): Also method definitions can
25290 fail now, keep track of this.
25292 (TypeContainer::FindMembers): Implement support for
25293 DeclaredOnly/noDeclaredOnly flag.
25295 (Constructor::Emit) Return the ConstructorBuilder.
25297 (Method::Emit) Return the MethodBuilder.
25298 Check for abstract or virtual methods to be public.
25300 * rootcontext.cs (RootContext::CreateType): Register all the
25301 abstract methods required for the class to be complete and the
25302 interface methods that must be implemented.
25304 * cs-parser.jay: Report error 501 (method requires body if it is
25305 not marked abstract or extern).
25307 * expression.cs (TypeOf::Emit): Implement.
25309 * typemanager.cs: runtime_handle_type, new global type.
25311 * class.cs (Property::Emit): Generate code for properties.
25313 2001-10-02 Ravi Pratap <ravi@ximian.com>
25315 * expression.cs (Unary::ResolveOperator): Find operators on base type
25316 too - we now conform exactly to the spec.
25318 (Binary::ResolveOperator): Same here.
25320 * class.cs (Operator::Define): Fix minor quirk in the tests.
25322 * ../errors/cs0215.cs : Added.
25324 * ../errors/cs0556.cs : Added.
25326 * ../errors/cs0555.cs : Added.
25328 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25330 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
25331 single integer which is really efficient
25333 2001-10-01 Ravi Pratap <ravi@ximian.com>
25335 * expression.cs (Expression::ImplicitUserConversion): Use location
25336 even in the case when we are examining True operators.
25338 * class.cs (Operator::Define): Perform extensive checks to conform
25339 with the rules for operator overloading in the spec.
25341 * expression.cs (Expression::ImplicitReferenceConversion): Implement
25342 some of the other conversions mentioned in the spec.
25344 * typemanager.cs (array_type): New static member for the System.Array built-in
25347 (cloneable_interface): For System.ICloneable interface.
25349 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
25350 we start resolving the tree and populating types.
25352 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
25354 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25356 * expression.cs (Expression::ExprClassFromMemberInfo,
25357 Expression::Literalize): Create literal expressions from
25358 FieldInfos which are literals.
25360 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
25361 type casts, because they were wrong. The test suite in tests
25364 (ImplicitNumericConversion): ushort to ulong requires a widening
25367 Int32 constant to long requires widening cast as well.
25369 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
25370 for integers because the type on the stack is not i4.
25372 2001-09-30 Miguel de Icaza <miguel@ximian.com>
25374 * expression.cs (report118): require location argument.
25376 * parameter.cs: Do not dereference potential null value.
25378 * class.cs: Catch methods that lack the `new' keyword when
25379 overriding a name. Report warnings when `new' is used without
25380 anything being there to override.
25382 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
25384 * class.cs: Only add constructor to hashtable if it is non-null
25385 (as now constructors can fail on define).
25387 (TypeManager, Class, Struct): Take location arguments.
25389 Catch field instance initialization in structs as errors.
25391 accepting_filter: a new filter for FindMembers that is static so
25392 that we dont create an instance per invocation.
25394 (Constructor::Define): Catch errors where a struct constructor is
25397 * cs-parser.jay: Pass location information for various new
25400 * delegate.cs (Delegate): take a location argument.
25402 * driver.cs: Do not call EmitCode if there were problesm in the
25403 Definition of the types, as many Builders wont be there.
25405 * decl.cs (Decl::Decl): Require a location argument.
25407 * cs-tokenizer.cs: Handle properly hex constants that can not fit
25408 into integers, and find the most appropiate integer for it.
25410 * literal.cs: Implement ULongLiteral.
25412 * rootcontext.cs: Provide better information about the location of
25413 failure when CreateType fails.
25415 2001-09-29 Miguel de Icaza <miguel@ximian.com>
25417 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
25420 * expression.cs (Binary::CheckShiftArguments): Add missing type
25422 (Binary::ResolveOperator): Add type to the logical and and logical
25423 or, Bitwise And/Or and Exclusive Or code paths, it was missing
25426 (Binary::DoNumericPromotions): In the case where either argument
25427 is ulong (and most signed types combined with ulong cause an
25428 error) perform implicit integer constant conversions as well.
25430 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25432 * expression.cs (UserImplicitCast): Method should always be
25434 (Invocation::BetterConversion): Simplified test for IntLiteral.
25436 (Expression::ImplicitNumericConversion): Split this routine out.
25437 Put the code that performs implicit constant integer conversions
25440 (Expression::Resolve): Become a wrapper around DoResolve so we can
25441 check eclass and type being set after resolve.
25443 (Invocation::Badness): Remove this dead function
25445 (Binary::ResolveOperator): Do not compute the expensive argumnets
25446 unless we have a union for it.
25448 (Probe::Emit): Is needs to do an isinst and then
25449 compare against null.
25451 (::CanConvert): Added Location argument. If the Location argument
25452 is null (Location.Null), then we do not report errors. This is
25453 used by the `probe' mechanism of the Explicit conversion. We do
25454 not want to generate an error for something that the user
25455 explicitly requested to be casted. But the pipeline for an
25456 explicit cast first tests for potential implicit casts.
25458 So for now, if the Location is null, it means `Probe only' to
25459 avoid adding another argument. Might have to revise this
25462 (ClassCast): New class used to type cast objects into arbitrary
25463 classes (used in Explicit Reference Conversions).
25465 Implement `as' as well.
25467 Reverted all the patches from Ravi below: they were broken:
25469 * The use of `level' as a mechanism to stop recursive
25470 invocations is wrong. That was there just to catch the
25471 bug with a strack trace but not as a way of addressing
25474 To fix the problem we have to *understand* what is going
25475 on and the interactions and come up with a plan, not
25476 just get things going.
25478 * The use of the type conversion cache that I proposed
25479 last night had an open topic: How does this work across
25480 protection domains. A user defined conversion might not
25481 be public in the location where we are applying the
25482 conversion, a different conversion might be selected
25483 (ie, private A->B (better) but public B->A (worse),
25484 inside A, A->B applies, but outside it, B->A will
25487 * On top of that (ie, even if the above is solved),
25488 conversions in a cache need to be abstract. Ie, `To
25489 convert from an Int to a Short use an OpcodeCast', not
25490 `To convert from an Int to a Short use the OpcodeCast on
25491 the variable 5' (which is what this patch was doing).
25493 2001-09-28 Ravi Pratap <ravi@ximian.com>
25495 * expression.cs (Invocation::ConversionExists): Re-write to use
25496 the conversion cache
25498 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25499 cache all conversions done, not just user-defined ones.
25501 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25502 to determine if a conversion exists instead of acutually trying to
25503 perform the conversion. It's faster too.
25505 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25506 and only then attempt the implicit conversion.
25508 2001-09-28 Ravi Pratap <ravi@ximian.com>
25510 * expression.cs (ConvertImplicit): Use a cache for conversions
25511 already found. Check level of recursion and bail out if necessary.
25513 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25515 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25516 Export standard methods that we expect for string operations.
25518 * statement.cs (Block::UsageWarning): Track usage of variables and
25519 report the errors for not used variables.
25521 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25524 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25526 * codegen.cs: remove unnneded code
25528 * expression.cs: Removed BuiltinTypeAccess class
25530 Fix the order in which implicit conversions are
25533 The previous fixed dropped support for boxed conversions (adding a
25534 test to the test suite now)
25536 (UserImplicitCast::CanConvert): Remove test for source being null,
25537 that code is broken. We should not feed a null to begin with, if
25538 we do, then we should track the bug where the problem originates
25539 and not try to cover it up here.
25541 Return a resolved expression of type UserImplicitCast on success
25542 rather than true/false. Ravi: this is what I was talking about,
25543 the pattern is to use a static method as a "constructor" for
25546 Also, do not create arguments until the very last minute,
25547 otherwise we always create the arguments even for lookups that
25548 will never be performed.
25550 (UserImplicitCast::Resolve): Eliminate, objects of type
25551 UserImplicitCast are born in a fully resolved state.
25553 * typemanager.cs (InitCoreTypes): Init also value_type
25554 (System.ValueType).
25556 * expression.cs (Cast::Resolve): First resolve the child expression.
25558 (LValue): Add new method AddressOf to be used by
25561 Change the argument of Store to take an EmitContext instead of an
25562 ILGenerator, because things like FieldExpr need to be able to call
25563 their children expression to generate the instance code.
25565 (Expression::Error, Expression::Warning): Sugar functions for
25568 (Expression::MemberLookup): Accept a TypeContainer instead of a
25569 Report as the first argument.
25571 (Expression::ResolvePrimary): Killed. I still want to improve
25572 this as currently the code is just not right.
25574 (Expression::ResolveMemberAccess): Simplify, but it is still
25577 (Unary::Resolve): Catch errors in AddressOf operators.
25579 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25580 index to a byte for the short-version, or the compiler will choose
25581 the wrong Emit call, which generates the wrong data.
25583 (ParameterReference::Emit, ::Store): same.
25585 (FieldExpr::AddressOf): Implement.
25587 * typemanager.cs: TypeManager: made public variable instead of
25590 * driver.cs: document --fatal.
25592 * report.cs (ErrorMessage, WarningMessage): new names for the old
25593 Error and Warning classes.
25595 * cs-parser.jay (member_access): Turn built-in access to types
25596 into a normal simplename
25598 2001-09-27 Ravi Pratap <ravi@ximian.com>
25600 * expression.cs (Invocation::BetterConversion): Fix to cope
25601 with q being null, since this was introducing a bug.
25603 * expression.cs (ConvertImplicit): Do built-in conversions first.
25605 2001-09-27 Ravi Pratap <ravi@ximian.com>
25607 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25609 2001-09-27 Ravi Pratap <ravi@ximian.com>
25611 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25612 I had introduced long ago (what's new ?).
25614 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25615 the work of all the checking.
25616 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25617 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25619 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25620 that is the right way.
25622 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25623 overloading resolution. Use everywhere instead of cutting and pasting code.
25625 (Binary::ResolveOperator): Use MakeUnionSet.
25627 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25628 we have to convert to bool types. Not complete yet.
25630 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25632 * typemanager.cs (TypeManager::CSharpName): support ushort.
25634 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25635 to provide an expression that performsn an implicit constant int
25636 conversion (section 6.1.6).
25637 (Expression::ConvertImplicitRequired): Reworked to include
25638 implicit constant expression conversions.
25640 (Expression::ConvertNumericExplicit): Finished.
25642 (Invocation::Emit): If InstanceExpression is null, then it means
25643 that we perform a call on this.
25645 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25647 * expression.cs (Unary::Emit): Remove some dead code.
25648 (Probe): Implement Resolve and Emit for `is'.
25649 (Expression::ConvertImplicitRequired): Attempt to do constant
25650 expression conversions here. Maybe should be moved to
25651 ConvertImplicit, but I am not sure.
25652 (Expression::ImplicitLongConstantConversionPossible,
25653 Expression::ImplicitIntConstantConversionPossible): New functions
25654 that tell whether is it possible to apply an implicit constant
25655 expression conversion.
25657 (ConvertNumericExplicit): Started work on explicit numeric
25660 * cs-parser.jay: Update operator constants.
25662 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25663 (Parameters::GetSignature): Hook up VerifyArgs here.
25664 (Parameters::VerifyArgs): Verifies that no two arguments have the
25667 * class.cs (Operator): Update the operator names to reflect the
25668 ones that the spec expects (as we are just stringizing the
25671 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25672 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25673 previous usage did only work for our methods.
25674 (Expression::ConvertImplicit): Handle decimal implicit numeric
25675 conversions as well.
25676 (Expression::InternalTypeConstructor): Used to invoke constructors
25677 on internal types for default promotions.
25679 (Unary::Emit): Implement special handling for the pre/post
25680 increment/decrement for overloaded operators, as they need to have
25681 the same semantics as the other operators.
25683 (Binary::ResolveOperator): ditto.
25684 (Invocation::ConversionExists): ditto.
25685 (UserImplicitCast::Resolve): ditto.
25687 2001-09-26 Ravi Pratap <ravi@ximian.com>
25689 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25690 operator, return after emitting body. Regression tests pass again !
25692 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25693 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25694 (Invocation::OverloadResolve): Ditto.
25695 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25697 * everywhere : update calls to the above methods accordingly.
25699 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25701 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25703 * expression.cs (ExpressionStatement): New base class used for
25704 expressions that can appear in statements, so that we can provide
25705 an alternate path to generate expression that do not leave a value
25708 (Expression::Emit, and all the derivatives): We no longer return
25709 whether a value is left on the stack or not. Every expression
25710 after being emitted leaves a single value on the stack.
25712 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25713 facilties of ExpressionStatement if possible.
25715 * cs-parser.jay: Update statement_expression.
25717 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25719 * driver.cs: Change the wording of message
25721 2001-09-25 Ravi Pratap <ravi@ximian.com>
25723 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25724 the type of the expression to the return type of the method if
25725 we have an overloaded operator match ! The regression tests pass again !
25726 (Unary::ResolveOperator): Ditto.
25728 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25729 to find "op_Implicit", not "implicit" ;-)
25730 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25731 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25733 * everywhere : Correct calls to the above accordingly.
25735 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25736 (ConvertImplicit): Do user-defined conversion if it exists.
25738 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25740 * assign.cs: track location.
25741 (Resolve): Use implicit conversions on assignment.
25743 * literal.cs: Oops. Not good, Emit of short access values should
25744 pass (Bytes) or the wrong argument will be selected.
25746 * expression.cs (Unary::Emit): Emit code for -expr.
25748 (Unary::ResolveOperator): Handle `Substract' for non-constants
25749 (substract from zero from the non-constants).
25750 Deal with Doubles as well.
25752 (Expression::ConvertImplicitRequired): New routine that reports an
25753 error if no implicit conversion exists.
25755 (Invocation::OverloadResolve): Store the converted implicit
25756 expressions if we make them
25758 2001-09-24 Ravi Pratap <ravi@ximian.com>
25760 * class.cs (ConstructorInitializer): Take a Location argument.
25761 (ConstructorBaseInitializer): Same here.
25762 (ConstructorThisInitializer): Same here.
25764 * cs-parser.jay : Update all calls accordingly.
25766 * expression.cs (Unary, Binary, New): Take location argument.
25767 Update accordingly everywhere.
25769 * cs-parser.jay : Update all calls to the above to take a location
25772 * class.cs : Ditto.
25774 2001-09-24 Ravi Pratap <ravi@ximian.com>
25776 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25777 (Invocation::BetterConversion): Same here
25778 (Invocation::ConversionExists): Ditto.
25780 (Invocation::ConversionExists): Implement.
25782 2001-09-22 Ravi Pratap <ravi@ximian.com>
25784 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25785 Also take an additional TypeContainer argument.
25787 * All over : Pass in TypeContainer as argument to OverloadResolve.
25789 * typemanager.cs (CSharpName): Update to check for the string type and return
25792 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25795 2001-09-21 Ravi Pratap <ravi@ximian.com>
25797 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25798 (Invocation::BetterFunction): Implement.
25799 (Invocation::BetterConversion): Implement.
25800 (Invocation::ConversionExists): Skeleton, no implementation yet.
25802 Okay, things work fine !
25804 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25806 * typemanager.cs: declare and load enum_type, delegate_type and
25809 * expression.cs (Expression::Emit): Now emit returns a value that
25810 tells whether a value is left on the stack or not. This strategy
25811 might be reveted tomorrow with a mechanism that would address
25812 multiple assignments.
25813 (Expression::report118): Utility routine to report mismatches on
25816 (Unary::Report23): Report impossible type/operator combination
25819 (Unary::IsIncrementableNumber): Whether the type can be
25820 incremented or decremented with add.
25821 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25823 (Unary::ResolveOperator): Implement ++, !, ~,
25825 (Invocation::Emit): Deal with new Emit convetion.
25827 * All Expression derivatives: Updated their Emit method to return
25828 whether they leave values on the stack or not.
25830 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25831 stack for expressions that are statements.
25833 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25835 * expression.cs (LValue): New interface. Must be implemented by
25837 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25840 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25841 interface for generating code, simplifies the code.
25843 2001-09-20 Ravi Pratap <ravi@ximian.com>
25845 * expression.cs (everywhere): Comment out return statements in ::Resolve
25846 methods to avoid the warnings.
25848 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25850 * driver.cs (parse): Report error 2001 if we can not open the
25853 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25856 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25859 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25860 otherwise nested blocks end up with the same index.
25862 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25864 * expression.cs: Instead of having FIXMEs in the Resolve
25865 functions, throw exceptions so it is obvious that we are facing a
25868 * cs-parser.jay (invocation_expression): Pass Location information.
25870 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25871 Use a basename for those routines because .NET does not like paths
25874 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25877 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25879 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25880 are loading the correct data types (throws an exception if not).
25881 (TypeManager::InitCoreTypes): Use CoreLookupType
25883 * expression.cs (Unary::ResolveOperator): return the child
25884 expression for expressions which are just +expr.
25885 (Unary::ResolveOperator): Return negative literals for -LITERAL
25886 expressions (otherwise they are Unary {Literal}).
25887 (Invocation::Badness): Take into account `Implicit constant
25888 expression conversions'.
25890 * literal.cs (LongLiteral): Implement long literal class.
25891 (IntLiteral): export the `Value' of the intliteral.
25893 2001-09-19 Ravi Pratap <ravi@ximian.com>
25895 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25897 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25898 instead of 'Operator'
25900 * expression.cs (Binary::ResolveOperator): Update accordingly.
25901 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25904 * cs-parser.jay (unary_expression): Update to use the new names.
25906 * gen-treedump.cs (GetUnary): Same here.
25908 * expression.cs (Unary::Resolve): Implement.
25909 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25910 operators are found instead of making noise ;-)
25911 (Unary::ResolveOperator): New method to do precisely the same thing which
25912 Binary::ResolveOperator does for Binary expressions.
25913 (Unary.method, .Arguments): Add.
25914 (Unary::OperName): Implement.
25915 (Unary::ForceConversion): Copy and Paste !
25917 * class.cs (Operator::Define): Fix a small bug for the case when we have
25920 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25921 for the inbuilt operators. Only overloading works for now ;-)
25923 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25925 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25926 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25928 * expression.cs (This::Emit): Implement.
25929 (This::Resolve): Implement.
25930 (TypeOf:Resolve): Implement.
25931 (Expression::ResolveSimpleName): Add an implicit this to instance
25933 (MemberAccess::Resolve): Deal with Parameters and Fields.
25934 Bind instance variable to Field expressions.
25935 (FieldExpr::Instance): New field used to track the expression that
25936 represents the object instance.
25937 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25939 (FieldExpr::Emit): Implement.
25941 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25942 the last instruction contains a return opcode to avoid generating
25943 the last `ret' instruction (this generates correct code, and it is
25944 nice to pass the peverify output).
25946 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25947 initializer for static and instance variables.
25948 (Constructor::Emit): Allow initializer to be null in the case of
25949 static constructors. Only emit initializer for instance
25952 (TypeContainer::FindMembers): Return a null array if there are no
25955 Also fix the code for the MemberTypes.Method branch, as it was not
25956 scanning that for operators (or tried to access null variables before).
25958 * assign.cs (Assign::Emit): Handle instance and static fields.
25962 * driver.cs: Stop compilation if there are parse errors.
25964 * cs-parser.jay (constructor_declaration): Provide default base
25965 initializer for non-static constructors.
25966 (constructor_declarator): Do not provide a default base
25967 initializers if none was specified.
25968 Catch the fact that constructors should not have parameters.
25970 * class.cs: Do not emit parent class initializers for static
25971 constructors, that should be flagged as an error.
25973 2001-09-18 Ravi Pratap <ravi@ximian.com>
25975 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25976 Move back code into TypeContainer::Populate.
25978 2001-09-18 Ravi Pratap <ravi@ximian.com>
25980 * class.cs (TypeContainer::AddConstructor): Fix the check to
25981 compare against Name, not Basename.
25982 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25984 * cs-parser.jay : Update accordingly.
25986 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25987 for methods, don't forget to look into the operators too.
25988 (RegisterMethodBuilder): Helper method to take care of this for
25989 methods, constructors and operators.
25990 (Operator::Define): Completely revamp.
25991 (Operator.OperatorMethod, MethodName): New fields.
25992 (TypeContainer::Populate): Move the registering of builders into
25993 RegisterMethodBuilder.
25994 (Operator::Emit): Re-write.
25996 * expression.cs (Binary::Emit): Comment out code path to emit method
25997 invocation stuff for the case when we have a user defined operator. I am
25998 just not able to get it right !
26000 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26002 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
26005 (Expression::MemberLookup): Provide a version that allows to
26006 specify the MemberTypes and BindingFlags.
26008 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
26009 so it was not fetching variable information from outer blocks.
26011 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
26012 Beforefieldinit as it was buggy.
26014 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
26015 that Ravi put here.
26017 * class.cs (Constructor::Emit): Only emit if block is not null.
26018 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
26019 deal with this by semantically definining it as if the user had
26022 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
26023 constructors as we now "emit" them at a higher level.
26025 (TypeContainer::DefineDefaultConstructor): Used to define the
26026 default constructors if none was provided.
26028 (ConstructorInitializer): Add methods Resolve and Emit.
26030 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
26032 2001-09-17 Ravi Pratap <ravi@ximian.com>
26034 * class.cs (TypeContainer::EmitDefaultConstructor): Register
26035 the default constructor builder with our hashtable for methodbuilders
26038 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
26039 and argument_count is 0 in which case we have a match.
26040 (Binary::ResolveOperator): More null checking and miscellaneous coding
26043 2001-09-17 Ravi Pratap <ravi@ximian.com>
26045 * rootcontext.cs (IsNameSpace): Compare against null.
26047 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
26049 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
26050 and Unary::Operator.
26052 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
26055 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
26056 we have overloaded operators.
26057 (Binary::ResolveOperator): Implement the part which does the operator overload
26060 * class.cs (Operator::Emit): Implement.
26061 (TypeContainer::Emit): Emit the operators we have too.
26063 * expression.cs (Binary::Emit): Update to emit the appropriate code for
26064 the case when we have a user-defined operator.
26066 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26068 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
26070 2001-09-16 Ravi Pratap <ravi@ximian.com>
26072 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
26073 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
26074 (Constructor::Emit): Implement.
26075 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
26076 if we have no work to do.
26077 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
26080 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
26081 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
26083 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
26086 2001-09-15 Ravi Pratap <ravi@ximian.com>
26088 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
26090 (Tree::RecordNamespace): Method to do what the name says ;-)
26091 (Tree::Namespaces): Property to get at the namespaces hashtable.
26093 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
26096 * rootcontext.cs (IsNamespace): Fixed it :-)
26098 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26100 * class.cs (TypeContainer::FindMembers): Add support for
26102 (MethodCore): New class that encapsulates both the shared aspects
26103 of a Constructor and a Method.
26104 (Method, Constructor): Factored pieces into MethodCore.
26106 * driver.cs: Added --fatal which makes errors throw exceptions.
26107 Load System assembly as well as part of the standard library.
26109 * report.cs: Allow throwing exceptions on errors for debugging.
26111 * modifiers.cs: Do not use `parent', instead use the real type
26112 container to evaluate permission settings.
26114 * class.cs: Put Ravi's patch back in. He is right, and we will
26115 have to cope with the
26117 2001-09-14 Ravi Pratap <ravi@ximian.com>
26119 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
26120 FamORAssem, not FamANDAssem.
26122 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26124 * driver.cs: Added --parse option that only parses its input files
26127 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
26128 incorrect. IsTopLevel is not used to tell whether an object is
26129 root_types or not (that can be achieved by testing this ==
26130 root_types). But to see if this is a top-level *class* (not
26131 necessarly our "toplevel" container).
26133 2001-09-14 Ravi Pratap <ravi@ximian.com>
26135 * enum.cs (Enum::Define): Modify to call the Lookup method on the
26136 parent instead of a direct call to GetType.
26138 2001-09-14 Ravi Pratap <ravi@ximian.com>
26140 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
26141 Modifiers.TypeAttr. This should just be a call to that method.
26143 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
26144 object so that we can determine if we are top-level or not.
26146 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
26149 * enum.cs (Enum::Define): Ditto.
26151 * modifiers.cs (FieldAttr): Re-write.
26153 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
26154 (TypeContainer::HaveStaticConstructor): New property to provide access
26155 to precisely that info.
26157 * modifiers.cs (MethodAttr): Re-write.
26158 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
26160 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
26161 of top-level types as claimed.
26163 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26165 * expression.cs (MemberLookup): Fruitless attempt to lookup
26166 constructors. Maybe I need to emit default constructors? That
26167 might be it (currently .NET emits this for me automatically).
26168 (Invocation::OverloadResolve): Cope with Arguments == null.
26169 (Invocation::EmitArguments): new function, shared by the new
26170 constructor and us.
26171 (Invocation::Emit): Handle static and instance methods. Emit
26172 proper call instruction for virtual or non-virtual invocations.
26173 (New::Emit): Implement.
26174 (New::Resolve): Implement.
26175 (MemberAccess:Resolve): Implement.
26176 (MethodGroupExpr::InstanceExpression): used conforming to the spec
26177 to track instances.
26178 (FieldExpr::Resolve): Set type.
26180 * support.cs: Handle empty arguments.
26182 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
26183 SimpleLookup): Auxiliary routines to help parse a qualifier
26186 Update qualifier_identifier rule.
26188 * codegen.cs: Removed debugging messages.
26190 * class.cs: Make this a global thing, this acts just as a "key" to
26191 objects that we might have around.
26193 (Populate): Only initialize method_builders_to_methods once.
26195 * expression.cs (PropertyExpr): Initialize type from the
26198 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
26199 Resolve pattern. Attempt to implicitly convert value to boolean.
26202 * expression.cs: Set the type for the int32/int32 argument case.
26203 (Binary::ResolveOperator): Set the return type to boolean for
26204 comparission operators
26206 * typemanager.cs: Remove debugging print code.
26208 (Invocation::Resolve): resolve type.
26210 * class.cs: Allocate a MemberInfo of the correct size, as the code
26211 elsewhere depends on the test to reflect the correct contents.
26213 (Method::) Keep track of parameters, due to System.Reflection holes
26215 (TypeContainer::Populate): Keep track of MethodBuilders to Method
26218 (TypeContainer::FindMembers): Use ArrayList and then copy an array
26219 of the exact size and return that.
26221 (Class::LookupMethodByBuilder): New function that maps
26222 MethodBuilders to its methods. Required to locate the information
26223 on methods because System.Reflection bit us again.
26225 * support.cs: New file, contains an interface ParameterData and
26226 two implementations: ReflectionParameters and InternalParameters
26227 used to access Parameter information. We will need to grow this
26230 * expression.cs (Invocation::GetParameterData): implement a cache
26231 and a wrapper around the ParameterData creation for methods.
26232 (Invocation::OverloadResolve): Use new code.
26234 2001-09-13 Ravi Pratap <ravi@ximian.com>
26236 * class.cs (TypeContainer::EmitField): Remove and move into
26237 (Field::Define): here and modify accordingly.
26238 (Field.FieldBuilder): New member.
26239 (TypeContainer::Populate): Update accordingly.
26240 (TypeContainer::FindMembers): Implement.
26242 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26244 * statement.cs: (VariableInfo::VariableType): New field to be
26245 initialized with the full type once it is resolved.
26247 2001-09-12 Miguel de Icaza <miguel@ximian.com>
26249 * parameter.cs (GetParameterInfo): Use a type cache to compute
26250 things only once, and to reuse this information
26252 * expression.cs (LocalVariableReference::Emit): Implement.
26253 (OpcodeCast::Emit): fix.
26255 (ParameterReference::Resolve): Implement.
26256 (ParameterReference::Emit): Implement.
26258 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
26259 that are expressions need to stay as Expressions.
26261 * typemanager.cs (CSharpName): Returns the C# name of a type if
26264 * expression.cs (Expression::ConvertImplicit): New function that
26265 implements implicit type conversions.
26267 (Expression::ImplicitReferenceConversion): Implements implicit
26268 reference conversions.
26270 (EmptyCast): New type for transparent casts.
26272 (OpcodeCast): New type for casts of types that are performed with
26273 a sequence of bytecodes.
26275 (BoxedCast): New type used for casting value types into reference
26276 types. Emits a box opcode.
26278 (Binary::DoNumericPromotions): Implements numeric promotions of
26279 and computation of the Binary::Type.
26281 (Binary::EmitBranchable): Optimization.
26283 (Binary::Emit): Implement code emission for expressions.
26285 * typemanager.cs (TypeManager): Added two new core types: sbyte
26288 2001-09-12 Ravi Pratap <ravi@ximian.com>
26290 * class.cs (TypeContainer::FindMembers): Method which does exactly
26291 what Type.FindMembers does, only we don't have to use reflection. No
26292 implementation yet.
26294 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
26295 typecontainer objects as we need to get at them.
26296 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
26298 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
26299 typecontainer object.
26301 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
26302 of just a Report object.
26304 2001-09-11 Ravi Pratap <ravi@ximian.com>
26306 * class.cs (Event::Define): Go back to using the prefixes "add_" and
26308 (TypeContainer::Populate): Now define the delegates of the type too.
26309 (TypeContainer.Delegates): Property to access the list of delegates defined
26312 * delegates.cs (Delegate::Define): Implement partially.
26314 * modifiers.cs (TypeAttr): Handle more flags.
26316 2001-09-11 Ravi Pratap <ravi@ximian.com>
26318 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
26320 (Operator::Define): Re-write logic to get types by using the LookupType method
26321 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
26322 (Indexer::Define): Ditto.
26323 (Event::Define): Ditto.
26324 (Property::Define): Ditto.
26326 2001-09-10 Ravi Pratap <ravi@ximian.com>
26328 * class.cs (TypeContainer::Populate): Now define operators too.
26329 (TypeContainer.Operators): New property to access the list of operators
26331 (Operator.OperatorMethodBuilder): New member to hold the method builder
26332 for the operator we are defining.
26333 (Operator::Define): Implement.
26335 2001-09-10 Ravi Pratap <ravi@ximian.com>
26337 * class.cs (Event::Define): Make the prefixes of the accessor methods
26338 addOn_ and removeOn_
26340 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
26341 of the location being passed in too. Ideally, this should go later since all
26342 error reporting should be done through the Report object.
26344 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
26345 (Populate): Iterate thru the indexers we have and define them too.
26346 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
26347 for the get and set accessors.
26348 (Indexer::Define): Implement.
26350 2001-09-09 Miguel de Icaza <miguel@ximian.com>
26352 * expression.cs (Binary::Resolve): Beginning of it. I scratched
26353 my previous implementation, did not work.
26355 * typemanager.cs: Add a couple of missing types (the longs).
26357 * literal.cs: Use TypeManager.bool_type instead of getting it.
26359 * expression.cs (EventExpr): New kind of expressions.
26360 (Expressio::ExprClassFromMemberInfo): finish
26362 2001-09-08 Miguel de Icaza <miguel@ximian.com>
26364 * assign.cs: Emit stores to static fields differently.
26366 2001-09-08 Ravi Pratap <ravi@ximian.com>
26368 * Merge in changes and adjust code to tackle conflicts. Backed out my
26369 code in Assign::Resolve ;-)
26371 2001-09-08 Ravi Pratap <ravi@ximian.com>
26373 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
26374 instead Report.Error and also pass in the location.
26375 (CSharpParser::Lexer): New readonly property to return the reference
26376 to the Tokenizer object.
26377 (declare_local_variables): Use Report.Error with location instead of plain
26381 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
26382 (Operator.CheckBinaryOperator): Ditto.
26384 * cs-parser.jay (operator_declarator): Update accordingly.
26386 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
26387 (CheckBinaryOperator): Same here.
26389 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
26390 on the name without any prefixes of namespace names etc. This is because we
26391 already might have something already fully qualified like
26392 'System.Console.WriteLine'
26394 * assign.cs (Resolve): Begin implementation. Stuck ;-)
26396 2001-09-07 Ravi Pratap <ravi@ximian.com>
26398 * cs-tokenizer.cs (location): Return a string which also contains
26401 * expression.cs (ElementAccess): New class for expressions of the
26402 type 'element access.'
26403 (BaseAccess): New class for expressions of the type 'base access.'
26404 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
26407 * cs-parser.jay (element_access): Implement action.
26408 (base_access): Implement actions.
26409 (checked_expression, unchecked_expression): Implement.
26411 * cs-parser.jay (local_variable_type): Correct and implement.
26412 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
26414 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
26416 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
26417 name and the specifiers.
26419 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
26421 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
26422 making them all public ;-)
26424 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
26427 2001-09-07 Miguel de Icaza <miguel@ximian.com>
26429 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
26431 (FieldExpr, PropertyExprs): New resolved expressions.
26432 (SimpleName::MemberStaticCheck): Perform static checks for access
26433 to non-static fields on static methods. Maybe this should be
26434 generalized for MemberAccesses.
26435 (SimpleName::ResolveSimpleName): More work on simple name
26438 * cs-parser.jay (primary_expression/qualified_identifier): track
26439 the parameter index.
26441 * codegen.cs (CodeGen::Save): Catch save exception, report error.
26442 (EmitContext::EmitBoolExpression): Chain to expression generation
26443 instead of temporary hack.
26444 (::EmitStatementExpression): Put generic expression code generation.
26446 * assign.cs (Assign::Emit): Implement variable assignments to
26447 local variables, parameters and fields.
26449 2001-09-06 Miguel de Icaza <miguel@ximian.com>
26451 * statement.cs (Block::GetVariableInfo): New method, returns the
26452 VariableInfo for a variable name in a block.
26453 (Block::GetVariableType): Implement in terms of GetVariableInfo
26455 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26456 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26458 2001-09-06 Ravi Pratap <ravi@ximian.com>
26460 * cs-parser.jay (operator_declaration): Continue on my quest : update
26461 to take attributes argument.
26462 (event_declaration): Ditto.
26463 (enum_declaration): Ditto.
26464 (indexer_declaration): Ditto.
26466 * class.cs (Operator::Operator): Update constructor accordingly.
26467 (Event::Event): Ditto.
26469 * delegate.cs (Delegate::Delegate): Same here.
26471 * enum.cs (Enum::Enum): Same here.
26473 2001-09-05 Ravi Pratap <ravi@ximian.com>
26475 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26477 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26479 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26480 being passed around as an arraylist.
26481 (Attributes::AddAttribute): Method to add attribute sections.
26483 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26484 (struct_declaration): Update accordingly.
26485 (constant_declaration): Update.
26486 (field_declaration): Update.
26487 (method_header): Update.
26488 (fixed_parameter): Update.
26489 (parameter_array): Ditto.
26490 (property_declaration): Ditto.
26491 (destructor_declaration): Ditto.
26493 * class.cs (Struct::Struct): Update constructors accordingly.
26494 (Class::Class): Ditto.
26495 (Field::Field): Ditto.
26496 (Method::Method): Ditto.
26497 (Property::Property): Ditto.
26498 (TypeContainer::OptAttribute): update property's return type.
26500 * interface.cs (Interface.opt_attributes): New member.
26501 (Interface::Interface): Update to take the extra Attributes argument.
26503 * parameter.cs (Parameter::Parameter): Ditto.
26505 * constant.cs (Constant::Constant): Ditto.
26507 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26508 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26509 the attributes as a parameter.
26510 (InterfaceProperty): Update constructor call.
26511 (InterfaceEvent): Ditto.
26512 (InterfaceMethod): Ditto.
26513 (InterfaceIndexer): Ditto.
26515 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26516 pass the attributes too.
26517 (interface_event_declaration): Ditto.
26518 (interface_property_declaration): Ditto.
26519 (interface_method_declaration): Ditto.
26520 (interface_declaration): Ditto.
26522 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26524 * class.cs (Method::Define): Track the "static Main" definition to
26525 create an entry point.
26527 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26528 EntryPoint if we find it.
26530 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26531 (EmitContext::ig): Make this variable public.
26533 * driver.cs: Make the default output file be the first file name
26534 with the .exe extension.
26536 Detect empty compilations
26538 Handle various kinds of output targets. Handle --target and
26539 rename -t to --dumper.
26541 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26542 methods inherited from Expression return now an Expression. This
26543 will is used during the tree rewriting as we resolve them during
26546 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26547 the spec. Missing entirely is the information about
26548 accessability of elements of it.
26550 (Expression::ExprClassFromMemberInfo): New constructor for
26551 Expressions that creates a fully initialized Expression based on
26552 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26555 (Invocation::Resolve): Begin implementing resolution of invocations.
26557 * literal.cs (StringLiteral): Implement Emit.
26559 2001-09-05 Ravi Pratap <ravi@ximian.com>
26561 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26564 2001-09-04 Ravi Pratap <ravi@ximian.com>
26566 * cs-parser.jay (attribute_arguments): Implement actions.
26567 (attribute): Fix bug in production. Implement action.
26568 (attribute_list): Implement.
26569 (attribute_target): Implement.
26570 (attribute_target_specifier, opt_target_specifier): Implement
26571 (CheckAttributeTarget): New method to check if the attribute target
26573 (attribute_section): Implement.
26574 (opt_attributes): Implement.
26576 * attribute.cs : New file to handle attributes.
26577 (Attribute): Class to hold attribute info.
26579 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26580 (attribute_section): Modify production to use 2 different rules to
26581 achieve the same thing. 1 s/r conflict down !
26582 Clean out commented, useless, non-reducing dimension_separator rules.
26584 * class.cs (TypeContainer.attributes): New member to hold list
26585 of attributes for a type.
26586 (Struct::Struct): Modify to take one more argument, the attribute list.
26587 (Class::Class): Ditto.
26588 (Field::Field): Ditto.
26589 (Method::Method): Ditto.
26590 (Property::Property): Ditto.
26592 * cs-parser.jay (struct_declaration): Update constructor call to
26593 pass in the attributes too.
26594 (class_declaration): Ditto.
26595 (constant_declaration): Ditto.
26596 (field_declaration): Ditto.
26597 (method_header): Ditto.
26598 (fixed_parameter): Ditto.
26599 (parameter_array): Ditto.
26600 (property_declaration): Ditto.
26602 * constant.cs (Constant::Constant): Update constructor similarly.
26603 Use System.Collections.
26605 * parameter.cs (Parameter::Parameter): Update as above.
26607 2001-09-02 Ravi Pratap <ravi@ximian.com>
26609 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26610 (TypeContainer.delegates): New member to hold list of delegates.
26612 * cs-parser.jay (delegate_declaration): Implement the action correctly
26613 this time as I seem to be on crack ;-)
26615 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26617 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26618 tell whether an identifier represents a namespace.
26620 * expression.cs (NamespaceExpr): A namespace expression, used only
26621 temporarly during expression resolution.
26622 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26623 utility functions to resolve names on expressions.
26625 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26627 * codegen.cs: Add hook for StatementExpressions.
26629 * class.cs: Fix inverted test for static flag in methods.
26631 2001-09-02 Ravi Pratap <ravi@ximian.com>
26633 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26634 to make it coincide with MS' number.
26635 (Operator::CheckBinaryOperator): Ditto.
26637 * ../errors/errors.txt : Remove error numbers added earlier.
26639 * ../errors/cs1019.cs : Test case for error # 1019
26641 * ../errros/cs1020.cs : Test case for error # 1020
26643 * cs-parser.jay : Clean out commented cruft.
26644 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26645 used anywhere - non-reducing rule.
26646 (namespace_declarations): Non-reducing rule - comment out.
26648 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26649 with TypeContainer::AddEnum.
26651 * delegate.cs : New file for delegate handling classes.
26652 (Delegate): Class for declaring delegates.
26654 * makefile : Update.
26656 * cs-parser.jay (delegate_declaration): Implement.
26658 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26660 * class.cs (Event::Define): Implement.
26661 (Event.EventBuilder): New member.
26663 * class.cs (TypeContainer::Populate): Update to define all enums and events
26665 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26666 readonly fields for all these cases ?
26668 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26670 * class.cs (Property): Revamp to use the convention of making fields readonly.
26671 Accordingly modify code elsewhere.
26673 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26674 the Define method of the Property class.
26676 * class.cs : Clean up applied patch and update references to variables etc. Fix
26678 (TypeContainer::Populate): Update to define all the properties we have. Also
26679 define all enumerations.
26681 * enum.cs (Define): Implement.
26683 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26685 * cs-parser.jay (overloadable_operator): The semantic value is an
26686 enum of the Operator class.
26687 (operator_declarator): Implement actions.
26688 (operator_declaration): Implement.
26690 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26691 validity of definitions.
26692 (Operator::CheckBinaryOperator): Static method to check for binary operators
26693 (TypeContainer::AddOperator): New method to add an operator to a type.
26695 * cs-parser.jay (indexer_declaration): Added line to actually call the
26696 AddIndexer method so it gets added ;-)
26698 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26699 already taken care of by the MS compiler ?
26701 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26703 * class.cs (Operator): New class for operator declarations.
26704 (Operator::OpType): Enum for the various operators.
26706 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26708 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26709 ostensibly handle this in semantic analysis.
26711 * cs-parser.jay (general_catch_clause): Comment out
26712 (specific_catch_clauses, specific_catch_clause): Ditto.
26713 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26714 (catch_args, opt_catch_args): New productions.
26715 (catch_clause): Rewrite to use the new productions above
26716 (catch_clauses): Modify accordingly.
26717 (opt_catch_clauses): New production to use in try_statement
26718 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26719 and re-write the code in the actions to extract the specific and
26720 general catch clauses by being a little smart ;-)
26722 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26723 Hooray, try and catch statements parse fine !
26725 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26727 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26728 string from the hashtable of variables.
26730 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26731 I end up making that mistake ;-)
26732 (catch_clauses): Fixed gross error which made Key and Value of the
26733 DictionaryEntry the same : $1 !!
26735 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26737 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26739 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26740 when the add and remove accessors are specified.
26742 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26744 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26745 information about indexer_declarator.
26746 (indexer_declarator): Implement actions.
26747 (parsing_indexer): New local boolean used to keep track of whether
26748 we are parsing indexers or properties. This is necessary because
26749 implicit_parameters come into picture even for the get accessor in the
26750 case of an indexer.
26751 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26753 * class.cs (Indexer): New class for indexer declarations.
26754 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26755 (TypeContainer::indexers): New member to hold list of indexers for the
26758 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26760 * cs-parser.jay (add_accessor_declaration): Implement action.
26761 (remove_accessor_declaration): Implement action.
26762 (event_accessors_declaration): Implement
26763 (variable_declarators): swap statements for first rule - trivial.
26765 * class.cs (Event): New class to hold information about event
26767 (TypeContainer::AddEvent): New method to add an event to a type
26768 (TypeContainer::events): New member to hold list of events.
26770 * cs-parser.jay (event_declaration): Implement actions.
26772 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26774 * cs-parser.jay (dim_separators): Implement. Make it a string
26775 concatenating all the commas together, just as they appear.
26776 (opt_dim_separators): Modify accordingly
26777 (rank_specifiers): Update accordingly. Basically do the same
26778 thing - instead, collect the brackets here.
26779 (opt_rank_sepcifiers): Modify accordingly.
26780 (array_type): Modify to actually return the complete type string
26781 instead of ignoring the rank_specifiers.
26782 (expression_list): Implement to collect the expressions
26783 (variable_initializer): Implement. We make it a list of expressions
26784 essentially so that we can handle the array_initializer case neatly too.
26785 (variable_initializer_list): Implement.
26786 (array_initializer): Make it a list of variable_initializers
26787 (opt_array_initializer): Modify accordingly.
26789 * expression.cs (New::NType): Add enumeration to help us
26790 keep track of whether we have an object/delegate creation
26791 or an array creation.
26792 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26793 members to hold data about array creation.
26794 (New:New): Modify to update NewType
26795 (New:New): New Overloaded contructor for the array creation
26798 * cs-parser.jay (array_creation_expression): Implement to call
26799 the overloaded New constructor.
26801 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26803 * class.cs (TypeContainer::Constructors): Return member
26804 constructors instead of returning null.
26806 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26808 * typemanager.cs (InitCoreTypes): Initialize the various core
26809 types after we have populated the type manager with the user
26810 defined types (this distinction will be important later while
26811 compiling corlib.dll)
26813 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26814 on Expression Classification. Now all expressions have a method
26815 `Resolve' and a method `Emit'.
26817 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26818 generation from working. Also add some temporary debugging
26821 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26823 * codegen.cs: Lots of code generation pieces. This is only the
26824 beginning, will continue tomorrow with more touches of polish. We
26825 handle the fundamentals of if, while, do, for, return. Others are
26826 trickier and I need to start working on invocations soon.
26828 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26831 * codegen.cs (EmitContext): New struct, used during code
26832 emission to keep a context. Most of the code generation will be
26835 * cs-parser.jay: Add embedded blocks to the list of statements of
26836 this block. So code generation proceeds in a top down fashion.
26838 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26840 * statement.cs: Add support for multiple child blocks.
26842 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26844 * codegen.cs (EmitCode): New function, will emit the code for a
26845 Block of code given a TypeContainer and its ILGenerator.
26847 * statement.cs (Block): Standard public readonly optimization.
26848 (Block::Block constructors): Link children.
26849 (Block::Child): Child Linker.
26850 (Block::EmitVariables): Emits IL variable declarations.
26852 * class.cs: Drop support for MethodGroups here, delay until
26854 (Method::): Applied the same simplification that I did before, and
26855 move from Properties to public readonly fields.
26856 (Method::ParameterTypes): Returns the parameter types for the
26857 function, and implements a cache that will be useful later when I
26858 do error checking and the semantic analysis on the methods is
26860 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26861 and made a method, optional argument tells whether this is a class
26862 or a structure to apply the `has-this' bit.
26863 (Method::GetCallingConvention): Implement, returns the calling
26865 (Method::Define): Defines the type, a second pass is performed
26866 later to populate the methods.
26868 (Constructor::ParameterTypes): implement a cache similar to the
26869 one on Method::ParameterTypes, useful later when we do semantic
26872 (TypeContainer::EmitMethod): New method. Emits methods.
26874 * expression.cs: Removed MethodGroup class from here.
26876 * parameter.cs (Parameters::GetCallingConvention): new method.
26878 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26880 * class.cs (TypeContainer::Populate): Drop RootContext from the
26883 (Constructor::CallingConvention): Returns the calling convention.
26884 (Constructor::ParameterTypes): Returns the constructor parameter
26887 (TypeContainer::AddConstructor): Keep track of default constructor
26888 and the default static constructor.
26890 (Constructor::) Another class that starts using `public readonly'
26891 instead of properties.
26893 (Constructor::IsDefault): Whether this is a default constructor.
26895 (Field::) use readonly public fields instead of properties also.
26897 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26898 track of static constructors; If none is used, turn on
26899 BeforeFieldInit in the TypeAttributes.
26901 * cs-parser.jay (opt_argument_list): now the return can be null
26902 for the cases where there are no arguments.
26904 (constructor_declarator): If there is no implicit `base' or
26905 `this', then invoke the default parent constructor.
26907 * modifiers.cs (MethodAttr): New static function maps a set of
26908 modifiers flags into a MethodAttributes enum
26909 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26910 MethodAttr, TypeAttr to represent the various mappings where the
26911 modifiers are used.
26912 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26914 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26916 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26919 * interface.cs (PopulateIndexer): Implemented the code generator
26920 for interface indexers.
26922 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26924 * interface.cs (InterfaceMemberBase): Now we track the new status
26927 (PopulateProperty): Implement property population. Woohoo! Got
26928 Methods and Properties going today.
26930 Removed all the properties for interfaces, and replaced them with
26931 `public readonly' fields.
26933 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26935 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26936 initialize their hashtables/arraylists only when they are needed
26937 instead of doing this always.
26939 * parameter.cs: Handle refs and out parameters.
26941 * cs-parser.jay: Use an ArrayList to construct the arguments
26942 instead of the ParameterCollection, and then cast that to a
26945 * parameter.cs: Drop the use of ParameterCollection and use
26946 instead arrays of Parameters.
26948 (GetParameterInfo): Use the Type, not the Name when resolving
26951 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26953 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26954 and instead use public readonly fields.
26956 * class.cs: Put back walking code for type containers.
26958 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26960 * class.cs (MakeConstant): Code to define constants.
26962 * rootcontext.cs (LookupType): New function. Used to locate types
26965 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26967 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26968 this System.Reflection code is. Kudos to Microsoft
26970 * typemanager.cs: Implement a type cache and avoid loading all
26971 types at boot time. Wrap in LookupType the internals. This made
26972 the compiler so much faster. Wow. I rule!
26974 * driver.cs: Make sure we always load mscorlib first (for
26975 debugging purposes, nothing really important).
26977 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26978 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26980 * rootcontext.cs: Lookup types on their namespace; Lookup types
26981 on namespaces that have been imported using the `using' keyword.
26983 * class.cs (TypeContainer::TypeAttr): Virtualize.
26984 (Class::TypeAttr): Return attributes suitable for this bad boy.
26985 (Struct::TypeAttr): ditto.
26986 Handle nested classes.
26987 (TypeContainer::) Remove all the type visiting code, it is now
26988 replaced with the rootcontext.cs code
26990 * rootcontext.cs (GetClassBases): Added support for structs.
26992 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26994 * interface.cs, statement.cs, class.cs, parameter.cs,
26995 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26996 Drop use of TypeRefs, and use strings instead.
26998 2001-08-04 Miguel de Icaza <miguel@ximian.com>
27002 * class.cs (Struct::Struct): set the SEALED flags after
27003 checking the modifiers.
27004 (TypeContainer::TypeAttr): new property, returns the
27005 TypeAttributes for a class.
27007 * cs-parser.jay (type_list): Oops, list production was creating a
27008 new list of base types.
27010 * rootcontext.cs (StdLib): New property.
27011 (GetInterfaceTypeByName): returns an interface by type name, and
27012 encapsulates error handling here.
27013 (GetInterfaces): simplified.
27014 (ResolveTree): Encapsulated all the tree resolution here.
27015 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
27018 * driver.cs: Add support for --nostdlib, to avoid loading the
27019 default assemblies.
27020 (Main): Do not put tree resolution here.
27022 * rootcontext.cs: Beginning of the class resolution.
27024 2001-08-03 Miguel de Icaza <miguel@ximian.com>
27026 * rootcontext.cs: Provide better error reporting.
27028 * cs-parser.jay (interface_base): set our $$ to be interfaces.
27030 * rootcontext.cs (CreateInterface): Handle the case where there
27031 are no parent interfaces.
27033 (CloseTypes): Routine to flush types at the end.
27034 (CreateInterface): Track types.
27035 (GetInterfaces): Returns an array of Types from the list of
27036 defined interfaces.
27038 * typemanager.c (AddUserType): Mechanism to track user types (puts
27039 the type on the global type hash, and allows us to close it at the
27042 2001-08-02 Miguel de Icaza <miguel@ximian.com>
27044 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
27045 RecordInterface instead.
27047 * cs-parser.jay: Updated to reflect changes above.
27049 * decl.cs (Definition): Keep track of the TypeBuilder type that
27050 represents this type here. Not sure we will use it in the long
27051 run, but wont hurt for now.
27053 * driver.cs: Smaller changes to accomodate the new code.
27055 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
27058 * rootcontext.cs (CreateInterface): New method, used to create
27059 the System.TypeBuilder type for interfaces.
27060 (ResolveInterfaces): new entry point to resolve the interface
27062 (CodeGen): Property, used to keep track of the code generator.
27064 2001-07-26 Miguel de Icaza <miguel@ximian.com>
27066 * cs-parser.jay: Add a second production for delegate_declaration
27069 (enum_body): Put an opt_comma here instead of putting it on
27070 enum_body or enum_member_declarations so we can handle trailing
27071 commas on enumeration members. Gets rid of a shift/reduce.
27073 (type_list): Need a COMMA in the middle.
27075 (indexer_declaration): Tell tokenizer to recognize get/set
27077 * Remove old targets.
27079 * Re-add the parser target.
27081 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27083 * cs-parser.jay: Add precendence rules for a number of operators
27084 ot reduce the number of shift/reduce conflicts in the grammar.
27086 2001-07-17 Miguel de Icaza <miguel@ximian.com>
27088 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
27091 Get rid of old crufty code.
27093 * rootcontext.cs: Use this to keep track of the parsed
27094 representation and the defined types available to the program.
27096 * gen-treedump.cs: adjust for new convention.
27098 * type.cs: Split out the type manager, and the assembly builder
27101 * typemanager.cs: the type manager will live here now.
27103 * cil-codegen.cs: And the code generator here.
27105 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
27107 * makefile: Fixed up for easy making.
27109 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27111 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
27114 (unary_expression): Expand pre_increment_expression and
27115 post_decrement_expression to reduce a shift/reduce.
27117 2001-07-11 Simon Cozens
27119 * cs-tokenizer.cs: Hex numbers should begin with a 0.
27121 Improve allow_keyword_as_indent name.
27123 2001-06-19 Miguel de Icaza <miguel@ximian.com>
27125 * Adjustments for Beta2.
27127 2001-06-13 Miguel de Icaza <miguel@ximian.com>
27129 * decl.cs: Added `Define' abstract method.
27130 (InTransit): new property, used to catch recursive definitions.
27132 * interface.cs: Implement `Define'.
27134 * modifiers.cs: Map Modifiers.constants to
27135 System.Reflection.TypeAttribute flags.
27137 * class.cs: Keep track of types and user-defined types.
27138 (BuilderInit): New method for creating an assembly
27139 (ResolveType): New function to launch the resolution process, only
27140 used by interfaces for now.
27142 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
27143 that are inserted into the name space.
27145 2001-06-08 Miguel de Icaza <miguel@ximian.com>
27147 * ARGH. I have screwed up my tree so many times due to the use of
27148 rsync rather than using CVS. Going to fix this at once.
27150 * driver.cs: Objetify driver. Load assemblies, use assemblies to
27153 2001-06-07 Miguel de Icaza <miguel@ximian.com>
27155 * Experiment successful: Use System.Type rather that our own
27158 2001-05-25 Miguel de Icaza <miguel@ximian.com>
27160 * cs-parser.jay: Removed nsAliases from here.
27162 Use new namespaces, handle `using XXX;'
27164 * namespace.cs: Reimplemented namespace handling, use a recursive
27165 definition of the class. Now we can keep track of using clauses
27166 and catch invalid using clauses.
27168 2001-05-24 Miguel de Icaza <miguel@ximian.com>
27170 * gen-treedump.cs: Adapted for all the renaming.
27172 * expression.cs (Expression): this class now has a Type property
27173 which returns an expression Type.
27175 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
27176 `Type', as this has a different meaning now in the base
27178 2001-05-22 Miguel de Icaza <miguel@ximian.com>
27180 * interface.cs, class.cs: Removed from all the sources the
27181 references to signature computation, as we can not do method
27182 signature computation during the parsing time, as we are not
27183 trying to solve at that point distinguishing:
27187 void a (NS.Blah x) {}
27190 Which depending on the context might be valid or not, as we do not
27191 know if Blah is the same thing as NS.Blah at that point.
27193 * Redid everything so the code uses TypeRefs now instead of
27194 Types. TypeRefs are just temporary type placeholders, that need
27195 to be resolved. They initially have a pointer to a string and the
27196 current scope in which they are used. This is used later by the
27197 compiler to resolve the reference to an actual Type.
27199 * DeclSpace is no longer a CIR.Type, and neither are
27200 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
27201 are all DeclSpaces, but no Types.
27203 * type.cs (TypeRefManager): This implements the TypeRef manager,
27204 which keeps track of all the types that need to be resolved after
27205 the parsing has finished.
27207 2001-05-13 Miguel de Icaza <miguel@ximian.com>
27209 * ARGH. We are going to have to store `foreach' as a class rather
27210 than resolving it, as we need to verify error 1579 after name
27211 resolution. *OR* we could keep a flag that says `This request to
27212 IEnumerator comes from a foreach statement' which we can then use
27213 to generate the error.
27215 2001-05-10 Miguel de Icaza <miguel@ximian.com>
27217 * class.cs (TypeContainer.AddMethod): we now add methods to the
27218 MethodGroup instead of the method hashtable.
27220 * expression.cs: Add MethodGroup abstraction, which gets us one
27221 step closer to the specification in the way we handle method
27224 * cs-parser.jay (primary_expression): qualified_identifier now
27225 tried to match up an identifier to a local variable reference or
27226 to a parameter reference.
27228 current_local_parameters is now a parser global variable that
27229 points to the current parameters for the block, used during name
27232 (property_declaration): Now creates an implicit `value' argument to
27235 2001-05-09 Miguel de Icaza <miguel@ximian.com>
27237 * parameter.cs: Do not use `param' arguments as part of the
27238 signature, per the spec.
27240 2001-05-08 Miguel de Icaza <miguel@ximian.com>
27242 * decl.cs: Base class for classes, structs and interfaces. This
27243 is the "Declaration Space"
27245 * cs-parser.jay: Use CheckDef for checking declaration errors
27246 instead of having one on each function.
27248 * class.cs: Factor out some code for handling error handling in
27249 accordance to the "Declarations" section in the "Basic Concepts"
27250 chapter in the ECMA C# spec.
27252 * interface.cs: Make all interface member classes derive from
27253 InterfaceMemberBase.
27255 2001-05-07 Miguel de Icaza <miguel@ximian.com>
27257 * Many things: all interfaces are parsed and generated in
27258 gen-treedump. Support for member variables, constructors,
27259 destructors, properties, constants is there.
27261 Beginning of the IL backend, but very little done, just there for
27264 2001-04-29 Miguel de Icaza <miguel@ximian.com>
27266 * cs-parser.jay: Fix labeled statement.
27268 * cs-tokenizer.cs (escape): Escape " and ' always.
27269 ref_line, ref_name: keep track of the line/filename as instructed
27270 by #line by the compiler.
27273 2001-04-27 Miguel de Icaza <miguel@ximian.com>
27275 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
27276 to match the values in System.CodeDOM.
27278 Divid renamed to Divide.
27280 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
27282 (Statements.set): remove.
27284 * System.CodeDOM/CodeCatchClause.cs: always have a valid
27287 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
27288 falseStatements always have valid values.
27290 * cs-parser.jay: Use System.CodeDOM now.